* xterm.c (x_draw_underwave): Check for integer overflow.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9a900ca9
PE
12012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xterm.c (x_draw_underwave): Check for integer overflow.
4 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
5
41b7f8bc 62012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
7
8 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
9 referenced (Bug#11583).
10
9b0e3eba
AA
112012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
12
13 Implement wave-style variant of underlining.
14 * dispextern.h (face_underline_type): New enum.
15 (face): Add field for underline type.
16 * nsterm.m (ns_draw_underwave): New function.
17 (ns_draw_text_decoration): Use it.
18 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
19 New functions.
20 (x_draw_glyph_string): Use them.
21 * xfaces.c (Qline, Qwave): New Lisp objects.
22 (check_lface_attrs, merge_face_ref)
23 (Finternal_set_lisp_face_attribute, realize_x_face): Handle
24 wave-style underline face attributes.
25 * xterm.c (x_draw_underwave): New function.
26 (x_draw_glyph_string): Use it.
27
0fb52f11
JB
282012-06-16 Juanma Barranquero <lekktu@gmail.com>
29
30 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
31 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
32 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
33 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
34 ($(BLD)/w32select.$(O)): Update dependencies.
35
e5560ff7
AS
362012-06-16 Andreas Schwab <schwab@linux-m68k.org>
37
38 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
39 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
40 * character.c (_fetch_multibyte_char_p): Remove.
41 * alloc.c: Include "character.h" before "buffer.h".
42 * bidi.c: Likewise.
43 * buffer.c: Likewise.
44 * bytecode.c: Likewise.
45 * callint.c: Likewise.
46 * callproc.c: Likewise.
47 * casefiddle.c: Likewise.
48 * casetab.c: Likewise.
49 * category.c: Likewise.
50 * cmds.c: Likewise.
51 * coding.c: Likewise.
52 * composite.c: Likewise.
53 * dired.c: Likewise.
54 * dispnew.c: Likewise.
55 * doc.c: Likewise.
56 * dosfns.c: Likewise.
57 * editfns.c: Likewise.
58 * emacs.c: Likewise.
59 * fileio.c: Likewise.
60 * filelock.c: Likewise.
61 * font.c: Likewise.
62 * fontset.c: Likewise.
63 * fringe.c: Likewise.
64 * indent.c: Likewise.
65 * insdel.c: Likewise.
66 * intervals.c: Likewise.
67 * keyboard.c: Likewise.
68 * keymap.c: Likewise.
69 * lread.c: Likewise.
70 * macros.c: Likewise.
71 * marker.c: Likewise.
72 * minibuf.c: Likewise.
73 * nsfns.m: Likewise.
74 * nsmenu.m: Likewise.
75 * print.c: Likewise.
76 * process.c: Likewise.
77 * regex.c: Likewise.
78 * region-cache.c: Likewise.
79 * search.c: Likewise.
80 * syntax.c: Likewise.
81 * term.c: Likewise.
82 * textprop.c: Likewise.
83 * undo.c: Likewise.
84 * unexsol.c: Likewise.
85 * w16select.c: Likewise.
86 * w32fns.c: Likewise.
87 * w32menu.c: Likewise.
88 * window.c: Likewise.
89 * xdisp.c: Likewise.
90 * xfns.c: Likewise.
91 * xmenu.c: Likewise.
92 * xml.c: Likewise.
93 * xselect.c: Likewise.
94
2f07e6af
EZ
952012-06-16 Eli Zaretskii <eliz@gnu.org>
96
97 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end. If
98 all the glyphs of the glyph row came from strings, and we have no
99 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
100 row.
101 (handle_face_prop): Use chunk-relative overlay string index when
102 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
103 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
104 the rightmost. (Bug#11720)
2f07e6af 105
29b83cec
AS
1062012-06-16 Andreas Schwab <schwab@linux-m68k.org>
107
108 * category.h (CHAR_HAS_CATEGORY): Define as inline.
109 (CATEGORY_MEMBER): Enforce 1/0 value.
110 * category.c (_temp_category_set): Remove.
111
4c5501e9
EZ
1122012-06-16 Eli Zaretskii <eliz@gnu.org>
113
114 * window.c (Fdelete_other_windows_internal)
115 (Fdelete_window_internal): Don't access frame's mouse highlight
116 info of the initial frame. (Bug#11677)
117
2b570124
PE
1182012-06-14 Paul Eggert <eggert@cs.ucla.edu>
119
e93864f9
PE
120 * .gdbinit (xgetint): Fix recently-introduced paren typo.
121 Assume USE_2_TAGS_FOR_INTS.
122 (xreload): Adjust $tagmask width to match recent lisp.h change.
123
2b570124
PE
124 Simplify lisp.h in minor ways that should not affect code.
125 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
126 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
127 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
128 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
129 (INTTYPEBITS): New macro, for clarity.
130 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
131 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
132 now that USE_LSB_TAG is always defined.
133 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
134 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
135
81755f69
JB
1362012-06-13 Juanma Barranquero <lekktu@gmail.com>
137
138 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
139
16192a57
GM
1402012-06-13 Glenn Morris <rgm@gnu.org>
141
142 * s/bsd-common.h (BSD4_3):
143 * s/usg5-4-common.h (USG5_4): No longer define; unused.
144
646b5f55
AS
1452012-06-13 Andreas Schwab <schwab@linux-m68k.org>
146
147 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
148 instead of union.
149 (XLI, XIL): Define.
150 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
151 them.
152 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
153 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
154 * alloc.c (widen_to_Lisp_Object): Removed.
155 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
156 * frame.c (delete_frame): Remove outdated comment.
157 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
158 USE_LISP_UNION_TYPE.
159 (Fw32_unregister_hot_key): Likewise.
160 (Fw32_toggle_lock_key): Likewise.
161 * w32menu.c (add_menu_item): Likewise.
162 (w32_menu_display_help): Use XIL instead of checking
163 USE_LISP_UNION_TYPE.
164 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
165 (init_heap): Likewise.
166 * w32term.c (w32_read_socket): Update comment.
167
1d3823c9
GM
1682012-06-13 Glenn Morris <rgm@gnu.org>
169
c62ff706
GM
170 * s/usg5-4-common.h, src/s/unixware.h:
171 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
172
1d3823c9
GM
173 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
174
bfe3e0a2
PE
1752012-06-13 Paul Eggert <eggert@cs.ucla.edu>
176
177 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
178 * alloc.c (make_number) [!defined make_number]:
179 Remove, as lisp.h always defines this now.
180 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
181 (roundup_size): Verify that it is a power of 2.
182 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
183 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
184 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
185 -DUSE_LSB_TAG=0, to override the automatically-selected default.
186 USE_LSB_TAG now is always defined to be either 0 or 1.
187 All uses changed.
188 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
189 code works fine either way, and efficiency is not a concern here,
190 as the union type is for debugging, not for production.
191 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
192 Use an inline function on all platforms when using the union type,
193 since this is simpler and 'static inline' can be used portably
194 within Emacs now.
195 (LISP_INITIALLY_ZERO): New macro.
196 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
197 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
198
45fa9c0f
GM
1992012-06-12 Glenn Morris <rgm@gnu.org>
200
b4492cba
GM
201 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
202
203 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 204
45fa9c0f
GM
205 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
206 Move BROKEN_SIGIO to configure.
207
208 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
209 Move NO_TERMIO to configure.
210
0e25d334
CY
2112012-06-12 Chong Yidong <cyd@gnu.org>
212
213 * image.c (imagemagick_load_image): Use MagickFlattenImage if
214 MagickMergeImageLayers is undefined. Use pixel pusher loop if
215 MagickExportImagePixels is undefined.
216
43682bb6
PE
2172012-06-12 Paul Eggert <eggert@cs.ucla.edu>
218
219 * image.c (imagemagick_load_image): Remove unused label.
220
a9be7d2b
GM
2212012-06-11 Glenn Morris <rgm@gnu.org>
222
223 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
224 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
225 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
226 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
227
3017f87f
SM
2282012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
229
230 * alloc.c (make_byte_code): New function.
231 (Fmake_byte_code): Use it. Don't purify here.
232 * lread.c (read1): Use it as well to avoid extra allocation.
233
1b9b4cf4
CY
2342012-06-11 Chong Yidong <cyd@gnu.org>
235
236 * image.c (imagemagick_load_image): Implement transparency.
237
95988fcf
AS
2382012-06-10 Andreas Schwab <schwab@linux-m68k.org>
239
240 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
241 account for preceding backslashes. (Bug#11663)
242
cd4eb164
CY
2432012-06-09 Chong Yidong <cyd@gnu.org>
244
245 * term.c: Support italics in capable terminals (Bug#9652).
246 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
247 (turn_on_face): Output using TS_enter_italic_mode if available.
248 Don't handle unused blinking and alt-charset cases.
249 (turn_off_face): Handle italic case; discard unused tty_blinking_p
250 and tty_alt_charset_p cases.
251 (tty_capable_p, init_tty): Support italics.
252
253 * termchar.h (struct tty_display_info): Add field for italics.
254 Remove unused blink field.
255
256 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
257 Handle slant.
258
259 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
260 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
261 tty_alt_charset_p. Add tty_italic_p.
262
ff88beb8
MA
2632012-06-09 Michael Albinus <michael.albinus@gmx.de>
264
265 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
266 dbus_type_is_basic if available.
267 (xd_extract_signed, xd_extract_unsigned): Rename from
268 extract_signed and extract_unsigned, respectively. Adapt callers.
269
44286096
CY
2702012-06-09 Chong Yidong <cyd@gnu.org>
271
1682701f
CY
272 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
273
44286096
CY
274 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
275 case (Bug#9752).
276
d86feb17
PE
2772012-06-08 Paul Eggert <eggert@cs.ucla.edu>
278
279 * xdisp.c (vmessage): Treat frame message as multibyte.
280 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
281 would generate the diagnostic "Making \302\247 buffer-local while
282 let-bound!".
283
d5c20fe8
EZ
2842012-06-08 Eli Zaretskii <eliz@gnu.org>
285
286 * dispnew.c (showing_window_margins_p): Undo last change, which
287 was done due to an inadvertent commit.
288 (adjust_frame_glyphs_for_frame_redisplay): Do call
289 showing_window_margins_p.
290
513749ee
SM
2912012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
292
293 * eval.c (Fmake_var_non_special): New primitive.
294 (syms_of_eval): Defsubr it.
295 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
296
d4a8f5c1
JB
2972012-06-08 Juanma Barranquero <lekktu@gmail.com>
298
299 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
300 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
301
8bbbc977
EZ
3022012-06-08 Eli Zaretskii <eliz@gnu.org>
303
304 * alloc.c (allocate_vectorlike): Fix last change.
305
f3372c87
DA
3062012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
307
308 Block-based vector allocation of small vectors.
309 * lisp.h (struct vectorlike_header): New field `nbytes',
310 adjust comment accordingly.
311 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
312 to denote vector blocks. Adjust users (live_vector_p,
313 mark_maybe_pointer, valid_lisp_object_p) accordingly.
314 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
315 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
316 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
317 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
318 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
319 (roundup_size): New constant.
320 (struct vector_block): New data type.
321 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 322 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
323 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
324 (sweep_vectors): New functions.
325 (allocate_vectorlike): Return `zero_vector' as the only vector of
326 0 items. Allocate new vector from block if vector size is less than
327 or equal to VBLOCK_BYTES_MAX.
328 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
329 (init_alloc_once): Add call to init_vectors.
330
4f18a4ed
SM
3312012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
332
333 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
334
86f158bc
PE
3352012-06-07 Paul Eggert <eggert@cs.ucla.edu>
336
337 * doprnt.c (doprnt): Truncate multibyte char correctly.
338 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
339 would mishandle a string argument "Xc" if X was a multibyte
340 character of length 2: it would truncate after X's first byte
341 rather than including all of X.
342
c5cfcbe0
CY
3432012-06-06 Chong Yidong <cyd@gnu.org>
344
345 * buffer.c (word_wrap): Doc fix.
346
c05cf390
PE
3472012-06-04 Paul Eggert <eggert@cs.ucla.edu>
348
349 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
350
0c3461de
GM
3512012-06-03 Glenn Morris <rgm@gnu.org>
352
353 * xdisp.c (tool-bar-style): Doc fix.
354
c71232db
UM
3552012-06-03 Ulrich Müller <ulm@gentoo.org>
356
357 * Makefile.in (PAXCTL): Define.
358 (temacs$(EXEEXT)): Disable memory randomization for the temacs
359 binary via PaX flags if the paxctl utility is available.
360 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
361 Restore PaX flags to their default. (Bug#11398)
362
383f7350
CY
3632012-06-03 Chong Yidong <cyd@gnu.org>
364
365 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
366 buffer (Bug#11226).
367
5f2c76c6
CY
3682012-06-03 Chong Yidong <cyd@gnu.org>
369
370 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
371 (note_mode_line_or_margin_highlight): If there is no help echo,
372 use mode-line-default-help-echo. Handle the case where the mouse
373 position is past the end of the mode line string.
374
375 * buffer.c (buffer_local_value_1): New function, split from
376 Fbuffer_local_value; can return Qunbound.
377 (Fbuffer_local_value): Use it.
378 (Vmode_line_format): Docstring tweaks.
379
773d47f6
PE
3802012-06-02 Paul Eggert <eggert@cs.ucla.edu>
381
382 * sysdep.c (system_process_attributes): Improve comment.
383
f2d6a3df
SM
3842012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
385
386 * keyboard.c: Export real-this-command to Elisp.
387 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
388 and DEFVAR it. Update all users.
389
63810350
PE
3902012-06-02 Paul Eggert <eggert@cs.ucla.edu>
391
7bd5c1f4
PE
392 * minibuf.c (Fassoc_string): Remove duplicate declaration.
393
63810350
PE
394 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
395 Convert pctcpu and pctmem to Lisp float properly.
396 Let the compiler fold better, as 100.0/0x8000 is exact.
397
a2821611
AS
3982012-06-02 Andreas Schwab <schwab@linux-m68k.org>
399
400 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
401 cons_block.
402
5fceba1d
PE
4032012-06-01 Paul Eggert <eggert@cs.ucla.edu>
404
405 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
406
c98ff5dd
DA
4072012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
408
409 For a 'struct window', replace some Lisp_Object fields to
410 bitfields where appropriate, remove unused fields.
411 * window.h (struct window): Remove unused 'last_mark_x' and
412 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
413 change it's type from Lisp_Object to bitfield.
414 Change type of 'force_start', 'optional_new_start',
415 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
416 fields from Lisp_Object to bitfield. Adjust users accordingly.
417
ca34e0be
PE
4182012-05-31 Paul Eggert <eggert@cs.ucla.edu>
419
420 Pacify gcc -Wdouble-precision when using Xaw.
421 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
422 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
423 Use 'float' consistently, rather than 'float' in most places
424 and 'double' in a couple of places.
425
efc00ab1 4262012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
427
428 * xdisp.c (handle_stop): Detect whether we have overlay strings
429 loaded by testing it->current.overlay_string_index to be
430 non-negative, instead of checking whether n_overlay_strings is
431 positive. (Bug#11587)
432
efc00ab1 4332012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
434
435 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
436
437 * doc.c (Fsubstitute_command_keys): Doc fix.
438
efc00ab1 4392012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
440
441 * search.c (search_buffer): Remove calls to
442 r_alloc_inhibit_buffer_relocation, as it is now called by
443 maybe_unify_char, which was the cause of relocation of buffer text
444 in bug#11519.
445
efc00ab1 4462012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
447
448 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
449 for the duration of call to load_charset, to avoid problems with
450 callers of maybe_unify_char that access buffer text through C
451 pointers.
452
453 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
454 decrement the inhibition flag, instead of just setting or
455 resetting it.
456
ba93a187
PE
4572012-05-31 Paul Eggert <eggert@cs.ucla.edu>
458
459 Remove obsolete '#define static' cruft.
460 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
461 This #undef was "temporary" in 2000; it is no longer needed
462 now that '#define static' has gone away.
463 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
464 (gray_bitmap_bits): Remove; no longer needed.
465 All uses replaced with definiens.
466 * xterm.c: Include "bitmaps/gray.xbm".
467
9e4bf381
PE
4682012-05-30 Paul Eggert <eggert@cs.ucla.edu>
469
470 Clean up __executable_start, monstartup when --enable-profiling.
471 The following changes affect the code only when profiling.
472 * dispnew.c (__executable_start): Rename from safe_bcopy.
473 Define only on platforms that need it.
474 * emacs.c: Include <sys/gmon.h> when profiling.
475 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
476 (__executable_start): Remove decl, since lisp.h does it now.
477 (safe_bcopy): Remove decl; no longer has that name.
478 (main): Coalesce #if into single bit of code, for simplicity.
479 Cast pointers to uintptr_t, since standard libraries want integers
480 and not pointers.
481 * lisp.h (__executable_start): New decl.
482
32d72c2f
GM
4832012-05-31 Glenn Morris <rgm@gnu.org>
484
485 * image.c (Fimagemagick_types): Doc fix.
486
baac5bc7
JM
4872012-05-30 Jim Meyering <meyering@redhat.com>
488
489 * callproc.c (Fcall_process_region): Include directory component
490 in mkstemp error message (Bug#11586).
491
72cb32cf
PE
4922012-05-30 Paul Eggert <eggert@cs.ucla.edu>
493
494 * alloc.c, lisp.h (make_pure_vector): Now static.
495
61b108cc
SM
4962012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
497
498 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
499 Move to byte-run.el.
500 (Fautoload): Do the hash-doc more carefully.
501 * data.c (Fdefalias): Purify definition, except for keymaps.
502 (Qdefun): Move from eval.c.
503 * lisp.h (Qdefun): Remove.
504 * lread.c (read1): Tiny simplification.
505
471fe23d
TN
5062012-05-29 Troels Nielsen <bn.troels@gmail.com>
507
934f3f58 508 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
509 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
510 Bug#9642, but explicitly check that the buffer the overlay would
511 be moved to is live and rearrange lines to make sure that errors
512 will not put the overlay in an inconsistent state.
513 (Fdelete_overlay): Cosmetics.
514
85d0efd1
EZ
5152012-05-28 Eli Zaretskii <eliz@gnu.org>
516
517 * w32term.c (my_bring_window_to_top): New function.
518 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
519 could be different from the original one.
520 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
521 (Bug#11513)
522
523 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
524 by calling BringWindowToTop.
525
526 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
527 (WM_EMACS_END): Increase by one.
528
da92a98c
PE
5292012-05-28 Paul Eggert <eggert@cs.ucla.edu>
530
531 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
532 This avoids undefined behavior that might cause the eassert
533 to not catch an out-of-range value.
534
74d1f848
JB
5352012-05-28 Juanma Barranquero <lekktu@gmail.com>
536
537 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
538 Update dependencies.
539
9e1a06fc
EZ
5402012-05-27 Eli Zaretskii <eliz@gnu.org>
541
542 * bidi.c (bidi_mirror_char): Fix last change.
543
f3dd7312
AS
5442012-05-27 Andreas Schwab <schwab@linux-m68k.org>
545
546 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
547 when referring to sectname field in printf format.
548
81899c91
PE
5492012-05-27 Paul Eggert <eggert@cs.ucla.edu>
550
57b81a9f
PE
551 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
552 Only r_alloc_inhibit_buffer_relocation needed to be added;
553 the others were already declared.
554
81899c91
PE
555 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
556 before checking whether it's out of range. Put the check inside
557 eassert. See
558 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
559
33017faf 5602012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
561
562 * callproc.c (Fcall_process): Restore a line that was accidentally
563 commented out in the 2011-02-13 change (bug#11547).
564
33017faf 5652012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
566
567 * lisp.h [REL_ALLOC]: Add prototypes for external functions
568 defined on ralloc.c.
569
570 * buffer.c [REL_ALLOC]: Remove prototypes of
571 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
572 they are now on lisp.h.
573
574 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
575
576 * search.c (search_buffer): Use it to inhibit relocation of buffer
577 text while re_search_2 is doing its job, because re_search_2 is
578 passed C pointers to buffer text. (Bug#11519)
579
23415acf
EZ
580 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
581 Update value to 24.
582
44e27368
EZ
583 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
584 state after an additional call to move_it_in_display_line_to, keep
585 the values of it->max_ascent and it->max_descent found for the
586 entire line.
587 (pos_visible_p): Revert the comparison against bottom_y to what it
588 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
589 (Bug#11464)
590
c1892f11
PE
5912012-05-26 Paul Eggert <eggert@cs.ucla.edu>
592
593 Fix coding-related core dumps with gcc -ftrapv.
594 The code was computing A - B, where A and B are pointers, and B is
595 random garbage. This can lead to core dumps on platforms that
596 have special pointer registers, and it also leads to core dumps on
597 x86-64 when compiled with gcc -ftrapv. The fix is to compute
598 A - B only when B is initialized properly.
599 * coding.c (coding_set_source, coding_set_destination): Return void.
600 (coding_change_source, coding_change_destinations): New functions,
601 with the old behaviors of coding_set_source and coding_set_destination.
602 All callers that need an offset changed to use these new functions.
603
eb7afdad
GM
6042012-05-26 Glenn Morris <rgm@gnu.org>
605
606 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
607
f12fdf02
EZ
6082012-05-26 Eli Zaretskii <eliz@gnu.org>
609
53a63be6 610 Extend mouse support on W32 text-mode console.
61b108cc
SM
611 * xdisp.c (draw_row_with_mouse_face):
612 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 613
eb3f6f01 614 * w32console.c: Include window.h.
61b108cc
SM
615 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
616 New functions.
eb3f6f01
EZ
617 (initialize_w32_display): Initialize mouse-highlight data.
618
53a63be6
EZ
619 * w32inevt.c: Include termchar.h and window.h.
620 (do_mouse_event): Support mouse-autoselect-window. When the mouse
621 moves, call note_mouse_highlight. If help_echo changed, call
622 gen_help_event to produce help-echo message in the echo area.
623 Call clear_mouse_face if mouse_face_hidden is set in the mouse
624 highlight info.
625
4cfd81f6
PE
6262012-05-26 Paul Eggert <eggert@cs.ucla.edu>
627
628 * lread.c (read1): Simplify slightly to avoid an overflow warning
629 with GCC 4.7.0 on x86-64.
630
4446092a
EZ
6312012-05-26 Eli Zaretskii <eliz@gnu.org>
632
633 * bidi.c (bidi_mirror_char): Revert last change: an int is
634 definitely wide enough here.
635
42b2a986 6362012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 637
42b2a986 638 Fix integer width and related bugs (Bug#9874).
eb106a49 639 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
640 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
641 (string_bytes, check_sblock, allocate_string_data):
642 (compact_small_strings, Fmake_bool_vector, make_string)
643 (make_unibyte_string, make_multibyte_string)
644 (make_string_from_bytes, make_specified_string)
645 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
646 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
647 (mark_vectorlike):
648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
649 (allocate_pseudovector):
650 Use int, not EMACS_INT, where int is wide enough.
651 (inhibit_garbage_collection, Fgarbage_collect):
652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
653 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
654 int might not be wide enough.
655 (bidi_cache_search, bidi_cache_find, bidi_init_it)
656 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
657 (bidi_at_paragraph_end, bidi_find_paragraph_start)
658 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
659 (bidi_level_of_next_char, bidi_move_to_visually_next):
660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
661 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
662 (Fkill_buffer, Fset_buffer_major_mode)
663 (advance_to_char_boundary, Fbuffer_swap_text)
664 (Fset_buffer_multibyte, overlays_at, overlays_in)
665 (overlay_touches_p, struct sortvec, record_overlay_string)
666 (overlay_strings, recenter_overlay_lists)
667 (adjust_overlays_for_insert, adjust_overlays_for_delete)
668 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
669 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
670 (Foverlay_recenter, last_overlay_modification_hooks_used)
671 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
673 (validate_region): Omit unnecessary test for b <= e,
674 since that's guaranteed by the previous test.
d311d28c
PE
675 (adjust_overlays_for_delete): Avoid pos + length overflow.
676 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
677 (report_overlay_modification):
678 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
679 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
680 Omit pointer cast, which isn't needed anyway, and doesn't work
681 after the EMACS_INT -> ptrdiff_t change.
02481186 682 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
683 * buffer.h: Adjust decls to match defn changes elsewhere.
684 (struct buffer_text, struct buffer):
685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
686 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
687 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
688 not int, to avoid needless 32-bit limit on 64-bit hosts.
689 (exec_byte_code): Use tighter memory-full test, one that checks
690 for alloca overflow. Don't compute the address of the object just
691 before an array, as that's not portable. Use EMACS_INT, not
692 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
693 * callint.c (Fcall_interactively):
694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
695 * callproc.c (call_process_kill, Fcall_process):
696 Don't assume pid_t fits into an Emacs fixnum.
697 (call_process_cleanup, Fcall_process, child_setup):
698 Don't assume pid_t fits into int.
699 (call_process_cleanup, Fcall_process, delete_temp_file)
700 (Fcall_process_region):
701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
702 (Fcall_process): Simplify handling of volatile integers.
703 Use int, not EMACS_INT, where int will do.
704 * casefiddle.c (casify_object, casify_region, operate_on_word)
705 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
707 (casify_object): Avoid integer overflow when overallocating buffer.
708 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 709 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
710 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
711 * category.h (CATEGORYP): Don't assume arg is nonnegative.
712 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
713 integers are now checked earlier. All uses replaced with XINT.
714 (ccl_driver):
715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
716 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
717 (ccl_driver, Fregister_code_conversion_map):
718 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
719 (resolve_symbol_ccl_program): Check that vector header is in range.
720 Always copy the vector, so that we can check its contents reliably
721 now rather than having to recheck each instruction as it's being
722 executed. Check that vector words fit in 'int'.
723 (ccl_get_compiled_code, Fregister_ccl_program)
724 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
725 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
726 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
727 contents are in range.
728 (Fccl_execute_on_string): Check that status is in range.
729 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
730 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
731 Accept and return EMACS_INT, not int, because callers can pass values
732 out of 'int' range.
733 (c_string_width, strwidth, lisp_string_width, chars_in_text)
734 (multibyte_chars_in_text, parse_str_as_multibyte)
735 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
736 (str_as_unibyte, str_to_unibyte, string_count_byte8)
737 (string_escape_byte8, Fget_byte):
738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 739 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
740 avoid mishandling large integers.
741 * character.h: Adjust decls to match defn changes elsewhere.
742 * charset.c (load_charset_map_from_file, find_charsets_in_text)
743 (Ffind_charset_region):
744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
745 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
746 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 747 Don't assume fixnum fits in int.
d311d28c
PE
748 (load_charset_map_from_vector, Fmap_charset_chars):
749 Remove now-unnecessary CHECK_NATNUMs.
750 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
751 Don't rely on undefined behavior with signed left shift overflow.
752 Don't assume unsigned int fits into fixnum, or that fixnum fits
753 into unsigned int. Don't require max_code to be a valid fixnum;
754 that's not true for gb10830 4-byte on a 32-bit host. Allow
755 invalid_code to be a cons, for the same reason. Require code_offset
756 to be a character. Avoid int overflow if max_char is close
757 to INT_MAX.
758 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
759 this is intended anyway and avoids some undefined behavior.
760 (load_charset_map): Pass unsigned, not int, as 2nd arg of
761 INDEX_TO_CODE_POINT, as that's what it expects.
762 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
763 * charset.h (DECODE_CHAR): Return int, not unsigned;
764 this is what was intended anyway, and it avoids undefined behavior.
765 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
766 integer-overflow issues.
767 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
768 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
769 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
770 * chartab.c (Fmake_char_table, Fset_char_table_range)
771 (uniprop_get_decoder, uniprop_get_encoder):
772 Don't assume fixnum fits in int.
773 * cmds.c (move_point): New function, that does the gist of
774 Fforward_char and Fbackward_char, but does so while checking
775 for integer overflow more accurately.
c96e5d6a 776 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
777 (Fforward_line, Fend_of_line, internal_self_insert)
778 (internal_self_insert):
779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
780 Fix a FIXME, by checking for integer overflow when calculating
781 target_clm and actual_clm.
782 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 783 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
784 (ASSURE_DESTINATION, coding_alloc_by_realloc)
785 (coding_alloc_by_making_gap, alloc_destination)
786 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
787 (encode_coding_utf_16, detect_coding_emacs_mule)
788 (decode_coding_emacs_mule, encode_coding_emacs_mule)
789 (detect_coding_iso_2022, decode_coding_iso_2022)
790 (encode_invocation_designation, encode_designation_at_bol)
791 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
792 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
793 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
794 (encode_coding_ccl, encode_coding_raw_text)
795 (detect_coding_charset, decode_coding_charset)
796 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
797 (produce_composition, produce_charset, produce_annotation)
798 (decode_coding, handle_composition_annotation)
799 (handle_charset_annotation, consume_chars, decode_coding_gap)
800 (decode_coding_object, encode_coding_object, detect_coding_system)
801 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
802 (code_convert_region, code_convert_string)
8f50130c
PE
803 (Fdefine_coding_system_internal)
804 (coding_set_source, coding_set_destination):
d311d28c
PE
805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
806 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
807 (Fdefine_coding_system_internal):
808 Don't assume fixnums fit in int.
809 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 810 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
811 (Funencodable_char_position, Fcheck_coding_systems_region)
812 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 814 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 815 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 816 Don't access memory outside of the args array.
d311d28c 817 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
818 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
819 result of ENCODE_CHAR.
d311d28c
PE
820 * coding.h: Adjust decls to match defn changes elsewhere.
821 (struct coding_system):
822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
823 * composite.c (get_composition_id, find_composition)
824 (run_composition_function, update_compositions)
825 (compose_text, composition_gstring_put_cache)
826 (composition_gstring_p, composition_gstring_width)
827 (fill_gstring_header, fill_gstring_body, autocmp_chars)
828 (composition_compute_stop_pos, composition_reseat_it)
829 (composition_update_it, struct position_record)
830 (find_automatic_composition, composition_adjust_point)
831 (Fcomposition_get_gstring, Ffind_composition_internal):
832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
833 (update_compositions):
834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
835 * composite.h: Adjust decls to match defn changes elsewhere.
836 (struct composition):
837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
838 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
839 Do not attempt to compute the address of the object just before a
840 buffer; this is not portable.
841 (Faref, Faset):
842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
843 (Faset): Use int, not EMACS_INT, where int is wide enough.
844 (Fstring_to_number): Don't assume fixnums fit in int.
845 (Frem): Don't assume arg is nonnegative.
846 * dbusbind.c (xd_append_arg): Check for integers out of range.
847 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 848 (extract_signed, extract_unsigned): New functions.
243e0530
PE
849 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
850 (xd_get_connection_references): Return ptrdiff_t, not int.
851 All uses changed.
852 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
853 (xd_read_message_1):
854 Use int, not unsigned, where the dbus API uses int.
855 (Fdbus_message_internal): Don't overflow mtype.
856 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
857 * dired.c (directory_files_internal, file_name_completion, scmp)
858 (file_name_completion_stat):
859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
860 (file_name_completion): Don't overflow matchcount.
861 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
862 * dispextern.h: Adjust decls to match defn changes elsewhere.
863 (struct text_pos, struct glyph, struct bidi_saved_info)
864 (struct bidi_string_data, struct bidi_it, struct composition_it)
865 (struct it):
866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
867 (struct display_pos, struct composition_it, struct it):
868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
869 * dispnew.c (increment_matrix_positions)
870 (increment_row_positions, mode_line_string)
871 (marginal_area_string):
872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 873 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
875 (duration_to_sec_usec): New function, to check for overflow better.
876 (Fsleep_for, sit_for): Use it.
877 * doc.c (get_doc_string, store_function_docstring):
878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
879 (get_doc_string, Fsnarf_documentation):
880 Use int, not EMACS_INT, where int is wide enough.
881 (get_doc_string):
882 Use SAFE_ALLOCA, not alloca.
883 Check for overflow when converting EMACS_INT to off_t.
884 * doprnt.c (doprnt):
885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
886 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
887 Don't assume uid_t fits into fixnum.
888 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
889 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
890 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
891 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
892 (general_insert_function)
893 (Finsert_char, make_buffer_string, make_buffer_string_both)
894 (update_buffer_properties, Fbuffer_substring)
895 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
896 (Fsubst_char_in_region, check_translation)
897 (Ftranslate_region_internal, save_restriction_restore, Fformat)
898 (transpose_markers, Ftranspose_regions):
899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
900 (clip_to_bounds): Move to lisp.h as an inline function).
901 (Fconstrain_to_field): Don't assume integers are nonnegative.
902 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
903 (Fsubst_char_in_region, Fsave_restriction):
904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
905 (Femacs_pid): Don't assume pid_t fits into fixnum.
906 (lo_time): Use int, not EMACS_INT, when int suffices.
907 (lisp_time_argument): Check for usec out of range.
908 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
909 (Fuser_login_name, Fuser_full_name): Signal an error
910 if a uid argument is out of range, rather than relying on
911 undefined behavior.
c8d5c857
PE
912 (Fformat_time_string): Remove now-unnecessary check.
913 lisp_time_argument checks for out-of-range usec now.
243e0530 914 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
915 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
916 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
917 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
918 (init_cmdargs, Fdump_emacs):
919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
920 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
921 the bottom (typically) 32 bits of the fixnum.
922 * eval.c (specpdl_size, call_debugger):
923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
924 (when_entered_debugger, Fbacktrace_debug):
925 Don't assume fixnum can fit in int.
926 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
927 the object just before a buffer; this is not portable.
928 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
929 (grow_specpdl, unbind_to):
930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
931 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
932 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 933 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
934 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
935 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
937 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
938 (a_write, e_write):
939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
940 (Fcopy_file, non_regular_nbytes, read_non_regular)
941 (Finsert_file_contents):
942 Use int, not EMACS_INT, where int is wide enough.
943 (READ_BUF_SIZE): Verify that it fits in int.
944 (Finsert_file_contents): Check that counts are in proper range,
945 rather than assuming fixnums fit into ptrdiff_t etc.
946 Don't assume fixnums fit into int.
125b3835 947 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
948 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
949 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
950 (string_char_to_byte, string_byte_to_char)
951 (string_make_multibyte, string_to_multibyte)
952 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
953 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
954 (substring_both, Fdelete, internal_equal, Ffillarray)
955 (Fclear_string, mapcar1)
956 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
957 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
958 (larger_vector, make_hash_table, maybe_resize_hash_table)
959 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
960 (Fmaphash, secure_hash):
961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
962 (concat): Check for string index and length overflow.
963 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
964 (Frequire):
965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
966 (larger_vector): New API (vec, incr_min, size_max) replaces old
967 one (vec, new_size, init). This catches size overflow.
968 INIT was removed because it was always Qnil.
969 All callers changed.
970 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
971 the upper bound on a hash table index size.
972 (make_hash_table, maybe_resize_hash_table): Use it.
973 (secure_hash): Computer start_byte and end_byte only after
974 they're known to be in ptrdiff_t range.
975 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
976 (Ffont_get_glyphs, Ffont_at):
977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
978 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
979 (Flist_fonts, Fopen_font):
980 Don't assume fixnum can fit in int.
981 (check_gstring): Don't assume index can fit in int.
982 (font_match_p): Check that fixnum is a character, not a nonnegative
983 fixnum, since the later code needs to stuff it into an int.
984 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
985 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
986 conversion overflow issues.
987 (Fopen_font): Check for integer out of range.
988 (Ffont_get_glyphs): Don't assume index can fit in int.
989 * font.h: Adjust decls to match defn changes elsewhere.
990 * fontset.c (reorder_font_vector): Redo score calculation to avoid
991 integer overflow.
992 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
993 printmax_t, where ptrdiff_t is wide enough.
994 (Finternal_char_font):
995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
996 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
997 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
998 (Fset_frame_position, x_set_frame_parameters)
999 (x_set_line_spacing, x_set_border_width)
1000 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1001 Check that fixnums are in proper range for system types.
1002 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1004 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1005 Use SAFE_ALLOCA_LISP, not alloca.
1006 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1007 intptr_t is wide enough.
1008 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1009 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1010 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1011 Check for fixnum out of range.
1012 * ftfont.c (ftfont_list): Don't assume index fits in int.
1013 Check that fixnums are in proper range for system types.
1014 (ftfont_shape_by_flt):
1015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1016 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1018 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1019 Check that fixnums are in proper range for system types.
1020 * gnutls.h: Adjust decls to match defn changes elsewhere.
1021 * gtkutil.c (xg_dialog_run):
1022 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1023 (update_frame_tool_bar):
1024 Check that fixnums are in proper range for system types.
1025 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1026 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1027 * indent.c (last_known_column, last_known_column_point):
1028 (current_column_bol_cache):
1029 (skip_invisible, current_column, check_display_width):
1030 (check_display_width, scan_for_column, current_column_1)
1031 (Findent_to, Fcurrent_indentation, position_indentation)
1032 (indented_beyond_p, Fmove_to_column, compute_motion):
1033 (Fcompute_motion, Fvertical_motion):
1034 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1035 (last_known_column_modified): Use EMACS_INT, not int.
1036 (check_display_width):
1037 (Fcompute_motion):
1038 Check that fixnums and floats are in proper range for system types.
1039 (compute_motion): Don't assume index or fixnum fits in int.
1040 (compute_motion, Fcompute_motion):
1041 Use int, not EMACS_INT, when it is wide enough.
1042 (vmotion): Omit local var start_hpos that is always 0; that way
1043 we don't need to worry about overflow in expressions involving it.
1044 * indent.h: Adjust decls to match defn changes elsewhere.
1045 (struct position):
1046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1047 Use int, not EMACS_INT, where int is wide enough.
1048 Remove unused members ovstring_chars_done and tab_offset;
1049 all uses removed.
1050 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1051 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1052 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1053 (make_gap, copy_text, insert, insert_and_inherit)
1054 (insert_before_markers, insert_before_markers_and_inherit)
1055 (insert_1, count_combining_before, count_combining_after)
1056 (insert_1_both, insert_from_string)
1057 (insert_from_string_before_markers, insert_from_string_1)
1058 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1059 (adjust_after_replace, adjust_after_insert, replace_range)
1060 (replace_range_2, del_range, del_range_1, del_range_byte)
1061 (del_range_both, del_range_2, modify_region)
1062 (prepare_to_modify_buffer, signal_before_change)
1063 (signal_after_change, Fcombine_after_change_execute):
1064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1065 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1066 (balance_an_interval, split_interval_right, split_interval_left)
1067 (find_interval, next_interval, update_interval)
1068 (adjust_intervals_for_insertion, delete_node, delete_interval)
1069 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1070 (static_offset_intervals, offset_intervals)
1071 (merge_interval_right, merge_interval_left, make_new_interval)
1072 (graft_intervals_into_buffer, temp_set_point_both)
1073 (temp_set_point, set_point, adjust_for_invis_intang)
1074 (set_point_both, move_if_not_intangible, get_property_and_range)
1075 (get_local_map, copy_intervals, copy_intervals_to_string)
1076 (compare_string_intervals, set_intervals_multibyte_1):
1077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1078 * intervals.h: Adjust decls to match defn changes elsewhere.
1079 (struct interval):
1080 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1081 * keyboard.c (this_command_key_count, this_single_command_key_start)
1082 (before_command_key_count, before_command_echo_length, echo_now)
1083 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1084 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1085 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1086 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1088 (last_non_minibuf_size, last_point_position, echo_truncate)
1089 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1090 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1091 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1092 (stuff_buffered_input):
1093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1094 (last_auto_save, command_loop_1, read_char):
1095 Use EMACS_INT, not int, to avoid integer overflow.
1096 (record_char): Avoid overflow in total_keys computation.
1097 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1098 * keyboard.h: Adjust decls to match defn changes elsewhere.
1099 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1100 (Fkey_description, Fdescribe_vector, Flookup_key):
1101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1102 (click_position): New function, to check that positions are in range.
1103 (Fcurrent_active_maps):
1104 (describe_command):
1105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1106 (Faccessible_keymaps, Fkey_description):
1107 (preferred_sequence_p):
1108 Don't assume fixnum can fit into int.
1109 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1110 Check for integer overflow in size calculations.
1111 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1112 avoid mishandling large integers.
1113 * lisp.h: Adjust decls to match defn changes elsewhere.
1114 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1115 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1116 (struct Lisp_Marker):
1117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1118 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1119 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1120 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1121 All callers changed.
1122 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1123 Assume the arg has valid form, since it always does.
1124 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1125 unsigned integer system type.
1126 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1127 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1129 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1130 (duration_to_sec_usec): New decl.
1131 * lread.c (read_from_string_index, read_from_string_index_byte)
1132 (read_from_string_limit, readchar, unreadchar, openp)
1133 (read_internal_start, read1, oblookup):
1134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1135 (Fload, readevalloop, Feval_buffer, Feval_region):
1136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1137 (openp): Check for out-of-range argument to 'access'.
1138 (read1): Use int, not EMACS_INT, where int is wide enough.
1139 Don't assume fixnum fits into int.
6efdadfd 1140 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1141 (read_filtered_event): Use duration_to_sec_usec
1142 to do proper overflow checking on durations.
d311d28c
PE
1143 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1144 in size calculation.
1145 (Fexecute_kbd_macro):
1146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1147 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1148 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1149 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1150 (set_marker_both, set_marker_restricted_both, marker_position)
1151 (marker_byte_position, Fbuffer_has_markers_at):
1152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1153 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1154 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1155 It now merely ensures that the menu is large enough, without
1156 necessarily growing it, as this avoids some integer overflow issues.
1157 All callers changed.
1158 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1160 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1161 Use SAFE_ALLOCA_LISP, not alloca.
1162 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1163 to EMACS_INT. Check that fixnums are in proper range for system types.
1164 * minibuf.c (minibuf_prompt_width, string_to_object)
1165 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1166 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1168 (get_minibuffer, read_minibuf_unwind):
1169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1170 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1171 this simplifies overflow checking. All callers changed.
1172 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1173 (Ftest_completion):
1174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1175 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1176 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1177 Check that fixnums are in proper range for system types.
1178 (Fx_create_frame, Fx_show_tip):
1179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1180 * nsfont.m (ns_findfonts, nsfont_list_family):
1181 Don't assume fixnum fits in long.
1182 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1184 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1185 wide enough.
17fdb222 1186 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1188 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1189 (PRINTDECLARE, PRINTPREPARE):
1190 (strout, print_string):
1191 (print, print_preprocess, print_check_string_charset_prop)
1192 (print_object):
1193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1194 (PRINTDECLARE):
1195 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1197 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1198 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1199 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1200 (print_error_message): Use SAFE_ALLOCA, not alloca.
1201 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1202 (print_depth, new_backquote_output, print_number_index):
1203 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1204 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1205 (Fset_process_window_size, Fformat_network_address)
1206 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1207 (sigchld_handler):
d311d28c 1208 Check that fixnums are in proper range for system types.
d44287d4 1209 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1210 Check for process-ids out of pid_t range rather than relying on
1211 undefined behavior.
e4d81efc 1212 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1213 (Fformat_network_address, read_process_output, send_process)
1214 (Fprocess_send_region, status_notify):
1215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1216 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1217 (wait_reading_process_output, read_process_output, exec_sentinel):
1218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1219 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1220 (Faccept_process_output): Use duration_to_sec_usec to do proper
1221 overflow checking on durations.
dde14581
PE
1222 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1223 Don't assume pid_t fits in int.
02481186
PE
1224 * process.h (struct Lisp_Process): Members tick and update_tick
1225 are now of type EMACS_INT, not int.
b62b53e8
PE
1226 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1227 configured --with-wide-int.
d311d28c
PE
1228 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1229 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1230 * search.c (looking_at_1, string_match_1):
1231 (fast_string_match, fast_c_string_match_ignore_case)
1232 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1233 (scan_newline, find_before_next_newline, search_command)
1234 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1235 (set_search_regs, wordify):
1236 (Freplace_match):
1237 (Fmatch_data):
1238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1239 (string_match_1, search_buffer, set_search_regs):
1240 (Fmatch_data):
1241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1242 (wordify): Check for overflow in size calculation.
1243 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1244 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1245 Check that fixnums are in proper range for system types.
1246 * sound.c (struct sound_device)
1247 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1249 (Fplay_sound_internal):
1250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1251 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1252 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1253 (Fparse_partial_sexp):
1254 Don't assume fixnums can fit in int.
1255 (struct lisp_parse_state, find_start_pos, find_start_value)
1256 (find_start_value_byte, find_start_begv)
1257 (update_syntax_table, char_quoted, dec_bytepos)
1258 (find_defun_start, prev_char_comend_first, back_comment):
1259 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1260 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1261 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1262 (Finternal_describe_syntax_value): Check that match_lisp is a
1263 character, not an integer, since the code stuffs it into int.
1264 (scan_words, scan_sexps_forward):
1265 Check that fixnums are in proper range for system types.
1266 (Fforward_word):
1267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1268 (scan_sexps_forward):
1269 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1270 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1271 * syntax.h: Adjust decls to match defn changes elsewhere.
1272 (struct gl_state_s):
1273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1274 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1275 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1276 * sysdep.c (wait_for_termination_1, wait_for_termination)
1277 (interruptible_wait_for_termination, mkdir):
1278 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1279 (emacs_read, emacs_write):
1280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1281 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1282 and double all fit in int.
d311d28c
PE
1283 * term.c (set_tty_color_mode):
1284 Check that fixnums are in proper range for system types.
1285 * termhooks.h (struct input_event):
1286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1287 * textprop.c (validate_interval_range, interval_of)
1288 (Fadd_text_properties, set_text_properties_1)
1289 (Fremove_text_properties, Fremove_list_of_text_properties)
1290 (Ftext_property_any, Ftext_property_not_all)
1291 (copy_text_properties, text_property_list, extend_property_ranges)
1292 (verify_interval_modification):
1293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1294 (Fnext_single_char_property_change)
1295 (Fprevious_single_char_property_change):
1296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1297 (copy_text_properties):
1298 Check for integer overflow in index calculation.
d311d28c
PE
1299 * undo.c (last_boundary_position, record_point, record_insert)
1300 (record_delete, record_marker_adjustment, record_change)
1301 (record_property_change):
1302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1303 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1305 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1306 (Fx_hide_tip, Fx_file_dialog):
1307 * w32menu.c (set_frame_menubar):
1308 Use ptrdiff_t, not int, for consistency with rest of code.
1309 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1310 (select_window, Fdelete_other_windows_internal)
1311 (window_scroll_pixel_based, window_scroll_line_based)
1312 (Frecenter, Fset_window_configuration):
1313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1314 (Fset_window_hscroll, run_window_configuration_change_hook)
1315 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1316 (Fscroll_other_window, Frecenter):
d311d28c
PE
1317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1318 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1319 Don't assume fixnum fits in int.
1320 (Fset_window_scroll_bars):
1321 Check that fixnums are in proper range for system types.
1322 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1323 (string_pos, c_string_pos, number_of_chars, init_iterator)
1324 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1325 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1326 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1327 (face_before_or_after_it_pos, handle_invisible_prop)
1328 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1329 (display_prop_intangible_p, string_buffer_position_lim)
1330 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1331 (get_overlay_strings_1, get_overlay_strings)
1332 (iterate_out_of_display_property, forward_to_next_line_start)
1333 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1334 (get_next_display_element, set_iterator_to_next)
1335 (get_visually_first_element, compute_stop_pos_backwards)
1336 (handle_stop_backwards, next_element_from_buffer)
1337 (move_it_in_display_line_to, move_it_in_display_line)
1338 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1339 (add_to_log, message_dolog, message_log_check_duplicate)
1340 (message2, message2_nolog, message3, message3_nolog
1341 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1342 (current_message_1, truncate_echo_area, truncate_message_1)
1343 (set_message, set_message_1, store_mode_line_noprop)
1344 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1345 (text_outside_line_unchanged_p, check_point_in_composition)
1346 (reconsider_clip_changes)
1347 (redisplay_internal, set_cursor_from_row, try_scrolling)
1348 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1349 (redisplay_window, find_last_unchanged_at_beg_row)
1350 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1351 (trailing_whitespace_p, find_row_edges, display_line)
1352 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1353 (display_mode_element, store_mode_line_string)
1354 (pint2str, pint2hrstr, decode_mode_spec)
1355 (display_count_lines, display_string, draw_glyphs)
1356 (x_produce_glyphs, x_insert_glyphs)
1357 (rows_from_pos_range, mouse_face_from_buffer_pos)
1358 (fast_find_string_pos, mouse_face_from_string_pos)
1359 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1361 (safe_call, init_from_display_pos, handle_fontified_prop)
1362 (handle_single_display_spec, load_overlay_strings)
1363 (with_echo_area_buffer, setup_echo_area_for_printing)
1364 (display_echo_area, echo_area_display)
1365 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1366 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1367 (redisplay_window, dump_glyph_row, display_mode_line)
1368 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1369 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1371 (handle_single_display_spec, build_desired_tool_bar_string)
1372 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1373 (get_specified_cursor_type):
1374 Check that fixnums are in proper range for system types.
1375 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1376 (Flookup_image_map):
1377 Don't assume fixnums fit in int.
1378 (compare_overlay_entries):
1379 Avoid mishandling comparisons due to subtraction overflow.
1380 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1381 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1382 (handle_tool_bar_click):
1383 Use int, not unsigned, since we prefer signed and the signedness
1384 doesn't matter here.
1385 (get_next_display_element, next_element_from_display_vector):
1386 Use int, not EMACS_INT, when int is wide enough.
1387 (start_hourglass): Use duration_to_sec_usec to do proper
1388 overflow checking on durations.
1389 * xfaces.c (Fbitmap_spec_p):
1390 Check that fixnums are in proper range for system types.
1391 (compare_fonts_by_sort_order):
1392 Avoid mishandling comparisons due to subtraction overflow.
1393 (Fx_family_fonts, realize_basic_faces):
1394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1395 (Fx_family_fonts):
1396 Don't assume fixnum fits in int.
1397 Use SAFE_ALLOCA_LISP, not alloca.
1398 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1399 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1400 (face_at_buffer_position, face_for_overlay_string)
1401 (face_at_string_position):
1402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1403 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1404 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1405 (Fx_show_tip):
1406 Check that fixnums are in proper range for system types.
1407 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1408 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1410 (Fx_change_window_property): Don't assume fixnums fit in int.
1411 * xfont.c (xfont_chars_supported):
1412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1413 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1414 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1416 * xml.c (parse_region):
1417 * xrdb.c (magic_file_p):
1418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1419 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1420 (x_get_local_selection, x_reply_selection_request)
1421 (x_handle_selection_request, wait_for_property_change):
1422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1423 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1424 short is wide enough.
1425 (x_send_client_event): Don't assume fixnum fits in int.
1426 * xterm.c (x_x_to_emacs_modifiers):
1427 Don't assume EMACS_INT overflows nicely into int.
1428 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1429 may come from Lisp.
1430 (handle_one_xevent): NATNUMP can eval its arg twice.
1431 (x_connection_closed):
1432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1433 * xterm.h: Adjust decls to match defn changes elsewhere.
1434 (struct scroll_bar): Use struct vectorlike_header
1435 rather than rolling our own approximation.
1436 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1437
c6574eb5
GM
14382012-05-25 Glenn Morris <rgm@gnu.org>
1439
1440 * lisp.mk (lisp): Update for more files being compiled now.
1441
e8d32c7e
SM
14422012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1443
48def666
SM
1444 * lread.c: Remove `read_pure' which makes no difference.
1445 (read_pure): Remove var.
1446 (unreadpure): Remove function.
1447 (readevalloop): Don't call read_list with -1 flag.
1448 (read1, read_vector): Don't test read_pure any more.
1449 (read_list): Simplify.
1450
e8d32c7e
SM
1451 * fileio.c, character.h: Minor style tweaks.
1452
4b2addb7
DA
14532012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1454
1455 * window.h (clip_changed): Remove useless declaration.
1456
584461b2
JB
14572012-05-22 Juanma Barranquero <lekktu@gmail.com>
1458
1459 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1460 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1461
34374650
PE
14622012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1463
1464 Remove src/m/*.
1465 This directory predates autoconf and is no longer needed nowadays.
1466 Move its few remaining bits of functionality to where they're needed.
1467 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1468 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1469 * m/template.h: Remove.
1470 * Makefile.in (M_FILE): Remove. All uses removed.
1471 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1472 * lisp.h (USE_LSB_TAG):
1473 * mem-limits.h (EXCEEDS_LISP_PTR):
1474 Use VAL_MAX, not VALBITS, in #if.
1475 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1476 (EMACS_UINT): Define unconditionally now.
1477 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1478 (BITS_PER_EMACS_INT): New constants, replacing
1479 what used to be in config.h, but not useful in #if.
1480 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1481 define them any more.
1482 (VAL_MAX): New macro.
1483 (VALMASK): Use it.
1484 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1485 BITS_PER_EMACS_INT, in #if.
1486 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1487 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1488 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1489 * s/ms-w32.h (DATA_START):
1490 Move here from removed file m/intel386.h.
1491 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1492 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1493
261cb4bb
PE
14942012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1495
1496 Assume C89 or later.
1497 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1498 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1499 (xrealloc):
1500 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1501 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1502 * textprop.c, tparam.c (NULL): Remove.
1503 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1504 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1505 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1506 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1507 * xterm.c (input_signal_count): Assume volatile works.
1508
ff23cd9f
KB
15092012-05-21 Ken Brown <kbrown@cornell.edu>
1510
1511 * xgselect.c (xg_select): Fix first argument in call to 'select'
1512 (bug#11508).
1513
1b170bc6
KB
15142012-05-20 Ken Brown <kbrown@cornell.edu>
1515
1516 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1517 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1518
b2f4d39f
KB
15192012-05-19 Ken Brown <kbrown@cornell.edu>
1520
1521 * xfns.c (x_in_use): Remove `static' qualifier.
1522 * xterm.h (x_in_use): Declare.
1523 * xgselect.c: Include xterm.h.
1524 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1525 and `display_arg' (bug#9754).
1526
003fdae2
PE
15272012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1528
9232a6d9
PE
1529 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1530
003fdae2
PE
1531 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1532 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1533
784b56e2
EZ
15342012-05-18 Eli Zaretskii <eliz@gnu.org>
1535
1536 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1537
1538 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1539 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1540
1541 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1542 reference to image_cache->refcount.
1543 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1544
a0a79cde
JL
15452012-05-17 Juri Linkov <juri@jurta.org>
1546
1547 * search.c (Fword_search_regexp, Fword_search_backward)
1548 (Fword_search_forward, Fword_search_backward_lax)
1549 (Fword_search_forward_lax): Move functions to isearch.el
1550 (bug#10145, bug#11381).
1551
b0572523
PE
15522012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1555
9660f5fc
SM
15562012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1557
1558 * lread.c (init_obarray): Declare Qt and Qnil as special.
1559
4374de83
GM
15602012-05-14 Glenn Morris <rgm@gnu.org>
1561
1562 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1563 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1564
dc44c39a
PE
15652012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1566
078c97cb
PE
1567 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1568
dc44c39a
PE
1569 * unexaix.c: Port to more-recent AIX compilers.
1570 (report_error, report_error_1, make_hdr, copy_sym)
1571 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1572 Make arguments const char *, not char *, to avoid violations of C
1573 standard and to fix some AIX warnings reported by Gilles Pion.
1574
e18afed7 15752012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1576
1577 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1578 already have overlays loaded.
1579 (handle_single_display_spec): Before returning without displaying
1580 fringe bitmap, synchronize the bidi iterator with the main display
1581 iterator, by calling iterate_out_of_display_property.
1582 (iterate_out_of_display_property): Detect buffer iteration by
1583 testing that it->string is a Lisp string.
1584 (get_next_display_element): When the current object is exhausted,
1585 and there's something on it->stack, call set_iterator_to_next to
1586 proceed with what's on the stack, instead of returning zero.
1587 (set_iterator_to_next): If called at the end of a Lisp string,
1588 proceed to consider_string_end without incrementing string
1589 position. Don't increment display vector index past the end of
1590 the display vector. (Bug#11417)
c8fb9dc6
EZ
1591 (pos_visible_p): Don't report a position visible when move_it_to
1592 stopped at the last line of window, which happens to be scanned
1593 backwards by the bidi iteration. (Bug#11464)
ac268e67 1594
e18afed7 15952012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1596
1597 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1598 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1599 are on a TTY, and thus unable to display on the fringes.
1600 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1601 so we need to signal to the caller that this is a "replacing"
1602 display spec. This fixes display when the spec is invalid or we
1603 are on a TTY.
1604
e18afed7 16052012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1606
1607 * unexaix.c (make_hdr): Fix typo in prototype.
1608 This bug broke the build on AIX. Problem reported by Gilles Pion.
1609
9d0a235a
MA
16102012-05-14 Michael Albinus <michael.albinus@gmx.de>
1611
1612 * keyboard.c (kbd_buffer_get_event): Read special events also in
1613 batch mode. (Bug#11415)
1614
9e6b06ed
GM
16152012-05-12 Glenn Morris <rgm@gnu.org>
1616
1617 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1618
c1a1d7a3
EZ
16192012-05-12 Eli Zaretskii <eliz@gnu.org>
1620
1621 * lisp.mk (lisp): Add newcomment.elc.
1622
3fe7cdc8
GM
16232012-05-12 Glenn Morris <rgm@gnu.org>
1624
1625 * Makefile.in (MKDIR_P): New, set by configure.
1626 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1627
53f7d2c0
PE
16282012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1629
1630 Remove unused function hourglass_started.
1631 * dispextern.h (hourglass_started):
1632 * w32fns.c (hourglass_started):
1633 * xdisp.c (hourglass_started): Remove.
1634
75aafb17
JB
16352012-05-10 Juanma Barranquero <lekktu@gmail.com>
1636
1637 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1638 Update dependencies.
1639
12959e8e
PE
16402012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1641
97107e2e
PE
1642 * xgselect.c (xg_select): Put maxfds+1 into a var.
1643 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1644
12959e8e
PE
1645 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1646
836d29b3
DA
16472012-05-10 Dave Abrahams <dave@boostpro.com>
1648
1649 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1650 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1651
5cb67954
MA
16522012-05-09 Michael Albinus <michael.albinus@gmx.de>
1653
1654 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1655 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1656 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1657 Initialize xd_registered_buses.
1658
3478ec45
PE
16592012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1660
b263a6b0
PE
1661 Untag more efficiently if USE_LSB_TAG.
1662 This is based on a proposal by YAMAMOTO Mitsuharu in
1663 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1664 For an admittedly artificial (nth 8000 longlist) benchmark on
1665 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1666 Emacs's overall text size by 1%.
1667 * lisp.h (XUNTAG): New macro.
1668 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1669 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1670 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1671 * eval.c (Fautoload):
1672 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1673 * frame.h (XFRAME): Use XUNTAG.
1674
3478ec45
PE
1675 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1676 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1677 Remove unportable assumptions about print widths of types like
1678 dbus_uint32_t.
1679 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1680 intptr_t when converting between pointer and integer, to avoid GCC
1681 warnings about wrong width.
1682
666b903b 16832012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1684
1685 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1686 stack for each reader_thread, instead of defaulting to 8MB
1687 determined by the linker. This avoids failures in creating
1688 subprocesses on Windows 7, see the discussion in this thread:
1689 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1690
b120cc17
JC
16912012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1692
1693 Fix up display of the *Minibuf-0* buffer in the mini window.
1694 * keyboard.c (read_char): Don't clear the echo area if there's no
1695 message to clear.
1696 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1697 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1698
9a4b36f8
MA
16992012-05-07 Michael Albinus <michael.albinus@gmx.de>
1700
1701 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1702 batch mode.
1703
e5f9458f
CY
17042012-05-06 Chong Yidong <cyd@gnu.org>
1705
1706 * lisp.mk (lisp): Update.
1707
eceeb5fc 17082012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1709
1710 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1711
71873e2b
SM
17122012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1713
1714 * data.c (PUT_ERROR): New macro.
1715 (syms_of_data): Use it. Add new error type `user-error'.
1716 * undo.c (user_error): New function.
1717 (Fprimitive_undo): Use it.
1718 * print.c (print_error_message): Adjust print style for `user-error'.
1719 * keyboard.c (user_error): New function.
1720 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1721
ab0fa4e4
PE
17222012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1723
1724 Do not limit current-time-string to years 1000..9999.
1725 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1726 (Fcurrent_time_string): Support any year that is supported by the
1727 underlying localtime representation. Don't use asctime, as it
1728 has undefined behavior for years outside the range -999..9999.
1729
7ed806a7
PE
17302012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 Fix race conditions involving setenv, gmtime, localtime, asctime.
1733 Without this fix, interrupts could mess up code that uses these
1734 nonreentrant functions, since setting TZ invalidates existing
1735 tm_zone or tzname values, and since most of these functions return
1736 pointers to static storage.
1737 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1738 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1739 Grow the critical sections to include not just invoking
1740 localtime/gmtime, but also accessing these functions' results
1741 including their tm_zone values if any, and any related TZ setting.
1742 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1743 so that the struct tm is saved in the critical section.
1744 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1745 motivated by the fact that memory allocation needs to be outside
1746 the critical section.
1747
0c16dfed
DA
17482012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1749
1750 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1751 with RESET_INTERVAL.
1752
1753 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1754 Remove duplicated buffer name initialization.
1755
3f83ace8
JM
17562012-05-02 Jim Meyering <jim@meyering.net>
1757
1758 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1759
c7b8541e
JM
1760 * xfns.c (x_window): Use xstrdup (Bug#11375).
1761
90207a15 17622012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1763
1764 * xdisp.c (pos_visible_p): If already at a newline from the
1765 display string before the 'while' loop, don't walk back the glyphs
1766 from it3.glyph_row. Solves assertion violation when the display
1767 string begins with a newline (egg.el). (Bug#11367)
1768
b593d6a9
AH
17692012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1770
1771 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1772 Move to simple.el.
1773
4737362e
GM
17742012-05-01 Glenn Morris <rgm@gnu.org>
1775
99cf43f9
GM
1776 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1777 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1778 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1779 All were removed before 23.1.
1780
9311dcff
GM
1781 * dispnew.c: Remove HAVE_LIBNCURSES test;
1782 it is always true on relevant platforms.
1783
4d5c6349
GM
1784 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1785 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1786
4737362e
GM
1787 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1788
74dd3a6b
AS
17892012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1790
1791 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1792 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1793 Remove.
1794
13c379ee
PE
17952012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1796
1797 Do not avoid creating empty evaporating overlays (Bug#9642).
1798 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1799 That is, do not delete an evaporating overlay if it becomes
1800 empty after its bounds are adjusted to fit within its buffer.
1801 This fix caused other problems, and I'm reverting it until we get
1802 to the bottom of them.
1803
a8e7d6d7 18042012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1805
1806 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1807
a8e7d6d7 18082012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1809
1810 * xdisp.c (pos_visible_p): If the window start position is beyond
1811 ZV, start the display from buffer beginning. Prevents assertion
1812 violation in init_iterator when the minibuffer window is scrolled
1813 via the scroll bar.
1814
1815 * window.c (window_scroll_pixel_based): Likewise.
1816
a8e7d6d7 18172012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1818
1819 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1820
a8e7d6d7 18212012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1822
1823 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1824 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1825
a8e7d6d7 18262012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1827
b593d6a9
AH
1828 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1829 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1830
1c6900d9
EZ
18312012-04-26 Eli Zaretskii <eliz@gnu.org>
1832
4c3fa1d9
EZ
1833 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1834 display element, check also the underlying string or buffer
1835 character. (Bug#11341)
1836
1c6900d9
EZ
1837 * w32menu.c: Include w32heap.h.
1838 (add_menu_item): If the call to AppendMenuW (via
1839 unicode_append_menu) fails, disable Unicode menus only if we are
1840 running on Windows 9X/Me.
1841
42bf8205
AS
18422012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1843
1844 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1845 (xgetint): Add missing shift for LSB tags.
1846
b1bac16e
MR
18472012-04-24 Martin Rudalics <rudalics@gmx.at>
1848
1849 * keyboard.c (read_char): Don't wipe echo area for select window
1850 events: These might get delayed via `mouse-autoselect-window'
1851 (Bug#11304).
1852
d69621cc
JB
18532012-04-24 Juanma Barranquero <lekktu@gmail.com>
1854
1855 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1856 manipulation of :loaded-from data.
1857
02fd101b
JB
18582012-04-23 Juanma Barranquero <lekktu@gmail.com>
1859
1860 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1861 now a cons (bug#11311).
1862
888bec30
PE
18632012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1864
89a438bd
PE
1865 Do not create empty overlays with the evaporate property (Bug#9642).
1866 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1867 if it becomes empty after its bounds are adjusted to fit within
1868 its buffer. Without this fix, in a nonempty buffer (let ((o
1869 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1870 yields an empty overlay that has the evaporate property, which is
1871 not supposed to happen.
1872
1068fe4d
PE
1873 Fix minor GTK3 problems found by static checking.
1874 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1875 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1876 (struct _EmacsFixedClass, emacs_fixed_get_type):
1877 Move decls here from emacsgtkfixed.h, since they needn't be public.
1878 (emacs_fixed_get_type): Now static.
1879 (emacs_fixed_class_init): Omit unused local.
1880 (emacs_fixed_child_type): Remove; unused.
1881 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1882 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1883 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1884 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1885 (EMACS_FIXED_GET_CLASS): Remove; unused.
1886 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1887
888bec30
PE
1888 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1889 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1890
de85e130
PE
18912012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1892
d0baac98 1893 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1894 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1895 (__malloc_size_t, __malloc_ptrdiff_t):
1896 Remove. All uses removed, replaced by the definiens if needed,
1897 since we can assume C89 or better now.
1898 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1899 (protect_malloc_state, align, get_contiguous_space)
1900 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1901 (malloc_atfork_handler_child, malloc_enable_thread)
1902 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1903 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1904 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1905 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1906 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1907 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1908 Define using prototypes, not old style.
1909 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1910 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1911 (align): Don't assume that signed integer overflow wraps around.
1912 Omit unused local var.
1913 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1914 (_free_internal_nolock, memalign, mallochook, reallochook):
1915 Omit no-longer-needed casts.
1916 (valloc): Use getpagesize, not __getpagesize.
1917 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1918 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1919
de85e130
PE
1920 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1921
dcbf5805
MA
19222012-04-22 Michael Albinus <michael.albinus@gmx.de>
1923
1924 Move functions from C to Lisp. Make non-blocking method calls
1925 the default. Implement further D-Bus standard interfaces.
1926
1927 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1928 (QCdbus_request_name_allow_replacement)
1929 (QCdbus_request_name_replace_existing)
1930 (QCdbus_request_name_do_not_queue)
1931 (QCdbus_request_name_reply_primary_owner)
1932 (QCdbus_request_name_reply_in_queue)
1933 (QCdbus_request_name_reply_exists)
1934 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1935 (QCdbus_registered_serial, QCdbus_registered_method)
1936 (QCdbus_registered_signal): New Lisp objects.
1937 (XD_DEBUG_MESSAGE): Use sizeof.
1938 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1939 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1940 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1941 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1942 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1943 (xd_signature, xd_append_arg): Allow float for integer types.
1944 (xd_get_connection_references): New function.
b593d6a9
AH
1945 (xd_get_connection_address): Rename from xd_initialize.
1946 Return cached address.
dcbf5805
MA
1947 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1948 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1949 level.
1950 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1951 Return number of refcounts.
dcbf5805
MA
1952 (Fdbus_get_unique_name): Make stronger parameter check.
1953 (Fdbus_message_internal): New defun.
1954 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1955 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1956 (Fdbus_send_signal, Fdbus_register_service)
1957 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1958 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1959 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1960 (Vdbus_compiled_version, Vdbus_runtime_version)
1961 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1962 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1963 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1964 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1965 Adapt docstring.
dcbf5805 1966
52828e02
PE
19672012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1968
da05bc4c
PE
1969 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1970 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1971 Do not assume ptrdiff_t is the same width as 'int'.
1972
52828e02
PE
1973 * alloc.c: Handle unusual debugging option combinations.
1974 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1975 since the two debugging options are incompatible.
1976 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1977 is defined.
1978 (mem_init, mem_insert, mem_insert_fixup):
1979 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1980 (NEED_MEM_INSERT): Remove; no longer needed.
1981
f01769f9
LL
19822012-04-22 Leo Liu <sdl.web@gmail.com>
1983
1984 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1985
5790543d
PE
19862012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1987
1988 * sysdep.c [__FreeBSD__]: Minor cleanups.
1989 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1990 Use Emacs indenting style more consistently. Avoid some casts.
1991 Use 'double' consistently rather than mixing 'float' and 'double'.
1992
b91b7e4d
EW
19932012-04-21 Eduard Wiebe <usenet@pusto.de>
1994
b593d6a9
AH
1995 * sysdep.c (list_system_processes, system_process_attributes):
1996 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1997
6114eb15
AS
19982012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1999
2000 * lisp.mk (lisp): Update.
2001
2f38dff7
PE
20022012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2003
2004 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2005 It is never used otherwise.
2006
4ae29f89
SM
20072012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2008
2009 * print.c (print_preprocess): Only check print_depth if print-circle
2010 is nil.
2011 (print_object): Check for cycles even when print-circle is nil and
2012 print-gensym is t, but only check print_depth if print-circle is nil.
2013
f30d612a
CY
20142012-04-20 Chong Yidong <cyd@gnu.org>
2015
2016 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2017 set the status to "failed" and ensure that sentinel is run.
2018
c07a4c0b 20192012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2020
2021 * process.c (Fset_process_inherit_coding_system_flag)
2022 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2023 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2024
c07a4c0b 20252012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2026
2027 * xdisp.c (string_buffer_position_lim): Limit starting position to
2028 BEGV.
2029 (set_cursor_from_row): If called for a mode-line or header-line
2030 row, return zero immediately.
2031 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2032 farther than the first row after the header line, if any.
2033 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2034 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2035
c07a4c0b 20362012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2037
4ae29f89
SM
2038 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2039 (bug#11238).
ad3a2b41 2040
c07a4c0b 20412012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 20422012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2043
2044 configure: new option --enable-gcc-warnings (Bug#11207)
2045 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2046 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2047 (ALL_CFLAGS): Use new macros rather than old.
2048 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2049 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2050 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2051 -Wunused-result, -Wunused-variable. This should go away once
2052 the Emacs and Gnulib regex code is merged.
2053 (xmalloc, xrealloc): Now static.
2054
aba027e8
PE
20552012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2056
2057 * dired.c (Fsystem_groups): Remove unused local.
2058
e5a36063
GM
20592012-04-17 Glenn Morris <rgm@gnu.org>
2060
2061 * dired.c (Fsystem_users): Doc fix.
2062
316411f0
DA
20632012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2064
2065 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2066 (syms_of_dired): Add them.
2067
9426aba4
PE
20682012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2069
b62a57be
PE
2070 Fix minor alloc.c problems found by static checking.
2071 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2072 New extern decls, to avoid calling undeclared functions.
2073 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2074 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2075 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2076 (NEED_MEM_INSERT): New macro.
2077 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2078 Remove one incorrect comment and fix another.
b62a57be 2079
3539f31f
PE
2080 Fix minor ralloc.c problems found by static checking.
2081 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2082 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2083 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2084 (r_alloc_sbrk): Now static.
2085
a041960a
PE
2086 Improve ralloc.c interface checking.
2087 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2088 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2089 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2090 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2091 [REL_ALLOC]: ... to here, to check interface.
2092 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2093 Remove decls. This fixes an "It stinks!".
2094
9426aba4
PE
2095 * alloc.c (which_symbols): Fix alignment issue / type clash.
2096
d55c12ed
AS
20972012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2098
2099 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2100 (struct Lisp_Misc_Any): Likewise.
2101 (struct Lisp_Free): Likewise.
2102 * alloc.c (union aligned_Lisp_Symbol): Define.
2103 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2104 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2105 (union aligned_Lisp_Misc): Define.
2106 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2107 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2108 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2109
b948ce8b
PE
21102012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2111
2112 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2113 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2114 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2115 * s/netbsd.h, s/sol2-6.h:
2116 Remove definition of GC_MARK_STACK, since the default now works.
2117 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2118 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2119 no longer the default.
2120 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2121
35dc09a1 21222012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2123
35dc09a1
GM
2124 * lread.c (lisp_file_lexically_bound_p):
2125 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2126
35dc09a1
GM
21272012-04-14 Eli Zaretskii <eliz@gnu.org>
2128
2129 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2130 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2131
21322012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2133
2134 * nsterm.m (constrainFrameRect): Always constrain when there is only
2135 one screen (Bug#10962).
2136
bcd86815
KB
21372012-04-13 Ken Brown <kbrown@cornell.edu>
2138
2139 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2140
c25df26e
RT
21412012-04-13 Reuben Thomas <rrt@sc3d.org>
2142
2143 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2144
0fc59f1e
DC
21452012-04-11 Daniel Colascione <dancol@dancol.org>
2146
2147 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2148 against is gone. It's better to use vfork now so that when Cygwin
2149 gains a new, working vfork, we use it automatically (bug#10398).
2150
de8c03dc
SM
21512012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2152
2153 * window.c (save_window_save): Obey window-point-insertion-type.
2154
2f097256
GM
21552012-04-11 Glenn Morris <rgm@gnu.org>
2156
2157 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2158
453b951e
SM
21592012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2160
2161 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2162
75f1671a 21632012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2164
2165 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2166 (force_quit_count): New var.
2167 (handle_interrupt): Use it.
2168
2a8ce227
JB
21692012-04-10 Juanma Barranquero <lekktu@gmail.com>
2170
2171 * w32.c (w32_delayed_load): Record the full path of the library
2172 being loaded (bug#10424).
2173
935396c0
GM
21742012-04-09 Glenn Morris <rgm@gnu.org>
2175
05920a43
GM
2176 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2177 not just in the obarray, before snarfing them. (Bug#11036)
2178
935396c0
GM
2179 * Makefile.in ($(leimdir)/leim-list.el):
2180 Pass EMACS rather than BUILT_EMACS.
2181
a18ecafa
TZ
21822012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2183
2184 * process.c (make_process):
2185 * process.h: Add integer `gnutls_handshakes_tried' member to
2186 process struct.
2187
6bbef4e5
JC
2188 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2189 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2190
2191 * gnutls.c (gnutls_log_function2i): Convenience log function.
2192 (emacs_gnutls_read): Use new log functions,
2193 `gnutls_handshakes_tried' process member, and
2194 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2195 attempts per process (connection).
2196
b4d3bc10
CY
21972012-04-09 Chong Yidong <cyd@gnu.org>
2198
2199 * eval.c (Fuser_variable_p, user_variable_p_eh)
2200 (lisp_indirect_variable): Functions deleted.
2201 (Fdefvar): Caller changed.
2202
2203 * callint.c (Finteractive, Fcall_interactively):
2204 * minibuf.c (Fread_variable): Callers changed.
2205
70f4d973
EZ
22062012-04-09 Eli Zaretskii <eliz@gnu.org>
2207
2208 * xdisp.c (set_cursor_from_row): If the display string appears in
2209 the buffer at position that is closer to point than the position
2210 after the display string, display the cursor on the first glyph of
2211 the display string. Fixes cursor display when a 'display' text
2212 property immediately follows invisible text. (Bug#11094)
2213
cb3c2e3e
PE
22142012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2215
2216 composite.c: use 'double' consistently
2217 * composite.c (get_composition_id): Use 'double' consistently
2218 instead of converting 'float' to 'double' and vice versa; this is
2219 easier to understand and avoids a GCC warning.
2220
fd06db5d
GM
22212012-04-09 Glenn Morris <rgm@gnu.org>
2222
50fe702a
GM
2223 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2224 preparation for dumping it with emacs. (Bug#4789)
2225 (leimdir): New variable.
2226 ($(leimdir)/leim-list.el): New rule.
2227 (emacs$(EXEEXT)): Depend on leim-list.el.
2228
fd06db5d
GM
2229 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2230 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2231 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2232
55c131ee
AS
22332012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2234
2235 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2236 proper alignment.
2237
9209588f
JB
22382012-04-07 Juanma Barranquero <lekktu@gmail.com>
2239
2240 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2241 Remove unused local variable.
2242
e3fb2efb
PE
22432012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2244
2245 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2246 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2247 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2248 objects, as mark_maybe_pointer will catch them otherwise.
2249 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2250 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2251
b5385551
PE
22522012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2253
2254 Fix typo that broke non-Windows builds.
2255 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2256
9078ead6
EZ
22572012-04-07 Eli Zaretskii <eliz@gnu.org>
2258
2259 Support building on MS-Windows with libxml2.
2260
2261 * makefile.w32-in (OBJ2): Add xml.$(O).
2262 (GLOBAL_SOURCES): Add xml.c.
2263 ($(BLD)/xml.$(O)): New dependency list.
2264
2265 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2266 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2267 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2268 [!WINDOWSNT]: New macros.
2269 (init_libxml2_functions, libxml2_loaded_p): New functions.
2270 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2271 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2272 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2273 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2274 linked in).
6bbef4e5
JC
2275 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2276 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2277 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2278
2279 * emacs.c: Don't include libxml/parser.h.
2280 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2281 xmlCleanupParser directly.
2282
2283 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2284
3811fdf3
EZ
22852012-04-07 Eli Zaretskii <eliz@gnu.org>
2286
2287 * indent.c (Fvertical_motion): If there is a display string at
2288 point, use it.vpos to compute how many lines to backtrack after
2289 move_it_to point. (Bug#11133)
2290
2f8e16b2
EZ
22912012-04-06 Eli Zaretskii <eliz@gnu.org>
2292
2293 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2294 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2295 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2296 macros related to unification of CJK characters. For the details,
2297 see the discussion following the message here:
2298 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2299
3d439cd1
CY
23002012-04-04 Chong Yidong <cyd@gnu.org>
2301
2302 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2303
8bc53d00
EZ
23042012-04-01 Eli Zaretskii <eliz@gnu.org>
2305
2306 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2307 instead of alloca. (Bug#11138)
2308
3b0512a3
AS
23092012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2310
2311 * w32menu.c (is_simple_dialog): Properly check lisp types.
2312 (Bug#11141)
2313
8427ddd2
EZ
23142012-03-31 Eli Zaretskii <eliz@gnu.org>
2315
979022ef
EZ
2316 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2317 position we get to after a call to move_it_to fails the
2318 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2319 only if we wind up in a string from display property. (Bug#11063)
2320
a6b1c7cc
EZ
2321 * window.c (Fdelete_other_windows_internal): Invalidate the row
2322 and column information about mouse highlight, so that redisplay
2323 restores it after reallocating the glyph matrices. (Bug#7464)
2324
8427ddd2
EZ
2325 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2326 string comes from a `display' text property, use the buffer
2327 position of that property as if we actually saw that position in
2328 the row's glyphs.
697ba24b
EZ
2329 (move_it_by_lines): Remove the assertion that
2330 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2331 violated when there's a before-string at the beginning of a line.
2332 (Bug#11063)
8427ddd2 2333
65a0a738
EZ
23342012-03-30 Eli Zaretskii <eliz@gnu.org>
2335
2336 * xdisp.c (append_space_for_newline): If the default face was
2337 remapped, use the remapped face for the appended newline.
2338 (extend_face_to_end_of_line): Use the remapped default face for
2339 extending the face to the end of the line.
2340 (display_line): Call extend_face_to_end_of_line when the default
2341 face was remapped. (Bug#11068)
2342
581355cc
EZ
23432012-03-29 Eli Zaretskii <eliz@gnu.org>
2344
2345 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2346
e8fc049f
SM
23472012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2348
2349 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2350
4fb9a543
GM
23512012-03-27 Glenn Morris <rgm@gnu.org>
2352
2353 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2354 Doc fixes.
2355
679910f1
KH
23562012-03-26 Kenichi Handa <handa@m17n.org>
2357
2358 * dispextern.h (struct glyph): Fix previous change. Change the
2359 bit length of glyphless.ch to 25 (Bug#11082).
2360
90d49b7f
CY
23612012-03-26 Chong Yidong <cyd@gnu.org>
2362
2363 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2364 (command_loop_1): Use it; inhibit selection update for
2365 handle-select-window too (Bug#8996).
2366
f514f6f0
FP
23672012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2368
e8fc049f 2369 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2370
bf43fa51
KH
23712012-03-25 Kenichi Handa <handa@m17n.org>
2372
2373 * dispextern.h (struct glyph): Change the bit length of
2374 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2375
8a0c01dd
EZ
23762012-03-24 Eli Zaretskii <eliz@gnu.org>
2377
2378 * s/ms-w32.h (tzname): Include time.h before redirecting to
2379 _tzname. Fixes the MSVC build. (Bug#9960)
2380
7d1c3a76
AS
23812012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2382
8ed79523
AS
2383 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2384 characters.
2385
7d1c3a76
AS
2386 * xterm.c (XTread_socket): Only modify handling_signal if
2387 !SYNC_INPUT. (Bug#11080)
2388
e99a9b8b
EZ
23892012-03-23 Eli Zaretskii <eliz@gnu.org>
2390
2391 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2392 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2393 when fetching a multibyte character consumes more bytes than
2394 CHAR_BYTES returns, due to unification of CJK characters in
2395 string_char. (Bug#11073)
2396
5063c0e1
TN
23972012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2398
2399 * process.c (wait_reading_process_output): Handle pty disconnect
2400 by refraining from sending oneself a SIGCHLD (bug#10933).
2401
9f851fbd
CY
24022012-03-22 Chong Yidong <cyd@gnu.org>
2403
2404 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2405
5063c0e1 2406 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2407 Mark string as coming from a prefix property.
2408 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2409 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2410
fb5b8aca
CY
24112012-03-21 Chong Yidong <cyd@gnu.org>
2412
2413 * xfaces.c (Vface_remapping_alist): Doc fix.
2414
62356a1b
EZ
24152012-03-20 Eli Zaretskii <eliz@gnu.org>
2416
2417 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2418 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2419 Doc fixes.
62356a1b 2420
025de85b
CY
24212012-03-20 Chong Yidong <cyd@gnu.org>
2422
2423 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2424 to reflect default non-nil value of redisplay-dont-pause.
2425
4827f94e
KH
24262012-03-19 Kenichi Handa <handa@m17n.org>
2427
2428 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2429 it fit in a valid range (Bug#11003).
2430
e50a24a2
EZ
24312012-03-18 Eli Zaretskii <eliz@gnu.org>
2432
2433 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2434 that is not from display property, accept the row as a "cursor
2435 row" if one of the string's character has a non-nil `cursor'
2436 property. Fixes cursor positioning when there are newlines in
2437 overlay strings, e.g. in icomplete.el. (Bug#11035)
2438
9af5ed87
PE
24392012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2440
2441 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2442
d1f55f16
CY
24432012-03-12 Chong Yidong <cyd@gnu.org>
2444
2445 * eval.c (inhibit_lisp_code): Rename from
2446 inhibit_window_configuration_change_hook; move from window.c.
2447
2448 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2449 * window.c (run_window_configuration_change_hook)
2450 (syms_of_window): Callers changed.
2451
66c5eebd
CY
24522012-03-11 Chong Yidong <cyd@gnu.org>
2453
413df973
CY
2454 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2455
66c5eebd
CY
2456 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2457
1de11f56
CY
24582012-03-10 Chong Yidong <cyd@gnu.org>
2459
2460 * frame.c (other_visible_frames): Don't assume the selected frame
2461 is visible (Bug#10955).
2462
cae07000
SM
24632012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2464
2465 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2466
89c94350
JD
24672012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2468
2469 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2470 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2471 zero (Bug#10954).
2472
999dd333
GM
24732012-03-03 Glenn Morris <rgm@gnu.org>
2474
01a6dcc8 2475 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2476
de0100f2
EZ
24772012-03-02 Eli Zaretskii <eliz@gnu.org>
2478
2479 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2480 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2481 (redisplay_window, next_element_from_string): Fix typos in
2482 comments.
3e441275
EZ
2483 (redisplay_window): Pass to move_it_vertically the margin in
2484 pixels, not in screen lines.
de0100f2 2485
96a72ee9
GM
24862012-03-02 Glenn Morris <rgm@gnu.org>
2487
2488 * buffer.c (buffer-list-update-hook): Doc fix.
2489
312508d7
EZ
24902012-02-29 Eli Zaretskii <eliz@gnu.org>
2491
2492 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2493 push_it before setting up the iterator for the first overlay
2494 string, even if we have an empty string loaded.
2495 (next_overlay_string): If there's an empty string on the iterator
2496 stack, pop the stack. (Bug#10903)
2497
27f3c637
PE
24982012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2499
2500 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2501 Suggested by Stefan Monnier in
2502 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2503 * alloc.c (widen_to_Lisp_Object): New static function.
2504 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2505 and widening them to Lisp_Objects. This would work even if
2506 USE_LSB_TAG is defined and wide integers are used, which might
2507 happen in a future version of Emacs.
2508
3c9dfce6
CY
25092012-02-25 Chong Yidong <cyd@gnu.org>
2510
fa74b241
CY
2511 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2512 Doc fix.
2513
3c9dfce6
CY
2514 * xselect.c (Fx_selection_exists_p): Doc fix.
2515 (x_clipboard_manager_save_all): Print an informative message
2516 before saving to clipboard manager.
2517
9486df08
CY
25182012-02-24 Chong Yidong <cyd@gnu.org>
2519
2520 * keyboard.c (process_special_events): Handle all X selection
2521 requests in kbd_buffer, not just the next one (Bug#8869).
2522
f01d3321
CY
25232012-02-23 Chong Yidong <cyd@gnu.org>
2524
2525 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2526 call when setting menu-bar-lines and tool-bar-lines parameters.
2527 (unwind_create_frame_1): New helper function.
2528
2529 * window.c (inhibit_window_configuration_change_hook): New var.
2530 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2531 (syms_of_window): Initialize it.
f01d3321 2532
86b847b6
CY
25332012-02-22 Chong Yidong <cyd@gnu.org>
2534
2535 * xterm.c (x_draw_image_relief): Add missing type check for
2536 Vtool_bar_button_margin (Bug#10743).
2537
a59225b1
CY
25382012-02-21 Chong Yidong <cyd@gnu.org>
2539
2540 * fileio.c (Vfile_name_handler_alist): Doc fix.
2541
2542 * buffer.c (Fget_file_buffer): Protect against invalid file
2543 handler return value.
2544
310f5bd4
PE
25452012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2546
cb3a28cc
PE
2547 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2548 when computing $valmask.
2549
310f5bd4
PE
2550 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2551 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2552 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2553 It's useless in that case, and it can cause problems on hosts
2554 that allocate halves of EMACS_INT values separately.
2555 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2556 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2557 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2558 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2559 it avoids undefined behavior on hosts where shifting right by more
2560 than the word width has undefined behavior.
2561
2375c96a
CY
25622012-02-19 Chong Yidong <cyd@gnu.org>
2563
2564 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2565 (Funhandled_file_name_directory, Ffile_name_as_directory)
2566 (Fdirectory_file_name, Fexpand_file_name)
2567 (Fsubstitute_in_file_name): Protect against invalid file handler
2568 return values (Bug#10845).
2569
3eb49e71
EZ
25702012-02-18 Eli Zaretskii <eliz@gnu.org>
2571
2572 * .gdbinit (pitx): Fix incorrect references to fields of the
2573 iterator stack.
2574
7b926f3f
CY
25752012-02-17 Chong Yidong <cyd@gnu.org>
2576
2577 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2578
11273115
PE
25792012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2580
2581 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2582 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2583
c3a70e2b
CY
25842012-02-15 Chong Yidong <cyd@gnu.org>
2585
2586 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2587 marked as special. Also, starting docstrings with * is obsolete.
2588
0ca43699
AS
25892012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2590
2591 * gnutls.c (emacs_gnutls_write): Fix last change.
2592
2e8f3c56
LI
25932012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2594
2595 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2596 send_process.
2597
af70074f
SM
25982012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2599
2600 * keymap.c (Fsingle_key_description): Handle char ranges.
2601
95986d52
CY
26022012-02-12 Chong Yidong <cyd@gnu.org>
2603
afd83bd1
CY
2604 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2605 as that creates a dangerous corner case.
2606
95986d52
CY
2607 * window.c (Fdelete_window_internal): Invalidate the mouse
2608 highlight (Bug#9904).
2609
bd7da63e
GM
26102012-02-12 Glenn Morris <rgm@gnu.org>
2611
2612 * xselect.c (Fx_own_selection_internal)
2613 (Fx_get_selection_internal, Fx_disown_selection_internal)
2614 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2615 * nsselect.m (Fx_own_selection_internal)
2616 (Fx_disown_selection_internal, Fx_selection_exists_p)
2617 (Fx_selection_owner_p, Fx_get_selection_internal):
2618 Sync docs and argument specs with the xselect.c versions.
2619
77abcbc2
LI
26202012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2621
2622 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2623
90b671e2
EZ
26242012-02-11 Eli Zaretskii <eliz@gnu.org>
2625
1c0ca0b7
EZ
2626 * w32select.c (Fx_selection_exists_p): Sync doc string and
2627 argument list with xselect.c. (Bug#10783)
2628
2629 * w16select.c (Fx_selection_exists_p): Sync doc string and
2630 argument list with xselect.c. (Bug#10783)
90b671e2 2631
49241268
GM
26322012-02-10 Glenn Morris <rgm@gnu.org>
2633
2634 * fns.c (Fsecure_hash): Doc fix.
2635
f998bbe7 26362012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2637
2638 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2639
0992bd9c
CY
26402012-02-07 Chong Yidong <cyd@gnu.org>
2641
2642 * buffer.c (Fbuffer_local_variables)
2643 (buffer_lisp_local_variables): Handle unbound vars correctly;
2644 don't let Qunbound leak into Lisp.
2645
af008560
GM
26462012-02-07 Glenn Morris <rgm@gnu.org>
2647
dd605cc4
GM
2648 * image.c (Fimagemagick_types): Doc fix.
2649
af008560
GM
2650 * image.c (imagemagick-render-type): Change it from a lisp object
2651 to an integer. Move the doc here from the lisp manual.
2652 Treat all values not equal to 0 the same.
2653
1449fa1d
CY
26542012-02-06 Chong Yidong <cyd@gnu.org>
2655
2656 * doc.c (store_function_docstring): Avoid applying docstring of
2657 alias to base function (Bug#2603).
2658
3723ec07
AS
26592012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2660
2661 * .gdbinit (pp1, pv1): Remove redundant defines.
2662 (pr): Use pp.
2663
79c1cc1e
CY
26642012-02-04 Chong Yidong <cyd@gnu.org>
2665
2666 * nsterm.m: Declare a global (Bug#10694).
2667
d7f29f8e
EZ
26682012-02-04 Eli Zaretskii <eliz@gnu.org>
2669
cae07000
SM
2670 * w32.c (get_emacs_configuration_options):
2671 Include --enable-checking, if specified, in the return value.
d7f29f8e 2672
3b95a6f9
MR
26732012-02-04 Martin Rudalics <rudalics@gmx.at>
2674
2675 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2676 after rounding frame sizes. (Bug#9723)
2677
d6fa96a6
EZ
26782012-02-04 Eli Zaretskii <eliz@gnu.org>
2679
2680 * keyboard.c (adjust_point_for_property): Don't position point
2681 before BEGV. (Bug#10696)
2682
df0b2940
PE
26832012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2684
2685 Handle overflow when computing char display width (Bug#9496).
2686 * character.c (char_width): Return EMACS_INT, not int.
2687 (char_width, c_string_width): Check for overflow when
2688 computing the width; this is possible now that individual
2689 characters can have unbounded width. Problem introduced
2690 by merge from Emacs 23 on 2012-01-19.
2691
6bee44d6
MA
26922012-02-02 Michael Albinus <michael.albinus@gmx.de>
2693
2694 * dbusbind.c (Fdbus_register_method): Mention the return value
2695 :ignore in the docstring.
2696
44f92739
GM
26972012-02-02 Glenn Morris <rgm@gnu.org>
2698
1b9f60cc
GM
2699 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2700
44f92739
GM
2701 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2702 Unconditionally set to t. (Bug#10673)
2703 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2704 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2705 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2706
c5d3843c
KH
27072012-02-02 Kenichi Handa <handa@m17n.org>
2708
2709 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2710 0, do not call append_composite_glyph.
2711
159462d4 27122012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2713
2714 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2715 NULL (Bug#6988).
2716 (x_produce_glyphs): If the component of a composition is a null
2717 string, set it->pixel_width to 1 to avoid zero-width glyph.
2718
78cef877
EZ
27192012-02-01 Eli Zaretskii <eliz@gnu.org>
2720
2721 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2722 first 2 arguments are identical. This makes inserting large
2723 output from a subprocess an order of magnitude faster on
2724 MS-Windows, where all sbrk'ed memory is always contiguous.
2725
97897668
GM
27262012-01-31 Glenn Morris <rgm@gnu.org>
2727
2728 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2729 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2730 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2731
31fd3586
GM
27322012-01-29 Glenn Morris <rgm@gnu.org>
2733
2734 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2735
0e24a8b2
CY
27362012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2737
2738 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2739
cc0adcb0
CY
27402012-01-28 Chong Yidong <cyd@gnu.org>
2741
2742 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2743
acc28cb9
CY
27442012-01-26 Chong Yidong <cyd@gnu.org>
2745
9c69cfb7
CY
2746 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2747
acc28cb9
CY
2748 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2749 repeat counts (Bug#10507).
2750
48da7392
GM
27512012-01-26 Glenn Morris <rgm@gnu.org>
2752
2753 * lread.c (syms_of_lread): Doc fix.
2754
14af5f7f
CY
27552012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2756
2757 * coding.c (encode_designation_at_bol): Change return value to
2758 EMACS_INT.
2759
0b21c100
CY
27602012-01-25 Chong Yidong <cyd@gnu.org>
2761
2762 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2763
3c2907f7
CY
27642012-01-21 Chong Yidong <cyd@gnu.org>
2765
2766 * floatfns.c (Fcopysign): Make the second argument non-optional,
2767 since nil is not allowed anyway.
2768
959ad23f
AS
27692012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2770
2771 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2772 (send_process): Likewise.
2773
34a02f46
MR
27742012-01-19 Martin Rudalics <rudalics@gmx.at>
2775
2776 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2777 (Vwindow_persistent_parameters): Do not use Qstate.
2778 Rewrite doc-strings.
34a02f46 2779
1259009a 27802012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2781
2782 * character.c (char_width): New function.
70d4fdf6
GM
2783 (Fchar_width, c_string_width, lisp_string_width):
2784 Use char_width (Bug#9496).
25ed9e61 2785
6a6ee00d
MR
27862012-01-16 Martin Rudalics <rudalics@gmx.at>
2787
2788 * window.c (Vwindow_persistent_parameters): New variable.
2789 (Fset_window_configuration, save_window_save): Handle persistent
2790 window parameters.
2791
c85efaf7
EZ
27922012-01-14 Eli Zaretskii <eliz@gnu.org>
2793
2794 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2795 thrashing the stack of the thread. (Bug#9087)
2796
5944709e
PE
27972012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2798
2799 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2800
e71f5d99
EZ
28012012-01-11 Eli Zaretskii <eliz@gnu.org>
2802
2803 * xdisp.c (rows_from_pos_range): Handle the case where the
2804 highlight ends on a newline. (Bug#10464)
2805 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2806 he end column for display of highlight that ends on a newline
2807 before a R2L line.
2808
ce316182
GM
28092012-01-11 Glenn Morris <rgm@gnu.org>
2810
2811 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2812 from load-path also when installation-directory is nil. (Bug#10208)
2813
5b43da69
GM
28142012-01-10 Glenn Morris <rgm@gnu.org>
2815
74cc8ff9
GM
2816 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2817
7d8d6e4e
GM
2818 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2819 Update template values to be closer to their typical values these days.
5b43da69 2820
a0db8d43
EZ
28212012-01-09 Eli Zaretskii <eliz@gnu.org>
2822
2823 * xdisp.c (rows_from_pos_range): Accept additional argument
2824 DISP_STRING, and accept any glyph in a row whose object is that
2825 string as eligible for mouse highlight. Fixes mouse highlight of
2826 display strings from overlays. (Bug#10464)
2827
9a0115ab 28282012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2829
b9110d6a 2830 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2831 * fileio.c (auto_saving_dir_umask): New static var.
2832 (Fmake_directory_internal): Use it.
2833 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2834 creating the directory. The old code temporarily assigns
2835 too-generous permissions to the directory.
2836 (do_auto_save_eh): Clear it.
b9110d6a 2837 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2838 that the var is always cleared.
2839
6c1bd3f3
EZ
28402012-01-07 Eli Zaretskii <eliz@gnu.org>
2841
2842 * search.c (scan_buffer): Pass character positions to
2843 know_region_cache, not byte positions. (Bug#6540)
2844
069d2b50
L
28452012-01-07 LynX <_LynX@bk.ru> (tiny change)
2846
2847 * w32.c (sys_rename): Report EXDEV when rename of a directory
2848 fails because the target is on another logical disk. (Bug#10284)
2849
75bf0d33
DB
28502012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2851
2852 * xterm.c (x_embed_request_focus): New function.
2853
2854 * xterm.h: Add prototype.
2855
2856 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2857
1c6e5a32
GM
28582012-01-05 Glenn Morris <rgm@gnu.org>
2859
2860 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2861
651e947e
EZ
28622012-01-01 Eli Zaretskii <eliz@gnu.org>
2863
2864 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2865 Load gnutls_transport_set_lowat only if GnuTLS version is below
2866 2.11.1.
2867 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2868 GnuTLS versions below 2.11.1.
2869
3778cdd8
AL
28702011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2871
2872 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2873 to the doc string advising against its use for altering the way
2874 windows are scrolled.
2875
0e5317f7
KH
28762011-12-28 Kenichi Handa <handa@m17n.org>
2877
2878 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2879 coding-system ASCII compatible only when it does not produce BOM
2880 on encoding (Bug#10383).
2881
93d5ca1f
JD
28822011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2883
2884 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2885 can scroll.
2886 (create_and_show_popup_menu): Always use menu_position_func for
2887 Gtk3 (Bug#10361).
2888
ca22b785
AS
28892011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2890
2891 * callint.c (Fcall_interactively): Don't truncate prompt string.
2892
d048e1e6
EZ
28932011-12-23 Eli Zaretskii <eliz@gnu.org>
2894
2895 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2896 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2897 resumed from there (after widening). (Bug#10360)
d048e1e6 2898
5ccaba1f
JD
28992011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2900
2901 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2902
204ee57f
JD
29032011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2904
b81d40f0
JB
2905 * nsterm.m (x_free_frame_resources):
2906 Release f->output_data.ns->miniimage.
204ee57f
JD
2907 (ns_index_color): Fix indentation. Do not retain
2908 color_table->colors[i].
2909
2910 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2911 before returning.
2912
2913 * nsfns.m (x_set_background_color): Assign return value from
2914 ns_index_color to face-background instead of NSColor*.
2915 (ns_implicitly_set_icon_type): Fix indentation.
2916 Change assignment in for loop to comparison.
2917
2918 * emacs.c (ns_pool): New variable.
2919 (main): Assign ns_pool.
2920 (Fkill_emacs): Call ns_release_autorelease_pool.
2921
2922 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2923 autorelease fdesc, release fdAttrs and tdict.
2924 (ns_get_covering_families): Release charset.
2925 (ns_findfonts): Release NSFontDescriptor created with new.
2926 (ns_uni_to_glyphs): Fix indentation.
2927 (setString): Release attrStr before assigning new value.
2928
c803b2b7
JD
29292011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2930
678f4426
JD
2931 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2932 and NS_IMPL_COCOA.
2933 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2934 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2935
cd394be1 29362011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2937
5fecd5fc
JD
2938 * nsterm.m (ns_term_init): Subscribe for notifications
2939 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2940 to method trackingNotification in EmacsMenu.
2941
2942 * nsmenu.m (trackingMenu): New variable.
3771cb17 2943 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2944 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2945 from Aquamacs (Bug#7030).
678f4426
JD
2946
29472011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2948
c803b2b7
JD
2949 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2950 (symbol_to_nsstring): Fix indentation.
2951 (ns_symbol_to_pb): New function.
cae07000
SM
2952 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2953 (Fns_rotate_cut_buffers_internal): Remove.
2954 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2955 Fns_store_cut_buffer_internal.
2956 (ns_get_foreign_selection, Fx_own_selection_internal)
2957 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2958 (Fns_get_selection_internal, Fns_store_selection_internal):
2959 Use ns_symbol_to_pb and check if return value is nil.
2960 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2961 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2962 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2963 renamed to Sns_store_selection_internal.
2964 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2965 and remove this function.
2966 (ns_handle_selection_clear): Remove, never used.
2967 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2968 here.
2969
e1b01a3a
KB
29702011-12-17 Ken Brown <kbrown@cornell.edu>
2971
2972 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2973 GID is unknown (Bug#10257).
2974
2adb6e85
PE
29752011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2976
2977 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2978 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2979 which caused a build failure on GNU/Linux IA-64. This problem was
2980 introduced by my 2011-10-07 patch.
2981
d1d7b339
JL
29822011-12-15 Juri Linkov <juri@jurta.org>
2983
2984 * image.c (imagemagick_error): New function. (Bug#10112)
2985 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2986 Use `imagemagick_error' where ImageMagick functions return
2987 `MagickFalse'.
2988 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2989 proper order.
2990
100d5755
KH
29912011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2992
2993 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2994 fill background (Bug#8992).
2995
454592a6
MR
29962011-12-13 Martin Rudalics <rudalics@gmx.at>
2997
2998 * window.c (Vwindow_combination_resize)
2999 (Vwindow_combination_limit): Use t instead of non-nil in
3000 doc-strings.
61d4b438
MR
3001 (Vrecenter_redisplay): Add first sentence of doc-string on
3002 separate line.
53524d93 3003 (Frecenter): Fix doc-string typo.
454592a6 3004
3633e3aa
KH
30052011-12-11 Kenichi Handa <handa@m17n.org>
3006
3007 * coding.c (Funencodable_char_position): Pay attention to the
3008 buffer text relocation (Bug#9389).
3009
7b9d523a 30102011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3011
7b9d523a
JD
3012 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3013 gtk_init (Bug#10100).
3014
b73189c6
EZ
30152011-12-10 Eli Zaretskii <eliz@gnu.org>
3016
3017 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3018 IT->string is nil. (Bug#10263)
3019
f7dfe5d6
JD
30202011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3021
83faebb4
JD
3022 * nsterm.h (x_free_frame_resources): Declare.
3023
f7dfe5d6
JD
3024 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3025 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3026
3027 * nsterm.h (ns_get_defaults_value): Declare.
3028
3029 * nsterm.m (ns_default): Call ns_get_defaults_value.
3030
7cd4e72c
EZ
30312011-12-09 Eli Zaretskii <eliz@gnu.org>
3032
3033 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3034 (Bug#10170)
3035
b34d7317
YM
30362011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3037
3038 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3039 that where the value of an _OBJC_* symbol points to is in the .bss
3040 section (Bug#10240).
3041
76470ad1
KH
30422011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3043
3044 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3045 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3046
745fff94
KH
30472011-12-08 Kenichi Handa <handa@m17n.org>
3048
3049 * ftfont.c (get_adstyle_property): Fix previous change
3050 (Bug#10233).
3051
6e44397c
JB
30522011-12-07 Juanma Barranquero <lekktu@gmail.com>
3053
3054 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3055 dirs from the default value of EMACSLOADPATH (bug#10208).
3056
7efa6272
GM
30572011-12-07 Glenn Morris <rgm@gnu.org>
3058
3059 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3060 installation and source directories as well. (Bug#10208)
3061
f6fc4d87
CY
30622011-12-06 Chong Yidong <cyd@gnu.org>
3063
3064 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3065
2bf26180
GM
30662011-12-06 Glenn Morris <rgm@gnu.org>
3067
3068 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3069 as an error, not just -1. (Bug#10217)
3070
3a6ad4f0
CY
30712011-12-05 Chong Yidong <cyd@gnu.org>
3072
3073 * keyboard.c (process_special_events): New function.
3074 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3075
75a3b399
PE
30762011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3077
3078 * coding.c (encode_designation_at_bol): Don't use uninitialized
3079 local variable (Bug#9318).
3080
c3c9e25e
KH
30812011-12-05 Kenichi Handa <handa@m17n.org>
3082
3083 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3084 return Qnil (Bug#8046, Bug#10193).
3085
5eb05ea3
KH
30862011-12-05 Kenichi Handa <handa@m17n.org>
3087
3088 * coding.c (encode_designation_at_bol): New args charbuf_end and
3089 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3090 (coding_set_source): Return how many bytes coding->source was
3091 relocated.
3092 (coding_set_destination): Return how many bytes
3093 coding->destination was relocated.
3094 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3095 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3096
30972011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3098
3099 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3100 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3101 macro (Bug#9318).
3102
31032011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3104
3105 The following changes are to fix Bug#9318.
3106
a79703f5 3107 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3108 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3109 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3110 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3111
7dbda6df
JB
31122011-12-05 Juanma Barranquero <lekktu@gmail.com>
3113
3114 * lisp.h (process_quit_flag): Fix external declaration.
3115
6d5eb5b0
SM
31162011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3117
3118 Don't macro-inline non-performance-critical code.
3119 * eval.c (process_quit_flag): New function.
3120 * lisp.h (QUIT): Use it.
3121
a0c3fad0
JD
31222011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3123
3124 * nsfns.m (get_geometry_from_preferences): New function.
3125 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3126
6c07aac2
AS
31272011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3128
3129 * emacs.c (Qkill_emacs): Define.
3130 (syms_of_emacs): Initialize it.
3131 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3132 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3133 (quit_throw_to_read_char): Add parameter `from_signal'.
3134 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3135 * lisp.h (QUIT): Call Fkill_emacs if requested.
3136
c052ead4
JD
31372011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3138
3139 * widget.c (update_wm_hints): Return if wmshell is null.
3140 (widget_update_wm_size_hints): New function.
3141
3142 * widget.h (widget_update_wm_size_hints): Declare.
3143
3144 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3145 widget_update_wm_size_hints (Bug#10104).
3146
9e49252b
EZ
31472011-12-03 Eli Zaretskii <eliz@gnu.org>
3148
3149 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3150 before a newline, prepare the bidi iterator for consuming the
3151 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3152 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3153
02b16839
JL
31542011-12-02 Juri Linkov <juri@jurta.org>
3155
3156 * search.c (Fword_search_regexp): New Lisp function created from
3157 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3158 (Fword_search_backward, Fword_search_forward)
3159 (Fword_search_backward_lax, Fword_search_forward_lax):
3160 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3161 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3162
0068070e
SM
31632011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3164
3165 * fileio.c (Finsert_file_contents): Move after-change-function call
3166 to before the "handled:" label, since all "goto handled" appear in
3167 cases where the *-change-functions have already been properly called
3168 (bug#10117).
3169
3360a3fc
AS
31702011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3171
3172 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3173 waiting for input. (Bug#10169)
3174
73d6c093
EZ
31752011-11-30 Eli Zaretskii <eliz@gnu.org>
3176
3177 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3178 verifies glyph row's hash code--we have just reallocated the
3179 glyphs, so their contents can be complete garbage. (Bug#10164)
3180
febe6bea
JB
31812011-11-30 Juanma Barranquero <lekktu@gmail.com>
3182
3183 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3184
801a4313
EZ
31852011-11-30 Eli Zaretskii <eliz@gnu.org>
3186
3187 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3188 attributes are tested _before_ calling verify_row_hash, to protect
3189 against GCC re-ordering of the tests. (Bug#10164)
3190
2b56b87e
JD
31912011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3192
3193 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3194
3195 * xterm.c (handle_one_xevent): Only set async_visible and friends
3196 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3197 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3198 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3199
dbf31225
PE
32002011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3201
3202 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3203 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3204 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3205 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3206 All uses changed to use GCPRO1 etc.
3207 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3208 Revert to old implementation (i.e., before 2011-03-11).
3209
1305621b
YM
32102011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3211
3212 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3213 of scroll runs so as to avoid assigning disabled bogus rows and
3214 unnecessary graphics copy operations.
3215
8c9afb46
EZ
32162011-11-27 Eli Zaretskii <eliz@gnu.org>
3217
3218 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3219 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3220 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3221 (malloc, free, realloc, calloc): Redirect to e_* only when
3222 compiling Emacs.
3223
3224 * lisp.h (GCTYPEBITS): Move before first use.
3225 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3226 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3227 this macro definition.
3228
3229 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3230 _MSC_VER.
3231
54e9e3bf
JD
32322011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3233
6d5eb5b0
SM
3234 * gtkutil.c (xg_create_frame_widgets):
3235 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3236 present with Gtk+ 2.0.
3237
83aca1cb
PE
32382011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3239
3240 * fileio.c (Finsert_file_contents): Undo previous change; see
3241 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3242
5b76caa4
PE
32432011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3244
3245 Rename locals to avoid shadowing.
3246 * fileio.c (Finsert_file_contents):
3247 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3248 * process.c (wait_reading_process_output):
3249 Rename inner 'proc' to 'p' to avoid shadowing.
3250 Indent for consistency with usual Emacs style.
3251
8c535114
EZ
32522011-11-25 Eli Zaretskii <eliz@gnu.org>
3253
3254 * xdisp.c (redisplay_window): If cursor row is not fully visible
3255 after recentering, and scroll-conservatively is set to a large
3256 number, scroll window by a few more lines to make the cursor fully
3257 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3258 (start_display): Don't move to the next line if the display should
3259 start at a newline that is part of a display vector or an overlay
3260 string. (Bug#10119)
8c535114 3261
fa4fdb5c
JL
32622011-11-24 Juri Linkov <juri@jurta.org>
3263
3264 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3265 after the `MagickPingImage' call. (Bug#10112)
3266
90ec88df
CY
32672011-11-23 Chong Yidong <cyd@gnu.org>
3268
3269 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3270
56e2e794
MR
32712011-11-23 Martin Rudalics <rudalics@gmx.at>
3272
3273 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3274 making another buffer current. (Bug#10114)
3275
b6e64c41
GM
32762011-11-23 Glenn Morris <rgm@gnu.org>
3277
3278 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3279
6b21de18
CY
32802011-11-23 Chong Yidong <cyd@gnu.org>
3281
3282 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3283 using it (Bug#5984).
3284
b12cd789
EZ
32852011-11-22 Eli Zaretskii <eliz@gnu.org>
3286
3287 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3288 and header-lines, as they don't have one computed for them.
3289 (Bug#10098)
3290
3291 * .gdbinit (prow): Make displayed values more self-explaining.
3292 Add row's hash code.
3293
261b6fd4
LMI
32942011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3295
3296 * process.c (wait_reading_process_output): Fix asynchrounous
3297 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3298 (wait_reading_process_output): Add comment and URL.
261b6fd4 3299
e7cfd277
JD
33002011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3301
3302 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3303
a9b9b7f5
CY
33042011-11-21 Chong Yidong <cyd@gnu.org>
3305
3306 * window.c (Fnext_window, Fprevious_window): Doc fix.
3307
b0d15b4f
SM
33082011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3309
3310 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3311
fe7a3057
JB
33122011-11-20 Juanma Barranquero <lekktu@gmail.com>
3313
3314 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3315
d2999b1a
MR
33162011-11-20 Martin Rudalics <rudalics@gmx.at>
3317
3318 * window.c (Fset_window_combination_limit): Rename argument
3319 STATUS to LIMIT.
3320 (Vwindow_combination_limit): Remove "status" from doc-string.
3321
d5ff9cd0
AS
33222011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3323
3324 * m/ibms390.h: Remove.
3325 * m/ibms390x.h: Don't include "ibms390.h".
3326
a5bb9bd3
SM
33272011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3328
3329 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3330 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3331
cd1181db
JB
33322011-11-20 Juanma Barranquero <lekktu@gmail.com>
3333
3334 * casetab.c (Fset_case_table):
3335 * charset.c (Fcharset_after): Fix typos.
3336
615a3b8d 33372011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3338
17e845af
PE
3339 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3340 Otherwise, valgrind does not work on some platforms.
3341 Problem reported by Andreas Schwab in
6a0bf43d
PE
3342 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3343 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3344 is set, removing the need for VIRT_ADDRESS_VARIES.
3345 (PURE_P): Use a more-efficient implementation that needs just one
3346 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3347 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3348 to 4 (xorl, subq, cmpq, setbe).
3349 * alloc.c (pure): Always extern now, since that's the
3350 VIRT_ADDR_VARIES behavior.
3351 (PURE_POINTER_P): Use a single comparison, not two, for
3352 consistency with the new puresize.h.
3353 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3354 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3355 Remove VIRT_ADDR_VARIES no longer needed.
3356
f8fe6f96
EZ
33572011-11-19 Eli Zaretskii <eliz@gnu.org>
3358
3359 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3360 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3361 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3362 behave as if the cursor position were at the window margin.
3363
3364 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3365 and the cursor position is out of bounds, behave as if the cursor
3366 position were at the window margin. (Bug#10075)
3367
df05a53c
CY
33682011-11-18 Chong Yidong <cyd@gnu.org>
3369
3370 * window.c (Fwindow_combination_limit): Make first argument
3371 non-optional, since it is meaningless for live windows like the
3372 selected window.
61ccba97 3373
2071918e
DA
33742011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3375
3376 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3377
b50a28de
SM
33782011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3379
3380 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3381 (graft_intervals_into_buffer): Simplify.
3382
015137db
EZ
33832011-11-18 Eli Zaretskii <eliz@gnu.org>
3384
3385 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3386 hash values of the two rows.
3387 (copy_row_except_pointers): Preserve the used[] arrays and the
3388 hash values of the two rows. (Bug#10035)
68c95424 3389 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3390
3391 * xdisp.c (row_hash): New function, body extracted from
3392 compute_line_metrics.
3393 (compute_line_metrics): Call row_hash, instead of computing the
3394 hash code inline.
3395
3396 * dispnew.c (verify_row_hash): Call row_hash for computing the
3397 hash code of a row, instead of duplicating code from xdisp.c.
3398
3399 * dispextern.h (row_hash): Add prototype.
3400
a2addb04
TH
34012011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3402
3403 * frame.c (delete_frame): Don't delete the terminal when the last
3404 X frame is closed if emacs is built with GTK toolkit.
3405
df85d315
JB
34062011-11-17 Juanma Barranquero <lekktu@gmail.com>
3407
3408 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3409
a0c2d0ae
MR
34102011-11-17 Martin Rudalics <rudalics@gmx.at>
3411
3412 * window.c (Vwindow_splits): Rename to
3413 Vwindow_combination_resize. Suggested by Juri Linkov.
3414 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3415 of Vwindow_splits.
3416
58179cce
JB
34172011-11-16 Juanma Barranquero <lekktu@gmail.com>
3418
7877f373
JB
3419 * nsfns.m (Fns_font_name):
3420 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3421
b6f67890
MR
34222011-11-16 Martin Rudalics <rudalics@gmx.at>
3423
3424 * window.h (window): Rename slot "nest" to "combination_limit".
3425 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3426 (Fset_window_nest): Rename to Fset_window_combination_limit.
3427 (Vwindow_nest): Rename to Vwindow_combination_limit.
3428 (recombine_windows, make_parent_window, make_window)
3429 (Fsplit_window_internal, saved_window)
3430 (Fset_window_configuration, save_window_save): Rename all
3431 occurrences of window_nest to window_combination_limit.
3432
c7015153
JB
34332011-11-15 Juanma Barranquero <lekktu@gmail.com>
3434
3435 * image.c (imagemagick_load_image): Fix typo.
3436
322ad6ec
EZ
34372011-11-14 Eli Zaretskii <eliz@gnu.org>
3438
3439 * xdisp.c (display_line): Move the call to
3440 highlight_trailing_whitespace before the call to
3441 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3442 faces of all the glyphs to compute ROW's hash value.
3443 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3444
f067b8ec
JB
34452011-11-14 Juanma Barranquero <lekktu@gmail.com>
3446
3447 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3448 just return (bug#10044).
3449
1e5b2111
EZ
34502011-11-12 Eli Zaretskii <eliz@gnu.org>
3451
7ef3cbd5
EZ
3452 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3453 with user-defined heap size. Bump the default size of the temacs
3454 heap to 27MB, to avoid memory warning when running temacs.
3455 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3456
1e5b2111
EZ
3457 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3458 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3459 (verify_row_hash) [XASSERTS]: New function.
3460 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3461 that the hash value of glyph rows is correct.
1e5b2111 3462
89d61221
MR
34632011-11-12 Martin Rudalics <rudalics@gmx.at>
3464
3465 * window.h (window): Remove splits slot.
3466 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3467 (Fdelete_other_windows_internal, make_parent_window)
3468 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3469 (Fset_window_configuration, save_window_save): Don't deal with
3470 split status of windows.
3471 (saved_window): Remove splits slot.
3472 (Vwindow_splits): Rewrite doc-string.
3473
97f18cc8
JD
34742011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3475
3476 * xfns.c (unwind_create_frame):
3477 * nsfns.m (unwind_create_frame):
3478 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3479 Vframe_list (Bug#9999).
3480
22a648b4
DA
34812011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3482
0b381c7e 3483 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3484
659afede
KH
34852011-11-11 Kenichi Handa <handa@m17n.org>
3486
3487 * callproc.c (Fcall_process): Set the member dst_multibyte of
3488 process_coding.
3489
9ac0394b
KH
34902011-11-11 Johan Bockgård <bojohan@gnu.org>
3491
3492 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3493 avoid a crash (bug#9496).
3494
2fbdc249
CY
34952011-11-09 Chong Yidong <cyd@gnu.org>
3496
3497 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3498 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3499
ac6b1f81
PE
35002011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3501
3502 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3503
09db192c
PE
35042011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3505
3506 Avoid some portability problems by eschewing 'extern inline' functions.
3507 The trivial performance wins aren't worth the portability hassles; see
3508 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3509 et seq.
3510 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3511 (window_box_width, window_box_left, window_box_left_offset)
3512 (window_box_right, window_box_right_offset): Undo previous change,
3513 by removing the "extern"s.
3514 * intervals.c (adjust_intervals_for_insertion)
3515 (adjust_intervals_for_deletion): Undo previous change,
3516 making these static again.
3517 (offset_intervals, temp_set_point_both, temp_set_point)
3518 (copy_intervals_to_string): No longer inline.
3519 * xdisp.c (window_text_bottom_y, window_box_width)
3520 (window_box_height, window_box_left_offset)
3521 (window_box_right_offset, window_box_left, window_box_right)
3522 (window_box): No longer inline.
3523
105216ed
CY
35242011-11-08 Chong Yidong <cyd@gnu.org>
3525
3526 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3527 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3528 Signal an error if not a live window.
105216ed
CY
3529 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3530 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3531
ae9e237f
JB
35322011-11-07 Juanma Barranquero <lekktu@gmail.com>
3533
3534 * lisp.h (syms_of_abbrev): Remove declaration.
3535 Reported by CHENG Gao <chenggao@royau.me>.
3536
c7aa8333
EZ
35372011-11-07 Eli Zaretskii <eliz@gnu.org>
3538
3539 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3540 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3541 of temacs in GUI mode.
3542
be7f5545
MR
35432011-11-07 Martin Rudalics <rudalics@gmx.at>
3544
3545 * window.h: Declare delete_all_child_windows instead of
3546 delete_all_subwindows.
3547 * window.c (Fwindow_nest, Fset_window_nest)
3548 (Fset_window_new_total, Fset_window_new_normal)
3549 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3550 (delete_all_subwindows): Rename to delete_all_child_windows.
3551 (Fdelete_other_windows_internal, Fset_window_configuration):
3552 Call delete_all_child_windows instead of delete_all_subwindows.
3553 * frame.c (delete_frame): Call delete_all_child_windows instead
3554 of delete_all_subwindows.
3555
ca78dc43
PE
35562011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3557
3558 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3559 This is also needed for porting to any host where GC_MARK_STACK is
3560 not GC_MAKE_GCPROS_NOOPS.
3561 (which_symbols): Use it.
3562
a0241d01
KH
35632011-11-07 Kenichi Handa <handa@m17n.org>
3564
3565 * coding.c (coding_set_destination): Check coding->src_pos only
3566 when coding->src_object is a buffer (bug#9910).
3567
3568 * process.c (send_process): Set the member src_multibyte of coding
3569 to 0 (bug#9911) when sending a unibyte text.
3570
3571 * callproc.c (Fcall_process): Set the member src_multibyte of
3572 process_coding to 0 (bug#9912).
3573
a64bfdfa 35742011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3575
3576 * xmenu.c (cleanup_widget_value_tree): New function.
3577 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3578 calling free_menubar_widget_value_tree directly (Bug#9830).
3579
cb41b32a
PE
35802011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3581
3582 Fix some portability problems with 'inline'.
3583 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3584 (window_box_width, window_box_left, window_box_left_offset)
3585 (window_box_right, window_box_right_offset): Declare extern.
3586 Otherwise, these inline functions do not conform to C99 and
3587 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3588 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3589 * intervals.c (adjust_intervals_for_insertion)
3590 (adjust_intervals_for_deletion): Now extern, because otherwise the
3591 extern inline functions 'offset_intervals' couldn't refer to it.
3592 (static_offset_intervals): Remove.
3593 (offset_intervals): Rewrite using the old contents of
3594 static_offset_intervals. The old version didn't conform to C99
3595 because an extern inline function contained a reference to an
3596 identifier with static linkage.
3597
b7041366
AS
35982011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3599
3600 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3601 GC.
3602
88a37c4d
EZ
36032011-11-06 Eli Zaretskii <eliz@gnu.org>
3604
3605 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3606 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3607 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3608 return Qleft_to_right.
3609
49745b39
CY
36102011-11-06 Chong Yidong <cyd@gnu.org>
3611
3612 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3613 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3614 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3615 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3616 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3617 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3618 (Fwindow_vscroll): Doc fix.
3619 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3620 argument, since it makes no sense to pass a live window and for
3621 consistency with window-child.
3622
1f05cd82
CS
36232011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3624
3625 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3626 support MSVC.
3627
22610910
JR
36282011-11-05 Jason Rumney <jasonr@gnu.org>
3629
3630 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3631 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3632 fonts (Bug#6029).
3633 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3634 bitwise arithmetic preventing use of unicode-sip and non-truetype
3635 opentype fonts.
3636
a06776b2
EZ
36372011-11-05 Eli Zaretskii <eliz@gnu.org>
3638
3ad924ba
EZ
3639 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3640 "emacs"-only part.
3641
a06776b2
EZ
3642 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3643 initialization code to keep similarity to xfns.c after changes
3644 from 2011-11-05.
3645
c9e7db78
JD
36462011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3647
a97f8f3f
JD
3648 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3649 (unwind_create_frame): New function (Bug#9943).
3650 (Fx_create_frame): Restructure code to be more similar to the one in
3651 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3652 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3653 Move terminal->reference_count++ just before making the frame official
3654 (Bug#9943).
3655
3656 * nsterm.m (x_free_frame_resources): New function.
3657 (x_destroy_window): Move code to x_free_frame_resources.
3658
c9e7db78 3659 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3660 (Fx_create_frame, x_create_tip_frame):
3661 Move terminal->reference_count++ just before making the frame
75f1671a 3662 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3663 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3664
a6fc3b5c
EZ
36652011-11-05 Eli Zaretskii <eliz@gnu.org>
3666
3667 Support MSVC build with newer versions of Visual Studio.
3668 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3669 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3670 nt/gmake.defs.
3671
3672 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3673 which are not supported by MSVC.
3674 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3675 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3676 bitfields.
3677 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3678 types in bitfields.
3679 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3680
3681 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3682
58179cce 36832011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3684
3685 Support MSVC build with newer versions of Visual Studio.
3686 * w32.c: Don't include w32api.h for MSVC.
3687 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3688
3689 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3690 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3691 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3692 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3693 e_* cousins.
3694 (alloca) [_MSC_VER]: Define to _alloca.
3695
3696 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3697
3698 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3699
a58c13ed
EZ
37002011-11-04 Eli Zaretskii <eliz@gnu.org>
3701
3702 * xdisp.c (note_mouse_highlight): If either of
3703 previous/next-single-property-change returns nil, treat that as
3704 the beginning or the end of the buffer. (Bug#9955)
3705
fe0b6370
JD
37062011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3707
a58c13ed 3708 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3709 label is not null (Bug#9951).
3710 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3711 may be NULL.
3712
89bd5ee1
EZ
37132011-11-04 Eli Zaretskii <eliz@gnu.org>
3714
3715 * window.c (Fwindow_body_size): Mention in the doc string that the
3716 return value is in frame's canonical units. (Bug#9949)
3717
84c3edb9
EZ
37182011-11-03 Eli Zaretskii <eliz@gnu.org>
3719
4e2fb5c7
EZ
3720 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3721
84c3edb9 3722 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3723 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3724 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3725
bc17a887
EZ
37262011-11-01 Eli Zaretskii <eliz@gnu.org>
3727
3728 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3729 Don't stop backward scan on the continuation glyph, even though
3730 its CHARPOS is positive.
6d5eb5b0
SM
3731 (mouse_face_from_buffer_pos, note_mouse_highlight):
3732 Rename cover_string to disp_string.
bc17a887 3733
4ee88440
MR
37342011-11-01 Martin Rudalics <rudalics@gmx.at>
3735
3736 * window.c (temp_output_buffer_show): Don't use
3737 Vtemp_buffer_show_specifiers.
3738 (Vtemp_buffer_show_specifiers): Remove unused variable.
3739
c2ff3c02
EZ
37402011-10-30 Eli Zaretskii <eliz@gnu.org>
3741
3742 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3743 past the beginning of the current glyph matrix.
3744
58179cce 37452011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3746
3747 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3748 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3749 HAVE_GTK3 (Bug#9869).
b77a6a7f 3750
3b574623
JD
3751 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3752 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3753
b77a6a7f
JD
3754 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3755
3756 * xterm.c: Declare x_handle_net_wm_state to return int.
3757 (handle_one_xevent): Check if we are iconified but don't have
3758 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3759 (get_current_wm_state): Return non-zero if not hidden,
3760 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3761 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3762 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3763 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3764
196e41e4
PE
37652011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3766
3767 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3768 so that this new function doesn't get optimized away by a
3769 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3770
021f2e1a
AS
37712011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3772
3773 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3774
8b058d44
EZ
37752011-10-29 Eli Zaretskii <eliz@gnu.org>
3776
3777 Fix the `xbytecode' command.
3778 * .gdbinit (xprintbytestr): New command.
b50a28de 3779 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3780 (xbytecode): Print the byte-code string as well.
3781
4452fb80
EZ
37822011-10-29 Kim Storm <storm@cua.dk>
3783
8b058d44
EZ
3784 * alloc.c (which_symbols): New function.
3785
21b72067
AS
37862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3787
3788 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3789 line. (Bug#9903)
3790
83ed7b5c
GM
37912011-10-29 Glenn Morris <rgm@gnu.org>
3792
3793 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3794 Not clear what it was for, and it causes various bugs. (Bug#9839)
3795
5a7a728b
EZ
37962011-10-28 Eli Zaretskii <eliz@gnu.org>
3797
3798 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3799 possible random value that matches one of those tested as
3800 condition to clear the mouse face.
3801
d3d0842f
CY
38022011-10-28 Chong Yidong <cyd@gnu.org>
3803
3804 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3805
31b39d13
DN
38062011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3807
3808 * window.c (make_window): Initialize phys_cursor_on_p.
3809
9aba6043
SM
38102011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3811
3812 * lisp.h (struct Lisp_Symbol): Update comments.
3813
c20992f4
JB
38142011-10-28 Juanma Barranquero <lekktu@gmail.com>
3815
3816 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3817
db4f02f2
EZ
38182011-10-28 Eli Zaretskii <eliz@gnu.org>
3819
3820 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3821 <oslsachem@gmail.com> for helping to debug this.
3822
3823 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3824 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3825 (g_b_init_get_glyph_outline_w): New static variables.
3826 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3827 (GetGlyphOutlineW_Proc): New typedefs.
3828 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3829 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3830 New functions.
3831 (w32font_open_internal, compute_metrics):
3832 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3833 instead of calling the "wide" APIs directly.
3834
3835 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3836
3837 * w32.h (syms_of_w32font): Add prototype.
3838
87e68db4
JB
38392011-10-27 Juanma Barranquero <lekktu@gmail.com>
3840
3841 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3842 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3843 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3844 (Fmove_to_window_line): Doc fix.
3845
435c1d67
CY
38462011-10-27 Chong Yidong <cyd@gnu.org>
3847
3848 * process.c (make_process): Set gnutls_state to NULL.
3849
3850 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3851 non-NULL, regardless of GNUTLS_INITSTAGE.
3852 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3853 an error. Set process slots as soon as we allocate them.
3854
3855 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3856
9c6c6f49
CY
38572011-10-27 Chong Yidong <cyd@gnu.org>
3858
9aba6043
SM
3859 * gnutls.c (emacs_gnutls_deinit): New function.
3860 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3861 (Fgnutls_deinit, Fgnutls_boot): Use it.
3862
3863 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3864 (deactivate_process): Call emacs_gnutls_deinit.
3865
657d08d3
JB
38662011-10-27 Juanma Barranquero <lekktu@gmail.com>
3867
3868 * image.c (x_create_x_image_and_pixmap):
3869 * w32.c (sys_rename, w32_delayed_load):
3870 * w32font.c (fill_in_logfont):
3871 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3872
5430d399
JB
38732011-10-26 Juanma Barranquero <lekktu@gmail.com>
3874
3875 * w32fns.c (w32_default_color_map): New function,
3876 extracted from Fw32_default_color_map.
a7ef684b 3877 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3878
fe0055fa
PE
38792011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3880
3881 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3882
e6346438
SM
38832011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3884
3885 * keyboard.c (test_undefined): New function (bug#9751).
3886 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3887
e112cc37
ET
38882011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3889
3890 * sysdep.c (init_sys_modes): Fix the check for the controlling
3891 terminal (Bug#6649).
3892
7b5d6677
EZ
38932011-10-20 Eli Zaretskii <eliz@gnu.org>
3894
3895 * dispextern.h (struct bidi_it): New member next_en_type.
3896
3897 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3898 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3899 current character, check also for next_en_type being WEAK_EN.
3900 (bidi_resolve_weak): Don't enter the expensive loop if the current
3901 position is before next_en_pos. Record the bidi type of the first
3902 non-ET, non-BN character we find, in addition to its position.
3903 (bidi_level_of_next_char): Invalidate next_en_type when
3904 next_en_pos is over-stepped.
3905
7da0b018
PE
39062011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3907
3908 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3909 * editfns.c: Rewrite current-time-zone so that it invokes
3910 the equivalent of (format-time-string "%Z") to get the time zone name.
3911 This fixes a bug when the time zone name contains characters that
3912 need converting from the system time locale to Emacs internal format.
3913 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3914 that patch fixed format-time-string to do the conversion, but
3915 I forgot to fix current-time-zone.
3916 (format_time_string): New function, containing most of
3917 what Fformat_time_string used to contain.
3918 (Fformat_time_string): Rewrite in terms of format_time_string.
3919 This doesn't change this function's behavior.
3920 (current-time-zone): Rewrite to use format_time_string.
3921 This fixes the bug reported by Michael Schierl in
3922 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3923 Jason Rumney's 2007-06-07 change worked around this bug, but
3924 didn't fix it.
3925 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3926
8547b010
EZ
39272011-10-19 Eli Zaretskii <eliz@gnu.org>
3928
3929 * xdisp.c (start_display): If the character at POS is displayed
3930 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3931 (try_window_reusing_current_matrix): If a line ends in a display
3932 vector or the next line starts in a display vector, continue
3933 redrawing the window even though the character position of
3934 start_row was reached.
8547b010
EZ
3935 (Bug#9771, part 2)
3936
4e948d15
CY
39372011-10-18 Chong Yidong <cyd@gnu.org>
3938
3939 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3940 with nobreak-char-display too.
3941
4787455f
EZ
39422011-10-18 Eli Zaretskii <eliz@gnu.org>
3943
3944 Fix part 3 of bug#9771.
3945 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3946 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3947 non-neutral characters if the current character is a paragraph
3948 separator (a.k.a. Newline). This avoids running the same
3949 expensive loop twice, once when we consume the preceding newline
3950 and the other time when the line actually needs to be displayed.
3951 Avoid the loop when we see neutrals on the base embedding level
3952 following a character whose directionality is the same as the
3953 paragraph's. This avoids running the expensive loop when a line
3954 ends in a long sequence of neutrals, like control characters.
3955 Add assertion against STRONG_AL type. Slightly rearrange code
3956 that determines the type of a neutral given the first non-neutral
3957 that follows it.
3958 (bidi_level_of_next_char): Set next_en_pos to zero when
3959 invalidating its info.
3960
2c91f553
EZ
39612011-10-17 Eli Zaretskii <eliz@gnu.org>
3962
3963 * xdisp.c (push_display_prop): Determine whether to record string
3964 or buffer position by IT->string, not by IT->method. Allow
3965 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3966 (move_it_vertically_backward): Don't look for character position
3967 immediately after the newline when in a continuation line.
3968 (Bug#9771, part 1)
2c91f553 3969
c7b08b0d
MR
39702011-10-15 Martin Rudalics <rudalics@gmx.at>
3971
3972 * window.c (coordinates_in_window): Rewrite and delabelize
3973 vertical border check. (Bug#5357) (Bug#9618)
3974
6b02f655
SM
39752011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3976
3977 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3978 errors in XSetWindowBorder (bug#9310).
3979
81d40c92
DA
39802011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3981
3982 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3983 avoid crash when xmalloc overrun checking is enabled.
3984
d4172c3b
EZ
39852011-10-13 Eli Zaretskii <eliz@gnu.org>
3986
3987 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3988 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3989 cursor motion with <left> and <right> arrow keys.
3990
3991 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3992 some callers set that themselves.
3993
b00eea75
EZ
39942011-10-12 Eli Zaretskii <eliz@gnu.org>
3995
3996 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3997 display string and the previous row comes from the same string and
3998 is empty. (Bug#9739) (Bug#9738)
3999
8fe012c4
SM
40002011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4001
4002 * doc.c (get_doc_string): Encode file name (bug#9735).
4003
0074aef2
EZ
40042011-10-12 Eli Zaretskii <eliz@gnu.org>
4005
79beb178
EZ
4006 * bidi.c (bidi_level_of_next_char):
4007 * xdisp.c (get_visually_first_element): Remove old incorrect
4008 comments regarding the Unicode Line Separator character.
4009
0074aef2
EZ
4010 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4011
6e4b3fbe
DA
40122011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4013
4014 * alloc.c (Fgc_status): Do not access beyond zombies array
4015 boundary if nzombies > MAX_ZOMBIES.
4016 * alloc.c (dump_zombies): Add missing format specifier.
4017
0324f3af
PE
40182011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4019
b5525cac
PE
4020 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4021 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4022
0324f3af
PE
4023 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4024 Some packages use them to denote characters with modifiers.
4025
e9b5f888
AS
40262011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4027
4028 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4029 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4030 matching a pp-number. Rename parameter var to var1.
4031
127827c0
SM
40322011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4033
4034 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4035
c8fd3bd0
GM
40362011-10-08 Glenn Morris <rgm@gnu.org>
4037
4038 * callint.c (Fcall_interactively): Give a more explicit error for the
4039 'c' case with a non-character input. (Bug#8479)
4040
352ec8ff
EZ
40412011-10-08 Eli Zaretskii <eliz@gnu.org>
4042
03669ccb
EZ
4043 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4044 lines.
7061c986
EZ
4045 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4046 lines that are hscrolled on the left.
03669ccb 4047
352ec8ff
EZ
4048 * dispnew.c (buffer_posn_from_coords): Account for a possible
4049 presence of header-line. (Bug#4426)
4050
a66cfb1c
SM
40512011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4052
6b02f655
SM
4053 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4054 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4055
7c5ee88e
PE
40562011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4057
4058 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4059 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4060 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4061 this makes Emacs dump core during garbage collection on rare
4062 occasions. sizeof is obviously inferior to offsetof here, so
4063 stick with offsetof.
4064 (GC_POINTER_ALIGNMENT): New macro.
4065 (mark_memory): Omit 3rd (offset) arg; caller changed.
4066 Don't assume EMACS_INT alignment is the same as pointer alignment.
4067
df1bbe5b
SM
40682011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4069
4070 * keyboard.c (read_key_sequence_remapped): New var.
4071 (read_key_sequence): Compute remapping in the right buffer.
4072 (command_loop_1): Use read_key_sequence's remapping directly.
4073
51553db6
SM
40742011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4075
32c1fffd
SM
4076 * dired.c (file_name_completion): Don't expand file name.
4077 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4078 before checking file name handler.
4079
51553db6
SM
4080 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4081 they've been requested explicitly (bug#9591).
4082
b6bd1599 40832011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4084
4085 * keymap.c (Fsingle_key_description): Use make_specified_string
4086 instead of build_string to build string from push_key_description.
4087 (Bug#5193)
4088
f701dc2a
PE
40892011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4090
4222c55d
PE
4091 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4092 This fixes a Y2038 bug on 64-bit hosts.
4093 * buffer.c (reset_buffer):
4094 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4095 (Fclear_buffer_auto_save_failure):
4096 Use 0, not -1, to represent an unset failure time, since time_t
4097 might not be signed.
4098
f701dc2a
PE
4099 Remove dependency on glibc malloc internals.
4100 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4101 Move back here from lisp.h, but with their new implementations.
4102 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4103 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4104 * charset.c (charset_table_init): New static var.
4105 (syms_of_charset): Use it instead of xmalloc. This removes a
4106 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4107 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4108 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4109 Move back to alloc.c.
4110 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4111 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4112
9ceebf39
JD
41132011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4114
4115 * nsterm.m (windowDidResize): Call x_set_window_size only when
4116 ns_in_resize is true. Otherwise set pixelwidth/height and
4117 call change_frame_size (Bug#9628).
4118
cb993c58
PE
41192011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4120
3930c88b
PE
4121 Port --enable-checking=all to Fedora 14 x86-64.
4122 * charset.c (syms_of_charset): Also account for glibc malloc's
4123 internal overhead when calculating the initial malloc maximum.
4124
cb993c58
PE
4125 Port --enable-checking=all to Fedora 14 x86.
4126 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4127 Move to lisp.h.
4128 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4129 (overrun_check_realloc, overrun_check_free):
4130 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4131 That way, xmalloc returns a properly-aligned pointer even if
4132 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4133 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4134 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4135 into account when calculating the initial malloc maximum.
4136 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4137 Move here from alloc.c, so that charset.c can use it too.
4138 Properly align; the old code wasn't right for common 32-bit hosts
4139 when configured with --enable-checking=all.
4140 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4141 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4142
31bed486
EZ
41432011-09-29 Eli Zaretskii <eliz@gnu.org>
4144
04c70788 4145 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4146 use EDOM.
4147
fbcaa2f3
EZ
41482011-09-28 Eli Zaretskii <eliz@gnu.org>
4149
4150 * xdisp.c (compute_display_string_end): If there's no display
4151 string at CHARPOS, return -1.
4152
4153 * bidi.c (bidi_fetch_char): When compute_display_string_end
4154 returns a negative value, treat the character as a normal
4155 character not covered by a display string. (Bug#9624)
4156
a239d4e9
JB
41572011-09-28 Juanma Barranquero <lekktu@gmail.com>
4158
4159 * lread.c (Fread_from_string): Fix typo in docstring.
4160
88652fd5
EZ
41612011-09-27 Eli Zaretskii <eliz@gnu.org>
4162
4163 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4164 newline, reseat the iterator instead of bidi-iterating there one
4165 character at a time. (Bug#9610)
32c1fffd
SM
4166 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4167 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4168
ed497dd4
AS
41692011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4170
4171 * lread.c (readevalloop): Use correct code for NBSP.
4172 (read1): Likewise. (Bug#9608)
4173
b2bf61aa
MA
41742011-09-25 Michael Albinus <michael.albinus@gmx.de>
4175
4176 * dbusbind.c (Fdbus_register_signal): When service is not
4177 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4178
32bbb17c
GM
41792011-09-25 Glenn Morris <rgm@gnu.org>
4180
4181 * buffer.c (truncate-lines): Doc fix.
4182
94e0933e
CY
41832011-09-24 Chong Yidong <cyd@stupidchicken.com>
4184
4185 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4186 (Fset_window_next_buffers): Doc fix.
4187
cddde921
GM
41882011-09-24 Glenn Morris <rgm@gnu.org>
4189
4190 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4191
1260aef1
PE
41922011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4193
25b4bfa0
PE
4194 Fix minor problems found by static checking.
4195 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4196 * indent.c (Fvertical_motion): Fix == vs = typo.
4197
e3cbd34b
EZ
41982011-09-24 Eli Zaretskii <eliz@gnu.org>
4199
a66cfb1c
SM
4200 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4201 Default value is now t. Doc fix.
6bf7006f 4202
e3cbd34b 4203 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4204 logic when moving up, not only when moving down. Fix the
e3cbd34b 4205 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4206 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4207
4208 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4209 CHARPOS is covered by a display string which includes newlines.
4210 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4211 is covered by a display string with embedded newlines.
4212
a3de0cbd
MA
42132011-09-24 Michael Albinus <michael.albinus@gmx.de>
4214
4215 * dbusbind.c (Fdbus_register_signal): Add match rule to
4216 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4217 (Fdbus_register_method, Vdbus_registered_objects_table):
4218 Fix docstring.
a3de0cbd 4219
b260039d
JM
42202011-09-24 Jim Meyering <meyering@redhat.com>
4221
32c1fffd 4222 do not ignore write error for any output size
b260039d
JM
4223 The previous change was incomplete.
4224 While it makes emacs --batch detect the vast majority of stdout
4225 write failures, errors were still ignored whenever the output size is
4226 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4227 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4228 && echo FAIL: ignored write error
4229 FAIL: ignored write error
4230 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4231 && echo FAIL: ignored write error
4232 FAIL: ignored write error
4233 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4234
8eca8a7c
AS
42352011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4236
4237 * emacs.c (Fkill_emacs): In noninteractive mode exit
4238 non-successfully if a write error occurred on stdout. (Bug#9574)
4239
3341db62
EZ
42402011-09-21 Eli Zaretskii <eliz@gnu.org>
4241
4242 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4243 the xassert test.
4244
4245 * dispextern.h (struct it): Update the comment documenting what
4246 can it->OBJECT be.
4247
8c203dbf
EZ
42482011-09-20 Eli Zaretskii <eliz@gnu.org>
4249
4250 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4251 a display string, extend search for cursor position to end of row.
4252 (find_row_edges): If the row ends in a newline from a display
4253 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4254 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4255 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4256 non-empty line. Fixes confusing cursor motion with arrow keys at
4257 the beginning of a line that starts with whitespace.
8c203dbf 4258
a4824228
LMI
42592011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4260
4261 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4262 (bug#9493).
4263
33ed493b
CY
42642011-09-18 Chong Yidong <cyd@stupidchicken.com>
4265
4266 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4267 boolean (Bug#9154).
4268
56cd55c8
EZ
42692011-09-18 Eli Zaretskii <eliz@gnu.org>
4270
4271 * xdisp.c (display_line): Record maximum and minimum buffer
4272 positions even if no glyphs were produced (e.g., by a zero-width
4273 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4274 buffer positions that will be removed from the glyph row because
4275 they don't fit.
c02dcedf
EZ
4276 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4277 column is beyond frame width: don't subtract 1 "pixel" when
4278 computing width of the stretch.
3e62b7e0
EZ
4279 (reseat_at_next_visible_line_start): Undo the change made on
4280 2011-09-17 that saved paragraph information and restored it after
4281 the call to `reseat'. (Bug#9545)
56cd55c8 4282
5ed99d36 42832011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4284
4285 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4286 and turn window cursor on if cleared (Bug#9415).
4287
5ed99d36 42882011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4289
4290 * search.c (boyer_moore): Take unibyte characters from pattern
4291 literally. (Bug#9458)
4292
9bade7b2
EZ
42932011-09-18 Eli Zaretskii <eliz@gnu.org>
4294
4295 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4296
e5e9d610
PE
42972011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4298
87e4427a
PE
4299 Fix minor problem found by static checking.
4300 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4301 initialized, to pacify gcc -Wuninitialized.
4302
e5e9d610
PE
4303 * fileio.c: Report proper errno when syscall falls.
4304 (Finsert_file_contents): Save and restore errno,
4305 so that report_file_error outputs the correct diagnostic.
4306 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4307
a1674f0b
EZ
43082011-09-18 Eli Zaretskii <eliz@gnu.org>
4309
4310 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4311
fbfb6dd4
EZ
43122011-09-17 Eli Zaretskii <eliz@gnu.org>
4313
4314 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4315 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4316
bb187662
EZ
43172011-09-17 Eli Zaretskii <eliz@gnu.org>
4318
1137e8b8 4319 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4320 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4321
4322 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4323 (bidi_find_paragraph_start): Search back for paragraph beginning
4324 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4325 (bidi_move_to_visually_next): Only trigger paragraph-related
4326 computations when the last character is a newline or at EOB, not
4327 just any NEUTRAL_B. (Bug#9470)
4328
bb187662
EZ
4329 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4330 truncated lines if point is covered by a display string. (Bug#9524)
4331
2e621251
PE
43322011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4333
4334 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4335 (cons_to_x_long): New function.
4336 (lisp_data_to_selection_data): Use it. Correct the test for
4337 short-versus-long data; it was negated. Break out of vector
4338 loop, for efficiency, when a long datum is discovered.
4339
91a15bc6
SM
43402011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4341
4342 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4343
b41c3a35
EZ
43442011-09-16 Eli Zaretskii <eliz@gnu.org>
4345
4346 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4347 GCC PR/17406) by declaring this function with external scope.
4348
7812ba2d
PE
43492011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4350
4351 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4352 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4353
cf7edc2a
AS
43542011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4355
4356 * editfns.c (Fformat): Correctly handle text properties on "%%".
4357
bd01620e
EZ
43582011-09-15 Eli Zaretskii <eliz@gnu.org>
4359
4360 * xterm.c (x_draw_composite_glyph_string_foreground):
4361 * w32term.c (x_draw_composite_glyph_string_foreground):
4362 * term.c (encode_terminal_code):
4363 * composite.c (composition_update_it, get_composition_id):
4364 * xdisp.c (get_next_display_element)
4365 (fill_composite_glyph_string): Add comments about special meaning
4366 of TAB characters in a composition.
4367
a02719a3
PE
43682011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4369
4370 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4371 This occurs when processing a multibyte format.
4372 Problem reported by Wolfgang Jenker.
a02719a3 4373
72589a3c
JB
43742011-09-15 Johan Bockgård <bojohan@gnu.org>
4375
4376 * xdisp.c (try_cursor_movement): Only check for exact match if
4377 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4378
1c14176c
PE
43792011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4380
4381 Remove unused external symbols.
4382 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4383 * xdisp.c (calc_pixel_width_or_height): Now static.
4384 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4385 * indent.c (check_display_width):
4386 * w32term.c: Fix comment to match code.
4387 * xterm.c, xterm.h (x_catching_errors): Remove.
4388
d2eea5b5
PE
43892011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4390
4391 * xselect.c: Use signed conversions more consistently (Bug#9498).
4392 (selection_data_to_lisp_data): Assume incoming selection data are
4393 signed integers, not unsigned. This is to be consistent with
4394 outgoing selection data, which was modified to use signed integers
4395 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4396 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4397 expects long, not unsigned long.
4398
46888499
EZ
43992011-09-14 Eli Zaretskii <eliz@gnu.org>
4400
4401 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4402 computation of loop end. Reported by Johan Bockgård
4403 <bojohan@gnu.org>.
4404
ef8ef9fb
CY
44052011-09-13 Chong Yidong <cyd@stupidchicken.com>
4406
4407 * frame.c (Fother_visible_frames_p): Function deleted.
4408
fa819fed
EZ
44092011-09-12 Eli Zaretskii <eliz@gnu.org>
4410
4411 * indent.c (compute_motion): Process display vector front to back
4412 rather than the other way around. (Bug#2496)
4413
2ba8e008
SM
44142011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4415
4416 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4417
20f53c69
CY
44182011-09-11 Chong Yidong <cyd@stupidchicken.com>
4419
4420 * minibuf.c (Fread_from_minibuffer): Doc fix.
4421
d562d7a4
EZ
44222011-09-11 Eli Zaretskii <eliz@gnu.org>
4423
4424 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4425 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4426
1c4d7f3d
LMI
44272011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4428
4429 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4430 value for non-existent files.
4431
b885bf36
EZ
44322011-09-11 Eli Zaretskii <eliz@gnu.org>
4433
4434 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4435 set its "size" to -1. This will set the modtime_size field of
4436 the corresponding buffer to -1, which is what
4437 verify-visited-file-modtime expects for files that do not exist.
4438 (Bug#9139)
4439
6612f0bf
PE
44402011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4441
4442 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4443 here ...
4444 * lisp.h: ... from here. push_key_description is no longer
4445 defined in keyboard.c, so its declaration should not be in
4446 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4447 logically belongs with push_key_description.
4448
dfb3f755
PE
44492011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4450
4451 * buffer.h: Include <sys/types.h> instead of <time.h>.
4452 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4453 Problem reported by Herbert J. Skuhra.
4454
3134906c
LMI
44552011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4456
4457 * xml.c (parse_region): Make the parsing work for
4458 non-comment-starting XML files again (bug#9144).
4459
8d903f4e
AS
44602011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4461
4462 * image.c (gif_load): Fix calculation of bottom and right corner.
4463 (Bug#9468)
4464
80ad64f4
EZ
44652011-09-10 Eli Zaretskii <eliz@gnu.org>
4466
4467 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4468 redisplay in small windows.
4469
208a048d
EZ
44702011-09-09 Eli Zaretskii <eliz@gnu.org>
4471
4472 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4473
9b1c252e
MR
44742011-09-08 Martin Rudalics <rudalics@gmx.at>
4475
4476 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4477 Operate on live windows only.
4478
2949f33b
JB
44792011-09-08 Juanma Barranquero <lekktu@gmail.com>
4480
4481 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4482
e08dcafd
EZ
44832011-09-07 Eli Zaretskii <eliz@gnu.org>
4484
4485 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4486 only under bidi iteration.
4487
115b96bd
JD
44882011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4489
4490 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4491
c8199d0f
PE
44922011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4493
4494 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4495 Without this fix, the command to link temacs failed due to an
4496 undefined symbol __builtin_isnan. This is because
4497 /usr/include/iso/math_c99.h #defines isnan(x) to
4498 __builtin_isnan(x), but the bundled gcc, which identifies itself
4499 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4500 a __builtin_isnan.
4501 * floatfns.c (isnan): #undef, and then #define to a clone of
4502 what's in data.c.
4503 (Fisnan): Always define, since it's always available now.
4504 (syms_of_floatfns): Always define isnan at the Lisp level.
4505
e39b275c 45062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4507
4508 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4509
b2db44d9 45102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4511
f4af5137 4512 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4513 The previous code assumed that file offsets (off_t values) fit in
4514 EMACS_INT variables, which is not true on typical 32-bit hosts.
4515 The code messed up by falsely reporting buffer overflow in cases
4516 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4517 when "big" contains more than 2**29 bytes, even though this
4518 inserts just one byte and does not overflow the buffer.
4519 (Finsert_file_contents): Store file offsets as off_t
4520 values, not as EMACS_INT values. Check for overflow when
4521 converting between EMACS_INT and off_t. When checking for
4522 buffer overflow or for overlap, take the offsets into account.
4523 Don't use EMACS_INT for small values where int suffices.
4524 When checking for overlap, fix a typo: ZV was used where
4525 ZV_BYTE was intended.
4526 (Fwrite_region): Don't assume off_t fits into 'long'.
4527 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4528
ecfc0a49
MA
45292011-09-05 Michael Albinus <michael.albinus@gmx.de>
4530
4531 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4532
6511acf2 45332011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4534
0999621a 4535 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4536
4537 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4538 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4539 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4540 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4541 (modify_event_symbol): Do not assume that the length of
4542 name_alist_or_stem is safe to alloca and fits in int.
4543 (Fexecute_extended_command): Likewise for function name and binding.
4544 (Frecursion_depth): Wrap around reliably on integer overflow.
4545 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4546 since some callers pass EMACS_INT values.
4547 (Fsingle_key_description): Don't crash if symbol name contains more
4548 than MAX_ALLOCA bytes.
4549 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4550 (get_minibuffer): Arg is now EMACS_INT, not int.
4551 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4552 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4553 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4554
2be7d702
PE
4555 * dbusbind.c (signature_cat): New function.
4556 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4557 Do not overrun buffer; instead, report string overflow.
4558
9d1df220
PE
4559 * dispnew.c (add_window_display_history): Don't overrun buffer.
4560 Truncate instead; this is OK since it's just a log.
4561
33ef5c64
PE
4562 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4563 even if the time zone offset is outlandishly large.
4564 Don't mishandle offset == INT_MIN.
4565
66c6fdd5
PE
4566 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4567 when creating daemon; the previous buffer-overflow check was incorrect.
4568
d749b01b
PE
4569 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4570 which has the guts of the old verror function.
4571
b5cd1905
PE
4572 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4573 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4574
6e1a67fb
PE
4575 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4576 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4577 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4578 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4579 length of string rather than counting it via multiple sprintfs;
4580 that's simpler and more reliable.
c21721cc
PE
4581 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4582 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4583 sprintf, in case result does not fit in int.
4584
c57b67fc
PE
4585 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4586 (fontset_from_font): Print it.
4587
8a401434
PE
4588 * frame.c (tty_frame_count): Now printmax_t, not int.
4589 (make_terminal_frame, set_term_frame_name): Print it.
4590 (x_report_frame_params): In X, window IDs are unsigned long,
4591 not signed long, so print them as unsigned.
4592 (validate_x_resource_name): Check for implausibly long names,
4593 and don't assume name length fits in 'int'.
4594 (x_get_resource_string): Don't blindly alloca invocation name;
4595 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4596 not fit in int.
4597
6e1a67fb
PE
4598 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4599 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4600 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4601
0df02bf3
PE
4602 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4603 Use esprintf, not sprintf, in case result does not fit in int.
4604
48e30793
PE
4605 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4606 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4607 it as a large positive number.
4608 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4609 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4610
a66ff6d8
PE
4611 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4612 in case result does not fit in int.
4613
aca216ff
PE
4614 * print.c (float_to_string): Detect width overflow more reliably.
4615 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4616 buffer overrun. Don't assume list length fits in 'int'. Treat
4617 print length of 0 as 0, not as infinity; to be consistent with other
4618 uses of print length in this function. Don't overflow print length
4619 index. Don't assume hash table size fits in 'long', or that
4620 vectorlike size fits in 'unsigned long'.
4621
31c286f7
PE
4622 * process.c (make_process): Use printmax_t, not int, to format
4623 process-name gensyms.
4624
55e5faa1
PE
4625 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4626
80f2e268
PE
4627 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4628 to avoid potential buffer overrun.
4629
670741ab
PE
4630 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4631 if X resource line is longer than 512 bytes.
4632
b7163a50
PE
4633 * xfns.c (x_window): Make sprintf buffer a bit bigger
4634 to avoid potential buffer overrun.
4635
ae58ff1f
PE
4636 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4637
c43c8a6a
PE
4638 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4639
3f8236f4
PE
46402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4641
53e9fe90 4642 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4643 Without these, Emacs silently mishandles large integers sometimes.
4644 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4645 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4646
6511acf2
PE
4647 * xdisp.c (try_window_id): Check Emacs fixnum range before
4648 converting to 'int'.
806add1d 4649
6511acf2 4650 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4651 Check that an Emacs fixnum is in range before assigning it to 'int'.
4652 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4653 values converted from Emacs fixnums.
4654 (Frecenter): Don't wrap around a line count if it is out of 'int'
4655 range; instead, treat it as an extreme value.
4656 (Fset_window_configuration, compare_window_configurations):
4657 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4658
6511acf2
PE
4659 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4660 that can exceed INT_MAX. Check that EMACS_INT value is in range
4661 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4662 (match_limit): Don't assume that a fixnum can fit in 'int'.
4663
6511acf2 4664 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4665 exceed INT_MAX.
4666
6511acf2 4667 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4668 (Fvertical_motion): Don't wrap around LINES values that don't fit
4669 in 'int'. Instead, treat them as extreme values. This is good
4670 enough for windows, which can't have more than INT_MAX lines anyway.
4671
fcb901a7
LMI
46722011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4673
0f2f6b6d
LMI
4674 * Require libxml/parser.h to avoid compilation warning.
4675
fcb901a7
LMI
4676 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4677
4678 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4679 since this reportedly can destroy thread storage.
4680
6e20a0d4
CY
46812011-08-30 Chong Yidong <cyd@stupidchicken.com>
4682
4683 * syntax.c (find_defun_start): Update all cache variables if
4684 exiting early (Bug#9401).
4685
148ae00e
EZ
46862011-08-30 Eli Zaretskii <eliz@gnu.org>
4687
f6cfbd8f
EZ
4688 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4689
148ae00e
EZ
4690 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4691 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4692 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4693
4694 * term.c (tty_append_glyph): New function.
4695 (produce_stretch_glyph): Static function and its prototype deleted.
4696
a66cfb1c
SM
4697 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4698 Add prototypes.
148ae00e 4699
c4a07a4c
PE
47002011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4701
4702 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4703 when checking :margin (Bug#9390).
4704 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4705 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4706 so that the name doesn't mislead. All uses changed.
4707
6bc8cd65
JB
47082011-08-28 Johan Bockgård <bojohan@gnu.org>
4709
4710 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4711 set_tty_hooks.
4712
dca4927e
EZ
47132011-08-27 Eli Zaretskii <eliz@gnu.org>
4714
4715 * xdisp.c (move_it_to): Don't bail out early when reaching
4716 position beyond to_charpos, if we are scanning backwards.
4717 (move_it_vertically_backward): When DY == 0, make sure we get to
4718 the first character in the line after the newline.
4719
f2cad773
PE
47202011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4721
4722 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4723 (ccl_driver): Do not generate an out-of-range pointer.
4724 (Fccl_execute_on_string): Remove unnecessary check for
4725 integer overflow, noted by Stefan Monnier in
4726 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4727 Remove a FIXME that didn't need fixing.
4728 Simplify the newly-introduced buffer reallocation code.
4729
0cae2cdb
JB
47302011-08-27 Juanma Barranquero <lekktu@gmail.com>
4731
4732 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4733
5fc295a4 47342011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4735
70c60eb2 4736 Integer and memory overflow issues (Bug#9196).
726e0ab1 4737
d31850da
PE
4738 * doc.c (get_doc_string): Rework so that
4739 get_doc_string_buffer_size is the actual buffer size, rather than
4740 being 1 less than the actual buffer size; this makes xpalloc more
4741 convenient.
4742
a69fbedb
PE
4743 * image.c (x_allocate_bitmap_record, cache_image):
4744 * xselect.c (Fx_register_dnd_atom):
4745 Simplify previous changes by using xpalloc.
4746
fe5c5d37
PE
4747 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4748 since either will do and ptrdiff_t is convenient with xpalloc.
4749
0065d054
PE
4750 * charset.c (charset_table_size)
4751 (struct charset_sort_data.priority): Now ptrdiff_t.
4752 (charset_compare): Don't overflow if priorities differ greatly.
4753 (Fsort_charsets): Don't assume list length fits in int.
4754 Check for size-calculation overflow when allocating sort data.
4755 (syms_of_charset): Allocate an initial charset table that is
4756 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4757
4758 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4759
4760 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4761 The actual value is always <= INT_MAX, and leaving it unsigned made
4762 overflow checking harder.
4763
4764 * dispextern.h (struct glyph_matrix.rows_allocated)
4765 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4766 with xpalloc. The values are still always <= INT_MAX.
4767
4768 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4769
4770 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4771 (SAFE_NALLOCA): New macro.
4772
4773 * region-cache.c (struct boundary.pos, find_cache_boundary)
4774 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4775 (set_cache_region, invalidate_region_cache)
4776 (revalidate_region_cache, know_region_cache, region_cache_forward)
4777 (region_cache_backward, pp_cache):
4778 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4779 so that ptrdiff_t * can be passed to xpalloc.
4780 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4781 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4782 (pp_cache): Don't assume cache_len fits in int.
4783 * region-cache.h: Adjust extern decls to match.
4784
4785 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4786 EMACS_INT, since either will do, for xpalloc.
4787
4788 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4789 (xnmalloc, xnrealloc, xpalloc): New functions.
4790
726e0ab1
PE
4791 * bidi.c (bidi_shelve_header_size): New constant.
4792 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4793 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4794
51f30bc5 4795 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4796 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4797 (overlay_strings):
4798 Don't update size of array until after memory allocation succeeds,
4799 because xmalloc/xrealloc may not return.
0065d054
PE
4800 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4801 now that we have proper integer overflow checking.
4802 (record_overlay_string, overlay_strings): Catch overflows when
4803 calculating size of overlay_str_buf.
726e0ab1 4804
0065d054
PE
4805 * callproc.c (Fcall_process): Check for size overflow when
4806 calculating size of args2.
4807 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4808 Normally we prefer signed values, but sticking with ptrdiff_t would
4809 require adding more-complicated checks.
726e0ab1
PE
4810
4811 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4812 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4813 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4814 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4815
4816 * character.c (Fstring): Check for size-calculation overflow.
4817
4818 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4819 unnecessary integer overflow. Check for size overflow.
4820 (encode_coding_object): Don't update size until xmalloc succeeds.
4821
4822 * composite.c (get_composition_id): Check for overflow in glyph
4823 length calculations.
4824
4825 Integer and memory overflow fixes for display code.
4826 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4827 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4828 (scrolling_window): Check for overflow in size calculations.
4829 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4830 Don't assume glyph table len fits in int.
4831 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4832 (row_table_size): Now ptrdiff_t, not int.
4833 (scrolling_window): Avoid overflow in size calculations.
4834 Don't update size until allocation succeeds.
4835 * fns.c (concat): Check for overflow in size calculations.
4836 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4837 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4838 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4839
4840 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4841 (get_doc_string): Check for size calculation overflow.
4842 Don't update size until allocation succeeds.
4843 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4844 EMACS_INT, where ptrdiff_t will do.
4845 (Fsubstitute_command_keys): Check for string overflow.
4846
4847 * editfns.c (set_time_zone_rule): Don't assume environment length
4848 fits in int.
4849 (message_length): Now ptrdiff_t, not int.
4850 (Fmessage_box): Don't update size until allocation succeeds.
4851 Don't assume message length fits in int.
4852 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4853
0065d054
PE
4854 * emacs.c (main): Do not reallocate argv, since there is a null at
4855 the end that can be overwritten, and this way there's no need to
4856 worry about size-calculation overflow.
4857 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4858
4859 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4860 alloc succeeds.
4861 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4862
4863 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4864 (x_set_scroll_bar_width, x_figure_window_size):
4865 Check for integer overflow.
4866 (x_set_alpha): Do not assume XINT fits in int.
4867
4868 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4869 This is for the members text_lines, text_cols, total_lines, total_cols,
4870 where the system imposes an 'int' limit.
4871
4872 * fringe.c (Fdefine_fringe_bitmap):
4873 Don't update size until alloc works.
4874
4875 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4876 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4877
4878 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4879 Check for size-calculation overflow.
4880 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4881 do, as we prefer signed integers.
4882 (id_to_widget.max_size, id_to_widget.used)
4883 (xg_store_widget_in_map, xg_remove_widget_from_map)
4884 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4885 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4886 Use and return ptrdiff_t, not int.
4887 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4888 * gtkutil.h: Change prototypes to match the above.
4889
4890 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4891 are duplicate now that they've been promoted to lisp.h.
4892 (x_allocate_bitmap_record, x_alloc_image_color)
4893 (make_image_cache, cache_image, xpm_load):
4894 Don't update size until alloc is done.
4895 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4896 (x_detect_edges):
3256efce 4897 Check for size calculation overflow.
726e0ab1
PE
4898 (ct_colors_allocated_max): New constant.
4899 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4900 overflow.
3256efce 4901
726e0ab1
PE
4902 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4903 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4904 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4905 Use ptrdiff_t, not int, to count maps.
4906 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4907 calculations. Don't update size until allocation succeeds.
4908 Redo calculations to avoid overflow.
726e0ab1
PE
4909 * keyboard.h: Change prototypes to match the above.
4910
4911 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4912 to count maps.
4913 (current_minor_maps): Check for size calculation overflow.
4914 * keymap.h: Change prototypes to match the above.
4915
4916 * lread.c (read1, init_obarray): Don't update size until alloc done.
4917
4918 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4919 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4920
726e0ab1
PE
4921 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4922 Now ptrdiff_t, not int.
4923 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4924 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4925
4926 * process.c (Fnetwork_interface_list): Check for overflow
4927 in size calculation.
4928
4929 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4930
4931 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4932 overflow. Don't bother calling xmalloc when xrealloc will do.
4933
4934 * search.c (Freplace_match): Check for size calculation overflow.
4935 (Fset_match_data): Don't assume list lengths fit in 'int'.
4936
4937 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4938 for command line length. Do not attempt to address one before the
4939 beginning of an array, as that's not portable.
4940
4941 * term.c (max_frame_lines): Remove; unused.
4942 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4943 not int.
4944 (encode_terminal_code, calculate_costs): Check for size
4945 calculation overflow.
4946 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4947 table lengths and related sizes. Don't update size until alloc
4948 done. Redo calculations to avoid overflow.
4949 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4950
4951 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4952 subtracting pointers.
4953 (gobble_line): Check for overflow more carefully. Don't update size
4954 until alloc done.
4955
4956 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4957 Don't update size until alloc done.
4958 Redo size calculations to avoid overflow.
4959 Check for size calculation overflow.
0065d054 4960 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4961
4962 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4963 Use ptrdiff_t, not int, for sizes.
4964 (store_mode_line_noprop_char): Don't update size until alloc done.
4965
0065d054
PE
4966 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4967 Use ptrdiff_t, not int, for sizes.
4968 (Finternal_make_lisp_face, cache_face):
4969 Check for size calculation overflow.
4970 (cache_face): Treat size calculation overflows as if they were
4971 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4972
4973 * xfns.c (x_encode_text, x_set_name_internal)
4974 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4975 sizes, since they can exceed INT_MAX in size. Check for size
4976 calculation overflow.
4977
0065d054
PE
4978 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4979 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4980 Don't update size until alloc done.
4981
0065d054 4982 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4983 as sprintf is limited to int lengths.
1d526e2f 4984
252c5ee1
PE
4985 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4986 (X_LONG_MIN): New macros.
864d7ce7
PE
4987 Use them to make the following changes clearer.
4988 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4989 This change doesn't affect the value now, but it may help remind
4990 future maintainers not to raise the value too much later.
4991 (SELECTION_QUANTUM): Remove, replacing with ...
4992 (selection_quantum): ... new function, which avoids overflow.
4993 All uses changed.
4994 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4995 assumption that selection length fits in 'int'.
4996 (x_reply_selection_request, x_handle_selection_request)
4997 (x_get_window_property, receive_incremental_selection)
4998 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4999 (lisp_data_to_selection_data, clean_local_selection_data):
5000 Use ptrdiff_t, not int, to record length of selection.
5001 (x_reply_selection_request, x_get_window_property)
5002 (receive_incremental_selection, x_property_data_to_lisp):
5003 Redo calculations to avoid overflow.
5004 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5005 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5006 something.
5007 (x_get_window_property, receive_incremental_selection)
5008 (lisp_data_to_selection_data, x_property_data_to_lisp):
5009 Check for size-calculation overflow.
5010 (x_get_window_property, receive_incremental_selection)
5011 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5012 Don't store size until memory allocation succeeds.
5013 (x_get_window_property): Plug memory leak on memory exhaustion.
5014 Don't double-block input; malloc is safe here. Don't assume 2**34
5015 - 4 fits in unsigned long. Add an xassert to check
5016 XGetWindowProperty overflow. Be more careful about overflow
5017 calculations, and distinguish size from memory overflow better.
5018 (receive_incremental_selection): When tracing, don't assume
5019 unsigned int is less than INT_MAX.
5020 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5021 harmful) conversions of unsigned short to int.
5022 (lisp_data_to_selection_data): Don't assume that integers
5023 in the range -65535 through -1 fit in an X unsigned short.
5024 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5025 result parameters unless successful. Rely on cons_to_unsigned
5026 to report problems with elements; the old code wasn't right anyway.
5027 (x_check_property_data): Check for int overflow; we cannot use
5028 a wider type due to X limits.
5029 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5030
726e0ab1 5031 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5032
0065d054
PE
5033 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5034 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5035 (x_color_cells): Don't store size until memory allocation succeeds.
5036 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5037 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5038 (x_term_init): Don't assume length fits in int (sprintf is limited
5039 to int size).
bc18e09d 5040
ebfa62c0
PE
5041 Use ptrdiff_t for composition IDs.
5042 * character.c (lisp_string_width):
5043 * composite.c (composition_table_size, n_compositions)
5044 (get_composition_id, composition_gstring_from_id):
5045 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5046 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5047 * window.c (Frecenter):
5048 Use ptrdiff_t, not int, for composition IDs.
5049 * composite.c (get_composition_id): Check for integer overflow.
5050 * composite.h: Adjust prototypes to match the above changes.
5051
d3411f89
PE
5052 Use ptrdiff_t for hash table indexes.
5053 * category.c (hash_get_category_set):
5054 * ccl.c (ccl_driver):
5055 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5056 * coding.c (coding_system_charset_list, detect_coding_system):
5057 * coding.h (struct coding_system.id):
5058 * composite.c (get_composition_id, gstring_lookup_cache):
5059 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5060 * image.c (xpm_get_color_table_h):
5061 * lisp.h (hash_lookup, hash_put):
5062 * minibuf.c (Ftest_completion):
5063 Use ptrdiff_t for hash table indexes, not int (which is too
5064 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5065 32-bit --with-wide-int hosts).
5066
e097a6fa
PE
5067 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5068 Add a FIXME comment about memory leaks.
5069 (syms_of_charset): Don't assume xmalloc returns.
5070
5637687f
PE
5071 Don't assume that stated character widths fit in int.
5072 * character.c (Fchar_width, c_string_width, lisp_string_width):
5073 * character.h (CHAR_WIDTH):
5074 * indent.c (MULTIBYTE_BYTES_WIDTH):
5075 Use sanitize_char_width to avoid undefined and/or bad behavior
5076 with outlandish widths.
a66cfb1c 5077 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5078 now that we have two such functions. All uses changed.
5079 (sanitize_char_width): New inline function.
5080
a2271ba2
PE
5081 Don't assume that tab-width fits in int.
5082 * character.h (sanitize_width): New inline function.
5083 (SANE_TAB_WIDTH): New macro.
5084 (ASCII_CHAR_WIDTH): Use it.
5085 * indent.c (sane_tab_width): Remove. All uses replaced by
5086 SANE_TAB_WIDTH (current_buffer).
5087 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5088
18c52557
PE
5089 * fileio.c: Integer overflow issues with file modes.
5090 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5091
caeeedc1
PE
5092 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5093 Remove unreachable code.
5094 (read_hex, load_charset_map_from_file): Check for integer overflow.
5095
6df6ae42 5096 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5097 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5098 (x_send_scroll_bar_event): Likewise. Check that the size does not
5099 exceed limits imposed by XClientMessageEvent, as well as the usual
5100 ptrdiff_t and size_t limits.
5101
b13995db
PE
5102 * keyboard.c: Overflow, signedness and related fixes.
5103 (make_lispy_movement): Use same integer type in forward decl
5104 that is used in the definition.
5105 (read_key_sequence, keyremap_step):
5106 Change bufsize argument back to int, undoing my 2011-03-30 change.
5107 We prefer signed types, and int is wide enough here.
5108 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5109 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5110 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5111 length, not size_t. Use ptrdiff_t for index, not int.
5112 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5113 possibility of integer overflow.
5114
13464394
PE
5115 Overflow, signedness and related fixes for images.
5116
5117 * dispextern.h (struct it.stack[0].u.image.image_id)
5118 (struct_it.image_id, struct image.id, struct image_cache.size)
5119 (struct image_cache.used, struct image_cache.ref_count):
5120 * gtkutil.c (update_frame_tool_bar):
5121 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5122 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5123 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5124 * nsmenu.m (update_frame_tool_bar):
5125 * xdisp.c (calc_pixel_width_or_height):
5126 * xfns.c (image_cache_refcount):
5127 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5128 on typical 64-bit hosts.
5129
5130 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5131 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5132 Omit unnecessary casts to int.
5133 (parse_image_spec): Check that integers fall into 'int' range
5134 when the callers expect that.
5135 (image_ascent): Redo ascent calculation to avoid int overflow.
5136 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5137 (lookup_image): Remove unnecessary tests.
5138 (xbm_image_p): Locals are now of int, not EMACS_INT,
5139 since parse_image_check makes sure they fit into int.
5140 (png_load, gif_load, svg_load_image):
5141 Prefer int to unsigned where either will do.
5142 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5143 old tiff_error_handler and tiff_warning_handler.
5144 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5145 stack buffer overflows. It uses only the features of vsnprintf
5146 that are common to both POSIX and native Microsoft.
5147 (tiff_error_handler, tiff_warning_handler): Use it.
5148 (tiff_load, gif_load, imagemagick_load_image):
5149 Don't assume :index value fits in 'int'.
5150 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5151 (imagemagick_load_image): Check that crop parameters fit into
5152 the integer types that MagickCropImage accepts. Don't assume
5153 Vimagemagick_render_type has a nonnegative value. Don't assume
5154 size_t fits in 'long'.
5155 (gs_load): Use printmax_t to print the widest integers possible.
5156 Check for integer overflow when computing image height and width.
5157
c11821d4
EZ
51582011-08-26 Eli Zaretskii <eliz@gnu.org>
5159
5160 * xdisp.c (redisplay_window): Don't force window start if point
5161 will be invisible in the resulting window. (Bug#9324)
5162
0c95fcf7
EZ
51632011-08-25 Eli Zaretskii <eliz@gnu.org>
5164
5165 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5166 the display spec is of the form `(space ...)'.
5167 (handle_display_spec): Return the value returned by
5168 handle_single_display_spec, not just 1 or zero.
5169 (handle_single_display_spec): If the display spec is of the form
5170 `(space ...)', and specifies display in the text area, return 2
5171 rather than 1.
fee65a97 5172 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5173 accurately, and prefer exact match for point under bidi.
5174 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5175
5176 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5177 into disp_prop; all users changed.
5178
5179 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5180 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5181 for the text covered by the display property.
5182
e4ed06f1
CY
51832011-08-25 Chong Yidong <cyd@stupidchicken.com>
5184
5185 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5186 Change return value to nil.
5187 (Frecord_buffer): Delete unused function.
5188
f67cdd7f
EZ
51892011-08-24 Eli Zaretskii <eliz@gnu.org>
5190
5980d4c6
EZ
5191 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5192 buffers, return left-to-right.
8610fe8b
EZ
5193 (set_cursor_from_row): Consider candidate row a win if its glyph
5194 represents a newline and point is on that newline. Fixes cursor
5195 positioning on the newline at EOL of R2L text within L2R
5196 paragraph, and vice versa.
5197 (try_cursor_movement): Check continued rows, in addition to
5198 continuation rows. Fixes unwarranted scroll when point enters a
5199 continued line of R2L text within an L2R paragraph, or vice versa.
5200 (cursor_row_p): Consider the case of point being equal to
5201 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5202 from the end of a short line to the beginning of a continued line
5203 of R2L text within L2R paragraph.
5204 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5205 composed characters.
5980d4c6 5206
f67cdd7f
EZ
5207 * bidi.c (bidi_check_type): Use xassert.
5208 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5209 members.
5210
bca633fb
EZ
52112011-08-23 Eli Zaretskii <eliz@gnu.org>
5212
5213 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5214 a character.
5215
4a5885a7
CY
52162011-08-23 Chong Yidong <cyd@stupidchicken.com>
5217
5218 * nsfont.m (ns_otf_to_script): Fix typo.
5219
0902a04e
KH
52202011-08-22 Kenichi Handa <handa@m17n.org>
5221
5222 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5223 extra slot even if the purpose is char-code-property-table.
5224
1a2e6670
EZ
52252011-08-23 Eli Zaretskii <eliz@gnu.org>
5226
8ddde651
EZ
5227 * xdisp.c (redisplay_window): When computing centering_position,
5228 account for the height of the header line. (Bug#8874)
5229
425cc014
EZ
5230 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5231 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5232 candidate is selected by the mouse, and that candidate has a
5233 composed character under the mouse.
5234
1a2e6670
EZ
5235 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5236 coordinates reported by pos-visible-in-window-p for a composed
5237 character in column zero.
5238
8b76d6f8
SM
52392011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5240
5241 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5242
dac347dd
EZ
52432011-08-22 Eli Zaretskii <eliz@gnu.org>
5244
5245 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5246 consider it a hit if to_charpos is anywhere in the range of the
5247 composed buffer positions.
5248
e013fb34
CY
52492011-08-22 Chong Yidong <cyd@stupidchicken.com>
5250
5251 * image.c (gif_load): Don't assume that each subimage has the same
5252 dimensions as the base image. Handle disposal method that is
5253 "undefined" by the gif spec (Bug#9335).
5254
bd1ba3e8
CY
52552011-08-20 Chong Yidong <cyd@stupidchicken.com>
5256
5257 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5258 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5259
54a1215b
EZ
52602011-08-19 Eli Zaretskii <eliz@gnu.org>
5261
823564e5
EZ
5262 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5263 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5264 from an Org mode buffer to a Speedbar frame.
5265
54a1215b
EZ
5266 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5267 a composition, take its buffer position from IT->cmp_it.charpos.
5268 Fixes cursor positioning at the beginning of a line that begins
5269 with a composed character.
5270
9778ebcc
EZ
52712011-08-18 Eli Zaretskii <eliz@gnu.org>
5272
0be6ee06
EZ
5273 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5274 character bidirectional type, use STRONG_L instead. Fixes crashes
5275 in a buffer produced by `describe-categories'.
5276
9778ebcc
EZ
5277 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5278 members before the level stack, so they would be saved and
5279 restored when copying iterator state. Fixes incorrect reordering
5280 around TABs covered by display properties.
5281
156bffbe
AS
52822011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5283
6b02f655 5284 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5285
72ad093b
CY
52862011-08-17 Chong Yidong <cyd@stupidchicken.com>
5287
5288 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5289 (internal_condition_case_2, internal_condition_case_n):
5290 Remove unnecessary aborts (Bug#9081).
72ad093b 5291
35774242
EZ
52922011-08-17 Eli Zaretskii <eliz@gnu.org>
5293
5294 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5295 has no `load' handler, try opening the file locally. (Bug#9311)
5296
db76dd85
KB
52972011-08-16 Ken Brown <kbrown@cornell.edu>
5298
5299 * gmalloc.c: Expand comment.
5300
b215eee5
EZ
53012011-08-16 Eli Zaretskii <eliz@gnu.org>
5302
5303 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5304 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5305
a4579d33
KB
53062011-08-16 Ken Brown <kbrown@cornell.edu>
5307
5308 Fix memory allocation problems in Cygwin build (Bug#9273).
5309
5310 * unexcw.c ( __malloc_initialized): Declare external variable.
5311 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5312
8b76d6f8
SM
5313 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5314 New variables.
a4579d33
KB
5315 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5316 dumped emacs.
5317 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5318 in the static heap.
5319 [CYGWIN] (special_realloc): New function.
5320 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5321 requests to realloc storage in the static heap.
5322
3ebec551
PE
53232011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5324
5325 * bidi.c (bidi_initialize): Remove unused local.
5326
9fd8be00
EZ
53272011-08-15 Eli Zaretskii <eliz@gnu.org>
5328
6b02f655
SM
5329 * bidimirror.h:
5330 * biditype.h: Remove file.
5331 * makefile.w32-in ($(BLD)/bidi.$(O)):
5332 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5333
5334 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5335
5336 * chartab.c: Improve commentary for the uniprop_table API.
5337
32413314
EZ
5338 * bidi.c (bidi_paragraph_init): Support zero value of
5339 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5340 (bidi_initialize): Use uniprop_table instead of including
5341 biditype.h and bidimirror.h.
32413314 5342
9fd8be00
EZ
5343 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5344 coordinates of the iterator when restoring from ppos_it.
5345 (Bug#9296)
5346
5cf2b69b
KH
53472011-08-14 Kenichi Handa <handa@m17n.org>
5348
5349 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5350 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5351
daf17d00
EZ
53522011-08-14 Eli Zaretskii <eliz@gnu.org>
5353
5354 * xdisp.c (move_it_in_display_line_to): Don't invoke
5355 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5356 ppos_it. Fixes vertical cursor motion when line beginning is
5357 covered by an image. (Bug#9296)
5358
08e3161a
JD
53592011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5360
5361 * nsterm.h (ns_run_ascript): Declare.
5362 (NSAPP_DATA2_RUNASSCRIPT): Define.
5363
5364 * nsfns.m (as_script, as_result, as_status): New static variables.
5365 (ns_run_ascript): New function.
5e617bc2 5366 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5367 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5368 the event loop. Get status from as_status (Bug#7276).
5369
5370 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5371 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5372 the event loop (Bug#7276).
5373
a3720aa2
AS
53742011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5375
5376 * gnutls.c (QCgnutls_bootprop_priority)
5377 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5378 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5379 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5380 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5381 (QCgnutls_bootprop_verify_hostname_error)
5382 (QCgnutls_bootprop_callbacks_verify): Rename from
5383 Qgnutls_bootprop_..., all uses changed.
5384
5385 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5386 uses changed.
5387
0a0d27fb
PE
53882011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5389
19d5c50c
PE
5390 * xfaces.c (Qframe_set_background_mode): Now static.
5391 * dispextern.h (Qframe_set_background_mode): Remove decl.
5392
0a0d27fb
PE
5393 * process.c (Fnetwork_interface_info): Declare local only if needed.
5394
377538cb
JD
53952011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5396
5397 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5398 (Fnetwork_interface_list): Allocate in increments of bytes instead
5399 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5400 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5401 sockaddr.
5402 (struct ifflag_def): notrailers is smart on OSX.
5403 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5404 Get hardware address with getifaddrs if available.
5405
08fff70c
EZ
54062011-08-12 Eli Zaretskii <eliz@gnu.org>
5407
5408 * xdisp.c (iterate_out_of_display_property): xassert that
5409 IT->position is set to within IT->object's boundaries. Break from
5410 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5411 when IT->position is set up wrongly due to some bug.
5412 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5413 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5414 entry. Force push_it to save on the stack the current
5415 buffer/string position, to be restored by pop_it. Fix flags in
5416 the iterator structure wrt the object coming from a display
5417 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5418 properties. (Bug#9284)
5419
7be1c708 54202011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5421
7be1c708
CY
5422 * fontset.c (fontset_get_font_group): Add proper type checks.
5423 (Bug#9172)
aac0c6e3 5424
7be1c708 54252011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5426
7be1c708
CY
5427 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5428 and LC_VERSION_MIN_MACOSX.
5429 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5430 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5431
97bb72a6
EZ
54322011-08-08 Eli Zaretskii <eliz@gnu.org>
5433
5434 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5435 no-display-properties-and-no-overlays under bidi display.
5436 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5437 properties and overlays.
97bb72a6 5438
d5617611
CY
54392011-08-08 Chong Yidong <cyd@stupidchicken.com>
5440
37e11a63
CY
5441 * editfns.c (Fset_time_zone_rule): Document relationship with the
5442 setenv function.
5443
d5617611
CY
5444 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5445 the font entity extracted from the cache (Bug#8109).
5446
58872834
CY
54472011-08-07 Chong Yidong <cyd@stupidchicken.com>
5448
5449 * composite.c (autocmp_chars): Don't reset point. That is done by
5450 restore_point_unwind (Bug#5984).
5451
75bfc667
JL
54522011-08-07 Juri Linkov <juri@jurta.org>
5453
5454 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5455 to show the arg `TIME' instead of `TIMEVAL'.
5456
d1410150
EZ
54572011-08-06 Eli Zaretskii <eliz@gnu.org>
5458
5459 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5460 display property strides EOL and includes a newline, as in
5461 longlines-mode. (Bug#9254)
75b771e4
EZ
5462 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5463 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5464
5465 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5466 is non-zero, even if the data buffer is NULL. Fixes a crash in
5467 vertical-motion with longlines-mode. (Bug#9254)
5468
35928349
EZ
54692011-08-05 Eli Zaretskii <eliz@gnu.org>
5470
ec7cc85b
EZ
5471 * bidi.c <bidi_cache_total_alloc>: Now static.
5472 (bidi_initialize): Initialize bidi_cache_total_alloc.
5473
8b76d6f8 5474 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5475 cache. (Bug#9221)
5476
5477 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5478 amount allocated this far in `bidi_cache_total_alloc'.
5479 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5480 non-zero, only free the data buffer without restoring the cache
5481 contents. All callers changed.
5482
5483 * dispextern.h (bidi_unshelve_cache): Update prototype.
5484
5485 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5486 (move_it_in_display_line, move_it_to)
5487 (move_it_vertically_backward, move_it_by_lines): Replace the call
5488 to xfree to an equivalent call to bidi_unshelve_cache.
5489 (move_it_in_display_line_to): Fix logic of returning
412b6358 5490 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5491
e2e2423b
EZ
54922011-08-05 Eli Zaretskii <eliz@gnu.org>
5493
5494 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5495 came from a string character with a `cursor' property. (Bug#9229)
5496
ae9e757a
JD
54972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5498
5499 * Makefile.in (LIB_PTHREAD): New variable.
5500 (LIBES): Add LIB_PTHREAD (Bug#9216).
5501
5502 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5503 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5504
213bd7f2
AS
55052011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5506
6b02f655 5507 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5508
99aaf75f
JD
55092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5510
5511 * xterm.c (x_find_topmost_parent): New function.
5512 (x_set_frame_alpha): Find topmost parent window with
5513 x_find_topmost_parent and set the property there also (bug#9181).
5514 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5515
c74e9d86
PE
55162011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5517
5518 * callproc.c (Fcall_process): Avoid vfork clobbering
5519 the local vars buffer, coding_systems, current_dir.
5520
640c8776
SM
55212011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5522
5523 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5524
f26d0e4c
PE
55252011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5526
8a10d76c
PE
5527 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5528 so that it is not optimized away.
5529
f26d0e4c
PE
5530 * xdisp.c (compute_display_string_pos): Remove unused local.
5531
55439c61
EZ
55322011-08-02 Eli Zaretskii <eliz@gnu.org>
5533
5534 Fix slow cursor motion and scrolling in large buffers with
5535 selective display, like Org Mode buffers. (Bug#9218)
5536
5537 * dispextern.h (struct bidi_it): New member disp_prop_p.
5538
5539 * xdisp.c: Remove one-slot cache of display string positions.
5540 (compute_display_string_pos): Accept an additional argument
5e617bc2 5541 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5542 for a display string or property. If found, set DISP_PROP_P
5543 non-zero.
5544
5545 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5546 DISP_PROP_P, and pass it to compute_display_string_pos.
5547 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5548 non-zero. All callers of bidi_fetch_char changed.
5549
fb33fa43
SM
55502011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5551
5552 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5553
b099e063
DM
55542010-12-03 Don March <don@ohspite.net>
5555
5556 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5557 last character M-[char] is translated to ESC [char] (bug#7541).
5558
5cc7f7af
KH
55592011-08-02 Kenichi Handa <handa@m17n.org>
5560
d0fffa3f 5561 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5562
5563 * chartab.c (uniprop_table): Make it non-static.
5564
525d5e6e
EZ
55652011-08-01 Eli Zaretskii <eliz@gnu.org>
5566
5567 * xdisp.c (forward_to_next_line_start): Accept additional argument
5568 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5569 on the newline.
5570 (reseat_at_next_visible_line_start): Use the bidi iterator state
5571 returned by forward_to_next_line_start to restore the state of
5572 it->bidi_it after backing up to previous newline. (Bug#9212)
5573
31011111
AS
55742011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5575
5576 * regex.c (re_comp): Protoize.
5577 (re_exec): Fix return type.
5578 (regexec): Fix type of `ret'. (Bug#9203)
5579
476371c4
PE
55802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5581
e5d76069
PE
5582 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5583 This is needed if max-image-size is a floating-point number.
5584
9a79b20c
AS
55852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5586
5587 * print.c (print_object): Print empty symbol as ##.
5588
5589 * lread.c (read1): Read ## as empty symbol.
5590
d8c2fa78
AA
55912011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5592
5593 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5594 setting frame foreground color (Bug#9175).
5595 (x_set_background_color): Likewise.
5596
ffe57a7a
AA
5597 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5598 contents (Bug#9176).
5599 (EmacsTooltip -init): Remove bezels and add shadows to
5600 tooltip windows.
5601
bf3492a5
AA
5602 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5603 or scroll bar (Bug#8470).
5604
d55e9c53
AA
5605 * nsfont.m (nsfont_open): Remove assignment to voffset and
5606 unnecessary vars hshink, expand, hd, full_height, min_height.
5607 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5608
5609 * nsterm.h (nsfont_info): Remove voffset field.
5610
d8c2fa78 56112011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5612
5613 Implement strike-through and overline on NextStep (Bug#8863).
5614
5615 * nsfont.m (nsfont_open): Use underline position provided by font,
5616 instead of hard-coded value of 2.
5617 (nsfont_draw): Call ns_draw_text_decoration instead.
5618
5619 * nsterm.h: Add declaration for ns_draw_text_decoration.
5620
5621 * nsterm.m (ns_draw_text_decoration): New function for drawing
5622 underline, overline, and strike-through.
5623 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5624 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5625 accommodate underlining, etc.
4843aac3 5626
4cc60b9b
EZ
56272011-07-28 Eli Zaretskii <eliz@gnu.org>
5628
bc7ece87
EZ
5629 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5630 default.
4cc60b9b 5631
476371c4
PE
56322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5633
66606eea
PE
5634 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5635 Without this fix, if a signal arrives just after memory fills up,
5636 'malloc' might be invoked reentrantly.
5637
476371c4
PE
5638 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5639 In other words, assume that every image size is allowed, on non-X
5640 hosts. This assumption is probably wrong, but it lets Emacs compile.
5641
f3fcc40d
AS
56422011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5643
5644 * regex.c (re_iswctype): Convert return values to boolean.
5645
350c992f
EZ
56462011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5647
5648 * xdisp.c (compute_display_string_pos): Don't use cached display
5649 string position if the buffer had its restriction changed.
5650 (Bug#9184)
5651
5266b4bb
PE
56522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5653
5654 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5655
2573a837 56562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5657
41f55ccd 5658 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5659
39e378da
PE
5660 * bidi.c: Integer size and overflow fixes.
5661 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5662 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5663 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5664 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5665 (bidi_find_other_level_edge):
5666 Use ptrdiff_t instead of EMACS_INT where either will do.
5667 This works better on 32-bit hosts configured --with-wide-int.
5668 (bidi_cache_ensure_space): Check for size-calculation overflow.
5669 Use % rather than repeated addition, for better worst-case speed.
5670 Don't set bidi_cache_size until after xrealloc returns, because it
5671 might not return.
5672 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5673 (bidi_cache_ensure_space): Also check that the bidi cache size
5674 does not exceed that of the largest Lisp string or buffer. See Eli
5675 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5676
5e927815
PE
5677 * alloc.c (__malloc_size_t): Remove.
5678 All uses replaced by size_t. See Andreas Schwab's note
5679 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5680
ca4aa935
PE
5681 * image.c: Improve checking for integer overflow.
5682 (check_image_size): Assume that f is nonnull, since
5683 it is always nonnull in practice. This is one less thing to
5684 worry about when checking for integer overflow later.
5685 (x_check_image_size): New function, which checks for integer
5686 overflow issues inside X.
5687 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5688 This removes the need for a memory_full check.
5689 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5690 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5691 (xbm_read_bitmap_data): Change locals back to 'int', since
5692 their values must fit in 'int'.
5693 (xpm_load_image, png_load, tiff_load):
5694 Invoke x_create_x_image_and_pixmap earlier,
5695 to avoid much needless work if the image is too large.
5696 (tiff_load): Treat overly large images as if
5697 x_create_x_image_and_pixmap failed, not as malloc failures.
5698 (gs_load): Use x_check_image_size.
5699
5f8f9cc2
PE
5700 * gtkutil.c: Omit integer casts.
5701 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5702 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5703
5adf60bc
PE
5704 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5705
c8907a93
PE
5706 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5707 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5708 would wrongly return t on a 64-bit host.
5709
e3c25c68
PE
5710 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5711 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5712 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5713 and therefore cause GCC to emit a bogus diagnostic in some cases.
5714
3f791afe
PE
5715 * image.c: Integer signedness and overflow and related fixes.
5716 This is not an exhaustive set of fixes, but it's time to
5717 record what I've got.
5718 (lookup_pixel_color, check_image_size): Remove redundant decls.
5719 (check_image_size): Don't assume that arbitrary EMACS_INT values
5720 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5721 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5722 (tiff_load, imagemagick_load_image):
5723 Check for overflow in size calculations.
5724 (x_create_x_image_and_pixmap): Remove unnecessary test for
5725 xmalloc returning NULL; that can't happen.
5726 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5727 (xpm_color_bucket): Use better integer hashing function.
5728 (xpm_cache_color): Don't possibly over-allocate memory.
5729 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5730 (gif_memory_source):
5731 Use ptrdiff_t, not int or size_t, to record sizes.
5732 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5733 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5734 either works, as we prefer signed integers.
5735 (tiff_read_from_memory, tiff_write_from_memory):
5736 Return tsize_t, not size_t, since that's what the TIFF API wants.
5737 (tiff_read_from_memory): Don't fail simply because the read would
5738 go past EOF; instead, return a short read.
5739 (tiff_load): Omit no-longer-needed casts.
5740 (Fimagemagick_types): Don't assume size fits into 'int'.
5741
3cc5a532
PE
5742 Improve hashing quality when configured --with-wide-int.
5743 * fns.c (hash_string): New function, taken from sxhash_string.
5744 Do not discard information about ASCII character case; this
5745 discarding is no longer needed.
5746 (sxhash-string): Use it. Change sig to match it. Caller changed.
5747 * lisp.h: Declare it.
5748 * lread.c (hash_string): Remove, since we now use fns.c's version.
5749 The fns.c version returns a wider integer if --with-wide-int is
5750 specified, so this should help the quality of the hashing a bit.
5751
b312a492
PE
5752 * emacs.c: Integer overflow minor fix.
5753 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5754 Define only if GNU_LINUX.
5755 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5756
dfd153ae
PE
5757 * dispnew.c: Integer signedness and overflow fixes.
5758 Remove unnecessary forward decls, that were a maintenance hassle.
5759 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5760 All uses changed.
5761 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5762 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5763 (prepare_desired_row, line_draw_cost):
5764 Use int, not unsigned, where either works.
5765 (save_current_matrix, restore_current_matrix):
5766 Use ptrdiff_t, not size_t, where either works.
5767 (init_display): Check for overflow more accurately, and without
5768 relying on undefined behavior.
5769
a81d11a3
PE
5770 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5771 Remove, replacing with the new symbols in lisp.h. All uses changed.
5772 * fileio.c (make_temp_name):
5773 * filelock.c (lock_file_1, lock_file):
5774 * xdisp.c (message_dolog):
5775 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5776 Use pMd etc. instead.
5777 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5778 replacing the pWIDE etc. symbols removed from editfns.c.
5779
3300e6fd
PE
5780 * keyboard.h (num_input_events): Now uintmax_t.
5781 This is (very slightly) less likely to mess up due to wraparound.
5782 All uses changed.
5783
fd05c7e9
PE
5784 * buffer.c: Integer signedness fixes.
5785 (alloc_buffer_text, enlarge_buffer_text):
5786 Use ptrdiff_t rather than size_t when either will do, as we prefer
5787 signed integers.
5788
903fe15d
PE
5789 * alloc.c: Integer signedness and overflow fixes.
5790 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5791 (__malloc_size_t): Default to size_t, not to int.
5792 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5793 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5794 Prefer ptrdiff_t to size_t when either would do, as we prefer
5795 signed integers.
5796 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5797 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5798 Now const. Initialize with values that are in range even if char
5799 is signed.
5800 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5801 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5802 These functions do the right thing with sizes > 2**32.
5803 (check_depth): Now ptrdiff_t, not int.
5804 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5805 Adjust to new way of storing sizes. Check for size overflow bugs
5806 in rest of code.
5807 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5808 slightly wrong anyway, as it missed one instance of
5809 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5810 (refill_memory_reserve): Omit needless cast to size_t.
5811 (mark_object_loop_halt): Mark as externally visible.
5812
ac82cc6a
PE
5813 * xselect.c: Integer signedness and overflow fixes.
5814 (Fx_register_dnd_atom, x_handle_dnd_message):
5815 Use ptrdiff_t, not size_t, since we prefer signed.
5816 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5817 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5818 x_dnd_atoms_size and x_dnd_atoms_length.
5819
c2d1e36d
PE
5820 * doprnt.c: Prefer signed to unsigned when either works.
5821 * eval.c (verror):
5822 * doprnt.c (doprnt):
5823 * lisp.h (doprnt):
5824 * xdisp.c (vmessage):
5825 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5826 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5827 prefer signed arithmetic to avoid comparison confusion.
5828 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5829 but is a bit tricky.
5830
0e926e56
PE
5831 Assume freestanding C89 headers, string.h, stdlib.h.
5832 * data.c, doprnt.c, floatfns.c, print.c:
5833 Include float.h unconditionally.
5834 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5835 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5836 * regex.c: Likewise for stddef.h, string.h.
5837 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5838 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5839 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5840 (STDC_HEADERS): Remove obsolete defines.
5841 * sysdep.c: Include limits.h unconditionally.
5842
9cfdb3ec
PE
5843 Assume support for memcmp, memcpy, memmove, memset.
5844 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5845 * regex.c (memcmp, memcpy):
5846 Remove; we assume C89 now.
5847
5848 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5849 (__malloc_safe_bcopy): Remove; no longer needed.
5850
cf950e6b 5851 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5852 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5853 well either way, and we prefer signed to unsigned.
5854
dbf38e02
LMI
58552011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5856
5857 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5858 closes the connection while we're reading (bug#9182).
5859
d6f0886c 58602011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5861
d6f0886c
JD
5862 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5863 are specified (Bug#9168).
24e0f6b1 5864
2eb1f9e6
PE
58652011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5866
5867 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5868 Found by GCC static checking and --with-wide-int on a 32-bit host.
5869
22381272 58702011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5871
5872 * xdisp.c (compute_display_string_pos): Fix logic of caching
5873 previous display string position. Initialize cached_prev_pos to
5874 -1. Fixes slow-down at the beginning of a buffer.
5875
f25e39b4
EZ
58762011-07-24 Eli Zaretskii <eliz@gnu.org>
5877
5878 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5879 for attrs[LFACE_FONTSET_INDEX].
5880
04c4b52e
PE
58812011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5882
5883 * xml.c (parse_region): Remove unused local
5884 that was recently introduced.
5885
c1734fbd
EZ
58862011-07-23 Eli Zaretskii <eliz@gnu.org>
5887
be18c5a5
EZ
5888 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5889 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5890
c1734fbd
EZ
5891 * xdisp.c (move_it_in_display_line_to): Record the best matching
5892 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5893 exit if none of the characters scanned was an exact match.
5894 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5895 when exact match is impossible due to invisible text, and the
5896 lines are truncated.
5897
a258d627
JD
58982011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5899
5900 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5901 for OSX >= 10.7.
5902
b6d5a689
EZ
59032011-07-22 Eli Zaretskii <eliz@gnu.org>
5904
0f74f785
EZ
5905 Fix a significant slow-down of cursor motion with C-n, C-p,
5906 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5907 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5908 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5909 (next_element_from_buffer): Call compute_stop_pos_backwards to
5910 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5911 base_level_stop.
5912 (reseat): Don't look for prev_stop, as that could mean a very long
5913 run.
5914 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5915 <cached_disp_overlay_modiff>: Cache for last found display string
5916 position.
551918c1 5917 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5918 about the same buffer in the same area of character positions, and
5919 the buffer wasn't changed since the time the display string
5920 position was cached.
551918c1 5921
b2d0c91a
EZ
59222011-07-22 Eli Zaretskii <eliz@gnu.org>
5923
5924 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5925 is an integer, which is important for empty lines. (Bug#9149)
5926
043604ee
CY
59272011-07-22 Chong Yidong <cyd@stupidchicken.com>
5928
5929 * frame.c (Fmodify_frame_parameters): In tty case, update the
5930 default face if necessary (Bug#4238).
5931
da4adb04
CY
59322011-07-21 Chong Yidong <cyd@stupidchicken.com>
5933
5934 * editfns.c (Fstring_to_char): No need to explain what a character
5935 is in the docstring (Bug#6576).
5936
9abd0532
LMI
59372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5938
5939 * xml.c (parse_region): Make sure we always return a tree.
5940
36881d16
HK
59412011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5942
5943 * xml.c (parse_region): If a document contains only comments,
5944 return that, too.
5945
1e98674d
LMI
59462011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5947
5948 * xml.c (make_dom): Return comments, too.
5949
590bd467
PE
59502011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5951
5952 Port to OpenBSD.
5953 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5954 and the surrounding thread.
5955 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5956 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5957 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5958 timer goes off.
5959 * s/openbsd.h (BROKEN_SIGIO): Define.
5960 * unexelf.c (unexec) [__OpenBSD__]:
5961 Don't update the .mdebug section of the Alpha COFF symbol table.
5962
f41628b2
LMI
59632011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5964
5965 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5966 (bug#8460).
5967
b59b67c5
PE
59682011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5969
15e3a074
PE
5970 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5971 This fixes some race conditions on the permissions of any newly
5972 created file.
5973
41bed37d
PE
5974 * alloc.c (valid_pointer_p): Use pipe, not open.
5975 This fixes some permissions issues when debugging.
5976
b59b67c5
PE
5977 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5978 If fchown fails to set both uid and gid, try to set just gid,
5979 as that is sometimes allowed. Adjust the file's mode to eliminate
5980 setuid or setgid bits that are inappropriate if fchown fails.
5981
925a6be7
SM
59822011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5983
5984 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5985 to compare Lisp_Objects.
5986 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5987 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5988 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5989
52968808
AS
59902011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5991
0a6a104b
AS
5992 * lread.c (read_integer): Unread even EOF character.
5993 (read1): Likewise. Properly record start position of symbol.
5994
52968808
AS
5995 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5996 symbol character follows.
5997
9e381cdd
PE
59982011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5999
6000 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6001 This works around a problem with the previous change to Fcopy_file.
6002 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6003 and without this change, GCC might complain about discarding
6004 fchown's return value.
6005
b5641435
JB
60062011-07-16 Juanma Barranquero <lekktu@gmail.com>
6007
6008 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6009
a8031457
PE
60102011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6011
6012 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6013
dd889327
LMI
60142011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6015
750c33f7
LMI
6016 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6017 it's used from the C level.
6018
dd889327
LMI
6019 * process.c: Use the same condition for POLL_FOR_INPUT in both
6020 keyboard.c and process.c (bug#1858).
6021
87e86684
LM
60222011-07-09 Lawrence Mitchell <wence@gmx.li>
6023
6024 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6025 (Fgnutls_boot): Use it.
6026
64348f40
AS
60272011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6028
6029 * doc.c (Fsubstitute_command_keys): Revert last change.
6030
1d698799
LMI
60312011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6032
f863868c
LMI
6033 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6034 quotes the next character, and doesn't affect other longer
6035 sequences (bug#8935).
6036
1d698799
LMI
6037 * lread.c (syms_of_lread): Clarify that is isn't only
6038 `eval-buffer' and `eval-defun' that's affected by
6039 `lexical-binding' (bug#8460).
6040
aa4b6df6
EZ
60412011-07-15 Eli Zaretskii <eliz@gnu.org>
6042
6043 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6044 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6045
5d856da6
PE
60462011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6047
ad6042bb
PE
6048 Fix minor problems found by static checking.
6049 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6050 (elsz): Now a signed constant, not a size_t var. We prefer signed
6051 types to unsigned, to avoid integer comparison confusion. Without
6052 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6053 "cannot optimize loop, the loop counter may overflow", a symptom
6054 of the confusion.
f00bbb22 6055 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6056 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6057
6468f31c
LMI
60582011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6059
49080b10
LMI
6060 * search.c (Fre_search_backward): Mention `case-fold-search' in
6061 all the re_search_* functions (bug#8138).
6062
6468f31c
LMI
6063 * keyboard.c (Fopen_dribble_file): Document when the file is
6064 closed (bug#8056).
6065
c965adc5
EZ
60662011-07-14 Eli Zaretskii <eliz@gnu.org>
6067
df9733bf
EZ
6068 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6069 bidi_cache_idx.
6070
0bb23927
EZ
6071 Support bidi reordering of display and overlay strings.
6072 * xdisp.c (compute_display_string_pos)
6073 (compute_display_string_end): Accept additional argument STRING.
6074 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6075 (reseat_to_string): Initialize bidi_it->string.s and
6076 bidi_it->string.schars.
6077 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6078 NULL (avoids a crash in bidi_paragraph_init).
6079 Initialize itb.string.lstring.
0bb23927
EZ
6080 (init_iterator): Call bidi_init_it only of a valid
6081 buffer position was specified. Initialize paragraph_embedding to
6082 L2R.
6083 (reseat_to_string): Initialize the bidi iterator.
6084 (display_string): If we need to ignore text properties of
6085 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6086 original value of -1 will not work with bidi.)
6087 (compute_display_string_pos): First arg is now struct
6088 `text_pos *'; all callers changed. Support display properties on
6089 Lisp strings.
6090 (compute_display_string_end): Support display properties on Lisp
6091 strings.
6092 (init_iterator, reseat_1, reseat_to_string): Initialize the
6093 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6094 when iterating on a string not from display properties).
640c8776
SM
6095 (compute_display_string_pos, compute_display_string_end):
6096 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6097 arrow keys.
6098 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6099 base_level_stop; instead, set base_level_stop to BEGV.
6100 Fixes crashes in vertical-motion.
0bb23927
EZ
6101 (next_element_from_buffer): Improve commentary for when
6102 the iterator is before prev_stop.
6103 (init_iterator): Initialize bidi_p from the default value of
6104 bidi-display-reordering, not from buffer-local value. Use the
6105 buffer-local value only if initializing for buffer iteration.
6106 (handle_invisible_prop): Support invisible properties on strings
6107 that are being bidi-reordered.
6108 (set_iterator_to_next): Support bidi reordering of C strings and
6109 Lisp strings.
6110 (next_element_from_string): Support bidi reordering of Lisp
6111 strings.
6112 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6113 (display_string): Support display of R2L glyph rows.
6114 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6115 (init_iterator): Don't initialize it->bidi_p for strings
6116 here.
6117 (reseat_to_string): Initialize it->bidi_p for strings here.
6118 (next_element_from_string, next_element_from_c_string)
6119 (next_element_from_buffer): Add xassert's for correspondence
6120 between IT's object being iterated and it->bidi_it.string
6121 structure.
6122 (face_before_or_after_it_pos): Support bidi iteration.
6123 (next_element_from_c_string): Handle the case of the first string
6124 character that is not the first one in the visual order.
6125 (get_visually_first_element): New function, refactored from common
6126 parts of next_element_from_buffer, next_element_from_string, and
6127 next_element_from_c_string.
6128 (tool_bar_lines_needed, redisplay_tool_bar)
6129 (display_menu_bar): Force left-to-right direction. Add a FIXME
6130 comment for making that be controlled by a user option.
6131 (push_it, pop_it): Save and restore the state of the
6132 bidi iterator. Save and restore the bidi_p flag.
6133 (pop_it): Iterate out of display property for string iteration as
6134 well.
6135 (iterate_out_of_display_property): Support iteration over strings.
6136 (handle_single_display_spec): Set up it->bidi_it for iteration
6137 over a display string, and call bidi_init_it.
6138 (handle_single_display_spec, next_overlay_string)
6139 (get_overlay_strings_1, push_display_prop): Set up the bidi
6140 iterator for displaying display or overlay strings.
6141 (forward_to_next_line_start): Don't use the shortcut if
6142 bidi-iterating.
6143 (back_to_previous_visible_line_start): If handle_display_prop
6144 pushed the iterator stack, restore the internal state of the bidi
6145 iterator by calling bidi_pop_it same number of times.
6146 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6147 and we are bidi-iterating, don't decrement the iterator position;
6148 instead, set the first_elt flag in the bidi iterator, to produce
6149 the same effect.
6150 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6151 (push_display_prop): xassert that we are iterating a buffer.
6152 (push_it, pop_it): Save and restore paragraph_embedding member.
6153 (handle_single_display_spec, next_overlay_string)
6154 (get_overlay_strings_1, reseat_1, reseat_to_string)
6155 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6156 correctly. Don't assume unibyte strings are not bidi-reordered.
6157 (compute_display_string_pos)
6158 (compute_display_string_end): Fix handling the case of C string.
6159 (push_it, pop_it): Save and restore from_disp_prop_p.
6160 (handle_single_display_spec, push_display_prop): Set the
6161 from_disp_prop_p flag.
6162 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6163 (pop_it): Call iterate_out_of_display_property only if we are
6164 popping after iteration over a string that came from a display
6165 property. Fix a typo in popping stretch info. Add an assertion
6166 for verifying that the iterator position is in sync with the bidi
6167 iterator.
6168 (handle_single_display_spec, get_overlay_strings_1)
6169 (push_display_prop): Fix initialization of paragraph direction for
6170 string when that of the parent object is not yet determined.
6171 (reseat_1): Call bidi_init_it to resync the bidi
6172 iterator with IT's position. (Bug#7616)
6173 (find_row_edges): If ROW->start.pos gives position
6174 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6175 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6176 Reset the from_disp_prop_p flag.
6177 (SAVE_IT, RESTORE_IT): New macros.
6178 (pos_visible_p, face_before_or_after_it_pos)
6179 (back_to_previous_visible_line_start)
6180 (move_it_in_display_line_to, move_it_in_display_line)
6181 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6182 (try_scrolling, redisplay_window, display_line): Use them when
6183 saving a temporary copy of the iterator and restoring it back.
6184 (back_to_previous_visible_line_start, reseat_1)
6185 (init_iterator): Empty the bidi cache "stack".
6186 (move_it_in_display_line_to): If iterator ended up at
6187 EOL, but we never saw any buffer positions smaller than
6188 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6189 motion in bidi-reordered lines.
6190 (move_it_in_display_line_to): Record prev_method and prev_pos
6191 immediately before the call to set_iterator_to_next. Fixes cursor
6192 motion in bidi-reordered lines with stretch glyphs and strings
6193 displayed in margins. (Bug#8133) (Bug#8867)
6194 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6195 TO_CHARPOS.
640c8776
SM
6196 (pos_visible_p): Support positions in bidi-reordered lines.
6197 Save and restore bidi cache.
0bb23927
EZ
6198
6199 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6200 (bidi_paragraph_info): Delete unused struct.
6201 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6202 (bidi_cache_start): New variable.
6203 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6204 to zero.
6205 (bidi_cache_fetch_state, bidi_cache_search)
6206 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6207 (bidi_cache_find, bidi_peek_at_next_level)
6208 (bidi_level_of_next_char, bidi_find_other_level_edge)
6209 (bidi_move_to_visually_next): Compare cache index with
6210 bidi_cache_start rather than with zero.
6211 (bidi_fetch_char): Accept new argument STRING; all callers
6212 changed. Support iteration over a string. Support strings with
6213 display properties. Support unibyte strings. Fix the type of
6214 `len' according to what STRING_CHAR_AND_LENGTH expects.
6215 (bidi_paragraph_init, bidi_resolve_explicit_1)
6216 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6217 (bidi_level_of_next_char, bidi_move_to_visually_next):
6218 Support iteration over a string.
0bb23927
EZ
6219 (bidi_set_sor_type, bidi_resolve_explicit_1)
6220 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6221 can now be zero (for strings); special values 0 and -1 were
6222 changed to -1 and -2, respectively.
6223 (bidi_char_at_pos): New function.
6224 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6225 Call it instead of FETCH_MULTIBYTE_CHAR.
6226 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6227 initialized to valid values.
6228 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6229 values.
6230 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6231 the test for valid cached positions. Fix the logic for looking up
6232 the sentinel state in the cache. GCPRO the Lisp string we are
6233 iterating.
6234 (bidi_push_it, bidi_pop_it): New functions.
6235 (bidi_initialize): Initialize the bidi cache start stack pointer.
6236 (bidi_cache_ensure_space): New function, refactored from part of
6237 bidi_cache_iterator_state. Don't assume the required size is just
6238 one BIDI_CACHE_CHUNK away.
6239 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6240 (bidi_count_bytes, bidi_char_at_pos): New functions.
6241 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6242 always valid if bidi_cache_idx is valid.
6243 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6244 is valid if it's going to be used.
6245 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6246 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6247 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6248 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6249 (bidi_find_other_level_edge, bidi_cache_start_stack):
6250 All variables related to cache indices are now EMACS_INT.
c965adc5 6251
0bb23927
EZ
6252 * dispextern.h (struct bidi_string_data): New structure.
6253 (struct bidi_it): New member `string'. Make flag members be 1-bit
6254 fields, and put them last in the struct.
640c8776
SM
6255 (compute_display_string_pos, compute_display_string_end):
6256 Update prototypes.
0bb23927
EZ
6257 (bidi_push_it, bidi_pop_it): Add prototypes.
6258 (struct iterator_stack_entry): New members bidi_p,
6259 paragraph_embedding, and from_disp_prop_p.
6260 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6261 (bidi_shelve_cache, bidi_unshelve_cache):
6262 Declare prototypes.
0bb23927
EZ
6263
6264 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6265 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6266 and vector-like objects.
6267
6268 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6269 cache around display iteration.
6270
6271 * window.c (Fwindow_end, window_scroll_pixel_based)
6272 (displayed_window_lines, Frecenter): Save and restore the bidi
6273 cache around display iteration.
6274
3bbd2265
LMI
62752011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6276
6277 * editfns.c (Fdelete_region): Clarify the use of the named
6278 parameters (bug#6788).
6279
adc47434
MR
62802011-07-14 Martin Rudalics <rudalics@gmx.at>
6281
6282 * indent.c (Fvertical_motion): Set and restore w->pointm when
6283 saving and restoring the window's buffer (Bug#9006).
6284
837c31f8
LMI
62852011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6286
6287 * editfns.c (Fstring_to_char): Clarify just what is returned
6288 (bug#6576). Text by Eli Zaretskii.
6289
ac389d0c
JB
62902011-07-13 Juanma Barranquero <lekktu@gmail.com>
6291
6292 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6293
0be0ce47
EZ
62942011-07-13 Eli Zaretskii <eliz@gnu.org>
6295
6296 * buffer.c (mmap_find): Fix a typo.
6297
cd18e7e3
JB
62982011-07-13 Johan Bockgård <bojohan@gnu.org>
6299
6300 Fix execution of x selection hooks.
6301 * xselect.c (Qx_lost_selection_functions)
6302 (Qx_sent_selection_functions): New vars.
6303 (syms_of_xselect): DEFSYM them.
6304 (x_handle_selection_request): Pass Qx_sent_selection_functions
6305 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6306 (x_handle_selection_clear,x_clear_frame_selections):
6307 Pass Qx_lost_selection_functions rather than
6308 Vx_lost_selection_functions to Frun_hook_with_args.
6309
47ea7f44
PE
63102011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6311
ac389d0c 6312 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6313 The old code sometimes used this field without initializing it.
6314
47ea7f44
PE
6315 * alloc.c (gc_sweep): Don't read past end of array.
6316 In theory, the old code could also have corrupted Emacs internals,
6317 though it'd be very unlikely.
6318
bc985c87
AS
63192011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6320
6321 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6322 argument. (Bug#4026)
bc985c87 6323
0cf34688
LMI
63242011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6325
b3dadd76
LMI
6326 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6327 key" (bug#4257).
6328
0cf34688
LMI
6329 * window.c (Fset_window_start): Doc fix (bug#4199).
6330 (Fset_window_hscroll): Ditto.
6331
270768cd
PE
63322011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6333
077e3dda 6334 Fix minor new problems caught by GCC 4.6.1.
270768cd 6335 * term.c (init_tty): Remove unused local.
490011a6 6336 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6337 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6338 not used otherwise.
270768cd 6339
b1f58454
CY
63402011-07-12 Chong Yidong <cyd@stupidchicken.com>
6341
6342 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6343
22b9578d
LMI
63442011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6345
6e70ab07
LMI
6346 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6347 are the mini-buffer and the echo area (bug#3320).
6348
22b9578d
LMI
6349 * term.c (init_tty): Remove support for supdup, c10 and perq
6350 terminals, which are no longer supported (bug#1482).
6351
8974cc9f
JB
63522011-07-10 Johan Bockgård <bojohan@gnu.org>
6353
6354 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6355
a560d974
JD
63562011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6357
6358 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6359 for non-popups (Bug#3642).
6360
1dae0f0a
AS
63612011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6362
268c2c36 6363 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6364 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6365 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6366 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6367 * data.c (fmod): Likewise.
6368 * dispnew.c (swap_glyphs_in_rows): Likewise.
6369 * emacs.c (memory_warning_signal): Likewise.
6370 * floatfns.c (float_error): Likewise.
6371 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6372 (otf_open, font_otf_capability, generate_otf_features)
6373 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6374 Likewise.
6375 * image.c (pbm_read_file): Likewise.
6376 * indent.c (string_display_width): Likewise.
6377 * intervals.c (check_for_interval, search_for_interval)
6378 (inc_interval_count, count_intervals, root_interval)
6379 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6380 * lread.c (defalias): Likewise.
268c2c36 6381 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6382 * regex.c (set_image_of_range_1, set_image_of_range)
6383 (regex_grow_registers): Likewise.
6384 * sysdep.c (strerror): Likewise.
6385 * termcap.c (valid_filename_p, tprint, main): Likewise.
6386 * tparam.c (main): Likewise.
6387 * unexhp9k800.c (run_time_remap, save_data_space)
6388 (update_file_ptrs, read_header, write_header, calculate_checksum)
6389 (copy_file, copy_rest, display_header): Likewise.
6390 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6391 Likewise.
6392 * xdisp.c (check_it): Likewise.
6393 * xfaces.c (register_color, unregister_color, unregister_colors):
6394 Likewise.
6395 * xfns.c (print_fontset_result): Likewise.
6396 * xrdb.c (member, fatal, main): Likewise.
6397
99033785
PE
63982011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6399
6400 Fix minor problems found by static checking (Bug#9031).
6401 * chartab.c (char_table_set_range, map_sub_char_table):
6402 Remove unused locals.
6403 (uniprop_table): Now static.
6404 * composite.c (_work_char): Remove unused static var.
6405
9cb2ac56
JB
64062011-07-09 Juanma Barranquero <lekktu@gmail.com>
6407
6408 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6409
f25661f0
JD
64102011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6411
6412 * gtkutil.c (qttip_cb): Remove code without function.
6413
8278c4fe
EZ
64142011-07-09 Eli Zaretskii <eliz@gnu.org>
6415
6416 * w32.c (pthread_sigmask): New stub.
6417
1692ae2d 64182011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6419
8a6ebd58 6420 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6421 sigprocmask is portable only for single-threaded applications, and
6422 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6423 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6424 (LIBES): Use it.
6425 * callproc.c (Fcall_process):
6426 * process.c (create_process):
6427 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6428 Use pthread_sigmask, not sigprocmask.
123403e4 6429
1b854618
JD
64302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6431
6432 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6433 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6434 wrong (Bug#8591).
6435
3fe4b549
JD
64362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6437
0ce7e563
JD
6438 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6439 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6440 (xg_hide_tooltip): Fix comment.
6441
3fe4b549
JD
6442 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6443 in registerServicesMenuSendTypes.
6444 (validRequestorForSendType): Don't check ns_return_types.
6445
6446 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6447 ns_return_type.
6448
5df75e47
JR
64492011-07-08 Jason Rumney <jasonr@gnu.org>
6450
22610910
JR
6451 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6452 SH_SHOW for hidden windows (Bug#5482).
6453
5df75e47
JR
6454 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6455 frame struct members of non-existent frames (Bug#6284).
6456
699c10bd
JD
64572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6458
4393663b
JD
6459 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6460 variable firstTime not needed on OSX >= 10.6.
6461 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6462 >= 10.5. Use setKnobProportion, setDoubleValue.
6463
6464 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6465 (MAC_OS_X_VERSION_10_5): Define if not defined.
6466 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6467 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6468 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6469
6470 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6471 cString and lossyCString on OSX >= 10.4
6472
58179cce 6473 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6474 sizeToFit on OSX >= 10.2.
6475
6476 * nsimage.m (allocInitFromFile): Don't use deprecated method
6477 bestRepresentationForDevice on OSX >= 10.6.
6478
6479 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6480 to avoid warning.
6481
6482 * emacs.c: Declare unexec_init_emacs_zone.
6483
a63e0781
JD
6484 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6485
699c10bd
JD
6486 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6487
6488 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6489 on svcsMenu (Bug#8842).
6490
6491 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6492 ns_return_types.
6493 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6494
6495 * nsterm.m (QUTF8_STRING): Declare.
6496 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6497 (validRequestorForSendType): Return type is (id).
6498 Change indexOfObjectIdenticalTo to indexOfObject.
6499 Check if we have local selection before returning self (Bug#8842).
6500 (writeSelectionToPasteboard): Put local selection into paste board
6501 if we have a local selection (Bug#8842).
6502 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6503
6504 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6505 (ns_get_local_selection): Declare.
6506
54e10184
LMI
65072011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6508
9888ff71
LMI
6509 * keymap.c (describe_map_tree): Don't insert a double newline at
6510 the end of the buffer (bug#1169) and return whether we inserted
6511 something.
6512
54e10184
LMI
6513 * callint.c (Fcall_interactively): Change "reading args" to
6514 "providing args" to try to clarify what it does (bug#1010).
6515
15fa4783
KH
65162011-07-07 Kenichi Handa <handa@m17n.org>
6517
6518 * composite.c (composition_compute_stop_pos): Ignore a static
6519 composition starting before CHARPOS (Bug#8915).
6520
6521 * xdisp.c (handle_composition_prop): Likewise.
6522
a8815b00
EZ
65232011-07-07 Eli Zaretskii <eliz@gnu.org>
6524
6525 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6526 (Bug#9015)
6527
ef7b981d 65282011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6529
6530 * character.h (unicode_category_t): New enum type.
6531
6532 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6533 (Qchar_code_property_table): New variable.
6534 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6535 (UNIPROP_COMPRESSED_FORM_P): New macros.
6536 (char_table_ascii): Uncompress the compressed values.
6537 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6538 Uncompress the compressed values.
ac389d0c 6539 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6540 (char_table_ref_and_range): Uncompress the compressed values.
6541 (sub_char_table_set): New arg is_uniprop. Callers changed.
6542 Uncompress the compressed values.
6543 (sub_char_table_set_range): Args changed. Callers changed.
6544 (char_table_set_range): Adjuted for the above change.
6545 (map_sub_char_table): Delete args default_val and parent. Add arg
6546 top. Give decoded values to a Lisp function.
640c8776 6547 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6548 values to a Lisp function. Gcpro more variables.
6549 (uniprop_table_uncompress)
6550 (uniprop_decode_value_run_length): New functions.
6551 (uniprop_decoder, uniprop_decoder_count): New variables.
6552 (uniprop_get_decoder, uniprop_encode_value_character)
6553 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6554 New functions.
6555 (uniprop_encoder, uniprop_encoder_count): New variables.
6556 (uniprop_get_encoder, uniprop_table)
6557 (Funicode_property_table_internal, Fget_unicode_property_internal)
6558 (Fput_unicode_property_internal): New functions.
6559 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6560 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6561 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6562 char-code-property-alist.
6563
640c8776 6564 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6565 Vunicode_category_table.
6566
640c8776 6567 * font.c (font_range): Adjust for the change of
c805dec0
KH
6568 Vunicode_category_table.
6569
76b397fb
DN
65702011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6571
6572 * m/iris4d.h: Remove file, move contents ...
6573 * s/irix6-5.h: ... here.
6574
22b4128e
PE
65752011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6576
6577 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6578 * alloc.c (mark_buffer):
6579 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6580 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6581 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6582 This isn't true in general, and it's particularly not true
6583 if Emacs is configured with --with-wide-int.
6584 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6585 New macros, used in the buffer.c change.
6586
869795d6
JD
65872011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6588
6589 * xsettings.c: Use both GConf and GSettings if both are available.
6590 (store_config_changed_event): Add comment.
6591 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6592 (store_tool_bar_style_changed): New functions.
5e617bc2 6593 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6594 (struct xsettings): Move font inside HAVE_XFT.
6595 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6596 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6597 Move inside HAVE_XFT.
640c8776 6598 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6599 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6600 also.
6601 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6602 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6603 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6604 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6605 (parse_settings): Move check for font inside HAVE_XFT.
6606 (read_settings, apply_xft_settings): Add comment.
6607 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6608 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6609 call store_font_name_changed.
6610 (xft_settings_event): Add comment.
6611 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6612 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6613 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6614 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6615 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6616 (xsettings_get_system_font, xsettings_get_system_normal_font):
6617 Add comment.
869795d6 6618
d8ed26bd
PE
66192011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6620
6621 Random fixes. E.g., (random) never returned negative values.
6622 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6623 subseconds part to the entropy, as that's a bit more random.
6624 Prefer signed to unsigned, since the signedness doesn't matter and
6625 in general we prefer signed. When given a limit, use a
6626 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6627 latter isn't right if USE_2_TAGS_FOR_INTS.
6628 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6629 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6630
cabf1cac
SM
66312011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6632
6633 * textprop.c (text_property_stickiness):
6634 Obey Vtext_property_default_nonsticky.
6635 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6636 * w32fns.c (syms_of_w32fns):
6637 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6638
6e9b2be9
PE
66392011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6640
6641 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6642 This is more efficient than Ffile_directory_p and avoids a minor race.
6643
90186c68
LMI
66442011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6645
7c301272
LMI
6646 * buffer.c (Foverlay_put): Say what the return value is
6647 (bug#7835).
6648
c4f2d8d4
LMI
6649 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6650 is a directory before asking whether to use the file name
6651 (bug#7564).
ad637907
LMI
6652 (barf_or_query_if_file_exists): Make the "File is a directory"
6653 error be more correct.
c4f2d8d4 6654
90186c68
LMI
6655 * fns.c (Frequire): Remove the mention of the .gz files, since
6656 that's installation-specific, but keep the mention of
6657 `get-load-suffixes'.
6658
da64016e
PE
66592011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6660
6661 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6662 Report string overflow if the output is too long.
6663
7d47b580
JB
66642011-07-04 Juanma Barranquero <lekktu@gmail.com>
6665
a555cb87
JB
6666 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6667 (syms_of_gnutls): Remove duplicate DEFSYM for
6668 Qgnutls_bootprop_verify_hostname_error, an error for
6669 Qgnutls_bootprop_verify_error (which is no longer used).
6670
7d47b580
JB
6671 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6672 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6673 Also (re)move comments that are misplaced or no longer relevant.
6674
1e49bfab
LMI
66752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6676
6677 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6678
1485f4c0
CY
66792011-07-03 Chong Yidong <cyd@stupidchicken.com>
6680
6681 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6682 and background color parameters if they have been changed.
6683
a9ab721e
LMI
66842011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6685
6686 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6687
cf7cff57
PE
66882011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6689
2e13213d
PE
6690 * xsettings.c (SYSTEM_FONT): Define only when used.
6691 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6692
cf7cff57
PE
6693 * keymap.c (access_keymap_1): Now static.
6694
7a8e04f7
CY
66952011-07-02 Chong Yidong <cyd@stupidchicken.com>
6696
6697 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6698 leave any prefix arg for the up event (Bug#1586).
6699
61352f62
LMI
67002011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6701
69bb1ef7
LMI
6702 * lread.c (syms_of_lread): Mention single symbols defined by
6703 `defvar' or `defconst' (bug#7154).
6704
61352f62 6705 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6706 (Frequire): Mention get-load-suffixes.
61352f62 6707
28545e04
MR
67082011-07-02 Martin Rudalics <rudalics@gmx.at>
6709
6710 * window.h (window): Remove clone_number slot.
6711 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6712 Remove.
6713 (make_parent_window, make_window, saved_window)
6714 (Fset_window_configuration, save_window_save): Don't deal with
6715 clone numbers.
6716 * buffer.c (Qclone_number): Remove declaration.
6717 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6718
3349e122
SM
67192011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6720
6721 Add multiple inheritance to keymaps.
6722 * keymap.c (Fmake_composed_keymap): New function.
6723 (Fset_keymap_parent): Simplify.
6724 (fix_submap_inheritance): Remove.
6725 (access_keymap_1): New function extracted from access_keymap to handle
6726 embedded parents and handle lists of maps.
6727 (access_keymap): Use it.
6728 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6729 (Fcopy_keymap): Handle embedded parents.
6730 (Fcommand_remapping, define_as_prefix): Simplify.
6731 (Fkey_binding): Simplify.
6732 (syms_of_keymap): Move minibuffer-local-completion-map,
6733 minibuffer-local-filename-completion-map,
6734 minibuffer-local-must-match-map, and
6735 minibuffer-local-filename-must-match-map to Elisp.
6736 (syms_of_keymap): Defsubr make-composed-keymap.
6737 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6738 (parse_menu_item): Trivial simplification.
6739
3279eb87
GM
67402011-07-01 Glenn Morris <rgm@gnu.org>
6741
6742 * Makefile.in (SETTINGS_LIBS): Fix typo.
6743
4550efdf
KI
67442011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6745
6746 * coding.c (Fencode_coding_string): Record the last coding system
6747 used, as the function doc string says (bug#8738).
6748
0949d2b6
JD
67492011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6750
6751 * xsettings.c (store_monospaced_changed): Take new font as arg and
6752 check for change against current_mono_font.
6753 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6754 (emacs_settings_constructor, emacs_settings_get_property)
6755 (emacs_settings_set_property, emacs_settings_class_init)
6756 (emacs_settings_init, gsettings_obj): Remove.
6757 (something_changedCB): New function for HAVE_GSETTINGS.
6758 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6759 with value as argument.
6760 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6761 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6762 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6763 "changed".
6764
6765 * xgselect.c: Add defined (HAVE_GSETTINGS).
6766 (xgselect_initialize): Ditto.
6767
6768 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6769 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6770 xg_select.
6771
bbc6b304
PE
67722011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6773
6774 * eval.c (struct backtrace): Simplify and port the data structure.
6775 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6776 signed bit field, as this assumption is not portable and it makes
6777 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6778 "char debug_on_exit : 1" as this is not portable either; instead,
6779 use the portable "unsigned int debug_on_exit : 1". Remove unused
6780 member evalargs. Remove obsolete comments about cc bombing out.
6781
9851bfc5
JD
67822011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6783
51bb811f 6784 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6785 Let HAVE_GSETTINGS override HAVE_GCONF.
6786 (store_monospaced_changed): New function.
6787 (EMACS_SETTINGS): A new type derived from GObject to handle
6788 GSettings notifications.
6789 (emacs_settings_constructor, emacs_settings_get_property)
6790 (emacs_settings_set_property, emacs_settings_class_init):
6791 New functions.
6792 (gsettings_client, gsettings_obj): New variables.
6793 (GSETTINGS_SCHEMA): New define.
6794 (something_changedCB): Call store_monospaced_changed.
6795 (init_gsettings): New function.
6796 (xsettings_initialize): Call init_gsettings.
6797 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6798 to NULL.
6799
640c8776 6800 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6801 GCONF_CFLAGS/LIBS.
6802
5386012d
MR
68032011-06-29 Martin Rudalics <rudalics@gmx.at>
6804
6805 * window.c (resize_root_window, grow_mini_window)
6806 (shrink_mini_window): Rename Qresize_root_window to
6807 Qwindow_resize_root_window and Qresize_root_window_vertically to
6808 Qwindow_resize_root_window_vertically.
6809
f13e0b08
PE
68102011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6811
6812 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6813
94515237
JB
68142011-06-27 Juanma Barranquero <lekktu@gmail.com>
6815
6816 * makefile.w32-in: Redesign dependencies so they reflect more
6817 clearly which files are directly included by each source file,
6818 and not through other includes.
6819
e43b6e43
MR
68202011-06-27 Martin Rudalics <rudalics@gmx.at>
6821
6822 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6823 (sort_overlays, overlay_strings): When an overlay's clone number
6824 matches the window's clone number process the overlay even if
6825 the overlay's window property doesn't match the current window.
6826
d68443dc
MR
6827 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6828 (Fwindow_hchild): Rename to Fwindow_left_child.
6829 (Fwindow_next): Rename to Fwindow_next_sibling.
6830 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6831 (resize_window_check): Rename to window_resize_check.
6832 (resize_window_apply): Rename to window_resize_apply.
6833 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6834 (Fdelete_other_windows_internal, resize_frame_windows)
6835 (Fsplit_window_internal, Fdelete_window_internal)
6836 (grow_mini_window, shrink_mini_window)
6837 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6838
c7e73be5
JD
68392011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6840
6841 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6842 (emacs_fixed_set_min_size): Remove.
6843 (emacs_fixed_new): Take frame as argument.
6844
6845 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6846 (_EmacsFixedPrivate): Remove minwidth/height.
6847 Add struct frame *f.
6848 (emacs_fixed_init): Initialize priv->f.
6849 (get_parent_class, emacs_fixed_set_min_size): Remove.
6850 (emacs_fixed_new): Set priv->f to argument.
6851 (emacs_fixed_get_preferred_width)
6852 (emacs_fixed_get_preferred_height): Use min_width/height from
6853 frames size_hint to set minimum and natural (Bug#8919).
6854 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6855 and use min_width/height from frames size_hint to set
6856 min_width/height (Bug#8919).
6857
6858 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6859 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6860 Fix indentation.
c7e73be5 6861
cf99dcf8
EZ
68622011-06-26 Eli Zaretskii <eliz@gnu.org>
6863
6864 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6865 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6866 called at ZV.
6867
029529ac
CY
68682011-06-26 Chong Yidong <cyd@stupidchicken.com>
6869
6870 * process.c (wait_reading_process_output): Bypass select if
6871 waiting for a cell while ignoring keyboard input, and input is
6872 pending. Suggested by Jan Djärv (Bug#8869).
6873
7a7ef429
PE
68742011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6875
6876 Use gnulib's dup2 module instead of rolling our own.
6877 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6878
11fdef7d 68792011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6880
6881 * dispnew.c (scrolling_window): Before scrolling, turn off a
6882 mouse-highlight in the window being scrolled.
6883
cd3520a4
JB
68842011-06-24 Juanma Barranquero <lekktu@gmail.com>
6885
6886 Move DEFSYM to lisp.h and use everywhere.
6887
6888 * character.h (DEFSYM): Move declaration...
6889 * lisp.h (DEFSYM): ...here.
6890
6891 * gnutls.c:
6892 * minibuf.c:
6893 * w32menu.c:
6894 * w32proc.c:
6895 * w32select.c: Don't include character.h.
6896
6897 * alloc.c (syms_of_alloc):
6898 * buffer.c (syms_of_buffer):
6899 * bytecode.c (syms_of_bytecode):
6900 * callint.c (syms_of_callint):
6901 * casefiddle.c (syms_of_casefiddle):
6902 * casetab.c (init_casetab_once):
6903 * category.c (init_category_once, syms_of_category):
6904 * ccl.c (syms_of_ccl):
6905 * cmds.c (syms_of_cmds):
6906 * composite.c (syms_of_composite):
6907 * dbusbind.c (syms_of_dbusbind):
6908 * dired.c (syms_of_dired):
6909 * dispnew.c (syms_of_display):
6910 * doc.c (syms_of_doc):
6911 * editfns.c (syms_of_editfns):
6912 * emacs.c (syms_of_emacs):
6913 * eval.c (syms_of_eval):
6914 * fileio.c (syms_of_fileio):
6915 * fns.c (syms_of_fns):
6916 * frame.c (syms_of_frame):
6917 * fringe.c (syms_of_fringe):
6918 * insdel.c (syms_of_insdel):
6919 * keymap.c (syms_of_keymap):
6920 * lread.c (init_obarray, syms_of_lread):
6921 * macros.c (syms_of_macros):
6922 * msdos.c (syms_of_msdos):
6923 * print.c (syms_of_print):
6924 * process.c (syms_of_process):
6925 * search.c (syms_of_search):
6926 * sound.c (syms_of_sound):
6927 * syntax.c (init_syntax_once, syms_of_syntax):
6928 * terminal.c (syms_of_terminal):
6929 * textprop.c (syms_of_textprop):
6930 * undo.c (syms_of_undo):
6931 * w32.c (globals_of_w32):
6932 * window.c (syms_of_window):
6933 * xdisp.c (syms_of_xdisp):
6934 * xfaces.c (syms_of_xfaces):
6935 * xfns.c (syms_of_xfns):
6936 * xmenu.c (syms_of_xmenu):
6937 * xsettings.c (syms_of_xsettings):
6938 * xterm.c (syms_of_xterm): Use DEFSYM.
6939
4228cf16
TZ
69402011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6941
cd3520a4 6942 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6943
7fcccf1e
PE
69442011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6945
7efb4e0e
PE
6946 Integer and buffer overflow fixes (Bug#8873).
6947
ff5844ad
PE
6948 * print.c (printchar, strout): Check for string overflow.
6949 (PRINTPREPARE, printchar, strout):
6950 Don't set size unless allocation succeeds.
6951
90532f02
PE
6952 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6953 for sizes. Check for string overflow more accurately.
6954 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6955
6d84508d
PE
6956 * macros.c: Integer and buffer overflow fixes.
6957 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6958 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6959 Use ptrdiff_t, not int, for sizes.
6960 Don't increment bufsize until after realloc succeeds.
6961 Check for size-calculation overflow.
6962 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6963
437b2cb4
PE
6964 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6965
8b9ac8b4
PE
6966 * lread.c: Integer overflow fixes.
6967 (read_integer): Radix is now EMACS_INT, not int,
6968 to improve quality of diagnostics for out-of-range radices.
6969 Calculate buffer size correctly for out-of-range radices.
6970 (read1): Check for integer overflow in radices, and in
6971 read-circle numbers.
82cb60d3
PE
6972 (read_escape): Avoid int overflow.
6973 (Fload, openp, read_buffer_size, read1)
6974 (substitute_object_recurse, read_vector, read_list, map_obarray):
6975 Use ptrdiff_t, not int, for sizes.
6976 (read1): Use EMACS_INT, not int, for sizes.
20270765 6977 Check for size overflow.
8b9ac8b4 6978
7fcccf1e
PE
6979 * image.c (cache_image): Check for size arithmetic overflow.
6980
bfbbd7e7
PE
6981 * lread.c: Integer overflow issues.
6982 (saved_doc_string_size, saved_doc_string_length)
6983 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6984 Now ptrdiff_t, not int.
6985 (read1): Don't assume doc string length fits in int. Check for
6986 out-of-range doc string lengths.
6987 (read_list): Don't assume file position fits in int.
39019e54 6988 (read_escape): Check for hex character overflow.
bfbbd7e7 6989
4e323265
LL
69902011-06-22 Leo Liu <sdl.web@gmail.com>
6991
6992 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6993 Move to minibuffer.el.
6994
85fece3e
PE
69952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6996
20b84ce9 6997 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6998 The following patches are for when GLYPH_DEBUG && !XASSERT.
6999 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7000 * dispnew.c (flush_stdout):
7001 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7002 Mark as externally visible.
7003 * dispnew.c (check_window_matrix_pointers): Now static.
7004 * dispnew.c (window_to_frame_vpos):
7005 * xfns.c (unwind_create_frame):
7006 * xterm.c (x_check_font): Remove unused local.
7007 * scroll.c (CHECK_BOUNDS):
7008 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7009 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7010 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7011 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7012 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7013 Now static.
7014 (debug_method_add): Use va_list and vsprintf rather than relying
7015 on undefined behavior with wrong number of arguments.
7016 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7017 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7018 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7019 since we're not interested in debugging glyphs with old libraries.
7020 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7021 GCC 4.6.0's static checking.
7022
0766b489
PE
70232011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7024
31fd4b32
PE
7025 Integer overflow and signedness fixes (Bug#8873).
7026 A few related buffer overrun fixes, too.
7027
b79e8648
PE
7028 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7029
0766b489
PE
7030 * dispextern.h (struct face.stipple):
7031 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7032 (x_bitmap_mask, x_allocate_bitmap_record)
7033 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7034 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7035 (x_create_bitmap_from_xpm_data):
7036 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7037 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7038 (.bitmaps_last):
7039 * xfaces.c (load_pixmap):
7040 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7041 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7042 (.bitmaps_last, struct x_output.icon_bitmap):
7043 Use ptrdiff_t, not int, for bitmap indexes.
7044 (x_allocate_bitmap_record): Check for size overflow.
7045 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7046
b081724f
PE
7047 Use ptrdiff_t, not int, for overlay counts.
7048 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7049 * editfns.c (overlays_around, get_pos_property):
7050 * textprop.c (get_char_property_and_overlay):
7051 * xdisp.c (next_overlay_change, note_mouse_highlight):
7052 * xfaces.c (face_at_buffer_position):
21514da7
PE
7053 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7054 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7055 (Fnext_overlay_change, Fprevious_overlay_change)
7056 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7057 Use ptrdiff_t, not int, for sizes.
21514da7 7058 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7059
3de73e5e
PE
7060 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7061
2606c57b
PE
7062 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7063 (x_session_initialize): Do not assume string length fits in int.
7064
aaafe47a
PE
7065 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7066 This is unlikely, but can occur if DPI is outlandish.
7067
2674ddc8 7068 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7069 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7070
28154962
PE
7071 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7072 * xrdb.c (magic_file_p, search_magic_path):
7073 Omit last arg SUFFIX; it was always 0. All callers changed.
7074 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7075
7de51af5
PE
7076 * xfont.c (xfont_match): Avoid need for strlen.
7077
25ed6cc3
PE
7078 * xfns.c: Don't assume strlen fits in int.
7079 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7080
4eab31dd
PE
7081 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7082 not unsigned long, as we prefer signed integers. All callers changed.
7083 Detect integer overflow in repeat count.
7084 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7085 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7086
171e2a58
PE
7087 * termcap.c: Don't assume sizes fit in int and never overflow.
7088 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7089 (gobble_line): Check for size-calculation overflow.
7090
ad39faca 7091 * minibuf.c (Fread_buffer):
6e5bb2dc 7092 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7093 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7094 Don't assume string length fits in int.
7095
52c61c22 7096 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7097 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7098
b5b8c9e5
PE
7099 * font.c: Don't assume string length fits in int.
7100 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7101 Use ptrdiff_t, not int.
ccd6111c
PE
7102 (font_intern_prop): Don't assume string length fits in int.
7103 Don't assume integer property fits in fixnum.
7104 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7105
882f0d81 7106 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7107 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7108 Reformulate so as not to need the command string.
7109 Invoke gzip -cd rather than gunzip, as it's more portable.
7110 (lock_info_type, lock_file_1, lock_file):
7111 Don't assume pid_t and time_t fit in unsigned long.
7112 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7113 (current_lock_owner): Prefer signed type for sizes.
7114 Use memcpy, not strncpy, where memcpy is what is really wanted.
7115 Don't assume (via atoi) that time_t and pid_t fit in int.
7116 Check for time_t and/or pid_t out of range, e.g., via a network share.
7117 Don't alloca where an auto var works fine.
7118
93f4cf88
PE
7119 * fileio.c: Fix some integer overflow issues.
7120 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7121 Don't assume string length fits in int.
7122 (directory_file_name): Don't assume string length fits in long.
7123 (make_temp_name): Don't assume pid fits in int, or that its print
7124 length is less than 20.
7125
f3e92b69
PE
7126 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7127
1bfdaf10
PE
7128 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7129
35016e9a
PE
7130 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7131
3d1e65a1
PE
7132 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7133 We prefer signed integers, even for size calculations.
7134
0b963a93
PE
7135 * emacs.c: Don't assume string length fits in 'int'.
7136 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7137 (main): Don't invoke strlen when not needed.
7138
573f4b54
PE
7139 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7140 (XD_DEBUG_MESSAGE): Don't waste a byte.
7141
989f33ba
PE
7142 * callproc.c (getenv_internal_1, getenv_internal)
7143 (Fgetenv_internal):
965d34eb
PE
7144 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7145
e4d29b33
PE
7146 * lread.c (invalid_syntax): Omit length argument.
7147 All uses changed. This doesn't fix a bug, but it simplifies the
7148 code away from its former Hollerith-constant appearance, and it's
7149 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7150 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7151
eb49b136
PE
7152 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7153 This didn't break anything, but it didn't help either.
7154 It's confusing to put a bogus integer in a place where the actual
7155 value does not matter.
9f62aeb1 7156 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7157 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7158
15375a22
PE
7159 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7160 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7161 implementation.
b61cc01c
PE
7162 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7163 We prefer signed types, and the value cannot exceed the EMACS_INT
7164 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7165 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7166 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7167 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7168
53b2623d
PE
7169 * indent.c (sane_tab_width): New function.
7170 (current_column, scan_for_column, Findent_to, position_indentation)
7171 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7172 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7173
51cab52b 7174 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7175
f2ed8a70
PE
7176 * lisp.h (lint_assume): New macro.
7177 * composite.c (composition_gstring_put_cache):
7178 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7179
abe80cc6
PE
7180 * editfns.c, insdel.c:
7181 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7182
b02c740e
PE
7183 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7184
ebc96716
PE
7185 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7186
b4e50fa0 7187 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7188 Use much-faster test for byte-length change.
311d5d7c 7189 Don't assume string byte-length fits in 'int'.
a4cf38e4 7190 Check that character arg fits in 'int'.
85461888 7191 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7192
c0c1ee9f
PE
7193 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7194
a498d7f4
PE
7195 * fns.c (concat): Catch string overflow earlier.
7196 Do not rely on integer wraparound.
7197
51cab52b
PE
7198 * dispextern.h (struct it.overlay_strings_charpos)
7199 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7200 * xdisp.c (forward_to_next_line_start)
7201 (back_to_previous_visible_line_start)
7202 (reseat_at_next_visible_line_start, next_element_from_buffer):
7203 Don't arbitrarily truncate the value of 'selective' to int.
7204
76031fad
PE
7205 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7206
5eb55db9
PE
7207 * composite.c: Don't truncate sizes to 'int'.
7208 (composition_gstring_p, composition_reseat_it)
7209 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7210 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7211 not EMACS_UINT, for indexes.
5eb55db9 7212
0703a717
PE
7213 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7214
d6202519
PE
7215 * buffer.c: Include <verify.h>.
7216 (struct sortvec.priority, struct sortstr.priority):
8961a454 7217 Now EMACS_INT, not int.
c20998a7 7218 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7219 (struct sortstr.size, record_overlay_string)
7220 (struct sortstrlist.size, struct sortlist.used):
7221 Don't truncate size to int.
7222 (record_overlay_string): Check for size-calculation overflow.
d6202519 7223 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7224
d5a19415
JM
72252011-06-22 Jim Meyering <meyering@redhat.com>
7226
029529ac 7227 Don't leak an XBM-image-sized buffer
d5a19415
JM
7228 * image.c (xbm_load): Free the image buffer after using it.
7229
a9041e6c
PE
72302011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7231
7232 Port to Sun C.
7233 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7234 that Sun C diagnosed.
7235 * fns.c (secure_hash): Fix pointer signedness issue.
7236 * intervals.c (static_offset_intervals): New function.
7237 (offset_intervals): Use it.
7238
7f3f739f
LL
72392011-06-21 Leo Liu <sdl.web@gmail.com>
7240
7241 * deps.mk (fns.o):
7242 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7243 sha512.h.
7244
7245 * fns.c (secure_hash): Rename from crypto_hash_function and change
7246 the first arg to accept symbols.
5b66d427 7247 (Fsecure_hash): New primitive.
7f3f739f
LL
7248 (syms_of_fns): New symbols.
7249
76147d94
DD
72502011-06-20 Deniz Dogan <deniz@dogan.se>
7251
7252 * process.c (Fset_process_buffer): Clarify return value in
7253 docstring.
7254
7d7d0045
CY
72552011-06-18 Chong Yidong <cyd@stupidchicken.com>
7256
7257 * dispnew.c (add_window_display_history): Use BVAR.
7258
7259 * xdisp.c (debug_method_add): Use BVAR.
7260 (check_window_end, dump_glyph_matrix, dump_glyph)
7261 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7262
7263 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7264 Likewise.
7265
7266 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7267 check till after the cache is created in init_frame_faces.
7268
ff2bc410
SM
72692011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7270
7271 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7272
28177add
PE
72732011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7274
dd3482fe
PE
7275 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7276 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7277 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7278
393d71f3 7279 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7280 * fileio.c (Finsert_file_contents):
7281 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7282 Remove the old (too-loose) buffer overflow checks.
7283 They weren't needed, since make_gap checks for buffer overflow.
7284 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7285 The old code merely checked for Emacs fixnum overflow, and relied
7286 on undefined (wraparound) behavior. The new code avoids undefined
7287 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7288
2e6813b0 7289 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7290 Tune. Don't use wider integers than needed. Don't use alloca.
7291 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7292
599a9e4f
PE
7293 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7294
99561444
PE
7295 * insdel.c, lisp.h (buffer_overflow): New function.
7296 (insert_from_buffer_1, replace_range, replace_range_2):
7297 * insdel.c (make_gap_larger):
7298 * editfns.c (Finsert_char):
7299 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7300
28177add
PE
7301 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7302
e69dafad
PE
73032011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7304
4baa020d 7305 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7306
b1c46f02
PE
7307 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7308 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7309
e69dafad
PE
7310 * fileio.c: Don't assume EMACS_INT fits in off_t.
7311 (emacs_lseek): New static function.
7312 (Finsert_file_contents, Fwrite_region): Use it.
7313 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7314
566684ea
PE
7315 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7316
e6966cd6
PE
7317 * fns.c: Don't overflow int when computing a list length.
7318 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7319 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7320 truncation on 64-bit hosts. Check for QUIT every
7321 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7322 faster and is responsive enough.
7323 (Flength): Report an error instead of overflowing an integer.
7324 (Fsafe_length): Return a float if the value is not representable
7325 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7326 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7327 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7328
dd0b0efb
PE
7329 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7330 (header_size, word_size): New constants.
7331 (allocate_vectorlike): Don't check size overflow here.
7332 (allocate_vector): Check it here instead, since this is the only
7333 caller of allocate_vectorlike that could cause overflow.
7334 Check that the new vector's length is representable as a fixnum.
7335
86fe5cfe
PE
7336 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7337 The previous code was bogus. For example, next_almost_prime (32)
7338 returned 39, which is undesirable as it is a multiple of 3; and
7339 next_almost_prime (24) returned 25, which is a multiple of 5 so
7340 why was the code bothering to check for multiples of 7?
7341
80e88859
PE
7342 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7343
4a2f0ad6
PE
7344 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7345
f66c7cf8
PE
7346 Variadic C functions now count arguments with ptrdiff_t.
7347 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7348 Back then I didn't know that the Emacs coding style prefers signed int.
7349 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7350 were being counted with int, which may truncate counts on 64-bit
7351 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7352 * lisp.h (struct Lisp_Subr.function.aMANY)
7353 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7354 Arg counts are now ptrdiff_t, not size_t.
7355 All variadic functions and their callers changed accordingly.
7356 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7357 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7358 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7359 * callint.c (Fcall_interactively): Check arg count for overflow,
7360 to avoid potential buffer overrun. Use signed char, not 'int',
7361 for 'varies' array, so that we needn't bother to check its size
7362 calculation for overflow.
7363 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7364 * eval.c (apply_lambda):
7365 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7366 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7367 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7368
a1759b76
PE
7369 * callint.c (Fcall_interactively): Don't use index var as event count.
7370
d96be9fc
PE
7371 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7372 * mem-limits.h (SIZE): Remove; no longer used.
7373
a690a978 7374 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7375
578c21e6
PE
7376 Remove unnecessary casts.
7377 * xterm.c (x_term_init):
7378 * xfns.c (x_set_border_pixel):
7379 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7380 These aren't needed now that we assume ANSI C.
7381
96f53c6c
PE
7382 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7383 It's more likely to cause problems (due to unsigned overflow)
7384 than to cure them.
7385
83c77d31
PE
7386 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7387
ee2079f1
PE
7388 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7389
6da65536
PE
7390 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7391
7147c4a4
PE
7392 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7393
193e32d9
PE
7394 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7395
e5533da6
PE
7396 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7397
9910e595
PE
7398 GLYPH_CODE_FACE returns EMACS_INT, not int.
7399 * dispextern.h (merge_faces):
7400 * xfaces.c (merge_faces):
01103c44
PE
7401 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7402 Don't assume EMACS_INT fits in int.
9910e595 7403
2638320e
PE
7404 * character.h (CHAR_VALID_P): Remove unused parameter.
7405 * fontset.c, lisp.h, xdisp.c: All uses changed.
7406
045eb8d9
PE
7407 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7408
c1f134b5
PE
7409 * fns.c (concat): Minor tuning based on overflow analysis.
7410 This doesn't fix any bugs. Use int to hold character, instead
7411 of constantly refetching from Emacs object. Use XFASTINT, not
7412 XINT, for value known to be a character. Don't bother comparing
7413 a single byte to 0400, as it's always less.
7414
395fcb93 7415 * floatfns.c (Fexpt):
327eeec8
PE
7416 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7417
abbd3d23
PE
7418 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7419 for characters.
7420
684a03ef
PE
7421 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7422
0fed43f3
PE
7423 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7424 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7425 incorrectly succeed when S was a string, because 4294967386 was
7426 truncated before it was used.
7427
8fd02eb7
PE
7428 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7429 Otherwise, an out-of-range integer could cause undefined behavior
7430 on a 64-bit host.
7431
f8c86b69
PE
7432 * composite.c: Use int, not EMACS_INT, for characters.
7433 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7434 EMACS_INT, for values that are known to be in character range.
7435 This doesn't fix any bugs but is the usual style inside Emacs and
7436 may generate better code on 32-bit machines.
7437
34206dd2
PE
7438 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7439 This is for reasons similar to the recent CHAR_STRING fix.
7440 * charset.c (Fencode_char): Check that character arg is actually
7441 a character. Pass an int to ENCODE_CHAR.
7442 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7443 wider than 'int', as a compile-time check to prevent future regressions
7444 in this area.
7445
c5958d4c 7446 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7447
7448 Make sure a 64-bit char is never passed to CHAR_STRING.
7449 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7450 by silently ignoring the top 32 bits, allowing some values
7451 that were far too large to be valid characters.
7452 * character.h: Include <verify.h>.
7453 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7454 arguments are no wider than unsigned, as a compile-time check
7455 to prevent future regressions in this area.
7456 * data.c (Faset):
01103c44 7457 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7458 (Fsubst_char_in_region):
7459 * fns.c (concat):
7460 * xdisp.c (decode_mode_spec_coding):
7461 Adjust to CHAR_STRING's new requirement.
7462 * editfns.c (Finsert_char, Fsubst_char_in_region):
7463 * fns.c (concat): Check that character args are actually
7464 characters. Without this test, these functions did the wrong
7465 thing with wildly out-of-range values on 64-bit hosts.
7466
d37ca623
PE
7467 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7468 These casts should not be needed on 32-bit hosts, either.
7469 * keyboard.c (read_char):
7470 * lread.c (Fload): Remove casts to unsigned.
7471
ea204efb
PE
7472 * lisp.h (UNSIGNED_CMP): New macro.
7473 This fixes comparison bugs on 64-bit hosts.
7474 (ASCII_CHAR_P): Use it.
7475 * casefiddle.c (casify_object):
01103c44 7476 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7477 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7478 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7479 * dispextern.h (FACE_FROM_ID):
7480 * keyboard.c (read_char): Use UNSIGNED_CMP.
7481
41cb286c
PE
7482 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7483 not to EMACS_INT, to avoid GCC warning.
7484
4a1b9832
PE
7485 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7486
55daad71
PE
7487 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7488 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7489 isn't needed on 32-bit machines.
8f95c75c 7490
01103c44
PE
7491 * buffer.c (Fgenerate_new_buffer_name):
7492 Use EMACS_INT for count, not int.
0ceccced 7493 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7494
7495 * data.c (Qcompiled_function): Now static.
7496
c6f072e7
PE
7497 * window.c (window_body_lines): Now static.
7498
20ce5912
PE
7499 * image.c (gif_load): Rename local to avoid shadowing.
7500
9c4c5f81
PE
7501 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7502 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7503 * alloc.c (make_save_value): Integer argument is now of type
7504 ptrdiff_t, not int.
7505 (mark_object): Use ptrdiff_t, not int.
7506 * lisp.h (pD): New macro.
7507 * print.c (print_object): Use it.
7508
c0c5c8ae
PE
7509 * alloc.c: Use EMACS_INT, not int, to count objects.
7510 (total_conses, total_markers, total_symbols, total_vector_size)
7511 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7512 (total_free_floats, total_floats, total_free_intervals)
7513 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7514 Now EMACS_INT, not int. All uses changed.
7515 (Fgarbage_collect): Compute overall total using a double, so that
7516 integer overflow is less likely to be a problem. Check for overflow
7517 when converting back to an integer.
5a25e253
PE
7518 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7519 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7520 These were 'int' variables that could overflow on 64-bit hosts;
7521 they were never used, so remove them instead of repairing them.
211a0b2a 7522 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7523 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7524 Previously, this ceilinged at INT_MAX, but that doesn't work on
7525 64-bit machines.
e46bb31a 7526 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7527
c78baabf 7528 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7529 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7530 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7531 when a (possibly-narrower) signed value would do just as well.
7532 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7533
c9d624c6
PE
7534 * alloc.c: Catch some string size overflows that we were missing.
7535 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7536 for convenience in STRING_BYTES_MAX.
7537 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7538 The definition here is exact; the one in lisp.h was approximate.
7539 (allocate_string_data): Check for string overflow. This catches
7540 some instances we weren't catching before. Also, it catches
7541 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7542 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7543 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7544
c9d624c6
PE
7545 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7546 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7547 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7548
353032ce
PE
7549 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7550
2bccce07
PE
7551 * alloc.c (Fmake_string): Check for out-of-range init.
7552
0ac30604
SM
75532011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7554
7555 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7556
c195f2de
JD
75572011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7558
7559 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7560 xg_get_default_scrollbar_width.
7561
7562 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7563 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7564 (style_changed_cb): Call update_theme_scrollbar_width and call
7565 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7566 all frames (Bug#8505).
7567 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7568 Call gtk_window_set_resizable if HAVE_GTK3.
7569 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7570 and height if HAVE_GTK3 (Bug#8505).
7571 (scroll_bar_width_for_theme): New variable.
7572 (update_theme_scrollbar_width): New function.
7573 (xg_get_default_scrollbar_width): Move code to
7574 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7575 (xg_initialize): Call update_theme_scrollbar_width.
7576
7577 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7578
7579 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7580
e10ac9f1
MR
75812011-06-12 Martin Rudalics <rudalics@gmx.at>
7582
7583 * frame.c (make_frame): Call other_buffer_safely instead of
7584 other_buffer.
7585
7586 * window.c (temp_output_buffer_show): Call display_buffer with
7587 second argument Vtemp_buffer_show_specifiers and reset latter
7588 immediately after the call.
7589 (Vtemp_buffer_show_specifiers): New variable.
7590 (auto_window_vscroll_p, next_screen_context_lines)
7591 (Vscroll_preserve_screen_position): Remove leading asterisks from
7592 doc-strings.
7593
2d3c217e 75942011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7595
7b7f97e8 7596 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7597 * buffer.c (Qclone_number): Remove for now, as it's unused.
7598 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7599 (record_buffer): Remove unused local.
7600 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7601 (set_frame_buffer_list): Remove; unused.
7602 * frame.h (other_visible_frames): Remove decl.
7603 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7604 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7605 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7606 if HAVE_GPM.
7607 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7608 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7609 Define only if HAVE_GPM.
7610 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7611 (update_hints_inhibit): Remove; never set. All uses removed.
7612 * widgetprv.h (emacsFrameClassRec): Remove decl.
7613 * window.c (delete_deletable_window): Now returns void, since it
7614 wasn't returning anything.
7615 (compare_window_configurations): Remove unused locals.
7616 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7617 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7618 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7619 the same widths as pointers. This follows up on the 2011-05-06 patch.
7620 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7621 * xterm.h: Likewise.
7622 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7623
1384b89e
JB
76242011-06-12 Juanma Barranquero <lekktu@gmail.com>
7625
7626 * makefile.w32-in: Update dependencies.
7627 (LISP_H): Add lib/intprops.h.
7628
1100a63c
CY
76292011-06-11 Chong Yidong <cyd@stupidchicken.com>
7630
7631 * image.c (gif_load): Add animation frame delay to the metadata.
7632 (syms_of_image): Use DEFSYM. New symbol `delay'.
7633
6198ccd0
MR
76342011-06-11 Martin Rudalics <rudalics@gmx.at>
7635
7636 * window.c (delete_deletable_window): Re-add.
7637 (Fset_window_configuration): Rewrite to handle dead buffers and
7638 consequently deletable windows.
7639 (window_tree, Fwindow_tree): Remove. Supply functionality in
7640 window.el.
7641 (compare_window_configurations): Simplify code.
7642
b6e3633c
AS
76432011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7644
1ab0dee5
AS
7645 * image.c (imagemagick_load_image): Fix type mismatch.
7646 (Fimagemagick_types): Likewise.
7647
b6e3633c
AS
7648 * window.h (replace_buffer_in_windows): Declare.
7649
9397e56f
MR
76502011-06-11 Martin Rudalics <rudalics@gmx.at>
7651
7652 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7653 Qclone_number. Remove external declaration of Qdelete_window.
7654 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7655 code.
640c8776
SM
7656 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7657 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7658 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7659 buffer list implementation.
7660 (other_buffer_safely): New function.
7661 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7662 calls to replace_buffer_in_windows and
7663 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7664 if allowed.
7665 (record_buffer): Inhibit quitting and rewrite using quittable
7666 functions. Run Qbuffer_list_update_hook if allowed.
7667 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7668 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7669 Move switch-to-buffer to window.el.
9397e56f
MR
7670 (bury-buffer): Move to window.el.
7671 (Vbuffer_list_update_hook): New variable.
7672
7673 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7674 section.
7675
7676 * window.h (resize_frame_windows): Move up in code.
7677 (Fwindow_frame): Remove EXFUN.
7678 (replace_buffer_in_all_windows): Remove prototype.
7679 (replace_buffer_in_windows_safely): Add prototype.
7680
7681 * window.c: Declare Qdelete_window static again. Move down
7682 declaration of select_count.
7683 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7684 (Fother_window): Move to window.el.
7685 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7686 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7687 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7688 window.el.
7689 (replace_buffer_in_windows): Implement by calling
7690 Qreplace_buffer_in_windows.
7691 (replace_buffer_in_all_windows): Remove with some functionality
7692 moved into replace_buffer_in_windows_safely.
7693 (replace_buffer_in_windows_safely): New function.
7694 (select_window_norecord, select_frame_norecord): Move in front
7695 of run_window_configuration_change_hook. Remove now obsolete
7696 declarations.
640c8776
SM
7697 (Fset_window_buffer): Rewrite doc-string.
7698 Call Qrecord_window_buffer.
9397e56f
MR
7699 (keys_of_window): Move binding for other-window to window.el.
7700
b50691aa
CY
77012011-06-11 Chong Yidong <cyd@stupidchicken.com>
7702
7703 * dispextern.h (struct image): Replace data member, whose int_val
7704 and ptr_val fields were not used by anything, with a single
7705 lisp_val object.
7706
7707 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7708 (gif_clear_image, gif_load, imagemagick_load_image)
7709 (gs_clear_image, gs_load): Callers changed.
7710
3f754b86
PE
77112011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7712
cca69397
PE
7713 * buffer.h: Include <time.h>, for time_t.
7714 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7715
109e28d0
PE
7716 Fix minor problems found by static checking.
7717
60737f02
PE
7718 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7719
4b66faf3
PE
7720 Make identifiers static if they are not used in other modules.
7721 * data.c (Qcompiled_function, Qframe, Qvector):
7722 * image.c (QimageMagick, Qsvg):
7723 * minibuf.c (Qmetadata):
7724 * window.c (resize_window_check, resize_root_window): Now static.
7725 * window.h (resize_window_check, resize_root_window): Remove decls.
7726
109e28d0
PE
7727 * window.c (window_deletion_count, delete_deletable_window):
7728 Remove; unused.
46a4ce9e
PE
7729 (window_body_lines): Now static.
7730 (Fdelete_other_windows_internal): Mark vars as initialized.
7731 Make sure 'resize_failed' is initialized.
7732 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7733 (resize_window_apply): Remove unused local.
7734 * window.h (delete_deletable_window): Remove decl.
7735
109e28d0 7736 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7737 (imagemagick_load_image): Fix pointer signedness problem by changing
7738 last arg from unsigned char * to char *. All uses changed.
7739 Also, fix a local for similar reasons.
7740 Remove unused locals. Remove locals to avoid shadowing.
7741 (fn_rsvg_handle_free): Remove; unused.
7742 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7743 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7744
3f754b86
PE
7745 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7746
2547adb1
CY
77472011-06-10 Chong Yidong <cyd@stupidchicken.com>
7748
7749 * image.c (gif_load): Fix omitted cast error introduced by
7750 2011-06-06 change.
7751
2c8e37d4
MR
77522011-06-10 Martin Rudalics <rudalics@gmx.at>
7753
7754 * window.h (resize_proportionally, orig_total_lines)
7755 (orig_top_line): Remove from window structure.
7756 (set_window_height, set_window_width, change_window_heights)
7757 (Fdelete_window): Remove prototypes.
7758 (resize_frame_windows): Remove duplicate declaration.
7759
440a42e3
EZ
77602011-06-10 Eli Zaretskii <eliz@gnu.org>
7761
7762 * window.h (resize_frame_windows, resize_window_check)
7763 (delete_deletable_window, resize_root_window)
7764 (resize_frame_windows): Declare prototypes.
7765
7766 * window.c (resize_window_apply): Make definition be "static" to
7767 match the prototype.
7768
562dd5e9
MR
77692011-06-10 Martin Rudalics <rudalics@gmx.at>
7770
7771 * window.c: Remove declarations of Qwindow_size_fixed,
7772 window_min_size_1, window_min_size_2, window_min_size,
7773 size_window, window_fixed_size_p, enlarge_window, delete_window.
7774 Remove static from declaration of Qdelete_window, it's
7775 temporarily needed by Fbury_buffer.
7776 (replace_window): Don't assign orig_top_line and
7777 orig_total_lines.
7778 (Fdelete_window, delete_window): Remove. Window deletion is
7779 handled by window.el.
640c8776
SM
7780 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7781 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7782 (Fdelete_other_windows): Remove. Deleting other windows is
7783 handled by window.el.
7784 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7785 handled in window.el.
7786 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7787 Window minimum sizes are handled in window.el.
7788 (shrink_windows, size_window, set_window_height)
7789 (set_window_width, change_window_heights, window_height)
7790 (window_width, CURBEG, CURSIZE, enlarge_window)
7791 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7792 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7793 handled in window.el.
7794 (make_dummy_parent): Rename to make_parent_window and give it a
7795 second argument horflag.
7796 (make_window): Don't set resize_proportionally any more.
7797 (Fsplit_window): Remove. Windows are split in window.el.
7798 (save_restore_action, save_restore_orig_size)
7799 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7800 Resize mini windows in window.el.
7801 (grow_mini_window, shrink_mini_window): Implement by calling
7802 Qresize_root_window_vertically, resize_window_check and
7803 resize_window_apply.
640c8776
SM
7804 (saved_window, Fset_window_configuration, save_window_save):
7805 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7806 resize_proportionally.
7807 (window_min_height, window_min_width): Move to window.el.
7808 (keys_of_window): Move bindings for delete-other-windows,
7809 split-window, delete-window and enlarge-window to window.el.
7810
7811 * buffer.c: Temporarily extern Qdelete_window.
7812 (Fbury_buffer): Temporarily call Qdelete_window instead of
7813 Fdelete_window (Fbury_buffer will move to window.el soon).
7814
7815 * frame.c (set_menu_bar_lines_1): Remove code handling
7816 orig_top_line and orig_total_lines.
7817
7818 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7819 set_window_height but set heights directly.
7820 (change_frame_size_1): Use resize_frame_windows.
7821
7822 * xdisp.c (init_xdisp): Don't use set_window_height but set
7823 heights directly.
7824
640c8776
SM
7825 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7826 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7827 run_window_configuration_change_hook.
7828
7829 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7830 instead of change_window_heights and run
7831 run_window_configuration_change_hook.
7832
1a13852e
MR
78332011-06-09 Martin Rudalics <rudalics@gmx.at>
7834
7835 * window.c (replace_window): Rename second argument REPLACEMENT to
7836 NEW. New third argument SETFLAG. Rewrite.
7837 (delete_window, make_dummy_parent): Call replace_window with
7838 third argument 1.
7839 (window_list_1): Move down in code.
7840 (run_window_configuration_change_hook): Move set_buffer part
7841 before select_frame_norecord part in order to unwind correctly.
7842 Rename count1 to count.
7843 (recombine_windows, delete_deletable_window, resize_root_window)
7844 (Fdelete_other_windows_internal)
7845 (Frun_window_configuration_change_hook, make_parent_window)
7846 (resize_window_check, resize_window_apply, Fresize_window_apply)
7847 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7848 (Fdelete_window_internal, Fresize_mini_window_internal):
7849 New functions.
1a13852e
MR
7850 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7851
f3d1777e
MR
78522011-06-08 Martin Rudalics <rudalics@gmx.at>
7853
496e208e
MR
7854 * window.h (window): Add some new members to window structure -
7855 normal_lines, normal_cols, new_total, new_normal, clone_number,
7856 splits, nest, prev_buffers, next_buffers.
7857 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7858 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7859
f3d1777e
MR
7860 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7861 Remove.
496e208e
MR
7862 (make_dummy_parent): Set new members of windows structure.
7863 (make_window): Move down in code. Handle new members of window
7864 structure.
7865 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7866 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7867 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7868 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7869 (Fset_window_next_buffers, Fset_window_clone_number):
7870 New functions.
496e208e
MR
7871 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7872 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7873 Doc-string fixes.
7874 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7875 Argument WINDOW can be now internal window too.
7876 (Fwindow_use_time): Move up in code.
7877 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7878 Rewrite doc-string.
7879 (Fset_window_configuration, saved_window)
7880 (Fcurrent_window_configuration, save_window_save): Handle new
7881 members of window structure.
b9e809c2
MR
7882 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7883 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7884 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7885 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7886 Qget_mru_window, Qresize_root_window,
7887 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7888 Qauto_buffer_name; staticpro them.
f3d1777e 7889
abde8f8c
MR
78902011-06-07 Martin Rudalics <rudalics@gmx.at>
7891
7892 * window.c (Fwindow_total_size, Fwindow_left_column)
7893 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7894 (Fwindow_list_1): New functions.
7895 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7896 (Fwindow_width, Fscroll_left, Fscroll_right):
7897 Use window_body_cols instead of window_box_text_cols.
7898 (delete_window, Fset_window_configuration):
7899 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7900 (delete_all_subwindows): Take a window as argument and not a
7901 structure. Rewrite.
190b47e6
MR
7902 (window_loop): Remove handling of GET_LRU_WINDOW and
7903 GET_LARGEST_WINDOW.
7904 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7905
7906 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7907 window_box_text_cols. delete_all_subwindows now takes a
7908 Lisp_Object as argument.
abde8f8c 7909
640c8776
SM
7910 * indent.c (compute_motion, Fcompute_motion):
7911 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7912
fa8a67e6
MR
7913 * frame.c (delete_frame): Call delete_all_subwindows with root
7914 window as argument.
7915
a54e3482
DC
79162011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7917
7918 * fns.c (Fputhash): Document return value.
7919
60002bf5
CY
79202011-06-06 Chong Yidong <cyd@stupidchicken.com>
7921
7922 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7923
0c671da6 79242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7925
b862a52a 7926 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7927
be44ca6c
PE
7928 Check for overflow when converting integer to cons and back.
7929 * charset.c (Fdefine_charset_internal, Fdecode_char):
7930 Use cons_to_unsigned to catch overflow.
7931 (Fencode_char): Use INTEGER_TO_CONS.
7932 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7933 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7934 * data.c (long_to_cons, cons_to_long): Remove.
7935 (cons_to_unsigned, cons_to_signed): New functions.
7936 These signal an error for invalid or out-of-range values.
7937 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7938 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7939 * font.c (Ffont_variation_glyphs):
7940 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7941 * lisp.h: Include <intprops.h>.
7942 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7943 (cons_to_signed, cons_to_unsigned): New decls.
7944 (long_to_cons, cons_to_long): Remove decls.
7945 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7946 (Fprimitive_undo): Use CONS_TO_INTEGER.
7947 * xfns.c (Fx_window_property): Likewise.
7948 * xselect.c: Include <limits.h>.
7949 (x_own_selection, selection_data_to_lisp_data):
7950 Use INTEGER_TO_CONS.
7951 (x_handle_selection_request, x_handle_selection_clear)
7952 (x_get_foreign_selection, Fx_disown_selection_internal)
7953 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7954 (lisp_data_to_selection_data): Use cons_to_unsigned.
7955 (x_fill_property_data): Use cons_to_signed.
7956 Report values out of range.
7957
d1f3d2af
PE
7958 Check for buffer and string overflow more precisely.
7959 * buffer.h (BUF_BYTES_MAX): New macro.
7960 * lisp.h (STRING_BYTES_MAX): New macro.
7961 * alloc.c (Fmake_string):
7962 * character.c (string_escape_byte8):
7963 * coding.c (coding_alloc_by_realloc):
7964 * doprnt.c (doprnt):
7965 * editfns.c (Fformat):
7966 * eval.c (verror):
7967 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7968 since they may not be the same number.
7969 * editfns.c (Finsert_char):
7970 * fileio.c (Finsert_file_contents):
7971 Likewise for BUF_BYTES_MAX.
7972
dd52fcea
PE
7973 * image.c: Use ptrdiff_t, not int, for sizes.
7974 (slurp_file): Switch from int to ptrdiff_t.
7975 All uses changed.
7976 (slurp_file): Check that file size fits in both size_t (for
7977 malloc) and ptrdiff_t (for sanity and safety).
7978
7f9bbdbb
PE
7979 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7980 if b->modtime has its maximal value.
7981
dfe18f82
PE
7982 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7983
84acfcf0
PE
7984 Don't assume time_t can fit into int.
7985 * buffer.h (struct buffer.modtime): Now time_t, not int.
7986 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7987 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7988
ccd9a01a
PE
7989 Minor fixes for signed vs unsigned integers.
7990 * character.h (MAYBE_UNIFY_CHAR):
7991 * charset.c (maybe_unify_char):
7992 * keyboard.c (read_char, reorder_modifiers):
7993 XINT -> XFASTINT, since the integer must be nonnegative.
7994 * ftfont.c (ftfont_spec_pattern):
7995 * keymap.c (access_keymap, silly_event_symbol_error):
7996 XUINT -> XFASTINT, since the integer must be nonnegative.
7997 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7998 since it makes no difference and we prefer signed.
7999 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8000 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8001 nonnegative.
8002
d6d100dd
SM
80032011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8004
8005 * window.h (Fwindow_frame): Declare.
8006
2b6148e4
PE
80072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8008
8009 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8010 (SPARE_MEMORY): Always define.
8011 (LARGE_REQUEST): Remove.
8012 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8013
f230ecc9
MR
80142011-06-06 Martin Rudalics <rudalics@gmx.at>
8015
727e958e
MR
8016 * lisp.h: Move EXFUNS for Fframe_root_window,
8017 Fframe_first_window and Fset_frame_selected_window to window.h.
8018
8019 * window.h: Move EXFUNS for Fframe_root_window,
8020 Fframe_first_window and Fset_frame_selected_window here from
8021 lisp.h.
8022
8023 * frame.c (Fwindow_frame, Fframe_first_window)
8024 (Fframe_root_window, Fframe_selected_window)
8025 (Fset_frame_selected_window): Move to window.c.
8026 (Factive_minibuffer_window): Move to minibuf.c.
8027 (Fother_visible_frames_p): New function.
8028
8029 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8030
f230ecc9
MR
8031 * window.c (decode_window, decode_any_window): Move up in code.
8032 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8033 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8034 (Fwindow_buffer): Move up and rewrite doc-string.
8035 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8036 (Fwindow_prev): New functions.
727e958e
MR
8037 (Fwindow_frame): Move here from frame.c. Accept any window as
8038 argument.
8039 (Fframe_root_window, Fframe_first_window)
8040 (Fframe_selected_window): Move here from frame.c. Accept frame
8041 or arbitrary window as argument. Update doc-strings.
8042 (Fminibuffer_window): Move up in code.
8043 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8044 (Fset_frame_selected_window): Move here from frame.c.
8045 Marginal rewrite.
727e958e
MR
8046 (Fselected_window, select_window, Fselect_window): Move up in
8047 code. Minor doc-string fixes.
f230ecc9 8048
4d09bcf6
PE
80492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8050
8051 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8052 Do not assume that spare memory exists; that assumption is valid
8053 only if SYSTEM_MALLOC.
8054 (LARGE_REQUEST): New macro, so that the issue of large requests
8055 is separated from the issue of spare memory.
8056
810928a2
AS
80572011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8058
172418ad
AS
8059 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8060 format. (Bug#8806)
8061
43f862f7
AS
8062 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8063
810928a2
AS
8064 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8065 before statements.
8066
a059fe24
JD
80672011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8068
8069 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8070
8071 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8072
8073 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8074 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8075
989bf368
JB
80762011-06-05 Juanma Barranquero <lekktu@gmail.com>
8077
8078 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8079
4b80f674
CY
80802011-06-04 Chong Yidong <cyd@stupidchicken.com>
8081
8082 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8083 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8084 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8085 New error handlers.
4b80f674
CY
8086 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8087 Obey Vx_select_enable_clipboard_manager. Catch errors in
8088 x_clipboard_manager_save (Bug#8779).
8089 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8090 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8091
99a33b77 80922011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8093
8094 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8095
99a33b77 80962011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8097
8098 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8099 in the current matrix if keep_current_p is non-zero.
8100
8264569d
EZ
81012011-06-04 Eli Zaretskii <eliz@gnu.org>
8102
8103 * bidi.c (bidi_level_of_next_char): Fix last change.
8104
57f97249
EZ
81052011-06-03 Eli Zaretskii <eliz@gnu.org>
8106
fec2107c 8107 Support bidi reordering of text covered by display properties.
57f97249 8108
fec2107c
EZ
8109 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8110 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8111 (bidi_cache_search, bidi_cache_iterator_state)
8112 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8113 (bidi_level_of_next_char, bidi_move_to_visually_next):
8114 Support character positions inside a run of characters covered by a
fec2107c
EZ
8115 display string.
8116 (bidi_paragraph_init, bidi_resolve_explicit_1)
8117 (bidi_level_of_next_char): Call bidi_fetch_char and
8118 bidi_fetch_char_advance instead of FETCH_CHAR and
8119 FETCH_CHAR_ADVANCE.
8120 (bidi_init_it): Initialize new members.
8121 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8122 definitions.
8123 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8124 instead of using explicit *_CHAR codes.
d6d100dd
SM
8125 (bidi_resolve_explicit, bidi_resolve_weak):
8126 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8127 bidirectional text is supported only in multibyte buffers.
8128 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8129 it to initialize the frame_window_p member of struct bidi_it.
8130 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8131 (bidi_resolve_explicit, bidi_resolve_weak)
8132 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8133 bidi_it->nchars is non-positive.
8134 (bidi_level_of_next_char): Don't try to lookup the cache for the
8135 next/previous character if nothing is cached there yet, or if we
8136 were just reseat()'ed to a new position.
c40e2fb2 8137
0e14fe90
EZ
8138 * xdisp.c (set_cursor_from_row): Set start and stop points
8139 according to the row's direction when priming the loop that looks
8140 for the glyph on which to display cursor.
8141 (single_display_spec_intangible_p): Function deleted.
8142 (display_prop_intangible_p): Reimplement to call
8143 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8144 Accept 3 additional arguments needed by handle_display_spec.
8145 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8146 values: lists, `(when COND...)' forms, etc.
8147 (single_display_spec_string_p): Support property values that are
8148 lists with the argument STRING its top-level element.
8149 (display_prop_string_p): Fix the condition for processing a
8150 property that is a list to be consistent with handle_display_spec.
fec2107c 8151 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8152 last portion of handle_display_prop.
8153 (compute_display_string_pos): Accept additional argument
8154 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8155 value of a `display' property is a "replacing spec".
8156 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8157 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8158 the display property, but just return a value indicating whether
8159 the display property will replace the characters it covers.
8160 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8161 frame_window_p members of struct bidi_it.
d6d100dd
SM
8162 (compute_display_string_pos, compute_display_string_end):
8163 New functions.
fec2107c
EZ
8164 (push_it): Accept second argument POSITION, where pop_it should
8165 jump to continue iteration.
8166 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8167
fec2107c
EZ
8168 * keyboard.c (adjust_point_for_property): Adjust the call to
8169 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8170
8171 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8172 (bidi_init_it): Update prototypes.
8173 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8174 (compute_display_string_pos, compute_display_string_end):
8175 Declare prototypes.
fec2107c
EZ
8176 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8177 EMACS_INT.
fc6f18ce 8178
40087514 81792011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8180
57f53182
PE
8181 Malloc failure behavior now depends on size of allocation.
8182 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8183 * lisp.h: Change signatures accordingly.
8184 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8185 All callers changed. (Bug#8762)
8186
8187 * gnutls.c: Use Emacs's memory allocators.
8188 Without this change, the gnutls library would invoke malloc etc.
8189 directly, which causes problems on non-SYNC_INPUT hosts, and which
8190 runs afoul of improving memory_full behavior. (Bug#8761)
8191 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8192 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8193 xfree instead of the default malloc, realloc, free.
8194 (Fgnutls_boot): No need to check for memory allocation failure,
8195 since xmalloc does that for us.
8196
ac32cd99 8197 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8198 * category.c (hash_get_category_set):
8199 * ccl.c (ccl_driver):
8200 * charset.c (Fdefine_charset_internal):
8201 * charset.h (struct charset.hash_index):
8202 * composite.c (get_composition_id, gstring_lookup_cache)
8203 (composition_gstring_put_cache):
8204 * composite.h (struct composition.hash_index):
8205 * dispextern.h (struct image.hash):
8206 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8207 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8208 (hashfn_equal, hashfn_user_defined, make_hash_table)
8209 (maybe_resize_hash_table, hash_lookup, hash_put)
8210 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8211 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8212 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8213 * image.c (make_image, search_image_cache, lookup_image)
8214 (xpm_put_color_table_h):
8215 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8216 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8217 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8218 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8219 * alloc.c (allocate_vectorlike):
8220 Check for overflow in vector size calculations.
8221 * ccl.c (ccl_driver):
8222 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8223 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8224 need to be updated by these changes.
40087514
PE
8225 * fns.c (make_hash_table, maybe_resize_hash_table):
8226 Check for integer overflow with large hash tables.
0de4bb68
PE
8227 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8228 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8229 (SXHASH_REDUCE): New macro.
8230 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8231 Use it instead of discarding useful hash info with large hash values.
8232 (sxhash_float): New function.
8233 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8234 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8235 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8236 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8237 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8238 Adjust signatures to match updated version of code.
8239 (consing_since_gc): Now EMACS_INT, since a single hash table can
8240 use more than INT_MAX bytes.
8241
698d32e2
DN
82422011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8243
8244 Make it possible to build with GCC-4.6+ -O2 -flto.
8245
8246 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8247
fd6fa53f
SM
82482011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8249
8250 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8251 Call minibuffer-inactive-mode.
8252
864db017
JB
82532011-05-31 Juanma Barranquero <lekktu@gmail.com>
8254
8255 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8256 Update dependencies.
8257
2ad0baf4
DN
82582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8259
8260 * data.c (init_data): Remove code for UTS, this system is not
8261 supported anymore.
8262
4fcc2638
DN
82632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8264
8265 Don't force ./temacs to start in terminal mode.
8266
8267 * frame.c (make_initial_frame): Initialize faces in all cases, not
8268 only when CANNOT_DUMP is defined.
8269 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8270
c56e0fd5
DN
82712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8272
8273 * dispnew.c (add_window_display_history): Use const for the string
8274 pointer. Remove declaration, not needed.
8275
333d54da 82762011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8277
55d4c1b2 8278 Use 'inline', not 'INLINE'.
333d54da 8279 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8280 * alloc.c, fontset.c (INLINE): Remove.
8281 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8282 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8283 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8284 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8285 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8286
738db178
DN
82872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8288
8289 Make it possible to run ./temacs.
8290
8291 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8292 syms_of_callproc does the same thing. Remove test for
8293 "initialized", do it in the caller.
8294 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8295
620c53a6
SM
82962011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8297
8298 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8299 (read_minibuf): Use get_minibuffer.
8300 (syms_of_minibuf): Use DEFSYM.
8301 (Qmetadata): New var.
8302 * data.c (Qbuffer): Don't make it static.
8303 (syms_of_data): Use DEFSYM.
8304
e003a292
PE
83052011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8306
8307 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8308 (CCL_CODE_MIN): New macro.
8309
ed008a6d
PE
83102011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8311
3687c2ef
PE
8312 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8313
ed008a6d
PE
8314 * eval.c (Qdebug): Now static.
8315 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8316 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8317 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8318
d66c4c7c
CY
83192011-05-29 Chong Yidong <cyd@stupidchicken.com>
8320
8321 * image.c: Various fixes to ImageMagick code comments.
8322 (Fimagemagick_types): Doc fix.
8323
5fbc2025
PE
83242011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8325
0196f88a
PE
8326 Minor fixes prompted by GCC 4.6.0 warnings.
8327
8328 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8329
5fbc2025
PE
8330 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8331 (x_clipboard_manager_save_all): Move extern decl to ...
8332 * xterm.h: ... here, so that it can be checked for consistency.
8333
1dd3c2d9
CY
83342011-05-29 Chong Yidong <cyd@stupidchicken.com>
8335
8336 * xselect.c (x_clipboard_manager_save_frame)
8337 (x_clipboard_manager_save_all): New functions.
8338 (Fx_clipboard_manager_save): Lisp function deleted.
8339
8340 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8341 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8342
8343 * xterm.h: Update prototype.
8344
5ba6571d
WX
83452011-05-28 William Xu <william.xwl@gmail.com>
8346
8347 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8348 exiting (Bug#8239).
8349
3eaff834
JM
83502011-05-28 Jim Meyering <meyering@redhat.com>
8351
e1900994 8352 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8353 * fns.c (to_uchar): Define.
8354 (crypto_hash_function): Use it to convert some newly-signed
8355 variables to unsigned, to avoid sign-extension bugs. For example,
8356 without this change, (md5 "truc") would evaluate to
8357 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8358 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8359 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8360
0f6990a7
PE
83612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8362
8363 Integer overflow fixes.
c8a9ca5a 8364
08686060
PE
8365 * dbusbind.c: Serial number integer overflow fixes.
8366 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8367 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8368 to hold a serial number that is too large for a fixnum.
8369 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8370 Check for serial numbers out of range. Decode any serial number
59568bf0 8371 that was so large that it became a float. (Bug#8722)
08686060 8372
2d1fc3c7
PE
8373 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8374 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8375 Use XFASTINT rather than XUINT when numbers are nonnegative.
8376 (xd_append_arg, Fdbus_method_return_internal):
8377 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8378 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8379 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8380 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8381 (Bug#8722)
2d1fc3c7 8382
c8a9ca5a
PE
8383 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8384
519e1d69
PE
8385 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8386
6df6ae42 8387 ccl: Add integer overflow checks.
30569699
PE
8388 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8389 (IN_INT_RANGE): New macros.
8390 (ccl_driver): Use them to check for integer overflow when
8391 decoding a CCL program. Many of the new checks are whether XINT (x)
8392 fits in int; it doesn't always, on 64-bit hosts. The new version
8393 doesn't catch all possible integer overflows, but it's an
847044ea 8394 improvement. (Bug#8719)
30569699 8395
c11285dc
PE
8396 * alloc.c (make_event_array): Use XINT, not XUINT.
8397 There's no need for unsigned here.
8398
fdccd48e
PE
8399 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8400 This follows up to the 2011-05-06 change that substituted uintptr_t
8401 for EMACS_INT. This case wasn't caught back then.
8402
37910ab2
PE
8403 Rework Fformat to avoid integer overflow issues.
8404 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8405 now (part of C89). Include <verify.h>.
8406 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8407 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8408 (Fformat): Avoid the prepass trying to compute sizes; it was only
8409 approximate and thus did not catch overflow reliably. Instead, walk
8410 through the format just once, formatting and computing sizes as we go,
8411 checking for integer overflow at every step, and allocating a larger
8412 buffer as needed. Keep track separately whether the format is
8413 multibyte. Keep only the most-recently calculated precision, rather
8414 than them all. Record whether each argument has been converted to
8415 string. Use EMACS_INT, not int, for byte and char and arg counts.
8416 Support field widths and precisions larger than INT_MAX. Avoid
8417 sprintf's undefined behavior with conversion specifications such as %#d
8418 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8419 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8420 formatting out-of-range floating point numbers with int
9173deec 8421 formats. (Bug#8668)
37910ab2 8422
2e6578fb
PE
8423 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8424
0ae6bdee
PE
8425 * data.c: Avoid integer truncation in expressions involving floats.
8426 * data.c: Include <intprops.h>.
8427 (arith_driver): When there's an integer overflow in an expression
8428 involving floating point, convert the integers to floating point
8429 so that the resulting value does not suffer from catastrophic
8430 integer truncation. For example, on a 64-bit host (* 4
8431 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8432 Do not rely on undefined behavior after integer overflow.
8433
de883a70
PE
8434 merge count_size_as_multibyte, parse_str_to_multibyte
8435 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8436 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8437 Check for integer overflow.
8438 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8439 since it's now a duplicate of the other. This is more of
8440 a character than a buffer op, so better that it's in character.c.
8441 * fns.c, print.c: Adjust to above changes.
8442
2ff916cb
PE
84432011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8444
8445 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8446
f1b54466
PE
84472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8448
fb1ac845
PE
8449 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8450 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8451 (x_clipboard_manager_save): Now static.
8452 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8453
f1b54466
PE
8454 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8455 (crypto_hash_function): Now static.
8456 Fix pointer signedness problems. Avoid unnecessary initializations.
8457
a9f737ee
CY
84582011-05-27 Chong Yidong <cyd@stupidchicken.com>
8459
8460 * termhooks.h (Vselection_alist): Make it terminal-local.
8461
8462 * terminal.c (create_terminal): Initialize it.
8463
8464 * xselect.c: Support for clipboard managers.
8465 (Vselection_alist): Move to termhooks.h as terminal-local var.
8466 (LOCAL_SELECTION): New macro.
8467 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8468 (symbol_to_x_atom): Remove gratuitous arg.
8469 (x_handle_selection_request, lisp_data_to_selection_data)
8470 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8471 (x_own_selection, x_get_local_selection, x_convert_selection):
8472 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8473 (some_frame_on_display): Delete unused function.
8474 (Fx_own_selection_internal, Fx_get_selection_internal)
8475 (Fx_disown_selection_internal, Fx_selection_owner_p)
8476 (Fx_selection_exists_p): New optional frame arg.
8477 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8478 (x_handle_selection_clear): Don't treat other terminals with the
8479 same keyboard specially. Use the terminal-local Vselection_alist.
8480 (x_clear_frame_selections): Use Frun_hook_with_args.
8481
8482 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8483
8484 * xterm.h: Add support for those atoms.
8485
e067f0c1
CY
84862011-05-26 Chong Yidong <cyd@stupidchicken.com>
8487
8488 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8489 (converted_selections, conversion_fail_tag): New global variables.
8490 (x_selection_request_lisp_error): Free the above.
8491 (x_get_local_selection): Remove unnecessary code.
8492 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8493 of converted selections stored in converted_selections.
8494 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8495 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8496 (x_convert_selection): New function.
8497 (x_handle_selection_event): Simplify.
8498 (x_get_foreign_selection): Don't ignore incoming requests while
8499 waiting for an answer; this will fail when we implement
8500 SAVE_TARGETS, and seems unnecessary anyway.
8501 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8502 (Vx_sent_selection_functions): Doc fix.
8503
0f4aebc0
LL
85042011-05-26 Leo Liu <sdl.web@gmail.com>
8505
8506 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8507
e61124cd
YM
85082011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8509
8510 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8511
8512 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8513 for fringe update if it has periodic bitmap.
ac389d0c 8514 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8515 and fringe_bitmap_periodic_p.
8516
8517 * fringe.c (get_fringe_bitmap_data): New function.
8518 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8519 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8520 row. Mark glyph row for fringe update if periodicity changed.
8521
8522 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8523 for fringe update unless it has periodic bitmap.
8524
f16d9837
KH
85252011-05-25 Kenichi Handa <handa@m17n.org>
8526
8527 * xdisp.c (get_next_display_element): Set correct it->face_id for
8528 a static composition.
8529
e1b90ef6
LL
85302011-05-24 Leo Liu <sdl.web@gmail.com>
8531
8532 * deps.mk (fns.o):
8533 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8534
8535 * fns.c (crypto_hash_function, Fsha1): New function.
8536 (Fmd5): Use crypto_hash_function.
8537 (syms_of_fns): Add Ssha1.
8538
7400048f
PE
85392011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8540
8541 * gnutls.c: Remove unused macros.
8542 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8543 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8544 Remove macros that are defined and never used.
8545 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8546
abb71cf4
CY
85472011-05-22 Chong Yidong <cyd@stupidchicken.com>
8548
8549 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8550 (Fx_get_selection_internal): Minor cleanup.
8551 (Fx_own_selection_internal): Rename arguments for consistency with
8552 select.el.
8553
6307db39
PE
85542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8555
8556 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8557
f3d4e0a4
CY
85582011-05-22 Chong Yidong <cyd@stupidchicken.com>
8559
8560 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8561
4d8ade89
YM
85622011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8563
8564 * dispnew.c (scrolling_window): Don't exclude the case that the
8565 last enabled row in the desired matrix touches the bottom boundary.
8566
32078c8d
GM
85672011-05-21 Glenn Morris <rgm@gnu.org>
8568
8569 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8570 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8571 and add some more files.
32078c8d 8572
7285dc67
EZ
85732011-05-20 Eli Zaretskii <eliz@gnu.org>
8574
8575 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8576 report_file_error introduced by the change from 2011-05-07.
8577
89d1bd22
PE
85782011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8579
8580 * systime.h (Time): Define only if emacs is defined.
8581 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8582 where the include path doesn't have X11/X.h by default. See
8583 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8584
cd394be1 85852011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8586
8587 * composite.c (find_automatic_composition): Fix previous change.
8588
b9704ad9
GM
85892011-05-20 Glenn Morris <rgm@gnu.org>
8590
8591 * lisp.mk: New file, split from Makefile.in.
8592 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8593 (shortlisp): Remove.
8594 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8595
4a720484
GM
85962011-05-19 Glenn Morris <rgm@gnu.org>
8597
8598 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8599 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8600 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8601 (lisp): Set the order to that of loadup.el.
8602 (shortlisp): Make it a copy of $lisp.
8603 (SOME_MACHINE_LISP): Remove.
8604 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8605 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8606
a28d4396
KH
86072011-05-18 Kenichi Handa <handa@m17n.org>
8608
8609 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8610 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8611 (find_automatic_composition): Mostly rewrite for efficiency.
8612
a2b1fa8e
JB
86132011-05-18 Juanma Barranquero <lekktu@gmail.com>
8614
8615 * makefile.w32-in: Update dependencies.
8616
8e1f5610
CS
86172011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8618
8619 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8620 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8621
7025ee00 86222011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8623
cdfa6eab
PE
8624 Fix some integer overflow issues, such as string length overflow.
8625
06d6db33
PE
8626 * insdel.c (count_size_as_multibyte): Check for string overflow.
8627
2b4560a8
PE
8628 * character.c (lisp_string_width): Check for string overflow.
8629 Use EMACS_INT, not int, for string indexes and lengths; in
8630 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8631 the resulting string length overflows an EMACS_INT; instead,
8632 report a string overflow if no precision given. When checking for
8633 precision exhaustion, use a check that cannot possibly have
8634 integer overflow. (Bug#8675)
8635 * character.h (lisp_string_width): Adjust to new signature.
8636
cb93f9be
PE
8637 * alloc.c (string_overflow): New function.
8638 (Fmake_string): Use it. This doesn't change behavior, but saves
8639 a few bytes and will simplify future changes.
8640 * character.c (string_escape_byte8): Likewise.
8641 * lisp.h (string_overflow): New decl.
8642
1a1f3366
PE
8643 Fixups, following up to the user-interface timestamp change.
8644 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8645 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8646 * msdos.c (mouse_get_pos): Likewise.
8647 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8648 * w32gui.h (Time): Define by including "systime.h" rather than by
8649 declaring it ourselves. (Bug#8664)
8650
d4e3e4d3
PE
8651 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8652 * image.c (clear_image_cache): Likewise.
8653
f6a24d19
PE
8654 * term.c (term_mouse_position): Don't assume time_t wraparound.
8655
08dc5ae6
PE
8656 Be more systematic about user-interface timestamps.
8657 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8658 and sometimes 'EMACS_UINT', to represent these timestamps.
8659 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8660 This makes the code easier to follow, and makes it easier to catch
8661 integer overflow bugs such as Bug#8664.
8662 * frame.c (Fmouse_position, Fmouse_pixel_position):
8663 Use Time, not unsigned long, for user-interface timestamps.
8664 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8665 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8666 * keyboard.h (last_event_timestamp): Likewise.
8667 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8668 * menu.h (xmenu_show): Likewise.
8669 * term.c (term_mouse_position): Likewise.
8670 * termhooks.h (struct input_event.timestamp): Likewise.
8671 (struct terminal.mouse_position_hook): Likewise.
8672 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8673 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8674 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8675 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8676 what it was before.
8677 * menu.h, termhooks.h: Include "systime.h", for Time.
8678
8e55734a
PE
8679 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8680 Don't assume that the difference between two unsigned long values
8681 can fit into an integer. At this point, we know button_down_time
8682 <= event->timestamp, so the difference must be nonnegative, so
8683 there's no need to cast the result if double-click-time is
8684 nonnegative, as it should be; check that it's nonnegative, just in
8685 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8686 apart (about 25 days). (Bug#8664)
8e55734a 8687
841f1b75 8688 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8689 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8690
3e26f69c
PE
8691 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8692 that always fit in int. Use a sentinel instead of a counter, to
8693 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8694 * frame.h (struct frame): Use int for menu_bar_items_used
8695 instead of EMACS_INT, since it always fits in int.
3e26f69c 8696
5cc152c0
PE
8697 * menu.c (grow_menu_items): Check for int overflow.
8698
d89eb65e
PE
8699 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8700
5235bd3e
PE
8701 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8702 Before, the code was not consistent. These values cannot exceed
8703 2**31 - 1 so there's no need to make them unsigned.
8704 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8705 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8706 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8707 as modifiers.
8708 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8709
bc827e23
PE
8710 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8711 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8712 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8713 presumably because the widths might not match.
8714
78eb494e
PE
8715 * window.c (size_window): Avoid needless test at loop start.
8716
04f2d78b
CB
87172011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8718
8719 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8720
d2fc7e3d 87212011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8722
8723 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8724
d2fc7e3d 87252011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8726
8727 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8728 `width' to `bar_area_x' and `bar_area_width', respectively.
8729 (x_scroll_run): Take account of fringe background extension.
8730
04f2d78b
CB
8731 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8732 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8733 `bar_area_width', respectively.
8734 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8735 background extension.
8736
79b70037
GM
87372011-05-10 Jim Meyering <meyering@redhat.com>
8738
8739 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8740
2f142cc5
JB
87412011-05-10 Juanma Barranquero <lekktu@gmail.com>
8742
8743 * image.c (Finit_image_library): Return t for built-in image types,
8744 like pbm and xbm. (Bug#8640)
8745
57679c86
AS
87462011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8747
8748 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8749
888c9e86
EZ
87502011-05-07 Eli Zaretskii <eliz@gnu.org>
8751
b0512a1d
EZ
8752 * w32console.c (Fset_screen_color): Doc fix.
8753 (Fget_screen_color): New function.
8754 (syms_of_ntterm): Defsubr it.
8755
7285dc67
EZ
8756 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8757 unlink the temporary file if Fcall_process didn't create it in the
8758 first place.
8759 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8760 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8761 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8762 cue to call_process_cleanup not to close that handle.
8763
4d3fcc8e
BK
87642011-05-07 Ben Key <bkey76@gmail.com>
8765
8766 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8767 one of two shell specific rules, either bootstrap-temacs-CMD or
8768 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8769 to the previous implementation of the bootstrap-temacs rule.
8770 The bootstrap-temacs-CMD rule is similar to the previous
8771 implementation of the bootstrap-temacs rule except that it
8772 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8773 variable.
8774
8775 These changes, along with some changes to nt/configure.bat,
8776 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8777 earlier fix to add support for --cflags and --ldflags options
8778 that include quotes so that it works whether make uses cmd or
8779 sh as the shell.
8780
b4289b64
MA
87812011-05-06 Michael Albinus <michael.albinus@gmx.de>
8782
8783 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8784 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8785 is a constant.
8786 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8787 a string. Handle both cases.
8788 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8789 (Fdbus_register_method): Use Qinvalid_function.
8790
af4c0e28
JB
87912011-05-06 Juanma Barranquero <lekktu@gmail.com>
8792
8793 * makefile.w32-in: Update dependencies.
8794 (LISP_H): Add inttypes.h and stdin.h.
8795 (PROCESS_H): Add unistd.h.
8796
c51453d9
EZ
87972011-05-06 Eli Zaretskii <eliz@gnu.org>
8798
8799 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8800 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8801
8ff0ac3c 88022011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8803
4c4b566b
PE
8804 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8805
aab2b9b5
PE
8806 * term.c (vfatal): Remove stray call to va_end.
8807 It's not needed and the C Standard doesn't allow it here anyway.
8808
c378da0b
PE
8809 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8810 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8811
288b08c7
PE
8812 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8813 bytes.
8814
e3601888
PE
8815 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8816
db6c0e74
PE
8817 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8818
dd5963ea
PE
8819 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8820
88c9450f
PE
8821 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8822
2f9442b8
PE
8823 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8824
c032b5f8
PE
8825 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8826 * charset.c (Fdefine_charset_internal): Don't initialize
8827 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8828 32-bit int (Bug#8600).
a108c10b
PE
8829
8830 * lread.c (read_integer): Be more consistent with string-to-number.
8831 Use string_to_number to do the actual conversion; this avoids
8832 rounding errors and fixes some other screwups. Without this fix,
8833 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8834 (digit_to_number): Move earlier, for benefit of read_integer.
8835 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8836 not a digit in any supported base. (Bug#8602)
a108c10b 8837
ad5f9eea
PE
8838 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8839
aec1708a
PE
8840 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8841 to match comment at start of function. This also removes a
8842 GCC warning about overflow in a 32+64-bit port.
8843
47be4ab5
PE
8844 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8845
371cac43
PE
8846 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8847 Reported by Stefan Monnier in
8848 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8849 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8850 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8851
d01a7826
PE
8852 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8853 (EMACS_UINTPTR): Likewise, with uintptr_t.
8854
7fd47d5c
PE
8855 * lisp.h: Prefer 64-bit EMACS_INT if available.
8856 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8857 on 32-bit hosts that have 64-bit int, so that they can access
8858 large files.
122b0c86
PE
8859 However, temporarily disable this change unless the temporary
8860 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8861
8727937b
PE
8862 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8863
8ac068ac
PE
8864 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8865 This removes an assumption that EMACS_INT and long are the same
8866 width as pointers. The assumption is true for Emacs porting targets
8867 now, but we want to make other targets possible.
8868 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8869 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8870 In the rest of the code, change types of integers that hold casted
8871 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8872 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8873 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8874 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8875 No need to cast type when ORing.
8876 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8877 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8878 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8879 assume EMACS_INT is the same width as char *.
8880 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8881 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8882 Remove no-longer-needed casts.
8883 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8884 (xg_tool_bar_help_callback, xg_make_tool_item):
8885 Use EMACS_INTPTR to hold an integer
8886 that will be cast to void *; this can avoid a GCC warning
8887 if EMACS_INT is not the same width as void *.
8888 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8889 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8890 (current_message_1, set_message_1):
8891 Use a local to convert to proper width without a cast.
8892 * xmenu.c (dialog_selection_callback): Likewise.
8893
ede49d71
PE
8894 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8895 Also, don't assume VALBITS / RAND_BITS is less than 5,
8896 and don't rely on undefined behavior when shifting a 1 left into
8897 the sign bit.
8898 * lisp.h (get_random): Change signature to match.
8899
2f30ecd0
PE
8900 * lread.c (hash_string): Use size_t, not int, for hash computation.
8901 Normally we prefer signed values; but hashing is special, because
8902 it's better to use unsigned division on hash table sizes so that
8903 the remainder is nonnegative. Also, size_t is the natural width
8904 for hashing into memory. The previous code used 'int', which doesn't
8905 retain enough info to hash well into very large tables.
8906 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8907
2a866e7b
PE
8908 * dbusbind.c: Don't possibly lose pointer info when converting.
8909 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8910 Use XPNTR rather than XHASH, so that the high-order bits of
8911 the pointer aren't lost when converting through void *.
8912
51639eac
PE
8913 * eval.c (Fautoload): Don't double-shift a pointer.
8914
92394119
PE
8915 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8916
dbdb9a7c
JB
89172011-05-06 Juanma Barranquero <lekktu@gmail.com>
8918
8919 * gnutls.c (DEF_GNUTLS_FN):
8920 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8921
db7a0b4f
AS
89222011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8923
8924 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8925 marker. (Bug#8610)
8926
cd394be1 89272011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8928
8929 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8930 New version that can reserve upto 2GB of heap space.
8931
f7ff1b0f 89322011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8933
8934 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8935
639c109b
TZ
89362011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8937
8938 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8939 `gnutls_certificate_set_x509_key_file'.
8940
d2127135
JB
89412011-05-05 Juanma Barranquero <lekktu@gmail.com>
8942
8943 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8944 Update dependencies.
8945
e968f4f3
JB
89462011-05-04 Juanma Barranquero <lekktu@gmail.com>
8947
8948 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8949 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8950 Remove unused parameter `fildes'.
8951 * process.c (read_process_output, send_process): Don't pass it.
8952
84d358f0
JB
89532011-05-04 Juanma Barranquero <lekktu@gmail.com>
8954
8955 Fix previous change: the library cache is defined in w32.c.
8956 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8957 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8958
0898ca10
JB
89592011-05-04 Juanma Barranquero <lekktu@gmail.com>
8960
8961 Implement dynamic loading of GnuTLS on Windows.
8962
8963 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8964 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8965 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8966 Declare.
8967
8968 * gnutls.c (Qgnutls_dll): Define.
8969 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8970 (gnutls_*): Declare function pointers.
8971 (init_gnutls_functions): New function to initialize function pointers.
8972 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8973 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8974 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8975 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8976 (emacs_gnutls_write, emacs_gnutls_read)
8977 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8978 (Fgnutls_available_p): New function.
8979 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8980 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8981 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8982
8983 * image.c: Include w32.h.
8984 (Vimage_type_cache): Delete.
8985 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8986 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8987 (w32_delayed_load): Move to w32.c.
8988
8989 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8990
8991 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8992 (w32_delayed_load): Move from image.c. When loading a library, record
8993 its filename in the :loaded-from property of the library id.
8994 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8995 Initialize and staticpro them.
8996 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8997
8998 * process.c: Include lisp.h before w32.h, not after.
8999 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9000 instead of gnutls_record_check_pending.
9001
9002 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9003
ff4de4aa
TZ
90042011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9005
9006 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9007 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9008 as passed in.
9009
abe95abb
JD
90102011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9011
9012 * xterm.c (x_set_frame_alpha): Do not set property on anything
9013 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9014
e16e55d4
JB
90152011-05-02 Juanma Barranquero <lekktu@gmail.com>
9016
9017 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9018
bafcf6a5
JB
90192011-05-02 Juanma Barranquero <lekktu@gmail.com>
9020
9021 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9022 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9023 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9024 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9025 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9026 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9027 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9028 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9029 (Qgnutls_bootprop_callbacks_verify): Make static.
9030
e7a6747f
AS
90312011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9032
19ed11ba
AS
9033 * callproc.c: Indentation fixup.
9034
e7a6747f 9035 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9036 (wait_for_termination, interruptible_wait_for_termination):
9037 Move after wait_for_termination_1.
e7a6747f 9038
1ef14cb4
LMI
90392011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9040
9041 * sysdep.c (interruptible_wait_for_termination): New function
9042 which is like wait_for_termination, but allows keyboard
9043 interruptions.
9044
9045 * callproc.c (Fcall_process): Add (:file "file") as an option for
9046 the STDOUT buffer.
9047 (Fcall_process_region): Ditto.
9048
330d880c
EZ
90492011-04-30 Eli Zaretskii <eliz@gnu.org>
9050
8db90b73
EZ
9051 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9052 rather than `XVECTOR (FOO)->size'.
9053
330d880c
EZ
9054 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9055 inttypes.h, as a gnulib replacement is used if it not available in
9056 system headers.
9057
15cbd324
EZ
90582011-04-21 Eli Zaretskii <eliz@gnu.org>
9059
9060 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9061 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9062 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9063
9064 * coding.c (coding_alloc_by_realloc): Error out if destination
9065 will grow beyond MOST_POSITIVE_FIXNUM.
9066 (decode_coding_emacs_mule): Abort if there isn't enough place in
9067 charbuf for the composition carryover bytes. Reserve an extra
9068 space for up to 2 characters produced in a loop.
9069 (decode_coding_iso_2022): Abort if there isn't enough place in
9070 charbuf for the composition carryover bytes.
9071
90722011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9073
ae940cca
EZ
9074 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9075 aborting when %lld or %lll format is passed.
9076 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9077 %llo or %llx format is passed. (Bug#8545)
9078
03ab8921
EZ
9079 * window.c (window_scroll_line_based): Use a marker instead of
9080 simple variables to record original value of point. (Bug#7952)
9081
afda1437
EZ
9082 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9083 produced by %s or %c overflows available buffer space. (Bug#8545)
9084
f76dee0c
PE
90852011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9086
9087 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9088 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9089
fdc5744d
JB
90902011-04-28 Juanma Barranquero <lekktu@gmail.com>
9091
9092 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9093
638f053a
JB
90942011-04-28 Juanma Barranquero <lekktu@gmail.com>
9095
9096 * keyboard.c (Qdelayed_warnings_hook): Define.
9097 (command_loop_1): Run `delayed-warnings-hook'
9098 if Vdelayed_warnings_list is non-nil.
9099 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9100 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9101
d178f871
EZ
91022011-04-28 Eli Zaretskii <eliz@gnu.org>
9103
9104 * doprnt.c (doprnt): Don't return value smaller than the buffer
9105 size if the message was truncated. (Bug#8545).
9106
b124fd93
JB
91072011-04-28 Juanma Barranquero <lekktu@gmail.com>
9108
9109 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9110 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9111
e810457d
PE
91122011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9113
9114 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9115
ea51cceb
JB
91162011-04-27 Juanma Barranquero <lekktu@gmail.com>
9117
9118 * makefile.w32-in: Update dependencies.
9119
94dcfacf
EZ
91202011-04-27 Eli Zaretskii <eliz@gnu.org>
9121
9122 Improve `doprnt' and its usage. (Bug#8545)
9123 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9124 `format_end'. Remove support for %l as a conversion specifier.
9125 Don't use xrealloc. Improve diagnostics when the %l size modifier
9126 is used. Update the commentary.
9127
9128 * eval.c (verror): Simplify calculation of size_t.
9129
9130 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9131 messages.
9132
f61f41d7
PE
91332011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9134
9135 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9136 change.
9137
96fb4434
PE
91382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9139
9140 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9141 This makes this file independent of the recent pseudovector change.
9142
671875da 91432011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9144
69e9b5a3
PE
9145 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9146
b5f869a7 9147 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9148 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9149 Remove unused local.
c8926152 9150 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9151
841a1577 9152 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9153 GCC 4.6.0 optimizes based on type-based alias analysis.
9154 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9155 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9156 != &v->size, and therefore "v->size = 1; b->size = 2; return
9157 v->size;" must therefore return 1. This assumption is incorrect
9158 for Emacs, since it type-puns struct Lisp_Vector * with many other
9159 types. To fix this problem, this patch adds a new type struct
f904488f 9160 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9161 and pseudovectors, and helps optimizing compilers not get fooled
9162 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9163 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9164 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9165 the size member.
eab3844f
PE
9166 (XSETPVECTYPE): Rewrite in terms of new macro.
9167 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9168 This is a bit clearer, and further avoids the possibility of
9169 undesirable aliasing.
9170 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9171 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9172 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9173 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9174 (ASIZE): Now uses header.size rather than size.
9175 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9176 to avoid the hassle of writing XVECTOR (foo)->header.size.
9177 (struct vectorlike_header): New type.
eab3844f
PE
9178 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9179 object, to help avoid aliasing.
9180 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9181 (SUBRP): Likewise, since Lisp_Subr is a special case.
9182 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9183 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9184 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9185 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9186 changed to be "header.size" and "header.next".
9187 * buffer.h (struct buffer): Likewise.
9188 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9189 * frame.h (struct frame): Likewise.
9190 * process.h (struct Lisp_Process): Likewise.
9191 * termhooks.h (struct terminal): Likewise.
9192 * window.c (struct save_window_data, struct saved_window): Likewise.
9193 * window.h (struct window): Likewise.
9194 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9195 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9196 * buffer.c (init_buffer_once): Likewise.
9197 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9198 special case.
9199 * process.c (Fformat_network_address): Use local var for size,
9200 for brevity.
9201
0df1eac5
PE
9202 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9203
847ab9d1 9204 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9205 * data.c (atof): Remove decl; no longer used or needed.
9206 (digit_to_number): Move to lread.c.
9207 (Fstring_to_number): Use new string_to_number function, to be
9208 consistent with how the Lisp reader treats infinities and NaNs.
9209 Do not assume that floating-point numbers represent EMACS_INT
9210 without losing information; this is not true on most 64-bit hosts.
9211 Avoid double-rounding errors, by insisting on integers when
9212 parsing non-base-10 numbers, as the documentation specifies.
9213 * lisp.h (string_to_number): New decl, replacing ...
9214 (isfloat_string): Remove.
bc0a5c13 9215 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9216 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9217 appears to have been a coding error. Similarly, do not accept
9218 strings like +-1e0 as floating point numbers. Do not report
9219 overflow for integer overflows unless the base is not 10 which
9220 means we have no simple and reliable way to continue.
9221 Break out the floating-point parsing into a new
9222 function string_to_number, so that Fstring_to_number parses
9223 floating point numbers consistently with the Lisp reader.
04f2d78b 9224 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9225 (E_CHAR, EXP_INT): Remove, replacing with ...
9226 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9227 (string_to_number): New function, replacing isfloat_string.
9228 This function checks for valid syntax and produces the resulting
9229 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9230 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9231 so that overflow for non-base-10 numbers is reported only when
9232 there's no portable and simple way to convert to floating point.
452f4150 9233
67769ffc
PE
9234 * textprop.c (set_text_properties_1): Rewrite for clarity,
9235 and to avoid GCC warning about integer overflow.
9236
c20db43f
PE
9237 * intervals.h (struct interval): Use EMACS_INT for members
9238 where EMACS_UINT might cause problems. See
9239 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9240 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9241 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9242 All uses changed.
37aa2f85
PE
9243 (offset_intervals): Tell GCC not to worry about length overflow
9244 when negating a negative length.
c20db43f 9245
2538aa2f
PE
9246 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9247 (overrun_check_free): Likewise.
9248
f2d3008d
PE
9249 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9250 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9251 word size.
9252
ec8df744
PE
9253 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9254 (gnutls_make_error): Rename local to avoid shadowing.
9255 (gnutls_emacs_global_deinit): ifdef out; not used.
9256 (Fgnutls_boot): Use const for pointer to readonly storage.
9257 Comment out unused local. Fix pointer signedness problems.
9258
640ee02d
PE
9259 * lread.c (openp): Don't stuff size_t into an 'int'.
9260 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9261 about possible signed overflow.
9262
6048fb2a
PE
9263 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9264 (GDK_KEY_g): Don't define if already defined.
9265 (xg_prepare_tooltip): Avoid pointer signedness problem.
9266 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9267
fa3c87e1
PE
9268 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9269 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9270
2172544b
PE
9271 * xfns.c (Fx_window_property): Simplify a bit,
9272 to make a bit faster and to avoid GCC 4.6.0 warning.
9273 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9274
9b821a21
PE
9275 * fns.c (internal_equal): Don't assume size_t fits in int.
9276
3c616cfa
PE
9277 * alloc.c (compact_small_strings): Tighten assertion a little.
9278
c2982e87
PE
9279 Replace pEd with more-general pI, and fix some printf arg casts.
9280 * lisp.h (pI): New macro, generalizing old pEd macro to other
9281 conversion specifiers. For example, use "...%"pI"d..." rather
9282 than "...%"pEd"...".
9283 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9284 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9285 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9286 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9287 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9288 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9289 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9290 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9291 64-bit hosts.
9292 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9293 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9294 * print.c (safe_debug_print, print_object): Likewise.
9295 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9296 to int.
6f04d126
PE
9297 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9298 avoiding the 0 flag, which is not portable.
c2982e87
PE
9299 * process.c (Fmake_network_process): Use pI to avoid cast.
9300 * region-cache.c (pp_cache): Likewise.
9301 * xdisp.c (decode_mode_spec): Likewise.
9302 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9303 behavior on 64-bit hosts with printf arg.
6f04d126 9304 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9305 (x_stop_queuing_selection_requests): Likewise.
9306 (x_get_window_property): Don't truncate byte count to an 'int'
9307 when tracing.
0b432f21 9308
5e073ec7
PE
9309 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9310 here, since it parses constructs like leading '-' and spaces,
9311 which are not wanted; and it overflows with large numbers.
9312 Instead, simply match F[0-9]+, which is what is wanted anyway.
9313
36372bf9
PE
9314 * alloc.c: Remove unportable assumptions about struct layout.
9315 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9316 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9317 (allocate_vectorlike, make_pure_vector): Use the new macros,
9318 plus offsetof, to remove unportable assumptions about struct layout.
9319 These assumptions hold on all porting targets that I know of, but
9320 they are not guaranteed, they're easy to remove, and removing them
9321 makes further changes easier.
9322
0b432f21
PE
9323 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9324 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9325 (string_overrun_cookie): Now const. Use initializers that
9326 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9327 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9328 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9329 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9330 multiple of sizeof (EMACS_INT); it need not be, if
9331 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9332 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9333
895009e1
JB
93342011-04-26 Juanma Barranquero <lekktu@gmail.com>
9335
9336 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9337
6a7a1b0b
TZ
93382011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9339
9340 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9341 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9342 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9343
841a1577 93442011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9345
9346 * lisp.h (Qdebug): List symbol.
895009e1 9347 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9348 * keyboard.c (debug-on-event): New variable.
9349 (handle_user_signal): Break into debugger when debug-on-event
9350 matches the current signal symbol.
9351
f2d3ba6f
DN
93522011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9353
9354 * alloc.c (check_sblock, check_string_bytes)
9355 (check_string_free_list): Convert to standard C.
9356
42ce4c63
TZ
93572011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9358
9359 * w32.c (emacs_gnutls_push): Fix typo.
9360
825cd63c
EZ
93612011-04-25 Eli Zaretskii <eliz@gnu.org>
9362
fb11d64d
EZ
9363 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9364 "cast to pointer from integer of different size".
9365
825cd63c
EZ
9366 Improve doprnt and its use in verror. (Bug#8545)
9367 * doprnt.c (doprnt): Document the set of format control sequences
9368 supported by the function. Use SAFE_ALLOCA instead of always
9369 using `alloca'.
9370
9371 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9372 is one byte too soon. Don't use xrealloc; instead xfree and
9373 xmalloc anew.
9374
e061a11b
TZ
93752011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9376
9377 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9378 callbacks stage.
9379
9380 * gnutls.c: Renamed global_initialized to
9381 gnutls_global_initialized. Added internals for the
9382 :verify-hostname-error, :verify-error, and :verify-flags
9383 parameters of `gnutls-boot' and documented those parameters in the
9384 docstring. Start callback support.
9173deec
JB
9385 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9386 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9387 on error. Return error code.
e061a11b
TZ
9388 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9389 (emacs_gnutls_read): Likewise.
9390 (Fgnutls_boot): Return handshake error code.
9391 (emacs_gnutls_handle_error): New function.
9392 (wsaerror_to_errno): Likewise.
9393
9394 * w32.h (emacs_gnutls_pull): Add prototype.
9395 (emacs_gnutls_push): Likewise.
9396
9397 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9398 (emacs_gnutls_push): Likewise.
9399
94002011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9401
9402 * process.c (wait_reading_process_output): Check if GnuTLS
9403 buffered some data internally if no FDs are set for TLS
9404 connections.
9405
9406 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9407 (LIBS): Link to USER_LIBS.
9408 ($(BLD)/gnutls.$(0)): New target.
9409
fa6996bc
EZ
94102011-04-24 Eli Zaretskii <eliz@gnu.org>
9411
eb35682e
EZ
9412 * xdisp.c (handle_single_display_spec): Rename the
9413 display_replaced_before_p argument into display_replaced_p, to
9414 make it consistent with the commentary. Fix typos in the
9415 commentary.
9416
e2ad650c
EZ
9417 * textprop.c (syms_of_textprop): Remove dead code.
9418 (copy_text_properties): Delete obsolete commentary about an
9419 interface that was deleted long ago. Fix typos in the description
9420 of arguments.
9421
1b2de274
EZ
9422 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9423 to changes in oldXMenu/XMenu.h from 2011-04-16.
9424 <menu_help_message, prev_menu_help_message>: Constify.
9425 (IT_menu_make_room): menu->help_text is now `const char **';
9426 adjust.
9427
9428 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9429 to changes in oldXMenu/XMenu.h from 2011-04-16.
9430 (struct XMenu): Declare `help_text' `const char **'.
9431
9432 * xfaces.c <Qunspecified>: Make extern again.
9433
9434 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9435 required by POSIX.
1b2de274 9436
762b15be
EZ
9437 * doc.c (get_doc_string): Improve the format passed to `error'.
9438
9439 * doprnt.c (doprnt): Improve commentary.
9440
9441 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9442
9443 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9444 them with etags.
9445
f1052e5d
EZ
9446 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9447 changes in globals.h immediately force recompilation.
762b15be
EZ
9448 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9449 $(CURDIR)/s/ms-w32.h.
9450 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9451
fa6996bc
EZ
9452 * character.c (Fchar_direction): Function deleted.
9453 (syms_of_character): Don't defsubr it.
9454 <char-direction-table>: Deleted.
9455
e6c3da20
EZ
94562011-04-23 Eli Zaretskii <eliz@gnu.org>
9457
9458 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9459 * doprnt.c: Include limits.h.
9460 (SIZE_MAX): New macro.
04f2d78b
CB
9461 (doprnt): Return a size_t value. 2nd arg is now size_t.
9462 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9463 Improve overflow protection. Support `l' modifier for integer
9464 conversions. Support %l conversion. Don't assume an EMACS_INT
9465 argument for integer conversions and for %c.
9466
9467 * lisp.h (doprnt): Restore prototype.
9468
9469 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9470 $(SRC)/character.h.
9471
9472 * Makefile.in (base_obj): Add back doprnt.o.
9473
9474 * deps.mk (doprnt.o): Add back prerequisites.
9475 (callint.o): Depend on character.h.
9476
9477 * eval.c (internal_lisp_condition_case): Include the handler
9478 representation in the error message.
9479 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9480 when breaking from the loop.
9481
9482 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9483
9484 * callint.c (Fcall_interactively): When displaying error message
9485 about invalid control letter, pass the character's codepoint, not
9486 a pointer to its multibyte form. Improve display of the character
9487 in octal and display also its hex code.
9488
9489 * character.c (char_string): Use %x to display the (unsigned)
9490 codepoint of an invalid character, to avoid displaying a bogus
9491 negative value.
9492
9493 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9494 `error', not SYMBOL_NAME itself.
9495
9496 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9497 character arguments to `error'.
9498
9499 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9500 to `error' in error message about FINAL_CHAR argument. Make sure
9501 FINAL_CHAR is a character, and use %c when it is passed as
9502 argument to `error'.
9503
4ffd0d6b 95042011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9505
9506 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9507
9508 * w32.c: Include <time.h>.
9509 (sys_localtime): New function.
9510
4ffd0d6b 95112011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9512
9513 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9514
4ffd0d6b 9515 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9516
4ffd0d6b 95172011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9518
4ffd0d6b
GM
9519 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9520 zombies (Bug#8467).
aac0c6e3 9521
04c56954
EZ
95222011-04-19 Eli Zaretskii <eliz@gnu.org>
9523
9524 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9525 gl_state.e_property when gl_state.object is Qt.
9526
9527 * insdel.c (make_gap_larger): Remove limitation of buffer size
9528 to <= INT_MAX.
9529
16a43933
CY
95302011-04-18 Chong Yidong <cyd@stupidchicken.com>
9531
9532 * xdisp.c (lookup_glyphless_char_display)
9533 (produce_glyphless_glyph): Handle cons cell entry in
9534 glyphless-char-display.
9535 (Vglyphless_char_display): Document it.
9536
9537 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9538 glyphless-char-display.
9539
4581706e
CY
95402011-04-17 Chong Yidong <cyd@stupidchicken.com>
9541
9542 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9543
9544 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9545
9546 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9547 definition for no-X builds.
9548
4887c6e2 95492011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9550
fd35b6f9
PE
9551 Static checks with GCC 4.6.0 and non-default toolkits.
9552
5c1ccb01
PE
9553 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9554
006c5daa
PE
9555 * process.c (keyboard_bit_set): Define only if SIGIO.
9556 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9557 (send_process): Repair possible setjmp clobbering.
9558
efc736d3
PE
9559 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9560
4e2fe2e6
PE
9561 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9562
f97334a2
PE
9563 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9564
4e75f29d
PE
9565 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9566 Define only if needed.
9567
90efadd1
PE
9568 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9569 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9570 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9571
3c647824
PE
9572 * dispextern.h (struct redisplay_interface): Rename param
9573 to avoid shadowing.
e264f262 9574 * termhooks.h (struct terminal): Likewise.
761383f4 9575 * xterm.c (xembed_send_message): Likewise.
3c647824 9576
b58c5c4a
PE
9577 * insdel.c (make_gap_smaller): Define only if
9578 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9579
cad59032
PE
9580 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9581 it.
9582
c339dc2e
PE
9583 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9584 so that we aren't warned about unused symbols.
9585
91a3e27b
PE
9586 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9587
399c71d3 9588 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9589
8ffc96f5
PE
9590 * xfns.c (x_real_positions): Mark locals as initialized.
9591
eef9bc79
PE
9592 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9593
098db9dd
PE
9594 * xterm.c: Fix problems found by static analysis with other toolkits.
9595 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9596 (x_dispatch_event): Declare static if USE_GTK, and
9597 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9598 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9599 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9600 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9601 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9602
eb18f6cc
PE
9603 * xmenu.c (menu_help_callback): Pointer type fixes.
9604 Use const pointers when pointing at readonly data. Avoid pointer
9605 signedness clashes.
9606 (FALSE): Remove unused macro.
9607 (update_frame_menubar): Remove unused decl.
9608
1fe72bf8
PE
9609 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9610
60d9e1db
PE
9611 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9612 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9613 (single_menu_item): Rename local to avoid shadowing.
9614
39261c26
PE
9615 * keyboard.c (make_lispy_event): Remove unused local var.
9616
018c5e19
PE
9617 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9618 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9619
63d2b86e
PE
9620 * bitmaps: Change bitmaps from unsigned char back to the X11
9621 compatible char. Avoid the old compiler warnings about
9622 out-of-range initializers by using, for example, '\xab' rather
9623 than 0xab.
9624
aefd87e1
PE
9625 * xgselect.c (xgselect_initialize): Check vs interface
9626 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9627
bf501fb9
PE
9628 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9629
e9829fdf
PE
9630 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9631 to read-only memory.
9632
1086c095
PE
9633 * fns.c (vector): Remove; this old hack is no longer needed.
9634
2baccd04 9635 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9636 Remove unused var.
dde42981 9637 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9638
72391843 9639 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9640
436c16df 9641 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9642 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9643 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9644
92bb796d 9645 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9646 (x_term_init): Remove local to avoid shadowing.
92bb796d 9647
764430a3 9648 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9649
9650 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9651 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9652
d1dfb56c
EZ
96532011-04-16 Eli Zaretskii <eliz@gnu.org>
9654
c4354cb4
EZ
9655 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9656
d1dfb56c
EZ
9657 Fix regex.c, syntax.c and friends for buffers > 2GB.
9658 * syntax.h (struct gl_state_s): Declare character position members
9659 EMACS_INT.
9660
9661 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9662
04f2d78b
CB
9663 * textprop.c (verify_interval_modification, interval_of):
9664 Declare arguments EMACS_INT.
d1dfb56c
EZ
9665
9666 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9667 EMACS_INT.
9668
9669 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9670
9671 * indent.c (Fvertical_motion): Local variable it_start is now
9672 EMACS_INT.
9673
9674 * regex.c (re_match, re_match_2, re_match_2_internal)
9675 (bcmp_translate, regcomp, regexec, print_double_string)
9676 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9677 (re_compile_pattern, re_exec): Declare arguments and local
9678 variables `size_t' and `ssize_t' and return values `regoff_t', as
9679 appropriate.
9680 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9681 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9682 <compile_stack_type>: `size' and `avail' are now `size_t'.
9683
9684 * regex.h <regoff_t>: Use ssize_t, not int.
9685 (re_search, re_search_2, re_match, re_match_2): Arguments that
9686 specify buffer/string position and length are now ssize_t and
9687 size_t. Return type is regoff_t.
9688
613052cd
BK
96892011-04-16 Ben Key <bkey76@gmail.com>
9690
9691 * nsfont.m: Fixed bugs in ns_get_family and
9692 ns_descriptor_to_entity that were caused by using free to
9693 deallocate memory blocks that were allocated by xmalloc (via
9694 xstrdup). This caused Emacs to crash when compiled with
9695 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9696 --enable-checking=xmallocoverrun). xfree is now used to
9697 deallocate these memory blocks.
9698
4170f62f 96992011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9700
71b41406
PE
9701 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9702
9587a89d
PE
9703 emacs_write: Accept and return EMACS_INT for sizes.
9704 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9705 et seq.
9706 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9707 Accept and return EMACS_INT.
9708 (emacs_gnutls_write): Return the number of bytes written on
9709 partial writes.
9710 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9711 (emacs_read, emacs_write): Remove check for negative size, as the
9712 Emacs source code has been audited now.
9587a89d
PE
9713 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9714 (emacs_read, emacs_write): Use it.
273a5f82
PE
9715 * process.c (send_process): Adjust to the new signatures of
9716 emacs_write and emacs_gnutls_write. Do not attempt to store
9717 a byte offset into an 'int'; it might overflow.
9587a89d 9718 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9719
3e047f51
PE
9720 * sound.c: Don't assume sizes fit in 'int'.
9721 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9722 Return EMACS_INT, not int.
3e047f51 9723 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9724 Accept EMACS_INT, not int.
9725 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9726 record read return values.
9727
cc39a9db
BK
97282011-04-15 Ben Key <bkey76@gmail.com>
9729
c9d0ec6d
JB
9730 * keyboard.c (Qundefined): Don't declare static since it is used
9731 in nsfns.m.
9732 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9733 static since they are used in nsfont.m.
cc39a9db 9734
6c60eb9f
SM
97352011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9736
9737 * process.c (Qprocessp): Don't declare static.
9738 * lisp.h (Qprocessp): Declare again.
9739
7990b61a
JB
97402011-04-15 Juanma Barranquero <lekktu@gmail.com>
9741
9742 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9743
5d4cb038
PE
97442011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9745
8bd7b830 9746 Improve C-level modularity by making more things 'static'.
cd64ea1d 9747
e3b27b31
PE
9748 Don't publish debugger-only interfaces to other modules.
9749 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9750 (verify_bytepos, count_markers): Move decls to the only modules
9751 that need them.
9752 * region-cache.h (pp_cache): Likewise.
9753 * window.h (check_all_windows): Likewise.
9754 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9755
5d4cb038
PE
9756 * sysdep.c (croak): Now static, if
9757 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9758 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9759
9760 * alloc.c (refill_memory_reserve): Now static if
9761 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9762 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9763
e87b6180
PE
9764 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9765 Define only if USE_LUCID.
9766
ac64929e
PE
9767 * xrdb.c (x_customization_string, x_rm_string): Now static.
9768
6f37259d
PE
9769 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9770 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9771
1683e3ab
PE
9772 * xdisp.c (draw_row_with_mouse_face): Now static.
9773 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9774
de9c2632
PE
9775 * window.h (check_all_windows): Mark externally visible.
9776
2b96acb7
PE
9777 * window.c (window_deletion_count): Now static.
9778
9779 * undo.c: Make symbols static if they're not exported.
9780 (last_undo_buffer, last_boundary_position, pending_boundary):
9781 Now static.
9782
50436f33
PE
9783 * textprop.c (interval_insert_behind_hooks): Now static.
9784 (interval_insert_in_front_hooks): Likewise.
9785
64520e5c
PE
9786 * term.c: Make symbols static if they're not exported.
9787 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9788 (max_frame_lines, tty_set_terminal_modes):
9789 (tty_reset_terminal_modes, tty_turn_off_highlight):
9790 (get_tty_terminal): Now static.
9791 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9792 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9793 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9794 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9795 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9796
1fa53021
PE
9797 * sysdep.c: Make symbols static if they're not exported.
9798 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9799 Now static.
9800 (sigprocmask_set, full_mask): Remove; unused.
9801 (wait_debugging): Mark as visible.
9802 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9803 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9804
d4b43b22
PE
9805 * syntax.c (syntax_temp): Define only if !__GNUC__.
9806
b7c513d0
PE
9807 * sound.c (current_sound_device, current_sound): Now static.
9808
989b29ad
PE
9809 * search.c (searchbufs, searchbuf_head): Now static.
9810
13a55a78
PE
9811 * scroll.c (scroll_cost): Remove; unused.
9812 * dispextern.h (scroll_cost): Remove decl.
9813
de68a1fc
PE
9814 * region-cache.h (pp_cache): Mark as externally visible.
9815
40ccffa6
PE
9816 * process.c: Make symbols static if they're not exported.
9817 (process_tick, update_tick, create_process, chan_process):
9818 (Vprocess_alist, proc_buffered_char, datagram_access):
9819 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9820 (deactivate_process): Mark defn as static, as well as decl.
9821 * lisp.h (create_process): Remove decl.
9822 * process.h (chan_process, Vprocess_alist): Remove decls.
9823
ad64fc97
PE
9824 * print.c: Make symbols static if they're not exported.
9825 (print_depth, new_backquote_output, being_printed, print_buffer):
9826 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9827 (print_interval, print_number_index, initial_stderr_stream):
9828 Now static.
9829 * lisp.h (Fprinc): Remove decl.
9830 (debug_output_compilation_hack): Mark as externally visible.
9831
adddb265
PE
9832 * sysdep.c (croak): Move decl from here to syssignal.h.
9833 * syssignal.h (croak): Put it here, so the API can be checked when
9834 'croak' is called from dissociate_if_controlling_tty.
9835
1717ede2
PE
9836 * minibuf.c: Make symbols static if they're not exported.
9837 (minibuf_save_list, choose_minibuf_frame): Now static.
9838 * lisp.h (choose_minibuf_frame): Remove decl.
9839
fa5fb2bc
PE
9840 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9841
1e3890d1
PE
9842 * lread.c: Make symbols static if they're not exported.
9843 (read_objects, initial_obarray, oblookup_last_bucket_number):
9844 Now static.
9845 (make_symbol): Remove; unused.
9846 * lisp.h (initial_obarray, make_symbol): Remove decls.
9847
8a1414fa
PE
9848 * keyboard.c: Make symbols static if they're not exported.
9849 (single_kboard, recent_keys_index, total_keys, recent_keys):
9850 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9851 (this_single_command_key_start, echoing, last_auto_save):
9852 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9853 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9854 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9855 (Vlispy_mouse_stem, double_click_count):
9856 Now static.
9857 (force_auto_save_soon): Define only if SIGDANGER.
9858 (ignore_mouse_drag_p): Now static if
9859 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9860 (print_help): Remove; unused.
9861 (stop_character, last_timer_event): Mark as externally visible.
9862 * keyboard.h (ignore_mouse_drag_p): Declare only if
9863 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9864 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9865 * lisp.h (echoing): Remove decl.
9866 (force_auto_save_soon): Declare only if SIGDANGER.
9867 * xdisp.c (redisplay_window): Simplify code, to make it more
9868 obvious that ignore_mouse_drag_p is not accessed if !defined
9869 USE_GTK && !defined HAVE_NS.
9870
93ea6e8f
PE
9871 * intervals.c: Make symbols static if they're not exported.
9872 (merge_properties_sticky, merge_interval_right, delete_interval):
9873 Now static.
9874 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9875
77382fcc
PE
9876 * insdel.c: Make symbols static if they're not exported.
9877 However, leave prepare_to_modify_buffer alone. It's never
9878 called from outside this function, but that appears to be a bug.
9879 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9880 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9881 (adjust_after_replace_noundo): Remove; unused.
9882 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9883 (signal_before_change): Remove decls.
77382fcc 9884
9306c32e
PE
9885 * indent.c (val_compute_motion, val_vmotion): Now static.
9886
cd44d2eb
PE
9887 * image.c: Make symbols static if they're not exported.
9888 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9889 if USE_GTK.
9890 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9891 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9892
ad9a7a06
PE
9893 * fringe.c (standard_bitmaps): Now static.
9894 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9895
81626931
PE
9896 * frame.c: Make symbols static if they're not exported.
9897 (x_report_frame_params, make_terminal_frame): Now static.
9898 (get_frame_param): Now static, unless HAVE_NS.
9899 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9900 (x_get_resource_string): Remove; not used.
9901 * frame.h (make_terminal_frame, x_report_frame_params):
9902 (x_get_resource_string); Remove decls.
9903 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9904 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9905
239f9db9
PE
9906 * font.c, fontset.c: Make symbols static if they're not exported.
9907 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9908 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9909 * font.c (font_close_object): Now static.
9910 * font.h (font_close_object): Remove.
9911 * fontset.c (FONTSET_OBJLIST): Remove.
9912 (free_realized_fontset) #if-0 the body, which does nothing.
9913 (face_suitable_for_char_p): #if-0, as it's never called.
9914 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9915 * xfaces.c (face_at_string_position):
9916 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9917 since 0 is always ASCII.
9918
dfcf3579
PE
9919 * fns.c (weak_hash_tables): Now static.
9920
5045092b
PE
9921 * fileio.c: Make symbols static if they're not exported.
9922 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9923 (Vwrite_region_annotation_buffers): Now static.
9924
57a96f5c
PE
9925 * eval.c: Make symbols static if they're not exported.
9926 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9927 * lisp.h (backtrace_list): Remove decl.
9928
35f08c38
PE
9929 * emacs.c: Make symbols static if they're not exported.
9930 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9931 (fatal_error_code, fatal_error_signal_hook, standard_args):
9932 Now static.
9933 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9934 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9935 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9936 * lisp.h (fatal_error_signal_hook): Remove decl.
9937 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9938
f44bd759
PE
9939 * editfns.c: Move a (normally-unused) function to its only use.
9940 * editfns.c, lisp.h (get_operating_system_release): Remove.
9941 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9942 worth the hassle of breaking this out.
9943
b532497d
PE
9944 * xterm.c: Make symbols static if they're not exported.
9945 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9946 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9947 (x_destroy_window, x_delete_display):
9948 Now static.
9949 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9950 (x_mouse_leave): Remove; unused.
9951 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9952 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9953 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9954 Remove decls.
9955 (x_mouse_leave): Declare only if WINDOWSNT.
9956 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9957 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9958 USE_X_TOOLKIT.
9959
1675728f
PE
9960 * ftxfont.c: Make symbols static if they're not exported.
9961 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9962 HAVE_FREETYPE.
9963 * font.h (ftxfont_driver): Likewise.
9964
e4cebfca
PE
9965 * xfns.c: Make symbols static if they're not exported.
9966 (x_last_font_name, x_display_info_for_name):
9967 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9968 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9969 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9970 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9971 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9972 (last_show_tip_args): Now static.
9973 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9974 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9975 (x_screen_planes): Remove; unused.
9976 * dispextern.h (x_screen_planes): Remove decl.
9977
5bf46f05
PE
9978 * dispnew.c: Make symbols static if they're not exported.
9979 * dispextern.h (redraw_garbaged_frames, scrolling):
9980 (increment_row_positions): Remove.
9981 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9982 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9983 Now static.
9984 (redraw_garbaged_frames): Remove; unused.
9985
435f4c28
PE
9986 * xfaces.c: Make symbols static if they're not exported.
9987 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9988 Remove decls.
9989 * xterm.h (defined_color): Remove decls.
9990 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9991 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9992 (menu_face_changed_default, defined_color, free_realized_face):
9993 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9994 (ascii_face_of_lisp_face): Remove; unused.
9995
8524aef3
PE
9996 * xdisp.c: Make symbols static if they're not exported.
9997 * dispextern.h (scratch_glyph_row, window_box_edges):
9998 (glyph_to_pixel_coords, set_cursor_from_row):
9999 (get_next_display_element, set_iterator_to_next):
10000 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10001 (show_mouse_face): Remove decls
10002 * frame.h (message_buf_print): Likewise.
10003 * lisp.h (pop_message, set_message, check_point_in_composition):
10004 Likewise.
10005 * xterm.h (set_vertical_scroll_bar): Likewise.
10006 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10007 (message_buf_print, scratch_glyph_row, displayed_buffer):
10008 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10009 (get_next_display_element, show_mouse_face, window_box_edges):
10010 (frame_to_window_pixel_xy, check_point_in_composition):
10011 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10012 (glyph_to_pixel_coords): Remove; unused.
10013
16390cd2
PE
10014 * dired.c (file_name_completion): Now static.
10015
10016 * dbusbind.c (xd_in_read_queued_messages): Now static.
10017
a25f4dfa
PE
10018 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10019 * data.c (circular_list_error): Remove.
10020
14a9c8df
PE
10021 * commands.h (last_point_position, last_point_position_buffer):
10022 (last_point_position_window): Remove decls.
10023 * keyboard.c: Make these variables static.
10024
04f2d78b
CB
10025 * coding.h (coding, code_convert_region, encode_coding_gap):
10026 Remove decls.
74ab6df5
PE
10027 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10028 (iso_code_class, detect_coding, code_convert_region): Now static.
10029 (encode_coding_gap): Remove; unused.
10030
38dfbee1
PE
10031 * chartab.c (chartab_chars, chartab_bits): Now static.
10032
a2cb4e63
PE
10033 * charset.h (charset_iso_8859_1): Remove decl.
10034 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10035 Now static.
10036
127198fd
PE
10037 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10038 * ccl.c (Vccl_program_table): Now static.
10039 (check_ccl_update): Remove; unused.
10040
d85b608f
PE
10041 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10042 * category.h: ... from here.
10043 * category.c (check_category_table, set_category_set): Now static.
10044
31cd66f3
PE
10045 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10046 * lisp.h: Remove these decls.
10047
c358e587
PE
10048 * buffer.c (buffer_count): Remove unused var.
10049
e78aecca
PE
10050 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10051 so that it's not optimized away.
10052 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10053 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10054 exported only to the debugger.
10055
e192d7d3 10056 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10057 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10058
92470028
PE
10059 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10060 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10061 was inaccessible from Lisp.
10062 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10063 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10064
244ed907
PE
10065 alloc.c: Import and export fewer symbols, and remove unused items.
10066 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10067 is defined.
10068 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10069 it's not optimized away by whole-program optimization.
10070 (message_enable_multibyte, free_misc): Remove.
10071 (catchlist, handlerlist, mark_backtrace):
10072 Declare only if BYTE_MARK_STACK.
10073 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10074 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10075 (message_enable_multibyte): Remove decl.
10076 (free_misc, interval_free_list, float_block, float_block_index):
10077 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10078 (cons_free_list, last_marked_index):
10079 Now static.
10080 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10081 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10082 (mark_backtrace): Define only if BYTE_MARK_STACK.
10083 * xdisp.c (message_enable_multibyte): Now static.
10084
61c2b50e 10085 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10086 This makes it easier for human readers (and static analyzers)
10087 to see whether these variables are used from other modules.
10088 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10089 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10090 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10091 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10092 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10093 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10094 * xmenu.c, xselect.c:
10095 Declare Q* vars static if they are not used in other modules.
10096 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10097 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10098 Remove decls of unexported vars.
10099 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10100
95c82688
PE
10101 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10102
16a97296
PE
10103 Make Emacs functions such as Fatom 'static' by default.
10104 This makes it easier for human readers (and static analyzers)
10105 to see whether these functions can be called from other modules.
10106 DEFUN now defines a static function. To make the function external
10107 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10108 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10109 (Finit_image_library):
16a97296
PE
10110 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10111 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10112 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10113 Remove decls, since these functions are now static.
10114 (Funintern, Fget_internal_run_time): New decls, since these functions
10115 were already external.
95c82688 10116
16a97296
PE
10117 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10118 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10119 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10120 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10121 * keyboard.c, keymap.c, lread.c:
10122 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10123 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10124 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10125 Mark functions with DEFUE instead of DEFUN,
10126 if they are used in other modules.
10127 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10128 decls for now-static functions.
10129 * buffer.h (Fdelete_overlay): Remove decl.
10130 * callproc.c (Fgetenv_internal): Mark as internal.
10131 * composite.c (Fremove_list_of_text_properties): Remove decl.
10132 (Fcomposition_get_gstring): New forward static decl.
10133 * composite.h (Fcomposite_get_gstring): Remove decl.
10134 * dired.c (Ffile_attributes): New forward static decl.
10135 * doc.c (Fdocumntation_property): New forward static decl.
10136 * eval.c (Ffetch_bytecode): New forward static decl.
10137 (Funintern): Remove extern decl; now in .h file where it belongs.
10138 * fileio.c (Fmake_symbolic_link): New forward static decl.
10139 * image.c (Finit_image_library): New forward static decl.
10140 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10141 * intervals.h (Fprevious_property_change):
10142 (Fremove_list_of_text_properties): Remove decls.
10143 * keyboard.c (Fthis_command_keys): Remove decl.
10144 (Fcommand_execute): New forward static decl.
10145 * keymap.c (Flookup_key): New forward static decl.
10146 (Fcopy_keymap): Now static.
10147 * keymap.h (Flookup_key): Remove decl.
10148 * process.c (Fget_process): New forward static decl.
10149 (Fprocess_datagram_address): Mark as internal.
10150 * syntax.c (Fsyntax_table_p): New forward static decl.
10151 (skip_chars): Remove duplicate decl.
10152 * textprop.c (Fprevious_property_change): New forward static decl.
10153 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10154 Now internal.
10155 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10156 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10157
785bbd42
PE
10158 * editfns.c (Fformat): Remove unreachable code.
10159
8b913b57
AS
101602011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10161
10162 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10163 change. (Bug#8496)
10164
a6744a35
EZ
101652011-04-13 Eli Zaretskii <eliz@gnu.org>
10166
10167 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10168 when at ZV. (Bug#8487)
10169
e7974947
AS
101702011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10171
baad03f0
AS
10172 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10173 (Bug#8437)
10174 * keyboard.c (parse_tool_bar_item): Likewise.
10175 * sound.c (sound_cleanup, alsa_close): Likewise.
10176 * termcap.c (tgetent): Likewise.
10177 * xfns.c (x_default_font_parameter): Likewise.
10178 * xsettings.c (read_and_apply_settings): Likewise.
10179
e7974947
AS
10180 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10181 (overrun_check_free): Protoize.
10182
28272684
PE
101832011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10184
10185 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10186 since callers should never pass a negative size.
10187 Change the signature to match that of plain 'read' and 'write'; see
10188 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10189 * lisp.h: Update prototypes of emacs_write and emacs_read.
10190
11997c76
EZ
101912011-04-11 Eli Zaretskii <eliz@gnu.org>
10192
10193 * xdisp.c (redisplay_window): Don't try to determine the character
10194 position of the scroll margin if the window start point w->startp
e896f03c 10195 is outside the buffer's accessible region. (Bug#8468)
11997c76 10196
8a2cbd72
EZ
101972011-04-10 Eli Zaretskii <eliz@gnu.org>
10198
10199 Fix write-region and its subroutines for buffers > 2GB.
10200 * fileio.c (a_write, e_write): Modify declaration of arguments and
10201 local variables to support buffers larger than 2GB.
10202 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10203
10204 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10205 argument, local variables, and return value.
10206
10207 * lisp.h: Update prototypes of emacs_write and emacs_read.
10208
10209 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10210
4073e537 102112011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10212
1ebfdcb6
PE
10213 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10214
b2ded58d
PE
10215 Fix more problems found by GCC 4.6.0's static checks.
10216
7d66342c
PE
10217 * xdisp.c (vmessage): Use a better test for character truncation.
10218
bbf47d44
PE
10219 * charset.c (load_charset_map): <, not <=, for optimization,
10220 and to avoid potential problems with integer overflow.
9248994d 10221 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10222 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10223 * editfns.c (Fformat): Likewise.
1e69125e 10224 * syntax.c (skip_chars): Likewise.
3befa583 10225
e3019616
PE
10226 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10227 This also lets GCC 4.6.0 generate slightly better loop code.
10228
becfa255
PE
10229 * callint.c (Fcall_interactively): <, not <=, for optimization.
10230 (Fcall_interactively): Count the number of arguments produced,
10231 not the number of arguments given. This is simpler and lets GCC
10232 4.6.0 generate slightly better code.
10233
dae0cd48
PE
10234 * ftfont.c: Distingish more carefully between FcChar8 and char.
10235 The previous code passed unsigned char * to a functions like
10236 strlen and xstrcasecmp that expect char *, which does not
10237 conform to the C standard.
10238 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10239 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10240 char * when the C standard requires it.
10241
76032d70
PE
10242 * keyboard.c (read_char): Remove unused var.
10243
eb3f1cc8
PE
10244 * eval.c: Port to Windows vsnprintf (Bug#8435).
10245 Include <limits.h>.
10246 (SIZE_MAX): Define if the headers do not.
10247 (verror): Do not give up if vsnprintf returns a negative count.
10248 Instead, grow the buffer. This ports to Windows vsnprintf, which
10249 does not conform to C99. Problem reported by Eli Zaretskii.
10250 Also, simplify the allocation scheme, by avoiding the need for
10251 calling realloc, and removing the ALLOCATED variable.
10252
70476b54
PE
10253 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10254
12020a9e
PE
10255 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10256 But keep the doprint source code for now, as we might revamp it
10257 and use it again (Bug#8435).
ea6c7ae6
PE
10258 * lisp.h (doprnt): Remove.
10259 * Makefile.in (base_obj): Remove doprnt.o.
10260 * deps.mk (doprnt.o): Remove.
10261
5fdb398c
PE
10262 error: Print 32- and 64-bit integers portably (Bug#8435).
10263 Without this change, on typical 64-bit hosts error ("...%d...", N)
10264 was used to print both 32- and 64-bit integers N, which relied on
10265 undefined behavior.
61bdb816 10266 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10267 * lisp.h (error, verror): Mark as printf-like functions.
10268 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10269 Report overflow in size calculations when allocating printf buffer.
10270 Do not truncate output string at its first null byte.
10271 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10272 Truncate the output at a character boundary, since vsnprintf does not
10273 do that.
10274 * charset.c (check_iso_charset_parameter): Convert internal
10275 character to string before calling 'error', since %c now has the
10276 printf meaning.
10277 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10278 overflow when computing char to be passed to 'error'. Do not
10279 pass Lisp_Object to 'error'; pass the integer instead.
10280 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10281 formatted with plain %d.
10282
b189fa66
PE
10283 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10284
bff87ef0
PE
10285 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10286
7e2cac20
PE
10287 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10288
ce4d90b5
PE
10289 * xterm.c (x_catch_errors): Remove duplicate declaration.
10290
266c9547
PE
10291 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10292
79c49ad2
PE
10293 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10294
368f4090
JM
102952011-04-10 Jim Meyering <meyering@redhat.com>
10296
10297 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10298 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10299 return ssize_t not "int", and use size_t as the buffer length.
10300 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10301 * gnutls.h: Update declarations.
10302 * process.c (read_process_output): Use ssize_t, to match.
10303 (send_process): Likewise.
10304
a32d4040
CY
103052011-04-09 Chong Yidong <cyd@stupidchicken.com>
10306
10307 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10308
8546720e 103092011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10310
04f2d78b
CB
10311 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10312 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10313
8546720e
GM
10314 * xterm.c (handle_one_xevent):
10315 * xmenu.c (create_and_show_popup_menu):
10316 * xselect.c (x_decline_selection_request)
10317 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10318
0a2f5c1a 103192011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10320
10321 Fix some uses of `int' instead of EMACS_INT.
10322 * search.c (string_match_1, fast_string_match)
10323 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10324 (scan_buffer, find_next_newline_no_quit)
10325 (find_before_next_newline, search_command, Freplace_match)
10326 (Fmatch_data): Make some `int' variables be EMACS_INT.
10327
10328 * xdisp.c (display_count_lines): 3rd argument and return value now
10329 EMACS_INT. All callers changed.
10330 (pint2hrstr): Last argument is now EMACS_INT.
10331
10332 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10333 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10334 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10335 (decode_coding_utf_16, decode_coding_emacs_mule)
10336 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10337 (decode_coding_ccl, decode_coding_charset)
10338 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10339 (decode_coding_iso_2022, decode_coding_emacs_mule)
10340 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10341 <char_offset, last_offset>: Declare EMACS_INT.
10342 (encode_coding_utf_8, encode_coding_utf_16)
10343 (encode_coding_emacs_mule, encode_invocation_designation)
10344 (encode_designation_at_bol, encode_coding_iso_2022)
10345 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10346 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10347 Declare EMACS_INT.
10348 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10349 (encode_invocation_designation): Last argument P_NCHARS is now
10350 EMACS_INT.
10351 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10352 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10353
10354 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10355 All users changed.
10356
10357 * ccl.c (Fccl_execute_on_string): Declare some variables
10358 EMACS_INT.
10359
8546720e 103602011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10361
10362 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10363
4e19a977
CS
103642011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10365
10366 * process.c (Fformat_network_address): Doc fix.
10367
87302331
R
103682011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10369
ee7683eb 10370 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10371
cbb59342
CY
103722011-04-08 Chong Yidong <cyd@stupidchicken.com>
10373
10374 * keyboard.c (read_char): Call Lisp function help-form-show,
10375 instead of using internal_with_output_to_temp_buffer.
10376 (Qhelp_form_show): New var.
e0d38eeb 10377 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10378
10379 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10380
10381 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10382
e67a13ab
CY
103832011-04-06 Chong Yidong <cyd@stupidchicken.com>
10384
04f2d78b
CB
10385 * process.c (Flist_processes): Remove to Lisp.
10386 (list_processes_1): Delete.
e67a13ab 10387
973f782d
EZ
103882011-04-06 Eli Zaretskii <eliz@gnu.org>
10389
7c106b1e
EZ
10390 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10391
973f782d
EZ
10392 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10393
41cf7d1a 103942011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10395
ca23cc88
PE
10396 Fix more problems found by GCC 4.6.0's static checks.
10397
f390e2d5
PE
10398 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10399
42eea0d0
PE
10400 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10401
b69769da 10402 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10403
f9541e84
PE
10404 * xdisp.c (vmessage): Mark as a printf-like function.
10405
13841b55
PE
10406 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10407
c136c10f
PE
10408 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10409
5e2d4a30
PE
10410 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10411 printf-like functions.
10412 (tiff_load): Add casts to remove these marks before passing them
10413 to system-supplied API.
10414
583f48b9
PE
10415 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10416
b25d760e
PE
10417 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10418 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10419 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10420 directly, rather than having caller test rule sign. This avoids
10421 some unnecessary tests.
10422 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10423 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10424 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10425
bc7b6697 10426 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10427 (xfont_open): Avoid unnecessary tests.
bc7b6697 10428
27ccc379
PE
10429 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10430
dcd5c89a
PE
10431 * composite.h, composite.c (composition_gstring_put_cache):
10432 Use EMACS_INT, not int, for length.
10433
b13a45c6
PE
10434 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10435 breaking out part of COMPOSITION_DECODE_RULE.
10436 (COMPOSITION_DECODE_RULE): Use it.
10437 * composite.c (get_composition_id): Remove unused local vars,
10438 by using the new macro.
10439
1e792e4d
PE
10440 * textprop.c (set_text_properties_1): Change while to do-while,
10441 since the condition is always true at first.
10442
dc6c6455 10443 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10444 (interval_deletion_adjustment): Return unsigned value.
10445 All uses changed.
dc6c6455 10446
aba7731a
PE
10447 * process.c (list_processes_1, create_pty, read_process_output):
10448 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10449 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10450 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10451 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10452 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10453
fdfc4bf3
PE
10454 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10455
fca8fe46 10456 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10457 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10458
06a0259a 10459 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10460 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10461 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10462
e7b9e80f
PE
10463 * print.c (print_error_message): Avoid int overflow.
10464
56201685
PE
10465 * font.c (font_list_entities): Redo for clarity,
10466 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10467
78834453 10468 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10469 (font_score): Avoid potential overflow in diff calculation.
78834453 10470
0bc0b309 10471 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10472 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10473
e610eaca
PE
10474 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10475
b895abce
PE
10476 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10477 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10478 can always succeed if overflow has undefined behavior.
10479
1f1d9321 10480 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10481 (wordify): Omit three unnecessary tests.
1f1d9321 10482
c59478bc
PE
10483 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10484 All callers changed. This avoids the need for an unused var.
10485
79b73827
PE
10486 * casefiddle.c (casify_region): Remove var that is set but not used.
10487
a4db5dfe
PE
10488 * dired.c (file_name_completion): Remove var that is set but not used.
10489
43aae36e
PE
10490 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10491
2a47c44d 10492 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10493 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10494
a37c69bf
PE
10495 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10496 Check for integer overflow on size calculations.
10497
328ab8e7
PE
10498 * buffer.c (Fprevious_overlay_change): Remove var that is set
10499 but not used.
10500
e5a2a5cb
PE
10501 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10502 Remove vars that are set but not used.
8d84a6eb 10503 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10504 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10505
a60e5f68
PE
10506 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10507
f661cb61 10508 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10509 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10510
f0397f5a
PE
10511 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10512 that are set but not used.
10513
8664db06 10514 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10515 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10516
6abdaa4a
PE
10517 * xselect.c (x_get_local_selection, x_handle_property_notify):
10518 Remove vars that are set but not used.
10519
0ce7538d 10520 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10521 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10522
9ae848fc
PE
10523 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10524 Remove var that is set but not used.
0b918413
PE
10525 (scroll_bar_windows_size): Now size_t, not int.
10526 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10527 Check for overflow.
9ae848fc 10528
a5a62657
PE
10529 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10530 (map_tty_color) [!defined MSDOS]: Likewise.
10531
5c5cdd39
PE
10532 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10533
66ebf983
PE
10534 * coding.c: Remove vars that are set but not used.
10535 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10536 All callers changed.
10537 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10538 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10539 (decode_coding_charset): Remove vars that are set but not used.
10540
1be4d761
PE
10541 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10542 that is set but not used.
10543
47553fa8
PE
10544 * print.c (print_object): Remove var that is set but not used.
10545
1f7196bf 10546 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10547 The gnulib version avoids calling malloc in the usual case,
10548 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10549 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10550 * filelock.c (current_lock_owner): Likewise.
10551 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10552 * sysdep.c: Include allocator.h, careadlinkat.h.
10553 (emacs_no_realloc_allocator): New static constant.
10554 (emacs_readlink): New function.
fdb61804
PE
10555 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10556 ../lib/careadlinkat.h.
d1fdcab7 10557
f84c17c7
SM
105582011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10559
10560 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10561 first non-nil return value).
10562
ef3862ad
JD
105632011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10564
10565 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10566 if not defined (Bug#8403).
10567
376a7006
JB
105682011-04-02 Juanma Barranquero <lekktu@gmail.com>
10569
10570 * xdisp.c (display_count_lines): Remove parameter `start',
10571 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10572 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10573 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10574 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10575 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10576 and thereabouts. All callers changed.
10577 (get_per_char_metric): Remove parameter `f', unused since
10578 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10579
6ca3801d
JM
105802011-04-02 Jim Meyering <meyering@redhat.com>
10581
10582 do not dereference NULL upon failed strdup
10583 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10584 (ns_get_family): Likewise.
10585
d8e2b5ba
JB
105862011-04-02 Juanma Barranquero <lekktu@gmail.com>
10587
10588 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10589
8c74fcbd
JD
105902011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10591
10592 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10593 later (Bug#8403).
10594
7200d79c
SM
105952011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10596
03408648 10597 Add lexical binding.
7200d79c 10598
03408648
SM
10599 * window.c (Ftemp_output_buffer_show): New fun.
10600 (Fsave_window_excursion):
10601 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10602
10603 * lread.c (lisp_file_lexically_bound_p): New function.
10604 (Fload): Bind Qlexical_binding.
10605 (readevalloop): Remove `evalfun' arg.
10606 Bind Qinternal_interpreter_environment.
10607 (Feval_buffer): Bind Qlexical_binding.
10608 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10609 Mark as dynamic.
10610 (syms_of_lread): Declare `lexical-binding'.
10611
10612 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10613
10614 * keyboard.c (eval_dyn): New fun.
10615 (menu_item_eval_property): Use it.
ca105506
SM
10616
10617 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10618
03408648
SM
10619 * fns.c (concat, mapcar1): Accept byte-code-functions.
10620
10621 * eval.c (Fsetq): Handle lexical vars.
10622 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10623 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10624 (FletX, Flet): Obey lexical binding.
10625 (Fcommandp): Handle closures.
10626 (Feval): New `lexical' arg.
10627 (eval_sub): New function extracted from Feval. Use it almost
10628 everywhere where Feval was used. Look up vars in lexical env.
10629 Handle closures.
10630 (Ffunctionp): Move from subr.el.
10631 (Ffuncall): Handle closures.
10632 (apply_lambda): Remove `eval_flags'.
10633 (funcall_lambda): Handle closures and new byte-code-functions.
10634 (Fspecial_variable_p): New function.
10635 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10636 but without exporting it to Lisp.
23aba0ea 10637
23aba0ea 10638 * doc.c (Fdocumentation, store_function_docstring):
03408648 10639 * data.c (Finteractive_form): Handle closures.
23aba0ea 10640
03408648
SM
10641 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10642 interactive spec.
ba83908c 10643
04f2d78b
CB
10644 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10645 New byte-codes.
03408648
SM
10646 (exec_byte_code): New function extracted from Fbyte_code to handle new
10647 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10648
03408648 10649 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10650
03408648 10651 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10652
e2abce01
JB
106532011-03-31 Juanma Barranquero <lekktu@gmail.com>
10654
10655 * xdisp.c (redisplay_internal): Fix prototype.
10656
63696a73 106572011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10658
63696a73 10659 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10660 (try_scrolling): Use it when setting scroll_limit.
10661 Limit scrolling to 100 screen lines.
63696a73
EZ
10662 (redisplay_window): Even when falling back on "recentering",
10663 position point in the window according to scroll-conservatively,
10664 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10665
10666 (try_scrolling): When point is above the window, allow searching
10667 as far as scroll_max, or one screenful, to compute vertical
10668 distance from PT to the scroll margin position. This prevents
10669 try_scrolling from unnecessarily failing when
10670 scroll-conservatively is set to a value slightly larger than the
10671 window height. Clean up the case of PT below the margin at bottom
10672 of window: scroll_max can no longer be INT_MAX. When aggressive
10673 scrolling is in use, don't let point enter the opposite scroll
10674 margin as result of the scroll.
10675 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10676 threshold of 100 lines for never-recentering scrolling.
10677
e4cc2dfc
JB
106782011-03-31 Juanma Barranquero <lekktu@gmail.com>
10679
10680 * dispextern.h (move_it_by_lines):
10681 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10682 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10683 (message_log_check_duplicate): Remove parameters `prev_bol' and
10684 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10685 (redisplay_internal): Remove parameter `preserve_echo_area',
10686 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10687
10688 * indent.c (Fvertical_motion):
10689 * window.c (window_scroll_pixel_based, Frecenter):
10690 Don't pass `need_y_p' to `move_it_by_lines'.
10691
1c470562
SM
106922011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10693
44f230aa
SM
10694 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10695 steal a few bits to be more compact.
10696 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10697 Remove unneeded casts.
10698
1c470562
SM
10699 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10700
888adce9
ZK
107012011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10702
10703 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10704 binding" message (bug#7967).
10705
f838ed7b
PE
107062011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10707
77861b95
PE
10708 Fix more problems found by GCC 4.6.0's static checks.
10709
de6dbc14
PE
10710 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10711 Remove unused local var.
10712
f838ed7b
PE
10713 * editfns.c (Fmessage_box): Remove unused local var.
10714
792c7b2b
PE
10715 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10716 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10717 Omit unused local vars.
c499e557 10718 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10719 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10720 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10721 Omit unused local var.
10722
ba0165e1
PE
10723 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10724 Don't assume string length fits in int.
32ad8845 10725 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10726 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10727
3c59b4c9
PE
10728 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10729 instead of alloca (Bug#8344).
10730
a3eed478 10731 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10732 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10733
eb4d412d
PE
10734 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10735
1658b401
PE
10736 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10737 concerns.
10738
10739 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10740
10741 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10742
9a2c6e05
PE
10743 * keyboard.c (syms_of_keyboard): Use the same style as later
10744 in this function when indexing through an array. This also
10745 works around GCC bug 48267.
10746
03d0a109
PE
10747 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10748
44f730c8
PE
10749 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10750
fe75f926
PE
10751 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10752 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10753
ffa8c828
PE
10754 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10755 This avoids undefined behavior on integer overflow, and is a bit
10756 more convenient anyway since it is compared to a size_t variable.
10757
c5101a77
PE
10758 Variadic C functions now count arguments with size_t, not int.
10759 This avoids an unnecessary limitation on 64-bit machines, which
10760 caused (substring ...) to crash on large vectors (Bug#8344).
10761 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10762 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10763 All variadic functions and their callers changed accordingly.
c5101a77
PE
10764 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10765 * data.c (arith_driver, float_arith_driver): Likewise.
10766 * editfns.c (general_insert_function): Likewise.
10767 * eval.c (struct backtrace.nargs, interactive_p)
10768 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10769 (funcall_lambda, mark_backtrace): Likewise.
10770 * fns.c (concat): Likewise.
10771 * frame.c (x_set_frame_parameters): Likewise.
10772 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10773 0 if not found, not -1. All callers changed.
10774
dd3f25f7
PE
10775 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10776 (stack_copy_size): Now size_t, not int.
10777 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10778
461c2ab9
JB
107792011-03-28 Juanma Barranquero <lekktu@gmail.com>
10780
10781 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10782 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10783 All callers changed.
10784
10785 * lisp.h (multibyte_char_to_unibyte):
10786 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10787 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10788 * character.h (CHAR_TO_BYTE8):
10789 * cmds.c (internal_self_insert):
10790 * editfns.c (general_insert_function):
10791 * keymap.c (push_key_description):
10792 * search.c (Freplace_match):
10793 * xdisp.c (message_dolog, set_message_1): All callers changed.
10794
f6d62986
SM
107952011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10796
10797 * keyboard.c (safe_run_hook_funcall): New function.
10798 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10799 don't set the hook to nil, but remove the offending function instead.
10800 (Qcommand_hook_internal): Remove, unused.
10801 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10802 Vcommand_hook_internal.
10803
10804 * eval.c (enum run_hooks_condition): Remove.
10805 (funcall_nil, funcall_not): New functions.
10806 (run_hook_with_args): Call each function through a `funcall' argument.
10807 Remove `cond' argument, now redundant.
10808 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10809 (Frun_hook_with_args_until_failure): Adjust accordingly.
10810 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10811
1db5b1ad
JB
108122011-03-28 Juanma Barranquero <lekktu@gmail.com>
10813
10814 * dispextern.h (string_buffer_position): Remove declaration.
10815
10816 * print.c (strout): Remove parameter `multibyte', unused since
10817 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10818
10819 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10820 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10821 All callers changed.
10822
10823 * w32.c (_wsa_errlist): Use braces for struct initializers.
10824
10825 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10826 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10827 All callers changed.
10828 (string_buffer_position): Likewise. Also, make static (it's never
10829 used outside xdisp.c).
10830 (cursor_row_p): Remove parameter `w', unused since
10831 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10832 (decode_mode_spec): Remove parameter `precision', introduced during
10833 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10834 All callers changed.
10835
5ffb62aa
JD
108362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10837
10838 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10839
461c2ab9 108402011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10841
10842 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10843 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10844 (ns_update_auto_hide_menu_bar): New functions.
10845 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10846 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10847 ns_constrain_all_frames.
10848 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10849 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10850
5c380ffb
JD
108512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10852
10853 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10854
9af30bdf
GM
108552011-03-27 Glenn Morris <rgm@gnu.org>
10856
10857 * syssignal.h: Replace RETSIGTYPE with void.
10858 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10859 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10860 Replace SIGTYPE with void everywhere.
10861 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10862 * s/template.h (SIGTYPE): Remove commented out definition.
10863
e2abce01
JB
108642011-03-26 Eli Zaretskii <eliz@gnu.org>
10865
10866 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10867 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10868
f868cd8a
JB
108692011-03-26 Juanma Barranquero <lekktu@gmail.com>
10870
59eb0929
JB
10871 * w32.c (read_unc_volume): Use parameter `henum', instead of
10872 global variable `wget_enum_handle'.
10873
10874 * keymap.c (describe_vector): Remove parameters `indices' and
10875 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10876 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10877
f868cd8a
JB
10878 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10879
10880 * keyboard.c (timer_check): Remove parameter `do_it_now',
10881 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10882 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10883 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10884
10885 * keyboard.c (read_char):
10886 * w32menu.c (w32_menu_display_help):
10887 * xmenu.c (show_help_event, menu_help_callback):
10888 Adjust calls to `show_help_echo'.
10889
10890 * gtkutil.c (xg_maybe_add_timer):
10891 * keyboard.c (readable_events):
10892 * process.c (wait_reading_process_output):
10893 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10894
10895 * insdel.c (adjust_markers_gap_motion):
10896 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10897 (gap_left, gap_right): Don't call it.
10898
2ecf6fdb
CY
108992011-03-25 Chong Yidong <cyd@stupidchicken.com>
10900
10901 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10902 incurred during fontification.
10903
6b1f9ba4
JB
109042011-03-25 Juanma Barranquero <lekktu@gmail.com>
10905
10906 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10907 (DEFVAR_PER_BUFFER): Don't pass it.
10908
10909 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10910 (scrolling_window): Don't pass it.
10911
0f4a96b5
JB
109122011-03-25 Juanma Barranquero <lekktu@gmail.com>
10913
10914 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10915
10916 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10917 and `suffix'.
10918 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10919 of variables specific to SELinux and computation of `encoded_absname'.
10920
10921 * image.c (XPutPixel): Remove unused variable `height'.
10922
10923 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10924
10925 * unexw32.c (get_section_info): Remove unused variable `section'.
10926
10927 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10928 (system_process_attributes): Remove unused variable `sess'.
10929 (sys_read): Remove unused variable `err'.
10930
10931 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10932 (w32_wnd_proc): Remove unused variable `isdead'.
10933 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10934 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10935 (x_create_tip_frame): Remove unused variable `tem'.
10936
10937 * w32inevt.c (w32_console_read_socket):
10938 Remove unused variable `no_events'.
10939
10940 * w32term.c (x_draw_composite_glyph_string_foreground):
10941 Remove unused variable `width'.
10942
1149507c
JB
109432011-03-24 Juanma Barranquero <lekktu@gmail.com>
10944
10945 * w32term.c (x_set_glyph_string_clipping):
10946 Don't pass uninitialized region to CombineRgn.
10947
9c88f339
JB
109482011-03-23 Juanma Barranquero <lekktu@gmail.com>
10949
10950 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10951 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10952 (Fx_close_connection): Remove unused variable `i'.
10953
10954 * w32font.c (w32font_draw): Return number of glyphs.
10955 (w32font_open_internal): Remove unused variable `i'.
10956 (w32font_driver): Add missing initializer.
10957
10958 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10959 (fill_in_menu): Remove unused variable `items_added'.
10960
10961 * w32term.c (last_mouse_press_frame): Remove static global variable.
10962 (w32_clip_to_row): Remove unused variable `f'.
10963 (x_delete_terminal): Remove unused variable `i'.
10964
10965 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10966 (NOTHING): Remove unused static global variable.
10967 (uniscribe_check_otf): Remove unused variable `table'.
10968 (uniscribe_font_driver): Add missing initializers.
10969
dee091a3
JD
109702011-03-23 Julien Danjou <julien@danjou.info>
10971
10972 * term.c (Fsuspend_tty, Fresume_tty):
10973 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10974 * window.c (temp_output_buffer_show):
10975 * insdel.c (signal_before_change):
10976 * frame.c (Fhandle_switch_frame):
10977 * fileio.c (Fdo_auto_save):
10978 * emacs.c (Fkill_emacs):
10979 * editfns.c (save_excursion_restore):
10980 * cmds.c (internal_self_insert):
10981 * callint.c (Fcall_interactively):
10982 * buffer.c (Fkill_all_local_variables):
10983 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10984 Use Frun_hooks.
0f4a96b5 10985 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10986 unconditionally since it does the check itself.
dee091a3 10987
2c520ab5 109882011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10989
c9c49752
PE
10990 Fix more problems found by GCC 4.5.2's static checks.
10991
8abc3f12
PE
10992 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10993 the first time through the loop, since we know p0 < p1 then.
10994 This also avoids a gcc -Wstrict-overflow warning.
10995
a2d26660
PE
10996 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10997 leading to a memory leak, possible in functions like
10998 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10999 of objects (Bug#8318).
a2d26660 11000
916c72e9
PE
11001 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11002 that could (at least in theory) be that large.
11003
19ab8a18
PE
11004 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11005 This is less likely to overflow, and avoids undefined behavior if
11006 overflow does occur. All callers changed. Use strtoul to scan
11007 for the unsigned long integer.
b7cbbd6f
PE
11008 (pint2hrstr): Simplify and tune code slightly.
11009 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11010
f0641eff
PE
11011 * scroll.c (do_scrolling): Work around GCC bug 48228.
11012 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11013
7f650bb9
PE
11014 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11015 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11016 (validate_x_resource_name): Simplify count usage.
11017 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11018
37dd57d1
PE
11019 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11020 fail (Bug#8306).
81e56e61 11021
699979fc 11022 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11023
401bf9b4
PE
11024 * process.c (Fmake_network_process): Use socklen_t, not int,
11025 where POSIX says socklen_t is required in portable programs.
11026 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11027 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11028 (Fmake_network_process, server_accept_connection):
11029 (wait_reading_process_output, read_process_output):
11030 Likewise.
11031
b93aacde
PE
11032 * process.c: Rename or move locals to avoid shadowing.
11033 (list_processes_1, Fmake_network_process):
11034 (read_process_output_error_handler, exec_sentinel_error_handler):
11035 Rename or move locals.
4dc343ee 11036 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11037 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11038 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11039 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11040 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11041
af8a867c 11042 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11043 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11044 Include tparam.h instead, since it declares them.
af8a867c
PE
11045 * cm.h (PC): Remove extern decl; tparam.h now does this.
11046 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11047 * terminfo.c: Include tparam.h, to check interfaces.
11048 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11049 (tparam): Adjust signature to match interface in tparam.h;
11050 this removes some undefined behavior. Check that outstring and len
11051 are zero, which they always are with Emacs.
11052 * tparam.h (PC, BC, UP): New extern decls.
11053
0248044d 11054 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11055 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11056
8ff096c1 11057 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11058 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11059 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11060 (ftfont_list): Remove unused local.
49eaafba
PE
11061 (get_adstyle_property, ftfont_pattern_entity):
11062 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11063 Rename locals to avoid shadowing.
8ff096c1 11064
e2be39f6
PE
11065 * xfont.c (xfont_list_family): Mark var as initialized.
11066
c9735e30
PE
11067 * xml.c (make_dom): Now static.
11068
8f5201ae
PE
11069 * composite.c (composition_compute_stop_pos): Rename local to
11070 avoid shadowing.
b246f932
PE
11071 (composition_reseat_it): Remove unused locals.
11072 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11073 (composition_update_it): Mark var as initialized.
11b61122
PE
11074 (find_automatic_composition): Mark vars as initialized,
11075 with a FIXME (Bug#8290).
8f5201ae 11076
760fbc2c
PE
11077 character.h: Rename locals to avoid shadowing.
11078 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11079 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11080 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11081 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11082 to avoid shadowing.
11083
ff08eb85
PE
11084 * textprop.c (property_change_between_p): Remove; unused.
11085
fc7bf025
PE
11086 * intervals.c (interval_start_pos): Now static.
11087
235d7abc
PE
11088 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11089
44f230aa
SM
11090 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11091 Rename locals to avoid shadowing.
3e7d6594 11092
50060332
PE
11093 * sound.c (wav_play, au_play, Fplay_sound_internal):
11094 Fix pointer signedness.
d01f234b 11095 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11096 (wav_play): Initialize a variable to 0, to prevent undefined
11097 behavior (Bug#8278).
50060332 11098
c4fc4e30
PE
11099 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11100
918436ed
PE
11101 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11102
c939f91b
PE
11103 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11104 clobbering (Bug#8298).
b9c7f648
PE
11105 * sysdep.c (sys_subshell): Likewise.
11106 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11107
6bd8c144
PE
11108 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11109 This should get cleaned up, so that child_setup has the
11110 same signature on all platforms.
11111
7710357c 11112 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11113 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11114
c59da222
CY
111152011-03-22 Chong Yidong <cyd@stupidchicken.com>
11116
11117 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11118 not to be necessary, and produces flickering.
11119
66b87493
GM
111202011-03-20 Glenn Morris <rgm@gnu.org>
11121
11122 * config.in: Remove file.
11123
45b6f6d5
JB
111242011-03-20 Juanma Barranquero <lekktu@gmail.com>
11125
11126 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11127 are now in src/globals.h.
11128 (syms_of_minibuf): Remove spurious & from previous change.
11129
cd394be1 111302011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11131
11132 * minibuf.c (completing-read-function): New variable.
11133 (completing-read-default): Rename from completing-read.
11134 (completing-read): Call completing-read-function.
11135
b14e3e21
CY
111362011-03-19 Juanma Barranquero <lekktu@gmail.com>
11137
11138 * xfaces.c (Fx_load_color_file):
11139 Read color file from absolute filename (bug#8250).
11140
f2b726e6
JB
111412011-03-19 Juanma Barranquero <lekktu@gmail.com>
11142
11143 * makefile.w32-in: Update dependencies.
11144
09f6ff02
EZ
111452011-03-17 Eli Zaretskii <eliz@gnu.org>
11146
11147 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11148
29a6015a
PE
111492011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11150
a3a6c54e
PE
11151 Fix more problems found by GCC 4.5.2's static checks.
11152
b766f867
PE
11153 * process.c (make_serial_process_unwind, send_process_trap):
11154 (sigchld_handler): Now static.
11155
be02381c
PE
11156 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11157 That way, the code declares only the vars that it needs.
11158 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11159 * s/cygwin.h (PTY_ITERATION): Likewise.
11160 * s/darwin.h (PTY_ITERATION): Likewise.
11161 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11162
57048744
PE
11163 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11164 * process.c (allocate_pty): Don't declare stb unless it's needed.
11165
7914961c 11166 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11167 (CONSTANTLIM): Remove; unused.
11168 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11169 Define only if needed.
7914961c 11170
b3967b18
PE
11171 * unexelf.c (unexec): Name an expression,
11172 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11173 Use a different way to cause a compilation error if anyone uses
11174 n rather than nn, a way that does not involve shadowing.
73366a00 11175 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11176
29a6015a
PE
11177 * deps.mk (unexalpha.o): Remove; unused.
11178
43cfc33e 11179 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11180 * unexec.h: New file.
ce701a33
PE
11181 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11182 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11183 Depend on unexec.h.
11184 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11185 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11186 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11187 Change as necessary to match prototype in unexec.h.
ce701a33 11188
01f44d5a
PE
11189 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11190 shadowing.
4f63c6bb 11191 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11192
a6670b0b
PE
11193 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11194 Rename locals to avoid shadowing.
11195
cef2010d 11196 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11197 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11198
d4d7173a
PE
11199 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11200
f08b802a
PE
11201 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11202 warning when compiling print.c.
11203
3ddb0639
PE
11204 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11205 instead of using an uninitialized var.
5ad03b97 11206 (font_sort_entities): Mark var as initialized.
3ddb0639 11207
170a2692
PE
11208 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11209
e663c700
PE
11210 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11211 pointers to constants.
89bc529a 11212 (font_parse_fcname): Remove unused vars.
7b81e2d0 11213 (font_delete_unmatched): Now static.
ea838e10 11214 (font_get_spec): Remove; unused.
13a547c6
PE
11215 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11216 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11217 Rename or move locals to avoid shadowing.
e663c700 11218
2a80c887 11219 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11220 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11221
1384fa33 11222 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11223 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11224
8b2c52e9
PE
11225 * alloc.c (mark_backtrace): Move decl from here ...
11226 * lisp.h: ... to here, so that it can be checked.
11227
475545b5 11228 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11229 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11230 (lisp_indirect_variable): Name an expression,
11231 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11232 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11233
b1349114 11234 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11235 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11236 Use const pointer when appropriate.
b1349114 11237
a2928364
PE
11238 * lisp.h (get_system_name, get_operating_system_release):
11239 Move decls here, to check interfaces.
11240 * process.c (get_operating_system_release): Move decl to lisp.h.
11241 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11242 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11243 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11244 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11245 (Fformat_time_string, Fencode_time, Finsert_char):
11246 (Ftranslate_region_internal, Fformat):
11247 Rename or remove local vars to avoid shadowing.
9710023e 11248 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11249
a415e694
PE
11250 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11251 avoid shadowing.
11252
8ef4622d
PE
11253 * lisp.h (eassert): Check that the argument compiles, even if
11254 ENABLE_CHECKING is not defined.
11255
946f9a5b
PE
11256 * data.c (Findirect_variable): Name an expression, to avoid
11257 gcc -Wbad-function-cast warning.
112396d6 11258 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11259 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11260 (Fmake_variable_buffer_local, Fmake_local_variable):
11261 Mark variables as initialized.
52746918 11262 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11263
e5aab7e7 11264 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11265 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11266 Rename locals to avoid shadowing.
dff45157
PE
11267 (mark_stack): Move local variables into the #ifdef region where
11268 they're used.
7bc26fdb
PE
11269 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11270 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11271 needed otherwise.
11272 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11273 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11274 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11275
e5aab7e7
PE
11276 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11277 avoids undefined behavior in theory.
11278
4da60324
PE
11279 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11280
88043301
PE
11281 Use functions, not macros, for up- and down-casing (Bug#8254).
11282 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11283 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11284 to use the following functions instead of these macros.
11285 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11286 EMACS_INT, since callers assume the returned value fits in int.
11287 (upcase1): Likewise, for UPCASE_TABLE.
11288 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11289 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11290 the race-condition problem in the old DOWNCASE.
88043301 11291
19ed5445
PE
11292 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11293 Rename locals to avoid shadowing.
11294 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11295 (regex_compile, re_search_2, re_match_2_internal):
11296 Remove unused local vars.
952db0d7
PE
11297 (FREE_VAR): Rewrite so as not to use empty "else",
11298 which gcc can warn about.
da053e48 11299 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11300 (RETALLOC_IF): Define only if needed.
11301 (WORDCHAR_P): Likewise. This one is never needed, but is used
11302 only in a comment talking about a compiler bug, so put inside
11303 the #if 0 of that comment.
11304 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11305 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11306 Remove; unused.
19ed5445 11307
1f3561e4 11308 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11309 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11310 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11311
ded6f8f7
PE
11312 * search.c (simple_search): Remove unused var.
11313
dbd37a95
PE
11314 * dired.c (compile_pattern): Move decl from here ...
11315 * lisp.h: ... to here, so that it can be checked.
11316 (struct re_registers): New forward decl.
11317
7e47afad
PE
11318 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11319
85f24f61
PE
11320 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11321 All uses changed.
11322 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11323 Rename locals to avoid shadowing.
5671df8f 11324 (Fvertical_motion): Mark locals as initialized.
85f24f61 11325
181aa2be 11326 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11327 (casify_region): Mark local as initialized.
181aa2be 11328
930d429c
PE
11329 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11330
7082eac6
PE
11331 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11332 New macros, so that the caller can use some names other than
11333 gcpro1, gcpro2, etc.
11334 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11335 of the new macros.
11336 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11337 argument, for consistency with GCPRO2_VAR, etc: it is now the
11338 prefix of the variable, not the variable itself. All uses
11339 changed.
38b2c076
PE
11340 * dired.c (directory_files_internal, file_name_completion):
11341 Rename locals to avoid shadowing.
11342
15206ed9
PE
11343 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11344 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11345 dired.c's scmp function, had undefined behavior.
11346 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11347 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11348 * buffer.h: ... to here, because these macros use current_buffer,
11349 and the new implementation with inline functions needs to have
11350 current_buffer in scope now, rather than later when the macros
11351 are used.
11352 (downcase, upcase1): New static inline functions.
11353 (DOWNCASE, UPCASE1): Reimplement using these functions.
11354 This avoids undefined behavior in expressions like
11355 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11356 from race conditions in accessing the global variables
11357 case_temp1 and case_temp2.
11358 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11359 * lisp.h (case_temp1, case_temp2): Remove their decls.
11360 * character.h (ASCII_CHAR_P): Move from here ...
11361 * lisp.h: ... to here, so that the inline functions mentioned
11362 above can use them.
11363
4a6bea26
PE
11364 * dired.c (directory_files_internal_unwind): Now static.
11365
f14b7e14
PE
11366 * fileio.c (file_name_as_directory, directory_file_name):
11367 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11368 Now static.
2893f146
PE
11369 (file_name_as_directory): Use const pointers when appropriate.
11370 (Fexpand_file_name): Likewise. In particular, newdir might
11371 point at constant storage, so make it a const pointer.
fd4ead52 11372 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11373 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11374 signedness issues.
f839df0c
PE
11375 (Fset_file_times, Finsert_file_contents, auto_save_error):
11376 Rename locals to avoid shadowing.
f14b7e14 11377
5716756e 11378 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11379 (Ftry_completion, Fall_completions): Rename or remove locals
11380 to avoid shadowing.
5716756e 11381
b4c3046a
PE
11382 * marker.c (bytepos_to_charpos): Remove; unused.
11383
b45db522
PE
11384 * lisp.h (verify_bytepos, count_markers): New decls,
11385 so that gcc does not warn that these functions aren't declared.
11386
85876d07
PE
11387 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11388 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11389 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11390 (copy_text): Remove unused local var.
85876d07 11391
03d78a21 11392 * filelock.c (within_one_second): Now static.
b3dd38ab 11393 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11394
5df8f01b
PE
11395 * buffer.c (fix_overlays_before): Mark locals as initialized.
11396 (fix_start_end_in_overlays): Likewise. This function should be
11397 simplified by using pointers-to-pointers, but that's a different
11398 matter.
b1d876f1 11399 (switch_to_buffer_1): Now static.
8f54f30a
PE
11400 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11401 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11402
a70072c9 11403 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11404 Fix pointer signedness issue.
edced198
PE
11405 (sys_subshell): Mark local as volatile if checking for lint,
11406 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11407 (MAXPATHLEN): Define only if needed.
a70072c9 11408
a0977c44
PE
11409 * process.c (serial_open, serial_configure): Move decls from here ...
11410 * systty.h: ... to here, so that they can be checked.
11411
a884fdcc
PE
11412 * fns.c (get_random, seed_random): Move extern decls from here ...
11413 * lisp.h: ... to here, so that they can be checked.
11414
604efe86 11415 * sysdep.c (reset_io): Now static.
b8950c94 11416 (wait_for_termination_signal): Remove; unused.
604efe86 11417
38fc62d9
PE
11418 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11419 (copy_keymap_item, append_key, push_text_char_description):
11420 Now static.
1004a21a 11421 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11422 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11423 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11424 (describe_map_tree):
11425 Rename locals to avoid shadowing.
38fc62d9 11426
2f2650da
PE
11427 * keyboard.c: Declare functions static if they are not used elsewhere.
11428 (echo_char, echo_dash, cmd_error, top_level_2):
11429 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11430 (read_char, kbd_buffer_get_event, make_lispy_position):
11431 (make_lispy_event, make_lispy_movement, apply_modifiers):
11432 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11433 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11434 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11435 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11436 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11437
a053e86c 11438 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11439 (mark_kboards): Move decl here ...
11440 * alloc.c (mark_kboards): ... from here.
a053e86c 11441
4752793e
PE
11442 * lisp.h (force_auto_save_soon): New decl.
11443
74f10ca7 11444 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11445 (DEFINE_DUMMY_FUNCTION): New macro.
11446 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11447 Use it.
c03cd23f
PE
11448 (main): Add casts to avoid warnings
11449 if GCC considers string literals to be constants.
74f10ca7 11450
022e70d4
PE
11451 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11452
59d6fe83
PE
11453 * dbusbind.c: Pointer signedness fixes.
11454 (xd_signature, xd_append_arg, xd_initialize):
11455 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11456 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11457 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11458 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11459
78320123
PE
11460 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11461 if GCC considers string literals to be constants.
49cebcca 11462 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11463
35ac2a97
SM
114642011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11465
fb103ca9
SM
11466 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11467 (print_preprocess, print_object): New macro to fix last change.
11468
35ac2a97
SM
11469 * print.c (print_preprocess): Don't forget font objects.
11470
62973b41
JB
114712011-03-16 Juanma Barranquero <lekktu@gmail.com>
11472
11473 * emacs.c (USAGE3): Doc fixes.
11474
0e48bb22
AS
114752011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11476
11477 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11478 structure.
11479
7684e57b
JB
114802011-03-14 Juanma Barranquero <lekktu@gmail.com>
11481
11482 * lisp.h (VWindow_system, Qfile_name_history):
11483 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11484 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11485 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11486
11487 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11488 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11489
11490 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11491 * w32console.c (detect_input_pending, read_input_pending)
11492 (encode_terminal_code):
11493 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11494 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11495 (w32_system_caret_y, Qfile_name_history):
11496 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11497 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11498 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11499 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11500 * w32proc.c (Qlocal, report_file_error):
11501 * w32term.c (Vwindow_system, updating_frame):
11502 * w32uniscribe.c (initialized, uniscribe_font_driver):
11503 Remove unneeded extern declarations.
11504
2aa46d6c
CY
115052011-03-14 Chong Yidong <cyd@stupidchicken.com>
11506
c96bbc66 11507 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11508
cffc6f3b
CY
115092011-03-13 Chong Yidong <cyd@stupidchicken.com>
11510
11511 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11512 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11513 These macros can no longer be used for assignment.
11514
44f230aa
SM
11515 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11516 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11517 (record_buffer_markers, fetch_buffer_markers): New functions for
11518 recording and fetching special buffer markers.
11519 (set_buffer_internal_1, set_buffer_temp): Use them.
11520
11521 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11522
11523 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11524
11525 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11526 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11527
11528 * xdisp.c (hscroll_window_tree):
11529 (reconsider_clip_changes): Use PT instead of BUF_PT.
11530
d251f04b
EZ
115312011-03-13 Eli Zaretskii <eliz@gnu.org>
11532
11533 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11534 $(EMACS_ROOT)/lib/intprops.h.
11535
f0c77cd1
PE
115362011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11537
3eca4629
PE
11538 Fix more problems found by GCC 4.5.2's static checks.
11539
7c86ee98
PE
11540 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11541 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11542 (xg_free_frame_widgets): Make it clear that a local variable is
11543 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11544 (gdk_window_get_screen): Make it clear that this macro is needed
11545 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11546 (int_gtk_range_get_value): New function, which avoids a diagnostic
11547 from gcc -Wbad-function-cast.
11548 (xg_set_toolkit_scroll_bar_thumb): Use it.
11549 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11550 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11551 (get_utf8_string, xg_get_file_with_chooser):
11552 Rename locals to avoid shadowing.
11553 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11554
41729b81
PE
11555 * xgselect.c (xg_select): Remove unused var.
11556
f0c77cd1
PE
11557 * image.c (four_corners_best): Mark locals as initialized.
11558 (gif_load): Initialize transparent_p to zero (Bug#8238).
11559 Mark another local as initialized.
ec6cf4c6 11560 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11561
ce0ad53d 11562 * image.c (clear_image_cache): Now static.
d5d5a617 11563 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11564 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11565 (x_edge_detection): Remove unnecessary cast that
11566 gcc -Wbad-function-cast diagnoses.
2037898d 11567 (gif_load): Fix pointer signedness.
6ae141d6
PE
11568 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11569 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11570
33383987 115712011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11572
d32df629
PE
11573 Improve quality of tests for time stamp overflow.
11574 For example, without this patch (encode-time 0 0 0 1 1
11575 1152921504606846976) returns the obviously-bogus value (-948597
11576 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11577 reports time overflow. See
11578 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11579 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11580 * editfns.c: Include limits.h and intprops.h.
11581 (TIME_T_MIN, TIME_T_MAX): New macros.
11582 (time_overflow): Move earlier, to before first use.
11583 (hi_time, lo_time): New functions, for an accurate test for
11584 out-of-range times.
11585 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11586 (Fget_internal_run_time): Don't assume time_t fits in int.
11587 (make_time): Use list2 instead of Fcons twice.
11588 (Fdecode_time): More accurate test for out-of-range times.
11589 (check_tm_member): New function.
11590 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11591 (lisp_time_argument): Don't rely on undefined left-shift and
11592 right-shift behavior when checking for time stamp overflow.
8be6f318 11593
fe31d94c
PE
11594 * editfns.c (time_overflow): New function, refactoring common code.
11595 (Fformat_time_string, Fdecode_time, Fencode_time):
11596 (Fcurrent_time_string): Use it.
11597
8be6f318
PE
11598 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11599 * dired.c (make_time): Move to ...
11600 * editfns.c (make_time): ... here.
11601 * systime.h: Note the move.
11602
09d9db2c 116032011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11604
126bc0dc
YM
11605 * fringe.c (update_window_fringes): Remove unused variables.
11606
c47cbdfd
YM
11607 * unexmacosx.c (copy_data_segment): Also copy __got section.
11608 (Bug#8223)
11609
7ac80be9
EZ
116102011-03-12 Eli Zaretskii <eliz@gnu.org>
11611
c96bbc66 11612 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11613 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11614 Constify `char *' arguments and their references according to
11615 prototypes in tparam.h.
11616
ecb0f94d 11617 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11618
7ac80be9
EZ
11619 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11620 Adapt all references accordingly.
11621
11622 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11623
ef1fd07e
TT
116242011-03-11 Tom Tromey <tromey@redhat.com>
11625
11626 * buffer.c (syms_of_buffer): Remove obsolete comment.
11627
7ef4b50c
EZ
116282011-03-11 Eli Zaretskii <eliz@gnu.org>
11629
11630 * termhooks.h (encode_terminal_code): Declare prototype.
11631
11632 * msdos.c (encode_terminal_code): Don't declare prototype.
11633
11634 * term.c (encode_terminal_code): Now external again, used by
11635 w32console.c and msdos.c.
11636
44f230aa
SM
11637 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11638 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11639
4b1ec863 116402011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11641
1714f52b 11642 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11643
4b1ec863
PE
11644 * fringe.c (update_window_fringes): Mark locals as initialized
11645 (Bug#8227).
11646 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11647
524c7aa6
PE
11648 * alloc.c (mark_fringe_data): Move decl from here ...
11649 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11650 to check its interface.
11651 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11652
a5c0af81 11653 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11654 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11655 (fontset_font): Mark local as initialized.
a9a06e0b 11656 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11657
b4716021
PE
11658 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11659
811e9bac 11660 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11661 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11662 (x_own_selection, Fx_disown_selection_internal): Rename locals
11663 to avoid shadowing.
11664 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11665
7e3ab302
PE
11666 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11667 so that the caller can use some name other than gcpro1.
11668 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11669 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11670 (Fx_backspace_delete_keys_p):
11671 Use them to avoid shadowing, and rename vars to avoid shadowing.
11672 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11673 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11674 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11675 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11676 Remove unused locals.
7e3ab302
PE
11677 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11678 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11679 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11680 macros.
f78faa98 11681
e2b13473
PE
11682 * xterm.h (x_mouse_leave): New decl.
11683
77f23912
PE
11684 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11685 Remove unused functions.
cdf4ba58
PE
11686 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11687 (x_calc_absolute_position): Now static.
7411c686 11688 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11689 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11690 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11691 unless they are used.
38d0b34a
PE
11692 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11693 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11694 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11695 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11696 (x_error_catcher, x_connection_closed, x_error_handler):
11697 (x_error_quitter, xembed_send_message, x_iconify_frame):
11698 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11699 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11700 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11701
44f230aa
SM
11702 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11703 Rename or move locals to avoid shadowing.
6b463e58 11704 (tty_defined_color, merge_face_heights): Now static.
5967d051 11705 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11706 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11707 does not deduce is never used uninitialized.
73719eba
PE
11708 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11709 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11710
426994c3 11711 * terminal.c (store_terminal_param): Now static.
5489860b 11712
032f1620 11713 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11714 (set_frame_menubar): Remove unused local.
d4323972 11715 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11716 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11717 since they might point to immutable storage.
281585b0
PE
11718 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11719 since it's unused otherwise.
032f1620 11720
367c19e5 11721 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11722 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11723 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11724 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11725 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11726 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11727 does not deduce are never used uninitialized.
70739cbe 11728
07b48fa9
PE
11729 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11730
8868a238 11731 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11732 * window.c (window_loop, size_window):
11733 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11734
7e5cf297 11735 * window.c (display_buffer): Now static.
d6550a9f
PE
11736 (size_window): Mark variables that gcc -Wuninitialized
11737 does not deduce are never used uninitialized.
a586633d
PE
11738 * window.h (check_all_windows): New decl, to forestall
11739 gcc -Wmissing-prototypes diagnostic.
5b555da1 11740 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11741
f6095868
PE
11742 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11743 shadowing.
11744 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11745 Include <limits.h>.
11746 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11747 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11748 (load_charset_map): Mark variables that gcc -Wuninitialized
11749 does not deduce are never used uninitialized.
53df7c11 11750 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11751
f38b440c
PE
11752 * coding.c (coding_set_source, coding_set_destination):
11753 Use "else { /* comment */ }" rather than "else /* comment */;"
11754 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11755 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11756 a block, when the outer 'i' will do.
11757 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11758 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11759 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11760 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11761 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11762 Rename locals to avoid shadowing.
11763 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11764 * coding.c (emacs_mule_char, encode_invocation_designation):
11765 Now static, since they're not used elsewhere.
413bb2db 11766 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11767 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11768 (decode_coding_emacs_mule): Mark variables that gcc
11769 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11770 (detect_coding_iso_2022): Initialize a local variable that might
11771 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11772 this initialization is needed. (Bug#8211)
5f58e762
PE
11773 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11774 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11775 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11776 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11777 Remove unused macros.
f38b440c 11778
232b38b9 11779 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11780 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11781 * character.c (string_count_byte8): Likewise.
232b38b9 11782
fb90da1b
PE
11783 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11784 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11785
fb93dbc2
PE
11786 * chartab.c (copy_sub_char_table): Now static, since it's not used
11787 elsewhere.
5c156ace
PE
11788 (sub_char_table_ref_and_range, char_table_ref_and_range):
11789 Rename locals to avoid shadowing.
bbcd0949 11790 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11791
7d3b3862 11792 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11793 (BIDI_BOB): Remove unused macro.
7d3b3862 11794
6be7d3da
PE
11795 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11796 deduce are never used uninitialized.
c2ed9c8b 11797 * term.c (encode_terminal_code): Likewise.
6be7d3da 11798
75f8807f 11799 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11800
50938595
PE
11801 * tparam.h: New file.
11802 * term.c, tparam.h: Include it.
11803 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11804 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11805 Move these decls to tparam.h, and make them agree with what
11806 is actually in tparam.c. The previous trick of using incompatible
11807 decls in different modules does not conform to the C standard.
11808 All callers of tparam changed to use tparam's actual API.
11809 * tparam.c (tparam1, tparam, tgoto):
11810 Use const pointers where appropriate.
11811
fbceeba2
PE
11812 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11813 * cm.h (struct cm): Likewise.
11814 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11815 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11816 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11817 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11818 (turn_on_face, init_tty): Likewise.
11819 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11820
7f3f1250
PE
11821 * term.c (term_mouse_position): Rename local to avoid shadowing.
11822
e6ca6543
PE
11823 * alloc.c (mark_ttys): Move decl from here ...
11824 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11825
c40f8d15
AS
118262011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11827
11828 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11829
cfe0661d
JB
118302011-03-09 Juanma Barranquero <lekktu@gmail.com>
11831
11832 * search.c (compile_pattern_1): Remove argument regp, unused since
11833 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11834 (compile_pattern): Don't pass it.
11835
0afb4571
J
118362011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11837
11838 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11839 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11840 for ! HAVE_GTK3.
11841 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11842
11843 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11844
11845 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11846 gdk_window_get_screen, gdk_window_get_geometry,
11847 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11848 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11849 (xg_get_pixbuf_from_pixmap): New function.
11850 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11851 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11852 Call xg_get_pixbuf_from_pixmap instead of
11853 gdk_pixbuf_get_from_drawable.
11854 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11855 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11856 (xg_check_special_colors): Use GtkStyleContext and its functions
11857 for HAVE_GTK3.
11858 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11859 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11860 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11861 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11862 Call gtk_widget_get_preferred_size.
0afb4571
J
11863 (xg_frame_resized): gdk_window_get_geometry only takes 5
11864 parameters.
44f230aa
SM
11865 (xg_win_to_widget, xg_event_is_for_menubar):
11866 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11867 (xg_set_widget_bg): New function.
11868 (delete_cb): New function.
895009e1 11869 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11870 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11871 (xg_set_background_color): Call xg_set_widget_bg.
11872 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11873 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11874 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11875 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11876 if ! HAVE_GTK3.
11877 (update_frame_tool_bar): Call gtk_widget_hide.
11878 (xg_initialize): Use GDK_KEY_g.
11879
11880 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11881 if ! HAVE_GTK3
11882 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11883
11884 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11885 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11886 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11887
1c2cc4ef
JB
118882011-03-08 Juanma Barranquero <lekktu@gmail.com>
11889
11890 * w32xfns.c (select_palette): Check success of RealizePalette against
11891 GDI_ERROR, not zero.
11892
33383987 11893See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11894
11895;; Local Variables:
11896;; coding: utf-8
aac0c6e3
MR
11897;; End:
11898
2f097256 11899 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11900
11901 This file is part of GNU Emacs.
11902
11903 GNU Emacs is free software: you can redistribute it and/or modify
11904 it under the terms of the GNU General Public License as published by
11905 the Free Software Foundation, either version 3 of the License, or
11906 (at your option) any later version.
11907
11908 GNU Emacs is distributed in the hope that it will be useful,
11909 but WITHOUT ANY WARRANTY; without even the implied warranty of
11910 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11911 GNU General Public License for more details.
11912
11913 You should have received a copy of the GNU General Public License
11914 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.