Port --enable-checking=all to Fedora 14 x86.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
cb993c58
PE
12011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2
3 Port --enable-checking=all to Fedora 14 x86.
4 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5 Move to lisp.h.
6 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7 (overrun_check_realloc, overrun_check_free):
8 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
9 That way, xmalloc returns a properly-aligned pointer even if
10 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
11 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
12 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
13 into account when calculating the initial malloc maximum.
14 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
15 Move here from alloc.c, so that charset.c can use it too.
16 Properly align; the old code wasn't right for common 32-bit hosts
17 when configured with --enable-checking=all.
18 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
19 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
20
31bed486
EZ
212011-09-29 Eli Zaretskii <eliz@gnu.org>
22
23 * sysdep.c (snprintf) [EOVERFLOW]: If EOVERFLOW is not defined,
24 use EDOM.
25
fbcaa2f3
EZ
262011-09-28 Eli Zaretskii <eliz@gnu.org>
27
28 * xdisp.c (compute_display_string_end): If there's no display
29 string at CHARPOS, return -1.
30
31 * bidi.c (bidi_fetch_char): When compute_display_string_end
32 returns a negative value, treat the character as a normal
33 character not covered by a display string. (Bug#9624)
34
a239d4e9
JB
352011-09-28 Juanma Barranquero <lekktu@gmail.com>
36
37 * lread.c (Fread_from_string): Fix typo in docstring.
38
88652fd5
EZ
392011-09-27 Eli Zaretskii <eliz@gnu.org>
40
41 * xdisp.c (handle_invisible_prop): If invisible text ends on a
42 newline, reseat the iterator instead of bidi-iterating there one
43 character at a time. (Bug#9610)
44 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
45 TO_CHARPOS if the bidi iterator is at base embedding level.
46
ed497dd4
AS
472011-09-27 Andreas Schwab <schwab@linux-m68k.org>
48
49 * lread.c (readevalloop): Use correct code for NBSP.
50 (read1): Likewise. (Bug#9608)
51
b2bf61aa
MA
522011-09-25 Michael Albinus <michael.albinus@gmx.de>
53
54 * dbusbind.c (Fdbus_register_signal): When service is not
55 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
56
32bbb17c
GM
572011-09-25 Glenn Morris <rgm@gnu.org>
58
59 * buffer.c (truncate-lines): Doc fix.
60
94e0933e
CY
612011-09-24 Chong Yidong <cyd@stupidchicken.com>
62
63 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
64 (Fset_window_next_buffers): Doc fix.
65
cddde921
GM
662011-09-24 Glenn Morris <rgm@gnu.org>
67
68 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
69
1260aef1
PE
702011-09-24 Paul Eggert <eggert@cs.ucla.edu>
71
25b4bfa0
PE
72 Fix minor problems found by static checking.
73 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
74 * indent.c (Fvertical_motion): Fix == vs = typo.
75
e3cbd34b
EZ
762011-09-24 Eli Zaretskii <eliz@gnu.org>
77
6bf7006f
EZ
78 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
79 value is now t. Doc fix.
80
e3cbd34b
EZ
81 * indent.c (Fvertical_motion): Compute and apply the overshoot
82 logic when moving up, not only when moving down. Fix the
83 confusing name and values of the it_overshoot_expected variable;
84 logic changes accordingly. (Bug#9254) (Bug#9549)
85
86 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
87 CHARPOS is covered by a display string which includes newlines.
88 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
89 is covered by a display string with embedded newlines.
90
a3de0cbd
MA
912011-09-24 Michael Albinus <michael.albinus@gmx.de>
92
93 * dbusbind.c (Fdbus_register_signal): Add match rule to
94 Vdbus_registered_objects_table. (Bug#9581)
95 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
96 docstring.
97
b260039d
JM
982011-09-24 Jim Meyering <meyering@redhat.com>
99
100 do not ignore write error for any output size
101 The previous change was incomplete.
102 While it makes emacs --batch detect the vast majority of stdout
103 write failures, errors were still ignored whenever the output size is
104 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
105 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
106 && echo FAIL: ignored write error
107 FAIL: ignored write error
108 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
109 && echo FAIL: ignored write error
110 FAIL: ignored write error
111 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
112
8eca8a7c
AS
1132011-09-23 Andreas Schwab <schwab@linux-m68k.org>
114
115 * emacs.c (Fkill_emacs): In noninteractive mode exit
116 non-successfully if a write error occurred on stdout. (Bug#9574)
117
3341db62
EZ
1182011-09-21 Eli Zaretskii <eliz@gnu.org>
119
120 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
121 the xassert test.
122
123 * dispextern.h (struct it): Update the comment documenting what
124 can it->OBJECT be.
125
8c203dbf
EZ
1262011-09-20 Eli Zaretskii <eliz@gnu.org>
127
128 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
129 a display string, extend search for cursor position to end of row.
130 (find_row_edges): If the row ends in a newline from a display
131 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
132 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
133 (Fcurrent_bidi_paragraph_direction): Fix search for previous
134 non-empty line. Fixes confusing cursor motion with arrow keys at
135 the beginning of a line that starts with whitespace.
8c203dbf 136
a4824228
LMI
1372011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
138
139 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
140 (bug#9493).
141
33ed493b
CY
1422011-09-18 Chong Yidong <cyd@stupidchicken.com>
143
144 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
145 boolean (Bug#9154).
146
56cd55c8
EZ
1472011-09-18 Eli Zaretskii <eliz@gnu.org>
148
149 * xdisp.c (display_line): Record maximum and minimum buffer
150 positions even if no glyphs were produced (e.g., by a zero-width
151 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
152 buffer positions that will be removed from the glyph row because
153 they don't fit.
c02dcedf
EZ
154 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
155 column is beyond frame width: don't subtract 1 "pixel" when
156 computing width of the stretch.
3e62b7e0
EZ
157 (reseat_at_next_visible_line_start): Undo the change made on
158 2011-09-17 that saved paragraph information and restored it after
159 the call to `reseat'. (Bug#9545)
56cd55c8 160
5ed99d36 1612011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
162
163 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
164 and turn window cursor on if cleared (Bug#9415).
165
5ed99d36 1662011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
167
168 * search.c (boyer_moore): Take unibyte characters from pattern
169 literally. (Bug#9458)
170
9bade7b2
EZ
1712011-09-18 Eli Zaretskii <eliz@gnu.org>
172
173 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
174
e5e9d610
PE
1752011-09-18 Paul Eggert <eggert@cs.ucla.edu>
176
87e4427a
PE
177 Fix minor problem found by static checking.
178 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
179 initialized, to pacify gcc -Wuninitialized.
180
e5e9d610
PE
181 * fileio.c: Report proper errno when syscall falls.
182 (Finsert_file_contents): Save and restore errno,
183 so that report_file_error outputs the correct diagnostic.
184 (Fwrite_region) [CLASH_DETECTION]: Likewise.
185
a1674f0b
EZ
1862011-09-18 Eli Zaretskii <eliz@gnu.org>
187
188 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
189
fbfb6dd4
EZ
1902011-09-17 Eli Zaretskii <eliz@gnu.org>
191
192 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
193 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
194
bb187662
EZ
1952011-09-17 Eli Zaretskii <eliz@gnu.org>
196
1137e8b8
EZ
197 * xdisp.c (reseat_at_next_visible_line_start): Keep information
198 about the current paragraph and restore it after the call to
199 reseat.
200
201 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
202 (bidi_find_paragraph_start): Search back for paragraph beginning
203 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
204 (bidi_move_to_visually_next): Only trigger paragraph-related
205 computations when the last character is a newline or at EOB, not
206 just any NEUTRAL_B. (Bug#9470)
207
bb187662
EZ
208 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
209 truncated lines if point is covered by a display string. (Bug#9524)
210
2e621251
PE
2112011-09-16 Paul Eggert <eggert@cs.ucla.edu>
212
213 * xselect.c: Relax test for outgoing X longs (Bug#9498).
214 (cons_to_x_long): New function.
215 (lisp_data_to_selection_data): Use it. Correct the test for
216 short-versus-long data; it was negated. Break out of vector
217 loop, for efficiency, when a long datum is discovered.
218
91a15bc6
SM
2192011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
220
221 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
222
b41c3a35
EZ
2232011-09-16 Eli Zaretskii <eliz@gnu.org>
224
225 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
226 GCC PR/17406) by declaring this function with external scope.
227
7812ba2d
PE
2282011-09-15 Paul Eggert <eggert@cs.ucla.edu>
229
230 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
231 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
232
cf7edc2a
AS
2332011-09-15 Andreas Schwab <schwab@linux-m68k.org>
234
235 * editfns.c (Fformat): Correctly handle text properties on "%%".
236
bd01620e
EZ
2372011-09-15 Eli Zaretskii <eliz@gnu.org>
238
239 * xterm.c (x_draw_composite_glyph_string_foreground):
240 * w32term.c (x_draw_composite_glyph_string_foreground):
241 * term.c (encode_terminal_code):
242 * composite.c (composition_update_it, get_composition_id):
243 * xdisp.c (get_next_display_element)
244 (fill_composite_glyph_string): Add comments about special meaning
245 of TAB characters in a composition.
246
a02719a3
PE
2472011-09-15 Paul Eggert <eggert@cs.ucla.edu>
248
249 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
250 This occurs when processing a multibyte format.
251 Problem reported by Wolfgang Jenker.
a02719a3 252
72589a3c
JB
2532011-09-15 Johan Bockgård <bojohan@gnu.org>
254
255 * xdisp.c (try_cursor_movement): Only check for exact match if
256 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
257
1c14176c
PE
2582011-09-14 Paul Eggert <eggert@cs.ucla.edu>
259
260 Remove unused external symbols.
261 * dispextern.h (calc_pixel_width_or_height): Remove decl.
262 * xdisp.c (calc_pixel_width_or_height): Now static.
263 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
264 * indent.c (check_display_width):
265 * w32term.c: Fix comment to match code.
266 * xterm.c, xterm.h (x_catching_errors): Remove.
267
d2eea5b5
PE
2682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
269
270 * xselect.c: Use signed conversions more consistently (Bug#9498).
271 (selection_data_to_lisp_data): Assume incoming selection data are
272 signed integers, not unsigned. This is to be consistent with
273 outgoing selection data, which was modified to use signed integers
274 in as part of the fix to Bug#9196 in response to Jan D.'s comment
275 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
276 expects long, not unsigned long.
277
46888499
EZ
2782011-09-14 Eli Zaretskii <eliz@gnu.org>
279
280 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
281 computation of loop end. Reported by Johan Bockgård
282 <bojohan@gnu.org>.
283
ef8ef9fb
CY
2842011-09-13 Chong Yidong <cyd@stupidchicken.com>
285
286 * frame.c (Fother_visible_frames_p): Function deleted.
287
fa819fed
EZ
2882011-09-12 Eli Zaretskii <eliz@gnu.org>
289
290 * indent.c (compute_motion): Process display vector front to back
291 rather than the other way around. (Bug#2496)
292
2ba8e008
SM
2932011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
294
295 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
296
20f53c69
CY
2972011-09-11 Chong Yidong <cyd@stupidchicken.com>
298
299 * minibuf.c (Fread_from_minibuffer): Doc fix.
300
d562d7a4
EZ
3012011-09-11 Eli Zaretskii <eliz@gnu.org>
302
303 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
304 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
305
1c4d7f3d
LMI
3062011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
307
308 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
309 value for non-existent files.
310
b885bf36
EZ
3112011-09-11 Eli Zaretskii <eliz@gnu.org>
312
313 * fileio.c (Finsert_file_contents): If the file cannot be opened,
314 set its "size" to -1. This will set the modtime_size field of
315 the corresponding buffer to -1, which is what
316 verify-visited-file-modtime expects for files that do not exist.
317 (Bug#9139)
318
6612f0bf
PE
3192011-09-11 Paul Eggert <eggert@cs.ucla.edu>
320
321 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
322 here ...
323 * lisp.h: ... from here. push_key_description is no longer
324 defined in keyboard.c, so its declaration should not be in
325 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
326 logically belongs with push_key_description.
327
dfb3f755
PE
3282011-09-10 Paul Eggert <eggert@cs.ucla.edu>
329
330 * buffer.h: Include <sys/types.h> instead of <time.h>.
331 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
332 Problem reported by Herbert J. Skuhra.
333
3134906c
LMI
3342011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
335
336 * xml.c (parse_region): Make the parsing work for
337 non-comment-starting XML files again (bug#9144).
338
8d903f4e
AS
3392011-09-10 Andreas Schwab <schwab@linux-m68k.org>
340
341 * image.c (gif_load): Fix calculation of bottom and right corner.
342 (Bug#9468)
343
80ad64f4
EZ
3442011-09-10 Eli Zaretskii <eliz@gnu.org>
345
346 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
347 redisplay in small windows.
348
208a048d
EZ
3492011-09-09 Eli Zaretskii <eliz@gnu.org>
350
351 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
352
9b1c252e
MR
3532011-09-08 Martin Rudalics <rudalics@gmx.at>
354
355 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
356 Operate on live windows only.
357
2949f33b
JB
3582011-09-08 Juanma Barranquero <lekktu@gmail.com>
359
360 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
361
e08dcafd
EZ
3622011-09-07 Eli Zaretskii <eliz@gnu.org>
363
364 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
365 only under bidi iteration.
366
115b96bd
JD
3672011-09-07 Jan Djärv <jan.h.d@swipnet.se>
368
369 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
370
c8199d0f
PE
3712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
372
373 isnan: Fix porting problem to Solaris 10 with bundled gcc.
374 Without this fix, the command to link temacs failed due to an
375 undefined symbol __builtin_isnan. This is because
376 /usr/include/iso/math_c99.h #defines isnan(x) to
377 __builtin_isnan(x), but the bundled gcc, which identifies itself
378 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
379 a __builtin_isnan.
380 * floatfns.c (isnan): #undef, and then #define to a clone of
381 what's in data.c.
382 (Fisnan): Always define, since it's always available now.
383 (syms_of_floatfns): Always define isnan at the Lisp level.
384
e39b275c 3852011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
386
387 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
388
b2db44d9 3892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 390
f4af5137 391 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
392 The previous code assumed that file offsets (off_t values) fit in
393 EMACS_INT variables, which is not true on typical 32-bit hosts.
394 The code messed up by falsely reporting buffer overflow in cases
395 such as (insert-file-contents "big" nil 1 2) into an empty buffer
396 when "big" contains more than 2**29 bytes, even though this
397 inserts just one byte and does not overflow the buffer.
398 (Finsert_file_contents): Store file offsets as off_t
399 values, not as EMACS_INT values. Check for overflow when
400 converting between EMACS_INT and off_t. When checking for
401 buffer overflow or for overlap, take the offsets into account.
402 Don't use EMACS_INT for small values where int suffices.
403 When checking for overlap, fix a typo: ZV was used where
404 ZV_BYTE was intended.
405 (Fwrite_region): Don't assume off_t fits into 'long'.
406 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
407
ecfc0a49
MA
4082011-09-05 Michael Albinus <michael.albinus@gmx.de>
409
410 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
411
6511acf2 4122011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 413
0999621a 414 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
415
416 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 417 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
418 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
419 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
420 (modify_event_symbol): Do not assume that the length of
421 name_alist_or_stem is safe to alloca and fits in int.
422 (Fexecute_extended_command): Likewise for function name and binding.
423 (Frecursion_depth): Wrap around reliably on integer overflow.
424 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
425 since some callers pass EMACS_INT values.
426 (Fsingle_key_description): Don't crash if symbol name contains more
427 than MAX_ALLOCA bytes.
428 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
429 (get_minibuffer): Arg is now EMACS_INT, not int.
430 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 431 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
432 * window.h (command_loop_level, minibuf_level): Reflect API changes.
433
2be7d702
PE
434 * dbusbind.c (signature_cat): New function.
435 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
436 Do not overrun buffer; instead, report string overflow.
437
9d1df220
PE
438 * dispnew.c (add_window_display_history): Don't overrun buffer.
439 Truncate instead; this is OK since it's just a log.
440
33ef5c64
PE
441 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
442 even if the time zone offset is outlandishly large.
443 Don't mishandle offset == INT_MIN.
444
66c6fdd5
PE
445 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
446 when creating daemon; the previous buffer-overflow check was incorrect.
447
d749b01b
PE
448 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
449 which has the guts of the old verror function.
450
b5cd1905
PE
451 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
452 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
453
6e1a67fb
PE
454 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
455 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 456 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 457 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
458 length of string rather than counting it via multiple sprintfs;
459 that's simpler and more reliable.
c21721cc
PE
460 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
461 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
462 sprintf, in case result does not fit in int.
463
c57b67fc
PE
464 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
465 (fontset_from_font): Print it.
466
8a401434
PE
467 * frame.c (tty_frame_count): Now printmax_t, not int.
468 (make_terminal_frame, set_term_frame_name): Print it.
469 (x_report_frame_params): In X, window IDs are unsigned long,
470 not signed long, so print them as unsigned.
471 (validate_x_resource_name): Check for implausibly long names,
472 and don't assume name length fits in 'int'.
473 (x_get_resource_string): Don't blindly alloca invocation name;
474 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
475 not fit in int.
476
6e1a67fb
PE
477 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
478 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
479 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
480
0df02bf3
PE
481 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
482 Use esprintf, not sprintf, in case result does not fit in int.
483
48e30793
PE
484 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
485 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
486 it as a large positive number.
487 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
488 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
489
a66ff6d8
PE
490 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
491 in case result does not fit in int.
492
aca216ff
PE
493 * print.c (float_to_string): Detect width overflow more reliably.
494 (print_object): Make sprintf buffer a bit bigger, to avoid potential
495 buffer overrun. Don't assume list length fits in 'int'. Treat
496 print length of 0 as 0, not as infinity; to be consistent with other
497 uses of print length in this function. Don't overflow print length
498 index. Don't assume hash table size fits in 'long', or that
499 vectorlike size fits in 'unsigned long'.
500
31c286f7
PE
501 * process.c (make_process): Use printmax_t, not int, to format
502 process-name gensyms.
503
55e5faa1
PE
504 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
505
80f2e268
PE
506 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
507 to avoid potential buffer overrun.
508
670741ab
PE
509 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
510 if X resource line is longer than 512 bytes.
511
b7163a50
PE
512 * xfns.c (x_window): Make sprintf buffer a bit bigger
513 to avoid potential buffer overrun.
514
ae58ff1f
PE
515 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
516
c43c8a6a
PE
517 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
518
3f8236f4
PE
5192011-09-04 Paul Eggert <eggert@cs.ucla.edu>
520
53e9fe90 521 Integer overflow fixes for scrolling, etc.
6511acf2
PE
522 Without these, Emacs silently mishandles large integers sometimes.
523 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
524 it were "C-u 1 M-x recenter" on a typical 64-bit host.
525
6511acf2
PE
526 * xdisp.c (try_window_id): Check Emacs fixnum range before
527 converting to 'int'.
806add1d 528
6511acf2 529 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
530 Check that an Emacs fixnum is in range before assigning it to 'int'.
531 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
532 values converted from Emacs fixnums.
533 (Frecenter): Don't wrap around a line count if it is out of 'int'
534 range; instead, treat it as an extreme value.
535 (Fset_window_configuration, compare_window_configurations):
536 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
537
6511acf2
PE
538 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
539 that can exceed INT_MAX. Check that EMACS_INT value is in range
540 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
541 (match_limit): Don't assume that a fixnum can fit in 'int'.
542
6511acf2 543 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
544 exceed INT_MAX.
545
6511acf2 546 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
547 (Fvertical_motion): Don't wrap around LINES values that don't fit
548 in 'int'. Instead, treat them as extreme values. This is good
549 enough for windows, which can't have more than INT_MAX lines anyway.
550
fcb901a7
LMI
5512011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
552
0f2f6b6d
LMI
553 * Require libxml/parser.h to avoid compilation warning.
554
fcb901a7
LMI
555 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
556
557 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
558 since this reportedly can destroy thread storage.
559
6e20a0d4
CY
5602011-08-30 Chong Yidong <cyd@stupidchicken.com>
561
562 * syntax.c (find_defun_start): Update all cache variables if
563 exiting early (Bug#9401).
564
148ae00e
EZ
5652011-08-30 Eli Zaretskii <eliz@gnu.org>
566
f6cfbd8f
EZ
567 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
568
148ae00e
EZ
569 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
570 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
571 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
572
573 * term.c (tty_append_glyph): New function.
574 (produce_stretch_glyph): Static function and its prototype deleted.
575
576 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
577 prototypes.
578
c4a07a4c
PE
5792011-08-29 Paul Eggert <eggert@cs.ucla.edu>
580
581 * image.c (parse_image_spec): Check for nonnegative, not for positive,
582 when checking :margin (Bug#9390).
583 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
584 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
585 so that the name doesn't mislead. All uses changed.
586
6bc8cd65
JB
5872011-08-28 Johan Bockgård <bojohan@gnu.org>
588
589 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
590 set_tty_hooks.
591
dca4927e
EZ
5922011-08-27 Eli Zaretskii <eliz@gnu.org>
593
594 * xdisp.c (move_it_to): Don't bail out early when reaching
595 position beyond to_charpos, if we are scanning backwards.
596 (move_it_vertically_backward): When DY == 0, make sure we get to
597 the first character in the line after the newline.
598
f2cad773
PE
5992011-08-27 Paul Eggert <eggert@cs.ucla.edu>
600
601 * ccl.c: Improve and simplify overflow checking (Bug#9196).
602 (ccl_driver): Do not generate an out-of-range pointer.
603 (Fccl_execute_on_string): Remove unnecessary check for
604 integer overflow, noted by Stefan Monnier in
605 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
606 Remove a FIXME that didn't need fixing.
607 Simplify the newly-introduced buffer reallocation code.
608
0cae2cdb
JB
6092011-08-27 Juanma Barranquero <lekktu@gmail.com>
610
611 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
612
5fc295a4 6132011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 614
70c60eb2 615 Integer and memory overflow issues (Bug#9196).
726e0ab1 616
d31850da
PE
617 * doc.c (get_doc_string): Rework so that
618 get_doc_string_buffer_size is the actual buffer size, rather than
619 being 1 less than the actual buffer size; this makes xpalloc more
620 convenient.
621
a69fbedb
PE
622 * image.c (x_allocate_bitmap_record, cache_image):
623 * xselect.c (Fx_register_dnd_atom):
624 Simplify previous changes by using xpalloc.
625
fe5c5d37
PE
626 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
627 since either will do and ptrdiff_t is convenient with xpalloc.
628
0065d054
PE
629 * charset.c (charset_table_size)
630 (struct charset_sort_data.priority): Now ptrdiff_t.
631 (charset_compare): Don't overflow if priorities differ greatly.
632 (Fsort_charsets): Don't assume list length fits in int.
633 Check for size-calculation overflow when allocating sort data.
634 (syms_of_charset): Allocate an initial charset table that is
635 just under 64 KiB, to avoid problems with glibc malloc and mmap.
636
637 * cmds.c (internal_self_insert): Check for size-calculation overflow.
638
639 * composite.h (struct composition.glyph_len): Now int, not unsigned.
640 The actual value is always <= INT_MAX, and leaving it unsigned made
641 overflow checking harder.
642
643 * dispextern.h (struct glyph_matrix.rows_allocated)
644 (struct face_cache.size): Now ptrdiff_t, for convenience in use
645 with xpalloc. The values are still always <= INT_MAX.
646
647 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
648
649 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
650 (SAFE_NALLOCA): New macro.
651
652 * region-cache.c (struct boundary.pos, find_cache_boundary)
653 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
654 (set_cache_region, invalidate_region_cache)
655 (revalidate_region_cache, know_region_cache, region_cache_forward)
656 (region_cache_backward, pp_cache):
657 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
658 so that ptrdiff_t * can be passed to xpalloc.
659 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
660 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
661 (pp_cache): Don't assume cache_len fits in int.
662 * region-cache.h: Adjust extern decls to match.
663
664 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
665 EMACS_INT, since either will do, for xpalloc.
666
667 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
668 (xnmalloc, xnrealloc, xpalloc): New functions.
669
726e0ab1
PE
670 * bidi.c (bidi_shelve_header_size): New constant.
671 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
672 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
673
51f30bc5 674 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
675 * buffer.c (overlays_at, overlays_in, record_overlay_string)
676 (overlay_strings):
677 Don't update size of array until after memory allocation succeeds,
678 because xmalloc/xrealloc may not return.
0065d054
PE
679 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
680 now that we have proper integer overflow checking.
681 (record_overlay_string, overlay_strings): Catch overflows when
682 calculating size of overlay_str_buf.
726e0ab1 683
0065d054
PE
684 * callproc.c (Fcall_process): Check for size overflow when
685 calculating size of args2.
686 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
687 Normally we prefer signed values, but sticking with ptrdiff_t would
688 require adding more-complicated checks.
726e0ab1
PE
689
690 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
691 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
692 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 693 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
694
695 * character.c (Fstring): Check for size-calculation overflow.
696
697 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
698 unnecessary integer overflow. Check for size overflow.
699 (encode_coding_object): Don't update size until xmalloc succeeds.
700
701 * composite.c (get_composition_id): Check for overflow in glyph
702 length calculations.
703
704 Integer and memory overflow fixes for display code.
705 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
706 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
707 (scrolling_window): Check for overflow in size calculations.
708 (line_draw_cost, realloc_glyph_pool, add_row_entry):
709 Don't assume glyph table len fits in int.
710 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
711 (row_table_size): Now ptrdiff_t, not int.
712 (scrolling_window): Avoid overflow in size calculations.
713 Don't update size until allocation succeeds.
714 * fns.c (concat): Check for overflow in size calculations.
715 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
716 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
717 (NEXT_ALMOST_PRIME_LIMIT): New constant.
718
719 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
720 (get_doc_string): Check for size calculation overflow.
721 Don't update size until allocation succeeds.
722 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
723 EMACS_INT, where ptrdiff_t will do.
724 (Fsubstitute_command_keys): Check for string overflow.
725
726 * editfns.c (set_time_zone_rule): Don't assume environment length
727 fits in int.
728 (message_length): Now ptrdiff_t, not int.
729 (Fmessage_box): Don't update size until allocation succeeds.
730 Don't assume message length fits in int.
731 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
732
0065d054
PE
733 * emacs.c (main): Do not reallocate argv, since there is a null at
734 the end that can be overwritten, and this way there's no need to
735 worry about size-calculation overflow.
736 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
737
738 * eval.c (init_eval_once, grow_specpdl): Don't update size until
739 alloc succeeds.
740 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
741
742 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
743 (x_set_scroll_bar_width, x_figure_window_size):
744 Check for integer overflow.
745 (x_set_alpha): Do not assume XINT fits in int.
746
747 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
748 This is for the members text_lines, text_cols, total_lines, total_cols,
749 where the system imposes an 'int' limit.
750
751 * fringe.c (Fdefine_fringe_bitmap):
752 Don't update size until alloc works.
753
754 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
755 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
756
757 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
758 Check for size-calculation overflow.
759 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
760 do, as we prefer signed integers.
761 (id_to_widget.max_size, id_to_widget.used)
762 (xg_store_widget_in_map, xg_remove_widget_from_map)
763 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
764 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
765 Use and return ptrdiff_t, not int.
766 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
767 * gtkutil.h: Change prototypes to match the above.
768
769 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
770 are duplicate now that they've been promoted to lisp.h.
771 (x_allocate_bitmap_record, x_alloc_image_color)
772 (make_image_cache, cache_image, xpm_load):
773 Don't update size until alloc is done.
774 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
775 (x_detect_edges):
3256efce 776 Check for size calculation overflow.
726e0ab1
PE
777 (ct_colors_allocated_max): New constant.
778 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
779 overflow.
3256efce 780
726e0ab1
PE
781 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
782 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
783 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
784 Use ptrdiff_t, not int, to count maps.
785 (read_char_minibuf_menu_prompt): Check for overflow in size
786 calculations. Don't update size until allocation succeeds. Redo
787 calculations to avoid overflow.
788 * keyboard.h: Change prototypes to match the above.
789
790 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
791 to count maps.
792 (current_minor_maps): Check for size calculation overflow.
793 * keymap.h: Change prototypes to match the above.
794
795 * lread.c (read1, init_obarray): Don't update size until alloc done.
796
797 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
798 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
799
726e0ab1
PE
800 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
801 Now ptrdiff_t, not int.
802 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
803 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
804
805 * process.c (Fnetwork_interface_list): Check for overflow
806 in size calculation.
807
808 * region-cache.c (move_cache_gap): Check for size calculation overflow.
809
810 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
811 overflow. Don't bother calling xmalloc when xrealloc will do.
812
813 * search.c (Freplace_match): Check for size calculation overflow.
814 (Fset_match_data): Don't assume list lengths fit in 'int'.
815
816 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
817 for command line length. Do not attempt to address one before the
818 beginning of an array, as that's not portable.
819
820 * term.c (max_frame_lines): Remove; unused.
821 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
822 not int.
823 (encode_terminal_code, calculate_costs): Check for size
824 calculation overflow.
825 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
826 table lengths and related sizes. Don't update size until alloc
827 done. Redo calculations to avoid overflow.
828 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
829
830 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
831 subtracting pointers.
832 (gobble_line): Check for overflow more carefully. Don't update size
833 until alloc done.
834
835 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
836 Don't update size until alloc done.
837 Redo size calculations to avoid overflow.
838 Check for size calculation overflow.
0065d054 839 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
840
841 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
842 Use ptrdiff_t, not int, for sizes.
843 (store_mode_line_noprop_char): Don't update size until alloc done.
844
0065d054
PE
845 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
846 Use ptrdiff_t, not int, for sizes.
847 (Finternal_make_lisp_face, cache_face):
848 Check for size calculation overflow.
849 (cache_face): Treat size calculation overflows as if they were
850 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
851
852 * xfns.c (x_encode_text, x_set_name_internal)
853 (Fx_change_window_property): Use ptrdiff_t, not int, to count
854 sizes, since they can exceed INT_MAX in size. Check for size
855 calculation overflow.
856
0065d054
PE
857 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
858 (xg_select): Check for size calculation overflow.
726e0ab1
PE
859 Don't update size until alloc done.
860
0065d054 861 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 862 as sprintf is limited to int lengths.
1d526e2f 863
252c5ee1
PE
864 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
865 (X_LONG_MIN): New macros.
864d7ce7
PE
866 Use them to make the following changes clearer.
867 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
868 This change doesn't affect the value now, but it may help remind
869 future maintainers not to raise the value too much later.
870 (SELECTION_QUANTUM): Remove, replacing with ...
871 (selection_quantum): ... new function, which avoids overflow.
872 All uses changed.
873 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
874 assumption that selection length fits in 'int'.
875 (x_reply_selection_request, x_handle_selection_request)
876 (x_get_window_property, receive_incremental_selection)
877 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
878 (lisp_data_to_selection_data, clean_local_selection_data):
879 Use ptrdiff_t, not int, to record length of selection.
880 (x_reply_selection_request, x_get_window_property)
881 (receive_incremental_selection, x_property_data_to_lisp):
882 Redo calculations to avoid overflow.
883 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 884 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
885 something.
886 (x_get_window_property, receive_incremental_selection)
887 (lisp_data_to_selection_data, x_property_data_to_lisp):
888 Check for size-calculation overflow.
889 (x_get_window_property, receive_incremental_selection)
890 (lisp_data_to_selection_data, Fx_register_dnd_atom):
891 Don't store size until memory allocation succeeds.
892 (x_get_window_property): Plug memory leak on memory exhaustion.
893 Don't double-block input; malloc is safe here. Don't assume 2**34
894 - 4 fits in unsigned long. Add an xassert to check
895 XGetWindowProperty overflow. Be more careful about overflow
896 calculations, and distinguish size from memory overflow better.
897 (receive_incremental_selection): When tracing, don't assume
898 unsigned int is less than INT_MAX.
899 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
900 harmful) conversions of unsigned short to int.
901 (lisp_data_to_selection_data): Don't assume that integers
902 in the range -65535 through -1 fit in an X unsigned short.
903 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
904 result parameters unless successful. Rely on cons_to_unsigned
905 to report problems with elements; the old code wasn't right anyway.
906 (x_check_property_data): Check for int overflow; we cannot use
907 a wider type due to X limits.
908 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
909
726e0ab1 910 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 911
0065d054
PE
912 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
913 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
914 (x_color_cells): Don't store size until memory allocation succeeds.
915 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 916 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
917 (x_term_init): Don't assume length fits in int (sprintf is limited
918 to int size).
bc18e09d 919
ebfa62c0
PE
920 Use ptrdiff_t for composition IDs.
921 * character.c (lisp_string_width):
922 * composite.c (composition_table_size, n_compositions)
923 (get_composition_id, composition_gstring_from_id):
924 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
925 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
926 * window.c (Frecenter):
927 Use ptrdiff_t, not int, for composition IDs.
928 * composite.c (get_composition_id): Check for integer overflow.
929 * composite.h: Adjust prototypes to match the above changes.
930
d3411f89
PE
931 Use ptrdiff_t for hash table indexes.
932 * category.c (hash_get_category_set):
933 * ccl.c (ccl_driver):
934 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
935 * coding.c (coding_system_charset_list, detect_coding_system):
936 * coding.h (struct coding_system.id):
937 * composite.c (get_composition_id, gstring_lookup_cache):
938 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
939 * image.c (xpm_get_color_table_h):
940 * lisp.h (hash_lookup, hash_put):
941 * minibuf.c (Ftest_completion):
942 Use ptrdiff_t for hash table indexes, not int (which is too
943 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
944 32-bit --with-wide-int hosts).
945
e097a6fa
PE
946 * charset.c (Fdefine_charset_internal): Check for integer overflow.
947 Add a FIXME comment about memory leaks.
948 (syms_of_charset): Don't assume xmalloc returns.
949
5637687f
PE
950 Don't assume that stated character widths fit in int.
951 * character.c (Fchar_width, c_string_width, lisp_string_width):
952 * character.h (CHAR_WIDTH):
953 * indent.c (MULTIBYTE_BYTES_WIDTH):
954 Use sanitize_char_width to avoid undefined and/or bad behavior
955 with outlandish widths.
956 * character.h (sanitize_tab_width): Renamed from sanitize_width,
957 now that we have two such functions. All uses changed.
958 (sanitize_char_width): New inline function.
959
a2271ba2
PE
960 Don't assume that tab-width fits in int.
961 * character.h (sanitize_width): New inline function.
962 (SANE_TAB_WIDTH): New macro.
963 (ASCII_CHAR_WIDTH): Use it.
964 * indent.c (sane_tab_width): Remove. All uses replaced by
965 SANE_TAB_WIDTH (current_buffer).
966 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
967
18c52557
PE
968 * fileio.c: Integer overflow issues with file modes.
969 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
970
caeeedc1
PE
971 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
972 Remove unreachable code.
973 (read_hex, load_charset_map_from_file): Check for integer overflow.
974
50849c52
PE
975 * xterm.c: don't go over XClientMessageEvent limit
976 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
977 (x_send_scroll_bar_event): Likewise. Check that the size does not
978 exceed limits imposed by XClientMessageEvent, as well as the usual
979 ptrdiff_t and size_t limits.
980
b13995db
PE
981 * keyboard.c: Overflow, signedness and related fixes.
982 (make_lispy_movement): Use same integer type in forward decl
983 that is used in the definition.
984 (read_key_sequence, keyremap_step):
985 Change bufsize argument back to int, undoing my 2011-03-30 change.
986 We prefer signed types, and int is wide enough here.
987 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
988 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
989 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
990 length, not size_t. Use ptrdiff_t for index, not int.
991 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
992 possibility of integer overflow.
993
13464394
PE
994 Overflow, signedness and related fixes for images.
995
996 * dispextern.h (struct it.stack[0].u.image.image_id)
997 (struct_it.image_id, struct image.id, struct image_cache.size)
998 (struct image_cache.used, struct image_cache.ref_count):
999 * gtkutil.c (update_frame_tool_bar):
1000 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1001 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1002 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1003 * nsmenu.m (update_frame_tool_bar):
1004 * xdisp.c (calc_pixel_width_or_height):
1005 * xfns.c (image_cache_refcount):
1006 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1007 on typical 64-bit hosts.
1008
1009 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1010 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1011 Omit unnecessary casts to int.
1012 (parse_image_spec): Check that integers fall into 'int' range
1013 when the callers expect that.
1014 (image_ascent): Redo ascent calculation to avoid int overflow.
1015 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1016 (lookup_image): Remove unnecessary tests.
1017 (xbm_image_p): Locals are now of int, not EMACS_INT,
1018 since parse_image_check makes sure they fit into int.
1019 (png_load, gif_load, svg_load_image):
1020 Prefer int to unsigned where either will do.
1021 (tiff_handler): New function, combining the cores of the
1022 old tiff_error_handler and tiff_warning_handler. This
1023 function is rewritten to use vsnprintf and thereby avoid
1024 stack buffer overflows. It uses only the features of vsnprintf
1025 that are common to both POSIX and native Microsoft.
1026 (tiff_error_handler, tiff_warning_handler): Use it.
1027 (tiff_load, gif_load, imagemagick_load_image):
1028 Don't assume :index value fits in 'int'.
1029 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1030 (imagemagick_load_image): Check that crop parameters fit into
1031 the integer types that MagickCropImage accepts. Don't assume
1032 Vimagemagick_render_type has a nonnegative value. Don't assume
1033 size_t fits in 'long'.
1034 (gs_load): Use printmax_t to print the widest integers possible.
1035 Check for integer overflow when computing image height and width.
1036
c11821d4
EZ
10372011-08-26 Eli Zaretskii <eliz@gnu.org>
1038
1039 * xdisp.c (redisplay_window): Don't force window start if point
1040 will be invisible in the resulting window. (Bug#9324)
1041
0c95fcf7
EZ
10422011-08-25 Eli Zaretskii <eliz@gnu.org>
1043
1044 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1045 the display spec is of the form `(space ...)'.
1046 (handle_display_spec): Return the value returned by
1047 handle_single_display_spec, not just 1 or zero.
1048 (handle_single_display_spec): If the display spec is of the form
1049 `(space ...)', and specifies display in the text area, return 2
1050 rather than 1.
fee65a97 1051 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
1052 accurately, and prefer exact match for point under bidi. Don't
1053 advance `row' beyond the last row of the window.
0c95fcf7
EZ
1054
1055 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1056 into disp_prop; all users changed.
1057
1058 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1059 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1060 for the text covered by the display property.
1061
e4ed06f1
CY
10622011-08-25 Chong Yidong <cyd@stupidchicken.com>
1063
1064 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1065 Change return value to nil.
1066 (Frecord_buffer): Delete unused function.
1067
f67cdd7f
EZ
10682011-08-24 Eli Zaretskii <eliz@gnu.org>
1069
5980d4c6
EZ
1070 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1071 buffers, return left-to-right.
8610fe8b
EZ
1072 (set_cursor_from_row): Consider candidate row a win if its glyph
1073 represents a newline and point is on that newline. Fixes cursor
1074 positioning on the newline at EOL of R2L text within L2R
1075 paragraph, and vice versa.
1076 (try_cursor_movement): Check continued rows, in addition to
1077 continuation rows. Fixes unwarranted scroll when point enters a
1078 continued line of R2L text within an L2R paragraph, or vice versa.
1079 (cursor_row_p): Consider the case of point being equal to
1080 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1081 from the end of a short line to the beginning of a continued line
1082 of R2L text within L2R paragraph.
1083 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1084 composed characters.
5980d4c6 1085
f67cdd7f
EZ
1086 * bidi.c (bidi_check_type): Use xassert.
1087 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1088 members.
1089
bca633fb
EZ
10902011-08-23 Eli Zaretskii <eliz@gnu.org>
1091
1092 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1093 a character.
1094
4a5885a7
CY
10952011-08-23 Chong Yidong <cyd@stupidchicken.com>
1096
1097 * nsfont.m (ns_otf_to_script): Fix typo.
1098
0902a04e
KH
10992011-08-22 Kenichi Handa <handa@m17n.org>
1100
1101 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1102 extra slot even if the purpose is char-code-property-table.
1103
1a2e6670
EZ
11042011-08-23 Eli Zaretskii <eliz@gnu.org>
1105
8ddde651
EZ
1106 * xdisp.c (redisplay_window): When computing centering_position,
1107 account for the height of the header line. (Bug#8874)
1108
425cc014
EZ
1109 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1110 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1111 candidate is selected by the mouse, and that candidate has a
1112 composed character under the mouse.
1113
1a2e6670
EZ
1114 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1115 coordinates reported by pos-visible-in-window-p for a composed
1116 character in column zero.
1117
8b76d6f8
SM
11182011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1119
1120 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1121
dac347dd
EZ
11222011-08-22 Eli Zaretskii <eliz@gnu.org>
1123
1124 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1125 consider it a hit if to_charpos is anywhere in the range of the
1126 composed buffer positions.
1127
e013fb34
CY
11282011-08-22 Chong Yidong <cyd@stupidchicken.com>
1129
1130 * image.c (gif_load): Don't assume that each subimage has the same
1131 dimensions as the base image. Handle disposal method that is
1132 "undefined" by the gif spec (Bug#9335).
1133
bd1ba3e8
CY
11342011-08-20 Chong Yidong <cyd@stupidchicken.com>
1135
1136 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1137 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1138
54a1215b
EZ
11392011-08-19 Eli Zaretskii <eliz@gnu.org>
1140
823564e5
EZ
1141 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1142 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1143 from an Org mode buffer to a Speedbar frame.
1144
54a1215b
EZ
1145 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1146 a composition, take its buffer position from IT->cmp_it.charpos.
1147 Fixes cursor positioning at the beginning of a line that begins
1148 with a composed character.
1149
9778ebcc
EZ
11502011-08-18 Eli Zaretskii <eliz@gnu.org>
1151
0be6ee06
EZ
1152 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1153 character bidirectional type, use STRONG_L instead. Fixes crashes
1154 in a buffer produced by `describe-categories'.
1155
9778ebcc
EZ
1156 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1157 members before the level stack, so they would be saved and
1158 restored when copying iterator state. Fixes incorrect reordering
1159 around TABs covered by display properties.
1160
156bffbe
AS
11612011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1162
1163 * process.c (Fnetwork_interface_list): Correctly determine buffer
1164 size.
1165
72ad093b
CY
11662011-08-17 Chong Yidong <cyd@stupidchicken.com>
1167
1168 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1169 (internal_condition_case_2, internal_condition_case_n):
1170 Remove unnecessary aborts (Bug#9081).
72ad093b 1171
35774242
EZ
11722011-08-17 Eli Zaretskii <eliz@gnu.org>
1173
1174 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1175 has no `load' handler, try opening the file locally. (Bug#9311)
1176
db76dd85
KB
11772011-08-16 Ken Brown <kbrown@cornell.edu>
1178
1179 * gmalloc.c: Expand comment.
1180
b215eee5
EZ
11812011-08-16 Eli Zaretskii <eliz@gnu.org>
1182
1183 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1184 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1185
a4579d33
KB
11862011-08-16 Ken Brown <kbrown@cornell.edu>
1187
1188 Fix memory allocation problems in Cygwin build (Bug#9273).
1189
1190 * unexcw.c ( __malloc_initialized): Declare external variable.
1191 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1192
8b76d6f8
SM
1193 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1194 New variables.
a4579d33
KB
1195 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1196 dumped emacs.
1197 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1198 in the static heap.
1199 [CYGWIN] (special_realloc): New function.
1200 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1201 requests to realloc storage in the static heap.
1202
3ebec551
PE
12032011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1204
1205 * bidi.c (bidi_initialize): Remove unused local.
1206
9fd8be00
EZ
12072011-08-15 Eli Zaretskii <eliz@gnu.org>
1208
474a8465
EZ
1209 * biditype.h: File removed.
1210
1211 * bidimirror.h: File removed.
1212
1213 * deps.mk (bidi.o): Remove biditype.h and
1214 bidimirror.h.
1215
1216 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1217 bidimirror.h.
1218
1219 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1220
1221 * chartab.c: Improve commentary for the uniprop_table API.
1222
32413314
EZ
1223 * bidi.c (bidi_paragraph_init): Support zero value of
1224 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1225 (bidi_initialize): Use uniprop_table instead of including
1226 biditype.h and bidimirror.h.
32413314 1227
9fd8be00
EZ
1228 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1229 coordinates of the iterator when restoring from ppos_it.
1230 (Bug#9296)
1231
5cf2b69b
KH
12322011-08-14 Kenichi Handa <handa@m17n.org>
1233
1234 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1235 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1236
daf17d00
EZ
12372011-08-14 Eli Zaretskii <eliz@gnu.org>
1238
1239 * xdisp.c (move_it_in_display_line_to): Don't invoke
1240 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1241 ppos_it. Fixes vertical cursor motion when line beginning is
1242 covered by an image. (Bug#9296)
1243
08e3161a
JD
12442011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1245
1246 * nsterm.h (ns_run_ascript): Declare.
1247 (NSAPP_DATA2_RUNASSCRIPT): Define.
1248
1249 * nsfns.m (as_script, as_result, as_status): New static variables.
1250 (ns_run_ascript): New function.
5e617bc2 1251 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1252 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1253 the event loop. Get status from as_status (Bug#7276).
1254
1255 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1256 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1257 the event loop (Bug#7276).
1258
a3720aa2
AS
12592011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1260
1261 * gnutls.c (QCgnutls_bootprop_priority)
1262 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1263 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1264 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1265 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1266 (QCgnutls_bootprop_verify_hostname_error)
1267 (QCgnutls_bootprop_callbacks_verify): Rename from
1268 Qgnutls_bootprop_..., all uses changed.
1269
1270 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1271 uses changed.
1272
0a0d27fb
PE
12732011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1274
19d5c50c
PE
1275 * xfaces.c (Qframe_set_background_mode): Now static.
1276 * dispextern.h (Qframe_set_background_mode): Remove decl.
1277
0a0d27fb
PE
1278 * process.c (Fnetwork_interface_info): Declare local only if needed.
1279
377538cb
JD
12802011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1281
1282 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1283 (Fnetwork_interface_list): Allocate in increments of bytes instead
1284 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1285 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1286 sockaddr.
1287 (struct ifflag_def): notrailers is smart on OSX.
1288 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1289 Get hardware address with getifaddrs if available.
1290
08fff70c
EZ
12912011-08-12 Eli Zaretskii <eliz@gnu.org>
1292
1293 * xdisp.c (iterate_out_of_display_property): xassert that
1294 IT->position is set to within IT->object's boundaries. Break from
1295 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1296 when IT->position is set up wrongly due to some bug.
1297 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1298 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1299 entry. Force push_it to save on the stack the current
1300 buffer/string position, to be restored by pop_it. Fix flags in
1301 the iterator structure wrt the object coming from a display
1302 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1303 properties. (Bug#9284)
1304
7be1c708 13052011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1306
7be1c708
CY
1307 * fontset.c (fontset_get_font_group): Add proper type checks.
1308 (Bug#9172)
aac0c6e3 1309
7be1c708 13102011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1311
7be1c708
CY
1312 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1313 and LC_VERSION_MIN_MACOSX.
1314 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1315 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1316
97bb72a6
EZ
13172011-08-08 Eli Zaretskii <eliz@gnu.org>
1318
1319 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1320 no-display-properties-and-no-overlays under bidi display.
1321 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1322 properties and overlays.
97bb72a6 1323
d5617611
CY
13242011-08-08 Chong Yidong <cyd@stupidchicken.com>
1325
37e11a63
CY
1326 * editfns.c (Fset_time_zone_rule): Document relationship with the
1327 setenv function.
1328
d5617611
CY
1329 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1330 the font entity extracted from the cache (Bug#8109).
1331
58872834
CY
13322011-08-07 Chong Yidong <cyd@stupidchicken.com>
1333
1334 * composite.c (autocmp_chars): Don't reset point. That is done by
1335 restore_point_unwind (Bug#5984).
1336
75bfc667
JL
13372011-08-07 Juri Linkov <juri@jurta.org>
1338
1339 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1340 to show the arg `TIME' instead of `TIMEVAL'.
1341
d1410150
EZ
13422011-08-06 Eli Zaretskii <eliz@gnu.org>
1343
1344 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1345 display property strides EOL and includes a newline, as in
1346 longlines-mode. (Bug#9254)
75b771e4
EZ
1347 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1348 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1349
1350 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1351 is non-zero, even if the data buffer is NULL. Fixes a crash in
1352 vertical-motion with longlines-mode. (Bug#9254)
1353
35928349
EZ
13542011-08-05 Eli Zaretskii <eliz@gnu.org>
1355
ec7cc85b
EZ
1356 * bidi.c <bidi_cache_total_alloc>: Now static.
1357 (bidi_initialize): Initialize bidi_cache_total_alloc.
1358
8b76d6f8 1359 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1360 cache. (Bug#9221)
1361
1362 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1363 amount allocated this far in `bidi_cache_total_alloc'.
1364 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1365 non-zero, only free the data buffer without restoring the cache
1366 contents. All callers changed.
1367
1368 * dispextern.h (bidi_unshelve_cache): Update prototype.
1369
1370 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1371 (move_it_in_display_line, move_it_to)
1372 (move_it_vertically_backward, move_it_by_lines): Replace the call
1373 to xfree to an equivalent call to bidi_unshelve_cache.
1374 (move_it_in_display_line_to): Fix logic of returning
412b6358 1375 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1376
e2e2423b
EZ
13772011-08-05 Eli Zaretskii <eliz@gnu.org>
1378
1379 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1380 came from a string character with a `cursor' property. (Bug#9229)
1381
ae9e757a
JD
13822011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1383
1384 * Makefile.in (LIB_PTHREAD): New variable.
1385 (LIBES): Add LIB_PTHREAD (Bug#9216).
1386
1387 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1388 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1389
213bd7f2
AS
13902011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1391
1392 * regex.c (re_iswctype): Remove some redundant boolean
1393 conversions.
1394
99aaf75f
JD
13952011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1396
1397 * xterm.c (x_find_topmost_parent): New function.
1398 (x_set_frame_alpha): Find topmost parent window with
1399 x_find_topmost_parent and set the property there also (bug#9181).
1400 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1401
c74e9d86
PE
14022011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1403
1404 * callproc.c (Fcall_process): Avoid vfork clobbering
1405 the local vars buffer, coding_systems, current_dir.
1406
640c8776
SM
14072011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1408
1409 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1410
f26d0e4c
PE
14112011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1412
8a10d76c
PE
1413 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1414 so that it is not optimized away.
1415
f26d0e4c
PE
1416 * xdisp.c (compute_display_string_pos): Remove unused local.
1417
55439c61
EZ
14182011-08-02 Eli Zaretskii <eliz@gnu.org>
1419
1420 Fix slow cursor motion and scrolling in large buffers with
1421 selective display, like Org Mode buffers. (Bug#9218)
1422
1423 * dispextern.h (struct bidi_it): New member disp_prop_p.
1424
1425 * xdisp.c: Remove one-slot cache of display string positions.
1426 (compute_display_string_pos): Accept an additional argument
5e617bc2 1427 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1428 for a display string or property. If found, set DISP_PROP_P
1429 non-zero.
1430
1431 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1432 DISP_PROP_P, and pass it to compute_display_string_pos.
1433 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1434 non-zero. All callers of bidi_fetch_char changed.
1435
fb33fa43
SM
14362011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1437
1438 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1439
b099e063
DM
14402010-12-03 Don March <don@ohspite.net>
1441
1442 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1443 last character M-[char] is translated to ESC [char] (bug#7541).
1444
5cc7f7af
KH
14452011-08-02 Kenichi Handa <handa@m17n.org>
1446
d0fffa3f 1447 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1448
1449 * chartab.c (uniprop_table): Make it non-static.
1450
525d5e6e
EZ
14512011-08-01 Eli Zaretskii <eliz@gnu.org>
1452
1453 * xdisp.c (forward_to_next_line_start): Accept additional argument
1454 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1455 on the newline.
1456 (reseat_at_next_visible_line_start): Use the bidi iterator state
1457 returned by forward_to_next_line_start to restore the state of
1458 it->bidi_it after backing up to previous newline. (Bug#9212)
1459
31011111
AS
14602011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1461
1462 * regex.c (re_comp): Protoize.
1463 (re_exec): Fix return type.
1464 (regexec): Fix type of `ret'. (Bug#9203)
1465
476371c4
PE
14662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1467
e5d76069
PE
1468 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1469 This is needed if max-image-size is a floating-point number.
1470
9a79b20c
AS
14712011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1472
1473 * print.c (print_object): Print empty symbol as ##.
1474
1475 * lread.c (read1): Read ## as empty symbol.
1476
d8c2fa78
AA
14772011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1478
1479 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1480 setting frame foreground color (Bug#9175).
1481 (x_set_background_color): Likewise.
1482
ffe57a7a
AA
1483 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1484 contents (Bug#9176).
1485 (EmacsTooltip -init): Remove bezels and add shadows to
1486 tooltip windows.
1487
bf3492a5
AA
1488 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1489 or scroll bar (Bug#8470).
1490
d55e9c53
AA
1491 * nsfont.m (nsfont_open): Remove assignment to voffset and
1492 unnecessary vars hshink, expand, hd, full_height, min_height.
1493 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1494
1495 * nsterm.h (nsfont_info): Remove voffset field.
1496
d8c2fa78 14972011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1498
1499 Implement strike-through and overline on NextStep (Bug#8863).
1500
1501 * nsfont.m (nsfont_open): Use underline position provided by font,
1502 instead of hard-coded value of 2.
1503 (nsfont_draw): Call ns_draw_text_decoration instead.
1504
1505 * nsterm.h: Add declaration for ns_draw_text_decoration.
1506
1507 * nsterm.m (ns_draw_text_decoration): New function for drawing
1508 underline, overline, and strike-through.
1509 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1510 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1511 accommodate underlining, etc.
4843aac3 1512
4cc60b9b
EZ
15132011-07-28 Eli Zaretskii <eliz@gnu.org>
1514
bc7ece87
EZ
1515 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1516 default.
4cc60b9b 1517
476371c4
PE
15182011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1519
66606eea
PE
1520 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1521 Without this fix, if a signal arrives just after memory fills up,
1522 'malloc' might be invoked reentrantly.
1523
476371c4
PE
1524 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1525 In other words, assume that every image size is allowed, on non-X
1526 hosts. This assumption is probably wrong, but it lets Emacs compile.
1527
f3fcc40d
AS
15282011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1529
1530 * regex.c (re_iswctype): Convert return values to boolean.
1531
350c992f
EZ
15322011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1533
1534 * xdisp.c (compute_display_string_pos): Don't use cached display
1535 string position if the buffer had its restriction changed.
1536 (Bug#9184)
1537
5266b4bb
PE
15382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1539
1540 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1541
2573a837 15422011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1543
41f55ccd 1544 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1545
39e378da
PE
1546 * bidi.c: Integer size and overflow fixes.
1547 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1548 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1549 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1550 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1551 (bidi_find_other_level_edge):
1552 Use ptrdiff_t instead of EMACS_INT where either will do.
1553 This works better on 32-bit hosts configured --with-wide-int.
1554 (bidi_cache_ensure_space): Check for size-calculation overflow.
1555 Use % rather than repeated addition, for better worst-case speed.
1556 Don't set bidi_cache_size until after xrealloc returns, because it
1557 might not return.
1558 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1559 (bidi_cache_ensure_space): Also check that the bidi cache size
1560 does not exceed that of the largest Lisp string or buffer. See Eli
1561 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1562
5e927815
PE
1563 * alloc.c (__malloc_size_t): Remove.
1564 All uses replaced by size_t. See Andreas Schwab's note
1565 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1566
ca4aa935
PE
1567 * image.c: Improve checking for integer overflow.
1568 (check_image_size): Assume that f is nonnull, since
1569 it is always nonnull in practice. This is one less thing to
1570 worry about when checking for integer overflow later.
1571 (x_check_image_size): New function, which checks for integer
1572 overflow issues inside X.
1573 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1574 This removes the need for a memory_full check.
1575 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1576 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1577 (xbm_read_bitmap_data): Change locals back to 'int', since
1578 their values must fit in 'int'.
1579 (xpm_load_image, png_load, tiff_load):
1580 Invoke x_create_x_image_and_pixmap earlier,
1581 to avoid much needless work if the image is too large.
1582 (tiff_load): Treat overly large images as if
1583 x_create_x_image_and_pixmap failed, not as malloc failures.
1584 (gs_load): Use x_check_image_size.
1585
5f8f9cc2
PE
1586 * gtkutil.c: Omit integer casts.
1587 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1588 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1589
5adf60bc
PE
1590 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1591
c8907a93
PE
1592 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1593 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1594 would wrongly return t on a 64-bit host.
1595
e3c25c68
PE
1596 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1597 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1598 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1599 and therefore cause GCC to emit a bogus diagnostic in some cases.
1600
3f791afe
PE
1601 * image.c: Integer signedness and overflow and related fixes.
1602 This is not an exhaustive set of fixes, but it's time to
1603 record what I've got.
1604 (lookup_pixel_color, check_image_size): Remove redundant decls.
1605 (check_image_size): Don't assume that arbitrary EMACS_INT values
1606 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1607 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1608 (tiff_load, imagemagick_load_image):
1609 Check for overflow in size calculations.
1610 (x_create_x_image_and_pixmap): Remove unnecessary test for
1611 xmalloc returning NULL; that can't happen.
1612 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1613 (xpm_color_bucket): Use better integer hashing function.
1614 (xpm_cache_color): Don't possibly over-allocate memory.
1615 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1616 (gif_memory_source):
1617 Use ptrdiff_t, not int or size_t, to record sizes.
1618 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1619 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1620 either works, as we prefer signed integers.
1621 (tiff_read_from_memory, tiff_write_from_memory):
1622 Return tsize_t, not size_t, since that's what the TIFF API wants.
1623 (tiff_read_from_memory): Don't fail simply because the read would
1624 go past EOF; instead, return a short read.
1625 (tiff_load): Omit no-longer-needed casts.
1626 (Fimagemagick_types): Don't assume size fits into 'int'.
1627
3cc5a532
PE
1628 Improve hashing quality when configured --with-wide-int.
1629 * fns.c (hash_string): New function, taken from sxhash_string.
1630 Do not discard information about ASCII character case; this
1631 discarding is no longer needed.
1632 (sxhash-string): Use it. Change sig to match it. Caller changed.
1633 * lisp.h: Declare it.
1634 * lread.c (hash_string): Remove, since we now use fns.c's version.
1635 The fns.c version returns a wider integer if --with-wide-int is
1636 specified, so this should help the quality of the hashing a bit.
1637
b312a492
PE
1638 * emacs.c: Integer overflow minor fix.
1639 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1640 Define only if GNU_LINUX.
1641 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1642
dfd153ae
PE
1643 * dispnew.c: Integer signedness and overflow fixes.
1644 Remove unnecessary forward decls, that were a maintenance hassle.
1645 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1646 All uses changed.
1647 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1648 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1649 (prepare_desired_row, line_draw_cost):
1650 Use int, not unsigned, where either works.
1651 (save_current_matrix, restore_current_matrix):
1652 Use ptrdiff_t, not size_t, where either works.
1653 (init_display): Check for overflow more accurately, and without
1654 relying on undefined behavior.
1655
a81d11a3
PE
1656 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1657 Remove, replacing with the new symbols in lisp.h. All uses changed.
1658 * fileio.c (make_temp_name):
1659 * filelock.c (lock_file_1, lock_file):
1660 * xdisp.c (message_dolog):
1661 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1662 Use pMd etc. instead.
1663 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1664 replacing the pWIDE etc. symbols removed from editfns.c.
1665
3300e6fd
PE
1666 * keyboard.h (num_input_events): Now uintmax_t.
1667 This is (very slightly) less likely to mess up due to wraparound.
1668 All uses changed.
1669
fd05c7e9
PE
1670 * buffer.c: Integer signedness fixes.
1671 (alloc_buffer_text, enlarge_buffer_text):
1672 Use ptrdiff_t rather than size_t when either will do, as we prefer
1673 signed integers.
1674
903fe15d
PE
1675 * alloc.c: Integer signedness and overflow fixes.
1676 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1677 (__malloc_size_t): Default to size_t, not to int.
1678 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1679 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1680 Prefer ptrdiff_t to size_t when either would do, as we prefer
1681 signed integers.
1682 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1683 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1684 Now const. Initialize with values that are in range even if char
1685 is signed.
1686 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1687 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1688 These functions do the right thing with sizes > 2**32.
1689 (check_depth): Now ptrdiff_t, not int.
1690 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1691 Adjust to new way of storing sizes. Check for size overflow bugs
1692 in rest of code.
1693 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1694 slightly wrong anyway, as it missed one instance of
1695 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1696 (refill_memory_reserve): Omit needless cast to size_t.
1697 (mark_object_loop_halt): Mark as externally visible.
1698
ac82cc6a
PE
1699 * xselect.c: Integer signedness and overflow fixes.
1700 (Fx_register_dnd_atom, x_handle_dnd_message):
1701 Use ptrdiff_t, not size_t, since we prefer signed.
1702 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1703 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1704 x_dnd_atoms_size and x_dnd_atoms_length.
1705
c2d1e36d
PE
1706 * doprnt.c: Prefer signed to unsigned when either works.
1707 * eval.c (verror):
1708 * doprnt.c (doprnt):
1709 * lisp.h (doprnt):
1710 * xdisp.c (vmessage):
1711 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1712 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1713 prefer signed arithmetic to avoid comparison confusion.
1714 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1715 but is a bit tricky.
1716
0e926e56
PE
1717 Assume freestanding C89 headers, string.h, stdlib.h.
1718 * data.c, doprnt.c, floatfns.c, print.c:
1719 Include float.h unconditionally.
1720 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1721 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1722 * regex.c: Likewise for stddef.h, string.h.
1723 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1724 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1725 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1726 (STDC_HEADERS): Remove obsolete defines.
1727 * sysdep.c: Include limits.h unconditionally.
1728
9cfdb3ec
PE
1729 Assume support for memcmp, memcpy, memmove, memset.
1730 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1731 * regex.c (memcmp, memcpy):
1732 Remove; we assume C89 now.
1733
1734 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1735 (__malloc_safe_bcopy): Remove; no longer needed.
1736
cf950e6b 1737 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1738 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1739 well either way, and we prefer signed to unsigned.
1740
dbf38e02
LMI
17412011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1742
1743 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1744 closes the connection while we're reading (bug#9182).
1745
d6f0886c 17462011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1747
d6f0886c
JD
1748 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1749 are specified (Bug#9168).
24e0f6b1 1750
2eb1f9e6
PE
17512011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1752
1753 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1754 Found by GCC static checking and --with-wide-int on a 32-bit host.
1755
22381272 17562011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1757
1758 * xdisp.c (compute_display_string_pos): Fix logic of caching
1759 previous display string position. Initialize cached_prev_pos to
1760 -1. Fixes slow-down at the beginning of a buffer.
1761
f25e39b4
EZ
17622011-07-24 Eli Zaretskii <eliz@gnu.org>
1763
1764 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1765 for attrs[LFACE_FONTSET_INDEX].
1766
04c4b52e
PE
17672011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1768
1769 * xml.c (parse_region): Remove unused local
1770 that was recently introduced.
1771
c1734fbd
EZ
17722011-07-23 Eli Zaretskii <eliz@gnu.org>
1773
be18c5a5
EZ
1774 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1775 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1776
c1734fbd
EZ
1777 * xdisp.c (move_it_in_display_line_to): Record the best matching
1778 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1779 exit if none of the characters scanned was an exact match.
1780 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1781 when exact match is impossible due to invisible text, and the
1782 lines are truncated.
1783
a258d627
JD
17842011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1785
1786 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1787 for OSX >= 10.7.
1788
b6d5a689
EZ
17892011-07-22 Eli Zaretskii <eliz@gnu.org>
1790
0f74f785
EZ
1791 Fix a significant slow-down of cursor motion with C-n, C-p,
1792 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1793 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1794 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1795 (next_element_from_buffer): Call compute_stop_pos_backwards to
1796 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1797 base_level_stop.
1798 (reseat): Don't look for prev_stop, as that could mean a very long
1799 run.
1800 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1801 <cached_disp_overlay_modiff>: Cache for last found display string
1802 position.
551918c1 1803 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1804 about the same buffer in the same area of character positions, and
1805 the buffer wasn't changed since the time the display string
1806 position was cached.
551918c1 1807
b2d0c91a
EZ
18082011-07-22 Eli Zaretskii <eliz@gnu.org>
1809
1810 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1811 is an integer, which is important for empty lines. (Bug#9149)
1812
043604ee
CY
18132011-07-22 Chong Yidong <cyd@stupidchicken.com>
1814
1815 * frame.c (Fmodify_frame_parameters): In tty case, update the
1816 default face if necessary (Bug#4238).
1817
da4adb04
CY
18182011-07-21 Chong Yidong <cyd@stupidchicken.com>
1819
1820 * editfns.c (Fstring_to_char): No need to explain what a character
1821 is in the docstring (Bug#6576).
1822
9abd0532
LMI
18232011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1824
1825 * xml.c (parse_region): Make sure we always return a tree.
1826
36881d16
HK
18272011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1828
1829 * xml.c (parse_region): If a document contains only comments,
1830 return that, too.
1831
1e98674d
LMI
18322011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1833
1834 * xml.c (make_dom): Return comments, too.
1835
590bd467
PE
18362011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1837
1838 Port to OpenBSD.
1839 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1840 and the surrounding thread.
1841 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1842 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1843 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1844 timer goes off.
1845 * s/openbsd.h (BROKEN_SIGIO): Define.
1846 * unexelf.c (unexec) [__OpenBSD__]:
1847 Don't update the .mdebug section of the Alpha COFF symbol table.
1848
f41628b2
LMI
18492011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1850
1851 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1852 (bug#8460).
1853
b59b67c5
PE
18542011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1855
15e3a074
PE
1856 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1857 This fixes some race conditions on the permissions of any newly
1858 created file.
1859
41bed37d
PE
1860 * alloc.c (valid_pointer_p): Use pipe, not open.
1861 This fixes some permissions issues when debugging.
1862
b59b67c5
PE
1863 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1864 If fchown fails to set both uid and gid, try to set just gid,
1865 as that is sometimes allowed. Adjust the file's mode to eliminate
1866 setuid or setgid bits that are inappropriate if fchown fails.
1867
925a6be7
SM
18682011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1869
1870 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1871 to compare Lisp_Objects.
1872 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1873 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1874 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1875
52968808
AS
18762011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1877
0a6a104b
AS
1878 * lread.c (read_integer): Unread even EOF character.
1879 (read1): Likewise. Properly record start position of symbol.
1880
52968808
AS
1881 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1882 symbol character follows.
1883
9e381cdd
PE
18842011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1885
1886 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1887 This works around a problem with the previous change to Fcopy_file.
1888 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1889 and without this change, GCC might complain about discarding
1890 fchown's return value.
1891
b5641435
JB
18922011-07-16 Juanma Barranquero <lekktu@gmail.com>
1893
1894 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1895
a8031457
PE
18962011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1897
1898 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1899
dd889327
LMI
19002011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1901
750c33f7
LMI
1902 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1903 it's used from the C level.
1904
dd889327
LMI
1905 * process.c: Use the same condition for POLL_FOR_INPUT in both
1906 keyboard.c and process.c (bug#1858).
1907
87e86684
LM
19082011-07-09 Lawrence Mitchell <wence@gmx.li>
1909
1910 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1911 (Fgnutls_boot): Use it.
1912
64348f40
AS
19132011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1914
1915 * doc.c (Fsubstitute_command_keys): Revert last change.
1916
1d698799
LMI
19172011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1918
f863868c
LMI
1919 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1920 quotes the next character, and doesn't affect other longer
1921 sequences (bug#8935).
1922
1d698799
LMI
1923 * lread.c (syms_of_lread): Clarify that is isn't only
1924 `eval-buffer' and `eval-defun' that's affected by
1925 `lexical-binding' (bug#8460).
1926
aa4b6df6
EZ
19272011-07-15 Eli Zaretskii <eliz@gnu.org>
1928
1929 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1930 bidi redisplay when a line includes both an image and is
1931 truncated.
1932
5d856da6
PE
19332011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1934
ad6042bb
PE
1935 Fix minor problems found by static checking.
1936 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1937 (elsz): Now a signed constant, not a size_t var. We prefer signed
1938 types to unsigned, to avoid integer comparison confusion. Without
1939 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1940 "cannot optimize loop, the loop counter may overflow", a symptom
1941 of the confusion.
f00bbb22 1942 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1943 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1944
6468f31c
LMI
19452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1946
49080b10
LMI
1947 * search.c (Fre_search_backward): Mention `case-fold-search' in
1948 all the re_search_* functions (bug#8138).
1949
6468f31c
LMI
1950 * keyboard.c (Fopen_dribble_file): Document when the file is
1951 closed (bug#8056).
1952
c965adc5
EZ
19532011-07-14 Eli Zaretskii <eliz@gnu.org>
1954
df9733bf
EZ
1955 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1956 bidi_cache_idx.
1957
0bb23927
EZ
1958 Support bidi reordering of display and overlay strings.
1959 * xdisp.c (compute_display_string_pos)
1960 (compute_display_string_end): Accept additional argument STRING.
1961 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1962 (reseat_to_string): Initialize bidi_it->string.s and
1963 bidi_it->string.schars.
1964 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1965 NULL (avoids a crash in bidi_paragraph_init).
1966 Initialize itb.string.lstring.
0bb23927
EZ
1967 (init_iterator): Call bidi_init_it only of a valid
1968 buffer position was specified. Initialize paragraph_embedding to
1969 L2R.
1970 (reseat_to_string): Initialize the bidi iterator.
1971 (display_string): If we need to ignore text properties of
1972 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1973 original value of -1 will not work with bidi.)
1974 (compute_display_string_pos): First arg is now struct
1975 `text_pos *'; all callers changed. Support display properties on
1976 Lisp strings.
1977 (compute_display_string_end): Support display properties on Lisp
1978 strings.
1979 (init_iterator, reseat_1, reseat_to_string): Initialize the
1980 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1981 when iterating on a string not from display properties).
640c8776
SM
1982 (compute_display_string_pos, compute_display_string_end):
1983 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1984 arrow keys.
1985 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1986 base_level_stop; instead, set base_level_stop to BEGV.
1987 Fixes crashes in vertical-motion.
0bb23927
EZ
1988 (next_element_from_buffer): Improve commentary for when
1989 the iterator is before prev_stop.
1990 (init_iterator): Initialize bidi_p from the default value of
1991 bidi-display-reordering, not from buffer-local value. Use the
1992 buffer-local value only if initializing for buffer iteration.
1993 (handle_invisible_prop): Support invisible properties on strings
1994 that are being bidi-reordered.
1995 (set_iterator_to_next): Support bidi reordering of C strings and
1996 Lisp strings.
1997 (next_element_from_string): Support bidi reordering of Lisp
1998 strings.
1999 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2000 (display_string): Support display of R2L glyph rows.
2001 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2002 (init_iterator): Don't initialize it->bidi_p for strings
2003 here.
2004 (reseat_to_string): Initialize it->bidi_p for strings here.
2005 (next_element_from_string, next_element_from_c_string)
2006 (next_element_from_buffer): Add xassert's for correspondence
2007 between IT's object being iterated and it->bidi_it.string
2008 structure.
2009 (face_before_or_after_it_pos): Support bidi iteration.
2010 (next_element_from_c_string): Handle the case of the first string
2011 character that is not the first one in the visual order.
2012 (get_visually_first_element): New function, refactored from common
2013 parts of next_element_from_buffer, next_element_from_string, and
2014 next_element_from_c_string.
2015 (tool_bar_lines_needed, redisplay_tool_bar)
2016 (display_menu_bar): Force left-to-right direction. Add a FIXME
2017 comment for making that be controlled by a user option.
2018 (push_it, pop_it): Save and restore the state of the
2019 bidi iterator. Save and restore the bidi_p flag.
2020 (pop_it): Iterate out of display property for string iteration as
2021 well.
2022 (iterate_out_of_display_property): Support iteration over strings.
2023 (handle_single_display_spec): Set up it->bidi_it for iteration
2024 over a display string, and call bidi_init_it.
2025 (handle_single_display_spec, next_overlay_string)
2026 (get_overlay_strings_1, push_display_prop): Set up the bidi
2027 iterator for displaying display or overlay strings.
2028 (forward_to_next_line_start): Don't use the shortcut if
2029 bidi-iterating.
2030 (back_to_previous_visible_line_start): If handle_display_prop
2031 pushed the iterator stack, restore the internal state of the bidi
2032 iterator by calling bidi_pop_it same number of times.
2033 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2034 and we are bidi-iterating, don't decrement the iterator position;
2035 instead, set the first_elt flag in the bidi iterator, to produce
2036 the same effect.
2037 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2038 (push_display_prop): xassert that we are iterating a buffer.
2039 (push_it, pop_it): Save and restore paragraph_embedding member.
2040 (handle_single_display_spec, next_overlay_string)
2041 (get_overlay_strings_1, reseat_1, reseat_to_string)
2042 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2043 correctly. Don't assume unibyte strings are not bidi-reordered.
2044 (compute_display_string_pos)
2045 (compute_display_string_end): Fix handling the case of C string.
2046 (push_it, pop_it): Save and restore from_disp_prop_p.
2047 (handle_single_display_spec, push_display_prop): Set the
2048 from_disp_prop_p flag.
2049 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2050 (pop_it): Call iterate_out_of_display_property only if we are
2051 popping after iteration over a string that came from a display
2052 property. Fix a typo in popping stretch info. Add an assertion
2053 for verifying that the iterator position is in sync with the bidi
2054 iterator.
2055 (handle_single_display_spec, get_overlay_strings_1)
2056 (push_display_prop): Fix initialization of paragraph direction for
2057 string when that of the parent object is not yet determined.
2058 (reseat_1): Call bidi_init_it to resync the bidi
2059 iterator with IT's position. (Bug#7616)
2060 (find_row_edges): If ROW->start.pos gives position
2061 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2062 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2063 Reset the from_disp_prop_p flag.
2064 (SAVE_IT, RESTORE_IT): New macros.
2065 (pos_visible_p, face_before_or_after_it_pos)
2066 (back_to_previous_visible_line_start)
2067 (move_it_in_display_line_to, move_it_in_display_line)
2068 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2069 (try_scrolling, redisplay_window, display_line): Use them when
2070 saving a temporary copy of the iterator and restoring it back.
2071 (back_to_previous_visible_line_start, reseat_1)
2072 (init_iterator): Empty the bidi cache "stack".
2073 (move_it_in_display_line_to): If iterator ended up at
2074 EOL, but we never saw any buffer positions smaller than
2075 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2076 motion in bidi-reordered lines.
2077 (move_it_in_display_line_to): Record prev_method and prev_pos
2078 immediately before the call to set_iterator_to_next. Fixes cursor
2079 motion in bidi-reordered lines with stretch glyphs and strings
2080 displayed in margins. (Bug#8133) (Bug#8867)
2081 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2082 TO_CHARPOS.
640c8776
SM
2083 (pos_visible_p): Support positions in bidi-reordered lines.
2084 Save and restore bidi cache.
0bb23927
EZ
2085
2086 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2087 (bidi_paragraph_info): Delete unused struct.
2088 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2089 (bidi_cache_start): New variable.
2090 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2091 to zero.
2092 (bidi_cache_fetch_state, bidi_cache_search)
2093 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2094 (bidi_cache_find, bidi_peek_at_next_level)
2095 (bidi_level_of_next_char, bidi_find_other_level_edge)
2096 (bidi_move_to_visually_next): Compare cache index with
2097 bidi_cache_start rather than with zero.
2098 (bidi_fetch_char): Accept new argument STRING; all callers
2099 changed. Support iteration over a string. Support strings with
2100 display properties. Support unibyte strings. Fix the type of
2101 `len' according to what STRING_CHAR_AND_LENGTH expects.
2102 (bidi_paragraph_init, bidi_resolve_explicit_1)
2103 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2104 (bidi_level_of_next_char, bidi_move_to_visually_next):
2105 Support iteration over a string.
0bb23927
EZ
2106 (bidi_set_sor_type, bidi_resolve_explicit_1)
2107 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2108 can now be zero (for strings); special values 0 and -1 were
2109 changed to -1 and -2, respectively.
2110 (bidi_char_at_pos): New function.
2111 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2112 Call it instead of FETCH_MULTIBYTE_CHAR.
2113 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2114 initialized to valid values.
2115 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2116 values.
2117 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2118 the test for valid cached positions. Fix the logic for looking up
2119 the sentinel state in the cache. GCPRO the Lisp string we are
2120 iterating.
2121 (bidi_push_it, bidi_pop_it): New functions.
2122 (bidi_initialize): Initialize the bidi cache start stack pointer.
2123 (bidi_cache_ensure_space): New function, refactored from part of
2124 bidi_cache_iterator_state. Don't assume the required size is just
2125 one BIDI_CACHE_CHUNK away.
2126 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2127 (bidi_count_bytes, bidi_char_at_pos): New functions.
2128 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2129 always valid if bidi_cache_idx is valid.
2130 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2131 is valid if it's going to be used.
2132 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2133 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2134 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2135 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2136 (bidi_find_other_level_edge, bidi_cache_start_stack):
2137 All variables related to cache indices are now EMACS_INT.
c965adc5 2138
0bb23927
EZ
2139 * dispextern.h (struct bidi_string_data): New structure.
2140 (struct bidi_it): New member `string'. Make flag members be 1-bit
2141 fields, and put them last in the struct.
640c8776
SM
2142 (compute_display_string_pos, compute_display_string_end):
2143 Update prototypes.
0bb23927
EZ
2144 (bidi_push_it, bidi_pop_it): Add prototypes.
2145 (struct iterator_stack_entry): New members bidi_p,
2146 paragraph_embedding, and from_disp_prop_p.
2147 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2148 (bidi_shelve_cache, bidi_unshelve_cache):
2149 Declare prototypes.
0bb23927
EZ
2150
2151 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2152 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2153 and vector-like objects.
2154
2155 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2156 cache around display iteration.
2157
2158 * window.c (Fwindow_end, window_scroll_pixel_based)
2159 (displayed_window_lines, Frecenter): Save and restore the bidi
2160 cache around display iteration.
2161
3bbd2265
LMI
21622011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2163
2164 * editfns.c (Fdelete_region): Clarify the use of the named
2165 parameters (bug#6788).
2166
adc47434
MR
21672011-07-14 Martin Rudalics <rudalics@gmx.at>
2168
2169 * indent.c (Fvertical_motion): Set and restore w->pointm when
2170 saving and restoring the window's buffer (Bug#9006).
2171
837c31f8
LMI
21722011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2173
2174 * editfns.c (Fstring_to_char): Clarify just what is returned
2175 (bug#6576). Text by Eli Zaretskii.
2176
ac389d0c
JB
21772011-07-13 Juanma Barranquero <lekktu@gmail.com>
2178
2179 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2180
0be0ce47
EZ
21812011-07-13 Eli Zaretskii <eliz@gnu.org>
2182
2183 * buffer.c (mmap_find): Fix a typo.
2184
cd18e7e3
JB
21852011-07-13 Johan Bockgård <bojohan@gnu.org>
2186
2187 Fix execution of x selection hooks.
2188 * xselect.c (Qx_lost_selection_functions)
2189 (Qx_sent_selection_functions): New vars.
2190 (syms_of_xselect): DEFSYM them.
2191 (x_handle_selection_request): Pass Qx_sent_selection_functions
2192 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2193 (x_handle_selection_clear,x_clear_frame_selections):
2194 Pass Qx_lost_selection_functions rather than
2195 Vx_lost_selection_functions to Frun_hook_with_args.
2196
47ea7f44
PE
21972011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2198
ac389d0c 2199 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2200 The old code sometimes used this field without initializing it.
2201
47ea7f44
PE
2202 * alloc.c (gc_sweep): Don't read past end of array.
2203 In theory, the old code could also have corrupted Emacs internals,
2204 though it'd be very unlikely.
2205
bc985c87
AS
22062011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2207
2208 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2209 argument. (Bug#4026)
bc985c87 2210
0cf34688
LMI
22112011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2212
b3dadd76
LMI
2213 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2214 key" (bug#4257).
2215
0cf34688
LMI
2216 * window.c (Fset_window_start): Doc fix (bug#4199).
2217 (Fset_window_hscroll): Ditto.
2218
270768cd
PE
22192011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2220
077e3dda 2221 Fix minor new problems caught by GCC 4.6.1.
270768cd 2222 * term.c (init_tty): Remove unused local.
490011a6 2223 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2224 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2225 not used otherwise.
270768cd 2226
b1f58454
CY
22272011-07-12 Chong Yidong <cyd@stupidchicken.com>
2228
2229 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2230
22b9578d
LMI
22312011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2232
6e70ab07
LMI
2233 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2234 are the mini-buffer and the echo area (bug#3320).
2235
22b9578d
LMI
2236 * term.c (init_tty): Remove support for supdup, c10 and perq
2237 terminals, which are no longer supported (bug#1482).
2238
8974cc9f
JB
22392011-07-10 Johan Bockgård <bojohan@gnu.org>
2240
2241 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2242
a560d974
JD
22432011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2244
2245 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2246 for non-popups (Bug#3642).
2247
1dae0f0a
AS
22482011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2249
268c2c36 2250 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2251 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2252 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2253 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2254 * data.c (fmod): Likewise.
2255 * dispnew.c (swap_glyphs_in_rows): Likewise.
2256 * emacs.c (memory_warning_signal): Likewise.
2257 * floatfns.c (float_error): Likewise.
2258 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2259 (otf_open, font_otf_capability, generate_otf_features)
2260 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2261 Likewise.
2262 * image.c (pbm_read_file): Likewise.
2263 * indent.c (string_display_width): Likewise.
2264 * intervals.c (check_for_interval, search_for_interval)
2265 (inc_interval_count, count_intervals, root_interval)
2266 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2267 * lread.c (defalias): Likewise.
268c2c36 2268 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2269 * regex.c (set_image_of_range_1, set_image_of_range)
2270 (regex_grow_registers): Likewise.
2271 * sysdep.c (strerror): Likewise.
2272 * termcap.c (valid_filename_p, tprint, main): Likewise.
2273 * tparam.c (main): Likewise.
2274 * unexhp9k800.c (run_time_remap, save_data_space)
2275 (update_file_ptrs, read_header, write_header, calculate_checksum)
2276 (copy_file, copy_rest, display_header): Likewise.
2277 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2278 Likewise.
2279 * xdisp.c (check_it): Likewise.
2280 * xfaces.c (register_color, unregister_color, unregister_colors):
2281 Likewise.
2282 * xfns.c (print_fontset_result): Likewise.
2283 * xrdb.c (member, fatal, main): Likewise.
2284
99033785
PE
22852011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2286
2287 Fix minor problems found by static checking (Bug#9031).
2288 * chartab.c (char_table_set_range, map_sub_char_table):
2289 Remove unused locals.
2290 (uniprop_table): Now static.
2291 * composite.c (_work_char): Remove unused static var.
2292
9cb2ac56
JB
22932011-07-09 Juanma Barranquero <lekktu@gmail.com>
2294
2295 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2296
f25661f0
JD
22972011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2298
2299 * gtkutil.c (qttip_cb): Remove code without function.
2300
8278c4fe
EZ
23012011-07-09 Eli Zaretskii <eliz@gnu.org>
2302
2303 * w32.c (pthread_sigmask): New stub.
2304
1692ae2d 23052011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2306
8a6ebd58 2307 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2308 sigprocmask is portable only for single-threaded applications, and
2309 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2310 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2311 (LIBES): Use it.
2312 * callproc.c (Fcall_process):
2313 * process.c (create_process):
2314 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2315 Use pthread_sigmask, not sigprocmask.
123403e4 2316
1b854618
JD
23172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2318
2319 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2320 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2321 wrong (Bug#8591).
2322
3fe4b549
JD
23232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2324
0ce7e563
JD
2325 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2326 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2327 (xg_hide_tooltip): Fix comment.
2328
3fe4b549
JD
2329 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2330 in registerServicesMenuSendTypes.
2331 (validRequestorForSendType): Don't check ns_return_types.
2332
2333 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2334 ns_return_type.
2335
5df75e47
JR
23362011-07-08 Jason Rumney <jasonr@gnu.org>
2337
2338 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2339 frame struct members of non-existent frames (Bug#6284).
2340
699c10bd
JD
23412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2342
4393663b
JD
2343 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2344 variable firstTime not needed on OSX >= 10.6.
2345 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2346 >= 10.5. Use setKnobProportion, setDoubleValue.
2347
2348 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2349 (MAC_OS_X_VERSION_10_5): Define if not defined.
2350 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2351 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2352 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2353
2354 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2355 cString and lossyCString on OSX >= 10.4
2356
2357 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2358 sizeToFit on OSX >= 10.2.
2359
2360 * nsimage.m (allocInitFromFile): Don't use deprecated method
2361 bestRepresentationForDevice on OSX >= 10.6.
2362
2363 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2364 to avoid warning.
2365
2366 * emacs.c: Declare unexec_init_emacs_zone.
2367
a63e0781
JD
2368 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2369
699c10bd
JD
2370 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2371
2372 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2373 on svcsMenu (Bug#8842).
2374
2375 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2376 ns_return_types.
2377 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2378
2379 * nsterm.m (QUTF8_STRING): Declare.
2380 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2381 (validRequestorForSendType): Return type is (id).
2382 Change indexOfObjectIdenticalTo to indexOfObject.
2383 Check if we have local selection before returning self (Bug#8842).
2384 (writeSelectionToPasteboard): Put local selection into paste board
2385 if we have a local selection (Bug#8842).
2386 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2387
2388 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2389 (ns_get_local_selection): Declare.
2390
54e10184
LMI
23912011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2392
9888ff71
LMI
2393 * keymap.c (describe_map_tree): Don't insert a double newline at
2394 the end of the buffer (bug#1169) and return whether we inserted
2395 something.
2396
54e10184
LMI
2397 * callint.c (Fcall_interactively): Change "reading args" to
2398 "providing args" to try to clarify what it does (bug#1010).
2399
15fa4783
KH
24002011-07-07 Kenichi Handa <handa@m17n.org>
2401
2402 * composite.c (composition_compute_stop_pos): Ignore a static
2403 composition starting before CHARPOS (Bug#8915).
2404
2405 * xdisp.c (handle_composition_prop): Likewise.
2406
a8815b00
EZ
24072011-07-07 Eli Zaretskii <eliz@gnu.org>
2408
2409 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2410 (Bug#9015)
2411
ef7b981d 24122011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2413
2414 * character.h (unicode_category_t): New enum type.
2415
2416 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2417 (Qchar_code_property_table): New variable.
2418 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2419 (UNIPROP_COMPRESSED_FORM_P): New macros.
2420 (char_table_ascii): Uncompress the compressed values.
2421 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2422 Uncompress the compressed values.
ac389d0c 2423 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2424 (char_table_ref_and_range): Uncompress the compressed values.
2425 (sub_char_table_set): New arg is_uniprop. Callers changed.
2426 Uncompress the compressed values.
2427 (sub_char_table_set_range): Args changed. Callers changed.
2428 (char_table_set_range): Adjuted for the above change.
2429 (map_sub_char_table): Delete args default_val and parent. Add arg
2430 top. Give decoded values to a Lisp function.
640c8776 2431 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2432 values to a Lisp function. Gcpro more variables.
2433 (uniprop_table_uncompress)
2434 (uniprop_decode_value_run_length): New functions.
2435 (uniprop_decoder, uniprop_decoder_count): New variables.
2436 (uniprop_get_decoder, uniprop_encode_value_character)
2437 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2438 New functions.
2439 (uniprop_encoder, uniprop_encoder_count): New variables.
2440 (uniprop_get_encoder, uniprop_table)
2441 (Funicode_property_table_internal, Fget_unicode_property_internal)
2442 (Fput_unicode_property_internal): New functions.
2443 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2444 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2445 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2446 char-code-property-alist.
2447
640c8776 2448 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2449 Vunicode_category_table.
2450
640c8776 2451 * font.c (font_range): Adjust for the change of
c805dec0
KH
2452 Vunicode_category_table.
2453
76b397fb
DN
24542011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2455
2456 * m/iris4d.h: Remove file, move contents ...
2457 * s/irix6-5.h: ... here.
2458
22b4128e
PE
24592011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2460
2461 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2462 * alloc.c (mark_buffer):
2463 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2464 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2465 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2466 This isn't true in general, and it's particularly not true
2467 if Emacs is configured with --with-wide-int.
2468 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2469 New macros, used in the buffer.c change.
2470
869795d6
JD
24712011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2472
2473 * xsettings.c: Use both GConf and GSettings if both are available.
2474 (store_config_changed_event): Add comment.
2475 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2476 (store_tool_bar_style_changed): New functions.
5e617bc2 2477 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2478 (struct xsettings): Move font inside HAVE_XFT.
2479 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2480 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2481 Move inside HAVE_XFT.
640c8776 2482 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2483 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2484 also.
2485 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2486 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2487 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2488 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2489 (parse_settings): Move check for font inside HAVE_XFT.
2490 (read_settings, apply_xft_settings): Add comment.
2491 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2492 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2493 call store_font_name_changed.
2494 (xft_settings_event): Add comment.
2495 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2496 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2497 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2498 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2499 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2500 (xsettings_get_system_font, xsettings_get_system_normal_font):
2501 Add comment.
869795d6 2502
d8ed26bd
PE
25032011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2504
2505 Random fixes. E.g., (random) never returned negative values.
2506 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2507 subseconds part to the entropy, as that's a bit more random.
2508 Prefer signed to unsigned, since the signedness doesn't matter and
2509 in general we prefer signed. When given a limit, use a
2510 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2511 latter isn't right if USE_2_TAGS_FOR_INTS.
2512 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2513 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2514
cabf1cac
SM
25152011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2516
2517 * textprop.c (text_property_stickiness):
2518 Obey Vtext_property_default_nonsticky.
2519 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2520 * w32fns.c (syms_of_w32fns):
2521 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2522
6e9b2be9
PE
25232011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2524
2525 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2526 This is more efficient than Ffile_directory_p and avoids a minor race.
2527
90186c68
LMI
25282011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2529
7c301272
LMI
2530 * buffer.c (Foverlay_put): Say what the return value is
2531 (bug#7835).
2532
c4f2d8d4
LMI
2533 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2534 is a directory before asking whether to use the file name
2535 (bug#7564).
ad637907
LMI
2536 (barf_or_query_if_file_exists): Make the "File is a directory"
2537 error be more correct.
c4f2d8d4 2538
90186c68
LMI
2539 * fns.c (Frequire): Remove the mention of the .gz files, since
2540 that's installation-specific, but keep the mention of
2541 `get-load-suffixes'.
2542
da64016e
PE
25432011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2544
2545 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2546 Report string overflow if the output is too long.
2547
7d47b580
JB
25482011-07-04 Juanma Barranquero <lekktu@gmail.com>
2549
a555cb87
JB
2550 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2551 (syms_of_gnutls): Remove duplicate DEFSYM for
2552 Qgnutls_bootprop_verify_hostname_error, an error for
2553 Qgnutls_bootprop_verify_error (which is no longer used).
2554
7d47b580
JB
2555 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2556 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2557 Also (re)move comments that are misplaced or no longer relevant.
2558
1e49bfab
LMI
25592011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2560
2561 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2562
1485f4c0
CY
25632011-07-03 Chong Yidong <cyd@stupidchicken.com>
2564
2565 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2566 and background color parameters if they have been changed.
2567
a9ab721e
LMI
25682011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2569
2570 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2571
cf7cff57
PE
25722011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2573
2e13213d
PE
2574 * xsettings.c (SYSTEM_FONT): Define only when used.
2575 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2576
cf7cff57
PE
2577 * keymap.c (access_keymap_1): Now static.
2578
7a8e04f7
CY
25792011-07-02 Chong Yidong <cyd@stupidchicken.com>
2580
2581 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2582 leave any prefix arg for the up event (Bug#1586).
2583
61352f62
LMI
25842011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2585
69bb1ef7
LMI
2586 * lread.c (syms_of_lread): Mention single symbols defined by
2587 `defvar' or `defconst' (bug#7154).
2588
61352f62 2589 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2590 (Frequire): Mention get-load-suffixes.
61352f62 2591
28545e04
MR
25922011-07-02 Martin Rudalics <rudalics@gmx.at>
2593
2594 * window.h (window): Remove clone_number slot.
2595 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2596 Remove.
2597 (make_parent_window, make_window, saved_window)
2598 (Fset_window_configuration, save_window_save): Don't deal with
2599 clone numbers.
2600 * buffer.c (Qclone_number): Remove declaration.
2601 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2602
3349e122
SM
26032011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2604
2605 Add multiple inheritance to keymaps.
2606 * keymap.c (Fmake_composed_keymap): New function.
2607 (Fset_keymap_parent): Simplify.
2608 (fix_submap_inheritance): Remove.
2609 (access_keymap_1): New function extracted from access_keymap to handle
2610 embedded parents and handle lists of maps.
2611 (access_keymap): Use it.
2612 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2613 (Fcopy_keymap): Handle embedded parents.
2614 (Fcommand_remapping, define_as_prefix): Simplify.
2615 (Fkey_binding): Simplify.
2616 (syms_of_keymap): Move minibuffer-local-completion-map,
2617 minibuffer-local-filename-completion-map,
2618 minibuffer-local-must-match-map, and
2619 minibuffer-local-filename-must-match-map to Elisp.
2620 (syms_of_keymap): Defsubr make-composed-keymap.
2621 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2622 (parse_menu_item): Trivial simplification.
2623
3279eb87
GM
26242011-07-01 Glenn Morris <rgm@gnu.org>
2625
2626 * Makefile.in (SETTINGS_LIBS): Fix typo.
2627
4550efdf
KI
26282011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2629
2630 * coding.c (Fencode_coding_string): Record the last coding system
2631 used, as the function doc string says (bug#8738).
2632
0949d2b6
JD
26332011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2634
2635 * xsettings.c (store_monospaced_changed): Take new font as arg and
2636 check for change against current_mono_font.
2637 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2638 (emacs_settings_constructor, emacs_settings_get_property)
2639 (emacs_settings_set_property, emacs_settings_class_init)
2640 (emacs_settings_init, gsettings_obj): Remove.
2641 (something_changedCB): New function for HAVE_GSETTINGS.
2642 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2643 with value as argument.
2644 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2645 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2646 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2647 "changed".
2648
2649 * xgselect.c: Add defined (HAVE_GSETTINGS).
2650 (xgselect_initialize): Ditto.
2651
2652 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2653 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2654 xg_select.
2655
bbc6b304
PE
26562011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 * eval.c (struct backtrace): Simplify and port the data structure.
2659 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2660 signed bit field, as this assumption is not portable and it makes
2661 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2662 "char debug_on_exit : 1" as this is not portable either; instead,
2663 use the portable "unsigned int debug_on_exit : 1". Remove unused
2664 member evalargs. Remove obsolete comments about cc bombing out.
2665
9851bfc5
JD
26662011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2667
51bb811f 2668 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2669 Let HAVE_GSETTINGS override HAVE_GCONF.
2670 (store_monospaced_changed): New function.
2671 (EMACS_SETTINGS): A new type derived from GObject to handle
2672 GSettings notifications.
2673 (emacs_settings_constructor, emacs_settings_get_property)
2674 (emacs_settings_set_property, emacs_settings_class_init):
2675 New functions.
2676 (gsettings_client, gsettings_obj): New variables.
2677 (GSETTINGS_SCHEMA): New define.
2678 (something_changedCB): Call store_monospaced_changed.
2679 (init_gsettings): New function.
2680 (xsettings_initialize): Call init_gsettings.
2681 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2682 to NULL.
2683
640c8776 2684 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2685 GCONF_CFLAGS/LIBS.
2686
5386012d
MR
26872011-06-29 Martin Rudalics <rudalics@gmx.at>
2688
2689 * window.c (resize_root_window, grow_mini_window)
2690 (shrink_mini_window): Rename Qresize_root_window to
2691 Qwindow_resize_root_window and Qresize_root_window_vertically to
2692 Qwindow_resize_root_window_vertically.
2693
f13e0b08
PE
26942011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2695
2696 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2697
94515237
JB
26982011-06-27 Juanma Barranquero <lekktu@gmail.com>
2699
2700 * makefile.w32-in: Redesign dependencies so they reflect more
2701 clearly which files are directly included by each source file,
2702 and not through other includes.
2703
e43b6e43
MR
27042011-06-27 Martin Rudalics <rudalics@gmx.at>
2705
2706 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2707 (sort_overlays, overlay_strings): When an overlay's clone number
2708 matches the window's clone number process the overlay even if
2709 the overlay's window property doesn't match the current window.
2710
d68443dc
MR
2711 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2712 (Fwindow_hchild): Rename to Fwindow_left_child.
2713 (Fwindow_next): Rename to Fwindow_next_sibling.
2714 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2715 (resize_window_check): Rename to window_resize_check.
2716 (resize_window_apply): Rename to window_resize_apply.
2717 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2718 (Fdelete_other_windows_internal, resize_frame_windows)
2719 (Fsplit_window_internal, Fdelete_window_internal)
2720 (grow_mini_window, shrink_mini_window)
2721 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2722
c7e73be5
JD
27232011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2724
2725 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2726 (emacs_fixed_set_min_size): Remove.
2727 (emacs_fixed_new): Take frame as argument.
2728
2729 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2730 (_EmacsFixedPrivate): Remove minwidth/height.
2731 Add struct frame *f.
2732 (emacs_fixed_init): Initialize priv->f.
2733 (get_parent_class, emacs_fixed_set_min_size): Remove.
2734 (emacs_fixed_new): Set priv->f to argument.
2735 (emacs_fixed_get_preferred_width)
2736 (emacs_fixed_get_preferred_height): Use min_width/height from
2737 frames size_hint to set minimum and natural (Bug#8919).
2738 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2739 and use min_width/height from frames size_hint to set
2740 min_width/height (Bug#8919).
2741
2742 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2743 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2744 Fix indentation.
c7e73be5 2745
cf99dcf8
EZ
27462011-06-26 Eli Zaretskii <eliz@gnu.org>
2747
2748 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2749 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2750 called at ZV.
2751
029529ac
CY
27522011-06-26 Chong Yidong <cyd@stupidchicken.com>
2753
2754 * process.c (wait_reading_process_output): Bypass select if
2755 waiting for a cell while ignoring keyboard input, and input is
2756 pending. Suggested by Jan Djärv (Bug#8869).
2757
7a7ef429
PE
27582011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2759
2760 Use gnulib's dup2 module instead of rolling our own.
2761 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2762
11fdef7d 27632011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2764
2765 * dispnew.c (scrolling_window): Before scrolling, turn off a
2766 mouse-highlight in the window being scrolled.
2767
cd3520a4
JB
27682011-06-24 Juanma Barranquero <lekktu@gmail.com>
2769
2770 Move DEFSYM to lisp.h and use everywhere.
2771
2772 * character.h (DEFSYM): Move declaration...
2773 * lisp.h (DEFSYM): ...here.
2774
2775 * gnutls.c:
2776 * minibuf.c:
2777 * w32menu.c:
2778 * w32proc.c:
2779 * w32select.c: Don't include character.h.
2780
2781 * alloc.c (syms_of_alloc):
2782 * buffer.c (syms_of_buffer):
2783 * bytecode.c (syms_of_bytecode):
2784 * callint.c (syms_of_callint):
2785 * casefiddle.c (syms_of_casefiddle):
2786 * casetab.c (init_casetab_once):
2787 * category.c (init_category_once, syms_of_category):
2788 * ccl.c (syms_of_ccl):
2789 * cmds.c (syms_of_cmds):
2790 * composite.c (syms_of_composite):
2791 * dbusbind.c (syms_of_dbusbind):
2792 * dired.c (syms_of_dired):
2793 * dispnew.c (syms_of_display):
2794 * doc.c (syms_of_doc):
2795 * editfns.c (syms_of_editfns):
2796 * emacs.c (syms_of_emacs):
2797 * eval.c (syms_of_eval):
2798 * fileio.c (syms_of_fileio):
2799 * fns.c (syms_of_fns):
2800 * frame.c (syms_of_frame):
2801 * fringe.c (syms_of_fringe):
2802 * insdel.c (syms_of_insdel):
2803 * keymap.c (syms_of_keymap):
2804 * lread.c (init_obarray, syms_of_lread):
2805 * macros.c (syms_of_macros):
2806 * msdos.c (syms_of_msdos):
2807 * print.c (syms_of_print):
2808 * process.c (syms_of_process):
2809 * search.c (syms_of_search):
2810 * sound.c (syms_of_sound):
2811 * syntax.c (init_syntax_once, syms_of_syntax):
2812 * terminal.c (syms_of_terminal):
2813 * textprop.c (syms_of_textprop):
2814 * undo.c (syms_of_undo):
2815 * w32.c (globals_of_w32):
2816 * window.c (syms_of_window):
2817 * xdisp.c (syms_of_xdisp):
2818 * xfaces.c (syms_of_xfaces):
2819 * xfns.c (syms_of_xfns):
2820 * xmenu.c (syms_of_xmenu):
2821 * xsettings.c (syms_of_xsettings):
2822 * xterm.c (syms_of_xterm): Use DEFSYM.
2823
4228cf16
TZ
28242011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2825
cd3520a4 2826 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2827
7fcccf1e
PE
28282011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2829
7efb4e0e
PE
2830 Integer and buffer overflow fixes (Bug#8873).
2831
ff5844ad
PE
2832 * print.c (printchar, strout): Check for string overflow.
2833 (PRINTPREPARE, printchar, strout):
2834 Don't set size unless allocation succeeds.
2835
90532f02
PE
2836 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2837 for sizes. Check for string overflow more accurately.
2838 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2839
6d84508d
PE
2840 * macros.c: Integer and buffer overflow fixes.
2841 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2842 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2843 Use ptrdiff_t, not int, for sizes.
2844 Don't increment bufsize until after realloc succeeds.
2845 Check for size-calculation overflow.
2846 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2847
437b2cb4
PE
2848 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2849
8b9ac8b4
PE
2850 * lread.c: Integer overflow fixes.
2851 (read_integer): Radix is now EMACS_INT, not int,
2852 to improve quality of diagnostics for out-of-range radices.
2853 Calculate buffer size correctly for out-of-range radices.
2854 (read1): Check for integer overflow in radices, and in
2855 read-circle numbers.
82cb60d3
PE
2856 (read_escape): Avoid int overflow.
2857 (Fload, openp, read_buffer_size, read1)
2858 (substitute_object_recurse, read_vector, read_list, map_obarray):
2859 Use ptrdiff_t, not int, for sizes.
2860 (read1): Use EMACS_INT, not int, for sizes.
20270765 2861 Check for size overflow.
8b9ac8b4 2862
7fcccf1e
PE
2863 * image.c (cache_image): Check for size arithmetic overflow.
2864
bfbbd7e7
PE
2865 * lread.c: Integer overflow issues.
2866 (saved_doc_string_size, saved_doc_string_length)
2867 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2868 Now ptrdiff_t, not int.
2869 (read1): Don't assume doc string length fits in int. Check for
2870 out-of-range doc string lengths.
2871 (read_list): Don't assume file position fits in int.
39019e54 2872 (read_escape): Check for hex character overflow.
bfbbd7e7 2873
4e323265
LL
28742011-06-22 Leo Liu <sdl.web@gmail.com>
2875
2876 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2877 Move to minibuffer.el.
2878
85fece3e
PE
28792011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2880
20b84ce9 2881 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2882 The following patches are for when GLYPH_DEBUG && !XASSERT.
2883 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2884 * dispnew.c (flush_stdout):
2885 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2886 Mark as externally visible.
2887 * dispnew.c (check_window_matrix_pointers): Now static.
2888 * dispnew.c (window_to_frame_vpos):
2889 * xfns.c (unwind_create_frame):
2890 * xterm.c (x_check_font): Remove unused local.
2891 * scroll.c (CHECK_BOUNDS):
2892 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2893 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2894 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2895 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2896 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2897 Now static.
2898 (debug_method_add): Use va_list and vsprintf rather than relying
2899 on undefined behavior with wrong number of arguments.
2900 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2901 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2902 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2903 since we're not interested in debugging glyphs with old libraries.
2904 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2905 GCC 4.6.0's static checking.
2906
0766b489
PE
29072011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2908
31fd4b32
PE
2909 Integer overflow and signedness fixes (Bug#8873).
2910 A few related buffer overrun fixes, too.
2911
b79e8648
PE
2912 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2913
0766b489
PE
2914 * dispextern.h (struct face.stipple):
2915 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2916 (x_bitmap_mask, x_allocate_bitmap_record)
2917 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2918 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2919 (x_create_bitmap_from_xpm_data):
2920 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2921 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2922 (.bitmaps_last):
2923 * xfaces.c (load_pixmap):
2924 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2925 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2926 (.bitmaps_last, struct x_output.icon_bitmap):
2927 Use ptrdiff_t, not int, for bitmap indexes.
2928 (x_allocate_bitmap_record): Check for size overflow.
2929 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2930
b081724f
PE
2931 Use ptrdiff_t, not int, for overlay counts.
2932 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2933 * editfns.c (overlays_around, get_pos_property):
2934 * textprop.c (get_char_property_and_overlay):
2935 * xdisp.c (next_overlay_change, note_mouse_highlight):
2936 * xfaces.c (face_at_buffer_position):
21514da7
PE
2937 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2938 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2939 (Fnext_overlay_change, Fprevious_overlay_change)
2940 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2941 Use ptrdiff_t, not int, for sizes.
21514da7 2942 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2943
3de73e5e
PE
2944 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2945
2606c57b
PE
2946 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2947 (x_session_initialize): Do not assume string length fits in int.
2948
aaafe47a
PE
2949 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2950 This is unlikely, but can occur if DPI is outlandish.
2951
2674ddc8 2952 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2953 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2954
28154962
PE
2955 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2956 * xrdb.c (magic_file_p, search_magic_path):
2957 Omit last arg SUFFIX; it was always 0. All callers changed.
2958 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2959
7de51af5
PE
2960 * xfont.c (xfont_match): Avoid need for strlen.
2961
25ed6cc3
PE
2962 * xfns.c: Don't assume strlen fits in int.
2963 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2964
4eab31dd
PE
2965 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2966 not unsigned long, as we prefer signed integers. All callers changed.
2967 Detect integer overflow in repeat count.
2968 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2969 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2970
171e2a58
PE
2971 * termcap.c: Don't assume sizes fit in int and never overflow.
2972 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2973 (gobble_line): Check for size-calculation overflow.
2974
ad39faca 2975 * minibuf.c (Fread_buffer):
6e5bb2dc 2976 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2977 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2978 Don't assume string length fits in int.
2979
52c61c22 2980 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2981 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2982
b5b8c9e5
PE
2983 * font.c: Don't assume string length fits in int.
2984 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2985 Use ptrdiff_t, not int.
ccd6111c
PE
2986 (font_intern_prop): Don't assume string length fits in int.
2987 Don't assume integer property fits in fixnum.
2988 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2989
882f0d81 2990 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2991 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2992 Reformulate so as not to need the command string.
2993 Invoke gzip -cd rather than gunzip, as it's more portable.
2994 (lock_info_type, lock_file_1, lock_file):
2995 Don't assume pid_t and time_t fit in unsigned long.
2996 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2997 (current_lock_owner): Prefer signed type for sizes.
2998 Use memcpy, not strncpy, where memcpy is what is really wanted.
2999 Don't assume (via atoi) that time_t and pid_t fit in int.
3000 Check for time_t and/or pid_t out of range, e.g., via a network share.
3001 Don't alloca where an auto var works fine.
3002
93f4cf88
PE
3003 * fileio.c: Fix some integer overflow issues.
3004 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3005 Don't assume string length fits in int.
3006 (directory_file_name): Don't assume string length fits in long.
3007 (make_temp_name): Don't assume pid fits in int, or that its print
3008 length is less than 20.
3009
f3e92b69
PE
3010 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3011
1bfdaf10
PE
3012 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3013
35016e9a
PE
3014 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3015
3d1e65a1
PE
3016 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3017 We prefer signed integers, even for size calculations.
3018
0b963a93
PE
3019 * emacs.c: Don't assume string length fits in 'int'.
3020 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3021 (main): Don't invoke strlen when not needed.
3022
573f4b54
PE
3023 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3024 (XD_DEBUG_MESSAGE): Don't waste a byte.
3025
989f33ba
PE
3026 * callproc.c (getenv_internal_1, getenv_internal)
3027 (Fgetenv_internal):
965d34eb
PE
3028 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3029
e4d29b33
PE
3030 * lread.c (invalid_syntax): Omit length argument.
3031 All uses changed. This doesn't fix a bug, but it simplifies the
3032 code away from its former Hollerith-constant appearance, and it's
3033 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3034 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3035
eb49b136
PE
3036 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3037 This didn't break anything, but it didn't help either.
3038 It's confusing to put a bogus integer in a place where the actual
3039 value does not matter.
9f62aeb1 3040 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3041 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3042
15375a22
PE
3043 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3044 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3045 implementation.
b61cc01c
PE
3046 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3047 We prefer signed types, and the value cannot exceed the EMACS_INT
3048 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3049 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3050 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3051 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3052
53b2623d
PE
3053 * indent.c (sane_tab_width): New function.
3054 (current_column, scan_for_column, Findent_to, position_indentation)
3055 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3056 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3057
51cab52b 3058 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3059
f2ed8a70
PE
3060 * lisp.h (lint_assume): New macro.
3061 * composite.c (composition_gstring_put_cache):
3062 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3063
abe80cc6
PE
3064 * editfns.c, insdel.c:
3065 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3066
b02c740e
PE
3067 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3068
ebc96716
PE
3069 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3070
b4e50fa0 3071 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3072 Use much-faster test for byte-length change.
311d5d7c 3073 Don't assume string byte-length fits in 'int'.
a4cf38e4 3074 Check that character arg fits in 'int'.
85461888 3075 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3076
c0c1ee9f
PE
3077 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3078
a498d7f4
PE
3079 * fns.c (concat): Catch string overflow earlier.
3080 Do not rely on integer wraparound.
3081
51cab52b
PE
3082 * dispextern.h (struct it.overlay_strings_charpos)
3083 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3084 * xdisp.c (forward_to_next_line_start)
3085 (back_to_previous_visible_line_start)
3086 (reseat_at_next_visible_line_start, next_element_from_buffer):
3087 Don't arbitrarily truncate the value of 'selective' to int.
3088
76031fad
PE
3089 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3090
5eb55db9
PE
3091 * composite.c: Don't truncate sizes to 'int'.
3092 (composition_gstring_p, composition_reseat_it)
3093 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3094 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3095 not EMACS_UINT, for indexes.
5eb55db9 3096
0703a717
PE
3097 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3098
d6202519
PE
3099 * buffer.c: Include <verify.h>.
3100 (struct sortvec.priority, struct sortstr.priority):
8961a454 3101 Now EMACS_INT, not int.
c20998a7 3102 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3103 (struct sortstr.size, record_overlay_string)
3104 (struct sortstrlist.size, struct sortlist.used):
3105 Don't truncate size to int.
3106 (record_overlay_string): Check for size-calculation overflow.
d6202519 3107 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3108
d5a19415
JM
31092011-06-22 Jim Meyering <meyering@redhat.com>
3110
029529ac 3111 Don't leak an XBM-image-sized buffer
d5a19415
JM
3112 * image.c (xbm_load): Free the image buffer after using it.
3113
a9041e6c
PE
31142011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3115
3116 Port to Sun C.
3117 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3118 that Sun C diagnosed.
3119 * fns.c (secure_hash): Fix pointer signedness issue.
3120 * intervals.c (static_offset_intervals): New function.
3121 (offset_intervals): Use it.
3122
7f3f739f
LL
31232011-06-21 Leo Liu <sdl.web@gmail.com>
3124
3125 * deps.mk (fns.o):
3126 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3127 sha512.h.
3128
3129 * fns.c (secure_hash): Rename from crypto_hash_function and change
3130 the first arg to accept symbols.
5b66d427 3131 (Fsecure_hash): New primitive.
7f3f739f
LL
3132 (syms_of_fns): New symbols.
3133
76147d94
DD
31342011-06-20 Deniz Dogan <deniz@dogan.se>
3135
3136 * process.c (Fset_process_buffer): Clarify return value in
3137 docstring.
3138
7d7d0045
CY
31392011-06-18 Chong Yidong <cyd@stupidchicken.com>
3140
3141 * dispnew.c (add_window_display_history): Use BVAR.
3142
3143 * xdisp.c (debug_method_add): Use BVAR.
3144 (check_window_end, dump_glyph_matrix, dump_glyph)
3145 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3146
3147 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3148 Likewise.
3149
3150 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3151 check till after the cache is created in init_frame_faces.
3152
ff2bc410
SM
31532011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3154
3155 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3156
28177add
PE
31572011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3158
dd3482fe
PE
3159 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3160 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3161 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3162
393d71f3 3163 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3164 * fileio.c (Finsert_file_contents):
3165 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3166 Remove the old (too-loose) buffer overflow checks.
3167 They weren't needed, since make_gap checks for buffer overflow.
3168 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3169 The old code merely checked for Emacs fixnum overflow, and relied
3170 on undefined (wraparound) behavior. The new code avoids undefined
3171 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3172
2e6813b0 3173 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3174 Tune. Don't use wider integers than needed. Don't use alloca.
3175 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3176
599a9e4f
PE
3177 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3178
99561444
PE
3179 * insdel.c, lisp.h (buffer_overflow): New function.
3180 (insert_from_buffer_1, replace_range, replace_range_2):
3181 * insdel.c (make_gap_larger):
3182 * editfns.c (Finsert_char):
3183 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3184
28177add
PE
3185 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3186
e69dafad
PE
31872011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3188
a7af7fde 3189 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3190
b1c46f02
PE
3191 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3192 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3193
e69dafad
PE
3194 * fileio.c: Don't assume EMACS_INT fits in off_t.
3195 (emacs_lseek): New static function.
3196 (Finsert_file_contents, Fwrite_region): Use it.
3197 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3198
566684ea
PE
3199 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3200
e6966cd6
PE
3201 * fns.c: Don't overflow int when computing a list length.
3202 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3203 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3204 truncation on 64-bit hosts. Check for QUIT every
3205 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3206 faster and is responsive enough.
3207 (Flength): Report an error instead of overflowing an integer.
3208 (Fsafe_length): Return a float if the value is not representable
3209 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3210 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3211 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3212
dd0b0efb
PE
3213 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3214 (header_size, word_size): New constants.
3215 (allocate_vectorlike): Don't check size overflow here.
3216 (allocate_vector): Check it here instead, since this is the only
3217 caller of allocate_vectorlike that could cause overflow.
3218 Check that the new vector's length is representable as a fixnum.
3219
86fe5cfe
PE
3220 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3221 The previous code was bogus. For example, next_almost_prime (32)
3222 returned 39, which is undesirable as it is a multiple of 3; and
3223 next_almost_prime (24) returned 25, which is a multiple of 5 so
3224 why was the code bothering to check for multiples of 7?
3225
80e88859
PE
3226 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3227
4a2f0ad6
PE
3228 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3229
f66c7cf8
PE
3230 Variadic C functions now count arguments with ptrdiff_t.
3231 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3232 Back then I didn't know that the Emacs coding style prefers signed int.
3233 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3234 were being counted with int, which may truncate counts on 64-bit
3235 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3236 * lisp.h (struct Lisp_Subr.function.aMANY)
3237 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3238 Arg counts are now ptrdiff_t, not size_t.
3239 All variadic functions and their callers changed accordingly.
3240 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3241 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3242 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3243 * callint.c (Fcall_interactively): Check arg count for overflow,
3244 to avoid potential buffer overrun. Use signed char, not 'int',
3245 for 'varies' array, so that we needn't bother to check its size
3246 calculation for overflow.
3247 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3248 * eval.c (apply_lambda):
3249 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3250 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3251 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3252
a1759b76
PE
3253 * callint.c (Fcall_interactively): Don't use index var as event count.
3254
d96be9fc
PE
3255 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3256 * mem-limits.h (SIZE): Remove; no longer used.
3257
a690a978 3258 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3259
578c21e6
PE
3260 Remove unnecessary casts.
3261 * xterm.c (x_term_init):
3262 * xfns.c (x_set_border_pixel):
3263 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3264 These aren't needed now that we assume ANSI C.
3265
96f53c6c
PE
3266 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3267 It's more likely to cause problems (due to unsigned overflow)
3268 than to cure them.
3269
83c77d31
PE
3270 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3271
ee2079f1
PE
3272 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3273
6da65536
PE
3274 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3275
7147c4a4
PE
3276 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3277
193e32d9
PE
3278 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3279
e5533da6
PE
3280 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3281
9910e595
PE
3282 GLYPH_CODE_FACE returns EMACS_INT, not int.
3283 * dispextern.h (merge_faces):
3284 * xfaces.c (merge_faces):
01103c44
PE
3285 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3286 Don't assume EMACS_INT fits in int.
9910e595 3287
2638320e
PE
3288 * character.h (CHAR_VALID_P): Remove unused parameter.
3289 * fontset.c, lisp.h, xdisp.c: All uses changed.
3290
045eb8d9
PE
3291 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3292
c1f134b5
PE
3293 * fns.c (concat): Minor tuning based on overflow analysis.
3294 This doesn't fix any bugs. Use int to hold character, instead
3295 of constantly refetching from Emacs object. Use XFASTINT, not
3296 XINT, for value known to be a character. Don't bother comparing
3297 a single byte to 0400, as it's always less.
3298
395fcb93 3299 * floatfns.c (Fexpt):
327eeec8
PE
3300 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3301
abbd3d23
PE
3302 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3303 for characters.
3304
684a03ef
PE
3305 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3306
0fed43f3
PE
3307 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3308 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3309 incorrectly succeed when S was a string, because 4294967386 was
3310 truncated before it was used.
3311
8fd02eb7
PE
3312 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3313 Otherwise, an out-of-range integer could cause undefined behavior
3314 on a 64-bit host.
3315
f8c86b69
PE
3316 * composite.c: Use int, not EMACS_INT, for characters.
3317 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3318 EMACS_INT, for values that are known to be in character range.
3319 This doesn't fix any bugs but is the usual style inside Emacs and
3320 may generate better code on 32-bit machines.
3321
34206dd2
PE
3322 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3323 This is for reasons similar to the recent CHAR_STRING fix.
3324 * charset.c (Fencode_char): Check that character arg is actually
3325 a character. Pass an int to ENCODE_CHAR.
3326 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3327 wider than 'int', as a compile-time check to prevent future regressions
3328 in this area.
3329
c5958d4c 3330 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3331
3332 Make sure a 64-bit char is never passed to CHAR_STRING.
3333 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3334 by silently ignoring the top 32 bits, allowing some values
3335 that were far too large to be valid characters.
3336 * character.h: Include <verify.h>.
3337 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3338 arguments are no wider than unsigned, as a compile-time check
3339 to prevent future regressions in this area.
3340 * data.c (Faset):
01103c44 3341 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3342 (Fsubst_char_in_region):
3343 * fns.c (concat):
3344 * xdisp.c (decode_mode_spec_coding):
3345 Adjust to CHAR_STRING's new requirement.
3346 * editfns.c (Finsert_char, Fsubst_char_in_region):
3347 * fns.c (concat): Check that character args are actually
3348 characters. Without this test, these functions did the wrong
3349 thing with wildly out-of-range values on 64-bit hosts.
3350
d37ca623
PE
3351 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3352 These casts should not be needed on 32-bit hosts, either.
3353 * keyboard.c (read_char):
3354 * lread.c (Fload): Remove casts to unsigned.
3355
ea204efb
PE
3356 * lisp.h (UNSIGNED_CMP): New macro.
3357 This fixes comparison bugs on 64-bit hosts.
3358 (ASCII_CHAR_P): Use it.
3359 * casefiddle.c (casify_object):
01103c44 3360 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3361 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3362 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3363 * dispextern.h (FACE_FROM_ID):
3364 * keyboard.c (read_char): Use UNSIGNED_CMP.
3365
41cb286c
PE
3366 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3367 not to EMACS_INT, to avoid GCC warning.
3368
4a1b9832
PE
3369 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3370
55daad71
PE
3371 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3372 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3373 isn't needed on 32-bit machines.
8f95c75c 3374
01103c44
PE
3375 * buffer.c (Fgenerate_new_buffer_name):
3376 Use EMACS_INT for count, not int.
0ceccced 3377 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3378
3379 * data.c (Qcompiled_function): Now static.
3380
c6f072e7
PE
3381 * window.c (window_body_lines): Now static.
3382
20ce5912
PE
3383 * image.c (gif_load): Rename local to avoid shadowing.
3384
9c4c5f81
PE
3385 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3386 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3387 * alloc.c (make_save_value): Integer argument is now of type
3388 ptrdiff_t, not int.
3389 (mark_object): Use ptrdiff_t, not int.
3390 * lisp.h (pD): New macro.
3391 * print.c (print_object): Use it.
3392
c0c5c8ae
PE
3393 * alloc.c: Use EMACS_INT, not int, to count objects.
3394 (total_conses, total_markers, total_symbols, total_vector_size)
3395 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3396 (total_free_floats, total_floats, total_free_intervals)
3397 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3398 Now EMACS_INT, not int. All uses changed.
3399 (Fgarbage_collect): Compute overall total using a double, so that
3400 integer overflow is less likely to be a problem. Check for overflow
3401 when converting back to an integer.
5a25e253
PE
3402 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3403 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3404 These were 'int' variables that could overflow on 64-bit hosts;
3405 they were never used, so remove them instead of repairing them.
211a0b2a 3406 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3407 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3408 Previously, this ceilinged at INT_MAX, but that doesn't work on
3409 64-bit machines.
e46bb31a 3410 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3411
c78baabf 3412 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3413 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3414 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3415 when a (possibly-narrower) signed value would do just as well.
3416 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3417
c9d624c6
PE
3418 * alloc.c: Catch some string size overflows that we were missing.
3419 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3420 for convenience in STRING_BYTES_MAX.
3421 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3422 The definition here is exact; the one in lisp.h was approximate.
3423 (allocate_string_data): Check for string overflow. This catches
3424 some instances we weren't catching before. Also, it catches
3425 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3426 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3427 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3428
c9d624c6
PE
3429 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3430 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3431 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3432
353032ce
PE
3433 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3434
2bccce07
PE
3435 * alloc.c (Fmake_string): Check for out-of-range init.
3436
0ac30604
SM
34372011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3438
3439 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3440
c195f2de
JD
34412011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3442
3443 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3444 xg_get_default_scrollbar_width.
3445
3446 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3447 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3448 (style_changed_cb): Call update_theme_scrollbar_width and call
3449 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3450 all frames (Bug#8505).
3451 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3452 Call gtk_window_set_resizable if HAVE_GTK3.
3453 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3454 and height if HAVE_GTK3 (Bug#8505).
3455 (scroll_bar_width_for_theme): New variable.
3456 (update_theme_scrollbar_width): New function.
3457 (xg_get_default_scrollbar_width): Move code to
3458 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3459 (xg_initialize): Call update_theme_scrollbar_width.
3460
3461 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3462
3463 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3464
e10ac9f1
MR
34652011-06-12 Martin Rudalics <rudalics@gmx.at>
3466
3467 * frame.c (make_frame): Call other_buffer_safely instead of
3468 other_buffer.
3469
3470 * window.c (temp_output_buffer_show): Call display_buffer with
3471 second argument Vtemp_buffer_show_specifiers and reset latter
3472 immediately after the call.
3473 (Vtemp_buffer_show_specifiers): New variable.
3474 (auto_window_vscroll_p, next_screen_context_lines)
3475 (Vscroll_preserve_screen_position): Remove leading asterisks from
3476 doc-strings.
3477
2d3c217e 34782011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3479
7b7f97e8 3480 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3481 * buffer.c (Qclone_number): Remove for now, as it's unused.
3482 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3483 (record_buffer): Remove unused local.
3484 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3485 (set_frame_buffer_list): Remove; unused.
3486 * frame.h (other_visible_frames): Remove decl.
3487 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3488 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3489 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3490 if HAVE_GPM.
3491 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3492 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3493 Define only if HAVE_GPM.
3494 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3495 (update_hints_inhibit): Remove; never set. All uses removed.
3496 * widgetprv.h (emacsFrameClassRec): Remove decl.
3497 * window.c (delete_deletable_window): Now returns void, since it
3498 wasn't returning anything.
3499 (compare_window_configurations): Remove unused locals.
3500 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3501 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3502 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3503 the same widths as pointers. This follows up on the 2011-05-06 patch.
3504 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3505 * xterm.h: Likewise.
3506 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3507
1384b89e
JB
35082011-06-12 Juanma Barranquero <lekktu@gmail.com>
3509
3510 * makefile.w32-in: Update dependencies.
3511 (LISP_H): Add lib/intprops.h.
3512
1100a63c
CY
35132011-06-11 Chong Yidong <cyd@stupidchicken.com>
3514
3515 * image.c (gif_load): Add animation frame delay to the metadata.
3516 (syms_of_image): Use DEFSYM. New symbol `delay'.
3517
6198ccd0
MR
35182011-06-11 Martin Rudalics <rudalics@gmx.at>
3519
3520 * window.c (delete_deletable_window): Re-add.
3521 (Fset_window_configuration): Rewrite to handle dead buffers and
3522 consequently deletable windows.
3523 (window_tree, Fwindow_tree): Remove. Supply functionality in
3524 window.el.
3525 (compare_window_configurations): Simplify code.
3526
b6e3633c
AS
35272011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3528
1ab0dee5
AS
3529 * image.c (imagemagick_load_image): Fix type mismatch.
3530 (Fimagemagick_types): Likewise.
3531
b6e3633c
AS
3532 * window.h (replace_buffer_in_windows): Declare.
3533
9397e56f
MR
35342011-06-11 Martin Rudalics <rudalics@gmx.at>
3535
3536 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3537 Qclone_number. Remove external declaration of Qdelete_window.
3538 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3539 code.
640c8776
SM
3540 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3541 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3542 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3543 buffer list implementation.
3544 (other_buffer_safely): New function.
3545 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3546 calls to replace_buffer_in_windows and
3547 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3548 if allowed.
3549 (record_buffer): Inhibit quitting and rewrite using quittable
3550 functions. Run Qbuffer_list_update_hook if allowed.
3551 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3552 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3553 Move switch-to-buffer to window.el.
9397e56f
MR
3554 (bury-buffer): Move to window.el.
3555 (Vbuffer_list_update_hook): New variable.
3556
3557 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3558 section.
3559
3560 * window.h (resize_frame_windows): Move up in code.
3561 (Fwindow_frame): Remove EXFUN.
3562 (replace_buffer_in_all_windows): Remove prototype.
3563 (replace_buffer_in_windows_safely): Add prototype.
3564
3565 * window.c: Declare Qdelete_window static again. Move down
3566 declaration of select_count.
3567 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3568 (Fother_window): Move to window.el.
3569 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3570 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3571 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3572 window.el.
3573 (replace_buffer_in_windows): Implement by calling
3574 Qreplace_buffer_in_windows.
3575 (replace_buffer_in_all_windows): Remove with some functionality
3576 moved into replace_buffer_in_windows_safely.
3577 (replace_buffer_in_windows_safely): New function.
3578 (select_window_norecord, select_frame_norecord): Move in front
3579 of run_window_configuration_change_hook. Remove now obsolete
3580 declarations.
640c8776
SM
3581 (Fset_window_buffer): Rewrite doc-string.
3582 Call Qrecord_window_buffer.
9397e56f
MR
3583 (keys_of_window): Move binding for other-window to window.el.
3584
b50691aa
CY
35852011-06-11 Chong Yidong <cyd@stupidchicken.com>
3586
3587 * dispextern.h (struct image): Replace data member, whose int_val
3588 and ptr_val fields were not used by anything, with a single
3589 lisp_val object.
3590
3591 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3592 (gif_clear_image, gif_load, imagemagick_load_image)
3593 (gs_clear_image, gs_load): Callers changed.
3594
3f754b86
PE
35952011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3596
cca69397
PE
3597 * buffer.h: Include <time.h>, for time_t.
3598 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3599
109e28d0
PE
3600 Fix minor problems found by static checking.
3601
60737f02
PE
3602 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3603
4b66faf3
PE
3604 Make identifiers static if they are not used in other modules.
3605 * data.c (Qcompiled_function, Qframe, Qvector):
3606 * image.c (QimageMagick, Qsvg):
3607 * minibuf.c (Qmetadata):
3608 * window.c (resize_window_check, resize_root_window): Now static.
3609 * window.h (resize_window_check, resize_root_window): Remove decls.
3610
109e28d0
PE
3611 * window.c (window_deletion_count, delete_deletable_window):
3612 Remove; unused.
46a4ce9e
PE
3613 (window_body_lines): Now static.
3614 (Fdelete_other_windows_internal): Mark vars as initialized.
3615 Make sure 'resize_failed' is initialized.
3616 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3617 (resize_window_apply): Remove unused local.
3618 * window.h (delete_deletable_window): Remove decl.
3619
109e28d0 3620 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3621 (imagemagick_load_image): Fix pointer signedness problem by changing
3622 last arg from unsigned char * to char *. All uses changed.
3623 Also, fix a local for similar reasons.
3624 Remove unused locals. Remove locals to avoid shadowing.
3625 (fn_rsvg_handle_free): Remove; unused.
3626 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3627 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3628
3f754b86
PE
3629 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3630
2547adb1
CY
36312011-06-10 Chong Yidong <cyd@stupidchicken.com>
3632
3633 * image.c (gif_load): Fix omitted cast error introduced by
3634 2011-06-06 change.
3635
2c8e37d4
MR
36362011-06-10 Martin Rudalics <rudalics@gmx.at>
3637
3638 * window.h (resize_proportionally, orig_total_lines)
3639 (orig_top_line): Remove from window structure.
3640 (set_window_height, set_window_width, change_window_heights)
3641 (Fdelete_window): Remove prototypes.
3642 (resize_frame_windows): Remove duplicate declaration.
3643
440a42e3
EZ
36442011-06-10 Eli Zaretskii <eliz@gnu.org>
3645
3646 * window.h (resize_frame_windows, resize_window_check)
3647 (delete_deletable_window, resize_root_window)
3648 (resize_frame_windows): Declare prototypes.
3649
3650 * window.c (resize_window_apply): Make definition be "static" to
3651 match the prototype.
3652
562dd5e9
MR
36532011-06-10 Martin Rudalics <rudalics@gmx.at>
3654
3655 * window.c: Remove declarations of Qwindow_size_fixed,
3656 window_min_size_1, window_min_size_2, window_min_size,
3657 size_window, window_fixed_size_p, enlarge_window, delete_window.
3658 Remove static from declaration of Qdelete_window, it's
3659 temporarily needed by Fbury_buffer.
3660 (replace_window): Don't assign orig_top_line and
3661 orig_total_lines.
3662 (Fdelete_window, delete_window): Remove. Window deletion is
3663 handled by window.el.
640c8776
SM
3664 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3665 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3666 (Fdelete_other_windows): Remove. Deleting other windows is
3667 handled by window.el.
3668 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3669 handled in window.el.
3670 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3671 Window minimum sizes are handled in window.el.
3672 (shrink_windows, size_window, set_window_height)
3673 (set_window_width, change_window_heights, window_height)
3674 (window_width, CURBEG, CURSIZE, enlarge_window)
3675 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3676 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3677 handled in window.el.
3678 (make_dummy_parent): Rename to make_parent_window and give it a
3679 second argument horflag.
3680 (make_window): Don't set resize_proportionally any more.
3681 (Fsplit_window): Remove. Windows are split in window.el.
3682 (save_restore_action, save_restore_orig_size)
3683 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3684 Resize mini windows in window.el.
3685 (grow_mini_window, shrink_mini_window): Implement by calling
3686 Qresize_root_window_vertically, resize_window_check and
3687 resize_window_apply.
640c8776
SM
3688 (saved_window, Fset_window_configuration, save_window_save):
3689 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3690 resize_proportionally.
3691 (window_min_height, window_min_width): Move to window.el.
3692 (keys_of_window): Move bindings for delete-other-windows,
3693 split-window, delete-window and enlarge-window to window.el.
3694
3695 * buffer.c: Temporarily extern Qdelete_window.
3696 (Fbury_buffer): Temporarily call Qdelete_window instead of
3697 Fdelete_window (Fbury_buffer will move to window.el soon).
3698
3699 * frame.c (set_menu_bar_lines_1): Remove code handling
3700 orig_top_line and orig_total_lines.
3701
3702 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3703 set_window_height but set heights directly.
3704 (change_frame_size_1): Use resize_frame_windows.
3705
3706 * xdisp.c (init_xdisp): Don't use set_window_height but set
3707 heights directly.
3708
640c8776
SM
3709 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3710 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3711 run_window_configuration_change_hook.
3712
3713 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3714 instead of change_window_heights and run
3715 run_window_configuration_change_hook.
3716
1a13852e
MR
37172011-06-09 Martin Rudalics <rudalics@gmx.at>
3718
3719 * window.c (replace_window): Rename second argument REPLACEMENT to
3720 NEW. New third argument SETFLAG. Rewrite.
3721 (delete_window, make_dummy_parent): Call replace_window with
3722 third argument 1.
3723 (window_list_1): Move down in code.
3724 (run_window_configuration_change_hook): Move set_buffer part
3725 before select_frame_norecord part in order to unwind correctly.
3726 Rename count1 to count.
3727 (recombine_windows, delete_deletable_window, resize_root_window)
3728 (Fdelete_other_windows_internal)
3729 (Frun_window_configuration_change_hook, make_parent_window)
3730 (resize_window_check, resize_window_apply, Fresize_window_apply)
3731 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3732 (Fdelete_window_internal, Fresize_mini_window_internal):
3733 New functions.
1a13852e
MR
3734 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3735
f3d1777e
MR
37362011-06-08 Martin Rudalics <rudalics@gmx.at>
3737
496e208e
MR
3738 * window.h (window): Add some new members to window structure -
3739 normal_lines, normal_cols, new_total, new_normal, clone_number,
3740 splits, nest, prev_buffers, next_buffers.
3741 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3742 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3743
f3d1777e
MR
3744 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3745 Remove.
496e208e
MR
3746 (make_dummy_parent): Set new members of windows structure.
3747 (make_window): Move down in code. Handle new members of window
3748 structure.
3749 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3750 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3751 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3752 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3753 (Fset_window_next_buffers, Fset_window_clone_number):
3754 New functions.
496e208e
MR
3755 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3756 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3757 Doc-string fixes.
3758 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3759 Argument WINDOW can be now internal window too.
3760 (Fwindow_use_time): Move up in code.
3761 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3762 Rewrite doc-string.
3763 (Fset_window_configuration, saved_window)
3764 (Fcurrent_window_configuration, save_window_save): Handle new
3765 members of window structure.
b9e809c2
MR
3766 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3767 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3768 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3769 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3770 Qget_mru_window, Qresize_root_window,
3771 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3772 Qauto_buffer_name; staticpro them.
f3d1777e 3773
abde8f8c
MR
37742011-06-07 Martin Rudalics <rudalics@gmx.at>
3775
3776 * window.c (Fwindow_total_size, Fwindow_left_column)
3777 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3778 (Fwindow_list_1): New functions.
3779 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3780 (Fwindow_width, Fscroll_left, Fscroll_right):
3781 Use window_body_cols instead of window_box_text_cols.
3782 (delete_window, Fset_window_configuration):
3783 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3784 (delete_all_subwindows): Take a window as argument and not a
3785 structure. Rewrite.
190b47e6
MR
3786 (window_loop): Remove handling of GET_LRU_WINDOW and
3787 GET_LARGEST_WINDOW.
3788 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3789
3790 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3791 window_box_text_cols. delete_all_subwindows now takes a
3792 Lisp_Object as argument.
abde8f8c 3793
640c8776
SM
3794 * indent.c (compute_motion, Fcompute_motion):
3795 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3796
fa8a67e6
MR
3797 * frame.c (delete_frame): Call delete_all_subwindows with root
3798 window as argument.
3799
a54e3482
DC
38002011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3801
3802 * fns.c (Fputhash): Document return value.
3803
60002bf5
CY
38042011-06-06 Chong Yidong <cyd@stupidchicken.com>
3805
3806 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3807
0c671da6 38082011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3809
b862a52a 3810 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3811
be44ca6c
PE
3812 Check for overflow when converting integer to cons and back.
3813 * charset.c (Fdefine_charset_internal, Fdecode_char):
3814 Use cons_to_unsigned to catch overflow.
3815 (Fencode_char): Use INTEGER_TO_CONS.
3816 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3817 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3818 * data.c (long_to_cons, cons_to_long): Remove.
3819 (cons_to_unsigned, cons_to_signed): New functions.
3820 These signal an error for invalid or out-of-range values.
3821 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3822 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3823 * font.c (Ffont_variation_glyphs):
3824 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3825 * lisp.h: Include <intprops.h>.
3826 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3827 (cons_to_signed, cons_to_unsigned): New decls.
3828 (long_to_cons, cons_to_long): Remove decls.
3829 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3830 (Fprimitive_undo): Use CONS_TO_INTEGER.
3831 * xfns.c (Fx_window_property): Likewise.
3832 * xselect.c: Include <limits.h>.
3833 (x_own_selection, selection_data_to_lisp_data):
3834 Use INTEGER_TO_CONS.
3835 (x_handle_selection_request, x_handle_selection_clear)
3836 (x_get_foreign_selection, Fx_disown_selection_internal)
3837 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3838 (lisp_data_to_selection_data): Use cons_to_unsigned.
3839 (x_fill_property_data): Use cons_to_signed.
3840 Report values out of range.
3841
d1f3d2af
PE
3842 Check for buffer and string overflow more precisely.
3843 * buffer.h (BUF_BYTES_MAX): New macro.
3844 * lisp.h (STRING_BYTES_MAX): New macro.
3845 * alloc.c (Fmake_string):
3846 * character.c (string_escape_byte8):
3847 * coding.c (coding_alloc_by_realloc):
3848 * doprnt.c (doprnt):
3849 * editfns.c (Fformat):
3850 * eval.c (verror):
3851 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3852 since they may not be the same number.
3853 * editfns.c (Finsert_char):
3854 * fileio.c (Finsert_file_contents):
3855 Likewise for BUF_BYTES_MAX.
3856
dd52fcea
PE
3857 * image.c: Use ptrdiff_t, not int, for sizes.
3858 (slurp_file): Switch from int to ptrdiff_t.
3859 All uses changed.
3860 (slurp_file): Check that file size fits in both size_t (for
3861 malloc) and ptrdiff_t (for sanity and safety).
3862
7f9bbdbb
PE
3863 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3864 if b->modtime has its maximal value.
3865
dfe18f82
PE
3866 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3867
84acfcf0
PE
3868 Don't assume time_t can fit into int.
3869 * buffer.h (struct buffer.modtime): Now time_t, not int.
3870 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3871 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3872
ccd9a01a
PE
3873 Minor fixes for signed vs unsigned integers.
3874 * character.h (MAYBE_UNIFY_CHAR):
3875 * charset.c (maybe_unify_char):
3876 * keyboard.c (read_char, reorder_modifiers):
3877 XINT -> XFASTINT, since the integer must be nonnegative.
3878 * ftfont.c (ftfont_spec_pattern):
3879 * keymap.c (access_keymap, silly_event_symbol_error):
3880 XUINT -> XFASTINT, since the integer must be nonnegative.
3881 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3882 since it makes no difference and we prefer signed.
3883 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3884 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3885 nonnegative.
3886
d6d100dd
SM
38872011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3888
3889 * window.h (Fwindow_frame): Declare.
3890
2b6148e4
PE
38912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3892
3893 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3894 (SPARE_MEMORY): Always define.
3895 (LARGE_REQUEST): Remove.
3896 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3897
f230ecc9
MR
38982011-06-06 Martin Rudalics <rudalics@gmx.at>
3899
727e958e
MR
3900 * lisp.h: Move EXFUNS for Fframe_root_window,
3901 Fframe_first_window and Fset_frame_selected_window to window.h.
3902
3903 * window.h: Move EXFUNS for Fframe_root_window,
3904 Fframe_first_window and Fset_frame_selected_window here from
3905 lisp.h.
3906
3907 * frame.c (Fwindow_frame, Fframe_first_window)
3908 (Fframe_root_window, Fframe_selected_window)
3909 (Fset_frame_selected_window): Move to window.c.
3910 (Factive_minibuffer_window): Move to minibuf.c.
3911 (Fother_visible_frames_p): New function.
3912
3913 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3914
f230ecc9
MR
3915 * window.c (decode_window, decode_any_window): Move up in code.
3916 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3917 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3918 (Fwindow_buffer): Move up and rewrite doc-string.
3919 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3920 (Fwindow_prev): New functions.
727e958e
MR
3921 (Fwindow_frame): Move here from frame.c. Accept any window as
3922 argument.
3923 (Fframe_root_window, Fframe_first_window)
3924 (Fframe_selected_window): Move here from frame.c. Accept frame
3925 or arbitrary window as argument. Update doc-strings.
3926 (Fminibuffer_window): Move up in code.
3927 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3928 (Fset_frame_selected_window): Move here from frame.c.
3929 Marginal rewrite.
727e958e
MR
3930 (Fselected_window, select_window, Fselect_window): Move up in
3931 code. Minor doc-string fixes.
f230ecc9 3932
4d09bcf6
PE
39332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3934
3935 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3936 Do not assume that spare memory exists; that assumption is valid
3937 only if SYSTEM_MALLOC.
3938 (LARGE_REQUEST): New macro, so that the issue of large requests
3939 is separated from the issue of spare memory.
3940
810928a2
AS
39412011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3942
172418ad
AS
3943 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3944 format. (Bug#8806)
3945
43f862f7
AS
3946 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3947
810928a2
AS
3948 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3949 before statements.
3950
a059fe24
JD
39512011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3952
3953 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3954
3955 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3956
3957 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3958 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3959
989bf368
JB
39602011-06-05 Juanma Barranquero <lekktu@gmail.com>
3961
3962 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3963
4b80f674
CY
39642011-06-04 Chong Yidong <cyd@stupidchicken.com>
3965
3966 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3967 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3968 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3969 New error handlers.
4b80f674
CY
3970 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3971 Obey Vx_select_enable_clipboard_manager. Catch errors in
3972 x_clipboard_manager_save (Bug#8779).
3973 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3974 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3975
99a33b77 39762011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3977
3978 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3979
99a33b77 39802011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3981
3982 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3983 in the current matrix if keep_current_p is non-zero.
3984
8264569d
EZ
39852011-06-04 Eli Zaretskii <eliz@gnu.org>
3986
3987 * bidi.c (bidi_level_of_next_char): Fix last change.
3988
57f97249
EZ
39892011-06-03 Eli Zaretskii <eliz@gnu.org>
3990
fec2107c 3991 Support bidi reordering of text covered by display properties.
57f97249 3992
fec2107c
EZ
3993 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3994 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3995 (bidi_cache_search, bidi_cache_iterator_state)
3996 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3997 (bidi_level_of_next_char, bidi_move_to_visually_next):
3998 Support character positions inside a run of characters covered by a
fec2107c
EZ
3999 display string.
4000 (bidi_paragraph_init, bidi_resolve_explicit_1)
4001 (bidi_level_of_next_char): Call bidi_fetch_char and
4002 bidi_fetch_char_advance instead of FETCH_CHAR and
4003 FETCH_CHAR_ADVANCE.
4004 (bidi_init_it): Initialize new members.
4005 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4006 definitions.
4007 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4008 instead of using explicit *_CHAR codes.
d6d100dd
SM
4009 (bidi_resolve_explicit, bidi_resolve_weak):
4010 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4011 bidirectional text is supported only in multibyte buffers.
4012 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4013 it to initialize the frame_window_p member of struct bidi_it.
4014 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4015 (bidi_resolve_explicit, bidi_resolve_weak)
4016 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4017 bidi_it->nchars is non-positive.
4018 (bidi_level_of_next_char): Don't try to lookup the cache for the
4019 next/previous character if nothing is cached there yet, or if we
4020 were just reseat()'ed to a new position.
c40e2fb2 4021
0e14fe90
EZ
4022 * xdisp.c (set_cursor_from_row): Set start and stop points
4023 according to the row's direction when priming the loop that looks
4024 for the glyph on which to display cursor.
4025 (single_display_spec_intangible_p): Function deleted.
4026 (display_prop_intangible_p): Reimplement to call
4027 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4028 Accept 3 additional arguments needed by handle_display_spec.
4029 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4030 values: lists, `(when COND...)' forms, etc.
4031 (single_display_spec_string_p): Support property values that are
4032 lists with the argument STRING its top-level element.
4033 (display_prop_string_p): Fix the condition for processing a
4034 property that is a list to be consistent with handle_display_spec.
fec2107c 4035 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4036 last portion of handle_display_prop.
4037 (compute_display_string_pos): Accept additional argument
4038 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4039 value of a `display' property is a "replacing spec".
4040 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4041 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4042 the display property, but just return a value indicating whether
4043 the display property will replace the characters it covers.
4044 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4045 frame_window_p members of struct bidi_it.
d6d100dd
SM
4046 (compute_display_string_pos, compute_display_string_end):
4047 New functions.
fec2107c
EZ
4048 (push_it): Accept second argument POSITION, where pop_it should
4049 jump to continue iteration.
4050 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4051
fec2107c
EZ
4052 * keyboard.c (adjust_point_for_property): Adjust the call to
4053 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4054
4055 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4056 (bidi_init_it): Update prototypes.
4057 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4058 (compute_display_string_pos, compute_display_string_end):
4059 Declare prototypes.
fec2107c
EZ
4060 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4061 EMACS_INT.
fc6f18ce 4062
40087514 40632011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4064
57f53182
PE
4065 Malloc failure behavior now depends on size of allocation.
4066 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4067 * lisp.h: Change signatures accordingly.
4068 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4069 All callers changed. (Bug#8762)
4070
4071 * gnutls.c: Use Emacs's memory allocators.
4072 Without this change, the gnutls library would invoke malloc etc.
4073 directly, which causes problems on non-SYNC_INPUT hosts, and which
4074 runs afoul of improving memory_full behavior. (Bug#8761)
4075 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4076 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4077 xfree instead of the default malloc, realloc, free.
4078 (Fgnutls_boot): No need to check for memory allocation failure,
4079 since xmalloc does that for us.
4080
ac32cd99 4081 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4082 * category.c (hash_get_category_set):
4083 * ccl.c (ccl_driver):
4084 * charset.c (Fdefine_charset_internal):
4085 * charset.h (struct charset.hash_index):
4086 * composite.c (get_composition_id, gstring_lookup_cache)
4087 (composition_gstring_put_cache):
4088 * composite.h (struct composition.hash_index):
4089 * dispextern.h (struct image.hash):
4090 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4091 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4092 (hashfn_equal, hashfn_user_defined, make_hash_table)
4093 (maybe_resize_hash_table, hash_lookup, hash_put)
4094 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4095 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4096 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4097 * image.c (make_image, search_image_cache, lookup_image)
4098 (xpm_put_color_table_h):
4099 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4100 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4101 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4102 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4103 * alloc.c (allocate_vectorlike):
4104 Check for overflow in vector size calculations.
4105 * ccl.c (ccl_driver):
4106 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4107 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4108 need to be updated by these changes.
40087514
PE
4109 * fns.c (make_hash_table, maybe_resize_hash_table):
4110 Check for integer overflow with large hash tables.
0de4bb68
PE
4111 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4112 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4113 (SXHASH_REDUCE): New macro.
4114 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4115 Use it instead of discarding useful hash info with large hash values.
4116 (sxhash_float): New function.
4117 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4118 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4119 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4120 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4121 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4122 Adjust signatures to match updated version of code.
4123 (consing_since_gc): Now EMACS_INT, since a single hash table can
4124 use more than INT_MAX bytes.
4125
698d32e2
DN
41262011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4127
4128 Make it possible to build with GCC-4.6+ -O2 -flto.
4129
4130 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4131
fd6fa53f
SM
41322011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4133
4134 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4135 Call minibuffer-inactive-mode.
4136
864db017
JB
41372011-05-31 Juanma Barranquero <lekktu@gmail.com>
4138
4139 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4140 Update dependencies.
4141
2ad0baf4
DN
41422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4143
4144 * data.c (init_data): Remove code for UTS, this system is not
4145 supported anymore.
4146
4fcc2638
DN
41472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4148
4149 Don't force ./temacs to start in terminal mode.
4150
4151 * frame.c (make_initial_frame): Initialize faces in all cases, not
4152 only when CANNOT_DUMP is defined.
4153 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4154
c56e0fd5
DN
41552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4156
4157 * dispnew.c (add_window_display_history): Use const for the string
4158 pointer. Remove declaration, not needed.
4159
333d54da 41602011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4161
55d4c1b2 4162 Use 'inline', not 'INLINE'.
333d54da 4163 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4164 * alloc.c, fontset.c (INLINE): Remove.
4165 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4166 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4167 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4168 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4169 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4170
738db178
DN
41712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4172
4173 Make it possible to run ./temacs.
4174
4175 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4176 syms_of_callproc does the same thing. Remove test for
4177 "initialized", do it in the caller.
4178 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4179
620c53a6
SM
41802011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4181
4182 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4183 (read_minibuf): Use get_minibuffer.
4184 (syms_of_minibuf): Use DEFSYM.
4185 (Qmetadata): New var.
4186 * data.c (Qbuffer): Don't make it static.
4187 (syms_of_data): Use DEFSYM.
4188
e003a292
PE
41892011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4190
4191 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4192 (CCL_CODE_MIN): New macro.
4193
ed008a6d
PE
41942011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4195
3687c2ef
PE
4196 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4197
ed008a6d
PE
4198 * eval.c (Qdebug): Now static.
4199 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4200 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4201 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4202
d66c4c7c
CY
42032011-05-29 Chong Yidong <cyd@stupidchicken.com>
4204
4205 * image.c: Various fixes to ImageMagick code comments.
4206 (Fimagemagick_types): Doc fix.
4207
5fbc2025
PE
42082011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4209
0196f88a
PE
4210 Minor fixes prompted by GCC 4.6.0 warnings.
4211
4212 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4213
5fbc2025
PE
4214 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4215 (x_clipboard_manager_save_all): Move extern decl to ...
4216 * xterm.h: ... here, so that it can be checked for consistency.
4217
1dd3c2d9
CY
42182011-05-29 Chong Yidong <cyd@stupidchicken.com>
4219
4220 * xselect.c (x_clipboard_manager_save_frame)
4221 (x_clipboard_manager_save_all): New functions.
4222 (Fx_clipboard_manager_save): Lisp function deleted.
4223
4224 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4225 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4226
4227 * xterm.h: Update prototype.
4228
5ba6571d
WX
42292011-05-28 William Xu <william.xwl@gmail.com>
4230
4231 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4232 exiting (Bug#8239).
4233
3eaff834
JM
42342011-05-28 Jim Meyering <meyering@redhat.com>
4235
e1900994 4236 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4237 * fns.c (to_uchar): Define.
4238 (crypto_hash_function): Use it to convert some newly-signed
4239 variables to unsigned, to avoid sign-extension bugs. For example,
4240 without this change, (md5 "truc") would evaluate to
4241 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4242 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4243 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4244
0f6990a7
PE
42452011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4246
4247 Integer overflow fixes.
c8a9ca5a 4248
08686060
PE
4249 * dbusbind.c: Serial number integer overflow fixes.
4250 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4251 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4252 to hold a serial number that is too large for a fixnum.
4253 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4254 Check for serial numbers out of range. Decode any serial number
59568bf0 4255 that was so large that it became a float. (Bug#8722)
08686060 4256
2d1fc3c7
PE
4257 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4258 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4259 Use XFASTINT rather than XUINT when numbers are nonnegative.
4260 (xd_append_arg, Fdbus_method_return_internal):
4261 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4262 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4263 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4264 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4265 (Bug#8722)
2d1fc3c7 4266
c8a9ca5a
PE
4267 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4268
519e1d69
PE
4269 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4270
30569699
PE
4271 ccl: add integer overflow checks
4272 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4273 (IN_INT_RANGE): New macros.
4274 (ccl_driver): Use them to check for integer overflow when
4275 decoding a CCL program. Many of the new checks are whether XINT (x)
4276 fits in int; it doesn't always, on 64-bit hosts. The new version
4277 doesn't catch all possible integer overflows, but it's an
847044ea 4278 improvement. (Bug#8719)
30569699 4279
c11285dc
PE
4280 * alloc.c (make_event_array): Use XINT, not XUINT.
4281 There's no need for unsigned here.
4282
fdccd48e
PE
4283 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4284 This follows up to the 2011-05-06 change that substituted uintptr_t
4285 for EMACS_INT. This case wasn't caught back then.
4286
37910ab2
PE
4287 Rework Fformat to avoid integer overflow issues.
4288 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4289 now (part of C89). Include <verify.h>.
4290 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4291 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4292 (Fformat): Avoid the prepass trying to compute sizes; it was only
4293 approximate and thus did not catch overflow reliably. Instead, walk
4294 through the format just once, formatting and computing sizes as we go,
4295 checking for integer overflow at every step, and allocating a larger
4296 buffer as needed. Keep track separately whether the format is
4297 multibyte. Keep only the most-recently calculated precision, rather
4298 than them all. Record whether each argument has been converted to
4299 string. Use EMACS_INT, not int, for byte and char and arg counts.
4300 Support field widths and precisions larger than INT_MAX. Avoid
4301 sprintf's undefined behavior with conversion specifications such as %#d
4302 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4303 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4304 formatting out-of-range floating point numbers with int
9173deec 4305 formats. (Bug#8668)
37910ab2 4306
2e6578fb
PE
4307 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4308
0ae6bdee
PE
4309 * data.c: Avoid integer truncation in expressions involving floats.
4310 * data.c: Include <intprops.h>.
4311 (arith_driver): When there's an integer overflow in an expression
4312 involving floating point, convert the integers to floating point
4313 so that the resulting value does not suffer from catastrophic
4314 integer truncation. For example, on a 64-bit host (* 4
4315 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4316 Do not rely on undefined behavior after integer overflow.
4317
de883a70
PE
4318 merge count_size_as_multibyte, parse_str_to_multibyte
4319 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4320 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4321 Check for integer overflow.
4322 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4323 since it's now a duplicate of the other. This is more of
4324 a character than a buffer op, so better that it's in character.c.
4325 * fns.c, print.c: Adjust to above changes.
4326
2ff916cb
PE
43272011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4328
4329 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4330
f1b54466
PE
43312011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4332
fb1ac845
PE
4333 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4334 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4335 (x_clipboard_manager_save): Now static.
4336 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4337
f1b54466
PE
4338 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4339 (crypto_hash_function): Now static.
4340 Fix pointer signedness problems. Avoid unnecessary initializations.
4341
a9f737ee
CY
43422011-05-27 Chong Yidong <cyd@stupidchicken.com>
4343
4344 * termhooks.h (Vselection_alist): Make it terminal-local.
4345
4346 * terminal.c (create_terminal): Initialize it.
4347
4348 * xselect.c: Support for clipboard managers.
4349 (Vselection_alist): Move to termhooks.h as terminal-local var.
4350 (LOCAL_SELECTION): New macro.
4351 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4352 (symbol_to_x_atom): Remove gratuitous arg.
4353 (x_handle_selection_request, lisp_data_to_selection_data)
4354 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4355 (x_own_selection, x_get_local_selection, x_convert_selection):
4356 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4357 (some_frame_on_display): Delete unused function.
4358 (Fx_own_selection_internal, Fx_get_selection_internal)
4359 (Fx_disown_selection_internal, Fx_selection_owner_p)
4360 (Fx_selection_exists_p): New optional frame arg.
4361 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4362 (x_handle_selection_clear): Don't treat other terminals with the
4363 same keyboard specially. Use the terminal-local Vselection_alist.
4364 (x_clear_frame_selections): Use Frun_hook_with_args.
4365
4366 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4367
4368 * xterm.h: Add support for those atoms.
4369
e067f0c1
CY
43702011-05-26 Chong Yidong <cyd@stupidchicken.com>
4371
4372 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4373 (converted_selections, conversion_fail_tag): New global variables.
4374 (x_selection_request_lisp_error): Free the above.
4375 (x_get_local_selection): Remove unnecessary code.
4376 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4377 of converted selections stored in converted_selections.
4378 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4379 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4380 (x_convert_selection): New function.
4381 (x_handle_selection_event): Simplify.
4382 (x_get_foreign_selection): Don't ignore incoming requests while
4383 waiting for an answer; this will fail when we implement
4384 SAVE_TARGETS, and seems unnecessary anyway.
4385 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4386 (Vx_sent_selection_functions): Doc fix.
4387
0f4aebc0
LL
43882011-05-26 Leo Liu <sdl.web@gmail.com>
4389
4390 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4391
e61124cd
YM
43922011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4393
4394 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4395
4396 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4397 for fringe update if it has periodic bitmap.
ac389d0c 4398 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4399 and fringe_bitmap_periodic_p.
4400
4401 * fringe.c (get_fringe_bitmap_data): New function.
4402 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4403 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4404 row. Mark glyph row for fringe update if periodicity changed.
4405
4406 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4407 for fringe update unless it has periodic bitmap.
4408
f16d9837
KH
44092011-05-25 Kenichi Handa <handa@m17n.org>
4410
4411 * xdisp.c (get_next_display_element): Set correct it->face_id for
4412 a static composition.
4413
e1b90ef6
LL
44142011-05-24 Leo Liu <sdl.web@gmail.com>
4415
4416 * deps.mk (fns.o):
4417 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4418
4419 * fns.c (crypto_hash_function, Fsha1): New function.
4420 (Fmd5): Use crypto_hash_function.
4421 (syms_of_fns): Add Ssha1.
4422
7400048f
PE
44232011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4424
4425 * gnutls.c: Remove unused macros.
4426 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4427 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4428 Remove macros that are defined and never used.
4429 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4430
abb71cf4
CY
44312011-05-22 Chong Yidong <cyd@stupidchicken.com>
4432
4433 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4434 (Fx_get_selection_internal): Minor cleanup.
4435 (Fx_own_selection_internal): Rename arguments for consistency with
4436 select.el.
4437
6307db39
PE
44382011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4439
4440 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4441
f3d4e0a4
CY
44422011-05-22 Chong Yidong <cyd@stupidchicken.com>
4443
4444 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4445
4d8ade89
YM
44462011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4447
4448 * dispnew.c (scrolling_window): Don't exclude the case that the
4449 last enabled row in the desired matrix touches the bottom boundary.
4450
32078c8d
GM
44512011-05-21 Glenn Morris <rgm@gnu.org>
4452
4453 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4454 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4455 and add some more files.
32078c8d 4456
7285dc67
EZ
44572011-05-20 Eli Zaretskii <eliz@gnu.org>
4458
4459 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4460 report_file_error introduced by the change from 2011-05-07.
4461
89d1bd22
PE
44622011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4463
4464 * systime.h (Time): Define only if emacs is defined.
4465 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4466 where the include path doesn't have X11/X.h by default. See
4467 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4468
e23640bb 44692011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4470
4471 * composite.c (find_automatic_composition): Fix previous change.
4472
b9704ad9
GM
44732011-05-20 Glenn Morris <rgm@gnu.org>
4474
4475 * lisp.mk: New file, split from Makefile.in.
4476 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4477 (shortlisp): Remove.
4478 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4479
4a720484
GM
44802011-05-19 Glenn Morris <rgm@gnu.org>
4481
4482 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4483 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4484 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4485 (lisp): Set the order to that of loadup.el.
4486 (shortlisp): Make it a copy of $lisp.
4487 (SOME_MACHINE_LISP): Remove.
4488 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4489 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4490
a28d4396
KH
44912011-05-18 Kenichi Handa <handa@m17n.org>
4492
4493 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4494 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4495 (find_automatic_composition): Mostly rewrite for efficiency.
4496
a2b1fa8e
JB
44972011-05-18 Juanma Barranquero <lekktu@gmail.com>
4498
4499 * makefile.w32-in: Update dependencies.
4500
8e1f5610
CS
45012011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4502
4503 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4504 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4505
7025ee00 45062011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4507
cdfa6eab
PE
4508 Fix some integer overflow issues, such as string length overflow.
4509
06d6db33
PE
4510 * insdel.c (count_size_as_multibyte): Check for string overflow.
4511
2b4560a8
PE
4512 * character.c (lisp_string_width): Check for string overflow.
4513 Use EMACS_INT, not int, for string indexes and lengths; in
4514 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4515 the resulting string length overflows an EMACS_INT; instead,
4516 report a string overflow if no precision given. When checking for
4517 precision exhaustion, use a check that cannot possibly have
4518 integer overflow. (Bug#8675)
4519 * character.h (lisp_string_width): Adjust to new signature.
4520
cb93f9be
PE
4521 * alloc.c (string_overflow): New function.
4522 (Fmake_string): Use it. This doesn't change behavior, but saves
4523 a few bytes and will simplify future changes.
4524 * character.c (string_escape_byte8): Likewise.
4525 * lisp.h (string_overflow): New decl.
4526
1a1f3366
PE
4527 Fixups, following up to the user-interface timestamp change.
4528 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4529 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4530 * msdos.c (mouse_get_pos): Likewise.
4531 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4532 * w32gui.h (Time): Define by including "systime.h" rather than by
4533 declaring it ourselves. (Bug#8664)
4534
d4e3e4d3
PE
4535 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4536 * image.c (clear_image_cache): Likewise.
4537
f6a24d19
PE
4538 * term.c (term_mouse_position): Don't assume time_t wraparound.
4539
08dc5ae6
PE
4540 Be more systematic about user-interface timestamps.
4541 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4542 and sometimes 'EMACS_UINT', to represent these timestamps.
4543 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4544 This makes the code easier to follow, and makes it easier to catch
4545 integer overflow bugs such as Bug#8664.
4546 * frame.c (Fmouse_position, Fmouse_pixel_position):
4547 Use Time, not unsigned long, for user-interface timestamps.
4548 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4549 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4550 * keyboard.h (last_event_timestamp): Likewise.
4551 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4552 * menu.h (xmenu_show): Likewise.
4553 * term.c (term_mouse_position): Likewise.
4554 * termhooks.h (struct input_event.timestamp): Likewise.
4555 (struct terminal.mouse_position_hook): Likewise.
4556 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4557 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4558 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4559 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4560 what it was before.
4561 * menu.h, termhooks.h: Include "systime.h", for Time.
4562
8e55734a
PE
4563 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4564 Don't assume that the difference between two unsigned long values
4565 can fit into an integer. At this point, we know button_down_time
4566 <= event->timestamp, so the difference must be nonnegative, so
4567 there's no need to cast the result if double-click-time is
4568 nonnegative, as it should be; check that it's nonnegative, just in
4569 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4570 apart (about 25 days). (Bug#8664)
8e55734a 4571
841f1b75 4572 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4573 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4574
3e26f69c
PE
4575 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4576 that always fit in int. Use a sentinel instead of a counter, to
4577 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4578 * frame.h (struct frame): Use int for menu_bar_items_used
4579 instead of EMACS_INT, since it always fits in int.
3e26f69c 4580
5cc152c0
PE
4581 * menu.c (grow_menu_items): Check for int overflow.
4582
d89eb65e
PE
4583 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4584
5235bd3e
PE
4585 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4586 Before, the code was not consistent. These values cannot exceed
4587 2**31 - 1 so there's no need to make them unsigned.
4588 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4589 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4590 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4591 as modifiers.
4592 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4593
bc827e23
PE
4594 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4595 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4596 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4597 presumably because the widths might not match.
4598
78eb494e
PE
4599 * window.c (size_window): Avoid needless test at loop start.
4600
04f2d78b
CB
46012011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4602
4603 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4604
d2fc7e3d 46052011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4606
4607 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4608
d2fc7e3d 46092011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4610
4611 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4612 `width' to `bar_area_x' and `bar_area_width', respectively.
4613 (x_scroll_run): Take account of fringe background extension.
4614
04f2d78b
CB
4615 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4616 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4617 `bar_area_width', respectively.
4618 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4619 background extension.
4620
79b70037
GM
46212011-05-10 Jim Meyering <meyering@redhat.com>
4622
4623 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4624
2f142cc5
JB
46252011-05-10 Juanma Barranquero <lekktu@gmail.com>
4626
4627 * image.c (Finit_image_library): Return t for built-in image types,
4628 like pbm and xbm. (Bug#8640)
4629
57679c86
AS
46302011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4631
4632 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4633
888c9e86
EZ
46342011-05-07 Eli Zaretskii <eliz@gnu.org>
4635
b0512a1d
EZ
4636 * w32console.c (Fset_screen_color): Doc fix.
4637 (Fget_screen_color): New function.
4638 (syms_of_ntterm): Defsubr it.
4639
7285dc67
EZ
4640 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4641 unlink the temporary file if Fcall_process didn't create it in the
4642 first place.
4643 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4644 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4645 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4646 cue to call_process_cleanup not to close that handle.
4647
4d3fcc8e
BK
46482011-05-07 Ben Key <bkey76@gmail.com>
4649
4650 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4651 one of two shell specific rules, either bootstrap-temacs-CMD or
4652 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4653 to the previous implementation of the bootstrap-temacs rule.
4654 The bootstrap-temacs-CMD rule is similar to the previous
4655 implementation of the bootstrap-temacs rule except that it
4656 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4657 variable.
4658
4659 These changes, along with some changes to nt/configure.bat,
4660 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4661 earlier fix to add support for --cflags and --ldflags options
4662 that include quotes so that it works whether make uses cmd or
4663 sh as the shell.
4664
b4289b64
MA
46652011-05-06 Michael Albinus <michael.albinus@gmx.de>
4666
4667 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4668 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4669 is a constant.
4670 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4671 a string. Handle both cases.
4672 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4673 (Fdbus_register_method): Use Qinvalid_function.
4674
af4c0e28
JB
46752011-05-06 Juanma Barranquero <lekktu@gmail.com>
4676
4677 * makefile.w32-in: Update dependencies.
4678 (LISP_H): Add inttypes.h and stdin.h.
4679 (PROCESS_H): Add unistd.h.
4680
c51453d9
EZ
46812011-05-06 Eli Zaretskii <eliz@gnu.org>
4682
4683 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4684 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4685
8ff0ac3c 46862011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4687
4c4b566b
PE
4688 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4689
aab2b9b5
PE
4690 * term.c (vfatal): Remove stray call to va_end.
4691 It's not needed and the C Standard doesn't allow it here anyway.
4692
c378da0b
PE
4693 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4694 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4695
288b08c7
PE
4696 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4697 bytes.
4698
e3601888
PE
4699 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4700
db6c0e74
PE
4701 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4702
dd5963ea
PE
4703 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4704
88c9450f
PE
4705 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4706
2f9442b8
PE
4707 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4708
c032b5f8
PE
4709 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4710 * charset.c (Fdefine_charset_internal): Don't initialize
4711 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4712 32-bit int (Bug#8600).
a108c10b
PE
4713
4714 * lread.c (read_integer): Be more consistent with string-to-number.
4715 Use string_to_number to do the actual conversion; this avoids
4716 rounding errors and fixes some other screwups. Without this fix,
4717 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4718 (digit_to_number): Move earlier, for benefit of read_integer.
4719 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4720 not a digit in any supported base. (Bug#8602)
a108c10b 4721
ad5f9eea
PE
4722 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4723
aec1708a
PE
4724 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4725 to match comment at start of function. This also removes a
4726 GCC warning about overflow in a 32+64-bit port.
4727
47be4ab5
PE
4728 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4729
371cac43
PE
4730 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4731 Reported by Stefan Monnier in
4732 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4733 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4734 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4735
d01a7826
PE
4736 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4737 (EMACS_UINTPTR): Likewise, with uintptr_t.
4738
7fd47d5c
PE
4739 * lisp.h: Prefer 64-bit EMACS_INT if available.
4740 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4741 on 32-bit hosts that have 64-bit int, so that they can access
4742 large files.
122b0c86
PE
4743 However, temporarily disable this change unless the temporary
4744 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4745
8727937b
PE
4746 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4747
8ac068ac
PE
4748 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4749 This removes an assumption that EMACS_INT and long are the same
4750 width as pointers. The assumption is true for Emacs porting targets
4751 now, but we want to make other targets possible.
4752 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4753 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4754 In the rest of the code, change types of integers that hold casted
4755 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4756 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4757 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4758 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4759 No need to cast type when ORing.
4760 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4761 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4762 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4763 assume EMACS_INT is the same width as char *.
4764 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4765 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4766 Remove no-longer-needed casts.
4767 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4768 (xg_tool_bar_help_callback, xg_make_tool_item):
4769 Use EMACS_INTPTR to hold an integer
4770 that will be cast to void *; this can avoid a GCC warning
4771 if EMACS_INT is not the same width as void *.
4772 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4773 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4774 (current_message_1, set_message_1):
4775 Use a local to convert to proper width without a cast.
4776 * xmenu.c (dialog_selection_callback): Likewise.
4777
ede49d71
PE
4778 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4779 Also, don't assume VALBITS / RAND_BITS is less than 5,
4780 and don't rely on undefined behavior when shifting a 1 left into
4781 the sign bit.
4782 * lisp.h (get_random): Change signature to match.
4783
2f30ecd0
PE
4784 * lread.c (hash_string): Use size_t, not int, for hash computation.
4785 Normally we prefer signed values; but hashing is special, because
4786 it's better to use unsigned division on hash table sizes so that
4787 the remainder is nonnegative. Also, size_t is the natural width
4788 for hashing into memory. The previous code used 'int', which doesn't
4789 retain enough info to hash well into very large tables.
4790 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4791
2a866e7b
PE
4792 * dbusbind.c: Don't possibly lose pointer info when converting.
4793 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4794 Use XPNTR rather than XHASH, so that the high-order bits of
4795 the pointer aren't lost when converting through void *.
4796
51639eac
PE
4797 * eval.c (Fautoload): Don't double-shift a pointer.
4798
92394119
PE
4799 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4800
dbdb9a7c
JB
48012011-05-06 Juanma Barranquero <lekktu@gmail.com>
4802
4803 * gnutls.c (DEF_GNUTLS_FN):
4804 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4805
db7a0b4f
AS
48062011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4807
4808 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4809 marker. (Bug#8610)
4810
f7ff1b0f 48112011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4812
4813 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4814 New version that can reserve upto 2GB of heap space.
4815
f7ff1b0f 48162011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4817
4818 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4819
639c109b
TZ
48202011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4821
4822 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4823 `gnutls_certificate_set_x509_key_file'.
4824
d2127135
JB
48252011-05-05 Juanma Barranquero <lekktu@gmail.com>
4826
4827 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4828 Update dependencies.
4829
e968f4f3
JB
48302011-05-04 Juanma Barranquero <lekktu@gmail.com>
4831
4832 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4833 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4834 Remove unused parameter `fildes'.
4835 * process.c (read_process_output, send_process): Don't pass it.
4836
84d358f0
JB
48372011-05-04 Juanma Barranquero <lekktu@gmail.com>
4838
4839 Fix previous change: the library cache is defined in w32.c.
4840 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4841 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4842
0898ca10
JB
48432011-05-04 Juanma Barranquero <lekktu@gmail.com>
4844
4845 Implement dynamic loading of GnuTLS on Windows.
4846
4847 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4848 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4849 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4850 Declare.
4851
4852 * gnutls.c (Qgnutls_dll): Define.
4853 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4854 (gnutls_*): Declare function pointers.
4855 (init_gnutls_functions): New function to initialize function pointers.
4856 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4857 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4858 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4859 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4860 (emacs_gnutls_write, emacs_gnutls_read)
4861 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4862 (Fgnutls_available_p): New function.
4863 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4864 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4865 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4866
4867 * image.c: Include w32.h.
4868 (Vimage_type_cache): Delete.
4869 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4870 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4871 (w32_delayed_load): Move to w32.c.
4872
4873 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4874
4875 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4876 (w32_delayed_load): Move from image.c. When loading a library, record
4877 its filename in the :loaded-from property of the library id.
4878 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4879 Initialize and staticpro them.
4880 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4881
4882 * process.c: Include lisp.h before w32.h, not after.
4883 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4884 instead of gnutls_record_check_pending.
4885
4886 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4887
ff4de4aa
TZ
48882011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4889
4890 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4891 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4892 as passed in.
4893
abe95abb
JD
48942011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4895
4896 * xterm.c (x_set_frame_alpha): Do not set property on anything
4897 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4898
e16e55d4
JB
48992011-05-02 Juanma Barranquero <lekktu@gmail.com>
4900
4901 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4902
bafcf6a5
JB
49032011-05-02 Juanma Barranquero <lekktu@gmail.com>
4904
4905 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4906 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4907 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4908 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4909 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4910 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4911 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4912 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4913 (Qgnutls_bootprop_callbacks_verify): Make static.
4914
e7a6747f
AS
49152011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4916
19ed11ba
AS
4917 * callproc.c: Indentation fixup.
4918
e7a6747f 4919 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4920 (wait_for_termination, interruptible_wait_for_termination):
4921 Move after wait_for_termination_1.
e7a6747f 4922
1ef14cb4
LMI
49232011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4924
4925 * sysdep.c (interruptible_wait_for_termination): New function
4926 which is like wait_for_termination, but allows keyboard
4927 interruptions.
4928
4929 * callproc.c (Fcall_process): Add (:file "file") as an option for
4930 the STDOUT buffer.
4931 (Fcall_process_region): Ditto.
4932
330d880c
EZ
49332011-04-30 Eli Zaretskii <eliz@gnu.org>
4934
8db90b73
EZ
4935 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4936 rather than `XVECTOR (FOO)->size'.
4937
330d880c
EZ
4938 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4939 inttypes.h, as a gnulib replacement is used if it not available in
4940 system headers.
4941
15cbd324
EZ
49422011-04-21 Eli Zaretskii <eliz@gnu.org>
4943
4944 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4945 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4946 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4947
4948 * coding.c (coding_alloc_by_realloc): Error out if destination
4949 will grow beyond MOST_POSITIVE_FIXNUM.
4950 (decode_coding_emacs_mule): Abort if there isn't enough place in
4951 charbuf for the composition carryover bytes. Reserve an extra
4952 space for up to 2 characters produced in a loop.
4953 (decode_coding_iso_2022): Abort if there isn't enough place in
4954 charbuf for the composition carryover bytes.
4955
49562011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4957
ae940cca
EZ
4958 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4959 aborting when %lld or %lll format is passed.
4960 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4961 %llo or %llx format is passed. (Bug#8545)
4962
03ab8921
EZ
4963 * window.c (window_scroll_line_based): Use a marker instead of
4964 simple variables to record original value of point. (Bug#7952)
4965
afda1437
EZ
4966 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4967 produced by %s or %c overflows available buffer space. (Bug#8545)
4968
f76dee0c
PE
49692011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4970
4971 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4972 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4973
fdc5744d
JB
49742011-04-28 Juanma Barranquero <lekktu@gmail.com>
4975
4976 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4977
638f053a
JB
49782011-04-28 Juanma Barranquero <lekktu@gmail.com>
4979
4980 * keyboard.c (Qdelayed_warnings_hook): Define.
4981 (command_loop_1): Run `delayed-warnings-hook'
4982 if Vdelayed_warnings_list is non-nil.
4983 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4984 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4985
d178f871
EZ
49862011-04-28 Eli Zaretskii <eliz@gnu.org>
4987
4988 * doprnt.c (doprnt): Don't return value smaller than the buffer
4989 size if the message was truncated. (Bug#8545).
4990
b124fd93
JB
49912011-04-28 Juanma Barranquero <lekktu@gmail.com>
4992
4993 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4994 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4995
e810457d
PE
49962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4997
4998 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4999
ea51cceb
JB
50002011-04-27 Juanma Barranquero <lekktu@gmail.com>
5001
5002 * makefile.w32-in: Update dependencies.
5003
94dcfacf
EZ
50042011-04-27 Eli Zaretskii <eliz@gnu.org>
5005
5006 Improve `doprnt' and its usage. (Bug#8545)
5007 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5008 `format_end'. Remove support for %l as a conversion specifier.
5009 Don't use xrealloc. Improve diagnostics when the %l size modifier
5010 is used. Update the commentary.
5011
5012 * eval.c (verror): Simplify calculation of size_t.
5013
5014 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5015 messages.
5016
f61f41d7
PE
50172011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5018
5019 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5020 change.
5021
96fb4434
PE
50222011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5023
5024 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5025 This makes this file independent of the recent pseudovector change.
5026
671875da 50272011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5028
69e9b5a3
PE
5029 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5030
b5f869a7 5031 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5032 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5033 Remove unused local.
c8926152 5034 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5035
841a1577 5036 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5037 GCC 4.6.0 optimizes based on type-based alias analysis.
5038 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5039 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5040 != &v->size, and therefore "v->size = 1; b->size = 2; return
5041 v->size;" must therefore return 1. This assumption is incorrect
5042 for Emacs, since it type-puns struct Lisp_Vector * with many other
5043 types. To fix this problem, this patch adds a new type struct
f904488f 5044 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5045 and pseudovectors, and helps optimizing compilers not get fooled
5046 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5047 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5048 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5049 the size member.
eab3844f
PE
5050 (XSETPVECTYPE): Rewrite in terms of new macro.
5051 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5052 This is a bit clearer, and further avoids the possibility of
5053 undesirable aliasing.
5054 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5055 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5056 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5057 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5058 (ASIZE): Now uses header.size rather than size.
5059 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5060 to avoid the hassle of writing XVECTOR (foo)->header.size.
5061 (struct vectorlike_header): New type.
eab3844f
PE
5062 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5063 object, to help avoid aliasing.
5064 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5065 (SUBRP): Likewise, since Lisp_Subr is a special case.
5066 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5067 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5068 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5069 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5070 changed to be "header.size" and "header.next".
5071 * buffer.h (struct buffer): Likewise.
5072 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5073 * frame.h (struct frame): Likewise.
5074 * process.h (struct Lisp_Process): Likewise.
5075 * termhooks.h (struct terminal): Likewise.
5076 * window.c (struct save_window_data, struct saved_window): Likewise.
5077 * window.h (struct window): Likewise.
5078 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5079 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5080 * buffer.c (init_buffer_once): Likewise.
5081 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5082 special case.
5083 * process.c (Fformat_network_address): Use local var for size,
5084 for brevity.
5085
0df1eac5
PE
5086 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5087
847ab9d1 5088 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5089 * data.c (atof): Remove decl; no longer used or needed.
5090 (digit_to_number): Move to lread.c.
5091 (Fstring_to_number): Use new string_to_number function, to be
5092 consistent with how the Lisp reader treats infinities and NaNs.
5093 Do not assume that floating-point numbers represent EMACS_INT
5094 without losing information; this is not true on most 64-bit hosts.
5095 Avoid double-rounding errors, by insisting on integers when
5096 parsing non-base-10 numbers, as the documentation specifies.
5097 * lisp.h (string_to_number): New decl, replacing ...
5098 (isfloat_string): Remove.
bc0a5c13 5099 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5100 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5101 appears to have been a coding error. Similarly, do not accept
5102 strings like +-1e0 as floating point numbers. Do not report
5103 overflow for integer overflows unless the base is not 10 which
5104 means we have no simple and reliable way to continue.
5105 Break out the floating-point parsing into a new
5106 function string_to_number, so that Fstring_to_number parses
5107 floating point numbers consistently with the Lisp reader.
04f2d78b 5108 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5109 (E_CHAR, EXP_INT): Remove, replacing with ...
5110 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5111 (string_to_number): New function, replacing isfloat_string.
5112 This function checks for valid syntax and produces the resulting
5113 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5114 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5115 so that overflow for non-base-10 numbers is reported only when
5116 there's no portable and simple way to convert to floating point.
452f4150 5117
67769ffc
PE
5118 * textprop.c (set_text_properties_1): Rewrite for clarity,
5119 and to avoid GCC warning about integer overflow.
5120
c20db43f
PE
5121 * intervals.h (struct interval): Use EMACS_INT for members
5122 where EMACS_UINT might cause problems. See
5123 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5124 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5125 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5126 All uses changed.
37aa2f85
PE
5127 (offset_intervals): Tell GCC not to worry about length overflow
5128 when negating a negative length.
c20db43f 5129
2538aa2f
PE
5130 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5131 (overrun_check_free): Likewise.
5132
f2d3008d
PE
5133 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5134 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5135 word size.
5136
ec8df744
PE
5137 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5138 (gnutls_make_error): Rename local to avoid shadowing.
5139 (gnutls_emacs_global_deinit): ifdef out; not used.
5140 (Fgnutls_boot): Use const for pointer to readonly storage.
5141 Comment out unused local. Fix pointer signedness problems.
5142
640ee02d
PE
5143 * lread.c (openp): Don't stuff size_t into an 'int'.
5144 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5145 about possible signed overflow.
5146
6048fb2a
PE
5147 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5148 (GDK_KEY_g): Don't define if already defined.
5149 (xg_prepare_tooltip): Avoid pointer signedness problem.
5150 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5151
fa3c87e1
PE
5152 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5153 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5154
2172544b
PE
5155 * xfns.c (Fx_window_property): Simplify a bit,
5156 to make a bit faster and to avoid GCC 4.6.0 warning.
5157 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5158
9b821a21
PE
5159 * fns.c (internal_equal): Don't assume size_t fits in int.
5160
3c616cfa
PE
5161 * alloc.c (compact_small_strings): Tighten assertion a little.
5162
c2982e87
PE
5163 Replace pEd with more-general pI, and fix some printf arg casts.
5164 * lisp.h (pI): New macro, generalizing old pEd macro to other
5165 conversion specifiers. For example, use "...%"pI"d..." rather
5166 than "...%"pEd"...".
5167 (pEd): Remove. All uses replaced with similar uses of pI.
5168 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5169 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5170 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5171 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5172 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5173 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5174 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5175 64-bit hosts.
5176 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5177 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5178 * print.c (safe_debug_print, print_object): Likewise.
5179 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5180 to int.
6f04d126
PE
5181 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5182 avoiding the 0 flag, which is not portable.
c2982e87
PE
5183 * process.c (Fmake_network_process): Use pI to avoid cast.
5184 * region-cache.c (pp_cache): Likewise.
5185 * xdisp.c (decode_mode_spec): Likewise.
5186 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5187 behavior on 64-bit hosts with printf arg.
6f04d126 5188 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5189 (x_stop_queuing_selection_requests): Likewise.
5190 (x_get_window_property): Don't truncate byte count to an 'int'
5191 when tracing.
0b432f21 5192
5e073ec7
PE
5193 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5194 here, since it parses constructs like leading '-' and spaces,
5195 which are not wanted; and it overflows with large numbers.
5196 Instead, simply match F[0-9]+, which is what is wanted anyway.
5197
36372bf9
PE
5198 * alloc.c: Remove unportable assumptions about struct layout.
5199 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5200 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5201 (allocate_vectorlike, make_pure_vector): Use the new macros,
5202 plus offsetof, to remove unportable assumptions about struct layout.
5203 These assumptions hold on all porting targets that I know of, but
5204 they are not guaranteed, they're easy to remove, and removing them
5205 makes further changes easier.
5206
0b432f21
PE
5207 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5208 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5209 (string_overrun_cookie): Now const. Use initializers that
5210 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5211 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5212 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5213 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5214 multiple of sizeof (EMACS_INT); it need not be, if
5215 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5216 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5217
895009e1
JB
52182011-04-26 Juanma Barranquero <lekktu@gmail.com>
5219
5220 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5221
6a7a1b0b
TZ
52222011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5223
5224 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5225 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5226 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5227
841a1577 52282011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5229
5230 * lisp.h (Qdebug): List symbol.
895009e1 5231 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5232 * keyboard.c (debug-on-event): New variable.
5233 (handle_user_signal): Break into debugger when debug-on-event
5234 matches the current signal symbol.
5235
f2d3ba6f
DN
52362011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5237
5238 * alloc.c (check_sblock, check_string_bytes)
5239 (check_string_free_list): Convert to standard C.
5240
42ce4c63
TZ
52412011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5242
5243 * w32.c (emacs_gnutls_push): Fix typo.
5244
825cd63c
EZ
52452011-04-25 Eli Zaretskii <eliz@gnu.org>
5246
fb11d64d
EZ
5247 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5248 "cast to pointer from integer of different size".
5249
825cd63c
EZ
5250 Improve doprnt and its use in verror. (Bug#8545)
5251 * doprnt.c (doprnt): Document the set of format control sequences
5252 supported by the function. Use SAFE_ALLOCA instead of always
5253 using `alloca'.
5254
5255 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5256 is one byte too soon. Don't use xrealloc; instead xfree and
5257 xmalloc anew.
5258
e061a11b
TZ
52592011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5260
5261 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5262 callbacks stage.
5263
5264 * gnutls.c: Renamed global_initialized to
5265 gnutls_global_initialized. Added internals for the
5266 :verify-hostname-error, :verify-error, and :verify-flags
5267 parameters of `gnutls-boot' and documented those parameters in the
5268 docstring. Start callback support.
9173deec
JB
5269 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5270 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5271 on error. Return error code.
e061a11b
TZ
5272 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5273 (emacs_gnutls_read): Likewise.
5274 (Fgnutls_boot): Return handshake error code.
5275 (emacs_gnutls_handle_error): New function.
5276 (wsaerror_to_errno): Likewise.
5277
5278 * w32.h (emacs_gnutls_pull): Add prototype.
5279 (emacs_gnutls_push): Likewise.
5280
5281 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5282 (emacs_gnutls_push): Likewise.
5283
52842011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5285
5286 * process.c (wait_reading_process_output): Check if GnuTLS
5287 buffered some data internally if no FDs are set for TLS
5288 connections.
5289
5290 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5291 (LIBS): Link to USER_LIBS.
5292 ($(BLD)/gnutls.$(0)): New target.
5293
fa6996bc
EZ
52942011-04-24 Eli Zaretskii <eliz@gnu.org>
5295
eb35682e
EZ
5296 * xdisp.c (handle_single_display_spec): Rename the
5297 display_replaced_before_p argument into display_replaced_p, to
5298 make it consistent with the commentary. Fix typos in the
5299 commentary.
5300
e2ad650c
EZ
5301 * textprop.c (syms_of_textprop): Remove dead code.
5302 (copy_text_properties): Delete obsolete commentary about an
5303 interface that was deleted long ago. Fix typos in the description
5304 of arguments.
5305
1b2de274
EZ
5306 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5307 to changes in oldXMenu/XMenu.h from 2011-04-16.
5308 <menu_help_message, prev_menu_help_message>: Constify.
5309 (IT_menu_make_room): menu->help_text is now `const char **';
5310 adjust.
5311
5312 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5313 to changes in oldXMenu/XMenu.h from 2011-04-16.
5314 (struct XMenu): Declare `help_text' `const char **'.
5315
5316 * xfaces.c <Qunspecified>: Make extern again.
5317
5318 * syntax.c: Include sys/types.h before including regex.h, as
5319 required by Posix.
5320
762b15be
EZ
5321 * doc.c (get_doc_string): Improve the format passed to `error'.
5322
5323 * doprnt.c (doprnt): Improve commentary.
5324
5325 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5326
5327 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5328 them with etags.
5329
f1052e5d
EZ
5330 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5331 changes in globals.h immediately force recompilation.
762b15be
EZ
5332 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5333 $(CURDIR)/s/ms-w32.h.
5334 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5335
fa6996bc
EZ
5336 * character.c (Fchar_direction): Function deleted.
5337 (syms_of_character): Don't defsubr it.
5338 <char-direction-table>: Deleted.
5339
e6c3da20
EZ
53402011-04-23 Eli Zaretskii <eliz@gnu.org>
5341
5342 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5343 * doprnt.c: Include limits.h.
5344 (SIZE_MAX): New macro.
04f2d78b
CB
5345 (doprnt): Return a size_t value. 2nd arg is now size_t.
5346 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5347 Improve overflow protection. Support `l' modifier for integer
5348 conversions. Support %l conversion. Don't assume an EMACS_INT
5349 argument for integer conversions and for %c.
5350
5351 * lisp.h (doprnt): Restore prototype.
5352
5353 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5354 $(SRC)/character.h.
5355
5356 * Makefile.in (base_obj): Add back doprnt.o.
5357
5358 * deps.mk (doprnt.o): Add back prerequisites.
5359 (callint.o): Depend on character.h.
5360
5361 * eval.c (internal_lisp_condition_case): Include the handler
5362 representation in the error message.
5363 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5364 when breaking from the loop.
5365
5366 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5367
5368 * callint.c (Fcall_interactively): When displaying error message
5369 about invalid control letter, pass the character's codepoint, not
5370 a pointer to its multibyte form. Improve display of the character
5371 in octal and display also its hex code.
5372
5373 * character.c (char_string): Use %x to display the (unsigned)
5374 codepoint of an invalid character, to avoid displaying a bogus
5375 negative value.
5376
5377 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5378 `error', not SYMBOL_NAME itself.
5379
5380 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5381 character arguments to `error'.
5382
5383 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5384 to `error' in error message about FINAL_CHAR argument. Make sure
5385 FINAL_CHAR is a character, and use %c when it is passed as
5386 argument to `error'.
5387
4ffd0d6b 53882011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5389
5390 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5391
5392 * w32.c: Include <time.h>.
5393 (sys_localtime): New function.
5394
4ffd0d6b 53952011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5396
5397 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5398
4ffd0d6b 5399 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5400
4ffd0d6b 54012011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5402
4ffd0d6b
GM
5403 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5404 zombies (Bug#8467).
aac0c6e3 5405
04c56954
EZ
54062011-04-19 Eli Zaretskii <eliz@gnu.org>
5407
5408 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5409 gl_state.e_property when gl_state.object is Qt.
5410
5411 * insdel.c (make_gap_larger): Remove limitation of buffer size
5412 to <= INT_MAX.
5413
16a43933
CY
54142011-04-18 Chong Yidong <cyd@stupidchicken.com>
5415
5416 * xdisp.c (lookup_glyphless_char_display)
5417 (produce_glyphless_glyph): Handle cons cell entry in
5418 glyphless-char-display.
5419 (Vglyphless_char_display): Document it.
5420
5421 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5422 glyphless-char-display.
5423
4581706e
CY
54242011-04-17 Chong Yidong <cyd@stupidchicken.com>
5425
5426 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5427
5428 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5429
5430 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5431 definition for no-X builds.
5432
4887c6e2 54332011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5434
fd35b6f9
PE
5435 Static checks with GCC 4.6.0 and non-default toolkits.
5436
5c1ccb01
PE
5437 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5438
006c5daa
PE
5439 * process.c (keyboard_bit_set): Define only if SIGIO.
5440 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5441 (send_process): Repair possible setjmp clobbering.
5442
efc736d3
PE
5443 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5444
4e2fe2e6
PE
5445 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5446
f97334a2
PE
5447 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5448
4e75f29d
PE
5449 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5450 Define only if needed.
5451
90efadd1
PE
5452 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5453 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5454 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5455
3c647824
PE
5456 * dispextern.h (struct redisplay_interface): Rename param
5457 to avoid shadowing.
e264f262 5458 * termhooks.h (struct terminal): Likewise.
761383f4 5459 * xterm.c (xembed_send_message): Likewise.
3c647824 5460
b58c5c4a
PE
5461 * insdel.c (make_gap_smaller): Define only if
5462 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5463
cad59032
PE
5464 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5465 it.
5466
c339dc2e
PE
5467 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5468 so that we aren't warned about unused symbols.
5469
91a3e27b
PE
5470 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5471
399c71d3 5472 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5473
8ffc96f5
PE
5474 * xfns.c (x_real_positions): Mark locals as initialized.
5475
eef9bc79
PE
5476 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5477
098db9dd
PE
5478 * xterm.c: Fix problems found by static analysis with other toolkits.
5479 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5480 (x_dispatch_event): Declare static if USE_GTK, and
5481 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5482 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5483 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5484 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5485 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5486
eb18f6cc
PE
5487 * xmenu.c (menu_help_callback): Pointer type fixes.
5488 Use const pointers when pointing at readonly data. Avoid pointer
5489 signedness clashes.
5490 (FALSE): Remove unused macro.
5491 (update_frame_menubar): Remove unused decl.
5492
1fe72bf8
PE
5493 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5494
60d9e1db
PE
5495 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5496 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5497 (single_menu_item): Rename local to avoid shadowing.
5498
39261c26
PE
5499 * keyboard.c (make_lispy_event): Remove unused local var.
5500
018c5e19
PE
5501 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5502 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5503
63d2b86e
PE
5504 * bitmaps: Change bitmaps from unsigned char back to the X11
5505 compatible char. Avoid the old compiler warnings about
5506 out-of-range initializers by using, for example, '\xab' rather
5507 than 0xab.
5508
aefd87e1
PE
5509 * xgselect.c (xgselect_initialize): Check vs interface
5510 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5511
bf501fb9
PE
5512 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5513
e9829fdf
PE
5514 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5515 to read-only memory.
5516
1086c095
PE
5517 * fns.c (vector): Remove; this old hack is no longer needed.
5518
2baccd04 5519 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5520 Remove unused var.
dde42981 5521 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5522
72391843 5523 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5524
436c16df 5525 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5526 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5527 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5528
92bb796d 5529 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5530 (x_term_init): Remove local to avoid shadowing.
92bb796d 5531
764430a3 5532 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5533
5534 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5535 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5536
d1dfb56c
EZ
55372011-04-16 Eli Zaretskii <eliz@gnu.org>
5538
c4354cb4
EZ
5539 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5540
d1dfb56c
EZ
5541 Fix regex.c, syntax.c and friends for buffers > 2GB.
5542 * syntax.h (struct gl_state_s): Declare character position members
5543 EMACS_INT.
5544
5545 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5546
04f2d78b
CB
5547 * textprop.c (verify_interval_modification, interval_of):
5548 Declare arguments EMACS_INT.
d1dfb56c
EZ
5549
5550 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5551 EMACS_INT.
5552
5553 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5554
5555 * indent.c (Fvertical_motion): Local variable it_start is now
5556 EMACS_INT.
5557
5558 * regex.c (re_match, re_match_2, re_match_2_internal)
5559 (bcmp_translate, regcomp, regexec, print_double_string)
5560 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5561 (re_compile_pattern, re_exec): Declare arguments and local
5562 variables `size_t' and `ssize_t' and return values `regoff_t', as
5563 appropriate.
5564 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5565 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5566 <compile_stack_type>: `size' and `avail' are now `size_t'.
5567
5568 * regex.h <regoff_t>: Use ssize_t, not int.
5569 (re_search, re_search_2, re_match, re_match_2): Arguments that
5570 specify buffer/string position and length are now ssize_t and
5571 size_t. Return type is regoff_t.
5572
613052cd
BK
55732011-04-16 Ben Key <bkey76@gmail.com>
5574
5575 * nsfont.m: Fixed bugs in ns_get_family and
5576 ns_descriptor_to_entity that were caused by using free to
5577 deallocate memory blocks that were allocated by xmalloc (via
5578 xstrdup). This caused Emacs to crash when compiled with
5579 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5580 --enable-checking=xmallocoverrun). xfree is now used to
5581 deallocate these memory blocks.
5582
4170f62f 55832011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5584
71b41406
PE
5585 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5586
9587a89d
PE
5587 emacs_write: Accept and return EMACS_INT for sizes.
5588 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5589 et seq.
5590 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5591 Accept and return EMACS_INT.
5592 (emacs_gnutls_write): Return the number of bytes written on
5593 partial writes.
5594 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5595 (emacs_read, emacs_write): Remove check for negative size, as the
5596 Emacs source code has been audited now.
9587a89d
PE
5597 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5598 (emacs_read, emacs_write): Use it.
273a5f82
PE
5599 * process.c (send_process): Adjust to the new signatures of
5600 emacs_write and emacs_gnutls_write. Do not attempt to store
5601 a byte offset into an 'int'; it might overflow.
9587a89d 5602 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5603
3e047f51
PE
5604 * sound.c: Don't assume sizes fit in 'int'.
5605 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5606 Return EMACS_INT, not int.
3e047f51 5607 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5608 Accept EMACS_INT, not int.
5609 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5610 record read return values.
5611
cc39a9db
BK
56122011-04-15 Ben Key <bkey76@gmail.com>
5613
c9d0ec6d
JB
5614 * keyboard.c (Qundefined): Don't declare static since it is used
5615 in nsfns.m.
5616 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5617 static since they are used in nsfont.m.
cc39a9db 5618
6c60eb9f
SM
56192011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5620
5621 * process.c (Qprocessp): Don't declare static.
5622 * lisp.h (Qprocessp): Declare again.
5623
7990b61a
JB
56242011-04-15 Juanma Barranquero <lekktu@gmail.com>
5625
5626 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5627
5d4cb038
PE
56282011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5629
8bd7b830 5630 Improve C-level modularity by making more things 'static'.
cd64ea1d 5631
e3b27b31
PE
5632 Don't publish debugger-only interfaces to other modules.
5633 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5634 (verify_bytepos, count_markers): Move decls to the only modules
5635 that need them.
5636 * region-cache.h (pp_cache): Likewise.
5637 * window.h (check_all_windows): Likewise.
5638 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5639
5d4cb038
PE
5640 * sysdep.c (croak): Now static, if
5641 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5642 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5643
5644 * alloc.c (refill_memory_reserve): Now static if
5645 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5646 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5647
e87b6180
PE
5648 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5649 Define only if USE_LUCID.
5650
ac64929e
PE
5651 * xrdb.c (x_customization_string, x_rm_string): Now static.
5652
6f37259d
PE
5653 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5654 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5655
1683e3ab
PE
5656 * xdisp.c (draw_row_with_mouse_face): Now static.
5657 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5658
de9c2632
PE
5659 * window.h (check_all_windows): Mark externally visible.
5660
2b96acb7
PE
5661 * window.c (window_deletion_count): Now static.
5662
5663 * undo.c: Make symbols static if they're not exported.
5664 (last_undo_buffer, last_boundary_position, pending_boundary):
5665 Now static.
5666
50436f33
PE
5667 * textprop.c (interval_insert_behind_hooks): Now static.
5668 (interval_insert_in_front_hooks): Likewise.
5669
64520e5c
PE
5670 * term.c: Make symbols static if they're not exported.
5671 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5672 (max_frame_lines, tty_set_terminal_modes):
5673 (tty_reset_terminal_modes, tty_turn_off_highlight):
5674 (get_tty_terminal): Now static.
5675 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5676 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5677 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5678 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5679 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5680
1fa53021
PE
5681 * sysdep.c: Make symbols static if they're not exported.
5682 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5683 Now static.
5684 (sigprocmask_set, full_mask): Remove; unused.
5685 (wait_debugging): Mark as visible.
5686 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5687 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5688
d4b43b22
PE
5689 * syntax.c (syntax_temp): Define only if !__GNUC__.
5690
b7c513d0
PE
5691 * sound.c (current_sound_device, current_sound): Now static.
5692
989b29ad
PE
5693 * search.c (searchbufs, searchbuf_head): Now static.
5694
13a55a78
PE
5695 * scroll.c (scroll_cost): Remove; unused.
5696 * dispextern.h (scroll_cost): Remove decl.
5697
de68a1fc
PE
5698 * region-cache.h (pp_cache): Mark as externally visible.
5699
40ccffa6
PE
5700 * process.c: Make symbols static if they're not exported.
5701 (process_tick, update_tick, create_process, chan_process):
5702 (Vprocess_alist, proc_buffered_char, datagram_access):
5703 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5704 (deactivate_process): Mark defn as static, as well as decl.
5705 * lisp.h (create_process): Remove decl.
5706 * process.h (chan_process, Vprocess_alist): Remove decls.
5707
ad64fc97
PE
5708 * print.c: Make symbols static if they're not exported.
5709 (print_depth, new_backquote_output, being_printed, print_buffer):
5710 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5711 (print_interval, print_number_index, initial_stderr_stream):
5712 Now static.
5713 * lisp.h (Fprinc): Remove decl.
5714 (debug_output_compilation_hack): Mark as externally visible.
5715
adddb265
PE
5716 * sysdep.c (croak): Move decl from here to syssignal.h.
5717 * syssignal.h (croak): Put it here, so the API can be checked when
5718 'croak' is called from dissociate_if_controlling_tty.
5719
1717ede2
PE
5720 * minibuf.c: Make symbols static if they're not exported.
5721 (minibuf_save_list, choose_minibuf_frame): Now static.
5722 * lisp.h (choose_minibuf_frame): Remove decl.
5723
fa5fb2bc
PE
5724 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5725
1e3890d1
PE
5726 * lread.c: Make symbols static if they're not exported.
5727 (read_objects, initial_obarray, oblookup_last_bucket_number):
5728 Now static.
5729 (make_symbol): Remove; unused.
5730 * lisp.h (initial_obarray, make_symbol): Remove decls.
5731
8a1414fa
PE
5732 * keyboard.c: Make symbols static if they're not exported.
5733 (single_kboard, recent_keys_index, total_keys, recent_keys):
5734 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5735 (this_single_command_key_start, echoing, last_auto_save):
5736 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5737 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5738 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5739 (Vlispy_mouse_stem, double_click_count):
5740 Now static.
5741 (force_auto_save_soon): Define only if SIGDANGER.
5742 (ignore_mouse_drag_p): Now static if
5743 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5744 (print_help): Remove; unused.
5745 (stop_character, last_timer_event): Mark as externally visible.
5746 * keyboard.h (ignore_mouse_drag_p): Declare only if
5747 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5748 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5749 * lisp.h (echoing): Remove decl.
5750 (force_auto_save_soon): Declare only if SIGDANGER.
5751 * xdisp.c (redisplay_window): Simplify code, to make it more
5752 obvious that ignore_mouse_drag_p is not accessed if !defined
5753 USE_GTK && !defined HAVE_NS.
5754
93ea6e8f
PE
5755 * intervals.c: Make symbols static if they're not exported.
5756 (merge_properties_sticky, merge_interval_right, delete_interval):
5757 Now static.
5758 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5759
77382fcc
PE
5760 * insdel.c: Make symbols static if they're not exported.
5761 However, leave prepare_to_modify_buffer alone. It's never
5762 called from outside this function, but that appears to be a bug.
5763 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5764 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5765 (adjust_after_replace_noundo): Remove; unused.
5766 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5767 (signal_before_change): Remove decls.
77382fcc 5768
9306c32e
PE
5769 * indent.c (val_compute_motion, val_vmotion): Now static.
5770
cd44d2eb
PE
5771 * image.c: Make symbols static if they're not exported.
5772 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5773 if USE_GTK.
5774 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5775 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5776
ad9a7a06
PE
5777 * fringe.c (standard_bitmaps): Now static.
5778 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5779
81626931
PE
5780 * frame.c: Make symbols static if they're not exported.
5781 (x_report_frame_params, make_terminal_frame): Now static.
5782 (get_frame_param): Now static, unless HAVE_NS.
5783 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5784 (x_get_resource_string): Remove; not used.
5785 * frame.h (make_terminal_frame, x_report_frame_params):
5786 (x_get_resource_string); Remove decls.
5787 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5788 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5789
239f9db9
PE
5790 * font.c, fontset.c: Make symbols static if they're not exported.
5791 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5792 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5793 * font.c (font_close_object): Now static.
5794 * font.h (font_close_object): Remove.
5795 * fontset.c (FONTSET_OBJLIST): Remove.
5796 (free_realized_fontset) #if-0 the body, which does nothing.
5797 (face_suitable_for_char_p): #if-0, as it's never called.
5798 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5799 * xfaces.c (face_at_string_position):
5800 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5801 since 0 is always ASCII.
5802
dfcf3579
PE
5803 * fns.c (weak_hash_tables): Now static.
5804
5045092b
PE
5805 * fileio.c: Make symbols static if they're not exported.
5806 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5807 (Vwrite_region_annotation_buffers): Now static.
5808
57a96f5c
PE
5809 * eval.c: Make symbols static if they're not exported.
5810 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5811 * lisp.h (backtrace_list): Remove decl.
5812
35f08c38
PE
5813 * emacs.c: Make symbols static if they're not exported.
5814 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5815 (fatal_error_code, fatal_error_signal_hook, standard_args):
5816 Now static.
5817 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5818 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5819 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5820 * lisp.h (fatal_error_signal_hook): Remove decl.
5821 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5822
f44bd759
PE
5823 * editfns.c: Move a (normally-unused) function to its only use.
5824 * editfns.c, lisp.h (get_operating_system_release): Remove.
5825 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5826 worth the hassle of breaking this out.
5827
b532497d
PE
5828 * xterm.c: Make symbols static if they're not exported.
5829 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5830 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5831 (x_destroy_window, x_delete_display):
5832 Now static.
5833 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5834 (x_mouse_leave): Remove; unused.
5835 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5836 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5837 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5838 Remove decls.
5839 (x_mouse_leave): Declare only if WINDOWSNT.
5840 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5841 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5842 USE_X_TOOLKIT.
5843
1675728f
PE
5844 * ftxfont.c: Make symbols static if they're not exported.
5845 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5846 HAVE_FREETYPE.
5847 * font.h (ftxfont_driver): Likewise.
5848
e4cebfca
PE
5849 * xfns.c: Make symbols static if they're not exported.
5850 (x_last_font_name, x_display_info_for_name):
5851 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5852 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5853 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5854 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5855 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5856 (last_show_tip_args): Now static.
5857 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5858 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5859 (x_screen_planes): Remove; unused.
5860 * dispextern.h (x_screen_planes): Remove decl.
5861
5bf46f05
PE
5862 * dispnew.c: Make symbols static if they're not exported.
5863 * dispextern.h (redraw_garbaged_frames, scrolling):
5864 (increment_row_positions): Remove.
5865 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5866 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5867 Now static.
5868 (redraw_garbaged_frames): Remove; unused.
5869
435f4c28
PE
5870 * xfaces.c: Make symbols static if they're not exported.
5871 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5872 Remove decls.
5873 * xterm.h (defined_color): Remove decls.
5874 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5875 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5876 (menu_face_changed_default, defined_color, free_realized_face):
5877 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5878 (ascii_face_of_lisp_face): Remove; unused.
5879
8524aef3
PE
5880 * xdisp.c: Make symbols static if they're not exported.
5881 * dispextern.h (scratch_glyph_row, window_box_edges):
5882 (glyph_to_pixel_coords, set_cursor_from_row):
5883 (get_next_display_element, set_iterator_to_next):
5884 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5885 (show_mouse_face): Remove decls
5886 * frame.h (message_buf_print): Likewise.
5887 * lisp.h (pop_message, set_message, check_point_in_composition):
5888 Likewise.
5889 * xterm.h (set_vertical_scroll_bar): Likewise.
5890 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5891 (message_buf_print, scratch_glyph_row, displayed_buffer):
5892 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5893 (get_next_display_element, show_mouse_face, window_box_edges):
5894 (frame_to_window_pixel_xy, check_point_in_composition):
5895 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5896 (glyph_to_pixel_coords): Remove; unused.
5897
16390cd2
PE
5898 * dired.c (file_name_completion): Now static.
5899
5900 * dbusbind.c (xd_in_read_queued_messages): Now static.
5901
a25f4dfa
PE
5902 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5903 * data.c (circular_list_error): Remove.
5904
14a9c8df
PE
5905 * commands.h (last_point_position, last_point_position_buffer):
5906 (last_point_position_window): Remove decls.
5907 * keyboard.c: Make these variables static.
5908
04f2d78b
CB
5909 * coding.h (coding, code_convert_region, encode_coding_gap):
5910 Remove decls.
74ab6df5
PE
5911 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5912 (iso_code_class, detect_coding, code_convert_region): Now static.
5913 (encode_coding_gap): Remove; unused.
5914
38dfbee1
PE
5915 * chartab.c (chartab_chars, chartab_bits): Now static.
5916
a2cb4e63
PE
5917 * charset.h (charset_iso_8859_1): Remove decl.
5918 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5919 Now static.
5920
127198fd
PE
5921 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5922 * ccl.c (Vccl_program_table): Now static.
5923 (check_ccl_update): Remove; unused.
5924
d85b608f
PE
5925 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5926 * category.h: ... from here.
5927 * category.c (check_category_table, set_category_set): Now static.
5928
31cd66f3
PE
5929 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5930 * lisp.h: Remove these decls.
5931
c358e587
PE
5932 * buffer.c (buffer_count): Remove unused var.
5933
e78aecca
PE
5934 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5935 so that it's not optimized away.
5936 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5937 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5938 exported only to the debugger.
5939
e192d7d3 5940 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5941 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5942
92470028
PE
5943 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5944 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5945 was inaccessible from Lisp.
5946 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5947 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5948
244ed907
PE
5949 alloc.c: Import and export fewer symbols, and remove unused items.
5950 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5951 is defined.
5952 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5953 it's not optimized away by whole-program optimization.
5954 (message_enable_multibyte, free_misc): Remove.
5955 (catchlist, handlerlist, mark_backtrace):
5956 Declare only if BYTE_MARK_STACK.
5957 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5958 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5959 (message_enable_multibyte): Remove decl.
5960 (free_misc, interval_free_list, float_block, float_block_index):
5961 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5962 (cons_free_list, last_marked_index):
5963 Now static.
5964 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5965 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5966 (mark_backtrace): Define only if BYTE_MARK_STACK.
5967 * xdisp.c (message_enable_multibyte): Now static.
5968
61c2b50e 5969 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5970 This makes it easier for human readers (and static analyzers)
5971 to see whether these variables are used from other modules.
5972 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5973 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5974 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5975 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5976 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5977 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5978 * xmenu.c, xselect.c:
5979 Declare Q* vars static if they are not used in other modules.
5980 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5981 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5982 Remove decls of unexported vars.
5983 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5984
95c82688
PE
5985 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5986
16a97296
PE
5987 Make Emacs functions such as Fatom 'static' by default.
5988 This makes it easier for human readers (and static analyzers)
5989 to see whether these functions can be called from other modules.
5990 DEFUN now defines a static function. To make the function external
5991 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5992 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5993 (Finit_image_library):
16a97296
PE
5994 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5995 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5996 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5997 Remove decls, since these functions are now static.
5998 (Funintern, Fget_internal_run_time): New decls, since these functions
5999 were already external.
95c82688 6000
16a97296
PE
6001 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6002 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6003 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6004 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6005 * keyboard.c, keymap.c, lread.c:
6006 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6007 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6008 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6009 Mark functions with DEFUE instead of DEFUN,
6010 if they are used in other modules.
6011 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6012 decls for now-static functions.
6013 * buffer.h (Fdelete_overlay): Remove decl.
6014 * callproc.c (Fgetenv_internal): Mark as internal.
6015 * composite.c (Fremove_list_of_text_properties): Remove decl.
6016 (Fcomposition_get_gstring): New forward static decl.
6017 * composite.h (Fcomposite_get_gstring): Remove decl.
6018 * dired.c (Ffile_attributes): New forward static decl.
6019 * doc.c (Fdocumntation_property): New forward static decl.
6020 * eval.c (Ffetch_bytecode): New forward static decl.
6021 (Funintern): Remove extern decl; now in .h file where it belongs.
6022 * fileio.c (Fmake_symbolic_link): New forward static decl.
6023 * image.c (Finit_image_library): New forward static decl.
6024 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6025 * intervals.h (Fprevious_property_change):
6026 (Fremove_list_of_text_properties): Remove decls.
6027 * keyboard.c (Fthis_command_keys): Remove decl.
6028 (Fcommand_execute): New forward static decl.
6029 * keymap.c (Flookup_key): New forward static decl.
6030 (Fcopy_keymap): Now static.
6031 * keymap.h (Flookup_key): Remove decl.
6032 * process.c (Fget_process): New forward static decl.
6033 (Fprocess_datagram_address): Mark as internal.
6034 * syntax.c (Fsyntax_table_p): New forward static decl.
6035 (skip_chars): Remove duplicate decl.
6036 * textprop.c (Fprevious_property_change): New forward static decl.
6037 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6038 Now internal.
6039 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6040 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6041
785bbd42
PE
6042 * editfns.c (Fformat): Remove unreachable code.
6043
8b913b57
AS
60442011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6045
6046 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6047 change. (Bug#8496)
6048
a6744a35
EZ
60492011-04-13 Eli Zaretskii <eliz@gnu.org>
6050
6051 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6052 when at ZV. (Bug#8487)
6053
e7974947
AS
60542011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6055
baad03f0
AS
6056 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6057 (Bug#8437)
6058 * keyboard.c (parse_tool_bar_item): Likewise.
6059 * sound.c (sound_cleanup, alsa_close): Likewise.
6060 * termcap.c (tgetent): Likewise.
6061 * xfns.c (x_default_font_parameter): Likewise.
6062 * xsettings.c (read_and_apply_settings): Likewise.
6063
e7974947
AS
6064 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6065 (overrun_check_free): Protoize.
6066
28272684
PE
60672011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6068
6069 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6070 since callers should never pass a negative size.
6071 Change the signature to match that of plain 'read' and 'write'; see
6072 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6073 * lisp.h: Update prototypes of emacs_write and emacs_read.
6074
11997c76
EZ
60752011-04-11 Eli Zaretskii <eliz@gnu.org>
6076
6077 * xdisp.c (redisplay_window): Don't try to determine the character
6078 position of the scroll margin if the window start point w->startp
e896f03c 6079 is outside the buffer's accessible region. (Bug#8468)
11997c76 6080
8a2cbd72
EZ
60812011-04-10 Eli Zaretskii <eliz@gnu.org>
6082
6083 Fix write-region and its subroutines for buffers > 2GB.
6084 * fileio.c (a_write, e_write): Modify declaration of arguments and
6085 local variables to support buffers larger than 2GB.
6086 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6087
6088 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6089 argument, local variables, and return value.
6090
6091 * lisp.h: Update prototypes of emacs_write and emacs_read.
6092
6093 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6094
4073e537 60952011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6096
1ebfdcb6
PE
6097 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6098
b2ded58d
PE
6099 Fix more problems found by GCC 4.6.0's static checks.
6100
7d66342c
PE
6101 * xdisp.c (vmessage): Use a better test for character truncation.
6102
bbf47d44
PE
6103 * charset.c (load_charset_map): <, not <=, for optimization,
6104 and to avoid potential problems with integer overflow.
9248994d 6105 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6106 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6107 * editfns.c (Fformat): Likewise.
1e69125e 6108 * syntax.c (skip_chars): Likewise.
3befa583 6109
e3019616
PE
6110 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6111 This also lets GCC 4.6.0 generate slightly better loop code.
6112
becfa255
PE
6113 * callint.c (Fcall_interactively): <, not <=, for optimization.
6114 (Fcall_interactively): Count the number of arguments produced,
6115 not the number of arguments given. This is simpler and lets GCC
6116 4.6.0 generate slightly better code.
6117
dae0cd48
PE
6118 * ftfont.c: Distingish more carefully between FcChar8 and char.
6119 The previous code passed unsigned char * to a functions like
6120 strlen and xstrcasecmp that expect char *, which does not
6121 conform to the C standard.
6122 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6123 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6124 char * when the C standard requires it.
6125
76032d70
PE
6126 * keyboard.c (read_char): Remove unused var.
6127
eb3f1cc8
PE
6128 * eval.c: Port to Windows vsnprintf (Bug#8435).
6129 Include <limits.h>.
6130 (SIZE_MAX): Define if the headers do not.
6131 (verror): Do not give up if vsnprintf returns a negative count.
6132 Instead, grow the buffer. This ports to Windows vsnprintf, which
6133 does not conform to C99. Problem reported by Eli Zaretskii.
6134 Also, simplify the allocation scheme, by avoiding the need for
6135 calling realloc, and removing the ALLOCATED variable.
6136
70476b54
PE
6137 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6138
12020a9e
PE
6139 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6140 But keep the doprint source code for now, as we might revamp it
6141 and use it again (Bug#8435).
ea6c7ae6
PE
6142 * lisp.h (doprnt): Remove.
6143 * Makefile.in (base_obj): Remove doprnt.o.
6144 * deps.mk (doprnt.o): Remove.
6145
5fdb398c
PE
6146 error: Print 32- and 64-bit integers portably (Bug#8435).
6147 Without this change, on typical 64-bit hosts error ("...%d...", N)
6148 was used to print both 32- and 64-bit integers N, which relied on
6149 undefined behavior.
6150 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6151 New macro.
6152 * lisp.h (error, verror): Mark as printf-like functions.
6153 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6154 Report overflow in size calculations when allocating printf buffer.
6155 Do not truncate output string at its first null byte.
6156 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6157 Truncate the output at a character boundary, since vsnprintf does not
6158 do that.
6159 * charset.c (check_iso_charset_parameter): Convert internal
6160 character to string before calling 'error', since %c now has the
6161 printf meaning.
6162 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6163 overflow when computing char to be passed to 'error'. Do not
6164 pass Lisp_Object to 'error'; pass the integer instead.
6165 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6166 formatted with plain %d.
6167
b189fa66
PE
6168 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6169
bff87ef0
PE
6170 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6171
7e2cac20
PE
6172 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6173
ce4d90b5
PE
6174 * xterm.c (x_catch_errors): Remove duplicate declaration.
6175
266c9547
PE
6176 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6177
79c49ad2
PE
6178 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6179
368f4090
JM
61802011-04-10 Jim Meyering <meyering@redhat.com>
6181
6182 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6183 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6184 return ssize_t not "int", and use size_t as the buffer length.
6185 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6186 * gnutls.h: Update declarations.
6187 * process.c (read_process_output): Use ssize_t, to match.
6188 (send_process): Likewise.
6189
a32d4040
CY
61902011-04-09 Chong Yidong <cyd@stupidchicken.com>
6191
6192 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6193
8546720e 61942011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6195
04f2d78b
CB
6196 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6197 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6198
8546720e
GM
6199 * xterm.c (handle_one_xevent):
6200 * xmenu.c (create_and_show_popup_menu):
6201 * xselect.c (x_decline_selection_request)
6202 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6203
0a2f5c1a 62042011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6205
6206 Fix some uses of `int' instead of EMACS_INT.
6207 * search.c (string_match_1, fast_string_match)
6208 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6209 (scan_buffer, find_next_newline_no_quit)
6210 (find_before_next_newline, search_command, Freplace_match)
6211 (Fmatch_data): Make some `int' variables be EMACS_INT.
6212
6213 * xdisp.c (display_count_lines): 3rd argument and return value now
6214 EMACS_INT. All callers changed.
6215 (pint2hrstr): Last argument is now EMACS_INT.
6216
6217 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6218 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6219 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6220 (decode_coding_utf_16, decode_coding_emacs_mule)
6221 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6222 (decode_coding_ccl, decode_coding_charset)
6223 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6224 (decode_coding_iso_2022, decode_coding_emacs_mule)
6225 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6226 <char_offset, last_offset>: Declare EMACS_INT.
6227 (encode_coding_utf_8, encode_coding_utf_16)
6228 (encode_coding_emacs_mule, encode_invocation_designation)
6229 (encode_designation_at_bol, encode_coding_iso_2022)
6230 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6231 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6232 Declare EMACS_INT.
6233 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6234 (encode_invocation_designation): Last argument P_NCHARS is now
6235 EMACS_INT.
6236 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6237 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6238
6239 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6240 All users changed.
6241
6242 * ccl.c (Fccl_execute_on_string): Declare some variables
6243 EMACS_INT.
6244
8546720e 62452011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6246
6247 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6248
4e19a977
CS
62492011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6250
6251 * process.c (Fformat_network_address): Doc fix.
6252
87302331
R
62532011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6254
6255 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6256
cbb59342
CY
62572011-04-08 Chong Yidong <cyd@stupidchicken.com>
6258
6259 * keyboard.c (read_char): Call Lisp function help-form-show,
6260 instead of using internal_with_output_to_temp_buffer.
6261 (Qhelp_form_show): New var.
e0d38eeb 6262 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6263
6264 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6265
6266 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6267
e67a13ab
CY
62682011-04-06 Chong Yidong <cyd@stupidchicken.com>
6269
04f2d78b
CB
6270 * process.c (Flist_processes): Remove to Lisp.
6271 (list_processes_1): Delete.
e67a13ab 6272
973f782d
EZ
62732011-04-06 Eli Zaretskii <eliz@gnu.org>
6274
7c106b1e
EZ
6275 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6276
973f782d
EZ
6277 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6278
41cf7d1a 62792011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6280
ca23cc88
PE
6281 Fix more problems found by GCC 4.6.0's static checks.
6282
f390e2d5
PE
6283 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6284
42eea0d0
PE
6285 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6286
b69769da 6287 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6288
f9541e84
PE
6289 * xdisp.c (vmessage): Mark as a printf-like function.
6290
13841b55
PE
6291 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6292
c136c10f
PE
6293 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6294
5e2d4a30
PE
6295 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6296 printf-like functions.
6297 (tiff_load): Add casts to remove these marks before passing them
6298 to system-supplied API.
6299
583f48b9
PE
6300 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6301
b25d760e
PE
6302 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6303 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6304 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6305 directly, rather than having caller test rule sign. This avoids
6306 some unnecessary tests.
6307 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6308 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6309 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6310
bc7b6697 6311 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6312 (xfont_open): Avoid unnecessary tests.
bc7b6697 6313
27ccc379
PE
6314 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6315
dcd5c89a
PE
6316 * composite.h, composite.c (composition_gstring_put_cache):
6317 Use EMACS_INT, not int, for length.
6318
b13a45c6
PE
6319 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6320 breaking out part of COMPOSITION_DECODE_RULE.
6321 (COMPOSITION_DECODE_RULE): Use it.
6322 * composite.c (get_composition_id): Remove unused local vars,
6323 by using the new macro.
6324
1e792e4d
PE
6325 * textprop.c (set_text_properties_1): Change while to do-while,
6326 since the condition is always true at first.
6327
dc6c6455 6328 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6329 (interval_deletion_adjustment): Return unsigned value.
6330 All uses changed.
dc6c6455 6331
aba7731a
PE
6332 * process.c (list_processes_1, create_pty, read_process_output):
6333 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6334 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6335 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6336 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6337 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6338
fdfc4bf3
PE
6339 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6340
fca8fe46 6341 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6342 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6343
06a0259a 6344 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6345 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6346 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6347
e7b9e80f
PE
6348 * print.c (print_error_message): Avoid int overflow.
6349
56201685
PE
6350 * font.c (font_list_entities): Redo for clarity,
6351 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6352
78834453 6353 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6354 (font_score): Avoid potential overflow in diff calculation.
78834453 6355
0bc0b309 6356 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6357 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6358
e610eaca
PE
6359 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6360
b895abce
PE
6361 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6362 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6363 can always succeed if overflow has undefined behavior.
6364
1f1d9321 6365 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6366 (wordify): Omit three unnecessary tests.
1f1d9321 6367
c59478bc
PE
6368 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6369 All callers changed. This avoids the need for an unused var.
6370
79b73827
PE
6371 * casefiddle.c (casify_region): Remove var that is set but not used.
6372
a4db5dfe
PE
6373 * dired.c (file_name_completion): Remove var that is set but not used.
6374
43aae36e
PE
6375 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6376
2a47c44d 6377 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6378 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6379
a37c69bf
PE
6380 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6381 Check for integer overflow on size calculations.
6382
328ab8e7
PE
6383 * buffer.c (Fprevious_overlay_change): Remove var that is set
6384 but not used.
6385
e5a2a5cb
PE
6386 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6387 Remove vars that are set but not used.
8d84a6eb 6388 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6389 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6390
a60e5f68
PE
6391 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6392
f661cb61 6393 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6394 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6395
f0397f5a
PE
6396 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6397 that are set but not used.
6398
8664db06 6399 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6400 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6401
6abdaa4a
PE
6402 * xselect.c (x_get_local_selection, x_handle_property_notify):
6403 Remove vars that are set but not used.
6404
0ce7538d 6405 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6406 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6407
9ae848fc
PE
6408 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6409 Remove var that is set but not used.
0b918413
PE
6410 (scroll_bar_windows_size): Now size_t, not int.
6411 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6412 Check for overflow.
9ae848fc 6413
a5a62657
PE
6414 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6415 (map_tty_color) [!defined MSDOS]: Likewise.
6416
5c5cdd39
PE
6417 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6418
66ebf983
PE
6419 * coding.c: Remove vars that are set but not used.
6420 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6421 All callers changed.
6422 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6423 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6424 (decode_coding_charset): Remove vars that are set but not used.
6425
1be4d761
PE
6426 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6427 that is set but not used.
6428
47553fa8
PE
6429 * print.c (print_object): Remove var that is set but not used.
6430
1f7196bf 6431 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6432 The gnulib version avoids calling malloc in the usual case,
6433 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6434 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6435 * filelock.c (current_lock_owner): Likewise.
6436 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6437 * sysdep.c: Include allocator.h, careadlinkat.h.
6438 (emacs_no_realloc_allocator): New static constant.
6439 (emacs_readlink): New function.
fdb61804
PE
6440 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6441 ../lib/careadlinkat.h.
d1fdcab7 6442
f84c17c7
SM
64432011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6444
6445 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6446 first non-nil return value).
6447
ef3862ad
JD
64482011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6449
6450 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6451 if not defined (Bug#8403).
6452
376a7006
JB
64532011-04-02 Juanma Barranquero <lekktu@gmail.com>
6454
6455 * xdisp.c (display_count_lines): Remove parameter `start',
6456 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6457 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6458 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6459 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6460 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6461 and thereabouts. All callers changed.
6462 (get_per_char_metric): Remove parameter `f', unused since
6463 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6464
6ca3801d
JM
64652011-04-02 Jim Meyering <meyering@redhat.com>
6466
6467 do not dereference NULL upon failed strdup
6468 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6469 (ns_get_family): Likewise.
6470
d8e2b5ba
JB
64712011-04-02 Juanma Barranquero <lekktu@gmail.com>
6472
6473 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6474
8c74fcbd
JD
64752011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6476
6477 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6478 later (Bug#8403).
6479
7200d79c
SM
64802011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6481
03408648 6482 Add lexical binding.
7200d79c 6483
03408648
SM
6484 * window.c (Ftemp_output_buffer_show): New fun.
6485 (Fsave_window_excursion):
6486 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6487
6488 * lread.c (lisp_file_lexically_bound_p): New function.
6489 (Fload): Bind Qlexical_binding.
6490 (readevalloop): Remove `evalfun' arg.
6491 Bind Qinternal_interpreter_environment.
6492 (Feval_buffer): Bind Qlexical_binding.
6493 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6494 Mark as dynamic.
6495 (syms_of_lread): Declare `lexical-binding'.
6496
6497 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6498
6499 * keyboard.c (eval_dyn): New fun.
6500 (menu_item_eval_property): Use it.
ca105506
SM
6501
6502 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6503
03408648
SM
6504 * fns.c (concat, mapcar1): Accept byte-code-functions.
6505
6506 * eval.c (Fsetq): Handle lexical vars.
6507 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6508 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6509 (FletX, Flet): Obey lexical binding.
6510 (Fcommandp): Handle closures.
6511 (Feval): New `lexical' arg.
6512 (eval_sub): New function extracted from Feval. Use it almost
6513 everywhere where Feval was used. Look up vars in lexical env.
6514 Handle closures.
6515 (Ffunctionp): Move from subr.el.
6516 (Ffuncall): Handle closures.
6517 (apply_lambda): Remove `eval_flags'.
6518 (funcall_lambda): Handle closures and new byte-code-functions.
6519 (Fspecial_variable_p): New function.
6520 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6521 but without exporting it to Lisp.
23aba0ea 6522
23aba0ea 6523 * doc.c (Fdocumentation, store_function_docstring):
03408648 6524 * data.c (Finteractive_form): Handle closures.
23aba0ea 6525
03408648
SM
6526 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6527 interactive spec.
ba83908c 6528
04f2d78b
CB
6529 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6530 New byte-codes.
03408648
SM
6531 (exec_byte_code): New function extracted from Fbyte_code to handle new
6532 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6533
03408648 6534 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6535
03408648 6536 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6537
e2abce01
JB
65382011-03-31 Juanma Barranquero <lekktu@gmail.com>
6539
6540 * xdisp.c (redisplay_internal): Fix prototype.
6541
63696a73 65422011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6543
63696a73 6544 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6545 (try_scrolling): Use it when setting scroll_limit.
6546 Limit scrolling to 100 screen lines.
63696a73
EZ
6547 (redisplay_window): Even when falling back on "recentering",
6548 position point in the window according to scroll-conservatively,
6549 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6550
6551 (try_scrolling): When point is above the window, allow searching
6552 as far as scroll_max, or one screenful, to compute vertical
6553 distance from PT to the scroll margin position. This prevents
6554 try_scrolling from unnecessarily failing when
6555 scroll-conservatively is set to a value slightly larger than the
6556 window height. Clean up the case of PT below the margin at bottom
6557 of window: scroll_max can no longer be INT_MAX. When aggressive
6558 scrolling is in use, don't let point enter the opposite scroll
6559 margin as result of the scroll.
6560 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6561 threshold of 100 lines for never-recentering scrolling.
6562
e4cc2dfc
JB
65632011-03-31 Juanma Barranquero <lekktu@gmail.com>
6564
6565 * dispextern.h (move_it_by_lines):
6566 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6567 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6568 (message_log_check_duplicate): Remove parameters `prev_bol' and
6569 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6570 (redisplay_internal): Remove parameter `preserve_echo_area',
6571 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6572
6573 * indent.c (Fvertical_motion):
6574 * window.c (window_scroll_pixel_based, Frecenter):
6575 Don't pass `need_y_p' to `move_it_by_lines'.
6576
1c470562
SM
65772011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6578
44f230aa
SM
6579 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6580 steal a few bits to be more compact.
6581 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6582 Remove unneeded casts.
6583
1c470562
SM
6584 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6585
888adce9
ZK
65862011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6587
6588 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6589 binding" message (bug#7967).
6590
f838ed7b
PE
65912011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6592
77861b95
PE
6593 Fix more problems found by GCC 4.6.0's static checks.
6594
de6dbc14
PE
6595 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6596 Remove unused local var.
6597
f838ed7b
PE
6598 * editfns.c (Fmessage_box): Remove unused local var.
6599
792c7b2b
PE
6600 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6601 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6602 Omit unused local vars.
c499e557 6603 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6604 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6605 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6606 Omit unused local var.
6607
ba0165e1
PE
6608 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6609 Don't assume string length fits in int.
32ad8845 6610 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6611 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6612
3c59b4c9
PE
6613 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6614 instead of alloca (Bug#8344).
6615
a3eed478 6616 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6617 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6618
eb4d412d
PE
6619 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6620
1658b401
PE
6621 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6622 concerns.
6623
6624 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6625
6626 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6627
9a2c6e05
PE
6628 * keyboard.c (syms_of_keyboard): Use the same style as later
6629 in this function when indexing through an array. This also
6630 works around GCC bug 48267.
6631
03d0a109
PE
6632 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6633
44f730c8
PE
6634 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6635
fe75f926
PE
6636 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6637 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6638
ffa8c828
PE
6639 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6640 This avoids undefined behavior on integer overflow, and is a bit
6641 more convenient anyway since it is compared to a size_t variable.
6642
c5101a77
PE
6643 Variadic C functions now count arguments with size_t, not int.
6644 This avoids an unnecessary limitation on 64-bit machines, which
6645 caused (substring ...) to crash on large vectors (Bug#8344).
6646 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6647 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6648 All variadic functions and their callers changed accordingly.
c5101a77
PE
6649 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6650 * data.c (arith_driver, float_arith_driver): Likewise.
6651 * editfns.c (general_insert_function): Likewise.
6652 * eval.c (struct backtrace.nargs, interactive_p)
6653 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6654 (funcall_lambda, mark_backtrace): Likewise.
6655 * fns.c (concat): Likewise.
6656 * frame.c (x_set_frame_parameters): Likewise.
6657 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6658 0 if not found, not -1. All callers changed.
6659
dd3f25f7
PE
6660 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6661 (stack_copy_size): Now size_t, not int.
6662 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6663
461c2ab9
JB
66642011-03-28 Juanma Barranquero <lekktu@gmail.com>
6665
6666 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6667 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6668 All callers changed.
6669
6670 * lisp.h (multibyte_char_to_unibyte):
6671 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6672 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6673 * character.h (CHAR_TO_BYTE8):
6674 * cmds.c (internal_self_insert):
6675 * editfns.c (general_insert_function):
6676 * keymap.c (push_key_description):
6677 * search.c (Freplace_match):
6678 * xdisp.c (message_dolog, set_message_1): All callers changed.
6679
f6d62986
SM
66802011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6681
6682 * keyboard.c (safe_run_hook_funcall): New function.
6683 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6684 don't set the hook to nil, but remove the offending function instead.
6685 (Qcommand_hook_internal): Remove, unused.
6686 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6687 Vcommand_hook_internal.
6688
6689 * eval.c (enum run_hooks_condition): Remove.
6690 (funcall_nil, funcall_not): New functions.
6691 (run_hook_with_args): Call each function through a `funcall' argument.
6692 Remove `cond' argument, now redundant.
6693 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6694 (Frun_hook_with_args_until_failure): Adjust accordingly.
6695 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6696
1db5b1ad
JB
66972011-03-28 Juanma Barranquero <lekktu@gmail.com>
6698
6699 * dispextern.h (string_buffer_position): Remove declaration.
6700
6701 * print.c (strout): Remove parameter `multibyte', unused since
6702 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6703
6704 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6705 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6706 All callers changed.
6707
6708 * w32.c (_wsa_errlist): Use braces for struct initializers.
6709
6710 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6711 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6712 All callers changed.
6713 (string_buffer_position): Likewise. Also, make static (it's never
6714 used outside xdisp.c).
6715 (cursor_row_p): Remove parameter `w', unused since
6716 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6717 (decode_mode_spec): Remove parameter `precision', introduced during
6718 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6719 All callers changed.
6720
5ffb62aa
JD
67212011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6722
6723 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6724
461c2ab9 67252011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6726
6727 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6728 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6729 (ns_update_auto_hide_menu_bar): New functions.
6730 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6731 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6732 ns_constrain_all_frames.
6733 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6734 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6735
5c380ffb
JD
67362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6737
6738 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6739
9af30bdf
GM
67402011-03-27 Glenn Morris <rgm@gnu.org>
6741
6742 * syssignal.h: Replace RETSIGTYPE with void.
6743 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6744 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6745 Replace SIGTYPE with void everywhere.
6746 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6747 * s/template.h (SIGTYPE): Remove commented out definition.
6748
e2abce01
JB
67492011-03-26 Eli Zaretskii <eliz@gnu.org>
6750
6751 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6752 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6753
f868cd8a
JB
67542011-03-26 Juanma Barranquero <lekktu@gmail.com>
6755
59eb0929
JB
6756 * w32.c (read_unc_volume): Use parameter `henum', instead of
6757 global variable `wget_enum_handle'.
6758
6759 * keymap.c (describe_vector): Remove parameters `indices' and
6760 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6761 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6762
f868cd8a
JB
6763 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6764
6765 * keyboard.c (timer_check): Remove parameter `do_it_now',
6766 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6767 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6768 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6769
6770 * keyboard.c (read_char):
6771 * w32menu.c (w32_menu_display_help):
6772 * xmenu.c (show_help_event, menu_help_callback):
6773 Adjust calls to `show_help_echo'.
6774
6775 * gtkutil.c (xg_maybe_add_timer):
6776 * keyboard.c (readable_events):
6777 * process.c (wait_reading_process_output):
6778 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6779
6780 * insdel.c (adjust_markers_gap_motion):
6781 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6782 (gap_left, gap_right): Don't call it.
6783
2ecf6fdb
CY
67842011-03-25 Chong Yidong <cyd@stupidchicken.com>
6785
6786 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6787 incurred during fontification.
6788
6b1f9ba4
JB
67892011-03-25 Juanma Barranquero <lekktu@gmail.com>
6790
6791 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6792 (DEFVAR_PER_BUFFER): Don't pass it.
6793
6794 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6795 (scrolling_window): Don't pass it.
6796
0f4a96b5
JB
67972011-03-25 Juanma Barranquero <lekktu@gmail.com>
6798
6799 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6800
6801 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6802 and `suffix'.
6803 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6804 of variables specific to SELinux and computation of `encoded_absname'.
6805
6806 * image.c (XPutPixel): Remove unused variable `height'.
6807
6808 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6809
6810 * unexw32.c (get_section_info): Remove unused variable `section'.
6811
6812 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6813 (system_process_attributes): Remove unused variable `sess'.
6814 (sys_read): Remove unused variable `err'.
6815
6816 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6817 (w32_wnd_proc): Remove unused variable `isdead'.
6818 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6819 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6820 (x_create_tip_frame): Remove unused variable `tem'.
6821
6822 * w32inevt.c (w32_console_read_socket):
6823 Remove unused variable `no_events'.
6824
6825 * w32term.c (x_draw_composite_glyph_string_foreground):
6826 Remove unused variable `width'.
6827
1149507c
JB
68282011-03-24 Juanma Barranquero <lekktu@gmail.com>
6829
6830 * w32term.c (x_set_glyph_string_clipping):
6831 Don't pass uninitialized region to CombineRgn.
6832
9c88f339
JB
68332011-03-23 Juanma Barranquero <lekktu@gmail.com>
6834
6835 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6836 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6837 (Fx_close_connection): Remove unused variable `i'.
6838
6839 * w32font.c (w32font_draw): Return number of glyphs.
6840 (w32font_open_internal): Remove unused variable `i'.
6841 (w32font_driver): Add missing initializer.
6842
6843 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6844 (fill_in_menu): Remove unused variable `items_added'.
6845
6846 * w32term.c (last_mouse_press_frame): Remove static global variable.
6847 (w32_clip_to_row): Remove unused variable `f'.
6848 (x_delete_terminal): Remove unused variable `i'.
6849
6850 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6851 (NOTHING): Remove unused static global variable.
6852 (uniscribe_check_otf): Remove unused variable `table'.
6853 (uniscribe_font_driver): Add missing initializers.
6854
dee091a3
JD
68552011-03-23 Julien Danjou <julien@danjou.info>
6856
6857 * term.c (Fsuspend_tty, Fresume_tty):
6858 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6859 * window.c (temp_output_buffer_show):
6860 * insdel.c (signal_before_change):
6861 * frame.c (Fhandle_switch_frame):
6862 * fileio.c (Fdo_auto_save):
6863 * emacs.c (Fkill_emacs):
6864 * editfns.c (save_excursion_restore):
6865 * cmds.c (internal_self_insert):
6866 * callint.c (Fcall_interactively):
6867 * buffer.c (Fkill_all_local_variables):
6868 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6869 Use Frun_hooks.
0f4a96b5 6870 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6871 unconditionnaly since it does the check itself.
6872
2c520ab5 68732011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6874
c9c49752
PE
6875 Fix more problems found by GCC 4.5.2's static checks.
6876
8abc3f12
PE
6877 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6878 the first time through the loop, since we know p0 < p1 then.
6879 This also avoids a gcc -Wstrict-overflow warning.
6880
a2d26660
PE
6881 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6882 leading to a memory leak, possible in functions like
6883 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6884 of objects (Bug#8318).
a2d26660 6885
916c72e9
PE
6886 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6887 that could (at least in theory) be that large.
6888
19ab8a18
PE
6889 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6890 This is less likely to overflow, and avoids undefined behavior if
6891 overflow does occur. All callers changed. Use strtoul to scan
6892 for the unsigned long integer.
b7cbbd6f
PE
6893 (pint2hrstr): Simplify and tune code slightly.
6894 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6895
f0641eff
PE
6896 * scroll.c (do_scrolling): Work around GCC bug 48228.
6897 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6898
7f650bb9
PE
6899 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6900 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6901 (validate_x_resource_name): Simplify count usage.
6902 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6903
37dd57d1
PE
6904 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6905 fail (Bug#8306).
81e56e61 6906
699979fc 6907 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6908
401bf9b4
PE
6909 * process.c (Fmake_network_process): Use socklen_t, not int,
6910 where POSIX says socklen_t is required in portable programs.
6911 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6912 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6913 (Fmake_network_process, server_accept_connection):
6914 (wait_reading_process_output, read_process_output):
6915 Likewise.
6916
b93aacde
PE
6917 * process.c: Rename or move locals to avoid shadowing.
6918 (list_processes_1, Fmake_network_process):
6919 (read_process_output_error_handler, exec_sentinel_error_handler):
6920 Rename or move locals.
4dc343ee 6921 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6922 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6923 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6924 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6925 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6926
af8a867c 6927 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6928 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6929 Include tparam.h instead, since it declares them.
af8a867c
PE
6930 * cm.h (PC): Remove extern decl; tparam.h now does this.
6931 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6932 * terminfo.c: Include tparam.h, to check interfaces.
6933 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6934 (tparam): Adjust signature to match interface in tparam.h;
6935 this removes some undefined behavior. Check that outstring and len
6936 are zero, which they always are with Emacs.
6937 * tparam.h (PC, BC, UP): New extern decls.
6938
0248044d 6939 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6940 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6941
8ff096c1 6942 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6943 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6944 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6945 (ftfont_list): Remove unused local.
49eaafba
PE
6946 (get_adstyle_property, ftfont_pattern_entity):
6947 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6948 Rename locals to avoid shadowing.
8ff096c1 6949
e2be39f6
PE
6950 * xfont.c (xfont_list_family): Mark var as initialized.
6951
c9735e30
PE
6952 * xml.c (make_dom): Now static.
6953
8f5201ae
PE
6954 * composite.c (composition_compute_stop_pos): Rename local to
6955 avoid shadowing.
b246f932
PE
6956 (composition_reseat_it): Remove unused locals.
6957 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6958 (composition_update_it): Mark var as initialized.
11b61122
PE
6959 (find_automatic_composition): Mark vars as initialized,
6960 with a FIXME (Bug#8290).
8f5201ae 6961
760fbc2c
PE
6962 character.h: Rename locals to avoid shadowing.
6963 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6964 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6965 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6966 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6967 to avoid shadowing.
6968
ff08eb85
PE
6969 * textprop.c (property_change_between_p): Remove; unused.
6970
fc7bf025
PE
6971 * intervals.c (interval_start_pos): Now static.
6972
235d7abc
PE
6973 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6974
44f230aa
SM
6975 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6976 Rename locals to avoid shadowing.
3e7d6594 6977
50060332
PE
6978 * sound.c (wav_play, au_play, Fplay_sound_internal):
6979 Fix pointer signedness.
d01f234b 6980 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6981 (wav_play): Initialize a variable to 0, to prevent undefined
6982 behavior (Bug#8278).
50060332 6983
c4fc4e30
PE
6984 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6985
918436ed
PE
6986 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6987
c939f91b
PE
6988 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6989 clobbering (Bug#8298).
b9c7f648
PE
6990 * sysdep.c (sys_subshell): Likewise.
6991 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6992
6bd8c144
PE
6993 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6994 This should get cleaned up, so that child_setup has the
6995 same signature on all platforms.
6996
7710357c 6997 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6998 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6999
c59da222
CY
70002011-03-22 Chong Yidong <cyd@stupidchicken.com>
7001
7002 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7003 not to be necessary, and produces flickering.
7004
66b87493
GM
70052011-03-20 Glenn Morris <rgm@gnu.org>
7006
7007 * config.in: Remove file.
7008
45b6f6d5
JB
70092011-03-20 Juanma Barranquero <lekktu@gmail.com>
7010
7011 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7012 are now in src/globals.h.
7013 (syms_of_minibuf): Remove spurious & from previous change.
7014
3ec03f7e
LL
70152011-03-20 Leo <sdl.web@gmail.com>
7016
7017 * minibuf.c (completing-read-function): New variable.
7018 (completing-read-default): Rename from completing-read.
7019 (completing-read): Call completing-read-function.
7020
b14e3e21
CY
70212011-03-19 Juanma Barranquero <lekktu@gmail.com>
7022
7023 * xfaces.c (Fx_load_color_file):
7024 Read color file from absolute filename (bug#8250).
7025
f2b726e6
JB
70262011-03-19 Juanma Barranquero <lekktu@gmail.com>
7027
7028 * makefile.w32-in: Update dependencies.
7029
09f6ff02
EZ
70302011-03-17 Eli Zaretskii <eliz@gnu.org>
7031
7032 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7033
29a6015a
PE
70342011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7035
a3a6c54e
PE
7036 Fix more problems found by GCC 4.5.2's static checks.
7037
b766f867
PE
7038 * process.c (make_serial_process_unwind, send_process_trap):
7039 (sigchld_handler): Now static.
7040
be02381c
PE
7041 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7042 That way, the code declares only the vars that it needs.
7043 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7044 * s/cygwin.h (PTY_ITERATION): Likewise.
7045 * s/darwin.h (PTY_ITERATION): Likewise.
7046 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7047
57048744
PE
7048 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7049 * process.c (allocate_pty): Don't declare stb unless it's needed.
7050
7914961c 7051 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7052 (CONSTANTLIM): Remove; unused.
7053 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7054 Define only if needed.
7914961c 7055
b3967b18
PE
7056 * unexelf.c (unexec): Name an expression,
7057 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7058 Use a different way to cause a compilation error if anyone uses
7059 n rather than nn, a way that does not involve shadowing.
73366a00 7060 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7061
29a6015a
PE
7062 * deps.mk (unexalpha.o): Remove; unused.
7063
43cfc33e 7064 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7065 * unexec.h: New file.
ce701a33
PE
7066 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7067 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7068 Depend on unexec.h.
7069 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7070 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7071 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7072 Change as necessary to match prototype in unexec.h.
ce701a33 7073
01f44d5a
PE
7074 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7075 shadowing.
4f63c6bb 7076 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7077
a6670b0b
PE
7078 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7079 Rename locals to avoid shadowing.
7080
cef2010d 7081 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7082 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7083
d4d7173a
PE
7084 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7085
f08b802a
PE
7086 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7087 warning when compiling print.c.
7088
3ddb0639
PE
7089 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7090 instead of using an uninitialized var.
5ad03b97 7091 (font_sort_entities): Mark var as initialized.
3ddb0639 7092
170a2692
PE
7093 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7094
e663c700
PE
7095 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7096 pointers to constants.
89bc529a 7097 (font_parse_fcname): Remove unused vars.
7b81e2d0 7098 (font_delete_unmatched): Now static.
ea838e10 7099 (font_get_spec): Remove; unused.
13a547c6
PE
7100 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7101 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7102 Rename or move locals to avoid shadowing.
e663c700 7103
2a80c887 7104 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7105 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7106
1384fa33 7107 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7108 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7109
8b2c52e9
PE
7110 * alloc.c (mark_backtrace): Move decl from here ...
7111 * lisp.h: ... to here, so that it can be checked.
7112
475545b5 7113 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7114 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7115 (lisp_indirect_variable): Name an expression,
7116 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7117 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7118
b1349114 7119 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7120 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7121 Use const pointer when appropriate.
b1349114 7122
a2928364
PE
7123 * lisp.h (get_system_name, get_operating_system_release):
7124 Move decls here, to check interfaces.
7125 * process.c (get_operating_system_release): Move decl to lisp.h.
7126 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7127 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7128 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7129 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7130 (Fformat_time_string, Fencode_time, Finsert_char):
7131 (Ftranslate_region_internal, Fformat):
7132 Rename or remove local vars to avoid shadowing.
9710023e 7133 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7134
a415e694
PE
7135 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7136 avoid shadowing.
7137
8ef4622d
PE
7138 * lisp.h (eassert): Check that the argument compiles, even if
7139 ENABLE_CHECKING is not defined.
7140
946f9a5b
PE
7141 * data.c (Findirect_variable): Name an expression, to avoid
7142 gcc -Wbad-function-cast warning.
112396d6 7143 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7144 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7145 (Fmake_variable_buffer_local, Fmake_local_variable):
7146 Mark variables as initialized.
52746918 7147 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7148
e5aab7e7 7149 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7150 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7151 Rename locals to avoid shadowing.
dff45157
PE
7152 (mark_stack): Move local variables into the #ifdef region where
7153 they're used.
7bc26fdb
PE
7154 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7155 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7156 needed otherwise.
7157 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7158 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7159 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7160
e5aab7e7
PE
7161 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7162 avoids undefined behavior in theory.
7163
4da60324
PE
7164 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7165
88043301
PE
7166 Use functions, not macros, for up- and down-casing (Bug#8254).
7167 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7168 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7169 to use the following functions instead of these macros.
7170 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7171 EMACS_INT, since callers assume the returned value fits in int.
7172 (upcase1): Likewise, for UPCASE_TABLE.
7173 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7174 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7175 the race-condition problem in the old DOWNCASE.
88043301 7176
19ed5445
PE
7177 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7178 Rename locals to avoid shadowing.
7179 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7180 (regex_compile, re_search_2, re_match_2_internal):
7181 Remove unused local vars.
952db0d7
PE
7182 (FREE_VAR): Rewrite so as not to use empty "else",
7183 which gcc can warn about.
da053e48 7184 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7185 (RETALLOC_IF): Define only if needed.
7186 (WORDCHAR_P): Likewise. This one is never needed, but is used
7187 only in a comment talking about a compiler bug, so put inside
7188 the #if 0 of that comment.
7189 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7190 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7191 Remove; unused.
19ed5445 7192
1f3561e4 7193 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7194 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7195 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7196
ded6f8f7
PE
7197 * search.c (simple_search): Remove unused var.
7198
dbd37a95
PE
7199 * dired.c (compile_pattern): Move decl from here ...
7200 * lisp.h: ... to here, so that it can be checked.
7201 (struct re_registers): New forward decl.
7202
7e47afad
PE
7203 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7204
85f24f61
PE
7205 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7206 All uses changed.
7207 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7208 Rename locals to avoid shadowing.
5671df8f 7209 (Fvertical_motion): Mark locals as initialized.
85f24f61 7210
181aa2be 7211 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7212 (casify_region): Mark local as initialized.
181aa2be 7213
930d429c
PE
7214 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7215
7082eac6
PE
7216 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7217 New macros, so that the caller can use some names other than
7218 gcpro1, gcpro2, etc.
7219 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7220 of the new macros.
7221 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7222 argument, for consistency with GCPRO2_VAR, etc: it is now the
7223 prefix of the variable, not the variable itself. All uses
7224 changed.
38b2c076
PE
7225 * dired.c (directory_files_internal, file_name_completion):
7226 Rename locals to avoid shadowing.
7227
15206ed9
PE
7228 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7229 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7230 dired.c's scmp function, had undefined behavior.
7231 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7232 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7233 * buffer.h: ... to here, because these macros use current_buffer,
7234 and the new implementation with inline functions needs to have
7235 current_buffer in scope now, rather than later when the macros
7236 are used.
7237 (downcase, upcase1): New static inline functions.
7238 (DOWNCASE, UPCASE1): Reimplement using these functions.
7239 This avoids undefined behavior in expressions like
7240 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7241 from race conditions in accessing the global variables
7242 case_temp1 and case_temp2.
7243 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7244 * lisp.h (case_temp1, case_temp2): Remove their decls.
7245 * character.h (ASCII_CHAR_P): Move from here ...
7246 * lisp.h: ... to here, so that the inline functions mentioned
7247 above can use them.
7248
4a6bea26
PE
7249 * dired.c (directory_files_internal_unwind): Now static.
7250
f14b7e14
PE
7251 * fileio.c (file_name_as_directory, directory_file_name):
7252 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7253 Now static.
2893f146
PE
7254 (file_name_as_directory): Use const pointers when appropriate.
7255 (Fexpand_file_name): Likewise. In particular, newdir might
7256 point at constant storage, so make it a const pointer.
fd4ead52 7257 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7258 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7259 signedness issues.
f839df0c
PE
7260 (Fset_file_times, Finsert_file_contents, auto_save_error):
7261 Rename locals to avoid shadowing.
f14b7e14 7262
5716756e 7263 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7264 (Ftry_completion, Fall_completions): Rename or remove locals
7265 to avoid shadowing.
5716756e 7266
b4c3046a
PE
7267 * marker.c (bytepos_to_charpos): Remove; unused.
7268
b45db522
PE
7269 * lisp.h (verify_bytepos, count_markers): New decls,
7270 so that gcc does not warn that these functions aren't declared.
7271
85876d07
PE
7272 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7273 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7274 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7275 (copy_text): Remove unused local var.
85876d07 7276
03d78a21 7277 * filelock.c (within_one_second): Now static.
b3dd38ab 7278 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7279
5df8f01b
PE
7280 * buffer.c (fix_overlays_before): Mark locals as initialized.
7281 (fix_start_end_in_overlays): Likewise. This function should be
7282 simplified by using pointers-to-pointers, but that's a different
7283 matter.
b1d876f1 7284 (switch_to_buffer_1): Now static.
8f54f30a
PE
7285 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7286 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7287
a70072c9 7288 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7289 Fix pointer signedness issue.
edced198
PE
7290 (sys_subshell): Mark local as volatile if checking for lint,
7291 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7292 (MAXPATHLEN): Define only if needed.
a70072c9 7293
a0977c44
PE
7294 * process.c (serial_open, serial_configure): Move decls from here ...
7295 * systty.h: ... to here, so that they can be checked.
7296
a884fdcc
PE
7297 * fns.c (get_random, seed_random): Move extern decls from here ...
7298 * lisp.h: ... to here, so that they can be checked.
7299
604efe86 7300 * sysdep.c (reset_io): Now static.
b8950c94 7301 (wait_for_termination_signal): Remove; unused.
604efe86 7302
38fc62d9
PE
7303 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7304 (copy_keymap_item, append_key, push_text_char_description):
7305 Now static.
1004a21a 7306 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7307 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7308 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7309 (describe_map_tree):
7310 Rename locals to avoid shadowing.
38fc62d9 7311
2f2650da
PE
7312 * keyboard.c: Declare functions static if they are not used elsewhere.
7313 (echo_char, echo_dash, cmd_error, top_level_2):
7314 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7315 (read_char, kbd_buffer_get_event, make_lispy_position):
7316 (make_lispy_event, make_lispy_movement, apply_modifiers):
7317 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7318 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7319 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7320 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7321 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7322
a053e86c 7323 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7324 (mark_kboards): Move decl here ...
7325 * alloc.c (mark_kboards): ... from here.
a053e86c 7326
4752793e
PE
7327 * lisp.h (force_auto_save_soon): New decl.
7328
74f10ca7 7329 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7330 (DEFINE_DUMMY_FUNCTION): New macro.
7331 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7332 Use it.
c03cd23f
PE
7333 (main): Add casts to avoid warnings
7334 if GCC considers string literals to be constants.
74f10ca7 7335
022e70d4
PE
7336 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7337
59d6fe83
PE
7338 * dbusbind.c: Pointer signedness fixes.
7339 (xd_signature, xd_append_arg, xd_initialize):
7340 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7341 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7342 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7343 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7344
78320123
PE
7345 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7346 if GCC considers string literals to be constants.
49cebcca 7347 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7348
35ac2a97
SM
73492011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7350
fb103ca9
SM
7351 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7352 (print_preprocess, print_object): New macro to fix last change.
7353
35ac2a97
SM
7354 * print.c (print_preprocess): Don't forget font objects.
7355
62973b41
JB
73562011-03-16 Juanma Barranquero <lekktu@gmail.com>
7357
7358 * emacs.c (USAGE3): Doc fixes.
7359
0e48bb22
AS
73602011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7361
7362 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7363 structure.
7364
7684e57b
JB
73652011-03-14 Juanma Barranquero <lekktu@gmail.com>
7366
7367 * lisp.h (VWindow_system, Qfile_name_history):
7368 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7369 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7370 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7371
7372 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7373 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7374
7375 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7376 * w32console.c (detect_input_pending, read_input_pending)
7377 (encode_terminal_code):
7378 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7379 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7380 (w32_system_caret_y, Qfile_name_history):
7381 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7382 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7383 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7384 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7385 * w32proc.c (Qlocal, report_file_error):
7386 * w32term.c (Vwindow_system, updating_frame):
7387 * w32uniscribe.c (initialized, uniscribe_font_driver):
7388 Remove unneeded extern declarations.
7389
2aa46d6c
CY
73902011-03-14 Chong Yidong <cyd@stupidchicken.com>
7391
c96bbc66 7392 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7393
cffc6f3b
CY
73942011-03-13 Chong Yidong <cyd@stupidchicken.com>
7395
7396 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7397 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7398 These macros can no longer be used for assignment.
7399
44f230aa
SM
7400 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7401 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7402 (record_buffer_markers, fetch_buffer_markers): New functions for
7403 recording and fetching special buffer markers.
7404 (set_buffer_internal_1, set_buffer_temp): Use them.
7405
7406 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7407
7408 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7409
7410 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7411 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7412
7413 * xdisp.c (hscroll_window_tree):
7414 (reconsider_clip_changes): Use PT instead of BUF_PT.
7415
d251f04b
EZ
74162011-03-13 Eli Zaretskii <eliz@gnu.org>
7417
7418 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7419 $(EMACS_ROOT)/lib/intprops.h.
7420
f0c77cd1
PE
74212011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7422
3eca4629
PE
7423 Fix more problems found by GCC 4.5.2's static checks.
7424
7c86ee98
PE
7425 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7426 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7427 (xg_free_frame_widgets): Make it clear that a local variable is
7428 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7429 (gdk_window_get_screen): Make it clear that this macro is needed
7430 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7431 (int_gtk_range_get_value): New function, which avoids a diagnostic
7432 from gcc -Wbad-function-cast.
7433 (xg_set_toolkit_scroll_bar_thumb): Use it.
7434 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7435 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7436 (get_utf8_string, xg_get_file_with_chooser):
7437 Rename locals to avoid shadowing.
7438 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7439
41729b81
PE
7440 * xgselect.c (xg_select): Remove unused var.
7441
f0c77cd1
PE
7442 * image.c (four_corners_best): Mark locals as initialized.
7443 (gif_load): Initialize transparent_p to zero (Bug#8238).
7444 Mark another local as initialized.
ec6cf4c6 7445 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7446
ce0ad53d 7447 * image.c (clear_image_cache): Now static.
d5d5a617 7448 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7449 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7450 (x_edge_detection): Remove unnecessary cast that
7451 gcc -Wbad-function-cast diagnoses.
2037898d 7452 (gif_load): Fix pointer signedness.
6ae141d6
PE
7453 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7454 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7455
33383987 74562011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7457
d32df629
PE
7458 Improve quality of tests for time stamp overflow.
7459 For example, without this patch (encode-time 0 0 0 1 1
7460 1152921504606846976) returns the obviously-bogus value (-948597
7461 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7462 reports time overflow. See
7463 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7464 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7465 * editfns.c: Include limits.h and intprops.h.
7466 (TIME_T_MIN, TIME_T_MAX): New macros.
7467 (time_overflow): Move earlier, to before first use.
7468 (hi_time, lo_time): New functions, for an accurate test for
7469 out-of-range times.
7470 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7471 (Fget_internal_run_time): Don't assume time_t fits in int.
7472 (make_time): Use list2 instead of Fcons twice.
7473 (Fdecode_time): More accurate test for out-of-range times.
7474 (check_tm_member): New function.
7475 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7476 (lisp_time_argument): Don't rely on undefined left-shift and
7477 right-shift behavior when checking for time stamp overflow.
8be6f318 7478
fe31d94c
PE
7479 * editfns.c (time_overflow): New function, refactoring common code.
7480 (Fformat_time_string, Fdecode_time, Fencode_time):
7481 (Fcurrent_time_string): Use it.
7482
8be6f318
PE
7483 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7484 * dired.c (make_time): Move to ...
7485 * editfns.c (make_time): ... here.
7486 * systime.h: Note the move.
7487
09d9db2c 74882011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7489
126bc0dc
YM
7490 * fringe.c (update_window_fringes): Remove unused variables.
7491
c47cbdfd
YM
7492 * unexmacosx.c (copy_data_segment): Also copy __got section.
7493 (Bug#8223)
7494
7ac80be9
EZ
74952011-03-12 Eli Zaretskii <eliz@gnu.org>
7496
c96bbc66 7497 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7498 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7499 Constify `char *' arguments and their references according to
7500 prototypes in tparam.h.
7501
ecb0f94d 7502 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7503
7ac80be9
EZ
7504 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7505 Adapt all references accordingly.
7506
7507 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7508
ef1fd07e
TT
75092011-03-11 Tom Tromey <tromey@redhat.com>
7510
7511 * buffer.c (syms_of_buffer): Remove obsolete comment.
7512
7ef4b50c
EZ
75132011-03-11 Eli Zaretskii <eliz@gnu.org>
7514
7515 * termhooks.h (encode_terminal_code): Declare prototype.
7516
7517 * msdos.c (encode_terminal_code): Don't declare prototype.
7518
7519 * term.c (encode_terminal_code): Now external again, used by
7520 w32console.c and msdos.c.
7521
44f230aa
SM
7522 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7523 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7524
4b1ec863 75252011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7526
1714f52b 7527 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7528
4b1ec863
PE
7529 * fringe.c (update_window_fringes): Mark locals as initialized
7530 (Bug#8227).
7531 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7532
524c7aa6
PE
7533 * alloc.c (mark_fringe_data): Move decl from here ...
7534 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7535 to check its interface.
7536 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7537
a5c0af81 7538 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7539 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7540 (fontset_font): Mark local as initialized.
a9a06e0b 7541 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7542
b4716021
PE
7543 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7544
811e9bac 7545 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7546 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7547 (x_own_selection, Fx_disown_selection_internal): Rename locals
7548 to avoid shadowing.
7549 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7550
7e3ab302
PE
7551 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7552 so that the caller can use some name other than gcpro1.
7553 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7554 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7555 (Fx_backspace_delete_keys_p):
7556 Use them to avoid shadowing, and rename vars to avoid shadowing.
7557 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7558 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7559 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7560 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7561 Remove unused locals.
7e3ab302
PE
7562 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7563 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7564 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7565 macros.
f78faa98 7566
e2b13473
PE
7567 * xterm.h (x_mouse_leave): New decl.
7568
77f23912
PE
7569 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7570 Remove unused functions.
cdf4ba58
PE
7571 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7572 (x_calc_absolute_position): Now static.
7411c686 7573 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7574 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7575 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7576 unless they are used.
38d0b34a
PE
7577 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7578 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7579 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7580 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7581 (x_error_catcher, x_connection_closed, x_error_handler):
7582 (x_error_quitter, xembed_send_message, x_iconify_frame):
7583 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7584 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7585 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7586
44f230aa
SM
7587 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7588 Rename or move locals to avoid shadowing.
6b463e58 7589 (tty_defined_color, merge_face_heights): Now static.
5967d051 7590 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7591 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7592 does not deduce is never used uninitialized.
73719eba
PE
7593 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7594 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7595
426994c3 7596 * terminal.c (store_terminal_param): Now static.
5489860b 7597
032f1620 7598 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7599 (set_frame_menubar): Remove unused local.
d4323972 7600 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7601 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7602 since they might point to immutable storage.
281585b0
PE
7603 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7604 since it's unused otherwise.
032f1620 7605
367c19e5 7606 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7607 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7608 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7609 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7610 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7611 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7612 does not deduce are never used uninitialized.
70739cbe 7613
07b48fa9
PE
7614 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7615
8868a238 7616 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7617 * window.c (window_loop, size_window):
7618 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7619
7e5cf297 7620 * window.c (display_buffer): Now static.
d6550a9f
PE
7621 (size_window): Mark variables that gcc -Wuninitialized
7622 does not deduce are never used uninitialized.
a586633d
PE
7623 * window.h (check_all_windows): New decl, to forestall
7624 gcc -Wmissing-prototypes diagnostic.
5b555da1 7625 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7626
f6095868
PE
7627 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7628 shadowing.
7629 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7630 Include <limits.h>.
7631 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7632 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7633 (load_charset_map): Mark variables that gcc -Wuninitialized
7634 does not deduce are never used uninitialized.
53df7c11 7635 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7636
f38b440c
PE
7637 * coding.c (coding_set_source, coding_set_destination):
7638 Use "else { /* comment */ }" rather than "else /* comment */;"
7639 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7640 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7641 a block, when the outer 'i' will do.
7642 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7643 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7644 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7645 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7646 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7647 Rename locals to avoid shadowing.
7648 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7649 * coding.c (emacs_mule_char, encode_invocation_designation):
7650 Now static, since they're not used elsewhere.
413bb2db 7651 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7652 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7653 (decode_coding_emacs_mule): Mark variables that gcc
7654 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7655 (detect_coding_iso_2022): Initialize a local variable that might
7656 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7657 this initialization is needed. (Bug#8211)
5f58e762
PE
7658 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7659 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7660 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7661 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7662 Remove unused macros.
f38b440c 7663
232b38b9 7664 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7665 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7666 * character.c (string_count_byte8): Likewise.
232b38b9 7667
fb90da1b
PE
7668 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7669 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7670
fb93dbc2
PE
7671 * chartab.c (copy_sub_char_table): Now static, since it's not used
7672 elsewhere.
5c156ace
PE
7673 (sub_char_table_ref_and_range, char_table_ref_and_range):
7674 Rename locals to avoid shadowing.
bbcd0949 7675 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7676
7d3b3862 7677 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7678 (BIDI_BOB): Remove unused macro.
7d3b3862 7679
6be7d3da
PE
7680 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7681 deduce are never used uninitialized.
c2ed9c8b 7682 * term.c (encode_terminal_code): Likewise.
6be7d3da 7683
75f8807f 7684 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7685
50938595
PE
7686 * tparam.h: New file.
7687 * term.c, tparam.h: Include it.
7688 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7689 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7690 Move these decls to tparam.h, and make them agree with what
7691 is actually in tparam.c. The previous trick of using incompatible
7692 decls in different modules does not conform to the C standard.
7693 All callers of tparam changed to use tparam's actual API.
7694 * tparam.c (tparam1, tparam, tgoto):
7695 Use const pointers where appropriate.
7696
fbceeba2
PE
7697 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7698 * cm.h (struct cm): Likewise.
7699 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7700 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7701 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7702 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7703 (turn_on_face, init_tty): Likewise.
7704 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7705
7f3f1250
PE
7706 * term.c (term_mouse_position): Rename local to avoid shadowing.
7707
e6ca6543
PE
7708 * alloc.c (mark_ttys): Move decl from here ...
7709 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7710
c40f8d15
AS
77112011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7712
7713 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7714
cfe0661d
JB
77152011-03-09 Juanma Barranquero <lekktu@gmail.com>
7716
7717 * search.c (compile_pattern_1): Remove argument regp, unused since
7718 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7719 (compile_pattern): Don't pass it.
7720
0afb4571
J
77212011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7722
7723 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7724 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7725 for ! HAVE_GTK3.
7726 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7727
7728 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7729
7730 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7731 gdk_window_get_screen, gdk_window_get_geometry,
7732 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7733 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7734 (xg_get_pixbuf_from_pixmap): New function.
7735 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7736 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7737 Call xg_get_pixbuf_from_pixmap instead of
7738 gdk_pixbuf_get_from_drawable.
7739 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7740 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7741 (xg_check_special_colors): Use GtkStyleContext and its functions
7742 for HAVE_GTK3.
7743 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7744 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7745 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7746 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7747 Call gtk_widget_get_preferred_size.
0afb4571
J
7748 (xg_frame_resized): gdk_window_get_geometry only takes 5
7749 parameters.
44f230aa
SM
7750 (xg_win_to_widget, xg_event_is_for_menubar):
7751 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7752 (xg_set_widget_bg): New function.
7753 (delete_cb): New function.
895009e1 7754 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7755 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7756 (xg_set_background_color): Call xg_set_widget_bg.
7757 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7758 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7759 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7760 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7761 if ! HAVE_GTK3.
7762 (update_frame_tool_bar): Call gtk_widget_hide.
7763 (xg_initialize): Use GDK_KEY_g.
7764
7765 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7766 if ! HAVE_GTK3
7767 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7768
7769 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7770 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7771 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7772
1c2cc4ef
JB
77732011-03-08 Juanma Barranquero <lekktu@gmail.com>
7774
7775 * w32xfns.c (select_palette): Check success of RealizePalette against
7776 GDI_ERROR, not zero.
7777
33383987 7778See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7779
7780;; Local Variables:
7781;; coding: utf-8
aac0c6e3
MR
7782;; End:
7783
33383987 7784 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7785
7786 This file is part of GNU Emacs.
7787
7788 GNU Emacs is free software: you can redistribute it and/or modify
7789 it under the terms of the GNU General Public License as published by
7790 the Free Software Foundation, either version 3 of the License, or
7791 (at your option) any later version.
7792
7793 GNU Emacs is distributed in the hope that it will be useful,
7794 but WITHOUT ANY WARRANTY; without even the implied warranty of
7795 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7796 GNU General Public License for more details.
7797
7798 You should have received a copy of the GNU General Public License
7799 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.