* coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c1dbc63c
PE
12012-08-01 Paul Eggert <eggert@cs.ucla.edu>
2
3 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
4
5c0c0e8a
GM
52012-08-01 Glenn Morris <rgm@gnu.org>
6
7 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
8 Move to configure.ac.
9
552a99b4
JB
102012-08-01 Juanma Barranquero <lekktu@gmail.com>
11
12 * makefile.w32-in (CONFIG_H): Update dependencies.
13 (CONF_POST_H): New macro.
14
15 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
16
8d8e2dfe
GM
172012-07-31 Glenn Morris <rgm@gnu.org>
18
bc96620a
GM
19 * Makefile.in (S_FILE): No longer set by configure.
20
476b1b2d
GM
21 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
22 is available.
23 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
24
b2c7a106
GM
25 * process.h (NULL_DEVICE):
26 * emacs.c (SEPCHAR):
27 * editfns.c (USER_FULL_NAME): Let configure set them.
28
d53d062a
GM
29 * s/README, s/template.h: Remove files.
30
4515017f
GM
31 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
32
8d8e2dfe
GM
33 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
34 Move to configure.ac.
35
5b20b3cc
EZ
362012-07-31 Eli Zaretskii <eliz@gnu.org>
37
1e0afd9a
EZ
38 * .gdbinit (xframe): Adapt to introduction of FVAR and the
39 resulting renaming of 'struct frame' members.
40
5b20b3cc
EZ
41 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
42
43 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
44 after introduction of FVAR.
45
f1310128
JD
462012-07-31 Jan Djärv <jan.h.d@swipnet.se>
47
79e721e0
JD
48 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
49
50 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
51 instead of compositeToPoint.
52 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
53
8d7c7eed 54 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 55
e34f7f79
DA
562012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
57
58 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
59 * lisp.h (INTERNAL_FIELD): New macro.
60 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
61 (BVAR): Change to use INTERNAL_FIELD.
62 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
63 (KVAR): Change to use INTERNAL_FIELD.
64 * frame.h (FVAR): New macro.
65 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
66 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c
67 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c
68 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h,
69 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
70
c09bfb2f
DA
712012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
72
73 Miscellaneous fixes for non-default X toolkits.
74 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
75 * xterm.c (x_frame_of_widget): Remove redundant prototype.
76 Move under #ifdef USE_LUCID.
77 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
78 definition and usage to avoid warnings.
79
14c114ae
JD
802012-07-31 Jan Djärv <jan.h.d@swipnet.se>
81
82 * nsterm.m (openFiles): Fix previous checkin.
83
3bd21e82
PE
842012-07-31 Paul Eggert <eggert@cs.ucla.edu>
85
86 * indent.c (compute_motion): Remove unused local.
87
c1529ded
GM
882012-07-31 Glenn Morris <rgm@gnu.org>
89
400d5621
GM
90 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
91
268e2432
GM
92 * conf_post.h [USG5_4]:
93 Move remaining contents of s/usg5-4-common.h here.
94 * s/usg5-4-common.h: Remove file.
95
7552f3ee
GM
96 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
97 * s/irix6-5.h: Remove file.
98
6a381852
GM
99 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
100 * s/darwin.h: Remove file.
101
c1529ded
GM
102 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
103 * s/hpux10-20.h: Remove file, which is now empty.
104
b429a4ee
GM
1052012-07-30 Glenn Morris <rgm@gnu.org>
106
107 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
108 * Makefile.in (config_h): Add conf_post.h.
109 * makefile.w32-in (CONFIG_H): Add conf_post.h.
110
adff3182
JD
1112012-07-30 Jan Djärv <jan.h.d@swipnet.se>
112
113 * nsterm.m (ns_do_open_file): New variable.
b9031d69 114 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
115 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
116 files only if ns_do_open_file.
117
c32af1e4
PE
1182012-07-30 Paul Eggert <eggert@cs.ucla.edu>
119
7393bcbb
PE
120 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
121 This no-op macro hasn't been needed for many years.
122 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
123
c32af1e4
PE
124 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
125 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
126 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
127 gdb_make_enums_visible.
128 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
129 (DIRECTORY_SEP): Now a constant, not a macro.
130
302fc036
EZ
1312012-07-30 Eli Zaretskii <eliz@gnu.org>
132
133 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
134 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
135
136 * w32term.c <w32_keyboard_codepage>: Renamed from
137 keyboard_codepage and now external. All users changed.
138
139 * w32term.h: Add declaration of w32_keyboard_codepage.
140
141 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
142 the codepage to translate keys to Unicode. If this argument is
143 -1, use the value returned by GetConsoleCP. All callers changed.
144
88fb40b4
PE
1452012-07-30 Paul Eggert <eggert@cs.ucla.edu>
146
0aee6912
PE
147 Update .PHONY listings in makefiles.
148 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
149 bootstrap-clean, distclean, maintainer-clean, versioclean,
150 extraclean, frc.
151
88fb40b4
PE
152 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
153 This is a bit clearer. Fix some commentary typos.
154
0a763bd1
GM
1552012-07-30 Glenn Morris <rgm@gnu.org>
156
32bac6d6
GM
157 * s/netbsd.h: Let configure include signal.h if needed.
158 Remove file, which is now empty.
159
b65e7c46
GM
160 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
161 Let configure set them.
162 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
163 No more need to undefine.
0a763bd1 164
169304bd
AS
1652012-07-30 Andreas Schwab <schwab@linux-m68k.org>
166
167 * keymap.c (Fkey_description): Don't remove 0x80 bit from
168 non-single-byte char when adding meta modifier. (Bug#12090)
169
6cd7a139
DA
1702012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
171
172 Convert safe_call to use variable number of arguments.
173 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
174 (safe_call2): Fix comment.
175 * lisp.h (safe_call): Adjust prototype.
176 * coding.c (encode_coding_object): Change to use safe_call2.
177 * xfaces.c (merge_face_heights): Change to use safe_call1.
178
d34d6ffc
GM
1792012-07-30 Glenn Morris <rgm@gnu.org>
180
7b8a48e4 181 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 182 does that unconditionally. Remove file, which is now empty.
7b8a48e4 183
d34d6ffc
GM
184 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
185 Remove empty files.
186
03a660a6
PE
1872012-07-30 Paul Eggert <eggert@cs.ucla.edu>
188
189 Export to GDB most of lisp.h's remaining object-like macros.
190 * lisp.h (min, max): Move earlier, because they're used earlier now.
191 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
192 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
193 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
194 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
195 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
196 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
197 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
198 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
199 Now constants, for GDB. They need not be macros.
200 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
201 Now constants, for GDB, as well as macros, for static initializers.
202 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
203 Move to after the definition of struct Lisp_Char_Table,
204 since the former now needs that type defined.
205 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
206 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
207 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
208 New enums, for gdb_make_enums_visible.
209 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 210 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
211 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
212 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
213 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
214 enum maxargs, enum MAX_ALLOCA.
215 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
216 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
217 no longer needed, now that they are done in lisp.h.
218
e499d0ee
DA
2192012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
220
221 Cleanup string bytes checking.
222 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
223 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
224 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
225 (check_sblock, compact_small_strings): Simplify.
226
d5040d2d
PE
2272012-07-29 Paul Eggert <eggert@cs.ucla.edu>
228
229 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
230 These macros are confusing and no longer need to be defined, as
231 the enum values now suffice. All uses replaced with definiens.
232 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
233
7f259ae6
JB
2342012-07-29 Juanma Barranquero <lekktu@gmail.com>
235
236 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
237 ($(BLD)/w32console.$(O)): Update dependencies.
238
7e63e0c3
DA
2392012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
240
241 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
242 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
243 time. Adjust users.
244 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
245
ffd817eb
JD
2462012-07-29 Jan Djärv <jan.h.d@swipnet.se>
247
248 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
249 setting sitelisp (Bug#12010).
250
417a7a0e
EZ
2512012-07-29 Eli Zaretskii <eliz@gnu.org>
252
253 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
254
255 * w32heap.c (cache_system_info):
256 * w32.c (sys_rename):
257 * w32proc.c (find_child_console, sys_kill): All users changed.
258
387d4d92
PE
2592012-07-29 Paul Eggert <eggert@cs.ucla.edu>
260
261 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
262
55a6cca6
EZ
2632012-07-29 Eli Zaretskii <eliz@gnu.org>
264
265 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
266
dbcf001c
DA
2672012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
268
269 Cleanup statistics calculation in Fgarbage_collect.
270 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
271 zombies percentage calculation. Simplify elapsed time calculation.
272
e2688e4a
DA
2732012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
274
275 Generalize marker debugging code under MARKER_DEBUG and use eassert.
276 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
277 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
278 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
279 (replace_range, replace_range_2, del_range_2): Change to eassert.
280 * marker.c (byte_char_debug_check): Adjust style.
281
b46a6a83
PE
2822012-07-29 Paul Eggert <eggert@cs.ucla.edu>
283
284 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
285 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
286 long-ago-commented-out code that talks about "WIN32".
287 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
288 All uses changed.
289
e32a5799
PE
2902012-07-28 Paul Eggert <eggert@cs.ucla.edu>
291
292 Use Gnulib stdalign module (Bug#9772, Bug#9960).
293 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
294 Simplify by using alignof.
295 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
296 * lisp.h: Include <stdalign.h>.
297 (GCALIGNMENT): New macro and constant.
298 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
299 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
300 (stdalign): New macro, if not already defined.
301
df81cd29
EZ
3022012-07-28 Eli Zaretskii <eliz@gnu.org>
303
01bd1b0d
EZ
304 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
305 * w32inevt.c: Include w32inevt.h.
306 (w32_read_console_input): New inline function, calls either
307 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
308 w32_console_unicode_input.
309 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
310 (w32_kbd_patch_key, key_event): Use the codepage returned by
311 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
312 (key_event): use uChar.UnicodeChar only if
313 w32_console_unicode_input is non-zero.
314
315 * w32console.c: Include w32heap.h.
316 <w32_console_unicode_input>: New global variable.
317 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
318 family of Windows, zero otherwise.
319
320 * w32inevt.h: Declare w32_console_unicode_input.
321
df81cd29
EZ
322 * xdisp.c (init_iterator): Don't reference tip_frame in a build
323 --without-x. (Bug#11742)
324
c20fdd9e
PE
3252012-07-27 Paul Eggert <eggert@cs.ucla.edu>
326
327 Adjust GDB to reflect pvec_type changes (Bug#12036).
328 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
329 2012-07-04 changes to pseudovector representation. Problem
330 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
331
32770973 3322012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
333
334 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
335 bus address.
336 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
337
3438fe21
EZ
3382012-07-27 Eli Zaretskii <eliz@gnu.org>
339
bcfbc9de
EZ
340 * alloc.c (listn): Fix the order the arguments are consed onto the
341 list.
342
3438fe21
EZ
343 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
344 enumeration constants, as PURE and HEAP are too general, and clash
345 with other headers and sources, such as gmalloc.c and the
346 MS-Windows system headers. All users changed.
347
eeaea515
DA
3482012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
349
350 Revert last save_excursion_save and save_excursion_restore changes.
351 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
352 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
353
073c88c2
DA
3542012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
355
356 Fix recently-introduced typos in Windows port.
357 Reported by Martin Rudalics <rudalics@gmx.at>.
358 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 359 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 360
4706125e
PE
3612012-07-27 Paul Eggert <eggert@cs.ucla.edu>
362
363 Improve GDB symbol export (Bug#12036).
364 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
365 arms of an 'if', not using conditional expressions; otherwise GDB
366 complains about the types in the unevaluated arm when the argument
367 is an integer literal.
368 (xgetint): Simplify expression.
369 * alloc.c (gdb_make_enums_visible): New constant. This ports to
370 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
371 Zaretskii in <http://bugs.gnu.org/12036#13>.
372 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
373 needed now that we have gdb_make_enums_visible.
374 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
375 (enum enum_USE_LSB_TAG):
376 New enum types, packaging up enums that need to be exported to GDB.
377
694b6c97
DA
3782012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
379
380 Utility function to make a list from specified amount of objects.
381 * lisp.h (enum constype): New datatype.
382 (listn): New prototype.
383 * alloc.c (listn): New function.
384 (Fmemory_use_count, syms_of_alloc): Use it.
385 * buffer.c (syms_of_buffer): Likewise.
386 * callint.c (syms_of_callint): Likewise.
387 * charset.c (define_charset_internal): Likewise.
388 * coding.c (syms_of_coding): Likewise.
389 * keymap.c (syms_of_keymap): Likewise.
390 * search.c (syms_of_search): Likewise.
391 * syntax.c (syms_of_syntax): Likewise.
392 * w32.c (init_environment): Likewise.
393 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
394 * xdisp.c (syms_of_xdisp): Likewise.
395 * xfns.c (syms_of_xfns): Likewise.
396
6195f384
DA
3972012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
398
399 Fast save_excursion_save and save_excursion_restore.
400 * lisp.h (struct Lisp_Excursion): New data type.
401 (PVEC_EXCURSION): New pseudovector type.
402 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
403 to deal with it. Adjust comments.
404 (init_marker, attach_marker): New prototype.
405 (unchain_marker): Adjust prototype.
406 * marker.c (attach_marker): Change to global.
407 (init_marker): New function.
408 * alloc.c (Fmake_marker, build_marker): Use it.
409 (build_marker): More easserts.
410 (mark_object): Handle struct Lisp_Excursion.
411 * editfns.c (save_excursion_save, save_excursion_restore):
412 Reimplement to use struct Lisp_Excursion. Add comments.
413
5eceb8fb
PE
4142012-07-26 Paul Eggert <eggert@cs.ucla.edu>
415
416 Fix export of symbols to GDB (Bug#12036).
417 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
418 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
419 emacs.c, as this is a more-suitable home. Had this been done earlier
420 the fix for 12036 would have avoided some of the problems noted in
421 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
422 would have been more obvious.
562157c8
PE
423 * emacs.c: Do not include <verify.h>; no longer needed.
424 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
425 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
426 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
427 Remove; now done in lisp.h.
428 * lisp.h (PUBLISH_TO_GDB): New macro.
429 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
430 (DATA_SEG_BITS): Use it.
431 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
432 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
433 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
434 not be usable in #if. This simplifies things.
435
d6749401
JB
4362012-07-26 Juanma Barranquero <lekktu@gmail.com>
437
438 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
439
1781b9e9
PE
4402012-07-26 Paul Eggert <eggert@cs.ucla.edu>
441
d89518db 442 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
443 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
444 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
445 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
446 Adjust to changes in lisp.h and emacs.c, by using
447 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
448 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
449 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
450 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
451 instead of gdb_valbits.
452 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
453 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
454 instead of gdb_array_mark_flag.
455 (xboolvector): Get size from $->size, not $->header.size.
456 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
457 (xreload, hook-run, hookpost-run): Remove.
458 * emacs.c: Include <verify.h>.
459 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
460 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
461 Remove.
462 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
463 (gdb_USE_LSB_TAG): New enum constants.
464 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
465 Also define these as enum constants, so they're visible to GDB.
466 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
467 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
468 as constants, so they're visible to GDB.
469 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
470 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
471 Now enum constants, not macros, so they're visible to GDB.
472 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
473 more convenient now. All uses changed.
474 (VALMASK) [USE_LSB_TAG]: Also define in this case.
475 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
476
3628596a
DA
4772012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
478
479 Explicitly free restriction data that are not needed anymore.
480 * editfns.c (save_restriction_restore): Free restriction data.
481
7abaf5cc
SM
4822012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
483
484 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
485 add argument, tune behavior, and adjust all callers.
486
71f88e00
PE
4872012-07-25 Paul Eggert <eggert@cs.ucla.edu>
488
489 Use typedef for EMACS_INT, EMACS_UINT.
490 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
491 than macros. This simplifies debugging in the usual case, since
492 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
493 and it allows expressions involving EMACS_INT casts.
494 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
495
57ec3034
JD
4962012-07-25 Jan Djärv <jan.h.d@swipnet.se>
497
498 * nsterm.m (ns_read_socket): Return early if there is a modal
499 window (Bug#12043).
500
8137e7b3
MR
5012012-07-25 Martin Rudalics <rudalics@gmx.at>
502
503 * frame.c (Fredirect_frame_focus): In doc-string don't mention
504 that FOCUS-FRAME can be omitted.
505
04e9897c
DA
5062012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
507
508 Adjust buffer text indirection counters at the end of Fkill_buffer.
509 * buffer.c (Fkill_buffer): Adjust indirection counters when the
510 buffer is definitely dead. This should really fix an issue reported
511 by Christoph Scholtes again. (Bug#12007).
512 (init_buffer_once): Initialize indirection counters of
513 buffer_defaults and buffer_local_symbols (for sanity and safety).
514
8a0484e1
EZ
5152012-07-24 Eli Zaretskii <eliz@gnu.org>
516
517 * xdisp.c (init_iterator): Don't compute dimensions of truncation
518 and continuation glyphs on tooltip frames, leave them at zero.
519 Avoids continued lines in tooltips. (Bug#11832)
520
fa691a83
DA
5212012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
522
523 Simplify copy_overlay.
04e9897c 524 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
525 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
526
436bc8e0
EZ
5272012-07-23 Eli Zaretskii <eliz@gnu.org>
528
529 * print.c (print_object): Don't crash when a frame's name is nil
530 or invalid. (Bug#12025)
531
532 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
533 it signals an error when a tooltip frame is being created.
534
d7a7fda3
DA
5352012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
536
537 Cleanup miscellaneous objects allocation and initialization.
538 * alloc.c (allocate_misc): Change to static. Add argument to
539 specify the subtype. Adjust comment and users.
540 (build_overlay): New function.
541 * buffer.c (copy_overlays, Fmake_overlay): Use it.
542 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
543 (allocate_misc): Remove prototype.
544 (build_overlay): Add prototype.
545
5462012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
547
548 Swap buffer text indirection counters in Fbuffer_swap_text.
549 * buffer.c (Fbuffer_swap_text): Swap indirections too.
550 This avoids crash reported by Christoph Scholtes at
551 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
552
9d7fa573
JD
5532012-07-22 Jan Djärv <jan.h.d@swipnet.se>
554
555 * nsmenu.m (Popdown_data): New struct.
556 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
557 free Popdown_data.
558 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
559 (initWithContentRect): Make imgView and contentView non-static
560 and autorelease them. Also autorelease img and matrix (Bug#12005).
561 (dealloc): Remove (Bug#12005).
562
0dd6d66d
DA
5632012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
564
565 Adjust consing_since_gc when objects are explicitly freed.
566 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
567 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
568 (free_cons, free_misc): Subtract object size from consing_since_gc.
569
d36d71df
DA
5702012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
571
572 Simplify and cleanup markers positioning code.
573 * marker.c (attach_marker): More useful eassert.
574 (live_buffer, set_marker_internal): New function.
575 (Fset_marker, set_marker_restricted): Use set_marker_internal.
576 (set_marker_both, set_marker_restricted_both): Use live_buffer.
577
fb9ea40f
PE
5782012-07-22 Paul Eggert <eggert@cs.ucla.edu>
579
580 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
581 as it's limited by the amount of memory, not by INT_MAX.
582
2d5c5f7d
EZ
5832012-07-21 Eli Zaretskii <eliz@gnu.org>
584
07fb592e
EZ
585 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
586 in special-event-map. See the discussion at
587 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
588 for the reasons.
589
37a9eac8 590 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
591 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
592 Fabrice Popineau <fabrice.popineau@supelec.fr>.
593
c4328746
JD
5942012-07-21 Jan Djärv <jan.h.d@swipnet.se>
595
596 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 597 (conversationIdentifier): Return value is NSInteger.
784051c4 598 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 599
6e5d1c12
CY
6002012-07-21 Chong Yidong <cyd@gnu.org>
601
602 * window.c (decode_any_window): Signal an error if the window is
603 on a dead frame (Bug#11984).
604
9928463d
DA
6052012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
606
607 Add indirection counting to speed up Fkill_buffer.
608 * buffer.h (struct buffer): New member.
609 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
610 (Fmake_indirect_buffer): Set indirection counter to -1, increment
611 base buffer indirection counter.
612 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
613 (Fkill_buffer): Adjust indirection counters as needed, don't walk
614 through buffer list if indirection counter is 0.
615
f8643a6b
DA
6162012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
617
618 Extend the value returned by Fgarbage_collect with heap statistics.
619 * alloc.c (Qheap): New symbol.
620 (syms_of_alloc): DEFSYM it.
621 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
622 (Fmemory_free): Remove.
623 (syms_of_alloc): Don't defsubr it.
624 * buffer.c (Fcompact_buffer): Remove.
625 (syms_of_buffer): Don't defsubr it.
626
dac616ff
DA
6272012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
628
629 Make maybe_gc inline.
630 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
631 * lisp.h (consing_since_gc, gc_relative_threshold)
632 (memory_full_cons_threshold): Revert declaration.
633 (maybe_gc): Remove prototype, define as inline.
634 * alloc.c: Remove old commented-out code.
635 (consing_since_gc, gc_relative_threshold)
636 (memory_full_cons_threshold): Revert to global.
637 (maybe_gc): Remove.
638
d7ea76b4
DA
6392012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
640
641 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
642 * lisp.h (build_unibyte_string): New function.
643 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
644 * sysdep.c, w32fns.c, xfns.c: Use it.
645 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
646 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
647 Adjust users accordingly.
648 * font.h (font_open_by_name): Adjust prototype.
649
765e61e3
DA
6502012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
651
652 Cleanup calls to Fgarbage_collect.
653 * lisp.h (maybe_gc): New prototype.
654 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
655 Remove declarations.
656 * alloc.c (maybe_gc): New function.
657 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
658 Make them static.
659 * bytecode.c (MAYBE_GC): Use maybe_gc.
660 * eval.c (eval_sub, Ffuncall): Likewise.
661 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
662 to avoid dependency from auto-save feature.
663
52b852c7
PE
6642012-07-19 Paul Eggert <eggert@cs.ucla.edu>
665
666 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
667 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
668 'for_each_per_buffer_object_at'.
669 All uses changed. It's better to use upper-case for macros that
670 cannot be implemented as functions, to give the reader a clue
671 that they're special.
672
5db81e33
SM
6732012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
674
675 * alloc.c (Fgarbage_collect): Tweak docstring.
676
5b835e1d
DA
6772012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
678
679 Tweak the value returned from Fgarbage_collect again.
680 * alloc.c (Fgarbage_collect): New return value, as confirmed in
681 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
682 Adjust documentation.
683 (total_vector_bytes): Rename to total_vector_slots, adjust
684 accounting.
685 (total_free_vector_bytes): Rename to total_free_vector_slots,
686 adjust accounting.
687 (Qstring_bytes, Qvector_slots): New symbols.
688 (syms_of_alloc): DEFSYM them.
689
9cd47b72
DA
6902012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
691
692 Buffer compaction primitive which may be used from Lisp.
693 * buffer.c (compact_buffer, Fcompact_buffer): New function.
694 (syms_of_buffer): Register Fcompact_buffer.
695 * alloc.c (Fgarbage_collect): Use compact_buffer.
696 * buffer.h (compact_buffer): New prototype.
697 (struct buffer_text): New member.
698
d17337e5
DA
6992012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
700
701 New macro to iterate over all buffers, miscellaneous cleanups.
702 * lisp.h (all_buffers): Remove declaration.
703 * buffer.h (all_buffers): Add declaration, with comment.
704 (for_each_buffer): New macro.
705 * alloc.c (Fgarbage_collect, mark_object): Use it.
706 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
707 (init_buffer): Likewise.
708 * data.c (Fset_default): Likewise.
709 * coding.c (code_conversion_restore): Remove redundant check
710 for dead buffer.
711 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
712
60cfd278
AS
7132012-07-18 Andreas Schwab <schwab@linux-m68k.org>
714
715 Fix bug that created negative-length intervals.
716 * intervals.c (merge_interval_right, merge_interval_left):
717 Do not zero out this interval if it is absorbed by its children,
718 as this interval's total length doesn't change in that case. See
719 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
720
d06714cb
PE
7212012-07-18 Paul Eggert <eggert@cs.ucla.edu>
722
83713154
PE
723 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
724 when invoking (make-bool-vector N t) and N is a positive
725 multiple of 8 -- the last 8 bits were mistakenly cleared.
726
d06714cb
PE
727 Remove some struct layout assumptions in bool vectors.
728 * alloc.c (bool_header_size): New constant.
729 (header_size, word_size): Move earlier, as they're now used earlier.
730 Use 'word_size' in a few more places, where it's appropriate.
731 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
732 padding before the data member of a bool vector.
733 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
734 than doing the check by hand with an abort ().
735
464d5a5e
SM
7362012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
737
5fbc0409
SM
738 * eval.c (Fdefvar): Don't check constants since we only set the var if
739 it's not yet defined anyway (bug#11904).
740
464d5a5e
SM
741 * lisp.h (last_undo_boundary): Declare new var.
742 * keyboard.c (command_loop_1): Set it.
743 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
744 were auto-added by the command loop (bug#11774).
745
8dc2e44a
AS
7462012-07-18 Andreas Schwab <schwab@linux-m68k.org>
747
748 * w32font.c (Qsymbol): Remove local definition.
749 (syms_of_w32font): Don't DEFSYM it.
750
169925ec
DA
7512012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
752
753 Fix sweep_vectors to handle large bool vectors correctly.
754 * alloc.c (sweep_vectors): Account total_vector_bytes for
755 bool vectors larger than VBLOCK_BYTES_MAX.
756
5fbfb018
CY
7572012-07-18 Chong Yidong <cyd@gnu.org>
758
759 * frame.c (x_set_frame_parameters): Revert bogus change introduced
760 in 2012-05-25 commit by Paul Eggert (Bug#11738).
761
3ab6e069
DA
7622012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
763
764 Return more descriptive data from Fgarbage_collect.
765 Suggested by Stefan Monnier in
766 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
767 * alloc.c (bounded_number): New function.
768 (total_buffers, total_vectors): New variable.
769 (total_string_size): Rename to total_string_bytes, adjust users.
770 (total_vector_size): Rename to total_vector_bytes, adjust users.
771 (sweep_vectors): Account total_vectors and total_vector_bytes.
772 (Fgarbage_collect): New return value. Adjust documentation.
773 (gc_sweep): Account total_buffers.
774 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
775 (VECTOR_SIZE): Remove.
776 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
777 (Qinterval, Qmisc): New symbols.
778 (syms_of_data): Initialize them.
779 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
780 (Qcons, Qbuffer): New declarations.
781
6d02fe5b
PE
7822012-07-17 Paul Eggert <eggert@cs.ucla.edu>
783
784 * alloc.c (Fmemory_free): Account for memory-free's own storage.
785 Round up, not down. Improve doc.
786
b7ffe040
DA
7872012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
788
789 Restore old code in allocate_string_data to avoid Faset breakage.
790 Reported by Julien Danjou <julien@danjou.info> in
791 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
792 * alloc.c (allocate_string_data): Restore old code with minor
793 adjustments, fix comment to explain this subtle issue.
794
4dc7c8d5
SM
7952012-07-17 Eli Zaretskii <eliz@gnu.org>
796
797 Remove FILE_SYSTEM_CASE.
798 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
799
800 * fileio.c (FILE_SYSTEM_CASE): Don't define.
801 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
802 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
803 call-process-region passes it through expand-file-name.
804
805 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
806
8072012-07-17 Andreas Schwab <schwab@linux-m68k.org>
808
809 Fix crash when creating indirect buffer (Bug#11917)
810 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
811 Don't handle unbound variables specially if non-zero.
812 (Fbuffer_local_variables): Pass zero.
813 (clone_per_buffer_values): Pass non-zero.
814
8152012-07-17 Andreas Schwab <schwab@linux-m68k.org>
816
817 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
818 to make the loop interruptible.
819
8202012-07-17 Andreas Schwab <schwab@linux-m68k.org>
821
822 * gnutls.c (emacs_gnutls_handshake): Only retry if
823 GNUTLS_E_INTERRUPTED.
824
cce7fefc
DA
8252012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
826
827 Cleanup and convert miscellaneous checks to eassert.
828 * alloc.c (mark_interval): Fix comment, partially rephrase
829 old comment from intervals.h (see below).
830 * intervals.c (find_interval, adjust_intervals_for_insertion)
831 (delete_interval, adjust_intervals_for_deletion)
832 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
833 Convert to eassert.
834 (adjust_intervals_for_insertion, make_new_interval):
835 Remove obsolete and unused code.
836 * intervals.h (struct interval): Remove obsolete comment.
837 * textprotp.c (erase_properties): Remove unused code.
838 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
839 (Fremove_list_of_text_properties): Convert to eassert.
840
9ea10cc3
CY
8412012-07-17 Chong Yidong <cyd@gnu.org>
842
843 * editfns.c (Finsert_char): Doc fix.
844
3900d5de
DA
8452012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
846
847 Fix previous change to make Fmemory_free always accurate.
848 * alloc.c (make_interval): Update total_free_intervals.
849 (make_float): Likewise for total_free_floats.
850 (free_cons, Fcons): Likewise for total_free_conses.
851 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
852 Likewise for total_free_vector_bytes.
853 (Fmake_symbol): Likewise for total_free_symbols.
854 (bytes_free): Remove.
855
7098646f
DA
8562012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
857
858 Simple free memory accounting feature.
859 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
860 (sweep_vectors): Accumulate size of free vectors.
861 (Fgarbage_collect): Setup bytes_free.
862 (Fmemory_free): New function.
863 (syms_of_alloc): Register it.
864
22657b40
DA
8652012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
866
867 Cleanup overlays checking.
868 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
869 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
870 eassert and OVERLAYP.
871 (sort_overlays): Change to use OVERLAYP.
872
ddfc8813
RK
8732012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
874
875 * editfns.c (Finsert_char): Make it interactive, and make the
876 second arg optional. Copy interactive spec and docstring from
877 ucs-insert.
878
7c26cf3c
PE
8792012-07-17 Paul Eggert <eggert@cs.ucla.edu>
880
881 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
882 Unlike the other wrapped functions, fabs has an unspecified
883 effect on errno.
884
5d127af9
JD
8852012-07-16 Jan Djärv <jan.h.d@swipnet.se>
886
887 * nsterm.m (keyDown): Interpret flags without left/right bits
888 as the left key (Bug#11670).
889
6a0dd1d7
DA
8902012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
891
892 Remove empty and useless init functions.
893 * lisp.h (init_character_once, init_fns, init_image)
894 (init_filelock, init_sound): Remove prototype.
895 * character.c (init_character_once): Remove.
896 * filelock.c (init_filelock): Likewise.
897 * fns.c (init_fns): Likewise.
898 * image.c (init_image): Likewise.
899 * sound.c (init_sound): Likewise.
900 * emacs.c (main): Adjust accordingly.
901
7a6136fd
DA
9022012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
903
904 * gtkutil.h: Tiny cleanups.
905 (use_old_gtk_file_dialog): Remove useless declaration.
906 (xg_uses_old_file_dialog): Add suggested const attribute.
907
ce811ad9
EZ
9082012-07-15 Eli Zaretskii <eliz@gnu.org>
909
910 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
911 (bidi_paragraph_init): Use it to limit search forward for a strong
912 directional character in abnormally large paragraphs full of
913 neutral or weak characters. (Bug#11943)
914
c9adfeaa
SF
9152012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
916
917 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
918 the toolbar (Bug#9451).
919 (xg_make_tool_item): Give the widget event box a transparent
920 background.
921
fff62aa9
DA
9222012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
923
924 Cleanup basic allocation variables and functions.
925 * alloc.c (ignore_warnings, init_intervals, init_float)
926 (init_cons, init_symbol, init_marker): Remove.
927 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
928 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
929 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
930 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
931 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
932 (staticidx, init_alloc_once, init_strings, free_ablock):
933 Remove redundant initialization.
934 * fns.c (init_weak_hash_tables): Remove.
935 * lisp.h (init_weak_hash_tables): Remove prototype.
936
9730daca
DA
9372012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
938
939 Use zero_vector where appropriate.
940 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
941 accordingly.
942 * lisp.h (zero_vector): New declaration.
943 * font.c (null_vector): Remove.
944 (syms_of_font): Remove initialization and staticpro.
945 (font_list_entities, font_find_for_lface): Change to use zero_vector.
946 * keymap.c (Faccessible_keymaps): Likewise.
947
2e2d2a13
LL
9482012-07-15 Leo Liu <sdl.web@gmail.com>
949
950 * fringe.c: Fix typo in comments.
951
cd276f6e
LL
9522012-07-14 Leo Liu <sdl.web@gmail.com>
953
954 * fringe.c: Add a new bitmap exclamation-mark.
955
5a1131d9
EZ
9562012-07-14 Eli Zaretskii <eliz@gnu.org>
957
958 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
959
960 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
961 (HAVE_MENUS): Don't define, defined by editing config.in with
962 msdos/sed2v2.inp.
963 (GMALLOC_INHIBIT_VALLOC): Don't define.
964 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
965
22e983b7
JB
9662012-07-14 Juanma Barranquero <lekktu@gmail.com>
967
968 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
969
5b3f250f
GM
9702012-07-14 Glenn Morris <rgm@gnu.org>
971
972 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
973 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
974 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
975
33d63ff4
GM
9762012-07-13 Glenn Morris <rgm@gnu.org>
977
5b633342
GM
978 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
979
33d63ff4
GM
980 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
981 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
982
b55b9f85
JD
9832012-07-13 Jan Djärv <jan.h.d@swipnet.se>
984
0dc8cf50
JD
985 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
986 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
987 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
988 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
989 where appropriate.
990 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
991 as boolean expression.
992 (x_set_window_size): Remove unused variable toolbar.
993 (ns_get_color_default, ns_mod_to_lisp): Remove.
994 (ns_mouse_position): Remove unused variables xchar and ychar.
995 (ns_compute_glyph_string_overhangs): Remove unused variable face.
996 (ns_set_vertical_scroll_bar): Remove unused variable count.
997 (ns_delete_terminal): Remove unused variable i.
998 (ns_term_init): Remove unused variables r, g and b.
999 (mouseDown): Remove unused variable window.
1000 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1001 (initFrameFromEmacs): Remove unused variable vbextra.
1002 (mouseEntered): Remove unused variables p and dpyinfo.
1003 (mouseExited): Remove unused variables p and r.
1004 (ns_define_frame_cursor, ns_clear_frame_area)
1005 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1006 (menuDown): Assign [sender tag] to variable and cast the variable.
1007
1008 * nsterm.h (menuDown): Add id as type to argument sender.
1009 (ns_display_info_for_name): Add Lisp_Object argument.
1010 (ns_term_init): Add Lisp_Object argument.
1011 (ns_map_event_to_object): Add void argument.
1012 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1013 prototype with arguments and only declare if __OBJC__.
1014 (nxatoms_of_nsselect): Add void argument.
1015 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1016 (ns_alloc_autorelease_pool): Add void argument.
1017 (ns_release_autorelease_pool): Add void* argument.
1018 (ns_get_defaults_value): Add const char* argument.
1019
1020 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1021 (initFromContents): Use SSDATA where appropriate.
1022 (ns_update_menubar): Add braces to ambigous if-else.
1023 (initWithTitle): Put () around assignment in if statement.
1024 (ns_menu_show): Remove unused variables window and keymap.
1025 (update_frame_tool_bar): Remove unused variable selected_p.
1026 (initWithContentRect): Remove unused variable this_cmd_name.
1027
1028 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1029 appropriate.
1030 (setXBMColor): Remove unused variable len.
1031 (setPixmapData): Put () around assignment in loop statement.
1032
1033 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1034 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1035 where appropriate.
1036 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1037 around assignment in loop statement.
1038 (nsfont_open): Remove unused variable i.
1039 (nsfont_open): Remove unused variable len.
1040 (nsfont_draw): Remove unused variable cs.
1041
1042 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1043 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1044 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1045 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1046 (Fns_font_name, Fns_perform_service)
1047 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1048 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1049 (ns_set_name): Remove unused variable view.
1050 (x_set_menu_bar_lines): Remove unused variable olines.
1051 (x_set_tool_bar_lines): Remove unused variable root_window.
1052 (Fns_list_colors): Put () around assignment in while statement.
1053 (Fns_perform_service): Remove unused variable len.
1054 (Fns_display_usable_bounds): Remove unused variable top.
1055 (syms_of_nsfns): Remove unused variable i.
1056
b55b9f85
JD
1057 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1058 memcpy (Bug#11907).
1059
ed9265fc 10602012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1061
1062 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1063 and free it with DestroyExceptionInfo (Bug#11558).
1064
ef099b57
JB
10652012-07-13 Juanma Barranquero <lekktu@gmail.com>
1066
1067 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1068 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1069 Set here, not in nt/config.nt.
1070
ea814a5d
EZ
10712012-07-13 Eli Zaretskii <eliz@gnu.org>
1072
1073 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1074 cursor overflow into the last glyph on display line when the right
1075 fringe is off. (Bug#11832)
1076
1a952767
PE
10772012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1078
1079 * xdisp.c (produce_special_glyphs): Now static.
1080 * dispextern.h (produce_special_glyphs): Remove decl.
1081
983188fd
GM
10822012-07-13 Glenn Morris <rgm@gnu.org>
1083
8d7c7eed 1084 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1085 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1086
983188fd
GM
1087 * s/usg5-4-common.h (USG, USG5):
1088 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1089 * s/sol2-6.h (SOLARIS2):
1090 * s/irix6-5.h (IRIX6_5):
1091 * s/hpux10-20.h (USG, USG5, HPUX):
1092 * s/gnu-linux.h (USG, GNU_LINUX):
1093 * s/freebsd.h (BSD_SYSTEM):
1094 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1095 * s/cygwin.h (CYGWIN):
1096 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1097 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1098
d1e68667 10992012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1100
1101 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1102
6de0e799
GM
11032012-07-13 Glenn Morris <rgm@gnu.org>
1104
739ae010
GM
1105 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1106
dbee5793
GM
1107 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1108
6de0e799
GM
1109 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1110 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1111
b82da769
GM
11122012-07-12 Glenn Morris <rgm@gnu.org>
1113
4fae5a7a 1114 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1115
1116 * process.c (init_process_emacs): Rename from init_process.
1117 The old name is also the name of a Mach system call.
1118 * lisp.h, emacs.c: Update for this name change.
1119 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1120 longer needed.
1121
5a979817
EZ
11222012-07-12 Eli Zaretskii <eliz@gnu.org>
1123
1124 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1125 memmove call that removes glyphs covered by the left truncation
1126 glyph. Improve commentary.
1127 (display_line): Fix display of continuation glyphs on GUI frames
1128 when the right fringe is turned off and variable-size fonts are
1129 used in the window. Move the code that appends a stretch glyph to
1130 produce_special_glyphs, so that it could be used for truncation
1131 and continuation glyphs alike.
1132 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1133 glyph of a suitably computed width, to align the special glyphs at
1134 the window margin. Code moved from display_line. (Bug#11832)
1135
3e91a053
GM
11362012-07-12 Glenn Morris <rgm@gnu.org>
1137
ba9e4b84
GM
1138 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1139
1140 * s/gnu-linux.h, s/hpux10-20.h:
1141 Do not unconditionally define HAVE_XRMSETDATABASE.
1142
3e91a053
GM
1143 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1144
b300b1f4
PE
11452012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1146
1147 Fix typos that broke OS X build.
1148 Reported by Randal L. Schwartz in
1149 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1150 * nsterm.m (ns_timeout): Add missing local decl.
1151 (ns_get_color): snprintf -> sprintf, to fix typo.
1152
6e777848
GM
11532012-07-12 Glenn Morris <rgm@gnu.org>
1154
3f922c37
GM
1155 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1156 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1157 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1158 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1159
0ab7b23a
GM
1160 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1161 Move PTY_OPEN to configure.
1162
6e777848
GM
1163 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1164 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1165 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1166
4a7edc24
DA
11672012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1168
1169 Use empty_unibyte_string where applicable.
1170 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1171 * lread.c (read1): Likewise.
1172 * xsettings.c (syms_of_xsettings): Likewise.
1173
308aab79
GM
11742012-07-12 Glenn Morris <rgm@gnu.org>
1175
42bd1719
GM
1176 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1177 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1178 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1179 * s/hpux10-20.h (RUN_TIME_REMAP):
1180 * s/bsd-common.h (TABDLY): Move to configure.
1181
1182 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1183
1184 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1185
ea0bbd17 1186 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1187 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1188
1189 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1190
308aab79
GM
1191 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1192 * s/template.h: Move NARROWPROTO to configure.
1193
ee1cf5cf
GM
11942012-07-11 Glenn Morris <rgm@gnu.org>
1195
30fe9bf4
GM
1196 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1197 unused since 2011-01-17 change to systty.h.
1198
ee1cf5cf
GM
1199 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1200 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1201 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1202
63e47e07
PE
12032012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1204
1205 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1206
c43fb4c3
GM
12072012-07-11 Glenn Morris <rgm@gnu.org>
1208
1209 * s/darwin.h, s/gnu-linux.h, s/template.h:
1210 Move INTERRUPT_INPUT to configure.
1211
e8df9267
DA
12122012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1213
1214 Minor adjustments to interning code.
1215 * lisp.h (intern, intern_c_string): Redefine as static inline
1216 wrappers for intern_1 and intern_c_string_1, respectively.
1217 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1218 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1219 Vobarray checking.
e8df9267
DA
1220 * font.c (font_intern_prop): Likewise. Adjust comment.
1221 * w32font.c (intern_font_name): Likewise.
1222
34348bd4
AS
12232012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1224
d96a1e0c
AS
1225 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1226
34348bd4
AS
1227 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1228 of Fcar/Fcdr if possible.
1229 * font.c (check_otf_features): Likewise.
1230 * fontset.c (Fnew_fontset): Likewise.
1231 * gnutls.c (Fgnutls_boot): Likewise.
1232 * minibuf.c (read_minibuf): Likewise.
1233 * msdos.c (IT_set_frame_parameters): Likewise.
1234 * xmenu.c (Fx_popup_dialog): Likewise.
1235 * w32menu.c (Fx_popup_dialog): Likewise.
1236
c8add24e
GM
12372012-07-11 Glenn Morris <rgm@gnu.org>
1238
4b575b3c
GM
1239 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1240 since nothing has defined it on these platforms.
1241
09f4e3b0
GM
1242 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1243 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1244
172bedef
GM
1245 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1246 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1247 Move CLASH_DETECTION to configure.
1248
249685df
GM
1249 * s/gnu.h: Remove file, which is now empty.
1250
c8add24e
GM
1251 * s/gnu.h, s/gnu-linux.h:
1252 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1253
b41253a3
JW
12542012-07-11 John Wiegley <johnw@newartisans.com>
1255
1256 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1257 function attribute, so we only use it if it exists in the
1258 compiler.
1259
d923b542
DA
12602012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1261
1262 Avoid call to strlen in fast_c_string_match_ignore_case.
1263 * search.c (fast_c_string_match_ignore_case): Change to use
1264 length argument. Adjust users accordingly.
1265 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1266
5ebbef1d
PE
12672012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1268
bb352260
PE
1269 Assume mkdir, rmdir.
1270 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1271 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1272
57054ddd
PE
1273 Assume rename.
1274 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1275
b747d3f7
PE
1276 Assume perror.
1277 * s/hpux10-20.h (HAVE_PERROR): Remove.
1278 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1279 Remove dummy definition, as this problem was obsolete long ago.
1280
5ebbef1d
PE
1281 Assume strerror.
1282 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1283
984e7f30
DA
12842012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1285
1286 Avoid calls to strlen in font processing functions.
1287 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1288 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1289 users accordingly.
d923b542
DA
1290 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1291 Adjust prototypes.
1292 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1293 Change to return ptrdiff_t.
984e7f30
DA
1294 (xfont_list_pattern, xfont_match): Use length returned by
1295 xfont_decode_coding_xlfd.
1296 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1297
20e94fdd
GM
12982012-07-11 Glenn Morris <rgm@gnu.org>
1299
9d596af3
GM
1300 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1301 Move DONT_REOPEN_PTY to configure.
1302
20e94fdd
GM
1303 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1304 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1305
e99a530f
PE
13062012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1307
22ffb973
PE
1308 Remove "#define unix" that is no longer needed (Bug#11905).
1309 * s/aix4-2.h (unix): Remove; no longer needed.
1310
e9a9ae03
PE
1311 EMACS_TIME simplification (Bug#11875).
1312 This replaces macros (which typically do not work in GDB)
1313 with functions, typedefs and enums, making the code easier to debug.
1314 The functional style also makes code easier to read and maintain.
1315 * systime.h: Include <sys/time.h> on all hosts, not just if
1316 WINDOWSNT, since 'struct timeval' is needed in general.
1317 (EMACS_TIME): Now a typedef, not a macro.
1318 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1319 not macros.
1320 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1321 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1322 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1323 (EMACS_TIME_LE): Now functions, not macros.
1324 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1325 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1326 which are not functions. All uses rewritten to use:
1327 (make_emacs_time): New function.
1328 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1329 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1330 not functions. All uses rewritten to use the following, respectively:
1331 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1332 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1333 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1334 * fileio.c (Fcopy_file):
1335 * xterm.c (XTflash): Get the current time closer to when it's used.
1336 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1337
ffacb126
PE
1338 * bytecode.c (targets): Suppress -Woverride-init warnings.
1339
e99a530f
PE
1340 Simplify by avoiding confusing use of strncpy etc.
1341 * doc.c (Fsnarf_documentation):
1342 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1343 * frame.c (Fmake_terminal_frame):
1344 * gtkutil.c (get_utf8_string):
1345 * lread.c (openp):
1346 * nsmenu.m (ns_update_menubar):
1347 * regex.c (regerror):
1348 Prefer memcpy to strncpy and strncat when either will do.
1349 * fileio.c (Fsubstitute_in_file_name):
1350 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1351 (menu_separator_name_p):
1352 * nsmenu.m (ns_update_menubar):
1353 Prefer memcmp to strncmp when either will do.
1354 * nsterm.m: Include <ftoastr.h>.
1355 (ns_get_color):
1356 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1357 Prefer snprintf to strncpy.
1358 * nsterm.m (ns_term_init):
1359 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1360 * nsterm.m (ns_term_init):
1361 Avoid the need for strncpy, by using build_string or
1362 make_unibyte_string directly. Use dtoastr, not snprintf.
1363 * process.c (Fmake_network_process): Diagnose service names that
1364 are too long, rather than silently truncating them or creating
1365 non-null-terminated names.
1366 (Fnetwork_interface_info): Likewise, for interface names.
1367 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1368 Prefer sprintf to strncat.
1369 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1370 Prefer vsnprintf to vsprintf + strncpy.
1371
c59592b3
GM
13722012-07-10 Glenn Morris <rgm@gnu.org>
1373
1374 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1375 Clarify fallback case.
1376
7d7bbefd
DA
13772012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1378
1379 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1380 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1381 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1382 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1383 where argument type is known to be a Lisp_Cons.
1384
3a4c8000
TT
13852012-07-10 Tom Tromey <tromey@redhat.com>
1386
1387 * bytecode.c (BYTE_CODE_THREADED): New macro.
1388 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1389 (enum byte_code_op): New type.
1390 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1391 (exec_byte_code): Use them. Use token threading when applicable.
1392
2a0213a6
DA
13932012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1394
1395 Optimize pure C strings initialization.
1396 * lisp.h (make_pure_string): Fix prototype.
1397 (build_pure_c_string): New function, defined as static inline. This
1398 provides a better opportunity to optimize away calls to strlen when
1399 the function is called with compile-time constant argument.
1400 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1401 argument, adjust users accordingly. Use build_pure_c_string where
1402 appropriate.
1403 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1404 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1405 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1406
cb1caeaf
DA
14072012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1408
1409 Avoid calls to strlen in miscellaneous functions.
1410 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1411 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1412 * lread.c (openp): Likewise.
1413
c293e30c
DA
14142012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1415
1416 Avoid calls to strlen in path processing functions.
1417 * fileio.c (file_name_as_directory): Add comment. Change to add
1418 srclen argument and return the length of result. Adjust users
1419 accordingly.
1420 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1421 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1422 users accordingly.
1423 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1424
9e059e3f
GM
14252012-07-10 Glenn Morris <rgm@gnu.org>
1426
d02eb359
GM
1427 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1428 Move PENDING_OUTPUT_COUNT definition to configure.
1429
882cf227
GM
1430 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1431 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1432 * s/gnu.h (DATA_START): Move definitions to configure.
1433
af6e839f
GM
1434 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1435 We include usg5-4-common.h, which defines them both.
1436
40289a12
GM
1437 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1438 O_RDONLY already includes it).
1439
9e059e3f
GM
1440 Stop ns builds setting the EMACSLOADPATH environment variable.
1441 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1442 Now it does not set EMACSLOADPATH, just returns the load-path string.
1443 * nsterm.h: Update accordingly.
1444 * lread.c [HAVE_NS]: Include nsterm.h.
1445 (init_lread) [HAVE_NS]: Use ns_load_path.
1446 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1447
7c4e8ec0
GM
14482012-07-09 Glenn Morris <rgm@gnu.org>
1449
d4f600ff
GM
1450 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1451 since the included bsd-common.h does so.
1452
cbb31951
GM
1453 Stop ns builds setting the EMACSPATH environment variable.
1454 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1455 (ns_init_paths): Do not set EMACSPATH.
1456 * nsterm.h (ns_exec_path): Add it.
1457 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1458 Use ns_exec_path.
1459
7c4e8ec0
GM
1460 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1461
26bccfae
PE
14622012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1463
a0bee46f
PE
1464 * process.c (wait_reading_process_output): 'waitchannels' was unset
1465 when read_kbd || !NILP (wait_for_cell); fix this.
1466
5994c183
PE
1467 Add GCC-style 'const' attribute to functions that can use it.
1468 * character.h (char_resolve_modifier_mask):
1469 * keyboard.h (make_ctrl_char):
1470 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1471 (init_character_once, next_almost_prime, init_fns, init_image)
1472 (flush_pending_output, init_sound):
1473 * mem-limits.h (start_of_data):
1474 * menu.h (finish_menu_items):
1475 Add ATTRIBUTE_CONST.
1476 * emacs.c (DEFINE_DUMMY_FUNCTION):
1477 Declare the dummy function with ATTRIBUTE_CONST.
1478 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1479 Add decls with ATTRIBUTE_CONST.
1480
26bccfae
PE
1481 Minor improvements to make_formatted_string.
1482 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1483 where int is good enough, as vsprintf returns an int.
1484 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1485
a8290ec3
DA
14862012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1487
1488 Use make_formatted_string to avoid double length calculation.
1489 * lisp.h (make_formatted_string): New prototype.
1490 * alloc.c (make_formatted_string): New function.
1491 * buffer.c (Fgenerate_new_buffer_name): Use it.
1492 * dbus.c (syms_of_dbusbind): Likewise.
1493 * editfns.c (Fcurrent_time_zone): Likewise.
1494 * filelock.c (get_boot_time): Likewise.
1495 * frame.c (make_terminal_frame, set_term_frame_name)
1496 (x_report_frame_params): Likewise.
1497 * image.c (gs_load): Likewise.
1498 * minibuf.c (get_minibuffer): Likewise.
1499 * msdos.c (dos_set_window_size): Likewise.
1500 * process.c (make_process): Likewise.
1501 * xdisp.c (ensure_echo_area_buffers): Likewise.
1502 * xsettings.c (apply_xft_settings): Likewise.
1503
d01ba2f1
GM
15042012-07-09 Glenn Morris <rgm@gnu.org>
1505
1506 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1507 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1508 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1509 * nsterm.h (ns_etc_directory): Add it.
1510 * callproc.c [HAVE_NS]: Include nsterm.h.
1511 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1512
f1f924b6
DA
15132012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1514
1515 Move marker debugging code under MARKER_DEBUG.
1516 * marker.c (MARKER_DEBUG): Move marker debugging code under
1517 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1518 for bootstrap with --enable-checking (~3x slowdown reported
1519 by Juanma Barranquero <lekktu@gmail.com>).
1520 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1521
ab531b66
PE
15222012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1525 See <http://bugs.gnu.org/11825#29>.
1526
c4b3bc8a
EZ
15272012-07-08 Eli Zaretskii <eliz@gnu.org>
1528
1529 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1530 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1531 (display_line): Add commentary about displaying truncation glyphs
1532 on GUI frames.
1533 (produce_special_glyphs): Move here from term.c.
1534
1535 * term.c (produce_special_glyphs): Move to xdisp.c.
1536
1537 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1538 section.
c4b3bc8a 1539
b676b881
AS
15402012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1541
f17c5273
AS
1542 * xdisp.c (display_line): Avoid warning about implicit declaration
1543 of FRAME_FONT.
1544
298819b9
AS
1545 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1546
b676b881
AS
1547 * lisp.h: Remove empty conditional.
1548
6045c4fd
PE
15492012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1550
b3350bf9
PE
1551 * lread.c (load_path_check): Now static.
1552
6045c4fd
PE
1553 Fix some minor --with-ns problems found by static checking.
1554 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1555 (x_set_font) [!HAVE_X_WINDOWS]:
1556 * image.c (xpm_load_image) [HAVE_NS]:
1557 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1558 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1559 Remove unused local.
1560 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1561 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1562 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1563 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1564 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1565 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1566 Fix pointer signedness problem.
1567 * xfaces.c (FRAME_X_FONT_TABLE):
1568 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1569
929e7845
GM
15702012-07-07 Glenn Morris <rgm@gnu.org>
1571
1572 * lread.c (load_path_check): New function, split from init_lread.
1573 (init_lread): Reorganize. Motivation:
1574 If EMACSLOADPATH is set, check/warn about that rather than the
1575 defaults, which we are not going to use. Hence we can remove
1576 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1577 Don't warn if site-lisp directories are missing.
1578 If not installed, start from a blank load-path, since
1579 PATH_LOADSEARCH refers to the eventual installation directories.
1580
58dd0aa4
EZ
15812012-07-07 Eli Zaretskii <eliz@gnu.org>
1582
1583 Support truncation and continuation glyphs on GUI frames, when
1584 fringes are disabled. (Bug#11832)
1585 * xdisp.c (init_iterator): Get dimensions of truncation and
1586 continuation glyphs even if on GUI frames. Adjust
1587 it->last_visible_x on GUI frames when the left or right fringes,
1588 or both, are absent.
1589 (start_display, move_it_in_display_line_to): Handle the case of a
1590 GUI frame without a fringe to display continuation or truncation
1591 glyphs.
1592 (insert_left_trunc_glyphs): Support GUI frames: make sure
1593 truncation glyphs overwrite enough glyphs from the current line to
1594 have sufficient space in pixels.
1595 (display_line): Support truncation and continuation glyphs on GUI
1596 frames. If some spare pixels are left on the line after inserting
1597 the truncation glyphs, fill that space with a stretch glyph of a
1598 suitably computed width.
1599
1600 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1601 produce_glyphs, to support GUI sessions.
1602
31571fd7
PE
16032012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1604
5a16b9bc
PE
1605 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1606
f3047c75
PE
1607 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1608
31571fd7
PE
1609 Do not require float-time's arg to fit in time_t (Bug#11825).
1610 This works better on hosts where time_t is unsigned, and where
1611 float-time is applied to the (negative) difference between two times.
1612 * editfns.c (decode_time_components): Last arg is now double *,
1613 not int *, and means to store all the result as a double, without
1614 worrying about whether the seconds part fits in time_t.
1615 All callers changed.
1616 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1617 All callers changed.
1618 (Ffloat_time): Do not fail merely because the specified time falls
1619 outside of time_t range.
1620
4516fbef
GM
16212012-07-07 Glenn Morris <rgm@gnu.org>
1622
1623 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1624 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1625 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1626
07adc2c6
JB
16272012-07-07 Juanma Barranquero <lekktu@gmail.com>
1628
1629 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1630 Update dependencies.
1631
1632 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1633
fd573f31
PE
16342012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1635
fee5959d
PE
1636 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1637 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1638 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1639 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1640 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1641 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1642
fd573f31
PE
1643 * xfont.c (compare_font_names): Redo to omit the need for casts.
1644
ddadbc0e
AS
16452012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1646
fca8d6b6
AS
1647 * xfns.c (Fx_change_window_property): Doc fix.
1648 * w32fns.c (Fx_change_window_property): Doc fix.
1649
ddadbc0e
AS
1650 * w32fns.c (Fx_window_property): Accept the same arguments as the
1651 X Windows version. Doc fix.
1652 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1653
ed9265fc 16542012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1655 Eli Zaretskii <eliz@gnu.org>
1656
1657 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1658 Windows-specific code from nt/config.nt moved here.
1659 Obsolete settings removed.
1660
216ee680
PE
16612012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1662
1663 * process.c: Avoid unnecessary calls to gettime.
1664 (wait_reading_process_output): Don't get the time of day
1665 when gobbling data immediately and not waiting, as there's no need
1666 for it in that case. This removes a FIXME.
1667
bdd091e4
JD
16682012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1669
1670 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1671 is defined (Bug#11768).
1672
9d44f8ce
DA
16732012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1674
1675 Fix marker debugging code.
1676 * marker.c (byte_char_debug_check): Do not perform the check
1677 if buffer is not multibyte.
090bd7cb
JB
1678 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1679 Call byte_char_debug_check with correct arguments.
9d44f8ce 1680
90fc4786
DA
16812012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1682
1683 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1684 * marker.c (byte_char_debug_check, count_markers):
1685 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1686 (byte_debug_flag): Remove.
1687 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1688 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1689
7b7ae965
DA
16902012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1691
4e57b342
DA
1692 Avoid code repetition in marker-related functions.
1693 * marker.c (attach_marker): New function.
1694 (Fset_marker, set_marker_restricted, set_marker_both)
1695 (set_marker_restricted_both): Use it.
1696 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1697 Consistently rename charno to charpos.
1698 (marker_position): Add eassert.
1699 (marker_byte_position): Convert to eassert.
1700
17012012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1702
1703 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1704 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1705 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1706
657924ff
DA
17072012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1708
1709 Introduce fast path for the widely used marker operation.
1710 * alloc.c (build_marker): New function.
1711 * lisp.h (build_marker): New prototype.
1712 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1713 * composite.c (autocmp_chars): Likewise.
1714 * editfns.c (buildmark): Remove.
1715 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1716 (save_restriction_save): Use build_marker.
1717 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1718 * window.c (save_window_save): Likewise.
1719
041a49a6
DA
17202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1721
1722 Do not use Fdelete_overlay in delete_all_overlays
1723 to avoid redundant calls to unchain_overlay.
1724 * buffer.c (drop_overlay): New function.
1725 (delete_all_overlays, Fdelete_overlay): Use it.
1726 * minibuf.c (get_minibuffer): Fix comment.
1727
7dca65a4
PE
17282012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1729
1730 Port to OpenBSD 5.1 amd64.
1731 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1732 This is needed for OpenBSD, and should be harmless on all BSD systems.
1733 Also, include <sys/sysctl.h>, as it should be available on all
1734 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1735 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1736 use p_pid member, not kp_proc.pid.
1737
8eb876e2
GM
17382012-07-06 Glenn Morris <rgm@gnu.org>
1739
1740 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1741
38182d90
PE
17422012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1743
1744 More xmalloc and related cleanup.
1745 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1746 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1747 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1748 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1749 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1750 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1751 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1752 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1753 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1754 * xterm.c:
1755 Omit needless casts involving void * pointers and allocation.
1756 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1757 as the former is more robust if P's type is changed.
1758 Prefer xzalloc to xmalloc + memset 0.
1759 Simplify malloc-or-realloc to realloc.
1760 Don't worry about xmalloc returning a null pointer.
1761 Prefer xstrdup to xmalloc + strcpy.
1762 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1763 growing it.
1764 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1765 alloca of a constant.
1766
6dd5a677
EZ
17672012-07-05 Eli Zaretskii <eliz@gnu.org>
1768
1769 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1770 hscroll is larger than the line width. Fixes long and futile
1771 looping inside extend_face_to_end_of_line (on a TTY) producing
1772 glyphs that are not needed and thrown away.
1773
6b312f0f
DA
17742012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1775
1776 * marker.c (set_marker_restricted_both): Simplify by using
1777 clip_to_bounds.
1778
f520ef9b
PE
17792012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1780
1781 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1782
383b7c95
JD
17832012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1784
1785 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1786 not defined (Bug#11768).
1787 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1788 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1789 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1790 followed by gtk_box_set_homogeneous (Bug#11768).
1791 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1792 (update_theme_scrollbar_width, xg_create_scroll_bar):
1793 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1794 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1795 (is_box_type): New function (Bug#11768).
1796 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1797 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1798 with default display (Bug#11768).
1799
d6e7bf45
EZ
18002012-07-05 Eli Zaretskii <eliz@gnu.org>
1801
1802 * xdisp.c (window_hscroll_limited): New function.
1803 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1804 coordinates when window's hscroll is set to insanely large
1805 values. (Bug#11857)
1806
431391ec
JB
18072012-07-05 Juanma Barranquero <lekktu@gmail.com>
1808
1809 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1810 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1811
23f86fce
DA
18122012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1813
1814 Cleanup xmalloc.
1815 * lisp.h (xzalloc): New prototype. Omit needless casts.
1816 * alloc.c (xzalloc): New function. Omit needless casts.
1817 * charset.c: Omit needless casts. Convert all calls to
1818 xmalloc with following memset to xzalloc.
1819 * dispnew.c: Likewise.
1820 * fringe.c: Likewise.
1821 * image.c: Likewise.
1822 * sound.c: Likewise.
1823 * term.c: Likewise.
1824 * w32fns.c: Likewise.
1825 * w32font.c: Likewise.
1826 * w32term.c: Likewise.
1827 * xfaces.c: Likewise.
1828 * xfns.c: Likewise.
1829 * xterm.c: Likewise.
1830 * atimer.c: Omit needless casts.
1831 * buffer.c: Likewise.
1832 * callproc.c: Likewise.
1833 * ccl.c: Likewise.
1834 * coding.c: Likewise.
1835 * composite.c: Likewise.
1836 * doc.c: Likewise.
1837 * doprnt.c: Likewise.
1838 * editfns.c: Likewise.
1839 * emacs.c: Likewise.
1840 * eval.c: Likewise.
1841 * filelock.c: Likewise.
1842 * fns.c: Likewise.
1843 * gtkutil.c: Likewise.
1844 * keyboard.c: Likewise.
1845 * lisp.h: Likewise.
1846 * lread.c: Likewise.
1847 * minibuf.c: Likewise.
1848 * msdos.c: Likewise.
1849 * print.c: Likewise.
1850 * process.c: Likewise.
1851 * region-cache.c: Likewise.
1852 * search.c: Likewise.
1853 * sysdep.c: Likewise.
1854 * termcap.c: Likewise.
1855 * terminal.c: Likewise.
1856 * tparam.c: Likewise.
1857 * w16select.c: Likewise.
1858 * w32.c: Likewise.
1859 * w32reg.c: Likewise.
1860 * w32select.c: Likewise.
1861 * w32uniscribe.c: Likewise.
1862 * widget.c: Likewise.
1863 * xdisp.c: Likewise.
1864 * xmenu.c: Likewise.
1865 * xrdb.c: Likewise.
1866 * xselect.c: Likewise.
1867
0497dc44
PE
18682012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 * fileio.c (time_error_value): Check the right error number.
1871 Problem reported by Troels Nielsen in
1872 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1873
356e7178
PE
18742012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1875
4e71fd89
PE
1876 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1877 This should be fixed in a better way; see Eli Zaretskii in
1878 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1879 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1880
f0941253
PE
1881 * fileio.c (time_error_value): Rename from special_mtime.
1882 The old name's problems were noted by Eli Zaretskii in
1883 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1884
065c9eb4
PE
1885 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1886 This variable's comment says Emacs needs at least one GDB-visible
1887 symbol of type enum pvec_type, to work around GDB problems.
1888 The symbol's value doesn't matter.
1889
356e7178
PE
1890 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1891 that causes compilation to fail on pre-C99 compilers.
1892
ed9265fc 18932012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1894
1895 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1896 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1897
3884d954
DA
18982012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1899
d209e2fb 1900 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1901 headers for buffer_defaults and buffer_local_symbols.
1902 Reported by Juanma Barranquero <lekktu@gmail.com>.
1903
ee28be33
SM
19042012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1905
1906 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1907 * lisp.h (enum pvec_type): Use fewer bits.
1908 (PSEUDOVECTOR_SIZE_BITS): New constant.
1909 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1910 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1911 change in pvec_type.
1912 (PSEUDOVECTOR_TYPEP): New macro.
1913 (TYPED_PSEUDOVECTORP): Use it.
1914 * fns.c (internal_equal): Adapt code to extract pvectype.
1915 * emacs.c (gdb_pvec_type): Update type.
1916 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1917 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1918 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1919 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1920 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1921 abusing vector->header.next.nbytes.
1922 (live_vector_p): Use PVEC_TYPE.
1923 (mark_object): Adapt code to extract pvectype. Use switch.
1924
c7f2cd7f
PE
19252012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1928 Tighten new eassert a bit.
1929
8ce70ed2
DA
19302012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1931
1932 Fix compilation with --enable-gcc-warnings and -O1
1933 optimization level.
1934 * doprnt.c (doprnt): Change type of tem to int, initialize
1935 to avoid compiler warning. Add eassert.
1936 * search.c (simple_search): Initialize match_byte to avoid
1937 compiler warning. Add eassert.
1938
dea7f1e5
PE
19392012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1940
24a212eb
PE
1941 Avoid weird behavior with large horizontal scrolls.
1942 Without this change, for example, large hscroll values would
1943 mess up Emacs's display on Fedora 15 x86, presumably due to
1944 overflows in int calculations in the display code.
1945 Also, if buffers had long lines, Emacs would freeze.
1946 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1947 (set_window_hscroll): New function, containing the old guts of
1948 Fset_window_hscroll. Return the clipped value.
1949 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1950 This avoids the need to check against PTRDIFF_MAX.
1951
dea7f1e5
PE
1952 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1953
76046526
DA
19542012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1955
1956 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1957
39adff0d
PE
19582012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1959
63807d47
PE
1960 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1961 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1962 since GCC 4.4.6 issues a bogus warning for them.
1963
39adff0d
PE
1964 Fix bugs in file timestamp newness comparisons.
1965 * fileio.c (Ffile_newer_than_file_p):
1966 * lread.c (Fload): Use full timestamp resolution of files,
1967 not just the 1-second resolution, so that files that are only
1968 slightly newer still count as newer.
1969 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1970 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1971
dbeed9a6
PE
19722012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 * fileio.c: Improve handling of file time marker. (Bug#11852)
1975 (special_mtime): New function.
1976 (Finsert_file_contents, Fverify_visited_file_modtime):
1977 Use it to set special mtime values consistently.
1978
636334d6
AS
19792012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1980
1981 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1982 marker for non-existing file. (Bug#11852)
1983
e2017fe2
GM
19842012-07-03 Glenn Morris <rgm@gnu.org>
1985
1986 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1987 and did not make it into globals.h).
1988
404dbd37
TT
19892012-07-03 Tom Tromey <tromey@redhat.com>
1990
1991 * window.c (Fset_window_margins, Fset_window_fringes)
1992 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1993 * textprop.c (Fprevious_property_change): No longer static.
1994 * syntax.c (Fsyntax_table_p): No longer static.
1995 * process.c (Fget_process, Fprocess_datagram_address): No longer
1996 static.
1997 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1998 * keyboard.c (Fcommand_execute): No longer static.
1999 Remove EXFUN.
2000 * insdel.c (Fcombine_after_change_execute): No longer static.
2001 * image.c (Finit_image_library): No longer static.
2002 * fileio.c (Fmake_symbolic_link): No longer static.
2003 * eval.c (Ffetch_bytecode): No longer static.
2004 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2005 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2006 No longer static.
404dbd37
TT
2007 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2008 static.
2009 * dired.c (Ffile_attributes): No longer static.
2010 * composite.c (Fcomposition_get_gstring): No longer static.
2011 * callproc.c (Fgetenv_internal): No longer static.
2012
2013 * ccl.h: Remove EXFUNs.
2014 * buffer.h: Remove EXFUNs.
2015 * dispextern.h: Remove EXFUNs.
2016 * intervals.h: Remove EXFUNs.
2017 * fontset.h: Remove EXFUN.
2018 * font.h: Remove EXFUNs.
2019 * dosfns.c (system_process_attributes): Remove EXFUN.
2020 * keymap.h: Remove EXFUNs.
2021 * lisp.h: Remove EXFUNs.
2022 * w32term.h: Remove EXFUNs.
2023 * window.h: Remove EXFUNs.
2024 * xsettings.h: Remove EXFUN.
2025 * xterm.h: Remove EXFUN.
2026
8e4fd1e1
GM
20272012-07-03 Glenn Morris <rgm@gnu.org>
2028
2029 * lisp.h (Frandom): Make it visible to C.
2030 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2031 buffer for invisible buffers. (Bug#1229)
2032
ca95b3eb
DA
20332012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2034
2035 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2036 values which aren't power of 2.
2037 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2038 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2039 accordingly.
2040
7555c33f
SM
20412012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2042
2043 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2044
2045 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2046
d12e8f5a
DA
20472012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2048
2049 * alloc.c (allocate_vector_block): Remove redundant
2050 calls to mallopt if DOUG_LEA_MALLOC is defined.
2051 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2052 avoid calls to mallopt if zero_vector is returned.
2053
296094c3
DA
20542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2055
2056 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2057 is enabled, avoid dereferencing NULL current_sblock if
2058 running undumped.
2059
36429c89
DA
20602012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2061
2062 Cleanup basic buffer management.
2063 * buffer.h (struct buffer): Change layout to use generic vector
2064 marking code. Fix some comments. Change type of 'clip_changed'
2065 to bitfield. Remove unused #ifndef old.
2066 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2067 (GET_OVERLAYS_AT): Fix indentation.
2068 (for_each_per_buffer_object_at): New macro.
2069 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2070 (Fbuffer_local_variables): Use it.
2071 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2072 * alloc.c (allocate_buffer): Adjust to match new layout of
2073 struct buffer. Fix comment.
2074 (mark_overlay): New function.
2075 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2076 Lisp area of struct buffer.
2077 (mark_object): Use it. Adjust marking of misc objects
2078 and related comments.
2079
3b3e4cac
PE
20802012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2081
2082 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2083 wrapper that is not needed because the wrapped code is a no-op (zero
2084 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2085 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2086
cf5c0175
DA
20872012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2088
2089 * alloc.c (mark_buffer): Simplify. Remove prototype.
2090 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2091 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2092 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2093 redundant calls to mark_vectorlike for bool vectors.
2094
ca26824c
GM
20952012-06-30 Glenn Morris <rgm@gnu.org>
2096
2e4c5312
GM
2097 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2098
ca26824c
GM
2099 * epaths.in (PATH_SITELOADSEARCH): New.
2100 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2101 This is rather than relying on --enable-locallisppath elements
2102 having "site-lisp" in their names. (Bug#10208#25, 11658)
2103
0d23c240
EZ
21042012-06-30 Eli Zaretskii <eliz@gnu.org>
2105
c9240d7a
EZ
2106 * w32proc.c (sys_select): Accept and ignore one more argument.
2107
2108 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2109
0d23c240 2110 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2111 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2112
2113 * sysdep.c: Don't include dos.h and dosfns.h.
2114
2115 * process.c (sys_select):
2116 * msdos.c (sys_select): Accept one more argument and ignore it.
2117
2118 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2119 adapt data types and code to that.
2120
2121 * dosfns.c:
2122 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2123 which clashes with the gnulib function of the same name.
2124
af5a5a98
AS
21252012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2126
c5e4379c
AS
2127 * font.c (font_style_to_value, font_style_symbolic)
2128 (font_prop_validate_style): Add type checks for values in
2129 font_style_table.
2130
af5a5a98
AS
2131 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2132 argument.
2133 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2134 uses.
2135
8d38f461
EZ
21362012-06-29 Eli Zaretskii <eliz@gnu.org>
2137
2e5a6631
EZ
2138 * xdisp.c (try_window_id): Undo last change.
2139
8d38f461
EZ
2140 * w32.c (getwd): Adjust commentary about startup_dir.
2141 (init_environment): Always call sys_access, even in non-MSVC
2142 builds. Don't chdir to the directory of the Emacs executable.
2143 This undoes code from 1997 which was justified by the need to
2144 "avoid conflicts when removing and renaming directories". But its
2145 downside was that every relative file name was being interpreted
2146 relative to the directory of the Emacs executable, which can never
2147 be TRT. In particular, it broke sys_access when called with
2148 relative file names.
2149 (sys_access): Map GetLastError to errno.
2150
2af3565e
DA
21512012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2152
2153 * window.h (struct window): Change type of 'fringes_outside_margins'
2154 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2155 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2156 Adjust comment.
2157 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2158 to ptrdiff_t.
2159
c8d3a25c 21602012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2161
c8d3a25c
GM
2162 * gnutls.c (emacs_gnutls_handshake):
2163 Add QUIT to make the loop interruptible.
57570cd3 2164
c8d3a25c 21652012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2166
c8d3a25c
GM
2167 * charset.c (init_charset): Make lack of etc/charsets fatal.
2168
3e984ee8
DA
21692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2170
2171 * editfns.c (region_limit): Fix type mismatch.
2172
ef884f23
DA
21732012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2174
2175 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2176 undefined. Convert from xassert to eassert.
2177 * nsmenu.m: Convert from xassert to eassert.
2178 * nsterm.m: Likewise.
2179
7d7e0027
SM
21802012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2181
2182 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2183
aa754e6a
PE
21842012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2185
2186 Avoid integer overflow on scroll-left and scroll-right.
2187 * window.c (HSCROLL_MAX): New macro.
2188 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2189 overflow when requested scroll falls outside ptrdiff_t range.
2190
80b00b08
DA
21912012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2192
2193 * window.h (struct window): Change type of 'hscroll',
2194 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2195 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2196 Adjust users accordingly.
2197 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2198 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2199 from EMACS_INT to ptrdiff_t.
2200 (make_window): Omit redundant initialization.
2201
62b2bcf6
JB
22022012-06-28 Juanma Barranquero <lekktu@gmail.com>
2203
2204 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2205
45942c7d
DA
22062012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2207
2208 * window.h (struct window): Change type of 'use_time' and
2209 'sequence_number' from Lisp_Object to int.
2210 * frame.c (make_frame): Adjust users accordingly.
2211 * print.c (print_object): Likewise.
2212 * window.c (select_window, Fwindow_use_time, make_parent_window)
2213 (make_window): Likewise.
2214
e509cfa6
DA
22152012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2216
2217 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2218 enabled with --enable-checking=[all,glyphs] configure option.
2219 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2220 adjust comments accordingly.
2221 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2222 undefined, adjust comments accordingly.
2223 * image.c: Likewise.
2224 * scroll.c: Likewise.
2225 * w32fns.c: Likewise.
2226 * w32term.c: Likewise.
2227 * xdisp.c: Likewise.
2228 * xfaces.c: Likewise.
2229 * xfns.c: Likewise.
2230 * xterm.c: Likewise.
2231
a54e2c05
DA
22322012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2233
2234 Generalize run-time debugging checks.
2235 * dispextern.h (XASSERTS): Remove.
2236 * fontset.c (xassert): Remove.
2237 Convert from xassert to eassert.
2238 * alloc.c: Convert from xassert to eassert.
2239 * bidi.c: Likewise.
2240 * dispnew.c: Likewise.
2241 * fns.c: Likewise.
2242 * fringe.c: Likewise.
2243 * ftfont.c: Likewise.
2244 * gtkutil.c: Likewise.
2245 * image.c: Likewise.
2246 * keyboard.c: Likewise.
2247 * menu.c: Likewise.
2248 * process.c: Likewise.
2249 * scroll.c: Likewise.
2250 * sound.c: Likewise.
2251 * term.c: Likewise.
2252 * w32console.c: Likewise.
2253 * w32fns.c: Likewise.
2254 * w32term.c: Likewise.
2255 * window.c: Likewise.
2256 * xdisp.c: Likewise.
2257 * xfaces.c: Likewise.
2258 * xfns.c: Likewise.
2259 * xselect.c: Likewise.
2260 * xterm.c: Likewise.
2261
1ec4b7b2
SM
22622012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2263
2264 * fns.c (maybe_resize_hash_table): Output message when growing the
2265 purify-hashtable.
2266
2014308a
DA
22672012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2268
2269 * alloc.c (allocate_string_data): Remove dead code.
2270 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2271 avoid GCC warning about unused macro.
2272
246155eb
DA
22732012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2274
2275 * alloc.c (allocate_string): Omit intervals initialization.
2276 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2277 as in make_pure_string and make_pure_c_string.
2278
43184b7b
DA
22792012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2280
d209e2fb 2281 * alloc.c (allocate_string): Fix last change.
43184b7b 2282
3fe6dd74
DA
22832012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2284
d209e2fb 2285 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2286 to memset, add explicit initialization where appropriate.
2287
1ba6038a
GM
22882012-06-27 Glenn Morris <rgm@gnu.org>
2289
2290 * lisp.mk (lisp): Remove paths.elc.
2291
c89926a5
CY
22922012-06-27 Chong Yidong <cyd@gnu.org>
2293
2294 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2295
ed6b3510
JW
22962012-06-26 John Wiegley <johnw@newartisans.com>
2297
1ec4b7b2 2298 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2299 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2300
ed6b3510
JW
2301 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2302 when building with Clang.
2303
8edd4a2b
SM
23042012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2305
2306 * eval.c (Fapply): Allow calling it with a single argument.
2307
f6f62d1b
EZ
23082012-06-26 Eli Zaretskii <eliz@gnu.org>
2309
2310 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2311 _stricmp and _strnicmp.
2312 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2313
62efea5e
DA
23142012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2315
2316 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2317 allocated window.
2318 (allocate_process): Likewise for new process.
8edd4a2b 2319 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2320 (allocate_frame): Likewise.
2321 * frame.c (make_frame): Omit redundant initialization.
2322 * window.c (make_parent_window): Use memset.
2323 (make_window): Omit redundant initialization.
2324 * process.c (make_process): Omit redundant initialization.
2325 * terminal.c (create_terminal): Likewise.
2326
42997f4d
DA
23272012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2328
2329 * term.c (delete_tty): Remove redundant call to memset.
2330
1130ecfc
DA
23312012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2332
2333 * alloc.c: Remove build_string.
2334 * lisp.h: Define build_string as static inline. This provides
2335 a better opportunity to optimize away calls to strlen when the
2336 function is called with compile-time constant argument.
2337 * image.c (imagemagick_error): Convert to build_string.
2338 * w32proc.c (sys_spawnve): Likewise.
2339 * xterm.c (x_term_init): Likewise.
2340
cf38a720
PE
23412012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2342
99027bdd
PE
2343 Use sprintf return value instead of invoking strlen on result.
2344 In the old days this wasn't portable, since some sprintf
2345 implementations returned char *. But they died out years ago and
2346 Emacs already assumes sprintf returns int.
2347 Similarly for float_to_string.
2348 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2349 * ccl.c (ccl_driver):
2350 * character.c (string_escape_byte8):
2351 * data.c (Fnumber_to_string):
2352 * doprnt.c (doprnt):
2353 * print.c (print_object):
2354 * xdisp.c (message_dolog):
2355 * xfns.c (syms_of_xfns):
2356 Use sprintf or float_to_string result to avoid need to call strlen.
2357 * data.c (Fnumber_to_string):
2358 Use make_unibyte_string, since the string must be ASCII.
2359 * lisp.h, print.c (float_to_string): Now returns int length.
2360 * term.c (produce_glyphless_glyph):
2361 Use sprintf result rather than recomputing it.
2362
cf38a720
PE
2363 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2364 * Makefile.in (ALL_CFLAGS):
2365 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2366 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2367
3511c784
DA
23682012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2369
0a08eb21 2370 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2371 strcasecmp if available.
2372 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2373
fb7da12e
AS
23742012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2375
2376 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2377 Avoid comma operator.
2378 * menu.c (push_submenu_start, push_submenu_end)
2379 (push_left_right_boundary, push_menu_pane): Likewise.
2380 * msdos.c (dos_rawgetc): Likewise.
2381
afa2ffd8
DA
23822012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2383
2384 * xfns.c (xic_create_fontsetname): Remove redundant calls
2385 to memset.
2386
b3b4476b
PE
23872012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2388
4495ff38
PE
2389 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2390 sprintf already null-terminates its output.
2391
b3b4476b
PE
2392 * xfns.c (x_window): Remove redundant cast.
2393
b00876c9
DA
23942012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2395
2396 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2397 `const char *' to `char *' to avoid compiler warning.
2398
d188e26b
PE
23992012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2400
885d1d74
PE
2401 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2402 instead of truncating it to 63 (admittedly a generous limit).
2403
d188e26b
PE
2404 * process.c: Fix spelling and caps in comments.
2405
e2f560b1
DN
24062012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2407
e86db54b 2408 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2409 * sysdep.c (setpgrp): Remove definition, not used in this file.
2410
7583a3a1
JB
24112012-06-24 Juanma Barranquero <lekktu@gmail.com>
2412
2413 * makefile.w32-in: Update dependencies.
2414
696056c2
EZ
24152012-06-24 Eli Zaretskii <eliz@gnu.org>
2416
2417 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2418 (SYSTIME_H): Add nt/inc/sys/time.h.
2419
2420 * systime.h [WINDOWSNT]: Include sys/time.h.
2421
2422 * s/ms-w32.h (struct timespec): Definition moved from
2423 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2424
845ca893
PE
24252012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2426
2427 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2428 * buffer.h (buffer_slot_type_mismatch):
2429 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2430 * eval.c (unwind_to_catch):
2431 * image.c (my_png_error, my_error_exit):
2432 * keyboard.c (quit_throw_to_read_char, user_error)
2433 (Fexit_recursive_edit, Fabort_recursive_edit):
2434 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2435 (wrong_type_argument, buffer_overflow, __executable_start)
2436 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2437 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2438 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2439 (fatal):
2440 (child_setup) [!DOS_NT]:
2441 * lread.c (end_of_file_error, invalid_syntax):
2442 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2443 * puresize.h (pure_write_error):
2444 * search.c (matcher_overflow):
2445 * sound.c (sound_perror, alsa_sound_perror):
2446 * sysdep.c, syssignal.h (croak):
2447 * term.c (maybe_fatal, vfatal):
2448 * textprop.c (text_read_only):
2449 * undo.c (user_error):
2450 * unexmacosx.c (unexec_error):
2451 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2452 Use _Noreturn rather than NO_RETURN.
2453 No need for separate decl merely because of _Noreturn.
2454 * sound.c (sound_warning, parse_sound):
2455 Remove unnecessary forward decls.
2456
f1dd8073
PE
24572012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2458
2459 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2460 * lisp.h (WAIT_READING_MAX): New macro.
2461 * dispnew.c (Fsleep_for, sit_for):
2462 * keyboard.c (kbd_buffer_get_event):
2463 * process.c (Faccept_process_output):
2464 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2465 This improves on the previous patch, which introduced a bug
2466 when time_t is unsigned and as wide as intmax_t.
2467 See <http://bugs.gnu.org/9000#51>.
2468
b82c1755
EZ
24692012-06-23 Eli Zaretskii <eliz@gnu.org>
2470
2471 * dispnew.c (sit_for, Fsleep_for):
2472 * keyboard.c (kbd_buffer_get_event):
2473 * process.c (Faccept_process_output): Avoid compiler warnings when
2474 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2475
ca300656
JB
24762012-06-23 Juanma Barranquero <lekktu@gmail.com>
2477
049ec95b
JB
2478 * makefile.w32-in: Update dependencies.
2479
ca300656
JB
2480 * w32.c (ltime): Add return type and declare static.
2481 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2482
db7b8d06
PE
24832012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2486 Privately reported by Herbert J. Skuhra.
2487 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2488 All uses changed.
2489 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2490 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2491
0bd8297f
EZ
24922012-06-23 Eli Zaretskii <eliz@gnu.org>
2493
96512555
EZ
2494 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2495 last argument of make_unibyte_string.
2496
0bd8297f
EZ
2497 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2498 language ID in the event parameters.
2499
2500 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2501 event.code, not the obscure "character set ID".
2502
63def6b6
CY
25032012-06-23 Chong Yidong <cyd@gnu.org>
2504
2505 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2506
e8a02204
EZ
25072012-06-23 Eli Zaretskii <eliz@gnu.org>
2508
388cdec0
EZ
2509 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2510 * w32.c (fdutimens): New function.
2511
2512 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2513
2514 * s/ms-w32.h (pselect): Redirect to sys_select.
2515
2516 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2517
e8a02204
EZ
2518 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2519 in the logic of incrementing and decrementing the value of
2520 use_relocatable_buffers.
2521
d054f3fb
PE
25222012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2523
2524 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2525 Privately reported by Herbert J. Skuhra.
2526 [__FreeBSD__]: Remove "*/" typo after "#include".
2527 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2528 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2529 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2530 Don't assume EMACS_TIME and struct timeval are the same type.
2531
d35af63c
PE
25322012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2533
2534 Support higher-resolution time stamps (Bug#9000).
2535 The time stamps are only nanosecond-resolution at the C level,
2536 since that's the best that any real-world system supports now.
2537 But they are picosecond-resolution at the Lisp level, as that's
2538 easy, and leaves room for future OS improvements.
2539
2540 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2541 (LIBES): Use it.
2542
2543 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2544 Don't get current time unless it's needed.
2545
2546 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2547 now provides it if it's absent.
2548 (start_atimer): Port to higher-res time stamps.
2549 Check for time stamp overflow. Don't get current time more
2550 often than is needed.
2551
2552 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2553 Include systime.h, not time.h.
2554 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2555
2556 * dired.c: Include stat-time.h.
2557 (Ffile-attributes): File times now have higher resolution.
2558
2559 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2560 (struct image): Timestamp now has higher resolution.
2561
2562 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2563 has at least microseconds now. All uses removed.
2564 (update_frame, update_single_window, update_window, update_frame_1)
2565 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2566
2567 * editfns.c (time_overflow): Now extern.
2568 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2569 (float-time, Fformat_time_string, Fcurrent_time_string)
2570 (Fcurrent_time_zone): Accept and generate higher-resolution
2571 time stamps.
2572 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2573 (decode_time_components, lisp_seconds_argument): New functions.
2574 (make_time): Now static.
2575 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2576 Report an error if the time is invalid, rather than having the caller
2577 do that.
2578
2579 * fileio.c: Include <stat-time.h>
2580 (Fcopy_file): Copy higher-resolution time stamps.
2581 Prefer to set the time stamp via a file descriptor if that works.
2582 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2583 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2584 (Fvisited_file_modtime, Fset_visited_file_modtime):
2585 Support higher-resolution time stamps.
2586
2587 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2588
2589 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2590
2591 * image.c (prepare_image_for_display, clear_image_cache)
2592 (lookup_image): Port to higer-resolution time stamps.
2593
2594 * keyboard.c (start_polling, bind_polling_period):
2595 Check for time stamp overflow.
2596 (read_char, kbd_buffer_get_event, timer_start_idle)
2597 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2598 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2599 Port to higher-resolution time stamps. Do not assume time_t is signed.
2600 (decode_timer): New function. Timers are now vectors of length 9,
2601 not 8, to accommodate the picosecond component.
2602 (timer_check_2): Use it.
2603
2604 * nsterm.m (select_timeout, timeval_subtract): Remove.
2605 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2606 as they're a bit more accurate and handle overflow better.
2607 (ns_select): Change prototype to be compatible with pselect.
2608 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2609 * nsterm.h (ns_select): Adjust prototype.
2610
2611 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2612 us-resolution time stamps.
2613 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2614
2615 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2616
2617 * lisp.h (time_overflow): New decl.
2618 (wait_reading_process_output): First arg is now intmax_t, not int,
2619 to accommodate larger waits.
2620
2621 * process.h (struct Lisp_Process.read_output_delay):
2622 Now counts nanoseconds, not microseconds.
2623 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2624 EMACS_HAS_USECS.
2625 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2626 (wait_reading_process_output):
2627 Port to ns-resolution time stamps.
2628 (Faccept_process_output, wait_reading_process_output):
2629 Check for time stamp overflow. Do not assume time_t is signed.
2630 (select_wrapper): Remove; we now use pselect.
2631 (Fprocess_attributes): Now generates ns-resolution time stamps.
2632
2633 * sysdep.c: Include utimens.h. Don't include utime.h
2634 or worry about struct utimbuf; gnulib does that for us now.
2635 (gettimeofday): Remove; gnulib provides a substitute.
2636 (make_timeval): New function.
2637 (set_file_times): Now sets ns-resolution time stamps.
2638 New arg FD; all uses changed.
2639 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2640 (system_process_attributes):
2641 Now returns ns-resolution time stamp. All uses changed.
2642 Check for time stamp overflow.
2643
2644 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2645 provides a substitute now.
2646
2647 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2648 since it guarantees struct timespec.
2649 (EMACS_TIME): Now struct timespec, so that we can support
2650 ns-resolution time stamps.
2651 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2652 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2653 (EMACS_USECS): Remove.
2654 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2655 so multiply the arg by 1000 before storing it.
2656 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2657 New macros.
2658 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2659 Port to ns-resolution time stamps.
2660 (EMACS_TIME_NEG_P): Remove; replaced by....
2661 (EMACS_TIME_SIGN): New macro.
2662 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2663 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2664 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2665 (make_timeval, make_lisp_time, decode_time_components): New decls.
2666 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2667 that it mishandled time_t overflow. You can't compare by subtracting!
2668 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2669 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2670
2671 * term.c: Include <sys/time.h>.
2672 (timeval_to_Time): New function, for proper overflow wraparound.
2673 (term_mouse_position, term_mouse_click): Use it.
2674
2675 * undo.c (record_first_change): Support higher-resolution time stamps
2676 in the undo buffer.
2677 (Fprimitive_undo): Use them when restoring time stamps.
2678
2679 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2680 (w32_get_internal_run_time):
2681 Port to higher-resolution Emacs time stamps.
2682 (ltime): Now accepts single 64-bit integer, as that's more convenient
2683 for callers.
2684
2685 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2686
2687 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2688 for compatibility with pselect. Support ns-resolution time stamps.
2689
2690 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2691
2692 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2693 Check for time stamp overflow, and support ns-resolution time stamps.
2694
2695 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2696 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2697 (timeval_subtract): Remove; no longer needed.
2698 (XTflash, XTring_bell, x_wait_for_event):
2699 Port to ns-resolution time stamps. Don't assume time_t is signed.
2700
b6a92dfe
CY
27012012-06-22 Chong Yidong <cyd@gnu.org>
2702
2703 * xdisp.c (x_consider_frame_title): Revert last change.
2704
d251c37c
EZ
27052012-06-22 Eli Zaretskii <eliz@gnu.org>
2706
2707 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2708 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2709 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2710 staticidx goes up to 1597 out of 1600 = 0x640.)
2711
f10deafb
PE
27122012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2713
2714 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2715 Otherwise, the umask might be mistakenly 0 while handling input signals.
2716
ec6de1e2
SM
27172012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2718
2719 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2720
28be1ada
DA
27212012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2722
2723 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2724 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2725 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2726 access to `contents' member of Lisp_Vector objects with AREF and ASET
2727 where appropriate.
2728
c6bf3022
CY
27292012-06-19 Chong Yidong <cyd@gnu.org>
2730
2731 * frame.c (delete_frame): When selecting a frame on a different
2732 text terminal, do not alter the terminal's top-frame.
2733
2734 * xdisp.c (format_mode_line_unwind_data): Record the target
2735 frame's selected window and its terminal's top-frame.
2736 (unwind_format_mode_line): Restore them.
2737 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2738 Callers changed.
2739 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2740 since tty frames can be explicitly named.
2741 (prepare_menu_bars): Likewise.
2742
2743 * term.c (Ftty_top_frame): New function.
2744
defd4196
PE
27452012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2746
2747 Port byte-code-meter to modern targets.
2748 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2749 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2750 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2751 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2752 (METER_1, METER_2): Simplify.
2753
1053a871
SM
27542012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2755
2756 * data.c (Fdefalias): Return `symbol' (bug#11686).
2757
b7e8d081
MR
27582012-06-18 Martin Rudalics <rudalics@gmx.at>
2759
2760 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2761 gets killed during executing of this function (Bug#11665).
2762 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2763 (Vkill_buffer_query_functions): In doc-string say that functions
2764 run by this hook should not change the current buffer.
2765
7ea2b339
PE
27662012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2767
2768 Fix recently-introduced process.c problems found by static checking.
2769 * process.c (write_queue_push, write_queue_pop, send_process):
2770 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2771 (write_queue_pop): Fix pointer signedness problem.
2772 (send_process): Remove unused local.
2773
96a313a1
CY
27742012-06-17 Chong Yidong <cyd@gnu.org>
2775
2776 * xdisp.c (redisplay_internal): No need to redisplay terminal
2777 frames that are not on top.
2778
20ca2e94
TN
27792012-06-17 Troels Nielsen <bn.troels@gmail.com>
2780
2781 * process.c (make_process): Initialize write_queue.
2782 (write_queue_push, write_queue_pop): New functions.
2783 (send_process): Use them to maintain correct ordering of process
2784 writes (Bug#10815).
2785
9a900ca9
PE
27862012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2787
310fbfa8
PE
2788 * lisp.h (eassert): Assume C89 or later.
2789 This removes the need for CHECK.
2790 (CHECK): Remove. Its comments about always evaluating its
2791 argument were confusing, as 'eassert' typically does not evaluate
2792 its argument.
2793
27bb1ca4
PE
2794 * coding.c (produce_chars): Use ptrdiff_t, not int.
2795
9a900ca9
PE
2796 * xterm.c (x_draw_underwave): Check for integer overflow.
2797 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2798
41b7f8bc 27992012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2800
2801 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2802 referenced (Bug#11583).
2803
9b0e3eba
AA
28042012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2805
2806 Implement wave-style variant of underlining.
2807 * dispextern.h (face_underline_type): New enum.
2808 (face): Add field for underline type.
2809 * nsterm.m (ns_draw_underwave): New function.
2810 (ns_draw_text_decoration): Use it.
2811 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2812 New functions.
2813 (x_draw_glyph_string): Use them.
2814 * xfaces.c (Qline, Qwave): New Lisp objects.
2815 (check_lface_attrs, merge_face_ref)
1053a871
SM
2816 (Finternal_set_lisp_face_attribute, realize_x_face):
2817 Handle wave-style underline face attributes.
9b0e3eba
AA
2818 * xterm.c (x_draw_underwave): New function.
2819 (x_draw_glyph_string): Use it.
2820
0fb52f11
JB
28212012-06-16 Juanma Barranquero <lekktu@gmail.com>
2822
2823 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2824 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2825 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2826 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2827 ($(BLD)/w32select.$(O)): Update dependencies.
2828
e5560ff7
AS
28292012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2830
2831 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2832 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2833 * character.c (_fetch_multibyte_char_p): Remove.
2834 * alloc.c: Include "character.h" before "buffer.h".
2835 * bidi.c: Likewise.
2836 * buffer.c: Likewise.
2837 * bytecode.c: Likewise.
2838 * callint.c: Likewise.
2839 * callproc.c: Likewise.
2840 * casefiddle.c: Likewise.
2841 * casetab.c: Likewise.
2842 * category.c: Likewise.
2843 * cmds.c: Likewise.
2844 * coding.c: Likewise.
2845 * composite.c: Likewise.
2846 * dired.c: Likewise.
2847 * dispnew.c: Likewise.
2848 * doc.c: Likewise.
2849 * dosfns.c: Likewise.
2850 * editfns.c: Likewise.
2851 * emacs.c: Likewise.
2852 * fileio.c: Likewise.
2853 * filelock.c: Likewise.
2854 * font.c: Likewise.
2855 * fontset.c: Likewise.
2856 * fringe.c: Likewise.
2857 * indent.c: Likewise.
2858 * insdel.c: Likewise.
2859 * intervals.c: Likewise.
2860 * keyboard.c: Likewise.
2861 * keymap.c: Likewise.
2862 * lread.c: Likewise.
2863 * macros.c: Likewise.
2864 * marker.c: Likewise.
2865 * minibuf.c: Likewise.
2866 * nsfns.m: Likewise.
2867 * nsmenu.m: Likewise.
2868 * print.c: Likewise.
2869 * process.c: Likewise.
2870 * regex.c: Likewise.
2871 * region-cache.c: Likewise.
2872 * search.c: Likewise.
2873 * syntax.c: Likewise.
2874 * term.c: Likewise.
2875 * textprop.c: Likewise.
2876 * undo.c: Likewise.
2877 * unexsol.c: Likewise.
2878 * w16select.c: Likewise.
2879 * w32fns.c: Likewise.
2880 * w32menu.c: Likewise.
2881 * window.c: Likewise.
2882 * xdisp.c: Likewise.
2883 * xfns.c: Likewise.
2884 * xmenu.c: Likewise.
2885 * xml.c: Likewise.
2886 * xselect.c: Likewise.
2887
2f07e6af
EZ
28882012-06-16 Eli Zaretskii <eliz@gnu.org>
2889
1053a871
SM
2890 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2891 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2892 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2893 row.
2894 (handle_face_prop): Use chunk-relative overlay string index when
2895 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2896 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2897 the rightmost. (Bug#11720)
2f07e6af 2898
29b83cec
AS
28992012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2900
2901 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2902 (CATEGORY_MEMBER): Enforce 1/0 value.
2903 * category.c (_temp_category_set): Remove.
2904
4c5501e9
EZ
29052012-06-16 Eli Zaretskii <eliz@gnu.org>
2906
2907 * window.c (Fdelete_other_windows_internal)
2908 (Fdelete_window_internal): Don't access frame's mouse highlight
2909 info of the initial frame. (Bug#11677)
2910
2b570124
PE
29112012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2912
e93864f9
PE
2913 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2914 Assume USE_2_TAGS_FOR_INTS.
2915 (xreload): Adjust $tagmask width to match recent lisp.h change.
2916
2b570124
PE
2917 Simplify lisp.h in minor ways that should not affect code.
2918 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2919 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2920 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2921 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2922 (INTTYPEBITS): New macro, for clarity.
2923 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2924 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2925 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2926 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2927 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2928
81755f69
JB
29292012-06-13 Juanma Barranquero <lekktu@gmail.com>
2930
2931 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2932
16192a57
GM
29332012-06-13 Glenn Morris <rgm@gnu.org>
2934
2935 * s/bsd-common.h (BSD4_3):
2936 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2937
646b5f55
AS
29382012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2939
2940 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2941 instead of union.
2942 (XLI, XIL): Define.
1053a871
SM
2943 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2944 Use them.
2945 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2946 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2947 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2948 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2949 * frame.c (delete_frame): Remove outdated comment.
2950 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2951 USE_LISP_UNION_TYPE.
2952 (Fw32_unregister_hot_key): Likewise.
2953 (Fw32_toggle_lock_key): Likewise.
2954 * w32menu.c (add_menu_item): Likewise.
2955 (w32_menu_display_help): Use XIL instead of checking
2956 USE_LISP_UNION_TYPE.
2957 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2958 (init_heap): Likewise.
2959 * w32term.c (w32_read_socket): Update comment.
2960
1d3823c9
GM
29612012-06-13 Glenn Morris <rgm@gnu.org>
2962
c62ff706
GM
2963 * s/usg5-4-common.h, src/s/unixware.h:
2964 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2965
1d3823c9
GM
2966 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2967
bfe3e0a2
PE
29682012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2969
2970 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2971 * alloc.c (make_number) [!defined make_number]:
2972 Remove, as lisp.h always defines this now.
2973 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2974 (roundup_size): Verify that it is a power of 2.
2975 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2976 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2977 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2978 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2979 USE_LSB_TAG now is always defined to be either 0 or 1.
2980 All uses changed.
2981 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2982 code works fine either way, and efficiency is not a concern here,
2983 as the union type is for debugging, not for production.
2984 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2985 Use an inline function on all platforms when using the union type,
2986 since this is simpler and 'static inline' can be used portably
2987 within Emacs now.
2988 (LISP_INITIALLY_ZERO): New macro.
2989 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2990 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2991
45fa9c0f
GM
29922012-06-12 Glenn Morris <rgm@gnu.org>
2993
b4492cba
GM
2994 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2995
2996 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2997
45fa9c0f
GM
2998 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2999 Move BROKEN_SIGIO to configure.
3000
3001 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3002 Move NO_TERMIO to configure.
3003
0e25d334
CY
30042012-06-12 Chong Yidong <cyd@gnu.org>
3005
3006 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3007 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3008 MagickExportImagePixels is undefined.
3009
43682bb6
PE
30102012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3011
3012 * image.c (imagemagick_load_image): Remove unused label.
3013
a9be7d2b
GM
30142012-06-11 Glenn Morris <rgm@gnu.org>
3015
3016 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3017 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3018 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3019 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3020
3017f87f
SM
30212012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3022
3023 * alloc.c (make_byte_code): New function.
3024 (Fmake_byte_code): Use it. Don't purify here.
3025 * lread.c (read1): Use it as well to avoid extra allocation.
3026
1b9b4cf4
CY
30272012-06-11 Chong Yidong <cyd@gnu.org>
3028
3029 * image.c (imagemagick_load_image): Implement transparency.
3030
95988fcf
AS
30312012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3032
3033 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3034 account for preceding backslashes. (Bug#11663)
3035
cd4eb164
CY
30362012-06-09 Chong Yidong <cyd@gnu.org>
3037
3038 * term.c: Support italics in capable terminals (Bug#9652).
3039 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3040 (turn_on_face): Output using TS_enter_italic_mode if available.
3041 Don't handle unused blinking and alt-charset cases.
3042 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3043 and tty_alt_charset_p cases.
3044 (tty_capable_p, init_tty): Support italics.
3045
3046 * termchar.h (struct tty_display_info): Add field for italics.
3047 Remove unused blink field.
3048
3049 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3050 Handle slant.
3051
3052 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3053 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3054 tty_alt_charset_p. Add tty_italic_p.
3055
ff88beb8
MA
30562012-06-09 Michael Albinus <michael.albinus@gmx.de>
3057
3058 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3059 dbus_type_is_basic if available.
3060 (xd_extract_signed, xd_extract_unsigned): Rename from
3061 extract_signed and extract_unsigned, respectively. Adapt callers.
3062
44286096
CY
30632012-06-09 Chong Yidong <cyd@gnu.org>
3064
1682701f
CY
3065 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3066
44286096
CY
3067 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3068 case (Bug#9752).
3069
d86feb17
PE
30702012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3071
3072 * xdisp.c (vmessage): Treat frame message as multibyte.
3073 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3074 would generate the diagnostic "Making \302\247 buffer-local while
3075 let-bound!".
3076
d5c20fe8
EZ
30772012-06-08 Eli Zaretskii <eliz@gnu.org>
3078
3079 * dispnew.c (showing_window_margins_p): Undo last change, which
3080 was done due to an inadvertent commit.
3081 (adjust_frame_glyphs_for_frame_redisplay): Do call
3082 showing_window_margins_p.
3083
513749ee
SM
30842012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3085
3086 * eval.c (Fmake_var_non_special): New primitive.
3087 (syms_of_eval): Defsubr it.
3088 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3089
d4a8f5c1
JB
30902012-06-08 Juanma Barranquero <lekktu@gmail.com>
3091
3092 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3093 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3094
8bbbc977
EZ
30952012-06-08 Eli Zaretskii <eliz@gnu.org>
3096
3097 * alloc.c (allocate_vectorlike): Fix last change.
3098
f3372c87
DA
30992012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3100
3101 Block-based vector allocation of small vectors.
3102 * lisp.h (struct vectorlike_header): New field `nbytes',
3103 adjust comment accordingly.
3104 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3105 to denote vector blocks. Adjust users (live_vector_p,
3106 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3107 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3108 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3109 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3110 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3111 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3112 (roundup_size): New constant.
3113 (struct vector_block): New data type.
3114 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3115 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3116 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3117 (sweep_vectors): New functions.
3118 (allocate_vectorlike): Return `zero_vector' as the only vector of
3119 0 items. Allocate new vector from block if vector size is less than
3120 or equal to VBLOCK_BYTES_MAX.
3121 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3122 (init_alloc_once): Add call to init_vectors.
3123
4f18a4ed
SM
31242012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3125
3126 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3127
86f158bc
PE
31282012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3129
3130 * doprnt.c (doprnt): Truncate multibyte char correctly.
3131 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3132 would mishandle a string argument "Xc" if X was a multibyte
3133 character of length 2: it would truncate after X's first byte
3134 rather than including all of X.
3135
c5cfcbe0
CY
31362012-06-06 Chong Yidong <cyd@gnu.org>
3137
3138 * buffer.c (word_wrap): Doc fix.
3139
c05cf390
PE
31402012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3141
3142 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3143
0c3461de
GM
31442012-06-03 Glenn Morris <rgm@gnu.org>
3145
3146 * xdisp.c (tool-bar-style): Doc fix.
3147
c71232db
UM
31482012-06-03 Ulrich Müller <ulm@gentoo.org>
3149
3150 * Makefile.in (PAXCTL): Define.
3151 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3152 binary via PaX flags if the paxctl utility is available.
3153 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3154 Restore PaX flags to their default. (Bug#11398)
3155
383f7350
CY
31562012-06-03 Chong Yidong <cyd@gnu.org>
3157
3158 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3159 buffer (Bug#11226).
3160
5f2c76c6
CY
31612012-06-03 Chong Yidong <cyd@gnu.org>
3162
3163 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3164 (note_mode_line_or_margin_highlight): If there is no help echo,
3165 use mode-line-default-help-echo. Handle the case where the mouse
3166 position is past the end of the mode line string.
3167
3168 * buffer.c (buffer_local_value_1): New function, split from
3169 Fbuffer_local_value; can return Qunbound.
3170 (Fbuffer_local_value): Use it.
3171 (Vmode_line_format): Docstring tweaks.
3172
773d47f6
PE
31732012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3174
3175 * sysdep.c (system_process_attributes): Improve comment.
3176
f2d6a3df
SM
31772012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3178
3179 * keyboard.c: Export real-this-command to Elisp.
3180 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3181 and DEFVAR it. Update all users.
3182
63810350
PE
31832012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3184
7bd5c1f4
PE
3185 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3186
63810350
PE
3187 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3188 Convert pctcpu and pctmem to Lisp float properly.
3189 Let the compiler fold better, as 100.0/0x8000 is exact.
3190
a2821611
AS
31912012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3192
3193 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3194 cons_block.
3195
5fceba1d
PE
31962012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3197
3198 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3199
c98ff5dd
DA
32002012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3201
3202 For a 'struct window', replace some Lisp_Object fields to
3203 bitfields where appropriate, remove unused fields.
3204 * window.h (struct window): Remove unused 'last_mark_x' and
3205 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3206 change it's type from Lisp_Object to bitfield.
3207 Change type of 'force_start', 'optional_new_start',
3208 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3209 fields from Lisp_Object to bitfield. Adjust users accordingly.
3210
ca34e0be
PE
32112012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3212
3213 Pacify gcc -Wdouble-precision when using Xaw.
3214 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3215 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3216 Use 'float' consistently, rather than 'float' in most places
3217 and 'double' in a couple of places.
3218
efc00ab1 32192012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3220
3221 * xdisp.c (handle_stop): Detect whether we have overlay strings
3222 loaded by testing it->current.overlay_string_index to be
3223 non-negative, instead of checking whether n_overlay_strings is
3224 positive. (Bug#11587)
3225
efc00ab1 32262012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3227
3228 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3229
3230 * doc.c (Fsubstitute_command_keys): Doc fix.
3231
efc00ab1 32322012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3233
3234 * search.c (search_buffer): Remove calls to
3235 r_alloc_inhibit_buffer_relocation, as it is now called by
3236 maybe_unify_char, which was the cause of relocation of buffer text
3237 in bug#11519.
3238
efc00ab1 32392012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3240
3241 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3242 for the duration of call to load_charset, to avoid problems with
3243 callers of maybe_unify_char that access buffer text through C
3244 pointers.
3245
3246 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3247 decrement the inhibition flag, instead of just setting or
3248 resetting it.
3249
ba93a187
PE
32502012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3251
3252 Remove obsolete '#define static' cruft.
3253 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3254 This #undef was "temporary" in 2000; it is no longer needed
3255 now that '#define static' has gone away.
3256 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3257 (gray_bitmap_bits): Remove; no longer needed.
3258 All uses replaced with definiens.
3259 * xterm.c: Include "bitmaps/gray.xbm".
3260
9e4bf381
PE
32612012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3262
3263 Clean up __executable_start, monstartup when --enable-profiling.
3264 The following changes affect the code only when profiling.
3265 * dispnew.c (__executable_start): Rename from safe_bcopy.
3266 Define only on platforms that need it.
3267 * emacs.c: Include <sys/gmon.h> when profiling.
3268 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3269 (__executable_start): Remove decl, since lisp.h does it now.
3270 (safe_bcopy): Remove decl; no longer has that name.
3271 (main): Coalesce #if into single bit of code, for simplicity.
3272 Cast pointers to uintptr_t, since standard libraries want integers
3273 and not pointers.
3274 * lisp.h (__executable_start): New decl.
3275
32d72c2f
GM
32762012-05-31 Glenn Morris <rgm@gnu.org>
3277
3278 * image.c (Fimagemagick_types): Doc fix.
3279
baac5bc7
JM
32802012-05-30 Jim Meyering <meyering@redhat.com>
3281
3282 * callproc.c (Fcall_process_region): Include directory component
3283 in mkstemp error message (Bug#11586).
3284
72cb32cf
PE
32852012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3286
3287 * alloc.c, lisp.h (make_pure_vector): Now static.
3288
61b108cc
SM
32892012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3290
3291 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3292 Move to byte-run.el.
3293 (Fautoload): Do the hash-doc more carefully.
3294 * data.c (Fdefalias): Purify definition, except for keymaps.
3295 (Qdefun): Move from eval.c.
3296 * lisp.h (Qdefun): Remove.
3297 * lread.c (read1): Tiny simplification.
3298
471fe23d
TN
32992012-05-29 Troels Nielsen <bn.troels@gmail.com>
3300
934f3f58 3301 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3302 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3303 Bug#9642, but explicitly check that the buffer the overlay would
3304 be moved to is live and rearrange lines to make sure that errors
3305 will not put the overlay in an inconsistent state.
3306 (Fdelete_overlay): Cosmetics.
3307
85d0efd1
EZ
33082012-05-28 Eli Zaretskii <eliz@gnu.org>
3309
3310 * w32term.c (my_bring_window_to_top): New function.
3311 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3312 could be different from the original one.
3313 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3314 (Bug#11513)
3315
3316 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3317 by calling BringWindowToTop.
3318
3319 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3320 (WM_EMACS_END): Increase by one.
3321
da92a98c
PE
33222012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3323
3324 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3325 This avoids undefined behavior that might cause the eassert
3326 to not catch an out-of-range value.
3327
74d1f848
JB
33282012-05-28 Juanma Barranquero <lekktu@gmail.com>
3329
3330 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3331 Update dependencies.
3332
9e1a06fc
EZ
33332012-05-27 Eli Zaretskii <eliz@gnu.org>
3334
3335 * bidi.c (bidi_mirror_char): Fix last change.
3336
f3dd7312
AS
33372012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3338
3339 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3340 when referring to sectname field in printf format.
3341
81899c91
PE
33422012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3343
57b81a9f
PE
3344 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3345 Only r_alloc_inhibit_buffer_relocation needed to be added;
3346 the others were already declared.
3347
81899c91
PE
3348 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3349 before checking whether it's out of range. Put the check inside
3350 eassert. See
3351 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3352
33017faf 33532012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3354
3355 * callproc.c (Fcall_process): Restore a line that was accidentally
3356 commented out in the 2011-02-13 change (bug#11547).
3357
33017faf 33582012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3359
3360 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3361 defined on ralloc.c.
3362
3363 * buffer.c [REL_ALLOC]: Remove prototypes of
3364 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3365 they are now on lisp.h.
3366
3367 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3368
3369 * search.c (search_buffer): Use it to inhibit relocation of buffer
3370 text while re_search_2 is doing its job, because re_search_2 is
3371 passed C pointers to buffer text. (Bug#11519)
3372
23415acf
EZ
3373 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3374 Update value to 24.
3375
44e27368
EZ
3376 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3377 state after an additional call to move_it_in_display_line_to, keep
3378 the values of it->max_ascent and it->max_descent found for the
3379 entire line.
3380 (pos_visible_p): Revert the comparison against bottom_y to what it
3381 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3382 (Bug#11464)
3383
c1892f11
PE
33842012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3385
3386 Fix coding-related core dumps with gcc -ftrapv.
3387 The code was computing A - B, where A and B are pointers, and B is
3388 random garbage. This can lead to core dumps on platforms that
3389 have special pointer registers, and it also leads to core dumps on
3390 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3391 A - B only when B is initialized properly.
3392 * coding.c (coding_set_source, coding_set_destination): Return void.
3393 (coding_change_source, coding_change_destinations): New functions,
3394 with the old behaviors of coding_set_source and coding_set_destination.
3395 All callers that need an offset changed to use these new functions.
3396
eb7afdad
GM
33972012-05-26 Glenn Morris <rgm@gnu.org>
3398
3399 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3400
f12fdf02
EZ
34012012-05-26 Eli Zaretskii <eliz@gnu.org>
3402
53a63be6 3403 Extend mouse support on W32 text-mode console.
61b108cc
SM
3404 * xdisp.c (draw_row_with_mouse_face):
3405 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3406
eb3f6f01 3407 * w32console.c: Include window.h.
61b108cc
SM
3408 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3409 New functions.
eb3f6f01
EZ
3410 (initialize_w32_display): Initialize mouse-highlight data.
3411
53a63be6
EZ
3412 * w32inevt.c: Include termchar.h and window.h.
3413 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3414 moves, call note_mouse_highlight. If help_echo changed, call
3415 gen_help_event to produce help-echo message in the echo area.
3416 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3417 highlight info.
3418
4cfd81f6
PE
34192012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3420
3421 * lread.c (read1): Simplify slightly to avoid an overflow warning
3422 with GCC 4.7.0 on x86-64.
3423
4446092a
EZ
34242012-05-26 Eli Zaretskii <eliz@gnu.org>
3425
3426 * bidi.c (bidi_mirror_char): Revert last change: an int is
3427 definitely wide enough here.
3428
42b2a986 34292012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3430
42b2a986 3431 Fix integer width and related bugs (Bug#9874).
eb106a49 3432 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3433 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3434 (string_bytes, check_sblock, allocate_string_data):
3435 (compact_small_strings, Fmake_bool_vector, make_string)
3436 (make_unibyte_string, make_multibyte_string)
3437 (make_string_from_bytes, make_specified_string)
3438 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3439 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3440 (mark_vectorlike):
3441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3442 (allocate_pseudovector):
3443 Use int, not EMACS_INT, where int is wide enough.
3444 (inhibit_garbage_collection, Fgarbage_collect):
3445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3446 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3447 int might not be wide enough.
3448 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3449 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3450 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3451 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3452 (bidi_level_of_next_char, bidi_move_to_visually_next):
3453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3454 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3455 (Fkill_buffer, Fset_buffer_major_mode)
3456 (advance_to_char_boundary, Fbuffer_swap_text)
3457 (Fset_buffer_multibyte, overlays_at, overlays_in)
3458 (overlay_touches_p, struct sortvec, record_overlay_string)
3459 (overlay_strings, recenter_overlay_lists)
3460 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3461 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3462 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3463 (Foverlay_recenter, last_overlay_modification_hooks_used)
3464 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3466 (validate_region): Omit unnecessary test for b <= e,
3467 since that's guaranteed by the previous test.
d311d28c
PE
3468 (adjust_overlays_for_delete): Avoid pos + length overflow.
3469 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3470 (report_overlay_modification):
3471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3472 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3473 Omit pointer cast, which isn't needed anyway, and doesn't work
3474 after the EMACS_INT -> ptrdiff_t change.
02481186 3475 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3476 * buffer.h: Adjust decls to match defn changes elsewhere.
3477 (struct buffer_text, struct buffer):
3478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3479 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3480 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3481 not int, to avoid needless 32-bit limit on 64-bit hosts.
3482 (exec_byte_code): Use tighter memory-full test, one that checks
3483 for alloca overflow. Don't compute the address of the object just
3484 before an array, as that's not portable. Use EMACS_INT, not
3485 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3486 * callint.c (Fcall_interactively):
3487 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3488 * callproc.c (call_process_kill, Fcall_process):
3489 Don't assume pid_t fits into an Emacs fixnum.
3490 (call_process_cleanup, Fcall_process, child_setup):
3491 Don't assume pid_t fits into int.
3492 (call_process_cleanup, Fcall_process, delete_temp_file)
3493 (Fcall_process_region):
3494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3495 (Fcall_process): Simplify handling of volatile integers.
3496 Use int, not EMACS_INT, where int will do.
3497 * casefiddle.c (casify_object, casify_region, operate_on_word)
3498 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3500 (casify_object): Avoid integer overflow when overallocating buffer.
3501 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3502 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3503 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3504 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3505 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3506 integers are now checked earlier. All uses replaced with XINT.
3507 (ccl_driver):
3508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3509 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3510 (ccl_driver, Fregister_code_conversion_map):
3511 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3512 (resolve_symbol_ccl_program): Check that vector header is in range.
3513 Always copy the vector, so that we can check its contents reliably
3514 now rather than having to recheck each instruction as it's being
3515 executed. Check that vector words fit in 'int'.
3516 (ccl_get_compiled_code, Fregister_ccl_program)
3517 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3518 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3519 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3520 contents are in range.
3521 (Fccl_execute_on_string): Check that status is in range.
3522 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3523 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3524 Accept and return EMACS_INT, not int, because callers can pass values
3525 out of 'int' range.
3526 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3527 (multibyte_chars_in_text, parse_str_as_multibyte)
3528 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3529 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3530 (string_escape_byte8, Fget_byte):
3531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3532 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3533 avoid mishandling large integers.
3534 * character.h: Adjust decls to match defn changes elsewhere.
3535 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3536 (Ffind_charset_region):
3537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3538 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3539 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3540 Don't assume fixnum fits in int.
d311d28c
PE
3541 (load_charset_map_from_vector, Fmap_charset_chars):
3542 Remove now-unnecessary CHECK_NATNUMs.
3543 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3544 Don't rely on undefined behavior with signed left shift overflow.
3545 Don't assume unsigned int fits into fixnum, or that fixnum fits
3546 into unsigned int. Don't require max_code to be a valid fixnum;
3547 that's not true for gb10830 4-byte on a 32-bit host. Allow
3548 invalid_code to be a cons, for the same reason. Require code_offset
3549 to be a character. Avoid int overflow if max_char is close
3550 to INT_MAX.
3551 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3552 this is intended anyway and avoids some undefined behavior.
3553 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3554 INDEX_TO_CODE_POINT, as that's what it expects.
3555 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3556 * charset.h (DECODE_CHAR): Return int, not unsigned;
3557 this is what was intended anyway, and it avoids undefined behavior.
3558 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3559 integer-overflow issues.
3560 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3561 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3562 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3563 * chartab.c (Fmake_char_table, Fset_char_table_range)
3564 (uniprop_get_decoder, uniprop_get_encoder):
3565 Don't assume fixnum fits in int.
3566 * cmds.c (move_point): New function, that does the gist of
3567 Fforward_char and Fbackward_char, but does so while checking
3568 for integer overflow more accurately.
c96e5d6a 3569 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3570 (Fforward_line, Fend_of_line, internal_self_insert)
3571 (internal_self_insert):
3572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3573 Fix a FIXME, by checking for integer overflow when calculating
3574 target_clm and actual_clm.
3575 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3576 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3577 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3578 (coding_alloc_by_making_gap, alloc_destination)
3579 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3580 (encode_coding_utf_16, detect_coding_emacs_mule)
3581 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3582 (detect_coding_iso_2022, decode_coding_iso_2022)
3583 (encode_invocation_designation, encode_designation_at_bol)
3584 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3585 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3586 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3587 (encode_coding_ccl, encode_coding_raw_text)
3588 (detect_coding_charset, decode_coding_charset)
3589 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3590 (produce_composition, produce_charset, produce_annotation)
3591 (decode_coding, handle_composition_annotation)
3592 (handle_charset_annotation, consume_chars, decode_coding_gap)
3593 (decode_coding_object, encode_coding_object, detect_coding_system)
3594 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3595 (code_convert_region, code_convert_string)
8f50130c
PE
3596 (Fdefine_coding_system_internal)
3597 (coding_set_source, coding_set_destination):
d311d28c
PE
3598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3599 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3600 (Fdefine_coding_system_internal):
3601 Don't assume fixnums fit in int.
3602 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3603 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3604 (Funencodable_char_position, Fcheck_coding_systems_region)
3605 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3607 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3608 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3609 Don't access memory outside of the args array.
d311d28c 3610 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3611 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3612 result of ENCODE_CHAR.
d311d28c
PE
3613 * coding.h: Adjust decls to match defn changes elsewhere.
3614 (struct coding_system):
3615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3616 * composite.c (get_composition_id, find_composition)
3617 (run_composition_function, update_compositions)
3618 (compose_text, composition_gstring_put_cache)
3619 (composition_gstring_p, composition_gstring_width)
3620 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3621 (composition_compute_stop_pos, composition_reseat_it)
3622 (composition_update_it, struct position_record)
3623 (find_automatic_composition, composition_adjust_point)
3624 (Fcomposition_get_gstring, Ffind_composition_internal):
3625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3626 (update_compositions):
3627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3628 * composite.h: Adjust decls to match defn changes elsewhere.
3629 (struct composition):
3630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3631 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3632 Do not attempt to compute the address of the object just before a
3633 buffer; this is not portable.
3634 (Faref, Faset):
3635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3636 (Faset): Use int, not EMACS_INT, where int is wide enough.
3637 (Fstring_to_number): Don't assume fixnums fit in int.
3638 (Frem): Don't assume arg is nonnegative.
3639 * dbusbind.c (xd_append_arg): Check for integers out of range.
3640 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3641 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3642 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3643 (xd_get_connection_references): Return ptrdiff_t, not int.
3644 All uses changed.
3645 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3646 (xd_read_message_1):
3647 Use int, not unsigned, where the dbus API uses int.
3648 (Fdbus_message_internal): Don't overflow mtype.
3649 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3650 * dired.c (directory_files_internal, file_name_completion, scmp)
3651 (file_name_completion_stat):
3652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3653 (file_name_completion): Don't overflow matchcount.
3654 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3655 * dispextern.h: Adjust decls to match defn changes elsewhere.
3656 (struct text_pos, struct glyph, struct bidi_saved_info)
3657 (struct bidi_string_data, struct bidi_it, struct composition_it)
3658 (struct it):
3659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3660 (struct display_pos, struct composition_it, struct it):
3661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3662 * dispnew.c (increment_matrix_positions)
3663 (increment_row_positions, mode_line_string)
3664 (marginal_area_string):
3665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3666 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3668 (duration_to_sec_usec): New function, to check for overflow better.
3669 (Fsleep_for, sit_for): Use it.
3670 * doc.c (get_doc_string, store_function_docstring):
3671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3672 (get_doc_string, Fsnarf_documentation):
3673 Use int, not EMACS_INT, where int is wide enough.
3674 (get_doc_string):
3675 Use SAFE_ALLOCA, not alloca.
3676 Check for overflow when converting EMACS_INT to off_t.
3677 * doprnt.c (doprnt):
3678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3679 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3680 Don't assume uid_t fits into fixnum.
3681 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3682 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3683 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3684 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3685 (general_insert_function)
3686 (Finsert_char, make_buffer_string, make_buffer_string_both)
3687 (update_buffer_properties, Fbuffer_substring)
3688 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3689 (Fsubst_char_in_region, check_translation)
3690 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3691 (transpose_markers, Ftranspose_regions):
3692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3693 (clip_to_bounds): Move to lisp.h as an inline function).
3694 (Fconstrain_to_field): Don't assume integers are nonnegative.
3695 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3696 (Fsubst_char_in_region, Fsave_restriction):
3697 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3698 (Femacs_pid): Don't assume pid_t fits into fixnum.
3699 (lo_time): Use int, not EMACS_INT, when int suffices.
3700 (lisp_time_argument): Check for usec out of range.
3701 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3702 (Fuser_login_name, Fuser_full_name): Signal an error
3703 if a uid argument is out of range, rather than relying on
3704 undefined behavior.
c8d5c857
PE
3705 (Fformat_time_string): Remove now-unnecessary check.
3706 lisp_time_argument checks for out-of-range usec now.
243e0530 3707 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3708 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3709 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3710 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3711 (init_cmdargs, Fdump_emacs):
3712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3713 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3714 the bottom (typically) 32 bits of the fixnum.
3715 * eval.c (specpdl_size, call_debugger):
3716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3717 (when_entered_debugger, Fbacktrace_debug):
3718 Don't assume fixnum can fit in int.
3719 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3720 the object just before a buffer; this is not portable.
3721 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3722 (grow_specpdl, unbind_to):
3723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3724 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3725 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3726 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3727 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3728 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3730 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3731 (a_write, e_write):
3732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3733 (Fcopy_file, non_regular_nbytes, read_non_regular)
3734 (Finsert_file_contents):
3735 Use int, not EMACS_INT, where int is wide enough.
3736 (READ_BUF_SIZE): Verify that it fits in int.
3737 (Finsert_file_contents): Check that counts are in proper range,
3738 rather than assuming fixnums fit into ptrdiff_t etc.
3739 Don't assume fixnums fit into int.
125b3835 3740 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3741 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3742 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3743 (string_char_to_byte, string_byte_to_char)
3744 (string_make_multibyte, string_to_multibyte)
3745 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3746 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3747 (substring_both, Fdelete, internal_equal, Ffillarray)
3748 (Fclear_string, mapcar1)
3749 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3750 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3751 (larger_vector, make_hash_table, maybe_resize_hash_table)
3752 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3753 (Fmaphash, secure_hash):
3754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3755 (concat): Check for string index and length overflow.
3756 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3757 (Frequire):
3758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3759 (larger_vector): New API (vec, incr_min, size_max) replaces old
3760 one (vec, new_size, init). This catches size overflow.
3761 INIT was removed because it was always Qnil.
3762 All callers changed.
3763 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3764 the upper bound on a hash table index size.
3765 (make_hash_table, maybe_resize_hash_table): Use it.
3766 (secure_hash): Computer start_byte and end_byte only after
3767 they're known to be in ptrdiff_t range.
3768 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3769 (Ffont_get_glyphs, Ffont_at):
3770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3771 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3772 (Flist_fonts, Fopen_font):
3773 Don't assume fixnum can fit in int.
3774 (check_gstring): Don't assume index can fit in int.
3775 (font_match_p): Check that fixnum is a character, not a nonnegative
3776 fixnum, since the later code needs to stuff it into an int.
3777 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3778 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3779 conversion overflow issues.
3780 (Fopen_font): Check for integer out of range.
3781 (Ffont_get_glyphs): Don't assume index can fit in int.
3782 * font.h: Adjust decls to match defn changes elsewhere.
3783 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3784 integer overflow.
3785 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3786 printmax_t, where ptrdiff_t is wide enough.
3787 (Finternal_char_font):
3788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3789 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3790 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3791 (Fset_frame_position, x_set_frame_parameters)
3792 (x_set_line_spacing, x_set_border_width)
3793 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3794 Check that fixnums are in proper range for system types.
3795 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3796 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3797 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3798 Use SAFE_ALLOCA_LISP, not alloca.
3799 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3800 intptr_t is wide enough.
3801 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3802 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3803 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3804 Check for fixnum out of range.
3805 * ftfont.c (ftfont_list): Don't assume index fits in int.
3806 Check that fixnums are in proper range for system types.
3807 (ftfont_shape_by_flt):
3808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3809 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3811 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3812 Check that fixnums are in proper range for system types.
3813 * gnutls.h: Adjust decls to match defn changes elsewhere.
3814 * gtkutil.c (xg_dialog_run):
3815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3816 (update_frame_tool_bar):
3817 Check that fixnums are in proper range for system types.
3818 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3819 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3820 * indent.c (last_known_column, last_known_column_point):
3821 (current_column_bol_cache):
3822 (skip_invisible, current_column, check_display_width):
3823 (check_display_width, scan_for_column, current_column_1)
3824 (Findent_to, Fcurrent_indentation, position_indentation)
3825 (indented_beyond_p, Fmove_to_column, compute_motion):
3826 (Fcompute_motion, Fvertical_motion):
3827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3828 (last_known_column_modified): Use EMACS_INT, not int.
3829 (check_display_width):
3830 (Fcompute_motion):
3831 Check that fixnums and floats are in proper range for system types.
3832 (compute_motion): Don't assume index or fixnum fits in int.
3833 (compute_motion, Fcompute_motion):
3834 Use int, not EMACS_INT, when it is wide enough.
3835 (vmotion): Omit local var start_hpos that is always 0; that way
3836 we don't need to worry about overflow in expressions involving it.
3837 * indent.h: Adjust decls to match defn changes elsewhere.
3838 (struct position):
3839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3840 Use int, not EMACS_INT, where int is wide enough.
3841 Remove unused members ovstring_chars_done and tab_offset;
3842 all uses removed.
3843 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3844 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3845 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3846 (make_gap, copy_text, insert, insert_and_inherit)
3847 (insert_before_markers, insert_before_markers_and_inherit)
3848 (insert_1, count_combining_before, count_combining_after)
3849 (insert_1_both, insert_from_string)
3850 (insert_from_string_before_markers, insert_from_string_1)
3851 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3852 (adjust_after_replace, adjust_after_insert, replace_range)
3853 (replace_range_2, del_range, del_range_1, del_range_byte)
3854 (del_range_both, del_range_2, modify_region)
3855 (prepare_to_modify_buffer, signal_before_change)
3856 (signal_after_change, Fcombine_after_change_execute):
3857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3858 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3859 (balance_an_interval, split_interval_right, split_interval_left)
3860 (find_interval, next_interval, update_interval)
3861 (adjust_intervals_for_insertion, delete_node, delete_interval)
3862 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3863 (static_offset_intervals, offset_intervals)
3864 (merge_interval_right, merge_interval_left, make_new_interval)
3865 (graft_intervals_into_buffer, temp_set_point_both)
3866 (temp_set_point, set_point, adjust_for_invis_intang)
3867 (set_point_both, move_if_not_intangible, get_property_and_range)
3868 (get_local_map, copy_intervals, copy_intervals_to_string)
3869 (compare_string_intervals, set_intervals_multibyte_1):
3870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3871 * intervals.h: Adjust decls to match defn changes elsewhere.
3872 (struct interval):
3873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3874 * keyboard.c (this_command_key_count, this_single_command_key_start)
3875 (before_command_key_count, before_command_echo_length, echo_now)
3876 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3877 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3878 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3879 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3881 (last_non_minibuf_size, last_point_position, echo_truncate)
3882 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3883 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3884 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3885 (stuff_buffered_input):
3886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3887 (last_auto_save, command_loop_1, read_char):
3888 Use EMACS_INT, not int, to avoid integer overflow.
3889 (record_char): Avoid overflow in total_keys computation.
3890 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3891 * keyboard.h: Adjust decls to match defn changes elsewhere.
3892 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3893 (Fkey_description, Fdescribe_vector, Flookup_key):
3894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3895 (click_position): New function, to check that positions are in range.
3896 (Fcurrent_active_maps):
3897 (describe_command):
3898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3899 (Faccessible_keymaps, Fkey_description):
3900 (preferred_sequence_p):
3901 Don't assume fixnum can fit into int.
3902 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3903 Check for integer overflow in size calculations.
3904 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3905 avoid mishandling large integers.
3906 * lisp.h: Adjust decls to match defn changes elsewhere.
3907 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3908 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3909 (struct Lisp_Marker):
3910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3911 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3912 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3913 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3914 All callers changed.
3915 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3916 Assume the arg has valid form, since it always does.
3917 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3918 unsigned integer system type.
3919 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3920 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3922 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3923 (duration_to_sec_usec): New decl.
3924 * lread.c (read_from_string_index, read_from_string_index_byte)
3925 (read_from_string_limit, readchar, unreadchar, openp)
3926 (read_internal_start, read1, oblookup):
3927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3928 (Fload, readevalloop, Feval_buffer, Feval_region):
3929 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3930 (openp): Check for out-of-range argument to 'access'.
3931 (read1): Use int, not EMACS_INT, where int is wide enough.
3932 Don't assume fixnum fits into int.
6efdadfd 3933 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3934 (read_filtered_event): Use duration_to_sec_usec
3935 to do proper overflow checking on durations.
d311d28c
PE
3936 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3937 in size calculation.
3938 (Fexecute_kbd_macro):
3939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3940 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3941 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3942 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3943 (set_marker_both, set_marker_restricted_both, marker_position)
3944 (marker_byte_position, Fbuffer_has_markers_at):
3945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3946 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3947 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3948 It now merely ensures that the menu is large enough, without
3949 necessarily growing it, as this avoids some integer overflow issues.
3950 All callers changed.
3951 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3952 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3953 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3954 Use SAFE_ALLOCA_LISP, not alloca.
3955 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3956 to EMACS_INT. Check that fixnums are in proper range for system types.
3957 * minibuf.c (minibuf_prompt_width, string_to_object)
3958 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3959 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3961 (get_minibuffer, read_minibuf_unwind):
3962 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3963 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3964 this simplifies overflow checking. All callers changed.
3965 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3966 (Ftest_completion):
3967 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3968 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3969 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3970 Check that fixnums are in proper range for system types.
3971 (Fx_create_frame, Fx_show_tip):
3972 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3973 * nsfont.m (ns_findfonts, nsfont_list_family):
3974 Don't assume fixnum fits in long.
3975 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3977 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3978 wide enough.
17fdb222 3979 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3981 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3982 (PRINTDECLARE, PRINTPREPARE):
3983 (strout, print_string):
3984 (print, print_preprocess, print_check_string_charset_prop)
3985 (print_object):
3986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3987 (PRINTDECLARE):
3988 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3990 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3991 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3992 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3993 (print_error_message): Use SAFE_ALLOCA, not alloca.
3994 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3995 (print_depth, new_backquote_output, print_number_index):
3996 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3997 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3998 (Fset_process_window_size, Fformat_network_address)
3999 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4000 (sigchld_handler):
d311d28c 4001 Check that fixnums are in proper range for system types.
d44287d4 4002 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4003 Check for process-ids out of pid_t range rather than relying on
4004 undefined behavior.
e4d81efc 4005 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4006 (Fformat_network_address, read_process_output, send_process)
4007 (Fprocess_send_region, status_notify):
4008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4009 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4010 (wait_reading_process_output, read_process_output, exec_sentinel):
4011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4012 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4013 (Faccept_process_output): Use duration_to_sec_usec to do proper
4014 overflow checking on durations.
dde14581
PE
4015 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4016 Don't assume pid_t fits in int.
02481186
PE
4017 * process.h (struct Lisp_Process): Members tick and update_tick
4018 are now of type EMACS_INT, not int.
b62b53e8
PE
4019 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4020 configured --with-wide-int.
d311d28c
PE
4021 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4022 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4023 * search.c (looking_at_1, string_match_1):
4024 (fast_string_match, fast_c_string_match_ignore_case)
4025 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4026 (scan_newline, find_before_next_newline, search_command)
4027 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4028 (set_search_regs, wordify):
4029 (Freplace_match):
4030 (Fmatch_data):
4031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4032 (string_match_1, search_buffer, set_search_regs):
4033 (Fmatch_data):
4034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4035 (wordify): Check for overflow in size calculation.
4036 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4037 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4038 Check that fixnums are in proper range for system types.
4039 * sound.c (struct sound_device)
4040 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4041 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4042 (Fplay_sound_internal):
4043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4044 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4045 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4046 (Fparse_partial_sexp):
4047 Don't assume fixnums can fit in int.
4048 (struct lisp_parse_state, find_start_pos, find_start_value)
4049 (find_start_value_byte, find_start_begv)
4050 (update_syntax_table, char_quoted, dec_bytepos)
4051 (find_defun_start, prev_char_comend_first, back_comment):
4052 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4053 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4054 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4055 (Finternal_describe_syntax_value): Check that match_lisp is a
4056 character, not an integer, since the code stuffs it into int.
4057 (scan_words, scan_sexps_forward):
4058 Check that fixnums are in proper range for system types.
4059 (Fforward_word):
4060 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4061 (scan_sexps_forward):
4062 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4063 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4064 * syntax.h: Adjust decls to match defn changes elsewhere.
4065 (struct gl_state_s):
4066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4067 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4068 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4069 * sysdep.c (wait_for_termination_1, wait_for_termination)
4070 (interruptible_wait_for_termination, mkdir):
4071 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4072 (emacs_read, emacs_write):
4073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4074 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4075 and double all fit in int.
d311d28c
PE
4076 * term.c (set_tty_color_mode):
4077 Check that fixnums are in proper range for system types.
4078 * termhooks.h (struct input_event):
4079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4080 * textprop.c (validate_interval_range, interval_of)
4081 (Fadd_text_properties, set_text_properties_1)
4082 (Fremove_text_properties, Fremove_list_of_text_properties)
4083 (Ftext_property_any, Ftext_property_not_all)
4084 (copy_text_properties, text_property_list, extend_property_ranges)
4085 (verify_interval_modification):
4086 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4087 (Fnext_single_char_property_change)
4088 (Fprevious_single_char_property_change):
4089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4090 (copy_text_properties):
4091 Check for integer overflow in index calculation.
d311d28c
PE
4092 * undo.c (last_boundary_position, record_point, record_insert)
4093 (record_delete, record_marker_adjustment, record_change)
4094 (record_property_change):
4095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4096 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4098 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4099 (Fx_hide_tip, Fx_file_dialog):
4100 * w32menu.c (set_frame_menubar):
4101 Use ptrdiff_t, not int, for consistency with rest of code.
4102 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4103 (select_window, Fdelete_other_windows_internal)
4104 (window_scroll_pixel_based, window_scroll_line_based)
4105 (Frecenter, Fset_window_configuration):
4106 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4107 (Fset_window_hscroll, run_window_configuration_change_hook)
4108 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4109 (Fscroll_other_window, Frecenter):
d311d28c
PE
4110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4111 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4112 Don't assume fixnum fits in int.
4113 (Fset_window_scroll_bars):
4114 Check that fixnums are in proper range for system types.
4115 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4116 (string_pos, c_string_pos, number_of_chars, init_iterator)
4117 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4118 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4119 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4120 (face_before_or_after_it_pos, handle_invisible_prop)
4121 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4122 (display_prop_intangible_p, string_buffer_position_lim)
4123 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4124 (get_overlay_strings_1, get_overlay_strings)
4125 (iterate_out_of_display_property, forward_to_next_line_start)
4126 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4127 (get_next_display_element, set_iterator_to_next)
4128 (get_visually_first_element, compute_stop_pos_backwards)
4129 (handle_stop_backwards, next_element_from_buffer)
4130 (move_it_in_display_line_to, move_it_in_display_line)
4131 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4132 (add_to_log, message_dolog, message_log_check_duplicate)
4133 (message2, message2_nolog, message3, message3_nolog
4134 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4135 (current_message_1, truncate_echo_area, truncate_message_1)
4136 (set_message, set_message_1, store_mode_line_noprop)
4137 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4138 (text_outside_line_unchanged_p, check_point_in_composition)
4139 (reconsider_clip_changes)
4140 (redisplay_internal, set_cursor_from_row, try_scrolling)
4141 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4142 (redisplay_window, find_last_unchanged_at_beg_row)
4143 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4144 (trailing_whitespace_p, find_row_edges, display_line)
4145 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4146 (display_mode_element, store_mode_line_string)
4147 (pint2str, pint2hrstr, decode_mode_spec)
4148 (display_count_lines, display_string, draw_glyphs)
4149 (x_produce_glyphs, x_insert_glyphs)
4150 (rows_from_pos_range, mouse_face_from_buffer_pos)
4151 (fast_find_string_pos, mouse_face_from_string_pos)
4152 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4153 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4154 (safe_call, init_from_display_pos, handle_fontified_prop)
4155 (handle_single_display_spec, load_overlay_strings)
4156 (with_echo_area_buffer, setup_echo_area_for_printing)
4157 (display_echo_area, echo_area_display)
4158 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4159 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4160 (redisplay_window, dump_glyph_row, display_mode_line)
4161 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4162 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4164 (handle_single_display_spec, build_desired_tool_bar_string)
4165 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4166 (get_specified_cursor_type):
4167 Check that fixnums are in proper range for system types.
4168 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4169 (Flookup_image_map):
4170 Don't assume fixnums fit in int.
4171 (compare_overlay_entries):
4172 Avoid mishandling comparisons due to subtraction overflow.
4173 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4174 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4175 (handle_tool_bar_click):
4176 Use int, not unsigned, since we prefer signed and the signedness
4177 doesn't matter here.
4178 (get_next_display_element, next_element_from_display_vector):
4179 Use int, not EMACS_INT, when int is wide enough.
4180 (start_hourglass): Use duration_to_sec_usec to do proper
4181 overflow checking on durations.
4182 * xfaces.c (Fbitmap_spec_p):
4183 Check that fixnums are in proper range for system types.
4184 (compare_fonts_by_sort_order):
4185 Avoid mishandling comparisons due to subtraction overflow.
4186 (Fx_family_fonts, realize_basic_faces):
4187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4188 (Fx_family_fonts):
4189 Don't assume fixnum fits in int.
4190 Use SAFE_ALLOCA_LISP, not alloca.
4191 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4192 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4193 (face_at_buffer_position, face_for_overlay_string)
4194 (face_at_string_position):
4195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4196 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4197 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4198 (Fx_show_tip):
4199 Check that fixnums are in proper range for system types.
4200 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4201 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4203 (Fx_change_window_property): Don't assume fixnums fit in int.
4204 * xfont.c (xfont_chars_supported):
4205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4206 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4207 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4208 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4209 * xml.c (parse_region):
4210 * xrdb.c (magic_file_p):
4211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4212 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4213 (x_get_local_selection, x_reply_selection_request)
4214 (x_handle_selection_request, wait_for_property_change):
4215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4216 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4217 short is wide enough.
4218 (x_send_client_event): Don't assume fixnum fits in int.
4219 * xterm.c (x_x_to_emacs_modifiers):
4220 Don't assume EMACS_INT overflows nicely into int.
4221 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4222 may come from Lisp.
4223 (handle_one_xevent): NATNUMP can eval its arg twice.
4224 (x_connection_closed):
4225 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4226 * xterm.h: Adjust decls to match defn changes elsewhere.
4227 (struct scroll_bar): Use struct vectorlike_header
4228 rather than rolling our own approximation.
4229 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4230
c6574eb5
GM
42312012-05-25 Glenn Morris <rgm@gnu.org>
4232
4233 * lisp.mk (lisp): Update for more files being compiled now.
4234
e8d32c7e
SM
42352012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4236
48def666
SM
4237 * lread.c: Remove `read_pure' which makes no difference.
4238 (read_pure): Remove var.
4239 (unreadpure): Remove function.
4240 (readevalloop): Don't call read_list with -1 flag.
4241 (read1, read_vector): Don't test read_pure any more.
4242 (read_list): Simplify.
4243
e8d32c7e
SM
4244 * fileio.c, character.h: Minor style tweaks.
4245
4b2addb7
DA
42462012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4247
4248 * window.h (clip_changed): Remove useless declaration.
4249
584461b2
JB
42502012-05-22 Juanma Barranquero <lekktu@gmail.com>
4251
4252 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4253 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4254
34374650
PE
42552012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4256
4257 Remove src/m/*.
4258 This directory predates autoconf and is no longer needed nowadays.
4259 Move its few remaining bits of functionality to where they're needed.
4260 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4261 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4262 * m/template.h: Remove.
4263 * Makefile.in (M_FILE): Remove. All uses removed.
4264 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4265 * lisp.h (USE_LSB_TAG):
4266 * mem-limits.h (EXCEEDS_LISP_PTR):
4267 Use VAL_MAX, not VALBITS, in #if.
4268 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4269 (EMACS_UINT): Define unconditionally now.
4270 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4271 (BITS_PER_EMACS_INT): New constants, replacing
4272 what used to be in config.h, but not useful in #if.
4273 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4274 define them any more.
4275 (VAL_MAX): New macro.
4276 (VALMASK): Use it.
4277 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4278 BITS_PER_EMACS_INT, in #if.
4279 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4280 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4281 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4282 * s/ms-w32.h (DATA_START):
4283 Move here from removed file m/intel386.h.
4284 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4285 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4286
261cb4bb
PE
42872012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4288
4289 Assume C89 or later.
4290 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4291 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4292 (xrealloc):
4293 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4294 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4295 * textprop.c, tparam.c (NULL): Remove.
4296 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4297 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4298 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4299 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4300 * xterm.c (input_signal_count): Assume volatile works.
4301
ff23cd9f
KB
43022012-05-21 Ken Brown <kbrown@cornell.edu>
4303
4304 * xgselect.c (xg_select): Fix first argument in call to 'select'
4305 (bug#11508).
4306
1b170bc6
KB
43072012-05-20 Ken Brown <kbrown@cornell.edu>
4308
4309 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4310 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4311
b2f4d39f
KB
43122012-05-19 Ken Brown <kbrown@cornell.edu>
4313
4314 * xfns.c (x_in_use): Remove `static' qualifier.
4315 * xterm.h (x_in_use): Declare.
4316 * xgselect.c: Include xterm.h.
4317 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4318 and `display_arg' (bug#9754).
4319
003fdae2
PE
43202012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4321
9232a6d9
PE
4322 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4323
003fdae2
PE
4324 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4325 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4326
784b56e2
EZ
43272012-05-18 Eli Zaretskii <eliz@gnu.org>
4328
4329 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4330
4331 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4332 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4333
4334 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4335 reference to image_cache->refcount.
4336 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4337
a0a79cde
JL
43382012-05-17 Juri Linkov <juri@jurta.org>
4339
4340 * search.c (Fword_search_regexp, Fword_search_backward)
4341 (Fword_search_forward, Fword_search_backward_lax)
4342 (Fword_search_forward_lax): Move functions to isearch.el
4343 (bug#10145, bug#11381).
4344
b0572523
PE
43452012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4346
4347 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4348
9660f5fc
SM
43492012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4350
4351 * lread.c (init_obarray): Declare Qt and Qnil as special.
4352
4374de83
GM
43532012-05-14 Glenn Morris <rgm@gnu.org>
4354
4355 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4356 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4357
dc44c39a
PE
43582012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4359
078c97cb
PE
4360 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4361
dc44c39a
PE
4362 * unexaix.c: Port to more-recent AIX compilers.
4363 (report_error, report_error_1, make_hdr, copy_sym)
4364 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4365 Make arguments const char *, not char *, to avoid violations of C
4366 standard and to fix some AIX warnings reported by Gilles Pion.
4367
e18afed7 43682012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4369
4370 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4371 already have overlays loaded.
4372 (handle_single_display_spec): Before returning without displaying
4373 fringe bitmap, synchronize the bidi iterator with the main display
4374 iterator, by calling iterate_out_of_display_property.
4375 (iterate_out_of_display_property): Detect buffer iteration by
4376 testing that it->string is a Lisp string.
4377 (get_next_display_element): When the current object is exhausted,
4378 and there's something on it->stack, call set_iterator_to_next to
4379 proceed with what's on the stack, instead of returning zero.
4380 (set_iterator_to_next): If called at the end of a Lisp string,
4381 proceed to consider_string_end without incrementing string
4382 position. Don't increment display vector index past the end of
4383 the display vector. (Bug#11417)
c8fb9dc6
EZ
4384 (pos_visible_p): Don't report a position visible when move_it_to
4385 stopped at the last line of window, which happens to be scanned
4386 backwards by the bidi iteration. (Bug#11464)
ac268e67 4387
e18afed7 43882012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4389
4390 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4391 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4392 are on a TTY, and thus unable to display on the fringes.
4393 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4394 so we need to signal to the caller that this is a "replacing"
4395 display spec. This fixes display when the spec is invalid or we
4396 are on a TTY.
4397
e18afed7 43982012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4399
4400 * unexaix.c (make_hdr): Fix typo in prototype.
4401 This bug broke the build on AIX. Problem reported by Gilles Pion.
4402
9d0a235a
MA
44032012-05-14 Michael Albinus <michael.albinus@gmx.de>
4404
4405 * keyboard.c (kbd_buffer_get_event): Read special events also in
4406 batch mode. (Bug#11415)
4407
9e6b06ed
GM
44082012-05-12 Glenn Morris <rgm@gnu.org>
4409
4410 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4411
c1a1d7a3
EZ
44122012-05-12 Eli Zaretskii <eliz@gnu.org>
4413
4414 * lisp.mk (lisp): Add newcomment.elc.
4415
3fe7cdc8
GM
44162012-05-12 Glenn Morris <rgm@gnu.org>
4417
4418 * Makefile.in (MKDIR_P): New, set by configure.
4419 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4420
53f7d2c0
PE
44212012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4422
4423 Remove unused function hourglass_started.
4424 * dispextern.h (hourglass_started):
4425 * w32fns.c (hourglass_started):
4426 * xdisp.c (hourglass_started): Remove.
4427
75aafb17
JB
44282012-05-10 Juanma Barranquero <lekktu@gmail.com>
4429
4430 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4431 Update dependencies.
4432
12959e8e
PE
44332012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4434
97107e2e
PE
4435 * xgselect.c (xg_select): Put maxfds+1 into a var.
4436 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4437
12959e8e
PE
4438 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4439
836d29b3
DA
44402012-05-10 Dave Abrahams <dave@boostpro.com>
4441
4442 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4443 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4444
5cb67954
MA
44452012-05-09 Michael Albinus <michael.albinus@gmx.de>
4446
4447 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4448 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4449 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4450 Initialize xd_registered_buses.
4451
3478ec45
PE
44522012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4453
b263a6b0
PE
4454 Untag more efficiently if USE_LSB_TAG.
4455 This is based on a proposal by YAMAMOTO Mitsuharu in
4456 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4457 For an admittedly artificial (nth 8000 longlist) benchmark on
4458 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4459 Emacs's overall text size by 1%.
4460 * lisp.h (XUNTAG): New macro.
4461 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4462 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4463 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4464 * eval.c (Fautoload):
4465 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4466 * frame.h (XFRAME): Use XUNTAG.
4467
3478ec45
PE
4468 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4469 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4470 Remove unportable assumptions about print widths of types like
4471 dbus_uint32_t.
4472 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4473 intptr_t when converting between pointer and integer, to avoid GCC
4474 warnings about wrong width.
4475
666b903b 44762012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4477
4478 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4479 stack for each reader_thread, instead of defaulting to 8MB
4480 determined by the linker. This avoids failures in creating
4481 subprocesses on Windows 7, see the discussion in this thread:
4482 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4483
b120cc17
JC
44842012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4485
4486 Fix up display of the *Minibuf-0* buffer in the mini window.
4487 * keyboard.c (read_char): Don't clear the echo area if there's no
4488 message to clear.
4489 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4490 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4491
9a4b36f8
MA
44922012-05-07 Michael Albinus <michael.albinus@gmx.de>
4493
4494 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4495 batch mode.
4496
e5f9458f
CY
44972012-05-06 Chong Yidong <cyd@gnu.org>
4498
4499 * lisp.mk (lisp): Update.
4500
eceeb5fc 45012012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4502
4503 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4504
71873e2b
SM
45052012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4506
4507 * data.c (PUT_ERROR): New macro.
4508 (syms_of_data): Use it. Add new error type `user-error'.
4509 * undo.c (user_error): New function.
4510 (Fprimitive_undo): Use it.
4511 * print.c (print_error_message): Adjust print style for `user-error'.
4512 * keyboard.c (user_error): New function.
4513 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4514
ab0fa4e4
PE
45152012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4516
4517 Do not limit current-time-string to years 1000..9999.
4518 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4519 (Fcurrent_time_string): Support any year that is supported by the
4520 underlying localtime representation. Don't use asctime, as it
4521 has undefined behavior for years outside the range -999..9999.
4522
7ed806a7
PE
45232012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4524
4525 Fix race conditions involving setenv, gmtime, localtime, asctime.
4526 Without this fix, interrupts could mess up code that uses these
4527 nonreentrant functions, since setting TZ invalidates existing
4528 tm_zone or tzname values, and since most of these functions return
4529 pointers to static storage.
4530 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4531 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4532 Grow the critical sections to include not just invoking
4533 localtime/gmtime, but also accessing these functions' results
4534 including their tm_zone values if any, and any related TZ setting.
4535 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4536 so that the struct tm is saved in the critical section.
4537 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4538 motivated by the fact that memory allocation needs to be outside
4539 the critical section.
4540
0c16dfed
DA
45412012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4542
4543 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4544 with RESET_INTERVAL.
4545
4546 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4547 Remove duplicated buffer name initialization.
4548
3f83ace8
JM
45492012-05-02 Jim Meyering <jim@meyering.net>
4550
4551 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4552
c7b8541e
JM
4553 * xfns.c (x_window): Use xstrdup (Bug#11375).
4554
90207a15 45552012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4556
4557 * xdisp.c (pos_visible_p): If already at a newline from the
4558 display string before the 'while' loop, don't walk back the glyphs
4559 from it3.glyph_row. Solves assertion violation when the display
4560 string begins with a newline (egg.el). (Bug#11367)
4561
b593d6a9
AH
45622012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4563
4564 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4565 Move to simple.el.
4566
4737362e
GM
45672012-05-01 Glenn Morris <rgm@gnu.org>
4568
99cf43f9
GM
4569 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4570 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4571 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4572 All were removed before 23.1.
4573
9311dcff
GM
4574 * dispnew.c: Remove HAVE_LIBNCURSES test;
4575 it is always true on relevant platforms.
4576
4d5c6349
GM
4577 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4578 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4579
4737362e
GM
4580 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4581
74dd3a6b
AS
45822012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4583
4584 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4585 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4586 Remove.
4587
13c379ee
PE
45882012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4589
4590 Do not avoid creating empty evaporating overlays (Bug#9642).
4591 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4592 That is, do not delete an evaporating overlay if it becomes
4593 empty after its bounds are adjusted to fit within its buffer.
4594 This fix caused other problems, and I'm reverting it until we get
4595 to the bottom of them.
4596
a8e7d6d7 45972012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4598
4599 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4600
a8e7d6d7 46012012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4602
4603 * xdisp.c (pos_visible_p): If the window start position is beyond
4604 ZV, start the display from buffer beginning. Prevents assertion
4605 violation in init_iterator when the minibuffer window is scrolled
4606 via the scroll bar.
4607
4608 * window.c (window_scroll_pixel_based): Likewise.
4609
a8e7d6d7 46102012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4611
4612 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4613
a8e7d6d7 46142012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4615
4616 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4617 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4618
a8e7d6d7 46192012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4620
b593d6a9
AH
4621 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4622 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4623
1c6900d9
EZ
46242012-04-26 Eli Zaretskii <eliz@gnu.org>
4625
4c3fa1d9
EZ
4626 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4627 display element, check also the underlying string or buffer
4628 character. (Bug#11341)
4629
1c6900d9
EZ
4630 * w32menu.c: Include w32heap.h.
4631 (add_menu_item): If the call to AppendMenuW (via
4632 unicode_append_menu) fails, disable Unicode menus only if we are
4633 running on Windows 9X/Me.
4634
42bf8205
AS
46352012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4636
4637 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4638 (xgetint): Add missing shift for LSB tags.
4639
b1bac16e
MR
46402012-04-24 Martin Rudalics <rudalics@gmx.at>
4641
4642 * keyboard.c (read_char): Don't wipe echo area for select window
4643 events: These might get delayed via `mouse-autoselect-window'
4644 (Bug#11304).
4645
d69621cc
JB
46462012-04-24 Juanma Barranquero <lekktu@gmail.com>
4647
4648 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4649 manipulation of :loaded-from data.
4650
02fd101b
JB
46512012-04-23 Juanma Barranquero <lekktu@gmail.com>
4652
4653 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4654 now a cons (bug#11311).
4655
888bec30
PE
46562012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4657
89a438bd
PE
4658 Do not create empty overlays with the evaporate property (Bug#9642).
4659 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4660 if it becomes empty after its bounds are adjusted to fit within
4661 its buffer. Without this fix, in a nonempty buffer (let ((o
4662 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4663 yields an empty overlay that has the evaporate property, which is
4664 not supposed to happen.
4665
1068fe4d
PE
4666 Fix minor GTK3 problems found by static checking.
4667 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4668 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4669 (struct _EmacsFixedClass, emacs_fixed_get_type):
4670 Move decls here from emacsgtkfixed.h, since they needn't be public.
4671 (emacs_fixed_get_type): Now static.
4672 (emacs_fixed_class_init): Omit unused local.
4673 (emacs_fixed_child_type): Remove; unused.
4674 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4675 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4676 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4677 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4678 (EMACS_FIXED_GET_CLASS): Remove; unused.
4679 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4680
888bec30
PE
4681 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4682 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4683
de85e130
PE
46842012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4685
d0baac98 4686 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4687 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4688 (__malloc_size_t, __malloc_ptrdiff_t):
4689 Remove. All uses removed, replaced by the definiens if needed,
4690 since we can assume C89 or better now.
4691 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4692 (protect_malloc_state, align, get_contiguous_space)
4693 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4694 (malloc_atfork_handler_child, malloc_enable_thread)
4695 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4696 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4697 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4698 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4699 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4700 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4701 Define using prototypes, not old style.
4702 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4703 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4704 (align): Don't assume that signed integer overflow wraps around.
4705 Omit unused local var.
4706 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4707 (_free_internal_nolock, memalign, mallochook, reallochook):
4708 Omit no-longer-needed casts.
4709 (valloc): Use getpagesize, not __getpagesize.
4710 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4711 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4712
de85e130
PE
4713 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4714
dcbf5805
MA
47152012-04-22 Michael Albinus <michael.albinus@gmx.de>
4716
4717 Move functions from C to Lisp. Make non-blocking method calls
4718 the default. Implement further D-Bus standard interfaces.
4719
4720 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4721 (QCdbus_request_name_allow_replacement)
4722 (QCdbus_request_name_replace_existing)
4723 (QCdbus_request_name_do_not_queue)
4724 (QCdbus_request_name_reply_primary_owner)
4725 (QCdbus_request_name_reply_in_queue)
4726 (QCdbus_request_name_reply_exists)
4727 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4728 (QCdbus_registered_serial, QCdbus_registered_method)
4729 (QCdbus_registered_signal): New Lisp objects.
4730 (XD_DEBUG_MESSAGE): Use sizeof.
4731 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4732 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4733 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4734 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4735 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4736 (xd_signature, xd_append_arg): Allow float for integer types.
4737 (xd_get_connection_references): New function.
b593d6a9
AH
4738 (xd_get_connection_address): Rename from xd_initialize.
4739 Return cached address.
dcbf5805
MA
4740 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4741 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4742 level.
4743 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4744 Return number of refcounts.
dcbf5805
MA
4745 (Fdbus_get_unique_name): Make stronger parameter check.
4746 (Fdbus_message_internal): New defun.
4747 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4748 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4749 (Fdbus_send_signal, Fdbus_register_service)
4750 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4751 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4752 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4753 (Vdbus_compiled_version, Vdbus_runtime_version)
4754 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4755 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4756 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4757 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4758 Adapt docstring.
dcbf5805 4759
52828e02
PE
47602012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4761
da05bc4c
PE
4762 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4763 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4764 Do not assume ptrdiff_t is the same width as 'int'.
4765
52828e02
PE
4766 * alloc.c: Handle unusual debugging option combinations.
4767 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4768 since the two debugging options are incompatible.
4769 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4770 is defined.
4771 (mem_init, mem_insert, mem_insert_fixup):
4772 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4773 (NEED_MEM_INSERT): Remove; no longer needed.
4774
f01769f9
LL
47752012-04-22 Leo Liu <sdl.web@gmail.com>
4776
4777 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4778
5790543d
PE
47792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4780
4781 * sysdep.c [__FreeBSD__]: Minor cleanups.
4782 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4783 Use Emacs indenting style more consistently. Avoid some casts.
4784 Use 'double' consistently rather than mixing 'float' and 'double'.
4785
b91b7e4d
EW
47862012-04-21 Eduard Wiebe <usenet@pusto.de>
4787
b593d6a9
AH
4788 * sysdep.c (list_system_processes, system_process_attributes):
4789 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4790
6114eb15
AS
47912012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4792
4793 * lisp.mk (lisp): Update.
4794
2f38dff7
PE
47952012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4796
4797 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4798 It is never used otherwise.
4799
4ae29f89
SM
48002012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4801
4802 * print.c (print_preprocess): Only check print_depth if print-circle
4803 is nil.
4804 (print_object): Check for cycles even when print-circle is nil and
4805 print-gensym is t, but only check print_depth if print-circle is nil.
4806
f30d612a
CY
48072012-04-20 Chong Yidong <cyd@gnu.org>
4808
4809 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4810 set the status to "failed" and ensure that sentinel is run.
4811
c07a4c0b 48122012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4813
4814 * process.c (Fset_process_inherit_coding_system_flag)
4815 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4816 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4817
c07a4c0b 48182012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4819
4820 * xdisp.c (string_buffer_position_lim): Limit starting position to
4821 BEGV.
4822 (set_cursor_from_row): If called for a mode-line or header-line
4823 row, return zero immediately.
4824 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4825 farther than the first row after the header line, if any.
4826 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4827 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4828
c07a4c0b 48292012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4830
4ae29f89
SM
4831 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4832 (bug#11238).
ad3a2b41 4833
c07a4c0b 48342012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 48352012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4836
4837 configure: new option --enable-gcc-warnings (Bug#11207)
4838 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4839 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4840 (ALL_CFLAGS): Use new macros rather than old.
4841 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4842 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4843 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4844 -Wunused-result, -Wunused-variable. This should go away once
4845 the Emacs and Gnulib regex code is merged.
4846 (xmalloc, xrealloc): Now static.
4847
aba027e8
PE
48482012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4849
4850 * dired.c (Fsystem_groups): Remove unused local.
4851
e5a36063
GM
48522012-04-17 Glenn Morris <rgm@gnu.org>
4853
4854 * dired.c (Fsystem_users): Doc fix.
4855
316411f0
DA
48562012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4857
4858 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4859 (syms_of_dired): Add them.
4860
9426aba4
PE
48612012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4862
b62a57be
PE
4863 Fix minor alloc.c problems found by static checking.
4864 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4865 New extern decls, to avoid calling undeclared functions.
4866 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4867 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4868 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4869 (NEED_MEM_INSERT): New macro.
4870 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4871 Remove one incorrect comment and fix another.
b62a57be 4872
3539f31f
PE
4873 Fix minor ralloc.c problems found by static checking.
4874 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4875 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4876 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4877 (r_alloc_sbrk): Now static.
4878
a041960a
PE
4879 Improve ralloc.c interface checking.
4880 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4881 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4882 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4883 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4884 [REL_ALLOC]: ... to here, to check interface.
4885 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4886 Remove decls. This fixes an "It stinks!".
4887
9426aba4
PE
4888 * alloc.c (which_symbols): Fix alignment issue / type clash.
4889
d55c12ed
AS
48902012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4891
4892 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4893 (struct Lisp_Misc_Any): Likewise.
4894 (struct Lisp_Free): Likewise.
4895 * alloc.c (union aligned_Lisp_Symbol): Define.
4896 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4897 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4898 (union aligned_Lisp_Misc): Define.
4899 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4900 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4901 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4902
b948ce8b
PE
49032012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4904
4905 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4906 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4907 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4908 * s/netbsd.h, s/sol2-6.h:
4909 Remove definition of GC_MARK_STACK, since the default now works.
4910 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4911 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4912 no longer the default.
4913 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4914
35dc09a1 49152012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4916
35dc09a1
GM
4917 * lread.c (lisp_file_lexically_bound_p):
4918 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4919
35dc09a1
GM
49202012-04-14 Eli Zaretskii <eliz@gnu.org>
4921
4922 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4923 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4924
49252012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4926
4927 * nsterm.m (constrainFrameRect): Always constrain when there is only
4928 one screen (Bug#10962).
4929
bcd86815
KB
49302012-04-13 Ken Brown <kbrown@cornell.edu>
4931
4932 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4933
c25df26e
RT
49342012-04-13 Reuben Thomas <rrt@sc3d.org>
4935
4936 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4937
0fc59f1e
DC
49382012-04-11 Daniel Colascione <dancol@dancol.org>
4939
4940 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4941 against is gone. It's better to use vfork now so that when Cygwin
4942 gains a new, working vfork, we use it automatically (bug#10398).
4943
de8c03dc
SM
49442012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4945
4946 * window.c (save_window_save): Obey window-point-insertion-type.
4947
2f097256
GM
49482012-04-11 Glenn Morris <rgm@gnu.org>
4949
4950 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4951
453b951e
SM
49522012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4953
4954 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4955
75f1671a 49562012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4957
4958 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4959 (force_quit_count): New var.
4960 (handle_interrupt): Use it.
4961
2a8ce227
JB
49622012-04-10 Juanma Barranquero <lekktu@gmail.com>
4963
4964 * w32.c (w32_delayed_load): Record the full path of the library
4965 being loaded (bug#10424).
4966
935396c0
GM
49672012-04-09 Glenn Morris <rgm@gnu.org>
4968
05920a43
GM
4969 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4970 not just in the obarray, before snarfing them. (Bug#11036)
4971
935396c0
GM
4972 * Makefile.in ($(leimdir)/leim-list.el):
4973 Pass EMACS rather than BUILT_EMACS.
4974
a18ecafa
TZ
49752012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4976
4977 * process.c (make_process):
4978 * process.h: Add integer `gnutls_handshakes_tried' member to
4979 process struct.
4980
6bbef4e5
JC
4981 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4982 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4983
4984 * gnutls.c (gnutls_log_function2i): Convenience log function.
4985 (emacs_gnutls_read): Use new log functions,
4986 `gnutls_handshakes_tried' process member, and
4987 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4988 attempts per process (connection).
4989
b4d3bc10
CY
49902012-04-09 Chong Yidong <cyd@gnu.org>
4991
4992 * eval.c (Fuser_variable_p, user_variable_p_eh)
4993 (lisp_indirect_variable): Functions deleted.
4994 (Fdefvar): Caller changed.
4995
4996 * callint.c (Finteractive, Fcall_interactively):
4997 * minibuf.c (Fread_variable): Callers changed.
4998
70f4d973
EZ
49992012-04-09 Eli Zaretskii <eliz@gnu.org>
5000
5001 * xdisp.c (set_cursor_from_row): If the display string appears in
5002 the buffer at position that is closer to point than the position
5003 after the display string, display the cursor on the first glyph of
5004 the display string. Fixes cursor display when a 'display' text
5005 property immediately follows invisible text. (Bug#11094)
5006
cb3c2e3e
PE
50072012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5008
5009 composite.c: use 'double' consistently
5010 * composite.c (get_composition_id): Use 'double' consistently
5011 instead of converting 'float' to 'double' and vice versa; this is
5012 easier to understand and avoids a GCC warning.
5013
fd06db5d
GM
50142012-04-09 Glenn Morris <rgm@gnu.org>
5015
50fe702a
GM
5016 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5017 preparation for dumping it with emacs. (Bug#4789)
5018 (leimdir): New variable.
5019 ($(leimdir)/leim-list.el): New rule.
5020 (emacs$(EXEEXT)): Depend on leim-list.el.
5021
fd06db5d
GM
5022 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5023 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5024 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5025
55c131ee
AS
50262012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5027
5028 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5029 proper alignment.
5030
9209588f
JB
50312012-04-07 Juanma Barranquero <lekktu@gmail.com>
5032
5033 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5034 Remove unused local variable.
5035
e3fb2efb
PE
50362012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5037
5038 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5039 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5040 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5041 objects, as mark_maybe_pointer will catch them otherwise.
5042 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5043 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5044
b5385551
PE
50452012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5046
5047 Fix typo that broke non-Windows builds.
5048 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5049
9078ead6
EZ
50502012-04-07 Eli Zaretskii <eliz@gnu.org>
5051
5052 Support building on MS-Windows with libxml2.
5053
5054 * makefile.w32-in (OBJ2): Add xml.$(O).
5055 (GLOBAL_SOURCES): Add xml.c.
5056 ($(BLD)/xml.$(O)): New dependency list.
5057
5058 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5059 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5060 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5061 [!WINDOWSNT]: New macros.
5062 (init_libxml2_functions, libxml2_loaded_p): New functions.
5063 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5064 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5065 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5066 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5067 linked in).
6bbef4e5
JC
5068 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5069 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5070 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5071
5072 * emacs.c: Don't include libxml/parser.h.
5073 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5074 xmlCleanupParser directly.
5075
5076 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5077
3811fdf3
EZ
50782012-04-07 Eli Zaretskii <eliz@gnu.org>
5079
5080 * indent.c (Fvertical_motion): If there is a display string at
5081 point, use it.vpos to compute how many lines to backtrack after
5082 move_it_to point. (Bug#11133)
5083
2f8e16b2
EZ
50842012-04-06 Eli Zaretskii <eliz@gnu.org>
5085
5086 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5087 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5088 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5089 macros related to unification of CJK characters. For the details,
5090 see the discussion following the message here:
5091 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5092
3d439cd1
CY
50932012-04-04 Chong Yidong <cyd@gnu.org>
5094
5095 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5096
8bc53d00
EZ
50972012-04-01 Eli Zaretskii <eliz@gnu.org>
5098
5099 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5100 instead of alloca. (Bug#11138)
5101
3b0512a3
AS
51022012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5103
5104 * w32menu.c (is_simple_dialog): Properly check lisp types.
5105 (Bug#11141)
5106
8427ddd2
EZ
51072012-03-31 Eli Zaretskii <eliz@gnu.org>
5108
979022ef
EZ
5109 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5110 position we get to after a call to move_it_to fails the
5111 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5112 only if we wind up in a string from display property. (Bug#11063)
5113
a6b1c7cc
EZ
5114 * window.c (Fdelete_other_windows_internal): Invalidate the row
5115 and column information about mouse highlight, so that redisplay
5116 restores it after reallocating the glyph matrices. (Bug#7464)
5117
8427ddd2
EZ
5118 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5119 string comes from a `display' text property, use the buffer
5120 position of that property as if we actually saw that position in
5121 the row's glyphs.
697ba24b
EZ
5122 (move_it_by_lines): Remove the assertion that
5123 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5124 violated when there's a before-string at the beginning of a line.
5125 (Bug#11063)
8427ddd2 5126
65a0a738
EZ
51272012-03-30 Eli Zaretskii <eliz@gnu.org>
5128
5129 * xdisp.c (append_space_for_newline): If the default face was
5130 remapped, use the remapped face for the appended newline.
5131 (extend_face_to_end_of_line): Use the remapped default face for
5132 extending the face to the end of the line.
5133 (display_line): Call extend_face_to_end_of_line when the default
5134 face was remapped. (Bug#11068)
5135
581355cc
EZ
51362012-03-29 Eli Zaretskii <eliz@gnu.org>
5137
5138 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5139
e8fc049f
SM
51402012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5141
5142 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5143
4fb9a543
GM
51442012-03-27 Glenn Morris <rgm@gnu.org>
5145
5146 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5147 Doc fixes.
5148
679910f1
KH
51492012-03-26 Kenichi Handa <handa@m17n.org>
5150
5151 * dispextern.h (struct glyph): Fix previous change. Change the
5152 bit length of glyphless.ch to 25 (Bug#11082).
5153
90d49b7f
CY
51542012-03-26 Chong Yidong <cyd@gnu.org>
5155
5156 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5157 (command_loop_1): Use it; inhibit selection update for
5158 handle-select-window too (Bug#8996).
5159
f514f6f0
FP
51602012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5161
e8fc049f 5162 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5163
bf43fa51
KH
51642012-03-25 Kenichi Handa <handa@m17n.org>
5165
5166 * dispextern.h (struct glyph): Change the bit length of
5167 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5168
8a0c01dd
EZ
51692012-03-24 Eli Zaretskii <eliz@gnu.org>
5170
5171 * s/ms-w32.h (tzname): Include time.h before redirecting to
5172 _tzname. Fixes the MSVC build. (Bug#9960)
5173
7d1c3a76
AS
51742012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5175
8ed79523
AS
5176 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5177 characters.
5178
7d1c3a76
AS
5179 * xterm.c (XTread_socket): Only modify handling_signal if
5180 !SYNC_INPUT. (Bug#11080)
5181
e99a9b8b
EZ
51822012-03-23 Eli Zaretskii <eliz@gnu.org>
5183
5184 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5185 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5186 when fetching a multibyte character consumes more bytes than
5187 CHAR_BYTES returns, due to unification of CJK characters in
5188 string_char. (Bug#11073)
5189
5063c0e1
TN
51902012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5191
5192 * process.c (wait_reading_process_output): Handle pty disconnect
5193 by refraining from sending oneself a SIGCHLD (bug#10933).
5194
9f851fbd
CY
51952012-03-22 Chong Yidong <cyd@gnu.org>
5196
5197 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5198
5063c0e1 5199 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5200 Mark string as coming from a prefix property.
5201 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5202 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5203
fb5b8aca
CY
52042012-03-21 Chong Yidong <cyd@gnu.org>
5205
5206 * xfaces.c (Vface_remapping_alist): Doc fix.
5207
62356a1b
EZ
52082012-03-20 Eli Zaretskii <eliz@gnu.org>
5209
5210 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5211 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5212 Doc fixes.
62356a1b 5213
025de85b
CY
52142012-03-20 Chong Yidong <cyd@gnu.org>
5215
5216 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5217 to reflect default non-nil value of redisplay-dont-pause.
5218
4827f94e
KH
52192012-03-19 Kenichi Handa <handa@m17n.org>
5220
5221 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5222 it fit in a valid range (Bug#11003).
5223
e50a24a2
EZ
52242012-03-18 Eli Zaretskii <eliz@gnu.org>
5225
5226 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5227 that is not from display property, accept the row as a "cursor
5228 row" if one of the string's character has a non-nil `cursor'
5229 property. Fixes cursor positioning when there are newlines in
5230 overlay strings, e.g. in icomplete.el. (Bug#11035)
5231
9af5ed87
PE
52322012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5233
5234 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5235
d1f55f16
CY
52362012-03-12 Chong Yidong <cyd@gnu.org>
5237
5238 * eval.c (inhibit_lisp_code): Rename from
5239 inhibit_window_configuration_change_hook; move from window.c.
5240
5241 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5242 * window.c (run_window_configuration_change_hook)
5243 (syms_of_window): Callers changed.
5244
66c5eebd
CY
52452012-03-11 Chong Yidong <cyd@gnu.org>
5246
413df973
CY
5247 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5248
66c5eebd
CY
5249 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5250
1de11f56
CY
52512012-03-10 Chong Yidong <cyd@gnu.org>
5252
5253 * frame.c (other_visible_frames): Don't assume the selected frame
5254 is visible (Bug#10955).
5255
cae07000
SM
52562012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5257
5258 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5259
89c94350
JD
52602012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5261
5262 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5263 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5264 zero (Bug#10954).
5265
999dd333
GM
52662012-03-03 Glenn Morris <rgm@gnu.org>
5267
01a6dcc8 5268 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5269
de0100f2
EZ
52702012-03-02 Eli Zaretskii <eliz@gnu.org>
5271
5272 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5273 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5274 (redisplay_window, next_element_from_string): Fix typos in
5275 comments.
3e441275
EZ
5276 (redisplay_window): Pass to move_it_vertically the margin in
5277 pixels, not in screen lines.
de0100f2 5278
96a72ee9
GM
52792012-03-02 Glenn Morris <rgm@gnu.org>
5280
5281 * buffer.c (buffer-list-update-hook): Doc fix.
5282
312508d7
EZ
52832012-02-29 Eli Zaretskii <eliz@gnu.org>
5284
5285 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5286 push_it before setting up the iterator for the first overlay
5287 string, even if we have an empty string loaded.
5288 (next_overlay_string): If there's an empty string on the iterator
5289 stack, pop the stack. (Bug#10903)
5290
27f3c637
PE
52912012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5292
5293 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5294 Suggested by Stefan Monnier in
5295 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5296 * alloc.c (widen_to_Lisp_Object): New static function.
5297 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5298 and widening them to Lisp_Objects. This would work even if
5299 USE_LSB_TAG is defined and wide integers are used, which might
5300 happen in a future version of Emacs.
5301
3c9dfce6
CY
53022012-02-25 Chong Yidong <cyd@gnu.org>
5303
fa74b241
CY
5304 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5305 Doc fix.
5306
3c9dfce6
CY
5307 * xselect.c (Fx_selection_exists_p): Doc fix.
5308 (x_clipboard_manager_save_all): Print an informative message
5309 before saving to clipboard manager.
5310
9486df08
CY
53112012-02-24 Chong Yidong <cyd@gnu.org>
5312
5313 * keyboard.c (process_special_events): Handle all X selection
5314 requests in kbd_buffer, not just the next one (Bug#8869).
5315
f01d3321
CY
53162012-02-23 Chong Yidong <cyd@gnu.org>
5317
5318 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5319 call when setting menu-bar-lines and tool-bar-lines parameters.
5320 (unwind_create_frame_1): New helper function.
5321
5322 * window.c (inhibit_window_configuration_change_hook): New var.
5323 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5324 (syms_of_window): Initialize it.
f01d3321 5325
86b847b6
CY
53262012-02-22 Chong Yidong <cyd@gnu.org>
5327
5328 * xterm.c (x_draw_image_relief): Add missing type check for
5329 Vtool_bar_button_margin (Bug#10743).
5330
a59225b1
CY
53312012-02-21 Chong Yidong <cyd@gnu.org>
5332
5333 * fileio.c (Vfile_name_handler_alist): Doc fix.
5334
5335 * buffer.c (Fget_file_buffer): Protect against invalid file
5336 handler return value.
5337
310f5bd4
PE
53382012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5339
cb3a28cc
PE
5340 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5341 when computing $valmask.
5342
310f5bd4
PE
5343 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5344 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5345 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5346 It's useless in that case, and it can cause problems on hosts
5347 that allocate halves of EMACS_INT values separately.
5348 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5349 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5350 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5351 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5352 it avoids undefined behavior on hosts where shifting right by more
5353 than the word width has undefined behavior.
5354
2375c96a
CY
53552012-02-19 Chong Yidong <cyd@gnu.org>
5356
5357 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5358 (Funhandled_file_name_directory, Ffile_name_as_directory)
5359 (Fdirectory_file_name, Fexpand_file_name)
5360 (Fsubstitute_in_file_name): Protect against invalid file handler
5361 return values (Bug#10845).
5362
3eb49e71
EZ
53632012-02-18 Eli Zaretskii <eliz@gnu.org>
5364
5365 * .gdbinit (pitx): Fix incorrect references to fields of the
5366 iterator stack.
5367
7b926f3f
CY
53682012-02-17 Chong Yidong <cyd@gnu.org>
5369
5370 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5371
11273115
PE
53722012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5373
5374 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5375 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5376
c3a70e2b
CY
53772012-02-15 Chong Yidong <cyd@gnu.org>
5378
5379 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5380 marked as special. Also, starting docstrings with * is obsolete.
5381
0ca43699
AS
53822012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5383
5384 * gnutls.c (emacs_gnutls_write): Fix last change.
5385
2e8f3c56
LI
53862012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5387
5388 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5389 send_process.
5390
af70074f
SM
53912012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5392
5393 * keymap.c (Fsingle_key_description): Handle char ranges.
5394
95986d52
CY
53952012-02-12 Chong Yidong <cyd@gnu.org>
5396
afd83bd1
CY
5397 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5398 as that creates a dangerous corner case.
5399
95986d52
CY
5400 * window.c (Fdelete_window_internal): Invalidate the mouse
5401 highlight (Bug#9904).
5402
bd7da63e
GM
54032012-02-12 Glenn Morris <rgm@gnu.org>
5404
5405 * xselect.c (Fx_own_selection_internal)
5406 (Fx_get_selection_internal, Fx_disown_selection_internal)
5407 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5408 * nsselect.m (Fx_own_selection_internal)
5409 (Fx_disown_selection_internal, Fx_selection_exists_p)
5410 (Fx_selection_owner_p, Fx_get_selection_internal):
5411 Sync docs and argument specs with the xselect.c versions.
5412
77abcbc2
LI
54132012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5414
5415 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5416
90b671e2
EZ
54172012-02-11 Eli Zaretskii <eliz@gnu.org>
5418
1c0ca0b7
EZ
5419 * w32select.c (Fx_selection_exists_p): Sync doc string and
5420 argument list with xselect.c. (Bug#10783)
5421
5422 * w16select.c (Fx_selection_exists_p): Sync doc string and
5423 argument list with xselect.c. (Bug#10783)
90b671e2 5424
49241268
GM
54252012-02-10 Glenn Morris <rgm@gnu.org>
5426
5427 * fns.c (Fsecure_hash): Doc fix.
5428
f998bbe7 54292012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5430
5431 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5432
0992bd9c
CY
54332012-02-07 Chong Yidong <cyd@gnu.org>
5434
5435 * buffer.c (Fbuffer_local_variables)
5436 (buffer_lisp_local_variables): Handle unbound vars correctly;
5437 don't let Qunbound leak into Lisp.
5438
af008560
GM
54392012-02-07 Glenn Morris <rgm@gnu.org>
5440
dd605cc4
GM
5441 * image.c (Fimagemagick_types): Doc fix.
5442
af008560
GM
5443 * image.c (imagemagick-render-type): Change it from a lisp object
5444 to an integer. Move the doc here from the lisp manual.
5445 Treat all values not equal to 0 the same.
5446
1449fa1d
CY
54472012-02-06 Chong Yidong <cyd@gnu.org>
5448
5449 * doc.c (store_function_docstring): Avoid applying docstring of
5450 alias to base function (Bug#2603).
5451
3723ec07
AS
54522012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5453
5454 * .gdbinit (pp1, pv1): Remove redundant defines.
5455 (pr): Use pp.
5456
79c1cc1e
CY
54572012-02-04 Chong Yidong <cyd@gnu.org>
5458
5459 * nsterm.m: Declare a global (Bug#10694).
5460
d7f29f8e
EZ
54612012-02-04 Eli Zaretskii <eliz@gnu.org>
5462
cae07000
SM
5463 * w32.c (get_emacs_configuration_options):
5464 Include --enable-checking, if specified, in the return value.
d7f29f8e 5465
3b95a6f9
MR
54662012-02-04 Martin Rudalics <rudalics@gmx.at>
5467
5468 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5469 after rounding frame sizes. (Bug#9723)
5470
d6fa96a6
EZ
54712012-02-04 Eli Zaretskii <eliz@gnu.org>
5472
5473 * keyboard.c (adjust_point_for_property): Don't position point
5474 before BEGV. (Bug#10696)
5475
df0b2940
PE
54762012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5477
5478 Handle overflow when computing char display width (Bug#9496).
5479 * character.c (char_width): Return EMACS_INT, not int.
5480 (char_width, c_string_width): Check for overflow when
5481 computing the width; this is possible now that individual
5482 characters can have unbounded width. Problem introduced
5483 by merge from Emacs 23 on 2012-01-19.
5484
6bee44d6
MA
54852012-02-02 Michael Albinus <michael.albinus@gmx.de>
5486
5487 * dbusbind.c (Fdbus_register_method): Mention the return value
5488 :ignore in the docstring.
5489
44f92739
GM
54902012-02-02 Glenn Morris <rgm@gnu.org>
5491
1b9f60cc
GM
5492 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5493
44f92739
GM
5494 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5495 Unconditionally set to t. (Bug#10673)
5496 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5497 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5498 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5499
c5d3843c
KH
55002012-02-02 Kenichi Handa <handa@m17n.org>
5501
5502 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5503 0, do not call append_composite_glyph.
5504
159462d4 55052012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5506
5507 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5508 NULL (Bug#6988).
5509 (x_produce_glyphs): If the component of a composition is a null
5510 string, set it->pixel_width to 1 to avoid zero-width glyph.
5511
78cef877
EZ
55122012-02-01 Eli Zaretskii <eliz@gnu.org>
5513
5514 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5515 first 2 arguments are identical. This makes inserting large
5516 output from a subprocess an order of magnitude faster on
5517 MS-Windows, where all sbrk'ed memory is always contiguous.
5518
97897668
GM
55192012-01-31 Glenn Morris <rgm@gnu.org>
5520
5521 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5522 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5523 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5524
31fd3586
GM
55252012-01-29 Glenn Morris <rgm@gnu.org>
5526
5527 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5528
0e24a8b2
CY
55292012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5530
5531 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5532
cc0adcb0
CY
55332012-01-28 Chong Yidong <cyd@gnu.org>
5534
5535 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5536
acc28cb9
CY
55372012-01-26 Chong Yidong <cyd@gnu.org>
5538
9c69cfb7
CY
5539 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5540
acc28cb9
CY
5541 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5542 repeat counts (Bug#10507).
5543
48da7392
GM
55442012-01-26 Glenn Morris <rgm@gnu.org>
5545
5546 * lread.c (syms_of_lread): Doc fix.
5547
14af5f7f
CY
55482012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5549
5550 * coding.c (encode_designation_at_bol): Change return value to
5551 EMACS_INT.
5552
0b21c100
CY
55532012-01-25 Chong Yidong <cyd@gnu.org>
5554
5555 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5556
3c2907f7
CY
55572012-01-21 Chong Yidong <cyd@gnu.org>
5558
5559 * floatfns.c (Fcopysign): Make the second argument non-optional,
5560 since nil is not allowed anyway.
5561
959ad23f
AS
55622012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5563
5564 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5565 (send_process): Likewise.
5566
34a02f46
MR
55672012-01-19 Martin Rudalics <rudalics@gmx.at>
5568
5569 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5570 (Vwindow_persistent_parameters): Do not use Qstate.
5571 Rewrite doc-strings.
34a02f46 5572
1259009a 55732012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5574
5575 * character.c (char_width): New function.
70d4fdf6
GM
5576 (Fchar_width, c_string_width, lisp_string_width):
5577 Use char_width (Bug#9496).
25ed9e61 5578
6a6ee00d
MR
55792012-01-16 Martin Rudalics <rudalics@gmx.at>
5580
5581 * window.c (Vwindow_persistent_parameters): New variable.
5582 (Fset_window_configuration, save_window_save): Handle persistent
5583 window parameters.
5584
c85efaf7
EZ
55852012-01-14 Eli Zaretskii <eliz@gnu.org>
5586
5587 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5588 thrashing the stack of the thread. (Bug#9087)
5589
5944709e
PE
55902012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5591
5592 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5593
e71f5d99
EZ
55942012-01-11 Eli Zaretskii <eliz@gnu.org>
5595
5596 * xdisp.c (rows_from_pos_range): Handle the case where the
5597 highlight ends on a newline. (Bug#10464)
5598 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5599 he end column for display of highlight that ends on a newline
5600 before a R2L line.
5601
ce316182
GM
56022012-01-11 Glenn Morris <rgm@gnu.org>
5603
5604 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5605 from load-path also when installation-directory is nil. (Bug#10208)
5606
5b43da69
GM
56072012-01-10 Glenn Morris <rgm@gnu.org>
5608
74cc8ff9
GM
5609 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5610
7d8d6e4e
GM
5611 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5612 Update template values to be closer to their typical values these days.
5b43da69 5613
a0db8d43
EZ
56142012-01-09 Eli Zaretskii <eliz@gnu.org>
5615
5616 * xdisp.c (rows_from_pos_range): Accept additional argument
5617 DISP_STRING, and accept any glyph in a row whose object is that
5618 string as eligible for mouse highlight. Fixes mouse highlight of
5619 display strings from overlays. (Bug#10464)
5620
9a0115ab 56212012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5622
b9110d6a 5623 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5624 * fileio.c (auto_saving_dir_umask): New static var.
5625 (Fmake_directory_internal): Use it.
5626 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5627 creating the directory. The old code temporarily assigns
5628 too-generous permissions to the directory.
5629 (do_auto_save_eh): Clear it.
b9110d6a 5630 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5631 that the var is always cleared.
5632
6c1bd3f3
EZ
56332012-01-07 Eli Zaretskii <eliz@gnu.org>
5634
5635 * search.c (scan_buffer): Pass character positions to
5636 know_region_cache, not byte positions. (Bug#6540)
5637
069d2b50
L
56382012-01-07 LynX <_LynX@bk.ru> (tiny change)
5639
5640 * w32.c (sys_rename): Report EXDEV when rename of a directory
5641 fails because the target is on another logical disk. (Bug#10284)
5642
75bf0d33
DB
56432012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5644
5645 * xterm.c (x_embed_request_focus): New function.
5646
5647 * xterm.h: Add prototype.
5648
5649 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5650
1c6e5a32
GM
56512012-01-05 Glenn Morris <rgm@gnu.org>
5652
5653 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5654
651e947e
EZ
56552012-01-01 Eli Zaretskii <eliz@gnu.org>
5656
5657 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5658 Load gnutls_transport_set_lowat only if GnuTLS version is below
5659 2.11.1.
5660 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5661 GnuTLS versions below 2.11.1.
5662
3778cdd8
AL
56632011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5664
5665 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5666 to the doc string advising against its use for altering the way
5667 windows are scrolled.
5668
0e5317f7
KH
56692011-12-28 Kenichi Handa <handa@m17n.org>
5670
5671 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5672 coding-system ASCII compatible only when it does not produce BOM
5673 on encoding (Bug#10383).
5674
93d5ca1f
JD
56752011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5676
5677 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5678 can scroll.
5679 (create_and_show_popup_menu): Always use menu_position_func for
5680 Gtk3 (Bug#10361).
5681
ca22b785
AS
56822011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5683
5684 * callint.c (Fcall_interactively): Don't truncate prompt string.
5685
d048e1e6
EZ
56862011-12-23 Eli Zaretskii <eliz@gnu.org>
5687
5688 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5689 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5690 resumed from there (after widening). (Bug#10360)
d048e1e6 5691
5ccaba1f
JD
56922011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5693
5694 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5695
204ee57f
JD
56962011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5697
b81d40f0
JB
5698 * nsterm.m (x_free_frame_resources):
5699 Release f->output_data.ns->miniimage.
204ee57f
JD
5700 (ns_index_color): Fix indentation. Do not retain
5701 color_table->colors[i].
5702
5703 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5704 before returning.
5705
5706 * nsfns.m (x_set_background_color): Assign return value from
5707 ns_index_color to face-background instead of NSColor*.
5708 (ns_implicitly_set_icon_type): Fix indentation.
5709 Change assignment in for loop to comparison.
5710
5711 * emacs.c (ns_pool): New variable.
5712 (main): Assign ns_pool.
5713 (Fkill_emacs): Call ns_release_autorelease_pool.
5714
5715 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5716 autorelease fdesc, release fdAttrs and tdict.
5717 (ns_get_covering_families): Release charset.
5718 (ns_findfonts): Release NSFontDescriptor created with new.
5719 (ns_uni_to_glyphs): Fix indentation.
5720 (setString): Release attrStr before assigning new value.
5721
c803b2b7
JD
57222011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5723
678f4426
JD
5724 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5725 and NS_IMPL_COCOA.
5726 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5727 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5728
cd394be1 57292011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5730
5fecd5fc
JD
5731 * nsterm.m (ns_term_init): Subscribe for notifications
5732 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5733 to method trackingNotification in EmacsMenu.
5734
5735 * nsmenu.m (trackingMenu): New variable.
3771cb17 5736 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5737 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5738 from Aquamacs (Bug#7030).
678f4426
JD
5739
57402011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5741
c803b2b7
JD
5742 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5743 (symbol_to_nsstring): Fix indentation.
5744 (ns_symbol_to_pb): New function.
cae07000
SM
5745 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5746 (Fns_rotate_cut_buffers_internal): Remove.
5747 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5748 Fns_store_cut_buffer_internal.
5749 (ns_get_foreign_selection, Fx_own_selection_internal)
5750 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5751 (Fns_get_selection_internal, Fns_store_selection_internal):
5752 Use ns_symbol_to_pb and check if return value is nil.
5753 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5754 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5755 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5756 renamed to Sns_store_selection_internal.
5757 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5758 and remove this function.
5759 (ns_handle_selection_clear): Remove, never used.
5760 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5761 here.
5762
e1b01a3a
KB
57632011-12-17 Ken Brown <kbrown@cornell.edu>
5764
5765 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5766 GID is unknown (Bug#10257).
5767
2adb6e85
PE
57682011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5769
5770 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5771 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5772 which caused a build failure on GNU/Linux IA-64. This problem was
5773 introduced by my 2011-10-07 patch.
5774
d1d7b339
JL
57752011-12-15 Juri Linkov <juri@jurta.org>
5776
5777 * image.c (imagemagick_error): New function. (Bug#10112)
5778 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5779 Use `imagemagick_error' where ImageMagick functions return
5780 `MagickFalse'.
5781 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5782 proper order.
5783
100d5755
KH
57842011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5785
5786 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5787 fill background (Bug#8992).
5788
454592a6
MR
57892011-12-13 Martin Rudalics <rudalics@gmx.at>
5790
5791 * window.c (Vwindow_combination_resize)
5792 (Vwindow_combination_limit): Use t instead of non-nil in
5793 doc-strings.
61d4b438
MR
5794 (Vrecenter_redisplay): Add first sentence of doc-string on
5795 separate line.
53524d93 5796 (Frecenter): Fix doc-string typo.
454592a6 5797
3633e3aa
KH
57982011-12-11 Kenichi Handa <handa@m17n.org>
5799
5800 * coding.c (Funencodable_char_position): Pay attention to the
5801 buffer text relocation (Bug#9389).
5802
7b9d523a 58032011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5804
7b9d523a
JD
5805 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5806 gtk_init (Bug#10100).
5807
b73189c6
EZ
58082011-12-10 Eli Zaretskii <eliz@gnu.org>
5809
5810 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5811 IT->string is nil. (Bug#10263)
5812
f7dfe5d6
JD
58132011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5814
83faebb4
JD
5815 * nsterm.h (x_free_frame_resources): Declare.
5816
f7dfe5d6
JD
5817 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5818 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5819
5820 * nsterm.h (ns_get_defaults_value): Declare.
5821
5822 * nsterm.m (ns_default): Call ns_get_defaults_value.
5823
7cd4e72c
EZ
58242011-12-09 Eli Zaretskii <eliz@gnu.org>
5825
5826 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5827 (Bug#10170)
5828
b34d7317
YM
58292011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5830
5831 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5832 that where the value of an _OBJC_* symbol points to is in the .bss
5833 section (Bug#10240).
5834
76470ad1
KH
58352011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5836
5837 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5838 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5839
745fff94
KH
58402011-12-08 Kenichi Handa <handa@m17n.org>
5841
5842 * ftfont.c (get_adstyle_property): Fix previous change
5843 (Bug#10233).
5844
6e44397c
JB
58452011-12-07 Juanma Barranquero <lekktu@gmail.com>
5846
5847 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5848 dirs from the default value of EMACSLOADPATH (bug#10208).
5849
7efa6272
GM
58502011-12-07 Glenn Morris <rgm@gnu.org>
5851
5852 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5853 installation and source directories as well. (Bug#10208)
5854
f6fc4d87
CY
58552011-12-06 Chong Yidong <cyd@gnu.org>
5856
5857 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5858
2bf26180
GM
58592011-12-06 Glenn Morris <rgm@gnu.org>
5860
5861 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5862 as an error, not just -1. (Bug#10217)
5863
3a6ad4f0
CY
58642011-12-05 Chong Yidong <cyd@gnu.org>
5865
5866 * keyboard.c (process_special_events): New function.
5867 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5868
75a3b399
PE
58692011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5870
5871 * coding.c (encode_designation_at_bol): Don't use uninitialized
5872 local variable (Bug#9318).
5873
c3c9e25e
KH
58742011-12-05 Kenichi Handa <handa@m17n.org>
5875
5876 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5877 return Qnil (Bug#8046, Bug#10193).
5878
5eb05ea3
KH
58792011-12-05 Kenichi Handa <handa@m17n.org>
5880
5881 * coding.c (encode_designation_at_bol): New args charbuf_end and
5882 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5883 (coding_set_source): Return how many bytes coding->source was
5884 relocated.
5885 (coding_set_destination): Return how many bytes
5886 coding->destination was relocated.
5887 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5888 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5889
58902011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5891
5892 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5893 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5894 macro (Bug#9318).
5895
58962011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5897
5898 The following changes are to fix Bug#9318.
5899
a79703f5 5900 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5901 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5902 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5903 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5904
7dbda6df
JB
59052011-12-05 Juanma Barranquero <lekktu@gmail.com>
5906
5907 * lisp.h (process_quit_flag): Fix external declaration.
5908
6d5eb5b0
SM
59092011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5910
5911 Don't macro-inline non-performance-critical code.
5912 * eval.c (process_quit_flag): New function.
5913 * lisp.h (QUIT): Use it.
5914
a0c3fad0
JD
59152011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5916
5917 * nsfns.m (get_geometry_from_preferences): New function.
5918 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5919
6c07aac2
AS
59202011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5921
5922 * emacs.c (Qkill_emacs): Define.
5923 (syms_of_emacs): Initialize it.
5924 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5925 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5926 (quit_throw_to_read_char): Add parameter `from_signal'.
5927 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5928 * lisp.h (QUIT): Call Fkill_emacs if requested.
5929
c052ead4
JD
59302011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5931
5932 * widget.c (update_wm_hints): Return if wmshell is null.
5933 (widget_update_wm_size_hints): New function.
5934
5935 * widget.h (widget_update_wm_size_hints): Declare.
5936
5937 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5938 widget_update_wm_size_hints (Bug#10104).
5939
9e49252b
EZ
59402011-12-03 Eli Zaretskii <eliz@gnu.org>
5941
5942 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5943 before a newline, prepare the bidi iterator for consuming the
5944 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5945 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5946
02b16839
JL
59472011-12-02 Juri Linkov <juri@jurta.org>
5948
5949 * search.c (Fword_search_regexp): New Lisp function created from
5950 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5951 (Fword_search_backward, Fword_search_forward)
5952 (Fword_search_backward_lax, Fword_search_forward_lax):
5953 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5954 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5955
0068070e
SM
59562011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5957
5958 * fileio.c (Finsert_file_contents): Move after-change-function call
5959 to before the "handled:" label, since all "goto handled" appear in
5960 cases where the *-change-functions have already been properly called
5961 (bug#10117).
5962
3360a3fc
AS
59632011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5964
5965 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5966 waiting for input. (Bug#10169)
5967
73d6c093
EZ
59682011-11-30 Eli Zaretskii <eliz@gnu.org>
5969
5970 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5971 verifies glyph row's hash code--we have just reallocated the
5972 glyphs, so their contents can be complete garbage. (Bug#10164)
5973
febe6bea
JB
59742011-11-30 Juanma Barranquero <lekktu@gmail.com>
5975
5976 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5977
801a4313
EZ
59782011-11-30 Eli Zaretskii <eliz@gnu.org>
5979
5980 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5981 attributes are tested _before_ calling verify_row_hash, to protect
5982 against GCC re-ordering of the tests. (Bug#10164)
5983
2b56b87e
JD
59842011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5985
5986 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5987
5988 * xterm.c (handle_one_xevent): Only set async_visible and friends
5989 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5990 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5991 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5992
dbf31225
PE
59932011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5994
5995 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5996 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5997 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5998 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5999 All uses changed to use GCPRO1 etc.
6000 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6001 Revert to old implementation (i.e., before 2011-03-11).
6002
1305621b
YM
60032011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6004
6005 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6006 of scroll runs so as to avoid assigning disabled bogus rows and
6007 unnecessary graphics copy operations.
6008
8c9afb46
EZ
60092011-11-27 Eli Zaretskii <eliz@gnu.org>
6010
6011 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6012 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6013 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6014 (malloc, free, realloc, calloc): Redirect to e_* only when
6015 compiling Emacs.
6016
6017 * lisp.h (GCTYPEBITS): Move before first use.
6018 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6019 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6020 this macro definition.
6021
6022 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6023 _MSC_VER.
6024
54e9e3bf
JD
60252011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6026
6d5eb5b0
SM
6027 * gtkutil.c (xg_create_frame_widgets):
6028 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6029 present with Gtk+ 2.0.
6030
83aca1cb
PE
60312011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6032
6033 * fileio.c (Finsert_file_contents): Undo previous change; see
6034 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6035
5b76caa4
PE
60362011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6037
6038 Rename locals to avoid shadowing.
6039 * fileio.c (Finsert_file_contents):
6040 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6041 * process.c (wait_reading_process_output):
6042 Rename inner 'proc' to 'p' to avoid shadowing.
6043 Indent for consistency with usual Emacs style.
6044
8c535114
EZ
60452011-11-25 Eli Zaretskii <eliz@gnu.org>
6046
6047 * xdisp.c (redisplay_window): If cursor row is not fully visible
6048 after recentering, and scroll-conservatively is set to a large
6049 number, scroll window by a few more lines to make the cursor fully
6050 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6051 (start_display): Don't move to the next line if the display should
6052 start at a newline that is part of a display vector or an overlay
6053 string. (Bug#10119)
8c535114 6054
fa4fdb5c
JL
60552011-11-24 Juri Linkov <juri@jurta.org>
6056
6057 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6058 after the `MagickPingImage' call. (Bug#10112)
6059
90ec88df
CY
60602011-11-23 Chong Yidong <cyd@gnu.org>
6061
6062 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6063
56e2e794
MR
60642011-11-23 Martin Rudalics <rudalics@gmx.at>
6065
6066 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6067 making another buffer current. (Bug#10114)
6068
b6e64c41
GM
60692011-11-23 Glenn Morris <rgm@gnu.org>
6070
6071 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6072
6b21de18
CY
60732011-11-23 Chong Yidong <cyd@gnu.org>
6074
6075 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6076 using it (Bug#5984).
6077
b12cd789
EZ
60782011-11-22 Eli Zaretskii <eliz@gnu.org>
6079
6080 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6081 and header-lines, as they don't have one computed for them.
6082 (Bug#10098)
6083
6084 * .gdbinit (prow): Make displayed values more self-explaining.
6085 Add row's hash code.
6086
261b6fd4
LMI
60872011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6088
6089 * process.c (wait_reading_process_output): Fix asynchrounous
6090 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6091 (wait_reading_process_output): Add comment and URL.
261b6fd4 6092
e7cfd277
JD
60932011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6094
6095 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6096
a9b9b7f5
CY
60972011-11-21 Chong Yidong <cyd@gnu.org>
6098
6099 * window.c (Fnext_window, Fprevious_window): Doc fix.
6100
b0d15b4f
SM
61012011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6102
6103 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6104
fe7a3057
JB
61052011-11-20 Juanma Barranquero <lekktu@gmail.com>
6106
6107 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6108
d2999b1a
MR
61092011-11-20 Martin Rudalics <rudalics@gmx.at>
6110
6111 * window.c (Fset_window_combination_limit): Rename argument
6112 STATUS to LIMIT.
6113 (Vwindow_combination_limit): Remove "status" from doc-string.
6114
d5ff9cd0
AS
61152011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6116
6117 * m/ibms390.h: Remove.
6118 * m/ibms390x.h: Don't include "ibms390.h".
6119
a5bb9bd3
SM
61202011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6121
6122 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6123 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6124
cd1181db
JB
61252011-11-20 Juanma Barranquero <lekktu@gmail.com>
6126
6127 * casetab.c (Fset_case_table):
6128 * charset.c (Fcharset_after): Fix typos.
6129
615a3b8d 61302011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6131
17e845af
PE
6132 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6133 Otherwise, valgrind does not work on some platforms.
6134 Problem reported by Andreas Schwab in
6a0bf43d
PE
6135 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6136 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6137 is set, removing the need for VIRT_ADDRESS_VARIES.
6138 (PURE_P): Use a more-efficient implementation that needs just one
6139 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6140 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6141 to 4 (xorl, subq, cmpq, setbe).
6142 * alloc.c (pure): Always extern now, since that's the
6143 VIRT_ADDR_VARIES behavior.
6144 (PURE_POINTER_P): Use a single comparison, not two, for
6145 consistency with the new puresize.h.
6146 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6147 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6148 Remove VIRT_ADDR_VARIES no longer needed.
6149
f8fe6f96
EZ
61502011-11-19 Eli Zaretskii <eliz@gnu.org>
6151
6152 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6153 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6154 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6155 behave as if the cursor position were at the window margin.
6156
6157 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6158 and the cursor position is out of bounds, behave as if the cursor
6159 position were at the window margin. (Bug#10075)
6160
df05a53c
CY
61612011-11-18 Chong Yidong <cyd@gnu.org>
6162
6163 * window.c (Fwindow_combination_limit): Make first argument
6164 non-optional, since it is meaningless for live windows like the
6165 selected window.
61ccba97 6166
2071918e
DA
61672011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6168
6169 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6170
b50a28de
SM
61712011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6172
6173 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6174 (graft_intervals_into_buffer): Simplify.
6175
015137db
EZ
61762011-11-18 Eli Zaretskii <eliz@gnu.org>
6177
6178 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6179 hash values of the two rows.
6180 (copy_row_except_pointers): Preserve the used[] arrays and the
6181 hash values of the two rows. (Bug#10035)
68c95424 6182 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6183
6184 * xdisp.c (row_hash): New function, body extracted from
6185 compute_line_metrics.
6186 (compute_line_metrics): Call row_hash, instead of computing the
6187 hash code inline.
6188
6189 * dispnew.c (verify_row_hash): Call row_hash for computing the
6190 hash code of a row, instead of duplicating code from xdisp.c.
6191
6192 * dispextern.h (row_hash): Add prototype.
6193
a2addb04
TH
61942011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6195
6196 * frame.c (delete_frame): Don't delete the terminal when the last
6197 X frame is closed if emacs is built with GTK toolkit.
6198
df85d315
JB
61992011-11-17 Juanma Barranquero <lekktu@gmail.com>
6200
6201 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6202
a0c2d0ae
MR
62032011-11-17 Martin Rudalics <rudalics@gmx.at>
6204
6205 * window.c (Vwindow_splits): Rename to
6206 Vwindow_combination_resize. Suggested by Juri Linkov.
6207 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6208 of Vwindow_splits.
6209
58179cce
JB
62102011-11-16 Juanma Barranquero <lekktu@gmail.com>
6211
7877f373
JB
6212 * nsfns.m (Fns_font_name):
6213 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6214
b6f67890
MR
62152011-11-16 Martin Rudalics <rudalics@gmx.at>
6216
6217 * window.h (window): Rename slot "nest" to "combination_limit".
6218 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6219 (Fset_window_nest): Rename to Fset_window_combination_limit.
6220 (Vwindow_nest): Rename to Vwindow_combination_limit.
6221 (recombine_windows, make_parent_window, make_window)
6222 (Fsplit_window_internal, saved_window)
6223 (Fset_window_configuration, save_window_save): Rename all
6224 occurrences of window_nest to window_combination_limit.
6225
c7015153
JB
62262011-11-15 Juanma Barranquero <lekktu@gmail.com>
6227
6228 * image.c (imagemagick_load_image): Fix typo.
6229
322ad6ec
EZ
62302011-11-14 Eli Zaretskii <eliz@gnu.org>
6231
6232 * xdisp.c (display_line): Move the call to
6233 highlight_trailing_whitespace before the call to
6234 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6235 faces of all the glyphs to compute ROW's hash value.
6236 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6237
f067b8ec
JB
62382011-11-14 Juanma Barranquero <lekktu@gmail.com>
6239
6240 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6241 just return (bug#10044).
6242
1e5b2111
EZ
62432011-11-12 Eli Zaretskii <eliz@gnu.org>
6244
7ef3cbd5
EZ
6245 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6246 with user-defined heap size. Bump the default size of the temacs
6247 heap to 27MB, to avoid memory warning when running temacs.
6248 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6249
1e5b2111
EZ
6250 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6251 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6252 (verify_row_hash) [XASSERTS]: New function.
6253 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6254 that the hash value of glyph rows is correct.
1e5b2111 6255
89d61221
MR
62562011-11-12 Martin Rudalics <rudalics@gmx.at>
6257
6258 * window.h (window): Remove splits slot.
6259 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6260 (Fdelete_other_windows_internal, make_parent_window)
6261 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6262 (Fset_window_configuration, save_window_save): Don't deal with
6263 split status of windows.
6264 (saved_window): Remove splits slot.
6265 (Vwindow_splits): Rewrite doc-string.
6266
97f18cc8
JD
62672011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6268
6269 * xfns.c (unwind_create_frame):
6270 * nsfns.m (unwind_create_frame):
6271 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6272 Vframe_list (Bug#9999).
6273
22a648b4
DA
62742011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6275
0b381c7e 6276 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6277
659afede
KH
62782011-11-11 Kenichi Handa <handa@m17n.org>
6279
6280 * callproc.c (Fcall_process): Set the member dst_multibyte of
6281 process_coding.
6282
9ac0394b
KH
62832011-11-11 Johan Bockgård <bojohan@gnu.org>
6284
6285 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6286 avoid a crash (bug#9496).
6287
2fbdc249
CY
62882011-11-09 Chong Yidong <cyd@gnu.org>
6289
6290 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6291 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6292
ac6b1f81
PE
62932011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6294
6295 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6296
09db192c
PE
62972011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6298
6299 Avoid some portability problems by eschewing 'extern inline' functions.
6300 The trivial performance wins aren't worth the portability hassles; see
6301 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6302 et seq.
6303 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6304 (window_box_width, window_box_left, window_box_left_offset)
6305 (window_box_right, window_box_right_offset): Undo previous change,
6306 by removing the "extern"s.
6307 * intervals.c (adjust_intervals_for_insertion)
6308 (adjust_intervals_for_deletion): Undo previous change,
6309 making these static again.
6310 (offset_intervals, temp_set_point_both, temp_set_point)
6311 (copy_intervals_to_string): No longer inline.
6312 * xdisp.c (window_text_bottom_y, window_box_width)
6313 (window_box_height, window_box_left_offset)
6314 (window_box_right_offset, window_box_left, window_box_right)
6315 (window_box): No longer inline.
6316
105216ed
CY
63172011-11-08 Chong Yidong <cyd@gnu.org>
6318
6319 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6320 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6321 Signal an error if not a live window.
105216ed
CY
6322 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6323 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6324
ae9e237f
JB
63252011-11-07 Juanma Barranquero <lekktu@gmail.com>
6326
6327 * lisp.h (syms_of_abbrev): Remove declaration.
6328 Reported by CHENG Gao <chenggao@royau.me>.
6329
c7aa8333
EZ
63302011-11-07 Eli Zaretskii <eliz@gnu.org>
6331
6332 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6333 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6334 of temacs in GUI mode.
6335
be7f5545
MR
63362011-11-07 Martin Rudalics <rudalics@gmx.at>
6337
6338 * window.h: Declare delete_all_child_windows instead of
6339 delete_all_subwindows.
6340 * window.c (Fwindow_nest, Fset_window_nest)
6341 (Fset_window_new_total, Fset_window_new_normal)
6342 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6343 (delete_all_subwindows): Rename to delete_all_child_windows.
6344 (Fdelete_other_windows_internal, Fset_window_configuration):
6345 Call delete_all_child_windows instead of delete_all_subwindows.
6346 * frame.c (delete_frame): Call delete_all_child_windows instead
6347 of delete_all_subwindows.
6348
ca78dc43
PE
63492011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6350
6351 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6352 This is also needed for porting to any host where GC_MARK_STACK is
6353 not GC_MAKE_GCPROS_NOOPS.
6354 (which_symbols): Use it.
6355
a0241d01
KH
63562011-11-07 Kenichi Handa <handa@m17n.org>
6357
6358 * coding.c (coding_set_destination): Check coding->src_pos only
6359 when coding->src_object is a buffer (bug#9910).
6360
6361 * process.c (send_process): Set the member src_multibyte of coding
6362 to 0 (bug#9911) when sending a unibyte text.
6363
6364 * callproc.c (Fcall_process): Set the member src_multibyte of
6365 process_coding to 0 (bug#9912).
6366
a64bfdfa 63672011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6368
6369 * xmenu.c (cleanup_widget_value_tree): New function.
6370 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6371 calling free_menubar_widget_value_tree directly (Bug#9830).
6372
cb41b32a
PE
63732011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6374
6375 Fix some portability problems with 'inline'.
6376 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6377 (window_box_width, window_box_left, window_box_left_offset)
6378 (window_box_right, window_box_right_offset): Declare extern.
6379 Otherwise, these inline functions do not conform to C99 and
6380 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6381 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6382 * intervals.c (adjust_intervals_for_insertion)
6383 (adjust_intervals_for_deletion): Now extern, because otherwise the
6384 extern inline functions 'offset_intervals' couldn't refer to it.
6385 (static_offset_intervals): Remove.
6386 (offset_intervals): Rewrite using the old contents of
6387 static_offset_intervals. The old version didn't conform to C99
6388 because an extern inline function contained a reference to an
6389 identifier with static linkage.
6390
b7041366
AS
63912011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6392
6393 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6394 GC.
6395
88a37c4d
EZ
63962011-11-06 Eli Zaretskii <eliz@gnu.org>
6397
6398 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6399 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6400 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6401 return Qleft_to_right.
6402
49745b39
CY
64032011-11-06 Chong Yidong <cyd@gnu.org>
6404
6405 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6406 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6407 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6408 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6409 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6410 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6411 (Fwindow_vscroll): Doc fix.
6412 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6413 argument, since it makes no sense to pass a live window and for
6414 consistency with window-child.
6415
1f05cd82
CS
64162011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6417
6418 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6419 support MSVC.
6420
22610910
JR
64212011-11-05 Jason Rumney <jasonr@gnu.org>
6422
6423 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6424 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6425 fonts (Bug#6029).
6426 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6427 bitwise arithmetic preventing use of unicode-sip and non-truetype
6428 opentype fonts.
6429
a06776b2
EZ
64302011-11-05 Eli Zaretskii <eliz@gnu.org>
6431
3ad924ba
EZ
6432 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6433 "emacs"-only part.
6434
a06776b2
EZ
6435 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6436 initialization code to keep similarity to xfns.c after changes
6437 from 2011-11-05.
6438
c9e7db78
JD
64392011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6440
a97f8f3f
JD
6441 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6442 (unwind_create_frame): New function (Bug#9943).
6443 (Fx_create_frame): Restructure code to be more similar to the one in
6444 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6445 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6446 Move terminal->reference_count++ just before making the frame official
6447 (Bug#9943).
6448
6449 * nsterm.m (x_free_frame_resources): New function.
6450 (x_destroy_window): Move code to x_free_frame_resources.
6451
c9e7db78 6452 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6453 (Fx_create_frame, x_create_tip_frame):
6454 Move terminal->reference_count++ just before making the frame
75f1671a 6455 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6456 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6457
a6fc3b5c
EZ
64582011-11-05 Eli Zaretskii <eliz@gnu.org>
6459
6460 Support MSVC build with newer versions of Visual Studio.
6461 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6462 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6463 nt/gmake.defs.
6464
6465 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6466 which are not supported by MSVC.
6467 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6468 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6469 bitfields.
6470 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6471 types in bitfields.
6472 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6473
6474 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6475
58179cce 64762011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6477
6478 Support MSVC build with newer versions of Visual Studio.
6479 * w32.c: Don't include w32api.h for MSVC.
6480 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6481
6482 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6483 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6484 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6485 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6486 e_* cousins.
6487 (alloca) [_MSC_VER]: Define to _alloca.
6488
6489 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6490
6491 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6492
a58c13ed
EZ
64932011-11-04 Eli Zaretskii <eliz@gnu.org>
6494
6495 * xdisp.c (note_mouse_highlight): If either of
6496 previous/next-single-property-change returns nil, treat that as
6497 the beginning or the end of the buffer. (Bug#9955)
6498
fe0b6370
JD
64992011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6500
a58c13ed 6501 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6502 label is not null (Bug#9951).
6503 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6504 may be NULL.
6505
89bd5ee1
EZ
65062011-11-04 Eli Zaretskii <eliz@gnu.org>
6507
6508 * window.c (Fwindow_body_size): Mention in the doc string that the
6509 return value is in frame's canonical units. (Bug#9949)
6510
84c3edb9
EZ
65112011-11-03 Eli Zaretskii <eliz@gnu.org>
6512
4e2fb5c7
EZ
6513 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6514
84c3edb9 6515 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6516 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6517 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6518
bc17a887
EZ
65192011-11-01 Eli Zaretskii <eliz@gnu.org>
6520
6521 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6522 Don't stop backward scan on the continuation glyph, even though
6523 its CHARPOS is positive.
6d5eb5b0
SM
6524 (mouse_face_from_buffer_pos, note_mouse_highlight):
6525 Rename cover_string to disp_string.
bc17a887 6526
4ee88440
MR
65272011-11-01 Martin Rudalics <rudalics@gmx.at>
6528
6529 * window.c (temp_output_buffer_show): Don't use
6530 Vtemp_buffer_show_specifiers.
6531 (Vtemp_buffer_show_specifiers): Remove unused variable.
6532
c2ff3c02
EZ
65332011-10-30 Eli Zaretskii <eliz@gnu.org>
6534
6535 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6536 past the beginning of the current glyph matrix.
6537
58179cce 65382011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6539
6540 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6541 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6542 HAVE_GTK3 (Bug#9869).
b77a6a7f 6543
3b574623
JD
6544 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6545 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6546
b77a6a7f
JD
6547 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6548
6549 * xterm.c: Declare x_handle_net_wm_state to return int.
6550 (handle_one_xevent): Check if we are iconified but don't have
6551 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6552 (get_current_wm_state): Return non-zero if not hidden,
6553 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6554 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6555 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6556 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6557
196e41e4
PE
65582011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6559
6560 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6561 so that this new function doesn't get optimized away by a
6562 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6563
021f2e1a
AS
65642011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6565
6566 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6567
8b058d44
EZ
65682011-10-29 Eli Zaretskii <eliz@gnu.org>
6569
6570 Fix the `xbytecode' command.
6571 * .gdbinit (xprintbytestr): New command.
b50a28de 6572 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6573 (xbytecode): Print the byte-code string as well.
6574
4452fb80
EZ
65752011-10-29 Kim Storm <storm@cua.dk>
6576
8b058d44
EZ
6577 * alloc.c (which_symbols): New function.
6578
21b72067
AS
65792011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6580
6581 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6582 line. (Bug#9903)
6583
83ed7b5c
GM
65842011-10-29 Glenn Morris <rgm@gnu.org>
6585
6586 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6587 Not clear what it was for, and it causes various bugs. (Bug#9839)
6588
5a7a728b
EZ
65892011-10-28 Eli Zaretskii <eliz@gnu.org>
6590
6591 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6592 possible random value that matches one of those tested as
6593 condition to clear the mouse face.
6594
d3d0842f
CY
65952011-10-28 Chong Yidong <cyd@gnu.org>
6596
6597 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6598
31b39d13
DN
65992011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6600
6601 * window.c (make_window): Initialize phys_cursor_on_p.
6602
9aba6043
SM
66032011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6604
6605 * lisp.h (struct Lisp_Symbol): Update comments.
6606
c20992f4
JB
66072011-10-28 Juanma Barranquero <lekktu@gmail.com>
6608
6609 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6610
db4f02f2
EZ
66112011-10-28 Eli Zaretskii <eliz@gnu.org>
6612
6613 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6614 <oslsachem@gmail.com> for helping to debug this.
6615
6616 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6617 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6618 (g_b_init_get_glyph_outline_w): New static variables.
6619 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6620 (GetGlyphOutlineW_Proc): New typedefs.
6621 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6622 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6623 New functions.
6624 (w32font_open_internal, compute_metrics):
6625 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6626 instead of calling the "wide" APIs directly.
6627
6628 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6629
6630 * w32.h (syms_of_w32font): Add prototype.
6631
87e68db4
JB
66322011-10-27 Juanma Barranquero <lekktu@gmail.com>
6633
6634 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6635 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6636 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6637 (Fmove_to_window_line): Doc fix.
6638
435c1d67
CY
66392011-10-27 Chong Yidong <cyd@gnu.org>
6640
6641 * process.c (make_process): Set gnutls_state to NULL.
6642
6643 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6644 non-NULL, regardless of GNUTLS_INITSTAGE.
6645 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6646 an error. Set process slots as soon as we allocate them.
6647
6648 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6649
9c6c6f49
CY
66502011-10-27 Chong Yidong <cyd@gnu.org>
6651
9aba6043
SM
6652 * gnutls.c (emacs_gnutls_deinit): New function.
6653 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6654 (Fgnutls_deinit, Fgnutls_boot): Use it.
6655
6656 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6657 (deactivate_process): Call emacs_gnutls_deinit.
6658
657d08d3
JB
66592011-10-27 Juanma Barranquero <lekktu@gmail.com>
6660
6661 * image.c (x_create_x_image_and_pixmap):
6662 * w32.c (sys_rename, w32_delayed_load):
6663 * w32font.c (fill_in_logfont):
6664 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6665
5430d399
JB
66662011-10-26 Juanma Barranquero <lekktu@gmail.com>
6667
6668 * w32fns.c (w32_default_color_map): New function,
6669 extracted from Fw32_default_color_map.
a7ef684b 6670 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6671
fe0055fa
PE
66722011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6673
6674 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6675
e6346438
SM
66762011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6677
6678 * keyboard.c (test_undefined): New function (bug#9751).
6679 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6680
e112cc37
ET
66812011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6682
6683 * sysdep.c (init_sys_modes): Fix the check for the controlling
6684 terminal (Bug#6649).
6685
7b5d6677
EZ
66862011-10-20 Eli Zaretskii <eliz@gnu.org>
6687
6688 * dispextern.h (struct bidi_it): New member next_en_type.
6689
6690 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6691 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6692 current character, check also for next_en_type being WEAK_EN.
6693 (bidi_resolve_weak): Don't enter the expensive loop if the current
6694 position is before next_en_pos. Record the bidi type of the first
6695 non-ET, non-BN character we find, in addition to its position.
6696 (bidi_level_of_next_char): Invalidate next_en_type when
6697 next_en_pos is over-stepped.
6698
7da0b018
PE
66992011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6700
6701 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6702 * editfns.c: Rewrite current-time-zone so that it invokes
6703 the equivalent of (format-time-string "%Z") to get the time zone name.
6704 This fixes a bug when the time zone name contains characters that
6705 need converting from the system time locale to Emacs internal format.
6706 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6707 that patch fixed format-time-string to do the conversion, but
6708 I forgot to fix current-time-zone.
6709 (format_time_string): New function, containing most of
6710 what Fformat_time_string used to contain.
6711 (Fformat_time_string): Rewrite in terms of format_time_string.
6712 This doesn't change this function's behavior.
6713 (current-time-zone): Rewrite to use format_time_string.
6714 This fixes the bug reported by Michael Schierl in
6715 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6716 Jason Rumney's 2007-06-07 change worked around this bug, but
6717 didn't fix it.
6718 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6719
8547b010
EZ
67202011-10-19 Eli Zaretskii <eliz@gnu.org>
6721
6722 * xdisp.c (start_display): If the character at POS is displayed
6723 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6724 (try_window_reusing_current_matrix): If a line ends in a display
6725 vector or the next line starts in a display vector, continue
6726 redrawing the window even though the character position of
6727 start_row was reached.
8547b010
EZ
6728 (Bug#9771, part 2)
6729
4e948d15
CY
67302011-10-18 Chong Yidong <cyd@gnu.org>
6731
6732 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6733 with nobreak-char-display too.
6734
4787455f
EZ
67352011-10-18 Eli Zaretskii <eliz@gnu.org>
6736
6737 Fix part 3 of bug#9771.
6738 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6739 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6740 non-neutral characters if the current character is a paragraph
6741 separator (a.k.a. Newline). This avoids running the same
6742 expensive loop twice, once when we consume the preceding newline
6743 and the other time when the line actually needs to be displayed.
6744 Avoid the loop when we see neutrals on the base embedding level
6745 following a character whose directionality is the same as the
6746 paragraph's. This avoids running the expensive loop when a line
6747 ends in a long sequence of neutrals, like control characters.
6748 Add assertion against STRONG_AL type. Slightly rearrange code
6749 that determines the type of a neutral given the first non-neutral
6750 that follows it.
6751 (bidi_level_of_next_char): Set next_en_pos to zero when
6752 invalidating its info.
6753
2c91f553
EZ
67542011-10-17 Eli Zaretskii <eliz@gnu.org>
6755
6756 * xdisp.c (push_display_prop): Determine whether to record string
6757 or buffer position by IT->string, not by IT->method. Allow
6758 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6759 (move_it_vertically_backward): Don't look for character position
6760 immediately after the newline when in a continuation line.
6761 (Bug#9771, part 1)
2c91f553 6762
c7b08b0d
MR
67632011-10-15 Martin Rudalics <rudalics@gmx.at>
6764
6765 * window.c (coordinates_in_window): Rewrite and delabelize
6766 vertical border check. (Bug#5357) (Bug#9618)
6767
6b02f655
SM
67682011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6769
6770 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6771 errors in XSetWindowBorder (bug#9310).
6772
81d40c92
DA
67732011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6774
6775 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6776 avoid crash when xmalloc overrun checking is enabled.
6777
d4172c3b
EZ
67782011-10-13 Eli Zaretskii <eliz@gnu.org>
6779
6780 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6781 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6782 cursor motion with <left> and <right> arrow keys.
6783
6784 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6785 some callers set that themselves.
6786
b00eea75
EZ
67872011-10-12 Eli Zaretskii <eliz@gnu.org>
6788
6789 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6790 display string and the previous row comes from the same string and
6791 is empty. (Bug#9739) (Bug#9738)
6792
8fe012c4
SM
67932011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6794
6795 * doc.c (get_doc_string): Encode file name (bug#9735).
6796
0074aef2
EZ
67972011-10-12 Eli Zaretskii <eliz@gnu.org>
6798
79beb178
EZ
6799 * bidi.c (bidi_level_of_next_char):
6800 * xdisp.c (get_visually_first_element): Remove old incorrect
6801 comments regarding the Unicode Line Separator character.
6802
0074aef2
EZ
6803 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6804
6e4b3fbe
DA
68052011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6806
6807 * alloc.c (Fgc_status): Do not access beyond zombies array
6808 boundary if nzombies > MAX_ZOMBIES.
6809 * alloc.c (dump_zombies): Add missing format specifier.
6810
0324f3af
PE
68112011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6812
b5525cac
PE
6813 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6814 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6815
0324f3af
PE
6816 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6817 Some packages use them to denote characters with modifiers.
6818
e9b5f888
AS
68192011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6820
6821 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6822 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6823 matching a pp-number. Rename parameter var to var1.
6824
127827c0
SM
68252011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6826
6827 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6828
c8fd3bd0
GM
68292011-10-08 Glenn Morris <rgm@gnu.org>
6830
6831 * callint.c (Fcall_interactively): Give a more explicit error for the
6832 'c' case with a non-character input. (Bug#8479)
6833
352ec8ff
EZ
68342011-10-08 Eli Zaretskii <eliz@gnu.org>
6835
03669ccb
EZ
6836 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6837 lines.
7061c986
EZ
6838 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6839 lines that are hscrolled on the left.
03669ccb 6840
352ec8ff
EZ
6841 * dispnew.c (buffer_posn_from_coords): Account for a possible
6842 presence of header-line. (Bug#4426)
6843
a66cfb1c
SM
68442011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6845
6b02f655
SM
6846 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6847 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6848
7c5ee88e
PE
68492011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6850
6851 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6852 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6853 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6854 this makes Emacs dump core during garbage collection on rare
6855 occasions. sizeof is obviously inferior to offsetof here, so
6856 stick with offsetof.
6857 (GC_POINTER_ALIGNMENT): New macro.
6858 (mark_memory): Omit 3rd (offset) arg; caller changed.
6859 Don't assume EMACS_INT alignment is the same as pointer alignment.
6860
df1bbe5b
SM
68612011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6862
6863 * keyboard.c (read_key_sequence_remapped): New var.
6864 (read_key_sequence): Compute remapping in the right buffer.
6865 (command_loop_1): Use read_key_sequence's remapping directly.
6866
51553db6
SM
68672011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6868
32c1fffd
SM
6869 * dired.c (file_name_completion): Don't expand file name.
6870 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6871 before checking file name handler.
6872
51553db6
SM
6873 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6874 they've been requested explicitly (bug#9591).
6875
b6bd1599 68762011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6877
6878 * keymap.c (Fsingle_key_description): Use make_specified_string
6879 instead of build_string to build string from push_key_description.
6880 (Bug#5193)
6881
f701dc2a
PE
68822011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6883
4222c55d
PE
6884 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6885 This fixes a Y2038 bug on 64-bit hosts.
6886 * buffer.c (reset_buffer):
6887 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6888 (Fclear_buffer_auto_save_failure):
6889 Use 0, not -1, to represent an unset failure time, since time_t
6890 might not be signed.
6891
f701dc2a
PE
6892 Remove dependency on glibc malloc internals.
6893 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6894 Move back here from lisp.h, but with their new implementations.
6895 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6896 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6897 * charset.c (charset_table_init): New static var.
6898 (syms_of_charset): Use it instead of xmalloc. This removes a
6899 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6900 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6901 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6902 Move back to alloc.c.
6903 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6904 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6905
9ceebf39
JD
69062011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6907
6908 * nsterm.m (windowDidResize): Call x_set_window_size only when
6909 ns_in_resize is true. Otherwise set pixelwidth/height and
6910 call change_frame_size (Bug#9628).
6911
cb993c58
PE
69122011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6913
3930c88b
PE
6914 Port --enable-checking=all to Fedora 14 x86-64.
6915 * charset.c (syms_of_charset): Also account for glibc malloc's
6916 internal overhead when calculating the initial malloc maximum.
6917
cb993c58
PE
6918 Port --enable-checking=all to Fedora 14 x86.
6919 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6920 Move to lisp.h.
6921 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6922 (overrun_check_realloc, overrun_check_free):
6923 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6924 That way, xmalloc returns a properly-aligned pointer even if
6925 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6926 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6927 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6928 into account when calculating the initial malloc maximum.
6929 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6930 Move here from alloc.c, so that charset.c can use it too.
6931 Properly align; the old code wasn't right for common 32-bit hosts
6932 when configured with --enable-checking=all.
6933 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6934 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6935
31bed486
EZ
69362011-09-29 Eli Zaretskii <eliz@gnu.org>
6937
04c70788 6938 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6939 use EDOM.
6940
fbcaa2f3
EZ
69412011-09-28 Eli Zaretskii <eliz@gnu.org>
6942
6943 * xdisp.c (compute_display_string_end): If there's no display
6944 string at CHARPOS, return -1.
6945
6946 * bidi.c (bidi_fetch_char): When compute_display_string_end
6947 returns a negative value, treat the character as a normal
6948 character not covered by a display string. (Bug#9624)
6949
a239d4e9
JB
69502011-09-28 Juanma Barranquero <lekktu@gmail.com>
6951
6952 * lread.c (Fread_from_string): Fix typo in docstring.
6953
88652fd5
EZ
69542011-09-27 Eli Zaretskii <eliz@gnu.org>
6955
6956 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6957 newline, reseat the iterator instead of bidi-iterating there one
6958 character at a time. (Bug#9610)
32c1fffd
SM
6959 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6960 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6961
ed497dd4
AS
69622011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6963
6964 * lread.c (readevalloop): Use correct code for NBSP.
6965 (read1): Likewise. (Bug#9608)
6966
b2bf61aa
MA
69672011-09-25 Michael Albinus <michael.albinus@gmx.de>
6968
6969 * dbusbind.c (Fdbus_register_signal): When service is not
6970 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6971
32bbb17c
GM
69722011-09-25 Glenn Morris <rgm@gnu.org>
6973
6974 * buffer.c (truncate-lines): Doc fix.
6975
94e0933e
CY
69762011-09-24 Chong Yidong <cyd@stupidchicken.com>
6977
6978 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6979 (Fset_window_next_buffers): Doc fix.
6980
cddde921
GM
69812011-09-24 Glenn Morris <rgm@gnu.org>
6982
6983 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6984
1260aef1
PE
69852011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6986
25b4bfa0
PE
6987 Fix minor problems found by static checking.
6988 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6989 * indent.c (Fvertical_motion): Fix == vs = typo.
6990
e3cbd34b
EZ
69912011-09-24 Eli Zaretskii <eliz@gnu.org>
6992
a66cfb1c
SM
6993 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6994 Default value is now t. Doc fix.
6bf7006f 6995
e3cbd34b 6996 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6997 logic when moving up, not only when moving down. Fix the
e3cbd34b 6998 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6999 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7000
7001 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7002 CHARPOS is covered by a display string which includes newlines.
7003 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7004 is covered by a display string with embedded newlines.
7005
a3de0cbd
MA
70062011-09-24 Michael Albinus <michael.albinus@gmx.de>
7007
7008 * dbusbind.c (Fdbus_register_signal): Add match rule to
7009 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7010 (Fdbus_register_method, Vdbus_registered_objects_table):
7011 Fix docstring.
a3de0cbd 7012
b260039d
JM
70132011-09-24 Jim Meyering <meyering@redhat.com>
7014
32c1fffd 7015 do not ignore write error for any output size
b260039d
JM
7016 The previous change was incomplete.
7017 While it makes emacs --batch detect the vast majority of stdout
7018 write failures, errors were still ignored whenever the output size is
7019 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7020 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7021 && echo FAIL: ignored write error
7022 FAIL: ignored write error
7023 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7024 && echo FAIL: ignored write error
7025 FAIL: ignored write error
7026 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7027
8eca8a7c
AS
70282011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7029
7030 * emacs.c (Fkill_emacs): In noninteractive mode exit
7031 non-successfully if a write error occurred on stdout. (Bug#9574)
7032
3341db62
EZ
70332011-09-21 Eli Zaretskii <eliz@gnu.org>
7034
7035 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7036 the xassert test.
7037
7038 * dispextern.h (struct it): Update the comment documenting what
7039 can it->OBJECT be.
7040
8c203dbf
EZ
70412011-09-20 Eli Zaretskii <eliz@gnu.org>
7042
7043 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7044 a display string, extend search for cursor position to end of row.
7045 (find_row_edges): If the row ends in a newline from a display
7046 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7047 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7048 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7049 non-empty line. Fixes confusing cursor motion with arrow keys at
7050 the beginning of a line that starts with whitespace.
8c203dbf 7051
a4824228
LMI
70522011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7053
7054 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7055 (bug#9493).
7056
33ed493b
CY
70572011-09-18 Chong Yidong <cyd@stupidchicken.com>
7058
7059 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7060 boolean (Bug#9154).
7061
56cd55c8
EZ
70622011-09-18 Eli Zaretskii <eliz@gnu.org>
7063
7064 * xdisp.c (display_line): Record maximum and minimum buffer
7065 positions even if no glyphs were produced (e.g., by a zero-width
7066 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7067 buffer positions that will be removed from the glyph row because
7068 they don't fit.
c02dcedf
EZ
7069 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7070 column is beyond frame width: don't subtract 1 "pixel" when
7071 computing width of the stretch.
3e62b7e0
EZ
7072 (reseat_at_next_visible_line_start): Undo the change made on
7073 2011-09-17 that saved paragraph information and restored it after
7074 the call to `reseat'. (Bug#9545)
56cd55c8 7075
5ed99d36 70762011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7077
7078 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7079 and turn window cursor on if cleared (Bug#9415).
7080
5ed99d36 70812011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7082
7083 * search.c (boyer_moore): Take unibyte characters from pattern
7084 literally. (Bug#9458)
7085
9bade7b2
EZ
70862011-09-18 Eli Zaretskii <eliz@gnu.org>
7087
7088 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7089
e5e9d610
PE
70902011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7091
87e4427a
PE
7092 Fix minor problem found by static checking.
7093 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7094 initialized, to pacify gcc -Wuninitialized.
7095
e5e9d610
PE
7096 * fileio.c: Report proper errno when syscall falls.
7097 (Finsert_file_contents): Save and restore errno,
7098 so that report_file_error outputs the correct diagnostic.
7099 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7100
a1674f0b
EZ
71012011-09-18 Eli Zaretskii <eliz@gnu.org>
7102
7103 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7104
fbfb6dd4
EZ
71052011-09-17 Eli Zaretskii <eliz@gnu.org>
7106
7107 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7108 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7109
bb187662
EZ
71102011-09-17 Eli Zaretskii <eliz@gnu.org>
7111
1137e8b8 7112 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7113 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7114
7115 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7116 (bidi_find_paragraph_start): Search back for paragraph beginning
7117 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7118 (bidi_move_to_visually_next): Only trigger paragraph-related
7119 computations when the last character is a newline or at EOB, not
7120 just any NEUTRAL_B. (Bug#9470)
7121
bb187662
EZ
7122 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7123 truncated lines if point is covered by a display string. (Bug#9524)
7124
2e621251
PE
71252011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7126
7127 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7128 (cons_to_x_long): New function.
7129 (lisp_data_to_selection_data): Use it. Correct the test for
7130 short-versus-long data; it was negated. Break out of vector
7131 loop, for efficiency, when a long datum is discovered.
7132
91a15bc6
SM
71332011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7134
7135 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7136
b41c3a35
EZ
71372011-09-16 Eli Zaretskii <eliz@gnu.org>
7138
7139 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7140 GCC PR/17406) by declaring this function with external scope.
7141
7812ba2d
PE
71422011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7143
7144 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7145 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7146
cf7edc2a
AS
71472011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7148
7149 * editfns.c (Fformat): Correctly handle text properties on "%%".
7150
bd01620e
EZ
71512011-09-15 Eli Zaretskii <eliz@gnu.org>
7152
7153 * xterm.c (x_draw_composite_glyph_string_foreground):
7154 * w32term.c (x_draw_composite_glyph_string_foreground):
7155 * term.c (encode_terminal_code):
7156 * composite.c (composition_update_it, get_composition_id):
7157 * xdisp.c (get_next_display_element)
7158 (fill_composite_glyph_string): Add comments about special meaning
7159 of TAB characters in a composition.
7160
a02719a3
PE
71612011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7162
7163 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7164 This occurs when processing a multibyte format.
7165 Problem reported by Wolfgang Jenker.
a02719a3 7166
72589a3c
JB
71672011-09-15 Johan Bockgård <bojohan@gnu.org>
7168
7169 * xdisp.c (try_cursor_movement): Only check for exact match if
7170 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7171
1c14176c
PE
71722011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7173
7174 Remove unused external symbols.
7175 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7176 * xdisp.c (calc_pixel_width_or_height): Now static.
7177 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7178 * indent.c (check_display_width):
7179 * w32term.c: Fix comment to match code.
7180 * xterm.c, xterm.h (x_catching_errors): Remove.
7181
d2eea5b5
PE
71822011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7183
7184 * xselect.c: Use signed conversions more consistently (Bug#9498).
7185 (selection_data_to_lisp_data): Assume incoming selection data are
7186 signed integers, not unsigned. This is to be consistent with
7187 outgoing selection data, which was modified to use signed integers
7188 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7189 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7190 expects long, not unsigned long.
7191
46888499
EZ
71922011-09-14 Eli Zaretskii <eliz@gnu.org>
7193
7194 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7195 computation of loop end. Reported by Johan Bockgård
7196 <bojohan@gnu.org>.
7197
ef8ef9fb
CY
71982011-09-13 Chong Yidong <cyd@stupidchicken.com>
7199
7200 * frame.c (Fother_visible_frames_p): Function deleted.
7201
fa819fed
EZ
72022011-09-12 Eli Zaretskii <eliz@gnu.org>
7203
7204 * indent.c (compute_motion): Process display vector front to back
7205 rather than the other way around. (Bug#2496)
7206
2ba8e008
SM
72072011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7208
7209 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7210
20f53c69
CY
72112011-09-11 Chong Yidong <cyd@stupidchicken.com>
7212
7213 * minibuf.c (Fread_from_minibuffer): Doc fix.
7214
d562d7a4
EZ
72152011-09-11 Eli Zaretskii <eliz@gnu.org>
7216
7217 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7218 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7219
1c4d7f3d
LMI
72202011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7221
7222 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7223 value for non-existent files.
7224
b885bf36
EZ
72252011-09-11 Eli Zaretskii <eliz@gnu.org>
7226
7227 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7228 set its "size" to -1. This will set the modtime_size field of
7229 the corresponding buffer to -1, which is what
7230 verify-visited-file-modtime expects for files that do not exist.
7231 (Bug#9139)
7232
6612f0bf
PE
72332011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7234
7235 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7236 here ...
7237 * lisp.h: ... from here. push_key_description is no longer
7238 defined in keyboard.c, so its declaration should not be in
7239 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7240 logically belongs with push_key_description.
7241
dfb3f755
PE
72422011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7243
7244 * buffer.h: Include <sys/types.h> instead of <time.h>.
7245 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7246 Problem reported by Herbert J. Skuhra.
7247
3134906c
LMI
72482011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7249
7250 * xml.c (parse_region): Make the parsing work for
7251 non-comment-starting XML files again (bug#9144).
7252
8d903f4e
AS
72532011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7254
7255 * image.c (gif_load): Fix calculation of bottom and right corner.
7256 (Bug#9468)
7257
80ad64f4
EZ
72582011-09-10 Eli Zaretskii <eliz@gnu.org>
7259
7260 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7261 redisplay in small windows.
7262
208a048d
EZ
72632011-09-09 Eli Zaretskii <eliz@gnu.org>
7264
7265 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7266
9b1c252e
MR
72672011-09-08 Martin Rudalics <rudalics@gmx.at>
7268
7269 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7270 Operate on live windows only.
7271
2949f33b
JB
72722011-09-08 Juanma Barranquero <lekktu@gmail.com>
7273
7274 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7275
e08dcafd
EZ
72762011-09-07 Eli Zaretskii <eliz@gnu.org>
7277
7278 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7279 only under bidi iteration.
7280
115b96bd
JD
72812011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7282
7283 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7284
c8199d0f
PE
72852011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7286
7287 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7288 Without this fix, the command to link temacs failed due to an
7289 undefined symbol __builtin_isnan. This is because
7290 /usr/include/iso/math_c99.h #defines isnan(x) to
7291 __builtin_isnan(x), but the bundled gcc, which identifies itself
7292 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7293 a __builtin_isnan.
7294 * floatfns.c (isnan): #undef, and then #define to a clone of
7295 what's in data.c.
7296 (Fisnan): Always define, since it's always available now.
7297 (syms_of_floatfns): Always define isnan at the Lisp level.
7298
e39b275c 72992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7300
7301 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7302
b2db44d9 73032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7304
f4af5137 7305 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7306 The previous code assumed that file offsets (off_t values) fit in
7307 EMACS_INT variables, which is not true on typical 32-bit hosts.
7308 The code messed up by falsely reporting buffer overflow in cases
7309 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7310 when "big" contains more than 2**29 bytes, even though this
7311 inserts just one byte and does not overflow the buffer.
7312 (Finsert_file_contents): Store file offsets as off_t
7313 values, not as EMACS_INT values. Check for overflow when
7314 converting between EMACS_INT and off_t. When checking for
7315 buffer overflow or for overlap, take the offsets into account.
7316 Don't use EMACS_INT for small values where int suffices.
7317 When checking for overlap, fix a typo: ZV was used where
7318 ZV_BYTE was intended.
7319 (Fwrite_region): Don't assume off_t fits into 'long'.
7320 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7321
ecfc0a49
MA
73222011-09-05 Michael Albinus <michael.albinus@gmx.de>
7323
7324 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7325
6511acf2 73262011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7327
0999621a 7328 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7329
7330 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7331 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7332 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7333 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7334 (modify_event_symbol): Do not assume that the length of
7335 name_alist_or_stem is safe to alloca and fits in int.
7336 (Fexecute_extended_command): Likewise for function name and binding.
7337 (Frecursion_depth): Wrap around reliably on integer overflow.
7338 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7339 since some callers pass EMACS_INT values.
7340 (Fsingle_key_description): Don't crash if symbol name contains more
7341 than MAX_ALLOCA bytes.
7342 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7343 (get_minibuffer): Arg is now EMACS_INT, not int.
7344 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7345 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7346 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7347
2be7d702
PE
7348 * dbusbind.c (signature_cat): New function.
7349 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7350 Do not overrun buffer; instead, report string overflow.
7351
9d1df220
PE
7352 * dispnew.c (add_window_display_history): Don't overrun buffer.
7353 Truncate instead; this is OK since it's just a log.
7354
33ef5c64
PE
7355 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7356 even if the time zone offset is outlandishly large.
7357 Don't mishandle offset == INT_MIN.
7358
66c6fdd5
PE
7359 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7360 when creating daemon; the previous buffer-overflow check was incorrect.
7361
d749b01b
PE
7362 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7363 which has the guts of the old verror function.
7364
b5cd1905
PE
7365 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7366 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7367
6e1a67fb
PE
7368 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7369 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7370 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7371 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7372 length of string rather than counting it via multiple sprintfs;
7373 that's simpler and more reliable.
c21721cc
PE
7374 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7375 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7376 sprintf, in case result does not fit in int.
7377
c57b67fc
PE
7378 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7379 (fontset_from_font): Print it.
7380
8a401434
PE
7381 * frame.c (tty_frame_count): Now printmax_t, not int.
7382 (make_terminal_frame, set_term_frame_name): Print it.
7383 (x_report_frame_params): In X, window IDs are unsigned long,
7384 not signed long, so print them as unsigned.
7385 (validate_x_resource_name): Check for implausibly long names,
7386 and don't assume name length fits in 'int'.
7387 (x_get_resource_string): Don't blindly alloca invocation name;
7388 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7389 not fit in int.
7390
6e1a67fb
PE
7391 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7392 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7393 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7394
0df02bf3
PE
7395 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7396 Use esprintf, not sprintf, in case result does not fit in int.
7397
48e30793
PE
7398 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7399 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7400 it as a large positive number.
7401 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7402 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7403
a66ff6d8
PE
7404 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7405 in case result does not fit in int.
7406
aca216ff
PE
7407 * print.c (float_to_string): Detect width overflow more reliably.
7408 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7409 buffer overrun. Don't assume list length fits in 'int'. Treat
7410 print length of 0 as 0, not as infinity; to be consistent with other
7411 uses of print length in this function. Don't overflow print length
7412 index. Don't assume hash table size fits in 'long', or that
7413 vectorlike size fits in 'unsigned long'.
7414
31c286f7
PE
7415 * process.c (make_process): Use printmax_t, not int, to format
7416 process-name gensyms.
7417
55e5faa1
PE
7418 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7419
80f2e268
PE
7420 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7421 to avoid potential buffer overrun.
7422
670741ab
PE
7423 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7424 if X resource line is longer than 512 bytes.
7425
b7163a50
PE
7426 * xfns.c (x_window): Make sprintf buffer a bit bigger
7427 to avoid potential buffer overrun.
7428
ae58ff1f
PE
7429 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7430
c43c8a6a
PE
7431 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7432
3f8236f4
PE
74332011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7434
53e9fe90 7435 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7436 Without these, Emacs silently mishandles large integers sometimes.
7437 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7438 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7439
6511acf2
PE
7440 * xdisp.c (try_window_id): Check Emacs fixnum range before
7441 converting to 'int'.
806add1d 7442
6511acf2 7443 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7444 Check that an Emacs fixnum is in range before assigning it to 'int'.
7445 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7446 values converted from Emacs fixnums.
7447 (Frecenter): Don't wrap around a line count if it is out of 'int'
7448 range; instead, treat it as an extreme value.
7449 (Fset_window_configuration, compare_window_configurations):
7450 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7451
6511acf2
PE
7452 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7453 that can exceed INT_MAX. Check that EMACS_INT value is in range
7454 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7455 (match_limit): Don't assume that a fixnum can fit in 'int'.
7456
6511acf2 7457 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7458 exceed INT_MAX.
7459
6511acf2 7460 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7461 (Fvertical_motion): Don't wrap around LINES values that don't fit
7462 in 'int'. Instead, treat them as extreme values. This is good
7463 enough for windows, which can't have more than INT_MAX lines anyway.
7464
fcb901a7
LMI
74652011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7466
0f2f6b6d
LMI
7467 * Require libxml/parser.h to avoid compilation warning.
7468
fcb901a7
LMI
7469 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7470
7471 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7472 since this reportedly can destroy thread storage.
7473
6e20a0d4
CY
74742011-08-30 Chong Yidong <cyd@stupidchicken.com>
7475
7476 * syntax.c (find_defun_start): Update all cache variables if
7477 exiting early (Bug#9401).
7478
148ae00e
EZ
74792011-08-30 Eli Zaretskii <eliz@gnu.org>
7480
f6cfbd8f
EZ
7481 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7482
148ae00e
EZ
7483 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7484 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7485 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7486
7487 * term.c (tty_append_glyph): New function.
7488 (produce_stretch_glyph): Static function and its prototype deleted.
7489
a66cfb1c
SM
7490 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7491 Add prototypes.
148ae00e 7492
c4a07a4c
PE
74932011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7494
7495 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7496 when checking :margin (Bug#9390).
7497 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7498 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7499 so that the name doesn't mislead. All uses changed.
7500
6bc8cd65
JB
75012011-08-28 Johan Bockgård <bojohan@gnu.org>
7502
7503 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7504 set_tty_hooks.
7505
dca4927e
EZ
75062011-08-27 Eli Zaretskii <eliz@gnu.org>
7507
7508 * xdisp.c (move_it_to): Don't bail out early when reaching
7509 position beyond to_charpos, if we are scanning backwards.
7510 (move_it_vertically_backward): When DY == 0, make sure we get to
7511 the first character in the line after the newline.
7512
f2cad773
PE
75132011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7514
7515 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7516 (ccl_driver): Do not generate an out-of-range pointer.
7517 (Fccl_execute_on_string): Remove unnecessary check for
7518 integer overflow, noted by Stefan Monnier in
7519 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7520 Remove a FIXME that didn't need fixing.
7521 Simplify the newly-introduced buffer reallocation code.
7522
0cae2cdb
JB
75232011-08-27 Juanma Barranquero <lekktu@gmail.com>
7524
7525 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7526
5fc295a4 75272011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7528
70c60eb2 7529 Integer and memory overflow issues (Bug#9196).
726e0ab1 7530
d31850da
PE
7531 * doc.c (get_doc_string): Rework so that
7532 get_doc_string_buffer_size is the actual buffer size, rather than
7533 being 1 less than the actual buffer size; this makes xpalloc more
7534 convenient.
7535
a69fbedb
PE
7536 * image.c (x_allocate_bitmap_record, cache_image):
7537 * xselect.c (Fx_register_dnd_atom):
7538 Simplify previous changes by using xpalloc.
7539
fe5c5d37
PE
7540 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7541 since either will do and ptrdiff_t is convenient with xpalloc.
7542
0065d054
PE
7543 * charset.c (charset_table_size)
7544 (struct charset_sort_data.priority): Now ptrdiff_t.
7545 (charset_compare): Don't overflow if priorities differ greatly.
7546 (Fsort_charsets): Don't assume list length fits in int.
7547 Check for size-calculation overflow when allocating sort data.
7548 (syms_of_charset): Allocate an initial charset table that is
7549 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7550
7551 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7552
7553 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7554 The actual value is always <= INT_MAX, and leaving it unsigned made
7555 overflow checking harder.
7556
7557 * dispextern.h (struct glyph_matrix.rows_allocated)
7558 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7559 with xpalloc. The values are still always <= INT_MAX.
7560
7561 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7562
7563 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7564 (SAFE_NALLOCA): New macro.
7565
7566 * region-cache.c (struct boundary.pos, find_cache_boundary)
7567 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7568 (set_cache_region, invalidate_region_cache)
7569 (revalidate_region_cache, know_region_cache, region_cache_forward)
7570 (region_cache_backward, pp_cache):
7571 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7572 so that ptrdiff_t * can be passed to xpalloc.
7573 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7574 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7575 (pp_cache): Don't assume cache_len fits in int.
7576 * region-cache.h: Adjust extern decls to match.
7577
7578 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7579 EMACS_INT, since either will do, for xpalloc.
7580
7581 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7582 (xnmalloc, xnrealloc, xpalloc): New functions.
7583
726e0ab1
PE
7584 * bidi.c (bidi_shelve_header_size): New constant.
7585 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7586 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7587
51f30bc5 7588 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7589 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7590 (overlay_strings):
7591 Don't update size of array until after memory allocation succeeds,
7592 because xmalloc/xrealloc may not return.
0065d054
PE
7593 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7594 now that we have proper integer overflow checking.
7595 (record_overlay_string, overlay_strings): Catch overflows when
7596 calculating size of overlay_str_buf.
726e0ab1 7597
0065d054
PE
7598 * callproc.c (Fcall_process): Check for size overflow when
7599 calculating size of args2.
7600 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7601 Normally we prefer signed values, but sticking with ptrdiff_t would
7602 require adding more-complicated checks.
726e0ab1
PE
7603
7604 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7605 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7606 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7607 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7608
7609 * character.c (Fstring): Check for size-calculation overflow.
7610
7611 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7612 unnecessary integer overflow. Check for size overflow.
7613 (encode_coding_object): Don't update size until xmalloc succeeds.
7614
7615 * composite.c (get_composition_id): Check for overflow in glyph
7616 length calculations.
7617
7618 Integer and memory overflow fixes for display code.
7619 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7620 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7621 (scrolling_window): Check for overflow in size calculations.
7622 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7623 Don't assume glyph table len fits in int.
7624 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7625 (row_table_size): Now ptrdiff_t, not int.
7626 (scrolling_window): Avoid overflow in size calculations.
7627 Don't update size until allocation succeeds.
7628 * fns.c (concat): Check for overflow in size calculations.
7629 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7630 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7631 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7632
7633 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7634 (get_doc_string): Check for size calculation overflow.
7635 Don't update size until allocation succeeds.
7636 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7637 EMACS_INT, where ptrdiff_t will do.
7638 (Fsubstitute_command_keys): Check for string overflow.
7639
7640 * editfns.c (set_time_zone_rule): Don't assume environment length
7641 fits in int.
7642 (message_length): Now ptrdiff_t, not int.
7643 (Fmessage_box): Don't update size until allocation succeeds.
7644 Don't assume message length fits in int.
7645 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7646
0065d054
PE
7647 * emacs.c (main): Do not reallocate argv, since there is a null at
7648 the end that can be overwritten, and this way there's no need to
7649 worry about size-calculation overflow.
7650 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7651
7652 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7653 alloc succeeds.
7654 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7655
7656 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7657 (x_set_scroll_bar_width, x_figure_window_size):
7658 Check for integer overflow.
7659 (x_set_alpha): Do not assume XINT fits in int.
7660
7661 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7662 This is for the members text_lines, text_cols, total_lines, total_cols,
7663 where the system imposes an 'int' limit.
7664
7665 * fringe.c (Fdefine_fringe_bitmap):
7666 Don't update size until alloc works.
7667
7668 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7669 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7670
7671 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7672 Check for size-calculation overflow.
7673 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7674 do, as we prefer signed integers.
7675 (id_to_widget.max_size, id_to_widget.used)
7676 (xg_store_widget_in_map, xg_remove_widget_from_map)
7677 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7678 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7679 Use and return ptrdiff_t, not int.
7680 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7681 * gtkutil.h: Change prototypes to match the above.
7682
7683 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7684 are duplicate now that they've been promoted to lisp.h.
7685 (x_allocate_bitmap_record, x_alloc_image_color)
7686 (make_image_cache, cache_image, xpm_load):
7687 Don't update size until alloc is done.
7688 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7689 (x_detect_edges):
3256efce 7690 Check for size calculation overflow.
726e0ab1
PE
7691 (ct_colors_allocated_max): New constant.
7692 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7693 overflow.
3256efce 7694
726e0ab1
PE
7695 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7696 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7697 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7698 Use ptrdiff_t, not int, to count maps.
7699 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7700 calculations. Don't update size until allocation succeeds.
7701 Redo calculations to avoid overflow.
726e0ab1
PE
7702 * keyboard.h: Change prototypes to match the above.
7703
7704 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7705 to count maps.
7706 (current_minor_maps): Check for size calculation overflow.
7707 * keymap.h: Change prototypes to match the above.
7708
7709 * lread.c (read1, init_obarray): Don't update size until alloc done.
7710
7711 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7712 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7713
726e0ab1
PE
7714 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7715 Now ptrdiff_t, not int.
7716 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7717 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7718
7719 * process.c (Fnetwork_interface_list): Check for overflow
7720 in size calculation.
7721
7722 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7723
7724 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7725 overflow. Don't bother calling xmalloc when xrealloc will do.
7726
7727 * search.c (Freplace_match): Check for size calculation overflow.
7728 (Fset_match_data): Don't assume list lengths fit in 'int'.
7729
7730 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7731 for command line length. Do not attempt to address one before the
7732 beginning of an array, as that's not portable.
7733
7734 * term.c (max_frame_lines): Remove; unused.
7735 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7736 not int.
7737 (encode_terminal_code, calculate_costs): Check for size
7738 calculation overflow.
7739 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7740 table lengths and related sizes. Don't update size until alloc
7741 done. Redo calculations to avoid overflow.
7742 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7743
7744 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7745 subtracting pointers.
7746 (gobble_line): Check for overflow more carefully. Don't update size
7747 until alloc done.
7748
7749 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7750 Don't update size until alloc done.
7751 Redo size calculations to avoid overflow.
7752 Check for size calculation overflow.
0065d054 7753 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7754
7755 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7756 Use ptrdiff_t, not int, for sizes.
7757 (store_mode_line_noprop_char): Don't update size until alloc done.
7758
0065d054
PE
7759 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7760 Use ptrdiff_t, not int, for sizes.
7761 (Finternal_make_lisp_face, cache_face):
7762 Check for size calculation overflow.
7763 (cache_face): Treat size calculation overflows as if they were
7764 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7765
7766 * xfns.c (x_encode_text, x_set_name_internal)
7767 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7768 sizes, since they can exceed INT_MAX in size. Check for size
7769 calculation overflow.
7770
0065d054
PE
7771 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7772 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7773 Don't update size until alloc done.
7774
0065d054 7775 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7776 as sprintf is limited to int lengths.
1d526e2f 7777
252c5ee1
PE
7778 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7779 (X_LONG_MIN): New macros.
864d7ce7
PE
7780 Use them to make the following changes clearer.
7781 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7782 This change doesn't affect the value now, but it may help remind
7783 future maintainers not to raise the value too much later.
7784 (SELECTION_QUANTUM): Remove, replacing with ...
7785 (selection_quantum): ... new function, which avoids overflow.
7786 All uses changed.
7787 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7788 assumption that selection length fits in 'int'.
7789 (x_reply_selection_request, x_handle_selection_request)
7790 (x_get_window_property, receive_incremental_selection)
7791 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7792 (lisp_data_to_selection_data, clean_local_selection_data):
7793 Use ptrdiff_t, not int, to record length of selection.
7794 (x_reply_selection_request, x_get_window_property)
7795 (receive_incremental_selection, x_property_data_to_lisp):
7796 Redo calculations to avoid overflow.
7797 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7798 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7799 something.
7800 (x_get_window_property, receive_incremental_selection)
7801 (lisp_data_to_selection_data, x_property_data_to_lisp):
7802 Check for size-calculation overflow.
7803 (x_get_window_property, receive_incremental_selection)
7804 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7805 Don't store size until memory allocation succeeds.
7806 (x_get_window_property): Plug memory leak on memory exhaustion.
7807 Don't double-block input; malloc is safe here. Don't assume 2**34
7808 - 4 fits in unsigned long. Add an xassert to check
7809 XGetWindowProperty overflow. Be more careful about overflow
7810 calculations, and distinguish size from memory overflow better.
7811 (receive_incremental_selection): When tracing, don't assume
7812 unsigned int is less than INT_MAX.
7813 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7814 harmful) conversions of unsigned short to int.
7815 (lisp_data_to_selection_data): Don't assume that integers
7816 in the range -65535 through -1 fit in an X unsigned short.
7817 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7818 result parameters unless successful. Rely on cons_to_unsigned
7819 to report problems with elements; the old code wasn't right anyway.
7820 (x_check_property_data): Check for int overflow; we cannot use
7821 a wider type due to X limits.
7822 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7823
726e0ab1 7824 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7825
0065d054
PE
7826 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7827 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7828 (x_color_cells): Don't store size until memory allocation succeeds.
7829 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7830 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7831 (x_term_init): Don't assume length fits in int (sprintf is limited
7832 to int size).
bc18e09d 7833
ebfa62c0
PE
7834 Use ptrdiff_t for composition IDs.
7835 * character.c (lisp_string_width):
7836 * composite.c (composition_table_size, n_compositions)
7837 (get_composition_id, composition_gstring_from_id):
7838 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7839 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7840 * window.c (Frecenter):
7841 Use ptrdiff_t, not int, for composition IDs.
7842 * composite.c (get_composition_id): Check for integer overflow.
7843 * composite.h: Adjust prototypes to match the above changes.
7844
d3411f89
PE
7845 Use ptrdiff_t for hash table indexes.
7846 * category.c (hash_get_category_set):
7847 * ccl.c (ccl_driver):
7848 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7849 * coding.c (coding_system_charset_list, detect_coding_system):
7850 * coding.h (struct coding_system.id):
7851 * composite.c (get_composition_id, gstring_lookup_cache):
7852 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7853 * image.c (xpm_get_color_table_h):
7854 * lisp.h (hash_lookup, hash_put):
7855 * minibuf.c (Ftest_completion):
7856 Use ptrdiff_t for hash table indexes, not int (which is too
7857 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7858 32-bit --with-wide-int hosts).
7859
e097a6fa
PE
7860 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7861 Add a FIXME comment about memory leaks.
7862 (syms_of_charset): Don't assume xmalloc returns.
7863
5637687f
PE
7864 Don't assume that stated character widths fit in int.
7865 * character.c (Fchar_width, c_string_width, lisp_string_width):
7866 * character.h (CHAR_WIDTH):
7867 * indent.c (MULTIBYTE_BYTES_WIDTH):
7868 Use sanitize_char_width to avoid undefined and/or bad behavior
7869 with outlandish widths.
a66cfb1c 7870 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7871 now that we have two such functions. All uses changed.
7872 (sanitize_char_width): New inline function.
7873
a2271ba2
PE
7874 Don't assume that tab-width fits in int.
7875 * character.h (sanitize_width): New inline function.
7876 (SANE_TAB_WIDTH): New macro.
7877 (ASCII_CHAR_WIDTH): Use it.
7878 * indent.c (sane_tab_width): Remove. All uses replaced by
7879 SANE_TAB_WIDTH (current_buffer).
7880 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7881
18c52557
PE
7882 * fileio.c: Integer overflow issues with file modes.
7883 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7884
caeeedc1
PE
7885 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7886 Remove unreachable code.
7887 (read_hex, load_charset_map_from_file): Check for integer overflow.
7888
6df6ae42 7889 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7890 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7891 (x_send_scroll_bar_event): Likewise. Check that the size does not
7892 exceed limits imposed by XClientMessageEvent, as well as the usual
7893 ptrdiff_t and size_t limits.
7894
b13995db
PE
7895 * keyboard.c: Overflow, signedness and related fixes.
7896 (make_lispy_movement): Use same integer type in forward decl
7897 that is used in the definition.
7898 (read_key_sequence, keyremap_step):
7899 Change bufsize argument back to int, undoing my 2011-03-30 change.
7900 We prefer signed types, and int is wide enough here.
7901 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7902 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7903 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7904 length, not size_t. Use ptrdiff_t for index, not int.
7905 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7906 possibility of integer overflow.
7907
13464394
PE
7908 Overflow, signedness and related fixes for images.
7909
7910 * dispextern.h (struct it.stack[0].u.image.image_id)
7911 (struct_it.image_id, struct image.id, struct image_cache.size)
7912 (struct image_cache.used, struct image_cache.ref_count):
7913 * gtkutil.c (update_frame_tool_bar):
7914 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7915 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7916 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7917 * nsmenu.m (update_frame_tool_bar):
7918 * xdisp.c (calc_pixel_width_or_height):
7919 * xfns.c (image_cache_refcount):
7920 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7921 on typical 64-bit hosts.
7922
7923 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7924 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7925 Omit unnecessary casts to int.
7926 (parse_image_spec): Check that integers fall into 'int' range
7927 when the callers expect that.
7928 (image_ascent): Redo ascent calculation to avoid int overflow.
7929 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7930 (lookup_image): Remove unnecessary tests.
7931 (xbm_image_p): Locals are now of int, not EMACS_INT,
7932 since parse_image_check makes sure they fit into int.
7933 (png_load, gif_load, svg_load_image):
7934 Prefer int to unsigned where either will do.
7935 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7936 old tiff_error_handler and tiff_warning_handler.
7937 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7938 stack buffer overflows. It uses only the features of vsnprintf
7939 that are common to both POSIX and native Microsoft.
7940 (tiff_error_handler, tiff_warning_handler): Use it.
7941 (tiff_load, gif_load, imagemagick_load_image):
7942 Don't assume :index value fits in 'int'.
7943 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7944 (imagemagick_load_image): Check that crop parameters fit into
7945 the integer types that MagickCropImage accepts. Don't assume
7946 Vimagemagick_render_type has a nonnegative value. Don't assume
7947 size_t fits in 'long'.
7948 (gs_load): Use printmax_t to print the widest integers possible.
7949 Check for integer overflow when computing image height and width.
7950
c11821d4
EZ
79512011-08-26 Eli Zaretskii <eliz@gnu.org>
7952
7953 * xdisp.c (redisplay_window): Don't force window start if point
7954 will be invisible in the resulting window. (Bug#9324)
7955
0c95fcf7
EZ
79562011-08-25 Eli Zaretskii <eliz@gnu.org>
7957
7958 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7959 the display spec is of the form `(space ...)'.
7960 (handle_display_spec): Return the value returned by
7961 handle_single_display_spec, not just 1 or zero.
7962 (handle_single_display_spec): If the display spec is of the form
7963 `(space ...)', and specifies display in the text area, return 2
7964 rather than 1.
fee65a97 7965 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7966 accurately, and prefer exact match for point under bidi.
7967 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7968
7969 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7970 into disp_prop; all users changed.
7971
7972 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7973 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7974 for the text covered by the display property.
7975
e4ed06f1
CY
79762011-08-25 Chong Yidong <cyd@stupidchicken.com>
7977
7978 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7979 Change return value to nil.
7980 (Frecord_buffer): Delete unused function.
7981
f67cdd7f
EZ
79822011-08-24 Eli Zaretskii <eliz@gnu.org>
7983
5980d4c6
EZ
7984 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7985 buffers, return left-to-right.
8610fe8b
EZ
7986 (set_cursor_from_row): Consider candidate row a win if its glyph
7987 represents a newline and point is on that newline. Fixes cursor
7988 positioning on the newline at EOL of R2L text within L2R
7989 paragraph, and vice versa.
7990 (try_cursor_movement): Check continued rows, in addition to
7991 continuation rows. Fixes unwarranted scroll when point enters a
7992 continued line of R2L text within an L2R paragraph, or vice versa.
7993 (cursor_row_p): Consider the case of point being equal to
7994 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7995 from the end of a short line to the beginning of a continued line
7996 of R2L text within L2R paragraph.
7997 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7998 composed characters.
5980d4c6 7999
f67cdd7f
EZ
8000 * bidi.c (bidi_check_type): Use xassert.
8001 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8002 members.
8003
bca633fb
EZ
80042011-08-23 Eli Zaretskii <eliz@gnu.org>
8005
8006 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8007 a character.
8008
4a5885a7
CY
80092011-08-23 Chong Yidong <cyd@stupidchicken.com>
8010
8011 * nsfont.m (ns_otf_to_script): Fix typo.
8012
0902a04e
KH
80132011-08-22 Kenichi Handa <handa@m17n.org>
8014
8015 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8016 extra slot even if the purpose is char-code-property-table.
8017
1a2e6670
EZ
80182011-08-23 Eli Zaretskii <eliz@gnu.org>
8019
8ddde651
EZ
8020 * xdisp.c (redisplay_window): When computing centering_position,
8021 account for the height of the header line. (Bug#8874)
8022
425cc014
EZ
8023 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8024 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8025 candidate is selected by the mouse, and that candidate has a
8026 composed character under the mouse.
8027
1a2e6670
EZ
8028 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8029 coordinates reported by pos-visible-in-window-p for a composed
8030 character in column zero.
8031
8b76d6f8
SM
80322011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8033
8034 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8035
dac347dd
EZ
80362011-08-22 Eli Zaretskii <eliz@gnu.org>
8037
8038 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8039 consider it a hit if to_charpos is anywhere in the range of the
8040 composed buffer positions.
8041
e013fb34
CY
80422011-08-22 Chong Yidong <cyd@stupidchicken.com>
8043
8044 * image.c (gif_load): Don't assume that each subimage has the same
8045 dimensions as the base image. Handle disposal method that is
8046 "undefined" by the gif spec (Bug#9335).
8047
bd1ba3e8
CY
80482011-08-20 Chong Yidong <cyd@stupidchicken.com>
8049
8050 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8051 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8052
54a1215b
EZ
80532011-08-19 Eli Zaretskii <eliz@gnu.org>
8054
823564e5
EZ
8055 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8056 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8057 from an Org mode buffer to a Speedbar frame.
8058
54a1215b
EZ
8059 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8060 a composition, take its buffer position from IT->cmp_it.charpos.
8061 Fixes cursor positioning at the beginning of a line that begins
8062 with a composed character.
8063
9778ebcc
EZ
80642011-08-18 Eli Zaretskii <eliz@gnu.org>
8065
0be6ee06
EZ
8066 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8067 character bidirectional type, use STRONG_L instead. Fixes crashes
8068 in a buffer produced by `describe-categories'.
8069
9778ebcc
EZ
8070 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8071 members before the level stack, so they would be saved and
8072 restored when copying iterator state. Fixes incorrect reordering
8073 around TABs covered by display properties.
8074
156bffbe
AS
80752011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8076
6b02f655 8077 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8078
72ad093b
CY
80792011-08-17 Chong Yidong <cyd@stupidchicken.com>
8080
8081 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8082 (internal_condition_case_2, internal_condition_case_n):
8083 Remove unnecessary aborts (Bug#9081).
72ad093b 8084
35774242
EZ
80852011-08-17 Eli Zaretskii <eliz@gnu.org>
8086
8087 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8088 has no `load' handler, try opening the file locally. (Bug#9311)
8089
db76dd85
KB
80902011-08-16 Ken Brown <kbrown@cornell.edu>
8091
8092 * gmalloc.c: Expand comment.
8093
b215eee5
EZ
80942011-08-16 Eli Zaretskii <eliz@gnu.org>
8095
8096 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8097 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8098
a4579d33
KB
80992011-08-16 Ken Brown <kbrown@cornell.edu>
8100
8101 Fix memory allocation problems in Cygwin build (Bug#9273).
8102
8103 * unexcw.c ( __malloc_initialized): Declare external variable.
8104 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8105
8b76d6f8
SM
8106 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8107 New variables.
a4579d33
KB
8108 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8109 dumped emacs.
8110 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8111 in the static heap.
8112 [CYGWIN] (special_realloc): New function.
8113 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8114 requests to realloc storage in the static heap.
8115
3ebec551
PE
81162011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8117
8118 * bidi.c (bidi_initialize): Remove unused local.
8119
9fd8be00
EZ
81202011-08-15 Eli Zaretskii <eliz@gnu.org>
8121
6b02f655
SM
8122 * bidimirror.h:
8123 * biditype.h: Remove file.
8124 * makefile.w32-in ($(BLD)/bidi.$(O)):
8125 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8126
8127 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8128
8129 * chartab.c: Improve commentary for the uniprop_table API.
8130
32413314
EZ
8131 * bidi.c (bidi_paragraph_init): Support zero value of
8132 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8133 (bidi_initialize): Use uniprop_table instead of including
8134 biditype.h and bidimirror.h.
32413314 8135
9fd8be00
EZ
8136 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8137 coordinates of the iterator when restoring from ppos_it.
8138 (Bug#9296)
8139
5cf2b69b
KH
81402011-08-14 Kenichi Handa <handa@m17n.org>
8141
8142 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8143 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8144
daf17d00
EZ
81452011-08-14 Eli Zaretskii <eliz@gnu.org>
8146
8147 * xdisp.c (move_it_in_display_line_to): Don't invoke
8148 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8149 ppos_it. Fixes vertical cursor motion when line beginning is
8150 covered by an image. (Bug#9296)
8151
08e3161a
JD
81522011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8153
8154 * nsterm.h (ns_run_ascript): Declare.
8155 (NSAPP_DATA2_RUNASSCRIPT): Define.
8156
8157 * nsfns.m (as_script, as_result, as_status): New static variables.
8158 (ns_run_ascript): New function.
5e617bc2 8159 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8160 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8161 the event loop. Get status from as_status (Bug#7276).
8162
8163 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8164 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8165 the event loop (Bug#7276).
8166
a3720aa2
AS
81672011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8168
8169 * gnutls.c (QCgnutls_bootprop_priority)
8170 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8171 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8172 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8173 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8174 (QCgnutls_bootprop_verify_hostname_error)
8175 (QCgnutls_bootprop_callbacks_verify): Rename from
8176 Qgnutls_bootprop_..., all uses changed.
8177
8178 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8179 uses changed.
8180
0a0d27fb
PE
81812011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8182
19d5c50c
PE
8183 * xfaces.c (Qframe_set_background_mode): Now static.
8184 * dispextern.h (Qframe_set_background_mode): Remove decl.
8185
0a0d27fb
PE
8186 * process.c (Fnetwork_interface_info): Declare local only if needed.
8187
377538cb
JD
81882011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8189
8190 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8191 (Fnetwork_interface_list): Allocate in increments of bytes instead
8192 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8193 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8194 sockaddr.
8195 (struct ifflag_def): notrailers is smart on OSX.
8196 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8197 Get hardware address with getifaddrs if available.
8198
08fff70c
EZ
81992011-08-12 Eli Zaretskii <eliz@gnu.org>
8200
8201 * xdisp.c (iterate_out_of_display_property): xassert that
8202 IT->position is set to within IT->object's boundaries. Break from
8203 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8204 when IT->position is set up wrongly due to some bug.
8205 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8206 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8207 entry. Force push_it to save on the stack the current
8208 buffer/string position, to be restored by pop_it. Fix flags in
8209 the iterator structure wrt the object coming from a display
8210 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8211 properties. (Bug#9284)
8212
7be1c708 82132011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8214
7be1c708
CY
8215 * fontset.c (fontset_get_font_group): Add proper type checks.
8216 (Bug#9172)
aac0c6e3 8217
7be1c708 82182011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8219
7be1c708
CY
8220 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8221 and LC_VERSION_MIN_MACOSX.
8222 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8223 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8224
97bb72a6
EZ
82252011-08-08 Eli Zaretskii <eliz@gnu.org>
8226
8227 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8228 no-display-properties-and-no-overlays under bidi display.
8229 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8230 properties and overlays.
97bb72a6 8231
d5617611
CY
82322011-08-08 Chong Yidong <cyd@stupidchicken.com>
8233
37e11a63
CY
8234 * editfns.c (Fset_time_zone_rule): Document relationship with the
8235 setenv function.
8236
d5617611
CY
8237 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8238 the font entity extracted from the cache (Bug#8109).
8239
58872834
CY
82402011-08-07 Chong Yidong <cyd@stupidchicken.com>
8241
8242 * composite.c (autocmp_chars): Don't reset point. That is done by
8243 restore_point_unwind (Bug#5984).
8244
75bfc667
JL
82452011-08-07 Juri Linkov <juri@jurta.org>
8246
8247 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8248 to show the arg `TIME' instead of `TIMEVAL'.
8249
d1410150
EZ
82502011-08-06 Eli Zaretskii <eliz@gnu.org>
8251
8252 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8253 display property strides EOL and includes a newline, as in
8254 longlines-mode. (Bug#9254)
75b771e4
EZ
8255 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8256 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8257
8258 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8259 is non-zero, even if the data buffer is NULL. Fixes a crash in
8260 vertical-motion with longlines-mode. (Bug#9254)
8261
35928349
EZ
82622011-08-05 Eli Zaretskii <eliz@gnu.org>
8263
ec7cc85b
EZ
8264 * bidi.c <bidi_cache_total_alloc>: Now static.
8265 (bidi_initialize): Initialize bidi_cache_total_alloc.
8266
8b76d6f8 8267 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8268 cache. (Bug#9221)
8269
8270 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8271 amount allocated this far in `bidi_cache_total_alloc'.
8272 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8273 non-zero, only free the data buffer without restoring the cache
8274 contents. All callers changed.
8275
8276 * dispextern.h (bidi_unshelve_cache): Update prototype.
8277
8278 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8279 (move_it_in_display_line, move_it_to)
8280 (move_it_vertically_backward, move_it_by_lines): Replace the call
8281 to xfree to an equivalent call to bidi_unshelve_cache.
8282 (move_it_in_display_line_to): Fix logic of returning
412b6358 8283 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8284
e2e2423b
EZ
82852011-08-05 Eli Zaretskii <eliz@gnu.org>
8286
8287 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8288 came from a string character with a `cursor' property. (Bug#9229)
8289
ae9e757a
JD
82902011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8291
8292 * Makefile.in (LIB_PTHREAD): New variable.
8293 (LIBES): Add LIB_PTHREAD (Bug#9216).
8294
8295 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8296 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8297
213bd7f2
AS
82982011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8299
6b02f655 8300 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8301
99aaf75f
JD
83022011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8303
8304 * xterm.c (x_find_topmost_parent): New function.
8305 (x_set_frame_alpha): Find topmost parent window with
8306 x_find_topmost_parent and set the property there also (bug#9181).
8307 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8308
c74e9d86
PE
83092011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8310
8311 * callproc.c (Fcall_process): Avoid vfork clobbering
8312 the local vars buffer, coding_systems, current_dir.
8313
640c8776
SM
83142011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8315
8316 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8317
f26d0e4c
PE
83182011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8319
8a10d76c
PE
8320 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8321 so that it is not optimized away.
8322
f26d0e4c
PE
8323 * xdisp.c (compute_display_string_pos): Remove unused local.
8324
55439c61
EZ
83252011-08-02 Eli Zaretskii <eliz@gnu.org>
8326
8327 Fix slow cursor motion and scrolling in large buffers with
8328 selective display, like Org Mode buffers. (Bug#9218)
8329
8330 * dispextern.h (struct bidi_it): New member disp_prop_p.
8331
8332 * xdisp.c: Remove one-slot cache of display string positions.
8333 (compute_display_string_pos): Accept an additional argument
5e617bc2 8334 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8335 for a display string or property. If found, set DISP_PROP_P
8336 non-zero.
8337
8338 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8339 DISP_PROP_P, and pass it to compute_display_string_pos.
8340 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8341 non-zero. All callers of bidi_fetch_char changed.
8342
fb33fa43
SM
83432011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8344
8345 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8346
b099e063
DM
83472010-12-03 Don March <don@ohspite.net>
8348
8349 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8350 last character M-[char] is translated to ESC [char] (bug#7541).
8351
5cc7f7af
KH
83522011-08-02 Kenichi Handa <handa@m17n.org>
8353
d0fffa3f 8354 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8355
8356 * chartab.c (uniprop_table): Make it non-static.
8357
525d5e6e
EZ
83582011-08-01 Eli Zaretskii <eliz@gnu.org>
8359
8360 * xdisp.c (forward_to_next_line_start): Accept additional argument
8361 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8362 on the newline.
8363 (reseat_at_next_visible_line_start): Use the bidi iterator state
8364 returned by forward_to_next_line_start to restore the state of
8365 it->bidi_it after backing up to previous newline. (Bug#9212)
8366
31011111
AS
83672011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8368
8369 * regex.c (re_comp): Protoize.
8370 (re_exec): Fix return type.
8371 (regexec): Fix type of `ret'. (Bug#9203)
8372
476371c4
PE
83732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8374
e5d76069
PE
8375 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8376 This is needed if max-image-size is a floating-point number.
8377
9a79b20c
AS
83782011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8379
8380 * print.c (print_object): Print empty symbol as ##.
8381
8382 * lread.c (read1): Read ## as empty symbol.
8383
d8c2fa78
AA
83842011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8385
8386 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8387 setting frame foreground color (Bug#9175).
8388 (x_set_background_color): Likewise.
8389
ffe57a7a
AA
8390 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8391 contents (Bug#9176).
8392 (EmacsTooltip -init): Remove bezels and add shadows to
8393 tooltip windows.
8394
bf3492a5
AA
8395 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8396 or scroll bar (Bug#8470).
8397
d55e9c53
AA
8398 * nsfont.m (nsfont_open): Remove assignment to voffset and
8399 unnecessary vars hshink, expand, hd, full_height, min_height.
8400 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8401
8402 * nsterm.h (nsfont_info): Remove voffset field.
8403
d8c2fa78 84042011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8405
8406 Implement strike-through and overline on NextStep (Bug#8863).
8407
8408 * nsfont.m (nsfont_open): Use underline position provided by font,
8409 instead of hard-coded value of 2.
8410 (nsfont_draw): Call ns_draw_text_decoration instead.
8411
8412 * nsterm.h: Add declaration for ns_draw_text_decoration.
8413
8414 * nsterm.m (ns_draw_text_decoration): New function for drawing
8415 underline, overline, and strike-through.
8416 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8417 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8418 accommodate underlining, etc.
4843aac3 8419
4cc60b9b
EZ
84202011-07-28 Eli Zaretskii <eliz@gnu.org>
8421
bc7ece87
EZ
8422 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8423 default.
4cc60b9b 8424
476371c4
PE
84252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8426
66606eea
PE
8427 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8428 Without this fix, if a signal arrives just after memory fills up,
8429 'malloc' might be invoked reentrantly.
8430
476371c4
PE
8431 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8432 In other words, assume that every image size is allowed, on non-X
8433 hosts. This assumption is probably wrong, but it lets Emacs compile.
8434
f3fcc40d
AS
84352011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8436
8437 * regex.c (re_iswctype): Convert return values to boolean.
8438
350c992f
EZ
84392011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8440
8441 * xdisp.c (compute_display_string_pos): Don't use cached display
8442 string position if the buffer had its restriction changed.
8443 (Bug#9184)
8444
5266b4bb
PE
84452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8446
8447 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8448
2573a837 84492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8450
41f55ccd 8451 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8452
39e378da
PE
8453 * bidi.c: Integer size and overflow fixes.
8454 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8455 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8456 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8457 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8458 (bidi_find_other_level_edge):
8459 Use ptrdiff_t instead of EMACS_INT where either will do.
8460 This works better on 32-bit hosts configured --with-wide-int.
8461 (bidi_cache_ensure_space): Check for size-calculation overflow.
8462 Use % rather than repeated addition, for better worst-case speed.
8463 Don't set bidi_cache_size until after xrealloc returns, because it
8464 might not return.
8465 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8466 (bidi_cache_ensure_space): Also check that the bidi cache size
8467 does not exceed that of the largest Lisp string or buffer. See Eli
8468 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8469
5e927815
PE
8470 * alloc.c (__malloc_size_t): Remove.
8471 All uses replaced by size_t. See Andreas Schwab's note
8472 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8473
ca4aa935
PE
8474 * image.c: Improve checking for integer overflow.
8475 (check_image_size): Assume that f is nonnull, since
8476 it is always nonnull in practice. This is one less thing to
8477 worry about when checking for integer overflow later.
8478 (x_check_image_size): New function, which checks for integer
8479 overflow issues inside X.
8480 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8481 This removes the need for a memory_full check.
8482 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8483 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8484 (xbm_read_bitmap_data): Change locals back to 'int', since
8485 their values must fit in 'int'.
8486 (xpm_load_image, png_load, tiff_load):
8487 Invoke x_create_x_image_and_pixmap earlier,
8488 to avoid much needless work if the image is too large.
8489 (tiff_load): Treat overly large images as if
8490 x_create_x_image_and_pixmap failed, not as malloc failures.
8491 (gs_load): Use x_check_image_size.
8492
5f8f9cc2
PE
8493 * gtkutil.c: Omit integer casts.
8494 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8495 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8496
5adf60bc
PE
8497 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8498
c8907a93
PE
8499 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8500 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8501 would wrongly return t on a 64-bit host.
8502
e3c25c68
PE
8503 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8504 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8505 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8506 and therefore cause GCC to emit a bogus diagnostic in some cases.
8507
3f791afe
PE
8508 * image.c: Integer signedness and overflow and related fixes.
8509 This is not an exhaustive set of fixes, but it's time to
8510 record what I've got.
8511 (lookup_pixel_color, check_image_size): Remove redundant decls.
8512 (check_image_size): Don't assume that arbitrary EMACS_INT values
8513 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8514 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8515 (tiff_load, imagemagick_load_image):
8516 Check for overflow in size calculations.
8517 (x_create_x_image_and_pixmap): Remove unnecessary test for
8518 xmalloc returning NULL; that can't happen.
8519 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8520 (xpm_color_bucket): Use better integer hashing function.
8521 (xpm_cache_color): Don't possibly over-allocate memory.
8522 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8523 (gif_memory_source):
8524 Use ptrdiff_t, not int or size_t, to record sizes.
8525 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8526 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8527 either works, as we prefer signed integers.
8528 (tiff_read_from_memory, tiff_write_from_memory):
8529 Return tsize_t, not size_t, since that's what the TIFF API wants.
8530 (tiff_read_from_memory): Don't fail simply because the read would
8531 go past EOF; instead, return a short read.
8532 (tiff_load): Omit no-longer-needed casts.
8533 (Fimagemagick_types): Don't assume size fits into 'int'.
8534
3cc5a532
PE
8535 Improve hashing quality when configured --with-wide-int.
8536 * fns.c (hash_string): New function, taken from sxhash_string.
8537 Do not discard information about ASCII character case; this
8538 discarding is no longer needed.
8539 (sxhash-string): Use it. Change sig to match it. Caller changed.
8540 * lisp.h: Declare it.
8541 * lread.c (hash_string): Remove, since we now use fns.c's version.
8542 The fns.c version returns a wider integer if --with-wide-int is
8543 specified, so this should help the quality of the hashing a bit.
8544
b312a492
PE
8545 * emacs.c: Integer overflow minor fix.
8546 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8547 Define only if GNU_LINUX.
8548 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8549
dfd153ae
PE
8550 * dispnew.c: Integer signedness and overflow fixes.
8551 Remove unnecessary forward decls, that were a maintenance hassle.
8552 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8553 All uses changed.
8554 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8555 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8556 (prepare_desired_row, line_draw_cost):
8557 Use int, not unsigned, where either works.
8558 (save_current_matrix, restore_current_matrix):
8559 Use ptrdiff_t, not size_t, where either works.
8560 (init_display): Check for overflow more accurately, and without
8561 relying on undefined behavior.
8562
a81d11a3
PE
8563 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8564 Remove, replacing with the new symbols in lisp.h. All uses changed.
8565 * fileio.c (make_temp_name):
8566 * filelock.c (lock_file_1, lock_file):
8567 * xdisp.c (message_dolog):
8568 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8569 Use pMd etc. instead.
8570 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8571 replacing the pWIDE etc. symbols removed from editfns.c.
8572
3300e6fd
PE
8573 * keyboard.h (num_input_events): Now uintmax_t.
8574 This is (very slightly) less likely to mess up due to wraparound.
8575 All uses changed.
8576
fd05c7e9
PE
8577 * buffer.c: Integer signedness fixes.
8578 (alloc_buffer_text, enlarge_buffer_text):
8579 Use ptrdiff_t rather than size_t when either will do, as we prefer
8580 signed integers.
8581
903fe15d
PE
8582 * alloc.c: Integer signedness and overflow fixes.
8583 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8584 (__malloc_size_t): Default to size_t, not to int.
8585 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8586 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8587 Prefer ptrdiff_t to size_t when either would do, as we prefer
8588 signed integers.
8589 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8590 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8591 Now const. Initialize with values that are in range even if char
8592 is signed.
8593 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8594 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8595 These functions do the right thing with sizes > 2**32.
8596 (check_depth): Now ptrdiff_t, not int.
8597 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8598 Adjust to new way of storing sizes. Check for size overflow bugs
8599 in rest of code.
8600 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8601 slightly wrong anyway, as it missed one instance of
8602 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8603 (refill_memory_reserve): Omit needless cast to size_t.
8604 (mark_object_loop_halt): Mark as externally visible.
8605
ac82cc6a
PE
8606 * xselect.c: Integer signedness and overflow fixes.
8607 (Fx_register_dnd_atom, x_handle_dnd_message):
8608 Use ptrdiff_t, not size_t, since we prefer signed.
8609 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8610 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8611 x_dnd_atoms_size and x_dnd_atoms_length.
8612
c2d1e36d
PE
8613 * doprnt.c: Prefer signed to unsigned when either works.
8614 * eval.c (verror):
8615 * doprnt.c (doprnt):
8616 * lisp.h (doprnt):
8617 * xdisp.c (vmessage):
8618 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8619 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8620 prefer signed arithmetic to avoid comparison confusion.
8621 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8622 but is a bit tricky.
8623
0e926e56
PE
8624 Assume freestanding C89 headers, string.h, stdlib.h.
8625 * data.c, doprnt.c, floatfns.c, print.c:
8626 Include float.h unconditionally.
8627 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8628 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8629 * regex.c: Likewise for stddef.h, string.h.
8630 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8631 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8632 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8633 (STDC_HEADERS): Remove obsolete defines.
8634 * sysdep.c: Include limits.h unconditionally.
8635
9cfdb3ec
PE
8636 Assume support for memcmp, memcpy, memmove, memset.
8637 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8638 * regex.c (memcmp, memcpy):
8639 Remove; we assume C89 now.
8640
8641 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8642 (__malloc_safe_bcopy): Remove; no longer needed.
8643
cf950e6b 8644 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8645 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8646 well either way, and we prefer signed to unsigned.
8647
dbf38e02
LMI
86482011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8649
8650 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8651 closes the connection while we're reading (bug#9182).
8652
d6f0886c 86532011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8654
d6f0886c
JD
8655 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8656 are specified (Bug#9168).
24e0f6b1 8657
2eb1f9e6
PE
86582011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8659
8660 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8661 Found by GCC static checking and --with-wide-int on a 32-bit host.
8662
22381272 86632011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8664
8665 * xdisp.c (compute_display_string_pos): Fix logic of caching
8666 previous display string position. Initialize cached_prev_pos to
8667 -1. Fixes slow-down at the beginning of a buffer.
8668
f25e39b4
EZ
86692011-07-24 Eli Zaretskii <eliz@gnu.org>
8670
8671 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8672 for attrs[LFACE_FONTSET_INDEX].
8673
04c4b52e
PE
86742011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8675
8676 * xml.c (parse_region): Remove unused local
8677 that was recently introduced.
8678
c1734fbd
EZ
86792011-07-23 Eli Zaretskii <eliz@gnu.org>
8680
be18c5a5
EZ
8681 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8682 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8683
c1734fbd
EZ
8684 * xdisp.c (move_it_in_display_line_to): Record the best matching
8685 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8686 exit if none of the characters scanned was an exact match.
8687 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8688 when exact match is impossible due to invisible text, and the
8689 lines are truncated.
8690
a258d627
JD
86912011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8692
8693 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8694 for OSX >= 10.7.
8695
b6d5a689
EZ
86962011-07-22 Eli Zaretskii <eliz@gnu.org>
8697
0f74f785
EZ
8698 Fix a significant slow-down of cursor motion with C-n, C-p,
8699 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8700 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8701 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8702 (next_element_from_buffer): Call compute_stop_pos_backwards to
8703 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8704 base_level_stop.
8705 (reseat): Don't look for prev_stop, as that could mean a very long
8706 run.
8707 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8708 <cached_disp_overlay_modiff>: Cache for last found display string
8709 position.
551918c1 8710 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8711 about the same buffer in the same area of character positions, and
8712 the buffer wasn't changed since the time the display string
8713 position was cached.
551918c1 8714
b2d0c91a
EZ
87152011-07-22 Eli Zaretskii <eliz@gnu.org>
8716
8717 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8718 is an integer, which is important for empty lines. (Bug#9149)
8719
043604ee
CY
87202011-07-22 Chong Yidong <cyd@stupidchicken.com>
8721
8722 * frame.c (Fmodify_frame_parameters): In tty case, update the
8723 default face if necessary (Bug#4238).
8724
da4adb04
CY
87252011-07-21 Chong Yidong <cyd@stupidchicken.com>
8726
8727 * editfns.c (Fstring_to_char): No need to explain what a character
8728 is in the docstring (Bug#6576).
8729
9abd0532
LMI
87302011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8731
8732 * xml.c (parse_region): Make sure we always return a tree.
8733
36881d16
HK
87342011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8735
8736 * xml.c (parse_region): If a document contains only comments,
8737 return that, too.
8738
1e98674d
LMI
87392011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8740
8741 * xml.c (make_dom): Return comments, too.
8742
590bd467
PE
87432011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8744
8745 Port to OpenBSD.
8746 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8747 and the surrounding thread.
8748 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8749 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8750 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8751 timer goes off.
8752 * s/openbsd.h (BROKEN_SIGIO): Define.
8753 * unexelf.c (unexec) [__OpenBSD__]:
8754 Don't update the .mdebug section of the Alpha COFF symbol table.
8755
f41628b2
LMI
87562011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8757
8758 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8759 (bug#8460).
8760
b59b67c5
PE
87612011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8762
15e3a074
PE
8763 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8764 This fixes some race conditions on the permissions of any newly
8765 created file.
8766
41bed37d
PE
8767 * alloc.c (valid_pointer_p): Use pipe, not open.
8768 This fixes some permissions issues when debugging.
8769
b59b67c5
PE
8770 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8771 If fchown fails to set both uid and gid, try to set just gid,
8772 as that is sometimes allowed. Adjust the file's mode to eliminate
8773 setuid or setgid bits that are inappropriate if fchown fails.
8774
925a6be7
SM
87752011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8776
8777 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8778 to compare Lisp_Objects.
8779 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8780 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8781 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8782
52968808
AS
87832011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8784
0a6a104b
AS
8785 * lread.c (read_integer): Unread even EOF character.
8786 (read1): Likewise. Properly record start position of symbol.
8787
52968808
AS
8788 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8789 symbol character follows.
8790
9e381cdd
PE
87912011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8792
8793 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8794 This works around a problem with the previous change to Fcopy_file.
8795 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8796 and without this change, GCC might complain about discarding
8797 fchown's return value.
8798
b5641435
JB
87992011-07-16 Juanma Barranquero <lekktu@gmail.com>
8800
8801 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8802
a8031457
PE
88032011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8804
8805 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8806
dd889327
LMI
88072011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8808
750c33f7
LMI
8809 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8810 it's used from the C level.
8811
dd889327
LMI
8812 * process.c: Use the same condition for POLL_FOR_INPUT in both
8813 keyboard.c and process.c (bug#1858).
8814
87e86684
LM
88152011-07-09 Lawrence Mitchell <wence@gmx.li>
8816
8817 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8818 (Fgnutls_boot): Use it.
8819
64348f40
AS
88202011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8821
8822 * doc.c (Fsubstitute_command_keys): Revert last change.
8823
1d698799
LMI
88242011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8825
f863868c
LMI
8826 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8827 quotes the next character, and doesn't affect other longer
8828 sequences (bug#8935).
8829
1d698799
LMI
8830 * lread.c (syms_of_lread): Clarify that is isn't only
8831 `eval-buffer' and `eval-defun' that's affected by
8832 `lexical-binding' (bug#8460).
8833
aa4b6df6
EZ
88342011-07-15 Eli Zaretskii <eliz@gnu.org>
8835
8836 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8837 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8838
5d856da6
PE
88392011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8840
ad6042bb
PE
8841 Fix minor problems found by static checking.
8842 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8843 (elsz): Now a signed constant, not a size_t var. We prefer signed
8844 types to unsigned, to avoid integer comparison confusion. Without
8845 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8846 "cannot optimize loop, the loop counter may overflow", a symptom
8847 of the confusion.
f00bbb22 8848 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8849 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8850
6468f31c
LMI
88512011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8852
49080b10
LMI
8853 * search.c (Fre_search_backward): Mention `case-fold-search' in
8854 all the re_search_* functions (bug#8138).
8855
6468f31c
LMI
8856 * keyboard.c (Fopen_dribble_file): Document when the file is
8857 closed (bug#8056).
8858
c965adc5
EZ
88592011-07-14 Eli Zaretskii <eliz@gnu.org>
8860
df9733bf
EZ
8861 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8862 bidi_cache_idx.
8863
0bb23927
EZ
8864 Support bidi reordering of display and overlay strings.
8865 * xdisp.c (compute_display_string_pos)
8866 (compute_display_string_end): Accept additional argument STRING.
8867 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8868 (reseat_to_string): Initialize bidi_it->string.s and
8869 bidi_it->string.schars.
8870 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8871 NULL (avoids a crash in bidi_paragraph_init).
8872 Initialize itb.string.lstring.
0bb23927
EZ
8873 (init_iterator): Call bidi_init_it only of a valid
8874 buffer position was specified. Initialize paragraph_embedding to
8875 L2R.
8876 (reseat_to_string): Initialize the bidi iterator.
8877 (display_string): If we need to ignore text properties of
8878 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8879 original value of -1 will not work with bidi.)
8880 (compute_display_string_pos): First arg is now struct
8881 `text_pos *'; all callers changed. Support display properties on
8882 Lisp strings.
8883 (compute_display_string_end): Support display properties on Lisp
8884 strings.
8885 (init_iterator, reseat_1, reseat_to_string): Initialize the
8886 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8887 when iterating on a string not from display properties).
640c8776
SM
8888 (compute_display_string_pos, compute_display_string_end):
8889 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8890 arrow keys.
8891 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8892 base_level_stop; instead, set base_level_stop to BEGV.
8893 Fixes crashes in vertical-motion.
0bb23927
EZ
8894 (next_element_from_buffer): Improve commentary for when
8895 the iterator is before prev_stop.
8896 (init_iterator): Initialize bidi_p from the default value of
8897 bidi-display-reordering, not from buffer-local value. Use the
8898 buffer-local value only if initializing for buffer iteration.
8899 (handle_invisible_prop): Support invisible properties on strings
8900 that are being bidi-reordered.
8901 (set_iterator_to_next): Support bidi reordering of C strings and
8902 Lisp strings.
8903 (next_element_from_string): Support bidi reordering of Lisp
8904 strings.
8905 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8906 (display_string): Support display of R2L glyph rows.
8907 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8908 (init_iterator): Don't initialize it->bidi_p for strings
8909 here.
8910 (reseat_to_string): Initialize it->bidi_p for strings here.
8911 (next_element_from_string, next_element_from_c_string)
8912 (next_element_from_buffer): Add xassert's for correspondence
8913 between IT's object being iterated and it->bidi_it.string
8914 structure.
8915 (face_before_or_after_it_pos): Support bidi iteration.
8916 (next_element_from_c_string): Handle the case of the first string
8917 character that is not the first one in the visual order.
8918 (get_visually_first_element): New function, refactored from common
8919 parts of next_element_from_buffer, next_element_from_string, and
8920 next_element_from_c_string.
8921 (tool_bar_lines_needed, redisplay_tool_bar)
8922 (display_menu_bar): Force left-to-right direction. Add a FIXME
8923 comment for making that be controlled by a user option.
8924 (push_it, pop_it): Save and restore the state of the
8925 bidi iterator. Save and restore the bidi_p flag.
8926 (pop_it): Iterate out of display property for string iteration as
8927 well.
8928 (iterate_out_of_display_property): Support iteration over strings.
8929 (handle_single_display_spec): Set up it->bidi_it for iteration
8930 over a display string, and call bidi_init_it.
8931 (handle_single_display_spec, next_overlay_string)
8932 (get_overlay_strings_1, push_display_prop): Set up the bidi
8933 iterator for displaying display or overlay strings.
8934 (forward_to_next_line_start): Don't use the shortcut if
8935 bidi-iterating.
8936 (back_to_previous_visible_line_start): If handle_display_prop
8937 pushed the iterator stack, restore the internal state of the bidi
8938 iterator by calling bidi_pop_it same number of times.
8939 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8940 and we are bidi-iterating, don't decrement the iterator position;
8941 instead, set the first_elt flag in the bidi iterator, to produce
8942 the same effect.
8943 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8944 (push_display_prop): xassert that we are iterating a buffer.
8945 (push_it, pop_it): Save and restore paragraph_embedding member.
8946 (handle_single_display_spec, next_overlay_string)
8947 (get_overlay_strings_1, reseat_1, reseat_to_string)
8948 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8949 correctly. Don't assume unibyte strings are not bidi-reordered.
8950 (compute_display_string_pos)
8951 (compute_display_string_end): Fix handling the case of C string.
8952 (push_it, pop_it): Save and restore from_disp_prop_p.
8953 (handle_single_display_spec, push_display_prop): Set the
8954 from_disp_prop_p flag.
8955 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8956 (pop_it): Call iterate_out_of_display_property only if we are
8957 popping after iteration over a string that came from a display
8958 property. Fix a typo in popping stretch info. Add an assertion
8959 for verifying that the iterator position is in sync with the bidi
8960 iterator.
8961 (handle_single_display_spec, get_overlay_strings_1)
8962 (push_display_prop): Fix initialization of paragraph direction for
8963 string when that of the parent object is not yet determined.
8964 (reseat_1): Call bidi_init_it to resync the bidi
8965 iterator with IT's position. (Bug#7616)
8966 (find_row_edges): If ROW->start.pos gives position
8967 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8968 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8969 Reset the from_disp_prop_p flag.
8970 (SAVE_IT, RESTORE_IT): New macros.
8971 (pos_visible_p, face_before_or_after_it_pos)
8972 (back_to_previous_visible_line_start)
8973 (move_it_in_display_line_to, move_it_in_display_line)
8974 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8975 (try_scrolling, redisplay_window, display_line): Use them when
8976 saving a temporary copy of the iterator and restoring it back.
8977 (back_to_previous_visible_line_start, reseat_1)
8978 (init_iterator): Empty the bidi cache "stack".
8979 (move_it_in_display_line_to): If iterator ended up at
8980 EOL, but we never saw any buffer positions smaller than
8981 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8982 motion in bidi-reordered lines.
8983 (move_it_in_display_line_to): Record prev_method and prev_pos
8984 immediately before the call to set_iterator_to_next. Fixes cursor
8985 motion in bidi-reordered lines with stretch glyphs and strings
8986 displayed in margins. (Bug#8133) (Bug#8867)
8987 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8988 TO_CHARPOS.
640c8776
SM
8989 (pos_visible_p): Support positions in bidi-reordered lines.
8990 Save and restore bidi cache.
0bb23927
EZ
8991
8992 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8993 (bidi_paragraph_info): Delete unused struct.
8994 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8995 (bidi_cache_start): New variable.
8996 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8997 to zero.
8998 (bidi_cache_fetch_state, bidi_cache_search)
8999 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9000 (bidi_cache_find, bidi_peek_at_next_level)
9001 (bidi_level_of_next_char, bidi_find_other_level_edge)
9002 (bidi_move_to_visually_next): Compare cache index with
9003 bidi_cache_start rather than with zero.
9004 (bidi_fetch_char): Accept new argument STRING; all callers
9005 changed. Support iteration over a string. Support strings with
9006 display properties. Support unibyte strings. Fix the type of
9007 `len' according to what STRING_CHAR_AND_LENGTH expects.
9008 (bidi_paragraph_init, bidi_resolve_explicit_1)
9009 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9010 (bidi_level_of_next_char, bidi_move_to_visually_next):
9011 Support iteration over a string.
0bb23927
EZ
9012 (bidi_set_sor_type, bidi_resolve_explicit_1)
9013 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9014 can now be zero (for strings); special values 0 and -1 were
9015 changed to -1 and -2, respectively.
9016 (bidi_char_at_pos): New function.
9017 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9018 Call it instead of FETCH_MULTIBYTE_CHAR.
9019 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9020 initialized to valid values.
9021 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9022 values.
9023 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9024 the test for valid cached positions. Fix the logic for looking up
9025 the sentinel state in the cache. GCPRO the Lisp string we are
9026 iterating.
9027 (bidi_push_it, bidi_pop_it): New functions.
9028 (bidi_initialize): Initialize the bidi cache start stack pointer.
9029 (bidi_cache_ensure_space): New function, refactored from part of
9030 bidi_cache_iterator_state. Don't assume the required size is just
9031 one BIDI_CACHE_CHUNK away.
9032 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9033 (bidi_count_bytes, bidi_char_at_pos): New functions.
9034 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9035 always valid if bidi_cache_idx is valid.
9036 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9037 is valid if it's going to be used.
9038 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9039 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9040 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9041 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9042 (bidi_find_other_level_edge, bidi_cache_start_stack):
9043 All variables related to cache indices are now EMACS_INT.
c965adc5 9044
0bb23927
EZ
9045 * dispextern.h (struct bidi_string_data): New structure.
9046 (struct bidi_it): New member `string'. Make flag members be 1-bit
9047 fields, and put them last in the struct.
640c8776
SM
9048 (compute_display_string_pos, compute_display_string_end):
9049 Update prototypes.
0bb23927
EZ
9050 (bidi_push_it, bidi_pop_it): Add prototypes.
9051 (struct iterator_stack_entry): New members bidi_p,
9052 paragraph_embedding, and from_disp_prop_p.
9053 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9054 (bidi_shelve_cache, bidi_unshelve_cache):
9055 Declare prototypes.
0bb23927
EZ
9056
9057 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9058 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9059 and vector-like objects.
9060
9061 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9062 cache around display iteration.
9063
9064 * window.c (Fwindow_end, window_scroll_pixel_based)
9065 (displayed_window_lines, Frecenter): Save and restore the bidi
9066 cache around display iteration.
9067
3bbd2265
LMI
90682011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9069
9070 * editfns.c (Fdelete_region): Clarify the use of the named
9071 parameters (bug#6788).
9072
adc47434
MR
90732011-07-14 Martin Rudalics <rudalics@gmx.at>
9074
9075 * indent.c (Fvertical_motion): Set and restore w->pointm when
9076 saving and restoring the window's buffer (Bug#9006).
9077
837c31f8
LMI
90782011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9079
9080 * editfns.c (Fstring_to_char): Clarify just what is returned
9081 (bug#6576). Text by Eli Zaretskii.
9082
ac389d0c
JB
90832011-07-13 Juanma Barranquero <lekktu@gmail.com>
9084
9085 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9086
0be0ce47
EZ
90872011-07-13 Eli Zaretskii <eliz@gnu.org>
9088
9089 * buffer.c (mmap_find): Fix a typo.
9090
cd18e7e3
JB
90912011-07-13 Johan Bockgård <bojohan@gnu.org>
9092
9093 Fix execution of x selection hooks.
9094 * xselect.c (Qx_lost_selection_functions)
9095 (Qx_sent_selection_functions): New vars.
9096 (syms_of_xselect): DEFSYM them.
9097 (x_handle_selection_request): Pass Qx_sent_selection_functions
9098 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9099 (x_handle_selection_clear,x_clear_frame_selections):
9100 Pass Qx_lost_selection_functions rather than
9101 Vx_lost_selection_functions to Frun_hook_with_args.
9102
47ea7f44
PE
91032011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9104
ac389d0c 9105 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9106 The old code sometimes used this field without initializing it.
9107
47ea7f44
PE
9108 * alloc.c (gc_sweep): Don't read past end of array.
9109 In theory, the old code could also have corrupted Emacs internals,
9110 though it'd be very unlikely.
9111
bc985c87
AS
91122011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9113
9114 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9115 argument. (Bug#4026)
bc985c87 9116
0cf34688
LMI
91172011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9118
b3dadd76
LMI
9119 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9120 key" (bug#4257).
9121
0cf34688
LMI
9122 * window.c (Fset_window_start): Doc fix (bug#4199).
9123 (Fset_window_hscroll): Ditto.
9124
270768cd
PE
91252011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9126
077e3dda 9127 Fix minor new problems caught by GCC 4.6.1.
270768cd 9128 * term.c (init_tty): Remove unused local.
490011a6 9129 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9130 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9131 not used otherwise.
270768cd 9132
b1f58454
CY
91332011-07-12 Chong Yidong <cyd@stupidchicken.com>
9134
9135 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9136
22b9578d
LMI
91372011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9138
6e70ab07
LMI
9139 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9140 are the mini-buffer and the echo area (bug#3320).
9141
22b9578d
LMI
9142 * term.c (init_tty): Remove support for supdup, c10 and perq
9143 terminals, which are no longer supported (bug#1482).
9144
8974cc9f
JB
91452011-07-10 Johan Bockgård <bojohan@gnu.org>
9146
9147 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9148
a560d974
JD
91492011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9150
9151 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9152 for non-popups (Bug#3642).
9153
1dae0f0a
AS
91542011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9155
268c2c36 9156 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9157 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9158 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9159 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9160 * data.c (fmod): Likewise.
9161 * dispnew.c (swap_glyphs_in_rows): Likewise.
9162 * emacs.c (memory_warning_signal): Likewise.
9163 * floatfns.c (float_error): Likewise.
9164 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9165 (otf_open, font_otf_capability, generate_otf_features)
9166 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9167 Likewise.
9168 * image.c (pbm_read_file): Likewise.
9169 * indent.c (string_display_width): Likewise.
9170 * intervals.c (check_for_interval, search_for_interval)
9171 (inc_interval_count, count_intervals, root_interval)
9172 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9173 * lread.c (defalias): Likewise.
268c2c36 9174 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9175 * regex.c (set_image_of_range_1, set_image_of_range)
9176 (regex_grow_registers): Likewise.
9177 * sysdep.c (strerror): Likewise.
9178 * termcap.c (valid_filename_p, tprint, main): Likewise.
9179 * tparam.c (main): Likewise.
9180 * unexhp9k800.c (run_time_remap, save_data_space)
9181 (update_file_ptrs, read_header, write_header, calculate_checksum)
9182 (copy_file, copy_rest, display_header): Likewise.
9183 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9184 Likewise.
9185 * xdisp.c (check_it): Likewise.
9186 * xfaces.c (register_color, unregister_color, unregister_colors):
9187 Likewise.
9188 * xfns.c (print_fontset_result): Likewise.
9189 * xrdb.c (member, fatal, main): Likewise.
9190
99033785
PE
91912011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9192
9193 Fix minor problems found by static checking (Bug#9031).
9194 * chartab.c (char_table_set_range, map_sub_char_table):
9195 Remove unused locals.
9196 (uniprop_table): Now static.
9197 * composite.c (_work_char): Remove unused static var.
9198
9cb2ac56
JB
91992011-07-09 Juanma Barranquero <lekktu@gmail.com>
9200
9201 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9202
f25661f0
JD
92032011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9204
9205 * gtkutil.c (qttip_cb): Remove code without function.
9206
8278c4fe
EZ
92072011-07-09 Eli Zaretskii <eliz@gnu.org>
9208
9209 * w32.c (pthread_sigmask): New stub.
9210
1692ae2d 92112011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9212
8a6ebd58 9213 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9214 sigprocmask is portable only for single-threaded applications, and
9215 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9216 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9217 (LIBES): Use it.
9218 * callproc.c (Fcall_process):
9219 * process.c (create_process):
9220 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9221 Use pthread_sigmask, not sigprocmask.
123403e4 9222
1b854618
JD
92232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9224
9225 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9226 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9227 wrong (Bug#8591).
9228
3fe4b549
JD
92292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9230
0ce7e563
JD
9231 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9232 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9233 (xg_hide_tooltip): Fix comment.
9234
3fe4b549
JD
9235 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9236 in registerServicesMenuSendTypes.
9237 (validRequestorForSendType): Don't check ns_return_types.
9238
9239 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9240 ns_return_type.
9241
5df75e47
JR
92422011-07-08 Jason Rumney <jasonr@gnu.org>
9243
22610910
JR
9244 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9245 SH_SHOW for hidden windows (Bug#5482).
9246
5df75e47
JR
9247 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9248 frame struct members of non-existent frames (Bug#6284).
9249
699c10bd
JD
92502011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9251
4393663b
JD
9252 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9253 variable firstTime not needed on OSX >= 10.6.
9254 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9255 >= 10.5. Use setKnobProportion, setDoubleValue.
9256
9257 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9258 (MAC_OS_X_VERSION_10_5): Define if not defined.
9259 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9260 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9261 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9262
9263 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9264 cString and lossyCString on OSX >= 10.4.
4393663b 9265
58179cce 9266 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9267 sizeToFit on OSX >= 10.2.
9268
9269 * nsimage.m (allocInitFromFile): Don't use deprecated method
9270 bestRepresentationForDevice on OSX >= 10.6.
9271
9272 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9273 to avoid warning.
9274
9275 * emacs.c: Declare unexec_init_emacs_zone.
9276
a63e0781
JD
9277 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9278
699c10bd
JD
9279 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9280
9281 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9282 on svcsMenu (Bug#8842).
9283
9284 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9285 ns_return_types.
9286 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9287
9288 * nsterm.m (QUTF8_STRING): Declare.
9289 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9290 (validRequestorForSendType): Return type is (id).
9291 Change indexOfObjectIdenticalTo to indexOfObject.
9292 Check if we have local selection before returning self (Bug#8842).
9293 (writeSelectionToPasteboard): Put local selection into paste board
9294 if we have a local selection (Bug#8842).
9295 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9296
9297 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9298 (ns_get_local_selection): Declare.
9299
54e10184
LMI
93002011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9301
9888ff71
LMI
9302 * keymap.c (describe_map_tree): Don't insert a double newline at
9303 the end of the buffer (bug#1169) and return whether we inserted
9304 something.
9305
54e10184
LMI
9306 * callint.c (Fcall_interactively): Change "reading args" to
9307 "providing args" to try to clarify what it does (bug#1010).
9308
15fa4783
KH
93092011-07-07 Kenichi Handa <handa@m17n.org>
9310
9311 * composite.c (composition_compute_stop_pos): Ignore a static
9312 composition starting before CHARPOS (Bug#8915).
9313
9314 * xdisp.c (handle_composition_prop): Likewise.
9315
a8815b00
EZ
93162011-07-07 Eli Zaretskii <eliz@gnu.org>
9317
9318 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9319 (Bug#9015)
9320
ef7b981d 93212011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9322
9323 * character.h (unicode_category_t): New enum type.
9324
9325 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9326 (Qchar_code_property_table): New variable.
9327 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9328 (UNIPROP_COMPRESSED_FORM_P): New macros.
9329 (char_table_ascii): Uncompress the compressed values.
9330 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9331 Uncompress the compressed values.
ac389d0c 9332 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9333 (char_table_ref_and_range): Uncompress the compressed values.
9334 (sub_char_table_set): New arg is_uniprop. Callers changed.
9335 Uncompress the compressed values.
9336 (sub_char_table_set_range): Args changed. Callers changed.
9337 (char_table_set_range): Adjuted for the above change.
9338 (map_sub_char_table): Delete args default_val and parent. Add arg
9339 top. Give decoded values to a Lisp function.
640c8776 9340 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9341 values to a Lisp function. Gcpro more variables.
9342 (uniprop_table_uncompress)
9343 (uniprop_decode_value_run_length): New functions.
9344 (uniprop_decoder, uniprop_decoder_count): New variables.
9345 (uniprop_get_decoder, uniprop_encode_value_character)
9346 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9347 New functions.
9348 (uniprop_encoder, uniprop_encoder_count): New variables.
9349 (uniprop_get_encoder, uniprop_table)
9350 (Funicode_property_table_internal, Fget_unicode_property_internal)
9351 (Fput_unicode_property_internal): New functions.
9352 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9353 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9354 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9355 char-code-property-alist.
9356
640c8776 9357 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9358 Vunicode_category_table.
9359
640c8776 9360 * font.c (font_range): Adjust for the change of
c805dec0
KH
9361 Vunicode_category_table.
9362
76b397fb
DN
93632011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9364
9365 * m/iris4d.h: Remove file, move contents ...
9366 * s/irix6-5.h: ... here.
9367
22b4128e
PE
93682011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9369
9370 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9371 * alloc.c (mark_buffer):
9372 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9373 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9374 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9375 This isn't true in general, and it's particularly not true
9376 if Emacs is configured with --with-wide-int.
9377 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9378 New macros, used in the buffer.c change.
9379
869795d6
JD
93802011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9381
9382 * xsettings.c: Use both GConf and GSettings if both are available.
9383 (store_config_changed_event): Add comment.
9384 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9385 (store_tool_bar_style_changed): New functions.
5e617bc2 9386 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9387 (struct xsettings): Move font inside HAVE_XFT.
9388 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9389 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9390 Move inside HAVE_XFT.
640c8776 9391 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9392 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9393 also.
9394 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9395 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9396 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9397 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9398 (parse_settings): Move check for font inside HAVE_XFT.
9399 (read_settings, apply_xft_settings): Add comment.
9400 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9401 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9402 call store_font_name_changed.
9403 (xft_settings_event): Add comment.
9404 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9405 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9406 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9407 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9408 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9409 (xsettings_get_system_font, xsettings_get_system_normal_font):
9410 Add comment.
869795d6 9411
d8ed26bd
PE
94122011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9413
9414 Random fixes. E.g., (random) never returned negative values.
9415 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9416 subseconds part to the entropy, as that's a bit more random.
9417 Prefer signed to unsigned, since the signedness doesn't matter and
9418 in general we prefer signed. When given a limit, use a
9419 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9420 latter isn't right if USE_2_TAGS_FOR_INTS.
9421 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9422 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9423
cabf1cac
SM
94242011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9425
9426 * textprop.c (text_property_stickiness):
9427 Obey Vtext_property_default_nonsticky.
9428 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9429 * w32fns.c (syms_of_w32fns):
9430 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9431
6e9b2be9
PE
94322011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9433
9434 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9435 This is more efficient than Ffile_directory_p and avoids a minor race.
9436
90186c68
LMI
94372011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9438
7c301272
LMI
9439 * buffer.c (Foverlay_put): Say what the return value is
9440 (bug#7835).
9441
c4f2d8d4
LMI
9442 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9443 is a directory before asking whether to use the file name
9444 (bug#7564).
ad637907
LMI
9445 (barf_or_query_if_file_exists): Make the "File is a directory"
9446 error be more correct.
c4f2d8d4 9447
90186c68
LMI
9448 * fns.c (Frequire): Remove the mention of the .gz files, since
9449 that's installation-specific, but keep the mention of
9450 `get-load-suffixes'.
9451
da64016e
PE
94522011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9453
9454 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9455 Report string overflow if the output is too long.
9456
7d47b580
JB
94572011-07-04 Juanma Barranquero <lekktu@gmail.com>
9458
a555cb87
JB
9459 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9460 (syms_of_gnutls): Remove duplicate DEFSYM for
9461 Qgnutls_bootprop_verify_hostname_error, an error for
9462 Qgnutls_bootprop_verify_error (which is no longer used).
9463
7d47b580
JB
9464 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9465 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9466 Also (re)move comments that are misplaced or no longer relevant.
9467
1e49bfab
LMI
94682011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9469
9470 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9471
1485f4c0
CY
94722011-07-03 Chong Yidong <cyd@stupidchicken.com>
9473
9474 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9475 and background color parameters if they have been changed.
9476
a9ab721e
LMI
94772011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9478
9479 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9480
cf7cff57
PE
94812011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9482
2e13213d
PE
9483 * xsettings.c (SYSTEM_FONT): Define only when used.
9484 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9485
cf7cff57
PE
9486 * keymap.c (access_keymap_1): Now static.
9487
7a8e04f7
CY
94882011-07-02 Chong Yidong <cyd@stupidchicken.com>
9489
9490 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9491 leave any prefix arg for the up event (Bug#1586).
9492
61352f62
LMI
94932011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9494
69bb1ef7
LMI
9495 * lread.c (syms_of_lread): Mention single symbols defined by
9496 `defvar' or `defconst' (bug#7154).
9497
61352f62 9498 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9499 (Frequire): Mention get-load-suffixes.
61352f62 9500
28545e04
MR
95012011-07-02 Martin Rudalics <rudalics@gmx.at>
9502
9503 * window.h (window): Remove clone_number slot.
9504 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9505 Remove.
9506 (make_parent_window, make_window, saved_window)
9507 (Fset_window_configuration, save_window_save): Don't deal with
9508 clone numbers.
9509 * buffer.c (Qclone_number): Remove declaration.
9510 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9511
3349e122
SM
95122011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9513
9514 Add multiple inheritance to keymaps.
9515 * keymap.c (Fmake_composed_keymap): New function.
9516 (Fset_keymap_parent): Simplify.
9517 (fix_submap_inheritance): Remove.
9518 (access_keymap_1): New function extracted from access_keymap to handle
9519 embedded parents and handle lists of maps.
9520 (access_keymap): Use it.
9521 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9522 (Fcopy_keymap): Handle embedded parents.
9523 (Fcommand_remapping, define_as_prefix): Simplify.
9524 (Fkey_binding): Simplify.
9525 (syms_of_keymap): Move minibuffer-local-completion-map,
9526 minibuffer-local-filename-completion-map,
9527 minibuffer-local-must-match-map, and
9528 minibuffer-local-filename-must-match-map to Elisp.
9529 (syms_of_keymap): Defsubr make-composed-keymap.
9530 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9531 (parse_menu_item): Trivial simplification.
9532
3279eb87
GM
95332011-07-01 Glenn Morris <rgm@gnu.org>
9534
9535 * Makefile.in (SETTINGS_LIBS): Fix typo.
9536
4550efdf
KI
95372011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9538
9539 * coding.c (Fencode_coding_string): Record the last coding system
9540 used, as the function doc string says (bug#8738).
9541
0949d2b6
JD
95422011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9543
9544 * xsettings.c (store_monospaced_changed): Take new font as arg and
9545 check for change against current_mono_font.
9546 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9547 (emacs_settings_constructor, emacs_settings_get_property)
9548 (emacs_settings_set_property, emacs_settings_class_init)
9549 (emacs_settings_init, gsettings_obj): Remove.
9550 (something_changedCB): New function for HAVE_GSETTINGS.
9551 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9552 with value as argument.
9553 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9554 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9555 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9556 "changed".
9557
9558 * xgselect.c: Add defined (HAVE_GSETTINGS).
9559 (xgselect_initialize): Ditto.
9560
9561 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9562 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9563 xg_select.
9564
bbc6b304
PE
95652011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9566
9567 * eval.c (struct backtrace): Simplify and port the data structure.
9568 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9569 signed bit field, as this assumption is not portable and it makes
9570 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9571 "char debug_on_exit : 1" as this is not portable either; instead,
9572 use the portable "unsigned int debug_on_exit : 1". Remove unused
9573 member evalargs. Remove obsolete comments about cc bombing out.
9574
9851bfc5
JD
95752011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9576
51bb811f 9577 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9578 Let HAVE_GSETTINGS override HAVE_GCONF.
9579 (store_monospaced_changed): New function.
9580 (EMACS_SETTINGS): A new type derived from GObject to handle
9581 GSettings notifications.
9582 (emacs_settings_constructor, emacs_settings_get_property)
9583 (emacs_settings_set_property, emacs_settings_class_init):
9584 New functions.
9585 (gsettings_client, gsettings_obj): New variables.
9586 (GSETTINGS_SCHEMA): New define.
9587 (something_changedCB): Call store_monospaced_changed.
9588 (init_gsettings): New function.
9589 (xsettings_initialize): Call init_gsettings.
9590 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9591 to NULL.
9592
640c8776 9593 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9594 GCONF_CFLAGS/LIBS.
9595
5386012d
MR
95962011-06-29 Martin Rudalics <rudalics@gmx.at>
9597
9598 * window.c (resize_root_window, grow_mini_window)
9599 (shrink_mini_window): Rename Qresize_root_window to
9600 Qwindow_resize_root_window and Qresize_root_window_vertically to
9601 Qwindow_resize_root_window_vertically.
9602
f13e0b08
PE
96032011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9604
9605 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9606
94515237
JB
96072011-06-27 Juanma Barranquero <lekktu@gmail.com>
9608
9609 * makefile.w32-in: Redesign dependencies so they reflect more
9610 clearly which files are directly included by each source file,
9611 and not through other includes.
9612
e43b6e43
MR
96132011-06-27 Martin Rudalics <rudalics@gmx.at>
9614
9615 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9616 (sort_overlays, overlay_strings): When an overlay's clone number
9617 matches the window's clone number process the overlay even if
9618 the overlay's window property doesn't match the current window.
9619
d68443dc
MR
9620 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9621 (Fwindow_hchild): Rename to Fwindow_left_child.
9622 (Fwindow_next): Rename to Fwindow_next_sibling.
9623 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9624 (resize_window_check): Rename to window_resize_check.
9625 (resize_window_apply): Rename to window_resize_apply.
9626 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9627 (Fdelete_other_windows_internal, resize_frame_windows)
9628 (Fsplit_window_internal, Fdelete_window_internal)
9629 (grow_mini_window, shrink_mini_window)
9630 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9631
c7e73be5
JD
96322011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9633
9634 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9635 (emacs_fixed_set_min_size): Remove.
9636 (emacs_fixed_new): Take frame as argument.
9637
9638 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9639 (_EmacsFixedPrivate): Remove minwidth/height.
9640 Add struct frame *f.
9641 (emacs_fixed_init): Initialize priv->f.
9642 (get_parent_class, emacs_fixed_set_min_size): Remove.
9643 (emacs_fixed_new): Set priv->f to argument.
9644 (emacs_fixed_get_preferred_width)
9645 (emacs_fixed_get_preferred_height): Use min_width/height from
9646 frames size_hint to set minimum and natural (Bug#8919).
9647 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9648 and use min_width/height from frames size_hint to set
9649 min_width/height (Bug#8919).
9650
9651 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9652 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9653 Fix indentation.
c7e73be5 9654
cf99dcf8
EZ
96552011-06-26 Eli Zaretskii <eliz@gnu.org>
9656
9657 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9658 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9659 called at ZV.
9660
029529ac
CY
96612011-06-26 Chong Yidong <cyd@stupidchicken.com>
9662
9663 * process.c (wait_reading_process_output): Bypass select if
9664 waiting for a cell while ignoring keyboard input, and input is
9665 pending. Suggested by Jan Djärv (Bug#8869).
9666
7a7ef429
PE
96672011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9668
9669 Use gnulib's dup2 module instead of rolling our own.
9670 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9671
11fdef7d 96722011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9673
9674 * dispnew.c (scrolling_window): Before scrolling, turn off a
9675 mouse-highlight in the window being scrolled.
9676
cd3520a4
JB
96772011-06-24 Juanma Barranquero <lekktu@gmail.com>
9678
9679 Move DEFSYM to lisp.h and use everywhere.
9680
9681 * character.h (DEFSYM): Move declaration...
9682 * lisp.h (DEFSYM): ...here.
9683
9684 * gnutls.c:
9685 * minibuf.c:
9686 * w32menu.c:
9687 * w32proc.c:
9688 * w32select.c: Don't include character.h.
9689
9690 * alloc.c (syms_of_alloc):
9691 * buffer.c (syms_of_buffer):
9692 * bytecode.c (syms_of_bytecode):
9693 * callint.c (syms_of_callint):
9694 * casefiddle.c (syms_of_casefiddle):
9695 * casetab.c (init_casetab_once):
9696 * category.c (init_category_once, syms_of_category):
9697 * ccl.c (syms_of_ccl):
9698 * cmds.c (syms_of_cmds):
9699 * composite.c (syms_of_composite):
9700 * dbusbind.c (syms_of_dbusbind):
9701 * dired.c (syms_of_dired):
9702 * dispnew.c (syms_of_display):
9703 * doc.c (syms_of_doc):
9704 * editfns.c (syms_of_editfns):
9705 * emacs.c (syms_of_emacs):
9706 * eval.c (syms_of_eval):
9707 * fileio.c (syms_of_fileio):
9708 * fns.c (syms_of_fns):
9709 * frame.c (syms_of_frame):
9710 * fringe.c (syms_of_fringe):
9711 * insdel.c (syms_of_insdel):
9712 * keymap.c (syms_of_keymap):
9713 * lread.c (init_obarray, syms_of_lread):
9714 * macros.c (syms_of_macros):
9715 * msdos.c (syms_of_msdos):
9716 * print.c (syms_of_print):
9717 * process.c (syms_of_process):
9718 * search.c (syms_of_search):
9719 * sound.c (syms_of_sound):
9720 * syntax.c (init_syntax_once, syms_of_syntax):
9721 * terminal.c (syms_of_terminal):
9722 * textprop.c (syms_of_textprop):
9723 * undo.c (syms_of_undo):
9724 * w32.c (globals_of_w32):
9725 * window.c (syms_of_window):
9726 * xdisp.c (syms_of_xdisp):
9727 * xfaces.c (syms_of_xfaces):
9728 * xfns.c (syms_of_xfns):
9729 * xmenu.c (syms_of_xmenu):
9730 * xsettings.c (syms_of_xsettings):
9731 * xterm.c (syms_of_xterm): Use DEFSYM.
9732
4228cf16
TZ
97332011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9734
cd3520a4 9735 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9736
7fcccf1e
PE
97372011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9738
7efb4e0e
PE
9739 Integer and buffer overflow fixes (Bug#8873).
9740
ff5844ad
PE
9741 * print.c (printchar, strout): Check for string overflow.
9742 (PRINTPREPARE, printchar, strout):
9743 Don't set size unless allocation succeeds.
9744
90532f02
PE
9745 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9746 for sizes. Check for string overflow more accurately.
9747 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9748
6d84508d
PE
9749 * macros.c: Integer and buffer overflow fixes.
9750 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9751 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9752 Use ptrdiff_t, not int, for sizes.
9753 Don't increment bufsize until after realloc succeeds.
9754 Check for size-calculation overflow.
9755 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9756
437b2cb4
PE
9757 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9758
8b9ac8b4
PE
9759 * lread.c: Integer overflow fixes.
9760 (read_integer): Radix is now EMACS_INT, not int,
9761 to improve quality of diagnostics for out-of-range radices.
9762 Calculate buffer size correctly for out-of-range radices.
9763 (read1): Check for integer overflow in radices, and in
9764 read-circle numbers.
82cb60d3
PE
9765 (read_escape): Avoid int overflow.
9766 (Fload, openp, read_buffer_size, read1)
9767 (substitute_object_recurse, read_vector, read_list, map_obarray):
9768 Use ptrdiff_t, not int, for sizes.
9769 (read1): Use EMACS_INT, not int, for sizes.
20270765 9770 Check for size overflow.
8b9ac8b4 9771
7fcccf1e
PE
9772 * image.c (cache_image): Check for size arithmetic overflow.
9773
bfbbd7e7
PE
9774 * lread.c: Integer overflow issues.
9775 (saved_doc_string_size, saved_doc_string_length)
9776 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9777 Now ptrdiff_t, not int.
9778 (read1): Don't assume doc string length fits in int. Check for
9779 out-of-range doc string lengths.
9780 (read_list): Don't assume file position fits in int.
39019e54 9781 (read_escape): Check for hex character overflow.
bfbbd7e7 9782
4e323265
LL
97832011-06-22 Leo Liu <sdl.web@gmail.com>
9784
9785 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9786 Move to minibuffer.el.
9787
85fece3e
PE
97882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9789
20b84ce9 9790 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9791 The following patches are for when GLYPH_DEBUG && !XASSERT.
9792 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9793 * dispnew.c (flush_stdout):
9794 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9795 Mark as externally visible.
9796 * dispnew.c (check_window_matrix_pointers): Now static.
9797 * dispnew.c (window_to_frame_vpos):
9798 * xfns.c (unwind_create_frame):
9799 * xterm.c (x_check_font): Remove unused local.
9800 * scroll.c (CHECK_BOUNDS):
9801 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9802 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9803 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9804 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9805 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9806 Now static.
9807 (debug_method_add): Use va_list and vsprintf rather than relying
9808 on undefined behavior with wrong number of arguments.
9809 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9810 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9811 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9812 since we're not interested in debugging glyphs with old libraries.
9813 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9814 GCC 4.6.0's static checking.
9815
0766b489
PE
98162011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9817
31fd4b32
PE
9818 Integer overflow and signedness fixes (Bug#8873).
9819 A few related buffer overrun fixes, too.
9820
b79e8648
PE
9821 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9822
0766b489
PE
9823 * dispextern.h (struct face.stipple):
9824 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9825 (x_bitmap_mask, x_allocate_bitmap_record)
9826 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9827 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9828 (x_create_bitmap_from_xpm_data):
9829 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9830 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9831 (.bitmaps_last):
9832 * xfaces.c (load_pixmap):
9833 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9834 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9835 (.bitmaps_last, struct x_output.icon_bitmap):
9836 Use ptrdiff_t, not int, for bitmap indexes.
9837 (x_allocate_bitmap_record): Check for size overflow.
9838 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9839
b081724f
PE
9840 Use ptrdiff_t, not int, for overlay counts.
9841 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9842 * editfns.c (overlays_around, get_pos_property):
9843 * textprop.c (get_char_property_and_overlay):
9844 * xdisp.c (next_overlay_change, note_mouse_highlight):
9845 * xfaces.c (face_at_buffer_position):
21514da7
PE
9846 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9847 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9848 (Fnext_overlay_change, Fprevious_overlay_change)
9849 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9850 Use ptrdiff_t, not int, for sizes.
21514da7 9851 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9852
3de73e5e
PE
9853 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9854
2606c57b
PE
9855 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9856 (x_session_initialize): Do not assume string length fits in int.
9857
aaafe47a
PE
9858 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9859 This is unlikely, but can occur if DPI is outlandish.
9860
2674ddc8 9861 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9862 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9863
28154962
PE
9864 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9865 * xrdb.c (magic_file_p, search_magic_path):
9866 Omit last arg SUFFIX; it was always 0. All callers changed.
9867 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9868
7de51af5
PE
9869 * xfont.c (xfont_match): Avoid need for strlen.
9870
25ed6cc3
PE
9871 * xfns.c: Don't assume strlen fits in int.
9872 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9873
4eab31dd
PE
9874 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9875 not unsigned long, as we prefer signed integers. All callers changed.
9876 Detect integer overflow in repeat count.
9877 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9878 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9879
171e2a58
PE
9880 * termcap.c: Don't assume sizes fit in int and never overflow.
9881 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9882 (gobble_line): Check for size-calculation overflow.
9883
ad39faca 9884 * minibuf.c (Fread_buffer):
6e5bb2dc 9885 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9886 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9887 Don't assume string length fits in int.
9888
52c61c22 9889 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9890 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9891
b5b8c9e5
PE
9892 * font.c: Don't assume string length fits in int.
9893 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9894 Use ptrdiff_t, not int.
ccd6111c
PE
9895 (font_intern_prop): Don't assume string length fits in int.
9896 Don't assume integer property fits in fixnum.
9897 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9898
882f0d81 9899 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9900 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9901 Reformulate so as not to need the command string.
9902 Invoke gzip -cd rather than gunzip, as it's more portable.
9903 (lock_info_type, lock_file_1, lock_file):
9904 Don't assume pid_t and time_t fit in unsigned long.
9905 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9906 (current_lock_owner): Prefer signed type for sizes.
9907 Use memcpy, not strncpy, where memcpy is what is really wanted.
9908 Don't assume (via atoi) that time_t and pid_t fit in int.
9909 Check for time_t and/or pid_t out of range, e.g., via a network share.
9910 Don't alloca where an auto var works fine.
9911
93f4cf88
PE
9912 * fileio.c: Fix some integer overflow issues.
9913 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9914 Don't assume string length fits in int.
9915 (directory_file_name): Don't assume string length fits in long.
9916 (make_temp_name): Don't assume pid fits in int, or that its print
9917 length is less than 20.
9918
f3e92b69
PE
9919 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9920
1bfdaf10
PE
9921 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9922
35016e9a
PE
9923 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9924
3d1e65a1
PE
9925 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9926 We prefer signed integers, even for size calculations.
9927
0b963a93
PE
9928 * emacs.c: Don't assume string length fits in 'int'.
9929 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9930 (main): Don't invoke strlen when not needed.
9931
573f4b54
PE
9932 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9933 (XD_DEBUG_MESSAGE): Don't waste a byte.
9934
989f33ba
PE
9935 * callproc.c (getenv_internal_1, getenv_internal)
9936 (Fgetenv_internal):
965d34eb
PE
9937 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9938
e4d29b33
PE
9939 * lread.c (invalid_syntax): Omit length argument.
9940 All uses changed. This doesn't fix a bug, but it simplifies the
9941 code away from its former Hollerith-constant appearance, and it's
9942 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9943 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9944
eb49b136
PE
9945 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9946 This didn't break anything, but it didn't help either.
9947 It's confusing to put a bogus integer in a place where the actual
9948 value does not matter.
9f62aeb1 9949 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9950 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9951
15375a22
PE
9952 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9953 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9954 implementation.
b61cc01c
PE
9955 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9956 We prefer signed types, and the value cannot exceed the EMACS_INT
9957 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9958 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9959 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9960 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9961
53b2623d
PE
9962 * indent.c (sane_tab_width): New function.
9963 (current_column, scan_for_column, Findent_to, position_indentation)
9964 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9965 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9966
51cab52b 9967 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9968
f2ed8a70
PE
9969 * lisp.h (lint_assume): New macro.
9970 * composite.c (composition_gstring_put_cache):
9971 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9972
abe80cc6
PE
9973 * editfns.c, insdel.c:
9974 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9975
b02c740e
PE
9976 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9977
ebc96716
PE
9978 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9979
b4e50fa0 9980 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9981 Use much-faster test for byte-length change.
311d5d7c 9982 Don't assume string byte-length fits in 'int'.
a4cf38e4 9983 Check that character arg fits in 'int'.
85461888 9984 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9985
c0c1ee9f
PE
9986 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9987
a498d7f4
PE
9988 * fns.c (concat): Catch string overflow earlier.
9989 Do not rely on integer wraparound.
9990
51cab52b
PE
9991 * dispextern.h (struct it.overlay_strings_charpos)
9992 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9993 * xdisp.c (forward_to_next_line_start)
9994 (back_to_previous_visible_line_start)
9995 (reseat_at_next_visible_line_start, next_element_from_buffer):
9996 Don't arbitrarily truncate the value of 'selective' to int.
9997
76031fad
PE
9998 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9999
5eb55db9
PE
10000 * composite.c: Don't truncate sizes to 'int'.
10001 (composition_gstring_p, composition_reseat_it)
10002 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10003 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10004 not EMACS_UINT, for indexes.
5eb55db9 10005
0703a717
PE
10006 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10007
d6202519
PE
10008 * buffer.c: Include <verify.h>.
10009 (struct sortvec.priority, struct sortstr.priority):
8961a454 10010 Now EMACS_INT, not int.
c20998a7 10011 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10012 (struct sortstr.size, record_overlay_string)
10013 (struct sortstrlist.size, struct sortlist.used):
10014 Don't truncate size to int.
10015 (record_overlay_string): Check for size-calculation overflow.
d6202519 10016 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10017
d5a19415
JM
100182011-06-22 Jim Meyering <meyering@redhat.com>
10019
029529ac 10020 Don't leak an XBM-image-sized buffer
d5a19415
JM
10021 * image.c (xbm_load): Free the image buffer after using it.
10022
a9041e6c
PE
100232011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10024
10025 Port to Sun C.
10026 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10027 that Sun C diagnosed.
10028 * fns.c (secure_hash): Fix pointer signedness issue.
10029 * intervals.c (static_offset_intervals): New function.
10030 (offset_intervals): Use it.
10031
7f3f739f
LL
100322011-06-21 Leo Liu <sdl.web@gmail.com>
10033
10034 * deps.mk (fns.o):
10035 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10036 sha512.h.
10037
10038 * fns.c (secure_hash): Rename from crypto_hash_function and change
10039 the first arg to accept symbols.
5b66d427 10040 (Fsecure_hash): New primitive.
7f3f739f
LL
10041 (syms_of_fns): New symbols.
10042
76147d94
DD
100432011-06-20 Deniz Dogan <deniz@dogan.se>
10044
10045 * process.c (Fset_process_buffer): Clarify return value in
10046 docstring.
10047
7d7d0045
CY
100482011-06-18 Chong Yidong <cyd@stupidchicken.com>
10049
10050 * dispnew.c (add_window_display_history): Use BVAR.
10051
10052 * xdisp.c (debug_method_add): Use BVAR.
10053 (check_window_end, dump_glyph_matrix, dump_glyph)
10054 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10055
10056 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10057 Likewise.
10058
10059 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10060 check till after the cache is created in init_frame_faces.
10061
ff2bc410
SM
100622011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10063
10064 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10065
28177add
PE
100662011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10067
dd3482fe
PE
10068 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10069 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10070 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10071
393d71f3 10072 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10073 * fileio.c (Finsert_file_contents):
10074 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10075 Remove the old (too-loose) buffer overflow checks.
10076 They weren't needed, since make_gap checks for buffer overflow.
10077 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10078 The old code merely checked for Emacs fixnum overflow, and relied
10079 on undefined (wraparound) behavior. The new code avoids undefined
10080 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10081
2e6813b0 10082 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10083 Tune. Don't use wider integers than needed. Don't use alloca.
10084 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10085
599a9e4f
PE
10086 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10087
99561444
PE
10088 * insdel.c, lisp.h (buffer_overflow): New function.
10089 (insert_from_buffer_1, replace_range, replace_range_2):
10090 * insdel.c (make_gap_larger):
10091 * editfns.c (Finsert_char):
10092 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10093
28177add
PE
10094 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10095
e69dafad
PE
100962011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10097
4baa020d 10098 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10099
b1c46f02
PE
10100 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10101 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10102
e69dafad
PE
10103 * fileio.c: Don't assume EMACS_INT fits in off_t.
10104 (emacs_lseek): New static function.
10105 (Finsert_file_contents, Fwrite_region): Use it.
10106 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10107
566684ea
PE
10108 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10109
e6966cd6
PE
10110 * fns.c: Don't overflow int when computing a list length.
10111 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10112 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10113 truncation on 64-bit hosts. Check for QUIT every
10114 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10115 faster and is responsive enough.
10116 (Flength): Report an error instead of overflowing an integer.
10117 (Fsafe_length): Return a float if the value is not representable
10118 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10119 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10120 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10121
dd0b0efb
PE
10122 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10123 (header_size, word_size): New constants.
10124 (allocate_vectorlike): Don't check size overflow here.
10125 (allocate_vector): Check it here instead, since this is the only
10126 caller of allocate_vectorlike that could cause overflow.
10127 Check that the new vector's length is representable as a fixnum.
10128
86fe5cfe
PE
10129 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10130 The previous code was bogus. For example, next_almost_prime (32)
10131 returned 39, which is undesirable as it is a multiple of 3; and
10132 next_almost_prime (24) returned 25, which is a multiple of 5 so
10133 why was the code bothering to check for multiples of 7?
10134
80e88859
PE
10135 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10136
4a2f0ad6
PE
10137 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10138
f66c7cf8
PE
10139 Variadic C functions now count arguments with ptrdiff_t.
10140 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10141 Back then I didn't know that the Emacs coding style prefers signed int.
10142 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10143 were being counted with int, which may truncate counts on 64-bit
10144 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10145 * lisp.h (struct Lisp_Subr.function.aMANY)
10146 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10147 Arg counts are now ptrdiff_t, not size_t.
10148 All variadic functions and their callers changed accordingly.
10149 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10150 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10151 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10152 * callint.c (Fcall_interactively): Check arg count for overflow,
10153 to avoid potential buffer overrun. Use signed char, not 'int',
10154 for 'varies' array, so that we needn't bother to check its size
10155 calculation for overflow.
10156 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10157 * eval.c (apply_lambda):
10158 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10159 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10160 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10161
a1759b76
PE
10162 * callint.c (Fcall_interactively): Don't use index var as event count.
10163
d96be9fc
PE
10164 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10165 * mem-limits.h (SIZE): Remove; no longer used.
10166
a690a978 10167 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10168
578c21e6
PE
10169 Remove unnecessary casts.
10170 * xterm.c (x_term_init):
10171 * xfns.c (x_set_border_pixel):
10172 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10173 These aren't needed now that we assume ANSI C.
10174
96f53c6c
PE
10175 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10176 It's more likely to cause problems (due to unsigned overflow)
10177 than to cure them.
10178
83c77d31
PE
10179 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10180
ee2079f1
PE
10181 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10182
6da65536
PE
10183 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10184
7147c4a4
PE
10185 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10186
193e32d9
PE
10187 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10188
e5533da6
PE
10189 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10190
9910e595
PE
10191 GLYPH_CODE_FACE returns EMACS_INT, not int.
10192 * dispextern.h (merge_faces):
10193 * xfaces.c (merge_faces):
01103c44
PE
10194 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10195 Don't assume EMACS_INT fits in int.
9910e595 10196
2638320e
PE
10197 * character.h (CHAR_VALID_P): Remove unused parameter.
10198 * fontset.c, lisp.h, xdisp.c: All uses changed.
10199
045eb8d9
PE
10200 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10201
c1f134b5
PE
10202 * fns.c (concat): Minor tuning based on overflow analysis.
10203 This doesn't fix any bugs. Use int to hold character, instead
10204 of constantly refetching from Emacs object. Use XFASTINT, not
10205 XINT, for value known to be a character. Don't bother comparing
10206 a single byte to 0400, as it's always less.
10207
395fcb93 10208 * floatfns.c (Fexpt):
327eeec8
PE
10209 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10210
abbd3d23
PE
10211 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10212 for characters.
10213
684a03ef
PE
10214 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10215
0fed43f3
PE
10216 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10217 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10218 incorrectly succeed when S was a string, because 4294967386 was
10219 truncated before it was used.
10220
8fd02eb7
PE
10221 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10222 Otherwise, an out-of-range integer could cause undefined behavior
10223 on a 64-bit host.
10224
f8c86b69
PE
10225 * composite.c: Use int, not EMACS_INT, for characters.
10226 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10227 EMACS_INT, for values that are known to be in character range.
10228 This doesn't fix any bugs but is the usual style inside Emacs and
10229 may generate better code on 32-bit machines.
10230
34206dd2
PE
10231 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10232 This is for reasons similar to the recent CHAR_STRING fix.
10233 * charset.c (Fencode_char): Check that character arg is actually
10234 a character. Pass an int to ENCODE_CHAR.
10235 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10236 wider than 'int', as a compile-time check to prevent future regressions
10237 in this area.
10238
c5958d4c 10239 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10240
10241 Make sure a 64-bit char is never passed to CHAR_STRING.
10242 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10243 by silently ignoring the top 32 bits, allowing some values
10244 that were far too large to be valid characters.
10245 * character.h: Include <verify.h>.
10246 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10247 arguments are no wider than unsigned, as a compile-time check
10248 to prevent future regressions in this area.
10249 * data.c (Faset):
01103c44 10250 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10251 (Fsubst_char_in_region):
10252 * fns.c (concat):
10253 * xdisp.c (decode_mode_spec_coding):
10254 Adjust to CHAR_STRING's new requirement.
10255 * editfns.c (Finsert_char, Fsubst_char_in_region):
10256 * fns.c (concat): Check that character args are actually
10257 characters. Without this test, these functions did the wrong
10258 thing with wildly out-of-range values on 64-bit hosts.
10259
d37ca623
PE
10260 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10261 These casts should not be needed on 32-bit hosts, either.
10262 * keyboard.c (read_char):
10263 * lread.c (Fload): Remove casts to unsigned.
10264
ea204efb
PE
10265 * lisp.h (UNSIGNED_CMP): New macro.
10266 This fixes comparison bugs on 64-bit hosts.
10267 (ASCII_CHAR_P): Use it.
10268 * casefiddle.c (casify_object):
01103c44 10269 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10270 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10271 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10272 * dispextern.h (FACE_FROM_ID):
10273 * keyboard.c (read_char): Use UNSIGNED_CMP.
10274
41cb286c
PE
10275 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10276 not to EMACS_INT, to avoid GCC warning.
10277
4a1b9832
PE
10278 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10279
55daad71
PE
10280 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10281 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10282 isn't needed on 32-bit machines.
8f95c75c 10283
01103c44
PE
10284 * buffer.c (Fgenerate_new_buffer_name):
10285 Use EMACS_INT for count, not int.
0ceccced 10286 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10287
10288 * data.c (Qcompiled_function): Now static.
10289
c6f072e7
PE
10290 * window.c (window_body_lines): Now static.
10291
20ce5912
PE
10292 * image.c (gif_load): Rename local to avoid shadowing.
10293
9c4c5f81
PE
10294 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10295 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10296 * alloc.c (make_save_value): Integer argument is now of type
10297 ptrdiff_t, not int.
10298 (mark_object): Use ptrdiff_t, not int.
10299 * lisp.h (pD): New macro.
10300 * print.c (print_object): Use it.
10301
c0c5c8ae
PE
10302 * alloc.c: Use EMACS_INT, not int, to count objects.
10303 (total_conses, total_markers, total_symbols, total_vector_size)
10304 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10305 (total_free_floats, total_floats, total_free_intervals)
10306 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10307 Now EMACS_INT, not int. All uses changed.
10308 (Fgarbage_collect): Compute overall total using a double, so that
10309 integer overflow is less likely to be a problem. Check for overflow
10310 when converting back to an integer.
5a25e253
PE
10311 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10312 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10313 These were 'int' variables that could overflow on 64-bit hosts;
10314 they were never used, so remove them instead of repairing them.
211a0b2a 10315 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10316 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10317 Previously, this ceilinged at INT_MAX, but that doesn't work on
10318 64-bit machines.
e46bb31a 10319 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10320
c78baabf 10321 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10322 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10323 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10324 when a (possibly-narrower) signed value would do just as well.
10325 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10326
c9d624c6
PE
10327 * alloc.c: Catch some string size overflows that we were missing.
10328 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10329 for convenience in STRING_BYTES_MAX.
10330 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10331 The definition here is exact; the one in lisp.h was approximate.
10332 (allocate_string_data): Check for string overflow. This catches
10333 some instances we weren't catching before. Also, it catches
10334 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10335 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10336 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10337
c9d624c6
PE
10338 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10339 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10340 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10341
353032ce
PE
10342 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10343
2bccce07
PE
10344 * alloc.c (Fmake_string): Check for out-of-range init.
10345
0ac30604
SM
103462011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10347
10348 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10349
c195f2de
JD
103502011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10351
10352 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10353 xg_get_default_scrollbar_width.
10354
10355 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10356 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10357 (style_changed_cb): Call update_theme_scrollbar_width and call
10358 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10359 all frames (Bug#8505).
10360 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10361 Call gtk_window_set_resizable if HAVE_GTK3.
10362 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10363 and height if HAVE_GTK3 (Bug#8505).
10364 (scroll_bar_width_for_theme): New variable.
10365 (update_theme_scrollbar_width): New function.
10366 (xg_get_default_scrollbar_width): Move code to
10367 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10368 (xg_initialize): Call update_theme_scrollbar_width.
10369
10370 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10371
10372 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10373
e10ac9f1
MR
103742011-06-12 Martin Rudalics <rudalics@gmx.at>
10375
10376 * frame.c (make_frame): Call other_buffer_safely instead of
10377 other_buffer.
10378
10379 * window.c (temp_output_buffer_show): Call display_buffer with
10380 second argument Vtemp_buffer_show_specifiers and reset latter
10381 immediately after the call.
10382 (Vtemp_buffer_show_specifiers): New variable.
10383 (auto_window_vscroll_p, next_screen_context_lines)
10384 (Vscroll_preserve_screen_position): Remove leading asterisks from
10385 doc-strings.
10386
2d3c217e 103872011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10388
7b7f97e8 10389 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10390 * buffer.c (Qclone_number): Remove for now, as it's unused.
10391 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10392 (record_buffer): Remove unused local.
10393 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10394 (set_frame_buffer_list): Remove; unused.
10395 * frame.h (other_visible_frames): Remove decl.
10396 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10397 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10398 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10399 if HAVE_GPM.
10400 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10401 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10402 Define only if HAVE_GPM.
10403 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10404 (update_hints_inhibit): Remove; never set. All uses removed.
10405 * widgetprv.h (emacsFrameClassRec): Remove decl.
10406 * window.c (delete_deletable_window): Now returns void, since it
10407 wasn't returning anything.
10408 (compare_window_configurations): Remove unused locals.
10409 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10410 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10411 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10412 the same widths as pointers. This follows up on the 2011-05-06 patch.
10413 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10414 * xterm.h: Likewise.
10415 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10416
1384b89e
JB
104172011-06-12 Juanma Barranquero <lekktu@gmail.com>
10418
10419 * makefile.w32-in: Update dependencies.
10420 (LISP_H): Add lib/intprops.h.
10421
1100a63c
CY
104222011-06-11 Chong Yidong <cyd@stupidchicken.com>
10423
10424 * image.c (gif_load): Add animation frame delay to the metadata.
10425 (syms_of_image): Use DEFSYM. New symbol `delay'.
10426
6198ccd0
MR
104272011-06-11 Martin Rudalics <rudalics@gmx.at>
10428
10429 * window.c (delete_deletable_window): Re-add.
10430 (Fset_window_configuration): Rewrite to handle dead buffers and
10431 consequently deletable windows.
10432 (window_tree, Fwindow_tree): Remove. Supply functionality in
10433 window.el.
10434 (compare_window_configurations): Simplify code.
10435
b6e3633c
AS
104362011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10437
1ab0dee5
AS
10438 * image.c (imagemagick_load_image): Fix type mismatch.
10439 (Fimagemagick_types): Likewise.
10440
b6e3633c
AS
10441 * window.h (replace_buffer_in_windows): Declare.
10442
9397e56f
MR
104432011-06-11 Martin Rudalics <rudalics@gmx.at>
10444
10445 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10446 Qclone_number. Remove external declaration of Qdelete_window.
10447 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10448 code.
640c8776
SM
10449 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10450 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10451 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10452 buffer list implementation.
10453 (other_buffer_safely): New function.
10454 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10455 calls to replace_buffer_in_windows and
10456 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10457 if allowed.
10458 (record_buffer): Inhibit quitting and rewrite using quittable
10459 functions. Run Qbuffer_list_update_hook if allowed.
10460 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10461 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10462 Move switch-to-buffer to window.el.
9397e56f
MR
10463 (bury-buffer): Move to window.el.
10464 (Vbuffer_list_update_hook): New variable.
10465
10466 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10467 section.
10468
10469 * window.h (resize_frame_windows): Move up in code.
10470 (Fwindow_frame): Remove EXFUN.
10471 (replace_buffer_in_all_windows): Remove prototype.
10472 (replace_buffer_in_windows_safely): Add prototype.
10473
10474 * window.c: Declare Qdelete_window static again. Move down
10475 declaration of select_count.
10476 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10477 (Fother_window): Move to window.el.
10478 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10479 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10480 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10481 window.el.
10482 (replace_buffer_in_windows): Implement by calling
10483 Qreplace_buffer_in_windows.
10484 (replace_buffer_in_all_windows): Remove with some functionality
10485 moved into replace_buffer_in_windows_safely.
10486 (replace_buffer_in_windows_safely): New function.
10487 (select_window_norecord, select_frame_norecord): Move in front
10488 of run_window_configuration_change_hook. Remove now obsolete
10489 declarations.
640c8776
SM
10490 (Fset_window_buffer): Rewrite doc-string.
10491 Call Qrecord_window_buffer.
9397e56f
MR
10492 (keys_of_window): Move binding for other-window to window.el.
10493
b50691aa
CY
104942011-06-11 Chong Yidong <cyd@stupidchicken.com>
10495
10496 * dispextern.h (struct image): Replace data member, whose int_val
10497 and ptr_val fields were not used by anything, with a single
10498 lisp_val object.
10499
10500 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10501 (gif_clear_image, gif_load, imagemagick_load_image)
10502 (gs_clear_image, gs_load): Callers changed.
10503
3f754b86
PE
105042011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10505
cca69397
PE
10506 * buffer.h: Include <time.h>, for time_t.
10507 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10508
109e28d0
PE
10509 Fix minor problems found by static checking.
10510
60737f02
PE
10511 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10512
4b66faf3
PE
10513 Make identifiers static if they are not used in other modules.
10514 * data.c (Qcompiled_function, Qframe, Qvector):
10515 * image.c (QimageMagick, Qsvg):
10516 * minibuf.c (Qmetadata):
10517 * window.c (resize_window_check, resize_root_window): Now static.
10518 * window.h (resize_window_check, resize_root_window): Remove decls.
10519
109e28d0
PE
10520 * window.c (window_deletion_count, delete_deletable_window):
10521 Remove; unused.
46a4ce9e
PE
10522 (window_body_lines): Now static.
10523 (Fdelete_other_windows_internal): Mark vars as initialized.
10524 Make sure 'resize_failed' is initialized.
10525 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10526 (resize_window_apply): Remove unused local.
10527 * window.h (delete_deletable_window): Remove decl.
10528
109e28d0 10529 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10530 (imagemagick_load_image): Fix pointer signedness problem by changing
10531 last arg from unsigned char * to char *. All uses changed.
10532 Also, fix a local for similar reasons.
10533 Remove unused locals. Remove locals to avoid shadowing.
10534 (fn_rsvg_handle_free): Remove; unused.
10535 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10536 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10537
3f754b86
PE
10538 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10539
2547adb1
CY
105402011-06-10 Chong Yidong <cyd@stupidchicken.com>
10541
10542 * image.c (gif_load): Fix omitted cast error introduced by
10543 2011-06-06 change.
10544
2c8e37d4
MR
105452011-06-10 Martin Rudalics <rudalics@gmx.at>
10546
10547 * window.h (resize_proportionally, orig_total_lines)
10548 (orig_top_line): Remove from window structure.
10549 (set_window_height, set_window_width, change_window_heights)
10550 (Fdelete_window): Remove prototypes.
10551 (resize_frame_windows): Remove duplicate declaration.
10552
440a42e3
EZ
105532011-06-10 Eli Zaretskii <eliz@gnu.org>
10554
10555 * window.h (resize_frame_windows, resize_window_check)
10556 (delete_deletable_window, resize_root_window)
10557 (resize_frame_windows): Declare prototypes.
10558
10559 * window.c (resize_window_apply): Make definition be "static" to
10560 match the prototype.
10561
562dd5e9
MR
105622011-06-10 Martin Rudalics <rudalics@gmx.at>
10563
10564 * window.c: Remove declarations of Qwindow_size_fixed,
10565 window_min_size_1, window_min_size_2, window_min_size,
10566 size_window, window_fixed_size_p, enlarge_window, delete_window.
10567 Remove static from declaration of Qdelete_window, it's
10568 temporarily needed by Fbury_buffer.
10569 (replace_window): Don't assign orig_top_line and
10570 orig_total_lines.
10571 (Fdelete_window, delete_window): Remove. Window deletion is
10572 handled by window.el.
640c8776
SM
10573 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10574 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10575 (Fdelete_other_windows): Remove. Deleting other windows is
10576 handled by window.el.
10577 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10578 handled in window.el.
10579 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10580 Window minimum sizes are handled in window.el.
10581 (shrink_windows, size_window, set_window_height)
10582 (set_window_width, change_window_heights, window_height)
10583 (window_width, CURBEG, CURSIZE, enlarge_window)
10584 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10585 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10586 handled in window.el.
10587 (make_dummy_parent): Rename to make_parent_window and give it a
10588 second argument horflag.
10589 (make_window): Don't set resize_proportionally any more.
10590 (Fsplit_window): Remove. Windows are split in window.el.
10591 (save_restore_action, save_restore_orig_size)
10592 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10593 Resize mini windows in window.el.
10594 (grow_mini_window, shrink_mini_window): Implement by calling
10595 Qresize_root_window_vertically, resize_window_check and
10596 resize_window_apply.
640c8776
SM
10597 (saved_window, Fset_window_configuration, save_window_save):
10598 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10599 resize_proportionally.
10600 (window_min_height, window_min_width): Move to window.el.
10601 (keys_of_window): Move bindings for delete-other-windows,
10602 split-window, delete-window and enlarge-window to window.el.
10603
10604 * buffer.c: Temporarily extern Qdelete_window.
10605 (Fbury_buffer): Temporarily call Qdelete_window instead of
10606 Fdelete_window (Fbury_buffer will move to window.el soon).
10607
10608 * frame.c (set_menu_bar_lines_1): Remove code handling
10609 orig_top_line and orig_total_lines.
10610
10611 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10612 set_window_height but set heights directly.
10613 (change_frame_size_1): Use resize_frame_windows.
10614
10615 * xdisp.c (init_xdisp): Don't use set_window_height but set
10616 heights directly.
10617
640c8776
SM
10618 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10619 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10620 run_window_configuration_change_hook.
10621
10622 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10623 instead of change_window_heights and run
10624 run_window_configuration_change_hook.
10625
1a13852e
MR
106262011-06-09 Martin Rudalics <rudalics@gmx.at>
10627
10628 * window.c (replace_window): Rename second argument REPLACEMENT to
10629 NEW. New third argument SETFLAG. Rewrite.
10630 (delete_window, make_dummy_parent): Call replace_window with
10631 third argument 1.
10632 (window_list_1): Move down in code.
10633 (run_window_configuration_change_hook): Move set_buffer part
10634 before select_frame_norecord part in order to unwind correctly.
10635 Rename count1 to count.
10636 (recombine_windows, delete_deletable_window, resize_root_window)
10637 (Fdelete_other_windows_internal)
10638 (Frun_window_configuration_change_hook, make_parent_window)
10639 (resize_window_check, resize_window_apply, Fresize_window_apply)
10640 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10641 (Fdelete_window_internal, Fresize_mini_window_internal):
10642 New functions.
1a13852e
MR
10643 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10644
f3d1777e
MR
106452011-06-08 Martin Rudalics <rudalics@gmx.at>
10646
496e208e
MR
10647 * window.h (window): Add some new members to window structure -
10648 normal_lines, normal_cols, new_total, new_normal, clone_number,
10649 splits, nest, prev_buffers, next_buffers.
10650 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10651 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10652
f3d1777e
MR
10653 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10654 Remove.
496e208e
MR
10655 (make_dummy_parent): Set new members of windows structure.
10656 (make_window): Move down in code. Handle new members of window
10657 structure.
10658 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10659 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10660 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10661 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10662 (Fset_window_next_buffers, Fset_window_clone_number):
10663 New functions.
496e208e
MR
10664 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10665 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10666 Doc-string fixes.
10667 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10668 Argument WINDOW can be now internal window too.
10669 (Fwindow_use_time): Move up in code.
10670 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10671 Rewrite doc-string.
10672 (Fset_window_configuration, saved_window)
10673 (Fcurrent_window_configuration, save_window_save): Handle new
10674 members of window structure.
b9e809c2
MR
10675 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10676 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10677 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10678 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10679 Qget_mru_window, Qresize_root_window,
10680 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10681 Qauto_buffer_name; staticpro them.
f3d1777e 10682
abde8f8c
MR
106832011-06-07 Martin Rudalics <rudalics@gmx.at>
10684
10685 * window.c (Fwindow_total_size, Fwindow_left_column)
10686 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10687 (Fwindow_list_1): New functions.
10688 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10689 (Fwindow_width, Fscroll_left, Fscroll_right):
10690 Use window_body_cols instead of window_box_text_cols.
10691 (delete_window, Fset_window_configuration):
10692 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10693 (delete_all_subwindows): Take a window as argument and not a
10694 structure. Rewrite.
190b47e6
MR
10695 (window_loop): Remove handling of GET_LRU_WINDOW and
10696 GET_LARGEST_WINDOW.
10697 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10698
10699 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10700 window_box_text_cols. delete_all_subwindows now takes a
10701 Lisp_Object as argument.
abde8f8c 10702
640c8776
SM
10703 * indent.c (compute_motion, Fcompute_motion):
10704 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10705
fa8a67e6
MR
10706 * frame.c (delete_frame): Call delete_all_subwindows with root
10707 window as argument.
10708
a54e3482
DC
107092011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10710
10711 * fns.c (Fputhash): Document return value.
10712
60002bf5
CY
107132011-06-06 Chong Yidong <cyd@stupidchicken.com>
10714
10715 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10716
0c671da6 107172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10718
b862a52a 10719 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10720
be44ca6c
PE
10721 Check for overflow when converting integer to cons and back.
10722 * charset.c (Fdefine_charset_internal, Fdecode_char):
10723 Use cons_to_unsigned to catch overflow.
10724 (Fencode_char): Use INTEGER_TO_CONS.
10725 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10726 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10727 * data.c (long_to_cons, cons_to_long): Remove.
10728 (cons_to_unsigned, cons_to_signed): New functions.
10729 These signal an error for invalid or out-of-range values.
10730 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10731 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10732 * font.c (Ffont_variation_glyphs):
10733 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10734 * lisp.h: Include <intprops.h>.
10735 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10736 (cons_to_signed, cons_to_unsigned): New decls.
10737 (long_to_cons, cons_to_long): Remove decls.
10738 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10739 (Fprimitive_undo): Use CONS_TO_INTEGER.
10740 * xfns.c (Fx_window_property): Likewise.
10741 * xselect.c: Include <limits.h>.
10742 (x_own_selection, selection_data_to_lisp_data):
10743 Use INTEGER_TO_CONS.
10744 (x_handle_selection_request, x_handle_selection_clear)
10745 (x_get_foreign_selection, Fx_disown_selection_internal)
10746 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10747 (lisp_data_to_selection_data): Use cons_to_unsigned.
10748 (x_fill_property_data): Use cons_to_signed.
10749 Report values out of range.
10750
d1f3d2af
PE
10751 Check for buffer and string overflow more precisely.
10752 * buffer.h (BUF_BYTES_MAX): New macro.
10753 * lisp.h (STRING_BYTES_MAX): New macro.
10754 * alloc.c (Fmake_string):
10755 * character.c (string_escape_byte8):
10756 * coding.c (coding_alloc_by_realloc):
10757 * doprnt.c (doprnt):
10758 * editfns.c (Fformat):
10759 * eval.c (verror):
10760 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10761 since they may not be the same number.
10762 * editfns.c (Finsert_char):
10763 * fileio.c (Finsert_file_contents):
10764 Likewise for BUF_BYTES_MAX.
10765
dd52fcea
PE
10766 * image.c: Use ptrdiff_t, not int, for sizes.
10767 (slurp_file): Switch from int to ptrdiff_t.
10768 All uses changed.
10769 (slurp_file): Check that file size fits in both size_t (for
10770 malloc) and ptrdiff_t (for sanity and safety).
10771
7f9bbdbb
PE
10772 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10773 if b->modtime has its maximal value.
10774
dfe18f82
PE
10775 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10776
84acfcf0
PE
10777 Don't assume time_t can fit into int.
10778 * buffer.h (struct buffer.modtime): Now time_t, not int.
10779 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10780 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10781
ccd9a01a
PE
10782 Minor fixes for signed vs unsigned integers.
10783 * character.h (MAYBE_UNIFY_CHAR):
10784 * charset.c (maybe_unify_char):
10785 * keyboard.c (read_char, reorder_modifiers):
10786 XINT -> XFASTINT, since the integer must be nonnegative.
10787 * ftfont.c (ftfont_spec_pattern):
10788 * keymap.c (access_keymap, silly_event_symbol_error):
10789 XUINT -> XFASTINT, since the integer must be nonnegative.
10790 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10791 since it makes no difference and we prefer signed.
10792 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10793 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10794 nonnegative.
10795
d6d100dd
SM
107962011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10797
10798 * window.h (Fwindow_frame): Declare.
10799
2b6148e4
PE
108002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10801
10802 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10803 (SPARE_MEMORY): Always define.
10804 (LARGE_REQUEST): Remove.
10805 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10806
f230ecc9
MR
108072011-06-06 Martin Rudalics <rudalics@gmx.at>
10808
727e958e
MR
10809 * lisp.h: Move EXFUNS for Fframe_root_window,
10810 Fframe_first_window and Fset_frame_selected_window to window.h.
10811
10812 * window.h: Move EXFUNS for Fframe_root_window,
10813 Fframe_first_window and Fset_frame_selected_window here from
10814 lisp.h.
10815
10816 * frame.c (Fwindow_frame, Fframe_first_window)
10817 (Fframe_root_window, Fframe_selected_window)
10818 (Fset_frame_selected_window): Move to window.c.
10819 (Factive_minibuffer_window): Move to minibuf.c.
10820 (Fother_visible_frames_p): New function.
10821
10822 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10823
f230ecc9
MR
10824 * window.c (decode_window, decode_any_window): Move up in code.
10825 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10826 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10827 (Fwindow_buffer): Move up and rewrite doc-string.
10828 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10829 (Fwindow_prev): New functions.
727e958e
MR
10830 (Fwindow_frame): Move here from frame.c. Accept any window as
10831 argument.
10832 (Fframe_root_window, Fframe_first_window)
10833 (Fframe_selected_window): Move here from frame.c. Accept frame
10834 or arbitrary window as argument. Update doc-strings.
10835 (Fminibuffer_window): Move up in code.
10836 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10837 (Fset_frame_selected_window): Move here from frame.c.
10838 Marginal rewrite.
727e958e
MR
10839 (Fselected_window, select_window, Fselect_window): Move up in
10840 code. Minor doc-string fixes.
f230ecc9 10841
4d09bcf6
PE
108422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10843
10844 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10845 Do not assume that spare memory exists; that assumption is valid
10846 only if SYSTEM_MALLOC.
10847 (LARGE_REQUEST): New macro, so that the issue of large requests
10848 is separated from the issue of spare memory.
10849
810928a2
AS
108502011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10851
172418ad
AS
10852 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10853 format. (Bug#8806)
10854
43f862f7
AS
10855 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10856
810928a2
AS
10857 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10858 before statements.
10859
a059fe24
JD
108602011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10861
10862 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10863
10864 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10865
10866 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10867 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10868
989bf368
JB
108692011-06-05 Juanma Barranquero <lekktu@gmail.com>
10870
10871 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10872
4b80f674
CY
108732011-06-04 Chong Yidong <cyd@stupidchicken.com>
10874
10875 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10876 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10877 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10878 New error handlers.
4b80f674
CY
10879 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10880 Obey Vx_select_enable_clipboard_manager. Catch errors in
10881 x_clipboard_manager_save (Bug#8779).
10882 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10883 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10884
99a33b77 108852011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10886
10887 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10888
99a33b77 108892011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10890
10891 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10892 in the current matrix if keep_current_p is non-zero.
10893
8264569d
EZ
108942011-06-04 Eli Zaretskii <eliz@gnu.org>
10895
10896 * bidi.c (bidi_level_of_next_char): Fix last change.
10897
57f97249
EZ
108982011-06-03 Eli Zaretskii <eliz@gnu.org>
10899
fec2107c 10900 Support bidi reordering of text covered by display properties.
57f97249 10901
fec2107c
EZ
10902 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10903 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10904 (bidi_cache_search, bidi_cache_iterator_state)
10905 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10906 (bidi_level_of_next_char, bidi_move_to_visually_next):
10907 Support character positions inside a run of characters covered by a
fec2107c
EZ
10908 display string.
10909 (bidi_paragraph_init, bidi_resolve_explicit_1)
10910 (bidi_level_of_next_char): Call bidi_fetch_char and
10911 bidi_fetch_char_advance instead of FETCH_CHAR and
10912 FETCH_CHAR_ADVANCE.
10913 (bidi_init_it): Initialize new members.
10914 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10915 definitions.
10916 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10917 instead of using explicit *_CHAR codes.
d6d100dd
SM
10918 (bidi_resolve_explicit, bidi_resolve_weak):
10919 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10920 bidirectional text is supported only in multibyte buffers.
10921 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10922 it to initialize the frame_window_p member of struct bidi_it.
10923 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10924 (bidi_resolve_explicit, bidi_resolve_weak)
10925 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10926 bidi_it->nchars is non-positive.
10927 (bidi_level_of_next_char): Don't try to lookup the cache for the
10928 next/previous character if nothing is cached there yet, or if we
10929 were just reseat()'ed to a new position.
c40e2fb2 10930
0e14fe90
EZ
10931 * xdisp.c (set_cursor_from_row): Set start and stop points
10932 according to the row's direction when priming the loop that looks
10933 for the glyph on which to display cursor.
10934 (single_display_spec_intangible_p): Function deleted.
10935 (display_prop_intangible_p): Reimplement to call
10936 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10937 Accept 3 additional arguments needed by handle_display_spec.
10938 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10939 values: lists, `(when COND...)' forms, etc.
10940 (single_display_spec_string_p): Support property values that are
10941 lists with the argument STRING its top-level element.
10942 (display_prop_string_p): Fix the condition for processing a
10943 property that is a list to be consistent with handle_display_spec.
fec2107c 10944 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10945 last portion of handle_display_prop.
10946 (compute_display_string_pos): Accept additional argument
10947 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10948 value of a `display' property is a "replacing spec".
10949 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10950 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10951 the display property, but just return a value indicating whether
10952 the display property will replace the characters it covers.
10953 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10954 frame_window_p members of struct bidi_it.
d6d100dd
SM
10955 (compute_display_string_pos, compute_display_string_end):
10956 New functions.
fec2107c
EZ
10957 (push_it): Accept second argument POSITION, where pop_it should
10958 jump to continue iteration.
10959 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10960
fec2107c
EZ
10961 * keyboard.c (adjust_point_for_property): Adjust the call to
10962 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10963
10964 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10965 (bidi_init_it): Update prototypes.
10966 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10967 (compute_display_string_pos, compute_display_string_end):
10968 Declare prototypes.
fec2107c
EZ
10969 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10970 EMACS_INT.
fc6f18ce 10971
40087514 109722011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10973
57f53182
PE
10974 Malloc failure behavior now depends on size of allocation.
10975 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10976 * lisp.h: Change signatures accordingly.
10977 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10978 All callers changed. (Bug#8762)
10979
10980 * gnutls.c: Use Emacs's memory allocators.
10981 Without this change, the gnutls library would invoke malloc etc.
10982 directly, which causes problems on non-SYNC_INPUT hosts, and which
10983 runs afoul of improving memory_full behavior. (Bug#8761)
10984 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10985 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10986 xfree instead of the default malloc, realloc, free.
10987 (Fgnutls_boot): No need to check for memory allocation failure,
10988 since xmalloc does that for us.
10989
ac32cd99 10990 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10991 * category.c (hash_get_category_set):
10992 * ccl.c (ccl_driver):
10993 * charset.c (Fdefine_charset_internal):
10994 * charset.h (struct charset.hash_index):
10995 * composite.c (get_composition_id, gstring_lookup_cache)
10996 (composition_gstring_put_cache):
10997 * composite.h (struct composition.hash_index):
10998 * dispextern.h (struct image.hash):
10999 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11000 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11001 (hashfn_equal, hashfn_user_defined, make_hash_table)
11002 (maybe_resize_hash_table, hash_lookup, hash_put)
11003 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11004 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11005 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11006 * image.c (make_image, search_image_cache, lookup_image)
11007 (xpm_put_color_table_h):
11008 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11009 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11010 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11011 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11012 * alloc.c (allocate_vectorlike):
11013 Check for overflow in vector size calculations.
11014 * ccl.c (ccl_driver):
11015 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11016 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11017 need to be updated by these changes.
40087514
PE
11018 * fns.c (make_hash_table, maybe_resize_hash_table):
11019 Check for integer overflow with large hash tables.
0de4bb68
PE
11020 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11021 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11022 (SXHASH_REDUCE): New macro.
11023 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11024 Use it instead of discarding useful hash info with large hash values.
11025 (sxhash_float): New function.
11026 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11027 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11028 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11029 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11030 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11031 Adjust signatures to match updated version of code.
11032 (consing_since_gc): Now EMACS_INT, since a single hash table can
11033 use more than INT_MAX bytes.
11034
698d32e2
DN
110352011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11036
11037 Make it possible to build with GCC-4.6+ -O2 -flto.
11038
11039 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11040
fd6fa53f
SM
110412011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11042
11043 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11044 Call minibuffer-inactive-mode.
11045
864db017
JB
110462011-05-31 Juanma Barranquero <lekktu@gmail.com>
11047
11048 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11049 Update dependencies.
11050
2ad0baf4
DN
110512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11052
11053 * data.c (init_data): Remove code for UTS, this system is not
11054 supported anymore.
11055
4fcc2638
DN
110562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11057
11058 Don't force ./temacs to start in terminal mode.
11059
11060 * frame.c (make_initial_frame): Initialize faces in all cases, not
11061 only when CANNOT_DUMP is defined.
11062 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11063
c56e0fd5
DN
110642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11065
11066 * dispnew.c (add_window_display_history): Use const for the string
11067 pointer. Remove declaration, not needed.
11068
333d54da 110692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11070
55d4c1b2 11071 Use 'inline', not 'INLINE'.
333d54da 11072 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11073 * alloc.c, fontset.c (INLINE): Remove.
11074 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11075 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11076 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11077 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11078 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11079
738db178
DN
110802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11081
11082 Make it possible to run ./temacs.
11083
11084 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11085 syms_of_callproc does the same thing. Remove test for
11086 "initialized", do it in the caller.
11087 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11088
620c53a6
SM
110892011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11090
11091 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11092 (read_minibuf): Use get_minibuffer.
11093 (syms_of_minibuf): Use DEFSYM.
11094 (Qmetadata): New var.
11095 * data.c (Qbuffer): Don't make it static.
11096 (syms_of_data): Use DEFSYM.
11097
e003a292
PE
110982011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11099
11100 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11101 (CCL_CODE_MIN): New macro.
11102
ed008a6d
PE
111032011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11104
3687c2ef
PE
11105 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11106
ed008a6d
PE
11107 * eval.c (Qdebug): Now static.
11108 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11109 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11110 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11111
d66c4c7c
CY
111122011-05-29 Chong Yidong <cyd@stupidchicken.com>
11113
11114 * image.c: Various fixes to ImageMagick code comments.
11115 (Fimagemagick_types): Doc fix.
11116
5fbc2025
PE
111172011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11118
0196f88a
PE
11119 Minor fixes prompted by GCC 4.6.0 warnings.
11120
11121 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11122
5fbc2025
PE
11123 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11124 (x_clipboard_manager_save_all): Move extern decl to ...
11125 * xterm.h: ... here, so that it can be checked for consistency.
11126
1dd3c2d9
CY
111272011-05-29 Chong Yidong <cyd@stupidchicken.com>
11128
11129 * xselect.c (x_clipboard_manager_save_frame)
11130 (x_clipboard_manager_save_all): New functions.
11131 (Fx_clipboard_manager_save): Lisp function deleted.
11132
11133 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11134 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11135
11136 * xterm.h: Update prototype.
11137
5ba6571d
WX
111382011-05-28 William Xu <william.xwl@gmail.com>
11139
11140 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11141 exiting (Bug#8239).
11142
3eaff834
JM
111432011-05-28 Jim Meyering <meyering@redhat.com>
11144
e1900994 11145 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11146 * fns.c (to_uchar): Define.
11147 (crypto_hash_function): Use it to convert some newly-signed
11148 variables to unsigned, to avoid sign-extension bugs. For example,
11149 without this change, (md5 "truc") would evaluate to
11150 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11151 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11152 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11153
0f6990a7
PE
111542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11155
11156 Integer overflow fixes.
c8a9ca5a 11157
08686060
PE
11158 * dbusbind.c: Serial number integer overflow fixes.
11159 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11160 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11161 to hold a serial number that is too large for a fixnum.
11162 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11163 Check for serial numbers out of range. Decode any serial number
59568bf0 11164 that was so large that it became a float. (Bug#8722)
08686060 11165
2d1fc3c7
PE
11166 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11167 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11168 Use XFASTINT rather than XUINT when numbers are nonnegative.
11169 (xd_append_arg, Fdbus_method_return_internal):
11170 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11171 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11172 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11173 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11174 (Bug#8722)
2d1fc3c7 11175
c8a9ca5a
PE
11176 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11177
519e1d69
PE
11178 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11179
6df6ae42 11180 ccl: Add integer overflow checks.
30569699
PE
11181 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11182 (IN_INT_RANGE): New macros.
11183 (ccl_driver): Use them to check for integer overflow when
11184 decoding a CCL program. Many of the new checks are whether XINT (x)
11185 fits in int; it doesn't always, on 64-bit hosts. The new version
11186 doesn't catch all possible integer overflows, but it's an
847044ea 11187 improvement. (Bug#8719)
30569699 11188
c11285dc
PE
11189 * alloc.c (make_event_array): Use XINT, not XUINT.
11190 There's no need for unsigned here.
11191
fdccd48e
PE
11192 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11193 This follows up to the 2011-05-06 change that substituted uintptr_t
11194 for EMACS_INT. This case wasn't caught back then.
11195
37910ab2
PE
11196 Rework Fformat to avoid integer overflow issues.
11197 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11198 now (part of C89). Include <verify.h>.
11199 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11200 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11201 (Fformat): Avoid the prepass trying to compute sizes; it was only
11202 approximate and thus did not catch overflow reliably. Instead, walk
11203 through the format just once, formatting and computing sizes as we go,
11204 checking for integer overflow at every step, and allocating a larger
11205 buffer as needed. Keep track separately whether the format is
11206 multibyte. Keep only the most-recently calculated precision, rather
11207 than them all. Record whether each argument has been converted to
11208 string. Use EMACS_INT, not int, for byte and char and arg counts.
11209 Support field widths and precisions larger than INT_MAX. Avoid
11210 sprintf's undefined behavior with conversion specifications such as %#d
11211 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11212 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11213 formatting out-of-range floating point numbers with int
9173deec 11214 formats. (Bug#8668)
37910ab2 11215
2e6578fb
PE
11216 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11217
0ae6bdee
PE
11218 * data.c: Avoid integer truncation in expressions involving floats.
11219 * data.c: Include <intprops.h>.
11220 (arith_driver): When there's an integer overflow in an expression
11221 involving floating point, convert the integers to floating point
11222 so that the resulting value does not suffer from catastrophic
11223 integer truncation. For example, on a 64-bit host (* 4
11224 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11225 Do not rely on undefined behavior after integer overflow.
11226
de883a70
PE
11227 merge count_size_as_multibyte, parse_str_to_multibyte
11228 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11229 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11230 Check for integer overflow.
11231 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11232 since it's now a duplicate of the other. This is more of
11233 a character than a buffer op, so better that it's in character.c.
11234 * fns.c, print.c: Adjust to above changes.
11235
2ff916cb
PE
112362011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11237
11238 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11239
f1b54466
PE
112402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11241
fb1ac845
PE
11242 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11243 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11244 (x_clipboard_manager_save): Now static.
11245 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11246
f1b54466
PE
11247 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11248 (crypto_hash_function): Now static.
11249 Fix pointer signedness problems. Avoid unnecessary initializations.
11250
a9f737ee
CY
112512011-05-27 Chong Yidong <cyd@stupidchicken.com>
11252
11253 * termhooks.h (Vselection_alist): Make it terminal-local.
11254
11255 * terminal.c (create_terminal): Initialize it.
11256
11257 * xselect.c: Support for clipboard managers.
11258 (Vselection_alist): Move to termhooks.h as terminal-local var.
11259 (LOCAL_SELECTION): New macro.
11260 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11261 (symbol_to_x_atom): Remove gratuitous arg.
11262 (x_handle_selection_request, lisp_data_to_selection_data)
11263 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11264 (x_own_selection, x_get_local_selection, x_convert_selection):
11265 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11266 (some_frame_on_display): Delete unused function.
11267 (Fx_own_selection_internal, Fx_get_selection_internal)
11268 (Fx_disown_selection_internal, Fx_selection_owner_p)
11269 (Fx_selection_exists_p): New optional frame arg.
11270 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11271 (x_handle_selection_clear): Don't treat other terminals with the
11272 same keyboard specially. Use the terminal-local Vselection_alist.
11273 (x_clear_frame_selections): Use Frun_hook_with_args.
11274
11275 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11276
11277 * xterm.h: Add support for those atoms.
11278
e067f0c1
CY
112792011-05-26 Chong Yidong <cyd@stupidchicken.com>
11280
11281 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11282 (converted_selections, conversion_fail_tag): New global variables.
11283 (x_selection_request_lisp_error): Free the above.
11284 (x_get_local_selection): Remove unnecessary code.
11285 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11286 of converted selections stored in converted_selections.
11287 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11288 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11289 (x_convert_selection): New function.
11290 (x_handle_selection_event): Simplify.
11291 (x_get_foreign_selection): Don't ignore incoming requests while
11292 waiting for an answer; this will fail when we implement
11293 SAVE_TARGETS, and seems unnecessary anyway.
11294 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11295 (Vx_sent_selection_functions): Doc fix.
11296
0f4aebc0
LL
112972011-05-26 Leo Liu <sdl.web@gmail.com>
11298
11299 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11300
e61124cd
YM
113012011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11302
11303 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11304
11305 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11306 for fringe update if it has periodic bitmap.
ac389d0c 11307 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11308 and fringe_bitmap_periodic_p.
11309
11310 * fringe.c (get_fringe_bitmap_data): New function.
11311 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11312 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11313 row. Mark glyph row for fringe update if periodicity changed.
11314
11315 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11316 for fringe update unless it has periodic bitmap.
11317
f16d9837
KH
113182011-05-25 Kenichi Handa <handa@m17n.org>
11319
11320 * xdisp.c (get_next_display_element): Set correct it->face_id for
11321 a static composition.
11322
e1b90ef6
LL
113232011-05-24 Leo Liu <sdl.web@gmail.com>
11324
11325 * deps.mk (fns.o):
11326 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11327
11328 * fns.c (crypto_hash_function, Fsha1): New function.
11329 (Fmd5): Use crypto_hash_function.
11330 (syms_of_fns): Add Ssha1.
11331
7400048f
PE
113322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11333
11334 * gnutls.c: Remove unused macros.
11335 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11336 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11337 Remove macros that are defined and never used.
11338 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11339
abb71cf4
CY
113402011-05-22 Chong Yidong <cyd@stupidchicken.com>
11341
11342 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11343 (Fx_get_selection_internal): Minor cleanup.
11344 (Fx_own_selection_internal): Rename arguments for consistency with
11345 select.el.
11346
6307db39
PE
113472011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11348
11349 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11350
f3d4e0a4
CY
113512011-05-22 Chong Yidong <cyd@stupidchicken.com>
11352
11353 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11354
4d8ade89
YM
113552011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11356
11357 * dispnew.c (scrolling_window): Don't exclude the case that the
11358 last enabled row in the desired matrix touches the bottom boundary.
11359
32078c8d
GM
113602011-05-21 Glenn Morris <rgm@gnu.org>
11361
11362 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11363 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11364 and add some more files.
32078c8d 11365
7285dc67
EZ
113662011-05-20 Eli Zaretskii <eliz@gnu.org>
11367
11368 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11369 report_file_error introduced by the change from 2011-05-07.
11370
89d1bd22
PE
113712011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11372
11373 * systime.h (Time): Define only if emacs is defined.
11374 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11375 where the include path doesn't have X11/X.h by default. See
11376 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11377
cd394be1 113782011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11379
11380 * composite.c (find_automatic_composition): Fix previous change.
11381
b9704ad9
GM
113822011-05-20 Glenn Morris <rgm@gnu.org>
11383
11384 * lisp.mk: New file, split from Makefile.in.
11385 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11386 (shortlisp): Remove.
11387 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11388
4a720484
GM
113892011-05-19 Glenn Morris <rgm@gnu.org>
11390
11391 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11392 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11393 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11394 (lisp): Set the order to that of loadup.el.
11395 (shortlisp): Make it a copy of $lisp.
11396 (SOME_MACHINE_LISP): Remove.
11397 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11398 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11399
a28d4396
KH
114002011-05-18 Kenichi Handa <handa@m17n.org>
11401
11402 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11403 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11404 (find_automatic_composition): Mostly rewrite for efficiency.
11405
a2b1fa8e
JB
114062011-05-18 Juanma Barranquero <lekktu@gmail.com>
11407
11408 * makefile.w32-in: Update dependencies.
11409
8e1f5610
CS
114102011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11411
11412 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11413 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11414
7025ee00 114152011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11416
cdfa6eab
PE
11417 Fix some integer overflow issues, such as string length overflow.
11418
06d6db33
PE
11419 * insdel.c (count_size_as_multibyte): Check for string overflow.
11420
2b4560a8
PE
11421 * character.c (lisp_string_width): Check for string overflow.
11422 Use EMACS_INT, not int, for string indexes and lengths; in
11423 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11424 the resulting string length overflows an EMACS_INT; instead,
11425 report a string overflow if no precision given. When checking for
11426 precision exhaustion, use a check that cannot possibly have
11427 integer overflow. (Bug#8675)
11428 * character.h (lisp_string_width): Adjust to new signature.
11429
cb93f9be
PE
11430 * alloc.c (string_overflow): New function.
11431 (Fmake_string): Use it. This doesn't change behavior, but saves
11432 a few bytes and will simplify future changes.
11433 * character.c (string_escape_byte8): Likewise.
11434 * lisp.h (string_overflow): New decl.
11435
1a1f3366
PE
11436 Fixups, following up to the user-interface timestamp change.
11437 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11438 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11439 * msdos.c (mouse_get_pos): Likewise.
11440 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11441 * w32gui.h (Time): Define by including "systime.h" rather than by
11442 declaring it ourselves. (Bug#8664)
11443
d4e3e4d3
PE
11444 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11445 * image.c (clear_image_cache): Likewise.
11446
f6a24d19
PE
11447 * term.c (term_mouse_position): Don't assume time_t wraparound.
11448
08dc5ae6
PE
11449 Be more systematic about user-interface timestamps.
11450 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11451 and sometimes 'EMACS_UINT', to represent these timestamps.
11452 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11453 This makes the code easier to follow, and makes it easier to catch
11454 integer overflow bugs such as Bug#8664.
11455 * frame.c (Fmouse_position, Fmouse_pixel_position):
11456 Use Time, not unsigned long, for user-interface timestamps.
11457 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11458 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11459 * keyboard.h (last_event_timestamp): Likewise.
11460 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11461 * menu.h (xmenu_show): Likewise.
11462 * term.c (term_mouse_position): Likewise.
11463 * termhooks.h (struct input_event.timestamp): Likewise.
11464 (struct terminal.mouse_position_hook): Likewise.
11465 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11466 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11467 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11468 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11469 what it was before.
11470 * menu.h, termhooks.h: Include "systime.h", for Time.
11471
8e55734a
PE
11472 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11473 Don't assume that the difference between two unsigned long values
11474 can fit into an integer. At this point, we know button_down_time
11475 <= event->timestamp, so the difference must be nonnegative, so
11476 there's no need to cast the result if double-click-time is
11477 nonnegative, as it should be; check that it's nonnegative, just in
11478 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11479 apart (about 25 days). (Bug#8664)
8e55734a 11480
841f1b75 11481 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11482 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11483
3e26f69c
PE
11484 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11485 that always fit in int. Use a sentinel instead of a counter, to
11486 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11487 * frame.h (struct frame): Use int for menu_bar_items_used
11488 instead of EMACS_INT, since it always fits in int.
3e26f69c 11489
5cc152c0
PE
11490 * menu.c (grow_menu_items): Check for int overflow.
11491
d89eb65e
PE
11492 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11493
5235bd3e
PE
11494 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11495 Before, the code was not consistent. These values cannot exceed
11496 2**31 - 1 so there's no need to make them unsigned.
11497 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11498 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11499 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11500 as modifiers.
11501 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11502
bc827e23
PE
11503 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11504 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11505 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11506 presumably because the widths might not match.
11507
78eb494e
PE
11508 * window.c (size_window): Avoid needless test at loop start.
11509
04f2d78b
CB
115102011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11511
11512 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11513
d2fc7e3d 115142011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11515
11516 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11517
d2fc7e3d 115182011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11519
11520 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11521 `width' to `bar_area_x' and `bar_area_width', respectively.
11522 (x_scroll_run): Take account of fringe background extension.
11523
04f2d78b
CB
11524 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11525 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11526 `bar_area_width', respectively.
11527 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11528 background extension.
11529
79b70037
GM
115302011-05-10 Jim Meyering <meyering@redhat.com>
11531
11532 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11533
2f142cc5
JB
115342011-05-10 Juanma Barranquero <lekktu@gmail.com>
11535
11536 * image.c (Finit_image_library): Return t for built-in image types,
11537 like pbm and xbm. (Bug#8640)
11538
57679c86
AS
115392011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11540
11541 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11542
888c9e86
EZ
115432011-05-07 Eli Zaretskii <eliz@gnu.org>
11544
b0512a1d
EZ
11545 * w32console.c (Fset_screen_color): Doc fix.
11546 (Fget_screen_color): New function.
11547 (syms_of_ntterm): Defsubr it.
11548
7285dc67
EZ
11549 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11550 unlink the temporary file if Fcall_process didn't create it in the
11551 first place.
11552 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11553 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11554 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11555 cue to call_process_cleanup not to close that handle.
11556
4d3fcc8e
BK
115572011-05-07 Ben Key <bkey76@gmail.com>
11558
11559 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11560 one of two shell specific rules, either bootstrap-temacs-CMD or
11561 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11562 to the previous implementation of the bootstrap-temacs rule.
11563 The bootstrap-temacs-CMD rule is similar to the previous
11564 implementation of the bootstrap-temacs rule except that it
11565 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11566 variable.
11567
11568 These changes, along with some changes to nt/configure.bat,
11569 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11570 earlier fix to add support for --cflags and --ldflags options
11571 that include quotes so that it works whether make uses cmd or
11572 sh as the shell.
11573
b4289b64
MA
115742011-05-06 Michael Albinus <michael.albinus@gmx.de>
11575
11576 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11577 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11578 is a constant.
11579 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11580 a string. Handle both cases.
11581 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11582 (Fdbus_register_method): Use Qinvalid_function.
11583
af4c0e28
JB
115842011-05-06 Juanma Barranquero <lekktu@gmail.com>
11585
11586 * makefile.w32-in: Update dependencies.
11587 (LISP_H): Add inttypes.h and stdin.h.
11588 (PROCESS_H): Add unistd.h.
11589
c51453d9
EZ
115902011-05-06 Eli Zaretskii <eliz@gnu.org>
11591
11592 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11593 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11594
8ff0ac3c 115952011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11596
4c4b566b
PE
11597 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11598
aab2b9b5
PE
11599 * term.c (vfatal): Remove stray call to va_end.
11600 It's not needed and the C Standard doesn't allow it here anyway.
11601
c378da0b
PE
11602 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11603 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11604
288b08c7
PE
11605 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11606 bytes.
11607
e3601888
PE
11608 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11609
db6c0e74
PE
11610 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11611
dd5963ea
PE
11612 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11613
88c9450f
PE
11614 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11615
2f9442b8
PE
11616 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11617
c032b5f8
PE
11618 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11619 * charset.c (Fdefine_charset_internal): Don't initialize
11620 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11621 32-bit int (Bug#8600).
a108c10b
PE
11622
11623 * lread.c (read_integer): Be more consistent with string-to-number.
11624 Use string_to_number to do the actual conversion; this avoids
11625 rounding errors and fixes some other screwups. Without this fix,
11626 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11627 (digit_to_number): Move earlier, for benefit of read_integer.
11628 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11629 not a digit in any supported base. (Bug#8602)
a108c10b 11630
ad5f9eea
PE
11631 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11632
aec1708a
PE
11633 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11634 to match comment at start of function. This also removes a
11635 GCC warning about overflow in a 32+64-bit port.
11636
47be4ab5
PE
11637 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11638
371cac43
PE
11639 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11640 Reported by Stefan Monnier in
11641 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11642 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11643 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11644
d01a7826
PE
11645 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11646 (EMACS_UINTPTR): Likewise, with uintptr_t.
11647
7fd47d5c
PE
11648 * lisp.h: Prefer 64-bit EMACS_INT if available.
11649 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11650 on 32-bit hosts that have 64-bit int, so that they can access
11651 large files.
122b0c86
PE
11652 However, temporarily disable this change unless the temporary
11653 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11654
8727937b
PE
11655 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11656
8ac068ac
PE
11657 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11658 This removes an assumption that EMACS_INT and long are the same
11659 width as pointers. The assumption is true for Emacs porting targets
11660 now, but we want to make other targets possible.
11661 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11662 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11663 In the rest of the code, change types of integers that hold casted
11664 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11665 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11666 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11667 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11668 No need to cast type when ORing.
11669 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11670 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11671 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11672 assume EMACS_INT is the same width as char *.
11673 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11674 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11675 Remove no-longer-needed casts.
11676 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11677 (xg_tool_bar_help_callback, xg_make_tool_item):
11678 Use EMACS_INTPTR to hold an integer
11679 that will be cast to void *; this can avoid a GCC warning
11680 if EMACS_INT is not the same width as void *.
11681 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11682 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11683 (current_message_1, set_message_1):
11684 Use a local to convert to proper width without a cast.
11685 * xmenu.c (dialog_selection_callback): Likewise.
11686
ede49d71
PE
11687 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11688 Also, don't assume VALBITS / RAND_BITS is less than 5,
11689 and don't rely on undefined behavior when shifting a 1 left into
11690 the sign bit.
11691 * lisp.h (get_random): Change signature to match.
11692
2f30ecd0
PE
11693 * lread.c (hash_string): Use size_t, not int, for hash computation.
11694 Normally we prefer signed values; but hashing is special, because
11695 it's better to use unsigned division on hash table sizes so that
11696 the remainder is nonnegative. Also, size_t is the natural width
11697 for hashing into memory. The previous code used 'int', which doesn't
11698 retain enough info to hash well into very large tables.
11699 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11700
2a866e7b
PE
11701 * dbusbind.c: Don't possibly lose pointer info when converting.
11702 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11703 Use XPNTR rather than XHASH, so that the high-order bits of
11704 the pointer aren't lost when converting through void *.
11705
51639eac
PE
11706 * eval.c (Fautoload): Don't double-shift a pointer.
11707
92394119
PE
11708 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11709
dbdb9a7c
JB
117102011-05-06 Juanma Barranquero <lekktu@gmail.com>
11711
11712 * gnutls.c (DEF_GNUTLS_FN):
11713 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11714
db7a0b4f
AS
117152011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11716
11717 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11718 marker. (Bug#8610)
11719
cd394be1 117202011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11721
11722 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11723 New version that can reserve upto 2GB of heap space.
11724
f7ff1b0f 117252011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11726
11727 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11728
639c109b
TZ
117292011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11730
11731 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11732 `gnutls_certificate_set_x509_key_file'.
11733
d2127135
JB
117342011-05-05 Juanma Barranquero <lekktu@gmail.com>
11735
11736 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11737 Update dependencies.
11738
e968f4f3
JB
117392011-05-04 Juanma Barranquero <lekktu@gmail.com>
11740
11741 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11742 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11743 Remove unused parameter `fildes'.
11744 * process.c (read_process_output, send_process): Don't pass it.
11745
84d358f0
JB
117462011-05-04 Juanma Barranquero <lekktu@gmail.com>
11747
11748 Fix previous change: the library cache is defined in w32.c.
11749 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11750 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11751
0898ca10
JB
117522011-05-04 Juanma Barranquero <lekktu@gmail.com>
11753
11754 Implement dynamic loading of GnuTLS on Windows.
11755
11756 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11757 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11758 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11759 Declare.
11760
11761 * gnutls.c (Qgnutls_dll): Define.
11762 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11763 (gnutls_*): Declare function pointers.
11764 (init_gnutls_functions): New function to initialize function pointers.
11765 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11766 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11767 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11768 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11769 (emacs_gnutls_write, emacs_gnutls_read)
11770 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11771 (Fgnutls_available_p): New function.
11772 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11773 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11774 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11775
11776 * image.c: Include w32.h.
11777 (Vimage_type_cache): Delete.
11778 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11779 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11780 (w32_delayed_load): Move to w32.c.
11781
11782 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11783
11784 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11785 (w32_delayed_load): Move from image.c. When loading a library, record
11786 its filename in the :loaded-from property of the library id.
11787 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11788 Initialize and staticpro them.
11789 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11790
11791 * process.c: Include lisp.h before w32.h, not after.
11792 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11793 instead of gnutls_record_check_pending.
11794
11795 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11796
ff4de4aa
TZ
117972011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11798
11799 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11800 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11801 as passed in.
11802
abe95abb
JD
118032011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11804
11805 * xterm.c (x_set_frame_alpha): Do not set property on anything
11806 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11807
e16e55d4
JB
118082011-05-02 Juanma Barranquero <lekktu@gmail.com>
11809
11810 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11811
bafcf6a5
JB
118122011-05-02 Juanma Barranquero <lekktu@gmail.com>
11813
11814 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11815 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11816 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11817 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11818 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11819 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11820 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11821 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11822 (Qgnutls_bootprop_callbacks_verify): Make static.
11823
e7a6747f
AS
118242011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11825
19ed11ba
AS
11826 * callproc.c: Indentation fixup.
11827
e7a6747f 11828 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11829 (wait_for_termination, interruptible_wait_for_termination):
11830 Move after wait_for_termination_1.
e7a6747f 11831
1ef14cb4
LMI
118322011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11833
11834 * sysdep.c (interruptible_wait_for_termination): New function
11835 which is like wait_for_termination, but allows keyboard
11836 interruptions.
11837
11838 * callproc.c (Fcall_process): Add (:file "file") as an option for
11839 the STDOUT buffer.
11840 (Fcall_process_region): Ditto.
11841
330d880c
EZ
118422011-04-30 Eli Zaretskii <eliz@gnu.org>
11843
8db90b73
EZ
11844 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11845 rather than `XVECTOR (FOO)->size'.
11846
330d880c
EZ
11847 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11848 inttypes.h, as a gnulib replacement is used if it not available in
11849 system headers.
11850
15cbd324
EZ
118512011-04-21 Eli Zaretskii <eliz@gnu.org>
11852
11853 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11854 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11855 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11856
11857 * coding.c (coding_alloc_by_realloc): Error out if destination
11858 will grow beyond MOST_POSITIVE_FIXNUM.
11859 (decode_coding_emacs_mule): Abort if there isn't enough place in
11860 charbuf for the composition carryover bytes. Reserve an extra
11861 space for up to 2 characters produced in a loop.
11862 (decode_coding_iso_2022): Abort if there isn't enough place in
11863 charbuf for the composition carryover bytes.
11864
118652011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11866
ae940cca
EZ
11867 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11868 aborting when %lld or %lll format is passed.
11869 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11870 %llo or %llx format is passed. (Bug#8545)
11871
03ab8921
EZ
11872 * window.c (window_scroll_line_based): Use a marker instead of
11873 simple variables to record original value of point. (Bug#7952)
11874
afda1437
EZ
11875 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11876 produced by %s or %c overflows available buffer space. (Bug#8545)
11877
f76dee0c
PE
118782011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11879
11880 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11881 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11882
fdc5744d
JB
118832011-04-28 Juanma Barranquero <lekktu@gmail.com>
11884
11885 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11886
638f053a
JB
118872011-04-28 Juanma Barranquero <lekktu@gmail.com>
11888
11889 * keyboard.c (Qdelayed_warnings_hook): Define.
11890 (command_loop_1): Run `delayed-warnings-hook'
11891 if Vdelayed_warnings_list is non-nil.
11892 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11893 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11894
d178f871
EZ
118952011-04-28 Eli Zaretskii <eliz@gnu.org>
11896
11897 * doprnt.c (doprnt): Don't return value smaller than the buffer
11898 size if the message was truncated. (Bug#8545).
11899
b124fd93
JB
119002011-04-28 Juanma Barranquero <lekktu@gmail.com>
11901
11902 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11903 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11904
e810457d
PE
119052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11906
11907 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11908
ea51cceb
JB
119092011-04-27 Juanma Barranquero <lekktu@gmail.com>
11910
11911 * makefile.w32-in: Update dependencies.
11912
94dcfacf
EZ
119132011-04-27 Eli Zaretskii <eliz@gnu.org>
11914
11915 Improve `doprnt' and its usage. (Bug#8545)
11916 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11917 `format_end'. Remove support for %l as a conversion specifier.
11918 Don't use xrealloc. Improve diagnostics when the %l size modifier
11919 is used. Update the commentary.
11920
11921 * eval.c (verror): Simplify calculation of size_t.
11922
11923 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11924 messages.
11925
f61f41d7
PE
119262011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11927
11928 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11929 change.
11930
96fb4434
PE
119312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11932
11933 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11934 This makes this file independent of the recent pseudovector change.
11935
671875da 119362011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11937
69e9b5a3
PE
11938 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11939
b5f869a7 11940 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11941 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11942 Remove unused local.
c8926152 11943 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11944
841a1577 11945 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11946 GCC 4.6.0 optimizes based on type-based alias analysis.
11947 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11948 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11949 != &v->size, and therefore "v->size = 1; b->size = 2; return
11950 v->size;" must therefore return 1. This assumption is incorrect
11951 for Emacs, since it type-puns struct Lisp_Vector * with many other
11952 types. To fix this problem, this patch adds a new type struct
f904488f 11953 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11954 and pseudovectors, and helps optimizing compilers not get fooled
11955 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11956 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11957 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11958 the size member.
eab3844f
PE
11959 (XSETPVECTYPE): Rewrite in terms of new macro.
11960 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11961 This is a bit clearer, and further avoids the possibility of
11962 undesirable aliasing.
11963 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11964 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11965 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11966 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11967 (ASIZE): Now uses header.size rather than size.
11968 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11969 to avoid the hassle of writing XVECTOR (foo)->header.size.
11970 (struct vectorlike_header): New type.
eab3844f
PE
11971 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11972 object, to help avoid aliasing.
11973 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11974 (SUBRP): Likewise, since Lisp_Subr is a special case.
11975 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11976 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11977 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11978 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11979 changed to be "header.size" and "header.next".
11980 * buffer.h (struct buffer): Likewise.
11981 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11982 * frame.h (struct frame): Likewise.
11983 * process.h (struct Lisp_Process): Likewise.
11984 * termhooks.h (struct terminal): Likewise.
11985 * window.c (struct save_window_data, struct saved_window): Likewise.
11986 * window.h (struct window): Likewise.
11987 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11988 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11989 * buffer.c (init_buffer_once): Likewise.
11990 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11991 special case.
11992 * process.c (Fformat_network_address): Use local var for size,
11993 for brevity.
11994
0df1eac5
PE
11995 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11996
847ab9d1 11997 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11998 * data.c (atof): Remove decl; no longer used or needed.
11999 (digit_to_number): Move to lread.c.
12000 (Fstring_to_number): Use new string_to_number function, to be
12001 consistent with how the Lisp reader treats infinities and NaNs.
12002 Do not assume that floating-point numbers represent EMACS_INT
12003 without losing information; this is not true on most 64-bit hosts.
12004 Avoid double-rounding errors, by insisting on integers when
12005 parsing non-base-10 numbers, as the documentation specifies.
12006 * lisp.h (string_to_number): New decl, replacing ...
12007 (isfloat_string): Remove.
bc0a5c13 12008 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12009 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12010 appears to have been a coding error. Similarly, do not accept
12011 strings like +-1e0 as floating point numbers. Do not report
12012 overflow for integer overflows unless the base is not 10 which
12013 means we have no simple and reliable way to continue.
12014 Break out the floating-point parsing into a new
12015 function string_to_number, so that Fstring_to_number parses
12016 floating point numbers consistently with the Lisp reader.
04f2d78b 12017 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12018 (E_CHAR, EXP_INT): Remove, replacing with ...
12019 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12020 (string_to_number): New function, replacing isfloat_string.
12021 This function checks for valid syntax and produces the resulting
12022 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12023 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12024 so that overflow for non-base-10 numbers is reported only when
12025 there's no portable and simple way to convert to floating point.
452f4150 12026
67769ffc
PE
12027 * textprop.c (set_text_properties_1): Rewrite for clarity,
12028 and to avoid GCC warning about integer overflow.
12029
c20db43f
PE
12030 * intervals.h (struct interval): Use EMACS_INT for members
12031 where EMACS_UINT might cause problems. See
12032 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12033 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12034 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12035 All uses changed.
37aa2f85
PE
12036 (offset_intervals): Tell GCC not to worry about length overflow
12037 when negating a negative length.
c20db43f 12038
2538aa2f
PE
12039 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12040 (overrun_check_free): Likewise.
12041
f2d3008d
PE
12042 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12043 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12044 word size.
12045
ec8df744
PE
12046 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12047 (gnutls_make_error): Rename local to avoid shadowing.
12048 (gnutls_emacs_global_deinit): ifdef out; not used.
12049 (Fgnutls_boot): Use const for pointer to readonly storage.
12050 Comment out unused local. Fix pointer signedness problems.
12051
640ee02d
PE
12052 * lread.c (openp): Don't stuff size_t into an 'int'.
12053 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12054 about possible signed overflow.
12055
6048fb2a
PE
12056 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12057 (GDK_KEY_g): Don't define if already defined.
12058 (xg_prepare_tooltip): Avoid pointer signedness problem.
12059 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12060
fa3c87e1
PE
12061 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12062 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12063
2172544b
PE
12064 * xfns.c (Fx_window_property): Simplify a bit,
12065 to make a bit faster and to avoid GCC 4.6.0 warning.
12066 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12067
9b821a21
PE
12068 * fns.c (internal_equal): Don't assume size_t fits in int.
12069
3c616cfa
PE
12070 * alloc.c (compact_small_strings): Tighten assertion a little.
12071
c2982e87
PE
12072 Replace pEd with more-general pI, and fix some printf arg casts.
12073 * lisp.h (pI): New macro, generalizing old pEd macro to other
12074 conversion specifiers. For example, use "...%"pI"d..." rather
12075 than "...%"pEd"...".
12076 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12077 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12078 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12079 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12080 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12081 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12082 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12083 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12084 64-bit hosts.
12085 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12086 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12087 * print.c (safe_debug_print, print_object): Likewise.
12088 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12089 to int.
6f04d126
PE
12090 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12091 avoiding the 0 flag, which is not portable.
c2982e87
PE
12092 * process.c (Fmake_network_process): Use pI to avoid cast.
12093 * region-cache.c (pp_cache): Likewise.
12094 * xdisp.c (decode_mode_spec): Likewise.
12095 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12096 behavior on 64-bit hosts with printf arg.
6f04d126 12097 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12098 (x_stop_queuing_selection_requests): Likewise.
12099 (x_get_window_property): Don't truncate byte count to an 'int'
12100 when tracing.
0b432f21 12101
5e073ec7
PE
12102 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12103 here, since it parses constructs like leading '-' and spaces,
12104 which are not wanted; and it overflows with large numbers.
12105 Instead, simply match F[0-9]+, which is what is wanted anyway.
12106
36372bf9
PE
12107 * alloc.c: Remove unportable assumptions about struct layout.
12108 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12109 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12110 (allocate_vectorlike, make_pure_vector): Use the new macros,
12111 plus offsetof, to remove unportable assumptions about struct layout.
12112 These assumptions hold on all porting targets that I know of, but
12113 they are not guaranteed, they're easy to remove, and removing them
12114 makes further changes easier.
12115
0b432f21
PE
12116 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12117 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12118 (string_overrun_cookie): Now const. Use initializers that
12119 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12120 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12121 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12122 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12123 multiple of sizeof (EMACS_INT); it need not be, if
12124 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12125 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12126
895009e1
JB
121272011-04-26 Juanma Barranquero <lekktu@gmail.com>
12128
12129 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12130
6a7a1b0b
TZ
121312011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12132
12133 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12134 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12135 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12136
841a1577 121372011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12138
12139 * lisp.h (Qdebug): List symbol.
895009e1 12140 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12141 * keyboard.c (debug-on-event): New variable.
12142 (handle_user_signal): Break into debugger when debug-on-event
12143 matches the current signal symbol.
12144
f2d3ba6f
DN
121452011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12146
12147 * alloc.c (check_sblock, check_string_bytes)
12148 (check_string_free_list): Convert to standard C.
12149
42ce4c63
TZ
121502011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12151
12152 * w32.c (emacs_gnutls_push): Fix typo.
12153
825cd63c
EZ
121542011-04-25 Eli Zaretskii <eliz@gnu.org>
12155
fb11d64d
EZ
12156 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12157 "cast to pointer from integer of different size".
12158
825cd63c
EZ
12159 Improve doprnt and its use in verror. (Bug#8545)
12160 * doprnt.c (doprnt): Document the set of format control sequences
12161 supported by the function. Use SAFE_ALLOCA instead of always
12162 using `alloca'.
12163
12164 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12165 is one byte too soon. Don't use xrealloc; instead xfree and
12166 xmalloc anew.
12167
e061a11b
TZ
121682011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12169
12170 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12171 callbacks stage.
12172
12173 * gnutls.c: Renamed global_initialized to
12174 gnutls_global_initialized. Added internals for the
12175 :verify-hostname-error, :verify-error, and :verify-flags
12176 parameters of `gnutls-boot' and documented those parameters in the
12177 docstring. Start callback support.
9173deec
JB
12178 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12179 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12180 on error. Return error code.
e061a11b
TZ
12181 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12182 (emacs_gnutls_read): Likewise.
12183 (Fgnutls_boot): Return handshake error code.
12184 (emacs_gnutls_handle_error): New function.
12185 (wsaerror_to_errno): Likewise.
12186
12187 * w32.h (emacs_gnutls_pull): Add prototype.
12188 (emacs_gnutls_push): Likewise.
12189
12190 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12191 (emacs_gnutls_push): Likewise.
12192
121932011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12194
12195 * process.c (wait_reading_process_output): Check if GnuTLS
12196 buffered some data internally if no FDs are set for TLS
12197 connections.
12198
12199 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12200 (LIBS): Link to USER_LIBS.
12201 ($(BLD)/gnutls.$(0)): New target.
12202
fa6996bc
EZ
122032011-04-24 Eli Zaretskii <eliz@gnu.org>
12204
eb35682e
EZ
12205 * xdisp.c (handle_single_display_spec): Rename the
12206 display_replaced_before_p argument into display_replaced_p, to
12207 make it consistent with the commentary. Fix typos in the
12208 commentary.
12209
e2ad650c
EZ
12210 * textprop.c (syms_of_textprop): Remove dead code.
12211 (copy_text_properties): Delete obsolete commentary about an
12212 interface that was deleted long ago. Fix typos in the description
12213 of arguments.
12214
1b2de274
EZ
12215 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12216 to changes in oldXMenu/XMenu.h from 2011-04-16.
12217 <menu_help_message, prev_menu_help_message>: Constify.
12218 (IT_menu_make_room): menu->help_text is now `const char **';
12219 adjust.
12220
12221 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12222 to changes in oldXMenu/XMenu.h from 2011-04-16.
12223 (struct XMenu): Declare `help_text' `const char **'.
12224
12225 * xfaces.c <Qunspecified>: Make extern again.
12226
12227 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12228 required by POSIX.
1b2de274 12229
762b15be
EZ
12230 * doc.c (get_doc_string): Improve the format passed to `error'.
12231
12232 * doprnt.c (doprnt): Improve commentary.
12233
12234 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12235
12236 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12237 them with etags.
12238
f1052e5d
EZ
12239 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12240 changes in globals.h immediately force recompilation.
762b15be
EZ
12241 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12242 $(CURDIR)/s/ms-w32.h.
12243 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12244
fa6996bc
EZ
12245 * character.c (Fchar_direction): Function deleted.
12246 (syms_of_character): Don't defsubr it.
12247 <char-direction-table>: Deleted.
12248
e6c3da20
EZ
122492011-04-23 Eli Zaretskii <eliz@gnu.org>
12250
12251 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12252 * doprnt.c: Include limits.h.
12253 (SIZE_MAX): New macro.
04f2d78b
CB
12254 (doprnt): Return a size_t value. 2nd arg is now size_t.
12255 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12256 Improve overflow protection. Support `l' modifier for integer
12257 conversions. Support %l conversion. Don't assume an EMACS_INT
12258 argument for integer conversions and for %c.
12259
12260 * lisp.h (doprnt): Restore prototype.
12261
12262 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12263 $(SRC)/character.h.
12264
12265 * Makefile.in (base_obj): Add back doprnt.o.
12266
12267 * deps.mk (doprnt.o): Add back prerequisites.
12268 (callint.o): Depend on character.h.
12269
12270 * eval.c (internal_lisp_condition_case): Include the handler
12271 representation in the error message.
12272 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12273 when breaking from the loop.
12274
12275 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12276
12277 * callint.c (Fcall_interactively): When displaying error message
12278 about invalid control letter, pass the character's codepoint, not
12279 a pointer to its multibyte form. Improve display of the character
12280 in octal and display also its hex code.
12281
12282 * character.c (char_string): Use %x to display the (unsigned)
12283 codepoint of an invalid character, to avoid displaying a bogus
12284 negative value.
12285
12286 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12287 `error', not SYMBOL_NAME itself.
12288
12289 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12290 character arguments to `error'.
12291
12292 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12293 to `error' in error message about FINAL_CHAR argument. Make sure
12294 FINAL_CHAR is a character, and use %c when it is passed as
12295 argument to `error'.
12296
4ffd0d6b 122972011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12298
12299 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12300
12301 * w32.c: Include <time.h>.
12302 (sys_localtime): New function.
12303
4ffd0d6b 123042011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12305
12306 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12307
4ffd0d6b 12308 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12309
4ffd0d6b 123102011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12311
4ffd0d6b
GM
12312 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12313 zombies (Bug#8467).
aac0c6e3 12314
04c56954
EZ
123152011-04-19 Eli Zaretskii <eliz@gnu.org>
12316
12317 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12318 gl_state.e_property when gl_state.object is Qt.
12319
12320 * insdel.c (make_gap_larger): Remove limitation of buffer size
12321 to <= INT_MAX.
12322
16a43933
CY
123232011-04-18 Chong Yidong <cyd@stupidchicken.com>
12324
12325 * xdisp.c (lookup_glyphless_char_display)
12326 (produce_glyphless_glyph): Handle cons cell entry in
12327 glyphless-char-display.
12328 (Vglyphless_char_display): Document it.
12329
12330 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12331 glyphless-char-display.
12332
4581706e
CY
123332011-04-17 Chong Yidong <cyd@stupidchicken.com>
12334
12335 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12336
12337 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12338
12339 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12340 definition for no-X builds.
12341
4887c6e2 123422011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12343
fd35b6f9
PE
12344 Static checks with GCC 4.6.0 and non-default toolkits.
12345
5c1ccb01
PE
12346 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12347
006c5daa
PE
12348 * process.c (keyboard_bit_set): Define only if SIGIO.
12349 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12350 (send_process): Repair possible setjmp clobbering.
12351
efc736d3
PE
12352 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12353
4e2fe2e6
PE
12354 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12355
f97334a2
PE
12356 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12357
4e75f29d
PE
12358 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12359 Define only if needed.
12360
90efadd1
PE
12361 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12362 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12363 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12364
3c647824
PE
12365 * dispextern.h (struct redisplay_interface): Rename param
12366 to avoid shadowing.
e264f262 12367 * termhooks.h (struct terminal): Likewise.
761383f4 12368 * xterm.c (xembed_send_message): Likewise.
3c647824 12369
b58c5c4a
PE
12370 * insdel.c (make_gap_smaller): Define only if
12371 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12372
cad59032
PE
12373 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12374 it.
12375
c339dc2e
PE
12376 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12377 so that we aren't warned about unused symbols.
12378
91a3e27b
PE
12379 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12380
399c71d3 12381 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12382
8ffc96f5
PE
12383 * xfns.c (x_real_positions): Mark locals as initialized.
12384
eef9bc79
PE
12385 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12386
098db9dd
PE
12387 * xterm.c: Fix problems found by static analysis with other toolkits.
12388 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12389 (x_dispatch_event): Declare static if USE_GTK, and
12390 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12391 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12392 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12393 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12394 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12395
eb18f6cc
PE
12396 * xmenu.c (menu_help_callback): Pointer type fixes.
12397 Use const pointers when pointing at readonly data. Avoid pointer
12398 signedness clashes.
12399 (FALSE): Remove unused macro.
12400 (update_frame_menubar): Remove unused decl.
12401
1fe72bf8
PE
12402 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12403
60d9e1db
PE
12404 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12405 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12406 (single_menu_item): Rename local to avoid shadowing.
12407
39261c26
PE
12408 * keyboard.c (make_lispy_event): Remove unused local var.
12409
018c5e19
PE
12410 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12411 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12412
63d2b86e
PE
12413 * bitmaps: Change bitmaps from unsigned char back to the X11
12414 compatible char. Avoid the old compiler warnings about
12415 out-of-range initializers by using, for example, '\xab' rather
12416 than 0xab.
12417
aefd87e1
PE
12418 * xgselect.c (xgselect_initialize): Check vs interface
12419 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12420
bf501fb9
PE
12421 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12422
e9829fdf
PE
12423 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12424 to read-only memory.
12425
1086c095
PE
12426 * fns.c (vector): Remove; this old hack is no longer needed.
12427
2baccd04 12428 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12429 Remove unused var.
dde42981 12430 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12431
72391843 12432 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12433
436c16df 12434 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12435 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12436 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12437
92bb796d 12438 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12439 (x_term_init): Remove local to avoid shadowing.
92bb796d 12440
764430a3 12441 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12442
12443 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12444 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12445
d1dfb56c
EZ
124462011-04-16 Eli Zaretskii <eliz@gnu.org>
12447
c4354cb4
EZ
12448 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12449
d1dfb56c
EZ
12450 Fix regex.c, syntax.c and friends for buffers > 2GB.
12451 * syntax.h (struct gl_state_s): Declare character position members
12452 EMACS_INT.
12453
12454 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12455
04f2d78b
CB
12456 * textprop.c (verify_interval_modification, interval_of):
12457 Declare arguments EMACS_INT.
d1dfb56c
EZ
12458
12459 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12460 EMACS_INT.
12461
12462 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12463
12464 * indent.c (Fvertical_motion): Local variable it_start is now
12465 EMACS_INT.
12466
12467 * regex.c (re_match, re_match_2, re_match_2_internal)
12468 (bcmp_translate, regcomp, regexec, print_double_string)
12469 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12470 (re_compile_pattern, re_exec): Declare arguments and local
12471 variables `size_t' and `ssize_t' and return values `regoff_t', as
12472 appropriate.
12473 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12474 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12475 <compile_stack_type>: `size' and `avail' are now `size_t'.
12476
12477 * regex.h <regoff_t>: Use ssize_t, not int.
12478 (re_search, re_search_2, re_match, re_match_2): Arguments that
12479 specify buffer/string position and length are now ssize_t and
12480 size_t. Return type is regoff_t.
12481
613052cd
BK
124822011-04-16 Ben Key <bkey76@gmail.com>
12483
12484 * nsfont.m: Fixed bugs in ns_get_family and
12485 ns_descriptor_to_entity that were caused by using free to
12486 deallocate memory blocks that were allocated by xmalloc (via
12487 xstrdup). This caused Emacs to crash when compiled with
12488 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12489 --enable-checking=xmallocoverrun). xfree is now used to
12490 deallocate these memory blocks.
12491
4170f62f 124922011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12493
71b41406
PE
12494 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12495
9587a89d
PE
12496 emacs_write: Accept and return EMACS_INT for sizes.
12497 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12498 et seq.
12499 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12500 Accept and return EMACS_INT.
12501 (emacs_gnutls_write): Return the number of bytes written on
12502 partial writes.
12503 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12504 (emacs_read, emacs_write): Remove check for negative size, as the
12505 Emacs source code has been audited now.
9587a89d
PE
12506 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12507 (emacs_read, emacs_write): Use it.
273a5f82
PE
12508 * process.c (send_process): Adjust to the new signatures of
12509 emacs_write and emacs_gnutls_write. Do not attempt to store
12510 a byte offset into an 'int'; it might overflow.
9587a89d 12511 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12512
3e047f51
PE
12513 * sound.c: Don't assume sizes fit in 'int'.
12514 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12515 Return EMACS_INT, not int.
3e047f51 12516 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12517 Accept EMACS_INT, not int.
12518 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12519 record read return values.
12520
cc39a9db
BK
125212011-04-15 Ben Key <bkey76@gmail.com>
12522
c9d0ec6d
JB
12523 * keyboard.c (Qundefined): Don't declare static since it is used
12524 in nsfns.m.
12525 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12526 static since they are used in nsfont.m.
cc39a9db 12527
6c60eb9f
SM
125282011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12529
12530 * process.c (Qprocessp): Don't declare static.
12531 * lisp.h (Qprocessp): Declare again.
12532
7990b61a
JB
125332011-04-15 Juanma Barranquero <lekktu@gmail.com>
12534
12535 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12536
5d4cb038
PE
125372011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12538
8bd7b830 12539 Improve C-level modularity by making more things 'static'.
cd64ea1d 12540
e3b27b31
PE
12541 Don't publish debugger-only interfaces to other modules.
12542 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12543 (verify_bytepos, count_markers): Move decls to the only modules
12544 that need them.
12545 * region-cache.h (pp_cache): Likewise.
12546 * window.h (check_all_windows): Likewise.
12547 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12548
5d4cb038
PE
12549 * sysdep.c (croak): Now static, if
12550 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12551 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12552
12553 * alloc.c (refill_memory_reserve): Now static if
12554 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12555 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12556
e87b6180
PE
12557 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12558 Define only if USE_LUCID.
12559
ac64929e
PE
12560 * xrdb.c (x_customization_string, x_rm_string): Now static.
12561
6f37259d
PE
12562 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12563 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12564
1683e3ab
PE
12565 * xdisp.c (draw_row_with_mouse_face): Now static.
12566 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12567
de9c2632
PE
12568 * window.h (check_all_windows): Mark externally visible.
12569
2b96acb7
PE
12570 * window.c (window_deletion_count): Now static.
12571
12572 * undo.c: Make symbols static if they're not exported.
12573 (last_undo_buffer, last_boundary_position, pending_boundary):
12574 Now static.
12575
50436f33
PE
12576 * textprop.c (interval_insert_behind_hooks): Now static.
12577 (interval_insert_in_front_hooks): Likewise.
12578
64520e5c
PE
12579 * term.c: Make symbols static if they're not exported.
12580 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12581 (max_frame_lines, tty_set_terminal_modes):
12582 (tty_reset_terminal_modes, tty_turn_off_highlight):
12583 (get_tty_terminal): Now static.
12584 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12585 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12586 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12587 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12588 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12589
1fa53021
PE
12590 * sysdep.c: Make symbols static if they're not exported.
12591 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12592 Now static.
12593 (sigprocmask_set, full_mask): Remove; unused.
12594 (wait_debugging): Mark as visible.
12595 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12596 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12597
d4b43b22
PE
12598 * syntax.c (syntax_temp): Define only if !__GNUC__.
12599
b7c513d0
PE
12600 * sound.c (current_sound_device, current_sound): Now static.
12601
989b29ad
PE
12602 * search.c (searchbufs, searchbuf_head): Now static.
12603
13a55a78
PE
12604 * scroll.c (scroll_cost): Remove; unused.
12605 * dispextern.h (scroll_cost): Remove decl.
12606
de68a1fc
PE
12607 * region-cache.h (pp_cache): Mark as externally visible.
12608
40ccffa6
PE
12609 * process.c: Make symbols static if they're not exported.
12610 (process_tick, update_tick, create_process, chan_process):
12611 (Vprocess_alist, proc_buffered_char, datagram_access):
12612 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12613 (deactivate_process): Mark defn as static, as well as decl.
12614 * lisp.h (create_process): Remove decl.
12615 * process.h (chan_process, Vprocess_alist): Remove decls.
12616
ad64fc97
PE
12617 * print.c: Make symbols static if they're not exported.
12618 (print_depth, new_backquote_output, being_printed, print_buffer):
12619 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12620 (print_interval, print_number_index, initial_stderr_stream):
12621 Now static.
12622 * lisp.h (Fprinc): Remove decl.
12623 (debug_output_compilation_hack): Mark as externally visible.
12624
adddb265
PE
12625 * sysdep.c (croak): Move decl from here to syssignal.h.
12626 * syssignal.h (croak): Put it here, so the API can be checked when
12627 'croak' is called from dissociate_if_controlling_tty.
12628
1717ede2
PE
12629 * minibuf.c: Make symbols static if they're not exported.
12630 (minibuf_save_list, choose_minibuf_frame): Now static.
12631 * lisp.h (choose_minibuf_frame): Remove decl.
12632
fa5fb2bc
PE
12633 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12634
1e3890d1
PE
12635 * lread.c: Make symbols static if they're not exported.
12636 (read_objects, initial_obarray, oblookup_last_bucket_number):
12637 Now static.
12638 (make_symbol): Remove; unused.
12639 * lisp.h (initial_obarray, make_symbol): Remove decls.
12640
8a1414fa
PE
12641 * keyboard.c: Make symbols static if they're not exported.
12642 (single_kboard, recent_keys_index, total_keys, recent_keys):
12643 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12644 (this_single_command_key_start, echoing, last_auto_save):
12645 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12646 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12647 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12648 (Vlispy_mouse_stem, double_click_count):
12649 Now static.
12650 (force_auto_save_soon): Define only if SIGDANGER.
12651 (ignore_mouse_drag_p): Now static if
12652 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12653 (print_help): Remove; unused.
12654 (stop_character, last_timer_event): Mark as externally visible.
12655 * keyboard.h (ignore_mouse_drag_p): Declare only if
12656 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12657 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12658 * lisp.h (echoing): Remove decl.
12659 (force_auto_save_soon): Declare only if SIGDANGER.
12660 * xdisp.c (redisplay_window): Simplify code, to make it more
12661 obvious that ignore_mouse_drag_p is not accessed if !defined
12662 USE_GTK && !defined HAVE_NS.
12663
93ea6e8f
PE
12664 * intervals.c: Make symbols static if they're not exported.
12665 (merge_properties_sticky, merge_interval_right, delete_interval):
12666 Now static.
12667 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12668
77382fcc
PE
12669 * insdel.c: Make symbols static if they're not exported.
12670 However, leave prepare_to_modify_buffer alone. It's never
12671 called from outside this function, but that appears to be a bug.
12672 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12673 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12674 (adjust_after_replace_noundo): Remove; unused.
12675 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12676 (signal_before_change): Remove decls.
77382fcc 12677
9306c32e
PE
12678 * indent.c (val_compute_motion, val_vmotion): Now static.
12679
cd44d2eb
PE
12680 * image.c: Make symbols static if they're not exported.
12681 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12682 if USE_GTK.
12683 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12684 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12685
ad9a7a06
PE
12686 * fringe.c (standard_bitmaps): Now static.
12687 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12688
81626931
PE
12689 * frame.c: Make symbols static if they're not exported.
12690 (x_report_frame_params, make_terminal_frame): Now static.
12691 (get_frame_param): Now static, unless HAVE_NS.
12692 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12693 (x_get_resource_string): Remove; not used.
12694 * frame.h (make_terminal_frame, x_report_frame_params):
12695 (x_get_resource_string); Remove decls.
12696 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12697 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12698
239f9db9
PE
12699 * font.c, fontset.c: Make symbols static if they're not exported.
12700 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12701 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12702 * font.c (font_close_object): Now static.
12703 * font.h (font_close_object): Remove.
12704 * fontset.c (FONTSET_OBJLIST): Remove.
12705 (free_realized_fontset) #if-0 the body, which does nothing.
12706 (face_suitable_for_char_p): #if-0, as it's never called.
12707 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12708 * xfaces.c (face_at_string_position):
12709 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12710 since 0 is always ASCII.
12711
dfcf3579
PE
12712 * fns.c (weak_hash_tables): Now static.
12713
5045092b
PE
12714 * fileio.c: Make symbols static if they're not exported.
12715 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12716 (Vwrite_region_annotation_buffers): Now static.
12717
57a96f5c
PE
12718 * eval.c: Make symbols static if they're not exported.
12719 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12720 * lisp.h (backtrace_list): Remove decl.
12721
35f08c38
PE
12722 * emacs.c: Make symbols static if they're not exported.
12723 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12724 (fatal_error_code, fatal_error_signal_hook, standard_args):
12725 Now static.
12726 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12727 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12728 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12729 * lisp.h (fatal_error_signal_hook): Remove decl.
12730 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12731
f44bd759
PE
12732 * editfns.c: Move a (normally-unused) function to its only use.
12733 * editfns.c, lisp.h (get_operating_system_release): Remove.
12734 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12735 worth the hassle of breaking this out.
12736
b532497d
PE
12737 * xterm.c: Make symbols static if they're not exported.
12738 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12739 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12740 (x_destroy_window, x_delete_display):
12741 Now static.
12742 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12743 (x_mouse_leave): Remove; unused.
12744 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12745 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12746 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12747 Remove decls.
12748 (x_mouse_leave): Declare only if WINDOWSNT.
12749 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12750 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12751 USE_X_TOOLKIT.
12752
1675728f
PE
12753 * ftxfont.c: Make symbols static if they're not exported.
12754 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12755 HAVE_FREETYPE.
12756 * font.h (ftxfont_driver): Likewise.
12757
e4cebfca
PE
12758 * xfns.c: Make symbols static if they're not exported.
12759 (x_last_font_name, x_display_info_for_name):
12760 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12761 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12762 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12763 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12764 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12765 (last_show_tip_args): Now static.
12766 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12767 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12768 (x_screen_planes): Remove; unused.
12769 * dispextern.h (x_screen_planes): Remove decl.
12770
5bf46f05
PE
12771 * dispnew.c: Make symbols static if they're not exported.
12772 * dispextern.h (redraw_garbaged_frames, scrolling):
12773 (increment_row_positions): Remove.
12774 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12775 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12776 Now static.
12777 (redraw_garbaged_frames): Remove; unused.
12778
435f4c28
PE
12779 * xfaces.c: Make symbols static if they're not exported.
12780 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12781 Remove decls.
12782 * xterm.h (defined_color): Remove decls.
12783 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12784 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12785 (menu_face_changed_default, defined_color, free_realized_face):
12786 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12787 (ascii_face_of_lisp_face): Remove; unused.
12788
8524aef3
PE
12789 * xdisp.c: Make symbols static if they're not exported.
12790 * dispextern.h (scratch_glyph_row, window_box_edges):
12791 (glyph_to_pixel_coords, set_cursor_from_row):
12792 (get_next_display_element, set_iterator_to_next):
12793 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12794 (show_mouse_face): Remove decls
12795 * frame.h (message_buf_print): Likewise.
12796 * lisp.h (pop_message, set_message, check_point_in_composition):
12797 Likewise.
12798 * xterm.h (set_vertical_scroll_bar): Likewise.
12799 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12800 (message_buf_print, scratch_glyph_row, displayed_buffer):
12801 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12802 (get_next_display_element, show_mouse_face, window_box_edges):
12803 (frame_to_window_pixel_xy, check_point_in_composition):
12804 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12805 (glyph_to_pixel_coords): Remove; unused.
12806
16390cd2
PE
12807 * dired.c (file_name_completion): Now static.
12808
12809 * dbusbind.c (xd_in_read_queued_messages): Now static.
12810
a25f4dfa
PE
12811 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12812 * data.c (circular_list_error): Remove.
12813
14a9c8df
PE
12814 * commands.h (last_point_position, last_point_position_buffer):
12815 (last_point_position_window): Remove decls.
12816 * keyboard.c: Make these variables static.
12817
04f2d78b
CB
12818 * coding.h (coding, code_convert_region, encode_coding_gap):
12819 Remove decls.
74ab6df5
PE
12820 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12821 (iso_code_class, detect_coding, code_convert_region): Now static.
12822 (encode_coding_gap): Remove; unused.
12823
38dfbee1
PE
12824 * chartab.c (chartab_chars, chartab_bits): Now static.
12825
a2cb4e63
PE
12826 * charset.h (charset_iso_8859_1): Remove decl.
12827 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12828 Now static.
12829
127198fd
PE
12830 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12831 * ccl.c (Vccl_program_table): Now static.
12832 (check_ccl_update): Remove; unused.
12833
d85b608f
PE
12834 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12835 * category.h: ... from here.
12836 * category.c (check_category_table, set_category_set): Now static.
12837
31cd66f3
PE
12838 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12839 * lisp.h: Remove these decls.
12840
c358e587
PE
12841 * buffer.c (buffer_count): Remove unused var.
12842
e78aecca
PE
12843 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12844 so that it's not optimized away.
12845 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12846 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12847 exported only to the debugger.
12848
e192d7d3 12849 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12850 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12851
92470028
PE
12852 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12853 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12854 was inaccessible from Lisp.
12855 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12856 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12857
244ed907
PE
12858 alloc.c: Import and export fewer symbols, and remove unused items.
12859 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12860 is defined.
12861 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12862 it's not optimized away by whole-program optimization.
12863 (message_enable_multibyte, free_misc): Remove.
12864 (catchlist, handlerlist, mark_backtrace):
12865 Declare only if BYTE_MARK_STACK.
12866 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12867 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12868 (message_enable_multibyte): Remove decl.
12869 (free_misc, interval_free_list, float_block, float_block_index):
12870 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12871 (cons_free_list, last_marked_index):
12872 Now static.
12873 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12874 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12875 (mark_backtrace): Define only if BYTE_MARK_STACK.
12876 * xdisp.c (message_enable_multibyte): Now static.
12877
61c2b50e 12878 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12879 This makes it easier for human readers (and static analyzers)
12880 to see whether these variables are used from other modules.
12881 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12882 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12883 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12884 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12885 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12886 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12887 * xmenu.c, xselect.c:
12888 Declare Q* vars static if they are not used in other modules.
12889 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12890 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12891 Remove decls of unexported vars.
12892 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12893
95c82688
PE
12894 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12895
16a97296
PE
12896 Make Emacs functions such as Fatom 'static' by default.
12897 This makes it easier for human readers (and static analyzers)
12898 to see whether these functions can be called from other modules.
12899 DEFUN now defines a static function. To make the function external
12900 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12901 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12902 (Finit_image_library):
16a97296
PE
12903 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12904 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12905 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12906 Remove decls, since these functions are now static.
12907 (Funintern, Fget_internal_run_time): New decls, since these functions
12908 were already external.
95c82688 12909
16a97296
PE
12910 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12911 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12912 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12913 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12914 * keyboard.c, keymap.c, lread.c:
12915 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12916 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12917 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12918 Mark functions with DEFUE instead of DEFUN,
12919 if they are used in other modules.
12920 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12921 decls for now-static functions.
12922 * buffer.h (Fdelete_overlay): Remove decl.
12923 * callproc.c (Fgetenv_internal): Mark as internal.
12924 * composite.c (Fremove_list_of_text_properties): Remove decl.
12925 (Fcomposition_get_gstring): New forward static decl.
12926 * composite.h (Fcomposite_get_gstring): Remove decl.
12927 * dired.c (Ffile_attributes): New forward static decl.
12928 * doc.c (Fdocumntation_property): New forward static decl.
12929 * eval.c (Ffetch_bytecode): New forward static decl.
12930 (Funintern): Remove extern decl; now in .h file where it belongs.
12931 * fileio.c (Fmake_symbolic_link): New forward static decl.
12932 * image.c (Finit_image_library): New forward static decl.
12933 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12934 * intervals.h (Fprevious_property_change):
12935 (Fremove_list_of_text_properties): Remove decls.
12936 * keyboard.c (Fthis_command_keys): Remove decl.
12937 (Fcommand_execute): New forward static decl.
12938 * keymap.c (Flookup_key): New forward static decl.
12939 (Fcopy_keymap): Now static.
12940 * keymap.h (Flookup_key): Remove decl.
12941 * process.c (Fget_process): New forward static decl.
12942 (Fprocess_datagram_address): Mark as internal.
12943 * syntax.c (Fsyntax_table_p): New forward static decl.
12944 (skip_chars): Remove duplicate decl.
12945 * textprop.c (Fprevious_property_change): New forward static decl.
12946 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12947 Now internal.
12948 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12949 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12950
785bbd42
PE
12951 * editfns.c (Fformat): Remove unreachable code.
12952
8b913b57
AS
129532011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12954
12955 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12956 change. (Bug#8496)
12957
a6744a35
EZ
129582011-04-13 Eli Zaretskii <eliz@gnu.org>
12959
12960 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12961 when at ZV. (Bug#8487)
12962
e7974947
AS
129632011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12964
baad03f0
AS
12965 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12966 (Bug#8437)
12967 * keyboard.c (parse_tool_bar_item): Likewise.
12968 * sound.c (sound_cleanup, alsa_close): Likewise.
12969 * termcap.c (tgetent): Likewise.
12970 * xfns.c (x_default_font_parameter): Likewise.
12971 * xsettings.c (read_and_apply_settings): Likewise.
12972
e7974947
AS
12973 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12974 (overrun_check_free): Protoize.
12975
28272684
PE
129762011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12977
12978 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12979 since callers should never pass a negative size.
12980 Change the signature to match that of plain 'read' and 'write'; see
12981 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12982 * lisp.h: Update prototypes of emacs_write and emacs_read.
12983
11997c76
EZ
129842011-04-11 Eli Zaretskii <eliz@gnu.org>
12985
12986 * xdisp.c (redisplay_window): Don't try to determine the character
12987 position of the scroll margin if the window start point w->startp
e896f03c 12988 is outside the buffer's accessible region. (Bug#8468)
11997c76 12989
8a2cbd72
EZ
129902011-04-10 Eli Zaretskii <eliz@gnu.org>
12991
12992 Fix write-region and its subroutines for buffers > 2GB.
12993 * fileio.c (a_write, e_write): Modify declaration of arguments and
12994 local variables to support buffers larger than 2GB.
12995 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12996
12997 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12998 argument, local variables, and return value.
12999
13000 * lisp.h: Update prototypes of emacs_write and emacs_read.
13001
13002 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13003
4073e537 130042011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13005
1ebfdcb6
PE
13006 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13007
b2ded58d
PE
13008 Fix more problems found by GCC 4.6.0's static checks.
13009
7d66342c
PE
13010 * xdisp.c (vmessage): Use a better test for character truncation.
13011
bbf47d44
PE
13012 * charset.c (load_charset_map): <, not <=, for optimization,
13013 and to avoid potential problems with integer overflow.
9248994d 13014 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13015 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13016 * editfns.c (Fformat): Likewise.
1e69125e 13017 * syntax.c (skip_chars): Likewise.
3befa583 13018
e3019616
PE
13019 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13020 This also lets GCC 4.6.0 generate slightly better loop code.
13021
becfa255
PE
13022 * callint.c (Fcall_interactively): <, not <=, for optimization.
13023 (Fcall_interactively): Count the number of arguments produced,
13024 not the number of arguments given. This is simpler and lets GCC
13025 4.6.0 generate slightly better code.
13026
dae0cd48
PE
13027 * ftfont.c: Distingish more carefully between FcChar8 and char.
13028 The previous code passed unsigned char * to a functions like
13029 strlen and xstrcasecmp that expect char *, which does not
13030 conform to the C standard.
13031 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13032 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13033 char * when the C standard requires it.
13034
76032d70
PE
13035 * keyboard.c (read_char): Remove unused var.
13036
eb3f1cc8
PE
13037 * eval.c: Port to Windows vsnprintf (Bug#8435).
13038 Include <limits.h>.
13039 (SIZE_MAX): Define if the headers do not.
13040 (verror): Do not give up if vsnprintf returns a negative count.
13041 Instead, grow the buffer. This ports to Windows vsnprintf, which
13042 does not conform to C99. Problem reported by Eli Zaretskii.
13043 Also, simplify the allocation scheme, by avoiding the need for
13044 calling realloc, and removing the ALLOCATED variable.
13045
70476b54
PE
13046 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13047
12020a9e
PE
13048 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13049 But keep the doprint source code for now, as we might revamp it
13050 and use it again (Bug#8435).
ea6c7ae6
PE
13051 * lisp.h (doprnt): Remove.
13052 * Makefile.in (base_obj): Remove doprnt.o.
13053 * deps.mk (doprnt.o): Remove.
13054
5fdb398c
PE
13055 error: Print 32- and 64-bit integers portably (Bug#8435).
13056 Without this change, on typical 64-bit hosts error ("...%d...", N)
13057 was used to print both 32- and 64-bit integers N, which relied on
13058 undefined behavior.
61bdb816 13059 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13060 * lisp.h (error, verror): Mark as printf-like functions.
13061 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13062 Report overflow in size calculations when allocating printf buffer.
13063 Do not truncate output string at its first null byte.
13064 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13065 Truncate the output at a character boundary, since vsnprintf does not
13066 do that.
13067 * charset.c (check_iso_charset_parameter): Convert internal
13068 character to string before calling 'error', since %c now has the
13069 printf meaning.
13070 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13071 overflow when computing char to be passed to 'error'. Do not
13072 pass Lisp_Object to 'error'; pass the integer instead.
13073 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13074 formatted with plain %d.
13075
b189fa66
PE
13076 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13077
bff87ef0
PE
13078 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13079
7e2cac20
PE
13080 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13081
ce4d90b5
PE
13082 * xterm.c (x_catch_errors): Remove duplicate declaration.
13083
266c9547
PE
13084 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13085
79c49ad2
PE
13086 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13087
368f4090
JM
130882011-04-10 Jim Meyering <meyering@redhat.com>
13089
13090 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13091 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13092 return ssize_t not "int", and use size_t as the buffer length.
13093 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13094 * gnutls.h: Update declarations.
13095 * process.c (read_process_output): Use ssize_t, to match.
13096 (send_process): Likewise.
13097
a32d4040
CY
130982011-04-09 Chong Yidong <cyd@stupidchicken.com>
13099
13100 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13101
8546720e 131022011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13103
04f2d78b
CB
13104 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13105 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13106
8546720e
GM
13107 * xterm.c (handle_one_xevent):
13108 * xmenu.c (create_and_show_popup_menu):
13109 * xselect.c (x_decline_selection_request)
13110 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13111
0a2f5c1a 131122011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13113
13114 Fix some uses of `int' instead of EMACS_INT.
13115 * search.c (string_match_1, fast_string_match)
13116 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13117 (scan_buffer, find_next_newline_no_quit)
13118 (find_before_next_newline, search_command, Freplace_match)
13119 (Fmatch_data): Make some `int' variables be EMACS_INT.
13120
13121 * xdisp.c (display_count_lines): 3rd argument and return value now
13122 EMACS_INT. All callers changed.
13123 (pint2hrstr): Last argument is now EMACS_INT.
13124
13125 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13126 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13127 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13128 (decode_coding_utf_16, decode_coding_emacs_mule)
13129 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13130 (decode_coding_ccl, decode_coding_charset)
13131 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13132 (decode_coding_iso_2022, decode_coding_emacs_mule)
13133 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13134 <char_offset, last_offset>: Declare EMACS_INT.
13135 (encode_coding_utf_8, encode_coding_utf_16)
13136 (encode_coding_emacs_mule, encode_invocation_designation)
13137 (encode_designation_at_bol, encode_coding_iso_2022)
13138 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13139 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13140 Declare EMACS_INT.
13141 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13142 (encode_invocation_designation): Last argument P_NCHARS is now
13143 EMACS_INT.
13144 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13145 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13146
13147 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13148 All users changed.
13149
13150 * ccl.c (Fccl_execute_on_string): Declare some variables
13151 EMACS_INT.
13152
8546720e 131532011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13154
13155 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13156
4e19a977
CS
131572011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13158
13159 * process.c (Fformat_network_address): Doc fix.
13160
87302331
R
131612011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13162
ee7683eb 13163 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13164
cbb59342
CY
131652011-04-08 Chong Yidong <cyd@stupidchicken.com>
13166
13167 * keyboard.c (read_char): Call Lisp function help-form-show,
13168 instead of using internal_with_output_to_temp_buffer.
13169 (Qhelp_form_show): New var.
e0d38eeb 13170 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13171
13172 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13173
13174 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13175
e67a13ab
CY
131762011-04-06 Chong Yidong <cyd@stupidchicken.com>
13177
04f2d78b
CB
13178 * process.c (Flist_processes): Remove to Lisp.
13179 (list_processes_1): Delete.
e67a13ab 13180
973f782d
EZ
131812011-04-06 Eli Zaretskii <eliz@gnu.org>
13182
7c106b1e
EZ
13183 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13184
973f782d
EZ
13185 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13186
41cf7d1a 131872011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13188
ca23cc88
PE
13189 Fix more problems found by GCC 4.6.0's static checks.
13190
f390e2d5
PE
13191 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13192
42eea0d0
PE
13193 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13194
b69769da 13195 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13196
f9541e84
PE
13197 * xdisp.c (vmessage): Mark as a printf-like function.
13198
13841b55
PE
13199 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13200
c136c10f
PE
13201 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13202
5e2d4a30
PE
13203 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13204 printf-like functions.
13205 (tiff_load): Add casts to remove these marks before passing them
13206 to system-supplied API.
13207
583f48b9
PE
13208 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13209
b25d760e
PE
13210 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13211 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13212 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13213 directly, rather than having caller test rule sign. This avoids
13214 some unnecessary tests.
13215 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13216 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13217 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13218
bc7b6697 13219 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13220 (xfont_open): Avoid unnecessary tests.
bc7b6697 13221
27ccc379
PE
13222 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13223
dcd5c89a
PE
13224 * composite.h, composite.c (composition_gstring_put_cache):
13225 Use EMACS_INT, not int, for length.
13226
b13a45c6
PE
13227 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13228 breaking out part of COMPOSITION_DECODE_RULE.
13229 (COMPOSITION_DECODE_RULE): Use it.
13230 * composite.c (get_composition_id): Remove unused local vars,
13231 by using the new macro.
13232
1e792e4d
PE
13233 * textprop.c (set_text_properties_1): Change while to do-while,
13234 since the condition is always true at first.
13235
dc6c6455 13236 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13237 (interval_deletion_adjustment): Return unsigned value.
13238 All uses changed.
dc6c6455 13239
aba7731a
PE
13240 * process.c (list_processes_1, create_pty, read_process_output):
13241 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13242 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13243 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13244 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13245 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13246
fdfc4bf3
PE
13247 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13248
fca8fe46 13249 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13250 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13251
06a0259a 13252 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13253 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13254 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13255
e7b9e80f
PE
13256 * print.c (print_error_message): Avoid int overflow.
13257
56201685
PE
13258 * font.c (font_list_entities): Redo for clarity,
13259 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13260
78834453 13261 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13262 (font_score): Avoid potential overflow in diff calculation.
78834453 13263
0bc0b309 13264 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13265 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13266
e610eaca
PE
13267 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13268
b895abce
PE
13269 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13270 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13271 can always succeed if overflow has undefined behavior.
13272
1f1d9321 13273 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13274 (wordify): Omit three unnecessary tests.
1f1d9321 13275
c59478bc
PE
13276 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13277 All callers changed. This avoids the need for an unused var.
13278
79b73827
PE
13279 * casefiddle.c (casify_region): Remove var that is set but not used.
13280
a4db5dfe
PE
13281 * dired.c (file_name_completion): Remove var that is set but not used.
13282
43aae36e
PE
13283 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13284
2a47c44d 13285 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13286 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13287
a37c69bf
PE
13288 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13289 Check for integer overflow on size calculations.
13290
328ab8e7
PE
13291 * buffer.c (Fprevious_overlay_change): Remove var that is set
13292 but not used.
13293
e5a2a5cb
PE
13294 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13295 Remove vars that are set but not used.
8d84a6eb 13296 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13297 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13298
a60e5f68
PE
13299 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13300
f661cb61 13301 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13302 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13303
f0397f5a
PE
13304 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13305 that are set but not used.
13306
8664db06 13307 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13308 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13309
6abdaa4a
PE
13310 * xselect.c (x_get_local_selection, x_handle_property_notify):
13311 Remove vars that are set but not used.
13312
0ce7538d 13313 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13314 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13315
9ae848fc
PE
13316 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13317 Remove var that is set but not used.
0b918413
PE
13318 (scroll_bar_windows_size): Now size_t, not int.
13319 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13320 Check for overflow.
9ae848fc 13321
a5a62657
PE
13322 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13323 (map_tty_color) [!defined MSDOS]: Likewise.
13324
5c5cdd39
PE
13325 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13326
66ebf983
PE
13327 * coding.c: Remove vars that are set but not used.
13328 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13329 All callers changed.
13330 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13331 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13332 (decode_coding_charset): Remove vars that are set but not used.
13333
1be4d761
PE
13334 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13335 that is set but not used.
13336
47553fa8
PE
13337 * print.c (print_object): Remove var that is set but not used.
13338
1f7196bf 13339 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13340 The gnulib version avoids calling malloc in the usual case,
13341 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13342 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13343 * filelock.c (current_lock_owner): Likewise.
13344 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13345 * sysdep.c: Include allocator.h, careadlinkat.h.
13346 (emacs_no_realloc_allocator): New static constant.
13347 (emacs_readlink): New function.
fdb61804
PE
13348 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13349 ../lib/careadlinkat.h.
d1fdcab7 13350
f84c17c7
SM
133512011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13352
13353 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13354 first non-nil return value).
13355
ef3862ad
JD
133562011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13357
13358 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13359 if not defined (Bug#8403).
13360
376a7006
JB
133612011-04-02 Juanma Barranquero <lekktu@gmail.com>
13362
13363 * xdisp.c (display_count_lines): Remove parameter `start',
13364 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13365 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13366 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13367 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13368 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13369 and thereabouts. All callers changed.
13370 (get_per_char_metric): Remove parameter `f', unused since
13371 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13372
6ca3801d
JM
133732011-04-02 Jim Meyering <meyering@redhat.com>
13374
13375 do not dereference NULL upon failed strdup
13376 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13377 (ns_get_family): Likewise.
13378
d8e2b5ba
JB
133792011-04-02 Juanma Barranquero <lekktu@gmail.com>
13380
13381 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13382
8c74fcbd
JD
133832011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13384
13385 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13386 later (Bug#8403).
13387
7200d79c
SM
133882011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13389
03408648 13390 Add lexical binding.
7200d79c 13391
03408648
SM
13392 * window.c (Ftemp_output_buffer_show): New fun.
13393 (Fsave_window_excursion):
13394 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13395
13396 * lread.c (lisp_file_lexically_bound_p): New function.
13397 (Fload): Bind Qlexical_binding.
13398 (readevalloop): Remove `evalfun' arg.
13399 Bind Qinternal_interpreter_environment.
13400 (Feval_buffer): Bind Qlexical_binding.
13401 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13402 Mark as dynamic.
13403 (syms_of_lread): Declare `lexical-binding'.
13404
13405 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13406
13407 * keyboard.c (eval_dyn): New fun.
13408 (menu_item_eval_property): Use it.
ca105506
SM
13409
13410 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13411
03408648
SM
13412 * fns.c (concat, mapcar1): Accept byte-code-functions.
13413
13414 * eval.c (Fsetq): Handle lexical vars.
13415 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13416 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13417 (FletX, Flet): Obey lexical binding.
13418 (Fcommandp): Handle closures.
13419 (Feval): New `lexical' arg.
13420 (eval_sub): New function extracted from Feval. Use it almost
13421 everywhere where Feval was used. Look up vars in lexical env.
13422 Handle closures.
13423 (Ffunctionp): Move from subr.el.
13424 (Ffuncall): Handle closures.
13425 (apply_lambda): Remove `eval_flags'.
13426 (funcall_lambda): Handle closures and new byte-code-functions.
13427 (Fspecial_variable_p): New function.
13428 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13429 but without exporting it to Lisp.
23aba0ea 13430
23aba0ea 13431 * doc.c (Fdocumentation, store_function_docstring):
03408648 13432 * data.c (Finteractive_form): Handle closures.
23aba0ea 13433
03408648
SM
13434 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13435 interactive spec.
ba83908c 13436
04f2d78b
CB
13437 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13438 New byte-codes.
03408648
SM
13439 (exec_byte_code): New function extracted from Fbyte_code to handle new
13440 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13441
03408648 13442 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13443
03408648 13444 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13445
e2abce01
JB
134462011-03-31 Juanma Barranquero <lekktu@gmail.com>
13447
13448 * xdisp.c (redisplay_internal): Fix prototype.
13449
63696a73 134502011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13451
63696a73 13452 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13453 (try_scrolling): Use it when setting scroll_limit.
13454 Limit scrolling to 100 screen lines.
63696a73
EZ
13455 (redisplay_window): Even when falling back on "recentering",
13456 position point in the window according to scroll-conservatively,
13457 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13458
13459 (try_scrolling): When point is above the window, allow searching
13460 as far as scroll_max, or one screenful, to compute vertical
13461 distance from PT to the scroll margin position. This prevents
13462 try_scrolling from unnecessarily failing when
13463 scroll-conservatively is set to a value slightly larger than the
13464 window height. Clean up the case of PT below the margin at bottom
13465 of window: scroll_max can no longer be INT_MAX. When aggressive
13466 scrolling is in use, don't let point enter the opposite scroll
13467 margin as result of the scroll.
13468 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13469 threshold of 100 lines for never-recentering scrolling.
13470
e4cc2dfc
JB
134712011-03-31 Juanma Barranquero <lekktu@gmail.com>
13472
13473 * dispextern.h (move_it_by_lines):
13474 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13475 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13476 (message_log_check_duplicate): Remove parameters `prev_bol' and
13477 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13478 (redisplay_internal): Remove parameter `preserve_echo_area',
13479 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13480
13481 * indent.c (Fvertical_motion):
13482 * window.c (window_scroll_pixel_based, Frecenter):
13483 Don't pass `need_y_p' to `move_it_by_lines'.
13484
1c470562
SM
134852011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13486
44f230aa
SM
13487 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13488 steal a few bits to be more compact.
13489 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13490 Remove unneeded casts.
13491
1c470562
SM
13492 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13493
888adce9
ZK
134942011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13495
13496 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13497 binding" message (bug#7967).
13498
f838ed7b
PE
134992011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13500
77861b95
PE
13501 Fix more problems found by GCC 4.6.0's static checks.
13502
de6dbc14
PE
13503 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13504 Remove unused local var.
13505
f838ed7b
PE
13506 * editfns.c (Fmessage_box): Remove unused local var.
13507
792c7b2b
PE
13508 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13509 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13510 Omit unused local vars.
c499e557 13511 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13512 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13513 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13514 Omit unused local var.
13515
ba0165e1
PE
13516 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13517 Don't assume string length fits in int.
32ad8845 13518 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13519 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13520
3c59b4c9
PE
13521 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13522 instead of alloca (Bug#8344).
13523
a3eed478 13524 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13525 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13526
eb4d412d
PE
13527 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13528
1658b401
PE
13529 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13530 concerns.
13531
13532 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13533
13534 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13535
9a2c6e05
PE
13536 * keyboard.c (syms_of_keyboard): Use the same style as later
13537 in this function when indexing through an array. This also
13538 works around GCC bug 48267.
13539
03d0a109
PE
13540 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13541
44f730c8
PE
13542 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13543
fe75f926
PE
13544 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13545 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13546
ffa8c828
PE
13547 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13548 This avoids undefined behavior on integer overflow, and is a bit
13549 more convenient anyway since it is compared to a size_t variable.
13550
c5101a77
PE
13551 Variadic C functions now count arguments with size_t, not int.
13552 This avoids an unnecessary limitation on 64-bit machines, which
13553 caused (substring ...) to crash on large vectors (Bug#8344).
13554 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13555 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13556 All variadic functions and their callers changed accordingly.
c5101a77
PE
13557 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13558 * data.c (arith_driver, float_arith_driver): Likewise.
13559 * editfns.c (general_insert_function): Likewise.
13560 * eval.c (struct backtrace.nargs, interactive_p)
13561 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13562 (funcall_lambda, mark_backtrace): Likewise.
13563 * fns.c (concat): Likewise.
13564 * frame.c (x_set_frame_parameters): Likewise.
13565 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13566 0 if not found, not -1. All callers changed.
13567
dd3f25f7
PE
13568 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13569 (stack_copy_size): Now size_t, not int.
13570 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13571
461c2ab9
JB
135722011-03-28 Juanma Barranquero <lekktu@gmail.com>
13573
13574 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13575 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13576 All callers changed.
13577
13578 * lisp.h (multibyte_char_to_unibyte):
13579 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13580 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13581 * character.h (CHAR_TO_BYTE8):
13582 * cmds.c (internal_self_insert):
13583 * editfns.c (general_insert_function):
13584 * keymap.c (push_key_description):
13585 * search.c (Freplace_match):
13586 * xdisp.c (message_dolog, set_message_1): All callers changed.
13587
f6d62986
SM
135882011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13589
13590 * keyboard.c (safe_run_hook_funcall): New function.
13591 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13592 don't set the hook to nil, but remove the offending function instead.
13593 (Qcommand_hook_internal): Remove, unused.
13594 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13595 Vcommand_hook_internal.
13596
13597 * eval.c (enum run_hooks_condition): Remove.
13598 (funcall_nil, funcall_not): New functions.
13599 (run_hook_with_args): Call each function through a `funcall' argument.
13600 Remove `cond' argument, now redundant.
13601 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13602 (Frun_hook_with_args_until_failure): Adjust accordingly.
13603 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13604
1db5b1ad
JB
136052011-03-28 Juanma Barranquero <lekktu@gmail.com>
13606
13607 * dispextern.h (string_buffer_position): Remove declaration.
13608
13609 * print.c (strout): Remove parameter `multibyte', unused since
13610 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13611
13612 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13613 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13614 All callers changed.
13615
13616 * w32.c (_wsa_errlist): Use braces for struct initializers.
13617
13618 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13619 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13620 All callers changed.
13621 (string_buffer_position): Likewise. Also, make static (it's never
13622 used outside xdisp.c).
13623 (cursor_row_p): Remove parameter `w', unused since
13624 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13625 (decode_mode_spec): Remove parameter `precision', introduced during
13626 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13627 All callers changed.
13628
5ffb62aa
JD
136292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13630
13631 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13632
461c2ab9 136332011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13634
13635 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13636 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13637 (ns_update_auto_hide_menu_bar): New functions.
13638 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13639 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13640 ns_constrain_all_frames.
13641 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13642 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13643
5c380ffb
JD
136442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13645
13646 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13647
9af30bdf
GM
136482011-03-27 Glenn Morris <rgm@gnu.org>
13649
13650 * syssignal.h: Replace RETSIGTYPE with void.
13651 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13652 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13653 Replace SIGTYPE with void everywhere.
13654 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13655 * s/template.h (SIGTYPE): Remove commented out definition.
13656
e2abce01
JB
136572011-03-26 Eli Zaretskii <eliz@gnu.org>
13658
13659 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13660 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13661
f868cd8a
JB
136622011-03-26 Juanma Barranquero <lekktu@gmail.com>
13663
59eb0929
JB
13664 * w32.c (read_unc_volume): Use parameter `henum', instead of
13665 global variable `wget_enum_handle'.
13666
13667 * keymap.c (describe_vector): Remove parameters `indices' and
13668 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13669 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13670
f868cd8a
JB
13671 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13672
13673 * keyboard.c (timer_check): Remove parameter `do_it_now',
13674 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13675 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13676 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13677
13678 * keyboard.c (read_char):
13679 * w32menu.c (w32_menu_display_help):
13680 * xmenu.c (show_help_event, menu_help_callback):
13681 Adjust calls to `show_help_echo'.
13682
13683 * gtkutil.c (xg_maybe_add_timer):
13684 * keyboard.c (readable_events):
13685 * process.c (wait_reading_process_output):
13686 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13687
13688 * insdel.c (adjust_markers_gap_motion):
13689 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13690 (gap_left, gap_right): Don't call it.
13691
2ecf6fdb
CY
136922011-03-25 Chong Yidong <cyd@stupidchicken.com>
13693
13694 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13695 incurred during fontification.
13696
6b1f9ba4
JB
136972011-03-25 Juanma Barranquero <lekktu@gmail.com>
13698
13699 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13700 (DEFVAR_PER_BUFFER): Don't pass it.
13701
13702 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13703 (scrolling_window): Don't pass it.
13704
0f4a96b5
JB
137052011-03-25 Juanma Barranquero <lekktu@gmail.com>
13706
13707 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13708
13709 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13710 and `suffix'.
13711 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13712 of variables specific to SELinux and computation of `encoded_absname'.
13713
13714 * image.c (XPutPixel): Remove unused variable `height'.
13715
13716 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13717
13718 * unexw32.c (get_section_info): Remove unused variable `section'.
13719
13720 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13721 (system_process_attributes): Remove unused variable `sess'.
13722 (sys_read): Remove unused variable `err'.
13723
13724 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13725 (w32_wnd_proc): Remove unused variable `isdead'.
13726 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13727 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13728 (x_create_tip_frame): Remove unused variable `tem'.
13729
13730 * w32inevt.c (w32_console_read_socket):
13731 Remove unused variable `no_events'.
13732
13733 * w32term.c (x_draw_composite_glyph_string_foreground):
13734 Remove unused variable `width'.
13735
1149507c
JB
137362011-03-24 Juanma Barranquero <lekktu@gmail.com>
13737
13738 * w32term.c (x_set_glyph_string_clipping):
13739 Don't pass uninitialized region to CombineRgn.
13740
9c88f339
JB
137412011-03-23 Juanma Barranquero <lekktu@gmail.com>
13742
13743 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13744 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13745 (Fx_close_connection): Remove unused variable `i'.
13746
13747 * w32font.c (w32font_draw): Return number of glyphs.
13748 (w32font_open_internal): Remove unused variable `i'.
13749 (w32font_driver): Add missing initializer.
13750
13751 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13752 (fill_in_menu): Remove unused variable `items_added'.
13753
13754 * w32term.c (last_mouse_press_frame): Remove static global variable.
13755 (w32_clip_to_row): Remove unused variable `f'.
13756 (x_delete_terminal): Remove unused variable `i'.
13757
13758 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13759 (NOTHING): Remove unused static global variable.
13760 (uniscribe_check_otf): Remove unused variable `table'.
13761 (uniscribe_font_driver): Add missing initializers.
13762
dee091a3
JD
137632011-03-23 Julien Danjou <julien@danjou.info>
13764
13765 * term.c (Fsuspend_tty, Fresume_tty):
13766 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13767 * window.c (temp_output_buffer_show):
13768 * insdel.c (signal_before_change):
13769 * frame.c (Fhandle_switch_frame):
13770 * fileio.c (Fdo_auto_save):
13771 * emacs.c (Fkill_emacs):
13772 * editfns.c (save_excursion_restore):
13773 * cmds.c (internal_self_insert):
13774 * callint.c (Fcall_interactively):
13775 * buffer.c (Fkill_all_local_variables):
13776 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13777 Use Frun_hooks.
0f4a96b5 13778 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13779 unconditionally since it does the check itself.
dee091a3 13780
2c520ab5 137812011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13782
c9c49752
PE
13783 Fix more problems found by GCC 4.5.2's static checks.
13784
8abc3f12
PE
13785 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13786 the first time through the loop, since we know p0 < p1 then.
13787 This also avoids a gcc -Wstrict-overflow warning.
13788
a2d26660
PE
13789 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13790 leading to a memory leak, possible in functions like
13791 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13792 of objects (Bug#8318).
a2d26660 13793
916c72e9
PE
13794 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13795 that could (at least in theory) be that large.
13796
19ab8a18
PE
13797 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13798 This is less likely to overflow, and avoids undefined behavior if
13799 overflow does occur. All callers changed. Use strtoul to scan
13800 for the unsigned long integer.
b7cbbd6f
PE
13801 (pint2hrstr): Simplify and tune code slightly.
13802 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13803
f0641eff
PE
13804 * scroll.c (do_scrolling): Work around GCC bug 48228.
13805 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13806
7f650bb9
PE
13807 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13808 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13809 (validate_x_resource_name): Simplify count usage.
13810 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13811
37dd57d1
PE
13812 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13813 fail (Bug#8306).
81e56e61 13814
699979fc 13815 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13816
401bf9b4
PE
13817 * process.c (Fmake_network_process): Use socklen_t, not int,
13818 where POSIX says socklen_t is required in portable programs.
13819 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13820 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13821 (Fmake_network_process, server_accept_connection):
13822 (wait_reading_process_output, read_process_output):
13823 Likewise.
13824
b93aacde
PE
13825 * process.c: Rename or move locals to avoid shadowing.
13826 (list_processes_1, Fmake_network_process):
13827 (read_process_output_error_handler, exec_sentinel_error_handler):
13828 Rename or move locals.
4dc343ee 13829 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13830 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13831 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13832 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13833 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13834
af8a867c 13835 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13836 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13837 Include tparam.h instead, since it declares them.
af8a867c
PE
13838 * cm.h (PC): Remove extern decl; tparam.h now does this.
13839 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13840 * terminfo.c: Include tparam.h, to check interfaces.
13841 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13842 (tparam): Adjust signature to match interface in tparam.h;
13843 this removes some undefined behavior. Check that outstring and len
13844 are zero, which they always are with Emacs.
13845 * tparam.h (PC, BC, UP): New extern decls.
13846
0248044d 13847 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13848 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13849
8ff096c1 13850 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13851 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13852 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13853 (ftfont_list): Remove unused local.
49eaafba
PE
13854 (get_adstyle_property, ftfont_pattern_entity):
13855 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13856 Rename locals to avoid shadowing.
8ff096c1 13857
e2be39f6
PE
13858 * xfont.c (xfont_list_family): Mark var as initialized.
13859
c9735e30
PE
13860 * xml.c (make_dom): Now static.
13861
8f5201ae
PE
13862 * composite.c (composition_compute_stop_pos): Rename local to
13863 avoid shadowing.
b246f932
PE
13864 (composition_reseat_it): Remove unused locals.
13865 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13866 (composition_update_it): Mark var as initialized.
11b61122
PE
13867 (find_automatic_composition): Mark vars as initialized,
13868 with a FIXME (Bug#8290).
8f5201ae 13869
760fbc2c
PE
13870 character.h: Rename locals to avoid shadowing.
13871 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13872 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13873 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13874 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13875 to avoid shadowing.
13876
ff08eb85
PE
13877 * textprop.c (property_change_between_p): Remove; unused.
13878
fc7bf025
PE
13879 * intervals.c (interval_start_pos): Now static.
13880
235d7abc
PE
13881 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13882
44f230aa
SM
13883 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13884 Rename locals to avoid shadowing.
3e7d6594 13885
50060332
PE
13886 * sound.c (wav_play, au_play, Fplay_sound_internal):
13887 Fix pointer signedness.
d01f234b 13888 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13889 (wav_play): Initialize a variable to 0, to prevent undefined
13890 behavior (Bug#8278).
50060332 13891
c4fc4e30
PE
13892 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13893
918436ed
PE
13894 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13895
c939f91b
PE
13896 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13897 clobbering (Bug#8298).
b9c7f648
PE
13898 * sysdep.c (sys_subshell): Likewise.
13899 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13900
6bd8c144
PE
13901 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13902 This should get cleaned up, so that child_setup has the
13903 same signature on all platforms.
13904
7710357c 13905 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13906 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13907
c59da222
CY
139082011-03-22 Chong Yidong <cyd@stupidchicken.com>
13909
13910 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13911 not to be necessary, and produces flickering.
13912
66b87493
GM
139132011-03-20 Glenn Morris <rgm@gnu.org>
13914
13915 * config.in: Remove file.
13916
45b6f6d5
JB
139172011-03-20 Juanma Barranquero <lekktu@gmail.com>
13918
13919 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13920 are now in src/globals.h.
13921 (syms_of_minibuf): Remove spurious & from previous change.
13922
cd394be1 139232011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13924
13925 * minibuf.c (completing-read-function): New variable.
13926 (completing-read-default): Rename from completing-read.
13927 (completing-read): Call completing-read-function.
13928
b14e3e21
CY
139292011-03-19 Juanma Barranquero <lekktu@gmail.com>
13930
13931 * xfaces.c (Fx_load_color_file):
13932 Read color file from absolute filename (bug#8250).
13933
f2b726e6
JB
139342011-03-19 Juanma Barranquero <lekktu@gmail.com>
13935
13936 * makefile.w32-in: Update dependencies.
13937
09f6ff02
EZ
139382011-03-17 Eli Zaretskii <eliz@gnu.org>
13939
13940 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13941
29a6015a
PE
139422011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13943
a3a6c54e
PE
13944 Fix more problems found by GCC 4.5.2's static checks.
13945
b766f867
PE
13946 * process.c (make_serial_process_unwind, send_process_trap):
13947 (sigchld_handler): Now static.
13948
be02381c
PE
13949 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13950 That way, the code declares only the vars that it needs.
13951 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13952 * s/cygwin.h (PTY_ITERATION): Likewise.
13953 * s/darwin.h (PTY_ITERATION): Likewise.
13954 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13955
57048744
PE
13956 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13957 * process.c (allocate_pty): Don't declare stb unless it's needed.
13958
7914961c 13959 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13960 (CONSTANTLIM): Remove; unused.
13961 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13962 Define only if needed.
7914961c 13963
b3967b18
PE
13964 * unexelf.c (unexec): Name an expression,
13965 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13966 Use a different way to cause a compilation error if anyone uses
13967 n rather than nn, a way that does not involve shadowing.
73366a00 13968 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13969
29a6015a
PE
13970 * deps.mk (unexalpha.o): Remove; unused.
13971
43cfc33e 13972 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13973 * unexec.h: New file.
ce701a33
PE
13974 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13975 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13976 Depend on unexec.h.
13977 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13978 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13979 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13980 Change as necessary to match prototype in unexec.h.
ce701a33 13981
01f44d5a
PE
13982 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13983 shadowing.
4f63c6bb 13984 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13985
a6670b0b
PE
13986 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13987 Rename locals to avoid shadowing.
13988
cef2010d 13989 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13990 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13991
d4d7173a
PE
13992 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13993
f08b802a
PE
13994 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13995 warning when compiling print.c.
13996
3ddb0639
PE
13997 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13998 instead of using an uninitialized var.
5ad03b97 13999 (font_sort_entities): Mark var as initialized.
3ddb0639 14000
170a2692
PE
14001 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14002
e663c700
PE
14003 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14004 pointers to constants.
89bc529a 14005 (font_parse_fcname): Remove unused vars.
7b81e2d0 14006 (font_delete_unmatched): Now static.
ea838e10 14007 (font_get_spec): Remove; unused.
13a547c6
PE
14008 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14009 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14010 Rename or move locals to avoid shadowing.
e663c700 14011
2a80c887 14012 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14013 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14014
1384fa33 14015 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14016 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14017
8b2c52e9
PE
14018 * alloc.c (mark_backtrace): Move decl from here ...
14019 * lisp.h: ... to here, so that it can be checked.
14020
475545b5 14021 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14022 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14023 (lisp_indirect_variable): Name an expression,
14024 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14025 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14026
b1349114 14027 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14028 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14029 Use const pointer when appropriate.
b1349114 14030
a2928364
PE
14031 * lisp.h (get_system_name, get_operating_system_release):
14032 Move decls here, to check interfaces.
14033 * process.c (get_operating_system_release): Move decl to lisp.h.
14034 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14035 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14036 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14037 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14038 (Fformat_time_string, Fencode_time, Finsert_char):
14039 (Ftranslate_region_internal, Fformat):
14040 Rename or remove local vars to avoid shadowing.
9710023e 14041 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14042
a415e694
PE
14043 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14044 avoid shadowing.
14045
8ef4622d
PE
14046 * lisp.h (eassert): Check that the argument compiles, even if
14047 ENABLE_CHECKING is not defined.
14048
946f9a5b
PE
14049 * data.c (Findirect_variable): Name an expression, to avoid
14050 gcc -Wbad-function-cast warning.
112396d6 14051 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14052 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14053 (Fmake_variable_buffer_local, Fmake_local_variable):
14054 Mark variables as initialized.
52746918 14055 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14056
e5aab7e7 14057 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14058 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14059 Rename locals to avoid shadowing.
dff45157
PE
14060 (mark_stack): Move local variables into the #ifdef region where
14061 they're used.
7bc26fdb
PE
14062 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14063 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14064 needed otherwise.
14065 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14066 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14067 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14068
e5aab7e7
PE
14069 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14070 avoids undefined behavior in theory.
14071
4da60324
PE
14072 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14073
88043301
PE
14074 Use functions, not macros, for up- and down-casing (Bug#8254).
14075 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14076 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14077 to use the following functions instead of these macros.
14078 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14079 EMACS_INT, since callers assume the returned value fits in int.
14080 (upcase1): Likewise, for UPCASE_TABLE.
14081 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14082 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14083 the race-condition problem in the old DOWNCASE.
88043301 14084
19ed5445
PE
14085 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14086 Rename locals to avoid shadowing.
14087 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14088 (regex_compile, re_search_2, re_match_2_internal):
14089 Remove unused local vars.
952db0d7
PE
14090 (FREE_VAR): Rewrite so as not to use empty "else",
14091 which gcc can warn about.
da053e48 14092 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14093 (RETALLOC_IF): Define only if needed.
14094 (WORDCHAR_P): Likewise. This one is never needed, but is used
14095 only in a comment talking about a compiler bug, so put inside
14096 the #if 0 of that comment.
14097 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14098 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14099 Remove; unused.
19ed5445 14100
1f3561e4 14101 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14102 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14103 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14104
ded6f8f7
PE
14105 * search.c (simple_search): Remove unused var.
14106
dbd37a95
PE
14107 * dired.c (compile_pattern): Move decl from here ...
14108 * lisp.h: ... to here, so that it can be checked.
14109 (struct re_registers): New forward decl.
14110
7e47afad
PE
14111 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14112
85f24f61
PE
14113 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14114 All uses changed.
14115 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14116 Rename locals to avoid shadowing.
5671df8f 14117 (Fvertical_motion): Mark locals as initialized.
85f24f61 14118
181aa2be 14119 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14120 (casify_region): Mark local as initialized.
181aa2be 14121
930d429c
PE
14122 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14123
7082eac6
PE
14124 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14125 New macros, so that the caller can use some names other than
14126 gcpro1, gcpro2, etc.
14127 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14128 of the new macros.
14129 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14130 argument, for consistency with GCPRO2_VAR, etc: it is now the
14131 prefix of the variable, not the variable itself. All uses
14132 changed.
38b2c076
PE
14133 * dired.c (directory_files_internal, file_name_completion):
14134 Rename locals to avoid shadowing.
14135
15206ed9
PE
14136 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14137 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14138 dired.c's scmp function, had undefined behavior.
14139 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14140 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14141 * buffer.h: ... to here, because these macros use current_buffer,
14142 and the new implementation with inline functions needs to have
14143 current_buffer in scope now, rather than later when the macros
14144 are used.
14145 (downcase, upcase1): New static inline functions.
14146 (DOWNCASE, UPCASE1): Reimplement using these functions.
14147 This avoids undefined behavior in expressions like
14148 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14149 from race conditions in accessing the global variables
14150 case_temp1 and case_temp2.
14151 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14152 * lisp.h (case_temp1, case_temp2): Remove their decls.
14153 * character.h (ASCII_CHAR_P): Move from here ...
14154 * lisp.h: ... to here, so that the inline functions mentioned
14155 above can use them.
14156
4a6bea26
PE
14157 * dired.c (directory_files_internal_unwind): Now static.
14158
f14b7e14
PE
14159 * fileio.c (file_name_as_directory, directory_file_name):
14160 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14161 Now static.
2893f146
PE
14162 (file_name_as_directory): Use const pointers when appropriate.
14163 (Fexpand_file_name): Likewise. In particular, newdir might
14164 point at constant storage, so make it a const pointer.
fd4ead52 14165 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14166 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14167 signedness issues.
f839df0c
PE
14168 (Fset_file_times, Finsert_file_contents, auto_save_error):
14169 Rename locals to avoid shadowing.
f14b7e14 14170
5716756e 14171 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14172 (Ftry_completion, Fall_completions): Rename or remove locals
14173 to avoid shadowing.
5716756e 14174
b4c3046a
PE
14175 * marker.c (bytepos_to_charpos): Remove; unused.
14176
b45db522
PE
14177 * lisp.h (verify_bytepos, count_markers): New decls,
14178 so that gcc does not warn that these functions aren't declared.
14179
85876d07
PE
14180 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14181 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14182 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14183 (copy_text): Remove unused local var.
85876d07 14184
03d78a21 14185 * filelock.c (within_one_second): Now static.
b3dd38ab 14186 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14187
5df8f01b
PE
14188 * buffer.c (fix_overlays_before): Mark locals as initialized.
14189 (fix_start_end_in_overlays): Likewise. This function should be
14190 simplified by using pointers-to-pointers, but that's a different
14191 matter.
b1d876f1 14192 (switch_to_buffer_1): Now static.
8f54f30a
PE
14193 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14194 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14195
a70072c9 14196 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14197 Fix pointer signedness issue.
edced198
PE
14198 (sys_subshell): Mark local as volatile if checking for lint,
14199 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14200 (MAXPATHLEN): Define only if needed.
a70072c9 14201
a0977c44
PE
14202 * process.c (serial_open, serial_configure): Move decls from here ...
14203 * systty.h: ... to here, so that they can be checked.
14204
a884fdcc
PE
14205 * fns.c (get_random, seed_random): Move extern decls from here ...
14206 * lisp.h: ... to here, so that they can be checked.
14207
604efe86 14208 * sysdep.c (reset_io): Now static.
b8950c94 14209 (wait_for_termination_signal): Remove; unused.
604efe86 14210
38fc62d9
PE
14211 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14212 (copy_keymap_item, append_key, push_text_char_description):
14213 Now static.
1004a21a 14214 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14215 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14216 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14217 (describe_map_tree):
14218 Rename locals to avoid shadowing.
38fc62d9 14219
2f2650da
PE
14220 * keyboard.c: Declare functions static if they are not used elsewhere.
14221 (echo_char, echo_dash, cmd_error, top_level_2):
14222 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14223 (read_char, kbd_buffer_get_event, make_lispy_position):
14224 (make_lispy_event, make_lispy_movement, apply_modifiers):
14225 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14226 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14227 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14228 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14229 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14230
a053e86c 14231 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14232 (mark_kboards): Move decl here ...
14233 * alloc.c (mark_kboards): ... from here.
a053e86c 14234
4752793e
PE
14235 * lisp.h (force_auto_save_soon): New decl.
14236
74f10ca7 14237 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14238 (DEFINE_DUMMY_FUNCTION): New macro.
14239 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14240 Use it.
c03cd23f
PE
14241 (main): Add casts to avoid warnings
14242 if GCC considers string literals to be constants.
74f10ca7 14243
022e70d4
PE
14244 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14245
59d6fe83
PE
14246 * dbusbind.c: Pointer signedness fixes.
14247 (xd_signature, xd_append_arg, xd_initialize):
14248 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14249 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14250 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14251 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14252
78320123
PE
14253 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14254 if GCC considers string literals to be constants.
49cebcca 14255 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14256
35ac2a97
SM
142572011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14258
fb103ca9
SM
14259 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14260 (print_preprocess, print_object): New macro to fix last change.
14261
35ac2a97
SM
14262 * print.c (print_preprocess): Don't forget font objects.
14263
62973b41
JB
142642011-03-16 Juanma Barranquero <lekktu@gmail.com>
14265
14266 * emacs.c (USAGE3): Doc fixes.
14267
0e48bb22
AS
142682011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14269
14270 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14271 structure.
14272
7684e57b
JB
142732011-03-14 Juanma Barranquero <lekktu@gmail.com>
14274
14275 * lisp.h (VWindow_system, Qfile_name_history):
14276 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14277 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14278 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14279
14280 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14281 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14282
14283 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14284 * w32console.c (detect_input_pending, read_input_pending)
14285 (encode_terminal_code):
14286 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14287 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14288 (w32_system_caret_y, Qfile_name_history):
14289 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14290 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14291 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14292 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14293 * w32proc.c (Qlocal, report_file_error):
14294 * w32term.c (Vwindow_system, updating_frame):
14295 * w32uniscribe.c (initialized, uniscribe_font_driver):
14296 Remove unneeded extern declarations.
14297
2aa46d6c
CY
142982011-03-14 Chong Yidong <cyd@stupidchicken.com>
14299
c96bbc66 14300 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14301
cffc6f3b
CY
143022011-03-13 Chong Yidong <cyd@stupidchicken.com>
14303
14304 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14305 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14306 These macros can no longer be used for assignment.
14307
44f230aa
SM
14308 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14309 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14310 (record_buffer_markers, fetch_buffer_markers): New functions for
14311 recording and fetching special buffer markers.
14312 (set_buffer_internal_1, set_buffer_temp): Use them.
14313
14314 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14315
14316 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14317
14318 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14319 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14320
14321 * xdisp.c (hscroll_window_tree):
14322 (reconsider_clip_changes): Use PT instead of BUF_PT.
14323
d251f04b
EZ
143242011-03-13 Eli Zaretskii <eliz@gnu.org>
14325
14326 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14327 $(EMACS_ROOT)/lib/intprops.h.
14328
f0c77cd1
PE
143292011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14330
3eca4629
PE
14331 Fix more problems found by GCC 4.5.2's static checks.
14332
7c86ee98
PE
14333 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14334 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14335 (xg_free_frame_widgets): Make it clear that a local variable is
14336 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14337 (gdk_window_get_screen): Make it clear that this macro is needed
14338 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14339 (int_gtk_range_get_value): New function, which avoids a diagnostic
14340 from gcc -Wbad-function-cast.
14341 (xg_set_toolkit_scroll_bar_thumb): Use it.
14342 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14343 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14344 (get_utf8_string, xg_get_file_with_chooser):
14345 Rename locals to avoid shadowing.
14346 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14347
41729b81
PE
14348 * xgselect.c (xg_select): Remove unused var.
14349
f0c77cd1
PE
14350 * image.c (four_corners_best): Mark locals as initialized.
14351 (gif_load): Initialize transparent_p to zero (Bug#8238).
14352 Mark another local as initialized.
ec6cf4c6 14353 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14354
ce0ad53d 14355 * image.c (clear_image_cache): Now static.
d5d5a617 14356 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14357 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14358 (x_edge_detection): Remove unnecessary cast that
14359 gcc -Wbad-function-cast diagnoses.
2037898d 14360 (gif_load): Fix pointer signedness.
6ae141d6
PE
14361 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14362 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14363
33383987 143642011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14365
d32df629
PE
14366 Improve quality of tests for time stamp overflow.
14367 For example, without this patch (encode-time 0 0 0 1 1
14368 1152921504606846976) returns the obviously-bogus value (-948597
14369 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14370 reports time overflow. See
14371 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14372 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14373 * editfns.c: Include limits.h and intprops.h.
14374 (TIME_T_MIN, TIME_T_MAX): New macros.
14375 (time_overflow): Move earlier, to before first use.
14376 (hi_time, lo_time): New functions, for an accurate test for
14377 out-of-range times.
14378 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14379 (Fget_internal_run_time): Don't assume time_t fits in int.
14380 (make_time): Use list2 instead of Fcons twice.
14381 (Fdecode_time): More accurate test for out-of-range times.
14382 (check_tm_member): New function.
14383 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14384 (lisp_time_argument): Don't rely on undefined left-shift and
14385 right-shift behavior when checking for time stamp overflow.
8be6f318 14386
fe31d94c
PE
14387 * editfns.c (time_overflow): New function, refactoring common code.
14388 (Fformat_time_string, Fdecode_time, Fencode_time):
14389 (Fcurrent_time_string): Use it.
14390
8be6f318
PE
14391 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14392 * dired.c (make_time): Move to ...
14393 * editfns.c (make_time): ... here.
14394 * systime.h: Note the move.
14395
09d9db2c 143962011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14397
126bc0dc
YM
14398 * fringe.c (update_window_fringes): Remove unused variables.
14399
c47cbdfd
YM
14400 * unexmacosx.c (copy_data_segment): Also copy __got section.
14401 (Bug#8223)
14402
7ac80be9
EZ
144032011-03-12 Eli Zaretskii <eliz@gnu.org>
14404
c96bbc66 14405 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14406 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14407 Constify `char *' arguments and their references according to
14408 prototypes in tparam.h.
14409
ecb0f94d 14410 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14411
7ac80be9
EZ
14412 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14413 Adapt all references accordingly.
14414
14415 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14416
ef1fd07e
TT
144172011-03-11 Tom Tromey <tromey@redhat.com>
14418
14419 * buffer.c (syms_of_buffer): Remove obsolete comment.
14420
7ef4b50c
EZ
144212011-03-11 Eli Zaretskii <eliz@gnu.org>
14422
14423 * termhooks.h (encode_terminal_code): Declare prototype.
14424
14425 * msdos.c (encode_terminal_code): Don't declare prototype.
14426
14427 * term.c (encode_terminal_code): Now external again, used by
14428 w32console.c and msdos.c.
14429
44f230aa
SM
14430 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14431 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14432
4b1ec863 144332011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14434
1714f52b 14435 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14436
4b1ec863
PE
14437 * fringe.c (update_window_fringes): Mark locals as initialized
14438 (Bug#8227).
14439 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14440
524c7aa6
PE
14441 * alloc.c (mark_fringe_data): Move decl from here ...
14442 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14443 to check its interface.
14444 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14445
a5c0af81 14446 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14447 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14448 (fontset_font): Mark local as initialized.
a9a06e0b 14449 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14450
b4716021
PE
14451 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14452
811e9bac 14453 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14454 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14455 (x_own_selection, Fx_disown_selection_internal): Rename locals
14456 to avoid shadowing.
14457 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14458
7e3ab302
PE
14459 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14460 so that the caller can use some name other than gcpro1.
14461 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14462 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14463 (Fx_backspace_delete_keys_p):
14464 Use them to avoid shadowing, and rename vars to avoid shadowing.
14465 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14466 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14467 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14468 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14469 Remove unused locals.
7e3ab302
PE
14470 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14471 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14472 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14473 macros.
f78faa98 14474
e2b13473
PE
14475 * xterm.h (x_mouse_leave): New decl.
14476
77f23912
PE
14477 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14478 Remove unused functions.
cdf4ba58
PE
14479 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14480 (x_calc_absolute_position): Now static.
7411c686 14481 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14482 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14483 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14484 unless they are used.
38d0b34a
PE
14485 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14486 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14487 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14488 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14489 (x_error_catcher, x_connection_closed, x_error_handler):
14490 (x_error_quitter, xembed_send_message, x_iconify_frame):
14491 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14492 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14493 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14494
44f230aa
SM
14495 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14496 Rename or move locals to avoid shadowing.
6b463e58 14497 (tty_defined_color, merge_face_heights): Now static.
5967d051 14498 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14499 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14500 does not deduce is never used uninitialized.
73719eba
PE
14501 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14502 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14503
426994c3 14504 * terminal.c (store_terminal_param): Now static.
5489860b 14505
032f1620 14506 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14507 (set_frame_menubar): Remove unused local.
d4323972 14508 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14509 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14510 since they might point to immutable storage.
281585b0
PE
14511 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14512 since it's unused otherwise.
032f1620 14513
367c19e5 14514 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14515 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14516 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14517 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14518 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14519 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14520 does not deduce are never used uninitialized.
70739cbe 14521
07b48fa9
PE
14522 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14523
8868a238 14524 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14525 * window.c (window_loop, size_window):
14526 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14527
7e5cf297 14528 * window.c (display_buffer): Now static.
d6550a9f
PE
14529 (size_window): Mark variables that gcc -Wuninitialized
14530 does not deduce are never used uninitialized.
a586633d
PE
14531 * window.h (check_all_windows): New decl, to forestall
14532 gcc -Wmissing-prototypes diagnostic.
5b555da1 14533 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14534
f6095868
PE
14535 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14536 shadowing.
14537 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14538 Include <limits.h>.
14539 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14540 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14541 (load_charset_map): Mark variables that gcc -Wuninitialized
14542 does not deduce are never used uninitialized.
53df7c11 14543 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14544
f38b440c
PE
14545 * coding.c (coding_set_source, coding_set_destination):
14546 Use "else { /* comment */ }" rather than "else /* comment */;"
14547 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14548 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14549 a block, when the outer 'i' will do.
14550 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14551 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14552 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14553 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14554 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14555 Rename locals to avoid shadowing.
14556 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14557 * coding.c (emacs_mule_char, encode_invocation_designation):
14558 Now static, since they're not used elsewhere.
413bb2db 14559 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14560 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14561 (decode_coding_emacs_mule): Mark variables that gcc
14562 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14563 (detect_coding_iso_2022): Initialize a local variable that might
14564 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14565 this initialization is needed. (Bug#8211)
5f58e762
PE
14566 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14567 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14568 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14569 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14570 Remove unused macros.
f38b440c 14571
232b38b9 14572 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14573 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14574 * character.c (string_count_byte8): Likewise.
232b38b9 14575
fb90da1b
PE
14576 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14577 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14578
fb93dbc2
PE
14579 * chartab.c (copy_sub_char_table): Now static, since it's not used
14580 elsewhere.
5c156ace
PE
14581 (sub_char_table_ref_and_range, char_table_ref_and_range):
14582 Rename locals to avoid shadowing.
bbcd0949 14583 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14584
7d3b3862 14585 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14586 (BIDI_BOB): Remove unused macro.
7d3b3862 14587
6be7d3da
PE
14588 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14589 deduce are never used uninitialized.
c2ed9c8b 14590 * term.c (encode_terminal_code): Likewise.
6be7d3da 14591
75f8807f 14592 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14593
50938595
PE
14594 * tparam.h: New file.
14595 * term.c, tparam.h: Include it.
14596 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14597 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14598 Move these decls to tparam.h, and make them agree with what
14599 is actually in tparam.c. The previous trick of using incompatible
14600 decls in different modules does not conform to the C standard.
14601 All callers of tparam changed to use tparam's actual API.
14602 * tparam.c (tparam1, tparam, tgoto):
14603 Use const pointers where appropriate.
14604
fbceeba2
PE
14605 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14606 * cm.h (struct cm): Likewise.
14607 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14608 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14609 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14610 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14611 (turn_on_face, init_tty): Likewise.
14612 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14613
7f3f1250
PE
14614 * term.c (term_mouse_position): Rename local to avoid shadowing.
14615
e6ca6543
PE
14616 * alloc.c (mark_ttys): Move decl from here ...
14617 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14618
c40f8d15
AS
146192011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14620
14621 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14622
cfe0661d
JB
146232011-03-09 Juanma Barranquero <lekktu@gmail.com>
14624
14625 * search.c (compile_pattern_1): Remove argument regp, unused since
14626 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14627 (compile_pattern): Don't pass it.
14628
0afb4571
J
146292011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14630
14631 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14632 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14633 for ! HAVE_GTK3.
14634 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14635
14636 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14637
14638 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14639 gdk_window_get_screen, gdk_window_get_geometry,
14640 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14641 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14642 (xg_get_pixbuf_from_pixmap): New function.
14643 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14644 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14645 Call xg_get_pixbuf_from_pixmap instead of
14646 gdk_pixbuf_get_from_drawable.
14647 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14648 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14649 (xg_check_special_colors): Use GtkStyleContext and its functions
14650 for HAVE_GTK3.
14651 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14652 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14653 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14654 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14655 Call gtk_widget_get_preferred_size.
0afb4571
J
14656 (xg_frame_resized): gdk_window_get_geometry only takes 5
14657 parameters.
44f230aa
SM
14658 (xg_win_to_widget, xg_event_is_for_menubar):
14659 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14660 (xg_set_widget_bg): New function.
14661 (delete_cb): New function.
895009e1 14662 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14663 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14664 (xg_set_background_color): Call xg_set_widget_bg.
14665 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14666 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14667 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14668 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14669 if ! HAVE_GTK3.
14670 (update_frame_tool_bar): Call gtk_widget_hide.
14671 (xg_initialize): Use GDK_KEY_g.
14672
14673 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14674 if ! HAVE_GTK3
14675 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14676
14677 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14678 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14679 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14680
1c2cc4ef
JB
146812011-03-08 Juanma Barranquero <lekktu@gmail.com>
14682
14683 * w32xfns.c (select_palette): Check success of RealizePalette against
14684 GDI_ERROR, not zero.
14685
33383987 14686See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14687
14688;; Local Variables:
14689;; coding: utf-8
aac0c6e3
MR
14690;; End:
14691
2f097256 14692 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14693
14694 This file is part of GNU Emacs.
14695
14696 GNU Emacs is free software: you can redistribute it and/or modify
14697 it under the terms of the GNU General Public License as published by
14698 the Free Software Foundation, either version 3 of the License, or
14699 (at your option) any later version.
14700
14701 GNU Emacs is distributed in the hope that it will be useful,
14702 but WITHOUT ANY WARRANTY; without even the implied warranty of
14703 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14704 GNU General Public License for more details.
14705
14706 You should have received a copy of the GNU General Public License
14707 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.