Last change fixes Bug#12069
[bpt/emacs.git] / src / ChangeLog
CommitLineData
32bcadb4
JD
12012-08-11 Jan Djärv <jan.h.d@swipnet.se>
2
3d29b2ce
JD
3 * nsterm.m (not_in_argv): New function.
4 (application:openFile, application:openTempFile:):
5 (application:openFileWithoutUI:, application:openFiles:): Open file
6 if not_in_argv returns non-zero (bug#12171).
7
32bcadb4
JD
8 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
9 (gtk_font_chooser_set_font, gtk_font_chooser_get_font): Define
10 for Gtk+ versions less than 3.2.
11 (xg_get_font_name): Use those functions/macros here.
12 Reported by Frans Oilinki <moilinki@gmail.com>.
13
9ff9402d 142012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
15
16 * unexmacosx.c (copy_data_segment): Copy initialized data in
17 statically linked libraries from input file rather than memory.
18
db74a5fc
YM
19 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
20 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
21 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
22
25e65510
GM
232012-08-10 Glenn Morris <rgm@gnu.org>
24
25 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
26 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
27
7961135c
DA
282012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
29
30 Fix last change to allow compilation with low optimization levels.
31 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
32 Reported by Jan Djärv <jan.h.d@swipnet.se>.
33
42b3a444
DA
342012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
35
36 Use common inline syntax in intervals.h.
37 * intervals.h (INTERVALS_INLINE): New macro.
38 Change all users from LISP_INLINE.
39
9fb0c957
DA
402012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
41
42 Define Qnone once for all platforms.
43 * frame.c (Qnone): Define here.
44 (syms_of_frame): DEFSYM it.
45 * lisp.h (Qnone): New declaration.
46 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
47 * xfns.c: Remove duplication. Adjust users.
48
65e8ee52
DA
492012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
50
51 Remove unused macros from intervals.h.
52 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
53 * intervals.c: Adjust comment.
54
9b855fd6
EZ
552012-08-10 Eli Zaretskii <eliz@gnu.org>
56
57 * w32fns.c <w32_unicode_gui>: New static variable.
58 (globals_of_w32fns): Initialize it according to os_subtype.
59 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
60 testing os_subtype.
61
39cb9e56 622012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
63 Eli Zaretskii <eliz@gnu.org>
64
65 Fix bug #10299 with Unicode characters sent by customized
66 keyboards created by MSKLC.
67 * w32fns.c (INIT_WINDOW_CLASS): New macro.
68 (w32_init_class): Use it to initialize the Emacs class with either
69 ANSI or Unicode API calls.
70 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
71 later.
72 (w32_wnd_proc): If the character code sent by WM_CHAR or
73 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
74 original message. Call DefWindowProcW on NT and later.
75
9374581a
GM
762012-08-10 Glenn Morris <rgm@gnu.org>
77
4b94e8cf
GM
78 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
79
9374581a
GM
80 * lisp.h (DIRECTORY_SEP): Let configure set it.
81
a2752828
DA
822012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
83
84 Use TSET for write access to Lisp_Object slots of struct terminal.
85 * termhooks.h (TSET): New macro.
86 * coding.c, terminal.c, xselect.c: Adjust users.
87
cc92c454
SM
882012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
89
90 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
91 the failing expression, include them in the error message.
92 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
93 * lisp.h (internal_condition_case_n): Update declaration.
94
4cb3e6b3
DA
952012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
96
97 Inline functions to examine and change buffer overlays.
98 * buffer.c (unchain_both): New function.
99 * buffer.h (buffer_get_overlays, buffer_set_overlays):
100 (buffer_has_overlays): New function.
101 (enum overlay_type): New enum.
102 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
103 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
104
8707c1e5
DA
1052012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
106
107 Inline functions to examine and change buffer intervals.
108 * alloc.c (mark_interval_tree): Remove.
109 (MARK_INTERVAL_TREE): Simplify.
110 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
111 * intervals.c (buffer_balance_intervals): New function.
112 (graft_intervals_into_buffer): Adjust indentation.
113 (set_intervals_multibyte): Simplify.
114 * buffer.h (BUF_INTERVALS): Remove.
115 (buffer_get_intervals, buffer_set_intervals): New function.
116 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
117 * intervals.c, textprop.c: Adjust users.
118
ad8c997f
DA
1192012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
120
121 Inline functions to examine and change string intervals.
122 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
123 (string_get_intervals, string_set_intervals): New function.
124 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
125 * lread.c, print.c, textprop.c: Adjust users.
126
32ac3a6b
GM
1272012-08-08 Glenn Morris <rgm@gnu.org>
128
129 * lisp.mk (lisp): Remove language/persian.elc.
130
77c7bcb1
DA
1312012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
132
133 Cleanup intervals.
134 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
135 (NULL_INTERVAL_P): Likewise. Adjust users.
136 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P): Adjust
137 comment. Move under #if 0.
138 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
139 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
140
9c08a8d4
DA
1412012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
142
143 Check total length of intervals with eassert.
144 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
145 * intervals.c: Change all users to eassert.
146
26d16b35
EZ
1472012-08-07 Eli Zaretskii <eliz@gnu.org>
148
149 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist): Rename
150 fields to match removal of FGET and WGET and disuse of
151 INTERNAL_FIELD in Lisp_Cons.
152
c644523b
DA
1532012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
154
155 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
156 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
157 name since all xname users are fixed long time ago. Do not
158 use INTERNAL_FIELD.
159 (set_symbol_name, set_symbol_function, set_symbol_plist):
160 (set_symbol_next, set_overlay_plist): New function.
161 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
162 (struct Lisp_Overlay): Likewise.
163 (CVAR, MVAR, SVAR): Remove.
164 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
165 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
166 * xterm.c: Adjust users.
167 * .gdbinit: Change to use name field of struct Lisp_Symbol
168 where appropriate.
169
6a3d20cc
DA
1702012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
171
172 Basic functions to set Lisp_Object and pointer slots of intervals.
173 * intervals.h (interval_set_parent, interval_set_object):
174 (interval_set_left, interval_set_right, interval_set_plist):
175 (interval_copy_parent): New function.
176 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
177 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE): Adjust
178 indentation.
179 (INTERVAL_SIZE): Remove. Adjust users.
180 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
181
4d2b044c
DA
1822012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
183
184 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
185 * process.h (PGET): Remove.
186 (struct Lisp_Process): Do not use INTERNAL_FIELD.
187 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
188
d3d50620
DA
1892012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
190
191 Drop WGET and revert read access to Lisp_Objects slots of struct window.
192 * window.h (WGET): Remove.
193 (struct window): Do not use INTERNAL_FIELD.
194 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
195 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
196 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
197 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
198 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
199 Adjust users.
200
d10a51dc
CY
2012012-08-07 Chong Yidong <cyd@gnu.org>
202
203 * window.c (Fwindow_edges, Fwindow_pixel_edges)
204 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
205 (Fdelete_window_internal): Signal an error if the window is not on
206 a live frame (Bug#12025).
207
e69b0960
DA
2082012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
209
210 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
211 * frame.h (FGET): Remove.
212 (struct frame): Do not use INTERNAL_FIELD.
213 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
214 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
215 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
216 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
217
25a20a3a
JB
2182012-08-06 Juanma Barranquero <lekktu@gmail.com>
219
220 * w32.c: Silence compiler warnings.
221 (map_w32_filename): Remove unused variable `is_fat'.
222 (chase_symlinks): Add parentheses around expression.
223
1c6f11f4
GM
2242012-08-06 Glenn Morris <rgm@gnu.org>
225
1db4583a
GM
226 * sysdep.c: Respect BROKEN_GETWD.
227
1c6f11f4
GM
228 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
229 Let configure handle it.
230 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
231
2b90362b
DA
2322012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
233
234 Use GCALIGNMENT where appropriate.
235 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
236 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
237 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
238
5f50daf2
EZ
2392012-08-06 Eli Zaretskii <eliz@gnu.org>
240
241 * w32menu.c (set_frame_menubar, initialize_frame_menubar): Don't
242 use FRAME_MENU_BAR_ITEMS as an lvalue.
243
cbcc7007
SM
2442012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
245
246 * buffer.h (struct buffer): Revert `indirections' to a simple int;
247 that should be sufficient for everyone.
248
4d365fa4
JD
2492012-08-06 Jan Djärv <jan.h.d@swipnet.se>
250
251 * keyboard.c (timer_check_2): Add break so timer_check returns next
252 timeout.
253
dd86bd82
DA
2542012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
255
256 Fix Windows build errors introduced after converting to WGET and WSET.
257 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
258 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
259
054e1668
JD
2602012-08-06 Jan Djärv <jan.h.d@swipnet.se>
261
262 * nsterm.m (ns_frame_rehighlight): Use FSET.
263
264 * nsmenu.m (ns_update_menubar): Use FSET.
265
21238f11
DA
2662012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
267
268 Separate read and write access to Lisp_Object slots of Lisp_Process.
269 * process.h (PGET, PSET): New macros similar to AREF and ASET.
270 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
271
077288cf
DA
2722012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
273
274 Separate read and write access to Lisp_Object slots of struct window.
275 * window.h (WGET, WSET): New macros similar to AREF and ASET.
276 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
277 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
278 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
279 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
280 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
281 Adjust users.
282
71688bd7
DA
2832012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
284
285 Fix Windows build errors introduced after converting to FGET and FSET.
286 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
287 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
288 (w32_judge_scroll_bars): Change to use FSET.
289 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
290
f99bac93
DA
2912012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
292
293 Fix replacement typo.
294 * window.c (replace_window): Set root_window instead of
295 selected_window. This fixes a total window subsystem
296 malfunction reported by Bastien Guerry <bzg@gnu.org>.
297
8c2a0f2d
GM
2982012-08-06 Glenn Morris <rgm@gnu.org>
299
300 * lisp.mk (lisp): Add language/persian.elc.
301
edd74c35
DA
3022012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
303
304 Separate read and write access to Lisp_Object slots of struct frame.
305 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
306 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
307 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
308 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
309 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
310
8671676c
AS
3112012-08-05 Andreas Schwab <schwab@linux-m68k.org>
312
313 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
314
663e2b3f
DA
3152012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
316
317 Generalize common compile-time constants.
318 * lisp.h (header_size, bool_header_size, word_size): Now here.
319 (struct Lisp_Vector): Add comment.
320 (struct Lisp_Bool_Vector): Move up to define handy constants.
321 (VECSIZE, PSEUDOVECSIZE): Simplify.
322 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
323 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
324 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
325 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
326 * xfont.c, xmenu.c: Use word_size where appropriate.
327
d32e47af
LM
3282012-08-05 Lawrence Mitchell <wence@gmx.li>
329
330 * search.c (Freplace_match): Treat \? in the replacement text
331 literally (Bug#8161).
332
e5d9c0d1
CY
3332012-08-05 Chong Yidong <cyd@gnu.org>
334
335 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
336 * frame.c (Vdelete_frame_functions):
337 * emacs.c (Vkill_emacs_hook): Doc fix.
338
8da0576b
EZ
3392012-08-04 Eli Zaretskii <eliz@gnu.org>
340
341 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
342 --with-x-toolkit=no builds.
343 Reported by Carsten Mattner <carstenmattner@gmail.com>.
344
02676e5d
CY
3452012-08-04 Chong Yidong <cyd@gnu.org>
346
347 * syntax.c (Fmodify_syntax_entry): Doc fix.
348
97147da9
EZ
3492012-08-04 Eli Zaretskii <eliz@gnu.org>
350
76151e2c
EZ
351 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
352 * w32.c (init_environment): Change the default values of many
353 environment variables in dflt_envvars[] to NULL, to avoid pushing
354 them into environment when they were not already defined. Remove
355 the code that deletes site-lisp subdirectories from the default
356 value of EMACSLOADPATH, as it is no longer needed.
357 (check_windows_init_file): Now external, not static. Use
358 Vload_path as is, without adding anything, as this function is now
359 called when Vload_path is already set up.
360
361 * w32.h (check_windows_init_file): Add prototype.
362
363 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
364 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
365 compatibility with Posix platforms.
366 (main): Move the call to check_windows_init_file to here from
367 w32.c.
368 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
369 any, in the DEFALT argument into the root of the Emacs build or
370 installation tree, as appropriate.
371
372 * callproc.c (init_callproc_1): Call decode_env_path instead of
373 doing its equivalent by hand.
374 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
375 the code that sets Vexec_path run on MS-Windows.
376
377 * lread.c (init_lread): Add comments to #ifdef's.
378
97147da9
EZ
379 * msdos.c (dos_set_window_size, IT_update_begin)
380 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
381 instead of direct references.
382
185ee146
PE
3832012-08-04 Paul Eggert <eggert@cs.ucla.edu>
384
385 Export DEFAULT_REHASH_* to GDB.
386 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
387 Now constants, not macros.
388
8834c57a
PE
3892012-08-03 Paul Eggert <eggert@cs.ucla.edu>
390
98c6f1e3
PE
391 Remove unnecessary casts involving pointers.
392 These casts are no longer needed now that we assume C89 or later,
393 since they involve casting to or from void *.
394 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
395 (make_pure_float, make_pure_vector):
396 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
397 * macros.c (Fstart_kbd_macro):
398 * menu.c (find_and_return_menu_selection):
399 * minibuf.c (read_minibuf_noninteractive):
400 * sysdep.c (closedir):
401 * xdisp.c (x_produce_glyphs):
402 * xfaces.c (compare_fonts_by_sort_order):
403 * xfns.c (x_real_positions, select_visual):
404 * xselect.c (x_stop_queuing_selection_requests)
405 (x_get_window_property, x_get_window_property_as_lisp_data):
406 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
407 Remove unnecessary pointer casts.
408 * alloc.c (record_xmalloc): New function.
409 * lisp.h (record_xmalloc): New decl.
410 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
411 more like a function. This is because the pointer cast is not
412 needed. All uses changed.
413 * print.c (print_string, print_error_message): Avoid length recalc.
414
8834c57a
PE
415 Improve fix for macroexp crash with debugging (Bug#12118).
416 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
417 ARRAY_MARK_FLAG when checking subscripts, because ASET is
418 not supposed to be invoked from the garbage collector.
419 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
420 (gc_aset): New function, which is like ASET but can be
421 used in the garbage collector.
422 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
423 (set_hash_index): Use it instead of ASET.
424
6dad7178
EZ
4252012-08-03 Eli Zaretskii <eliz@gnu.org>
426
427 Support symlinks on latest versions of MS-Windows.
428 * w32.c: Include winioctl.h and aclapi.h.
429 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
430 (revert_to_self): Forward declarations of static functions.
431 <static BOOL g_b_init_get_security_info>:
432 <g_b_init_create_symbolic_link>: New static flags.
433 (globals_of_w32): Initialize them to zero.
434 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
435 (map_w32_filename): Improve commentary. Simplify switch.
436 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
437 headers (most versions of MinGW w32api don't).
438 (get_security_info, create_symbolic_link)
439 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
440 New functions.
441 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
442 in the argument file name.
443 (sys_access): Call unc_volume_file_attributes only if
444 GetFileAttributes fails with network-related error codes.
445 (sys_rename): Diagnose renaming of a symlink when the user doesn't
446 have the required privileges.
447 (get_file_security_desc_by_name): Renamed from
448 get_file_security_desc.
449 (stat_worker): New function, with most of the guts of 'stat', and
450 with addition of handling of symlinks and support for 'lstat'. If
451 possible, get file's attributes and security information by
452 handle, not by name. Produce S_IFLNK bit for symlinks, when
453 called from 'lstat'.
454 (stat, lstat): New functions, call 'stat_worker'.
455 (symlink, readlink, careadlinkat): Rewritten to create and resolve
456 symlinks when the underlying filesystem supports them.
457
f162bcc3
PE
4582012-08-02 Paul Eggert <eggert@cs.ucla.edu>
459
79ea6c20
PE
460 Fix macroexp crash on Windows with debugging (Bug#12118).
461 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
462 checking subscripts; problem introduced with the recent
463 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
464 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
465 since it's used in non-static inline functions now.
466
c0ce93fd
PE
467 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
468 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 469
f162bcc3
PE
470 Use C99-style 'extern inline' if available.
471 * buffer.h (BUFFER_INLINE):
472 * category.h (CATEGORY_INLINE):
473 * character.h (CHARACTER_INLINE):
474 * charset.h (CHARSET_INLINE):
475 * composite.h (COMPOSITE_INLINE):
476 * dispextern.h (DISPEXTERN_INLINE):
477 * lisp.h (LISP_INLINE):
478 * systime.h (SYSTIME_INLINE):
479 New macro, replacing 'static inline' in this header.
480 * buffer.h, category.h, character.h, charset.h, composite.h:
481 * dispextern.h, lisp.h, systime.h:
482 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
483 * alloc.c (LISP_INLINE):
484 * buffer.c (BUFFER_INLINE):
485 * category.c (CATEGORY_INLINE):
486 * character.c (CHARACTER_INLINE):
487 * charset.c (CHARSET_INLINE):
488 * composite.c (COMPOSITE_INLINE):
489 * dispnew.c (DISPEXTERN_INLINE):
490 * sysdep.c (SYSTIME_INLINE):
491 Define to EXTERN_INLINE, so that the corresponding functions
492 are compiled into code.
493 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
494 (INLINE_HEADER_END): New macros.
495 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
496 since it's used in non-static inline functions now.
a8333d03 497 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 498
837b365b
GM
4992012-08-02 Glenn Morris <rgm@gnu.org>
500
d66b744d
GM
501 * s/: Remove empty directory.
502
837b365b
GM
503 * s/ms-w32.h: Move to ../nt/inc.
504 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
505 Update for new ms-w32.h location.
506
13294f95
PE
5072012-08-02 Paul Eggert <eggert@cs.ucla.edu>
508
509 Port to Solaris 8.
510 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
511
90df0db3
GM
5122012-08-02 Glenn Morris <rgm@gnu.org>
513
514 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
515 hard-coding the path separator.
516
4939150c
PE
5172012-08-01 Paul Eggert <eggert@cs.ucla.edu>
518
519 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
520 This how ASET and AREF are supposed to work, and makes
521 it easier to think about future improvements. See
522 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
523 * charset.h (set_charset_attr): New function.
524 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
525 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
526 (aref_addr): New function. All uses of &AREF(...) changed.
527 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
528 (set_hash_index): New functions. All lvalue-style uses of
529 HASH_KEY etc. changed.
530 * keyboard.c (set_prop): New function. All lvalue-style uses
531 of PROP changed.
532
947b2afd
AA
5332012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
534
535 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
536 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
537 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
538 * nsfns.m (ns_set_name_as_filename): Likewise.
539 * nsmenu.m (ns_update_menubar): Likewise.
540 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
541
4f5d0325
EZ
5422012-08-01 Eli Zaretskii <eliz@gnu.org>
543
2008beae
EZ
544 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
545 Adapt to latest changes in field names of the corresponding Lisp
288479f6 546 objects.
2008beae 547
4f5d0325
EZ
548 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
549
fe3cc771
GM
5502012-08-01 Glenn Morris <rgm@gnu.org>
551
552 * s/msdos.h: Remove file.
553 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
554 * Makefile.in (S_FILE): Remove.
555 (config_h): Remove S_FILE.
556
c90acc54
JB
5572012-08-01 Juanma Barranquero <lekktu@gmail.com>
558
559 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
560 Remove; moved to nt/config.nt.
561
d8a05828
DA
5622012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
563
564 Use INTERNAL_FIELD for conses and overlays.
565 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
566 Remove obsolete comment.
567 (MVAR): New macro.
568 (struct Lisp_Overlay): Use INTERNAL_FIELD.
569 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
570
8271d590
DA
5712012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
572
573 Use INTERNAL_FIELD for symbols.
574 * lisp.h (SVAR): New macro. Adjust users.
575 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
576 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
577
3193acd2
DA
5782012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
579
580 Use INTERNAL_FIELD for processes.
581 * process.h (PVAR): New macro. Adjust style.
582 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
583 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
584
3a45383a
DA
5852012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
586
587 Use INTERNAL_FIELD for windows.
588 * window.h (WVAR): New macro.
589 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
590 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
591 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
592 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
593 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
594 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
595
c1dbc63c
PE
5962012-08-01 Paul Eggert <eggert@cs.ucla.edu>
597
598 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
599
5c0c0e8a
GM
6002012-08-01 Glenn Morris <rgm@gnu.org>
601
602 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
603 Move to configure.ac.
604
552a99b4
JB
6052012-08-01 Juanma Barranquero <lekktu@gmail.com>
606
607 * makefile.w32-in (CONFIG_H): Update dependencies.
608 (CONF_POST_H): New macro.
609
610 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
611
8d8e2dfe
GM
6122012-07-31 Glenn Morris <rgm@gnu.org>
613
bc96620a
GM
614 * Makefile.in (S_FILE): No longer set by configure.
615
476b1b2d
GM
616 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
617 is available.
618 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
619
b2c7a106
GM
620 * process.h (NULL_DEVICE):
621 * emacs.c (SEPCHAR):
622 * editfns.c (USER_FULL_NAME): Let configure set them.
623
d53d062a
GM
624 * s/README, s/template.h: Remove files.
625
4515017f
GM
626 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
627
8d8e2dfe
GM
628 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
629 Move to configure.ac.
630
5b20b3cc
EZ
6312012-07-31 Eli Zaretskii <eliz@gnu.org>
632
1e0afd9a
EZ
633 * .gdbinit (xframe): Adapt to introduction of FVAR and the
634 resulting renaming of 'struct frame' members.
635
5b20b3cc
EZ
636 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
637
638 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
639 after introduction of FVAR.
640
f1310128
JD
6412012-07-31 Jan Djärv <jan.h.d@swipnet.se>
642
79e721e0
JD
643 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
644
645 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
646 instead of compositeToPoint.
647 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
648
8d7c7eed 649 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 650
e34f7f79
DA
6512012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
652
653 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
654 * lisp.h (INTERNAL_FIELD): New macro.
655 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
656 (BVAR): Change to use INTERNAL_FIELD.
657 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
658 (KVAR): Change to use INTERNAL_FIELD.
659 * frame.h (FVAR): New macro.
660 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
661 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
662 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
663 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
664 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
665
c09bfb2f
DA
6662012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
667
668 Miscellaneous fixes for non-default X toolkits.
669 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
670 * xterm.c (x_frame_of_widget): Remove redundant prototype.
671 Move under #ifdef USE_LUCID.
672 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
673 definition and usage to avoid warnings.
674
14c114ae
JD
6752012-07-31 Jan Djärv <jan.h.d@swipnet.se>
676
677 * nsterm.m (openFiles): Fix previous checkin.
678
3bd21e82
PE
6792012-07-31 Paul Eggert <eggert@cs.ucla.edu>
680
681 * indent.c (compute_motion): Remove unused local.
682
c1529ded
GM
6832012-07-31 Glenn Morris <rgm@gnu.org>
684
400d5621
GM
685 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
686
268e2432
GM
687 * conf_post.h [USG5_4]:
688 Move remaining contents of s/usg5-4-common.h here.
689 * s/usg5-4-common.h: Remove file.
690
7552f3ee
GM
691 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
692 * s/irix6-5.h: Remove file.
693
6a381852
GM
694 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
695 * s/darwin.h: Remove file.
696
c1529ded
GM
697 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
698 * s/hpux10-20.h: Remove file, which is now empty.
699
b429a4ee
GM
7002012-07-30 Glenn Morris <rgm@gnu.org>
701
702 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
703 * Makefile.in (config_h): Add conf_post.h.
704 * makefile.w32-in (CONFIG_H): Add conf_post.h.
705
adff3182
JD
7062012-07-30 Jan Djärv <jan.h.d@swipnet.se>
707
708 * nsterm.m (ns_do_open_file): New variable.
b9031d69 709 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
710 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
711 files only if ns_do_open_file.
712
c32af1e4
PE
7132012-07-30 Paul Eggert <eggert@cs.ucla.edu>
714
7393bcbb
PE
715 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
716 This no-op macro hasn't been needed for many years.
717 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
718
c32af1e4
PE
719 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
720 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
721 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
722 gdb_make_enums_visible.
723 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
724 (DIRECTORY_SEP): Now a constant, not a macro.
725
302fc036
EZ
7262012-07-30 Eli Zaretskii <eliz@gnu.org>
727
728 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
729 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
730
731 * w32term.c <w32_keyboard_codepage>: Renamed from
732 keyboard_codepage and now external. All users changed.
733
734 * w32term.h: Add declaration of w32_keyboard_codepage.
735
736 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
737 the codepage to translate keys to Unicode. If this argument is
738 -1, use the value returned by GetConsoleCP. All callers changed.
739
88fb40b4
PE
7402012-07-30 Paul Eggert <eggert@cs.ucla.edu>
741
0aee6912
PE
742 Update .PHONY listings in makefiles.
743 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
744 bootstrap-clean, distclean, maintainer-clean, versioclean,
745 extraclean, frc.
746
88fb40b4
PE
747 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
748 This is a bit clearer. Fix some commentary typos.
749
0a763bd1
GM
7502012-07-30 Glenn Morris <rgm@gnu.org>
751
32bac6d6
GM
752 * s/netbsd.h: Let configure include signal.h if needed.
753 Remove file, which is now empty.
754
b65e7c46
GM
755 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
756 Let configure set them.
757 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
758 No more need to undefine.
0a763bd1 759
169304bd
AS
7602012-07-30 Andreas Schwab <schwab@linux-m68k.org>
761
762 * keymap.c (Fkey_description): Don't remove 0x80 bit from
763 non-single-byte char when adding meta modifier. (Bug#12090)
764
6cd7a139
DA
7652012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
766
767 Convert safe_call to use variable number of arguments.
768 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
769 (safe_call2): Fix comment.
770 * lisp.h (safe_call): Adjust prototype.
771 * coding.c (encode_coding_object): Change to use safe_call2.
772 * xfaces.c (merge_face_heights): Change to use safe_call1.
773
d34d6ffc
GM
7742012-07-30 Glenn Morris <rgm@gnu.org>
775
7b8a48e4 776 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 777 does that unconditionally. Remove file, which is now empty.
7b8a48e4 778
d34d6ffc
GM
779 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
780 Remove empty files.
781
03a660a6
PE
7822012-07-30 Paul Eggert <eggert@cs.ucla.edu>
783
784 Export to GDB most of lisp.h's remaining object-like macros.
785 * lisp.h (min, max): Move earlier, because they're used earlier now.
786 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
787 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
788 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
789 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
790 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
791 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
792 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
793 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
794 Now constants, for GDB. They need not be macros.
795 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
796 Now constants, for GDB, as well as macros, for static initializers.
797 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
798 Move to after the definition of struct Lisp_Char_Table,
799 since the former now needs that type defined.
800 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
801 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
802 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
803 New enums, for gdb_make_enums_visible.
804 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 805 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
806 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
807 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
808 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
809 enum maxargs, enum MAX_ALLOCA.
810 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
811 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
812 no longer needed, now that they are done in lisp.h.
813
e499d0ee
DA
8142012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
815
816 Cleanup string bytes checking.
817 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
818 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
819 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
820 (check_sblock, compact_small_strings): Simplify.
821
d5040d2d
PE
8222012-07-29 Paul Eggert <eggert@cs.ucla.edu>
823
824 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
825 These macros are confusing and no longer need to be defined, as
826 the enum values now suffice. All uses replaced with definiens.
827 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
828
7f259ae6
JB
8292012-07-29 Juanma Barranquero <lekktu@gmail.com>
830
831 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
832 ($(BLD)/w32console.$(O)): Update dependencies.
833
7e63e0c3
DA
8342012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
835
836 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
837 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
838 time. Adjust users.
839 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
840
ffd817eb
JD
8412012-07-29 Jan Djärv <jan.h.d@swipnet.se>
842
843 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
844 setting sitelisp (Bug#12010).
845
417a7a0e
EZ
8462012-07-29 Eli Zaretskii <eliz@gnu.org>
847
848 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
849
850 * w32heap.c (cache_system_info):
851 * w32.c (sys_rename):
852 * w32proc.c (find_child_console, sys_kill): All users changed.
853
387d4d92
PE
8542012-07-29 Paul Eggert <eggert@cs.ucla.edu>
855
856 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
857
55a6cca6
EZ
8582012-07-29 Eli Zaretskii <eliz@gnu.org>
859
860 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
861
dbcf001c
DA
8622012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
863
864 Cleanup statistics calculation in Fgarbage_collect.
865 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
866 zombies percentage calculation. Simplify elapsed time calculation.
867
e2688e4a
DA
8682012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
869
870 Generalize marker debugging code under MARKER_DEBUG and use eassert.
871 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
872 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
873 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
874 (replace_range, replace_range_2, del_range_2): Change to eassert.
875 * marker.c (byte_char_debug_check): Adjust style.
876
b46a6a83
PE
8772012-07-29 Paul Eggert <eggert@cs.ucla.edu>
878
879 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
880 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
881 long-ago-commented-out code that talks about "WIN32".
882 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
883 All uses changed.
884
e32a5799
PE
8852012-07-28 Paul Eggert <eggert@cs.ucla.edu>
886
887 Use Gnulib stdalign module (Bug#9772, Bug#9960).
888 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
889 Simplify by using alignof.
890 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
891 * lisp.h: Include <stdalign.h>.
892 (GCALIGNMENT): New macro and constant.
893 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
894 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
895 (stdalign): New macro, if not already defined.
896
df81cd29
EZ
8972012-07-28 Eli Zaretskii <eliz@gnu.org>
898
01bd1b0d
EZ
899 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
900 * w32inevt.c: Include w32inevt.h.
901 (w32_read_console_input): New inline function, calls either
902 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
903 w32_console_unicode_input.
904 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
905 (w32_kbd_patch_key, key_event): Use the codepage returned by
906 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
907 (key_event): use uChar.UnicodeChar only if
908 w32_console_unicode_input is non-zero.
909
910 * w32console.c: Include w32heap.h.
911 <w32_console_unicode_input>: New global variable.
912 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
913 family of Windows, zero otherwise.
914
915 * w32inevt.h: Declare w32_console_unicode_input.
916
df81cd29
EZ
917 * xdisp.c (init_iterator): Don't reference tip_frame in a build
918 --without-x. (Bug#11742)
919
c20fdd9e
PE
9202012-07-27 Paul Eggert <eggert@cs.ucla.edu>
921
922 Adjust GDB to reflect pvec_type changes (Bug#12036).
923 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
924 2012-07-04 changes to pseudovector representation. Problem
925 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
926
32770973 9272012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
928
929 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
930 bus address.
931 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
932
3438fe21
EZ
9332012-07-27 Eli Zaretskii <eliz@gnu.org>
934
bcfbc9de
EZ
935 * alloc.c (listn): Fix the order the arguments are consed onto the
936 list.
937
3438fe21
EZ
938 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
939 enumeration constants, as PURE and HEAP are too general, and clash
940 with other headers and sources, such as gmalloc.c and the
941 MS-Windows system headers. All users changed.
942
eeaea515
DA
9432012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
944
945 Revert last save_excursion_save and save_excursion_restore changes.
946 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
947 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
948
073c88c2
DA
9492012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
950
951 Fix recently-introduced typos in Windows port.
952 Reported by Martin Rudalics <rudalics@gmx.at>.
953 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 954 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 955
4706125e
PE
9562012-07-27 Paul Eggert <eggert@cs.ucla.edu>
957
958 Improve GDB symbol export (Bug#12036).
959 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
960 arms of an 'if', not using conditional expressions; otherwise GDB
961 complains about the types in the unevaluated arm when the argument
962 is an integer literal.
963 (xgetint): Simplify expression.
964 * alloc.c (gdb_make_enums_visible): New constant. This ports to
965 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
966 Zaretskii in <http://bugs.gnu.org/12036#13>.
967 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
968 needed now that we have gdb_make_enums_visible.
969 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
970 (enum enum_USE_LSB_TAG):
971 New enum types, packaging up enums that need to be exported to GDB.
972
694b6c97
DA
9732012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
974
975 Utility function to make a list from specified amount of objects.
976 * lisp.h (enum constype): New datatype.
977 (listn): New prototype.
978 * alloc.c (listn): New function.
979 (Fmemory_use_count, syms_of_alloc): Use it.
980 * buffer.c (syms_of_buffer): Likewise.
981 * callint.c (syms_of_callint): Likewise.
982 * charset.c (define_charset_internal): Likewise.
983 * coding.c (syms_of_coding): Likewise.
984 * keymap.c (syms_of_keymap): Likewise.
985 * search.c (syms_of_search): Likewise.
986 * syntax.c (syms_of_syntax): Likewise.
987 * w32.c (init_environment): Likewise.
988 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
989 * xdisp.c (syms_of_xdisp): Likewise.
990 * xfns.c (syms_of_xfns): Likewise.
991
6195f384
DA
9922012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
993
994 Fast save_excursion_save and save_excursion_restore.
995 * lisp.h (struct Lisp_Excursion): New data type.
996 (PVEC_EXCURSION): New pseudovector type.
997 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
998 to deal with it. Adjust comments.
999 (init_marker, attach_marker): New prototype.
1000 (unchain_marker): Adjust prototype.
1001 * marker.c (attach_marker): Change to global.
1002 (init_marker): New function.
1003 * alloc.c (Fmake_marker, build_marker): Use it.
1004 (build_marker): More easserts.
1005 (mark_object): Handle struct Lisp_Excursion.
1006 * editfns.c (save_excursion_save, save_excursion_restore):
1007 Reimplement to use struct Lisp_Excursion. Add comments.
1008
5eceb8fb
PE
10092012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1010
1011 Fix export of symbols to GDB (Bug#12036).
1012 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1013 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1014 emacs.c, as this is a more-suitable home. Had this been done earlier
1015 the fix for 12036 would have avoided some of the problems noted in
1016 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1017 would have been more obvious.
562157c8
PE
1018 * emacs.c: Do not include <verify.h>; no longer needed.
1019 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1020 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1021 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1022 Remove; now done in lisp.h.
1023 * lisp.h (PUBLISH_TO_GDB): New macro.
1024 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1025 (DATA_SEG_BITS): Use it.
1026 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1027 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1028 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1029 not be usable in #if. This simplifies things.
1030
d6749401
JB
10312012-07-26 Juanma Barranquero <lekktu@gmail.com>
1032
1033 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1034
1781b9e9
PE
10352012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1036
d89518db 1037 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1038 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1039 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1040 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1041 Adjust to changes in lisp.h and emacs.c, by using
1042 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1043 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1044 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1045 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1046 instead of gdb_valbits.
1047 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1048 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1049 instead of gdb_array_mark_flag.
1050 (xboolvector): Get size from $->size, not $->header.size.
1051 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1052 (xreload, hook-run, hookpost-run): Remove.
1053 * emacs.c: Include <verify.h>.
1054 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1055 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1056 Remove.
1057 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1058 (gdb_USE_LSB_TAG): New enum constants.
1059 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1060 Also define these as enum constants, so they're visible to GDB.
1061 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1062 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1063 as constants, so they're visible to GDB.
1064 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1065 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1066 Now enum constants, not macros, so they're visible to GDB.
1067 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1068 more convenient now. All uses changed.
1069 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1070 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1071
3628596a
DA
10722012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1073
1074 Explicitly free restriction data that are not needed anymore.
1075 * editfns.c (save_restriction_restore): Free restriction data.
1076
7abaf5cc
SM
10772012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1078
1079 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1080 add argument, tune behavior, and adjust all callers.
1081
71f88e00
PE
10822012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1083
1084 Use typedef for EMACS_INT, EMACS_UINT.
1085 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1086 than macros. This simplifies debugging in the usual case, since
1087 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1088 and it allows expressions involving EMACS_INT casts.
1089 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1090
57ec3034
JD
10912012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1092
1093 * nsterm.m (ns_read_socket): Return early if there is a modal
1094 window (Bug#12043).
1095
8137e7b3
MR
10962012-07-25 Martin Rudalics <rudalics@gmx.at>
1097
1098 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1099 that FOCUS-FRAME can be omitted.
1100
04e9897c
DA
11012012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1102
1103 Adjust buffer text indirection counters at the end of Fkill_buffer.
1104 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1105 buffer is definitely dead. This should really fix an issue reported
1106 by Christoph Scholtes again. (Bug#12007).
1107 (init_buffer_once): Initialize indirection counters of
1108 buffer_defaults and buffer_local_symbols (for sanity and safety).
1109
8a0484e1
EZ
11102012-07-24 Eli Zaretskii <eliz@gnu.org>
1111
1112 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1113 and continuation glyphs on tooltip frames, leave them at zero.
1114 Avoids continued lines in tooltips. (Bug#11832)
1115
fa691a83
DA
11162012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1117
1118 Simplify copy_overlay.
04e9897c 1119 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1120 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1121
436bc8e0
EZ
11222012-07-23 Eli Zaretskii <eliz@gnu.org>
1123
1124 * print.c (print_object): Don't crash when a frame's name is nil
1125 or invalid. (Bug#12025)
1126
1127 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1128 it signals an error when a tooltip frame is being created.
1129
d7a7fda3
DA
11302012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1131
1132 Cleanup miscellaneous objects allocation and initialization.
1133 * alloc.c (allocate_misc): Change to static. Add argument to
1134 specify the subtype. Adjust comment and users.
1135 (build_overlay): New function.
1136 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1137 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1138 (allocate_misc): Remove prototype.
1139 (build_overlay): Add prototype.
1140
11412012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1142
1143 Swap buffer text indirection counters in Fbuffer_swap_text.
1144 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1145 This avoids crash reported by Christoph Scholtes at
1146 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1147
9d7fa573
JD
11482012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1149
1150 * nsmenu.m (Popdown_data): New struct.
1151 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1152 free Popdown_data.
1153 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1154 (initWithContentRect): Make imgView and contentView non-static
1155 and autorelease them. Also autorelease img and matrix (Bug#12005).
1156 (dealloc): Remove (Bug#12005).
1157
0dd6d66d
DA
11582012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1159
1160 Adjust consing_since_gc when objects are explicitly freed.
1161 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1162 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1163 (free_cons, free_misc): Subtract object size from consing_since_gc.
1164
d36d71df
DA
11652012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1166
1167 Simplify and cleanup markers positioning code.
1168 * marker.c (attach_marker): More useful eassert.
1169 (live_buffer, set_marker_internal): New function.
1170 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1171 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1172
fb9ea40f
PE
11732012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1176 as it's limited by the amount of memory, not by INT_MAX.
1177
2d5c5f7d
EZ
11782012-07-21 Eli Zaretskii <eliz@gnu.org>
1179
07fb592e
EZ
1180 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1181 in special-event-map. See the discussion at
1182 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1183 for the reasons.
1184
37a9eac8 1185 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
1186 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
1187 Fabrice Popineau <fabrice.popineau@supelec.fr>.
1188
c4328746
JD
11892012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1190
1191 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1192 (conversationIdentifier): Return value is NSInteger.
784051c4 1193 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1194
6e5d1c12
CY
11952012-07-21 Chong Yidong <cyd@gnu.org>
1196
1197 * window.c (decode_any_window): Signal an error if the window is
1198 on a dead frame (Bug#11984).
1199
9928463d
DA
12002012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1201
1202 Add indirection counting to speed up Fkill_buffer.
1203 * buffer.h (struct buffer): New member.
1204 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1205 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1206 base buffer indirection counter.
1207 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1208 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1209 through buffer list if indirection counter is 0.
1210
f8643a6b
DA
12112012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1212
1213 Extend the value returned by Fgarbage_collect with heap statistics.
1214 * alloc.c (Qheap): New symbol.
1215 (syms_of_alloc): DEFSYM it.
1216 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1217 (Fmemory_free): Remove.
1218 (syms_of_alloc): Don't defsubr it.
1219 * buffer.c (Fcompact_buffer): Remove.
1220 (syms_of_buffer): Don't defsubr it.
1221
dac616ff
DA
12222012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1223
1224 Make maybe_gc inline.
1225 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1226 * lisp.h (consing_since_gc, gc_relative_threshold)
1227 (memory_full_cons_threshold): Revert declaration.
1228 (maybe_gc): Remove prototype, define as inline.
1229 * alloc.c: Remove old commented-out code.
1230 (consing_since_gc, gc_relative_threshold)
1231 (memory_full_cons_threshold): Revert to global.
1232 (maybe_gc): Remove.
1233
d7ea76b4
DA
12342012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1235
1236 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1237 * lisp.h (build_unibyte_string): New function.
1238 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1239 * sysdep.c, w32fns.c, xfns.c: Use it.
1240 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1241 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1242 Adjust users accordingly.
1243 * font.h (font_open_by_name): Adjust prototype.
1244
765e61e3
DA
12452012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1246
1247 Cleanup calls to Fgarbage_collect.
1248 * lisp.h (maybe_gc): New prototype.
1249 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1250 Remove declarations.
1251 * alloc.c (maybe_gc): New function.
1252 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1253 Make them static.
1254 * bytecode.c (MAYBE_GC): Use maybe_gc.
1255 * eval.c (eval_sub, Ffuncall): Likewise.
1256 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1257 to avoid dependency from auto-save feature.
1258
52b852c7
PE
12592012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1260
1261 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1262 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1263 'for_each_per_buffer_object_at'.
1264 All uses changed. It's better to use upper-case for macros that
1265 cannot be implemented as functions, to give the reader a clue
1266 that they're special.
1267
5db81e33
SM
12682012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1269
1270 * alloc.c (Fgarbage_collect): Tweak docstring.
1271
5b835e1d
DA
12722012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1273
1274 Tweak the value returned from Fgarbage_collect again.
1275 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1276 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1277 Adjust documentation.
1278 (total_vector_bytes): Rename to total_vector_slots, adjust
1279 accounting.
1280 (total_free_vector_bytes): Rename to total_free_vector_slots,
1281 adjust accounting.
1282 (Qstring_bytes, Qvector_slots): New symbols.
1283 (syms_of_alloc): DEFSYM them.
1284
9cd47b72
DA
12852012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1286
1287 Buffer compaction primitive which may be used from Lisp.
1288 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1289 (syms_of_buffer): Register Fcompact_buffer.
1290 * alloc.c (Fgarbage_collect): Use compact_buffer.
1291 * buffer.h (compact_buffer): New prototype.
1292 (struct buffer_text): New member.
1293
d17337e5
DA
12942012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1295
1296 New macro to iterate over all buffers, miscellaneous cleanups.
1297 * lisp.h (all_buffers): Remove declaration.
1298 * buffer.h (all_buffers): Add declaration, with comment.
1299 (for_each_buffer): New macro.
1300 * alloc.c (Fgarbage_collect, mark_object): Use it.
1301 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1302 (init_buffer): Likewise.
1303 * data.c (Fset_default): Likewise.
1304 * coding.c (code_conversion_restore): Remove redundant check
1305 for dead buffer.
1306 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1307
60cfd278
AS
13082012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1309
1310 Fix bug that created negative-length intervals.
1311 * intervals.c (merge_interval_right, merge_interval_left):
1312 Do not zero out this interval if it is absorbed by its children,
1313 as this interval's total length doesn't change in that case. See
1314 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1315
d06714cb
PE
13162012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1317
83713154
PE
1318 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1319 when invoking (make-bool-vector N t) and N is a positive
1320 multiple of 8 -- the last 8 bits were mistakenly cleared.
1321
d06714cb
PE
1322 Remove some struct layout assumptions in bool vectors.
1323 * alloc.c (bool_header_size): New constant.
1324 (header_size, word_size): Move earlier, as they're now used earlier.
1325 Use 'word_size' in a few more places, where it's appropriate.
1326 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1327 padding before the data member of a bool vector.
1328 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1329 than doing the check by hand with an abort ().
1330
464d5a5e
SM
13312012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1332
5fbc0409
SM
1333 * eval.c (Fdefvar): Don't check constants since we only set the var if
1334 it's not yet defined anyway (bug#11904).
1335
464d5a5e
SM
1336 * lisp.h (last_undo_boundary): Declare new var.
1337 * keyboard.c (command_loop_1): Set it.
1338 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1339 were auto-added by the command loop (bug#11774).
1340
8dc2e44a
AS
13412012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1342
1343 * w32font.c (Qsymbol): Remove local definition.
1344 (syms_of_w32font): Don't DEFSYM it.
1345
169925ec
DA
13462012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1347
1348 Fix sweep_vectors to handle large bool vectors correctly.
1349 * alloc.c (sweep_vectors): Account total_vector_bytes for
1350 bool vectors larger than VBLOCK_BYTES_MAX.
1351
5fbfb018
CY
13522012-07-18 Chong Yidong <cyd@gnu.org>
1353
1354 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1355 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1356
3ab6e069
DA
13572012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1358
1359 Return more descriptive data from Fgarbage_collect.
1360 Suggested by Stefan Monnier in
1361 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1362 * alloc.c (bounded_number): New function.
1363 (total_buffers, total_vectors): New variable.
1364 (total_string_size): Rename to total_string_bytes, adjust users.
1365 (total_vector_size): Rename to total_vector_bytes, adjust users.
1366 (sweep_vectors): Account total_vectors and total_vector_bytes.
1367 (Fgarbage_collect): New return value. Adjust documentation.
1368 (gc_sweep): Account total_buffers.
1369 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1370 (VECTOR_SIZE): Remove.
1371 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1372 (Qinterval, Qmisc): New symbols.
1373 (syms_of_data): Initialize them.
1374 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1375 (Qcons, Qbuffer): New declarations.
1376
6d02fe5b
PE
13772012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1378
1379 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1380 Round up, not down. Improve doc.
1381
b7ffe040
DA
13822012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1383
1384 Restore old code in allocate_string_data to avoid Faset breakage.
1385 Reported by Julien Danjou <julien@danjou.info> in
1386 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1387 * alloc.c (allocate_string_data): Restore old code with minor
1388 adjustments, fix comment to explain this subtle issue.
1389
4dc7c8d5
SM
13902012-07-17 Eli Zaretskii <eliz@gnu.org>
1391
1392 Remove FILE_SYSTEM_CASE.
1393 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1394
1395 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1396 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1397 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1398 call-process-region passes it through expand-file-name.
1399
1400 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1401
14022012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1403
1404 Fix crash when creating indirect buffer (Bug#11917)
1405 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1406 Don't handle unbound variables specially if non-zero.
1407 (Fbuffer_local_variables): Pass zero.
1408 (clone_per_buffer_values): Pass non-zero.
1409
14102012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1411
1412 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1413 to make the loop interruptible.
1414
14152012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1416
1417 * gnutls.c (emacs_gnutls_handshake): Only retry if
1418 GNUTLS_E_INTERRUPTED.
1419
cce7fefc
DA
14202012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1421
1422 Cleanup and convert miscellaneous checks to eassert.
1423 * alloc.c (mark_interval): Fix comment, partially rephrase
1424 old comment from intervals.h (see below).
1425 * intervals.c (find_interval, adjust_intervals_for_insertion)
1426 (delete_interval, adjust_intervals_for_deletion)
1427 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1428 Convert to eassert.
1429 (adjust_intervals_for_insertion, make_new_interval):
1430 Remove obsolete and unused code.
1431 * intervals.h (struct interval): Remove obsolete comment.
1432 * textprotp.c (erase_properties): Remove unused code.
1433 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1434 (Fremove_list_of_text_properties): Convert to eassert.
1435
9ea10cc3
CY
14362012-07-17 Chong Yidong <cyd@gnu.org>
1437
1438 * editfns.c (Finsert_char): Doc fix.
1439
3900d5de
DA
14402012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1441
1442 Fix previous change to make Fmemory_free always accurate.
1443 * alloc.c (make_interval): Update total_free_intervals.
1444 (make_float): Likewise for total_free_floats.
1445 (free_cons, Fcons): Likewise for total_free_conses.
1446 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1447 Likewise for total_free_vector_bytes.
1448 (Fmake_symbol): Likewise for total_free_symbols.
1449 (bytes_free): Remove.
1450
7098646f
DA
14512012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1452
1453 Simple free memory accounting feature.
1454 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1455 (sweep_vectors): Accumulate size of free vectors.
1456 (Fgarbage_collect): Setup bytes_free.
1457 (Fmemory_free): New function.
1458 (syms_of_alloc): Register it.
1459
22657b40
DA
14602012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1461
1462 Cleanup overlays checking.
1463 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1464 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1465 eassert and OVERLAYP.
1466 (sort_overlays): Change to use OVERLAYP.
1467
ddfc8813
RK
14682012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1469
1470 * editfns.c (Finsert_char): Make it interactive, and make the
1471 second arg optional. Copy interactive spec and docstring from
1472 ucs-insert.
1473
7c26cf3c
PE
14742012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1477 Unlike the other wrapped functions, fabs has an unspecified
1478 effect on errno.
1479
5d127af9
JD
14802012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1481
1482 * nsterm.m (keyDown): Interpret flags without left/right bits
1483 as the left key (Bug#11670).
1484
6a0dd1d7
DA
14852012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1486
1487 Remove empty and useless init functions.
1488 * lisp.h (init_character_once, init_fns, init_image)
1489 (init_filelock, init_sound): Remove prototype.
1490 * character.c (init_character_once): Remove.
1491 * filelock.c (init_filelock): Likewise.
1492 * fns.c (init_fns): Likewise.
1493 * image.c (init_image): Likewise.
1494 * sound.c (init_sound): Likewise.
1495 * emacs.c (main): Adjust accordingly.
1496
7a6136fd
DA
14972012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1498
1499 * gtkutil.h: Tiny cleanups.
1500 (use_old_gtk_file_dialog): Remove useless declaration.
1501 (xg_uses_old_file_dialog): Add suggested const attribute.
1502
ce811ad9
EZ
15032012-07-15 Eli Zaretskii <eliz@gnu.org>
1504
1505 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1506 (bidi_paragraph_init): Use it to limit search forward for a strong
1507 directional character in abnormally large paragraphs full of
1508 neutral or weak characters. (Bug#11943)
1509
c9adfeaa
SF
15102012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1511
1512 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1513 the toolbar (Bug#9451).
1514 (xg_make_tool_item): Give the widget event box a transparent
1515 background.
1516
fff62aa9
DA
15172012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1518
1519 Cleanup basic allocation variables and functions.
1520 * alloc.c (ignore_warnings, init_intervals, init_float)
1521 (init_cons, init_symbol, init_marker): Remove.
1522 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1523 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1524 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1525 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1526 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1527 (staticidx, init_alloc_once, init_strings, free_ablock):
1528 Remove redundant initialization.
1529 * fns.c (init_weak_hash_tables): Remove.
1530 * lisp.h (init_weak_hash_tables): Remove prototype.
1531
9730daca
DA
15322012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1533
1534 Use zero_vector where appropriate.
1535 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1536 accordingly.
1537 * lisp.h (zero_vector): New declaration.
1538 * font.c (null_vector): Remove.
1539 (syms_of_font): Remove initialization and staticpro.
1540 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1541 * keymap.c (Faccessible_keymaps): Likewise.
1542
2e2d2a13
LL
15432012-07-15 Leo Liu <sdl.web@gmail.com>
1544
1545 * fringe.c: Fix typo in comments.
1546
cd276f6e
LL
15472012-07-14 Leo Liu <sdl.web@gmail.com>
1548
1549 * fringe.c: Add a new bitmap exclamation-mark.
1550
5a1131d9
EZ
15512012-07-14 Eli Zaretskii <eliz@gnu.org>
1552
1553 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1554
1555 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1556 (HAVE_MENUS): Don't define, defined by editing config.in with
1557 msdos/sed2v2.inp.
1558 (GMALLOC_INHIBIT_VALLOC): Don't define.
1559 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1560
22e983b7
JB
15612012-07-14 Juanma Barranquero <lekktu@gmail.com>
1562
1563 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1564
5b3f250f
GM
15652012-07-14 Glenn Morris <rgm@gnu.org>
1566
1567 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1568 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1569 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1570
33d63ff4
GM
15712012-07-13 Glenn Morris <rgm@gnu.org>
1572
5b633342
GM
1573 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1574
33d63ff4
GM
1575 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1576 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1577
b55b9f85
JD
15782012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1579
0dc8cf50
JD
1580 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1581 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1582 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1583 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1584 where appropriate.
1585 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1586 as boolean expression.
1587 (x_set_window_size): Remove unused variable toolbar.
1588 (ns_get_color_default, ns_mod_to_lisp): Remove.
1589 (ns_mouse_position): Remove unused variables xchar and ychar.
1590 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1591 (ns_set_vertical_scroll_bar): Remove unused variable count.
1592 (ns_delete_terminal): Remove unused variable i.
1593 (ns_term_init): Remove unused variables r, g and b.
1594 (mouseDown): Remove unused variable window.
1595 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1596 (initFrameFromEmacs): Remove unused variable vbextra.
1597 (mouseEntered): Remove unused variables p and dpyinfo.
1598 (mouseExited): Remove unused variables p and r.
1599 (ns_define_frame_cursor, ns_clear_frame_area)
1600 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1601 (menuDown): Assign [sender tag] to variable and cast the variable.
1602
1603 * nsterm.h (menuDown): Add id as type to argument sender.
1604 (ns_display_info_for_name): Add Lisp_Object argument.
1605 (ns_term_init): Add Lisp_Object argument.
1606 (ns_map_event_to_object): Add void argument.
1607 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1608 prototype with arguments and only declare if __OBJC__.
1609 (nxatoms_of_nsselect): Add void argument.
1610 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1611 (ns_alloc_autorelease_pool): Add void argument.
1612 (ns_release_autorelease_pool): Add void* argument.
1613 (ns_get_defaults_value): Add const char* argument.
1614
1615 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1616 (initFromContents): Use SSDATA where appropriate.
1617 (ns_update_menubar): Add braces to ambigous if-else.
1618 (initWithTitle): Put () around assignment in if statement.
1619 (ns_menu_show): Remove unused variables window and keymap.
1620 (update_frame_tool_bar): Remove unused variable selected_p.
1621 (initWithContentRect): Remove unused variable this_cmd_name.
1622
1623 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1624 appropriate.
1625 (setXBMColor): Remove unused variable len.
1626 (setPixmapData): Put () around assignment in loop statement.
1627
1628 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1629 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1630 where appropriate.
1631 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1632 around assignment in loop statement.
1633 (nsfont_open): Remove unused variable i.
1634 (nsfont_open): Remove unused variable len.
1635 (nsfont_draw): Remove unused variable cs.
1636
1637 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1638 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1639 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1640 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1641 (Fns_font_name, Fns_perform_service)
1642 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1643 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1644 (ns_set_name): Remove unused variable view.
1645 (x_set_menu_bar_lines): Remove unused variable olines.
1646 (x_set_tool_bar_lines): Remove unused variable root_window.
1647 (Fns_list_colors): Put () around assignment in while statement.
1648 (Fns_perform_service): Remove unused variable len.
1649 (Fns_display_usable_bounds): Remove unused variable top.
1650 (syms_of_nsfns): Remove unused variable i.
1651
b55b9f85
JD
1652 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1653 memcpy (Bug#11907).
1654
ed9265fc 16552012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1656
1657 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1658 and free it with DestroyExceptionInfo (Bug#11558).
1659
ef099b57
JB
16602012-07-13 Juanma Barranquero <lekktu@gmail.com>
1661
1662 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1663 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1664 Set here, not in nt/config.nt.
1665
ea814a5d
EZ
16662012-07-13 Eli Zaretskii <eliz@gnu.org>
1667
1668 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1669 cursor overflow into the last glyph on display line when the right
1670 fringe is off. (Bug#11832)
1671
1a952767
PE
16722012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1673
1674 * xdisp.c (produce_special_glyphs): Now static.
1675 * dispextern.h (produce_special_glyphs): Remove decl.
1676
983188fd
GM
16772012-07-13 Glenn Morris <rgm@gnu.org>
1678
8d7c7eed 1679 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1680 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1681
983188fd
GM
1682 * s/usg5-4-common.h (USG, USG5):
1683 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1684 * s/sol2-6.h (SOLARIS2):
1685 * s/irix6-5.h (IRIX6_5):
1686 * s/hpux10-20.h (USG, USG5, HPUX):
1687 * s/gnu-linux.h (USG, GNU_LINUX):
1688 * s/freebsd.h (BSD_SYSTEM):
1689 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1690 * s/cygwin.h (CYGWIN):
1691 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1692 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1693
d1e68667 16942012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1695
1696 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1697
6de0e799
GM
16982012-07-13 Glenn Morris <rgm@gnu.org>
1699
739ae010
GM
1700 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1701
dbee5793
GM
1702 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1703
6de0e799
GM
1704 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1705 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1706
b82da769
GM
17072012-07-12 Glenn Morris <rgm@gnu.org>
1708
4fae5a7a 1709 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1710
1711 * process.c (init_process_emacs): Rename from init_process.
1712 The old name is also the name of a Mach system call.
1713 * lisp.h, emacs.c: Update for this name change.
1714 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1715 longer needed.
1716
5a979817
EZ
17172012-07-12 Eli Zaretskii <eliz@gnu.org>
1718
1719 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1720 memmove call that removes glyphs covered by the left truncation
1721 glyph. Improve commentary.
1722 (display_line): Fix display of continuation glyphs on GUI frames
1723 when the right fringe is turned off and variable-size fonts are
1724 used in the window. Move the code that appends a stretch glyph to
1725 produce_special_glyphs, so that it could be used for truncation
1726 and continuation glyphs alike.
1727 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1728 glyph of a suitably computed width, to align the special glyphs at
1729 the window margin. Code moved from display_line. (Bug#11832)
1730
3e91a053
GM
17312012-07-12 Glenn Morris <rgm@gnu.org>
1732
ba9e4b84
GM
1733 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1734
1735 * s/gnu-linux.h, s/hpux10-20.h:
1736 Do not unconditionally define HAVE_XRMSETDATABASE.
1737
3e91a053
GM
1738 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1739
b300b1f4
PE
17402012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1741
1742 Fix typos that broke OS X build.
1743 Reported by Randal L. Schwartz in
1744 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1745 * nsterm.m (ns_timeout): Add missing local decl.
1746 (ns_get_color): snprintf -> sprintf, to fix typo.
1747
6e777848
GM
17482012-07-12 Glenn Morris <rgm@gnu.org>
1749
3f922c37
GM
1750 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1751 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1752 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1753 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1754
0ab7b23a
GM
1755 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1756 Move PTY_OPEN to configure.
1757
6e777848
GM
1758 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1759 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1760 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1761
4a7edc24
DA
17622012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1763
1764 Use empty_unibyte_string where applicable.
1765 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1766 * lread.c (read1): Likewise.
1767 * xsettings.c (syms_of_xsettings): Likewise.
1768
308aab79
GM
17692012-07-12 Glenn Morris <rgm@gnu.org>
1770
42bd1719
GM
1771 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1772 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1773 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1774 * s/hpux10-20.h (RUN_TIME_REMAP):
1775 * s/bsd-common.h (TABDLY): Move to configure.
1776
1777 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1778
1779 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1780
ea0bbd17 1781 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1782 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1783
1784 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1785
308aab79
GM
1786 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1787 * s/template.h: Move NARROWPROTO to configure.
1788
ee1cf5cf
GM
17892012-07-11 Glenn Morris <rgm@gnu.org>
1790
30fe9bf4
GM
1791 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1792 unused since 2011-01-17 change to systty.h.
1793
ee1cf5cf
GM
1794 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1795 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1796 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1797
63e47e07
PE
17982012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1799
1800 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1801
c43fb4c3
GM
18022012-07-11 Glenn Morris <rgm@gnu.org>
1803
1804 * s/darwin.h, s/gnu-linux.h, s/template.h:
1805 Move INTERRUPT_INPUT to configure.
1806
e8df9267
DA
18072012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1808
1809 Minor adjustments to interning code.
1810 * lisp.h (intern, intern_c_string): Redefine as static inline
1811 wrappers for intern_1 and intern_c_string_1, respectively.
1812 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1813 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1814 Vobarray checking.
e8df9267
DA
1815 * font.c (font_intern_prop): Likewise. Adjust comment.
1816 * w32font.c (intern_font_name): Likewise.
1817
34348bd4
AS
18182012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1819
d96a1e0c
AS
1820 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1821
34348bd4
AS
1822 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1823 of Fcar/Fcdr if possible.
1824 * font.c (check_otf_features): Likewise.
1825 * fontset.c (Fnew_fontset): Likewise.
1826 * gnutls.c (Fgnutls_boot): Likewise.
1827 * minibuf.c (read_minibuf): Likewise.
1828 * msdos.c (IT_set_frame_parameters): Likewise.
1829 * xmenu.c (Fx_popup_dialog): Likewise.
1830 * w32menu.c (Fx_popup_dialog): Likewise.
1831
c8add24e
GM
18322012-07-11 Glenn Morris <rgm@gnu.org>
1833
4b575b3c
GM
1834 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1835 since nothing has defined it on these platforms.
1836
09f4e3b0
GM
1837 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1838 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1839
172bedef
GM
1840 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1841 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1842 Move CLASH_DETECTION to configure.
1843
249685df
GM
1844 * s/gnu.h: Remove file, which is now empty.
1845
c8add24e
GM
1846 * s/gnu.h, s/gnu-linux.h:
1847 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1848
b41253a3
JW
18492012-07-11 John Wiegley <johnw@newartisans.com>
1850
1851 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1852 function attribute, so we only use it if it exists in the
1853 compiler.
1854
d923b542
DA
18552012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1856
1857 Avoid call to strlen in fast_c_string_match_ignore_case.
1858 * search.c (fast_c_string_match_ignore_case): Change to use
1859 length argument. Adjust users accordingly.
1860 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1861
5ebbef1d
PE
18622012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1863
bb352260
PE
1864 Assume mkdir, rmdir.
1865 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1866 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1867
57054ddd
PE
1868 Assume rename.
1869 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1870
b747d3f7
PE
1871 Assume perror.
1872 * s/hpux10-20.h (HAVE_PERROR): Remove.
1873 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1874 Remove dummy definition, as this problem was obsolete long ago.
1875
5ebbef1d
PE
1876 Assume strerror.
1877 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1878
984e7f30
DA
18792012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1880
1881 Avoid calls to strlen in font processing functions.
1882 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1883 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1884 users accordingly.
d923b542
DA
1885 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1886 Adjust prototypes.
1887 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1888 Change to return ptrdiff_t.
984e7f30
DA
1889 (xfont_list_pattern, xfont_match): Use length returned by
1890 xfont_decode_coding_xlfd.
1891 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1892
20e94fdd
GM
18932012-07-11 Glenn Morris <rgm@gnu.org>
1894
9d596af3
GM
1895 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1896 Move DONT_REOPEN_PTY to configure.
1897
20e94fdd
GM
1898 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1899 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1900
e99a530f
PE
19012012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1902
22ffb973
PE
1903 Remove "#define unix" that is no longer needed (Bug#11905).
1904 * s/aix4-2.h (unix): Remove; no longer needed.
1905
e9a9ae03
PE
1906 EMACS_TIME simplification (Bug#11875).
1907 This replaces macros (which typically do not work in GDB)
1908 with functions, typedefs and enums, making the code easier to debug.
1909 The functional style also makes code easier to read and maintain.
1910 * systime.h: Include <sys/time.h> on all hosts, not just if
1911 WINDOWSNT, since 'struct timeval' is needed in general.
1912 (EMACS_TIME): Now a typedef, not a macro.
1913 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1914 not macros.
1915 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1916 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1917 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1918 (EMACS_TIME_LE): Now functions, not macros.
1919 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1920 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1921 which are not functions. All uses rewritten to use:
1922 (make_emacs_time): New function.
1923 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1924 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1925 not functions. All uses rewritten to use the following, respectively:
1926 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1927 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1928 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1929 * fileio.c (Fcopy_file):
1930 * xterm.c (XTflash): Get the current time closer to when it's used.
1931 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1932
ffacb126
PE
1933 * bytecode.c (targets): Suppress -Woverride-init warnings.
1934
e99a530f
PE
1935 Simplify by avoiding confusing use of strncpy etc.
1936 * doc.c (Fsnarf_documentation):
1937 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1938 * frame.c (Fmake_terminal_frame):
1939 * gtkutil.c (get_utf8_string):
1940 * lread.c (openp):
1941 * nsmenu.m (ns_update_menubar):
1942 * regex.c (regerror):
1943 Prefer memcpy to strncpy and strncat when either will do.
1944 * fileio.c (Fsubstitute_in_file_name):
1945 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1946 (menu_separator_name_p):
1947 * nsmenu.m (ns_update_menubar):
1948 Prefer memcmp to strncmp when either will do.
1949 * nsterm.m: Include <ftoastr.h>.
1950 (ns_get_color):
1951 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1952 Prefer snprintf to strncpy.
1953 * nsterm.m (ns_term_init):
1954 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1955 * nsterm.m (ns_term_init):
1956 Avoid the need for strncpy, by using build_string or
1957 make_unibyte_string directly. Use dtoastr, not snprintf.
1958 * process.c (Fmake_network_process): Diagnose service names that
1959 are too long, rather than silently truncating them or creating
1960 non-null-terminated names.
1961 (Fnetwork_interface_info): Likewise, for interface names.
1962 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1963 Prefer sprintf to strncat.
1964 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1965 Prefer vsnprintf to vsprintf + strncpy.
1966
c59592b3
GM
19672012-07-10 Glenn Morris <rgm@gnu.org>
1968
1969 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1970 Clarify fallback case.
1971
7d7bbefd
DA
19722012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1973
1974 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1975 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1976 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1977 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1978 where argument type is known to be a Lisp_Cons.
1979
3a4c8000
TT
19802012-07-10 Tom Tromey <tromey@redhat.com>
1981
1982 * bytecode.c (BYTE_CODE_THREADED): New macro.
1983 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1984 (enum byte_code_op): New type.
1985 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1986 (exec_byte_code): Use them. Use token threading when applicable.
1987
2a0213a6
DA
19882012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1989
1990 Optimize pure C strings initialization.
1991 * lisp.h (make_pure_string): Fix prototype.
1992 (build_pure_c_string): New function, defined as static inline. This
1993 provides a better opportunity to optimize away calls to strlen when
1994 the function is called with compile-time constant argument.
1995 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1996 argument, adjust users accordingly. Use build_pure_c_string where
1997 appropriate.
1998 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1999 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2000 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2001
cb1caeaf
DA
20022012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2003
2004 Avoid calls to strlen in miscellaneous functions.
2005 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2006 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2007 * lread.c (openp): Likewise.
2008
c293e30c
DA
20092012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2010
2011 Avoid calls to strlen in path processing functions.
2012 * fileio.c (file_name_as_directory): Add comment. Change to add
2013 srclen argument and return the length of result. Adjust users
2014 accordingly.
2015 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 2016 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
2017 users accordingly.
2018 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2019
9e059e3f
GM
20202012-07-10 Glenn Morris <rgm@gnu.org>
2021
d02eb359
GM
2022 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2023 Move PENDING_OUTPUT_COUNT definition to configure.
2024
882cf227
GM
2025 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2026 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2027 * s/gnu.h (DATA_START): Move definitions to configure.
2028
af6e839f
GM
2029 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2030 We include usg5-4-common.h, which defines them both.
2031
40289a12
GM
2032 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2033 O_RDONLY already includes it).
2034
9e059e3f
GM
2035 Stop ns builds setting the EMACSLOADPATH environment variable.
2036 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2037 Now it does not set EMACSLOADPATH, just returns the load-path string.
2038 * nsterm.h: Update accordingly.
2039 * lread.c [HAVE_NS]: Include nsterm.h.
2040 (init_lread) [HAVE_NS]: Use ns_load_path.
2041 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2042
7c4e8ec0
GM
20432012-07-09 Glenn Morris <rgm@gnu.org>
2044
d4f600ff
GM
2045 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2046 since the included bsd-common.h does so.
2047
cbb31951
GM
2048 Stop ns builds setting the EMACSPATH environment variable.
2049 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2050 (ns_init_paths): Do not set EMACSPATH.
2051 * nsterm.h (ns_exec_path): Add it.
2052 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2053 Use ns_exec_path.
2054
7c4e8ec0
GM
2055 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2056
26bccfae
PE
20572012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2058
a0bee46f
PE
2059 * process.c (wait_reading_process_output): 'waitchannels' was unset
2060 when read_kbd || !NILP (wait_for_cell); fix this.
2061
5994c183
PE
2062 Add GCC-style 'const' attribute to functions that can use it.
2063 * character.h (char_resolve_modifier_mask):
2064 * keyboard.h (make_ctrl_char):
2065 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2066 (init_character_once, next_almost_prime, init_fns, init_image)
2067 (flush_pending_output, init_sound):
2068 * mem-limits.h (start_of_data):
2069 * menu.h (finish_menu_items):
2070 Add ATTRIBUTE_CONST.
2071 * emacs.c (DEFINE_DUMMY_FUNCTION):
2072 Declare the dummy function with ATTRIBUTE_CONST.
2073 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2074 Add decls with ATTRIBUTE_CONST.
2075
26bccfae
PE
2076 Minor improvements to make_formatted_string.
2077 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2078 where int is good enough, as vsprintf returns an int.
2079 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2080
a8290ec3
DA
20812012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2082
2083 Use make_formatted_string to avoid double length calculation.
2084 * lisp.h (make_formatted_string): New prototype.
2085 * alloc.c (make_formatted_string): New function.
2086 * buffer.c (Fgenerate_new_buffer_name): Use it.
2087 * dbus.c (syms_of_dbusbind): Likewise.
2088 * editfns.c (Fcurrent_time_zone): Likewise.
2089 * filelock.c (get_boot_time): Likewise.
2090 * frame.c (make_terminal_frame, set_term_frame_name)
2091 (x_report_frame_params): Likewise.
2092 * image.c (gs_load): Likewise.
2093 * minibuf.c (get_minibuffer): Likewise.
2094 * msdos.c (dos_set_window_size): Likewise.
2095 * process.c (make_process): Likewise.
2096 * xdisp.c (ensure_echo_area_buffers): Likewise.
2097 * xsettings.c (apply_xft_settings): Likewise.
2098
d01ba2f1
GM
20992012-07-09 Glenn Morris <rgm@gnu.org>
2100
2101 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2102 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2103 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2104 * nsterm.h (ns_etc_directory): Add it.
2105 * callproc.c [HAVE_NS]: Include nsterm.h.
2106 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2107
f1f924b6
DA
21082012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2109
2110 Move marker debugging code under MARKER_DEBUG.
2111 * marker.c (MARKER_DEBUG): Move marker debugging code under
2112 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2113 for bootstrap with --enable-checking (~3x slowdown reported
2114 by Juanma Barranquero <lekktu@gmail.com>).
2115 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2116
ab531b66
PE
21172012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2118
2119 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2120 See <http://bugs.gnu.org/11825#29>.
2121
c4b3bc8a
EZ
21222012-07-08 Eli Zaretskii <eliz@gnu.org>
2123
2124 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2125 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2126 (display_line): Add commentary about displaying truncation glyphs
2127 on GUI frames.
2128 (produce_special_glyphs): Move here from term.c.
2129
2130 * term.c (produce_special_glyphs): Move to xdisp.c.
2131
2132 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2133 section.
c4b3bc8a 2134
b676b881
AS
21352012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2136
f17c5273
AS
2137 * xdisp.c (display_line): Avoid warning about implicit declaration
2138 of FRAME_FONT.
2139
298819b9
AS
2140 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2141
b676b881
AS
2142 * lisp.h: Remove empty conditional.
2143
6045c4fd
PE
21442012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2145
b3350bf9
PE
2146 * lread.c (load_path_check): Now static.
2147
6045c4fd
PE
2148 Fix some minor --with-ns problems found by static checking.
2149 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2150 (x_set_font) [!HAVE_X_WINDOWS]:
2151 * image.c (xpm_load_image) [HAVE_NS]:
2152 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2153 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2154 Remove unused local.
2155 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2156 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2157 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2158 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2159 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2160 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2161 Fix pointer signedness problem.
2162 * xfaces.c (FRAME_X_FONT_TABLE):
2163 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2164
929e7845
GM
21652012-07-07 Glenn Morris <rgm@gnu.org>
2166
2167 * lread.c (load_path_check): New function, split from init_lread.
2168 (init_lread): Reorganize. Motivation:
2169 If EMACSLOADPATH is set, check/warn about that rather than the
2170 defaults, which we are not going to use. Hence we can remove
2171 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2172 Don't warn if site-lisp directories are missing.
2173 If not installed, start from a blank load-path, since
2174 PATH_LOADSEARCH refers to the eventual installation directories.
2175
58dd0aa4
EZ
21762012-07-07 Eli Zaretskii <eliz@gnu.org>
2177
2178 Support truncation and continuation glyphs on GUI frames, when
2179 fringes are disabled. (Bug#11832)
2180 * xdisp.c (init_iterator): Get dimensions of truncation and
2181 continuation glyphs even if on GUI frames. Adjust
2182 it->last_visible_x on GUI frames when the left or right fringes,
2183 or both, are absent.
2184 (start_display, move_it_in_display_line_to): Handle the case of a
2185 GUI frame without a fringe to display continuation or truncation
2186 glyphs.
2187 (insert_left_trunc_glyphs): Support GUI frames: make sure
2188 truncation glyphs overwrite enough glyphs from the current line to
2189 have sufficient space in pixels.
2190 (display_line): Support truncation and continuation glyphs on GUI
2191 frames. If some spare pixels are left on the line after inserting
2192 the truncation glyphs, fill that space with a stretch glyph of a
2193 suitably computed width.
2194
2195 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2196 produce_glyphs, to support GUI sessions.
2197
31571fd7
PE
21982012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2199
5a16b9bc
PE
2200 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2201
f3047c75
PE
2202 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2203
31571fd7
PE
2204 Do not require float-time's arg to fit in time_t (Bug#11825).
2205 This works better on hosts where time_t is unsigned, and where
2206 float-time is applied to the (negative) difference between two times.
2207 * editfns.c (decode_time_components): Last arg is now double *,
2208 not int *, and means to store all the result as a double, without
2209 worrying about whether the seconds part fits in time_t.
2210 All callers changed.
2211 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2212 All callers changed.
2213 (Ffloat_time): Do not fail merely because the specified time falls
2214 outside of time_t range.
2215
4516fbef
GM
22162012-07-07 Glenn Morris <rgm@gnu.org>
2217
2218 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2219 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2220 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2221
07adc2c6
JB
22222012-07-07 Juanma Barranquero <lekktu@gmail.com>
2223
2224 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2225 Update dependencies.
2226
2227 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2228
fd573f31
PE
22292012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2230
fee5959d
PE
2231 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2232 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2233 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2234 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2235 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2236 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2237
fd573f31
PE
2238 * xfont.c (compare_font_names): Redo to omit the need for casts.
2239
ddadbc0e
AS
22402012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2241
fca8d6b6
AS
2242 * xfns.c (Fx_change_window_property): Doc fix.
2243 * w32fns.c (Fx_change_window_property): Doc fix.
2244
ddadbc0e
AS
2245 * w32fns.c (Fx_window_property): Accept the same arguments as the
2246 X Windows version. Doc fix.
2247 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2248
ed9265fc 22492012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2250 Eli Zaretskii <eliz@gnu.org>
2251
2252 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2253 Windows-specific code from nt/config.nt moved here.
2254 Obsolete settings removed.
2255
216ee680
PE
22562012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2257
2258 * process.c: Avoid unnecessary calls to gettime.
2259 (wait_reading_process_output): Don't get the time of day
2260 when gobbling data immediately and not waiting, as there's no need
2261 for it in that case. This removes a FIXME.
2262
bdd091e4
JD
22632012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2264
2265 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2266 is defined (Bug#11768).
2267
9d44f8ce
DA
22682012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2269
2270 Fix marker debugging code.
2271 * marker.c (byte_char_debug_check): Do not perform the check
2272 if buffer is not multibyte.
090bd7cb
JB
2273 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2274 Call byte_char_debug_check with correct arguments.
9d44f8ce 2275
90fc4786
DA
22762012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2277
2278 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2279 * marker.c (byte_char_debug_check, count_markers):
2280 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2281 (byte_debug_flag): Remove.
2282 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2283 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2284
7b7ae965
DA
22852012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2286
4e57b342
DA
2287 Avoid code repetition in marker-related functions.
2288 * marker.c (attach_marker): New function.
2289 (Fset_marker, set_marker_restricted, set_marker_both)
2290 (set_marker_restricted_both): Use it.
2291 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2292 Consistently rename charno to charpos.
2293 (marker_position): Add eassert.
2294 (marker_byte_position): Convert to eassert.
2295
22962012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2297
2298 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2299 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2300 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2301
657924ff
DA
23022012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2303
2304 Introduce fast path for the widely used marker operation.
2305 * alloc.c (build_marker): New function.
2306 * lisp.h (build_marker): New prototype.
2307 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2308 * composite.c (autocmp_chars): Likewise.
2309 * editfns.c (buildmark): Remove.
2310 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2311 (save_restriction_save): Use build_marker.
2312 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2313 * window.c (save_window_save): Likewise.
2314
041a49a6
DA
23152012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2316
2317 Do not use Fdelete_overlay in delete_all_overlays
2318 to avoid redundant calls to unchain_overlay.
2319 * buffer.c (drop_overlay): New function.
2320 (delete_all_overlays, Fdelete_overlay): Use it.
2321 * minibuf.c (get_minibuffer): Fix comment.
2322
7dca65a4
PE
23232012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2324
2325 Port to OpenBSD 5.1 amd64.
2326 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2327 This is needed for OpenBSD, and should be harmless on all BSD systems.
2328 Also, include <sys/sysctl.h>, as it should be available on all
2329 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2330 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2331 use p_pid member, not kp_proc.pid.
2332
8eb876e2
GM
23332012-07-06 Glenn Morris <rgm@gnu.org>
2334
2335 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2336
38182d90
PE
23372012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2338
2339 More xmalloc and related cleanup.
2340 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2341 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2342 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2343 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2344 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2345 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2346 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2347 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2348 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2349 * xterm.c:
2350 Omit needless casts involving void * pointers and allocation.
2351 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2352 as the former is more robust if P's type is changed.
2353 Prefer xzalloc to xmalloc + memset 0.
2354 Simplify malloc-or-realloc to realloc.
2355 Don't worry about xmalloc returning a null pointer.
2356 Prefer xstrdup to xmalloc + strcpy.
2357 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2358 growing it.
2359 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2360 alloca of a constant.
2361
6dd5a677
EZ
23622012-07-05 Eli Zaretskii <eliz@gnu.org>
2363
2364 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2365 hscroll is larger than the line width. Fixes long and futile
2366 looping inside extend_face_to_end_of_line (on a TTY) producing
2367 glyphs that are not needed and thrown away.
2368
6b312f0f
DA
23692012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2370
2371 * marker.c (set_marker_restricted_both): Simplify by using
2372 clip_to_bounds.
2373
f520ef9b
PE
23742012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2375
2376 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2377
383b7c95
JD
23782012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2379
2380 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2381 not defined (Bug#11768).
2382 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2383 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2384 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2385 followed by gtk_box_set_homogeneous (Bug#11768).
2386 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2387 (update_theme_scrollbar_width, xg_create_scroll_bar):
2388 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2389 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2390 (is_box_type): New function (Bug#11768).
2391 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2392 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2393 with default display (Bug#11768).
2394
d6e7bf45
EZ
23952012-07-05 Eli Zaretskii <eliz@gnu.org>
2396
2397 * xdisp.c (window_hscroll_limited): New function.
2398 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2399 coordinates when window's hscroll is set to insanely large
2400 values. (Bug#11857)
2401
431391ec
JB
24022012-07-05 Juanma Barranquero <lekktu@gmail.com>
2403
2404 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2405 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2406
23f86fce
DA
24072012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2408
2409 Cleanup xmalloc.
2410 * lisp.h (xzalloc): New prototype. Omit needless casts.
2411 * alloc.c (xzalloc): New function. Omit needless casts.
2412 * charset.c: Omit needless casts. Convert all calls to
2413 xmalloc with following memset to xzalloc.
2414 * dispnew.c: Likewise.
2415 * fringe.c: Likewise.
2416 * image.c: Likewise.
2417 * sound.c: Likewise.
2418 * term.c: Likewise.
2419 * w32fns.c: Likewise.
2420 * w32font.c: Likewise.
2421 * w32term.c: Likewise.
2422 * xfaces.c: Likewise.
2423 * xfns.c: Likewise.
2424 * xterm.c: Likewise.
2425 * atimer.c: Omit needless casts.
2426 * buffer.c: Likewise.
2427 * callproc.c: Likewise.
2428 * ccl.c: Likewise.
2429 * coding.c: Likewise.
2430 * composite.c: Likewise.
2431 * doc.c: Likewise.
2432 * doprnt.c: Likewise.
2433 * editfns.c: Likewise.
2434 * emacs.c: Likewise.
2435 * eval.c: Likewise.
2436 * filelock.c: Likewise.
2437 * fns.c: Likewise.
2438 * gtkutil.c: Likewise.
2439 * keyboard.c: Likewise.
2440 * lisp.h: Likewise.
2441 * lread.c: Likewise.
2442 * minibuf.c: Likewise.
2443 * msdos.c: Likewise.
2444 * print.c: Likewise.
2445 * process.c: Likewise.
2446 * region-cache.c: Likewise.
2447 * search.c: Likewise.
2448 * sysdep.c: Likewise.
2449 * termcap.c: Likewise.
2450 * terminal.c: Likewise.
2451 * tparam.c: Likewise.
2452 * w16select.c: Likewise.
2453 * w32.c: Likewise.
2454 * w32reg.c: Likewise.
2455 * w32select.c: Likewise.
2456 * w32uniscribe.c: Likewise.
2457 * widget.c: Likewise.
2458 * xdisp.c: Likewise.
2459 * xmenu.c: Likewise.
2460 * xrdb.c: Likewise.
2461 * xselect.c: Likewise.
2462
0497dc44
PE
24632012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2464
2465 * fileio.c (time_error_value): Check the right error number.
2466 Problem reported by Troels Nielsen in
2467 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2468
356e7178
PE
24692012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2470
4e71fd89
PE
2471 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2472 This should be fixed in a better way; see Eli Zaretskii in
2473 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2474 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2475
f0941253
PE
2476 * fileio.c (time_error_value): Rename from special_mtime.
2477 The old name's problems were noted by Eli Zaretskii in
2478 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2479
065c9eb4
PE
2480 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2481 This variable's comment says Emacs needs at least one GDB-visible
2482 symbol of type enum pvec_type, to work around GDB problems.
2483 The symbol's value doesn't matter.
2484
356e7178
PE
2485 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2486 that causes compilation to fail on pre-C99 compilers.
2487
ed9265fc 24882012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2489
2490 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2491 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2492
3884d954
DA
24932012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2494
d209e2fb 2495 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2496 headers for buffer_defaults and buffer_local_symbols.
2497 Reported by Juanma Barranquero <lekktu@gmail.com>.
2498
ee28be33
SM
24992012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2500
2501 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2502 * lisp.h (enum pvec_type): Use fewer bits.
2503 (PSEUDOVECTOR_SIZE_BITS): New constant.
2504 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2505 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2506 change in pvec_type.
2507 (PSEUDOVECTOR_TYPEP): New macro.
2508 (TYPED_PSEUDOVECTORP): Use it.
2509 * fns.c (internal_equal): Adapt code to extract pvectype.
2510 * emacs.c (gdb_pvec_type): Update type.
2511 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2512 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2513 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2514 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2515 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2516 abusing vector->header.next.nbytes.
2517 (live_vector_p): Use PVEC_TYPE.
2518 (mark_object): Adapt code to extract pvectype. Use switch.
2519
c7f2cd7f
PE
25202012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2521
2522 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2523 Tighten new eassert a bit.
2524
8ce70ed2
DA
25252012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2526
2527 Fix compilation with --enable-gcc-warnings and -O1
2528 optimization level.
2529 * doprnt.c (doprnt): Change type of tem to int, initialize
2530 to avoid compiler warning. Add eassert.
2531 * search.c (simple_search): Initialize match_byte to avoid
2532 compiler warning. Add eassert.
2533
dea7f1e5
PE
25342012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2535
24a212eb
PE
2536 Avoid weird behavior with large horizontal scrolls.
2537 Without this change, for example, large hscroll values would
2538 mess up Emacs's display on Fedora 15 x86, presumably due to
2539 overflows in int calculations in the display code.
2540 Also, if buffers had long lines, Emacs would freeze.
2541 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2542 (set_window_hscroll): New function, containing the old guts of
2543 Fset_window_hscroll. Return the clipped value.
2544 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2545 This avoids the need to check against PTRDIFF_MAX.
2546
dea7f1e5
PE
2547 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2548
76046526
DA
25492012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2550
2551 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2552
39adff0d
PE
25532012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2554
63807d47
PE
2555 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2556 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2557 since GCC 4.4.6 issues a bogus warning for them.
2558
39adff0d
PE
2559 Fix bugs in file timestamp newness comparisons.
2560 * fileio.c (Ffile_newer_than_file_p):
2561 * lread.c (Fload): Use full timestamp resolution of files,
2562 not just the 1-second resolution, so that files that are only
2563 slightly newer still count as newer.
2564 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2565 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2566
dbeed9a6
PE
25672012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2568
2569 * fileio.c: Improve handling of file time marker. (Bug#11852)
2570 (special_mtime): New function.
2571 (Finsert_file_contents, Fverify_visited_file_modtime):
2572 Use it to set special mtime values consistently.
2573
636334d6
AS
25742012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2575
2576 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2577 marker for non-existing file. (Bug#11852)
2578
e2017fe2
GM
25792012-07-03 Glenn Morris <rgm@gnu.org>
2580
2581 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2582 and did not make it into globals.h).
2583
404dbd37
TT
25842012-07-03 Tom Tromey <tromey@redhat.com>
2585
2586 * window.c (Fset_window_margins, Fset_window_fringes)
2587 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2588 * textprop.c (Fprevious_property_change): No longer static.
2589 * syntax.c (Fsyntax_table_p): No longer static.
2590 * process.c (Fget_process, Fprocess_datagram_address): No longer
2591 static.
2592 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2593 * keyboard.c (Fcommand_execute): No longer static.
2594 Remove EXFUN.
2595 * insdel.c (Fcombine_after_change_execute): No longer static.
2596 * image.c (Finit_image_library): No longer static.
2597 * fileio.c (Fmake_symbolic_link): No longer static.
2598 * eval.c (Ffetch_bytecode): No longer static.
2599 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2600 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2601 No longer static.
404dbd37
TT
2602 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2603 static.
2604 * dired.c (Ffile_attributes): No longer static.
2605 * composite.c (Fcomposition_get_gstring): No longer static.
2606 * callproc.c (Fgetenv_internal): No longer static.
2607
2608 * ccl.h: Remove EXFUNs.
2609 * buffer.h: Remove EXFUNs.
2610 * dispextern.h: Remove EXFUNs.
2611 * intervals.h: Remove EXFUNs.
2612 * fontset.h: Remove EXFUN.
2613 * font.h: Remove EXFUNs.
2614 * dosfns.c (system_process_attributes): Remove EXFUN.
2615 * keymap.h: Remove EXFUNs.
2616 * lisp.h: Remove EXFUNs.
2617 * w32term.h: Remove EXFUNs.
2618 * window.h: Remove EXFUNs.
2619 * xsettings.h: Remove EXFUN.
2620 * xterm.h: Remove EXFUN.
2621
8e4fd1e1
GM
26222012-07-03 Glenn Morris <rgm@gnu.org>
2623
2624 * lisp.h (Frandom): Make it visible to C.
2625 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2626 buffer for invisible buffers. (Bug#1229)
2627
ca95b3eb
DA
26282012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2629
2630 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2631 values which aren't power of 2.
2632 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2633 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2634 accordingly.
2635
7555c33f
SM
26362012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2637
2638 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2639
2640 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2641
d12e8f5a
DA
26422012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2643
2644 * alloc.c (allocate_vector_block): Remove redundant
2645 calls to mallopt if DOUG_LEA_MALLOC is defined.
2646 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2647 avoid calls to mallopt if zero_vector is returned.
2648
296094c3
DA
26492012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2650
2651 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2652 is enabled, avoid dereferencing NULL current_sblock if
2653 running undumped.
2654
36429c89
DA
26552012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2656
2657 Cleanup basic buffer management.
2658 * buffer.h (struct buffer): Change layout to use generic vector
2659 marking code. Fix some comments. Change type of 'clip_changed'
2660 to bitfield. Remove unused #ifndef old.
2661 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2662 (GET_OVERLAYS_AT): Fix indentation.
2663 (for_each_per_buffer_object_at): New macro.
2664 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2665 (Fbuffer_local_variables): Use it.
2666 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2667 * alloc.c (allocate_buffer): Adjust to match new layout of
2668 struct buffer. Fix comment.
2669 (mark_overlay): New function.
2670 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2671 Lisp area of struct buffer.
2672 (mark_object): Use it. Adjust marking of misc objects
2673 and related comments.
2674
3b3e4cac
PE
26752012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2676
2677 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2678 wrapper that is not needed because the wrapped code is a no-op (zero
2679 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2680 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2681
cf5c0175
DA
26822012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2683
2684 * alloc.c (mark_buffer): Simplify. Remove prototype.
2685 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2686 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2687 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2688 redundant calls to mark_vectorlike for bool vectors.
2689
ca26824c
GM
26902012-06-30 Glenn Morris <rgm@gnu.org>
2691
2e4c5312
GM
2692 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2693
ca26824c
GM
2694 * epaths.in (PATH_SITELOADSEARCH): New.
2695 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2696 This is rather than relying on --enable-locallisppath elements
2697 having "site-lisp" in their names. (Bug#10208#25, 11658)
2698
0d23c240
EZ
26992012-06-30 Eli Zaretskii <eliz@gnu.org>
2700
c9240d7a
EZ
2701 * w32proc.c (sys_select): Accept and ignore one more argument.
2702
2703 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2704
0d23c240 2705 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2706 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2707
2708 * sysdep.c: Don't include dos.h and dosfns.h.
2709
2710 * process.c (sys_select):
2711 * msdos.c (sys_select): Accept one more argument and ignore it.
2712
2713 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2714 adapt data types and code to that.
2715
2716 * dosfns.c:
2717 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2718 which clashes with the gnulib function of the same name.
2719
af5a5a98
AS
27202012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2721
c5e4379c
AS
2722 * font.c (font_style_to_value, font_style_symbolic)
2723 (font_prop_validate_style): Add type checks for values in
2724 font_style_table.
2725
af5a5a98
AS
2726 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2727 argument.
2728 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2729 uses.
2730
8d38f461
EZ
27312012-06-29 Eli Zaretskii <eliz@gnu.org>
2732
2e5a6631
EZ
2733 * xdisp.c (try_window_id): Undo last change.
2734
8d38f461
EZ
2735 * w32.c (getwd): Adjust commentary about startup_dir.
2736 (init_environment): Always call sys_access, even in non-MSVC
2737 builds. Don't chdir to the directory of the Emacs executable.
2738 This undoes code from 1997 which was justified by the need to
2739 "avoid conflicts when removing and renaming directories". But its
2740 downside was that every relative file name was being interpreted
2741 relative to the directory of the Emacs executable, which can never
2742 be TRT. In particular, it broke sys_access when called with
2743 relative file names.
2744 (sys_access): Map GetLastError to errno.
2745
2af3565e
DA
27462012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2747
2748 * window.h (struct window): Change type of 'fringes_outside_margins'
2749 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2750 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2751 Adjust comment.
2752 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2753 to ptrdiff_t.
2754
c8d3a25c 27552012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2756
c8d3a25c
GM
2757 * gnutls.c (emacs_gnutls_handshake):
2758 Add QUIT to make the loop interruptible.
57570cd3 2759
c8d3a25c 27602012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2761
c8d3a25c
GM
2762 * charset.c (init_charset): Make lack of etc/charsets fatal.
2763
3e984ee8
DA
27642012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2765
2766 * editfns.c (region_limit): Fix type mismatch.
2767
ef884f23
DA
27682012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2769
2770 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2771 undefined. Convert from xassert to eassert.
2772 * nsmenu.m: Convert from xassert to eassert.
2773 * nsterm.m: Likewise.
2774
7d7e0027
SM
27752012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2776
2777 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2778
aa754e6a
PE
27792012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2780
2781 Avoid integer overflow on scroll-left and scroll-right.
2782 * window.c (HSCROLL_MAX): New macro.
2783 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2784 overflow when requested scroll falls outside ptrdiff_t range.
2785
80b00b08
DA
27862012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2787
2788 * window.h (struct window): Change type of 'hscroll',
2789 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2790 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2791 Adjust users accordingly.
2792 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2793 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2794 from EMACS_INT to ptrdiff_t.
2795 (make_window): Omit redundant initialization.
2796
62b2bcf6
JB
27972012-06-28 Juanma Barranquero <lekktu@gmail.com>
2798
2799 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2800
45942c7d
DA
28012012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2802
2803 * window.h (struct window): Change type of 'use_time' and
2804 'sequence_number' from Lisp_Object to int.
2805 * frame.c (make_frame): Adjust users accordingly.
2806 * print.c (print_object): Likewise.
2807 * window.c (select_window, Fwindow_use_time, make_parent_window)
2808 (make_window): Likewise.
2809
e509cfa6
DA
28102012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2811
2812 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2813 enabled with --enable-checking=[all,glyphs] configure option.
2814 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2815 adjust comments accordingly.
2816 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2817 undefined, adjust comments accordingly.
2818 * image.c: Likewise.
2819 * scroll.c: Likewise.
2820 * w32fns.c: Likewise.
2821 * w32term.c: Likewise.
2822 * xdisp.c: Likewise.
2823 * xfaces.c: Likewise.
2824 * xfns.c: Likewise.
2825 * xterm.c: Likewise.
2826
a54e2c05
DA
28272012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2828
2829 Generalize run-time debugging checks.
2830 * dispextern.h (XASSERTS): Remove.
2831 * fontset.c (xassert): Remove.
2832 Convert from xassert to eassert.
2833 * alloc.c: Convert from xassert to eassert.
2834 * bidi.c: Likewise.
2835 * dispnew.c: Likewise.
2836 * fns.c: Likewise.
2837 * fringe.c: Likewise.
2838 * ftfont.c: Likewise.
2839 * gtkutil.c: Likewise.
2840 * image.c: Likewise.
2841 * keyboard.c: Likewise.
2842 * menu.c: Likewise.
2843 * process.c: Likewise.
2844 * scroll.c: Likewise.
2845 * sound.c: Likewise.
2846 * term.c: Likewise.
2847 * w32console.c: Likewise.
2848 * w32fns.c: Likewise.
2849 * w32term.c: Likewise.
2850 * window.c: Likewise.
2851 * xdisp.c: Likewise.
2852 * xfaces.c: Likewise.
2853 * xfns.c: Likewise.
2854 * xselect.c: Likewise.
2855 * xterm.c: Likewise.
2856
1ec4b7b2
SM
28572012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2858
2859 * fns.c (maybe_resize_hash_table): Output message when growing the
2860 purify-hashtable.
2861
2014308a
DA
28622012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2863
2864 * alloc.c (allocate_string_data): Remove dead code.
2865 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2866 avoid GCC warning about unused macro.
2867
246155eb
DA
28682012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2869
2870 * alloc.c (allocate_string): Omit intervals initialization.
2871 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2872 as in make_pure_string and make_pure_c_string.
2873
43184b7b
DA
28742012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2875
d209e2fb 2876 * alloc.c (allocate_string): Fix last change.
43184b7b 2877
3fe6dd74
DA
28782012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2879
d209e2fb 2880 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2881 to memset, add explicit initialization where appropriate.
2882
1ba6038a
GM
28832012-06-27 Glenn Morris <rgm@gnu.org>
2884
2885 * lisp.mk (lisp): Remove paths.elc.
2886
c89926a5
CY
28872012-06-27 Chong Yidong <cyd@gnu.org>
2888
2889 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2890
ed6b3510
JW
28912012-06-26 John Wiegley <johnw@newartisans.com>
2892
1ec4b7b2 2893 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2894 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2895
ed6b3510
JW
2896 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2897 when building with Clang.
2898
8edd4a2b
SM
28992012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2900
2901 * eval.c (Fapply): Allow calling it with a single argument.
2902
f6f62d1b
EZ
29032012-06-26 Eli Zaretskii <eliz@gnu.org>
2904
2905 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2906 _stricmp and _strnicmp.
2907 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2908
62efea5e
DA
29092012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2910
2911 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2912 allocated window.
2913 (allocate_process): Likewise for new process.
8edd4a2b 2914 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2915 (allocate_frame): Likewise.
2916 * frame.c (make_frame): Omit redundant initialization.
2917 * window.c (make_parent_window): Use memset.
2918 (make_window): Omit redundant initialization.
2919 * process.c (make_process): Omit redundant initialization.
2920 * terminal.c (create_terminal): Likewise.
2921
42997f4d
DA
29222012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2923
2924 * term.c (delete_tty): Remove redundant call to memset.
2925
1130ecfc
DA
29262012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2927
2928 * alloc.c: Remove build_string.
2929 * lisp.h: Define build_string as static inline. This provides
2930 a better opportunity to optimize away calls to strlen when the
2931 function is called with compile-time constant argument.
2932 * image.c (imagemagick_error): Convert to build_string.
2933 * w32proc.c (sys_spawnve): Likewise.
2934 * xterm.c (x_term_init): Likewise.
2935
cf38a720
PE
29362012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2937
99027bdd
PE
2938 Use sprintf return value instead of invoking strlen on result.
2939 In the old days this wasn't portable, since some sprintf
2940 implementations returned char *. But they died out years ago and
2941 Emacs already assumes sprintf returns int.
2942 Similarly for float_to_string.
2943 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2944 * ccl.c (ccl_driver):
2945 * character.c (string_escape_byte8):
2946 * data.c (Fnumber_to_string):
2947 * doprnt.c (doprnt):
2948 * print.c (print_object):
2949 * xdisp.c (message_dolog):
2950 * xfns.c (syms_of_xfns):
2951 Use sprintf or float_to_string result to avoid need to call strlen.
2952 * data.c (Fnumber_to_string):
2953 Use make_unibyte_string, since the string must be ASCII.
2954 * lisp.h, print.c (float_to_string): Now returns int length.
2955 * term.c (produce_glyphless_glyph):
2956 Use sprintf result rather than recomputing it.
2957
cf38a720
PE
2958 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2959 * Makefile.in (ALL_CFLAGS):
2960 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2961 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2962
3511c784
DA
29632012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2964
0a08eb21 2965 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2966 strcasecmp if available.
2967 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2968
fb7da12e
AS
29692012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2970
2971 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2972 Avoid comma operator.
2973 * menu.c (push_submenu_start, push_submenu_end)
2974 (push_left_right_boundary, push_menu_pane): Likewise.
2975 * msdos.c (dos_rawgetc): Likewise.
2976
afa2ffd8
DA
29772012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2978
2979 * xfns.c (xic_create_fontsetname): Remove redundant calls
2980 to memset.
2981
b3b4476b
PE
29822012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2983
4495ff38
PE
2984 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2985 sprintf already null-terminates its output.
2986
b3b4476b
PE
2987 * xfns.c (x_window): Remove redundant cast.
2988
b00876c9
DA
29892012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2990
2991 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2992 `const char *' to `char *' to avoid compiler warning.
2993
d188e26b
PE
29942012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2995
885d1d74
PE
2996 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2997 instead of truncating it to 63 (admittedly a generous limit).
2998
d188e26b
PE
2999 * process.c: Fix spelling and caps in comments.
3000
e2f560b1
DN
30012012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3002
e86db54b 3003 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3004 * sysdep.c (setpgrp): Remove definition, not used in this file.
3005
7583a3a1
JB
30062012-06-24 Juanma Barranquero <lekktu@gmail.com>
3007
3008 * makefile.w32-in: Update dependencies.
3009
696056c2
EZ
30102012-06-24 Eli Zaretskii <eliz@gnu.org>
3011
3012 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3013 (SYSTIME_H): Add nt/inc/sys/time.h.
3014
3015 * systime.h [WINDOWSNT]: Include sys/time.h.
3016
3017 * s/ms-w32.h (struct timespec): Definition moved from
3018 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3019
845ca893
PE
30202012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3021
3022 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3023 * buffer.h (buffer_slot_type_mismatch):
3024 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3025 * eval.c (unwind_to_catch):
3026 * image.c (my_png_error, my_error_exit):
3027 * keyboard.c (quit_throw_to_read_char, user_error)
3028 (Fexit_recursive_edit, Fabort_recursive_edit):
3029 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3030 (wrong_type_argument, buffer_overflow, __executable_start)
3031 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3032 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3033 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3034 (fatal):
3035 (child_setup) [!DOS_NT]:
3036 * lread.c (end_of_file_error, invalid_syntax):
3037 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3038 * puresize.h (pure_write_error):
3039 * search.c (matcher_overflow):
3040 * sound.c (sound_perror, alsa_sound_perror):
3041 * sysdep.c, syssignal.h (croak):
3042 * term.c (maybe_fatal, vfatal):
3043 * textprop.c (text_read_only):
3044 * undo.c (user_error):
3045 * unexmacosx.c (unexec_error):
3046 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3047 Use _Noreturn rather than NO_RETURN.
3048 No need for separate decl merely because of _Noreturn.
3049 * sound.c (sound_warning, parse_sound):
3050 Remove unnecessary forward decls.
3051
f1dd8073
PE
30522012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3053
3054 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3055 * lisp.h (WAIT_READING_MAX): New macro.
3056 * dispnew.c (Fsleep_for, sit_for):
3057 * keyboard.c (kbd_buffer_get_event):
3058 * process.c (Faccept_process_output):
3059 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3060 This improves on the previous patch, which introduced a bug
3061 when time_t is unsigned and as wide as intmax_t.
3062 See <http://bugs.gnu.org/9000#51>.
3063
b82c1755
EZ
30642012-06-23 Eli Zaretskii <eliz@gnu.org>
3065
3066 * dispnew.c (sit_for, Fsleep_for):
3067 * keyboard.c (kbd_buffer_get_event):
3068 * process.c (Faccept_process_output): Avoid compiler warnings when
3069 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3070
ca300656
JB
30712012-06-23 Juanma Barranquero <lekktu@gmail.com>
3072
049ec95b
JB
3073 * makefile.w32-in: Update dependencies.
3074
ca300656
JB
3075 * w32.c (ltime): Add return type and declare static.
3076 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3077
db7b8d06
PE
30782012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3079
3080 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3081 Privately reported by Herbert J. Skuhra.
3082 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3083 All uses changed.
3084 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3085 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3086
0bd8297f
EZ
30872012-06-23 Eli Zaretskii <eliz@gnu.org>
3088
96512555
EZ
3089 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3090 last argument of make_unibyte_string.
3091
0bd8297f
EZ
3092 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3093 language ID in the event parameters.
3094
3095 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3096 event.code, not the obscure "character set ID".
3097
63def6b6
CY
30982012-06-23 Chong Yidong <cyd@gnu.org>
3099
3100 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3101
e8a02204
EZ
31022012-06-23 Eli Zaretskii <eliz@gnu.org>
3103
388cdec0
EZ
3104 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3105 * w32.c (fdutimens): New function.
3106
3107 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3108
3109 * s/ms-w32.h (pselect): Redirect to sys_select.
3110
3111 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3112
e8a02204
EZ
3113 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3114 in the logic of incrementing and decrementing the value of
3115 use_relocatable_buffers.
3116
d054f3fb
PE
31172012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3118
3119 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3120 Privately reported by Herbert J. Skuhra.
3121 [__FreeBSD__]: Remove "*/" typo after "#include".
3122 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3123 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3124 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3125 Don't assume EMACS_TIME and struct timeval are the same type.
3126
d35af63c
PE
31272012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3128
3129 Support higher-resolution time stamps (Bug#9000).
3130 The time stamps are only nanosecond-resolution at the C level,
3131 since that's the best that any real-world system supports now.
3132 But they are picosecond-resolution at the Lisp level, as that's
3133 easy, and leaves room for future OS improvements.
3134
3135 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3136 (LIBES): Use it.
3137
3138 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3139 Don't get current time unless it's needed.
3140
3141 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3142 now provides it if it's absent.
3143 (start_atimer): Port to higher-res time stamps.
3144 Check for time stamp overflow. Don't get current time more
3145 often than is needed.
3146
3147 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3148 Include systime.h, not time.h.
3149 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3150
3151 * dired.c: Include stat-time.h.
3152 (Ffile-attributes): File times now have higher resolution.
3153
3154 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3155 (struct image): Timestamp now has higher resolution.
3156
3157 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3158 has at least microseconds now. All uses removed.
3159 (update_frame, update_single_window, update_window, update_frame_1)
3160 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3161
3162 * editfns.c (time_overflow): Now extern.
3163 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3164 (float-time, Fformat_time_string, Fcurrent_time_string)
3165 (Fcurrent_time_zone): Accept and generate higher-resolution
3166 time stamps.
3167 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3168 (decode_time_components, lisp_seconds_argument): New functions.
3169 (make_time): Now static.
3170 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3171 Report an error if the time is invalid, rather than having the caller
3172 do that.
3173
3174 * fileio.c: Include <stat-time.h>
3175 (Fcopy_file): Copy higher-resolution time stamps.
3176 Prefer to set the time stamp via a file descriptor if that works.
3177 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3178 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3179 (Fvisited_file_modtime, Fset_visited_file_modtime):
3180 Support higher-resolution time stamps.
3181
3182 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3183
3184 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3185
3186 * image.c (prepare_image_for_display, clear_image_cache)
3187 (lookup_image): Port to higer-resolution time stamps.
3188
3189 * keyboard.c (start_polling, bind_polling_period):
3190 Check for time stamp overflow.
3191 (read_char, kbd_buffer_get_event, timer_start_idle)
3192 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3193 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3194 Port to higher-resolution time stamps. Do not assume time_t is signed.
3195 (decode_timer): New function. Timers are now vectors of length 9,
3196 not 8, to accommodate the picosecond component.
3197 (timer_check_2): Use it.
3198
3199 * nsterm.m (select_timeout, timeval_subtract): Remove.
3200 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3201 as they're a bit more accurate and handle overflow better.
3202 (ns_select): Change prototype to be compatible with pselect.
3203 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3204 * nsterm.h (ns_select): Adjust prototype.
3205
3206 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3207 us-resolution time stamps.
3208 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3209
3210 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3211
3212 * lisp.h (time_overflow): New decl.
3213 (wait_reading_process_output): First arg is now intmax_t, not int,
3214 to accommodate larger waits.
3215
3216 * process.h (struct Lisp_Process.read_output_delay):
3217 Now counts nanoseconds, not microseconds.
3218 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3219 EMACS_HAS_USECS.
3220 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3221 (wait_reading_process_output):
3222 Port to ns-resolution time stamps.
3223 (Faccept_process_output, wait_reading_process_output):
3224 Check for time stamp overflow. Do not assume time_t is signed.
3225 (select_wrapper): Remove; we now use pselect.
3226 (Fprocess_attributes): Now generates ns-resolution time stamps.
3227
3228 * sysdep.c: Include utimens.h. Don't include utime.h
3229 or worry about struct utimbuf; gnulib does that for us now.
3230 (gettimeofday): Remove; gnulib provides a substitute.
3231 (make_timeval): New function.
3232 (set_file_times): Now sets ns-resolution time stamps.
3233 New arg FD; all uses changed.
3234 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3235 (system_process_attributes):
3236 Now returns ns-resolution time stamp. All uses changed.
3237 Check for time stamp overflow.
3238
3239 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3240 provides a substitute now.
3241
3242 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3243 since it guarantees struct timespec.
3244 (EMACS_TIME): Now struct timespec, so that we can support
3245 ns-resolution time stamps.
3246 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3247 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3248 (EMACS_USECS): Remove.
3249 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3250 so multiply the arg by 1000 before storing it.
3251 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3252 New macros.
3253 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3254 Port to ns-resolution time stamps.
3255 (EMACS_TIME_NEG_P): Remove; replaced by....
3256 (EMACS_TIME_SIGN): New macro.
3257 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3258 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3259 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3260 (make_timeval, make_lisp_time, decode_time_components): New decls.
3261 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3262 that it mishandled time_t overflow. You can't compare by subtracting!
3263 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3264 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3265
3266 * term.c: Include <sys/time.h>.
3267 (timeval_to_Time): New function, for proper overflow wraparound.
3268 (term_mouse_position, term_mouse_click): Use it.
3269
3270 * undo.c (record_first_change): Support higher-resolution time stamps
3271 in the undo buffer.
3272 (Fprimitive_undo): Use them when restoring time stamps.
3273
3274 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3275 (w32_get_internal_run_time):
3276 Port to higher-resolution Emacs time stamps.
3277 (ltime): Now accepts single 64-bit integer, as that's more convenient
3278 for callers.
3279
3280 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3281
3282 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3283 for compatibility with pselect. Support ns-resolution time stamps.
3284
3285 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3286
3287 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3288 Check for time stamp overflow, and support ns-resolution time stamps.
3289
3290 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3291 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3292 (timeval_subtract): Remove; no longer needed.
3293 (XTflash, XTring_bell, x_wait_for_event):
3294 Port to ns-resolution time stamps. Don't assume time_t is signed.
3295
b6a92dfe
CY
32962012-06-22 Chong Yidong <cyd@gnu.org>
3297
3298 * xdisp.c (x_consider_frame_title): Revert last change.
3299
d251c37c
EZ
33002012-06-22 Eli Zaretskii <eliz@gnu.org>
3301
3302 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3303 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3304 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3305 staticidx goes up to 1597 out of 1600 = 0x640.)
3306
f10deafb
PE
33072012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3308
3309 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3310 Otherwise, the umask might be mistakenly 0 while handling input signals.
3311
ec6de1e2
SM
33122012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3313
3314 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3315
28be1ada
DA
33162012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3317
3318 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3319 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3320 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3321 access to `contents' member of Lisp_Vector objects with AREF and ASET
3322 where appropriate.
3323
c6bf3022
CY
33242012-06-19 Chong Yidong <cyd@gnu.org>
3325
3326 * frame.c (delete_frame): When selecting a frame on a different
3327 text terminal, do not alter the terminal's top-frame.
3328
3329 * xdisp.c (format_mode_line_unwind_data): Record the target
3330 frame's selected window and its terminal's top-frame.
3331 (unwind_format_mode_line): Restore them.
3332 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3333 Callers changed.
3334 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3335 since tty frames can be explicitly named.
3336 (prepare_menu_bars): Likewise.
3337
3338 * term.c (Ftty_top_frame): New function.
3339
defd4196
PE
33402012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 Port byte-code-meter to modern targets.
3343 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3344 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3345 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3346 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3347 (METER_1, METER_2): Simplify.
3348
1053a871
SM
33492012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3350
3351 * data.c (Fdefalias): Return `symbol' (bug#11686).
3352
b7e8d081
MR
33532012-06-18 Martin Rudalics <rudalics@gmx.at>
3354
3355 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3356 gets killed during executing of this function (Bug#11665).
3357 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3358 (Vkill_buffer_query_functions): In doc-string say that functions
3359 run by this hook should not change the current buffer.
3360
7ea2b339
PE
33612012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3362
3363 Fix recently-introduced process.c problems found by static checking.
3364 * process.c (write_queue_push, write_queue_pop, send_process):
3365 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3366 (write_queue_pop): Fix pointer signedness problem.
3367 (send_process): Remove unused local.
3368
96a313a1
CY
33692012-06-17 Chong Yidong <cyd@gnu.org>
3370
3371 * xdisp.c (redisplay_internal): No need to redisplay terminal
3372 frames that are not on top.
3373
20ca2e94
TN
33742012-06-17 Troels Nielsen <bn.troels@gmail.com>
3375
3376 * process.c (make_process): Initialize write_queue.
3377 (write_queue_push, write_queue_pop): New functions.
3378 (send_process): Use them to maintain correct ordering of process
3379 writes (Bug#10815).
3380
9a900ca9
PE
33812012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3382
310fbfa8
PE
3383 * lisp.h (eassert): Assume C89 or later.
3384 This removes the need for CHECK.
3385 (CHECK): Remove. Its comments about always evaluating its
3386 argument were confusing, as 'eassert' typically does not evaluate
3387 its argument.
3388
27bb1ca4
PE
3389 * coding.c (produce_chars): Use ptrdiff_t, not int.
3390
9a900ca9
PE
3391 * xterm.c (x_draw_underwave): Check for integer overflow.
3392 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3393
41b7f8bc 33942012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3395
3396 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3397 referenced (Bug#11583).
3398
9b0e3eba
AA
33992012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3400
3401 Implement wave-style variant of underlining.
3402 * dispextern.h (face_underline_type): New enum.
3403 (face): Add field for underline type.
3404 * nsterm.m (ns_draw_underwave): New function.
3405 (ns_draw_text_decoration): Use it.
3406 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3407 New functions.
3408 (x_draw_glyph_string): Use them.
3409 * xfaces.c (Qline, Qwave): New Lisp objects.
3410 (check_lface_attrs, merge_face_ref)
1053a871
SM
3411 (Finternal_set_lisp_face_attribute, realize_x_face):
3412 Handle wave-style underline face attributes.
9b0e3eba
AA
3413 * xterm.c (x_draw_underwave): New function.
3414 (x_draw_glyph_string): Use it.
3415
0fb52f11
JB
34162012-06-16 Juanma Barranquero <lekktu@gmail.com>
3417
3418 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3419 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3420 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3421 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3422 ($(BLD)/w32select.$(O)): Update dependencies.
3423
e5560ff7
AS
34242012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3425
3426 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3427 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3428 * character.c (_fetch_multibyte_char_p): Remove.
3429 * alloc.c: Include "character.h" before "buffer.h".
3430 * bidi.c: Likewise.
3431 * buffer.c: Likewise.
3432 * bytecode.c: Likewise.
3433 * callint.c: Likewise.
3434 * callproc.c: Likewise.
3435 * casefiddle.c: Likewise.
3436 * casetab.c: Likewise.
3437 * category.c: Likewise.
3438 * cmds.c: Likewise.
3439 * coding.c: Likewise.
3440 * composite.c: Likewise.
3441 * dired.c: Likewise.
3442 * dispnew.c: Likewise.
3443 * doc.c: Likewise.
3444 * dosfns.c: Likewise.
3445 * editfns.c: Likewise.
3446 * emacs.c: Likewise.
3447 * fileio.c: Likewise.
3448 * filelock.c: Likewise.
3449 * font.c: Likewise.
3450 * fontset.c: Likewise.
3451 * fringe.c: Likewise.
3452 * indent.c: Likewise.
3453 * insdel.c: Likewise.
3454 * intervals.c: Likewise.
3455 * keyboard.c: Likewise.
3456 * keymap.c: Likewise.
3457 * lread.c: Likewise.
3458 * macros.c: Likewise.
3459 * marker.c: Likewise.
3460 * minibuf.c: Likewise.
3461 * nsfns.m: Likewise.
3462 * nsmenu.m: Likewise.
3463 * print.c: Likewise.
3464 * process.c: Likewise.
3465 * regex.c: Likewise.
3466 * region-cache.c: Likewise.
3467 * search.c: Likewise.
3468 * syntax.c: Likewise.
3469 * term.c: Likewise.
3470 * textprop.c: Likewise.
3471 * undo.c: Likewise.
3472 * unexsol.c: Likewise.
3473 * w16select.c: Likewise.
3474 * w32fns.c: Likewise.
3475 * w32menu.c: Likewise.
3476 * window.c: Likewise.
3477 * xdisp.c: Likewise.
3478 * xfns.c: Likewise.
3479 * xmenu.c: Likewise.
3480 * xml.c: Likewise.
3481 * xselect.c: Likewise.
3482
2f07e6af
EZ
34832012-06-16 Eli Zaretskii <eliz@gnu.org>
3484
1053a871
SM
3485 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3486 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3487 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3488 row.
3489 (handle_face_prop): Use chunk-relative overlay string index when
3490 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3491 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3492 the rightmost. (Bug#11720)
2f07e6af 3493
29b83cec
AS
34942012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3495
3496 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3497 (CATEGORY_MEMBER): Enforce 1/0 value.
3498 * category.c (_temp_category_set): Remove.
3499
4c5501e9
EZ
35002012-06-16 Eli Zaretskii <eliz@gnu.org>
3501
3502 * window.c (Fdelete_other_windows_internal)
3503 (Fdelete_window_internal): Don't access frame's mouse highlight
3504 info of the initial frame. (Bug#11677)
3505
2b570124
PE
35062012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3507
e93864f9
PE
3508 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3509 Assume USE_2_TAGS_FOR_INTS.
3510 (xreload): Adjust $tagmask width to match recent lisp.h change.
3511
2b570124
PE
3512 Simplify lisp.h in minor ways that should not affect code.
3513 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3514 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3515 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3516 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3517 (INTTYPEBITS): New macro, for clarity.
3518 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3519 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3520 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3521 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3522 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3523
81755f69
JB
35242012-06-13 Juanma Barranquero <lekktu@gmail.com>
3525
3526 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3527
16192a57
GM
35282012-06-13 Glenn Morris <rgm@gnu.org>
3529
3530 * s/bsd-common.h (BSD4_3):
3531 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3532
646b5f55
AS
35332012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3534
3535 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3536 instead of union.
3537 (XLI, XIL): Define.
1053a871
SM
3538 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3539 Use them.
3540 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3541 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3542 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3543 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3544 * frame.c (delete_frame): Remove outdated comment.
3545 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3546 USE_LISP_UNION_TYPE.
3547 (Fw32_unregister_hot_key): Likewise.
3548 (Fw32_toggle_lock_key): Likewise.
3549 * w32menu.c (add_menu_item): Likewise.
3550 (w32_menu_display_help): Use XIL instead of checking
3551 USE_LISP_UNION_TYPE.
3552 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3553 (init_heap): Likewise.
3554 * w32term.c (w32_read_socket): Update comment.
3555
1d3823c9
GM
35562012-06-13 Glenn Morris <rgm@gnu.org>
3557
c62ff706
GM
3558 * s/usg5-4-common.h, src/s/unixware.h:
3559 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3560
1d3823c9
GM
3561 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3562
bfe3e0a2
PE
35632012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3564
3565 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3566 * alloc.c (make_number) [!defined make_number]:
3567 Remove, as lisp.h always defines this now.
3568 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3569 (roundup_size): Verify that it is a power of 2.
3570 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3571 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3572 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3573 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3574 USE_LSB_TAG now is always defined to be either 0 or 1.
3575 All uses changed.
3576 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3577 code works fine either way, and efficiency is not a concern here,
3578 as the union type is for debugging, not for production.
3579 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3580 Use an inline function on all platforms when using the union type,
3581 since this is simpler and 'static inline' can be used portably
3582 within Emacs now.
3583 (LISP_INITIALLY_ZERO): New macro.
3584 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3585 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3586
45fa9c0f
GM
35872012-06-12 Glenn Morris <rgm@gnu.org>
3588
b4492cba
GM
3589 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3590
3591 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3592
45fa9c0f
GM
3593 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3594 Move BROKEN_SIGIO to configure.
3595
3596 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3597 Move NO_TERMIO to configure.
3598
0e25d334
CY
35992012-06-12 Chong Yidong <cyd@gnu.org>
3600
3601 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3602 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3603 MagickExportImagePixels is undefined.
3604
43682bb6
PE
36052012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3606
3607 * image.c (imagemagick_load_image): Remove unused label.
3608
a9be7d2b
GM
36092012-06-11 Glenn Morris <rgm@gnu.org>
3610
3611 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3612 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3613 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3614 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3615
3017f87f
SM
36162012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3617
3618 * alloc.c (make_byte_code): New function.
3619 (Fmake_byte_code): Use it. Don't purify here.
3620 * lread.c (read1): Use it as well to avoid extra allocation.
3621
1b9b4cf4
CY
36222012-06-11 Chong Yidong <cyd@gnu.org>
3623
3624 * image.c (imagemagick_load_image): Implement transparency.
3625
95988fcf
AS
36262012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3627
3628 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3629 account for preceding backslashes. (Bug#11663)
3630
cd4eb164
CY
36312012-06-09 Chong Yidong <cyd@gnu.org>
3632
3633 * term.c: Support italics in capable terminals (Bug#9652).
3634 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3635 (turn_on_face): Output using TS_enter_italic_mode if available.
3636 Don't handle unused blinking and alt-charset cases.
3637 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3638 and tty_alt_charset_p cases.
3639 (tty_capable_p, init_tty): Support italics.
3640
3641 * termchar.h (struct tty_display_info): Add field for italics.
3642 Remove unused blink field.
3643
3644 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3645 Handle slant.
3646
3647 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3648 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3649 tty_alt_charset_p. Add tty_italic_p.
3650
ff88beb8
MA
36512012-06-09 Michael Albinus <michael.albinus@gmx.de>
3652
3653 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3654 dbus_type_is_basic if available.
3655 (xd_extract_signed, xd_extract_unsigned): Rename from
3656 extract_signed and extract_unsigned, respectively. Adapt callers.
3657
44286096
CY
36582012-06-09 Chong Yidong <cyd@gnu.org>
3659
1682701f
CY
3660 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3661
44286096
CY
3662 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3663 case (Bug#9752).
3664
d86feb17
PE
36652012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3666
3667 * xdisp.c (vmessage): Treat frame message as multibyte.
3668 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3669 would generate the diagnostic "Making \302\247 buffer-local while
3670 let-bound!".
3671
d5c20fe8
EZ
36722012-06-08 Eli Zaretskii <eliz@gnu.org>
3673
3674 * dispnew.c (showing_window_margins_p): Undo last change, which
3675 was done due to an inadvertent commit.
3676 (adjust_frame_glyphs_for_frame_redisplay): Do call
3677 showing_window_margins_p.
3678
513749ee
SM
36792012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3680
3681 * eval.c (Fmake_var_non_special): New primitive.
3682 (syms_of_eval): Defsubr it.
3683 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3684
d4a8f5c1
JB
36852012-06-08 Juanma Barranquero <lekktu@gmail.com>
3686
3687 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3688 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3689
8bbbc977
EZ
36902012-06-08 Eli Zaretskii <eliz@gnu.org>
3691
3692 * alloc.c (allocate_vectorlike): Fix last change.
3693
f3372c87
DA
36942012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3695
3696 Block-based vector allocation of small vectors.
3697 * lisp.h (struct vectorlike_header): New field `nbytes',
3698 adjust comment accordingly.
3699 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3700 to denote vector blocks. Adjust users (live_vector_p,
3701 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3702 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3703 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3704 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3705 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3706 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3707 (roundup_size): New constant.
3708 (struct vector_block): New data type.
3709 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3710 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3711 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3712 (sweep_vectors): New functions.
3713 (allocate_vectorlike): Return `zero_vector' as the only vector of
3714 0 items. Allocate new vector from block if vector size is less than
3715 or equal to VBLOCK_BYTES_MAX.
3716 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3717 (init_alloc_once): Add call to init_vectors.
3718
4f18a4ed
SM
37192012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3720
3721 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3722
86f158bc
PE
37232012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3724
3725 * doprnt.c (doprnt): Truncate multibyte char correctly.
3726 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3727 would mishandle a string argument "Xc" if X was a multibyte
3728 character of length 2: it would truncate after X's first byte
3729 rather than including all of X.
3730
c5cfcbe0
CY
37312012-06-06 Chong Yidong <cyd@gnu.org>
3732
3733 * buffer.c (word_wrap): Doc fix.
3734
c05cf390
PE
37352012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3736
3737 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3738
0c3461de
GM
37392012-06-03 Glenn Morris <rgm@gnu.org>
3740
3741 * xdisp.c (tool-bar-style): Doc fix.
3742
c71232db
UM
37432012-06-03 Ulrich Müller <ulm@gentoo.org>
3744
3745 * Makefile.in (PAXCTL): Define.
3746 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3747 binary via PaX flags if the paxctl utility is available.
3748 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3749 Restore PaX flags to their default. (Bug#11398)
3750
383f7350
CY
37512012-06-03 Chong Yidong <cyd@gnu.org>
3752
3753 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3754 buffer (Bug#11226).
3755
5f2c76c6
CY
37562012-06-03 Chong Yidong <cyd@gnu.org>
3757
3758 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3759 (note_mode_line_or_margin_highlight): If there is no help echo,
3760 use mode-line-default-help-echo. Handle the case where the mouse
3761 position is past the end of the mode line string.
3762
3763 * buffer.c (buffer_local_value_1): New function, split from
3764 Fbuffer_local_value; can return Qunbound.
3765 (Fbuffer_local_value): Use it.
3766 (Vmode_line_format): Docstring tweaks.
3767
773d47f6
PE
37682012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3769
3770 * sysdep.c (system_process_attributes): Improve comment.
3771
f2d6a3df
SM
37722012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3773
3774 * keyboard.c: Export real-this-command to Elisp.
3775 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3776 and DEFVAR it. Update all users.
3777
63810350
PE
37782012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3779
7bd5c1f4
PE
3780 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3781
63810350
PE
3782 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3783 Convert pctcpu and pctmem to Lisp float properly.
3784 Let the compiler fold better, as 100.0/0x8000 is exact.
3785
a2821611
AS
37862012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3787
3788 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3789 cons_block.
3790
5fceba1d
PE
37912012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3792
3793 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3794
c98ff5dd
DA
37952012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3796
3797 For a 'struct window', replace some Lisp_Object fields to
3798 bitfields where appropriate, remove unused fields.
3799 * window.h (struct window): Remove unused 'last_mark_x' and
3800 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3801 change it's type from Lisp_Object to bitfield.
3802 Change type of 'force_start', 'optional_new_start',
3803 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3804 fields from Lisp_Object to bitfield. Adjust users accordingly.
3805
ca34e0be
PE
38062012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 Pacify gcc -Wdouble-precision when using Xaw.
3809 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3810 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3811 Use 'float' consistently, rather than 'float' in most places
3812 and 'double' in a couple of places.
3813
efc00ab1 38142012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3815
3816 * xdisp.c (handle_stop): Detect whether we have overlay strings
3817 loaded by testing it->current.overlay_string_index to be
3818 non-negative, instead of checking whether n_overlay_strings is
3819 positive. (Bug#11587)
3820
efc00ab1 38212012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3822
3823 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3824
3825 * doc.c (Fsubstitute_command_keys): Doc fix.
3826
efc00ab1 38272012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3828
3829 * search.c (search_buffer): Remove calls to
3830 r_alloc_inhibit_buffer_relocation, as it is now called by
3831 maybe_unify_char, which was the cause of relocation of buffer text
3832 in bug#11519.
3833
efc00ab1 38342012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3835
3836 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3837 for the duration of call to load_charset, to avoid problems with
3838 callers of maybe_unify_char that access buffer text through C
3839 pointers.
3840
3841 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3842 decrement the inhibition flag, instead of just setting or
3843 resetting it.
3844
ba93a187
PE
38452012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3846
3847 Remove obsolete '#define static' cruft.
3848 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3849 This #undef was "temporary" in 2000; it is no longer needed
3850 now that '#define static' has gone away.
3851 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3852 (gray_bitmap_bits): Remove; no longer needed.
3853 All uses replaced with definiens.
3854 * xterm.c: Include "bitmaps/gray.xbm".
3855
9e4bf381
PE
38562012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3857
3858 Clean up __executable_start, monstartup when --enable-profiling.
3859 The following changes affect the code only when profiling.
3860 * dispnew.c (__executable_start): Rename from safe_bcopy.
3861 Define only on platforms that need it.
3862 * emacs.c: Include <sys/gmon.h> when profiling.
3863 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3864 (__executable_start): Remove decl, since lisp.h does it now.
3865 (safe_bcopy): Remove decl; no longer has that name.
3866 (main): Coalesce #if into single bit of code, for simplicity.
3867 Cast pointers to uintptr_t, since standard libraries want integers
3868 and not pointers.
3869 * lisp.h (__executable_start): New decl.
3870
32d72c2f
GM
38712012-05-31 Glenn Morris <rgm@gnu.org>
3872
3873 * image.c (Fimagemagick_types): Doc fix.
3874
baac5bc7
JM
38752012-05-30 Jim Meyering <meyering@redhat.com>
3876
3877 * callproc.c (Fcall_process_region): Include directory component
3878 in mkstemp error message (Bug#11586).
3879
72cb32cf
PE
38802012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3881
3882 * alloc.c, lisp.h (make_pure_vector): Now static.
3883
61b108cc
SM
38842012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3885
3886 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3887 Move to byte-run.el.
3888 (Fautoload): Do the hash-doc more carefully.
3889 * data.c (Fdefalias): Purify definition, except for keymaps.
3890 (Qdefun): Move from eval.c.
3891 * lisp.h (Qdefun): Remove.
3892 * lread.c (read1): Tiny simplification.
3893
471fe23d
TN
38942012-05-29 Troels Nielsen <bn.troels@gmail.com>
3895
934f3f58 3896 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3897 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3898 Bug#9642, but explicitly check that the buffer the overlay would
3899 be moved to is live and rearrange lines to make sure that errors
3900 will not put the overlay in an inconsistent state.
3901 (Fdelete_overlay): Cosmetics.
3902
85d0efd1
EZ
39032012-05-28 Eli Zaretskii <eliz@gnu.org>
3904
3905 * w32term.c (my_bring_window_to_top): New function.
3906 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3907 could be different from the original one.
3908 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3909 (Bug#11513)
3910
3911 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3912 by calling BringWindowToTop.
3913
3914 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3915 (WM_EMACS_END): Increase by one.
3916
da92a98c
PE
39172012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3918
3919 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3920 This avoids undefined behavior that might cause the eassert
3921 to not catch an out-of-range value.
3922
74d1f848
JB
39232012-05-28 Juanma Barranquero <lekktu@gmail.com>
3924
3925 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3926 Update dependencies.
3927
9e1a06fc
EZ
39282012-05-27 Eli Zaretskii <eliz@gnu.org>
3929
3930 * bidi.c (bidi_mirror_char): Fix last change.
3931
f3dd7312
AS
39322012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3933
3934 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3935 when referring to sectname field in printf format.
3936
81899c91
PE
39372012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3938
57b81a9f
PE
3939 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3940 Only r_alloc_inhibit_buffer_relocation needed to be added;
3941 the others were already declared.
3942
81899c91
PE
3943 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3944 before checking whether it's out of range. Put the check inside
3945 eassert. See
3946 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3947
33017faf 39482012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3949
3950 * callproc.c (Fcall_process): Restore a line that was accidentally
3951 commented out in the 2011-02-13 change (bug#11547).
3952
33017faf 39532012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3954
3955 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3956 defined on ralloc.c.
3957
3958 * buffer.c [REL_ALLOC]: Remove prototypes of
3959 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3960 they are now on lisp.h.
3961
3962 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3963
3964 * search.c (search_buffer): Use it to inhibit relocation of buffer
3965 text while re_search_2 is doing its job, because re_search_2 is
3966 passed C pointers to buffer text. (Bug#11519)
3967
23415acf
EZ
3968 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3969 Update value to 24.
3970
44e27368
EZ
3971 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3972 state after an additional call to move_it_in_display_line_to, keep
3973 the values of it->max_ascent and it->max_descent found for the
3974 entire line.
3975 (pos_visible_p): Revert the comparison against bottom_y to what it
3976 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3977 (Bug#11464)
3978
c1892f11
PE
39792012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3980
3981 Fix coding-related core dumps with gcc -ftrapv.
3982 The code was computing A - B, where A and B are pointers, and B is
3983 random garbage. This can lead to core dumps on platforms that
3984 have special pointer registers, and it also leads to core dumps on
3985 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3986 A - B only when B is initialized properly.
3987 * coding.c (coding_set_source, coding_set_destination): Return void.
3988 (coding_change_source, coding_change_destinations): New functions,
3989 with the old behaviors of coding_set_source and coding_set_destination.
3990 All callers that need an offset changed to use these new functions.
3991
eb7afdad
GM
39922012-05-26 Glenn Morris <rgm@gnu.org>
3993
3994 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3995
f12fdf02
EZ
39962012-05-26 Eli Zaretskii <eliz@gnu.org>
3997
53a63be6 3998 Extend mouse support on W32 text-mode console.
61b108cc
SM
3999 * xdisp.c (draw_row_with_mouse_face):
4000 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4001
eb3f6f01 4002 * w32console.c: Include window.h.
61b108cc
SM
4003 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4004 New functions.
eb3f6f01
EZ
4005 (initialize_w32_display): Initialize mouse-highlight data.
4006
53a63be6
EZ
4007 * w32inevt.c: Include termchar.h and window.h.
4008 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4009 moves, call note_mouse_highlight. If help_echo changed, call
4010 gen_help_event to produce help-echo message in the echo area.
4011 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4012 highlight info.
4013
4cfd81f6
PE
40142012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4015
4016 * lread.c (read1): Simplify slightly to avoid an overflow warning
4017 with GCC 4.7.0 on x86-64.
4018
4446092a
EZ
40192012-05-26 Eli Zaretskii <eliz@gnu.org>
4020
4021 * bidi.c (bidi_mirror_char): Revert last change: an int is
4022 definitely wide enough here.
4023
42b2a986 40242012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4025
42b2a986 4026 Fix integer width and related bugs (Bug#9874).
eb106a49 4027 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4028 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4029 (string_bytes, check_sblock, allocate_string_data):
4030 (compact_small_strings, Fmake_bool_vector, make_string)
4031 (make_unibyte_string, make_multibyte_string)
4032 (make_string_from_bytes, make_specified_string)
4033 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4034 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4035 (mark_vectorlike):
4036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4037 (allocate_pseudovector):
4038 Use int, not EMACS_INT, where int is wide enough.
4039 (inhibit_garbage_collection, Fgarbage_collect):
4040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4041 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4042 int might not be wide enough.
4043 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4044 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4045 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4046 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4047 (bidi_level_of_next_char, bidi_move_to_visually_next):
4048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4049 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4050 (Fkill_buffer, Fset_buffer_major_mode)
4051 (advance_to_char_boundary, Fbuffer_swap_text)
4052 (Fset_buffer_multibyte, overlays_at, overlays_in)
4053 (overlay_touches_p, struct sortvec, record_overlay_string)
4054 (overlay_strings, recenter_overlay_lists)
4055 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4056 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4057 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4058 (Foverlay_recenter, last_overlay_modification_hooks_used)
4059 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4061 (validate_region): Omit unnecessary test for b <= e,
4062 since that's guaranteed by the previous test.
d311d28c
PE
4063 (adjust_overlays_for_delete): Avoid pos + length overflow.
4064 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4065 (report_overlay_modification):
4066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4067 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4068 Omit pointer cast, which isn't needed anyway, and doesn't work
4069 after the EMACS_INT -> ptrdiff_t change.
02481186 4070 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4071 * buffer.h: Adjust decls to match defn changes elsewhere.
4072 (struct buffer_text, struct buffer):
4073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4074 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4075 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4076 not int, to avoid needless 32-bit limit on 64-bit hosts.
4077 (exec_byte_code): Use tighter memory-full test, one that checks
4078 for alloca overflow. Don't compute the address of the object just
4079 before an array, as that's not portable. Use EMACS_INT, not
4080 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4081 * callint.c (Fcall_interactively):
4082 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4083 * callproc.c (call_process_kill, Fcall_process):
4084 Don't assume pid_t fits into an Emacs fixnum.
4085 (call_process_cleanup, Fcall_process, child_setup):
4086 Don't assume pid_t fits into int.
4087 (call_process_cleanup, Fcall_process, delete_temp_file)
4088 (Fcall_process_region):
4089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4090 (Fcall_process): Simplify handling of volatile integers.
4091 Use int, not EMACS_INT, where int will do.
4092 * casefiddle.c (casify_object, casify_region, operate_on_word)
4093 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4095 (casify_object): Avoid integer overflow when overallocating buffer.
4096 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4097 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4098 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4099 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4100 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4101 integers are now checked earlier. All uses replaced with XINT.
4102 (ccl_driver):
4103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4104 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4105 (ccl_driver, Fregister_code_conversion_map):
4106 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4107 (resolve_symbol_ccl_program): Check that vector header is in range.
4108 Always copy the vector, so that we can check its contents reliably
4109 now rather than having to recheck each instruction as it's being
4110 executed. Check that vector words fit in 'int'.
4111 (ccl_get_compiled_code, Fregister_ccl_program)
4112 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4113 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4114 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4115 contents are in range.
4116 (Fccl_execute_on_string): Check that status is in range.
4117 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4118 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4119 Accept and return EMACS_INT, not int, because callers can pass values
4120 out of 'int' range.
4121 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4122 (multibyte_chars_in_text, parse_str_as_multibyte)
4123 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4124 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4125 (string_escape_byte8, Fget_byte):
4126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4127 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4128 avoid mishandling large integers.
4129 * character.h: Adjust decls to match defn changes elsewhere.
4130 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4131 (Ffind_charset_region):
4132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4133 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4134 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4135 Don't assume fixnum fits in int.
d311d28c
PE
4136 (load_charset_map_from_vector, Fmap_charset_chars):
4137 Remove now-unnecessary CHECK_NATNUMs.
4138 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4139 Don't rely on undefined behavior with signed left shift overflow.
4140 Don't assume unsigned int fits into fixnum, or that fixnum fits
4141 into unsigned int. Don't require max_code to be a valid fixnum;
4142 that's not true for gb10830 4-byte on a 32-bit host. Allow
4143 invalid_code to be a cons, for the same reason. Require code_offset
4144 to be a character. Avoid int overflow if max_char is close
4145 to INT_MAX.
4146 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4147 this is intended anyway and avoids some undefined behavior.
4148 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4149 INDEX_TO_CODE_POINT, as that's what it expects.
4150 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4151 * charset.h (DECODE_CHAR): Return int, not unsigned;
4152 this is what was intended anyway, and it avoids undefined behavior.
4153 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4154 integer-overflow issues.
4155 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4156 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4157 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4158 * chartab.c (Fmake_char_table, Fset_char_table_range)
4159 (uniprop_get_decoder, uniprop_get_encoder):
4160 Don't assume fixnum fits in int.
4161 * cmds.c (move_point): New function, that does the gist of
4162 Fforward_char and Fbackward_char, but does so while checking
4163 for integer overflow more accurately.
c96e5d6a 4164 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4165 (Fforward_line, Fend_of_line, internal_self_insert)
4166 (internal_self_insert):
4167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4168 Fix a FIXME, by checking for integer overflow when calculating
4169 target_clm and actual_clm.
4170 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4171 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4172 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4173 (coding_alloc_by_making_gap, alloc_destination)
4174 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4175 (encode_coding_utf_16, detect_coding_emacs_mule)
4176 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4177 (detect_coding_iso_2022, decode_coding_iso_2022)
4178 (encode_invocation_designation, encode_designation_at_bol)
4179 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4180 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4181 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4182 (encode_coding_ccl, encode_coding_raw_text)
4183 (detect_coding_charset, decode_coding_charset)
4184 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4185 (produce_composition, produce_charset, produce_annotation)
4186 (decode_coding, handle_composition_annotation)
4187 (handle_charset_annotation, consume_chars, decode_coding_gap)
4188 (decode_coding_object, encode_coding_object, detect_coding_system)
4189 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4190 (code_convert_region, code_convert_string)
8f50130c
PE
4191 (Fdefine_coding_system_internal)
4192 (coding_set_source, coding_set_destination):
d311d28c
PE
4193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4194 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4195 (Fdefine_coding_system_internal):
4196 Don't assume fixnums fit in int.
4197 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4198 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4199 (Funencodable_char_position, Fcheck_coding_systems_region)
4200 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4201 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4202 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4203 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4204 Don't access memory outside of the args array.
d311d28c 4205 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4206 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4207 result of ENCODE_CHAR.
d311d28c
PE
4208 * coding.h: Adjust decls to match defn changes elsewhere.
4209 (struct coding_system):
4210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4211 * composite.c (get_composition_id, find_composition)
4212 (run_composition_function, update_compositions)
4213 (compose_text, composition_gstring_put_cache)
4214 (composition_gstring_p, composition_gstring_width)
4215 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4216 (composition_compute_stop_pos, composition_reseat_it)
4217 (composition_update_it, struct position_record)
4218 (find_automatic_composition, composition_adjust_point)
4219 (Fcomposition_get_gstring, Ffind_composition_internal):
4220 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4221 (update_compositions):
4222 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4223 * composite.h: Adjust decls to match defn changes elsewhere.
4224 (struct composition):
4225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4226 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4227 Do not attempt to compute the address of the object just before a
4228 buffer; this is not portable.
4229 (Faref, Faset):
4230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4231 (Faset): Use int, not EMACS_INT, where int is wide enough.
4232 (Fstring_to_number): Don't assume fixnums fit in int.
4233 (Frem): Don't assume arg is nonnegative.
4234 * dbusbind.c (xd_append_arg): Check for integers out of range.
4235 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4236 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4237 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4238 (xd_get_connection_references): Return ptrdiff_t, not int.
4239 All uses changed.
4240 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4241 (xd_read_message_1):
4242 Use int, not unsigned, where the dbus API uses int.
4243 (Fdbus_message_internal): Don't overflow mtype.
4244 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4245 * dired.c (directory_files_internal, file_name_completion, scmp)
4246 (file_name_completion_stat):
4247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4248 (file_name_completion): Don't overflow matchcount.
4249 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4250 * dispextern.h: Adjust decls to match defn changes elsewhere.
4251 (struct text_pos, struct glyph, struct bidi_saved_info)
4252 (struct bidi_string_data, struct bidi_it, struct composition_it)
4253 (struct it):
4254 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4255 (struct display_pos, struct composition_it, struct it):
4256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4257 * dispnew.c (increment_matrix_positions)
4258 (increment_row_positions, mode_line_string)
4259 (marginal_area_string):
4260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4261 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4263 (duration_to_sec_usec): New function, to check for overflow better.
4264 (Fsleep_for, sit_for): Use it.
4265 * doc.c (get_doc_string, store_function_docstring):
4266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4267 (get_doc_string, Fsnarf_documentation):
4268 Use int, not EMACS_INT, where int is wide enough.
4269 (get_doc_string):
4270 Use SAFE_ALLOCA, not alloca.
4271 Check for overflow when converting EMACS_INT to off_t.
4272 * doprnt.c (doprnt):
4273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4274 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4275 Don't assume uid_t fits into fixnum.
4276 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4277 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4278 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4279 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4280 (general_insert_function)
4281 (Finsert_char, make_buffer_string, make_buffer_string_both)
4282 (update_buffer_properties, Fbuffer_substring)
4283 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4284 (Fsubst_char_in_region, check_translation)
4285 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4286 (transpose_markers, Ftranspose_regions):
4287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4288 (clip_to_bounds): Move to lisp.h as an inline function).
4289 (Fconstrain_to_field): Don't assume integers are nonnegative.
4290 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4291 (Fsubst_char_in_region, Fsave_restriction):
4292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4293 (Femacs_pid): Don't assume pid_t fits into fixnum.
4294 (lo_time): Use int, not EMACS_INT, when int suffices.
4295 (lisp_time_argument): Check for usec out of range.
4296 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4297 (Fuser_login_name, Fuser_full_name): Signal an error
4298 if a uid argument is out of range, rather than relying on
4299 undefined behavior.
c8d5c857
PE
4300 (Fformat_time_string): Remove now-unnecessary check.
4301 lisp_time_argument checks for out-of-range usec now.
243e0530 4302 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4303 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4304 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4305 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4306 (init_cmdargs, Fdump_emacs):
4307 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4308 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4309 the bottom (typically) 32 bits of the fixnum.
4310 * eval.c (specpdl_size, call_debugger):
4311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4312 (when_entered_debugger, Fbacktrace_debug):
4313 Don't assume fixnum can fit in int.
4314 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4315 the object just before a buffer; this is not portable.
4316 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4317 (grow_specpdl, unbind_to):
4318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4319 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4320 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4321 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4322 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4323 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4325 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4326 (a_write, e_write):
4327 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4328 (Fcopy_file, non_regular_nbytes, read_non_regular)
4329 (Finsert_file_contents):
4330 Use int, not EMACS_INT, where int is wide enough.
4331 (READ_BUF_SIZE): Verify that it fits in int.
4332 (Finsert_file_contents): Check that counts are in proper range,
4333 rather than assuming fixnums fit into ptrdiff_t etc.
4334 Don't assume fixnums fit into int.
125b3835 4335 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4336 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4337 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4338 (string_char_to_byte, string_byte_to_char)
4339 (string_make_multibyte, string_to_multibyte)
4340 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4341 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4342 (substring_both, Fdelete, internal_equal, Ffillarray)
4343 (Fclear_string, mapcar1)
4344 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4345 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4346 (larger_vector, make_hash_table, maybe_resize_hash_table)
4347 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4348 (Fmaphash, secure_hash):
4349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4350 (concat): Check for string index and length overflow.
4351 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4352 (Frequire):
4353 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4354 (larger_vector): New API (vec, incr_min, size_max) replaces old
4355 one (vec, new_size, init). This catches size overflow.
4356 INIT was removed because it was always Qnil.
4357 All callers changed.
4358 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4359 the upper bound on a hash table index size.
4360 (make_hash_table, maybe_resize_hash_table): Use it.
4361 (secure_hash): Computer start_byte and end_byte only after
4362 they're known to be in ptrdiff_t range.
4363 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4364 (Ffont_get_glyphs, Ffont_at):
4365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4366 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4367 (Flist_fonts, Fopen_font):
4368 Don't assume fixnum can fit in int.
4369 (check_gstring): Don't assume index can fit in int.
4370 (font_match_p): Check that fixnum is a character, not a nonnegative
4371 fixnum, since the later code needs to stuff it into an int.
4372 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4373 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4374 conversion overflow issues.
4375 (Fopen_font): Check for integer out of range.
4376 (Ffont_get_glyphs): Don't assume index can fit in int.
4377 * font.h: Adjust decls to match defn changes elsewhere.
4378 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4379 integer overflow.
4380 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4381 printmax_t, where ptrdiff_t is wide enough.
4382 (Finternal_char_font):
4383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4384 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4385 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4386 (Fset_frame_position, x_set_frame_parameters)
4387 (x_set_line_spacing, x_set_border_width)
4388 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4389 Check that fixnums are in proper range for system types.
4390 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4391 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4392 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4393 Use SAFE_ALLOCA_LISP, not alloca.
4394 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4395 intptr_t is wide enough.
4396 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4397 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4398 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4399 Check for fixnum out of range.
4400 * ftfont.c (ftfont_list): Don't assume index fits in int.
4401 Check that fixnums are in proper range for system types.
4402 (ftfont_shape_by_flt):
4403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4404 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4406 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4407 Check that fixnums are in proper range for system types.
4408 * gnutls.h: Adjust decls to match defn changes elsewhere.
4409 * gtkutil.c (xg_dialog_run):
4410 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4411 (update_frame_tool_bar):
4412 Check that fixnums are in proper range for system types.
4413 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4414 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4415 * indent.c (last_known_column, last_known_column_point):
4416 (current_column_bol_cache):
4417 (skip_invisible, current_column, check_display_width):
4418 (check_display_width, scan_for_column, current_column_1)
4419 (Findent_to, Fcurrent_indentation, position_indentation)
4420 (indented_beyond_p, Fmove_to_column, compute_motion):
4421 (Fcompute_motion, Fvertical_motion):
4422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4423 (last_known_column_modified): Use EMACS_INT, not int.
4424 (check_display_width):
4425 (Fcompute_motion):
4426 Check that fixnums and floats are in proper range for system types.
4427 (compute_motion): Don't assume index or fixnum fits in int.
4428 (compute_motion, Fcompute_motion):
4429 Use int, not EMACS_INT, when it is wide enough.
4430 (vmotion): Omit local var start_hpos that is always 0; that way
4431 we don't need to worry about overflow in expressions involving it.
4432 * indent.h: Adjust decls to match defn changes elsewhere.
4433 (struct position):
4434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4435 Use int, not EMACS_INT, where int is wide enough.
4436 Remove unused members ovstring_chars_done and tab_offset;
4437 all uses removed.
4438 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4439 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4440 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4441 (make_gap, copy_text, insert, insert_and_inherit)
4442 (insert_before_markers, insert_before_markers_and_inherit)
4443 (insert_1, count_combining_before, count_combining_after)
4444 (insert_1_both, insert_from_string)
4445 (insert_from_string_before_markers, insert_from_string_1)
4446 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4447 (adjust_after_replace, adjust_after_insert, replace_range)
4448 (replace_range_2, del_range, del_range_1, del_range_byte)
4449 (del_range_both, del_range_2, modify_region)
4450 (prepare_to_modify_buffer, signal_before_change)
4451 (signal_after_change, Fcombine_after_change_execute):
4452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4453 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4454 (balance_an_interval, split_interval_right, split_interval_left)
4455 (find_interval, next_interval, update_interval)
4456 (adjust_intervals_for_insertion, delete_node, delete_interval)
4457 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4458 (static_offset_intervals, offset_intervals)
4459 (merge_interval_right, merge_interval_left, make_new_interval)
4460 (graft_intervals_into_buffer, temp_set_point_both)
4461 (temp_set_point, set_point, adjust_for_invis_intang)
4462 (set_point_both, move_if_not_intangible, get_property_and_range)
4463 (get_local_map, copy_intervals, copy_intervals_to_string)
4464 (compare_string_intervals, set_intervals_multibyte_1):
4465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4466 * intervals.h: Adjust decls to match defn changes elsewhere.
4467 (struct interval):
4468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4469 * keyboard.c (this_command_key_count, this_single_command_key_start)
4470 (before_command_key_count, before_command_echo_length, echo_now)
4471 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4472 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4473 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4474 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4475 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4476 (last_non_minibuf_size, last_point_position, echo_truncate)
4477 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4478 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4479 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4480 (stuff_buffered_input):
4481 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4482 (last_auto_save, command_loop_1, read_char):
4483 Use EMACS_INT, not int, to avoid integer overflow.
4484 (record_char): Avoid overflow in total_keys computation.
4485 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4486 * keyboard.h: Adjust decls to match defn changes elsewhere.
4487 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4488 (Fkey_description, Fdescribe_vector, Flookup_key):
4489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4490 (click_position): New function, to check that positions are in range.
4491 (Fcurrent_active_maps):
4492 (describe_command):
4493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4494 (Faccessible_keymaps, Fkey_description):
4495 (preferred_sequence_p):
4496 Don't assume fixnum can fit into int.
4497 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4498 Check for integer overflow in size calculations.
4499 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4500 avoid mishandling large integers.
4501 * lisp.h: Adjust decls to match defn changes elsewhere.
4502 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4503 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4504 (struct Lisp_Marker):
4505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4506 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4507 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4508 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4509 All callers changed.
4510 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4511 Assume the arg has valid form, since it always does.
4512 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4513 unsigned integer system type.
4514 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4515 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4517 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4518 (duration_to_sec_usec): New decl.
4519 * lread.c (read_from_string_index, read_from_string_index_byte)
4520 (read_from_string_limit, readchar, unreadchar, openp)
4521 (read_internal_start, read1, oblookup):
4522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4523 (Fload, readevalloop, Feval_buffer, Feval_region):
4524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4525 (openp): Check for out-of-range argument to 'access'.
4526 (read1): Use int, not EMACS_INT, where int is wide enough.
4527 Don't assume fixnum fits into int.
6efdadfd 4528 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4529 (read_filtered_event): Use duration_to_sec_usec
4530 to do proper overflow checking on durations.
d311d28c
PE
4531 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4532 in size calculation.
4533 (Fexecute_kbd_macro):
4534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4535 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4536 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4537 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4538 (set_marker_both, set_marker_restricted_both, marker_position)
4539 (marker_byte_position, Fbuffer_has_markers_at):
4540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4541 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4542 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4543 It now merely ensures that the menu is large enough, without
4544 necessarily growing it, as this avoids some integer overflow issues.
4545 All callers changed.
4546 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4548 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4549 Use SAFE_ALLOCA_LISP, not alloca.
4550 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4551 to EMACS_INT. Check that fixnums are in proper range for system types.
4552 * minibuf.c (minibuf_prompt_width, string_to_object)
4553 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4554 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4556 (get_minibuffer, read_minibuf_unwind):
4557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4558 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4559 this simplifies overflow checking. All callers changed.
4560 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4561 (Ftest_completion):
4562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4563 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4564 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4565 Check that fixnums are in proper range for system types.
4566 (Fx_create_frame, Fx_show_tip):
4567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4568 * nsfont.m (ns_findfonts, nsfont_list_family):
4569 Don't assume fixnum fits in long.
4570 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4572 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4573 wide enough.
17fdb222 4574 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4576 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4577 (PRINTDECLARE, PRINTPREPARE):
4578 (strout, print_string):
4579 (print, print_preprocess, print_check_string_charset_prop)
4580 (print_object):
4581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4582 (PRINTDECLARE):
4583 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4585 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4586 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4587 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4588 (print_error_message): Use SAFE_ALLOCA, not alloca.
4589 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4590 (print_depth, new_backquote_output, print_number_index):
4591 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4592 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4593 (Fset_process_window_size, Fformat_network_address)
4594 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4595 (sigchld_handler):
d311d28c 4596 Check that fixnums are in proper range for system types.
d44287d4 4597 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4598 Check for process-ids out of pid_t range rather than relying on
4599 undefined behavior.
e4d81efc 4600 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4601 (Fformat_network_address, read_process_output, send_process)
4602 (Fprocess_send_region, status_notify):
4603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4604 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4605 (wait_reading_process_output, read_process_output, exec_sentinel):
4606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4607 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4608 (Faccept_process_output): Use duration_to_sec_usec to do proper
4609 overflow checking on durations.
dde14581
PE
4610 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4611 Don't assume pid_t fits in int.
02481186
PE
4612 * process.h (struct Lisp_Process): Members tick and update_tick
4613 are now of type EMACS_INT, not int.
b62b53e8
PE
4614 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4615 configured --with-wide-int.
d311d28c
PE
4616 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4617 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4618 * search.c (looking_at_1, string_match_1):
4619 (fast_string_match, fast_c_string_match_ignore_case)
4620 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4621 (scan_newline, find_before_next_newline, search_command)
4622 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4623 (set_search_regs, wordify):
4624 (Freplace_match):
4625 (Fmatch_data):
4626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4627 (string_match_1, search_buffer, set_search_regs):
4628 (Fmatch_data):
4629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4630 (wordify): Check for overflow in size calculation.
4631 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4632 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4633 Check that fixnums are in proper range for system types.
4634 * sound.c (struct sound_device)
4635 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4637 (Fplay_sound_internal):
4638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4639 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4640 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4641 (Fparse_partial_sexp):
4642 Don't assume fixnums can fit in int.
4643 (struct lisp_parse_state, find_start_pos, find_start_value)
4644 (find_start_value_byte, find_start_begv)
4645 (update_syntax_table, char_quoted, dec_bytepos)
4646 (find_defun_start, prev_char_comend_first, back_comment):
4647 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4648 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4650 (Finternal_describe_syntax_value): Check that match_lisp is a
4651 character, not an integer, since the code stuffs it into int.
4652 (scan_words, scan_sexps_forward):
4653 Check that fixnums are in proper range for system types.
4654 (Fforward_word):
4655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4656 (scan_sexps_forward):
4657 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4658 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4659 * syntax.h: Adjust decls to match defn changes elsewhere.
4660 (struct gl_state_s):
4661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4662 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4663 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4664 * sysdep.c (wait_for_termination_1, wait_for_termination)
4665 (interruptible_wait_for_termination, mkdir):
4666 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4667 (emacs_read, emacs_write):
4668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4669 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4670 and double all fit in int.
d311d28c
PE
4671 * term.c (set_tty_color_mode):
4672 Check that fixnums are in proper range for system types.
4673 * termhooks.h (struct input_event):
4674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4675 * textprop.c (validate_interval_range, interval_of)
4676 (Fadd_text_properties, set_text_properties_1)
4677 (Fremove_text_properties, Fremove_list_of_text_properties)
4678 (Ftext_property_any, Ftext_property_not_all)
4679 (copy_text_properties, text_property_list, extend_property_ranges)
4680 (verify_interval_modification):
4681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4682 (Fnext_single_char_property_change)
4683 (Fprevious_single_char_property_change):
4684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4685 (copy_text_properties):
4686 Check for integer overflow in index calculation.
d311d28c
PE
4687 * undo.c (last_boundary_position, record_point, record_insert)
4688 (record_delete, record_marker_adjustment, record_change)
4689 (record_property_change):
4690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4691 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4693 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4694 (Fx_hide_tip, Fx_file_dialog):
4695 * w32menu.c (set_frame_menubar):
4696 Use ptrdiff_t, not int, for consistency with rest of code.
4697 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4698 (select_window, Fdelete_other_windows_internal)
4699 (window_scroll_pixel_based, window_scroll_line_based)
4700 (Frecenter, Fset_window_configuration):
4701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4702 (Fset_window_hscroll, run_window_configuration_change_hook)
4703 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4704 (Fscroll_other_window, Frecenter):
d311d28c
PE
4705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4706 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4707 Don't assume fixnum fits in int.
4708 (Fset_window_scroll_bars):
4709 Check that fixnums are in proper range for system types.
4710 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4711 (string_pos, c_string_pos, number_of_chars, init_iterator)
4712 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4713 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4714 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4715 (face_before_or_after_it_pos, handle_invisible_prop)
4716 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4717 (display_prop_intangible_p, string_buffer_position_lim)
4718 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4719 (get_overlay_strings_1, get_overlay_strings)
4720 (iterate_out_of_display_property, forward_to_next_line_start)
4721 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4722 (get_next_display_element, set_iterator_to_next)
4723 (get_visually_first_element, compute_stop_pos_backwards)
4724 (handle_stop_backwards, next_element_from_buffer)
4725 (move_it_in_display_line_to, move_it_in_display_line)
4726 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4727 (add_to_log, message_dolog, message_log_check_duplicate)
4728 (message2, message2_nolog, message3, message3_nolog
4729 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4730 (current_message_1, truncate_echo_area, truncate_message_1)
4731 (set_message, set_message_1, store_mode_line_noprop)
4732 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4733 (text_outside_line_unchanged_p, check_point_in_composition)
4734 (reconsider_clip_changes)
4735 (redisplay_internal, set_cursor_from_row, try_scrolling)
4736 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4737 (redisplay_window, find_last_unchanged_at_beg_row)
4738 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4739 (trailing_whitespace_p, find_row_edges, display_line)
4740 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4741 (display_mode_element, store_mode_line_string)
4742 (pint2str, pint2hrstr, decode_mode_spec)
4743 (display_count_lines, display_string, draw_glyphs)
4744 (x_produce_glyphs, x_insert_glyphs)
4745 (rows_from_pos_range, mouse_face_from_buffer_pos)
4746 (fast_find_string_pos, mouse_face_from_string_pos)
4747 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4749 (safe_call, init_from_display_pos, handle_fontified_prop)
4750 (handle_single_display_spec, load_overlay_strings)
4751 (with_echo_area_buffer, setup_echo_area_for_printing)
4752 (display_echo_area, echo_area_display)
4753 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4754 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4755 (redisplay_window, dump_glyph_row, display_mode_line)
4756 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4757 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4759 (handle_single_display_spec, build_desired_tool_bar_string)
4760 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4761 (get_specified_cursor_type):
4762 Check that fixnums are in proper range for system types.
4763 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4764 (Flookup_image_map):
4765 Don't assume fixnums fit in int.
4766 (compare_overlay_entries):
4767 Avoid mishandling comparisons due to subtraction overflow.
4768 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4769 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4770 (handle_tool_bar_click):
4771 Use int, not unsigned, since we prefer signed and the signedness
4772 doesn't matter here.
4773 (get_next_display_element, next_element_from_display_vector):
4774 Use int, not EMACS_INT, when int is wide enough.
4775 (start_hourglass): Use duration_to_sec_usec to do proper
4776 overflow checking on durations.
4777 * xfaces.c (Fbitmap_spec_p):
4778 Check that fixnums are in proper range for system types.
4779 (compare_fonts_by_sort_order):
4780 Avoid mishandling comparisons due to subtraction overflow.
4781 (Fx_family_fonts, realize_basic_faces):
4782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4783 (Fx_family_fonts):
4784 Don't assume fixnum fits in int.
4785 Use SAFE_ALLOCA_LISP, not alloca.
4786 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4787 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4788 (face_at_buffer_position, face_for_overlay_string)
4789 (face_at_string_position):
4790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4791 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4792 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4793 (Fx_show_tip):
4794 Check that fixnums are in proper range for system types.
4795 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4796 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4798 (Fx_change_window_property): Don't assume fixnums fit in int.
4799 * xfont.c (xfont_chars_supported):
4800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4801 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4802 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4803 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4804 * xml.c (parse_region):
4805 * xrdb.c (magic_file_p):
4806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4807 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4808 (x_get_local_selection, x_reply_selection_request)
4809 (x_handle_selection_request, wait_for_property_change):
4810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4811 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4812 short is wide enough.
4813 (x_send_client_event): Don't assume fixnum fits in int.
4814 * xterm.c (x_x_to_emacs_modifiers):
4815 Don't assume EMACS_INT overflows nicely into int.
4816 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4817 may come from Lisp.
4818 (handle_one_xevent): NATNUMP can eval its arg twice.
4819 (x_connection_closed):
4820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4821 * xterm.h: Adjust decls to match defn changes elsewhere.
4822 (struct scroll_bar): Use struct vectorlike_header
4823 rather than rolling our own approximation.
4824 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4825
c6574eb5
GM
48262012-05-25 Glenn Morris <rgm@gnu.org>
4827
4828 * lisp.mk (lisp): Update for more files being compiled now.
4829
e8d32c7e
SM
48302012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4831
48def666
SM
4832 * lread.c: Remove `read_pure' which makes no difference.
4833 (read_pure): Remove var.
4834 (unreadpure): Remove function.
4835 (readevalloop): Don't call read_list with -1 flag.
4836 (read1, read_vector): Don't test read_pure any more.
4837 (read_list): Simplify.
4838
e8d32c7e
SM
4839 * fileio.c, character.h: Minor style tweaks.
4840
4b2addb7
DA
48412012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4842
4843 * window.h (clip_changed): Remove useless declaration.
4844
584461b2
JB
48452012-05-22 Juanma Barranquero <lekktu@gmail.com>
4846
4847 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4848 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4849
34374650
PE
48502012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4851
4852 Remove src/m/*.
4853 This directory predates autoconf and is no longer needed nowadays.
4854 Move its few remaining bits of functionality to where they're needed.
4855 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4856 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4857 * m/template.h: Remove.
4858 * Makefile.in (M_FILE): Remove. All uses removed.
4859 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4860 * lisp.h (USE_LSB_TAG):
4861 * mem-limits.h (EXCEEDS_LISP_PTR):
4862 Use VAL_MAX, not VALBITS, in #if.
4863 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4864 (EMACS_UINT): Define unconditionally now.
4865 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4866 (BITS_PER_EMACS_INT): New constants, replacing
4867 what used to be in config.h, but not useful in #if.
4868 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4869 define them any more.
4870 (VAL_MAX): New macro.
4871 (VALMASK): Use it.
4872 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4873 BITS_PER_EMACS_INT, in #if.
4874 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4875 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4876 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4877 * s/ms-w32.h (DATA_START):
4878 Move here from removed file m/intel386.h.
4879 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4880 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4881
261cb4bb
PE
48822012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4883
4884 Assume C89 or later.
4885 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4886 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4887 (xrealloc):
4888 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4889 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4890 * textprop.c, tparam.c (NULL): Remove.
4891 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4892 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4893 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4894 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4895 * xterm.c (input_signal_count): Assume volatile works.
4896
ff23cd9f
KB
48972012-05-21 Ken Brown <kbrown@cornell.edu>
4898
4899 * xgselect.c (xg_select): Fix first argument in call to 'select'
4900 (bug#11508).
4901
1b170bc6
KB
49022012-05-20 Ken Brown <kbrown@cornell.edu>
4903
4904 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4905 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4906
b2f4d39f
KB
49072012-05-19 Ken Brown <kbrown@cornell.edu>
4908
4909 * xfns.c (x_in_use): Remove `static' qualifier.
4910 * xterm.h (x_in_use): Declare.
4911 * xgselect.c: Include xterm.h.
4912 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4913 and `display_arg' (bug#9754).
4914
003fdae2
PE
49152012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4916
9232a6d9
PE
4917 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4918
003fdae2
PE
4919 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4920 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4921
784b56e2
EZ
49222012-05-18 Eli Zaretskii <eliz@gnu.org>
4923
4924 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4925
4926 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4927 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4928
4929 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4930 reference to image_cache->refcount.
4931 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4932
a0a79cde
JL
49332012-05-17 Juri Linkov <juri@jurta.org>
4934
4935 * search.c (Fword_search_regexp, Fword_search_backward)
4936 (Fword_search_forward, Fword_search_backward_lax)
4937 (Fword_search_forward_lax): Move functions to isearch.el
4938 (bug#10145, bug#11381).
4939
b0572523
PE
49402012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4941
4942 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4943
9660f5fc
SM
49442012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4945
4946 * lread.c (init_obarray): Declare Qt and Qnil as special.
4947
4374de83
GM
49482012-05-14 Glenn Morris <rgm@gnu.org>
4949
4950 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4951 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4952
dc44c39a
PE
49532012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4954
078c97cb
PE
4955 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4956
dc44c39a
PE
4957 * unexaix.c: Port to more-recent AIX compilers.
4958 (report_error, report_error_1, make_hdr, copy_sym)
4959 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4960 Make arguments const char *, not char *, to avoid violations of C
4961 standard and to fix some AIX warnings reported by Gilles Pion.
4962
e18afed7 49632012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4964
4965 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4966 already have overlays loaded.
4967 (handle_single_display_spec): Before returning without displaying
4968 fringe bitmap, synchronize the bidi iterator with the main display
4969 iterator, by calling iterate_out_of_display_property.
4970 (iterate_out_of_display_property): Detect buffer iteration by
4971 testing that it->string is a Lisp string.
4972 (get_next_display_element): When the current object is exhausted,
4973 and there's something on it->stack, call set_iterator_to_next to
4974 proceed with what's on the stack, instead of returning zero.
4975 (set_iterator_to_next): If called at the end of a Lisp string,
4976 proceed to consider_string_end without incrementing string
4977 position. Don't increment display vector index past the end of
4978 the display vector. (Bug#11417)
c8fb9dc6
EZ
4979 (pos_visible_p): Don't report a position visible when move_it_to
4980 stopped at the last line of window, which happens to be scanned
4981 backwards by the bidi iteration. (Bug#11464)
ac268e67 4982
e18afed7 49832012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4984
4985 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4986 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4987 are on a TTY, and thus unable to display on the fringes.
4988 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4989 so we need to signal to the caller that this is a "replacing"
4990 display spec. This fixes display when the spec is invalid or we
4991 are on a TTY.
4992
e18afed7 49932012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4994
4995 * unexaix.c (make_hdr): Fix typo in prototype.
4996 This bug broke the build on AIX. Problem reported by Gilles Pion.
4997
9d0a235a
MA
49982012-05-14 Michael Albinus <michael.albinus@gmx.de>
4999
5000 * keyboard.c (kbd_buffer_get_event): Read special events also in
5001 batch mode. (Bug#11415)
5002
9e6b06ed
GM
50032012-05-12 Glenn Morris <rgm@gnu.org>
5004
5005 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5006
c1a1d7a3
EZ
50072012-05-12 Eli Zaretskii <eliz@gnu.org>
5008
5009 * lisp.mk (lisp): Add newcomment.elc.
5010
3fe7cdc8
GM
50112012-05-12 Glenn Morris <rgm@gnu.org>
5012
5013 * Makefile.in (MKDIR_P): New, set by configure.
5014 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5015
53f7d2c0
PE
50162012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5017
5018 Remove unused function hourglass_started.
5019 * dispextern.h (hourglass_started):
5020 * w32fns.c (hourglass_started):
5021 * xdisp.c (hourglass_started): Remove.
5022
75aafb17
JB
50232012-05-10 Juanma Barranquero <lekktu@gmail.com>
5024
5025 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5026 Update dependencies.
5027
12959e8e
PE
50282012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5029
97107e2e
PE
5030 * xgselect.c (xg_select): Put maxfds+1 into a var.
5031 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5032
12959e8e
PE
5033 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5034
836d29b3
DA
50352012-05-10 Dave Abrahams <dave@boostpro.com>
5036
5037 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5038 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5039
5cb67954
MA
50402012-05-09 Michael Albinus <michael.albinus@gmx.de>
5041
5042 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5043 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5044 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5045 Initialize xd_registered_buses.
5046
3478ec45
PE
50472012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5048
b263a6b0
PE
5049 Untag more efficiently if USE_LSB_TAG.
5050 This is based on a proposal by YAMAMOTO Mitsuharu in
5051 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5052 For an admittedly artificial (nth 8000 longlist) benchmark on
5053 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5054 Emacs's overall text size by 1%.
5055 * lisp.h (XUNTAG): New macro.
5056 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5057 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5058 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5059 * eval.c (Fautoload):
5060 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5061 * frame.h (XFRAME): Use XUNTAG.
5062
3478ec45
PE
5063 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5064 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5065 Remove unportable assumptions about print widths of types like
5066 dbus_uint32_t.
5067 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5068 intptr_t when converting between pointer and integer, to avoid GCC
5069 warnings about wrong width.
5070
666b903b 50712012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5072
5073 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5074 stack for each reader_thread, instead of defaulting to 8MB
5075 determined by the linker. This avoids failures in creating
5076 subprocesses on Windows 7, see the discussion in this thread:
5077 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5078
b120cc17
JC
50792012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5080
5081 Fix up display of the *Minibuf-0* buffer in the mini window.
5082 * keyboard.c (read_char): Don't clear the echo area if there's no
5083 message to clear.
5084 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5085 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5086
9a4b36f8
MA
50872012-05-07 Michael Albinus <michael.albinus@gmx.de>
5088
5089 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5090 batch mode.
5091
e5f9458f
CY
50922012-05-06 Chong Yidong <cyd@gnu.org>
5093
5094 * lisp.mk (lisp): Update.
5095
eceeb5fc 50962012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5097
5098 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5099
71873e2b
SM
51002012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5101
5102 * data.c (PUT_ERROR): New macro.
5103 (syms_of_data): Use it. Add new error type `user-error'.
5104 * undo.c (user_error): New function.
5105 (Fprimitive_undo): Use it.
5106 * print.c (print_error_message): Adjust print style for `user-error'.
5107 * keyboard.c (user_error): New function.
5108 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5109
ab0fa4e4
PE
51102012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5111
5112 Do not limit current-time-string to years 1000..9999.
5113 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5114 (Fcurrent_time_string): Support any year that is supported by the
5115 underlying localtime representation. Don't use asctime, as it
5116 has undefined behavior for years outside the range -999..9999.
5117
7ed806a7
PE
51182012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5119
5120 Fix race conditions involving setenv, gmtime, localtime, asctime.
5121 Without this fix, interrupts could mess up code that uses these
5122 nonreentrant functions, since setting TZ invalidates existing
5123 tm_zone or tzname values, and since most of these functions return
5124 pointers to static storage.
5125 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5126 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5127 Grow the critical sections to include not just invoking
5128 localtime/gmtime, but also accessing these functions' results
5129 including their tm_zone values if any, and any related TZ setting.
5130 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5131 so that the struct tm is saved in the critical section.
5132 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5133 motivated by the fact that memory allocation needs to be outside
5134 the critical section.
5135
0c16dfed
DA
51362012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5137
5138 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5139 with RESET_INTERVAL.
5140
5141 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5142 Remove duplicated buffer name initialization.
5143
3f83ace8
JM
51442012-05-02 Jim Meyering <jim@meyering.net>
5145
5146 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5147
c7b8541e
JM
5148 * xfns.c (x_window): Use xstrdup (Bug#11375).
5149
90207a15 51502012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5151
5152 * xdisp.c (pos_visible_p): If already at a newline from the
5153 display string before the 'while' loop, don't walk back the glyphs
5154 from it3.glyph_row. Solves assertion violation when the display
5155 string begins with a newline (egg.el). (Bug#11367)
5156
b593d6a9
AH
51572012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5158
5159 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5160 Move to simple.el.
5161
4737362e
GM
51622012-05-01 Glenn Morris <rgm@gnu.org>
5163
99cf43f9
GM
5164 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5165 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5166 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5167 All were removed before 23.1.
5168
9311dcff
GM
5169 * dispnew.c: Remove HAVE_LIBNCURSES test;
5170 it is always true on relevant platforms.
5171
4d5c6349
GM
5172 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5173 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5174
4737362e
GM
5175 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5176
74dd3a6b
AS
51772012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5178
5179 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5180 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5181 Remove.
5182
13c379ee
PE
51832012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5184
5185 Do not avoid creating empty evaporating overlays (Bug#9642).
5186 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5187 That is, do not delete an evaporating overlay if it becomes
5188 empty after its bounds are adjusted to fit within its buffer.
5189 This fix caused other problems, and I'm reverting it until we get
5190 to the bottom of them.
5191
a8e7d6d7 51922012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5193
5194 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5195
a8e7d6d7 51962012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5197
5198 * xdisp.c (pos_visible_p): If the window start position is beyond
5199 ZV, start the display from buffer beginning. Prevents assertion
5200 violation in init_iterator when the minibuffer window is scrolled
5201 via the scroll bar.
5202
5203 * window.c (window_scroll_pixel_based): Likewise.
5204
a8e7d6d7 52052012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5206
5207 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5208
a8e7d6d7 52092012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5210
5211 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5212 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5213
a8e7d6d7 52142012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5215
b593d6a9
AH
5216 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5217 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5218
1c6900d9
EZ
52192012-04-26 Eli Zaretskii <eliz@gnu.org>
5220
4c3fa1d9
EZ
5221 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5222 display element, check also the underlying string or buffer
5223 character. (Bug#11341)
5224
1c6900d9
EZ
5225 * w32menu.c: Include w32heap.h.
5226 (add_menu_item): If the call to AppendMenuW (via
5227 unicode_append_menu) fails, disable Unicode menus only if we are
5228 running on Windows 9X/Me.
5229
42bf8205
AS
52302012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5231
5232 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5233 (xgetint): Add missing shift for LSB tags.
5234
b1bac16e
MR
52352012-04-24 Martin Rudalics <rudalics@gmx.at>
5236
5237 * keyboard.c (read_char): Don't wipe echo area for select window
5238 events: These might get delayed via `mouse-autoselect-window'
5239 (Bug#11304).
5240
d69621cc
JB
52412012-04-24 Juanma Barranquero <lekktu@gmail.com>
5242
5243 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5244 manipulation of :loaded-from data.
5245
02fd101b
JB
52462012-04-23 Juanma Barranquero <lekktu@gmail.com>
5247
5248 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5249 now a cons (bug#11311).
5250
888bec30
PE
52512012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5252
89a438bd
PE
5253 Do not create empty overlays with the evaporate property (Bug#9642).
5254 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5255 if it becomes empty after its bounds are adjusted to fit within
5256 its buffer. Without this fix, in a nonempty buffer (let ((o
5257 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5258 yields an empty overlay that has the evaporate property, which is
5259 not supposed to happen.
5260
1068fe4d
PE
5261 Fix minor GTK3 problems found by static checking.
5262 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5263 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5264 (struct _EmacsFixedClass, emacs_fixed_get_type):
5265 Move decls here from emacsgtkfixed.h, since they needn't be public.
5266 (emacs_fixed_get_type): Now static.
5267 (emacs_fixed_class_init): Omit unused local.
5268 (emacs_fixed_child_type): Remove; unused.
5269 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5270 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5271 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5272 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5273 (EMACS_FIXED_GET_CLASS): Remove; unused.
5274 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5275
888bec30
PE
5276 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5277 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5278
de85e130
PE
52792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5280
d0baac98 5281 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5282 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5283 (__malloc_size_t, __malloc_ptrdiff_t):
5284 Remove. All uses removed, replaced by the definiens if needed,
5285 since we can assume C89 or better now.
5286 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5287 (protect_malloc_state, align, get_contiguous_space)
5288 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5289 (malloc_atfork_handler_child, malloc_enable_thread)
5290 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5291 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5292 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5293 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5294 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5295 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5296 Define using prototypes, not old style.
5297 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5298 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5299 (align): Don't assume that signed integer overflow wraps around.
5300 Omit unused local var.
5301 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5302 (_free_internal_nolock, memalign, mallochook, reallochook):
5303 Omit no-longer-needed casts.
5304 (valloc): Use getpagesize, not __getpagesize.
5305 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5306 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5307
de85e130
PE
5308 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5309
dcbf5805
MA
53102012-04-22 Michael Albinus <michael.albinus@gmx.de>
5311
5312 Move functions from C to Lisp. Make non-blocking method calls
5313 the default. Implement further D-Bus standard interfaces.
5314
5315 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5316 (QCdbus_request_name_allow_replacement)
5317 (QCdbus_request_name_replace_existing)
5318 (QCdbus_request_name_do_not_queue)
5319 (QCdbus_request_name_reply_primary_owner)
5320 (QCdbus_request_name_reply_in_queue)
5321 (QCdbus_request_name_reply_exists)
5322 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5323 (QCdbus_registered_serial, QCdbus_registered_method)
5324 (QCdbus_registered_signal): New Lisp objects.
5325 (XD_DEBUG_MESSAGE): Use sizeof.
5326 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5327 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5328 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5329 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5330 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5331 (xd_signature, xd_append_arg): Allow float for integer types.
5332 (xd_get_connection_references): New function.
b593d6a9
AH
5333 (xd_get_connection_address): Rename from xd_initialize.
5334 Return cached address.
dcbf5805
MA
5335 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5336 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5337 level.
5338 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5339 Return number of refcounts.
dcbf5805
MA
5340 (Fdbus_get_unique_name): Make stronger parameter check.
5341 (Fdbus_message_internal): New defun.
5342 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5343 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5344 (Fdbus_send_signal, Fdbus_register_service)
5345 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5346 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5347 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5348 (Vdbus_compiled_version, Vdbus_runtime_version)
5349 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5350 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5351 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5352 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5353 Adapt docstring.
dcbf5805 5354
52828e02
PE
53552012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5356
da05bc4c
PE
5357 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5358 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5359 Do not assume ptrdiff_t is the same width as 'int'.
5360
52828e02
PE
5361 * alloc.c: Handle unusual debugging option combinations.
5362 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5363 since the two debugging options are incompatible.
5364 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5365 is defined.
5366 (mem_init, mem_insert, mem_insert_fixup):
5367 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5368 (NEED_MEM_INSERT): Remove; no longer needed.
5369
f01769f9
LL
53702012-04-22 Leo Liu <sdl.web@gmail.com>
5371
5372 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5373
5790543d
PE
53742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5375
5376 * sysdep.c [__FreeBSD__]: Minor cleanups.
5377 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5378 Use Emacs indenting style more consistently. Avoid some casts.
5379 Use 'double' consistently rather than mixing 'float' and 'double'.
5380
b91b7e4d
EW
53812012-04-21 Eduard Wiebe <usenet@pusto.de>
5382
b593d6a9
AH
5383 * sysdep.c (list_system_processes, system_process_attributes):
5384 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5385
6114eb15
AS
53862012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5387
5388 * lisp.mk (lisp): Update.
5389
2f38dff7
PE
53902012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5391
5392 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5393 It is never used otherwise.
5394
4ae29f89
SM
53952012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5396
5397 * print.c (print_preprocess): Only check print_depth if print-circle
5398 is nil.
5399 (print_object): Check for cycles even when print-circle is nil and
5400 print-gensym is t, but only check print_depth if print-circle is nil.
5401
f30d612a
CY
54022012-04-20 Chong Yidong <cyd@gnu.org>
5403
5404 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5405 set the status to "failed" and ensure that sentinel is run.
5406
c07a4c0b 54072012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5408
5409 * process.c (Fset_process_inherit_coding_system_flag)
5410 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5411 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5412
c07a4c0b 54132012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5414
5415 * xdisp.c (string_buffer_position_lim): Limit starting position to
5416 BEGV.
5417 (set_cursor_from_row): If called for a mode-line or header-line
5418 row, return zero immediately.
5419 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5420 farther than the first row after the header line, if any.
5421 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5422 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5423
c07a4c0b 54242012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5425
4ae29f89
SM
5426 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5427 (bug#11238).
ad3a2b41 5428
c07a4c0b 54292012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 54302012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5431
5432 configure: new option --enable-gcc-warnings (Bug#11207)
5433 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5434 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5435 (ALL_CFLAGS): Use new macros rather than old.
5436 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5437 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5438 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5439 -Wunused-result, -Wunused-variable. This should go away once
5440 the Emacs and Gnulib regex code is merged.
5441 (xmalloc, xrealloc): Now static.
5442
aba027e8
PE
54432012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5444
5445 * dired.c (Fsystem_groups): Remove unused local.
5446
e5a36063
GM
54472012-04-17 Glenn Morris <rgm@gnu.org>
5448
5449 * dired.c (Fsystem_users): Doc fix.
5450
316411f0
DA
54512012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5452
5453 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5454 (syms_of_dired): Add them.
5455
9426aba4
PE
54562012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5457
b62a57be
PE
5458 Fix minor alloc.c problems found by static checking.
5459 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5460 New extern decls, to avoid calling undeclared functions.
5461 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5462 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5463 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5464 (NEED_MEM_INSERT): New macro.
5465 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5466 Remove one incorrect comment and fix another.
b62a57be 5467
3539f31f
PE
5468 Fix minor ralloc.c problems found by static checking.
5469 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5470 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5471 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5472 (r_alloc_sbrk): Now static.
5473
a041960a
PE
5474 Improve ralloc.c interface checking.
5475 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5476 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5477 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5478 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5479 [REL_ALLOC]: ... to here, to check interface.
5480 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5481 Remove decls. This fixes an "It stinks!".
5482
9426aba4
PE
5483 * alloc.c (which_symbols): Fix alignment issue / type clash.
5484
d55c12ed
AS
54852012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5486
5487 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5488 (struct Lisp_Misc_Any): Likewise.
5489 (struct Lisp_Free): Likewise.
5490 * alloc.c (union aligned_Lisp_Symbol): Define.
5491 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5492 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5493 (union aligned_Lisp_Misc): Define.
5494 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5495 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5496 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5497
b948ce8b
PE
54982012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5499
5500 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5501 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5502 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5503 * s/netbsd.h, s/sol2-6.h:
5504 Remove definition of GC_MARK_STACK, since the default now works.
5505 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5506 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5507 no longer the default.
5508 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5509
35dc09a1 55102012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5511
35dc09a1
GM
5512 * lread.c (lisp_file_lexically_bound_p):
5513 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5514
35dc09a1
GM
55152012-04-14 Eli Zaretskii <eliz@gnu.org>
5516
5517 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5518 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5519
55202012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5521
5522 * nsterm.m (constrainFrameRect): Always constrain when there is only
5523 one screen (Bug#10962).
5524
bcd86815
KB
55252012-04-13 Ken Brown <kbrown@cornell.edu>
5526
5527 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5528
c25df26e
RT
55292012-04-13 Reuben Thomas <rrt@sc3d.org>
5530
5531 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5532
0fc59f1e
DC
55332012-04-11 Daniel Colascione <dancol@dancol.org>
5534
5535 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5536 against is gone. It's better to use vfork now so that when Cygwin
5537 gains a new, working vfork, we use it automatically (bug#10398).
5538
de8c03dc
SM
55392012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5540
5541 * window.c (save_window_save): Obey window-point-insertion-type.
5542
2f097256
GM
55432012-04-11 Glenn Morris <rgm@gnu.org>
5544
5545 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5546
453b951e
SM
55472012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5548
5549 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5550
75f1671a 55512012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5552
5553 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5554 (force_quit_count): New var.
5555 (handle_interrupt): Use it.
5556
2a8ce227
JB
55572012-04-10 Juanma Barranquero <lekktu@gmail.com>
5558
5559 * w32.c (w32_delayed_load): Record the full path of the library
5560 being loaded (bug#10424).
5561
935396c0
GM
55622012-04-09 Glenn Morris <rgm@gnu.org>
5563
05920a43
GM
5564 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5565 not just in the obarray, before snarfing them. (Bug#11036)
5566
935396c0
GM
5567 * Makefile.in ($(leimdir)/leim-list.el):
5568 Pass EMACS rather than BUILT_EMACS.
5569
a18ecafa
TZ
55702012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5571
5572 * process.c (make_process):
5573 * process.h: Add integer `gnutls_handshakes_tried' member to
5574 process struct.
5575
6bbef4e5
JC
5576 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5577 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5578
5579 * gnutls.c (gnutls_log_function2i): Convenience log function.
5580 (emacs_gnutls_read): Use new log functions,
5581 `gnutls_handshakes_tried' process member, and
5582 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5583 attempts per process (connection).
5584
b4d3bc10
CY
55852012-04-09 Chong Yidong <cyd@gnu.org>
5586
5587 * eval.c (Fuser_variable_p, user_variable_p_eh)
5588 (lisp_indirect_variable): Functions deleted.
5589 (Fdefvar): Caller changed.
5590
5591 * callint.c (Finteractive, Fcall_interactively):
5592 * minibuf.c (Fread_variable): Callers changed.
5593
70f4d973
EZ
55942012-04-09 Eli Zaretskii <eliz@gnu.org>
5595
5596 * xdisp.c (set_cursor_from_row): If the display string appears in
5597 the buffer at position that is closer to point than the position
5598 after the display string, display the cursor on the first glyph of
5599 the display string. Fixes cursor display when a 'display' text
5600 property immediately follows invisible text. (Bug#11094)
5601
cb3c2e3e
PE
56022012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5603
5604 composite.c: use 'double' consistently
5605 * composite.c (get_composition_id): Use 'double' consistently
5606 instead of converting 'float' to 'double' and vice versa; this is
5607 easier to understand and avoids a GCC warning.
5608
fd06db5d
GM
56092012-04-09 Glenn Morris <rgm@gnu.org>
5610
50fe702a
GM
5611 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5612 preparation for dumping it with emacs. (Bug#4789)
5613 (leimdir): New variable.
5614 ($(leimdir)/leim-list.el): New rule.
5615 (emacs$(EXEEXT)): Depend on leim-list.el.
5616
fd06db5d
GM
5617 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5618 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5619 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5620
55c131ee
AS
56212012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5622
5623 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5624 proper alignment.
5625
9209588f
JB
56262012-04-07 Juanma Barranquero <lekktu@gmail.com>
5627
5628 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5629 Remove unused local variable.
5630
e3fb2efb
PE
56312012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5632
5633 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5634 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5635 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5636 objects, as mark_maybe_pointer will catch them otherwise.
5637 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5638 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5639
b5385551
PE
56402012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5641
5642 Fix typo that broke non-Windows builds.
5643 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5644
9078ead6
EZ
56452012-04-07 Eli Zaretskii <eliz@gnu.org>
5646
5647 Support building on MS-Windows with libxml2.
5648
5649 * makefile.w32-in (OBJ2): Add xml.$(O).
5650 (GLOBAL_SOURCES): Add xml.c.
5651 ($(BLD)/xml.$(O)): New dependency list.
5652
5653 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5654 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5655 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5656 [!WINDOWSNT]: New macros.
5657 (init_libxml2_functions, libxml2_loaded_p): New functions.
5658 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5659 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5660 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5661 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5662 linked in).
6bbef4e5
JC
5663 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5664 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5665 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5666
5667 * emacs.c: Don't include libxml/parser.h.
5668 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5669 xmlCleanupParser directly.
5670
5671 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5672
3811fdf3
EZ
56732012-04-07 Eli Zaretskii <eliz@gnu.org>
5674
5675 * indent.c (Fvertical_motion): If there is a display string at
5676 point, use it.vpos to compute how many lines to backtrack after
5677 move_it_to point. (Bug#11133)
5678
2f8e16b2
EZ
56792012-04-06 Eli Zaretskii <eliz@gnu.org>
5680
5681 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5682 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5683 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5684 macros related to unification of CJK characters. For the details,
5685 see the discussion following the message here:
5686 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5687
3d439cd1
CY
56882012-04-04 Chong Yidong <cyd@gnu.org>
5689
5690 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5691
8bc53d00
EZ
56922012-04-01 Eli Zaretskii <eliz@gnu.org>
5693
5694 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5695 instead of alloca. (Bug#11138)
5696
3b0512a3
AS
56972012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5698
5699 * w32menu.c (is_simple_dialog): Properly check lisp types.
5700 (Bug#11141)
5701
8427ddd2
EZ
57022012-03-31 Eli Zaretskii <eliz@gnu.org>
5703
979022ef
EZ
5704 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5705 position we get to after a call to move_it_to fails the
5706 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5707 only if we wind up in a string from display property. (Bug#11063)
5708
a6b1c7cc
EZ
5709 * window.c (Fdelete_other_windows_internal): Invalidate the row
5710 and column information about mouse highlight, so that redisplay
5711 restores it after reallocating the glyph matrices. (Bug#7464)
5712
8427ddd2
EZ
5713 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5714 string comes from a `display' text property, use the buffer
5715 position of that property as if we actually saw that position in
5716 the row's glyphs.
697ba24b
EZ
5717 (move_it_by_lines): Remove the assertion that
5718 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5719 violated when there's a before-string at the beginning of a line.
5720 (Bug#11063)
8427ddd2 5721
65a0a738
EZ
57222012-03-30 Eli Zaretskii <eliz@gnu.org>
5723
5724 * xdisp.c (append_space_for_newline): If the default face was
5725 remapped, use the remapped face for the appended newline.
5726 (extend_face_to_end_of_line): Use the remapped default face for
5727 extending the face to the end of the line.
5728 (display_line): Call extend_face_to_end_of_line when the default
5729 face was remapped. (Bug#11068)
5730
581355cc
EZ
57312012-03-29 Eli Zaretskii <eliz@gnu.org>
5732
5733 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5734
e8fc049f
SM
57352012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5736
5737 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5738
4fb9a543
GM
57392012-03-27 Glenn Morris <rgm@gnu.org>
5740
5741 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5742 Doc fixes.
5743
679910f1
KH
57442012-03-26 Kenichi Handa <handa@m17n.org>
5745
5746 * dispextern.h (struct glyph): Fix previous change. Change the
5747 bit length of glyphless.ch to 25 (Bug#11082).
5748
90d49b7f
CY
57492012-03-26 Chong Yidong <cyd@gnu.org>
5750
5751 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5752 (command_loop_1): Use it; inhibit selection update for
5753 handle-select-window too (Bug#8996).
5754
f514f6f0
FP
57552012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5756
e8fc049f 5757 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5758
bf43fa51
KH
57592012-03-25 Kenichi Handa <handa@m17n.org>
5760
5761 * dispextern.h (struct glyph): Change the bit length of
5762 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5763
8a0c01dd
EZ
57642012-03-24 Eli Zaretskii <eliz@gnu.org>
5765
5766 * s/ms-w32.h (tzname): Include time.h before redirecting to
5767 _tzname. Fixes the MSVC build. (Bug#9960)
5768
7d1c3a76
AS
57692012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5770
8ed79523
AS
5771 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5772 characters.
5773
7d1c3a76
AS
5774 * xterm.c (XTread_socket): Only modify handling_signal if
5775 !SYNC_INPUT. (Bug#11080)
5776
e99a9b8b
EZ
57772012-03-23 Eli Zaretskii <eliz@gnu.org>
5778
5779 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5780 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5781 when fetching a multibyte character consumes more bytes than
5782 CHAR_BYTES returns, due to unification of CJK characters in
5783 string_char. (Bug#11073)
5784
5063c0e1
TN
57852012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5786
5787 * process.c (wait_reading_process_output): Handle pty disconnect
5788 by refraining from sending oneself a SIGCHLD (bug#10933).
5789
9f851fbd
CY
57902012-03-22 Chong Yidong <cyd@gnu.org>
5791
5792 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5793
5063c0e1 5794 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5795 Mark string as coming from a prefix property.
5796 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5797 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5798
fb5b8aca
CY
57992012-03-21 Chong Yidong <cyd@gnu.org>
5800
5801 * xfaces.c (Vface_remapping_alist): Doc fix.
5802
62356a1b
EZ
58032012-03-20 Eli Zaretskii <eliz@gnu.org>
5804
5805 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5806 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5807 Doc fixes.
62356a1b 5808
025de85b
CY
58092012-03-20 Chong Yidong <cyd@gnu.org>
5810
5811 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5812 to reflect default non-nil value of redisplay-dont-pause.
5813
4827f94e
KH
58142012-03-19 Kenichi Handa <handa@m17n.org>
5815
5816 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5817 it fit in a valid range (Bug#11003).
5818
e50a24a2
EZ
58192012-03-18 Eli Zaretskii <eliz@gnu.org>
5820
5821 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5822 that is not from display property, accept the row as a "cursor
5823 row" if one of the string's character has a non-nil `cursor'
5824 property. Fixes cursor positioning when there are newlines in
5825 overlay strings, e.g. in icomplete.el. (Bug#11035)
5826
9af5ed87
PE
58272012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5828
5829 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5830
d1f55f16
CY
58312012-03-12 Chong Yidong <cyd@gnu.org>
5832
5833 * eval.c (inhibit_lisp_code): Rename from
5834 inhibit_window_configuration_change_hook; move from window.c.
5835
5836 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5837 * window.c (run_window_configuration_change_hook)
5838 (syms_of_window): Callers changed.
5839
66c5eebd
CY
58402012-03-11 Chong Yidong <cyd@gnu.org>
5841
413df973
CY
5842 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5843
66c5eebd
CY
5844 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5845
1de11f56
CY
58462012-03-10 Chong Yidong <cyd@gnu.org>
5847
5848 * frame.c (other_visible_frames): Don't assume the selected frame
5849 is visible (Bug#10955).
5850
cae07000
SM
58512012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5852
5853 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5854
89c94350
JD
58552012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5856
5857 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5858 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5859 zero (Bug#10954).
5860
999dd333
GM
58612012-03-03 Glenn Morris <rgm@gnu.org>
5862
01a6dcc8 5863 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5864
de0100f2
EZ
58652012-03-02 Eli Zaretskii <eliz@gnu.org>
5866
5867 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5868 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5869 (redisplay_window, next_element_from_string): Fix typos in
5870 comments.
3e441275
EZ
5871 (redisplay_window): Pass to move_it_vertically the margin in
5872 pixels, not in screen lines.
de0100f2 5873
96a72ee9
GM
58742012-03-02 Glenn Morris <rgm@gnu.org>
5875
5876 * buffer.c (buffer-list-update-hook): Doc fix.
5877
312508d7
EZ
58782012-02-29 Eli Zaretskii <eliz@gnu.org>
5879
5880 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5881 push_it before setting up the iterator for the first overlay
5882 string, even if we have an empty string loaded.
5883 (next_overlay_string): If there's an empty string on the iterator
5884 stack, pop the stack. (Bug#10903)
5885
27f3c637
PE
58862012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5887
5888 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5889 Suggested by Stefan Monnier in
5890 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5891 * alloc.c (widen_to_Lisp_Object): New static function.
5892 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5893 and widening them to Lisp_Objects. This would work even if
5894 USE_LSB_TAG is defined and wide integers are used, which might
5895 happen in a future version of Emacs.
5896
3c9dfce6
CY
58972012-02-25 Chong Yidong <cyd@gnu.org>
5898
fa74b241
CY
5899 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5900 Doc fix.
5901
3c9dfce6
CY
5902 * xselect.c (Fx_selection_exists_p): Doc fix.
5903 (x_clipboard_manager_save_all): Print an informative message
5904 before saving to clipboard manager.
5905
9486df08
CY
59062012-02-24 Chong Yidong <cyd@gnu.org>
5907
5908 * keyboard.c (process_special_events): Handle all X selection
5909 requests in kbd_buffer, not just the next one (Bug#8869).
5910
f01d3321
CY
59112012-02-23 Chong Yidong <cyd@gnu.org>
5912
5913 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5914 call when setting menu-bar-lines and tool-bar-lines parameters.
5915 (unwind_create_frame_1): New helper function.
5916
5917 * window.c (inhibit_window_configuration_change_hook): New var.
5918 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5919 (syms_of_window): Initialize it.
f01d3321 5920
86b847b6
CY
59212012-02-22 Chong Yidong <cyd@gnu.org>
5922
5923 * xterm.c (x_draw_image_relief): Add missing type check for
5924 Vtool_bar_button_margin (Bug#10743).
5925
a59225b1
CY
59262012-02-21 Chong Yidong <cyd@gnu.org>
5927
5928 * fileio.c (Vfile_name_handler_alist): Doc fix.
5929
5930 * buffer.c (Fget_file_buffer): Protect against invalid file
5931 handler return value.
5932
310f5bd4
PE
59332012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5934
cb3a28cc
PE
5935 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5936 when computing $valmask.
5937
310f5bd4
PE
5938 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5939 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5940 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5941 It's useless in that case, and it can cause problems on hosts
5942 that allocate halves of EMACS_INT values separately.
5943 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5944 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5945 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5946 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5947 it avoids undefined behavior on hosts where shifting right by more
5948 than the word width has undefined behavior.
5949
2375c96a
CY
59502012-02-19 Chong Yidong <cyd@gnu.org>
5951
5952 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5953 (Funhandled_file_name_directory, Ffile_name_as_directory)
5954 (Fdirectory_file_name, Fexpand_file_name)
5955 (Fsubstitute_in_file_name): Protect against invalid file handler
5956 return values (Bug#10845).
5957
3eb49e71
EZ
59582012-02-18 Eli Zaretskii <eliz@gnu.org>
5959
5960 * .gdbinit (pitx): Fix incorrect references to fields of the
5961 iterator stack.
5962
7b926f3f
CY
59632012-02-17 Chong Yidong <cyd@gnu.org>
5964
5965 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5966
11273115
PE
59672012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5968
5969 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5970 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5971
c3a70e2b
CY
59722012-02-15 Chong Yidong <cyd@gnu.org>
5973
5974 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5975 marked as special. Also, starting docstrings with * is obsolete.
5976
0ca43699
AS
59772012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5978
5979 * gnutls.c (emacs_gnutls_write): Fix last change.
5980
2e8f3c56
LI
59812012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5982
5983 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5984 send_process.
5985
af70074f
SM
59862012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5987
5988 * keymap.c (Fsingle_key_description): Handle char ranges.
5989
95986d52
CY
59902012-02-12 Chong Yidong <cyd@gnu.org>
5991
afd83bd1
CY
5992 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5993 as that creates a dangerous corner case.
5994
95986d52
CY
5995 * window.c (Fdelete_window_internal): Invalidate the mouse
5996 highlight (Bug#9904).
5997
bd7da63e
GM
59982012-02-12 Glenn Morris <rgm@gnu.org>
5999
6000 * xselect.c (Fx_own_selection_internal)
6001 (Fx_get_selection_internal, Fx_disown_selection_internal)
6002 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6003 * nsselect.m (Fx_own_selection_internal)
6004 (Fx_disown_selection_internal, Fx_selection_exists_p)
6005 (Fx_selection_owner_p, Fx_get_selection_internal):
6006 Sync docs and argument specs with the xselect.c versions.
6007
77abcbc2
LI
60082012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6009
6010 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6011
90b671e2
EZ
60122012-02-11 Eli Zaretskii <eliz@gnu.org>
6013
1c0ca0b7
EZ
6014 * w32select.c (Fx_selection_exists_p): Sync doc string and
6015 argument list with xselect.c. (Bug#10783)
6016
6017 * w16select.c (Fx_selection_exists_p): Sync doc string and
6018 argument list with xselect.c. (Bug#10783)
90b671e2 6019
49241268
GM
60202012-02-10 Glenn Morris <rgm@gnu.org>
6021
6022 * fns.c (Fsecure_hash): Doc fix.
6023
f998bbe7 60242012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6025
6026 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6027
0992bd9c
CY
60282012-02-07 Chong Yidong <cyd@gnu.org>
6029
6030 * buffer.c (Fbuffer_local_variables)
6031 (buffer_lisp_local_variables): Handle unbound vars correctly;
6032 don't let Qunbound leak into Lisp.
6033
af008560
GM
60342012-02-07 Glenn Morris <rgm@gnu.org>
6035
dd605cc4
GM
6036 * image.c (Fimagemagick_types): Doc fix.
6037
af008560
GM
6038 * image.c (imagemagick-render-type): Change it from a lisp object
6039 to an integer. Move the doc here from the lisp manual.
6040 Treat all values not equal to 0 the same.
6041
1449fa1d
CY
60422012-02-06 Chong Yidong <cyd@gnu.org>
6043
6044 * doc.c (store_function_docstring): Avoid applying docstring of
6045 alias to base function (Bug#2603).
6046
3723ec07
AS
60472012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6048
6049 * .gdbinit (pp1, pv1): Remove redundant defines.
6050 (pr): Use pp.
6051
79c1cc1e
CY
60522012-02-04 Chong Yidong <cyd@gnu.org>
6053
6054 * nsterm.m: Declare a global (Bug#10694).
6055
d7f29f8e
EZ
60562012-02-04 Eli Zaretskii <eliz@gnu.org>
6057
cae07000
SM
6058 * w32.c (get_emacs_configuration_options):
6059 Include --enable-checking, if specified, in the return value.
d7f29f8e 6060
3b95a6f9
MR
60612012-02-04 Martin Rudalics <rudalics@gmx.at>
6062
6063 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6064 after rounding frame sizes. (Bug#9723)
6065
d6fa96a6
EZ
60662012-02-04 Eli Zaretskii <eliz@gnu.org>
6067
6068 * keyboard.c (adjust_point_for_property): Don't position point
6069 before BEGV. (Bug#10696)
6070
df0b2940
PE
60712012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6072
6073 Handle overflow when computing char display width (Bug#9496).
6074 * character.c (char_width): Return EMACS_INT, not int.
6075 (char_width, c_string_width): Check for overflow when
6076 computing the width; this is possible now that individual
6077 characters can have unbounded width. Problem introduced
6078 by merge from Emacs 23 on 2012-01-19.
6079
6bee44d6
MA
60802012-02-02 Michael Albinus <michael.albinus@gmx.de>
6081
6082 * dbusbind.c (Fdbus_register_method): Mention the return value
6083 :ignore in the docstring.
6084
44f92739
GM
60852012-02-02 Glenn Morris <rgm@gnu.org>
6086
1b9f60cc
GM
6087 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6088
44f92739
GM
6089 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6090 Unconditionally set to t. (Bug#10673)
6091 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6092 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6093 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6094
c5d3843c
KH
60952012-02-02 Kenichi Handa <handa@m17n.org>
6096
6097 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6098 0, do not call append_composite_glyph.
6099
159462d4 61002012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6101
6102 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6103 NULL (Bug#6988).
6104 (x_produce_glyphs): If the component of a composition is a null
6105 string, set it->pixel_width to 1 to avoid zero-width glyph.
6106
78cef877
EZ
61072012-02-01 Eli Zaretskii <eliz@gnu.org>
6108
6109 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6110 first 2 arguments are identical. This makes inserting large
6111 output from a subprocess an order of magnitude faster on
6112 MS-Windows, where all sbrk'ed memory is always contiguous.
6113
97897668
GM
61142012-01-31 Glenn Morris <rgm@gnu.org>
6115
6116 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6117 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6118 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6119
31fd3586
GM
61202012-01-29 Glenn Morris <rgm@gnu.org>
6121
6122 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6123
0e24a8b2
CY
61242012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6125
6126 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6127
cc0adcb0
CY
61282012-01-28 Chong Yidong <cyd@gnu.org>
6129
6130 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6131
acc28cb9
CY
61322012-01-26 Chong Yidong <cyd@gnu.org>
6133
9c69cfb7
CY
6134 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6135
acc28cb9
CY
6136 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6137 repeat counts (Bug#10507).
6138
48da7392
GM
61392012-01-26 Glenn Morris <rgm@gnu.org>
6140
6141 * lread.c (syms_of_lread): Doc fix.
6142
14af5f7f
CY
61432012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6144
6145 * coding.c (encode_designation_at_bol): Change return value to
6146 EMACS_INT.
6147
0b21c100
CY
61482012-01-25 Chong Yidong <cyd@gnu.org>
6149
6150 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6151
3c2907f7
CY
61522012-01-21 Chong Yidong <cyd@gnu.org>
6153
6154 * floatfns.c (Fcopysign): Make the second argument non-optional,
6155 since nil is not allowed anyway.
6156
959ad23f
AS
61572012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6158
6159 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6160 (send_process): Likewise.
6161
34a02f46
MR
61622012-01-19 Martin Rudalics <rudalics@gmx.at>
6163
6164 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6165 (Vwindow_persistent_parameters): Do not use Qstate.
6166 Rewrite doc-strings.
34a02f46 6167
1259009a 61682012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6169
6170 * character.c (char_width): New function.
70d4fdf6
GM
6171 (Fchar_width, c_string_width, lisp_string_width):
6172 Use char_width (Bug#9496).
25ed9e61 6173
6a6ee00d
MR
61742012-01-16 Martin Rudalics <rudalics@gmx.at>
6175
6176 * window.c (Vwindow_persistent_parameters): New variable.
6177 (Fset_window_configuration, save_window_save): Handle persistent
6178 window parameters.
6179
c85efaf7
EZ
61802012-01-14 Eli Zaretskii <eliz@gnu.org>
6181
6182 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6183 thrashing the stack of the thread. (Bug#9087)
6184
5944709e
PE
61852012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6186
6187 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6188
e71f5d99
EZ
61892012-01-11 Eli Zaretskii <eliz@gnu.org>
6190
6191 * xdisp.c (rows_from_pos_range): Handle the case where the
6192 highlight ends on a newline. (Bug#10464)
6193 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6194 he end column for display of highlight that ends on a newline
6195 before a R2L line.
6196
ce316182
GM
61972012-01-11 Glenn Morris <rgm@gnu.org>
6198
6199 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6200 from load-path also when installation-directory is nil. (Bug#10208)
6201
5b43da69
GM
62022012-01-10 Glenn Morris <rgm@gnu.org>
6203
74cc8ff9
GM
6204 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6205
7d8d6e4e
GM
6206 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6207 Update template values to be closer to their typical values these days.
5b43da69 6208
a0db8d43
EZ
62092012-01-09 Eli Zaretskii <eliz@gnu.org>
6210
6211 * xdisp.c (rows_from_pos_range): Accept additional argument
6212 DISP_STRING, and accept any glyph in a row whose object is that
6213 string as eligible for mouse highlight. Fixes mouse highlight of
6214 display strings from overlays. (Bug#10464)
6215
9a0115ab 62162012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6217
b9110d6a 6218 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6219 * fileio.c (auto_saving_dir_umask): New static var.
6220 (Fmake_directory_internal): Use it.
6221 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6222 creating the directory. The old code temporarily assigns
6223 too-generous permissions to the directory.
6224 (do_auto_save_eh): Clear it.
b9110d6a 6225 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6226 that the var is always cleared.
6227
6c1bd3f3
EZ
62282012-01-07 Eli Zaretskii <eliz@gnu.org>
6229
6230 * search.c (scan_buffer): Pass character positions to
6231 know_region_cache, not byte positions. (Bug#6540)
6232
069d2b50
L
62332012-01-07 LynX <_LynX@bk.ru> (tiny change)
6234
6235 * w32.c (sys_rename): Report EXDEV when rename of a directory
6236 fails because the target is on another logical disk. (Bug#10284)
6237
75bf0d33
DB
62382012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6239
6240 * xterm.c (x_embed_request_focus): New function.
6241
6242 * xterm.h: Add prototype.
6243
6244 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6245
1c6e5a32
GM
62462012-01-05 Glenn Morris <rgm@gnu.org>
6247
6248 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6249
651e947e
EZ
62502012-01-01 Eli Zaretskii <eliz@gnu.org>
6251
6252 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6253 Load gnutls_transport_set_lowat only if GnuTLS version is below
6254 2.11.1.
6255 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6256 GnuTLS versions below 2.11.1.
6257
3778cdd8
AL
62582011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6259
6260 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6261 to the doc string advising against its use for altering the way
6262 windows are scrolled.
6263
0e5317f7
KH
62642011-12-28 Kenichi Handa <handa@m17n.org>
6265
6266 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6267 coding-system ASCII compatible only when it does not produce BOM
6268 on encoding (Bug#10383).
6269
93d5ca1f
JD
62702011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6271
6272 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6273 can scroll.
6274 (create_and_show_popup_menu): Always use menu_position_func for
6275 Gtk3 (Bug#10361).
6276
ca22b785
AS
62772011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6278
6279 * callint.c (Fcall_interactively): Don't truncate prompt string.
6280
d048e1e6
EZ
62812011-12-23 Eli Zaretskii <eliz@gnu.org>
6282
6283 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6284 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6285 resumed from there (after widening). (Bug#10360)
d048e1e6 6286
5ccaba1f
JD
62872011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6288
6289 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6290
204ee57f
JD
62912011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6292
b81d40f0
JB
6293 * nsterm.m (x_free_frame_resources):
6294 Release f->output_data.ns->miniimage.
204ee57f
JD
6295 (ns_index_color): Fix indentation. Do not retain
6296 color_table->colors[i].
6297
6298 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6299 before returning.
6300
6301 * nsfns.m (x_set_background_color): Assign return value from
6302 ns_index_color to face-background instead of NSColor*.
6303 (ns_implicitly_set_icon_type): Fix indentation.
6304 Change assignment in for loop to comparison.
6305
6306 * emacs.c (ns_pool): New variable.
6307 (main): Assign ns_pool.
6308 (Fkill_emacs): Call ns_release_autorelease_pool.
6309
6310 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6311 autorelease fdesc, release fdAttrs and tdict.
6312 (ns_get_covering_families): Release charset.
6313 (ns_findfonts): Release NSFontDescriptor created with new.
6314 (ns_uni_to_glyphs): Fix indentation.
6315 (setString): Release attrStr before assigning new value.
6316
c803b2b7
JD
63172011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6318
678f4426
JD
6319 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6320 and NS_IMPL_COCOA.
6321 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6322 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6323
cd394be1 63242011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6325
5fecd5fc
JD
6326 * nsterm.m (ns_term_init): Subscribe for notifications
6327 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6328 to method trackingNotification in EmacsMenu.
6329
6330 * nsmenu.m (trackingMenu): New variable.
3771cb17 6331 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6332 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6333 from Aquamacs (Bug#7030).
678f4426
JD
6334
63352011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6336
c803b2b7
JD
6337 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6338 (symbol_to_nsstring): Fix indentation.
6339 (ns_symbol_to_pb): New function.
cae07000
SM
6340 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6341 (Fns_rotate_cut_buffers_internal): Remove.
6342 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6343 Fns_store_cut_buffer_internal.
6344 (ns_get_foreign_selection, Fx_own_selection_internal)
6345 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6346 (Fns_get_selection_internal, Fns_store_selection_internal):
6347 Use ns_symbol_to_pb and check if return value is nil.
6348 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6349 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6350 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6351 renamed to Sns_store_selection_internal.
6352 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6353 and remove this function.
6354 (ns_handle_selection_clear): Remove, never used.
6355 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6356 here.
6357
e1b01a3a
KB
63582011-12-17 Ken Brown <kbrown@cornell.edu>
6359
6360 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6361 GID is unknown (Bug#10257).
6362
2adb6e85
PE
63632011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6364
6365 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6366 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6367 which caused a build failure on GNU/Linux IA-64. This problem was
6368 introduced by my 2011-10-07 patch.
6369
d1d7b339
JL
63702011-12-15 Juri Linkov <juri@jurta.org>
6371
6372 * image.c (imagemagick_error): New function. (Bug#10112)
6373 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6374 Use `imagemagick_error' where ImageMagick functions return
6375 `MagickFalse'.
6376 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6377 proper order.
6378
100d5755
KH
63792011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6380
6381 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6382 fill background (Bug#8992).
6383
454592a6
MR
63842011-12-13 Martin Rudalics <rudalics@gmx.at>
6385
6386 * window.c (Vwindow_combination_resize)
6387 (Vwindow_combination_limit): Use t instead of non-nil in
6388 doc-strings.
61d4b438
MR
6389 (Vrecenter_redisplay): Add first sentence of doc-string on
6390 separate line.
53524d93 6391 (Frecenter): Fix doc-string typo.
454592a6 6392
3633e3aa
KH
63932011-12-11 Kenichi Handa <handa@m17n.org>
6394
6395 * coding.c (Funencodable_char_position): Pay attention to the
6396 buffer text relocation (Bug#9389).
6397
7b9d523a 63982011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6399
7b9d523a
JD
6400 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6401 gtk_init (Bug#10100).
6402
b73189c6
EZ
64032011-12-10 Eli Zaretskii <eliz@gnu.org>
6404
6405 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6406 IT->string is nil. (Bug#10263)
6407
f7dfe5d6
JD
64082011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6409
83faebb4
JD
6410 * nsterm.h (x_free_frame_resources): Declare.
6411
f7dfe5d6
JD
6412 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6413 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6414
6415 * nsterm.h (ns_get_defaults_value): Declare.
6416
6417 * nsterm.m (ns_default): Call ns_get_defaults_value.
6418
7cd4e72c
EZ
64192011-12-09 Eli Zaretskii <eliz@gnu.org>
6420
6421 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6422 (Bug#10170)
6423
b34d7317
YM
64242011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6425
6426 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6427 that where the value of an _OBJC_* symbol points to is in the .bss
6428 section (Bug#10240).
6429
76470ad1
KH
64302011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6431
6432 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6433 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6434
745fff94
KH
64352011-12-08 Kenichi Handa <handa@m17n.org>
6436
6437 * ftfont.c (get_adstyle_property): Fix previous change
6438 (Bug#10233).
6439
6e44397c
JB
64402011-12-07 Juanma Barranquero <lekktu@gmail.com>
6441
6442 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6443 dirs from the default value of EMACSLOADPATH (bug#10208).
6444
7efa6272
GM
64452011-12-07 Glenn Morris <rgm@gnu.org>
6446
6447 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6448 installation and source directories as well. (Bug#10208)
6449
f6fc4d87
CY
64502011-12-06 Chong Yidong <cyd@gnu.org>
6451
6452 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6453
2bf26180
GM
64542011-12-06 Glenn Morris <rgm@gnu.org>
6455
6456 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6457 as an error, not just -1. (Bug#10217)
6458
3a6ad4f0
CY
64592011-12-05 Chong Yidong <cyd@gnu.org>
6460
6461 * keyboard.c (process_special_events): New function.
6462 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6463
75a3b399
PE
64642011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6465
6466 * coding.c (encode_designation_at_bol): Don't use uninitialized
6467 local variable (Bug#9318).
6468
c3c9e25e
KH
64692011-12-05 Kenichi Handa <handa@m17n.org>
6470
6471 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6472 return Qnil (Bug#8046, Bug#10193).
6473
5eb05ea3
KH
64742011-12-05 Kenichi Handa <handa@m17n.org>
6475
6476 * coding.c (encode_designation_at_bol): New args charbuf_end and
6477 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6478 (coding_set_source): Return how many bytes coding->source was
6479 relocated.
6480 (coding_set_destination): Return how many bytes
6481 coding->destination was relocated.
6482 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6483 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6484
64852011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6486
6487 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6488 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6489 macro (Bug#9318).
6490
64912011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6492
6493 The following changes are to fix Bug#9318.
6494
a79703f5 6495 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6496 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6497 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6498 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6499
7dbda6df
JB
65002011-12-05 Juanma Barranquero <lekktu@gmail.com>
6501
6502 * lisp.h (process_quit_flag): Fix external declaration.
6503
6d5eb5b0
SM
65042011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6505
6506 Don't macro-inline non-performance-critical code.
6507 * eval.c (process_quit_flag): New function.
6508 * lisp.h (QUIT): Use it.
6509
a0c3fad0
JD
65102011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6511
6512 * nsfns.m (get_geometry_from_preferences): New function.
6513 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6514
6c07aac2
AS
65152011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6516
6517 * emacs.c (Qkill_emacs): Define.
6518 (syms_of_emacs): Initialize it.
6519 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6520 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6521 (quit_throw_to_read_char): Add parameter `from_signal'.
6522 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6523 * lisp.h (QUIT): Call Fkill_emacs if requested.
6524
c052ead4
JD
65252011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6526
6527 * widget.c (update_wm_hints): Return if wmshell is null.
6528 (widget_update_wm_size_hints): New function.
6529
6530 * widget.h (widget_update_wm_size_hints): Declare.
6531
6532 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6533 widget_update_wm_size_hints (Bug#10104).
6534
9e49252b
EZ
65352011-12-03 Eli Zaretskii <eliz@gnu.org>
6536
6537 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6538 before a newline, prepare the bidi iterator for consuming the
6539 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6540 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6541
02b16839
JL
65422011-12-02 Juri Linkov <juri@jurta.org>
6543
6544 * search.c (Fword_search_regexp): New Lisp function created from
6545 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6546 (Fword_search_backward, Fword_search_forward)
6547 (Fword_search_backward_lax, Fword_search_forward_lax):
6548 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6549 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6550
0068070e
SM
65512011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6552
6553 * fileio.c (Finsert_file_contents): Move after-change-function call
6554 to before the "handled:" label, since all "goto handled" appear in
6555 cases where the *-change-functions have already been properly called
6556 (bug#10117).
6557
3360a3fc
AS
65582011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6559
6560 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6561 waiting for input. (Bug#10169)
6562
73d6c093
EZ
65632011-11-30 Eli Zaretskii <eliz@gnu.org>
6564
6565 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6566 verifies glyph row's hash code--we have just reallocated the
6567 glyphs, so their contents can be complete garbage. (Bug#10164)
6568
febe6bea
JB
65692011-11-30 Juanma Barranquero <lekktu@gmail.com>
6570
6571 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6572
801a4313
EZ
65732011-11-30 Eli Zaretskii <eliz@gnu.org>
6574
6575 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6576 attributes are tested _before_ calling verify_row_hash, to protect
6577 against GCC re-ordering of the tests. (Bug#10164)
6578
2b56b87e
JD
65792011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6580
6581 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6582
6583 * xterm.c (handle_one_xevent): Only set async_visible and friends
6584 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6585 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6586 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6587
dbf31225
PE
65882011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6589
6590 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6591 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6592 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6593 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6594 All uses changed to use GCPRO1 etc.
6595 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6596 Revert to old implementation (i.e., before 2011-03-11).
6597
1305621b
YM
65982011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6599
6600 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6601 of scroll runs so as to avoid assigning disabled bogus rows and
6602 unnecessary graphics copy operations.
6603
8c9afb46
EZ
66042011-11-27 Eli Zaretskii <eliz@gnu.org>
6605
6606 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6607 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6608 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6609 (malloc, free, realloc, calloc): Redirect to e_* only when
6610 compiling Emacs.
6611
6612 * lisp.h (GCTYPEBITS): Move before first use.
6613 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6614 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6615 this macro definition.
6616
6617 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6618 _MSC_VER.
6619
54e9e3bf
JD
66202011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6621
6d5eb5b0
SM
6622 * gtkutil.c (xg_create_frame_widgets):
6623 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6624 present with Gtk+ 2.0.
6625
83aca1cb
PE
66262011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6627
6628 * fileio.c (Finsert_file_contents): Undo previous change; see
6629 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6630
5b76caa4
PE
66312011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6632
6633 Rename locals to avoid shadowing.
6634 * fileio.c (Finsert_file_contents):
6635 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6636 * process.c (wait_reading_process_output):
6637 Rename inner 'proc' to 'p' to avoid shadowing.
6638 Indent for consistency with usual Emacs style.
6639
8c535114
EZ
66402011-11-25 Eli Zaretskii <eliz@gnu.org>
6641
6642 * xdisp.c (redisplay_window): If cursor row is not fully visible
6643 after recentering, and scroll-conservatively is set to a large
6644 number, scroll window by a few more lines to make the cursor fully
6645 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6646 (start_display): Don't move to the next line if the display should
6647 start at a newline that is part of a display vector or an overlay
6648 string. (Bug#10119)
8c535114 6649
fa4fdb5c
JL
66502011-11-24 Juri Linkov <juri@jurta.org>
6651
6652 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6653 after the `MagickPingImage' call. (Bug#10112)
6654
90ec88df
CY
66552011-11-23 Chong Yidong <cyd@gnu.org>
6656
6657 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6658
56e2e794
MR
66592011-11-23 Martin Rudalics <rudalics@gmx.at>
6660
6661 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6662 making another buffer current. (Bug#10114)
6663
b6e64c41
GM
66642011-11-23 Glenn Morris <rgm@gnu.org>
6665
6666 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6667
6b21de18
CY
66682011-11-23 Chong Yidong <cyd@gnu.org>
6669
6670 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6671 using it (Bug#5984).
6672
b12cd789
EZ
66732011-11-22 Eli Zaretskii <eliz@gnu.org>
6674
6675 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6676 and header-lines, as they don't have one computed for them.
6677 (Bug#10098)
6678
6679 * .gdbinit (prow): Make displayed values more self-explaining.
6680 Add row's hash code.
6681
261b6fd4
LMI
66822011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6683
6684 * process.c (wait_reading_process_output): Fix asynchrounous
6685 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6686 (wait_reading_process_output): Add comment and URL.
261b6fd4 6687
e7cfd277
JD
66882011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6689
6690 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6691
a9b9b7f5
CY
66922011-11-21 Chong Yidong <cyd@gnu.org>
6693
6694 * window.c (Fnext_window, Fprevious_window): Doc fix.
6695
b0d15b4f
SM
66962011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6697
6698 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6699
fe7a3057
JB
67002011-11-20 Juanma Barranquero <lekktu@gmail.com>
6701
6702 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6703
d2999b1a
MR
67042011-11-20 Martin Rudalics <rudalics@gmx.at>
6705
6706 * window.c (Fset_window_combination_limit): Rename argument
6707 STATUS to LIMIT.
6708 (Vwindow_combination_limit): Remove "status" from doc-string.
6709
d5ff9cd0
AS
67102011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6711
6712 * m/ibms390.h: Remove.
6713 * m/ibms390x.h: Don't include "ibms390.h".
6714
a5bb9bd3
SM
67152011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6716
6717 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6718 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6719
cd1181db
JB
67202011-11-20 Juanma Barranquero <lekktu@gmail.com>
6721
6722 * casetab.c (Fset_case_table):
6723 * charset.c (Fcharset_after): Fix typos.
6724
615a3b8d 67252011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6726
17e845af
PE
6727 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6728 Otherwise, valgrind does not work on some platforms.
6729 Problem reported by Andreas Schwab in
6a0bf43d
PE
6730 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6731 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6732 is set, removing the need for VIRT_ADDRESS_VARIES.
6733 (PURE_P): Use a more-efficient implementation that needs just one
6734 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6735 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6736 to 4 (xorl, subq, cmpq, setbe).
6737 * alloc.c (pure): Always extern now, since that's the
6738 VIRT_ADDR_VARIES behavior.
6739 (PURE_POINTER_P): Use a single comparison, not two, for
6740 consistency with the new puresize.h.
6741 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6742 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6743 Remove VIRT_ADDR_VARIES no longer needed.
6744
f8fe6f96
EZ
67452011-11-19 Eli Zaretskii <eliz@gnu.org>
6746
6747 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6748 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6749 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6750 behave as if the cursor position were at the window margin.
6751
6752 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6753 and the cursor position is out of bounds, behave as if the cursor
6754 position were at the window margin. (Bug#10075)
6755
df05a53c
CY
67562011-11-18 Chong Yidong <cyd@gnu.org>
6757
6758 * window.c (Fwindow_combination_limit): Make first argument
6759 non-optional, since it is meaningless for live windows like the
6760 selected window.
61ccba97 6761
2071918e
DA
67622011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6763
6764 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6765
b50a28de
SM
67662011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6767
6768 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6769 (graft_intervals_into_buffer): Simplify.
6770
015137db
EZ
67712011-11-18 Eli Zaretskii <eliz@gnu.org>
6772
6773 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6774 hash values of the two rows.
6775 (copy_row_except_pointers): Preserve the used[] arrays and the
6776 hash values of the two rows. (Bug#10035)
68c95424 6777 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6778
6779 * xdisp.c (row_hash): New function, body extracted from
6780 compute_line_metrics.
6781 (compute_line_metrics): Call row_hash, instead of computing the
6782 hash code inline.
6783
6784 * dispnew.c (verify_row_hash): Call row_hash for computing the
6785 hash code of a row, instead of duplicating code from xdisp.c.
6786
6787 * dispextern.h (row_hash): Add prototype.
6788
a2addb04
TH
67892011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6790
6791 * frame.c (delete_frame): Don't delete the terminal when the last
6792 X frame is closed if emacs is built with GTK toolkit.
6793
df85d315
JB
67942011-11-17 Juanma Barranquero <lekktu@gmail.com>
6795
6796 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6797
a0c2d0ae
MR
67982011-11-17 Martin Rudalics <rudalics@gmx.at>
6799
6800 * window.c (Vwindow_splits): Rename to
6801 Vwindow_combination_resize. Suggested by Juri Linkov.
6802 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6803 of Vwindow_splits.
6804
58179cce
JB
68052011-11-16 Juanma Barranquero <lekktu@gmail.com>
6806
7877f373
JB
6807 * nsfns.m (Fns_font_name):
6808 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6809
b6f67890
MR
68102011-11-16 Martin Rudalics <rudalics@gmx.at>
6811
6812 * window.h (window): Rename slot "nest" to "combination_limit".
6813 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6814 (Fset_window_nest): Rename to Fset_window_combination_limit.
6815 (Vwindow_nest): Rename to Vwindow_combination_limit.
6816 (recombine_windows, make_parent_window, make_window)
6817 (Fsplit_window_internal, saved_window)
6818 (Fset_window_configuration, save_window_save): Rename all
6819 occurrences of window_nest to window_combination_limit.
6820
c7015153
JB
68212011-11-15 Juanma Barranquero <lekktu@gmail.com>
6822
6823 * image.c (imagemagick_load_image): Fix typo.
6824
322ad6ec
EZ
68252011-11-14 Eli Zaretskii <eliz@gnu.org>
6826
6827 * xdisp.c (display_line): Move the call to
6828 highlight_trailing_whitespace before the call to
6829 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6830 faces of all the glyphs to compute ROW's hash value.
6831 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6832
f067b8ec
JB
68332011-11-14 Juanma Barranquero <lekktu@gmail.com>
6834
6835 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6836 just return (bug#10044).
6837
1e5b2111
EZ
68382011-11-12 Eli Zaretskii <eliz@gnu.org>
6839
7ef3cbd5
EZ
6840 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6841 with user-defined heap size. Bump the default size of the temacs
6842 heap to 27MB, to avoid memory warning when running temacs.
6843 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6844
1e5b2111
EZ
6845 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6846 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6847 (verify_row_hash) [XASSERTS]: New function.
6848 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6849 that the hash value of glyph rows is correct.
1e5b2111 6850
89d61221
MR
68512011-11-12 Martin Rudalics <rudalics@gmx.at>
6852
6853 * window.h (window): Remove splits slot.
6854 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6855 (Fdelete_other_windows_internal, make_parent_window)
6856 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6857 (Fset_window_configuration, save_window_save): Don't deal with
6858 split status of windows.
6859 (saved_window): Remove splits slot.
6860 (Vwindow_splits): Rewrite doc-string.
6861
97f18cc8
JD
68622011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6863
6864 * xfns.c (unwind_create_frame):
6865 * nsfns.m (unwind_create_frame):
6866 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6867 Vframe_list (Bug#9999).
6868
22a648b4
DA
68692011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6870
0b381c7e 6871 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6872
659afede
KH
68732011-11-11 Kenichi Handa <handa@m17n.org>
6874
6875 * callproc.c (Fcall_process): Set the member dst_multibyte of
6876 process_coding.
6877
9ac0394b
KH
68782011-11-11 Johan Bockgård <bojohan@gnu.org>
6879
6880 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6881 avoid a crash (bug#9496).
6882
2fbdc249
CY
68832011-11-09 Chong Yidong <cyd@gnu.org>
6884
6885 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6886 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6887
ac6b1f81
PE
68882011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6889
6890 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6891
09db192c
PE
68922011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6893
6894 Avoid some portability problems by eschewing 'extern inline' functions.
6895 The trivial performance wins aren't worth the portability hassles; see
6896 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6897 et seq.
6898 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6899 (window_box_width, window_box_left, window_box_left_offset)
6900 (window_box_right, window_box_right_offset): Undo previous change,
6901 by removing the "extern"s.
6902 * intervals.c (adjust_intervals_for_insertion)
6903 (adjust_intervals_for_deletion): Undo previous change,
6904 making these static again.
6905 (offset_intervals, temp_set_point_both, temp_set_point)
6906 (copy_intervals_to_string): No longer inline.
6907 * xdisp.c (window_text_bottom_y, window_box_width)
6908 (window_box_height, window_box_left_offset)
6909 (window_box_right_offset, window_box_left, window_box_right)
6910 (window_box): No longer inline.
6911
105216ed
CY
69122011-11-08 Chong Yidong <cyd@gnu.org>
6913
6914 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6915 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6916 Signal an error if not a live window.
105216ed
CY
6917 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6918 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6919
ae9e237f
JB
69202011-11-07 Juanma Barranquero <lekktu@gmail.com>
6921
6922 * lisp.h (syms_of_abbrev): Remove declaration.
6923 Reported by CHENG Gao <chenggao@royau.me>.
6924
c7aa8333
EZ
69252011-11-07 Eli Zaretskii <eliz@gnu.org>
6926
6927 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6928 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6929 of temacs in GUI mode.
6930
be7f5545
MR
69312011-11-07 Martin Rudalics <rudalics@gmx.at>
6932
6933 * window.h: Declare delete_all_child_windows instead of
6934 delete_all_subwindows.
6935 * window.c (Fwindow_nest, Fset_window_nest)
6936 (Fset_window_new_total, Fset_window_new_normal)
6937 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6938 (delete_all_subwindows): Rename to delete_all_child_windows.
6939 (Fdelete_other_windows_internal, Fset_window_configuration):
6940 Call delete_all_child_windows instead of delete_all_subwindows.
6941 * frame.c (delete_frame): Call delete_all_child_windows instead
6942 of delete_all_subwindows.
6943
ca78dc43
PE
69442011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6945
6946 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6947 This is also needed for porting to any host where GC_MARK_STACK is
6948 not GC_MAKE_GCPROS_NOOPS.
6949 (which_symbols): Use it.
6950
a0241d01
KH
69512011-11-07 Kenichi Handa <handa@m17n.org>
6952
6953 * coding.c (coding_set_destination): Check coding->src_pos only
6954 when coding->src_object is a buffer (bug#9910).
6955
6956 * process.c (send_process): Set the member src_multibyte of coding
6957 to 0 (bug#9911) when sending a unibyte text.
6958
6959 * callproc.c (Fcall_process): Set the member src_multibyte of
6960 process_coding to 0 (bug#9912).
6961
a64bfdfa 69622011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6963
6964 * xmenu.c (cleanup_widget_value_tree): New function.
6965 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6966 calling free_menubar_widget_value_tree directly (Bug#9830).
6967
cb41b32a
PE
69682011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6969
6970 Fix some portability problems with 'inline'.
6971 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6972 (window_box_width, window_box_left, window_box_left_offset)
6973 (window_box_right, window_box_right_offset): Declare extern.
6974 Otherwise, these inline functions do not conform to C99 and
6975 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6976 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6977 * intervals.c (adjust_intervals_for_insertion)
6978 (adjust_intervals_for_deletion): Now extern, because otherwise the
6979 extern inline functions 'offset_intervals' couldn't refer to it.
6980 (static_offset_intervals): Remove.
6981 (offset_intervals): Rewrite using the old contents of
6982 static_offset_intervals. The old version didn't conform to C99
6983 because an extern inline function contained a reference to an
6984 identifier with static linkage.
6985
b7041366
AS
69862011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6987
6988 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6989 GC.
6990
88a37c4d
EZ
69912011-11-06 Eli Zaretskii <eliz@gnu.org>
6992
6993 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6994 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6995 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6996 return Qleft_to_right.
6997
49745b39
CY
69982011-11-06 Chong Yidong <cyd@gnu.org>
6999
7000 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7001 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7002 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7003 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7004 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7005 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7006 (Fwindow_vscroll): Doc fix.
7007 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7008 argument, since it makes no sense to pass a live window and for
7009 consistency with window-child.
7010
1f05cd82
CS
70112011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7012
7013 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7014 support MSVC.
7015
22610910
JR
70162011-11-05 Jason Rumney <jasonr@gnu.org>
7017
7018 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7019 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7020 fonts (Bug#6029).
7021 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7022 bitwise arithmetic preventing use of unicode-sip and non-truetype
7023 opentype fonts.
7024
a06776b2
EZ
70252011-11-05 Eli Zaretskii <eliz@gnu.org>
7026
3ad924ba
EZ
7027 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7028 "emacs"-only part.
7029
a06776b2
EZ
7030 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7031 initialization code to keep similarity to xfns.c after changes
7032 from 2011-11-05.
7033
c9e7db78
JD
70342011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7035
a97f8f3f
JD
7036 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7037 (unwind_create_frame): New function (Bug#9943).
7038 (Fx_create_frame): Restructure code to be more similar to the one in
7039 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7040 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7041 Move terminal->reference_count++ just before making the frame official
7042 (Bug#9943).
7043
7044 * nsterm.m (x_free_frame_resources): New function.
7045 (x_destroy_window): Move code to x_free_frame_resources.
7046
c9e7db78 7047 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7048 (Fx_create_frame, x_create_tip_frame):
7049 Move terminal->reference_count++ just before making the frame
75f1671a 7050 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7051 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7052
a6fc3b5c
EZ
70532011-11-05 Eli Zaretskii <eliz@gnu.org>
7054
7055 Support MSVC build with newer versions of Visual Studio.
7056 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7057 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7058 nt/gmake.defs.
7059
7060 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7061 which are not supported by MSVC.
7062 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7063 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7064 bitfields.
7065 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7066 types in bitfields.
7067 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7068
7069 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7070
58179cce 70712011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7072
7073 Support MSVC build with newer versions of Visual Studio.
7074 * w32.c: Don't include w32api.h for MSVC.
7075 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7076
7077 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7078 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7079 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7080 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7081 e_* cousins.
7082 (alloca) [_MSC_VER]: Define to _alloca.
7083
7084 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7085
7086 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7087
a58c13ed
EZ
70882011-11-04 Eli Zaretskii <eliz@gnu.org>
7089
7090 * xdisp.c (note_mouse_highlight): If either of
7091 previous/next-single-property-change returns nil, treat that as
7092 the beginning or the end of the buffer. (Bug#9955)
7093
fe0b6370
JD
70942011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7095
a58c13ed 7096 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7097 label is not null (Bug#9951).
7098 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7099 may be NULL.
7100
89bd5ee1
EZ
71012011-11-04 Eli Zaretskii <eliz@gnu.org>
7102
7103 * window.c (Fwindow_body_size): Mention in the doc string that the
7104 return value is in frame's canonical units. (Bug#9949)
7105
84c3edb9
EZ
71062011-11-03 Eli Zaretskii <eliz@gnu.org>
7107
4e2fb5c7
EZ
7108 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7109
84c3edb9 7110 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7111 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7112 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7113
bc17a887
EZ
71142011-11-01 Eli Zaretskii <eliz@gnu.org>
7115
7116 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7117 Don't stop backward scan on the continuation glyph, even though
7118 its CHARPOS is positive.
6d5eb5b0
SM
7119 (mouse_face_from_buffer_pos, note_mouse_highlight):
7120 Rename cover_string to disp_string.
bc17a887 7121
4ee88440
MR
71222011-11-01 Martin Rudalics <rudalics@gmx.at>
7123
7124 * window.c (temp_output_buffer_show): Don't use
7125 Vtemp_buffer_show_specifiers.
7126 (Vtemp_buffer_show_specifiers): Remove unused variable.
7127
c2ff3c02
EZ
71282011-10-30 Eli Zaretskii <eliz@gnu.org>
7129
7130 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7131 past the beginning of the current glyph matrix.
7132
58179cce 71332011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7134
7135 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7136 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7137 HAVE_GTK3 (Bug#9869).
b77a6a7f 7138
3b574623
JD
7139 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7140 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7141
b77a6a7f
JD
7142 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7143
7144 * xterm.c: Declare x_handle_net_wm_state to return int.
7145 (handle_one_xevent): Check if we are iconified but don't have
7146 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7147 (get_current_wm_state): Return non-zero if not hidden,
7148 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7149 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7150 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7151 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7152
196e41e4
PE
71532011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7154
7155 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7156 so that this new function doesn't get optimized away by a
7157 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7158
021f2e1a
AS
71592011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7160
7161 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7162
8b058d44
EZ
71632011-10-29 Eli Zaretskii <eliz@gnu.org>
7164
7165 Fix the `xbytecode' command.
7166 * .gdbinit (xprintbytestr): New command.
b50a28de 7167 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7168 (xbytecode): Print the byte-code string as well.
7169
4452fb80
EZ
71702011-10-29 Kim Storm <storm@cua.dk>
7171
8b058d44
EZ
7172 * alloc.c (which_symbols): New function.
7173
21b72067
AS
71742011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7175
7176 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7177 line. (Bug#9903)
7178
83ed7b5c
GM
71792011-10-29 Glenn Morris <rgm@gnu.org>
7180
7181 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7182 Not clear what it was for, and it causes various bugs. (Bug#9839)
7183
5a7a728b
EZ
71842011-10-28 Eli Zaretskii <eliz@gnu.org>
7185
7186 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7187 possible random value that matches one of those tested as
7188 condition to clear the mouse face.
7189
d3d0842f
CY
71902011-10-28 Chong Yidong <cyd@gnu.org>
7191
7192 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7193
31b39d13
DN
71942011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7195
7196 * window.c (make_window): Initialize phys_cursor_on_p.
7197
9aba6043
SM
71982011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7199
7200 * lisp.h (struct Lisp_Symbol): Update comments.
7201
c20992f4
JB
72022011-10-28 Juanma Barranquero <lekktu@gmail.com>
7203
7204 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7205
db4f02f2
EZ
72062011-10-28 Eli Zaretskii <eliz@gnu.org>
7207
7208 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7209 <oslsachem@gmail.com> for helping to debug this.
7210
7211 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7212 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7213 (g_b_init_get_glyph_outline_w): New static variables.
7214 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7215 (GetGlyphOutlineW_Proc): New typedefs.
7216 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7217 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7218 New functions.
7219 (w32font_open_internal, compute_metrics):
7220 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7221 instead of calling the "wide" APIs directly.
7222
7223 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7224
7225 * w32.h (syms_of_w32font): Add prototype.
7226
87e68db4
JB
72272011-10-27 Juanma Barranquero <lekktu@gmail.com>
7228
7229 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7230 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7231 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7232 (Fmove_to_window_line): Doc fix.
7233
435c1d67
CY
72342011-10-27 Chong Yidong <cyd@gnu.org>
7235
7236 * process.c (make_process): Set gnutls_state to NULL.
7237
7238 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7239 non-NULL, regardless of GNUTLS_INITSTAGE.
7240 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7241 an error. Set process slots as soon as we allocate them.
7242
7243 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7244
9c6c6f49
CY
72452011-10-27 Chong Yidong <cyd@gnu.org>
7246
9aba6043
SM
7247 * gnutls.c (emacs_gnutls_deinit): New function.
7248 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7249 (Fgnutls_deinit, Fgnutls_boot): Use it.
7250
7251 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7252 (deactivate_process): Call emacs_gnutls_deinit.
7253
657d08d3
JB
72542011-10-27 Juanma Barranquero <lekktu@gmail.com>
7255
7256 * image.c (x_create_x_image_and_pixmap):
7257 * w32.c (sys_rename, w32_delayed_load):
7258 * w32font.c (fill_in_logfont):
7259 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7260
5430d399
JB
72612011-10-26 Juanma Barranquero <lekktu@gmail.com>
7262
7263 * w32fns.c (w32_default_color_map): New function,
7264 extracted from Fw32_default_color_map.
a7ef684b 7265 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7266
fe0055fa
PE
72672011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7268
7269 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7270
e6346438
SM
72712011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7272
7273 * keyboard.c (test_undefined): New function (bug#9751).
7274 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7275
e112cc37
ET
72762011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7277
7278 * sysdep.c (init_sys_modes): Fix the check for the controlling
7279 terminal (Bug#6649).
7280
7b5d6677
EZ
72812011-10-20 Eli Zaretskii <eliz@gnu.org>
7282
7283 * dispextern.h (struct bidi_it): New member next_en_type.
7284
7285 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7286 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7287 current character, check also for next_en_type being WEAK_EN.
7288 (bidi_resolve_weak): Don't enter the expensive loop if the current
7289 position is before next_en_pos. Record the bidi type of the first
7290 non-ET, non-BN character we find, in addition to its position.
7291 (bidi_level_of_next_char): Invalidate next_en_type when
7292 next_en_pos is over-stepped.
7293
7da0b018
PE
72942011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7295
7296 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7297 * editfns.c: Rewrite current-time-zone so that it invokes
7298 the equivalent of (format-time-string "%Z") to get the time zone name.
7299 This fixes a bug when the time zone name contains characters that
7300 need converting from the system time locale to Emacs internal format.
7301 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7302 that patch fixed format-time-string to do the conversion, but
7303 I forgot to fix current-time-zone.
7304 (format_time_string): New function, containing most of
7305 what Fformat_time_string used to contain.
7306 (Fformat_time_string): Rewrite in terms of format_time_string.
7307 This doesn't change this function's behavior.
7308 (current-time-zone): Rewrite to use format_time_string.
7309 This fixes the bug reported by Michael Schierl in
7310 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7311 Jason Rumney's 2007-06-07 change worked around this bug, but
7312 didn't fix it.
7313 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7314
8547b010
EZ
73152011-10-19 Eli Zaretskii <eliz@gnu.org>
7316
7317 * xdisp.c (start_display): If the character at POS is displayed
7318 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7319 (try_window_reusing_current_matrix): If a line ends in a display
7320 vector or the next line starts in a display vector, continue
7321 redrawing the window even though the character position of
7322 start_row was reached.
8547b010
EZ
7323 (Bug#9771, part 2)
7324
4e948d15
CY
73252011-10-18 Chong Yidong <cyd@gnu.org>
7326
7327 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7328 with nobreak-char-display too.
7329
4787455f
EZ
73302011-10-18 Eli Zaretskii <eliz@gnu.org>
7331
7332 Fix part 3 of bug#9771.
7333 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7334 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7335 non-neutral characters if the current character is a paragraph
7336 separator (a.k.a. Newline). This avoids running the same
7337 expensive loop twice, once when we consume the preceding newline
7338 and the other time when the line actually needs to be displayed.
7339 Avoid the loop when we see neutrals on the base embedding level
7340 following a character whose directionality is the same as the
7341 paragraph's. This avoids running the expensive loop when a line
7342 ends in a long sequence of neutrals, like control characters.
7343 Add assertion against STRONG_AL type. Slightly rearrange code
7344 that determines the type of a neutral given the first non-neutral
7345 that follows it.
7346 (bidi_level_of_next_char): Set next_en_pos to zero when
7347 invalidating its info.
7348
2c91f553
EZ
73492011-10-17 Eli Zaretskii <eliz@gnu.org>
7350
7351 * xdisp.c (push_display_prop): Determine whether to record string
7352 or buffer position by IT->string, not by IT->method. Allow
7353 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7354 (move_it_vertically_backward): Don't look for character position
7355 immediately after the newline when in a continuation line.
7356 (Bug#9771, part 1)
2c91f553 7357
c7b08b0d
MR
73582011-10-15 Martin Rudalics <rudalics@gmx.at>
7359
7360 * window.c (coordinates_in_window): Rewrite and delabelize
7361 vertical border check. (Bug#5357) (Bug#9618)
7362
6b02f655
SM
73632011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7364
7365 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7366 errors in XSetWindowBorder (bug#9310).
7367
81d40c92
DA
73682011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7369
7370 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7371 avoid crash when xmalloc overrun checking is enabled.
7372
d4172c3b
EZ
73732011-10-13 Eli Zaretskii <eliz@gnu.org>
7374
7375 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7376 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7377 cursor motion with <left> and <right> arrow keys.
7378
7379 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7380 some callers set that themselves.
7381
b00eea75
EZ
73822011-10-12 Eli Zaretskii <eliz@gnu.org>
7383
7384 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7385 display string and the previous row comes from the same string and
7386 is empty. (Bug#9739) (Bug#9738)
7387
8fe012c4
SM
73882011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7389
7390 * doc.c (get_doc_string): Encode file name (bug#9735).
7391
0074aef2
EZ
73922011-10-12 Eli Zaretskii <eliz@gnu.org>
7393
79beb178
EZ
7394 * bidi.c (bidi_level_of_next_char):
7395 * xdisp.c (get_visually_first_element): Remove old incorrect
7396 comments regarding the Unicode Line Separator character.
7397
0074aef2
EZ
7398 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7399
6e4b3fbe
DA
74002011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7401
7402 * alloc.c (Fgc_status): Do not access beyond zombies array
7403 boundary if nzombies > MAX_ZOMBIES.
7404 * alloc.c (dump_zombies): Add missing format specifier.
7405
0324f3af
PE
74062011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7407
b5525cac
PE
7408 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7409 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7410
0324f3af
PE
7411 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7412 Some packages use them to denote characters with modifiers.
7413
e9b5f888
AS
74142011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7415
7416 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7417 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7418 matching a pp-number. Rename parameter var to var1.
7419
127827c0
SM
74202011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7421
7422 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7423
c8fd3bd0
GM
74242011-10-08 Glenn Morris <rgm@gnu.org>
7425
7426 * callint.c (Fcall_interactively): Give a more explicit error for the
7427 'c' case with a non-character input. (Bug#8479)
7428
352ec8ff
EZ
74292011-10-08 Eli Zaretskii <eliz@gnu.org>
7430
03669ccb
EZ
7431 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7432 lines.
7061c986
EZ
7433 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7434 lines that are hscrolled on the left.
03669ccb 7435
352ec8ff
EZ
7436 * dispnew.c (buffer_posn_from_coords): Account for a possible
7437 presence of header-line. (Bug#4426)
7438
a66cfb1c
SM
74392011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7440
6b02f655
SM
7441 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7442 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7443
7c5ee88e
PE
74442011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7445
7446 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7447 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7448 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7449 this makes Emacs dump core during garbage collection on rare
7450 occasions. sizeof is obviously inferior to offsetof here, so
7451 stick with offsetof.
7452 (GC_POINTER_ALIGNMENT): New macro.
7453 (mark_memory): Omit 3rd (offset) arg; caller changed.
7454 Don't assume EMACS_INT alignment is the same as pointer alignment.
7455
df1bbe5b
SM
74562011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7457
7458 * keyboard.c (read_key_sequence_remapped): New var.
7459 (read_key_sequence): Compute remapping in the right buffer.
7460 (command_loop_1): Use read_key_sequence's remapping directly.
7461
51553db6
SM
74622011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7463
32c1fffd
SM
7464 * dired.c (file_name_completion): Don't expand file name.
7465 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7466 before checking file name handler.
7467
51553db6
SM
7468 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7469 they've been requested explicitly (bug#9591).
7470
b6bd1599 74712011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7472
7473 * keymap.c (Fsingle_key_description): Use make_specified_string
7474 instead of build_string to build string from push_key_description.
7475 (Bug#5193)
7476
f701dc2a
PE
74772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7478
4222c55d
PE
7479 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7480 This fixes a Y2038 bug on 64-bit hosts.
7481 * buffer.c (reset_buffer):
7482 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7483 (Fclear_buffer_auto_save_failure):
7484 Use 0, not -1, to represent an unset failure time, since time_t
7485 might not be signed.
7486
f701dc2a
PE
7487 Remove dependency on glibc malloc internals.
7488 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7489 Move back here from lisp.h, but with their new implementations.
7490 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7491 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7492 * charset.c (charset_table_init): New static var.
7493 (syms_of_charset): Use it instead of xmalloc. This removes a
7494 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7495 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7496 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7497 Move back to alloc.c.
7498 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7499 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7500
9ceebf39
JD
75012011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7502
7503 * nsterm.m (windowDidResize): Call x_set_window_size only when
7504 ns_in_resize is true. Otherwise set pixelwidth/height and
7505 call change_frame_size (Bug#9628).
7506
cb993c58
PE
75072011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7508
3930c88b
PE
7509 Port --enable-checking=all to Fedora 14 x86-64.
7510 * charset.c (syms_of_charset): Also account for glibc malloc's
7511 internal overhead when calculating the initial malloc maximum.
7512
cb993c58
PE
7513 Port --enable-checking=all to Fedora 14 x86.
7514 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7515 Move to lisp.h.
7516 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7517 (overrun_check_realloc, overrun_check_free):
7518 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7519 That way, xmalloc returns a properly-aligned pointer even if
7520 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7521 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7522 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7523 into account when calculating the initial malloc maximum.
7524 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7525 Move here from alloc.c, so that charset.c can use it too.
7526 Properly align; the old code wasn't right for common 32-bit hosts
7527 when configured with --enable-checking=all.
7528 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7529 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7530
31bed486
EZ
75312011-09-29 Eli Zaretskii <eliz@gnu.org>
7532
04c70788 7533 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7534 use EDOM.
7535
fbcaa2f3
EZ
75362011-09-28 Eli Zaretskii <eliz@gnu.org>
7537
7538 * xdisp.c (compute_display_string_end): If there's no display
7539 string at CHARPOS, return -1.
7540
7541 * bidi.c (bidi_fetch_char): When compute_display_string_end
7542 returns a negative value, treat the character as a normal
7543 character not covered by a display string. (Bug#9624)
7544
a239d4e9
JB
75452011-09-28 Juanma Barranquero <lekktu@gmail.com>
7546
7547 * lread.c (Fread_from_string): Fix typo in docstring.
7548
88652fd5
EZ
75492011-09-27 Eli Zaretskii <eliz@gnu.org>
7550
7551 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7552 newline, reseat the iterator instead of bidi-iterating there one
7553 character at a time. (Bug#9610)
32c1fffd
SM
7554 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7555 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7556
ed497dd4
AS
75572011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7558
7559 * lread.c (readevalloop): Use correct code for NBSP.
7560 (read1): Likewise. (Bug#9608)
7561
b2bf61aa
MA
75622011-09-25 Michael Albinus <michael.albinus@gmx.de>
7563
7564 * dbusbind.c (Fdbus_register_signal): When service is not
7565 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7566
32bbb17c
GM
75672011-09-25 Glenn Morris <rgm@gnu.org>
7568
7569 * buffer.c (truncate-lines): Doc fix.
7570
94e0933e
CY
75712011-09-24 Chong Yidong <cyd@stupidchicken.com>
7572
7573 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7574 (Fset_window_next_buffers): Doc fix.
7575
cddde921
GM
75762011-09-24 Glenn Morris <rgm@gnu.org>
7577
7578 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7579
1260aef1
PE
75802011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7581
25b4bfa0
PE
7582 Fix minor problems found by static checking.
7583 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7584 * indent.c (Fvertical_motion): Fix == vs = typo.
7585
e3cbd34b
EZ
75862011-09-24 Eli Zaretskii <eliz@gnu.org>
7587
a66cfb1c
SM
7588 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7589 Default value is now t. Doc fix.
6bf7006f 7590
e3cbd34b 7591 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7592 logic when moving up, not only when moving down. Fix the
e3cbd34b 7593 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7594 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7595
7596 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7597 CHARPOS is covered by a display string which includes newlines.
7598 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7599 is covered by a display string with embedded newlines.
7600
a3de0cbd
MA
76012011-09-24 Michael Albinus <michael.albinus@gmx.de>
7602
7603 * dbusbind.c (Fdbus_register_signal): Add match rule to
7604 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7605 (Fdbus_register_method, Vdbus_registered_objects_table):
7606 Fix docstring.
a3de0cbd 7607
b260039d
JM
76082011-09-24 Jim Meyering <meyering@redhat.com>
7609
32c1fffd 7610 do not ignore write error for any output size
b260039d
JM
7611 The previous change was incomplete.
7612 While it makes emacs --batch detect the vast majority of stdout
7613 write failures, errors were still ignored whenever the output size is
7614 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7615 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7616 && echo FAIL: ignored write error
7617 FAIL: ignored write error
7618 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7619 && echo FAIL: ignored write error
7620 FAIL: ignored write error
7621 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7622
8eca8a7c
AS
76232011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7624
7625 * emacs.c (Fkill_emacs): In noninteractive mode exit
7626 non-successfully if a write error occurred on stdout. (Bug#9574)
7627
3341db62
EZ
76282011-09-21 Eli Zaretskii <eliz@gnu.org>
7629
7630 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7631 the xassert test.
7632
7633 * dispextern.h (struct it): Update the comment documenting what
7634 can it->OBJECT be.
7635
8c203dbf
EZ
76362011-09-20 Eli Zaretskii <eliz@gnu.org>
7637
7638 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7639 a display string, extend search for cursor position to end of row.
7640 (find_row_edges): If the row ends in a newline from a display
7641 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7642 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7643 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7644 non-empty line. Fixes confusing cursor motion with arrow keys at
7645 the beginning of a line that starts with whitespace.
8c203dbf 7646
a4824228
LMI
76472011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7648
7649 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7650 (bug#9493).
7651
33ed493b
CY
76522011-09-18 Chong Yidong <cyd@stupidchicken.com>
7653
7654 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7655 boolean (Bug#9154).
7656
56cd55c8
EZ
76572011-09-18 Eli Zaretskii <eliz@gnu.org>
7658
7659 * xdisp.c (display_line): Record maximum and minimum buffer
7660 positions even if no glyphs were produced (e.g., by a zero-width
7661 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7662 buffer positions that will be removed from the glyph row because
7663 they don't fit.
c02dcedf
EZ
7664 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7665 column is beyond frame width: don't subtract 1 "pixel" when
7666 computing width of the stretch.
3e62b7e0
EZ
7667 (reseat_at_next_visible_line_start): Undo the change made on
7668 2011-09-17 that saved paragraph information and restored it after
7669 the call to `reseat'. (Bug#9545)
56cd55c8 7670
5ed99d36 76712011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7672
7673 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7674 and turn window cursor on if cleared (Bug#9415).
7675
5ed99d36 76762011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7677
7678 * search.c (boyer_moore): Take unibyte characters from pattern
7679 literally. (Bug#9458)
7680
9bade7b2
EZ
76812011-09-18 Eli Zaretskii <eliz@gnu.org>
7682
7683 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7684
e5e9d610
PE
76852011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7686
87e4427a
PE
7687 Fix minor problem found by static checking.
7688 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7689 initialized, to pacify gcc -Wuninitialized.
7690
e5e9d610
PE
7691 * fileio.c: Report proper errno when syscall falls.
7692 (Finsert_file_contents): Save and restore errno,
7693 so that report_file_error outputs the correct diagnostic.
7694 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7695
a1674f0b
EZ
76962011-09-18 Eli Zaretskii <eliz@gnu.org>
7697
7698 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7699
fbfb6dd4
EZ
77002011-09-17 Eli Zaretskii <eliz@gnu.org>
7701
7702 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7703 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7704
bb187662
EZ
77052011-09-17 Eli Zaretskii <eliz@gnu.org>
7706
1137e8b8 7707 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7708 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7709
7710 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7711 (bidi_find_paragraph_start): Search back for paragraph beginning
7712 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7713 (bidi_move_to_visually_next): Only trigger paragraph-related
7714 computations when the last character is a newline or at EOB, not
7715 just any NEUTRAL_B. (Bug#9470)
7716
bb187662
EZ
7717 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7718 truncated lines if point is covered by a display string. (Bug#9524)
7719
2e621251
PE
77202011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7721
7722 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7723 (cons_to_x_long): New function.
7724 (lisp_data_to_selection_data): Use it. Correct the test for
7725 short-versus-long data; it was negated. Break out of vector
7726 loop, for efficiency, when a long datum is discovered.
7727
91a15bc6
SM
77282011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7729
7730 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7731
b41c3a35
EZ
77322011-09-16 Eli Zaretskii <eliz@gnu.org>
7733
7734 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7735 GCC PR/17406) by declaring this function with external scope.
7736
7812ba2d
PE
77372011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7738
7739 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7740 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7741
cf7edc2a
AS
77422011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7743
7744 * editfns.c (Fformat): Correctly handle text properties on "%%".
7745
bd01620e
EZ
77462011-09-15 Eli Zaretskii <eliz@gnu.org>
7747
7748 * xterm.c (x_draw_composite_glyph_string_foreground):
7749 * w32term.c (x_draw_composite_glyph_string_foreground):
7750 * term.c (encode_terminal_code):
7751 * composite.c (composition_update_it, get_composition_id):
7752 * xdisp.c (get_next_display_element)
7753 (fill_composite_glyph_string): Add comments about special meaning
7754 of TAB characters in a composition.
7755
a02719a3
PE
77562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7757
7758 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7759 This occurs when processing a multibyte format.
7760 Problem reported by Wolfgang Jenker.
a02719a3 7761
72589a3c
JB
77622011-09-15 Johan Bockgård <bojohan@gnu.org>
7763
7764 * xdisp.c (try_cursor_movement): Only check for exact match if
7765 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7766
1c14176c
PE
77672011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7768
7769 Remove unused external symbols.
7770 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7771 * xdisp.c (calc_pixel_width_or_height): Now static.
7772 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7773 * indent.c (check_display_width):
7774 * w32term.c: Fix comment to match code.
7775 * xterm.c, xterm.h (x_catching_errors): Remove.
7776
d2eea5b5
PE
77772011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7778
7779 * xselect.c: Use signed conversions more consistently (Bug#9498).
7780 (selection_data_to_lisp_data): Assume incoming selection data are
7781 signed integers, not unsigned. This is to be consistent with
7782 outgoing selection data, which was modified to use signed integers
7783 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7784 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7785 expects long, not unsigned long.
7786
46888499
EZ
77872011-09-14 Eli Zaretskii <eliz@gnu.org>
7788
7789 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7790 computation of loop end. Reported by Johan Bockgård
7791 <bojohan@gnu.org>.
7792
ef8ef9fb
CY
77932011-09-13 Chong Yidong <cyd@stupidchicken.com>
7794
7795 * frame.c (Fother_visible_frames_p): Function deleted.
7796
fa819fed
EZ
77972011-09-12 Eli Zaretskii <eliz@gnu.org>
7798
7799 * indent.c (compute_motion): Process display vector front to back
7800 rather than the other way around. (Bug#2496)
7801
2ba8e008
SM
78022011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7803
7804 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7805
20f53c69
CY
78062011-09-11 Chong Yidong <cyd@stupidchicken.com>
7807
7808 * minibuf.c (Fread_from_minibuffer): Doc fix.
7809
d562d7a4
EZ
78102011-09-11 Eli Zaretskii <eliz@gnu.org>
7811
7812 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7813 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7814
1c4d7f3d
LMI
78152011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7816
7817 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7818 value for non-existent files.
7819
b885bf36
EZ
78202011-09-11 Eli Zaretskii <eliz@gnu.org>
7821
7822 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7823 set its "size" to -1. This will set the modtime_size field of
7824 the corresponding buffer to -1, which is what
7825 verify-visited-file-modtime expects for files that do not exist.
7826 (Bug#9139)
7827
6612f0bf
PE
78282011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7829
7830 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7831 here ...
7832 * lisp.h: ... from here. push_key_description is no longer
7833 defined in keyboard.c, so its declaration should not be in
7834 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7835 logically belongs with push_key_description.
7836
dfb3f755
PE
78372011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7838
7839 * buffer.h: Include <sys/types.h> instead of <time.h>.
7840 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7841 Problem reported by Herbert J. Skuhra.
7842
3134906c
LMI
78432011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7844
7845 * xml.c (parse_region): Make the parsing work for
7846 non-comment-starting XML files again (bug#9144).
7847
8d903f4e
AS
78482011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7849
7850 * image.c (gif_load): Fix calculation of bottom and right corner.
7851 (Bug#9468)
7852
80ad64f4
EZ
78532011-09-10 Eli Zaretskii <eliz@gnu.org>
7854
7855 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7856 redisplay in small windows.
7857
208a048d
EZ
78582011-09-09 Eli Zaretskii <eliz@gnu.org>
7859
7860 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7861
9b1c252e
MR
78622011-09-08 Martin Rudalics <rudalics@gmx.at>
7863
7864 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7865 Operate on live windows only.
7866
2949f33b
JB
78672011-09-08 Juanma Barranquero <lekktu@gmail.com>
7868
7869 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7870
e08dcafd
EZ
78712011-09-07 Eli Zaretskii <eliz@gnu.org>
7872
7873 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7874 only under bidi iteration.
7875
115b96bd
JD
78762011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7877
7878 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7879
c8199d0f
PE
78802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7881
7882 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7883 Without this fix, the command to link temacs failed due to an
7884 undefined symbol __builtin_isnan. This is because
7885 /usr/include/iso/math_c99.h #defines isnan(x) to
7886 __builtin_isnan(x), but the bundled gcc, which identifies itself
7887 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7888 a __builtin_isnan.
7889 * floatfns.c (isnan): #undef, and then #define to a clone of
7890 what's in data.c.
7891 (Fisnan): Always define, since it's always available now.
7892 (syms_of_floatfns): Always define isnan at the Lisp level.
7893
e39b275c 78942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7895
7896 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7897
b2db44d9 78982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7899
f4af5137 7900 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7901 The previous code assumed that file offsets (off_t values) fit in
7902 EMACS_INT variables, which is not true on typical 32-bit hosts.
7903 The code messed up by falsely reporting buffer overflow in cases
7904 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7905 when "big" contains more than 2**29 bytes, even though this
7906 inserts just one byte and does not overflow the buffer.
7907 (Finsert_file_contents): Store file offsets as off_t
7908 values, not as EMACS_INT values. Check for overflow when
7909 converting between EMACS_INT and off_t. When checking for
7910 buffer overflow or for overlap, take the offsets into account.
7911 Don't use EMACS_INT for small values where int suffices.
7912 When checking for overlap, fix a typo: ZV was used where
7913 ZV_BYTE was intended.
7914 (Fwrite_region): Don't assume off_t fits into 'long'.
7915 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7916
ecfc0a49
MA
79172011-09-05 Michael Albinus <michael.albinus@gmx.de>
7918
7919 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7920
6511acf2 79212011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7922
0999621a 7923 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7924
7925 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7926 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7927 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7928 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7929 (modify_event_symbol): Do not assume that the length of
7930 name_alist_or_stem is safe to alloca and fits in int.
7931 (Fexecute_extended_command): Likewise for function name and binding.
7932 (Frecursion_depth): Wrap around reliably on integer overflow.
7933 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7934 since some callers pass EMACS_INT values.
7935 (Fsingle_key_description): Don't crash if symbol name contains more
7936 than MAX_ALLOCA bytes.
7937 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7938 (get_minibuffer): Arg is now EMACS_INT, not int.
7939 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7940 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7941 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7942
2be7d702
PE
7943 * dbusbind.c (signature_cat): New function.
7944 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7945 Do not overrun buffer; instead, report string overflow.
7946
9d1df220
PE
7947 * dispnew.c (add_window_display_history): Don't overrun buffer.
7948 Truncate instead; this is OK since it's just a log.
7949
33ef5c64
PE
7950 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7951 even if the time zone offset is outlandishly large.
7952 Don't mishandle offset == INT_MIN.
7953
66c6fdd5
PE
7954 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7955 when creating daemon; the previous buffer-overflow check was incorrect.
7956
d749b01b
PE
7957 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7958 which has the guts of the old verror function.
7959
b5cd1905
PE
7960 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7961 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7962
6e1a67fb
PE
7963 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7964 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7965 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7966 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7967 length of string rather than counting it via multiple sprintfs;
7968 that's simpler and more reliable.
c21721cc
PE
7969 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7970 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7971 sprintf, in case result does not fit in int.
7972
c57b67fc
PE
7973 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7974 (fontset_from_font): Print it.
7975
8a401434
PE
7976 * frame.c (tty_frame_count): Now printmax_t, not int.
7977 (make_terminal_frame, set_term_frame_name): Print it.
7978 (x_report_frame_params): In X, window IDs are unsigned long,
7979 not signed long, so print them as unsigned.
7980 (validate_x_resource_name): Check for implausibly long names,
7981 and don't assume name length fits in 'int'.
7982 (x_get_resource_string): Don't blindly alloca invocation name;
7983 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7984 not fit in int.
7985
6e1a67fb
PE
7986 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7987 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7988 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7989
0df02bf3
PE
7990 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7991 Use esprintf, not sprintf, in case result does not fit in int.
7992
48e30793
PE
7993 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7994 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7995 it as a large positive number.
7996 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7997 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7998
a66ff6d8
PE
7999 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8000 in case result does not fit in int.
8001
aca216ff
PE
8002 * print.c (float_to_string): Detect width overflow more reliably.
8003 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8004 buffer overrun. Don't assume list length fits in 'int'. Treat
8005 print length of 0 as 0, not as infinity; to be consistent with other
8006 uses of print length in this function. Don't overflow print length
8007 index. Don't assume hash table size fits in 'long', or that
8008 vectorlike size fits in 'unsigned long'.
8009
31c286f7
PE
8010 * process.c (make_process): Use printmax_t, not int, to format
8011 process-name gensyms.
8012
55e5faa1
PE
8013 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8014
80f2e268
PE
8015 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8016 to avoid potential buffer overrun.
8017
670741ab
PE
8018 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8019 if X resource line is longer than 512 bytes.
8020
b7163a50
PE
8021 * xfns.c (x_window): Make sprintf buffer a bit bigger
8022 to avoid potential buffer overrun.
8023
ae58ff1f
PE
8024 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8025
c43c8a6a
PE
8026 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8027
3f8236f4
PE
80282011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8029
53e9fe90 8030 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8031 Without these, Emacs silently mishandles large integers sometimes.
8032 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8033 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8034
6511acf2
PE
8035 * xdisp.c (try_window_id): Check Emacs fixnum range before
8036 converting to 'int'.
806add1d 8037
6511acf2 8038 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8039 Check that an Emacs fixnum is in range before assigning it to 'int'.
8040 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8041 values converted from Emacs fixnums.
8042 (Frecenter): Don't wrap around a line count if it is out of 'int'
8043 range; instead, treat it as an extreme value.
8044 (Fset_window_configuration, compare_window_configurations):
8045 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8046
6511acf2
PE
8047 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8048 that can exceed INT_MAX. Check that EMACS_INT value is in range
8049 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8050 (match_limit): Don't assume that a fixnum can fit in 'int'.
8051
6511acf2 8052 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8053 exceed INT_MAX.
8054
6511acf2 8055 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8056 (Fvertical_motion): Don't wrap around LINES values that don't fit
8057 in 'int'. Instead, treat them as extreme values. This is good
8058 enough for windows, which can't have more than INT_MAX lines anyway.
8059
fcb901a7
LMI
80602011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8061
0f2f6b6d
LMI
8062 * Require libxml/parser.h to avoid compilation warning.
8063
fcb901a7
LMI
8064 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8065
8066 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8067 since this reportedly can destroy thread storage.
8068
6e20a0d4
CY
80692011-08-30 Chong Yidong <cyd@stupidchicken.com>
8070
8071 * syntax.c (find_defun_start): Update all cache variables if
8072 exiting early (Bug#9401).
8073
148ae00e
EZ
80742011-08-30 Eli Zaretskii <eliz@gnu.org>
8075
f6cfbd8f
EZ
8076 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8077
148ae00e
EZ
8078 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8079 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8080 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8081
8082 * term.c (tty_append_glyph): New function.
8083 (produce_stretch_glyph): Static function and its prototype deleted.
8084
a66cfb1c
SM
8085 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8086 Add prototypes.
148ae00e 8087
c4a07a4c
PE
80882011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8089
8090 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8091 when checking :margin (Bug#9390).
8092 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8093 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8094 so that the name doesn't mislead. All uses changed.
8095
6bc8cd65
JB
80962011-08-28 Johan Bockgård <bojohan@gnu.org>
8097
8098 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8099 set_tty_hooks.
8100
dca4927e
EZ
81012011-08-27 Eli Zaretskii <eliz@gnu.org>
8102
8103 * xdisp.c (move_it_to): Don't bail out early when reaching
8104 position beyond to_charpos, if we are scanning backwards.
8105 (move_it_vertically_backward): When DY == 0, make sure we get to
8106 the first character in the line after the newline.
8107
f2cad773
PE
81082011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8109
8110 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8111 (ccl_driver): Do not generate an out-of-range pointer.
8112 (Fccl_execute_on_string): Remove unnecessary check for
8113 integer overflow, noted by Stefan Monnier in
8114 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8115 Remove a FIXME that didn't need fixing.
8116 Simplify the newly-introduced buffer reallocation code.
8117
0cae2cdb
JB
81182011-08-27 Juanma Barranquero <lekktu@gmail.com>
8119
8120 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8121
5fc295a4 81222011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8123
70c60eb2 8124 Integer and memory overflow issues (Bug#9196).
726e0ab1 8125
d31850da
PE
8126 * doc.c (get_doc_string): Rework so that
8127 get_doc_string_buffer_size is the actual buffer size, rather than
8128 being 1 less than the actual buffer size; this makes xpalloc more
8129 convenient.
8130
a69fbedb
PE
8131 * image.c (x_allocate_bitmap_record, cache_image):
8132 * xselect.c (Fx_register_dnd_atom):
8133 Simplify previous changes by using xpalloc.
8134
fe5c5d37
PE
8135 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8136 since either will do and ptrdiff_t is convenient with xpalloc.
8137
0065d054
PE
8138 * charset.c (charset_table_size)
8139 (struct charset_sort_data.priority): Now ptrdiff_t.
8140 (charset_compare): Don't overflow if priorities differ greatly.
8141 (Fsort_charsets): Don't assume list length fits in int.
8142 Check for size-calculation overflow when allocating sort data.
8143 (syms_of_charset): Allocate an initial charset table that is
8144 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8145
8146 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8147
8148 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8149 The actual value is always <= INT_MAX, and leaving it unsigned made
8150 overflow checking harder.
8151
8152 * dispextern.h (struct glyph_matrix.rows_allocated)
8153 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8154 with xpalloc. The values are still always <= INT_MAX.
8155
8156 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8157
8158 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8159 (SAFE_NALLOCA): New macro.
8160
8161 * region-cache.c (struct boundary.pos, find_cache_boundary)
8162 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8163 (set_cache_region, invalidate_region_cache)
8164 (revalidate_region_cache, know_region_cache, region_cache_forward)
8165 (region_cache_backward, pp_cache):
8166 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8167 so that ptrdiff_t * can be passed to xpalloc.
8168 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8169 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8170 (pp_cache): Don't assume cache_len fits in int.
8171 * region-cache.h: Adjust extern decls to match.
8172
8173 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8174 EMACS_INT, since either will do, for xpalloc.
8175
8176 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8177 (xnmalloc, xnrealloc, xpalloc): New functions.
8178
726e0ab1
PE
8179 * bidi.c (bidi_shelve_header_size): New constant.
8180 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8181 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8182
51f30bc5 8183 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8184 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8185 (overlay_strings):
8186 Don't update size of array until after memory allocation succeeds,
8187 because xmalloc/xrealloc may not return.
0065d054
PE
8188 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8189 now that we have proper integer overflow checking.
8190 (record_overlay_string, overlay_strings): Catch overflows when
8191 calculating size of overlay_str_buf.
726e0ab1 8192
0065d054
PE
8193 * callproc.c (Fcall_process): Check for size overflow when
8194 calculating size of args2.
8195 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8196 Normally we prefer signed values, but sticking with ptrdiff_t would
8197 require adding more-complicated checks.
726e0ab1
PE
8198
8199 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8200 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8201 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8202 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8203
8204 * character.c (Fstring): Check for size-calculation overflow.
8205
8206 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8207 unnecessary integer overflow. Check for size overflow.
8208 (encode_coding_object): Don't update size until xmalloc succeeds.
8209
8210 * composite.c (get_composition_id): Check for overflow in glyph
8211 length calculations.
8212
8213 Integer and memory overflow fixes for display code.
8214 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8215 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8216 (scrolling_window): Check for overflow in size calculations.
8217 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8218 Don't assume glyph table len fits in int.
8219 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8220 (row_table_size): Now ptrdiff_t, not int.
8221 (scrolling_window): Avoid overflow in size calculations.
8222 Don't update size until allocation succeeds.
8223 * fns.c (concat): Check for overflow in size calculations.
8224 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8225 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8226 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8227
8228 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8229 (get_doc_string): Check for size calculation overflow.
8230 Don't update size until allocation succeeds.
8231 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8232 EMACS_INT, where ptrdiff_t will do.
8233 (Fsubstitute_command_keys): Check for string overflow.
8234
8235 * editfns.c (set_time_zone_rule): Don't assume environment length
8236 fits in int.
8237 (message_length): Now ptrdiff_t, not int.
8238 (Fmessage_box): Don't update size until allocation succeeds.
8239 Don't assume message length fits in int.
8240 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8241
0065d054
PE
8242 * emacs.c (main): Do not reallocate argv, since there is a null at
8243 the end that can be overwritten, and this way there's no need to
8244 worry about size-calculation overflow.
8245 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8246
8247 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8248 alloc succeeds.
8249 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8250
8251 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8252 (x_set_scroll_bar_width, x_figure_window_size):
8253 Check for integer overflow.
8254 (x_set_alpha): Do not assume XINT fits in int.
8255
8256 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8257 This is for the members text_lines, text_cols, total_lines, total_cols,
8258 where the system imposes an 'int' limit.
8259
8260 * fringe.c (Fdefine_fringe_bitmap):
8261 Don't update size until alloc works.
8262
8263 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8264 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8265
8266 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8267 Check for size-calculation overflow.
8268 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8269 do, as we prefer signed integers.
8270 (id_to_widget.max_size, id_to_widget.used)
8271 (xg_store_widget_in_map, xg_remove_widget_from_map)
8272 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8273 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8274 Use and return ptrdiff_t, not int.
8275 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8276 * gtkutil.h: Change prototypes to match the above.
8277
8278 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8279 are duplicate now that they've been promoted to lisp.h.
8280 (x_allocate_bitmap_record, x_alloc_image_color)
8281 (make_image_cache, cache_image, xpm_load):
8282 Don't update size until alloc is done.
8283 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8284 (x_detect_edges):
3256efce 8285 Check for size calculation overflow.
726e0ab1
PE
8286 (ct_colors_allocated_max): New constant.
8287 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8288 overflow.
3256efce 8289
726e0ab1
PE
8290 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8291 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8292 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8293 Use ptrdiff_t, not int, to count maps.
8294 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8295 calculations. Don't update size until allocation succeeds.
8296 Redo calculations to avoid overflow.
726e0ab1
PE
8297 * keyboard.h: Change prototypes to match the above.
8298
8299 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8300 to count maps.
8301 (current_minor_maps): Check for size calculation overflow.
8302 * keymap.h: Change prototypes to match the above.
8303
8304 * lread.c (read1, init_obarray): Don't update size until alloc done.
8305
8306 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8307 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8308
726e0ab1
PE
8309 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8310 Now ptrdiff_t, not int.
8311 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8312 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8313
8314 * process.c (Fnetwork_interface_list): Check for overflow
8315 in size calculation.
8316
8317 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8318
8319 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8320 overflow. Don't bother calling xmalloc when xrealloc will do.
8321
8322 * search.c (Freplace_match): Check for size calculation overflow.
8323 (Fset_match_data): Don't assume list lengths fit in 'int'.
8324
8325 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8326 for command line length. Do not attempt to address one before the
8327 beginning of an array, as that's not portable.
8328
8329 * term.c (max_frame_lines): Remove; unused.
8330 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8331 not int.
8332 (encode_terminal_code, calculate_costs): Check for size
8333 calculation overflow.
8334 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8335 table lengths and related sizes. Don't update size until alloc
8336 done. Redo calculations to avoid overflow.
8337 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8338
8339 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8340 subtracting pointers.
8341 (gobble_line): Check for overflow more carefully. Don't update size
8342 until alloc done.
8343
8344 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8345 Don't update size until alloc done.
8346 Redo size calculations to avoid overflow.
8347 Check for size calculation overflow.
0065d054 8348 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8349
8350 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8351 Use ptrdiff_t, not int, for sizes.
8352 (store_mode_line_noprop_char): Don't update size until alloc done.
8353
0065d054
PE
8354 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8355 Use ptrdiff_t, not int, for sizes.
8356 (Finternal_make_lisp_face, cache_face):
8357 Check for size calculation overflow.
8358 (cache_face): Treat size calculation overflows as if they were
8359 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8360
8361 * xfns.c (x_encode_text, x_set_name_internal)
8362 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8363 sizes, since they can exceed INT_MAX in size. Check for size
8364 calculation overflow.
8365
0065d054
PE
8366 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8367 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8368 Don't update size until alloc done.
8369
0065d054 8370 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8371 as sprintf is limited to int lengths.
1d526e2f 8372
252c5ee1
PE
8373 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8374 (X_LONG_MIN): New macros.
864d7ce7
PE
8375 Use them to make the following changes clearer.
8376 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8377 This change doesn't affect the value now, but it may help remind
8378 future maintainers not to raise the value too much later.
8379 (SELECTION_QUANTUM): Remove, replacing with ...
8380 (selection_quantum): ... new function, which avoids overflow.
8381 All uses changed.
8382 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8383 assumption that selection length fits in 'int'.
8384 (x_reply_selection_request, x_handle_selection_request)
8385 (x_get_window_property, receive_incremental_selection)
8386 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8387 (lisp_data_to_selection_data, clean_local_selection_data):
8388 Use ptrdiff_t, not int, to record length of selection.
8389 (x_reply_selection_request, x_get_window_property)
8390 (receive_incremental_selection, x_property_data_to_lisp):
8391 Redo calculations to avoid overflow.
8392 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8393 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8394 something.
8395 (x_get_window_property, receive_incremental_selection)
8396 (lisp_data_to_selection_data, x_property_data_to_lisp):
8397 Check for size-calculation overflow.
8398 (x_get_window_property, receive_incremental_selection)
8399 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8400 Don't store size until memory allocation succeeds.
8401 (x_get_window_property): Plug memory leak on memory exhaustion.
8402 Don't double-block input; malloc is safe here. Don't assume 2**34
8403 - 4 fits in unsigned long. Add an xassert to check
8404 XGetWindowProperty overflow. Be more careful about overflow
8405 calculations, and distinguish size from memory overflow better.
8406 (receive_incremental_selection): When tracing, don't assume
8407 unsigned int is less than INT_MAX.
8408 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8409 harmful) conversions of unsigned short to int.
8410 (lisp_data_to_selection_data): Don't assume that integers
8411 in the range -65535 through -1 fit in an X unsigned short.
8412 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8413 result parameters unless successful. Rely on cons_to_unsigned
8414 to report problems with elements; the old code wasn't right anyway.
8415 (x_check_property_data): Check for int overflow; we cannot use
8416 a wider type due to X limits.
8417 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8418
726e0ab1 8419 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8420
0065d054
PE
8421 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8422 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8423 (x_color_cells): Don't store size until memory allocation succeeds.
8424 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8425 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8426 (x_term_init): Don't assume length fits in int (sprintf is limited
8427 to int size).
bc18e09d 8428
ebfa62c0
PE
8429 Use ptrdiff_t for composition IDs.
8430 * character.c (lisp_string_width):
8431 * composite.c (composition_table_size, n_compositions)
8432 (get_composition_id, composition_gstring_from_id):
8433 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8434 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8435 * window.c (Frecenter):
8436 Use ptrdiff_t, not int, for composition IDs.
8437 * composite.c (get_composition_id): Check for integer overflow.
8438 * composite.h: Adjust prototypes to match the above changes.
8439
d3411f89
PE
8440 Use ptrdiff_t for hash table indexes.
8441 * category.c (hash_get_category_set):
8442 * ccl.c (ccl_driver):
8443 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8444 * coding.c (coding_system_charset_list, detect_coding_system):
8445 * coding.h (struct coding_system.id):
8446 * composite.c (get_composition_id, gstring_lookup_cache):
8447 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8448 * image.c (xpm_get_color_table_h):
8449 * lisp.h (hash_lookup, hash_put):
8450 * minibuf.c (Ftest_completion):
8451 Use ptrdiff_t for hash table indexes, not int (which is too
8452 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8453 32-bit --with-wide-int hosts).
8454
e097a6fa
PE
8455 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8456 Add a FIXME comment about memory leaks.
8457 (syms_of_charset): Don't assume xmalloc returns.
8458
5637687f
PE
8459 Don't assume that stated character widths fit in int.
8460 * character.c (Fchar_width, c_string_width, lisp_string_width):
8461 * character.h (CHAR_WIDTH):
8462 * indent.c (MULTIBYTE_BYTES_WIDTH):
8463 Use sanitize_char_width to avoid undefined and/or bad behavior
8464 with outlandish widths.
a66cfb1c 8465 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8466 now that we have two such functions. All uses changed.
8467 (sanitize_char_width): New inline function.
8468
a2271ba2
PE
8469 Don't assume that tab-width fits in int.
8470 * character.h (sanitize_width): New inline function.
8471 (SANE_TAB_WIDTH): New macro.
8472 (ASCII_CHAR_WIDTH): Use it.
8473 * indent.c (sane_tab_width): Remove. All uses replaced by
8474 SANE_TAB_WIDTH (current_buffer).
8475 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8476
18c52557
PE
8477 * fileio.c: Integer overflow issues with file modes.
8478 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8479
caeeedc1
PE
8480 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8481 Remove unreachable code.
8482 (read_hex, load_charset_map_from_file): Check for integer overflow.
8483
6df6ae42 8484 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8485 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8486 (x_send_scroll_bar_event): Likewise. Check that the size does not
8487 exceed limits imposed by XClientMessageEvent, as well as the usual
8488 ptrdiff_t and size_t limits.
8489
b13995db
PE
8490 * keyboard.c: Overflow, signedness and related fixes.
8491 (make_lispy_movement): Use same integer type in forward decl
8492 that is used in the definition.
8493 (read_key_sequence, keyremap_step):
8494 Change bufsize argument back to int, undoing my 2011-03-30 change.
8495 We prefer signed types, and int is wide enough here.
8496 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8497 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8498 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8499 length, not size_t. Use ptrdiff_t for index, not int.
8500 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8501 possibility of integer overflow.
8502
13464394
PE
8503 Overflow, signedness and related fixes for images.
8504
8505 * dispextern.h (struct it.stack[0].u.image.image_id)
8506 (struct_it.image_id, struct image.id, struct image_cache.size)
8507 (struct image_cache.used, struct image_cache.ref_count):
8508 * gtkutil.c (update_frame_tool_bar):
8509 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8510 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8511 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8512 * nsmenu.m (update_frame_tool_bar):
8513 * xdisp.c (calc_pixel_width_or_height):
8514 * xfns.c (image_cache_refcount):
8515 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8516 on typical 64-bit hosts.
8517
8518 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8519 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8520 Omit unnecessary casts to int.
8521 (parse_image_spec): Check that integers fall into 'int' range
8522 when the callers expect that.
8523 (image_ascent): Redo ascent calculation to avoid int overflow.
8524 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8525 (lookup_image): Remove unnecessary tests.
8526 (xbm_image_p): Locals are now of int, not EMACS_INT,
8527 since parse_image_check makes sure they fit into int.
8528 (png_load, gif_load, svg_load_image):
8529 Prefer int to unsigned where either will do.
8530 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8531 old tiff_error_handler and tiff_warning_handler.
8532 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8533 stack buffer overflows. It uses only the features of vsnprintf
8534 that are common to both POSIX and native Microsoft.
8535 (tiff_error_handler, tiff_warning_handler): Use it.
8536 (tiff_load, gif_load, imagemagick_load_image):
8537 Don't assume :index value fits in 'int'.
8538 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8539 (imagemagick_load_image): Check that crop parameters fit into
8540 the integer types that MagickCropImage accepts. Don't assume
8541 Vimagemagick_render_type has a nonnegative value. Don't assume
8542 size_t fits in 'long'.
8543 (gs_load): Use printmax_t to print the widest integers possible.
8544 Check for integer overflow when computing image height and width.
8545
c11821d4
EZ
85462011-08-26 Eli Zaretskii <eliz@gnu.org>
8547
8548 * xdisp.c (redisplay_window): Don't force window start if point
8549 will be invisible in the resulting window. (Bug#9324)
8550
0c95fcf7
EZ
85512011-08-25 Eli Zaretskii <eliz@gnu.org>
8552
8553 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8554 the display spec is of the form `(space ...)'.
8555 (handle_display_spec): Return the value returned by
8556 handle_single_display_spec, not just 1 or zero.
8557 (handle_single_display_spec): If the display spec is of the form
8558 `(space ...)', and specifies display in the text area, return 2
8559 rather than 1.
fee65a97 8560 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8561 accurately, and prefer exact match for point under bidi.
8562 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8563
8564 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8565 into disp_prop; all users changed.
8566
8567 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8568 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8569 for the text covered by the display property.
8570
e4ed06f1
CY
85712011-08-25 Chong Yidong <cyd@stupidchicken.com>
8572
8573 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8574 Change return value to nil.
8575 (Frecord_buffer): Delete unused function.
8576
f67cdd7f
EZ
85772011-08-24 Eli Zaretskii <eliz@gnu.org>
8578
5980d4c6
EZ
8579 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8580 buffers, return left-to-right.
8610fe8b
EZ
8581 (set_cursor_from_row): Consider candidate row a win if its glyph
8582 represents a newline and point is on that newline. Fixes cursor
8583 positioning on the newline at EOL of R2L text within L2R
8584 paragraph, and vice versa.
8585 (try_cursor_movement): Check continued rows, in addition to
8586 continuation rows. Fixes unwarranted scroll when point enters a
8587 continued line of R2L text within an L2R paragraph, or vice versa.
8588 (cursor_row_p): Consider the case of point being equal to
8589 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8590 from the end of a short line to the beginning of a continued line
8591 of R2L text within L2R paragraph.
8592 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8593 composed characters.
5980d4c6 8594
f67cdd7f
EZ
8595 * bidi.c (bidi_check_type): Use xassert.
8596 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8597 members.
8598
bca633fb
EZ
85992011-08-23 Eli Zaretskii <eliz@gnu.org>
8600
8601 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8602 a character.
8603
4a5885a7
CY
86042011-08-23 Chong Yidong <cyd@stupidchicken.com>
8605
8606 * nsfont.m (ns_otf_to_script): Fix typo.
8607
0902a04e
KH
86082011-08-22 Kenichi Handa <handa@m17n.org>
8609
8610 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8611 extra slot even if the purpose is char-code-property-table.
8612
1a2e6670
EZ
86132011-08-23 Eli Zaretskii <eliz@gnu.org>
8614
8ddde651
EZ
8615 * xdisp.c (redisplay_window): When computing centering_position,
8616 account for the height of the header line. (Bug#8874)
8617
425cc014
EZ
8618 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8619 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8620 candidate is selected by the mouse, and that candidate has a
8621 composed character under the mouse.
8622
1a2e6670
EZ
8623 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8624 coordinates reported by pos-visible-in-window-p for a composed
8625 character in column zero.
8626
8b76d6f8
SM
86272011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8628
8629 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8630
dac347dd
EZ
86312011-08-22 Eli Zaretskii <eliz@gnu.org>
8632
8633 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8634 consider it a hit if to_charpos is anywhere in the range of the
8635 composed buffer positions.
8636
e013fb34
CY
86372011-08-22 Chong Yidong <cyd@stupidchicken.com>
8638
8639 * image.c (gif_load): Don't assume that each subimage has the same
8640 dimensions as the base image. Handle disposal method that is
8641 "undefined" by the gif spec (Bug#9335).
8642
bd1ba3e8
CY
86432011-08-20 Chong Yidong <cyd@stupidchicken.com>
8644
8645 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8646 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8647
54a1215b
EZ
86482011-08-19 Eli Zaretskii <eliz@gnu.org>
8649
823564e5
EZ
8650 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8651 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8652 from an Org mode buffer to a Speedbar frame.
8653
54a1215b
EZ
8654 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8655 a composition, take its buffer position from IT->cmp_it.charpos.
8656 Fixes cursor positioning at the beginning of a line that begins
8657 with a composed character.
8658
9778ebcc
EZ
86592011-08-18 Eli Zaretskii <eliz@gnu.org>
8660
0be6ee06
EZ
8661 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8662 character bidirectional type, use STRONG_L instead. Fixes crashes
8663 in a buffer produced by `describe-categories'.
8664
9778ebcc
EZ
8665 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8666 members before the level stack, so they would be saved and
8667 restored when copying iterator state. Fixes incorrect reordering
8668 around TABs covered by display properties.
8669
156bffbe
AS
86702011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8671
6b02f655 8672 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8673
72ad093b
CY
86742011-08-17 Chong Yidong <cyd@stupidchicken.com>
8675
8676 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8677 (internal_condition_case_2, internal_condition_case_n):
8678 Remove unnecessary aborts (Bug#9081).
72ad093b 8679
35774242
EZ
86802011-08-17 Eli Zaretskii <eliz@gnu.org>
8681
8682 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8683 has no `load' handler, try opening the file locally. (Bug#9311)
8684
db76dd85
KB
86852011-08-16 Ken Brown <kbrown@cornell.edu>
8686
8687 * gmalloc.c: Expand comment.
8688
b215eee5
EZ
86892011-08-16 Eli Zaretskii <eliz@gnu.org>
8690
8691 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8692 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8693
a4579d33
KB
86942011-08-16 Ken Brown <kbrown@cornell.edu>
8695
8696 Fix memory allocation problems in Cygwin build (Bug#9273).
8697
8698 * unexcw.c ( __malloc_initialized): Declare external variable.
8699 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8700
8b76d6f8
SM
8701 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8702 New variables.
a4579d33
KB
8703 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8704 dumped emacs.
8705 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8706 in the static heap.
8707 [CYGWIN] (special_realloc): New function.
8708 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8709 requests to realloc storage in the static heap.
8710
3ebec551
PE
87112011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8712
8713 * bidi.c (bidi_initialize): Remove unused local.
8714
9fd8be00
EZ
87152011-08-15 Eli Zaretskii <eliz@gnu.org>
8716
6b02f655
SM
8717 * bidimirror.h:
8718 * biditype.h: Remove file.
8719 * makefile.w32-in ($(BLD)/bidi.$(O)):
8720 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8721
8722 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8723
8724 * chartab.c: Improve commentary for the uniprop_table API.
8725
32413314
EZ
8726 * bidi.c (bidi_paragraph_init): Support zero value of
8727 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8728 (bidi_initialize): Use uniprop_table instead of including
8729 biditype.h and bidimirror.h.
32413314 8730
9fd8be00
EZ
8731 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8732 coordinates of the iterator when restoring from ppos_it.
8733 (Bug#9296)
8734
5cf2b69b
KH
87352011-08-14 Kenichi Handa <handa@m17n.org>
8736
8737 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8738 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8739
daf17d00
EZ
87402011-08-14 Eli Zaretskii <eliz@gnu.org>
8741
8742 * xdisp.c (move_it_in_display_line_to): Don't invoke
8743 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8744 ppos_it. Fixes vertical cursor motion when line beginning is
8745 covered by an image. (Bug#9296)
8746
08e3161a
JD
87472011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8748
8749 * nsterm.h (ns_run_ascript): Declare.
8750 (NSAPP_DATA2_RUNASSCRIPT): Define.
8751
8752 * nsfns.m (as_script, as_result, as_status): New static variables.
8753 (ns_run_ascript): New function.
5e617bc2 8754 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8755 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8756 the event loop. Get status from as_status (Bug#7276).
8757
8758 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8759 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8760 the event loop (Bug#7276).
8761
a3720aa2
AS
87622011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8763
8764 * gnutls.c (QCgnutls_bootprop_priority)
8765 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8766 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8767 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8768 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8769 (QCgnutls_bootprop_verify_hostname_error)
8770 (QCgnutls_bootprop_callbacks_verify): Rename from
8771 Qgnutls_bootprop_..., all uses changed.
8772
8773 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8774 uses changed.
8775
0a0d27fb
PE
87762011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8777
19d5c50c
PE
8778 * xfaces.c (Qframe_set_background_mode): Now static.
8779 * dispextern.h (Qframe_set_background_mode): Remove decl.
8780
0a0d27fb
PE
8781 * process.c (Fnetwork_interface_info): Declare local only if needed.
8782
377538cb
JD
87832011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8784
8785 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8786 (Fnetwork_interface_list): Allocate in increments of bytes instead
8787 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8788 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8789 sockaddr.
8790 (struct ifflag_def): notrailers is smart on OSX.
8791 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8792 Get hardware address with getifaddrs if available.
8793
08fff70c
EZ
87942011-08-12 Eli Zaretskii <eliz@gnu.org>
8795
8796 * xdisp.c (iterate_out_of_display_property): xassert that
8797 IT->position is set to within IT->object's boundaries. Break from
8798 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8799 when IT->position is set up wrongly due to some bug.
8800 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8801 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8802 entry. Force push_it to save on the stack the current
8803 buffer/string position, to be restored by pop_it. Fix flags in
8804 the iterator structure wrt the object coming from a display
8805 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8806 properties. (Bug#9284)
8807
7be1c708 88082011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8809
7be1c708
CY
8810 * fontset.c (fontset_get_font_group): Add proper type checks.
8811 (Bug#9172)
aac0c6e3 8812
7be1c708 88132011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8814
7be1c708
CY
8815 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8816 and LC_VERSION_MIN_MACOSX.
8817 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8818 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8819
97bb72a6
EZ
88202011-08-08 Eli Zaretskii <eliz@gnu.org>
8821
8822 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8823 no-display-properties-and-no-overlays under bidi display.
8824 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8825 properties and overlays.
97bb72a6 8826
d5617611
CY
88272011-08-08 Chong Yidong <cyd@stupidchicken.com>
8828
37e11a63
CY
8829 * editfns.c (Fset_time_zone_rule): Document relationship with the
8830 setenv function.
8831
d5617611
CY
8832 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8833 the font entity extracted from the cache (Bug#8109).
8834
58872834
CY
88352011-08-07 Chong Yidong <cyd@stupidchicken.com>
8836
8837 * composite.c (autocmp_chars): Don't reset point. That is done by
8838 restore_point_unwind (Bug#5984).
8839
75bfc667
JL
88402011-08-07 Juri Linkov <juri@jurta.org>
8841
8842 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8843 to show the arg `TIME' instead of `TIMEVAL'.
8844
d1410150
EZ
88452011-08-06 Eli Zaretskii <eliz@gnu.org>
8846
8847 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8848 display property strides EOL and includes a newline, as in
8849 longlines-mode. (Bug#9254)
75b771e4
EZ
8850 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8851 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8852
8853 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8854 is non-zero, even if the data buffer is NULL. Fixes a crash in
8855 vertical-motion with longlines-mode. (Bug#9254)
8856
35928349
EZ
88572011-08-05 Eli Zaretskii <eliz@gnu.org>
8858
ec7cc85b
EZ
8859 * bidi.c <bidi_cache_total_alloc>: Now static.
8860 (bidi_initialize): Initialize bidi_cache_total_alloc.
8861
8b76d6f8 8862 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8863 cache. (Bug#9221)
8864
8865 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8866 amount allocated this far in `bidi_cache_total_alloc'.
8867 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8868 non-zero, only free the data buffer without restoring the cache
8869 contents. All callers changed.
8870
8871 * dispextern.h (bidi_unshelve_cache): Update prototype.
8872
8873 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8874 (move_it_in_display_line, move_it_to)
8875 (move_it_vertically_backward, move_it_by_lines): Replace the call
8876 to xfree to an equivalent call to bidi_unshelve_cache.
8877 (move_it_in_display_line_to): Fix logic of returning
412b6358 8878 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8879
e2e2423b
EZ
88802011-08-05 Eli Zaretskii <eliz@gnu.org>
8881
8882 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8883 came from a string character with a `cursor' property. (Bug#9229)
8884
ae9e757a
JD
88852011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8886
8887 * Makefile.in (LIB_PTHREAD): New variable.
8888 (LIBES): Add LIB_PTHREAD (Bug#9216).
8889
8890 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8891 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8892
213bd7f2
AS
88932011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8894
6b02f655 8895 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8896
99aaf75f
JD
88972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8898
8899 * xterm.c (x_find_topmost_parent): New function.
8900 (x_set_frame_alpha): Find topmost parent window with
8901 x_find_topmost_parent and set the property there also (bug#9181).
8902 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8903
c74e9d86
PE
89042011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8905
8906 * callproc.c (Fcall_process): Avoid vfork clobbering
8907 the local vars buffer, coding_systems, current_dir.
8908
640c8776
SM
89092011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8910
8911 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8912
f26d0e4c
PE
89132011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8914
8a10d76c
PE
8915 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8916 so that it is not optimized away.
8917
f26d0e4c
PE
8918 * xdisp.c (compute_display_string_pos): Remove unused local.
8919
55439c61
EZ
89202011-08-02 Eli Zaretskii <eliz@gnu.org>
8921
8922 Fix slow cursor motion and scrolling in large buffers with
8923 selective display, like Org Mode buffers. (Bug#9218)
8924
8925 * dispextern.h (struct bidi_it): New member disp_prop_p.
8926
8927 * xdisp.c: Remove one-slot cache of display string positions.
8928 (compute_display_string_pos): Accept an additional argument
5e617bc2 8929 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8930 for a display string or property. If found, set DISP_PROP_P
8931 non-zero.
8932
8933 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8934 DISP_PROP_P, and pass it to compute_display_string_pos.
8935 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8936 non-zero. All callers of bidi_fetch_char changed.
8937
fb33fa43
SM
89382011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8939
8940 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8941
b099e063
DM
89422010-12-03 Don March <don@ohspite.net>
8943
8944 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8945 last character M-[char] is translated to ESC [char] (bug#7541).
8946
5cc7f7af
KH
89472011-08-02 Kenichi Handa <handa@m17n.org>
8948
d0fffa3f 8949 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8950
8951 * chartab.c (uniprop_table): Make it non-static.
8952
525d5e6e
EZ
89532011-08-01 Eli Zaretskii <eliz@gnu.org>
8954
8955 * xdisp.c (forward_to_next_line_start): Accept additional argument
8956 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8957 on the newline.
8958 (reseat_at_next_visible_line_start): Use the bidi iterator state
8959 returned by forward_to_next_line_start to restore the state of
8960 it->bidi_it after backing up to previous newline. (Bug#9212)
8961
31011111
AS
89622011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8963
8964 * regex.c (re_comp): Protoize.
8965 (re_exec): Fix return type.
8966 (regexec): Fix type of `ret'. (Bug#9203)
8967
476371c4
PE
89682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8969
e5d76069
PE
8970 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8971 This is needed if max-image-size is a floating-point number.
8972
9a79b20c
AS
89732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8974
8975 * print.c (print_object): Print empty symbol as ##.
8976
8977 * lread.c (read1): Read ## as empty symbol.
8978
d8c2fa78
AA
89792011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8980
8981 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8982 setting frame foreground color (Bug#9175).
8983 (x_set_background_color): Likewise.
8984
ffe57a7a
AA
8985 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8986 contents (Bug#9176).
8987 (EmacsTooltip -init): Remove bezels and add shadows to
8988 tooltip windows.
8989
bf3492a5
AA
8990 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8991 or scroll bar (Bug#8470).
8992
d55e9c53
AA
8993 * nsfont.m (nsfont_open): Remove assignment to voffset and
8994 unnecessary vars hshink, expand, hd, full_height, min_height.
8995 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8996
8997 * nsterm.h (nsfont_info): Remove voffset field.
8998
d8c2fa78 89992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9000
9001 Implement strike-through and overline on NextStep (Bug#8863).
9002
9003 * nsfont.m (nsfont_open): Use underline position provided by font,
9004 instead of hard-coded value of 2.
9005 (nsfont_draw): Call ns_draw_text_decoration instead.
9006
9007 * nsterm.h: Add declaration for ns_draw_text_decoration.
9008
9009 * nsterm.m (ns_draw_text_decoration): New function for drawing
9010 underline, overline, and strike-through.
9011 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9012 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9013 accommodate underlining, etc.
4843aac3 9014
4cc60b9b
EZ
90152011-07-28 Eli Zaretskii <eliz@gnu.org>
9016
bc7ece87
EZ
9017 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9018 default.
4cc60b9b 9019
476371c4
PE
90202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9021
66606eea
PE
9022 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9023 Without this fix, if a signal arrives just after memory fills up,
9024 'malloc' might be invoked reentrantly.
9025
476371c4
PE
9026 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9027 In other words, assume that every image size is allowed, on non-X
9028 hosts. This assumption is probably wrong, but it lets Emacs compile.
9029
f3fcc40d
AS
90302011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9031
9032 * regex.c (re_iswctype): Convert return values to boolean.
9033
350c992f
EZ
90342011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9035
9036 * xdisp.c (compute_display_string_pos): Don't use cached display
9037 string position if the buffer had its restriction changed.
9038 (Bug#9184)
9039
5266b4bb
PE
90402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9041
9042 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9043
2573a837 90442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9045
41f55ccd 9046 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9047
39e378da
PE
9048 * bidi.c: Integer size and overflow fixes.
9049 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9050 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9051 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9052 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9053 (bidi_find_other_level_edge):
9054 Use ptrdiff_t instead of EMACS_INT where either will do.
9055 This works better on 32-bit hosts configured --with-wide-int.
9056 (bidi_cache_ensure_space): Check for size-calculation overflow.
9057 Use % rather than repeated addition, for better worst-case speed.
9058 Don't set bidi_cache_size until after xrealloc returns, because it
9059 might not return.
9060 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9061 (bidi_cache_ensure_space): Also check that the bidi cache size
9062 does not exceed that of the largest Lisp string or buffer. See Eli
9063 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9064
5e927815
PE
9065 * alloc.c (__malloc_size_t): Remove.
9066 All uses replaced by size_t. See Andreas Schwab's note
9067 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9068
ca4aa935
PE
9069 * image.c: Improve checking for integer overflow.
9070 (check_image_size): Assume that f is nonnull, since
9071 it is always nonnull in practice. This is one less thing to
9072 worry about when checking for integer overflow later.
9073 (x_check_image_size): New function, which checks for integer
9074 overflow issues inside X.
9075 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9076 This removes the need for a memory_full check.
9077 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9078 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9079 (xbm_read_bitmap_data): Change locals back to 'int', since
9080 their values must fit in 'int'.
9081 (xpm_load_image, png_load, tiff_load):
9082 Invoke x_create_x_image_and_pixmap earlier,
9083 to avoid much needless work if the image is too large.
9084 (tiff_load): Treat overly large images as if
9085 x_create_x_image_and_pixmap failed, not as malloc failures.
9086 (gs_load): Use x_check_image_size.
9087
5f8f9cc2
PE
9088 * gtkutil.c: Omit integer casts.
9089 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9090 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9091
5adf60bc
PE
9092 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9093
c8907a93
PE
9094 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9095 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9096 would wrongly return t on a 64-bit host.
9097
e3c25c68
PE
9098 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9099 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9100 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9101 and therefore cause GCC to emit a bogus diagnostic in some cases.
9102
3f791afe
PE
9103 * image.c: Integer signedness and overflow and related fixes.
9104 This is not an exhaustive set of fixes, but it's time to
9105 record what I've got.
9106 (lookup_pixel_color, check_image_size): Remove redundant decls.
9107 (check_image_size): Don't assume that arbitrary EMACS_INT values
9108 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9109 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9110 (tiff_load, imagemagick_load_image):
9111 Check for overflow in size calculations.
9112 (x_create_x_image_and_pixmap): Remove unnecessary test for
9113 xmalloc returning NULL; that can't happen.
9114 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9115 (xpm_color_bucket): Use better integer hashing function.
9116 (xpm_cache_color): Don't possibly over-allocate memory.
9117 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9118 (gif_memory_source):
9119 Use ptrdiff_t, not int or size_t, to record sizes.
9120 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9121 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9122 either works, as we prefer signed integers.
9123 (tiff_read_from_memory, tiff_write_from_memory):
9124 Return tsize_t, not size_t, since that's what the TIFF API wants.
9125 (tiff_read_from_memory): Don't fail simply because the read would
9126 go past EOF; instead, return a short read.
9127 (tiff_load): Omit no-longer-needed casts.
9128 (Fimagemagick_types): Don't assume size fits into 'int'.
9129
3cc5a532
PE
9130 Improve hashing quality when configured --with-wide-int.
9131 * fns.c (hash_string): New function, taken from sxhash_string.
9132 Do not discard information about ASCII character case; this
9133 discarding is no longer needed.
9134 (sxhash-string): Use it. Change sig to match it. Caller changed.
9135 * lisp.h: Declare it.
9136 * lread.c (hash_string): Remove, since we now use fns.c's version.
9137 The fns.c version returns a wider integer if --with-wide-int is
9138 specified, so this should help the quality of the hashing a bit.
9139
b312a492
PE
9140 * emacs.c: Integer overflow minor fix.
9141 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9142 Define only if GNU_LINUX.
9143 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9144
dfd153ae
PE
9145 * dispnew.c: Integer signedness and overflow fixes.
9146 Remove unnecessary forward decls, that were a maintenance hassle.
9147 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9148 All uses changed.
9149 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9150 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9151 (prepare_desired_row, line_draw_cost):
9152 Use int, not unsigned, where either works.
9153 (save_current_matrix, restore_current_matrix):
9154 Use ptrdiff_t, not size_t, where either works.
9155 (init_display): Check for overflow more accurately, and without
9156 relying on undefined behavior.
9157
a81d11a3
PE
9158 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9159 Remove, replacing with the new symbols in lisp.h. All uses changed.
9160 * fileio.c (make_temp_name):
9161 * filelock.c (lock_file_1, lock_file):
9162 * xdisp.c (message_dolog):
9163 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9164 Use pMd etc. instead.
9165 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9166 replacing the pWIDE etc. symbols removed from editfns.c.
9167
3300e6fd
PE
9168 * keyboard.h (num_input_events): Now uintmax_t.
9169 This is (very slightly) less likely to mess up due to wraparound.
9170 All uses changed.
9171
fd05c7e9
PE
9172 * buffer.c: Integer signedness fixes.
9173 (alloc_buffer_text, enlarge_buffer_text):
9174 Use ptrdiff_t rather than size_t when either will do, as we prefer
9175 signed integers.
9176
903fe15d
PE
9177 * alloc.c: Integer signedness and overflow fixes.
9178 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9179 (__malloc_size_t): Default to size_t, not to int.
9180 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9181 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9182 Prefer ptrdiff_t to size_t when either would do, as we prefer
9183 signed integers.
9184 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9185 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9186 Now const. Initialize with values that are in range even if char
9187 is signed.
9188 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9189 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9190 These functions do the right thing with sizes > 2**32.
9191 (check_depth): Now ptrdiff_t, not int.
9192 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9193 Adjust to new way of storing sizes. Check for size overflow bugs
9194 in rest of code.
9195 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9196 slightly wrong anyway, as it missed one instance of
9197 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9198 (refill_memory_reserve): Omit needless cast to size_t.
9199 (mark_object_loop_halt): Mark as externally visible.
9200
ac82cc6a
PE
9201 * xselect.c: Integer signedness and overflow fixes.
9202 (Fx_register_dnd_atom, x_handle_dnd_message):
9203 Use ptrdiff_t, not size_t, since we prefer signed.
9204 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9205 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9206 x_dnd_atoms_size and x_dnd_atoms_length.
9207
c2d1e36d
PE
9208 * doprnt.c: Prefer signed to unsigned when either works.
9209 * eval.c (verror):
9210 * doprnt.c (doprnt):
9211 * lisp.h (doprnt):
9212 * xdisp.c (vmessage):
9213 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9214 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9215 prefer signed arithmetic to avoid comparison confusion.
9216 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9217 but is a bit tricky.
9218
0e926e56
PE
9219 Assume freestanding C89 headers, string.h, stdlib.h.
9220 * data.c, doprnt.c, floatfns.c, print.c:
9221 Include float.h unconditionally.
9222 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9223 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9224 * regex.c: Likewise for stddef.h, string.h.
9225 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9226 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9227 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9228 (STDC_HEADERS): Remove obsolete defines.
9229 * sysdep.c: Include limits.h unconditionally.
9230
9cfdb3ec
PE
9231 Assume support for memcmp, memcpy, memmove, memset.
9232 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9233 * regex.c (memcmp, memcpy):
9234 Remove; we assume C89 now.
9235
9236 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9237 (__malloc_safe_bcopy): Remove; no longer needed.
9238
cf950e6b 9239 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9240 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9241 well either way, and we prefer signed to unsigned.
9242
dbf38e02
LMI
92432011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9244
9245 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9246 closes the connection while we're reading (bug#9182).
9247
d6f0886c 92482011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9249
d6f0886c
JD
9250 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9251 are specified (Bug#9168).
24e0f6b1 9252
2eb1f9e6
PE
92532011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9254
9255 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9256 Found by GCC static checking and --with-wide-int on a 32-bit host.
9257
22381272 92582011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9259
9260 * xdisp.c (compute_display_string_pos): Fix logic of caching
9261 previous display string position. Initialize cached_prev_pos to
9262 -1. Fixes slow-down at the beginning of a buffer.
9263
f25e39b4
EZ
92642011-07-24 Eli Zaretskii <eliz@gnu.org>
9265
9266 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9267 for attrs[LFACE_FONTSET_INDEX].
9268
04c4b52e
PE
92692011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9270
9271 * xml.c (parse_region): Remove unused local
9272 that was recently introduced.
9273
c1734fbd
EZ
92742011-07-23 Eli Zaretskii <eliz@gnu.org>
9275
be18c5a5
EZ
9276 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9277 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9278
c1734fbd
EZ
9279 * xdisp.c (move_it_in_display_line_to): Record the best matching
9280 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9281 exit if none of the characters scanned was an exact match.
9282 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9283 when exact match is impossible due to invisible text, and the
9284 lines are truncated.
9285
a258d627
JD
92862011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9287
9288 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9289 for OSX >= 10.7.
9290
b6d5a689
EZ
92912011-07-22 Eli Zaretskii <eliz@gnu.org>
9292
0f74f785
EZ
9293 Fix a significant slow-down of cursor motion with C-n, C-p,
9294 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9295 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9296 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9297 (next_element_from_buffer): Call compute_stop_pos_backwards to
9298 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9299 base_level_stop.
9300 (reseat): Don't look for prev_stop, as that could mean a very long
9301 run.
9302 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9303 <cached_disp_overlay_modiff>: Cache for last found display string
9304 position.
551918c1 9305 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9306 about the same buffer in the same area of character positions, and
9307 the buffer wasn't changed since the time the display string
9308 position was cached.
551918c1 9309
b2d0c91a
EZ
93102011-07-22 Eli Zaretskii <eliz@gnu.org>
9311
9312 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9313 is an integer, which is important for empty lines. (Bug#9149)
9314
043604ee
CY
93152011-07-22 Chong Yidong <cyd@stupidchicken.com>
9316
9317 * frame.c (Fmodify_frame_parameters): In tty case, update the
9318 default face if necessary (Bug#4238).
9319
da4adb04
CY
93202011-07-21 Chong Yidong <cyd@stupidchicken.com>
9321
9322 * editfns.c (Fstring_to_char): No need to explain what a character
9323 is in the docstring (Bug#6576).
9324
9abd0532
LMI
93252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9326
9327 * xml.c (parse_region): Make sure we always return a tree.
9328
36881d16
HK
93292011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9330
9331 * xml.c (parse_region): If a document contains only comments,
9332 return that, too.
9333
1e98674d
LMI
93342011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9335
9336 * xml.c (make_dom): Return comments, too.
9337
590bd467
PE
93382011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9339
9340 Port to OpenBSD.
9341 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9342 and the surrounding thread.
9343 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9344 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9345 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9346 timer goes off.
9347 * s/openbsd.h (BROKEN_SIGIO): Define.
9348 * unexelf.c (unexec) [__OpenBSD__]:
9349 Don't update the .mdebug section of the Alpha COFF symbol table.
9350
f41628b2
LMI
93512011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9352
9353 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9354 (bug#8460).
9355
b59b67c5
PE
93562011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9357
15e3a074
PE
9358 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9359 This fixes some race conditions on the permissions of any newly
9360 created file.
9361
41bed37d
PE
9362 * alloc.c (valid_pointer_p): Use pipe, not open.
9363 This fixes some permissions issues when debugging.
9364
b59b67c5
PE
9365 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9366 If fchown fails to set both uid and gid, try to set just gid,
9367 as that is sometimes allowed. Adjust the file's mode to eliminate
9368 setuid or setgid bits that are inappropriate if fchown fails.
9369
925a6be7
SM
93702011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9371
9372 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9373 to compare Lisp_Objects.
9374 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9375 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9376 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9377
52968808
AS
93782011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9379
0a6a104b
AS
9380 * lread.c (read_integer): Unread even EOF character.
9381 (read1): Likewise. Properly record start position of symbol.
9382
52968808
AS
9383 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9384 symbol character follows.
9385
9e381cdd
PE
93862011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9387
9388 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9389 This works around a problem with the previous change to Fcopy_file.
9390 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9391 and without this change, GCC might complain about discarding
9392 fchown's return value.
9393
b5641435
JB
93942011-07-16 Juanma Barranquero <lekktu@gmail.com>
9395
9396 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9397
a8031457
PE
93982011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9399
9400 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9401
dd889327
LMI
94022011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9403
750c33f7
LMI
9404 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9405 it's used from the C level.
9406
dd889327
LMI
9407 * process.c: Use the same condition for POLL_FOR_INPUT in both
9408 keyboard.c and process.c (bug#1858).
9409
87e86684
LM
94102011-07-09 Lawrence Mitchell <wence@gmx.li>
9411
9412 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9413 (Fgnutls_boot): Use it.
9414
64348f40
AS
94152011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9416
9417 * doc.c (Fsubstitute_command_keys): Revert last change.
9418
1d698799
LMI
94192011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9420
f863868c
LMI
9421 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9422 quotes the next character, and doesn't affect other longer
9423 sequences (bug#8935).
9424
1d698799
LMI
9425 * lread.c (syms_of_lread): Clarify that is isn't only
9426 `eval-buffer' and `eval-defun' that's affected by
9427 `lexical-binding' (bug#8460).
9428
aa4b6df6
EZ
94292011-07-15 Eli Zaretskii <eliz@gnu.org>
9430
9431 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9432 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9433
5d856da6
PE
94342011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9435
ad6042bb
PE
9436 Fix minor problems found by static checking.
9437 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9438 (elsz): Now a signed constant, not a size_t var. We prefer signed
9439 types to unsigned, to avoid integer comparison confusion. Without
9440 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9441 "cannot optimize loop, the loop counter may overflow", a symptom
9442 of the confusion.
f00bbb22 9443 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9444 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9445
6468f31c
LMI
94462011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9447
49080b10
LMI
9448 * search.c (Fre_search_backward): Mention `case-fold-search' in
9449 all the re_search_* functions (bug#8138).
9450
6468f31c
LMI
9451 * keyboard.c (Fopen_dribble_file): Document when the file is
9452 closed (bug#8056).
9453
c965adc5
EZ
94542011-07-14 Eli Zaretskii <eliz@gnu.org>
9455
df9733bf
EZ
9456 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9457 bidi_cache_idx.
9458
0bb23927
EZ
9459 Support bidi reordering of display and overlay strings.
9460 * xdisp.c (compute_display_string_pos)
9461 (compute_display_string_end): Accept additional argument STRING.
9462 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9463 (reseat_to_string): Initialize bidi_it->string.s and
9464 bidi_it->string.schars.
9465 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9466 NULL (avoids a crash in bidi_paragraph_init).
9467 Initialize itb.string.lstring.
0bb23927
EZ
9468 (init_iterator): Call bidi_init_it only of a valid
9469 buffer position was specified. Initialize paragraph_embedding to
9470 L2R.
9471 (reseat_to_string): Initialize the bidi iterator.
9472 (display_string): If we need to ignore text properties of
9473 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9474 original value of -1 will not work with bidi.)
9475 (compute_display_string_pos): First arg is now struct
9476 `text_pos *'; all callers changed. Support display properties on
9477 Lisp strings.
9478 (compute_display_string_end): Support display properties on Lisp
9479 strings.
9480 (init_iterator, reseat_1, reseat_to_string): Initialize the
9481 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9482 when iterating on a string not from display properties).
640c8776
SM
9483 (compute_display_string_pos, compute_display_string_end):
9484 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9485 arrow keys.
9486 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9487 base_level_stop; instead, set base_level_stop to BEGV.
9488 Fixes crashes in vertical-motion.
0bb23927
EZ
9489 (next_element_from_buffer): Improve commentary for when
9490 the iterator is before prev_stop.
9491 (init_iterator): Initialize bidi_p from the default value of
9492 bidi-display-reordering, not from buffer-local value. Use the
9493 buffer-local value only if initializing for buffer iteration.
9494 (handle_invisible_prop): Support invisible properties on strings
9495 that are being bidi-reordered.
9496 (set_iterator_to_next): Support bidi reordering of C strings and
9497 Lisp strings.
9498 (next_element_from_string): Support bidi reordering of Lisp
9499 strings.
9500 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9501 (display_string): Support display of R2L glyph rows.
9502 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9503 (init_iterator): Don't initialize it->bidi_p for strings
9504 here.
9505 (reseat_to_string): Initialize it->bidi_p for strings here.
9506 (next_element_from_string, next_element_from_c_string)
9507 (next_element_from_buffer): Add xassert's for correspondence
9508 between IT's object being iterated and it->bidi_it.string
9509 structure.
9510 (face_before_or_after_it_pos): Support bidi iteration.
9511 (next_element_from_c_string): Handle the case of the first string
9512 character that is not the first one in the visual order.
9513 (get_visually_first_element): New function, refactored from common
9514 parts of next_element_from_buffer, next_element_from_string, and
9515 next_element_from_c_string.
9516 (tool_bar_lines_needed, redisplay_tool_bar)
9517 (display_menu_bar): Force left-to-right direction. Add a FIXME
9518 comment for making that be controlled by a user option.
9519 (push_it, pop_it): Save and restore the state of the
9520 bidi iterator. Save and restore the bidi_p flag.
9521 (pop_it): Iterate out of display property for string iteration as
9522 well.
9523 (iterate_out_of_display_property): Support iteration over strings.
9524 (handle_single_display_spec): Set up it->bidi_it for iteration
9525 over a display string, and call bidi_init_it.
9526 (handle_single_display_spec, next_overlay_string)
9527 (get_overlay_strings_1, push_display_prop): Set up the bidi
9528 iterator for displaying display or overlay strings.
9529 (forward_to_next_line_start): Don't use the shortcut if
9530 bidi-iterating.
9531 (back_to_previous_visible_line_start): If handle_display_prop
9532 pushed the iterator stack, restore the internal state of the bidi
9533 iterator by calling bidi_pop_it same number of times.
9534 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9535 and we are bidi-iterating, don't decrement the iterator position;
9536 instead, set the first_elt flag in the bidi iterator, to produce
9537 the same effect.
9538 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9539 (push_display_prop): xassert that we are iterating a buffer.
9540 (push_it, pop_it): Save and restore paragraph_embedding member.
9541 (handle_single_display_spec, next_overlay_string)
9542 (get_overlay_strings_1, reseat_1, reseat_to_string)
9543 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9544 correctly. Don't assume unibyte strings are not bidi-reordered.
9545 (compute_display_string_pos)
9546 (compute_display_string_end): Fix handling the case of C string.
9547 (push_it, pop_it): Save and restore from_disp_prop_p.
9548 (handle_single_display_spec, push_display_prop): Set the
9549 from_disp_prop_p flag.
9550 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9551 (pop_it): Call iterate_out_of_display_property only if we are
9552 popping after iteration over a string that came from a display
9553 property. Fix a typo in popping stretch info. Add an assertion
9554 for verifying that the iterator position is in sync with the bidi
9555 iterator.
9556 (handle_single_display_spec, get_overlay_strings_1)
9557 (push_display_prop): Fix initialization of paragraph direction for
9558 string when that of the parent object is not yet determined.
9559 (reseat_1): Call bidi_init_it to resync the bidi
9560 iterator with IT's position. (Bug#7616)
9561 (find_row_edges): If ROW->start.pos gives position
9562 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9563 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9564 Reset the from_disp_prop_p flag.
9565 (SAVE_IT, RESTORE_IT): New macros.
9566 (pos_visible_p, face_before_or_after_it_pos)
9567 (back_to_previous_visible_line_start)
9568 (move_it_in_display_line_to, move_it_in_display_line)
9569 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9570 (try_scrolling, redisplay_window, display_line): Use them when
9571 saving a temporary copy of the iterator and restoring it back.
9572 (back_to_previous_visible_line_start, reseat_1)
9573 (init_iterator): Empty the bidi cache "stack".
9574 (move_it_in_display_line_to): If iterator ended up at
9575 EOL, but we never saw any buffer positions smaller than
9576 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9577 motion in bidi-reordered lines.
9578 (move_it_in_display_line_to): Record prev_method and prev_pos
9579 immediately before the call to set_iterator_to_next. Fixes cursor
9580 motion in bidi-reordered lines with stretch glyphs and strings
9581 displayed in margins. (Bug#8133) (Bug#8867)
9582 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9583 TO_CHARPOS.
640c8776
SM
9584 (pos_visible_p): Support positions in bidi-reordered lines.
9585 Save and restore bidi cache.
0bb23927
EZ
9586
9587 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9588 (bidi_paragraph_info): Delete unused struct.
9589 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9590 (bidi_cache_start): New variable.
9591 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9592 to zero.
9593 (bidi_cache_fetch_state, bidi_cache_search)
9594 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9595 (bidi_cache_find, bidi_peek_at_next_level)
9596 (bidi_level_of_next_char, bidi_find_other_level_edge)
9597 (bidi_move_to_visually_next): Compare cache index with
9598 bidi_cache_start rather than with zero.
9599 (bidi_fetch_char): Accept new argument STRING; all callers
9600 changed. Support iteration over a string. Support strings with
9601 display properties. Support unibyte strings. Fix the type of
9602 `len' according to what STRING_CHAR_AND_LENGTH expects.
9603 (bidi_paragraph_init, bidi_resolve_explicit_1)
9604 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9605 (bidi_level_of_next_char, bidi_move_to_visually_next):
9606 Support iteration over a string.
0bb23927
EZ
9607 (bidi_set_sor_type, bidi_resolve_explicit_1)
9608 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9609 can now be zero (for strings); special values 0 and -1 were
9610 changed to -1 and -2, respectively.
9611 (bidi_char_at_pos): New function.
9612 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9613 Call it instead of FETCH_MULTIBYTE_CHAR.
9614 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9615 initialized to valid values.
9616 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9617 values.
9618 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9619 the test for valid cached positions. Fix the logic for looking up
9620 the sentinel state in the cache. GCPRO the Lisp string we are
9621 iterating.
9622 (bidi_push_it, bidi_pop_it): New functions.
9623 (bidi_initialize): Initialize the bidi cache start stack pointer.
9624 (bidi_cache_ensure_space): New function, refactored from part of
9625 bidi_cache_iterator_state. Don't assume the required size is just
9626 one BIDI_CACHE_CHUNK away.
9627 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9628 (bidi_count_bytes, bidi_char_at_pos): New functions.
9629 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9630 always valid if bidi_cache_idx is valid.
9631 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9632 is valid if it's going to be used.
9633 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9634 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9635 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9636 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9637 (bidi_find_other_level_edge, bidi_cache_start_stack):
9638 All variables related to cache indices are now EMACS_INT.
c965adc5 9639
0bb23927
EZ
9640 * dispextern.h (struct bidi_string_data): New structure.
9641 (struct bidi_it): New member `string'. Make flag members be 1-bit
9642 fields, and put them last in the struct.
640c8776
SM
9643 (compute_display_string_pos, compute_display_string_end):
9644 Update prototypes.
0bb23927
EZ
9645 (bidi_push_it, bidi_pop_it): Add prototypes.
9646 (struct iterator_stack_entry): New members bidi_p,
9647 paragraph_embedding, and from_disp_prop_p.
9648 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9649 (bidi_shelve_cache, bidi_unshelve_cache):
9650 Declare prototypes.
0bb23927
EZ
9651
9652 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9653 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9654 and vector-like objects.
9655
9656 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9657 cache around display iteration.
9658
9659 * window.c (Fwindow_end, window_scroll_pixel_based)
9660 (displayed_window_lines, Frecenter): Save and restore the bidi
9661 cache around display iteration.
9662
3bbd2265
LMI
96632011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9664
9665 * editfns.c (Fdelete_region): Clarify the use of the named
9666 parameters (bug#6788).
9667
adc47434
MR
96682011-07-14 Martin Rudalics <rudalics@gmx.at>
9669
9670 * indent.c (Fvertical_motion): Set and restore w->pointm when
9671 saving and restoring the window's buffer (Bug#9006).
9672
837c31f8
LMI
96732011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9674
9675 * editfns.c (Fstring_to_char): Clarify just what is returned
9676 (bug#6576). Text by Eli Zaretskii.
9677
ac389d0c
JB
96782011-07-13 Juanma Barranquero <lekktu@gmail.com>
9679
9680 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9681
0be0ce47
EZ
96822011-07-13 Eli Zaretskii <eliz@gnu.org>
9683
9684 * buffer.c (mmap_find): Fix a typo.
9685
cd18e7e3
JB
96862011-07-13 Johan Bockgård <bojohan@gnu.org>
9687
9688 Fix execution of x selection hooks.
9689 * xselect.c (Qx_lost_selection_functions)
9690 (Qx_sent_selection_functions): New vars.
9691 (syms_of_xselect): DEFSYM them.
9692 (x_handle_selection_request): Pass Qx_sent_selection_functions
9693 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9694 (x_handle_selection_clear,x_clear_frame_selections):
9695 Pass Qx_lost_selection_functions rather than
9696 Vx_lost_selection_functions to Frun_hook_with_args.
9697
47ea7f44
PE
96982011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9699
ac389d0c 9700 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9701 The old code sometimes used this field without initializing it.
9702
47ea7f44
PE
9703 * alloc.c (gc_sweep): Don't read past end of array.
9704 In theory, the old code could also have corrupted Emacs internals,
9705 though it'd be very unlikely.
9706
bc985c87
AS
97072011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9708
9709 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9710 argument. (Bug#4026)
bc985c87 9711
0cf34688
LMI
97122011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9713
b3dadd76
LMI
9714 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9715 key" (bug#4257).
9716
0cf34688
LMI
9717 * window.c (Fset_window_start): Doc fix (bug#4199).
9718 (Fset_window_hscroll): Ditto.
9719
270768cd
PE
97202011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9721
077e3dda 9722 Fix minor new problems caught by GCC 4.6.1.
270768cd 9723 * term.c (init_tty): Remove unused local.
490011a6 9724 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9725 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9726 not used otherwise.
270768cd 9727
b1f58454
CY
97282011-07-12 Chong Yidong <cyd@stupidchicken.com>
9729
9730 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9731
22b9578d
LMI
97322011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9733
6e70ab07
LMI
9734 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9735 are the mini-buffer and the echo area (bug#3320).
9736
22b9578d
LMI
9737 * term.c (init_tty): Remove support for supdup, c10 and perq
9738 terminals, which are no longer supported (bug#1482).
9739
8974cc9f
JB
97402011-07-10 Johan Bockgård <bojohan@gnu.org>
9741
9742 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9743
a560d974
JD
97442011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9745
9746 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9747 for non-popups (Bug#3642).
9748
1dae0f0a
AS
97492011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9750
268c2c36 9751 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9752 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9753 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9754 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9755 * data.c (fmod): Likewise.
9756 * dispnew.c (swap_glyphs_in_rows): Likewise.
9757 * emacs.c (memory_warning_signal): Likewise.
9758 * floatfns.c (float_error): Likewise.
9759 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9760 (otf_open, font_otf_capability, generate_otf_features)
9761 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9762 Likewise.
9763 * image.c (pbm_read_file): Likewise.
9764 * indent.c (string_display_width): Likewise.
9765 * intervals.c (check_for_interval, search_for_interval)
9766 (inc_interval_count, count_intervals, root_interval)
9767 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9768 * lread.c (defalias): Likewise.
268c2c36 9769 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9770 * regex.c (set_image_of_range_1, set_image_of_range)
9771 (regex_grow_registers): Likewise.
9772 * sysdep.c (strerror): Likewise.
9773 * termcap.c (valid_filename_p, tprint, main): Likewise.
9774 * tparam.c (main): Likewise.
9775 * unexhp9k800.c (run_time_remap, save_data_space)
9776 (update_file_ptrs, read_header, write_header, calculate_checksum)
9777 (copy_file, copy_rest, display_header): Likewise.
9778 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9779 Likewise.
9780 * xdisp.c (check_it): Likewise.
9781 * xfaces.c (register_color, unregister_color, unregister_colors):
9782 Likewise.
9783 * xfns.c (print_fontset_result): Likewise.
9784 * xrdb.c (member, fatal, main): Likewise.
9785
99033785
PE
97862011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9787
9788 Fix minor problems found by static checking (Bug#9031).
9789 * chartab.c (char_table_set_range, map_sub_char_table):
9790 Remove unused locals.
9791 (uniprop_table): Now static.
9792 * composite.c (_work_char): Remove unused static var.
9793
9cb2ac56
JB
97942011-07-09 Juanma Barranquero <lekktu@gmail.com>
9795
9796 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9797
f25661f0
JD
97982011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9799
9800 * gtkutil.c (qttip_cb): Remove code without function.
9801
8278c4fe
EZ
98022011-07-09 Eli Zaretskii <eliz@gnu.org>
9803
9804 * w32.c (pthread_sigmask): New stub.
9805
1692ae2d 98062011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9807
8a6ebd58 9808 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9809 sigprocmask is portable only for single-threaded applications, and
9810 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9811 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9812 (LIBES): Use it.
9813 * callproc.c (Fcall_process):
9814 * process.c (create_process):
9815 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9816 Use pthread_sigmask, not sigprocmask.
123403e4 9817
1b854618
JD
98182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9819
9820 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9821 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9822 wrong (Bug#8591).
9823
3fe4b549
JD
98242011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9825
0ce7e563
JD
9826 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9827 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9828 (xg_hide_tooltip): Fix comment.
9829
3fe4b549
JD
9830 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9831 in registerServicesMenuSendTypes.
9832 (validRequestorForSendType): Don't check ns_return_types.
9833
9834 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9835 ns_return_type.
9836
5df75e47
JR
98372011-07-08 Jason Rumney <jasonr@gnu.org>
9838
22610910
JR
9839 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9840 SH_SHOW for hidden windows (Bug#5482).
9841
5df75e47
JR
9842 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9843 frame struct members of non-existent frames (Bug#6284).
9844
699c10bd
JD
98452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9846
4393663b
JD
9847 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9848 variable firstTime not needed on OSX >= 10.6.
9849 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9850 >= 10.5. Use setKnobProportion, setDoubleValue.
9851
9852 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9853 (MAC_OS_X_VERSION_10_5): Define if not defined.
9854 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9855 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9856 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9857
9858 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9859 cString and lossyCString on OSX >= 10.4.
4393663b 9860
58179cce 9861 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9862 sizeToFit on OSX >= 10.2.
9863
9864 * nsimage.m (allocInitFromFile): Don't use deprecated method
9865 bestRepresentationForDevice on OSX >= 10.6.
9866
9867 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9868 to avoid warning.
9869
9870 * emacs.c: Declare unexec_init_emacs_zone.
9871
a63e0781
JD
9872 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9873
699c10bd
JD
9874 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9875
9876 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9877 on svcsMenu (Bug#8842).
9878
9879 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9880 ns_return_types.
9881 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9882
9883 * nsterm.m (QUTF8_STRING): Declare.
9884 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9885 (validRequestorForSendType): Return type is (id).
9886 Change indexOfObjectIdenticalTo to indexOfObject.
9887 Check if we have local selection before returning self (Bug#8842).
9888 (writeSelectionToPasteboard): Put local selection into paste board
9889 if we have a local selection (Bug#8842).
9890 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9891
9892 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9893 (ns_get_local_selection): Declare.
9894
54e10184
LMI
98952011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9896
9888ff71
LMI
9897 * keymap.c (describe_map_tree): Don't insert a double newline at
9898 the end of the buffer (bug#1169) and return whether we inserted
9899 something.
9900
54e10184
LMI
9901 * callint.c (Fcall_interactively): Change "reading args" to
9902 "providing args" to try to clarify what it does (bug#1010).
9903
15fa4783
KH
99042011-07-07 Kenichi Handa <handa@m17n.org>
9905
9906 * composite.c (composition_compute_stop_pos): Ignore a static
9907 composition starting before CHARPOS (Bug#8915).
9908
9909 * xdisp.c (handle_composition_prop): Likewise.
9910
a8815b00
EZ
99112011-07-07 Eli Zaretskii <eliz@gnu.org>
9912
9913 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9914 (Bug#9015)
9915
ef7b981d 99162011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9917
9918 * character.h (unicode_category_t): New enum type.
9919
9920 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9921 (Qchar_code_property_table): New variable.
9922 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9923 (UNIPROP_COMPRESSED_FORM_P): New macros.
9924 (char_table_ascii): Uncompress the compressed values.
9925 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9926 Uncompress the compressed values.
ac389d0c 9927 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9928 (char_table_ref_and_range): Uncompress the compressed values.
9929 (sub_char_table_set): New arg is_uniprop. Callers changed.
9930 Uncompress the compressed values.
9931 (sub_char_table_set_range): Args changed. Callers changed.
9932 (char_table_set_range): Adjuted for the above change.
9933 (map_sub_char_table): Delete args default_val and parent. Add arg
9934 top. Give decoded values to a Lisp function.
640c8776 9935 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9936 values to a Lisp function. Gcpro more variables.
9937 (uniprop_table_uncompress)
9938 (uniprop_decode_value_run_length): New functions.
9939 (uniprop_decoder, uniprop_decoder_count): New variables.
9940 (uniprop_get_decoder, uniprop_encode_value_character)
9941 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9942 New functions.
9943 (uniprop_encoder, uniprop_encoder_count): New variables.
9944 (uniprop_get_encoder, uniprop_table)
9945 (Funicode_property_table_internal, Fget_unicode_property_internal)
9946 (Fput_unicode_property_internal): New functions.
9947 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9948 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9949 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9950 char-code-property-alist.
9951
640c8776 9952 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9953 Vunicode_category_table.
9954
640c8776 9955 * font.c (font_range): Adjust for the change of
c805dec0
KH
9956 Vunicode_category_table.
9957
76b397fb
DN
99582011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9959
9960 * m/iris4d.h: Remove file, move contents ...
9961 * s/irix6-5.h: ... here.
9962
22b4128e
PE
99632011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9964
9965 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9966 * alloc.c (mark_buffer):
9967 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9968 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9969 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9970 This isn't true in general, and it's particularly not true
9971 if Emacs is configured with --with-wide-int.
9972 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9973 New macros, used in the buffer.c change.
9974
869795d6
JD
99752011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9976
9977 * xsettings.c: Use both GConf and GSettings if both are available.
9978 (store_config_changed_event): Add comment.
9979 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9980 (store_tool_bar_style_changed): New functions.
5e617bc2 9981 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9982 (struct xsettings): Move font inside HAVE_XFT.
9983 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9984 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9985 Move inside HAVE_XFT.
640c8776 9986 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9987 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9988 also.
9989 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9990 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9991 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9992 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9993 (parse_settings): Move check for font inside HAVE_XFT.
9994 (read_settings, apply_xft_settings): Add comment.
9995 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9996 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9997 call store_font_name_changed.
9998 (xft_settings_event): Add comment.
9999 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10000 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10001 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10002 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10003 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10004 (xsettings_get_system_font, xsettings_get_system_normal_font):
10005 Add comment.
869795d6 10006
d8ed26bd
PE
100072011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10008
10009 Random fixes. E.g., (random) never returned negative values.
10010 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10011 subseconds part to the entropy, as that's a bit more random.
10012 Prefer signed to unsigned, since the signedness doesn't matter and
10013 in general we prefer signed. When given a limit, use a
10014 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10015 latter isn't right if USE_2_TAGS_FOR_INTS.
10016 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10017 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10018
cabf1cac
SM
100192011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10020
10021 * textprop.c (text_property_stickiness):
10022 Obey Vtext_property_default_nonsticky.
10023 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10024 * w32fns.c (syms_of_w32fns):
10025 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10026
6e9b2be9
PE
100272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10028
10029 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10030 This is more efficient than Ffile_directory_p and avoids a minor race.
10031
90186c68
LMI
100322011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10033
7c301272
LMI
10034 * buffer.c (Foverlay_put): Say what the return value is
10035 (bug#7835).
10036
c4f2d8d4
LMI
10037 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10038 is a directory before asking whether to use the file name
10039 (bug#7564).
ad637907
LMI
10040 (barf_or_query_if_file_exists): Make the "File is a directory"
10041 error be more correct.
c4f2d8d4 10042
90186c68
LMI
10043 * fns.c (Frequire): Remove the mention of the .gz files, since
10044 that's installation-specific, but keep the mention of
10045 `get-load-suffixes'.
10046
da64016e
PE
100472011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10048
10049 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10050 Report string overflow if the output is too long.
10051
7d47b580
JB
100522011-07-04 Juanma Barranquero <lekktu@gmail.com>
10053
a555cb87
JB
10054 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10055 (syms_of_gnutls): Remove duplicate DEFSYM for
10056 Qgnutls_bootprop_verify_hostname_error, an error for
10057 Qgnutls_bootprop_verify_error (which is no longer used).
10058
7d47b580
JB
10059 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10060 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10061 Also (re)move comments that are misplaced or no longer relevant.
10062
1e49bfab
LMI
100632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10064
10065 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10066
1485f4c0
CY
100672011-07-03 Chong Yidong <cyd@stupidchicken.com>
10068
10069 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10070 and background color parameters if they have been changed.
10071
a9ab721e
LMI
100722011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10073
10074 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10075
cf7cff57
PE
100762011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10077
2e13213d
PE
10078 * xsettings.c (SYSTEM_FONT): Define only when used.
10079 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10080
cf7cff57
PE
10081 * keymap.c (access_keymap_1): Now static.
10082
7a8e04f7
CY
100832011-07-02 Chong Yidong <cyd@stupidchicken.com>
10084
10085 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10086 leave any prefix arg for the up event (Bug#1586).
10087
61352f62
LMI
100882011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10089
69bb1ef7
LMI
10090 * lread.c (syms_of_lread): Mention single symbols defined by
10091 `defvar' or `defconst' (bug#7154).
10092
61352f62 10093 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10094 (Frequire): Mention get-load-suffixes.
61352f62 10095
28545e04
MR
100962011-07-02 Martin Rudalics <rudalics@gmx.at>
10097
10098 * window.h (window): Remove clone_number slot.
10099 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10100 Remove.
10101 (make_parent_window, make_window, saved_window)
10102 (Fset_window_configuration, save_window_save): Don't deal with
10103 clone numbers.
10104 * buffer.c (Qclone_number): Remove declaration.
10105 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10106
3349e122
SM
101072011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10108
10109 Add multiple inheritance to keymaps.
10110 * keymap.c (Fmake_composed_keymap): New function.
10111 (Fset_keymap_parent): Simplify.
10112 (fix_submap_inheritance): Remove.
10113 (access_keymap_1): New function extracted from access_keymap to handle
10114 embedded parents and handle lists of maps.
10115 (access_keymap): Use it.
10116 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10117 (Fcopy_keymap): Handle embedded parents.
10118 (Fcommand_remapping, define_as_prefix): Simplify.
10119 (Fkey_binding): Simplify.
10120 (syms_of_keymap): Move minibuffer-local-completion-map,
10121 minibuffer-local-filename-completion-map,
10122 minibuffer-local-must-match-map, and
10123 minibuffer-local-filename-must-match-map to Elisp.
10124 (syms_of_keymap): Defsubr make-composed-keymap.
10125 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10126 (parse_menu_item): Trivial simplification.
10127
3279eb87
GM
101282011-07-01 Glenn Morris <rgm@gnu.org>
10129
10130 * Makefile.in (SETTINGS_LIBS): Fix typo.
10131
39cb9e56 101322011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10133
10134 * coding.c (Fencode_coding_string): Record the last coding system
10135 used, as the function doc string says (bug#8738).
10136
0949d2b6
JD
101372011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10138
10139 * xsettings.c (store_monospaced_changed): Take new font as arg and
10140 check for change against current_mono_font.
10141 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10142 (emacs_settings_constructor, emacs_settings_get_property)
10143 (emacs_settings_set_property, emacs_settings_class_init)
10144 (emacs_settings_init, gsettings_obj): Remove.
10145 (something_changedCB): New function for HAVE_GSETTINGS.
10146 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10147 with value as argument.
10148 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10149 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10150 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10151 "changed".
10152
10153 * xgselect.c: Add defined (HAVE_GSETTINGS).
10154 (xgselect_initialize): Ditto.
10155
10156 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10157 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10158 xg_select.
10159
bbc6b304
PE
101602011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10161
10162 * eval.c (struct backtrace): Simplify and port the data structure.
10163 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10164 signed bit field, as this assumption is not portable and it makes
10165 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10166 "char debug_on_exit : 1" as this is not portable either; instead,
10167 use the portable "unsigned int debug_on_exit : 1". Remove unused
10168 member evalargs. Remove obsolete comments about cc bombing out.
10169
9851bfc5
JD
101702011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10171
51bb811f 10172 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10173 Let HAVE_GSETTINGS override HAVE_GCONF.
10174 (store_monospaced_changed): New function.
10175 (EMACS_SETTINGS): A new type derived from GObject to handle
10176 GSettings notifications.
10177 (emacs_settings_constructor, emacs_settings_get_property)
10178 (emacs_settings_set_property, emacs_settings_class_init):
10179 New functions.
10180 (gsettings_client, gsettings_obj): New variables.
10181 (GSETTINGS_SCHEMA): New define.
10182 (something_changedCB): Call store_monospaced_changed.
10183 (init_gsettings): New function.
10184 (xsettings_initialize): Call init_gsettings.
10185 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10186 to NULL.
10187
640c8776 10188 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10189 GCONF_CFLAGS/LIBS.
10190
5386012d
MR
101912011-06-29 Martin Rudalics <rudalics@gmx.at>
10192
10193 * window.c (resize_root_window, grow_mini_window)
10194 (shrink_mini_window): Rename Qresize_root_window to
10195 Qwindow_resize_root_window and Qresize_root_window_vertically to
10196 Qwindow_resize_root_window_vertically.
10197
f13e0b08
PE
101982011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10199
10200 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10201
94515237
JB
102022011-06-27 Juanma Barranquero <lekktu@gmail.com>
10203
10204 * makefile.w32-in: Redesign dependencies so they reflect more
10205 clearly which files are directly included by each source file,
10206 and not through other includes.
10207
e43b6e43
MR
102082011-06-27 Martin Rudalics <rudalics@gmx.at>
10209
10210 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10211 (sort_overlays, overlay_strings): When an overlay's clone number
10212 matches the window's clone number process the overlay even if
10213 the overlay's window property doesn't match the current window.
10214
d68443dc
MR
10215 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10216 (Fwindow_hchild): Rename to Fwindow_left_child.
10217 (Fwindow_next): Rename to Fwindow_next_sibling.
10218 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10219 (resize_window_check): Rename to window_resize_check.
10220 (resize_window_apply): Rename to window_resize_apply.
10221 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10222 (Fdelete_other_windows_internal, resize_frame_windows)
10223 (Fsplit_window_internal, Fdelete_window_internal)
10224 (grow_mini_window, shrink_mini_window)
10225 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10226
c7e73be5
JD
102272011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10228
10229 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10230 (emacs_fixed_set_min_size): Remove.
10231 (emacs_fixed_new): Take frame as argument.
10232
10233 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10234 (_EmacsFixedPrivate): Remove minwidth/height.
10235 Add struct frame *f.
10236 (emacs_fixed_init): Initialize priv->f.
10237 (get_parent_class, emacs_fixed_set_min_size): Remove.
10238 (emacs_fixed_new): Set priv->f to argument.
10239 (emacs_fixed_get_preferred_width)
10240 (emacs_fixed_get_preferred_height): Use min_width/height from
10241 frames size_hint to set minimum and natural (Bug#8919).
10242 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10243 and use min_width/height from frames size_hint to set
10244 min_width/height (Bug#8919).
10245
10246 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10247 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10248 Fix indentation.
c7e73be5 10249
cf99dcf8
EZ
102502011-06-26 Eli Zaretskii <eliz@gnu.org>
10251
10252 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10253 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10254 called at ZV.
10255
029529ac
CY
102562011-06-26 Chong Yidong <cyd@stupidchicken.com>
10257
10258 * process.c (wait_reading_process_output): Bypass select if
10259 waiting for a cell while ignoring keyboard input, and input is
10260 pending. Suggested by Jan Djärv (Bug#8869).
10261
7a7ef429
PE
102622011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10263
10264 Use gnulib's dup2 module instead of rolling our own.
10265 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10266
11fdef7d 102672011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10268
10269 * dispnew.c (scrolling_window): Before scrolling, turn off a
10270 mouse-highlight in the window being scrolled.
10271
cd3520a4
JB
102722011-06-24 Juanma Barranquero <lekktu@gmail.com>
10273
10274 Move DEFSYM to lisp.h and use everywhere.
10275
10276 * character.h (DEFSYM): Move declaration...
10277 * lisp.h (DEFSYM): ...here.
10278
10279 * gnutls.c:
10280 * minibuf.c:
10281 * w32menu.c:
10282 * w32proc.c:
10283 * w32select.c: Don't include character.h.
10284
10285 * alloc.c (syms_of_alloc):
10286 * buffer.c (syms_of_buffer):
10287 * bytecode.c (syms_of_bytecode):
10288 * callint.c (syms_of_callint):
10289 * casefiddle.c (syms_of_casefiddle):
10290 * casetab.c (init_casetab_once):
10291 * category.c (init_category_once, syms_of_category):
10292 * ccl.c (syms_of_ccl):
10293 * cmds.c (syms_of_cmds):
10294 * composite.c (syms_of_composite):
10295 * dbusbind.c (syms_of_dbusbind):
10296 * dired.c (syms_of_dired):
10297 * dispnew.c (syms_of_display):
10298 * doc.c (syms_of_doc):
10299 * editfns.c (syms_of_editfns):
10300 * emacs.c (syms_of_emacs):
10301 * eval.c (syms_of_eval):
10302 * fileio.c (syms_of_fileio):
10303 * fns.c (syms_of_fns):
10304 * frame.c (syms_of_frame):
10305 * fringe.c (syms_of_fringe):
10306 * insdel.c (syms_of_insdel):
10307 * keymap.c (syms_of_keymap):
10308 * lread.c (init_obarray, syms_of_lread):
10309 * macros.c (syms_of_macros):
10310 * msdos.c (syms_of_msdos):
10311 * print.c (syms_of_print):
10312 * process.c (syms_of_process):
10313 * search.c (syms_of_search):
10314 * sound.c (syms_of_sound):
10315 * syntax.c (init_syntax_once, syms_of_syntax):
10316 * terminal.c (syms_of_terminal):
10317 * textprop.c (syms_of_textprop):
10318 * undo.c (syms_of_undo):
10319 * w32.c (globals_of_w32):
10320 * window.c (syms_of_window):
10321 * xdisp.c (syms_of_xdisp):
10322 * xfaces.c (syms_of_xfaces):
10323 * xfns.c (syms_of_xfns):
10324 * xmenu.c (syms_of_xmenu):
10325 * xsettings.c (syms_of_xsettings):
10326 * xterm.c (syms_of_xterm): Use DEFSYM.
10327
4228cf16
TZ
103282011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10329
cd3520a4 10330 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10331
7fcccf1e
PE
103322011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10333
7efb4e0e
PE
10334 Integer and buffer overflow fixes (Bug#8873).
10335
ff5844ad
PE
10336 * print.c (printchar, strout): Check for string overflow.
10337 (PRINTPREPARE, printchar, strout):
10338 Don't set size unless allocation succeeds.
10339
90532f02
PE
10340 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10341 for sizes. Check for string overflow more accurately.
10342 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10343
6d84508d
PE
10344 * macros.c: Integer and buffer overflow fixes.
10345 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10346 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10347 Use ptrdiff_t, not int, for sizes.
10348 Don't increment bufsize until after realloc succeeds.
10349 Check for size-calculation overflow.
10350 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10351
437b2cb4
PE
10352 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10353
8b9ac8b4
PE
10354 * lread.c: Integer overflow fixes.
10355 (read_integer): Radix is now EMACS_INT, not int,
10356 to improve quality of diagnostics for out-of-range radices.
10357 Calculate buffer size correctly for out-of-range radices.
10358 (read1): Check for integer overflow in radices, and in
10359 read-circle numbers.
82cb60d3
PE
10360 (read_escape): Avoid int overflow.
10361 (Fload, openp, read_buffer_size, read1)
10362 (substitute_object_recurse, read_vector, read_list, map_obarray):
10363 Use ptrdiff_t, not int, for sizes.
10364 (read1): Use EMACS_INT, not int, for sizes.
20270765 10365 Check for size overflow.
8b9ac8b4 10366
7fcccf1e
PE
10367 * image.c (cache_image): Check for size arithmetic overflow.
10368
bfbbd7e7
PE
10369 * lread.c: Integer overflow issues.
10370 (saved_doc_string_size, saved_doc_string_length)
10371 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10372 Now ptrdiff_t, not int.
10373 (read1): Don't assume doc string length fits in int. Check for
10374 out-of-range doc string lengths.
10375 (read_list): Don't assume file position fits in int.
39019e54 10376 (read_escape): Check for hex character overflow.
bfbbd7e7 10377
4e323265
LL
103782011-06-22 Leo Liu <sdl.web@gmail.com>
10379
10380 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10381 Move to minibuffer.el.
10382
85fece3e
PE
103832011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10384
20b84ce9 10385 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10386 The following patches are for when GLYPH_DEBUG && !XASSERT.
10387 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10388 * dispnew.c (flush_stdout):
10389 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10390 Mark as externally visible.
10391 * dispnew.c (check_window_matrix_pointers): Now static.
10392 * dispnew.c (window_to_frame_vpos):
10393 * xfns.c (unwind_create_frame):
10394 * xterm.c (x_check_font): Remove unused local.
10395 * scroll.c (CHECK_BOUNDS):
10396 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10397 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10398 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10399 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10400 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10401 Now static.
10402 (debug_method_add): Use va_list and vsprintf rather than relying
10403 on undefined behavior with wrong number of arguments.
10404 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10405 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10406 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10407 since we're not interested in debugging glyphs with old libraries.
10408 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10409 GCC 4.6.0's static checking.
10410
0766b489
PE
104112011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10412
31fd4b32
PE
10413 Integer overflow and signedness fixes (Bug#8873).
10414 A few related buffer overrun fixes, too.
10415
b79e8648
PE
10416 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10417
0766b489
PE
10418 * dispextern.h (struct face.stipple):
10419 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10420 (x_bitmap_mask, x_allocate_bitmap_record)
10421 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10422 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10423 (x_create_bitmap_from_xpm_data):
10424 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10425 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10426 (.bitmaps_last):
10427 * xfaces.c (load_pixmap):
10428 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10429 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10430 (.bitmaps_last, struct x_output.icon_bitmap):
10431 Use ptrdiff_t, not int, for bitmap indexes.
10432 (x_allocate_bitmap_record): Check for size overflow.
10433 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10434
b081724f
PE
10435 Use ptrdiff_t, not int, for overlay counts.
10436 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10437 * editfns.c (overlays_around, get_pos_property):
10438 * textprop.c (get_char_property_and_overlay):
10439 * xdisp.c (next_overlay_change, note_mouse_highlight):
10440 * xfaces.c (face_at_buffer_position):
21514da7
PE
10441 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10442 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10443 (Fnext_overlay_change, Fprevious_overlay_change)
10444 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10445 Use ptrdiff_t, not int, for sizes.
21514da7 10446 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10447
3de73e5e
PE
10448 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10449
2606c57b
PE
10450 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10451 (x_session_initialize): Do not assume string length fits in int.
10452
aaafe47a
PE
10453 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10454 This is unlikely, but can occur if DPI is outlandish.
10455
2674ddc8 10456 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10457 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10458
28154962
PE
10459 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10460 * xrdb.c (magic_file_p, search_magic_path):
10461 Omit last arg SUFFIX; it was always 0. All callers changed.
10462 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10463
7de51af5
PE
10464 * xfont.c (xfont_match): Avoid need for strlen.
10465
25ed6cc3
PE
10466 * xfns.c: Don't assume strlen fits in int.
10467 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10468
4eab31dd
PE
10469 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10470 not unsigned long, as we prefer signed integers. All callers changed.
10471 Detect integer overflow in repeat count.
10472 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10473 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10474
171e2a58
PE
10475 * termcap.c: Don't assume sizes fit in int and never overflow.
10476 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10477 (gobble_line): Check for size-calculation overflow.
10478
ad39faca 10479 * minibuf.c (Fread_buffer):
6e5bb2dc 10480 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10481 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10482 Don't assume string length fits in int.
10483
52c61c22 10484 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10485 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10486
b5b8c9e5
PE
10487 * font.c: Don't assume string length fits in int.
10488 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10489 Use ptrdiff_t, not int.
ccd6111c
PE
10490 (font_intern_prop): Don't assume string length fits in int.
10491 Don't assume integer property fits in fixnum.
10492 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10493
882f0d81 10494 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10495 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10496 Reformulate so as not to need the command string.
10497 Invoke gzip -cd rather than gunzip, as it's more portable.
10498 (lock_info_type, lock_file_1, lock_file):
10499 Don't assume pid_t and time_t fit in unsigned long.
10500 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10501 (current_lock_owner): Prefer signed type for sizes.
10502 Use memcpy, not strncpy, where memcpy is what is really wanted.
10503 Don't assume (via atoi) that time_t and pid_t fit in int.
10504 Check for time_t and/or pid_t out of range, e.g., via a network share.
10505 Don't alloca where an auto var works fine.
10506
93f4cf88
PE
10507 * fileio.c: Fix some integer overflow issues.
10508 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10509 Don't assume string length fits in int.
10510 (directory_file_name): Don't assume string length fits in long.
10511 (make_temp_name): Don't assume pid fits in int, or that its print
10512 length is less than 20.
10513
f3e92b69
PE
10514 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10515
1bfdaf10
PE
10516 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10517
35016e9a
PE
10518 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10519
3d1e65a1
PE
10520 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10521 We prefer signed integers, even for size calculations.
10522
0b963a93
PE
10523 * emacs.c: Don't assume string length fits in 'int'.
10524 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10525 (main): Don't invoke strlen when not needed.
10526
573f4b54
PE
10527 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10528 (XD_DEBUG_MESSAGE): Don't waste a byte.
10529
989f33ba
PE
10530 * callproc.c (getenv_internal_1, getenv_internal)
10531 (Fgetenv_internal):
965d34eb
PE
10532 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10533
e4d29b33
PE
10534 * lread.c (invalid_syntax): Omit length argument.
10535 All uses changed. This doesn't fix a bug, but it simplifies the
10536 code away from its former Hollerith-constant appearance, and it's
10537 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10538 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10539
eb49b136
PE
10540 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10541 This didn't break anything, but it didn't help either.
10542 It's confusing to put a bogus integer in a place where the actual
10543 value does not matter.
9f62aeb1 10544 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10545 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10546
15375a22
PE
10547 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10548 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10549 implementation.
b61cc01c
PE
10550 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10551 We prefer signed types, and the value cannot exceed the EMACS_INT
10552 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10553 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10554 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10555 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10556
53b2623d
PE
10557 * indent.c (sane_tab_width): New function.
10558 (current_column, scan_for_column, Findent_to, position_indentation)
10559 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10560 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10561
51cab52b 10562 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10563
f2ed8a70
PE
10564 * lisp.h (lint_assume): New macro.
10565 * composite.c (composition_gstring_put_cache):
10566 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10567
abe80cc6
PE
10568 * editfns.c, insdel.c:
10569 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10570
b02c740e
PE
10571 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10572
ebc96716
PE
10573 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10574
b4e50fa0 10575 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10576 Use much-faster test for byte-length change.
311d5d7c 10577 Don't assume string byte-length fits in 'int'.
a4cf38e4 10578 Check that character arg fits in 'int'.
85461888 10579 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10580
c0c1ee9f
PE
10581 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10582
a498d7f4
PE
10583 * fns.c (concat): Catch string overflow earlier.
10584 Do not rely on integer wraparound.
10585
51cab52b
PE
10586 * dispextern.h (struct it.overlay_strings_charpos)
10587 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10588 * xdisp.c (forward_to_next_line_start)
10589 (back_to_previous_visible_line_start)
10590 (reseat_at_next_visible_line_start, next_element_from_buffer):
10591 Don't arbitrarily truncate the value of 'selective' to int.
10592
76031fad
PE
10593 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10594
5eb55db9
PE
10595 * composite.c: Don't truncate sizes to 'int'.
10596 (composition_gstring_p, composition_reseat_it)
10597 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10598 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10599 not EMACS_UINT, for indexes.
5eb55db9 10600
0703a717
PE
10601 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10602
d6202519
PE
10603 * buffer.c: Include <verify.h>.
10604 (struct sortvec.priority, struct sortstr.priority):
8961a454 10605 Now EMACS_INT, not int.
c20998a7 10606 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10607 (struct sortstr.size, record_overlay_string)
10608 (struct sortstrlist.size, struct sortlist.used):
10609 Don't truncate size to int.
10610 (record_overlay_string): Check for size-calculation overflow.
d6202519 10611 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10612
d5a19415
JM
106132011-06-22 Jim Meyering <meyering@redhat.com>
10614
029529ac 10615 Don't leak an XBM-image-sized buffer
d5a19415
JM
10616 * image.c (xbm_load): Free the image buffer after using it.
10617
a9041e6c
PE
106182011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10619
10620 Port to Sun C.
10621 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10622 that Sun C diagnosed.
10623 * fns.c (secure_hash): Fix pointer signedness issue.
10624 * intervals.c (static_offset_intervals): New function.
10625 (offset_intervals): Use it.
10626
7f3f739f
LL
106272011-06-21 Leo Liu <sdl.web@gmail.com>
10628
10629 * deps.mk (fns.o):
10630 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10631 sha512.h.
10632
10633 * fns.c (secure_hash): Rename from crypto_hash_function and change
10634 the first arg to accept symbols.
5b66d427 10635 (Fsecure_hash): New primitive.
7f3f739f
LL
10636 (syms_of_fns): New symbols.
10637
76147d94
DD
106382011-06-20 Deniz Dogan <deniz@dogan.se>
10639
10640 * process.c (Fset_process_buffer): Clarify return value in
10641 docstring.
10642
7d7d0045
CY
106432011-06-18 Chong Yidong <cyd@stupidchicken.com>
10644
10645 * dispnew.c (add_window_display_history): Use BVAR.
10646
10647 * xdisp.c (debug_method_add): Use BVAR.
10648 (check_window_end, dump_glyph_matrix, dump_glyph)
10649 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10650
10651 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10652 Likewise.
10653
10654 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10655 check till after the cache is created in init_frame_faces.
10656
ff2bc410
SM
106572011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10658
10659 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10660
28177add
PE
106612011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10662
dd3482fe
PE
10663 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10664 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10665 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10666
393d71f3 10667 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10668 * fileio.c (Finsert_file_contents):
10669 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10670 Remove the old (too-loose) buffer overflow checks.
10671 They weren't needed, since make_gap checks for buffer overflow.
10672 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10673 The old code merely checked for Emacs fixnum overflow, and relied
10674 on undefined (wraparound) behavior. The new code avoids undefined
10675 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10676
2e6813b0 10677 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10678 Tune. Don't use wider integers than needed. Don't use alloca.
10679 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10680
599a9e4f
PE
10681 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10682
99561444
PE
10683 * insdel.c, lisp.h (buffer_overflow): New function.
10684 (insert_from_buffer_1, replace_range, replace_range_2):
10685 * insdel.c (make_gap_larger):
10686 * editfns.c (Finsert_char):
10687 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10688
28177add
PE
10689 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10690
e69dafad
PE
106912011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10692
4baa020d 10693 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10694
b1c46f02
PE
10695 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10696 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10697
e69dafad
PE
10698 * fileio.c: Don't assume EMACS_INT fits in off_t.
10699 (emacs_lseek): New static function.
10700 (Finsert_file_contents, Fwrite_region): Use it.
10701 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10702
566684ea
PE
10703 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10704
e6966cd6
PE
10705 * fns.c: Don't overflow int when computing a list length.
10706 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10707 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10708 truncation on 64-bit hosts. Check for QUIT every
10709 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10710 faster and is responsive enough.
10711 (Flength): Report an error instead of overflowing an integer.
10712 (Fsafe_length): Return a float if the value is not representable
10713 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10714 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10715 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10716
dd0b0efb
PE
10717 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10718 (header_size, word_size): New constants.
10719 (allocate_vectorlike): Don't check size overflow here.
10720 (allocate_vector): Check it here instead, since this is the only
10721 caller of allocate_vectorlike that could cause overflow.
10722 Check that the new vector's length is representable as a fixnum.
10723
86fe5cfe
PE
10724 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10725 The previous code was bogus. For example, next_almost_prime (32)
10726 returned 39, which is undesirable as it is a multiple of 3; and
10727 next_almost_prime (24) returned 25, which is a multiple of 5 so
10728 why was the code bothering to check for multiples of 7?
10729
80e88859
PE
10730 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10731
4a2f0ad6
PE
10732 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10733
f66c7cf8
PE
10734 Variadic C functions now count arguments with ptrdiff_t.
10735 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10736 Back then I didn't know that the Emacs coding style prefers signed int.
10737 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10738 were being counted with int, which may truncate counts on 64-bit
10739 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10740 * lisp.h (struct Lisp_Subr.function.aMANY)
10741 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10742 Arg counts are now ptrdiff_t, not size_t.
10743 All variadic functions and their callers changed accordingly.
10744 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10745 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10746 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10747 * callint.c (Fcall_interactively): Check arg count for overflow,
10748 to avoid potential buffer overrun. Use signed char, not 'int',
10749 for 'varies' array, so that we needn't bother to check its size
10750 calculation for overflow.
10751 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10752 * eval.c (apply_lambda):
10753 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10754 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10755 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10756
a1759b76
PE
10757 * callint.c (Fcall_interactively): Don't use index var as event count.
10758
d96be9fc
PE
10759 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10760 * mem-limits.h (SIZE): Remove; no longer used.
10761
a690a978 10762 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10763
578c21e6
PE
10764 Remove unnecessary casts.
10765 * xterm.c (x_term_init):
10766 * xfns.c (x_set_border_pixel):
10767 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10768 These aren't needed now that we assume ANSI C.
10769
96f53c6c
PE
10770 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10771 It's more likely to cause problems (due to unsigned overflow)
10772 than to cure them.
10773
83c77d31
PE
10774 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10775
ee2079f1
PE
10776 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10777
6da65536
PE
10778 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10779
7147c4a4
PE
10780 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10781
193e32d9
PE
10782 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10783
e5533da6
PE
10784 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10785
9910e595
PE
10786 GLYPH_CODE_FACE returns EMACS_INT, not int.
10787 * dispextern.h (merge_faces):
10788 * xfaces.c (merge_faces):
01103c44
PE
10789 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10790 Don't assume EMACS_INT fits in int.
9910e595 10791
2638320e
PE
10792 * character.h (CHAR_VALID_P): Remove unused parameter.
10793 * fontset.c, lisp.h, xdisp.c: All uses changed.
10794
045eb8d9
PE
10795 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10796
c1f134b5
PE
10797 * fns.c (concat): Minor tuning based on overflow analysis.
10798 This doesn't fix any bugs. Use int to hold character, instead
10799 of constantly refetching from Emacs object. Use XFASTINT, not
10800 XINT, for value known to be a character. Don't bother comparing
10801 a single byte to 0400, as it's always less.
10802
395fcb93 10803 * floatfns.c (Fexpt):
327eeec8
PE
10804 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10805
abbd3d23
PE
10806 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10807 for characters.
10808
684a03ef
PE
10809 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10810
0fed43f3
PE
10811 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10812 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10813 incorrectly succeed when S was a string, because 4294967386 was
10814 truncated before it was used.
10815
8fd02eb7
PE
10816 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10817 Otherwise, an out-of-range integer could cause undefined behavior
10818 on a 64-bit host.
10819
f8c86b69
PE
10820 * composite.c: Use int, not EMACS_INT, for characters.
10821 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10822 EMACS_INT, for values that are known to be in character range.
10823 This doesn't fix any bugs but is the usual style inside Emacs and
10824 may generate better code on 32-bit machines.
10825
34206dd2
PE
10826 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10827 This is for reasons similar to the recent CHAR_STRING fix.
10828 * charset.c (Fencode_char): Check that character arg is actually
10829 a character. Pass an int to ENCODE_CHAR.
10830 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10831 wider than 'int', as a compile-time check to prevent future regressions
10832 in this area.
10833
c5958d4c 10834 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10835
10836 Make sure a 64-bit char is never passed to CHAR_STRING.
10837 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10838 by silently ignoring the top 32 bits, allowing some values
10839 that were far too large to be valid characters.
10840 * character.h: Include <verify.h>.
10841 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10842 arguments are no wider than unsigned, as a compile-time check
10843 to prevent future regressions in this area.
10844 * data.c (Faset):
01103c44 10845 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10846 (Fsubst_char_in_region):
10847 * fns.c (concat):
10848 * xdisp.c (decode_mode_spec_coding):
10849 Adjust to CHAR_STRING's new requirement.
10850 * editfns.c (Finsert_char, Fsubst_char_in_region):
10851 * fns.c (concat): Check that character args are actually
10852 characters. Without this test, these functions did the wrong
10853 thing with wildly out-of-range values on 64-bit hosts.
10854
d37ca623
PE
10855 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10856 These casts should not be needed on 32-bit hosts, either.
10857 * keyboard.c (read_char):
10858 * lread.c (Fload): Remove casts to unsigned.
10859
ea204efb
PE
10860 * lisp.h (UNSIGNED_CMP): New macro.
10861 This fixes comparison bugs on 64-bit hosts.
10862 (ASCII_CHAR_P): Use it.
10863 * casefiddle.c (casify_object):
01103c44 10864 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10865 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10866 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10867 * dispextern.h (FACE_FROM_ID):
10868 * keyboard.c (read_char): Use UNSIGNED_CMP.
10869
41cb286c
PE
10870 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10871 not to EMACS_INT, to avoid GCC warning.
10872
4a1b9832
PE
10873 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10874
55daad71
PE
10875 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10876 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10877 isn't needed on 32-bit machines.
8f95c75c 10878
01103c44
PE
10879 * buffer.c (Fgenerate_new_buffer_name):
10880 Use EMACS_INT for count, not int.
0ceccced 10881 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10882
10883 * data.c (Qcompiled_function): Now static.
10884
c6f072e7
PE
10885 * window.c (window_body_lines): Now static.
10886
20ce5912
PE
10887 * image.c (gif_load): Rename local to avoid shadowing.
10888
9c4c5f81
PE
10889 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10890 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10891 * alloc.c (make_save_value): Integer argument is now of type
10892 ptrdiff_t, not int.
10893 (mark_object): Use ptrdiff_t, not int.
10894 * lisp.h (pD): New macro.
10895 * print.c (print_object): Use it.
10896
c0c5c8ae
PE
10897 * alloc.c: Use EMACS_INT, not int, to count objects.
10898 (total_conses, total_markers, total_symbols, total_vector_size)
10899 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10900 (total_free_floats, total_floats, total_free_intervals)
10901 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10902 Now EMACS_INT, not int. All uses changed.
10903 (Fgarbage_collect): Compute overall total using a double, so that
10904 integer overflow is less likely to be a problem. Check for overflow
10905 when converting back to an integer.
5a25e253
PE
10906 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10907 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10908 These were 'int' variables that could overflow on 64-bit hosts;
10909 they were never used, so remove them instead of repairing them.
211a0b2a 10910 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10911 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10912 Previously, this ceilinged at INT_MAX, but that doesn't work on
10913 64-bit machines.
e46bb31a 10914 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10915
c78baabf 10916 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10917 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10918 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10919 when a (possibly-narrower) signed value would do just as well.
10920 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10921
c9d624c6
PE
10922 * alloc.c: Catch some string size overflows that we were missing.
10923 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10924 for convenience in STRING_BYTES_MAX.
10925 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10926 The definition here is exact; the one in lisp.h was approximate.
10927 (allocate_string_data): Check for string overflow. This catches
10928 some instances we weren't catching before. Also, it catches
10929 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10930 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10931 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10932
c9d624c6
PE
10933 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10934 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10935 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10936
353032ce
PE
10937 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10938
2bccce07
PE
10939 * alloc.c (Fmake_string): Check for out-of-range init.
10940
0ac30604
SM
109412011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10942
10943 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10944
c195f2de
JD
109452011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10946
10947 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10948 xg_get_default_scrollbar_width.
10949
10950 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10951 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10952 (style_changed_cb): Call update_theme_scrollbar_width and call
10953 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10954 all frames (Bug#8505).
10955 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10956 Call gtk_window_set_resizable if HAVE_GTK3.
10957 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10958 and height if HAVE_GTK3 (Bug#8505).
10959 (scroll_bar_width_for_theme): New variable.
10960 (update_theme_scrollbar_width): New function.
10961 (xg_get_default_scrollbar_width): Move code to
10962 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10963 (xg_initialize): Call update_theme_scrollbar_width.
10964
10965 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10966
10967 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10968
e10ac9f1
MR
109692011-06-12 Martin Rudalics <rudalics@gmx.at>
10970
10971 * frame.c (make_frame): Call other_buffer_safely instead of
10972 other_buffer.
10973
10974 * window.c (temp_output_buffer_show): Call display_buffer with
10975 second argument Vtemp_buffer_show_specifiers and reset latter
10976 immediately after the call.
10977 (Vtemp_buffer_show_specifiers): New variable.
10978 (auto_window_vscroll_p, next_screen_context_lines)
10979 (Vscroll_preserve_screen_position): Remove leading asterisks from
10980 doc-strings.
10981
2d3c217e 109822011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10983
7b7f97e8 10984 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10985 * buffer.c (Qclone_number): Remove for now, as it's unused.
10986 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10987 (record_buffer): Remove unused local.
10988 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10989 (set_frame_buffer_list): Remove; unused.
10990 * frame.h (other_visible_frames): Remove decl.
10991 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10992 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10993 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10994 if HAVE_GPM.
10995 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10996 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10997 Define only if HAVE_GPM.
10998 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10999 (update_hints_inhibit): Remove; never set. All uses removed.
11000 * widgetprv.h (emacsFrameClassRec): Remove decl.
11001 * window.c (delete_deletable_window): Now returns void, since it
11002 wasn't returning anything.
11003 (compare_window_configurations): Remove unused locals.
11004 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11005 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11006 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11007 the same widths as pointers. This follows up on the 2011-05-06 patch.
11008 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11009 * xterm.h: Likewise.
11010 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11011
1384b89e
JB
110122011-06-12 Juanma Barranquero <lekktu@gmail.com>
11013
11014 * makefile.w32-in: Update dependencies.
11015 (LISP_H): Add lib/intprops.h.
11016
1100a63c
CY
110172011-06-11 Chong Yidong <cyd@stupidchicken.com>
11018
11019 * image.c (gif_load): Add animation frame delay to the metadata.
11020 (syms_of_image): Use DEFSYM. New symbol `delay'.
11021
6198ccd0
MR
110222011-06-11 Martin Rudalics <rudalics@gmx.at>
11023
11024 * window.c (delete_deletable_window): Re-add.
11025 (Fset_window_configuration): Rewrite to handle dead buffers and
11026 consequently deletable windows.
11027 (window_tree, Fwindow_tree): Remove. Supply functionality in
11028 window.el.
11029 (compare_window_configurations): Simplify code.
11030
b6e3633c
AS
110312011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11032
1ab0dee5
AS
11033 * image.c (imagemagick_load_image): Fix type mismatch.
11034 (Fimagemagick_types): Likewise.
11035
b6e3633c
AS
11036 * window.h (replace_buffer_in_windows): Declare.
11037
9397e56f
MR
110382011-06-11 Martin Rudalics <rudalics@gmx.at>
11039
11040 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11041 Qclone_number. Remove external declaration of Qdelete_window.
11042 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11043 code.
640c8776
SM
11044 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11045 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11046 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11047 buffer list implementation.
11048 (other_buffer_safely): New function.
11049 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11050 calls to replace_buffer_in_windows and
11051 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11052 if allowed.
11053 (record_buffer): Inhibit quitting and rewrite using quittable
11054 functions. Run Qbuffer_list_update_hook if allowed.
11055 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11056 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11057 Move switch-to-buffer to window.el.
9397e56f
MR
11058 (bury-buffer): Move to window.el.
11059 (Vbuffer_list_update_hook): New variable.
11060
11061 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11062 section.
11063
11064 * window.h (resize_frame_windows): Move up in code.
11065 (Fwindow_frame): Remove EXFUN.
11066 (replace_buffer_in_all_windows): Remove prototype.
11067 (replace_buffer_in_windows_safely): Add prototype.
11068
11069 * window.c: Declare Qdelete_window static again. Move down
11070 declaration of select_count.
11071 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11072 (Fother_window): Move to window.el.
11073 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11074 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11075 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11076 window.el.
11077 (replace_buffer_in_windows): Implement by calling
11078 Qreplace_buffer_in_windows.
11079 (replace_buffer_in_all_windows): Remove with some functionality
11080 moved into replace_buffer_in_windows_safely.
11081 (replace_buffer_in_windows_safely): New function.
11082 (select_window_norecord, select_frame_norecord): Move in front
11083 of run_window_configuration_change_hook. Remove now obsolete
11084 declarations.
640c8776
SM
11085 (Fset_window_buffer): Rewrite doc-string.
11086 Call Qrecord_window_buffer.
9397e56f
MR
11087 (keys_of_window): Move binding for other-window to window.el.
11088
b50691aa
CY
110892011-06-11 Chong Yidong <cyd@stupidchicken.com>
11090
11091 * dispextern.h (struct image): Replace data member, whose int_val
11092 and ptr_val fields were not used by anything, with a single
11093 lisp_val object.
11094
11095 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11096 (gif_clear_image, gif_load, imagemagick_load_image)
11097 (gs_clear_image, gs_load): Callers changed.
11098
3f754b86
PE
110992011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11100
cca69397
PE
11101 * buffer.h: Include <time.h>, for time_t.
11102 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11103
109e28d0
PE
11104 Fix minor problems found by static checking.
11105
60737f02
PE
11106 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11107
4b66faf3
PE
11108 Make identifiers static if they are not used in other modules.
11109 * data.c (Qcompiled_function, Qframe, Qvector):
11110 * image.c (QimageMagick, Qsvg):
11111 * minibuf.c (Qmetadata):
11112 * window.c (resize_window_check, resize_root_window): Now static.
11113 * window.h (resize_window_check, resize_root_window): Remove decls.
11114
109e28d0
PE
11115 * window.c (window_deletion_count, delete_deletable_window):
11116 Remove; unused.
46a4ce9e
PE
11117 (window_body_lines): Now static.
11118 (Fdelete_other_windows_internal): Mark vars as initialized.
11119 Make sure 'resize_failed' is initialized.
11120 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11121 (resize_window_apply): Remove unused local.
11122 * window.h (delete_deletable_window): Remove decl.
11123
109e28d0 11124 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11125 (imagemagick_load_image): Fix pointer signedness problem by changing
11126 last arg from unsigned char * to char *. All uses changed.
11127 Also, fix a local for similar reasons.
11128 Remove unused locals. Remove locals to avoid shadowing.
11129 (fn_rsvg_handle_free): Remove; unused.
11130 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11131 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11132
3f754b86
PE
11133 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11134
2547adb1
CY
111352011-06-10 Chong Yidong <cyd@stupidchicken.com>
11136
11137 * image.c (gif_load): Fix omitted cast error introduced by
11138 2011-06-06 change.
11139
2c8e37d4
MR
111402011-06-10 Martin Rudalics <rudalics@gmx.at>
11141
11142 * window.h (resize_proportionally, orig_total_lines)
11143 (orig_top_line): Remove from window structure.
11144 (set_window_height, set_window_width, change_window_heights)
11145 (Fdelete_window): Remove prototypes.
11146 (resize_frame_windows): Remove duplicate declaration.
11147
440a42e3
EZ
111482011-06-10 Eli Zaretskii <eliz@gnu.org>
11149
11150 * window.h (resize_frame_windows, resize_window_check)
11151 (delete_deletable_window, resize_root_window)
11152 (resize_frame_windows): Declare prototypes.
11153
11154 * window.c (resize_window_apply): Make definition be "static" to
11155 match the prototype.
11156
562dd5e9
MR
111572011-06-10 Martin Rudalics <rudalics@gmx.at>
11158
11159 * window.c: Remove declarations of Qwindow_size_fixed,
11160 window_min_size_1, window_min_size_2, window_min_size,
11161 size_window, window_fixed_size_p, enlarge_window, delete_window.
11162 Remove static from declaration of Qdelete_window, it's
11163 temporarily needed by Fbury_buffer.
11164 (replace_window): Don't assign orig_top_line and
11165 orig_total_lines.
11166 (Fdelete_window, delete_window): Remove. Window deletion is
11167 handled by window.el.
640c8776
SM
11168 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11169 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11170 (Fdelete_other_windows): Remove. Deleting other windows is
11171 handled by window.el.
11172 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11173 handled in window.el.
11174 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11175 Window minimum sizes are handled in window.el.
11176 (shrink_windows, size_window, set_window_height)
11177 (set_window_width, change_window_heights, window_height)
11178 (window_width, CURBEG, CURSIZE, enlarge_window)
11179 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11180 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11181 handled in window.el.
11182 (make_dummy_parent): Rename to make_parent_window and give it a
11183 second argument horflag.
11184 (make_window): Don't set resize_proportionally any more.
11185 (Fsplit_window): Remove. Windows are split in window.el.
11186 (save_restore_action, save_restore_orig_size)
11187 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11188 Resize mini windows in window.el.
11189 (grow_mini_window, shrink_mini_window): Implement by calling
11190 Qresize_root_window_vertically, resize_window_check and
11191 resize_window_apply.
640c8776
SM
11192 (saved_window, Fset_window_configuration, save_window_save):
11193 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11194 resize_proportionally.
11195 (window_min_height, window_min_width): Move to window.el.
11196 (keys_of_window): Move bindings for delete-other-windows,
11197 split-window, delete-window and enlarge-window to window.el.
11198
11199 * buffer.c: Temporarily extern Qdelete_window.
11200 (Fbury_buffer): Temporarily call Qdelete_window instead of
11201 Fdelete_window (Fbury_buffer will move to window.el soon).
11202
11203 * frame.c (set_menu_bar_lines_1): Remove code handling
11204 orig_top_line and orig_total_lines.
11205
11206 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11207 set_window_height but set heights directly.
11208 (change_frame_size_1): Use resize_frame_windows.
11209
11210 * xdisp.c (init_xdisp): Don't use set_window_height but set
11211 heights directly.
11212
640c8776
SM
11213 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11214 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11215 run_window_configuration_change_hook.
11216
11217 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11218 instead of change_window_heights and run
11219 run_window_configuration_change_hook.
11220
1a13852e
MR
112212011-06-09 Martin Rudalics <rudalics@gmx.at>
11222
11223 * window.c (replace_window): Rename second argument REPLACEMENT to
11224 NEW. New third argument SETFLAG. Rewrite.
11225 (delete_window, make_dummy_parent): Call replace_window with
11226 third argument 1.
11227 (window_list_1): Move down in code.
11228 (run_window_configuration_change_hook): Move set_buffer part
11229 before select_frame_norecord part in order to unwind correctly.
11230 Rename count1 to count.
11231 (recombine_windows, delete_deletable_window, resize_root_window)
11232 (Fdelete_other_windows_internal)
11233 (Frun_window_configuration_change_hook, make_parent_window)
11234 (resize_window_check, resize_window_apply, Fresize_window_apply)
11235 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11236 (Fdelete_window_internal, Fresize_mini_window_internal):
11237 New functions.
1a13852e
MR
11238 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11239
f3d1777e
MR
112402011-06-08 Martin Rudalics <rudalics@gmx.at>
11241
496e208e
MR
11242 * window.h (window): Add some new members to window structure -
11243 normal_lines, normal_cols, new_total, new_normal, clone_number,
11244 splits, nest, prev_buffers, next_buffers.
11245 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11246 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11247
f3d1777e
MR
11248 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11249 Remove.
496e208e
MR
11250 (make_dummy_parent): Set new members of windows structure.
11251 (make_window): Move down in code. Handle new members of window
11252 structure.
11253 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11254 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11255 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11256 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11257 (Fset_window_next_buffers, Fset_window_clone_number):
11258 New functions.
496e208e
MR
11259 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11260 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11261 Doc-string fixes.
11262 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11263 Argument WINDOW can be now internal window too.
11264 (Fwindow_use_time): Move up in code.
11265 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11266 Rewrite doc-string.
11267 (Fset_window_configuration, saved_window)
11268 (Fcurrent_window_configuration, save_window_save): Handle new
11269 members of window structure.
b9e809c2
MR
11270 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11271 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11272 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11273 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11274 Qget_mru_window, Qresize_root_window,
11275 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11276 Qauto_buffer_name; staticpro them.
f3d1777e 11277
abde8f8c
MR
112782011-06-07 Martin Rudalics <rudalics@gmx.at>
11279
11280 * window.c (Fwindow_total_size, Fwindow_left_column)
11281 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11282 (Fwindow_list_1): New functions.
11283 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11284 (Fwindow_width, Fscroll_left, Fscroll_right):
11285 Use window_body_cols instead of window_box_text_cols.
11286 (delete_window, Fset_window_configuration):
11287 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11288 (delete_all_subwindows): Take a window as argument and not a
11289 structure. Rewrite.
190b47e6
MR
11290 (window_loop): Remove handling of GET_LRU_WINDOW and
11291 GET_LARGEST_WINDOW.
11292 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11293
11294 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11295 window_box_text_cols. delete_all_subwindows now takes a
11296 Lisp_Object as argument.
abde8f8c 11297
640c8776
SM
11298 * indent.c (compute_motion, Fcompute_motion):
11299 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11300
fa8a67e6
MR
11301 * frame.c (delete_frame): Call delete_all_subwindows with root
11302 window as argument.
11303
a54e3482
DC
113042011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11305
11306 * fns.c (Fputhash): Document return value.
11307
60002bf5
CY
113082011-06-06 Chong Yidong <cyd@stupidchicken.com>
11309
11310 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11311
0c671da6 113122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11313
b862a52a 11314 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11315
be44ca6c
PE
11316 Check for overflow when converting integer to cons and back.
11317 * charset.c (Fdefine_charset_internal, Fdecode_char):
11318 Use cons_to_unsigned to catch overflow.
11319 (Fencode_char): Use INTEGER_TO_CONS.
11320 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11321 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11322 * data.c (long_to_cons, cons_to_long): Remove.
11323 (cons_to_unsigned, cons_to_signed): New functions.
11324 These signal an error for invalid or out-of-range values.
11325 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11326 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11327 * font.c (Ffont_variation_glyphs):
11328 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11329 * lisp.h: Include <intprops.h>.
11330 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11331 (cons_to_signed, cons_to_unsigned): New decls.
11332 (long_to_cons, cons_to_long): Remove decls.
11333 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11334 (Fprimitive_undo): Use CONS_TO_INTEGER.
11335 * xfns.c (Fx_window_property): Likewise.
11336 * xselect.c: Include <limits.h>.
11337 (x_own_selection, selection_data_to_lisp_data):
11338 Use INTEGER_TO_CONS.
11339 (x_handle_selection_request, x_handle_selection_clear)
11340 (x_get_foreign_selection, Fx_disown_selection_internal)
11341 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11342 (lisp_data_to_selection_data): Use cons_to_unsigned.
11343 (x_fill_property_data): Use cons_to_signed.
11344 Report values out of range.
11345
d1f3d2af
PE
11346 Check for buffer and string overflow more precisely.
11347 * buffer.h (BUF_BYTES_MAX): New macro.
11348 * lisp.h (STRING_BYTES_MAX): New macro.
11349 * alloc.c (Fmake_string):
11350 * character.c (string_escape_byte8):
11351 * coding.c (coding_alloc_by_realloc):
11352 * doprnt.c (doprnt):
11353 * editfns.c (Fformat):
11354 * eval.c (verror):
11355 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11356 since they may not be the same number.
11357 * editfns.c (Finsert_char):
11358 * fileio.c (Finsert_file_contents):
11359 Likewise for BUF_BYTES_MAX.
11360
dd52fcea
PE
11361 * image.c: Use ptrdiff_t, not int, for sizes.
11362 (slurp_file): Switch from int to ptrdiff_t.
11363 All uses changed.
11364 (slurp_file): Check that file size fits in both size_t (for
11365 malloc) and ptrdiff_t (for sanity and safety).
11366
7f9bbdbb
PE
11367 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11368 if b->modtime has its maximal value.
11369
dfe18f82
PE
11370 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11371
84acfcf0
PE
11372 Don't assume time_t can fit into int.
11373 * buffer.h (struct buffer.modtime): Now time_t, not int.
11374 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11375 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11376
ccd9a01a
PE
11377 Minor fixes for signed vs unsigned integers.
11378 * character.h (MAYBE_UNIFY_CHAR):
11379 * charset.c (maybe_unify_char):
11380 * keyboard.c (read_char, reorder_modifiers):
11381 XINT -> XFASTINT, since the integer must be nonnegative.
11382 * ftfont.c (ftfont_spec_pattern):
11383 * keymap.c (access_keymap, silly_event_symbol_error):
11384 XUINT -> XFASTINT, since the integer must be nonnegative.
11385 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11386 since it makes no difference and we prefer signed.
11387 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11388 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11389 nonnegative.
11390
d6d100dd
SM
113912011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11392
11393 * window.h (Fwindow_frame): Declare.
11394
2b6148e4
PE
113952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11396
11397 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11398 (SPARE_MEMORY): Always define.
11399 (LARGE_REQUEST): Remove.
11400 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11401
f230ecc9
MR
114022011-06-06 Martin Rudalics <rudalics@gmx.at>
11403
727e958e
MR
11404 * lisp.h: Move EXFUNS for Fframe_root_window,
11405 Fframe_first_window and Fset_frame_selected_window to window.h.
11406
11407 * window.h: Move EXFUNS for Fframe_root_window,
11408 Fframe_first_window and Fset_frame_selected_window here from
11409 lisp.h.
11410
11411 * frame.c (Fwindow_frame, Fframe_first_window)
11412 (Fframe_root_window, Fframe_selected_window)
11413 (Fset_frame_selected_window): Move to window.c.
11414 (Factive_minibuffer_window): Move to minibuf.c.
11415 (Fother_visible_frames_p): New function.
11416
11417 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11418
f230ecc9
MR
11419 * window.c (decode_window, decode_any_window): Move up in code.
11420 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11421 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11422 (Fwindow_buffer): Move up and rewrite doc-string.
11423 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11424 (Fwindow_prev): New functions.
727e958e
MR
11425 (Fwindow_frame): Move here from frame.c. Accept any window as
11426 argument.
11427 (Fframe_root_window, Fframe_first_window)
11428 (Fframe_selected_window): Move here from frame.c. Accept frame
11429 or arbitrary window as argument. Update doc-strings.
11430 (Fminibuffer_window): Move up in code.
11431 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11432 (Fset_frame_selected_window): Move here from frame.c.
11433 Marginal rewrite.
727e958e
MR
11434 (Fselected_window, select_window, Fselect_window): Move up in
11435 code. Minor doc-string fixes.
f230ecc9 11436
4d09bcf6
PE
114372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11438
11439 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11440 Do not assume that spare memory exists; that assumption is valid
11441 only if SYSTEM_MALLOC.
11442 (LARGE_REQUEST): New macro, so that the issue of large requests
11443 is separated from the issue of spare memory.
11444
810928a2
AS
114452011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11446
172418ad
AS
11447 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11448 format. (Bug#8806)
11449
43f862f7
AS
11450 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11451
810928a2
AS
11452 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11453 before statements.
11454
a059fe24
JD
114552011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11456
11457 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11458
11459 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11460
11461 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11462 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11463
989bf368
JB
114642011-06-05 Juanma Barranquero <lekktu@gmail.com>
11465
11466 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11467
4b80f674
CY
114682011-06-04 Chong Yidong <cyd@stupidchicken.com>
11469
11470 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11471 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11472 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11473 New error handlers.
4b80f674
CY
11474 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11475 Obey Vx_select_enable_clipboard_manager. Catch errors in
11476 x_clipboard_manager_save (Bug#8779).
11477 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11478 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11479
99a33b77 114802011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11481
11482 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11483
99a33b77 114842011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11485
11486 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11487 in the current matrix if keep_current_p is non-zero.
11488
8264569d
EZ
114892011-06-04 Eli Zaretskii <eliz@gnu.org>
11490
11491 * bidi.c (bidi_level_of_next_char): Fix last change.
11492
57f97249
EZ
114932011-06-03 Eli Zaretskii <eliz@gnu.org>
11494
fec2107c 11495 Support bidi reordering of text covered by display properties.
57f97249 11496
fec2107c
EZ
11497 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11498 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11499 (bidi_cache_search, bidi_cache_iterator_state)
11500 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11501 (bidi_level_of_next_char, bidi_move_to_visually_next):
11502 Support character positions inside a run of characters covered by a
fec2107c
EZ
11503 display string.
11504 (bidi_paragraph_init, bidi_resolve_explicit_1)
11505 (bidi_level_of_next_char): Call bidi_fetch_char and
11506 bidi_fetch_char_advance instead of FETCH_CHAR and
11507 FETCH_CHAR_ADVANCE.
11508 (bidi_init_it): Initialize new members.
11509 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11510 definitions.
11511 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11512 instead of using explicit *_CHAR codes.
d6d100dd
SM
11513 (bidi_resolve_explicit, bidi_resolve_weak):
11514 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11515 bidirectional text is supported only in multibyte buffers.
11516 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11517 it to initialize the frame_window_p member of struct bidi_it.
11518 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11519 (bidi_resolve_explicit, bidi_resolve_weak)
11520 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11521 bidi_it->nchars is non-positive.
11522 (bidi_level_of_next_char): Don't try to lookup the cache for the
11523 next/previous character if nothing is cached there yet, or if we
11524 were just reseat()'ed to a new position.
c40e2fb2 11525
0e14fe90
EZ
11526 * xdisp.c (set_cursor_from_row): Set start and stop points
11527 according to the row's direction when priming the loop that looks
11528 for the glyph on which to display cursor.
11529 (single_display_spec_intangible_p): Function deleted.
11530 (display_prop_intangible_p): Reimplement to call
11531 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11532 Accept 3 additional arguments needed by handle_display_spec.
11533 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11534 values: lists, `(when COND...)' forms, etc.
11535 (single_display_spec_string_p): Support property values that are
11536 lists with the argument STRING its top-level element.
11537 (display_prop_string_p): Fix the condition for processing a
11538 property that is a list to be consistent with handle_display_spec.
fec2107c 11539 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11540 last portion of handle_display_prop.
11541 (compute_display_string_pos): Accept additional argument
11542 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11543 value of a `display' property is a "replacing spec".
11544 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11545 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11546 the display property, but just return a value indicating whether
11547 the display property will replace the characters it covers.
11548 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11549 frame_window_p members of struct bidi_it.
d6d100dd
SM
11550 (compute_display_string_pos, compute_display_string_end):
11551 New functions.
fec2107c
EZ
11552 (push_it): Accept second argument POSITION, where pop_it should
11553 jump to continue iteration.
11554 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11555
fec2107c
EZ
11556 * keyboard.c (adjust_point_for_property): Adjust the call to
11557 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11558
11559 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11560 (bidi_init_it): Update prototypes.
11561 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11562 (compute_display_string_pos, compute_display_string_end):
11563 Declare prototypes.
fec2107c
EZ
11564 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11565 EMACS_INT.
fc6f18ce 11566
40087514 115672011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11568
57f53182
PE
11569 Malloc failure behavior now depends on size of allocation.
11570 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11571 * lisp.h: Change signatures accordingly.
11572 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11573 All callers changed. (Bug#8762)
11574
11575 * gnutls.c: Use Emacs's memory allocators.
11576 Without this change, the gnutls library would invoke malloc etc.
11577 directly, which causes problems on non-SYNC_INPUT hosts, and which
11578 runs afoul of improving memory_full behavior. (Bug#8761)
11579 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11580 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11581 xfree instead of the default malloc, realloc, free.
11582 (Fgnutls_boot): No need to check for memory allocation failure,
11583 since xmalloc does that for us.
11584
ac32cd99 11585 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11586 * category.c (hash_get_category_set):
11587 * ccl.c (ccl_driver):
11588 * charset.c (Fdefine_charset_internal):
11589 * charset.h (struct charset.hash_index):
11590 * composite.c (get_composition_id, gstring_lookup_cache)
11591 (composition_gstring_put_cache):
11592 * composite.h (struct composition.hash_index):
11593 * dispextern.h (struct image.hash):
11594 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11595 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11596 (hashfn_equal, hashfn_user_defined, make_hash_table)
11597 (maybe_resize_hash_table, hash_lookup, hash_put)
11598 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11599 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11600 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11601 * image.c (make_image, search_image_cache, lookup_image)
11602 (xpm_put_color_table_h):
11603 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11604 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11605 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11606 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11607 * alloc.c (allocate_vectorlike):
11608 Check for overflow in vector size calculations.
11609 * ccl.c (ccl_driver):
11610 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11611 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11612 need to be updated by these changes.
40087514
PE
11613 * fns.c (make_hash_table, maybe_resize_hash_table):
11614 Check for integer overflow with large hash tables.
0de4bb68
PE
11615 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11616 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11617 (SXHASH_REDUCE): New macro.
11618 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11619 Use it instead of discarding useful hash info with large hash values.
11620 (sxhash_float): New function.
11621 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11622 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11623 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11624 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11625 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11626 Adjust signatures to match updated version of code.
11627 (consing_since_gc): Now EMACS_INT, since a single hash table can
11628 use more than INT_MAX bytes.
11629
698d32e2
DN
116302011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11631
11632 Make it possible to build with GCC-4.6+ -O2 -flto.
11633
11634 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11635
fd6fa53f
SM
116362011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11637
11638 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11639 Call minibuffer-inactive-mode.
11640
864db017
JB
116412011-05-31 Juanma Barranquero <lekktu@gmail.com>
11642
11643 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11644 Update dependencies.
11645
2ad0baf4
DN
116462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11647
11648 * data.c (init_data): Remove code for UTS, this system is not
11649 supported anymore.
11650
4fcc2638
DN
116512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11652
11653 Don't force ./temacs to start in terminal mode.
11654
11655 * frame.c (make_initial_frame): Initialize faces in all cases, not
11656 only when CANNOT_DUMP is defined.
11657 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11658
c56e0fd5
DN
116592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11660
11661 * dispnew.c (add_window_display_history): Use const for the string
11662 pointer. Remove declaration, not needed.
11663
333d54da 116642011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11665
55d4c1b2 11666 Use 'inline', not 'INLINE'.
333d54da 11667 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11668 * alloc.c, fontset.c (INLINE): Remove.
11669 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11670 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11671 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11672 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11673 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11674
738db178
DN
116752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11676
11677 Make it possible to run ./temacs.
11678
11679 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11680 syms_of_callproc does the same thing. Remove test for
11681 "initialized", do it in the caller.
11682 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11683
620c53a6
SM
116842011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11685
11686 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11687 (read_minibuf): Use get_minibuffer.
11688 (syms_of_minibuf): Use DEFSYM.
11689 (Qmetadata): New var.
11690 * data.c (Qbuffer): Don't make it static.
11691 (syms_of_data): Use DEFSYM.
11692
e003a292
PE
116932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11694
11695 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11696 (CCL_CODE_MIN): New macro.
11697
ed008a6d
PE
116982011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11699
3687c2ef
PE
11700 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11701
ed008a6d
PE
11702 * eval.c (Qdebug): Now static.
11703 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11704 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11705 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11706
d66c4c7c
CY
117072011-05-29 Chong Yidong <cyd@stupidchicken.com>
11708
11709 * image.c: Various fixes to ImageMagick code comments.
11710 (Fimagemagick_types): Doc fix.
11711
5fbc2025
PE
117122011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11713
0196f88a
PE
11714 Minor fixes prompted by GCC 4.6.0 warnings.
11715
11716 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11717
5fbc2025
PE
11718 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11719 (x_clipboard_manager_save_all): Move extern decl to ...
11720 * xterm.h: ... here, so that it can be checked for consistency.
11721
1dd3c2d9
CY
117222011-05-29 Chong Yidong <cyd@stupidchicken.com>
11723
11724 * xselect.c (x_clipboard_manager_save_frame)
11725 (x_clipboard_manager_save_all): New functions.
11726 (Fx_clipboard_manager_save): Lisp function deleted.
11727
11728 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11729 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11730
11731 * xterm.h: Update prototype.
11732
5ba6571d
WX
117332011-05-28 William Xu <william.xwl@gmail.com>
11734
11735 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11736 exiting (Bug#8239).
11737
3eaff834
JM
117382011-05-28 Jim Meyering <meyering@redhat.com>
11739
e1900994 11740 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11741 * fns.c (to_uchar): Define.
11742 (crypto_hash_function): Use it to convert some newly-signed
11743 variables to unsigned, to avoid sign-extension bugs. For example,
11744 without this change, (md5 "truc") would evaluate to
11745 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11746 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11747 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11748
0f6990a7
PE
117492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11750
11751 Integer overflow fixes.
c8a9ca5a 11752
08686060
PE
11753 * dbusbind.c: Serial number integer overflow fixes.
11754 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11755 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11756 to hold a serial number that is too large for a fixnum.
11757 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11758 Check for serial numbers out of range. Decode any serial number
59568bf0 11759 that was so large that it became a float. (Bug#8722)
08686060 11760
2d1fc3c7
PE
11761 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11762 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11763 Use XFASTINT rather than XUINT when numbers are nonnegative.
11764 (xd_append_arg, Fdbus_method_return_internal):
11765 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11766 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11767 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11768 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11769 (Bug#8722)
2d1fc3c7 11770
c8a9ca5a
PE
11771 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11772
519e1d69
PE
11773 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11774
6df6ae42 11775 ccl: Add integer overflow checks.
30569699
PE
11776 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11777 (IN_INT_RANGE): New macros.
11778 (ccl_driver): Use them to check for integer overflow when
11779 decoding a CCL program. Many of the new checks are whether XINT (x)
11780 fits in int; it doesn't always, on 64-bit hosts. The new version
11781 doesn't catch all possible integer overflows, but it's an
847044ea 11782 improvement. (Bug#8719)
30569699 11783
c11285dc
PE
11784 * alloc.c (make_event_array): Use XINT, not XUINT.
11785 There's no need for unsigned here.
11786
fdccd48e
PE
11787 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11788 This follows up to the 2011-05-06 change that substituted uintptr_t
11789 for EMACS_INT. This case wasn't caught back then.
11790
37910ab2
PE
11791 Rework Fformat to avoid integer overflow issues.
11792 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11793 now (part of C89). Include <verify.h>.
11794 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11795 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11796 (Fformat): Avoid the prepass trying to compute sizes; it was only
11797 approximate and thus did not catch overflow reliably. Instead, walk
11798 through the format just once, formatting and computing sizes as we go,
11799 checking for integer overflow at every step, and allocating a larger
11800 buffer as needed. Keep track separately whether the format is
11801 multibyte. Keep only the most-recently calculated precision, rather
11802 than them all. Record whether each argument has been converted to
11803 string. Use EMACS_INT, not int, for byte and char and arg counts.
11804 Support field widths and precisions larger than INT_MAX. Avoid
11805 sprintf's undefined behavior with conversion specifications such as %#d
11806 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11807 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11808 formatting out-of-range floating point numbers with int
9173deec 11809 formats. (Bug#8668)
37910ab2 11810
2e6578fb
PE
11811 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11812
0ae6bdee
PE
11813 * data.c: Avoid integer truncation in expressions involving floats.
11814 * data.c: Include <intprops.h>.
11815 (arith_driver): When there's an integer overflow in an expression
11816 involving floating point, convert the integers to floating point
11817 so that the resulting value does not suffer from catastrophic
11818 integer truncation. For example, on a 64-bit host (* 4
11819 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11820 Do not rely on undefined behavior after integer overflow.
11821
de883a70
PE
11822 merge count_size_as_multibyte, parse_str_to_multibyte
11823 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11824 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11825 Check for integer overflow.
11826 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11827 since it's now a duplicate of the other. This is more of
11828 a character than a buffer op, so better that it's in character.c.
11829 * fns.c, print.c: Adjust to above changes.
11830
2ff916cb
PE
118312011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11832
11833 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11834
f1b54466
PE
118352011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11836
fb1ac845
PE
11837 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11838 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11839 (x_clipboard_manager_save): Now static.
11840 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11841
f1b54466
PE
11842 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11843 (crypto_hash_function): Now static.
11844 Fix pointer signedness problems. Avoid unnecessary initializations.
11845
a9f737ee
CY
118462011-05-27 Chong Yidong <cyd@stupidchicken.com>
11847
11848 * termhooks.h (Vselection_alist): Make it terminal-local.
11849
11850 * terminal.c (create_terminal): Initialize it.
11851
11852 * xselect.c: Support for clipboard managers.
11853 (Vselection_alist): Move to termhooks.h as terminal-local var.
11854 (LOCAL_SELECTION): New macro.
11855 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11856 (symbol_to_x_atom): Remove gratuitous arg.
11857 (x_handle_selection_request, lisp_data_to_selection_data)
11858 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11859 (x_own_selection, x_get_local_selection, x_convert_selection):
11860 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11861 (some_frame_on_display): Delete unused function.
11862 (Fx_own_selection_internal, Fx_get_selection_internal)
11863 (Fx_disown_selection_internal, Fx_selection_owner_p)
11864 (Fx_selection_exists_p): New optional frame arg.
11865 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11866 (x_handle_selection_clear): Don't treat other terminals with the
11867 same keyboard specially. Use the terminal-local Vselection_alist.
11868 (x_clear_frame_selections): Use Frun_hook_with_args.
11869
11870 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11871
11872 * xterm.h: Add support for those atoms.
11873
e067f0c1
CY
118742011-05-26 Chong Yidong <cyd@stupidchicken.com>
11875
11876 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11877 (converted_selections, conversion_fail_tag): New global variables.
11878 (x_selection_request_lisp_error): Free the above.
11879 (x_get_local_selection): Remove unnecessary code.
11880 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11881 of converted selections stored in converted_selections.
11882 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11883 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11884 (x_convert_selection): New function.
11885 (x_handle_selection_event): Simplify.
11886 (x_get_foreign_selection): Don't ignore incoming requests while
11887 waiting for an answer; this will fail when we implement
11888 SAVE_TARGETS, and seems unnecessary anyway.
11889 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11890 (Vx_sent_selection_functions): Doc fix.
11891
0f4aebc0
LL
118922011-05-26 Leo Liu <sdl.web@gmail.com>
11893
11894 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11895
e61124cd
YM
118962011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11897
11898 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11899
11900 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11901 for fringe update if it has periodic bitmap.
ac389d0c 11902 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11903 and fringe_bitmap_periodic_p.
11904
11905 * fringe.c (get_fringe_bitmap_data): New function.
11906 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11907 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11908 row. Mark glyph row for fringe update if periodicity changed.
11909
11910 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11911 for fringe update unless it has periodic bitmap.
11912
f16d9837
KH
119132011-05-25 Kenichi Handa <handa@m17n.org>
11914
11915 * xdisp.c (get_next_display_element): Set correct it->face_id for
11916 a static composition.
11917
e1b90ef6
LL
119182011-05-24 Leo Liu <sdl.web@gmail.com>
11919
11920 * deps.mk (fns.o):
11921 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11922
11923 * fns.c (crypto_hash_function, Fsha1): New function.
11924 (Fmd5): Use crypto_hash_function.
11925 (syms_of_fns): Add Ssha1.
11926
7400048f
PE
119272011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11928
11929 * gnutls.c: Remove unused macros.
11930 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11931 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11932 Remove macros that are defined and never used.
11933 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11934
abb71cf4
CY
119352011-05-22 Chong Yidong <cyd@stupidchicken.com>
11936
11937 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11938 (Fx_get_selection_internal): Minor cleanup.
11939 (Fx_own_selection_internal): Rename arguments for consistency with
11940 select.el.
11941
6307db39
PE
119422011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11943
11944 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11945
f3d4e0a4
CY
119462011-05-22 Chong Yidong <cyd@stupidchicken.com>
11947
11948 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11949
4d8ade89
YM
119502011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11951
11952 * dispnew.c (scrolling_window): Don't exclude the case that the
11953 last enabled row in the desired matrix touches the bottom boundary.
11954
32078c8d
GM
119552011-05-21 Glenn Morris <rgm@gnu.org>
11956
11957 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11958 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11959 and add some more files.
32078c8d 11960
7285dc67
EZ
119612011-05-20 Eli Zaretskii <eliz@gnu.org>
11962
11963 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11964 report_file_error introduced by the change from 2011-05-07.
11965
89d1bd22
PE
119662011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11967
11968 * systime.h (Time): Define only if emacs is defined.
11969 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11970 where the include path doesn't have X11/X.h by default. See
11971 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11972
cd394be1 119732011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11974
11975 * composite.c (find_automatic_composition): Fix previous change.
11976
b9704ad9
GM
119772011-05-20 Glenn Morris <rgm@gnu.org>
11978
11979 * lisp.mk: New file, split from Makefile.in.
11980 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11981 (shortlisp): Remove.
11982 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11983
4a720484
GM
119842011-05-19 Glenn Morris <rgm@gnu.org>
11985
11986 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11987 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11988 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11989 (lisp): Set the order to that of loadup.el.
11990 (shortlisp): Make it a copy of $lisp.
11991 (SOME_MACHINE_LISP): Remove.
11992 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11993 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11994
a28d4396
KH
119952011-05-18 Kenichi Handa <handa@m17n.org>
11996
11997 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11998 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11999 (find_automatic_composition): Mostly rewrite for efficiency.
12000
a2b1fa8e
JB
120012011-05-18 Juanma Barranquero <lekktu@gmail.com>
12002
12003 * makefile.w32-in: Update dependencies.
12004
8e1f5610
CS
120052011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12006
12007 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12008 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12009
7025ee00 120102011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12011
cdfa6eab
PE
12012 Fix some integer overflow issues, such as string length overflow.
12013
06d6db33
PE
12014 * insdel.c (count_size_as_multibyte): Check for string overflow.
12015
2b4560a8
PE
12016 * character.c (lisp_string_width): Check for string overflow.
12017 Use EMACS_INT, not int, for string indexes and lengths; in
12018 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12019 the resulting string length overflows an EMACS_INT; instead,
12020 report a string overflow if no precision given. When checking for
12021 precision exhaustion, use a check that cannot possibly have
12022 integer overflow. (Bug#8675)
12023 * character.h (lisp_string_width): Adjust to new signature.
12024
cb93f9be
PE
12025 * alloc.c (string_overflow): New function.
12026 (Fmake_string): Use it. This doesn't change behavior, but saves
12027 a few bytes and will simplify future changes.
12028 * character.c (string_escape_byte8): Likewise.
12029 * lisp.h (string_overflow): New decl.
12030
1a1f3366
PE
12031 Fixups, following up to the user-interface timestamp change.
12032 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12033 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12034 * msdos.c (mouse_get_pos): Likewise.
12035 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12036 * w32gui.h (Time): Define by including "systime.h" rather than by
12037 declaring it ourselves. (Bug#8664)
12038
d4e3e4d3
PE
12039 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12040 * image.c (clear_image_cache): Likewise.
12041
f6a24d19
PE
12042 * term.c (term_mouse_position): Don't assume time_t wraparound.
12043
08dc5ae6
PE
12044 Be more systematic about user-interface timestamps.
12045 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12046 and sometimes 'EMACS_UINT', to represent these timestamps.
12047 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12048 This makes the code easier to follow, and makes it easier to catch
12049 integer overflow bugs such as Bug#8664.
12050 * frame.c (Fmouse_position, Fmouse_pixel_position):
12051 Use Time, not unsigned long, for user-interface timestamps.
12052 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12053 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12054 * keyboard.h (last_event_timestamp): Likewise.
12055 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12056 * menu.h (xmenu_show): Likewise.
12057 * term.c (term_mouse_position): Likewise.
12058 * termhooks.h (struct input_event.timestamp): Likewise.
12059 (struct terminal.mouse_position_hook): Likewise.
12060 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12061 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12062 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12063 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12064 what it was before.
12065 * menu.h, termhooks.h: Include "systime.h", for Time.
12066
8e55734a
PE
12067 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12068 Don't assume that the difference between two unsigned long values
12069 can fit into an integer. At this point, we know button_down_time
12070 <= event->timestamp, so the difference must be nonnegative, so
12071 there's no need to cast the result if double-click-time is
12072 nonnegative, as it should be; check that it's nonnegative, just in
12073 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12074 apart (about 25 days). (Bug#8664)
8e55734a 12075
841f1b75 12076 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12077 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12078
3e26f69c
PE
12079 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12080 that always fit in int. Use a sentinel instead of a counter, to
12081 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12082 * frame.h (struct frame): Use int for menu_bar_items_used
12083 instead of EMACS_INT, since it always fits in int.
3e26f69c 12084
5cc152c0
PE
12085 * menu.c (grow_menu_items): Check for int overflow.
12086
d89eb65e
PE
12087 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12088
5235bd3e
PE
12089 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12090 Before, the code was not consistent. These values cannot exceed
12091 2**31 - 1 so there's no need to make them unsigned.
12092 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12093 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12094 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12095 as modifiers.
12096 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12097
bc827e23
PE
12098 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12099 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12100 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12101 presumably because the widths might not match.
12102
78eb494e
PE
12103 * window.c (size_window): Avoid needless test at loop start.
12104
04f2d78b
CB
121052011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12106
12107 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12108
d2fc7e3d 121092011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12110
12111 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12112
d2fc7e3d 121132011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12114
12115 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12116 `width' to `bar_area_x' and `bar_area_width', respectively.
12117 (x_scroll_run): Take account of fringe background extension.
12118
04f2d78b
CB
12119 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12120 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12121 `bar_area_width', respectively.
12122 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12123 background extension.
12124
79b70037
GM
121252011-05-10 Jim Meyering <meyering@redhat.com>
12126
12127 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12128
2f142cc5
JB
121292011-05-10 Juanma Barranquero <lekktu@gmail.com>
12130
12131 * image.c (Finit_image_library): Return t for built-in image types,
12132 like pbm and xbm. (Bug#8640)
12133
57679c86
AS
121342011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12135
12136 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12137
888c9e86
EZ
121382011-05-07 Eli Zaretskii <eliz@gnu.org>
12139
b0512a1d
EZ
12140 * w32console.c (Fset_screen_color): Doc fix.
12141 (Fget_screen_color): New function.
12142 (syms_of_ntterm): Defsubr it.
12143
7285dc67
EZ
12144 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12145 unlink the temporary file if Fcall_process didn't create it in the
12146 first place.
12147 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12148 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12149 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12150 cue to call_process_cleanup not to close that handle.
12151
4d3fcc8e
BK
121522011-05-07 Ben Key <bkey76@gmail.com>
12153
12154 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12155 one of two shell specific rules, either bootstrap-temacs-CMD or
12156 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12157 to the previous implementation of the bootstrap-temacs rule.
12158 The bootstrap-temacs-CMD rule is similar to the previous
12159 implementation of the bootstrap-temacs rule except that it
12160 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12161 variable.
12162
12163 These changes, along with some changes to nt/configure.bat,
12164 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12165 earlier fix to add support for --cflags and --ldflags options
12166 that include quotes so that it works whether make uses cmd or
12167 sh as the shell.
12168
b4289b64
MA
121692011-05-06 Michael Albinus <michael.albinus@gmx.de>
12170
12171 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12172 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12173 is a constant.
12174 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12175 a string. Handle both cases.
12176 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12177 (Fdbus_register_method): Use Qinvalid_function.
12178
af4c0e28
JB
121792011-05-06 Juanma Barranquero <lekktu@gmail.com>
12180
12181 * makefile.w32-in: Update dependencies.
12182 (LISP_H): Add inttypes.h and stdin.h.
12183 (PROCESS_H): Add unistd.h.
12184
c51453d9
EZ
121852011-05-06 Eli Zaretskii <eliz@gnu.org>
12186
12187 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12188 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12189
8ff0ac3c 121902011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12191
4c4b566b
PE
12192 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12193
aab2b9b5
PE
12194 * term.c (vfatal): Remove stray call to va_end.
12195 It's not needed and the C Standard doesn't allow it here anyway.
12196
c378da0b
PE
12197 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12198 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12199
288b08c7
PE
12200 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12201 bytes.
12202
e3601888
PE
12203 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12204
db6c0e74
PE
12205 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12206
dd5963ea
PE
12207 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12208
88c9450f
PE
12209 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12210
2f9442b8
PE
12211 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12212
c032b5f8
PE
12213 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12214 * charset.c (Fdefine_charset_internal): Don't initialize
12215 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12216 32-bit int (Bug#8600).
a108c10b
PE
12217
12218 * lread.c (read_integer): Be more consistent with string-to-number.
12219 Use string_to_number to do the actual conversion; this avoids
12220 rounding errors and fixes some other screwups. Without this fix,
12221 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12222 (digit_to_number): Move earlier, for benefit of read_integer.
12223 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12224 not a digit in any supported base. (Bug#8602)
a108c10b 12225
ad5f9eea
PE
12226 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12227
aec1708a
PE
12228 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12229 to match comment at start of function. This also removes a
12230 GCC warning about overflow in a 32+64-bit port.
12231
47be4ab5
PE
12232 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12233
371cac43
PE
12234 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12235 Reported by Stefan Monnier in
12236 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12237 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12238 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12239
d01a7826
PE
12240 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12241 (EMACS_UINTPTR): Likewise, with uintptr_t.
12242
7fd47d5c
PE
12243 * lisp.h: Prefer 64-bit EMACS_INT if available.
12244 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12245 on 32-bit hosts that have 64-bit int, so that they can access
12246 large files.
122b0c86
PE
12247 However, temporarily disable this change unless the temporary
12248 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12249
8727937b
PE
12250 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12251
8ac068ac
PE
12252 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12253 This removes an assumption that EMACS_INT and long are the same
12254 width as pointers. The assumption is true for Emacs porting targets
12255 now, but we want to make other targets possible.
12256 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12257 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12258 In the rest of the code, change types of integers that hold casted
12259 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12260 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12261 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12262 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12263 No need to cast type when ORing.
12264 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12265 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12266 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12267 assume EMACS_INT is the same width as char *.
12268 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12269 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12270 Remove no-longer-needed casts.
12271 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12272 (xg_tool_bar_help_callback, xg_make_tool_item):
12273 Use EMACS_INTPTR to hold an integer
12274 that will be cast to void *; this can avoid a GCC warning
12275 if EMACS_INT is not the same width as void *.
12276 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12277 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12278 (current_message_1, set_message_1):
12279 Use a local to convert to proper width without a cast.
12280 * xmenu.c (dialog_selection_callback): Likewise.
12281
ede49d71
PE
12282 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12283 Also, don't assume VALBITS / RAND_BITS is less than 5,
12284 and don't rely on undefined behavior when shifting a 1 left into
12285 the sign bit.
12286 * lisp.h (get_random): Change signature to match.
12287
2f30ecd0
PE
12288 * lread.c (hash_string): Use size_t, not int, for hash computation.
12289 Normally we prefer signed values; but hashing is special, because
12290 it's better to use unsigned division on hash table sizes so that
12291 the remainder is nonnegative. Also, size_t is the natural width
12292 for hashing into memory. The previous code used 'int', which doesn't
12293 retain enough info to hash well into very large tables.
12294 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12295
2a866e7b
PE
12296 * dbusbind.c: Don't possibly lose pointer info when converting.
12297 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12298 Use XPNTR rather than XHASH, so that the high-order bits of
12299 the pointer aren't lost when converting through void *.
12300
51639eac
PE
12301 * eval.c (Fautoload): Don't double-shift a pointer.
12302
92394119
PE
12303 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12304
dbdb9a7c
JB
123052011-05-06 Juanma Barranquero <lekktu@gmail.com>
12306
12307 * gnutls.c (DEF_GNUTLS_FN):
12308 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12309
db7a0b4f
AS
123102011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12311
12312 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12313 marker. (Bug#8610)
12314
cd394be1 123152011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12316
12317 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12318 New version that can reserve upto 2GB of heap space.
12319
f7ff1b0f 123202011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12321
12322 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12323
639c109b
TZ
123242011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12325
12326 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12327 `gnutls_certificate_set_x509_key_file'.
12328
d2127135
JB
123292011-05-05 Juanma Barranquero <lekktu@gmail.com>
12330
12331 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12332 Update dependencies.
12333
e968f4f3
JB
123342011-05-04 Juanma Barranquero <lekktu@gmail.com>
12335
12336 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12337 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12338 Remove unused parameter `fildes'.
12339 * process.c (read_process_output, send_process): Don't pass it.
12340
84d358f0
JB
123412011-05-04 Juanma Barranquero <lekktu@gmail.com>
12342
12343 Fix previous change: the library cache is defined in w32.c.
12344 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12345 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12346
0898ca10
JB
123472011-05-04 Juanma Barranquero <lekktu@gmail.com>
12348
12349 Implement dynamic loading of GnuTLS on Windows.
12350
12351 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12352 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12353 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12354 Declare.
12355
12356 * gnutls.c (Qgnutls_dll): Define.
12357 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12358 (gnutls_*): Declare function pointers.
12359 (init_gnutls_functions): New function to initialize function pointers.
12360 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12361 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12362 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12363 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12364 (emacs_gnutls_write, emacs_gnutls_read)
12365 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12366 (Fgnutls_available_p): New function.
12367 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12368 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12369 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12370
12371 * image.c: Include w32.h.
12372 (Vimage_type_cache): Delete.
12373 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12374 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12375 (w32_delayed_load): Move to w32.c.
12376
12377 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12378
12379 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12380 (w32_delayed_load): Move from image.c. When loading a library, record
12381 its filename in the :loaded-from property of the library id.
12382 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12383 Initialize and staticpro them.
12384 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12385
12386 * process.c: Include lisp.h before w32.h, not after.
12387 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12388 instead of gnutls_record_check_pending.
12389
12390 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12391
ff4de4aa
TZ
123922011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12393
12394 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12395 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12396 as passed in.
12397
abe95abb
JD
123982011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12399
12400 * xterm.c (x_set_frame_alpha): Do not set property on anything
12401 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12402
e16e55d4
JB
124032011-05-02 Juanma Barranquero <lekktu@gmail.com>
12404
12405 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12406
bafcf6a5
JB
124072011-05-02 Juanma Barranquero <lekktu@gmail.com>
12408
12409 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12410 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12411 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12412 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12413 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12414 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12415 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12416 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12417 (Qgnutls_bootprop_callbacks_verify): Make static.
12418
e7a6747f
AS
124192011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12420
19ed11ba
AS
12421 * callproc.c: Indentation fixup.
12422
e7a6747f 12423 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12424 (wait_for_termination, interruptible_wait_for_termination):
12425 Move after wait_for_termination_1.
e7a6747f 12426
1ef14cb4
LMI
124272011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12428
12429 * sysdep.c (interruptible_wait_for_termination): New function
12430 which is like wait_for_termination, but allows keyboard
12431 interruptions.
12432
12433 * callproc.c (Fcall_process): Add (:file "file") as an option for
12434 the STDOUT buffer.
12435 (Fcall_process_region): Ditto.
12436
330d880c
EZ
124372011-04-30 Eli Zaretskii <eliz@gnu.org>
12438
8db90b73
EZ
12439 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12440 rather than `XVECTOR (FOO)->size'.
12441
330d880c
EZ
12442 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12443 inttypes.h, as a gnulib replacement is used if it not available in
12444 system headers.
12445
15cbd324
EZ
124462011-04-21 Eli Zaretskii <eliz@gnu.org>
12447
12448 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12449 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12450 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12451
12452 * coding.c (coding_alloc_by_realloc): Error out if destination
12453 will grow beyond MOST_POSITIVE_FIXNUM.
12454 (decode_coding_emacs_mule): Abort if there isn't enough place in
12455 charbuf for the composition carryover bytes. Reserve an extra
12456 space for up to 2 characters produced in a loop.
12457 (decode_coding_iso_2022): Abort if there isn't enough place in
12458 charbuf for the composition carryover bytes.
12459
124602011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12461
ae940cca
EZ
12462 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12463 aborting when %lld or %lll format is passed.
12464 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12465 %llo or %llx format is passed. (Bug#8545)
12466
03ab8921
EZ
12467 * window.c (window_scroll_line_based): Use a marker instead of
12468 simple variables to record original value of point. (Bug#7952)
12469
afda1437
EZ
12470 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12471 produced by %s or %c overflows available buffer space. (Bug#8545)
12472
f76dee0c
PE
124732011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12474
12475 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12476 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12477
fdc5744d
JB
124782011-04-28 Juanma Barranquero <lekktu@gmail.com>
12479
12480 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12481
638f053a
JB
124822011-04-28 Juanma Barranquero <lekktu@gmail.com>
12483
12484 * keyboard.c (Qdelayed_warnings_hook): Define.
12485 (command_loop_1): Run `delayed-warnings-hook'
12486 if Vdelayed_warnings_list is non-nil.
12487 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12488 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12489
d178f871
EZ
124902011-04-28 Eli Zaretskii <eliz@gnu.org>
12491
12492 * doprnt.c (doprnt): Don't return value smaller than the buffer
12493 size if the message was truncated. (Bug#8545).
12494
b124fd93
JB
124952011-04-28 Juanma Barranquero <lekktu@gmail.com>
12496
12497 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12498 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12499
e810457d
PE
125002011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12501
12502 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12503
ea51cceb
JB
125042011-04-27 Juanma Barranquero <lekktu@gmail.com>
12505
12506 * makefile.w32-in: Update dependencies.
12507
94dcfacf
EZ
125082011-04-27 Eli Zaretskii <eliz@gnu.org>
12509
12510 Improve `doprnt' and its usage. (Bug#8545)
12511 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12512 `format_end'. Remove support for %l as a conversion specifier.
12513 Don't use xrealloc. Improve diagnostics when the %l size modifier
12514 is used. Update the commentary.
12515
12516 * eval.c (verror): Simplify calculation of size_t.
12517
12518 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12519 messages.
12520
f61f41d7
PE
125212011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12522
12523 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12524 change.
12525
96fb4434
PE
125262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12527
12528 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12529 This makes this file independent of the recent pseudovector change.
12530
671875da 125312011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12532
69e9b5a3
PE
12533 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12534
b5f869a7 12535 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12536 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12537 Remove unused local.
c8926152 12538 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12539
841a1577 12540 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12541 GCC 4.6.0 optimizes based on type-based alias analysis.
12542 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12543 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12544 != &v->size, and therefore "v->size = 1; b->size = 2; return
12545 v->size;" must therefore return 1. This assumption is incorrect
12546 for Emacs, since it type-puns struct Lisp_Vector * with many other
12547 types. To fix this problem, this patch adds a new type struct
f904488f 12548 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12549 and pseudovectors, and helps optimizing compilers not get fooled
12550 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12551 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12552 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12553 the size member.
eab3844f
PE
12554 (XSETPVECTYPE): Rewrite in terms of new macro.
12555 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12556 This is a bit clearer, and further avoids the possibility of
12557 undesirable aliasing.
12558 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12559 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12560 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12561 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12562 (ASIZE): Now uses header.size rather than size.
12563 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12564 to avoid the hassle of writing XVECTOR (foo)->header.size.
12565 (struct vectorlike_header): New type.
eab3844f
PE
12566 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12567 object, to help avoid aliasing.
12568 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12569 (SUBRP): Likewise, since Lisp_Subr is a special case.
12570 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12571 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12572 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12573 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12574 changed to be "header.size" and "header.next".
12575 * buffer.h (struct buffer): Likewise.
12576 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12577 * frame.h (struct frame): Likewise.
12578 * process.h (struct Lisp_Process): Likewise.
12579 * termhooks.h (struct terminal): Likewise.
12580 * window.c (struct save_window_data, struct saved_window): Likewise.
12581 * window.h (struct window): Likewise.
12582 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12583 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12584 * buffer.c (init_buffer_once): Likewise.
12585 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12586 special case.
12587 * process.c (Fformat_network_address): Use local var for size,
12588 for brevity.
12589
0df1eac5
PE
12590 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12591
847ab9d1 12592 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12593 * data.c (atof): Remove decl; no longer used or needed.
12594 (digit_to_number): Move to lread.c.
12595 (Fstring_to_number): Use new string_to_number function, to be
12596 consistent with how the Lisp reader treats infinities and NaNs.
12597 Do not assume that floating-point numbers represent EMACS_INT
12598 without losing information; this is not true on most 64-bit hosts.
12599 Avoid double-rounding errors, by insisting on integers when
12600 parsing non-base-10 numbers, as the documentation specifies.
12601 * lisp.h (string_to_number): New decl, replacing ...
12602 (isfloat_string): Remove.
bc0a5c13 12603 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12604 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12605 appears to have been a coding error. Similarly, do not accept
12606 strings like +-1e0 as floating point numbers. Do not report
12607 overflow for integer overflows unless the base is not 10 which
12608 means we have no simple and reliable way to continue.
12609 Break out the floating-point parsing into a new
12610 function string_to_number, so that Fstring_to_number parses
12611 floating point numbers consistently with the Lisp reader.
04f2d78b 12612 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12613 (E_CHAR, EXP_INT): Remove, replacing with ...
12614 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12615 (string_to_number): New function, replacing isfloat_string.
12616 This function checks for valid syntax and produces the resulting
12617 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12618 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12619 so that overflow for non-base-10 numbers is reported only when
12620 there's no portable and simple way to convert to floating point.
452f4150 12621
67769ffc
PE
12622 * textprop.c (set_text_properties_1): Rewrite for clarity,
12623 and to avoid GCC warning about integer overflow.
12624
c20db43f
PE
12625 * intervals.h (struct interval): Use EMACS_INT for members
12626 where EMACS_UINT might cause problems. See
12627 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12628 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12629 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12630 All uses changed.
37aa2f85
PE
12631 (offset_intervals): Tell GCC not to worry about length overflow
12632 when negating a negative length.
c20db43f 12633
2538aa2f
PE
12634 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12635 (overrun_check_free): Likewise.
12636
f2d3008d
PE
12637 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12638 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12639 word size.
12640
ec8df744
PE
12641 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12642 (gnutls_make_error): Rename local to avoid shadowing.
12643 (gnutls_emacs_global_deinit): ifdef out; not used.
12644 (Fgnutls_boot): Use const for pointer to readonly storage.
12645 Comment out unused local. Fix pointer signedness problems.
12646
640ee02d
PE
12647 * lread.c (openp): Don't stuff size_t into an 'int'.
12648 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12649 about possible signed overflow.
12650
6048fb2a
PE
12651 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12652 (GDK_KEY_g): Don't define if already defined.
12653 (xg_prepare_tooltip): Avoid pointer signedness problem.
12654 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12655
fa3c87e1
PE
12656 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12657 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12658
2172544b
PE
12659 * xfns.c (Fx_window_property): Simplify a bit,
12660 to make a bit faster and to avoid GCC 4.6.0 warning.
12661 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12662
9b821a21
PE
12663 * fns.c (internal_equal): Don't assume size_t fits in int.
12664
3c616cfa
PE
12665 * alloc.c (compact_small_strings): Tighten assertion a little.
12666
c2982e87
PE
12667 Replace pEd with more-general pI, and fix some printf arg casts.
12668 * lisp.h (pI): New macro, generalizing old pEd macro to other
12669 conversion specifiers. For example, use "...%"pI"d..." rather
12670 than "...%"pEd"...".
12671 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12672 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12673 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12674 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12675 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12676 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12677 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12678 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12679 64-bit hosts.
12680 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12681 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12682 * print.c (safe_debug_print, print_object): Likewise.
12683 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12684 to int.
6f04d126
PE
12685 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12686 avoiding the 0 flag, which is not portable.
c2982e87
PE
12687 * process.c (Fmake_network_process): Use pI to avoid cast.
12688 * region-cache.c (pp_cache): Likewise.
12689 * xdisp.c (decode_mode_spec): Likewise.
12690 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12691 behavior on 64-bit hosts with printf arg.
6f04d126 12692 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12693 (x_stop_queuing_selection_requests): Likewise.
12694 (x_get_window_property): Don't truncate byte count to an 'int'
12695 when tracing.
0b432f21 12696
5e073ec7
PE
12697 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12698 here, since it parses constructs like leading '-' and spaces,
12699 which are not wanted; and it overflows with large numbers.
12700 Instead, simply match F[0-9]+, which is what is wanted anyway.
12701
36372bf9
PE
12702 * alloc.c: Remove unportable assumptions about struct layout.
12703 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12704 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12705 (allocate_vectorlike, make_pure_vector): Use the new macros,
12706 plus offsetof, to remove unportable assumptions about struct layout.
12707 These assumptions hold on all porting targets that I know of, but
12708 they are not guaranteed, they're easy to remove, and removing them
12709 makes further changes easier.
12710
0b432f21
PE
12711 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12712 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12713 (string_overrun_cookie): Now const. Use initializers that
12714 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12715 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12716 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12717 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12718 multiple of sizeof (EMACS_INT); it need not be, if
12719 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12720 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12721
895009e1
JB
127222011-04-26 Juanma Barranquero <lekktu@gmail.com>
12723
12724 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12725
6a7a1b0b
TZ
127262011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12727
12728 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12729 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12730 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12731
841a1577 127322011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12733
12734 * lisp.h (Qdebug): List symbol.
895009e1 12735 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12736 * keyboard.c (debug-on-event): New variable.
12737 (handle_user_signal): Break into debugger when debug-on-event
12738 matches the current signal symbol.
12739
f2d3ba6f
DN
127402011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12741
12742 * alloc.c (check_sblock, check_string_bytes)
12743 (check_string_free_list): Convert to standard C.
12744
42ce4c63
TZ
127452011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12746
12747 * w32.c (emacs_gnutls_push): Fix typo.
12748
825cd63c
EZ
127492011-04-25 Eli Zaretskii <eliz@gnu.org>
12750
fb11d64d
EZ
12751 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12752 "cast to pointer from integer of different size".
12753
825cd63c
EZ
12754 Improve doprnt and its use in verror. (Bug#8545)
12755 * doprnt.c (doprnt): Document the set of format control sequences
12756 supported by the function. Use SAFE_ALLOCA instead of always
12757 using `alloca'.
12758
12759 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12760 is one byte too soon. Don't use xrealloc; instead xfree and
12761 xmalloc anew.
12762
e061a11b
TZ
127632011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12764
12765 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12766 callbacks stage.
12767
12768 * gnutls.c: Renamed global_initialized to
12769 gnutls_global_initialized. Added internals for the
12770 :verify-hostname-error, :verify-error, and :verify-flags
12771 parameters of `gnutls-boot' and documented those parameters in the
12772 docstring. Start callback support.
9173deec
JB
12773 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12774 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12775 on error. Return error code.
e061a11b
TZ
12776 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12777 (emacs_gnutls_read): Likewise.
12778 (Fgnutls_boot): Return handshake error code.
12779 (emacs_gnutls_handle_error): New function.
12780 (wsaerror_to_errno): Likewise.
12781
12782 * w32.h (emacs_gnutls_pull): Add prototype.
12783 (emacs_gnutls_push): Likewise.
12784
12785 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12786 (emacs_gnutls_push): Likewise.
12787
127882011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12789
12790 * process.c (wait_reading_process_output): Check if GnuTLS
12791 buffered some data internally if no FDs are set for TLS
12792 connections.
12793
12794 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12795 (LIBS): Link to USER_LIBS.
12796 ($(BLD)/gnutls.$(0)): New target.
12797
fa6996bc
EZ
127982011-04-24 Eli Zaretskii <eliz@gnu.org>
12799
eb35682e
EZ
12800 * xdisp.c (handle_single_display_spec): Rename the
12801 display_replaced_before_p argument into display_replaced_p, to
12802 make it consistent with the commentary. Fix typos in the
12803 commentary.
12804
e2ad650c
EZ
12805 * textprop.c (syms_of_textprop): Remove dead code.
12806 (copy_text_properties): Delete obsolete commentary about an
12807 interface that was deleted long ago. Fix typos in the description
12808 of arguments.
12809
1b2de274
EZ
12810 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12811 to changes in oldXMenu/XMenu.h from 2011-04-16.
12812 <menu_help_message, prev_menu_help_message>: Constify.
12813 (IT_menu_make_room): menu->help_text is now `const char **';
12814 adjust.
12815
12816 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12817 to changes in oldXMenu/XMenu.h from 2011-04-16.
12818 (struct XMenu): Declare `help_text' `const char **'.
12819
12820 * xfaces.c <Qunspecified>: Make extern again.
12821
12822 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12823 required by POSIX.
1b2de274 12824
762b15be
EZ
12825 * doc.c (get_doc_string): Improve the format passed to `error'.
12826
12827 * doprnt.c (doprnt): Improve commentary.
12828
12829 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12830
12831 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12832 them with etags.
12833
f1052e5d
EZ
12834 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12835 changes in globals.h immediately force recompilation.
762b15be
EZ
12836 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12837 $(CURDIR)/s/ms-w32.h.
12838 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12839
fa6996bc
EZ
12840 * character.c (Fchar_direction): Function deleted.
12841 (syms_of_character): Don't defsubr it.
12842 <char-direction-table>: Deleted.
12843
e6c3da20
EZ
128442011-04-23 Eli Zaretskii <eliz@gnu.org>
12845
12846 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12847 * doprnt.c: Include limits.h.
12848 (SIZE_MAX): New macro.
04f2d78b
CB
12849 (doprnt): Return a size_t value. 2nd arg is now size_t.
12850 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12851 Improve overflow protection. Support `l' modifier for integer
12852 conversions. Support %l conversion. Don't assume an EMACS_INT
12853 argument for integer conversions and for %c.
12854
12855 * lisp.h (doprnt): Restore prototype.
12856
12857 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12858 $(SRC)/character.h.
12859
12860 * Makefile.in (base_obj): Add back doprnt.o.
12861
12862 * deps.mk (doprnt.o): Add back prerequisites.
12863 (callint.o): Depend on character.h.
12864
12865 * eval.c (internal_lisp_condition_case): Include the handler
12866 representation in the error message.
12867 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12868 when breaking from the loop.
12869
12870 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12871
12872 * callint.c (Fcall_interactively): When displaying error message
12873 about invalid control letter, pass the character's codepoint, not
12874 a pointer to its multibyte form. Improve display of the character
12875 in octal and display also its hex code.
12876
12877 * character.c (char_string): Use %x to display the (unsigned)
12878 codepoint of an invalid character, to avoid displaying a bogus
12879 negative value.
12880
12881 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12882 `error', not SYMBOL_NAME itself.
12883
12884 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12885 character arguments to `error'.
12886
12887 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12888 to `error' in error message about FINAL_CHAR argument. Make sure
12889 FINAL_CHAR is a character, and use %c when it is passed as
12890 argument to `error'.
12891
4ffd0d6b 128922011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12893
12894 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12895
12896 * w32.c: Include <time.h>.
12897 (sys_localtime): New function.
12898
4ffd0d6b 128992011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12900
12901 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12902
4ffd0d6b 12903 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12904
4ffd0d6b 129052011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12906
4ffd0d6b
GM
12907 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12908 zombies (Bug#8467).
aac0c6e3 12909
04c56954
EZ
129102011-04-19 Eli Zaretskii <eliz@gnu.org>
12911
12912 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12913 gl_state.e_property when gl_state.object is Qt.
12914
12915 * insdel.c (make_gap_larger): Remove limitation of buffer size
12916 to <= INT_MAX.
12917
16a43933
CY
129182011-04-18 Chong Yidong <cyd@stupidchicken.com>
12919
12920 * xdisp.c (lookup_glyphless_char_display)
12921 (produce_glyphless_glyph): Handle cons cell entry in
12922 glyphless-char-display.
12923 (Vglyphless_char_display): Document it.
12924
12925 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12926 glyphless-char-display.
12927
4581706e
CY
129282011-04-17 Chong Yidong <cyd@stupidchicken.com>
12929
12930 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12931
12932 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12933
12934 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12935 definition for no-X builds.
12936
4887c6e2 129372011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12938
fd35b6f9
PE
12939 Static checks with GCC 4.6.0 and non-default toolkits.
12940
5c1ccb01
PE
12941 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12942
006c5daa
PE
12943 * process.c (keyboard_bit_set): Define only if SIGIO.
12944 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12945 (send_process): Repair possible setjmp clobbering.
12946
efc736d3
PE
12947 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12948
4e2fe2e6
PE
12949 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12950
f97334a2
PE
12951 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12952
4e75f29d
PE
12953 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12954 Define only if needed.
12955
90efadd1
PE
12956 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12957 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12958 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12959
3c647824
PE
12960 * dispextern.h (struct redisplay_interface): Rename param
12961 to avoid shadowing.
e264f262 12962 * termhooks.h (struct terminal): Likewise.
761383f4 12963 * xterm.c (xembed_send_message): Likewise.
3c647824 12964
b58c5c4a
PE
12965 * insdel.c (make_gap_smaller): Define only if
12966 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12967
cad59032
PE
12968 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12969 it.
12970
c339dc2e
PE
12971 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12972 so that we aren't warned about unused symbols.
12973
91a3e27b
PE
12974 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12975
399c71d3 12976 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12977
8ffc96f5
PE
12978 * xfns.c (x_real_positions): Mark locals as initialized.
12979
eef9bc79
PE
12980 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12981
098db9dd
PE
12982 * xterm.c: Fix problems found by static analysis with other toolkits.
12983 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12984 (x_dispatch_event): Declare static if USE_GTK, and
12985 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12986 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12987 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12988 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12989 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12990
eb18f6cc
PE
12991 * xmenu.c (menu_help_callback): Pointer type fixes.
12992 Use const pointers when pointing at readonly data. Avoid pointer
12993 signedness clashes.
12994 (FALSE): Remove unused macro.
12995 (update_frame_menubar): Remove unused decl.
12996
1fe72bf8
PE
12997 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12998
60d9e1db
PE
12999 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13000 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13001 (single_menu_item): Rename local to avoid shadowing.
13002
39261c26
PE
13003 * keyboard.c (make_lispy_event): Remove unused local var.
13004
018c5e19
PE
13005 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13006 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13007
63d2b86e
PE
13008 * bitmaps: Change bitmaps from unsigned char back to the X11
13009 compatible char. Avoid the old compiler warnings about
13010 out-of-range initializers by using, for example, '\xab' rather
13011 than 0xab.
13012
aefd87e1
PE
13013 * xgselect.c (xgselect_initialize): Check vs interface
13014 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13015
bf501fb9
PE
13016 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13017
e9829fdf
PE
13018 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13019 to read-only memory.
13020
1086c095
PE
13021 * fns.c (vector): Remove; this old hack is no longer needed.
13022
2baccd04 13023 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13024 Remove unused var.
dde42981 13025 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13026
72391843 13027 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13028
436c16df 13029 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13030 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13031 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13032
92bb796d 13033 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13034 (x_term_init): Remove local to avoid shadowing.
92bb796d 13035
764430a3 13036 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13037
13038 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13039 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13040
d1dfb56c
EZ
130412011-04-16 Eli Zaretskii <eliz@gnu.org>
13042
c4354cb4
EZ
13043 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13044
d1dfb56c
EZ
13045 Fix regex.c, syntax.c and friends for buffers > 2GB.
13046 * syntax.h (struct gl_state_s): Declare character position members
13047 EMACS_INT.
13048
13049 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13050
04f2d78b
CB
13051 * textprop.c (verify_interval_modification, interval_of):
13052 Declare arguments EMACS_INT.
d1dfb56c
EZ
13053
13054 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13055 EMACS_INT.
13056
13057 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13058
13059 * indent.c (Fvertical_motion): Local variable it_start is now
13060 EMACS_INT.
13061
13062 * regex.c (re_match, re_match_2, re_match_2_internal)
13063 (bcmp_translate, regcomp, regexec, print_double_string)
13064 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13065 (re_compile_pattern, re_exec): Declare arguments and local
13066 variables `size_t' and `ssize_t' and return values `regoff_t', as
13067 appropriate.
13068 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13069 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13070 <compile_stack_type>: `size' and `avail' are now `size_t'.
13071
13072 * regex.h <regoff_t>: Use ssize_t, not int.
13073 (re_search, re_search_2, re_match, re_match_2): Arguments that
13074 specify buffer/string position and length are now ssize_t and
13075 size_t. Return type is regoff_t.
13076
613052cd
BK
130772011-04-16 Ben Key <bkey76@gmail.com>
13078
13079 * nsfont.m: Fixed bugs in ns_get_family and
13080 ns_descriptor_to_entity that were caused by using free to
13081 deallocate memory blocks that were allocated by xmalloc (via
13082 xstrdup). This caused Emacs to crash when compiled with
13083 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13084 --enable-checking=xmallocoverrun). xfree is now used to
13085 deallocate these memory blocks.
13086
4170f62f 130872011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13088
71b41406
PE
13089 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13090
9587a89d
PE
13091 emacs_write: Accept and return EMACS_INT for sizes.
13092 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13093 et seq.
13094 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13095 Accept and return EMACS_INT.
13096 (emacs_gnutls_write): Return the number of bytes written on
13097 partial writes.
13098 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13099 (emacs_read, emacs_write): Remove check for negative size, as the
13100 Emacs source code has been audited now.
9587a89d
PE
13101 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13102 (emacs_read, emacs_write): Use it.
273a5f82
PE
13103 * process.c (send_process): Adjust to the new signatures of
13104 emacs_write and emacs_gnutls_write. Do not attempt to store
13105 a byte offset into an 'int'; it might overflow.
9587a89d 13106 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13107
3e047f51
PE
13108 * sound.c: Don't assume sizes fit in 'int'.
13109 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13110 Return EMACS_INT, not int.
3e047f51 13111 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13112 Accept EMACS_INT, not int.
13113 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13114 record read return values.
13115
cc39a9db
BK
131162011-04-15 Ben Key <bkey76@gmail.com>
13117
c9d0ec6d
JB
13118 * keyboard.c (Qundefined): Don't declare static since it is used
13119 in nsfns.m.
13120 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13121 static since they are used in nsfont.m.
cc39a9db 13122
6c60eb9f
SM
131232011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13124
13125 * process.c (Qprocessp): Don't declare static.
13126 * lisp.h (Qprocessp): Declare again.
13127
7990b61a
JB
131282011-04-15 Juanma Barranquero <lekktu@gmail.com>
13129
13130 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13131
5d4cb038
PE
131322011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13133
8bd7b830 13134 Improve C-level modularity by making more things 'static'.
cd64ea1d 13135
e3b27b31
PE
13136 Don't publish debugger-only interfaces to other modules.
13137 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13138 (verify_bytepos, count_markers): Move decls to the only modules
13139 that need them.
13140 * region-cache.h (pp_cache): Likewise.
13141 * window.h (check_all_windows): Likewise.
13142 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13143
5d4cb038
PE
13144 * sysdep.c (croak): Now static, if
13145 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13146 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13147
13148 * alloc.c (refill_memory_reserve): Now static if
13149 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13150 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13151
e87b6180
PE
13152 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13153 Define only if USE_LUCID.
13154
ac64929e
PE
13155 * xrdb.c (x_customization_string, x_rm_string): Now static.
13156
6f37259d
PE
13157 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13158 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13159
1683e3ab
PE
13160 * xdisp.c (draw_row_with_mouse_face): Now static.
13161 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13162
de9c2632
PE
13163 * window.h (check_all_windows): Mark externally visible.
13164
2b96acb7
PE
13165 * window.c (window_deletion_count): Now static.
13166
13167 * undo.c: Make symbols static if they're not exported.
13168 (last_undo_buffer, last_boundary_position, pending_boundary):
13169 Now static.
13170
50436f33
PE
13171 * textprop.c (interval_insert_behind_hooks): Now static.
13172 (interval_insert_in_front_hooks): Likewise.
13173
64520e5c
PE
13174 * term.c: Make symbols static if they're not exported.
13175 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13176 (max_frame_lines, tty_set_terminal_modes):
13177 (tty_reset_terminal_modes, tty_turn_off_highlight):
13178 (get_tty_terminal): Now static.
13179 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13180 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13181 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13182 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13183 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13184
1fa53021
PE
13185 * sysdep.c: Make symbols static if they're not exported.
13186 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13187 Now static.
13188 (sigprocmask_set, full_mask): Remove; unused.
13189 (wait_debugging): Mark as visible.
13190 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13191 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13192
d4b43b22
PE
13193 * syntax.c (syntax_temp): Define only if !__GNUC__.
13194
b7c513d0
PE
13195 * sound.c (current_sound_device, current_sound): Now static.
13196
989b29ad
PE
13197 * search.c (searchbufs, searchbuf_head): Now static.
13198
13a55a78
PE
13199 * scroll.c (scroll_cost): Remove; unused.
13200 * dispextern.h (scroll_cost): Remove decl.
13201
de68a1fc
PE
13202 * region-cache.h (pp_cache): Mark as externally visible.
13203
40ccffa6
PE
13204 * process.c: Make symbols static if they're not exported.
13205 (process_tick, update_tick, create_process, chan_process):
13206 (Vprocess_alist, proc_buffered_char, datagram_access):
13207 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13208 (deactivate_process): Mark defn as static, as well as decl.
13209 * lisp.h (create_process): Remove decl.
13210 * process.h (chan_process, Vprocess_alist): Remove decls.
13211
ad64fc97
PE
13212 * print.c: Make symbols static if they're not exported.
13213 (print_depth, new_backquote_output, being_printed, print_buffer):
13214 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13215 (print_interval, print_number_index, initial_stderr_stream):
13216 Now static.
13217 * lisp.h (Fprinc): Remove decl.
13218 (debug_output_compilation_hack): Mark as externally visible.
13219
adddb265
PE
13220 * sysdep.c (croak): Move decl from here to syssignal.h.
13221 * syssignal.h (croak): Put it here, so the API can be checked when
13222 'croak' is called from dissociate_if_controlling_tty.
13223
1717ede2
PE
13224 * minibuf.c: Make symbols static if they're not exported.
13225 (minibuf_save_list, choose_minibuf_frame): Now static.
13226 * lisp.h (choose_minibuf_frame): Remove decl.
13227
fa5fb2bc
PE
13228 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13229
1e3890d1
PE
13230 * lread.c: Make symbols static if they're not exported.
13231 (read_objects, initial_obarray, oblookup_last_bucket_number):
13232 Now static.
13233 (make_symbol): Remove; unused.
13234 * lisp.h (initial_obarray, make_symbol): Remove decls.
13235
8a1414fa
PE
13236 * keyboard.c: Make symbols static if they're not exported.
13237 (single_kboard, recent_keys_index, total_keys, recent_keys):
13238 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13239 (this_single_command_key_start, echoing, last_auto_save):
13240 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13241 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13242 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13243 (Vlispy_mouse_stem, double_click_count):
13244 Now static.
13245 (force_auto_save_soon): Define only if SIGDANGER.
13246 (ignore_mouse_drag_p): Now static if
13247 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13248 (print_help): Remove; unused.
13249 (stop_character, last_timer_event): Mark as externally visible.
13250 * keyboard.h (ignore_mouse_drag_p): Declare only if
13251 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13252 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13253 * lisp.h (echoing): Remove decl.
13254 (force_auto_save_soon): Declare only if SIGDANGER.
13255 * xdisp.c (redisplay_window): Simplify code, to make it more
13256 obvious that ignore_mouse_drag_p is not accessed if !defined
13257 USE_GTK && !defined HAVE_NS.
13258
93ea6e8f
PE
13259 * intervals.c: Make symbols static if they're not exported.
13260 (merge_properties_sticky, merge_interval_right, delete_interval):
13261 Now static.
13262 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13263
77382fcc
PE
13264 * insdel.c: Make symbols static if they're not exported.
13265 However, leave prepare_to_modify_buffer alone. It's never
13266 called from outside this function, but that appears to be a bug.
13267 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13268 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13269 (adjust_after_replace_noundo): Remove; unused.
13270 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13271 (signal_before_change): Remove decls.
77382fcc 13272
9306c32e
PE
13273 * indent.c (val_compute_motion, val_vmotion): Now static.
13274
cd44d2eb
PE
13275 * image.c: Make symbols static if they're not exported.
13276 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13277 if USE_GTK.
13278 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13279 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13280
ad9a7a06
PE
13281 * fringe.c (standard_bitmaps): Now static.
13282 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13283
81626931
PE
13284 * frame.c: Make symbols static if they're not exported.
13285 (x_report_frame_params, make_terminal_frame): Now static.
13286 (get_frame_param): Now static, unless HAVE_NS.
13287 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13288 (x_get_resource_string): Remove; not used.
13289 * frame.h (make_terminal_frame, x_report_frame_params):
13290 (x_get_resource_string); Remove decls.
13291 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13292 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13293
239f9db9
PE
13294 * font.c, fontset.c: Make symbols static if they're not exported.
13295 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13296 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13297 * font.c (font_close_object): Now static.
13298 * font.h (font_close_object): Remove.
13299 * fontset.c (FONTSET_OBJLIST): Remove.
13300 (free_realized_fontset) #if-0 the body, which does nothing.
13301 (face_suitable_for_char_p): #if-0, as it's never called.
13302 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13303 * xfaces.c (face_at_string_position):
13304 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13305 since 0 is always ASCII.
13306
dfcf3579
PE
13307 * fns.c (weak_hash_tables): Now static.
13308
5045092b
PE
13309 * fileio.c: Make symbols static if they're not exported.
13310 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13311 (Vwrite_region_annotation_buffers): Now static.
13312
57a96f5c
PE
13313 * eval.c: Make symbols static if they're not exported.
13314 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13315 * lisp.h (backtrace_list): Remove decl.
13316
35f08c38
PE
13317 * emacs.c: Make symbols static if they're not exported.
13318 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13319 (fatal_error_code, fatal_error_signal_hook, standard_args):
13320 Now static.
13321 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13322 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13323 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13324 * lisp.h (fatal_error_signal_hook): Remove decl.
13325 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13326
f44bd759
PE
13327 * editfns.c: Move a (normally-unused) function to its only use.
13328 * editfns.c, lisp.h (get_operating_system_release): Remove.
13329 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13330 worth the hassle of breaking this out.
13331
b532497d
PE
13332 * xterm.c: Make symbols static if they're not exported.
13333 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13334 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13335 (x_destroy_window, x_delete_display):
13336 Now static.
13337 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13338 (x_mouse_leave): Remove; unused.
13339 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13340 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13341 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13342 Remove decls.
13343 (x_mouse_leave): Declare only if WINDOWSNT.
13344 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13345 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13346 USE_X_TOOLKIT.
13347
1675728f
PE
13348 * ftxfont.c: Make symbols static if they're not exported.
13349 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13350 HAVE_FREETYPE.
13351 * font.h (ftxfont_driver): Likewise.
13352
e4cebfca
PE
13353 * xfns.c: Make symbols static if they're not exported.
13354 (x_last_font_name, x_display_info_for_name):
13355 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13356 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13357 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13358 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13359 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13360 (last_show_tip_args): Now static.
13361 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13362 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13363 (x_screen_planes): Remove; unused.
13364 * dispextern.h (x_screen_planes): Remove decl.
13365
5bf46f05
PE
13366 * dispnew.c: Make symbols static if they're not exported.
13367 * dispextern.h (redraw_garbaged_frames, scrolling):
13368 (increment_row_positions): Remove.
13369 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13370 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13371 Now static.
13372 (redraw_garbaged_frames): Remove; unused.
13373
435f4c28
PE
13374 * xfaces.c: Make symbols static if they're not exported.
13375 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13376 Remove decls.
13377 * xterm.h (defined_color): Remove decls.
13378 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13379 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13380 (menu_face_changed_default, defined_color, free_realized_face):
13381 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13382 (ascii_face_of_lisp_face): Remove; unused.
13383
8524aef3
PE
13384 * xdisp.c: Make symbols static if they're not exported.
13385 * dispextern.h (scratch_glyph_row, window_box_edges):
13386 (glyph_to_pixel_coords, set_cursor_from_row):
13387 (get_next_display_element, set_iterator_to_next):
13388 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13389 (show_mouse_face): Remove decls
13390 * frame.h (message_buf_print): Likewise.
13391 * lisp.h (pop_message, set_message, check_point_in_composition):
13392 Likewise.
13393 * xterm.h (set_vertical_scroll_bar): Likewise.
13394 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13395 (message_buf_print, scratch_glyph_row, displayed_buffer):
13396 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13397 (get_next_display_element, show_mouse_face, window_box_edges):
13398 (frame_to_window_pixel_xy, check_point_in_composition):
13399 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13400 (glyph_to_pixel_coords): Remove; unused.
13401
16390cd2
PE
13402 * dired.c (file_name_completion): Now static.
13403
13404 * dbusbind.c (xd_in_read_queued_messages): Now static.
13405
a25f4dfa
PE
13406 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13407 * data.c (circular_list_error): Remove.
13408
14a9c8df
PE
13409 * commands.h (last_point_position, last_point_position_buffer):
13410 (last_point_position_window): Remove decls.
13411 * keyboard.c: Make these variables static.
13412
04f2d78b
CB
13413 * coding.h (coding, code_convert_region, encode_coding_gap):
13414 Remove decls.
74ab6df5
PE
13415 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13416 (iso_code_class, detect_coding, code_convert_region): Now static.
13417 (encode_coding_gap): Remove; unused.
13418
38dfbee1
PE
13419 * chartab.c (chartab_chars, chartab_bits): Now static.
13420
a2cb4e63
PE
13421 * charset.h (charset_iso_8859_1): Remove decl.
13422 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13423 Now static.
13424
127198fd
PE
13425 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13426 * ccl.c (Vccl_program_table): Now static.
13427 (check_ccl_update): Remove; unused.
13428
d85b608f
PE
13429 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13430 * category.h: ... from here.
13431 * category.c (check_category_table, set_category_set): Now static.
13432
31cd66f3
PE
13433 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13434 * lisp.h: Remove these decls.
13435
c358e587
PE
13436 * buffer.c (buffer_count): Remove unused var.
13437
e78aecca
PE
13438 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13439 so that it's not optimized away.
13440 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13441 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13442 exported only to the debugger.
13443
e192d7d3 13444 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13445 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13446
92470028
PE
13447 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13448 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13449 was inaccessible from Lisp.
13450 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13451 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13452
244ed907
PE
13453 alloc.c: Import and export fewer symbols, and remove unused items.
13454 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13455 is defined.
13456 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13457 it's not optimized away by whole-program optimization.
13458 (message_enable_multibyte, free_misc): Remove.
13459 (catchlist, handlerlist, mark_backtrace):
13460 Declare only if BYTE_MARK_STACK.
13461 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13462 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13463 (message_enable_multibyte): Remove decl.
13464 (free_misc, interval_free_list, float_block, float_block_index):
13465 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13466 (cons_free_list, last_marked_index):
13467 Now static.
13468 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13469 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13470 (mark_backtrace): Define only if BYTE_MARK_STACK.
13471 * xdisp.c (message_enable_multibyte): Now static.
13472
61c2b50e 13473 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13474 This makes it easier for human readers (and static analyzers)
13475 to see whether these variables are used from other modules.
13476 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13477 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13478 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13479 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13480 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13481 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13482 * xmenu.c, xselect.c:
13483 Declare Q* vars static if they are not used in other modules.
13484 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13485 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13486 Remove decls of unexported vars.
13487 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13488
95c82688
PE
13489 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13490
16a97296
PE
13491 Make Emacs functions such as Fatom 'static' by default.
13492 This makes it easier for human readers (and static analyzers)
13493 to see whether these functions can be called from other modules.
13494 DEFUN now defines a static function. To make the function external
13495 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13496 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13497 (Finit_image_library):
16a97296
PE
13498 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13499 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13500 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13501 Remove decls, since these functions are now static.
13502 (Funintern, Fget_internal_run_time): New decls, since these functions
13503 were already external.
95c82688 13504
16a97296
PE
13505 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13506 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13507 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13508 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13509 * keyboard.c, keymap.c, lread.c:
13510 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13511 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13512 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13513 Mark functions with DEFUE instead of DEFUN,
13514 if they are used in other modules.
13515 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13516 decls for now-static functions.
13517 * buffer.h (Fdelete_overlay): Remove decl.
13518 * callproc.c (Fgetenv_internal): Mark as internal.
13519 * composite.c (Fremove_list_of_text_properties): Remove decl.
13520 (Fcomposition_get_gstring): New forward static decl.
13521 * composite.h (Fcomposite_get_gstring): Remove decl.
13522 * dired.c (Ffile_attributes): New forward static decl.
13523 * doc.c (Fdocumntation_property): New forward static decl.
13524 * eval.c (Ffetch_bytecode): New forward static decl.
13525 (Funintern): Remove extern decl; now in .h file where it belongs.
13526 * fileio.c (Fmake_symbolic_link): New forward static decl.
13527 * image.c (Finit_image_library): New forward static decl.
13528 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13529 * intervals.h (Fprevious_property_change):
13530 (Fremove_list_of_text_properties): Remove decls.
13531 * keyboard.c (Fthis_command_keys): Remove decl.
13532 (Fcommand_execute): New forward static decl.
13533 * keymap.c (Flookup_key): New forward static decl.
13534 (Fcopy_keymap): Now static.
13535 * keymap.h (Flookup_key): Remove decl.
13536 * process.c (Fget_process): New forward static decl.
13537 (Fprocess_datagram_address): Mark as internal.
13538 * syntax.c (Fsyntax_table_p): New forward static decl.
13539 (skip_chars): Remove duplicate decl.
13540 * textprop.c (Fprevious_property_change): New forward static decl.
13541 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13542 Now internal.
13543 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13544 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13545
785bbd42
PE
13546 * editfns.c (Fformat): Remove unreachable code.
13547
8b913b57
AS
135482011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13549
13550 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13551 change. (Bug#8496)
13552
a6744a35
EZ
135532011-04-13 Eli Zaretskii <eliz@gnu.org>
13554
13555 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13556 when at ZV. (Bug#8487)
13557
e7974947
AS
135582011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13559
baad03f0
AS
13560 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13561 (Bug#8437)
13562 * keyboard.c (parse_tool_bar_item): Likewise.
13563 * sound.c (sound_cleanup, alsa_close): Likewise.
13564 * termcap.c (tgetent): Likewise.
13565 * xfns.c (x_default_font_parameter): Likewise.
13566 * xsettings.c (read_and_apply_settings): Likewise.
13567
e7974947
AS
13568 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13569 (overrun_check_free): Protoize.
13570
28272684
PE
135712011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13572
13573 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13574 since callers should never pass a negative size.
13575 Change the signature to match that of plain 'read' and 'write'; see
13576 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13577 * lisp.h: Update prototypes of emacs_write and emacs_read.
13578
11997c76
EZ
135792011-04-11 Eli Zaretskii <eliz@gnu.org>
13580
13581 * xdisp.c (redisplay_window): Don't try to determine the character
13582 position of the scroll margin if the window start point w->startp
e896f03c 13583 is outside the buffer's accessible region. (Bug#8468)
11997c76 13584
8a2cbd72
EZ
135852011-04-10 Eli Zaretskii <eliz@gnu.org>
13586
13587 Fix write-region and its subroutines for buffers > 2GB.
13588 * fileio.c (a_write, e_write): Modify declaration of arguments and
13589 local variables to support buffers larger than 2GB.
13590 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13591
13592 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13593 argument, local variables, and return value.
13594
13595 * lisp.h: Update prototypes of emacs_write and emacs_read.
13596
13597 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13598
4073e537 135992011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13600
1ebfdcb6
PE
13601 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13602
b2ded58d
PE
13603 Fix more problems found by GCC 4.6.0's static checks.
13604
7d66342c
PE
13605 * xdisp.c (vmessage): Use a better test for character truncation.
13606
bbf47d44
PE
13607 * charset.c (load_charset_map): <, not <=, for optimization,
13608 and to avoid potential problems with integer overflow.
9248994d 13609 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13610 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13611 * editfns.c (Fformat): Likewise.
1e69125e 13612 * syntax.c (skip_chars): Likewise.
3befa583 13613
e3019616
PE
13614 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13615 This also lets GCC 4.6.0 generate slightly better loop code.
13616
becfa255
PE
13617 * callint.c (Fcall_interactively): <, not <=, for optimization.
13618 (Fcall_interactively): Count the number of arguments produced,
13619 not the number of arguments given. This is simpler and lets GCC
13620 4.6.0 generate slightly better code.
13621
dae0cd48
PE
13622 * ftfont.c: Distingish more carefully between FcChar8 and char.
13623 The previous code passed unsigned char * to a functions like
13624 strlen and xstrcasecmp that expect char *, which does not
13625 conform to the C standard.
13626 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13627 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13628 char * when the C standard requires it.
13629
76032d70
PE
13630 * keyboard.c (read_char): Remove unused var.
13631
eb3f1cc8
PE
13632 * eval.c: Port to Windows vsnprintf (Bug#8435).
13633 Include <limits.h>.
13634 (SIZE_MAX): Define if the headers do not.
13635 (verror): Do not give up if vsnprintf returns a negative count.
13636 Instead, grow the buffer. This ports to Windows vsnprintf, which
13637 does not conform to C99. Problem reported by Eli Zaretskii.
13638 Also, simplify the allocation scheme, by avoiding the need for
13639 calling realloc, and removing the ALLOCATED variable.
13640
70476b54
PE
13641 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13642
12020a9e
PE
13643 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13644 But keep the doprint source code for now, as we might revamp it
13645 and use it again (Bug#8435).
ea6c7ae6
PE
13646 * lisp.h (doprnt): Remove.
13647 * Makefile.in (base_obj): Remove doprnt.o.
13648 * deps.mk (doprnt.o): Remove.
13649
5fdb398c
PE
13650 error: Print 32- and 64-bit integers portably (Bug#8435).
13651 Without this change, on typical 64-bit hosts error ("...%d...", N)
13652 was used to print both 32- and 64-bit integers N, which relied on
13653 undefined behavior.
61bdb816 13654 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13655 * lisp.h (error, verror): Mark as printf-like functions.
13656 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13657 Report overflow in size calculations when allocating printf buffer.
13658 Do not truncate output string at its first null byte.
13659 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13660 Truncate the output at a character boundary, since vsnprintf does not
13661 do that.
13662 * charset.c (check_iso_charset_parameter): Convert internal
13663 character to string before calling 'error', since %c now has the
13664 printf meaning.
13665 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13666 overflow when computing char to be passed to 'error'. Do not
13667 pass Lisp_Object to 'error'; pass the integer instead.
13668 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13669 formatted with plain %d.
13670
b189fa66
PE
13671 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13672
bff87ef0
PE
13673 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13674
7e2cac20
PE
13675 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13676
ce4d90b5
PE
13677 * xterm.c (x_catch_errors): Remove duplicate declaration.
13678
266c9547
PE
13679 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13680
79c49ad2
PE
13681 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13682
368f4090
JM
136832011-04-10 Jim Meyering <meyering@redhat.com>
13684
13685 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13686 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13687 return ssize_t not "int", and use size_t as the buffer length.
13688 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13689 * gnutls.h: Update declarations.
13690 * process.c (read_process_output): Use ssize_t, to match.
13691 (send_process): Likewise.
13692
a32d4040
CY
136932011-04-09 Chong Yidong <cyd@stupidchicken.com>
13694
13695 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13696
8546720e 136972011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13698
04f2d78b
CB
13699 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13700 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13701
8546720e
GM
13702 * xterm.c (handle_one_xevent):
13703 * xmenu.c (create_and_show_popup_menu):
13704 * xselect.c (x_decline_selection_request)
13705 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13706
0a2f5c1a 137072011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13708
13709 Fix some uses of `int' instead of EMACS_INT.
13710 * search.c (string_match_1, fast_string_match)
13711 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13712 (scan_buffer, find_next_newline_no_quit)
13713 (find_before_next_newline, search_command, Freplace_match)
13714 (Fmatch_data): Make some `int' variables be EMACS_INT.
13715
13716 * xdisp.c (display_count_lines): 3rd argument and return value now
13717 EMACS_INT. All callers changed.
13718 (pint2hrstr): Last argument is now EMACS_INT.
13719
13720 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13721 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13722 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13723 (decode_coding_utf_16, decode_coding_emacs_mule)
13724 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13725 (decode_coding_ccl, decode_coding_charset)
13726 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13727 (decode_coding_iso_2022, decode_coding_emacs_mule)
13728 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13729 <char_offset, last_offset>: Declare EMACS_INT.
13730 (encode_coding_utf_8, encode_coding_utf_16)
13731 (encode_coding_emacs_mule, encode_invocation_designation)
13732 (encode_designation_at_bol, encode_coding_iso_2022)
13733 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13734 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13735 Declare EMACS_INT.
13736 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13737 (encode_invocation_designation): Last argument P_NCHARS is now
13738 EMACS_INT.
13739 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13740 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13741
13742 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13743 All users changed.
13744
13745 * ccl.c (Fccl_execute_on_string): Declare some variables
13746 EMACS_INT.
13747
8546720e 137482011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13749
13750 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13751
4e19a977
CS
137522011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13753
13754 * process.c (Fformat_network_address): Doc fix.
13755
87302331
R
137562011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13757
ee7683eb 13758 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13759
cbb59342
CY
137602011-04-08 Chong Yidong <cyd@stupidchicken.com>
13761
13762 * keyboard.c (read_char): Call Lisp function help-form-show,
13763 instead of using internal_with_output_to_temp_buffer.
13764 (Qhelp_form_show): New var.
e0d38eeb 13765 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13766
13767 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13768
13769 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13770
e67a13ab
CY
137712011-04-06 Chong Yidong <cyd@stupidchicken.com>
13772
04f2d78b
CB
13773 * process.c (Flist_processes): Remove to Lisp.
13774 (list_processes_1): Delete.
e67a13ab 13775
973f782d
EZ
137762011-04-06 Eli Zaretskii <eliz@gnu.org>
13777
7c106b1e
EZ
13778 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13779
973f782d
EZ
13780 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13781
41cf7d1a 137822011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13783
ca23cc88
PE
13784 Fix more problems found by GCC 4.6.0's static checks.
13785
f390e2d5
PE
13786 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13787
42eea0d0
PE
13788 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13789
b69769da 13790 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13791
f9541e84
PE
13792 * xdisp.c (vmessage): Mark as a printf-like function.
13793
13841b55
PE
13794 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13795
c136c10f
PE
13796 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13797
5e2d4a30
PE
13798 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13799 printf-like functions.
13800 (tiff_load): Add casts to remove these marks before passing them
13801 to system-supplied API.
13802
583f48b9
PE
13803 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13804
b25d760e
PE
13805 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13806 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13807 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13808 directly, rather than having caller test rule sign. This avoids
13809 some unnecessary tests.
13810 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13811 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13812 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13813
bc7b6697 13814 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13815 (xfont_open): Avoid unnecessary tests.
bc7b6697 13816
27ccc379
PE
13817 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13818
dcd5c89a
PE
13819 * composite.h, composite.c (composition_gstring_put_cache):
13820 Use EMACS_INT, not int, for length.
13821
b13a45c6
PE
13822 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13823 breaking out part of COMPOSITION_DECODE_RULE.
13824 (COMPOSITION_DECODE_RULE): Use it.
13825 * composite.c (get_composition_id): Remove unused local vars,
13826 by using the new macro.
13827
1e792e4d
PE
13828 * textprop.c (set_text_properties_1): Change while to do-while,
13829 since the condition is always true at first.
13830
dc6c6455 13831 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13832 (interval_deletion_adjustment): Return unsigned value.
13833 All uses changed.
dc6c6455 13834
aba7731a
PE
13835 * process.c (list_processes_1, create_pty, read_process_output):
13836 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13837 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13838 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13839 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13840 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13841
fdfc4bf3
PE
13842 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13843
fca8fe46 13844 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13845 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13846
06a0259a 13847 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13848 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13849 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13850
e7b9e80f
PE
13851 * print.c (print_error_message): Avoid int overflow.
13852
56201685
PE
13853 * font.c (font_list_entities): Redo for clarity,
13854 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13855
78834453 13856 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13857 (font_score): Avoid potential overflow in diff calculation.
78834453 13858
0bc0b309 13859 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13860 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13861
e610eaca
PE
13862 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13863
b895abce
PE
13864 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13865 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13866 can always succeed if overflow has undefined behavior.
13867
1f1d9321 13868 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13869 (wordify): Omit three unnecessary tests.
1f1d9321 13870
c59478bc
PE
13871 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13872 All callers changed. This avoids the need for an unused var.
13873
79b73827
PE
13874 * casefiddle.c (casify_region): Remove var that is set but not used.
13875
a4db5dfe
PE
13876 * dired.c (file_name_completion): Remove var that is set but not used.
13877
43aae36e
PE
13878 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13879
2a47c44d 13880 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13881 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13882
a37c69bf
PE
13883 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13884 Check for integer overflow on size calculations.
13885
328ab8e7
PE
13886 * buffer.c (Fprevious_overlay_change): Remove var that is set
13887 but not used.
13888
e5a2a5cb
PE
13889 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13890 Remove vars that are set but not used.
8d84a6eb 13891 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13892 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13893
a60e5f68
PE
13894 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13895
f661cb61 13896 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13897 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13898
f0397f5a
PE
13899 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13900 that are set but not used.
13901
8664db06 13902 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13903 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13904
6abdaa4a
PE
13905 * xselect.c (x_get_local_selection, x_handle_property_notify):
13906 Remove vars that are set but not used.
13907
0ce7538d 13908 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13909 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13910
9ae848fc
PE
13911 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13912 Remove var that is set but not used.
0b918413
PE
13913 (scroll_bar_windows_size): Now size_t, not int.
13914 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13915 Check for overflow.
9ae848fc 13916
a5a62657
PE
13917 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13918 (map_tty_color) [!defined MSDOS]: Likewise.
13919
5c5cdd39
PE
13920 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13921
66ebf983
PE
13922 * coding.c: Remove vars that are set but not used.
13923 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13924 All callers changed.
13925 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13926 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13927 (decode_coding_charset): Remove vars that are set but not used.
13928
1be4d761
PE
13929 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13930 that is set but not used.
13931
47553fa8
PE
13932 * print.c (print_object): Remove var that is set but not used.
13933
1f7196bf 13934 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13935 The gnulib version avoids calling malloc in the usual case,
13936 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13937 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13938 * filelock.c (current_lock_owner): Likewise.
13939 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13940 * sysdep.c: Include allocator.h, careadlinkat.h.
13941 (emacs_no_realloc_allocator): New static constant.
13942 (emacs_readlink): New function.
fdb61804
PE
13943 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13944 ../lib/careadlinkat.h.
d1fdcab7 13945
f84c17c7
SM
139462011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13947
13948 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13949 first non-nil return value).
13950
ef3862ad
JD
139512011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13952
13953 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13954 if not defined (Bug#8403).
13955
376a7006
JB
139562011-04-02 Juanma Barranquero <lekktu@gmail.com>
13957
13958 * xdisp.c (display_count_lines): Remove parameter `start',
13959 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13960 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13961 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13962 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13963 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13964 and thereabouts. All callers changed.
13965 (get_per_char_metric): Remove parameter `f', unused since
13966 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13967
6ca3801d
JM
139682011-04-02 Jim Meyering <meyering@redhat.com>
13969
13970 do not dereference NULL upon failed strdup
13971 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13972 (ns_get_family): Likewise.
13973
d8e2b5ba
JB
139742011-04-02 Juanma Barranquero <lekktu@gmail.com>
13975
13976 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13977
8c74fcbd
JD
139782011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13979
13980 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13981 later (Bug#8403).
13982
7200d79c
SM
139832011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13984
03408648 13985 Add lexical binding.
7200d79c 13986
03408648
SM
13987 * window.c (Ftemp_output_buffer_show): New fun.
13988 (Fsave_window_excursion):
13989 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13990
13991 * lread.c (lisp_file_lexically_bound_p): New function.
13992 (Fload): Bind Qlexical_binding.
13993 (readevalloop): Remove `evalfun' arg.
13994 Bind Qinternal_interpreter_environment.
13995 (Feval_buffer): Bind Qlexical_binding.
13996 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13997 Mark as dynamic.
13998 (syms_of_lread): Declare `lexical-binding'.
13999
14000 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14001
14002 * keyboard.c (eval_dyn): New fun.
14003 (menu_item_eval_property): Use it.
ca105506
SM
14004
14005 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14006
03408648
SM
14007 * fns.c (concat, mapcar1): Accept byte-code-functions.
14008
14009 * eval.c (Fsetq): Handle lexical vars.
14010 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14011 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14012 (FletX, Flet): Obey lexical binding.
14013 (Fcommandp): Handle closures.
14014 (Feval): New `lexical' arg.
14015 (eval_sub): New function extracted from Feval. Use it almost
14016 everywhere where Feval was used. Look up vars in lexical env.
14017 Handle closures.
14018 (Ffunctionp): Move from subr.el.
14019 (Ffuncall): Handle closures.
14020 (apply_lambda): Remove `eval_flags'.
14021 (funcall_lambda): Handle closures and new byte-code-functions.
14022 (Fspecial_variable_p): New function.
14023 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14024 but without exporting it to Lisp.
23aba0ea 14025
23aba0ea 14026 * doc.c (Fdocumentation, store_function_docstring):
03408648 14027 * data.c (Finteractive_form): Handle closures.
23aba0ea 14028
03408648
SM
14029 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14030 interactive spec.
ba83908c 14031
04f2d78b
CB
14032 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14033 New byte-codes.
03408648
SM
14034 (exec_byte_code): New function extracted from Fbyte_code to handle new
14035 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14036
03408648 14037 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14038
03408648 14039 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14040
e2abce01
JB
140412011-03-31 Juanma Barranquero <lekktu@gmail.com>
14042
14043 * xdisp.c (redisplay_internal): Fix prototype.
14044
63696a73 140452011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14046
63696a73 14047 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14048 (try_scrolling): Use it when setting scroll_limit.
14049 Limit scrolling to 100 screen lines.
63696a73
EZ
14050 (redisplay_window): Even when falling back on "recentering",
14051 position point in the window according to scroll-conservatively,
14052 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14053
14054 (try_scrolling): When point is above the window, allow searching
14055 as far as scroll_max, or one screenful, to compute vertical
14056 distance from PT to the scroll margin position. This prevents
14057 try_scrolling from unnecessarily failing when
14058 scroll-conservatively is set to a value slightly larger than the
14059 window height. Clean up the case of PT below the margin at bottom
14060 of window: scroll_max can no longer be INT_MAX. When aggressive
14061 scrolling is in use, don't let point enter the opposite scroll
14062 margin as result of the scroll.
14063 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14064 threshold of 100 lines for never-recentering scrolling.
14065
e4cc2dfc
JB
140662011-03-31 Juanma Barranquero <lekktu@gmail.com>
14067
14068 * dispextern.h (move_it_by_lines):
14069 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14070 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14071 (message_log_check_duplicate): Remove parameters `prev_bol' and
14072 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14073 (redisplay_internal): Remove parameter `preserve_echo_area',
14074 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14075
14076 * indent.c (Fvertical_motion):
14077 * window.c (window_scroll_pixel_based, Frecenter):
14078 Don't pass `need_y_p' to `move_it_by_lines'.
14079
1c470562
SM
140802011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14081
44f230aa
SM
14082 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14083 steal a few bits to be more compact.
14084 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14085 Remove unneeded casts.
14086
1c470562
SM
14087 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14088
888adce9
ZK
140892011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14090
14091 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14092 binding" message (bug#7967).
14093
f838ed7b
PE
140942011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14095
77861b95
PE
14096 Fix more problems found by GCC 4.6.0's static checks.
14097
de6dbc14
PE
14098 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14099 Remove unused local var.
14100
f838ed7b
PE
14101 * editfns.c (Fmessage_box): Remove unused local var.
14102
792c7b2b
PE
14103 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14104 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14105 Omit unused local vars.
c499e557 14106 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14107 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14108 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14109 Omit unused local var.
14110
ba0165e1
PE
14111 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14112 Don't assume string length fits in int.
32ad8845 14113 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14114 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14115
3c59b4c9
PE
14116 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14117 instead of alloca (Bug#8344).
14118
a3eed478 14119 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14120 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14121
eb4d412d
PE
14122 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14123
1658b401
PE
14124 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14125 concerns.
14126
14127 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14128
14129 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14130
9a2c6e05
PE
14131 * keyboard.c (syms_of_keyboard): Use the same style as later
14132 in this function when indexing through an array. This also
14133 works around GCC bug 48267.
14134
03d0a109
PE
14135 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14136
44f730c8
PE
14137 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14138
fe75f926
PE
14139 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14140 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14141
ffa8c828
PE
14142 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14143 This avoids undefined behavior on integer overflow, and is a bit
14144 more convenient anyway since it is compared to a size_t variable.
14145
c5101a77
PE
14146 Variadic C functions now count arguments with size_t, not int.
14147 This avoids an unnecessary limitation on 64-bit machines, which
14148 caused (substring ...) to crash on large vectors (Bug#8344).
14149 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14150 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14151 All variadic functions and their callers changed accordingly.
c5101a77
PE
14152 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14153 * data.c (arith_driver, float_arith_driver): Likewise.
14154 * editfns.c (general_insert_function): Likewise.
14155 * eval.c (struct backtrace.nargs, interactive_p)
14156 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14157 (funcall_lambda, mark_backtrace): Likewise.
14158 * fns.c (concat): Likewise.
14159 * frame.c (x_set_frame_parameters): Likewise.
14160 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14161 0 if not found, not -1. All callers changed.
14162
dd3f25f7
PE
14163 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14164 (stack_copy_size): Now size_t, not int.
14165 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14166
461c2ab9
JB
141672011-03-28 Juanma Barranquero <lekktu@gmail.com>
14168
14169 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14170 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14171 All callers changed.
14172
14173 * lisp.h (multibyte_char_to_unibyte):
14174 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14175 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14176 * character.h (CHAR_TO_BYTE8):
14177 * cmds.c (internal_self_insert):
14178 * editfns.c (general_insert_function):
14179 * keymap.c (push_key_description):
14180 * search.c (Freplace_match):
14181 * xdisp.c (message_dolog, set_message_1): All callers changed.
14182
f6d62986
SM
141832011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14184
14185 * keyboard.c (safe_run_hook_funcall): New function.
14186 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14187 don't set the hook to nil, but remove the offending function instead.
14188 (Qcommand_hook_internal): Remove, unused.
14189 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14190 Vcommand_hook_internal.
14191
14192 * eval.c (enum run_hooks_condition): Remove.
14193 (funcall_nil, funcall_not): New functions.
14194 (run_hook_with_args): Call each function through a `funcall' argument.
14195 Remove `cond' argument, now redundant.
14196 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14197 (Frun_hook_with_args_until_failure): Adjust accordingly.
14198 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14199
1db5b1ad
JB
142002011-03-28 Juanma Barranquero <lekktu@gmail.com>
14201
14202 * dispextern.h (string_buffer_position): Remove declaration.
14203
14204 * print.c (strout): Remove parameter `multibyte', unused since
14205 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14206
14207 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14208 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14209 All callers changed.
14210
14211 * w32.c (_wsa_errlist): Use braces for struct initializers.
14212
14213 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14214 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14215 All callers changed.
14216 (string_buffer_position): Likewise. Also, make static (it's never
14217 used outside xdisp.c).
14218 (cursor_row_p): Remove parameter `w', unused since
14219 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14220 (decode_mode_spec): Remove parameter `precision', introduced during
14221 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14222 All callers changed.
14223
5ffb62aa
JD
142242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14225
14226 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14227
461c2ab9 142282011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14229
14230 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14231 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14232 (ns_update_auto_hide_menu_bar): New functions.
14233 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14234 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14235 ns_constrain_all_frames.
14236 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14237 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14238
5c380ffb
JD
142392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14240
14241 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14242
9af30bdf
GM
142432011-03-27 Glenn Morris <rgm@gnu.org>
14244
14245 * syssignal.h: Replace RETSIGTYPE with void.
14246 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14247 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14248 Replace SIGTYPE with void everywhere.
14249 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14250 * s/template.h (SIGTYPE): Remove commented out definition.
14251
e2abce01
JB
142522011-03-26 Eli Zaretskii <eliz@gnu.org>
14253
14254 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14255 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14256
f868cd8a
JB
142572011-03-26 Juanma Barranquero <lekktu@gmail.com>
14258
59eb0929
JB
14259 * w32.c (read_unc_volume): Use parameter `henum', instead of
14260 global variable `wget_enum_handle'.
14261
14262 * keymap.c (describe_vector): Remove parameters `indices' and
14263 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14264 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14265
f868cd8a
JB
14266 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14267
14268 * keyboard.c (timer_check): Remove parameter `do_it_now',
14269 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14270 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14271 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14272
14273 * keyboard.c (read_char):
14274 * w32menu.c (w32_menu_display_help):
14275 * xmenu.c (show_help_event, menu_help_callback):
14276 Adjust calls to `show_help_echo'.
14277
14278 * gtkutil.c (xg_maybe_add_timer):
14279 * keyboard.c (readable_events):
14280 * process.c (wait_reading_process_output):
14281 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14282
14283 * insdel.c (adjust_markers_gap_motion):
14284 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14285 (gap_left, gap_right): Don't call it.
14286
2ecf6fdb
CY
142872011-03-25 Chong Yidong <cyd@stupidchicken.com>
14288
14289 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14290 incurred during fontification.
14291
6b1f9ba4
JB
142922011-03-25 Juanma Barranquero <lekktu@gmail.com>
14293
14294 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14295 (DEFVAR_PER_BUFFER): Don't pass it.
14296
14297 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14298 (scrolling_window): Don't pass it.
14299
0f4a96b5
JB
143002011-03-25 Juanma Barranquero <lekktu@gmail.com>
14301
14302 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14303
14304 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14305 and `suffix'.
14306 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14307 of variables specific to SELinux and computation of `encoded_absname'.
14308
14309 * image.c (XPutPixel): Remove unused variable `height'.
14310
14311 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14312
14313 * unexw32.c (get_section_info): Remove unused variable `section'.
14314
14315 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14316 (system_process_attributes): Remove unused variable `sess'.
14317 (sys_read): Remove unused variable `err'.
14318
14319 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14320 (w32_wnd_proc): Remove unused variable `isdead'.
14321 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14322 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14323 (x_create_tip_frame): Remove unused variable `tem'.
14324
14325 * w32inevt.c (w32_console_read_socket):
14326 Remove unused variable `no_events'.
14327
14328 * w32term.c (x_draw_composite_glyph_string_foreground):
14329 Remove unused variable `width'.
14330
1149507c
JB
143312011-03-24 Juanma Barranquero <lekktu@gmail.com>
14332
14333 * w32term.c (x_set_glyph_string_clipping):
14334 Don't pass uninitialized region to CombineRgn.
14335
9c88f339
JB
143362011-03-23 Juanma Barranquero <lekktu@gmail.com>
14337
14338 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14339 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14340 (Fx_close_connection): Remove unused variable `i'.
14341
14342 * w32font.c (w32font_draw): Return number of glyphs.
14343 (w32font_open_internal): Remove unused variable `i'.
14344 (w32font_driver): Add missing initializer.
14345
14346 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14347 (fill_in_menu): Remove unused variable `items_added'.
14348
14349 * w32term.c (last_mouse_press_frame): Remove static global variable.
14350 (w32_clip_to_row): Remove unused variable `f'.
14351 (x_delete_terminal): Remove unused variable `i'.
14352
14353 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14354 (NOTHING): Remove unused static global variable.
14355 (uniscribe_check_otf): Remove unused variable `table'.
14356 (uniscribe_font_driver): Add missing initializers.
14357
dee091a3
JD
143582011-03-23 Julien Danjou <julien@danjou.info>
14359
14360 * term.c (Fsuspend_tty, Fresume_tty):
14361 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14362 * window.c (temp_output_buffer_show):
14363 * insdel.c (signal_before_change):
14364 * frame.c (Fhandle_switch_frame):
14365 * fileio.c (Fdo_auto_save):
14366 * emacs.c (Fkill_emacs):
14367 * editfns.c (save_excursion_restore):
14368 * cmds.c (internal_self_insert):
14369 * callint.c (Fcall_interactively):
14370 * buffer.c (Fkill_all_local_variables):
14371 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14372 Use Frun_hooks.
0f4a96b5 14373 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14374 unconditionally since it does the check itself.
dee091a3 14375
2c520ab5 143762011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14377
c9c49752
PE
14378 Fix more problems found by GCC 4.5.2's static checks.
14379
8abc3f12
PE
14380 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14381 the first time through the loop, since we know p0 < p1 then.
14382 This also avoids a gcc -Wstrict-overflow warning.
14383
a2d26660
PE
14384 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14385 leading to a memory leak, possible in functions like
14386 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14387 of objects (Bug#8318).
a2d26660 14388
916c72e9
PE
14389 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14390 that could (at least in theory) be that large.
14391
19ab8a18
PE
14392 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14393 This is less likely to overflow, and avoids undefined behavior if
14394 overflow does occur. All callers changed. Use strtoul to scan
14395 for the unsigned long integer.
b7cbbd6f
PE
14396 (pint2hrstr): Simplify and tune code slightly.
14397 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14398
f0641eff
PE
14399 * scroll.c (do_scrolling): Work around GCC bug 48228.
14400 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14401
7f650bb9
PE
14402 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14403 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14404 (validate_x_resource_name): Simplify count usage.
14405 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14406
37dd57d1
PE
14407 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14408 fail (Bug#8306).
81e56e61 14409
699979fc 14410 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14411
401bf9b4
PE
14412 * process.c (Fmake_network_process): Use socklen_t, not int,
14413 where POSIX says socklen_t is required in portable programs.
14414 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14415 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14416 (Fmake_network_process, server_accept_connection):
14417 (wait_reading_process_output, read_process_output):
14418 Likewise.
14419
b93aacde
PE
14420 * process.c: Rename or move locals to avoid shadowing.
14421 (list_processes_1, Fmake_network_process):
14422 (read_process_output_error_handler, exec_sentinel_error_handler):
14423 Rename or move locals.
4dc343ee 14424 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14425 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14426 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14427 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14428 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14429
af8a867c 14430 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14431 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14432 Include tparam.h instead, since it declares them.
af8a867c
PE
14433 * cm.h (PC): Remove extern decl; tparam.h now does this.
14434 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14435 * terminfo.c: Include tparam.h, to check interfaces.
14436 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14437 (tparam): Adjust signature to match interface in tparam.h;
14438 this removes some undefined behavior. Check that outstring and len
14439 are zero, which they always are with Emacs.
14440 * tparam.h (PC, BC, UP): New extern decls.
14441
0248044d 14442 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14443 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14444
8ff096c1 14445 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14446 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14447 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14448 (ftfont_list): Remove unused local.
49eaafba
PE
14449 (get_adstyle_property, ftfont_pattern_entity):
14450 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14451 Rename locals to avoid shadowing.
8ff096c1 14452
e2be39f6
PE
14453 * xfont.c (xfont_list_family): Mark var as initialized.
14454
c9735e30
PE
14455 * xml.c (make_dom): Now static.
14456
8f5201ae
PE
14457 * composite.c (composition_compute_stop_pos): Rename local to
14458 avoid shadowing.
b246f932
PE
14459 (composition_reseat_it): Remove unused locals.
14460 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14461 (composition_update_it): Mark var as initialized.
11b61122
PE
14462 (find_automatic_composition): Mark vars as initialized,
14463 with a FIXME (Bug#8290).
8f5201ae 14464
760fbc2c
PE
14465 character.h: Rename locals to avoid shadowing.
14466 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14467 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14468 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14469 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14470 to avoid shadowing.
14471
ff08eb85
PE
14472 * textprop.c (property_change_between_p): Remove; unused.
14473
fc7bf025
PE
14474 * intervals.c (interval_start_pos): Now static.
14475
235d7abc
PE
14476 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14477
44f230aa
SM
14478 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14479 Rename locals to avoid shadowing.
3e7d6594 14480
50060332
PE
14481 * sound.c (wav_play, au_play, Fplay_sound_internal):
14482 Fix pointer signedness.
d01f234b 14483 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14484 (wav_play): Initialize a variable to 0, to prevent undefined
14485 behavior (Bug#8278).
50060332 14486
c4fc4e30
PE
14487 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14488
918436ed
PE
14489 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14490
c939f91b
PE
14491 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14492 clobbering (Bug#8298).
b9c7f648
PE
14493 * sysdep.c (sys_subshell): Likewise.
14494 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14495
6bd8c144
PE
14496 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14497 This should get cleaned up, so that child_setup has the
14498 same signature on all platforms.
14499
7710357c 14500 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14501 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14502
c59da222
CY
145032011-03-22 Chong Yidong <cyd@stupidchicken.com>
14504
14505 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14506 not to be necessary, and produces flickering.
14507
66b87493
GM
145082011-03-20 Glenn Morris <rgm@gnu.org>
14509
14510 * config.in: Remove file.
14511
45b6f6d5
JB
145122011-03-20 Juanma Barranquero <lekktu@gmail.com>
14513
14514 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14515 are now in src/globals.h.
14516 (syms_of_minibuf): Remove spurious & from previous change.
14517
cd394be1 145182011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14519
14520 * minibuf.c (completing-read-function): New variable.
14521 (completing-read-default): Rename from completing-read.
14522 (completing-read): Call completing-read-function.
14523
b14e3e21
CY
145242011-03-19 Juanma Barranquero <lekktu@gmail.com>
14525
14526 * xfaces.c (Fx_load_color_file):
14527 Read color file from absolute filename (bug#8250).
14528
f2b726e6
JB
145292011-03-19 Juanma Barranquero <lekktu@gmail.com>
14530
14531 * makefile.w32-in: Update dependencies.
14532
09f6ff02
EZ
145332011-03-17 Eli Zaretskii <eliz@gnu.org>
14534
14535 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14536
29a6015a
PE
145372011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14538
a3a6c54e
PE
14539 Fix more problems found by GCC 4.5.2's static checks.
14540
b766f867
PE
14541 * process.c (make_serial_process_unwind, send_process_trap):
14542 (sigchld_handler): Now static.
14543
be02381c
PE
14544 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14545 That way, the code declares only the vars that it needs.
14546 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14547 * s/cygwin.h (PTY_ITERATION): Likewise.
14548 * s/darwin.h (PTY_ITERATION): Likewise.
14549 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14550
57048744
PE
14551 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14552 * process.c (allocate_pty): Don't declare stb unless it's needed.
14553
7914961c 14554 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14555 (CONSTANTLIM): Remove; unused.
14556 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14557 Define only if needed.
7914961c 14558
b3967b18
PE
14559 * unexelf.c (unexec): Name an expression,
14560 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14561 Use a different way to cause a compilation error if anyone uses
14562 n rather than nn, a way that does not involve shadowing.
73366a00 14563 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14564
29a6015a
PE
14565 * deps.mk (unexalpha.o): Remove; unused.
14566
43cfc33e 14567 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14568 * unexec.h: New file.
ce701a33
PE
14569 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14570 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14571 Depend on unexec.h.
14572 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14573 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14574 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14575 Change as necessary to match prototype in unexec.h.
ce701a33 14576
01f44d5a
PE
14577 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14578 shadowing.
4f63c6bb 14579 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14580
a6670b0b
PE
14581 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14582 Rename locals to avoid shadowing.
14583
cef2010d 14584 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14585 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14586
d4d7173a
PE
14587 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14588
f08b802a
PE
14589 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14590 warning when compiling print.c.
14591
3ddb0639
PE
14592 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14593 instead of using an uninitialized var.
5ad03b97 14594 (font_sort_entities): Mark var as initialized.
3ddb0639 14595
170a2692
PE
14596 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14597
e663c700
PE
14598 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14599 pointers to constants.
89bc529a 14600 (font_parse_fcname): Remove unused vars.
7b81e2d0 14601 (font_delete_unmatched): Now static.
ea838e10 14602 (font_get_spec): Remove; unused.
13a547c6
PE
14603 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14604 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14605 Rename or move locals to avoid shadowing.
e663c700 14606
2a80c887 14607 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14608 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14609
1384fa33 14610 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14611 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14612
8b2c52e9
PE
14613 * alloc.c (mark_backtrace): Move decl from here ...
14614 * lisp.h: ... to here, so that it can be checked.
14615
475545b5 14616 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14617 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14618 (lisp_indirect_variable): Name an expression,
14619 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14620 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14621
b1349114 14622 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14623 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14624 Use const pointer when appropriate.
b1349114 14625
a2928364
PE
14626 * lisp.h (get_system_name, get_operating_system_release):
14627 Move decls here, to check interfaces.
14628 * process.c (get_operating_system_release): Move decl to lisp.h.
14629 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14630 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14631 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14632 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14633 (Fformat_time_string, Fencode_time, Finsert_char):
14634 (Ftranslate_region_internal, Fformat):
14635 Rename or remove local vars to avoid shadowing.
9710023e 14636 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14637
a415e694
PE
14638 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14639 avoid shadowing.
14640
8ef4622d
PE
14641 * lisp.h (eassert): Check that the argument compiles, even if
14642 ENABLE_CHECKING is not defined.
14643
946f9a5b
PE
14644 * data.c (Findirect_variable): Name an expression, to avoid
14645 gcc -Wbad-function-cast warning.
112396d6 14646 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14647 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14648 (Fmake_variable_buffer_local, Fmake_local_variable):
14649 Mark variables as initialized.
52746918 14650 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14651
e5aab7e7 14652 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14653 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14654 Rename locals to avoid shadowing.
dff45157
PE
14655 (mark_stack): Move local variables into the #ifdef region where
14656 they're used.
7bc26fdb
PE
14657 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14658 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14659 needed otherwise.
14660 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14661 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14662 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14663
e5aab7e7
PE
14664 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14665 avoids undefined behavior in theory.
14666
4da60324
PE
14667 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14668
88043301
PE
14669 Use functions, not macros, for up- and down-casing (Bug#8254).
14670 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14671 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14672 to use the following functions instead of these macros.
14673 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14674 EMACS_INT, since callers assume the returned value fits in int.
14675 (upcase1): Likewise, for UPCASE_TABLE.
14676 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14677 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14678 the race-condition problem in the old DOWNCASE.
88043301 14679
19ed5445
PE
14680 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14681 Rename locals to avoid shadowing.
14682 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14683 (regex_compile, re_search_2, re_match_2_internal):
14684 Remove unused local vars.
952db0d7
PE
14685 (FREE_VAR): Rewrite so as not to use empty "else",
14686 which gcc can warn about.
da053e48 14687 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14688 (RETALLOC_IF): Define only if needed.
14689 (WORDCHAR_P): Likewise. This one is never needed, but is used
14690 only in a comment talking about a compiler bug, so put inside
14691 the #if 0 of that comment.
14692 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14693 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14694 Remove; unused.
19ed5445 14695
1f3561e4 14696 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14697 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14698 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14699
ded6f8f7
PE
14700 * search.c (simple_search): Remove unused var.
14701
dbd37a95
PE
14702 * dired.c (compile_pattern): Move decl from here ...
14703 * lisp.h: ... to here, so that it can be checked.
14704 (struct re_registers): New forward decl.
14705
7e47afad
PE
14706 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14707
85f24f61
PE
14708 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14709 All uses changed.
14710 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14711 Rename locals to avoid shadowing.
5671df8f 14712 (Fvertical_motion): Mark locals as initialized.
85f24f61 14713
181aa2be 14714 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14715 (casify_region): Mark local as initialized.
181aa2be 14716
930d429c
PE
14717 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14718
7082eac6
PE
14719 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14720 New macros, so that the caller can use some names other than
14721 gcpro1, gcpro2, etc.
14722 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14723 of the new macros.
14724 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14725 argument, for consistency with GCPRO2_VAR, etc: it is now the
14726 prefix of the variable, not the variable itself. All uses
14727 changed.
38b2c076
PE
14728 * dired.c (directory_files_internal, file_name_completion):
14729 Rename locals to avoid shadowing.
14730
15206ed9
PE
14731 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14732 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14733 dired.c's scmp function, had undefined behavior.
14734 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14735 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14736 * buffer.h: ... to here, because these macros use current_buffer,
14737 and the new implementation with inline functions needs to have
14738 current_buffer in scope now, rather than later when the macros
14739 are used.
14740 (downcase, upcase1): New static inline functions.
14741 (DOWNCASE, UPCASE1): Reimplement using these functions.
14742 This avoids undefined behavior in expressions like
14743 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14744 from race conditions in accessing the global variables
14745 case_temp1 and case_temp2.
14746 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14747 * lisp.h (case_temp1, case_temp2): Remove their decls.
14748 * character.h (ASCII_CHAR_P): Move from here ...
14749 * lisp.h: ... to here, so that the inline functions mentioned
14750 above can use them.
14751
4a6bea26
PE
14752 * dired.c (directory_files_internal_unwind): Now static.
14753
f14b7e14
PE
14754 * fileio.c (file_name_as_directory, directory_file_name):
14755 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14756 Now static.
2893f146
PE
14757 (file_name_as_directory): Use const pointers when appropriate.
14758 (Fexpand_file_name): Likewise. In particular, newdir might
14759 point at constant storage, so make it a const pointer.
fd4ead52 14760 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14761 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14762 signedness issues.
f839df0c
PE
14763 (Fset_file_times, Finsert_file_contents, auto_save_error):
14764 Rename locals to avoid shadowing.
f14b7e14 14765
5716756e 14766 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14767 (Ftry_completion, Fall_completions): Rename or remove locals
14768 to avoid shadowing.
5716756e 14769
b4c3046a
PE
14770 * marker.c (bytepos_to_charpos): Remove; unused.
14771
b45db522
PE
14772 * lisp.h (verify_bytepos, count_markers): New decls,
14773 so that gcc does not warn that these functions aren't declared.
14774
85876d07
PE
14775 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14776 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14777 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14778 (copy_text): Remove unused local var.
85876d07 14779
03d78a21 14780 * filelock.c (within_one_second): Now static.
b3dd38ab 14781 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14782
5df8f01b
PE
14783 * buffer.c (fix_overlays_before): Mark locals as initialized.
14784 (fix_start_end_in_overlays): Likewise. This function should be
14785 simplified by using pointers-to-pointers, but that's a different
14786 matter.
b1d876f1 14787 (switch_to_buffer_1): Now static.
8f54f30a
PE
14788 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14789 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14790
a70072c9 14791 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14792 Fix pointer signedness issue.
edced198
PE
14793 (sys_subshell): Mark local as volatile if checking for lint,
14794 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14795 (MAXPATHLEN): Define only if needed.
a70072c9 14796
a0977c44
PE
14797 * process.c (serial_open, serial_configure): Move decls from here ...
14798 * systty.h: ... to here, so that they can be checked.
14799
a884fdcc
PE
14800 * fns.c (get_random, seed_random): Move extern decls from here ...
14801 * lisp.h: ... to here, so that they can be checked.
14802
604efe86 14803 * sysdep.c (reset_io): Now static.
b8950c94 14804 (wait_for_termination_signal): Remove; unused.
604efe86 14805
38fc62d9
PE
14806 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14807 (copy_keymap_item, append_key, push_text_char_description):
14808 Now static.
1004a21a 14809 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14810 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14811 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14812 (describe_map_tree):
14813 Rename locals to avoid shadowing.
38fc62d9 14814
2f2650da
PE
14815 * keyboard.c: Declare functions static if they are not used elsewhere.
14816 (echo_char, echo_dash, cmd_error, top_level_2):
14817 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14818 (read_char, kbd_buffer_get_event, make_lispy_position):
14819 (make_lispy_event, make_lispy_movement, apply_modifiers):
14820 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14821 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14822 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14823 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14824 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14825
a053e86c 14826 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14827 (mark_kboards): Move decl here ...
14828 * alloc.c (mark_kboards): ... from here.
a053e86c 14829
4752793e
PE
14830 * lisp.h (force_auto_save_soon): New decl.
14831
74f10ca7 14832 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14833 (DEFINE_DUMMY_FUNCTION): New macro.
14834 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14835 Use it.
c03cd23f
PE
14836 (main): Add casts to avoid warnings
14837 if GCC considers string literals to be constants.
74f10ca7 14838
022e70d4
PE
14839 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14840
59d6fe83
PE
14841 * dbusbind.c: Pointer signedness fixes.
14842 (xd_signature, xd_append_arg, xd_initialize):
14843 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14844 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14845 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14846 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14847
78320123
PE
14848 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14849 if GCC considers string literals to be constants.
49cebcca 14850 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14851
35ac2a97
SM
148522011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14853
fb103ca9
SM
14854 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14855 (print_preprocess, print_object): New macro to fix last change.
14856
35ac2a97
SM
14857 * print.c (print_preprocess): Don't forget font objects.
14858
62973b41
JB
148592011-03-16 Juanma Barranquero <lekktu@gmail.com>
14860
14861 * emacs.c (USAGE3): Doc fixes.
14862
0e48bb22
AS
148632011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14864
14865 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14866 structure.
14867
7684e57b
JB
148682011-03-14 Juanma Barranquero <lekktu@gmail.com>
14869
14870 * lisp.h (VWindow_system, Qfile_name_history):
14871 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14872 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14873 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14874
14875 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14876 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14877
14878 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14879 * w32console.c (detect_input_pending, read_input_pending)
14880 (encode_terminal_code):
14881 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14882 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14883 (w32_system_caret_y, Qfile_name_history):
14884 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14885 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14886 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14887 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14888 * w32proc.c (Qlocal, report_file_error):
14889 * w32term.c (Vwindow_system, updating_frame):
14890 * w32uniscribe.c (initialized, uniscribe_font_driver):
14891 Remove unneeded extern declarations.
14892
2aa46d6c
CY
148932011-03-14 Chong Yidong <cyd@stupidchicken.com>
14894
c96bbc66 14895 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14896
cffc6f3b
CY
148972011-03-13 Chong Yidong <cyd@stupidchicken.com>
14898
14899 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14900 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14901 These macros can no longer be used for assignment.
14902
44f230aa
SM
14903 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14904 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14905 (record_buffer_markers, fetch_buffer_markers): New functions for
14906 recording and fetching special buffer markers.
14907 (set_buffer_internal_1, set_buffer_temp): Use them.
14908
14909 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14910
14911 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14912
14913 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14914 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14915
14916 * xdisp.c (hscroll_window_tree):
14917 (reconsider_clip_changes): Use PT instead of BUF_PT.
14918
d251f04b
EZ
149192011-03-13 Eli Zaretskii <eliz@gnu.org>
14920
14921 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14922 $(EMACS_ROOT)/lib/intprops.h.
14923
f0c77cd1
PE
149242011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14925
3eca4629
PE
14926 Fix more problems found by GCC 4.5.2's static checks.
14927
7c86ee98
PE
14928 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14929 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14930 (xg_free_frame_widgets): Make it clear that a local variable is
14931 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14932 (gdk_window_get_screen): Make it clear that this macro is needed
14933 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14934 (int_gtk_range_get_value): New function, which avoids a diagnostic
14935 from gcc -Wbad-function-cast.
14936 (xg_set_toolkit_scroll_bar_thumb): Use it.
14937 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14938 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14939 (get_utf8_string, xg_get_file_with_chooser):
14940 Rename locals to avoid shadowing.
14941 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14942
41729b81
PE
14943 * xgselect.c (xg_select): Remove unused var.
14944
f0c77cd1
PE
14945 * image.c (four_corners_best): Mark locals as initialized.
14946 (gif_load): Initialize transparent_p to zero (Bug#8238).
14947 Mark another local as initialized.
ec6cf4c6 14948 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14949
ce0ad53d 14950 * image.c (clear_image_cache): Now static.
d5d5a617 14951 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14952 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14953 (x_edge_detection): Remove unnecessary cast that
14954 gcc -Wbad-function-cast diagnoses.
2037898d 14955 (gif_load): Fix pointer signedness.
6ae141d6
PE
14956 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14957 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14958
33383987 149592011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14960
d32df629
PE
14961 Improve quality of tests for time stamp overflow.
14962 For example, without this patch (encode-time 0 0 0 1 1
14963 1152921504606846976) returns the obviously-bogus value (-948597
14964 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14965 reports time overflow. See
14966 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14967 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14968 * editfns.c: Include limits.h and intprops.h.
14969 (TIME_T_MIN, TIME_T_MAX): New macros.
14970 (time_overflow): Move earlier, to before first use.
14971 (hi_time, lo_time): New functions, for an accurate test for
14972 out-of-range times.
14973 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14974 (Fget_internal_run_time): Don't assume time_t fits in int.
14975 (make_time): Use list2 instead of Fcons twice.
14976 (Fdecode_time): More accurate test for out-of-range times.
14977 (check_tm_member): New function.
14978 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14979 (lisp_time_argument): Don't rely on undefined left-shift and
14980 right-shift behavior when checking for time stamp overflow.
8be6f318 14981
fe31d94c
PE
14982 * editfns.c (time_overflow): New function, refactoring common code.
14983 (Fformat_time_string, Fdecode_time, Fencode_time):
14984 (Fcurrent_time_string): Use it.
14985
8be6f318
PE
14986 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14987 * dired.c (make_time): Move to ...
14988 * editfns.c (make_time): ... here.
14989 * systime.h: Note the move.
14990
09d9db2c 149912011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14992
126bc0dc
YM
14993 * fringe.c (update_window_fringes): Remove unused variables.
14994
c47cbdfd
YM
14995 * unexmacosx.c (copy_data_segment): Also copy __got section.
14996 (Bug#8223)
14997
7ac80be9
EZ
149982011-03-12 Eli Zaretskii <eliz@gnu.org>
14999
c96bbc66 15000 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15001 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15002 Constify `char *' arguments and their references according to
15003 prototypes in tparam.h.
15004
ecb0f94d 15005 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15006
7ac80be9
EZ
15007 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15008 Adapt all references accordingly.
15009
15010 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15011
ef1fd07e
TT
150122011-03-11 Tom Tromey <tromey@redhat.com>
15013
15014 * buffer.c (syms_of_buffer): Remove obsolete comment.
15015
7ef4b50c
EZ
150162011-03-11 Eli Zaretskii <eliz@gnu.org>
15017
15018 * termhooks.h (encode_terminal_code): Declare prototype.
15019
15020 * msdos.c (encode_terminal_code): Don't declare prototype.
15021
15022 * term.c (encode_terminal_code): Now external again, used by
15023 w32console.c and msdos.c.
15024
44f230aa
SM
15025 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15026 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15027
4b1ec863 150282011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15029
1714f52b 15030 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15031
4b1ec863
PE
15032 * fringe.c (update_window_fringes): Mark locals as initialized
15033 (Bug#8227).
15034 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15035
524c7aa6
PE
15036 * alloc.c (mark_fringe_data): Move decl from here ...
15037 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15038 to check its interface.
15039 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15040
a5c0af81 15041 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15042 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15043 (fontset_font): Mark local as initialized.
a9a06e0b 15044 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15045
b4716021
PE
15046 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15047
811e9bac 15048 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15049 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15050 (x_own_selection, Fx_disown_selection_internal): Rename locals
15051 to avoid shadowing.
15052 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15053
7e3ab302
PE
15054 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15055 so that the caller can use some name other than gcpro1.
15056 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15057 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15058 (Fx_backspace_delete_keys_p):
15059 Use them to avoid shadowing, and rename vars to avoid shadowing.
15060 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15061 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15062 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15063 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15064 Remove unused locals.
7e3ab302
PE
15065 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15066 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15067 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15068 macros.
f78faa98 15069
e2b13473
PE
15070 * xterm.h (x_mouse_leave): New decl.
15071
77f23912
PE
15072 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15073 Remove unused functions.
cdf4ba58
PE
15074 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15075 (x_calc_absolute_position): Now static.
7411c686 15076 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15077 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15078 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15079 unless they are used.
38d0b34a
PE
15080 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15081 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15082 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15083 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15084 (x_error_catcher, x_connection_closed, x_error_handler):
15085 (x_error_quitter, xembed_send_message, x_iconify_frame):
15086 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15087 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15088 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15089
44f230aa
SM
15090 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15091 Rename or move locals to avoid shadowing.
6b463e58 15092 (tty_defined_color, merge_face_heights): Now static.
5967d051 15093 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15094 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15095 does not deduce is never used uninitialized.
73719eba
PE
15096 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15097 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15098
426994c3 15099 * terminal.c (store_terminal_param): Now static.
5489860b 15100
032f1620 15101 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15102 (set_frame_menubar): Remove unused local.
d4323972 15103 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15104 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15105 since they might point to immutable storage.
281585b0
PE
15106 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15107 since it's unused otherwise.
032f1620 15108
367c19e5 15109 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15110 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15111 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15112 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15113 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15114 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15115 does not deduce are never used uninitialized.
70739cbe 15116
07b48fa9
PE
15117 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15118
8868a238 15119 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15120 * window.c (window_loop, size_window):
15121 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15122
7e5cf297 15123 * window.c (display_buffer): Now static.
d6550a9f
PE
15124 (size_window): Mark variables that gcc -Wuninitialized
15125 does not deduce are never used uninitialized.
a586633d
PE
15126 * window.h (check_all_windows): New decl, to forestall
15127 gcc -Wmissing-prototypes diagnostic.
5b555da1 15128 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15129
f6095868
PE
15130 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15131 shadowing.
15132 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15133 Include <limits.h>.
15134 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15135 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15136 (load_charset_map): Mark variables that gcc -Wuninitialized
15137 does not deduce are never used uninitialized.
53df7c11 15138 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15139
f38b440c
PE
15140 * coding.c (coding_set_source, coding_set_destination):
15141 Use "else { /* comment */ }" rather than "else /* comment */;"
15142 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15143 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15144 a block, when the outer 'i' will do.
15145 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15146 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15147 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15148 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15149 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15150 Rename locals to avoid shadowing.
15151 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15152 * coding.c (emacs_mule_char, encode_invocation_designation):
15153 Now static, since they're not used elsewhere.
413bb2db 15154 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15155 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15156 (decode_coding_emacs_mule): Mark variables that gcc
15157 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15158 (detect_coding_iso_2022): Initialize a local variable that might
15159 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15160 this initialization is needed. (Bug#8211)
5f58e762
PE
15161 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15162 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15163 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15164 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15165 Remove unused macros.
f38b440c 15166
232b38b9 15167 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15168 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15169 * character.c (string_count_byte8): Likewise.
232b38b9 15170
fb90da1b
PE
15171 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15172 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15173
fb93dbc2
PE
15174 * chartab.c (copy_sub_char_table): Now static, since it's not used
15175 elsewhere.
5c156ace
PE
15176 (sub_char_table_ref_and_range, char_table_ref_and_range):
15177 Rename locals to avoid shadowing.
bbcd0949 15178 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15179
7d3b3862 15180 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15181 (BIDI_BOB): Remove unused macro.
7d3b3862 15182
6be7d3da
PE
15183 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15184 deduce are never used uninitialized.
c2ed9c8b 15185 * term.c (encode_terminal_code): Likewise.
6be7d3da 15186
75f8807f 15187 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15188
50938595
PE
15189 * tparam.h: New file.
15190 * term.c, tparam.h: Include it.
15191 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15192 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15193 Move these decls to tparam.h, and make them agree with what
15194 is actually in tparam.c. The previous trick of using incompatible
15195 decls in different modules does not conform to the C standard.
15196 All callers of tparam changed to use tparam's actual API.
15197 * tparam.c (tparam1, tparam, tgoto):
15198 Use const pointers where appropriate.
15199
fbceeba2
PE
15200 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15201 * cm.h (struct cm): Likewise.
15202 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15203 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15204 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15205 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15206 (turn_on_face, init_tty): Likewise.
15207 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15208
7f3f1250
PE
15209 * term.c (term_mouse_position): Rename local to avoid shadowing.
15210
e6ca6543
PE
15211 * alloc.c (mark_ttys): Move decl from here ...
15212 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15213
c40f8d15
AS
152142011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15215
15216 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15217
cfe0661d
JB
152182011-03-09 Juanma Barranquero <lekktu@gmail.com>
15219
15220 * search.c (compile_pattern_1): Remove argument regp, unused since
15221 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15222 (compile_pattern): Don't pass it.
15223
0afb4571
J
152242011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15225
15226 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15227 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15228 for ! HAVE_GTK3.
15229 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15230
15231 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15232
15233 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15234 gdk_window_get_screen, gdk_window_get_geometry,
15235 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15236 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15237 (xg_get_pixbuf_from_pixmap): New function.
15238 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15239 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15240 Call xg_get_pixbuf_from_pixmap instead of
15241 gdk_pixbuf_get_from_drawable.
15242 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15243 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15244 (xg_check_special_colors): Use GtkStyleContext and its functions
15245 for HAVE_GTK3.
15246 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15247 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15248 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15249 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15250 Call gtk_widget_get_preferred_size.
0afb4571
J
15251 (xg_frame_resized): gdk_window_get_geometry only takes 5
15252 parameters.
44f230aa
SM
15253 (xg_win_to_widget, xg_event_is_for_menubar):
15254 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15255 (xg_set_widget_bg): New function.
15256 (delete_cb): New function.
895009e1 15257 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15258 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15259 (xg_set_background_color): Call xg_set_widget_bg.
15260 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15261 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15262 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15263 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15264 if ! HAVE_GTK3.
15265 (update_frame_tool_bar): Call gtk_widget_hide.
15266 (xg_initialize): Use GDK_KEY_g.
15267
15268 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15269 if ! HAVE_GTK3
15270 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15271
15272 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15273 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15274 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15275
1c2cc4ef
JB
152762011-03-08 Juanma Barranquero <lekktu@gmail.com>
15277
15278 * w32xfns.c (select_palette): Check success of RealizePalette against
15279 GDI_ERROR, not zero.
15280
33383987 15281See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15282
15283;; Local Variables:
15284;; coding: utf-8
aac0c6e3
MR
15285;; End:
15286
2f097256 15287 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15288
15289 This file is part of GNU Emacs.
15290
15291 GNU Emacs is free software: you can redistribute it and/or modify
15292 it under the terms of the GNU General Public License as published by
15293 the Free Software Foundation, either version 3 of the License, or
15294 (at your option) any later version.
15295
15296 GNU Emacs is distributed in the hope that it will be useful,
15297 but WITHOUT ANY WARRANTY; without even the implied warranty of
15298 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15299 GNU General Public License for more details.
15300
15301 You should have received a copy of the GNU General Public License
15302 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.