* doc/lispref/files.texi: (files-equal-p, file-subdir-of-p): Add documentation.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3c9dfce6
CY
12012-02-25 Chong Yidong <cyd@gnu.org>
2
fa74b241
CY
3 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4 Doc fix.
5
3c9dfce6
CY
6 * xselect.c (Fx_selection_exists_p): Doc fix.
7 (x_clipboard_manager_save_all): Print an informative message
8 before saving to clipboard manager.
9
9486df08
CY
102012-02-24 Chong Yidong <cyd@gnu.org>
11
12 * keyboard.c (process_special_events): Handle all X selection
13 requests in kbd_buffer, not just the next one (Bug#8869).
14
f01d3321
CY
152012-02-23 Chong Yidong <cyd@gnu.org>
16
17 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
18 call when setting menu-bar-lines and tool-bar-lines parameters.
19 (unwind_create_frame_1): New helper function.
20
21 * window.c (inhibit_window_configuration_change_hook): New var.
22 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 23 (syms_of_window): Initialize it.
f01d3321 24
86b847b6
CY
252012-02-22 Chong Yidong <cyd@gnu.org>
26
27 * xterm.c (x_draw_image_relief): Add missing type check for
28 Vtool_bar_button_margin (Bug#10743).
29
a59225b1
CY
302012-02-21 Chong Yidong <cyd@gnu.org>
31
32 * fileio.c (Vfile_name_handler_alist): Doc fix.
33
34 * buffer.c (Fget_file_buffer): Protect against invalid file
35 handler return value.
36
310f5bd4
PE
372012-02-20 Paul Eggert <eggert@cs.ucla.edu>
38
cb3a28cc
PE
39 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
40 when computing $valmask.
41
310f5bd4
PE
42 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
43 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
44 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
45 It's useless in that case, and it can cause problems on hosts
46 that allocate halves of EMACS_INT values separately.
47 Reported by Dan Horák. Diagnosed by Andreas Schwab in
48 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
49 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
50 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
51 it avoids undefined behavior on hosts where shifting right by more
52 than the word width has undefined behavior.
53
2375c96a
CY
542012-02-19 Chong Yidong <cyd@gnu.org>
55
56 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
57 (Funhandled_file_name_directory, Ffile_name_as_directory)
58 (Fdirectory_file_name, Fexpand_file_name)
59 (Fsubstitute_in_file_name): Protect against invalid file handler
60 return values (Bug#10845).
61
3eb49e71
EZ
622012-02-18 Eli Zaretskii <eliz@gnu.org>
63
64 * .gdbinit (pitx): Fix incorrect references to fields of the
65 iterator stack.
66
7b926f3f
CY
672012-02-17 Chong Yidong <cyd@gnu.org>
68
69 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
70
11273115
PE
712012-02-15 Paul Eggert <eggert@cs.ucla.edu>
72
73 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
74 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
75
c3a70e2b
CY
762012-02-15 Chong Yidong <cyd@gnu.org>
77
78 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
79 marked as special. Also, starting docstrings with * is obsolete.
80
0ca43699
AS
812012-02-13 Andreas Schwab <schwab@linux-m68k.org>
82
83 * gnutls.c (emacs_gnutls_write): Fix last change.
84
2e8f3c56
LI
852012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
86
87 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
88 send_process.
89
af70074f
SM
902012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
91
92 * keymap.c (Fsingle_key_description): Handle char ranges.
93
95986d52
CY
942012-02-12 Chong Yidong <cyd@gnu.org>
95
afd83bd1
CY
96 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
97 as that creates a dangerous corner case.
98
95986d52
CY
99 * window.c (Fdelete_window_internal): Invalidate the mouse
100 highlight (Bug#9904).
101
bd7da63e
GM
1022012-02-12 Glenn Morris <rgm@gnu.org>
103
104 * xselect.c (Fx_own_selection_internal)
105 (Fx_get_selection_internal, Fx_disown_selection_internal)
106 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
107 * nsselect.m (Fx_own_selection_internal)
108 (Fx_disown_selection_internal, Fx_selection_exists_p)
109 (Fx_selection_owner_p, Fx_get_selection_internal):
110 Sync docs and argument specs with the xselect.c versions.
111
77abcbc2
LI
1122012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
113
114 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
115
90b671e2
EZ
1162012-02-11 Eli Zaretskii <eliz@gnu.org>
117
1c0ca0b7
EZ
118 * w32select.c (Fx_selection_exists_p): Sync doc string and
119 argument list with xselect.c. (Bug#10783)
120
121 * w16select.c (Fx_selection_exists_p): Sync doc string and
122 argument list with xselect.c. (Bug#10783)
90b671e2 123
49241268
GM
1242012-02-10 Glenn Morris <rgm@gnu.org>
125
126 * fns.c (Fsecure_hash): Doc fix.
127
f998bbe7 1282012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
129
130 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
131
0992bd9c
CY
1322012-02-07 Chong Yidong <cyd@gnu.org>
133
134 * buffer.c (Fbuffer_local_variables)
135 (buffer_lisp_local_variables): Handle unbound vars correctly;
136 don't let Qunbound leak into Lisp.
137
af008560
GM
1382012-02-07 Glenn Morris <rgm@gnu.org>
139
dd605cc4
GM
140 * image.c (Fimagemagick_types): Doc fix.
141
af008560
GM
142 * image.c (imagemagick-render-type): Change it from a lisp object
143 to an integer. Move the doc here from the lisp manual.
144 Treat all values not equal to 0 the same.
145
1449fa1d
CY
1462012-02-06 Chong Yidong <cyd@gnu.org>
147
148 * doc.c (store_function_docstring): Avoid applying docstring of
149 alias to base function (Bug#2603).
150
3723ec07
AS
1512012-02-04 Andreas Schwab <schwab@linux-m68k.org>
152
153 * .gdbinit (pp1, pv1): Remove redundant defines.
154 (pr): Use pp.
155
79c1cc1e
CY
1562012-02-04 Chong Yidong <cyd@gnu.org>
157
158 * nsterm.m: Declare a global (Bug#10694).
159
d7f29f8e
EZ
1602012-02-04 Eli Zaretskii <eliz@gnu.org>
161
162 * w32.c (get_emacs_configuration_options): Include
163 --enable-checking, if specified, in the return value.
164
3b95a6f9
MR
1652012-02-04 Martin Rudalics <rudalics@gmx.at>
166
167 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
168 after rounding frame sizes. (Bug#9723)
169
d6fa96a6
EZ
1702012-02-04 Eli Zaretskii <eliz@gnu.org>
171
172 * keyboard.c (adjust_point_for_property): Don't position point
173 before BEGV. (Bug#10696)
174
df0b2940
PE
1752012-02-03 Paul Eggert <eggert@cs.ucla.edu>
176
177 Handle overflow when computing char display width (Bug#9496).
178 * character.c (char_width): Return EMACS_INT, not int.
179 (char_width, c_string_width): Check for overflow when
180 computing the width; this is possible now that individual
181 characters can have unbounded width. Problem introduced
182 by merge from Emacs 23 on 2012-01-19.
183
6bee44d6
MA
1842012-02-02 Michael Albinus <michael.albinus@gmx.de>
185
186 * dbusbind.c (Fdbus_register_method): Mention the return value
187 :ignore in the docstring.
188
44f92739
GM
1892012-02-02 Glenn Morris <rgm@gnu.org>
190
1b9f60cc
GM
191 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
192
44f92739
GM
193 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
194 Unconditionally set to t. (Bug#10673)
195 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
196 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
197 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
198
c5d3843c
KH
1992012-02-02 Kenichi Handa <handa@m17n.org>
200
201 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
202 0, do not call append_composite_glyph.
203
159462d4 2042012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
205
206 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
207 NULL (Bug#6988).
208 (x_produce_glyphs): If the component of a composition is a null
209 string, set it->pixel_width to 1 to avoid zero-width glyph.
210
78cef877
EZ
2112012-02-01 Eli Zaretskii <eliz@gnu.org>
212
213 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
214 first 2 arguments are identical. This makes inserting large
215 output from a subprocess an order of magnitude faster on
216 MS-Windows, where all sbrk'ed memory is always contiguous.
217
97897668
GM
2182012-01-31 Glenn Morris <rgm@gnu.org>
219
220 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 221 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
222 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
223
31fd3586
GM
2242012-01-29 Glenn Morris <rgm@gnu.org>
225
226 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
227
0e24a8b2
CY
2282012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
229
230 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
231
cc0adcb0
CY
2322012-01-28 Chong Yidong <cyd@gnu.org>
233
234 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
235
acc28cb9
CY
2362012-01-26 Chong Yidong <cyd@gnu.org>
237
9c69cfb7
CY
238 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
239
acc28cb9
CY
240 * search.c (Fsearch_forward, Fsearch_backward): Document negative
241 repeat counts (Bug#10507).
242
48da7392
GM
2432012-01-26 Glenn Morris <rgm@gnu.org>
244
245 * lread.c (syms_of_lread): Doc fix.
246
14af5f7f
CY
2472012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
248
249 * coding.c (encode_designation_at_bol): Change return value to
250 EMACS_INT.
251
0b21c100
CY
2522012-01-25 Chong Yidong <cyd@gnu.org>
253
254 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
255
3c2907f7
CY
2562012-01-21 Chong Yidong <cyd@gnu.org>
257
258 * floatfns.c (Fcopysign): Make the second argument non-optional,
259 since nil is not allowed anyway.
260
959ad23f
AS
2612012-01-21 Andreas Schwab <schwab@linux-m68k.org>
262
263 * process.c (read_process_output): Use p instead of XPROCESS (proc).
264 (send_process): Likewise.
265
34a02f46
MR
2662012-01-19 Martin Rudalics <rudalics@gmx.at>
267
268 * window.c (save_window_save, Fcurrent_window_configuration)
269 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
270 doc-strings.
271
1259009a 2722012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
273
274 * character.c (char_width): New function.
70d4fdf6
GM
275 (Fchar_width, c_string_width, lisp_string_width):
276 Use char_width (Bug#9496).
25ed9e61 277
6a6ee00d
MR
2782012-01-16 Martin Rudalics <rudalics@gmx.at>
279
280 * window.c (Vwindow_persistent_parameters): New variable.
281 (Fset_window_configuration, save_window_save): Handle persistent
282 window parameters.
283
c85efaf7
EZ
2842012-01-14 Eli Zaretskii <eliz@gnu.org>
285
286 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
287 thrashing the stack of the thread. (Bug#9087)
288
5944709e
PE
2892012-01-12 Paul Eggert <eggert@cs.ucla.edu>
290
291 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
292
e71f5d99
EZ
2932012-01-11 Eli Zaretskii <eliz@gnu.org>
294
295 * xdisp.c (rows_from_pos_range): Handle the case where the
296 highlight ends on a newline. (Bug#10464)
297 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
298 he end column for display of highlight that ends on a newline
299 before a R2L line.
300
ce316182
GM
3012012-01-11 Glenn Morris <rgm@gnu.org>
302
303 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
304 from load-path also when installation-directory is nil. (Bug#10208)
305
5b43da69
GM
3062012-01-10 Glenn Morris <rgm@gnu.org>
307
74cc8ff9
GM
308 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
309
7d8d6e4e
GM
310 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
311 Update template values to be closer to their typical values these days.
5b43da69 312
a0db8d43
EZ
3132012-01-09 Eli Zaretskii <eliz@gnu.org>
314
315 * xdisp.c (rows_from_pos_range): Accept additional argument
316 DISP_STRING, and accept any glyph in a row whose object is that
317 string as eligible for mouse highlight. Fixes mouse highlight of
318 display strings from overlays. (Bug#10464)
319
9a0115ab 3202012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 321
b9110d6a 322 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
323 * fileio.c (auto_saving_dir_umask): New static var.
324 (Fmake_directory_internal): Use it.
325 (do_auto_save_make_dir): Set it, instead of invoking chmod after
326 creating the directory. The old code temporarily assigns
327 too-generous permissions to the directory.
328 (do_auto_save_eh): Clear it.
b9110d6a 329 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
330 that the var is always cleared.
331
6c1bd3f3
EZ
3322012-01-07 Eli Zaretskii <eliz@gnu.org>
333
334 * search.c (scan_buffer): Pass character positions to
335 know_region_cache, not byte positions. (Bug#6540)
336
069d2b50
L
3372012-01-07 LynX <_LynX@bk.ru> (tiny change)
338
339 * w32.c (sys_rename): Report EXDEV when rename of a directory
340 fails because the target is on another logical disk. (Bug#10284)
341
75bf0d33
DB
3422012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
343
344 * xterm.c (x_embed_request_focus): New function.
345
346 * xterm.h: Add prototype.
347
348 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
349
1c6e5a32
GM
3502012-01-05 Glenn Morris <rgm@gnu.org>
351
352 * emacs.c (emacs_copyright): Update short copyright year to 2012.
353
651e947e
EZ
3542012-01-01 Eli Zaretskii <eliz@gnu.org>
355
356 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
357 Load gnutls_transport_set_lowat only if GnuTLS version is below
358 2.11.1.
359 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
360 GnuTLS versions below 2.11.1.
361
3778cdd8
AL
3622011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
363
364 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
365 to the doc string advising against its use for altering the way
366 windows are scrolled.
367
0e5317f7
KH
3682011-12-28 Kenichi Handa <handa@m17n.org>
369
370 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
371 coding-system ASCII compatible only when it does not produce BOM
372 on encoding (Bug#10383).
373
93d5ca1f
JD
3742011-12-26 Jan Djärv <jan.h.d@swipnet.se>
375
376 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
377 can scroll.
378 (create_and_show_popup_menu): Always use menu_position_func for
379 Gtk3 (Bug#10361).
380
ca22b785
AS
3812011-12-24 Andreas Schwab <schwab@linux-m68k.org>
382
383 * callint.c (Fcall_interactively): Don't truncate prompt string.
384
d048e1e6
EZ
3852011-12-23 Eli Zaretskii <eliz@gnu.org>
386
387 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
388 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 389 resumed from there (after widening). (Bug#10360)
d048e1e6 390
5ccaba1f
JD
3912011-12-22 Jan Djärv <jan.h.d@swipnet.se>
392
393 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
394
204ee57f
JD
3952011-12-21 Jan Djärv <jan.h.d@swipnet.se>
396
b81d40f0
JB
397 * nsterm.m (x_free_frame_resources):
398 Release f->output_data.ns->miniimage.
204ee57f
JD
399 (ns_index_color): Fix indentation. Do not retain
400 color_table->colors[i].
401
402 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
403 before returning.
404
405 * nsfns.m (x_set_background_color): Assign return value from
406 ns_index_color to face-background instead of NSColor*.
407 (ns_implicitly_set_icon_type): Fix indentation.
408 Change assignment in for loop to comparison.
409
410 * emacs.c (ns_pool): New variable.
411 (main): Assign ns_pool.
412 (Fkill_emacs): Call ns_release_autorelease_pool.
413
414 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
415 autorelease fdesc, release fdAttrs and tdict.
416 (ns_get_covering_families): Release charset.
417 (ns_findfonts): Release NSFontDescriptor created with new.
418 (ns_uni_to_glyphs): Fix indentation.
419 (setString): Release attrStr before assigning new value.
420
c803b2b7
JD
4212011-12-18 Jan Djärv <jan.h.d@swipnet.se>
422
678f4426
JD
423 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
424 and NS_IMPL_COCOA.
425 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
426 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
427
cd394be1 4282011-12-18 David Reitter <reitter@cmu.edu>
678f4426 429
5fecd5fc
JD
430 * nsterm.m (ns_term_init): Subscribe for notifications
431 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
432 to method trackingNotification in EmacsMenu.
433
434 * nsmenu.m (trackingMenu): New variable.
3771cb17 435 (trackingNotification): New method (from Aquamacs).
5fecd5fc 436 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 437 from Aquamacs (Bug#7030).
678f4426
JD
438
4392011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 440
c803b2b7
JD
441 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
442 (symbol_to_nsstring): Fix indentation.
443 (ns_symbol_to_pb): New function.
444 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
445 (Fns_rotate_cut_buffers_internal): Removed.
446 (Fns_store_selection_internal): Renamed from
447 Fns_store_cut_buffer_internal.
448 (ns_get_foreign_selection, Fx_own_selection_internal)
449 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
450 (Fns_get_selection_internal, Fns_store_selection_internal):
451 Use ns_symbol_to_pb and check if return value is nil.
452 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
453 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
454 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
455 renamed to Sns_store_selection_internal.
456 (ns_handle_selection_request): Move code to Fx_own_selection_internal
457 and remove this function.
458 (ns_handle_selection_clear): Remove, never used.
459 (Fx_own_selection_internal): Move code from ns_handle_selection_request
460 here.
461
e1b01a3a
KB
4622011-12-17 Ken Brown <kbrown@cornell.edu>
463
464 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
465 GID is unknown (Bug#10257).
466
2adb6e85
PE
4672011-12-17 Paul Eggert <eggert@cs.ucla.edu>
468
469 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
470 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
471 which caused a build failure on GNU/Linux IA-64. This problem was
472 introduced by my 2011-10-07 patch.
473
d1d7b339
JL
4742011-12-15 Juri Linkov <juri@jurta.org>
475
476 * image.c (imagemagick_error): New function. (Bug#10112)
477 (imagemagick_load_image): Comment out `MagickSetResolution' call.
478 Use `imagemagick_error' where ImageMagick functions return
479 `MagickFalse'.
480 (Fimagemagick_types): Add `Fnreverse' to return the list in the
481 proper order.
482
100d5755
KH
4832011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
484
485 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
486 fill background (Bug#8992).
487
454592a6
MR
4882011-12-13 Martin Rudalics <rudalics@gmx.at>
489
490 * window.c (Vwindow_combination_resize)
491 (Vwindow_combination_limit): Use t instead of non-nil in
492 doc-strings.
61d4b438
MR
493 (Vrecenter_redisplay): Add first sentence of doc-string on
494 separate line.
53524d93 495 (Frecenter): Fix doc-string typo.
454592a6 496
3633e3aa
KH
4972011-12-11 Kenichi Handa <handa@m17n.org>
498
499 * coding.c (Funencodable_char_position): Pay attention to the
500 buffer text relocation (Bug#9389).
501
7b9d523a
JD
5022011-12-10 Jan Djärv <jan.h.d@swipnet.se>
503
504 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
505 gtk_init (Bug#10100).
506
b73189c6
EZ
5072011-12-10 Eli Zaretskii <eliz@gnu.org>
508
509 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
510 IT->string is nil. (Bug#10263)
511
f7dfe5d6
JD
5122011-12-10 Jan Djärv <jan.h.d@swipnet.se>
513
83faebb4
JD
514 * nsterm.h (x_free_frame_resources): Declare.
515
f7dfe5d6
JD
516 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
517 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
518
519 * nsterm.h (ns_get_defaults_value): Declare.
520
521 * nsterm.m (ns_default): Call ns_get_defaults_value.
522
7cd4e72c
EZ
5232011-12-09 Eli Zaretskii <eliz@gnu.org>
524
525 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
526 (Bug#10170)
527
b34d7317
YM
5282011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
529
530 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
531 that where the value of an _OBJC_* symbol points to is in the .bss
532 section (Bug#10240).
533
76470ad1
KH
5342011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
535
536 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 537 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 538
745fff94
KH
5392011-12-08 Kenichi Handa <handa@m17n.org>
540
541 * ftfont.c (get_adstyle_property): Fix previous change
542 (Bug#10233).
543
6e44397c
JB
5442011-12-07 Juanma Barranquero <lekktu@gmail.com>
545
546 * w32.c (init_environment): If no_site_lisp, remove site-lisp
547 dirs from the default value of EMACSLOADPATH (bug#10208).
548
7efa6272
GM
5492011-12-07 Glenn Morris <rgm@gnu.org>
550
551 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
552 installation and source directories as well. (Bug#10208)
553
f6fc4d87
CY
5542011-12-06 Chong Yidong <cyd@gnu.org>
555
556 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
557
2bf26180
GM
5582011-12-06 Glenn Morris <rgm@gnu.org>
559
560 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
561 as an error, not just -1. (Bug#10217)
562
3a6ad4f0
CY
5632011-12-05 Chong Yidong <cyd@gnu.org>
564
565 * keyboard.c (process_special_events): New function.
566 (swallow_events, Finput_pending_p): Use it (Bug#10195).
567
75a3b399
PE
5682011-12-05 Paul Eggert <eggert@cs.ucla.edu>
569
570 * coding.c (encode_designation_at_bol): Don't use uninitialized
571 local variable (Bug#9318).
572
c3c9e25e
KH
5732011-12-05 Kenichi Handa <handa@m17n.org>
574
575 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
576 return Qnil (Bug#8046, Bug#10193).
577
5eb05ea3
KH
5782011-12-05 Kenichi Handa <handa@m17n.org>
579
580 * coding.c (encode_designation_at_bol): New args charbuf_end and
581 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
582 (coding_set_source): Return how many bytes coding->source was
583 relocated.
584 (coding_set_destination): Return how many bytes
585 coding->destination was relocated.
586 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
587 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
588
5892011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
590
591 * coding.c (CODING_CHAR_CHARSET_P): New macro.
592 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
593 macro (Bug#9318).
594
5952011-12-05 Andreas Schwab <schwab@linux-m68k.org>
596
597 The following changes are to fix Bug#9318.
598
a79703f5 599 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
600 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
601 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 602 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 603
7dbda6df
JB
6042011-12-05 Juanma Barranquero <lekktu@gmail.com>
605
606 * lisp.h (process_quit_flag): Fix external declaration.
607
6d5eb5b0
SM
6082011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
609
610 Don't macro-inline non-performance-critical code.
611 * eval.c (process_quit_flag): New function.
612 * lisp.h (QUIT): Use it.
613
a0c3fad0
JD
6142011-12-04 Jan Djärv <jan.h.d@swipnet.se>
615
616 * nsfns.m (get_geometry_from_preferences): New function.
617 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
618
6c07aac2
AS
6192011-12-04 Andreas Schwab <schwab@linux-m68k.org>
620
621 * emacs.c (Qkill_emacs): Define.
622 (syms_of_emacs): Initialize it.
623 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
624 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
625 (quit_throw_to_read_char): Add parameter `from_signal'.
626 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
627 * lisp.h (QUIT): Call Fkill_emacs if requested.
628
c052ead4
JD
6292011-12-03 Jan Djärv <jan.h.d@swipnet.se>
630
631 * widget.c (update_wm_hints): Return if wmshell is null.
632 (widget_update_wm_size_hints): New function.
633
634 * widget.h (widget_update_wm_size_hints): Declare.
635
636 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
637 widget_update_wm_size_hints (Bug#10104).
638
9e49252b
EZ
6392011-12-03 Eli Zaretskii <eliz@gnu.org>
640
641 * xdisp.c (handle_invisible_prop): If the invisible text ends just
642 before a newline, prepare the bidi iterator for consuming the
643 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 644 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 645
02b16839
JL
6462011-12-02 Juri Linkov <juri@jurta.org>
647
648 * search.c (Fword_search_regexp): New Lisp function created from
649 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
650 (Fword_search_backward, Fword_search_forward)
651 (Fword_search_backward_lax, Fword_search_forward_lax):
652 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
653 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
654
0068070e
SM
6552011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
656
657 * fileio.c (Finsert_file_contents): Move after-change-function call
658 to before the "handled:" label, since all "goto handled" appear in
659 cases where the *-change-functions have already been properly called
660 (bug#10117).
661
3360a3fc
AS
6622011-12-01 Andreas Schwab <schwab@linux-m68k.org>
663
664 * keyboard.c (interrupt_signal): Don't call kill-emacs when
665 waiting for input. (Bug#10169)
666
73d6c093
EZ
6672011-11-30 Eli Zaretskii <eliz@gnu.org>
668
669 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
670 verifies glyph row's hash code--we have just reallocated the
671 glyphs, so their contents can be complete garbage. (Bug#10164)
672
febe6bea
JB
6732011-11-30 Juanma Barranquero <lekktu@gmail.com>
674
675 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
676
801a4313
EZ
6772011-11-30 Eli Zaretskii <eliz@gnu.org>
678
679 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
680 attributes are tested _before_ calling verify_row_hash, to protect
681 against GCC re-ordering of the tests. (Bug#10164)
682
2b56b87e
JD
6832011-11-29 Jan Djärv <jan.h.d@swipnet.se>
684
685 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
686
687 * xterm.c (handle_one_xevent): Only set async_visible and friends
688 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 689 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
690 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
691
dbf31225
PE
6922011-11-28 Paul Eggert <eggert@cs.ucla.edu>
693
694 Remove GCPRO-related macros that exist only to avoid shadowing locals.
695 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
696 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
697 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
698 All uses changed to use GCPRO1 etc.
699 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
700 Revert to old implementation (i.e., before 2011-03-11).
701
1305621b
YM
7022011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
703
704 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
705 of scroll runs so as to avoid assigning disabled bogus rows and
706 unnecessary graphics copy operations.
707
8c9afb46
EZ
7082011-11-27 Eli Zaretskii <eliz@gnu.org>
709
710 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
711 (snprintf) [_MSC_VER]: Redirect to _snprintf.
712 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
713 (malloc, free, realloc, calloc): Redirect to e_* only when
714 compiling Emacs.
715
716 * lisp.h (GCTYPEBITS): Move before first use.
717 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
718 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
719 this macro definition.
720
721 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
722 _MSC_VER.
723
54e9e3bf
JD
7242011-11-27 Jan Djärv <jan.h.d@swipnet.se>
725
6d5eb5b0
SM
726 * gtkutil.c (xg_create_frame_widgets):
727 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
728 present with Gtk+ 2.0.
729
83aca1cb
PE
7302011-11-26 Paul Eggert <eggert@cs.ucla.edu>
731
732 * fileio.c (Finsert_file_contents): Undo previous change; see
733 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
734
5b76caa4
PE
7352011-11-26 Paul Eggert <eggert@cs.ucla.edu>
736
737 Rename locals to avoid shadowing.
738 * fileio.c (Finsert_file_contents):
739 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
740 * process.c (wait_reading_process_output):
741 Rename inner 'proc' to 'p' to avoid shadowing.
742 Indent for consistency with usual Emacs style.
743
8c535114
EZ
7442011-11-25 Eli Zaretskii <eliz@gnu.org>
745
746 * xdisp.c (redisplay_window): If cursor row is not fully visible
747 after recentering, and scroll-conservatively is set to a large
748 number, scroll window by a few more lines to make the cursor fully
749 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
750 (start_display): Don't move to the next line if the display should
751 start at a newline that is part of a display vector or an overlay
752 string. (Bug#10119)
8c535114 753
fa4fdb5c
JL
7542011-11-24 Juri Linkov <juri@jurta.org>
755
756 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
757 after the `MagickPingImage' call. (Bug#10112)
758
90ec88df
CY
7592011-11-23 Chong Yidong <cyd@gnu.org>
760
761 * window.c (Fcoordinates_in_window_p): Accept only live windows.
762
56e2e794
MR
7632011-11-23 Martin Rudalics <rudalics@gmx.at>
764
765 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
766 making another buffer current. (Bug#10114)
767
b6e64c41
GM
7682011-11-23 Glenn Morris <rgm@gnu.org>
769
770 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
771
6b21de18
CY
7722011-11-23 Chong Yidong <cyd@gnu.org>
773
774 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
775 using it (Bug#5984).
776
b12cd789
EZ
7772011-11-22 Eli Zaretskii <eliz@gnu.org>
778
779 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
780 and header-lines, as they don't have one computed for them.
781 (Bug#10098)
782
783 * .gdbinit (prow): Make displayed values more self-explaining.
784 Add row's hash code.
785
261b6fd4
LMI
7862011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
787
788 * process.c (wait_reading_process_output): Fix asynchrounous
789 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 790 (wait_reading_process_output): Add comment and URL.
261b6fd4 791
e7cfd277
JD
7922011-11-21 Jan Djärv <jan.h.d@swipnet.se>
793
794 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
795
a9b9b7f5
CY
7962011-11-21 Chong Yidong <cyd@gnu.org>
797
798 * window.c (Fnext_window, Fprevious_window): Doc fix.
799
b0d15b4f
SM
8002011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
801
802 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
803
fe7a3057
JB
8042011-11-20 Juanma Barranquero <lekktu@gmail.com>
805
806 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
807
d2999b1a
MR
8082011-11-20 Martin Rudalics <rudalics@gmx.at>
809
810 * window.c (Fset_window_combination_limit): Rename argument
811 STATUS to LIMIT.
812 (Vwindow_combination_limit): Remove "status" from doc-string.
813
d5ff9cd0
AS
8142011-11-20 Andreas Schwab <schwab@linux-m68k.org>
815
816 * m/ibms390.h: Remove.
817 * m/ibms390x.h: Don't include "ibms390.h".
818
a5bb9bd3
SM
8192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
820
821 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
822 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
823
cd1181db
JB
8242011-11-20 Juanma Barranquero <lekktu@gmail.com>
825
826 * casetab.c (Fset_case_table):
827 * charset.c (Fcharset_after): Fix typos.
828
615a3b8d 8292011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 830
17e845af
PE
831 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
832 Otherwise, valgrind does not work on some platforms.
833 Problem reported by Andreas Schwab in
6a0bf43d
PE
834 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
835 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
836 is set, removing the need for VIRT_ADDRESS_VARIES.
837 (PURE_P): Use a more-efficient implementation that needs just one
838 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
839 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
840 to 4 (xorl, subq, cmpq, setbe).
841 * alloc.c (pure): Always extern now, since that's the
842 VIRT_ADDR_VARIES behavior.
843 (PURE_POINTER_P): Use a single comparison, not two, for
844 consistency with the new puresize.h.
845 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
846 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
847 Remove VIRT_ADDR_VARIES no longer needed.
848
f8fe6f96
EZ
8492011-11-19 Eli Zaretskii <eliz@gnu.org>
850
851 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
852 (erase_phys_cursor, update_window_cursor, show_mouse_face)
853 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
854 behave as if the cursor position were at the window margin.
855
856 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
857 and the cursor position is out of bounds, behave as if the cursor
858 position were at the window margin. (Bug#10075)
859
df05a53c
CY
8602011-11-18 Chong Yidong <cyd@gnu.org>
861
862 * window.c (Fwindow_combination_limit): Make first argument
863 non-optional, since it is meaningless for live windows like the
864 selected window.
865
2071918e
DA
8662011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
867
868 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
869
b50a28de
SM
8702011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
871
872 * intervals.c: Fix grafting over the whole buffer (bug#10071).
873 (graft_intervals_into_buffer): Simplify.
874
015137db
EZ
8752011-11-18 Eli Zaretskii <eliz@gnu.org>
876
877 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
878 hash values of the two rows.
879 (copy_row_except_pointers): Preserve the used[] arrays and the
880 hash values of the two rows. (Bug#10035)
68c95424 881 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
882
883 * xdisp.c (row_hash): New function, body extracted from
884 compute_line_metrics.
885 (compute_line_metrics): Call row_hash, instead of computing the
886 hash code inline.
887
888 * dispnew.c (verify_row_hash): Call row_hash for computing the
889 hash code of a row, instead of duplicating code from xdisp.c.
890
891 * dispextern.h (row_hash): Add prototype.
892
a2addb04
TH
8932011-11-18 Tassilo Horn <tassilo@member.fsf.org>
894
895 * frame.c (delete_frame): Don't delete the terminal when the last
896 X frame is closed if emacs is built with GTK toolkit.
897
df85d315
JB
8982011-11-17 Juanma Barranquero <lekktu@gmail.com>
899
900 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
901
a0c2d0ae
MR
9022011-11-17 Martin Rudalics <rudalics@gmx.at>
903
904 * window.c (Vwindow_splits): Rename to
905 Vwindow_combination_resize. Suggested by Juri Linkov.
906 (Fsplit_window_internal): Use Vwindow_combination_resize instead
907 of Vwindow_splits.
908
58179cce
JB
9092011-11-16 Juanma Barranquero <lekktu@gmail.com>
910
7877f373
JB
911 * nsfns.m (Fns_font_name):
912 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 913
b6f67890
MR
9142011-11-16 Martin Rudalics <rudalics@gmx.at>
915
916 * window.h (window): Rename slot "nest" to "combination_limit".
917 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
918 (Fset_window_nest): Rename to Fset_window_combination_limit.
919 (Vwindow_nest): Rename to Vwindow_combination_limit.
920 (recombine_windows, make_parent_window, make_window)
921 (Fsplit_window_internal, saved_window)
922 (Fset_window_configuration, save_window_save): Rename all
923 occurrences of window_nest to window_combination_limit.
924
c7015153
JB
9252011-11-15 Juanma Barranquero <lekktu@gmail.com>
926
927 * image.c (imagemagick_load_image): Fix typo.
928
322ad6ec
EZ
9292011-11-14 Eli Zaretskii <eliz@gnu.org>
930
931 * xdisp.c (display_line): Move the call to
932 highlight_trailing_whitespace before the call to
933 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
934 faces of all the glyphs to compute ROW's hash value.
935 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 936
f067b8ec
JB
9372011-11-14 Juanma Barranquero <lekktu@gmail.com>
938
939 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
940 just return (bug#10044).
941
1e5b2111
EZ
9422011-11-12 Eli Zaretskii <eliz@gnu.org>
943
7ef3cbd5
EZ
944 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
945 with user-defined heap size. Bump the default size of the temacs
946 heap to 27MB, to avoid memory warning when running temacs.
947 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
948
1e5b2111
EZ
949 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
950 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
951 (verify_row_hash) [XASSERTS]: New function.
952 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
953 that the hash value of glyph rows is correct.
1e5b2111 954
89d61221
MR
9552011-11-12 Martin Rudalics <rudalics@gmx.at>
956
957 * window.h (window): Remove splits slot.
958 * window.c (Fwindow_splits, Fset_window_splits): Remove.
959 (Fdelete_other_windows_internal, make_parent_window)
960 (make_window, Fsplit_window_internal, Fdelete_window_internal)
961 (Fset_window_configuration, save_window_save): Don't deal with
962 split status of windows.
963 (saved_window): Remove splits slot.
964 (Vwindow_splits): Rewrite doc-string.
965
97f18cc8
JD
9662011-11-11 Jan Djärv <jan.h.d@swipnet.se>
967
968 * xfns.c (unwind_create_frame):
969 * nsfns.m (unwind_create_frame):
970 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
971 Vframe_list (Bug#9999).
972
22a648b4
DA
9732011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
974
0b381c7e 975 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 976
659afede
KH
9772011-11-11 Kenichi Handa <handa@m17n.org>
978
979 * callproc.c (Fcall_process): Set the member dst_multibyte of
980 process_coding.
981
9ac0394b
KH
9822011-11-11 Johan Bockgård <bojohan@gnu.org>
983
984 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
985 avoid a crash (bug#9496).
986
2fbdc249
CY
9872011-11-09 Chong Yidong <cyd@gnu.org>
988
989 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
990 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
991
ac6b1f81
PE
9922011-11-08 Paul Eggert <eggert@cs.ucla.edu>
993
994 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
995
09db192c
PE
9962011-11-08 Paul Eggert <eggert@cs.ucla.edu>
997
998 Avoid some portability problems by eschewing 'extern inline' functions.
999 The trivial performance wins aren't worth the portability hassles; see
1000 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1001 et seq.
1002 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1003 (window_box_width, window_box_left, window_box_left_offset)
1004 (window_box_right, window_box_right_offset): Undo previous change,
1005 by removing the "extern"s.
1006 * intervals.c (adjust_intervals_for_insertion)
1007 (adjust_intervals_for_deletion): Undo previous change,
1008 making these static again.
1009 (offset_intervals, temp_set_point_both, temp_set_point)
1010 (copy_intervals_to_string): No longer inline.
1011 * xdisp.c (window_text_bottom_y, window_box_width)
1012 (window_box_height, window_box_left_offset)
1013 (window_box_right_offset, window_box_left, window_box_right)
1014 (window_box): No longer inline.
1015
105216ed
CY
10162011-11-08 Chong Yidong <cyd@gnu.org>
1017
1018 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1019 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1020 Signal an error if not a live window.
105216ed
CY
1021 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1022 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1023
ae9e237f
JB
10242011-11-07 Juanma Barranquero <lekktu@gmail.com>
1025
1026 * lisp.h (syms_of_abbrev): Remove declaration.
1027 Reported by CHENG Gao <chenggao@royau.me>.
1028
c7aa8333
EZ
10292011-11-07 Eli Zaretskii <eliz@gnu.org>
1030
1031 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1032 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1033 of temacs in GUI mode.
1034
be7f5545
MR
10352011-11-07 Martin Rudalics <rudalics@gmx.at>
1036
1037 * window.h: Declare delete_all_child_windows instead of
1038 delete_all_subwindows.
1039 * window.c (Fwindow_nest, Fset_window_nest)
1040 (Fset_window_new_total, Fset_window_new_normal)
1041 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1042 (delete_all_subwindows): Rename to delete_all_child_windows.
1043 (Fdelete_other_windows_internal, Fset_window_configuration):
1044 Call delete_all_child_windows instead of delete_all_subwindows.
1045 * frame.c (delete_frame): Call delete_all_child_windows instead
1046 of delete_all_subwindows.
1047
ca78dc43
PE
10482011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1049
1050 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1051 This is also needed for porting to any host where GC_MARK_STACK is
1052 not GC_MAKE_GCPROS_NOOPS.
1053 (which_symbols): Use it.
1054
a0241d01
KH
10552011-11-07 Kenichi Handa <handa@m17n.org>
1056
1057 * coding.c (coding_set_destination): Check coding->src_pos only
1058 when coding->src_object is a buffer (bug#9910).
1059
1060 * process.c (send_process): Set the member src_multibyte of coding
1061 to 0 (bug#9911) when sending a unibyte text.
1062
1063 * callproc.c (Fcall_process): Set the member src_multibyte of
1064 process_coding to 0 (bug#9912).
1065
a64bfdfa 10662011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1067
1068 * xmenu.c (cleanup_widget_value_tree): New function.
1069 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1070 calling free_menubar_widget_value_tree directly (Bug#9830).
1071
cb41b32a
PE
10722011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1073
1074 Fix some portability problems with 'inline'.
1075 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1076 (window_box_width, window_box_left, window_box_left_offset)
1077 (window_box_right, window_box_right_offset): Declare extern.
1078 Otherwise, these inline functions do not conform to C99 and
1079 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1080 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1081 * intervals.c (adjust_intervals_for_insertion)
1082 (adjust_intervals_for_deletion): Now extern, because otherwise the
1083 extern inline functions 'offset_intervals' couldn't refer to it.
1084 (static_offset_intervals): Remove.
1085 (offset_intervals): Rewrite using the old contents of
1086 static_offset_intervals. The old version didn't conform to C99
1087 because an extern inline function contained a reference to an
1088 identifier with static linkage.
1089
b7041366
AS
10902011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1091
1092 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1093 GC.
1094
88a37c4d
EZ
10952011-11-06 Eli Zaretskii <eliz@gnu.org>
1096
1097 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1098 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1099 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1100 return Qleft_to_right.
1101
49745b39
CY
11022011-11-06 Chong Yidong <cyd@gnu.org>
1103
1104 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1105 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1106 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1107 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1108 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1109 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1110 (Fwindow_vscroll): Doc fix.
1111 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1112 argument, since it makes no sense to pass a live window and for
1113 consistency with window-child.
1114
1f05cd82
CS
11152011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1116
1117 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1118 support MSVC.
1119
22610910
JR
11202011-11-05 Jason Rumney <jasonr@gnu.org>
1121
1122 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1123 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1124 fonts (Bug#6029).
1125 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1126 bitwise arithmetic preventing use of unicode-sip and non-truetype
1127 opentype fonts.
1128
a06776b2
EZ
11292011-11-05 Eli Zaretskii <eliz@gnu.org>
1130
3ad924ba
EZ
1131 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1132 "emacs"-only part.
1133
a06776b2
EZ
1134 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1135 initialization code to keep similarity to xfns.c after changes
1136 from 2011-11-05.
1137
c9e7db78
JD
11382011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1139
a97f8f3f
JD
1140 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1141 (unwind_create_frame): New function (Bug#9943).
1142 (Fx_create_frame): Restructure code to be more similar to the one in
1143 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1144 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1145 Move terminal->reference_count++ just before making the frame official
1146 (Bug#9943).
1147
1148 * nsterm.m (x_free_frame_resources): New function.
1149 (x_destroy_window): Move code to x_free_frame_resources.
1150
c9e7db78 1151 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1152 (Fx_create_frame, x_create_tip_frame):
1153 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1154 official. Move initialization of image_cache_refcount and
1155 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1156
a6fc3b5c
EZ
11572011-11-05 Eli Zaretskii <eliz@gnu.org>
1158
1159 Support MSVC build with newer versions of Visual Studio.
1160 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1161 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1162 nt/gmake.defs.
1163
1164 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1165 which are not supported by MSVC.
1166 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1167 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1168 bitfields.
1169 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1170 types in bitfields.
1171 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1172
1173 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1174
58179cce 11752011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1176
1177 Support MSVC build with newer versions of Visual Studio.
1178 * w32.c: Don't include w32api.h for MSVC.
1179 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1180
1181 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1182 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1183 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1184 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1185 e_* cousins.
1186 (alloca) [_MSC_VER]: Define to _alloca.
1187
1188 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1189
1190 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1191
a58c13ed
EZ
11922011-11-04 Eli Zaretskii <eliz@gnu.org>
1193
1194 * xdisp.c (note_mouse_highlight): If either of
1195 previous/next-single-property-change returns nil, treat that as
1196 the beginning or the end of the buffer. (Bug#9955)
1197
fe0b6370
JD
11982011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1199
a58c13ed 1200 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1201 label is not null (Bug#9951).
1202 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1203 may be NULL.
1204
89bd5ee1
EZ
12052011-11-04 Eli Zaretskii <eliz@gnu.org>
1206
1207 * window.c (Fwindow_body_size): Mention in the doc string that the
1208 return value is in frame's canonical units. (Bug#9949)
1209
84c3edb9
EZ
12102011-11-03 Eli Zaretskii <eliz@gnu.org>
1211
4e2fb5c7
EZ
1212 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1213
84c3edb9 1214 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1215 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1216 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1217
bc17a887
EZ
12182011-11-01 Eli Zaretskii <eliz@gnu.org>
1219
1220 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1221 Don't stop backward scan on the continuation glyph, even though
1222 its CHARPOS is positive.
6d5eb5b0
SM
1223 (mouse_face_from_buffer_pos, note_mouse_highlight):
1224 Rename cover_string to disp_string.
bc17a887 1225
4ee88440
MR
12262011-11-01 Martin Rudalics <rudalics@gmx.at>
1227
1228 * window.c (temp_output_buffer_show): Don't use
1229 Vtemp_buffer_show_specifiers.
1230 (Vtemp_buffer_show_specifiers): Remove unused variable.
1231
c2ff3c02
EZ
12322011-10-30 Eli Zaretskii <eliz@gnu.org>
1233
1234 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1235 past the beginning of the current glyph matrix.
1236
58179cce 12372011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1238
1239 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1240 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1241 HAVE_GTK3 (Bug#9869).
b77a6a7f 1242
3b574623
JD
1243 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1244 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1245
b77a6a7f
JD
1246 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1247
1248 * xterm.c: Declare x_handle_net_wm_state to return int.
1249 (handle_one_xevent): Check if we are iconified but don't have
1250 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1251 (get_current_wm_state): Return non-zero if not hidden,
1252 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1253 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1254 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1255 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1256
196e41e4
PE
12572011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1260 so that this new function doesn't get optimized away by a
1261 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1262
021f2e1a
AS
12632011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1264
1265 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1266
8b058d44
EZ
12672011-10-29 Eli Zaretskii <eliz@gnu.org>
1268
1269 Fix the `xbytecode' command.
1270 * .gdbinit (xprintbytestr): New command.
b50a28de 1271 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1272 (xbytecode): Print the byte-code string as well.
1273
4452fb80
EZ
12742011-10-29 Kim Storm <storm@cua.dk>
1275
8b058d44
EZ
1276 * alloc.c (which_symbols): New function.
1277
21b72067
AS
12782011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1279
1280 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1281 line. (Bug#9903)
1282
83ed7b5c
GM
12832011-10-29 Glenn Morris <rgm@gnu.org>
1284
1285 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1286 Not clear what it was for, and it causes various bugs. (Bug#9839)
1287
5a7a728b
EZ
12882011-10-28 Eli Zaretskii <eliz@gnu.org>
1289
1290 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1291 possible random value that matches one of those tested as
1292 condition to clear the mouse face.
1293
d3d0842f
CY
12942011-10-28 Chong Yidong <cyd@gnu.org>
1295
1296 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1297
31b39d13
DN
12982011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1299
1300 * window.c (make_window): Initialize phys_cursor_on_p.
1301
9aba6043
SM
13022011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1303
1304 * lisp.h (struct Lisp_Symbol): Update comments.
1305
c20992f4
JB
13062011-10-28 Juanma Barranquero <lekktu@gmail.com>
1307
1308 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1309
db4f02f2
EZ
13102011-10-28 Eli Zaretskii <eliz@gnu.org>
1311
1312 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1313 <oslsachem@gmail.com> for helping to debug this.
1314
1315 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1316 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1317 (g_b_init_get_glyph_outline_w): New static variables.
1318 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1319 (GetGlyphOutlineW_Proc): New typedefs.
1320 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1321 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1322 New functions.
1323 (w32font_open_internal, compute_metrics):
1324 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1325 instead of calling the "wide" APIs directly.
1326
1327 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1328
1329 * w32.h (syms_of_w32font): Add prototype.
1330
87e68db4
JB
13312011-10-27 Juanma Barranquero <lekktu@gmail.com>
1332
1333 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1334 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1335 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1336 (Fmove_to_window_line): Doc fix.
1337
435c1d67
CY
13382011-10-27 Chong Yidong <cyd@gnu.org>
1339
1340 * process.c (make_process): Set gnutls_state to NULL.
1341
1342 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1343 non-NULL, regardless of GNUTLS_INITSTAGE.
1344 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1345 an error. Set process slots as soon as we allocate them.
1346
1347 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1348
9c6c6f49
CY
13492011-10-27 Chong Yidong <cyd@gnu.org>
1350
9aba6043
SM
1351 * gnutls.c (emacs_gnutls_deinit): New function.
1352 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1353 (Fgnutls_deinit, Fgnutls_boot): Use it.
1354
1355 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1356 (deactivate_process): Call emacs_gnutls_deinit.
1357
657d08d3
JB
13582011-10-27 Juanma Barranquero <lekktu@gmail.com>
1359
1360 * image.c (x_create_x_image_and_pixmap):
1361 * w32.c (sys_rename, w32_delayed_load):
1362 * w32font.c (fill_in_logfont):
1363 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1364
5430d399
JB
13652011-10-26 Juanma Barranquero <lekktu@gmail.com>
1366
1367 * w32fns.c (w32_default_color_map): New function,
1368 extracted from Fw32_default_color_map.
a7ef684b 1369 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1370
fe0055fa
PE
13712011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1372
1373 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1374
e6346438
SM
13752011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1376
1377 * keyboard.c (test_undefined): New function (bug#9751).
1378 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1379
e112cc37
ET
13802011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1381
1382 * sysdep.c (init_sys_modes): Fix the check for the controlling
1383 terminal (Bug#6649).
1384
7b5d6677
EZ
13852011-10-20 Eli Zaretskii <eliz@gnu.org>
1386
1387 * dispextern.h (struct bidi_it): New member next_en_type.
1388
1389 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1390 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1391 current character, check also for next_en_type being WEAK_EN.
1392 (bidi_resolve_weak): Don't enter the expensive loop if the current
1393 position is before next_en_pos. Record the bidi type of the first
1394 non-ET, non-BN character we find, in addition to its position.
1395 (bidi_level_of_next_char): Invalidate next_en_type when
1396 next_en_pos is over-stepped.
1397
7da0b018
PE
13982011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1399
1400 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1401 * editfns.c: Rewrite current-time-zone so that it invokes
1402 the equivalent of (format-time-string "%Z") to get the time zone name.
1403 This fixes a bug when the time zone name contains characters that
1404 need converting from the system time locale to Emacs internal format.
1405 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1406 that patch fixed format-time-string to do the conversion, but
1407 I forgot to fix current-time-zone.
1408 (format_time_string): New function, containing most of
1409 what Fformat_time_string used to contain.
1410 (Fformat_time_string): Rewrite in terms of format_time_string.
1411 This doesn't change this function's behavior.
1412 (current-time-zone): Rewrite to use format_time_string.
1413 This fixes the bug reported by Michael Schierl in
1414 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1415 Jason Rumney's 2007-06-07 change worked around this bug, but
1416 didn't fix it.
1417 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1418
8547b010
EZ
14192011-10-19 Eli Zaretskii <eliz@gnu.org>
1420
1421 * xdisp.c (start_display): If the character at POS is displayed
1422 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1423 (try_window_reusing_current_matrix): If a line ends in a display
1424 vector or the next line starts in a display vector, continue
1425 redrawing the window even though the character position of
1426 start_row was reached.
8547b010
EZ
1427 (Bug#9771, part 2)
1428
4e948d15
CY
14292011-10-18 Chong Yidong <cyd@gnu.org>
1430
1431 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1432 with nobreak-char-display too.
1433
4787455f
EZ
14342011-10-18 Eli Zaretskii <eliz@gnu.org>
1435
1436 Fix part 3 of bug#9771.
1437 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1438 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1439 non-neutral characters if the current character is a paragraph
1440 separator (a.k.a. Newline). This avoids running the same
1441 expensive loop twice, once when we consume the preceding newline
1442 and the other time when the line actually needs to be displayed.
1443 Avoid the loop when we see neutrals on the base embedding level
1444 following a character whose directionality is the same as the
1445 paragraph's. This avoids running the expensive loop when a line
1446 ends in a long sequence of neutrals, like control characters.
1447 Add assertion against STRONG_AL type. Slightly rearrange code
1448 that determines the type of a neutral given the first non-neutral
1449 that follows it.
1450 (bidi_level_of_next_char): Set next_en_pos to zero when
1451 invalidating its info.
1452
2c91f553
EZ
14532011-10-17 Eli Zaretskii <eliz@gnu.org>
1454
1455 * xdisp.c (push_display_prop): Determine whether to record string
1456 or buffer position by IT->string, not by IT->method. Allow
1457 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1458 (move_it_vertically_backward): Don't look for character position
1459 immediately after the newline when in a continuation line.
1460 (Bug#9771, part 1)
2c91f553 1461
c7b08b0d
MR
14622011-10-15 Martin Rudalics <rudalics@gmx.at>
1463
1464 * window.c (coordinates_in_window): Rewrite and delabelize
1465 vertical border check. (Bug#5357) (Bug#9618)
1466
6b02f655
SM
14672011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1468
1469 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1470 errors in XSetWindowBorder (bug#9310).
1471
81d40c92
DA
14722011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1473
1474 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1475 avoid crash when xmalloc overrun checking is enabled.
1476
d4172c3b
EZ
14772011-10-13 Eli Zaretskii <eliz@gnu.org>
1478
1479 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1480 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1481 cursor motion with <left> and <right> arrow keys.
1482
1483 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1484 some callers set that themselves.
1485
b00eea75
EZ
14862011-10-12 Eli Zaretskii <eliz@gnu.org>
1487
1488 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1489 display string and the previous row comes from the same string and
1490 is empty. (Bug#9739) (Bug#9738)
1491
8fe012c4
SM
14922011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1493
1494 * doc.c (get_doc_string): Encode file name (bug#9735).
1495
0074aef2
EZ
14962011-10-12 Eli Zaretskii <eliz@gnu.org>
1497
79beb178
EZ
1498 * bidi.c (bidi_level_of_next_char):
1499 * xdisp.c (get_visually_first_element): Remove old incorrect
1500 comments regarding the Unicode Line Separator character.
1501
0074aef2
EZ
1502 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1503
6e4b3fbe
DA
15042011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1505
1506 * alloc.c (Fgc_status): Do not access beyond zombies array
1507 boundary if nzombies > MAX_ZOMBIES.
1508 * alloc.c (dump_zombies): Add missing format specifier.
1509
0324f3af
PE
15102011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1511
b5525cac
PE
1512 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1513 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1514
0324f3af
PE
1515 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1516 Some packages use them to denote characters with modifiers.
1517
e9b5f888
AS
15182011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1519
1520 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1521 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1522 matching a pp-number. Rename parameter var to var1.
1523
127827c0
SM
15242011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1525
1526 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1527
c8fd3bd0
GM
15282011-10-08 Glenn Morris <rgm@gnu.org>
1529
1530 * callint.c (Fcall_interactively): Give a more explicit error for the
1531 'c' case with a non-character input. (Bug#8479)
1532
352ec8ff
EZ
15332011-10-08 Eli Zaretskii <eliz@gnu.org>
1534
03669ccb
EZ
1535 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1536 lines.
7061c986
EZ
1537 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1538 lines that are hscrolled on the left.
03669ccb 1539
352ec8ff
EZ
1540 * dispnew.c (buffer_posn_from_coords): Account for a possible
1541 presence of header-line. (Bug#4426)
1542
a66cfb1c
SM
15432011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1544
6b02f655
SM
1545 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1546 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1547
7c5ee88e
PE
15482011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1549
1550 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1551 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1552 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1553 this makes Emacs dump core during garbage collection on rare
1554 occasions. sizeof is obviously inferior to offsetof here, so
1555 stick with offsetof.
1556 (GC_POINTER_ALIGNMENT): New macro.
1557 (mark_memory): Omit 3rd (offset) arg; caller changed.
1558 Don't assume EMACS_INT alignment is the same as pointer alignment.
1559
df1bbe5b
SM
15602011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1561
1562 * keyboard.c (read_key_sequence_remapped): New var.
1563 (read_key_sequence): Compute remapping in the right buffer.
1564 (command_loop_1): Use read_key_sequence's remapping directly.
1565
51553db6
SM
15662011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1567
32c1fffd
SM
1568 * dired.c (file_name_completion): Don't expand file name.
1569 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1570 before checking file name handler.
1571
51553db6
SM
1572 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1573 they've been requested explicitly (bug#9591).
1574
b6bd1599 15752011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1576
1577 * keymap.c (Fsingle_key_description): Use make_specified_string
1578 instead of build_string to build string from push_key_description.
1579 (Bug#5193)
1580
f701dc2a
PE
15812011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1582
4222c55d
PE
1583 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1584 This fixes a Y2038 bug on 64-bit hosts.
1585 * buffer.c (reset_buffer):
1586 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1587 (Fclear_buffer_auto_save_failure):
1588 Use 0, not -1, to represent an unset failure time, since time_t
1589 might not be signed.
1590
f701dc2a
PE
1591 Remove dependency on glibc malloc internals.
1592 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1593 Move back here from lisp.h, but with their new implementations.
1594 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1595 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1596 * charset.c (charset_table_init): New static var.
1597 (syms_of_charset): Use it instead of xmalloc. This removes a
1598 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1599 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1600 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1601 Move back to alloc.c.
1602 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1603 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1604
9ceebf39
JD
16052011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1606
1607 * nsterm.m (windowDidResize): Call x_set_window_size only when
1608 ns_in_resize is true. Otherwise set pixelwidth/height and
1609 call change_frame_size (Bug#9628).
1610
cb993c58
PE
16112011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1612
3930c88b
PE
1613 Port --enable-checking=all to Fedora 14 x86-64.
1614 * charset.c (syms_of_charset): Also account for glibc malloc's
1615 internal overhead when calculating the initial malloc maximum.
1616
cb993c58
PE
1617 Port --enable-checking=all to Fedora 14 x86.
1618 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1619 Move to lisp.h.
1620 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1621 (overrun_check_realloc, overrun_check_free):
1622 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1623 That way, xmalloc returns a properly-aligned pointer even if
1624 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1625 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1626 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1627 into account when calculating the initial malloc maximum.
1628 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1629 Move here from alloc.c, so that charset.c can use it too.
1630 Properly align; the old code wasn't right for common 32-bit hosts
1631 when configured with --enable-checking=all.
1632 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1633 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1634
31bed486
EZ
16352011-09-29 Eli Zaretskii <eliz@gnu.org>
1636
04c70788 1637 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1638 use EDOM.
1639
fbcaa2f3
EZ
16402011-09-28 Eli Zaretskii <eliz@gnu.org>
1641
1642 * xdisp.c (compute_display_string_end): If there's no display
1643 string at CHARPOS, return -1.
1644
1645 * bidi.c (bidi_fetch_char): When compute_display_string_end
1646 returns a negative value, treat the character as a normal
1647 character not covered by a display string. (Bug#9624)
1648
a239d4e9
JB
16492011-09-28 Juanma Barranquero <lekktu@gmail.com>
1650
1651 * lread.c (Fread_from_string): Fix typo in docstring.
1652
88652fd5
EZ
16532011-09-27 Eli Zaretskii <eliz@gnu.org>
1654
1655 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1656 newline, reseat the iterator instead of bidi-iterating there one
1657 character at a time. (Bug#9610)
32c1fffd
SM
1658 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1659 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1660
ed497dd4
AS
16612011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1662
1663 * lread.c (readevalloop): Use correct code for NBSP.
1664 (read1): Likewise. (Bug#9608)
1665
b2bf61aa
MA
16662011-09-25 Michael Albinus <michael.albinus@gmx.de>
1667
1668 * dbusbind.c (Fdbus_register_signal): When service is not
1669 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1670
32bbb17c
GM
16712011-09-25 Glenn Morris <rgm@gnu.org>
1672
1673 * buffer.c (truncate-lines): Doc fix.
1674
94e0933e
CY
16752011-09-24 Chong Yidong <cyd@stupidchicken.com>
1676
1677 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1678 (Fset_window_next_buffers): Doc fix.
1679
cddde921
GM
16802011-09-24 Glenn Morris <rgm@gnu.org>
1681
1682 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1683
1260aef1
PE
16842011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1685
25b4bfa0
PE
1686 Fix minor problems found by static checking.
1687 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1688 * indent.c (Fvertical_motion): Fix == vs = typo.
1689
e3cbd34b
EZ
16902011-09-24 Eli Zaretskii <eliz@gnu.org>
1691
a66cfb1c
SM
1692 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1693 Default value is now t. Doc fix.
6bf7006f 1694
e3cbd34b 1695 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1696 logic when moving up, not only when moving down. Fix the
e3cbd34b 1697 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1698 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1699
1700 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1701 CHARPOS is covered by a display string which includes newlines.
1702 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1703 is covered by a display string with embedded newlines.
1704
a3de0cbd
MA
17052011-09-24 Michael Albinus <michael.albinus@gmx.de>
1706
1707 * dbusbind.c (Fdbus_register_signal): Add match rule to
1708 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1709 (Fdbus_register_method, Vdbus_registered_objects_table):
1710 Fix docstring.
a3de0cbd 1711
b260039d
JM
17122011-09-24 Jim Meyering <meyering@redhat.com>
1713
32c1fffd 1714 do not ignore write error for any output size
b260039d
JM
1715 The previous change was incomplete.
1716 While it makes emacs --batch detect the vast majority of stdout
1717 write failures, errors were still ignored whenever the output size is
1718 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1719 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1720 && echo FAIL: ignored write error
1721 FAIL: ignored write error
1722 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1723 && echo FAIL: ignored write error
1724 FAIL: ignored write error
1725 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1726
8eca8a7c
AS
17272011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1728
1729 * emacs.c (Fkill_emacs): In noninteractive mode exit
1730 non-successfully if a write error occurred on stdout. (Bug#9574)
1731
3341db62
EZ
17322011-09-21 Eli Zaretskii <eliz@gnu.org>
1733
1734 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1735 the xassert test.
1736
1737 * dispextern.h (struct it): Update the comment documenting what
1738 can it->OBJECT be.
1739
8c203dbf
EZ
17402011-09-20 Eli Zaretskii <eliz@gnu.org>
1741
1742 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1743 a display string, extend search for cursor position to end of row.
1744 (find_row_edges): If the row ends in a newline from a display
1745 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1746 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1747 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1748 non-empty line. Fixes confusing cursor motion with arrow keys at
1749 the beginning of a line that starts with whitespace.
8c203dbf 1750
a4824228
LMI
17512011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1752
1753 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1754 (bug#9493).
1755
33ed493b
CY
17562011-09-18 Chong Yidong <cyd@stupidchicken.com>
1757
1758 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1759 boolean (Bug#9154).
1760
56cd55c8
EZ
17612011-09-18 Eli Zaretskii <eliz@gnu.org>
1762
1763 * xdisp.c (display_line): Record maximum and minimum buffer
1764 positions even if no glyphs were produced (e.g., by a zero-width
1765 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1766 buffer positions that will be removed from the glyph row because
1767 they don't fit.
c02dcedf
EZ
1768 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1769 column is beyond frame width: don't subtract 1 "pixel" when
1770 computing width of the stretch.
3e62b7e0
EZ
1771 (reseat_at_next_visible_line_start): Undo the change made on
1772 2011-09-17 that saved paragraph information and restored it after
1773 the call to `reseat'. (Bug#9545)
56cd55c8 1774
5ed99d36 17752011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1776
1777 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1778 and turn window cursor on if cleared (Bug#9415).
1779
5ed99d36 17802011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1781
1782 * search.c (boyer_moore): Take unibyte characters from pattern
1783 literally. (Bug#9458)
1784
9bade7b2
EZ
17852011-09-18 Eli Zaretskii <eliz@gnu.org>
1786
1787 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1788
e5e9d610
PE
17892011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1790
87e4427a
PE
1791 Fix minor problem found by static checking.
1792 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1793 initialized, to pacify gcc -Wuninitialized.
1794
e5e9d610
PE
1795 * fileio.c: Report proper errno when syscall falls.
1796 (Finsert_file_contents): Save and restore errno,
1797 so that report_file_error outputs the correct diagnostic.
1798 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1799
a1674f0b
EZ
18002011-09-18 Eli Zaretskii <eliz@gnu.org>
1801
1802 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1803
fbfb6dd4
EZ
18042011-09-17 Eli Zaretskii <eliz@gnu.org>
1805
1806 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1807 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1808
bb187662
EZ
18092011-09-17 Eli Zaretskii <eliz@gnu.org>
1810
1137e8b8 1811 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1812 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1813
1814 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1815 (bidi_find_paragraph_start): Search back for paragraph beginning
1816 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1817 (bidi_move_to_visually_next): Only trigger paragraph-related
1818 computations when the last character is a newline or at EOB, not
1819 just any NEUTRAL_B. (Bug#9470)
1820
bb187662
EZ
1821 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1822 truncated lines if point is covered by a display string. (Bug#9524)
1823
2e621251
PE
18242011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1825
1826 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1827 (cons_to_x_long): New function.
1828 (lisp_data_to_selection_data): Use it. Correct the test for
1829 short-versus-long data; it was negated. Break out of vector
1830 loop, for efficiency, when a long datum is discovered.
1831
91a15bc6
SM
18322011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1833
1834 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1835
b41c3a35
EZ
18362011-09-16 Eli Zaretskii <eliz@gnu.org>
1837
1838 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1839 GCC PR/17406) by declaring this function with external scope.
1840
7812ba2d
PE
18412011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1842
1843 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1844 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1845
cf7edc2a
AS
18462011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1847
1848 * editfns.c (Fformat): Correctly handle text properties on "%%".
1849
bd01620e
EZ
18502011-09-15 Eli Zaretskii <eliz@gnu.org>
1851
1852 * xterm.c (x_draw_composite_glyph_string_foreground):
1853 * w32term.c (x_draw_composite_glyph_string_foreground):
1854 * term.c (encode_terminal_code):
1855 * composite.c (composition_update_it, get_composition_id):
1856 * xdisp.c (get_next_display_element)
1857 (fill_composite_glyph_string): Add comments about special meaning
1858 of TAB characters in a composition.
1859
a02719a3
PE
18602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1861
1862 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1863 This occurs when processing a multibyte format.
1864 Problem reported by Wolfgang Jenker.
a02719a3 1865
72589a3c
JB
18662011-09-15 Johan Bockgård <bojohan@gnu.org>
1867
1868 * xdisp.c (try_cursor_movement): Only check for exact match if
1869 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1870
1c14176c
PE
18712011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1872
1873 Remove unused external symbols.
1874 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1875 * xdisp.c (calc_pixel_width_or_height): Now static.
1876 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1877 * indent.c (check_display_width):
1878 * w32term.c: Fix comment to match code.
1879 * xterm.c, xterm.h (x_catching_errors): Remove.
1880
d2eea5b5
PE
18812011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1882
1883 * xselect.c: Use signed conversions more consistently (Bug#9498).
1884 (selection_data_to_lisp_data): Assume incoming selection data are
1885 signed integers, not unsigned. This is to be consistent with
1886 outgoing selection data, which was modified to use signed integers
1887 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1888 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1889 expects long, not unsigned long.
1890
46888499
EZ
18912011-09-14 Eli Zaretskii <eliz@gnu.org>
1892
1893 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1894 computation of loop end. Reported by Johan Bockgård
1895 <bojohan@gnu.org>.
1896
ef8ef9fb
CY
18972011-09-13 Chong Yidong <cyd@stupidchicken.com>
1898
1899 * frame.c (Fother_visible_frames_p): Function deleted.
1900
fa819fed
EZ
19012011-09-12 Eli Zaretskii <eliz@gnu.org>
1902
1903 * indent.c (compute_motion): Process display vector front to back
1904 rather than the other way around. (Bug#2496)
1905
2ba8e008
SM
19062011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1907
1908 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1909
20f53c69
CY
19102011-09-11 Chong Yidong <cyd@stupidchicken.com>
1911
1912 * minibuf.c (Fread_from_minibuffer): Doc fix.
1913
d562d7a4
EZ
19142011-09-11 Eli Zaretskii <eliz@gnu.org>
1915
1916 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1917 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1918
1c4d7f3d
LMI
19192011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1920
1921 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1922 value for non-existent files.
1923
b885bf36
EZ
19242011-09-11 Eli Zaretskii <eliz@gnu.org>
1925
1926 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1927 set its "size" to -1. This will set the modtime_size field of
1928 the corresponding buffer to -1, which is what
1929 verify-visited-file-modtime expects for files that do not exist.
1930 (Bug#9139)
1931
6612f0bf
PE
19322011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1933
1934 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1935 here ...
1936 * lisp.h: ... from here. push_key_description is no longer
1937 defined in keyboard.c, so its declaration should not be in
1938 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1939 logically belongs with push_key_description.
1940
dfb3f755
PE
19412011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1942
1943 * buffer.h: Include <sys/types.h> instead of <time.h>.
1944 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1945 Problem reported by Herbert J. Skuhra.
1946
3134906c
LMI
19472011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1948
1949 * xml.c (parse_region): Make the parsing work for
1950 non-comment-starting XML files again (bug#9144).
1951
8d903f4e
AS
19522011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1953
1954 * image.c (gif_load): Fix calculation of bottom and right corner.
1955 (Bug#9468)
1956
80ad64f4
EZ
19572011-09-10 Eli Zaretskii <eliz@gnu.org>
1958
1959 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1960 redisplay in small windows.
1961
208a048d
EZ
19622011-09-09 Eli Zaretskii <eliz@gnu.org>
1963
1964 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1965
9b1c252e
MR
19662011-09-08 Martin Rudalics <rudalics@gmx.at>
1967
1968 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1969 Operate on live windows only.
1970
2949f33b
JB
19712011-09-08 Juanma Barranquero <lekktu@gmail.com>
1972
1973 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1974
e08dcafd
EZ
19752011-09-07 Eli Zaretskii <eliz@gnu.org>
1976
1977 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1978 only under bidi iteration.
1979
115b96bd
JD
19802011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1981
1982 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1983
c8199d0f
PE
19842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1985
1986 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1987 Without this fix, the command to link temacs failed due to an
1988 undefined symbol __builtin_isnan. This is because
1989 /usr/include/iso/math_c99.h #defines isnan(x) to
1990 __builtin_isnan(x), but the bundled gcc, which identifies itself
1991 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1992 a __builtin_isnan.
1993 * floatfns.c (isnan): #undef, and then #define to a clone of
1994 what's in data.c.
1995 (Fisnan): Always define, since it's always available now.
1996 (syms_of_floatfns): Always define isnan at the Lisp level.
1997
e39b275c 19982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1999
2000 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2001
b2db44d9 20022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2003
f4af5137 2004 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2005 The previous code assumed that file offsets (off_t values) fit in
2006 EMACS_INT variables, which is not true on typical 32-bit hosts.
2007 The code messed up by falsely reporting buffer overflow in cases
2008 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2009 when "big" contains more than 2**29 bytes, even though this
2010 inserts just one byte and does not overflow the buffer.
2011 (Finsert_file_contents): Store file offsets as off_t
2012 values, not as EMACS_INT values. Check for overflow when
2013 converting between EMACS_INT and off_t. When checking for
2014 buffer overflow or for overlap, take the offsets into account.
2015 Don't use EMACS_INT for small values where int suffices.
2016 When checking for overlap, fix a typo: ZV was used where
2017 ZV_BYTE was intended.
2018 (Fwrite_region): Don't assume off_t fits into 'long'.
2019 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2020
ecfc0a49
MA
20212011-09-05 Michael Albinus <michael.albinus@gmx.de>
2022
2023 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2024
6511acf2 20252011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2026
0999621a 2027 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2028
2029 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2030 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2031 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2032 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2033 (modify_event_symbol): Do not assume that the length of
2034 name_alist_or_stem is safe to alloca and fits in int.
2035 (Fexecute_extended_command): Likewise for function name and binding.
2036 (Frecursion_depth): Wrap around reliably on integer overflow.
2037 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2038 since some callers pass EMACS_INT values.
2039 (Fsingle_key_description): Don't crash if symbol name contains more
2040 than MAX_ALLOCA bytes.
2041 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2042 (get_minibuffer): Arg is now EMACS_INT, not int.
2043 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2044 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2045 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2046
2be7d702
PE
2047 * dbusbind.c (signature_cat): New function.
2048 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2049 Do not overrun buffer; instead, report string overflow.
2050
9d1df220
PE
2051 * dispnew.c (add_window_display_history): Don't overrun buffer.
2052 Truncate instead; this is OK since it's just a log.
2053
33ef5c64
PE
2054 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2055 even if the time zone offset is outlandishly large.
2056 Don't mishandle offset == INT_MIN.
2057
66c6fdd5
PE
2058 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2059 when creating daemon; the previous buffer-overflow check was incorrect.
2060
d749b01b
PE
2061 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2062 which has the guts of the old verror function.
2063
b5cd1905
PE
2064 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2065 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2066
6e1a67fb
PE
2067 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2068 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2069 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2070 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2071 length of string rather than counting it via multiple sprintfs;
2072 that's simpler and more reliable.
c21721cc
PE
2073 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2074 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2075 sprintf, in case result does not fit in int.
2076
c57b67fc
PE
2077 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2078 (fontset_from_font): Print it.
2079
8a401434
PE
2080 * frame.c (tty_frame_count): Now printmax_t, not int.
2081 (make_terminal_frame, set_term_frame_name): Print it.
2082 (x_report_frame_params): In X, window IDs are unsigned long,
2083 not signed long, so print them as unsigned.
2084 (validate_x_resource_name): Check for implausibly long names,
2085 and don't assume name length fits in 'int'.
2086 (x_get_resource_string): Don't blindly alloca invocation name;
2087 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2088 not fit in int.
2089
6e1a67fb
PE
2090 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2091 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2092 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2093
0df02bf3
PE
2094 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2095 Use esprintf, not sprintf, in case result does not fit in int.
2096
48e30793
PE
2097 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2098 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2099 it as a large positive number.
2100 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2101 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2102
a66ff6d8
PE
2103 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2104 in case result does not fit in int.
2105
aca216ff
PE
2106 * print.c (float_to_string): Detect width overflow more reliably.
2107 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2108 buffer overrun. Don't assume list length fits in 'int'. Treat
2109 print length of 0 as 0, not as infinity; to be consistent with other
2110 uses of print length in this function. Don't overflow print length
2111 index. Don't assume hash table size fits in 'long', or that
2112 vectorlike size fits in 'unsigned long'.
2113
31c286f7
PE
2114 * process.c (make_process): Use printmax_t, not int, to format
2115 process-name gensyms.
2116
55e5faa1
PE
2117 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2118
80f2e268
PE
2119 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2120 to avoid potential buffer overrun.
2121
670741ab
PE
2122 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2123 if X resource line is longer than 512 bytes.
2124
b7163a50
PE
2125 * xfns.c (x_window): Make sprintf buffer a bit bigger
2126 to avoid potential buffer overrun.
2127
ae58ff1f
PE
2128 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2129
c43c8a6a
PE
2130 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2131
3f8236f4
PE
21322011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2133
53e9fe90 2134 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2135 Without these, Emacs silently mishandles large integers sometimes.
2136 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2137 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2138
6511acf2
PE
2139 * xdisp.c (try_window_id): Check Emacs fixnum range before
2140 converting to 'int'.
806add1d 2141
6511acf2 2142 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2143 Check that an Emacs fixnum is in range before assigning it to 'int'.
2144 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2145 values converted from Emacs fixnums.
2146 (Frecenter): Don't wrap around a line count if it is out of 'int'
2147 range; instead, treat it as an extreme value.
2148 (Fset_window_configuration, compare_window_configurations):
2149 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2150
6511acf2
PE
2151 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2152 that can exceed INT_MAX. Check that EMACS_INT value is in range
2153 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2154 (match_limit): Don't assume that a fixnum can fit in 'int'.
2155
6511acf2 2156 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2157 exceed INT_MAX.
2158
6511acf2 2159 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2160 (Fvertical_motion): Don't wrap around LINES values that don't fit
2161 in 'int'. Instead, treat them as extreme values. This is good
2162 enough for windows, which can't have more than INT_MAX lines anyway.
2163
fcb901a7
LMI
21642011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2165
0f2f6b6d
LMI
2166 * Require libxml/parser.h to avoid compilation warning.
2167
fcb901a7
LMI
2168 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2169
2170 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2171 since this reportedly can destroy thread storage.
2172
6e20a0d4
CY
21732011-08-30 Chong Yidong <cyd@stupidchicken.com>
2174
2175 * syntax.c (find_defun_start): Update all cache variables if
2176 exiting early (Bug#9401).
2177
148ae00e
EZ
21782011-08-30 Eli Zaretskii <eliz@gnu.org>
2179
f6cfbd8f
EZ
2180 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2181
148ae00e
EZ
2182 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2183 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2184 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2185
2186 * term.c (tty_append_glyph): New function.
2187 (produce_stretch_glyph): Static function and its prototype deleted.
2188
a66cfb1c
SM
2189 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2190 Add prototypes.
148ae00e 2191
c4a07a4c
PE
21922011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2193
2194 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2195 when checking :margin (Bug#9390).
2196 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2197 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2198 so that the name doesn't mislead. All uses changed.
2199
6bc8cd65
JB
22002011-08-28 Johan Bockgård <bojohan@gnu.org>
2201
2202 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2203 set_tty_hooks.
2204
dca4927e
EZ
22052011-08-27 Eli Zaretskii <eliz@gnu.org>
2206
2207 * xdisp.c (move_it_to): Don't bail out early when reaching
2208 position beyond to_charpos, if we are scanning backwards.
2209 (move_it_vertically_backward): When DY == 0, make sure we get to
2210 the first character in the line after the newline.
2211
f2cad773
PE
22122011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2213
2214 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2215 (ccl_driver): Do not generate an out-of-range pointer.
2216 (Fccl_execute_on_string): Remove unnecessary check for
2217 integer overflow, noted by Stefan Monnier in
2218 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2219 Remove a FIXME that didn't need fixing.
2220 Simplify the newly-introduced buffer reallocation code.
2221
0cae2cdb
JB
22222011-08-27 Juanma Barranquero <lekktu@gmail.com>
2223
2224 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2225
5fc295a4 22262011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2227
70c60eb2 2228 Integer and memory overflow issues (Bug#9196).
726e0ab1 2229
d31850da
PE
2230 * doc.c (get_doc_string): Rework so that
2231 get_doc_string_buffer_size is the actual buffer size, rather than
2232 being 1 less than the actual buffer size; this makes xpalloc more
2233 convenient.
2234
a69fbedb
PE
2235 * image.c (x_allocate_bitmap_record, cache_image):
2236 * xselect.c (Fx_register_dnd_atom):
2237 Simplify previous changes by using xpalloc.
2238
fe5c5d37
PE
2239 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2240 since either will do and ptrdiff_t is convenient with xpalloc.
2241
0065d054
PE
2242 * charset.c (charset_table_size)
2243 (struct charset_sort_data.priority): Now ptrdiff_t.
2244 (charset_compare): Don't overflow if priorities differ greatly.
2245 (Fsort_charsets): Don't assume list length fits in int.
2246 Check for size-calculation overflow when allocating sort data.
2247 (syms_of_charset): Allocate an initial charset table that is
2248 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2249
2250 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2251
2252 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2253 The actual value is always <= INT_MAX, and leaving it unsigned made
2254 overflow checking harder.
2255
2256 * dispextern.h (struct glyph_matrix.rows_allocated)
2257 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2258 with xpalloc. The values are still always <= INT_MAX.
2259
2260 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2261
2262 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2263 (SAFE_NALLOCA): New macro.
2264
2265 * region-cache.c (struct boundary.pos, find_cache_boundary)
2266 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2267 (set_cache_region, invalidate_region_cache)
2268 (revalidate_region_cache, know_region_cache, region_cache_forward)
2269 (region_cache_backward, pp_cache):
2270 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2271 so that ptrdiff_t * can be passed to xpalloc.
2272 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2273 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2274 (pp_cache): Don't assume cache_len fits in int.
2275 * region-cache.h: Adjust extern decls to match.
2276
2277 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2278 EMACS_INT, since either will do, for xpalloc.
2279
2280 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2281 (xnmalloc, xnrealloc, xpalloc): New functions.
2282
726e0ab1
PE
2283 * bidi.c (bidi_shelve_header_size): New constant.
2284 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2285 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2286
51f30bc5 2287 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2288 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2289 (overlay_strings):
2290 Don't update size of array until after memory allocation succeeds,
2291 because xmalloc/xrealloc may not return.
0065d054
PE
2292 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2293 now that we have proper integer overflow checking.
2294 (record_overlay_string, overlay_strings): Catch overflows when
2295 calculating size of overlay_str_buf.
726e0ab1 2296
0065d054
PE
2297 * callproc.c (Fcall_process): Check for size overflow when
2298 calculating size of args2.
2299 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2300 Normally we prefer signed values, but sticking with ptrdiff_t would
2301 require adding more-complicated checks.
726e0ab1
PE
2302
2303 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2304 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2305 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2306 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2307
2308 * character.c (Fstring): Check for size-calculation overflow.
2309
2310 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2311 unnecessary integer overflow. Check for size overflow.
2312 (encode_coding_object): Don't update size until xmalloc succeeds.
2313
2314 * composite.c (get_composition_id): Check for overflow in glyph
2315 length calculations.
2316
2317 Integer and memory overflow fixes for display code.
2318 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2319 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2320 (scrolling_window): Check for overflow in size calculations.
2321 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2322 Don't assume glyph table len fits in int.
2323 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2324 (row_table_size): Now ptrdiff_t, not int.
2325 (scrolling_window): Avoid overflow in size calculations.
2326 Don't update size until allocation succeeds.
2327 * fns.c (concat): Check for overflow in size calculations.
2328 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2329 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2330 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2331
2332 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2333 (get_doc_string): Check for size calculation overflow.
2334 Don't update size until allocation succeeds.
2335 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2336 EMACS_INT, where ptrdiff_t will do.
2337 (Fsubstitute_command_keys): Check for string overflow.
2338
2339 * editfns.c (set_time_zone_rule): Don't assume environment length
2340 fits in int.
2341 (message_length): Now ptrdiff_t, not int.
2342 (Fmessage_box): Don't update size until allocation succeeds.
2343 Don't assume message length fits in int.
2344 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2345
0065d054
PE
2346 * emacs.c (main): Do not reallocate argv, since there is a null at
2347 the end that can be overwritten, and this way there's no need to
2348 worry about size-calculation overflow.
2349 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2350
2351 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2352 alloc succeeds.
2353 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2354
2355 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2356 (x_set_scroll_bar_width, x_figure_window_size):
2357 Check for integer overflow.
2358 (x_set_alpha): Do not assume XINT fits in int.
2359
2360 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2361 This is for the members text_lines, text_cols, total_lines, total_cols,
2362 where the system imposes an 'int' limit.
2363
2364 * fringe.c (Fdefine_fringe_bitmap):
2365 Don't update size until alloc works.
2366
2367 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2368 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2369
2370 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2371 Check for size-calculation overflow.
2372 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2373 do, as we prefer signed integers.
2374 (id_to_widget.max_size, id_to_widget.used)
2375 (xg_store_widget_in_map, xg_remove_widget_from_map)
2376 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2377 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2378 Use and return ptrdiff_t, not int.
2379 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2380 * gtkutil.h: Change prototypes to match the above.
2381
2382 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2383 are duplicate now that they've been promoted to lisp.h.
2384 (x_allocate_bitmap_record, x_alloc_image_color)
2385 (make_image_cache, cache_image, xpm_load):
2386 Don't update size until alloc is done.
2387 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2388 (x_detect_edges):
3256efce 2389 Check for size calculation overflow.
726e0ab1
PE
2390 (ct_colors_allocated_max): New constant.
2391 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2392 overflow.
3256efce 2393
726e0ab1
PE
2394 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2395 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2396 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2397 Use ptrdiff_t, not int, to count maps.
2398 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2399 calculations. Don't update size until allocation succeeds.
2400 Redo calculations to avoid overflow.
726e0ab1
PE
2401 * keyboard.h: Change prototypes to match the above.
2402
2403 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2404 to count maps.
2405 (current_minor_maps): Check for size calculation overflow.
2406 * keymap.h: Change prototypes to match the above.
2407
2408 * lread.c (read1, init_obarray): Don't update size until alloc done.
2409
2410 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2411 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2412
726e0ab1
PE
2413 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2414 Now ptrdiff_t, not int.
2415 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2416 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2417
2418 * process.c (Fnetwork_interface_list): Check for overflow
2419 in size calculation.
2420
2421 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2422
2423 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2424 overflow. Don't bother calling xmalloc when xrealloc will do.
2425
2426 * search.c (Freplace_match): Check for size calculation overflow.
2427 (Fset_match_data): Don't assume list lengths fit in 'int'.
2428
2429 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2430 for command line length. Do not attempt to address one before the
2431 beginning of an array, as that's not portable.
2432
2433 * term.c (max_frame_lines): Remove; unused.
2434 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2435 not int.
2436 (encode_terminal_code, calculate_costs): Check for size
2437 calculation overflow.
2438 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2439 table lengths and related sizes. Don't update size until alloc
2440 done. Redo calculations to avoid overflow.
2441 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2442
2443 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2444 subtracting pointers.
2445 (gobble_line): Check for overflow more carefully. Don't update size
2446 until alloc done.
2447
2448 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2449 Don't update size until alloc done.
2450 Redo size calculations to avoid overflow.
2451 Check for size calculation overflow.
0065d054 2452 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2453
2454 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2455 Use ptrdiff_t, not int, for sizes.
2456 (store_mode_line_noprop_char): Don't update size until alloc done.
2457
0065d054
PE
2458 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2459 Use ptrdiff_t, not int, for sizes.
2460 (Finternal_make_lisp_face, cache_face):
2461 Check for size calculation overflow.
2462 (cache_face): Treat size calculation overflows as if they were
2463 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2464
2465 * xfns.c (x_encode_text, x_set_name_internal)
2466 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2467 sizes, since they can exceed INT_MAX in size. Check for size
2468 calculation overflow.
2469
0065d054
PE
2470 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2471 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2472 Don't update size until alloc done.
2473
0065d054 2474 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2475 as sprintf is limited to int lengths.
1d526e2f 2476
252c5ee1
PE
2477 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2478 (X_LONG_MIN): New macros.
864d7ce7
PE
2479 Use them to make the following changes clearer.
2480 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2481 This change doesn't affect the value now, but it may help remind
2482 future maintainers not to raise the value too much later.
2483 (SELECTION_QUANTUM): Remove, replacing with ...
2484 (selection_quantum): ... new function, which avoids overflow.
2485 All uses changed.
2486 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2487 assumption that selection length fits in 'int'.
2488 (x_reply_selection_request, x_handle_selection_request)
2489 (x_get_window_property, receive_incremental_selection)
2490 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2491 (lisp_data_to_selection_data, clean_local_selection_data):
2492 Use ptrdiff_t, not int, to record length of selection.
2493 (x_reply_selection_request, x_get_window_property)
2494 (receive_incremental_selection, x_property_data_to_lisp):
2495 Redo calculations to avoid overflow.
2496 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2497 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2498 something.
2499 (x_get_window_property, receive_incremental_selection)
2500 (lisp_data_to_selection_data, x_property_data_to_lisp):
2501 Check for size-calculation overflow.
2502 (x_get_window_property, receive_incremental_selection)
2503 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2504 Don't store size until memory allocation succeeds.
2505 (x_get_window_property): Plug memory leak on memory exhaustion.
2506 Don't double-block input; malloc is safe here. Don't assume 2**34
2507 - 4 fits in unsigned long. Add an xassert to check
2508 XGetWindowProperty overflow. Be more careful about overflow
2509 calculations, and distinguish size from memory overflow better.
2510 (receive_incremental_selection): When tracing, don't assume
2511 unsigned int is less than INT_MAX.
2512 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2513 harmful) conversions of unsigned short to int.
2514 (lisp_data_to_selection_data): Don't assume that integers
2515 in the range -65535 through -1 fit in an X unsigned short.
2516 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2517 result parameters unless successful. Rely on cons_to_unsigned
2518 to report problems with elements; the old code wasn't right anyway.
2519 (x_check_property_data): Check for int overflow; we cannot use
2520 a wider type due to X limits.
2521 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2522
726e0ab1 2523 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2524
0065d054
PE
2525 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2526 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2527 (x_color_cells): Don't store size until memory allocation succeeds.
2528 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2529 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2530 (x_term_init): Don't assume length fits in int (sprintf is limited
2531 to int size).
bc18e09d 2532
ebfa62c0
PE
2533 Use ptrdiff_t for composition IDs.
2534 * character.c (lisp_string_width):
2535 * composite.c (composition_table_size, n_compositions)
2536 (get_composition_id, composition_gstring_from_id):
2537 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2538 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2539 * window.c (Frecenter):
2540 Use ptrdiff_t, not int, for composition IDs.
2541 * composite.c (get_composition_id): Check for integer overflow.
2542 * composite.h: Adjust prototypes to match the above changes.
2543
d3411f89
PE
2544 Use ptrdiff_t for hash table indexes.
2545 * category.c (hash_get_category_set):
2546 * ccl.c (ccl_driver):
2547 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2548 * coding.c (coding_system_charset_list, detect_coding_system):
2549 * coding.h (struct coding_system.id):
2550 * composite.c (get_composition_id, gstring_lookup_cache):
2551 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2552 * image.c (xpm_get_color_table_h):
2553 * lisp.h (hash_lookup, hash_put):
2554 * minibuf.c (Ftest_completion):
2555 Use ptrdiff_t for hash table indexes, not int (which is too
2556 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2557 32-bit --with-wide-int hosts).
2558
e097a6fa
PE
2559 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2560 Add a FIXME comment about memory leaks.
2561 (syms_of_charset): Don't assume xmalloc returns.
2562
5637687f
PE
2563 Don't assume that stated character widths fit in int.
2564 * character.c (Fchar_width, c_string_width, lisp_string_width):
2565 * character.h (CHAR_WIDTH):
2566 * indent.c (MULTIBYTE_BYTES_WIDTH):
2567 Use sanitize_char_width to avoid undefined and/or bad behavior
2568 with outlandish widths.
a66cfb1c 2569 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2570 now that we have two such functions. All uses changed.
2571 (sanitize_char_width): New inline function.
2572
a2271ba2
PE
2573 Don't assume that tab-width fits in int.
2574 * character.h (sanitize_width): New inline function.
2575 (SANE_TAB_WIDTH): New macro.
2576 (ASCII_CHAR_WIDTH): Use it.
2577 * indent.c (sane_tab_width): Remove. All uses replaced by
2578 SANE_TAB_WIDTH (current_buffer).
2579 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2580
18c52557
PE
2581 * fileio.c: Integer overflow issues with file modes.
2582 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2583
caeeedc1
PE
2584 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2585 Remove unreachable code.
2586 (read_hex, load_charset_map_from_file): Check for integer overflow.
2587
6df6ae42 2588 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2589 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2590 (x_send_scroll_bar_event): Likewise. Check that the size does not
2591 exceed limits imposed by XClientMessageEvent, as well as the usual
2592 ptrdiff_t and size_t limits.
2593
b13995db
PE
2594 * keyboard.c: Overflow, signedness and related fixes.
2595 (make_lispy_movement): Use same integer type in forward decl
2596 that is used in the definition.
2597 (read_key_sequence, keyremap_step):
2598 Change bufsize argument back to int, undoing my 2011-03-30 change.
2599 We prefer signed types, and int is wide enough here.
2600 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2601 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2602 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2603 length, not size_t. Use ptrdiff_t for index, not int.
2604 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2605 possibility of integer overflow.
2606
13464394
PE
2607 Overflow, signedness and related fixes for images.
2608
2609 * dispextern.h (struct it.stack[0].u.image.image_id)
2610 (struct_it.image_id, struct image.id, struct image_cache.size)
2611 (struct image_cache.used, struct image_cache.ref_count):
2612 * gtkutil.c (update_frame_tool_bar):
2613 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2614 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2615 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2616 * nsmenu.m (update_frame_tool_bar):
2617 * xdisp.c (calc_pixel_width_or_height):
2618 * xfns.c (image_cache_refcount):
2619 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2620 on typical 64-bit hosts.
2621
2622 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2623 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2624 Omit unnecessary casts to int.
2625 (parse_image_spec): Check that integers fall into 'int' range
2626 when the callers expect that.
2627 (image_ascent): Redo ascent calculation to avoid int overflow.
2628 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2629 (lookup_image): Remove unnecessary tests.
2630 (xbm_image_p): Locals are now of int, not EMACS_INT,
2631 since parse_image_check makes sure they fit into int.
2632 (png_load, gif_load, svg_load_image):
2633 Prefer int to unsigned where either will do.
2634 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2635 old tiff_error_handler and tiff_warning_handler.
2636 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2637 stack buffer overflows. It uses only the features of vsnprintf
2638 that are common to both POSIX and native Microsoft.
2639 (tiff_error_handler, tiff_warning_handler): Use it.
2640 (tiff_load, gif_load, imagemagick_load_image):
2641 Don't assume :index value fits in 'int'.
2642 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2643 (imagemagick_load_image): Check that crop parameters fit into
2644 the integer types that MagickCropImage accepts. Don't assume
2645 Vimagemagick_render_type has a nonnegative value. Don't assume
2646 size_t fits in 'long'.
2647 (gs_load): Use printmax_t to print the widest integers possible.
2648 Check for integer overflow when computing image height and width.
2649
c11821d4
EZ
26502011-08-26 Eli Zaretskii <eliz@gnu.org>
2651
2652 * xdisp.c (redisplay_window): Don't force window start if point
2653 will be invisible in the resulting window. (Bug#9324)
2654
0c95fcf7
EZ
26552011-08-25 Eli Zaretskii <eliz@gnu.org>
2656
2657 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2658 the display spec is of the form `(space ...)'.
2659 (handle_display_spec): Return the value returned by
2660 handle_single_display_spec, not just 1 or zero.
2661 (handle_single_display_spec): If the display spec is of the form
2662 `(space ...)', and specifies display in the text area, return 2
2663 rather than 1.
fee65a97 2664 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2665 accurately, and prefer exact match for point under bidi.
2666 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2667
2668 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2669 into disp_prop; all users changed.
2670
2671 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2672 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2673 for the text covered by the display property.
2674
e4ed06f1
CY
26752011-08-25 Chong Yidong <cyd@stupidchicken.com>
2676
2677 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2678 Change return value to nil.
2679 (Frecord_buffer): Delete unused function.
2680
f67cdd7f
EZ
26812011-08-24 Eli Zaretskii <eliz@gnu.org>
2682
5980d4c6
EZ
2683 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2684 buffers, return left-to-right.
8610fe8b
EZ
2685 (set_cursor_from_row): Consider candidate row a win if its glyph
2686 represents a newline and point is on that newline. Fixes cursor
2687 positioning on the newline at EOL of R2L text within L2R
2688 paragraph, and vice versa.
2689 (try_cursor_movement): Check continued rows, in addition to
2690 continuation rows. Fixes unwarranted scroll when point enters a
2691 continued line of R2L text within an L2R paragraph, or vice versa.
2692 (cursor_row_p): Consider the case of point being equal to
2693 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2694 from the end of a short line to the beginning of a continued line
2695 of R2L text within L2R paragraph.
2696 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2697 composed characters.
5980d4c6 2698
f67cdd7f
EZ
2699 * bidi.c (bidi_check_type): Use xassert.
2700 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2701 members.
2702
bca633fb
EZ
27032011-08-23 Eli Zaretskii <eliz@gnu.org>
2704
2705 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2706 a character.
2707
4a5885a7
CY
27082011-08-23 Chong Yidong <cyd@stupidchicken.com>
2709
2710 * nsfont.m (ns_otf_to_script): Fix typo.
2711
0902a04e
KH
27122011-08-22 Kenichi Handa <handa@m17n.org>
2713
2714 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2715 extra slot even if the purpose is char-code-property-table.
2716
1a2e6670
EZ
27172011-08-23 Eli Zaretskii <eliz@gnu.org>
2718
8ddde651
EZ
2719 * xdisp.c (redisplay_window): When computing centering_position,
2720 account for the height of the header line. (Bug#8874)
2721
425cc014
EZ
2722 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2723 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2724 candidate is selected by the mouse, and that candidate has a
2725 composed character under the mouse.
2726
1a2e6670
EZ
2727 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2728 coordinates reported by pos-visible-in-window-p for a composed
2729 character in column zero.
2730
8b76d6f8
SM
27312011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2732
2733 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2734
dac347dd
EZ
27352011-08-22 Eli Zaretskii <eliz@gnu.org>
2736
2737 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2738 consider it a hit if to_charpos is anywhere in the range of the
2739 composed buffer positions.
2740
e013fb34
CY
27412011-08-22 Chong Yidong <cyd@stupidchicken.com>
2742
2743 * image.c (gif_load): Don't assume that each subimage has the same
2744 dimensions as the base image. Handle disposal method that is
2745 "undefined" by the gif spec (Bug#9335).
2746
bd1ba3e8
CY
27472011-08-20 Chong Yidong <cyd@stupidchicken.com>
2748
2749 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2750 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2751
54a1215b
EZ
27522011-08-19 Eli Zaretskii <eliz@gnu.org>
2753
823564e5
EZ
2754 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2755 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2756 from an Org mode buffer to a Speedbar frame.
2757
54a1215b
EZ
2758 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2759 a composition, take its buffer position from IT->cmp_it.charpos.
2760 Fixes cursor positioning at the beginning of a line that begins
2761 with a composed character.
2762
9778ebcc
EZ
27632011-08-18 Eli Zaretskii <eliz@gnu.org>
2764
0be6ee06
EZ
2765 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2766 character bidirectional type, use STRONG_L instead. Fixes crashes
2767 in a buffer produced by `describe-categories'.
2768
9778ebcc
EZ
2769 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2770 members before the level stack, so they would be saved and
2771 restored when copying iterator state. Fixes incorrect reordering
2772 around TABs covered by display properties.
2773
156bffbe
AS
27742011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2775
6b02f655 2776 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2777
72ad093b
CY
27782011-08-17 Chong Yidong <cyd@stupidchicken.com>
2779
2780 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2781 (internal_condition_case_2, internal_condition_case_n):
2782 Remove unnecessary aborts (Bug#9081).
72ad093b 2783
35774242
EZ
27842011-08-17 Eli Zaretskii <eliz@gnu.org>
2785
2786 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2787 has no `load' handler, try opening the file locally. (Bug#9311)
2788
db76dd85
KB
27892011-08-16 Ken Brown <kbrown@cornell.edu>
2790
2791 * gmalloc.c: Expand comment.
2792
b215eee5
EZ
27932011-08-16 Eli Zaretskii <eliz@gnu.org>
2794
2795 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2796 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2797
a4579d33
KB
27982011-08-16 Ken Brown <kbrown@cornell.edu>
2799
2800 Fix memory allocation problems in Cygwin build (Bug#9273).
2801
2802 * unexcw.c ( __malloc_initialized): Declare external variable.
2803 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2804
8b76d6f8
SM
2805 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2806 New variables.
a4579d33
KB
2807 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2808 dumped emacs.
2809 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2810 in the static heap.
2811 [CYGWIN] (special_realloc): New function.
2812 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2813 requests to realloc storage in the static heap.
2814
3ebec551
PE
28152011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2816
2817 * bidi.c (bidi_initialize): Remove unused local.
2818
9fd8be00
EZ
28192011-08-15 Eli Zaretskii <eliz@gnu.org>
2820
6b02f655
SM
2821 * bidimirror.h:
2822 * biditype.h: Remove file.
2823 * makefile.w32-in ($(BLD)/bidi.$(O)):
2824 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2825
2826 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2827
2828 * chartab.c: Improve commentary for the uniprop_table API.
2829
32413314
EZ
2830 * bidi.c (bidi_paragraph_init): Support zero value of
2831 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2832 (bidi_initialize): Use uniprop_table instead of including
2833 biditype.h and bidimirror.h.
32413314 2834
9fd8be00
EZ
2835 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2836 coordinates of the iterator when restoring from ppos_it.
2837 (Bug#9296)
2838
5cf2b69b
KH
28392011-08-14 Kenichi Handa <handa@m17n.org>
2840
2841 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2842 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2843
daf17d00
EZ
28442011-08-14 Eli Zaretskii <eliz@gnu.org>
2845
2846 * xdisp.c (move_it_in_display_line_to): Don't invoke
2847 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2848 ppos_it. Fixes vertical cursor motion when line beginning is
2849 covered by an image. (Bug#9296)
2850
08e3161a
JD
28512011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2852
2853 * nsterm.h (ns_run_ascript): Declare.
2854 (NSAPP_DATA2_RUNASSCRIPT): Define.
2855
2856 * nsfns.m (as_script, as_result, as_status): New static variables.
2857 (ns_run_ascript): New function.
5e617bc2 2858 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2859 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2860 the event loop. Get status from as_status (Bug#7276).
2861
2862 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2863 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2864 the event loop (Bug#7276).
2865
a3720aa2
AS
28662011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2867
2868 * gnutls.c (QCgnutls_bootprop_priority)
2869 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2870 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2871 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2872 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2873 (QCgnutls_bootprop_verify_hostname_error)
2874 (QCgnutls_bootprop_callbacks_verify): Rename from
2875 Qgnutls_bootprop_..., all uses changed.
2876
2877 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2878 uses changed.
2879
0a0d27fb
PE
28802011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2881
19d5c50c
PE
2882 * xfaces.c (Qframe_set_background_mode): Now static.
2883 * dispextern.h (Qframe_set_background_mode): Remove decl.
2884
0a0d27fb
PE
2885 * process.c (Fnetwork_interface_info): Declare local only if needed.
2886
377538cb
JD
28872011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2888
2889 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2890 (Fnetwork_interface_list): Allocate in increments of bytes instead
2891 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2892 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2893 sockaddr.
2894 (struct ifflag_def): notrailers is smart on OSX.
2895 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2896 Get hardware address with getifaddrs if available.
2897
08fff70c
EZ
28982011-08-12 Eli Zaretskii <eliz@gnu.org>
2899
2900 * xdisp.c (iterate_out_of_display_property): xassert that
2901 IT->position is set to within IT->object's boundaries. Break from
2902 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2903 when IT->position is set up wrongly due to some bug.
2904 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2905 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2906 entry. Force push_it to save on the stack the current
2907 buffer/string position, to be restored by pop_it. Fix flags in
2908 the iterator structure wrt the object coming from a display
2909 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2910 properties. (Bug#9284)
2911
7be1c708 29122011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2913
7be1c708
CY
2914 * fontset.c (fontset_get_font_group): Add proper type checks.
2915 (Bug#9172)
aac0c6e3 2916
7be1c708 29172011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2918
7be1c708
CY
2919 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2920 and LC_VERSION_MIN_MACOSX.
2921 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2922 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2923
97bb72a6
EZ
29242011-08-08 Eli Zaretskii <eliz@gnu.org>
2925
2926 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2927 no-display-properties-and-no-overlays under bidi display.
2928 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2929 properties and overlays.
97bb72a6 2930
d5617611
CY
29312011-08-08 Chong Yidong <cyd@stupidchicken.com>
2932
37e11a63
CY
2933 * editfns.c (Fset_time_zone_rule): Document relationship with the
2934 setenv function.
2935
d5617611
CY
2936 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2937 the font entity extracted from the cache (Bug#8109).
2938
58872834
CY
29392011-08-07 Chong Yidong <cyd@stupidchicken.com>
2940
2941 * composite.c (autocmp_chars): Don't reset point. That is done by
2942 restore_point_unwind (Bug#5984).
2943
75bfc667
JL
29442011-08-07 Juri Linkov <juri@jurta.org>
2945
2946 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2947 to show the arg `TIME' instead of `TIMEVAL'.
2948
d1410150
EZ
29492011-08-06 Eli Zaretskii <eliz@gnu.org>
2950
2951 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2952 display property strides EOL and includes a newline, as in
2953 longlines-mode. (Bug#9254)
75b771e4
EZ
2954 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2955 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2956
2957 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2958 is non-zero, even if the data buffer is NULL. Fixes a crash in
2959 vertical-motion with longlines-mode. (Bug#9254)
2960
35928349
EZ
29612011-08-05 Eli Zaretskii <eliz@gnu.org>
2962
ec7cc85b
EZ
2963 * bidi.c <bidi_cache_total_alloc>: Now static.
2964 (bidi_initialize): Initialize bidi_cache_total_alloc.
2965
8b76d6f8 2966 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2967 cache. (Bug#9221)
2968
2969 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2970 amount allocated this far in `bidi_cache_total_alloc'.
2971 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2972 non-zero, only free the data buffer without restoring the cache
2973 contents. All callers changed.
2974
2975 * dispextern.h (bidi_unshelve_cache): Update prototype.
2976
2977 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2978 (move_it_in_display_line, move_it_to)
2979 (move_it_vertically_backward, move_it_by_lines): Replace the call
2980 to xfree to an equivalent call to bidi_unshelve_cache.
2981 (move_it_in_display_line_to): Fix logic of returning
412b6358 2982 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2983
e2e2423b
EZ
29842011-08-05 Eli Zaretskii <eliz@gnu.org>
2985
2986 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2987 came from a string character with a `cursor' property. (Bug#9229)
2988
ae9e757a
JD
29892011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2990
2991 * Makefile.in (LIB_PTHREAD): New variable.
2992 (LIBES): Add LIB_PTHREAD (Bug#9216).
2993
2994 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2995 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2996
213bd7f2
AS
29972011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2998
6b02f655 2999 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3000
99aaf75f
JD
30012011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3002
3003 * xterm.c (x_find_topmost_parent): New function.
3004 (x_set_frame_alpha): Find topmost parent window with
3005 x_find_topmost_parent and set the property there also (bug#9181).
3006 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3007
c74e9d86
PE
30082011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3009
3010 * callproc.c (Fcall_process): Avoid vfork clobbering
3011 the local vars buffer, coding_systems, current_dir.
3012
640c8776
SM
30132011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3014
3015 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3016
f26d0e4c
PE
30172011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3018
8a10d76c
PE
3019 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3020 so that it is not optimized away.
3021
f26d0e4c
PE
3022 * xdisp.c (compute_display_string_pos): Remove unused local.
3023
55439c61
EZ
30242011-08-02 Eli Zaretskii <eliz@gnu.org>
3025
3026 Fix slow cursor motion and scrolling in large buffers with
3027 selective display, like Org Mode buffers. (Bug#9218)
3028
3029 * dispextern.h (struct bidi_it): New member disp_prop_p.
3030
3031 * xdisp.c: Remove one-slot cache of display string positions.
3032 (compute_display_string_pos): Accept an additional argument
5e617bc2 3033 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3034 for a display string or property. If found, set DISP_PROP_P
3035 non-zero.
3036
3037 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3038 DISP_PROP_P, and pass it to compute_display_string_pos.
3039 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3040 non-zero. All callers of bidi_fetch_char changed.
3041
fb33fa43
SM
30422011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3043
3044 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3045
b099e063
DM
30462010-12-03 Don March <don@ohspite.net>
3047
3048 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3049 last character M-[char] is translated to ESC [char] (bug#7541).
3050
5cc7f7af
KH
30512011-08-02 Kenichi Handa <handa@m17n.org>
3052
d0fffa3f 3053 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3054
3055 * chartab.c (uniprop_table): Make it non-static.
3056
525d5e6e
EZ
30572011-08-01 Eli Zaretskii <eliz@gnu.org>
3058
3059 * xdisp.c (forward_to_next_line_start): Accept additional argument
3060 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3061 on the newline.
3062 (reseat_at_next_visible_line_start): Use the bidi iterator state
3063 returned by forward_to_next_line_start to restore the state of
3064 it->bidi_it after backing up to previous newline. (Bug#9212)
3065
31011111
AS
30662011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3067
3068 * regex.c (re_comp): Protoize.
3069 (re_exec): Fix return type.
3070 (regexec): Fix type of `ret'. (Bug#9203)
3071
476371c4
PE
30722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3073
e5d76069
PE
3074 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3075 This is needed if max-image-size is a floating-point number.
3076
9a79b20c
AS
30772011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3078
3079 * print.c (print_object): Print empty symbol as ##.
3080
3081 * lread.c (read1): Read ## as empty symbol.
3082
d8c2fa78
AA
30832011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3084
3085 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3086 setting frame foreground color (Bug#9175).
3087 (x_set_background_color): Likewise.
3088
ffe57a7a
AA
3089 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3090 contents (Bug#9176).
3091 (EmacsTooltip -init): Remove bezels and add shadows to
3092 tooltip windows.
3093
bf3492a5
AA
3094 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3095 or scroll bar (Bug#8470).
3096
d55e9c53
AA
3097 * nsfont.m (nsfont_open): Remove assignment to voffset and
3098 unnecessary vars hshink, expand, hd, full_height, min_height.
3099 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3100
3101 * nsterm.h (nsfont_info): Remove voffset field.
3102
d8c2fa78 31032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3104
3105 Implement strike-through and overline on NextStep (Bug#8863).
3106
3107 * nsfont.m (nsfont_open): Use underline position provided by font,
3108 instead of hard-coded value of 2.
3109 (nsfont_draw): Call ns_draw_text_decoration instead.
3110
3111 * nsterm.h: Add declaration for ns_draw_text_decoration.
3112
3113 * nsterm.m (ns_draw_text_decoration): New function for drawing
3114 underline, overline, and strike-through.
3115 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3116 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3117 accommodate underlining, etc.
4843aac3 3118
4cc60b9b
EZ
31192011-07-28 Eli Zaretskii <eliz@gnu.org>
3120
bc7ece87
EZ
3121 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3122 default.
4cc60b9b 3123
476371c4
PE
31242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3125
66606eea
PE
3126 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3127 Without this fix, if a signal arrives just after memory fills up,
3128 'malloc' might be invoked reentrantly.
3129
476371c4
PE
3130 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3131 In other words, assume that every image size is allowed, on non-X
3132 hosts. This assumption is probably wrong, but it lets Emacs compile.
3133
f3fcc40d
AS
31342011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3135
3136 * regex.c (re_iswctype): Convert return values to boolean.
3137
350c992f
EZ
31382011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3139
3140 * xdisp.c (compute_display_string_pos): Don't use cached display
3141 string position if the buffer had its restriction changed.
3142 (Bug#9184)
3143
5266b4bb
PE
31442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3145
3146 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3147
2573a837 31482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3149
41f55ccd 3150 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3151
39e378da
PE
3152 * bidi.c: Integer size and overflow fixes.
3153 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3154 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3155 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3156 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3157 (bidi_find_other_level_edge):
3158 Use ptrdiff_t instead of EMACS_INT where either will do.
3159 This works better on 32-bit hosts configured --with-wide-int.
3160 (bidi_cache_ensure_space): Check for size-calculation overflow.
3161 Use % rather than repeated addition, for better worst-case speed.
3162 Don't set bidi_cache_size until after xrealloc returns, because it
3163 might not return.
3164 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3165 (bidi_cache_ensure_space): Also check that the bidi cache size
3166 does not exceed that of the largest Lisp string or buffer. See Eli
3167 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3168
5e927815
PE
3169 * alloc.c (__malloc_size_t): Remove.
3170 All uses replaced by size_t. See Andreas Schwab's note
3171 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3172
ca4aa935
PE
3173 * image.c: Improve checking for integer overflow.
3174 (check_image_size): Assume that f is nonnull, since
3175 it is always nonnull in practice. This is one less thing to
3176 worry about when checking for integer overflow later.
3177 (x_check_image_size): New function, which checks for integer
3178 overflow issues inside X.
3179 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3180 This removes the need for a memory_full check.
3181 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3182 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3183 (xbm_read_bitmap_data): Change locals back to 'int', since
3184 their values must fit in 'int'.
3185 (xpm_load_image, png_load, tiff_load):
3186 Invoke x_create_x_image_and_pixmap earlier,
3187 to avoid much needless work if the image is too large.
3188 (tiff_load): Treat overly large images as if
3189 x_create_x_image_and_pixmap failed, not as malloc failures.
3190 (gs_load): Use x_check_image_size.
3191
5f8f9cc2
PE
3192 * gtkutil.c: Omit integer casts.
3193 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3194 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3195
5adf60bc
PE
3196 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3197
c8907a93
PE
3198 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3199 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3200 would wrongly return t on a 64-bit host.
3201
e3c25c68
PE
3202 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3203 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3204 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3205 and therefore cause GCC to emit a bogus diagnostic in some cases.
3206
3f791afe
PE
3207 * image.c: Integer signedness and overflow and related fixes.
3208 This is not an exhaustive set of fixes, but it's time to
3209 record what I've got.
3210 (lookup_pixel_color, check_image_size): Remove redundant decls.
3211 (check_image_size): Don't assume that arbitrary EMACS_INT values
3212 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3213 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3214 (tiff_load, imagemagick_load_image):
3215 Check for overflow in size calculations.
3216 (x_create_x_image_and_pixmap): Remove unnecessary test for
3217 xmalloc returning NULL; that can't happen.
3218 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3219 (xpm_color_bucket): Use better integer hashing function.
3220 (xpm_cache_color): Don't possibly over-allocate memory.
3221 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3222 (gif_memory_source):
3223 Use ptrdiff_t, not int or size_t, to record sizes.
3224 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3225 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3226 either works, as we prefer signed integers.
3227 (tiff_read_from_memory, tiff_write_from_memory):
3228 Return tsize_t, not size_t, since that's what the TIFF API wants.
3229 (tiff_read_from_memory): Don't fail simply because the read would
3230 go past EOF; instead, return a short read.
3231 (tiff_load): Omit no-longer-needed casts.
3232 (Fimagemagick_types): Don't assume size fits into 'int'.
3233
3cc5a532
PE
3234 Improve hashing quality when configured --with-wide-int.
3235 * fns.c (hash_string): New function, taken from sxhash_string.
3236 Do not discard information about ASCII character case; this
3237 discarding is no longer needed.
3238 (sxhash-string): Use it. Change sig to match it. Caller changed.
3239 * lisp.h: Declare it.
3240 * lread.c (hash_string): Remove, since we now use fns.c's version.
3241 The fns.c version returns a wider integer if --with-wide-int is
3242 specified, so this should help the quality of the hashing a bit.
3243
b312a492
PE
3244 * emacs.c: Integer overflow minor fix.
3245 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3246 Define only if GNU_LINUX.
3247 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3248
dfd153ae
PE
3249 * dispnew.c: Integer signedness and overflow fixes.
3250 Remove unnecessary forward decls, that were a maintenance hassle.
3251 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3252 All uses changed.
3253 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3254 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3255 (prepare_desired_row, line_draw_cost):
3256 Use int, not unsigned, where either works.
3257 (save_current_matrix, restore_current_matrix):
3258 Use ptrdiff_t, not size_t, where either works.
3259 (init_display): Check for overflow more accurately, and without
3260 relying on undefined behavior.
3261
a81d11a3
PE
3262 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3263 Remove, replacing with the new symbols in lisp.h. All uses changed.
3264 * fileio.c (make_temp_name):
3265 * filelock.c (lock_file_1, lock_file):
3266 * xdisp.c (message_dolog):
3267 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3268 Use pMd etc. instead.
3269 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3270 replacing the pWIDE etc. symbols removed from editfns.c.
3271
3300e6fd
PE
3272 * keyboard.h (num_input_events): Now uintmax_t.
3273 This is (very slightly) less likely to mess up due to wraparound.
3274 All uses changed.
3275
fd05c7e9
PE
3276 * buffer.c: Integer signedness fixes.
3277 (alloc_buffer_text, enlarge_buffer_text):
3278 Use ptrdiff_t rather than size_t when either will do, as we prefer
3279 signed integers.
3280
903fe15d
PE
3281 * alloc.c: Integer signedness and overflow fixes.
3282 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3283 (__malloc_size_t): Default to size_t, not to int.
3284 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3285 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3286 Prefer ptrdiff_t to size_t when either would do, as we prefer
3287 signed integers.
3288 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3289 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3290 Now const. Initialize with values that are in range even if char
3291 is signed.
3292 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3293 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3294 These functions do the right thing with sizes > 2**32.
3295 (check_depth): Now ptrdiff_t, not int.
3296 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3297 Adjust to new way of storing sizes. Check for size overflow bugs
3298 in rest of code.
3299 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3300 slightly wrong anyway, as it missed one instance of
3301 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3302 (refill_memory_reserve): Omit needless cast to size_t.
3303 (mark_object_loop_halt): Mark as externally visible.
3304
ac82cc6a
PE
3305 * xselect.c: Integer signedness and overflow fixes.
3306 (Fx_register_dnd_atom, x_handle_dnd_message):
3307 Use ptrdiff_t, not size_t, since we prefer signed.
3308 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3309 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3310 x_dnd_atoms_size and x_dnd_atoms_length.
3311
c2d1e36d
PE
3312 * doprnt.c: Prefer signed to unsigned when either works.
3313 * eval.c (verror):
3314 * doprnt.c (doprnt):
3315 * lisp.h (doprnt):
3316 * xdisp.c (vmessage):
3317 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3318 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3319 prefer signed arithmetic to avoid comparison confusion.
3320 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3321 but is a bit tricky.
3322
0e926e56
PE
3323 Assume freestanding C89 headers, string.h, stdlib.h.
3324 * data.c, doprnt.c, floatfns.c, print.c:
3325 Include float.h unconditionally.
3326 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3327 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3328 * regex.c: Likewise for stddef.h, string.h.
3329 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3330 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3331 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3332 (STDC_HEADERS): Remove obsolete defines.
3333 * sysdep.c: Include limits.h unconditionally.
3334
9cfdb3ec
PE
3335 Assume support for memcmp, memcpy, memmove, memset.
3336 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3337 * regex.c (memcmp, memcpy):
3338 Remove; we assume C89 now.
3339
3340 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3341 (__malloc_safe_bcopy): Remove; no longer needed.
3342
cf950e6b 3343 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3344 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3345 well either way, and we prefer signed to unsigned.
3346
dbf38e02
LMI
33472011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3348
3349 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3350 closes the connection while we're reading (bug#9182).
3351
d6f0886c 33522011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3353
d6f0886c
JD
3354 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3355 are specified (Bug#9168).
24e0f6b1 3356
2eb1f9e6
PE
33572011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3358
3359 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3360 Found by GCC static checking and --with-wide-int on a 32-bit host.
3361
22381272 33622011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3363
3364 * xdisp.c (compute_display_string_pos): Fix logic of caching
3365 previous display string position. Initialize cached_prev_pos to
3366 -1. Fixes slow-down at the beginning of a buffer.
3367
f25e39b4
EZ
33682011-07-24 Eli Zaretskii <eliz@gnu.org>
3369
3370 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3371 for attrs[LFACE_FONTSET_INDEX].
3372
04c4b52e
PE
33732011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3374
3375 * xml.c (parse_region): Remove unused local
3376 that was recently introduced.
3377
c1734fbd
EZ
33782011-07-23 Eli Zaretskii <eliz@gnu.org>
3379
be18c5a5
EZ
3380 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3381 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3382
c1734fbd
EZ
3383 * xdisp.c (move_it_in_display_line_to): Record the best matching
3384 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3385 exit if none of the characters scanned was an exact match.
3386 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3387 when exact match is impossible due to invisible text, and the
3388 lines are truncated.
3389
a258d627
JD
33902011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3391
3392 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3393 for OSX >= 10.7.
3394
b6d5a689
EZ
33952011-07-22 Eli Zaretskii <eliz@gnu.org>
3396
0f74f785
EZ
3397 Fix a significant slow-down of cursor motion with C-n, C-p,
3398 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3399 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3400 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3401 (next_element_from_buffer): Call compute_stop_pos_backwards to
3402 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3403 base_level_stop.
3404 (reseat): Don't look for prev_stop, as that could mean a very long
3405 run.
3406 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3407 <cached_disp_overlay_modiff>: Cache for last found display string
3408 position.
551918c1 3409 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3410 about the same buffer in the same area of character positions, and
3411 the buffer wasn't changed since the time the display string
3412 position was cached.
551918c1 3413
b2d0c91a
EZ
34142011-07-22 Eli Zaretskii <eliz@gnu.org>
3415
3416 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3417 is an integer, which is important for empty lines. (Bug#9149)
3418
043604ee
CY
34192011-07-22 Chong Yidong <cyd@stupidchicken.com>
3420
3421 * frame.c (Fmodify_frame_parameters): In tty case, update the
3422 default face if necessary (Bug#4238).
3423
da4adb04
CY
34242011-07-21 Chong Yidong <cyd@stupidchicken.com>
3425
3426 * editfns.c (Fstring_to_char): No need to explain what a character
3427 is in the docstring (Bug#6576).
3428
9abd0532
LMI
34292011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3430
3431 * xml.c (parse_region): Make sure we always return a tree.
3432
36881d16
HK
34332011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3434
3435 * xml.c (parse_region): If a document contains only comments,
3436 return that, too.
3437
1e98674d
LMI
34382011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3439
3440 * xml.c (make_dom): Return comments, too.
3441
590bd467
PE
34422011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3443
3444 Port to OpenBSD.
3445 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3446 and the surrounding thread.
3447 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3448 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3449 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3450 timer goes off.
3451 * s/openbsd.h (BROKEN_SIGIO): Define.
3452 * unexelf.c (unexec) [__OpenBSD__]:
3453 Don't update the .mdebug section of the Alpha COFF symbol table.
3454
f41628b2
LMI
34552011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3456
3457 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3458 (bug#8460).
3459
b59b67c5
PE
34602011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3461
15e3a074
PE
3462 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3463 This fixes some race conditions on the permissions of any newly
3464 created file.
3465
41bed37d
PE
3466 * alloc.c (valid_pointer_p): Use pipe, not open.
3467 This fixes some permissions issues when debugging.
3468
b59b67c5
PE
3469 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3470 If fchown fails to set both uid and gid, try to set just gid,
3471 as that is sometimes allowed. Adjust the file's mode to eliminate
3472 setuid or setgid bits that are inappropriate if fchown fails.
3473
925a6be7
SM
34742011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3475
3476 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3477 to compare Lisp_Objects.
3478 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3479 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3480 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3481
52968808
AS
34822011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3483
0a6a104b
AS
3484 * lread.c (read_integer): Unread even EOF character.
3485 (read1): Likewise. Properly record start position of symbol.
3486
52968808
AS
3487 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3488 symbol character follows.
3489
9e381cdd
PE
34902011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3491
3492 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3493 This works around a problem with the previous change to Fcopy_file.
3494 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3495 and without this change, GCC might complain about discarding
3496 fchown's return value.
3497
b5641435
JB
34982011-07-16 Juanma Barranquero <lekktu@gmail.com>
3499
3500 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3501
a8031457
PE
35022011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3503
3504 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3505
dd889327
LMI
35062011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3507
750c33f7
LMI
3508 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3509 it's used from the C level.
3510
dd889327
LMI
3511 * process.c: Use the same condition for POLL_FOR_INPUT in both
3512 keyboard.c and process.c (bug#1858).
3513
87e86684
LM
35142011-07-09 Lawrence Mitchell <wence@gmx.li>
3515
3516 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3517 (Fgnutls_boot): Use it.
3518
64348f40
AS
35192011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3520
3521 * doc.c (Fsubstitute_command_keys): Revert last change.
3522
1d698799
LMI
35232011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3524
f863868c
LMI
3525 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3526 quotes the next character, and doesn't affect other longer
3527 sequences (bug#8935).
3528
1d698799
LMI
3529 * lread.c (syms_of_lread): Clarify that is isn't only
3530 `eval-buffer' and `eval-defun' that's affected by
3531 `lexical-binding' (bug#8460).
3532
aa4b6df6
EZ
35332011-07-15 Eli Zaretskii <eliz@gnu.org>
3534
3535 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3536 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3537
5d856da6
PE
35382011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3539
ad6042bb
PE
3540 Fix minor problems found by static checking.
3541 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3542 (elsz): Now a signed constant, not a size_t var. We prefer signed
3543 types to unsigned, to avoid integer comparison confusion. Without
3544 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3545 "cannot optimize loop, the loop counter may overflow", a symptom
3546 of the confusion.
f00bbb22 3547 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3548 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3549
6468f31c
LMI
35502011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3551
49080b10
LMI
3552 * search.c (Fre_search_backward): Mention `case-fold-search' in
3553 all the re_search_* functions (bug#8138).
3554
6468f31c
LMI
3555 * keyboard.c (Fopen_dribble_file): Document when the file is
3556 closed (bug#8056).
3557
c965adc5
EZ
35582011-07-14 Eli Zaretskii <eliz@gnu.org>
3559
df9733bf
EZ
3560 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3561 bidi_cache_idx.
3562
0bb23927
EZ
3563 Support bidi reordering of display and overlay strings.
3564 * xdisp.c (compute_display_string_pos)
3565 (compute_display_string_end): Accept additional argument STRING.
3566 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3567 (reseat_to_string): Initialize bidi_it->string.s and
3568 bidi_it->string.schars.
3569 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3570 NULL (avoids a crash in bidi_paragraph_init).
3571 Initialize itb.string.lstring.
0bb23927
EZ
3572 (init_iterator): Call bidi_init_it only of a valid
3573 buffer position was specified. Initialize paragraph_embedding to
3574 L2R.
3575 (reseat_to_string): Initialize the bidi iterator.
3576 (display_string): If we need to ignore text properties of
3577 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3578 original value of -1 will not work with bidi.)
3579 (compute_display_string_pos): First arg is now struct
3580 `text_pos *'; all callers changed. Support display properties on
3581 Lisp strings.
3582 (compute_display_string_end): Support display properties on Lisp
3583 strings.
3584 (init_iterator, reseat_1, reseat_to_string): Initialize the
3585 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3586 when iterating on a string not from display properties).
640c8776
SM
3587 (compute_display_string_pos, compute_display_string_end):
3588 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3589 arrow keys.
3590 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3591 base_level_stop; instead, set base_level_stop to BEGV.
3592 Fixes crashes in vertical-motion.
0bb23927
EZ
3593 (next_element_from_buffer): Improve commentary for when
3594 the iterator is before prev_stop.
3595 (init_iterator): Initialize bidi_p from the default value of
3596 bidi-display-reordering, not from buffer-local value. Use the
3597 buffer-local value only if initializing for buffer iteration.
3598 (handle_invisible_prop): Support invisible properties on strings
3599 that are being bidi-reordered.
3600 (set_iterator_to_next): Support bidi reordering of C strings and
3601 Lisp strings.
3602 (next_element_from_string): Support bidi reordering of Lisp
3603 strings.
3604 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3605 (display_string): Support display of R2L glyph rows.
3606 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3607 (init_iterator): Don't initialize it->bidi_p for strings
3608 here.
3609 (reseat_to_string): Initialize it->bidi_p for strings here.
3610 (next_element_from_string, next_element_from_c_string)
3611 (next_element_from_buffer): Add xassert's for correspondence
3612 between IT's object being iterated and it->bidi_it.string
3613 structure.
3614 (face_before_or_after_it_pos): Support bidi iteration.
3615 (next_element_from_c_string): Handle the case of the first string
3616 character that is not the first one in the visual order.
3617 (get_visually_first_element): New function, refactored from common
3618 parts of next_element_from_buffer, next_element_from_string, and
3619 next_element_from_c_string.
3620 (tool_bar_lines_needed, redisplay_tool_bar)
3621 (display_menu_bar): Force left-to-right direction. Add a FIXME
3622 comment for making that be controlled by a user option.
3623 (push_it, pop_it): Save and restore the state of the
3624 bidi iterator. Save and restore the bidi_p flag.
3625 (pop_it): Iterate out of display property for string iteration as
3626 well.
3627 (iterate_out_of_display_property): Support iteration over strings.
3628 (handle_single_display_spec): Set up it->bidi_it for iteration
3629 over a display string, and call bidi_init_it.
3630 (handle_single_display_spec, next_overlay_string)
3631 (get_overlay_strings_1, push_display_prop): Set up the bidi
3632 iterator for displaying display or overlay strings.
3633 (forward_to_next_line_start): Don't use the shortcut if
3634 bidi-iterating.
3635 (back_to_previous_visible_line_start): If handle_display_prop
3636 pushed the iterator stack, restore the internal state of the bidi
3637 iterator by calling bidi_pop_it same number of times.
3638 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3639 and we are bidi-iterating, don't decrement the iterator position;
3640 instead, set the first_elt flag in the bidi iterator, to produce
3641 the same effect.
3642 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3643 (push_display_prop): xassert that we are iterating a buffer.
3644 (push_it, pop_it): Save and restore paragraph_embedding member.
3645 (handle_single_display_spec, next_overlay_string)
3646 (get_overlay_strings_1, reseat_1, reseat_to_string)
3647 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3648 correctly. Don't assume unibyte strings are not bidi-reordered.
3649 (compute_display_string_pos)
3650 (compute_display_string_end): Fix handling the case of C string.
3651 (push_it, pop_it): Save and restore from_disp_prop_p.
3652 (handle_single_display_spec, push_display_prop): Set the
3653 from_disp_prop_p flag.
3654 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3655 (pop_it): Call iterate_out_of_display_property only if we are
3656 popping after iteration over a string that came from a display
3657 property. Fix a typo in popping stretch info. Add an assertion
3658 for verifying that the iterator position is in sync with the bidi
3659 iterator.
3660 (handle_single_display_spec, get_overlay_strings_1)
3661 (push_display_prop): Fix initialization of paragraph direction for
3662 string when that of the parent object is not yet determined.
3663 (reseat_1): Call bidi_init_it to resync the bidi
3664 iterator with IT's position. (Bug#7616)
3665 (find_row_edges): If ROW->start.pos gives position
3666 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3667 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3668 Reset the from_disp_prop_p flag.
3669 (SAVE_IT, RESTORE_IT): New macros.
3670 (pos_visible_p, face_before_or_after_it_pos)
3671 (back_to_previous_visible_line_start)
3672 (move_it_in_display_line_to, move_it_in_display_line)
3673 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3674 (try_scrolling, redisplay_window, display_line): Use them when
3675 saving a temporary copy of the iterator and restoring it back.
3676 (back_to_previous_visible_line_start, reseat_1)
3677 (init_iterator): Empty the bidi cache "stack".
3678 (move_it_in_display_line_to): If iterator ended up at
3679 EOL, but we never saw any buffer positions smaller than
3680 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3681 motion in bidi-reordered lines.
3682 (move_it_in_display_line_to): Record prev_method and prev_pos
3683 immediately before the call to set_iterator_to_next. Fixes cursor
3684 motion in bidi-reordered lines with stretch glyphs and strings
3685 displayed in margins. (Bug#8133) (Bug#8867)
3686 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3687 TO_CHARPOS.
640c8776
SM
3688 (pos_visible_p): Support positions in bidi-reordered lines.
3689 Save and restore bidi cache.
0bb23927
EZ
3690
3691 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3692 (bidi_paragraph_info): Delete unused struct.
3693 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3694 (bidi_cache_start): New variable.
3695 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3696 to zero.
3697 (bidi_cache_fetch_state, bidi_cache_search)
3698 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3699 (bidi_cache_find, bidi_peek_at_next_level)
3700 (bidi_level_of_next_char, bidi_find_other_level_edge)
3701 (bidi_move_to_visually_next): Compare cache index with
3702 bidi_cache_start rather than with zero.
3703 (bidi_fetch_char): Accept new argument STRING; all callers
3704 changed. Support iteration over a string. Support strings with
3705 display properties. Support unibyte strings. Fix the type of
3706 `len' according to what STRING_CHAR_AND_LENGTH expects.
3707 (bidi_paragraph_init, bidi_resolve_explicit_1)
3708 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3709 (bidi_level_of_next_char, bidi_move_to_visually_next):
3710 Support iteration over a string.
0bb23927
EZ
3711 (bidi_set_sor_type, bidi_resolve_explicit_1)
3712 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3713 can now be zero (for strings); special values 0 and -1 were
3714 changed to -1 and -2, respectively.
3715 (bidi_char_at_pos): New function.
3716 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3717 Call it instead of FETCH_MULTIBYTE_CHAR.
3718 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3719 initialized to valid values.
3720 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3721 values.
3722 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3723 the test for valid cached positions. Fix the logic for looking up
3724 the sentinel state in the cache. GCPRO the Lisp string we are
3725 iterating.
3726 (bidi_push_it, bidi_pop_it): New functions.
3727 (bidi_initialize): Initialize the bidi cache start stack pointer.
3728 (bidi_cache_ensure_space): New function, refactored from part of
3729 bidi_cache_iterator_state. Don't assume the required size is just
3730 one BIDI_CACHE_CHUNK away.
3731 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3732 (bidi_count_bytes, bidi_char_at_pos): New functions.
3733 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3734 always valid if bidi_cache_idx is valid.
3735 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3736 is valid if it's going to be used.
3737 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3738 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3739 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3740 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3741 (bidi_find_other_level_edge, bidi_cache_start_stack):
3742 All variables related to cache indices are now EMACS_INT.
c965adc5 3743
0bb23927
EZ
3744 * dispextern.h (struct bidi_string_data): New structure.
3745 (struct bidi_it): New member `string'. Make flag members be 1-bit
3746 fields, and put them last in the struct.
640c8776
SM
3747 (compute_display_string_pos, compute_display_string_end):
3748 Update prototypes.
0bb23927
EZ
3749 (bidi_push_it, bidi_pop_it): Add prototypes.
3750 (struct iterator_stack_entry): New members bidi_p,
3751 paragraph_embedding, and from_disp_prop_p.
3752 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3753 (bidi_shelve_cache, bidi_unshelve_cache):
3754 Declare prototypes.
0bb23927
EZ
3755
3756 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3757 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3758 and vector-like objects.
3759
3760 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3761 cache around display iteration.
3762
3763 * window.c (Fwindow_end, window_scroll_pixel_based)
3764 (displayed_window_lines, Frecenter): Save and restore the bidi
3765 cache around display iteration.
3766
3bbd2265
LMI
37672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3768
3769 * editfns.c (Fdelete_region): Clarify the use of the named
3770 parameters (bug#6788).
3771
adc47434
MR
37722011-07-14 Martin Rudalics <rudalics@gmx.at>
3773
3774 * indent.c (Fvertical_motion): Set and restore w->pointm when
3775 saving and restoring the window's buffer (Bug#9006).
3776
837c31f8
LMI
37772011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3778
3779 * editfns.c (Fstring_to_char): Clarify just what is returned
3780 (bug#6576). Text by Eli Zaretskii.
3781
ac389d0c
JB
37822011-07-13 Juanma Barranquero <lekktu@gmail.com>
3783
3784 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3785
0be0ce47
EZ
37862011-07-13 Eli Zaretskii <eliz@gnu.org>
3787
3788 * buffer.c (mmap_find): Fix a typo.
3789
cd18e7e3
JB
37902011-07-13 Johan Bockgård <bojohan@gnu.org>
3791
3792 Fix execution of x selection hooks.
3793 * xselect.c (Qx_lost_selection_functions)
3794 (Qx_sent_selection_functions): New vars.
3795 (syms_of_xselect): DEFSYM them.
3796 (x_handle_selection_request): Pass Qx_sent_selection_functions
3797 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3798 (x_handle_selection_clear,x_clear_frame_selections):
3799 Pass Qx_lost_selection_functions rather than
3800 Vx_lost_selection_functions to Frun_hook_with_args.
3801
47ea7f44
PE
38022011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3803
ac389d0c 3804 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3805 The old code sometimes used this field without initializing it.
3806
47ea7f44
PE
3807 * alloc.c (gc_sweep): Don't read past end of array.
3808 In theory, the old code could also have corrupted Emacs internals,
3809 though it'd be very unlikely.
3810
bc985c87
AS
38112011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3812
3813 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3814 argument. (Bug#4026)
bc985c87 3815
0cf34688
LMI
38162011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3817
b3dadd76
LMI
3818 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3819 key" (bug#4257).
3820
0cf34688
LMI
3821 * window.c (Fset_window_start): Doc fix (bug#4199).
3822 (Fset_window_hscroll): Ditto.
3823
270768cd
PE
38242011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3825
077e3dda 3826 Fix minor new problems caught by GCC 4.6.1.
270768cd 3827 * term.c (init_tty): Remove unused local.
490011a6 3828 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3829 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3830 not used otherwise.
270768cd 3831
b1f58454
CY
38322011-07-12 Chong Yidong <cyd@stupidchicken.com>
3833
3834 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3835
22b9578d
LMI
38362011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3837
6e70ab07
LMI
3838 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3839 are the mini-buffer and the echo area (bug#3320).
3840
22b9578d
LMI
3841 * term.c (init_tty): Remove support for supdup, c10 and perq
3842 terminals, which are no longer supported (bug#1482).
3843
8974cc9f
JB
38442011-07-10 Johan Bockgård <bojohan@gnu.org>
3845
3846 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3847
a560d974
JD
38482011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3849
3850 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3851 for non-popups (Bug#3642).
3852
1dae0f0a
AS
38532011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3854
268c2c36 3855 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3856 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3857 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3858 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3859 * data.c (fmod): Likewise.
3860 * dispnew.c (swap_glyphs_in_rows): Likewise.
3861 * emacs.c (memory_warning_signal): Likewise.
3862 * floatfns.c (float_error): Likewise.
3863 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3864 (otf_open, font_otf_capability, generate_otf_features)
3865 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3866 Likewise.
3867 * image.c (pbm_read_file): Likewise.
3868 * indent.c (string_display_width): Likewise.
3869 * intervals.c (check_for_interval, search_for_interval)
3870 (inc_interval_count, count_intervals, root_interval)
3871 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3872 * lread.c (defalias): Likewise.
268c2c36 3873 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3874 * regex.c (set_image_of_range_1, set_image_of_range)
3875 (regex_grow_registers): Likewise.
3876 * sysdep.c (strerror): Likewise.
3877 * termcap.c (valid_filename_p, tprint, main): Likewise.
3878 * tparam.c (main): Likewise.
3879 * unexhp9k800.c (run_time_remap, save_data_space)
3880 (update_file_ptrs, read_header, write_header, calculate_checksum)
3881 (copy_file, copy_rest, display_header): Likewise.
3882 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3883 Likewise.
3884 * xdisp.c (check_it): Likewise.
3885 * xfaces.c (register_color, unregister_color, unregister_colors):
3886 Likewise.
3887 * xfns.c (print_fontset_result): Likewise.
3888 * xrdb.c (member, fatal, main): Likewise.
3889
99033785
PE
38902011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3891
3892 Fix minor problems found by static checking (Bug#9031).
3893 * chartab.c (char_table_set_range, map_sub_char_table):
3894 Remove unused locals.
3895 (uniprop_table): Now static.
3896 * composite.c (_work_char): Remove unused static var.
3897
9cb2ac56
JB
38982011-07-09 Juanma Barranquero <lekktu@gmail.com>
3899
3900 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3901
f25661f0
JD
39022011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3903
3904 * gtkutil.c (qttip_cb): Remove code without function.
3905
8278c4fe
EZ
39062011-07-09 Eli Zaretskii <eliz@gnu.org>
3907
3908 * w32.c (pthread_sigmask): New stub.
3909
1692ae2d 39102011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3911
8a6ebd58 3912 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3913 sigprocmask is portable only for single-threaded applications, and
3914 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3915 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3916 (LIBES): Use it.
3917 * callproc.c (Fcall_process):
3918 * process.c (create_process):
3919 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3920 Use pthread_sigmask, not sigprocmask.
123403e4 3921
1b854618
JD
39222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3923
3924 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3925 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3926 wrong (Bug#8591).
3927
3fe4b549
JD
39282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3929
0ce7e563
JD
3930 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3931 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3932 (xg_hide_tooltip): Fix comment.
3933
3fe4b549
JD
3934 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3935 in registerServicesMenuSendTypes.
3936 (validRequestorForSendType): Don't check ns_return_types.
3937
3938 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3939 ns_return_type.
3940
5df75e47
JR
39412011-07-08 Jason Rumney <jasonr@gnu.org>
3942
22610910
JR
3943 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3944 SH_SHOW for hidden windows (Bug#5482).
3945
5df75e47
JR
3946 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3947 frame struct members of non-existent frames (Bug#6284).
3948
699c10bd
JD
39492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3950
4393663b
JD
3951 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3952 variable firstTime not needed on OSX >= 10.6.
3953 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3954 >= 10.5. Use setKnobProportion, setDoubleValue.
3955
3956 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3957 (MAC_OS_X_VERSION_10_5): Define if not defined.
3958 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3959 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3960 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3961
3962 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3963 cString and lossyCString on OSX >= 10.4
3964
58179cce 3965 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3966 sizeToFit on OSX >= 10.2.
3967
3968 * nsimage.m (allocInitFromFile): Don't use deprecated method
3969 bestRepresentationForDevice on OSX >= 10.6.
3970
3971 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3972 to avoid warning.
3973
3974 * emacs.c: Declare unexec_init_emacs_zone.
3975
a63e0781
JD
3976 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3977
699c10bd
JD
3978 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3979
3980 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3981 on svcsMenu (Bug#8842).
3982
3983 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3984 ns_return_types.
3985 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3986
3987 * nsterm.m (QUTF8_STRING): Declare.
3988 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3989 (validRequestorForSendType): Return type is (id).
3990 Change indexOfObjectIdenticalTo to indexOfObject.
3991 Check if we have local selection before returning self (Bug#8842).
3992 (writeSelectionToPasteboard): Put local selection into paste board
3993 if we have a local selection (Bug#8842).
3994 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3995
3996 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3997 (ns_get_local_selection): Declare.
3998
54e10184
LMI
39992011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4000
9888ff71
LMI
4001 * keymap.c (describe_map_tree): Don't insert a double newline at
4002 the end of the buffer (bug#1169) and return whether we inserted
4003 something.
4004
54e10184
LMI
4005 * callint.c (Fcall_interactively): Change "reading args" to
4006 "providing args" to try to clarify what it does (bug#1010).
4007
15fa4783
KH
40082011-07-07 Kenichi Handa <handa@m17n.org>
4009
4010 * composite.c (composition_compute_stop_pos): Ignore a static
4011 composition starting before CHARPOS (Bug#8915).
4012
4013 * xdisp.c (handle_composition_prop): Likewise.
4014
a8815b00
EZ
40152011-07-07 Eli Zaretskii <eliz@gnu.org>
4016
4017 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4018 (Bug#9015)
4019
ef7b981d 40202011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4021
4022 * character.h (unicode_category_t): New enum type.
4023
4024 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4025 (Qchar_code_property_table): New variable.
4026 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4027 (UNIPROP_COMPRESSED_FORM_P): New macros.
4028 (char_table_ascii): Uncompress the compressed values.
4029 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4030 Uncompress the compressed values.
ac389d0c 4031 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4032 (char_table_ref_and_range): Uncompress the compressed values.
4033 (sub_char_table_set): New arg is_uniprop. Callers changed.
4034 Uncompress the compressed values.
4035 (sub_char_table_set_range): Args changed. Callers changed.
4036 (char_table_set_range): Adjuted for the above change.
4037 (map_sub_char_table): Delete args default_val and parent. Add arg
4038 top. Give decoded values to a Lisp function.
640c8776 4039 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4040 values to a Lisp function. Gcpro more variables.
4041 (uniprop_table_uncompress)
4042 (uniprop_decode_value_run_length): New functions.
4043 (uniprop_decoder, uniprop_decoder_count): New variables.
4044 (uniprop_get_decoder, uniprop_encode_value_character)
4045 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4046 New functions.
4047 (uniprop_encoder, uniprop_encoder_count): New variables.
4048 (uniprop_get_encoder, uniprop_table)
4049 (Funicode_property_table_internal, Fget_unicode_property_internal)
4050 (Fput_unicode_property_internal): New functions.
4051 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4052 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4053 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4054 char-code-property-alist.
4055
640c8776 4056 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4057 Vunicode_category_table.
4058
640c8776 4059 * font.c (font_range): Adjust for the change of
c805dec0
KH
4060 Vunicode_category_table.
4061
76b397fb
DN
40622011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4063
4064 * m/iris4d.h: Remove file, move contents ...
4065 * s/irix6-5.h: ... here.
4066
22b4128e
PE
40672011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4068
4069 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4070 * alloc.c (mark_buffer):
4071 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4072 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4073 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4074 This isn't true in general, and it's particularly not true
4075 if Emacs is configured with --with-wide-int.
4076 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4077 New macros, used in the buffer.c change.
4078
869795d6
JD
40792011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4080
4081 * xsettings.c: Use both GConf and GSettings if both are available.
4082 (store_config_changed_event): Add comment.
4083 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4084 (store_tool_bar_style_changed): New functions.
5e617bc2 4085 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4086 (struct xsettings): Move font inside HAVE_XFT.
4087 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4088 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4089 Move inside HAVE_XFT.
640c8776 4090 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4091 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4092 also.
4093 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4094 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4095 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4096 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4097 (parse_settings): Move check for font inside HAVE_XFT.
4098 (read_settings, apply_xft_settings): Add comment.
4099 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4100 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4101 call store_font_name_changed.
4102 (xft_settings_event): Add comment.
4103 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4104 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4105 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4106 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4107 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4108 (xsettings_get_system_font, xsettings_get_system_normal_font):
4109 Add comment.
869795d6 4110
d8ed26bd
PE
41112011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4112
4113 Random fixes. E.g., (random) never returned negative values.
4114 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4115 subseconds part to the entropy, as that's a bit more random.
4116 Prefer signed to unsigned, since the signedness doesn't matter and
4117 in general we prefer signed. When given a limit, use a
4118 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4119 latter isn't right if USE_2_TAGS_FOR_INTS.
4120 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4121 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4122
cabf1cac
SM
41232011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4124
4125 * textprop.c (text_property_stickiness):
4126 Obey Vtext_property_default_nonsticky.
4127 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4128 * w32fns.c (syms_of_w32fns):
4129 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4130
6e9b2be9
PE
41312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4132
4133 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4134 This is more efficient than Ffile_directory_p and avoids a minor race.
4135
90186c68
LMI
41362011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4137
7c301272
LMI
4138 * buffer.c (Foverlay_put): Say what the return value is
4139 (bug#7835).
4140
c4f2d8d4
LMI
4141 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4142 is a directory before asking whether to use the file name
4143 (bug#7564).
ad637907
LMI
4144 (barf_or_query_if_file_exists): Make the "File is a directory"
4145 error be more correct.
c4f2d8d4 4146
90186c68
LMI
4147 * fns.c (Frequire): Remove the mention of the .gz files, since
4148 that's installation-specific, but keep the mention of
4149 `get-load-suffixes'.
4150
da64016e
PE
41512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4152
4153 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4154 Report string overflow if the output is too long.
4155
7d47b580
JB
41562011-07-04 Juanma Barranquero <lekktu@gmail.com>
4157
a555cb87
JB
4158 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4159 (syms_of_gnutls): Remove duplicate DEFSYM for
4160 Qgnutls_bootprop_verify_hostname_error, an error for
4161 Qgnutls_bootprop_verify_error (which is no longer used).
4162
7d47b580
JB
4163 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4164 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4165 Also (re)move comments that are misplaced or no longer relevant.
4166
1e49bfab
LMI
41672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4168
4169 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4170
1485f4c0
CY
41712011-07-03 Chong Yidong <cyd@stupidchicken.com>
4172
4173 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4174 and background color parameters if they have been changed.
4175
a9ab721e
LMI
41762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4177
4178 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4179
cf7cff57
PE
41802011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4181
2e13213d
PE
4182 * xsettings.c (SYSTEM_FONT): Define only when used.
4183 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4184
cf7cff57
PE
4185 * keymap.c (access_keymap_1): Now static.
4186
7a8e04f7
CY
41872011-07-02 Chong Yidong <cyd@stupidchicken.com>
4188
4189 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4190 leave any prefix arg for the up event (Bug#1586).
4191
61352f62
LMI
41922011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4193
69bb1ef7
LMI
4194 * lread.c (syms_of_lread): Mention single symbols defined by
4195 `defvar' or `defconst' (bug#7154).
4196
61352f62 4197 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4198 (Frequire): Mention get-load-suffixes.
61352f62 4199
28545e04
MR
42002011-07-02 Martin Rudalics <rudalics@gmx.at>
4201
4202 * window.h (window): Remove clone_number slot.
4203 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4204 Remove.
4205 (make_parent_window, make_window, saved_window)
4206 (Fset_window_configuration, save_window_save): Don't deal with
4207 clone numbers.
4208 * buffer.c (Qclone_number): Remove declaration.
4209 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4210
3349e122
SM
42112011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4212
4213 Add multiple inheritance to keymaps.
4214 * keymap.c (Fmake_composed_keymap): New function.
4215 (Fset_keymap_parent): Simplify.
4216 (fix_submap_inheritance): Remove.
4217 (access_keymap_1): New function extracted from access_keymap to handle
4218 embedded parents and handle lists of maps.
4219 (access_keymap): Use it.
4220 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4221 (Fcopy_keymap): Handle embedded parents.
4222 (Fcommand_remapping, define_as_prefix): Simplify.
4223 (Fkey_binding): Simplify.
4224 (syms_of_keymap): Move minibuffer-local-completion-map,
4225 minibuffer-local-filename-completion-map,
4226 minibuffer-local-must-match-map, and
4227 minibuffer-local-filename-must-match-map to Elisp.
4228 (syms_of_keymap): Defsubr make-composed-keymap.
4229 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4230 (parse_menu_item): Trivial simplification.
4231
3279eb87
GM
42322011-07-01 Glenn Morris <rgm@gnu.org>
4233
4234 * Makefile.in (SETTINGS_LIBS): Fix typo.
4235
4550efdf
KI
42362011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4237
4238 * coding.c (Fencode_coding_string): Record the last coding system
4239 used, as the function doc string says (bug#8738).
4240
0949d2b6
JD
42412011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4242
4243 * xsettings.c (store_monospaced_changed): Take new font as arg and
4244 check for change against current_mono_font.
4245 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4246 (emacs_settings_constructor, emacs_settings_get_property)
4247 (emacs_settings_set_property, emacs_settings_class_init)
4248 (emacs_settings_init, gsettings_obj): Remove.
4249 (something_changedCB): New function for HAVE_GSETTINGS.
4250 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4251 with value as argument.
4252 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4253 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4254 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4255 "changed".
4256
4257 * xgselect.c: Add defined (HAVE_GSETTINGS).
4258 (xgselect_initialize): Ditto.
4259
4260 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4261 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4262 xg_select.
4263
bbc6b304
PE
42642011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4265
4266 * eval.c (struct backtrace): Simplify and port the data structure.
4267 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4268 signed bit field, as this assumption is not portable and it makes
4269 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4270 "char debug_on_exit : 1" as this is not portable either; instead,
4271 use the portable "unsigned int debug_on_exit : 1". Remove unused
4272 member evalargs. Remove obsolete comments about cc bombing out.
4273
9851bfc5
JD
42742011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4275
51bb811f 4276 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4277 Let HAVE_GSETTINGS override HAVE_GCONF.
4278 (store_monospaced_changed): New function.
4279 (EMACS_SETTINGS): A new type derived from GObject to handle
4280 GSettings notifications.
4281 (emacs_settings_constructor, emacs_settings_get_property)
4282 (emacs_settings_set_property, emacs_settings_class_init):
4283 New functions.
4284 (gsettings_client, gsettings_obj): New variables.
4285 (GSETTINGS_SCHEMA): New define.
4286 (something_changedCB): Call store_monospaced_changed.
4287 (init_gsettings): New function.
4288 (xsettings_initialize): Call init_gsettings.
4289 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4290 to NULL.
4291
640c8776 4292 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4293 GCONF_CFLAGS/LIBS.
4294
5386012d
MR
42952011-06-29 Martin Rudalics <rudalics@gmx.at>
4296
4297 * window.c (resize_root_window, grow_mini_window)
4298 (shrink_mini_window): Rename Qresize_root_window to
4299 Qwindow_resize_root_window and Qresize_root_window_vertically to
4300 Qwindow_resize_root_window_vertically.
4301
f13e0b08
PE
43022011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4303
4304 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4305
94515237
JB
43062011-06-27 Juanma Barranquero <lekktu@gmail.com>
4307
4308 * makefile.w32-in: Redesign dependencies so they reflect more
4309 clearly which files are directly included by each source file,
4310 and not through other includes.
4311
e43b6e43
MR
43122011-06-27 Martin Rudalics <rudalics@gmx.at>
4313
4314 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4315 (sort_overlays, overlay_strings): When an overlay's clone number
4316 matches the window's clone number process the overlay even if
4317 the overlay's window property doesn't match the current window.
4318
d68443dc
MR
4319 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4320 (Fwindow_hchild): Rename to Fwindow_left_child.
4321 (Fwindow_next): Rename to Fwindow_next_sibling.
4322 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4323 (resize_window_check): Rename to window_resize_check.
4324 (resize_window_apply): Rename to window_resize_apply.
4325 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4326 (Fdelete_other_windows_internal, resize_frame_windows)
4327 (Fsplit_window_internal, Fdelete_window_internal)
4328 (grow_mini_window, shrink_mini_window)
4329 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4330
c7e73be5
JD
43312011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4332
4333 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4334 (emacs_fixed_set_min_size): Remove.
4335 (emacs_fixed_new): Take frame as argument.
4336
4337 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4338 (_EmacsFixedPrivate): Remove minwidth/height.
4339 Add struct frame *f.
4340 (emacs_fixed_init): Initialize priv->f.
4341 (get_parent_class, emacs_fixed_set_min_size): Remove.
4342 (emacs_fixed_new): Set priv->f to argument.
4343 (emacs_fixed_get_preferred_width)
4344 (emacs_fixed_get_preferred_height): Use min_width/height from
4345 frames size_hint to set minimum and natural (Bug#8919).
4346 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4347 and use min_width/height from frames size_hint to set
4348 min_width/height (Bug#8919).
4349
4350 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4351 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4352 Fix indentation.
c7e73be5 4353
cf99dcf8
EZ
43542011-06-26 Eli Zaretskii <eliz@gnu.org>
4355
4356 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4357 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4358 called at ZV.
4359
029529ac
CY
43602011-06-26 Chong Yidong <cyd@stupidchicken.com>
4361
4362 * process.c (wait_reading_process_output): Bypass select if
4363 waiting for a cell while ignoring keyboard input, and input is
4364 pending. Suggested by Jan Djärv (Bug#8869).
4365
7a7ef429
PE
43662011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4367
4368 Use gnulib's dup2 module instead of rolling our own.
4369 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4370
11fdef7d 43712011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4372
4373 * dispnew.c (scrolling_window): Before scrolling, turn off a
4374 mouse-highlight in the window being scrolled.
4375
cd3520a4
JB
43762011-06-24 Juanma Barranquero <lekktu@gmail.com>
4377
4378 Move DEFSYM to lisp.h and use everywhere.
4379
4380 * character.h (DEFSYM): Move declaration...
4381 * lisp.h (DEFSYM): ...here.
4382
4383 * gnutls.c:
4384 * minibuf.c:
4385 * w32menu.c:
4386 * w32proc.c:
4387 * w32select.c: Don't include character.h.
4388
4389 * alloc.c (syms_of_alloc):
4390 * buffer.c (syms_of_buffer):
4391 * bytecode.c (syms_of_bytecode):
4392 * callint.c (syms_of_callint):
4393 * casefiddle.c (syms_of_casefiddle):
4394 * casetab.c (init_casetab_once):
4395 * category.c (init_category_once, syms_of_category):
4396 * ccl.c (syms_of_ccl):
4397 * cmds.c (syms_of_cmds):
4398 * composite.c (syms_of_composite):
4399 * dbusbind.c (syms_of_dbusbind):
4400 * dired.c (syms_of_dired):
4401 * dispnew.c (syms_of_display):
4402 * doc.c (syms_of_doc):
4403 * editfns.c (syms_of_editfns):
4404 * emacs.c (syms_of_emacs):
4405 * eval.c (syms_of_eval):
4406 * fileio.c (syms_of_fileio):
4407 * fns.c (syms_of_fns):
4408 * frame.c (syms_of_frame):
4409 * fringe.c (syms_of_fringe):
4410 * insdel.c (syms_of_insdel):
4411 * keymap.c (syms_of_keymap):
4412 * lread.c (init_obarray, syms_of_lread):
4413 * macros.c (syms_of_macros):
4414 * msdos.c (syms_of_msdos):
4415 * print.c (syms_of_print):
4416 * process.c (syms_of_process):
4417 * search.c (syms_of_search):
4418 * sound.c (syms_of_sound):
4419 * syntax.c (init_syntax_once, syms_of_syntax):
4420 * terminal.c (syms_of_terminal):
4421 * textprop.c (syms_of_textprop):
4422 * undo.c (syms_of_undo):
4423 * w32.c (globals_of_w32):
4424 * window.c (syms_of_window):
4425 * xdisp.c (syms_of_xdisp):
4426 * xfaces.c (syms_of_xfaces):
4427 * xfns.c (syms_of_xfns):
4428 * xmenu.c (syms_of_xmenu):
4429 * xsettings.c (syms_of_xsettings):
4430 * xterm.c (syms_of_xterm): Use DEFSYM.
4431
4228cf16
TZ
44322011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4433
cd3520a4 4434 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4435
7fcccf1e
PE
44362011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4437
7efb4e0e
PE
4438 Integer and buffer overflow fixes (Bug#8873).
4439
ff5844ad
PE
4440 * print.c (printchar, strout): Check for string overflow.
4441 (PRINTPREPARE, printchar, strout):
4442 Don't set size unless allocation succeeds.
4443
90532f02
PE
4444 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4445 for sizes. Check for string overflow more accurately.
4446 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4447
6d84508d
PE
4448 * macros.c: Integer and buffer overflow fixes.
4449 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4450 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4451 Use ptrdiff_t, not int, for sizes.
4452 Don't increment bufsize until after realloc succeeds.
4453 Check for size-calculation overflow.
4454 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4455
437b2cb4
PE
4456 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4457
8b9ac8b4
PE
4458 * lread.c: Integer overflow fixes.
4459 (read_integer): Radix is now EMACS_INT, not int,
4460 to improve quality of diagnostics for out-of-range radices.
4461 Calculate buffer size correctly for out-of-range radices.
4462 (read1): Check for integer overflow in radices, and in
4463 read-circle numbers.
82cb60d3
PE
4464 (read_escape): Avoid int overflow.
4465 (Fload, openp, read_buffer_size, read1)
4466 (substitute_object_recurse, read_vector, read_list, map_obarray):
4467 Use ptrdiff_t, not int, for sizes.
4468 (read1): Use EMACS_INT, not int, for sizes.
20270765 4469 Check for size overflow.
8b9ac8b4 4470
7fcccf1e
PE
4471 * image.c (cache_image): Check for size arithmetic overflow.
4472
bfbbd7e7
PE
4473 * lread.c: Integer overflow issues.
4474 (saved_doc_string_size, saved_doc_string_length)
4475 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4476 Now ptrdiff_t, not int.
4477 (read1): Don't assume doc string length fits in int. Check for
4478 out-of-range doc string lengths.
4479 (read_list): Don't assume file position fits in int.
39019e54 4480 (read_escape): Check for hex character overflow.
bfbbd7e7 4481
4e323265
LL
44822011-06-22 Leo Liu <sdl.web@gmail.com>
4483
4484 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4485 Move to minibuffer.el.
4486
85fece3e
PE
44872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4488
20b84ce9 4489 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4490 The following patches are for when GLYPH_DEBUG && !XASSERT.
4491 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4492 * dispnew.c (flush_stdout):
4493 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4494 Mark as externally visible.
4495 * dispnew.c (check_window_matrix_pointers): Now static.
4496 * dispnew.c (window_to_frame_vpos):
4497 * xfns.c (unwind_create_frame):
4498 * xterm.c (x_check_font): Remove unused local.
4499 * scroll.c (CHECK_BOUNDS):
4500 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4501 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4502 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4503 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4504 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4505 Now static.
4506 (debug_method_add): Use va_list and vsprintf rather than relying
4507 on undefined behavior with wrong number of arguments.
4508 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4509 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4510 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4511 since we're not interested in debugging glyphs with old libraries.
4512 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4513 GCC 4.6.0's static checking.
4514
0766b489
PE
45152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4516
31fd4b32
PE
4517 Integer overflow and signedness fixes (Bug#8873).
4518 A few related buffer overrun fixes, too.
4519
b79e8648
PE
4520 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4521
0766b489
PE
4522 * dispextern.h (struct face.stipple):
4523 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4524 (x_bitmap_mask, x_allocate_bitmap_record)
4525 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4526 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4527 (x_create_bitmap_from_xpm_data):
4528 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4529 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4530 (.bitmaps_last):
4531 * xfaces.c (load_pixmap):
4532 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4533 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4534 (.bitmaps_last, struct x_output.icon_bitmap):
4535 Use ptrdiff_t, not int, for bitmap indexes.
4536 (x_allocate_bitmap_record): Check for size overflow.
4537 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4538
b081724f
PE
4539 Use ptrdiff_t, not int, for overlay counts.
4540 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4541 * editfns.c (overlays_around, get_pos_property):
4542 * textprop.c (get_char_property_and_overlay):
4543 * xdisp.c (next_overlay_change, note_mouse_highlight):
4544 * xfaces.c (face_at_buffer_position):
21514da7
PE
4545 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4546 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4547 (Fnext_overlay_change, Fprevious_overlay_change)
4548 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4549 Use ptrdiff_t, not int, for sizes.
21514da7 4550 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4551
3de73e5e
PE
4552 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4553
2606c57b
PE
4554 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4555 (x_session_initialize): Do not assume string length fits in int.
4556
aaafe47a
PE
4557 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4558 This is unlikely, but can occur if DPI is outlandish.
4559
2674ddc8 4560 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4561 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4562
28154962
PE
4563 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4564 * xrdb.c (magic_file_p, search_magic_path):
4565 Omit last arg SUFFIX; it was always 0. All callers changed.
4566 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4567
7de51af5
PE
4568 * xfont.c (xfont_match): Avoid need for strlen.
4569
25ed6cc3
PE
4570 * xfns.c: Don't assume strlen fits in int.
4571 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4572
4eab31dd
PE
4573 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4574 not unsigned long, as we prefer signed integers. All callers changed.
4575 Detect integer overflow in repeat count.
4576 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4577 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4578
171e2a58
PE
4579 * termcap.c: Don't assume sizes fit in int and never overflow.
4580 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4581 (gobble_line): Check for size-calculation overflow.
4582
ad39faca 4583 * minibuf.c (Fread_buffer):
6e5bb2dc 4584 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4585 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4586 Don't assume string length fits in int.
4587
52c61c22 4588 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4589 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4590
b5b8c9e5
PE
4591 * font.c: Don't assume string length fits in int.
4592 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4593 Use ptrdiff_t, not int.
ccd6111c
PE
4594 (font_intern_prop): Don't assume string length fits in int.
4595 Don't assume integer property fits in fixnum.
4596 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4597
882f0d81 4598 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4599 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4600 Reformulate so as not to need the command string.
4601 Invoke gzip -cd rather than gunzip, as it's more portable.
4602 (lock_info_type, lock_file_1, lock_file):
4603 Don't assume pid_t and time_t fit in unsigned long.
4604 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4605 (current_lock_owner): Prefer signed type for sizes.
4606 Use memcpy, not strncpy, where memcpy is what is really wanted.
4607 Don't assume (via atoi) that time_t and pid_t fit in int.
4608 Check for time_t and/or pid_t out of range, e.g., via a network share.
4609 Don't alloca where an auto var works fine.
4610
93f4cf88
PE
4611 * fileio.c: Fix some integer overflow issues.
4612 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4613 Don't assume string length fits in int.
4614 (directory_file_name): Don't assume string length fits in long.
4615 (make_temp_name): Don't assume pid fits in int, or that its print
4616 length is less than 20.
4617
f3e92b69
PE
4618 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4619
1bfdaf10
PE
4620 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4621
35016e9a
PE
4622 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4623
3d1e65a1
PE
4624 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4625 We prefer signed integers, even for size calculations.
4626
0b963a93
PE
4627 * emacs.c: Don't assume string length fits in 'int'.
4628 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4629 (main): Don't invoke strlen when not needed.
4630
573f4b54
PE
4631 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4632 (XD_DEBUG_MESSAGE): Don't waste a byte.
4633
989f33ba
PE
4634 * callproc.c (getenv_internal_1, getenv_internal)
4635 (Fgetenv_internal):
965d34eb
PE
4636 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4637
e4d29b33
PE
4638 * lread.c (invalid_syntax): Omit length argument.
4639 All uses changed. This doesn't fix a bug, but it simplifies the
4640 code away from its former Hollerith-constant appearance, and it's
4641 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4642 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4643
eb49b136
PE
4644 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4645 This didn't break anything, but it didn't help either.
4646 It's confusing to put a bogus integer in a place where the actual
4647 value does not matter.
9f62aeb1 4648 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4649 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4650
15375a22
PE
4651 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4652 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4653 implementation.
b61cc01c
PE
4654 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4655 We prefer signed types, and the value cannot exceed the EMACS_INT
4656 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4657 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4658 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4659 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4660
53b2623d
PE
4661 * indent.c (sane_tab_width): New function.
4662 (current_column, scan_for_column, Findent_to, position_indentation)
4663 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4664 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4665
51cab52b 4666 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4667
f2ed8a70
PE
4668 * lisp.h (lint_assume): New macro.
4669 * composite.c (composition_gstring_put_cache):
4670 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4671
abe80cc6
PE
4672 * editfns.c, insdel.c:
4673 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4674
b02c740e
PE
4675 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4676
ebc96716
PE
4677 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4678
b4e50fa0 4679 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4680 Use much-faster test for byte-length change.
311d5d7c 4681 Don't assume string byte-length fits in 'int'.
a4cf38e4 4682 Check that character arg fits in 'int'.
85461888 4683 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4684
c0c1ee9f
PE
4685 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4686
a498d7f4
PE
4687 * fns.c (concat): Catch string overflow earlier.
4688 Do not rely on integer wraparound.
4689
51cab52b
PE
4690 * dispextern.h (struct it.overlay_strings_charpos)
4691 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4692 * xdisp.c (forward_to_next_line_start)
4693 (back_to_previous_visible_line_start)
4694 (reseat_at_next_visible_line_start, next_element_from_buffer):
4695 Don't arbitrarily truncate the value of 'selective' to int.
4696
76031fad
PE
4697 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4698
5eb55db9
PE
4699 * composite.c: Don't truncate sizes to 'int'.
4700 (composition_gstring_p, composition_reseat_it)
4701 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4702 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4703 not EMACS_UINT, for indexes.
5eb55db9 4704
0703a717
PE
4705 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4706
d6202519
PE
4707 * buffer.c: Include <verify.h>.
4708 (struct sortvec.priority, struct sortstr.priority):
8961a454 4709 Now EMACS_INT, not int.
c20998a7 4710 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4711 (struct sortstr.size, record_overlay_string)
4712 (struct sortstrlist.size, struct sortlist.used):
4713 Don't truncate size to int.
4714 (record_overlay_string): Check for size-calculation overflow.
d6202519 4715 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4716
d5a19415
JM
47172011-06-22 Jim Meyering <meyering@redhat.com>
4718
029529ac 4719 Don't leak an XBM-image-sized buffer
d5a19415
JM
4720 * image.c (xbm_load): Free the image buffer after using it.
4721
a9041e6c
PE
47222011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4723
4724 Port to Sun C.
4725 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4726 that Sun C diagnosed.
4727 * fns.c (secure_hash): Fix pointer signedness issue.
4728 * intervals.c (static_offset_intervals): New function.
4729 (offset_intervals): Use it.
4730
7f3f739f
LL
47312011-06-21 Leo Liu <sdl.web@gmail.com>
4732
4733 * deps.mk (fns.o):
4734 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4735 sha512.h.
4736
4737 * fns.c (secure_hash): Rename from crypto_hash_function and change
4738 the first arg to accept symbols.
5b66d427 4739 (Fsecure_hash): New primitive.
7f3f739f
LL
4740 (syms_of_fns): New symbols.
4741
76147d94
DD
47422011-06-20 Deniz Dogan <deniz@dogan.se>
4743
4744 * process.c (Fset_process_buffer): Clarify return value in
4745 docstring.
4746
7d7d0045
CY
47472011-06-18 Chong Yidong <cyd@stupidchicken.com>
4748
4749 * dispnew.c (add_window_display_history): Use BVAR.
4750
4751 * xdisp.c (debug_method_add): Use BVAR.
4752 (check_window_end, dump_glyph_matrix, dump_glyph)
4753 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4754
4755 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4756 Likewise.
4757
4758 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4759 check till after the cache is created in init_frame_faces.
4760
ff2bc410
SM
47612011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4762
4763 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4764
28177add
PE
47652011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4766
dd3482fe
PE
4767 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4768 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4769 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4770
393d71f3 4771 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4772 * fileio.c (Finsert_file_contents):
4773 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4774 Remove the old (too-loose) buffer overflow checks.
4775 They weren't needed, since make_gap checks for buffer overflow.
4776 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4777 The old code merely checked for Emacs fixnum overflow, and relied
4778 on undefined (wraparound) behavior. The new code avoids undefined
4779 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4780
2e6813b0 4781 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4782 Tune. Don't use wider integers than needed. Don't use alloca.
4783 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4784
599a9e4f
PE
4785 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4786
99561444
PE
4787 * insdel.c, lisp.h (buffer_overflow): New function.
4788 (insert_from_buffer_1, replace_range, replace_range_2):
4789 * insdel.c (make_gap_larger):
4790 * editfns.c (Finsert_char):
4791 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4792
28177add
PE
4793 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4794
e69dafad
PE
47952011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4796
4baa020d 4797 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4798
b1c46f02
PE
4799 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4800 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4801
e69dafad
PE
4802 * fileio.c: Don't assume EMACS_INT fits in off_t.
4803 (emacs_lseek): New static function.
4804 (Finsert_file_contents, Fwrite_region): Use it.
4805 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4806
566684ea
PE
4807 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4808
e6966cd6
PE
4809 * fns.c: Don't overflow int when computing a list length.
4810 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4811 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4812 truncation on 64-bit hosts. Check for QUIT every
4813 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4814 faster and is responsive enough.
4815 (Flength): Report an error instead of overflowing an integer.
4816 (Fsafe_length): Return a float if the value is not representable
4817 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4818 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4819 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4820
dd0b0efb
PE
4821 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4822 (header_size, word_size): New constants.
4823 (allocate_vectorlike): Don't check size overflow here.
4824 (allocate_vector): Check it here instead, since this is the only
4825 caller of allocate_vectorlike that could cause overflow.
4826 Check that the new vector's length is representable as a fixnum.
4827
86fe5cfe
PE
4828 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4829 The previous code was bogus. For example, next_almost_prime (32)
4830 returned 39, which is undesirable as it is a multiple of 3; and
4831 next_almost_prime (24) returned 25, which is a multiple of 5 so
4832 why was the code bothering to check for multiples of 7?
4833
80e88859
PE
4834 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4835
4a2f0ad6
PE
4836 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4837
f66c7cf8
PE
4838 Variadic C functions now count arguments with ptrdiff_t.
4839 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4840 Back then I didn't know that the Emacs coding style prefers signed int.
4841 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4842 were being counted with int, which may truncate counts on 64-bit
4843 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4844 * lisp.h (struct Lisp_Subr.function.aMANY)
4845 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4846 Arg counts are now ptrdiff_t, not size_t.
4847 All variadic functions and their callers changed accordingly.
4848 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4849 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4850 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4851 * callint.c (Fcall_interactively): Check arg count for overflow,
4852 to avoid potential buffer overrun. Use signed char, not 'int',
4853 for 'varies' array, so that we needn't bother to check its size
4854 calculation for overflow.
4855 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4856 * eval.c (apply_lambda):
4857 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4858 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4859 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4860
a1759b76
PE
4861 * callint.c (Fcall_interactively): Don't use index var as event count.
4862
d96be9fc
PE
4863 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4864 * mem-limits.h (SIZE): Remove; no longer used.
4865
a690a978 4866 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4867
578c21e6
PE
4868 Remove unnecessary casts.
4869 * xterm.c (x_term_init):
4870 * xfns.c (x_set_border_pixel):
4871 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4872 These aren't needed now that we assume ANSI C.
4873
96f53c6c
PE
4874 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4875 It's more likely to cause problems (due to unsigned overflow)
4876 than to cure them.
4877
83c77d31
PE
4878 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4879
ee2079f1
PE
4880 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4881
6da65536
PE
4882 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4883
7147c4a4
PE
4884 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4885
193e32d9
PE
4886 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4887
e5533da6
PE
4888 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4889
9910e595
PE
4890 GLYPH_CODE_FACE returns EMACS_INT, not int.
4891 * dispextern.h (merge_faces):
4892 * xfaces.c (merge_faces):
01103c44
PE
4893 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4894 Don't assume EMACS_INT fits in int.
9910e595 4895
2638320e
PE
4896 * character.h (CHAR_VALID_P): Remove unused parameter.
4897 * fontset.c, lisp.h, xdisp.c: All uses changed.
4898
045eb8d9
PE
4899 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4900
c1f134b5
PE
4901 * fns.c (concat): Minor tuning based on overflow analysis.
4902 This doesn't fix any bugs. Use int to hold character, instead
4903 of constantly refetching from Emacs object. Use XFASTINT, not
4904 XINT, for value known to be a character. Don't bother comparing
4905 a single byte to 0400, as it's always less.
4906
395fcb93 4907 * floatfns.c (Fexpt):
327eeec8
PE
4908 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4909
abbd3d23
PE
4910 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4911 for characters.
4912
684a03ef
PE
4913 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4914
0fed43f3
PE
4915 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4916 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4917 incorrectly succeed when S was a string, because 4294967386 was
4918 truncated before it was used.
4919
8fd02eb7
PE
4920 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4921 Otherwise, an out-of-range integer could cause undefined behavior
4922 on a 64-bit host.
4923
f8c86b69
PE
4924 * composite.c: Use int, not EMACS_INT, for characters.
4925 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4926 EMACS_INT, for values that are known to be in character range.
4927 This doesn't fix any bugs but is the usual style inside Emacs and
4928 may generate better code on 32-bit machines.
4929
34206dd2
PE
4930 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4931 This is for reasons similar to the recent CHAR_STRING fix.
4932 * charset.c (Fencode_char): Check that character arg is actually
4933 a character. Pass an int to ENCODE_CHAR.
4934 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4935 wider than 'int', as a compile-time check to prevent future regressions
4936 in this area.
4937
c5958d4c 4938 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4939
4940 Make sure a 64-bit char is never passed to CHAR_STRING.
4941 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4942 by silently ignoring the top 32 bits, allowing some values
4943 that were far too large to be valid characters.
4944 * character.h: Include <verify.h>.
4945 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4946 arguments are no wider than unsigned, as a compile-time check
4947 to prevent future regressions in this area.
4948 * data.c (Faset):
01103c44 4949 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4950 (Fsubst_char_in_region):
4951 * fns.c (concat):
4952 * xdisp.c (decode_mode_spec_coding):
4953 Adjust to CHAR_STRING's new requirement.
4954 * editfns.c (Finsert_char, Fsubst_char_in_region):
4955 * fns.c (concat): Check that character args are actually
4956 characters. Without this test, these functions did the wrong
4957 thing with wildly out-of-range values on 64-bit hosts.
4958
d37ca623
PE
4959 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4960 These casts should not be needed on 32-bit hosts, either.
4961 * keyboard.c (read_char):
4962 * lread.c (Fload): Remove casts to unsigned.
4963
ea204efb
PE
4964 * lisp.h (UNSIGNED_CMP): New macro.
4965 This fixes comparison bugs on 64-bit hosts.
4966 (ASCII_CHAR_P): Use it.
4967 * casefiddle.c (casify_object):
01103c44 4968 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4969 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4970 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4971 * dispextern.h (FACE_FROM_ID):
4972 * keyboard.c (read_char): Use UNSIGNED_CMP.
4973
41cb286c
PE
4974 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4975 not to EMACS_INT, to avoid GCC warning.
4976
4a1b9832
PE
4977 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4978
55daad71
PE
4979 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4980 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4981 isn't needed on 32-bit machines.
8f95c75c 4982
01103c44
PE
4983 * buffer.c (Fgenerate_new_buffer_name):
4984 Use EMACS_INT for count, not int.
0ceccced 4985 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4986
4987 * data.c (Qcompiled_function): Now static.
4988
c6f072e7
PE
4989 * window.c (window_body_lines): Now static.
4990
20ce5912
PE
4991 * image.c (gif_load): Rename local to avoid shadowing.
4992
9c4c5f81
PE
4993 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4994 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4995 * alloc.c (make_save_value): Integer argument is now of type
4996 ptrdiff_t, not int.
4997 (mark_object): Use ptrdiff_t, not int.
4998 * lisp.h (pD): New macro.
4999 * print.c (print_object): Use it.
5000
c0c5c8ae
PE
5001 * alloc.c: Use EMACS_INT, not int, to count objects.
5002 (total_conses, total_markers, total_symbols, total_vector_size)
5003 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5004 (total_free_floats, total_floats, total_free_intervals)
5005 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5006 Now EMACS_INT, not int. All uses changed.
5007 (Fgarbage_collect): Compute overall total using a double, so that
5008 integer overflow is less likely to be a problem. Check for overflow
5009 when converting back to an integer.
5a25e253
PE
5010 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5011 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5012 These were 'int' variables that could overflow on 64-bit hosts;
5013 they were never used, so remove them instead of repairing them.
211a0b2a 5014 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5015 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5016 Previously, this ceilinged at INT_MAX, but that doesn't work on
5017 64-bit machines.
e46bb31a 5018 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5019
c78baabf 5020 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5021 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5022 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5023 when a (possibly-narrower) signed value would do just as well.
5024 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5025
c9d624c6
PE
5026 * alloc.c: Catch some string size overflows that we were missing.
5027 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5028 for convenience in STRING_BYTES_MAX.
5029 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5030 The definition here is exact; the one in lisp.h was approximate.
5031 (allocate_string_data): Check for string overflow. This catches
5032 some instances we weren't catching before. Also, it catches
5033 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5034 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5035 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5036
c9d624c6
PE
5037 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5038 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5039 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5040
353032ce
PE
5041 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5042
2bccce07
PE
5043 * alloc.c (Fmake_string): Check for out-of-range init.
5044
0ac30604
SM
50452011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5046
5047 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5048
c195f2de
JD
50492011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5050
5051 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5052 xg_get_default_scrollbar_width.
5053
5054 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5055 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5056 (style_changed_cb): Call update_theme_scrollbar_width and call
5057 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5058 all frames (Bug#8505).
5059 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5060 Call gtk_window_set_resizable if HAVE_GTK3.
5061 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5062 and height if HAVE_GTK3 (Bug#8505).
5063 (scroll_bar_width_for_theme): New variable.
5064 (update_theme_scrollbar_width): New function.
5065 (xg_get_default_scrollbar_width): Move code to
5066 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5067 (xg_initialize): Call update_theme_scrollbar_width.
5068
5069 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5070
5071 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5072
e10ac9f1
MR
50732011-06-12 Martin Rudalics <rudalics@gmx.at>
5074
5075 * frame.c (make_frame): Call other_buffer_safely instead of
5076 other_buffer.
5077
5078 * window.c (temp_output_buffer_show): Call display_buffer with
5079 second argument Vtemp_buffer_show_specifiers and reset latter
5080 immediately after the call.
5081 (Vtemp_buffer_show_specifiers): New variable.
5082 (auto_window_vscroll_p, next_screen_context_lines)
5083 (Vscroll_preserve_screen_position): Remove leading asterisks from
5084 doc-strings.
5085
2d3c217e 50862011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5087
7b7f97e8 5088 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5089 * buffer.c (Qclone_number): Remove for now, as it's unused.
5090 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5091 (record_buffer): Remove unused local.
5092 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5093 (set_frame_buffer_list): Remove; unused.
5094 * frame.h (other_visible_frames): Remove decl.
5095 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5096 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5097 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5098 if HAVE_GPM.
5099 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5100 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5101 Define only if HAVE_GPM.
5102 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5103 (update_hints_inhibit): Remove; never set. All uses removed.
5104 * widgetprv.h (emacsFrameClassRec): Remove decl.
5105 * window.c (delete_deletable_window): Now returns void, since it
5106 wasn't returning anything.
5107 (compare_window_configurations): Remove unused locals.
5108 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5109 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5110 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5111 the same widths as pointers. This follows up on the 2011-05-06 patch.
5112 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5113 * xterm.h: Likewise.
5114 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5115
1384b89e
JB
51162011-06-12 Juanma Barranquero <lekktu@gmail.com>
5117
5118 * makefile.w32-in: Update dependencies.
5119 (LISP_H): Add lib/intprops.h.
5120
1100a63c
CY
51212011-06-11 Chong Yidong <cyd@stupidchicken.com>
5122
5123 * image.c (gif_load): Add animation frame delay to the metadata.
5124 (syms_of_image): Use DEFSYM. New symbol `delay'.
5125
6198ccd0
MR
51262011-06-11 Martin Rudalics <rudalics@gmx.at>
5127
5128 * window.c (delete_deletable_window): Re-add.
5129 (Fset_window_configuration): Rewrite to handle dead buffers and
5130 consequently deletable windows.
5131 (window_tree, Fwindow_tree): Remove. Supply functionality in
5132 window.el.
5133 (compare_window_configurations): Simplify code.
5134
b6e3633c
AS
51352011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5136
1ab0dee5
AS
5137 * image.c (imagemagick_load_image): Fix type mismatch.
5138 (Fimagemagick_types): Likewise.
5139
b6e3633c
AS
5140 * window.h (replace_buffer_in_windows): Declare.
5141
9397e56f
MR
51422011-06-11 Martin Rudalics <rudalics@gmx.at>
5143
5144 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5145 Qclone_number. Remove external declaration of Qdelete_window.
5146 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5147 code.
640c8776
SM
5148 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5149 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5150 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5151 buffer list implementation.
5152 (other_buffer_safely): New function.
5153 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5154 calls to replace_buffer_in_windows and
5155 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5156 if allowed.
5157 (record_buffer): Inhibit quitting and rewrite using quittable
5158 functions. Run Qbuffer_list_update_hook if allowed.
5159 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5160 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5161 Move switch-to-buffer to window.el.
9397e56f
MR
5162 (bury-buffer): Move to window.el.
5163 (Vbuffer_list_update_hook): New variable.
5164
5165 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5166 section.
5167
5168 * window.h (resize_frame_windows): Move up in code.
5169 (Fwindow_frame): Remove EXFUN.
5170 (replace_buffer_in_all_windows): Remove prototype.
5171 (replace_buffer_in_windows_safely): Add prototype.
5172
5173 * window.c: Declare Qdelete_window static again. Move down
5174 declaration of select_count.
5175 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5176 (Fother_window): Move to window.el.
5177 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5178 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5179 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5180 window.el.
5181 (replace_buffer_in_windows): Implement by calling
5182 Qreplace_buffer_in_windows.
5183 (replace_buffer_in_all_windows): Remove with some functionality
5184 moved into replace_buffer_in_windows_safely.
5185 (replace_buffer_in_windows_safely): New function.
5186 (select_window_norecord, select_frame_norecord): Move in front
5187 of run_window_configuration_change_hook. Remove now obsolete
5188 declarations.
640c8776
SM
5189 (Fset_window_buffer): Rewrite doc-string.
5190 Call Qrecord_window_buffer.
9397e56f
MR
5191 (keys_of_window): Move binding for other-window to window.el.
5192
b50691aa
CY
51932011-06-11 Chong Yidong <cyd@stupidchicken.com>
5194
5195 * dispextern.h (struct image): Replace data member, whose int_val
5196 and ptr_val fields were not used by anything, with a single
5197 lisp_val object.
5198
5199 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5200 (gif_clear_image, gif_load, imagemagick_load_image)
5201 (gs_clear_image, gs_load): Callers changed.
5202
3f754b86
PE
52032011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5204
cca69397
PE
5205 * buffer.h: Include <time.h>, for time_t.
5206 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5207
109e28d0
PE
5208 Fix minor problems found by static checking.
5209
60737f02
PE
5210 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5211
4b66faf3
PE
5212 Make identifiers static if they are not used in other modules.
5213 * data.c (Qcompiled_function, Qframe, Qvector):
5214 * image.c (QimageMagick, Qsvg):
5215 * minibuf.c (Qmetadata):
5216 * window.c (resize_window_check, resize_root_window): Now static.
5217 * window.h (resize_window_check, resize_root_window): Remove decls.
5218
109e28d0
PE
5219 * window.c (window_deletion_count, delete_deletable_window):
5220 Remove; unused.
46a4ce9e
PE
5221 (window_body_lines): Now static.
5222 (Fdelete_other_windows_internal): Mark vars as initialized.
5223 Make sure 'resize_failed' is initialized.
5224 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5225 (resize_window_apply): Remove unused local.
5226 * window.h (delete_deletable_window): Remove decl.
5227
109e28d0 5228 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5229 (imagemagick_load_image): Fix pointer signedness problem by changing
5230 last arg from unsigned char * to char *. All uses changed.
5231 Also, fix a local for similar reasons.
5232 Remove unused locals. Remove locals to avoid shadowing.
5233 (fn_rsvg_handle_free): Remove; unused.
5234 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5235 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5236
3f754b86
PE
5237 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5238
2547adb1
CY
52392011-06-10 Chong Yidong <cyd@stupidchicken.com>
5240
5241 * image.c (gif_load): Fix omitted cast error introduced by
5242 2011-06-06 change.
5243
2c8e37d4
MR
52442011-06-10 Martin Rudalics <rudalics@gmx.at>
5245
5246 * window.h (resize_proportionally, orig_total_lines)
5247 (orig_top_line): Remove from window structure.
5248 (set_window_height, set_window_width, change_window_heights)
5249 (Fdelete_window): Remove prototypes.
5250 (resize_frame_windows): Remove duplicate declaration.
5251
440a42e3
EZ
52522011-06-10 Eli Zaretskii <eliz@gnu.org>
5253
5254 * window.h (resize_frame_windows, resize_window_check)
5255 (delete_deletable_window, resize_root_window)
5256 (resize_frame_windows): Declare prototypes.
5257
5258 * window.c (resize_window_apply): Make definition be "static" to
5259 match the prototype.
5260
562dd5e9
MR
52612011-06-10 Martin Rudalics <rudalics@gmx.at>
5262
5263 * window.c: Remove declarations of Qwindow_size_fixed,
5264 window_min_size_1, window_min_size_2, window_min_size,
5265 size_window, window_fixed_size_p, enlarge_window, delete_window.
5266 Remove static from declaration of Qdelete_window, it's
5267 temporarily needed by Fbury_buffer.
5268 (replace_window): Don't assign orig_top_line and
5269 orig_total_lines.
5270 (Fdelete_window, delete_window): Remove. Window deletion is
5271 handled by window.el.
640c8776
SM
5272 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5273 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5274 (Fdelete_other_windows): Remove. Deleting other windows is
5275 handled by window.el.
5276 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5277 handled in window.el.
5278 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5279 Window minimum sizes are handled in window.el.
5280 (shrink_windows, size_window, set_window_height)
5281 (set_window_width, change_window_heights, window_height)
5282 (window_width, CURBEG, CURSIZE, enlarge_window)
5283 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5284 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5285 handled in window.el.
5286 (make_dummy_parent): Rename to make_parent_window and give it a
5287 second argument horflag.
5288 (make_window): Don't set resize_proportionally any more.
5289 (Fsplit_window): Remove. Windows are split in window.el.
5290 (save_restore_action, save_restore_orig_size)
5291 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5292 Resize mini windows in window.el.
5293 (grow_mini_window, shrink_mini_window): Implement by calling
5294 Qresize_root_window_vertically, resize_window_check and
5295 resize_window_apply.
640c8776
SM
5296 (saved_window, Fset_window_configuration, save_window_save):
5297 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5298 resize_proportionally.
5299 (window_min_height, window_min_width): Move to window.el.
5300 (keys_of_window): Move bindings for delete-other-windows,
5301 split-window, delete-window and enlarge-window to window.el.
5302
5303 * buffer.c: Temporarily extern Qdelete_window.
5304 (Fbury_buffer): Temporarily call Qdelete_window instead of
5305 Fdelete_window (Fbury_buffer will move to window.el soon).
5306
5307 * frame.c (set_menu_bar_lines_1): Remove code handling
5308 orig_top_line and orig_total_lines.
5309
5310 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5311 set_window_height but set heights directly.
5312 (change_frame_size_1): Use resize_frame_windows.
5313
5314 * xdisp.c (init_xdisp): Don't use set_window_height but set
5315 heights directly.
5316
640c8776
SM
5317 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5318 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5319 run_window_configuration_change_hook.
5320
5321 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5322 instead of change_window_heights and run
5323 run_window_configuration_change_hook.
5324
1a13852e
MR
53252011-06-09 Martin Rudalics <rudalics@gmx.at>
5326
5327 * window.c (replace_window): Rename second argument REPLACEMENT to
5328 NEW. New third argument SETFLAG. Rewrite.
5329 (delete_window, make_dummy_parent): Call replace_window with
5330 third argument 1.
5331 (window_list_1): Move down in code.
5332 (run_window_configuration_change_hook): Move set_buffer part
5333 before select_frame_norecord part in order to unwind correctly.
5334 Rename count1 to count.
5335 (recombine_windows, delete_deletable_window, resize_root_window)
5336 (Fdelete_other_windows_internal)
5337 (Frun_window_configuration_change_hook, make_parent_window)
5338 (resize_window_check, resize_window_apply, Fresize_window_apply)
5339 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5340 (Fdelete_window_internal, Fresize_mini_window_internal):
5341 New functions.
1a13852e
MR
5342 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5343
f3d1777e
MR
53442011-06-08 Martin Rudalics <rudalics@gmx.at>
5345
496e208e
MR
5346 * window.h (window): Add some new members to window structure -
5347 normal_lines, normal_cols, new_total, new_normal, clone_number,
5348 splits, nest, prev_buffers, next_buffers.
5349 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5350 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5351
f3d1777e
MR
5352 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5353 Remove.
496e208e
MR
5354 (make_dummy_parent): Set new members of windows structure.
5355 (make_window): Move down in code. Handle new members of window
5356 structure.
5357 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5358 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5359 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5360 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5361 (Fset_window_next_buffers, Fset_window_clone_number):
5362 New functions.
496e208e
MR
5363 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5364 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5365 Doc-string fixes.
5366 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5367 Argument WINDOW can be now internal window too.
5368 (Fwindow_use_time): Move up in code.
5369 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5370 Rewrite doc-string.
5371 (Fset_window_configuration, saved_window)
5372 (Fcurrent_window_configuration, save_window_save): Handle new
5373 members of window structure.
b9e809c2
MR
5374 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5375 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5376 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5377 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5378 Qget_mru_window, Qresize_root_window,
5379 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5380 Qauto_buffer_name; staticpro them.
f3d1777e 5381
abde8f8c
MR
53822011-06-07 Martin Rudalics <rudalics@gmx.at>
5383
5384 * window.c (Fwindow_total_size, Fwindow_left_column)
5385 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5386 (Fwindow_list_1): New functions.
5387 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5388 (Fwindow_width, Fscroll_left, Fscroll_right):
5389 Use window_body_cols instead of window_box_text_cols.
5390 (delete_window, Fset_window_configuration):
5391 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5392 (delete_all_subwindows): Take a window as argument and not a
5393 structure. Rewrite.
190b47e6
MR
5394 (window_loop): Remove handling of GET_LRU_WINDOW and
5395 GET_LARGEST_WINDOW.
5396 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5397
5398 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5399 window_box_text_cols. delete_all_subwindows now takes a
5400 Lisp_Object as argument.
abde8f8c 5401
640c8776
SM
5402 * indent.c (compute_motion, Fcompute_motion):
5403 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5404
fa8a67e6
MR
5405 * frame.c (delete_frame): Call delete_all_subwindows with root
5406 window as argument.
5407
a54e3482
DC
54082011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5409
5410 * fns.c (Fputhash): Document return value.
5411
60002bf5
CY
54122011-06-06 Chong Yidong <cyd@stupidchicken.com>
5413
5414 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5415
0c671da6 54162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5417
b862a52a 5418 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5419
be44ca6c
PE
5420 Check for overflow when converting integer to cons and back.
5421 * charset.c (Fdefine_charset_internal, Fdecode_char):
5422 Use cons_to_unsigned to catch overflow.
5423 (Fencode_char): Use INTEGER_TO_CONS.
5424 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5425 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5426 * data.c (long_to_cons, cons_to_long): Remove.
5427 (cons_to_unsigned, cons_to_signed): New functions.
5428 These signal an error for invalid or out-of-range values.
5429 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5430 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5431 * font.c (Ffont_variation_glyphs):
5432 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5433 * lisp.h: Include <intprops.h>.
5434 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5435 (cons_to_signed, cons_to_unsigned): New decls.
5436 (long_to_cons, cons_to_long): Remove decls.
5437 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5438 (Fprimitive_undo): Use CONS_TO_INTEGER.
5439 * xfns.c (Fx_window_property): Likewise.
5440 * xselect.c: Include <limits.h>.
5441 (x_own_selection, selection_data_to_lisp_data):
5442 Use INTEGER_TO_CONS.
5443 (x_handle_selection_request, x_handle_selection_clear)
5444 (x_get_foreign_selection, Fx_disown_selection_internal)
5445 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5446 (lisp_data_to_selection_data): Use cons_to_unsigned.
5447 (x_fill_property_data): Use cons_to_signed.
5448 Report values out of range.
5449
d1f3d2af
PE
5450 Check for buffer and string overflow more precisely.
5451 * buffer.h (BUF_BYTES_MAX): New macro.
5452 * lisp.h (STRING_BYTES_MAX): New macro.
5453 * alloc.c (Fmake_string):
5454 * character.c (string_escape_byte8):
5455 * coding.c (coding_alloc_by_realloc):
5456 * doprnt.c (doprnt):
5457 * editfns.c (Fformat):
5458 * eval.c (verror):
5459 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5460 since they may not be the same number.
5461 * editfns.c (Finsert_char):
5462 * fileio.c (Finsert_file_contents):
5463 Likewise for BUF_BYTES_MAX.
5464
dd52fcea
PE
5465 * image.c: Use ptrdiff_t, not int, for sizes.
5466 (slurp_file): Switch from int to ptrdiff_t.
5467 All uses changed.
5468 (slurp_file): Check that file size fits in both size_t (for
5469 malloc) and ptrdiff_t (for sanity and safety).
5470
7f9bbdbb
PE
5471 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5472 if b->modtime has its maximal value.
5473
dfe18f82
PE
5474 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5475
84acfcf0
PE
5476 Don't assume time_t can fit into int.
5477 * buffer.h (struct buffer.modtime): Now time_t, not int.
5478 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5479 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5480
ccd9a01a
PE
5481 Minor fixes for signed vs unsigned integers.
5482 * character.h (MAYBE_UNIFY_CHAR):
5483 * charset.c (maybe_unify_char):
5484 * keyboard.c (read_char, reorder_modifiers):
5485 XINT -> XFASTINT, since the integer must be nonnegative.
5486 * ftfont.c (ftfont_spec_pattern):
5487 * keymap.c (access_keymap, silly_event_symbol_error):
5488 XUINT -> XFASTINT, since the integer must be nonnegative.
5489 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5490 since it makes no difference and we prefer signed.
5491 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5492 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5493 nonnegative.
5494
d6d100dd
SM
54952011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5496
5497 * window.h (Fwindow_frame): Declare.
5498
2b6148e4
PE
54992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5500
5501 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5502 (SPARE_MEMORY): Always define.
5503 (LARGE_REQUEST): Remove.
5504 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5505
f230ecc9
MR
55062011-06-06 Martin Rudalics <rudalics@gmx.at>
5507
727e958e
MR
5508 * lisp.h: Move EXFUNS for Fframe_root_window,
5509 Fframe_first_window and Fset_frame_selected_window to window.h.
5510
5511 * window.h: Move EXFUNS for Fframe_root_window,
5512 Fframe_first_window and Fset_frame_selected_window here from
5513 lisp.h.
5514
5515 * frame.c (Fwindow_frame, Fframe_first_window)
5516 (Fframe_root_window, Fframe_selected_window)
5517 (Fset_frame_selected_window): Move to window.c.
5518 (Factive_minibuffer_window): Move to minibuf.c.
5519 (Fother_visible_frames_p): New function.
5520
5521 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5522
f230ecc9
MR
5523 * window.c (decode_window, decode_any_window): Move up in code.
5524 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5525 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5526 (Fwindow_buffer): Move up and rewrite doc-string.
5527 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5528 (Fwindow_prev): New functions.
727e958e
MR
5529 (Fwindow_frame): Move here from frame.c. Accept any window as
5530 argument.
5531 (Fframe_root_window, Fframe_first_window)
5532 (Fframe_selected_window): Move here from frame.c. Accept frame
5533 or arbitrary window as argument. Update doc-strings.
5534 (Fminibuffer_window): Move up in code.
5535 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5536 (Fset_frame_selected_window): Move here from frame.c.
5537 Marginal rewrite.
727e958e
MR
5538 (Fselected_window, select_window, Fselect_window): Move up in
5539 code. Minor doc-string fixes.
f230ecc9 5540
4d09bcf6
PE
55412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5542
5543 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5544 Do not assume that spare memory exists; that assumption is valid
5545 only if SYSTEM_MALLOC.
5546 (LARGE_REQUEST): New macro, so that the issue of large requests
5547 is separated from the issue of spare memory.
5548
810928a2
AS
55492011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5550
172418ad
AS
5551 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5552 format. (Bug#8806)
5553
43f862f7
AS
5554 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5555
810928a2
AS
5556 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5557 before statements.
5558
a059fe24
JD
55592011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5560
5561 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5562
5563 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5564
5565 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5566 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5567
989bf368
JB
55682011-06-05 Juanma Barranquero <lekktu@gmail.com>
5569
5570 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5571
4b80f674
CY
55722011-06-04 Chong Yidong <cyd@stupidchicken.com>
5573
5574 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5575 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5576 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5577 New error handlers.
4b80f674
CY
5578 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5579 Obey Vx_select_enable_clipboard_manager. Catch errors in
5580 x_clipboard_manager_save (Bug#8779).
5581 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5582 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5583
99a33b77 55842011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5585
5586 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5587
99a33b77 55882011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5589
5590 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5591 in the current matrix if keep_current_p is non-zero.
5592
8264569d
EZ
55932011-06-04 Eli Zaretskii <eliz@gnu.org>
5594
5595 * bidi.c (bidi_level_of_next_char): Fix last change.
5596
57f97249
EZ
55972011-06-03 Eli Zaretskii <eliz@gnu.org>
5598
fec2107c 5599 Support bidi reordering of text covered by display properties.
57f97249 5600
fec2107c
EZ
5601 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5602 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5603 (bidi_cache_search, bidi_cache_iterator_state)
5604 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5605 (bidi_level_of_next_char, bidi_move_to_visually_next):
5606 Support character positions inside a run of characters covered by a
fec2107c
EZ
5607 display string.
5608 (bidi_paragraph_init, bidi_resolve_explicit_1)
5609 (bidi_level_of_next_char): Call bidi_fetch_char and
5610 bidi_fetch_char_advance instead of FETCH_CHAR and
5611 FETCH_CHAR_ADVANCE.
5612 (bidi_init_it): Initialize new members.
5613 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5614 definitions.
5615 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5616 instead of using explicit *_CHAR codes.
d6d100dd
SM
5617 (bidi_resolve_explicit, bidi_resolve_weak):
5618 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5619 bidirectional text is supported only in multibyte buffers.
5620 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5621 it to initialize the frame_window_p member of struct bidi_it.
5622 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5623 (bidi_resolve_explicit, bidi_resolve_weak)
5624 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5625 bidi_it->nchars is non-positive.
5626 (bidi_level_of_next_char): Don't try to lookup the cache for the
5627 next/previous character if nothing is cached there yet, or if we
5628 were just reseat()'ed to a new position.
c40e2fb2 5629
0e14fe90
EZ
5630 * xdisp.c (set_cursor_from_row): Set start and stop points
5631 according to the row's direction when priming the loop that looks
5632 for the glyph on which to display cursor.
5633 (single_display_spec_intangible_p): Function deleted.
5634 (display_prop_intangible_p): Reimplement to call
5635 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5636 Accept 3 additional arguments needed by handle_display_spec.
5637 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5638 values: lists, `(when COND...)' forms, etc.
5639 (single_display_spec_string_p): Support property values that are
5640 lists with the argument STRING its top-level element.
5641 (display_prop_string_p): Fix the condition for processing a
5642 property that is a list to be consistent with handle_display_spec.
fec2107c 5643 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5644 last portion of handle_display_prop.
5645 (compute_display_string_pos): Accept additional argument
5646 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5647 value of a `display' property is a "replacing spec".
5648 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5649 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5650 the display property, but just return a value indicating whether
5651 the display property will replace the characters it covers.
5652 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5653 frame_window_p members of struct bidi_it.
d6d100dd
SM
5654 (compute_display_string_pos, compute_display_string_end):
5655 New functions.
fec2107c
EZ
5656 (push_it): Accept second argument POSITION, where pop_it should
5657 jump to continue iteration.
5658 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5659
fec2107c
EZ
5660 * keyboard.c (adjust_point_for_property): Adjust the call to
5661 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5662
5663 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5664 (bidi_init_it): Update prototypes.
5665 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5666 (compute_display_string_pos, compute_display_string_end):
5667 Declare prototypes.
fec2107c
EZ
5668 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5669 EMACS_INT.
fc6f18ce 5670
40087514 56712011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5672
57f53182
PE
5673 Malloc failure behavior now depends on size of allocation.
5674 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5675 * lisp.h: Change signatures accordingly.
5676 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5677 All callers changed. (Bug#8762)
5678
5679 * gnutls.c: Use Emacs's memory allocators.
5680 Without this change, the gnutls library would invoke malloc etc.
5681 directly, which causes problems on non-SYNC_INPUT hosts, and which
5682 runs afoul of improving memory_full behavior. (Bug#8761)
5683 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5684 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5685 xfree instead of the default malloc, realloc, free.
5686 (Fgnutls_boot): No need to check for memory allocation failure,
5687 since xmalloc does that for us.
5688
ac32cd99 5689 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5690 * category.c (hash_get_category_set):
5691 * ccl.c (ccl_driver):
5692 * charset.c (Fdefine_charset_internal):
5693 * charset.h (struct charset.hash_index):
5694 * composite.c (get_composition_id, gstring_lookup_cache)
5695 (composition_gstring_put_cache):
5696 * composite.h (struct composition.hash_index):
5697 * dispextern.h (struct image.hash):
5698 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5699 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5700 (hashfn_equal, hashfn_user_defined, make_hash_table)
5701 (maybe_resize_hash_table, hash_lookup, hash_put)
5702 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5703 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5704 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5705 * image.c (make_image, search_image_cache, lookup_image)
5706 (xpm_put_color_table_h):
5707 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5708 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5709 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5710 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5711 * alloc.c (allocate_vectorlike):
5712 Check for overflow in vector size calculations.
5713 * ccl.c (ccl_driver):
5714 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5715 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5716 need to be updated by these changes.
40087514
PE
5717 * fns.c (make_hash_table, maybe_resize_hash_table):
5718 Check for integer overflow with large hash tables.
0de4bb68
PE
5719 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5720 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5721 (SXHASH_REDUCE): New macro.
5722 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5723 Use it instead of discarding useful hash info with large hash values.
5724 (sxhash_float): New function.
5725 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5726 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5727 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5728 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5729 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5730 Adjust signatures to match updated version of code.
5731 (consing_since_gc): Now EMACS_INT, since a single hash table can
5732 use more than INT_MAX bytes.
5733
698d32e2
DN
57342011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5735
5736 Make it possible to build with GCC-4.6+ -O2 -flto.
5737
5738 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5739
fd6fa53f
SM
57402011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5741
5742 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5743 Call minibuffer-inactive-mode.
5744
864db017
JB
57452011-05-31 Juanma Barranquero <lekktu@gmail.com>
5746
5747 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5748 Update dependencies.
5749
2ad0baf4
DN
57502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5751
5752 * data.c (init_data): Remove code for UTS, this system is not
5753 supported anymore.
5754
4fcc2638
DN
57552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5756
5757 Don't force ./temacs to start in terminal mode.
5758
5759 * frame.c (make_initial_frame): Initialize faces in all cases, not
5760 only when CANNOT_DUMP is defined.
5761 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5762
c56e0fd5
DN
57632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5764
5765 * dispnew.c (add_window_display_history): Use const for the string
5766 pointer. Remove declaration, not needed.
5767
333d54da 57682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5769
55d4c1b2 5770 Use 'inline', not 'INLINE'.
333d54da 5771 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5772 * alloc.c, fontset.c (INLINE): Remove.
5773 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5774 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5775 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5776 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5777 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5778
738db178
DN
57792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5780
5781 Make it possible to run ./temacs.
5782
5783 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5784 syms_of_callproc does the same thing. Remove test for
5785 "initialized", do it in the caller.
5786 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5787
620c53a6
SM
57882011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5789
5790 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5791 (read_minibuf): Use get_minibuffer.
5792 (syms_of_minibuf): Use DEFSYM.
5793 (Qmetadata): New var.
5794 * data.c (Qbuffer): Don't make it static.
5795 (syms_of_data): Use DEFSYM.
5796
e003a292
PE
57972011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5798
5799 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5800 (CCL_CODE_MIN): New macro.
5801
ed008a6d
PE
58022011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5803
3687c2ef
PE
5804 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5805
ed008a6d
PE
5806 * eval.c (Qdebug): Now static.
5807 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5808 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5809 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5810
d66c4c7c
CY
58112011-05-29 Chong Yidong <cyd@stupidchicken.com>
5812
5813 * image.c: Various fixes to ImageMagick code comments.
5814 (Fimagemagick_types): Doc fix.
5815
5fbc2025
PE
58162011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5817
0196f88a
PE
5818 Minor fixes prompted by GCC 4.6.0 warnings.
5819
5820 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5821
5fbc2025
PE
5822 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5823 (x_clipboard_manager_save_all): Move extern decl to ...
5824 * xterm.h: ... here, so that it can be checked for consistency.
5825
1dd3c2d9
CY
58262011-05-29 Chong Yidong <cyd@stupidchicken.com>
5827
5828 * xselect.c (x_clipboard_manager_save_frame)
5829 (x_clipboard_manager_save_all): New functions.
5830 (Fx_clipboard_manager_save): Lisp function deleted.
5831
5832 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5833 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5834
5835 * xterm.h: Update prototype.
5836
5ba6571d
WX
58372011-05-28 William Xu <william.xwl@gmail.com>
5838
5839 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5840 exiting (Bug#8239).
5841
3eaff834
JM
58422011-05-28 Jim Meyering <meyering@redhat.com>
5843
e1900994 5844 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5845 * fns.c (to_uchar): Define.
5846 (crypto_hash_function): Use it to convert some newly-signed
5847 variables to unsigned, to avoid sign-extension bugs. For example,
5848 without this change, (md5 "truc") would evaluate to
5849 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5850 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5851 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5852
0f6990a7
PE
58532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5854
5855 Integer overflow fixes.
c8a9ca5a 5856
08686060
PE
5857 * dbusbind.c: Serial number integer overflow fixes.
5858 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5859 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5860 to hold a serial number that is too large for a fixnum.
5861 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5862 Check for serial numbers out of range. Decode any serial number
59568bf0 5863 that was so large that it became a float. (Bug#8722)
08686060 5864
2d1fc3c7
PE
5865 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5866 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5867 Use XFASTINT rather than XUINT when numbers are nonnegative.
5868 (xd_append_arg, Fdbus_method_return_internal):
5869 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5870 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5871 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5872 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5873 (Bug#8722)
2d1fc3c7 5874
c8a9ca5a
PE
5875 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5876
519e1d69
PE
5877 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5878
6df6ae42 5879 ccl: Add integer overflow checks.
30569699
PE
5880 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5881 (IN_INT_RANGE): New macros.
5882 (ccl_driver): Use them to check for integer overflow when
5883 decoding a CCL program. Many of the new checks are whether XINT (x)
5884 fits in int; it doesn't always, on 64-bit hosts. The new version
5885 doesn't catch all possible integer overflows, but it's an
847044ea 5886 improvement. (Bug#8719)
30569699 5887
c11285dc
PE
5888 * alloc.c (make_event_array): Use XINT, not XUINT.
5889 There's no need for unsigned here.
5890
fdccd48e
PE
5891 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5892 This follows up to the 2011-05-06 change that substituted uintptr_t
5893 for EMACS_INT. This case wasn't caught back then.
5894
37910ab2
PE
5895 Rework Fformat to avoid integer overflow issues.
5896 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5897 now (part of C89). Include <verify.h>.
5898 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5899 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5900 (Fformat): Avoid the prepass trying to compute sizes; it was only
5901 approximate and thus did not catch overflow reliably. Instead, walk
5902 through the format just once, formatting and computing sizes as we go,
5903 checking for integer overflow at every step, and allocating a larger
5904 buffer as needed. Keep track separately whether the format is
5905 multibyte. Keep only the most-recently calculated precision, rather
5906 than them all. Record whether each argument has been converted to
5907 string. Use EMACS_INT, not int, for byte and char and arg counts.
5908 Support field widths and precisions larger than INT_MAX. Avoid
5909 sprintf's undefined behavior with conversion specifications such as %#d
5910 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5911 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5912 formatting out-of-range floating point numbers with int
9173deec 5913 formats. (Bug#8668)
37910ab2 5914
2e6578fb
PE
5915 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5916
0ae6bdee
PE
5917 * data.c: Avoid integer truncation in expressions involving floats.
5918 * data.c: Include <intprops.h>.
5919 (arith_driver): When there's an integer overflow in an expression
5920 involving floating point, convert the integers to floating point
5921 so that the resulting value does not suffer from catastrophic
5922 integer truncation. For example, on a 64-bit host (* 4
5923 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5924 Do not rely on undefined behavior after integer overflow.
5925
de883a70
PE
5926 merge count_size_as_multibyte, parse_str_to_multibyte
5927 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5928 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5929 Check for integer overflow.
5930 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5931 since it's now a duplicate of the other. This is more of
5932 a character than a buffer op, so better that it's in character.c.
5933 * fns.c, print.c: Adjust to above changes.
5934
2ff916cb
PE
59352011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5936
5937 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5938
f1b54466
PE
59392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5940
fb1ac845
PE
5941 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5942 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5943 (x_clipboard_manager_save): Now static.
5944 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5945
f1b54466
PE
5946 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5947 (crypto_hash_function): Now static.
5948 Fix pointer signedness problems. Avoid unnecessary initializations.
5949
a9f737ee
CY
59502011-05-27 Chong Yidong <cyd@stupidchicken.com>
5951
5952 * termhooks.h (Vselection_alist): Make it terminal-local.
5953
5954 * terminal.c (create_terminal): Initialize it.
5955
5956 * xselect.c: Support for clipboard managers.
5957 (Vselection_alist): Move to termhooks.h as terminal-local var.
5958 (LOCAL_SELECTION): New macro.
5959 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5960 (symbol_to_x_atom): Remove gratuitous arg.
5961 (x_handle_selection_request, lisp_data_to_selection_data)
5962 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5963 (x_own_selection, x_get_local_selection, x_convert_selection):
5964 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5965 (some_frame_on_display): Delete unused function.
5966 (Fx_own_selection_internal, Fx_get_selection_internal)
5967 (Fx_disown_selection_internal, Fx_selection_owner_p)
5968 (Fx_selection_exists_p): New optional frame arg.
5969 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5970 (x_handle_selection_clear): Don't treat other terminals with the
5971 same keyboard specially. Use the terminal-local Vselection_alist.
5972 (x_clear_frame_selections): Use Frun_hook_with_args.
5973
5974 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5975
5976 * xterm.h: Add support for those atoms.
5977
e067f0c1
CY
59782011-05-26 Chong Yidong <cyd@stupidchicken.com>
5979
5980 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5981 (converted_selections, conversion_fail_tag): New global variables.
5982 (x_selection_request_lisp_error): Free the above.
5983 (x_get_local_selection): Remove unnecessary code.
5984 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5985 of converted selections stored in converted_selections.
5986 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5987 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5988 (x_convert_selection): New function.
5989 (x_handle_selection_event): Simplify.
5990 (x_get_foreign_selection): Don't ignore incoming requests while
5991 waiting for an answer; this will fail when we implement
5992 SAVE_TARGETS, and seems unnecessary anyway.
5993 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5994 (Vx_sent_selection_functions): Doc fix.
5995
0f4aebc0
LL
59962011-05-26 Leo Liu <sdl.web@gmail.com>
5997
5998 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5999
e61124cd
YM
60002011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6001
6002 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6003
6004 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6005 for fringe update if it has periodic bitmap.
ac389d0c 6006 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6007 and fringe_bitmap_periodic_p.
6008
6009 * fringe.c (get_fringe_bitmap_data): New function.
6010 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6011 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6012 row. Mark glyph row for fringe update if periodicity changed.
6013
6014 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6015 for fringe update unless it has periodic bitmap.
6016
f16d9837
KH
60172011-05-25 Kenichi Handa <handa@m17n.org>
6018
6019 * xdisp.c (get_next_display_element): Set correct it->face_id for
6020 a static composition.
6021
e1b90ef6
LL
60222011-05-24 Leo Liu <sdl.web@gmail.com>
6023
6024 * deps.mk (fns.o):
6025 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6026
6027 * fns.c (crypto_hash_function, Fsha1): New function.
6028 (Fmd5): Use crypto_hash_function.
6029 (syms_of_fns): Add Ssha1.
6030
7400048f
PE
60312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6032
6033 * gnutls.c: Remove unused macros.
6034 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6035 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6036 Remove macros that are defined and never used.
6037 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6038
abb71cf4
CY
60392011-05-22 Chong Yidong <cyd@stupidchicken.com>
6040
6041 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6042 (Fx_get_selection_internal): Minor cleanup.
6043 (Fx_own_selection_internal): Rename arguments for consistency with
6044 select.el.
6045
6307db39
PE
60462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6047
6048 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6049
f3d4e0a4
CY
60502011-05-22 Chong Yidong <cyd@stupidchicken.com>
6051
6052 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6053
4d8ade89
YM
60542011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6055
6056 * dispnew.c (scrolling_window): Don't exclude the case that the
6057 last enabled row in the desired matrix touches the bottom boundary.
6058
32078c8d
GM
60592011-05-21 Glenn Morris <rgm@gnu.org>
6060
6061 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6062 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6063 and add some more files.
32078c8d 6064
7285dc67
EZ
60652011-05-20 Eli Zaretskii <eliz@gnu.org>
6066
6067 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6068 report_file_error introduced by the change from 2011-05-07.
6069
89d1bd22
PE
60702011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6071
6072 * systime.h (Time): Define only if emacs is defined.
6073 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6074 where the include path doesn't have X11/X.h by default. See
6075 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6076
cd394be1 60772011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6078
6079 * composite.c (find_automatic_composition): Fix previous change.
6080
b9704ad9
GM
60812011-05-20 Glenn Morris <rgm@gnu.org>
6082
6083 * lisp.mk: New file, split from Makefile.in.
6084 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6085 (shortlisp): Remove.
6086 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6087
4a720484
GM
60882011-05-19 Glenn Morris <rgm@gnu.org>
6089
6090 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6091 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6092 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6093 (lisp): Set the order to that of loadup.el.
6094 (shortlisp): Make it a copy of $lisp.
6095 (SOME_MACHINE_LISP): Remove.
6096 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6097 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6098
a28d4396
KH
60992011-05-18 Kenichi Handa <handa@m17n.org>
6100
6101 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6102 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6103 (find_automatic_composition): Mostly rewrite for efficiency.
6104
a2b1fa8e
JB
61052011-05-18 Juanma Barranquero <lekktu@gmail.com>
6106
6107 * makefile.w32-in: Update dependencies.
6108
8e1f5610
CS
61092011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6110
6111 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6112 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6113
7025ee00 61142011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6115
cdfa6eab
PE
6116 Fix some integer overflow issues, such as string length overflow.
6117
06d6db33
PE
6118 * insdel.c (count_size_as_multibyte): Check for string overflow.
6119
2b4560a8
PE
6120 * character.c (lisp_string_width): Check for string overflow.
6121 Use EMACS_INT, not int, for string indexes and lengths; in
6122 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6123 the resulting string length overflows an EMACS_INT; instead,
6124 report a string overflow if no precision given. When checking for
6125 precision exhaustion, use a check that cannot possibly have
6126 integer overflow. (Bug#8675)
6127 * character.h (lisp_string_width): Adjust to new signature.
6128
cb93f9be
PE
6129 * alloc.c (string_overflow): New function.
6130 (Fmake_string): Use it. This doesn't change behavior, but saves
6131 a few bytes and will simplify future changes.
6132 * character.c (string_escape_byte8): Likewise.
6133 * lisp.h (string_overflow): New decl.
6134
1a1f3366
PE
6135 Fixups, following up to the user-interface timestamp change.
6136 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6137 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6138 * msdos.c (mouse_get_pos): Likewise.
6139 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6140 * w32gui.h (Time): Define by including "systime.h" rather than by
6141 declaring it ourselves. (Bug#8664)
6142
d4e3e4d3
PE
6143 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6144 * image.c (clear_image_cache): Likewise.
6145
f6a24d19
PE
6146 * term.c (term_mouse_position): Don't assume time_t wraparound.
6147
08dc5ae6
PE
6148 Be more systematic about user-interface timestamps.
6149 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6150 and sometimes 'EMACS_UINT', to represent these timestamps.
6151 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6152 This makes the code easier to follow, and makes it easier to catch
6153 integer overflow bugs such as Bug#8664.
6154 * frame.c (Fmouse_position, Fmouse_pixel_position):
6155 Use Time, not unsigned long, for user-interface timestamps.
6156 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6157 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6158 * keyboard.h (last_event_timestamp): Likewise.
6159 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6160 * menu.h (xmenu_show): Likewise.
6161 * term.c (term_mouse_position): Likewise.
6162 * termhooks.h (struct input_event.timestamp): Likewise.
6163 (struct terminal.mouse_position_hook): Likewise.
6164 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6165 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6166 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6167 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6168 what it was before.
6169 * menu.h, termhooks.h: Include "systime.h", for Time.
6170
8e55734a
PE
6171 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6172 Don't assume that the difference between two unsigned long values
6173 can fit into an integer. At this point, we know button_down_time
6174 <= event->timestamp, so the difference must be nonnegative, so
6175 there's no need to cast the result if double-click-time is
6176 nonnegative, as it should be; check that it's nonnegative, just in
6177 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6178 apart (about 25 days). (Bug#8664)
8e55734a 6179
841f1b75 6180 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6181 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6182
3e26f69c
PE
6183 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6184 that always fit in int. Use a sentinel instead of a counter, to
6185 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6186 * frame.h (struct frame): Use int for menu_bar_items_used
6187 instead of EMACS_INT, since it always fits in int.
3e26f69c 6188
5cc152c0
PE
6189 * menu.c (grow_menu_items): Check for int overflow.
6190
d89eb65e
PE
6191 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6192
5235bd3e
PE
6193 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6194 Before, the code was not consistent. These values cannot exceed
6195 2**31 - 1 so there's no need to make them unsigned.
6196 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6197 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6198 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6199 as modifiers.
6200 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6201
bc827e23
PE
6202 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6203 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6204 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6205 presumably because the widths might not match.
6206
78eb494e
PE
6207 * window.c (size_window): Avoid needless test at loop start.
6208
04f2d78b
CB
62092011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6210
6211 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6212
d2fc7e3d 62132011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6214
6215 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6216
d2fc7e3d 62172011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6218
6219 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6220 `width' to `bar_area_x' and `bar_area_width', respectively.
6221 (x_scroll_run): Take account of fringe background extension.
6222
04f2d78b
CB
6223 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6224 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6225 `bar_area_width', respectively.
6226 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6227 background extension.
6228
79b70037
GM
62292011-05-10 Jim Meyering <meyering@redhat.com>
6230
6231 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6232
2f142cc5
JB
62332011-05-10 Juanma Barranquero <lekktu@gmail.com>
6234
6235 * image.c (Finit_image_library): Return t for built-in image types,
6236 like pbm and xbm. (Bug#8640)
6237
57679c86
AS
62382011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6239
6240 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6241
888c9e86
EZ
62422011-05-07 Eli Zaretskii <eliz@gnu.org>
6243
b0512a1d
EZ
6244 * w32console.c (Fset_screen_color): Doc fix.
6245 (Fget_screen_color): New function.
6246 (syms_of_ntterm): Defsubr it.
6247
7285dc67
EZ
6248 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6249 unlink the temporary file if Fcall_process didn't create it in the
6250 first place.
6251 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6252 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6253 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6254 cue to call_process_cleanup not to close that handle.
6255
4d3fcc8e
BK
62562011-05-07 Ben Key <bkey76@gmail.com>
6257
6258 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6259 one of two shell specific rules, either bootstrap-temacs-CMD or
6260 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6261 to the previous implementation of the bootstrap-temacs rule.
6262 The bootstrap-temacs-CMD rule is similar to the previous
6263 implementation of the bootstrap-temacs rule except that it
6264 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6265 variable.
6266
6267 These changes, along with some changes to nt/configure.bat,
6268 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6269 earlier fix to add support for --cflags and --ldflags options
6270 that include quotes so that it works whether make uses cmd or
6271 sh as the shell.
6272
b4289b64
MA
62732011-05-06 Michael Albinus <michael.albinus@gmx.de>
6274
6275 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6276 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6277 is a constant.
6278 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6279 a string. Handle both cases.
6280 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6281 (Fdbus_register_method): Use Qinvalid_function.
6282
af4c0e28
JB
62832011-05-06 Juanma Barranquero <lekktu@gmail.com>
6284
6285 * makefile.w32-in: Update dependencies.
6286 (LISP_H): Add inttypes.h and stdin.h.
6287 (PROCESS_H): Add unistd.h.
6288
c51453d9
EZ
62892011-05-06 Eli Zaretskii <eliz@gnu.org>
6290
6291 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6292 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6293
8ff0ac3c 62942011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6295
4c4b566b
PE
6296 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6297
aab2b9b5
PE
6298 * term.c (vfatal): Remove stray call to va_end.
6299 It's not needed and the C Standard doesn't allow it here anyway.
6300
c378da0b
PE
6301 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6302 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6303
288b08c7
PE
6304 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6305 bytes.
6306
e3601888
PE
6307 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6308
db6c0e74
PE
6309 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6310
dd5963ea
PE
6311 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6312
88c9450f
PE
6313 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6314
2f9442b8
PE
6315 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6316
c032b5f8
PE
6317 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6318 * charset.c (Fdefine_charset_internal): Don't initialize
6319 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6320 32-bit int (Bug#8600).
a108c10b
PE
6321
6322 * lread.c (read_integer): Be more consistent with string-to-number.
6323 Use string_to_number to do the actual conversion; this avoids
6324 rounding errors and fixes some other screwups. Without this fix,
6325 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6326 (digit_to_number): Move earlier, for benefit of read_integer.
6327 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6328 not a digit in any supported base. (Bug#8602)
a108c10b 6329
ad5f9eea
PE
6330 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6331
aec1708a
PE
6332 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6333 to match comment at start of function. This also removes a
6334 GCC warning about overflow in a 32+64-bit port.
6335
47be4ab5
PE
6336 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6337
371cac43
PE
6338 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6339 Reported by Stefan Monnier in
6340 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6341 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6342 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6343
d01a7826
PE
6344 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6345 (EMACS_UINTPTR): Likewise, with uintptr_t.
6346
7fd47d5c
PE
6347 * lisp.h: Prefer 64-bit EMACS_INT if available.
6348 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6349 on 32-bit hosts that have 64-bit int, so that they can access
6350 large files.
122b0c86
PE
6351 However, temporarily disable this change unless the temporary
6352 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6353
8727937b
PE
6354 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6355
8ac068ac
PE
6356 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6357 This removes an assumption that EMACS_INT and long are the same
6358 width as pointers. The assumption is true for Emacs porting targets
6359 now, but we want to make other targets possible.
6360 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6361 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6362 In the rest of the code, change types of integers that hold casted
6363 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6364 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6365 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6366 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6367 No need to cast type when ORing.
6368 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6369 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6370 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6371 assume EMACS_INT is the same width as char *.
6372 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6373 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6374 Remove no-longer-needed casts.
6375 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6376 (xg_tool_bar_help_callback, xg_make_tool_item):
6377 Use EMACS_INTPTR to hold an integer
6378 that will be cast to void *; this can avoid a GCC warning
6379 if EMACS_INT is not the same width as void *.
6380 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6381 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6382 (current_message_1, set_message_1):
6383 Use a local to convert to proper width without a cast.
6384 * xmenu.c (dialog_selection_callback): Likewise.
6385
ede49d71
PE
6386 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6387 Also, don't assume VALBITS / RAND_BITS is less than 5,
6388 and don't rely on undefined behavior when shifting a 1 left into
6389 the sign bit.
6390 * lisp.h (get_random): Change signature to match.
6391
2f30ecd0
PE
6392 * lread.c (hash_string): Use size_t, not int, for hash computation.
6393 Normally we prefer signed values; but hashing is special, because
6394 it's better to use unsigned division on hash table sizes so that
6395 the remainder is nonnegative. Also, size_t is the natural width
6396 for hashing into memory. The previous code used 'int', which doesn't
6397 retain enough info to hash well into very large tables.
6398 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6399
2a866e7b
PE
6400 * dbusbind.c: Don't possibly lose pointer info when converting.
6401 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6402 Use XPNTR rather than XHASH, so that the high-order bits of
6403 the pointer aren't lost when converting through void *.
6404
51639eac
PE
6405 * eval.c (Fautoload): Don't double-shift a pointer.
6406
92394119
PE
6407 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6408
dbdb9a7c
JB
64092011-05-06 Juanma Barranquero <lekktu@gmail.com>
6410
6411 * gnutls.c (DEF_GNUTLS_FN):
6412 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6413
db7a0b4f
AS
64142011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6415
6416 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6417 marker. (Bug#8610)
6418
cd394be1 64192011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6420
6421 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6422 New version that can reserve upto 2GB of heap space.
6423
f7ff1b0f 64242011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6425
6426 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6427
639c109b
TZ
64282011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6429
6430 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6431 `gnutls_certificate_set_x509_key_file'.
6432
d2127135
JB
64332011-05-05 Juanma Barranquero <lekktu@gmail.com>
6434
6435 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6436 Update dependencies.
6437
e968f4f3
JB
64382011-05-04 Juanma Barranquero <lekktu@gmail.com>
6439
6440 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6441 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6442 Remove unused parameter `fildes'.
6443 * process.c (read_process_output, send_process): Don't pass it.
6444
84d358f0
JB
64452011-05-04 Juanma Barranquero <lekktu@gmail.com>
6446
6447 Fix previous change: the library cache is defined in w32.c.
6448 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6449 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6450
0898ca10
JB
64512011-05-04 Juanma Barranquero <lekktu@gmail.com>
6452
6453 Implement dynamic loading of GnuTLS on Windows.
6454
6455 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6456 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6457 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6458 Declare.
6459
6460 * gnutls.c (Qgnutls_dll): Define.
6461 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6462 (gnutls_*): Declare function pointers.
6463 (init_gnutls_functions): New function to initialize function pointers.
6464 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6465 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6466 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6467 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6468 (emacs_gnutls_write, emacs_gnutls_read)
6469 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6470 (Fgnutls_available_p): New function.
6471 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6472 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6473 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6474
6475 * image.c: Include w32.h.
6476 (Vimage_type_cache): Delete.
6477 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6478 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6479 (w32_delayed_load): Move to w32.c.
6480
6481 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6482
6483 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6484 (w32_delayed_load): Move from image.c. When loading a library, record
6485 its filename in the :loaded-from property of the library id.
6486 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6487 Initialize and staticpro them.
6488 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6489
6490 * process.c: Include lisp.h before w32.h, not after.
6491 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6492 instead of gnutls_record_check_pending.
6493
6494 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6495
ff4de4aa
TZ
64962011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6497
6498 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6499 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6500 as passed in.
6501
abe95abb
JD
65022011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6503
6504 * xterm.c (x_set_frame_alpha): Do not set property on anything
6505 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6506
e16e55d4
JB
65072011-05-02 Juanma Barranquero <lekktu@gmail.com>
6508
6509 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6510
bafcf6a5
JB
65112011-05-02 Juanma Barranquero <lekktu@gmail.com>
6512
6513 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6514 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6515 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6516 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6517 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6518 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6519 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6520 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6521 (Qgnutls_bootprop_callbacks_verify): Make static.
6522
e7a6747f
AS
65232011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6524
19ed11ba
AS
6525 * callproc.c: Indentation fixup.
6526
e7a6747f 6527 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6528 (wait_for_termination, interruptible_wait_for_termination):
6529 Move after wait_for_termination_1.
e7a6747f 6530
1ef14cb4
LMI
65312011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6532
6533 * sysdep.c (interruptible_wait_for_termination): New function
6534 which is like wait_for_termination, but allows keyboard
6535 interruptions.
6536
6537 * callproc.c (Fcall_process): Add (:file "file") as an option for
6538 the STDOUT buffer.
6539 (Fcall_process_region): Ditto.
6540
330d880c
EZ
65412011-04-30 Eli Zaretskii <eliz@gnu.org>
6542
8db90b73
EZ
6543 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6544 rather than `XVECTOR (FOO)->size'.
6545
330d880c
EZ
6546 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6547 inttypes.h, as a gnulib replacement is used if it not available in
6548 system headers.
6549
15cbd324
EZ
65502011-04-21 Eli Zaretskii <eliz@gnu.org>
6551
6552 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6553 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6554 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6555
6556 * coding.c (coding_alloc_by_realloc): Error out if destination
6557 will grow beyond MOST_POSITIVE_FIXNUM.
6558 (decode_coding_emacs_mule): Abort if there isn't enough place in
6559 charbuf for the composition carryover bytes. Reserve an extra
6560 space for up to 2 characters produced in a loop.
6561 (decode_coding_iso_2022): Abort if there isn't enough place in
6562 charbuf for the composition carryover bytes.
6563
65642011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6565
ae940cca
EZ
6566 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6567 aborting when %lld or %lll format is passed.
6568 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6569 %llo or %llx format is passed. (Bug#8545)
6570
03ab8921
EZ
6571 * window.c (window_scroll_line_based): Use a marker instead of
6572 simple variables to record original value of point. (Bug#7952)
6573
afda1437
EZ
6574 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6575 produced by %s or %c overflows available buffer space. (Bug#8545)
6576
f76dee0c
PE
65772011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6578
6579 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6580 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6581
fdc5744d
JB
65822011-04-28 Juanma Barranquero <lekktu@gmail.com>
6583
6584 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6585
638f053a
JB
65862011-04-28 Juanma Barranquero <lekktu@gmail.com>
6587
6588 * keyboard.c (Qdelayed_warnings_hook): Define.
6589 (command_loop_1): Run `delayed-warnings-hook'
6590 if Vdelayed_warnings_list is non-nil.
6591 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6592 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6593
d178f871
EZ
65942011-04-28 Eli Zaretskii <eliz@gnu.org>
6595
6596 * doprnt.c (doprnt): Don't return value smaller than the buffer
6597 size if the message was truncated. (Bug#8545).
6598
b124fd93
JB
65992011-04-28 Juanma Barranquero <lekktu@gmail.com>
6600
6601 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6602 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6603
e810457d
PE
66042011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6605
6606 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6607
ea51cceb
JB
66082011-04-27 Juanma Barranquero <lekktu@gmail.com>
6609
6610 * makefile.w32-in: Update dependencies.
6611
94dcfacf
EZ
66122011-04-27 Eli Zaretskii <eliz@gnu.org>
6613
6614 Improve `doprnt' and its usage. (Bug#8545)
6615 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6616 `format_end'. Remove support for %l as a conversion specifier.
6617 Don't use xrealloc. Improve diagnostics when the %l size modifier
6618 is used. Update the commentary.
6619
6620 * eval.c (verror): Simplify calculation of size_t.
6621
6622 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6623 messages.
6624
f61f41d7
PE
66252011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6626
6627 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6628 change.
6629
96fb4434
PE
66302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6631
6632 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6633 This makes this file independent of the recent pseudovector change.
6634
671875da 66352011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6636
69e9b5a3
PE
6637 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6638
b5f869a7 6639 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6640 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6641 Remove unused local.
c8926152 6642 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6643
841a1577 6644 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6645 GCC 4.6.0 optimizes based on type-based alias analysis.
6646 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6647 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6648 != &v->size, and therefore "v->size = 1; b->size = 2; return
6649 v->size;" must therefore return 1. This assumption is incorrect
6650 for Emacs, since it type-puns struct Lisp_Vector * with many other
6651 types. To fix this problem, this patch adds a new type struct
f904488f 6652 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6653 and pseudovectors, and helps optimizing compilers not get fooled
6654 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6655 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6656 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6657 the size member.
eab3844f
PE
6658 (XSETPVECTYPE): Rewrite in terms of new macro.
6659 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6660 This is a bit clearer, and further avoids the possibility of
6661 undesirable aliasing.
6662 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6663 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6664 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6665 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6666 (ASIZE): Now uses header.size rather than size.
6667 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6668 to avoid the hassle of writing XVECTOR (foo)->header.size.
6669 (struct vectorlike_header): New type.
eab3844f
PE
6670 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6671 object, to help avoid aliasing.
6672 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6673 (SUBRP): Likewise, since Lisp_Subr is a special case.
6674 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6675 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6676 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6677 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6678 changed to be "header.size" and "header.next".
6679 * buffer.h (struct buffer): Likewise.
6680 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6681 * frame.h (struct frame): Likewise.
6682 * process.h (struct Lisp_Process): Likewise.
6683 * termhooks.h (struct terminal): Likewise.
6684 * window.c (struct save_window_data, struct saved_window): Likewise.
6685 * window.h (struct window): Likewise.
6686 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6687 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6688 * buffer.c (init_buffer_once): Likewise.
6689 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6690 special case.
6691 * process.c (Fformat_network_address): Use local var for size,
6692 for brevity.
6693
0df1eac5
PE
6694 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6695
847ab9d1 6696 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6697 * data.c (atof): Remove decl; no longer used or needed.
6698 (digit_to_number): Move to lread.c.
6699 (Fstring_to_number): Use new string_to_number function, to be
6700 consistent with how the Lisp reader treats infinities and NaNs.
6701 Do not assume that floating-point numbers represent EMACS_INT
6702 without losing information; this is not true on most 64-bit hosts.
6703 Avoid double-rounding errors, by insisting on integers when
6704 parsing non-base-10 numbers, as the documentation specifies.
6705 * lisp.h (string_to_number): New decl, replacing ...
6706 (isfloat_string): Remove.
bc0a5c13 6707 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6708 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6709 appears to have been a coding error. Similarly, do not accept
6710 strings like +-1e0 as floating point numbers. Do not report
6711 overflow for integer overflows unless the base is not 10 which
6712 means we have no simple and reliable way to continue.
6713 Break out the floating-point parsing into a new
6714 function string_to_number, so that Fstring_to_number parses
6715 floating point numbers consistently with the Lisp reader.
04f2d78b 6716 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6717 (E_CHAR, EXP_INT): Remove, replacing with ...
6718 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6719 (string_to_number): New function, replacing isfloat_string.
6720 This function checks for valid syntax and produces the resulting
6721 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6722 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6723 so that overflow for non-base-10 numbers is reported only when
6724 there's no portable and simple way to convert to floating point.
452f4150 6725
67769ffc
PE
6726 * textprop.c (set_text_properties_1): Rewrite for clarity,
6727 and to avoid GCC warning about integer overflow.
6728
c20db43f
PE
6729 * intervals.h (struct interval): Use EMACS_INT for members
6730 where EMACS_UINT might cause problems. See
6731 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6732 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6733 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6734 All uses changed.
37aa2f85
PE
6735 (offset_intervals): Tell GCC not to worry about length overflow
6736 when negating a negative length.
c20db43f 6737
2538aa2f
PE
6738 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6739 (overrun_check_free): Likewise.
6740
f2d3008d
PE
6741 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6742 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6743 word size.
6744
ec8df744
PE
6745 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6746 (gnutls_make_error): Rename local to avoid shadowing.
6747 (gnutls_emacs_global_deinit): ifdef out; not used.
6748 (Fgnutls_boot): Use const for pointer to readonly storage.
6749 Comment out unused local. Fix pointer signedness problems.
6750
640ee02d
PE
6751 * lread.c (openp): Don't stuff size_t into an 'int'.
6752 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6753 about possible signed overflow.
6754
6048fb2a
PE
6755 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6756 (GDK_KEY_g): Don't define if already defined.
6757 (xg_prepare_tooltip): Avoid pointer signedness problem.
6758 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6759
fa3c87e1
PE
6760 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6761 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6762
2172544b
PE
6763 * xfns.c (Fx_window_property): Simplify a bit,
6764 to make a bit faster and to avoid GCC 4.6.0 warning.
6765 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6766
9b821a21
PE
6767 * fns.c (internal_equal): Don't assume size_t fits in int.
6768
3c616cfa
PE
6769 * alloc.c (compact_small_strings): Tighten assertion a little.
6770
c2982e87
PE
6771 Replace pEd with more-general pI, and fix some printf arg casts.
6772 * lisp.h (pI): New macro, generalizing old pEd macro to other
6773 conversion specifiers. For example, use "...%"pI"d..." rather
6774 than "...%"pEd"...".
6775 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 6776 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
6777 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6778 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6779 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6780 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6781 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6782 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6783 64-bit hosts.
6784 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6785 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6786 * print.c (safe_debug_print, print_object): Likewise.
6787 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6788 to int.
6f04d126
PE
6789 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6790 avoiding the 0 flag, which is not portable.
c2982e87
PE
6791 * process.c (Fmake_network_process): Use pI to avoid cast.
6792 * region-cache.c (pp_cache): Likewise.
6793 * xdisp.c (decode_mode_spec): Likewise.
6794 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6795 behavior on 64-bit hosts with printf arg.
6f04d126 6796 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6797 (x_stop_queuing_selection_requests): Likewise.
6798 (x_get_window_property): Don't truncate byte count to an 'int'
6799 when tracing.
0b432f21 6800
5e073ec7
PE
6801 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6802 here, since it parses constructs like leading '-' and spaces,
6803 which are not wanted; and it overflows with large numbers.
6804 Instead, simply match F[0-9]+, which is what is wanted anyway.
6805
36372bf9
PE
6806 * alloc.c: Remove unportable assumptions about struct layout.
6807 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6808 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6809 (allocate_vectorlike, make_pure_vector): Use the new macros,
6810 plus offsetof, to remove unportable assumptions about struct layout.
6811 These assumptions hold on all porting targets that I know of, but
6812 they are not guaranteed, they're easy to remove, and removing them
6813 makes further changes easier.
6814
0b432f21
PE
6815 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6816 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6817 (string_overrun_cookie): Now const. Use initializers that
6818 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6819 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6820 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6821 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6822 multiple of sizeof (EMACS_INT); it need not be, if
6823 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6824 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6825
895009e1
JB
68262011-04-26 Juanma Barranquero <lekktu@gmail.com>
6827
6828 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6829
6a7a1b0b
TZ
68302011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6831
6832 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6833 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6834 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6835
841a1577 68362011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6837
6838 * lisp.h (Qdebug): List symbol.
895009e1 6839 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6840 * keyboard.c (debug-on-event): New variable.
6841 (handle_user_signal): Break into debugger when debug-on-event
6842 matches the current signal symbol.
6843
f2d3ba6f
DN
68442011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6845
6846 * alloc.c (check_sblock, check_string_bytes)
6847 (check_string_free_list): Convert to standard C.
6848
42ce4c63
TZ
68492011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6850
6851 * w32.c (emacs_gnutls_push): Fix typo.
6852
825cd63c
EZ
68532011-04-25 Eli Zaretskii <eliz@gnu.org>
6854
fb11d64d
EZ
6855 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6856 "cast to pointer from integer of different size".
6857
825cd63c
EZ
6858 Improve doprnt and its use in verror. (Bug#8545)
6859 * doprnt.c (doprnt): Document the set of format control sequences
6860 supported by the function. Use SAFE_ALLOCA instead of always
6861 using `alloca'.
6862
6863 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6864 is one byte too soon. Don't use xrealloc; instead xfree and
6865 xmalloc anew.
6866
e061a11b
TZ
68672011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6868
6869 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6870 callbacks stage.
6871
6872 * gnutls.c: Renamed global_initialized to
6873 gnutls_global_initialized. Added internals for the
6874 :verify-hostname-error, :verify-error, and :verify-flags
6875 parameters of `gnutls-boot' and documented those parameters in the
6876 docstring. Start callback support.
9173deec
JB
6877 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6878 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6879 on error. Return error code.
e061a11b
TZ
6880 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6881 (emacs_gnutls_read): Likewise.
6882 (Fgnutls_boot): Return handshake error code.
6883 (emacs_gnutls_handle_error): New function.
6884 (wsaerror_to_errno): Likewise.
6885
6886 * w32.h (emacs_gnutls_pull): Add prototype.
6887 (emacs_gnutls_push): Likewise.
6888
6889 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6890 (emacs_gnutls_push): Likewise.
6891
68922011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6893
6894 * process.c (wait_reading_process_output): Check if GnuTLS
6895 buffered some data internally if no FDs are set for TLS
6896 connections.
6897
6898 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6899 (LIBS): Link to USER_LIBS.
6900 ($(BLD)/gnutls.$(0)): New target.
6901
fa6996bc
EZ
69022011-04-24 Eli Zaretskii <eliz@gnu.org>
6903
eb35682e
EZ
6904 * xdisp.c (handle_single_display_spec): Rename the
6905 display_replaced_before_p argument into display_replaced_p, to
6906 make it consistent with the commentary. Fix typos in the
6907 commentary.
6908
e2ad650c
EZ
6909 * textprop.c (syms_of_textprop): Remove dead code.
6910 (copy_text_properties): Delete obsolete commentary about an
6911 interface that was deleted long ago. Fix typos in the description
6912 of arguments.
6913
1b2de274
EZ
6914 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6915 to changes in oldXMenu/XMenu.h from 2011-04-16.
6916 <menu_help_message, prev_menu_help_message>: Constify.
6917 (IT_menu_make_room): menu->help_text is now `const char **';
6918 adjust.
6919
6920 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6921 to changes in oldXMenu/XMenu.h from 2011-04-16.
6922 (struct XMenu): Declare `help_text' `const char **'.
6923
6924 * xfaces.c <Qunspecified>: Make extern again.
6925
6926 * syntax.c: Include sys/types.h before including regex.h, as
6927 required by Posix.
6928
762b15be
EZ
6929 * doc.c (get_doc_string): Improve the format passed to `error'.
6930
6931 * doprnt.c (doprnt): Improve commentary.
6932
6933 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6934
6935 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6936 them with etags.
6937
f1052e5d
EZ
6938 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6939 changes in globals.h immediately force recompilation.
762b15be
EZ
6940 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6941 $(CURDIR)/s/ms-w32.h.
6942 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6943
fa6996bc
EZ
6944 * character.c (Fchar_direction): Function deleted.
6945 (syms_of_character): Don't defsubr it.
6946 <char-direction-table>: Deleted.
6947
e6c3da20
EZ
69482011-04-23 Eli Zaretskii <eliz@gnu.org>
6949
6950 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6951 * doprnt.c: Include limits.h.
6952 (SIZE_MAX): New macro.
04f2d78b
CB
6953 (doprnt): Return a size_t value. 2nd arg is now size_t.
6954 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6955 Improve overflow protection. Support `l' modifier for integer
6956 conversions. Support %l conversion. Don't assume an EMACS_INT
6957 argument for integer conversions and for %c.
6958
6959 * lisp.h (doprnt): Restore prototype.
6960
6961 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6962 $(SRC)/character.h.
6963
6964 * Makefile.in (base_obj): Add back doprnt.o.
6965
6966 * deps.mk (doprnt.o): Add back prerequisites.
6967 (callint.o): Depend on character.h.
6968
6969 * eval.c (internal_lisp_condition_case): Include the handler
6970 representation in the error message.
6971 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6972 when breaking from the loop.
6973
6974 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6975
6976 * callint.c (Fcall_interactively): When displaying error message
6977 about invalid control letter, pass the character's codepoint, not
6978 a pointer to its multibyte form. Improve display of the character
6979 in octal and display also its hex code.
6980
6981 * character.c (char_string): Use %x to display the (unsigned)
6982 codepoint of an invalid character, to avoid displaying a bogus
6983 negative value.
6984
6985 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6986 `error', not SYMBOL_NAME itself.
6987
6988 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6989 character arguments to `error'.
6990
6991 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6992 to `error' in error message about FINAL_CHAR argument. Make sure
6993 FINAL_CHAR is a character, and use %c when it is passed as
6994 argument to `error'.
6995
4ffd0d6b 69962011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6997
6998 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6999
7000 * w32.c: Include <time.h>.
7001 (sys_localtime): New function.
7002
4ffd0d6b 70032011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7004
7005 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7006
4ffd0d6b 7007 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7008
4ffd0d6b 70092011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7010
4ffd0d6b
GM
7011 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7012 zombies (Bug#8467).
aac0c6e3 7013
04c56954
EZ
70142011-04-19 Eli Zaretskii <eliz@gnu.org>
7015
7016 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7017 gl_state.e_property when gl_state.object is Qt.
7018
7019 * insdel.c (make_gap_larger): Remove limitation of buffer size
7020 to <= INT_MAX.
7021
16a43933
CY
70222011-04-18 Chong Yidong <cyd@stupidchicken.com>
7023
7024 * xdisp.c (lookup_glyphless_char_display)
7025 (produce_glyphless_glyph): Handle cons cell entry in
7026 glyphless-char-display.
7027 (Vglyphless_char_display): Document it.
7028
7029 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7030 glyphless-char-display.
7031
4581706e
CY
70322011-04-17 Chong Yidong <cyd@stupidchicken.com>
7033
7034 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7035
7036 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7037
7038 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7039 definition for no-X builds.
7040
4887c6e2 70412011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7042
fd35b6f9
PE
7043 Static checks with GCC 4.6.0 and non-default toolkits.
7044
5c1ccb01
PE
7045 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7046
006c5daa
PE
7047 * process.c (keyboard_bit_set): Define only if SIGIO.
7048 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7049 (send_process): Repair possible setjmp clobbering.
7050
efc736d3
PE
7051 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7052
4e2fe2e6
PE
7053 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7054
f97334a2
PE
7055 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7056
4e75f29d
PE
7057 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7058 Define only if needed.
7059
90efadd1
PE
7060 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7061 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7062 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7063
3c647824
PE
7064 * dispextern.h (struct redisplay_interface): Rename param
7065 to avoid shadowing.
e264f262 7066 * termhooks.h (struct terminal): Likewise.
761383f4 7067 * xterm.c (xembed_send_message): Likewise.
3c647824 7068
b58c5c4a
PE
7069 * insdel.c (make_gap_smaller): Define only if
7070 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7071
cad59032
PE
7072 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7073 it.
7074
c339dc2e
PE
7075 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7076 so that we aren't warned about unused symbols.
7077
91a3e27b
PE
7078 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7079
399c71d3 7080 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7081
8ffc96f5
PE
7082 * xfns.c (x_real_positions): Mark locals as initialized.
7083
eef9bc79
PE
7084 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7085
098db9dd
PE
7086 * xterm.c: Fix problems found by static analysis with other toolkits.
7087 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7088 (x_dispatch_event): Declare static if USE_GTK, and
7089 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7090 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7091 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7092 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7093 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7094
eb18f6cc
PE
7095 * xmenu.c (menu_help_callback): Pointer type fixes.
7096 Use const pointers when pointing at readonly data. Avoid pointer
7097 signedness clashes.
7098 (FALSE): Remove unused macro.
7099 (update_frame_menubar): Remove unused decl.
7100
1fe72bf8
PE
7101 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7102
60d9e1db
PE
7103 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7104 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7105 (single_menu_item): Rename local to avoid shadowing.
7106
39261c26
PE
7107 * keyboard.c (make_lispy_event): Remove unused local var.
7108
018c5e19
PE
7109 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7110 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7111
63d2b86e
PE
7112 * bitmaps: Change bitmaps from unsigned char back to the X11
7113 compatible char. Avoid the old compiler warnings about
7114 out-of-range initializers by using, for example, '\xab' rather
7115 than 0xab.
7116
aefd87e1
PE
7117 * xgselect.c (xgselect_initialize): Check vs interface
7118 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7119
bf501fb9
PE
7120 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7121
e9829fdf
PE
7122 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7123 to read-only memory.
7124
1086c095
PE
7125 * fns.c (vector): Remove; this old hack is no longer needed.
7126
2baccd04 7127 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7128 Remove unused var.
dde42981 7129 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7130
72391843 7131 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7132
436c16df 7133 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7134 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7135 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7136
92bb796d 7137 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7138 (x_term_init): Remove local to avoid shadowing.
92bb796d 7139
764430a3 7140 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7141
7142 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7143 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7144
d1dfb56c
EZ
71452011-04-16 Eli Zaretskii <eliz@gnu.org>
7146
c4354cb4
EZ
7147 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7148
d1dfb56c
EZ
7149 Fix regex.c, syntax.c and friends for buffers > 2GB.
7150 * syntax.h (struct gl_state_s): Declare character position members
7151 EMACS_INT.
7152
7153 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7154
04f2d78b
CB
7155 * textprop.c (verify_interval_modification, interval_of):
7156 Declare arguments EMACS_INT.
d1dfb56c
EZ
7157
7158 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7159 EMACS_INT.
7160
7161 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7162
7163 * indent.c (Fvertical_motion): Local variable it_start is now
7164 EMACS_INT.
7165
7166 * regex.c (re_match, re_match_2, re_match_2_internal)
7167 (bcmp_translate, regcomp, regexec, print_double_string)
7168 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7169 (re_compile_pattern, re_exec): Declare arguments and local
7170 variables `size_t' and `ssize_t' and return values `regoff_t', as
7171 appropriate.
7172 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7173 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7174 <compile_stack_type>: `size' and `avail' are now `size_t'.
7175
7176 * regex.h <regoff_t>: Use ssize_t, not int.
7177 (re_search, re_search_2, re_match, re_match_2): Arguments that
7178 specify buffer/string position and length are now ssize_t and
7179 size_t. Return type is regoff_t.
7180
613052cd
BK
71812011-04-16 Ben Key <bkey76@gmail.com>
7182
7183 * nsfont.m: Fixed bugs in ns_get_family and
7184 ns_descriptor_to_entity that were caused by using free to
7185 deallocate memory blocks that were allocated by xmalloc (via
7186 xstrdup). This caused Emacs to crash when compiled with
7187 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7188 --enable-checking=xmallocoverrun). xfree is now used to
7189 deallocate these memory blocks.
7190
4170f62f 71912011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7192
71b41406
PE
7193 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7194
9587a89d
PE
7195 emacs_write: Accept and return EMACS_INT for sizes.
7196 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7197 et seq.
7198 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7199 Accept and return EMACS_INT.
7200 (emacs_gnutls_write): Return the number of bytes written on
7201 partial writes.
7202 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7203 (emacs_read, emacs_write): Remove check for negative size, as the
7204 Emacs source code has been audited now.
9587a89d
PE
7205 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7206 (emacs_read, emacs_write): Use it.
273a5f82
PE
7207 * process.c (send_process): Adjust to the new signatures of
7208 emacs_write and emacs_gnutls_write. Do not attempt to store
7209 a byte offset into an 'int'; it might overflow.
9587a89d 7210 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7211
3e047f51
PE
7212 * sound.c: Don't assume sizes fit in 'int'.
7213 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7214 Return EMACS_INT, not int.
3e047f51 7215 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7216 Accept EMACS_INT, not int.
7217 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7218 record read return values.
7219
cc39a9db
BK
72202011-04-15 Ben Key <bkey76@gmail.com>
7221
c9d0ec6d
JB
7222 * keyboard.c (Qundefined): Don't declare static since it is used
7223 in nsfns.m.
7224 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7225 static since they are used in nsfont.m.
cc39a9db 7226
6c60eb9f
SM
72272011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7228
7229 * process.c (Qprocessp): Don't declare static.
7230 * lisp.h (Qprocessp): Declare again.
7231
7990b61a
JB
72322011-04-15 Juanma Barranquero <lekktu@gmail.com>
7233
7234 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7235
5d4cb038
PE
72362011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7237
8bd7b830 7238 Improve C-level modularity by making more things 'static'.
cd64ea1d 7239
e3b27b31
PE
7240 Don't publish debugger-only interfaces to other modules.
7241 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7242 (verify_bytepos, count_markers): Move decls to the only modules
7243 that need them.
7244 * region-cache.h (pp_cache): Likewise.
7245 * window.h (check_all_windows): Likewise.
7246 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7247
5d4cb038
PE
7248 * sysdep.c (croak): Now static, if
7249 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7250 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7251
7252 * alloc.c (refill_memory_reserve): Now static if
7253 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7254 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7255
e87b6180
PE
7256 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7257 Define only if USE_LUCID.
7258
ac64929e
PE
7259 * xrdb.c (x_customization_string, x_rm_string): Now static.
7260
6f37259d
PE
7261 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7262 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7263
1683e3ab
PE
7264 * xdisp.c (draw_row_with_mouse_face): Now static.
7265 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7266
de9c2632
PE
7267 * window.h (check_all_windows): Mark externally visible.
7268
2b96acb7
PE
7269 * window.c (window_deletion_count): Now static.
7270
7271 * undo.c: Make symbols static if they're not exported.
7272 (last_undo_buffer, last_boundary_position, pending_boundary):
7273 Now static.
7274
50436f33
PE
7275 * textprop.c (interval_insert_behind_hooks): Now static.
7276 (interval_insert_in_front_hooks): Likewise.
7277
64520e5c
PE
7278 * term.c: Make symbols static if they're not exported.
7279 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7280 (max_frame_lines, tty_set_terminal_modes):
7281 (tty_reset_terminal_modes, tty_turn_off_highlight):
7282 (get_tty_terminal): Now static.
7283 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7284 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7285 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7286 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7287 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7288
1fa53021
PE
7289 * sysdep.c: Make symbols static if they're not exported.
7290 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7291 Now static.
7292 (sigprocmask_set, full_mask): Remove; unused.
7293 (wait_debugging): Mark as visible.
7294 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7295 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7296
d4b43b22
PE
7297 * syntax.c (syntax_temp): Define only if !__GNUC__.
7298
b7c513d0
PE
7299 * sound.c (current_sound_device, current_sound): Now static.
7300
989b29ad
PE
7301 * search.c (searchbufs, searchbuf_head): Now static.
7302
13a55a78
PE
7303 * scroll.c (scroll_cost): Remove; unused.
7304 * dispextern.h (scroll_cost): Remove decl.
7305
de68a1fc
PE
7306 * region-cache.h (pp_cache): Mark as externally visible.
7307
40ccffa6
PE
7308 * process.c: Make symbols static if they're not exported.
7309 (process_tick, update_tick, create_process, chan_process):
7310 (Vprocess_alist, proc_buffered_char, datagram_access):
7311 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7312 (deactivate_process): Mark defn as static, as well as decl.
7313 * lisp.h (create_process): Remove decl.
7314 * process.h (chan_process, Vprocess_alist): Remove decls.
7315
ad64fc97
PE
7316 * print.c: Make symbols static if they're not exported.
7317 (print_depth, new_backquote_output, being_printed, print_buffer):
7318 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7319 (print_interval, print_number_index, initial_stderr_stream):
7320 Now static.
7321 * lisp.h (Fprinc): Remove decl.
7322 (debug_output_compilation_hack): Mark as externally visible.
7323
adddb265
PE
7324 * sysdep.c (croak): Move decl from here to syssignal.h.
7325 * syssignal.h (croak): Put it here, so the API can be checked when
7326 'croak' is called from dissociate_if_controlling_tty.
7327
1717ede2
PE
7328 * minibuf.c: Make symbols static if they're not exported.
7329 (minibuf_save_list, choose_minibuf_frame): Now static.
7330 * lisp.h (choose_minibuf_frame): Remove decl.
7331
fa5fb2bc
PE
7332 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7333
1e3890d1
PE
7334 * lread.c: Make symbols static if they're not exported.
7335 (read_objects, initial_obarray, oblookup_last_bucket_number):
7336 Now static.
7337 (make_symbol): Remove; unused.
7338 * lisp.h (initial_obarray, make_symbol): Remove decls.
7339
8a1414fa
PE
7340 * keyboard.c: Make symbols static if they're not exported.
7341 (single_kboard, recent_keys_index, total_keys, recent_keys):
7342 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7343 (this_single_command_key_start, echoing, last_auto_save):
7344 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7345 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7346 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7347 (Vlispy_mouse_stem, double_click_count):
7348 Now static.
7349 (force_auto_save_soon): Define only if SIGDANGER.
7350 (ignore_mouse_drag_p): Now static if
7351 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7352 (print_help): Remove; unused.
7353 (stop_character, last_timer_event): Mark as externally visible.
7354 * keyboard.h (ignore_mouse_drag_p): Declare only if
7355 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7356 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7357 * lisp.h (echoing): Remove decl.
7358 (force_auto_save_soon): Declare only if SIGDANGER.
7359 * xdisp.c (redisplay_window): Simplify code, to make it more
7360 obvious that ignore_mouse_drag_p is not accessed if !defined
7361 USE_GTK && !defined HAVE_NS.
7362
93ea6e8f
PE
7363 * intervals.c: Make symbols static if they're not exported.
7364 (merge_properties_sticky, merge_interval_right, delete_interval):
7365 Now static.
7366 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7367
77382fcc
PE
7368 * insdel.c: Make symbols static if they're not exported.
7369 However, leave prepare_to_modify_buffer alone. It's never
7370 called from outside this function, but that appears to be a bug.
7371 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7372 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7373 (adjust_after_replace_noundo): Remove; unused.
7374 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7375 (signal_before_change): Remove decls.
77382fcc 7376
9306c32e
PE
7377 * indent.c (val_compute_motion, val_vmotion): Now static.
7378
cd44d2eb
PE
7379 * image.c: Make symbols static if they're not exported.
7380 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7381 if USE_GTK.
7382 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7383 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7384
ad9a7a06
PE
7385 * fringe.c (standard_bitmaps): Now static.
7386 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7387
81626931
PE
7388 * frame.c: Make symbols static if they're not exported.
7389 (x_report_frame_params, make_terminal_frame): Now static.
7390 (get_frame_param): Now static, unless HAVE_NS.
7391 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7392 (x_get_resource_string): Remove; not used.
7393 * frame.h (make_terminal_frame, x_report_frame_params):
7394 (x_get_resource_string); Remove decls.
7395 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7396 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7397
239f9db9
PE
7398 * font.c, fontset.c: Make symbols static if they're not exported.
7399 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7400 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7401 * font.c (font_close_object): Now static.
7402 * font.h (font_close_object): Remove.
7403 * fontset.c (FONTSET_OBJLIST): Remove.
7404 (free_realized_fontset) #if-0 the body, which does nothing.
7405 (face_suitable_for_char_p): #if-0, as it's never called.
7406 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7407 * xfaces.c (face_at_string_position):
7408 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7409 since 0 is always ASCII.
7410
dfcf3579
PE
7411 * fns.c (weak_hash_tables): Now static.
7412
5045092b
PE
7413 * fileio.c: Make symbols static if they're not exported.
7414 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7415 (Vwrite_region_annotation_buffers): Now static.
7416
57a96f5c
PE
7417 * eval.c: Make symbols static if they're not exported.
7418 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7419 * lisp.h (backtrace_list): Remove decl.
7420
35f08c38
PE
7421 * emacs.c: Make symbols static if they're not exported.
7422 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7423 (fatal_error_code, fatal_error_signal_hook, standard_args):
7424 Now static.
7425 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7426 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7427 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7428 * lisp.h (fatal_error_signal_hook): Remove decl.
7429 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7430
f44bd759
PE
7431 * editfns.c: Move a (normally-unused) function to its only use.
7432 * editfns.c, lisp.h (get_operating_system_release): Remove.
7433 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7434 worth the hassle of breaking this out.
7435
b532497d
PE
7436 * xterm.c: Make symbols static if they're not exported.
7437 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7438 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7439 (x_destroy_window, x_delete_display):
7440 Now static.
7441 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7442 (x_mouse_leave): Remove; unused.
7443 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7444 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7445 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7446 Remove decls.
7447 (x_mouse_leave): Declare only if WINDOWSNT.
7448 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7449 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7450 USE_X_TOOLKIT.
7451
1675728f
PE
7452 * ftxfont.c: Make symbols static if they're not exported.
7453 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7454 HAVE_FREETYPE.
7455 * font.h (ftxfont_driver): Likewise.
7456
e4cebfca
PE
7457 * xfns.c: Make symbols static if they're not exported.
7458 (x_last_font_name, x_display_info_for_name):
7459 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7460 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7461 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7462 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7463 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7464 (last_show_tip_args): Now static.
7465 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7466 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7467 (x_screen_planes): Remove; unused.
7468 * dispextern.h (x_screen_planes): Remove decl.
7469
5bf46f05
PE
7470 * dispnew.c: Make symbols static if they're not exported.
7471 * dispextern.h (redraw_garbaged_frames, scrolling):
7472 (increment_row_positions): Remove.
7473 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7474 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7475 Now static.
7476 (redraw_garbaged_frames): Remove; unused.
7477
435f4c28
PE
7478 * xfaces.c: Make symbols static if they're not exported.
7479 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7480 Remove decls.
7481 * xterm.h (defined_color): Remove decls.
7482 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7483 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7484 (menu_face_changed_default, defined_color, free_realized_face):
7485 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7486 (ascii_face_of_lisp_face): Remove; unused.
7487
8524aef3
PE
7488 * xdisp.c: Make symbols static if they're not exported.
7489 * dispextern.h (scratch_glyph_row, window_box_edges):
7490 (glyph_to_pixel_coords, set_cursor_from_row):
7491 (get_next_display_element, set_iterator_to_next):
7492 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7493 (show_mouse_face): Remove decls
7494 * frame.h (message_buf_print): Likewise.
7495 * lisp.h (pop_message, set_message, check_point_in_composition):
7496 Likewise.
7497 * xterm.h (set_vertical_scroll_bar): Likewise.
7498 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7499 (message_buf_print, scratch_glyph_row, displayed_buffer):
7500 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7501 (get_next_display_element, show_mouse_face, window_box_edges):
7502 (frame_to_window_pixel_xy, check_point_in_composition):
7503 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7504 (glyph_to_pixel_coords): Remove; unused.
7505
16390cd2
PE
7506 * dired.c (file_name_completion): Now static.
7507
7508 * dbusbind.c (xd_in_read_queued_messages): Now static.
7509
a25f4dfa
PE
7510 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7511 * data.c (circular_list_error): Remove.
7512
14a9c8df
PE
7513 * commands.h (last_point_position, last_point_position_buffer):
7514 (last_point_position_window): Remove decls.
7515 * keyboard.c: Make these variables static.
7516
04f2d78b
CB
7517 * coding.h (coding, code_convert_region, encode_coding_gap):
7518 Remove decls.
74ab6df5
PE
7519 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7520 (iso_code_class, detect_coding, code_convert_region): Now static.
7521 (encode_coding_gap): Remove; unused.
7522
38dfbee1
PE
7523 * chartab.c (chartab_chars, chartab_bits): Now static.
7524
a2cb4e63
PE
7525 * charset.h (charset_iso_8859_1): Remove decl.
7526 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7527 Now static.
7528
127198fd
PE
7529 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7530 * ccl.c (Vccl_program_table): Now static.
7531 (check_ccl_update): Remove; unused.
7532
d85b608f
PE
7533 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7534 * category.h: ... from here.
7535 * category.c (check_category_table, set_category_set): Now static.
7536
31cd66f3
PE
7537 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7538 * lisp.h: Remove these decls.
7539
c358e587
PE
7540 * buffer.c (buffer_count): Remove unused var.
7541
e78aecca
PE
7542 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7543 so that it's not optimized away.
7544 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7545 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7546 exported only to the debugger.
7547
e192d7d3 7548 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7549 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7550
92470028
PE
7551 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7552 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7553 was inaccessible from Lisp.
7554 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7555 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7556
244ed907
PE
7557 alloc.c: Import and export fewer symbols, and remove unused items.
7558 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7559 is defined.
7560 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7561 it's not optimized away by whole-program optimization.
7562 (message_enable_multibyte, free_misc): Remove.
7563 (catchlist, handlerlist, mark_backtrace):
7564 Declare only if BYTE_MARK_STACK.
7565 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7566 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7567 (message_enable_multibyte): Remove decl.
7568 (free_misc, interval_free_list, float_block, float_block_index):
7569 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7570 (cons_free_list, last_marked_index):
7571 Now static.
7572 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7573 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7574 (mark_backtrace): Define only if BYTE_MARK_STACK.
7575 * xdisp.c (message_enable_multibyte): Now static.
7576
61c2b50e 7577 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7578 This makes it easier for human readers (and static analyzers)
7579 to see whether these variables are used from other modules.
7580 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7581 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7582 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7583 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7584 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7585 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7586 * xmenu.c, xselect.c:
7587 Declare Q* vars static if they are not used in other modules.
7588 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7589 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7590 Remove decls of unexported vars.
7591 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7592
95c82688
PE
7593 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7594
16a97296
PE
7595 Make Emacs functions such as Fatom 'static' by default.
7596 This makes it easier for human readers (and static analyzers)
7597 to see whether these functions can be called from other modules.
7598 DEFUN now defines a static function. To make the function external
7599 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7600 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7601 (Finit_image_library):
16a97296
PE
7602 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7603 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7604 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7605 Remove decls, since these functions are now static.
7606 (Funintern, Fget_internal_run_time): New decls, since these functions
7607 were already external.
95c82688 7608
16a97296
PE
7609 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7610 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7611 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7612 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7613 * keyboard.c, keymap.c, lread.c:
7614 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7615 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7616 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7617 Mark functions with DEFUE instead of DEFUN,
7618 if they are used in other modules.
7619 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7620 decls for now-static functions.
7621 * buffer.h (Fdelete_overlay): Remove decl.
7622 * callproc.c (Fgetenv_internal): Mark as internal.
7623 * composite.c (Fremove_list_of_text_properties): Remove decl.
7624 (Fcomposition_get_gstring): New forward static decl.
7625 * composite.h (Fcomposite_get_gstring): Remove decl.
7626 * dired.c (Ffile_attributes): New forward static decl.
7627 * doc.c (Fdocumntation_property): New forward static decl.
7628 * eval.c (Ffetch_bytecode): New forward static decl.
7629 (Funintern): Remove extern decl; now in .h file where it belongs.
7630 * fileio.c (Fmake_symbolic_link): New forward static decl.
7631 * image.c (Finit_image_library): New forward static decl.
7632 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7633 * intervals.h (Fprevious_property_change):
7634 (Fremove_list_of_text_properties): Remove decls.
7635 * keyboard.c (Fthis_command_keys): Remove decl.
7636 (Fcommand_execute): New forward static decl.
7637 * keymap.c (Flookup_key): New forward static decl.
7638 (Fcopy_keymap): Now static.
7639 * keymap.h (Flookup_key): Remove decl.
7640 * process.c (Fget_process): New forward static decl.
7641 (Fprocess_datagram_address): Mark as internal.
7642 * syntax.c (Fsyntax_table_p): New forward static decl.
7643 (skip_chars): Remove duplicate decl.
7644 * textprop.c (Fprevious_property_change): New forward static decl.
7645 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7646 Now internal.
7647 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7648 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7649
785bbd42
PE
7650 * editfns.c (Fformat): Remove unreachable code.
7651
8b913b57
AS
76522011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7653
7654 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7655 change. (Bug#8496)
7656
a6744a35
EZ
76572011-04-13 Eli Zaretskii <eliz@gnu.org>
7658
7659 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7660 when at ZV. (Bug#8487)
7661
e7974947
AS
76622011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7663
baad03f0
AS
7664 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7665 (Bug#8437)
7666 * keyboard.c (parse_tool_bar_item): Likewise.
7667 * sound.c (sound_cleanup, alsa_close): Likewise.
7668 * termcap.c (tgetent): Likewise.
7669 * xfns.c (x_default_font_parameter): Likewise.
7670 * xsettings.c (read_and_apply_settings): Likewise.
7671
e7974947
AS
7672 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7673 (overrun_check_free): Protoize.
7674
28272684
PE
76752011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7676
7677 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7678 since callers should never pass a negative size.
7679 Change the signature to match that of plain 'read' and 'write'; see
7680 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7681 * lisp.h: Update prototypes of emacs_write and emacs_read.
7682
11997c76
EZ
76832011-04-11 Eli Zaretskii <eliz@gnu.org>
7684
7685 * xdisp.c (redisplay_window): Don't try to determine the character
7686 position of the scroll margin if the window start point w->startp
e896f03c 7687 is outside the buffer's accessible region. (Bug#8468)
11997c76 7688
8a2cbd72
EZ
76892011-04-10 Eli Zaretskii <eliz@gnu.org>
7690
7691 Fix write-region and its subroutines for buffers > 2GB.
7692 * fileio.c (a_write, e_write): Modify declaration of arguments and
7693 local variables to support buffers larger than 2GB.
7694 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7695
7696 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7697 argument, local variables, and return value.
7698
7699 * lisp.h: Update prototypes of emacs_write and emacs_read.
7700
7701 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7702
4073e537 77032011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7704
1ebfdcb6
PE
7705 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7706
b2ded58d
PE
7707 Fix more problems found by GCC 4.6.0's static checks.
7708
7d66342c
PE
7709 * xdisp.c (vmessage): Use a better test for character truncation.
7710
bbf47d44
PE
7711 * charset.c (load_charset_map): <, not <=, for optimization,
7712 and to avoid potential problems with integer overflow.
9248994d 7713 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7714 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7715 * editfns.c (Fformat): Likewise.
1e69125e 7716 * syntax.c (skip_chars): Likewise.
3befa583 7717
e3019616
PE
7718 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7719 This also lets GCC 4.6.0 generate slightly better loop code.
7720
becfa255
PE
7721 * callint.c (Fcall_interactively): <, not <=, for optimization.
7722 (Fcall_interactively): Count the number of arguments produced,
7723 not the number of arguments given. This is simpler and lets GCC
7724 4.6.0 generate slightly better code.
7725
dae0cd48
PE
7726 * ftfont.c: Distingish more carefully between FcChar8 and char.
7727 The previous code passed unsigned char * to a functions like
7728 strlen and xstrcasecmp that expect char *, which does not
7729 conform to the C standard.
7730 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7731 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7732 char * when the C standard requires it.
7733
76032d70
PE
7734 * keyboard.c (read_char): Remove unused var.
7735
eb3f1cc8
PE
7736 * eval.c: Port to Windows vsnprintf (Bug#8435).
7737 Include <limits.h>.
7738 (SIZE_MAX): Define if the headers do not.
7739 (verror): Do not give up if vsnprintf returns a negative count.
7740 Instead, grow the buffer. This ports to Windows vsnprintf, which
7741 does not conform to C99. Problem reported by Eli Zaretskii.
7742 Also, simplify the allocation scheme, by avoiding the need for
7743 calling realloc, and removing the ALLOCATED variable.
7744
70476b54
PE
7745 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7746
12020a9e
PE
7747 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7748 But keep the doprint source code for now, as we might revamp it
7749 and use it again (Bug#8435).
ea6c7ae6
PE
7750 * lisp.h (doprnt): Remove.
7751 * Makefile.in (base_obj): Remove doprnt.o.
7752 * deps.mk (doprnt.o): Remove.
7753
5fdb398c
PE
7754 error: Print 32- and 64-bit integers portably (Bug#8435).
7755 Without this change, on typical 64-bit hosts error ("...%d...", N)
7756 was used to print both 32- and 64-bit integers N, which relied on
7757 undefined behavior.
61bdb816 7758 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7759 * lisp.h (error, verror): Mark as printf-like functions.
7760 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7761 Report overflow in size calculations when allocating printf buffer.
7762 Do not truncate output string at its first null byte.
7763 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7764 Truncate the output at a character boundary, since vsnprintf does not
7765 do that.
7766 * charset.c (check_iso_charset_parameter): Convert internal
7767 character to string before calling 'error', since %c now has the
7768 printf meaning.
7769 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7770 overflow when computing char to be passed to 'error'. Do not
7771 pass Lisp_Object to 'error'; pass the integer instead.
7772 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7773 formatted with plain %d.
7774
b189fa66
PE
7775 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7776
bff87ef0
PE
7777 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7778
7e2cac20
PE
7779 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7780
ce4d90b5
PE
7781 * xterm.c (x_catch_errors): Remove duplicate declaration.
7782
266c9547
PE
7783 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7784
79c49ad2
PE
7785 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7786
368f4090
JM
77872011-04-10 Jim Meyering <meyering@redhat.com>
7788
7789 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7790 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7791 return ssize_t not "int", and use size_t as the buffer length.
7792 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7793 * gnutls.h: Update declarations.
7794 * process.c (read_process_output): Use ssize_t, to match.
7795 (send_process): Likewise.
7796
a32d4040
CY
77972011-04-09 Chong Yidong <cyd@stupidchicken.com>
7798
7799 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7800
8546720e 78012011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7802
04f2d78b
CB
7803 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7804 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7805
8546720e
GM
7806 * xterm.c (handle_one_xevent):
7807 * xmenu.c (create_and_show_popup_menu):
7808 * xselect.c (x_decline_selection_request)
7809 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7810
0a2f5c1a 78112011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7812
7813 Fix some uses of `int' instead of EMACS_INT.
7814 * search.c (string_match_1, fast_string_match)
7815 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7816 (scan_buffer, find_next_newline_no_quit)
7817 (find_before_next_newline, search_command, Freplace_match)
7818 (Fmatch_data): Make some `int' variables be EMACS_INT.
7819
7820 * xdisp.c (display_count_lines): 3rd argument and return value now
7821 EMACS_INT. All callers changed.
7822 (pint2hrstr): Last argument is now EMACS_INT.
7823
7824 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7825 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7826 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7827 (decode_coding_utf_16, decode_coding_emacs_mule)
7828 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7829 (decode_coding_ccl, decode_coding_charset)
7830 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7831 (decode_coding_iso_2022, decode_coding_emacs_mule)
7832 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7833 <char_offset, last_offset>: Declare EMACS_INT.
7834 (encode_coding_utf_8, encode_coding_utf_16)
7835 (encode_coding_emacs_mule, encode_invocation_designation)
7836 (encode_designation_at_bol, encode_coding_iso_2022)
7837 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7838 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7839 Declare EMACS_INT.
7840 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7841 (encode_invocation_designation): Last argument P_NCHARS is now
7842 EMACS_INT.
7843 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7844 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7845
7846 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7847 All users changed.
7848
7849 * ccl.c (Fccl_execute_on_string): Declare some variables
7850 EMACS_INT.
7851
8546720e 78522011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7853
7854 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7855
4e19a977
CS
78562011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7857
7858 * process.c (Fformat_network_address): Doc fix.
7859
87302331
R
78602011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7861
ee7683eb 7862 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7863
cbb59342
CY
78642011-04-08 Chong Yidong <cyd@stupidchicken.com>
7865
7866 * keyboard.c (read_char): Call Lisp function help-form-show,
7867 instead of using internal_with_output_to_temp_buffer.
7868 (Qhelp_form_show): New var.
e0d38eeb 7869 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7870
7871 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7872
7873 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7874
e67a13ab
CY
78752011-04-06 Chong Yidong <cyd@stupidchicken.com>
7876
04f2d78b
CB
7877 * process.c (Flist_processes): Remove to Lisp.
7878 (list_processes_1): Delete.
e67a13ab 7879
973f782d
EZ
78802011-04-06 Eli Zaretskii <eliz@gnu.org>
7881
7c106b1e
EZ
7882 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7883
973f782d
EZ
7884 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7885
41cf7d1a 78862011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7887
ca23cc88
PE
7888 Fix more problems found by GCC 4.6.0's static checks.
7889
f390e2d5
PE
7890 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7891
42eea0d0
PE
7892 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7893
b69769da 7894 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7895
f9541e84
PE
7896 * xdisp.c (vmessage): Mark as a printf-like function.
7897
13841b55
PE
7898 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7899
c136c10f
PE
7900 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7901
5e2d4a30
PE
7902 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7903 printf-like functions.
7904 (tiff_load): Add casts to remove these marks before passing them
7905 to system-supplied API.
7906
583f48b9
PE
7907 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7908
b25d760e
PE
7909 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7910 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7911 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7912 directly, rather than having caller test rule sign. This avoids
7913 some unnecessary tests.
7914 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7915 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7916 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7917
bc7b6697 7918 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7919 (xfont_open): Avoid unnecessary tests.
bc7b6697 7920
27ccc379
PE
7921 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7922
dcd5c89a
PE
7923 * composite.h, composite.c (composition_gstring_put_cache):
7924 Use EMACS_INT, not int, for length.
7925
b13a45c6
PE
7926 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7927 breaking out part of COMPOSITION_DECODE_RULE.
7928 (COMPOSITION_DECODE_RULE): Use it.
7929 * composite.c (get_composition_id): Remove unused local vars,
7930 by using the new macro.
7931
1e792e4d
PE
7932 * textprop.c (set_text_properties_1): Change while to do-while,
7933 since the condition is always true at first.
7934
dc6c6455 7935 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7936 (interval_deletion_adjustment): Return unsigned value.
7937 All uses changed.
dc6c6455 7938
aba7731a
PE
7939 * process.c (list_processes_1, create_pty, read_process_output):
7940 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7941 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7942 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7943 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7944 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7945
fdfc4bf3
PE
7946 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7947
fca8fe46 7948 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7949 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7950
06a0259a 7951 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7952 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7953 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7954
e7b9e80f
PE
7955 * print.c (print_error_message): Avoid int overflow.
7956
56201685
PE
7957 * font.c (font_list_entities): Redo for clarity,
7958 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7959
78834453 7960 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7961 (font_score): Avoid potential overflow in diff calculation.
78834453 7962
0bc0b309 7963 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7964 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7965
e610eaca
PE
7966 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7967
b895abce
PE
7968 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7969 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7970 can always succeed if overflow has undefined behavior.
7971
1f1d9321 7972 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7973 (wordify): Omit three unnecessary tests.
1f1d9321 7974
c59478bc
PE
7975 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7976 All callers changed. This avoids the need for an unused var.
7977
79b73827
PE
7978 * casefiddle.c (casify_region): Remove var that is set but not used.
7979
a4db5dfe
PE
7980 * dired.c (file_name_completion): Remove var that is set but not used.
7981
43aae36e
PE
7982 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7983
2a47c44d 7984 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7985 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7986
a37c69bf
PE
7987 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7988 Check for integer overflow on size calculations.
7989
328ab8e7
PE
7990 * buffer.c (Fprevious_overlay_change): Remove var that is set
7991 but not used.
7992
e5a2a5cb
PE
7993 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7994 Remove vars that are set but not used.
8d84a6eb 7995 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7996 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7997
a60e5f68
PE
7998 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7999
f661cb61 8000 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8001 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8002
f0397f5a
PE
8003 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8004 that are set but not used.
8005
8664db06 8006 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8007 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8008
6abdaa4a
PE
8009 * xselect.c (x_get_local_selection, x_handle_property_notify):
8010 Remove vars that are set but not used.
8011
0ce7538d 8012 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8013 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8014
9ae848fc
PE
8015 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8016 Remove var that is set but not used.
0b918413
PE
8017 (scroll_bar_windows_size): Now size_t, not int.
8018 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8019 Check for overflow.
9ae848fc 8020
a5a62657
PE
8021 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8022 (map_tty_color) [!defined MSDOS]: Likewise.
8023
5c5cdd39
PE
8024 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8025
66ebf983
PE
8026 * coding.c: Remove vars that are set but not used.
8027 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8028 All callers changed.
8029 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8030 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8031 (decode_coding_charset): Remove vars that are set but not used.
8032
1be4d761
PE
8033 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8034 that is set but not used.
8035
47553fa8
PE
8036 * print.c (print_object): Remove var that is set but not used.
8037
1f7196bf 8038 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8039 The gnulib version avoids calling malloc in the usual case,
8040 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8041 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8042 * filelock.c (current_lock_owner): Likewise.
8043 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8044 * sysdep.c: Include allocator.h, careadlinkat.h.
8045 (emacs_no_realloc_allocator): New static constant.
8046 (emacs_readlink): New function.
fdb61804
PE
8047 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8048 ../lib/careadlinkat.h.
d1fdcab7 8049
f84c17c7
SM
80502011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8051
8052 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8053 first non-nil return value).
8054
ef3862ad
JD
80552011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8056
8057 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8058 if not defined (Bug#8403).
8059
376a7006
JB
80602011-04-02 Juanma Barranquero <lekktu@gmail.com>
8061
8062 * xdisp.c (display_count_lines): Remove parameter `start',
8063 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8064 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8065 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8066 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8067 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8068 and thereabouts. All callers changed.
8069 (get_per_char_metric): Remove parameter `f', unused since
8070 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8071
6ca3801d
JM
80722011-04-02 Jim Meyering <meyering@redhat.com>
8073
8074 do not dereference NULL upon failed strdup
8075 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8076 (ns_get_family): Likewise.
8077
d8e2b5ba
JB
80782011-04-02 Juanma Barranquero <lekktu@gmail.com>
8079
8080 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8081
8c74fcbd
JD
80822011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8083
8084 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8085 later (Bug#8403).
8086
7200d79c
SM
80872011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8088
03408648 8089 Add lexical binding.
7200d79c 8090
03408648
SM
8091 * window.c (Ftemp_output_buffer_show): New fun.
8092 (Fsave_window_excursion):
8093 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8094
8095 * lread.c (lisp_file_lexically_bound_p): New function.
8096 (Fload): Bind Qlexical_binding.
8097 (readevalloop): Remove `evalfun' arg.
8098 Bind Qinternal_interpreter_environment.
8099 (Feval_buffer): Bind Qlexical_binding.
8100 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8101 Mark as dynamic.
8102 (syms_of_lread): Declare `lexical-binding'.
8103
8104 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8105
8106 * keyboard.c (eval_dyn): New fun.
8107 (menu_item_eval_property): Use it.
ca105506
SM
8108
8109 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8110
03408648
SM
8111 * fns.c (concat, mapcar1): Accept byte-code-functions.
8112
8113 * eval.c (Fsetq): Handle lexical vars.
8114 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8115 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8116 (FletX, Flet): Obey lexical binding.
8117 (Fcommandp): Handle closures.
8118 (Feval): New `lexical' arg.
8119 (eval_sub): New function extracted from Feval. Use it almost
8120 everywhere where Feval was used. Look up vars in lexical env.
8121 Handle closures.
8122 (Ffunctionp): Move from subr.el.
8123 (Ffuncall): Handle closures.
8124 (apply_lambda): Remove `eval_flags'.
8125 (funcall_lambda): Handle closures and new byte-code-functions.
8126 (Fspecial_variable_p): New function.
8127 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8128 but without exporting it to Lisp.
23aba0ea 8129
23aba0ea 8130 * doc.c (Fdocumentation, store_function_docstring):
03408648 8131 * data.c (Finteractive_form): Handle closures.
23aba0ea 8132
03408648
SM
8133 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8134 interactive spec.
ba83908c 8135
04f2d78b
CB
8136 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8137 New byte-codes.
03408648
SM
8138 (exec_byte_code): New function extracted from Fbyte_code to handle new
8139 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8140
03408648 8141 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8142
03408648 8143 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8144
e2abce01
JB
81452011-03-31 Juanma Barranquero <lekktu@gmail.com>
8146
8147 * xdisp.c (redisplay_internal): Fix prototype.
8148
63696a73 81492011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8150
63696a73 8151 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8152 (try_scrolling): Use it when setting scroll_limit.
8153 Limit scrolling to 100 screen lines.
63696a73
EZ
8154 (redisplay_window): Even when falling back on "recentering",
8155 position point in the window according to scroll-conservatively,
8156 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8157
8158 (try_scrolling): When point is above the window, allow searching
8159 as far as scroll_max, or one screenful, to compute vertical
8160 distance from PT to the scroll margin position. This prevents
8161 try_scrolling from unnecessarily failing when
8162 scroll-conservatively is set to a value slightly larger than the
8163 window height. Clean up the case of PT below the margin at bottom
8164 of window: scroll_max can no longer be INT_MAX. When aggressive
8165 scrolling is in use, don't let point enter the opposite scroll
8166 margin as result of the scroll.
8167 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8168 threshold of 100 lines for never-recentering scrolling.
8169
e4cc2dfc
JB
81702011-03-31 Juanma Barranquero <lekktu@gmail.com>
8171
8172 * dispextern.h (move_it_by_lines):
8173 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8174 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8175 (message_log_check_duplicate): Remove parameters `prev_bol' and
8176 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8177 (redisplay_internal): Remove parameter `preserve_echo_area',
8178 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8179
8180 * indent.c (Fvertical_motion):
8181 * window.c (window_scroll_pixel_based, Frecenter):
8182 Don't pass `need_y_p' to `move_it_by_lines'.
8183
1c470562
SM
81842011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8185
44f230aa
SM
8186 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8187 steal a few bits to be more compact.
8188 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8189 Remove unneeded casts.
8190
1c470562
SM
8191 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8192
888adce9
ZK
81932011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8194
8195 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8196 binding" message (bug#7967).
8197
f838ed7b
PE
81982011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8199
77861b95
PE
8200 Fix more problems found by GCC 4.6.0's static checks.
8201
de6dbc14
PE
8202 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8203 Remove unused local var.
8204
f838ed7b
PE
8205 * editfns.c (Fmessage_box): Remove unused local var.
8206
792c7b2b
PE
8207 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8208 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8209 Omit unused local vars.
c499e557 8210 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8211 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8212 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8213 Omit unused local var.
8214
ba0165e1
PE
8215 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8216 Don't assume string length fits in int.
32ad8845 8217 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8218 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8219
3c59b4c9
PE
8220 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8221 instead of alloca (Bug#8344).
8222
a3eed478 8223 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8224 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8225
eb4d412d
PE
8226 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8227
1658b401
PE
8228 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8229 concerns.
8230
8231 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8232
8233 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8234
9a2c6e05
PE
8235 * keyboard.c (syms_of_keyboard): Use the same style as later
8236 in this function when indexing through an array. This also
8237 works around GCC bug 48267.
8238
03d0a109
PE
8239 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8240
44f730c8
PE
8241 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8242
fe75f926
PE
8243 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8244 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8245
ffa8c828
PE
8246 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8247 This avoids undefined behavior on integer overflow, and is a bit
8248 more convenient anyway since it is compared to a size_t variable.
8249
c5101a77
PE
8250 Variadic C functions now count arguments with size_t, not int.
8251 This avoids an unnecessary limitation on 64-bit machines, which
8252 caused (substring ...) to crash on large vectors (Bug#8344).
8253 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8254 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8255 All variadic functions and their callers changed accordingly.
c5101a77
PE
8256 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8257 * data.c (arith_driver, float_arith_driver): Likewise.
8258 * editfns.c (general_insert_function): Likewise.
8259 * eval.c (struct backtrace.nargs, interactive_p)
8260 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8261 (funcall_lambda, mark_backtrace): Likewise.
8262 * fns.c (concat): Likewise.
8263 * frame.c (x_set_frame_parameters): Likewise.
8264 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8265 0 if not found, not -1. All callers changed.
8266
dd3f25f7
PE
8267 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8268 (stack_copy_size): Now size_t, not int.
8269 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8270
461c2ab9
JB
82712011-03-28 Juanma Barranquero <lekktu@gmail.com>
8272
8273 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8274 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8275 All callers changed.
8276
8277 * lisp.h (multibyte_char_to_unibyte):
8278 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8279 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8280 * character.h (CHAR_TO_BYTE8):
8281 * cmds.c (internal_self_insert):
8282 * editfns.c (general_insert_function):
8283 * keymap.c (push_key_description):
8284 * search.c (Freplace_match):
8285 * xdisp.c (message_dolog, set_message_1): All callers changed.
8286
f6d62986
SM
82872011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8288
8289 * keyboard.c (safe_run_hook_funcall): New function.
8290 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8291 don't set the hook to nil, but remove the offending function instead.
8292 (Qcommand_hook_internal): Remove, unused.
8293 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8294 Vcommand_hook_internal.
8295
8296 * eval.c (enum run_hooks_condition): Remove.
8297 (funcall_nil, funcall_not): New functions.
8298 (run_hook_with_args): Call each function through a `funcall' argument.
8299 Remove `cond' argument, now redundant.
8300 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8301 (Frun_hook_with_args_until_failure): Adjust accordingly.
8302 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8303
1db5b1ad
JB
83042011-03-28 Juanma Barranquero <lekktu@gmail.com>
8305
8306 * dispextern.h (string_buffer_position): Remove declaration.
8307
8308 * print.c (strout): Remove parameter `multibyte', unused since
8309 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8310
8311 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8312 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8313 All callers changed.
8314
8315 * w32.c (_wsa_errlist): Use braces for struct initializers.
8316
8317 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8318 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8319 All callers changed.
8320 (string_buffer_position): Likewise. Also, make static (it's never
8321 used outside xdisp.c).
8322 (cursor_row_p): Remove parameter `w', unused since
8323 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8324 (decode_mode_spec): Remove parameter `precision', introduced during
8325 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8326 All callers changed.
8327
5ffb62aa
JD
83282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8329
8330 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8331
461c2ab9 83322011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8333
8334 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8335 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8336 (ns_update_auto_hide_menu_bar): New functions.
8337 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8338 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8339 ns_constrain_all_frames.
8340 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8341 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8342
5c380ffb
JD
83432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8344
8345 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8346
9af30bdf
GM
83472011-03-27 Glenn Morris <rgm@gnu.org>
8348
8349 * syssignal.h: Replace RETSIGTYPE with void.
8350 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8351 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8352 Replace SIGTYPE with void everywhere.
8353 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8354 * s/template.h (SIGTYPE): Remove commented out definition.
8355
e2abce01
JB
83562011-03-26 Eli Zaretskii <eliz@gnu.org>
8357
8358 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8359 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8360
f868cd8a
JB
83612011-03-26 Juanma Barranquero <lekktu@gmail.com>
8362
59eb0929
JB
8363 * w32.c (read_unc_volume): Use parameter `henum', instead of
8364 global variable `wget_enum_handle'.
8365
8366 * keymap.c (describe_vector): Remove parameters `indices' and
8367 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8368 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8369
f868cd8a
JB
8370 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8371
8372 * keyboard.c (timer_check): Remove parameter `do_it_now',
8373 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8374 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8375 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8376
8377 * keyboard.c (read_char):
8378 * w32menu.c (w32_menu_display_help):
8379 * xmenu.c (show_help_event, menu_help_callback):
8380 Adjust calls to `show_help_echo'.
8381
8382 * gtkutil.c (xg_maybe_add_timer):
8383 * keyboard.c (readable_events):
8384 * process.c (wait_reading_process_output):
8385 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8386
8387 * insdel.c (adjust_markers_gap_motion):
8388 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8389 (gap_left, gap_right): Don't call it.
8390
2ecf6fdb
CY
83912011-03-25 Chong Yidong <cyd@stupidchicken.com>
8392
8393 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8394 incurred during fontification.
8395
6b1f9ba4
JB
83962011-03-25 Juanma Barranquero <lekktu@gmail.com>
8397
8398 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8399 (DEFVAR_PER_BUFFER): Don't pass it.
8400
8401 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8402 (scrolling_window): Don't pass it.
8403
0f4a96b5
JB
84042011-03-25 Juanma Barranquero <lekktu@gmail.com>
8405
8406 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8407
8408 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8409 and `suffix'.
8410 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8411 of variables specific to SELinux and computation of `encoded_absname'.
8412
8413 * image.c (XPutPixel): Remove unused variable `height'.
8414
8415 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8416
8417 * unexw32.c (get_section_info): Remove unused variable `section'.
8418
8419 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8420 (system_process_attributes): Remove unused variable `sess'.
8421 (sys_read): Remove unused variable `err'.
8422
8423 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8424 (w32_wnd_proc): Remove unused variable `isdead'.
8425 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8426 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8427 (x_create_tip_frame): Remove unused variable `tem'.
8428
8429 * w32inevt.c (w32_console_read_socket):
8430 Remove unused variable `no_events'.
8431
8432 * w32term.c (x_draw_composite_glyph_string_foreground):
8433 Remove unused variable `width'.
8434
1149507c
JB
84352011-03-24 Juanma Barranquero <lekktu@gmail.com>
8436
8437 * w32term.c (x_set_glyph_string_clipping):
8438 Don't pass uninitialized region to CombineRgn.
8439
9c88f339
JB
84402011-03-23 Juanma Barranquero <lekktu@gmail.com>
8441
8442 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8443 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8444 (Fx_close_connection): Remove unused variable `i'.
8445
8446 * w32font.c (w32font_draw): Return number of glyphs.
8447 (w32font_open_internal): Remove unused variable `i'.
8448 (w32font_driver): Add missing initializer.
8449
8450 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8451 (fill_in_menu): Remove unused variable `items_added'.
8452
8453 * w32term.c (last_mouse_press_frame): Remove static global variable.
8454 (w32_clip_to_row): Remove unused variable `f'.
8455 (x_delete_terminal): Remove unused variable `i'.
8456
8457 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8458 (NOTHING): Remove unused static global variable.
8459 (uniscribe_check_otf): Remove unused variable `table'.
8460 (uniscribe_font_driver): Add missing initializers.
8461
dee091a3
JD
84622011-03-23 Julien Danjou <julien@danjou.info>
8463
8464 * term.c (Fsuspend_tty, Fresume_tty):
8465 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8466 * window.c (temp_output_buffer_show):
8467 * insdel.c (signal_before_change):
8468 * frame.c (Fhandle_switch_frame):
8469 * fileio.c (Fdo_auto_save):
8470 * emacs.c (Fkill_emacs):
8471 * editfns.c (save_excursion_restore):
8472 * cmds.c (internal_self_insert):
8473 * callint.c (Fcall_interactively):
8474 * buffer.c (Fkill_all_local_variables):
8475 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8476 Use Frun_hooks.
0f4a96b5 8477 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8478 unconditionally since it does the check itself.
dee091a3 8479
2c520ab5 84802011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8481
c9c49752
PE
8482 Fix more problems found by GCC 4.5.2's static checks.
8483
8abc3f12
PE
8484 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8485 the first time through the loop, since we know p0 < p1 then.
8486 This also avoids a gcc -Wstrict-overflow warning.
8487
a2d26660
PE
8488 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8489 leading to a memory leak, possible in functions like
8490 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8491 of objects (Bug#8318).
a2d26660 8492
916c72e9
PE
8493 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8494 that could (at least in theory) be that large.
8495
19ab8a18
PE
8496 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8497 This is less likely to overflow, and avoids undefined behavior if
8498 overflow does occur. All callers changed. Use strtoul to scan
8499 for the unsigned long integer.
b7cbbd6f
PE
8500 (pint2hrstr): Simplify and tune code slightly.
8501 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8502
f0641eff
PE
8503 * scroll.c (do_scrolling): Work around GCC bug 48228.
8504 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8505
7f650bb9
PE
8506 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8507 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8508 (validate_x_resource_name): Simplify count usage.
8509 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8510
37dd57d1
PE
8511 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8512 fail (Bug#8306).
81e56e61 8513
699979fc 8514 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8515
401bf9b4
PE
8516 * process.c (Fmake_network_process): Use socklen_t, not int,
8517 where POSIX says socklen_t is required in portable programs.
8518 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8519 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8520 (Fmake_network_process, server_accept_connection):
8521 (wait_reading_process_output, read_process_output):
8522 Likewise.
8523
b93aacde
PE
8524 * process.c: Rename or move locals to avoid shadowing.
8525 (list_processes_1, Fmake_network_process):
8526 (read_process_output_error_handler, exec_sentinel_error_handler):
8527 Rename or move locals.
4dc343ee 8528 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8529 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8530 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8531 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8532 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8533
af8a867c 8534 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8535 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8536 Include tparam.h instead, since it declares them.
af8a867c
PE
8537 * cm.h (PC): Remove extern decl; tparam.h now does this.
8538 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8539 * terminfo.c: Include tparam.h, to check interfaces.
8540 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8541 (tparam): Adjust signature to match interface in tparam.h;
8542 this removes some undefined behavior. Check that outstring and len
8543 are zero, which they always are with Emacs.
8544 * tparam.h (PC, BC, UP): New extern decls.
8545
0248044d 8546 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8547 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8548
8ff096c1 8549 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8550 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8551 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8552 (ftfont_list): Remove unused local.
49eaafba
PE
8553 (get_adstyle_property, ftfont_pattern_entity):
8554 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8555 Rename locals to avoid shadowing.
8ff096c1 8556
e2be39f6
PE
8557 * xfont.c (xfont_list_family): Mark var as initialized.
8558
c9735e30
PE
8559 * xml.c (make_dom): Now static.
8560
8f5201ae
PE
8561 * composite.c (composition_compute_stop_pos): Rename local to
8562 avoid shadowing.
b246f932
PE
8563 (composition_reseat_it): Remove unused locals.
8564 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8565 (composition_update_it): Mark var as initialized.
11b61122
PE
8566 (find_automatic_composition): Mark vars as initialized,
8567 with a FIXME (Bug#8290).
8f5201ae 8568
760fbc2c
PE
8569 character.h: Rename locals to avoid shadowing.
8570 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8571 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8572 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8573 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8574 to avoid shadowing.
8575
ff08eb85
PE
8576 * textprop.c (property_change_between_p): Remove; unused.
8577
fc7bf025
PE
8578 * intervals.c (interval_start_pos): Now static.
8579
235d7abc
PE
8580 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8581
44f230aa
SM
8582 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8583 Rename locals to avoid shadowing.
3e7d6594 8584
50060332
PE
8585 * sound.c (wav_play, au_play, Fplay_sound_internal):
8586 Fix pointer signedness.
d01f234b 8587 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8588 (wav_play): Initialize a variable to 0, to prevent undefined
8589 behavior (Bug#8278).
50060332 8590
c4fc4e30
PE
8591 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8592
918436ed
PE
8593 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8594
c939f91b
PE
8595 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8596 clobbering (Bug#8298).
b9c7f648
PE
8597 * sysdep.c (sys_subshell): Likewise.
8598 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8599
6bd8c144
PE
8600 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8601 This should get cleaned up, so that child_setup has the
8602 same signature on all platforms.
8603
7710357c 8604 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8605 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8606
c59da222
CY
86072011-03-22 Chong Yidong <cyd@stupidchicken.com>
8608
8609 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8610 not to be necessary, and produces flickering.
8611
66b87493
GM
86122011-03-20 Glenn Morris <rgm@gnu.org>
8613
8614 * config.in: Remove file.
8615
45b6f6d5
JB
86162011-03-20 Juanma Barranquero <lekktu@gmail.com>
8617
8618 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8619 are now in src/globals.h.
8620 (syms_of_minibuf): Remove spurious & from previous change.
8621
cd394be1 86222011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8623
8624 * minibuf.c (completing-read-function): New variable.
8625 (completing-read-default): Rename from completing-read.
8626 (completing-read): Call completing-read-function.
8627
b14e3e21
CY
86282011-03-19 Juanma Barranquero <lekktu@gmail.com>
8629
8630 * xfaces.c (Fx_load_color_file):
8631 Read color file from absolute filename (bug#8250).
8632
f2b726e6
JB
86332011-03-19 Juanma Barranquero <lekktu@gmail.com>
8634
8635 * makefile.w32-in: Update dependencies.
8636
09f6ff02
EZ
86372011-03-17 Eli Zaretskii <eliz@gnu.org>
8638
8639 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8640
29a6015a
PE
86412011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8642
a3a6c54e
PE
8643 Fix more problems found by GCC 4.5.2's static checks.
8644
b766f867
PE
8645 * process.c (make_serial_process_unwind, send_process_trap):
8646 (sigchld_handler): Now static.
8647
be02381c
PE
8648 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8649 That way, the code declares only the vars that it needs.
8650 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8651 * s/cygwin.h (PTY_ITERATION): Likewise.
8652 * s/darwin.h (PTY_ITERATION): Likewise.
8653 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8654
57048744
PE
8655 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8656 * process.c (allocate_pty): Don't declare stb unless it's needed.
8657
7914961c 8658 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8659 (CONSTANTLIM): Remove; unused.
8660 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8661 Define only if needed.
7914961c 8662
b3967b18
PE
8663 * unexelf.c (unexec): Name an expression,
8664 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8665 Use a different way to cause a compilation error if anyone uses
8666 n rather than nn, a way that does not involve shadowing.
73366a00 8667 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8668
29a6015a
PE
8669 * deps.mk (unexalpha.o): Remove; unused.
8670
43cfc33e 8671 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8672 * unexec.h: New file.
ce701a33
PE
8673 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8674 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8675 Depend on unexec.h.
8676 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8677 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8678 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8679 Change as necessary to match prototype in unexec.h.
ce701a33 8680
01f44d5a
PE
8681 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8682 shadowing.
4f63c6bb 8683 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8684
a6670b0b
PE
8685 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8686 Rename locals to avoid shadowing.
8687
cef2010d 8688 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8689 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8690
d4d7173a
PE
8691 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8692
f08b802a
PE
8693 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8694 warning when compiling print.c.
8695
3ddb0639
PE
8696 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8697 instead of using an uninitialized var.
5ad03b97 8698 (font_sort_entities): Mark var as initialized.
3ddb0639 8699
170a2692
PE
8700 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8701
e663c700
PE
8702 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8703 pointers to constants.
89bc529a 8704 (font_parse_fcname): Remove unused vars.
7b81e2d0 8705 (font_delete_unmatched): Now static.
ea838e10 8706 (font_get_spec): Remove; unused.
13a547c6
PE
8707 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8708 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8709 Rename or move locals to avoid shadowing.
e663c700 8710
2a80c887 8711 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8712 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8713
1384fa33 8714 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8715 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8716
8b2c52e9
PE
8717 * alloc.c (mark_backtrace): Move decl from here ...
8718 * lisp.h: ... to here, so that it can be checked.
8719
475545b5 8720 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8721 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8722 (lisp_indirect_variable): Name an expression,
8723 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8724 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8725
b1349114 8726 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8727 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8728 Use const pointer when appropriate.
b1349114 8729
a2928364
PE
8730 * lisp.h (get_system_name, get_operating_system_release):
8731 Move decls here, to check interfaces.
8732 * process.c (get_operating_system_release): Move decl to lisp.h.
8733 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8734 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8735 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8736 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8737 (Fformat_time_string, Fencode_time, Finsert_char):
8738 (Ftranslate_region_internal, Fformat):
8739 Rename or remove local vars to avoid shadowing.
9710023e 8740 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8741
a415e694
PE
8742 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8743 avoid shadowing.
8744
8ef4622d
PE
8745 * lisp.h (eassert): Check that the argument compiles, even if
8746 ENABLE_CHECKING is not defined.
8747
946f9a5b
PE
8748 * data.c (Findirect_variable): Name an expression, to avoid
8749 gcc -Wbad-function-cast warning.
112396d6 8750 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8751 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8752 (Fmake_variable_buffer_local, Fmake_local_variable):
8753 Mark variables as initialized.
52746918 8754 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8755
e5aab7e7 8756 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8757 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8758 Rename locals to avoid shadowing.
dff45157
PE
8759 (mark_stack): Move local variables into the #ifdef region where
8760 they're used.
7bc26fdb
PE
8761 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8762 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8763 needed otherwise.
8764 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8765 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8766 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8767
e5aab7e7
PE
8768 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8769 avoids undefined behavior in theory.
8770
4da60324
PE
8771 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8772
88043301
PE
8773 Use functions, not macros, for up- and down-casing (Bug#8254).
8774 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8775 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8776 to use the following functions instead of these macros.
8777 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8778 EMACS_INT, since callers assume the returned value fits in int.
8779 (upcase1): Likewise, for UPCASE_TABLE.
8780 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8781 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8782 the race-condition problem in the old DOWNCASE.
88043301 8783
19ed5445
PE
8784 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8785 Rename locals to avoid shadowing.
8786 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8787 (regex_compile, re_search_2, re_match_2_internal):
8788 Remove unused local vars.
952db0d7
PE
8789 (FREE_VAR): Rewrite so as not to use empty "else",
8790 which gcc can warn about.
da053e48 8791 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8792 (RETALLOC_IF): Define only if needed.
8793 (WORDCHAR_P): Likewise. This one is never needed, but is used
8794 only in a comment talking about a compiler bug, so put inside
8795 the #if 0 of that comment.
8796 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8797 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8798 Remove; unused.
19ed5445 8799
1f3561e4 8800 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8801 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8802 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8803
ded6f8f7
PE
8804 * search.c (simple_search): Remove unused var.
8805
dbd37a95
PE
8806 * dired.c (compile_pattern): Move decl from here ...
8807 * lisp.h: ... to here, so that it can be checked.
8808 (struct re_registers): New forward decl.
8809
7e47afad
PE
8810 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8811
85f24f61
PE
8812 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8813 All uses changed.
8814 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8815 Rename locals to avoid shadowing.
5671df8f 8816 (Fvertical_motion): Mark locals as initialized.
85f24f61 8817
181aa2be 8818 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8819 (casify_region): Mark local as initialized.
181aa2be 8820
930d429c
PE
8821 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8822
7082eac6
PE
8823 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8824 New macros, so that the caller can use some names other than
8825 gcpro1, gcpro2, etc.
8826 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8827 of the new macros.
8828 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8829 argument, for consistency with GCPRO2_VAR, etc: it is now the
8830 prefix of the variable, not the variable itself. All uses
8831 changed.
38b2c076
PE
8832 * dired.c (directory_files_internal, file_name_completion):
8833 Rename locals to avoid shadowing.
8834
15206ed9
PE
8835 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8836 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8837 dired.c's scmp function, had undefined behavior.
8838 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8839 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8840 * buffer.h: ... to here, because these macros use current_buffer,
8841 and the new implementation with inline functions needs to have
8842 current_buffer in scope now, rather than later when the macros
8843 are used.
8844 (downcase, upcase1): New static inline functions.
8845 (DOWNCASE, UPCASE1): Reimplement using these functions.
8846 This avoids undefined behavior in expressions like
8847 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8848 from race conditions in accessing the global variables
8849 case_temp1 and case_temp2.
8850 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8851 * lisp.h (case_temp1, case_temp2): Remove their decls.
8852 * character.h (ASCII_CHAR_P): Move from here ...
8853 * lisp.h: ... to here, so that the inline functions mentioned
8854 above can use them.
8855
4a6bea26
PE
8856 * dired.c (directory_files_internal_unwind): Now static.
8857
f14b7e14
PE
8858 * fileio.c (file_name_as_directory, directory_file_name):
8859 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8860 Now static.
2893f146
PE
8861 (file_name_as_directory): Use const pointers when appropriate.
8862 (Fexpand_file_name): Likewise. In particular, newdir might
8863 point at constant storage, so make it a const pointer.
fd4ead52 8864 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8865 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8866 signedness issues.
f839df0c
PE
8867 (Fset_file_times, Finsert_file_contents, auto_save_error):
8868 Rename locals to avoid shadowing.
f14b7e14 8869
5716756e 8870 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8871 (Ftry_completion, Fall_completions): Rename or remove locals
8872 to avoid shadowing.
5716756e 8873
b4c3046a
PE
8874 * marker.c (bytepos_to_charpos): Remove; unused.
8875
b45db522
PE
8876 * lisp.h (verify_bytepos, count_markers): New decls,
8877 so that gcc does not warn that these functions aren't declared.
8878
85876d07
PE
8879 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8880 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8881 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8882 (copy_text): Remove unused local var.
85876d07 8883
03d78a21 8884 * filelock.c (within_one_second): Now static.
b3dd38ab 8885 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8886
5df8f01b
PE
8887 * buffer.c (fix_overlays_before): Mark locals as initialized.
8888 (fix_start_end_in_overlays): Likewise. This function should be
8889 simplified by using pointers-to-pointers, but that's a different
8890 matter.
b1d876f1 8891 (switch_to_buffer_1): Now static.
8f54f30a
PE
8892 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8893 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8894
a70072c9 8895 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8896 Fix pointer signedness issue.
edced198
PE
8897 (sys_subshell): Mark local as volatile if checking for lint,
8898 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8899 (MAXPATHLEN): Define only if needed.
a70072c9 8900
a0977c44
PE
8901 * process.c (serial_open, serial_configure): Move decls from here ...
8902 * systty.h: ... to here, so that they can be checked.
8903
a884fdcc
PE
8904 * fns.c (get_random, seed_random): Move extern decls from here ...
8905 * lisp.h: ... to here, so that they can be checked.
8906
604efe86 8907 * sysdep.c (reset_io): Now static.
b8950c94 8908 (wait_for_termination_signal): Remove; unused.
604efe86 8909
38fc62d9
PE
8910 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8911 (copy_keymap_item, append_key, push_text_char_description):
8912 Now static.
1004a21a 8913 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8914 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8915 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8916 (describe_map_tree):
8917 Rename locals to avoid shadowing.
38fc62d9 8918
2f2650da
PE
8919 * keyboard.c: Declare functions static if they are not used elsewhere.
8920 (echo_char, echo_dash, cmd_error, top_level_2):
8921 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8922 (read_char, kbd_buffer_get_event, make_lispy_position):
8923 (make_lispy_event, make_lispy_movement, apply_modifiers):
8924 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8925 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8926 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8927 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8928 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8929
a053e86c 8930 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8931 (mark_kboards): Move decl here ...
8932 * alloc.c (mark_kboards): ... from here.
a053e86c 8933
4752793e
PE
8934 * lisp.h (force_auto_save_soon): New decl.
8935
74f10ca7 8936 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8937 (DEFINE_DUMMY_FUNCTION): New macro.
8938 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8939 Use it.
c03cd23f
PE
8940 (main): Add casts to avoid warnings
8941 if GCC considers string literals to be constants.
74f10ca7 8942
022e70d4
PE
8943 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8944
59d6fe83
PE
8945 * dbusbind.c: Pointer signedness fixes.
8946 (xd_signature, xd_append_arg, xd_initialize):
8947 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8948 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8949 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8950 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8951
78320123
PE
8952 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8953 if GCC considers string literals to be constants.
49cebcca 8954 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8955
35ac2a97
SM
89562011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8957
fb103ca9
SM
8958 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8959 (print_preprocess, print_object): New macro to fix last change.
8960
35ac2a97
SM
8961 * print.c (print_preprocess): Don't forget font objects.
8962
62973b41
JB
89632011-03-16 Juanma Barranquero <lekktu@gmail.com>
8964
8965 * emacs.c (USAGE3): Doc fixes.
8966
0e48bb22
AS
89672011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8968
8969 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8970 structure.
8971
7684e57b
JB
89722011-03-14 Juanma Barranquero <lekktu@gmail.com>
8973
8974 * lisp.h (VWindow_system, Qfile_name_history):
8975 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8976 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8977 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8978
8979 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8980 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8981
8982 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8983 * w32console.c (detect_input_pending, read_input_pending)
8984 (encode_terminal_code):
8985 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8986 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8987 (w32_system_caret_y, Qfile_name_history):
8988 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8989 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8990 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8991 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8992 * w32proc.c (Qlocal, report_file_error):
8993 * w32term.c (Vwindow_system, updating_frame):
8994 * w32uniscribe.c (initialized, uniscribe_font_driver):
8995 Remove unneeded extern declarations.
8996
2aa46d6c
CY
89972011-03-14 Chong Yidong <cyd@stupidchicken.com>
8998
c96bbc66 8999 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9000
cffc6f3b
CY
90012011-03-13 Chong Yidong <cyd@stupidchicken.com>
9002
9003 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9004 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9005 These macros can no longer be used for assignment.
9006
44f230aa
SM
9007 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9008 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9009 (record_buffer_markers, fetch_buffer_markers): New functions for
9010 recording and fetching special buffer markers.
9011 (set_buffer_internal_1, set_buffer_temp): Use them.
9012
9013 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9014
9015 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9016
9017 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9018 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9019
9020 * xdisp.c (hscroll_window_tree):
9021 (reconsider_clip_changes): Use PT instead of BUF_PT.
9022
d251f04b
EZ
90232011-03-13 Eli Zaretskii <eliz@gnu.org>
9024
9025 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9026 $(EMACS_ROOT)/lib/intprops.h.
9027
f0c77cd1
PE
90282011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9029
3eca4629
PE
9030 Fix more problems found by GCC 4.5.2's static checks.
9031
7c86ee98
PE
9032 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9033 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9034 (xg_free_frame_widgets): Make it clear that a local variable is
9035 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9036 (gdk_window_get_screen): Make it clear that this macro is needed
9037 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9038 (int_gtk_range_get_value): New function, which avoids a diagnostic
9039 from gcc -Wbad-function-cast.
9040 (xg_set_toolkit_scroll_bar_thumb): Use it.
9041 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9042 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9043 (get_utf8_string, xg_get_file_with_chooser):
9044 Rename locals to avoid shadowing.
9045 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9046
41729b81
PE
9047 * xgselect.c (xg_select): Remove unused var.
9048
f0c77cd1
PE
9049 * image.c (four_corners_best): Mark locals as initialized.
9050 (gif_load): Initialize transparent_p to zero (Bug#8238).
9051 Mark another local as initialized.
ec6cf4c6 9052 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9053
ce0ad53d 9054 * image.c (clear_image_cache): Now static.
d5d5a617 9055 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9056 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9057 (x_edge_detection): Remove unnecessary cast that
9058 gcc -Wbad-function-cast diagnoses.
2037898d 9059 (gif_load): Fix pointer signedness.
6ae141d6
PE
9060 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9061 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9062
33383987 90632011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9064
d32df629
PE
9065 Improve quality of tests for time stamp overflow.
9066 For example, without this patch (encode-time 0 0 0 1 1
9067 1152921504606846976) returns the obviously-bogus value (-948597
9068 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9069 reports time overflow. See
9070 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9071 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9072 * editfns.c: Include limits.h and intprops.h.
9073 (TIME_T_MIN, TIME_T_MAX): New macros.
9074 (time_overflow): Move earlier, to before first use.
9075 (hi_time, lo_time): New functions, for an accurate test for
9076 out-of-range times.
9077 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9078 (Fget_internal_run_time): Don't assume time_t fits in int.
9079 (make_time): Use list2 instead of Fcons twice.
9080 (Fdecode_time): More accurate test for out-of-range times.
9081 (check_tm_member): New function.
9082 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9083 (lisp_time_argument): Don't rely on undefined left-shift and
9084 right-shift behavior when checking for time stamp overflow.
8be6f318 9085
fe31d94c
PE
9086 * editfns.c (time_overflow): New function, refactoring common code.
9087 (Fformat_time_string, Fdecode_time, Fencode_time):
9088 (Fcurrent_time_string): Use it.
9089
8be6f318
PE
9090 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9091 * dired.c (make_time): Move to ...
9092 * editfns.c (make_time): ... here.
9093 * systime.h: Note the move.
9094
09d9db2c 90952011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9096
126bc0dc
YM
9097 * fringe.c (update_window_fringes): Remove unused variables.
9098
c47cbdfd
YM
9099 * unexmacosx.c (copy_data_segment): Also copy __got section.
9100 (Bug#8223)
9101
7ac80be9
EZ
91022011-03-12 Eli Zaretskii <eliz@gnu.org>
9103
c96bbc66 9104 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9105 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9106 Constify `char *' arguments and their references according to
9107 prototypes in tparam.h.
9108
ecb0f94d 9109 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9110
7ac80be9
EZ
9111 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9112 Adapt all references accordingly.
9113
9114 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9115
ef1fd07e
TT
91162011-03-11 Tom Tromey <tromey@redhat.com>
9117
9118 * buffer.c (syms_of_buffer): Remove obsolete comment.
9119
7ef4b50c
EZ
91202011-03-11 Eli Zaretskii <eliz@gnu.org>
9121
9122 * termhooks.h (encode_terminal_code): Declare prototype.
9123
9124 * msdos.c (encode_terminal_code): Don't declare prototype.
9125
9126 * term.c (encode_terminal_code): Now external again, used by
9127 w32console.c and msdos.c.
9128
44f230aa
SM
9129 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9130 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9131
4b1ec863 91322011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9133
1714f52b 9134 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9135
4b1ec863
PE
9136 * fringe.c (update_window_fringes): Mark locals as initialized
9137 (Bug#8227).
9138 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9139
524c7aa6
PE
9140 * alloc.c (mark_fringe_data): Move decl from here ...
9141 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9142 to check its interface.
9143 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9144
a5c0af81 9145 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9146 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9147 (fontset_font): Mark local as initialized.
a9a06e0b 9148 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9149
b4716021
PE
9150 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9151
811e9bac 9152 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9153 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9154 (x_own_selection, Fx_disown_selection_internal): Rename locals
9155 to avoid shadowing.
9156 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9157
7e3ab302
PE
9158 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9159 so that the caller can use some name other than gcpro1.
9160 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9161 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9162 (Fx_backspace_delete_keys_p):
9163 Use them to avoid shadowing, and rename vars to avoid shadowing.
9164 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9165 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9166 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9167 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9168 Remove unused locals.
7e3ab302
PE
9169 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9170 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9171 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9172 macros.
f78faa98 9173
e2b13473
PE
9174 * xterm.h (x_mouse_leave): New decl.
9175
77f23912
PE
9176 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9177 Remove unused functions.
cdf4ba58
PE
9178 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9179 (x_calc_absolute_position): Now static.
7411c686 9180 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9181 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9182 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9183 unless they are used.
38d0b34a
PE
9184 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9185 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9186 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9187 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9188 (x_error_catcher, x_connection_closed, x_error_handler):
9189 (x_error_quitter, xembed_send_message, x_iconify_frame):
9190 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9191 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9192 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9193
44f230aa
SM
9194 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9195 Rename or move locals to avoid shadowing.
6b463e58 9196 (tty_defined_color, merge_face_heights): Now static.
5967d051 9197 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9198 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9199 does not deduce is never used uninitialized.
73719eba
PE
9200 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9201 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9202
426994c3 9203 * terminal.c (store_terminal_param): Now static.
5489860b 9204
032f1620 9205 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9206 (set_frame_menubar): Remove unused local.
d4323972 9207 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9208 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9209 since they might point to immutable storage.
281585b0
PE
9210 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9211 since it's unused otherwise.
032f1620 9212
367c19e5 9213 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9214 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9215 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9216 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9217 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9218 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9219 does not deduce are never used uninitialized.
70739cbe 9220
07b48fa9
PE
9221 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9222
8868a238 9223 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9224 * window.c (window_loop, size_window):
9225 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9226
7e5cf297 9227 * window.c (display_buffer): Now static.
d6550a9f
PE
9228 (size_window): Mark variables that gcc -Wuninitialized
9229 does not deduce are never used uninitialized.
a586633d
PE
9230 * window.h (check_all_windows): New decl, to forestall
9231 gcc -Wmissing-prototypes diagnostic.
5b555da1 9232 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9233
f6095868
PE
9234 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9235 shadowing.
9236 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9237 Include <limits.h>.
9238 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9239 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9240 (load_charset_map): Mark variables that gcc -Wuninitialized
9241 does not deduce are never used uninitialized.
53df7c11 9242 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9243
f38b440c
PE
9244 * coding.c (coding_set_source, coding_set_destination):
9245 Use "else { /* comment */ }" rather than "else /* comment */;"
9246 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9247 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9248 a block, when the outer 'i' will do.
9249 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9250 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9251 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9252 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9253 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9254 Rename locals to avoid shadowing.
9255 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9256 * coding.c (emacs_mule_char, encode_invocation_designation):
9257 Now static, since they're not used elsewhere.
413bb2db 9258 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9259 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9260 (decode_coding_emacs_mule): Mark variables that gcc
9261 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9262 (detect_coding_iso_2022): Initialize a local variable that might
9263 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9264 this initialization is needed. (Bug#8211)
5f58e762
PE
9265 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9266 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9267 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9268 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9269 Remove unused macros.
f38b440c 9270
232b38b9 9271 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9272 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9273 * character.c (string_count_byte8): Likewise.
232b38b9 9274
fb90da1b
PE
9275 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9276 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9277
fb93dbc2
PE
9278 * chartab.c (copy_sub_char_table): Now static, since it's not used
9279 elsewhere.
5c156ace
PE
9280 (sub_char_table_ref_and_range, char_table_ref_and_range):
9281 Rename locals to avoid shadowing.
bbcd0949 9282 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9283
7d3b3862 9284 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9285 (BIDI_BOB): Remove unused macro.
7d3b3862 9286
6be7d3da
PE
9287 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9288 deduce are never used uninitialized.
c2ed9c8b 9289 * term.c (encode_terminal_code): Likewise.
6be7d3da 9290
75f8807f 9291 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9292
50938595
PE
9293 * tparam.h: New file.
9294 * term.c, tparam.h: Include it.
9295 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9296 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9297 Move these decls to tparam.h, and make them agree with what
9298 is actually in tparam.c. The previous trick of using incompatible
9299 decls in different modules does not conform to the C standard.
9300 All callers of tparam changed to use tparam's actual API.
9301 * tparam.c (tparam1, tparam, tgoto):
9302 Use const pointers where appropriate.
9303
fbceeba2
PE
9304 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9305 * cm.h (struct cm): Likewise.
9306 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9307 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9308 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9309 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9310 (turn_on_face, init_tty): Likewise.
9311 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9312
7f3f1250
PE
9313 * term.c (term_mouse_position): Rename local to avoid shadowing.
9314
e6ca6543
PE
9315 * alloc.c (mark_ttys): Move decl from here ...
9316 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9317
c40f8d15
AS
93182011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9319
9320 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9321
cfe0661d
JB
93222011-03-09 Juanma Barranquero <lekktu@gmail.com>
9323
9324 * search.c (compile_pattern_1): Remove argument regp, unused since
9325 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9326 (compile_pattern): Don't pass it.
9327
0afb4571
J
93282011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9329
9330 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9331 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9332 for ! HAVE_GTK3.
9333 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9334
9335 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9336
9337 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9338 gdk_window_get_screen, gdk_window_get_geometry,
9339 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9340 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9341 (xg_get_pixbuf_from_pixmap): New function.
9342 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9343 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9344 Call xg_get_pixbuf_from_pixmap instead of
9345 gdk_pixbuf_get_from_drawable.
9346 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9347 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9348 (xg_check_special_colors): Use GtkStyleContext and its functions
9349 for HAVE_GTK3.
9350 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9351 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9352 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9353 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9354 Call gtk_widget_get_preferred_size.
0afb4571
J
9355 (xg_frame_resized): gdk_window_get_geometry only takes 5
9356 parameters.
44f230aa
SM
9357 (xg_win_to_widget, xg_event_is_for_menubar):
9358 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9359 (xg_set_widget_bg): New function.
9360 (delete_cb): New function.
895009e1 9361 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9362 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9363 (xg_set_background_color): Call xg_set_widget_bg.
9364 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9365 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9366 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9367 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9368 if ! HAVE_GTK3.
9369 (update_frame_tool_bar): Call gtk_widget_hide.
9370 (xg_initialize): Use GDK_KEY_g.
9371
9372 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9373 if ! HAVE_GTK3
9374 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9375
9376 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9377 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9378 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9379
1c2cc4ef
JB
93802011-03-08 Juanma Barranquero <lekktu@gmail.com>
9381
9382 * w32xfns.c (select_palette): Check success of RealizePalette against
9383 GDI_ERROR, not zero.
9384
33383987 9385See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9386
9387;; Local Variables:
9388;; coding: utf-8
aac0c6e3
MR
9389;; End:
9390
acaf905b 9391 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9392
9393 This file is part of GNU Emacs.
9394
9395 GNU Emacs is free software: you can redistribute it and/or modify
9396 it under the terms of the GNU General Public License as published by
9397 the Free Software Foundation, either version 3 of the License, or
9398 (at your option) any later version.
9399
9400 GNU Emacs is distributed in the hope that it will be useful,
9401 but WITHOUT ANY WARRANTY; without even the implied warranty of
9402 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9403 GNU General Public License for more details.
9404
9405 You should have received a copy of the GNU General Public License
9406 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.