Fix bug #11720 with cursor positioning in outline-mode and Org buffers.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2f07e6af
EZ
12012-06-16 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end. If
4 all the glyphs of the glyph row came from strings, and we have no
5 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
6 row.
7 (handle_face_prop): Use chunk-relative overlay string index when
8 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
9 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
10 the rightmost. (Bug#11720)
2f07e6af 11
29b83cec
AS
122012-06-16 Andreas Schwab <schwab@linux-m68k.org>
13
14 * category.h (CHAR_HAS_CATEGORY): Define as inline.
15 (CATEGORY_MEMBER): Enforce 1/0 value.
16 * category.c (_temp_category_set): Remove.
17
4c5501e9
EZ
182012-06-16 Eli Zaretskii <eliz@gnu.org>
19
20 * window.c (Fdelete_other_windows_internal)
21 (Fdelete_window_internal): Don't access frame's mouse highlight
22 info of the initial frame. (Bug#11677)
23
2b570124
PE
242012-06-14 Paul Eggert <eggert@cs.ucla.edu>
25
e93864f9
PE
26 * .gdbinit (xgetint): Fix recently-introduced paren typo.
27 Assume USE_2_TAGS_FOR_INTS.
28 (xreload): Adjust $tagmask width to match recent lisp.h change.
29
2b570124
PE
30 Simplify lisp.h in minor ways that should not affect code.
31 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
32 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
33 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
34 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
35 (INTTYPEBITS): New macro, for clarity.
36 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
37 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
38 now that USE_LSB_TAG is always defined.
39 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
40 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
41
81755f69
JB
422012-06-13 Juanma Barranquero <lekktu@gmail.com>
43
44 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
45
16192a57
GM
462012-06-13 Glenn Morris <rgm@gnu.org>
47
48 * s/bsd-common.h (BSD4_3):
49 * s/usg5-4-common.h (USG5_4): No longer define; unused.
50
646b5f55
AS
512012-06-13 Andreas Schwab <schwab@linux-m68k.org>
52
53 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
54 instead of union.
55 (XLI, XIL): Define.
56 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
57 them.
58 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
59 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
60 * alloc.c (widen_to_Lisp_Object): Removed.
61 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
62 * frame.c (delete_frame): Remove outdated comment.
63 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
64 USE_LISP_UNION_TYPE.
65 (Fw32_unregister_hot_key): Likewise.
66 (Fw32_toggle_lock_key): Likewise.
67 * w32menu.c (add_menu_item): Likewise.
68 (w32_menu_display_help): Use XIL instead of checking
69 USE_LISP_UNION_TYPE.
70 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
71 (init_heap): Likewise.
72 * w32term.c (w32_read_socket): Update comment.
73
1d3823c9
GM
742012-06-13 Glenn Morris <rgm@gnu.org>
75
c62ff706
GM
76 * s/usg5-4-common.h, src/s/unixware.h:
77 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
78
1d3823c9
GM
79 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
80
bfe3e0a2
PE
812012-06-13 Paul Eggert <eggert@cs.ucla.edu>
82
83 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
84 * alloc.c (make_number) [!defined make_number]:
85 Remove, as lisp.h always defines this now.
86 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
87 (roundup_size): Verify that it is a power of 2.
88 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
89 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
90 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
91 -DUSE_LSB_TAG=0, to override the automatically-selected default.
92 USE_LSB_TAG now is always defined to be either 0 or 1.
93 All uses changed.
94 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
95 code works fine either way, and efficiency is not a concern here,
96 as the union type is for debugging, not for production.
97 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
98 Use an inline function on all platforms when using the union type,
99 since this is simpler and 'static inline' can be used portably
100 within Emacs now.
101 (LISP_INITIALLY_ZERO): New macro.
102 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
103 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
104
45fa9c0f
GM
1052012-06-12 Glenn Morris <rgm@gnu.org>
106
b4492cba
GM
107 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
108
109 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 110
45fa9c0f
GM
111 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
112 Move BROKEN_SIGIO to configure.
113
114 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
115 Move NO_TERMIO to configure.
116
0e25d334
CY
1172012-06-12 Chong Yidong <cyd@gnu.org>
118
119 * image.c (imagemagick_load_image): Use MagickFlattenImage if
120 MagickMergeImageLayers is undefined. Use pixel pusher loop if
121 MagickExportImagePixels is undefined.
122
43682bb6
PE
1232012-06-12 Paul Eggert <eggert@cs.ucla.edu>
124
125 * image.c (imagemagick_load_image): Remove unused label.
126
a9be7d2b
GM
1272012-06-11 Glenn Morris <rgm@gnu.org>
128
129 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
130 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
131 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
132 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
133
3017f87f
SM
1342012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
135
136 * alloc.c (make_byte_code): New function.
137 (Fmake_byte_code): Use it. Don't purify here.
138 * lread.c (read1): Use it as well to avoid extra allocation.
139
1b9b4cf4
CY
1402012-06-11 Chong Yidong <cyd@gnu.org>
141
142 * image.c (imagemagick_load_image): Implement transparency.
143
95988fcf
AS
1442012-06-10 Andreas Schwab <schwab@linux-m68k.org>
145
146 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
147 account for preceding backslashes. (Bug#11663)
148
cd4eb164
CY
1492012-06-09 Chong Yidong <cyd@gnu.org>
150
151 * term.c: Support italics in capable terminals (Bug#9652).
152 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
153 (turn_on_face): Output using TS_enter_italic_mode if available.
154 Don't handle unused blinking and alt-charset cases.
155 (turn_off_face): Handle italic case; discard unused tty_blinking_p
156 and tty_alt_charset_p cases.
157 (tty_capable_p, init_tty): Support italics.
158
159 * termchar.h (struct tty_display_info): Add field for italics.
160 Remove unused blink field.
161
162 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
163 Handle slant.
164
165 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
166 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
167 tty_alt_charset_p. Add tty_italic_p.
168
ff88beb8
MA
1692012-06-09 Michael Albinus <michael.albinus@gmx.de>
170
171 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
172 dbus_type_is_basic if available.
173 (xd_extract_signed, xd_extract_unsigned): Rename from
174 extract_signed and extract_unsigned, respectively. Adapt callers.
175
44286096
CY
1762012-06-09 Chong Yidong <cyd@gnu.org>
177
1682701f
CY
178 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
179
44286096
CY
180 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
181 case (Bug#9752).
182
d86feb17
PE
1832012-06-08 Paul Eggert <eggert@cs.ucla.edu>
184
185 * xdisp.c (vmessage): Treat frame message as multibyte.
186 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
187 would generate the diagnostic "Making \302\247 buffer-local while
188 let-bound!".
189
d5c20fe8
EZ
1902012-06-08 Eli Zaretskii <eliz@gnu.org>
191
192 * dispnew.c (showing_window_margins_p): Undo last change, which
193 was done due to an inadvertent commit.
194 (adjust_frame_glyphs_for_frame_redisplay): Do call
195 showing_window_margins_p.
196
513749ee
SM
1972012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
198
199 * eval.c (Fmake_var_non_special): New primitive.
200 (syms_of_eval): Defsubr it.
201 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
202
d4a8f5c1
JB
2032012-06-08 Juanma Barranquero <lekktu@gmail.com>
204
205 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
206 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
207
8bbbc977
EZ
2082012-06-08 Eli Zaretskii <eliz@gnu.org>
209
210 * alloc.c (allocate_vectorlike): Fix last change.
211
f3372c87
DA
2122012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
213
214 Block-based vector allocation of small vectors.
215 * lisp.h (struct vectorlike_header): New field `nbytes',
216 adjust comment accordingly.
217 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
218 to denote vector blocks. Adjust users (live_vector_p,
219 mark_maybe_pointer, valid_lisp_object_p) accordingly.
220 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
221 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
222 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
223 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
224 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
225 (roundup_size): New constant.
226 (struct vector_block): New data type.
227 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 228 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
229 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
230 (sweep_vectors): New functions.
231 (allocate_vectorlike): Return `zero_vector' as the only vector of
232 0 items. Allocate new vector from block if vector size is less than
233 or equal to VBLOCK_BYTES_MAX.
234 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
235 (init_alloc_once): Add call to init_vectors.
236
4f18a4ed
SM
2372012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
238
239 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
240
86f158bc
PE
2412012-06-07 Paul Eggert <eggert@cs.ucla.edu>
242
243 * doprnt.c (doprnt): Truncate multibyte char correctly.
244 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
245 would mishandle a string argument "Xc" if X was a multibyte
246 character of length 2: it would truncate after X's first byte
247 rather than including all of X.
248
c5cfcbe0
CY
2492012-06-06 Chong Yidong <cyd@gnu.org>
250
251 * buffer.c (word_wrap): Doc fix.
252
c05cf390
PE
2532012-06-04 Paul Eggert <eggert@cs.ucla.edu>
254
255 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
256
0c3461de
GM
2572012-06-03 Glenn Morris <rgm@gnu.org>
258
259 * xdisp.c (tool-bar-style): Doc fix.
260
c71232db
UM
2612012-06-03 Ulrich Müller <ulm@gentoo.org>
262
263 * Makefile.in (PAXCTL): Define.
264 (temacs$(EXEEXT)): Disable memory randomization for the temacs
265 binary via PaX flags if the paxctl utility is available.
266 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
267 Restore PaX flags to their default. (Bug#11398)
268
383f7350
CY
2692012-06-03 Chong Yidong <cyd@gnu.org>
270
271 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
272 buffer (Bug#11226).
273
5f2c76c6
CY
2742012-06-03 Chong Yidong <cyd@gnu.org>
275
276 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
277 (note_mode_line_or_margin_highlight): If there is no help echo,
278 use mode-line-default-help-echo. Handle the case where the mouse
279 position is past the end of the mode line string.
280
281 * buffer.c (buffer_local_value_1): New function, split from
282 Fbuffer_local_value; can return Qunbound.
283 (Fbuffer_local_value): Use it.
284 (Vmode_line_format): Docstring tweaks.
285
773d47f6
PE
2862012-06-02 Paul Eggert <eggert@cs.ucla.edu>
287
288 * sysdep.c (system_process_attributes): Improve comment.
289
f2d6a3df
SM
2902012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
291
292 * keyboard.c: Export real-this-command to Elisp.
293 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
294 and DEFVAR it. Update all users.
295
63810350
PE
2962012-06-02 Paul Eggert <eggert@cs.ucla.edu>
297
7bd5c1f4
PE
298 * minibuf.c (Fassoc_string): Remove duplicate declaration.
299
63810350
PE
300 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
301 Convert pctcpu and pctmem to Lisp float properly.
302 Let the compiler fold better, as 100.0/0x8000 is exact.
303
a2821611
AS
3042012-06-02 Andreas Schwab <schwab@linux-m68k.org>
305
306 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
307 cons_block.
308
5fceba1d
PE
3092012-06-01 Paul Eggert <eggert@cs.ucla.edu>
310
311 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
312
c98ff5dd
DA
3132012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
314
315 For a 'struct window', replace some Lisp_Object fields to
316 bitfields where appropriate, remove unused fields.
317 * window.h (struct window): Remove unused 'last_mark_x' and
318 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
319 change it's type from Lisp_Object to bitfield.
320 Change type of 'force_start', 'optional_new_start',
321 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
322 fields from Lisp_Object to bitfield. Adjust users accordingly.
323
ca34e0be
PE
3242012-05-31 Paul Eggert <eggert@cs.ucla.edu>
325
326 Pacify gcc -Wdouble-precision when using Xaw.
327 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
328 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
329 Use 'float' consistently, rather than 'float' in most places
330 and 'double' in a couple of places.
331
efc00ab1 3322012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
333
334 * xdisp.c (handle_stop): Detect whether we have overlay strings
335 loaded by testing it->current.overlay_string_index to be
336 non-negative, instead of checking whether n_overlay_strings is
337 positive. (Bug#11587)
338
efc00ab1 3392012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
340
341 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
342
343 * doc.c (Fsubstitute_command_keys): Doc fix.
344
efc00ab1 3452012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
346
347 * search.c (search_buffer): Remove calls to
348 r_alloc_inhibit_buffer_relocation, as it is now called by
349 maybe_unify_char, which was the cause of relocation of buffer text
350 in bug#11519.
351
efc00ab1 3522012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
353
354 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
355 for the duration of call to load_charset, to avoid problems with
356 callers of maybe_unify_char that access buffer text through C
357 pointers.
358
359 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
360 decrement the inhibition flag, instead of just setting or
361 resetting it.
362
ba93a187
PE
3632012-05-31 Paul Eggert <eggert@cs.ucla.edu>
364
365 Remove obsolete '#define static' cruft.
366 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
367 This #undef was "temporary" in 2000; it is no longer needed
368 now that '#define static' has gone away.
369 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
370 (gray_bitmap_bits): Remove; no longer needed.
371 All uses replaced with definiens.
372 * xterm.c: Include "bitmaps/gray.xbm".
373
9e4bf381
PE
3742012-05-30 Paul Eggert <eggert@cs.ucla.edu>
375
376 Clean up __executable_start, monstartup when --enable-profiling.
377 The following changes affect the code only when profiling.
378 * dispnew.c (__executable_start): Rename from safe_bcopy.
379 Define only on platforms that need it.
380 * emacs.c: Include <sys/gmon.h> when profiling.
381 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
382 (__executable_start): Remove decl, since lisp.h does it now.
383 (safe_bcopy): Remove decl; no longer has that name.
384 (main): Coalesce #if into single bit of code, for simplicity.
385 Cast pointers to uintptr_t, since standard libraries want integers
386 and not pointers.
387 * lisp.h (__executable_start): New decl.
388
32d72c2f
GM
3892012-05-31 Glenn Morris <rgm@gnu.org>
390
391 * image.c (Fimagemagick_types): Doc fix.
392
baac5bc7
JM
3932012-05-30 Jim Meyering <meyering@redhat.com>
394
395 * callproc.c (Fcall_process_region): Include directory component
396 in mkstemp error message (Bug#11586).
397
72cb32cf
PE
3982012-05-30 Paul Eggert <eggert@cs.ucla.edu>
399
400 * alloc.c, lisp.h (make_pure_vector): Now static.
401
61b108cc
SM
4022012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
403
404 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
405 Move to byte-run.el.
406 (Fautoload): Do the hash-doc more carefully.
407 * data.c (Fdefalias): Purify definition, except for keymaps.
408 (Qdefun): Move from eval.c.
409 * lisp.h (Qdefun): Remove.
410 * lread.c (read1): Tiny simplification.
411
471fe23d
TN
4122012-05-29 Troels Nielsen <bn.troels@gmail.com>
413
934f3f58 414 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
415 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
416 Bug#9642, but explicitly check that the buffer the overlay would
417 be moved to is live and rearrange lines to make sure that errors
418 will not put the overlay in an inconsistent state.
419 (Fdelete_overlay): Cosmetics.
420
85d0efd1
EZ
4212012-05-28 Eli Zaretskii <eliz@gnu.org>
422
423 * w32term.c (my_bring_window_to_top): New function.
424 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
425 could be different from the original one.
426 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
427 (Bug#11513)
428
429 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
430 by calling BringWindowToTop.
431
432 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
433 (WM_EMACS_END): Increase by one.
434
da92a98c
PE
4352012-05-28 Paul Eggert <eggert@cs.ucla.edu>
436
437 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
438 This avoids undefined behavior that might cause the eassert
439 to not catch an out-of-range value.
440
74d1f848
JB
4412012-05-28 Juanma Barranquero <lekktu@gmail.com>
442
443 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
444 Update dependencies.
445
9e1a06fc
EZ
4462012-05-27 Eli Zaretskii <eliz@gnu.org>
447
448 * bidi.c (bidi_mirror_char): Fix last change.
449
f3dd7312
AS
4502012-05-27 Andreas Schwab <schwab@linux-m68k.org>
451
452 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
453 when referring to sectname field in printf format.
454
81899c91
PE
4552012-05-27 Paul Eggert <eggert@cs.ucla.edu>
456
57b81a9f
PE
457 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
458 Only r_alloc_inhibit_buffer_relocation needed to be added;
459 the others were already declared.
460
81899c91
PE
461 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
462 before checking whether it's out of range. Put the check inside
463 eassert. See
464 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
465
33017faf 4662012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
467
468 * callproc.c (Fcall_process): Restore a line that was accidentally
469 commented out in the 2011-02-13 change (bug#11547).
470
33017faf 4712012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
472
473 * lisp.h [REL_ALLOC]: Add prototypes for external functions
474 defined on ralloc.c.
475
476 * buffer.c [REL_ALLOC]: Remove prototypes of
477 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
478 they are now on lisp.h.
479
480 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
481
482 * search.c (search_buffer): Use it to inhibit relocation of buffer
483 text while re_search_2 is doing its job, because re_search_2 is
484 passed C pointers to buffer text. (Bug#11519)
485
23415acf
EZ
486 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
487 Update value to 24.
488
44e27368
EZ
489 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
490 state after an additional call to move_it_in_display_line_to, keep
491 the values of it->max_ascent and it->max_descent found for the
492 entire line.
493 (pos_visible_p): Revert the comparison against bottom_y to what it
494 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
495 (Bug#11464)
496
c1892f11
PE
4972012-05-26 Paul Eggert <eggert@cs.ucla.edu>
498
499 Fix coding-related core dumps with gcc -ftrapv.
500 The code was computing A - B, where A and B are pointers, and B is
501 random garbage. This can lead to core dumps on platforms that
502 have special pointer registers, and it also leads to core dumps on
503 x86-64 when compiled with gcc -ftrapv. The fix is to compute
504 A - B only when B is initialized properly.
505 * coding.c (coding_set_source, coding_set_destination): Return void.
506 (coding_change_source, coding_change_destinations): New functions,
507 with the old behaviors of coding_set_source and coding_set_destination.
508 All callers that need an offset changed to use these new functions.
509
eb7afdad
GM
5102012-05-26 Glenn Morris <rgm@gnu.org>
511
512 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
513
f12fdf02
EZ
5142012-05-26 Eli Zaretskii <eliz@gnu.org>
515
53a63be6 516 Extend mouse support on W32 text-mode console.
61b108cc
SM
517 * xdisp.c (draw_row_with_mouse_face):
518 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 519
eb3f6f01 520 * w32console.c: Include window.h.
61b108cc
SM
521 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
522 New functions.
eb3f6f01
EZ
523 (initialize_w32_display): Initialize mouse-highlight data.
524
53a63be6
EZ
525 * w32inevt.c: Include termchar.h and window.h.
526 (do_mouse_event): Support mouse-autoselect-window. When the mouse
527 moves, call note_mouse_highlight. If help_echo changed, call
528 gen_help_event to produce help-echo message in the echo area.
529 Call clear_mouse_face if mouse_face_hidden is set in the mouse
530 highlight info.
531
4cfd81f6
PE
5322012-05-26 Paul Eggert <eggert@cs.ucla.edu>
533
534 * lread.c (read1): Simplify slightly to avoid an overflow warning
535 with GCC 4.7.0 on x86-64.
536
4446092a
EZ
5372012-05-26 Eli Zaretskii <eliz@gnu.org>
538
539 * bidi.c (bidi_mirror_char): Revert last change: an int is
540 definitely wide enough here.
541
42b2a986 5422012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 543
42b2a986 544 Fix integer width and related bugs (Bug#9874).
eb106a49 545 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
546 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
547 (string_bytes, check_sblock, allocate_string_data):
548 (compact_small_strings, Fmake_bool_vector, make_string)
549 (make_unibyte_string, make_multibyte_string)
550 (make_string_from_bytes, make_specified_string)
551 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
552 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
553 (mark_vectorlike):
554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
555 (allocate_pseudovector):
556 Use int, not EMACS_INT, where int is wide enough.
557 (inhibit_garbage_collection, Fgarbage_collect):
558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
559 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
560 int might not be wide enough.
561 (bidi_cache_search, bidi_cache_find, bidi_init_it)
562 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
563 (bidi_at_paragraph_end, bidi_find_paragraph_start)
564 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
565 (bidi_level_of_next_char, bidi_move_to_visually_next):
566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
567 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
568 (Fkill_buffer, Fset_buffer_major_mode)
569 (advance_to_char_boundary, Fbuffer_swap_text)
570 (Fset_buffer_multibyte, overlays_at, overlays_in)
571 (overlay_touches_p, struct sortvec, record_overlay_string)
572 (overlay_strings, recenter_overlay_lists)
573 (adjust_overlays_for_insert, adjust_overlays_for_delete)
574 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
575 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
576 (Foverlay_recenter, last_overlay_modification_hooks_used)
577 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
579 (validate_region): Omit unnecessary test for b <= e,
580 since that's guaranteed by the previous test.
d311d28c
PE
581 (adjust_overlays_for_delete): Avoid pos + length overflow.
582 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
583 (report_overlay_modification):
584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
585 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
586 Omit pointer cast, which isn't needed anyway, and doesn't work
587 after the EMACS_INT -> ptrdiff_t change.
02481186 588 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
589 * buffer.h: Adjust decls to match defn changes elsewhere.
590 (struct buffer_text, struct buffer):
591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
592 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
593 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
594 not int, to avoid needless 32-bit limit on 64-bit hosts.
595 (exec_byte_code): Use tighter memory-full test, one that checks
596 for alloca overflow. Don't compute the address of the object just
597 before an array, as that's not portable. Use EMACS_INT, not
598 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
599 * callint.c (Fcall_interactively):
600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
601 * callproc.c (call_process_kill, Fcall_process):
602 Don't assume pid_t fits into an Emacs fixnum.
603 (call_process_cleanup, Fcall_process, child_setup):
604 Don't assume pid_t fits into int.
605 (call_process_cleanup, Fcall_process, delete_temp_file)
606 (Fcall_process_region):
607 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
608 (Fcall_process): Simplify handling of volatile integers.
609 Use int, not EMACS_INT, where int will do.
610 * casefiddle.c (casify_object, casify_region, operate_on_word)
611 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
613 (casify_object): Avoid integer overflow when overallocating buffer.
614 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 615 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
616 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
617 * category.h (CATEGORYP): Don't assume arg is nonnegative.
618 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
619 integers are now checked earlier. All uses replaced with XINT.
620 (ccl_driver):
621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
622 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
623 (ccl_driver, Fregister_code_conversion_map):
624 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
625 (resolve_symbol_ccl_program): Check that vector header is in range.
626 Always copy the vector, so that we can check its contents reliably
627 now rather than having to recheck each instruction as it's being
628 executed. Check that vector words fit in 'int'.
629 (ccl_get_compiled_code, Fregister_ccl_program)
630 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
631 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
632 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
633 contents are in range.
634 (Fccl_execute_on_string): Check that status is in range.
635 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
636 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
637 Accept and return EMACS_INT, not int, because callers can pass values
638 out of 'int' range.
639 (c_string_width, strwidth, lisp_string_width, chars_in_text)
640 (multibyte_chars_in_text, parse_str_as_multibyte)
641 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
642 (str_as_unibyte, str_to_unibyte, string_count_byte8)
643 (string_escape_byte8, Fget_byte):
644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 645 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
646 avoid mishandling large integers.
647 * character.h: Adjust decls to match defn changes elsewhere.
648 * charset.c (load_charset_map_from_file, find_charsets_in_text)
649 (Ffind_charset_region):
650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
651 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
652 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 653 Don't assume fixnum fits in int.
d311d28c
PE
654 (load_charset_map_from_vector, Fmap_charset_chars):
655 Remove now-unnecessary CHECK_NATNUMs.
656 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
657 Don't rely on undefined behavior with signed left shift overflow.
658 Don't assume unsigned int fits into fixnum, or that fixnum fits
659 into unsigned int. Don't require max_code to be a valid fixnum;
660 that's not true for gb10830 4-byte on a 32-bit host. Allow
661 invalid_code to be a cons, for the same reason. Require code_offset
662 to be a character. Avoid int overflow if max_char is close
663 to INT_MAX.
664 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
665 this is intended anyway and avoids some undefined behavior.
666 (load_charset_map): Pass unsigned, not int, as 2nd arg of
667 INDEX_TO_CODE_POINT, as that's what it expects.
668 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
669 * charset.h (DECODE_CHAR): Return int, not unsigned;
670 this is what was intended anyway, and it avoids undefined behavior.
671 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
672 integer-overflow issues.
673 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
674 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
675 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
676 * chartab.c (Fmake_char_table, Fset_char_table_range)
677 (uniprop_get_decoder, uniprop_get_encoder):
678 Don't assume fixnum fits in int.
679 * cmds.c (move_point): New function, that does the gist of
680 Fforward_char and Fbackward_char, but does so while checking
681 for integer overflow more accurately.
c96e5d6a 682 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
683 (Fforward_line, Fend_of_line, internal_self_insert)
684 (internal_self_insert):
685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
686 Fix a FIXME, by checking for integer overflow when calculating
687 target_clm and actual_clm.
688 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 689 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
690 (ASSURE_DESTINATION, coding_alloc_by_realloc)
691 (coding_alloc_by_making_gap, alloc_destination)
692 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
693 (encode_coding_utf_16, detect_coding_emacs_mule)
694 (decode_coding_emacs_mule, encode_coding_emacs_mule)
695 (detect_coding_iso_2022, decode_coding_iso_2022)
696 (encode_invocation_designation, encode_designation_at_bol)
697 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
698 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
699 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
700 (encode_coding_ccl, encode_coding_raw_text)
701 (detect_coding_charset, decode_coding_charset)
702 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
703 (produce_composition, produce_charset, produce_annotation)
704 (decode_coding, handle_composition_annotation)
705 (handle_charset_annotation, consume_chars, decode_coding_gap)
706 (decode_coding_object, encode_coding_object, detect_coding_system)
707 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
708 (code_convert_region, code_convert_string)
8f50130c
PE
709 (Fdefine_coding_system_internal)
710 (coding_set_source, coding_set_destination):
d311d28c
PE
711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
712 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
713 (Fdefine_coding_system_internal):
714 Don't assume fixnums fit in int.
715 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 716 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
717 (Funencodable_char_position, Fcheck_coding_systems_region)
718 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 720 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 721 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 722 Don't access memory outside of the args array.
d311d28c 723 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
724 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
725 result of ENCODE_CHAR.
d311d28c
PE
726 * coding.h: Adjust decls to match defn changes elsewhere.
727 (struct coding_system):
728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
729 * composite.c (get_composition_id, find_composition)
730 (run_composition_function, update_compositions)
731 (compose_text, composition_gstring_put_cache)
732 (composition_gstring_p, composition_gstring_width)
733 (fill_gstring_header, fill_gstring_body, autocmp_chars)
734 (composition_compute_stop_pos, composition_reseat_it)
735 (composition_update_it, struct position_record)
736 (find_automatic_composition, composition_adjust_point)
737 (Fcomposition_get_gstring, Ffind_composition_internal):
738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
739 (update_compositions):
740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
741 * composite.h: Adjust decls to match defn changes elsewhere.
742 (struct composition):
743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
744 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
745 Do not attempt to compute the address of the object just before a
746 buffer; this is not portable.
747 (Faref, Faset):
748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
749 (Faset): Use int, not EMACS_INT, where int is wide enough.
750 (Fstring_to_number): Don't assume fixnums fit in int.
751 (Frem): Don't assume arg is nonnegative.
752 * dbusbind.c (xd_append_arg): Check for integers out of range.
753 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 754 (extract_signed, extract_unsigned): New functions.
243e0530
PE
755 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
756 (xd_get_connection_references): Return ptrdiff_t, not int.
757 All uses changed.
758 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
759 (xd_read_message_1):
760 Use int, not unsigned, where the dbus API uses int.
761 (Fdbus_message_internal): Don't overflow mtype.
762 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
763 * dired.c (directory_files_internal, file_name_completion, scmp)
764 (file_name_completion_stat):
765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
766 (file_name_completion): Don't overflow matchcount.
767 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
768 * dispextern.h: Adjust decls to match defn changes elsewhere.
769 (struct text_pos, struct glyph, struct bidi_saved_info)
770 (struct bidi_string_data, struct bidi_it, struct composition_it)
771 (struct it):
772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
773 (struct display_pos, struct composition_it, struct it):
774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
775 * dispnew.c (increment_matrix_positions)
776 (increment_row_positions, mode_line_string)
777 (marginal_area_string):
778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 779 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
781 (duration_to_sec_usec): New function, to check for overflow better.
782 (Fsleep_for, sit_for): Use it.
783 * doc.c (get_doc_string, store_function_docstring):
784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
785 (get_doc_string, Fsnarf_documentation):
786 Use int, not EMACS_INT, where int is wide enough.
787 (get_doc_string):
788 Use SAFE_ALLOCA, not alloca.
789 Check for overflow when converting EMACS_INT to off_t.
790 * doprnt.c (doprnt):
791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
792 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
793 Don't assume uid_t fits into fixnum.
794 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
795 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
796 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
797 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
798 (general_insert_function)
799 (Finsert_char, make_buffer_string, make_buffer_string_both)
800 (update_buffer_properties, Fbuffer_substring)
801 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
802 (Fsubst_char_in_region, check_translation)
803 (Ftranslate_region_internal, save_restriction_restore, Fformat)
804 (transpose_markers, Ftranspose_regions):
805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
806 (clip_to_bounds): Move to lisp.h as an inline function).
807 (Fconstrain_to_field): Don't assume integers are nonnegative.
808 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
809 (Fsubst_char_in_region, Fsave_restriction):
810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
811 (Femacs_pid): Don't assume pid_t fits into fixnum.
812 (lo_time): Use int, not EMACS_INT, when int suffices.
813 (lisp_time_argument): Check for usec out of range.
814 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
815 (Fuser_login_name, Fuser_full_name): Signal an error
816 if a uid argument is out of range, rather than relying on
817 undefined behavior.
c8d5c857
PE
818 (Fformat_time_string): Remove now-unnecessary check.
819 lisp_time_argument checks for out-of-range usec now.
243e0530 820 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
821 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
822 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
823 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
824 (init_cmdargs, Fdump_emacs):
825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
826 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
827 the bottom (typically) 32 bits of the fixnum.
828 * eval.c (specpdl_size, call_debugger):
829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
830 (when_entered_debugger, Fbacktrace_debug):
831 Don't assume fixnum can fit in int.
832 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
833 the object just before a buffer; this is not portable.
834 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
835 (grow_specpdl, unbind_to):
836 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
837 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
838 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 839 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
840 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
841 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
843 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
844 (a_write, e_write):
845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
846 (Fcopy_file, non_regular_nbytes, read_non_regular)
847 (Finsert_file_contents):
848 Use int, not EMACS_INT, where int is wide enough.
849 (READ_BUF_SIZE): Verify that it fits in int.
850 (Finsert_file_contents): Check that counts are in proper range,
851 rather than assuming fixnums fit into ptrdiff_t etc.
852 Don't assume fixnums fit into int.
125b3835 853 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
854 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
855 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
856 (string_char_to_byte, string_byte_to_char)
857 (string_make_multibyte, string_to_multibyte)
858 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
859 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
860 (substring_both, Fdelete, internal_equal, Ffillarray)
861 (Fclear_string, mapcar1)
862 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
863 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
864 (larger_vector, make_hash_table, maybe_resize_hash_table)
865 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
866 (Fmaphash, secure_hash):
867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
868 (concat): Check for string index and length overflow.
869 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
870 (Frequire):
871 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
872 (larger_vector): New API (vec, incr_min, size_max) replaces old
873 one (vec, new_size, init). This catches size overflow.
874 INIT was removed because it was always Qnil.
875 All callers changed.
876 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
877 the upper bound on a hash table index size.
878 (make_hash_table, maybe_resize_hash_table): Use it.
879 (secure_hash): Computer start_byte and end_byte only after
880 they're known to be in ptrdiff_t range.
881 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
882 (Ffont_get_glyphs, Ffont_at):
883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
884 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
885 (Flist_fonts, Fopen_font):
886 Don't assume fixnum can fit in int.
887 (check_gstring): Don't assume index can fit in int.
888 (font_match_p): Check that fixnum is a character, not a nonnegative
889 fixnum, since the later code needs to stuff it into an int.
890 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
891 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
892 conversion overflow issues.
893 (Fopen_font): Check for integer out of range.
894 (Ffont_get_glyphs): Don't assume index can fit in int.
895 * font.h: Adjust decls to match defn changes elsewhere.
896 * fontset.c (reorder_font_vector): Redo score calculation to avoid
897 integer overflow.
898 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
899 printmax_t, where ptrdiff_t is wide enough.
900 (Finternal_char_font):
901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
902 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
903 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
904 (Fset_frame_position, x_set_frame_parameters)
905 (x_set_line_spacing, x_set_border_width)
906 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
907 Check that fixnums are in proper range for system types.
908 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
909 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
910 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
911 Use SAFE_ALLOCA_LISP, not alloca.
912 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
913 intptr_t is wide enough.
914 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
915 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
916 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
917 Check for fixnum out of range.
918 * ftfont.c (ftfont_list): Don't assume index fits in int.
919 Check that fixnums are in proper range for system types.
920 (ftfont_shape_by_flt):
921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
922 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
924 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
925 Check that fixnums are in proper range for system types.
926 * gnutls.h: Adjust decls to match defn changes elsewhere.
927 * gtkutil.c (xg_dialog_run):
928 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
929 (update_frame_tool_bar):
930 Check that fixnums are in proper range for system types.
931 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 932 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
933 * indent.c (last_known_column, last_known_column_point):
934 (current_column_bol_cache):
935 (skip_invisible, current_column, check_display_width):
936 (check_display_width, scan_for_column, current_column_1)
937 (Findent_to, Fcurrent_indentation, position_indentation)
938 (indented_beyond_p, Fmove_to_column, compute_motion):
939 (Fcompute_motion, Fvertical_motion):
940 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
941 (last_known_column_modified): Use EMACS_INT, not int.
942 (check_display_width):
943 (Fcompute_motion):
944 Check that fixnums and floats are in proper range for system types.
945 (compute_motion): Don't assume index or fixnum fits in int.
946 (compute_motion, Fcompute_motion):
947 Use int, not EMACS_INT, when it is wide enough.
948 (vmotion): Omit local var start_hpos that is always 0; that way
949 we don't need to worry about overflow in expressions involving it.
950 * indent.h: Adjust decls to match defn changes elsewhere.
951 (struct position):
952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
953 Use int, not EMACS_INT, where int is wide enough.
954 Remove unused members ovstring_chars_done and tab_offset;
955 all uses removed.
956 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
957 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
958 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
959 (make_gap, copy_text, insert, insert_and_inherit)
960 (insert_before_markers, insert_before_markers_and_inherit)
961 (insert_1, count_combining_before, count_combining_after)
962 (insert_1_both, insert_from_string)
963 (insert_from_string_before_markers, insert_from_string_1)
964 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
965 (adjust_after_replace, adjust_after_insert, replace_range)
966 (replace_range_2, del_range, del_range_1, del_range_byte)
967 (del_range_both, del_range_2, modify_region)
968 (prepare_to_modify_buffer, signal_before_change)
969 (signal_after_change, Fcombine_after_change_execute):
970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
971 * intervals.c (traverse_intervals, rotate_right, rotate_left)
972 (balance_an_interval, split_interval_right, split_interval_left)
973 (find_interval, next_interval, update_interval)
974 (adjust_intervals_for_insertion, delete_node, delete_interval)
975 (interval_deletion_adjustment, adjust_intervals_for_deletion)
976 (static_offset_intervals, offset_intervals)
977 (merge_interval_right, merge_interval_left, make_new_interval)
978 (graft_intervals_into_buffer, temp_set_point_both)
979 (temp_set_point, set_point, adjust_for_invis_intang)
980 (set_point_both, move_if_not_intangible, get_property_and_range)
981 (get_local_map, copy_intervals, copy_intervals_to_string)
982 (compare_string_intervals, set_intervals_multibyte_1):
983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
984 * intervals.h: Adjust decls to match defn changes elsewhere.
985 (struct interval):
986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
987 * keyboard.c (this_command_key_count, this_single_command_key_start)
988 (before_command_key_count, before_command_echo_length, echo_now)
989 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
990 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
991 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
992 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
994 (last_non_minibuf_size, last_point_position, echo_truncate)
995 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
996 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
997 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
998 (stuff_buffered_input):
999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1000 (last_auto_save, command_loop_1, read_char):
1001 Use EMACS_INT, not int, to avoid integer overflow.
1002 (record_char): Avoid overflow in total_keys computation.
1003 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1004 * keyboard.h: Adjust decls to match defn changes elsewhere.
1005 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1006 (Fkey_description, Fdescribe_vector, Flookup_key):
1007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1008 (click_position): New function, to check that positions are in range.
1009 (Fcurrent_active_maps):
1010 (describe_command):
1011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1012 (Faccessible_keymaps, Fkey_description):
1013 (preferred_sequence_p):
1014 Don't assume fixnum can fit into int.
1015 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1016 Check for integer overflow in size calculations.
1017 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1018 avoid mishandling large integers.
1019 * lisp.h: Adjust decls to match defn changes elsewhere.
1020 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1021 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1022 (struct Lisp_Marker):
1023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1024 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1025 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1026 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1027 All callers changed.
1028 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1029 Assume the arg has valid form, since it always does.
1030 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1031 unsigned integer system type.
1032 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1033 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1035 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1036 (duration_to_sec_usec): New decl.
1037 * lread.c (read_from_string_index, read_from_string_index_byte)
1038 (read_from_string_limit, readchar, unreadchar, openp)
1039 (read_internal_start, read1, oblookup):
1040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1041 (Fload, readevalloop, Feval_buffer, Feval_region):
1042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1043 (openp): Check for out-of-range argument to 'access'.
1044 (read1): Use int, not EMACS_INT, where int is wide enough.
1045 Don't assume fixnum fits into int.
6efdadfd 1046 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1047 (read_filtered_event): Use duration_to_sec_usec
1048 to do proper overflow checking on durations.
d311d28c
PE
1049 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1050 in size calculation.
1051 (Fexecute_kbd_macro):
1052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1053 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1054 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1055 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1056 (set_marker_both, set_marker_restricted_both, marker_position)
1057 (marker_byte_position, Fbuffer_has_markers_at):
1058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1059 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1060 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1061 It now merely ensures that the menu is large enough, without
1062 necessarily growing it, as this avoids some integer overflow issues.
1063 All callers changed.
1064 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1066 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1067 Use SAFE_ALLOCA_LISP, not alloca.
1068 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1069 to EMACS_INT. Check that fixnums are in proper range for system types.
1070 * minibuf.c (minibuf_prompt_width, string_to_object)
1071 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1072 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1074 (get_minibuffer, read_minibuf_unwind):
1075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1076 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1077 this simplifies overflow checking. All callers changed.
1078 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1079 (Ftest_completion):
1080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1081 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1082 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1083 Check that fixnums are in proper range for system types.
1084 (Fx_create_frame, Fx_show_tip):
1085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1086 * nsfont.m (ns_findfonts, nsfont_list_family):
1087 Don't assume fixnum fits in long.
1088 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1090 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1091 wide enough.
17fdb222 1092 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1094 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1095 (PRINTDECLARE, PRINTPREPARE):
1096 (strout, print_string):
1097 (print, print_preprocess, print_check_string_charset_prop)
1098 (print_object):
1099 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1100 (PRINTDECLARE):
1101 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1103 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1104 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1105 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1106 (print_error_message): Use SAFE_ALLOCA, not alloca.
1107 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1108 (print_depth, new_backquote_output, print_number_index):
1109 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1110 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1111 (Fset_process_window_size, Fformat_network_address)
1112 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1113 (sigchld_handler):
d311d28c 1114 Check that fixnums are in proper range for system types.
d44287d4 1115 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1116 Check for process-ids out of pid_t range rather than relying on
1117 undefined behavior.
e4d81efc 1118 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1119 (Fformat_network_address, read_process_output, send_process)
1120 (Fprocess_send_region, status_notify):
1121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1122 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1123 (wait_reading_process_output, read_process_output, exec_sentinel):
1124 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1125 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1126 (Faccept_process_output): Use duration_to_sec_usec to do proper
1127 overflow checking on durations.
dde14581
PE
1128 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1129 Don't assume pid_t fits in int.
02481186
PE
1130 * process.h (struct Lisp_Process): Members tick and update_tick
1131 are now of type EMACS_INT, not int.
b62b53e8
PE
1132 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1133 configured --with-wide-int.
d311d28c
PE
1134 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1135 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1136 * search.c (looking_at_1, string_match_1):
1137 (fast_string_match, fast_c_string_match_ignore_case)
1138 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1139 (scan_newline, find_before_next_newline, search_command)
1140 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1141 (set_search_regs, wordify):
1142 (Freplace_match):
1143 (Fmatch_data):
1144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1145 (string_match_1, search_buffer, set_search_regs):
1146 (Fmatch_data):
1147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1148 (wordify): Check for overflow in size calculation.
1149 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1150 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1151 Check that fixnums are in proper range for system types.
1152 * sound.c (struct sound_device)
1153 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1155 (Fplay_sound_internal):
1156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1157 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1158 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1159 (Fparse_partial_sexp):
1160 Don't assume fixnums can fit in int.
1161 (struct lisp_parse_state, find_start_pos, find_start_value)
1162 (find_start_value_byte, find_start_begv)
1163 (update_syntax_table, char_quoted, dec_bytepos)
1164 (find_defun_start, prev_char_comend_first, back_comment):
1165 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1166 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1168 (Finternal_describe_syntax_value): Check that match_lisp is a
1169 character, not an integer, since the code stuffs it into int.
1170 (scan_words, scan_sexps_forward):
1171 Check that fixnums are in proper range for system types.
1172 (Fforward_word):
1173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1174 (scan_sexps_forward):
1175 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1176 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1177 * syntax.h: Adjust decls to match defn changes elsewhere.
1178 (struct gl_state_s):
1179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1180 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1181 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1182 * sysdep.c (wait_for_termination_1, wait_for_termination)
1183 (interruptible_wait_for_termination, mkdir):
1184 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1185 (emacs_read, emacs_write):
1186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1187 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1188 and double all fit in int.
d311d28c
PE
1189 * term.c (set_tty_color_mode):
1190 Check that fixnums are in proper range for system types.
1191 * termhooks.h (struct input_event):
1192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1193 * textprop.c (validate_interval_range, interval_of)
1194 (Fadd_text_properties, set_text_properties_1)
1195 (Fremove_text_properties, Fremove_list_of_text_properties)
1196 (Ftext_property_any, Ftext_property_not_all)
1197 (copy_text_properties, text_property_list, extend_property_ranges)
1198 (verify_interval_modification):
1199 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1200 (Fnext_single_char_property_change)
1201 (Fprevious_single_char_property_change):
1202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1203 (copy_text_properties):
1204 Check for integer overflow in index calculation.
d311d28c
PE
1205 * undo.c (last_boundary_position, record_point, record_insert)
1206 (record_delete, record_marker_adjustment, record_change)
1207 (record_property_change):
1208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1209 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1210 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1211 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1212 (Fx_hide_tip, Fx_file_dialog):
1213 * w32menu.c (set_frame_menubar):
1214 Use ptrdiff_t, not int, for consistency with rest of code.
1215 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1216 (select_window, Fdelete_other_windows_internal)
1217 (window_scroll_pixel_based, window_scroll_line_based)
1218 (Frecenter, Fset_window_configuration):
1219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1220 (Fset_window_hscroll, run_window_configuration_change_hook)
1221 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1222 (Fscroll_other_window, Frecenter):
d311d28c
PE
1223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1224 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1225 Don't assume fixnum fits in int.
1226 (Fset_window_scroll_bars):
1227 Check that fixnums are in proper range for system types.
1228 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1229 (string_pos, c_string_pos, number_of_chars, init_iterator)
1230 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1231 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1232 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1233 (face_before_or_after_it_pos, handle_invisible_prop)
1234 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1235 (display_prop_intangible_p, string_buffer_position_lim)
1236 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1237 (get_overlay_strings_1, get_overlay_strings)
1238 (iterate_out_of_display_property, forward_to_next_line_start)
1239 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1240 (get_next_display_element, set_iterator_to_next)
1241 (get_visually_first_element, compute_stop_pos_backwards)
1242 (handle_stop_backwards, next_element_from_buffer)
1243 (move_it_in_display_line_to, move_it_in_display_line)
1244 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1245 (add_to_log, message_dolog, message_log_check_duplicate)
1246 (message2, message2_nolog, message3, message3_nolog
1247 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1248 (current_message_1, truncate_echo_area, truncate_message_1)
1249 (set_message, set_message_1, store_mode_line_noprop)
1250 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1251 (text_outside_line_unchanged_p, check_point_in_composition)
1252 (reconsider_clip_changes)
1253 (redisplay_internal, set_cursor_from_row, try_scrolling)
1254 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1255 (redisplay_window, find_last_unchanged_at_beg_row)
1256 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1257 (trailing_whitespace_p, find_row_edges, display_line)
1258 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1259 (display_mode_element, store_mode_line_string)
1260 (pint2str, pint2hrstr, decode_mode_spec)
1261 (display_count_lines, display_string, draw_glyphs)
1262 (x_produce_glyphs, x_insert_glyphs)
1263 (rows_from_pos_range, mouse_face_from_buffer_pos)
1264 (fast_find_string_pos, mouse_face_from_string_pos)
1265 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1267 (safe_call, init_from_display_pos, handle_fontified_prop)
1268 (handle_single_display_spec, load_overlay_strings)
1269 (with_echo_area_buffer, setup_echo_area_for_printing)
1270 (display_echo_area, echo_area_display)
1271 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1272 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1273 (redisplay_window, dump_glyph_row, display_mode_line)
1274 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1275 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1276 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1277 (handle_single_display_spec, build_desired_tool_bar_string)
1278 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1279 (get_specified_cursor_type):
1280 Check that fixnums are in proper range for system types.
1281 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1282 (Flookup_image_map):
1283 Don't assume fixnums fit in int.
1284 (compare_overlay_entries):
1285 Avoid mishandling comparisons due to subtraction overflow.
1286 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1287 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1288 (handle_tool_bar_click):
1289 Use int, not unsigned, since we prefer signed and the signedness
1290 doesn't matter here.
1291 (get_next_display_element, next_element_from_display_vector):
1292 Use int, not EMACS_INT, when int is wide enough.
1293 (start_hourglass): Use duration_to_sec_usec to do proper
1294 overflow checking on durations.
1295 * xfaces.c (Fbitmap_spec_p):
1296 Check that fixnums are in proper range for system types.
1297 (compare_fonts_by_sort_order):
1298 Avoid mishandling comparisons due to subtraction overflow.
1299 (Fx_family_fonts, realize_basic_faces):
1300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1301 (Fx_family_fonts):
1302 Don't assume fixnum fits in int.
1303 Use SAFE_ALLOCA_LISP, not alloca.
1304 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1305 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1306 (face_at_buffer_position, face_for_overlay_string)
1307 (face_at_string_position):
1308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1309 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1310 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1311 (Fx_show_tip):
1312 Check that fixnums are in proper range for system types.
1313 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1314 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1316 (Fx_change_window_property): Don't assume fixnums fit in int.
1317 * xfont.c (xfont_chars_supported):
1318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1319 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1320 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1322 * xml.c (parse_region):
1323 * xrdb.c (magic_file_p):
1324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1325 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1326 (x_get_local_selection, x_reply_selection_request)
1327 (x_handle_selection_request, wait_for_property_change):
1328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1329 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1330 short is wide enough.
1331 (x_send_client_event): Don't assume fixnum fits in int.
1332 * xterm.c (x_x_to_emacs_modifiers):
1333 Don't assume EMACS_INT overflows nicely into int.
1334 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1335 may come from Lisp.
1336 (handle_one_xevent): NATNUMP can eval its arg twice.
1337 (x_connection_closed):
1338 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1339 * xterm.h: Adjust decls to match defn changes elsewhere.
1340 (struct scroll_bar): Use struct vectorlike_header
1341 rather than rolling our own approximation.
1342 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1343
c6574eb5
GM
13442012-05-25 Glenn Morris <rgm@gnu.org>
1345
1346 * lisp.mk (lisp): Update for more files being compiled now.
1347
e8d32c7e
SM
13482012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1349
48def666
SM
1350 * lread.c: Remove `read_pure' which makes no difference.
1351 (read_pure): Remove var.
1352 (unreadpure): Remove function.
1353 (readevalloop): Don't call read_list with -1 flag.
1354 (read1, read_vector): Don't test read_pure any more.
1355 (read_list): Simplify.
1356
e8d32c7e
SM
1357 * fileio.c, character.h: Minor style tweaks.
1358
4b2addb7
DA
13592012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1360
1361 * window.h (clip_changed): Remove useless declaration.
1362
584461b2
JB
13632012-05-22 Juanma Barranquero <lekktu@gmail.com>
1364
1365 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1366 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1367
34374650
PE
13682012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 Remove src/m/*.
1371 This directory predates autoconf and is no longer needed nowadays.
1372 Move its few remaining bits of functionality to where they're needed.
1373 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1374 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1375 * m/template.h: Remove.
1376 * Makefile.in (M_FILE): Remove. All uses removed.
1377 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1378 * lisp.h (USE_LSB_TAG):
1379 * mem-limits.h (EXCEEDS_LISP_PTR):
1380 Use VAL_MAX, not VALBITS, in #if.
1381 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1382 (EMACS_UINT): Define unconditionally now.
1383 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1384 (BITS_PER_EMACS_INT): New constants, replacing
1385 what used to be in config.h, but not useful in #if.
1386 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1387 define them any more.
1388 (VAL_MAX): New macro.
1389 (VALMASK): Use it.
1390 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1391 BITS_PER_EMACS_INT, in #if.
1392 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1393 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1394 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1395 * s/ms-w32.h (DATA_START):
1396 Move here from removed file m/intel386.h.
1397 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1398 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1399
261cb4bb
PE
14002012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1401
1402 Assume C89 or later.
1403 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1404 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1405 (xrealloc):
1406 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1407 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1408 * textprop.c, tparam.c (NULL): Remove.
1409 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1410 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1411 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1412 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1413 * xterm.c (input_signal_count): Assume volatile works.
1414
ff23cd9f
KB
14152012-05-21 Ken Brown <kbrown@cornell.edu>
1416
1417 * xgselect.c (xg_select): Fix first argument in call to 'select'
1418 (bug#11508).
1419
1b170bc6
KB
14202012-05-20 Ken Brown <kbrown@cornell.edu>
1421
1422 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1423 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1424
b2f4d39f
KB
14252012-05-19 Ken Brown <kbrown@cornell.edu>
1426
1427 * xfns.c (x_in_use): Remove `static' qualifier.
1428 * xterm.h (x_in_use): Declare.
1429 * xgselect.c: Include xterm.h.
1430 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1431 and `display_arg' (bug#9754).
1432
003fdae2
PE
14332012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1434
9232a6d9
PE
1435 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1436
003fdae2
PE
1437 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1438 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1439
784b56e2
EZ
14402012-05-18 Eli Zaretskii <eliz@gnu.org>
1441
1442 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1443
1444 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1445 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1446
1447 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1448 reference to image_cache->refcount.
1449 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1450
a0a79cde
JL
14512012-05-17 Juri Linkov <juri@jurta.org>
1452
1453 * search.c (Fword_search_regexp, Fword_search_backward)
1454 (Fword_search_forward, Fword_search_backward_lax)
1455 (Fword_search_forward_lax): Move functions to isearch.el
1456 (bug#10145, bug#11381).
1457
b0572523
PE
14582012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1459
1460 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1461
9660f5fc
SM
14622012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1463
1464 * lread.c (init_obarray): Declare Qt and Qnil as special.
1465
4374de83
GM
14662012-05-14 Glenn Morris <rgm@gnu.org>
1467
1468 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1469 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1470
dc44c39a
PE
14712012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1472
078c97cb
PE
1473 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1474
dc44c39a
PE
1475 * unexaix.c: Port to more-recent AIX compilers.
1476 (report_error, report_error_1, make_hdr, copy_sym)
1477 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1478 Make arguments const char *, not char *, to avoid violations of C
1479 standard and to fix some AIX warnings reported by Gilles Pion.
1480
e18afed7 14812012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1482
1483 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1484 already have overlays loaded.
1485 (handle_single_display_spec): Before returning without displaying
1486 fringe bitmap, synchronize the bidi iterator with the main display
1487 iterator, by calling iterate_out_of_display_property.
1488 (iterate_out_of_display_property): Detect buffer iteration by
1489 testing that it->string is a Lisp string.
1490 (get_next_display_element): When the current object is exhausted,
1491 and there's something on it->stack, call set_iterator_to_next to
1492 proceed with what's on the stack, instead of returning zero.
1493 (set_iterator_to_next): If called at the end of a Lisp string,
1494 proceed to consider_string_end without incrementing string
1495 position. Don't increment display vector index past the end of
1496 the display vector. (Bug#11417)
c8fb9dc6
EZ
1497 (pos_visible_p): Don't report a position visible when move_it_to
1498 stopped at the last line of window, which happens to be scanned
1499 backwards by the bidi iteration. (Bug#11464)
ac268e67 1500
e18afed7 15012012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1502
1503 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1504 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1505 are on a TTY, and thus unable to display on the fringes.
1506 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1507 so we need to signal to the caller that this is a "replacing"
1508 display spec. This fixes display when the spec is invalid or we
1509 are on a TTY.
1510
e18afed7 15112012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1512
1513 * unexaix.c (make_hdr): Fix typo in prototype.
1514 This bug broke the build on AIX. Problem reported by Gilles Pion.
1515
9d0a235a
MA
15162012-05-14 Michael Albinus <michael.albinus@gmx.de>
1517
1518 * keyboard.c (kbd_buffer_get_event): Read special events also in
1519 batch mode. (Bug#11415)
1520
9e6b06ed
GM
15212012-05-12 Glenn Morris <rgm@gnu.org>
1522
1523 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1524
c1a1d7a3
EZ
15252012-05-12 Eli Zaretskii <eliz@gnu.org>
1526
1527 * lisp.mk (lisp): Add newcomment.elc.
1528
3fe7cdc8
GM
15292012-05-12 Glenn Morris <rgm@gnu.org>
1530
1531 * Makefile.in (MKDIR_P): New, set by configure.
1532 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1533
53f7d2c0
PE
15342012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 Remove unused function hourglass_started.
1537 * dispextern.h (hourglass_started):
1538 * w32fns.c (hourglass_started):
1539 * xdisp.c (hourglass_started): Remove.
1540
75aafb17
JB
15412012-05-10 Juanma Barranquero <lekktu@gmail.com>
1542
1543 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1544 Update dependencies.
1545
12959e8e
PE
15462012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1547
97107e2e
PE
1548 * xgselect.c (xg_select): Put maxfds+1 into a var.
1549 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1550
12959e8e
PE
1551 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1552
836d29b3
DA
15532012-05-10 Dave Abrahams <dave@boostpro.com>
1554
1555 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1556 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1557
5cb67954
MA
15582012-05-09 Michael Albinus <michael.albinus@gmx.de>
1559
1560 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1561 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1562 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1563 Initialize xd_registered_buses.
1564
3478ec45
PE
15652012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1566
b263a6b0
PE
1567 Untag more efficiently if USE_LSB_TAG.
1568 This is based on a proposal by YAMAMOTO Mitsuharu in
1569 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1570 For an admittedly artificial (nth 8000 longlist) benchmark on
1571 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1572 Emacs's overall text size by 1%.
1573 * lisp.h (XUNTAG): New macro.
1574 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1575 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1576 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1577 * eval.c (Fautoload):
1578 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1579 * frame.h (XFRAME): Use XUNTAG.
1580
3478ec45
PE
1581 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1582 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1583 Remove unportable assumptions about print widths of types like
1584 dbus_uint32_t.
1585 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1586 intptr_t when converting between pointer and integer, to avoid GCC
1587 warnings about wrong width.
1588
666b903b 15892012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1590
1591 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1592 stack for each reader_thread, instead of defaulting to 8MB
1593 determined by the linker. This avoids failures in creating
1594 subprocesses on Windows 7, see the discussion in this thread:
1595 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1596
b120cc17
JC
15972012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1598
1599 Fix up display of the *Minibuf-0* buffer in the mini window.
1600 * keyboard.c (read_char): Don't clear the echo area if there's no
1601 message to clear.
1602 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1603 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1604
9a4b36f8
MA
16052012-05-07 Michael Albinus <michael.albinus@gmx.de>
1606
1607 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1608 batch mode.
1609
e5f9458f
CY
16102012-05-06 Chong Yidong <cyd@gnu.org>
1611
1612 * lisp.mk (lisp): Update.
1613
eceeb5fc 16142012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1615
1616 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1617
71873e2b
SM
16182012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1619
1620 * data.c (PUT_ERROR): New macro.
1621 (syms_of_data): Use it. Add new error type `user-error'.
1622 * undo.c (user_error): New function.
1623 (Fprimitive_undo): Use it.
1624 * print.c (print_error_message): Adjust print style for `user-error'.
1625 * keyboard.c (user_error): New function.
1626 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1627
ab0fa4e4
PE
16282012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1629
1630 Do not limit current-time-string to years 1000..9999.
1631 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1632 (Fcurrent_time_string): Support any year that is supported by the
1633 underlying localtime representation. Don't use asctime, as it
1634 has undefined behavior for years outside the range -999..9999.
1635
7ed806a7
PE
16362012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1637
1638 Fix race conditions involving setenv, gmtime, localtime, asctime.
1639 Without this fix, interrupts could mess up code that uses these
1640 nonreentrant functions, since setting TZ invalidates existing
1641 tm_zone or tzname values, and since most of these functions return
1642 pointers to static storage.
1643 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1644 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1645 Grow the critical sections to include not just invoking
1646 localtime/gmtime, but also accessing these functions' results
1647 including their tm_zone values if any, and any related TZ setting.
1648 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1649 so that the struct tm is saved in the critical section.
1650 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1651 motivated by the fact that memory allocation needs to be outside
1652 the critical section.
1653
0c16dfed
DA
16542012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1655
1656 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1657 with RESET_INTERVAL.
1658
1659 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1660 Remove duplicated buffer name initialization.
1661
3f83ace8
JM
16622012-05-02 Jim Meyering <jim@meyering.net>
1663
1664 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1665
c7b8541e
JM
1666 * xfns.c (x_window): Use xstrdup (Bug#11375).
1667
90207a15 16682012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1669
1670 * xdisp.c (pos_visible_p): If already at a newline from the
1671 display string before the 'while' loop, don't walk back the glyphs
1672 from it3.glyph_row. Solves assertion violation when the display
1673 string begins with a newline (egg.el). (Bug#11367)
1674
b593d6a9
AH
16752012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1676
1677 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1678 Move to simple.el.
1679
4737362e
GM
16802012-05-01 Glenn Morris <rgm@gnu.org>
1681
99cf43f9
GM
1682 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1683 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1684 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1685 All were removed before 23.1.
1686
9311dcff
GM
1687 * dispnew.c: Remove HAVE_LIBNCURSES test;
1688 it is always true on relevant platforms.
1689
4d5c6349
GM
1690 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1691 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1692
4737362e
GM
1693 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1694
74dd3a6b
AS
16952012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1696
1697 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1698 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1699 Remove.
1700
13c379ee
PE
17012012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1702
1703 Do not avoid creating empty evaporating overlays (Bug#9642).
1704 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1705 That is, do not delete an evaporating overlay if it becomes
1706 empty after its bounds are adjusted to fit within its buffer.
1707 This fix caused other problems, and I'm reverting it until we get
1708 to the bottom of them.
1709
a8e7d6d7 17102012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1711
1712 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1713
a8e7d6d7 17142012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1715
1716 * xdisp.c (pos_visible_p): If the window start position is beyond
1717 ZV, start the display from buffer beginning. Prevents assertion
1718 violation in init_iterator when the minibuffer window is scrolled
1719 via the scroll bar.
1720
1721 * window.c (window_scroll_pixel_based): Likewise.
1722
a8e7d6d7 17232012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1724
1725 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1726
a8e7d6d7 17272012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1728
1729 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1730 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1731
a8e7d6d7 17322012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1733
b593d6a9
AH
1734 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1735 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1736
1c6900d9
EZ
17372012-04-26 Eli Zaretskii <eliz@gnu.org>
1738
4c3fa1d9
EZ
1739 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1740 display element, check also the underlying string or buffer
1741 character. (Bug#11341)
1742
1c6900d9
EZ
1743 * w32menu.c: Include w32heap.h.
1744 (add_menu_item): If the call to AppendMenuW (via
1745 unicode_append_menu) fails, disable Unicode menus only if we are
1746 running on Windows 9X/Me.
1747
42bf8205
AS
17482012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1749
1750 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1751 (xgetint): Add missing shift for LSB tags.
1752
b1bac16e
MR
17532012-04-24 Martin Rudalics <rudalics@gmx.at>
1754
1755 * keyboard.c (read_char): Don't wipe echo area for select window
1756 events: These might get delayed via `mouse-autoselect-window'
1757 (Bug#11304).
1758
d69621cc
JB
17592012-04-24 Juanma Barranquero <lekktu@gmail.com>
1760
1761 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1762 manipulation of :loaded-from data.
1763
02fd101b
JB
17642012-04-23 Juanma Barranquero <lekktu@gmail.com>
1765
1766 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1767 now a cons (bug#11311).
1768
888bec30
PE
17692012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1770
89a438bd
PE
1771 Do not create empty overlays with the evaporate property (Bug#9642).
1772 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1773 if it becomes empty after its bounds are adjusted to fit within
1774 its buffer. Without this fix, in a nonempty buffer (let ((o
1775 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1776 yields an empty overlay that has the evaporate property, which is
1777 not supposed to happen.
1778
1068fe4d
PE
1779 Fix minor GTK3 problems found by static checking.
1780 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1781 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1782 (struct _EmacsFixedClass, emacs_fixed_get_type):
1783 Move decls here from emacsgtkfixed.h, since they needn't be public.
1784 (emacs_fixed_get_type): Now static.
1785 (emacs_fixed_class_init): Omit unused local.
1786 (emacs_fixed_child_type): Remove; unused.
1787 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1788 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1789 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1790 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1791 (EMACS_FIXED_GET_CLASS): Remove; unused.
1792 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1793
888bec30
PE
1794 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1795 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1796
de85e130
PE
17972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1798
d0baac98 1799 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1800 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1801 (__malloc_size_t, __malloc_ptrdiff_t):
1802 Remove. All uses removed, replaced by the definiens if needed,
1803 since we can assume C89 or better now.
1804 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1805 (protect_malloc_state, align, get_contiguous_space)
1806 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1807 (malloc_atfork_handler_child, malloc_enable_thread)
1808 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1809 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1810 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1811 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1812 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1813 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1814 Define using prototypes, not old style.
1815 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1816 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1817 (align): Don't assume that signed integer overflow wraps around.
1818 Omit unused local var.
1819 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1820 (_free_internal_nolock, memalign, mallochook, reallochook):
1821 Omit no-longer-needed casts.
1822 (valloc): Use getpagesize, not __getpagesize.
1823 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1824 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1825
de85e130
PE
1826 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1827
dcbf5805
MA
18282012-04-22 Michael Albinus <michael.albinus@gmx.de>
1829
1830 Move functions from C to Lisp. Make non-blocking method calls
1831 the default. Implement further D-Bus standard interfaces.
1832
1833 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1834 (QCdbus_request_name_allow_replacement)
1835 (QCdbus_request_name_replace_existing)
1836 (QCdbus_request_name_do_not_queue)
1837 (QCdbus_request_name_reply_primary_owner)
1838 (QCdbus_request_name_reply_in_queue)
1839 (QCdbus_request_name_reply_exists)
1840 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1841 (QCdbus_registered_serial, QCdbus_registered_method)
1842 (QCdbus_registered_signal): New Lisp objects.
1843 (XD_DEBUG_MESSAGE): Use sizeof.
1844 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1845 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1846 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1847 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1848 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1849 (xd_signature, xd_append_arg): Allow float for integer types.
1850 (xd_get_connection_references): New function.
b593d6a9
AH
1851 (xd_get_connection_address): Rename from xd_initialize.
1852 Return cached address.
dcbf5805
MA
1853 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1854 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1855 level.
1856 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1857 Return number of refcounts.
dcbf5805
MA
1858 (Fdbus_get_unique_name): Make stronger parameter check.
1859 (Fdbus_message_internal): New defun.
1860 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1861 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1862 (Fdbus_send_signal, Fdbus_register_service)
1863 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1864 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1865 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1866 (Vdbus_compiled_version, Vdbus_runtime_version)
1867 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1868 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1869 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1870 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1871 Adapt docstring.
dcbf5805 1872
52828e02
PE
18732012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1874
da05bc4c
PE
1875 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1876 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1877 Do not assume ptrdiff_t is the same width as 'int'.
1878
52828e02
PE
1879 * alloc.c: Handle unusual debugging option combinations.
1880 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1881 since the two debugging options are incompatible.
1882 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1883 is defined.
1884 (mem_init, mem_insert, mem_insert_fixup):
1885 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1886 (NEED_MEM_INSERT): Remove; no longer needed.
1887
f01769f9
LL
18882012-04-22 Leo Liu <sdl.web@gmail.com>
1889
1890 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1891
5790543d
PE
18922012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1893
1894 * sysdep.c [__FreeBSD__]: Minor cleanups.
1895 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1896 Use Emacs indenting style more consistently. Avoid some casts.
1897 Use 'double' consistently rather than mixing 'float' and 'double'.
1898
b91b7e4d
EW
18992012-04-21 Eduard Wiebe <usenet@pusto.de>
1900
b593d6a9
AH
1901 * sysdep.c (list_system_processes, system_process_attributes):
1902 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1903
6114eb15
AS
19042012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1905
1906 * lisp.mk (lisp): Update.
1907
2f38dff7
PE
19082012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1911 It is never used otherwise.
1912
4ae29f89
SM
19132012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1914
1915 * print.c (print_preprocess): Only check print_depth if print-circle
1916 is nil.
1917 (print_object): Check for cycles even when print-circle is nil and
1918 print-gensym is t, but only check print_depth if print-circle is nil.
1919
f30d612a
CY
19202012-04-20 Chong Yidong <cyd@gnu.org>
1921
1922 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1923 set the status to "failed" and ensure that sentinel is run.
1924
c07a4c0b 19252012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1926
1927 * process.c (Fset_process_inherit_coding_system_flag)
1928 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1929 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1930
c07a4c0b 19312012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1932
1933 * xdisp.c (string_buffer_position_lim): Limit starting position to
1934 BEGV.
1935 (set_cursor_from_row): If called for a mode-line or header-line
1936 row, return zero immediately.
1937 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1938 farther than the first row after the header line, if any.
1939 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1940 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1941
c07a4c0b 19422012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1943
4ae29f89
SM
1944 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1945 (bug#11238).
ad3a2b41 1946
c07a4c0b 19472012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 19482012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1949
1950 configure: new option --enable-gcc-warnings (Bug#11207)
1951 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1952 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1953 (ALL_CFLAGS): Use new macros rather than old.
1954 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1955 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1956 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1957 -Wunused-result, -Wunused-variable. This should go away once
1958 the Emacs and Gnulib regex code is merged.
1959 (xmalloc, xrealloc): Now static.
1960
aba027e8
PE
19612012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1962
1963 * dired.c (Fsystem_groups): Remove unused local.
1964
e5a36063
GM
19652012-04-17 Glenn Morris <rgm@gnu.org>
1966
1967 * dired.c (Fsystem_users): Doc fix.
1968
316411f0
DA
19692012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1970
1971 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1972 (syms_of_dired): Add them.
1973
9426aba4
PE
19742012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1975
b62a57be
PE
1976 Fix minor alloc.c problems found by static checking.
1977 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1978 New extern decls, to avoid calling undeclared functions.
1979 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1980 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1981 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1982 (NEED_MEM_INSERT): New macro.
1983 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1984 Remove one incorrect comment and fix another.
b62a57be 1985
3539f31f
PE
1986 Fix minor ralloc.c problems found by static checking.
1987 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1988 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1989 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1990 (r_alloc_sbrk): Now static.
1991
a041960a
PE
1992 Improve ralloc.c interface checking.
1993 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1994 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1995 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1996 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1997 [REL_ALLOC]: ... to here, to check interface.
1998 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1999 Remove decls. This fixes an "It stinks!".
2000
9426aba4
PE
2001 * alloc.c (which_symbols): Fix alignment issue / type clash.
2002
d55c12ed
AS
20032012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2004
2005 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2006 (struct Lisp_Misc_Any): Likewise.
2007 (struct Lisp_Free): Likewise.
2008 * alloc.c (union aligned_Lisp_Symbol): Define.
2009 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2010 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2011 (union aligned_Lisp_Misc): Define.
2012 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2013 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2014 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2015
b948ce8b
PE
20162012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2017
2018 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2019 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2020 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2021 * s/netbsd.h, s/sol2-6.h:
2022 Remove definition of GC_MARK_STACK, since the default now works.
2023 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2024 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2025 no longer the default.
2026 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2027
35dc09a1 20282012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2029
35dc09a1
GM
2030 * lread.c (lisp_file_lexically_bound_p):
2031 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2032
35dc09a1
GM
20332012-04-14 Eli Zaretskii <eliz@gnu.org>
2034
2035 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2036 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2037
20382012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2039
2040 * nsterm.m (constrainFrameRect): Always constrain when there is only
2041 one screen (Bug#10962).
2042
bcd86815
KB
20432012-04-13 Ken Brown <kbrown@cornell.edu>
2044
2045 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2046
c25df26e
RT
20472012-04-13 Reuben Thomas <rrt@sc3d.org>
2048
2049 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2050
0fc59f1e
DC
20512012-04-11 Daniel Colascione <dancol@dancol.org>
2052
2053 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2054 against is gone. It's better to use vfork now so that when Cygwin
2055 gains a new, working vfork, we use it automatically (bug#10398).
2056
de8c03dc
SM
20572012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2058
2059 * window.c (save_window_save): Obey window-point-insertion-type.
2060
2f097256
GM
20612012-04-11 Glenn Morris <rgm@gnu.org>
2062
2063 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2064
453b951e
SM
20652012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2066
2067 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2068
75f1671a 20692012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2070
2071 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2072 (force_quit_count): New var.
2073 (handle_interrupt): Use it.
2074
2a8ce227
JB
20752012-04-10 Juanma Barranquero <lekktu@gmail.com>
2076
2077 * w32.c (w32_delayed_load): Record the full path of the library
2078 being loaded (bug#10424).
2079
935396c0
GM
20802012-04-09 Glenn Morris <rgm@gnu.org>
2081
05920a43
GM
2082 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2083 not just in the obarray, before snarfing them. (Bug#11036)
2084
935396c0
GM
2085 * Makefile.in ($(leimdir)/leim-list.el):
2086 Pass EMACS rather than BUILT_EMACS.
2087
a18ecafa
TZ
20882012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2089
2090 * process.c (make_process):
2091 * process.h: Add integer `gnutls_handshakes_tried' member to
2092 process struct.
2093
6bbef4e5
JC
2094 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2095 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2096
2097 * gnutls.c (gnutls_log_function2i): Convenience log function.
2098 (emacs_gnutls_read): Use new log functions,
2099 `gnutls_handshakes_tried' process member, and
2100 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2101 attempts per process (connection).
2102
b4d3bc10
CY
21032012-04-09 Chong Yidong <cyd@gnu.org>
2104
2105 * eval.c (Fuser_variable_p, user_variable_p_eh)
2106 (lisp_indirect_variable): Functions deleted.
2107 (Fdefvar): Caller changed.
2108
2109 * callint.c (Finteractive, Fcall_interactively):
2110 * minibuf.c (Fread_variable): Callers changed.
2111
70f4d973
EZ
21122012-04-09 Eli Zaretskii <eliz@gnu.org>
2113
2114 * xdisp.c (set_cursor_from_row): If the display string appears in
2115 the buffer at position that is closer to point than the position
2116 after the display string, display the cursor on the first glyph of
2117 the display string. Fixes cursor display when a 'display' text
2118 property immediately follows invisible text. (Bug#11094)
2119
cb3c2e3e
PE
21202012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2121
2122 composite.c: use 'double' consistently
2123 * composite.c (get_composition_id): Use 'double' consistently
2124 instead of converting 'float' to 'double' and vice versa; this is
2125 easier to understand and avoids a GCC warning.
2126
fd06db5d
GM
21272012-04-09 Glenn Morris <rgm@gnu.org>
2128
50fe702a
GM
2129 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2130 preparation for dumping it with emacs. (Bug#4789)
2131 (leimdir): New variable.
2132 ($(leimdir)/leim-list.el): New rule.
2133 (emacs$(EXEEXT)): Depend on leim-list.el.
2134
fd06db5d
GM
2135 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2136 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2137 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2138
55c131ee
AS
21392012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2140
2141 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2142 proper alignment.
2143
9209588f
JB
21442012-04-07 Juanma Barranquero <lekktu@gmail.com>
2145
2146 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2147 Remove unused local variable.
2148
e3fb2efb
PE
21492012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2150
2151 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2152 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2153 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2154 objects, as mark_maybe_pointer will catch them otherwise.
2155 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2156 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2157
b5385551
PE
21582012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2159
2160 Fix typo that broke non-Windows builds.
2161 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2162
9078ead6
EZ
21632012-04-07 Eli Zaretskii <eliz@gnu.org>
2164
2165 Support building on MS-Windows with libxml2.
2166
2167 * makefile.w32-in (OBJ2): Add xml.$(O).
2168 (GLOBAL_SOURCES): Add xml.c.
2169 ($(BLD)/xml.$(O)): New dependency list.
2170
2171 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2172 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2173 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2174 [!WINDOWSNT]: New macros.
2175 (init_libxml2_functions, libxml2_loaded_p): New functions.
2176 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2177 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2178 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2179 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2180 linked in).
6bbef4e5
JC
2181 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2182 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2183 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2184
2185 * emacs.c: Don't include libxml/parser.h.
2186 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2187 xmlCleanupParser directly.
2188
2189 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2190
3811fdf3
EZ
21912012-04-07 Eli Zaretskii <eliz@gnu.org>
2192
2193 * indent.c (Fvertical_motion): If there is a display string at
2194 point, use it.vpos to compute how many lines to backtrack after
2195 move_it_to point. (Bug#11133)
2196
2f8e16b2
EZ
21972012-04-06 Eli Zaretskii <eliz@gnu.org>
2198
2199 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2200 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2201 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2202 macros related to unification of CJK characters. For the details,
2203 see the discussion following the message here:
2204 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2205
3d439cd1
CY
22062012-04-04 Chong Yidong <cyd@gnu.org>
2207
2208 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2209
8bc53d00
EZ
22102012-04-01 Eli Zaretskii <eliz@gnu.org>
2211
2212 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2213 instead of alloca. (Bug#11138)
2214
3b0512a3
AS
22152012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2216
2217 * w32menu.c (is_simple_dialog): Properly check lisp types.
2218 (Bug#11141)
2219
8427ddd2
EZ
22202012-03-31 Eli Zaretskii <eliz@gnu.org>
2221
979022ef
EZ
2222 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2223 position we get to after a call to move_it_to fails the
2224 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2225 only if we wind up in a string from display property. (Bug#11063)
2226
a6b1c7cc
EZ
2227 * window.c (Fdelete_other_windows_internal): Invalidate the row
2228 and column information about mouse highlight, so that redisplay
2229 restores it after reallocating the glyph matrices. (Bug#7464)
2230
8427ddd2
EZ
2231 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2232 string comes from a `display' text property, use the buffer
2233 position of that property as if we actually saw that position in
2234 the row's glyphs.
697ba24b
EZ
2235 (move_it_by_lines): Remove the assertion that
2236 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2237 violated when there's a before-string at the beginning of a line.
2238 (Bug#11063)
8427ddd2 2239
65a0a738
EZ
22402012-03-30 Eli Zaretskii <eliz@gnu.org>
2241
2242 * xdisp.c (append_space_for_newline): If the default face was
2243 remapped, use the remapped face for the appended newline.
2244 (extend_face_to_end_of_line): Use the remapped default face for
2245 extending the face to the end of the line.
2246 (display_line): Call extend_face_to_end_of_line when the default
2247 face was remapped. (Bug#11068)
2248
581355cc
EZ
22492012-03-29 Eli Zaretskii <eliz@gnu.org>
2250
2251 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2252
e8fc049f
SM
22532012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2254
2255 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2256
4fb9a543
GM
22572012-03-27 Glenn Morris <rgm@gnu.org>
2258
2259 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2260 Doc fixes.
2261
679910f1
KH
22622012-03-26 Kenichi Handa <handa@m17n.org>
2263
2264 * dispextern.h (struct glyph): Fix previous change. Change the
2265 bit length of glyphless.ch to 25 (Bug#11082).
2266
90d49b7f
CY
22672012-03-26 Chong Yidong <cyd@gnu.org>
2268
2269 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2270 (command_loop_1): Use it; inhibit selection update for
2271 handle-select-window too (Bug#8996).
2272
f514f6f0
FP
22732012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2274
e8fc049f 2275 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2276
bf43fa51
KH
22772012-03-25 Kenichi Handa <handa@m17n.org>
2278
2279 * dispextern.h (struct glyph): Change the bit length of
2280 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2281
8a0c01dd
EZ
22822012-03-24 Eli Zaretskii <eliz@gnu.org>
2283
2284 * s/ms-w32.h (tzname): Include time.h before redirecting to
2285 _tzname. Fixes the MSVC build. (Bug#9960)
2286
7d1c3a76
AS
22872012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2288
8ed79523
AS
2289 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2290 characters.
2291
7d1c3a76
AS
2292 * xterm.c (XTread_socket): Only modify handling_signal if
2293 !SYNC_INPUT. (Bug#11080)
2294
e99a9b8b
EZ
22952012-03-23 Eli Zaretskii <eliz@gnu.org>
2296
2297 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2298 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2299 when fetching a multibyte character consumes more bytes than
2300 CHAR_BYTES returns, due to unification of CJK characters in
2301 string_char. (Bug#11073)
2302
5063c0e1
TN
23032012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2304
2305 * process.c (wait_reading_process_output): Handle pty disconnect
2306 by refraining from sending oneself a SIGCHLD (bug#10933).
2307
9f851fbd
CY
23082012-03-22 Chong Yidong <cyd@gnu.org>
2309
2310 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2311
5063c0e1 2312 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2313 Mark string as coming from a prefix property.
2314 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2315 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2316
fb5b8aca
CY
23172012-03-21 Chong Yidong <cyd@gnu.org>
2318
2319 * xfaces.c (Vface_remapping_alist): Doc fix.
2320
62356a1b
EZ
23212012-03-20 Eli Zaretskii <eliz@gnu.org>
2322
2323 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2324 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2325 Doc fixes.
62356a1b 2326
025de85b
CY
23272012-03-20 Chong Yidong <cyd@gnu.org>
2328
2329 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2330 to reflect default non-nil value of redisplay-dont-pause.
2331
4827f94e
KH
23322012-03-19 Kenichi Handa <handa@m17n.org>
2333
2334 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2335 it fit in a valid range (Bug#11003).
2336
e50a24a2
EZ
23372012-03-18 Eli Zaretskii <eliz@gnu.org>
2338
2339 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2340 that is not from display property, accept the row as a "cursor
2341 row" if one of the string's character has a non-nil `cursor'
2342 property. Fixes cursor positioning when there are newlines in
2343 overlay strings, e.g. in icomplete.el. (Bug#11035)
2344
9af5ed87
PE
23452012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2346
2347 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2348
d1f55f16
CY
23492012-03-12 Chong Yidong <cyd@gnu.org>
2350
2351 * eval.c (inhibit_lisp_code): Rename from
2352 inhibit_window_configuration_change_hook; move from window.c.
2353
2354 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2355 * window.c (run_window_configuration_change_hook)
2356 (syms_of_window): Callers changed.
2357
66c5eebd
CY
23582012-03-11 Chong Yidong <cyd@gnu.org>
2359
413df973
CY
2360 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2361
66c5eebd
CY
2362 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2363
1de11f56
CY
23642012-03-10 Chong Yidong <cyd@gnu.org>
2365
2366 * frame.c (other_visible_frames): Don't assume the selected frame
2367 is visible (Bug#10955).
2368
cae07000
SM
23692012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2370
2371 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2372
89c94350
JD
23732012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2374
2375 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2376 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2377 zero (Bug#10954).
2378
999dd333
GM
23792012-03-03 Glenn Morris <rgm@gnu.org>
2380
01a6dcc8 2381 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2382
de0100f2
EZ
23832012-03-02 Eli Zaretskii <eliz@gnu.org>
2384
2385 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2386 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2387 (redisplay_window, next_element_from_string): Fix typos in
2388 comments.
3e441275
EZ
2389 (redisplay_window): Pass to move_it_vertically the margin in
2390 pixels, not in screen lines.
de0100f2 2391
96a72ee9
GM
23922012-03-02 Glenn Morris <rgm@gnu.org>
2393
2394 * buffer.c (buffer-list-update-hook): Doc fix.
2395
312508d7
EZ
23962012-02-29 Eli Zaretskii <eliz@gnu.org>
2397
2398 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2399 push_it before setting up the iterator for the first overlay
2400 string, even if we have an empty string loaded.
2401 (next_overlay_string): If there's an empty string on the iterator
2402 stack, pop the stack. (Bug#10903)
2403
27f3c637
PE
24042012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2405
2406 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2407 Suggested by Stefan Monnier in
2408 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2409 * alloc.c (widen_to_Lisp_Object): New static function.
2410 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2411 and widening them to Lisp_Objects. This would work even if
2412 USE_LSB_TAG is defined and wide integers are used, which might
2413 happen in a future version of Emacs.
2414
3c9dfce6
CY
24152012-02-25 Chong Yidong <cyd@gnu.org>
2416
fa74b241
CY
2417 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2418 Doc fix.
2419
3c9dfce6
CY
2420 * xselect.c (Fx_selection_exists_p): Doc fix.
2421 (x_clipboard_manager_save_all): Print an informative message
2422 before saving to clipboard manager.
2423
9486df08
CY
24242012-02-24 Chong Yidong <cyd@gnu.org>
2425
2426 * keyboard.c (process_special_events): Handle all X selection
2427 requests in kbd_buffer, not just the next one (Bug#8869).
2428
f01d3321
CY
24292012-02-23 Chong Yidong <cyd@gnu.org>
2430
2431 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2432 call when setting menu-bar-lines and tool-bar-lines parameters.
2433 (unwind_create_frame_1): New helper function.
2434
2435 * window.c (inhibit_window_configuration_change_hook): New var.
2436 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2437 (syms_of_window): Initialize it.
f01d3321 2438
86b847b6
CY
24392012-02-22 Chong Yidong <cyd@gnu.org>
2440
2441 * xterm.c (x_draw_image_relief): Add missing type check for
2442 Vtool_bar_button_margin (Bug#10743).
2443
a59225b1
CY
24442012-02-21 Chong Yidong <cyd@gnu.org>
2445
2446 * fileio.c (Vfile_name_handler_alist): Doc fix.
2447
2448 * buffer.c (Fget_file_buffer): Protect against invalid file
2449 handler return value.
2450
310f5bd4
PE
24512012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2452
cb3a28cc
PE
2453 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2454 when computing $valmask.
2455
310f5bd4
PE
2456 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2457 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2458 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2459 It's useless in that case, and it can cause problems on hosts
2460 that allocate halves of EMACS_INT values separately.
2461 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2462 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2463 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2464 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2465 it avoids undefined behavior on hosts where shifting right by more
2466 than the word width has undefined behavior.
2467
2375c96a
CY
24682012-02-19 Chong Yidong <cyd@gnu.org>
2469
2470 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2471 (Funhandled_file_name_directory, Ffile_name_as_directory)
2472 (Fdirectory_file_name, Fexpand_file_name)
2473 (Fsubstitute_in_file_name): Protect against invalid file handler
2474 return values (Bug#10845).
2475
3eb49e71
EZ
24762012-02-18 Eli Zaretskii <eliz@gnu.org>
2477
2478 * .gdbinit (pitx): Fix incorrect references to fields of the
2479 iterator stack.
2480
7b926f3f
CY
24812012-02-17 Chong Yidong <cyd@gnu.org>
2482
2483 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2484
11273115
PE
24852012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2486
2487 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2488 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2489
c3a70e2b
CY
24902012-02-15 Chong Yidong <cyd@gnu.org>
2491
2492 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2493 marked as special. Also, starting docstrings with * is obsolete.
2494
0ca43699
AS
24952012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2496
2497 * gnutls.c (emacs_gnutls_write): Fix last change.
2498
2e8f3c56
LI
24992012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2500
2501 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2502 send_process.
2503
af70074f
SM
25042012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2505
2506 * keymap.c (Fsingle_key_description): Handle char ranges.
2507
95986d52
CY
25082012-02-12 Chong Yidong <cyd@gnu.org>
2509
afd83bd1
CY
2510 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2511 as that creates a dangerous corner case.
2512
95986d52
CY
2513 * window.c (Fdelete_window_internal): Invalidate the mouse
2514 highlight (Bug#9904).
2515
bd7da63e
GM
25162012-02-12 Glenn Morris <rgm@gnu.org>
2517
2518 * xselect.c (Fx_own_selection_internal)
2519 (Fx_get_selection_internal, Fx_disown_selection_internal)
2520 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2521 * nsselect.m (Fx_own_selection_internal)
2522 (Fx_disown_selection_internal, Fx_selection_exists_p)
2523 (Fx_selection_owner_p, Fx_get_selection_internal):
2524 Sync docs and argument specs with the xselect.c versions.
2525
77abcbc2
LI
25262012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2527
2528 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2529
90b671e2
EZ
25302012-02-11 Eli Zaretskii <eliz@gnu.org>
2531
1c0ca0b7
EZ
2532 * w32select.c (Fx_selection_exists_p): Sync doc string and
2533 argument list with xselect.c. (Bug#10783)
2534
2535 * w16select.c (Fx_selection_exists_p): Sync doc string and
2536 argument list with xselect.c. (Bug#10783)
90b671e2 2537
49241268
GM
25382012-02-10 Glenn Morris <rgm@gnu.org>
2539
2540 * fns.c (Fsecure_hash): Doc fix.
2541
f998bbe7 25422012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2543
2544 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2545
0992bd9c
CY
25462012-02-07 Chong Yidong <cyd@gnu.org>
2547
2548 * buffer.c (Fbuffer_local_variables)
2549 (buffer_lisp_local_variables): Handle unbound vars correctly;
2550 don't let Qunbound leak into Lisp.
2551
af008560
GM
25522012-02-07 Glenn Morris <rgm@gnu.org>
2553
dd605cc4
GM
2554 * image.c (Fimagemagick_types): Doc fix.
2555
af008560
GM
2556 * image.c (imagemagick-render-type): Change it from a lisp object
2557 to an integer. Move the doc here from the lisp manual.
2558 Treat all values not equal to 0 the same.
2559
1449fa1d
CY
25602012-02-06 Chong Yidong <cyd@gnu.org>
2561
2562 * doc.c (store_function_docstring): Avoid applying docstring of
2563 alias to base function (Bug#2603).
2564
3723ec07
AS
25652012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2566
2567 * .gdbinit (pp1, pv1): Remove redundant defines.
2568 (pr): Use pp.
2569
79c1cc1e
CY
25702012-02-04 Chong Yidong <cyd@gnu.org>
2571
2572 * nsterm.m: Declare a global (Bug#10694).
2573
d7f29f8e
EZ
25742012-02-04 Eli Zaretskii <eliz@gnu.org>
2575
cae07000
SM
2576 * w32.c (get_emacs_configuration_options):
2577 Include --enable-checking, if specified, in the return value.
d7f29f8e 2578
3b95a6f9
MR
25792012-02-04 Martin Rudalics <rudalics@gmx.at>
2580
2581 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2582 after rounding frame sizes. (Bug#9723)
2583
d6fa96a6
EZ
25842012-02-04 Eli Zaretskii <eliz@gnu.org>
2585
2586 * keyboard.c (adjust_point_for_property): Don't position point
2587 before BEGV. (Bug#10696)
2588
df0b2940
PE
25892012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2590
2591 Handle overflow when computing char display width (Bug#9496).
2592 * character.c (char_width): Return EMACS_INT, not int.
2593 (char_width, c_string_width): Check for overflow when
2594 computing the width; this is possible now that individual
2595 characters can have unbounded width. Problem introduced
2596 by merge from Emacs 23 on 2012-01-19.
2597
6bee44d6
MA
25982012-02-02 Michael Albinus <michael.albinus@gmx.de>
2599
2600 * dbusbind.c (Fdbus_register_method): Mention the return value
2601 :ignore in the docstring.
2602
44f92739
GM
26032012-02-02 Glenn Morris <rgm@gnu.org>
2604
1b9f60cc
GM
2605 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2606
44f92739
GM
2607 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2608 Unconditionally set to t. (Bug#10673)
2609 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2610 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2611 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2612
c5d3843c
KH
26132012-02-02 Kenichi Handa <handa@m17n.org>
2614
2615 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2616 0, do not call append_composite_glyph.
2617
159462d4 26182012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2619
2620 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2621 NULL (Bug#6988).
2622 (x_produce_glyphs): If the component of a composition is a null
2623 string, set it->pixel_width to 1 to avoid zero-width glyph.
2624
78cef877
EZ
26252012-02-01 Eli Zaretskii <eliz@gnu.org>
2626
2627 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2628 first 2 arguments are identical. This makes inserting large
2629 output from a subprocess an order of magnitude faster on
2630 MS-Windows, where all sbrk'ed memory is always contiguous.
2631
97897668
GM
26322012-01-31 Glenn Morris <rgm@gnu.org>
2633
2634 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2635 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2636 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2637
31fd3586
GM
26382012-01-29 Glenn Morris <rgm@gnu.org>
2639
2640 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2641
0e24a8b2
CY
26422012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2643
2644 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2645
cc0adcb0
CY
26462012-01-28 Chong Yidong <cyd@gnu.org>
2647
2648 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2649
acc28cb9
CY
26502012-01-26 Chong Yidong <cyd@gnu.org>
2651
9c69cfb7
CY
2652 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2653
acc28cb9
CY
2654 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2655 repeat counts (Bug#10507).
2656
48da7392
GM
26572012-01-26 Glenn Morris <rgm@gnu.org>
2658
2659 * lread.c (syms_of_lread): Doc fix.
2660
14af5f7f
CY
26612012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2662
2663 * coding.c (encode_designation_at_bol): Change return value to
2664 EMACS_INT.
2665
0b21c100
CY
26662012-01-25 Chong Yidong <cyd@gnu.org>
2667
2668 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2669
3c2907f7
CY
26702012-01-21 Chong Yidong <cyd@gnu.org>
2671
2672 * floatfns.c (Fcopysign): Make the second argument non-optional,
2673 since nil is not allowed anyway.
2674
959ad23f
AS
26752012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2676
2677 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2678 (send_process): Likewise.
2679
34a02f46
MR
26802012-01-19 Martin Rudalics <rudalics@gmx.at>
2681
2682 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2683 (Vwindow_persistent_parameters): Do not use Qstate.
2684 Rewrite doc-strings.
34a02f46 2685
1259009a 26862012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2687
2688 * character.c (char_width): New function.
70d4fdf6
GM
2689 (Fchar_width, c_string_width, lisp_string_width):
2690 Use char_width (Bug#9496).
25ed9e61 2691
6a6ee00d
MR
26922012-01-16 Martin Rudalics <rudalics@gmx.at>
2693
2694 * window.c (Vwindow_persistent_parameters): New variable.
2695 (Fset_window_configuration, save_window_save): Handle persistent
2696 window parameters.
2697
c85efaf7
EZ
26982012-01-14 Eli Zaretskii <eliz@gnu.org>
2699
2700 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2701 thrashing the stack of the thread. (Bug#9087)
2702
5944709e
PE
27032012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2704
2705 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2706
e71f5d99
EZ
27072012-01-11 Eli Zaretskii <eliz@gnu.org>
2708
2709 * xdisp.c (rows_from_pos_range): Handle the case where the
2710 highlight ends on a newline. (Bug#10464)
2711 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2712 he end column for display of highlight that ends on a newline
2713 before a R2L line.
2714
ce316182
GM
27152012-01-11 Glenn Morris <rgm@gnu.org>
2716
2717 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2718 from load-path also when installation-directory is nil. (Bug#10208)
2719
5b43da69
GM
27202012-01-10 Glenn Morris <rgm@gnu.org>
2721
74cc8ff9
GM
2722 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2723
7d8d6e4e
GM
2724 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2725 Update template values to be closer to their typical values these days.
5b43da69 2726
a0db8d43
EZ
27272012-01-09 Eli Zaretskii <eliz@gnu.org>
2728
2729 * xdisp.c (rows_from_pos_range): Accept additional argument
2730 DISP_STRING, and accept any glyph in a row whose object is that
2731 string as eligible for mouse highlight. Fixes mouse highlight of
2732 display strings from overlays. (Bug#10464)
2733
9a0115ab 27342012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2735
b9110d6a 2736 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2737 * fileio.c (auto_saving_dir_umask): New static var.
2738 (Fmake_directory_internal): Use it.
2739 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2740 creating the directory. The old code temporarily assigns
2741 too-generous permissions to the directory.
2742 (do_auto_save_eh): Clear it.
b9110d6a 2743 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2744 that the var is always cleared.
2745
6c1bd3f3
EZ
27462012-01-07 Eli Zaretskii <eliz@gnu.org>
2747
2748 * search.c (scan_buffer): Pass character positions to
2749 know_region_cache, not byte positions. (Bug#6540)
2750
069d2b50
L
27512012-01-07 LynX <_LynX@bk.ru> (tiny change)
2752
2753 * w32.c (sys_rename): Report EXDEV when rename of a directory
2754 fails because the target is on another logical disk. (Bug#10284)
2755
75bf0d33
DB
27562012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2757
2758 * xterm.c (x_embed_request_focus): New function.
2759
2760 * xterm.h: Add prototype.
2761
2762 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2763
1c6e5a32
GM
27642012-01-05 Glenn Morris <rgm@gnu.org>
2765
2766 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2767
651e947e
EZ
27682012-01-01 Eli Zaretskii <eliz@gnu.org>
2769
2770 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2771 Load gnutls_transport_set_lowat only if GnuTLS version is below
2772 2.11.1.
2773 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2774 GnuTLS versions below 2.11.1.
2775
3778cdd8
AL
27762011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2777
2778 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2779 to the doc string advising against its use for altering the way
2780 windows are scrolled.
2781
0e5317f7
KH
27822011-12-28 Kenichi Handa <handa@m17n.org>
2783
2784 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2785 coding-system ASCII compatible only when it does not produce BOM
2786 on encoding (Bug#10383).
2787
93d5ca1f
JD
27882011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2789
2790 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2791 can scroll.
2792 (create_and_show_popup_menu): Always use menu_position_func for
2793 Gtk3 (Bug#10361).
2794
ca22b785
AS
27952011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2796
2797 * callint.c (Fcall_interactively): Don't truncate prompt string.
2798
d048e1e6
EZ
27992011-12-23 Eli Zaretskii <eliz@gnu.org>
2800
2801 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2802 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2803 resumed from there (after widening). (Bug#10360)
d048e1e6 2804
5ccaba1f
JD
28052011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2806
2807 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2808
204ee57f
JD
28092011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2810
b81d40f0
JB
2811 * nsterm.m (x_free_frame_resources):
2812 Release f->output_data.ns->miniimage.
204ee57f
JD
2813 (ns_index_color): Fix indentation. Do not retain
2814 color_table->colors[i].
2815
2816 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2817 before returning.
2818
2819 * nsfns.m (x_set_background_color): Assign return value from
2820 ns_index_color to face-background instead of NSColor*.
2821 (ns_implicitly_set_icon_type): Fix indentation.
2822 Change assignment in for loop to comparison.
2823
2824 * emacs.c (ns_pool): New variable.
2825 (main): Assign ns_pool.
2826 (Fkill_emacs): Call ns_release_autorelease_pool.
2827
2828 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2829 autorelease fdesc, release fdAttrs and tdict.
2830 (ns_get_covering_families): Release charset.
2831 (ns_findfonts): Release NSFontDescriptor created with new.
2832 (ns_uni_to_glyphs): Fix indentation.
2833 (setString): Release attrStr before assigning new value.
2834
c803b2b7
JD
28352011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2836
678f4426
JD
2837 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2838 and NS_IMPL_COCOA.
2839 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2840 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2841
cd394be1 28422011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2843
5fecd5fc
JD
2844 * nsterm.m (ns_term_init): Subscribe for notifications
2845 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2846 to method trackingNotification in EmacsMenu.
2847
2848 * nsmenu.m (trackingMenu): New variable.
3771cb17 2849 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2850 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2851 from Aquamacs (Bug#7030).
678f4426
JD
2852
28532011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2854
c803b2b7
JD
2855 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2856 (symbol_to_nsstring): Fix indentation.
2857 (ns_symbol_to_pb): New function.
cae07000
SM
2858 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2859 (Fns_rotate_cut_buffers_internal): Remove.
2860 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2861 Fns_store_cut_buffer_internal.
2862 (ns_get_foreign_selection, Fx_own_selection_internal)
2863 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2864 (Fns_get_selection_internal, Fns_store_selection_internal):
2865 Use ns_symbol_to_pb and check if return value is nil.
2866 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2867 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2868 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2869 renamed to Sns_store_selection_internal.
2870 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2871 and remove this function.
2872 (ns_handle_selection_clear): Remove, never used.
2873 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2874 here.
2875
e1b01a3a
KB
28762011-12-17 Ken Brown <kbrown@cornell.edu>
2877
2878 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2879 GID is unknown (Bug#10257).
2880
2adb6e85
PE
28812011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2882
2883 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2884 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2885 which caused a build failure on GNU/Linux IA-64. This problem was
2886 introduced by my 2011-10-07 patch.
2887
d1d7b339
JL
28882011-12-15 Juri Linkov <juri@jurta.org>
2889
2890 * image.c (imagemagick_error): New function. (Bug#10112)
2891 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2892 Use `imagemagick_error' where ImageMagick functions return
2893 `MagickFalse'.
2894 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2895 proper order.
2896
100d5755
KH
28972011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2898
2899 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2900 fill background (Bug#8992).
2901
454592a6
MR
29022011-12-13 Martin Rudalics <rudalics@gmx.at>
2903
2904 * window.c (Vwindow_combination_resize)
2905 (Vwindow_combination_limit): Use t instead of non-nil in
2906 doc-strings.
61d4b438
MR
2907 (Vrecenter_redisplay): Add first sentence of doc-string on
2908 separate line.
53524d93 2909 (Frecenter): Fix doc-string typo.
454592a6 2910
3633e3aa
KH
29112011-12-11 Kenichi Handa <handa@m17n.org>
2912
2913 * coding.c (Funencodable_char_position): Pay attention to the
2914 buffer text relocation (Bug#9389).
2915
7b9d523a 29162011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2917
7b9d523a
JD
2918 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2919 gtk_init (Bug#10100).
2920
b73189c6
EZ
29212011-12-10 Eli Zaretskii <eliz@gnu.org>
2922
2923 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2924 IT->string is nil. (Bug#10263)
2925
f7dfe5d6
JD
29262011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2927
83faebb4
JD
2928 * nsterm.h (x_free_frame_resources): Declare.
2929
f7dfe5d6
JD
2930 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2931 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2932
2933 * nsterm.h (ns_get_defaults_value): Declare.
2934
2935 * nsterm.m (ns_default): Call ns_get_defaults_value.
2936
7cd4e72c
EZ
29372011-12-09 Eli Zaretskii <eliz@gnu.org>
2938
2939 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2940 (Bug#10170)
2941
b34d7317
YM
29422011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2943
2944 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2945 that where the value of an _OBJC_* symbol points to is in the .bss
2946 section (Bug#10240).
2947
76470ad1
KH
29482011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2949
2950 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2951 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2952
745fff94
KH
29532011-12-08 Kenichi Handa <handa@m17n.org>
2954
2955 * ftfont.c (get_adstyle_property): Fix previous change
2956 (Bug#10233).
2957
6e44397c
JB
29582011-12-07 Juanma Barranquero <lekktu@gmail.com>
2959
2960 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2961 dirs from the default value of EMACSLOADPATH (bug#10208).
2962
7efa6272
GM
29632011-12-07 Glenn Morris <rgm@gnu.org>
2964
2965 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2966 installation and source directories as well. (Bug#10208)
2967
f6fc4d87
CY
29682011-12-06 Chong Yidong <cyd@gnu.org>
2969
2970 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2971
2bf26180
GM
29722011-12-06 Glenn Morris <rgm@gnu.org>
2973
2974 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2975 as an error, not just -1. (Bug#10217)
2976
3a6ad4f0
CY
29772011-12-05 Chong Yidong <cyd@gnu.org>
2978
2979 * keyboard.c (process_special_events): New function.
2980 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2981
75a3b399
PE
29822011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2983
2984 * coding.c (encode_designation_at_bol): Don't use uninitialized
2985 local variable (Bug#9318).
2986
c3c9e25e
KH
29872011-12-05 Kenichi Handa <handa@m17n.org>
2988
2989 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2990 return Qnil (Bug#8046, Bug#10193).
2991
5eb05ea3
KH
29922011-12-05 Kenichi Handa <handa@m17n.org>
2993
2994 * coding.c (encode_designation_at_bol): New args charbuf_end and
2995 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2996 (coding_set_source): Return how many bytes coding->source was
2997 relocated.
2998 (coding_set_destination): Return how many bytes
2999 coding->destination was relocated.
3000 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3001 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3002
30032011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3004
3005 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3006 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3007 macro (Bug#9318).
3008
30092011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3010
3011 The following changes are to fix Bug#9318.
3012
a79703f5 3013 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3014 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3015 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3016 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3017
7dbda6df
JB
30182011-12-05 Juanma Barranquero <lekktu@gmail.com>
3019
3020 * lisp.h (process_quit_flag): Fix external declaration.
3021
6d5eb5b0
SM
30222011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3023
3024 Don't macro-inline non-performance-critical code.
3025 * eval.c (process_quit_flag): New function.
3026 * lisp.h (QUIT): Use it.
3027
a0c3fad0
JD
30282011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3029
3030 * nsfns.m (get_geometry_from_preferences): New function.
3031 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3032
6c07aac2
AS
30332011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3034
3035 * emacs.c (Qkill_emacs): Define.
3036 (syms_of_emacs): Initialize it.
3037 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3038 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3039 (quit_throw_to_read_char): Add parameter `from_signal'.
3040 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3041 * lisp.h (QUIT): Call Fkill_emacs if requested.
3042
c052ead4
JD
30432011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3044
3045 * widget.c (update_wm_hints): Return if wmshell is null.
3046 (widget_update_wm_size_hints): New function.
3047
3048 * widget.h (widget_update_wm_size_hints): Declare.
3049
3050 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3051 widget_update_wm_size_hints (Bug#10104).
3052
9e49252b
EZ
30532011-12-03 Eli Zaretskii <eliz@gnu.org>
3054
3055 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3056 before a newline, prepare the bidi iterator for consuming the
3057 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3058 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3059
02b16839
JL
30602011-12-02 Juri Linkov <juri@jurta.org>
3061
3062 * search.c (Fword_search_regexp): New Lisp function created from
3063 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3064 (Fword_search_backward, Fword_search_forward)
3065 (Fword_search_backward_lax, Fword_search_forward_lax):
3066 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3067 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3068
0068070e
SM
30692011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3070
3071 * fileio.c (Finsert_file_contents): Move after-change-function call
3072 to before the "handled:" label, since all "goto handled" appear in
3073 cases where the *-change-functions have already been properly called
3074 (bug#10117).
3075
3360a3fc
AS
30762011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3077
3078 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3079 waiting for input. (Bug#10169)
3080
73d6c093
EZ
30812011-11-30 Eli Zaretskii <eliz@gnu.org>
3082
3083 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3084 verifies glyph row's hash code--we have just reallocated the
3085 glyphs, so their contents can be complete garbage. (Bug#10164)
3086
febe6bea
JB
30872011-11-30 Juanma Barranquero <lekktu@gmail.com>
3088
3089 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3090
801a4313
EZ
30912011-11-30 Eli Zaretskii <eliz@gnu.org>
3092
3093 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3094 attributes are tested _before_ calling verify_row_hash, to protect
3095 against GCC re-ordering of the tests. (Bug#10164)
3096
2b56b87e
JD
30972011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3098
3099 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3100
3101 * xterm.c (handle_one_xevent): Only set async_visible and friends
3102 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3103 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3104 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3105
dbf31225
PE
31062011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3107
3108 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3109 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3110 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3111 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3112 All uses changed to use GCPRO1 etc.
3113 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3114 Revert to old implementation (i.e., before 2011-03-11).
3115
1305621b
YM
31162011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3117
3118 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3119 of scroll runs so as to avoid assigning disabled bogus rows and
3120 unnecessary graphics copy operations.
3121
8c9afb46
EZ
31222011-11-27 Eli Zaretskii <eliz@gnu.org>
3123
3124 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3125 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3126 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3127 (malloc, free, realloc, calloc): Redirect to e_* only when
3128 compiling Emacs.
3129
3130 * lisp.h (GCTYPEBITS): Move before first use.
3131 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3132 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3133 this macro definition.
3134
3135 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3136 _MSC_VER.
3137
54e9e3bf
JD
31382011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3139
6d5eb5b0
SM
3140 * gtkutil.c (xg_create_frame_widgets):
3141 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3142 present with Gtk+ 2.0.
3143
83aca1cb
PE
31442011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3145
3146 * fileio.c (Finsert_file_contents): Undo previous change; see
3147 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3148
5b76caa4
PE
31492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3150
3151 Rename locals to avoid shadowing.
3152 * fileio.c (Finsert_file_contents):
3153 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3154 * process.c (wait_reading_process_output):
3155 Rename inner 'proc' to 'p' to avoid shadowing.
3156 Indent for consistency with usual Emacs style.
3157
8c535114
EZ
31582011-11-25 Eli Zaretskii <eliz@gnu.org>
3159
3160 * xdisp.c (redisplay_window): If cursor row is not fully visible
3161 after recentering, and scroll-conservatively is set to a large
3162 number, scroll window by a few more lines to make the cursor fully
3163 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3164 (start_display): Don't move to the next line if the display should
3165 start at a newline that is part of a display vector or an overlay
3166 string. (Bug#10119)
8c535114 3167
fa4fdb5c
JL
31682011-11-24 Juri Linkov <juri@jurta.org>
3169
3170 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3171 after the `MagickPingImage' call. (Bug#10112)
3172
90ec88df
CY
31732011-11-23 Chong Yidong <cyd@gnu.org>
3174
3175 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3176
56e2e794
MR
31772011-11-23 Martin Rudalics <rudalics@gmx.at>
3178
3179 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3180 making another buffer current. (Bug#10114)
3181
b6e64c41
GM
31822011-11-23 Glenn Morris <rgm@gnu.org>
3183
3184 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3185
6b21de18
CY
31862011-11-23 Chong Yidong <cyd@gnu.org>
3187
3188 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3189 using it (Bug#5984).
3190
b12cd789
EZ
31912011-11-22 Eli Zaretskii <eliz@gnu.org>
3192
3193 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3194 and header-lines, as they don't have one computed for them.
3195 (Bug#10098)
3196
3197 * .gdbinit (prow): Make displayed values more self-explaining.
3198 Add row's hash code.
3199
261b6fd4
LMI
32002011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3201
3202 * process.c (wait_reading_process_output): Fix asynchrounous
3203 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3204 (wait_reading_process_output): Add comment and URL.
261b6fd4 3205
e7cfd277
JD
32062011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3207
3208 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3209
a9b9b7f5
CY
32102011-11-21 Chong Yidong <cyd@gnu.org>
3211
3212 * window.c (Fnext_window, Fprevious_window): Doc fix.
3213
b0d15b4f
SM
32142011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3215
3216 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3217
fe7a3057
JB
32182011-11-20 Juanma Barranquero <lekktu@gmail.com>
3219
3220 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3221
d2999b1a
MR
32222011-11-20 Martin Rudalics <rudalics@gmx.at>
3223
3224 * window.c (Fset_window_combination_limit): Rename argument
3225 STATUS to LIMIT.
3226 (Vwindow_combination_limit): Remove "status" from doc-string.
3227
d5ff9cd0
AS
32282011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3229
3230 * m/ibms390.h: Remove.
3231 * m/ibms390x.h: Don't include "ibms390.h".
3232
a5bb9bd3
SM
32332011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3234
3235 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3236 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3237
cd1181db
JB
32382011-11-20 Juanma Barranquero <lekktu@gmail.com>
3239
3240 * casetab.c (Fset_case_table):
3241 * charset.c (Fcharset_after): Fix typos.
3242
615a3b8d 32432011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3244
17e845af
PE
3245 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3246 Otherwise, valgrind does not work on some platforms.
3247 Problem reported by Andreas Schwab in
6a0bf43d
PE
3248 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3249 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3250 is set, removing the need for VIRT_ADDRESS_VARIES.
3251 (PURE_P): Use a more-efficient implementation that needs just one
3252 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3253 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3254 to 4 (xorl, subq, cmpq, setbe).
3255 * alloc.c (pure): Always extern now, since that's the
3256 VIRT_ADDR_VARIES behavior.
3257 (PURE_POINTER_P): Use a single comparison, not two, for
3258 consistency with the new puresize.h.
3259 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3260 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3261 Remove VIRT_ADDR_VARIES no longer needed.
3262
f8fe6f96
EZ
32632011-11-19 Eli Zaretskii <eliz@gnu.org>
3264
3265 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3266 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3267 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3268 behave as if the cursor position were at the window margin.
3269
3270 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3271 and the cursor position is out of bounds, behave as if the cursor
3272 position were at the window margin. (Bug#10075)
3273
df05a53c
CY
32742011-11-18 Chong Yidong <cyd@gnu.org>
3275
3276 * window.c (Fwindow_combination_limit): Make first argument
3277 non-optional, since it is meaningless for live windows like the
3278 selected window.
61ccba97 3279
2071918e
DA
32802011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3281
3282 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3283
b50a28de
SM
32842011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3285
3286 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3287 (graft_intervals_into_buffer): Simplify.
3288
015137db
EZ
32892011-11-18 Eli Zaretskii <eliz@gnu.org>
3290
3291 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3292 hash values of the two rows.
3293 (copy_row_except_pointers): Preserve the used[] arrays and the
3294 hash values of the two rows. (Bug#10035)
68c95424 3295 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3296
3297 * xdisp.c (row_hash): New function, body extracted from
3298 compute_line_metrics.
3299 (compute_line_metrics): Call row_hash, instead of computing the
3300 hash code inline.
3301
3302 * dispnew.c (verify_row_hash): Call row_hash for computing the
3303 hash code of a row, instead of duplicating code from xdisp.c.
3304
3305 * dispextern.h (row_hash): Add prototype.
3306
a2addb04
TH
33072011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3308
3309 * frame.c (delete_frame): Don't delete the terminal when the last
3310 X frame is closed if emacs is built with GTK toolkit.
3311
df85d315
JB
33122011-11-17 Juanma Barranquero <lekktu@gmail.com>
3313
3314 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3315
a0c2d0ae
MR
33162011-11-17 Martin Rudalics <rudalics@gmx.at>
3317
3318 * window.c (Vwindow_splits): Rename to
3319 Vwindow_combination_resize. Suggested by Juri Linkov.
3320 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3321 of Vwindow_splits.
3322
58179cce
JB
33232011-11-16 Juanma Barranquero <lekktu@gmail.com>
3324
7877f373
JB
3325 * nsfns.m (Fns_font_name):
3326 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3327
b6f67890
MR
33282011-11-16 Martin Rudalics <rudalics@gmx.at>
3329
3330 * window.h (window): Rename slot "nest" to "combination_limit".
3331 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3332 (Fset_window_nest): Rename to Fset_window_combination_limit.
3333 (Vwindow_nest): Rename to Vwindow_combination_limit.
3334 (recombine_windows, make_parent_window, make_window)
3335 (Fsplit_window_internal, saved_window)
3336 (Fset_window_configuration, save_window_save): Rename all
3337 occurrences of window_nest to window_combination_limit.
3338
c7015153
JB
33392011-11-15 Juanma Barranquero <lekktu@gmail.com>
3340
3341 * image.c (imagemagick_load_image): Fix typo.
3342
322ad6ec
EZ
33432011-11-14 Eli Zaretskii <eliz@gnu.org>
3344
3345 * xdisp.c (display_line): Move the call to
3346 highlight_trailing_whitespace before the call to
3347 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3348 faces of all the glyphs to compute ROW's hash value.
3349 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3350
f067b8ec
JB
33512011-11-14 Juanma Barranquero <lekktu@gmail.com>
3352
3353 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3354 just return (bug#10044).
3355
1e5b2111
EZ
33562011-11-12 Eli Zaretskii <eliz@gnu.org>
3357
7ef3cbd5
EZ
3358 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3359 with user-defined heap size. Bump the default size of the temacs
3360 heap to 27MB, to avoid memory warning when running temacs.
3361 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3362
1e5b2111
EZ
3363 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3364 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3365 (verify_row_hash) [XASSERTS]: New function.
3366 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3367 that the hash value of glyph rows is correct.
1e5b2111 3368
89d61221
MR
33692011-11-12 Martin Rudalics <rudalics@gmx.at>
3370
3371 * window.h (window): Remove splits slot.
3372 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3373 (Fdelete_other_windows_internal, make_parent_window)
3374 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3375 (Fset_window_configuration, save_window_save): Don't deal with
3376 split status of windows.
3377 (saved_window): Remove splits slot.
3378 (Vwindow_splits): Rewrite doc-string.
3379
97f18cc8
JD
33802011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3381
3382 * xfns.c (unwind_create_frame):
3383 * nsfns.m (unwind_create_frame):
3384 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3385 Vframe_list (Bug#9999).
3386
22a648b4
DA
33872011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3388
0b381c7e 3389 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3390
659afede
KH
33912011-11-11 Kenichi Handa <handa@m17n.org>
3392
3393 * callproc.c (Fcall_process): Set the member dst_multibyte of
3394 process_coding.
3395
9ac0394b
KH
33962011-11-11 Johan Bockgård <bojohan@gnu.org>
3397
3398 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3399 avoid a crash (bug#9496).
3400
2fbdc249
CY
34012011-11-09 Chong Yidong <cyd@gnu.org>
3402
3403 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3404 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3405
ac6b1f81
PE
34062011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3407
3408 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3409
09db192c
PE
34102011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3411
3412 Avoid some portability problems by eschewing 'extern inline' functions.
3413 The trivial performance wins aren't worth the portability hassles; see
3414 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3415 et seq.
3416 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3417 (window_box_width, window_box_left, window_box_left_offset)
3418 (window_box_right, window_box_right_offset): Undo previous change,
3419 by removing the "extern"s.
3420 * intervals.c (adjust_intervals_for_insertion)
3421 (adjust_intervals_for_deletion): Undo previous change,
3422 making these static again.
3423 (offset_intervals, temp_set_point_both, temp_set_point)
3424 (copy_intervals_to_string): No longer inline.
3425 * xdisp.c (window_text_bottom_y, window_box_width)
3426 (window_box_height, window_box_left_offset)
3427 (window_box_right_offset, window_box_left, window_box_right)
3428 (window_box): No longer inline.
3429
105216ed
CY
34302011-11-08 Chong Yidong <cyd@gnu.org>
3431
3432 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3433 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3434 Signal an error if not a live window.
105216ed
CY
3435 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3436 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3437
ae9e237f
JB
34382011-11-07 Juanma Barranquero <lekktu@gmail.com>
3439
3440 * lisp.h (syms_of_abbrev): Remove declaration.
3441 Reported by CHENG Gao <chenggao@royau.me>.
3442
c7aa8333
EZ
34432011-11-07 Eli Zaretskii <eliz@gnu.org>
3444
3445 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3446 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3447 of temacs in GUI mode.
3448
be7f5545
MR
34492011-11-07 Martin Rudalics <rudalics@gmx.at>
3450
3451 * window.h: Declare delete_all_child_windows instead of
3452 delete_all_subwindows.
3453 * window.c (Fwindow_nest, Fset_window_nest)
3454 (Fset_window_new_total, Fset_window_new_normal)
3455 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3456 (delete_all_subwindows): Rename to delete_all_child_windows.
3457 (Fdelete_other_windows_internal, Fset_window_configuration):
3458 Call delete_all_child_windows instead of delete_all_subwindows.
3459 * frame.c (delete_frame): Call delete_all_child_windows instead
3460 of delete_all_subwindows.
3461
ca78dc43
PE
34622011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3463
3464 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3465 This is also needed for porting to any host where GC_MARK_STACK is
3466 not GC_MAKE_GCPROS_NOOPS.
3467 (which_symbols): Use it.
3468
a0241d01
KH
34692011-11-07 Kenichi Handa <handa@m17n.org>
3470
3471 * coding.c (coding_set_destination): Check coding->src_pos only
3472 when coding->src_object is a buffer (bug#9910).
3473
3474 * process.c (send_process): Set the member src_multibyte of coding
3475 to 0 (bug#9911) when sending a unibyte text.
3476
3477 * callproc.c (Fcall_process): Set the member src_multibyte of
3478 process_coding to 0 (bug#9912).
3479
a64bfdfa 34802011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3481
3482 * xmenu.c (cleanup_widget_value_tree): New function.
3483 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3484 calling free_menubar_widget_value_tree directly (Bug#9830).
3485
cb41b32a
PE
34862011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3487
3488 Fix some portability problems with 'inline'.
3489 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3490 (window_box_width, window_box_left, window_box_left_offset)
3491 (window_box_right, window_box_right_offset): Declare extern.
3492 Otherwise, these inline functions do not conform to C99 and
3493 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3494 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3495 * intervals.c (adjust_intervals_for_insertion)
3496 (adjust_intervals_for_deletion): Now extern, because otherwise the
3497 extern inline functions 'offset_intervals' couldn't refer to it.
3498 (static_offset_intervals): Remove.
3499 (offset_intervals): Rewrite using the old contents of
3500 static_offset_intervals. The old version didn't conform to C99
3501 because an extern inline function contained a reference to an
3502 identifier with static linkage.
3503
b7041366
AS
35042011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3505
3506 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3507 GC.
3508
88a37c4d
EZ
35092011-11-06 Eli Zaretskii <eliz@gnu.org>
3510
3511 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3512 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3513 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3514 return Qleft_to_right.
3515
49745b39
CY
35162011-11-06 Chong Yidong <cyd@gnu.org>
3517
3518 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3519 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3520 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3521 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3522 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3523 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3524 (Fwindow_vscroll): Doc fix.
3525 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3526 argument, since it makes no sense to pass a live window and for
3527 consistency with window-child.
3528
1f05cd82
CS
35292011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3530
3531 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3532 support MSVC.
3533
22610910
JR
35342011-11-05 Jason Rumney <jasonr@gnu.org>
3535
3536 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3537 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3538 fonts (Bug#6029).
3539 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3540 bitwise arithmetic preventing use of unicode-sip and non-truetype
3541 opentype fonts.
3542
a06776b2
EZ
35432011-11-05 Eli Zaretskii <eliz@gnu.org>
3544
3ad924ba
EZ
3545 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3546 "emacs"-only part.
3547
a06776b2
EZ
3548 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3549 initialization code to keep similarity to xfns.c after changes
3550 from 2011-11-05.
3551
c9e7db78
JD
35522011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3553
a97f8f3f
JD
3554 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3555 (unwind_create_frame): New function (Bug#9943).
3556 (Fx_create_frame): Restructure code to be more similar to the one in
3557 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3558 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3559 Move terminal->reference_count++ just before making the frame official
3560 (Bug#9943).
3561
3562 * nsterm.m (x_free_frame_resources): New function.
3563 (x_destroy_window): Move code to x_free_frame_resources.
3564
c9e7db78 3565 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3566 (Fx_create_frame, x_create_tip_frame):
3567 Move terminal->reference_count++ just before making the frame
75f1671a 3568 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3569 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3570
a6fc3b5c
EZ
35712011-11-05 Eli Zaretskii <eliz@gnu.org>
3572
3573 Support MSVC build with newer versions of Visual Studio.
3574 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3575 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3576 nt/gmake.defs.
3577
3578 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3579 which are not supported by MSVC.
3580 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3581 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3582 bitfields.
3583 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3584 types in bitfields.
3585 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3586
3587 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3588
58179cce 35892011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3590
3591 Support MSVC build with newer versions of Visual Studio.
3592 * w32.c: Don't include w32api.h for MSVC.
3593 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3594
3595 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3596 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3597 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3598 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3599 e_* cousins.
3600 (alloca) [_MSC_VER]: Define to _alloca.
3601
3602 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3603
3604 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3605
a58c13ed
EZ
36062011-11-04 Eli Zaretskii <eliz@gnu.org>
3607
3608 * xdisp.c (note_mouse_highlight): If either of
3609 previous/next-single-property-change returns nil, treat that as
3610 the beginning or the end of the buffer. (Bug#9955)
3611
fe0b6370
JD
36122011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3613
a58c13ed 3614 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3615 label is not null (Bug#9951).
3616 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3617 may be NULL.
3618
89bd5ee1
EZ
36192011-11-04 Eli Zaretskii <eliz@gnu.org>
3620
3621 * window.c (Fwindow_body_size): Mention in the doc string that the
3622 return value is in frame's canonical units. (Bug#9949)
3623
84c3edb9
EZ
36242011-11-03 Eli Zaretskii <eliz@gnu.org>
3625
4e2fb5c7
EZ
3626 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3627
84c3edb9 3628 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3629 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3630 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3631
bc17a887
EZ
36322011-11-01 Eli Zaretskii <eliz@gnu.org>
3633
3634 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3635 Don't stop backward scan on the continuation glyph, even though
3636 its CHARPOS is positive.
6d5eb5b0
SM
3637 (mouse_face_from_buffer_pos, note_mouse_highlight):
3638 Rename cover_string to disp_string.
bc17a887 3639
4ee88440
MR
36402011-11-01 Martin Rudalics <rudalics@gmx.at>
3641
3642 * window.c (temp_output_buffer_show): Don't use
3643 Vtemp_buffer_show_specifiers.
3644 (Vtemp_buffer_show_specifiers): Remove unused variable.
3645
c2ff3c02
EZ
36462011-10-30 Eli Zaretskii <eliz@gnu.org>
3647
3648 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3649 past the beginning of the current glyph matrix.
3650
58179cce 36512011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3652
3653 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3654 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3655 HAVE_GTK3 (Bug#9869).
b77a6a7f 3656
3b574623
JD
3657 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3658 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3659
b77a6a7f
JD
3660 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3661
3662 * xterm.c: Declare x_handle_net_wm_state to return int.
3663 (handle_one_xevent): Check if we are iconified but don't have
3664 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3665 (get_current_wm_state): Return non-zero if not hidden,
3666 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3667 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3668 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3669 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3670
196e41e4
PE
36712011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3672
3673 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3674 so that this new function doesn't get optimized away by a
3675 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3676
021f2e1a
AS
36772011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3678
3679 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3680
8b058d44
EZ
36812011-10-29 Eli Zaretskii <eliz@gnu.org>
3682
3683 Fix the `xbytecode' command.
3684 * .gdbinit (xprintbytestr): New command.
b50a28de 3685 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3686 (xbytecode): Print the byte-code string as well.
3687
4452fb80
EZ
36882011-10-29 Kim Storm <storm@cua.dk>
3689
8b058d44
EZ
3690 * alloc.c (which_symbols): New function.
3691
21b72067
AS
36922011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3693
3694 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3695 line. (Bug#9903)
3696
83ed7b5c
GM
36972011-10-29 Glenn Morris <rgm@gnu.org>
3698
3699 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3700 Not clear what it was for, and it causes various bugs. (Bug#9839)
3701
5a7a728b
EZ
37022011-10-28 Eli Zaretskii <eliz@gnu.org>
3703
3704 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3705 possible random value that matches one of those tested as
3706 condition to clear the mouse face.
3707
d3d0842f
CY
37082011-10-28 Chong Yidong <cyd@gnu.org>
3709
3710 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3711
31b39d13
DN
37122011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3713
3714 * window.c (make_window): Initialize phys_cursor_on_p.
3715
9aba6043
SM
37162011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3717
3718 * lisp.h (struct Lisp_Symbol): Update comments.
3719
c20992f4
JB
37202011-10-28 Juanma Barranquero <lekktu@gmail.com>
3721
3722 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3723
db4f02f2
EZ
37242011-10-28 Eli Zaretskii <eliz@gnu.org>
3725
3726 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3727 <oslsachem@gmail.com> for helping to debug this.
3728
3729 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3730 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3731 (g_b_init_get_glyph_outline_w): New static variables.
3732 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3733 (GetGlyphOutlineW_Proc): New typedefs.
3734 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3735 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3736 New functions.
3737 (w32font_open_internal, compute_metrics):
3738 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3739 instead of calling the "wide" APIs directly.
3740
3741 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3742
3743 * w32.h (syms_of_w32font): Add prototype.
3744
87e68db4
JB
37452011-10-27 Juanma Barranquero <lekktu@gmail.com>
3746
3747 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3748 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3749 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3750 (Fmove_to_window_line): Doc fix.
3751
435c1d67
CY
37522011-10-27 Chong Yidong <cyd@gnu.org>
3753
3754 * process.c (make_process): Set gnutls_state to NULL.
3755
3756 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3757 non-NULL, regardless of GNUTLS_INITSTAGE.
3758 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3759 an error. Set process slots as soon as we allocate them.
3760
3761 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3762
9c6c6f49
CY
37632011-10-27 Chong Yidong <cyd@gnu.org>
3764
9aba6043
SM
3765 * gnutls.c (emacs_gnutls_deinit): New function.
3766 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3767 (Fgnutls_deinit, Fgnutls_boot): Use it.
3768
3769 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3770 (deactivate_process): Call emacs_gnutls_deinit.
3771
657d08d3
JB
37722011-10-27 Juanma Barranquero <lekktu@gmail.com>
3773
3774 * image.c (x_create_x_image_and_pixmap):
3775 * w32.c (sys_rename, w32_delayed_load):
3776 * w32font.c (fill_in_logfont):
3777 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3778
5430d399
JB
37792011-10-26 Juanma Barranquero <lekktu@gmail.com>
3780
3781 * w32fns.c (w32_default_color_map): New function,
3782 extracted from Fw32_default_color_map.
a7ef684b 3783 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3784
fe0055fa
PE
37852011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3786
3787 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3788
e6346438
SM
37892011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3790
3791 * keyboard.c (test_undefined): New function (bug#9751).
3792 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3793
e112cc37
ET
37942011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3795
3796 * sysdep.c (init_sys_modes): Fix the check for the controlling
3797 terminal (Bug#6649).
3798
7b5d6677
EZ
37992011-10-20 Eli Zaretskii <eliz@gnu.org>
3800
3801 * dispextern.h (struct bidi_it): New member next_en_type.
3802
3803 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3804 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3805 current character, check also for next_en_type being WEAK_EN.
3806 (bidi_resolve_weak): Don't enter the expensive loop if the current
3807 position is before next_en_pos. Record the bidi type of the first
3808 non-ET, non-BN character we find, in addition to its position.
3809 (bidi_level_of_next_char): Invalidate next_en_type when
3810 next_en_pos is over-stepped.
3811
7da0b018
PE
38122011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3813
3814 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3815 * editfns.c: Rewrite current-time-zone so that it invokes
3816 the equivalent of (format-time-string "%Z") to get the time zone name.
3817 This fixes a bug when the time zone name contains characters that
3818 need converting from the system time locale to Emacs internal format.
3819 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3820 that patch fixed format-time-string to do the conversion, but
3821 I forgot to fix current-time-zone.
3822 (format_time_string): New function, containing most of
3823 what Fformat_time_string used to contain.
3824 (Fformat_time_string): Rewrite in terms of format_time_string.
3825 This doesn't change this function's behavior.
3826 (current-time-zone): Rewrite to use format_time_string.
3827 This fixes the bug reported by Michael Schierl in
3828 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3829 Jason Rumney's 2007-06-07 change worked around this bug, but
3830 didn't fix it.
3831 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3832
8547b010
EZ
38332011-10-19 Eli Zaretskii <eliz@gnu.org>
3834
3835 * xdisp.c (start_display): If the character at POS is displayed
3836 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3837 (try_window_reusing_current_matrix): If a line ends in a display
3838 vector or the next line starts in a display vector, continue
3839 redrawing the window even though the character position of
3840 start_row was reached.
8547b010
EZ
3841 (Bug#9771, part 2)
3842
4e948d15
CY
38432011-10-18 Chong Yidong <cyd@gnu.org>
3844
3845 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3846 with nobreak-char-display too.
3847
4787455f
EZ
38482011-10-18 Eli Zaretskii <eliz@gnu.org>
3849
3850 Fix part 3 of bug#9771.
3851 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3852 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3853 non-neutral characters if the current character is a paragraph
3854 separator (a.k.a. Newline). This avoids running the same
3855 expensive loop twice, once when we consume the preceding newline
3856 and the other time when the line actually needs to be displayed.
3857 Avoid the loop when we see neutrals on the base embedding level
3858 following a character whose directionality is the same as the
3859 paragraph's. This avoids running the expensive loop when a line
3860 ends in a long sequence of neutrals, like control characters.
3861 Add assertion against STRONG_AL type. Slightly rearrange code
3862 that determines the type of a neutral given the first non-neutral
3863 that follows it.
3864 (bidi_level_of_next_char): Set next_en_pos to zero when
3865 invalidating its info.
3866
2c91f553
EZ
38672011-10-17 Eli Zaretskii <eliz@gnu.org>
3868
3869 * xdisp.c (push_display_prop): Determine whether to record string
3870 or buffer position by IT->string, not by IT->method. Allow
3871 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3872 (move_it_vertically_backward): Don't look for character position
3873 immediately after the newline when in a continuation line.
3874 (Bug#9771, part 1)
2c91f553 3875
c7b08b0d
MR
38762011-10-15 Martin Rudalics <rudalics@gmx.at>
3877
3878 * window.c (coordinates_in_window): Rewrite and delabelize
3879 vertical border check. (Bug#5357) (Bug#9618)
3880
6b02f655
SM
38812011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3882
3883 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3884 errors in XSetWindowBorder (bug#9310).
3885
81d40c92
DA
38862011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3887
3888 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3889 avoid crash when xmalloc overrun checking is enabled.
3890
d4172c3b
EZ
38912011-10-13 Eli Zaretskii <eliz@gnu.org>
3892
3893 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3894 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3895 cursor motion with <left> and <right> arrow keys.
3896
3897 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3898 some callers set that themselves.
3899
b00eea75
EZ
39002011-10-12 Eli Zaretskii <eliz@gnu.org>
3901
3902 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3903 display string and the previous row comes from the same string and
3904 is empty. (Bug#9739) (Bug#9738)
3905
8fe012c4
SM
39062011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3907
3908 * doc.c (get_doc_string): Encode file name (bug#9735).
3909
0074aef2
EZ
39102011-10-12 Eli Zaretskii <eliz@gnu.org>
3911
79beb178
EZ
3912 * bidi.c (bidi_level_of_next_char):
3913 * xdisp.c (get_visually_first_element): Remove old incorrect
3914 comments regarding the Unicode Line Separator character.
3915
0074aef2
EZ
3916 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3917
6e4b3fbe
DA
39182011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3919
3920 * alloc.c (Fgc_status): Do not access beyond zombies array
3921 boundary if nzombies > MAX_ZOMBIES.
3922 * alloc.c (dump_zombies): Add missing format specifier.
3923
0324f3af
PE
39242011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3925
b5525cac
PE
3926 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3927 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3928
0324f3af
PE
3929 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3930 Some packages use them to denote characters with modifiers.
3931
e9b5f888
AS
39322011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3933
3934 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3935 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3936 matching a pp-number. Rename parameter var to var1.
3937
127827c0
SM
39382011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3939
3940 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3941
c8fd3bd0
GM
39422011-10-08 Glenn Morris <rgm@gnu.org>
3943
3944 * callint.c (Fcall_interactively): Give a more explicit error for the
3945 'c' case with a non-character input. (Bug#8479)
3946
352ec8ff
EZ
39472011-10-08 Eli Zaretskii <eliz@gnu.org>
3948
03669ccb
EZ
3949 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3950 lines.
7061c986
EZ
3951 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3952 lines that are hscrolled on the left.
03669ccb 3953
352ec8ff
EZ
3954 * dispnew.c (buffer_posn_from_coords): Account for a possible
3955 presence of header-line. (Bug#4426)
3956
a66cfb1c
SM
39572011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3958
6b02f655
SM
3959 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3960 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3961
7c5ee88e
PE
39622011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3963
3964 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3965 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3966 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3967 this makes Emacs dump core during garbage collection on rare
3968 occasions. sizeof is obviously inferior to offsetof here, so
3969 stick with offsetof.
3970 (GC_POINTER_ALIGNMENT): New macro.
3971 (mark_memory): Omit 3rd (offset) arg; caller changed.
3972 Don't assume EMACS_INT alignment is the same as pointer alignment.
3973
df1bbe5b
SM
39742011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3975
3976 * keyboard.c (read_key_sequence_remapped): New var.
3977 (read_key_sequence): Compute remapping in the right buffer.
3978 (command_loop_1): Use read_key_sequence's remapping directly.
3979
51553db6
SM
39802011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3981
32c1fffd
SM
3982 * dired.c (file_name_completion): Don't expand file name.
3983 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3984 before checking file name handler.
3985
51553db6
SM
3986 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3987 they've been requested explicitly (bug#9591).
3988
b6bd1599 39892011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3990
3991 * keymap.c (Fsingle_key_description): Use make_specified_string
3992 instead of build_string to build string from push_key_description.
3993 (Bug#5193)
3994
f701dc2a
PE
39952011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3996
4222c55d
PE
3997 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3998 This fixes a Y2038 bug on 64-bit hosts.
3999 * buffer.c (reset_buffer):
4000 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4001 (Fclear_buffer_auto_save_failure):
4002 Use 0, not -1, to represent an unset failure time, since time_t
4003 might not be signed.
4004
f701dc2a
PE
4005 Remove dependency on glibc malloc internals.
4006 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4007 Move back here from lisp.h, but with their new implementations.
4008 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4009 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4010 * charset.c (charset_table_init): New static var.
4011 (syms_of_charset): Use it instead of xmalloc. This removes a
4012 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4013 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4014 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4015 Move back to alloc.c.
4016 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4017 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4018
9ceebf39
JD
40192011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4020
4021 * nsterm.m (windowDidResize): Call x_set_window_size only when
4022 ns_in_resize is true. Otherwise set pixelwidth/height and
4023 call change_frame_size (Bug#9628).
4024
cb993c58
PE
40252011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4026
3930c88b
PE
4027 Port --enable-checking=all to Fedora 14 x86-64.
4028 * charset.c (syms_of_charset): Also account for glibc malloc's
4029 internal overhead when calculating the initial malloc maximum.
4030
cb993c58
PE
4031 Port --enable-checking=all to Fedora 14 x86.
4032 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4033 Move to lisp.h.
4034 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4035 (overrun_check_realloc, overrun_check_free):
4036 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4037 That way, xmalloc returns a properly-aligned pointer even if
4038 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4039 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4040 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4041 into account when calculating the initial malloc maximum.
4042 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4043 Move here from alloc.c, so that charset.c can use it too.
4044 Properly align; the old code wasn't right for common 32-bit hosts
4045 when configured with --enable-checking=all.
4046 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4047 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4048
31bed486
EZ
40492011-09-29 Eli Zaretskii <eliz@gnu.org>
4050
04c70788 4051 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4052 use EDOM.
4053
fbcaa2f3
EZ
40542011-09-28 Eli Zaretskii <eliz@gnu.org>
4055
4056 * xdisp.c (compute_display_string_end): If there's no display
4057 string at CHARPOS, return -1.
4058
4059 * bidi.c (bidi_fetch_char): When compute_display_string_end
4060 returns a negative value, treat the character as a normal
4061 character not covered by a display string. (Bug#9624)
4062
a239d4e9
JB
40632011-09-28 Juanma Barranquero <lekktu@gmail.com>
4064
4065 * lread.c (Fread_from_string): Fix typo in docstring.
4066
88652fd5
EZ
40672011-09-27 Eli Zaretskii <eliz@gnu.org>
4068
4069 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4070 newline, reseat the iterator instead of bidi-iterating there one
4071 character at a time. (Bug#9610)
32c1fffd
SM
4072 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4073 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4074
ed497dd4
AS
40752011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4076
4077 * lread.c (readevalloop): Use correct code for NBSP.
4078 (read1): Likewise. (Bug#9608)
4079
b2bf61aa
MA
40802011-09-25 Michael Albinus <michael.albinus@gmx.de>
4081
4082 * dbusbind.c (Fdbus_register_signal): When service is not
4083 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4084
32bbb17c
GM
40852011-09-25 Glenn Morris <rgm@gnu.org>
4086
4087 * buffer.c (truncate-lines): Doc fix.
4088
94e0933e
CY
40892011-09-24 Chong Yidong <cyd@stupidchicken.com>
4090
4091 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4092 (Fset_window_next_buffers): Doc fix.
4093
cddde921
GM
40942011-09-24 Glenn Morris <rgm@gnu.org>
4095
4096 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4097
1260aef1
PE
40982011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4099
25b4bfa0
PE
4100 Fix minor problems found by static checking.
4101 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4102 * indent.c (Fvertical_motion): Fix == vs = typo.
4103
e3cbd34b
EZ
41042011-09-24 Eli Zaretskii <eliz@gnu.org>
4105
a66cfb1c
SM
4106 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4107 Default value is now t. Doc fix.
6bf7006f 4108
e3cbd34b 4109 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4110 logic when moving up, not only when moving down. Fix the
e3cbd34b 4111 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4112 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4113
4114 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4115 CHARPOS is covered by a display string which includes newlines.
4116 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4117 is covered by a display string with embedded newlines.
4118
a3de0cbd
MA
41192011-09-24 Michael Albinus <michael.albinus@gmx.de>
4120
4121 * dbusbind.c (Fdbus_register_signal): Add match rule to
4122 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4123 (Fdbus_register_method, Vdbus_registered_objects_table):
4124 Fix docstring.
a3de0cbd 4125
b260039d
JM
41262011-09-24 Jim Meyering <meyering@redhat.com>
4127
32c1fffd 4128 do not ignore write error for any output size
b260039d
JM
4129 The previous change was incomplete.
4130 While it makes emacs --batch detect the vast majority of stdout
4131 write failures, errors were still ignored whenever the output size is
4132 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4133 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4134 && echo FAIL: ignored write error
4135 FAIL: ignored write error
4136 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4137 && echo FAIL: ignored write error
4138 FAIL: ignored write error
4139 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4140
8eca8a7c
AS
41412011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4142
4143 * emacs.c (Fkill_emacs): In noninteractive mode exit
4144 non-successfully if a write error occurred on stdout. (Bug#9574)
4145
3341db62
EZ
41462011-09-21 Eli Zaretskii <eliz@gnu.org>
4147
4148 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4149 the xassert test.
4150
4151 * dispextern.h (struct it): Update the comment documenting what
4152 can it->OBJECT be.
4153
8c203dbf
EZ
41542011-09-20 Eli Zaretskii <eliz@gnu.org>
4155
4156 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4157 a display string, extend search for cursor position to end of row.
4158 (find_row_edges): If the row ends in a newline from a display
4159 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4160 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4161 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4162 non-empty line. Fixes confusing cursor motion with arrow keys at
4163 the beginning of a line that starts with whitespace.
8c203dbf 4164
a4824228
LMI
41652011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4166
4167 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4168 (bug#9493).
4169
33ed493b
CY
41702011-09-18 Chong Yidong <cyd@stupidchicken.com>
4171
4172 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4173 boolean (Bug#9154).
4174
56cd55c8
EZ
41752011-09-18 Eli Zaretskii <eliz@gnu.org>
4176
4177 * xdisp.c (display_line): Record maximum and minimum buffer
4178 positions even if no glyphs were produced (e.g., by a zero-width
4179 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4180 buffer positions that will be removed from the glyph row because
4181 they don't fit.
c02dcedf
EZ
4182 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4183 column is beyond frame width: don't subtract 1 "pixel" when
4184 computing width of the stretch.
3e62b7e0
EZ
4185 (reseat_at_next_visible_line_start): Undo the change made on
4186 2011-09-17 that saved paragraph information and restored it after
4187 the call to `reseat'. (Bug#9545)
56cd55c8 4188
5ed99d36 41892011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4190
4191 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4192 and turn window cursor on if cleared (Bug#9415).
4193
5ed99d36 41942011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4195
4196 * search.c (boyer_moore): Take unibyte characters from pattern
4197 literally. (Bug#9458)
4198
9bade7b2
EZ
41992011-09-18 Eli Zaretskii <eliz@gnu.org>
4200
4201 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4202
e5e9d610
PE
42032011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4204
87e4427a
PE
4205 Fix minor problem found by static checking.
4206 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4207 initialized, to pacify gcc -Wuninitialized.
4208
e5e9d610
PE
4209 * fileio.c: Report proper errno when syscall falls.
4210 (Finsert_file_contents): Save and restore errno,
4211 so that report_file_error outputs the correct diagnostic.
4212 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4213
a1674f0b
EZ
42142011-09-18 Eli Zaretskii <eliz@gnu.org>
4215
4216 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4217
fbfb6dd4
EZ
42182011-09-17 Eli Zaretskii <eliz@gnu.org>
4219
4220 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4221 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4222
bb187662
EZ
42232011-09-17 Eli Zaretskii <eliz@gnu.org>
4224
1137e8b8 4225 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4226 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4227
4228 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4229 (bidi_find_paragraph_start): Search back for paragraph beginning
4230 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4231 (bidi_move_to_visually_next): Only trigger paragraph-related
4232 computations when the last character is a newline or at EOB, not
4233 just any NEUTRAL_B. (Bug#9470)
4234
bb187662
EZ
4235 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4236 truncated lines if point is covered by a display string. (Bug#9524)
4237
2e621251
PE
42382011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4239
4240 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4241 (cons_to_x_long): New function.
4242 (lisp_data_to_selection_data): Use it. Correct the test for
4243 short-versus-long data; it was negated. Break out of vector
4244 loop, for efficiency, when a long datum is discovered.
4245
91a15bc6
SM
42462011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4247
4248 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4249
b41c3a35
EZ
42502011-09-16 Eli Zaretskii <eliz@gnu.org>
4251
4252 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4253 GCC PR/17406) by declaring this function with external scope.
4254
7812ba2d
PE
42552011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4256
4257 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4258 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4259
cf7edc2a
AS
42602011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4261
4262 * editfns.c (Fformat): Correctly handle text properties on "%%".
4263
bd01620e
EZ
42642011-09-15 Eli Zaretskii <eliz@gnu.org>
4265
4266 * xterm.c (x_draw_composite_glyph_string_foreground):
4267 * w32term.c (x_draw_composite_glyph_string_foreground):
4268 * term.c (encode_terminal_code):
4269 * composite.c (composition_update_it, get_composition_id):
4270 * xdisp.c (get_next_display_element)
4271 (fill_composite_glyph_string): Add comments about special meaning
4272 of TAB characters in a composition.
4273
a02719a3
PE
42742011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4275
4276 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4277 This occurs when processing a multibyte format.
4278 Problem reported by Wolfgang Jenker.
a02719a3 4279
72589a3c
JB
42802011-09-15 Johan Bockgård <bojohan@gnu.org>
4281
4282 * xdisp.c (try_cursor_movement): Only check for exact match if
4283 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4284
1c14176c
PE
42852011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4286
4287 Remove unused external symbols.
4288 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4289 * xdisp.c (calc_pixel_width_or_height): Now static.
4290 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4291 * indent.c (check_display_width):
4292 * w32term.c: Fix comment to match code.
4293 * xterm.c, xterm.h (x_catching_errors): Remove.
4294
d2eea5b5
PE
42952011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4296
4297 * xselect.c: Use signed conversions more consistently (Bug#9498).
4298 (selection_data_to_lisp_data): Assume incoming selection data are
4299 signed integers, not unsigned. This is to be consistent with
4300 outgoing selection data, which was modified to use signed integers
4301 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4302 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4303 expects long, not unsigned long.
4304
46888499
EZ
43052011-09-14 Eli Zaretskii <eliz@gnu.org>
4306
4307 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4308 computation of loop end. Reported by Johan Bockgård
4309 <bojohan@gnu.org>.
4310
ef8ef9fb
CY
43112011-09-13 Chong Yidong <cyd@stupidchicken.com>
4312
4313 * frame.c (Fother_visible_frames_p): Function deleted.
4314
fa819fed
EZ
43152011-09-12 Eli Zaretskii <eliz@gnu.org>
4316
4317 * indent.c (compute_motion): Process display vector front to back
4318 rather than the other way around. (Bug#2496)
4319
2ba8e008
SM
43202011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4321
4322 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4323
20f53c69
CY
43242011-09-11 Chong Yidong <cyd@stupidchicken.com>
4325
4326 * minibuf.c (Fread_from_minibuffer): Doc fix.
4327
d562d7a4
EZ
43282011-09-11 Eli Zaretskii <eliz@gnu.org>
4329
4330 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4331 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4332
1c4d7f3d
LMI
43332011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4334
4335 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4336 value for non-existent files.
4337
b885bf36
EZ
43382011-09-11 Eli Zaretskii <eliz@gnu.org>
4339
4340 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4341 set its "size" to -1. This will set the modtime_size field of
4342 the corresponding buffer to -1, which is what
4343 verify-visited-file-modtime expects for files that do not exist.
4344 (Bug#9139)
4345
6612f0bf
PE
43462011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4347
4348 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4349 here ...
4350 * lisp.h: ... from here. push_key_description is no longer
4351 defined in keyboard.c, so its declaration should not be in
4352 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4353 logically belongs with push_key_description.
4354
dfb3f755
PE
43552011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4356
4357 * buffer.h: Include <sys/types.h> instead of <time.h>.
4358 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4359 Problem reported by Herbert J. Skuhra.
4360
3134906c
LMI
43612011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4362
4363 * xml.c (parse_region): Make the parsing work for
4364 non-comment-starting XML files again (bug#9144).
4365
8d903f4e
AS
43662011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4367
4368 * image.c (gif_load): Fix calculation of bottom and right corner.
4369 (Bug#9468)
4370
80ad64f4
EZ
43712011-09-10 Eli Zaretskii <eliz@gnu.org>
4372
4373 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4374 redisplay in small windows.
4375
208a048d
EZ
43762011-09-09 Eli Zaretskii <eliz@gnu.org>
4377
4378 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4379
9b1c252e
MR
43802011-09-08 Martin Rudalics <rudalics@gmx.at>
4381
4382 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4383 Operate on live windows only.
4384
2949f33b
JB
43852011-09-08 Juanma Barranquero <lekktu@gmail.com>
4386
4387 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4388
e08dcafd
EZ
43892011-09-07 Eli Zaretskii <eliz@gnu.org>
4390
4391 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4392 only under bidi iteration.
4393
115b96bd
JD
43942011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4395
4396 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4397
c8199d0f
PE
43982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4399
4400 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4401 Without this fix, the command to link temacs failed due to an
4402 undefined symbol __builtin_isnan. This is because
4403 /usr/include/iso/math_c99.h #defines isnan(x) to
4404 __builtin_isnan(x), but the bundled gcc, which identifies itself
4405 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4406 a __builtin_isnan.
4407 * floatfns.c (isnan): #undef, and then #define to a clone of
4408 what's in data.c.
4409 (Fisnan): Always define, since it's always available now.
4410 (syms_of_floatfns): Always define isnan at the Lisp level.
4411
e39b275c 44122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4413
4414 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4415
b2db44d9 44162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4417
f4af5137 4418 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4419 The previous code assumed that file offsets (off_t values) fit in
4420 EMACS_INT variables, which is not true on typical 32-bit hosts.
4421 The code messed up by falsely reporting buffer overflow in cases
4422 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4423 when "big" contains more than 2**29 bytes, even though this
4424 inserts just one byte and does not overflow the buffer.
4425 (Finsert_file_contents): Store file offsets as off_t
4426 values, not as EMACS_INT values. Check for overflow when
4427 converting between EMACS_INT and off_t. When checking for
4428 buffer overflow or for overlap, take the offsets into account.
4429 Don't use EMACS_INT for small values where int suffices.
4430 When checking for overlap, fix a typo: ZV was used where
4431 ZV_BYTE was intended.
4432 (Fwrite_region): Don't assume off_t fits into 'long'.
4433 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4434
ecfc0a49
MA
44352011-09-05 Michael Albinus <michael.albinus@gmx.de>
4436
4437 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4438
6511acf2 44392011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4440
0999621a 4441 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4442
4443 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4444 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4445 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4446 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4447 (modify_event_symbol): Do not assume that the length of
4448 name_alist_or_stem is safe to alloca and fits in int.
4449 (Fexecute_extended_command): Likewise for function name and binding.
4450 (Frecursion_depth): Wrap around reliably on integer overflow.
4451 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4452 since some callers pass EMACS_INT values.
4453 (Fsingle_key_description): Don't crash if symbol name contains more
4454 than MAX_ALLOCA bytes.
4455 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4456 (get_minibuffer): Arg is now EMACS_INT, not int.
4457 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4458 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4459 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4460
2be7d702
PE
4461 * dbusbind.c (signature_cat): New function.
4462 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4463 Do not overrun buffer; instead, report string overflow.
4464
9d1df220
PE
4465 * dispnew.c (add_window_display_history): Don't overrun buffer.
4466 Truncate instead; this is OK since it's just a log.
4467
33ef5c64
PE
4468 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4469 even if the time zone offset is outlandishly large.
4470 Don't mishandle offset == INT_MIN.
4471
66c6fdd5
PE
4472 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4473 when creating daemon; the previous buffer-overflow check was incorrect.
4474
d749b01b
PE
4475 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4476 which has the guts of the old verror function.
4477
b5cd1905
PE
4478 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4479 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4480
6e1a67fb
PE
4481 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4482 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4483 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4484 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4485 length of string rather than counting it via multiple sprintfs;
4486 that's simpler and more reliable.
c21721cc
PE
4487 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4488 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4489 sprintf, in case result does not fit in int.
4490
c57b67fc
PE
4491 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4492 (fontset_from_font): Print it.
4493
8a401434
PE
4494 * frame.c (tty_frame_count): Now printmax_t, not int.
4495 (make_terminal_frame, set_term_frame_name): Print it.
4496 (x_report_frame_params): In X, window IDs are unsigned long,
4497 not signed long, so print them as unsigned.
4498 (validate_x_resource_name): Check for implausibly long names,
4499 and don't assume name length fits in 'int'.
4500 (x_get_resource_string): Don't blindly alloca invocation name;
4501 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4502 not fit in int.
4503
6e1a67fb
PE
4504 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4505 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4506 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4507
0df02bf3
PE
4508 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4509 Use esprintf, not sprintf, in case result does not fit in int.
4510
48e30793
PE
4511 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4512 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4513 it as a large positive number.
4514 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4515 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4516
a66ff6d8
PE
4517 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4518 in case result does not fit in int.
4519
aca216ff
PE
4520 * print.c (float_to_string): Detect width overflow more reliably.
4521 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4522 buffer overrun. Don't assume list length fits in 'int'. Treat
4523 print length of 0 as 0, not as infinity; to be consistent with other
4524 uses of print length in this function. Don't overflow print length
4525 index. Don't assume hash table size fits in 'long', or that
4526 vectorlike size fits in 'unsigned long'.
4527
31c286f7
PE
4528 * process.c (make_process): Use printmax_t, not int, to format
4529 process-name gensyms.
4530
55e5faa1
PE
4531 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4532
80f2e268
PE
4533 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4534 to avoid potential buffer overrun.
4535
670741ab
PE
4536 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4537 if X resource line is longer than 512 bytes.
4538
b7163a50
PE
4539 * xfns.c (x_window): Make sprintf buffer a bit bigger
4540 to avoid potential buffer overrun.
4541
ae58ff1f
PE
4542 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4543
c43c8a6a
PE
4544 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4545
3f8236f4
PE
45462011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4547
53e9fe90 4548 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4549 Without these, Emacs silently mishandles large integers sometimes.
4550 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4551 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4552
6511acf2
PE
4553 * xdisp.c (try_window_id): Check Emacs fixnum range before
4554 converting to 'int'.
806add1d 4555
6511acf2 4556 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4557 Check that an Emacs fixnum is in range before assigning it to 'int'.
4558 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4559 values converted from Emacs fixnums.
4560 (Frecenter): Don't wrap around a line count if it is out of 'int'
4561 range; instead, treat it as an extreme value.
4562 (Fset_window_configuration, compare_window_configurations):
4563 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4564
6511acf2
PE
4565 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4566 that can exceed INT_MAX. Check that EMACS_INT value is in range
4567 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4568 (match_limit): Don't assume that a fixnum can fit in 'int'.
4569
6511acf2 4570 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4571 exceed INT_MAX.
4572
6511acf2 4573 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4574 (Fvertical_motion): Don't wrap around LINES values that don't fit
4575 in 'int'. Instead, treat them as extreme values. This is good
4576 enough for windows, which can't have more than INT_MAX lines anyway.
4577
fcb901a7
LMI
45782011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4579
0f2f6b6d
LMI
4580 * Require libxml/parser.h to avoid compilation warning.
4581
fcb901a7
LMI
4582 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4583
4584 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4585 since this reportedly can destroy thread storage.
4586
6e20a0d4
CY
45872011-08-30 Chong Yidong <cyd@stupidchicken.com>
4588
4589 * syntax.c (find_defun_start): Update all cache variables if
4590 exiting early (Bug#9401).
4591
148ae00e
EZ
45922011-08-30 Eli Zaretskii <eliz@gnu.org>
4593
f6cfbd8f
EZ
4594 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4595
148ae00e
EZ
4596 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4597 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4598 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4599
4600 * term.c (tty_append_glyph): New function.
4601 (produce_stretch_glyph): Static function and its prototype deleted.
4602
a66cfb1c
SM
4603 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4604 Add prototypes.
148ae00e 4605
c4a07a4c
PE
46062011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4607
4608 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4609 when checking :margin (Bug#9390).
4610 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4611 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4612 so that the name doesn't mislead. All uses changed.
4613
6bc8cd65
JB
46142011-08-28 Johan Bockgård <bojohan@gnu.org>
4615
4616 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4617 set_tty_hooks.
4618
dca4927e
EZ
46192011-08-27 Eli Zaretskii <eliz@gnu.org>
4620
4621 * xdisp.c (move_it_to): Don't bail out early when reaching
4622 position beyond to_charpos, if we are scanning backwards.
4623 (move_it_vertically_backward): When DY == 0, make sure we get to
4624 the first character in the line after the newline.
4625
f2cad773
PE
46262011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4627
4628 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4629 (ccl_driver): Do not generate an out-of-range pointer.
4630 (Fccl_execute_on_string): Remove unnecessary check for
4631 integer overflow, noted by Stefan Monnier in
4632 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4633 Remove a FIXME that didn't need fixing.
4634 Simplify the newly-introduced buffer reallocation code.
4635
0cae2cdb
JB
46362011-08-27 Juanma Barranquero <lekktu@gmail.com>
4637
4638 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4639
5fc295a4 46402011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4641
70c60eb2 4642 Integer and memory overflow issues (Bug#9196).
726e0ab1 4643
d31850da
PE
4644 * doc.c (get_doc_string): Rework so that
4645 get_doc_string_buffer_size is the actual buffer size, rather than
4646 being 1 less than the actual buffer size; this makes xpalloc more
4647 convenient.
4648
a69fbedb
PE
4649 * image.c (x_allocate_bitmap_record, cache_image):
4650 * xselect.c (Fx_register_dnd_atom):
4651 Simplify previous changes by using xpalloc.
4652
fe5c5d37
PE
4653 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4654 since either will do and ptrdiff_t is convenient with xpalloc.
4655
0065d054
PE
4656 * charset.c (charset_table_size)
4657 (struct charset_sort_data.priority): Now ptrdiff_t.
4658 (charset_compare): Don't overflow if priorities differ greatly.
4659 (Fsort_charsets): Don't assume list length fits in int.
4660 Check for size-calculation overflow when allocating sort data.
4661 (syms_of_charset): Allocate an initial charset table that is
4662 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4663
4664 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4665
4666 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4667 The actual value is always <= INT_MAX, and leaving it unsigned made
4668 overflow checking harder.
4669
4670 * dispextern.h (struct glyph_matrix.rows_allocated)
4671 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4672 with xpalloc. The values are still always <= INT_MAX.
4673
4674 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4675
4676 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4677 (SAFE_NALLOCA): New macro.
4678
4679 * region-cache.c (struct boundary.pos, find_cache_boundary)
4680 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4681 (set_cache_region, invalidate_region_cache)
4682 (revalidate_region_cache, know_region_cache, region_cache_forward)
4683 (region_cache_backward, pp_cache):
4684 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4685 so that ptrdiff_t * can be passed to xpalloc.
4686 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4687 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4688 (pp_cache): Don't assume cache_len fits in int.
4689 * region-cache.h: Adjust extern decls to match.
4690
4691 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4692 EMACS_INT, since either will do, for xpalloc.
4693
4694 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4695 (xnmalloc, xnrealloc, xpalloc): New functions.
4696
726e0ab1
PE
4697 * bidi.c (bidi_shelve_header_size): New constant.
4698 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4699 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4700
51f30bc5 4701 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4702 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4703 (overlay_strings):
4704 Don't update size of array until after memory allocation succeeds,
4705 because xmalloc/xrealloc may not return.
0065d054
PE
4706 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4707 now that we have proper integer overflow checking.
4708 (record_overlay_string, overlay_strings): Catch overflows when
4709 calculating size of overlay_str_buf.
726e0ab1 4710
0065d054
PE
4711 * callproc.c (Fcall_process): Check for size overflow when
4712 calculating size of args2.
4713 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4714 Normally we prefer signed values, but sticking with ptrdiff_t would
4715 require adding more-complicated checks.
726e0ab1
PE
4716
4717 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4718 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4719 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4720 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4721
4722 * character.c (Fstring): Check for size-calculation overflow.
4723
4724 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4725 unnecessary integer overflow. Check for size overflow.
4726 (encode_coding_object): Don't update size until xmalloc succeeds.
4727
4728 * composite.c (get_composition_id): Check for overflow in glyph
4729 length calculations.
4730
4731 Integer and memory overflow fixes for display code.
4732 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4733 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4734 (scrolling_window): Check for overflow in size calculations.
4735 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4736 Don't assume glyph table len fits in int.
4737 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4738 (row_table_size): Now ptrdiff_t, not int.
4739 (scrolling_window): Avoid overflow in size calculations.
4740 Don't update size until allocation succeeds.
4741 * fns.c (concat): Check for overflow in size calculations.
4742 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4743 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4744 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4745
4746 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4747 (get_doc_string): Check for size calculation overflow.
4748 Don't update size until allocation succeeds.
4749 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4750 EMACS_INT, where ptrdiff_t will do.
4751 (Fsubstitute_command_keys): Check for string overflow.
4752
4753 * editfns.c (set_time_zone_rule): Don't assume environment length
4754 fits in int.
4755 (message_length): Now ptrdiff_t, not int.
4756 (Fmessage_box): Don't update size until allocation succeeds.
4757 Don't assume message length fits in int.
4758 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4759
0065d054
PE
4760 * emacs.c (main): Do not reallocate argv, since there is a null at
4761 the end that can be overwritten, and this way there's no need to
4762 worry about size-calculation overflow.
4763 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4764
4765 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4766 alloc succeeds.
4767 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4768
4769 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4770 (x_set_scroll_bar_width, x_figure_window_size):
4771 Check for integer overflow.
4772 (x_set_alpha): Do not assume XINT fits in int.
4773
4774 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4775 This is for the members text_lines, text_cols, total_lines, total_cols,
4776 where the system imposes an 'int' limit.
4777
4778 * fringe.c (Fdefine_fringe_bitmap):
4779 Don't update size until alloc works.
4780
4781 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4782 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4783
4784 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4785 Check for size-calculation overflow.
4786 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4787 do, as we prefer signed integers.
4788 (id_to_widget.max_size, id_to_widget.used)
4789 (xg_store_widget_in_map, xg_remove_widget_from_map)
4790 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4791 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4792 Use and return ptrdiff_t, not int.
4793 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4794 * gtkutil.h: Change prototypes to match the above.
4795
4796 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4797 are duplicate now that they've been promoted to lisp.h.
4798 (x_allocate_bitmap_record, x_alloc_image_color)
4799 (make_image_cache, cache_image, xpm_load):
4800 Don't update size until alloc is done.
4801 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4802 (x_detect_edges):
3256efce 4803 Check for size calculation overflow.
726e0ab1
PE
4804 (ct_colors_allocated_max): New constant.
4805 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4806 overflow.
3256efce 4807
726e0ab1
PE
4808 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4809 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4810 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4811 Use ptrdiff_t, not int, to count maps.
4812 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4813 calculations. Don't update size until allocation succeeds.
4814 Redo calculations to avoid overflow.
726e0ab1
PE
4815 * keyboard.h: Change prototypes to match the above.
4816
4817 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4818 to count maps.
4819 (current_minor_maps): Check for size calculation overflow.
4820 * keymap.h: Change prototypes to match the above.
4821
4822 * lread.c (read1, init_obarray): Don't update size until alloc done.
4823
4824 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4825 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4826
726e0ab1
PE
4827 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4828 Now ptrdiff_t, not int.
4829 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4830 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4831
4832 * process.c (Fnetwork_interface_list): Check for overflow
4833 in size calculation.
4834
4835 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4836
4837 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4838 overflow. Don't bother calling xmalloc when xrealloc will do.
4839
4840 * search.c (Freplace_match): Check for size calculation overflow.
4841 (Fset_match_data): Don't assume list lengths fit in 'int'.
4842
4843 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4844 for command line length. Do not attempt to address one before the
4845 beginning of an array, as that's not portable.
4846
4847 * term.c (max_frame_lines): Remove; unused.
4848 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4849 not int.
4850 (encode_terminal_code, calculate_costs): Check for size
4851 calculation overflow.
4852 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4853 table lengths and related sizes. Don't update size until alloc
4854 done. Redo calculations to avoid overflow.
4855 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4856
4857 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4858 subtracting pointers.
4859 (gobble_line): Check for overflow more carefully. Don't update size
4860 until alloc done.
4861
4862 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4863 Don't update size until alloc done.
4864 Redo size calculations to avoid overflow.
4865 Check for size calculation overflow.
0065d054 4866 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4867
4868 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4869 Use ptrdiff_t, not int, for sizes.
4870 (store_mode_line_noprop_char): Don't update size until alloc done.
4871
0065d054
PE
4872 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4873 Use ptrdiff_t, not int, for sizes.
4874 (Finternal_make_lisp_face, cache_face):
4875 Check for size calculation overflow.
4876 (cache_face): Treat size calculation overflows as if they were
4877 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4878
4879 * xfns.c (x_encode_text, x_set_name_internal)
4880 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4881 sizes, since they can exceed INT_MAX in size. Check for size
4882 calculation overflow.
4883
0065d054
PE
4884 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4885 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4886 Don't update size until alloc done.
4887
0065d054 4888 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4889 as sprintf is limited to int lengths.
1d526e2f 4890
252c5ee1
PE
4891 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4892 (X_LONG_MIN): New macros.
864d7ce7
PE
4893 Use them to make the following changes clearer.
4894 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4895 This change doesn't affect the value now, but it may help remind
4896 future maintainers not to raise the value too much later.
4897 (SELECTION_QUANTUM): Remove, replacing with ...
4898 (selection_quantum): ... new function, which avoids overflow.
4899 All uses changed.
4900 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4901 assumption that selection length fits in 'int'.
4902 (x_reply_selection_request, x_handle_selection_request)
4903 (x_get_window_property, receive_incremental_selection)
4904 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4905 (lisp_data_to_selection_data, clean_local_selection_data):
4906 Use ptrdiff_t, not int, to record length of selection.
4907 (x_reply_selection_request, x_get_window_property)
4908 (receive_incremental_selection, x_property_data_to_lisp):
4909 Redo calculations to avoid overflow.
4910 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4911 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4912 something.
4913 (x_get_window_property, receive_incremental_selection)
4914 (lisp_data_to_selection_data, x_property_data_to_lisp):
4915 Check for size-calculation overflow.
4916 (x_get_window_property, receive_incremental_selection)
4917 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4918 Don't store size until memory allocation succeeds.
4919 (x_get_window_property): Plug memory leak on memory exhaustion.
4920 Don't double-block input; malloc is safe here. Don't assume 2**34
4921 - 4 fits in unsigned long. Add an xassert to check
4922 XGetWindowProperty overflow. Be more careful about overflow
4923 calculations, and distinguish size from memory overflow better.
4924 (receive_incremental_selection): When tracing, don't assume
4925 unsigned int is less than INT_MAX.
4926 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4927 harmful) conversions of unsigned short to int.
4928 (lisp_data_to_selection_data): Don't assume that integers
4929 in the range -65535 through -1 fit in an X unsigned short.
4930 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4931 result parameters unless successful. Rely on cons_to_unsigned
4932 to report problems with elements; the old code wasn't right anyway.
4933 (x_check_property_data): Check for int overflow; we cannot use
4934 a wider type due to X limits.
4935 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4936
726e0ab1 4937 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4938
0065d054
PE
4939 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4940 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4941 (x_color_cells): Don't store size until memory allocation succeeds.
4942 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4943 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4944 (x_term_init): Don't assume length fits in int (sprintf is limited
4945 to int size).
bc18e09d 4946
ebfa62c0
PE
4947 Use ptrdiff_t for composition IDs.
4948 * character.c (lisp_string_width):
4949 * composite.c (composition_table_size, n_compositions)
4950 (get_composition_id, composition_gstring_from_id):
4951 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4952 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4953 * window.c (Frecenter):
4954 Use ptrdiff_t, not int, for composition IDs.
4955 * composite.c (get_composition_id): Check for integer overflow.
4956 * composite.h: Adjust prototypes to match the above changes.
4957
d3411f89
PE
4958 Use ptrdiff_t for hash table indexes.
4959 * category.c (hash_get_category_set):
4960 * ccl.c (ccl_driver):
4961 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4962 * coding.c (coding_system_charset_list, detect_coding_system):
4963 * coding.h (struct coding_system.id):
4964 * composite.c (get_composition_id, gstring_lookup_cache):
4965 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4966 * image.c (xpm_get_color_table_h):
4967 * lisp.h (hash_lookup, hash_put):
4968 * minibuf.c (Ftest_completion):
4969 Use ptrdiff_t for hash table indexes, not int (which is too
4970 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4971 32-bit --with-wide-int hosts).
4972
e097a6fa
PE
4973 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4974 Add a FIXME comment about memory leaks.
4975 (syms_of_charset): Don't assume xmalloc returns.
4976
5637687f
PE
4977 Don't assume that stated character widths fit in int.
4978 * character.c (Fchar_width, c_string_width, lisp_string_width):
4979 * character.h (CHAR_WIDTH):
4980 * indent.c (MULTIBYTE_BYTES_WIDTH):
4981 Use sanitize_char_width to avoid undefined and/or bad behavior
4982 with outlandish widths.
a66cfb1c 4983 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4984 now that we have two such functions. All uses changed.
4985 (sanitize_char_width): New inline function.
4986
a2271ba2
PE
4987 Don't assume that tab-width fits in int.
4988 * character.h (sanitize_width): New inline function.
4989 (SANE_TAB_WIDTH): New macro.
4990 (ASCII_CHAR_WIDTH): Use it.
4991 * indent.c (sane_tab_width): Remove. All uses replaced by
4992 SANE_TAB_WIDTH (current_buffer).
4993 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4994
18c52557
PE
4995 * fileio.c: Integer overflow issues with file modes.
4996 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4997
caeeedc1
PE
4998 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4999 Remove unreachable code.
5000 (read_hex, load_charset_map_from_file): Check for integer overflow.
5001
6df6ae42 5002 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5003 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5004 (x_send_scroll_bar_event): Likewise. Check that the size does not
5005 exceed limits imposed by XClientMessageEvent, as well as the usual
5006 ptrdiff_t and size_t limits.
5007
b13995db
PE
5008 * keyboard.c: Overflow, signedness and related fixes.
5009 (make_lispy_movement): Use same integer type in forward decl
5010 that is used in the definition.
5011 (read_key_sequence, keyremap_step):
5012 Change bufsize argument back to int, undoing my 2011-03-30 change.
5013 We prefer signed types, and int is wide enough here.
5014 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5015 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5016 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5017 length, not size_t. Use ptrdiff_t for index, not int.
5018 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5019 possibility of integer overflow.
5020
13464394
PE
5021 Overflow, signedness and related fixes for images.
5022
5023 * dispextern.h (struct it.stack[0].u.image.image_id)
5024 (struct_it.image_id, struct image.id, struct image_cache.size)
5025 (struct image_cache.used, struct image_cache.ref_count):
5026 * gtkutil.c (update_frame_tool_bar):
5027 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5028 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5029 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5030 * nsmenu.m (update_frame_tool_bar):
5031 * xdisp.c (calc_pixel_width_or_height):
5032 * xfns.c (image_cache_refcount):
5033 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5034 on typical 64-bit hosts.
5035
5036 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5037 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5038 Omit unnecessary casts to int.
5039 (parse_image_spec): Check that integers fall into 'int' range
5040 when the callers expect that.
5041 (image_ascent): Redo ascent calculation to avoid int overflow.
5042 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5043 (lookup_image): Remove unnecessary tests.
5044 (xbm_image_p): Locals are now of int, not EMACS_INT,
5045 since parse_image_check makes sure they fit into int.
5046 (png_load, gif_load, svg_load_image):
5047 Prefer int to unsigned where either will do.
5048 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5049 old tiff_error_handler and tiff_warning_handler.
5050 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5051 stack buffer overflows. It uses only the features of vsnprintf
5052 that are common to both POSIX and native Microsoft.
5053 (tiff_error_handler, tiff_warning_handler): Use it.
5054 (tiff_load, gif_load, imagemagick_load_image):
5055 Don't assume :index value fits in 'int'.
5056 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5057 (imagemagick_load_image): Check that crop parameters fit into
5058 the integer types that MagickCropImage accepts. Don't assume
5059 Vimagemagick_render_type has a nonnegative value. Don't assume
5060 size_t fits in 'long'.
5061 (gs_load): Use printmax_t to print the widest integers possible.
5062 Check for integer overflow when computing image height and width.
5063
c11821d4
EZ
50642011-08-26 Eli Zaretskii <eliz@gnu.org>
5065
5066 * xdisp.c (redisplay_window): Don't force window start if point
5067 will be invisible in the resulting window. (Bug#9324)
5068
0c95fcf7
EZ
50692011-08-25 Eli Zaretskii <eliz@gnu.org>
5070
5071 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5072 the display spec is of the form `(space ...)'.
5073 (handle_display_spec): Return the value returned by
5074 handle_single_display_spec, not just 1 or zero.
5075 (handle_single_display_spec): If the display spec is of the form
5076 `(space ...)', and specifies display in the text area, return 2
5077 rather than 1.
fee65a97 5078 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5079 accurately, and prefer exact match for point under bidi.
5080 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5081
5082 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5083 into disp_prop; all users changed.
5084
5085 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5086 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5087 for the text covered by the display property.
5088
e4ed06f1
CY
50892011-08-25 Chong Yidong <cyd@stupidchicken.com>
5090
5091 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5092 Change return value to nil.
5093 (Frecord_buffer): Delete unused function.
5094
f67cdd7f
EZ
50952011-08-24 Eli Zaretskii <eliz@gnu.org>
5096
5980d4c6
EZ
5097 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5098 buffers, return left-to-right.
8610fe8b
EZ
5099 (set_cursor_from_row): Consider candidate row a win if its glyph
5100 represents a newline and point is on that newline. Fixes cursor
5101 positioning on the newline at EOL of R2L text within L2R
5102 paragraph, and vice versa.
5103 (try_cursor_movement): Check continued rows, in addition to
5104 continuation rows. Fixes unwarranted scroll when point enters a
5105 continued line of R2L text within an L2R paragraph, or vice versa.
5106 (cursor_row_p): Consider the case of point being equal to
5107 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5108 from the end of a short line to the beginning of a continued line
5109 of R2L text within L2R paragraph.
5110 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5111 composed characters.
5980d4c6 5112
f67cdd7f
EZ
5113 * bidi.c (bidi_check_type): Use xassert.
5114 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5115 members.
5116
bca633fb
EZ
51172011-08-23 Eli Zaretskii <eliz@gnu.org>
5118
5119 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5120 a character.
5121
4a5885a7
CY
51222011-08-23 Chong Yidong <cyd@stupidchicken.com>
5123
5124 * nsfont.m (ns_otf_to_script): Fix typo.
5125
0902a04e
KH
51262011-08-22 Kenichi Handa <handa@m17n.org>
5127
5128 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5129 extra slot even if the purpose is char-code-property-table.
5130
1a2e6670
EZ
51312011-08-23 Eli Zaretskii <eliz@gnu.org>
5132
8ddde651
EZ
5133 * xdisp.c (redisplay_window): When computing centering_position,
5134 account for the height of the header line. (Bug#8874)
5135
425cc014
EZ
5136 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5137 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5138 candidate is selected by the mouse, and that candidate has a
5139 composed character under the mouse.
5140
1a2e6670
EZ
5141 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5142 coordinates reported by pos-visible-in-window-p for a composed
5143 character in column zero.
5144
8b76d6f8
SM
51452011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5146
5147 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5148
dac347dd
EZ
51492011-08-22 Eli Zaretskii <eliz@gnu.org>
5150
5151 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5152 consider it a hit if to_charpos is anywhere in the range of the
5153 composed buffer positions.
5154
e013fb34
CY
51552011-08-22 Chong Yidong <cyd@stupidchicken.com>
5156
5157 * image.c (gif_load): Don't assume that each subimage has the same
5158 dimensions as the base image. Handle disposal method that is
5159 "undefined" by the gif spec (Bug#9335).
5160
bd1ba3e8
CY
51612011-08-20 Chong Yidong <cyd@stupidchicken.com>
5162
5163 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5164 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5165
54a1215b
EZ
51662011-08-19 Eli Zaretskii <eliz@gnu.org>
5167
823564e5
EZ
5168 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5169 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5170 from an Org mode buffer to a Speedbar frame.
5171
54a1215b
EZ
5172 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5173 a composition, take its buffer position from IT->cmp_it.charpos.
5174 Fixes cursor positioning at the beginning of a line that begins
5175 with a composed character.
5176
9778ebcc
EZ
51772011-08-18 Eli Zaretskii <eliz@gnu.org>
5178
0be6ee06
EZ
5179 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5180 character bidirectional type, use STRONG_L instead. Fixes crashes
5181 in a buffer produced by `describe-categories'.
5182
9778ebcc
EZ
5183 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5184 members before the level stack, so they would be saved and
5185 restored when copying iterator state. Fixes incorrect reordering
5186 around TABs covered by display properties.
5187
156bffbe
AS
51882011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5189
6b02f655 5190 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5191
72ad093b
CY
51922011-08-17 Chong Yidong <cyd@stupidchicken.com>
5193
5194 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5195 (internal_condition_case_2, internal_condition_case_n):
5196 Remove unnecessary aborts (Bug#9081).
72ad093b 5197
35774242
EZ
51982011-08-17 Eli Zaretskii <eliz@gnu.org>
5199
5200 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5201 has no `load' handler, try opening the file locally. (Bug#9311)
5202
db76dd85
KB
52032011-08-16 Ken Brown <kbrown@cornell.edu>
5204
5205 * gmalloc.c: Expand comment.
5206
b215eee5
EZ
52072011-08-16 Eli Zaretskii <eliz@gnu.org>
5208
5209 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5210 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5211
a4579d33
KB
52122011-08-16 Ken Brown <kbrown@cornell.edu>
5213
5214 Fix memory allocation problems in Cygwin build (Bug#9273).
5215
5216 * unexcw.c ( __malloc_initialized): Declare external variable.
5217 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5218
8b76d6f8
SM
5219 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5220 New variables.
a4579d33
KB
5221 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5222 dumped emacs.
5223 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5224 in the static heap.
5225 [CYGWIN] (special_realloc): New function.
5226 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5227 requests to realloc storage in the static heap.
5228
3ebec551
PE
52292011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5230
5231 * bidi.c (bidi_initialize): Remove unused local.
5232
9fd8be00
EZ
52332011-08-15 Eli Zaretskii <eliz@gnu.org>
5234
6b02f655
SM
5235 * bidimirror.h:
5236 * biditype.h: Remove file.
5237 * makefile.w32-in ($(BLD)/bidi.$(O)):
5238 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5239
5240 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5241
5242 * chartab.c: Improve commentary for the uniprop_table API.
5243
32413314
EZ
5244 * bidi.c (bidi_paragraph_init): Support zero value of
5245 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5246 (bidi_initialize): Use uniprop_table instead of including
5247 biditype.h and bidimirror.h.
32413314 5248
9fd8be00
EZ
5249 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5250 coordinates of the iterator when restoring from ppos_it.
5251 (Bug#9296)
5252
5cf2b69b
KH
52532011-08-14 Kenichi Handa <handa@m17n.org>
5254
5255 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5256 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5257
daf17d00
EZ
52582011-08-14 Eli Zaretskii <eliz@gnu.org>
5259
5260 * xdisp.c (move_it_in_display_line_to): Don't invoke
5261 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5262 ppos_it. Fixes vertical cursor motion when line beginning is
5263 covered by an image. (Bug#9296)
5264
08e3161a
JD
52652011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5266
5267 * nsterm.h (ns_run_ascript): Declare.
5268 (NSAPP_DATA2_RUNASSCRIPT): Define.
5269
5270 * nsfns.m (as_script, as_result, as_status): New static variables.
5271 (ns_run_ascript): New function.
5e617bc2 5272 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5273 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5274 the event loop. Get status from as_status (Bug#7276).
5275
5276 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5277 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5278 the event loop (Bug#7276).
5279
a3720aa2
AS
52802011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5281
5282 * gnutls.c (QCgnutls_bootprop_priority)
5283 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5284 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5285 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5286 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5287 (QCgnutls_bootprop_verify_hostname_error)
5288 (QCgnutls_bootprop_callbacks_verify): Rename from
5289 Qgnutls_bootprop_..., all uses changed.
5290
5291 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5292 uses changed.
5293
0a0d27fb
PE
52942011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5295
19d5c50c
PE
5296 * xfaces.c (Qframe_set_background_mode): Now static.
5297 * dispextern.h (Qframe_set_background_mode): Remove decl.
5298
0a0d27fb
PE
5299 * process.c (Fnetwork_interface_info): Declare local only if needed.
5300
377538cb
JD
53012011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5302
5303 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5304 (Fnetwork_interface_list): Allocate in increments of bytes instead
5305 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5306 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5307 sockaddr.
5308 (struct ifflag_def): notrailers is smart on OSX.
5309 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5310 Get hardware address with getifaddrs if available.
5311
08fff70c
EZ
53122011-08-12 Eli Zaretskii <eliz@gnu.org>
5313
5314 * xdisp.c (iterate_out_of_display_property): xassert that
5315 IT->position is set to within IT->object's boundaries. Break from
5316 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5317 when IT->position is set up wrongly due to some bug.
5318 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5319 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5320 entry. Force push_it to save on the stack the current
5321 buffer/string position, to be restored by pop_it. Fix flags in
5322 the iterator structure wrt the object coming from a display
5323 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5324 properties. (Bug#9284)
5325
7be1c708 53262011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5327
7be1c708
CY
5328 * fontset.c (fontset_get_font_group): Add proper type checks.
5329 (Bug#9172)
aac0c6e3 5330
7be1c708 53312011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5332
7be1c708
CY
5333 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5334 and LC_VERSION_MIN_MACOSX.
5335 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5336 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5337
97bb72a6
EZ
53382011-08-08 Eli Zaretskii <eliz@gnu.org>
5339
5340 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5341 no-display-properties-and-no-overlays under bidi display.
5342 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5343 properties and overlays.
97bb72a6 5344
d5617611
CY
53452011-08-08 Chong Yidong <cyd@stupidchicken.com>
5346
37e11a63
CY
5347 * editfns.c (Fset_time_zone_rule): Document relationship with the
5348 setenv function.
5349
d5617611
CY
5350 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5351 the font entity extracted from the cache (Bug#8109).
5352
58872834
CY
53532011-08-07 Chong Yidong <cyd@stupidchicken.com>
5354
5355 * composite.c (autocmp_chars): Don't reset point. That is done by
5356 restore_point_unwind (Bug#5984).
5357
75bfc667
JL
53582011-08-07 Juri Linkov <juri@jurta.org>
5359
5360 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5361 to show the arg `TIME' instead of `TIMEVAL'.
5362
d1410150
EZ
53632011-08-06 Eli Zaretskii <eliz@gnu.org>
5364
5365 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5366 display property strides EOL and includes a newline, as in
5367 longlines-mode. (Bug#9254)
75b771e4
EZ
5368 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5369 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5370
5371 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5372 is non-zero, even if the data buffer is NULL. Fixes a crash in
5373 vertical-motion with longlines-mode. (Bug#9254)
5374
35928349
EZ
53752011-08-05 Eli Zaretskii <eliz@gnu.org>
5376
ec7cc85b
EZ
5377 * bidi.c <bidi_cache_total_alloc>: Now static.
5378 (bidi_initialize): Initialize bidi_cache_total_alloc.
5379
8b76d6f8 5380 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5381 cache. (Bug#9221)
5382
5383 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5384 amount allocated this far in `bidi_cache_total_alloc'.
5385 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5386 non-zero, only free the data buffer without restoring the cache
5387 contents. All callers changed.
5388
5389 * dispextern.h (bidi_unshelve_cache): Update prototype.
5390
5391 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5392 (move_it_in_display_line, move_it_to)
5393 (move_it_vertically_backward, move_it_by_lines): Replace the call
5394 to xfree to an equivalent call to bidi_unshelve_cache.
5395 (move_it_in_display_line_to): Fix logic of returning
412b6358 5396 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5397
e2e2423b
EZ
53982011-08-05 Eli Zaretskii <eliz@gnu.org>
5399
5400 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5401 came from a string character with a `cursor' property. (Bug#9229)
5402
ae9e757a
JD
54032011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5404
5405 * Makefile.in (LIB_PTHREAD): New variable.
5406 (LIBES): Add LIB_PTHREAD (Bug#9216).
5407
5408 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5409 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5410
213bd7f2
AS
54112011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5412
6b02f655 5413 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5414
99aaf75f
JD
54152011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5416
5417 * xterm.c (x_find_topmost_parent): New function.
5418 (x_set_frame_alpha): Find topmost parent window with
5419 x_find_topmost_parent and set the property there also (bug#9181).
5420 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5421
c74e9d86
PE
54222011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5423
5424 * callproc.c (Fcall_process): Avoid vfork clobbering
5425 the local vars buffer, coding_systems, current_dir.
5426
640c8776
SM
54272011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5428
5429 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5430
f26d0e4c
PE
54312011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5432
8a10d76c
PE
5433 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5434 so that it is not optimized away.
5435
f26d0e4c
PE
5436 * xdisp.c (compute_display_string_pos): Remove unused local.
5437
55439c61
EZ
54382011-08-02 Eli Zaretskii <eliz@gnu.org>
5439
5440 Fix slow cursor motion and scrolling in large buffers with
5441 selective display, like Org Mode buffers. (Bug#9218)
5442
5443 * dispextern.h (struct bidi_it): New member disp_prop_p.
5444
5445 * xdisp.c: Remove one-slot cache of display string positions.
5446 (compute_display_string_pos): Accept an additional argument
5e617bc2 5447 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5448 for a display string or property. If found, set DISP_PROP_P
5449 non-zero.
5450
5451 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5452 DISP_PROP_P, and pass it to compute_display_string_pos.
5453 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5454 non-zero. All callers of bidi_fetch_char changed.
5455
fb33fa43
SM
54562011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5457
5458 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5459
b099e063
DM
54602010-12-03 Don March <don@ohspite.net>
5461
5462 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5463 last character M-[char] is translated to ESC [char] (bug#7541).
5464
5cc7f7af
KH
54652011-08-02 Kenichi Handa <handa@m17n.org>
5466
d0fffa3f 5467 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5468
5469 * chartab.c (uniprop_table): Make it non-static.
5470
525d5e6e
EZ
54712011-08-01 Eli Zaretskii <eliz@gnu.org>
5472
5473 * xdisp.c (forward_to_next_line_start): Accept additional argument
5474 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5475 on the newline.
5476 (reseat_at_next_visible_line_start): Use the bidi iterator state
5477 returned by forward_to_next_line_start to restore the state of
5478 it->bidi_it after backing up to previous newline. (Bug#9212)
5479
31011111
AS
54802011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5481
5482 * regex.c (re_comp): Protoize.
5483 (re_exec): Fix return type.
5484 (regexec): Fix type of `ret'. (Bug#9203)
5485
476371c4
PE
54862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5487
e5d76069
PE
5488 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5489 This is needed if max-image-size is a floating-point number.
5490
9a79b20c
AS
54912011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5492
5493 * print.c (print_object): Print empty symbol as ##.
5494
5495 * lread.c (read1): Read ## as empty symbol.
5496
d8c2fa78
AA
54972011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5498
5499 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5500 setting frame foreground color (Bug#9175).
5501 (x_set_background_color): Likewise.
5502
ffe57a7a
AA
5503 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5504 contents (Bug#9176).
5505 (EmacsTooltip -init): Remove bezels and add shadows to
5506 tooltip windows.
5507
bf3492a5
AA
5508 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5509 or scroll bar (Bug#8470).
5510
d55e9c53
AA
5511 * nsfont.m (nsfont_open): Remove assignment to voffset and
5512 unnecessary vars hshink, expand, hd, full_height, min_height.
5513 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5514
5515 * nsterm.h (nsfont_info): Remove voffset field.
5516
d8c2fa78 55172011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5518
5519 Implement strike-through and overline on NextStep (Bug#8863).
5520
5521 * nsfont.m (nsfont_open): Use underline position provided by font,
5522 instead of hard-coded value of 2.
5523 (nsfont_draw): Call ns_draw_text_decoration instead.
5524
5525 * nsterm.h: Add declaration for ns_draw_text_decoration.
5526
5527 * nsterm.m (ns_draw_text_decoration): New function for drawing
5528 underline, overline, and strike-through.
5529 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5530 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5531 accommodate underlining, etc.
4843aac3 5532
4cc60b9b
EZ
55332011-07-28 Eli Zaretskii <eliz@gnu.org>
5534
bc7ece87
EZ
5535 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5536 default.
4cc60b9b 5537
476371c4
PE
55382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5539
66606eea
PE
5540 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5541 Without this fix, if a signal arrives just after memory fills up,
5542 'malloc' might be invoked reentrantly.
5543
476371c4
PE
5544 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5545 In other words, assume that every image size is allowed, on non-X
5546 hosts. This assumption is probably wrong, but it lets Emacs compile.
5547
f3fcc40d
AS
55482011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5549
5550 * regex.c (re_iswctype): Convert return values to boolean.
5551
350c992f
EZ
55522011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5553
5554 * xdisp.c (compute_display_string_pos): Don't use cached display
5555 string position if the buffer had its restriction changed.
5556 (Bug#9184)
5557
5266b4bb
PE
55582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5559
5560 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5561
2573a837 55622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5563
41f55ccd 5564 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5565
39e378da
PE
5566 * bidi.c: Integer size and overflow fixes.
5567 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5568 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5569 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5570 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5571 (bidi_find_other_level_edge):
5572 Use ptrdiff_t instead of EMACS_INT where either will do.
5573 This works better on 32-bit hosts configured --with-wide-int.
5574 (bidi_cache_ensure_space): Check for size-calculation overflow.
5575 Use % rather than repeated addition, for better worst-case speed.
5576 Don't set bidi_cache_size until after xrealloc returns, because it
5577 might not return.
5578 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5579 (bidi_cache_ensure_space): Also check that the bidi cache size
5580 does not exceed that of the largest Lisp string or buffer. See Eli
5581 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5582
5e927815
PE
5583 * alloc.c (__malloc_size_t): Remove.
5584 All uses replaced by size_t. See Andreas Schwab's note
5585 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5586
ca4aa935
PE
5587 * image.c: Improve checking for integer overflow.
5588 (check_image_size): Assume that f is nonnull, since
5589 it is always nonnull in practice. This is one less thing to
5590 worry about when checking for integer overflow later.
5591 (x_check_image_size): New function, which checks for integer
5592 overflow issues inside X.
5593 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5594 This removes the need for a memory_full check.
5595 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5596 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5597 (xbm_read_bitmap_data): Change locals back to 'int', since
5598 their values must fit in 'int'.
5599 (xpm_load_image, png_load, tiff_load):
5600 Invoke x_create_x_image_and_pixmap earlier,
5601 to avoid much needless work if the image is too large.
5602 (tiff_load): Treat overly large images as if
5603 x_create_x_image_and_pixmap failed, not as malloc failures.
5604 (gs_load): Use x_check_image_size.
5605
5f8f9cc2
PE
5606 * gtkutil.c: Omit integer casts.
5607 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5608 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5609
5adf60bc
PE
5610 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5611
c8907a93
PE
5612 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5613 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5614 would wrongly return t on a 64-bit host.
5615
e3c25c68
PE
5616 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5617 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5618 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5619 and therefore cause GCC to emit a bogus diagnostic in some cases.
5620
3f791afe
PE
5621 * image.c: Integer signedness and overflow and related fixes.
5622 This is not an exhaustive set of fixes, but it's time to
5623 record what I've got.
5624 (lookup_pixel_color, check_image_size): Remove redundant decls.
5625 (check_image_size): Don't assume that arbitrary EMACS_INT values
5626 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5627 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5628 (tiff_load, imagemagick_load_image):
5629 Check for overflow in size calculations.
5630 (x_create_x_image_and_pixmap): Remove unnecessary test for
5631 xmalloc returning NULL; that can't happen.
5632 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5633 (xpm_color_bucket): Use better integer hashing function.
5634 (xpm_cache_color): Don't possibly over-allocate memory.
5635 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5636 (gif_memory_source):
5637 Use ptrdiff_t, not int or size_t, to record sizes.
5638 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5639 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5640 either works, as we prefer signed integers.
5641 (tiff_read_from_memory, tiff_write_from_memory):
5642 Return tsize_t, not size_t, since that's what the TIFF API wants.
5643 (tiff_read_from_memory): Don't fail simply because the read would
5644 go past EOF; instead, return a short read.
5645 (tiff_load): Omit no-longer-needed casts.
5646 (Fimagemagick_types): Don't assume size fits into 'int'.
5647
3cc5a532
PE
5648 Improve hashing quality when configured --with-wide-int.
5649 * fns.c (hash_string): New function, taken from sxhash_string.
5650 Do not discard information about ASCII character case; this
5651 discarding is no longer needed.
5652 (sxhash-string): Use it. Change sig to match it. Caller changed.
5653 * lisp.h: Declare it.
5654 * lread.c (hash_string): Remove, since we now use fns.c's version.
5655 The fns.c version returns a wider integer if --with-wide-int is
5656 specified, so this should help the quality of the hashing a bit.
5657
b312a492
PE
5658 * emacs.c: Integer overflow minor fix.
5659 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5660 Define only if GNU_LINUX.
5661 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5662
dfd153ae
PE
5663 * dispnew.c: Integer signedness and overflow fixes.
5664 Remove unnecessary forward decls, that were a maintenance hassle.
5665 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5666 All uses changed.
5667 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5668 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5669 (prepare_desired_row, line_draw_cost):
5670 Use int, not unsigned, where either works.
5671 (save_current_matrix, restore_current_matrix):
5672 Use ptrdiff_t, not size_t, where either works.
5673 (init_display): Check for overflow more accurately, and without
5674 relying on undefined behavior.
5675
a81d11a3
PE
5676 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5677 Remove, replacing with the new symbols in lisp.h. All uses changed.
5678 * fileio.c (make_temp_name):
5679 * filelock.c (lock_file_1, lock_file):
5680 * xdisp.c (message_dolog):
5681 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5682 Use pMd etc. instead.
5683 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5684 replacing the pWIDE etc. symbols removed from editfns.c.
5685
3300e6fd
PE
5686 * keyboard.h (num_input_events): Now uintmax_t.
5687 This is (very slightly) less likely to mess up due to wraparound.
5688 All uses changed.
5689
fd05c7e9
PE
5690 * buffer.c: Integer signedness fixes.
5691 (alloc_buffer_text, enlarge_buffer_text):
5692 Use ptrdiff_t rather than size_t when either will do, as we prefer
5693 signed integers.
5694
903fe15d
PE
5695 * alloc.c: Integer signedness and overflow fixes.
5696 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5697 (__malloc_size_t): Default to size_t, not to int.
5698 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5699 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5700 Prefer ptrdiff_t to size_t when either would do, as we prefer
5701 signed integers.
5702 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5703 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5704 Now const. Initialize with values that are in range even if char
5705 is signed.
5706 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5707 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5708 These functions do the right thing with sizes > 2**32.
5709 (check_depth): Now ptrdiff_t, not int.
5710 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5711 Adjust to new way of storing sizes. Check for size overflow bugs
5712 in rest of code.
5713 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5714 slightly wrong anyway, as it missed one instance of
5715 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5716 (refill_memory_reserve): Omit needless cast to size_t.
5717 (mark_object_loop_halt): Mark as externally visible.
5718
ac82cc6a
PE
5719 * xselect.c: Integer signedness and overflow fixes.
5720 (Fx_register_dnd_atom, x_handle_dnd_message):
5721 Use ptrdiff_t, not size_t, since we prefer signed.
5722 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5723 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5724 x_dnd_atoms_size and x_dnd_atoms_length.
5725
c2d1e36d
PE
5726 * doprnt.c: Prefer signed to unsigned when either works.
5727 * eval.c (verror):
5728 * doprnt.c (doprnt):
5729 * lisp.h (doprnt):
5730 * xdisp.c (vmessage):
5731 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5732 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5733 prefer signed arithmetic to avoid comparison confusion.
5734 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5735 but is a bit tricky.
5736
0e926e56
PE
5737 Assume freestanding C89 headers, string.h, stdlib.h.
5738 * data.c, doprnt.c, floatfns.c, print.c:
5739 Include float.h unconditionally.
5740 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5741 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5742 * regex.c: Likewise for stddef.h, string.h.
5743 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5744 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5745 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5746 (STDC_HEADERS): Remove obsolete defines.
5747 * sysdep.c: Include limits.h unconditionally.
5748
9cfdb3ec
PE
5749 Assume support for memcmp, memcpy, memmove, memset.
5750 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5751 * regex.c (memcmp, memcpy):
5752 Remove; we assume C89 now.
5753
5754 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5755 (__malloc_safe_bcopy): Remove; no longer needed.
5756
cf950e6b 5757 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5758 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5759 well either way, and we prefer signed to unsigned.
5760
dbf38e02
LMI
57612011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5762
5763 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5764 closes the connection while we're reading (bug#9182).
5765
d6f0886c 57662011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5767
d6f0886c
JD
5768 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5769 are specified (Bug#9168).
24e0f6b1 5770
2eb1f9e6
PE
57712011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5772
5773 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5774 Found by GCC static checking and --with-wide-int on a 32-bit host.
5775
22381272 57762011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5777
5778 * xdisp.c (compute_display_string_pos): Fix logic of caching
5779 previous display string position. Initialize cached_prev_pos to
5780 -1. Fixes slow-down at the beginning of a buffer.
5781
f25e39b4
EZ
57822011-07-24 Eli Zaretskii <eliz@gnu.org>
5783
5784 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5785 for attrs[LFACE_FONTSET_INDEX].
5786
04c4b52e
PE
57872011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5788
5789 * xml.c (parse_region): Remove unused local
5790 that was recently introduced.
5791
c1734fbd
EZ
57922011-07-23 Eli Zaretskii <eliz@gnu.org>
5793
be18c5a5
EZ
5794 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5795 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5796
c1734fbd
EZ
5797 * xdisp.c (move_it_in_display_line_to): Record the best matching
5798 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5799 exit if none of the characters scanned was an exact match.
5800 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5801 when exact match is impossible due to invisible text, and the
5802 lines are truncated.
5803
a258d627
JD
58042011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5805
5806 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5807 for OSX >= 10.7.
5808
b6d5a689
EZ
58092011-07-22 Eli Zaretskii <eliz@gnu.org>
5810
0f74f785
EZ
5811 Fix a significant slow-down of cursor motion with C-n, C-p,
5812 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5813 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5814 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5815 (next_element_from_buffer): Call compute_stop_pos_backwards to
5816 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5817 base_level_stop.
5818 (reseat): Don't look for prev_stop, as that could mean a very long
5819 run.
5820 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5821 <cached_disp_overlay_modiff>: Cache for last found display string
5822 position.
551918c1 5823 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5824 about the same buffer in the same area of character positions, and
5825 the buffer wasn't changed since the time the display string
5826 position was cached.
551918c1 5827
b2d0c91a
EZ
58282011-07-22 Eli Zaretskii <eliz@gnu.org>
5829
5830 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5831 is an integer, which is important for empty lines. (Bug#9149)
5832
043604ee
CY
58332011-07-22 Chong Yidong <cyd@stupidchicken.com>
5834
5835 * frame.c (Fmodify_frame_parameters): In tty case, update the
5836 default face if necessary (Bug#4238).
5837
da4adb04
CY
58382011-07-21 Chong Yidong <cyd@stupidchicken.com>
5839
5840 * editfns.c (Fstring_to_char): No need to explain what a character
5841 is in the docstring (Bug#6576).
5842
9abd0532
LMI
58432011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5844
5845 * xml.c (parse_region): Make sure we always return a tree.
5846
36881d16
HK
58472011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5848
5849 * xml.c (parse_region): If a document contains only comments,
5850 return that, too.
5851
1e98674d
LMI
58522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5853
5854 * xml.c (make_dom): Return comments, too.
5855
590bd467
PE
58562011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5857
5858 Port to OpenBSD.
5859 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5860 and the surrounding thread.
5861 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5862 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5863 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5864 timer goes off.
5865 * s/openbsd.h (BROKEN_SIGIO): Define.
5866 * unexelf.c (unexec) [__OpenBSD__]:
5867 Don't update the .mdebug section of the Alpha COFF symbol table.
5868
f41628b2
LMI
58692011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5870
5871 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5872 (bug#8460).
5873
b59b67c5
PE
58742011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5875
15e3a074
PE
5876 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5877 This fixes some race conditions on the permissions of any newly
5878 created file.
5879
41bed37d
PE
5880 * alloc.c (valid_pointer_p): Use pipe, not open.
5881 This fixes some permissions issues when debugging.
5882
b59b67c5
PE
5883 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5884 If fchown fails to set both uid and gid, try to set just gid,
5885 as that is sometimes allowed. Adjust the file's mode to eliminate
5886 setuid or setgid bits that are inappropriate if fchown fails.
5887
925a6be7
SM
58882011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5889
5890 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5891 to compare Lisp_Objects.
5892 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5893 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5894 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5895
52968808
AS
58962011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5897
0a6a104b
AS
5898 * lread.c (read_integer): Unread even EOF character.
5899 (read1): Likewise. Properly record start position of symbol.
5900
52968808
AS
5901 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5902 symbol character follows.
5903
9e381cdd
PE
59042011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5905
5906 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5907 This works around a problem with the previous change to Fcopy_file.
5908 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5909 and without this change, GCC might complain about discarding
5910 fchown's return value.
5911
b5641435
JB
59122011-07-16 Juanma Barranquero <lekktu@gmail.com>
5913
5914 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5915
a8031457
PE
59162011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5917
5918 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5919
dd889327
LMI
59202011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5921
750c33f7
LMI
5922 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5923 it's used from the C level.
5924
dd889327
LMI
5925 * process.c: Use the same condition for POLL_FOR_INPUT in both
5926 keyboard.c and process.c (bug#1858).
5927
87e86684
LM
59282011-07-09 Lawrence Mitchell <wence@gmx.li>
5929
5930 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5931 (Fgnutls_boot): Use it.
5932
64348f40
AS
59332011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5934
5935 * doc.c (Fsubstitute_command_keys): Revert last change.
5936
1d698799
LMI
59372011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5938
f863868c
LMI
5939 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5940 quotes the next character, and doesn't affect other longer
5941 sequences (bug#8935).
5942
1d698799
LMI
5943 * lread.c (syms_of_lread): Clarify that is isn't only
5944 `eval-buffer' and `eval-defun' that's affected by
5945 `lexical-binding' (bug#8460).
5946
aa4b6df6
EZ
59472011-07-15 Eli Zaretskii <eliz@gnu.org>
5948
5949 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5950 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5951
5d856da6
PE
59522011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5953
ad6042bb
PE
5954 Fix minor problems found by static checking.
5955 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5956 (elsz): Now a signed constant, not a size_t var. We prefer signed
5957 types to unsigned, to avoid integer comparison confusion. Without
5958 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5959 "cannot optimize loop, the loop counter may overflow", a symptom
5960 of the confusion.
f00bbb22 5961 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5962 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5963
6468f31c
LMI
59642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5965
49080b10
LMI
5966 * search.c (Fre_search_backward): Mention `case-fold-search' in
5967 all the re_search_* functions (bug#8138).
5968
6468f31c
LMI
5969 * keyboard.c (Fopen_dribble_file): Document when the file is
5970 closed (bug#8056).
5971
c965adc5
EZ
59722011-07-14 Eli Zaretskii <eliz@gnu.org>
5973
df9733bf
EZ
5974 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5975 bidi_cache_idx.
5976
0bb23927
EZ
5977 Support bidi reordering of display and overlay strings.
5978 * xdisp.c (compute_display_string_pos)
5979 (compute_display_string_end): Accept additional argument STRING.
5980 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5981 (reseat_to_string): Initialize bidi_it->string.s and
5982 bidi_it->string.schars.
5983 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5984 NULL (avoids a crash in bidi_paragraph_init).
5985 Initialize itb.string.lstring.
0bb23927
EZ
5986 (init_iterator): Call bidi_init_it only of a valid
5987 buffer position was specified. Initialize paragraph_embedding to
5988 L2R.
5989 (reseat_to_string): Initialize the bidi iterator.
5990 (display_string): If we need to ignore text properties of
5991 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5992 original value of -1 will not work with bidi.)
5993 (compute_display_string_pos): First arg is now struct
5994 `text_pos *'; all callers changed. Support display properties on
5995 Lisp strings.
5996 (compute_display_string_end): Support display properties on Lisp
5997 strings.
5998 (init_iterator, reseat_1, reseat_to_string): Initialize the
5999 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6000 when iterating on a string not from display properties).
640c8776
SM
6001 (compute_display_string_pos, compute_display_string_end):
6002 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6003 arrow keys.
6004 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6005 base_level_stop; instead, set base_level_stop to BEGV.
6006 Fixes crashes in vertical-motion.
0bb23927
EZ
6007 (next_element_from_buffer): Improve commentary for when
6008 the iterator is before prev_stop.
6009 (init_iterator): Initialize bidi_p from the default value of
6010 bidi-display-reordering, not from buffer-local value. Use the
6011 buffer-local value only if initializing for buffer iteration.
6012 (handle_invisible_prop): Support invisible properties on strings
6013 that are being bidi-reordered.
6014 (set_iterator_to_next): Support bidi reordering of C strings and
6015 Lisp strings.
6016 (next_element_from_string): Support bidi reordering of Lisp
6017 strings.
6018 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6019 (display_string): Support display of R2L glyph rows.
6020 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6021 (init_iterator): Don't initialize it->bidi_p for strings
6022 here.
6023 (reseat_to_string): Initialize it->bidi_p for strings here.
6024 (next_element_from_string, next_element_from_c_string)
6025 (next_element_from_buffer): Add xassert's for correspondence
6026 between IT's object being iterated and it->bidi_it.string
6027 structure.
6028 (face_before_or_after_it_pos): Support bidi iteration.
6029 (next_element_from_c_string): Handle the case of the first string
6030 character that is not the first one in the visual order.
6031 (get_visually_first_element): New function, refactored from common
6032 parts of next_element_from_buffer, next_element_from_string, and
6033 next_element_from_c_string.
6034 (tool_bar_lines_needed, redisplay_tool_bar)
6035 (display_menu_bar): Force left-to-right direction. Add a FIXME
6036 comment for making that be controlled by a user option.
6037 (push_it, pop_it): Save and restore the state of the
6038 bidi iterator. Save and restore the bidi_p flag.
6039 (pop_it): Iterate out of display property for string iteration as
6040 well.
6041 (iterate_out_of_display_property): Support iteration over strings.
6042 (handle_single_display_spec): Set up it->bidi_it for iteration
6043 over a display string, and call bidi_init_it.
6044 (handle_single_display_spec, next_overlay_string)
6045 (get_overlay_strings_1, push_display_prop): Set up the bidi
6046 iterator for displaying display or overlay strings.
6047 (forward_to_next_line_start): Don't use the shortcut if
6048 bidi-iterating.
6049 (back_to_previous_visible_line_start): If handle_display_prop
6050 pushed the iterator stack, restore the internal state of the bidi
6051 iterator by calling bidi_pop_it same number of times.
6052 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6053 and we are bidi-iterating, don't decrement the iterator position;
6054 instead, set the first_elt flag in the bidi iterator, to produce
6055 the same effect.
6056 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6057 (push_display_prop): xassert that we are iterating a buffer.
6058 (push_it, pop_it): Save and restore paragraph_embedding member.
6059 (handle_single_display_spec, next_overlay_string)
6060 (get_overlay_strings_1, reseat_1, reseat_to_string)
6061 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6062 correctly. Don't assume unibyte strings are not bidi-reordered.
6063 (compute_display_string_pos)
6064 (compute_display_string_end): Fix handling the case of C string.
6065 (push_it, pop_it): Save and restore from_disp_prop_p.
6066 (handle_single_display_spec, push_display_prop): Set the
6067 from_disp_prop_p flag.
6068 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6069 (pop_it): Call iterate_out_of_display_property only if we are
6070 popping after iteration over a string that came from a display
6071 property. Fix a typo in popping stretch info. Add an assertion
6072 for verifying that the iterator position is in sync with the bidi
6073 iterator.
6074 (handle_single_display_spec, get_overlay_strings_1)
6075 (push_display_prop): Fix initialization of paragraph direction for
6076 string when that of the parent object is not yet determined.
6077 (reseat_1): Call bidi_init_it to resync the bidi
6078 iterator with IT's position. (Bug#7616)
6079 (find_row_edges): If ROW->start.pos gives position
6080 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6081 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6082 Reset the from_disp_prop_p flag.
6083 (SAVE_IT, RESTORE_IT): New macros.
6084 (pos_visible_p, face_before_or_after_it_pos)
6085 (back_to_previous_visible_line_start)
6086 (move_it_in_display_line_to, move_it_in_display_line)
6087 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6088 (try_scrolling, redisplay_window, display_line): Use them when
6089 saving a temporary copy of the iterator and restoring it back.
6090 (back_to_previous_visible_line_start, reseat_1)
6091 (init_iterator): Empty the bidi cache "stack".
6092 (move_it_in_display_line_to): If iterator ended up at
6093 EOL, but we never saw any buffer positions smaller than
6094 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6095 motion in bidi-reordered lines.
6096 (move_it_in_display_line_to): Record prev_method and prev_pos
6097 immediately before the call to set_iterator_to_next. Fixes cursor
6098 motion in bidi-reordered lines with stretch glyphs and strings
6099 displayed in margins. (Bug#8133) (Bug#8867)
6100 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6101 TO_CHARPOS.
640c8776
SM
6102 (pos_visible_p): Support positions in bidi-reordered lines.
6103 Save and restore bidi cache.
0bb23927
EZ
6104
6105 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6106 (bidi_paragraph_info): Delete unused struct.
6107 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6108 (bidi_cache_start): New variable.
6109 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6110 to zero.
6111 (bidi_cache_fetch_state, bidi_cache_search)
6112 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6113 (bidi_cache_find, bidi_peek_at_next_level)
6114 (bidi_level_of_next_char, bidi_find_other_level_edge)
6115 (bidi_move_to_visually_next): Compare cache index with
6116 bidi_cache_start rather than with zero.
6117 (bidi_fetch_char): Accept new argument STRING; all callers
6118 changed. Support iteration over a string. Support strings with
6119 display properties. Support unibyte strings. Fix the type of
6120 `len' according to what STRING_CHAR_AND_LENGTH expects.
6121 (bidi_paragraph_init, bidi_resolve_explicit_1)
6122 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6123 (bidi_level_of_next_char, bidi_move_to_visually_next):
6124 Support iteration over a string.
0bb23927
EZ
6125 (bidi_set_sor_type, bidi_resolve_explicit_1)
6126 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6127 can now be zero (for strings); special values 0 and -1 were
6128 changed to -1 and -2, respectively.
6129 (bidi_char_at_pos): New function.
6130 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6131 Call it instead of FETCH_MULTIBYTE_CHAR.
6132 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6133 initialized to valid values.
6134 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6135 values.
6136 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6137 the test for valid cached positions. Fix the logic for looking up
6138 the sentinel state in the cache. GCPRO the Lisp string we are
6139 iterating.
6140 (bidi_push_it, bidi_pop_it): New functions.
6141 (bidi_initialize): Initialize the bidi cache start stack pointer.
6142 (bidi_cache_ensure_space): New function, refactored from part of
6143 bidi_cache_iterator_state. Don't assume the required size is just
6144 one BIDI_CACHE_CHUNK away.
6145 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6146 (bidi_count_bytes, bidi_char_at_pos): New functions.
6147 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6148 always valid if bidi_cache_idx is valid.
6149 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6150 is valid if it's going to be used.
6151 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6152 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6153 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6154 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6155 (bidi_find_other_level_edge, bidi_cache_start_stack):
6156 All variables related to cache indices are now EMACS_INT.
c965adc5 6157
0bb23927
EZ
6158 * dispextern.h (struct bidi_string_data): New structure.
6159 (struct bidi_it): New member `string'. Make flag members be 1-bit
6160 fields, and put them last in the struct.
640c8776
SM
6161 (compute_display_string_pos, compute_display_string_end):
6162 Update prototypes.
0bb23927
EZ
6163 (bidi_push_it, bidi_pop_it): Add prototypes.
6164 (struct iterator_stack_entry): New members bidi_p,
6165 paragraph_embedding, and from_disp_prop_p.
6166 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6167 (bidi_shelve_cache, bidi_unshelve_cache):
6168 Declare prototypes.
0bb23927
EZ
6169
6170 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6171 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6172 and vector-like objects.
6173
6174 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6175 cache around display iteration.
6176
6177 * window.c (Fwindow_end, window_scroll_pixel_based)
6178 (displayed_window_lines, Frecenter): Save and restore the bidi
6179 cache around display iteration.
6180
3bbd2265
LMI
61812011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6182
6183 * editfns.c (Fdelete_region): Clarify the use of the named
6184 parameters (bug#6788).
6185
adc47434
MR
61862011-07-14 Martin Rudalics <rudalics@gmx.at>
6187
6188 * indent.c (Fvertical_motion): Set and restore w->pointm when
6189 saving and restoring the window's buffer (Bug#9006).
6190
837c31f8
LMI
61912011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6192
6193 * editfns.c (Fstring_to_char): Clarify just what is returned
6194 (bug#6576). Text by Eli Zaretskii.
6195
ac389d0c
JB
61962011-07-13 Juanma Barranquero <lekktu@gmail.com>
6197
6198 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6199
0be0ce47
EZ
62002011-07-13 Eli Zaretskii <eliz@gnu.org>
6201
6202 * buffer.c (mmap_find): Fix a typo.
6203
cd18e7e3
JB
62042011-07-13 Johan Bockgård <bojohan@gnu.org>
6205
6206 Fix execution of x selection hooks.
6207 * xselect.c (Qx_lost_selection_functions)
6208 (Qx_sent_selection_functions): New vars.
6209 (syms_of_xselect): DEFSYM them.
6210 (x_handle_selection_request): Pass Qx_sent_selection_functions
6211 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6212 (x_handle_selection_clear,x_clear_frame_selections):
6213 Pass Qx_lost_selection_functions rather than
6214 Vx_lost_selection_functions to Frun_hook_with_args.
6215
47ea7f44
PE
62162011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6217
ac389d0c 6218 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6219 The old code sometimes used this field without initializing it.
6220
47ea7f44
PE
6221 * alloc.c (gc_sweep): Don't read past end of array.
6222 In theory, the old code could also have corrupted Emacs internals,
6223 though it'd be very unlikely.
6224
bc985c87
AS
62252011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6226
6227 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6228 argument. (Bug#4026)
bc985c87 6229
0cf34688
LMI
62302011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6231
b3dadd76
LMI
6232 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6233 key" (bug#4257).
6234
0cf34688
LMI
6235 * window.c (Fset_window_start): Doc fix (bug#4199).
6236 (Fset_window_hscroll): Ditto.
6237
270768cd
PE
62382011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6239
077e3dda 6240 Fix minor new problems caught by GCC 4.6.1.
270768cd 6241 * term.c (init_tty): Remove unused local.
490011a6 6242 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6243 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6244 not used otherwise.
270768cd 6245
b1f58454
CY
62462011-07-12 Chong Yidong <cyd@stupidchicken.com>
6247
6248 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6249
22b9578d
LMI
62502011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6251
6e70ab07
LMI
6252 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6253 are the mini-buffer and the echo area (bug#3320).
6254
22b9578d
LMI
6255 * term.c (init_tty): Remove support for supdup, c10 and perq
6256 terminals, which are no longer supported (bug#1482).
6257
8974cc9f
JB
62582011-07-10 Johan Bockgård <bojohan@gnu.org>
6259
6260 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6261
a560d974
JD
62622011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6263
6264 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6265 for non-popups (Bug#3642).
6266
1dae0f0a
AS
62672011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6268
268c2c36 6269 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6270 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6271 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6272 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6273 * data.c (fmod): Likewise.
6274 * dispnew.c (swap_glyphs_in_rows): Likewise.
6275 * emacs.c (memory_warning_signal): Likewise.
6276 * floatfns.c (float_error): Likewise.
6277 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6278 (otf_open, font_otf_capability, generate_otf_features)
6279 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6280 Likewise.
6281 * image.c (pbm_read_file): Likewise.
6282 * indent.c (string_display_width): Likewise.
6283 * intervals.c (check_for_interval, search_for_interval)
6284 (inc_interval_count, count_intervals, root_interval)
6285 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6286 * lread.c (defalias): Likewise.
268c2c36 6287 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6288 * regex.c (set_image_of_range_1, set_image_of_range)
6289 (regex_grow_registers): Likewise.
6290 * sysdep.c (strerror): Likewise.
6291 * termcap.c (valid_filename_p, tprint, main): Likewise.
6292 * tparam.c (main): Likewise.
6293 * unexhp9k800.c (run_time_remap, save_data_space)
6294 (update_file_ptrs, read_header, write_header, calculate_checksum)
6295 (copy_file, copy_rest, display_header): Likewise.
6296 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6297 Likewise.
6298 * xdisp.c (check_it): Likewise.
6299 * xfaces.c (register_color, unregister_color, unregister_colors):
6300 Likewise.
6301 * xfns.c (print_fontset_result): Likewise.
6302 * xrdb.c (member, fatal, main): Likewise.
6303
99033785
PE
63042011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6305
6306 Fix minor problems found by static checking (Bug#9031).
6307 * chartab.c (char_table_set_range, map_sub_char_table):
6308 Remove unused locals.
6309 (uniprop_table): Now static.
6310 * composite.c (_work_char): Remove unused static var.
6311
9cb2ac56
JB
63122011-07-09 Juanma Barranquero <lekktu@gmail.com>
6313
6314 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6315
f25661f0
JD
63162011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6317
6318 * gtkutil.c (qttip_cb): Remove code without function.
6319
8278c4fe
EZ
63202011-07-09 Eli Zaretskii <eliz@gnu.org>
6321
6322 * w32.c (pthread_sigmask): New stub.
6323
1692ae2d 63242011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6325
8a6ebd58 6326 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6327 sigprocmask is portable only for single-threaded applications, and
6328 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6329 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6330 (LIBES): Use it.
6331 * callproc.c (Fcall_process):
6332 * process.c (create_process):
6333 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6334 Use pthread_sigmask, not sigprocmask.
123403e4 6335
1b854618
JD
63362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6337
6338 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6339 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6340 wrong (Bug#8591).
6341
3fe4b549
JD
63422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6343
0ce7e563
JD
6344 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6345 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6346 (xg_hide_tooltip): Fix comment.
6347
3fe4b549
JD
6348 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6349 in registerServicesMenuSendTypes.
6350 (validRequestorForSendType): Don't check ns_return_types.
6351
6352 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6353 ns_return_type.
6354
5df75e47
JR
63552011-07-08 Jason Rumney <jasonr@gnu.org>
6356
22610910
JR
6357 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6358 SH_SHOW for hidden windows (Bug#5482).
6359
5df75e47
JR
6360 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6361 frame struct members of non-existent frames (Bug#6284).
6362
699c10bd
JD
63632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6364
4393663b
JD
6365 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6366 variable firstTime not needed on OSX >= 10.6.
6367 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6368 >= 10.5. Use setKnobProportion, setDoubleValue.
6369
6370 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6371 (MAC_OS_X_VERSION_10_5): Define if not defined.
6372 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6373 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6374 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6375
6376 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6377 cString and lossyCString on OSX >= 10.4
6378
58179cce 6379 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6380 sizeToFit on OSX >= 10.2.
6381
6382 * nsimage.m (allocInitFromFile): Don't use deprecated method
6383 bestRepresentationForDevice on OSX >= 10.6.
6384
6385 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6386 to avoid warning.
6387
6388 * emacs.c: Declare unexec_init_emacs_zone.
6389
a63e0781
JD
6390 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6391
699c10bd
JD
6392 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6393
6394 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6395 on svcsMenu (Bug#8842).
6396
6397 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6398 ns_return_types.
6399 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6400
6401 * nsterm.m (QUTF8_STRING): Declare.
6402 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6403 (validRequestorForSendType): Return type is (id).
6404 Change indexOfObjectIdenticalTo to indexOfObject.
6405 Check if we have local selection before returning self (Bug#8842).
6406 (writeSelectionToPasteboard): Put local selection into paste board
6407 if we have a local selection (Bug#8842).
6408 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6409
6410 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6411 (ns_get_local_selection): Declare.
6412
54e10184
LMI
64132011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6414
9888ff71
LMI
6415 * keymap.c (describe_map_tree): Don't insert a double newline at
6416 the end of the buffer (bug#1169) and return whether we inserted
6417 something.
6418
54e10184
LMI
6419 * callint.c (Fcall_interactively): Change "reading args" to
6420 "providing args" to try to clarify what it does (bug#1010).
6421
15fa4783
KH
64222011-07-07 Kenichi Handa <handa@m17n.org>
6423
6424 * composite.c (composition_compute_stop_pos): Ignore a static
6425 composition starting before CHARPOS (Bug#8915).
6426
6427 * xdisp.c (handle_composition_prop): Likewise.
6428
a8815b00
EZ
64292011-07-07 Eli Zaretskii <eliz@gnu.org>
6430
6431 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6432 (Bug#9015)
6433
ef7b981d 64342011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6435
6436 * character.h (unicode_category_t): New enum type.
6437
6438 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6439 (Qchar_code_property_table): New variable.
6440 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6441 (UNIPROP_COMPRESSED_FORM_P): New macros.
6442 (char_table_ascii): Uncompress the compressed values.
6443 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6444 Uncompress the compressed values.
ac389d0c 6445 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6446 (char_table_ref_and_range): Uncompress the compressed values.
6447 (sub_char_table_set): New arg is_uniprop. Callers changed.
6448 Uncompress the compressed values.
6449 (sub_char_table_set_range): Args changed. Callers changed.
6450 (char_table_set_range): Adjuted for the above change.
6451 (map_sub_char_table): Delete args default_val and parent. Add arg
6452 top. Give decoded values to a Lisp function.
640c8776 6453 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6454 values to a Lisp function. Gcpro more variables.
6455 (uniprop_table_uncompress)
6456 (uniprop_decode_value_run_length): New functions.
6457 (uniprop_decoder, uniprop_decoder_count): New variables.
6458 (uniprop_get_decoder, uniprop_encode_value_character)
6459 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6460 New functions.
6461 (uniprop_encoder, uniprop_encoder_count): New variables.
6462 (uniprop_get_encoder, uniprop_table)
6463 (Funicode_property_table_internal, Fget_unicode_property_internal)
6464 (Fput_unicode_property_internal): New functions.
6465 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6466 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6467 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6468 char-code-property-alist.
6469
640c8776 6470 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6471 Vunicode_category_table.
6472
640c8776 6473 * font.c (font_range): Adjust for the change of
c805dec0
KH
6474 Vunicode_category_table.
6475
76b397fb
DN
64762011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6477
6478 * m/iris4d.h: Remove file, move contents ...
6479 * s/irix6-5.h: ... here.
6480
22b4128e
PE
64812011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6482
6483 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6484 * alloc.c (mark_buffer):
6485 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6486 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6487 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6488 This isn't true in general, and it's particularly not true
6489 if Emacs is configured with --with-wide-int.
6490 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6491 New macros, used in the buffer.c change.
6492
869795d6
JD
64932011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6494
6495 * xsettings.c: Use both GConf and GSettings if both are available.
6496 (store_config_changed_event): Add comment.
6497 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6498 (store_tool_bar_style_changed): New functions.
5e617bc2 6499 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6500 (struct xsettings): Move font inside HAVE_XFT.
6501 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6502 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6503 Move inside HAVE_XFT.
640c8776 6504 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6505 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6506 also.
6507 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6508 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6509 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6510 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6511 (parse_settings): Move check for font inside HAVE_XFT.
6512 (read_settings, apply_xft_settings): Add comment.
6513 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6514 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6515 call store_font_name_changed.
6516 (xft_settings_event): Add comment.
6517 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6518 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6519 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6520 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6521 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6522 (xsettings_get_system_font, xsettings_get_system_normal_font):
6523 Add comment.
869795d6 6524
d8ed26bd
PE
65252011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6526
6527 Random fixes. E.g., (random) never returned negative values.
6528 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6529 subseconds part to the entropy, as that's a bit more random.
6530 Prefer signed to unsigned, since the signedness doesn't matter and
6531 in general we prefer signed. When given a limit, use a
6532 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6533 latter isn't right if USE_2_TAGS_FOR_INTS.
6534 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6535 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6536
cabf1cac
SM
65372011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6538
6539 * textprop.c (text_property_stickiness):
6540 Obey Vtext_property_default_nonsticky.
6541 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6542 * w32fns.c (syms_of_w32fns):
6543 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6544
6e9b2be9
PE
65452011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6546
6547 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6548 This is more efficient than Ffile_directory_p and avoids a minor race.
6549
90186c68
LMI
65502011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6551
7c301272
LMI
6552 * buffer.c (Foverlay_put): Say what the return value is
6553 (bug#7835).
6554
c4f2d8d4
LMI
6555 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6556 is a directory before asking whether to use the file name
6557 (bug#7564).
ad637907
LMI
6558 (barf_or_query_if_file_exists): Make the "File is a directory"
6559 error be more correct.
c4f2d8d4 6560
90186c68
LMI
6561 * fns.c (Frequire): Remove the mention of the .gz files, since
6562 that's installation-specific, but keep the mention of
6563 `get-load-suffixes'.
6564
da64016e
PE
65652011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6566
6567 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6568 Report string overflow if the output is too long.
6569
7d47b580
JB
65702011-07-04 Juanma Barranquero <lekktu@gmail.com>
6571
a555cb87
JB
6572 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6573 (syms_of_gnutls): Remove duplicate DEFSYM for
6574 Qgnutls_bootprop_verify_hostname_error, an error for
6575 Qgnutls_bootprop_verify_error (which is no longer used).
6576
7d47b580
JB
6577 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6578 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6579 Also (re)move comments that are misplaced or no longer relevant.
6580
1e49bfab
LMI
65812011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6582
6583 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6584
1485f4c0
CY
65852011-07-03 Chong Yidong <cyd@stupidchicken.com>
6586
6587 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6588 and background color parameters if they have been changed.
6589
a9ab721e
LMI
65902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6591
6592 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6593
cf7cff57
PE
65942011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6595
2e13213d
PE
6596 * xsettings.c (SYSTEM_FONT): Define only when used.
6597 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6598
cf7cff57
PE
6599 * keymap.c (access_keymap_1): Now static.
6600
7a8e04f7
CY
66012011-07-02 Chong Yidong <cyd@stupidchicken.com>
6602
6603 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6604 leave any prefix arg for the up event (Bug#1586).
6605
61352f62
LMI
66062011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6607
69bb1ef7
LMI
6608 * lread.c (syms_of_lread): Mention single symbols defined by
6609 `defvar' or `defconst' (bug#7154).
6610
61352f62 6611 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6612 (Frequire): Mention get-load-suffixes.
61352f62 6613
28545e04
MR
66142011-07-02 Martin Rudalics <rudalics@gmx.at>
6615
6616 * window.h (window): Remove clone_number slot.
6617 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6618 Remove.
6619 (make_parent_window, make_window, saved_window)
6620 (Fset_window_configuration, save_window_save): Don't deal with
6621 clone numbers.
6622 * buffer.c (Qclone_number): Remove declaration.
6623 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6624
3349e122
SM
66252011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6626
6627 Add multiple inheritance to keymaps.
6628 * keymap.c (Fmake_composed_keymap): New function.
6629 (Fset_keymap_parent): Simplify.
6630 (fix_submap_inheritance): Remove.
6631 (access_keymap_1): New function extracted from access_keymap to handle
6632 embedded parents and handle lists of maps.
6633 (access_keymap): Use it.
6634 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6635 (Fcopy_keymap): Handle embedded parents.
6636 (Fcommand_remapping, define_as_prefix): Simplify.
6637 (Fkey_binding): Simplify.
6638 (syms_of_keymap): Move minibuffer-local-completion-map,
6639 minibuffer-local-filename-completion-map,
6640 minibuffer-local-must-match-map, and
6641 minibuffer-local-filename-must-match-map to Elisp.
6642 (syms_of_keymap): Defsubr make-composed-keymap.
6643 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6644 (parse_menu_item): Trivial simplification.
6645
3279eb87
GM
66462011-07-01 Glenn Morris <rgm@gnu.org>
6647
6648 * Makefile.in (SETTINGS_LIBS): Fix typo.
6649
4550efdf
KI
66502011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6651
6652 * coding.c (Fencode_coding_string): Record the last coding system
6653 used, as the function doc string says (bug#8738).
6654
0949d2b6
JD
66552011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6656
6657 * xsettings.c (store_monospaced_changed): Take new font as arg and
6658 check for change against current_mono_font.
6659 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6660 (emacs_settings_constructor, emacs_settings_get_property)
6661 (emacs_settings_set_property, emacs_settings_class_init)
6662 (emacs_settings_init, gsettings_obj): Remove.
6663 (something_changedCB): New function for HAVE_GSETTINGS.
6664 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6665 with value as argument.
6666 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6667 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6668 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6669 "changed".
6670
6671 * xgselect.c: Add defined (HAVE_GSETTINGS).
6672 (xgselect_initialize): Ditto.
6673
6674 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6675 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6676 xg_select.
6677
bbc6b304
PE
66782011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6679
6680 * eval.c (struct backtrace): Simplify and port the data structure.
6681 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6682 signed bit field, as this assumption is not portable and it makes
6683 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6684 "char debug_on_exit : 1" as this is not portable either; instead,
6685 use the portable "unsigned int debug_on_exit : 1". Remove unused
6686 member evalargs. Remove obsolete comments about cc bombing out.
6687
9851bfc5
JD
66882011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6689
51bb811f 6690 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6691 Let HAVE_GSETTINGS override HAVE_GCONF.
6692 (store_monospaced_changed): New function.
6693 (EMACS_SETTINGS): A new type derived from GObject to handle
6694 GSettings notifications.
6695 (emacs_settings_constructor, emacs_settings_get_property)
6696 (emacs_settings_set_property, emacs_settings_class_init):
6697 New functions.
6698 (gsettings_client, gsettings_obj): New variables.
6699 (GSETTINGS_SCHEMA): New define.
6700 (something_changedCB): Call store_monospaced_changed.
6701 (init_gsettings): New function.
6702 (xsettings_initialize): Call init_gsettings.
6703 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6704 to NULL.
6705
640c8776 6706 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6707 GCONF_CFLAGS/LIBS.
6708
5386012d
MR
67092011-06-29 Martin Rudalics <rudalics@gmx.at>
6710
6711 * window.c (resize_root_window, grow_mini_window)
6712 (shrink_mini_window): Rename Qresize_root_window to
6713 Qwindow_resize_root_window and Qresize_root_window_vertically to
6714 Qwindow_resize_root_window_vertically.
6715
f13e0b08
PE
67162011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6717
6718 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6719
94515237
JB
67202011-06-27 Juanma Barranquero <lekktu@gmail.com>
6721
6722 * makefile.w32-in: Redesign dependencies so they reflect more
6723 clearly which files are directly included by each source file,
6724 and not through other includes.
6725
e43b6e43
MR
67262011-06-27 Martin Rudalics <rudalics@gmx.at>
6727
6728 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6729 (sort_overlays, overlay_strings): When an overlay's clone number
6730 matches the window's clone number process the overlay even if
6731 the overlay's window property doesn't match the current window.
6732
d68443dc
MR
6733 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6734 (Fwindow_hchild): Rename to Fwindow_left_child.
6735 (Fwindow_next): Rename to Fwindow_next_sibling.
6736 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6737 (resize_window_check): Rename to window_resize_check.
6738 (resize_window_apply): Rename to window_resize_apply.
6739 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6740 (Fdelete_other_windows_internal, resize_frame_windows)
6741 (Fsplit_window_internal, Fdelete_window_internal)
6742 (grow_mini_window, shrink_mini_window)
6743 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6744
c7e73be5
JD
67452011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6746
6747 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6748 (emacs_fixed_set_min_size): Remove.
6749 (emacs_fixed_new): Take frame as argument.
6750
6751 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6752 (_EmacsFixedPrivate): Remove minwidth/height.
6753 Add struct frame *f.
6754 (emacs_fixed_init): Initialize priv->f.
6755 (get_parent_class, emacs_fixed_set_min_size): Remove.
6756 (emacs_fixed_new): Set priv->f to argument.
6757 (emacs_fixed_get_preferred_width)
6758 (emacs_fixed_get_preferred_height): Use min_width/height from
6759 frames size_hint to set minimum and natural (Bug#8919).
6760 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6761 and use min_width/height from frames size_hint to set
6762 min_width/height (Bug#8919).
6763
6764 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6765 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6766 Fix indentation.
c7e73be5 6767
cf99dcf8
EZ
67682011-06-26 Eli Zaretskii <eliz@gnu.org>
6769
6770 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6771 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6772 called at ZV.
6773
029529ac
CY
67742011-06-26 Chong Yidong <cyd@stupidchicken.com>
6775
6776 * process.c (wait_reading_process_output): Bypass select if
6777 waiting for a cell while ignoring keyboard input, and input is
6778 pending. Suggested by Jan Djärv (Bug#8869).
6779
7a7ef429
PE
67802011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6781
6782 Use gnulib's dup2 module instead of rolling our own.
6783 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6784
11fdef7d 67852011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6786
6787 * dispnew.c (scrolling_window): Before scrolling, turn off a
6788 mouse-highlight in the window being scrolled.
6789
cd3520a4
JB
67902011-06-24 Juanma Barranquero <lekktu@gmail.com>
6791
6792 Move DEFSYM to lisp.h and use everywhere.
6793
6794 * character.h (DEFSYM): Move declaration...
6795 * lisp.h (DEFSYM): ...here.
6796
6797 * gnutls.c:
6798 * minibuf.c:
6799 * w32menu.c:
6800 * w32proc.c:
6801 * w32select.c: Don't include character.h.
6802
6803 * alloc.c (syms_of_alloc):
6804 * buffer.c (syms_of_buffer):
6805 * bytecode.c (syms_of_bytecode):
6806 * callint.c (syms_of_callint):
6807 * casefiddle.c (syms_of_casefiddle):
6808 * casetab.c (init_casetab_once):
6809 * category.c (init_category_once, syms_of_category):
6810 * ccl.c (syms_of_ccl):
6811 * cmds.c (syms_of_cmds):
6812 * composite.c (syms_of_composite):
6813 * dbusbind.c (syms_of_dbusbind):
6814 * dired.c (syms_of_dired):
6815 * dispnew.c (syms_of_display):
6816 * doc.c (syms_of_doc):
6817 * editfns.c (syms_of_editfns):
6818 * emacs.c (syms_of_emacs):
6819 * eval.c (syms_of_eval):
6820 * fileio.c (syms_of_fileio):
6821 * fns.c (syms_of_fns):
6822 * frame.c (syms_of_frame):
6823 * fringe.c (syms_of_fringe):
6824 * insdel.c (syms_of_insdel):
6825 * keymap.c (syms_of_keymap):
6826 * lread.c (init_obarray, syms_of_lread):
6827 * macros.c (syms_of_macros):
6828 * msdos.c (syms_of_msdos):
6829 * print.c (syms_of_print):
6830 * process.c (syms_of_process):
6831 * search.c (syms_of_search):
6832 * sound.c (syms_of_sound):
6833 * syntax.c (init_syntax_once, syms_of_syntax):
6834 * terminal.c (syms_of_terminal):
6835 * textprop.c (syms_of_textprop):
6836 * undo.c (syms_of_undo):
6837 * w32.c (globals_of_w32):
6838 * window.c (syms_of_window):
6839 * xdisp.c (syms_of_xdisp):
6840 * xfaces.c (syms_of_xfaces):
6841 * xfns.c (syms_of_xfns):
6842 * xmenu.c (syms_of_xmenu):
6843 * xsettings.c (syms_of_xsettings):
6844 * xterm.c (syms_of_xterm): Use DEFSYM.
6845
4228cf16
TZ
68462011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6847
cd3520a4 6848 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6849
7fcccf1e
PE
68502011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6851
7efb4e0e
PE
6852 Integer and buffer overflow fixes (Bug#8873).
6853
ff5844ad
PE
6854 * print.c (printchar, strout): Check for string overflow.
6855 (PRINTPREPARE, printchar, strout):
6856 Don't set size unless allocation succeeds.
6857
90532f02
PE
6858 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6859 for sizes. Check for string overflow more accurately.
6860 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6861
6d84508d
PE
6862 * macros.c: Integer and buffer overflow fixes.
6863 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6864 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6865 Use ptrdiff_t, not int, for sizes.
6866 Don't increment bufsize until after realloc succeeds.
6867 Check for size-calculation overflow.
6868 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6869
437b2cb4
PE
6870 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6871
8b9ac8b4
PE
6872 * lread.c: Integer overflow fixes.
6873 (read_integer): Radix is now EMACS_INT, not int,
6874 to improve quality of diagnostics for out-of-range radices.
6875 Calculate buffer size correctly for out-of-range radices.
6876 (read1): Check for integer overflow in radices, and in
6877 read-circle numbers.
82cb60d3
PE
6878 (read_escape): Avoid int overflow.
6879 (Fload, openp, read_buffer_size, read1)
6880 (substitute_object_recurse, read_vector, read_list, map_obarray):
6881 Use ptrdiff_t, not int, for sizes.
6882 (read1): Use EMACS_INT, not int, for sizes.
20270765 6883 Check for size overflow.
8b9ac8b4 6884
7fcccf1e
PE
6885 * image.c (cache_image): Check for size arithmetic overflow.
6886
bfbbd7e7
PE
6887 * lread.c: Integer overflow issues.
6888 (saved_doc_string_size, saved_doc_string_length)
6889 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6890 Now ptrdiff_t, not int.
6891 (read1): Don't assume doc string length fits in int. Check for
6892 out-of-range doc string lengths.
6893 (read_list): Don't assume file position fits in int.
39019e54 6894 (read_escape): Check for hex character overflow.
bfbbd7e7 6895
4e323265
LL
68962011-06-22 Leo Liu <sdl.web@gmail.com>
6897
6898 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6899 Move to minibuffer.el.
6900
85fece3e
PE
69012011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6902
20b84ce9 6903 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6904 The following patches are for when GLYPH_DEBUG && !XASSERT.
6905 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6906 * dispnew.c (flush_stdout):
6907 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6908 Mark as externally visible.
6909 * dispnew.c (check_window_matrix_pointers): Now static.
6910 * dispnew.c (window_to_frame_vpos):
6911 * xfns.c (unwind_create_frame):
6912 * xterm.c (x_check_font): Remove unused local.
6913 * scroll.c (CHECK_BOUNDS):
6914 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6915 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6916 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6917 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6918 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6919 Now static.
6920 (debug_method_add): Use va_list and vsprintf rather than relying
6921 on undefined behavior with wrong number of arguments.
6922 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6923 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6924 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6925 since we're not interested in debugging glyphs with old libraries.
6926 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6927 GCC 4.6.0's static checking.
6928
0766b489
PE
69292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6930
31fd4b32
PE
6931 Integer overflow and signedness fixes (Bug#8873).
6932 A few related buffer overrun fixes, too.
6933
b79e8648
PE
6934 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6935
0766b489
PE
6936 * dispextern.h (struct face.stipple):
6937 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6938 (x_bitmap_mask, x_allocate_bitmap_record)
6939 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6940 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6941 (x_create_bitmap_from_xpm_data):
6942 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6943 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6944 (.bitmaps_last):
6945 * xfaces.c (load_pixmap):
6946 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6947 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6948 (.bitmaps_last, struct x_output.icon_bitmap):
6949 Use ptrdiff_t, not int, for bitmap indexes.
6950 (x_allocate_bitmap_record): Check for size overflow.
6951 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6952
b081724f
PE
6953 Use ptrdiff_t, not int, for overlay counts.
6954 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6955 * editfns.c (overlays_around, get_pos_property):
6956 * textprop.c (get_char_property_and_overlay):
6957 * xdisp.c (next_overlay_change, note_mouse_highlight):
6958 * xfaces.c (face_at_buffer_position):
21514da7
PE
6959 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6960 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6961 (Fnext_overlay_change, Fprevious_overlay_change)
6962 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6963 Use ptrdiff_t, not int, for sizes.
21514da7 6964 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6965
3de73e5e
PE
6966 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6967
2606c57b
PE
6968 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6969 (x_session_initialize): Do not assume string length fits in int.
6970
aaafe47a
PE
6971 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6972 This is unlikely, but can occur if DPI is outlandish.
6973
2674ddc8 6974 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6975 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6976
28154962
PE
6977 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6978 * xrdb.c (magic_file_p, search_magic_path):
6979 Omit last arg SUFFIX; it was always 0. All callers changed.
6980 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6981
7de51af5
PE
6982 * xfont.c (xfont_match): Avoid need for strlen.
6983
25ed6cc3
PE
6984 * xfns.c: Don't assume strlen fits in int.
6985 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6986
4eab31dd
PE
6987 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6988 not unsigned long, as we prefer signed integers. All callers changed.
6989 Detect integer overflow in repeat count.
6990 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6991 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6992
171e2a58
PE
6993 * termcap.c: Don't assume sizes fit in int and never overflow.
6994 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6995 (gobble_line): Check for size-calculation overflow.
6996
ad39faca 6997 * minibuf.c (Fread_buffer):
6e5bb2dc 6998 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6999 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7000 Don't assume string length fits in int.
7001
52c61c22 7002 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7003 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7004
b5b8c9e5
PE
7005 * font.c: Don't assume string length fits in int.
7006 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7007 Use ptrdiff_t, not int.
ccd6111c
PE
7008 (font_intern_prop): Don't assume string length fits in int.
7009 Don't assume integer property fits in fixnum.
7010 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7011
882f0d81 7012 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7013 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7014 Reformulate so as not to need the command string.
7015 Invoke gzip -cd rather than gunzip, as it's more portable.
7016 (lock_info_type, lock_file_1, lock_file):
7017 Don't assume pid_t and time_t fit in unsigned long.
7018 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7019 (current_lock_owner): Prefer signed type for sizes.
7020 Use memcpy, not strncpy, where memcpy is what is really wanted.
7021 Don't assume (via atoi) that time_t and pid_t fit in int.
7022 Check for time_t and/or pid_t out of range, e.g., via a network share.
7023 Don't alloca where an auto var works fine.
7024
93f4cf88
PE
7025 * fileio.c: Fix some integer overflow issues.
7026 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7027 Don't assume string length fits in int.
7028 (directory_file_name): Don't assume string length fits in long.
7029 (make_temp_name): Don't assume pid fits in int, or that its print
7030 length is less than 20.
7031
f3e92b69
PE
7032 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7033
1bfdaf10
PE
7034 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7035
35016e9a
PE
7036 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7037
3d1e65a1
PE
7038 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7039 We prefer signed integers, even for size calculations.
7040
0b963a93
PE
7041 * emacs.c: Don't assume string length fits in 'int'.
7042 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7043 (main): Don't invoke strlen when not needed.
7044
573f4b54
PE
7045 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7046 (XD_DEBUG_MESSAGE): Don't waste a byte.
7047
989f33ba
PE
7048 * callproc.c (getenv_internal_1, getenv_internal)
7049 (Fgetenv_internal):
965d34eb
PE
7050 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7051
e4d29b33
PE
7052 * lread.c (invalid_syntax): Omit length argument.
7053 All uses changed. This doesn't fix a bug, but it simplifies the
7054 code away from its former Hollerith-constant appearance, and it's
7055 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7056 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7057
eb49b136
PE
7058 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7059 This didn't break anything, but it didn't help either.
7060 It's confusing to put a bogus integer in a place where the actual
7061 value does not matter.
9f62aeb1 7062 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7063 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7064
15375a22
PE
7065 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7066 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7067 implementation.
b61cc01c
PE
7068 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7069 We prefer signed types, and the value cannot exceed the EMACS_INT
7070 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7071 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7072 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7073 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7074
53b2623d
PE
7075 * indent.c (sane_tab_width): New function.
7076 (current_column, scan_for_column, Findent_to, position_indentation)
7077 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7078 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7079
51cab52b 7080 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7081
f2ed8a70
PE
7082 * lisp.h (lint_assume): New macro.
7083 * composite.c (composition_gstring_put_cache):
7084 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7085
abe80cc6
PE
7086 * editfns.c, insdel.c:
7087 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7088
b02c740e
PE
7089 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7090
ebc96716
PE
7091 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7092
b4e50fa0 7093 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7094 Use much-faster test for byte-length change.
311d5d7c 7095 Don't assume string byte-length fits in 'int'.
a4cf38e4 7096 Check that character arg fits in 'int'.
85461888 7097 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7098
c0c1ee9f
PE
7099 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7100
a498d7f4
PE
7101 * fns.c (concat): Catch string overflow earlier.
7102 Do not rely on integer wraparound.
7103
51cab52b
PE
7104 * dispextern.h (struct it.overlay_strings_charpos)
7105 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7106 * xdisp.c (forward_to_next_line_start)
7107 (back_to_previous_visible_line_start)
7108 (reseat_at_next_visible_line_start, next_element_from_buffer):
7109 Don't arbitrarily truncate the value of 'selective' to int.
7110
76031fad
PE
7111 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7112
5eb55db9
PE
7113 * composite.c: Don't truncate sizes to 'int'.
7114 (composition_gstring_p, composition_reseat_it)
7115 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7116 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7117 not EMACS_UINT, for indexes.
5eb55db9 7118
0703a717
PE
7119 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7120
d6202519
PE
7121 * buffer.c: Include <verify.h>.
7122 (struct sortvec.priority, struct sortstr.priority):
8961a454 7123 Now EMACS_INT, not int.
c20998a7 7124 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7125 (struct sortstr.size, record_overlay_string)
7126 (struct sortstrlist.size, struct sortlist.used):
7127 Don't truncate size to int.
7128 (record_overlay_string): Check for size-calculation overflow.
d6202519 7129 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7130
d5a19415
JM
71312011-06-22 Jim Meyering <meyering@redhat.com>
7132
029529ac 7133 Don't leak an XBM-image-sized buffer
d5a19415
JM
7134 * image.c (xbm_load): Free the image buffer after using it.
7135
a9041e6c
PE
71362011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7137
7138 Port to Sun C.
7139 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7140 that Sun C diagnosed.
7141 * fns.c (secure_hash): Fix pointer signedness issue.
7142 * intervals.c (static_offset_intervals): New function.
7143 (offset_intervals): Use it.
7144
7f3f739f
LL
71452011-06-21 Leo Liu <sdl.web@gmail.com>
7146
7147 * deps.mk (fns.o):
7148 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7149 sha512.h.
7150
7151 * fns.c (secure_hash): Rename from crypto_hash_function and change
7152 the first arg to accept symbols.
5b66d427 7153 (Fsecure_hash): New primitive.
7f3f739f
LL
7154 (syms_of_fns): New symbols.
7155
76147d94
DD
71562011-06-20 Deniz Dogan <deniz@dogan.se>
7157
7158 * process.c (Fset_process_buffer): Clarify return value in
7159 docstring.
7160
7d7d0045
CY
71612011-06-18 Chong Yidong <cyd@stupidchicken.com>
7162
7163 * dispnew.c (add_window_display_history): Use BVAR.
7164
7165 * xdisp.c (debug_method_add): Use BVAR.
7166 (check_window_end, dump_glyph_matrix, dump_glyph)
7167 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7168
7169 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7170 Likewise.
7171
7172 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7173 check till after the cache is created in init_frame_faces.
7174
ff2bc410
SM
71752011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7176
7177 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7178
28177add
PE
71792011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7180
dd3482fe
PE
7181 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7182 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7183 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7184
393d71f3 7185 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7186 * fileio.c (Finsert_file_contents):
7187 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7188 Remove the old (too-loose) buffer overflow checks.
7189 They weren't needed, since make_gap checks for buffer overflow.
7190 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7191 The old code merely checked for Emacs fixnum overflow, and relied
7192 on undefined (wraparound) behavior. The new code avoids undefined
7193 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7194
2e6813b0 7195 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7196 Tune. Don't use wider integers than needed. Don't use alloca.
7197 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7198
599a9e4f
PE
7199 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7200
99561444
PE
7201 * insdel.c, lisp.h (buffer_overflow): New function.
7202 (insert_from_buffer_1, replace_range, replace_range_2):
7203 * insdel.c (make_gap_larger):
7204 * editfns.c (Finsert_char):
7205 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7206
28177add
PE
7207 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7208
e69dafad
PE
72092011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7210
4baa020d 7211 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7212
b1c46f02
PE
7213 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7214 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7215
e69dafad
PE
7216 * fileio.c: Don't assume EMACS_INT fits in off_t.
7217 (emacs_lseek): New static function.
7218 (Finsert_file_contents, Fwrite_region): Use it.
7219 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7220
566684ea
PE
7221 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7222
e6966cd6
PE
7223 * fns.c: Don't overflow int when computing a list length.
7224 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7225 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7226 truncation on 64-bit hosts. Check for QUIT every
7227 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7228 faster and is responsive enough.
7229 (Flength): Report an error instead of overflowing an integer.
7230 (Fsafe_length): Return a float if the value is not representable
7231 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7232 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7233 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7234
dd0b0efb
PE
7235 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7236 (header_size, word_size): New constants.
7237 (allocate_vectorlike): Don't check size overflow here.
7238 (allocate_vector): Check it here instead, since this is the only
7239 caller of allocate_vectorlike that could cause overflow.
7240 Check that the new vector's length is representable as a fixnum.
7241
86fe5cfe
PE
7242 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7243 The previous code was bogus. For example, next_almost_prime (32)
7244 returned 39, which is undesirable as it is a multiple of 3; and
7245 next_almost_prime (24) returned 25, which is a multiple of 5 so
7246 why was the code bothering to check for multiples of 7?
7247
80e88859
PE
7248 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7249
4a2f0ad6
PE
7250 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7251
f66c7cf8
PE
7252 Variadic C functions now count arguments with ptrdiff_t.
7253 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7254 Back then I didn't know that the Emacs coding style prefers signed int.
7255 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7256 were being counted with int, which may truncate counts on 64-bit
7257 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7258 * lisp.h (struct Lisp_Subr.function.aMANY)
7259 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7260 Arg counts are now ptrdiff_t, not size_t.
7261 All variadic functions and their callers changed accordingly.
7262 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7263 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7264 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7265 * callint.c (Fcall_interactively): Check arg count for overflow,
7266 to avoid potential buffer overrun. Use signed char, not 'int',
7267 for 'varies' array, so that we needn't bother to check its size
7268 calculation for overflow.
7269 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7270 * eval.c (apply_lambda):
7271 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7272 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7273 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7274
a1759b76
PE
7275 * callint.c (Fcall_interactively): Don't use index var as event count.
7276
d96be9fc
PE
7277 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7278 * mem-limits.h (SIZE): Remove; no longer used.
7279
a690a978 7280 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7281
578c21e6
PE
7282 Remove unnecessary casts.
7283 * xterm.c (x_term_init):
7284 * xfns.c (x_set_border_pixel):
7285 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7286 These aren't needed now that we assume ANSI C.
7287
96f53c6c
PE
7288 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7289 It's more likely to cause problems (due to unsigned overflow)
7290 than to cure them.
7291
83c77d31
PE
7292 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7293
ee2079f1
PE
7294 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7295
6da65536
PE
7296 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7297
7147c4a4
PE
7298 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7299
193e32d9
PE
7300 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7301
e5533da6
PE
7302 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7303
9910e595
PE
7304 GLYPH_CODE_FACE returns EMACS_INT, not int.
7305 * dispextern.h (merge_faces):
7306 * xfaces.c (merge_faces):
01103c44
PE
7307 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7308 Don't assume EMACS_INT fits in int.
9910e595 7309
2638320e
PE
7310 * character.h (CHAR_VALID_P): Remove unused parameter.
7311 * fontset.c, lisp.h, xdisp.c: All uses changed.
7312
045eb8d9
PE
7313 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7314
c1f134b5
PE
7315 * fns.c (concat): Minor tuning based on overflow analysis.
7316 This doesn't fix any bugs. Use int to hold character, instead
7317 of constantly refetching from Emacs object. Use XFASTINT, not
7318 XINT, for value known to be a character. Don't bother comparing
7319 a single byte to 0400, as it's always less.
7320
395fcb93 7321 * floatfns.c (Fexpt):
327eeec8
PE
7322 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7323
abbd3d23
PE
7324 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7325 for characters.
7326
684a03ef
PE
7327 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7328
0fed43f3
PE
7329 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7330 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7331 incorrectly succeed when S was a string, because 4294967386 was
7332 truncated before it was used.
7333
8fd02eb7
PE
7334 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7335 Otherwise, an out-of-range integer could cause undefined behavior
7336 on a 64-bit host.
7337
f8c86b69
PE
7338 * composite.c: Use int, not EMACS_INT, for characters.
7339 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7340 EMACS_INT, for values that are known to be in character range.
7341 This doesn't fix any bugs but is the usual style inside Emacs and
7342 may generate better code on 32-bit machines.
7343
34206dd2
PE
7344 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7345 This is for reasons similar to the recent CHAR_STRING fix.
7346 * charset.c (Fencode_char): Check that character arg is actually
7347 a character. Pass an int to ENCODE_CHAR.
7348 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7349 wider than 'int', as a compile-time check to prevent future regressions
7350 in this area.
7351
c5958d4c 7352 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7353
7354 Make sure a 64-bit char is never passed to CHAR_STRING.
7355 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7356 by silently ignoring the top 32 bits, allowing some values
7357 that were far too large to be valid characters.
7358 * character.h: Include <verify.h>.
7359 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7360 arguments are no wider than unsigned, as a compile-time check
7361 to prevent future regressions in this area.
7362 * data.c (Faset):
01103c44 7363 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7364 (Fsubst_char_in_region):
7365 * fns.c (concat):
7366 * xdisp.c (decode_mode_spec_coding):
7367 Adjust to CHAR_STRING's new requirement.
7368 * editfns.c (Finsert_char, Fsubst_char_in_region):
7369 * fns.c (concat): Check that character args are actually
7370 characters. Without this test, these functions did the wrong
7371 thing with wildly out-of-range values on 64-bit hosts.
7372
d37ca623
PE
7373 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7374 These casts should not be needed on 32-bit hosts, either.
7375 * keyboard.c (read_char):
7376 * lread.c (Fload): Remove casts to unsigned.
7377
ea204efb
PE
7378 * lisp.h (UNSIGNED_CMP): New macro.
7379 This fixes comparison bugs on 64-bit hosts.
7380 (ASCII_CHAR_P): Use it.
7381 * casefiddle.c (casify_object):
01103c44 7382 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7383 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7384 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7385 * dispextern.h (FACE_FROM_ID):
7386 * keyboard.c (read_char): Use UNSIGNED_CMP.
7387
41cb286c
PE
7388 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7389 not to EMACS_INT, to avoid GCC warning.
7390
4a1b9832
PE
7391 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7392
55daad71
PE
7393 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7394 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7395 isn't needed on 32-bit machines.
8f95c75c 7396
01103c44
PE
7397 * buffer.c (Fgenerate_new_buffer_name):
7398 Use EMACS_INT for count, not int.
0ceccced 7399 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7400
7401 * data.c (Qcompiled_function): Now static.
7402
c6f072e7
PE
7403 * window.c (window_body_lines): Now static.
7404
20ce5912
PE
7405 * image.c (gif_load): Rename local to avoid shadowing.
7406
9c4c5f81
PE
7407 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7408 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7409 * alloc.c (make_save_value): Integer argument is now of type
7410 ptrdiff_t, not int.
7411 (mark_object): Use ptrdiff_t, not int.
7412 * lisp.h (pD): New macro.
7413 * print.c (print_object): Use it.
7414
c0c5c8ae
PE
7415 * alloc.c: Use EMACS_INT, not int, to count objects.
7416 (total_conses, total_markers, total_symbols, total_vector_size)
7417 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7418 (total_free_floats, total_floats, total_free_intervals)
7419 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7420 Now EMACS_INT, not int. All uses changed.
7421 (Fgarbage_collect): Compute overall total using a double, so that
7422 integer overflow is less likely to be a problem. Check for overflow
7423 when converting back to an integer.
5a25e253
PE
7424 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7425 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7426 These were 'int' variables that could overflow on 64-bit hosts;
7427 they were never used, so remove them instead of repairing them.
211a0b2a 7428 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7429 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7430 Previously, this ceilinged at INT_MAX, but that doesn't work on
7431 64-bit machines.
e46bb31a 7432 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7433
c78baabf 7434 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7435 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7436 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7437 when a (possibly-narrower) signed value would do just as well.
7438 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7439
c9d624c6
PE
7440 * alloc.c: Catch some string size overflows that we were missing.
7441 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7442 for convenience in STRING_BYTES_MAX.
7443 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7444 The definition here is exact; the one in lisp.h was approximate.
7445 (allocate_string_data): Check for string overflow. This catches
7446 some instances we weren't catching before. Also, it catches
7447 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7448 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7449 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7450
c9d624c6
PE
7451 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7452 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7453 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7454
353032ce
PE
7455 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7456
2bccce07
PE
7457 * alloc.c (Fmake_string): Check for out-of-range init.
7458
0ac30604
SM
74592011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7460
7461 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7462
c195f2de
JD
74632011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7464
7465 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7466 xg_get_default_scrollbar_width.
7467
7468 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7469 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7470 (style_changed_cb): Call update_theme_scrollbar_width and call
7471 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7472 all frames (Bug#8505).
7473 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7474 Call gtk_window_set_resizable if HAVE_GTK3.
7475 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7476 and height if HAVE_GTK3 (Bug#8505).
7477 (scroll_bar_width_for_theme): New variable.
7478 (update_theme_scrollbar_width): New function.
7479 (xg_get_default_scrollbar_width): Move code to
7480 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7481 (xg_initialize): Call update_theme_scrollbar_width.
7482
7483 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7484
7485 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7486
e10ac9f1
MR
74872011-06-12 Martin Rudalics <rudalics@gmx.at>
7488
7489 * frame.c (make_frame): Call other_buffer_safely instead of
7490 other_buffer.
7491
7492 * window.c (temp_output_buffer_show): Call display_buffer with
7493 second argument Vtemp_buffer_show_specifiers and reset latter
7494 immediately after the call.
7495 (Vtemp_buffer_show_specifiers): New variable.
7496 (auto_window_vscroll_p, next_screen_context_lines)
7497 (Vscroll_preserve_screen_position): Remove leading asterisks from
7498 doc-strings.
7499
2d3c217e 75002011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7501
7b7f97e8 7502 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7503 * buffer.c (Qclone_number): Remove for now, as it's unused.
7504 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7505 (record_buffer): Remove unused local.
7506 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7507 (set_frame_buffer_list): Remove; unused.
7508 * frame.h (other_visible_frames): Remove decl.
7509 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7510 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7511 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7512 if HAVE_GPM.
7513 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7514 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7515 Define only if HAVE_GPM.
7516 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7517 (update_hints_inhibit): Remove; never set. All uses removed.
7518 * widgetprv.h (emacsFrameClassRec): Remove decl.
7519 * window.c (delete_deletable_window): Now returns void, since it
7520 wasn't returning anything.
7521 (compare_window_configurations): Remove unused locals.
7522 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7523 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7524 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7525 the same widths as pointers. This follows up on the 2011-05-06 patch.
7526 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7527 * xterm.h: Likewise.
7528 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7529
1384b89e
JB
75302011-06-12 Juanma Barranquero <lekktu@gmail.com>
7531
7532 * makefile.w32-in: Update dependencies.
7533 (LISP_H): Add lib/intprops.h.
7534
1100a63c
CY
75352011-06-11 Chong Yidong <cyd@stupidchicken.com>
7536
7537 * image.c (gif_load): Add animation frame delay to the metadata.
7538 (syms_of_image): Use DEFSYM. New symbol `delay'.
7539
6198ccd0
MR
75402011-06-11 Martin Rudalics <rudalics@gmx.at>
7541
7542 * window.c (delete_deletable_window): Re-add.
7543 (Fset_window_configuration): Rewrite to handle dead buffers and
7544 consequently deletable windows.
7545 (window_tree, Fwindow_tree): Remove. Supply functionality in
7546 window.el.
7547 (compare_window_configurations): Simplify code.
7548
b6e3633c
AS
75492011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7550
1ab0dee5
AS
7551 * image.c (imagemagick_load_image): Fix type mismatch.
7552 (Fimagemagick_types): Likewise.
7553
b6e3633c
AS
7554 * window.h (replace_buffer_in_windows): Declare.
7555
9397e56f
MR
75562011-06-11 Martin Rudalics <rudalics@gmx.at>
7557
7558 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7559 Qclone_number. Remove external declaration of Qdelete_window.
7560 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7561 code.
640c8776
SM
7562 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7563 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7564 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7565 buffer list implementation.
7566 (other_buffer_safely): New function.
7567 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7568 calls to replace_buffer_in_windows and
7569 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7570 if allowed.
7571 (record_buffer): Inhibit quitting and rewrite using quittable
7572 functions. Run Qbuffer_list_update_hook if allowed.
7573 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7574 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7575 Move switch-to-buffer to window.el.
9397e56f
MR
7576 (bury-buffer): Move to window.el.
7577 (Vbuffer_list_update_hook): New variable.
7578
7579 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7580 section.
7581
7582 * window.h (resize_frame_windows): Move up in code.
7583 (Fwindow_frame): Remove EXFUN.
7584 (replace_buffer_in_all_windows): Remove prototype.
7585 (replace_buffer_in_windows_safely): Add prototype.
7586
7587 * window.c: Declare Qdelete_window static again. Move down
7588 declaration of select_count.
7589 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7590 (Fother_window): Move to window.el.
7591 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7592 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7593 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7594 window.el.
7595 (replace_buffer_in_windows): Implement by calling
7596 Qreplace_buffer_in_windows.
7597 (replace_buffer_in_all_windows): Remove with some functionality
7598 moved into replace_buffer_in_windows_safely.
7599 (replace_buffer_in_windows_safely): New function.
7600 (select_window_norecord, select_frame_norecord): Move in front
7601 of run_window_configuration_change_hook. Remove now obsolete
7602 declarations.
640c8776
SM
7603 (Fset_window_buffer): Rewrite doc-string.
7604 Call Qrecord_window_buffer.
9397e56f
MR
7605 (keys_of_window): Move binding for other-window to window.el.
7606
b50691aa
CY
76072011-06-11 Chong Yidong <cyd@stupidchicken.com>
7608
7609 * dispextern.h (struct image): Replace data member, whose int_val
7610 and ptr_val fields were not used by anything, with a single
7611 lisp_val object.
7612
7613 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7614 (gif_clear_image, gif_load, imagemagick_load_image)
7615 (gs_clear_image, gs_load): Callers changed.
7616
3f754b86
PE
76172011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7618
cca69397
PE
7619 * buffer.h: Include <time.h>, for time_t.
7620 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7621
109e28d0
PE
7622 Fix minor problems found by static checking.
7623
60737f02
PE
7624 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7625
4b66faf3
PE
7626 Make identifiers static if they are not used in other modules.
7627 * data.c (Qcompiled_function, Qframe, Qvector):
7628 * image.c (QimageMagick, Qsvg):
7629 * minibuf.c (Qmetadata):
7630 * window.c (resize_window_check, resize_root_window): Now static.
7631 * window.h (resize_window_check, resize_root_window): Remove decls.
7632
109e28d0
PE
7633 * window.c (window_deletion_count, delete_deletable_window):
7634 Remove; unused.
46a4ce9e
PE
7635 (window_body_lines): Now static.
7636 (Fdelete_other_windows_internal): Mark vars as initialized.
7637 Make sure 'resize_failed' is initialized.
7638 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7639 (resize_window_apply): Remove unused local.
7640 * window.h (delete_deletable_window): Remove decl.
7641
109e28d0 7642 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7643 (imagemagick_load_image): Fix pointer signedness problem by changing
7644 last arg from unsigned char * to char *. All uses changed.
7645 Also, fix a local for similar reasons.
7646 Remove unused locals. Remove locals to avoid shadowing.
7647 (fn_rsvg_handle_free): Remove; unused.
7648 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7649 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7650
3f754b86
PE
7651 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7652
2547adb1
CY
76532011-06-10 Chong Yidong <cyd@stupidchicken.com>
7654
7655 * image.c (gif_load): Fix omitted cast error introduced by
7656 2011-06-06 change.
7657
2c8e37d4
MR
76582011-06-10 Martin Rudalics <rudalics@gmx.at>
7659
7660 * window.h (resize_proportionally, orig_total_lines)
7661 (orig_top_line): Remove from window structure.
7662 (set_window_height, set_window_width, change_window_heights)
7663 (Fdelete_window): Remove prototypes.
7664 (resize_frame_windows): Remove duplicate declaration.
7665
440a42e3
EZ
76662011-06-10 Eli Zaretskii <eliz@gnu.org>
7667
7668 * window.h (resize_frame_windows, resize_window_check)
7669 (delete_deletable_window, resize_root_window)
7670 (resize_frame_windows): Declare prototypes.
7671
7672 * window.c (resize_window_apply): Make definition be "static" to
7673 match the prototype.
7674
562dd5e9
MR
76752011-06-10 Martin Rudalics <rudalics@gmx.at>
7676
7677 * window.c: Remove declarations of Qwindow_size_fixed,
7678 window_min_size_1, window_min_size_2, window_min_size,
7679 size_window, window_fixed_size_p, enlarge_window, delete_window.
7680 Remove static from declaration of Qdelete_window, it's
7681 temporarily needed by Fbury_buffer.
7682 (replace_window): Don't assign orig_top_line and
7683 orig_total_lines.
7684 (Fdelete_window, delete_window): Remove. Window deletion is
7685 handled by window.el.
640c8776
SM
7686 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7687 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7688 (Fdelete_other_windows): Remove. Deleting other windows is
7689 handled by window.el.
7690 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7691 handled in window.el.
7692 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7693 Window minimum sizes are handled in window.el.
7694 (shrink_windows, size_window, set_window_height)
7695 (set_window_width, change_window_heights, window_height)
7696 (window_width, CURBEG, CURSIZE, enlarge_window)
7697 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7698 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7699 handled in window.el.
7700 (make_dummy_parent): Rename to make_parent_window and give it a
7701 second argument horflag.
7702 (make_window): Don't set resize_proportionally any more.
7703 (Fsplit_window): Remove. Windows are split in window.el.
7704 (save_restore_action, save_restore_orig_size)
7705 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7706 Resize mini windows in window.el.
7707 (grow_mini_window, shrink_mini_window): Implement by calling
7708 Qresize_root_window_vertically, resize_window_check and
7709 resize_window_apply.
640c8776
SM
7710 (saved_window, Fset_window_configuration, save_window_save):
7711 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7712 resize_proportionally.
7713 (window_min_height, window_min_width): Move to window.el.
7714 (keys_of_window): Move bindings for delete-other-windows,
7715 split-window, delete-window and enlarge-window to window.el.
7716
7717 * buffer.c: Temporarily extern Qdelete_window.
7718 (Fbury_buffer): Temporarily call Qdelete_window instead of
7719 Fdelete_window (Fbury_buffer will move to window.el soon).
7720
7721 * frame.c (set_menu_bar_lines_1): Remove code handling
7722 orig_top_line and orig_total_lines.
7723
7724 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7725 set_window_height but set heights directly.
7726 (change_frame_size_1): Use resize_frame_windows.
7727
7728 * xdisp.c (init_xdisp): Don't use set_window_height but set
7729 heights directly.
7730
640c8776
SM
7731 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7732 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7733 run_window_configuration_change_hook.
7734
7735 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7736 instead of change_window_heights and run
7737 run_window_configuration_change_hook.
7738
1a13852e
MR
77392011-06-09 Martin Rudalics <rudalics@gmx.at>
7740
7741 * window.c (replace_window): Rename second argument REPLACEMENT to
7742 NEW. New third argument SETFLAG. Rewrite.
7743 (delete_window, make_dummy_parent): Call replace_window with
7744 third argument 1.
7745 (window_list_1): Move down in code.
7746 (run_window_configuration_change_hook): Move set_buffer part
7747 before select_frame_norecord part in order to unwind correctly.
7748 Rename count1 to count.
7749 (recombine_windows, delete_deletable_window, resize_root_window)
7750 (Fdelete_other_windows_internal)
7751 (Frun_window_configuration_change_hook, make_parent_window)
7752 (resize_window_check, resize_window_apply, Fresize_window_apply)
7753 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7754 (Fdelete_window_internal, Fresize_mini_window_internal):
7755 New functions.
1a13852e
MR
7756 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7757
f3d1777e
MR
77582011-06-08 Martin Rudalics <rudalics@gmx.at>
7759
496e208e
MR
7760 * window.h (window): Add some new members to window structure -
7761 normal_lines, normal_cols, new_total, new_normal, clone_number,
7762 splits, nest, prev_buffers, next_buffers.
7763 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7764 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7765
f3d1777e
MR
7766 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7767 Remove.
496e208e
MR
7768 (make_dummy_parent): Set new members of windows structure.
7769 (make_window): Move down in code. Handle new members of window
7770 structure.
7771 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7772 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7773 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7774 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7775 (Fset_window_next_buffers, Fset_window_clone_number):
7776 New functions.
496e208e
MR
7777 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7778 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7779 Doc-string fixes.
7780 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7781 Argument WINDOW can be now internal window too.
7782 (Fwindow_use_time): Move up in code.
7783 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7784 Rewrite doc-string.
7785 (Fset_window_configuration, saved_window)
7786 (Fcurrent_window_configuration, save_window_save): Handle new
7787 members of window structure.
b9e809c2
MR
7788 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7789 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7790 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7791 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7792 Qget_mru_window, Qresize_root_window,
7793 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7794 Qauto_buffer_name; staticpro them.
f3d1777e 7795
abde8f8c
MR
77962011-06-07 Martin Rudalics <rudalics@gmx.at>
7797
7798 * window.c (Fwindow_total_size, Fwindow_left_column)
7799 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7800 (Fwindow_list_1): New functions.
7801 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7802 (Fwindow_width, Fscroll_left, Fscroll_right):
7803 Use window_body_cols instead of window_box_text_cols.
7804 (delete_window, Fset_window_configuration):
7805 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7806 (delete_all_subwindows): Take a window as argument and not a
7807 structure. Rewrite.
190b47e6
MR
7808 (window_loop): Remove handling of GET_LRU_WINDOW and
7809 GET_LARGEST_WINDOW.
7810 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7811
7812 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7813 window_box_text_cols. delete_all_subwindows now takes a
7814 Lisp_Object as argument.
abde8f8c 7815
640c8776
SM
7816 * indent.c (compute_motion, Fcompute_motion):
7817 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7818
fa8a67e6
MR
7819 * frame.c (delete_frame): Call delete_all_subwindows with root
7820 window as argument.
7821
a54e3482
DC
78222011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7823
7824 * fns.c (Fputhash): Document return value.
7825
60002bf5
CY
78262011-06-06 Chong Yidong <cyd@stupidchicken.com>
7827
7828 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7829
0c671da6 78302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7831
b862a52a 7832 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7833
be44ca6c
PE
7834 Check for overflow when converting integer to cons and back.
7835 * charset.c (Fdefine_charset_internal, Fdecode_char):
7836 Use cons_to_unsigned to catch overflow.
7837 (Fencode_char): Use INTEGER_TO_CONS.
7838 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7839 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7840 * data.c (long_to_cons, cons_to_long): Remove.
7841 (cons_to_unsigned, cons_to_signed): New functions.
7842 These signal an error for invalid or out-of-range values.
7843 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7844 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7845 * font.c (Ffont_variation_glyphs):
7846 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7847 * lisp.h: Include <intprops.h>.
7848 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7849 (cons_to_signed, cons_to_unsigned): New decls.
7850 (long_to_cons, cons_to_long): Remove decls.
7851 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7852 (Fprimitive_undo): Use CONS_TO_INTEGER.
7853 * xfns.c (Fx_window_property): Likewise.
7854 * xselect.c: Include <limits.h>.
7855 (x_own_selection, selection_data_to_lisp_data):
7856 Use INTEGER_TO_CONS.
7857 (x_handle_selection_request, x_handle_selection_clear)
7858 (x_get_foreign_selection, Fx_disown_selection_internal)
7859 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7860 (lisp_data_to_selection_data): Use cons_to_unsigned.
7861 (x_fill_property_data): Use cons_to_signed.
7862 Report values out of range.
7863
d1f3d2af
PE
7864 Check for buffer and string overflow more precisely.
7865 * buffer.h (BUF_BYTES_MAX): New macro.
7866 * lisp.h (STRING_BYTES_MAX): New macro.
7867 * alloc.c (Fmake_string):
7868 * character.c (string_escape_byte8):
7869 * coding.c (coding_alloc_by_realloc):
7870 * doprnt.c (doprnt):
7871 * editfns.c (Fformat):
7872 * eval.c (verror):
7873 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7874 since they may not be the same number.
7875 * editfns.c (Finsert_char):
7876 * fileio.c (Finsert_file_contents):
7877 Likewise for BUF_BYTES_MAX.
7878
dd52fcea
PE
7879 * image.c: Use ptrdiff_t, not int, for sizes.
7880 (slurp_file): Switch from int to ptrdiff_t.
7881 All uses changed.
7882 (slurp_file): Check that file size fits in both size_t (for
7883 malloc) and ptrdiff_t (for sanity and safety).
7884
7f9bbdbb
PE
7885 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7886 if b->modtime has its maximal value.
7887
dfe18f82
PE
7888 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7889
84acfcf0
PE
7890 Don't assume time_t can fit into int.
7891 * buffer.h (struct buffer.modtime): Now time_t, not int.
7892 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7893 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7894
ccd9a01a
PE
7895 Minor fixes for signed vs unsigned integers.
7896 * character.h (MAYBE_UNIFY_CHAR):
7897 * charset.c (maybe_unify_char):
7898 * keyboard.c (read_char, reorder_modifiers):
7899 XINT -> XFASTINT, since the integer must be nonnegative.
7900 * ftfont.c (ftfont_spec_pattern):
7901 * keymap.c (access_keymap, silly_event_symbol_error):
7902 XUINT -> XFASTINT, since the integer must be nonnegative.
7903 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7904 since it makes no difference and we prefer signed.
7905 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7906 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7907 nonnegative.
7908
d6d100dd
SM
79092011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7910
7911 * window.h (Fwindow_frame): Declare.
7912
2b6148e4
PE
79132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7914
7915 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7916 (SPARE_MEMORY): Always define.
7917 (LARGE_REQUEST): Remove.
7918 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7919
f230ecc9
MR
79202011-06-06 Martin Rudalics <rudalics@gmx.at>
7921
727e958e
MR
7922 * lisp.h: Move EXFUNS for Fframe_root_window,
7923 Fframe_first_window and Fset_frame_selected_window to window.h.
7924
7925 * window.h: Move EXFUNS for Fframe_root_window,
7926 Fframe_first_window and Fset_frame_selected_window here from
7927 lisp.h.
7928
7929 * frame.c (Fwindow_frame, Fframe_first_window)
7930 (Fframe_root_window, Fframe_selected_window)
7931 (Fset_frame_selected_window): Move to window.c.
7932 (Factive_minibuffer_window): Move to minibuf.c.
7933 (Fother_visible_frames_p): New function.
7934
7935 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7936
f230ecc9
MR
7937 * window.c (decode_window, decode_any_window): Move up in code.
7938 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7939 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7940 (Fwindow_buffer): Move up and rewrite doc-string.
7941 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7942 (Fwindow_prev): New functions.
727e958e
MR
7943 (Fwindow_frame): Move here from frame.c. Accept any window as
7944 argument.
7945 (Fframe_root_window, Fframe_first_window)
7946 (Fframe_selected_window): Move here from frame.c. Accept frame
7947 or arbitrary window as argument. Update doc-strings.
7948 (Fminibuffer_window): Move up in code.
7949 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7950 (Fset_frame_selected_window): Move here from frame.c.
7951 Marginal rewrite.
727e958e
MR
7952 (Fselected_window, select_window, Fselect_window): Move up in
7953 code. Minor doc-string fixes.
f230ecc9 7954
4d09bcf6
PE
79552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7956
7957 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7958 Do not assume that spare memory exists; that assumption is valid
7959 only if SYSTEM_MALLOC.
7960 (LARGE_REQUEST): New macro, so that the issue of large requests
7961 is separated from the issue of spare memory.
7962
810928a2
AS
79632011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7964
172418ad
AS
7965 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7966 format. (Bug#8806)
7967
43f862f7
AS
7968 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7969
810928a2
AS
7970 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7971 before statements.
7972
a059fe24
JD
79732011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7974
7975 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7976
7977 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7978
7979 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7980 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7981
989bf368
JB
79822011-06-05 Juanma Barranquero <lekktu@gmail.com>
7983
7984 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7985
4b80f674
CY
79862011-06-04 Chong Yidong <cyd@stupidchicken.com>
7987
7988 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7989 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7990 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7991 New error handlers.
4b80f674
CY
7992 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7993 Obey Vx_select_enable_clipboard_manager. Catch errors in
7994 x_clipboard_manager_save (Bug#8779).
7995 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7996 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7997
99a33b77 79982011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7999
8000 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8001
99a33b77 80022011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8003
8004 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8005 in the current matrix if keep_current_p is non-zero.
8006
8264569d
EZ
80072011-06-04 Eli Zaretskii <eliz@gnu.org>
8008
8009 * bidi.c (bidi_level_of_next_char): Fix last change.
8010
57f97249
EZ
80112011-06-03 Eli Zaretskii <eliz@gnu.org>
8012
fec2107c 8013 Support bidi reordering of text covered by display properties.
57f97249 8014
fec2107c
EZ
8015 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8016 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8017 (bidi_cache_search, bidi_cache_iterator_state)
8018 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8019 (bidi_level_of_next_char, bidi_move_to_visually_next):
8020 Support character positions inside a run of characters covered by a
fec2107c
EZ
8021 display string.
8022 (bidi_paragraph_init, bidi_resolve_explicit_1)
8023 (bidi_level_of_next_char): Call bidi_fetch_char and
8024 bidi_fetch_char_advance instead of FETCH_CHAR and
8025 FETCH_CHAR_ADVANCE.
8026 (bidi_init_it): Initialize new members.
8027 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8028 definitions.
8029 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8030 instead of using explicit *_CHAR codes.
d6d100dd
SM
8031 (bidi_resolve_explicit, bidi_resolve_weak):
8032 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8033 bidirectional text is supported only in multibyte buffers.
8034 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8035 it to initialize the frame_window_p member of struct bidi_it.
8036 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8037 (bidi_resolve_explicit, bidi_resolve_weak)
8038 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8039 bidi_it->nchars is non-positive.
8040 (bidi_level_of_next_char): Don't try to lookup the cache for the
8041 next/previous character if nothing is cached there yet, or if we
8042 were just reseat()'ed to a new position.
c40e2fb2 8043
0e14fe90
EZ
8044 * xdisp.c (set_cursor_from_row): Set start and stop points
8045 according to the row's direction when priming the loop that looks
8046 for the glyph on which to display cursor.
8047 (single_display_spec_intangible_p): Function deleted.
8048 (display_prop_intangible_p): Reimplement to call
8049 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8050 Accept 3 additional arguments needed by handle_display_spec.
8051 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8052 values: lists, `(when COND...)' forms, etc.
8053 (single_display_spec_string_p): Support property values that are
8054 lists with the argument STRING its top-level element.
8055 (display_prop_string_p): Fix the condition for processing a
8056 property that is a list to be consistent with handle_display_spec.
fec2107c 8057 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8058 last portion of handle_display_prop.
8059 (compute_display_string_pos): Accept additional argument
8060 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8061 value of a `display' property is a "replacing spec".
8062 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8063 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8064 the display property, but just return a value indicating whether
8065 the display property will replace the characters it covers.
8066 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8067 frame_window_p members of struct bidi_it.
d6d100dd
SM
8068 (compute_display_string_pos, compute_display_string_end):
8069 New functions.
fec2107c
EZ
8070 (push_it): Accept second argument POSITION, where pop_it should
8071 jump to continue iteration.
8072 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8073
fec2107c
EZ
8074 * keyboard.c (adjust_point_for_property): Adjust the call to
8075 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8076
8077 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8078 (bidi_init_it): Update prototypes.
8079 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8080 (compute_display_string_pos, compute_display_string_end):
8081 Declare prototypes.
fec2107c
EZ
8082 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8083 EMACS_INT.
fc6f18ce 8084
40087514 80852011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8086
57f53182
PE
8087 Malloc failure behavior now depends on size of allocation.
8088 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8089 * lisp.h: Change signatures accordingly.
8090 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8091 All callers changed. (Bug#8762)
8092
8093 * gnutls.c: Use Emacs's memory allocators.
8094 Without this change, the gnutls library would invoke malloc etc.
8095 directly, which causes problems on non-SYNC_INPUT hosts, and which
8096 runs afoul of improving memory_full behavior. (Bug#8761)
8097 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8098 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8099 xfree instead of the default malloc, realloc, free.
8100 (Fgnutls_boot): No need to check for memory allocation failure,
8101 since xmalloc does that for us.
8102
ac32cd99 8103 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8104 * category.c (hash_get_category_set):
8105 * ccl.c (ccl_driver):
8106 * charset.c (Fdefine_charset_internal):
8107 * charset.h (struct charset.hash_index):
8108 * composite.c (get_composition_id, gstring_lookup_cache)
8109 (composition_gstring_put_cache):
8110 * composite.h (struct composition.hash_index):
8111 * dispextern.h (struct image.hash):
8112 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8113 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8114 (hashfn_equal, hashfn_user_defined, make_hash_table)
8115 (maybe_resize_hash_table, hash_lookup, hash_put)
8116 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8117 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8118 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8119 * image.c (make_image, search_image_cache, lookup_image)
8120 (xpm_put_color_table_h):
8121 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8122 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8123 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8124 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8125 * alloc.c (allocate_vectorlike):
8126 Check for overflow in vector size calculations.
8127 * ccl.c (ccl_driver):
8128 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8129 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8130 need to be updated by these changes.
40087514
PE
8131 * fns.c (make_hash_table, maybe_resize_hash_table):
8132 Check for integer overflow with large hash tables.
0de4bb68
PE
8133 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8134 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8135 (SXHASH_REDUCE): New macro.
8136 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8137 Use it instead of discarding useful hash info with large hash values.
8138 (sxhash_float): New function.
8139 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8140 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8141 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8142 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8143 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8144 Adjust signatures to match updated version of code.
8145 (consing_since_gc): Now EMACS_INT, since a single hash table can
8146 use more than INT_MAX bytes.
8147
698d32e2
DN
81482011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8149
8150 Make it possible to build with GCC-4.6+ -O2 -flto.
8151
8152 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8153
fd6fa53f
SM
81542011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8155
8156 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8157 Call minibuffer-inactive-mode.
8158
864db017
JB
81592011-05-31 Juanma Barranquero <lekktu@gmail.com>
8160
8161 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8162 Update dependencies.
8163
2ad0baf4
DN
81642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8165
8166 * data.c (init_data): Remove code for UTS, this system is not
8167 supported anymore.
8168
4fcc2638
DN
81692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8170
8171 Don't force ./temacs to start in terminal mode.
8172
8173 * frame.c (make_initial_frame): Initialize faces in all cases, not
8174 only when CANNOT_DUMP is defined.
8175 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8176
c56e0fd5
DN
81772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8178
8179 * dispnew.c (add_window_display_history): Use const for the string
8180 pointer. Remove declaration, not needed.
8181
333d54da 81822011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8183
55d4c1b2 8184 Use 'inline', not 'INLINE'.
333d54da 8185 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8186 * alloc.c, fontset.c (INLINE): Remove.
8187 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8188 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8189 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8190 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8191 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8192
738db178
DN
81932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8194
8195 Make it possible to run ./temacs.
8196
8197 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8198 syms_of_callproc does the same thing. Remove test for
8199 "initialized", do it in the caller.
8200 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8201
620c53a6
SM
82022011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8203
8204 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8205 (read_minibuf): Use get_minibuffer.
8206 (syms_of_minibuf): Use DEFSYM.
8207 (Qmetadata): New var.
8208 * data.c (Qbuffer): Don't make it static.
8209 (syms_of_data): Use DEFSYM.
8210
e003a292
PE
82112011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8212
8213 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8214 (CCL_CODE_MIN): New macro.
8215
ed008a6d
PE
82162011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8217
3687c2ef
PE
8218 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8219
ed008a6d
PE
8220 * eval.c (Qdebug): Now static.
8221 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8222 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8223 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8224
d66c4c7c
CY
82252011-05-29 Chong Yidong <cyd@stupidchicken.com>
8226
8227 * image.c: Various fixes to ImageMagick code comments.
8228 (Fimagemagick_types): Doc fix.
8229
5fbc2025
PE
82302011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8231
0196f88a
PE
8232 Minor fixes prompted by GCC 4.6.0 warnings.
8233
8234 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8235
5fbc2025
PE
8236 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8237 (x_clipboard_manager_save_all): Move extern decl to ...
8238 * xterm.h: ... here, so that it can be checked for consistency.
8239
1dd3c2d9
CY
82402011-05-29 Chong Yidong <cyd@stupidchicken.com>
8241
8242 * xselect.c (x_clipboard_manager_save_frame)
8243 (x_clipboard_manager_save_all): New functions.
8244 (Fx_clipboard_manager_save): Lisp function deleted.
8245
8246 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8247 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8248
8249 * xterm.h: Update prototype.
8250
5ba6571d
WX
82512011-05-28 William Xu <william.xwl@gmail.com>
8252
8253 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8254 exiting (Bug#8239).
8255
3eaff834
JM
82562011-05-28 Jim Meyering <meyering@redhat.com>
8257
e1900994 8258 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8259 * fns.c (to_uchar): Define.
8260 (crypto_hash_function): Use it to convert some newly-signed
8261 variables to unsigned, to avoid sign-extension bugs. For example,
8262 without this change, (md5 "truc") would evaluate to
8263 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8264 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8265 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8266
0f6990a7
PE
82672011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8268
8269 Integer overflow fixes.
c8a9ca5a 8270
08686060
PE
8271 * dbusbind.c: Serial number integer overflow fixes.
8272 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8273 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8274 to hold a serial number that is too large for a fixnum.
8275 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8276 Check for serial numbers out of range. Decode any serial number
59568bf0 8277 that was so large that it became a float. (Bug#8722)
08686060 8278
2d1fc3c7
PE
8279 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8280 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8281 Use XFASTINT rather than XUINT when numbers are nonnegative.
8282 (xd_append_arg, Fdbus_method_return_internal):
8283 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8284 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8285 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8286 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8287 (Bug#8722)
2d1fc3c7 8288
c8a9ca5a
PE
8289 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8290
519e1d69
PE
8291 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8292
6df6ae42 8293 ccl: Add integer overflow checks.
30569699
PE
8294 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8295 (IN_INT_RANGE): New macros.
8296 (ccl_driver): Use them to check for integer overflow when
8297 decoding a CCL program. Many of the new checks are whether XINT (x)
8298 fits in int; it doesn't always, on 64-bit hosts. The new version
8299 doesn't catch all possible integer overflows, but it's an
847044ea 8300 improvement. (Bug#8719)
30569699 8301
c11285dc
PE
8302 * alloc.c (make_event_array): Use XINT, not XUINT.
8303 There's no need for unsigned here.
8304
fdccd48e
PE
8305 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8306 This follows up to the 2011-05-06 change that substituted uintptr_t
8307 for EMACS_INT. This case wasn't caught back then.
8308
37910ab2
PE
8309 Rework Fformat to avoid integer overflow issues.
8310 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8311 now (part of C89). Include <verify.h>.
8312 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8313 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8314 (Fformat): Avoid the prepass trying to compute sizes; it was only
8315 approximate and thus did not catch overflow reliably. Instead, walk
8316 through the format just once, formatting and computing sizes as we go,
8317 checking for integer overflow at every step, and allocating a larger
8318 buffer as needed. Keep track separately whether the format is
8319 multibyte. Keep only the most-recently calculated precision, rather
8320 than them all. Record whether each argument has been converted to
8321 string. Use EMACS_INT, not int, for byte and char and arg counts.
8322 Support field widths and precisions larger than INT_MAX. Avoid
8323 sprintf's undefined behavior with conversion specifications such as %#d
8324 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8325 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8326 formatting out-of-range floating point numbers with int
9173deec 8327 formats. (Bug#8668)
37910ab2 8328
2e6578fb
PE
8329 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8330
0ae6bdee
PE
8331 * data.c: Avoid integer truncation in expressions involving floats.
8332 * data.c: Include <intprops.h>.
8333 (arith_driver): When there's an integer overflow in an expression
8334 involving floating point, convert the integers to floating point
8335 so that the resulting value does not suffer from catastrophic
8336 integer truncation. For example, on a 64-bit host (* 4
8337 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8338 Do not rely on undefined behavior after integer overflow.
8339
de883a70
PE
8340 merge count_size_as_multibyte, parse_str_to_multibyte
8341 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8342 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8343 Check for integer overflow.
8344 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8345 since it's now a duplicate of the other. This is more of
8346 a character than a buffer op, so better that it's in character.c.
8347 * fns.c, print.c: Adjust to above changes.
8348
2ff916cb
PE
83492011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8350
8351 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8352
f1b54466
PE
83532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8354
fb1ac845
PE
8355 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8356 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8357 (x_clipboard_manager_save): Now static.
8358 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8359
f1b54466
PE
8360 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8361 (crypto_hash_function): Now static.
8362 Fix pointer signedness problems. Avoid unnecessary initializations.
8363
a9f737ee
CY
83642011-05-27 Chong Yidong <cyd@stupidchicken.com>
8365
8366 * termhooks.h (Vselection_alist): Make it terminal-local.
8367
8368 * terminal.c (create_terminal): Initialize it.
8369
8370 * xselect.c: Support for clipboard managers.
8371 (Vselection_alist): Move to termhooks.h as terminal-local var.
8372 (LOCAL_SELECTION): New macro.
8373 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8374 (symbol_to_x_atom): Remove gratuitous arg.
8375 (x_handle_selection_request, lisp_data_to_selection_data)
8376 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8377 (x_own_selection, x_get_local_selection, x_convert_selection):
8378 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8379 (some_frame_on_display): Delete unused function.
8380 (Fx_own_selection_internal, Fx_get_selection_internal)
8381 (Fx_disown_selection_internal, Fx_selection_owner_p)
8382 (Fx_selection_exists_p): New optional frame arg.
8383 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8384 (x_handle_selection_clear): Don't treat other terminals with the
8385 same keyboard specially. Use the terminal-local Vselection_alist.
8386 (x_clear_frame_selections): Use Frun_hook_with_args.
8387
8388 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8389
8390 * xterm.h: Add support for those atoms.
8391
e067f0c1
CY
83922011-05-26 Chong Yidong <cyd@stupidchicken.com>
8393
8394 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8395 (converted_selections, conversion_fail_tag): New global variables.
8396 (x_selection_request_lisp_error): Free the above.
8397 (x_get_local_selection): Remove unnecessary code.
8398 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8399 of converted selections stored in converted_selections.
8400 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8401 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8402 (x_convert_selection): New function.
8403 (x_handle_selection_event): Simplify.
8404 (x_get_foreign_selection): Don't ignore incoming requests while
8405 waiting for an answer; this will fail when we implement
8406 SAVE_TARGETS, and seems unnecessary anyway.
8407 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8408 (Vx_sent_selection_functions): Doc fix.
8409
0f4aebc0
LL
84102011-05-26 Leo Liu <sdl.web@gmail.com>
8411
8412 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8413
e61124cd
YM
84142011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8415
8416 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8417
8418 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8419 for fringe update if it has periodic bitmap.
ac389d0c 8420 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8421 and fringe_bitmap_periodic_p.
8422
8423 * fringe.c (get_fringe_bitmap_data): New function.
8424 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8425 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8426 row. Mark glyph row for fringe update if periodicity changed.
8427
8428 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8429 for fringe update unless it has periodic bitmap.
8430
f16d9837
KH
84312011-05-25 Kenichi Handa <handa@m17n.org>
8432
8433 * xdisp.c (get_next_display_element): Set correct it->face_id for
8434 a static composition.
8435
e1b90ef6
LL
84362011-05-24 Leo Liu <sdl.web@gmail.com>
8437
8438 * deps.mk (fns.o):
8439 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8440
8441 * fns.c (crypto_hash_function, Fsha1): New function.
8442 (Fmd5): Use crypto_hash_function.
8443 (syms_of_fns): Add Ssha1.
8444
7400048f
PE
84452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8446
8447 * gnutls.c: Remove unused macros.
8448 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8449 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8450 Remove macros that are defined and never used.
8451 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8452
abb71cf4
CY
84532011-05-22 Chong Yidong <cyd@stupidchicken.com>
8454
8455 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8456 (Fx_get_selection_internal): Minor cleanup.
8457 (Fx_own_selection_internal): Rename arguments for consistency with
8458 select.el.
8459
6307db39
PE
84602011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8461
8462 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8463
f3d4e0a4
CY
84642011-05-22 Chong Yidong <cyd@stupidchicken.com>
8465
8466 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8467
4d8ade89
YM
84682011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8469
8470 * dispnew.c (scrolling_window): Don't exclude the case that the
8471 last enabled row in the desired matrix touches the bottom boundary.
8472
32078c8d
GM
84732011-05-21 Glenn Morris <rgm@gnu.org>
8474
8475 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8476 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8477 and add some more files.
32078c8d 8478
7285dc67
EZ
84792011-05-20 Eli Zaretskii <eliz@gnu.org>
8480
8481 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8482 report_file_error introduced by the change from 2011-05-07.
8483
89d1bd22
PE
84842011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8485
8486 * systime.h (Time): Define only if emacs is defined.
8487 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8488 where the include path doesn't have X11/X.h by default. See
8489 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8490
cd394be1 84912011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8492
8493 * composite.c (find_automatic_composition): Fix previous change.
8494
b9704ad9
GM
84952011-05-20 Glenn Morris <rgm@gnu.org>
8496
8497 * lisp.mk: New file, split from Makefile.in.
8498 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8499 (shortlisp): Remove.
8500 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8501
4a720484
GM
85022011-05-19 Glenn Morris <rgm@gnu.org>
8503
8504 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8505 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8506 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8507 (lisp): Set the order to that of loadup.el.
8508 (shortlisp): Make it a copy of $lisp.
8509 (SOME_MACHINE_LISP): Remove.
8510 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8511 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8512
a28d4396
KH
85132011-05-18 Kenichi Handa <handa@m17n.org>
8514
8515 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8516 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8517 (find_automatic_composition): Mostly rewrite for efficiency.
8518
a2b1fa8e
JB
85192011-05-18 Juanma Barranquero <lekktu@gmail.com>
8520
8521 * makefile.w32-in: Update dependencies.
8522
8e1f5610
CS
85232011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8524
8525 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8526 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8527
7025ee00 85282011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8529
cdfa6eab
PE
8530 Fix some integer overflow issues, such as string length overflow.
8531
06d6db33
PE
8532 * insdel.c (count_size_as_multibyte): Check for string overflow.
8533
2b4560a8
PE
8534 * character.c (lisp_string_width): Check for string overflow.
8535 Use EMACS_INT, not int, for string indexes and lengths; in
8536 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8537 the resulting string length overflows an EMACS_INT; instead,
8538 report a string overflow if no precision given. When checking for
8539 precision exhaustion, use a check that cannot possibly have
8540 integer overflow. (Bug#8675)
8541 * character.h (lisp_string_width): Adjust to new signature.
8542
cb93f9be
PE
8543 * alloc.c (string_overflow): New function.
8544 (Fmake_string): Use it. This doesn't change behavior, but saves
8545 a few bytes and will simplify future changes.
8546 * character.c (string_escape_byte8): Likewise.
8547 * lisp.h (string_overflow): New decl.
8548
1a1f3366
PE
8549 Fixups, following up to the user-interface timestamp change.
8550 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8551 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8552 * msdos.c (mouse_get_pos): Likewise.
8553 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8554 * w32gui.h (Time): Define by including "systime.h" rather than by
8555 declaring it ourselves. (Bug#8664)
8556
d4e3e4d3
PE
8557 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8558 * image.c (clear_image_cache): Likewise.
8559
f6a24d19
PE
8560 * term.c (term_mouse_position): Don't assume time_t wraparound.
8561
08dc5ae6
PE
8562 Be more systematic about user-interface timestamps.
8563 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8564 and sometimes 'EMACS_UINT', to represent these timestamps.
8565 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8566 This makes the code easier to follow, and makes it easier to catch
8567 integer overflow bugs such as Bug#8664.
8568 * frame.c (Fmouse_position, Fmouse_pixel_position):
8569 Use Time, not unsigned long, for user-interface timestamps.
8570 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8571 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8572 * keyboard.h (last_event_timestamp): Likewise.
8573 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8574 * menu.h (xmenu_show): Likewise.
8575 * term.c (term_mouse_position): Likewise.
8576 * termhooks.h (struct input_event.timestamp): Likewise.
8577 (struct terminal.mouse_position_hook): Likewise.
8578 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8579 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8580 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8581 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8582 what it was before.
8583 * menu.h, termhooks.h: Include "systime.h", for Time.
8584
8e55734a
PE
8585 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8586 Don't assume that the difference between two unsigned long values
8587 can fit into an integer. At this point, we know button_down_time
8588 <= event->timestamp, so the difference must be nonnegative, so
8589 there's no need to cast the result if double-click-time is
8590 nonnegative, as it should be; check that it's nonnegative, just in
8591 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8592 apart (about 25 days). (Bug#8664)
8e55734a 8593
841f1b75 8594 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8595 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8596
3e26f69c
PE
8597 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8598 that always fit in int. Use a sentinel instead of a counter, to
8599 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8600 * frame.h (struct frame): Use int for menu_bar_items_used
8601 instead of EMACS_INT, since it always fits in int.
3e26f69c 8602
5cc152c0
PE
8603 * menu.c (grow_menu_items): Check for int overflow.
8604
d89eb65e
PE
8605 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8606
5235bd3e
PE
8607 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8608 Before, the code was not consistent. These values cannot exceed
8609 2**31 - 1 so there's no need to make them unsigned.
8610 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8611 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8612 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8613 as modifiers.
8614 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8615
bc827e23
PE
8616 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8617 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8618 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8619 presumably because the widths might not match.
8620
78eb494e
PE
8621 * window.c (size_window): Avoid needless test at loop start.
8622
04f2d78b
CB
86232011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8624
8625 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8626
d2fc7e3d 86272011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8628
8629 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8630
d2fc7e3d 86312011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8632
8633 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8634 `width' to `bar_area_x' and `bar_area_width', respectively.
8635 (x_scroll_run): Take account of fringe background extension.
8636
04f2d78b
CB
8637 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8638 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8639 `bar_area_width', respectively.
8640 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8641 background extension.
8642
79b70037
GM
86432011-05-10 Jim Meyering <meyering@redhat.com>
8644
8645 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8646
2f142cc5
JB
86472011-05-10 Juanma Barranquero <lekktu@gmail.com>
8648
8649 * image.c (Finit_image_library): Return t for built-in image types,
8650 like pbm and xbm. (Bug#8640)
8651
57679c86
AS
86522011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8653
8654 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8655
888c9e86
EZ
86562011-05-07 Eli Zaretskii <eliz@gnu.org>
8657
b0512a1d
EZ
8658 * w32console.c (Fset_screen_color): Doc fix.
8659 (Fget_screen_color): New function.
8660 (syms_of_ntterm): Defsubr it.
8661
7285dc67
EZ
8662 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8663 unlink the temporary file if Fcall_process didn't create it in the
8664 first place.
8665 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8666 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8667 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8668 cue to call_process_cleanup not to close that handle.
8669
4d3fcc8e
BK
86702011-05-07 Ben Key <bkey76@gmail.com>
8671
8672 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8673 one of two shell specific rules, either bootstrap-temacs-CMD or
8674 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8675 to the previous implementation of the bootstrap-temacs rule.
8676 The bootstrap-temacs-CMD rule is similar to the previous
8677 implementation of the bootstrap-temacs rule except that it
8678 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8679 variable.
8680
8681 These changes, along with some changes to nt/configure.bat,
8682 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8683 earlier fix to add support for --cflags and --ldflags options
8684 that include quotes so that it works whether make uses cmd or
8685 sh as the shell.
8686
b4289b64
MA
86872011-05-06 Michael Albinus <michael.albinus@gmx.de>
8688
8689 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8690 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8691 is a constant.
8692 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8693 a string. Handle both cases.
8694 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8695 (Fdbus_register_method): Use Qinvalid_function.
8696
af4c0e28
JB
86972011-05-06 Juanma Barranquero <lekktu@gmail.com>
8698
8699 * makefile.w32-in: Update dependencies.
8700 (LISP_H): Add inttypes.h and stdin.h.
8701 (PROCESS_H): Add unistd.h.
8702
c51453d9
EZ
87032011-05-06 Eli Zaretskii <eliz@gnu.org>
8704
8705 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8706 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8707
8ff0ac3c 87082011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8709
4c4b566b
PE
8710 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8711
aab2b9b5
PE
8712 * term.c (vfatal): Remove stray call to va_end.
8713 It's not needed and the C Standard doesn't allow it here anyway.
8714
c378da0b
PE
8715 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8716 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8717
288b08c7
PE
8718 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8719 bytes.
8720
e3601888
PE
8721 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8722
db6c0e74
PE
8723 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8724
dd5963ea
PE
8725 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8726
88c9450f
PE
8727 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8728
2f9442b8
PE
8729 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8730
c032b5f8
PE
8731 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8732 * charset.c (Fdefine_charset_internal): Don't initialize
8733 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8734 32-bit int (Bug#8600).
a108c10b
PE
8735
8736 * lread.c (read_integer): Be more consistent with string-to-number.
8737 Use string_to_number to do the actual conversion; this avoids
8738 rounding errors and fixes some other screwups. Without this fix,
8739 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8740 (digit_to_number): Move earlier, for benefit of read_integer.
8741 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8742 not a digit in any supported base. (Bug#8602)
a108c10b 8743
ad5f9eea
PE
8744 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8745
aec1708a
PE
8746 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8747 to match comment at start of function. This also removes a
8748 GCC warning about overflow in a 32+64-bit port.
8749
47be4ab5
PE
8750 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8751
371cac43
PE
8752 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8753 Reported by Stefan Monnier in
8754 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8755 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8756 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8757
d01a7826
PE
8758 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8759 (EMACS_UINTPTR): Likewise, with uintptr_t.
8760
7fd47d5c
PE
8761 * lisp.h: Prefer 64-bit EMACS_INT if available.
8762 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8763 on 32-bit hosts that have 64-bit int, so that they can access
8764 large files.
122b0c86
PE
8765 However, temporarily disable this change unless the temporary
8766 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8767
8727937b
PE
8768 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8769
8ac068ac
PE
8770 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8771 This removes an assumption that EMACS_INT and long are the same
8772 width as pointers. The assumption is true for Emacs porting targets
8773 now, but we want to make other targets possible.
8774 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8775 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8776 In the rest of the code, change types of integers that hold casted
8777 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8778 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8779 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8780 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8781 No need to cast type when ORing.
8782 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8783 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8784 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8785 assume EMACS_INT is the same width as char *.
8786 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8787 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8788 Remove no-longer-needed casts.
8789 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8790 (xg_tool_bar_help_callback, xg_make_tool_item):
8791 Use EMACS_INTPTR to hold an integer
8792 that will be cast to void *; this can avoid a GCC warning
8793 if EMACS_INT is not the same width as void *.
8794 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8795 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8796 (current_message_1, set_message_1):
8797 Use a local to convert to proper width without a cast.
8798 * xmenu.c (dialog_selection_callback): Likewise.
8799
ede49d71
PE
8800 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8801 Also, don't assume VALBITS / RAND_BITS is less than 5,
8802 and don't rely on undefined behavior when shifting a 1 left into
8803 the sign bit.
8804 * lisp.h (get_random): Change signature to match.
8805
2f30ecd0
PE
8806 * lread.c (hash_string): Use size_t, not int, for hash computation.
8807 Normally we prefer signed values; but hashing is special, because
8808 it's better to use unsigned division on hash table sizes so that
8809 the remainder is nonnegative. Also, size_t is the natural width
8810 for hashing into memory. The previous code used 'int', which doesn't
8811 retain enough info to hash well into very large tables.
8812 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8813
2a866e7b
PE
8814 * dbusbind.c: Don't possibly lose pointer info when converting.
8815 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8816 Use XPNTR rather than XHASH, so that the high-order bits of
8817 the pointer aren't lost when converting through void *.
8818
51639eac
PE
8819 * eval.c (Fautoload): Don't double-shift a pointer.
8820
92394119
PE
8821 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8822
dbdb9a7c
JB
88232011-05-06 Juanma Barranquero <lekktu@gmail.com>
8824
8825 * gnutls.c (DEF_GNUTLS_FN):
8826 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8827
db7a0b4f
AS
88282011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8829
8830 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8831 marker. (Bug#8610)
8832
cd394be1 88332011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8834
8835 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8836 New version that can reserve upto 2GB of heap space.
8837
f7ff1b0f 88382011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8839
8840 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8841
639c109b
TZ
88422011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8843
8844 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8845 `gnutls_certificate_set_x509_key_file'.
8846
d2127135
JB
88472011-05-05 Juanma Barranquero <lekktu@gmail.com>
8848
8849 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8850 Update dependencies.
8851
e968f4f3
JB
88522011-05-04 Juanma Barranquero <lekktu@gmail.com>
8853
8854 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8855 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8856 Remove unused parameter `fildes'.
8857 * process.c (read_process_output, send_process): Don't pass it.
8858
84d358f0
JB
88592011-05-04 Juanma Barranquero <lekktu@gmail.com>
8860
8861 Fix previous change: the library cache is defined in w32.c.
8862 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8863 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8864
0898ca10
JB
88652011-05-04 Juanma Barranquero <lekktu@gmail.com>
8866
8867 Implement dynamic loading of GnuTLS on Windows.
8868
8869 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8870 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8871 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8872 Declare.
8873
8874 * gnutls.c (Qgnutls_dll): Define.
8875 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8876 (gnutls_*): Declare function pointers.
8877 (init_gnutls_functions): New function to initialize function pointers.
8878 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8879 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8880 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8881 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8882 (emacs_gnutls_write, emacs_gnutls_read)
8883 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8884 (Fgnutls_available_p): New function.
8885 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8886 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8887 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8888
8889 * image.c: Include w32.h.
8890 (Vimage_type_cache): Delete.
8891 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8892 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8893 (w32_delayed_load): Move to w32.c.
8894
8895 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8896
8897 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8898 (w32_delayed_load): Move from image.c. When loading a library, record
8899 its filename in the :loaded-from property of the library id.
8900 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8901 Initialize and staticpro them.
8902 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8903
8904 * process.c: Include lisp.h before w32.h, not after.
8905 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8906 instead of gnutls_record_check_pending.
8907
8908 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8909
ff4de4aa
TZ
89102011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8911
8912 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8913 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8914 as passed in.
8915
abe95abb
JD
89162011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8917
8918 * xterm.c (x_set_frame_alpha): Do not set property on anything
8919 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8920
e16e55d4
JB
89212011-05-02 Juanma Barranquero <lekktu@gmail.com>
8922
8923 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8924
bafcf6a5
JB
89252011-05-02 Juanma Barranquero <lekktu@gmail.com>
8926
8927 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8928 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8929 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8930 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8931 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8932 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8933 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8934 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8935 (Qgnutls_bootprop_callbacks_verify): Make static.
8936
e7a6747f
AS
89372011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8938
19ed11ba
AS
8939 * callproc.c: Indentation fixup.
8940
e7a6747f 8941 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8942 (wait_for_termination, interruptible_wait_for_termination):
8943 Move after wait_for_termination_1.
e7a6747f 8944
1ef14cb4
LMI
89452011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8946
8947 * sysdep.c (interruptible_wait_for_termination): New function
8948 which is like wait_for_termination, but allows keyboard
8949 interruptions.
8950
8951 * callproc.c (Fcall_process): Add (:file "file") as an option for
8952 the STDOUT buffer.
8953 (Fcall_process_region): Ditto.
8954
330d880c
EZ
89552011-04-30 Eli Zaretskii <eliz@gnu.org>
8956
8db90b73
EZ
8957 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8958 rather than `XVECTOR (FOO)->size'.
8959
330d880c
EZ
8960 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8961 inttypes.h, as a gnulib replacement is used if it not available in
8962 system headers.
8963
15cbd324
EZ
89642011-04-21 Eli Zaretskii <eliz@gnu.org>
8965
8966 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8967 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8968 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8969
8970 * coding.c (coding_alloc_by_realloc): Error out if destination
8971 will grow beyond MOST_POSITIVE_FIXNUM.
8972 (decode_coding_emacs_mule): Abort if there isn't enough place in
8973 charbuf for the composition carryover bytes. Reserve an extra
8974 space for up to 2 characters produced in a loop.
8975 (decode_coding_iso_2022): Abort if there isn't enough place in
8976 charbuf for the composition carryover bytes.
8977
89782011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8979
ae940cca
EZ
8980 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8981 aborting when %lld or %lll format is passed.
8982 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8983 %llo or %llx format is passed. (Bug#8545)
8984
03ab8921
EZ
8985 * window.c (window_scroll_line_based): Use a marker instead of
8986 simple variables to record original value of point. (Bug#7952)
8987
afda1437
EZ
8988 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8989 produced by %s or %c overflows available buffer space. (Bug#8545)
8990
f76dee0c
PE
89912011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8992
8993 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8994 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8995
fdc5744d
JB
89962011-04-28 Juanma Barranquero <lekktu@gmail.com>
8997
8998 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8999
638f053a
JB
90002011-04-28 Juanma Barranquero <lekktu@gmail.com>
9001
9002 * keyboard.c (Qdelayed_warnings_hook): Define.
9003 (command_loop_1): Run `delayed-warnings-hook'
9004 if Vdelayed_warnings_list is non-nil.
9005 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9006 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9007
d178f871
EZ
90082011-04-28 Eli Zaretskii <eliz@gnu.org>
9009
9010 * doprnt.c (doprnt): Don't return value smaller than the buffer
9011 size if the message was truncated. (Bug#8545).
9012
b124fd93
JB
90132011-04-28 Juanma Barranquero <lekktu@gmail.com>
9014
9015 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9016 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9017
e810457d
PE
90182011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9019
9020 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9021
ea51cceb
JB
90222011-04-27 Juanma Barranquero <lekktu@gmail.com>
9023
9024 * makefile.w32-in: Update dependencies.
9025
94dcfacf
EZ
90262011-04-27 Eli Zaretskii <eliz@gnu.org>
9027
9028 Improve `doprnt' and its usage. (Bug#8545)
9029 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9030 `format_end'. Remove support for %l as a conversion specifier.
9031 Don't use xrealloc. Improve diagnostics when the %l size modifier
9032 is used. Update the commentary.
9033
9034 * eval.c (verror): Simplify calculation of size_t.
9035
9036 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9037 messages.
9038
f61f41d7
PE
90392011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9040
9041 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9042 change.
9043
96fb4434
PE
90442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9045
9046 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9047 This makes this file independent of the recent pseudovector change.
9048
671875da 90492011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9050
69e9b5a3
PE
9051 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9052
b5f869a7 9053 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9054 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9055 Remove unused local.
c8926152 9056 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9057
841a1577 9058 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9059 GCC 4.6.0 optimizes based on type-based alias analysis.
9060 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9061 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9062 != &v->size, and therefore "v->size = 1; b->size = 2; return
9063 v->size;" must therefore return 1. This assumption is incorrect
9064 for Emacs, since it type-puns struct Lisp_Vector * with many other
9065 types. To fix this problem, this patch adds a new type struct
f904488f 9066 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9067 and pseudovectors, and helps optimizing compilers not get fooled
9068 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9069 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9070 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9071 the size member.
eab3844f
PE
9072 (XSETPVECTYPE): Rewrite in terms of new macro.
9073 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9074 This is a bit clearer, and further avoids the possibility of
9075 undesirable aliasing.
9076 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9077 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9078 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9079 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9080 (ASIZE): Now uses header.size rather than size.
9081 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9082 to avoid the hassle of writing XVECTOR (foo)->header.size.
9083 (struct vectorlike_header): New type.
eab3844f
PE
9084 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9085 object, to help avoid aliasing.
9086 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9087 (SUBRP): Likewise, since Lisp_Subr is a special case.
9088 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9089 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9090 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9091 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9092 changed to be "header.size" and "header.next".
9093 * buffer.h (struct buffer): Likewise.
9094 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9095 * frame.h (struct frame): Likewise.
9096 * process.h (struct Lisp_Process): Likewise.
9097 * termhooks.h (struct terminal): Likewise.
9098 * window.c (struct save_window_data, struct saved_window): Likewise.
9099 * window.h (struct window): Likewise.
9100 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9101 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9102 * buffer.c (init_buffer_once): Likewise.
9103 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9104 special case.
9105 * process.c (Fformat_network_address): Use local var for size,
9106 for brevity.
9107
0df1eac5
PE
9108 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9109
847ab9d1 9110 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9111 * data.c (atof): Remove decl; no longer used or needed.
9112 (digit_to_number): Move to lread.c.
9113 (Fstring_to_number): Use new string_to_number function, to be
9114 consistent with how the Lisp reader treats infinities and NaNs.
9115 Do not assume that floating-point numbers represent EMACS_INT
9116 without losing information; this is not true on most 64-bit hosts.
9117 Avoid double-rounding errors, by insisting on integers when
9118 parsing non-base-10 numbers, as the documentation specifies.
9119 * lisp.h (string_to_number): New decl, replacing ...
9120 (isfloat_string): Remove.
bc0a5c13 9121 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9122 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9123 appears to have been a coding error. Similarly, do not accept
9124 strings like +-1e0 as floating point numbers. Do not report
9125 overflow for integer overflows unless the base is not 10 which
9126 means we have no simple and reliable way to continue.
9127 Break out the floating-point parsing into a new
9128 function string_to_number, so that Fstring_to_number parses
9129 floating point numbers consistently with the Lisp reader.
04f2d78b 9130 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9131 (E_CHAR, EXP_INT): Remove, replacing with ...
9132 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9133 (string_to_number): New function, replacing isfloat_string.
9134 This function checks for valid syntax and produces the resulting
9135 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9136 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9137 so that overflow for non-base-10 numbers is reported only when
9138 there's no portable and simple way to convert to floating point.
452f4150 9139
67769ffc
PE
9140 * textprop.c (set_text_properties_1): Rewrite for clarity,
9141 and to avoid GCC warning about integer overflow.
9142
c20db43f
PE
9143 * intervals.h (struct interval): Use EMACS_INT for members
9144 where EMACS_UINT might cause problems. See
9145 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9146 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9147 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9148 All uses changed.
37aa2f85
PE
9149 (offset_intervals): Tell GCC not to worry about length overflow
9150 when negating a negative length.
c20db43f 9151
2538aa2f
PE
9152 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9153 (overrun_check_free): Likewise.
9154
f2d3008d
PE
9155 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9156 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9157 word size.
9158
ec8df744
PE
9159 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9160 (gnutls_make_error): Rename local to avoid shadowing.
9161 (gnutls_emacs_global_deinit): ifdef out; not used.
9162 (Fgnutls_boot): Use const for pointer to readonly storage.
9163 Comment out unused local. Fix pointer signedness problems.
9164
640ee02d
PE
9165 * lread.c (openp): Don't stuff size_t into an 'int'.
9166 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9167 about possible signed overflow.
9168
6048fb2a
PE
9169 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9170 (GDK_KEY_g): Don't define if already defined.
9171 (xg_prepare_tooltip): Avoid pointer signedness problem.
9172 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9173
fa3c87e1
PE
9174 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9175 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9176
2172544b
PE
9177 * xfns.c (Fx_window_property): Simplify a bit,
9178 to make a bit faster and to avoid GCC 4.6.0 warning.
9179 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9180
9b821a21
PE
9181 * fns.c (internal_equal): Don't assume size_t fits in int.
9182
3c616cfa
PE
9183 * alloc.c (compact_small_strings): Tighten assertion a little.
9184
c2982e87
PE
9185 Replace pEd with more-general pI, and fix some printf arg casts.
9186 * lisp.h (pI): New macro, generalizing old pEd macro to other
9187 conversion specifiers. For example, use "...%"pI"d..." rather
9188 than "...%"pEd"...".
9189 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9190 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9191 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9192 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9193 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9194 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9195 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9196 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9197 64-bit hosts.
9198 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9199 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9200 * print.c (safe_debug_print, print_object): Likewise.
9201 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9202 to int.
6f04d126
PE
9203 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9204 avoiding the 0 flag, which is not portable.
c2982e87
PE
9205 * process.c (Fmake_network_process): Use pI to avoid cast.
9206 * region-cache.c (pp_cache): Likewise.
9207 * xdisp.c (decode_mode_spec): Likewise.
9208 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9209 behavior on 64-bit hosts with printf arg.
6f04d126 9210 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9211 (x_stop_queuing_selection_requests): Likewise.
9212 (x_get_window_property): Don't truncate byte count to an 'int'
9213 when tracing.
0b432f21 9214
5e073ec7
PE
9215 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9216 here, since it parses constructs like leading '-' and spaces,
9217 which are not wanted; and it overflows with large numbers.
9218 Instead, simply match F[0-9]+, which is what is wanted anyway.
9219
36372bf9
PE
9220 * alloc.c: Remove unportable assumptions about struct layout.
9221 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9222 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9223 (allocate_vectorlike, make_pure_vector): Use the new macros,
9224 plus offsetof, to remove unportable assumptions about struct layout.
9225 These assumptions hold on all porting targets that I know of, but
9226 they are not guaranteed, they're easy to remove, and removing them
9227 makes further changes easier.
9228
0b432f21
PE
9229 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9230 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9231 (string_overrun_cookie): Now const. Use initializers that
9232 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9233 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9234 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9235 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9236 multiple of sizeof (EMACS_INT); it need not be, if
9237 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9238 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9239
895009e1
JB
92402011-04-26 Juanma Barranquero <lekktu@gmail.com>
9241
9242 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9243
6a7a1b0b
TZ
92442011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9245
9246 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9247 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9248 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9249
841a1577 92502011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9251
9252 * lisp.h (Qdebug): List symbol.
895009e1 9253 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9254 * keyboard.c (debug-on-event): New variable.
9255 (handle_user_signal): Break into debugger when debug-on-event
9256 matches the current signal symbol.
9257
f2d3ba6f
DN
92582011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9259
9260 * alloc.c (check_sblock, check_string_bytes)
9261 (check_string_free_list): Convert to standard C.
9262
42ce4c63
TZ
92632011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9264
9265 * w32.c (emacs_gnutls_push): Fix typo.
9266
825cd63c
EZ
92672011-04-25 Eli Zaretskii <eliz@gnu.org>
9268
fb11d64d
EZ
9269 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9270 "cast to pointer from integer of different size".
9271
825cd63c
EZ
9272 Improve doprnt and its use in verror. (Bug#8545)
9273 * doprnt.c (doprnt): Document the set of format control sequences
9274 supported by the function. Use SAFE_ALLOCA instead of always
9275 using `alloca'.
9276
9277 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9278 is one byte too soon. Don't use xrealloc; instead xfree and
9279 xmalloc anew.
9280
e061a11b
TZ
92812011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9282
9283 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9284 callbacks stage.
9285
9286 * gnutls.c: Renamed global_initialized to
9287 gnutls_global_initialized. Added internals for the
9288 :verify-hostname-error, :verify-error, and :verify-flags
9289 parameters of `gnutls-boot' and documented those parameters in the
9290 docstring. Start callback support.
9173deec
JB
9291 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9292 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9293 on error. Return error code.
e061a11b
TZ
9294 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9295 (emacs_gnutls_read): Likewise.
9296 (Fgnutls_boot): Return handshake error code.
9297 (emacs_gnutls_handle_error): New function.
9298 (wsaerror_to_errno): Likewise.
9299
9300 * w32.h (emacs_gnutls_pull): Add prototype.
9301 (emacs_gnutls_push): Likewise.
9302
9303 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9304 (emacs_gnutls_push): Likewise.
9305
93062011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9307
9308 * process.c (wait_reading_process_output): Check if GnuTLS
9309 buffered some data internally if no FDs are set for TLS
9310 connections.
9311
9312 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9313 (LIBS): Link to USER_LIBS.
9314 ($(BLD)/gnutls.$(0)): New target.
9315
fa6996bc
EZ
93162011-04-24 Eli Zaretskii <eliz@gnu.org>
9317
eb35682e
EZ
9318 * xdisp.c (handle_single_display_spec): Rename the
9319 display_replaced_before_p argument into display_replaced_p, to
9320 make it consistent with the commentary. Fix typos in the
9321 commentary.
9322
e2ad650c
EZ
9323 * textprop.c (syms_of_textprop): Remove dead code.
9324 (copy_text_properties): Delete obsolete commentary about an
9325 interface that was deleted long ago. Fix typos in the description
9326 of arguments.
9327
1b2de274
EZ
9328 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9329 to changes in oldXMenu/XMenu.h from 2011-04-16.
9330 <menu_help_message, prev_menu_help_message>: Constify.
9331 (IT_menu_make_room): menu->help_text is now `const char **';
9332 adjust.
9333
9334 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9335 to changes in oldXMenu/XMenu.h from 2011-04-16.
9336 (struct XMenu): Declare `help_text' `const char **'.
9337
9338 * xfaces.c <Qunspecified>: Make extern again.
9339
9340 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9341 required by POSIX.
1b2de274 9342
762b15be
EZ
9343 * doc.c (get_doc_string): Improve the format passed to `error'.
9344
9345 * doprnt.c (doprnt): Improve commentary.
9346
9347 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9348
9349 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9350 them with etags.
9351
f1052e5d
EZ
9352 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9353 changes in globals.h immediately force recompilation.
762b15be
EZ
9354 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9355 $(CURDIR)/s/ms-w32.h.
9356 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9357
fa6996bc
EZ
9358 * character.c (Fchar_direction): Function deleted.
9359 (syms_of_character): Don't defsubr it.
9360 <char-direction-table>: Deleted.
9361
e6c3da20
EZ
93622011-04-23 Eli Zaretskii <eliz@gnu.org>
9363
9364 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9365 * doprnt.c: Include limits.h.
9366 (SIZE_MAX): New macro.
04f2d78b
CB
9367 (doprnt): Return a size_t value. 2nd arg is now size_t.
9368 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9369 Improve overflow protection. Support `l' modifier for integer
9370 conversions. Support %l conversion. Don't assume an EMACS_INT
9371 argument for integer conversions and for %c.
9372
9373 * lisp.h (doprnt): Restore prototype.
9374
9375 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9376 $(SRC)/character.h.
9377
9378 * Makefile.in (base_obj): Add back doprnt.o.
9379
9380 * deps.mk (doprnt.o): Add back prerequisites.
9381 (callint.o): Depend on character.h.
9382
9383 * eval.c (internal_lisp_condition_case): Include the handler
9384 representation in the error message.
9385 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9386 when breaking from the loop.
9387
9388 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9389
9390 * callint.c (Fcall_interactively): When displaying error message
9391 about invalid control letter, pass the character's codepoint, not
9392 a pointer to its multibyte form. Improve display of the character
9393 in octal and display also its hex code.
9394
9395 * character.c (char_string): Use %x to display the (unsigned)
9396 codepoint of an invalid character, to avoid displaying a bogus
9397 negative value.
9398
9399 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9400 `error', not SYMBOL_NAME itself.
9401
9402 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9403 character arguments to `error'.
9404
9405 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9406 to `error' in error message about FINAL_CHAR argument. Make sure
9407 FINAL_CHAR is a character, and use %c when it is passed as
9408 argument to `error'.
9409
4ffd0d6b 94102011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9411
9412 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9413
9414 * w32.c: Include <time.h>.
9415 (sys_localtime): New function.
9416
4ffd0d6b 94172011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9418
9419 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9420
4ffd0d6b 9421 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9422
4ffd0d6b 94232011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9424
4ffd0d6b
GM
9425 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9426 zombies (Bug#8467).
aac0c6e3 9427
04c56954
EZ
94282011-04-19 Eli Zaretskii <eliz@gnu.org>
9429
9430 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9431 gl_state.e_property when gl_state.object is Qt.
9432
9433 * insdel.c (make_gap_larger): Remove limitation of buffer size
9434 to <= INT_MAX.
9435
16a43933
CY
94362011-04-18 Chong Yidong <cyd@stupidchicken.com>
9437
9438 * xdisp.c (lookup_glyphless_char_display)
9439 (produce_glyphless_glyph): Handle cons cell entry in
9440 glyphless-char-display.
9441 (Vglyphless_char_display): Document it.
9442
9443 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9444 glyphless-char-display.
9445
4581706e
CY
94462011-04-17 Chong Yidong <cyd@stupidchicken.com>
9447
9448 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9449
9450 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9451
9452 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9453 definition for no-X builds.
9454
4887c6e2 94552011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9456
fd35b6f9
PE
9457 Static checks with GCC 4.6.0 and non-default toolkits.
9458
5c1ccb01
PE
9459 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9460
006c5daa
PE
9461 * process.c (keyboard_bit_set): Define only if SIGIO.
9462 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9463 (send_process): Repair possible setjmp clobbering.
9464
efc736d3
PE
9465 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9466
4e2fe2e6
PE
9467 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9468
f97334a2
PE
9469 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9470
4e75f29d
PE
9471 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9472 Define only if needed.
9473
90efadd1
PE
9474 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9475 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9476 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9477
3c647824
PE
9478 * dispextern.h (struct redisplay_interface): Rename param
9479 to avoid shadowing.
e264f262 9480 * termhooks.h (struct terminal): Likewise.
761383f4 9481 * xterm.c (xembed_send_message): Likewise.
3c647824 9482
b58c5c4a
PE
9483 * insdel.c (make_gap_smaller): Define only if
9484 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9485
cad59032
PE
9486 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9487 it.
9488
c339dc2e
PE
9489 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9490 so that we aren't warned about unused symbols.
9491
91a3e27b
PE
9492 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9493
399c71d3 9494 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9495
8ffc96f5
PE
9496 * xfns.c (x_real_positions): Mark locals as initialized.
9497
eef9bc79
PE
9498 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9499
098db9dd
PE
9500 * xterm.c: Fix problems found by static analysis with other toolkits.
9501 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9502 (x_dispatch_event): Declare static if USE_GTK, and
9503 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9504 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9505 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9506 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9507 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9508
eb18f6cc
PE
9509 * xmenu.c (menu_help_callback): Pointer type fixes.
9510 Use const pointers when pointing at readonly data. Avoid pointer
9511 signedness clashes.
9512 (FALSE): Remove unused macro.
9513 (update_frame_menubar): Remove unused decl.
9514
1fe72bf8
PE
9515 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9516
60d9e1db
PE
9517 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9518 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9519 (single_menu_item): Rename local to avoid shadowing.
9520
39261c26
PE
9521 * keyboard.c (make_lispy_event): Remove unused local var.
9522
018c5e19
PE
9523 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9524 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9525
63d2b86e
PE
9526 * bitmaps: Change bitmaps from unsigned char back to the X11
9527 compatible char. Avoid the old compiler warnings about
9528 out-of-range initializers by using, for example, '\xab' rather
9529 than 0xab.
9530
aefd87e1
PE
9531 * xgselect.c (xgselect_initialize): Check vs interface
9532 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9533
bf501fb9
PE
9534 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9535
e9829fdf
PE
9536 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9537 to read-only memory.
9538
1086c095
PE
9539 * fns.c (vector): Remove; this old hack is no longer needed.
9540
2baccd04 9541 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9542 Remove unused var.
dde42981 9543 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9544
72391843 9545 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9546
436c16df 9547 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9548 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9549 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9550
92bb796d 9551 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9552 (x_term_init): Remove local to avoid shadowing.
92bb796d 9553
764430a3 9554 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9555
9556 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9557 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9558
d1dfb56c
EZ
95592011-04-16 Eli Zaretskii <eliz@gnu.org>
9560
c4354cb4
EZ
9561 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9562
d1dfb56c
EZ
9563 Fix regex.c, syntax.c and friends for buffers > 2GB.
9564 * syntax.h (struct gl_state_s): Declare character position members
9565 EMACS_INT.
9566
9567 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9568
04f2d78b
CB
9569 * textprop.c (verify_interval_modification, interval_of):
9570 Declare arguments EMACS_INT.
d1dfb56c
EZ
9571
9572 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9573 EMACS_INT.
9574
9575 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9576
9577 * indent.c (Fvertical_motion): Local variable it_start is now
9578 EMACS_INT.
9579
9580 * regex.c (re_match, re_match_2, re_match_2_internal)
9581 (bcmp_translate, regcomp, regexec, print_double_string)
9582 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9583 (re_compile_pattern, re_exec): Declare arguments and local
9584 variables `size_t' and `ssize_t' and return values `regoff_t', as
9585 appropriate.
9586 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9587 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9588 <compile_stack_type>: `size' and `avail' are now `size_t'.
9589
9590 * regex.h <regoff_t>: Use ssize_t, not int.
9591 (re_search, re_search_2, re_match, re_match_2): Arguments that
9592 specify buffer/string position and length are now ssize_t and
9593 size_t. Return type is regoff_t.
9594
613052cd
BK
95952011-04-16 Ben Key <bkey76@gmail.com>
9596
9597 * nsfont.m: Fixed bugs in ns_get_family and
9598 ns_descriptor_to_entity that were caused by using free to
9599 deallocate memory blocks that were allocated by xmalloc (via
9600 xstrdup). This caused Emacs to crash when compiled with
9601 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9602 --enable-checking=xmallocoverrun). xfree is now used to
9603 deallocate these memory blocks.
9604
4170f62f 96052011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9606
71b41406
PE
9607 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9608
9587a89d
PE
9609 emacs_write: Accept and return EMACS_INT for sizes.
9610 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9611 et seq.
9612 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9613 Accept and return EMACS_INT.
9614 (emacs_gnutls_write): Return the number of bytes written on
9615 partial writes.
9616 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9617 (emacs_read, emacs_write): Remove check for negative size, as the
9618 Emacs source code has been audited now.
9587a89d
PE
9619 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9620 (emacs_read, emacs_write): Use it.
273a5f82
PE
9621 * process.c (send_process): Adjust to the new signatures of
9622 emacs_write and emacs_gnutls_write. Do not attempt to store
9623 a byte offset into an 'int'; it might overflow.
9587a89d 9624 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9625
3e047f51
PE
9626 * sound.c: Don't assume sizes fit in 'int'.
9627 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9628 Return EMACS_INT, not int.
3e047f51 9629 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9630 Accept EMACS_INT, not int.
9631 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9632 record read return values.
9633
cc39a9db
BK
96342011-04-15 Ben Key <bkey76@gmail.com>
9635
c9d0ec6d
JB
9636 * keyboard.c (Qundefined): Don't declare static since it is used
9637 in nsfns.m.
9638 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9639 static since they are used in nsfont.m.
cc39a9db 9640
6c60eb9f
SM
96412011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9642
9643 * process.c (Qprocessp): Don't declare static.
9644 * lisp.h (Qprocessp): Declare again.
9645
7990b61a
JB
96462011-04-15 Juanma Barranquero <lekktu@gmail.com>
9647
9648 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9649
5d4cb038
PE
96502011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9651
8bd7b830 9652 Improve C-level modularity by making more things 'static'.
cd64ea1d 9653
e3b27b31
PE
9654 Don't publish debugger-only interfaces to other modules.
9655 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9656 (verify_bytepos, count_markers): Move decls to the only modules
9657 that need them.
9658 * region-cache.h (pp_cache): Likewise.
9659 * window.h (check_all_windows): Likewise.
9660 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9661
5d4cb038
PE
9662 * sysdep.c (croak): Now static, if
9663 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9664 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9665
9666 * alloc.c (refill_memory_reserve): Now static if
9667 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9668 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9669
e87b6180
PE
9670 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9671 Define only if USE_LUCID.
9672
ac64929e
PE
9673 * xrdb.c (x_customization_string, x_rm_string): Now static.
9674
6f37259d
PE
9675 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9676 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9677
1683e3ab
PE
9678 * xdisp.c (draw_row_with_mouse_face): Now static.
9679 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9680
de9c2632
PE
9681 * window.h (check_all_windows): Mark externally visible.
9682
2b96acb7
PE
9683 * window.c (window_deletion_count): Now static.
9684
9685 * undo.c: Make symbols static if they're not exported.
9686 (last_undo_buffer, last_boundary_position, pending_boundary):
9687 Now static.
9688
50436f33
PE
9689 * textprop.c (interval_insert_behind_hooks): Now static.
9690 (interval_insert_in_front_hooks): Likewise.
9691
64520e5c
PE
9692 * term.c: Make symbols static if they're not exported.
9693 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9694 (max_frame_lines, tty_set_terminal_modes):
9695 (tty_reset_terminal_modes, tty_turn_off_highlight):
9696 (get_tty_terminal): Now static.
9697 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9698 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9699 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9700 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9701 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9702
1fa53021
PE
9703 * sysdep.c: Make symbols static if they're not exported.
9704 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9705 Now static.
9706 (sigprocmask_set, full_mask): Remove; unused.
9707 (wait_debugging): Mark as visible.
9708 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9709 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9710
d4b43b22
PE
9711 * syntax.c (syntax_temp): Define only if !__GNUC__.
9712
b7c513d0
PE
9713 * sound.c (current_sound_device, current_sound): Now static.
9714
989b29ad
PE
9715 * search.c (searchbufs, searchbuf_head): Now static.
9716
13a55a78
PE
9717 * scroll.c (scroll_cost): Remove; unused.
9718 * dispextern.h (scroll_cost): Remove decl.
9719
de68a1fc
PE
9720 * region-cache.h (pp_cache): Mark as externally visible.
9721
40ccffa6
PE
9722 * process.c: Make symbols static if they're not exported.
9723 (process_tick, update_tick, create_process, chan_process):
9724 (Vprocess_alist, proc_buffered_char, datagram_access):
9725 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9726 (deactivate_process): Mark defn as static, as well as decl.
9727 * lisp.h (create_process): Remove decl.
9728 * process.h (chan_process, Vprocess_alist): Remove decls.
9729
ad64fc97
PE
9730 * print.c: Make symbols static if they're not exported.
9731 (print_depth, new_backquote_output, being_printed, print_buffer):
9732 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9733 (print_interval, print_number_index, initial_stderr_stream):
9734 Now static.
9735 * lisp.h (Fprinc): Remove decl.
9736 (debug_output_compilation_hack): Mark as externally visible.
9737
adddb265
PE
9738 * sysdep.c (croak): Move decl from here to syssignal.h.
9739 * syssignal.h (croak): Put it here, so the API can be checked when
9740 'croak' is called from dissociate_if_controlling_tty.
9741
1717ede2
PE
9742 * minibuf.c: Make symbols static if they're not exported.
9743 (minibuf_save_list, choose_minibuf_frame): Now static.
9744 * lisp.h (choose_minibuf_frame): Remove decl.
9745
fa5fb2bc
PE
9746 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9747
1e3890d1
PE
9748 * lread.c: Make symbols static if they're not exported.
9749 (read_objects, initial_obarray, oblookup_last_bucket_number):
9750 Now static.
9751 (make_symbol): Remove; unused.
9752 * lisp.h (initial_obarray, make_symbol): Remove decls.
9753
8a1414fa
PE
9754 * keyboard.c: Make symbols static if they're not exported.
9755 (single_kboard, recent_keys_index, total_keys, recent_keys):
9756 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9757 (this_single_command_key_start, echoing, last_auto_save):
9758 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9759 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9760 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9761 (Vlispy_mouse_stem, double_click_count):
9762 Now static.
9763 (force_auto_save_soon): Define only if SIGDANGER.
9764 (ignore_mouse_drag_p): Now static if
9765 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9766 (print_help): Remove; unused.
9767 (stop_character, last_timer_event): Mark as externally visible.
9768 * keyboard.h (ignore_mouse_drag_p): Declare only if
9769 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9770 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9771 * lisp.h (echoing): Remove decl.
9772 (force_auto_save_soon): Declare only if SIGDANGER.
9773 * xdisp.c (redisplay_window): Simplify code, to make it more
9774 obvious that ignore_mouse_drag_p is not accessed if !defined
9775 USE_GTK && !defined HAVE_NS.
9776
93ea6e8f
PE
9777 * intervals.c: Make symbols static if they're not exported.
9778 (merge_properties_sticky, merge_interval_right, delete_interval):
9779 Now static.
9780 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9781
77382fcc
PE
9782 * insdel.c: Make symbols static if they're not exported.
9783 However, leave prepare_to_modify_buffer alone. It's never
9784 called from outside this function, but that appears to be a bug.
9785 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9786 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9787 (adjust_after_replace_noundo): Remove; unused.
9788 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9789 (signal_before_change): Remove decls.
77382fcc 9790
9306c32e
PE
9791 * indent.c (val_compute_motion, val_vmotion): Now static.
9792
cd44d2eb
PE
9793 * image.c: Make symbols static if they're not exported.
9794 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9795 if USE_GTK.
9796 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9797 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9798
ad9a7a06
PE
9799 * fringe.c (standard_bitmaps): Now static.
9800 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9801
81626931
PE
9802 * frame.c: Make symbols static if they're not exported.
9803 (x_report_frame_params, make_terminal_frame): Now static.
9804 (get_frame_param): Now static, unless HAVE_NS.
9805 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9806 (x_get_resource_string): Remove; not used.
9807 * frame.h (make_terminal_frame, x_report_frame_params):
9808 (x_get_resource_string); Remove decls.
9809 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9810 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9811
239f9db9
PE
9812 * font.c, fontset.c: Make symbols static if they're not exported.
9813 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9814 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9815 * font.c (font_close_object): Now static.
9816 * font.h (font_close_object): Remove.
9817 * fontset.c (FONTSET_OBJLIST): Remove.
9818 (free_realized_fontset) #if-0 the body, which does nothing.
9819 (face_suitable_for_char_p): #if-0, as it's never called.
9820 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9821 * xfaces.c (face_at_string_position):
9822 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9823 since 0 is always ASCII.
9824
dfcf3579
PE
9825 * fns.c (weak_hash_tables): Now static.
9826
5045092b
PE
9827 * fileio.c: Make symbols static if they're not exported.
9828 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9829 (Vwrite_region_annotation_buffers): Now static.
9830
57a96f5c
PE
9831 * eval.c: Make symbols static if they're not exported.
9832 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9833 * lisp.h (backtrace_list): Remove decl.
9834
35f08c38
PE
9835 * emacs.c: Make symbols static if they're not exported.
9836 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9837 (fatal_error_code, fatal_error_signal_hook, standard_args):
9838 Now static.
9839 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9840 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9841 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9842 * lisp.h (fatal_error_signal_hook): Remove decl.
9843 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9844
f44bd759
PE
9845 * editfns.c: Move a (normally-unused) function to its only use.
9846 * editfns.c, lisp.h (get_operating_system_release): Remove.
9847 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9848 worth the hassle of breaking this out.
9849
b532497d
PE
9850 * xterm.c: Make symbols static if they're not exported.
9851 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9852 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9853 (x_destroy_window, x_delete_display):
9854 Now static.
9855 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9856 (x_mouse_leave): Remove; unused.
9857 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9858 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9859 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9860 Remove decls.
9861 (x_mouse_leave): Declare only if WINDOWSNT.
9862 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9863 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9864 USE_X_TOOLKIT.
9865
1675728f
PE
9866 * ftxfont.c: Make symbols static if they're not exported.
9867 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9868 HAVE_FREETYPE.
9869 * font.h (ftxfont_driver): Likewise.
9870
e4cebfca
PE
9871 * xfns.c: Make symbols static if they're not exported.
9872 (x_last_font_name, x_display_info_for_name):
9873 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9874 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9875 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9876 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9877 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9878 (last_show_tip_args): Now static.
9879 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9880 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9881 (x_screen_planes): Remove; unused.
9882 * dispextern.h (x_screen_planes): Remove decl.
9883
5bf46f05
PE
9884 * dispnew.c: Make symbols static if they're not exported.
9885 * dispextern.h (redraw_garbaged_frames, scrolling):
9886 (increment_row_positions): Remove.
9887 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9888 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9889 Now static.
9890 (redraw_garbaged_frames): Remove; unused.
9891
435f4c28
PE
9892 * xfaces.c: Make symbols static if they're not exported.
9893 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9894 Remove decls.
9895 * xterm.h (defined_color): Remove decls.
9896 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9897 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9898 (menu_face_changed_default, defined_color, free_realized_face):
9899 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9900 (ascii_face_of_lisp_face): Remove; unused.
9901
8524aef3
PE
9902 * xdisp.c: Make symbols static if they're not exported.
9903 * dispextern.h (scratch_glyph_row, window_box_edges):
9904 (glyph_to_pixel_coords, set_cursor_from_row):
9905 (get_next_display_element, set_iterator_to_next):
9906 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9907 (show_mouse_face): Remove decls
9908 * frame.h (message_buf_print): Likewise.
9909 * lisp.h (pop_message, set_message, check_point_in_composition):
9910 Likewise.
9911 * xterm.h (set_vertical_scroll_bar): Likewise.
9912 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9913 (message_buf_print, scratch_glyph_row, displayed_buffer):
9914 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9915 (get_next_display_element, show_mouse_face, window_box_edges):
9916 (frame_to_window_pixel_xy, check_point_in_composition):
9917 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9918 (glyph_to_pixel_coords): Remove; unused.
9919
16390cd2
PE
9920 * dired.c (file_name_completion): Now static.
9921
9922 * dbusbind.c (xd_in_read_queued_messages): Now static.
9923
a25f4dfa
PE
9924 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9925 * data.c (circular_list_error): Remove.
9926
14a9c8df
PE
9927 * commands.h (last_point_position, last_point_position_buffer):
9928 (last_point_position_window): Remove decls.
9929 * keyboard.c: Make these variables static.
9930
04f2d78b
CB
9931 * coding.h (coding, code_convert_region, encode_coding_gap):
9932 Remove decls.
74ab6df5
PE
9933 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9934 (iso_code_class, detect_coding, code_convert_region): Now static.
9935 (encode_coding_gap): Remove; unused.
9936
38dfbee1
PE
9937 * chartab.c (chartab_chars, chartab_bits): Now static.
9938
a2cb4e63
PE
9939 * charset.h (charset_iso_8859_1): Remove decl.
9940 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9941 Now static.
9942
127198fd
PE
9943 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9944 * ccl.c (Vccl_program_table): Now static.
9945 (check_ccl_update): Remove; unused.
9946
d85b608f
PE
9947 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9948 * category.h: ... from here.
9949 * category.c (check_category_table, set_category_set): Now static.
9950
31cd66f3
PE
9951 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9952 * lisp.h: Remove these decls.
9953
c358e587
PE
9954 * buffer.c (buffer_count): Remove unused var.
9955
e78aecca
PE
9956 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9957 so that it's not optimized away.
9958 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9959 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9960 exported only to the debugger.
9961
e192d7d3 9962 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9963 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9964
92470028
PE
9965 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9966 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9967 was inaccessible from Lisp.
9968 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9969 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9970
244ed907
PE
9971 alloc.c: Import and export fewer symbols, and remove unused items.
9972 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9973 is defined.
9974 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9975 it's not optimized away by whole-program optimization.
9976 (message_enable_multibyte, free_misc): Remove.
9977 (catchlist, handlerlist, mark_backtrace):
9978 Declare only if BYTE_MARK_STACK.
9979 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9980 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9981 (message_enable_multibyte): Remove decl.
9982 (free_misc, interval_free_list, float_block, float_block_index):
9983 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9984 (cons_free_list, last_marked_index):
9985 Now static.
9986 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9987 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9988 (mark_backtrace): Define only if BYTE_MARK_STACK.
9989 * xdisp.c (message_enable_multibyte): Now static.
9990
61c2b50e 9991 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9992 This makes it easier for human readers (and static analyzers)
9993 to see whether these variables are used from other modules.
9994 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9995 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9996 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9997 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9998 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9999 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10000 * xmenu.c, xselect.c:
10001 Declare Q* vars static if they are not used in other modules.
10002 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10003 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10004 Remove decls of unexported vars.
10005 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10006
95c82688
PE
10007 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10008
16a97296
PE
10009 Make Emacs functions such as Fatom 'static' by default.
10010 This makes it easier for human readers (and static analyzers)
10011 to see whether these functions can be called from other modules.
10012 DEFUN now defines a static function. To make the function external
10013 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10014 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10015 (Finit_image_library):
16a97296
PE
10016 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10017 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10018 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10019 Remove decls, since these functions are now static.
10020 (Funintern, Fget_internal_run_time): New decls, since these functions
10021 were already external.
95c82688 10022
16a97296
PE
10023 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10024 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10025 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10026 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10027 * keyboard.c, keymap.c, lread.c:
10028 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10029 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10030 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10031 Mark functions with DEFUE instead of DEFUN,
10032 if they are used in other modules.
10033 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10034 decls for now-static functions.
10035 * buffer.h (Fdelete_overlay): Remove decl.
10036 * callproc.c (Fgetenv_internal): Mark as internal.
10037 * composite.c (Fremove_list_of_text_properties): Remove decl.
10038 (Fcomposition_get_gstring): New forward static decl.
10039 * composite.h (Fcomposite_get_gstring): Remove decl.
10040 * dired.c (Ffile_attributes): New forward static decl.
10041 * doc.c (Fdocumntation_property): New forward static decl.
10042 * eval.c (Ffetch_bytecode): New forward static decl.
10043 (Funintern): Remove extern decl; now in .h file where it belongs.
10044 * fileio.c (Fmake_symbolic_link): New forward static decl.
10045 * image.c (Finit_image_library): New forward static decl.
10046 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10047 * intervals.h (Fprevious_property_change):
10048 (Fremove_list_of_text_properties): Remove decls.
10049 * keyboard.c (Fthis_command_keys): Remove decl.
10050 (Fcommand_execute): New forward static decl.
10051 * keymap.c (Flookup_key): New forward static decl.
10052 (Fcopy_keymap): Now static.
10053 * keymap.h (Flookup_key): Remove decl.
10054 * process.c (Fget_process): New forward static decl.
10055 (Fprocess_datagram_address): Mark as internal.
10056 * syntax.c (Fsyntax_table_p): New forward static decl.
10057 (skip_chars): Remove duplicate decl.
10058 * textprop.c (Fprevious_property_change): New forward static decl.
10059 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10060 Now internal.
10061 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10062 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10063
785bbd42
PE
10064 * editfns.c (Fformat): Remove unreachable code.
10065
8b913b57
AS
100662011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10067
10068 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10069 change. (Bug#8496)
10070
a6744a35
EZ
100712011-04-13 Eli Zaretskii <eliz@gnu.org>
10072
10073 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10074 when at ZV. (Bug#8487)
10075
e7974947
AS
100762011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10077
baad03f0
AS
10078 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10079 (Bug#8437)
10080 * keyboard.c (parse_tool_bar_item): Likewise.
10081 * sound.c (sound_cleanup, alsa_close): Likewise.
10082 * termcap.c (tgetent): Likewise.
10083 * xfns.c (x_default_font_parameter): Likewise.
10084 * xsettings.c (read_and_apply_settings): Likewise.
10085
e7974947
AS
10086 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10087 (overrun_check_free): Protoize.
10088
28272684
PE
100892011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10090
10091 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10092 since callers should never pass a negative size.
10093 Change the signature to match that of plain 'read' and 'write'; see
10094 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10095 * lisp.h: Update prototypes of emacs_write and emacs_read.
10096
11997c76
EZ
100972011-04-11 Eli Zaretskii <eliz@gnu.org>
10098
10099 * xdisp.c (redisplay_window): Don't try to determine the character
10100 position of the scroll margin if the window start point w->startp
e896f03c 10101 is outside the buffer's accessible region. (Bug#8468)
11997c76 10102
8a2cbd72
EZ
101032011-04-10 Eli Zaretskii <eliz@gnu.org>
10104
10105 Fix write-region and its subroutines for buffers > 2GB.
10106 * fileio.c (a_write, e_write): Modify declaration of arguments and
10107 local variables to support buffers larger than 2GB.
10108 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10109
10110 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10111 argument, local variables, and return value.
10112
10113 * lisp.h: Update prototypes of emacs_write and emacs_read.
10114
10115 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10116
4073e537 101172011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10118
1ebfdcb6
PE
10119 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10120
b2ded58d
PE
10121 Fix more problems found by GCC 4.6.0's static checks.
10122
7d66342c
PE
10123 * xdisp.c (vmessage): Use a better test for character truncation.
10124
bbf47d44
PE
10125 * charset.c (load_charset_map): <, not <=, for optimization,
10126 and to avoid potential problems with integer overflow.
9248994d 10127 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10128 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10129 * editfns.c (Fformat): Likewise.
1e69125e 10130 * syntax.c (skip_chars): Likewise.
3befa583 10131
e3019616
PE
10132 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10133 This also lets GCC 4.6.0 generate slightly better loop code.
10134
becfa255
PE
10135 * callint.c (Fcall_interactively): <, not <=, for optimization.
10136 (Fcall_interactively): Count the number of arguments produced,
10137 not the number of arguments given. This is simpler and lets GCC
10138 4.6.0 generate slightly better code.
10139
dae0cd48
PE
10140 * ftfont.c: Distingish more carefully between FcChar8 and char.
10141 The previous code passed unsigned char * to a functions like
10142 strlen and xstrcasecmp that expect char *, which does not
10143 conform to the C standard.
10144 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10145 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10146 char * when the C standard requires it.
10147
76032d70
PE
10148 * keyboard.c (read_char): Remove unused var.
10149
eb3f1cc8
PE
10150 * eval.c: Port to Windows vsnprintf (Bug#8435).
10151 Include <limits.h>.
10152 (SIZE_MAX): Define if the headers do not.
10153 (verror): Do not give up if vsnprintf returns a negative count.
10154 Instead, grow the buffer. This ports to Windows vsnprintf, which
10155 does not conform to C99. Problem reported by Eli Zaretskii.
10156 Also, simplify the allocation scheme, by avoiding the need for
10157 calling realloc, and removing the ALLOCATED variable.
10158
70476b54
PE
10159 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10160
12020a9e
PE
10161 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10162 But keep the doprint source code for now, as we might revamp it
10163 and use it again (Bug#8435).
ea6c7ae6
PE
10164 * lisp.h (doprnt): Remove.
10165 * Makefile.in (base_obj): Remove doprnt.o.
10166 * deps.mk (doprnt.o): Remove.
10167
5fdb398c
PE
10168 error: Print 32- and 64-bit integers portably (Bug#8435).
10169 Without this change, on typical 64-bit hosts error ("...%d...", N)
10170 was used to print both 32- and 64-bit integers N, which relied on
10171 undefined behavior.
61bdb816 10172 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10173 * lisp.h (error, verror): Mark as printf-like functions.
10174 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10175 Report overflow in size calculations when allocating printf buffer.
10176 Do not truncate output string at its first null byte.
10177 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10178 Truncate the output at a character boundary, since vsnprintf does not
10179 do that.
10180 * charset.c (check_iso_charset_parameter): Convert internal
10181 character to string before calling 'error', since %c now has the
10182 printf meaning.
10183 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10184 overflow when computing char to be passed to 'error'. Do not
10185 pass Lisp_Object to 'error'; pass the integer instead.
10186 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10187 formatted with plain %d.
10188
b189fa66
PE
10189 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10190
bff87ef0
PE
10191 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10192
7e2cac20
PE
10193 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10194
ce4d90b5
PE
10195 * xterm.c (x_catch_errors): Remove duplicate declaration.
10196
266c9547
PE
10197 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10198
79c49ad2
PE
10199 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10200
368f4090
JM
102012011-04-10 Jim Meyering <meyering@redhat.com>
10202
10203 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10204 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10205 return ssize_t not "int", and use size_t as the buffer length.
10206 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10207 * gnutls.h: Update declarations.
10208 * process.c (read_process_output): Use ssize_t, to match.
10209 (send_process): Likewise.
10210
a32d4040
CY
102112011-04-09 Chong Yidong <cyd@stupidchicken.com>
10212
10213 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10214
8546720e 102152011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10216
04f2d78b
CB
10217 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10218 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10219
8546720e
GM
10220 * xterm.c (handle_one_xevent):
10221 * xmenu.c (create_and_show_popup_menu):
10222 * xselect.c (x_decline_selection_request)
10223 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10224
0a2f5c1a 102252011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10226
10227 Fix some uses of `int' instead of EMACS_INT.
10228 * search.c (string_match_1, fast_string_match)
10229 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10230 (scan_buffer, find_next_newline_no_quit)
10231 (find_before_next_newline, search_command, Freplace_match)
10232 (Fmatch_data): Make some `int' variables be EMACS_INT.
10233
10234 * xdisp.c (display_count_lines): 3rd argument and return value now
10235 EMACS_INT. All callers changed.
10236 (pint2hrstr): Last argument is now EMACS_INT.
10237
10238 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10239 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10240 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10241 (decode_coding_utf_16, decode_coding_emacs_mule)
10242 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10243 (decode_coding_ccl, decode_coding_charset)
10244 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10245 (decode_coding_iso_2022, decode_coding_emacs_mule)
10246 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10247 <char_offset, last_offset>: Declare EMACS_INT.
10248 (encode_coding_utf_8, encode_coding_utf_16)
10249 (encode_coding_emacs_mule, encode_invocation_designation)
10250 (encode_designation_at_bol, encode_coding_iso_2022)
10251 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10252 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10253 Declare EMACS_INT.
10254 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10255 (encode_invocation_designation): Last argument P_NCHARS is now
10256 EMACS_INT.
10257 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10258 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10259
10260 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10261 All users changed.
10262
10263 * ccl.c (Fccl_execute_on_string): Declare some variables
10264 EMACS_INT.
10265
8546720e 102662011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10267
10268 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10269
4e19a977
CS
102702011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10271
10272 * process.c (Fformat_network_address): Doc fix.
10273
87302331
R
102742011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10275
ee7683eb 10276 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10277
cbb59342
CY
102782011-04-08 Chong Yidong <cyd@stupidchicken.com>
10279
10280 * keyboard.c (read_char): Call Lisp function help-form-show,
10281 instead of using internal_with_output_to_temp_buffer.
10282 (Qhelp_form_show): New var.
e0d38eeb 10283 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10284
10285 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10286
10287 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10288
e67a13ab
CY
102892011-04-06 Chong Yidong <cyd@stupidchicken.com>
10290
04f2d78b
CB
10291 * process.c (Flist_processes): Remove to Lisp.
10292 (list_processes_1): Delete.
e67a13ab 10293
973f782d
EZ
102942011-04-06 Eli Zaretskii <eliz@gnu.org>
10295
7c106b1e
EZ
10296 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10297
973f782d
EZ
10298 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10299
41cf7d1a 103002011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10301
ca23cc88
PE
10302 Fix more problems found by GCC 4.6.0's static checks.
10303
f390e2d5
PE
10304 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10305
42eea0d0
PE
10306 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10307
b69769da 10308 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10309
f9541e84
PE
10310 * xdisp.c (vmessage): Mark as a printf-like function.
10311
13841b55
PE
10312 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10313
c136c10f
PE
10314 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10315
5e2d4a30
PE
10316 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10317 printf-like functions.
10318 (tiff_load): Add casts to remove these marks before passing them
10319 to system-supplied API.
10320
583f48b9
PE
10321 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10322
b25d760e
PE
10323 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10324 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10325 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10326 directly, rather than having caller test rule sign. This avoids
10327 some unnecessary tests.
10328 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10329 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10330 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10331
bc7b6697 10332 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10333 (xfont_open): Avoid unnecessary tests.
bc7b6697 10334
27ccc379
PE
10335 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10336
dcd5c89a
PE
10337 * composite.h, composite.c (composition_gstring_put_cache):
10338 Use EMACS_INT, not int, for length.
10339
b13a45c6
PE
10340 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10341 breaking out part of COMPOSITION_DECODE_RULE.
10342 (COMPOSITION_DECODE_RULE): Use it.
10343 * composite.c (get_composition_id): Remove unused local vars,
10344 by using the new macro.
10345
1e792e4d
PE
10346 * textprop.c (set_text_properties_1): Change while to do-while,
10347 since the condition is always true at first.
10348
dc6c6455 10349 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10350 (interval_deletion_adjustment): Return unsigned value.
10351 All uses changed.
dc6c6455 10352
aba7731a
PE
10353 * process.c (list_processes_1, create_pty, read_process_output):
10354 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10355 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10356 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10357 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10358 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10359
fdfc4bf3
PE
10360 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10361
fca8fe46 10362 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10363 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10364
06a0259a 10365 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10366 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10367 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10368
e7b9e80f
PE
10369 * print.c (print_error_message): Avoid int overflow.
10370
56201685
PE
10371 * font.c (font_list_entities): Redo for clarity,
10372 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10373
78834453 10374 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10375 (font_score): Avoid potential overflow in diff calculation.
78834453 10376
0bc0b309 10377 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10378 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10379
e610eaca
PE
10380 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10381
b895abce
PE
10382 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10383 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10384 can always succeed if overflow has undefined behavior.
10385
1f1d9321 10386 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10387 (wordify): Omit three unnecessary tests.
1f1d9321 10388
c59478bc
PE
10389 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10390 All callers changed. This avoids the need for an unused var.
10391
79b73827
PE
10392 * casefiddle.c (casify_region): Remove var that is set but not used.
10393
a4db5dfe
PE
10394 * dired.c (file_name_completion): Remove var that is set but not used.
10395
43aae36e
PE
10396 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10397
2a47c44d 10398 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10399 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10400
a37c69bf
PE
10401 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10402 Check for integer overflow on size calculations.
10403
328ab8e7
PE
10404 * buffer.c (Fprevious_overlay_change): Remove var that is set
10405 but not used.
10406
e5a2a5cb
PE
10407 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10408 Remove vars that are set but not used.
8d84a6eb 10409 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10410 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10411
a60e5f68
PE
10412 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10413
f661cb61 10414 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10415 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10416
f0397f5a
PE
10417 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10418 that are set but not used.
10419
8664db06 10420 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10421 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10422
6abdaa4a
PE
10423 * xselect.c (x_get_local_selection, x_handle_property_notify):
10424 Remove vars that are set but not used.
10425
0ce7538d 10426 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10427 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10428
9ae848fc
PE
10429 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10430 Remove var that is set but not used.
0b918413
PE
10431 (scroll_bar_windows_size): Now size_t, not int.
10432 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10433 Check for overflow.
9ae848fc 10434
a5a62657
PE
10435 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10436 (map_tty_color) [!defined MSDOS]: Likewise.
10437
5c5cdd39
PE
10438 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10439
66ebf983
PE
10440 * coding.c: Remove vars that are set but not used.
10441 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10442 All callers changed.
10443 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10444 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10445 (decode_coding_charset): Remove vars that are set but not used.
10446
1be4d761
PE
10447 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10448 that is set but not used.
10449
47553fa8
PE
10450 * print.c (print_object): Remove var that is set but not used.
10451
1f7196bf 10452 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10453 The gnulib version avoids calling malloc in the usual case,
10454 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10455 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10456 * filelock.c (current_lock_owner): Likewise.
10457 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10458 * sysdep.c: Include allocator.h, careadlinkat.h.
10459 (emacs_no_realloc_allocator): New static constant.
10460 (emacs_readlink): New function.
fdb61804
PE
10461 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10462 ../lib/careadlinkat.h.
d1fdcab7 10463
f84c17c7
SM
104642011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10465
10466 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10467 first non-nil return value).
10468
ef3862ad
JD
104692011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10470
10471 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10472 if not defined (Bug#8403).
10473
376a7006
JB
104742011-04-02 Juanma Barranquero <lekktu@gmail.com>
10475
10476 * xdisp.c (display_count_lines): Remove parameter `start',
10477 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10478 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10479 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10480 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10481 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10482 and thereabouts. All callers changed.
10483 (get_per_char_metric): Remove parameter `f', unused since
10484 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10485
6ca3801d
JM
104862011-04-02 Jim Meyering <meyering@redhat.com>
10487
10488 do not dereference NULL upon failed strdup
10489 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10490 (ns_get_family): Likewise.
10491
d8e2b5ba
JB
104922011-04-02 Juanma Barranquero <lekktu@gmail.com>
10493
10494 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10495
8c74fcbd
JD
104962011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10497
10498 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10499 later (Bug#8403).
10500
7200d79c
SM
105012011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10502
03408648 10503 Add lexical binding.
7200d79c 10504
03408648
SM
10505 * window.c (Ftemp_output_buffer_show): New fun.
10506 (Fsave_window_excursion):
10507 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10508
10509 * lread.c (lisp_file_lexically_bound_p): New function.
10510 (Fload): Bind Qlexical_binding.
10511 (readevalloop): Remove `evalfun' arg.
10512 Bind Qinternal_interpreter_environment.
10513 (Feval_buffer): Bind Qlexical_binding.
10514 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10515 Mark as dynamic.
10516 (syms_of_lread): Declare `lexical-binding'.
10517
10518 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10519
10520 * keyboard.c (eval_dyn): New fun.
10521 (menu_item_eval_property): Use it.
ca105506
SM
10522
10523 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10524
03408648
SM
10525 * fns.c (concat, mapcar1): Accept byte-code-functions.
10526
10527 * eval.c (Fsetq): Handle lexical vars.
10528 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10529 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10530 (FletX, Flet): Obey lexical binding.
10531 (Fcommandp): Handle closures.
10532 (Feval): New `lexical' arg.
10533 (eval_sub): New function extracted from Feval. Use it almost
10534 everywhere where Feval was used. Look up vars in lexical env.
10535 Handle closures.
10536 (Ffunctionp): Move from subr.el.
10537 (Ffuncall): Handle closures.
10538 (apply_lambda): Remove `eval_flags'.
10539 (funcall_lambda): Handle closures and new byte-code-functions.
10540 (Fspecial_variable_p): New function.
10541 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10542 but without exporting it to Lisp.
23aba0ea 10543
23aba0ea 10544 * doc.c (Fdocumentation, store_function_docstring):
03408648 10545 * data.c (Finteractive_form): Handle closures.
23aba0ea 10546
03408648
SM
10547 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10548 interactive spec.
ba83908c 10549
04f2d78b
CB
10550 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10551 New byte-codes.
03408648
SM
10552 (exec_byte_code): New function extracted from Fbyte_code to handle new
10553 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10554
03408648 10555 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10556
03408648 10557 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10558
e2abce01
JB
105592011-03-31 Juanma Barranquero <lekktu@gmail.com>
10560
10561 * xdisp.c (redisplay_internal): Fix prototype.
10562
63696a73 105632011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10564
63696a73 10565 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10566 (try_scrolling): Use it when setting scroll_limit.
10567 Limit scrolling to 100 screen lines.
63696a73
EZ
10568 (redisplay_window): Even when falling back on "recentering",
10569 position point in the window according to scroll-conservatively,
10570 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10571
10572 (try_scrolling): When point is above the window, allow searching
10573 as far as scroll_max, or one screenful, to compute vertical
10574 distance from PT to the scroll margin position. This prevents
10575 try_scrolling from unnecessarily failing when
10576 scroll-conservatively is set to a value slightly larger than the
10577 window height. Clean up the case of PT below the margin at bottom
10578 of window: scroll_max can no longer be INT_MAX. When aggressive
10579 scrolling is in use, don't let point enter the opposite scroll
10580 margin as result of the scroll.
10581 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10582 threshold of 100 lines for never-recentering scrolling.
10583
e4cc2dfc
JB
105842011-03-31 Juanma Barranquero <lekktu@gmail.com>
10585
10586 * dispextern.h (move_it_by_lines):
10587 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10588 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10589 (message_log_check_duplicate): Remove parameters `prev_bol' and
10590 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10591 (redisplay_internal): Remove parameter `preserve_echo_area',
10592 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10593
10594 * indent.c (Fvertical_motion):
10595 * window.c (window_scroll_pixel_based, Frecenter):
10596 Don't pass `need_y_p' to `move_it_by_lines'.
10597
1c470562
SM
105982011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10599
44f230aa
SM
10600 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10601 steal a few bits to be more compact.
10602 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10603 Remove unneeded casts.
10604
1c470562
SM
10605 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10606
888adce9
ZK
106072011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10608
10609 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10610 binding" message (bug#7967).
10611
f838ed7b
PE
106122011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10613
77861b95
PE
10614 Fix more problems found by GCC 4.6.0's static checks.
10615
de6dbc14
PE
10616 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10617 Remove unused local var.
10618
f838ed7b
PE
10619 * editfns.c (Fmessage_box): Remove unused local var.
10620
792c7b2b
PE
10621 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10622 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10623 Omit unused local vars.
c499e557 10624 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10625 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10626 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10627 Omit unused local var.
10628
ba0165e1
PE
10629 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10630 Don't assume string length fits in int.
32ad8845 10631 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10632 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10633
3c59b4c9
PE
10634 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10635 instead of alloca (Bug#8344).
10636
a3eed478 10637 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10638 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10639
eb4d412d
PE
10640 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10641
1658b401
PE
10642 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10643 concerns.
10644
10645 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10646
10647 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10648
9a2c6e05
PE
10649 * keyboard.c (syms_of_keyboard): Use the same style as later
10650 in this function when indexing through an array. This also
10651 works around GCC bug 48267.
10652
03d0a109
PE
10653 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10654
44f730c8
PE
10655 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10656
fe75f926
PE
10657 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10658 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10659
ffa8c828
PE
10660 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10661 This avoids undefined behavior on integer overflow, and is a bit
10662 more convenient anyway since it is compared to a size_t variable.
10663
c5101a77
PE
10664 Variadic C functions now count arguments with size_t, not int.
10665 This avoids an unnecessary limitation on 64-bit machines, which
10666 caused (substring ...) to crash on large vectors (Bug#8344).
10667 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10668 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10669 All variadic functions and their callers changed accordingly.
c5101a77
PE
10670 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10671 * data.c (arith_driver, float_arith_driver): Likewise.
10672 * editfns.c (general_insert_function): Likewise.
10673 * eval.c (struct backtrace.nargs, interactive_p)
10674 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10675 (funcall_lambda, mark_backtrace): Likewise.
10676 * fns.c (concat): Likewise.
10677 * frame.c (x_set_frame_parameters): Likewise.
10678 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10679 0 if not found, not -1. All callers changed.
10680
dd3f25f7
PE
10681 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10682 (stack_copy_size): Now size_t, not int.
10683 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10684
461c2ab9
JB
106852011-03-28 Juanma Barranquero <lekktu@gmail.com>
10686
10687 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10688 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10689 All callers changed.
10690
10691 * lisp.h (multibyte_char_to_unibyte):
10692 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10693 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10694 * character.h (CHAR_TO_BYTE8):
10695 * cmds.c (internal_self_insert):
10696 * editfns.c (general_insert_function):
10697 * keymap.c (push_key_description):
10698 * search.c (Freplace_match):
10699 * xdisp.c (message_dolog, set_message_1): All callers changed.
10700
f6d62986
SM
107012011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10702
10703 * keyboard.c (safe_run_hook_funcall): New function.
10704 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10705 don't set the hook to nil, but remove the offending function instead.
10706 (Qcommand_hook_internal): Remove, unused.
10707 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10708 Vcommand_hook_internal.
10709
10710 * eval.c (enum run_hooks_condition): Remove.
10711 (funcall_nil, funcall_not): New functions.
10712 (run_hook_with_args): Call each function through a `funcall' argument.
10713 Remove `cond' argument, now redundant.
10714 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10715 (Frun_hook_with_args_until_failure): Adjust accordingly.
10716 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10717
1db5b1ad
JB
107182011-03-28 Juanma Barranquero <lekktu@gmail.com>
10719
10720 * dispextern.h (string_buffer_position): Remove declaration.
10721
10722 * print.c (strout): Remove parameter `multibyte', unused since
10723 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10724
10725 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10726 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10727 All callers changed.
10728
10729 * w32.c (_wsa_errlist): Use braces for struct initializers.
10730
10731 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10732 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10733 All callers changed.
10734 (string_buffer_position): Likewise. Also, make static (it's never
10735 used outside xdisp.c).
10736 (cursor_row_p): Remove parameter `w', unused since
10737 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10738 (decode_mode_spec): Remove parameter `precision', introduced during
10739 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10740 All callers changed.
10741
5ffb62aa
JD
107422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10743
10744 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10745
461c2ab9 107462011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10747
10748 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10749 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10750 (ns_update_auto_hide_menu_bar): New functions.
10751 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10752 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10753 ns_constrain_all_frames.
10754 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10755 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10756
5c380ffb
JD
107572011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10758
10759 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10760
9af30bdf
GM
107612011-03-27 Glenn Morris <rgm@gnu.org>
10762
10763 * syssignal.h: Replace RETSIGTYPE with void.
10764 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10765 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10766 Replace SIGTYPE with void everywhere.
10767 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10768 * s/template.h (SIGTYPE): Remove commented out definition.
10769
e2abce01
JB
107702011-03-26 Eli Zaretskii <eliz@gnu.org>
10771
10772 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10773 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10774
f868cd8a
JB
107752011-03-26 Juanma Barranquero <lekktu@gmail.com>
10776
59eb0929
JB
10777 * w32.c (read_unc_volume): Use parameter `henum', instead of
10778 global variable `wget_enum_handle'.
10779
10780 * keymap.c (describe_vector): Remove parameters `indices' and
10781 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10782 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10783
f868cd8a
JB
10784 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10785
10786 * keyboard.c (timer_check): Remove parameter `do_it_now',
10787 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10788 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10789 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10790
10791 * keyboard.c (read_char):
10792 * w32menu.c (w32_menu_display_help):
10793 * xmenu.c (show_help_event, menu_help_callback):
10794 Adjust calls to `show_help_echo'.
10795
10796 * gtkutil.c (xg_maybe_add_timer):
10797 * keyboard.c (readable_events):
10798 * process.c (wait_reading_process_output):
10799 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10800
10801 * insdel.c (adjust_markers_gap_motion):
10802 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10803 (gap_left, gap_right): Don't call it.
10804
2ecf6fdb
CY
108052011-03-25 Chong Yidong <cyd@stupidchicken.com>
10806
10807 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10808 incurred during fontification.
10809
6b1f9ba4
JB
108102011-03-25 Juanma Barranquero <lekktu@gmail.com>
10811
10812 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10813 (DEFVAR_PER_BUFFER): Don't pass it.
10814
10815 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10816 (scrolling_window): Don't pass it.
10817
0f4a96b5
JB
108182011-03-25 Juanma Barranquero <lekktu@gmail.com>
10819
10820 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10821
10822 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10823 and `suffix'.
10824 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10825 of variables specific to SELinux and computation of `encoded_absname'.
10826
10827 * image.c (XPutPixel): Remove unused variable `height'.
10828
10829 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10830
10831 * unexw32.c (get_section_info): Remove unused variable `section'.
10832
10833 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10834 (system_process_attributes): Remove unused variable `sess'.
10835 (sys_read): Remove unused variable `err'.
10836
10837 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10838 (w32_wnd_proc): Remove unused variable `isdead'.
10839 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10840 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10841 (x_create_tip_frame): Remove unused variable `tem'.
10842
10843 * w32inevt.c (w32_console_read_socket):
10844 Remove unused variable `no_events'.
10845
10846 * w32term.c (x_draw_composite_glyph_string_foreground):
10847 Remove unused variable `width'.
10848
1149507c
JB
108492011-03-24 Juanma Barranquero <lekktu@gmail.com>
10850
10851 * w32term.c (x_set_glyph_string_clipping):
10852 Don't pass uninitialized region to CombineRgn.
10853
9c88f339
JB
108542011-03-23 Juanma Barranquero <lekktu@gmail.com>
10855
10856 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10857 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10858 (Fx_close_connection): Remove unused variable `i'.
10859
10860 * w32font.c (w32font_draw): Return number of glyphs.
10861 (w32font_open_internal): Remove unused variable `i'.
10862 (w32font_driver): Add missing initializer.
10863
10864 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10865 (fill_in_menu): Remove unused variable `items_added'.
10866
10867 * w32term.c (last_mouse_press_frame): Remove static global variable.
10868 (w32_clip_to_row): Remove unused variable `f'.
10869 (x_delete_terminal): Remove unused variable `i'.
10870
10871 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10872 (NOTHING): Remove unused static global variable.
10873 (uniscribe_check_otf): Remove unused variable `table'.
10874 (uniscribe_font_driver): Add missing initializers.
10875
dee091a3
JD
108762011-03-23 Julien Danjou <julien@danjou.info>
10877
10878 * term.c (Fsuspend_tty, Fresume_tty):
10879 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10880 * window.c (temp_output_buffer_show):
10881 * insdel.c (signal_before_change):
10882 * frame.c (Fhandle_switch_frame):
10883 * fileio.c (Fdo_auto_save):
10884 * emacs.c (Fkill_emacs):
10885 * editfns.c (save_excursion_restore):
10886 * cmds.c (internal_self_insert):
10887 * callint.c (Fcall_interactively):
10888 * buffer.c (Fkill_all_local_variables):
10889 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10890 Use Frun_hooks.
0f4a96b5 10891 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10892 unconditionally since it does the check itself.
dee091a3 10893
2c520ab5 108942011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10895
c9c49752
PE
10896 Fix more problems found by GCC 4.5.2's static checks.
10897
8abc3f12
PE
10898 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10899 the first time through the loop, since we know p0 < p1 then.
10900 This also avoids a gcc -Wstrict-overflow warning.
10901
a2d26660
PE
10902 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10903 leading to a memory leak, possible in functions like
10904 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10905 of objects (Bug#8318).
a2d26660 10906
916c72e9
PE
10907 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10908 that could (at least in theory) be that large.
10909
19ab8a18
PE
10910 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10911 This is less likely to overflow, and avoids undefined behavior if
10912 overflow does occur. All callers changed. Use strtoul to scan
10913 for the unsigned long integer.
b7cbbd6f
PE
10914 (pint2hrstr): Simplify and tune code slightly.
10915 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10916
f0641eff
PE
10917 * scroll.c (do_scrolling): Work around GCC bug 48228.
10918 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10919
7f650bb9
PE
10920 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10921 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10922 (validate_x_resource_name): Simplify count usage.
10923 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10924
37dd57d1
PE
10925 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10926 fail (Bug#8306).
81e56e61 10927
699979fc 10928 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10929
401bf9b4
PE
10930 * process.c (Fmake_network_process): Use socklen_t, not int,
10931 where POSIX says socklen_t is required in portable programs.
10932 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10933 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10934 (Fmake_network_process, server_accept_connection):
10935 (wait_reading_process_output, read_process_output):
10936 Likewise.
10937
b93aacde
PE
10938 * process.c: Rename or move locals to avoid shadowing.
10939 (list_processes_1, Fmake_network_process):
10940 (read_process_output_error_handler, exec_sentinel_error_handler):
10941 Rename or move locals.
4dc343ee 10942 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10943 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10944 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10945 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10946 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10947
af8a867c 10948 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10949 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10950 Include tparam.h instead, since it declares them.
af8a867c
PE
10951 * cm.h (PC): Remove extern decl; tparam.h now does this.
10952 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10953 * terminfo.c: Include tparam.h, to check interfaces.
10954 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10955 (tparam): Adjust signature to match interface in tparam.h;
10956 this removes some undefined behavior. Check that outstring and len
10957 are zero, which they always are with Emacs.
10958 * tparam.h (PC, BC, UP): New extern decls.
10959
0248044d 10960 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10961 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10962
8ff096c1 10963 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10964 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10965 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10966 (ftfont_list): Remove unused local.
49eaafba
PE
10967 (get_adstyle_property, ftfont_pattern_entity):
10968 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10969 Rename locals to avoid shadowing.
8ff096c1 10970
e2be39f6
PE
10971 * xfont.c (xfont_list_family): Mark var as initialized.
10972
c9735e30
PE
10973 * xml.c (make_dom): Now static.
10974
8f5201ae
PE
10975 * composite.c (composition_compute_stop_pos): Rename local to
10976 avoid shadowing.
b246f932
PE
10977 (composition_reseat_it): Remove unused locals.
10978 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10979 (composition_update_it): Mark var as initialized.
11b61122
PE
10980 (find_automatic_composition): Mark vars as initialized,
10981 with a FIXME (Bug#8290).
8f5201ae 10982
760fbc2c
PE
10983 character.h: Rename locals to avoid shadowing.
10984 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10985 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10986 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10987 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10988 to avoid shadowing.
10989
ff08eb85
PE
10990 * textprop.c (property_change_between_p): Remove; unused.
10991
fc7bf025
PE
10992 * intervals.c (interval_start_pos): Now static.
10993
235d7abc
PE
10994 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10995
44f230aa
SM
10996 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10997 Rename locals to avoid shadowing.
3e7d6594 10998
50060332
PE
10999 * sound.c (wav_play, au_play, Fplay_sound_internal):
11000 Fix pointer signedness.
d01f234b 11001 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11002 (wav_play): Initialize a variable to 0, to prevent undefined
11003 behavior (Bug#8278).
50060332 11004
c4fc4e30
PE
11005 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11006
918436ed
PE
11007 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11008
c939f91b
PE
11009 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11010 clobbering (Bug#8298).
b9c7f648
PE
11011 * sysdep.c (sys_subshell): Likewise.
11012 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11013
6bd8c144
PE
11014 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11015 This should get cleaned up, so that child_setup has the
11016 same signature on all platforms.
11017
7710357c 11018 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11019 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11020
c59da222
CY
110212011-03-22 Chong Yidong <cyd@stupidchicken.com>
11022
11023 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11024 not to be necessary, and produces flickering.
11025
66b87493
GM
110262011-03-20 Glenn Morris <rgm@gnu.org>
11027
11028 * config.in: Remove file.
11029
45b6f6d5
JB
110302011-03-20 Juanma Barranquero <lekktu@gmail.com>
11031
11032 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11033 are now in src/globals.h.
11034 (syms_of_minibuf): Remove spurious & from previous change.
11035
cd394be1 110362011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11037
11038 * minibuf.c (completing-read-function): New variable.
11039 (completing-read-default): Rename from completing-read.
11040 (completing-read): Call completing-read-function.
11041
b14e3e21
CY
110422011-03-19 Juanma Barranquero <lekktu@gmail.com>
11043
11044 * xfaces.c (Fx_load_color_file):
11045 Read color file from absolute filename (bug#8250).
11046
f2b726e6
JB
110472011-03-19 Juanma Barranquero <lekktu@gmail.com>
11048
11049 * makefile.w32-in: Update dependencies.
11050
09f6ff02
EZ
110512011-03-17 Eli Zaretskii <eliz@gnu.org>
11052
11053 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11054
29a6015a
PE
110552011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11056
a3a6c54e
PE
11057 Fix more problems found by GCC 4.5.2's static checks.
11058
b766f867
PE
11059 * process.c (make_serial_process_unwind, send_process_trap):
11060 (sigchld_handler): Now static.
11061
be02381c
PE
11062 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11063 That way, the code declares only the vars that it needs.
11064 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11065 * s/cygwin.h (PTY_ITERATION): Likewise.
11066 * s/darwin.h (PTY_ITERATION): Likewise.
11067 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11068
57048744
PE
11069 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11070 * process.c (allocate_pty): Don't declare stb unless it's needed.
11071
7914961c 11072 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11073 (CONSTANTLIM): Remove; unused.
11074 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11075 Define only if needed.
7914961c 11076
b3967b18
PE
11077 * unexelf.c (unexec): Name an expression,
11078 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11079 Use a different way to cause a compilation error if anyone uses
11080 n rather than nn, a way that does not involve shadowing.
73366a00 11081 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11082
29a6015a
PE
11083 * deps.mk (unexalpha.o): Remove; unused.
11084
43cfc33e 11085 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11086 * unexec.h: New file.
ce701a33
PE
11087 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11088 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11089 Depend on unexec.h.
11090 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11091 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11092 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11093 Change as necessary to match prototype in unexec.h.
ce701a33 11094
01f44d5a
PE
11095 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11096 shadowing.
4f63c6bb 11097 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11098
a6670b0b
PE
11099 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11100 Rename locals to avoid shadowing.
11101
cef2010d 11102 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11103 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11104
d4d7173a
PE
11105 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11106
f08b802a
PE
11107 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11108 warning when compiling print.c.
11109
3ddb0639
PE
11110 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11111 instead of using an uninitialized var.
5ad03b97 11112 (font_sort_entities): Mark var as initialized.
3ddb0639 11113
170a2692
PE
11114 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11115
e663c700
PE
11116 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11117 pointers to constants.
89bc529a 11118 (font_parse_fcname): Remove unused vars.
7b81e2d0 11119 (font_delete_unmatched): Now static.
ea838e10 11120 (font_get_spec): Remove; unused.
13a547c6
PE
11121 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11122 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11123 Rename or move locals to avoid shadowing.
e663c700 11124
2a80c887 11125 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11126 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11127
1384fa33 11128 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11129 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11130
8b2c52e9
PE
11131 * alloc.c (mark_backtrace): Move decl from here ...
11132 * lisp.h: ... to here, so that it can be checked.
11133
475545b5 11134 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11135 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11136 (lisp_indirect_variable): Name an expression,
11137 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11138 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11139
b1349114 11140 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11141 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11142 Use const pointer when appropriate.
b1349114 11143
a2928364
PE
11144 * lisp.h (get_system_name, get_operating_system_release):
11145 Move decls here, to check interfaces.
11146 * process.c (get_operating_system_release): Move decl to lisp.h.
11147 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11148 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11149 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11150 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11151 (Fformat_time_string, Fencode_time, Finsert_char):
11152 (Ftranslate_region_internal, Fformat):
11153 Rename or remove local vars to avoid shadowing.
9710023e 11154 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11155
a415e694
PE
11156 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11157 avoid shadowing.
11158
8ef4622d
PE
11159 * lisp.h (eassert): Check that the argument compiles, even if
11160 ENABLE_CHECKING is not defined.
11161
946f9a5b
PE
11162 * data.c (Findirect_variable): Name an expression, to avoid
11163 gcc -Wbad-function-cast warning.
112396d6 11164 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11165 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11166 (Fmake_variable_buffer_local, Fmake_local_variable):
11167 Mark variables as initialized.
52746918 11168 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11169
e5aab7e7 11170 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11171 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11172 Rename locals to avoid shadowing.
dff45157
PE
11173 (mark_stack): Move local variables into the #ifdef region where
11174 they're used.
7bc26fdb
PE
11175 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11176 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11177 needed otherwise.
11178 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11179 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11180 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11181
e5aab7e7
PE
11182 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11183 avoids undefined behavior in theory.
11184
4da60324
PE
11185 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11186
88043301
PE
11187 Use functions, not macros, for up- and down-casing (Bug#8254).
11188 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11189 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11190 to use the following functions instead of these macros.
11191 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11192 EMACS_INT, since callers assume the returned value fits in int.
11193 (upcase1): Likewise, for UPCASE_TABLE.
11194 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11195 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11196 the race-condition problem in the old DOWNCASE.
88043301 11197
19ed5445
PE
11198 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11199 Rename locals to avoid shadowing.
11200 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11201 (regex_compile, re_search_2, re_match_2_internal):
11202 Remove unused local vars.
952db0d7
PE
11203 (FREE_VAR): Rewrite so as not to use empty "else",
11204 which gcc can warn about.
da053e48 11205 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11206 (RETALLOC_IF): Define only if needed.
11207 (WORDCHAR_P): Likewise. This one is never needed, but is used
11208 only in a comment talking about a compiler bug, so put inside
11209 the #if 0 of that comment.
11210 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11211 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11212 Remove; unused.
19ed5445 11213
1f3561e4 11214 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11215 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11216 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11217
ded6f8f7
PE
11218 * search.c (simple_search): Remove unused var.
11219
dbd37a95
PE
11220 * dired.c (compile_pattern): Move decl from here ...
11221 * lisp.h: ... to here, so that it can be checked.
11222 (struct re_registers): New forward decl.
11223
7e47afad
PE
11224 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11225
85f24f61
PE
11226 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11227 All uses changed.
11228 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11229 Rename locals to avoid shadowing.
5671df8f 11230 (Fvertical_motion): Mark locals as initialized.
85f24f61 11231
181aa2be 11232 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11233 (casify_region): Mark local as initialized.
181aa2be 11234
930d429c
PE
11235 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11236
7082eac6
PE
11237 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11238 New macros, so that the caller can use some names other than
11239 gcpro1, gcpro2, etc.
11240 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11241 of the new macros.
11242 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11243 argument, for consistency with GCPRO2_VAR, etc: it is now the
11244 prefix of the variable, not the variable itself. All uses
11245 changed.
38b2c076
PE
11246 * dired.c (directory_files_internal, file_name_completion):
11247 Rename locals to avoid shadowing.
11248
15206ed9
PE
11249 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11250 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11251 dired.c's scmp function, had undefined behavior.
11252 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11253 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11254 * buffer.h: ... to here, because these macros use current_buffer,
11255 and the new implementation with inline functions needs to have
11256 current_buffer in scope now, rather than later when the macros
11257 are used.
11258 (downcase, upcase1): New static inline functions.
11259 (DOWNCASE, UPCASE1): Reimplement using these functions.
11260 This avoids undefined behavior in expressions like
11261 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11262 from race conditions in accessing the global variables
11263 case_temp1 and case_temp2.
11264 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11265 * lisp.h (case_temp1, case_temp2): Remove their decls.
11266 * character.h (ASCII_CHAR_P): Move from here ...
11267 * lisp.h: ... to here, so that the inline functions mentioned
11268 above can use them.
11269
4a6bea26
PE
11270 * dired.c (directory_files_internal_unwind): Now static.
11271
f14b7e14
PE
11272 * fileio.c (file_name_as_directory, directory_file_name):
11273 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11274 Now static.
2893f146
PE
11275 (file_name_as_directory): Use const pointers when appropriate.
11276 (Fexpand_file_name): Likewise. In particular, newdir might
11277 point at constant storage, so make it a const pointer.
fd4ead52 11278 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11279 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11280 signedness issues.
f839df0c
PE
11281 (Fset_file_times, Finsert_file_contents, auto_save_error):
11282 Rename locals to avoid shadowing.
f14b7e14 11283
5716756e 11284 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11285 (Ftry_completion, Fall_completions): Rename or remove locals
11286 to avoid shadowing.
5716756e 11287
b4c3046a
PE
11288 * marker.c (bytepos_to_charpos): Remove; unused.
11289
b45db522
PE
11290 * lisp.h (verify_bytepos, count_markers): New decls,
11291 so that gcc does not warn that these functions aren't declared.
11292
85876d07
PE
11293 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11294 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11295 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11296 (copy_text): Remove unused local var.
85876d07 11297
03d78a21 11298 * filelock.c (within_one_second): Now static.
b3dd38ab 11299 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11300
5df8f01b
PE
11301 * buffer.c (fix_overlays_before): Mark locals as initialized.
11302 (fix_start_end_in_overlays): Likewise. This function should be
11303 simplified by using pointers-to-pointers, but that's a different
11304 matter.
b1d876f1 11305 (switch_to_buffer_1): Now static.
8f54f30a
PE
11306 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11307 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11308
a70072c9 11309 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11310 Fix pointer signedness issue.
edced198
PE
11311 (sys_subshell): Mark local as volatile if checking for lint,
11312 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11313 (MAXPATHLEN): Define only if needed.
a70072c9 11314
a0977c44
PE
11315 * process.c (serial_open, serial_configure): Move decls from here ...
11316 * systty.h: ... to here, so that they can be checked.
11317
a884fdcc
PE
11318 * fns.c (get_random, seed_random): Move extern decls from here ...
11319 * lisp.h: ... to here, so that they can be checked.
11320
604efe86 11321 * sysdep.c (reset_io): Now static.
b8950c94 11322 (wait_for_termination_signal): Remove; unused.
604efe86 11323
38fc62d9
PE
11324 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11325 (copy_keymap_item, append_key, push_text_char_description):
11326 Now static.
1004a21a 11327 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11328 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11329 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11330 (describe_map_tree):
11331 Rename locals to avoid shadowing.
38fc62d9 11332
2f2650da
PE
11333 * keyboard.c: Declare functions static if they are not used elsewhere.
11334 (echo_char, echo_dash, cmd_error, top_level_2):
11335 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11336 (read_char, kbd_buffer_get_event, make_lispy_position):
11337 (make_lispy_event, make_lispy_movement, apply_modifiers):
11338 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11339 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11340 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11341 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11342 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11343
a053e86c 11344 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11345 (mark_kboards): Move decl here ...
11346 * alloc.c (mark_kboards): ... from here.
a053e86c 11347
4752793e
PE
11348 * lisp.h (force_auto_save_soon): New decl.
11349
74f10ca7 11350 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11351 (DEFINE_DUMMY_FUNCTION): New macro.
11352 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11353 Use it.
c03cd23f
PE
11354 (main): Add casts to avoid warnings
11355 if GCC considers string literals to be constants.
74f10ca7 11356
022e70d4
PE
11357 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11358
59d6fe83
PE
11359 * dbusbind.c: Pointer signedness fixes.
11360 (xd_signature, xd_append_arg, xd_initialize):
11361 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11362 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11363 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11364 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11365
78320123
PE
11366 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11367 if GCC considers string literals to be constants.
49cebcca 11368 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11369
35ac2a97
SM
113702011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11371
fb103ca9
SM
11372 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11373 (print_preprocess, print_object): New macro to fix last change.
11374
35ac2a97
SM
11375 * print.c (print_preprocess): Don't forget font objects.
11376
62973b41
JB
113772011-03-16 Juanma Barranquero <lekktu@gmail.com>
11378
11379 * emacs.c (USAGE3): Doc fixes.
11380
0e48bb22
AS
113812011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11382
11383 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11384 structure.
11385
7684e57b
JB
113862011-03-14 Juanma Barranquero <lekktu@gmail.com>
11387
11388 * lisp.h (VWindow_system, Qfile_name_history):
11389 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11390 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11391 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11392
11393 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11394 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11395
11396 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11397 * w32console.c (detect_input_pending, read_input_pending)
11398 (encode_terminal_code):
11399 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11400 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11401 (w32_system_caret_y, Qfile_name_history):
11402 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11403 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11404 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11405 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11406 * w32proc.c (Qlocal, report_file_error):
11407 * w32term.c (Vwindow_system, updating_frame):
11408 * w32uniscribe.c (initialized, uniscribe_font_driver):
11409 Remove unneeded extern declarations.
11410
2aa46d6c
CY
114112011-03-14 Chong Yidong <cyd@stupidchicken.com>
11412
c96bbc66 11413 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11414
cffc6f3b
CY
114152011-03-13 Chong Yidong <cyd@stupidchicken.com>
11416
11417 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11418 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11419 These macros can no longer be used for assignment.
11420
44f230aa
SM
11421 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11422 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11423 (record_buffer_markers, fetch_buffer_markers): New functions for
11424 recording and fetching special buffer markers.
11425 (set_buffer_internal_1, set_buffer_temp): Use them.
11426
11427 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11428
11429 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11430
11431 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11432 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11433
11434 * xdisp.c (hscroll_window_tree):
11435 (reconsider_clip_changes): Use PT instead of BUF_PT.
11436
d251f04b
EZ
114372011-03-13 Eli Zaretskii <eliz@gnu.org>
11438
11439 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11440 $(EMACS_ROOT)/lib/intprops.h.
11441
f0c77cd1
PE
114422011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11443
3eca4629
PE
11444 Fix more problems found by GCC 4.5.2's static checks.
11445
7c86ee98
PE
11446 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11447 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11448 (xg_free_frame_widgets): Make it clear that a local variable is
11449 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11450 (gdk_window_get_screen): Make it clear that this macro is needed
11451 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11452 (int_gtk_range_get_value): New function, which avoids a diagnostic
11453 from gcc -Wbad-function-cast.
11454 (xg_set_toolkit_scroll_bar_thumb): Use it.
11455 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11456 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11457 (get_utf8_string, xg_get_file_with_chooser):
11458 Rename locals to avoid shadowing.
11459 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11460
41729b81
PE
11461 * xgselect.c (xg_select): Remove unused var.
11462
f0c77cd1
PE
11463 * image.c (four_corners_best): Mark locals as initialized.
11464 (gif_load): Initialize transparent_p to zero (Bug#8238).
11465 Mark another local as initialized.
ec6cf4c6 11466 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11467
ce0ad53d 11468 * image.c (clear_image_cache): Now static.
d5d5a617 11469 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11470 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11471 (x_edge_detection): Remove unnecessary cast that
11472 gcc -Wbad-function-cast diagnoses.
2037898d 11473 (gif_load): Fix pointer signedness.
6ae141d6
PE
11474 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11475 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11476
33383987 114772011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11478
d32df629
PE
11479 Improve quality of tests for time stamp overflow.
11480 For example, without this patch (encode-time 0 0 0 1 1
11481 1152921504606846976) returns the obviously-bogus value (-948597
11482 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11483 reports time overflow. See
11484 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11485 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11486 * editfns.c: Include limits.h and intprops.h.
11487 (TIME_T_MIN, TIME_T_MAX): New macros.
11488 (time_overflow): Move earlier, to before first use.
11489 (hi_time, lo_time): New functions, for an accurate test for
11490 out-of-range times.
11491 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11492 (Fget_internal_run_time): Don't assume time_t fits in int.
11493 (make_time): Use list2 instead of Fcons twice.
11494 (Fdecode_time): More accurate test for out-of-range times.
11495 (check_tm_member): New function.
11496 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11497 (lisp_time_argument): Don't rely on undefined left-shift and
11498 right-shift behavior when checking for time stamp overflow.
8be6f318 11499
fe31d94c
PE
11500 * editfns.c (time_overflow): New function, refactoring common code.
11501 (Fformat_time_string, Fdecode_time, Fencode_time):
11502 (Fcurrent_time_string): Use it.
11503
8be6f318
PE
11504 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11505 * dired.c (make_time): Move to ...
11506 * editfns.c (make_time): ... here.
11507 * systime.h: Note the move.
11508
09d9db2c 115092011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11510
126bc0dc
YM
11511 * fringe.c (update_window_fringes): Remove unused variables.
11512
c47cbdfd
YM
11513 * unexmacosx.c (copy_data_segment): Also copy __got section.
11514 (Bug#8223)
11515
7ac80be9
EZ
115162011-03-12 Eli Zaretskii <eliz@gnu.org>
11517
c96bbc66 11518 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11519 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11520 Constify `char *' arguments and their references according to
11521 prototypes in tparam.h.
11522
ecb0f94d 11523 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11524
7ac80be9
EZ
11525 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11526 Adapt all references accordingly.
11527
11528 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11529
ef1fd07e
TT
115302011-03-11 Tom Tromey <tromey@redhat.com>
11531
11532 * buffer.c (syms_of_buffer): Remove obsolete comment.
11533
7ef4b50c
EZ
115342011-03-11 Eli Zaretskii <eliz@gnu.org>
11535
11536 * termhooks.h (encode_terminal_code): Declare prototype.
11537
11538 * msdos.c (encode_terminal_code): Don't declare prototype.
11539
11540 * term.c (encode_terminal_code): Now external again, used by
11541 w32console.c and msdos.c.
11542
44f230aa
SM
11543 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11544 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11545
4b1ec863 115462011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11547
1714f52b 11548 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11549
4b1ec863
PE
11550 * fringe.c (update_window_fringes): Mark locals as initialized
11551 (Bug#8227).
11552 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11553
524c7aa6
PE
11554 * alloc.c (mark_fringe_data): Move decl from here ...
11555 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11556 to check its interface.
11557 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11558
a5c0af81 11559 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11560 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11561 (fontset_font): Mark local as initialized.
a9a06e0b 11562 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11563
b4716021
PE
11564 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11565
811e9bac 11566 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11567 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11568 (x_own_selection, Fx_disown_selection_internal): Rename locals
11569 to avoid shadowing.
11570 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11571
7e3ab302
PE
11572 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11573 so that the caller can use some name other than gcpro1.
11574 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11575 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11576 (Fx_backspace_delete_keys_p):
11577 Use them to avoid shadowing, and rename vars to avoid shadowing.
11578 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11579 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11580 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11581 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11582 Remove unused locals.
7e3ab302
PE
11583 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11584 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11585 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11586 macros.
f78faa98 11587
e2b13473
PE
11588 * xterm.h (x_mouse_leave): New decl.
11589
77f23912
PE
11590 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11591 Remove unused functions.
cdf4ba58
PE
11592 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11593 (x_calc_absolute_position): Now static.
7411c686 11594 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11595 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11596 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11597 unless they are used.
38d0b34a
PE
11598 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11599 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11600 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11601 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11602 (x_error_catcher, x_connection_closed, x_error_handler):
11603 (x_error_quitter, xembed_send_message, x_iconify_frame):
11604 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11605 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11606 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11607
44f230aa
SM
11608 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11609 Rename or move locals to avoid shadowing.
6b463e58 11610 (tty_defined_color, merge_face_heights): Now static.
5967d051 11611 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11612 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11613 does not deduce is never used uninitialized.
73719eba
PE
11614 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11615 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11616
426994c3 11617 * terminal.c (store_terminal_param): Now static.
5489860b 11618
032f1620 11619 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11620 (set_frame_menubar): Remove unused local.
d4323972 11621 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11622 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11623 since they might point to immutable storage.
281585b0
PE
11624 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11625 since it's unused otherwise.
032f1620 11626
367c19e5 11627 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11628 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11629 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11630 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11631 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11632 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11633 does not deduce are never used uninitialized.
70739cbe 11634
07b48fa9
PE
11635 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11636
8868a238 11637 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11638 * window.c (window_loop, size_window):
11639 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11640
7e5cf297 11641 * window.c (display_buffer): Now static.
d6550a9f
PE
11642 (size_window): Mark variables that gcc -Wuninitialized
11643 does not deduce are never used uninitialized.
a586633d
PE
11644 * window.h (check_all_windows): New decl, to forestall
11645 gcc -Wmissing-prototypes diagnostic.
5b555da1 11646 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11647
f6095868
PE
11648 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11649 shadowing.
11650 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11651 Include <limits.h>.
11652 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11653 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11654 (load_charset_map): Mark variables that gcc -Wuninitialized
11655 does not deduce are never used uninitialized.
53df7c11 11656 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11657
f38b440c
PE
11658 * coding.c (coding_set_source, coding_set_destination):
11659 Use "else { /* comment */ }" rather than "else /* comment */;"
11660 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11661 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11662 a block, when the outer 'i' will do.
11663 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11664 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11665 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11666 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11667 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11668 Rename locals to avoid shadowing.
11669 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11670 * coding.c (emacs_mule_char, encode_invocation_designation):
11671 Now static, since they're not used elsewhere.
413bb2db 11672 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11673 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11674 (decode_coding_emacs_mule): Mark variables that gcc
11675 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11676 (detect_coding_iso_2022): Initialize a local variable that might
11677 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11678 this initialization is needed. (Bug#8211)
5f58e762
PE
11679 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11680 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11681 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11682 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11683 Remove unused macros.
f38b440c 11684
232b38b9 11685 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11686 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11687 * character.c (string_count_byte8): Likewise.
232b38b9 11688
fb90da1b
PE
11689 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11690 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11691
fb93dbc2
PE
11692 * chartab.c (copy_sub_char_table): Now static, since it's not used
11693 elsewhere.
5c156ace
PE
11694 (sub_char_table_ref_and_range, char_table_ref_and_range):
11695 Rename locals to avoid shadowing.
bbcd0949 11696 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11697
7d3b3862 11698 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11699 (BIDI_BOB): Remove unused macro.
7d3b3862 11700
6be7d3da
PE
11701 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11702 deduce are never used uninitialized.
c2ed9c8b 11703 * term.c (encode_terminal_code): Likewise.
6be7d3da 11704
75f8807f 11705 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11706
50938595
PE
11707 * tparam.h: New file.
11708 * term.c, tparam.h: Include it.
11709 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11710 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11711 Move these decls to tparam.h, and make them agree with what
11712 is actually in tparam.c. The previous trick of using incompatible
11713 decls in different modules does not conform to the C standard.
11714 All callers of tparam changed to use tparam's actual API.
11715 * tparam.c (tparam1, tparam, tgoto):
11716 Use const pointers where appropriate.
11717
fbceeba2
PE
11718 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11719 * cm.h (struct cm): Likewise.
11720 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11721 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11722 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11723 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11724 (turn_on_face, init_tty): Likewise.
11725 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11726
7f3f1250
PE
11727 * term.c (term_mouse_position): Rename local to avoid shadowing.
11728
e6ca6543
PE
11729 * alloc.c (mark_ttys): Move decl from here ...
11730 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11731
c40f8d15
AS
117322011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11733
11734 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11735
cfe0661d
JB
117362011-03-09 Juanma Barranquero <lekktu@gmail.com>
11737
11738 * search.c (compile_pattern_1): Remove argument regp, unused since
11739 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11740 (compile_pattern): Don't pass it.
11741
0afb4571
J
117422011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11743
11744 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11745 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11746 for ! HAVE_GTK3.
11747 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11748
11749 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11750
11751 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11752 gdk_window_get_screen, gdk_window_get_geometry,
11753 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11754 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11755 (xg_get_pixbuf_from_pixmap): New function.
11756 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11757 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11758 Call xg_get_pixbuf_from_pixmap instead of
11759 gdk_pixbuf_get_from_drawable.
11760 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11761 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11762 (xg_check_special_colors): Use GtkStyleContext and its functions
11763 for HAVE_GTK3.
11764 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11765 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11766 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11767 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11768 Call gtk_widget_get_preferred_size.
0afb4571
J
11769 (xg_frame_resized): gdk_window_get_geometry only takes 5
11770 parameters.
44f230aa
SM
11771 (xg_win_to_widget, xg_event_is_for_menubar):
11772 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11773 (xg_set_widget_bg): New function.
11774 (delete_cb): New function.
895009e1 11775 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11776 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11777 (xg_set_background_color): Call xg_set_widget_bg.
11778 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11779 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11780 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11781 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11782 if ! HAVE_GTK3.
11783 (update_frame_tool_bar): Call gtk_widget_hide.
11784 (xg_initialize): Use GDK_KEY_g.
11785
11786 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11787 if ! HAVE_GTK3
11788 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11789
11790 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11791 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11792 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11793
1c2cc4ef
JB
117942011-03-08 Juanma Barranquero <lekktu@gmail.com>
11795
11796 * w32xfns.c (select_palette): Check success of RealizePalette against
11797 GDI_ERROR, not zero.
11798
33383987 11799See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11800
11801;; Local Variables:
11802;; coding: utf-8
aac0c6e3
MR
11803;; End:
11804
2f097256 11805 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11806
11807 This file is part of GNU Emacs.
11808
11809 GNU Emacs is free software: you can redistribute it and/or modify
11810 it under the terms of the GNU General Public License as published by
11811 the Free Software Foundation, either version 3 of the License, or
11812 (at your option) any later version.
11813
11814 GNU Emacs is distributed in the hope that it will be useful,
11815 but WITHOUT ANY WARRANTY; without even the implied warranty of
11816 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11817 GNU General Public License for more details.
11818
11819 You should have received a copy of the GNU General Public License
11820 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.