Standardize on VIRT_ADDR_VARIES behavior.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
615a3b8d 12011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 2
17e845af
PE
3 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4 Otherwise, valgrind does not work on some platforms.
5 Problem reported by Andreas Schwab in
6a0bf43d
PE
6 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
7 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
8 is set, removing the need for VIRT_ADDRESS_VARIES.
9 (PURE_P): Use a more-efficient implementation that needs just one
10 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
11 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
12 to 4 (xorl, subq, cmpq, setbe).
13 * alloc.c (pure): Always extern now, since that's the
14 VIRT_ADDR_VARIES behavior.
15 (PURE_POINTER_P): Use a single comparison, not two, for
16 consistency with the new puresize.h.
17 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
18 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
19 Remove VIRT_ADDR_VARIES no longer needed.
20
f8fe6f96
EZ
212011-11-19 Eli Zaretskii <eliz@gnu.org>
22
23 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
24 (erase_phys_cursor, update_window_cursor, show_mouse_face)
25 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
26 behave as if the cursor position were at the window margin.
27
28 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
29 and the cursor position is out of bounds, behave as if the cursor
30 position were at the window margin. (Bug#10075)
31
df05a53c
CY
322011-11-18 Chong Yidong <cyd@gnu.org>
33
34 * window.c (Fwindow_combination_limit): Make first argument
35 non-optional, since it is meaningless for live windows like the
36 selected window.
37
2071918e
DA
382011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
39
40 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
41
b50a28de
SM
422011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
43
44 * intervals.c: Fix grafting over the whole buffer (bug#10071).
45 (graft_intervals_into_buffer): Simplify.
46
015137db
EZ
472011-11-18 Eli Zaretskii <eliz@gnu.org>
48
49 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
50 hash values of the two rows.
51 (copy_row_except_pointers): Preserve the used[] arrays and the
52 hash values of the two rows. (Bug#10035)
68c95424 53 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
54
55 * xdisp.c (row_hash): New function, body extracted from
56 compute_line_metrics.
57 (compute_line_metrics): Call row_hash, instead of computing the
58 hash code inline.
59
60 * dispnew.c (verify_row_hash): Call row_hash for computing the
61 hash code of a row, instead of duplicating code from xdisp.c.
62
63 * dispextern.h (row_hash): Add prototype.
64
a2addb04
TH
652011-11-18 Tassilo Horn <tassilo@member.fsf.org>
66
67 * frame.c (delete_frame): Don't delete the terminal when the last
68 X frame is closed if emacs is built with GTK toolkit.
69
df85d315
JB
702011-11-17 Juanma Barranquero <lekktu@gmail.com>
71
72 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
73
a0c2d0ae
MR
742011-11-17 Martin Rudalics <rudalics@gmx.at>
75
76 * window.c (Vwindow_splits): Rename to
77 Vwindow_combination_resize. Suggested by Juri Linkov.
78 (Fsplit_window_internal): Use Vwindow_combination_resize instead
79 of Vwindow_splits.
80
58179cce
JB
812011-11-16 Juanma Barranquero <lekktu@gmail.com>
82
7877f373
JB
83 * nsfns.m (Fns_font_name):
84 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 85
b6f67890
MR
862011-11-16 Martin Rudalics <rudalics@gmx.at>
87
88 * window.h (window): Rename slot "nest" to "combination_limit".
89 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
90 (Fset_window_nest): Rename to Fset_window_combination_limit.
91 (Vwindow_nest): Rename to Vwindow_combination_limit.
92 (recombine_windows, make_parent_window, make_window)
93 (Fsplit_window_internal, saved_window)
94 (Fset_window_configuration, save_window_save): Rename all
95 occurrences of window_nest to window_combination_limit.
96
c7015153
JB
972011-11-15 Juanma Barranquero <lekktu@gmail.com>
98
99 * image.c (imagemagick_load_image): Fix typo.
100
322ad6ec
EZ
1012011-11-14 Eli Zaretskii <eliz@gnu.org>
102
103 * xdisp.c (display_line): Move the call to
104 highlight_trailing_whitespace before the call to
105 compute_line_metrics, since the latter needs to see the final
106 faces of all the glyphs to compute ROW's hash value. Fixes
107 assertion violations in row_equal_p. (Bug#10035)
108
f067b8ec
JB
1092011-11-14 Juanma Barranquero <lekktu@gmail.com>
110
111 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
112 just return (bug#10044).
113
1e5b2111
EZ
1142011-11-12 Eli Zaretskii <eliz@gnu.org>
115
7ef3cbd5
EZ
116 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
117 with user-defined heap size. Bump the default size of the temacs
118 heap to 27MB, to avoid memory warning when running temacs.
119 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
120
1e5b2111
EZ
121 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
122 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
123 (verify_row_hash) [XASSERTS]: New function.
124 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
125 that the hash value of glyph rows is correct.
1e5b2111 126
89d61221
MR
1272011-11-12 Martin Rudalics <rudalics@gmx.at>
128
129 * window.h (window): Remove splits slot.
130 * window.c (Fwindow_splits, Fset_window_splits): Remove.
131 (Fdelete_other_windows_internal, make_parent_window)
132 (make_window, Fsplit_window_internal, Fdelete_window_internal)
133 (Fset_window_configuration, save_window_save): Don't deal with
134 split status of windows.
135 (saved_window): Remove splits slot.
136 (Vwindow_splits): Rewrite doc-string.
137
97f18cc8
JD
1382011-11-11 Jan Djärv <jan.h.d@swipnet.se>
139
140 * xfns.c (unwind_create_frame):
141 * nsfns.m (unwind_create_frame):
142 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
143 Vframe_list (Bug#9999).
144
22a648b4
DA
1452011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
146
0b381c7e 147 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 148
659afede
KH
1492011-11-11 Kenichi Handa <handa@m17n.org>
150
151 * callproc.c (Fcall_process): Set the member dst_multibyte of
152 process_coding.
153
9ac0394b
KH
1542011-11-11 Johan Bockgård <bojohan@gnu.org>
155
156 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
157 avoid a crash (bug#9496).
158
2fbdc249
CY
1592011-11-09 Chong Yidong <cyd@gnu.org>
160
161 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
162 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
163
ac6b1f81
PE
1642011-11-08 Paul Eggert <eggert@cs.ucla.edu>
165
166 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
167
09db192c
PE
1682011-11-08 Paul Eggert <eggert@cs.ucla.edu>
169
170 Avoid some portability problems by eschewing 'extern inline' functions.
171 The trivial performance wins aren't worth the portability hassles; see
172 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
173 et seq.
174 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
175 (window_box_width, window_box_left, window_box_left_offset)
176 (window_box_right, window_box_right_offset): Undo previous change,
177 by removing the "extern"s.
178 * intervals.c (adjust_intervals_for_insertion)
179 (adjust_intervals_for_deletion): Undo previous change,
180 making these static again.
181 (offset_intervals, temp_set_point_both, temp_set_point)
182 (copy_intervals_to_string): No longer inline.
183 * xdisp.c (window_text_bottom_y, window_box_width)
184 (window_box_height, window_box_left_offset)
185 (window_box_right_offset, window_box_left, window_box_right)
186 (window_box): No longer inline.
187
105216ed
CY
1882011-11-08 Chong Yidong <cyd@gnu.org>
189
190 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
191 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
192 an error if not a live window.
193 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
194 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
195
ae9e237f
JB
1962011-11-07 Juanma Barranquero <lekktu@gmail.com>
197
198 * lisp.h (syms_of_abbrev): Remove declaration.
199 Reported by CHENG Gao <chenggao@royau.me>.
200
c7aa8333
EZ
2012011-11-07 Eli Zaretskii <eliz@gnu.org>
202
203 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
204 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
205 of temacs in GUI mode.
206
be7f5545
MR
2072011-11-07 Martin Rudalics <rudalics@gmx.at>
208
209 * window.h: Declare delete_all_child_windows instead of
210 delete_all_subwindows.
211 * window.c (Fwindow_nest, Fset_window_nest)
212 (Fset_window_new_total, Fset_window_new_normal)
213 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
214 (delete_all_subwindows): Rename to delete_all_child_windows.
215 (Fdelete_other_windows_internal, Fset_window_configuration):
216 Call delete_all_child_windows instead of delete_all_subwindows.
217 * frame.c (delete_frame): Call delete_all_child_windows instead
218 of delete_all_subwindows.
219
ca78dc43
PE
2202011-11-07 Paul Eggert <eggert@cs.ucla.edu>
221
222 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
223 This is also needed for porting to any host where GC_MARK_STACK is
224 not GC_MAKE_GCPROS_NOOPS.
225 (which_symbols): Use it.
226
a0241d01
KH
2272011-11-07 Kenichi Handa <handa@m17n.org>
228
229 * coding.c (coding_set_destination): Check coding->src_pos only
230 when coding->src_object is a buffer (bug#9910).
231
232 * process.c (send_process): Set the member src_multibyte of coding
233 to 0 (bug#9911) when sending a unibyte text.
234
235 * callproc.c (Fcall_process): Set the member src_multibyte of
236 process_coding to 0 (bug#9912).
237
a64bfdfa 2382011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
239
240 * xmenu.c (cleanup_widget_value_tree): New function.
241 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
242 calling free_menubar_widget_value_tree directly (Bug#9830).
243
cb41b32a
PE
2442011-11-06 Paul Eggert <eggert@cs.ucla.edu>
245
246 Fix some portability problems with 'inline'.
247 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
248 (window_box_width, window_box_left, window_box_left_offset)
249 (window_box_right, window_box_right_offset): Declare extern.
250 Otherwise, these inline functions do not conform to C99 and
251 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
252 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
253 * intervals.c (adjust_intervals_for_insertion)
254 (adjust_intervals_for_deletion): Now extern, because otherwise the
255 extern inline functions 'offset_intervals' couldn't refer to it.
256 (static_offset_intervals): Remove.
257 (offset_intervals): Rewrite using the old contents of
258 static_offset_intervals. The old version didn't conform to C99
259 because an extern inline function contained a reference to an
260 identifier with static linkage.
261
b7041366
AS
2622011-11-06 Andreas Schwab <schwab@linux-m68k.org>
263
264 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
265 GC.
266
88a37c4d
EZ
2672011-11-06 Eli Zaretskii <eliz@gnu.org>
268
269 * xdisp.c (init_iterator, reseat_to_string): Don't set the
270 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
271 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
272 return Qleft_to_right.
273
49745b39
CY
2742011-11-06 Chong Yidong <cyd@gnu.org>
275
276 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
277 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
278 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
279 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
280 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
281 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
282 (Fwindow_vscroll): Doc fix.
283 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
284 argument, since it makes no sense to pass a live window and for
285 consistency with window-child.
286
1f05cd82
CS
2872011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
288
289 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
290 support MSVC.
291
22610910
JR
2922011-11-05 Jason Rumney <jasonr@gnu.org>
293
294 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
295 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
296 fonts (Bug#6029).
297 (add_font_entity_to_list): Fix logic errors in mixed boolean and
298 bitwise arithmetic preventing use of unicode-sip and non-truetype
299 opentype fonts.
300
a06776b2
EZ
3012011-11-05 Eli Zaretskii <eliz@gnu.org>
302
3ad924ba
EZ
303 * s/ms-w32.h (fstat, stat, utime): Move redirections to
304 "emacs"-only part.
305
a06776b2
EZ
306 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
307 initialization code to keep similarity to xfns.c after changes
308 from 2011-11-05.
309
c9e7db78
JD
3102011-11-05 Jan Djärv <jan.h.d@swipnet.se>
311
a97f8f3f
JD
312 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
313 (unwind_create_frame): New function (Bug#9943).
314 (Fx_create_frame): Restructure code to be more similar to the one in
315 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
316 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
317 Move terminal->reference_count++ just before making the frame official
318 (Bug#9943).
319
320 * nsterm.m (x_free_frame_resources): New function.
321 (x_destroy_window): Move code to x_free_frame_resources.
322
c9e7db78
JD
323 * xfns.c (unwind_create_frame): Fix comment.
324 (Fx_create_frame, x_create_tip_frame): Move
325 terminal->reference_count++ just before making the frame
326 official. Move initialization of image_cache_refcount and
327 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
328
a6fc3b5c
EZ
3292011-11-05 Eli Zaretskii <eliz@gnu.org>
330
331 Support MSVC build with newer versions of Visual Studio.
332 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
333 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
334 nt/gmake.defs.
335
336 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
337 which are not supported by MSVC.
338 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
339 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
340 bitfields.
341 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
342 types in bitfields.
343 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
344
345 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
346
58179cce 3472011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
348
349 Support MSVC build with newer versions of Visual Studio.
350 * w32.c: Don't include w32api.h for MSVC.
351 (init_environment) [_MSC_VER]: Call sys_access, not _access.
352
353 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
354 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
355 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
356 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
357 e_* cousins.
358 (alloca) [_MSC_VER]: Define to _alloca.
359
360 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
361
362 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
363
a58c13ed
EZ
3642011-11-04 Eli Zaretskii <eliz@gnu.org>
365
366 * xdisp.c (note_mouse_highlight): If either of
367 previous/next-single-property-change returns nil, treat that as
368 the beginning or the end of the buffer. (Bug#9955)
369
fe0b6370
JD
3702011-11-04 Jan Djärv <jan.h.d@swipnet.se>
371
a58c13ed 372 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
373 label is not null (Bug#9951).
374 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
375 may be NULL.
376
89bd5ee1
EZ
3772011-11-04 Eli Zaretskii <eliz@gnu.org>
378
379 * window.c (Fwindow_body_size): Mention in the doc string that the
380 return value is in frame's canonical units. (Bug#9949)
381
84c3edb9
EZ
3822011-11-03 Eli Zaretskii <eliz@gnu.org>
383
4e2fb5c7
EZ
384 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
385
84c3edb9 386 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 387 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 388 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 389
bc17a887
EZ
3902011-11-01 Eli Zaretskii <eliz@gnu.org>
391
392 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
393 Don't stop backward scan on the continuation glyph, even though
394 its CHARPOS is positive.
26b46e51
EZ
395 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
396 cover_string to disp_string.
bc17a887 397
4ee88440
MR
3982011-11-01 Martin Rudalics <rudalics@gmx.at>
399
400 * window.c (temp_output_buffer_show): Don't use
401 Vtemp_buffer_show_specifiers.
402 (Vtemp_buffer_show_specifiers): Remove unused variable.
403
c2ff3c02
EZ
4042011-10-30 Eli Zaretskii <eliz@gnu.org>
405
406 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
407 past the beginning of the current glyph matrix.
408
58179cce 4092011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
410
411 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
412 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
413 HAVE_GTK3 (Bug#9869).
b77a6a7f 414
3b574623
JD
415 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
416 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
417
b77a6a7f
JD
418 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
419
420 * xterm.c: Declare x_handle_net_wm_state to return int.
421 (handle_one_xevent): Check if we are iconified but don't have
422 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
423 (get_current_wm_state): Return non-zero if not hidden,
424 check for _NET_WM_STATE_HIDDEN (Bug#9893).
425 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
426 (x_handle_net_wm_state): Return what get_current_wm_state returns.
427 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
428
196e41e4
PE
4292011-10-29 Paul Eggert <eggert@cs.ucla.edu>
430
431 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
432 so that this new function doesn't get optimized away by a
433 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
434
021f2e1a
AS
4352011-10-29 Andreas Schwab <schwab@linux-m68k.org>
436
437 * frame.h (MOUSE_HL_INFO): Remove excess parens.
438
8b058d44
EZ
4392011-10-29 Eli Zaretskii <eliz@gnu.org>
440
441 Fix the `xbytecode' command.
442 * .gdbinit (xprintbytestr): New command.
b50a28de 443 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
444 (xbytecode): Print the byte-code string as well.
445
4452fb80
EZ
4462011-10-29 Kim Storm <storm@cua.dk>
447
8b058d44
EZ
448 * alloc.c (which_symbols): New function.
449
21b72067
AS
4502011-10-29 Andreas Schwab <schwab@linux-m68k.org>
451
452 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
453 line. (Bug#9903)
454
83ed7b5c
GM
4552011-10-29 Glenn Morris <rgm@gnu.org>
456
457 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
458 Not clear what it was for, and it causes various bugs. (Bug#9839)
459
5a7a728b
EZ
4602011-10-28 Eli Zaretskii <eliz@gnu.org>
461
462 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
463 possible random value that matches one of those tested as
464 condition to clear the mouse face.
465
d3d0842f
CY
4662011-10-28 Chong Yidong <cyd@gnu.org>
467
468 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
469
31b39d13
DN
4702011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
471
472 * window.c (make_window): Initialize phys_cursor_on_p.
473
9aba6043
SM
4742011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
475
476 * lisp.h (struct Lisp_Symbol): Update comments.
477
c20992f4
JB
4782011-10-28 Juanma Barranquero <lekktu@gmail.com>
479
480 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
481
db4f02f2
EZ
4822011-10-28 Eli Zaretskii <eliz@gnu.org>
483
484 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
485 <oslsachem@gmail.com> for helping to debug this.
486
487 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
488 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
489 (g_b_init_get_glyph_outline_w): New static variables.
490 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
491 (GetGlyphOutlineW_Proc): New typedefs.
492 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
493 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
494 New functions.
495 (w32font_open_internal, compute_metrics):
496 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
497 instead of calling the "wide" APIs directly.
498
499 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
500
501 * w32.h (syms_of_w32font): Add prototype.
502
87e68db4
JB
5032011-10-27 Juanma Barranquero <lekktu@gmail.com>
504
505 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
506 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
507 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
508 (Fmove_to_window_line): Doc fix.
509
435c1d67
CY
5102011-10-27 Chong Yidong <cyd@gnu.org>
511
512 * process.c (make_process): Set gnutls_state to NULL.
513
514 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
515 non-NULL, regardless of GNUTLS_INITSTAGE.
516 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
517 an error. Set process slots as soon as we allocate them.
518
519 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
520
9c6c6f49
CY
5212011-10-27 Chong Yidong <cyd@gnu.org>
522
9aba6043
SM
523 * gnutls.c (emacs_gnutls_deinit): New function.
524 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
525 (Fgnutls_deinit, Fgnutls_boot): Use it.
526
527 * process.c (make_process): Initialize GnuTLS credentials to NULL.
528 (deactivate_process): Call emacs_gnutls_deinit.
529
657d08d3
JB
5302011-10-27 Juanma Barranquero <lekktu@gmail.com>
531
532 * image.c (x_create_x_image_and_pixmap):
533 * w32.c (sys_rename, w32_delayed_load):
534 * w32font.c (fill_in_logfont):
535 * w32reg.c (x_get_string_resource): Silence compiler warnings.
536
5430d399
JB
5372011-10-26 Juanma Barranquero <lekktu@gmail.com>
538
539 * w32fns.c (w32_default_color_map): New function,
540 extracted from Fw32_default_color_map.
a7ef684b 541 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 542
fe0055fa
PE
5432011-10-25 Paul Eggert <eggert@cs.ucla.edu>
544
545 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
546
e6346438
SM
5472011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
548
549 * keyboard.c (test_undefined): New function (bug#9751).
550 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
551
e112cc37
ET
5522011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
553
554 * sysdep.c (init_sys_modes): Fix the check for the controlling
555 terminal (Bug#6649).
556
7b5d6677
EZ
5572011-10-20 Eli Zaretskii <eliz@gnu.org>
558
559 * dispextern.h (struct bidi_it): New member next_en_type.
560
561 * bidi.c (bidi_line_init): Initialize the next_en_type member.
562 (bidi_resolve_explicit_1): When next_en_pos is valid for the
563 current character, check also for next_en_type being WEAK_EN.
564 (bidi_resolve_weak): Don't enter the expensive loop if the current
565 position is before next_en_pos. Record the bidi type of the first
566 non-ET, non-BN character we find, in addition to its position.
567 (bidi_level_of_next_char): Invalidate next_en_type when
568 next_en_pos is over-stepped.
569
7da0b018
PE
5702011-10-20 Paul Eggert <eggert@cs.ucla.edu>
571
572 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
573 * editfns.c: Rewrite current-time-zone so that it invokes
574 the equivalent of (format-time-string "%Z") to get the time zone name.
575 This fixes a bug when the time zone name contains characters that
576 need converting from the system time locale to Emacs internal format.
577 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
578 that patch fixed format-time-string to do the conversion, but
579 I forgot to fix current-time-zone.
580 (format_time_string): New function, containing most of
581 what Fformat_time_string used to contain.
582 (Fformat_time_string): Rewrite in terms of format_time_string.
583 This doesn't change this function's behavior.
584 (current-time-zone): Rewrite to use format_time_string.
585 This fixes the bug reported by Michael Schierl in
586 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
587 Jason Rumney's 2007-06-07 change worked around this bug, but
588 didn't fix it.
589 * systime.h (tzname, timezone): Remove no-longer-used declarations.
590
8547b010
EZ
5912011-10-19 Eli Zaretskii <eliz@gnu.org>
592
593 * xdisp.c (start_display): If the character at POS is displayed
594 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
595 (try_window_reusing_current_matrix): If a line ends in a display
596 vector or the next line starts in a display vector, continue
597 redrawing the window even though the character position of
598 start_row was reached.
8547b010
EZ
599 (Bug#9771, part 2)
600
4e948d15
CY
6012011-10-18 Chong Yidong <cyd@gnu.org>
602
603 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
604 with nobreak-char-display too.
605
4787455f
EZ
6062011-10-18 Eli Zaretskii <eliz@gnu.org>
607
608 Fix part 3 of bug#9771.
609 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
610 (bidi_resolve_neutral): Don't enter the expensive loop looking for
611 non-neutral characters if the current character is a paragraph
612 separator (a.k.a. Newline). This avoids running the same
613 expensive loop twice, once when we consume the preceding newline
614 and the other time when the line actually needs to be displayed.
615 Avoid the loop when we see neutrals on the base embedding level
616 following a character whose directionality is the same as the
617 paragraph's. This avoids running the expensive loop when a line
618 ends in a long sequence of neutrals, like control characters.
619 Add assertion against STRONG_AL type. Slightly rearrange code
620 that determines the type of a neutral given the first non-neutral
621 that follows it.
622 (bidi_level_of_next_char): Set next_en_pos to zero when
623 invalidating its info.
624
2c91f553
EZ
6252011-10-17 Eli Zaretskii <eliz@gnu.org>
626
627 * xdisp.c (push_display_prop): Determine whether to record string
628 or buffer position by IT->string, not by IT->method. Allow
629 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
630 (move_it_vertically_backward): Don't look for character position
631 immediately after the newline when in a continuation line.
632 (Bug#9771, part 1)
2c91f553 633
c7b08b0d
MR
6342011-10-15 Martin Rudalics <rudalics@gmx.at>
635
636 * window.c (coordinates_in_window): Rewrite and delabelize
637 vertical border check. (Bug#5357) (Bug#9618)
638
6b02f655
SM
6392011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
640
641 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
642 errors in XSetWindowBorder (bug#9310).
643
81d40c92
DA
6442011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
645
646 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
647 avoid crash when xmalloc overrun checking is enabled.
648
d4172c3b
EZ
6492011-10-13 Eli Zaretskii <eliz@gnu.org>
650
651 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
652 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
653 cursor motion with <left> and <right> arrow keys.
654
655 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
656 some callers set that themselves.
657
b00eea75
EZ
6582011-10-12 Eli Zaretskii <eliz@gnu.org>
659
660 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
661 display string and the previous row comes from the same string and
662 is empty. (Bug#9739) (Bug#9738)
663
8fe012c4
SM
6642011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
665
666 * doc.c (get_doc_string): Encode file name (bug#9735).
667
0074aef2
EZ
6682011-10-12 Eli Zaretskii <eliz@gnu.org>
669
79beb178
EZ
670 * bidi.c (bidi_level_of_next_char):
671 * xdisp.c (get_visually_first_element): Remove old incorrect
672 comments regarding the Unicode Line Separator character.
673
0074aef2
EZ
674 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
675
6e4b3fbe
DA
6762011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
677
678 * alloc.c (Fgc_status): Do not access beyond zombies array
679 boundary if nzombies > MAX_ZOMBIES.
680 * alloc.c (dump_zombies): Add missing format specifier.
681
0324f3af
PE
6822011-10-12 Paul Eggert <eggert@cs.ucla.edu>
683
b5525cac
PE
684 * xdisp.c (set_cursor_from_row): Simplify conditionals,
685 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
686
0324f3af
PE
687 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
688 Some packages use them to denote characters with modifiers.
689
e9b5f888
AS
6902011-10-11 Andreas Schwab <schwab@linux-m68k.org>
691
692 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
693 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
694 matching a pp-number. Rename parameter var to var1.
695
127827c0
SM
6962011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
697
698 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
699
c8fd3bd0
GM
7002011-10-08 Glenn Morris <rgm@gnu.org>
701
702 * callint.c (Fcall_interactively): Give a more explicit error for the
703 'c' case with a non-character input. (Bug#8479)
704
352ec8ff
EZ
7052011-10-08 Eli Zaretskii <eliz@gnu.org>
706
03669ccb
EZ
707 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
708 lines.
7061c986
EZ
709 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
710 lines that are hscrolled on the left.
03669ccb 711
352ec8ff
EZ
712 * dispnew.c (buffer_posn_from_coords): Account for a possible
713 presence of header-line. (Bug#4426)
714
a66cfb1c
SM
7152011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
716
6b02f655
SM
717 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
718 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 719
7c5ee88e
PE
7202011-10-07 Paul Eggert <eggert@cs.ucla.edu>
721
722 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
723 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
724 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
725 this makes Emacs dump core during garbage collection on rare
726 occasions. sizeof is obviously inferior to offsetof here, so
727 stick with offsetof.
728 (GC_POINTER_ALIGNMENT): New macro.
729 (mark_memory): Omit 3rd (offset) arg; caller changed.
730 Don't assume EMACS_INT alignment is the same as pointer alignment.
731
df1bbe5b
SM
7322011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
733
734 * keyboard.c (read_key_sequence_remapped): New var.
735 (read_key_sequence): Compute remapping in the right buffer.
736 (command_loop_1): Use read_key_sequence's remapping directly.
737
51553db6
SM
7382011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
739
32c1fffd
SM
740 * dired.c (file_name_completion): Don't expand file name.
741 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
742 before checking file name handler.
743
51553db6
SM
744 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
745 they've been requested explicitly (bug#9591).
746
b6bd1599 7472011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
748
749 * keymap.c (Fsingle_key_description): Use make_specified_string
750 instead of build_string to build string from push_key_description.
751 (Bug#5193)
752
f701dc2a
PE
7532011-09-30 Paul Eggert <eggert@cs.ucla.edu>
754
4222c55d
PE
755 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
756 This fixes a Y2038 bug on 64-bit hosts.
757 * buffer.c (reset_buffer):
758 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
759 (Fclear_buffer_auto_save_failure):
760 Use 0, not -1, to represent an unset failure time, since time_t
761 might not be signed.
762
f701dc2a
PE
763 Remove dependency on glibc malloc internals.
764 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
765 Move back here from lisp.h, but with their new implementations.
766 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
767 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
768 * charset.c (charset_table_init): New static var.
769 (syms_of_charset): Use it instead of xmalloc. This removes a
770 dependency on glibc malloc internals. See Eli Zaretskii's comment in
771 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
772 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
773 Move back to alloc.c.
774 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
775 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
776
9ceebf39
JD
7772011-09-30 Jan Djärv <jan.h.d@swipnet.se>
778
779 * nsterm.m (windowDidResize): Call x_set_window_size only when
780 ns_in_resize is true. Otherwise set pixelwidth/height and
781 call change_frame_size (Bug#9628).
782
cb993c58
PE
7832011-09-30 Paul Eggert <eggert@cs.ucla.edu>
784
3930c88b
PE
785 Port --enable-checking=all to Fedora 14 x86-64.
786 * charset.c (syms_of_charset): Also account for glibc malloc's
787 internal overhead when calculating the initial malloc maximum.
788
cb993c58
PE
789 Port --enable-checking=all to Fedora 14 x86.
790 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
791 Move to lisp.h.
792 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
793 (overrun_check_realloc, overrun_check_free):
794 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
795 That way, xmalloc returns a properly-aligned pointer even if
796 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
797 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
798 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
799 into account when calculating the initial malloc maximum.
800 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
801 Move here from alloc.c, so that charset.c can use it too.
802 Properly align; the old code wasn't right for common 32-bit hosts
803 when configured with --enable-checking=all.
804 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
805 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
806
31bed486
EZ
8072011-09-29 Eli Zaretskii <eliz@gnu.org>
808
04c70788 809 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
810 use EDOM.
811
fbcaa2f3
EZ
8122011-09-28 Eli Zaretskii <eliz@gnu.org>
813
814 * xdisp.c (compute_display_string_end): If there's no display
815 string at CHARPOS, return -1.
816
817 * bidi.c (bidi_fetch_char): When compute_display_string_end
818 returns a negative value, treat the character as a normal
819 character not covered by a display string. (Bug#9624)
820
a239d4e9
JB
8212011-09-28 Juanma Barranquero <lekktu@gmail.com>
822
823 * lread.c (Fread_from_string): Fix typo in docstring.
824
88652fd5
EZ
8252011-09-27 Eli Zaretskii <eliz@gnu.org>
826
827 * xdisp.c (handle_invisible_prop): If invisible text ends on a
828 newline, reseat the iterator instead of bidi-iterating there one
829 character at a time. (Bug#9610)
32c1fffd
SM
830 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
831 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 832
ed497dd4
AS
8332011-09-27 Andreas Schwab <schwab@linux-m68k.org>
834
835 * lread.c (readevalloop): Use correct code for NBSP.
836 (read1): Likewise. (Bug#9608)
837
b2bf61aa
MA
8382011-09-25 Michael Albinus <michael.albinus@gmx.de>
839
840 * dbusbind.c (Fdbus_register_signal): When service is not
841 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
842
32bbb17c
GM
8432011-09-25 Glenn Morris <rgm@gnu.org>
844
845 * buffer.c (truncate-lines): Doc fix.
846
94e0933e
CY
8472011-09-24 Chong Yidong <cyd@stupidchicken.com>
848
849 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
850 (Fset_window_next_buffers): Doc fix.
851
cddde921
GM
8522011-09-24 Glenn Morris <rgm@gnu.org>
853
854 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
855
1260aef1
PE
8562011-09-24 Paul Eggert <eggert@cs.ucla.edu>
857
25b4bfa0
PE
858 Fix minor problems found by static checking.
859 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
860 * indent.c (Fvertical_motion): Fix == vs = typo.
861
e3cbd34b
EZ
8622011-09-24 Eli Zaretskii <eliz@gnu.org>
863
a66cfb1c
SM
864 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
865 Default value is now t. Doc fix.
6bf7006f 866
e3cbd34b 867 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 868 logic when moving up, not only when moving down. Fix the
e3cbd34b 869 confusing name and values of the it_overshoot_expected variable;
32c1fffd 870 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
871
872 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
873 CHARPOS is covered by a display string which includes newlines.
874 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
875 is covered by a display string with embedded newlines.
876
a3de0cbd
MA
8772011-09-24 Michael Albinus <michael.albinus@gmx.de>
878
879 * dbusbind.c (Fdbus_register_signal): Add match rule to
880 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
881 (Fdbus_register_method, Vdbus_registered_objects_table):
882 Fix docstring.
a3de0cbd 883
b260039d
JM
8842011-09-24 Jim Meyering <meyering@redhat.com>
885
32c1fffd 886 do not ignore write error for any output size
b260039d
JM
887 The previous change was incomplete.
888 While it makes emacs --batch detect the vast majority of stdout
889 write failures, errors were still ignored whenever the output size is
890 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
891 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
892 && echo FAIL: ignored write error
893 FAIL: ignored write error
894 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
895 && echo FAIL: ignored write error
896 FAIL: ignored write error
897 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
898
8eca8a7c
AS
8992011-09-23 Andreas Schwab <schwab@linux-m68k.org>
900
901 * emacs.c (Fkill_emacs): In noninteractive mode exit
902 non-successfully if a write error occurred on stdout. (Bug#9574)
903
3341db62
EZ
9042011-09-21 Eli Zaretskii <eliz@gnu.org>
905
906 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
907 the xassert test.
908
909 * dispextern.h (struct it): Update the comment documenting what
910 can it->OBJECT be.
911
8c203dbf
EZ
9122011-09-20 Eli Zaretskii <eliz@gnu.org>
913
914 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
915 a display string, extend search for cursor position to end of row.
916 (find_row_edges): If the row ends in a newline from a display
917 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
918 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
919 (Fcurrent_bidi_paragraph_direction): Fix search for previous
920 non-empty line. Fixes confusing cursor motion with arrow keys at
921 the beginning of a line that starts with whitespace.
8c203dbf 922
a4824228
LMI
9232011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
924
925 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
926 (bug#9493).
927
33ed493b
CY
9282011-09-18 Chong Yidong <cyd@stupidchicken.com>
929
930 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
931 boolean (Bug#9154).
932
56cd55c8
EZ
9332011-09-18 Eli Zaretskii <eliz@gnu.org>
934
935 * xdisp.c (display_line): Record maximum and minimum buffer
936 positions even if no glyphs were produced (e.g., by a zero-width
937 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
938 buffer positions that will be removed from the glyph row because
939 they don't fit.
c02dcedf
EZ
940 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
941 column is beyond frame width: don't subtract 1 "pixel" when
942 computing width of the stretch.
3e62b7e0
EZ
943 (reseat_at_next_visible_line_start): Undo the change made on
944 2011-09-17 that saved paragraph information and restored it after
945 the call to `reseat'. (Bug#9545)
56cd55c8 946
5ed99d36 9472011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
948
949 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
950 and turn window cursor on if cleared (Bug#9415).
951
5ed99d36 9522011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
953
954 * search.c (boyer_moore): Take unibyte characters from pattern
955 literally. (Bug#9458)
956
9bade7b2
EZ
9572011-09-18 Eli Zaretskii <eliz@gnu.org>
958
959 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
960
e5e9d610
PE
9612011-09-18 Paul Eggert <eggert@cs.ucla.edu>
962
87e4427a
PE
963 Fix minor problem found by static checking.
964 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
965 initialized, to pacify gcc -Wuninitialized.
966
e5e9d610
PE
967 * fileio.c: Report proper errno when syscall falls.
968 (Finsert_file_contents): Save and restore errno,
969 so that report_file_error outputs the correct diagnostic.
970 (Fwrite_region) [CLASH_DETECTION]: Likewise.
971
a1674f0b
EZ
9722011-09-18 Eli Zaretskii <eliz@gnu.org>
973
974 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
975
fbfb6dd4
EZ
9762011-09-17 Eli Zaretskii <eliz@gnu.org>
977
978 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
979 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
980
bb187662
EZ
9812011-09-17 Eli Zaretskii <eliz@gnu.org>
982
1137e8b8 983 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 984 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
985
986 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
987 (bidi_find_paragraph_start): Search back for paragraph beginning
988 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
989 (bidi_move_to_visually_next): Only trigger paragraph-related
990 computations when the last character is a newline or at EOB, not
991 just any NEUTRAL_B. (Bug#9470)
992
bb187662
EZ
993 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
994 truncated lines if point is covered by a display string. (Bug#9524)
995
2e621251
PE
9962011-09-16 Paul Eggert <eggert@cs.ucla.edu>
997
998 * xselect.c: Relax test for outgoing X longs (Bug#9498).
999 (cons_to_x_long): New function.
1000 (lisp_data_to_selection_data): Use it. Correct the test for
1001 short-versus-long data; it was negated. Break out of vector
1002 loop, for efficiency, when a long datum is discovered.
1003
91a15bc6
SM
10042011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1005
1006 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1007
b41c3a35
EZ
10082011-09-16 Eli Zaretskii <eliz@gnu.org>
1009
1010 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1011 GCC PR/17406) by declaring this function with external scope.
1012
7812ba2d
PE
10132011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1014
1015 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1016 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1017
cf7edc2a
AS
10182011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1019
1020 * editfns.c (Fformat): Correctly handle text properties on "%%".
1021
bd01620e
EZ
10222011-09-15 Eli Zaretskii <eliz@gnu.org>
1023
1024 * xterm.c (x_draw_composite_glyph_string_foreground):
1025 * w32term.c (x_draw_composite_glyph_string_foreground):
1026 * term.c (encode_terminal_code):
1027 * composite.c (composition_update_it, get_composition_id):
1028 * xdisp.c (get_next_display_element)
1029 (fill_composite_glyph_string): Add comments about special meaning
1030 of TAB characters in a composition.
1031
a02719a3
PE
10322011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1033
1034 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1035 This occurs when processing a multibyte format.
1036 Problem reported by Wolfgang Jenker.
a02719a3 1037
72589a3c
JB
10382011-09-15 Johan Bockgård <bojohan@gnu.org>
1039
1040 * xdisp.c (try_cursor_movement): Only check for exact match if
1041 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1042
1c14176c
PE
10432011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1044
1045 Remove unused external symbols.
1046 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1047 * xdisp.c (calc_pixel_width_or_height): Now static.
1048 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1049 * indent.c (check_display_width):
1050 * w32term.c: Fix comment to match code.
1051 * xterm.c, xterm.h (x_catching_errors): Remove.
1052
d2eea5b5
PE
10532011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 * xselect.c: Use signed conversions more consistently (Bug#9498).
1056 (selection_data_to_lisp_data): Assume incoming selection data are
1057 signed integers, not unsigned. This is to be consistent with
1058 outgoing selection data, which was modified to use signed integers
1059 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1060 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1061 expects long, not unsigned long.
1062
46888499
EZ
10632011-09-14 Eli Zaretskii <eliz@gnu.org>
1064
1065 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1066 computation of loop end. Reported by Johan Bockgård
1067 <bojohan@gnu.org>.
1068
ef8ef9fb
CY
10692011-09-13 Chong Yidong <cyd@stupidchicken.com>
1070
1071 * frame.c (Fother_visible_frames_p): Function deleted.
1072
fa819fed
EZ
10732011-09-12 Eli Zaretskii <eliz@gnu.org>
1074
1075 * indent.c (compute_motion): Process display vector front to back
1076 rather than the other way around. (Bug#2496)
1077
2ba8e008
SM
10782011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1079
1080 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1081
20f53c69
CY
10822011-09-11 Chong Yidong <cyd@stupidchicken.com>
1083
1084 * minibuf.c (Fread_from_minibuffer): Doc fix.
1085
d562d7a4
EZ
10862011-09-11 Eli Zaretskii <eliz@gnu.org>
1087
1088 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1089 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1090
1c4d7f3d
LMI
10912011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1092
1093 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1094 value for non-existent files.
1095
b885bf36
EZ
10962011-09-11 Eli Zaretskii <eliz@gnu.org>
1097
1098 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1099 set its "size" to -1. This will set the modtime_size field of
1100 the corresponding buffer to -1, which is what
1101 verify-visited-file-modtime expects for files that do not exist.
1102 (Bug#9139)
1103
6612f0bf
PE
11042011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1105
1106 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1107 here ...
1108 * lisp.h: ... from here. push_key_description is no longer
1109 defined in keyboard.c, so its declaration should not be in
1110 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1111 logically belongs with push_key_description.
1112
dfb3f755
PE
11132011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1114
1115 * buffer.h: Include <sys/types.h> instead of <time.h>.
1116 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1117 Problem reported by Herbert J. Skuhra.
1118
3134906c
LMI
11192011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1120
1121 * xml.c (parse_region): Make the parsing work for
1122 non-comment-starting XML files again (bug#9144).
1123
8d903f4e
AS
11242011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1125
1126 * image.c (gif_load): Fix calculation of bottom and right corner.
1127 (Bug#9468)
1128
80ad64f4
EZ
11292011-09-10 Eli Zaretskii <eliz@gnu.org>
1130
1131 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1132 redisplay in small windows.
1133
208a048d
EZ
11342011-09-09 Eli Zaretskii <eliz@gnu.org>
1135
1136 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1137
9b1c252e
MR
11382011-09-08 Martin Rudalics <rudalics@gmx.at>
1139
1140 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1141 Operate on live windows only.
1142
2949f33b
JB
11432011-09-08 Juanma Barranquero <lekktu@gmail.com>
1144
1145 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1146
e08dcafd
EZ
11472011-09-07 Eli Zaretskii <eliz@gnu.org>
1148
1149 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1150 only under bidi iteration.
1151
115b96bd
JD
11522011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1153
1154 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1155
c8199d0f
PE
11562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1157
1158 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1159 Without this fix, the command to link temacs failed due to an
1160 undefined symbol __builtin_isnan. This is because
1161 /usr/include/iso/math_c99.h #defines isnan(x) to
1162 __builtin_isnan(x), but the bundled gcc, which identifies itself
1163 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1164 a __builtin_isnan.
1165 * floatfns.c (isnan): #undef, and then #define to a clone of
1166 what's in data.c.
1167 (Fisnan): Always define, since it's always available now.
1168 (syms_of_floatfns): Always define isnan at the Lisp level.
1169
e39b275c 11702011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1171
1172 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1173
b2db44d9 11742011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1175
f4af5137 1176 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1177 The previous code assumed that file offsets (off_t values) fit in
1178 EMACS_INT variables, which is not true on typical 32-bit hosts.
1179 The code messed up by falsely reporting buffer overflow in cases
1180 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1181 when "big" contains more than 2**29 bytes, even though this
1182 inserts just one byte and does not overflow the buffer.
1183 (Finsert_file_contents): Store file offsets as off_t
1184 values, not as EMACS_INT values. Check for overflow when
1185 converting between EMACS_INT and off_t. When checking for
1186 buffer overflow or for overlap, take the offsets into account.
1187 Don't use EMACS_INT for small values where int suffices.
1188 When checking for overlap, fix a typo: ZV was used where
1189 ZV_BYTE was intended.
1190 (Fwrite_region): Don't assume off_t fits into 'long'.
1191 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1192
ecfc0a49
MA
11932011-09-05 Michael Albinus <michael.albinus@gmx.de>
1194
1195 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1196
6511acf2 11972011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1198
0999621a 1199 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1200
1201 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1202 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1203 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1204 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1205 (modify_event_symbol): Do not assume that the length of
1206 name_alist_or_stem is safe to alloca and fits in int.
1207 (Fexecute_extended_command): Likewise for function name and binding.
1208 (Frecursion_depth): Wrap around reliably on integer overflow.
1209 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1210 since some callers pass EMACS_INT values.
1211 (Fsingle_key_description): Don't crash if symbol name contains more
1212 than MAX_ALLOCA bytes.
1213 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1214 (get_minibuffer): Arg is now EMACS_INT, not int.
1215 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1216 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1217 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1218
2be7d702
PE
1219 * dbusbind.c (signature_cat): New function.
1220 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1221 Do not overrun buffer; instead, report string overflow.
1222
9d1df220
PE
1223 * dispnew.c (add_window_display_history): Don't overrun buffer.
1224 Truncate instead; this is OK since it's just a log.
1225
33ef5c64
PE
1226 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1227 even if the time zone offset is outlandishly large.
1228 Don't mishandle offset == INT_MIN.
1229
66c6fdd5
PE
1230 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1231 when creating daemon; the previous buffer-overflow check was incorrect.
1232
d749b01b
PE
1233 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1234 which has the guts of the old verror function.
1235
b5cd1905
PE
1236 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1237 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1238
6e1a67fb
PE
1239 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1240 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1241 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1242 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1243 length of string rather than counting it via multiple sprintfs;
1244 that's simpler and more reliable.
c21721cc
PE
1245 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1246 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1247 sprintf, in case result does not fit in int.
1248
c57b67fc
PE
1249 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1250 (fontset_from_font): Print it.
1251
8a401434
PE
1252 * frame.c (tty_frame_count): Now printmax_t, not int.
1253 (make_terminal_frame, set_term_frame_name): Print it.
1254 (x_report_frame_params): In X, window IDs are unsigned long,
1255 not signed long, so print them as unsigned.
1256 (validate_x_resource_name): Check for implausibly long names,
1257 and don't assume name length fits in 'int'.
1258 (x_get_resource_string): Don't blindly alloca invocation name;
1259 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1260 not fit in int.
1261
6e1a67fb
PE
1262 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1263 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1264 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1265
0df02bf3
PE
1266 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1267 Use esprintf, not sprintf, in case result does not fit in int.
1268
48e30793
PE
1269 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1270 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1271 it as a large positive number.
1272 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1273 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1274
a66ff6d8
PE
1275 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1276 in case result does not fit in int.
1277
aca216ff
PE
1278 * print.c (float_to_string): Detect width overflow more reliably.
1279 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1280 buffer overrun. Don't assume list length fits in 'int'. Treat
1281 print length of 0 as 0, not as infinity; to be consistent with other
1282 uses of print length in this function. Don't overflow print length
1283 index. Don't assume hash table size fits in 'long', or that
1284 vectorlike size fits in 'unsigned long'.
1285
31c286f7
PE
1286 * process.c (make_process): Use printmax_t, not int, to format
1287 process-name gensyms.
1288
55e5faa1
PE
1289 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1290
80f2e268
PE
1291 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1292 to avoid potential buffer overrun.
1293
670741ab
PE
1294 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1295 if X resource line is longer than 512 bytes.
1296
b7163a50
PE
1297 * xfns.c (x_window): Make sprintf buffer a bit bigger
1298 to avoid potential buffer overrun.
1299
ae58ff1f
PE
1300 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1301
c43c8a6a
PE
1302 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1303
3f8236f4
PE
13042011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1305
53e9fe90 1306 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1307 Without these, Emacs silently mishandles large integers sometimes.
1308 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1309 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1310
6511acf2
PE
1311 * xdisp.c (try_window_id): Check Emacs fixnum range before
1312 converting to 'int'.
806add1d 1313
6511acf2 1314 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1315 Check that an Emacs fixnum is in range before assigning it to 'int'.
1316 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1317 values converted from Emacs fixnums.
1318 (Frecenter): Don't wrap around a line count if it is out of 'int'
1319 range; instead, treat it as an extreme value.
1320 (Fset_window_configuration, compare_window_configurations):
1321 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1322
6511acf2
PE
1323 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1324 that can exceed INT_MAX. Check that EMACS_INT value is in range
1325 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1326 (match_limit): Don't assume that a fixnum can fit in 'int'.
1327
6511acf2 1328 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1329 exceed INT_MAX.
1330
6511acf2 1331 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1332 (Fvertical_motion): Don't wrap around LINES values that don't fit
1333 in 'int'. Instead, treat them as extreme values. This is good
1334 enough for windows, which can't have more than INT_MAX lines anyway.
1335
fcb901a7
LMI
13362011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1337
0f2f6b6d
LMI
1338 * Require libxml/parser.h to avoid compilation warning.
1339
fcb901a7
LMI
1340 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1341
1342 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1343 since this reportedly can destroy thread storage.
1344
6e20a0d4
CY
13452011-08-30 Chong Yidong <cyd@stupidchicken.com>
1346
1347 * syntax.c (find_defun_start): Update all cache variables if
1348 exiting early (Bug#9401).
1349
148ae00e
EZ
13502011-08-30 Eli Zaretskii <eliz@gnu.org>
1351
f6cfbd8f
EZ
1352 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1353
148ae00e
EZ
1354 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1355 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1356 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1357
1358 * term.c (tty_append_glyph): New function.
1359 (produce_stretch_glyph): Static function and its prototype deleted.
1360
a66cfb1c
SM
1361 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1362 Add prototypes.
148ae00e 1363
c4a07a4c
PE
13642011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1367 when checking :margin (Bug#9390).
1368 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1369 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1370 so that the name doesn't mislead. All uses changed.
1371
6bc8cd65
JB
13722011-08-28 Johan Bockgård <bojohan@gnu.org>
1373
1374 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1375 set_tty_hooks.
1376
dca4927e
EZ
13772011-08-27 Eli Zaretskii <eliz@gnu.org>
1378
1379 * xdisp.c (move_it_to): Don't bail out early when reaching
1380 position beyond to_charpos, if we are scanning backwards.
1381 (move_it_vertically_backward): When DY == 0, make sure we get to
1382 the first character in the line after the newline.
1383
f2cad773
PE
13842011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1385
1386 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1387 (ccl_driver): Do not generate an out-of-range pointer.
1388 (Fccl_execute_on_string): Remove unnecessary check for
1389 integer overflow, noted by Stefan Monnier in
1390 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1391 Remove a FIXME that didn't need fixing.
1392 Simplify the newly-introduced buffer reallocation code.
1393
0cae2cdb
JB
13942011-08-27 Juanma Barranquero <lekktu@gmail.com>
1395
1396 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1397
5fc295a4 13982011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1399
70c60eb2 1400 Integer and memory overflow issues (Bug#9196).
726e0ab1 1401
d31850da
PE
1402 * doc.c (get_doc_string): Rework so that
1403 get_doc_string_buffer_size is the actual buffer size, rather than
1404 being 1 less than the actual buffer size; this makes xpalloc more
1405 convenient.
1406
a69fbedb
PE
1407 * image.c (x_allocate_bitmap_record, cache_image):
1408 * xselect.c (Fx_register_dnd_atom):
1409 Simplify previous changes by using xpalloc.
1410
fe5c5d37
PE
1411 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1412 since either will do and ptrdiff_t is convenient with xpalloc.
1413
0065d054
PE
1414 * charset.c (charset_table_size)
1415 (struct charset_sort_data.priority): Now ptrdiff_t.
1416 (charset_compare): Don't overflow if priorities differ greatly.
1417 (Fsort_charsets): Don't assume list length fits in int.
1418 Check for size-calculation overflow when allocating sort data.
1419 (syms_of_charset): Allocate an initial charset table that is
1420 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1421
1422 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1423
1424 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1425 The actual value is always <= INT_MAX, and leaving it unsigned made
1426 overflow checking harder.
1427
1428 * dispextern.h (struct glyph_matrix.rows_allocated)
1429 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1430 with xpalloc. The values are still always <= INT_MAX.
1431
1432 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1433
1434 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1435 (SAFE_NALLOCA): New macro.
1436
1437 * region-cache.c (struct boundary.pos, find_cache_boundary)
1438 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1439 (set_cache_region, invalidate_region_cache)
1440 (revalidate_region_cache, know_region_cache, region_cache_forward)
1441 (region_cache_backward, pp_cache):
1442 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1443 so that ptrdiff_t * can be passed to xpalloc.
1444 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1445 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1446 (pp_cache): Don't assume cache_len fits in int.
1447 * region-cache.h: Adjust extern decls to match.
1448
1449 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1450 EMACS_INT, since either will do, for xpalloc.
1451
1452 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1453 (xnmalloc, xnrealloc, xpalloc): New functions.
1454
726e0ab1
PE
1455 * bidi.c (bidi_shelve_header_size): New constant.
1456 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1457 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1458
51f30bc5 1459 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1460 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1461 (overlay_strings):
1462 Don't update size of array until after memory allocation succeeds,
1463 because xmalloc/xrealloc may not return.
0065d054
PE
1464 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1465 now that we have proper integer overflow checking.
1466 (record_overlay_string, overlay_strings): Catch overflows when
1467 calculating size of overlay_str_buf.
726e0ab1 1468
0065d054
PE
1469 * callproc.c (Fcall_process): Check for size overflow when
1470 calculating size of args2.
1471 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1472 Normally we prefer signed values, but sticking with ptrdiff_t would
1473 require adding more-complicated checks.
726e0ab1
PE
1474
1475 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1476 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1477 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1478 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1479
1480 * character.c (Fstring): Check for size-calculation overflow.
1481
1482 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1483 unnecessary integer overflow. Check for size overflow.
1484 (encode_coding_object): Don't update size until xmalloc succeeds.
1485
1486 * composite.c (get_composition_id): Check for overflow in glyph
1487 length calculations.
1488
1489 Integer and memory overflow fixes for display code.
1490 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1491 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1492 (scrolling_window): Check for overflow in size calculations.
1493 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1494 Don't assume glyph table len fits in int.
1495 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1496 (row_table_size): Now ptrdiff_t, not int.
1497 (scrolling_window): Avoid overflow in size calculations.
1498 Don't update size until allocation succeeds.
1499 * fns.c (concat): Check for overflow in size calculations.
1500 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1501 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1502 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1503
1504 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1505 (get_doc_string): Check for size calculation overflow.
1506 Don't update size until allocation succeeds.
1507 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1508 EMACS_INT, where ptrdiff_t will do.
1509 (Fsubstitute_command_keys): Check for string overflow.
1510
1511 * editfns.c (set_time_zone_rule): Don't assume environment length
1512 fits in int.
1513 (message_length): Now ptrdiff_t, not int.
1514 (Fmessage_box): Don't update size until allocation succeeds.
1515 Don't assume message length fits in int.
1516 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1517
0065d054
PE
1518 * emacs.c (main): Do not reallocate argv, since there is a null at
1519 the end that can be overwritten, and this way there's no need to
1520 worry about size-calculation overflow.
1521 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1522
1523 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1524 alloc succeeds.
1525 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1526
1527 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1528 (x_set_scroll_bar_width, x_figure_window_size):
1529 Check for integer overflow.
1530 (x_set_alpha): Do not assume XINT fits in int.
1531
1532 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1533 This is for the members text_lines, text_cols, total_lines, total_cols,
1534 where the system imposes an 'int' limit.
1535
1536 * fringe.c (Fdefine_fringe_bitmap):
1537 Don't update size until alloc works.
1538
1539 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1540 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1541
1542 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1543 Check for size-calculation overflow.
1544 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1545 do, as we prefer signed integers.
1546 (id_to_widget.max_size, id_to_widget.used)
1547 (xg_store_widget_in_map, xg_remove_widget_from_map)
1548 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1549 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1550 Use and return ptrdiff_t, not int.
1551 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1552 * gtkutil.h: Change prototypes to match the above.
1553
1554 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1555 are duplicate now that they've been promoted to lisp.h.
1556 (x_allocate_bitmap_record, x_alloc_image_color)
1557 (make_image_cache, cache_image, xpm_load):
1558 Don't update size until alloc is done.
1559 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1560 (x_detect_edges):
3256efce 1561 Check for size calculation overflow.
726e0ab1
PE
1562 (ct_colors_allocated_max): New constant.
1563 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1564 overflow.
3256efce 1565
726e0ab1
PE
1566 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1567 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1568 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1569 Use ptrdiff_t, not int, to count maps.
1570 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1571 calculations. Don't update size until allocation succeeds.
1572 Redo calculations to avoid overflow.
726e0ab1
PE
1573 * keyboard.h: Change prototypes to match the above.
1574
1575 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1576 to count maps.
1577 (current_minor_maps): Check for size calculation overflow.
1578 * keymap.h: Change prototypes to match the above.
1579
1580 * lread.c (read1, init_obarray): Don't update size until alloc done.
1581
1582 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1583 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1584
726e0ab1
PE
1585 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1586 Now ptrdiff_t, not int.
1587 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1588 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1589
1590 * process.c (Fnetwork_interface_list): Check for overflow
1591 in size calculation.
1592
1593 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1594
1595 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1596 overflow. Don't bother calling xmalloc when xrealloc will do.
1597
1598 * search.c (Freplace_match): Check for size calculation overflow.
1599 (Fset_match_data): Don't assume list lengths fit in 'int'.
1600
1601 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1602 for command line length. Do not attempt to address one before the
1603 beginning of an array, as that's not portable.
1604
1605 * term.c (max_frame_lines): Remove; unused.
1606 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1607 not int.
1608 (encode_terminal_code, calculate_costs): Check for size
1609 calculation overflow.
1610 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1611 table lengths and related sizes. Don't update size until alloc
1612 done. Redo calculations to avoid overflow.
1613 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1614
1615 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1616 subtracting pointers.
1617 (gobble_line): Check for overflow more carefully. Don't update size
1618 until alloc done.
1619
1620 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1621 Don't update size until alloc done.
1622 Redo size calculations to avoid overflow.
1623 Check for size calculation overflow.
0065d054 1624 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1625
1626 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1627 Use ptrdiff_t, not int, for sizes.
1628 (store_mode_line_noprop_char): Don't update size until alloc done.
1629
0065d054
PE
1630 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1631 Use ptrdiff_t, not int, for sizes.
1632 (Finternal_make_lisp_face, cache_face):
1633 Check for size calculation overflow.
1634 (cache_face): Treat size calculation overflows as if they were
1635 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1636
1637 * xfns.c (x_encode_text, x_set_name_internal)
1638 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1639 sizes, since they can exceed INT_MAX in size. Check for size
1640 calculation overflow.
1641
0065d054
PE
1642 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1643 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1644 Don't update size until alloc done.
1645
0065d054 1646 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1647 as sprintf is limited to int lengths.
1d526e2f 1648
252c5ee1
PE
1649 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1650 (X_LONG_MIN): New macros.
864d7ce7
PE
1651 Use them to make the following changes clearer.
1652 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1653 This change doesn't affect the value now, but it may help remind
1654 future maintainers not to raise the value too much later.
1655 (SELECTION_QUANTUM): Remove, replacing with ...
1656 (selection_quantum): ... new function, which avoids overflow.
1657 All uses changed.
1658 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1659 assumption that selection length fits in 'int'.
1660 (x_reply_selection_request, x_handle_selection_request)
1661 (x_get_window_property, receive_incremental_selection)
1662 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1663 (lisp_data_to_selection_data, clean_local_selection_data):
1664 Use ptrdiff_t, not int, to record length of selection.
1665 (x_reply_selection_request, x_get_window_property)
1666 (receive_incremental_selection, x_property_data_to_lisp):
1667 Redo calculations to avoid overflow.
1668 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1669 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1670 something.
1671 (x_get_window_property, receive_incremental_selection)
1672 (lisp_data_to_selection_data, x_property_data_to_lisp):
1673 Check for size-calculation overflow.
1674 (x_get_window_property, receive_incremental_selection)
1675 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1676 Don't store size until memory allocation succeeds.
1677 (x_get_window_property): Plug memory leak on memory exhaustion.
1678 Don't double-block input; malloc is safe here. Don't assume 2**34
1679 - 4 fits in unsigned long. Add an xassert to check
1680 XGetWindowProperty overflow. Be more careful about overflow
1681 calculations, and distinguish size from memory overflow better.
1682 (receive_incremental_selection): When tracing, don't assume
1683 unsigned int is less than INT_MAX.
1684 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1685 harmful) conversions of unsigned short to int.
1686 (lisp_data_to_selection_data): Don't assume that integers
1687 in the range -65535 through -1 fit in an X unsigned short.
1688 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1689 result parameters unless successful. Rely on cons_to_unsigned
1690 to report problems with elements; the old code wasn't right anyway.
1691 (x_check_property_data): Check for int overflow; we cannot use
1692 a wider type due to X limits.
1693 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1694
726e0ab1 1695 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1696
0065d054
PE
1697 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1698 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1699 (x_color_cells): Don't store size until memory allocation succeeds.
1700 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1701 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1702 (x_term_init): Don't assume length fits in int (sprintf is limited
1703 to int size).
bc18e09d 1704
ebfa62c0
PE
1705 Use ptrdiff_t for composition IDs.
1706 * character.c (lisp_string_width):
1707 * composite.c (composition_table_size, n_compositions)
1708 (get_composition_id, composition_gstring_from_id):
1709 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1710 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1711 * window.c (Frecenter):
1712 Use ptrdiff_t, not int, for composition IDs.
1713 * composite.c (get_composition_id): Check for integer overflow.
1714 * composite.h: Adjust prototypes to match the above changes.
1715
d3411f89
PE
1716 Use ptrdiff_t for hash table indexes.
1717 * category.c (hash_get_category_set):
1718 * ccl.c (ccl_driver):
1719 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1720 * coding.c (coding_system_charset_list, detect_coding_system):
1721 * coding.h (struct coding_system.id):
1722 * composite.c (get_composition_id, gstring_lookup_cache):
1723 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1724 * image.c (xpm_get_color_table_h):
1725 * lisp.h (hash_lookup, hash_put):
1726 * minibuf.c (Ftest_completion):
1727 Use ptrdiff_t for hash table indexes, not int (which is too
1728 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1729 32-bit --with-wide-int hosts).
1730
e097a6fa
PE
1731 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1732 Add a FIXME comment about memory leaks.
1733 (syms_of_charset): Don't assume xmalloc returns.
1734
5637687f
PE
1735 Don't assume that stated character widths fit in int.
1736 * character.c (Fchar_width, c_string_width, lisp_string_width):
1737 * character.h (CHAR_WIDTH):
1738 * indent.c (MULTIBYTE_BYTES_WIDTH):
1739 Use sanitize_char_width to avoid undefined and/or bad behavior
1740 with outlandish widths.
a66cfb1c 1741 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1742 now that we have two such functions. All uses changed.
1743 (sanitize_char_width): New inline function.
1744
a2271ba2
PE
1745 Don't assume that tab-width fits in int.
1746 * character.h (sanitize_width): New inline function.
1747 (SANE_TAB_WIDTH): New macro.
1748 (ASCII_CHAR_WIDTH): Use it.
1749 * indent.c (sane_tab_width): Remove. All uses replaced by
1750 SANE_TAB_WIDTH (current_buffer).
1751 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1752
18c52557
PE
1753 * fileio.c: Integer overflow issues with file modes.
1754 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1755
caeeedc1
PE
1756 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1757 Remove unreachable code.
1758 (read_hex, load_charset_map_from_file): Check for integer overflow.
1759
50849c52
PE
1760 * xterm.c: don't go over XClientMessageEvent limit
1761 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1762 (x_send_scroll_bar_event): Likewise. Check that the size does not
1763 exceed limits imposed by XClientMessageEvent, as well as the usual
1764 ptrdiff_t and size_t limits.
1765
b13995db
PE
1766 * keyboard.c: Overflow, signedness and related fixes.
1767 (make_lispy_movement): Use same integer type in forward decl
1768 that is used in the definition.
1769 (read_key_sequence, keyremap_step):
1770 Change bufsize argument back to int, undoing my 2011-03-30 change.
1771 We prefer signed types, and int is wide enough here.
1772 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1773 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1774 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1775 length, not size_t. Use ptrdiff_t for index, not int.
1776 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1777 possibility of integer overflow.
1778
13464394
PE
1779 Overflow, signedness and related fixes for images.
1780
1781 * dispextern.h (struct it.stack[0].u.image.image_id)
1782 (struct_it.image_id, struct image.id, struct image_cache.size)
1783 (struct image_cache.used, struct image_cache.ref_count):
1784 * gtkutil.c (update_frame_tool_bar):
1785 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1786 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1787 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1788 * nsmenu.m (update_frame_tool_bar):
1789 * xdisp.c (calc_pixel_width_or_height):
1790 * xfns.c (image_cache_refcount):
1791 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1792 on typical 64-bit hosts.
1793
1794 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1795 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1796 Omit unnecessary casts to int.
1797 (parse_image_spec): Check that integers fall into 'int' range
1798 when the callers expect that.
1799 (image_ascent): Redo ascent calculation to avoid int overflow.
1800 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1801 (lookup_image): Remove unnecessary tests.
1802 (xbm_image_p): Locals are now of int, not EMACS_INT,
1803 since parse_image_check makes sure they fit into int.
1804 (png_load, gif_load, svg_load_image):
1805 Prefer int to unsigned where either will do.
1806 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1807 old tiff_error_handler and tiff_warning_handler.
1808 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1809 stack buffer overflows. It uses only the features of vsnprintf
1810 that are common to both POSIX and native Microsoft.
1811 (tiff_error_handler, tiff_warning_handler): Use it.
1812 (tiff_load, gif_load, imagemagick_load_image):
1813 Don't assume :index value fits in 'int'.
1814 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1815 (imagemagick_load_image): Check that crop parameters fit into
1816 the integer types that MagickCropImage accepts. Don't assume
1817 Vimagemagick_render_type has a nonnegative value. Don't assume
1818 size_t fits in 'long'.
1819 (gs_load): Use printmax_t to print the widest integers possible.
1820 Check for integer overflow when computing image height and width.
1821
c11821d4
EZ
18222011-08-26 Eli Zaretskii <eliz@gnu.org>
1823
1824 * xdisp.c (redisplay_window): Don't force window start if point
1825 will be invisible in the resulting window. (Bug#9324)
1826
0c95fcf7
EZ
18272011-08-25 Eli Zaretskii <eliz@gnu.org>
1828
1829 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1830 the display spec is of the form `(space ...)'.
1831 (handle_display_spec): Return the value returned by
1832 handle_single_display_spec, not just 1 or zero.
1833 (handle_single_display_spec): If the display spec is of the form
1834 `(space ...)', and specifies display in the text area, return 2
1835 rather than 1.
fee65a97 1836 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1837 accurately, and prefer exact match for point under bidi.
1838 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1839
1840 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1841 into disp_prop; all users changed.
1842
1843 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1844 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1845 for the text covered by the display property.
1846
e4ed06f1
CY
18472011-08-25 Chong Yidong <cyd@stupidchicken.com>
1848
1849 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1850 Change return value to nil.
1851 (Frecord_buffer): Delete unused function.
1852
f67cdd7f
EZ
18532011-08-24 Eli Zaretskii <eliz@gnu.org>
1854
5980d4c6
EZ
1855 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1856 buffers, return left-to-right.
8610fe8b
EZ
1857 (set_cursor_from_row): Consider candidate row a win if its glyph
1858 represents a newline and point is on that newline. Fixes cursor
1859 positioning on the newline at EOL of R2L text within L2R
1860 paragraph, and vice versa.
1861 (try_cursor_movement): Check continued rows, in addition to
1862 continuation rows. Fixes unwarranted scroll when point enters a
1863 continued line of R2L text within an L2R paragraph, or vice versa.
1864 (cursor_row_p): Consider the case of point being equal to
1865 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1866 from the end of a short line to the beginning of a continued line
1867 of R2L text within L2R paragraph.
1868 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1869 composed characters.
5980d4c6 1870
f67cdd7f
EZ
1871 * bidi.c (bidi_check_type): Use xassert.
1872 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1873 members.
1874
bca633fb
EZ
18752011-08-23 Eli Zaretskii <eliz@gnu.org>
1876
1877 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1878 a character.
1879
4a5885a7
CY
18802011-08-23 Chong Yidong <cyd@stupidchicken.com>
1881
1882 * nsfont.m (ns_otf_to_script): Fix typo.
1883
0902a04e
KH
18842011-08-22 Kenichi Handa <handa@m17n.org>
1885
1886 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1887 extra slot even if the purpose is char-code-property-table.
1888
1a2e6670
EZ
18892011-08-23 Eli Zaretskii <eliz@gnu.org>
1890
8ddde651
EZ
1891 * xdisp.c (redisplay_window): When computing centering_position,
1892 account for the height of the header line. (Bug#8874)
1893
425cc014
EZ
1894 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1895 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1896 candidate is selected by the mouse, and that candidate has a
1897 composed character under the mouse.
1898
1a2e6670
EZ
1899 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1900 coordinates reported by pos-visible-in-window-p for a composed
1901 character in column zero.
1902
8b76d6f8
SM
19032011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1904
1905 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1906
dac347dd
EZ
19072011-08-22 Eli Zaretskii <eliz@gnu.org>
1908
1909 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1910 consider it a hit if to_charpos is anywhere in the range of the
1911 composed buffer positions.
1912
e013fb34
CY
19132011-08-22 Chong Yidong <cyd@stupidchicken.com>
1914
1915 * image.c (gif_load): Don't assume that each subimage has the same
1916 dimensions as the base image. Handle disposal method that is
1917 "undefined" by the gif spec (Bug#9335).
1918
bd1ba3e8
CY
19192011-08-20 Chong Yidong <cyd@stupidchicken.com>
1920
1921 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1922 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1923
54a1215b
EZ
19242011-08-19 Eli Zaretskii <eliz@gnu.org>
1925
823564e5
EZ
1926 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1927 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1928 from an Org mode buffer to a Speedbar frame.
1929
54a1215b
EZ
1930 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1931 a composition, take its buffer position from IT->cmp_it.charpos.
1932 Fixes cursor positioning at the beginning of a line that begins
1933 with a composed character.
1934
9778ebcc
EZ
19352011-08-18 Eli Zaretskii <eliz@gnu.org>
1936
0be6ee06
EZ
1937 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1938 character bidirectional type, use STRONG_L instead. Fixes crashes
1939 in a buffer produced by `describe-categories'.
1940
9778ebcc
EZ
1941 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1942 members before the level stack, so they would be saved and
1943 restored when copying iterator state. Fixes incorrect reordering
1944 around TABs covered by display properties.
1945
156bffbe
AS
19462011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1947
6b02f655 1948 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1949
72ad093b
CY
19502011-08-17 Chong Yidong <cyd@stupidchicken.com>
1951
1952 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1953 (internal_condition_case_2, internal_condition_case_n):
1954 Remove unnecessary aborts (Bug#9081).
72ad093b 1955
35774242
EZ
19562011-08-17 Eli Zaretskii <eliz@gnu.org>
1957
1958 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1959 has no `load' handler, try opening the file locally. (Bug#9311)
1960
db76dd85
KB
19612011-08-16 Ken Brown <kbrown@cornell.edu>
1962
1963 * gmalloc.c: Expand comment.
1964
b215eee5
EZ
19652011-08-16 Eli Zaretskii <eliz@gnu.org>
1966
1967 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1968 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1969
a4579d33
KB
19702011-08-16 Ken Brown <kbrown@cornell.edu>
1971
1972 Fix memory allocation problems in Cygwin build (Bug#9273).
1973
1974 * unexcw.c ( __malloc_initialized): Declare external variable.
1975 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1976
8b76d6f8
SM
1977 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1978 New variables.
a4579d33
KB
1979 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1980 dumped emacs.
1981 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1982 in the static heap.
1983 [CYGWIN] (special_realloc): New function.
1984 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1985 requests to realloc storage in the static heap.
1986
3ebec551
PE
19872011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1988
1989 * bidi.c (bidi_initialize): Remove unused local.
1990
9fd8be00
EZ
19912011-08-15 Eli Zaretskii <eliz@gnu.org>
1992
6b02f655
SM
1993 * bidimirror.h:
1994 * biditype.h: Remove file.
1995 * makefile.w32-in ($(BLD)/bidi.$(O)):
1996 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1997
1998 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1999
2000 * chartab.c: Improve commentary for the uniprop_table API.
2001
32413314
EZ
2002 * bidi.c (bidi_paragraph_init): Support zero value of
2003 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2004 (bidi_initialize): Use uniprop_table instead of including
2005 biditype.h and bidimirror.h.
32413314 2006
9fd8be00
EZ
2007 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2008 coordinates of the iterator when restoring from ppos_it.
2009 (Bug#9296)
2010
5cf2b69b
KH
20112011-08-14 Kenichi Handa <handa@m17n.org>
2012
2013 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2014 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2015
daf17d00
EZ
20162011-08-14 Eli Zaretskii <eliz@gnu.org>
2017
2018 * xdisp.c (move_it_in_display_line_to): Don't invoke
2019 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2020 ppos_it. Fixes vertical cursor motion when line beginning is
2021 covered by an image. (Bug#9296)
2022
08e3161a
JD
20232011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2024
2025 * nsterm.h (ns_run_ascript): Declare.
2026 (NSAPP_DATA2_RUNASSCRIPT): Define.
2027
2028 * nsfns.m (as_script, as_result, as_status): New static variables.
2029 (ns_run_ascript): New function.
5e617bc2 2030 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2031 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2032 the event loop. Get status from as_status (Bug#7276).
2033
2034 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2035 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2036 the event loop (Bug#7276).
2037
a3720aa2
AS
20382011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2039
2040 * gnutls.c (QCgnutls_bootprop_priority)
2041 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2042 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2043 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2044 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2045 (QCgnutls_bootprop_verify_hostname_error)
2046 (QCgnutls_bootprop_callbacks_verify): Rename from
2047 Qgnutls_bootprop_..., all uses changed.
2048
2049 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2050 uses changed.
2051
0a0d27fb
PE
20522011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2053
19d5c50c
PE
2054 * xfaces.c (Qframe_set_background_mode): Now static.
2055 * dispextern.h (Qframe_set_background_mode): Remove decl.
2056
0a0d27fb
PE
2057 * process.c (Fnetwork_interface_info): Declare local only if needed.
2058
377538cb
JD
20592011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2060
2061 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2062 (Fnetwork_interface_list): Allocate in increments of bytes instead
2063 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2064 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2065 sockaddr.
2066 (struct ifflag_def): notrailers is smart on OSX.
2067 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2068 Get hardware address with getifaddrs if available.
2069
08fff70c
EZ
20702011-08-12 Eli Zaretskii <eliz@gnu.org>
2071
2072 * xdisp.c (iterate_out_of_display_property): xassert that
2073 IT->position is set to within IT->object's boundaries. Break from
2074 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2075 when IT->position is set up wrongly due to some bug.
2076 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2077 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2078 entry. Force push_it to save on the stack the current
2079 buffer/string position, to be restored by pop_it. Fix flags in
2080 the iterator structure wrt the object coming from a display
2081 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2082 properties. (Bug#9284)
2083
7be1c708 20842011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2085
7be1c708
CY
2086 * fontset.c (fontset_get_font_group): Add proper type checks.
2087 (Bug#9172)
aac0c6e3 2088
7be1c708 20892011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2090
7be1c708
CY
2091 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2092 and LC_VERSION_MIN_MACOSX.
2093 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2094 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2095
97bb72a6
EZ
20962011-08-08 Eli Zaretskii <eliz@gnu.org>
2097
2098 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2099 no-display-properties-and-no-overlays under bidi display.
2100 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2101 properties and overlays.
97bb72a6 2102
d5617611
CY
21032011-08-08 Chong Yidong <cyd@stupidchicken.com>
2104
37e11a63
CY
2105 * editfns.c (Fset_time_zone_rule): Document relationship with the
2106 setenv function.
2107
d5617611
CY
2108 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2109 the font entity extracted from the cache (Bug#8109).
2110
58872834
CY
21112011-08-07 Chong Yidong <cyd@stupidchicken.com>
2112
2113 * composite.c (autocmp_chars): Don't reset point. That is done by
2114 restore_point_unwind (Bug#5984).
2115
75bfc667
JL
21162011-08-07 Juri Linkov <juri@jurta.org>
2117
2118 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2119 to show the arg `TIME' instead of `TIMEVAL'.
2120
d1410150
EZ
21212011-08-06 Eli Zaretskii <eliz@gnu.org>
2122
2123 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2124 display property strides EOL and includes a newline, as in
2125 longlines-mode. (Bug#9254)
75b771e4
EZ
2126 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2127 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2128
2129 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2130 is non-zero, even if the data buffer is NULL. Fixes a crash in
2131 vertical-motion with longlines-mode. (Bug#9254)
2132
35928349
EZ
21332011-08-05 Eli Zaretskii <eliz@gnu.org>
2134
ec7cc85b
EZ
2135 * bidi.c <bidi_cache_total_alloc>: Now static.
2136 (bidi_initialize): Initialize bidi_cache_total_alloc.
2137
8b76d6f8 2138 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2139 cache. (Bug#9221)
2140
2141 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2142 amount allocated this far in `bidi_cache_total_alloc'.
2143 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2144 non-zero, only free the data buffer without restoring the cache
2145 contents. All callers changed.
2146
2147 * dispextern.h (bidi_unshelve_cache): Update prototype.
2148
2149 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2150 (move_it_in_display_line, move_it_to)
2151 (move_it_vertically_backward, move_it_by_lines): Replace the call
2152 to xfree to an equivalent call to bidi_unshelve_cache.
2153 (move_it_in_display_line_to): Fix logic of returning
412b6358 2154 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2155
e2e2423b
EZ
21562011-08-05 Eli Zaretskii <eliz@gnu.org>
2157
2158 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2159 came from a string character with a `cursor' property. (Bug#9229)
2160
ae9e757a
JD
21612011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2162
2163 * Makefile.in (LIB_PTHREAD): New variable.
2164 (LIBES): Add LIB_PTHREAD (Bug#9216).
2165
2166 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2167 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2168
213bd7f2
AS
21692011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2170
6b02f655 2171 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2172
99aaf75f
JD
21732011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2174
2175 * xterm.c (x_find_topmost_parent): New function.
2176 (x_set_frame_alpha): Find topmost parent window with
2177 x_find_topmost_parent and set the property there also (bug#9181).
2178 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2179
c74e9d86
PE
21802011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2181
2182 * callproc.c (Fcall_process): Avoid vfork clobbering
2183 the local vars buffer, coding_systems, current_dir.
2184
640c8776
SM
21852011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2186
2187 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2188
f26d0e4c
PE
21892011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2190
8a10d76c
PE
2191 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2192 so that it is not optimized away.
2193
f26d0e4c
PE
2194 * xdisp.c (compute_display_string_pos): Remove unused local.
2195
55439c61
EZ
21962011-08-02 Eli Zaretskii <eliz@gnu.org>
2197
2198 Fix slow cursor motion and scrolling in large buffers with
2199 selective display, like Org Mode buffers. (Bug#9218)
2200
2201 * dispextern.h (struct bidi_it): New member disp_prop_p.
2202
2203 * xdisp.c: Remove one-slot cache of display string positions.
2204 (compute_display_string_pos): Accept an additional argument
5e617bc2 2205 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2206 for a display string or property. If found, set DISP_PROP_P
2207 non-zero.
2208
2209 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2210 DISP_PROP_P, and pass it to compute_display_string_pos.
2211 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2212 non-zero. All callers of bidi_fetch_char changed.
2213
fb33fa43
SM
22142011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2215
2216 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2217
b099e063
DM
22182010-12-03 Don March <don@ohspite.net>
2219
2220 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2221 last character M-[char] is translated to ESC [char] (bug#7541).
2222
5cc7f7af
KH
22232011-08-02 Kenichi Handa <handa@m17n.org>
2224
d0fffa3f 2225 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2226
2227 * chartab.c (uniprop_table): Make it non-static.
2228
525d5e6e
EZ
22292011-08-01 Eli Zaretskii <eliz@gnu.org>
2230
2231 * xdisp.c (forward_to_next_line_start): Accept additional argument
2232 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2233 on the newline.
2234 (reseat_at_next_visible_line_start): Use the bidi iterator state
2235 returned by forward_to_next_line_start to restore the state of
2236 it->bidi_it after backing up to previous newline. (Bug#9212)
2237
31011111
AS
22382011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2239
2240 * regex.c (re_comp): Protoize.
2241 (re_exec): Fix return type.
2242 (regexec): Fix type of `ret'. (Bug#9203)
2243
476371c4
PE
22442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2245
e5d76069
PE
2246 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2247 This is needed if max-image-size is a floating-point number.
2248
9a79b20c
AS
22492011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2250
2251 * print.c (print_object): Print empty symbol as ##.
2252
2253 * lread.c (read1): Read ## as empty symbol.
2254
d8c2fa78
AA
22552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2256
2257 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2258 setting frame foreground color (Bug#9175).
2259 (x_set_background_color): Likewise.
2260
ffe57a7a
AA
2261 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2262 contents (Bug#9176).
2263 (EmacsTooltip -init): Remove bezels and add shadows to
2264 tooltip windows.
2265
bf3492a5
AA
2266 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2267 or scroll bar (Bug#8470).
2268
d55e9c53
AA
2269 * nsfont.m (nsfont_open): Remove assignment to voffset and
2270 unnecessary vars hshink, expand, hd, full_height, min_height.
2271 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2272
2273 * nsterm.h (nsfont_info): Remove voffset field.
2274
d8c2fa78 22752011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2276
2277 Implement strike-through and overline on NextStep (Bug#8863).
2278
2279 * nsfont.m (nsfont_open): Use underline position provided by font,
2280 instead of hard-coded value of 2.
2281 (nsfont_draw): Call ns_draw_text_decoration instead.
2282
2283 * nsterm.h: Add declaration for ns_draw_text_decoration.
2284
2285 * nsterm.m (ns_draw_text_decoration): New function for drawing
2286 underline, overline, and strike-through.
2287 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2288 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2289 accommodate underlining, etc.
4843aac3 2290
4cc60b9b
EZ
22912011-07-28 Eli Zaretskii <eliz@gnu.org>
2292
bc7ece87
EZ
2293 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2294 default.
4cc60b9b 2295
476371c4
PE
22962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2297
66606eea
PE
2298 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2299 Without this fix, if a signal arrives just after memory fills up,
2300 'malloc' might be invoked reentrantly.
2301
476371c4
PE
2302 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2303 In other words, assume that every image size is allowed, on non-X
2304 hosts. This assumption is probably wrong, but it lets Emacs compile.
2305
f3fcc40d
AS
23062011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2307
2308 * regex.c (re_iswctype): Convert return values to boolean.
2309
350c992f
EZ
23102011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2311
2312 * xdisp.c (compute_display_string_pos): Don't use cached display
2313 string position if the buffer had its restriction changed.
2314 (Bug#9184)
2315
5266b4bb
PE
23162011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2319
2573a837 23202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2321
41f55ccd 2322 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2323
39e378da
PE
2324 * bidi.c: Integer size and overflow fixes.
2325 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2326 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2327 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2328 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2329 (bidi_find_other_level_edge):
2330 Use ptrdiff_t instead of EMACS_INT where either will do.
2331 This works better on 32-bit hosts configured --with-wide-int.
2332 (bidi_cache_ensure_space): Check for size-calculation overflow.
2333 Use % rather than repeated addition, for better worst-case speed.
2334 Don't set bidi_cache_size until after xrealloc returns, because it
2335 might not return.
2336 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2337 (bidi_cache_ensure_space): Also check that the bidi cache size
2338 does not exceed that of the largest Lisp string or buffer. See Eli
2339 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2340
5e927815
PE
2341 * alloc.c (__malloc_size_t): Remove.
2342 All uses replaced by size_t. See Andreas Schwab's note
2343 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2344
ca4aa935
PE
2345 * image.c: Improve checking for integer overflow.
2346 (check_image_size): Assume that f is nonnull, since
2347 it is always nonnull in practice. This is one less thing to
2348 worry about when checking for integer overflow later.
2349 (x_check_image_size): New function, which checks for integer
2350 overflow issues inside X.
2351 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2352 This removes the need for a memory_full check.
2353 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2354 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2355 (xbm_read_bitmap_data): Change locals back to 'int', since
2356 their values must fit in 'int'.
2357 (xpm_load_image, png_load, tiff_load):
2358 Invoke x_create_x_image_and_pixmap earlier,
2359 to avoid much needless work if the image is too large.
2360 (tiff_load): Treat overly large images as if
2361 x_create_x_image_and_pixmap failed, not as malloc failures.
2362 (gs_load): Use x_check_image_size.
2363
5f8f9cc2
PE
2364 * gtkutil.c: Omit integer casts.
2365 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2366 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2367
5adf60bc
PE
2368 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2369
c8907a93
PE
2370 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2371 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2372 would wrongly return t on a 64-bit host.
2373
e3c25c68
PE
2374 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2375 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2376 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2377 and therefore cause GCC to emit a bogus diagnostic in some cases.
2378
3f791afe
PE
2379 * image.c: Integer signedness and overflow and related fixes.
2380 This is not an exhaustive set of fixes, but it's time to
2381 record what I've got.
2382 (lookup_pixel_color, check_image_size): Remove redundant decls.
2383 (check_image_size): Don't assume that arbitrary EMACS_INT values
2384 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2385 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2386 (tiff_load, imagemagick_load_image):
2387 Check for overflow in size calculations.
2388 (x_create_x_image_and_pixmap): Remove unnecessary test for
2389 xmalloc returning NULL; that can't happen.
2390 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2391 (xpm_color_bucket): Use better integer hashing function.
2392 (xpm_cache_color): Don't possibly over-allocate memory.
2393 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2394 (gif_memory_source):
2395 Use ptrdiff_t, not int or size_t, to record sizes.
2396 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2397 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2398 either works, as we prefer signed integers.
2399 (tiff_read_from_memory, tiff_write_from_memory):
2400 Return tsize_t, not size_t, since that's what the TIFF API wants.
2401 (tiff_read_from_memory): Don't fail simply because the read would
2402 go past EOF; instead, return a short read.
2403 (tiff_load): Omit no-longer-needed casts.
2404 (Fimagemagick_types): Don't assume size fits into 'int'.
2405
3cc5a532
PE
2406 Improve hashing quality when configured --with-wide-int.
2407 * fns.c (hash_string): New function, taken from sxhash_string.
2408 Do not discard information about ASCII character case; this
2409 discarding is no longer needed.
2410 (sxhash-string): Use it. Change sig to match it. Caller changed.
2411 * lisp.h: Declare it.
2412 * lread.c (hash_string): Remove, since we now use fns.c's version.
2413 The fns.c version returns a wider integer if --with-wide-int is
2414 specified, so this should help the quality of the hashing a bit.
2415
b312a492
PE
2416 * emacs.c: Integer overflow minor fix.
2417 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2418 Define only if GNU_LINUX.
2419 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2420
dfd153ae
PE
2421 * dispnew.c: Integer signedness and overflow fixes.
2422 Remove unnecessary forward decls, that were a maintenance hassle.
2423 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2424 All uses changed.
2425 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2426 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2427 (prepare_desired_row, line_draw_cost):
2428 Use int, not unsigned, where either works.
2429 (save_current_matrix, restore_current_matrix):
2430 Use ptrdiff_t, not size_t, where either works.
2431 (init_display): Check for overflow more accurately, and without
2432 relying on undefined behavior.
2433
a81d11a3
PE
2434 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2435 Remove, replacing with the new symbols in lisp.h. All uses changed.
2436 * fileio.c (make_temp_name):
2437 * filelock.c (lock_file_1, lock_file):
2438 * xdisp.c (message_dolog):
2439 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2440 Use pMd etc. instead.
2441 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2442 replacing the pWIDE etc. symbols removed from editfns.c.
2443
3300e6fd
PE
2444 * keyboard.h (num_input_events): Now uintmax_t.
2445 This is (very slightly) less likely to mess up due to wraparound.
2446 All uses changed.
2447
fd05c7e9
PE
2448 * buffer.c: Integer signedness fixes.
2449 (alloc_buffer_text, enlarge_buffer_text):
2450 Use ptrdiff_t rather than size_t when either will do, as we prefer
2451 signed integers.
2452
903fe15d
PE
2453 * alloc.c: Integer signedness and overflow fixes.
2454 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2455 (__malloc_size_t): Default to size_t, not to int.
2456 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2457 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2458 Prefer ptrdiff_t to size_t when either would do, as we prefer
2459 signed integers.
2460 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2461 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2462 Now const. Initialize with values that are in range even if char
2463 is signed.
2464 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2465 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2466 These functions do the right thing with sizes > 2**32.
2467 (check_depth): Now ptrdiff_t, not int.
2468 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2469 Adjust to new way of storing sizes. Check for size overflow bugs
2470 in rest of code.
2471 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2472 slightly wrong anyway, as it missed one instance of
2473 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2474 (refill_memory_reserve): Omit needless cast to size_t.
2475 (mark_object_loop_halt): Mark as externally visible.
2476
ac82cc6a
PE
2477 * xselect.c: Integer signedness and overflow fixes.
2478 (Fx_register_dnd_atom, x_handle_dnd_message):
2479 Use ptrdiff_t, not size_t, since we prefer signed.
2480 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2481 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2482 x_dnd_atoms_size and x_dnd_atoms_length.
2483
c2d1e36d
PE
2484 * doprnt.c: Prefer signed to unsigned when either works.
2485 * eval.c (verror):
2486 * doprnt.c (doprnt):
2487 * lisp.h (doprnt):
2488 * xdisp.c (vmessage):
2489 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2490 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2491 prefer signed arithmetic to avoid comparison confusion.
2492 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2493 but is a bit tricky.
2494
0e926e56
PE
2495 Assume freestanding C89 headers, string.h, stdlib.h.
2496 * data.c, doprnt.c, floatfns.c, print.c:
2497 Include float.h unconditionally.
2498 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2499 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2500 * regex.c: Likewise for stddef.h, string.h.
2501 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2502 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2503 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2504 (STDC_HEADERS): Remove obsolete defines.
2505 * sysdep.c: Include limits.h unconditionally.
2506
9cfdb3ec
PE
2507 Assume support for memcmp, memcpy, memmove, memset.
2508 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2509 * regex.c (memcmp, memcpy):
2510 Remove; we assume C89 now.
2511
2512 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2513 (__malloc_safe_bcopy): Remove; no longer needed.
2514
cf950e6b 2515 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2516 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2517 well either way, and we prefer signed to unsigned.
2518
dbf38e02
LMI
25192011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2520
2521 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2522 closes the connection while we're reading (bug#9182).
2523
d6f0886c 25242011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2525
d6f0886c
JD
2526 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2527 are specified (Bug#9168).
24e0f6b1 2528
2eb1f9e6
PE
25292011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2530
2531 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2532 Found by GCC static checking and --with-wide-int on a 32-bit host.
2533
22381272 25342011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2535
2536 * xdisp.c (compute_display_string_pos): Fix logic of caching
2537 previous display string position. Initialize cached_prev_pos to
2538 -1. Fixes slow-down at the beginning of a buffer.
2539
f25e39b4
EZ
25402011-07-24 Eli Zaretskii <eliz@gnu.org>
2541
2542 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2543 for attrs[LFACE_FONTSET_INDEX].
2544
04c4b52e
PE
25452011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2546
2547 * xml.c (parse_region): Remove unused local
2548 that was recently introduced.
2549
c1734fbd
EZ
25502011-07-23 Eli Zaretskii <eliz@gnu.org>
2551
be18c5a5
EZ
2552 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2553 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2554
c1734fbd
EZ
2555 * xdisp.c (move_it_in_display_line_to): Record the best matching
2556 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2557 exit if none of the characters scanned was an exact match.
2558 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2559 when exact match is impossible due to invisible text, and the
2560 lines are truncated.
2561
a258d627
JD
25622011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2563
2564 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2565 for OSX >= 10.7.
2566
b6d5a689
EZ
25672011-07-22 Eli Zaretskii <eliz@gnu.org>
2568
0f74f785
EZ
2569 Fix a significant slow-down of cursor motion with C-n, C-p,
2570 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2571 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2572 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2573 (next_element_from_buffer): Call compute_stop_pos_backwards to
2574 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2575 base_level_stop.
2576 (reseat): Don't look for prev_stop, as that could mean a very long
2577 run.
2578 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2579 <cached_disp_overlay_modiff>: Cache for last found display string
2580 position.
551918c1 2581 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2582 about the same buffer in the same area of character positions, and
2583 the buffer wasn't changed since the time the display string
2584 position was cached.
551918c1 2585
b2d0c91a
EZ
25862011-07-22 Eli Zaretskii <eliz@gnu.org>
2587
2588 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2589 is an integer, which is important for empty lines. (Bug#9149)
2590
043604ee
CY
25912011-07-22 Chong Yidong <cyd@stupidchicken.com>
2592
2593 * frame.c (Fmodify_frame_parameters): In tty case, update the
2594 default face if necessary (Bug#4238).
2595
da4adb04
CY
25962011-07-21 Chong Yidong <cyd@stupidchicken.com>
2597
2598 * editfns.c (Fstring_to_char): No need to explain what a character
2599 is in the docstring (Bug#6576).
2600
9abd0532
LMI
26012011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2602
2603 * xml.c (parse_region): Make sure we always return a tree.
2604
36881d16
HK
26052011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2606
2607 * xml.c (parse_region): If a document contains only comments,
2608 return that, too.
2609
1e98674d
LMI
26102011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2611
2612 * xml.c (make_dom): Return comments, too.
2613
590bd467
PE
26142011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2615
2616 Port to OpenBSD.
2617 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2618 and the surrounding thread.
2619 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2620 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2621 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2622 timer goes off.
2623 * s/openbsd.h (BROKEN_SIGIO): Define.
2624 * unexelf.c (unexec) [__OpenBSD__]:
2625 Don't update the .mdebug section of the Alpha COFF symbol table.
2626
f41628b2
LMI
26272011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2628
2629 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2630 (bug#8460).
2631
b59b67c5
PE
26322011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2633
15e3a074
PE
2634 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2635 This fixes some race conditions on the permissions of any newly
2636 created file.
2637
41bed37d
PE
2638 * alloc.c (valid_pointer_p): Use pipe, not open.
2639 This fixes some permissions issues when debugging.
2640
b59b67c5
PE
2641 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2642 If fchown fails to set both uid and gid, try to set just gid,
2643 as that is sometimes allowed. Adjust the file's mode to eliminate
2644 setuid or setgid bits that are inappropriate if fchown fails.
2645
925a6be7
SM
26462011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2647
2648 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2649 to compare Lisp_Objects.
2650 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2651 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2652 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2653
52968808
AS
26542011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2655
0a6a104b
AS
2656 * lread.c (read_integer): Unread even EOF character.
2657 (read1): Likewise. Properly record start position of symbol.
2658
52968808
AS
2659 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2660 symbol character follows.
2661
9e381cdd
PE
26622011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2665 This works around a problem with the previous change to Fcopy_file.
2666 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2667 and without this change, GCC might complain about discarding
2668 fchown's return value.
2669
b5641435
JB
26702011-07-16 Juanma Barranquero <lekktu@gmail.com>
2671
2672 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2673
a8031457
PE
26742011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2675
2676 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2677
dd889327
LMI
26782011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2679
750c33f7
LMI
2680 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2681 it's used from the C level.
2682
dd889327
LMI
2683 * process.c: Use the same condition for POLL_FOR_INPUT in both
2684 keyboard.c and process.c (bug#1858).
2685
87e86684
LM
26862011-07-09 Lawrence Mitchell <wence@gmx.li>
2687
2688 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2689 (Fgnutls_boot): Use it.
2690
64348f40
AS
26912011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2692
2693 * doc.c (Fsubstitute_command_keys): Revert last change.
2694
1d698799
LMI
26952011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2696
f863868c
LMI
2697 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2698 quotes the next character, and doesn't affect other longer
2699 sequences (bug#8935).
2700
1d698799
LMI
2701 * lread.c (syms_of_lread): Clarify that is isn't only
2702 `eval-buffer' and `eval-defun' that's affected by
2703 `lexical-binding' (bug#8460).
2704
aa4b6df6
EZ
27052011-07-15 Eli Zaretskii <eliz@gnu.org>
2706
2707 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2708 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2709
5d856da6
PE
27102011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2711
ad6042bb
PE
2712 Fix minor problems found by static checking.
2713 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2714 (elsz): Now a signed constant, not a size_t var. We prefer signed
2715 types to unsigned, to avoid integer comparison confusion. Without
2716 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2717 "cannot optimize loop, the loop counter may overflow", a symptom
2718 of the confusion.
f00bbb22 2719 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2720 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2721
6468f31c
LMI
27222011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2723
49080b10
LMI
2724 * search.c (Fre_search_backward): Mention `case-fold-search' in
2725 all the re_search_* functions (bug#8138).
2726
6468f31c
LMI
2727 * keyboard.c (Fopen_dribble_file): Document when the file is
2728 closed (bug#8056).
2729
c965adc5
EZ
27302011-07-14 Eli Zaretskii <eliz@gnu.org>
2731
df9733bf
EZ
2732 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2733 bidi_cache_idx.
2734
0bb23927
EZ
2735 Support bidi reordering of display and overlay strings.
2736 * xdisp.c (compute_display_string_pos)
2737 (compute_display_string_end): Accept additional argument STRING.
2738 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2739 (reseat_to_string): Initialize bidi_it->string.s and
2740 bidi_it->string.schars.
2741 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2742 NULL (avoids a crash in bidi_paragraph_init).
2743 Initialize itb.string.lstring.
0bb23927
EZ
2744 (init_iterator): Call bidi_init_it only of a valid
2745 buffer position was specified. Initialize paragraph_embedding to
2746 L2R.
2747 (reseat_to_string): Initialize the bidi iterator.
2748 (display_string): If we need to ignore text properties of
2749 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2750 original value of -1 will not work with bidi.)
2751 (compute_display_string_pos): First arg is now struct
2752 `text_pos *'; all callers changed. Support display properties on
2753 Lisp strings.
2754 (compute_display_string_end): Support display properties on Lisp
2755 strings.
2756 (init_iterator, reseat_1, reseat_to_string): Initialize the
2757 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2758 when iterating on a string not from display properties).
640c8776
SM
2759 (compute_display_string_pos, compute_display_string_end):
2760 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2761 arrow keys.
2762 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2763 base_level_stop; instead, set base_level_stop to BEGV.
2764 Fixes crashes in vertical-motion.
0bb23927
EZ
2765 (next_element_from_buffer): Improve commentary for when
2766 the iterator is before prev_stop.
2767 (init_iterator): Initialize bidi_p from the default value of
2768 bidi-display-reordering, not from buffer-local value. Use the
2769 buffer-local value only if initializing for buffer iteration.
2770 (handle_invisible_prop): Support invisible properties on strings
2771 that are being bidi-reordered.
2772 (set_iterator_to_next): Support bidi reordering of C strings and
2773 Lisp strings.
2774 (next_element_from_string): Support bidi reordering of Lisp
2775 strings.
2776 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2777 (display_string): Support display of R2L glyph rows.
2778 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2779 (init_iterator): Don't initialize it->bidi_p for strings
2780 here.
2781 (reseat_to_string): Initialize it->bidi_p for strings here.
2782 (next_element_from_string, next_element_from_c_string)
2783 (next_element_from_buffer): Add xassert's for correspondence
2784 between IT's object being iterated and it->bidi_it.string
2785 structure.
2786 (face_before_or_after_it_pos): Support bidi iteration.
2787 (next_element_from_c_string): Handle the case of the first string
2788 character that is not the first one in the visual order.
2789 (get_visually_first_element): New function, refactored from common
2790 parts of next_element_from_buffer, next_element_from_string, and
2791 next_element_from_c_string.
2792 (tool_bar_lines_needed, redisplay_tool_bar)
2793 (display_menu_bar): Force left-to-right direction. Add a FIXME
2794 comment for making that be controlled by a user option.
2795 (push_it, pop_it): Save and restore the state of the
2796 bidi iterator. Save and restore the bidi_p flag.
2797 (pop_it): Iterate out of display property for string iteration as
2798 well.
2799 (iterate_out_of_display_property): Support iteration over strings.
2800 (handle_single_display_spec): Set up it->bidi_it for iteration
2801 over a display string, and call bidi_init_it.
2802 (handle_single_display_spec, next_overlay_string)
2803 (get_overlay_strings_1, push_display_prop): Set up the bidi
2804 iterator for displaying display or overlay strings.
2805 (forward_to_next_line_start): Don't use the shortcut if
2806 bidi-iterating.
2807 (back_to_previous_visible_line_start): If handle_display_prop
2808 pushed the iterator stack, restore the internal state of the bidi
2809 iterator by calling bidi_pop_it same number of times.
2810 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2811 and we are bidi-iterating, don't decrement the iterator position;
2812 instead, set the first_elt flag in the bidi iterator, to produce
2813 the same effect.
2814 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2815 (push_display_prop): xassert that we are iterating a buffer.
2816 (push_it, pop_it): Save and restore paragraph_embedding member.
2817 (handle_single_display_spec, next_overlay_string)
2818 (get_overlay_strings_1, reseat_1, reseat_to_string)
2819 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2820 correctly. Don't assume unibyte strings are not bidi-reordered.
2821 (compute_display_string_pos)
2822 (compute_display_string_end): Fix handling the case of C string.
2823 (push_it, pop_it): Save and restore from_disp_prop_p.
2824 (handle_single_display_spec, push_display_prop): Set the
2825 from_disp_prop_p flag.
2826 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2827 (pop_it): Call iterate_out_of_display_property only if we are
2828 popping after iteration over a string that came from a display
2829 property. Fix a typo in popping stretch info. Add an assertion
2830 for verifying that the iterator position is in sync with the bidi
2831 iterator.
2832 (handle_single_display_spec, get_overlay_strings_1)
2833 (push_display_prop): Fix initialization of paragraph direction for
2834 string when that of the parent object is not yet determined.
2835 (reseat_1): Call bidi_init_it to resync the bidi
2836 iterator with IT's position. (Bug#7616)
2837 (find_row_edges): If ROW->start.pos gives position
2838 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2839 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2840 Reset the from_disp_prop_p flag.
2841 (SAVE_IT, RESTORE_IT): New macros.
2842 (pos_visible_p, face_before_or_after_it_pos)
2843 (back_to_previous_visible_line_start)
2844 (move_it_in_display_line_to, move_it_in_display_line)
2845 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2846 (try_scrolling, redisplay_window, display_line): Use them when
2847 saving a temporary copy of the iterator and restoring it back.
2848 (back_to_previous_visible_line_start, reseat_1)
2849 (init_iterator): Empty the bidi cache "stack".
2850 (move_it_in_display_line_to): If iterator ended up at
2851 EOL, but we never saw any buffer positions smaller than
2852 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2853 motion in bidi-reordered lines.
2854 (move_it_in_display_line_to): Record prev_method and prev_pos
2855 immediately before the call to set_iterator_to_next. Fixes cursor
2856 motion in bidi-reordered lines with stretch glyphs and strings
2857 displayed in margins. (Bug#8133) (Bug#8867)
2858 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2859 TO_CHARPOS.
640c8776
SM
2860 (pos_visible_p): Support positions in bidi-reordered lines.
2861 Save and restore bidi cache.
0bb23927
EZ
2862
2863 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2864 (bidi_paragraph_info): Delete unused struct.
2865 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2866 (bidi_cache_start): New variable.
2867 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2868 to zero.
2869 (bidi_cache_fetch_state, bidi_cache_search)
2870 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2871 (bidi_cache_find, bidi_peek_at_next_level)
2872 (bidi_level_of_next_char, bidi_find_other_level_edge)
2873 (bidi_move_to_visually_next): Compare cache index with
2874 bidi_cache_start rather than with zero.
2875 (bidi_fetch_char): Accept new argument STRING; all callers
2876 changed. Support iteration over a string. Support strings with
2877 display properties. Support unibyte strings. Fix the type of
2878 `len' according to what STRING_CHAR_AND_LENGTH expects.
2879 (bidi_paragraph_init, bidi_resolve_explicit_1)
2880 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2881 (bidi_level_of_next_char, bidi_move_to_visually_next):
2882 Support iteration over a string.
0bb23927
EZ
2883 (bidi_set_sor_type, bidi_resolve_explicit_1)
2884 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2885 can now be zero (for strings); special values 0 and -1 were
2886 changed to -1 and -2, respectively.
2887 (bidi_char_at_pos): New function.
2888 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2889 Call it instead of FETCH_MULTIBYTE_CHAR.
2890 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2891 initialized to valid values.
2892 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2893 values.
2894 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2895 the test for valid cached positions. Fix the logic for looking up
2896 the sentinel state in the cache. GCPRO the Lisp string we are
2897 iterating.
2898 (bidi_push_it, bidi_pop_it): New functions.
2899 (bidi_initialize): Initialize the bidi cache start stack pointer.
2900 (bidi_cache_ensure_space): New function, refactored from part of
2901 bidi_cache_iterator_state. Don't assume the required size is just
2902 one BIDI_CACHE_CHUNK away.
2903 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2904 (bidi_count_bytes, bidi_char_at_pos): New functions.
2905 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2906 always valid if bidi_cache_idx is valid.
2907 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2908 is valid if it's going to be used.
2909 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2910 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2911 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2912 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2913 (bidi_find_other_level_edge, bidi_cache_start_stack):
2914 All variables related to cache indices are now EMACS_INT.
c965adc5 2915
0bb23927
EZ
2916 * dispextern.h (struct bidi_string_data): New structure.
2917 (struct bidi_it): New member `string'. Make flag members be 1-bit
2918 fields, and put them last in the struct.
640c8776
SM
2919 (compute_display_string_pos, compute_display_string_end):
2920 Update prototypes.
0bb23927
EZ
2921 (bidi_push_it, bidi_pop_it): Add prototypes.
2922 (struct iterator_stack_entry): New members bidi_p,
2923 paragraph_embedding, and from_disp_prop_p.
2924 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2925 (bidi_shelve_cache, bidi_unshelve_cache):
2926 Declare prototypes.
0bb23927
EZ
2927
2928 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2929 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2930 and vector-like objects.
2931
2932 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2933 cache around display iteration.
2934
2935 * window.c (Fwindow_end, window_scroll_pixel_based)
2936 (displayed_window_lines, Frecenter): Save and restore the bidi
2937 cache around display iteration.
2938
3bbd2265
LMI
29392011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2940
2941 * editfns.c (Fdelete_region): Clarify the use of the named
2942 parameters (bug#6788).
2943
adc47434
MR
29442011-07-14 Martin Rudalics <rudalics@gmx.at>
2945
2946 * indent.c (Fvertical_motion): Set and restore w->pointm when
2947 saving and restoring the window's buffer (Bug#9006).
2948
837c31f8
LMI
29492011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2950
2951 * editfns.c (Fstring_to_char): Clarify just what is returned
2952 (bug#6576). Text by Eli Zaretskii.
2953
ac389d0c
JB
29542011-07-13 Juanma Barranquero <lekktu@gmail.com>
2955
2956 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2957
0be0ce47
EZ
29582011-07-13 Eli Zaretskii <eliz@gnu.org>
2959
2960 * buffer.c (mmap_find): Fix a typo.
2961
cd18e7e3
JB
29622011-07-13 Johan Bockgård <bojohan@gnu.org>
2963
2964 Fix execution of x selection hooks.
2965 * xselect.c (Qx_lost_selection_functions)
2966 (Qx_sent_selection_functions): New vars.
2967 (syms_of_xselect): DEFSYM them.
2968 (x_handle_selection_request): Pass Qx_sent_selection_functions
2969 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2970 (x_handle_selection_clear,x_clear_frame_selections):
2971 Pass Qx_lost_selection_functions rather than
2972 Vx_lost_selection_functions to Frun_hook_with_args.
2973
47ea7f44
PE
29742011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2975
ac389d0c 2976 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2977 The old code sometimes used this field without initializing it.
2978
47ea7f44
PE
2979 * alloc.c (gc_sweep): Don't read past end of array.
2980 In theory, the old code could also have corrupted Emacs internals,
2981 though it'd be very unlikely.
2982
bc985c87
AS
29832011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2984
2985 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2986 argument. (Bug#4026)
bc985c87 2987
0cf34688
LMI
29882011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2989
b3dadd76
LMI
2990 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2991 key" (bug#4257).
2992
0cf34688
LMI
2993 * window.c (Fset_window_start): Doc fix (bug#4199).
2994 (Fset_window_hscroll): Ditto.
2995
270768cd
PE
29962011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2997
077e3dda 2998 Fix minor new problems caught by GCC 4.6.1.
270768cd 2999 * term.c (init_tty): Remove unused local.
490011a6 3000 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3001 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3002 not used otherwise.
270768cd 3003
b1f58454
CY
30042011-07-12 Chong Yidong <cyd@stupidchicken.com>
3005
3006 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3007
22b9578d
LMI
30082011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3009
6e70ab07
LMI
3010 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3011 are the mini-buffer and the echo area (bug#3320).
3012
22b9578d
LMI
3013 * term.c (init_tty): Remove support for supdup, c10 and perq
3014 terminals, which are no longer supported (bug#1482).
3015
8974cc9f
JB
30162011-07-10 Johan Bockgård <bojohan@gnu.org>
3017
3018 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3019
a560d974
JD
30202011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3021
3022 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3023 for non-popups (Bug#3642).
3024
1dae0f0a
AS
30252011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3026
268c2c36 3027 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3028 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3029 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3030 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3031 * data.c (fmod): Likewise.
3032 * dispnew.c (swap_glyphs_in_rows): Likewise.
3033 * emacs.c (memory_warning_signal): Likewise.
3034 * floatfns.c (float_error): Likewise.
3035 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3036 (otf_open, font_otf_capability, generate_otf_features)
3037 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3038 Likewise.
3039 * image.c (pbm_read_file): Likewise.
3040 * indent.c (string_display_width): Likewise.
3041 * intervals.c (check_for_interval, search_for_interval)
3042 (inc_interval_count, count_intervals, root_interval)
3043 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3044 * lread.c (defalias): Likewise.
268c2c36 3045 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3046 * regex.c (set_image_of_range_1, set_image_of_range)
3047 (regex_grow_registers): Likewise.
3048 * sysdep.c (strerror): Likewise.
3049 * termcap.c (valid_filename_p, tprint, main): Likewise.
3050 * tparam.c (main): Likewise.
3051 * unexhp9k800.c (run_time_remap, save_data_space)
3052 (update_file_ptrs, read_header, write_header, calculate_checksum)
3053 (copy_file, copy_rest, display_header): Likewise.
3054 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3055 Likewise.
3056 * xdisp.c (check_it): Likewise.
3057 * xfaces.c (register_color, unregister_color, unregister_colors):
3058 Likewise.
3059 * xfns.c (print_fontset_result): Likewise.
3060 * xrdb.c (member, fatal, main): Likewise.
3061
99033785
PE
30622011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3063
3064 Fix minor problems found by static checking (Bug#9031).
3065 * chartab.c (char_table_set_range, map_sub_char_table):
3066 Remove unused locals.
3067 (uniprop_table): Now static.
3068 * composite.c (_work_char): Remove unused static var.
3069
9cb2ac56
JB
30702011-07-09 Juanma Barranquero <lekktu@gmail.com>
3071
3072 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3073
f25661f0
JD
30742011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3075
3076 * gtkutil.c (qttip_cb): Remove code without function.
3077
8278c4fe
EZ
30782011-07-09 Eli Zaretskii <eliz@gnu.org>
3079
3080 * w32.c (pthread_sigmask): New stub.
3081
1692ae2d 30822011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3083
8a6ebd58 3084 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3085 sigprocmask is portable only for single-threaded applications, and
3086 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3087 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3088 (LIBES): Use it.
3089 * callproc.c (Fcall_process):
3090 * process.c (create_process):
3091 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3092 Use pthread_sigmask, not sigprocmask.
123403e4 3093
1b854618
JD
30942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3095
3096 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3097 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3098 wrong (Bug#8591).
3099
3fe4b549
JD
31002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3101
0ce7e563
JD
3102 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3103 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3104 (xg_hide_tooltip): Fix comment.
3105
3fe4b549
JD
3106 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3107 in registerServicesMenuSendTypes.
3108 (validRequestorForSendType): Don't check ns_return_types.
3109
3110 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3111 ns_return_type.
3112
5df75e47
JR
31132011-07-08 Jason Rumney <jasonr@gnu.org>
3114
22610910
JR
3115 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3116 SH_SHOW for hidden windows (Bug#5482).
3117
5df75e47
JR
3118 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3119 frame struct members of non-existent frames (Bug#6284).
3120
699c10bd
JD
31212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3122
4393663b
JD
3123 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3124 variable firstTime not needed on OSX >= 10.6.
3125 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3126 >= 10.5. Use setKnobProportion, setDoubleValue.
3127
3128 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3129 (MAC_OS_X_VERSION_10_5): Define if not defined.
3130 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3131 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3132 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3133
3134 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3135 cString and lossyCString on OSX >= 10.4
3136
58179cce 3137 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3138 sizeToFit on OSX >= 10.2.
3139
3140 * nsimage.m (allocInitFromFile): Don't use deprecated method
3141 bestRepresentationForDevice on OSX >= 10.6.
3142
3143 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3144 to avoid warning.
3145
3146 * emacs.c: Declare unexec_init_emacs_zone.
3147
a63e0781
JD
3148 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3149
699c10bd
JD
3150 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3151
3152 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3153 on svcsMenu (Bug#8842).
3154
3155 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3156 ns_return_types.
3157 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3158
3159 * nsterm.m (QUTF8_STRING): Declare.
3160 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3161 (validRequestorForSendType): Return type is (id).
3162 Change indexOfObjectIdenticalTo to indexOfObject.
3163 Check if we have local selection before returning self (Bug#8842).
3164 (writeSelectionToPasteboard): Put local selection into paste board
3165 if we have a local selection (Bug#8842).
3166 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3167
3168 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3169 (ns_get_local_selection): Declare.
3170
54e10184
LMI
31712011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3172
9888ff71
LMI
3173 * keymap.c (describe_map_tree): Don't insert a double newline at
3174 the end of the buffer (bug#1169) and return whether we inserted
3175 something.
3176
54e10184
LMI
3177 * callint.c (Fcall_interactively): Change "reading args" to
3178 "providing args" to try to clarify what it does (bug#1010).
3179
15fa4783
KH
31802011-07-07 Kenichi Handa <handa@m17n.org>
3181
3182 * composite.c (composition_compute_stop_pos): Ignore a static
3183 composition starting before CHARPOS (Bug#8915).
3184
3185 * xdisp.c (handle_composition_prop): Likewise.
3186
a8815b00
EZ
31872011-07-07 Eli Zaretskii <eliz@gnu.org>
3188
3189 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3190 (Bug#9015)
3191
ef7b981d 31922011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3193
3194 * character.h (unicode_category_t): New enum type.
3195
3196 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3197 (Qchar_code_property_table): New variable.
3198 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3199 (UNIPROP_COMPRESSED_FORM_P): New macros.
3200 (char_table_ascii): Uncompress the compressed values.
3201 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3202 Uncompress the compressed values.
ac389d0c 3203 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3204 (char_table_ref_and_range): Uncompress the compressed values.
3205 (sub_char_table_set): New arg is_uniprop. Callers changed.
3206 Uncompress the compressed values.
3207 (sub_char_table_set_range): Args changed. Callers changed.
3208 (char_table_set_range): Adjuted for the above change.
3209 (map_sub_char_table): Delete args default_val and parent. Add arg
3210 top. Give decoded values to a Lisp function.
640c8776 3211 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3212 values to a Lisp function. Gcpro more variables.
3213 (uniprop_table_uncompress)
3214 (uniprop_decode_value_run_length): New functions.
3215 (uniprop_decoder, uniprop_decoder_count): New variables.
3216 (uniprop_get_decoder, uniprop_encode_value_character)
3217 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3218 New functions.
3219 (uniprop_encoder, uniprop_encoder_count): New variables.
3220 (uniprop_get_encoder, uniprop_table)
3221 (Funicode_property_table_internal, Fget_unicode_property_internal)
3222 (Fput_unicode_property_internal): New functions.
3223 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3224 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3225 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3226 char-code-property-alist.
3227
640c8776 3228 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3229 Vunicode_category_table.
3230
640c8776 3231 * font.c (font_range): Adjust for the change of
c805dec0
KH
3232 Vunicode_category_table.
3233
76b397fb
DN
32342011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3235
3236 * m/iris4d.h: Remove file, move contents ...
3237 * s/irix6-5.h: ... here.
3238
22b4128e
PE
32392011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3240
3241 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3242 * alloc.c (mark_buffer):
3243 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3244 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3245 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3246 This isn't true in general, and it's particularly not true
3247 if Emacs is configured with --with-wide-int.
3248 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3249 New macros, used in the buffer.c change.
3250
869795d6
JD
32512011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3252
3253 * xsettings.c: Use both GConf and GSettings if both are available.
3254 (store_config_changed_event): Add comment.
3255 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3256 (store_tool_bar_style_changed): New functions.
5e617bc2 3257 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3258 (struct xsettings): Move font inside HAVE_XFT.
3259 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3260 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3261 Move inside HAVE_XFT.
640c8776 3262 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3263 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3264 also.
3265 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3266 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3267 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3268 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3269 (parse_settings): Move check for font inside HAVE_XFT.
3270 (read_settings, apply_xft_settings): Add comment.
3271 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3272 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3273 call store_font_name_changed.
3274 (xft_settings_event): Add comment.
3275 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3276 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3277 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3278 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3279 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3280 (xsettings_get_system_font, xsettings_get_system_normal_font):
3281 Add comment.
869795d6 3282
d8ed26bd
PE
32832011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3284
3285 Random fixes. E.g., (random) never returned negative values.
3286 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3287 subseconds part to the entropy, as that's a bit more random.
3288 Prefer signed to unsigned, since the signedness doesn't matter and
3289 in general we prefer signed. When given a limit, use a
3290 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3291 latter isn't right if USE_2_TAGS_FOR_INTS.
3292 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3293 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3294
cabf1cac
SM
32952011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3296
3297 * textprop.c (text_property_stickiness):
3298 Obey Vtext_property_default_nonsticky.
3299 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3300 * w32fns.c (syms_of_w32fns):
3301 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3302
6e9b2be9
PE
33032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3304
3305 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3306 This is more efficient than Ffile_directory_p and avoids a minor race.
3307
90186c68
LMI
33082011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3309
7c301272
LMI
3310 * buffer.c (Foverlay_put): Say what the return value is
3311 (bug#7835).
3312
c4f2d8d4
LMI
3313 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3314 is a directory before asking whether to use the file name
3315 (bug#7564).
ad637907
LMI
3316 (barf_or_query_if_file_exists): Make the "File is a directory"
3317 error be more correct.
c4f2d8d4 3318
90186c68
LMI
3319 * fns.c (Frequire): Remove the mention of the .gz files, since
3320 that's installation-specific, but keep the mention of
3321 `get-load-suffixes'.
3322
da64016e
PE
33232011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3324
3325 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3326 Report string overflow if the output is too long.
3327
7d47b580
JB
33282011-07-04 Juanma Barranquero <lekktu@gmail.com>
3329
a555cb87
JB
3330 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3331 (syms_of_gnutls): Remove duplicate DEFSYM for
3332 Qgnutls_bootprop_verify_hostname_error, an error for
3333 Qgnutls_bootprop_verify_error (which is no longer used).
3334
7d47b580
JB
3335 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3336 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3337 Also (re)move comments that are misplaced or no longer relevant.
3338
1e49bfab
LMI
33392011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3340
3341 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3342
1485f4c0
CY
33432011-07-03 Chong Yidong <cyd@stupidchicken.com>
3344
3345 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3346 and background color parameters if they have been changed.
3347
a9ab721e
LMI
33482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3349
3350 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3351
cf7cff57
PE
33522011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3353
2e13213d
PE
3354 * xsettings.c (SYSTEM_FONT): Define only when used.
3355 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3356
cf7cff57
PE
3357 * keymap.c (access_keymap_1): Now static.
3358
7a8e04f7
CY
33592011-07-02 Chong Yidong <cyd@stupidchicken.com>
3360
3361 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3362 leave any prefix arg for the up event (Bug#1586).
3363
61352f62
LMI
33642011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3365
69bb1ef7
LMI
3366 * lread.c (syms_of_lread): Mention single symbols defined by
3367 `defvar' or `defconst' (bug#7154).
3368
61352f62 3369 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3370 (Frequire): Mention get-load-suffixes.
61352f62 3371
28545e04
MR
33722011-07-02 Martin Rudalics <rudalics@gmx.at>
3373
3374 * window.h (window): Remove clone_number slot.
3375 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3376 Remove.
3377 (make_parent_window, make_window, saved_window)
3378 (Fset_window_configuration, save_window_save): Don't deal with
3379 clone numbers.
3380 * buffer.c (Qclone_number): Remove declaration.
3381 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3382
3349e122
SM
33832011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3384
3385 Add multiple inheritance to keymaps.
3386 * keymap.c (Fmake_composed_keymap): New function.
3387 (Fset_keymap_parent): Simplify.
3388 (fix_submap_inheritance): Remove.
3389 (access_keymap_1): New function extracted from access_keymap to handle
3390 embedded parents and handle lists of maps.
3391 (access_keymap): Use it.
3392 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3393 (Fcopy_keymap): Handle embedded parents.
3394 (Fcommand_remapping, define_as_prefix): Simplify.
3395 (Fkey_binding): Simplify.
3396 (syms_of_keymap): Move minibuffer-local-completion-map,
3397 minibuffer-local-filename-completion-map,
3398 minibuffer-local-must-match-map, and
3399 minibuffer-local-filename-must-match-map to Elisp.
3400 (syms_of_keymap): Defsubr make-composed-keymap.
3401 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3402 (parse_menu_item): Trivial simplification.
3403
3279eb87
GM
34042011-07-01 Glenn Morris <rgm@gnu.org>
3405
3406 * Makefile.in (SETTINGS_LIBS): Fix typo.
3407
4550efdf
KI
34082011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3409
3410 * coding.c (Fencode_coding_string): Record the last coding system
3411 used, as the function doc string says (bug#8738).
3412
0949d2b6
JD
34132011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3414
3415 * xsettings.c (store_monospaced_changed): Take new font as arg and
3416 check for change against current_mono_font.
3417 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3418 (emacs_settings_constructor, emacs_settings_get_property)
3419 (emacs_settings_set_property, emacs_settings_class_init)
3420 (emacs_settings_init, gsettings_obj): Remove.
3421 (something_changedCB): New function for HAVE_GSETTINGS.
3422 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3423 with value as argument.
3424 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3425 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3426 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3427 "changed".
3428
3429 * xgselect.c: Add defined (HAVE_GSETTINGS).
3430 (xgselect_initialize): Ditto.
3431
3432 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3433 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3434 xg_select.
3435
bbc6b304
PE
34362011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3437
3438 * eval.c (struct backtrace): Simplify and port the data structure.
3439 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3440 signed bit field, as this assumption is not portable and it makes
3441 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3442 "char debug_on_exit : 1" as this is not portable either; instead,
3443 use the portable "unsigned int debug_on_exit : 1". Remove unused
3444 member evalargs. Remove obsolete comments about cc bombing out.
3445
9851bfc5
JD
34462011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3447
51bb811f 3448 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3449 Let HAVE_GSETTINGS override HAVE_GCONF.
3450 (store_monospaced_changed): New function.
3451 (EMACS_SETTINGS): A new type derived from GObject to handle
3452 GSettings notifications.
3453 (emacs_settings_constructor, emacs_settings_get_property)
3454 (emacs_settings_set_property, emacs_settings_class_init):
3455 New functions.
3456 (gsettings_client, gsettings_obj): New variables.
3457 (GSETTINGS_SCHEMA): New define.
3458 (something_changedCB): Call store_monospaced_changed.
3459 (init_gsettings): New function.
3460 (xsettings_initialize): Call init_gsettings.
3461 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3462 to NULL.
3463
640c8776 3464 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3465 GCONF_CFLAGS/LIBS.
3466
5386012d
MR
34672011-06-29 Martin Rudalics <rudalics@gmx.at>
3468
3469 * window.c (resize_root_window, grow_mini_window)
3470 (shrink_mini_window): Rename Qresize_root_window to
3471 Qwindow_resize_root_window and Qresize_root_window_vertically to
3472 Qwindow_resize_root_window_vertically.
3473
f13e0b08
PE
34742011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3475
3476 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3477
94515237
JB
34782011-06-27 Juanma Barranquero <lekktu@gmail.com>
3479
3480 * makefile.w32-in: Redesign dependencies so they reflect more
3481 clearly which files are directly included by each source file,
3482 and not through other includes.
3483
e43b6e43
MR
34842011-06-27 Martin Rudalics <rudalics@gmx.at>
3485
3486 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3487 (sort_overlays, overlay_strings): When an overlay's clone number
3488 matches the window's clone number process the overlay even if
3489 the overlay's window property doesn't match the current window.
3490
d68443dc
MR
3491 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3492 (Fwindow_hchild): Rename to Fwindow_left_child.
3493 (Fwindow_next): Rename to Fwindow_next_sibling.
3494 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3495 (resize_window_check): Rename to window_resize_check.
3496 (resize_window_apply): Rename to window_resize_apply.
3497 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3498 (Fdelete_other_windows_internal, resize_frame_windows)
3499 (Fsplit_window_internal, Fdelete_window_internal)
3500 (grow_mini_window, shrink_mini_window)
3501 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3502
c7e73be5
JD
35032011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3504
3505 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3506 (emacs_fixed_set_min_size): Remove.
3507 (emacs_fixed_new): Take frame as argument.
3508
3509 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3510 (_EmacsFixedPrivate): Remove minwidth/height.
3511 Add struct frame *f.
3512 (emacs_fixed_init): Initialize priv->f.
3513 (get_parent_class, emacs_fixed_set_min_size): Remove.
3514 (emacs_fixed_new): Set priv->f to argument.
3515 (emacs_fixed_get_preferred_width)
3516 (emacs_fixed_get_preferred_height): Use min_width/height from
3517 frames size_hint to set minimum and natural (Bug#8919).
3518 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3519 and use min_width/height from frames size_hint to set
3520 min_width/height (Bug#8919).
3521
3522 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3523 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3524 Fix indentation.
c7e73be5 3525
cf99dcf8
EZ
35262011-06-26 Eli Zaretskii <eliz@gnu.org>
3527
3528 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3529 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3530 called at ZV.
3531
029529ac
CY
35322011-06-26 Chong Yidong <cyd@stupidchicken.com>
3533
3534 * process.c (wait_reading_process_output): Bypass select if
3535 waiting for a cell while ignoring keyboard input, and input is
3536 pending. Suggested by Jan Djärv (Bug#8869).
3537
7a7ef429
PE
35382011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3539
3540 Use gnulib's dup2 module instead of rolling our own.
3541 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3542
11fdef7d 35432011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3544
3545 * dispnew.c (scrolling_window): Before scrolling, turn off a
3546 mouse-highlight in the window being scrolled.
3547
cd3520a4
JB
35482011-06-24 Juanma Barranquero <lekktu@gmail.com>
3549
3550 Move DEFSYM to lisp.h and use everywhere.
3551
3552 * character.h (DEFSYM): Move declaration...
3553 * lisp.h (DEFSYM): ...here.
3554
3555 * gnutls.c:
3556 * minibuf.c:
3557 * w32menu.c:
3558 * w32proc.c:
3559 * w32select.c: Don't include character.h.
3560
3561 * alloc.c (syms_of_alloc):
3562 * buffer.c (syms_of_buffer):
3563 * bytecode.c (syms_of_bytecode):
3564 * callint.c (syms_of_callint):
3565 * casefiddle.c (syms_of_casefiddle):
3566 * casetab.c (init_casetab_once):
3567 * category.c (init_category_once, syms_of_category):
3568 * ccl.c (syms_of_ccl):
3569 * cmds.c (syms_of_cmds):
3570 * composite.c (syms_of_composite):
3571 * dbusbind.c (syms_of_dbusbind):
3572 * dired.c (syms_of_dired):
3573 * dispnew.c (syms_of_display):
3574 * doc.c (syms_of_doc):
3575 * editfns.c (syms_of_editfns):
3576 * emacs.c (syms_of_emacs):
3577 * eval.c (syms_of_eval):
3578 * fileio.c (syms_of_fileio):
3579 * fns.c (syms_of_fns):
3580 * frame.c (syms_of_frame):
3581 * fringe.c (syms_of_fringe):
3582 * insdel.c (syms_of_insdel):
3583 * keymap.c (syms_of_keymap):
3584 * lread.c (init_obarray, syms_of_lread):
3585 * macros.c (syms_of_macros):
3586 * msdos.c (syms_of_msdos):
3587 * print.c (syms_of_print):
3588 * process.c (syms_of_process):
3589 * search.c (syms_of_search):
3590 * sound.c (syms_of_sound):
3591 * syntax.c (init_syntax_once, syms_of_syntax):
3592 * terminal.c (syms_of_terminal):
3593 * textprop.c (syms_of_textprop):
3594 * undo.c (syms_of_undo):
3595 * w32.c (globals_of_w32):
3596 * window.c (syms_of_window):
3597 * xdisp.c (syms_of_xdisp):
3598 * xfaces.c (syms_of_xfaces):
3599 * xfns.c (syms_of_xfns):
3600 * xmenu.c (syms_of_xmenu):
3601 * xsettings.c (syms_of_xsettings):
3602 * xterm.c (syms_of_xterm): Use DEFSYM.
3603
4228cf16
TZ
36042011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3605
cd3520a4 3606 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3607
7fcccf1e
PE
36082011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3609
7efb4e0e
PE
3610 Integer and buffer overflow fixes (Bug#8873).
3611
ff5844ad
PE
3612 * print.c (printchar, strout): Check for string overflow.
3613 (PRINTPREPARE, printchar, strout):
3614 Don't set size unless allocation succeeds.
3615
90532f02
PE
3616 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3617 for sizes. Check for string overflow more accurately.
3618 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3619
6d84508d
PE
3620 * macros.c: Integer and buffer overflow fixes.
3621 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3622 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3623 Use ptrdiff_t, not int, for sizes.
3624 Don't increment bufsize until after realloc succeeds.
3625 Check for size-calculation overflow.
3626 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3627
437b2cb4
PE
3628 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3629
8b9ac8b4
PE
3630 * lread.c: Integer overflow fixes.
3631 (read_integer): Radix is now EMACS_INT, not int,
3632 to improve quality of diagnostics for out-of-range radices.
3633 Calculate buffer size correctly for out-of-range radices.
3634 (read1): Check for integer overflow in radices, and in
3635 read-circle numbers.
82cb60d3
PE
3636 (read_escape): Avoid int overflow.
3637 (Fload, openp, read_buffer_size, read1)
3638 (substitute_object_recurse, read_vector, read_list, map_obarray):
3639 Use ptrdiff_t, not int, for sizes.
3640 (read1): Use EMACS_INT, not int, for sizes.
20270765 3641 Check for size overflow.
8b9ac8b4 3642
7fcccf1e
PE
3643 * image.c (cache_image): Check for size arithmetic overflow.
3644
bfbbd7e7
PE
3645 * lread.c: Integer overflow issues.
3646 (saved_doc_string_size, saved_doc_string_length)
3647 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3648 Now ptrdiff_t, not int.
3649 (read1): Don't assume doc string length fits in int. Check for
3650 out-of-range doc string lengths.
3651 (read_list): Don't assume file position fits in int.
39019e54 3652 (read_escape): Check for hex character overflow.
bfbbd7e7 3653
4e323265
LL
36542011-06-22 Leo Liu <sdl.web@gmail.com>
3655
3656 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3657 Move to minibuffer.el.
3658
85fece3e
PE
36592011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3660
20b84ce9 3661 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3662 The following patches are for when GLYPH_DEBUG && !XASSERT.
3663 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3664 * dispnew.c (flush_stdout):
3665 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3666 Mark as externally visible.
3667 * dispnew.c (check_window_matrix_pointers): Now static.
3668 * dispnew.c (window_to_frame_vpos):
3669 * xfns.c (unwind_create_frame):
3670 * xterm.c (x_check_font): Remove unused local.
3671 * scroll.c (CHECK_BOUNDS):
3672 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3673 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3674 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3675 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3676 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3677 Now static.
3678 (debug_method_add): Use va_list and vsprintf rather than relying
3679 on undefined behavior with wrong number of arguments.
3680 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3681 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3682 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3683 since we're not interested in debugging glyphs with old libraries.
3684 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3685 GCC 4.6.0's static checking.
3686
0766b489
PE
36872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3688
31fd4b32
PE
3689 Integer overflow and signedness fixes (Bug#8873).
3690 A few related buffer overrun fixes, too.
3691
b79e8648
PE
3692 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3693
0766b489
PE
3694 * dispextern.h (struct face.stipple):
3695 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3696 (x_bitmap_mask, x_allocate_bitmap_record)
3697 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3698 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3699 (x_create_bitmap_from_xpm_data):
3700 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3701 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3702 (.bitmaps_last):
3703 * xfaces.c (load_pixmap):
3704 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3705 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3706 (.bitmaps_last, struct x_output.icon_bitmap):
3707 Use ptrdiff_t, not int, for bitmap indexes.
3708 (x_allocate_bitmap_record): Check for size overflow.
3709 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3710
b081724f
PE
3711 Use ptrdiff_t, not int, for overlay counts.
3712 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3713 * editfns.c (overlays_around, get_pos_property):
3714 * textprop.c (get_char_property_and_overlay):
3715 * xdisp.c (next_overlay_change, note_mouse_highlight):
3716 * xfaces.c (face_at_buffer_position):
21514da7
PE
3717 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3718 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3719 (Fnext_overlay_change, Fprevious_overlay_change)
3720 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3721 Use ptrdiff_t, not int, for sizes.
21514da7 3722 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3723
3de73e5e
PE
3724 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3725
2606c57b
PE
3726 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3727 (x_session_initialize): Do not assume string length fits in int.
3728
aaafe47a
PE
3729 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3730 This is unlikely, but can occur if DPI is outlandish.
3731
2674ddc8 3732 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3733 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3734
28154962
PE
3735 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3736 * xrdb.c (magic_file_p, search_magic_path):
3737 Omit last arg SUFFIX; it was always 0. All callers changed.
3738 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3739
7de51af5
PE
3740 * xfont.c (xfont_match): Avoid need for strlen.
3741
25ed6cc3
PE
3742 * xfns.c: Don't assume strlen fits in int.
3743 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3744
4eab31dd
PE
3745 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3746 not unsigned long, as we prefer signed integers. All callers changed.
3747 Detect integer overflow in repeat count.
3748 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3749 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3750
171e2a58
PE
3751 * termcap.c: Don't assume sizes fit in int and never overflow.
3752 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3753 (gobble_line): Check for size-calculation overflow.
3754
ad39faca 3755 * minibuf.c (Fread_buffer):
6e5bb2dc 3756 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3757 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3758 Don't assume string length fits in int.
3759
52c61c22 3760 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3761 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3762
b5b8c9e5
PE
3763 * font.c: Don't assume string length fits in int.
3764 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3765 Use ptrdiff_t, not int.
ccd6111c
PE
3766 (font_intern_prop): Don't assume string length fits in int.
3767 Don't assume integer property fits in fixnum.
3768 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3769
882f0d81 3770 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3771 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3772 Reformulate so as not to need the command string.
3773 Invoke gzip -cd rather than gunzip, as it's more portable.
3774 (lock_info_type, lock_file_1, lock_file):
3775 Don't assume pid_t and time_t fit in unsigned long.
3776 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3777 (current_lock_owner): Prefer signed type for sizes.
3778 Use memcpy, not strncpy, where memcpy is what is really wanted.
3779 Don't assume (via atoi) that time_t and pid_t fit in int.
3780 Check for time_t and/or pid_t out of range, e.g., via a network share.
3781 Don't alloca where an auto var works fine.
3782
93f4cf88
PE
3783 * fileio.c: Fix some integer overflow issues.
3784 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3785 Don't assume string length fits in int.
3786 (directory_file_name): Don't assume string length fits in long.
3787 (make_temp_name): Don't assume pid fits in int, or that its print
3788 length is less than 20.
3789
f3e92b69
PE
3790 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3791
1bfdaf10
PE
3792 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3793
35016e9a
PE
3794 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3795
3d1e65a1
PE
3796 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3797 We prefer signed integers, even for size calculations.
3798
0b963a93
PE
3799 * emacs.c: Don't assume string length fits in 'int'.
3800 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3801 (main): Don't invoke strlen when not needed.
3802
573f4b54
PE
3803 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3804 (XD_DEBUG_MESSAGE): Don't waste a byte.
3805
989f33ba
PE
3806 * callproc.c (getenv_internal_1, getenv_internal)
3807 (Fgetenv_internal):
965d34eb
PE
3808 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3809
e4d29b33
PE
3810 * lread.c (invalid_syntax): Omit length argument.
3811 All uses changed. This doesn't fix a bug, but it simplifies the
3812 code away from its former Hollerith-constant appearance, and it's
3813 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3814 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3815
eb49b136
PE
3816 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3817 This didn't break anything, but it didn't help either.
3818 It's confusing to put a bogus integer in a place where the actual
3819 value does not matter.
9f62aeb1 3820 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3821 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3822
15375a22
PE
3823 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3824 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3825 implementation.
b61cc01c
PE
3826 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3827 We prefer signed types, and the value cannot exceed the EMACS_INT
3828 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3829 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3830 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3831 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3832
53b2623d
PE
3833 * indent.c (sane_tab_width): New function.
3834 (current_column, scan_for_column, Findent_to, position_indentation)
3835 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3836 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3837
51cab52b 3838 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3839
f2ed8a70
PE
3840 * lisp.h (lint_assume): New macro.
3841 * composite.c (composition_gstring_put_cache):
3842 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3843
abe80cc6
PE
3844 * editfns.c, insdel.c:
3845 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3846
b02c740e
PE
3847 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3848
ebc96716
PE
3849 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3850
b4e50fa0 3851 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3852 Use much-faster test for byte-length change.
311d5d7c 3853 Don't assume string byte-length fits in 'int'.
a4cf38e4 3854 Check that character arg fits in 'int'.
85461888 3855 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3856
c0c1ee9f
PE
3857 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3858
a498d7f4
PE
3859 * fns.c (concat): Catch string overflow earlier.
3860 Do not rely on integer wraparound.
3861
51cab52b
PE
3862 * dispextern.h (struct it.overlay_strings_charpos)
3863 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3864 * xdisp.c (forward_to_next_line_start)
3865 (back_to_previous_visible_line_start)
3866 (reseat_at_next_visible_line_start, next_element_from_buffer):
3867 Don't arbitrarily truncate the value of 'selective' to int.
3868
76031fad
PE
3869 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3870
5eb55db9
PE
3871 * composite.c: Don't truncate sizes to 'int'.
3872 (composition_gstring_p, composition_reseat_it)
3873 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3874 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3875 not EMACS_UINT, for indexes.
5eb55db9 3876
0703a717
PE
3877 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3878
d6202519
PE
3879 * buffer.c: Include <verify.h>.
3880 (struct sortvec.priority, struct sortstr.priority):
8961a454 3881 Now EMACS_INT, not int.
c20998a7 3882 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3883 (struct sortstr.size, record_overlay_string)
3884 (struct sortstrlist.size, struct sortlist.used):
3885 Don't truncate size to int.
3886 (record_overlay_string): Check for size-calculation overflow.
d6202519 3887 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3888
d5a19415
JM
38892011-06-22 Jim Meyering <meyering@redhat.com>
3890
029529ac 3891 Don't leak an XBM-image-sized buffer
d5a19415
JM
3892 * image.c (xbm_load): Free the image buffer after using it.
3893
a9041e6c
PE
38942011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3895
3896 Port to Sun C.
3897 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3898 that Sun C diagnosed.
3899 * fns.c (secure_hash): Fix pointer signedness issue.
3900 * intervals.c (static_offset_intervals): New function.
3901 (offset_intervals): Use it.
3902
7f3f739f
LL
39032011-06-21 Leo Liu <sdl.web@gmail.com>
3904
3905 * deps.mk (fns.o):
3906 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3907 sha512.h.
3908
3909 * fns.c (secure_hash): Rename from crypto_hash_function and change
3910 the first arg to accept symbols.
5b66d427 3911 (Fsecure_hash): New primitive.
7f3f739f
LL
3912 (syms_of_fns): New symbols.
3913
76147d94
DD
39142011-06-20 Deniz Dogan <deniz@dogan.se>
3915
3916 * process.c (Fset_process_buffer): Clarify return value in
3917 docstring.
3918
7d7d0045
CY
39192011-06-18 Chong Yidong <cyd@stupidchicken.com>
3920
3921 * dispnew.c (add_window_display_history): Use BVAR.
3922
3923 * xdisp.c (debug_method_add): Use BVAR.
3924 (check_window_end, dump_glyph_matrix, dump_glyph)
3925 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3926
3927 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3928 Likewise.
3929
3930 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3931 check till after the cache is created in init_frame_faces.
3932
ff2bc410
SM
39332011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3934
3935 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3936
28177add
PE
39372011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3938
dd3482fe
PE
3939 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3940 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3941 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3942
393d71f3 3943 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3944 * fileio.c (Finsert_file_contents):
3945 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3946 Remove the old (too-loose) buffer overflow checks.
3947 They weren't needed, since make_gap checks for buffer overflow.
3948 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3949 The old code merely checked for Emacs fixnum overflow, and relied
3950 on undefined (wraparound) behavior. The new code avoids undefined
3951 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3952
2e6813b0 3953 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3954 Tune. Don't use wider integers than needed. Don't use alloca.
3955 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3956
599a9e4f
PE
3957 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3958
99561444
PE
3959 * insdel.c, lisp.h (buffer_overflow): New function.
3960 (insert_from_buffer_1, replace_range, replace_range_2):
3961 * insdel.c (make_gap_larger):
3962 * editfns.c (Finsert_char):
3963 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3964
28177add
PE
3965 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3966
e69dafad
PE
39672011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3968
a7af7fde 3969 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3970
b1c46f02
PE
3971 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3972 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3973
e69dafad
PE
3974 * fileio.c: Don't assume EMACS_INT fits in off_t.
3975 (emacs_lseek): New static function.
3976 (Finsert_file_contents, Fwrite_region): Use it.
3977 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3978
566684ea
PE
3979 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3980
e6966cd6
PE
3981 * fns.c: Don't overflow int when computing a list length.
3982 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3983 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3984 truncation on 64-bit hosts. Check for QUIT every
3985 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3986 faster and is responsive enough.
3987 (Flength): Report an error instead of overflowing an integer.
3988 (Fsafe_length): Return a float if the value is not representable
3989 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3990 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3991 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3992
dd0b0efb
PE
3993 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3994 (header_size, word_size): New constants.
3995 (allocate_vectorlike): Don't check size overflow here.
3996 (allocate_vector): Check it here instead, since this is the only
3997 caller of allocate_vectorlike that could cause overflow.
3998 Check that the new vector's length is representable as a fixnum.
3999
86fe5cfe
PE
4000 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4001 The previous code was bogus. For example, next_almost_prime (32)
4002 returned 39, which is undesirable as it is a multiple of 3; and
4003 next_almost_prime (24) returned 25, which is a multiple of 5 so
4004 why was the code bothering to check for multiples of 7?
4005
80e88859
PE
4006 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4007
4a2f0ad6
PE
4008 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4009
f66c7cf8
PE
4010 Variadic C functions now count arguments with ptrdiff_t.
4011 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4012 Back then I didn't know that the Emacs coding style prefers signed int.
4013 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4014 were being counted with int, which may truncate counts on 64-bit
4015 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4016 * lisp.h (struct Lisp_Subr.function.aMANY)
4017 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4018 Arg counts are now ptrdiff_t, not size_t.
4019 All variadic functions and their callers changed accordingly.
4020 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4021 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4022 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4023 * callint.c (Fcall_interactively): Check arg count for overflow,
4024 to avoid potential buffer overrun. Use signed char, not 'int',
4025 for 'varies' array, so that we needn't bother to check its size
4026 calculation for overflow.
4027 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4028 * eval.c (apply_lambda):
4029 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4030 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4031 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4032
a1759b76
PE
4033 * callint.c (Fcall_interactively): Don't use index var as event count.
4034
d96be9fc
PE
4035 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4036 * mem-limits.h (SIZE): Remove; no longer used.
4037
a690a978 4038 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4039
578c21e6
PE
4040 Remove unnecessary casts.
4041 * xterm.c (x_term_init):
4042 * xfns.c (x_set_border_pixel):
4043 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4044 These aren't needed now that we assume ANSI C.
4045
96f53c6c
PE
4046 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4047 It's more likely to cause problems (due to unsigned overflow)
4048 than to cure them.
4049
83c77d31
PE
4050 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4051
ee2079f1
PE
4052 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4053
6da65536
PE
4054 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4055
7147c4a4
PE
4056 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4057
193e32d9
PE
4058 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4059
e5533da6
PE
4060 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4061
9910e595
PE
4062 GLYPH_CODE_FACE returns EMACS_INT, not int.
4063 * dispextern.h (merge_faces):
4064 * xfaces.c (merge_faces):
01103c44
PE
4065 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4066 Don't assume EMACS_INT fits in int.
9910e595 4067
2638320e
PE
4068 * character.h (CHAR_VALID_P): Remove unused parameter.
4069 * fontset.c, lisp.h, xdisp.c: All uses changed.
4070
045eb8d9
PE
4071 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4072
c1f134b5
PE
4073 * fns.c (concat): Minor tuning based on overflow analysis.
4074 This doesn't fix any bugs. Use int to hold character, instead
4075 of constantly refetching from Emacs object. Use XFASTINT, not
4076 XINT, for value known to be a character. Don't bother comparing
4077 a single byte to 0400, as it's always less.
4078
395fcb93 4079 * floatfns.c (Fexpt):
327eeec8
PE
4080 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4081
abbd3d23
PE
4082 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4083 for characters.
4084
684a03ef
PE
4085 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4086
0fed43f3
PE
4087 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4088 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4089 incorrectly succeed when S was a string, because 4294967386 was
4090 truncated before it was used.
4091
8fd02eb7
PE
4092 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4093 Otherwise, an out-of-range integer could cause undefined behavior
4094 on a 64-bit host.
4095
f8c86b69
PE
4096 * composite.c: Use int, not EMACS_INT, for characters.
4097 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4098 EMACS_INT, for values that are known to be in character range.
4099 This doesn't fix any bugs but is the usual style inside Emacs and
4100 may generate better code on 32-bit machines.
4101
34206dd2
PE
4102 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4103 This is for reasons similar to the recent CHAR_STRING fix.
4104 * charset.c (Fencode_char): Check that character arg is actually
4105 a character. Pass an int to ENCODE_CHAR.
4106 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4107 wider than 'int', as a compile-time check to prevent future regressions
4108 in this area.
4109
c5958d4c 4110 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4111
4112 Make sure a 64-bit char is never passed to CHAR_STRING.
4113 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4114 by silently ignoring the top 32 bits, allowing some values
4115 that were far too large to be valid characters.
4116 * character.h: Include <verify.h>.
4117 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4118 arguments are no wider than unsigned, as a compile-time check
4119 to prevent future regressions in this area.
4120 * data.c (Faset):
01103c44 4121 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4122 (Fsubst_char_in_region):
4123 * fns.c (concat):
4124 * xdisp.c (decode_mode_spec_coding):
4125 Adjust to CHAR_STRING's new requirement.
4126 * editfns.c (Finsert_char, Fsubst_char_in_region):
4127 * fns.c (concat): Check that character args are actually
4128 characters. Without this test, these functions did the wrong
4129 thing with wildly out-of-range values on 64-bit hosts.
4130
d37ca623
PE
4131 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4132 These casts should not be needed on 32-bit hosts, either.
4133 * keyboard.c (read_char):
4134 * lread.c (Fload): Remove casts to unsigned.
4135
ea204efb
PE
4136 * lisp.h (UNSIGNED_CMP): New macro.
4137 This fixes comparison bugs on 64-bit hosts.
4138 (ASCII_CHAR_P): Use it.
4139 * casefiddle.c (casify_object):
01103c44 4140 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4141 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4142 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4143 * dispextern.h (FACE_FROM_ID):
4144 * keyboard.c (read_char): Use UNSIGNED_CMP.
4145
41cb286c
PE
4146 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4147 not to EMACS_INT, to avoid GCC warning.
4148
4a1b9832
PE
4149 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4150
55daad71
PE
4151 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4152 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4153 isn't needed on 32-bit machines.
8f95c75c 4154
01103c44
PE
4155 * buffer.c (Fgenerate_new_buffer_name):
4156 Use EMACS_INT for count, not int.
0ceccced 4157 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4158
4159 * data.c (Qcompiled_function): Now static.
4160
c6f072e7
PE
4161 * window.c (window_body_lines): Now static.
4162
20ce5912
PE
4163 * image.c (gif_load): Rename local to avoid shadowing.
4164
9c4c5f81
PE
4165 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4166 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4167 * alloc.c (make_save_value): Integer argument is now of type
4168 ptrdiff_t, not int.
4169 (mark_object): Use ptrdiff_t, not int.
4170 * lisp.h (pD): New macro.
4171 * print.c (print_object): Use it.
4172
c0c5c8ae
PE
4173 * alloc.c: Use EMACS_INT, not int, to count objects.
4174 (total_conses, total_markers, total_symbols, total_vector_size)
4175 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4176 (total_free_floats, total_floats, total_free_intervals)
4177 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4178 Now EMACS_INT, not int. All uses changed.
4179 (Fgarbage_collect): Compute overall total using a double, so that
4180 integer overflow is less likely to be a problem. Check for overflow
4181 when converting back to an integer.
5a25e253
PE
4182 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4183 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4184 These were 'int' variables that could overflow on 64-bit hosts;
4185 they were never used, so remove them instead of repairing them.
211a0b2a 4186 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4187 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4188 Previously, this ceilinged at INT_MAX, but that doesn't work on
4189 64-bit machines.
e46bb31a 4190 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4191
c78baabf 4192 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4193 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4194 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4195 when a (possibly-narrower) signed value would do just as well.
4196 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4197
c9d624c6
PE
4198 * alloc.c: Catch some string size overflows that we were missing.
4199 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4200 for convenience in STRING_BYTES_MAX.
4201 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4202 The definition here is exact; the one in lisp.h was approximate.
4203 (allocate_string_data): Check for string overflow. This catches
4204 some instances we weren't catching before. Also, it catches
4205 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4206 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4207 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4208
c9d624c6
PE
4209 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4210 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4211 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4212
353032ce
PE
4213 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4214
2bccce07
PE
4215 * alloc.c (Fmake_string): Check for out-of-range init.
4216
0ac30604
SM
42172011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4218
4219 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4220
c195f2de
JD
42212011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4222
4223 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4224 xg_get_default_scrollbar_width.
4225
4226 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4227 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4228 (style_changed_cb): Call update_theme_scrollbar_width and call
4229 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4230 all frames (Bug#8505).
4231 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4232 Call gtk_window_set_resizable if HAVE_GTK3.
4233 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4234 and height if HAVE_GTK3 (Bug#8505).
4235 (scroll_bar_width_for_theme): New variable.
4236 (update_theme_scrollbar_width): New function.
4237 (xg_get_default_scrollbar_width): Move code to
4238 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4239 (xg_initialize): Call update_theme_scrollbar_width.
4240
4241 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4242
4243 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4244
e10ac9f1
MR
42452011-06-12 Martin Rudalics <rudalics@gmx.at>
4246
4247 * frame.c (make_frame): Call other_buffer_safely instead of
4248 other_buffer.
4249
4250 * window.c (temp_output_buffer_show): Call display_buffer with
4251 second argument Vtemp_buffer_show_specifiers and reset latter
4252 immediately after the call.
4253 (Vtemp_buffer_show_specifiers): New variable.
4254 (auto_window_vscroll_p, next_screen_context_lines)
4255 (Vscroll_preserve_screen_position): Remove leading asterisks from
4256 doc-strings.
4257
2d3c217e 42582011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4259
7b7f97e8 4260 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4261 * buffer.c (Qclone_number): Remove for now, as it's unused.
4262 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4263 (record_buffer): Remove unused local.
4264 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4265 (set_frame_buffer_list): Remove; unused.
4266 * frame.h (other_visible_frames): Remove decl.
4267 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4268 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4269 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4270 if HAVE_GPM.
4271 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4272 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4273 Define only if HAVE_GPM.
4274 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4275 (update_hints_inhibit): Remove; never set. All uses removed.
4276 * widgetprv.h (emacsFrameClassRec): Remove decl.
4277 * window.c (delete_deletable_window): Now returns void, since it
4278 wasn't returning anything.
4279 (compare_window_configurations): Remove unused locals.
4280 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4281 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4282 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4283 the same widths as pointers. This follows up on the 2011-05-06 patch.
4284 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4285 * xterm.h: Likewise.
4286 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4287
1384b89e
JB
42882011-06-12 Juanma Barranquero <lekktu@gmail.com>
4289
4290 * makefile.w32-in: Update dependencies.
4291 (LISP_H): Add lib/intprops.h.
4292
1100a63c
CY
42932011-06-11 Chong Yidong <cyd@stupidchicken.com>
4294
4295 * image.c (gif_load): Add animation frame delay to the metadata.
4296 (syms_of_image): Use DEFSYM. New symbol `delay'.
4297
6198ccd0
MR
42982011-06-11 Martin Rudalics <rudalics@gmx.at>
4299
4300 * window.c (delete_deletable_window): Re-add.
4301 (Fset_window_configuration): Rewrite to handle dead buffers and
4302 consequently deletable windows.
4303 (window_tree, Fwindow_tree): Remove. Supply functionality in
4304 window.el.
4305 (compare_window_configurations): Simplify code.
4306
b6e3633c
AS
43072011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4308
1ab0dee5
AS
4309 * image.c (imagemagick_load_image): Fix type mismatch.
4310 (Fimagemagick_types): Likewise.
4311
b6e3633c
AS
4312 * window.h (replace_buffer_in_windows): Declare.
4313
9397e56f
MR
43142011-06-11 Martin Rudalics <rudalics@gmx.at>
4315
4316 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4317 Qclone_number. Remove external declaration of Qdelete_window.
4318 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4319 code.
640c8776
SM
4320 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4321 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4322 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4323 buffer list implementation.
4324 (other_buffer_safely): New function.
4325 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4326 calls to replace_buffer_in_windows and
4327 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4328 if allowed.
4329 (record_buffer): Inhibit quitting and rewrite using quittable
4330 functions. Run Qbuffer_list_update_hook if allowed.
4331 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4332 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4333 Move switch-to-buffer to window.el.
9397e56f
MR
4334 (bury-buffer): Move to window.el.
4335 (Vbuffer_list_update_hook): New variable.
4336
4337 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4338 section.
4339
4340 * window.h (resize_frame_windows): Move up in code.
4341 (Fwindow_frame): Remove EXFUN.
4342 (replace_buffer_in_all_windows): Remove prototype.
4343 (replace_buffer_in_windows_safely): Add prototype.
4344
4345 * window.c: Declare Qdelete_window static again. Move down
4346 declaration of select_count.
4347 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4348 (Fother_window): Move to window.el.
4349 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4350 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4351 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4352 window.el.
4353 (replace_buffer_in_windows): Implement by calling
4354 Qreplace_buffer_in_windows.
4355 (replace_buffer_in_all_windows): Remove with some functionality
4356 moved into replace_buffer_in_windows_safely.
4357 (replace_buffer_in_windows_safely): New function.
4358 (select_window_norecord, select_frame_norecord): Move in front
4359 of run_window_configuration_change_hook. Remove now obsolete
4360 declarations.
640c8776
SM
4361 (Fset_window_buffer): Rewrite doc-string.
4362 Call Qrecord_window_buffer.
9397e56f
MR
4363 (keys_of_window): Move binding for other-window to window.el.
4364
b50691aa
CY
43652011-06-11 Chong Yidong <cyd@stupidchicken.com>
4366
4367 * dispextern.h (struct image): Replace data member, whose int_val
4368 and ptr_val fields were not used by anything, with a single
4369 lisp_val object.
4370
4371 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4372 (gif_clear_image, gif_load, imagemagick_load_image)
4373 (gs_clear_image, gs_load): Callers changed.
4374
3f754b86
PE
43752011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4376
cca69397
PE
4377 * buffer.h: Include <time.h>, for time_t.
4378 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4379
109e28d0
PE
4380 Fix minor problems found by static checking.
4381
60737f02
PE
4382 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4383
4b66faf3
PE
4384 Make identifiers static if they are not used in other modules.
4385 * data.c (Qcompiled_function, Qframe, Qvector):
4386 * image.c (QimageMagick, Qsvg):
4387 * minibuf.c (Qmetadata):
4388 * window.c (resize_window_check, resize_root_window): Now static.
4389 * window.h (resize_window_check, resize_root_window): Remove decls.
4390
109e28d0
PE
4391 * window.c (window_deletion_count, delete_deletable_window):
4392 Remove; unused.
46a4ce9e
PE
4393 (window_body_lines): Now static.
4394 (Fdelete_other_windows_internal): Mark vars as initialized.
4395 Make sure 'resize_failed' is initialized.
4396 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4397 (resize_window_apply): Remove unused local.
4398 * window.h (delete_deletable_window): Remove decl.
4399
109e28d0 4400 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4401 (imagemagick_load_image): Fix pointer signedness problem by changing
4402 last arg from unsigned char * to char *. All uses changed.
4403 Also, fix a local for similar reasons.
4404 Remove unused locals. Remove locals to avoid shadowing.
4405 (fn_rsvg_handle_free): Remove; unused.
4406 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4407 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4408
3f754b86
PE
4409 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4410
2547adb1
CY
44112011-06-10 Chong Yidong <cyd@stupidchicken.com>
4412
4413 * image.c (gif_load): Fix omitted cast error introduced by
4414 2011-06-06 change.
4415
2c8e37d4
MR
44162011-06-10 Martin Rudalics <rudalics@gmx.at>
4417
4418 * window.h (resize_proportionally, orig_total_lines)
4419 (orig_top_line): Remove from window structure.
4420 (set_window_height, set_window_width, change_window_heights)
4421 (Fdelete_window): Remove prototypes.
4422 (resize_frame_windows): Remove duplicate declaration.
4423
440a42e3
EZ
44242011-06-10 Eli Zaretskii <eliz@gnu.org>
4425
4426 * window.h (resize_frame_windows, resize_window_check)
4427 (delete_deletable_window, resize_root_window)
4428 (resize_frame_windows): Declare prototypes.
4429
4430 * window.c (resize_window_apply): Make definition be "static" to
4431 match the prototype.
4432
562dd5e9
MR
44332011-06-10 Martin Rudalics <rudalics@gmx.at>
4434
4435 * window.c: Remove declarations of Qwindow_size_fixed,
4436 window_min_size_1, window_min_size_2, window_min_size,
4437 size_window, window_fixed_size_p, enlarge_window, delete_window.
4438 Remove static from declaration of Qdelete_window, it's
4439 temporarily needed by Fbury_buffer.
4440 (replace_window): Don't assign orig_top_line and
4441 orig_total_lines.
4442 (Fdelete_window, delete_window): Remove. Window deletion is
4443 handled by window.el.
640c8776
SM
4444 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4445 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4446 (Fdelete_other_windows): Remove. Deleting other windows is
4447 handled by window.el.
4448 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4449 handled in window.el.
4450 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4451 Window minimum sizes are handled in window.el.
4452 (shrink_windows, size_window, set_window_height)
4453 (set_window_width, change_window_heights, window_height)
4454 (window_width, CURBEG, CURSIZE, enlarge_window)
4455 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4456 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4457 handled in window.el.
4458 (make_dummy_parent): Rename to make_parent_window and give it a
4459 second argument horflag.
4460 (make_window): Don't set resize_proportionally any more.
4461 (Fsplit_window): Remove. Windows are split in window.el.
4462 (save_restore_action, save_restore_orig_size)
4463 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4464 Resize mini windows in window.el.
4465 (grow_mini_window, shrink_mini_window): Implement by calling
4466 Qresize_root_window_vertically, resize_window_check and
4467 resize_window_apply.
640c8776
SM
4468 (saved_window, Fset_window_configuration, save_window_save):
4469 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4470 resize_proportionally.
4471 (window_min_height, window_min_width): Move to window.el.
4472 (keys_of_window): Move bindings for delete-other-windows,
4473 split-window, delete-window and enlarge-window to window.el.
4474
4475 * buffer.c: Temporarily extern Qdelete_window.
4476 (Fbury_buffer): Temporarily call Qdelete_window instead of
4477 Fdelete_window (Fbury_buffer will move to window.el soon).
4478
4479 * frame.c (set_menu_bar_lines_1): Remove code handling
4480 orig_top_line and orig_total_lines.
4481
4482 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4483 set_window_height but set heights directly.
4484 (change_frame_size_1): Use resize_frame_windows.
4485
4486 * xdisp.c (init_xdisp): Don't use set_window_height but set
4487 heights directly.
4488
640c8776
SM
4489 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4490 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4491 run_window_configuration_change_hook.
4492
4493 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4494 instead of change_window_heights and run
4495 run_window_configuration_change_hook.
4496
1a13852e
MR
44972011-06-09 Martin Rudalics <rudalics@gmx.at>
4498
4499 * window.c (replace_window): Rename second argument REPLACEMENT to
4500 NEW. New third argument SETFLAG. Rewrite.
4501 (delete_window, make_dummy_parent): Call replace_window with
4502 third argument 1.
4503 (window_list_1): Move down in code.
4504 (run_window_configuration_change_hook): Move set_buffer part
4505 before select_frame_norecord part in order to unwind correctly.
4506 Rename count1 to count.
4507 (recombine_windows, delete_deletable_window, resize_root_window)
4508 (Fdelete_other_windows_internal)
4509 (Frun_window_configuration_change_hook, make_parent_window)
4510 (resize_window_check, resize_window_apply, Fresize_window_apply)
4511 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4512 (Fdelete_window_internal, Fresize_mini_window_internal):
4513 New functions.
1a13852e
MR
4514 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4515
f3d1777e
MR
45162011-06-08 Martin Rudalics <rudalics@gmx.at>
4517
496e208e
MR
4518 * window.h (window): Add some new members to window structure -
4519 normal_lines, normal_cols, new_total, new_normal, clone_number,
4520 splits, nest, prev_buffers, next_buffers.
4521 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4522 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4523
f3d1777e
MR
4524 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4525 Remove.
496e208e
MR
4526 (make_dummy_parent): Set new members of windows structure.
4527 (make_window): Move down in code. Handle new members of window
4528 structure.
4529 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4530 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4531 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4532 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4533 (Fset_window_next_buffers, Fset_window_clone_number):
4534 New functions.
496e208e
MR
4535 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4536 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4537 Doc-string fixes.
4538 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4539 Argument WINDOW can be now internal window too.
4540 (Fwindow_use_time): Move up in code.
4541 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4542 Rewrite doc-string.
4543 (Fset_window_configuration, saved_window)
4544 (Fcurrent_window_configuration, save_window_save): Handle new
4545 members of window structure.
b9e809c2
MR
4546 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4547 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4548 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4549 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4550 Qget_mru_window, Qresize_root_window,
4551 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4552 Qauto_buffer_name; staticpro them.
f3d1777e 4553
abde8f8c
MR
45542011-06-07 Martin Rudalics <rudalics@gmx.at>
4555
4556 * window.c (Fwindow_total_size, Fwindow_left_column)
4557 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4558 (Fwindow_list_1): New functions.
4559 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4560 (Fwindow_width, Fscroll_left, Fscroll_right):
4561 Use window_body_cols instead of window_box_text_cols.
4562 (delete_window, Fset_window_configuration):
4563 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4564 (delete_all_subwindows): Take a window as argument and not a
4565 structure. Rewrite.
190b47e6
MR
4566 (window_loop): Remove handling of GET_LRU_WINDOW and
4567 GET_LARGEST_WINDOW.
4568 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4569
4570 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4571 window_box_text_cols. delete_all_subwindows now takes a
4572 Lisp_Object as argument.
abde8f8c 4573
640c8776
SM
4574 * indent.c (compute_motion, Fcompute_motion):
4575 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4576
fa8a67e6
MR
4577 * frame.c (delete_frame): Call delete_all_subwindows with root
4578 window as argument.
4579
a54e3482
DC
45802011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4581
4582 * fns.c (Fputhash): Document return value.
4583
60002bf5
CY
45842011-06-06 Chong Yidong <cyd@stupidchicken.com>
4585
4586 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4587
0c671da6 45882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4589
b862a52a 4590 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4591
be44ca6c
PE
4592 Check for overflow when converting integer to cons and back.
4593 * charset.c (Fdefine_charset_internal, Fdecode_char):
4594 Use cons_to_unsigned to catch overflow.
4595 (Fencode_char): Use INTEGER_TO_CONS.
4596 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4597 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4598 * data.c (long_to_cons, cons_to_long): Remove.
4599 (cons_to_unsigned, cons_to_signed): New functions.
4600 These signal an error for invalid or out-of-range values.
4601 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4602 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4603 * font.c (Ffont_variation_glyphs):
4604 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4605 * lisp.h: Include <intprops.h>.
4606 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4607 (cons_to_signed, cons_to_unsigned): New decls.
4608 (long_to_cons, cons_to_long): Remove decls.
4609 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4610 (Fprimitive_undo): Use CONS_TO_INTEGER.
4611 * xfns.c (Fx_window_property): Likewise.
4612 * xselect.c: Include <limits.h>.
4613 (x_own_selection, selection_data_to_lisp_data):
4614 Use INTEGER_TO_CONS.
4615 (x_handle_selection_request, x_handle_selection_clear)
4616 (x_get_foreign_selection, Fx_disown_selection_internal)
4617 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4618 (lisp_data_to_selection_data): Use cons_to_unsigned.
4619 (x_fill_property_data): Use cons_to_signed.
4620 Report values out of range.
4621
d1f3d2af
PE
4622 Check for buffer and string overflow more precisely.
4623 * buffer.h (BUF_BYTES_MAX): New macro.
4624 * lisp.h (STRING_BYTES_MAX): New macro.
4625 * alloc.c (Fmake_string):
4626 * character.c (string_escape_byte8):
4627 * coding.c (coding_alloc_by_realloc):
4628 * doprnt.c (doprnt):
4629 * editfns.c (Fformat):
4630 * eval.c (verror):
4631 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4632 since they may not be the same number.
4633 * editfns.c (Finsert_char):
4634 * fileio.c (Finsert_file_contents):
4635 Likewise for BUF_BYTES_MAX.
4636
dd52fcea
PE
4637 * image.c: Use ptrdiff_t, not int, for sizes.
4638 (slurp_file): Switch from int to ptrdiff_t.
4639 All uses changed.
4640 (slurp_file): Check that file size fits in both size_t (for
4641 malloc) and ptrdiff_t (for sanity and safety).
4642
7f9bbdbb
PE
4643 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4644 if b->modtime has its maximal value.
4645
dfe18f82
PE
4646 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4647
84acfcf0
PE
4648 Don't assume time_t can fit into int.
4649 * buffer.h (struct buffer.modtime): Now time_t, not int.
4650 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4651 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4652
ccd9a01a
PE
4653 Minor fixes for signed vs unsigned integers.
4654 * character.h (MAYBE_UNIFY_CHAR):
4655 * charset.c (maybe_unify_char):
4656 * keyboard.c (read_char, reorder_modifiers):
4657 XINT -> XFASTINT, since the integer must be nonnegative.
4658 * ftfont.c (ftfont_spec_pattern):
4659 * keymap.c (access_keymap, silly_event_symbol_error):
4660 XUINT -> XFASTINT, since the integer must be nonnegative.
4661 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4662 since it makes no difference and we prefer signed.
4663 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4664 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4665 nonnegative.
4666
d6d100dd
SM
46672011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4668
4669 * window.h (Fwindow_frame): Declare.
4670
2b6148e4
PE
46712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4672
4673 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4674 (SPARE_MEMORY): Always define.
4675 (LARGE_REQUEST): Remove.
4676 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4677
f230ecc9
MR
46782011-06-06 Martin Rudalics <rudalics@gmx.at>
4679
727e958e
MR
4680 * lisp.h: Move EXFUNS for Fframe_root_window,
4681 Fframe_first_window and Fset_frame_selected_window to window.h.
4682
4683 * window.h: Move EXFUNS for Fframe_root_window,
4684 Fframe_first_window and Fset_frame_selected_window here from
4685 lisp.h.
4686
4687 * frame.c (Fwindow_frame, Fframe_first_window)
4688 (Fframe_root_window, Fframe_selected_window)
4689 (Fset_frame_selected_window): Move to window.c.
4690 (Factive_minibuffer_window): Move to minibuf.c.
4691 (Fother_visible_frames_p): New function.
4692
4693 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4694
f230ecc9
MR
4695 * window.c (decode_window, decode_any_window): Move up in code.
4696 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4697 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4698 (Fwindow_buffer): Move up and rewrite doc-string.
4699 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4700 (Fwindow_prev): New functions.
727e958e
MR
4701 (Fwindow_frame): Move here from frame.c. Accept any window as
4702 argument.
4703 (Fframe_root_window, Fframe_first_window)
4704 (Fframe_selected_window): Move here from frame.c. Accept frame
4705 or arbitrary window as argument. Update doc-strings.
4706 (Fminibuffer_window): Move up in code.
4707 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4708 (Fset_frame_selected_window): Move here from frame.c.
4709 Marginal rewrite.
727e958e
MR
4710 (Fselected_window, select_window, Fselect_window): Move up in
4711 code. Minor doc-string fixes.
f230ecc9 4712
4d09bcf6
PE
47132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4714
4715 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4716 Do not assume that spare memory exists; that assumption is valid
4717 only if SYSTEM_MALLOC.
4718 (LARGE_REQUEST): New macro, so that the issue of large requests
4719 is separated from the issue of spare memory.
4720
810928a2
AS
47212011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4722
172418ad
AS
4723 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4724 format. (Bug#8806)
4725
43f862f7
AS
4726 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4727
810928a2
AS
4728 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4729 before statements.
4730
a059fe24
JD
47312011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4732
4733 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4734
4735 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4736
4737 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4738 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4739
989bf368
JB
47402011-06-05 Juanma Barranquero <lekktu@gmail.com>
4741
4742 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4743
4b80f674
CY
47442011-06-04 Chong Yidong <cyd@stupidchicken.com>
4745
4746 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4747 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4748 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4749 New error handlers.
4b80f674
CY
4750 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4751 Obey Vx_select_enable_clipboard_manager. Catch errors in
4752 x_clipboard_manager_save (Bug#8779).
4753 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4754 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4755
99a33b77 47562011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4757
4758 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4759
99a33b77 47602011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4761
4762 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4763 in the current matrix if keep_current_p is non-zero.
4764
8264569d
EZ
47652011-06-04 Eli Zaretskii <eliz@gnu.org>
4766
4767 * bidi.c (bidi_level_of_next_char): Fix last change.
4768
57f97249
EZ
47692011-06-03 Eli Zaretskii <eliz@gnu.org>
4770
fec2107c 4771 Support bidi reordering of text covered by display properties.
57f97249 4772
fec2107c
EZ
4773 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4774 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4775 (bidi_cache_search, bidi_cache_iterator_state)
4776 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4777 (bidi_level_of_next_char, bidi_move_to_visually_next):
4778 Support character positions inside a run of characters covered by a
fec2107c
EZ
4779 display string.
4780 (bidi_paragraph_init, bidi_resolve_explicit_1)
4781 (bidi_level_of_next_char): Call bidi_fetch_char and
4782 bidi_fetch_char_advance instead of FETCH_CHAR and
4783 FETCH_CHAR_ADVANCE.
4784 (bidi_init_it): Initialize new members.
4785 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4786 definitions.
4787 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4788 instead of using explicit *_CHAR codes.
d6d100dd
SM
4789 (bidi_resolve_explicit, bidi_resolve_weak):
4790 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4791 bidirectional text is supported only in multibyte buffers.
4792 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4793 it to initialize the frame_window_p member of struct bidi_it.
4794 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4795 (bidi_resolve_explicit, bidi_resolve_weak)
4796 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4797 bidi_it->nchars is non-positive.
4798 (bidi_level_of_next_char): Don't try to lookup the cache for the
4799 next/previous character if nothing is cached there yet, or if we
4800 were just reseat()'ed to a new position.
c40e2fb2 4801
0e14fe90
EZ
4802 * xdisp.c (set_cursor_from_row): Set start and stop points
4803 according to the row's direction when priming the loop that looks
4804 for the glyph on which to display cursor.
4805 (single_display_spec_intangible_p): Function deleted.
4806 (display_prop_intangible_p): Reimplement to call
4807 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4808 Accept 3 additional arguments needed by handle_display_spec.
4809 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4810 values: lists, `(when COND...)' forms, etc.
4811 (single_display_spec_string_p): Support property values that are
4812 lists with the argument STRING its top-level element.
4813 (display_prop_string_p): Fix the condition for processing a
4814 property that is a list to be consistent with handle_display_spec.
fec2107c 4815 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4816 last portion of handle_display_prop.
4817 (compute_display_string_pos): Accept additional argument
4818 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4819 value of a `display' property is a "replacing spec".
4820 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4821 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4822 the display property, but just return a value indicating whether
4823 the display property will replace the characters it covers.
4824 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4825 frame_window_p members of struct bidi_it.
d6d100dd
SM
4826 (compute_display_string_pos, compute_display_string_end):
4827 New functions.
fec2107c
EZ
4828 (push_it): Accept second argument POSITION, where pop_it should
4829 jump to continue iteration.
4830 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4831
fec2107c
EZ
4832 * keyboard.c (adjust_point_for_property): Adjust the call to
4833 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4834
4835 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4836 (bidi_init_it): Update prototypes.
4837 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4838 (compute_display_string_pos, compute_display_string_end):
4839 Declare prototypes.
fec2107c
EZ
4840 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4841 EMACS_INT.
fc6f18ce 4842
40087514 48432011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4844
57f53182
PE
4845 Malloc failure behavior now depends on size of allocation.
4846 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4847 * lisp.h: Change signatures accordingly.
4848 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4849 All callers changed. (Bug#8762)
4850
4851 * gnutls.c: Use Emacs's memory allocators.
4852 Without this change, the gnutls library would invoke malloc etc.
4853 directly, which causes problems on non-SYNC_INPUT hosts, and which
4854 runs afoul of improving memory_full behavior. (Bug#8761)
4855 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4856 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4857 xfree instead of the default malloc, realloc, free.
4858 (Fgnutls_boot): No need to check for memory allocation failure,
4859 since xmalloc does that for us.
4860
ac32cd99 4861 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4862 * category.c (hash_get_category_set):
4863 * ccl.c (ccl_driver):
4864 * charset.c (Fdefine_charset_internal):
4865 * charset.h (struct charset.hash_index):
4866 * composite.c (get_composition_id, gstring_lookup_cache)
4867 (composition_gstring_put_cache):
4868 * composite.h (struct composition.hash_index):
4869 * dispextern.h (struct image.hash):
4870 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4871 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4872 (hashfn_equal, hashfn_user_defined, make_hash_table)
4873 (maybe_resize_hash_table, hash_lookup, hash_put)
4874 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4875 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4876 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4877 * image.c (make_image, search_image_cache, lookup_image)
4878 (xpm_put_color_table_h):
4879 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4880 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4881 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4882 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4883 * alloc.c (allocate_vectorlike):
4884 Check for overflow in vector size calculations.
4885 * ccl.c (ccl_driver):
4886 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4887 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4888 need to be updated by these changes.
40087514
PE
4889 * fns.c (make_hash_table, maybe_resize_hash_table):
4890 Check for integer overflow with large hash tables.
0de4bb68
PE
4891 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4892 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4893 (SXHASH_REDUCE): New macro.
4894 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4895 Use it instead of discarding useful hash info with large hash values.
4896 (sxhash_float): New function.
4897 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4898 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4899 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4900 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4901 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4902 Adjust signatures to match updated version of code.
4903 (consing_since_gc): Now EMACS_INT, since a single hash table can
4904 use more than INT_MAX bytes.
4905
698d32e2
DN
49062011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4907
4908 Make it possible to build with GCC-4.6+ -O2 -flto.
4909
4910 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4911
fd6fa53f
SM
49122011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4913
4914 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4915 Call minibuffer-inactive-mode.
4916
864db017
JB
49172011-05-31 Juanma Barranquero <lekktu@gmail.com>
4918
4919 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4920 Update dependencies.
4921
2ad0baf4
DN
49222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4923
4924 * data.c (init_data): Remove code for UTS, this system is not
4925 supported anymore.
4926
4fcc2638
DN
49272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4928
4929 Don't force ./temacs to start in terminal mode.
4930
4931 * frame.c (make_initial_frame): Initialize faces in all cases, not
4932 only when CANNOT_DUMP is defined.
4933 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4934
c56e0fd5
DN
49352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4936
4937 * dispnew.c (add_window_display_history): Use const for the string
4938 pointer. Remove declaration, not needed.
4939
333d54da 49402011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4941
55d4c1b2 4942 Use 'inline', not 'INLINE'.
333d54da 4943 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4944 * alloc.c, fontset.c (INLINE): Remove.
4945 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4946 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4947 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4948 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4949 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4950
738db178
DN
49512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4952
4953 Make it possible to run ./temacs.
4954
4955 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4956 syms_of_callproc does the same thing. Remove test for
4957 "initialized", do it in the caller.
4958 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4959
620c53a6
SM
49602011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4961
4962 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4963 (read_minibuf): Use get_minibuffer.
4964 (syms_of_minibuf): Use DEFSYM.
4965 (Qmetadata): New var.
4966 * data.c (Qbuffer): Don't make it static.
4967 (syms_of_data): Use DEFSYM.
4968
e003a292
PE
49692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4970
4971 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4972 (CCL_CODE_MIN): New macro.
4973
ed008a6d
PE
49742011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4975
3687c2ef
PE
4976 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4977
ed008a6d
PE
4978 * eval.c (Qdebug): Now static.
4979 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4980 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4981 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4982
d66c4c7c
CY
49832011-05-29 Chong Yidong <cyd@stupidchicken.com>
4984
4985 * image.c: Various fixes to ImageMagick code comments.
4986 (Fimagemagick_types): Doc fix.
4987
5fbc2025
PE
49882011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4989
0196f88a
PE
4990 Minor fixes prompted by GCC 4.6.0 warnings.
4991
4992 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4993
5fbc2025
PE
4994 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4995 (x_clipboard_manager_save_all): Move extern decl to ...
4996 * xterm.h: ... here, so that it can be checked for consistency.
4997
1dd3c2d9
CY
49982011-05-29 Chong Yidong <cyd@stupidchicken.com>
4999
5000 * xselect.c (x_clipboard_manager_save_frame)
5001 (x_clipboard_manager_save_all): New functions.
5002 (Fx_clipboard_manager_save): Lisp function deleted.
5003
5004 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5005 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5006
5007 * xterm.h: Update prototype.
5008
5ba6571d
WX
50092011-05-28 William Xu <william.xwl@gmail.com>
5010
5011 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5012 exiting (Bug#8239).
5013
3eaff834
JM
50142011-05-28 Jim Meyering <meyering@redhat.com>
5015
e1900994 5016 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5017 * fns.c (to_uchar): Define.
5018 (crypto_hash_function): Use it to convert some newly-signed
5019 variables to unsigned, to avoid sign-extension bugs. For example,
5020 without this change, (md5 "truc") would evaluate to
5021 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5022 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5023 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5024
0f6990a7
PE
50252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5026
5027 Integer overflow fixes.
c8a9ca5a 5028
08686060
PE
5029 * dbusbind.c: Serial number integer overflow fixes.
5030 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5031 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5032 to hold a serial number that is too large for a fixnum.
5033 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5034 Check for serial numbers out of range. Decode any serial number
59568bf0 5035 that was so large that it became a float. (Bug#8722)
08686060 5036
2d1fc3c7
PE
5037 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5038 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5039 Use XFASTINT rather than XUINT when numbers are nonnegative.
5040 (xd_append_arg, Fdbus_method_return_internal):
5041 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5042 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5043 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5044 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5045 (Bug#8722)
2d1fc3c7 5046
c8a9ca5a
PE
5047 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5048
519e1d69
PE
5049 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5050
30569699
PE
5051 ccl: add integer overflow checks
5052 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5053 (IN_INT_RANGE): New macros.
5054 (ccl_driver): Use them to check for integer overflow when
5055 decoding a CCL program. Many of the new checks are whether XINT (x)
5056 fits in int; it doesn't always, on 64-bit hosts. The new version
5057 doesn't catch all possible integer overflows, but it's an
847044ea 5058 improvement. (Bug#8719)
30569699 5059
c11285dc
PE
5060 * alloc.c (make_event_array): Use XINT, not XUINT.
5061 There's no need for unsigned here.
5062
fdccd48e
PE
5063 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5064 This follows up to the 2011-05-06 change that substituted uintptr_t
5065 for EMACS_INT. This case wasn't caught back then.
5066
37910ab2
PE
5067 Rework Fformat to avoid integer overflow issues.
5068 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5069 now (part of C89). Include <verify.h>.
5070 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5071 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5072 (Fformat): Avoid the prepass trying to compute sizes; it was only
5073 approximate and thus did not catch overflow reliably. Instead, walk
5074 through the format just once, formatting and computing sizes as we go,
5075 checking for integer overflow at every step, and allocating a larger
5076 buffer as needed. Keep track separately whether the format is
5077 multibyte. Keep only the most-recently calculated precision, rather
5078 than them all. Record whether each argument has been converted to
5079 string. Use EMACS_INT, not int, for byte and char and arg counts.
5080 Support field widths and precisions larger than INT_MAX. Avoid
5081 sprintf's undefined behavior with conversion specifications such as %#d
5082 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5083 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5084 formatting out-of-range floating point numbers with int
9173deec 5085 formats. (Bug#8668)
37910ab2 5086
2e6578fb
PE
5087 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5088
0ae6bdee
PE
5089 * data.c: Avoid integer truncation in expressions involving floats.
5090 * data.c: Include <intprops.h>.
5091 (arith_driver): When there's an integer overflow in an expression
5092 involving floating point, convert the integers to floating point
5093 so that the resulting value does not suffer from catastrophic
5094 integer truncation. For example, on a 64-bit host (* 4
5095 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5096 Do not rely on undefined behavior after integer overflow.
5097
de883a70
PE
5098 merge count_size_as_multibyte, parse_str_to_multibyte
5099 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5100 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5101 Check for integer overflow.
5102 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5103 since it's now a duplicate of the other. This is more of
5104 a character than a buffer op, so better that it's in character.c.
5105 * fns.c, print.c: Adjust to above changes.
5106
2ff916cb
PE
51072011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5108
5109 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5110
f1b54466
PE
51112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5112
fb1ac845
PE
5113 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5114 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5115 (x_clipboard_manager_save): Now static.
5116 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5117
f1b54466
PE
5118 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5119 (crypto_hash_function): Now static.
5120 Fix pointer signedness problems. Avoid unnecessary initializations.
5121
a9f737ee
CY
51222011-05-27 Chong Yidong <cyd@stupidchicken.com>
5123
5124 * termhooks.h (Vselection_alist): Make it terminal-local.
5125
5126 * terminal.c (create_terminal): Initialize it.
5127
5128 * xselect.c: Support for clipboard managers.
5129 (Vselection_alist): Move to termhooks.h as terminal-local var.
5130 (LOCAL_SELECTION): New macro.
5131 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5132 (symbol_to_x_atom): Remove gratuitous arg.
5133 (x_handle_selection_request, lisp_data_to_selection_data)
5134 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5135 (x_own_selection, x_get_local_selection, x_convert_selection):
5136 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5137 (some_frame_on_display): Delete unused function.
5138 (Fx_own_selection_internal, Fx_get_selection_internal)
5139 (Fx_disown_selection_internal, Fx_selection_owner_p)
5140 (Fx_selection_exists_p): New optional frame arg.
5141 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5142 (x_handle_selection_clear): Don't treat other terminals with the
5143 same keyboard specially. Use the terminal-local Vselection_alist.
5144 (x_clear_frame_selections): Use Frun_hook_with_args.
5145
5146 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5147
5148 * xterm.h: Add support for those atoms.
5149
e067f0c1
CY
51502011-05-26 Chong Yidong <cyd@stupidchicken.com>
5151
5152 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5153 (converted_selections, conversion_fail_tag): New global variables.
5154 (x_selection_request_lisp_error): Free the above.
5155 (x_get_local_selection): Remove unnecessary code.
5156 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5157 of converted selections stored in converted_selections.
5158 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5159 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5160 (x_convert_selection): New function.
5161 (x_handle_selection_event): Simplify.
5162 (x_get_foreign_selection): Don't ignore incoming requests while
5163 waiting for an answer; this will fail when we implement
5164 SAVE_TARGETS, and seems unnecessary anyway.
5165 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5166 (Vx_sent_selection_functions): Doc fix.
5167
0f4aebc0
LL
51682011-05-26 Leo Liu <sdl.web@gmail.com>
5169
5170 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5171
e61124cd
YM
51722011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5173
5174 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5175
5176 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5177 for fringe update if it has periodic bitmap.
ac389d0c 5178 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5179 and fringe_bitmap_periodic_p.
5180
5181 * fringe.c (get_fringe_bitmap_data): New function.
5182 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5183 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5184 row. Mark glyph row for fringe update if periodicity changed.
5185
5186 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5187 for fringe update unless it has periodic bitmap.
5188
f16d9837
KH
51892011-05-25 Kenichi Handa <handa@m17n.org>
5190
5191 * xdisp.c (get_next_display_element): Set correct it->face_id for
5192 a static composition.
5193
e1b90ef6
LL
51942011-05-24 Leo Liu <sdl.web@gmail.com>
5195
5196 * deps.mk (fns.o):
5197 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5198
5199 * fns.c (crypto_hash_function, Fsha1): New function.
5200 (Fmd5): Use crypto_hash_function.
5201 (syms_of_fns): Add Ssha1.
5202
7400048f
PE
52032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5204
5205 * gnutls.c: Remove unused macros.
5206 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5207 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5208 Remove macros that are defined and never used.
5209 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5210
abb71cf4
CY
52112011-05-22 Chong Yidong <cyd@stupidchicken.com>
5212
5213 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5214 (Fx_get_selection_internal): Minor cleanup.
5215 (Fx_own_selection_internal): Rename arguments for consistency with
5216 select.el.
5217
6307db39
PE
52182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5219
5220 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5221
f3d4e0a4
CY
52222011-05-22 Chong Yidong <cyd@stupidchicken.com>
5223
5224 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5225
4d8ade89
YM
52262011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5227
5228 * dispnew.c (scrolling_window): Don't exclude the case that the
5229 last enabled row in the desired matrix touches the bottom boundary.
5230
32078c8d
GM
52312011-05-21 Glenn Morris <rgm@gnu.org>
5232
5233 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5234 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5235 and add some more files.
32078c8d 5236
7285dc67
EZ
52372011-05-20 Eli Zaretskii <eliz@gnu.org>
5238
5239 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5240 report_file_error introduced by the change from 2011-05-07.
5241
89d1bd22
PE
52422011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5243
5244 * systime.h (Time): Define only if emacs is defined.
5245 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5246 where the include path doesn't have X11/X.h by default. See
5247 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5248
e23640bb 52492011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5250
5251 * composite.c (find_automatic_composition): Fix previous change.
5252
b9704ad9
GM
52532011-05-20 Glenn Morris <rgm@gnu.org>
5254
5255 * lisp.mk: New file, split from Makefile.in.
5256 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5257 (shortlisp): Remove.
5258 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5259
4a720484
GM
52602011-05-19 Glenn Morris <rgm@gnu.org>
5261
5262 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5263 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5264 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5265 (lisp): Set the order to that of loadup.el.
5266 (shortlisp): Make it a copy of $lisp.
5267 (SOME_MACHINE_LISP): Remove.
5268 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5269 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5270
a28d4396
KH
52712011-05-18 Kenichi Handa <handa@m17n.org>
5272
5273 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5274 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5275 (find_automatic_composition): Mostly rewrite for efficiency.
5276
a2b1fa8e
JB
52772011-05-18 Juanma Barranquero <lekktu@gmail.com>
5278
5279 * makefile.w32-in: Update dependencies.
5280
8e1f5610
CS
52812011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5282
5283 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5284 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5285
7025ee00 52862011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5287
cdfa6eab
PE
5288 Fix some integer overflow issues, such as string length overflow.
5289
06d6db33
PE
5290 * insdel.c (count_size_as_multibyte): Check for string overflow.
5291
2b4560a8
PE
5292 * character.c (lisp_string_width): Check for string overflow.
5293 Use EMACS_INT, not int, for string indexes and lengths; in
5294 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5295 the resulting string length overflows an EMACS_INT; instead,
5296 report a string overflow if no precision given. When checking for
5297 precision exhaustion, use a check that cannot possibly have
5298 integer overflow. (Bug#8675)
5299 * character.h (lisp_string_width): Adjust to new signature.
5300
cb93f9be
PE
5301 * alloc.c (string_overflow): New function.
5302 (Fmake_string): Use it. This doesn't change behavior, but saves
5303 a few bytes and will simplify future changes.
5304 * character.c (string_escape_byte8): Likewise.
5305 * lisp.h (string_overflow): New decl.
5306
1a1f3366
PE
5307 Fixups, following up to the user-interface timestamp change.
5308 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5309 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5310 * msdos.c (mouse_get_pos): Likewise.
5311 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5312 * w32gui.h (Time): Define by including "systime.h" rather than by
5313 declaring it ourselves. (Bug#8664)
5314
d4e3e4d3
PE
5315 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5316 * image.c (clear_image_cache): Likewise.
5317
f6a24d19
PE
5318 * term.c (term_mouse_position): Don't assume time_t wraparound.
5319
08dc5ae6
PE
5320 Be more systematic about user-interface timestamps.
5321 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5322 and sometimes 'EMACS_UINT', to represent these timestamps.
5323 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5324 This makes the code easier to follow, and makes it easier to catch
5325 integer overflow bugs such as Bug#8664.
5326 * frame.c (Fmouse_position, Fmouse_pixel_position):
5327 Use Time, not unsigned long, for user-interface timestamps.
5328 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5329 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5330 * keyboard.h (last_event_timestamp): Likewise.
5331 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5332 * menu.h (xmenu_show): Likewise.
5333 * term.c (term_mouse_position): Likewise.
5334 * termhooks.h (struct input_event.timestamp): Likewise.
5335 (struct terminal.mouse_position_hook): Likewise.
5336 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5337 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5338 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5339 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5340 what it was before.
5341 * menu.h, termhooks.h: Include "systime.h", for Time.
5342
8e55734a
PE
5343 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5344 Don't assume that the difference between two unsigned long values
5345 can fit into an integer. At this point, we know button_down_time
5346 <= event->timestamp, so the difference must be nonnegative, so
5347 there's no need to cast the result if double-click-time is
5348 nonnegative, as it should be; check that it's nonnegative, just in
5349 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5350 apart (about 25 days). (Bug#8664)
8e55734a 5351
841f1b75 5352 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5353 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5354
3e26f69c
PE
5355 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5356 that always fit in int. Use a sentinel instead of a counter, to
5357 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5358 * frame.h (struct frame): Use int for menu_bar_items_used
5359 instead of EMACS_INT, since it always fits in int.
3e26f69c 5360
5cc152c0
PE
5361 * menu.c (grow_menu_items): Check for int overflow.
5362
d89eb65e
PE
5363 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5364
5235bd3e
PE
5365 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5366 Before, the code was not consistent. These values cannot exceed
5367 2**31 - 1 so there's no need to make them unsigned.
5368 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5369 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5370 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5371 as modifiers.
5372 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5373
bc827e23
PE
5374 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5375 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5376 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5377 presumably because the widths might not match.
5378
78eb494e
PE
5379 * window.c (size_window): Avoid needless test at loop start.
5380
04f2d78b
CB
53812011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5382
5383 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5384
d2fc7e3d 53852011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5386
5387 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5388
d2fc7e3d 53892011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5390
5391 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5392 `width' to `bar_area_x' and `bar_area_width', respectively.
5393 (x_scroll_run): Take account of fringe background extension.
5394
04f2d78b
CB
5395 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5396 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5397 `bar_area_width', respectively.
5398 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5399 background extension.
5400
79b70037
GM
54012011-05-10 Jim Meyering <meyering@redhat.com>
5402
5403 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5404
2f142cc5
JB
54052011-05-10 Juanma Barranquero <lekktu@gmail.com>
5406
5407 * image.c (Finit_image_library): Return t for built-in image types,
5408 like pbm and xbm. (Bug#8640)
5409
57679c86
AS
54102011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5411
5412 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5413
888c9e86
EZ
54142011-05-07 Eli Zaretskii <eliz@gnu.org>
5415
b0512a1d
EZ
5416 * w32console.c (Fset_screen_color): Doc fix.
5417 (Fget_screen_color): New function.
5418 (syms_of_ntterm): Defsubr it.
5419
7285dc67
EZ
5420 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5421 unlink the temporary file if Fcall_process didn't create it in the
5422 first place.
5423 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5424 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5425 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5426 cue to call_process_cleanup not to close that handle.
5427
4d3fcc8e
BK
54282011-05-07 Ben Key <bkey76@gmail.com>
5429
5430 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5431 one of two shell specific rules, either bootstrap-temacs-CMD or
5432 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5433 to the previous implementation of the bootstrap-temacs rule.
5434 The bootstrap-temacs-CMD rule is similar to the previous
5435 implementation of the bootstrap-temacs rule except that it
5436 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5437 variable.
5438
5439 These changes, along with some changes to nt/configure.bat,
5440 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5441 earlier fix to add support for --cflags and --ldflags options
5442 that include quotes so that it works whether make uses cmd or
5443 sh as the shell.
5444
b4289b64
MA
54452011-05-06 Michael Albinus <michael.albinus@gmx.de>
5446
5447 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5448 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5449 is a constant.
5450 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5451 a string. Handle both cases.
5452 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5453 (Fdbus_register_method): Use Qinvalid_function.
5454
af4c0e28
JB
54552011-05-06 Juanma Barranquero <lekktu@gmail.com>
5456
5457 * makefile.w32-in: Update dependencies.
5458 (LISP_H): Add inttypes.h and stdin.h.
5459 (PROCESS_H): Add unistd.h.
5460
c51453d9
EZ
54612011-05-06 Eli Zaretskii <eliz@gnu.org>
5462
5463 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5464 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5465
8ff0ac3c 54662011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5467
4c4b566b
PE
5468 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5469
aab2b9b5
PE
5470 * term.c (vfatal): Remove stray call to va_end.
5471 It's not needed and the C Standard doesn't allow it here anyway.
5472
c378da0b
PE
5473 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5474 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5475
288b08c7
PE
5476 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5477 bytes.
5478
e3601888
PE
5479 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5480
db6c0e74
PE
5481 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5482
dd5963ea
PE
5483 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5484
88c9450f
PE
5485 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5486
2f9442b8
PE
5487 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5488
c032b5f8
PE
5489 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5490 * charset.c (Fdefine_charset_internal): Don't initialize
5491 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5492 32-bit int (Bug#8600).
a108c10b
PE
5493
5494 * lread.c (read_integer): Be more consistent with string-to-number.
5495 Use string_to_number to do the actual conversion; this avoids
5496 rounding errors and fixes some other screwups. Without this fix,
5497 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5498 (digit_to_number): Move earlier, for benefit of read_integer.
5499 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5500 not a digit in any supported base. (Bug#8602)
a108c10b 5501
ad5f9eea
PE
5502 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5503
aec1708a
PE
5504 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5505 to match comment at start of function. This also removes a
5506 GCC warning about overflow in a 32+64-bit port.
5507
47be4ab5
PE
5508 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5509
371cac43
PE
5510 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5511 Reported by Stefan Monnier in
5512 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5513 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5514 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5515
d01a7826
PE
5516 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5517 (EMACS_UINTPTR): Likewise, with uintptr_t.
5518
7fd47d5c
PE
5519 * lisp.h: Prefer 64-bit EMACS_INT if available.
5520 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5521 on 32-bit hosts that have 64-bit int, so that they can access
5522 large files.
122b0c86
PE
5523 However, temporarily disable this change unless the temporary
5524 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5525
8727937b
PE
5526 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5527
8ac068ac
PE
5528 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5529 This removes an assumption that EMACS_INT and long are the same
5530 width as pointers. The assumption is true for Emacs porting targets
5531 now, but we want to make other targets possible.
5532 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5533 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5534 In the rest of the code, change types of integers that hold casted
5535 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5536 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5537 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5538 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5539 No need to cast type when ORing.
5540 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5541 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5542 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5543 assume EMACS_INT is the same width as char *.
5544 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5545 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5546 Remove no-longer-needed casts.
5547 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5548 (xg_tool_bar_help_callback, xg_make_tool_item):
5549 Use EMACS_INTPTR to hold an integer
5550 that will be cast to void *; this can avoid a GCC warning
5551 if EMACS_INT is not the same width as void *.
5552 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5553 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5554 (current_message_1, set_message_1):
5555 Use a local to convert to proper width without a cast.
5556 * xmenu.c (dialog_selection_callback): Likewise.
5557
ede49d71
PE
5558 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5559 Also, don't assume VALBITS / RAND_BITS is less than 5,
5560 and don't rely on undefined behavior when shifting a 1 left into
5561 the sign bit.
5562 * lisp.h (get_random): Change signature to match.
5563
2f30ecd0
PE
5564 * lread.c (hash_string): Use size_t, not int, for hash computation.
5565 Normally we prefer signed values; but hashing is special, because
5566 it's better to use unsigned division on hash table sizes so that
5567 the remainder is nonnegative. Also, size_t is the natural width
5568 for hashing into memory. The previous code used 'int', which doesn't
5569 retain enough info to hash well into very large tables.
5570 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5571
2a866e7b
PE
5572 * dbusbind.c: Don't possibly lose pointer info when converting.
5573 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5574 Use XPNTR rather than XHASH, so that the high-order bits of
5575 the pointer aren't lost when converting through void *.
5576
51639eac
PE
5577 * eval.c (Fautoload): Don't double-shift a pointer.
5578
92394119
PE
5579 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5580
dbdb9a7c
JB
55812011-05-06 Juanma Barranquero <lekktu@gmail.com>
5582
5583 * gnutls.c (DEF_GNUTLS_FN):
5584 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5585
db7a0b4f
AS
55862011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5587
5588 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5589 marker. (Bug#8610)
5590
f7ff1b0f 55912011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5592
5593 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5594 New version that can reserve upto 2GB of heap space.
5595
f7ff1b0f 55962011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5597
5598 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5599
639c109b
TZ
56002011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5601
5602 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5603 `gnutls_certificate_set_x509_key_file'.
5604
d2127135
JB
56052011-05-05 Juanma Barranquero <lekktu@gmail.com>
5606
5607 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5608 Update dependencies.
5609
e968f4f3
JB
56102011-05-04 Juanma Barranquero <lekktu@gmail.com>
5611
5612 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5613 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5614 Remove unused parameter `fildes'.
5615 * process.c (read_process_output, send_process): Don't pass it.
5616
84d358f0
JB
56172011-05-04 Juanma Barranquero <lekktu@gmail.com>
5618
5619 Fix previous change: the library cache is defined in w32.c.
5620 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5621 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5622
0898ca10
JB
56232011-05-04 Juanma Barranquero <lekktu@gmail.com>
5624
5625 Implement dynamic loading of GnuTLS on Windows.
5626
5627 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5628 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5629 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5630 Declare.
5631
5632 * gnutls.c (Qgnutls_dll): Define.
5633 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5634 (gnutls_*): Declare function pointers.
5635 (init_gnutls_functions): New function to initialize function pointers.
5636 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5637 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5638 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5639 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5640 (emacs_gnutls_write, emacs_gnutls_read)
5641 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5642 (Fgnutls_available_p): New function.
5643 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5644 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5645 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5646
5647 * image.c: Include w32.h.
5648 (Vimage_type_cache): Delete.
5649 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5650 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5651 (w32_delayed_load): Move to w32.c.
5652
5653 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5654
5655 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5656 (w32_delayed_load): Move from image.c. When loading a library, record
5657 its filename in the :loaded-from property of the library id.
5658 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5659 Initialize and staticpro them.
5660 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5661
5662 * process.c: Include lisp.h before w32.h, not after.
5663 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5664 instead of gnutls_record_check_pending.
5665
5666 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5667
ff4de4aa
TZ
56682011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5669
5670 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5671 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5672 as passed in.
5673
abe95abb
JD
56742011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5675
5676 * xterm.c (x_set_frame_alpha): Do not set property on anything
5677 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5678
e16e55d4
JB
56792011-05-02 Juanma Barranquero <lekktu@gmail.com>
5680
5681 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5682
bafcf6a5
JB
56832011-05-02 Juanma Barranquero <lekktu@gmail.com>
5684
5685 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5686 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5687 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5688 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5689 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5690 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5691 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5692 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5693 (Qgnutls_bootprop_callbacks_verify): Make static.
5694
e7a6747f
AS
56952011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5696
19ed11ba
AS
5697 * callproc.c: Indentation fixup.
5698
e7a6747f 5699 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5700 (wait_for_termination, interruptible_wait_for_termination):
5701 Move after wait_for_termination_1.
e7a6747f 5702
1ef14cb4
LMI
57032011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5704
5705 * sysdep.c (interruptible_wait_for_termination): New function
5706 which is like wait_for_termination, but allows keyboard
5707 interruptions.
5708
5709 * callproc.c (Fcall_process): Add (:file "file") as an option for
5710 the STDOUT buffer.
5711 (Fcall_process_region): Ditto.
5712
330d880c
EZ
57132011-04-30 Eli Zaretskii <eliz@gnu.org>
5714
8db90b73
EZ
5715 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5716 rather than `XVECTOR (FOO)->size'.
5717
330d880c
EZ
5718 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5719 inttypes.h, as a gnulib replacement is used if it not available in
5720 system headers.
5721
15cbd324
EZ
57222011-04-21 Eli Zaretskii <eliz@gnu.org>
5723
5724 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5725 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5726 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5727
5728 * coding.c (coding_alloc_by_realloc): Error out if destination
5729 will grow beyond MOST_POSITIVE_FIXNUM.
5730 (decode_coding_emacs_mule): Abort if there isn't enough place in
5731 charbuf for the composition carryover bytes. Reserve an extra
5732 space for up to 2 characters produced in a loop.
5733 (decode_coding_iso_2022): Abort if there isn't enough place in
5734 charbuf for the composition carryover bytes.
5735
57362011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5737
ae940cca
EZ
5738 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5739 aborting when %lld or %lll format is passed.
5740 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5741 %llo or %llx format is passed. (Bug#8545)
5742
03ab8921
EZ
5743 * window.c (window_scroll_line_based): Use a marker instead of
5744 simple variables to record original value of point. (Bug#7952)
5745
afda1437
EZ
5746 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5747 produced by %s or %c overflows available buffer space. (Bug#8545)
5748
f76dee0c
PE
57492011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5750
5751 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5752 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5753
fdc5744d
JB
57542011-04-28 Juanma Barranquero <lekktu@gmail.com>
5755
5756 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5757
638f053a
JB
57582011-04-28 Juanma Barranquero <lekktu@gmail.com>
5759
5760 * keyboard.c (Qdelayed_warnings_hook): Define.
5761 (command_loop_1): Run `delayed-warnings-hook'
5762 if Vdelayed_warnings_list is non-nil.
5763 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5764 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5765
d178f871
EZ
57662011-04-28 Eli Zaretskii <eliz@gnu.org>
5767
5768 * doprnt.c (doprnt): Don't return value smaller than the buffer
5769 size if the message was truncated. (Bug#8545).
5770
b124fd93
JB
57712011-04-28 Juanma Barranquero <lekktu@gmail.com>
5772
5773 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5774 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5775
e810457d
PE
57762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5777
5778 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5779
ea51cceb
JB
57802011-04-27 Juanma Barranquero <lekktu@gmail.com>
5781
5782 * makefile.w32-in: Update dependencies.
5783
94dcfacf
EZ
57842011-04-27 Eli Zaretskii <eliz@gnu.org>
5785
5786 Improve `doprnt' and its usage. (Bug#8545)
5787 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5788 `format_end'. Remove support for %l as a conversion specifier.
5789 Don't use xrealloc. Improve diagnostics when the %l size modifier
5790 is used. Update the commentary.
5791
5792 * eval.c (verror): Simplify calculation of size_t.
5793
5794 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5795 messages.
5796
f61f41d7
PE
57972011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5798
5799 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5800 change.
5801
96fb4434
PE
58022011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5803
5804 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5805 This makes this file independent of the recent pseudovector change.
5806
671875da 58072011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5808
69e9b5a3
PE
5809 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5810
b5f869a7 5811 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5812 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5813 Remove unused local.
c8926152 5814 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5815
841a1577 5816 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5817 GCC 4.6.0 optimizes based on type-based alias analysis.
5818 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5819 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5820 != &v->size, and therefore "v->size = 1; b->size = 2; return
5821 v->size;" must therefore return 1. This assumption is incorrect
5822 for Emacs, since it type-puns struct Lisp_Vector * with many other
5823 types. To fix this problem, this patch adds a new type struct
f904488f 5824 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5825 and pseudovectors, and helps optimizing compilers not get fooled
5826 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5827 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5828 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5829 the size member.
eab3844f
PE
5830 (XSETPVECTYPE): Rewrite in terms of new macro.
5831 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5832 This is a bit clearer, and further avoids the possibility of
5833 undesirable aliasing.
5834 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5835 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5836 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5837 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5838 (ASIZE): Now uses header.size rather than size.
5839 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5840 to avoid the hassle of writing XVECTOR (foo)->header.size.
5841 (struct vectorlike_header): New type.
eab3844f
PE
5842 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5843 object, to help avoid aliasing.
5844 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5845 (SUBRP): Likewise, since Lisp_Subr is a special case.
5846 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5847 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5848 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5849 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5850 changed to be "header.size" and "header.next".
5851 * buffer.h (struct buffer): Likewise.
5852 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5853 * frame.h (struct frame): Likewise.
5854 * process.h (struct Lisp_Process): Likewise.
5855 * termhooks.h (struct terminal): Likewise.
5856 * window.c (struct save_window_data, struct saved_window): Likewise.
5857 * window.h (struct window): Likewise.
5858 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5859 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5860 * buffer.c (init_buffer_once): Likewise.
5861 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5862 special case.
5863 * process.c (Fformat_network_address): Use local var for size,
5864 for brevity.
5865
0df1eac5
PE
5866 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5867
847ab9d1 5868 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5869 * data.c (atof): Remove decl; no longer used or needed.
5870 (digit_to_number): Move to lread.c.
5871 (Fstring_to_number): Use new string_to_number function, to be
5872 consistent with how the Lisp reader treats infinities and NaNs.
5873 Do not assume that floating-point numbers represent EMACS_INT
5874 without losing information; this is not true on most 64-bit hosts.
5875 Avoid double-rounding errors, by insisting on integers when
5876 parsing non-base-10 numbers, as the documentation specifies.
5877 * lisp.h (string_to_number): New decl, replacing ...
5878 (isfloat_string): Remove.
bc0a5c13 5879 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5880 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5881 appears to have been a coding error. Similarly, do not accept
5882 strings like +-1e0 as floating point numbers. Do not report
5883 overflow for integer overflows unless the base is not 10 which
5884 means we have no simple and reliable way to continue.
5885 Break out the floating-point parsing into a new
5886 function string_to_number, so that Fstring_to_number parses
5887 floating point numbers consistently with the Lisp reader.
04f2d78b 5888 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5889 (E_CHAR, EXP_INT): Remove, replacing with ...
5890 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5891 (string_to_number): New function, replacing isfloat_string.
5892 This function checks for valid syntax and produces the resulting
5893 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5894 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5895 so that overflow for non-base-10 numbers is reported only when
5896 there's no portable and simple way to convert to floating point.
452f4150 5897
67769ffc
PE
5898 * textprop.c (set_text_properties_1): Rewrite for clarity,
5899 and to avoid GCC warning about integer overflow.
5900
c20db43f
PE
5901 * intervals.h (struct interval): Use EMACS_INT for members
5902 where EMACS_UINT might cause problems. See
5903 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5904 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5905 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5906 All uses changed.
37aa2f85
PE
5907 (offset_intervals): Tell GCC not to worry about length overflow
5908 when negating a negative length.
c20db43f 5909
2538aa2f
PE
5910 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5911 (overrun_check_free): Likewise.
5912
f2d3008d
PE
5913 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5914 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5915 word size.
5916
ec8df744
PE
5917 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5918 (gnutls_make_error): Rename local to avoid shadowing.
5919 (gnutls_emacs_global_deinit): ifdef out; not used.
5920 (Fgnutls_boot): Use const for pointer to readonly storage.
5921 Comment out unused local. Fix pointer signedness problems.
5922
640ee02d
PE
5923 * lread.c (openp): Don't stuff size_t into an 'int'.
5924 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5925 about possible signed overflow.
5926
6048fb2a
PE
5927 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5928 (GDK_KEY_g): Don't define if already defined.
5929 (xg_prepare_tooltip): Avoid pointer signedness problem.
5930 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5931
fa3c87e1
PE
5932 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5933 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5934
2172544b
PE
5935 * xfns.c (Fx_window_property): Simplify a bit,
5936 to make a bit faster and to avoid GCC 4.6.0 warning.
5937 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5938
9b821a21
PE
5939 * fns.c (internal_equal): Don't assume size_t fits in int.
5940
3c616cfa
PE
5941 * alloc.c (compact_small_strings): Tighten assertion a little.
5942
c2982e87
PE
5943 Replace pEd with more-general pI, and fix some printf arg casts.
5944 * lisp.h (pI): New macro, generalizing old pEd macro to other
5945 conversion specifiers. For example, use "...%"pI"d..." rather
5946 than "...%"pEd"...".
5947 (pEd): Remove. All uses replaced with similar uses of pI.
5948 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5949 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5950 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5951 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5952 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5953 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5954 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5955 64-bit hosts.
5956 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5957 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5958 * print.c (safe_debug_print, print_object): Likewise.
5959 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5960 to int.
6f04d126
PE
5961 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5962 avoiding the 0 flag, which is not portable.
c2982e87
PE
5963 * process.c (Fmake_network_process): Use pI to avoid cast.
5964 * region-cache.c (pp_cache): Likewise.
5965 * xdisp.c (decode_mode_spec): Likewise.
5966 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5967 behavior on 64-bit hosts with printf arg.
6f04d126 5968 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5969 (x_stop_queuing_selection_requests): Likewise.
5970 (x_get_window_property): Don't truncate byte count to an 'int'
5971 when tracing.
0b432f21 5972
5e073ec7
PE
5973 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5974 here, since it parses constructs like leading '-' and spaces,
5975 which are not wanted; and it overflows with large numbers.
5976 Instead, simply match F[0-9]+, which is what is wanted anyway.
5977
36372bf9
PE
5978 * alloc.c: Remove unportable assumptions about struct layout.
5979 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5980 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5981 (allocate_vectorlike, make_pure_vector): Use the new macros,
5982 plus offsetof, to remove unportable assumptions about struct layout.
5983 These assumptions hold on all porting targets that I know of, but
5984 they are not guaranteed, they're easy to remove, and removing them
5985 makes further changes easier.
5986
0b432f21
PE
5987 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5988 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5989 (string_overrun_cookie): Now const. Use initializers that
5990 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5991 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5992 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5993 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5994 multiple of sizeof (EMACS_INT); it need not be, if
5995 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5996 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5997
895009e1
JB
59982011-04-26 Juanma Barranquero <lekktu@gmail.com>
5999
6000 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6001
6a7a1b0b
TZ
60022011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6003
6004 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6005 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6006 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6007
841a1577 60082011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6009
6010 * lisp.h (Qdebug): List symbol.
895009e1 6011 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6012 * keyboard.c (debug-on-event): New variable.
6013 (handle_user_signal): Break into debugger when debug-on-event
6014 matches the current signal symbol.
6015
f2d3ba6f
DN
60162011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6017
6018 * alloc.c (check_sblock, check_string_bytes)
6019 (check_string_free_list): Convert to standard C.
6020
42ce4c63
TZ
60212011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6022
6023 * w32.c (emacs_gnutls_push): Fix typo.
6024
825cd63c
EZ
60252011-04-25 Eli Zaretskii <eliz@gnu.org>
6026
fb11d64d
EZ
6027 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6028 "cast to pointer from integer of different size".
6029
825cd63c
EZ
6030 Improve doprnt and its use in verror. (Bug#8545)
6031 * doprnt.c (doprnt): Document the set of format control sequences
6032 supported by the function. Use SAFE_ALLOCA instead of always
6033 using `alloca'.
6034
6035 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6036 is one byte too soon. Don't use xrealloc; instead xfree and
6037 xmalloc anew.
6038
e061a11b
TZ
60392011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6040
6041 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6042 callbacks stage.
6043
6044 * gnutls.c: Renamed global_initialized to
6045 gnutls_global_initialized. Added internals for the
6046 :verify-hostname-error, :verify-error, and :verify-flags
6047 parameters of `gnutls-boot' and documented those parameters in the
6048 docstring. Start callback support.
9173deec
JB
6049 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6050 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6051 on error. Return error code.
e061a11b
TZ
6052 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6053 (emacs_gnutls_read): Likewise.
6054 (Fgnutls_boot): Return handshake error code.
6055 (emacs_gnutls_handle_error): New function.
6056 (wsaerror_to_errno): Likewise.
6057
6058 * w32.h (emacs_gnutls_pull): Add prototype.
6059 (emacs_gnutls_push): Likewise.
6060
6061 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6062 (emacs_gnutls_push): Likewise.
6063
60642011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6065
6066 * process.c (wait_reading_process_output): Check if GnuTLS
6067 buffered some data internally if no FDs are set for TLS
6068 connections.
6069
6070 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6071 (LIBS): Link to USER_LIBS.
6072 ($(BLD)/gnutls.$(0)): New target.
6073
fa6996bc
EZ
60742011-04-24 Eli Zaretskii <eliz@gnu.org>
6075
eb35682e
EZ
6076 * xdisp.c (handle_single_display_spec): Rename the
6077 display_replaced_before_p argument into display_replaced_p, to
6078 make it consistent with the commentary. Fix typos in the
6079 commentary.
6080
e2ad650c
EZ
6081 * textprop.c (syms_of_textprop): Remove dead code.
6082 (copy_text_properties): Delete obsolete commentary about an
6083 interface that was deleted long ago. Fix typos in the description
6084 of arguments.
6085
1b2de274
EZ
6086 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6087 to changes in oldXMenu/XMenu.h from 2011-04-16.
6088 <menu_help_message, prev_menu_help_message>: Constify.
6089 (IT_menu_make_room): menu->help_text is now `const char **';
6090 adjust.
6091
6092 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6093 to changes in oldXMenu/XMenu.h from 2011-04-16.
6094 (struct XMenu): Declare `help_text' `const char **'.
6095
6096 * xfaces.c <Qunspecified>: Make extern again.
6097
6098 * syntax.c: Include sys/types.h before including regex.h, as
6099 required by Posix.
6100
762b15be
EZ
6101 * doc.c (get_doc_string): Improve the format passed to `error'.
6102
6103 * doprnt.c (doprnt): Improve commentary.
6104
6105 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6106
6107 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6108 them with etags.
6109
f1052e5d
EZ
6110 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6111 changes in globals.h immediately force recompilation.
762b15be
EZ
6112 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6113 $(CURDIR)/s/ms-w32.h.
6114 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6115
fa6996bc
EZ
6116 * character.c (Fchar_direction): Function deleted.
6117 (syms_of_character): Don't defsubr it.
6118 <char-direction-table>: Deleted.
6119
e6c3da20
EZ
61202011-04-23 Eli Zaretskii <eliz@gnu.org>
6121
6122 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6123 * doprnt.c: Include limits.h.
6124 (SIZE_MAX): New macro.
04f2d78b
CB
6125 (doprnt): Return a size_t value. 2nd arg is now size_t.
6126 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6127 Improve overflow protection. Support `l' modifier for integer
6128 conversions. Support %l conversion. Don't assume an EMACS_INT
6129 argument for integer conversions and for %c.
6130
6131 * lisp.h (doprnt): Restore prototype.
6132
6133 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6134 $(SRC)/character.h.
6135
6136 * Makefile.in (base_obj): Add back doprnt.o.
6137
6138 * deps.mk (doprnt.o): Add back prerequisites.
6139 (callint.o): Depend on character.h.
6140
6141 * eval.c (internal_lisp_condition_case): Include the handler
6142 representation in the error message.
6143 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6144 when breaking from the loop.
6145
6146 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6147
6148 * callint.c (Fcall_interactively): When displaying error message
6149 about invalid control letter, pass the character's codepoint, not
6150 a pointer to its multibyte form. Improve display of the character
6151 in octal and display also its hex code.
6152
6153 * character.c (char_string): Use %x to display the (unsigned)
6154 codepoint of an invalid character, to avoid displaying a bogus
6155 negative value.
6156
6157 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6158 `error', not SYMBOL_NAME itself.
6159
6160 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6161 character arguments to `error'.
6162
6163 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6164 to `error' in error message about FINAL_CHAR argument. Make sure
6165 FINAL_CHAR is a character, and use %c when it is passed as
6166 argument to `error'.
6167
4ffd0d6b 61682011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6169
6170 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6171
6172 * w32.c: Include <time.h>.
6173 (sys_localtime): New function.
6174
4ffd0d6b 61752011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6176
6177 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6178
4ffd0d6b 6179 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6180
4ffd0d6b 61812011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6182
4ffd0d6b
GM
6183 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6184 zombies (Bug#8467).
aac0c6e3 6185
04c56954
EZ
61862011-04-19 Eli Zaretskii <eliz@gnu.org>
6187
6188 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6189 gl_state.e_property when gl_state.object is Qt.
6190
6191 * insdel.c (make_gap_larger): Remove limitation of buffer size
6192 to <= INT_MAX.
6193
16a43933
CY
61942011-04-18 Chong Yidong <cyd@stupidchicken.com>
6195
6196 * xdisp.c (lookup_glyphless_char_display)
6197 (produce_glyphless_glyph): Handle cons cell entry in
6198 glyphless-char-display.
6199 (Vglyphless_char_display): Document it.
6200
6201 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6202 glyphless-char-display.
6203
4581706e
CY
62042011-04-17 Chong Yidong <cyd@stupidchicken.com>
6205
6206 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6207
6208 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6209
6210 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6211 definition for no-X builds.
6212
4887c6e2 62132011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6214
fd35b6f9
PE
6215 Static checks with GCC 4.6.0 and non-default toolkits.
6216
5c1ccb01
PE
6217 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6218
006c5daa
PE
6219 * process.c (keyboard_bit_set): Define only if SIGIO.
6220 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6221 (send_process): Repair possible setjmp clobbering.
6222
efc736d3
PE
6223 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6224
4e2fe2e6
PE
6225 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6226
f97334a2
PE
6227 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6228
4e75f29d
PE
6229 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6230 Define only if needed.
6231
90efadd1
PE
6232 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6233 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6234 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6235
3c647824
PE
6236 * dispextern.h (struct redisplay_interface): Rename param
6237 to avoid shadowing.
e264f262 6238 * termhooks.h (struct terminal): Likewise.
761383f4 6239 * xterm.c (xembed_send_message): Likewise.
3c647824 6240
b58c5c4a
PE
6241 * insdel.c (make_gap_smaller): Define only if
6242 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6243
cad59032
PE
6244 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6245 it.
6246
c339dc2e
PE
6247 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6248 so that we aren't warned about unused symbols.
6249
91a3e27b
PE
6250 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6251
399c71d3 6252 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6253
8ffc96f5
PE
6254 * xfns.c (x_real_positions): Mark locals as initialized.
6255
eef9bc79
PE
6256 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6257
098db9dd
PE
6258 * xterm.c: Fix problems found by static analysis with other toolkits.
6259 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6260 (x_dispatch_event): Declare static if USE_GTK, and
6261 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6262 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6263 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6264 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6265 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6266
eb18f6cc
PE
6267 * xmenu.c (menu_help_callback): Pointer type fixes.
6268 Use const pointers when pointing at readonly data. Avoid pointer
6269 signedness clashes.
6270 (FALSE): Remove unused macro.
6271 (update_frame_menubar): Remove unused decl.
6272
1fe72bf8
PE
6273 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6274
60d9e1db
PE
6275 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6276 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6277 (single_menu_item): Rename local to avoid shadowing.
6278
39261c26
PE
6279 * keyboard.c (make_lispy_event): Remove unused local var.
6280
018c5e19
PE
6281 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6282 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6283
63d2b86e
PE
6284 * bitmaps: Change bitmaps from unsigned char back to the X11
6285 compatible char. Avoid the old compiler warnings about
6286 out-of-range initializers by using, for example, '\xab' rather
6287 than 0xab.
6288
aefd87e1
PE
6289 * xgselect.c (xgselect_initialize): Check vs interface
6290 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6291
bf501fb9
PE
6292 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6293
e9829fdf
PE
6294 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6295 to read-only memory.
6296
1086c095
PE
6297 * fns.c (vector): Remove; this old hack is no longer needed.
6298
2baccd04 6299 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6300 Remove unused var.
dde42981 6301 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6302
72391843 6303 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6304
436c16df 6305 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6306 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6307 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6308
92bb796d 6309 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6310 (x_term_init): Remove local to avoid shadowing.
92bb796d 6311
764430a3 6312 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6313
6314 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6315 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6316
d1dfb56c
EZ
63172011-04-16 Eli Zaretskii <eliz@gnu.org>
6318
c4354cb4
EZ
6319 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6320
d1dfb56c
EZ
6321 Fix regex.c, syntax.c and friends for buffers > 2GB.
6322 * syntax.h (struct gl_state_s): Declare character position members
6323 EMACS_INT.
6324
6325 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6326
04f2d78b
CB
6327 * textprop.c (verify_interval_modification, interval_of):
6328 Declare arguments EMACS_INT.
d1dfb56c
EZ
6329
6330 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6331 EMACS_INT.
6332
6333 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6334
6335 * indent.c (Fvertical_motion): Local variable it_start is now
6336 EMACS_INT.
6337
6338 * regex.c (re_match, re_match_2, re_match_2_internal)
6339 (bcmp_translate, regcomp, regexec, print_double_string)
6340 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6341 (re_compile_pattern, re_exec): Declare arguments and local
6342 variables `size_t' and `ssize_t' and return values `regoff_t', as
6343 appropriate.
6344 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6345 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6346 <compile_stack_type>: `size' and `avail' are now `size_t'.
6347
6348 * regex.h <regoff_t>: Use ssize_t, not int.
6349 (re_search, re_search_2, re_match, re_match_2): Arguments that
6350 specify buffer/string position and length are now ssize_t and
6351 size_t. Return type is regoff_t.
6352
613052cd
BK
63532011-04-16 Ben Key <bkey76@gmail.com>
6354
6355 * nsfont.m: Fixed bugs in ns_get_family and
6356 ns_descriptor_to_entity that were caused by using free to
6357 deallocate memory blocks that were allocated by xmalloc (via
6358 xstrdup). This caused Emacs to crash when compiled with
6359 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6360 --enable-checking=xmallocoverrun). xfree is now used to
6361 deallocate these memory blocks.
6362
4170f62f 63632011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6364
71b41406
PE
6365 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6366
9587a89d
PE
6367 emacs_write: Accept and return EMACS_INT for sizes.
6368 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6369 et seq.
6370 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6371 Accept and return EMACS_INT.
6372 (emacs_gnutls_write): Return the number of bytes written on
6373 partial writes.
6374 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6375 (emacs_read, emacs_write): Remove check for negative size, as the
6376 Emacs source code has been audited now.
9587a89d
PE
6377 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6378 (emacs_read, emacs_write): Use it.
273a5f82
PE
6379 * process.c (send_process): Adjust to the new signatures of
6380 emacs_write and emacs_gnutls_write. Do not attempt to store
6381 a byte offset into an 'int'; it might overflow.
9587a89d 6382 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6383
3e047f51
PE
6384 * sound.c: Don't assume sizes fit in 'int'.
6385 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6386 Return EMACS_INT, not int.
3e047f51 6387 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6388 Accept EMACS_INT, not int.
6389 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6390 record read return values.
6391
cc39a9db
BK
63922011-04-15 Ben Key <bkey76@gmail.com>
6393
c9d0ec6d
JB
6394 * keyboard.c (Qundefined): Don't declare static since it is used
6395 in nsfns.m.
6396 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6397 static since they are used in nsfont.m.
cc39a9db 6398
6c60eb9f
SM
63992011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6400
6401 * process.c (Qprocessp): Don't declare static.
6402 * lisp.h (Qprocessp): Declare again.
6403
7990b61a
JB
64042011-04-15 Juanma Barranquero <lekktu@gmail.com>
6405
6406 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6407
5d4cb038
PE
64082011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6409
8bd7b830 6410 Improve C-level modularity by making more things 'static'.
cd64ea1d 6411
e3b27b31
PE
6412 Don't publish debugger-only interfaces to other modules.
6413 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6414 (verify_bytepos, count_markers): Move decls to the only modules
6415 that need them.
6416 * region-cache.h (pp_cache): Likewise.
6417 * window.h (check_all_windows): Likewise.
6418 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6419
5d4cb038
PE
6420 * sysdep.c (croak): Now static, if
6421 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6422 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6423
6424 * alloc.c (refill_memory_reserve): Now static if
6425 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6426 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6427
e87b6180
PE
6428 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6429 Define only if USE_LUCID.
6430
ac64929e
PE
6431 * xrdb.c (x_customization_string, x_rm_string): Now static.
6432
6f37259d
PE
6433 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6434 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6435
1683e3ab
PE
6436 * xdisp.c (draw_row_with_mouse_face): Now static.
6437 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6438
de9c2632
PE
6439 * window.h (check_all_windows): Mark externally visible.
6440
2b96acb7
PE
6441 * window.c (window_deletion_count): Now static.
6442
6443 * undo.c: Make symbols static if they're not exported.
6444 (last_undo_buffer, last_boundary_position, pending_boundary):
6445 Now static.
6446
50436f33
PE
6447 * textprop.c (interval_insert_behind_hooks): Now static.
6448 (interval_insert_in_front_hooks): Likewise.
6449
64520e5c
PE
6450 * term.c: Make symbols static if they're not exported.
6451 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6452 (max_frame_lines, tty_set_terminal_modes):
6453 (tty_reset_terminal_modes, tty_turn_off_highlight):
6454 (get_tty_terminal): Now static.
6455 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6456 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6457 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6458 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6459 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6460
1fa53021
PE
6461 * sysdep.c: Make symbols static if they're not exported.
6462 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6463 Now static.
6464 (sigprocmask_set, full_mask): Remove; unused.
6465 (wait_debugging): Mark as visible.
6466 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6467 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6468
d4b43b22
PE
6469 * syntax.c (syntax_temp): Define only if !__GNUC__.
6470
b7c513d0
PE
6471 * sound.c (current_sound_device, current_sound): Now static.
6472
989b29ad
PE
6473 * search.c (searchbufs, searchbuf_head): Now static.
6474
13a55a78
PE
6475 * scroll.c (scroll_cost): Remove; unused.
6476 * dispextern.h (scroll_cost): Remove decl.
6477
de68a1fc
PE
6478 * region-cache.h (pp_cache): Mark as externally visible.
6479
40ccffa6
PE
6480 * process.c: Make symbols static if they're not exported.
6481 (process_tick, update_tick, create_process, chan_process):
6482 (Vprocess_alist, proc_buffered_char, datagram_access):
6483 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6484 (deactivate_process): Mark defn as static, as well as decl.
6485 * lisp.h (create_process): Remove decl.
6486 * process.h (chan_process, Vprocess_alist): Remove decls.
6487
ad64fc97
PE
6488 * print.c: Make symbols static if they're not exported.
6489 (print_depth, new_backquote_output, being_printed, print_buffer):
6490 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6491 (print_interval, print_number_index, initial_stderr_stream):
6492 Now static.
6493 * lisp.h (Fprinc): Remove decl.
6494 (debug_output_compilation_hack): Mark as externally visible.
6495
adddb265
PE
6496 * sysdep.c (croak): Move decl from here to syssignal.h.
6497 * syssignal.h (croak): Put it here, so the API can be checked when
6498 'croak' is called from dissociate_if_controlling_tty.
6499
1717ede2
PE
6500 * minibuf.c: Make symbols static if they're not exported.
6501 (minibuf_save_list, choose_minibuf_frame): Now static.
6502 * lisp.h (choose_minibuf_frame): Remove decl.
6503
fa5fb2bc
PE
6504 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6505
1e3890d1
PE
6506 * lread.c: Make symbols static if they're not exported.
6507 (read_objects, initial_obarray, oblookup_last_bucket_number):
6508 Now static.
6509 (make_symbol): Remove; unused.
6510 * lisp.h (initial_obarray, make_symbol): Remove decls.
6511
8a1414fa
PE
6512 * keyboard.c: Make symbols static if they're not exported.
6513 (single_kboard, recent_keys_index, total_keys, recent_keys):
6514 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6515 (this_single_command_key_start, echoing, last_auto_save):
6516 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6517 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6518 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6519 (Vlispy_mouse_stem, double_click_count):
6520 Now static.
6521 (force_auto_save_soon): Define only if SIGDANGER.
6522 (ignore_mouse_drag_p): Now static if
6523 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6524 (print_help): Remove; unused.
6525 (stop_character, last_timer_event): Mark as externally visible.
6526 * keyboard.h (ignore_mouse_drag_p): Declare only if
6527 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6528 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6529 * lisp.h (echoing): Remove decl.
6530 (force_auto_save_soon): Declare only if SIGDANGER.
6531 * xdisp.c (redisplay_window): Simplify code, to make it more
6532 obvious that ignore_mouse_drag_p is not accessed if !defined
6533 USE_GTK && !defined HAVE_NS.
6534
93ea6e8f
PE
6535 * intervals.c: Make symbols static if they're not exported.
6536 (merge_properties_sticky, merge_interval_right, delete_interval):
6537 Now static.
6538 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6539
77382fcc
PE
6540 * insdel.c: Make symbols static if they're not exported.
6541 However, leave prepare_to_modify_buffer alone. It's never
6542 called from outside this function, but that appears to be a bug.
6543 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6544 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6545 (adjust_after_replace_noundo): Remove; unused.
6546 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6547 (signal_before_change): Remove decls.
77382fcc 6548
9306c32e
PE
6549 * indent.c (val_compute_motion, val_vmotion): Now static.
6550
cd44d2eb
PE
6551 * image.c: Make symbols static if they're not exported.
6552 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6553 if USE_GTK.
6554 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6555 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6556
ad9a7a06
PE
6557 * fringe.c (standard_bitmaps): Now static.
6558 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6559
81626931
PE
6560 * frame.c: Make symbols static if they're not exported.
6561 (x_report_frame_params, make_terminal_frame): Now static.
6562 (get_frame_param): Now static, unless HAVE_NS.
6563 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6564 (x_get_resource_string): Remove; not used.
6565 * frame.h (make_terminal_frame, x_report_frame_params):
6566 (x_get_resource_string); Remove decls.
6567 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6568 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6569
239f9db9
PE
6570 * font.c, fontset.c: Make symbols static if they're not exported.
6571 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6572 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6573 * font.c (font_close_object): Now static.
6574 * font.h (font_close_object): Remove.
6575 * fontset.c (FONTSET_OBJLIST): Remove.
6576 (free_realized_fontset) #if-0 the body, which does nothing.
6577 (face_suitable_for_char_p): #if-0, as it's never called.
6578 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6579 * xfaces.c (face_at_string_position):
6580 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6581 since 0 is always ASCII.
6582
dfcf3579
PE
6583 * fns.c (weak_hash_tables): Now static.
6584
5045092b
PE
6585 * fileio.c: Make symbols static if they're not exported.
6586 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6587 (Vwrite_region_annotation_buffers): Now static.
6588
57a96f5c
PE
6589 * eval.c: Make symbols static if they're not exported.
6590 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6591 * lisp.h (backtrace_list): Remove decl.
6592
35f08c38
PE
6593 * emacs.c: Make symbols static if they're not exported.
6594 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6595 (fatal_error_code, fatal_error_signal_hook, standard_args):
6596 Now static.
6597 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6598 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6599 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6600 * lisp.h (fatal_error_signal_hook): Remove decl.
6601 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6602
f44bd759
PE
6603 * editfns.c: Move a (normally-unused) function to its only use.
6604 * editfns.c, lisp.h (get_operating_system_release): Remove.
6605 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6606 worth the hassle of breaking this out.
6607
b532497d
PE
6608 * xterm.c: Make symbols static if they're not exported.
6609 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6610 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6611 (x_destroy_window, x_delete_display):
6612 Now static.
6613 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6614 (x_mouse_leave): Remove; unused.
6615 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6616 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6617 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6618 Remove decls.
6619 (x_mouse_leave): Declare only if WINDOWSNT.
6620 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6621 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6622 USE_X_TOOLKIT.
6623
1675728f
PE
6624 * ftxfont.c: Make symbols static if they're not exported.
6625 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6626 HAVE_FREETYPE.
6627 * font.h (ftxfont_driver): Likewise.
6628
e4cebfca
PE
6629 * xfns.c: Make symbols static if they're not exported.
6630 (x_last_font_name, x_display_info_for_name):
6631 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6632 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6633 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6634 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6635 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6636 (last_show_tip_args): Now static.
6637 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6638 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6639 (x_screen_planes): Remove; unused.
6640 * dispextern.h (x_screen_planes): Remove decl.
6641
5bf46f05
PE
6642 * dispnew.c: Make symbols static if they're not exported.
6643 * dispextern.h (redraw_garbaged_frames, scrolling):
6644 (increment_row_positions): Remove.
6645 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6646 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6647 Now static.
6648 (redraw_garbaged_frames): Remove; unused.
6649
435f4c28
PE
6650 * xfaces.c: Make symbols static if they're not exported.
6651 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6652 Remove decls.
6653 * xterm.h (defined_color): Remove decls.
6654 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6655 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6656 (menu_face_changed_default, defined_color, free_realized_face):
6657 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6658 (ascii_face_of_lisp_face): Remove; unused.
6659
8524aef3
PE
6660 * xdisp.c: Make symbols static if they're not exported.
6661 * dispextern.h (scratch_glyph_row, window_box_edges):
6662 (glyph_to_pixel_coords, set_cursor_from_row):
6663 (get_next_display_element, set_iterator_to_next):
6664 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6665 (show_mouse_face): Remove decls
6666 * frame.h (message_buf_print): Likewise.
6667 * lisp.h (pop_message, set_message, check_point_in_composition):
6668 Likewise.
6669 * xterm.h (set_vertical_scroll_bar): Likewise.
6670 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6671 (message_buf_print, scratch_glyph_row, displayed_buffer):
6672 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6673 (get_next_display_element, show_mouse_face, window_box_edges):
6674 (frame_to_window_pixel_xy, check_point_in_composition):
6675 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6676 (glyph_to_pixel_coords): Remove; unused.
6677
16390cd2
PE
6678 * dired.c (file_name_completion): Now static.
6679
6680 * dbusbind.c (xd_in_read_queued_messages): Now static.
6681
a25f4dfa
PE
6682 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6683 * data.c (circular_list_error): Remove.
6684
14a9c8df
PE
6685 * commands.h (last_point_position, last_point_position_buffer):
6686 (last_point_position_window): Remove decls.
6687 * keyboard.c: Make these variables static.
6688
04f2d78b
CB
6689 * coding.h (coding, code_convert_region, encode_coding_gap):
6690 Remove decls.
74ab6df5
PE
6691 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6692 (iso_code_class, detect_coding, code_convert_region): Now static.
6693 (encode_coding_gap): Remove; unused.
6694
38dfbee1
PE
6695 * chartab.c (chartab_chars, chartab_bits): Now static.
6696
a2cb4e63
PE
6697 * charset.h (charset_iso_8859_1): Remove decl.
6698 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6699 Now static.
6700
127198fd
PE
6701 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6702 * ccl.c (Vccl_program_table): Now static.
6703 (check_ccl_update): Remove; unused.
6704
d85b608f
PE
6705 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6706 * category.h: ... from here.
6707 * category.c (check_category_table, set_category_set): Now static.
6708
31cd66f3
PE
6709 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6710 * lisp.h: Remove these decls.
6711
c358e587
PE
6712 * buffer.c (buffer_count): Remove unused var.
6713
e78aecca
PE
6714 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6715 so that it's not optimized away.
6716 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6717 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6718 exported only to the debugger.
6719
e192d7d3 6720 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6721 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6722
92470028
PE
6723 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6724 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6725 was inaccessible from Lisp.
6726 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6727 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6728
244ed907
PE
6729 alloc.c: Import and export fewer symbols, and remove unused items.
6730 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6731 is defined.
6732 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6733 it's not optimized away by whole-program optimization.
6734 (message_enable_multibyte, free_misc): Remove.
6735 (catchlist, handlerlist, mark_backtrace):
6736 Declare only if BYTE_MARK_STACK.
6737 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6738 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6739 (message_enable_multibyte): Remove decl.
6740 (free_misc, interval_free_list, float_block, float_block_index):
6741 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6742 (cons_free_list, last_marked_index):
6743 Now static.
6744 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6745 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6746 (mark_backtrace): Define only if BYTE_MARK_STACK.
6747 * xdisp.c (message_enable_multibyte): Now static.
6748
61c2b50e 6749 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6750 This makes it easier for human readers (and static analyzers)
6751 to see whether these variables are used from other modules.
6752 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6753 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6754 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6755 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6756 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6757 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6758 * xmenu.c, xselect.c:
6759 Declare Q* vars static if they are not used in other modules.
6760 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6761 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6762 Remove decls of unexported vars.
6763 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6764
95c82688
PE
6765 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6766
16a97296
PE
6767 Make Emacs functions such as Fatom 'static' by default.
6768 This makes it easier for human readers (and static analyzers)
6769 to see whether these functions can be called from other modules.
6770 DEFUN now defines a static function. To make the function external
6771 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6772 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6773 (Finit_image_library):
16a97296
PE
6774 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6775 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6776 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6777 Remove decls, since these functions are now static.
6778 (Funintern, Fget_internal_run_time): New decls, since these functions
6779 were already external.
95c82688 6780
16a97296
PE
6781 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6782 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6783 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6784 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6785 * keyboard.c, keymap.c, lread.c:
6786 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6787 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6788 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6789 Mark functions with DEFUE instead of DEFUN,
6790 if they are used in other modules.
6791 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6792 decls for now-static functions.
6793 * buffer.h (Fdelete_overlay): Remove decl.
6794 * callproc.c (Fgetenv_internal): Mark as internal.
6795 * composite.c (Fremove_list_of_text_properties): Remove decl.
6796 (Fcomposition_get_gstring): New forward static decl.
6797 * composite.h (Fcomposite_get_gstring): Remove decl.
6798 * dired.c (Ffile_attributes): New forward static decl.
6799 * doc.c (Fdocumntation_property): New forward static decl.
6800 * eval.c (Ffetch_bytecode): New forward static decl.
6801 (Funintern): Remove extern decl; now in .h file where it belongs.
6802 * fileio.c (Fmake_symbolic_link): New forward static decl.
6803 * image.c (Finit_image_library): New forward static decl.
6804 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6805 * intervals.h (Fprevious_property_change):
6806 (Fremove_list_of_text_properties): Remove decls.
6807 * keyboard.c (Fthis_command_keys): Remove decl.
6808 (Fcommand_execute): New forward static decl.
6809 * keymap.c (Flookup_key): New forward static decl.
6810 (Fcopy_keymap): Now static.
6811 * keymap.h (Flookup_key): Remove decl.
6812 * process.c (Fget_process): New forward static decl.
6813 (Fprocess_datagram_address): Mark as internal.
6814 * syntax.c (Fsyntax_table_p): New forward static decl.
6815 (skip_chars): Remove duplicate decl.
6816 * textprop.c (Fprevious_property_change): New forward static decl.
6817 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6818 Now internal.
6819 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6820 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6821
785bbd42
PE
6822 * editfns.c (Fformat): Remove unreachable code.
6823
8b913b57
AS
68242011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6825
6826 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6827 change. (Bug#8496)
6828
a6744a35
EZ
68292011-04-13 Eli Zaretskii <eliz@gnu.org>
6830
6831 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6832 when at ZV. (Bug#8487)
6833
e7974947
AS
68342011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6835
baad03f0
AS
6836 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6837 (Bug#8437)
6838 * keyboard.c (parse_tool_bar_item): Likewise.
6839 * sound.c (sound_cleanup, alsa_close): Likewise.
6840 * termcap.c (tgetent): Likewise.
6841 * xfns.c (x_default_font_parameter): Likewise.
6842 * xsettings.c (read_and_apply_settings): Likewise.
6843
e7974947
AS
6844 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6845 (overrun_check_free): Protoize.
6846
28272684
PE
68472011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6848
6849 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6850 since callers should never pass a negative size.
6851 Change the signature to match that of plain 'read' and 'write'; see
6852 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6853 * lisp.h: Update prototypes of emacs_write and emacs_read.
6854
11997c76
EZ
68552011-04-11 Eli Zaretskii <eliz@gnu.org>
6856
6857 * xdisp.c (redisplay_window): Don't try to determine the character
6858 position of the scroll margin if the window start point w->startp
e896f03c 6859 is outside the buffer's accessible region. (Bug#8468)
11997c76 6860
8a2cbd72
EZ
68612011-04-10 Eli Zaretskii <eliz@gnu.org>
6862
6863 Fix write-region and its subroutines for buffers > 2GB.
6864 * fileio.c (a_write, e_write): Modify declaration of arguments and
6865 local variables to support buffers larger than 2GB.
6866 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6867
6868 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6869 argument, local variables, and return value.
6870
6871 * lisp.h: Update prototypes of emacs_write and emacs_read.
6872
6873 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6874
4073e537 68752011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6876
1ebfdcb6
PE
6877 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6878
b2ded58d
PE
6879 Fix more problems found by GCC 4.6.0's static checks.
6880
7d66342c
PE
6881 * xdisp.c (vmessage): Use a better test for character truncation.
6882
bbf47d44
PE
6883 * charset.c (load_charset_map): <, not <=, for optimization,
6884 and to avoid potential problems with integer overflow.
9248994d 6885 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6886 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6887 * editfns.c (Fformat): Likewise.
1e69125e 6888 * syntax.c (skip_chars): Likewise.
3befa583 6889
e3019616
PE
6890 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6891 This also lets GCC 4.6.0 generate slightly better loop code.
6892
becfa255
PE
6893 * callint.c (Fcall_interactively): <, not <=, for optimization.
6894 (Fcall_interactively): Count the number of arguments produced,
6895 not the number of arguments given. This is simpler and lets GCC
6896 4.6.0 generate slightly better code.
6897
dae0cd48
PE
6898 * ftfont.c: Distingish more carefully between FcChar8 and char.
6899 The previous code passed unsigned char * to a functions like
6900 strlen and xstrcasecmp that expect char *, which does not
6901 conform to the C standard.
6902 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6903 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6904 char * when the C standard requires it.
6905
76032d70
PE
6906 * keyboard.c (read_char): Remove unused var.
6907
eb3f1cc8
PE
6908 * eval.c: Port to Windows vsnprintf (Bug#8435).
6909 Include <limits.h>.
6910 (SIZE_MAX): Define if the headers do not.
6911 (verror): Do not give up if vsnprintf returns a negative count.
6912 Instead, grow the buffer. This ports to Windows vsnprintf, which
6913 does not conform to C99. Problem reported by Eli Zaretskii.
6914 Also, simplify the allocation scheme, by avoiding the need for
6915 calling realloc, and removing the ALLOCATED variable.
6916
70476b54
PE
6917 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6918
12020a9e
PE
6919 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6920 But keep the doprint source code for now, as we might revamp it
6921 and use it again (Bug#8435).
ea6c7ae6
PE
6922 * lisp.h (doprnt): Remove.
6923 * Makefile.in (base_obj): Remove doprnt.o.
6924 * deps.mk (doprnt.o): Remove.
6925
5fdb398c
PE
6926 error: Print 32- and 64-bit integers portably (Bug#8435).
6927 Without this change, on typical 64-bit hosts error ("...%d...", N)
6928 was used to print both 32- and 64-bit integers N, which relied on
6929 undefined behavior.
6930 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6931 New macro.
6932 * lisp.h (error, verror): Mark as printf-like functions.
6933 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6934 Report overflow in size calculations when allocating printf buffer.
6935 Do not truncate output string at its first null byte.
6936 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6937 Truncate the output at a character boundary, since vsnprintf does not
6938 do that.
6939 * charset.c (check_iso_charset_parameter): Convert internal
6940 character to string before calling 'error', since %c now has the
6941 printf meaning.
6942 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6943 overflow when computing char to be passed to 'error'. Do not
6944 pass Lisp_Object to 'error'; pass the integer instead.
6945 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6946 formatted with plain %d.
6947
b189fa66
PE
6948 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6949
bff87ef0
PE
6950 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6951
7e2cac20
PE
6952 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6953
ce4d90b5
PE
6954 * xterm.c (x_catch_errors): Remove duplicate declaration.
6955
266c9547
PE
6956 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6957
79c49ad2
PE
6958 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6959
368f4090
JM
69602011-04-10 Jim Meyering <meyering@redhat.com>
6961
6962 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6963 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6964 return ssize_t not "int", and use size_t as the buffer length.
6965 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6966 * gnutls.h: Update declarations.
6967 * process.c (read_process_output): Use ssize_t, to match.
6968 (send_process): Likewise.
6969
a32d4040
CY
69702011-04-09 Chong Yidong <cyd@stupidchicken.com>
6971
6972 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6973
8546720e 69742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6975
04f2d78b
CB
6976 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6977 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6978
8546720e
GM
6979 * xterm.c (handle_one_xevent):
6980 * xmenu.c (create_and_show_popup_menu):
6981 * xselect.c (x_decline_selection_request)
6982 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6983
0a2f5c1a 69842011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6985
6986 Fix some uses of `int' instead of EMACS_INT.
6987 * search.c (string_match_1, fast_string_match)
6988 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6989 (scan_buffer, find_next_newline_no_quit)
6990 (find_before_next_newline, search_command, Freplace_match)
6991 (Fmatch_data): Make some `int' variables be EMACS_INT.
6992
6993 * xdisp.c (display_count_lines): 3rd argument and return value now
6994 EMACS_INT. All callers changed.
6995 (pint2hrstr): Last argument is now EMACS_INT.
6996
6997 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6998 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6999 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7000 (decode_coding_utf_16, decode_coding_emacs_mule)
7001 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7002 (decode_coding_ccl, decode_coding_charset)
7003 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7004 (decode_coding_iso_2022, decode_coding_emacs_mule)
7005 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7006 <char_offset, last_offset>: Declare EMACS_INT.
7007 (encode_coding_utf_8, encode_coding_utf_16)
7008 (encode_coding_emacs_mule, encode_invocation_designation)
7009 (encode_designation_at_bol, encode_coding_iso_2022)
7010 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7011 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7012 Declare EMACS_INT.
7013 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7014 (encode_invocation_designation): Last argument P_NCHARS is now
7015 EMACS_INT.
7016 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7017 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7018
7019 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7020 All users changed.
7021
7022 * ccl.c (Fccl_execute_on_string): Declare some variables
7023 EMACS_INT.
7024
8546720e 70252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7026
7027 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7028
4e19a977
CS
70292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7030
7031 * process.c (Fformat_network_address): Doc fix.
7032
87302331
R
70332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7034
7035 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7036
cbb59342
CY
70372011-04-08 Chong Yidong <cyd@stupidchicken.com>
7038
7039 * keyboard.c (read_char): Call Lisp function help-form-show,
7040 instead of using internal_with_output_to_temp_buffer.
7041 (Qhelp_form_show): New var.
e0d38eeb 7042 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7043
7044 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7045
7046 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7047
e67a13ab
CY
70482011-04-06 Chong Yidong <cyd@stupidchicken.com>
7049
04f2d78b
CB
7050 * process.c (Flist_processes): Remove to Lisp.
7051 (list_processes_1): Delete.
e67a13ab 7052
973f782d
EZ
70532011-04-06 Eli Zaretskii <eliz@gnu.org>
7054
7c106b1e
EZ
7055 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7056
973f782d
EZ
7057 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7058
41cf7d1a 70592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7060
ca23cc88
PE
7061 Fix more problems found by GCC 4.6.0's static checks.
7062
f390e2d5
PE
7063 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7064
42eea0d0
PE
7065 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7066
b69769da 7067 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7068
f9541e84
PE
7069 * xdisp.c (vmessage): Mark as a printf-like function.
7070
13841b55
PE
7071 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7072
c136c10f
PE
7073 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7074
5e2d4a30
PE
7075 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7076 printf-like functions.
7077 (tiff_load): Add casts to remove these marks before passing them
7078 to system-supplied API.
7079
583f48b9
PE
7080 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7081
b25d760e
PE
7082 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7083 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7084 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7085 directly, rather than having caller test rule sign. This avoids
7086 some unnecessary tests.
7087 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7088 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7089 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7090
bc7b6697 7091 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7092 (xfont_open): Avoid unnecessary tests.
bc7b6697 7093
27ccc379
PE
7094 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7095
dcd5c89a
PE
7096 * composite.h, composite.c (composition_gstring_put_cache):
7097 Use EMACS_INT, not int, for length.
7098
b13a45c6
PE
7099 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7100 breaking out part of COMPOSITION_DECODE_RULE.
7101 (COMPOSITION_DECODE_RULE): Use it.
7102 * composite.c (get_composition_id): Remove unused local vars,
7103 by using the new macro.
7104
1e792e4d
PE
7105 * textprop.c (set_text_properties_1): Change while to do-while,
7106 since the condition is always true at first.
7107
dc6c6455 7108 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7109 (interval_deletion_adjustment): Return unsigned value.
7110 All uses changed.
dc6c6455 7111
aba7731a
PE
7112 * process.c (list_processes_1, create_pty, read_process_output):
7113 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7114 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7115 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7116 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7117 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7118
fdfc4bf3
PE
7119 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7120
fca8fe46 7121 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7122 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7123
06a0259a 7124 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7125 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7126 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7127
e7b9e80f
PE
7128 * print.c (print_error_message): Avoid int overflow.
7129
56201685
PE
7130 * font.c (font_list_entities): Redo for clarity,
7131 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7132
78834453 7133 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7134 (font_score): Avoid potential overflow in diff calculation.
78834453 7135
0bc0b309 7136 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7137 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7138
e610eaca
PE
7139 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7140
b895abce
PE
7141 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7142 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7143 can always succeed if overflow has undefined behavior.
7144
1f1d9321 7145 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7146 (wordify): Omit three unnecessary tests.
1f1d9321 7147
c59478bc
PE
7148 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7149 All callers changed. This avoids the need for an unused var.
7150
79b73827
PE
7151 * casefiddle.c (casify_region): Remove var that is set but not used.
7152
a4db5dfe
PE
7153 * dired.c (file_name_completion): Remove var that is set but not used.
7154
43aae36e
PE
7155 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7156
2a47c44d 7157 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7158 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7159
a37c69bf
PE
7160 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7161 Check for integer overflow on size calculations.
7162
328ab8e7
PE
7163 * buffer.c (Fprevious_overlay_change): Remove var that is set
7164 but not used.
7165
e5a2a5cb
PE
7166 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7167 Remove vars that are set but not used.
8d84a6eb 7168 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7169 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7170
a60e5f68
PE
7171 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7172
f661cb61 7173 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7174 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7175
f0397f5a
PE
7176 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7177 that are set but not used.
7178
8664db06 7179 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7180 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7181
6abdaa4a
PE
7182 * xselect.c (x_get_local_selection, x_handle_property_notify):
7183 Remove vars that are set but not used.
7184
0ce7538d 7185 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7186 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7187
9ae848fc
PE
7188 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7189 Remove var that is set but not used.
0b918413
PE
7190 (scroll_bar_windows_size): Now size_t, not int.
7191 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7192 Check for overflow.
9ae848fc 7193
a5a62657
PE
7194 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7195 (map_tty_color) [!defined MSDOS]: Likewise.
7196
5c5cdd39
PE
7197 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7198
66ebf983
PE
7199 * coding.c: Remove vars that are set but not used.
7200 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7201 All callers changed.
7202 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7203 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7204 (decode_coding_charset): Remove vars that are set but not used.
7205
1be4d761
PE
7206 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7207 that is set but not used.
7208
47553fa8
PE
7209 * print.c (print_object): Remove var that is set but not used.
7210
1f7196bf 7211 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7212 The gnulib version avoids calling malloc in the usual case,
7213 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7214 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7215 * filelock.c (current_lock_owner): Likewise.
7216 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7217 * sysdep.c: Include allocator.h, careadlinkat.h.
7218 (emacs_no_realloc_allocator): New static constant.
7219 (emacs_readlink): New function.
fdb61804
PE
7220 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7221 ../lib/careadlinkat.h.
d1fdcab7 7222
f84c17c7
SM
72232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7224
7225 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7226 first non-nil return value).
7227
ef3862ad
JD
72282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7229
7230 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7231 if not defined (Bug#8403).
7232
376a7006
JB
72332011-04-02 Juanma Barranquero <lekktu@gmail.com>
7234
7235 * xdisp.c (display_count_lines): Remove parameter `start',
7236 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7237 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7238 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7239 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7240 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7241 and thereabouts. All callers changed.
7242 (get_per_char_metric): Remove parameter `f', unused since
7243 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7244
6ca3801d
JM
72452011-04-02 Jim Meyering <meyering@redhat.com>
7246
7247 do not dereference NULL upon failed strdup
7248 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7249 (ns_get_family): Likewise.
7250
d8e2b5ba
JB
72512011-04-02 Juanma Barranquero <lekktu@gmail.com>
7252
7253 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7254
8c74fcbd
JD
72552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7256
7257 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7258 later (Bug#8403).
7259
7200d79c
SM
72602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7261
03408648 7262 Add lexical binding.
7200d79c 7263
03408648
SM
7264 * window.c (Ftemp_output_buffer_show): New fun.
7265 (Fsave_window_excursion):
7266 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7267
7268 * lread.c (lisp_file_lexically_bound_p): New function.
7269 (Fload): Bind Qlexical_binding.
7270 (readevalloop): Remove `evalfun' arg.
7271 Bind Qinternal_interpreter_environment.
7272 (Feval_buffer): Bind Qlexical_binding.
7273 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7274 Mark as dynamic.
7275 (syms_of_lread): Declare `lexical-binding'.
7276
7277 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7278
7279 * keyboard.c (eval_dyn): New fun.
7280 (menu_item_eval_property): Use it.
ca105506
SM
7281
7282 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7283
03408648
SM
7284 * fns.c (concat, mapcar1): Accept byte-code-functions.
7285
7286 * eval.c (Fsetq): Handle lexical vars.
7287 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7288 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7289 (FletX, Flet): Obey lexical binding.
7290 (Fcommandp): Handle closures.
7291 (Feval): New `lexical' arg.
7292 (eval_sub): New function extracted from Feval. Use it almost
7293 everywhere where Feval was used. Look up vars in lexical env.
7294 Handle closures.
7295 (Ffunctionp): Move from subr.el.
7296 (Ffuncall): Handle closures.
7297 (apply_lambda): Remove `eval_flags'.
7298 (funcall_lambda): Handle closures and new byte-code-functions.
7299 (Fspecial_variable_p): New function.
7300 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7301 but without exporting it to Lisp.
23aba0ea 7302
23aba0ea 7303 * doc.c (Fdocumentation, store_function_docstring):
03408648 7304 * data.c (Finteractive_form): Handle closures.
23aba0ea 7305
03408648
SM
7306 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7307 interactive spec.
ba83908c 7308
04f2d78b
CB
7309 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7310 New byte-codes.
03408648
SM
7311 (exec_byte_code): New function extracted from Fbyte_code to handle new
7312 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7313
03408648 7314 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7315
03408648 7316 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7317
e2abce01
JB
73182011-03-31 Juanma Barranquero <lekktu@gmail.com>
7319
7320 * xdisp.c (redisplay_internal): Fix prototype.
7321
63696a73 73222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7323
63696a73 7324 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7325 (try_scrolling): Use it when setting scroll_limit.
7326 Limit scrolling to 100 screen lines.
63696a73
EZ
7327 (redisplay_window): Even when falling back on "recentering",
7328 position point in the window according to scroll-conservatively,
7329 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7330
7331 (try_scrolling): When point is above the window, allow searching
7332 as far as scroll_max, or one screenful, to compute vertical
7333 distance from PT to the scroll margin position. This prevents
7334 try_scrolling from unnecessarily failing when
7335 scroll-conservatively is set to a value slightly larger than the
7336 window height. Clean up the case of PT below the margin at bottom
7337 of window: scroll_max can no longer be INT_MAX. When aggressive
7338 scrolling is in use, don't let point enter the opposite scroll
7339 margin as result of the scroll.
7340 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7341 threshold of 100 lines for never-recentering scrolling.
7342
e4cc2dfc
JB
73432011-03-31 Juanma Barranquero <lekktu@gmail.com>
7344
7345 * dispextern.h (move_it_by_lines):
7346 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7347 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7348 (message_log_check_duplicate): Remove parameters `prev_bol' and
7349 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7350 (redisplay_internal): Remove parameter `preserve_echo_area',
7351 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7352
7353 * indent.c (Fvertical_motion):
7354 * window.c (window_scroll_pixel_based, Frecenter):
7355 Don't pass `need_y_p' to `move_it_by_lines'.
7356
1c470562
SM
73572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7358
44f230aa
SM
7359 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7360 steal a few bits to be more compact.
7361 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7362 Remove unneeded casts.
7363
1c470562
SM
7364 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7365
888adce9
ZK
73662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7367
7368 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7369 binding" message (bug#7967).
7370
f838ed7b
PE
73712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7372
77861b95
PE
7373 Fix more problems found by GCC 4.6.0's static checks.
7374
de6dbc14
PE
7375 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7376 Remove unused local var.
7377
f838ed7b
PE
7378 * editfns.c (Fmessage_box): Remove unused local var.
7379
792c7b2b
PE
7380 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7381 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7382 Omit unused local vars.
c499e557 7383 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7384 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7385 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7386 Omit unused local var.
7387
ba0165e1
PE
7388 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7389 Don't assume string length fits in int.
32ad8845 7390 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7391 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7392
3c59b4c9
PE
7393 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7394 instead of alloca (Bug#8344).
7395
a3eed478 7396 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7397 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7398
eb4d412d
PE
7399 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7400
1658b401
PE
7401 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7402 concerns.
7403
7404 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7405
7406 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7407
9a2c6e05
PE
7408 * keyboard.c (syms_of_keyboard): Use the same style as later
7409 in this function when indexing through an array. This also
7410 works around GCC bug 48267.
7411
03d0a109
PE
7412 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7413
44f730c8
PE
7414 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7415
fe75f926
PE
7416 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7417 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7418
ffa8c828
PE
7419 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7420 This avoids undefined behavior on integer overflow, and is a bit
7421 more convenient anyway since it is compared to a size_t variable.
7422
c5101a77
PE
7423 Variadic C functions now count arguments with size_t, not int.
7424 This avoids an unnecessary limitation on 64-bit machines, which
7425 caused (substring ...) to crash on large vectors (Bug#8344).
7426 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7427 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7428 All variadic functions and their callers changed accordingly.
c5101a77
PE
7429 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7430 * data.c (arith_driver, float_arith_driver): Likewise.
7431 * editfns.c (general_insert_function): Likewise.
7432 * eval.c (struct backtrace.nargs, interactive_p)
7433 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7434 (funcall_lambda, mark_backtrace): Likewise.
7435 * fns.c (concat): Likewise.
7436 * frame.c (x_set_frame_parameters): Likewise.
7437 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7438 0 if not found, not -1. All callers changed.
7439
dd3f25f7
PE
7440 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7441 (stack_copy_size): Now size_t, not int.
7442 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7443
461c2ab9
JB
74442011-03-28 Juanma Barranquero <lekktu@gmail.com>
7445
7446 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7447 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7448 All callers changed.
7449
7450 * lisp.h (multibyte_char_to_unibyte):
7451 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7452 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7453 * character.h (CHAR_TO_BYTE8):
7454 * cmds.c (internal_self_insert):
7455 * editfns.c (general_insert_function):
7456 * keymap.c (push_key_description):
7457 * search.c (Freplace_match):
7458 * xdisp.c (message_dolog, set_message_1): All callers changed.
7459
f6d62986
SM
74602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7461
7462 * keyboard.c (safe_run_hook_funcall): New function.
7463 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7464 don't set the hook to nil, but remove the offending function instead.
7465 (Qcommand_hook_internal): Remove, unused.
7466 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7467 Vcommand_hook_internal.
7468
7469 * eval.c (enum run_hooks_condition): Remove.
7470 (funcall_nil, funcall_not): New functions.
7471 (run_hook_with_args): Call each function through a `funcall' argument.
7472 Remove `cond' argument, now redundant.
7473 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7474 (Frun_hook_with_args_until_failure): Adjust accordingly.
7475 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7476
1db5b1ad
JB
74772011-03-28 Juanma Barranquero <lekktu@gmail.com>
7478
7479 * dispextern.h (string_buffer_position): Remove declaration.
7480
7481 * print.c (strout): Remove parameter `multibyte', unused since
7482 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7483
7484 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7485 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7486 All callers changed.
7487
7488 * w32.c (_wsa_errlist): Use braces for struct initializers.
7489
7490 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7491 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7492 All callers changed.
7493 (string_buffer_position): Likewise. Also, make static (it's never
7494 used outside xdisp.c).
7495 (cursor_row_p): Remove parameter `w', unused since
7496 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7497 (decode_mode_spec): Remove parameter `precision', introduced during
7498 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7499 All callers changed.
7500
5ffb62aa
JD
75012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7502
7503 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7504
461c2ab9 75052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7506
7507 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7508 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7509 (ns_update_auto_hide_menu_bar): New functions.
7510 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7511 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7512 ns_constrain_all_frames.
7513 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7514 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7515
5c380ffb
JD
75162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7517
7518 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7519
9af30bdf
GM
75202011-03-27 Glenn Morris <rgm@gnu.org>
7521
7522 * syssignal.h: Replace RETSIGTYPE with void.
7523 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7524 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7525 Replace SIGTYPE with void everywhere.
7526 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7527 * s/template.h (SIGTYPE): Remove commented out definition.
7528
e2abce01
JB
75292011-03-26 Eli Zaretskii <eliz@gnu.org>
7530
7531 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7532 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7533
f868cd8a
JB
75342011-03-26 Juanma Barranquero <lekktu@gmail.com>
7535
59eb0929
JB
7536 * w32.c (read_unc_volume): Use parameter `henum', instead of
7537 global variable `wget_enum_handle'.
7538
7539 * keymap.c (describe_vector): Remove parameters `indices' and
7540 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7541 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7542
f868cd8a
JB
7543 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7544
7545 * keyboard.c (timer_check): Remove parameter `do_it_now',
7546 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7547 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7548 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7549
7550 * keyboard.c (read_char):
7551 * w32menu.c (w32_menu_display_help):
7552 * xmenu.c (show_help_event, menu_help_callback):
7553 Adjust calls to `show_help_echo'.
7554
7555 * gtkutil.c (xg_maybe_add_timer):
7556 * keyboard.c (readable_events):
7557 * process.c (wait_reading_process_output):
7558 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7559
7560 * insdel.c (adjust_markers_gap_motion):
7561 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7562 (gap_left, gap_right): Don't call it.
7563
2ecf6fdb
CY
75642011-03-25 Chong Yidong <cyd@stupidchicken.com>
7565
7566 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7567 incurred during fontification.
7568
6b1f9ba4
JB
75692011-03-25 Juanma Barranquero <lekktu@gmail.com>
7570
7571 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7572 (DEFVAR_PER_BUFFER): Don't pass it.
7573
7574 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7575 (scrolling_window): Don't pass it.
7576
0f4a96b5
JB
75772011-03-25 Juanma Barranquero <lekktu@gmail.com>
7578
7579 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7580
7581 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7582 and `suffix'.
7583 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7584 of variables specific to SELinux and computation of `encoded_absname'.
7585
7586 * image.c (XPutPixel): Remove unused variable `height'.
7587
7588 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7589
7590 * unexw32.c (get_section_info): Remove unused variable `section'.
7591
7592 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7593 (system_process_attributes): Remove unused variable `sess'.
7594 (sys_read): Remove unused variable `err'.
7595
7596 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7597 (w32_wnd_proc): Remove unused variable `isdead'.
7598 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7599 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7600 (x_create_tip_frame): Remove unused variable `tem'.
7601
7602 * w32inevt.c (w32_console_read_socket):
7603 Remove unused variable `no_events'.
7604
7605 * w32term.c (x_draw_composite_glyph_string_foreground):
7606 Remove unused variable `width'.
7607
1149507c
JB
76082011-03-24 Juanma Barranquero <lekktu@gmail.com>
7609
7610 * w32term.c (x_set_glyph_string_clipping):
7611 Don't pass uninitialized region to CombineRgn.
7612
9c88f339
JB
76132011-03-23 Juanma Barranquero <lekktu@gmail.com>
7614
7615 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7616 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7617 (Fx_close_connection): Remove unused variable `i'.
7618
7619 * w32font.c (w32font_draw): Return number of glyphs.
7620 (w32font_open_internal): Remove unused variable `i'.
7621 (w32font_driver): Add missing initializer.
7622
7623 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7624 (fill_in_menu): Remove unused variable `items_added'.
7625
7626 * w32term.c (last_mouse_press_frame): Remove static global variable.
7627 (w32_clip_to_row): Remove unused variable `f'.
7628 (x_delete_terminal): Remove unused variable `i'.
7629
7630 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7631 (NOTHING): Remove unused static global variable.
7632 (uniscribe_check_otf): Remove unused variable `table'.
7633 (uniscribe_font_driver): Add missing initializers.
7634
dee091a3
JD
76352011-03-23 Julien Danjou <julien@danjou.info>
7636
7637 * term.c (Fsuspend_tty, Fresume_tty):
7638 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7639 * window.c (temp_output_buffer_show):
7640 * insdel.c (signal_before_change):
7641 * frame.c (Fhandle_switch_frame):
7642 * fileio.c (Fdo_auto_save):
7643 * emacs.c (Fkill_emacs):
7644 * editfns.c (save_excursion_restore):
7645 * cmds.c (internal_self_insert):
7646 * callint.c (Fcall_interactively):
7647 * buffer.c (Fkill_all_local_variables):
7648 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7649 Use Frun_hooks.
0f4a96b5 7650 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7651 unconditionnaly since it does the check itself.
7652
2c520ab5 76532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7654
c9c49752
PE
7655 Fix more problems found by GCC 4.5.2's static checks.
7656
8abc3f12
PE
7657 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7658 the first time through the loop, since we know p0 < p1 then.
7659 This also avoids a gcc -Wstrict-overflow warning.
7660
a2d26660
PE
7661 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7662 leading to a memory leak, possible in functions like
7663 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7664 of objects (Bug#8318).
a2d26660 7665
916c72e9
PE
7666 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7667 that could (at least in theory) be that large.
7668
19ab8a18
PE
7669 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7670 This is less likely to overflow, and avoids undefined behavior if
7671 overflow does occur. All callers changed. Use strtoul to scan
7672 for the unsigned long integer.
b7cbbd6f
PE
7673 (pint2hrstr): Simplify and tune code slightly.
7674 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7675
f0641eff
PE
7676 * scroll.c (do_scrolling): Work around GCC bug 48228.
7677 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7678
7f650bb9
PE
7679 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7680 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7681 (validate_x_resource_name): Simplify count usage.
7682 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7683
37dd57d1
PE
7684 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7685 fail (Bug#8306).
81e56e61 7686
699979fc 7687 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7688
401bf9b4
PE
7689 * process.c (Fmake_network_process): Use socklen_t, not int,
7690 where POSIX says socklen_t is required in portable programs.
7691 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7692 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7693 (Fmake_network_process, server_accept_connection):
7694 (wait_reading_process_output, read_process_output):
7695 Likewise.
7696
b93aacde
PE
7697 * process.c: Rename or move locals to avoid shadowing.
7698 (list_processes_1, Fmake_network_process):
7699 (read_process_output_error_handler, exec_sentinel_error_handler):
7700 Rename or move locals.
4dc343ee 7701 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7702 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7703 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7704 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7705 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7706
af8a867c 7707 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7708 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7709 Include tparam.h instead, since it declares them.
af8a867c
PE
7710 * cm.h (PC): Remove extern decl; tparam.h now does this.
7711 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7712 * terminfo.c: Include tparam.h, to check interfaces.
7713 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7714 (tparam): Adjust signature to match interface in tparam.h;
7715 this removes some undefined behavior. Check that outstring and len
7716 are zero, which they always are with Emacs.
7717 * tparam.h (PC, BC, UP): New extern decls.
7718
0248044d 7719 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7720 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7721
8ff096c1 7722 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7723 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7724 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7725 (ftfont_list): Remove unused local.
49eaafba
PE
7726 (get_adstyle_property, ftfont_pattern_entity):
7727 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7728 Rename locals to avoid shadowing.
8ff096c1 7729
e2be39f6
PE
7730 * xfont.c (xfont_list_family): Mark var as initialized.
7731
c9735e30
PE
7732 * xml.c (make_dom): Now static.
7733
8f5201ae
PE
7734 * composite.c (composition_compute_stop_pos): Rename local to
7735 avoid shadowing.
b246f932
PE
7736 (composition_reseat_it): Remove unused locals.
7737 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7738 (composition_update_it): Mark var as initialized.
11b61122
PE
7739 (find_automatic_composition): Mark vars as initialized,
7740 with a FIXME (Bug#8290).
8f5201ae 7741
760fbc2c
PE
7742 character.h: Rename locals to avoid shadowing.
7743 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7744 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7745 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7746 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7747 to avoid shadowing.
7748
ff08eb85
PE
7749 * textprop.c (property_change_between_p): Remove; unused.
7750
fc7bf025
PE
7751 * intervals.c (interval_start_pos): Now static.
7752
235d7abc
PE
7753 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7754
44f230aa
SM
7755 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7756 Rename locals to avoid shadowing.
3e7d6594 7757
50060332
PE
7758 * sound.c (wav_play, au_play, Fplay_sound_internal):
7759 Fix pointer signedness.
d01f234b 7760 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7761 (wav_play): Initialize a variable to 0, to prevent undefined
7762 behavior (Bug#8278).
50060332 7763
c4fc4e30
PE
7764 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7765
918436ed
PE
7766 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7767
c939f91b
PE
7768 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7769 clobbering (Bug#8298).
b9c7f648
PE
7770 * sysdep.c (sys_subshell): Likewise.
7771 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7772
6bd8c144
PE
7773 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7774 This should get cleaned up, so that child_setup has the
7775 same signature on all platforms.
7776
7710357c 7777 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7778 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7779
c59da222
CY
77802011-03-22 Chong Yidong <cyd@stupidchicken.com>
7781
7782 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7783 not to be necessary, and produces flickering.
7784
66b87493
GM
77852011-03-20 Glenn Morris <rgm@gnu.org>
7786
7787 * config.in: Remove file.
7788
45b6f6d5
JB
77892011-03-20 Juanma Barranquero <lekktu@gmail.com>
7790
7791 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7792 are now in src/globals.h.
7793 (syms_of_minibuf): Remove spurious & from previous change.
7794
3ec03f7e
LL
77952011-03-20 Leo <sdl.web@gmail.com>
7796
7797 * minibuf.c (completing-read-function): New variable.
7798 (completing-read-default): Rename from completing-read.
7799 (completing-read): Call completing-read-function.
7800
b14e3e21
CY
78012011-03-19 Juanma Barranquero <lekktu@gmail.com>
7802
7803 * xfaces.c (Fx_load_color_file):
7804 Read color file from absolute filename (bug#8250).
7805
f2b726e6
JB
78062011-03-19 Juanma Barranquero <lekktu@gmail.com>
7807
7808 * makefile.w32-in: Update dependencies.
7809
09f6ff02
EZ
78102011-03-17 Eli Zaretskii <eliz@gnu.org>
7811
7812 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7813
29a6015a
PE
78142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7815
a3a6c54e
PE
7816 Fix more problems found by GCC 4.5.2's static checks.
7817
b766f867
PE
7818 * process.c (make_serial_process_unwind, send_process_trap):
7819 (sigchld_handler): Now static.
7820
be02381c
PE
7821 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7822 That way, the code declares only the vars that it needs.
7823 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7824 * s/cygwin.h (PTY_ITERATION): Likewise.
7825 * s/darwin.h (PTY_ITERATION): Likewise.
7826 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7827
57048744
PE
7828 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7829 * process.c (allocate_pty): Don't declare stb unless it's needed.
7830
7914961c 7831 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7832 (CONSTANTLIM): Remove; unused.
7833 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7834 Define only if needed.
7914961c 7835
b3967b18
PE
7836 * unexelf.c (unexec): Name an expression,
7837 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7838 Use a different way to cause a compilation error if anyone uses
7839 n rather than nn, a way that does not involve shadowing.
73366a00 7840 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7841
29a6015a
PE
7842 * deps.mk (unexalpha.o): Remove; unused.
7843
43cfc33e 7844 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7845 * unexec.h: New file.
ce701a33
PE
7846 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7847 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7848 Depend on unexec.h.
7849 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7850 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7851 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7852 Change as necessary to match prototype in unexec.h.
ce701a33 7853
01f44d5a
PE
7854 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7855 shadowing.
4f63c6bb 7856 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7857
a6670b0b
PE
7858 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7859 Rename locals to avoid shadowing.
7860
cef2010d 7861 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7862 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7863
d4d7173a
PE
7864 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7865
f08b802a
PE
7866 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7867 warning when compiling print.c.
7868
3ddb0639
PE
7869 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7870 instead of using an uninitialized var.
5ad03b97 7871 (font_sort_entities): Mark var as initialized.
3ddb0639 7872
170a2692
PE
7873 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7874
e663c700
PE
7875 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7876 pointers to constants.
89bc529a 7877 (font_parse_fcname): Remove unused vars.
7b81e2d0 7878 (font_delete_unmatched): Now static.
ea838e10 7879 (font_get_spec): Remove; unused.
13a547c6
PE
7880 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7881 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7882 Rename or move locals to avoid shadowing.
e663c700 7883
2a80c887 7884 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7885 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7886
1384fa33 7887 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7888 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7889
8b2c52e9
PE
7890 * alloc.c (mark_backtrace): Move decl from here ...
7891 * lisp.h: ... to here, so that it can be checked.
7892
475545b5 7893 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7894 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7895 (lisp_indirect_variable): Name an expression,
7896 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7897 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7898
b1349114 7899 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7900 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7901 Use const pointer when appropriate.
b1349114 7902
a2928364
PE
7903 * lisp.h (get_system_name, get_operating_system_release):
7904 Move decls here, to check interfaces.
7905 * process.c (get_operating_system_release): Move decl to lisp.h.
7906 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7907 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7908 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7909 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7910 (Fformat_time_string, Fencode_time, Finsert_char):
7911 (Ftranslate_region_internal, Fformat):
7912 Rename or remove local vars to avoid shadowing.
9710023e 7913 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7914
a415e694
PE
7915 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7916 avoid shadowing.
7917
8ef4622d
PE
7918 * lisp.h (eassert): Check that the argument compiles, even if
7919 ENABLE_CHECKING is not defined.
7920
946f9a5b
PE
7921 * data.c (Findirect_variable): Name an expression, to avoid
7922 gcc -Wbad-function-cast warning.
112396d6 7923 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7924 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7925 (Fmake_variable_buffer_local, Fmake_local_variable):
7926 Mark variables as initialized.
52746918 7927 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7928
e5aab7e7 7929 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7930 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7931 Rename locals to avoid shadowing.
dff45157
PE
7932 (mark_stack): Move local variables into the #ifdef region where
7933 they're used.
7bc26fdb
PE
7934 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7935 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7936 needed otherwise.
7937 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7938 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7939 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7940
e5aab7e7
PE
7941 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7942 avoids undefined behavior in theory.
7943
4da60324
PE
7944 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7945
88043301
PE
7946 Use functions, not macros, for up- and down-casing (Bug#8254).
7947 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7948 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7949 to use the following functions instead of these macros.
7950 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7951 EMACS_INT, since callers assume the returned value fits in int.
7952 (upcase1): Likewise, for UPCASE_TABLE.
7953 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7954 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7955 the race-condition problem in the old DOWNCASE.
88043301 7956
19ed5445
PE
7957 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7958 Rename locals to avoid shadowing.
7959 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7960 (regex_compile, re_search_2, re_match_2_internal):
7961 Remove unused local vars.
952db0d7
PE
7962 (FREE_VAR): Rewrite so as not to use empty "else",
7963 which gcc can warn about.
da053e48 7964 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7965 (RETALLOC_IF): Define only if needed.
7966 (WORDCHAR_P): Likewise. This one is never needed, but is used
7967 only in a comment talking about a compiler bug, so put inside
7968 the #if 0 of that comment.
7969 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7970 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7971 Remove; unused.
19ed5445 7972
1f3561e4 7973 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7974 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7975 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7976
ded6f8f7
PE
7977 * search.c (simple_search): Remove unused var.
7978
dbd37a95
PE
7979 * dired.c (compile_pattern): Move decl from here ...
7980 * lisp.h: ... to here, so that it can be checked.
7981 (struct re_registers): New forward decl.
7982
7e47afad
PE
7983 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7984
85f24f61
PE
7985 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7986 All uses changed.
7987 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7988 Rename locals to avoid shadowing.
5671df8f 7989 (Fvertical_motion): Mark locals as initialized.
85f24f61 7990
181aa2be 7991 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7992 (casify_region): Mark local as initialized.
181aa2be 7993
930d429c
PE
7994 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7995
7082eac6
PE
7996 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7997 New macros, so that the caller can use some names other than
7998 gcpro1, gcpro2, etc.
7999 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8000 of the new macros.
8001 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8002 argument, for consistency with GCPRO2_VAR, etc: it is now the
8003 prefix of the variable, not the variable itself. All uses
8004 changed.
38b2c076
PE
8005 * dired.c (directory_files_internal, file_name_completion):
8006 Rename locals to avoid shadowing.
8007
15206ed9
PE
8008 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8009 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8010 dired.c's scmp function, had undefined behavior.
8011 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8012 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8013 * buffer.h: ... to here, because these macros use current_buffer,
8014 and the new implementation with inline functions needs to have
8015 current_buffer in scope now, rather than later when the macros
8016 are used.
8017 (downcase, upcase1): New static inline functions.
8018 (DOWNCASE, UPCASE1): Reimplement using these functions.
8019 This avoids undefined behavior in expressions like
8020 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8021 from race conditions in accessing the global variables
8022 case_temp1 and case_temp2.
8023 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8024 * lisp.h (case_temp1, case_temp2): Remove their decls.
8025 * character.h (ASCII_CHAR_P): Move from here ...
8026 * lisp.h: ... to here, so that the inline functions mentioned
8027 above can use them.
8028
4a6bea26
PE
8029 * dired.c (directory_files_internal_unwind): Now static.
8030
f14b7e14
PE
8031 * fileio.c (file_name_as_directory, directory_file_name):
8032 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8033 Now static.
2893f146
PE
8034 (file_name_as_directory): Use const pointers when appropriate.
8035 (Fexpand_file_name): Likewise. In particular, newdir might
8036 point at constant storage, so make it a const pointer.
fd4ead52 8037 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8038 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8039 signedness issues.
f839df0c
PE
8040 (Fset_file_times, Finsert_file_contents, auto_save_error):
8041 Rename locals to avoid shadowing.
f14b7e14 8042
5716756e 8043 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8044 (Ftry_completion, Fall_completions): Rename or remove locals
8045 to avoid shadowing.
5716756e 8046
b4c3046a
PE
8047 * marker.c (bytepos_to_charpos): Remove; unused.
8048
b45db522
PE
8049 * lisp.h (verify_bytepos, count_markers): New decls,
8050 so that gcc does not warn that these functions aren't declared.
8051
85876d07
PE
8052 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8053 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8054 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8055 (copy_text): Remove unused local var.
85876d07 8056
03d78a21 8057 * filelock.c (within_one_second): Now static.
b3dd38ab 8058 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8059
5df8f01b
PE
8060 * buffer.c (fix_overlays_before): Mark locals as initialized.
8061 (fix_start_end_in_overlays): Likewise. This function should be
8062 simplified by using pointers-to-pointers, but that's a different
8063 matter.
b1d876f1 8064 (switch_to_buffer_1): Now static.
8f54f30a
PE
8065 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8066 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8067
a70072c9 8068 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8069 Fix pointer signedness issue.
edced198
PE
8070 (sys_subshell): Mark local as volatile if checking for lint,
8071 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8072 (MAXPATHLEN): Define only if needed.
a70072c9 8073
a0977c44
PE
8074 * process.c (serial_open, serial_configure): Move decls from here ...
8075 * systty.h: ... to here, so that they can be checked.
8076
a884fdcc
PE
8077 * fns.c (get_random, seed_random): Move extern decls from here ...
8078 * lisp.h: ... to here, so that they can be checked.
8079
604efe86 8080 * sysdep.c (reset_io): Now static.
b8950c94 8081 (wait_for_termination_signal): Remove; unused.
604efe86 8082
38fc62d9
PE
8083 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8084 (copy_keymap_item, append_key, push_text_char_description):
8085 Now static.
1004a21a 8086 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8087 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8088 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8089 (describe_map_tree):
8090 Rename locals to avoid shadowing.
38fc62d9 8091
2f2650da
PE
8092 * keyboard.c: Declare functions static if they are not used elsewhere.
8093 (echo_char, echo_dash, cmd_error, top_level_2):
8094 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8095 (read_char, kbd_buffer_get_event, make_lispy_position):
8096 (make_lispy_event, make_lispy_movement, apply_modifiers):
8097 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8098 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8099 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8100 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8101 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8102
a053e86c 8103 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8104 (mark_kboards): Move decl here ...
8105 * alloc.c (mark_kboards): ... from here.
a053e86c 8106
4752793e
PE
8107 * lisp.h (force_auto_save_soon): New decl.
8108
74f10ca7 8109 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8110 (DEFINE_DUMMY_FUNCTION): New macro.
8111 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8112 Use it.
c03cd23f
PE
8113 (main): Add casts to avoid warnings
8114 if GCC considers string literals to be constants.
74f10ca7 8115
022e70d4
PE
8116 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8117
59d6fe83
PE
8118 * dbusbind.c: Pointer signedness fixes.
8119 (xd_signature, xd_append_arg, xd_initialize):
8120 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8121 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8122 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8123 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8124
78320123
PE
8125 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8126 if GCC considers string literals to be constants.
49cebcca 8127 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8128
35ac2a97
SM
81292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8130
fb103ca9
SM
8131 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8132 (print_preprocess, print_object): New macro to fix last change.
8133
35ac2a97
SM
8134 * print.c (print_preprocess): Don't forget font objects.
8135
62973b41
JB
81362011-03-16 Juanma Barranquero <lekktu@gmail.com>
8137
8138 * emacs.c (USAGE3): Doc fixes.
8139
0e48bb22
AS
81402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8141
8142 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8143 structure.
8144
7684e57b
JB
81452011-03-14 Juanma Barranquero <lekktu@gmail.com>
8146
8147 * lisp.h (VWindow_system, Qfile_name_history):
8148 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8149 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8150 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8151
8152 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8153 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8154
8155 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8156 * w32console.c (detect_input_pending, read_input_pending)
8157 (encode_terminal_code):
8158 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8159 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8160 (w32_system_caret_y, Qfile_name_history):
8161 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8162 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8163 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8164 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8165 * w32proc.c (Qlocal, report_file_error):
8166 * w32term.c (Vwindow_system, updating_frame):
8167 * w32uniscribe.c (initialized, uniscribe_font_driver):
8168 Remove unneeded extern declarations.
8169
2aa46d6c
CY
81702011-03-14 Chong Yidong <cyd@stupidchicken.com>
8171
c96bbc66 8172 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8173
cffc6f3b
CY
81742011-03-13 Chong Yidong <cyd@stupidchicken.com>
8175
8176 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8177 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8178 These macros can no longer be used for assignment.
8179
44f230aa
SM
8180 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8181 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8182 (record_buffer_markers, fetch_buffer_markers): New functions for
8183 recording and fetching special buffer markers.
8184 (set_buffer_internal_1, set_buffer_temp): Use them.
8185
8186 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8187
8188 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8189
8190 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8191 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8192
8193 * xdisp.c (hscroll_window_tree):
8194 (reconsider_clip_changes): Use PT instead of BUF_PT.
8195
d251f04b
EZ
81962011-03-13 Eli Zaretskii <eliz@gnu.org>
8197
8198 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8199 $(EMACS_ROOT)/lib/intprops.h.
8200
f0c77cd1
PE
82012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8202
3eca4629
PE
8203 Fix more problems found by GCC 4.5.2's static checks.
8204
7c86ee98
PE
8205 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8206 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8207 (xg_free_frame_widgets): Make it clear that a local variable is
8208 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8209 (gdk_window_get_screen): Make it clear that this macro is needed
8210 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8211 (int_gtk_range_get_value): New function, which avoids a diagnostic
8212 from gcc -Wbad-function-cast.
8213 (xg_set_toolkit_scroll_bar_thumb): Use it.
8214 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8215 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8216 (get_utf8_string, xg_get_file_with_chooser):
8217 Rename locals to avoid shadowing.
8218 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8219
41729b81
PE
8220 * xgselect.c (xg_select): Remove unused var.
8221
f0c77cd1
PE
8222 * image.c (four_corners_best): Mark locals as initialized.
8223 (gif_load): Initialize transparent_p to zero (Bug#8238).
8224 Mark another local as initialized.
ec6cf4c6 8225 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8226
ce0ad53d 8227 * image.c (clear_image_cache): Now static.
d5d5a617 8228 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8229 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8230 (x_edge_detection): Remove unnecessary cast that
8231 gcc -Wbad-function-cast diagnoses.
2037898d 8232 (gif_load): Fix pointer signedness.
6ae141d6
PE
8233 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8234 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8235
33383987 82362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8237
d32df629
PE
8238 Improve quality of tests for time stamp overflow.
8239 For example, without this patch (encode-time 0 0 0 1 1
8240 1152921504606846976) returns the obviously-bogus value (-948597
8241 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8242 reports time overflow. See
8243 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8244 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8245 * editfns.c: Include limits.h and intprops.h.
8246 (TIME_T_MIN, TIME_T_MAX): New macros.
8247 (time_overflow): Move earlier, to before first use.
8248 (hi_time, lo_time): New functions, for an accurate test for
8249 out-of-range times.
8250 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8251 (Fget_internal_run_time): Don't assume time_t fits in int.
8252 (make_time): Use list2 instead of Fcons twice.
8253 (Fdecode_time): More accurate test for out-of-range times.
8254 (check_tm_member): New function.
8255 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8256 (lisp_time_argument): Don't rely on undefined left-shift and
8257 right-shift behavior when checking for time stamp overflow.
8be6f318 8258
fe31d94c
PE
8259 * editfns.c (time_overflow): New function, refactoring common code.
8260 (Fformat_time_string, Fdecode_time, Fencode_time):
8261 (Fcurrent_time_string): Use it.
8262
8be6f318
PE
8263 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8264 * dired.c (make_time): Move to ...
8265 * editfns.c (make_time): ... here.
8266 * systime.h: Note the move.
8267
09d9db2c 82682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8269
126bc0dc
YM
8270 * fringe.c (update_window_fringes): Remove unused variables.
8271
c47cbdfd
YM
8272 * unexmacosx.c (copy_data_segment): Also copy __got section.
8273 (Bug#8223)
8274
7ac80be9
EZ
82752011-03-12 Eli Zaretskii <eliz@gnu.org>
8276
c96bbc66 8277 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8278 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8279 Constify `char *' arguments and their references according to
8280 prototypes in tparam.h.
8281
ecb0f94d 8282 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8283
7ac80be9
EZ
8284 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8285 Adapt all references accordingly.
8286
8287 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8288
ef1fd07e
TT
82892011-03-11 Tom Tromey <tromey@redhat.com>
8290
8291 * buffer.c (syms_of_buffer): Remove obsolete comment.
8292
7ef4b50c
EZ
82932011-03-11 Eli Zaretskii <eliz@gnu.org>
8294
8295 * termhooks.h (encode_terminal_code): Declare prototype.
8296
8297 * msdos.c (encode_terminal_code): Don't declare prototype.
8298
8299 * term.c (encode_terminal_code): Now external again, used by
8300 w32console.c and msdos.c.
8301
44f230aa
SM
8302 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8303 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8304
4b1ec863 83052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8306
1714f52b 8307 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8308
4b1ec863
PE
8309 * fringe.c (update_window_fringes): Mark locals as initialized
8310 (Bug#8227).
8311 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8312
524c7aa6
PE
8313 * alloc.c (mark_fringe_data): Move decl from here ...
8314 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8315 to check its interface.
8316 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8317
a5c0af81 8318 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8319 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8320 (fontset_font): Mark local as initialized.
a9a06e0b 8321 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8322
b4716021
PE
8323 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8324
811e9bac 8325 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8326 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8327 (x_own_selection, Fx_disown_selection_internal): Rename locals
8328 to avoid shadowing.
8329 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8330
7e3ab302
PE
8331 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8332 so that the caller can use some name other than gcpro1.
8333 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8334 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8335 (Fx_backspace_delete_keys_p):
8336 Use them to avoid shadowing, and rename vars to avoid shadowing.
8337 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8338 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8339 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8340 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8341 Remove unused locals.
7e3ab302
PE
8342 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8343 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8344 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8345 macros.
f78faa98 8346
e2b13473
PE
8347 * xterm.h (x_mouse_leave): New decl.
8348
77f23912
PE
8349 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8350 Remove unused functions.
cdf4ba58
PE
8351 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8352 (x_calc_absolute_position): Now static.
7411c686 8353 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8354 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8355 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8356 unless they are used.
38d0b34a
PE
8357 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8358 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8359 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8360 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8361 (x_error_catcher, x_connection_closed, x_error_handler):
8362 (x_error_quitter, xembed_send_message, x_iconify_frame):
8363 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8364 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8365 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8366
44f230aa
SM
8367 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8368 Rename or move locals to avoid shadowing.
6b463e58 8369 (tty_defined_color, merge_face_heights): Now static.
5967d051 8370 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8371 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8372 does not deduce is never used uninitialized.
73719eba
PE
8373 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8374 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8375
426994c3 8376 * terminal.c (store_terminal_param): Now static.
5489860b 8377
032f1620 8378 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8379 (set_frame_menubar): Remove unused local.
d4323972 8380 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8381 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8382 since they might point to immutable storage.
281585b0
PE
8383 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8384 since it's unused otherwise.
032f1620 8385
367c19e5 8386 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8387 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8388 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8389 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8390 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8391 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8392 does not deduce are never used uninitialized.
70739cbe 8393
07b48fa9
PE
8394 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8395
8868a238 8396 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8397 * window.c (window_loop, size_window):
8398 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8399
7e5cf297 8400 * window.c (display_buffer): Now static.
d6550a9f
PE
8401 (size_window): Mark variables that gcc -Wuninitialized
8402 does not deduce are never used uninitialized.
a586633d
PE
8403 * window.h (check_all_windows): New decl, to forestall
8404 gcc -Wmissing-prototypes diagnostic.
5b555da1 8405 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8406
f6095868
PE
8407 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8408 shadowing.
8409 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8410 Include <limits.h>.
8411 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8412 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8413 (load_charset_map): Mark variables that gcc -Wuninitialized
8414 does not deduce are never used uninitialized.
53df7c11 8415 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8416
f38b440c
PE
8417 * coding.c (coding_set_source, coding_set_destination):
8418 Use "else { /* comment */ }" rather than "else /* comment */;"
8419 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8420 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8421 a block, when the outer 'i' will do.
8422 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8423 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8424 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8425 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8426 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8427 Rename locals to avoid shadowing.
8428 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8429 * coding.c (emacs_mule_char, encode_invocation_designation):
8430 Now static, since they're not used elsewhere.
413bb2db 8431 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8432 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8433 (decode_coding_emacs_mule): Mark variables that gcc
8434 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8435 (detect_coding_iso_2022): Initialize a local variable that might
8436 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8437 this initialization is needed. (Bug#8211)
5f58e762
PE
8438 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8439 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8440 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8441 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8442 Remove unused macros.
f38b440c 8443
232b38b9 8444 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8445 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8446 * character.c (string_count_byte8): Likewise.
232b38b9 8447
fb90da1b
PE
8448 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8449 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8450
fb93dbc2
PE
8451 * chartab.c (copy_sub_char_table): Now static, since it's not used
8452 elsewhere.
5c156ace
PE
8453 (sub_char_table_ref_and_range, char_table_ref_and_range):
8454 Rename locals to avoid shadowing.
bbcd0949 8455 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8456
7d3b3862 8457 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8458 (BIDI_BOB): Remove unused macro.
7d3b3862 8459
6be7d3da
PE
8460 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8461 deduce are never used uninitialized.
c2ed9c8b 8462 * term.c (encode_terminal_code): Likewise.
6be7d3da 8463
75f8807f 8464 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8465
50938595
PE
8466 * tparam.h: New file.
8467 * term.c, tparam.h: Include it.
8468 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8469 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8470 Move these decls to tparam.h, and make them agree with what
8471 is actually in tparam.c. The previous trick of using incompatible
8472 decls in different modules does not conform to the C standard.
8473 All callers of tparam changed to use tparam's actual API.
8474 * tparam.c (tparam1, tparam, tgoto):
8475 Use const pointers where appropriate.
8476
fbceeba2
PE
8477 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8478 * cm.h (struct cm): Likewise.
8479 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8480 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8481 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8482 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8483 (turn_on_face, init_tty): Likewise.
8484 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8485
7f3f1250
PE
8486 * term.c (term_mouse_position): Rename local to avoid shadowing.
8487
e6ca6543
PE
8488 * alloc.c (mark_ttys): Move decl from here ...
8489 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8490
c40f8d15
AS
84912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8492
8493 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8494
cfe0661d
JB
84952011-03-09 Juanma Barranquero <lekktu@gmail.com>
8496
8497 * search.c (compile_pattern_1): Remove argument regp, unused since
8498 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8499 (compile_pattern): Don't pass it.
8500
0afb4571
J
85012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8502
8503 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8504 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8505 for ! HAVE_GTK3.
8506 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8507
8508 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8509
8510 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8511 gdk_window_get_screen, gdk_window_get_geometry,
8512 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8513 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8514 (xg_get_pixbuf_from_pixmap): New function.
8515 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8516 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8517 Call xg_get_pixbuf_from_pixmap instead of
8518 gdk_pixbuf_get_from_drawable.
8519 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8520 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8521 (xg_check_special_colors): Use GtkStyleContext and its functions
8522 for HAVE_GTK3.
8523 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8524 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8525 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8526 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8527 Call gtk_widget_get_preferred_size.
0afb4571
J
8528 (xg_frame_resized): gdk_window_get_geometry only takes 5
8529 parameters.
44f230aa
SM
8530 (xg_win_to_widget, xg_event_is_for_menubar):
8531 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8532 (xg_set_widget_bg): New function.
8533 (delete_cb): New function.
895009e1 8534 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8535 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8536 (xg_set_background_color): Call xg_set_widget_bg.
8537 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8538 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8539 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8540 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8541 if ! HAVE_GTK3.
8542 (update_frame_tool_bar): Call gtk_widget_hide.
8543 (xg_initialize): Use GDK_KEY_g.
8544
8545 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8546 if ! HAVE_GTK3
8547 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8548
8549 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8550 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8551 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8552
1c2cc4ef
JB
85532011-03-08 Juanma Barranquero <lekktu@gmail.com>
8554
8555 * w32xfns.c (select_palette): Check success of RealizePalette against
8556 GDI_ERROR, not zero.
8557
33383987 8558See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8559
8560;; Local Variables:
8561;; coding: utf-8
aac0c6e3
MR
8562;; End:
8563
33383987 8564 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8565
8566 This file is part of GNU Emacs.
8567
8568 GNU Emacs is free software: you can redistribute it and/or modify
8569 it under the terms of the GNU General Public License as published by
8570 the Free Software Foundation, either version 3 of the License, or
8571 (at your option) any later version.
8572
8573 GNU Emacs is distributed in the hope that it will be useful,
8574 but WITHOUT ANY WARRANTY; without even the implied warranty of
8575 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8576 GNU General Public License for more details.
8577
8578 You should have received a copy of the GNU General Public License
8579 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.