sprintf-related integer and memory overflow issues.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
62f19c19
PE
12011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 sprintf-related integer and memory overflow issues.
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
5fc295a4 232011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 24
70c60eb2 25 Integer and memory overflow issues (Bug#9196).
726e0ab1 26
d31850da
PE
27 * doc.c (get_doc_string): Rework so that
28 get_doc_string_buffer_size is the actual buffer size, rather than
29 being 1 less than the actual buffer size; this makes xpalloc more
30 convenient.
31
a69fbedb
PE
32 * image.c (x_allocate_bitmap_record, cache_image):
33 * xselect.c (Fx_register_dnd_atom):
34 Simplify previous changes by using xpalloc.
35
fe5c5d37
PE
36 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
37 since either will do and ptrdiff_t is convenient with xpalloc.
38
0065d054
PE
39 * charset.c (charset_table_size)
40 (struct charset_sort_data.priority): Now ptrdiff_t.
41 (charset_compare): Don't overflow if priorities differ greatly.
42 (Fsort_charsets): Don't assume list length fits in int.
43 Check for size-calculation overflow when allocating sort data.
44 (syms_of_charset): Allocate an initial charset table that is
45 just under 64 KiB, to avoid problems with glibc malloc and mmap.
46
47 * cmds.c (internal_self_insert): Check for size-calculation overflow.
48
49 * composite.h (struct composition.glyph_len): Now int, not unsigned.
50 The actual value is always <= INT_MAX, and leaving it unsigned made
51 overflow checking harder.
52
53 * dispextern.h (struct glyph_matrix.rows_allocated)
54 (struct face_cache.size): Now ptrdiff_t, for convenience in use
55 with xpalloc. The values are still always <= INT_MAX.
56
57 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
58
59 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
60 (SAFE_NALLOCA): New macro.
61
62 * region-cache.c (struct boundary.pos, find_cache_boundary)
63 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
64 (set_cache_region, invalidate_region_cache)
65 (revalidate_region_cache, know_region_cache, region_cache_forward)
66 (region_cache_backward, pp_cache):
67 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
68 so that ptrdiff_t * can be passed to xpalloc.
69 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
70 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
71 (pp_cache): Don't assume cache_len fits in int.
72 * region-cache.h: Adjust extern decls to match.
73
74 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
75 EMACS_INT, since either will do, for xpalloc.
76
77 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
78 (xnmalloc, xnrealloc, xpalloc): New functions.
79
726e0ab1
PE
80 * bidi.c (bidi_shelve_header_size): New constant.
81 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
82 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
83
51f30bc5 84 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
85 * buffer.c (overlays_at, overlays_in, record_overlay_string)
86 (overlay_strings):
87 Don't update size of array until after memory allocation succeeds,
88 because xmalloc/xrealloc may not return.
0065d054
PE
89 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
90 now that we have proper integer overflow checking.
91 (record_overlay_string, overlay_strings): Catch overflows when
92 calculating size of overlay_str_buf.
726e0ab1 93
0065d054
PE
94 * callproc.c (Fcall_process): Check for size overflow when
95 calculating size of args2.
96 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
97 Normally we prefer signed values, but sticking with ptrdiff_t would
98 require adding more-complicated checks.
726e0ab1
PE
99
100 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
101 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
102 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 103 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
104
105 * character.c (Fstring): Check for size-calculation overflow.
106
107 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
108 unnecessary integer overflow. Check for size overflow.
109 (encode_coding_object): Don't update size until xmalloc succeeds.
110
111 * composite.c (get_composition_id): Check for overflow in glyph
112 length calculations.
113
114 Integer and memory overflow fixes for display code.
115 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
116 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
117 (scrolling_window): Check for overflow in size calculations.
118 (line_draw_cost, realloc_glyph_pool, add_row_entry):
119 Don't assume glyph table len fits in int.
120 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
121 (row_table_size): Now ptrdiff_t, not int.
122 (scrolling_window): Avoid overflow in size calculations.
123 Don't update size until allocation succeeds.
124 * fns.c (concat): Check for overflow in size calculations.
125 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
126 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
127 (NEXT_ALMOST_PRIME_LIMIT): New constant.
128
129 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
130 (get_doc_string): Check for size calculation overflow.
131 Don't update size until allocation succeeds.
132 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
133 EMACS_INT, where ptrdiff_t will do.
134 (Fsubstitute_command_keys): Check for string overflow.
135
136 * editfns.c (set_time_zone_rule): Don't assume environment length
137 fits in int.
138 (message_length): Now ptrdiff_t, not int.
139 (Fmessage_box): Don't update size until allocation succeeds.
140 Don't assume message length fits in int.
141 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
142
0065d054
PE
143 * emacs.c (main): Do not reallocate argv, since there is a null at
144 the end that can be overwritten, and this way there's no need to
145 worry about size-calculation overflow.
146 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
147
148 * eval.c (init_eval_once, grow_specpdl): Don't update size until
149 alloc succeeds.
150 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
151
152 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
153 (x_set_scroll_bar_width, x_figure_window_size):
154 Check for integer overflow.
155 (x_set_alpha): Do not assume XINT fits in int.
156
157 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
158 This is for the members text_lines, text_cols, total_lines, total_cols,
159 where the system imposes an 'int' limit.
160
161 * fringe.c (Fdefine_fringe_bitmap):
162 Don't update size until alloc works.
163
164 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
165 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
166
167 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
168 Check for size-calculation overflow.
169 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
170 do, as we prefer signed integers.
171 (id_to_widget.max_size, id_to_widget.used)
172 (xg_store_widget_in_map, xg_remove_widget_from_map)
173 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
174 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
175 Use and return ptrdiff_t, not int.
176 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
177 * gtkutil.h: Change prototypes to match the above.
178
179 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
180 are duplicate now that they've been promoted to lisp.h.
181 (x_allocate_bitmap_record, x_alloc_image_color)
182 (make_image_cache, cache_image, xpm_load):
183 Don't update size until alloc is done.
184 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
185 (x_detect_edges):
3256efce 186 Check for size calculation overflow.
726e0ab1
PE
187 (ct_colors_allocated_max): New constant.
188 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
189 overflow.
3256efce 190
726e0ab1
PE
191 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
192 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
193 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
194 Use ptrdiff_t, not int, to count maps.
195 (read_char_minibuf_menu_prompt): Check for overflow in size
196 calculations. Don't update size until allocation succeeds. Redo
197 calculations to avoid overflow.
198 * keyboard.h: Change prototypes to match the above.
199
200 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
201 to count maps.
202 (current_minor_maps): Check for size calculation overflow.
203 * keymap.h: Change prototypes to match the above.
204
205 * lread.c (read1, init_obarray): Don't update size until alloc done.
206
207 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
208 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
209
726e0ab1
PE
210 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
211 Now ptrdiff_t, not int.
212 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
213 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
214
215 * process.c (Fnetwork_interface_list): Check for overflow
216 in size calculation.
217
218 * region-cache.c (move_cache_gap): Check for size calculation overflow.
219
220 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
221 overflow. Don't bother calling xmalloc when xrealloc will do.
222
223 * search.c (Freplace_match): Check for size calculation overflow.
224 (Fset_match_data): Don't assume list lengths fit in 'int'.
225
226 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
227 for command line length. Do not attempt to address one before the
228 beginning of an array, as that's not portable.
229
230 * term.c (max_frame_lines): Remove; unused.
231 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
232 not int.
233 (encode_terminal_code, calculate_costs): Check for size
234 calculation overflow.
235 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
236 table lengths and related sizes. Don't update size until alloc
237 done. Redo calculations to avoid overflow.
238 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
239
240 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
241 subtracting pointers.
242 (gobble_line): Check for overflow more carefully. Don't update size
243 until alloc done.
244
245 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
246 Don't update size until alloc done.
247 Redo size calculations to avoid overflow.
248 Check for size calculation overflow.
0065d054 249 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
250
251 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
252 Use ptrdiff_t, not int, for sizes.
253 (store_mode_line_noprop_char): Don't update size until alloc done.
254
0065d054
PE
255 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
256 Use ptrdiff_t, not int, for sizes.
257 (Finternal_make_lisp_face, cache_face):
258 Check for size calculation overflow.
259 (cache_face): Treat size calculation overflows as if they were
260 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
261
262 * xfns.c (x_encode_text, x_set_name_internal)
263 (Fx_change_window_property): Use ptrdiff_t, not int, to count
264 sizes, since they can exceed INT_MAX in size. Check for size
265 calculation overflow.
266
0065d054
PE
267 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
268 (xg_select): Check for size calculation overflow.
726e0ab1
PE
269 Don't update size until alloc done.
270
0065d054 271 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 272 as sprintf is limited to int lengths.
1d526e2f 273
252c5ee1
PE
274 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
275 (X_LONG_MIN): New macros.
864d7ce7
PE
276 Use them to make the following changes clearer.
277 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
278 This change doesn't affect the value now, but it may help remind
279 future maintainers not to raise the value too much later.
280 (SELECTION_QUANTUM): Remove, replacing with ...
281 (selection_quantum): ... new function, which avoids overflow.
282 All uses changed.
283 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
284 assumption that selection length fits in 'int'.
285 (x_reply_selection_request, x_handle_selection_request)
286 (x_get_window_property, receive_incremental_selection)
287 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
288 (lisp_data_to_selection_data, clean_local_selection_data):
289 Use ptrdiff_t, not int, to record length of selection.
290 (x_reply_selection_request, x_get_window_property)
291 (receive_incremental_selection, x_property_data_to_lisp):
292 Redo calculations to avoid overflow.
293 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 294 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
295 something.
296 (x_get_window_property, receive_incremental_selection)
297 (lisp_data_to_selection_data, x_property_data_to_lisp):
298 Check for size-calculation overflow.
299 (x_get_window_property, receive_incremental_selection)
300 (lisp_data_to_selection_data, Fx_register_dnd_atom):
301 Don't store size until memory allocation succeeds.
302 (x_get_window_property): Plug memory leak on memory exhaustion.
303 Don't double-block input; malloc is safe here. Don't assume 2**34
304 - 4 fits in unsigned long. Add an xassert to check
305 XGetWindowProperty overflow. Be more careful about overflow
306 calculations, and distinguish size from memory overflow better.
307 (receive_incremental_selection): When tracing, don't assume
308 unsigned int is less than INT_MAX.
309 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
310 harmful) conversions of unsigned short to int.
311 (lisp_data_to_selection_data): Don't assume that integers
312 in the range -65535 through -1 fit in an X unsigned short.
313 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
314 result parameters unless successful. Rely on cons_to_unsigned
315 to report problems with elements; the old code wasn't right anyway.
316 (x_check_property_data): Check for int overflow; we cannot use
317 a wider type due to X limits.
318 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
319
726e0ab1 320 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 321
0065d054
PE
322 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
323 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
324 (x_color_cells): Don't store size until memory allocation succeeds.
325 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 326 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
327 (x_term_init): Don't assume length fits in int (sprintf is limited
328 to int size).
bc18e09d 329
ebfa62c0
PE
330 Use ptrdiff_t for composition IDs.
331 * character.c (lisp_string_width):
332 * composite.c (composition_table_size, n_compositions)
333 (get_composition_id, composition_gstring_from_id):
334 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
335 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
336 * window.c (Frecenter):
337 Use ptrdiff_t, not int, for composition IDs.
338 * composite.c (get_composition_id): Check for integer overflow.
339 * composite.h: Adjust prototypes to match the above changes.
340
d3411f89
PE
341 Use ptrdiff_t for hash table indexes.
342 * category.c (hash_get_category_set):
343 * ccl.c (ccl_driver):
344 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
345 * coding.c (coding_system_charset_list, detect_coding_system):
346 * coding.h (struct coding_system.id):
347 * composite.c (get_composition_id, gstring_lookup_cache):
348 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
349 * image.c (xpm_get_color_table_h):
350 * lisp.h (hash_lookup, hash_put):
351 * minibuf.c (Ftest_completion):
352 Use ptrdiff_t for hash table indexes, not int (which is too
353 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
354 32-bit --with-wide-int hosts).
355
e097a6fa
PE
356 * charset.c (Fdefine_charset_internal): Check for integer overflow.
357 Add a FIXME comment about memory leaks.
358 (syms_of_charset): Don't assume xmalloc returns.
359
5637687f
PE
360 Don't assume that stated character widths fit in int.
361 * character.c (Fchar_width, c_string_width, lisp_string_width):
362 * character.h (CHAR_WIDTH):
363 * indent.c (MULTIBYTE_BYTES_WIDTH):
364 Use sanitize_char_width to avoid undefined and/or bad behavior
365 with outlandish widths.
366 * character.h (sanitize_tab_width): Renamed from sanitize_width,
367 now that we have two such functions. All uses changed.
368 (sanitize_char_width): New inline function.
369
a2271ba2
PE
370 Don't assume that tab-width fits in int.
371 * character.h (sanitize_width): New inline function.
372 (SANE_TAB_WIDTH): New macro.
373 (ASCII_CHAR_WIDTH): Use it.
374 * indent.c (sane_tab_width): Remove. All uses replaced by
375 SANE_TAB_WIDTH (current_buffer).
376 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
377
18c52557
PE
378 * fileio.c: Integer overflow issues with file modes.
379 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
380
caeeedc1
PE
381 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
382 Remove unreachable code.
383 (read_hex, load_charset_map_from_file): Check for integer overflow.
384
50849c52
PE
385 * xterm.c: don't go over XClientMessageEvent limit
386 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
387 (x_send_scroll_bar_event): Likewise. Check that the size does not
388 exceed limits imposed by XClientMessageEvent, as well as the usual
389 ptrdiff_t and size_t limits.
390
b13995db
PE
391 * keyboard.c: Overflow, signedness and related fixes.
392 (make_lispy_movement): Use same integer type in forward decl
393 that is used in the definition.
394 (read_key_sequence, keyremap_step):
395 Change bufsize argument back to int, undoing my 2011-03-30 change.
396 We prefer signed types, and int is wide enough here.
397 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
398 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
399 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
400 length, not size_t. Use ptrdiff_t for index, not int.
401 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
402 possibility of integer overflow.
403
13464394
PE
404 Overflow, signedness and related fixes for images.
405
406 * dispextern.h (struct it.stack[0].u.image.image_id)
407 (struct_it.image_id, struct image.id, struct image_cache.size)
408 (struct image_cache.used, struct image_cache.ref_count):
409 * gtkutil.c (update_frame_tool_bar):
410 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
411 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
412 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
413 * nsmenu.m (update_frame_tool_bar):
414 * xdisp.c (calc_pixel_width_or_height):
415 * xfns.c (image_cache_refcount):
416 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
417 on typical 64-bit hosts.
418
419 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
420 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
421 Omit unnecessary casts to int.
422 (parse_image_spec): Check that integers fall into 'int' range
423 when the callers expect that.
424 (image_ascent): Redo ascent calculation to avoid int overflow.
425 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
426 (lookup_image): Remove unnecessary tests.
427 (xbm_image_p): Locals are now of int, not EMACS_INT,
428 since parse_image_check makes sure they fit into int.
429 (png_load, gif_load, svg_load_image):
430 Prefer int to unsigned where either will do.
431 (tiff_handler): New function, combining the cores of the
432 old tiff_error_handler and tiff_warning_handler. This
433 function is rewritten to use vsnprintf and thereby avoid
434 stack buffer overflows. It uses only the features of vsnprintf
435 that are common to both POSIX and native Microsoft.
436 (tiff_error_handler, tiff_warning_handler): Use it.
437 (tiff_load, gif_load, imagemagick_load_image):
438 Don't assume :index value fits in 'int'.
439 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
440 (imagemagick_load_image): Check that crop parameters fit into
441 the integer types that MagickCropImage accepts. Don't assume
442 Vimagemagick_render_type has a nonnegative value. Don't assume
443 size_t fits in 'long'.
444 (gs_load): Use printmax_t to print the widest integers possible.
445 Check for integer overflow when computing image height and width.
446
c11821d4
EZ
4472011-08-26 Eli Zaretskii <eliz@gnu.org>
448
449 * xdisp.c (redisplay_window): Don't force window start if point
450 will be invisible in the resulting window. (Bug#9324)
451
0c95fcf7
EZ
4522011-08-25 Eli Zaretskii <eliz@gnu.org>
453
454 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
455 the display spec is of the form `(space ...)'.
456 (handle_display_spec): Return the value returned by
457 handle_single_display_spec, not just 1 or zero.
458 (handle_single_display_spec): If the display spec is of the form
459 `(space ...)', and specifies display in the text area, return 2
460 rather than 1.
fee65a97 461 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
462 accurately, and prefer exact match for point under bidi. Don't
463 advance `row' beyond the last row of the window.
0c95fcf7
EZ
464
465 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
466 into disp_prop; all users changed.
467
468 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
469 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
470 for the text covered by the display property.
471
e4ed06f1
CY
4722011-08-25 Chong Yidong <cyd@stupidchicken.com>
473
474 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
475 Change return value to nil.
476 (Frecord_buffer): Delete unused function.
477
f67cdd7f
EZ
4782011-08-24 Eli Zaretskii <eliz@gnu.org>
479
5980d4c6
EZ
480 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
481 buffers, return left-to-right.
8610fe8b
EZ
482 (set_cursor_from_row): Consider candidate row a win if its glyph
483 represents a newline and point is on that newline. Fixes cursor
484 positioning on the newline at EOL of R2L text within L2R
485 paragraph, and vice versa.
486 (try_cursor_movement): Check continued rows, in addition to
487 continuation rows. Fixes unwarranted scroll when point enters a
488 continued line of R2L text within an L2R paragraph, or vice versa.
489 (cursor_row_p): Consider the case of point being equal to
490 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
491 from the end of a short line to the beginning of a continued line
492 of R2L text within L2R paragraph.
493 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
494 composed characters.
5980d4c6 495
f67cdd7f
EZ
496 * bidi.c (bidi_check_type): Use xassert.
497 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
498 members.
499
bca633fb
EZ
5002011-08-23 Eli Zaretskii <eliz@gnu.org>
501
502 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
503 a character.
504
4a5885a7
CY
5052011-08-23 Chong Yidong <cyd@stupidchicken.com>
506
507 * nsfont.m (ns_otf_to_script): Fix typo.
508
0902a04e
KH
5092011-08-22 Kenichi Handa <handa@m17n.org>
510
511 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
512 extra slot even if the purpose is char-code-property-table.
513
1a2e6670
EZ
5142011-08-23 Eli Zaretskii <eliz@gnu.org>
515
8ddde651
EZ
516 * xdisp.c (redisplay_window): When computing centering_position,
517 account for the height of the header line. (Bug#8874)
518
425cc014
EZ
519 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
520 instead of CHAR_TO_BYTE. Fixes a crash when a completion
521 candidate is selected by the mouse, and that candidate has a
522 composed character under the mouse.
523
1a2e6670
EZ
524 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
525 coordinates reported by pos-visible-in-window-p for a composed
526 character in column zero.
527
8b76d6f8
SM
5282011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
529
530 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
531
dac347dd
EZ
5322011-08-22 Eli Zaretskii <eliz@gnu.org>
533
534 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
535 consider it a hit if to_charpos is anywhere in the range of the
536 composed buffer positions.
537
e013fb34
CY
5382011-08-22 Chong Yidong <cyd@stupidchicken.com>
539
540 * image.c (gif_load): Don't assume that each subimage has the same
541 dimensions as the base image. Handle disposal method that is
542 "undefined" by the gif spec (Bug#9335).
543
bd1ba3e8
CY
5442011-08-20 Chong Yidong <cyd@stupidchicken.com>
545
546 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 547 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 548
54a1215b
EZ
5492011-08-19 Eli Zaretskii <eliz@gnu.org>
550
823564e5
EZ
551 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
552 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
553 from an Org mode buffer to a Speedbar frame.
554
54a1215b
EZ
555 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
556 a composition, take its buffer position from IT->cmp_it.charpos.
557 Fixes cursor positioning at the beginning of a line that begins
558 with a composed character.
559
9778ebcc
EZ
5602011-08-18 Eli Zaretskii <eliz@gnu.org>
561
0be6ee06
EZ
562 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
563 character bidirectional type, use STRONG_L instead. Fixes crashes
564 in a buffer produced by `describe-categories'.
565
9778ebcc
EZ
566 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
567 members before the level stack, so they would be saved and
568 restored when copying iterator state. Fixes incorrect reordering
569 around TABs covered by display properties.
570
156bffbe
AS
5712011-08-18 Andreas Schwab <schwab@linux-m68k.org>
572
573 * process.c (Fnetwork_interface_list): Correctly determine buffer
574 size.
575
72ad093b
CY
5762011-08-17 Chong Yidong <cyd@stupidchicken.com>
577
578 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
579 (internal_condition_case_2, internal_condition_case_n):
580 Remove unnecessary aborts (Bug#9081).
72ad093b 581
35774242
EZ
5822011-08-17 Eli Zaretskii <eliz@gnu.org>
583
584 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
585 has no `load' handler, try opening the file locally. (Bug#9311)
586
db76dd85
KB
5872011-08-16 Ken Brown <kbrown@cornell.edu>
588
589 * gmalloc.c: Expand comment.
590
b215eee5
EZ
5912011-08-16 Eli Zaretskii <eliz@gnu.org>
592
593 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
594 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
595
a4579d33
KB
5962011-08-16 Ken Brown <kbrown@cornell.edu>
597
598 Fix memory allocation problems in Cygwin build (Bug#9273).
599
600 * unexcw.c ( __malloc_initialized): Declare external variable.
601 (fixup_executable): Force the dumped emacs to reinitialize malloc.
602
8b76d6f8
SM
603 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
604 New variables.
a4579d33
KB
605 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
606 dumped emacs.
607 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
608 in the static heap.
609 [CYGWIN] (special_realloc): New function.
610 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
611 requests to realloc storage in the static heap.
612
3ebec551
PE
6132011-08-15 Paul Eggert <eggert@cs.ucla.edu>
614
615 * bidi.c (bidi_initialize): Remove unused local.
616
9fd8be00
EZ
6172011-08-15 Eli Zaretskii <eliz@gnu.org>
618
474a8465
EZ
619 * biditype.h: File removed.
620
621 * bidimirror.h: File removed.
622
623 * deps.mk (bidi.o): Remove biditype.h and
624 bidimirror.h.
625
626 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
627 bidimirror.h.
628
629 * dispextern.h: Fix a typo in the comment to bidi_type_t.
630
631 * chartab.c: Improve commentary for the uniprop_table API.
632
32413314
EZ
633 * bidi.c (bidi_paragraph_init): Support zero value of
634 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
635 (bidi_initialize): Use uniprop_table instead of including
636 biditype.h and bidimirror.h.
32413314 637
9fd8be00
EZ
638 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
639 coordinates of the iterator when restoring from ppos_it.
640 (Bug#9296)
641
5cf2b69b
KH
6422011-08-14 Kenichi Handa <handa@m17n.org>
643
644 * process.c (create_process): Call setup_process_coding_systems
72ad093b 645 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 646
daf17d00
EZ
6472011-08-14 Eli Zaretskii <eliz@gnu.org>
648
649 * xdisp.c (move_it_in_display_line_to): Don't invoke
650 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
651 ppos_it. Fixes vertical cursor motion when line beginning is
652 covered by an image. (Bug#9296)
653
08e3161a
JD
6542011-08-14 Jan Djärv <jan.h.d@swipnet.se>
655
656 * nsterm.h (ns_run_ascript): Declare.
657 (NSAPP_DATA2_RUNASSCRIPT): Define.
658
659 * nsfns.m (as_script, as_result, as_status): New static variables.
660 (ns_run_ascript): New function.
661 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
662 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
663 the event loop. Get status from as_status (Bug#7276).
664
665 * nsterm.m (sendEvent): If event is NSApplicationDefined and
666 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
667 the event loop (Bug#7276).
668
a3720aa2
AS
6692011-08-14 Andreas Schwab <schwab@linux-m68k.org>
670
671 * gnutls.c (QCgnutls_bootprop_priority)
672 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
673 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
674 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
675 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
676 (QCgnutls_bootprop_verify_hostname_error)
677 (QCgnutls_bootprop_callbacks_verify): Rename from
678 Qgnutls_bootprop_..., all uses changed.
679
680 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
681 uses changed.
682
0a0d27fb
PE
6832011-08-14 Paul Eggert <eggert@cs.ucla.edu>
684
19d5c50c
PE
685 * xfaces.c (Qframe_set_background_mode): Now static.
686 * dispextern.h (Qframe_set_background_mode): Remove decl.
687
0a0d27fb
PE
688 * process.c (Fnetwork_interface_info): Declare local only if needed.
689
377538cb
JD
6902011-08-13 Jan Djärv <jan.h.d@swipnet.se>
691
692 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
693 (Fnetwork_interface_list): Allocate in increments of bytes instead
694 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
695 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
696 sockaddr.
697 (struct ifflag_def): notrailers is smart on OSX.
698 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
699 Get hardware address with getifaddrs if available.
700
08fff70c
EZ
7012011-08-12 Eli Zaretskii <eliz@gnu.org>
702
703 * xdisp.c (iterate_out_of_display_property): xassert that
704 IT->position is set to within IT->object's boundaries. Break from
705 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
706 when IT->position is set up wrongly due to some bug.
707 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
708 (push_display_prop): Allow GET_FROM_STRING as IT->method on
709 entry. Force push_it to save on the stack the current
710 buffer/string position, to be restored by pop_it. Fix flags in
711 the iterator structure wrt the object coming from a display
712 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
713 properties. (Bug#9284)
714
7be1c708 7152011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 716
7be1c708
CY
717 * fontset.c (fontset_get_font_group): Add proper type checks.
718 (Bug#9172)
aac0c6e3 719
7be1c708 7202011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 721
7be1c708
CY
722 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
723 and LC_VERSION_MIN_MACOSX.
724 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
725 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 726
97bb72a6
EZ
7272011-08-08 Eli Zaretskii <eliz@gnu.org>
728
729 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
730 no-display-properties-and-no-overlays under bidi display.
731 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 732 properties and overlays.
97bb72a6 733
d5617611
CY
7342011-08-08 Chong Yidong <cyd@stupidchicken.com>
735
37e11a63
CY
736 * editfns.c (Fset_time_zone_rule): Document relationship with the
737 setenv function.
738
d5617611
CY
739 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
740 the font entity extracted from the cache (Bug#8109).
741
58872834
CY
7422011-08-07 Chong Yidong <cyd@stupidchicken.com>
743
744 * composite.c (autocmp_chars): Don't reset point. That is done by
745 restore_point_unwind (Bug#5984).
746
75bfc667
JL
7472011-08-07 Juri Linkov <juri@jurta.org>
748
749 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
750 to show the arg `TIME' instead of `TIMEVAL'.
751
d1410150
EZ
7522011-08-06 Eli Zaretskii <eliz@gnu.org>
753
754 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
755 display property strides EOL and includes a newline, as in
756 longlines-mode. (Bug#9254)
75b771e4
EZ
757 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
758 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
759
760 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
761 is non-zero, even if the data buffer is NULL. Fixes a crash in
762 vertical-motion with longlines-mode. (Bug#9254)
763
35928349
EZ
7642011-08-05 Eli Zaretskii <eliz@gnu.org>
765
ec7cc85b
EZ
766 * bidi.c <bidi_cache_total_alloc>: Now static.
767 (bidi_initialize): Initialize bidi_cache_total_alloc.
768
8b76d6f8 769 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
770 cache. (Bug#9221)
771
772 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
773 amount allocated this far in `bidi_cache_total_alloc'.
774 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
775 non-zero, only free the data buffer without restoring the cache
776 contents. All callers changed.
777
778 * dispextern.h (bidi_unshelve_cache): Update prototype.
779
780 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
781 (move_it_in_display_line, move_it_to)
782 (move_it_vertically_backward, move_it_by_lines): Replace the call
783 to xfree to an equivalent call to bidi_unshelve_cache.
784 (move_it_in_display_line_to): Fix logic of returning
412b6358 785 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 786
e2e2423b
EZ
7872011-08-05 Eli Zaretskii <eliz@gnu.org>
788
789 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
790 came from a string character with a `cursor' property. (Bug#9229)
791
ae9e757a
JD
7922011-08-04 Jan Djärv <jan.h.d@swipnet.se>
793
794 * Makefile.in (LIB_PTHREAD): New variable.
795 (LIBES): Add LIB_PTHREAD (Bug#9216).
796
797 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
798 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
799
213bd7f2
AS
8002011-08-04 Andreas Schwab <schwab@linux-m68k.org>
801
802 * regex.c (re_iswctype): Remove some redundant boolean
803 conversions.
804
99aaf75f
JD
8052011-08-04 Jan Djärv <jan.h.d@swipnet.se>
806
807 * xterm.c (x_find_topmost_parent): New function.
808 (x_set_frame_alpha): Find topmost parent window with
809 x_find_topmost_parent and set the property there also (bug#9181).
810 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
811
c74e9d86
PE
8122011-08-04 Paul Eggert <eggert@cs.ucla.edu>
813
814 * callproc.c (Fcall_process): Avoid vfork clobbering
815 the local vars buffer, coding_systems, current_dir.
816
640c8776
SM
8172011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
818
819 * keymap.c (Fmake_composed_keymap): Move to subr.el.
820
f26d0e4c
PE
8212011-08-03 Paul Eggert <eggert@cs.ucla.edu>
822
8a10d76c
PE
823 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
824 so that it is not optimized away.
825
f26d0e4c
PE
826 * xdisp.c (compute_display_string_pos): Remove unused local.
827
55439c61
EZ
8282011-08-02 Eli Zaretskii <eliz@gnu.org>
829
830 Fix slow cursor motion and scrolling in large buffers with
831 selective display, like Org Mode buffers. (Bug#9218)
832
833 * dispextern.h (struct bidi_it): New member disp_prop_p.
834
835 * xdisp.c: Remove one-slot cache of display string positions.
836 (compute_display_string_pos): Accept an additional argument
837 DISP_PROP_P; callers changed. Scan at most 5K characters forward
838 for a display string or property. If found, set DISP_PROP_P
839 non-zero.
840
841 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
842 DISP_PROP_P, and pass it to compute_display_string_pos.
843 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
844 non-zero. All callers of bidi_fetch_char changed.
845
fb33fa43
SM
8462011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
847
848 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
849
b099e063
DM
8502010-12-03 Don March <don@ohspite.net>
851
852 * keymap.c (Fdefine_key): Fix non-prefix key error message when
853 last character M-[char] is translated to ESC [char] (bug#7541).
854
5cc7f7af
KH
8552011-08-02 Kenichi Handa <handa@m17n.org>
856
d0fffa3f 857 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
858
859 * chartab.c (uniprop_table): Make it non-static.
860
525d5e6e
EZ
8612011-08-01 Eli Zaretskii <eliz@gnu.org>
862
863 * xdisp.c (forward_to_next_line_start): Accept additional argument
864 BIDI_IT_PREV, and store into it the state of the bidi iterator had
865 on the newline.
866 (reseat_at_next_visible_line_start): Use the bidi iterator state
867 returned by forward_to_next_line_start to restore the state of
868 it->bidi_it after backing up to previous newline. (Bug#9212)
869
31011111
AS
8702011-07-30 Andreas Schwab <schwab@linux-m68k.org>
871
872 * regex.c (re_comp): Protoize.
873 (re_exec): Fix return type.
874 (regexec): Fix type of `ret'. (Bug#9203)
875
e5d76069
PE
8762011-07-29 Paul Eggert <eggert@cs.ucla.edu>
877
878 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
879 This is needed if max-image-size is a floating-point number.
880
9a79b20c
AS
8812011-07-28 Andreas Schwab <schwab@linux-m68k.org>
882
883 * print.c (print_object): Print empty symbol as ##.
884
885 * lread.c (read1): Read ## as empty symbol.
886
d8c2fa78
AA
8872011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
888
889 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
890 setting frame foreground color (Bug#9175).
891 (x_set_background_color): Likewise.
892
ffe57a7a
AA
893 * nsmenu.m (-setText): Size tooltip dimensions precisely to
894 contents (Bug#9176).
895 (EmacsTooltip -init): Remove bezels and add shadows to
896 tooltip windows.
897
bf3492a5
AA
898 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
899 or scroll bar (Bug#8470).
900
d55e9c53
AA
901 * nsfont.m (nsfont_open): Remove assignment to voffset and
902 unnecessary vars hshink, expand, hd, full_height, min_height.
903 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
904
905 * nsterm.h (nsfont_info): Remove voffset field.
906
d8c2fa78 9072011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
908
909 Implement strike-through and overline on NextStep (Bug#8863).
910
911 * nsfont.m (nsfont_open): Use underline position provided by font,
912 instead of hard-coded value of 2.
913 (nsfont_draw): Call ns_draw_text_decoration instead.
914
915 * nsterm.h: Add declaration for ns_draw_text_decoration.
916
917 * nsterm.m (ns_draw_text_decoration): New function for drawing
918 underline, overline, and strike-through.
919 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
920 ns_draw_text_decoration. Change treatment of cursor drawing to
921 accomodate underlining, etc.
922
4cc60b9b
EZ
9232011-07-28 Eli Zaretskii <eliz@gnu.org>
924
bc7ece87
EZ
925 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
926 default.
4cc60b9b 927
476371c4
PE
9282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
929
66606eea
PE
930 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
931 Without this fix, if a signal arrives just after memory fills up,
932 'malloc' might be invoked reentrantly.
933
476371c4
PE
934 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
935 In other words, assume that every image size is allowed, on non-X
936 hosts. This assumption is probably wrong, but it lets Emacs compile.
937
f3fcc40d
AS
9382011-07-28 Andreas Schwab <schwab@linux-m68k.org>
939
940 * regex.c (re_iswctype): Convert return values to boolean.
941
350c992f
EZ
9422011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
943
944 * xdisp.c (compute_display_string_pos): Don't use cached display
945 string position if the buffer had its restriction changed.
946 (Bug#9184)
947
5266b4bb
PE
9482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
949
950 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
951
2573a837 9522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 953
41f55ccd 954 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 955
39e378da
PE
956 * bidi.c: Integer size and overflow fixes.
957 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
958 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
959 (bidi_cache_find_level_change, bidi_cache_ensure_space)
960 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
961 (bidi_find_other_level_edge):
962 Use ptrdiff_t instead of EMACS_INT where either will do.
963 This works better on 32-bit hosts configured --with-wide-int.
964 (bidi_cache_ensure_space): Check for size-calculation overflow.
965 Use % rather than repeated addition, for better worst-case speed.
966 Don't set bidi_cache_size until after xrealloc returns, because it
967 might not return.
968 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
969 (bidi_cache_ensure_space): Also check that the bidi cache size
970 does not exceed that of the largest Lisp string or buffer. See Eli
971 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 972
5e927815
PE
973 * alloc.c (__malloc_size_t): Remove.
974 All uses replaced by size_t. See Andreas Schwab's note
975 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
976
ca4aa935
PE
977 * image.c: Improve checking for integer overflow.
978 (check_image_size): Assume that f is nonnull, since
979 it is always nonnull in practice. This is one less thing to
980 worry about when checking for integer overflow later.
981 (x_check_image_size): New function, which checks for integer
982 overflow issues inside X.
983 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
984 This removes the need for a memory_full check.
985 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
986 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
987 (xbm_read_bitmap_data): Change locals back to 'int', since
988 their values must fit in 'int'.
989 (xpm_load_image, png_load, tiff_load):
990 Invoke x_create_x_image_and_pixmap earlier,
991 to avoid much needless work if the image is too large.
992 (tiff_load): Treat overly large images as if
993 x_create_x_image_and_pixmap failed, not as malloc failures.
994 (gs_load): Use x_check_image_size.
995
5f8f9cc2
PE
996 * gtkutil.c: Omit integer casts.
997 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
998 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
999
5adf60bc
PE
1000 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1001
c8907a93
PE
1002 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1003 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1004 would wrongly return t on a 64-bit host.
1005
e3c25c68
PE
1006 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1007 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1008 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1009 and therefore cause GCC to emit a bogus diagnostic in some cases.
1010
3f791afe
PE
1011 * image.c: Integer signedness and overflow and related fixes.
1012 This is not an exhaustive set of fixes, but it's time to
1013 record what I've got.
1014 (lookup_pixel_color, check_image_size): Remove redundant decls.
1015 (check_image_size): Don't assume that arbitrary EMACS_INT values
1016 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1017 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1018 (tiff_load, imagemagick_load_image):
1019 Check for overflow in size calculations.
1020 (x_create_x_image_and_pixmap): Remove unnecessary test for
1021 xmalloc returning NULL; that can't happen.
1022 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1023 (xpm_color_bucket): Use better integer hashing function.
1024 (xpm_cache_color): Don't possibly over-allocate memory.
1025 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1026 (gif_memory_source):
1027 Use ptrdiff_t, not int or size_t, to record sizes.
1028 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1029 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1030 either works, as we prefer signed integers.
1031 (tiff_read_from_memory, tiff_write_from_memory):
1032 Return tsize_t, not size_t, since that's what the TIFF API wants.
1033 (tiff_read_from_memory): Don't fail simply because the read would
1034 go past EOF; instead, return a short read.
1035 (tiff_load): Omit no-longer-needed casts.
1036 (Fimagemagick_types): Don't assume size fits into 'int'.
1037
3cc5a532
PE
1038 Improve hashing quality when configured --with-wide-int.
1039 * fns.c (hash_string): New function, taken from sxhash_string.
1040 Do not discard information about ASCII character case; this
1041 discarding is no longer needed.
1042 (sxhash-string): Use it. Change sig to match it. Caller changed.
1043 * lisp.h: Declare it.
1044 * lread.c (hash_string): Remove, since we now use fns.c's version.
1045 The fns.c version returns a wider integer if --with-wide-int is
1046 specified, so this should help the quality of the hashing a bit.
1047
b312a492
PE
1048 * emacs.c: Integer overflow minor fix.
1049 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1050 Define only if GNU_LINUX.
1051 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1052
dfd153ae
PE
1053 * dispnew.c: Integer signedness and overflow fixes.
1054 Remove unnecessary forward decls, that were a maintenance hassle.
1055 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1056 All uses changed.
1057 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1058 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1059 (prepare_desired_row, line_draw_cost):
1060 Use int, not unsigned, where either works.
1061 (save_current_matrix, restore_current_matrix):
1062 Use ptrdiff_t, not size_t, where either works.
1063 (init_display): Check for overflow more accurately, and without
1064 relying on undefined behavior.
1065
a81d11a3
PE
1066 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1067 Remove, replacing with the new symbols in lisp.h. All uses changed.
1068 * fileio.c (make_temp_name):
1069 * filelock.c (lock_file_1, lock_file):
1070 * xdisp.c (message_dolog):
1071 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1072 Use pMd etc. instead.
1073 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1074 replacing the pWIDE etc. symbols removed from editfns.c.
1075
3300e6fd
PE
1076 * keyboard.h (num_input_events): Now uintmax_t.
1077 This is (very slightly) less likely to mess up due to wraparound.
1078 All uses changed.
1079
fd05c7e9
PE
1080 * buffer.c: Integer signedness fixes.
1081 (alloc_buffer_text, enlarge_buffer_text):
1082 Use ptrdiff_t rather than size_t when either will do, as we prefer
1083 signed integers.
1084
903fe15d
PE
1085 * alloc.c: Integer signedness and overflow fixes.
1086 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1087 (__malloc_size_t): Default to size_t, not to int.
1088 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1089 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1090 Prefer ptrdiff_t to size_t when either would do, as we prefer
1091 signed integers.
1092 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1093 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1094 Now const. Initialize with values that are in range even if char
1095 is signed.
1096 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1097 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1098 These functions do the right thing with sizes > 2**32.
1099 (check_depth): Now ptrdiff_t, not int.
1100 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1101 Adjust to new way of storing sizes. Check for size overflow bugs
1102 in rest of code.
1103 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1104 slightly wrong anyway, as it missed one instance of
1105 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1106 (refill_memory_reserve): Omit needless cast to size_t.
1107 (mark_object_loop_halt): Mark as externally visible.
1108
ac82cc6a
PE
1109 * xselect.c: Integer signedness and overflow fixes.
1110 (Fx_register_dnd_atom, x_handle_dnd_message):
1111 Use ptrdiff_t, not size_t, since we prefer signed.
1112 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1113 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1114 x_dnd_atoms_size and x_dnd_atoms_length.
1115
c2d1e36d
PE
1116 * doprnt.c: Prefer signed to unsigned when either works.
1117 * eval.c (verror):
1118 * doprnt.c (doprnt):
1119 * lisp.h (doprnt):
1120 * xdisp.c (vmessage):
1121 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1122 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1123 prefer signed arithmetic to avoid comparison confusion.
1124 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1125 but is a bit tricky.
1126
0e926e56
PE
1127 Assume freestanding C89 headers, string.h, stdlib.h.
1128 * data.c, doprnt.c, floatfns.c, print.c:
1129 Include float.h unconditionally.
1130 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1131 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1132 * regex.c: Likewise for stddef.h, string.h.
1133 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1134 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1135 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1136 (STDC_HEADERS): Remove obsolete defines.
1137 * sysdep.c: Include limits.h unconditionally.
1138
9cfdb3ec
PE
1139 Assume support for memcmp, memcpy, memmove, memset.
1140 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1141 * regex.c (memcmp, memcpy):
1142 Remove; we assume C89 now.
1143
1144 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1145 (__malloc_safe_bcopy): Remove; no longer needed.
1146
cf950e6b 1147 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1148 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1149 well either way, and we prefer signed to unsigned.
1150
dbf38e02
LMI
11512011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1152
1153 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1154 closes the connection while we're reading (bug#9182).
1155
d6f0886c
JD
11562011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1157
1158 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1159 are specified (Bug#9168).
1160
2eb1f9e6
PE
11612011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1162
1163 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1164 Found by GCC static checking and --with-wide-int on a 32-bit host.
1165
22381272 11662011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1167
1168 * xdisp.c (compute_display_string_pos): Fix logic of caching
1169 previous display string position. Initialize cached_prev_pos to
1170 -1. Fixes slow-down at the beginning of a buffer.
1171
f25e39b4
EZ
11722011-07-24 Eli Zaretskii <eliz@gnu.org>
1173
1174 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1175 for attrs[LFACE_FONTSET_INDEX].
1176
04c4b52e
PE
11772011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1178
1179 * xml.c (parse_region): Remove unused local
1180 that was recently introduced.
1181
c1734fbd
EZ
11822011-07-23 Eli Zaretskii <eliz@gnu.org>
1183
be18c5a5
EZ
1184 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1185 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1186
c1734fbd
EZ
1187 * xdisp.c (move_it_in_display_line_to): Record the best matching
1188 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1189 exit if none of the characters scanned was an exact match.
1190 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1191 when exact match is impossible due to invisible text, and the
1192 lines are truncated.
1193
a258d627
JD
11942011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1195
1196 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1197 for OSX >= 10.7.
1198
b6d5a689
EZ
11992011-07-22 Eli Zaretskii <eliz@gnu.org>
1200
0f74f785
EZ
1201 Fix a significant slow-down of cursor motion with C-n, C-p,
1202 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1203 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1204 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1205 (next_element_from_buffer): Call compute_stop_pos_backwards to
1206 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1207 base_level_stop.
1208 (reseat): Don't look for prev_stop, as that could mean a very long
1209 run.
1210 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1211 <cached_disp_overlay_modiff>: Cache for last found display string
1212 position.
551918c1 1213 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1214 about the same buffer in the same area of character positions, and
1215 the buffer wasn't changed since the time the display string
1216 position was cached.
551918c1 1217
b2d0c91a
EZ
12182011-07-22 Eli Zaretskii <eliz@gnu.org>
1219
1220 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1221 is an integer, which is important for empty lines. (Bug#9149)
1222
043604ee
CY
12232011-07-22 Chong Yidong <cyd@stupidchicken.com>
1224
1225 * frame.c (Fmodify_frame_parameters): In tty case, update the
1226 default face if necessary (Bug#4238).
1227
da4adb04
CY
12282011-07-21 Chong Yidong <cyd@stupidchicken.com>
1229
1230 * editfns.c (Fstring_to_char): No need to explain what a character
1231 is in the docstring (Bug#6576).
1232
9abd0532
LMI
12332011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1234
1235 * xml.c (parse_region): Make sure we always return a tree.
1236
36881d16
HK
12372011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1238
1239 * xml.c (parse_region): If a document contains only comments,
1240 return that, too.
1241
1e98674d
LMI
12422011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1243
1244 * xml.c (make_dom): Return comments, too.
1245
590bd467
PE
12462011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1247
1248 Port to OpenBSD.
1249 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1250 and the surrounding thread.
1251 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1252 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1253 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1254 timer goes off.
1255 * s/openbsd.h (BROKEN_SIGIO): Define.
1256 * unexelf.c (unexec) [__OpenBSD__]:
1257 Don't update the .mdebug section of the Alpha COFF symbol table.
1258
f41628b2
LMI
12592011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1260
1261 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1262 (bug#8460).
1263
b59b67c5
PE
12642011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1265
15e3a074
PE
1266 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1267 This fixes some race conditions on the permissions of any newly
1268 created file.
1269
41bed37d
PE
1270 * alloc.c (valid_pointer_p): Use pipe, not open.
1271 This fixes some permissions issues when debugging.
1272
b59b67c5
PE
1273 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1274 If fchown fails to set both uid and gid, try to set just gid,
1275 as that is sometimes allowed. Adjust the file's mode to eliminate
1276 setuid or setgid bits that are inappropriate if fchown fails.
1277
925a6be7
SM
12782011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1279
1280 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1281 to compare Lisp_Objects.
1282 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1283 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1284 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1285
52968808
AS
12862011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1287
0a6a104b
AS
1288 * lread.c (read_integer): Unread even EOF character.
1289 (read1): Likewise. Properly record start position of symbol.
1290
52968808
AS
1291 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1292 symbol character follows.
1293
9e381cdd
PE
12942011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1295
1296 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1297 This works around a problem with the previous change to Fcopy_file.
1298 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1299 and without this change, GCC might complain about discarding
1300 fchown's return value.
1301
b5641435
JB
13022011-07-16 Juanma Barranquero <lekktu@gmail.com>
1303
1304 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1305
a8031457
PE
13062011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1307
1308 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1309
dd889327
LMI
13102011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1311
750c33f7
LMI
1312 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1313 it's used from the C level.
1314
dd889327
LMI
1315 * process.c: Use the same condition for POLL_FOR_INPUT in both
1316 keyboard.c and process.c (bug#1858).
1317
87e86684
LM
13182011-07-09 Lawrence Mitchell <wence@gmx.li>
1319
1320 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1321 (Fgnutls_boot): Use it.
1322
64348f40
AS
13232011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1324
1325 * doc.c (Fsubstitute_command_keys): Revert last change.
1326
1d698799
LMI
13272011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1328
f863868c
LMI
1329 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1330 quotes the next character, and doesn't affect other longer
1331 sequences (bug#8935).
1332
1d698799
LMI
1333 * lread.c (syms_of_lread): Clarify that is isn't only
1334 `eval-buffer' and `eval-defun' that's affected by
1335 `lexical-binding' (bug#8460).
1336
aa4b6df6
EZ
13372011-07-15 Eli Zaretskii <eliz@gnu.org>
1338
1339 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1340 bidi redisplay when a line includes both an image and is
1341 truncated.
1342
5d856da6
PE
13432011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1344
ad6042bb
PE
1345 Fix minor problems found by static checking.
1346 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1347 (elsz): Now a signed constant, not a size_t var. We prefer signed
1348 types to unsigned, to avoid integer comparison confusion. Without
1349 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1350 "cannot optimize loop, the loop counter may overflow", a symptom
1351 of the confusion.
f00bbb22 1352 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1353 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1354
6468f31c
LMI
13552011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1356
49080b10
LMI
1357 * search.c (Fre_search_backward): Mention `case-fold-search' in
1358 all the re_search_* functions (bug#8138).
1359
6468f31c
LMI
1360 * keyboard.c (Fopen_dribble_file): Document when the file is
1361 closed (bug#8056).
1362
c965adc5
EZ
13632011-07-14 Eli Zaretskii <eliz@gnu.org>
1364
df9733bf
EZ
1365 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1366 bidi_cache_idx.
1367
0bb23927
EZ
1368 Support bidi reordering of display and overlay strings.
1369 * xdisp.c (compute_display_string_pos)
1370 (compute_display_string_end): Accept additional argument STRING.
1371 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1372 (reseat_to_string): Initialize bidi_it->string.s and
1373 bidi_it->string.schars.
1374 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1375 NULL (avoids a crash in bidi_paragraph_init).
1376 Initialize itb.string.lstring.
0bb23927
EZ
1377 (init_iterator): Call bidi_init_it only of a valid
1378 buffer position was specified. Initialize paragraph_embedding to
1379 L2R.
1380 (reseat_to_string): Initialize the bidi iterator.
1381 (display_string): If we need to ignore text properties of
1382 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1383 original value of -1 will not work with bidi.)
1384 (compute_display_string_pos): First arg is now struct
1385 `text_pos *'; all callers changed. Support display properties on
1386 Lisp strings.
1387 (compute_display_string_end): Support display properties on Lisp
1388 strings.
1389 (init_iterator, reseat_1, reseat_to_string): Initialize the
1390 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1391 when iterating on a string not from display properties).
640c8776
SM
1392 (compute_display_string_pos, compute_display_string_end):
1393 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1394 arrow keys.
1395 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1396 base_level_stop; instead, set base_level_stop to BEGV.
1397 Fixes crashes in vertical-motion.
0bb23927
EZ
1398 (next_element_from_buffer): Improve commentary for when
1399 the iterator is before prev_stop.
1400 (init_iterator): Initialize bidi_p from the default value of
1401 bidi-display-reordering, not from buffer-local value. Use the
1402 buffer-local value only if initializing for buffer iteration.
1403 (handle_invisible_prop): Support invisible properties on strings
1404 that are being bidi-reordered.
1405 (set_iterator_to_next): Support bidi reordering of C strings and
1406 Lisp strings.
1407 (next_element_from_string): Support bidi reordering of Lisp
1408 strings.
1409 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1410 (display_string): Support display of R2L glyph rows.
1411 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1412 (init_iterator): Don't initialize it->bidi_p for strings
1413 here.
1414 (reseat_to_string): Initialize it->bidi_p for strings here.
1415 (next_element_from_string, next_element_from_c_string)
1416 (next_element_from_buffer): Add xassert's for correspondence
1417 between IT's object being iterated and it->bidi_it.string
1418 structure.
1419 (face_before_or_after_it_pos): Support bidi iteration.
1420 (next_element_from_c_string): Handle the case of the first string
1421 character that is not the first one in the visual order.
1422 (get_visually_first_element): New function, refactored from common
1423 parts of next_element_from_buffer, next_element_from_string, and
1424 next_element_from_c_string.
1425 (tool_bar_lines_needed, redisplay_tool_bar)
1426 (display_menu_bar): Force left-to-right direction. Add a FIXME
1427 comment for making that be controlled by a user option.
1428 (push_it, pop_it): Save and restore the state of the
1429 bidi iterator. Save and restore the bidi_p flag.
1430 (pop_it): Iterate out of display property for string iteration as
1431 well.
1432 (iterate_out_of_display_property): Support iteration over strings.
1433 (handle_single_display_spec): Set up it->bidi_it for iteration
1434 over a display string, and call bidi_init_it.
1435 (handle_single_display_spec, next_overlay_string)
1436 (get_overlay_strings_1, push_display_prop): Set up the bidi
1437 iterator for displaying display or overlay strings.
1438 (forward_to_next_line_start): Don't use the shortcut if
1439 bidi-iterating.
1440 (back_to_previous_visible_line_start): If handle_display_prop
1441 pushed the iterator stack, restore the internal state of the bidi
1442 iterator by calling bidi_pop_it same number of times.
1443 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1444 and we are bidi-iterating, don't decrement the iterator position;
1445 instead, set the first_elt flag in the bidi iterator, to produce
1446 the same effect.
1447 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1448 (push_display_prop): xassert that we are iterating a buffer.
1449 (push_it, pop_it): Save and restore paragraph_embedding member.
1450 (handle_single_display_spec, next_overlay_string)
1451 (get_overlay_strings_1, reseat_1, reseat_to_string)
1452 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1453 correctly. Don't assume unibyte strings are not bidi-reordered.
1454 (compute_display_string_pos)
1455 (compute_display_string_end): Fix handling the case of C string.
1456 (push_it, pop_it): Save and restore from_disp_prop_p.
1457 (handle_single_display_spec, push_display_prop): Set the
1458 from_disp_prop_p flag.
1459 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1460 (pop_it): Call iterate_out_of_display_property only if we are
1461 popping after iteration over a string that came from a display
1462 property. Fix a typo in popping stretch info. Add an assertion
1463 for verifying that the iterator position is in sync with the bidi
1464 iterator.
1465 (handle_single_display_spec, get_overlay_strings_1)
1466 (push_display_prop): Fix initialization of paragraph direction for
1467 string when that of the parent object is not yet determined.
1468 (reseat_1): Call bidi_init_it to resync the bidi
1469 iterator with IT's position. (Bug#7616)
1470 (find_row_edges): If ROW->start.pos gives position
1471 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1472 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1473 Reset the from_disp_prop_p flag.
1474 (SAVE_IT, RESTORE_IT): New macros.
1475 (pos_visible_p, face_before_or_after_it_pos)
1476 (back_to_previous_visible_line_start)
1477 (move_it_in_display_line_to, move_it_in_display_line)
1478 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1479 (try_scrolling, redisplay_window, display_line): Use them when
1480 saving a temporary copy of the iterator and restoring it back.
1481 (back_to_previous_visible_line_start, reseat_1)
1482 (init_iterator): Empty the bidi cache "stack".
1483 (move_it_in_display_line_to): If iterator ended up at
1484 EOL, but we never saw any buffer positions smaller than
1485 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1486 motion in bidi-reordered lines.
1487 (move_it_in_display_line_to): Record prev_method and prev_pos
1488 immediately before the call to set_iterator_to_next. Fixes cursor
1489 motion in bidi-reordered lines with stretch glyphs and strings
1490 displayed in margins. (Bug#8133) (Bug#8867)
1491 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1492 TO_CHARPOS.
640c8776
SM
1493 (pos_visible_p): Support positions in bidi-reordered lines.
1494 Save and restore bidi cache.
0bb23927
EZ
1495
1496 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1497 (bidi_paragraph_info): Delete unused struct.
1498 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1499 (bidi_cache_start): New variable.
1500 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1501 to zero.
1502 (bidi_cache_fetch_state, bidi_cache_search)
1503 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1504 (bidi_cache_find, bidi_peek_at_next_level)
1505 (bidi_level_of_next_char, bidi_find_other_level_edge)
1506 (bidi_move_to_visually_next): Compare cache index with
1507 bidi_cache_start rather than with zero.
1508 (bidi_fetch_char): Accept new argument STRING; all callers
1509 changed. Support iteration over a string. Support strings with
1510 display properties. Support unibyte strings. Fix the type of
1511 `len' according to what STRING_CHAR_AND_LENGTH expects.
1512 (bidi_paragraph_init, bidi_resolve_explicit_1)
1513 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1514 (bidi_level_of_next_char, bidi_move_to_visually_next):
1515 Support iteration over a string.
0bb23927
EZ
1516 (bidi_set_sor_type, bidi_resolve_explicit_1)
1517 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1518 can now be zero (for strings); special values 0 and -1 were
1519 changed to -1 and -2, respectively.
1520 (bidi_char_at_pos): New function.
1521 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1522 Call it instead of FETCH_MULTIBYTE_CHAR.
1523 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1524 initialized to valid values.
1525 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1526 values.
1527 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1528 the test for valid cached positions. Fix the logic for looking up
1529 the sentinel state in the cache. GCPRO the Lisp string we are
1530 iterating.
1531 (bidi_push_it, bidi_pop_it): New functions.
1532 (bidi_initialize): Initialize the bidi cache start stack pointer.
1533 (bidi_cache_ensure_space): New function, refactored from part of
1534 bidi_cache_iterator_state. Don't assume the required size is just
1535 one BIDI_CACHE_CHUNK away.
1536 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1537 (bidi_count_bytes, bidi_char_at_pos): New functions.
1538 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1539 always valid if bidi_cache_idx is valid.
1540 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1541 is valid if it's going to be used.
1542 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1543 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1544 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1545 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1546 (bidi_find_other_level_edge, bidi_cache_start_stack):
1547 All variables related to cache indices are now EMACS_INT.
c965adc5 1548
0bb23927
EZ
1549 * dispextern.h (struct bidi_string_data): New structure.
1550 (struct bidi_it): New member `string'. Make flag members be 1-bit
1551 fields, and put them last in the struct.
640c8776
SM
1552 (compute_display_string_pos, compute_display_string_end):
1553 Update prototypes.
0bb23927
EZ
1554 (bidi_push_it, bidi_pop_it): Add prototypes.
1555 (struct iterator_stack_entry): New members bidi_p,
1556 paragraph_embedding, and from_disp_prop_p.
1557 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1558 (bidi_shelve_cache, bidi_unshelve_cache):
1559 Declare prototypes.
0bb23927
EZ
1560
1561 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1562 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1563 and vector-like objects.
1564
1565 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1566 cache around display iteration.
1567
1568 * window.c (Fwindow_end, window_scroll_pixel_based)
1569 (displayed_window_lines, Frecenter): Save and restore the bidi
1570 cache around display iteration.
1571
3bbd2265
LMI
15722011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1573
1574 * editfns.c (Fdelete_region): Clarify the use of the named
1575 parameters (bug#6788).
1576
adc47434
MR
15772011-07-14 Martin Rudalics <rudalics@gmx.at>
1578
1579 * indent.c (Fvertical_motion): Set and restore w->pointm when
1580 saving and restoring the window's buffer (Bug#9006).
1581
837c31f8
LMI
15822011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1583
1584 * editfns.c (Fstring_to_char): Clarify just what is returned
1585 (bug#6576). Text by Eli Zaretskii.
1586
ac389d0c
JB
15872011-07-13 Juanma Barranquero <lekktu@gmail.com>
1588
1589 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1590
0be0ce47
EZ
15912011-07-13 Eli Zaretskii <eliz@gnu.org>
1592
1593 * buffer.c (mmap_find): Fix a typo.
1594
cd18e7e3
JB
15952011-07-13 Johan Bockgård <bojohan@gnu.org>
1596
1597 Fix execution of x selection hooks.
1598 * xselect.c (Qx_lost_selection_functions)
1599 (Qx_sent_selection_functions): New vars.
1600 (syms_of_xselect): DEFSYM them.
1601 (x_handle_selection_request): Pass Qx_sent_selection_functions
1602 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1603 (x_handle_selection_clear,x_clear_frame_selections):
1604 Pass Qx_lost_selection_functions rather than
1605 Vx_lost_selection_functions to Frun_hook_with_args.
1606
47ea7f44
PE
16072011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1608
ac389d0c 1609 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1610 The old code sometimes used this field without initializing it.
1611
47ea7f44
PE
1612 * alloc.c (gc_sweep): Don't read past end of array.
1613 In theory, the old code could also have corrupted Emacs internals,
1614 though it'd be very unlikely.
1615
bc985c87
AS
16162011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1617
1618 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1619 argument. (Bug#4026)
bc985c87 1620
0cf34688
LMI
16212011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1622
b3dadd76
LMI
1623 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1624 key" (bug#4257).
1625
0cf34688
LMI
1626 * window.c (Fset_window_start): Doc fix (bug#4199).
1627 (Fset_window_hscroll): Ditto.
1628
270768cd
PE
16292011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1630
077e3dda 1631 Fix minor new problems caught by GCC 4.6.1.
270768cd 1632 * term.c (init_tty): Remove unused local.
490011a6 1633 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1634 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1635 not used otherwise.
270768cd 1636
b1f58454
CY
16372011-07-12 Chong Yidong <cyd@stupidchicken.com>
1638
1639 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1640
22b9578d
LMI
16412011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1642
6e70ab07
LMI
1643 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1644 are the mini-buffer and the echo area (bug#3320).
1645
22b9578d
LMI
1646 * term.c (init_tty): Remove support for supdup, c10 and perq
1647 terminals, which are no longer supported (bug#1482).
1648
8974cc9f
JB
16492011-07-10 Johan Bockgård <bojohan@gnu.org>
1650
1651 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1652
a560d974
JD
16532011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1654
1655 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1656 for non-popups (Bug#3642).
1657
1dae0f0a
AS
16582011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1659
268c2c36 1660 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1661 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1662 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1663 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1664 * data.c (fmod): Likewise.
1665 * dispnew.c (swap_glyphs_in_rows): Likewise.
1666 * emacs.c (memory_warning_signal): Likewise.
1667 * floatfns.c (float_error): Likewise.
1668 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1669 (otf_open, font_otf_capability, generate_otf_features)
1670 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1671 Likewise.
1672 * image.c (pbm_read_file): Likewise.
1673 * indent.c (string_display_width): Likewise.
1674 * intervals.c (check_for_interval, search_for_interval)
1675 (inc_interval_count, count_intervals, root_interval)
1676 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1677 * lread.c (defalias): Likewise.
268c2c36 1678 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1679 * regex.c (set_image_of_range_1, set_image_of_range)
1680 (regex_grow_registers): Likewise.
1681 * sysdep.c (strerror): Likewise.
1682 * termcap.c (valid_filename_p, tprint, main): Likewise.
1683 * tparam.c (main): Likewise.
1684 * unexhp9k800.c (run_time_remap, save_data_space)
1685 (update_file_ptrs, read_header, write_header, calculate_checksum)
1686 (copy_file, copy_rest, display_header): Likewise.
1687 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1688 Likewise.
1689 * xdisp.c (check_it): Likewise.
1690 * xfaces.c (register_color, unregister_color, unregister_colors):
1691 Likewise.
1692 * xfns.c (print_fontset_result): Likewise.
1693 * xrdb.c (member, fatal, main): Likewise.
1694
99033785
PE
16952011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1696
1697 Fix minor problems found by static checking (Bug#9031).
1698 * chartab.c (char_table_set_range, map_sub_char_table):
1699 Remove unused locals.
1700 (uniprop_table): Now static.
1701 * composite.c (_work_char): Remove unused static var.
1702
9cb2ac56
JB
17032011-07-09 Juanma Barranquero <lekktu@gmail.com>
1704
1705 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1706
f25661f0
JD
17072011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1708
1709 * gtkutil.c (qttip_cb): Remove code without function.
1710
8278c4fe
EZ
17112011-07-09 Eli Zaretskii <eliz@gnu.org>
1712
1713 * w32.c (pthread_sigmask): New stub.
1714
1692ae2d 17152011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1716
8a6ebd58 1717 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1718 sigprocmask is portable only for single-threaded applications, and
1719 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1720 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1721 (LIBES): Use it.
1722 * callproc.c (Fcall_process):
1723 * process.c (create_process):
1724 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1725 Use pthread_sigmask, not sigprocmask.
123403e4 1726
1b854618
JD
17272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1728
1729 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1730 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1731 wrong (Bug#8591).
1732
3fe4b549
JD
17332011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1734
0ce7e563
JD
1735 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1736 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1737 (xg_hide_tooltip): Fix comment.
1738
3fe4b549
JD
1739 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1740 in registerServicesMenuSendTypes.
1741 (validRequestorForSendType): Don't check ns_return_types.
1742
1743 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1744 ns_return_type.
1745
5df75e47
JR
17462011-07-08 Jason Rumney <jasonr@gnu.org>
1747
1748 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1749 frame struct members of non-existent frames (Bug#6284).
1750
699c10bd
JD
17512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1752
4393663b
JD
1753 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1754 variable firstTime not needed on OSX >= 10.6.
1755 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1756 >= 10.5. Use setKnobProportion, setDoubleValue.
1757
1758 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1759 (MAC_OS_X_VERSION_10_5): Define if not defined.
1760 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1761 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1762 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1763
1764 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1765 cString and lossyCString on OSX >= 10.4
1766
1767 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1768 sizeToFit on OSX >= 10.2.
1769
1770 * nsimage.m (allocInitFromFile): Don't use deprecated method
1771 bestRepresentationForDevice on OSX >= 10.6.
1772
1773 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1774 to avoid warning.
1775
1776 * emacs.c: Declare unexec_init_emacs_zone.
1777
a63e0781
JD
1778 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1779
699c10bd
JD
1780 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1781
1782 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1783 on svcsMenu (Bug#8842).
1784
1785 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1786 ns_return_types.
1787 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1788
1789 * nsterm.m (QUTF8_STRING): Declare.
1790 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1791 (validRequestorForSendType): Return type is (id).
1792 Change indexOfObjectIdenticalTo to indexOfObject.
1793 Check if we have local selection before returning self (Bug#8842).
1794 (writeSelectionToPasteboard): Put local selection into paste board
1795 if we have a local selection (Bug#8842).
1796 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1797
1798 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1799 (ns_get_local_selection): Declare.
1800
54e10184
LMI
18012011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1802
9888ff71
LMI
1803 * keymap.c (describe_map_tree): Don't insert a double newline at
1804 the end of the buffer (bug#1169) and return whether we inserted
1805 something.
1806
54e10184
LMI
1807 * callint.c (Fcall_interactively): Change "reading args" to
1808 "providing args" to try to clarify what it does (bug#1010).
1809
15fa4783
KH
18102011-07-07 Kenichi Handa <handa@m17n.org>
1811
1812 * composite.c (composition_compute_stop_pos): Ignore a static
1813 composition starting before CHARPOS (Bug#8915).
1814
1815 * xdisp.c (handle_composition_prop): Likewise.
1816
a8815b00
EZ
18172011-07-07 Eli Zaretskii <eliz@gnu.org>
1818
1819 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1820 (Bug#9015)
1821
ef7b981d 18222011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1823
1824 * character.h (unicode_category_t): New enum type.
1825
1826 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1827 (Qchar_code_property_table): New variable.
1828 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1829 (UNIPROP_COMPRESSED_FORM_P): New macros.
1830 (char_table_ascii): Uncompress the compressed values.
1831 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1832 Uncompress the compressed values.
ac389d0c 1833 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1834 (char_table_ref_and_range): Uncompress the compressed values.
1835 (sub_char_table_set): New arg is_uniprop. Callers changed.
1836 Uncompress the compressed values.
1837 (sub_char_table_set_range): Args changed. Callers changed.
1838 (char_table_set_range): Adjuted for the above change.
1839 (map_sub_char_table): Delete args default_val and parent. Add arg
1840 top. Give decoded values to a Lisp function.
640c8776 1841 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1842 values to a Lisp function. Gcpro more variables.
1843 (uniprop_table_uncompress)
1844 (uniprop_decode_value_run_length): New functions.
1845 (uniprop_decoder, uniprop_decoder_count): New variables.
1846 (uniprop_get_decoder, uniprop_encode_value_character)
1847 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1848 New functions.
1849 (uniprop_encoder, uniprop_encoder_count): New variables.
1850 (uniprop_get_encoder, uniprop_table)
1851 (Funicode_property_table_internal, Fget_unicode_property_internal)
1852 (Fput_unicode_property_internal): New functions.
1853 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1854 Sunicode_property_table_internal, Sget_unicode_property_internal,
1855 and Sput_unicode_property_internal. Defvar_lisp
1856 char-code-property-alist.
1857
640c8776 1858 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1859 Vunicode_category_table.
1860
640c8776 1861 * font.c (font_range): Adjust for the change of
c805dec0
KH
1862 Vunicode_category_table.
1863
76b397fb
DN
18642011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1865
1866 * m/iris4d.h: Remove file, move contents ...
1867 * s/irix6-5.h: ... here.
1868
22b4128e
PE
18692011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1870
1871 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1872 * alloc.c (mark_buffer):
1873 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1874 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1875 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1876 This isn't true in general, and it's particularly not true
1877 if Emacs is configured with --with-wide-int.
1878 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1879 New macros, used in the buffer.c change.
1880
869795d6
JD
18812011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1882
1883 * xsettings.c: Use both GConf and GSettings if both are available.
1884 (store_config_changed_event): Add comment.
1885 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1886 (store_tool_bar_style_changed): New functions.
1887 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1888 (struct xsettings): Move font inside HAVE_XFT.
1889 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1890 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1891 Move inside HAVE_XFT.
640c8776 1892 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1893 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1894 also.
1895 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1896 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1897 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1898 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1899 (parse_settings): Move check for font inside HAVE_XFT.
1900 (read_settings, apply_xft_settings): Add comment.
1901 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1902 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1903 call store_font_name_changed.
1904 (xft_settings_event): Add comment.
1905 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1906 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1907 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1908 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1909 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1910 (xsettings_get_system_font, xsettings_get_system_normal_font):
1911 Add comment.
869795d6 1912
d8ed26bd
PE
19132011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1914
1915 Random fixes. E.g., (random) never returned negative values.
1916 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1917 subseconds part to the entropy, as that's a bit more random.
1918 Prefer signed to unsigned, since the signedness doesn't matter and
1919 in general we prefer signed. When given a limit, use a
1920 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1921 latter isn't right if USE_2_TAGS_FOR_INTS.
1922 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1923 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1924
cabf1cac
SM
19252011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1926
1927 * textprop.c (text_property_stickiness):
1928 Obey Vtext_property_default_nonsticky.
1929 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1930 * w32fns.c (syms_of_w32fns):
1931 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1932
6e9b2be9
PE
19332011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1934
1935 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1936 This is more efficient than Ffile_directory_p and avoids a minor race.
1937
90186c68
LMI
19382011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1939
7c301272
LMI
1940 * buffer.c (Foverlay_put): Say what the return value is
1941 (bug#7835).
1942
c4f2d8d4
LMI
1943 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1944 is a directory before asking whether to use the file name
1945 (bug#7564).
ad637907
LMI
1946 (barf_or_query_if_file_exists): Make the "File is a directory"
1947 error be more correct.
c4f2d8d4 1948
90186c68
LMI
1949 * fns.c (Frequire): Remove the mention of the .gz files, since
1950 that's installation-specific, but keep the mention of
1951 `get-load-suffixes'.
1952
da64016e
PE
19532011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1954
1955 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1956 Report string overflow if the output is too long.
1957
7d47b580
JB
19582011-07-04 Juanma Barranquero <lekktu@gmail.com>
1959
a555cb87
JB
1960 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1961 (syms_of_gnutls): Remove duplicate DEFSYM for
1962 Qgnutls_bootprop_verify_hostname_error, an error for
1963 Qgnutls_bootprop_verify_error (which is no longer used).
1964
7d47b580
JB
1965 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1966 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1967 Also (re)move comments that are misplaced or no longer relevant.
1968
1e49bfab
LMI
19692011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1970
1971 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1972
1485f4c0
CY
19732011-07-03 Chong Yidong <cyd@stupidchicken.com>
1974
1975 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1976 and background color parameters if they have been changed.
1977
a9ab721e
LMI
19782011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1979
1980 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1981
cf7cff57
PE
19822011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1983
2e13213d
PE
1984 * xsettings.c (SYSTEM_FONT): Define only when used.
1985 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1986
cf7cff57
PE
1987 * keymap.c (access_keymap_1): Now static.
1988
7a8e04f7
CY
19892011-07-02 Chong Yidong <cyd@stupidchicken.com>
1990
1991 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1992 leave any prefix arg for the up event (Bug#1586).
1993
61352f62
LMI
19942011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1995
69bb1ef7
LMI
1996 * lread.c (syms_of_lread): Mention single symbols defined by
1997 `defvar' or `defconst' (bug#7154).
1998
61352f62 1999 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2000 (Frequire): Mention get-load-suffixes.
61352f62 2001
28545e04
MR
20022011-07-02 Martin Rudalics <rudalics@gmx.at>
2003
2004 * window.h (window): Remove clone_number slot.
2005 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2006 Remove.
2007 (make_parent_window, make_window, saved_window)
2008 (Fset_window_configuration, save_window_save): Don't deal with
2009 clone numbers.
2010 * buffer.c (Qclone_number): Remove declaration.
2011 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2012
3349e122
SM
20132011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2014
2015 Add multiple inheritance to keymaps.
2016 * keymap.c (Fmake_composed_keymap): New function.
2017 (Fset_keymap_parent): Simplify.
2018 (fix_submap_inheritance): Remove.
2019 (access_keymap_1): New function extracted from access_keymap to handle
2020 embedded parents and handle lists of maps.
2021 (access_keymap): Use it.
2022 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2023 (Fcopy_keymap): Handle embedded parents.
2024 (Fcommand_remapping, define_as_prefix): Simplify.
2025 (Fkey_binding): Simplify.
2026 (syms_of_keymap): Move minibuffer-local-completion-map,
2027 minibuffer-local-filename-completion-map,
2028 minibuffer-local-must-match-map, and
2029 minibuffer-local-filename-must-match-map to Elisp.
2030 (syms_of_keymap): Defsubr make-composed-keymap.
2031 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2032 (parse_menu_item): Trivial simplification.
2033
3279eb87
GM
20342011-07-01 Glenn Morris <rgm@gnu.org>
2035
2036 * Makefile.in (SETTINGS_LIBS): Fix typo.
2037
4550efdf
KI
20382011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2039
2040 * coding.c (Fencode_coding_string): Record the last coding system
2041 used, as the function doc string says (bug#8738).
2042
0949d2b6
JD
20432011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2044
2045 * xsettings.c (store_monospaced_changed): Take new font as arg and
2046 check for change against current_mono_font.
2047 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2048 (emacs_settings_constructor, emacs_settings_get_property)
2049 (emacs_settings_set_property, emacs_settings_class_init)
2050 (emacs_settings_init, gsettings_obj): Remove.
2051 (something_changedCB): New function for HAVE_GSETTINGS.
2052 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2053 with value as argument.
2054 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2055 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2056 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2057 "changed".
2058
2059 * xgselect.c: Add defined (HAVE_GSETTINGS).
2060 (xgselect_initialize): Ditto.
2061
2062 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2063 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2064 xg_select.
2065
bbc6b304
PE
20662011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2067
2068 * eval.c (struct backtrace): Simplify and port the data structure.
2069 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2070 signed bit field, as this assumption is not portable and it makes
2071 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2072 "char debug_on_exit : 1" as this is not portable either; instead,
2073 use the portable "unsigned int debug_on_exit : 1". Remove unused
2074 member evalargs. Remove obsolete comments about cc bombing out.
2075
9851bfc5
JD
20762011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2077
51bb811f 2078 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2079 Let HAVE_GSETTINGS override HAVE_GCONF.
2080 (store_monospaced_changed): New function.
2081 (EMACS_SETTINGS): A new type derived from GObject to handle
2082 GSettings notifications.
2083 (emacs_settings_constructor, emacs_settings_get_property)
2084 (emacs_settings_set_property, emacs_settings_class_init):
2085 New functions.
2086 (gsettings_client, gsettings_obj): New variables.
2087 (GSETTINGS_SCHEMA): New define.
2088 (something_changedCB): Call store_monospaced_changed.
2089 (init_gsettings): New function.
2090 (xsettings_initialize): Call init_gsettings.
2091 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2092 to NULL.
2093
640c8776 2094 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2095 GCONF_CFLAGS/LIBS.
2096
5386012d
MR
20972011-06-29 Martin Rudalics <rudalics@gmx.at>
2098
2099 * window.c (resize_root_window, grow_mini_window)
2100 (shrink_mini_window): Rename Qresize_root_window to
2101 Qwindow_resize_root_window and Qresize_root_window_vertically to
2102 Qwindow_resize_root_window_vertically.
2103
f13e0b08
PE
21042011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2105
2106 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2107
94515237
JB
21082011-06-27 Juanma Barranquero <lekktu@gmail.com>
2109
2110 * makefile.w32-in: Redesign dependencies so they reflect more
2111 clearly which files are directly included by each source file,
2112 and not through other includes.
2113
e43b6e43
MR
21142011-06-27 Martin Rudalics <rudalics@gmx.at>
2115
2116 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2117 (sort_overlays, overlay_strings): When an overlay's clone number
2118 matches the window's clone number process the overlay even if
2119 the overlay's window property doesn't match the current window.
2120
d68443dc
MR
2121 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2122 (Fwindow_hchild): Rename to Fwindow_left_child.
2123 (Fwindow_next): Rename to Fwindow_next_sibling.
2124 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2125 (resize_window_check): Rename to window_resize_check.
2126 (resize_window_apply): Rename to window_resize_apply.
2127 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2128 (Fdelete_other_windows_internal, resize_frame_windows)
2129 (Fsplit_window_internal, Fdelete_window_internal)
2130 (grow_mini_window, shrink_mini_window)
2131 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2132
c7e73be5
JD
21332011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2134
2135 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2136 (emacs_fixed_set_min_size): Remove.
2137 (emacs_fixed_new): Take frame as argument.
2138
2139 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2140 (_EmacsFixedPrivate): Remove minwidth/height.
2141 Add struct frame *f.
2142 (emacs_fixed_init): Initialize priv->f.
2143 (get_parent_class, emacs_fixed_set_min_size): Remove.
2144 (emacs_fixed_new): Set priv->f to argument.
2145 (emacs_fixed_get_preferred_width)
2146 (emacs_fixed_get_preferred_height): Use min_width/height from
2147 frames size_hint to set minimum and natural (Bug#8919).
2148 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2149 and use min_width/height from frames size_hint to set
2150 min_width/height (Bug#8919).
2151
2152 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2153 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2154 Fix indentation.
c7e73be5 2155
cf99dcf8
EZ
21562011-06-26 Eli Zaretskii <eliz@gnu.org>
2157
2158 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2159 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2160 called at ZV.
2161
029529ac
CY
21622011-06-26 Chong Yidong <cyd@stupidchicken.com>
2163
2164 * process.c (wait_reading_process_output): Bypass select if
2165 waiting for a cell while ignoring keyboard input, and input is
2166 pending. Suggested by Jan Djärv (Bug#8869).
2167
7a7ef429
PE
21682011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2169
2170 Use gnulib's dup2 module instead of rolling our own.
2171 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2172
11fdef7d 21732011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2174
2175 * dispnew.c (scrolling_window): Before scrolling, turn off a
2176 mouse-highlight in the window being scrolled.
2177
cd3520a4
JB
21782011-06-24 Juanma Barranquero <lekktu@gmail.com>
2179
2180 Move DEFSYM to lisp.h and use everywhere.
2181
2182 * character.h (DEFSYM): Move declaration...
2183 * lisp.h (DEFSYM): ...here.
2184
2185 * gnutls.c:
2186 * minibuf.c:
2187 * w32menu.c:
2188 * w32proc.c:
2189 * w32select.c: Don't include character.h.
2190
2191 * alloc.c (syms_of_alloc):
2192 * buffer.c (syms_of_buffer):
2193 * bytecode.c (syms_of_bytecode):
2194 * callint.c (syms_of_callint):
2195 * casefiddle.c (syms_of_casefiddle):
2196 * casetab.c (init_casetab_once):
2197 * category.c (init_category_once, syms_of_category):
2198 * ccl.c (syms_of_ccl):
2199 * cmds.c (syms_of_cmds):
2200 * composite.c (syms_of_composite):
2201 * dbusbind.c (syms_of_dbusbind):
2202 * dired.c (syms_of_dired):
2203 * dispnew.c (syms_of_display):
2204 * doc.c (syms_of_doc):
2205 * editfns.c (syms_of_editfns):
2206 * emacs.c (syms_of_emacs):
2207 * eval.c (syms_of_eval):
2208 * fileio.c (syms_of_fileio):
2209 * fns.c (syms_of_fns):
2210 * frame.c (syms_of_frame):
2211 * fringe.c (syms_of_fringe):
2212 * insdel.c (syms_of_insdel):
2213 * keymap.c (syms_of_keymap):
2214 * lread.c (init_obarray, syms_of_lread):
2215 * macros.c (syms_of_macros):
2216 * msdos.c (syms_of_msdos):
2217 * print.c (syms_of_print):
2218 * process.c (syms_of_process):
2219 * search.c (syms_of_search):
2220 * sound.c (syms_of_sound):
2221 * syntax.c (init_syntax_once, syms_of_syntax):
2222 * terminal.c (syms_of_terminal):
2223 * textprop.c (syms_of_textprop):
2224 * undo.c (syms_of_undo):
2225 * w32.c (globals_of_w32):
2226 * window.c (syms_of_window):
2227 * xdisp.c (syms_of_xdisp):
2228 * xfaces.c (syms_of_xfaces):
2229 * xfns.c (syms_of_xfns):
2230 * xmenu.c (syms_of_xmenu):
2231 * xsettings.c (syms_of_xsettings):
2232 * xterm.c (syms_of_xterm): Use DEFSYM.
2233
4228cf16
TZ
22342011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2235
cd3520a4 2236 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2237
7fcccf1e
PE
22382011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2239
7efb4e0e
PE
2240 Integer and buffer overflow fixes (Bug#8873).
2241
ff5844ad
PE
2242 * print.c (printchar, strout): Check for string overflow.
2243 (PRINTPREPARE, printchar, strout):
2244 Don't set size unless allocation succeeds.
2245
90532f02
PE
2246 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2247 for sizes. Check for string overflow more accurately.
2248 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2249
6d84508d
PE
2250 * macros.c: Integer and buffer overflow fixes.
2251 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2252 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2253 Use ptrdiff_t, not int, for sizes.
2254 Don't increment bufsize until after realloc succeeds.
2255 Check for size-calculation overflow.
2256 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2257
437b2cb4
PE
2258 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2259
8b9ac8b4
PE
2260 * lread.c: Integer overflow fixes.
2261 (read_integer): Radix is now EMACS_INT, not int,
2262 to improve quality of diagnostics for out-of-range radices.
2263 Calculate buffer size correctly for out-of-range radices.
2264 (read1): Check for integer overflow in radices, and in
2265 read-circle numbers.
82cb60d3
PE
2266 (read_escape): Avoid int overflow.
2267 (Fload, openp, read_buffer_size, read1)
2268 (substitute_object_recurse, read_vector, read_list, map_obarray):
2269 Use ptrdiff_t, not int, for sizes.
2270 (read1): Use EMACS_INT, not int, for sizes.
20270765 2271 Check for size overflow.
8b9ac8b4 2272
7fcccf1e
PE
2273 * image.c (cache_image): Check for size arithmetic overflow.
2274
bfbbd7e7
PE
2275 * lread.c: Integer overflow issues.
2276 (saved_doc_string_size, saved_doc_string_length)
2277 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2278 Now ptrdiff_t, not int.
2279 (read1): Don't assume doc string length fits in int. Check for
2280 out-of-range doc string lengths.
2281 (read_list): Don't assume file position fits in int.
39019e54 2282 (read_escape): Check for hex character overflow.
bfbbd7e7 2283
4e323265
LL
22842011-06-22 Leo Liu <sdl.web@gmail.com>
2285
2286 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2287 Move to minibuffer.el.
2288
85fece3e
PE
22892011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2290
20b84ce9 2291 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2292 The following patches are for when GLYPH_DEBUG && !XASSERT.
2293 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2294 * dispnew.c (flush_stdout):
2295 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2296 Mark as externally visible.
2297 * dispnew.c (check_window_matrix_pointers): Now static.
2298 * dispnew.c (window_to_frame_vpos):
2299 * xfns.c (unwind_create_frame):
2300 * xterm.c (x_check_font): Remove unused local.
2301 * scroll.c (CHECK_BOUNDS):
2302 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2303 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2304 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2305 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2306 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2307 Now static.
2308 (debug_method_add): Use va_list and vsprintf rather than relying
2309 on undefined behavior with wrong number of arguments.
2310 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2311 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2312 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2313 since we're not interested in debugging glyphs with old libraries.
2314 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2315 GCC 4.6.0's static checking.
2316
0766b489
PE
23172011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2318
31fd4b32
PE
2319 Integer overflow and signedness fixes (Bug#8873).
2320 A few related buffer overrun fixes, too.
2321
b79e8648
PE
2322 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2323
0766b489
PE
2324 * dispextern.h (struct face.stipple):
2325 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2326 (x_bitmap_mask, x_allocate_bitmap_record)
2327 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2328 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2329 (x_create_bitmap_from_xpm_data):
2330 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2331 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2332 (.bitmaps_last):
2333 * xfaces.c (load_pixmap):
2334 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2335 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2336 (.bitmaps_last, struct x_output.icon_bitmap):
2337 Use ptrdiff_t, not int, for bitmap indexes.
2338 (x_allocate_bitmap_record): Check for size overflow.
2339 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2340
b081724f
PE
2341 Use ptrdiff_t, not int, for overlay counts.
2342 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2343 * editfns.c (overlays_around, get_pos_property):
2344 * textprop.c (get_char_property_and_overlay):
2345 * xdisp.c (next_overlay_change, note_mouse_highlight):
2346 * xfaces.c (face_at_buffer_position):
21514da7
PE
2347 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2348 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2349 (Fnext_overlay_change, Fprevious_overlay_change)
2350 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2351 Use ptrdiff_t, not int, for sizes.
21514da7 2352 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2353
3de73e5e
PE
2354 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2355
2606c57b
PE
2356 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2357 (x_session_initialize): Do not assume string length fits in int.
2358
aaafe47a
PE
2359 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2360 This is unlikely, but can occur if DPI is outlandish.
2361
2674ddc8 2362 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2363 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2364
28154962
PE
2365 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2366 * xrdb.c (magic_file_p, search_magic_path):
2367 Omit last arg SUFFIX; it was always 0. All callers changed.
2368 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2369
7de51af5
PE
2370 * xfont.c (xfont_match): Avoid need for strlen.
2371
25ed6cc3
PE
2372 * xfns.c: Don't assume strlen fits in int.
2373 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2374
4eab31dd
PE
2375 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2376 not unsigned long, as we prefer signed integers. All callers changed.
2377 Detect integer overflow in repeat count.
2378 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2379 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2380
171e2a58
PE
2381 * termcap.c: Don't assume sizes fit in int and never overflow.
2382 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2383 (gobble_line): Check for size-calculation overflow.
2384
ad39faca 2385 * minibuf.c (Fread_buffer):
6e5bb2dc 2386 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2387 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2388 Don't assume string length fits in int.
2389
52c61c22 2390 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2391 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2392
b5b8c9e5
PE
2393 * font.c: Don't assume string length fits in int.
2394 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2395 Use ptrdiff_t, not int.
ccd6111c
PE
2396 (font_intern_prop): Don't assume string length fits in int.
2397 Don't assume integer property fits in fixnum.
2398 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2399
882f0d81 2400 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2401 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2402 Reformulate so as not to need the command string.
2403 Invoke gzip -cd rather than gunzip, as it's more portable.
2404 (lock_info_type, lock_file_1, lock_file):
2405 Don't assume pid_t and time_t fit in unsigned long.
2406 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2407 (current_lock_owner): Prefer signed type for sizes.
2408 Use memcpy, not strncpy, where memcpy is what is really wanted.
2409 Don't assume (via atoi) that time_t and pid_t fit in int.
2410 Check for time_t and/or pid_t out of range, e.g., via a network share.
2411 Don't alloca where an auto var works fine.
2412
93f4cf88
PE
2413 * fileio.c: Fix some integer overflow issues.
2414 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2415 Don't assume string length fits in int.
2416 (directory_file_name): Don't assume string length fits in long.
2417 (make_temp_name): Don't assume pid fits in int, or that its print
2418 length is less than 20.
2419
f3e92b69
PE
2420 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2421
1bfdaf10
PE
2422 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2423
35016e9a
PE
2424 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2425
3d1e65a1
PE
2426 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2427 We prefer signed integers, even for size calculations.
2428
0b963a93
PE
2429 * emacs.c: Don't assume string length fits in 'int'.
2430 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2431 (main): Don't invoke strlen when not needed.
2432
573f4b54
PE
2433 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2434 (XD_DEBUG_MESSAGE): Don't waste a byte.
2435
989f33ba
PE
2436 * callproc.c (getenv_internal_1, getenv_internal)
2437 (Fgetenv_internal):
965d34eb
PE
2438 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2439
e4d29b33
PE
2440 * lread.c (invalid_syntax): Omit length argument.
2441 All uses changed. This doesn't fix a bug, but it simplifies the
2442 code away from its former Hollerith-constant appearance, and it's
2443 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2444 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2445
eb49b136
PE
2446 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2447 This didn't break anything, but it didn't help either.
2448 It's confusing to put a bogus integer in a place where the actual
2449 value does not matter.
9f62aeb1 2450 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2451 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2452
15375a22
PE
2453 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2454 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2455 implementation.
b61cc01c
PE
2456 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2457 We prefer signed types, and the value cannot exceed the EMACS_INT
2458 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2459 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2460 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2461 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2462
53b2623d
PE
2463 * indent.c (sane_tab_width): New function.
2464 (current_column, scan_for_column, Findent_to, position_indentation)
2465 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2466 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2467
51cab52b 2468 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2469
f2ed8a70
PE
2470 * lisp.h (lint_assume): New macro.
2471 * composite.c (composition_gstring_put_cache):
2472 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2473
abe80cc6
PE
2474 * editfns.c, insdel.c:
2475 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2476
b02c740e
PE
2477 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2478
ebc96716
PE
2479 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2480
b4e50fa0 2481 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2482 Use much-faster test for byte-length change.
311d5d7c 2483 Don't assume string byte-length fits in 'int'.
a4cf38e4 2484 Check that character arg fits in 'int'.
85461888 2485 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2486
c0c1ee9f
PE
2487 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2488
a498d7f4
PE
2489 * fns.c (concat): Catch string overflow earlier.
2490 Do not rely on integer wraparound.
2491
51cab52b
PE
2492 * dispextern.h (struct it.overlay_strings_charpos)
2493 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2494 * xdisp.c (forward_to_next_line_start)
2495 (back_to_previous_visible_line_start)
2496 (reseat_at_next_visible_line_start, next_element_from_buffer):
2497 Don't arbitrarily truncate the value of 'selective' to int.
2498
76031fad
PE
2499 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2500
5eb55db9
PE
2501 * composite.c: Don't truncate sizes to 'int'.
2502 (composition_gstring_p, composition_reseat_it)
2503 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2504 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2505 not EMACS_UINT, for indexes.
5eb55db9 2506
0703a717
PE
2507 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2508
d6202519
PE
2509 * buffer.c: Include <verify.h>.
2510 (struct sortvec.priority, struct sortstr.priority):
8961a454 2511 Now EMACS_INT, not int.
c20998a7 2512 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2513 (struct sortstr.size, record_overlay_string)
2514 (struct sortstrlist.size, struct sortlist.used):
2515 Don't truncate size to int.
2516 (record_overlay_string): Check for size-calculation overflow.
d6202519 2517 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2518
d5a19415
JM
25192011-06-22 Jim Meyering <meyering@redhat.com>
2520
029529ac 2521 Don't leak an XBM-image-sized buffer
d5a19415
JM
2522 * image.c (xbm_load): Free the image buffer after using it.
2523
a9041e6c
PE
25242011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2525
2526 Port to Sun C.
2527 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2528 that Sun C diagnosed.
2529 * fns.c (secure_hash): Fix pointer signedness issue.
2530 * intervals.c (static_offset_intervals): New function.
2531 (offset_intervals): Use it.
2532
7f3f739f
LL
25332011-06-21 Leo Liu <sdl.web@gmail.com>
2534
2535 * deps.mk (fns.o):
2536 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2537 sha512.h.
2538
2539 * fns.c (secure_hash): Rename from crypto_hash_function and change
2540 the first arg to accept symbols.
5b66d427 2541 (Fsecure_hash): New primitive.
7f3f739f
LL
2542 (syms_of_fns): New symbols.
2543
76147d94
DD
25442011-06-20 Deniz Dogan <deniz@dogan.se>
2545
2546 * process.c (Fset_process_buffer): Clarify return value in
2547 docstring.
2548
7d7d0045
CY
25492011-06-18 Chong Yidong <cyd@stupidchicken.com>
2550
2551 * dispnew.c (add_window_display_history): Use BVAR.
2552
2553 * xdisp.c (debug_method_add): Use BVAR.
2554 (check_window_end, dump_glyph_matrix, dump_glyph)
2555 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2556
2557 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2558 Likewise.
2559
2560 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2561 check till after the cache is created in init_frame_faces.
2562
ff2bc410
SM
25632011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2564
2565 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2566
28177add
PE
25672011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2568
dd3482fe
PE
2569 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2570 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2571 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2572
393d71f3 2573 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2574 * fileio.c (Finsert_file_contents):
2575 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2576 Remove the old (too-loose) buffer overflow checks.
2577 They weren't needed, since make_gap checks for buffer overflow.
2578 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2579 The old code merely checked for Emacs fixnum overflow, and relied
2580 on undefined (wraparound) behavior. The new code avoids undefined
2581 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2582
2e6813b0 2583 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2584 Tune. Don't use wider integers than needed. Don't use alloca.
2585 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2586
599a9e4f
PE
2587 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2588
99561444
PE
2589 * insdel.c, lisp.h (buffer_overflow): New function.
2590 (insert_from_buffer_1, replace_range, replace_range_2):
2591 * insdel.c (make_gap_larger):
2592 * editfns.c (Finsert_char):
2593 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2594
28177add
PE
2595 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2596
e69dafad
PE
25972011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2598
a7af7fde 2599 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2600
b1c46f02
PE
2601 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2602 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2603
e69dafad
PE
2604 * fileio.c: Don't assume EMACS_INT fits in off_t.
2605 (emacs_lseek): New static function.
2606 (Finsert_file_contents, Fwrite_region): Use it.
2607 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2608
566684ea
PE
2609 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2610
e6966cd6
PE
2611 * fns.c: Don't overflow int when computing a list length.
2612 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2613 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2614 truncation on 64-bit hosts. Check for QUIT every
2615 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2616 faster and is responsive enough.
2617 (Flength): Report an error instead of overflowing an integer.
2618 (Fsafe_length): Return a float if the value is not representable
2619 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2620 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2621 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2622
dd0b0efb
PE
2623 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2624 (header_size, word_size): New constants.
2625 (allocate_vectorlike): Don't check size overflow here.
2626 (allocate_vector): Check it here instead, since this is the only
2627 caller of allocate_vectorlike that could cause overflow.
2628 Check that the new vector's length is representable as a fixnum.
2629
86fe5cfe
PE
2630 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2631 The previous code was bogus. For example, next_almost_prime (32)
2632 returned 39, which is undesirable as it is a multiple of 3; and
2633 next_almost_prime (24) returned 25, which is a multiple of 5 so
2634 why was the code bothering to check for multiples of 7?
2635
80e88859
PE
2636 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2637
4a2f0ad6
PE
2638 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2639
f66c7cf8
PE
2640 Variadic C functions now count arguments with ptrdiff_t.
2641 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2642 Back then I didn't know that the Emacs coding style prefers signed int.
2643 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2644 were being counted with int, which may truncate counts on 64-bit
2645 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2646 * lisp.h (struct Lisp_Subr.function.aMANY)
2647 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2648 Arg counts are now ptrdiff_t, not size_t.
2649 All variadic functions and their callers changed accordingly.
2650 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2651 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2652 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2653 * callint.c (Fcall_interactively): Check arg count for overflow,
2654 to avoid potential buffer overrun. Use signed char, not 'int',
2655 for 'varies' array, so that we needn't bother to check its size
2656 calculation for overflow.
2657 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2658 * eval.c (apply_lambda):
2659 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2660 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2661 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2662
a1759b76
PE
2663 * callint.c (Fcall_interactively): Don't use index var as event count.
2664
d96be9fc
PE
2665 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2666 * mem-limits.h (SIZE): Remove; no longer used.
2667
a690a978 2668 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2669
578c21e6
PE
2670 Remove unnecessary casts.
2671 * xterm.c (x_term_init):
2672 * xfns.c (x_set_border_pixel):
2673 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2674 These aren't needed now that we assume ANSI C.
2675
96f53c6c
PE
2676 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2677 It's more likely to cause problems (due to unsigned overflow)
2678 than to cure them.
2679
83c77d31
PE
2680 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2681
ee2079f1
PE
2682 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2683
6da65536
PE
2684 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2685
7147c4a4
PE
2686 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2687
193e32d9
PE
2688 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2689
e5533da6
PE
2690 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2691
9910e595
PE
2692 GLYPH_CODE_FACE returns EMACS_INT, not int.
2693 * dispextern.h (merge_faces):
2694 * xfaces.c (merge_faces):
01103c44
PE
2695 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2696 Don't assume EMACS_INT fits in int.
9910e595 2697
2638320e
PE
2698 * character.h (CHAR_VALID_P): Remove unused parameter.
2699 * fontset.c, lisp.h, xdisp.c: All uses changed.
2700
045eb8d9
PE
2701 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2702
c1f134b5
PE
2703 * fns.c (concat): Minor tuning based on overflow analysis.
2704 This doesn't fix any bugs. Use int to hold character, instead
2705 of constantly refetching from Emacs object. Use XFASTINT, not
2706 XINT, for value known to be a character. Don't bother comparing
2707 a single byte to 0400, as it's always less.
2708
395fcb93 2709 * floatfns.c (Fexpt):
327eeec8
PE
2710 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2711
abbd3d23
PE
2712 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2713 for characters.
2714
684a03ef
PE
2715 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2716
0fed43f3
PE
2717 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2718 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2719 incorrectly succeed when S was a string, because 4294967386 was
2720 truncated before it was used.
2721
8fd02eb7
PE
2722 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2723 Otherwise, an out-of-range integer could cause undefined behavior
2724 on a 64-bit host.
2725
f8c86b69
PE
2726 * composite.c: Use int, not EMACS_INT, for characters.
2727 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2728 EMACS_INT, for values that are known to be in character range.
2729 This doesn't fix any bugs but is the usual style inside Emacs and
2730 may generate better code on 32-bit machines.
2731
34206dd2
PE
2732 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2733 This is for reasons similar to the recent CHAR_STRING fix.
2734 * charset.c (Fencode_char): Check that character arg is actually
2735 a character. Pass an int to ENCODE_CHAR.
2736 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2737 wider than 'int', as a compile-time check to prevent future regressions
2738 in this area.
2739
c5958d4c 2740 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2741
2742 Make sure a 64-bit char is never passed to CHAR_STRING.
2743 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2744 by silently ignoring the top 32 bits, allowing some values
2745 that were far too large to be valid characters.
2746 * character.h: Include <verify.h>.
2747 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2748 arguments are no wider than unsigned, as a compile-time check
2749 to prevent future regressions in this area.
2750 * data.c (Faset):
01103c44 2751 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2752 (Fsubst_char_in_region):
2753 * fns.c (concat):
2754 * xdisp.c (decode_mode_spec_coding):
2755 Adjust to CHAR_STRING's new requirement.
2756 * editfns.c (Finsert_char, Fsubst_char_in_region):
2757 * fns.c (concat): Check that character args are actually
2758 characters. Without this test, these functions did the wrong
2759 thing with wildly out-of-range values on 64-bit hosts.
2760
d37ca623
PE
2761 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2762 These casts should not be needed on 32-bit hosts, either.
2763 * keyboard.c (read_char):
2764 * lread.c (Fload): Remove casts to unsigned.
2765
ea204efb
PE
2766 * lisp.h (UNSIGNED_CMP): New macro.
2767 This fixes comparison bugs on 64-bit hosts.
2768 (ASCII_CHAR_P): Use it.
2769 * casefiddle.c (casify_object):
01103c44 2770 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2771 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2772 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2773 * dispextern.h (FACE_FROM_ID):
2774 * keyboard.c (read_char): Use UNSIGNED_CMP.
2775
41cb286c
PE
2776 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2777 not to EMACS_INT, to avoid GCC warning.
2778
4a1b9832
PE
2779 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2780
55daad71
PE
2781 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2782 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2783 isn't needed on 32-bit machines.
8f95c75c 2784
01103c44
PE
2785 * buffer.c (Fgenerate_new_buffer_name):
2786 Use EMACS_INT for count, not int.
0ceccced 2787 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2788
2789 * data.c (Qcompiled_function): Now static.
2790
c6f072e7
PE
2791 * window.c (window_body_lines): Now static.
2792
20ce5912
PE
2793 * image.c (gif_load): Rename local to avoid shadowing.
2794
9c4c5f81
PE
2795 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2796 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2797 * alloc.c (make_save_value): Integer argument is now of type
2798 ptrdiff_t, not int.
2799 (mark_object): Use ptrdiff_t, not int.
2800 * lisp.h (pD): New macro.
2801 * print.c (print_object): Use it.
2802
c0c5c8ae
PE
2803 * alloc.c: Use EMACS_INT, not int, to count objects.
2804 (total_conses, total_markers, total_symbols, total_vector_size)
2805 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2806 (total_free_floats, total_floats, total_free_intervals)
2807 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2808 Now EMACS_INT, not int. All uses changed.
2809 (Fgarbage_collect): Compute overall total using a double, so that
2810 integer overflow is less likely to be a problem. Check for overflow
2811 when converting back to an integer.
5a25e253
PE
2812 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2813 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2814 These were 'int' variables that could overflow on 64-bit hosts;
2815 they were never used, so remove them instead of repairing them.
211a0b2a 2816 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2817 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2818 Previously, this ceilinged at INT_MAX, but that doesn't work on
2819 64-bit machines.
e46bb31a 2820 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2821
c78baabf 2822 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2823 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2824 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2825 when a (possibly-narrower) signed value would do just as well.
2826 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2827
c9d624c6
PE
2828 * alloc.c: Catch some string size overflows that we were missing.
2829 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2830 for convenience in STRING_BYTES_MAX.
2831 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2832 The definition here is exact; the one in lisp.h was approximate.
2833 (allocate_string_data): Check for string overflow. This catches
2834 some instances we weren't catching before. Also, it catches
2835 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2836 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2837 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2838
c9d624c6
PE
2839 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2840 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2841 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2842
353032ce
PE
2843 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2844
2bccce07
PE
2845 * alloc.c (Fmake_string): Check for out-of-range init.
2846
0ac30604
SM
28472011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2848
2849 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2850
c195f2de
JD
28512011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2852
2853 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2854 xg_get_default_scrollbar_width.
2855
2856 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2857 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2858 (style_changed_cb): Call update_theme_scrollbar_width and call
2859 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2860 all frames (Bug#8505).
2861 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2862 Call gtk_window_set_resizable if HAVE_GTK3.
2863 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2864 and height if HAVE_GTK3 (Bug#8505).
2865 (scroll_bar_width_for_theme): New variable.
2866 (update_theme_scrollbar_width): New function.
2867 (xg_get_default_scrollbar_width): Move code to
2868 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2869 (xg_initialize): Call update_theme_scrollbar_width.
2870
2871 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2872
2873 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2874
e10ac9f1
MR
28752011-06-12 Martin Rudalics <rudalics@gmx.at>
2876
2877 * frame.c (make_frame): Call other_buffer_safely instead of
2878 other_buffer.
2879
2880 * window.c (temp_output_buffer_show): Call display_buffer with
2881 second argument Vtemp_buffer_show_specifiers and reset latter
2882 immediately after the call.
2883 (Vtemp_buffer_show_specifiers): New variable.
2884 (auto_window_vscroll_p, next_screen_context_lines)
2885 (Vscroll_preserve_screen_position): Remove leading asterisks from
2886 doc-strings.
2887
2d3c217e 28882011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2889
7b7f97e8 2890 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2891 * buffer.c (Qclone_number): Remove for now, as it's unused.
2892 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2893 (record_buffer): Remove unused local.
2894 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2895 (set_frame_buffer_list): Remove; unused.
2896 * frame.h (other_visible_frames): Remove decl.
2897 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2898 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2899 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2900 if HAVE_GPM.
2901 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2902 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2903 Define only if HAVE_GPM.
2904 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2905 (update_hints_inhibit): Remove; never set. All uses removed.
2906 * widgetprv.h (emacsFrameClassRec): Remove decl.
2907 * window.c (delete_deletable_window): Now returns void, since it
2908 wasn't returning anything.
2909 (compare_window_configurations): Remove unused locals.
2910 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2911 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2912 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2913 the same widths as pointers. This follows up on the 2011-05-06 patch.
2914 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2915 * xterm.h: Likewise.
2916 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2917
1384b89e
JB
29182011-06-12 Juanma Barranquero <lekktu@gmail.com>
2919
2920 * makefile.w32-in: Update dependencies.
2921 (LISP_H): Add lib/intprops.h.
2922
1100a63c
CY
29232011-06-11 Chong Yidong <cyd@stupidchicken.com>
2924
2925 * image.c (gif_load): Add animation frame delay to the metadata.
2926 (syms_of_image): Use DEFSYM. New symbol `delay'.
2927
6198ccd0
MR
29282011-06-11 Martin Rudalics <rudalics@gmx.at>
2929
2930 * window.c (delete_deletable_window): Re-add.
2931 (Fset_window_configuration): Rewrite to handle dead buffers and
2932 consequently deletable windows.
2933 (window_tree, Fwindow_tree): Remove. Supply functionality in
2934 window.el.
2935 (compare_window_configurations): Simplify code.
2936
b6e3633c
AS
29372011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2938
1ab0dee5
AS
2939 * image.c (imagemagick_load_image): Fix type mismatch.
2940 (Fimagemagick_types): Likewise.
2941
b6e3633c
AS
2942 * window.h (replace_buffer_in_windows): Declare.
2943
9397e56f
MR
29442011-06-11 Martin Rudalics <rudalics@gmx.at>
2945
2946 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2947 Qclone_number. Remove external declaration of Qdelete_window.
2948 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2949 code.
640c8776
SM
2950 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2951 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2952 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2953 buffer list implementation.
2954 (other_buffer_safely): New function.
2955 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2956 calls to replace_buffer_in_windows and
2957 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2958 if allowed.
2959 (record_buffer): Inhibit quitting and rewrite using quittable
2960 functions. Run Qbuffer_list_update_hook if allowed.
2961 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2962 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2963 Move switch-to-buffer to window.el.
9397e56f
MR
2964 (bury-buffer): Move to window.el.
2965 (Vbuffer_list_update_hook): New variable.
2966
2967 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2968 section.
2969
2970 * window.h (resize_frame_windows): Move up in code.
2971 (Fwindow_frame): Remove EXFUN.
2972 (replace_buffer_in_all_windows): Remove prototype.
2973 (replace_buffer_in_windows_safely): Add prototype.
2974
2975 * window.c: Declare Qdelete_window static again. Move down
2976 declaration of select_count.
2977 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2978 (Fother_window): Move to window.el.
2979 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2980 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2981 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2982 window.el.
2983 (replace_buffer_in_windows): Implement by calling
2984 Qreplace_buffer_in_windows.
2985 (replace_buffer_in_all_windows): Remove with some functionality
2986 moved into replace_buffer_in_windows_safely.
2987 (replace_buffer_in_windows_safely): New function.
2988 (select_window_norecord, select_frame_norecord): Move in front
2989 of run_window_configuration_change_hook. Remove now obsolete
2990 declarations.
640c8776
SM
2991 (Fset_window_buffer): Rewrite doc-string.
2992 Call Qrecord_window_buffer.
9397e56f
MR
2993 (keys_of_window): Move binding for other-window to window.el.
2994
b50691aa
CY
29952011-06-11 Chong Yidong <cyd@stupidchicken.com>
2996
2997 * dispextern.h (struct image): Replace data member, whose int_val
2998 and ptr_val fields were not used by anything, with a single
2999 lisp_val object.
3000
3001 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3002 (gif_clear_image, gif_load, imagemagick_load_image)
3003 (gs_clear_image, gs_load): Callers changed.
3004
3f754b86
PE
30052011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3006
cca69397
PE
3007 * buffer.h: Include <time.h>, for time_t.
3008 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3009
109e28d0
PE
3010 Fix minor problems found by static checking.
3011
60737f02
PE
3012 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3013
4b66faf3
PE
3014 Make identifiers static if they are not used in other modules.
3015 * data.c (Qcompiled_function, Qframe, Qvector):
3016 * image.c (QimageMagick, Qsvg):
3017 * minibuf.c (Qmetadata):
3018 * window.c (resize_window_check, resize_root_window): Now static.
3019 * window.h (resize_window_check, resize_root_window): Remove decls.
3020
109e28d0
PE
3021 * window.c (window_deletion_count, delete_deletable_window):
3022 Remove; unused.
46a4ce9e
PE
3023 (window_body_lines): Now static.
3024 (Fdelete_other_windows_internal): Mark vars as initialized.
3025 Make sure 'resize_failed' is initialized.
3026 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3027 (resize_window_apply): Remove unused local.
3028 * window.h (delete_deletable_window): Remove decl.
3029
109e28d0 3030 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3031 (imagemagick_load_image): Fix pointer signedness problem by changing
3032 last arg from unsigned char * to char *. All uses changed.
3033 Also, fix a local for similar reasons.
3034 Remove unused locals. Remove locals to avoid shadowing.
3035 (fn_rsvg_handle_free): Remove; unused.
3036 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3037 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3038
3f754b86
PE
3039 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3040
2547adb1
CY
30412011-06-10 Chong Yidong <cyd@stupidchicken.com>
3042
3043 * image.c (gif_load): Fix omitted cast error introduced by
3044 2011-06-06 change.
3045
2c8e37d4
MR
30462011-06-10 Martin Rudalics <rudalics@gmx.at>
3047
3048 * window.h (resize_proportionally, orig_total_lines)
3049 (orig_top_line): Remove from window structure.
3050 (set_window_height, set_window_width, change_window_heights)
3051 (Fdelete_window): Remove prototypes.
3052 (resize_frame_windows): Remove duplicate declaration.
3053
440a42e3
EZ
30542011-06-10 Eli Zaretskii <eliz@gnu.org>
3055
3056 * window.h (resize_frame_windows, resize_window_check)
3057 (delete_deletable_window, resize_root_window)
3058 (resize_frame_windows): Declare prototypes.
3059
3060 * window.c (resize_window_apply): Make definition be "static" to
3061 match the prototype.
3062
562dd5e9
MR
30632011-06-10 Martin Rudalics <rudalics@gmx.at>
3064
3065 * window.c: Remove declarations of Qwindow_size_fixed,
3066 window_min_size_1, window_min_size_2, window_min_size,
3067 size_window, window_fixed_size_p, enlarge_window, delete_window.
3068 Remove static from declaration of Qdelete_window, it's
3069 temporarily needed by Fbury_buffer.
3070 (replace_window): Don't assign orig_top_line and
3071 orig_total_lines.
3072 (Fdelete_window, delete_window): Remove. Window deletion is
3073 handled by window.el.
640c8776
SM
3074 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3075 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3076 (Fdelete_other_windows): Remove. Deleting other windows is
3077 handled by window.el.
3078 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3079 handled in window.el.
3080 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3081 Window minimum sizes are handled in window.el.
3082 (shrink_windows, size_window, set_window_height)
3083 (set_window_width, change_window_heights, window_height)
3084 (window_width, CURBEG, CURSIZE, enlarge_window)
3085 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3086 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3087 handled in window.el.
3088 (make_dummy_parent): Rename to make_parent_window and give it a
3089 second argument horflag.
3090 (make_window): Don't set resize_proportionally any more.
3091 (Fsplit_window): Remove. Windows are split in window.el.
3092 (save_restore_action, save_restore_orig_size)
3093 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3094 Resize mini windows in window.el.
3095 (grow_mini_window, shrink_mini_window): Implement by calling
3096 Qresize_root_window_vertically, resize_window_check and
3097 resize_window_apply.
640c8776
SM
3098 (saved_window, Fset_window_configuration, save_window_save):
3099 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3100 resize_proportionally.
3101 (window_min_height, window_min_width): Move to window.el.
3102 (keys_of_window): Move bindings for delete-other-windows,
3103 split-window, delete-window and enlarge-window to window.el.
3104
3105 * buffer.c: Temporarily extern Qdelete_window.
3106 (Fbury_buffer): Temporarily call Qdelete_window instead of
3107 Fdelete_window (Fbury_buffer will move to window.el soon).
3108
3109 * frame.c (set_menu_bar_lines_1): Remove code handling
3110 orig_top_line and orig_total_lines.
3111
3112 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3113 set_window_height but set heights directly.
3114 (change_frame_size_1): Use resize_frame_windows.
3115
3116 * xdisp.c (init_xdisp): Don't use set_window_height but set
3117 heights directly.
3118
640c8776
SM
3119 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3120 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3121 run_window_configuration_change_hook.
3122
3123 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3124 instead of change_window_heights and run
3125 run_window_configuration_change_hook.
3126
1a13852e
MR
31272011-06-09 Martin Rudalics <rudalics@gmx.at>
3128
3129 * window.c (replace_window): Rename second argument REPLACEMENT to
3130 NEW. New third argument SETFLAG. Rewrite.
3131 (delete_window, make_dummy_parent): Call replace_window with
3132 third argument 1.
3133 (window_list_1): Move down in code.
3134 (run_window_configuration_change_hook): Move set_buffer part
3135 before select_frame_norecord part in order to unwind correctly.
3136 Rename count1 to count.
3137 (recombine_windows, delete_deletable_window, resize_root_window)
3138 (Fdelete_other_windows_internal)
3139 (Frun_window_configuration_change_hook, make_parent_window)
3140 (resize_window_check, resize_window_apply, Fresize_window_apply)
3141 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3142 (Fdelete_window_internal, Fresize_mini_window_internal):
3143 New functions.
1a13852e
MR
3144 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3145
f3d1777e
MR
31462011-06-08 Martin Rudalics <rudalics@gmx.at>
3147
496e208e
MR
3148 * window.h (window): Add some new members to window structure -
3149 normal_lines, normal_cols, new_total, new_normal, clone_number,
3150 splits, nest, prev_buffers, next_buffers.
3151 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3152 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3153
f3d1777e
MR
3154 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3155 Remove.
496e208e
MR
3156 (make_dummy_parent): Set new members of windows structure.
3157 (make_window): Move down in code. Handle new members of window
3158 structure.
3159 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3160 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3161 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3162 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3163 (Fset_window_next_buffers, Fset_window_clone_number):
3164 New functions.
496e208e
MR
3165 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3166 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3167 Doc-string fixes.
3168 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3169 Argument WINDOW can be now internal window too.
3170 (Fwindow_use_time): Move up in code.
3171 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3172 Rewrite doc-string.
3173 (Fset_window_configuration, saved_window)
3174 (Fcurrent_window_configuration, save_window_save): Handle new
3175 members of window structure.
b9e809c2
MR
3176 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3177 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3178 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3179 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3180 Qget_mru_window, Qresize_root_window,
3181 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3182 Qauto_buffer_name; staticpro them.
f3d1777e 3183
abde8f8c
MR
31842011-06-07 Martin Rudalics <rudalics@gmx.at>
3185
3186 * window.c (Fwindow_total_size, Fwindow_left_column)
3187 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3188 (Fwindow_list_1): New functions.
3189 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3190 (Fwindow_width, Fscroll_left, Fscroll_right):
3191 Use window_body_cols instead of window_box_text_cols.
3192 (delete_window, Fset_window_configuration):
3193 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3194 (delete_all_subwindows): Take a window as argument and not a
3195 structure. Rewrite.
190b47e6
MR
3196 (window_loop): Remove handling of GET_LRU_WINDOW and
3197 GET_LARGEST_WINDOW.
3198 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3199
3200 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3201 window_box_text_cols. delete_all_subwindows now takes a
3202 Lisp_Object as argument.
abde8f8c 3203
640c8776
SM
3204 * indent.c (compute_motion, Fcompute_motion):
3205 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3206
fa8a67e6
MR
3207 * frame.c (delete_frame): Call delete_all_subwindows with root
3208 window as argument.
3209
a54e3482
DC
32102011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3211
3212 * fns.c (Fputhash): Document return value.
3213
60002bf5
CY
32142011-06-06 Chong Yidong <cyd@stupidchicken.com>
3215
3216 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3217
0c671da6 32182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3219
b862a52a 3220 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3221
be44ca6c
PE
3222 Check for overflow when converting integer to cons and back.
3223 * charset.c (Fdefine_charset_internal, Fdecode_char):
3224 Use cons_to_unsigned to catch overflow.
3225 (Fencode_char): Use INTEGER_TO_CONS.
3226 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3227 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3228 * data.c (long_to_cons, cons_to_long): Remove.
3229 (cons_to_unsigned, cons_to_signed): New functions.
3230 These signal an error for invalid or out-of-range values.
3231 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3232 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3233 * font.c (Ffont_variation_glyphs):
3234 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3235 * lisp.h: Include <intprops.h>.
3236 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3237 (cons_to_signed, cons_to_unsigned): New decls.
3238 (long_to_cons, cons_to_long): Remove decls.
3239 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3240 (Fprimitive_undo): Use CONS_TO_INTEGER.
3241 * xfns.c (Fx_window_property): Likewise.
3242 * xselect.c: Include <limits.h>.
3243 (x_own_selection, selection_data_to_lisp_data):
3244 Use INTEGER_TO_CONS.
3245 (x_handle_selection_request, x_handle_selection_clear)
3246 (x_get_foreign_selection, Fx_disown_selection_internal)
3247 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3248 (lisp_data_to_selection_data): Use cons_to_unsigned.
3249 (x_fill_property_data): Use cons_to_signed.
3250 Report values out of range.
3251
d1f3d2af
PE
3252 Check for buffer and string overflow more precisely.
3253 * buffer.h (BUF_BYTES_MAX): New macro.
3254 * lisp.h (STRING_BYTES_MAX): New macro.
3255 * alloc.c (Fmake_string):
3256 * character.c (string_escape_byte8):
3257 * coding.c (coding_alloc_by_realloc):
3258 * doprnt.c (doprnt):
3259 * editfns.c (Fformat):
3260 * eval.c (verror):
3261 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3262 since they may not be the same number.
3263 * editfns.c (Finsert_char):
3264 * fileio.c (Finsert_file_contents):
3265 Likewise for BUF_BYTES_MAX.
3266
dd52fcea
PE
3267 * image.c: Use ptrdiff_t, not int, for sizes.
3268 (slurp_file): Switch from int to ptrdiff_t.
3269 All uses changed.
3270 (slurp_file): Check that file size fits in both size_t (for
3271 malloc) and ptrdiff_t (for sanity and safety).
3272
7f9bbdbb
PE
3273 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3274 if b->modtime has its maximal value.
3275
dfe18f82
PE
3276 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3277
84acfcf0
PE
3278 Don't assume time_t can fit into int.
3279 * buffer.h (struct buffer.modtime): Now time_t, not int.
3280 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3281 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3282
ccd9a01a
PE
3283 Minor fixes for signed vs unsigned integers.
3284 * character.h (MAYBE_UNIFY_CHAR):
3285 * charset.c (maybe_unify_char):
3286 * keyboard.c (read_char, reorder_modifiers):
3287 XINT -> XFASTINT, since the integer must be nonnegative.
3288 * ftfont.c (ftfont_spec_pattern):
3289 * keymap.c (access_keymap, silly_event_symbol_error):
3290 XUINT -> XFASTINT, since the integer must be nonnegative.
3291 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3292 since it makes no difference and we prefer signed.
3293 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3294 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3295 nonnegative.
3296
d6d100dd
SM
32972011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3298
3299 * window.h (Fwindow_frame): Declare.
3300
2b6148e4
PE
33012011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3302
3303 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3304 (SPARE_MEMORY): Always define.
3305 (LARGE_REQUEST): Remove.
3306 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3307
f230ecc9
MR
33082011-06-06 Martin Rudalics <rudalics@gmx.at>
3309
727e958e
MR
3310 * lisp.h: Move EXFUNS for Fframe_root_window,
3311 Fframe_first_window and Fset_frame_selected_window to window.h.
3312
3313 * window.h: Move EXFUNS for Fframe_root_window,
3314 Fframe_first_window and Fset_frame_selected_window here from
3315 lisp.h.
3316
3317 * frame.c (Fwindow_frame, Fframe_first_window)
3318 (Fframe_root_window, Fframe_selected_window)
3319 (Fset_frame_selected_window): Move to window.c.
3320 (Factive_minibuffer_window): Move to minibuf.c.
3321 (Fother_visible_frames_p): New function.
3322
3323 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3324
f230ecc9
MR
3325 * window.c (decode_window, decode_any_window): Move up in code.
3326 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3327 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3328 (Fwindow_buffer): Move up and rewrite doc-string.
3329 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3330 (Fwindow_prev): New functions.
727e958e
MR
3331 (Fwindow_frame): Move here from frame.c. Accept any window as
3332 argument.
3333 (Fframe_root_window, Fframe_first_window)
3334 (Fframe_selected_window): Move here from frame.c. Accept frame
3335 or arbitrary window as argument. Update doc-strings.
3336 (Fminibuffer_window): Move up in code.
3337 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3338 (Fset_frame_selected_window): Move here from frame.c.
3339 Marginal rewrite.
727e958e
MR
3340 (Fselected_window, select_window, Fselect_window): Move up in
3341 code. Minor doc-string fixes.
f230ecc9 3342
4d09bcf6
PE
33432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3346 Do not assume that spare memory exists; that assumption is valid
3347 only if SYSTEM_MALLOC.
3348 (LARGE_REQUEST): New macro, so that the issue of large requests
3349 is separated from the issue of spare memory.
3350
810928a2
AS
33512011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3352
172418ad
AS
3353 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3354 format. (Bug#8806)
3355
43f862f7
AS
3356 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3357
810928a2
AS
3358 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3359 before statements.
3360
a059fe24
JD
33612011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3362
3363 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3364
3365 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3366
3367 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3368 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3369
989bf368
JB
33702011-06-05 Juanma Barranquero <lekktu@gmail.com>
3371
3372 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3373
4b80f674
CY
33742011-06-04 Chong Yidong <cyd@stupidchicken.com>
3375
3376 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3377 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3378 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3379 New error handlers.
4b80f674
CY
3380 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3381 Obey Vx_select_enable_clipboard_manager. Catch errors in
3382 x_clipboard_manager_save (Bug#8779).
3383 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3384 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3385
99a33b77 33862011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3387
3388 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3389
99a33b77 33902011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3391
3392 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3393 in the current matrix if keep_current_p is non-zero.
3394
8264569d
EZ
33952011-06-04 Eli Zaretskii <eliz@gnu.org>
3396
3397 * bidi.c (bidi_level_of_next_char): Fix last change.
3398
57f97249
EZ
33992011-06-03 Eli Zaretskii <eliz@gnu.org>
3400
fec2107c 3401 Support bidi reordering of text covered by display properties.
57f97249 3402
fec2107c
EZ
3403 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3404 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3405 (bidi_cache_search, bidi_cache_iterator_state)
3406 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3407 (bidi_level_of_next_char, bidi_move_to_visually_next):
3408 Support character positions inside a run of characters covered by a
fec2107c
EZ
3409 display string.
3410 (bidi_paragraph_init, bidi_resolve_explicit_1)
3411 (bidi_level_of_next_char): Call bidi_fetch_char and
3412 bidi_fetch_char_advance instead of FETCH_CHAR and
3413 FETCH_CHAR_ADVANCE.
3414 (bidi_init_it): Initialize new members.
3415 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3416 definitions.
3417 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3418 instead of using explicit *_CHAR codes.
d6d100dd
SM
3419 (bidi_resolve_explicit, bidi_resolve_weak):
3420 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3421 bidirectional text is supported only in multibyte buffers.
3422 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3423 it to initialize the frame_window_p member of struct bidi_it.
3424 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3425 (bidi_resolve_explicit, bidi_resolve_weak)
3426 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3427 bidi_it->nchars is non-positive.
3428 (bidi_level_of_next_char): Don't try to lookup the cache for the
3429 next/previous character if nothing is cached there yet, or if we
3430 were just reseat()'ed to a new position.
c40e2fb2 3431
0e14fe90
EZ
3432 * xdisp.c (set_cursor_from_row): Set start and stop points
3433 according to the row's direction when priming the loop that looks
3434 for the glyph on which to display cursor.
3435 (single_display_spec_intangible_p): Function deleted.
3436 (display_prop_intangible_p): Reimplement to call
3437 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3438 Accept 3 additional arguments needed by handle_display_spec.
3439 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3440 values: lists, `(when COND...)' forms, etc.
3441 (single_display_spec_string_p): Support property values that are
3442 lists with the argument STRING its top-level element.
3443 (display_prop_string_p): Fix the condition for processing a
3444 property that is a list to be consistent with handle_display_spec.
fec2107c 3445 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3446 last portion of handle_display_prop.
3447 (compute_display_string_pos): Accept additional argument
3448 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3449 value of a `display' property is a "replacing spec".
3450 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3451 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3452 the display property, but just return a value indicating whether
3453 the display property will replace the characters it covers.
3454 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3455 frame_window_p members of struct bidi_it.
d6d100dd
SM
3456 (compute_display_string_pos, compute_display_string_end):
3457 New functions.
fec2107c
EZ
3458 (push_it): Accept second argument POSITION, where pop_it should
3459 jump to continue iteration.
3460 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3461
fec2107c
EZ
3462 * keyboard.c (adjust_point_for_property): Adjust the call to
3463 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3464
3465 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3466 (bidi_init_it): Update prototypes.
3467 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3468 (compute_display_string_pos, compute_display_string_end):
3469 Declare prototypes.
fec2107c
EZ
3470 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3471 EMACS_INT.
fc6f18ce 3472
40087514 34732011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3474
57f53182
PE
3475 Malloc failure behavior now depends on size of allocation.
3476 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3477 * lisp.h: Change signatures accordingly.
3478 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3479 All callers changed. (Bug#8762)
3480
3481 * gnutls.c: Use Emacs's memory allocators.
3482 Without this change, the gnutls library would invoke malloc etc.
3483 directly, which causes problems on non-SYNC_INPUT hosts, and which
3484 runs afoul of improving memory_full behavior. (Bug#8761)
3485 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3486 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3487 xfree instead of the default malloc, realloc, free.
3488 (Fgnutls_boot): No need to check for memory allocation failure,
3489 since xmalloc does that for us.
3490
ac32cd99 3491 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3492 * category.c (hash_get_category_set):
3493 * ccl.c (ccl_driver):
3494 * charset.c (Fdefine_charset_internal):
3495 * charset.h (struct charset.hash_index):
3496 * composite.c (get_composition_id, gstring_lookup_cache)
3497 (composition_gstring_put_cache):
3498 * composite.h (struct composition.hash_index):
3499 * dispextern.h (struct image.hash):
3500 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3501 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3502 (hashfn_equal, hashfn_user_defined, make_hash_table)
3503 (maybe_resize_hash_table, hash_lookup, hash_put)
3504 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3505 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3506 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3507 * image.c (make_image, search_image_cache, lookup_image)
3508 (xpm_put_color_table_h):
3509 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3510 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3511 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3512 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3513 * alloc.c (allocate_vectorlike):
3514 Check for overflow in vector size calculations.
3515 * ccl.c (ccl_driver):
3516 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3517 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3518 need to be updated by these changes.
40087514
PE
3519 * fns.c (make_hash_table, maybe_resize_hash_table):
3520 Check for integer overflow with large hash tables.
0de4bb68
PE
3521 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3522 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3523 (SXHASH_REDUCE): New macro.
3524 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3525 Use it instead of discarding useful hash info with large hash values.
3526 (sxhash_float): New function.
3527 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3528 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3529 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3530 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3531 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3532 Adjust signatures to match updated version of code.
3533 (consing_since_gc): Now EMACS_INT, since a single hash table can
3534 use more than INT_MAX bytes.
3535
698d32e2
DN
35362011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3537
3538 Make it possible to build with GCC-4.6+ -O2 -flto.
3539
3540 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3541
fd6fa53f
SM
35422011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3543
3544 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3545 Call minibuffer-inactive-mode.
3546
864db017
JB
35472011-05-31 Juanma Barranquero <lekktu@gmail.com>
3548
3549 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3550 Update dependencies.
3551
2ad0baf4
DN
35522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3553
3554 * data.c (init_data): Remove code for UTS, this system is not
3555 supported anymore.
3556
4fcc2638
DN
35572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3558
3559 Don't force ./temacs to start in terminal mode.
3560
3561 * frame.c (make_initial_frame): Initialize faces in all cases, not
3562 only when CANNOT_DUMP is defined.
3563 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3564
c56e0fd5
DN
35652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3566
3567 * dispnew.c (add_window_display_history): Use const for the string
3568 pointer. Remove declaration, not needed.
3569
333d54da 35702011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3571
55d4c1b2 3572 Use 'inline', not 'INLINE'.
333d54da 3573 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3574 * alloc.c, fontset.c (INLINE): Remove.
3575 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3576 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3577 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3578 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3579 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3580
738db178
DN
35812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3582
3583 Make it possible to run ./temacs.
3584
3585 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3586 syms_of_callproc does the same thing. Remove test for
3587 "initialized", do it in the caller.
3588 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3589
620c53a6
SM
35902011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3591
3592 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3593 (read_minibuf): Use get_minibuffer.
3594 (syms_of_minibuf): Use DEFSYM.
3595 (Qmetadata): New var.
3596 * data.c (Qbuffer): Don't make it static.
3597 (syms_of_data): Use DEFSYM.
3598
e003a292
PE
35992011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3600
3601 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3602 (CCL_CODE_MIN): New macro.
3603
ed008a6d
PE
36042011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3605
3687c2ef
PE
3606 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3607
ed008a6d
PE
3608 * eval.c (Qdebug): Now static.
3609 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3610 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3611 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3612
d66c4c7c
CY
36132011-05-29 Chong Yidong <cyd@stupidchicken.com>
3614
3615 * image.c: Various fixes to ImageMagick code comments.
3616 (Fimagemagick_types): Doc fix.
3617
5fbc2025
PE
36182011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3619
0196f88a
PE
3620 Minor fixes prompted by GCC 4.6.0 warnings.
3621
3622 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3623
5fbc2025
PE
3624 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3625 (x_clipboard_manager_save_all): Move extern decl to ...
3626 * xterm.h: ... here, so that it can be checked for consistency.
3627
1dd3c2d9
CY
36282011-05-29 Chong Yidong <cyd@stupidchicken.com>
3629
3630 * xselect.c (x_clipboard_manager_save_frame)
3631 (x_clipboard_manager_save_all): New functions.
3632 (Fx_clipboard_manager_save): Lisp function deleted.
3633
3634 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3635 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3636
3637 * xterm.h: Update prototype.
3638
5ba6571d
WX
36392011-05-28 William Xu <william.xwl@gmail.com>
3640
3641 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3642 exiting (Bug#8239).
3643
3eaff834
JM
36442011-05-28 Jim Meyering <meyering@redhat.com>
3645
e1900994 3646 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3647 * fns.c (to_uchar): Define.
3648 (crypto_hash_function): Use it to convert some newly-signed
3649 variables to unsigned, to avoid sign-extension bugs. For example,
3650 without this change, (md5 "truc") would evaluate to
3651 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3652 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3653 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3654
0f6990a7
PE
36552011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3656
3657 Integer overflow fixes.
c8a9ca5a 3658
08686060
PE
3659 * dbusbind.c: Serial number integer overflow fixes.
3660 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3661 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3662 to hold a serial number that is too large for a fixnum.
3663 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3664 Check for serial numbers out of range. Decode any serial number
59568bf0 3665 that was so large that it became a float. (Bug#8722)
08686060 3666
2d1fc3c7
PE
3667 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3668 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3669 Use XFASTINT rather than XUINT when numbers are nonnegative.
3670 (xd_append_arg, Fdbus_method_return_internal):
3671 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3672 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3673 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3674 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3675 (Bug#8722)
2d1fc3c7 3676
c8a9ca5a
PE
3677 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3678
519e1d69
PE
3679 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3680
30569699
PE
3681 ccl: add integer overflow checks
3682 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3683 (IN_INT_RANGE): New macros.
3684 (ccl_driver): Use them to check for integer overflow when
3685 decoding a CCL program. Many of the new checks are whether XINT (x)
3686 fits in int; it doesn't always, on 64-bit hosts. The new version
3687 doesn't catch all possible integer overflows, but it's an
847044ea 3688 improvement. (Bug#8719)
30569699 3689
c11285dc
PE
3690 * alloc.c (make_event_array): Use XINT, not XUINT.
3691 There's no need for unsigned here.
3692
fdccd48e
PE
3693 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3694 This follows up to the 2011-05-06 change that substituted uintptr_t
3695 for EMACS_INT. This case wasn't caught back then.
3696
37910ab2
PE
3697 Rework Fformat to avoid integer overflow issues.
3698 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3699 now (part of C89). Include <verify.h>.
3700 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3701 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3702 (Fformat): Avoid the prepass trying to compute sizes; it was only
3703 approximate and thus did not catch overflow reliably. Instead, walk
3704 through the format just once, formatting and computing sizes as we go,
3705 checking for integer overflow at every step, and allocating a larger
3706 buffer as needed. Keep track separately whether the format is
3707 multibyte. Keep only the most-recently calculated precision, rather
3708 than them all. Record whether each argument has been converted to
3709 string. Use EMACS_INT, not int, for byte and char and arg counts.
3710 Support field widths and precisions larger than INT_MAX. Avoid
3711 sprintf's undefined behavior with conversion specifications such as %#d
3712 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3713 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3714 formatting out-of-range floating point numbers with int
9173deec 3715 formats. (Bug#8668)
37910ab2 3716
2e6578fb
PE
3717 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3718
0ae6bdee
PE
3719 * data.c: Avoid integer truncation in expressions involving floats.
3720 * data.c: Include <intprops.h>.
3721 (arith_driver): When there's an integer overflow in an expression
3722 involving floating point, convert the integers to floating point
3723 so that the resulting value does not suffer from catastrophic
3724 integer truncation. For example, on a 64-bit host (* 4
3725 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3726 Do not rely on undefined behavior after integer overflow.
3727
de883a70
PE
3728 merge count_size_as_multibyte, parse_str_to_multibyte
3729 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3730 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3731 Check for integer overflow.
3732 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3733 since it's now a duplicate of the other. This is more of
3734 a character than a buffer op, so better that it's in character.c.
3735 * fns.c, print.c: Adjust to above changes.
3736
2ff916cb
PE
37372011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3738
3739 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3740
f1b54466
PE
37412011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3742
fb1ac845
PE
3743 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3744 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3745 (x_clipboard_manager_save): Now static.
3746 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3747
f1b54466
PE
3748 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3749 (crypto_hash_function): Now static.
3750 Fix pointer signedness problems. Avoid unnecessary initializations.
3751
a9f737ee
CY
37522011-05-27 Chong Yidong <cyd@stupidchicken.com>
3753
3754 * termhooks.h (Vselection_alist): Make it terminal-local.
3755
3756 * terminal.c (create_terminal): Initialize it.
3757
3758 * xselect.c: Support for clipboard managers.
3759 (Vselection_alist): Move to termhooks.h as terminal-local var.
3760 (LOCAL_SELECTION): New macro.
3761 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3762 (symbol_to_x_atom): Remove gratuitous arg.
3763 (x_handle_selection_request, lisp_data_to_selection_data)
3764 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3765 (x_own_selection, x_get_local_selection, x_convert_selection):
3766 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3767 (some_frame_on_display): Delete unused function.
3768 (Fx_own_selection_internal, Fx_get_selection_internal)
3769 (Fx_disown_selection_internal, Fx_selection_owner_p)
3770 (Fx_selection_exists_p): New optional frame arg.
3771 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3772 (x_handle_selection_clear): Don't treat other terminals with the
3773 same keyboard specially. Use the terminal-local Vselection_alist.
3774 (x_clear_frame_selections): Use Frun_hook_with_args.
3775
3776 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3777
3778 * xterm.h: Add support for those atoms.
3779
e067f0c1
CY
37802011-05-26 Chong Yidong <cyd@stupidchicken.com>
3781
3782 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3783 (converted_selections, conversion_fail_tag): New global variables.
3784 (x_selection_request_lisp_error): Free the above.
3785 (x_get_local_selection): Remove unnecessary code.
3786 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3787 of converted selections stored in converted_selections.
3788 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3789 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3790 (x_convert_selection): New function.
3791 (x_handle_selection_event): Simplify.
3792 (x_get_foreign_selection): Don't ignore incoming requests while
3793 waiting for an answer; this will fail when we implement
3794 SAVE_TARGETS, and seems unnecessary anyway.
3795 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3796 (Vx_sent_selection_functions): Doc fix.
3797
0f4aebc0
LL
37982011-05-26 Leo Liu <sdl.web@gmail.com>
3799
3800 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3801
e61124cd
YM
38022011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3803
3804 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3805
3806 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3807 for fringe update if it has periodic bitmap.
ac389d0c 3808 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3809 and fringe_bitmap_periodic_p.
3810
3811 * fringe.c (get_fringe_bitmap_data): New function.
3812 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3813 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3814 row. Mark glyph row for fringe update if periodicity changed.
3815
3816 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3817 for fringe update unless it has periodic bitmap.
3818
f16d9837
KH
38192011-05-25 Kenichi Handa <handa@m17n.org>
3820
3821 * xdisp.c (get_next_display_element): Set correct it->face_id for
3822 a static composition.
3823
e1b90ef6
LL
38242011-05-24 Leo Liu <sdl.web@gmail.com>
3825
3826 * deps.mk (fns.o):
3827 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3828
3829 * fns.c (crypto_hash_function, Fsha1): New function.
3830 (Fmd5): Use crypto_hash_function.
3831 (syms_of_fns): Add Ssha1.
3832
7400048f
PE
38332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3834
3835 * gnutls.c: Remove unused macros.
3836 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3837 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3838 Remove macros that are defined and never used.
3839 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3840
abb71cf4
CY
38412011-05-22 Chong Yidong <cyd@stupidchicken.com>
3842
3843 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3844 (Fx_get_selection_internal): Minor cleanup.
3845 (Fx_own_selection_internal): Rename arguments for consistency with
3846 select.el.
3847
6307db39
PE
38482011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3849
3850 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3851
f3d4e0a4
CY
38522011-05-22 Chong Yidong <cyd@stupidchicken.com>
3853
3854 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3855
4d8ade89
YM
38562011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3857
3858 * dispnew.c (scrolling_window): Don't exclude the case that the
3859 last enabled row in the desired matrix touches the bottom boundary.
3860
32078c8d
GM
38612011-05-21 Glenn Morris <rgm@gnu.org>
3862
3863 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3864 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3865 and add some more files.
32078c8d 3866
7285dc67
EZ
38672011-05-20 Eli Zaretskii <eliz@gnu.org>
3868
3869 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3870 report_file_error introduced by the change from 2011-05-07.
3871
89d1bd22
PE
38722011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3873
3874 * systime.h (Time): Define only if emacs is defined.
3875 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3876 where the include path doesn't have X11/X.h by default. See
3877 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3878
e23640bb 38792011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3880
3881 * composite.c (find_automatic_composition): Fix previous change.
3882
b9704ad9
GM
38832011-05-20 Glenn Morris <rgm@gnu.org>
3884
3885 * lisp.mk: New file, split from Makefile.in.
3886 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3887 (shortlisp): Remove.
3888 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3889
4a720484
GM
38902011-05-19 Glenn Morris <rgm@gnu.org>
3891
3892 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3893 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3894 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3895 (lisp): Set the order to that of loadup.el.
3896 (shortlisp): Make it a copy of $lisp.
3897 (SOME_MACHINE_LISP): Remove.
3898 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3899 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3900
a28d4396
KH
39012011-05-18 Kenichi Handa <handa@m17n.org>
3902
3903 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3904 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3905 (find_automatic_composition): Mostly rewrite for efficiency.
3906
a2b1fa8e
JB
39072011-05-18 Juanma Barranquero <lekktu@gmail.com>
3908
3909 * makefile.w32-in: Update dependencies.
3910
8e1f5610
CS
39112011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3912
3913 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3914 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3915
7025ee00 39162011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3917
cdfa6eab
PE
3918 Fix some integer overflow issues, such as string length overflow.
3919
06d6db33
PE
3920 * insdel.c (count_size_as_multibyte): Check for string overflow.
3921
2b4560a8
PE
3922 * character.c (lisp_string_width): Check for string overflow.
3923 Use EMACS_INT, not int, for string indexes and lengths; in
3924 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3925 the resulting string length overflows an EMACS_INT; instead,
3926 report a string overflow if no precision given. When checking for
3927 precision exhaustion, use a check that cannot possibly have
3928 integer overflow. (Bug#8675)
3929 * character.h (lisp_string_width): Adjust to new signature.
3930
cb93f9be
PE
3931 * alloc.c (string_overflow): New function.
3932 (Fmake_string): Use it. This doesn't change behavior, but saves
3933 a few bytes and will simplify future changes.
3934 * character.c (string_escape_byte8): Likewise.
3935 * lisp.h (string_overflow): New decl.
3936
1a1f3366
PE
3937 Fixups, following up to the user-interface timestamp change.
3938 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3939 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3940 * msdos.c (mouse_get_pos): Likewise.
3941 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3942 * w32gui.h (Time): Define by including "systime.h" rather than by
3943 declaring it ourselves. (Bug#8664)
3944
d4e3e4d3
PE
3945 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3946 * image.c (clear_image_cache): Likewise.
3947
f6a24d19
PE
3948 * term.c (term_mouse_position): Don't assume time_t wraparound.
3949
08dc5ae6
PE
3950 Be more systematic about user-interface timestamps.
3951 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3952 and sometimes 'EMACS_UINT', to represent these timestamps.
3953 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3954 This makes the code easier to follow, and makes it easier to catch
3955 integer overflow bugs such as Bug#8664.
3956 * frame.c (Fmouse_position, Fmouse_pixel_position):
3957 Use Time, not unsigned long, for user-interface timestamps.
3958 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3959 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3960 * keyboard.h (last_event_timestamp): Likewise.
3961 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3962 * menu.h (xmenu_show): Likewise.
3963 * term.c (term_mouse_position): Likewise.
3964 * termhooks.h (struct input_event.timestamp): Likewise.
3965 (struct terminal.mouse_position_hook): Likewise.
3966 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3967 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3968 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3969 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3970 what it was before.
3971 * menu.h, termhooks.h: Include "systime.h", for Time.
3972
8e55734a
PE
3973 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3974 Don't assume that the difference between two unsigned long values
3975 can fit into an integer. At this point, we know button_down_time
3976 <= event->timestamp, so the difference must be nonnegative, so
3977 there's no need to cast the result if double-click-time is
3978 nonnegative, as it should be; check that it's nonnegative, just in
3979 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3980 apart (about 25 days). (Bug#8664)
8e55734a 3981
841f1b75 3982 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3983 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3984
3e26f69c
PE
3985 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3986 that always fit in int. Use a sentinel instead of a counter, to
3987 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3988 * frame.h (struct frame): Use int for menu_bar_items_used
3989 instead of EMACS_INT, since it always fits in int.
3e26f69c 3990
5cc152c0
PE
3991 * menu.c (grow_menu_items): Check for int overflow.
3992
d89eb65e
PE
3993 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3994
5235bd3e
PE
3995 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3996 Before, the code was not consistent. These values cannot exceed
3997 2**31 - 1 so there's no need to make them unsigned.
3998 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3999 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4000 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4001 as modifiers.
4002 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4003
bc827e23
PE
4004 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4005 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4006 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4007 presumably because the widths might not match.
4008
78eb494e
PE
4009 * window.c (size_window): Avoid needless test at loop start.
4010
04f2d78b
CB
40112011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4012
4013 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4014
d2fc7e3d 40152011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4016
4017 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4018
d2fc7e3d 40192011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4020
4021 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4022 `width' to `bar_area_x' and `bar_area_width', respectively.
4023 (x_scroll_run): Take account of fringe background extension.
4024
04f2d78b
CB
4025 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4026 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4027 `bar_area_width', respectively.
4028 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4029 background extension.
4030
79b70037
GM
40312011-05-10 Jim Meyering <meyering@redhat.com>
4032
4033 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4034
2f142cc5
JB
40352011-05-10 Juanma Barranquero <lekktu@gmail.com>
4036
4037 * image.c (Finit_image_library): Return t for built-in image types,
4038 like pbm and xbm. (Bug#8640)
4039
57679c86
AS
40402011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4041
4042 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4043
888c9e86
EZ
40442011-05-07 Eli Zaretskii <eliz@gnu.org>
4045
b0512a1d
EZ
4046 * w32console.c (Fset_screen_color): Doc fix.
4047 (Fget_screen_color): New function.
4048 (syms_of_ntterm): Defsubr it.
4049
7285dc67
EZ
4050 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4051 unlink the temporary file if Fcall_process didn't create it in the
4052 first place.
4053 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4054 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4055 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4056 cue to call_process_cleanup not to close that handle.
4057
4d3fcc8e
BK
40582011-05-07 Ben Key <bkey76@gmail.com>
4059
4060 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4061 one of two shell specific rules, either bootstrap-temacs-CMD or
4062 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4063 to the previous implementation of the bootstrap-temacs rule.
4064 The bootstrap-temacs-CMD rule is similar to the previous
4065 implementation of the bootstrap-temacs rule except that it
4066 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4067 variable.
4068
4069 These changes, along with some changes to nt/configure.bat,
4070 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4071 earlier fix to add support for --cflags and --ldflags options
4072 that include quotes so that it works whether make uses cmd or
4073 sh as the shell.
4074
b4289b64
MA
40752011-05-06 Michael Albinus <michael.albinus@gmx.de>
4076
4077 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4078 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4079 is a constant.
4080 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4081 a string. Handle both cases.
4082 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4083 (Fdbus_register_method): Use Qinvalid_function.
4084
af4c0e28
JB
40852011-05-06 Juanma Barranquero <lekktu@gmail.com>
4086
4087 * makefile.w32-in: Update dependencies.
4088 (LISP_H): Add inttypes.h and stdin.h.
4089 (PROCESS_H): Add unistd.h.
4090
c51453d9
EZ
40912011-05-06 Eli Zaretskii <eliz@gnu.org>
4092
4093 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4094 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4095
8ff0ac3c 40962011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4097
4c4b566b
PE
4098 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4099
aab2b9b5
PE
4100 * term.c (vfatal): Remove stray call to va_end.
4101 It's not needed and the C Standard doesn't allow it here anyway.
4102
c378da0b
PE
4103 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4104 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4105
288b08c7
PE
4106 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4107 bytes.
4108
e3601888
PE
4109 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4110
db6c0e74
PE
4111 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4112
dd5963ea
PE
4113 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4114
88c9450f
PE
4115 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4116
2f9442b8
PE
4117 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4118
c032b5f8
PE
4119 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4120 * charset.c (Fdefine_charset_internal): Don't initialize
4121 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4122 32-bit int (Bug#8600).
a108c10b
PE
4123
4124 * lread.c (read_integer): Be more consistent with string-to-number.
4125 Use string_to_number to do the actual conversion; this avoids
4126 rounding errors and fixes some other screwups. Without this fix,
4127 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4128 (digit_to_number): Move earlier, for benefit of read_integer.
4129 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4130 not a digit in any supported base. (Bug#8602)
a108c10b 4131
ad5f9eea
PE
4132 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4133
aec1708a
PE
4134 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4135 to match comment at start of function. This also removes a
4136 GCC warning about overflow in a 32+64-bit port.
4137
47be4ab5
PE
4138 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4139
371cac43
PE
4140 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4141 Reported by Stefan Monnier in
4142 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4143 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4144 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4145
d01a7826
PE
4146 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4147 (EMACS_UINTPTR): Likewise, with uintptr_t.
4148
7fd47d5c
PE
4149 * lisp.h: Prefer 64-bit EMACS_INT if available.
4150 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4151 on 32-bit hosts that have 64-bit int, so that they can access
4152 large files.
122b0c86
PE
4153 However, temporarily disable this change unless the temporary
4154 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4155
8727937b
PE
4156 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4157
8ac068ac
PE
4158 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4159 This removes an assumption that EMACS_INT and long are the same
4160 width as pointers. The assumption is true for Emacs porting targets
4161 now, but we want to make other targets possible.
4162 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4163 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4164 In the rest of the code, change types of integers that hold casted
4165 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4166 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4167 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4168 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4169 No need to cast type when ORing.
4170 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4171 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4172 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4173 assume EMACS_INT is the same width as char *.
4174 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4175 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4176 Remove no-longer-needed casts.
4177 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4178 (xg_tool_bar_help_callback, xg_make_tool_item):
4179 Use EMACS_INTPTR to hold an integer
4180 that will be cast to void *; this can avoid a GCC warning
4181 if EMACS_INT is not the same width as void *.
4182 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4183 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4184 (current_message_1, set_message_1):
4185 Use a local to convert to proper width without a cast.
4186 * xmenu.c (dialog_selection_callback): Likewise.
4187
ede49d71
PE
4188 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4189 Also, don't assume VALBITS / RAND_BITS is less than 5,
4190 and don't rely on undefined behavior when shifting a 1 left into
4191 the sign bit.
4192 * lisp.h (get_random): Change signature to match.
4193
2f30ecd0
PE
4194 * lread.c (hash_string): Use size_t, not int, for hash computation.
4195 Normally we prefer signed values; but hashing is special, because
4196 it's better to use unsigned division on hash table sizes so that
4197 the remainder is nonnegative. Also, size_t is the natural width
4198 for hashing into memory. The previous code used 'int', which doesn't
4199 retain enough info to hash well into very large tables.
4200 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4201
2a866e7b
PE
4202 * dbusbind.c: Don't possibly lose pointer info when converting.
4203 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4204 Use XPNTR rather than XHASH, so that the high-order bits of
4205 the pointer aren't lost when converting through void *.
4206
51639eac
PE
4207 * eval.c (Fautoload): Don't double-shift a pointer.
4208
92394119
PE
4209 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4210
dbdb9a7c
JB
42112011-05-06 Juanma Barranquero <lekktu@gmail.com>
4212
4213 * gnutls.c (DEF_GNUTLS_FN):
4214 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4215
db7a0b4f
AS
42162011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4217
4218 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4219 marker. (Bug#8610)
4220
f7ff1b0f 42212011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4222
4223 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4224 New version that can reserve upto 2GB of heap space.
4225
f7ff1b0f 42262011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4227
4228 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4229
639c109b
TZ
42302011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4231
4232 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4233 `gnutls_certificate_set_x509_key_file'.
4234
d2127135
JB
42352011-05-05 Juanma Barranquero <lekktu@gmail.com>
4236
4237 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4238 Update dependencies.
4239
e968f4f3
JB
42402011-05-04 Juanma Barranquero <lekktu@gmail.com>
4241
4242 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4243 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4244 Remove unused parameter `fildes'.
4245 * process.c (read_process_output, send_process): Don't pass it.
4246
84d358f0
JB
42472011-05-04 Juanma Barranquero <lekktu@gmail.com>
4248
4249 Fix previous change: the library cache is defined in w32.c.
4250 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4251 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4252
0898ca10
JB
42532011-05-04 Juanma Barranquero <lekktu@gmail.com>
4254
4255 Implement dynamic loading of GnuTLS on Windows.
4256
4257 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4258 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4259 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4260 Declare.
4261
4262 * gnutls.c (Qgnutls_dll): Define.
4263 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4264 (gnutls_*): Declare function pointers.
4265 (init_gnutls_functions): New function to initialize function pointers.
4266 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4267 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4268 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4269 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4270 (emacs_gnutls_write, emacs_gnutls_read)
4271 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4272 (Fgnutls_available_p): New function.
4273 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4274 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4275 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4276
4277 * image.c: Include w32.h.
4278 (Vimage_type_cache): Delete.
4279 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4280 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4281 (w32_delayed_load): Move to w32.c.
4282
4283 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4284
4285 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4286 (w32_delayed_load): Move from image.c. When loading a library, record
4287 its filename in the :loaded-from property of the library id.
4288 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4289 Initialize and staticpro them.
4290 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4291
4292 * process.c: Include lisp.h before w32.h, not after.
4293 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4294 instead of gnutls_record_check_pending.
4295
4296 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4297
ff4de4aa
TZ
42982011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4299
4300 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4301 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4302 as passed in.
4303
abe95abb
JD
43042011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4305
4306 * xterm.c (x_set_frame_alpha): Do not set property on anything
4307 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4308
e16e55d4
JB
43092011-05-02 Juanma Barranquero <lekktu@gmail.com>
4310
4311 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4312
bafcf6a5
JB
43132011-05-02 Juanma Barranquero <lekktu@gmail.com>
4314
4315 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4316 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4317 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4318 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4319 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4320 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4321 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4322 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4323 (Qgnutls_bootprop_callbacks_verify): Make static.
4324
e7a6747f
AS
43252011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4326
19ed11ba
AS
4327 * callproc.c: Indentation fixup.
4328
e7a6747f 4329 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4330 (wait_for_termination, interruptible_wait_for_termination):
4331 Move after wait_for_termination_1.
e7a6747f 4332
1ef14cb4
LMI
43332011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4334
4335 * sysdep.c (interruptible_wait_for_termination): New function
4336 which is like wait_for_termination, but allows keyboard
4337 interruptions.
4338
4339 * callproc.c (Fcall_process): Add (:file "file") as an option for
4340 the STDOUT buffer.
4341 (Fcall_process_region): Ditto.
4342
330d880c
EZ
43432011-04-30 Eli Zaretskii <eliz@gnu.org>
4344
8db90b73
EZ
4345 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4346 rather than `XVECTOR (FOO)->size'.
4347
330d880c
EZ
4348 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4349 inttypes.h, as a gnulib replacement is used if it not available in
4350 system headers.
4351
15cbd324
EZ
43522011-04-21 Eli Zaretskii <eliz@gnu.org>
4353
4354 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4355 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4356 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4357
4358 * coding.c (coding_alloc_by_realloc): Error out if destination
4359 will grow beyond MOST_POSITIVE_FIXNUM.
4360 (decode_coding_emacs_mule): Abort if there isn't enough place in
4361 charbuf for the composition carryover bytes. Reserve an extra
4362 space for up to 2 characters produced in a loop.
4363 (decode_coding_iso_2022): Abort if there isn't enough place in
4364 charbuf for the composition carryover bytes.
4365
43662011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4367
ae940cca
EZ
4368 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4369 aborting when %lld or %lll format is passed.
4370 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4371 %llo or %llx format is passed. (Bug#8545)
4372
03ab8921
EZ
4373 * window.c (window_scroll_line_based): Use a marker instead of
4374 simple variables to record original value of point. (Bug#7952)
4375
afda1437
EZ
4376 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4377 produced by %s or %c overflows available buffer space. (Bug#8545)
4378
f76dee0c
PE
43792011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4380
4381 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4382 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4383
fdc5744d
JB
43842011-04-28 Juanma Barranquero <lekktu@gmail.com>
4385
4386 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4387
638f053a
JB
43882011-04-28 Juanma Barranquero <lekktu@gmail.com>
4389
4390 * keyboard.c (Qdelayed_warnings_hook): Define.
4391 (command_loop_1): Run `delayed-warnings-hook'
4392 if Vdelayed_warnings_list is non-nil.
4393 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4394 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4395
d178f871
EZ
43962011-04-28 Eli Zaretskii <eliz@gnu.org>
4397
4398 * doprnt.c (doprnt): Don't return value smaller than the buffer
4399 size if the message was truncated. (Bug#8545).
4400
b124fd93
JB
44012011-04-28 Juanma Barranquero <lekktu@gmail.com>
4402
4403 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4404 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4405
e810457d
PE
44062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4407
4408 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4409
ea51cceb
JB
44102011-04-27 Juanma Barranquero <lekktu@gmail.com>
4411
4412 * makefile.w32-in: Update dependencies.
4413
94dcfacf
EZ
44142011-04-27 Eli Zaretskii <eliz@gnu.org>
4415
4416 Improve `doprnt' and its usage. (Bug#8545)
4417 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4418 `format_end'. Remove support for %l as a conversion specifier.
4419 Don't use xrealloc. Improve diagnostics when the %l size modifier
4420 is used. Update the commentary.
4421
4422 * eval.c (verror): Simplify calculation of size_t.
4423
4424 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4425 messages.
4426
f61f41d7
PE
44272011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4428
4429 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4430 change.
4431
96fb4434
PE
44322011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4433
4434 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4435 This makes this file independent of the recent pseudovector change.
4436
671875da 44372011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4438
69e9b5a3
PE
4439 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4440
b5f869a7 4441 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4442 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4443 Remove unused local.
c8926152 4444 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4445
841a1577 4446 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4447 GCC 4.6.0 optimizes based on type-based alias analysis.
4448 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4449 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4450 != &v->size, and therefore "v->size = 1; b->size = 2; return
4451 v->size;" must therefore return 1. This assumption is incorrect
4452 for Emacs, since it type-puns struct Lisp_Vector * with many other
4453 types. To fix this problem, this patch adds a new type struct
f904488f 4454 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4455 and pseudovectors, and helps optimizing compilers not get fooled
4456 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4457 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4458 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4459 the size member.
eab3844f
PE
4460 (XSETPVECTYPE): Rewrite in terms of new macro.
4461 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4462 This is a bit clearer, and further avoids the possibility of
4463 undesirable aliasing.
4464 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4465 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4466 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4467 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4468 (ASIZE): Now uses header.size rather than size.
4469 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4470 to avoid the hassle of writing XVECTOR (foo)->header.size.
4471 (struct vectorlike_header): New type.
eab3844f
PE
4472 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4473 object, to help avoid aliasing.
4474 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4475 (SUBRP): Likewise, since Lisp_Subr is a special case.
4476 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4477 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4478 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4479 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4480 changed to be "header.size" and "header.next".
4481 * buffer.h (struct buffer): Likewise.
4482 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4483 * frame.h (struct frame): Likewise.
4484 * process.h (struct Lisp_Process): Likewise.
4485 * termhooks.h (struct terminal): Likewise.
4486 * window.c (struct save_window_data, struct saved_window): Likewise.
4487 * window.h (struct window): Likewise.
4488 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4489 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4490 * buffer.c (init_buffer_once): Likewise.
4491 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4492 special case.
4493 * process.c (Fformat_network_address): Use local var for size,
4494 for brevity.
4495
0df1eac5
PE
4496 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4497
847ab9d1 4498 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4499 * data.c (atof): Remove decl; no longer used or needed.
4500 (digit_to_number): Move to lread.c.
4501 (Fstring_to_number): Use new string_to_number function, to be
4502 consistent with how the Lisp reader treats infinities and NaNs.
4503 Do not assume that floating-point numbers represent EMACS_INT
4504 without losing information; this is not true on most 64-bit hosts.
4505 Avoid double-rounding errors, by insisting on integers when
4506 parsing non-base-10 numbers, as the documentation specifies.
4507 * lisp.h (string_to_number): New decl, replacing ...
4508 (isfloat_string): Remove.
bc0a5c13 4509 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4510 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4511 appears to have been a coding error. Similarly, do not accept
4512 strings like +-1e0 as floating point numbers. Do not report
4513 overflow for integer overflows unless the base is not 10 which
4514 means we have no simple and reliable way to continue.
4515 Break out the floating-point parsing into a new
4516 function string_to_number, so that Fstring_to_number parses
4517 floating point numbers consistently with the Lisp reader.
04f2d78b 4518 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4519 (E_CHAR, EXP_INT): Remove, replacing with ...
4520 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4521 (string_to_number): New function, replacing isfloat_string.
4522 This function checks for valid syntax and produces the resulting
4523 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4524 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4525 so that overflow for non-base-10 numbers is reported only when
4526 there's no portable and simple way to convert to floating point.
452f4150 4527
67769ffc
PE
4528 * textprop.c (set_text_properties_1): Rewrite for clarity,
4529 and to avoid GCC warning about integer overflow.
4530
c20db43f
PE
4531 * intervals.h (struct interval): Use EMACS_INT for members
4532 where EMACS_UINT might cause problems. See
4533 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4534 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4535 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4536 All uses changed.
37aa2f85
PE
4537 (offset_intervals): Tell GCC not to worry about length overflow
4538 when negating a negative length.
c20db43f 4539
2538aa2f
PE
4540 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4541 (overrun_check_free): Likewise.
4542
f2d3008d
PE
4543 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4544 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4545 word size.
4546
ec8df744
PE
4547 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4548 (gnutls_make_error): Rename local to avoid shadowing.
4549 (gnutls_emacs_global_deinit): ifdef out; not used.
4550 (Fgnutls_boot): Use const for pointer to readonly storage.
4551 Comment out unused local. Fix pointer signedness problems.
4552
640ee02d
PE
4553 * lread.c (openp): Don't stuff size_t into an 'int'.
4554 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4555 about possible signed overflow.
4556
6048fb2a
PE
4557 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4558 (GDK_KEY_g): Don't define if already defined.
4559 (xg_prepare_tooltip): Avoid pointer signedness problem.
4560 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4561
fa3c87e1
PE
4562 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4563 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4564
2172544b
PE
4565 * xfns.c (Fx_window_property): Simplify a bit,
4566 to make a bit faster and to avoid GCC 4.6.0 warning.
4567 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4568
9b821a21
PE
4569 * fns.c (internal_equal): Don't assume size_t fits in int.
4570
3c616cfa
PE
4571 * alloc.c (compact_small_strings): Tighten assertion a little.
4572
c2982e87
PE
4573 Replace pEd with more-general pI, and fix some printf arg casts.
4574 * lisp.h (pI): New macro, generalizing old pEd macro to other
4575 conversion specifiers. For example, use "...%"pI"d..." rather
4576 than "...%"pEd"...".
4577 (pEd): Remove. All uses replaced with similar uses of pI.
4578 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4579 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4580 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4581 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4582 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4583 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4584 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4585 64-bit hosts.
4586 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4587 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4588 * print.c (safe_debug_print, print_object): Likewise.
4589 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4590 to int.
6f04d126
PE
4591 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4592 avoiding the 0 flag, which is not portable.
c2982e87
PE
4593 * process.c (Fmake_network_process): Use pI to avoid cast.
4594 * region-cache.c (pp_cache): Likewise.
4595 * xdisp.c (decode_mode_spec): Likewise.
4596 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4597 behavior on 64-bit hosts with printf arg.
6f04d126 4598 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4599 (x_stop_queuing_selection_requests): Likewise.
4600 (x_get_window_property): Don't truncate byte count to an 'int'
4601 when tracing.
0b432f21 4602
5e073ec7
PE
4603 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4604 here, since it parses constructs like leading '-' and spaces,
4605 which are not wanted; and it overflows with large numbers.
4606 Instead, simply match F[0-9]+, which is what is wanted anyway.
4607
36372bf9
PE
4608 * alloc.c: Remove unportable assumptions about struct layout.
4609 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4610 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4611 (allocate_vectorlike, make_pure_vector): Use the new macros,
4612 plus offsetof, to remove unportable assumptions about struct layout.
4613 These assumptions hold on all porting targets that I know of, but
4614 they are not guaranteed, they're easy to remove, and removing them
4615 makes further changes easier.
4616
0b432f21
PE
4617 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4618 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4619 (string_overrun_cookie): Now const. Use initializers that
4620 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4621 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4622 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4623 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4624 multiple of sizeof (EMACS_INT); it need not be, if
4625 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4626 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4627
895009e1
JB
46282011-04-26 Juanma Barranquero <lekktu@gmail.com>
4629
4630 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4631
6a7a1b0b
TZ
46322011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4633
4634 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4635 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4636 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4637
841a1577 46382011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4639
4640 * lisp.h (Qdebug): List symbol.
895009e1 4641 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4642 * keyboard.c (debug-on-event): New variable.
4643 (handle_user_signal): Break into debugger when debug-on-event
4644 matches the current signal symbol.
4645
f2d3ba6f
DN
46462011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4647
4648 * alloc.c (check_sblock, check_string_bytes)
4649 (check_string_free_list): Convert to standard C.
4650
42ce4c63
TZ
46512011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4652
4653 * w32.c (emacs_gnutls_push): Fix typo.
4654
825cd63c
EZ
46552011-04-25 Eli Zaretskii <eliz@gnu.org>
4656
fb11d64d
EZ
4657 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4658 "cast to pointer from integer of different size".
4659
825cd63c
EZ
4660 Improve doprnt and its use in verror. (Bug#8545)
4661 * doprnt.c (doprnt): Document the set of format control sequences
4662 supported by the function. Use SAFE_ALLOCA instead of always
4663 using `alloca'.
4664
4665 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4666 is one byte too soon. Don't use xrealloc; instead xfree and
4667 xmalloc anew.
4668
e061a11b
TZ
46692011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4670
4671 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4672 callbacks stage.
4673
4674 * gnutls.c: Renamed global_initialized to
4675 gnutls_global_initialized. Added internals for the
4676 :verify-hostname-error, :verify-error, and :verify-flags
4677 parameters of `gnutls-boot' and documented those parameters in the
4678 docstring. Start callback support.
9173deec
JB
4679 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4680 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4681 on error. Return error code.
e061a11b
TZ
4682 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4683 (emacs_gnutls_read): Likewise.
4684 (Fgnutls_boot): Return handshake error code.
4685 (emacs_gnutls_handle_error): New function.
4686 (wsaerror_to_errno): Likewise.
4687
4688 * w32.h (emacs_gnutls_pull): Add prototype.
4689 (emacs_gnutls_push): Likewise.
4690
4691 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4692 (emacs_gnutls_push): Likewise.
4693
46942011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4695
4696 * process.c (wait_reading_process_output): Check if GnuTLS
4697 buffered some data internally if no FDs are set for TLS
4698 connections.
4699
4700 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4701 (LIBS): Link to USER_LIBS.
4702 ($(BLD)/gnutls.$(0)): New target.
4703
fa6996bc
EZ
47042011-04-24 Eli Zaretskii <eliz@gnu.org>
4705
eb35682e
EZ
4706 * xdisp.c (handle_single_display_spec): Rename the
4707 display_replaced_before_p argument into display_replaced_p, to
4708 make it consistent with the commentary. Fix typos in the
4709 commentary.
4710
e2ad650c
EZ
4711 * textprop.c (syms_of_textprop): Remove dead code.
4712 (copy_text_properties): Delete obsolete commentary about an
4713 interface that was deleted long ago. Fix typos in the description
4714 of arguments.
4715
1b2de274
EZ
4716 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4717 to changes in oldXMenu/XMenu.h from 2011-04-16.
4718 <menu_help_message, prev_menu_help_message>: Constify.
4719 (IT_menu_make_room): menu->help_text is now `const char **';
4720 adjust.
4721
4722 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4723 to changes in oldXMenu/XMenu.h from 2011-04-16.
4724 (struct XMenu): Declare `help_text' `const char **'.
4725
4726 * xfaces.c <Qunspecified>: Make extern again.
4727
4728 * syntax.c: Include sys/types.h before including regex.h, as
4729 required by Posix.
4730
762b15be
EZ
4731 * doc.c (get_doc_string): Improve the format passed to `error'.
4732
4733 * doprnt.c (doprnt): Improve commentary.
4734
4735 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4736
4737 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4738 them with etags.
4739
f1052e5d
EZ
4740 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4741 changes in globals.h immediately force recompilation.
762b15be
EZ
4742 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4743 $(CURDIR)/s/ms-w32.h.
4744 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4745
fa6996bc
EZ
4746 * character.c (Fchar_direction): Function deleted.
4747 (syms_of_character): Don't defsubr it.
4748 <char-direction-table>: Deleted.
4749
e6c3da20
EZ
47502011-04-23 Eli Zaretskii <eliz@gnu.org>
4751
4752 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4753 * doprnt.c: Include limits.h.
4754 (SIZE_MAX): New macro.
04f2d78b
CB
4755 (doprnt): Return a size_t value. 2nd arg is now size_t.
4756 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4757 Improve overflow protection. Support `l' modifier for integer
4758 conversions. Support %l conversion. Don't assume an EMACS_INT
4759 argument for integer conversions and for %c.
4760
4761 * lisp.h (doprnt): Restore prototype.
4762
4763 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4764 $(SRC)/character.h.
4765
4766 * Makefile.in (base_obj): Add back doprnt.o.
4767
4768 * deps.mk (doprnt.o): Add back prerequisites.
4769 (callint.o): Depend on character.h.
4770
4771 * eval.c (internal_lisp_condition_case): Include the handler
4772 representation in the error message.
4773 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4774 when breaking from the loop.
4775
4776 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4777
4778 * callint.c (Fcall_interactively): When displaying error message
4779 about invalid control letter, pass the character's codepoint, not
4780 a pointer to its multibyte form. Improve display of the character
4781 in octal and display also its hex code.
4782
4783 * character.c (char_string): Use %x to display the (unsigned)
4784 codepoint of an invalid character, to avoid displaying a bogus
4785 negative value.
4786
4787 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4788 `error', not SYMBOL_NAME itself.
4789
4790 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4791 character arguments to `error'.
4792
4793 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4794 to `error' in error message about FINAL_CHAR argument. Make sure
4795 FINAL_CHAR is a character, and use %c when it is passed as
4796 argument to `error'.
4797
4ffd0d6b 47982011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4799
4800 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4801
4802 * w32.c: Include <time.h>.
4803 (sys_localtime): New function.
4804
4ffd0d6b 48052011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4806
4807 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4808
4ffd0d6b 4809 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4810
4ffd0d6b 48112011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4812
4ffd0d6b
GM
4813 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4814 zombies (Bug#8467).
aac0c6e3 4815
04c56954
EZ
48162011-04-19 Eli Zaretskii <eliz@gnu.org>
4817
4818 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4819 gl_state.e_property when gl_state.object is Qt.
4820
4821 * insdel.c (make_gap_larger): Remove limitation of buffer size
4822 to <= INT_MAX.
4823
16a43933
CY
48242011-04-18 Chong Yidong <cyd@stupidchicken.com>
4825
4826 * xdisp.c (lookup_glyphless_char_display)
4827 (produce_glyphless_glyph): Handle cons cell entry in
4828 glyphless-char-display.
4829 (Vglyphless_char_display): Document it.
4830
4831 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4832 glyphless-char-display.
4833
4581706e
CY
48342011-04-17 Chong Yidong <cyd@stupidchicken.com>
4835
4836 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4837
4838 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4839
4840 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4841 definition for no-X builds.
4842
4887c6e2 48432011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4844
fd35b6f9
PE
4845 Static checks with GCC 4.6.0 and non-default toolkits.
4846
5c1ccb01
PE
4847 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4848
006c5daa
PE
4849 * process.c (keyboard_bit_set): Define only if SIGIO.
4850 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4851 (send_process): Repair possible setjmp clobbering.
4852
efc736d3
PE
4853 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4854
4e2fe2e6
PE
4855 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4856
f97334a2
PE
4857 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4858
4e75f29d
PE
4859 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4860 Define only if needed.
4861
90efadd1
PE
4862 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4863 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4864 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4865
3c647824
PE
4866 * dispextern.h (struct redisplay_interface): Rename param
4867 to avoid shadowing.
e264f262 4868 * termhooks.h (struct terminal): Likewise.
761383f4 4869 * xterm.c (xembed_send_message): Likewise.
3c647824 4870
b58c5c4a
PE
4871 * insdel.c (make_gap_smaller): Define only if
4872 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4873
cad59032
PE
4874 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4875 it.
4876
c339dc2e
PE
4877 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4878 so that we aren't warned about unused symbols.
4879
91a3e27b
PE
4880 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4881
399c71d3 4882 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4883
8ffc96f5
PE
4884 * xfns.c (x_real_positions): Mark locals as initialized.
4885
eef9bc79
PE
4886 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4887
098db9dd
PE
4888 * xterm.c: Fix problems found by static analysis with other toolkits.
4889 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4890 (x_dispatch_event): Declare static if USE_GTK, and
4891 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4892 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4893 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4894 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4895 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4896
eb18f6cc
PE
4897 * xmenu.c (menu_help_callback): Pointer type fixes.
4898 Use const pointers when pointing at readonly data. Avoid pointer
4899 signedness clashes.
4900 (FALSE): Remove unused macro.
4901 (update_frame_menubar): Remove unused decl.
4902
1fe72bf8
PE
4903 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4904
60d9e1db
PE
4905 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4906 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4907 (single_menu_item): Rename local to avoid shadowing.
4908
39261c26
PE
4909 * keyboard.c (make_lispy_event): Remove unused local var.
4910
018c5e19
PE
4911 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4912 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4913
63d2b86e
PE
4914 * bitmaps: Change bitmaps from unsigned char back to the X11
4915 compatible char. Avoid the old compiler warnings about
4916 out-of-range initializers by using, for example, '\xab' rather
4917 than 0xab.
4918
aefd87e1
PE
4919 * xgselect.c (xgselect_initialize): Check vs interface
4920 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4921
bf501fb9
PE
4922 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4923
e9829fdf
PE
4924 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4925 to read-only memory.
4926
1086c095
PE
4927 * fns.c (vector): Remove; this old hack is no longer needed.
4928
2baccd04 4929 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4930 Remove unused var.
dde42981 4931 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4932
72391843 4933 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4934
436c16df 4935 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4936 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4937 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4938
92bb796d 4939 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4940 (x_term_init): Remove local to avoid shadowing.
92bb796d 4941
764430a3 4942 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4943
4944 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4945 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4946
d1dfb56c
EZ
49472011-04-16 Eli Zaretskii <eliz@gnu.org>
4948
c4354cb4
EZ
4949 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4950
d1dfb56c
EZ
4951 Fix regex.c, syntax.c and friends for buffers > 2GB.
4952 * syntax.h (struct gl_state_s): Declare character position members
4953 EMACS_INT.
4954
4955 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4956
04f2d78b
CB
4957 * textprop.c (verify_interval_modification, interval_of):
4958 Declare arguments EMACS_INT.
d1dfb56c
EZ
4959
4960 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4961 EMACS_INT.
4962
4963 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4964
4965 * indent.c (Fvertical_motion): Local variable it_start is now
4966 EMACS_INT.
4967
4968 * regex.c (re_match, re_match_2, re_match_2_internal)
4969 (bcmp_translate, regcomp, regexec, print_double_string)
4970 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4971 (re_compile_pattern, re_exec): Declare arguments and local
4972 variables `size_t' and `ssize_t' and return values `regoff_t', as
4973 appropriate.
4974 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4975 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4976 <compile_stack_type>: `size' and `avail' are now `size_t'.
4977
4978 * regex.h <regoff_t>: Use ssize_t, not int.
4979 (re_search, re_search_2, re_match, re_match_2): Arguments that
4980 specify buffer/string position and length are now ssize_t and
4981 size_t. Return type is regoff_t.
4982
613052cd
BK
49832011-04-16 Ben Key <bkey76@gmail.com>
4984
4985 * nsfont.m: Fixed bugs in ns_get_family and
4986 ns_descriptor_to_entity that were caused by using free to
4987 deallocate memory blocks that were allocated by xmalloc (via
4988 xstrdup). This caused Emacs to crash when compiled with
4989 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4990 --enable-checking=xmallocoverrun). xfree is now used to
4991 deallocate these memory blocks.
4992
4170f62f 49932011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4994
71b41406
PE
4995 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4996
9587a89d
PE
4997 emacs_write: Accept and return EMACS_INT for sizes.
4998 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4999 et seq.
5000 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5001 Accept and return EMACS_INT.
5002 (emacs_gnutls_write): Return the number of bytes written on
5003 partial writes.
5004 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5005 (emacs_read, emacs_write): Remove check for negative size, as the
5006 Emacs source code has been audited now.
9587a89d
PE
5007 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5008 (emacs_read, emacs_write): Use it.
273a5f82
PE
5009 * process.c (send_process): Adjust to the new signatures of
5010 emacs_write and emacs_gnutls_write. Do not attempt to store
5011 a byte offset into an 'int'; it might overflow.
9587a89d 5012 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5013
3e047f51
PE
5014 * sound.c: Don't assume sizes fit in 'int'.
5015 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5016 Return EMACS_INT, not int.
3e047f51 5017 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5018 Accept EMACS_INT, not int.
5019 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5020 record read return values.
5021
cc39a9db
BK
50222011-04-15 Ben Key <bkey76@gmail.com>
5023
c9d0ec6d
JB
5024 * keyboard.c (Qundefined): Don't declare static since it is used
5025 in nsfns.m.
5026 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5027 static since they are used in nsfont.m.
cc39a9db 5028
6c60eb9f
SM
50292011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5030
5031 * process.c (Qprocessp): Don't declare static.
5032 * lisp.h (Qprocessp): Declare again.
5033
7990b61a
JB
50342011-04-15 Juanma Barranquero <lekktu@gmail.com>
5035
5036 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5037
5d4cb038
PE
50382011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5039
8bd7b830 5040 Improve C-level modularity by making more things 'static'.
cd64ea1d 5041
e3b27b31
PE
5042 Don't publish debugger-only interfaces to other modules.
5043 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5044 (verify_bytepos, count_markers): Move decls to the only modules
5045 that need them.
5046 * region-cache.h (pp_cache): Likewise.
5047 * window.h (check_all_windows): Likewise.
5048 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5049
5d4cb038
PE
5050 * sysdep.c (croak): Now static, if
5051 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5052 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5053
5054 * alloc.c (refill_memory_reserve): Now static if
5055 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5056 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5057
e87b6180
PE
5058 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5059 Define only if USE_LUCID.
5060
ac64929e
PE
5061 * xrdb.c (x_customization_string, x_rm_string): Now static.
5062
6f37259d
PE
5063 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5064 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5065
1683e3ab
PE
5066 * xdisp.c (draw_row_with_mouse_face): Now static.
5067 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5068
de9c2632
PE
5069 * window.h (check_all_windows): Mark externally visible.
5070
2b96acb7
PE
5071 * window.c (window_deletion_count): Now static.
5072
5073 * undo.c: Make symbols static if they're not exported.
5074 (last_undo_buffer, last_boundary_position, pending_boundary):
5075 Now static.
5076
50436f33
PE
5077 * textprop.c (interval_insert_behind_hooks): Now static.
5078 (interval_insert_in_front_hooks): Likewise.
5079
64520e5c
PE
5080 * term.c: Make symbols static if they're not exported.
5081 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5082 (max_frame_lines, tty_set_terminal_modes):
5083 (tty_reset_terminal_modes, tty_turn_off_highlight):
5084 (get_tty_terminal): Now static.
5085 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5086 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5087 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5088 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5089 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5090
1fa53021
PE
5091 * sysdep.c: Make symbols static if they're not exported.
5092 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5093 Now static.
5094 (sigprocmask_set, full_mask): Remove; unused.
5095 (wait_debugging): Mark as visible.
5096 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5097 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5098
d4b43b22
PE
5099 * syntax.c (syntax_temp): Define only if !__GNUC__.
5100
b7c513d0
PE
5101 * sound.c (current_sound_device, current_sound): Now static.
5102
989b29ad
PE
5103 * search.c (searchbufs, searchbuf_head): Now static.
5104
13a55a78
PE
5105 * scroll.c (scroll_cost): Remove; unused.
5106 * dispextern.h (scroll_cost): Remove decl.
5107
de68a1fc
PE
5108 * region-cache.h (pp_cache): Mark as externally visible.
5109
40ccffa6
PE
5110 * process.c: Make symbols static if they're not exported.
5111 (process_tick, update_tick, create_process, chan_process):
5112 (Vprocess_alist, proc_buffered_char, datagram_access):
5113 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5114 (deactivate_process): Mark defn as static, as well as decl.
5115 * lisp.h (create_process): Remove decl.
5116 * process.h (chan_process, Vprocess_alist): Remove decls.
5117
ad64fc97
PE
5118 * print.c: Make symbols static if they're not exported.
5119 (print_depth, new_backquote_output, being_printed, print_buffer):
5120 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5121 (print_interval, print_number_index, initial_stderr_stream):
5122 Now static.
5123 * lisp.h (Fprinc): Remove decl.
5124 (debug_output_compilation_hack): Mark as externally visible.
5125
adddb265
PE
5126 * sysdep.c (croak): Move decl from here to syssignal.h.
5127 * syssignal.h (croak): Put it here, so the API can be checked when
5128 'croak' is called from dissociate_if_controlling_tty.
5129
1717ede2
PE
5130 * minibuf.c: Make symbols static if they're not exported.
5131 (minibuf_save_list, choose_minibuf_frame): Now static.
5132 * lisp.h (choose_minibuf_frame): Remove decl.
5133
fa5fb2bc
PE
5134 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5135
1e3890d1
PE
5136 * lread.c: Make symbols static if they're not exported.
5137 (read_objects, initial_obarray, oblookup_last_bucket_number):
5138 Now static.
5139 (make_symbol): Remove; unused.
5140 * lisp.h (initial_obarray, make_symbol): Remove decls.
5141
8a1414fa
PE
5142 * keyboard.c: Make symbols static if they're not exported.
5143 (single_kboard, recent_keys_index, total_keys, recent_keys):
5144 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5145 (this_single_command_key_start, echoing, last_auto_save):
5146 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5147 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5148 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5149 (Vlispy_mouse_stem, double_click_count):
5150 Now static.
5151 (force_auto_save_soon): Define only if SIGDANGER.
5152 (ignore_mouse_drag_p): Now static if
5153 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5154 (print_help): Remove; unused.
5155 (stop_character, last_timer_event): Mark as externally visible.
5156 * keyboard.h (ignore_mouse_drag_p): Declare only if
5157 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5158 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5159 * lisp.h (echoing): Remove decl.
5160 (force_auto_save_soon): Declare only if SIGDANGER.
5161 * xdisp.c (redisplay_window): Simplify code, to make it more
5162 obvious that ignore_mouse_drag_p is not accessed if !defined
5163 USE_GTK && !defined HAVE_NS.
5164
93ea6e8f
PE
5165 * intervals.c: Make symbols static if they're not exported.
5166 (merge_properties_sticky, merge_interval_right, delete_interval):
5167 Now static.
5168 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5169
77382fcc
PE
5170 * insdel.c: Make symbols static if they're not exported.
5171 However, leave prepare_to_modify_buffer alone. It's never
5172 called from outside this function, but that appears to be a bug.
5173 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5174 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5175 (adjust_after_replace_noundo): Remove; unused.
5176 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5177 (signal_before_change): Remove decls.
77382fcc 5178
9306c32e
PE
5179 * indent.c (val_compute_motion, val_vmotion): Now static.
5180
cd44d2eb
PE
5181 * image.c: Make symbols static if they're not exported.
5182 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5183 if USE_GTK.
5184 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5185 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5186
ad9a7a06
PE
5187 * fringe.c (standard_bitmaps): Now static.
5188 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5189
81626931
PE
5190 * frame.c: Make symbols static if they're not exported.
5191 (x_report_frame_params, make_terminal_frame): Now static.
5192 (get_frame_param): Now static, unless HAVE_NS.
5193 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5194 (x_get_resource_string): Remove; not used.
5195 * frame.h (make_terminal_frame, x_report_frame_params):
5196 (x_get_resource_string); Remove decls.
5197 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5198 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5199
239f9db9
PE
5200 * font.c, fontset.c: Make symbols static if they're not exported.
5201 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5202 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5203 * font.c (font_close_object): Now static.
5204 * font.h (font_close_object): Remove.
5205 * fontset.c (FONTSET_OBJLIST): Remove.
5206 (free_realized_fontset) #if-0 the body, which does nothing.
5207 (face_suitable_for_char_p): #if-0, as it's never called.
5208 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5209 * xfaces.c (face_at_string_position):
5210 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5211 since 0 is always ASCII.
5212
dfcf3579
PE
5213 * fns.c (weak_hash_tables): Now static.
5214
5045092b
PE
5215 * fileio.c: Make symbols static if they're not exported.
5216 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5217 (Vwrite_region_annotation_buffers): Now static.
5218
57a96f5c
PE
5219 * eval.c: Make symbols static if they're not exported.
5220 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5221 * lisp.h (backtrace_list): Remove decl.
5222
35f08c38
PE
5223 * emacs.c: Make symbols static if they're not exported.
5224 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5225 (fatal_error_code, fatal_error_signal_hook, standard_args):
5226 Now static.
5227 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5228 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5229 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5230 * lisp.h (fatal_error_signal_hook): Remove decl.
5231 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5232
f44bd759
PE
5233 * editfns.c: Move a (normally-unused) function to its only use.
5234 * editfns.c, lisp.h (get_operating_system_release): Remove.
5235 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5236 worth the hassle of breaking this out.
5237
b532497d
PE
5238 * xterm.c: Make symbols static if they're not exported.
5239 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5240 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5241 (x_destroy_window, x_delete_display):
5242 Now static.
5243 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5244 (x_mouse_leave): Remove; unused.
5245 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5246 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5247 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5248 Remove decls.
5249 (x_mouse_leave): Declare only if WINDOWSNT.
5250 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5251 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5252 USE_X_TOOLKIT.
5253
1675728f
PE
5254 * ftxfont.c: Make symbols static if they're not exported.
5255 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5256 HAVE_FREETYPE.
5257 * font.h (ftxfont_driver): Likewise.
5258
e4cebfca
PE
5259 * xfns.c: Make symbols static if they're not exported.
5260 (x_last_font_name, x_display_info_for_name):
5261 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5262 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5263 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5264 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5265 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5266 (last_show_tip_args): Now static.
5267 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5268 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5269 (x_screen_planes): Remove; unused.
5270 * dispextern.h (x_screen_planes): Remove decl.
5271
5bf46f05
PE
5272 * dispnew.c: Make symbols static if they're not exported.
5273 * dispextern.h (redraw_garbaged_frames, scrolling):
5274 (increment_row_positions): Remove.
5275 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5276 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5277 Now static.
5278 (redraw_garbaged_frames): Remove; unused.
5279
435f4c28
PE
5280 * xfaces.c: Make symbols static if they're not exported.
5281 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5282 Remove decls.
5283 * xterm.h (defined_color): Remove decls.
5284 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5285 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5286 (menu_face_changed_default, defined_color, free_realized_face):
5287 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5288 (ascii_face_of_lisp_face): Remove; unused.
5289
8524aef3
PE
5290 * xdisp.c: Make symbols static if they're not exported.
5291 * dispextern.h (scratch_glyph_row, window_box_edges):
5292 (glyph_to_pixel_coords, set_cursor_from_row):
5293 (get_next_display_element, set_iterator_to_next):
5294 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5295 (show_mouse_face): Remove decls
5296 * frame.h (message_buf_print): Likewise.
5297 * lisp.h (pop_message, set_message, check_point_in_composition):
5298 Likewise.
5299 * xterm.h (set_vertical_scroll_bar): Likewise.
5300 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5301 (message_buf_print, scratch_glyph_row, displayed_buffer):
5302 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5303 (get_next_display_element, show_mouse_face, window_box_edges):
5304 (frame_to_window_pixel_xy, check_point_in_composition):
5305 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5306 (glyph_to_pixel_coords): Remove; unused.
5307
16390cd2
PE
5308 * dired.c (file_name_completion): Now static.
5309
5310 * dbusbind.c (xd_in_read_queued_messages): Now static.
5311
a25f4dfa
PE
5312 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5313 * data.c (circular_list_error): Remove.
5314
14a9c8df
PE
5315 * commands.h (last_point_position, last_point_position_buffer):
5316 (last_point_position_window): Remove decls.
5317 * keyboard.c: Make these variables static.
5318
04f2d78b
CB
5319 * coding.h (coding, code_convert_region, encode_coding_gap):
5320 Remove decls.
74ab6df5
PE
5321 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5322 (iso_code_class, detect_coding, code_convert_region): Now static.
5323 (encode_coding_gap): Remove; unused.
5324
38dfbee1
PE
5325 * chartab.c (chartab_chars, chartab_bits): Now static.
5326
a2cb4e63
PE
5327 * charset.h (charset_iso_8859_1): Remove decl.
5328 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5329 Now static.
5330
127198fd
PE
5331 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5332 * ccl.c (Vccl_program_table): Now static.
5333 (check_ccl_update): Remove; unused.
5334
d85b608f
PE
5335 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5336 * category.h: ... from here.
5337 * category.c (check_category_table, set_category_set): Now static.
5338
31cd66f3
PE
5339 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5340 * lisp.h: Remove these decls.
5341
c358e587
PE
5342 * buffer.c (buffer_count): Remove unused var.
5343
e78aecca
PE
5344 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5345 so that it's not optimized away.
5346 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5347 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5348 exported only to the debugger.
5349
e192d7d3 5350 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5351 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5352
92470028
PE
5353 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5354 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5355 was inaccessible from Lisp.
5356 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5357 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5358
244ed907
PE
5359 alloc.c: Import and export fewer symbols, and remove unused items.
5360 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5361 is defined.
5362 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5363 it's not optimized away by whole-program optimization.
5364 (message_enable_multibyte, free_misc): Remove.
5365 (catchlist, handlerlist, mark_backtrace):
5366 Declare only if BYTE_MARK_STACK.
5367 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5368 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5369 (message_enable_multibyte): Remove decl.
5370 (free_misc, interval_free_list, float_block, float_block_index):
5371 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5372 (cons_free_list, last_marked_index):
5373 Now static.
5374 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5375 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5376 (mark_backtrace): Define only if BYTE_MARK_STACK.
5377 * xdisp.c (message_enable_multibyte): Now static.
5378
61c2b50e 5379 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5380 This makes it easier for human readers (and static analyzers)
5381 to see whether these variables are used from other modules.
5382 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5383 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5384 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5385 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5386 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5387 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5388 * xmenu.c, xselect.c:
5389 Declare Q* vars static if they are not used in other modules.
5390 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5391 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5392 Remove decls of unexported vars.
5393 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5394
95c82688
PE
5395 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5396
16a97296
PE
5397 Make Emacs functions such as Fatom 'static' by default.
5398 This makes it easier for human readers (and static analyzers)
5399 to see whether these functions can be called from other modules.
5400 DEFUN now defines a static function. To make the function external
5401 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5402 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5403 (Finit_image_library):
16a97296
PE
5404 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5405 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5406 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5407 Remove decls, since these functions are now static.
5408 (Funintern, Fget_internal_run_time): New decls, since these functions
5409 were already external.
95c82688 5410
16a97296
PE
5411 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5412 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5413 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5414 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5415 * keyboard.c, keymap.c, lread.c:
5416 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5417 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5418 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5419 Mark functions with DEFUE instead of DEFUN,
5420 if they are used in other modules.
5421 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5422 decls for now-static functions.
5423 * buffer.h (Fdelete_overlay): Remove decl.
5424 * callproc.c (Fgetenv_internal): Mark as internal.
5425 * composite.c (Fremove_list_of_text_properties): Remove decl.
5426 (Fcomposition_get_gstring): New forward static decl.
5427 * composite.h (Fcomposite_get_gstring): Remove decl.
5428 * dired.c (Ffile_attributes): New forward static decl.
5429 * doc.c (Fdocumntation_property): New forward static decl.
5430 * eval.c (Ffetch_bytecode): New forward static decl.
5431 (Funintern): Remove extern decl; now in .h file where it belongs.
5432 * fileio.c (Fmake_symbolic_link): New forward static decl.
5433 * image.c (Finit_image_library): New forward static decl.
5434 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5435 * intervals.h (Fprevious_property_change):
5436 (Fremove_list_of_text_properties): Remove decls.
5437 * keyboard.c (Fthis_command_keys): Remove decl.
5438 (Fcommand_execute): New forward static decl.
5439 * keymap.c (Flookup_key): New forward static decl.
5440 (Fcopy_keymap): Now static.
5441 * keymap.h (Flookup_key): Remove decl.
5442 * process.c (Fget_process): New forward static decl.
5443 (Fprocess_datagram_address): Mark as internal.
5444 * syntax.c (Fsyntax_table_p): New forward static decl.
5445 (skip_chars): Remove duplicate decl.
5446 * textprop.c (Fprevious_property_change): New forward static decl.
5447 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5448 Now internal.
5449 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5450 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5451
785bbd42
PE
5452 * editfns.c (Fformat): Remove unreachable code.
5453
8b913b57
AS
54542011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5455
5456 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5457 change. (Bug#8496)
5458
a6744a35
EZ
54592011-04-13 Eli Zaretskii <eliz@gnu.org>
5460
5461 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5462 when at ZV. (Bug#8487)
5463
e7974947
AS
54642011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5465
baad03f0
AS
5466 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5467 (Bug#8437)
5468 * keyboard.c (parse_tool_bar_item): Likewise.
5469 * sound.c (sound_cleanup, alsa_close): Likewise.
5470 * termcap.c (tgetent): Likewise.
5471 * xfns.c (x_default_font_parameter): Likewise.
5472 * xsettings.c (read_and_apply_settings): Likewise.
5473
e7974947
AS
5474 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5475 (overrun_check_free): Protoize.
5476
28272684
PE
54772011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5478
5479 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5480 since callers should never pass a negative size.
5481 Change the signature to match that of plain 'read' and 'write'; see
5482 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5483 * lisp.h: Update prototypes of emacs_write and emacs_read.
5484
11997c76
EZ
54852011-04-11 Eli Zaretskii <eliz@gnu.org>
5486
5487 * xdisp.c (redisplay_window): Don't try to determine the character
5488 position of the scroll margin if the window start point w->startp
e896f03c 5489 is outside the buffer's accessible region. (Bug#8468)
11997c76 5490
8a2cbd72
EZ
54912011-04-10 Eli Zaretskii <eliz@gnu.org>
5492
5493 Fix write-region and its subroutines for buffers > 2GB.
5494 * fileio.c (a_write, e_write): Modify declaration of arguments and
5495 local variables to support buffers larger than 2GB.
5496 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5497
5498 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5499 argument, local variables, and return value.
5500
5501 * lisp.h: Update prototypes of emacs_write and emacs_read.
5502
5503 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5504
4073e537 55052011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5506
1ebfdcb6
PE
5507 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5508
b2ded58d
PE
5509 Fix more problems found by GCC 4.6.0's static checks.
5510
7d66342c
PE
5511 * xdisp.c (vmessage): Use a better test for character truncation.
5512
bbf47d44
PE
5513 * charset.c (load_charset_map): <, not <=, for optimization,
5514 and to avoid potential problems with integer overflow.
9248994d 5515 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5516 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5517 * editfns.c (Fformat): Likewise.
1e69125e 5518 * syntax.c (skip_chars): Likewise.
3befa583 5519
e3019616
PE
5520 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5521 This also lets GCC 4.6.0 generate slightly better loop code.
5522
becfa255
PE
5523 * callint.c (Fcall_interactively): <, not <=, for optimization.
5524 (Fcall_interactively): Count the number of arguments produced,
5525 not the number of arguments given. This is simpler and lets GCC
5526 4.6.0 generate slightly better code.
5527
dae0cd48
PE
5528 * ftfont.c: Distingish more carefully between FcChar8 and char.
5529 The previous code passed unsigned char * to a functions like
5530 strlen and xstrcasecmp that expect char *, which does not
5531 conform to the C standard.
5532 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5533 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5534 char * when the C standard requires it.
5535
76032d70
PE
5536 * keyboard.c (read_char): Remove unused var.
5537
eb3f1cc8
PE
5538 * eval.c: Port to Windows vsnprintf (Bug#8435).
5539 Include <limits.h>.
5540 (SIZE_MAX): Define if the headers do not.
5541 (verror): Do not give up if vsnprintf returns a negative count.
5542 Instead, grow the buffer. This ports to Windows vsnprintf, which
5543 does not conform to C99. Problem reported by Eli Zaretskii.
5544 Also, simplify the allocation scheme, by avoiding the need for
5545 calling realloc, and removing the ALLOCATED variable.
5546
70476b54
PE
5547 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5548
12020a9e
PE
5549 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5550 But keep the doprint source code for now, as we might revamp it
5551 and use it again (Bug#8435).
ea6c7ae6
PE
5552 * lisp.h (doprnt): Remove.
5553 * Makefile.in (base_obj): Remove doprnt.o.
5554 * deps.mk (doprnt.o): Remove.
5555
5fdb398c
PE
5556 error: Print 32- and 64-bit integers portably (Bug#8435).
5557 Without this change, on typical 64-bit hosts error ("...%d...", N)
5558 was used to print both 32- and 64-bit integers N, which relied on
5559 undefined behavior.
5560 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5561 New macro.
5562 * lisp.h (error, verror): Mark as printf-like functions.
5563 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5564 Report overflow in size calculations when allocating printf buffer.
5565 Do not truncate output string at its first null byte.
5566 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5567 Truncate the output at a character boundary, since vsnprintf does not
5568 do that.
5569 * charset.c (check_iso_charset_parameter): Convert internal
5570 character to string before calling 'error', since %c now has the
5571 printf meaning.
5572 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5573 overflow when computing char to be passed to 'error'. Do not
5574 pass Lisp_Object to 'error'; pass the integer instead.
5575 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5576 formatted with plain %d.
5577
b189fa66
PE
5578 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5579
bff87ef0
PE
5580 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5581
7e2cac20
PE
5582 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5583
ce4d90b5
PE
5584 * xterm.c (x_catch_errors): Remove duplicate declaration.
5585
266c9547
PE
5586 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5587
79c49ad2
PE
5588 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5589
368f4090
JM
55902011-04-10 Jim Meyering <meyering@redhat.com>
5591
5592 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5593 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5594 return ssize_t not "int", and use size_t as the buffer length.
5595 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5596 * gnutls.h: Update declarations.
5597 * process.c (read_process_output): Use ssize_t, to match.
5598 (send_process): Likewise.
5599
a32d4040
CY
56002011-04-09 Chong Yidong <cyd@stupidchicken.com>
5601
5602 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5603
8546720e 56042011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5605
04f2d78b
CB
5606 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5607 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5608
8546720e
GM
5609 * xterm.c (handle_one_xevent):
5610 * xmenu.c (create_and_show_popup_menu):
5611 * xselect.c (x_decline_selection_request)
5612 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5613
0a2f5c1a 56142011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5615
5616 Fix some uses of `int' instead of EMACS_INT.
5617 * search.c (string_match_1, fast_string_match)
5618 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5619 (scan_buffer, find_next_newline_no_quit)
5620 (find_before_next_newline, search_command, Freplace_match)
5621 (Fmatch_data): Make some `int' variables be EMACS_INT.
5622
5623 * xdisp.c (display_count_lines): 3rd argument and return value now
5624 EMACS_INT. All callers changed.
5625 (pint2hrstr): Last argument is now EMACS_INT.
5626
5627 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5628 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5629 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5630 (decode_coding_utf_16, decode_coding_emacs_mule)
5631 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5632 (decode_coding_ccl, decode_coding_charset)
5633 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5634 (decode_coding_iso_2022, decode_coding_emacs_mule)
5635 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5636 <char_offset, last_offset>: Declare EMACS_INT.
5637 (encode_coding_utf_8, encode_coding_utf_16)
5638 (encode_coding_emacs_mule, encode_invocation_designation)
5639 (encode_designation_at_bol, encode_coding_iso_2022)
5640 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5641 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5642 Declare EMACS_INT.
5643 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5644 (encode_invocation_designation): Last argument P_NCHARS is now
5645 EMACS_INT.
5646 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5647 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5648
5649 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5650 All users changed.
5651
5652 * ccl.c (Fccl_execute_on_string): Declare some variables
5653 EMACS_INT.
5654
8546720e 56552011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5656
5657 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5658
4e19a977
CS
56592011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5660
5661 * process.c (Fformat_network_address): Doc fix.
5662
87302331
R
56632011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5664
5665 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5666
cbb59342
CY
56672011-04-08 Chong Yidong <cyd@stupidchicken.com>
5668
5669 * keyboard.c (read_char): Call Lisp function help-form-show,
5670 instead of using internal_with_output_to_temp_buffer.
5671 (Qhelp_form_show): New var.
e0d38eeb 5672 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5673
5674 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5675
5676 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5677
e67a13ab
CY
56782011-04-06 Chong Yidong <cyd@stupidchicken.com>
5679
04f2d78b
CB
5680 * process.c (Flist_processes): Remove to Lisp.
5681 (list_processes_1): Delete.
e67a13ab 5682
973f782d
EZ
56832011-04-06 Eli Zaretskii <eliz@gnu.org>
5684
7c106b1e
EZ
5685 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5686
973f782d
EZ
5687 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5688
41cf7d1a 56892011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5690
ca23cc88
PE
5691 Fix more problems found by GCC 4.6.0's static checks.
5692
f390e2d5
PE
5693 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5694
42eea0d0
PE
5695 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5696
b69769da 5697 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5698
f9541e84
PE
5699 * xdisp.c (vmessage): Mark as a printf-like function.
5700
13841b55
PE
5701 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5702
c136c10f
PE
5703 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5704
5e2d4a30
PE
5705 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5706 printf-like functions.
5707 (tiff_load): Add casts to remove these marks before passing them
5708 to system-supplied API.
5709
583f48b9
PE
5710 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5711
b25d760e
PE
5712 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5713 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5714 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5715 directly, rather than having caller test rule sign. This avoids
5716 some unnecessary tests.
5717 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5718 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5719 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5720
bc7b6697 5721 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5722 (xfont_open): Avoid unnecessary tests.
bc7b6697 5723
27ccc379
PE
5724 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5725
dcd5c89a
PE
5726 * composite.h, composite.c (composition_gstring_put_cache):
5727 Use EMACS_INT, not int, for length.
5728
b13a45c6
PE
5729 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5730 breaking out part of COMPOSITION_DECODE_RULE.
5731 (COMPOSITION_DECODE_RULE): Use it.
5732 * composite.c (get_composition_id): Remove unused local vars,
5733 by using the new macro.
5734
1e792e4d
PE
5735 * textprop.c (set_text_properties_1): Change while to do-while,
5736 since the condition is always true at first.
5737
dc6c6455 5738 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5739 (interval_deletion_adjustment): Return unsigned value.
5740 All uses changed.
dc6c6455 5741
aba7731a
PE
5742 * process.c (list_processes_1, create_pty, read_process_output):
5743 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5744 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5745 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5746 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5747 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5748
fdfc4bf3
PE
5749 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5750
fca8fe46 5751 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5752 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5753
06a0259a 5754 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5755 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5756 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5757
e7b9e80f
PE
5758 * print.c (print_error_message): Avoid int overflow.
5759
56201685
PE
5760 * font.c (font_list_entities): Redo for clarity,
5761 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5762
78834453 5763 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5764 (font_score): Avoid potential overflow in diff calculation.
78834453 5765
0bc0b309 5766 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5767 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5768
e610eaca
PE
5769 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5770
b895abce
PE
5771 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5772 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5773 can always succeed if overflow has undefined behavior.
5774
1f1d9321 5775 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5776 (wordify): Omit three unnecessary tests.
1f1d9321 5777
c59478bc
PE
5778 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5779 All callers changed. This avoids the need for an unused var.
5780
79b73827
PE
5781 * casefiddle.c (casify_region): Remove var that is set but not used.
5782
a4db5dfe
PE
5783 * dired.c (file_name_completion): Remove var that is set but not used.
5784
43aae36e
PE
5785 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5786
2a47c44d 5787 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5788 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5789
a37c69bf
PE
5790 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5791 Check for integer overflow on size calculations.
5792
328ab8e7
PE
5793 * buffer.c (Fprevious_overlay_change): Remove var that is set
5794 but not used.
5795
e5a2a5cb
PE
5796 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5797 Remove vars that are set but not used.
8d84a6eb 5798 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5799 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5800
a60e5f68
PE
5801 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5802
f661cb61 5803 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5804 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5805
f0397f5a
PE
5806 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5807 that are set but not used.
5808
8664db06 5809 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5810 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5811
6abdaa4a
PE
5812 * xselect.c (x_get_local_selection, x_handle_property_notify):
5813 Remove vars that are set but not used.
5814
0ce7538d 5815 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5816 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5817
9ae848fc
PE
5818 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5819 Remove var that is set but not used.
0b918413
PE
5820 (scroll_bar_windows_size): Now size_t, not int.
5821 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5822 Check for overflow.
9ae848fc 5823
a5a62657
PE
5824 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5825 (map_tty_color) [!defined MSDOS]: Likewise.
5826
5c5cdd39
PE
5827 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5828
66ebf983
PE
5829 * coding.c: Remove vars that are set but not used.
5830 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5831 All callers changed.
5832 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5833 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5834 (decode_coding_charset): Remove vars that are set but not used.
5835
1be4d761
PE
5836 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5837 that is set but not used.
5838
47553fa8
PE
5839 * print.c (print_object): Remove var that is set but not used.
5840
1f7196bf 5841 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5842 The gnulib version avoids calling malloc in the usual case,
5843 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5844 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5845 * filelock.c (current_lock_owner): Likewise.
5846 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5847 * sysdep.c: Include allocator.h, careadlinkat.h.
5848 (emacs_no_realloc_allocator): New static constant.
5849 (emacs_readlink): New function.
fdb61804
PE
5850 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5851 ../lib/careadlinkat.h.
d1fdcab7 5852
f84c17c7
SM
58532011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5854
5855 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5856 first non-nil return value).
5857
ef3862ad
JD
58582011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5859
5860 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5861 if not defined (Bug#8403).
5862
376a7006
JB
58632011-04-02 Juanma Barranquero <lekktu@gmail.com>
5864
5865 * xdisp.c (display_count_lines): Remove parameter `start',
5866 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5867 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5868 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5869 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5870 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5871 and thereabouts. All callers changed.
5872 (get_per_char_metric): Remove parameter `f', unused since
5873 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5874
6ca3801d
JM
58752011-04-02 Jim Meyering <meyering@redhat.com>
5876
5877 do not dereference NULL upon failed strdup
5878 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5879 (ns_get_family): Likewise.
5880
d8e2b5ba
JB
58812011-04-02 Juanma Barranquero <lekktu@gmail.com>
5882
5883 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5884
8c74fcbd
JD
58852011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5886
5887 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5888 later (Bug#8403).
5889
7200d79c
SM
58902011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5891
03408648 5892 Add lexical binding.
7200d79c 5893
03408648
SM
5894 * window.c (Ftemp_output_buffer_show): New fun.
5895 (Fsave_window_excursion):
5896 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5897
5898 * lread.c (lisp_file_lexically_bound_p): New function.
5899 (Fload): Bind Qlexical_binding.
5900 (readevalloop): Remove `evalfun' arg.
5901 Bind Qinternal_interpreter_environment.
5902 (Feval_buffer): Bind Qlexical_binding.
5903 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5904 Mark as dynamic.
5905 (syms_of_lread): Declare `lexical-binding'.
5906
5907 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5908
5909 * keyboard.c (eval_dyn): New fun.
5910 (menu_item_eval_property): Use it.
ca105506
SM
5911
5912 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5913
03408648
SM
5914 * fns.c (concat, mapcar1): Accept byte-code-functions.
5915
5916 * eval.c (Fsetq): Handle lexical vars.
5917 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5918 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5919 (FletX, Flet): Obey lexical binding.
5920 (Fcommandp): Handle closures.
5921 (Feval): New `lexical' arg.
5922 (eval_sub): New function extracted from Feval. Use it almost
5923 everywhere where Feval was used. Look up vars in lexical env.
5924 Handle closures.
5925 (Ffunctionp): Move from subr.el.
5926 (Ffuncall): Handle closures.
5927 (apply_lambda): Remove `eval_flags'.
5928 (funcall_lambda): Handle closures and new byte-code-functions.
5929 (Fspecial_variable_p): New function.
5930 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5931 but without exporting it to Lisp.
23aba0ea 5932
23aba0ea 5933 * doc.c (Fdocumentation, store_function_docstring):
03408648 5934 * data.c (Finteractive_form): Handle closures.
23aba0ea 5935
03408648
SM
5936 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5937 interactive spec.
ba83908c 5938
04f2d78b
CB
5939 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5940 New byte-codes.
03408648
SM
5941 (exec_byte_code): New function extracted from Fbyte_code to handle new
5942 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5943
03408648 5944 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5945
03408648 5946 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5947
e2abce01
JB
59482011-03-31 Juanma Barranquero <lekktu@gmail.com>
5949
5950 * xdisp.c (redisplay_internal): Fix prototype.
5951
63696a73 59522011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5953
63696a73 5954 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5955 (try_scrolling): Use it when setting scroll_limit.
5956 Limit scrolling to 100 screen lines.
63696a73
EZ
5957 (redisplay_window): Even when falling back on "recentering",
5958 position point in the window according to scroll-conservatively,
5959 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5960
5961 (try_scrolling): When point is above the window, allow searching
5962 as far as scroll_max, or one screenful, to compute vertical
5963 distance from PT to the scroll margin position. This prevents
5964 try_scrolling from unnecessarily failing when
5965 scroll-conservatively is set to a value slightly larger than the
5966 window height. Clean up the case of PT below the margin at bottom
5967 of window: scroll_max can no longer be INT_MAX. When aggressive
5968 scrolling is in use, don't let point enter the opposite scroll
5969 margin as result of the scroll.
5970 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5971 threshold of 100 lines for never-recentering scrolling.
5972
e4cc2dfc
JB
59732011-03-31 Juanma Barranquero <lekktu@gmail.com>
5974
5975 * dispextern.h (move_it_by_lines):
5976 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5977 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5978 (message_log_check_duplicate): Remove parameters `prev_bol' and
5979 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5980 (redisplay_internal): Remove parameter `preserve_echo_area',
5981 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5982
5983 * indent.c (Fvertical_motion):
5984 * window.c (window_scroll_pixel_based, Frecenter):
5985 Don't pass `need_y_p' to `move_it_by_lines'.
5986
1c470562
SM
59872011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5988
44f230aa
SM
5989 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5990 steal a few bits to be more compact.
5991 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5992 Remove unneeded casts.
5993
1c470562
SM
5994 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5995
888adce9
ZK
59962011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5997
5998 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5999 binding" message (bug#7967).
6000
f838ed7b
PE
60012011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6002
77861b95
PE
6003 Fix more problems found by GCC 4.6.0's static checks.
6004
de6dbc14
PE
6005 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6006 Remove unused local var.
6007
f838ed7b
PE
6008 * editfns.c (Fmessage_box): Remove unused local var.
6009
792c7b2b
PE
6010 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6011 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6012 Omit unused local vars.
c499e557 6013 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6014 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6015 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6016 Omit unused local var.
6017
ba0165e1
PE
6018 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6019 Don't assume string length fits in int.
32ad8845 6020 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6021 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6022
3c59b4c9
PE
6023 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6024 instead of alloca (Bug#8344).
6025
a3eed478 6026 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6027 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6028
eb4d412d
PE
6029 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6030
1658b401
PE
6031 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6032 concerns.
6033
6034 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6035
6036 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6037
9a2c6e05
PE
6038 * keyboard.c (syms_of_keyboard): Use the same style as later
6039 in this function when indexing through an array. This also
6040 works around GCC bug 48267.
6041
03d0a109
PE
6042 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6043
44f730c8
PE
6044 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6045
fe75f926
PE
6046 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6047 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6048
ffa8c828
PE
6049 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6050 This avoids undefined behavior on integer overflow, and is a bit
6051 more convenient anyway since it is compared to a size_t variable.
6052
c5101a77
PE
6053 Variadic C functions now count arguments with size_t, not int.
6054 This avoids an unnecessary limitation on 64-bit machines, which
6055 caused (substring ...) to crash on large vectors (Bug#8344).
6056 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6057 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6058 All variadic functions and their callers changed accordingly.
c5101a77
PE
6059 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6060 * data.c (arith_driver, float_arith_driver): Likewise.
6061 * editfns.c (general_insert_function): Likewise.
6062 * eval.c (struct backtrace.nargs, interactive_p)
6063 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6064 (funcall_lambda, mark_backtrace): Likewise.
6065 * fns.c (concat): Likewise.
6066 * frame.c (x_set_frame_parameters): Likewise.
6067 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6068 0 if not found, not -1. All callers changed.
6069
dd3f25f7
PE
6070 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6071 (stack_copy_size): Now size_t, not int.
6072 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6073
461c2ab9
JB
60742011-03-28 Juanma Barranquero <lekktu@gmail.com>
6075
6076 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6077 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6078 All callers changed.
6079
6080 * lisp.h (multibyte_char_to_unibyte):
6081 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6082 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6083 * character.h (CHAR_TO_BYTE8):
6084 * cmds.c (internal_self_insert):
6085 * editfns.c (general_insert_function):
6086 * keymap.c (push_key_description):
6087 * search.c (Freplace_match):
6088 * xdisp.c (message_dolog, set_message_1): All callers changed.
6089
f6d62986
SM
60902011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6091
6092 * keyboard.c (safe_run_hook_funcall): New function.
6093 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6094 don't set the hook to nil, but remove the offending function instead.
6095 (Qcommand_hook_internal): Remove, unused.
6096 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6097 Vcommand_hook_internal.
6098
6099 * eval.c (enum run_hooks_condition): Remove.
6100 (funcall_nil, funcall_not): New functions.
6101 (run_hook_with_args): Call each function through a `funcall' argument.
6102 Remove `cond' argument, now redundant.
6103 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6104 (Frun_hook_with_args_until_failure): Adjust accordingly.
6105 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6106
1db5b1ad
JB
61072011-03-28 Juanma Barranquero <lekktu@gmail.com>
6108
6109 * dispextern.h (string_buffer_position): Remove declaration.
6110
6111 * print.c (strout): Remove parameter `multibyte', unused since
6112 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6113
6114 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6115 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6116 All callers changed.
6117
6118 * w32.c (_wsa_errlist): Use braces for struct initializers.
6119
6120 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6121 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6122 All callers changed.
6123 (string_buffer_position): Likewise. Also, make static (it's never
6124 used outside xdisp.c).
6125 (cursor_row_p): Remove parameter `w', unused since
6126 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6127 (decode_mode_spec): Remove parameter `precision', introduced during
6128 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6129 All callers changed.
6130
5ffb62aa
JD
61312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6132
6133 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6134
461c2ab9 61352011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6136
6137 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6138 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6139 (ns_update_auto_hide_menu_bar): New functions.
6140 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6141 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6142 ns_constrain_all_frames.
6143 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6144 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6145
5c380ffb
JD
61462011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6147
6148 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6149
9af30bdf
GM
61502011-03-27 Glenn Morris <rgm@gnu.org>
6151
6152 * syssignal.h: Replace RETSIGTYPE with void.
6153 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6154 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6155 Replace SIGTYPE with void everywhere.
6156 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6157 * s/template.h (SIGTYPE): Remove commented out definition.
6158
e2abce01
JB
61592011-03-26 Eli Zaretskii <eliz@gnu.org>
6160
6161 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6162 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6163
f868cd8a
JB
61642011-03-26 Juanma Barranquero <lekktu@gmail.com>
6165
59eb0929
JB
6166 * w32.c (read_unc_volume): Use parameter `henum', instead of
6167 global variable `wget_enum_handle'.
6168
6169 * keymap.c (describe_vector): Remove parameters `indices' and
6170 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6171 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6172
f868cd8a
JB
6173 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6174
6175 * keyboard.c (timer_check): Remove parameter `do_it_now',
6176 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6177 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6178 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6179
6180 * keyboard.c (read_char):
6181 * w32menu.c (w32_menu_display_help):
6182 * xmenu.c (show_help_event, menu_help_callback):
6183 Adjust calls to `show_help_echo'.
6184
6185 * gtkutil.c (xg_maybe_add_timer):
6186 * keyboard.c (readable_events):
6187 * process.c (wait_reading_process_output):
6188 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6189
6190 * insdel.c (adjust_markers_gap_motion):
6191 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6192 (gap_left, gap_right): Don't call it.
6193
2ecf6fdb
CY
61942011-03-25 Chong Yidong <cyd@stupidchicken.com>
6195
6196 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6197 incurred during fontification.
6198
6b1f9ba4
JB
61992011-03-25 Juanma Barranquero <lekktu@gmail.com>
6200
6201 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6202 (DEFVAR_PER_BUFFER): Don't pass it.
6203
6204 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6205 (scrolling_window): Don't pass it.
6206
0f4a96b5
JB
62072011-03-25 Juanma Barranquero <lekktu@gmail.com>
6208
6209 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6210
6211 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6212 and `suffix'.
6213 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6214 of variables specific to SELinux and computation of `encoded_absname'.
6215
6216 * image.c (XPutPixel): Remove unused variable `height'.
6217
6218 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6219
6220 * unexw32.c (get_section_info): Remove unused variable `section'.
6221
6222 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6223 (system_process_attributes): Remove unused variable `sess'.
6224 (sys_read): Remove unused variable `err'.
6225
6226 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6227 (w32_wnd_proc): Remove unused variable `isdead'.
6228 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6229 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6230 (x_create_tip_frame): Remove unused variable `tem'.
6231
6232 * w32inevt.c (w32_console_read_socket):
6233 Remove unused variable `no_events'.
6234
6235 * w32term.c (x_draw_composite_glyph_string_foreground):
6236 Remove unused variable `width'.
6237
1149507c
JB
62382011-03-24 Juanma Barranquero <lekktu@gmail.com>
6239
6240 * w32term.c (x_set_glyph_string_clipping):
6241 Don't pass uninitialized region to CombineRgn.
6242
9c88f339
JB
62432011-03-23 Juanma Barranquero <lekktu@gmail.com>
6244
6245 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6246 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6247 (Fx_close_connection): Remove unused variable `i'.
6248
6249 * w32font.c (w32font_draw): Return number of glyphs.
6250 (w32font_open_internal): Remove unused variable `i'.
6251 (w32font_driver): Add missing initializer.
6252
6253 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6254 (fill_in_menu): Remove unused variable `items_added'.
6255
6256 * w32term.c (last_mouse_press_frame): Remove static global variable.
6257 (w32_clip_to_row): Remove unused variable `f'.
6258 (x_delete_terminal): Remove unused variable `i'.
6259
6260 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6261 (NOTHING): Remove unused static global variable.
6262 (uniscribe_check_otf): Remove unused variable `table'.
6263 (uniscribe_font_driver): Add missing initializers.
6264
dee091a3
JD
62652011-03-23 Julien Danjou <julien@danjou.info>
6266
6267 * term.c (Fsuspend_tty, Fresume_tty):
6268 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6269 * window.c (temp_output_buffer_show):
6270 * insdel.c (signal_before_change):
6271 * frame.c (Fhandle_switch_frame):
6272 * fileio.c (Fdo_auto_save):
6273 * emacs.c (Fkill_emacs):
6274 * editfns.c (save_excursion_restore):
6275 * cmds.c (internal_self_insert):
6276 * callint.c (Fcall_interactively):
6277 * buffer.c (Fkill_all_local_variables):
6278 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6279 Use Frun_hooks.
0f4a96b5 6280 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6281 unconditionnaly since it does the check itself.
6282
2c520ab5 62832011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6284
c9c49752
PE
6285 Fix more problems found by GCC 4.5.2's static checks.
6286
8abc3f12
PE
6287 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6288 the first time through the loop, since we know p0 < p1 then.
6289 This also avoids a gcc -Wstrict-overflow warning.
6290
a2d26660
PE
6291 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6292 leading to a memory leak, possible in functions like
6293 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6294 of objects (Bug#8318).
a2d26660 6295
916c72e9
PE
6296 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6297 that could (at least in theory) be that large.
6298
19ab8a18
PE
6299 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6300 This is less likely to overflow, and avoids undefined behavior if
6301 overflow does occur. All callers changed. Use strtoul to scan
6302 for the unsigned long integer.
b7cbbd6f
PE
6303 (pint2hrstr): Simplify and tune code slightly.
6304 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6305
f0641eff
PE
6306 * scroll.c (do_scrolling): Work around GCC bug 48228.
6307 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6308
7f650bb9
PE
6309 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6310 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6311 (validate_x_resource_name): Simplify count usage.
6312 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6313
37dd57d1
PE
6314 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6315 fail (Bug#8306).
81e56e61 6316
699979fc 6317 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6318
401bf9b4
PE
6319 * process.c (Fmake_network_process): Use socklen_t, not int,
6320 where POSIX says socklen_t is required in portable programs.
6321 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6322 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6323 (Fmake_network_process, server_accept_connection):
6324 (wait_reading_process_output, read_process_output):
6325 Likewise.
6326
b93aacde
PE
6327 * process.c: Rename or move locals to avoid shadowing.
6328 (list_processes_1, Fmake_network_process):
6329 (read_process_output_error_handler, exec_sentinel_error_handler):
6330 Rename or move locals.
4dc343ee 6331 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6332 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6333 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6334 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6335 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6336
af8a867c 6337 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6338 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6339 Include tparam.h instead, since it declares them.
af8a867c
PE
6340 * cm.h (PC): Remove extern decl; tparam.h now does this.
6341 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6342 * terminfo.c: Include tparam.h, to check interfaces.
6343 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6344 (tparam): Adjust signature to match interface in tparam.h;
6345 this removes some undefined behavior. Check that outstring and len
6346 are zero, which they always are with Emacs.
6347 * tparam.h (PC, BC, UP): New extern decls.
6348
0248044d 6349 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6350 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6351
8ff096c1 6352 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6353 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6354 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6355 (ftfont_list): Remove unused local.
49eaafba
PE
6356 (get_adstyle_property, ftfont_pattern_entity):
6357 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6358 Rename locals to avoid shadowing.
8ff096c1 6359
e2be39f6
PE
6360 * xfont.c (xfont_list_family): Mark var as initialized.
6361
c9735e30
PE
6362 * xml.c (make_dom): Now static.
6363
8f5201ae
PE
6364 * composite.c (composition_compute_stop_pos): Rename local to
6365 avoid shadowing.
b246f932
PE
6366 (composition_reseat_it): Remove unused locals.
6367 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6368 (composition_update_it): Mark var as initialized.
11b61122
PE
6369 (find_automatic_composition): Mark vars as initialized,
6370 with a FIXME (Bug#8290).
8f5201ae 6371
760fbc2c
PE
6372 character.h: Rename locals to avoid shadowing.
6373 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6374 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6375 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6376 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6377 to avoid shadowing.
6378
ff08eb85
PE
6379 * textprop.c (property_change_between_p): Remove; unused.
6380
fc7bf025
PE
6381 * intervals.c (interval_start_pos): Now static.
6382
235d7abc
PE
6383 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6384
44f230aa
SM
6385 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6386 Rename locals to avoid shadowing.
3e7d6594 6387
50060332
PE
6388 * sound.c (wav_play, au_play, Fplay_sound_internal):
6389 Fix pointer signedness.
d01f234b 6390 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6391 (wav_play): Initialize a variable to 0, to prevent undefined
6392 behavior (Bug#8278).
50060332 6393
c4fc4e30
PE
6394 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6395
918436ed
PE
6396 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6397
c939f91b
PE
6398 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6399 clobbering (Bug#8298).
b9c7f648
PE
6400 * sysdep.c (sys_subshell): Likewise.
6401 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6402
6bd8c144
PE
6403 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6404 This should get cleaned up, so that child_setup has the
6405 same signature on all platforms.
6406
7710357c 6407 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6408 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6409
c59da222
CY
64102011-03-22 Chong Yidong <cyd@stupidchicken.com>
6411
6412 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6413 not to be necessary, and produces flickering.
6414
66b87493
GM
64152011-03-20 Glenn Morris <rgm@gnu.org>
6416
6417 * config.in: Remove file.
6418
45b6f6d5
JB
64192011-03-20 Juanma Barranquero <lekktu@gmail.com>
6420
6421 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6422 are now in src/globals.h.
6423 (syms_of_minibuf): Remove spurious & from previous change.
6424
3ec03f7e
LL
64252011-03-20 Leo <sdl.web@gmail.com>
6426
6427 * minibuf.c (completing-read-function): New variable.
6428 (completing-read-default): Rename from completing-read.
6429 (completing-read): Call completing-read-function.
6430
b14e3e21
CY
64312011-03-19 Juanma Barranquero <lekktu@gmail.com>
6432
6433 * xfaces.c (Fx_load_color_file):
6434 Read color file from absolute filename (bug#8250).
6435
f2b726e6
JB
64362011-03-19 Juanma Barranquero <lekktu@gmail.com>
6437
6438 * makefile.w32-in: Update dependencies.
6439
09f6ff02
EZ
64402011-03-17 Eli Zaretskii <eliz@gnu.org>
6441
6442 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6443
29a6015a
PE
64442011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6445
a3a6c54e
PE
6446 Fix more problems found by GCC 4.5.2's static checks.
6447
b766f867
PE
6448 * process.c (make_serial_process_unwind, send_process_trap):
6449 (sigchld_handler): Now static.
6450
be02381c
PE
6451 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6452 That way, the code declares only the vars that it needs.
6453 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6454 * s/cygwin.h (PTY_ITERATION): Likewise.
6455 * s/darwin.h (PTY_ITERATION): Likewise.
6456 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6457
57048744
PE
6458 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6459 * process.c (allocate_pty): Don't declare stb unless it's needed.
6460
7914961c 6461 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6462 (CONSTANTLIM): Remove; unused.
6463 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6464 Define only if needed.
7914961c 6465
b3967b18
PE
6466 * unexelf.c (unexec): Name an expression,
6467 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6468 Use a different way to cause a compilation error if anyone uses
6469 n rather than nn, a way that does not involve shadowing.
73366a00 6470 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6471
29a6015a
PE
6472 * deps.mk (unexalpha.o): Remove; unused.
6473
43cfc33e 6474 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6475 * unexec.h: New file.
ce701a33
PE
6476 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6477 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6478 Depend on unexec.h.
6479 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6480 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6481 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6482 Change as necessary to match prototype in unexec.h.
ce701a33 6483
01f44d5a
PE
6484 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6485 shadowing.
4f63c6bb 6486 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6487
a6670b0b
PE
6488 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6489 Rename locals to avoid shadowing.
6490
cef2010d 6491 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6492 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6493
d4d7173a
PE
6494 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6495
f08b802a
PE
6496 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6497 warning when compiling print.c.
6498
3ddb0639
PE
6499 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6500 instead of using an uninitialized var.
5ad03b97 6501 (font_sort_entities): Mark var as initialized.
3ddb0639 6502
170a2692
PE
6503 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6504
e663c700
PE
6505 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6506 pointers to constants.
89bc529a 6507 (font_parse_fcname): Remove unused vars.
7b81e2d0 6508 (font_delete_unmatched): Now static.
ea838e10 6509 (font_get_spec): Remove; unused.
13a547c6
PE
6510 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6511 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6512 Rename or move locals to avoid shadowing.
e663c700 6513
2a80c887 6514 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6515 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6516
1384fa33 6517 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6518 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6519
8b2c52e9
PE
6520 * alloc.c (mark_backtrace): Move decl from here ...
6521 * lisp.h: ... to here, so that it can be checked.
6522
475545b5 6523 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6524 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6525 (lisp_indirect_variable): Name an expression,
6526 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6527 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6528
b1349114 6529 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6530 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6531 Use const pointer when appropriate.
b1349114 6532
a2928364
PE
6533 * lisp.h (get_system_name, get_operating_system_release):
6534 Move decls here, to check interfaces.
6535 * process.c (get_operating_system_release): Move decl to lisp.h.
6536 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6537 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6538 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6539 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6540 (Fformat_time_string, Fencode_time, Finsert_char):
6541 (Ftranslate_region_internal, Fformat):
6542 Rename or remove local vars to avoid shadowing.
9710023e 6543 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6544
a415e694
PE
6545 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6546 avoid shadowing.
6547
8ef4622d
PE
6548 * lisp.h (eassert): Check that the argument compiles, even if
6549 ENABLE_CHECKING is not defined.
6550
946f9a5b
PE
6551 * data.c (Findirect_variable): Name an expression, to avoid
6552 gcc -Wbad-function-cast warning.
112396d6 6553 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6554 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6555 (Fmake_variable_buffer_local, Fmake_local_variable):
6556 Mark variables as initialized.
52746918 6557 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6558
e5aab7e7 6559 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6560 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6561 Rename locals to avoid shadowing.
dff45157
PE
6562 (mark_stack): Move local variables into the #ifdef region where
6563 they're used.
7bc26fdb
PE
6564 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6565 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6566 needed otherwise.
6567 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6568 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6569 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6570
e5aab7e7
PE
6571 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6572 avoids undefined behavior in theory.
6573
4da60324
PE
6574 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6575
88043301
PE
6576 Use functions, not macros, for up- and down-casing (Bug#8254).
6577 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6578 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6579 to use the following functions instead of these macros.
6580 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6581 EMACS_INT, since callers assume the returned value fits in int.
6582 (upcase1): Likewise, for UPCASE_TABLE.
6583 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6584 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6585 the race-condition problem in the old DOWNCASE.
88043301 6586
19ed5445
PE
6587 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6588 Rename locals to avoid shadowing.
6589 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6590 (regex_compile, re_search_2, re_match_2_internal):
6591 Remove unused local vars.
952db0d7
PE
6592 (FREE_VAR): Rewrite so as not to use empty "else",
6593 which gcc can warn about.
da053e48 6594 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6595 (RETALLOC_IF): Define only if needed.
6596 (WORDCHAR_P): Likewise. This one is never needed, but is used
6597 only in a comment talking about a compiler bug, so put inside
6598 the #if 0 of that comment.
6599 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6600 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6601 Remove; unused.
19ed5445 6602
1f3561e4 6603 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6604 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6605 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6606
ded6f8f7
PE
6607 * search.c (simple_search): Remove unused var.
6608
dbd37a95
PE
6609 * dired.c (compile_pattern): Move decl from here ...
6610 * lisp.h: ... to here, so that it can be checked.
6611 (struct re_registers): New forward decl.
6612
7e47afad
PE
6613 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6614
85f24f61
PE
6615 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6616 All uses changed.
6617 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6618 Rename locals to avoid shadowing.
5671df8f 6619 (Fvertical_motion): Mark locals as initialized.
85f24f61 6620
181aa2be 6621 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6622 (casify_region): Mark local as initialized.
181aa2be 6623
930d429c
PE
6624 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6625
7082eac6
PE
6626 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6627 New macros, so that the caller can use some names other than
6628 gcpro1, gcpro2, etc.
6629 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6630 of the new macros.
6631 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6632 argument, for consistency with GCPRO2_VAR, etc: it is now the
6633 prefix of the variable, not the variable itself. All uses
6634 changed.
38b2c076
PE
6635 * dired.c (directory_files_internal, file_name_completion):
6636 Rename locals to avoid shadowing.
6637
15206ed9
PE
6638 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6639 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6640 dired.c's scmp function, had undefined behavior.
6641 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6642 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6643 * buffer.h: ... to here, because these macros use current_buffer,
6644 and the new implementation with inline functions needs to have
6645 current_buffer in scope now, rather than later when the macros
6646 are used.
6647 (downcase, upcase1): New static inline functions.
6648 (DOWNCASE, UPCASE1): Reimplement using these functions.
6649 This avoids undefined behavior in expressions like
6650 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6651 from race conditions in accessing the global variables
6652 case_temp1 and case_temp2.
6653 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6654 * lisp.h (case_temp1, case_temp2): Remove their decls.
6655 * character.h (ASCII_CHAR_P): Move from here ...
6656 * lisp.h: ... to here, so that the inline functions mentioned
6657 above can use them.
6658
4a6bea26
PE
6659 * dired.c (directory_files_internal_unwind): Now static.
6660
f14b7e14
PE
6661 * fileio.c (file_name_as_directory, directory_file_name):
6662 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6663 Now static.
2893f146
PE
6664 (file_name_as_directory): Use const pointers when appropriate.
6665 (Fexpand_file_name): Likewise. In particular, newdir might
6666 point at constant storage, so make it a const pointer.
fd4ead52 6667 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6668 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6669 signedness issues.
f839df0c
PE
6670 (Fset_file_times, Finsert_file_contents, auto_save_error):
6671 Rename locals to avoid shadowing.
f14b7e14 6672
5716756e 6673 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6674 (Ftry_completion, Fall_completions): Rename or remove locals
6675 to avoid shadowing.
5716756e 6676
b4c3046a
PE
6677 * marker.c (bytepos_to_charpos): Remove; unused.
6678
b45db522
PE
6679 * lisp.h (verify_bytepos, count_markers): New decls,
6680 so that gcc does not warn that these functions aren't declared.
6681
85876d07
PE
6682 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6683 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6684 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6685 (copy_text): Remove unused local var.
85876d07 6686
03d78a21 6687 * filelock.c (within_one_second): Now static.
b3dd38ab 6688 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6689
5df8f01b
PE
6690 * buffer.c (fix_overlays_before): Mark locals as initialized.
6691 (fix_start_end_in_overlays): Likewise. This function should be
6692 simplified by using pointers-to-pointers, but that's a different
6693 matter.
b1d876f1 6694 (switch_to_buffer_1): Now static.
8f54f30a
PE
6695 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6696 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6697
a70072c9 6698 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6699 Fix pointer signedness issue.
edced198
PE
6700 (sys_subshell): Mark local as volatile if checking for lint,
6701 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6702 (MAXPATHLEN): Define only if needed.
a70072c9 6703
a0977c44
PE
6704 * process.c (serial_open, serial_configure): Move decls from here ...
6705 * systty.h: ... to here, so that they can be checked.
6706
a884fdcc
PE
6707 * fns.c (get_random, seed_random): Move extern decls from here ...
6708 * lisp.h: ... to here, so that they can be checked.
6709
604efe86 6710 * sysdep.c (reset_io): Now static.
b8950c94 6711 (wait_for_termination_signal): Remove; unused.
604efe86 6712
38fc62d9
PE
6713 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6714 (copy_keymap_item, append_key, push_text_char_description):
6715 Now static.
1004a21a 6716 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6717 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6718 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6719 (describe_map_tree):
6720 Rename locals to avoid shadowing.
38fc62d9 6721
2f2650da
PE
6722 * keyboard.c: Declare functions static if they are not used elsewhere.
6723 (echo_char, echo_dash, cmd_error, top_level_2):
6724 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6725 (read_char, kbd_buffer_get_event, make_lispy_position):
6726 (make_lispy_event, make_lispy_movement, apply_modifiers):
6727 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6728 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6729 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6730 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6731 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6732
a053e86c 6733 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6734 (mark_kboards): Move decl here ...
6735 * alloc.c (mark_kboards): ... from here.
a053e86c 6736
4752793e
PE
6737 * lisp.h (force_auto_save_soon): New decl.
6738
74f10ca7 6739 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6740 (DEFINE_DUMMY_FUNCTION): New macro.
6741 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6742 Use it.
c03cd23f
PE
6743 (main): Add casts to avoid warnings
6744 if GCC considers string literals to be constants.
74f10ca7 6745
022e70d4
PE
6746 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6747
59d6fe83
PE
6748 * dbusbind.c: Pointer signedness fixes.
6749 (xd_signature, xd_append_arg, xd_initialize):
6750 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6751 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6752 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6753 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6754
78320123
PE
6755 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6756 if GCC considers string literals to be constants.
49cebcca 6757 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6758
35ac2a97
SM
67592011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6760
fb103ca9
SM
6761 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6762 (print_preprocess, print_object): New macro to fix last change.
6763
35ac2a97
SM
6764 * print.c (print_preprocess): Don't forget font objects.
6765
62973b41
JB
67662011-03-16 Juanma Barranquero <lekktu@gmail.com>
6767
6768 * emacs.c (USAGE3): Doc fixes.
6769
0e48bb22
AS
67702011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6771
6772 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6773 structure.
6774
7684e57b
JB
67752011-03-14 Juanma Barranquero <lekktu@gmail.com>
6776
6777 * lisp.h (VWindow_system, Qfile_name_history):
6778 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6779 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6780 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6781
6782 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6783 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6784
6785 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6786 * w32console.c (detect_input_pending, read_input_pending)
6787 (encode_terminal_code):
6788 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6789 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6790 (w32_system_caret_y, Qfile_name_history):
6791 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6792 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6793 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6794 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6795 * w32proc.c (Qlocal, report_file_error):
6796 * w32term.c (Vwindow_system, updating_frame):
6797 * w32uniscribe.c (initialized, uniscribe_font_driver):
6798 Remove unneeded extern declarations.
6799
2aa46d6c
CY
68002011-03-14 Chong Yidong <cyd@stupidchicken.com>
6801
c96bbc66 6802 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6803
cffc6f3b
CY
68042011-03-13 Chong Yidong <cyd@stupidchicken.com>
6805
6806 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6807 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6808 These macros can no longer be used for assignment.
6809
44f230aa
SM
6810 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6811 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6812 (record_buffer_markers, fetch_buffer_markers): New functions for
6813 recording and fetching special buffer markers.
6814 (set_buffer_internal_1, set_buffer_temp): Use them.
6815
6816 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6817
6818 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6819
6820 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6821 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6822
6823 * xdisp.c (hscroll_window_tree):
6824 (reconsider_clip_changes): Use PT instead of BUF_PT.
6825
d251f04b
EZ
68262011-03-13 Eli Zaretskii <eliz@gnu.org>
6827
6828 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6829 $(EMACS_ROOT)/lib/intprops.h.
6830
f0c77cd1
PE
68312011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6832
3eca4629
PE
6833 Fix more problems found by GCC 4.5.2's static checks.
6834
7c86ee98
PE
6835 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6836 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6837 (xg_free_frame_widgets): Make it clear that a local variable is
6838 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6839 (gdk_window_get_screen): Make it clear that this macro is needed
6840 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6841 (int_gtk_range_get_value): New function, which avoids a diagnostic
6842 from gcc -Wbad-function-cast.
6843 (xg_set_toolkit_scroll_bar_thumb): Use it.
6844 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6845 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6846 (get_utf8_string, xg_get_file_with_chooser):
6847 Rename locals to avoid shadowing.
6848 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6849
41729b81
PE
6850 * xgselect.c (xg_select): Remove unused var.
6851
f0c77cd1
PE
6852 * image.c (four_corners_best): Mark locals as initialized.
6853 (gif_load): Initialize transparent_p to zero (Bug#8238).
6854 Mark another local as initialized.
ec6cf4c6 6855 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6856
ce0ad53d 6857 * image.c (clear_image_cache): Now static.
d5d5a617 6858 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6859 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6860 (x_edge_detection): Remove unnecessary cast that
6861 gcc -Wbad-function-cast diagnoses.
2037898d 6862 (gif_load): Fix pointer signedness.
6ae141d6
PE
6863 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6864 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6865
33383987 68662011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6867
d32df629
PE
6868 Improve quality of tests for time stamp overflow.
6869 For example, without this patch (encode-time 0 0 0 1 1
6870 1152921504606846976) returns the obviously-bogus value (-948597
6871 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6872 reports time overflow. See
6873 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6874 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6875 * editfns.c: Include limits.h and intprops.h.
6876 (TIME_T_MIN, TIME_T_MAX): New macros.
6877 (time_overflow): Move earlier, to before first use.
6878 (hi_time, lo_time): New functions, for an accurate test for
6879 out-of-range times.
6880 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6881 (Fget_internal_run_time): Don't assume time_t fits in int.
6882 (make_time): Use list2 instead of Fcons twice.
6883 (Fdecode_time): More accurate test for out-of-range times.
6884 (check_tm_member): New function.
6885 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6886 (lisp_time_argument): Don't rely on undefined left-shift and
6887 right-shift behavior when checking for time stamp overflow.
8be6f318 6888
fe31d94c
PE
6889 * editfns.c (time_overflow): New function, refactoring common code.
6890 (Fformat_time_string, Fdecode_time, Fencode_time):
6891 (Fcurrent_time_string): Use it.
6892
8be6f318
PE
6893 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6894 * dired.c (make_time): Move to ...
6895 * editfns.c (make_time): ... here.
6896 * systime.h: Note the move.
6897
09d9db2c 68982011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6899
126bc0dc
YM
6900 * fringe.c (update_window_fringes): Remove unused variables.
6901
c47cbdfd
YM
6902 * unexmacosx.c (copy_data_segment): Also copy __got section.
6903 (Bug#8223)
6904
7ac80be9
EZ
69052011-03-12 Eli Zaretskii <eliz@gnu.org>
6906
c96bbc66 6907 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6908 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6909 Constify `char *' arguments and their references according to
6910 prototypes in tparam.h.
6911
ecb0f94d 6912 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6913
7ac80be9
EZ
6914 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6915 Adapt all references accordingly.
6916
6917 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6918
ef1fd07e
TT
69192011-03-11 Tom Tromey <tromey@redhat.com>
6920
6921 * buffer.c (syms_of_buffer): Remove obsolete comment.
6922
7ef4b50c
EZ
69232011-03-11 Eli Zaretskii <eliz@gnu.org>
6924
6925 * termhooks.h (encode_terminal_code): Declare prototype.
6926
6927 * msdos.c (encode_terminal_code): Don't declare prototype.
6928
6929 * term.c (encode_terminal_code): Now external again, used by
6930 w32console.c and msdos.c.
6931
44f230aa
SM
6932 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6933 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6934
4b1ec863 69352011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6936
1714f52b 6937 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6938
4b1ec863
PE
6939 * fringe.c (update_window_fringes): Mark locals as initialized
6940 (Bug#8227).
6941 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6942
524c7aa6
PE
6943 * alloc.c (mark_fringe_data): Move decl from here ...
6944 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6945 to check its interface.
6946 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6947
a5c0af81 6948 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6949 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6950 (fontset_font): Mark local as initialized.
a9a06e0b 6951 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6952
b4716021
PE
6953 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6954
811e9bac 6955 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6956 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6957 (x_own_selection, Fx_disown_selection_internal): Rename locals
6958 to avoid shadowing.
6959 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6960
7e3ab302
PE
6961 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6962 so that the caller can use some name other than gcpro1.
6963 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6964 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6965 (Fx_backspace_delete_keys_p):
6966 Use them to avoid shadowing, and rename vars to avoid shadowing.
6967 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6968 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6969 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6970 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6971 Remove unused locals.
7e3ab302
PE
6972 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6973 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6974 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6975 macros.
f78faa98 6976
e2b13473
PE
6977 * xterm.h (x_mouse_leave): New decl.
6978
77f23912
PE
6979 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6980 Remove unused functions.
cdf4ba58
PE
6981 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6982 (x_calc_absolute_position): Now static.
7411c686 6983 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6984 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6985 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6986 unless they are used.
38d0b34a
PE
6987 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6988 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6989 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6990 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6991 (x_error_catcher, x_connection_closed, x_error_handler):
6992 (x_error_quitter, xembed_send_message, x_iconify_frame):
6993 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6994 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6995 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6996
44f230aa
SM
6997 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6998 Rename or move locals to avoid shadowing.
6b463e58 6999 (tty_defined_color, merge_face_heights): Now static.
5967d051 7000 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7001 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7002 does not deduce is never used uninitialized.
73719eba
PE
7003 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7004 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7005
426994c3 7006 * terminal.c (store_terminal_param): Now static.
5489860b 7007
032f1620 7008 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7009 (set_frame_menubar): Remove unused local.
d4323972 7010 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7011 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7012 since they might point to immutable storage.
281585b0
PE
7013 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7014 since it's unused otherwise.
032f1620 7015
367c19e5 7016 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7017 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7018 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7019 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7020 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7021 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7022 does not deduce are never used uninitialized.
70739cbe 7023
07b48fa9
PE
7024 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7025
8868a238 7026 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7027 * window.c (window_loop, size_window):
7028 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7029
7e5cf297 7030 * window.c (display_buffer): Now static.
d6550a9f
PE
7031 (size_window): Mark variables that gcc -Wuninitialized
7032 does not deduce are never used uninitialized.
a586633d
PE
7033 * window.h (check_all_windows): New decl, to forestall
7034 gcc -Wmissing-prototypes diagnostic.
5b555da1 7035 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7036
f6095868
PE
7037 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7038 shadowing.
7039 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7040 Include <limits.h>.
7041 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7042 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7043 (load_charset_map): Mark variables that gcc -Wuninitialized
7044 does not deduce are never used uninitialized.
53df7c11 7045 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7046
f38b440c
PE
7047 * coding.c (coding_set_source, coding_set_destination):
7048 Use "else { /* comment */ }" rather than "else /* comment */;"
7049 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7050 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7051 a block, when the outer 'i' will do.
7052 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7053 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7054 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7055 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7056 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7057 Rename locals to avoid shadowing.
7058 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7059 * coding.c (emacs_mule_char, encode_invocation_designation):
7060 Now static, since they're not used elsewhere.
413bb2db 7061 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7062 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7063 (decode_coding_emacs_mule): Mark variables that gcc
7064 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7065 (detect_coding_iso_2022): Initialize a local variable that might
7066 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7067 this initialization is needed. (Bug#8211)
5f58e762
PE
7068 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7069 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7070 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7071 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7072 Remove unused macros.
f38b440c 7073
232b38b9 7074 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7075 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7076 * character.c (string_count_byte8): Likewise.
232b38b9 7077
fb90da1b
PE
7078 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7079 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7080
fb93dbc2
PE
7081 * chartab.c (copy_sub_char_table): Now static, since it's not used
7082 elsewhere.
5c156ace
PE
7083 (sub_char_table_ref_and_range, char_table_ref_and_range):
7084 Rename locals to avoid shadowing.
bbcd0949 7085 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7086
7d3b3862 7087 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7088 (BIDI_BOB): Remove unused macro.
7d3b3862 7089
6be7d3da
PE
7090 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7091 deduce are never used uninitialized.
c2ed9c8b 7092 * term.c (encode_terminal_code): Likewise.
6be7d3da 7093
75f8807f 7094 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7095
50938595
PE
7096 * tparam.h: New file.
7097 * term.c, tparam.h: Include it.
7098 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7099 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7100 Move these decls to tparam.h, and make them agree with what
7101 is actually in tparam.c. The previous trick of using incompatible
7102 decls in different modules does not conform to the C standard.
7103 All callers of tparam changed to use tparam's actual API.
7104 * tparam.c (tparam1, tparam, tgoto):
7105 Use const pointers where appropriate.
7106
fbceeba2
PE
7107 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7108 * cm.h (struct cm): Likewise.
7109 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7110 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7111 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7112 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7113 (turn_on_face, init_tty): Likewise.
7114 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7115
7f3f1250
PE
7116 * term.c (term_mouse_position): Rename local to avoid shadowing.
7117
e6ca6543
PE
7118 * alloc.c (mark_ttys): Move decl from here ...
7119 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7120
c40f8d15
AS
71212011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7122
7123 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7124
cfe0661d
JB
71252011-03-09 Juanma Barranquero <lekktu@gmail.com>
7126
7127 * search.c (compile_pattern_1): Remove argument regp, unused since
7128 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7129 (compile_pattern): Don't pass it.
7130
0afb4571
J
71312011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7132
7133 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7134 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7135 for ! HAVE_GTK3.
7136 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7137
7138 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7139
7140 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7141 gdk_window_get_screen, gdk_window_get_geometry,
7142 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7143 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7144 (xg_get_pixbuf_from_pixmap): New function.
7145 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7146 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7147 Call xg_get_pixbuf_from_pixmap instead of
7148 gdk_pixbuf_get_from_drawable.
7149 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7150 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7151 (xg_check_special_colors): Use GtkStyleContext and its functions
7152 for HAVE_GTK3.
7153 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7154 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7155 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7156 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7157 Call gtk_widget_get_preferred_size.
0afb4571
J
7158 (xg_frame_resized): gdk_window_get_geometry only takes 5
7159 parameters.
44f230aa
SM
7160 (xg_win_to_widget, xg_event_is_for_menubar):
7161 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7162 (xg_set_widget_bg): New function.
7163 (delete_cb): New function.
895009e1 7164 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7165 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7166 (xg_set_background_color): Call xg_set_widget_bg.
7167 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7168 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7169 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7170 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7171 if ! HAVE_GTK3.
7172 (update_frame_tool_bar): Call gtk_widget_hide.
7173 (xg_initialize): Use GDK_KEY_g.
7174
7175 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7176 if ! HAVE_GTK3
7177 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7178
7179 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7180 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7181 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7182
1c2cc4ef
JB
71832011-03-08 Juanma Barranquero <lekktu@gmail.com>
7184
7185 * w32xfns.c (select_palette): Check success of RealizePalette against
7186 GDI_ERROR, not zero.
7187
33383987 7188See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7189
7190;; Local Variables:
7191;; coding: utf-8
aac0c6e3
MR
7192;; End:
7193
33383987 7194 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7195
7196 This file is part of GNU Emacs.
7197
7198 GNU Emacs is free software: you can redistribute it and/or modify
7199 it under the terms of the GNU General Public License as published by
7200 the Free Software Foundation, either version 3 of the License, or
7201 (at your option) any later version.
7202
7203 GNU Emacs is distributed in the hope that it will be useful,
7204 but WITHOUT ANY WARRANTY; without even the implied warranty of
7205 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7206 GNU General Public License for more details.
7207
7208 You should have received a copy of the GNU General Public License
7209 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.