Do not create empty overlays with the evaporate property (Bug#9642).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
888bec30
PE
12012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2
89a438bd
PE
3 Do not create empty overlays with the evaporate property (Bug#9642).
4 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5 if it becomes empty after its bounds are adjusted to fit within
6 its buffer. Without this fix, in a nonempty buffer (let ((o
7 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
8 yields an empty overlay that has the evaporate property, which is
9 not supposed to happen.
10
1068fe4d
PE
11 Fix minor GTK3 problems found by static checking.
12 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
13 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
14 (struct _EmacsFixedClass, emacs_fixed_get_type):
15 Move decls here from emacsgtkfixed.h, since they needn't be public.
16 (emacs_fixed_get_type): Now static.
17 (emacs_fixed_class_init): Omit unused local.
18 (emacs_fixed_child_type): Remove; unused.
19 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
20 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
21 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
22 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
23 (EMACS_FIXED_GET_CLASS): Remove; unused.
24 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
25
888bec30
PE
26 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
27 Problem reported by Juanma Barranquero for Windows -Wunused-function.
28
de85e130
PE
292012-04-22 Paul Eggert <eggert@cs.ucla.edu>
30
d0baac98
PE
31 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
32 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
33 (__malloc_size_t, __malloc_ptrdiff_t):
34 Remove. All uses removed, replaced by the definiens if needed,
35 since we can assume C89 or better now.
36 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
37 (protect_malloc_state, align, get_contiguous_space)
38 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
39 (malloc_atfork_handler_child, malloc_enable_thread)
40 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
41 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
42 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
43 (special_realloc, _realloc_internal_nolock, _realloc_internal)
44 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
45 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
46 Define using prototypes, not old style.
47 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
48 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
49 (align): Don't assume that signed integer overflow wraps around.
50 Omit unused local var.
51 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
52 (_free_internal_nolock, memalign, mallochook, reallochook):
53 Omit no-longer-needed casts.
54 (valloc): Use getpagesize, not __getpagesize.
55 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
56 (struct hdr): The 'magic' member is now size_t, not unsigned long.
57
de85e130
PE
58 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
59
dcbf5805
MA
602012-04-22 Michael Albinus <michael.albinus@gmx.de>
61
62 Move functions from C to Lisp. Make non-blocking method calls
63 the default. Implement further D-Bus standard interfaces.
64
65 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
66 (QCdbus_request_name_allow_replacement)
67 (QCdbus_request_name_replace_existing)
68 (QCdbus_request_name_do_not_queue)
69 (QCdbus_request_name_reply_primary_owner)
70 (QCdbus_request_name_reply_in_queue)
71 (QCdbus_request_name_reply_exists)
72 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
73 (QCdbus_registered_serial, QCdbus_registered_method)
74 (QCdbus_registered_signal): New Lisp objects.
75 (XD_DEBUG_MESSAGE): Use sizeof.
76 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
77 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
78 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
79 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
80 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
81 (xd_signature, xd_append_arg): Allow float for integer types.
82 (xd_get_connection_references): New function.
83 (xd_get_connection_address): Rename from xd_initialize. Return
84 cached address.
85 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
86 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
87 level.
88 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
89 Return number of recounts.
90 (Fdbus_get_unique_name): Make stronger parameter check.
91 (Fdbus_message_internal): New defun.
92 (Fdbus_call_method, Fdbus_call_method_asynchronously)
93 (Fdbus_method_return_internal, Fdbus_method_error_internal)
94 (Fdbus_send_signal, Fdbus_register_service)
95 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
96 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
97 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
98 (Vdbus_compiled_version, Vdbus_runtime_version)
99 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
100 (Vdbus_message_type_method_return, Vdbus_message_type_error)
101 (Vdbus_message_type_signal): New defvars.
102 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
103 docstring.
104
52828e02
PE
1052012-04-22 Paul Eggert <eggert@cs.ucla.edu>
106
da05bc4c
PE
107 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
108 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
109 Do not assume ptrdiff_t is the same width as 'int'.
110
52828e02
PE
111 * alloc.c: Handle unusual debugging option combinations.
112 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
113 since the two debugging options are incompatible.
114 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
115 is defined.
116 (mem_init, mem_insert, mem_insert_fixup):
117 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
118 (NEED_MEM_INSERT): Remove; no longer needed.
119
f01769f9
LL
1202012-04-22 Leo Liu <sdl.web@gmail.com>
121
122 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
123
5790543d
PE
1242012-04-22 Paul Eggert <eggert@cs.ucla.edu>
125
126 * sysdep.c [__FreeBSD__]: Minor cleanups.
127 (list_system_processes, system_process_attributes) [__FreeBSD__]:
128 Use Emacs indenting style more consistently. Avoid some casts.
129 Use 'double' consistently rather than mixing 'float' and 'double'.
130
b91b7e4d
EW
1312012-04-21 Eduard Wiebe <usenet@pusto.de>
132
133 * sysdep.c (list_system_processes, system_process_attributes): Add
134 implementation for FreeBSD (Bug#5243).
135
6114eb15
AS
1362012-04-21 Andreas Schwab <schwab@linux-m68k.org>
137
138 * lisp.mk (lisp): Update.
139
2f38dff7
PE
1402012-04-20 Paul Eggert <eggert@cs.ucla.edu>
141
142 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
143 It is never used otherwise.
144
4ae29f89
SM
1452012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
146
147 * print.c (print_preprocess): Only check print_depth if print-circle
148 is nil.
149 (print_object): Check for cycles even when print-circle is nil and
150 print-gensym is t, but only check print_depth if print-circle is nil.
151
f30d612a
CY
1522012-04-20 Chong Yidong <cyd@gnu.org>
153
154 * process.c (wait_reading_process_output): If EIO occurs on a pty,
155 set the status to "failed" and ensure that sentinel is run.
156
c07a4c0b 1572012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
158
159 * process.c (Fset_process_inherit_coding_system_flag)
160 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 161 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 162
c07a4c0b 1632012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
164
165 * xdisp.c (string_buffer_position_lim): Limit starting position to
166 BEGV.
167 (set_cursor_from_row): If called for a mode-line or header-line
168 row, return zero immediately.
169 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
170 farther than the first row after the header line, if any.
171 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
172 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
173
c07a4c0b 1742012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 175
4ae29f89
SM
176 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
177 (bug#11238).
ad3a2b41 178
c07a4c0b 1792012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 1802012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
181
182 configure: new option --enable-gcc-warnings (Bug#11207)
183 * Makefile.in (C_WARNINGS_SWITCH): Remove.
184 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
185 (ALL_CFLAGS): Use new macros rather than old.
186 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
187 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
188 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
189 -Wunused-result, -Wunused-variable. This should go away once
190 the Emacs and Gnulib regex code is merged.
191 (xmalloc, xrealloc): Now static.
192
aba027e8
PE
1932012-04-17 Paul Eggert <eggert@cs.ucla.edu>
194
195 * dired.c (Fsystem_groups): Remove unused local.
196
e5a36063
GM
1972012-04-17 Glenn Morris <rgm@gnu.org>
198
199 * dired.c (Fsystem_users): Doc fix.
200
316411f0
DA
2012012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
202
203 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
204 (syms_of_dired): Add them.
205
9426aba4
PE
2062012-04-16 Paul Eggert <eggert@cs.ucla.edu>
207
b62a57be
PE
208 Fix minor alloc.c problems found by static checking.
209 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
210 New extern decls, to avoid calling undeclared functions.
211 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
212 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
213 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
214 (NEED_MEM_INSERT): New macro.
215 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 216 Remove one incorrect comment and fix another.
b62a57be 217
3539f31f
PE
218 Fix minor ralloc.c problems found by static checking.
219 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
220 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
221 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
222 (r_alloc_sbrk): Now static.
223
a041960a
PE
224 Improve ralloc.c interface checking.
225 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
226 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
227 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
228 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
229 [REL_ALLOC]: ... to here, to check interface.
230 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
231 Remove decls. This fixes an "It stinks!".
232
9426aba4
PE
233 * alloc.c (which_symbols): Fix alignment issue / type clash.
234
d55c12ed
AS
2352012-04-15 Andreas Schwab <schwab@linux-m68k.org>
236
237 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
238 (struct Lisp_Misc_Any): Likewise.
239 (struct Lisp_Free): Likewise.
240 * alloc.c (union aligned_Lisp_Symbol): Define.
241 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
242 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
243 (union aligned_Lisp_Misc): Define.
244 (MARKER_BLOCK_SIZE, struct marker_block): Use union
245 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 246 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 247
b948ce8b
PE
2482012-04-14 Paul Eggert <eggert@cs.ucla.edu>
249
250 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
251 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
252 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
253 * s/netbsd.h, s/sol2-6.h:
254 Remove definition of GC_MARK_STACK, since the default now works.
255 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
256 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
257 no longer the default.
258 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
259
35dc09a1 2602012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 261
35dc09a1
GM
262 * lread.c (lisp_file_lexically_bound_p):
263 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 264
35dc09a1
GM
2652012-04-14 Eli Zaretskii <eliz@gnu.org>
266
267 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
268 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
269
2702012-04-14 Jan Djärv <jan.h.d@swipnet.se>
271
272 * nsterm.m (constrainFrameRect): Always constrain when there is only
273 one screen (Bug#10962).
274
bcd86815
KB
2752012-04-13 Ken Brown <kbrown@cornell.edu>
276
277 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
278
c25df26e
RT
2792012-04-13 Reuben Thomas <rrt@sc3d.org>
280
281 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
282
0fc59f1e
DC
2832012-04-11 Daniel Colascione <dancol@dancol.org>
284
285 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
286 against is gone. It's better to use vfork now so that when Cygwin
287 gains a new, working vfork, we use it automatically (bug#10398).
288
de8c03dc
SM
2892012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
290
291 * window.c (save_window_save): Obey window-point-insertion-type.
292
2f097256
GM
2932012-04-11 Glenn Morris <rgm@gnu.org>
294
295 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
296
453b951e
SM
2972012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
298
299 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
300
75f1671a 3012012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
302
303 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
304 (force_quit_count): New var.
305 (handle_interrupt): Use it.
306
2a8ce227
JB
3072012-04-10 Juanma Barranquero <lekktu@gmail.com>
308
309 * w32.c (w32_delayed_load): Record the full path of the library
310 being loaded (bug#10424).
311
935396c0
GM
3122012-04-09 Glenn Morris <rgm@gnu.org>
313
05920a43
GM
314 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
315 not just in the obarray, before snarfing them. (Bug#11036)
316
935396c0
GM
317 * Makefile.in ($(leimdir)/leim-list.el):
318 Pass EMACS rather than BUILT_EMACS.
319
a18ecafa
TZ
3202012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
321
322 * process.c (make_process):
323 * process.h: Add integer `gnutls_handshakes_tried' member to
324 process struct.
325
6bbef4e5
JC
326 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
327 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
328
329 * gnutls.c (gnutls_log_function2i): Convenience log function.
330 (emacs_gnutls_read): Use new log functions,
331 `gnutls_handshakes_tried' process member, and
332 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
333 attempts per process (connection).
334
b4d3bc10
CY
3352012-04-09 Chong Yidong <cyd@gnu.org>
336
337 * eval.c (Fuser_variable_p, user_variable_p_eh)
338 (lisp_indirect_variable): Functions deleted.
339 (Fdefvar): Caller changed.
340
341 * callint.c (Finteractive, Fcall_interactively):
342 * minibuf.c (Fread_variable): Callers changed.
343
70f4d973
EZ
3442012-04-09 Eli Zaretskii <eliz@gnu.org>
345
346 * xdisp.c (set_cursor_from_row): If the display string appears in
347 the buffer at position that is closer to point than the position
348 after the display string, display the cursor on the first glyph of
349 the display string. Fixes cursor display when a 'display' text
350 property immediately follows invisible text. (Bug#11094)
351
cb3c2e3e
PE
3522012-04-09 Paul Eggert <eggert@cs.ucla.edu>
353
354 composite.c: use 'double' consistently
355 * composite.c (get_composition_id): Use 'double' consistently
356 instead of converting 'float' to 'double' and vice versa; this is
357 easier to understand and avoids a GCC warning.
358
fd06db5d
GM
3592012-04-09 Glenn Morris <rgm@gnu.org>
360
50fe702a
GM
361 * Makefile.in: Generate leim-list with bootstrap-emacs, in
362 preparation for dumping it with emacs. (Bug#4789)
363 (leimdir): New variable.
364 ($(leimdir)/leim-list.el): New rule.
365 (emacs$(EXEEXT)): Depend on leim-list.el.
366
fd06db5d
GM
367 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
368 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
369 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
370
55c131ee
AS
3712012-04-08 Andreas Schwab <schwab@linux-m68k.org>
372
373 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
374 proper alignment.
375
9209588f
JB
3762012-04-07 Juanma Barranquero <lekktu@gmail.com>
377
378 * xml.c (init_libxml2_functions) [WINDOWSNT]:
379 Remove unused local variable.
380
e3fb2efb
PE
3812012-04-07 Paul Eggert <eggert@cs.ucla.edu>
382
383 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
384 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
385 (mark_memory): Mark Lisp_Objects only if pointers might hide in
386 objects, as mark_maybe_pointer will catch them otherwise.
387 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
388 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
389
b5385551
PE
3902012-04-07 Paul Eggert <eggert@cs.ucla.edu>
391
392 Fix typo that broke non-Windows builds.
393 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
394
9078ead6
EZ
3952012-04-07 Eli Zaretskii <eliz@gnu.org>
396
397 Support building on MS-Windows with libxml2.
398
399 * makefile.w32-in (OBJ2): Add xml.$(O).
400 (GLOBAL_SOURCES): Add xml.c.
401 ($(BLD)/xml.$(O)): New dependency list.
402
403 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
404 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
405 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
406 [!WINDOWSNT]: New macros.
407 (init_libxml2_functions, libxml2_loaded_p): New functions.
408 (parse_region): Call fn_xmlCheckVersion instead of using the macro
409 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
410 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
411 Calls xmlCleanupParser only if libxml2 was loaded (or statically
412 linked in).
6bbef4e5
JC
413 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
414 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
415 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
416
417 * emacs.c: Don't include libxml/parser.h.
418 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
419 xmlCleanupParser directly.
420
421 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
422
3811fdf3
EZ
4232012-04-07 Eli Zaretskii <eliz@gnu.org>
424
425 * indent.c (Fvertical_motion): If there is a display string at
426 point, use it.vpos to compute how many lines to backtrack after
427 move_it_to point. (Bug#11133)
428
2f8e16b2
EZ
4292012-04-06 Eli Zaretskii <eliz@gnu.org>
430
431 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
432 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
433 about subtle differences between FETCH_CHAR* and STRING_CHAR*
434 macros related to unification of CJK characters. For the details,
435 see the discussion following the message here:
436 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
437
3d439cd1
CY
4382012-04-04 Chong Yidong <cyd@gnu.org>
439
440 * keyboard.c (Vdelayed_warnings_list): Doc fix.
441
8bc53d00
EZ
4422012-04-01 Eli Zaretskii <eliz@gnu.org>
443
444 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
445 instead of alloca. (Bug#11138)
446
3b0512a3
AS
4472012-04-01 Andreas Schwab <schwab@linux-m68k.org>
448
449 * w32menu.c (is_simple_dialog): Properly check lisp types.
450 (Bug#11141)
451
8427ddd2
EZ
4522012-03-31 Eli Zaretskii <eliz@gnu.org>
453
979022ef
EZ
454 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
455 position we get to after a call to move_it_to fails the
456 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
457 only if we wind up in a string from display property. (Bug#11063)
458
a6b1c7cc
EZ
459 * window.c (Fdelete_other_windows_internal): Invalidate the row
460 and column information about mouse highlight, so that redisplay
461 restores it after reallocating the glyph matrices. (Bug#7464)
462
8427ddd2
EZ
463 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
464 string comes from a `display' text property, use the buffer
465 position of that property as if we actually saw that position in
466 the row's glyphs.
697ba24b
EZ
467 (move_it_by_lines): Remove the assertion that
468 "it->current_x == 0 && it->hpos == 0" which can be legitimately
469 violated when there's a before-string at the beginning of a line.
470 (Bug#11063)
8427ddd2 471
65a0a738
EZ
4722012-03-30 Eli Zaretskii <eliz@gnu.org>
473
474 * xdisp.c (append_space_for_newline): If the default face was
475 remapped, use the remapped face for the appended newline.
476 (extend_face_to_end_of_line): Use the remapped default face for
477 extending the face to the end of the line.
478 (display_line): Call extend_face_to_end_of_line when the default
479 face was remapped. (Bug#11068)
480
581355cc
EZ
4812012-03-29 Eli Zaretskii <eliz@gnu.org>
482
483 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
484
e8fc049f
SM
4852012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
486
487 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
488
4fb9a543
GM
4892012-03-27 Glenn Morris <rgm@gnu.org>
490
491 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
492 Doc fixes.
493
679910f1
KH
4942012-03-26 Kenichi Handa <handa@m17n.org>
495
496 * dispextern.h (struct glyph): Fix previous change. Change the
497 bit length of glyphless.ch to 25 (Bug#11082).
498
90d49b7f
CY
4992012-03-26 Chong Yidong <cyd@gnu.org>
500
501 * keyboard.c (Vselection_inhibit_update_commands): New variable.
502 (command_loop_1): Use it; inhibit selection update for
503 handle-select-window too (Bug#8996).
504
f514f6f0
FP
5052012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
506
e8fc049f 507 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 508
bf43fa51
KH
5092012-03-25 Kenichi Handa <handa@m17n.org>
510
511 * dispextern.h (struct glyph): Change the bit length of
512 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
513
8a0c01dd
EZ
5142012-03-24 Eli Zaretskii <eliz@gnu.org>
515
516 * s/ms-w32.h (tzname): Include time.h before redirecting to
517 _tzname. Fixes the MSVC build. (Bug#9960)
518
7d1c3a76
AS
5192012-03-24 Andreas Schwab <schwab@linux-m68k.org>
520
8ed79523
AS
521 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
522 characters.
523
7d1c3a76
AS
524 * xterm.c (XTread_socket): Only modify handling_signal if
525 !SYNC_INPUT. (Bug#11080)
526
e99a9b8b
EZ
5272012-03-23 Eli Zaretskii <eliz@gnu.org>
528
529 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
530 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
531 when fetching a multibyte character consumes more bytes than
532 CHAR_BYTES returns, due to unification of CJK characters in
533 string_char. (Bug#11073)
534
5063c0e1
TN
5352012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
536
537 * process.c (wait_reading_process_output): Handle pty disconnect
538 by refraining from sending oneself a SIGCHLD (bug#10933).
539
9f851fbd
CY
5402012-03-22 Chong Yidong <cyd@gnu.org>
541
542 * dispextern.h (struct it): New member string_from_prefix_prop_p.
543
5063c0e1 544 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
545 Mark string as coming from a prefix property.
546 (handle_face_prop): Use default face for prefix strings (Bug#4281).
547 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
548
fb5b8aca
CY
5492012-03-21 Chong Yidong <cyd@gnu.org>
550
551 * xfaces.c (Vface_remapping_alist): Doc fix.
552
62356a1b
EZ
5532012-03-20 Eli Zaretskii <eliz@gnu.org>
554
555 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
556 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
557 Doc fixes.
62356a1b 558
025de85b
CY
5592012-03-20 Chong Yidong <cyd@gnu.org>
560
561 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
562 to reflect default non-nil value of redisplay-dont-pause.
563
4827f94e
KH
5642012-03-19 Kenichi Handa <handa@m17n.org>
565
566 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
567 it fit in a valid range (Bug#11003).
568
e50a24a2
EZ
5692012-03-18 Eli Zaretskii <eliz@gnu.org>
570
571 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
572 that is not from display property, accept the row as a "cursor
573 row" if one of the string's character has a non-nil `cursor'
574 property. Fixes cursor positioning when there are newlines in
575 overlay strings, e.g. in icomplete.el. (Bug#11035)
576
9af5ed87
PE
5772012-03-12 Paul Eggert <eggert@cs.ucla.edu>
578
579 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
580
d1f55f16
CY
5812012-03-12 Chong Yidong <cyd@gnu.org>
582
583 * eval.c (inhibit_lisp_code): Rename from
584 inhibit_window_configuration_change_hook; move from window.c.
585
586 * xfns.c (unwind_create_frame_1, Fx_create_frame):
587 * window.c (run_window_configuration_change_hook)
588 (syms_of_window): Callers changed.
589
66c5eebd
CY
5902012-03-11 Chong Yidong <cyd@gnu.org>
591
413df973
CY
592 * keymap.c (Fkey_description): Doc fix (Bug#9700).
593
66c5eebd
CY
594 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
595
1de11f56
CY
5962012-03-10 Chong Yidong <cyd@gnu.org>
597
598 * frame.c (other_visible_frames): Don't assume the selected frame
599 is visible (Bug#10955).
600
cae07000
SM
6012012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
602
603 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
604
89c94350
JD
6052012-03-08 Jan Djärv <jan.h.d@swipnet.se>
606
607 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
608 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
609 zero (Bug#10954).
610
999dd333
GM
6112012-03-03 Glenn Morris <rgm@gnu.org>
612
01a6dcc8 613 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 614
de0100f2
EZ
6152012-03-02 Eli Zaretskii <eliz@gnu.org>
616
617 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
618 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
619 (redisplay_window, next_element_from_string): Fix typos in
620 comments.
3e441275
EZ
621 (redisplay_window): Pass to move_it_vertically the margin in
622 pixels, not in screen lines.
de0100f2 623
96a72ee9
GM
6242012-03-02 Glenn Morris <rgm@gnu.org>
625
626 * buffer.c (buffer-list-update-hook): Doc fix.
627
312508d7
EZ
6282012-02-29 Eli Zaretskii <eliz@gnu.org>
629
630 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
631 push_it before setting up the iterator for the first overlay
632 string, even if we have an empty string loaded.
633 (next_overlay_string): If there's an empty string on the iterator
634 stack, pop the stack. (Bug#10903)
635
27f3c637
PE
6362012-02-25 Paul Eggert <eggert@cs.ucla.edu>
637
638 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
639 Suggested by Stefan Monnier in
640 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
641 * alloc.c (widen_to_Lisp_Object): New static function.
642 (mark_memory): Also mark Lisp_Objects by fetching pointer words
643 and widening them to Lisp_Objects. This would work even if
644 USE_LSB_TAG is defined and wide integers are used, which might
645 happen in a future version of Emacs.
646
3c9dfce6
CY
6472012-02-25 Chong Yidong <cyd@gnu.org>
648
fa74b241
CY
649 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
650 Doc fix.
651
3c9dfce6
CY
652 * xselect.c (Fx_selection_exists_p): Doc fix.
653 (x_clipboard_manager_save_all): Print an informative message
654 before saving to clipboard manager.
655
9486df08
CY
6562012-02-24 Chong Yidong <cyd@gnu.org>
657
658 * keyboard.c (process_special_events): Handle all X selection
659 requests in kbd_buffer, not just the next one (Bug#8869).
660
f01d3321
CY
6612012-02-23 Chong Yidong <cyd@gnu.org>
662
663 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
664 call when setting menu-bar-lines and tool-bar-lines parameters.
665 (unwind_create_frame_1): New helper function.
666
667 * window.c (inhibit_window_configuration_change_hook): New var.
668 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 669 (syms_of_window): Initialize it.
f01d3321 670
86b847b6
CY
6712012-02-22 Chong Yidong <cyd@gnu.org>
672
673 * xterm.c (x_draw_image_relief): Add missing type check for
674 Vtool_bar_button_margin (Bug#10743).
675
a59225b1
CY
6762012-02-21 Chong Yidong <cyd@gnu.org>
677
678 * fileio.c (Vfile_name_handler_alist): Doc fix.
679
680 * buffer.c (Fget_file_buffer): Protect against invalid file
681 handler return value.
682
310f5bd4
PE
6832012-02-20 Paul Eggert <eggert@cs.ucla.edu>
684
cb3a28cc
PE
685 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
686 when computing $valmask.
687
310f5bd4
PE
688 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
689 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
690 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
691 It's useless in that case, and it can cause problems on hosts
692 that allocate halves of EMACS_INT values separately.
693 Reported by Dan Horák. Diagnosed by Andreas Schwab in
694 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
695 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
696 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
697 it avoids undefined behavior on hosts where shifting right by more
698 than the word width has undefined behavior.
699
2375c96a
CY
7002012-02-19 Chong Yidong <cyd@gnu.org>
701
702 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
703 (Funhandled_file_name_directory, Ffile_name_as_directory)
704 (Fdirectory_file_name, Fexpand_file_name)
705 (Fsubstitute_in_file_name): Protect against invalid file handler
706 return values (Bug#10845).
707
3eb49e71
EZ
7082012-02-18 Eli Zaretskii <eliz@gnu.org>
709
710 * .gdbinit (pitx): Fix incorrect references to fields of the
711 iterator stack.
712
7b926f3f
CY
7132012-02-17 Chong Yidong <cyd@gnu.org>
714
715 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
716
11273115
PE
7172012-02-15 Paul Eggert <eggert@cs.ucla.edu>
718
719 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
720 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
721
c3a70e2b
CY
7222012-02-15 Chong Yidong <cyd@gnu.org>
723
724 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
725 marked as special. Also, starting docstrings with * is obsolete.
726
0ca43699
AS
7272012-02-13 Andreas Schwab <schwab@linux-m68k.org>
728
729 * gnutls.c (emacs_gnutls_write): Fix last change.
730
2e8f3c56
LI
7312012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
732
733 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
734 send_process.
735
af70074f
SM
7362012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
737
738 * keymap.c (Fsingle_key_description): Handle char ranges.
739
95986d52
CY
7402012-02-12 Chong Yidong <cyd@gnu.org>
741
afd83bd1
CY
742 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
743 as that creates a dangerous corner case.
744
95986d52
CY
745 * window.c (Fdelete_window_internal): Invalidate the mouse
746 highlight (Bug#9904).
747
bd7da63e
GM
7482012-02-12 Glenn Morris <rgm@gnu.org>
749
750 * xselect.c (Fx_own_selection_internal)
751 (Fx_get_selection_internal, Fx_disown_selection_internal)
752 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
753 * nsselect.m (Fx_own_selection_internal)
754 (Fx_disown_selection_internal, Fx_selection_exists_p)
755 (Fx_selection_owner_p, Fx_get_selection_internal):
756 Sync docs and argument specs with the xselect.c versions.
757
77abcbc2
LI
7582012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
759
760 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
761
90b671e2
EZ
7622012-02-11 Eli Zaretskii <eliz@gnu.org>
763
1c0ca0b7
EZ
764 * w32select.c (Fx_selection_exists_p): Sync doc string and
765 argument list with xselect.c. (Bug#10783)
766
767 * w16select.c (Fx_selection_exists_p): Sync doc string and
768 argument list with xselect.c. (Bug#10783)
90b671e2 769
49241268
GM
7702012-02-10 Glenn Morris <rgm@gnu.org>
771
772 * fns.c (Fsecure_hash): Doc fix.
773
f998bbe7 7742012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
775
776 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
777
0992bd9c
CY
7782012-02-07 Chong Yidong <cyd@gnu.org>
779
780 * buffer.c (Fbuffer_local_variables)
781 (buffer_lisp_local_variables): Handle unbound vars correctly;
782 don't let Qunbound leak into Lisp.
783
af008560
GM
7842012-02-07 Glenn Morris <rgm@gnu.org>
785
dd605cc4
GM
786 * image.c (Fimagemagick_types): Doc fix.
787
af008560
GM
788 * image.c (imagemagick-render-type): Change it from a lisp object
789 to an integer. Move the doc here from the lisp manual.
790 Treat all values not equal to 0 the same.
791
1449fa1d
CY
7922012-02-06 Chong Yidong <cyd@gnu.org>
793
794 * doc.c (store_function_docstring): Avoid applying docstring of
795 alias to base function (Bug#2603).
796
3723ec07
AS
7972012-02-04 Andreas Schwab <schwab@linux-m68k.org>
798
799 * .gdbinit (pp1, pv1): Remove redundant defines.
800 (pr): Use pp.
801
79c1cc1e
CY
8022012-02-04 Chong Yidong <cyd@gnu.org>
803
804 * nsterm.m: Declare a global (Bug#10694).
805
d7f29f8e
EZ
8062012-02-04 Eli Zaretskii <eliz@gnu.org>
807
cae07000
SM
808 * w32.c (get_emacs_configuration_options):
809 Include --enable-checking, if specified, in the return value.
d7f29f8e 810
3b95a6f9
MR
8112012-02-04 Martin Rudalics <rudalics@gmx.at>
812
813 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
814 after rounding frame sizes. (Bug#9723)
815
d6fa96a6
EZ
8162012-02-04 Eli Zaretskii <eliz@gnu.org>
817
818 * keyboard.c (adjust_point_for_property): Don't position point
819 before BEGV. (Bug#10696)
820
df0b2940
PE
8212012-02-03 Paul Eggert <eggert@cs.ucla.edu>
822
823 Handle overflow when computing char display width (Bug#9496).
824 * character.c (char_width): Return EMACS_INT, not int.
825 (char_width, c_string_width): Check for overflow when
826 computing the width; this is possible now that individual
827 characters can have unbounded width. Problem introduced
828 by merge from Emacs 23 on 2012-01-19.
829
6bee44d6
MA
8302012-02-02 Michael Albinus <michael.albinus@gmx.de>
831
832 * dbusbind.c (Fdbus_register_method): Mention the return value
833 :ignore in the docstring.
834
44f92739
GM
8352012-02-02 Glenn Morris <rgm@gnu.org>
836
1b9f60cc
GM
837 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
838
44f92739
GM
839 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
840 Unconditionally set to t. (Bug#10673)
841 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
842 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
843 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
844
c5d3843c
KH
8452012-02-02 Kenichi Handa <handa@m17n.org>
846
847 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
848 0, do not call append_composite_glyph.
849
159462d4 8502012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
851
852 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
853 NULL (Bug#6988).
854 (x_produce_glyphs): If the component of a composition is a null
855 string, set it->pixel_width to 1 to avoid zero-width glyph.
856
78cef877
EZ
8572012-02-01 Eli Zaretskii <eliz@gnu.org>
858
859 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
860 first 2 arguments are identical. This makes inserting large
861 output from a subprocess an order of magnitude faster on
862 MS-Windows, where all sbrk'ed memory is always contiguous.
863
97897668
GM
8642012-01-31 Glenn Morris <rgm@gnu.org>
865
866 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 867 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
868 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
869
31fd3586
GM
8702012-01-29 Glenn Morris <rgm@gnu.org>
871
872 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
873
0e24a8b2
CY
8742012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
875
876 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
877
cc0adcb0
CY
8782012-01-28 Chong Yidong <cyd@gnu.org>
879
880 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
881
acc28cb9
CY
8822012-01-26 Chong Yidong <cyd@gnu.org>
883
9c69cfb7
CY
884 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
885
acc28cb9
CY
886 * search.c (Fsearch_forward, Fsearch_backward): Document negative
887 repeat counts (Bug#10507).
888
48da7392
GM
8892012-01-26 Glenn Morris <rgm@gnu.org>
890
891 * lread.c (syms_of_lread): Doc fix.
892
14af5f7f
CY
8932012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
894
895 * coding.c (encode_designation_at_bol): Change return value to
896 EMACS_INT.
897
0b21c100
CY
8982012-01-25 Chong Yidong <cyd@gnu.org>
899
900 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
901
3c2907f7
CY
9022012-01-21 Chong Yidong <cyd@gnu.org>
903
904 * floatfns.c (Fcopysign): Make the second argument non-optional,
905 since nil is not allowed anyway.
906
959ad23f
AS
9072012-01-21 Andreas Schwab <schwab@linux-m68k.org>
908
909 * process.c (read_process_output): Use p instead of XPROCESS (proc).
910 (send_process): Likewise.
911
34a02f46
MR
9122012-01-19 Martin Rudalics <rudalics@gmx.at>
913
914 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
915 (Vwindow_persistent_parameters): Do not use Qstate.
916 Rewrite doc-strings.
34a02f46 917
1259009a 9182012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
919
920 * character.c (char_width): New function.
70d4fdf6
GM
921 (Fchar_width, c_string_width, lisp_string_width):
922 Use char_width (Bug#9496).
25ed9e61 923
6a6ee00d
MR
9242012-01-16 Martin Rudalics <rudalics@gmx.at>
925
926 * window.c (Vwindow_persistent_parameters): New variable.
927 (Fset_window_configuration, save_window_save): Handle persistent
928 window parameters.
929
c85efaf7
EZ
9302012-01-14 Eli Zaretskii <eliz@gnu.org>
931
932 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
933 thrashing the stack of the thread. (Bug#9087)
934
5944709e
PE
9352012-01-12 Paul Eggert <eggert@cs.ucla.edu>
936
937 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
938
e71f5d99
EZ
9392012-01-11 Eli Zaretskii <eliz@gnu.org>
940
941 * xdisp.c (rows_from_pos_range): Handle the case where the
942 highlight ends on a newline. (Bug#10464)
943 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
944 he end column for display of highlight that ends on a newline
945 before a R2L line.
946
ce316182
GM
9472012-01-11 Glenn Morris <rgm@gnu.org>
948
949 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
950 from load-path also when installation-directory is nil. (Bug#10208)
951
5b43da69
GM
9522012-01-10 Glenn Morris <rgm@gnu.org>
953
74cc8ff9
GM
954 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
955
7d8d6e4e
GM
956 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
957 Update template values to be closer to their typical values these days.
5b43da69 958
a0db8d43
EZ
9592012-01-09 Eli Zaretskii <eliz@gnu.org>
960
961 * xdisp.c (rows_from_pos_range): Accept additional argument
962 DISP_STRING, and accept any glyph in a row whose object is that
963 string as eligible for mouse highlight. Fixes mouse highlight of
964 display strings from overlays. (Bug#10464)
965
9a0115ab 9662012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 967
b9110d6a 968 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
969 * fileio.c (auto_saving_dir_umask): New static var.
970 (Fmake_directory_internal): Use it.
971 (do_auto_save_make_dir): Set it, instead of invoking chmod after
972 creating the directory. The old code temporarily assigns
973 too-generous permissions to the directory.
974 (do_auto_save_eh): Clear it.
b9110d6a 975 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
976 that the var is always cleared.
977
6c1bd3f3
EZ
9782012-01-07 Eli Zaretskii <eliz@gnu.org>
979
980 * search.c (scan_buffer): Pass character positions to
981 know_region_cache, not byte positions. (Bug#6540)
982
069d2b50
L
9832012-01-07 LynX <_LynX@bk.ru> (tiny change)
984
985 * w32.c (sys_rename): Report EXDEV when rename of a directory
986 fails because the target is on another logical disk. (Bug#10284)
987
75bf0d33
DB
9882012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
989
990 * xterm.c (x_embed_request_focus): New function.
991
992 * xterm.h: Add prototype.
993
994 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
995
1c6e5a32
GM
9962012-01-05 Glenn Morris <rgm@gnu.org>
997
998 * emacs.c (emacs_copyright): Update short copyright year to 2012.
999
651e947e
EZ
10002012-01-01 Eli Zaretskii <eliz@gnu.org>
1001
1002 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1003 Load gnutls_transport_set_lowat only if GnuTLS version is below
1004 2.11.1.
1005 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1006 GnuTLS versions below 2.11.1.
1007
3778cdd8
AL
10082011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1009
1010 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1011 to the doc string advising against its use for altering the way
1012 windows are scrolled.
1013
0e5317f7
KH
10142011-12-28 Kenichi Handa <handa@m17n.org>
1015
1016 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1017 coding-system ASCII compatible only when it does not produce BOM
1018 on encoding (Bug#10383).
1019
93d5ca1f
JD
10202011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1021
1022 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1023 can scroll.
1024 (create_and_show_popup_menu): Always use menu_position_func for
1025 Gtk3 (Bug#10361).
1026
ca22b785
AS
10272011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1028
1029 * callint.c (Fcall_interactively): Don't truncate prompt string.
1030
d048e1e6
EZ
10312011-12-23 Eli Zaretskii <eliz@gnu.org>
1032
1033 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1034 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1035 resumed from there (after widening). (Bug#10360)
d048e1e6 1036
5ccaba1f
JD
10372011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1038
1039 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1040
204ee57f
JD
10412011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1042
b81d40f0
JB
1043 * nsterm.m (x_free_frame_resources):
1044 Release f->output_data.ns->miniimage.
204ee57f
JD
1045 (ns_index_color): Fix indentation. Do not retain
1046 color_table->colors[i].
1047
1048 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1049 before returning.
1050
1051 * nsfns.m (x_set_background_color): Assign return value from
1052 ns_index_color to face-background instead of NSColor*.
1053 (ns_implicitly_set_icon_type): Fix indentation.
1054 Change assignment in for loop to comparison.
1055
1056 * emacs.c (ns_pool): New variable.
1057 (main): Assign ns_pool.
1058 (Fkill_emacs): Call ns_release_autorelease_pool.
1059
1060 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1061 autorelease fdesc, release fdAttrs and tdict.
1062 (ns_get_covering_families): Release charset.
1063 (ns_findfonts): Release NSFontDescriptor created with new.
1064 (ns_uni_to_glyphs): Fix indentation.
1065 (setString): Release attrStr before assigning new value.
1066
c803b2b7
JD
10672011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1068
678f4426
JD
1069 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1070 and NS_IMPL_COCOA.
1071 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1072 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1073
cd394be1 10742011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1075
5fecd5fc
JD
1076 * nsterm.m (ns_term_init): Subscribe for notifications
1077 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1078 to method trackingNotification in EmacsMenu.
1079
1080 * nsmenu.m (trackingMenu): New variable.
3771cb17 1081 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1082 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1083 from Aquamacs (Bug#7030).
678f4426
JD
1084
10852011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1086
c803b2b7
JD
1087 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1088 (symbol_to_nsstring): Fix indentation.
1089 (ns_symbol_to_pb): New function.
cae07000
SM
1090 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1091 (Fns_rotate_cut_buffers_internal): Remove.
1092 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1093 Fns_store_cut_buffer_internal.
1094 (ns_get_foreign_selection, Fx_own_selection_internal)
1095 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1096 (Fns_get_selection_internal, Fns_store_selection_internal):
1097 Use ns_symbol_to_pb and check if return value is nil.
1098 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1099 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1100 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1101 renamed to Sns_store_selection_internal.
1102 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1103 and remove this function.
1104 (ns_handle_selection_clear): Remove, never used.
1105 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1106 here.
1107
e1b01a3a
KB
11082011-12-17 Ken Brown <kbrown@cornell.edu>
1109
1110 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1111 GID is unknown (Bug#10257).
1112
2adb6e85
PE
11132011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1114
1115 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1116 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1117 which caused a build failure on GNU/Linux IA-64. This problem was
1118 introduced by my 2011-10-07 patch.
1119
d1d7b339
JL
11202011-12-15 Juri Linkov <juri@jurta.org>
1121
1122 * image.c (imagemagick_error): New function. (Bug#10112)
1123 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1124 Use `imagemagick_error' where ImageMagick functions return
1125 `MagickFalse'.
1126 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1127 proper order.
1128
100d5755
KH
11292011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1130
1131 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1132 fill background (Bug#8992).
1133
454592a6
MR
11342011-12-13 Martin Rudalics <rudalics@gmx.at>
1135
1136 * window.c (Vwindow_combination_resize)
1137 (Vwindow_combination_limit): Use t instead of non-nil in
1138 doc-strings.
61d4b438
MR
1139 (Vrecenter_redisplay): Add first sentence of doc-string on
1140 separate line.
53524d93 1141 (Frecenter): Fix doc-string typo.
454592a6 1142
3633e3aa
KH
11432011-12-11 Kenichi Handa <handa@m17n.org>
1144
1145 * coding.c (Funencodable_char_position): Pay attention to the
1146 buffer text relocation (Bug#9389).
1147
7b9d523a
JD
11482011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1149
1150 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1151 gtk_init (Bug#10100).
1152
b73189c6
EZ
11532011-12-10 Eli Zaretskii <eliz@gnu.org>
1154
1155 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1156 IT->string is nil. (Bug#10263)
1157
f7dfe5d6
JD
11582011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1159
83faebb4
JD
1160 * nsterm.h (x_free_frame_resources): Declare.
1161
f7dfe5d6
JD
1162 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1163 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1164
1165 * nsterm.h (ns_get_defaults_value): Declare.
1166
1167 * nsterm.m (ns_default): Call ns_get_defaults_value.
1168
7cd4e72c
EZ
11692011-12-09 Eli Zaretskii <eliz@gnu.org>
1170
1171 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1172 (Bug#10170)
1173
b34d7317
YM
11742011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1175
1176 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1177 that where the value of an _OBJC_* symbol points to is in the .bss
1178 section (Bug#10240).
1179
76470ad1
KH
11802011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1181
1182 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1183 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1184
745fff94
KH
11852011-12-08 Kenichi Handa <handa@m17n.org>
1186
1187 * ftfont.c (get_adstyle_property): Fix previous change
1188 (Bug#10233).
1189
6e44397c
JB
11902011-12-07 Juanma Barranquero <lekktu@gmail.com>
1191
1192 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1193 dirs from the default value of EMACSLOADPATH (bug#10208).
1194
7efa6272
GM
11952011-12-07 Glenn Morris <rgm@gnu.org>
1196
1197 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1198 installation and source directories as well. (Bug#10208)
1199
f6fc4d87
CY
12002011-12-06 Chong Yidong <cyd@gnu.org>
1201
1202 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1203
2bf26180
GM
12042011-12-06 Glenn Morris <rgm@gnu.org>
1205
1206 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1207 as an error, not just -1. (Bug#10217)
1208
3a6ad4f0
CY
12092011-12-05 Chong Yidong <cyd@gnu.org>
1210
1211 * keyboard.c (process_special_events): New function.
1212 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1213
75a3b399
PE
12142011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1215
1216 * coding.c (encode_designation_at_bol): Don't use uninitialized
1217 local variable (Bug#9318).
1218
c3c9e25e
KH
12192011-12-05 Kenichi Handa <handa@m17n.org>
1220
1221 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1222 return Qnil (Bug#8046, Bug#10193).
1223
5eb05ea3
KH
12242011-12-05 Kenichi Handa <handa@m17n.org>
1225
1226 * coding.c (encode_designation_at_bol): New args charbuf_end and
1227 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1228 (coding_set_source): Return how many bytes coding->source was
1229 relocated.
1230 (coding_set_destination): Return how many bytes
1231 coding->destination was relocated.
1232 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1233 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1234
12352011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1236
1237 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1238 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1239 macro (Bug#9318).
1240
12412011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1242
1243 The following changes are to fix Bug#9318.
1244
a79703f5 1245 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1246 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1247 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1248 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1249
7dbda6df
JB
12502011-12-05 Juanma Barranquero <lekktu@gmail.com>
1251
1252 * lisp.h (process_quit_flag): Fix external declaration.
1253
6d5eb5b0
SM
12542011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1255
1256 Don't macro-inline non-performance-critical code.
1257 * eval.c (process_quit_flag): New function.
1258 * lisp.h (QUIT): Use it.
1259
a0c3fad0
JD
12602011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1261
1262 * nsfns.m (get_geometry_from_preferences): New function.
1263 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1264
6c07aac2
AS
12652011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1266
1267 * emacs.c (Qkill_emacs): Define.
1268 (syms_of_emacs): Initialize it.
1269 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1270 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1271 (quit_throw_to_read_char): Add parameter `from_signal'.
1272 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1273 * lisp.h (QUIT): Call Fkill_emacs if requested.
1274
c052ead4
JD
12752011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1276
1277 * widget.c (update_wm_hints): Return if wmshell is null.
1278 (widget_update_wm_size_hints): New function.
1279
1280 * widget.h (widget_update_wm_size_hints): Declare.
1281
1282 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1283 widget_update_wm_size_hints (Bug#10104).
1284
9e49252b
EZ
12852011-12-03 Eli Zaretskii <eliz@gnu.org>
1286
1287 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1288 before a newline, prepare the bidi iterator for consuming the
1289 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1290 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1291
02b16839
JL
12922011-12-02 Juri Linkov <juri@jurta.org>
1293
1294 * search.c (Fword_search_regexp): New Lisp function created from
1295 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1296 (Fword_search_backward, Fword_search_forward)
1297 (Fword_search_backward_lax, Fword_search_forward_lax):
1298 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1299 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1300
0068070e
SM
13012011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1302
1303 * fileio.c (Finsert_file_contents): Move after-change-function call
1304 to before the "handled:" label, since all "goto handled" appear in
1305 cases where the *-change-functions have already been properly called
1306 (bug#10117).
1307
3360a3fc
AS
13082011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1309
1310 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1311 waiting for input. (Bug#10169)
1312
73d6c093
EZ
13132011-11-30 Eli Zaretskii <eliz@gnu.org>
1314
1315 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1316 verifies glyph row's hash code--we have just reallocated the
1317 glyphs, so their contents can be complete garbage. (Bug#10164)
1318
febe6bea
JB
13192011-11-30 Juanma Barranquero <lekktu@gmail.com>
1320
1321 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1322
801a4313
EZ
13232011-11-30 Eli Zaretskii <eliz@gnu.org>
1324
1325 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1326 attributes are tested _before_ calling verify_row_hash, to protect
1327 against GCC re-ordering of the tests. (Bug#10164)
1328
2b56b87e
JD
13292011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1330
1331 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1332
1333 * xterm.c (handle_one_xevent): Only set async_visible and friends
1334 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1335 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1336 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1337
dbf31225
PE
13382011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1341 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1342 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1343 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1344 All uses changed to use GCPRO1 etc.
1345 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1346 Revert to old implementation (i.e., before 2011-03-11).
1347
1305621b
YM
13482011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1349
1350 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1351 of scroll runs so as to avoid assigning disabled bogus rows and
1352 unnecessary graphics copy operations.
1353
8c9afb46
EZ
13542011-11-27 Eli Zaretskii <eliz@gnu.org>
1355
1356 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1357 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1358 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1359 (malloc, free, realloc, calloc): Redirect to e_* only when
1360 compiling Emacs.
1361
1362 * lisp.h (GCTYPEBITS): Move before first use.
1363 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1364 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1365 this macro definition.
1366
1367 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1368 _MSC_VER.
1369
54e9e3bf
JD
13702011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1371
6d5eb5b0
SM
1372 * gtkutil.c (xg_create_frame_widgets):
1373 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1374 present with Gtk+ 2.0.
1375
83aca1cb
PE
13762011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1377
1378 * fileio.c (Finsert_file_contents): Undo previous change; see
1379 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1380
5b76caa4
PE
13812011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1382
1383 Rename locals to avoid shadowing.
1384 * fileio.c (Finsert_file_contents):
1385 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1386 * process.c (wait_reading_process_output):
1387 Rename inner 'proc' to 'p' to avoid shadowing.
1388 Indent for consistency with usual Emacs style.
1389
8c535114
EZ
13902011-11-25 Eli Zaretskii <eliz@gnu.org>
1391
1392 * xdisp.c (redisplay_window): If cursor row is not fully visible
1393 after recentering, and scroll-conservatively is set to a large
1394 number, scroll window by a few more lines to make the cursor fully
1395 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1396 (start_display): Don't move to the next line if the display should
1397 start at a newline that is part of a display vector or an overlay
1398 string. (Bug#10119)
8c535114 1399
fa4fdb5c
JL
14002011-11-24 Juri Linkov <juri@jurta.org>
1401
1402 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1403 after the `MagickPingImage' call. (Bug#10112)
1404
90ec88df
CY
14052011-11-23 Chong Yidong <cyd@gnu.org>
1406
1407 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1408
56e2e794
MR
14092011-11-23 Martin Rudalics <rudalics@gmx.at>
1410
1411 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1412 making another buffer current. (Bug#10114)
1413
b6e64c41
GM
14142011-11-23 Glenn Morris <rgm@gnu.org>
1415
1416 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1417
6b21de18
CY
14182011-11-23 Chong Yidong <cyd@gnu.org>
1419
1420 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1421 using it (Bug#5984).
1422
b12cd789
EZ
14232011-11-22 Eli Zaretskii <eliz@gnu.org>
1424
1425 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1426 and header-lines, as they don't have one computed for them.
1427 (Bug#10098)
1428
1429 * .gdbinit (prow): Make displayed values more self-explaining.
1430 Add row's hash code.
1431
261b6fd4
LMI
14322011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1433
1434 * process.c (wait_reading_process_output): Fix asynchrounous
1435 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1436 (wait_reading_process_output): Add comment and URL.
261b6fd4 1437
e7cfd277
JD
14382011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1439
1440 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1441
a9b9b7f5
CY
14422011-11-21 Chong Yidong <cyd@gnu.org>
1443
1444 * window.c (Fnext_window, Fprevious_window): Doc fix.
1445
b0d15b4f
SM
14462011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1447
1448 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1449
fe7a3057
JB
14502011-11-20 Juanma Barranquero <lekktu@gmail.com>
1451
1452 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1453
d2999b1a
MR
14542011-11-20 Martin Rudalics <rudalics@gmx.at>
1455
1456 * window.c (Fset_window_combination_limit): Rename argument
1457 STATUS to LIMIT.
1458 (Vwindow_combination_limit): Remove "status" from doc-string.
1459
d5ff9cd0
AS
14602011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1461
1462 * m/ibms390.h: Remove.
1463 * m/ibms390x.h: Don't include "ibms390.h".
1464
a5bb9bd3
SM
14652011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1466
1467 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1468 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1469
cd1181db
JB
14702011-11-20 Juanma Barranquero <lekktu@gmail.com>
1471
1472 * casetab.c (Fset_case_table):
1473 * charset.c (Fcharset_after): Fix typos.
1474
615a3b8d 14752011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1476
17e845af
PE
1477 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1478 Otherwise, valgrind does not work on some platforms.
1479 Problem reported by Andreas Schwab in
6a0bf43d
PE
1480 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1481 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1482 is set, removing the need for VIRT_ADDRESS_VARIES.
1483 (PURE_P): Use a more-efficient implementation that needs just one
1484 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1485 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1486 to 4 (xorl, subq, cmpq, setbe).
1487 * alloc.c (pure): Always extern now, since that's the
1488 VIRT_ADDR_VARIES behavior.
1489 (PURE_POINTER_P): Use a single comparison, not two, for
1490 consistency with the new puresize.h.
1491 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1492 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1493 Remove VIRT_ADDR_VARIES no longer needed.
1494
f8fe6f96
EZ
14952011-11-19 Eli Zaretskii <eliz@gnu.org>
1496
1497 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1498 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1499 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1500 behave as if the cursor position were at the window margin.
1501
1502 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1503 and the cursor position is out of bounds, behave as if the cursor
1504 position were at the window margin. (Bug#10075)
1505
df05a53c
CY
15062011-11-18 Chong Yidong <cyd@gnu.org>
1507
1508 * window.c (Fwindow_combination_limit): Make first argument
1509 non-optional, since it is meaningless for live windows like the
1510 selected window.
1511
2071918e
DA
15122011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1513
1514 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1515
b50a28de
SM
15162011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1517
1518 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1519 (graft_intervals_into_buffer): Simplify.
1520
015137db
EZ
15212011-11-18 Eli Zaretskii <eliz@gnu.org>
1522
1523 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1524 hash values of the two rows.
1525 (copy_row_except_pointers): Preserve the used[] arrays and the
1526 hash values of the two rows. (Bug#10035)
68c95424 1527 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1528
1529 * xdisp.c (row_hash): New function, body extracted from
1530 compute_line_metrics.
1531 (compute_line_metrics): Call row_hash, instead of computing the
1532 hash code inline.
1533
1534 * dispnew.c (verify_row_hash): Call row_hash for computing the
1535 hash code of a row, instead of duplicating code from xdisp.c.
1536
1537 * dispextern.h (row_hash): Add prototype.
1538
a2addb04
TH
15392011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1540
1541 * frame.c (delete_frame): Don't delete the terminal when the last
1542 X frame is closed if emacs is built with GTK toolkit.
1543
df85d315
JB
15442011-11-17 Juanma Barranquero <lekktu@gmail.com>
1545
1546 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1547
a0c2d0ae
MR
15482011-11-17 Martin Rudalics <rudalics@gmx.at>
1549
1550 * window.c (Vwindow_splits): Rename to
1551 Vwindow_combination_resize. Suggested by Juri Linkov.
1552 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1553 of Vwindow_splits.
1554
58179cce
JB
15552011-11-16 Juanma Barranquero <lekktu@gmail.com>
1556
7877f373
JB
1557 * nsfns.m (Fns_font_name):
1558 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1559
b6f67890
MR
15602011-11-16 Martin Rudalics <rudalics@gmx.at>
1561
1562 * window.h (window): Rename slot "nest" to "combination_limit".
1563 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1564 (Fset_window_nest): Rename to Fset_window_combination_limit.
1565 (Vwindow_nest): Rename to Vwindow_combination_limit.
1566 (recombine_windows, make_parent_window, make_window)
1567 (Fsplit_window_internal, saved_window)
1568 (Fset_window_configuration, save_window_save): Rename all
1569 occurrences of window_nest to window_combination_limit.
1570
c7015153
JB
15712011-11-15 Juanma Barranquero <lekktu@gmail.com>
1572
1573 * image.c (imagemagick_load_image): Fix typo.
1574
322ad6ec
EZ
15752011-11-14 Eli Zaretskii <eliz@gnu.org>
1576
1577 * xdisp.c (display_line): Move the call to
1578 highlight_trailing_whitespace before the call to
1579 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1580 faces of all the glyphs to compute ROW's hash value.
1581 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1582
f067b8ec
JB
15832011-11-14 Juanma Barranquero <lekktu@gmail.com>
1584
1585 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1586 just return (bug#10044).
1587
1e5b2111
EZ
15882011-11-12 Eli Zaretskii <eliz@gnu.org>
1589
7ef3cbd5
EZ
1590 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1591 with user-defined heap size. Bump the default size of the temacs
1592 heap to 27MB, to avoid memory warning when running temacs.
1593 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1594
1e5b2111
EZ
1595 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1596 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1597 (verify_row_hash) [XASSERTS]: New function.
1598 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1599 that the hash value of glyph rows is correct.
1e5b2111 1600
89d61221
MR
16012011-11-12 Martin Rudalics <rudalics@gmx.at>
1602
1603 * window.h (window): Remove splits slot.
1604 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1605 (Fdelete_other_windows_internal, make_parent_window)
1606 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1607 (Fset_window_configuration, save_window_save): Don't deal with
1608 split status of windows.
1609 (saved_window): Remove splits slot.
1610 (Vwindow_splits): Rewrite doc-string.
1611
97f18cc8
JD
16122011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1613
1614 * xfns.c (unwind_create_frame):
1615 * nsfns.m (unwind_create_frame):
1616 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1617 Vframe_list (Bug#9999).
1618
22a648b4
DA
16192011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1620
0b381c7e 1621 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1622
659afede
KH
16232011-11-11 Kenichi Handa <handa@m17n.org>
1624
1625 * callproc.c (Fcall_process): Set the member dst_multibyte of
1626 process_coding.
1627
9ac0394b
KH
16282011-11-11 Johan Bockgård <bojohan@gnu.org>
1629
1630 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1631 avoid a crash (bug#9496).
1632
2fbdc249
CY
16332011-11-09 Chong Yidong <cyd@gnu.org>
1634
1635 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1636 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1637
ac6b1f81
PE
16382011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1639
1640 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1641
09db192c
PE
16422011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1643
1644 Avoid some portability problems by eschewing 'extern inline' functions.
1645 The trivial performance wins aren't worth the portability hassles; see
1646 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1647 et seq.
1648 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1649 (window_box_width, window_box_left, window_box_left_offset)
1650 (window_box_right, window_box_right_offset): Undo previous change,
1651 by removing the "extern"s.
1652 * intervals.c (adjust_intervals_for_insertion)
1653 (adjust_intervals_for_deletion): Undo previous change,
1654 making these static again.
1655 (offset_intervals, temp_set_point_both, temp_set_point)
1656 (copy_intervals_to_string): No longer inline.
1657 * xdisp.c (window_text_bottom_y, window_box_width)
1658 (window_box_height, window_box_left_offset)
1659 (window_box_right_offset, window_box_left, window_box_right)
1660 (window_box): No longer inline.
1661
105216ed
CY
16622011-11-08 Chong Yidong <cyd@gnu.org>
1663
1664 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1665 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1666 Signal an error if not a live window.
105216ed
CY
1667 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1668 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1669
ae9e237f
JB
16702011-11-07 Juanma Barranquero <lekktu@gmail.com>
1671
1672 * lisp.h (syms_of_abbrev): Remove declaration.
1673 Reported by CHENG Gao <chenggao@royau.me>.
1674
c7aa8333
EZ
16752011-11-07 Eli Zaretskii <eliz@gnu.org>
1676
1677 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1678 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1679 of temacs in GUI mode.
1680
be7f5545
MR
16812011-11-07 Martin Rudalics <rudalics@gmx.at>
1682
1683 * window.h: Declare delete_all_child_windows instead of
1684 delete_all_subwindows.
1685 * window.c (Fwindow_nest, Fset_window_nest)
1686 (Fset_window_new_total, Fset_window_new_normal)
1687 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1688 (delete_all_subwindows): Rename to delete_all_child_windows.
1689 (Fdelete_other_windows_internal, Fset_window_configuration):
1690 Call delete_all_child_windows instead of delete_all_subwindows.
1691 * frame.c (delete_frame): Call delete_all_child_windows instead
1692 of delete_all_subwindows.
1693
ca78dc43
PE
16942011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1695
1696 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1697 This is also needed for porting to any host where GC_MARK_STACK is
1698 not GC_MAKE_GCPROS_NOOPS.
1699 (which_symbols): Use it.
1700
a0241d01
KH
17012011-11-07 Kenichi Handa <handa@m17n.org>
1702
1703 * coding.c (coding_set_destination): Check coding->src_pos only
1704 when coding->src_object is a buffer (bug#9910).
1705
1706 * process.c (send_process): Set the member src_multibyte of coding
1707 to 0 (bug#9911) when sending a unibyte text.
1708
1709 * callproc.c (Fcall_process): Set the member src_multibyte of
1710 process_coding to 0 (bug#9912).
1711
a64bfdfa 17122011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1713
1714 * xmenu.c (cleanup_widget_value_tree): New function.
1715 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1716 calling free_menubar_widget_value_tree directly (Bug#9830).
1717
cb41b32a
PE
17182011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1719
1720 Fix some portability problems with 'inline'.
1721 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1722 (window_box_width, window_box_left, window_box_left_offset)
1723 (window_box_right, window_box_right_offset): Declare extern.
1724 Otherwise, these inline functions do not conform to C99 and
1725 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1726 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1727 * intervals.c (adjust_intervals_for_insertion)
1728 (adjust_intervals_for_deletion): Now extern, because otherwise the
1729 extern inline functions 'offset_intervals' couldn't refer to it.
1730 (static_offset_intervals): Remove.
1731 (offset_intervals): Rewrite using the old contents of
1732 static_offset_intervals. The old version didn't conform to C99
1733 because an extern inline function contained a reference to an
1734 identifier with static linkage.
1735
b7041366
AS
17362011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1737
1738 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1739 GC.
1740
88a37c4d
EZ
17412011-11-06 Eli Zaretskii <eliz@gnu.org>
1742
1743 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1744 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1745 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1746 return Qleft_to_right.
1747
49745b39
CY
17482011-11-06 Chong Yidong <cyd@gnu.org>
1749
1750 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1751 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1752 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1753 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1754 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1755 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1756 (Fwindow_vscroll): Doc fix.
1757 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1758 argument, since it makes no sense to pass a live window and for
1759 consistency with window-child.
1760
1f05cd82
CS
17612011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1762
1763 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1764 support MSVC.
1765
22610910
JR
17662011-11-05 Jason Rumney <jasonr@gnu.org>
1767
1768 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1769 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1770 fonts (Bug#6029).
1771 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1772 bitwise arithmetic preventing use of unicode-sip and non-truetype
1773 opentype fonts.
1774
a06776b2
EZ
17752011-11-05 Eli Zaretskii <eliz@gnu.org>
1776
3ad924ba
EZ
1777 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1778 "emacs"-only part.
1779
a06776b2
EZ
1780 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1781 initialization code to keep similarity to xfns.c after changes
1782 from 2011-11-05.
1783
c9e7db78
JD
17842011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1785
a97f8f3f
JD
1786 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1787 (unwind_create_frame): New function (Bug#9943).
1788 (Fx_create_frame): Restructure code to be more similar to the one in
1789 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1790 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1791 Move terminal->reference_count++ just before making the frame official
1792 (Bug#9943).
1793
1794 * nsterm.m (x_free_frame_resources): New function.
1795 (x_destroy_window): Move code to x_free_frame_resources.
1796
c9e7db78 1797 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1798 (Fx_create_frame, x_create_tip_frame):
1799 Move terminal->reference_count++ just before making the frame
75f1671a 1800 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1801 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1802
a6fc3b5c
EZ
18032011-11-05 Eli Zaretskii <eliz@gnu.org>
1804
1805 Support MSVC build with newer versions of Visual Studio.
1806 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1807 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1808 nt/gmake.defs.
1809
1810 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1811 which are not supported by MSVC.
1812 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1813 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1814 bitfields.
1815 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1816 types in bitfields.
1817 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1818
1819 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1820
58179cce 18212011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1822
1823 Support MSVC build with newer versions of Visual Studio.
1824 * w32.c: Don't include w32api.h for MSVC.
1825 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1826
1827 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1828 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1829 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1830 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1831 e_* cousins.
1832 (alloca) [_MSC_VER]: Define to _alloca.
1833
1834 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1835
1836 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1837
a58c13ed
EZ
18382011-11-04 Eli Zaretskii <eliz@gnu.org>
1839
1840 * xdisp.c (note_mouse_highlight): If either of
1841 previous/next-single-property-change returns nil, treat that as
1842 the beginning or the end of the buffer. (Bug#9955)
1843
fe0b6370
JD
18442011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1845
a58c13ed 1846 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1847 label is not null (Bug#9951).
1848 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1849 may be NULL.
1850
89bd5ee1
EZ
18512011-11-04 Eli Zaretskii <eliz@gnu.org>
1852
1853 * window.c (Fwindow_body_size): Mention in the doc string that the
1854 return value is in frame's canonical units. (Bug#9949)
1855
84c3edb9
EZ
18562011-11-03 Eli Zaretskii <eliz@gnu.org>
1857
4e2fb5c7
EZ
1858 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1859
84c3edb9 1860 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1861 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1862 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1863
bc17a887
EZ
18642011-11-01 Eli Zaretskii <eliz@gnu.org>
1865
1866 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1867 Don't stop backward scan on the continuation glyph, even though
1868 its CHARPOS is positive.
6d5eb5b0
SM
1869 (mouse_face_from_buffer_pos, note_mouse_highlight):
1870 Rename cover_string to disp_string.
bc17a887 1871
4ee88440
MR
18722011-11-01 Martin Rudalics <rudalics@gmx.at>
1873
1874 * window.c (temp_output_buffer_show): Don't use
1875 Vtemp_buffer_show_specifiers.
1876 (Vtemp_buffer_show_specifiers): Remove unused variable.
1877
c2ff3c02
EZ
18782011-10-30 Eli Zaretskii <eliz@gnu.org>
1879
1880 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1881 past the beginning of the current glyph matrix.
1882
58179cce 18832011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1884
1885 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1886 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1887 HAVE_GTK3 (Bug#9869).
b77a6a7f 1888
3b574623
JD
1889 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1890 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1891
b77a6a7f
JD
1892 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1893
1894 * xterm.c: Declare x_handle_net_wm_state to return int.
1895 (handle_one_xevent): Check if we are iconified but don't have
1896 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1897 (get_current_wm_state): Return non-zero if not hidden,
1898 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1899 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1900 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1901 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1902
196e41e4
PE
19032011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1904
1905 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1906 so that this new function doesn't get optimized away by a
1907 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1908
021f2e1a
AS
19092011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1910
1911 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1912
8b058d44
EZ
19132011-10-29 Eli Zaretskii <eliz@gnu.org>
1914
1915 Fix the `xbytecode' command.
1916 * .gdbinit (xprintbytestr): New command.
b50a28de 1917 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1918 (xbytecode): Print the byte-code string as well.
1919
4452fb80
EZ
19202011-10-29 Kim Storm <storm@cua.dk>
1921
8b058d44
EZ
1922 * alloc.c (which_symbols): New function.
1923
21b72067
AS
19242011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1925
1926 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1927 line. (Bug#9903)
1928
83ed7b5c
GM
19292011-10-29 Glenn Morris <rgm@gnu.org>
1930
1931 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1932 Not clear what it was for, and it causes various bugs. (Bug#9839)
1933
5a7a728b
EZ
19342011-10-28 Eli Zaretskii <eliz@gnu.org>
1935
1936 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1937 possible random value that matches one of those tested as
1938 condition to clear the mouse face.
1939
d3d0842f
CY
19402011-10-28 Chong Yidong <cyd@gnu.org>
1941
1942 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1943
31b39d13
DN
19442011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1945
1946 * window.c (make_window): Initialize phys_cursor_on_p.
1947
9aba6043
SM
19482011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1949
1950 * lisp.h (struct Lisp_Symbol): Update comments.
1951
c20992f4
JB
19522011-10-28 Juanma Barranquero <lekktu@gmail.com>
1953
1954 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1955
db4f02f2
EZ
19562011-10-28 Eli Zaretskii <eliz@gnu.org>
1957
1958 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1959 <oslsachem@gmail.com> for helping to debug this.
1960
1961 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1962 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1963 (g_b_init_get_glyph_outline_w): New static variables.
1964 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1965 (GetGlyphOutlineW_Proc): New typedefs.
1966 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1967 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1968 New functions.
1969 (w32font_open_internal, compute_metrics):
1970 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1971 instead of calling the "wide" APIs directly.
1972
1973 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1974
1975 * w32.h (syms_of_w32font): Add prototype.
1976
87e68db4
JB
19772011-10-27 Juanma Barranquero <lekktu@gmail.com>
1978
1979 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1980 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1981 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1982 (Fmove_to_window_line): Doc fix.
1983
435c1d67
CY
19842011-10-27 Chong Yidong <cyd@gnu.org>
1985
1986 * process.c (make_process): Set gnutls_state to NULL.
1987
1988 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1989 non-NULL, regardless of GNUTLS_INITSTAGE.
1990 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1991 an error. Set process slots as soon as we allocate them.
1992
1993 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1994
9c6c6f49
CY
19952011-10-27 Chong Yidong <cyd@gnu.org>
1996
9aba6043
SM
1997 * gnutls.c (emacs_gnutls_deinit): New function.
1998 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1999 (Fgnutls_deinit, Fgnutls_boot): Use it.
2000
2001 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2002 (deactivate_process): Call emacs_gnutls_deinit.
2003
657d08d3
JB
20042011-10-27 Juanma Barranquero <lekktu@gmail.com>
2005
2006 * image.c (x_create_x_image_and_pixmap):
2007 * w32.c (sys_rename, w32_delayed_load):
2008 * w32font.c (fill_in_logfont):
2009 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2010
5430d399
JB
20112011-10-26 Juanma Barranquero <lekktu@gmail.com>
2012
2013 * w32fns.c (w32_default_color_map): New function,
2014 extracted from Fw32_default_color_map.
a7ef684b 2015 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2016
fe0055fa
PE
20172011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2018
2019 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2020
e6346438
SM
20212011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2022
2023 * keyboard.c (test_undefined): New function (bug#9751).
2024 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2025
e112cc37
ET
20262011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2027
2028 * sysdep.c (init_sys_modes): Fix the check for the controlling
2029 terminal (Bug#6649).
2030
7b5d6677
EZ
20312011-10-20 Eli Zaretskii <eliz@gnu.org>
2032
2033 * dispextern.h (struct bidi_it): New member next_en_type.
2034
2035 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2036 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2037 current character, check also for next_en_type being WEAK_EN.
2038 (bidi_resolve_weak): Don't enter the expensive loop if the current
2039 position is before next_en_pos. Record the bidi type of the first
2040 non-ET, non-BN character we find, in addition to its position.
2041 (bidi_level_of_next_char): Invalidate next_en_type when
2042 next_en_pos is over-stepped.
2043
7da0b018
PE
20442011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2045
2046 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2047 * editfns.c: Rewrite current-time-zone so that it invokes
2048 the equivalent of (format-time-string "%Z") to get the time zone name.
2049 This fixes a bug when the time zone name contains characters that
2050 need converting from the system time locale to Emacs internal format.
2051 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2052 that patch fixed format-time-string to do the conversion, but
2053 I forgot to fix current-time-zone.
2054 (format_time_string): New function, containing most of
2055 what Fformat_time_string used to contain.
2056 (Fformat_time_string): Rewrite in terms of format_time_string.
2057 This doesn't change this function's behavior.
2058 (current-time-zone): Rewrite to use format_time_string.
2059 This fixes the bug reported by Michael Schierl in
2060 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2061 Jason Rumney's 2007-06-07 change worked around this bug, but
2062 didn't fix it.
2063 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2064
8547b010
EZ
20652011-10-19 Eli Zaretskii <eliz@gnu.org>
2066
2067 * xdisp.c (start_display): If the character at POS is displayed
2068 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2069 (try_window_reusing_current_matrix): If a line ends in a display
2070 vector or the next line starts in a display vector, continue
2071 redrawing the window even though the character position of
2072 start_row was reached.
8547b010
EZ
2073 (Bug#9771, part 2)
2074
4e948d15
CY
20752011-10-18 Chong Yidong <cyd@gnu.org>
2076
2077 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2078 with nobreak-char-display too.
2079
4787455f
EZ
20802011-10-18 Eli Zaretskii <eliz@gnu.org>
2081
2082 Fix part 3 of bug#9771.
2083 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2084 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2085 non-neutral characters if the current character is a paragraph
2086 separator (a.k.a. Newline). This avoids running the same
2087 expensive loop twice, once when we consume the preceding newline
2088 and the other time when the line actually needs to be displayed.
2089 Avoid the loop when we see neutrals on the base embedding level
2090 following a character whose directionality is the same as the
2091 paragraph's. This avoids running the expensive loop when a line
2092 ends in a long sequence of neutrals, like control characters.
2093 Add assertion against STRONG_AL type. Slightly rearrange code
2094 that determines the type of a neutral given the first non-neutral
2095 that follows it.
2096 (bidi_level_of_next_char): Set next_en_pos to zero when
2097 invalidating its info.
2098
2c91f553
EZ
20992011-10-17 Eli Zaretskii <eliz@gnu.org>
2100
2101 * xdisp.c (push_display_prop): Determine whether to record string
2102 or buffer position by IT->string, not by IT->method. Allow
2103 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2104 (move_it_vertically_backward): Don't look for character position
2105 immediately after the newline when in a continuation line.
2106 (Bug#9771, part 1)
2c91f553 2107
c7b08b0d
MR
21082011-10-15 Martin Rudalics <rudalics@gmx.at>
2109
2110 * window.c (coordinates_in_window): Rewrite and delabelize
2111 vertical border check. (Bug#5357) (Bug#9618)
2112
6b02f655
SM
21132011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2114
2115 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2116 errors in XSetWindowBorder (bug#9310).
2117
81d40c92
DA
21182011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2119
2120 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2121 avoid crash when xmalloc overrun checking is enabled.
2122
d4172c3b
EZ
21232011-10-13 Eli Zaretskii <eliz@gnu.org>
2124
2125 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2126 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2127 cursor motion with <left> and <right> arrow keys.
2128
2129 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2130 some callers set that themselves.
2131
b00eea75
EZ
21322011-10-12 Eli Zaretskii <eliz@gnu.org>
2133
2134 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2135 display string and the previous row comes from the same string and
2136 is empty. (Bug#9739) (Bug#9738)
2137
8fe012c4
SM
21382011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2139
2140 * doc.c (get_doc_string): Encode file name (bug#9735).
2141
0074aef2
EZ
21422011-10-12 Eli Zaretskii <eliz@gnu.org>
2143
79beb178
EZ
2144 * bidi.c (bidi_level_of_next_char):
2145 * xdisp.c (get_visually_first_element): Remove old incorrect
2146 comments regarding the Unicode Line Separator character.
2147
0074aef2
EZ
2148 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2149
6e4b3fbe
DA
21502011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2151
2152 * alloc.c (Fgc_status): Do not access beyond zombies array
2153 boundary if nzombies > MAX_ZOMBIES.
2154 * alloc.c (dump_zombies): Add missing format specifier.
2155
0324f3af
PE
21562011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2157
b5525cac
PE
2158 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2159 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2160
0324f3af
PE
2161 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2162 Some packages use them to denote characters with modifiers.
2163
e9b5f888
AS
21642011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2165
2166 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2167 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2168 matching a pp-number. Rename parameter var to var1.
2169
127827c0
SM
21702011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2171
2172 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2173
c8fd3bd0
GM
21742011-10-08 Glenn Morris <rgm@gnu.org>
2175
2176 * callint.c (Fcall_interactively): Give a more explicit error for the
2177 'c' case with a non-character input. (Bug#8479)
2178
352ec8ff
EZ
21792011-10-08 Eli Zaretskii <eliz@gnu.org>
2180
03669ccb
EZ
2181 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2182 lines.
7061c986
EZ
2183 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2184 lines that are hscrolled on the left.
03669ccb 2185
352ec8ff
EZ
2186 * dispnew.c (buffer_posn_from_coords): Account for a possible
2187 presence of header-line. (Bug#4426)
2188
a66cfb1c
SM
21892011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2190
6b02f655
SM
2191 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2192 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2193
7c5ee88e
PE
21942011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2195
2196 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2197 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2198 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2199 this makes Emacs dump core during garbage collection on rare
2200 occasions. sizeof is obviously inferior to offsetof here, so
2201 stick with offsetof.
2202 (GC_POINTER_ALIGNMENT): New macro.
2203 (mark_memory): Omit 3rd (offset) arg; caller changed.
2204 Don't assume EMACS_INT alignment is the same as pointer alignment.
2205
df1bbe5b
SM
22062011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2207
2208 * keyboard.c (read_key_sequence_remapped): New var.
2209 (read_key_sequence): Compute remapping in the right buffer.
2210 (command_loop_1): Use read_key_sequence's remapping directly.
2211
51553db6
SM
22122011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2213
32c1fffd
SM
2214 * dired.c (file_name_completion): Don't expand file name.
2215 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2216 before checking file name handler.
2217
51553db6
SM
2218 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2219 they've been requested explicitly (bug#9591).
2220
b6bd1599 22212011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2222
2223 * keymap.c (Fsingle_key_description): Use make_specified_string
2224 instead of build_string to build string from push_key_description.
2225 (Bug#5193)
2226
f701dc2a
PE
22272011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2228
4222c55d
PE
2229 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2230 This fixes a Y2038 bug on 64-bit hosts.
2231 * buffer.c (reset_buffer):
2232 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2233 (Fclear_buffer_auto_save_failure):
2234 Use 0, not -1, to represent an unset failure time, since time_t
2235 might not be signed.
2236
f701dc2a
PE
2237 Remove dependency on glibc malloc internals.
2238 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2239 Move back here from lisp.h, but with their new implementations.
2240 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2241 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2242 * charset.c (charset_table_init): New static var.
2243 (syms_of_charset): Use it instead of xmalloc. This removes a
2244 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2245 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2246 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2247 Move back to alloc.c.
2248 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2249 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2250
9ceebf39
JD
22512011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2252
2253 * nsterm.m (windowDidResize): Call x_set_window_size only when
2254 ns_in_resize is true. Otherwise set pixelwidth/height and
2255 call change_frame_size (Bug#9628).
2256
cb993c58
PE
22572011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2258
3930c88b
PE
2259 Port --enable-checking=all to Fedora 14 x86-64.
2260 * charset.c (syms_of_charset): Also account for glibc malloc's
2261 internal overhead when calculating the initial malloc maximum.
2262
cb993c58
PE
2263 Port --enable-checking=all to Fedora 14 x86.
2264 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2265 Move to lisp.h.
2266 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2267 (overrun_check_realloc, overrun_check_free):
2268 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2269 That way, xmalloc returns a properly-aligned pointer even if
2270 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2271 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2272 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2273 into account when calculating the initial malloc maximum.
2274 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2275 Move here from alloc.c, so that charset.c can use it too.
2276 Properly align; the old code wasn't right for common 32-bit hosts
2277 when configured with --enable-checking=all.
2278 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2279 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2280
31bed486
EZ
22812011-09-29 Eli Zaretskii <eliz@gnu.org>
2282
04c70788 2283 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2284 use EDOM.
2285
fbcaa2f3
EZ
22862011-09-28 Eli Zaretskii <eliz@gnu.org>
2287
2288 * xdisp.c (compute_display_string_end): If there's no display
2289 string at CHARPOS, return -1.
2290
2291 * bidi.c (bidi_fetch_char): When compute_display_string_end
2292 returns a negative value, treat the character as a normal
2293 character not covered by a display string. (Bug#9624)
2294
a239d4e9
JB
22952011-09-28 Juanma Barranquero <lekktu@gmail.com>
2296
2297 * lread.c (Fread_from_string): Fix typo in docstring.
2298
88652fd5
EZ
22992011-09-27 Eli Zaretskii <eliz@gnu.org>
2300
2301 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2302 newline, reseat the iterator instead of bidi-iterating there one
2303 character at a time. (Bug#9610)
32c1fffd
SM
2304 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2305 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2306
ed497dd4
AS
23072011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2308
2309 * lread.c (readevalloop): Use correct code for NBSP.
2310 (read1): Likewise. (Bug#9608)
2311
b2bf61aa
MA
23122011-09-25 Michael Albinus <michael.albinus@gmx.de>
2313
2314 * dbusbind.c (Fdbus_register_signal): When service is not
2315 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2316
32bbb17c
GM
23172011-09-25 Glenn Morris <rgm@gnu.org>
2318
2319 * buffer.c (truncate-lines): Doc fix.
2320
94e0933e
CY
23212011-09-24 Chong Yidong <cyd@stupidchicken.com>
2322
2323 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2324 (Fset_window_next_buffers): Doc fix.
2325
cddde921
GM
23262011-09-24 Glenn Morris <rgm@gnu.org>
2327
2328 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2329
1260aef1
PE
23302011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2331
25b4bfa0
PE
2332 Fix minor problems found by static checking.
2333 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2334 * indent.c (Fvertical_motion): Fix == vs = typo.
2335
e3cbd34b
EZ
23362011-09-24 Eli Zaretskii <eliz@gnu.org>
2337
a66cfb1c
SM
2338 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2339 Default value is now t. Doc fix.
6bf7006f 2340
e3cbd34b 2341 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2342 logic when moving up, not only when moving down. Fix the
e3cbd34b 2343 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2344 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2345
2346 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2347 CHARPOS is covered by a display string which includes newlines.
2348 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2349 is covered by a display string with embedded newlines.
2350
a3de0cbd
MA
23512011-09-24 Michael Albinus <michael.albinus@gmx.de>
2352
2353 * dbusbind.c (Fdbus_register_signal): Add match rule to
2354 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2355 (Fdbus_register_method, Vdbus_registered_objects_table):
2356 Fix docstring.
a3de0cbd 2357
b260039d
JM
23582011-09-24 Jim Meyering <meyering@redhat.com>
2359
32c1fffd 2360 do not ignore write error for any output size
b260039d
JM
2361 The previous change was incomplete.
2362 While it makes emacs --batch detect the vast majority of stdout
2363 write failures, errors were still ignored whenever the output size is
2364 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2365 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2366 && echo FAIL: ignored write error
2367 FAIL: ignored write error
2368 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2369 && echo FAIL: ignored write error
2370 FAIL: ignored write error
2371 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2372
8eca8a7c
AS
23732011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2374
2375 * emacs.c (Fkill_emacs): In noninteractive mode exit
2376 non-successfully if a write error occurred on stdout. (Bug#9574)
2377
3341db62
EZ
23782011-09-21 Eli Zaretskii <eliz@gnu.org>
2379
2380 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2381 the xassert test.
2382
2383 * dispextern.h (struct it): Update the comment documenting what
2384 can it->OBJECT be.
2385
8c203dbf
EZ
23862011-09-20 Eli Zaretskii <eliz@gnu.org>
2387
2388 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2389 a display string, extend search for cursor position to end of row.
2390 (find_row_edges): If the row ends in a newline from a display
2391 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2392 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2393 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2394 non-empty line. Fixes confusing cursor motion with arrow keys at
2395 the beginning of a line that starts with whitespace.
8c203dbf 2396
a4824228
LMI
23972011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2398
2399 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2400 (bug#9493).
2401
33ed493b
CY
24022011-09-18 Chong Yidong <cyd@stupidchicken.com>
2403
2404 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2405 boolean (Bug#9154).
2406
56cd55c8
EZ
24072011-09-18 Eli Zaretskii <eliz@gnu.org>
2408
2409 * xdisp.c (display_line): Record maximum and minimum buffer
2410 positions even if no glyphs were produced (e.g., by a zero-width
2411 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2412 buffer positions that will be removed from the glyph row because
2413 they don't fit.
c02dcedf
EZ
2414 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2415 column is beyond frame width: don't subtract 1 "pixel" when
2416 computing width of the stretch.
3e62b7e0
EZ
2417 (reseat_at_next_visible_line_start): Undo the change made on
2418 2011-09-17 that saved paragraph information and restored it after
2419 the call to `reseat'. (Bug#9545)
56cd55c8 2420
5ed99d36 24212011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2422
2423 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2424 and turn window cursor on if cleared (Bug#9415).
2425
5ed99d36 24262011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2427
2428 * search.c (boyer_moore): Take unibyte characters from pattern
2429 literally. (Bug#9458)
2430
9bade7b2
EZ
24312011-09-18 Eli Zaretskii <eliz@gnu.org>
2432
2433 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2434
e5e9d610
PE
24352011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2436
87e4427a
PE
2437 Fix minor problem found by static checking.
2438 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2439 initialized, to pacify gcc -Wuninitialized.
2440
e5e9d610
PE
2441 * fileio.c: Report proper errno when syscall falls.
2442 (Finsert_file_contents): Save and restore errno,
2443 so that report_file_error outputs the correct diagnostic.
2444 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2445
a1674f0b
EZ
24462011-09-18 Eli Zaretskii <eliz@gnu.org>
2447
2448 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2449
fbfb6dd4
EZ
24502011-09-17 Eli Zaretskii <eliz@gnu.org>
2451
2452 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2453 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2454
bb187662
EZ
24552011-09-17 Eli Zaretskii <eliz@gnu.org>
2456
1137e8b8 2457 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2458 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2459
2460 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2461 (bidi_find_paragraph_start): Search back for paragraph beginning
2462 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2463 (bidi_move_to_visually_next): Only trigger paragraph-related
2464 computations when the last character is a newline or at EOB, not
2465 just any NEUTRAL_B. (Bug#9470)
2466
bb187662
EZ
2467 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2468 truncated lines if point is covered by a display string. (Bug#9524)
2469
2e621251
PE
24702011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2471
2472 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2473 (cons_to_x_long): New function.
2474 (lisp_data_to_selection_data): Use it. Correct the test for
2475 short-versus-long data; it was negated. Break out of vector
2476 loop, for efficiency, when a long datum is discovered.
2477
91a15bc6
SM
24782011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2479
2480 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2481
b41c3a35
EZ
24822011-09-16 Eli Zaretskii <eliz@gnu.org>
2483
2484 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2485 GCC PR/17406) by declaring this function with external scope.
2486
7812ba2d
PE
24872011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2488
2489 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2490 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2491
cf7edc2a
AS
24922011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2493
2494 * editfns.c (Fformat): Correctly handle text properties on "%%".
2495
bd01620e
EZ
24962011-09-15 Eli Zaretskii <eliz@gnu.org>
2497
2498 * xterm.c (x_draw_composite_glyph_string_foreground):
2499 * w32term.c (x_draw_composite_glyph_string_foreground):
2500 * term.c (encode_terminal_code):
2501 * composite.c (composition_update_it, get_composition_id):
2502 * xdisp.c (get_next_display_element)
2503 (fill_composite_glyph_string): Add comments about special meaning
2504 of TAB characters in a composition.
2505
a02719a3
PE
25062011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2507
2508 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2509 This occurs when processing a multibyte format.
2510 Problem reported by Wolfgang Jenker.
a02719a3 2511
72589a3c
JB
25122011-09-15 Johan Bockgård <bojohan@gnu.org>
2513
2514 * xdisp.c (try_cursor_movement): Only check for exact match if
2515 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2516
1c14176c
PE
25172011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2518
2519 Remove unused external symbols.
2520 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2521 * xdisp.c (calc_pixel_width_or_height): Now static.
2522 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2523 * indent.c (check_display_width):
2524 * w32term.c: Fix comment to match code.
2525 * xterm.c, xterm.h (x_catching_errors): Remove.
2526
d2eea5b5
PE
25272011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2528
2529 * xselect.c: Use signed conversions more consistently (Bug#9498).
2530 (selection_data_to_lisp_data): Assume incoming selection data are
2531 signed integers, not unsigned. This is to be consistent with
2532 outgoing selection data, which was modified to use signed integers
2533 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2534 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2535 expects long, not unsigned long.
2536
46888499
EZ
25372011-09-14 Eli Zaretskii <eliz@gnu.org>
2538
2539 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2540 computation of loop end. Reported by Johan Bockgård
2541 <bojohan@gnu.org>.
2542
ef8ef9fb
CY
25432011-09-13 Chong Yidong <cyd@stupidchicken.com>
2544
2545 * frame.c (Fother_visible_frames_p): Function deleted.
2546
fa819fed
EZ
25472011-09-12 Eli Zaretskii <eliz@gnu.org>
2548
2549 * indent.c (compute_motion): Process display vector front to back
2550 rather than the other way around. (Bug#2496)
2551
2ba8e008
SM
25522011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2553
2554 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2555
20f53c69
CY
25562011-09-11 Chong Yidong <cyd@stupidchicken.com>
2557
2558 * minibuf.c (Fread_from_minibuffer): Doc fix.
2559
d562d7a4
EZ
25602011-09-11 Eli Zaretskii <eliz@gnu.org>
2561
2562 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2563 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2564
1c4d7f3d
LMI
25652011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2566
2567 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2568 value for non-existent files.
2569
b885bf36
EZ
25702011-09-11 Eli Zaretskii <eliz@gnu.org>
2571
2572 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2573 set its "size" to -1. This will set the modtime_size field of
2574 the corresponding buffer to -1, which is what
2575 verify-visited-file-modtime expects for files that do not exist.
2576 (Bug#9139)
2577
6612f0bf
PE
25782011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2579
2580 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2581 here ...
2582 * lisp.h: ... from here. push_key_description is no longer
2583 defined in keyboard.c, so its declaration should not be in
2584 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2585 logically belongs with push_key_description.
2586
dfb3f755
PE
25872011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2588
2589 * buffer.h: Include <sys/types.h> instead of <time.h>.
2590 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2591 Problem reported by Herbert J. Skuhra.
2592
3134906c
LMI
25932011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2594
2595 * xml.c (parse_region): Make the parsing work for
2596 non-comment-starting XML files again (bug#9144).
2597
8d903f4e
AS
25982011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2599
2600 * image.c (gif_load): Fix calculation of bottom and right corner.
2601 (Bug#9468)
2602
80ad64f4
EZ
26032011-09-10 Eli Zaretskii <eliz@gnu.org>
2604
2605 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2606 redisplay in small windows.
2607
208a048d
EZ
26082011-09-09 Eli Zaretskii <eliz@gnu.org>
2609
2610 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2611
9b1c252e
MR
26122011-09-08 Martin Rudalics <rudalics@gmx.at>
2613
2614 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2615 Operate on live windows only.
2616
2949f33b
JB
26172011-09-08 Juanma Barranquero <lekktu@gmail.com>
2618
2619 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2620
e08dcafd
EZ
26212011-09-07 Eli Zaretskii <eliz@gnu.org>
2622
2623 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2624 only under bidi iteration.
2625
115b96bd
JD
26262011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2627
2628 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2629
c8199d0f
PE
26302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2631
2632 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2633 Without this fix, the command to link temacs failed due to an
2634 undefined symbol __builtin_isnan. This is because
2635 /usr/include/iso/math_c99.h #defines isnan(x) to
2636 __builtin_isnan(x), but the bundled gcc, which identifies itself
2637 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2638 a __builtin_isnan.
2639 * floatfns.c (isnan): #undef, and then #define to a clone of
2640 what's in data.c.
2641 (Fisnan): Always define, since it's always available now.
2642 (syms_of_floatfns): Always define isnan at the Lisp level.
2643
e39b275c 26442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2645
2646 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2647
b2db44d9 26482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2649
f4af5137 2650 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2651 The previous code assumed that file offsets (off_t values) fit in
2652 EMACS_INT variables, which is not true on typical 32-bit hosts.
2653 The code messed up by falsely reporting buffer overflow in cases
2654 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2655 when "big" contains more than 2**29 bytes, even though this
2656 inserts just one byte and does not overflow the buffer.
2657 (Finsert_file_contents): Store file offsets as off_t
2658 values, not as EMACS_INT values. Check for overflow when
2659 converting between EMACS_INT and off_t. When checking for
2660 buffer overflow or for overlap, take the offsets into account.
2661 Don't use EMACS_INT for small values where int suffices.
2662 When checking for overlap, fix a typo: ZV was used where
2663 ZV_BYTE was intended.
2664 (Fwrite_region): Don't assume off_t fits into 'long'.
2665 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2666
ecfc0a49
MA
26672011-09-05 Michael Albinus <michael.albinus@gmx.de>
2668
2669 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2670
6511acf2 26712011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2672
0999621a 2673 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2674
2675 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2676 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2677 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2678 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2679 (modify_event_symbol): Do not assume that the length of
2680 name_alist_or_stem is safe to alloca and fits in int.
2681 (Fexecute_extended_command): Likewise for function name and binding.
2682 (Frecursion_depth): Wrap around reliably on integer overflow.
2683 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2684 since some callers pass EMACS_INT values.
2685 (Fsingle_key_description): Don't crash if symbol name contains more
2686 than MAX_ALLOCA bytes.
2687 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2688 (get_minibuffer): Arg is now EMACS_INT, not int.
2689 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2690 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2691 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2692
2be7d702
PE
2693 * dbusbind.c (signature_cat): New function.
2694 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2695 Do not overrun buffer; instead, report string overflow.
2696
9d1df220
PE
2697 * dispnew.c (add_window_display_history): Don't overrun buffer.
2698 Truncate instead; this is OK since it's just a log.
2699
33ef5c64
PE
2700 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2701 even if the time zone offset is outlandishly large.
2702 Don't mishandle offset == INT_MIN.
2703
66c6fdd5
PE
2704 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2705 when creating daemon; the previous buffer-overflow check was incorrect.
2706
d749b01b
PE
2707 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2708 which has the guts of the old verror function.
2709
b5cd1905
PE
2710 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2711 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2712
6e1a67fb
PE
2713 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2714 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2715 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2716 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2717 length of string rather than counting it via multiple sprintfs;
2718 that's simpler and more reliable.
c21721cc
PE
2719 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2720 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2721 sprintf, in case result does not fit in int.
2722
c57b67fc
PE
2723 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2724 (fontset_from_font): Print it.
2725
8a401434
PE
2726 * frame.c (tty_frame_count): Now printmax_t, not int.
2727 (make_terminal_frame, set_term_frame_name): Print it.
2728 (x_report_frame_params): In X, window IDs are unsigned long,
2729 not signed long, so print them as unsigned.
2730 (validate_x_resource_name): Check for implausibly long names,
2731 and don't assume name length fits in 'int'.
2732 (x_get_resource_string): Don't blindly alloca invocation name;
2733 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2734 not fit in int.
2735
6e1a67fb
PE
2736 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2737 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2738 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2739
0df02bf3
PE
2740 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2741 Use esprintf, not sprintf, in case result does not fit in int.
2742
48e30793
PE
2743 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2744 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2745 it as a large positive number.
2746 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2747 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2748
a66ff6d8
PE
2749 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2750 in case result does not fit in int.
2751
aca216ff
PE
2752 * print.c (float_to_string): Detect width overflow more reliably.
2753 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2754 buffer overrun. Don't assume list length fits in 'int'. Treat
2755 print length of 0 as 0, not as infinity; to be consistent with other
2756 uses of print length in this function. Don't overflow print length
2757 index. Don't assume hash table size fits in 'long', or that
2758 vectorlike size fits in 'unsigned long'.
2759
31c286f7
PE
2760 * process.c (make_process): Use printmax_t, not int, to format
2761 process-name gensyms.
2762
55e5faa1
PE
2763 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2764
80f2e268
PE
2765 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2766 to avoid potential buffer overrun.
2767
670741ab
PE
2768 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2769 if X resource line is longer than 512 bytes.
2770
b7163a50
PE
2771 * xfns.c (x_window): Make sprintf buffer a bit bigger
2772 to avoid potential buffer overrun.
2773
ae58ff1f
PE
2774 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2775
c43c8a6a
PE
2776 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2777
3f8236f4
PE
27782011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2779
53e9fe90 2780 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2781 Without these, Emacs silently mishandles large integers sometimes.
2782 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2783 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2784
6511acf2
PE
2785 * xdisp.c (try_window_id): Check Emacs fixnum range before
2786 converting to 'int'.
806add1d 2787
6511acf2 2788 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2789 Check that an Emacs fixnum is in range before assigning it to 'int'.
2790 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2791 values converted from Emacs fixnums.
2792 (Frecenter): Don't wrap around a line count if it is out of 'int'
2793 range; instead, treat it as an extreme value.
2794 (Fset_window_configuration, compare_window_configurations):
2795 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2796
6511acf2
PE
2797 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2798 that can exceed INT_MAX. Check that EMACS_INT value is in range
2799 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2800 (match_limit): Don't assume that a fixnum can fit in 'int'.
2801
6511acf2 2802 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2803 exceed INT_MAX.
2804
6511acf2 2805 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2806 (Fvertical_motion): Don't wrap around LINES values that don't fit
2807 in 'int'. Instead, treat them as extreme values. This is good
2808 enough for windows, which can't have more than INT_MAX lines anyway.
2809
fcb901a7
LMI
28102011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2811
0f2f6b6d
LMI
2812 * Require libxml/parser.h to avoid compilation warning.
2813
fcb901a7
LMI
2814 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2815
2816 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2817 since this reportedly can destroy thread storage.
2818
6e20a0d4
CY
28192011-08-30 Chong Yidong <cyd@stupidchicken.com>
2820
2821 * syntax.c (find_defun_start): Update all cache variables if
2822 exiting early (Bug#9401).
2823
148ae00e
EZ
28242011-08-30 Eli Zaretskii <eliz@gnu.org>
2825
f6cfbd8f
EZ
2826 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2827
148ae00e
EZ
2828 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2829 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2830 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2831
2832 * term.c (tty_append_glyph): New function.
2833 (produce_stretch_glyph): Static function and its prototype deleted.
2834
a66cfb1c
SM
2835 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2836 Add prototypes.
148ae00e 2837
c4a07a4c
PE
28382011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2839
2840 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2841 when checking :margin (Bug#9390).
2842 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2843 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2844 so that the name doesn't mislead. All uses changed.
2845
6bc8cd65
JB
28462011-08-28 Johan Bockgård <bojohan@gnu.org>
2847
2848 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2849 set_tty_hooks.
2850
dca4927e
EZ
28512011-08-27 Eli Zaretskii <eliz@gnu.org>
2852
2853 * xdisp.c (move_it_to): Don't bail out early when reaching
2854 position beyond to_charpos, if we are scanning backwards.
2855 (move_it_vertically_backward): When DY == 0, make sure we get to
2856 the first character in the line after the newline.
2857
f2cad773
PE
28582011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2859
2860 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2861 (ccl_driver): Do not generate an out-of-range pointer.
2862 (Fccl_execute_on_string): Remove unnecessary check for
2863 integer overflow, noted by Stefan Monnier in
2864 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2865 Remove a FIXME that didn't need fixing.
2866 Simplify the newly-introduced buffer reallocation code.
2867
0cae2cdb
JB
28682011-08-27 Juanma Barranquero <lekktu@gmail.com>
2869
2870 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2871
5fc295a4 28722011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2873
70c60eb2 2874 Integer and memory overflow issues (Bug#9196).
726e0ab1 2875
d31850da
PE
2876 * doc.c (get_doc_string): Rework so that
2877 get_doc_string_buffer_size is the actual buffer size, rather than
2878 being 1 less than the actual buffer size; this makes xpalloc more
2879 convenient.
2880
a69fbedb
PE
2881 * image.c (x_allocate_bitmap_record, cache_image):
2882 * xselect.c (Fx_register_dnd_atom):
2883 Simplify previous changes by using xpalloc.
2884
fe5c5d37
PE
2885 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2886 since either will do and ptrdiff_t is convenient with xpalloc.
2887
0065d054
PE
2888 * charset.c (charset_table_size)
2889 (struct charset_sort_data.priority): Now ptrdiff_t.
2890 (charset_compare): Don't overflow if priorities differ greatly.
2891 (Fsort_charsets): Don't assume list length fits in int.
2892 Check for size-calculation overflow when allocating sort data.
2893 (syms_of_charset): Allocate an initial charset table that is
2894 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2895
2896 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2897
2898 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2899 The actual value is always <= INT_MAX, and leaving it unsigned made
2900 overflow checking harder.
2901
2902 * dispextern.h (struct glyph_matrix.rows_allocated)
2903 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2904 with xpalloc. The values are still always <= INT_MAX.
2905
2906 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2907
2908 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2909 (SAFE_NALLOCA): New macro.
2910
2911 * region-cache.c (struct boundary.pos, find_cache_boundary)
2912 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2913 (set_cache_region, invalidate_region_cache)
2914 (revalidate_region_cache, know_region_cache, region_cache_forward)
2915 (region_cache_backward, pp_cache):
2916 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2917 so that ptrdiff_t * can be passed to xpalloc.
2918 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2919 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2920 (pp_cache): Don't assume cache_len fits in int.
2921 * region-cache.h: Adjust extern decls to match.
2922
2923 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2924 EMACS_INT, since either will do, for xpalloc.
2925
2926 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2927 (xnmalloc, xnrealloc, xpalloc): New functions.
2928
726e0ab1
PE
2929 * bidi.c (bidi_shelve_header_size): New constant.
2930 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2931 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2932
51f30bc5 2933 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2934 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2935 (overlay_strings):
2936 Don't update size of array until after memory allocation succeeds,
2937 because xmalloc/xrealloc may not return.
0065d054
PE
2938 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2939 now that we have proper integer overflow checking.
2940 (record_overlay_string, overlay_strings): Catch overflows when
2941 calculating size of overlay_str_buf.
726e0ab1 2942
0065d054
PE
2943 * callproc.c (Fcall_process): Check for size overflow when
2944 calculating size of args2.
2945 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2946 Normally we prefer signed values, but sticking with ptrdiff_t would
2947 require adding more-complicated checks.
726e0ab1
PE
2948
2949 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2950 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2951 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2952 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2953
2954 * character.c (Fstring): Check for size-calculation overflow.
2955
2956 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2957 unnecessary integer overflow. Check for size overflow.
2958 (encode_coding_object): Don't update size until xmalloc succeeds.
2959
2960 * composite.c (get_composition_id): Check for overflow in glyph
2961 length calculations.
2962
2963 Integer and memory overflow fixes for display code.
2964 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2965 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2966 (scrolling_window): Check for overflow in size calculations.
2967 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2968 Don't assume glyph table len fits in int.
2969 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2970 (row_table_size): Now ptrdiff_t, not int.
2971 (scrolling_window): Avoid overflow in size calculations.
2972 Don't update size until allocation succeeds.
2973 * fns.c (concat): Check for overflow in size calculations.
2974 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2975 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2976 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2977
2978 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2979 (get_doc_string): Check for size calculation overflow.
2980 Don't update size until allocation succeeds.
2981 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2982 EMACS_INT, where ptrdiff_t will do.
2983 (Fsubstitute_command_keys): Check for string overflow.
2984
2985 * editfns.c (set_time_zone_rule): Don't assume environment length
2986 fits in int.
2987 (message_length): Now ptrdiff_t, not int.
2988 (Fmessage_box): Don't update size until allocation succeeds.
2989 Don't assume message length fits in int.
2990 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2991
0065d054
PE
2992 * emacs.c (main): Do not reallocate argv, since there is a null at
2993 the end that can be overwritten, and this way there's no need to
2994 worry about size-calculation overflow.
2995 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2996
2997 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2998 alloc succeeds.
2999 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3000
3001 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3002 (x_set_scroll_bar_width, x_figure_window_size):
3003 Check for integer overflow.
3004 (x_set_alpha): Do not assume XINT fits in int.
3005
3006 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3007 This is for the members text_lines, text_cols, total_lines, total_cols,
3008 where the system imposes an 'int' limit.
3009
3010 * fringe.c (Fdefine_fringe_bitmap):
3011 Don't update size until alloc works.
3012
3013 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3014 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3015
3016 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3017 Check for size-calculation overflow.
3018 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3019 do, as we prefer signed integers.
3020 (id_to_widget.max_size, id_to_widget.used)
3021 (xg_store_widget_in_map, xg_remove_widget_from_map)
3022 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3023 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3024 Use and return ptrdiff_t, not int.
3025 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3026 * gtkutil.h: Change prototypes to match the above.
3027
3028 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3029 are duplicate now that they've been promoted to lisp.h.
3030 (x_allocate_bitmap_record, x_alloc_image_color)
3031 (make_image_cache, cache_image, xpm_load):
3032 Don't update size until alloc is done.
3033 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3034 (x_detect_edges):
3256efce 3035 Check for size calculation overflow.
726e0ab1
PE
3036 (ct_colors_allocated_max): New constant.
3037 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3038 overflow.
3256efce 3039
726e0ab1
PE
3040 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3041 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3042 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3043 Use ptrdiff_t, not int, to count maps.
3044 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3045 calculations. Don't update size until allocation succeeds.
3046 Redo calculations to avoid overflow.
726e0ab1
PE
3047 * keyboard.h: Change prototypes to match the above.
3048
3049 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3050 to count maps.
3051 (current_minor_maps): Check for size calculation overflow.
3052 * keymap.h: Change prototypes to match the above.
3053
3054 * lread.c (read1, init_obarray): Don't update size until alloc done.
3055
3056 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3057 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3058
726e0ab1
PE
3059 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3060 Now ptrdiff_t, not int.
3061 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3062 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3063
3064 * process.c (Fnetwork_interface_list): Check for overflow
3065 in size calculation.
3066
3067 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3068
3069 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3070 overflow. Don't bother calling xmalloc when xrealloc will do.
3071
3072 * search.c (Freplace_match): Check for size calculation overflow.
3073 (Fset_match_data): Don't assume list lengths fit in 'int'.
3074
3075 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3076 for command line length. Do not attempt to address one before the
3077 beginning of an array, as that's not portable.
3078
3079 * term.c (max_frame_lines): Remove; unused.
3080 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3081 not int.
3082 (encode_terminal_code, calculate_costs): Check for size
3083 calculation overflow.
3084 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3085 table lengths and related sizes. Don't update size until alloc
3086 done. Redo calculations to avoid overflow.
3087 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3088
3089 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3090 subtracting pointers.
3091 (gobble_line): Check for overflow more carefully. Don't update size
3092 until alloc done.
3093
3094 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3095 Don't update size until alloc done.
3096 Redo size calculations to avoid overflow.
3097 Check for size calculation overflow.
0065d054 3098 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3099
3100 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3101 Use ptrdiff_t, not int, for sizes.
3102 (store_mode_line_noprop_char): Don't update size until alloc done.
3103
0065d054
PE
3104 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3105 Use ptrdiff_t, not int, for sizes.
3106 (Finternal_make_lisp_face, cache_face):
3107 Check for size calculation overflow.
3108 (cache_face): Treat size calculation overflows as if they were
3109 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3110
3111 * xfns.c (x_encode_text, x_set_name_internal)
3112 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3113 sizes, since they can exceed INT_MAX in size. Check for size
3114 calculation overflow.
3115
0065d054
PE
3116 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3117 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3118 Don't update size until alloc done.
3119
0065d054 3120 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3121 as sprintf is limited to int lengths.
1d526e2f 3122
252c5ee1
PE
3123 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3124 (X_LONG_MIN): New macros.
864d7ce7
PE
3125 Use them to make the following changes clearer.
3126 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3127 This change doesn't affect the value now, but it may help remind
3128 future maintainers not to raise the value too much later.
3129 (SELECTION_QUANTUM): Remove, replacing with ...
3130 (selection_quantum): ... new function, which avoids overflow.
3131 All uses changed.
3132 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3133 assumption that selection length fits in 'int'.
3134 (x_reply_selection_request, x_handle_selection_request)
3135 (x_get_window_property, receive_incremental_selection)
3136 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3137 (lisp_data_to_selection_data, clean_local_selection_data):
3138 Use ptrdiff_t, not int, to record length of selection.
3139 (x_reply_selection_request, x_get_window_property)
3140 (receive_incremental_selection, x_property_data_to_lisp):
3141 Redo calculations to avoid overflow.
3142 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3143 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3144 something.
3145 (x_get_window_property, receive_incremental_selection)
3146 (lisp_data_to_selection_data, x_property_data_to_lisp):
3147 Check for size-calculation overflow.
3148 (x_get_window_property, receive_incremental_selection)
3149 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3150 Don't store size until memory allocation succeeds.
3151 (x_get_window_property): Plug memory leak on memory exhaustion.
3152 Don't double-block input; malloc is safe here. Don't assume 2**34
3153 - 4 fits in unsigned long. Add an xassert to check
3154 XGetWindowProperty overflow. Be more careful about overflow
3155 calculations, and distinguish size from memory overflow better.
3156 (receive_incremental_selection): When tracing, don't assume
3157 unsigned int is less than INT_MAX.
3158 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3159 harmful) conversions of unsigned short to int.
3160 (lisp_data_to_selection_data): Don't assume that integers
3161 in the range -65535 through -1 fit in an X unsigned short.
3162 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3163 result parameters unless successful. Rely on cons_to_unsigned
3164 to report problems with elements; the old code wasn't right anyway.
3165 (x_check_property_data): Check for int overflow; we cannot use
3166 a wider type due to X limits.
3167 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3168
726e0ab1 3169 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3170
0065d054
PE
3171 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3172 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3173 (x_color_cells): Don't store size until memory allocation succeeds.
3174 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3175 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3176 (x_term_init): Don't assume length fits in int (sprintf is limited
3177 to int size).
bc18e09d 3178
ebfa62c0
PE
3179 Use ptrdiff_t for composition IDs.
3180 * character.c (lisp_string_width):
3181 * composite.c (composition_table_size, n_compositions)
3182 (get_composition_id, composition_gstring_from_id):
3183 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3184 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3185 * window.c (Frecenter):
3186 Use ptrdiff_t, not int, for composition IDs.
3187 * composite.c (get_composition_id): Check for integer overflow.
3188 * composite.h: Adjust prototypes to match the above changes.
3189
d3411f89
PE
3190 Use ptrdiff_t for hash table indexes.
3191 * category.c (hash_get_category_set):
3192 * ccl.c (ccl_driver):
3193 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3194 * coding.c (coding_system_charset_list, detect_coding_system):
3195 * coding.h (struct coding_system.id):
3196 * composite.c (get_composition_id, gstring_lookup_cache):
3197 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3198 * image.c (xpm_get_color_table_h):
3199 * lisp.h (hash_lookup, hash_put):
3200 * minibuf.c (Ftest_completion):
3201 Use ptrdiff_t for hash table indexes, not int (which is too
3202 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3203 32-bit --with-wide-int hosts).
3204
e097a6fa
PE
3205 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3206 Add a FIXME comment about memory leaks.
3207 (syms_of_charset): Don't assume xmalloc returns.
3208
5637687f
PE
3209 Don't assume that stated character widths fit in int.
3210 * character.c (Fchar_width, c_string_width, lisp_string_width):
3211 * character.h (CHAR_WIDTH):
3212 * indent.c (MULTIBYTE_BYTES_WIDTH):
3213 Use sanitize_char_width to avoid undefined and/or bad behavior
3214 with outlandish widths.
a66cfb1c 3215 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3216 now that we have two such functions. All uses changed.
3217 (sanitize_char_width): New inline function.
3218
a2271ba2
PE
3219 Don't assume that tab-width fits in int.
3220 * character.h (sanitize_width): New inline function.
3221 (SANE_TAB_WIDTH): New macro.
3222 (ASCII_CHAR_WIDTH): Use it.
3223 * indent.c (sane_tab_width): Remove. All uses replaced by
3224 SANE_TAB_WIDTH (current_buffer).
3225 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3226
18c52557
PE
3227 * fileio.c: Integer overflow issues with file modes.
3228 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3229
caeeedc1
PE
3230 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3231 Remove unreachable code.
3232 (read_hex, load_charset_map_from_file): Check for integer overflow.
3233
6df6ae42 3234 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3235 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3236 (x_send_scroll_bar_event): Likewise. Check that the size does not
3237 exceed limits imposed by XClientMessageEvent, as well as the usual
3238 ptrdiff_t and size_t limits.
3239
b13995db
PE
3240 * keyboard.c: Overflow, signedness and related fixes.
3241 (make_lispy_movement): Use same integer type in forward decl
3242 that is used in the definition.
3243 (read_key_sequence, keyremap_step):
3244 Change bufsize argument back to int, undoing my 2011-03-30 change.
3245 We prefer signed types, and int is wide enough here.
3246 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3247 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3248 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3249 length, not size_t. Use ptrdiff_t for index, not int.
3250 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3251 possibility of integer overflow.
3252
13464394
PE
3253 Overflow, signedness and related fixes for images.
3254
3255 * dispextern.h (struct it.stack[0].u.image.image_id)
3256 (struct_it.image_id, struct image.id, struct image_cache.size)
3257 (struct image_cache.used, struct image_cache.ref_count):
3258 * gtkutil.c (update_frame_tool_bar):
3259 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3260 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3261 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3262 * nsmenu.m (update_frame_tool_bar):
3263 * xdisp.c (calc_pixel_width_or_height):
3264 * xfns.c (image_cache_refcount):
3265 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3266 on typical 64-bit hosts.
3267
3268 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3269 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3270 Omit unnecessary casts to int.
3271 (parse_image_spec): Check that integers fall into 'int' range
3272 when the callers expect that.
3273 (image_ascent): Redo ascent calculation to avoid int overflow.
3274 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3275 (lookup_image): Remove unnecessary tests.
3276 (xbm_image_p): Locals are now of int, not EMACS_INT,
3277 since parse_image_check makes sure they fit into int.
3278 (png_load, gif_load, svg_load_image):
3279 Prefer int to unsigned where either will do.
3280 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3281 old tiff_error_handler and tiff_warning_handler.
3282 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3283 stack buffer overflows. It uses only the features of vsnprintf
3284 that are common to both POSIX and native Microsoft.
3285 (tiff_error_handler, tiff_warning_handler): Use it.
3286 (tiff_load, gif_load, imagemagick_load_image):
3287 Don't assume :index value fits in 'int'.
3288 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3289 (imagemagick_load_image): Check that crop parameters fit into
3290 the integer types that MagickCropImage accepts. Don't assume
3291 Vimagemagick_render_type has a nonnegative value. Don't assume
3292 size_t fits in 'long'.
3293 (gs_load): Use printmax_t to print the widest integers possible.
3294 Check for integer overflow when computing image height and width.
3295
c11821d4
EZ
32962011-08-26 Eli Zaretskii <eliz@gnu.org>
3297
3298 * xdisp.c (redisplay_window): Don't force window start if point
3299 will be invisible in the resulting window. (Bug#9324)
3300
0c95fcf7
EZ
33012011-08-25 Eli Zaretskii <eliz@gnu.org>
3302
3303 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3304 the display spec is of the form `(space ...)'.
3305 (handle_display_spec): Return the value returned by
3306 handle_single_display_spec, not just 1 or zero.
3307 (handle_single_display_spec): If the display spec is of the form
3308 `(space ...)', and specifies display in the text area, return 2
3309 rather than 1.
fee65a97 3310 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3311 accurately, and prefer exact match for point under bidi.
3312 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3313
3314 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3315 into disp_prop; all users changed.
3316
3317 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3318 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3319 for the text covered by the display property.
3320
e4ed06f1
CY
33212011-08-25 Chong Yidong <cyd@stupidchicken.com>
3322
3323 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3324 Change return value to nil.
3325 (Frecord_buffer): Delete unused function.
3326
f67cdd7f
EZ
33272011-08-24 Eli Zaretskii <eliz@gnu.org>
3328
5980d4c6
EZ
3329 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3330 buffers, return left-to-right.
8610fe8b
EZ
3331 (set_cursor_from_row): Consider candidate row a win if its glyph
3332 represents a newline and point is on that newline. Fixes cursor
3333 positioning on the newline at EOL of R2L text within L2R
3334 paragraph, and vice versa.
3335 (try_cursor_movement): Check continued rows, in addition to
3336 continuation rows. Fixes unwarranted scroll when point enters a
3337 continued line of R2L text within an L2R paragraph, or vice versa.
3338 (cursor_row_p): Consider the case of point being equal to
3339 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3340 from the end of a short line to the beginning of a continued line
3341 of R2L text within L2R paragraph.
3342 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3343 composed characters.
5980d4c6 3344
f67cdd7f
EZ
3345 * bidi.c (bidi_check_type): Use xassert.
3346 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3347 members.
3348
bca633fb
EZ
33492011-08-23 Eli Zaretskii <eliz@gnu.org>
3350
3351 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3352 a character.
3353
4a5885a7
CY
33542011-08-23 Chong Yidong <cyd@stupidchicken.com>
3355
3356 * nsfont.m (ns_otf_to_script): Fix typo.
3357
0902a04e
KH
33582011-08-22 Kenichi Handa <handa@m17n.org>
3359
3360 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3361 extra slot even if the purpose is char-code-property-table.
3362
1a2e6670
EZ
33632011-08-23 Eli Zaretskii <eliz@gnu.org>
3364
8ddde651
EZ
3365 * xdisp.c (redisplay_window): When computing centering_position,
3366 account for the height of the header line. (Bug#8874)
3367
425cc014
EZ
3368 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3369 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3370 candidate is selected by the mouse, and that candidate has a
3371 composed character under the mouse.
3372
1a2e6670
EZ
3373 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3374 coordinates reported by pos-visible-in-window-p for a composed
3375 character in column zero.
3376
8b76d6f8
SM
33772011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3378
3379 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3380
dac347dd
EZ
33812011-08-22 Eli Zaretskii <eliz@gnu.org>
3382
3383 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3384 consider it a hit if to_charpos is anywhere in the range of the
3385 composed buffer positions.
3386
e013fb34
CY
33872011-08-22 Chong Yidong <cyd@stupidchicken.com>
3388
3389 * image.c (gif_load): Don't assume that each subimage has the same
3390 dimensions as the base image. Handle disposal method that is
3391 "undefined" by the gif spec (Bug#9335).
3392
bd1ba3e8
CY
33932011-08-20 Chong Yidong <cyd@stupidchicken.com>
3394
3395 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3396 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3397
54a1215b
EZ
33982011-08-19 Eli Zaretskii <eliz@gnu.org>
3399
823564e5
EZ
3400 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3401 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3402 from an Org mode buffer to a Speedbar frame.
3403
54a1215b
EZ
3404 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3405 a composition, take its buffer position from IT->cmp_it.charpos.
3406 Fixes cursor positioning at the beginning of a line that begins
3407 with a composed character.
3408
9778ebcc
EZ
34092011-08-18 Eli Zaretskii <eliz@gnu.org>
3410
0be6ee06
EZ
3411 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3412 character bidirectional type, use STRONG_L instead. Fixes crashes
3413 in a buffer produced by `describe-categories'.
3414
9778ebcc
EZ
3415 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3416 members before the level stack, so they would be saved and
3417 restored when copying iterator state. Fixes incorrect reordering
3418 around TABs covered by display properties.
3419
156bffbe
AS
34202011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3421
6b02f655 3422 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3423
72ad093b
CY
34242011-08-17 Chong Yidong <cyd@stupidchicken.com>
3425
3426 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3427 (internal_condition_case_2, internal_condition_case_n):
3428 Remove unnecessary aborts (Bug#9081).
72ad093b 3429
35774242
EZ
34302011-08-17 Eli Zaretskii <eliz@gnu.org>
3431
3432 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3433 has no `load' handler, try opening the file locally. (Bug#9311)
3434
db76dd85
KB
34352011-08-16 Ken Brown <kbrown@cornell.edu>
3436
3437 * gmalloc.c: Expand comment.
3438
b215eee5
EZ
34392011-08-16 Eli Zaretskii <eliz@gnu.org>
3440
3441 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3442 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3443
a4579d33
KB
34442011-08-16 Ken Brown <kbrown@cornell.edu>
3445
3446 Fix memory allocation problems in Cygwin build (Bug#9273).
3447
3448 * unexcw.c ( __malloc_initialized): Declare external variable.
3449 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3450
8b76d6f8
SM
3451 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3452 New variables.
a4579d33
KB
3453 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3454 dumped emacs.
3455 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3456 in the static heap.
3457 [CYGWIN] (special_realloc): New function.
3458 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3459 requests to realloc storage in the static heap.
3460
3ebec551
PE
34612011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3462
3463 * bidi.c (bidi_initialize): Remove unused local.
3464
9fd8be00
EZ
34652011-08-15 Eli Zaretskii <eliz@gnu.org>
3466
6b02f655
SM
3467 * bidimirror.h:
3468 * biditype.h: Remove file.
3469 * makefile.w32-in ($(BLD)/bidi.$(O)):
3470 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3471
3472 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3473
3474 * chartab.c: Improve commentary for the uniprop_table API.
3475
32413314
EZ
3476 * bidi.c (bidi_paragraph_init): Support zero value of
3477 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3478 (bidi_initialize): Use uniprop_table instead of including
3479 biditype.h and bidimirror.h.
32413314 3480
9fd8be00
EZ
3481 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3482 coordinates of the iterator when restoring from ppos_it.
3483 (Bug#9296)
3484
5cf2b69b
KH
34852011-08-14 Kenichi Handa <handa@m17n.org>
3486
3487 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3488 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3489
daf17d00
EZ
34902011-08-14 Eli Zaretskii <eliz@gnu.org>
3491
3492 * xdisp.c (move_it_in_display_line_to): Don't invoke
3493 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3494 ppos_it. Fixes vertical cursor motion when line beginning is
3495 covered by an image. (Bug#9296)
3496
08e3161a
JD
34972011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3498
3499 * nsterm.h (ns_run_ascript): Declare.
3500 (NSAPP_DATA2_RUNASSCRIPT): Define.
3501
3502 * nsfns.m (as_script, as_result, as_status): New static variables.
3503 (ns_run_ascript): New function.
5e617bc2 3504 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3505 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3506 the event loop. Get status from as_status (Bug#7276).
3507
3508 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3509 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3510 the event loop (Bug#7276).
3511
a3720aa2
AS
35122011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3513
3514 * gnutls.c (QCgnutls_bootprop_priority)
3515 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3516 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3517 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3518 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3519 (QCgnutls_bootprop_verify_hostname_error)
3520 (QCgnutls_bootprop_callbacks_verify): Rename from
3521 Qgnutls_bootprop_..., all uses changed.
3522
3523 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3524 uses changed.
3525
0a0d27fb
PE
35262011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3527
19d5c50c
PE
3528 * xfaces.c (Qframe_set_background_mode): Now static.
3529 * dispextern.h (Qframe_set_background_mode): Remove decl.
3530
0a0d27fb
PE
3531 * process.c (Fnetwork_interface_info): Declare local only if needed.
3532
377538cb
JD
35332011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3534
3535 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3536 (Fnetwork_interface_list): Allocate in increments of bytes instead
3537 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3538 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3539 sockaddr.
3540 (struct ifflag_def): notrailers is smart on OSX.
3541 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3542 Get hardware address with getifaddrs if available.
3543
08fff70c
EZ
35442011-08-12 Eli Zaretskii <eliz@gnu.org>
3545
3546 * xdisp.c (iterate_out_of_display_property): xassert that
3547 IT->position is set to within IT->object's boundaries. Break from
3548 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3549 when IT->position is set up wrongly due to some bug.
3550 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3551 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3552 entry. Force push_it to save on the stack the current
3553 buffer/string position, to be restored by pop_it. Fix flags in
3554 the iterator structure wrt the object coming from a display
3555 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3556 properties. (Bug#9284)
3557
7be1c708 35582011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3559
7be1c708
CY
3560 * fontset.c (fontset_get_font_group): Add proper type checks.
3561 (Bug#9172)
aac0c6e3 3562
7be1c708 35632011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3564
7be1c708
CY
3565 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3566 and LC_VERSION_MIN_MACOSX.
3567 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3568 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3569
97bb72a6
EZ
35702011-08-08 Eli Zaretskii <eliz@gnu.org>
3571
3572 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3573 no-display-properties-and-no-overlays under bidi display.
3574 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3575 properties and overlays.
97bb72a6 3576
d5617611
CY
35772011-08-08 Chong Yidong <cyd@stupidchicken.com>
3578
37e11a63
CY
3579 * editfns.c (Fset_time_zone_rule): Document relationship with the
3580 setenv function.
3581
d5617611
CY
3582 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3583 the font entity extracted from the cache (Bug#8109).
3584
58872834
CY
35852011-08-07 Chong Yidong <cyd@stupidchicken.com>
3586
3587 * composite.c (autocmp_chars): Don't reset point. That is done by
3588 restore_point_unwind (Bug#5984).
3589
75bfc667
JL
35902011-08-07 Juri Linkov <juri@jurta.org>
3591
3592 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3593 to show the arg `TIME' instead of `TIMEVAL'.
3594
d1410150
EZ
35952011-08-06 Eli Zaretskii <eliz@gnu.org>
3596
3597 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3598 display property strides EOL and includes a newline, as in
3599 longlines-mode. (Bug#9254)
75b771e4
EZ
3600 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3601 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3602
3603 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3604 is non-zero, even if the data buffer is NULL. Fixes a crash in
3605 vertical-motion with longlines-mode. (Bug#9254)
3606
35928349
EZ
36072011-08-05 Eli Zaretskii <eliz@gnu.org>
3608
ec7cc85b
EZ
3609 * bidi.c <bidi_cache_total_alloc>: Now static.
3610 (bidi_initialize): Initialize bidi_cache_total_alloc.
3611
8b76d6f8 3612 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3613 cache. (Bug#9221)
3614
3615 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3616 amount allocated this far in `bidi_cache_total_alloc'.
3617 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3618 non-zero, only free the data buffer without restoring the cache
3619 contents. All callers changed.
3620
3621 * dispextern.h (bidi_unshelve_cache): Update prototype.
3622
3623 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3624 (move_it_in_display_line, move_it_to)
3625 (move_it_vertically_backward, move_it_by_lines): Replace the call
3626 to xfree to an equivalent call to bidi_unshelve_cache.
3627 (move_it_in_display_line_to): Fix logic of returning
412b6358 3628 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3629
e2e2423b
EZ
36302011-08-05 Eli Zaretskii <eliz@gnu.org>
3631
3632 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3633 came from a string character with a `cursor' property. (Bug#9229)
3634
ae9e757a
JD
36352011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3636
3637 * Makefile.in (LIB_PTHREAD): New variable.
3638 (LIBES): Add LIB_PTHREAD (Bug#9216).
3639
3640 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3641 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3642
213bd7f2
AS
36432011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3644
6b02f655 3645 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3646
99aaf75f
JD
36472011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3648
3649 * xterm.c (x_find_topmost_parent): New function.
3650 (x_set_frame_alpha): Find topmost parent window with
3651 x_find_topmost_parent and set the property there also (bug#9181).
3652 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3653
c74e9d86
PE
36542011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3655
3656 * callproc.c (Fcall_process): Avoid vfork clobbering
3657 the local vars buffer, coding_systems, current_dir.
3658
640c8776
SM
36592011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3660
3661 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3662
f26d0e4c
PE
36632011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3664
8a10d76c
PE
3665 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3666 so that it is not optimized away.
3667
f26d0e4c
PE
3668 * xdisp.c (compute_display_string_pos): Remove unused local.
3669
55439c61
EZ
36702011-08-02 Eli Zaretskii <eliz@gnu.org>
3671
3672 Fix slow cursor motion and scrolling in large buffers with
3673 selective display, like Org Mode buffers. (Bug#9218)
3674
3675 * dispextern.h (struct bidi_it): New member disp_prop_p.
3676
3677 * xdisp.c: Remove one-slot cache of display string positions.
3678 (compute_display_string_pos): Accept an additional argument
5e617bc2 3679 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3680 for a display string or property. If found, set DISP_PROP_P
3681 non-zero.
3682
3683 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3684 DISP_PROP_P, and pass it to compute_display_string_pos.
3685 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3686 non-zero. All callers of bidi_fetch_char changed.
3687
fb33fa43
SM
36882011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3689
3690 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3691
b099e063
DM
36922010-12-03 Don March <don@ohspite.net>
3693
3694 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3695 last character M-[char] is translated to ESC [char] (bug#7541).
3696
5cc7f7af
KH
36972011-08-02 Kenichi Handa <handa@m17n.org>
3698
d0fffa3f 3699 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3700
3701 * chartab.c (uniprop_table): Make it non-static.
3702
525d5e6e
EZ
37032011-08-01 Eli Zaretskii <eliz@gnu.org>
3704
3705 * xdisp.c (forward_to_next_line_start): Accept additional argument
3706 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3707 on the newline.
3708 (reseat_at_next_visible_line_start): Use the bidi iterator state
3709 returned by forward_to_next_line_start to restore the state of
3710 it->bidi_it after backing up to previous newline. (Bug#9212)
3711
31011111
AS
37122011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3713
3714 * regex.c (re_comp): Protoize.
3715 (re_exec): Fix return type.
3716 (regexec): Fix type of `ret'. (Bug#9203)
3717
476371c4
PE
37182011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3719
e5d76069
PE
3720 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3721 This is needed if max-image-size is a floating-point number.
3722
9a79b20c
AS
37232011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3724
3725 * print.c (print_object): Print empty symbol as ##.
3726
3727 * lread.c (read1): Read ## as empty symbol.
3728
d8c2fa78
AA
37292011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3730
3731 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3732 setting frame foreground color (Bug#9175).
3733 (x_set_background_color): Likewise.
3734
ffe57a7a
AA
3735 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3736 contents (Bug#9176).
3737 (EmacsTooltip -init): Remove bezels and add shadows to
3738 tooltip windows.
3739
bf3492a5
AA
3740 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3741 or scroll bar (Bug#8470).
3742
d55e9c53
AA
3743 * nsfont.m (nsfont_open): Remove assignment to voffset and
3744 unnecessary vars hshink, expand, hd, full_height, min_height.
3745 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3746
3747 * nsterm.h (nsfont_info): Remove voffset field.
3748
d8c2fa78 37492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3750
3751 Implement strike-through and overline on NextStep (Bug#8863).
3752
3753 * nsfont.m (nsfont_open): Use underline position provided by font,
3754 instead of hard-coded value of 2.
3755 (nsfont_draw): Call ns_draw_text_decoration instead.
3756
3757 * nsterm.h: Add declaration for ns_draw_text_decoration.
3758
3759 * nsterm.m (ns_draw_text_decoration): New function for drawing
3760 underline, overline, and strike-through.
3761 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3762 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3763 accommodate underlining, etc.
4843aac3 3764
4cc60b9b
EZ
37652011-07-28 Eli Zaretskii <eliz@gnu.org>
3766
bc7ece87
EZ
3767 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3768 default.
4cc60b9b 3769
476371c4
PE
37702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3771
66606eea
PE
3772 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3773 Without this fix, if a signal arrives just after memory fills up,
3774 'malloc' might be invoked reentrantly.
3775
476371c4
PE
3776 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3777 In other words, assume that every image size is allowed, on non-X
3778 hosts. This assumption is probably wrong, but it lets Emacs compile.
3779
f3fcc40d
AS
37802011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3781
3782 * regex.c (re_iswctype): Convert return values to boolean.
3783
350c992f
EZ
37842011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3785
3786 * xdisp.c (compute_display_string_pos): Don't use cached display
3787 string position if the buffer had its restriction changed.
3788 (Bug#9184)
3789
5266b4bb
PE
37902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3791
3792 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3793
2573a837 37942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3795
41f55ccd 3796 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3797
39e378da
PE
3798 * bidi.c: Integer size and overflow fixes.
3799 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3800 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3801 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3802 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3803 (bidi_find_other_level_edge):
3804 Use ptrdiff_t instead of EMACS_INT where either will do.
3805 This works better on 32-bit hosts configured --with-wide-int.
3806 (bidi_cache_ensure_space): Check for size-calculation overflow.
3807 Use % rather than repeated addition, for better worst-case speed.
3808 Don't set bidi_cache_size until after xrealloc returns, because it
3809 might not return.
3810 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3811 (bidi_cache_ensure_space): Also check that the bidi cache size
3812 does not exceed that of the largest Lisp string or buffer. See Eli
3813 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3814
5e927815
PE
3815 * alloc.c (__malloc_size_t): Remove.
3816 All uses replaced by size_t. See Andreas Schwab's note
3817 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3818
ca4aa935
PE
3819 * image.c: Improve checking for integer overflow.
3820 (check_image_size): Assume that f is nonnull, since
3821 it is always nonnull in practice. This is one less thing to
3822 worry about when checking for integer overflow later.
3823 (x_check_image_size): New function, which checks for integer
3824 overflow issues inside X.
3825 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3826 This removes the need for a memory_full check.
3827 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3828 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3829 (xbm_read_bitmap_data): Change locals back to 'int', since
3830 their values must fit in 'int'.
3831 (xpm_load_image, png_load, tiff_load):
3832 Invoke x_create_x_image_and_pixmap earlier,
3833 to avoid much needless work if the image is too large.
3834 (tiff_load): Treat overly large images as if
3835 x_create_x_image_and_pixmap failed, not as malloc failures.
3836 (gs_load): Use x_check_image_size.
3837
5f8f9cc2
PE
3838 * gtkutil.c: Omit integer casts.
3839 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3840 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3841
5adf60bc
PE
3842 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3843
c8907a93
PE
3844 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3845 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3846 would wrongly return t on a 64-bit host.
3847
e3c25c68
PE
3848 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3849 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3850 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3851 and therefore cause GCC to emit a bogus diagnostic in some cases.
3852
3f791afe
PE
3853 * image.c: Integer signedness and overflow and related fixes.
3854 This is not an exhaustive set of fixes, but it's time to
3855 record what I've got.
3856 (lookup_pixel_color, check_image_size): Remove redundant decls.
3857 (check_image_size): Don't assume that arbitrary EMACS_INT values
3858 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3859 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3860 (tiff_load, imagemagick_load_image):
3861 Check for overflow in size calculations.
3862 (x_create_x_image_and_pixmap): Remove unnecessary test for
3863 xmalloc returning NULL; that can't happen.
3864 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3865 (xpm_color_bucket): Use better integer hashing function.
3866 (xpm_cache_color): Don't possibly over-allocate memory.
3867 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3868 (gif_memory_source):
3869 Use ptrdiff_t, not int or size_t, to record sizes.
3870 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3871 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3872 either works, as we prefer signed integers.
3873 (tiff_read_from_memory, tiff_write_from_memory):
3874 Return tsize_t, not size_t, since that's what the TIFF API wants.
3875 (tiff_read_from_memory): Don't fail simply because the read would
3876 go past EOF; instead, return a short read.
3877 (tiff_load): Omit no-longer-needed casts.
3878 (Fimagemagick_types): Don't assume size fits into 'int'.
3879
3cc5a532
PE
3880 Improve hashing quality when configured --with-wide-int.
3881 * fns.c (hash_string): New function, taken from sxhash_string.
3882 Do not discard information about ASCII character case; this
3883 discarding is no longer needed.
3884 (sxhash-string): Use it. Change sig to match it. Caller changed.
3885 * lisp.h: Declare it.
3886 * lread.c (hash_string): Remove, since we now use fns.c's version.
3887 The fns.c version returns a wider integer if --with-wide-int is
3888 specified, so this should help the quality of the hashing a bit.
3889
b312a492
PE
3890 * emacs.c: Integer overflow minor fix.
3891 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3892 Define only if GNU_LINUX.
3893 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3894
dfd153ae
PE
3895 * dispnew.c: Integer signedness and overflow fixes.
3896 Remove unnecessary forward decls, that were a maintenance hassle.
3897 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3898 All uses changed.
3899 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3900 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3901 (prepare_desired_row, line_draw_cost):
3902 Use int, not unsigned, where either works.
3903 (save_current_matrix, restore_current_matrix):
3904 Use ptrdiff_t, not size_t, where either works.
3905 (init_display): Check for overflow more accurately, and without
3906 relying on undefined behavior.
3907
a81d11a3
PE
3908 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3909 Remove, replacing with the new symbols in lisp.h. All uses changed.
3910 * fileio.c (make_temp_name):
3911 * filelock.c (lock_file_1, lock_file):
3912 * xdisp.c (message_dolog):
3913 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3914 Use pMd etc. instead.
3915 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3916 replacing the pWIDE etc. symbols removed from editfns.c.
3917
3300e6fd
PE
3918 * keyboard.h (num_input_events): Now uintmax_t.
3919 This is (very slightly) less likely to mess up due to wraparound.
3920 All uses changed.
3921
fd05c7e9
PE
3922 * buffer.c: Integer signedness fixes.
3923 (alloc_buffer_text, enlarge_buffer_text):
3924 Use ptrdiff_t rather than size_t when either will do, as we prefer
3925 signed integers.
3926
903fe15d
PE
3927 * alloc.c: Integer signedness and overflow fixes.
3928 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3929 (__malloc_size_t): Default to size_t, not to int.
3930 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3931 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3932 Prefer ptrdiff_t to size_t when either would do, as we prefer
3933 signed integers.
3934 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3935 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3936 Now const. Initialize with values that are in range even if char
3937 is signed.
3938 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3939 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3940 These functions do the right thing with sizes > 2**32.
3941 (check_depth): Now ptrdiff_t, not int.
3942 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3943 Adjust to new way of storing sizes. Check for size overflow bugs
3944 in rest of code.
3945 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3946 slightly wrong anyway, as it missed one instance of
3947 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3948 (refill_memory_reserve): Omit needless cast to size_t.
3949 (mark_object_loop_halt): Mark as externally visible.
3950
ac82cc6a
PE
3951 * xselect.c: Integer signedness and overflow fixes.
3952 (Fx_register_dnd_atom, x_handle_dnd_message):
3953 Use ptrdiff_t, not size_t, since we prefer signed.
3954 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3955 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3956 x_dnd_atoms_size and x_dnd_atoms_length.
3957
c2d1e36d
PE
3958 * doprnt.c: Prefer signed to unsigned when either works.
3959 * eval.c (verror):
3960 * doprnt.c (doprnt):
3961 * lisp.h (doprnt):
3962 * xdisp.c (vmessage):
3963 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3964 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3965 prefer signed arithmetic to avoid comparison confusion.
3966 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3967 but is a bit tricky.
3968
0e926e56
PE
3969 Assume freestanding C89 headers, string.h, stdlib.h.
3970 * data.c, doprnt.c, floatfns.c, print.c:
3971 Include float.h unconditionally.
3972 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3973 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3974 * regex.c: Likewise for stddef.h, string.h.
3975 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3976 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3977 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3978 (STDC_HEADERS): Remove obsolete defines.
3979 * sysdep.c: Include limits.h unconditionally.
3980
9cfdb3ec
PE
3981 Assume support for memcmp, memcpy, memmove, memset.
3982 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3983 * regex.c (memcmp, memcpy):
3984 Remove; we assume C89 now.
3985
3986 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3987 (__malloc_safe_bcopy): Remove; no longer needed.
3988
cf950e6b 3989 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3990 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3991 well either way, and we prefer signed to unsigned.
3992
dbf38e02
LMI
39932011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3994
3995 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3996 closes the connection while we're reading (bug#9182).
3997
d6f0886c 39982011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3999
d6f0886c
JD
4000 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4001 are specified (Bug#9168).
24e0f6b1 4002
2eb1f9e6
PE
40032011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4004
4005 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4006 Found by GCC static checking and --with-wide-int on a 32-bit host.
4007
22381272 40082011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4009
4010 * xdisp.c (compute_display_string_pos): Fix logic of caching
4011 previous display string position. Initialize cached_prev_pos to
4012 -1. Fixes slow-down at the beginning of a buffer.
4013
f25e39b4
EZ
40142011-07-24 Eli Zaretskii <eliz@gnu.org>
4015
4016 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4017 for attrs[LFACE_FONTSET_INDEX].
4018
04c4b52e
PE
40192011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4020
4021 * xml.c (parse_region): Remove unused local
4022 that was recently introduced.
4023
c1734fbd
EZ
40242011-07-23 Eli Zaretskii <eliz@gnu.org>
4025
be18c5a5
EZ
4026 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4027 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4028
c1734fbd
EZ
4029 * xdisp.c (move_it_in_display_line_to): Record the best matching
4030 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4031 exit if none of the characters scanned was an exact match.
4032 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4033 when exact match is impossible due to invisible text, and the
4034 lines are truncated.
4035
a258d627
JD
40362011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4037
4038 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4039 for OSX >= 10.7.
4040
b6d5a689
EZ
40412011-07-22 Eli Zaretskii <eliz@gnu.org>
4042
0f74f785
EZ
4043 Fix a significant slow-down of cursor motion with C-n, C-p,
4044 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4045 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4046 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4047 (next_element_from_buffer): Call compute_stop_pos_backwards to
4048 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4049 base_level_stop.
4050 (reseat): Don't look for prev_stop, as that could mean a very long
4051 run.
4052 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4053 <cached_disp_overlay_modiff>: Cache for last found display string
4054 position.
551918c1 4055 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4056 about the same buffer in the same area of character positions, and
4057 the buffer wasn't changed since the time the display string
4058 position was cached.
551918c1 4059
b2d0c91a
EZ
40602011-07-22 Eli Zaretskii <eliz@gnu.org>
4061
4062 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4063 is an integer, which is important for empty lines. (Bug#9149)
4064
043604ee
CY
40652011-07-22 Chong Yidong <cyd@stupidchicken.com>
4066
4067 * frame.c (Fmodify_frame_parameters): In tty case, update the
4068 default face if necessary (Bug#4238).
4069
da4adb04
CY
40702011-07-21 Chong Yidong <cyd@stupidchicken.com>
4071
4072 * editfns.c (Fstring_to_char): No need to explain what a character
4073 is in the docstring (Bug#6576).
4074
9abd0532
LMI
40752011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4076
4077 * xml.c (parse_region): Make sure we always return a tree.
4078
36881d16
HK
40792011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4080
4081 * xml.c (parse_region): If a document contains only comments,
4082 return that, too.
4083
1e98674d
LMI
40842011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4085
4086 * xml.c (make_dom): Return comments, too.
4087
590bd467
PE
40882011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4089
4090 Port to OpenBSD.
4091 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4092 and the surrounding thread.
4093 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4094 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4095 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4096 timer goes off.
4097 * s/openbsd.h (BROKEN_SIGIO): Define.
4098 * unexelf.c (unexec) [__OpenBSD__]:
4099 Don't update the .mdebug section of the Alpha COFF symbol table.
4100
f41628b2
LMI
41012011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4102
4103 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4104 (bug#8460).
4105
b59b67c5
PE
41062011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4107
15e3a074
PE
4108 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4109 This fixes some race conditions on the permissions of any newly
4110 created file.
4111
41bed37d
PE
4112 * alloc.c (valid_pointer_p): Use pipe, not open.
4113 This fixes some permissions issues when debugging.
4114
b59b67c5
PE
4115 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4116 If fchown fails to set both uid and gid, try to set just gid,
4117 as that is sometimes allowed. Adjust the file's mode to eliminate
4118 setuid or setgid bits that are inappropriate if fchown fails.
4119
925a6be7
SM
41202011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4121
4122 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4123 to compare Lisp_Objects.
4124 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4125 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4126 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4127
52968808
AS
41282011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4129
0a6a104b
AS
4130 * lread.c (read_integer): Unread even EOF character.
4131 (read1): Likewise. Properly record start position of symbol.
4132
52968808
AS
4133 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4134 symbol character follows.
4135
9e381cdd
PE
41362011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4137
4138 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4139 This works around a problem with the previous change to Fcopy_file.
4140 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4141 and without this change, GCC might complain about discarding
4142 fchown's return value.
4143
b5641435
JB
41442011-07-16 Juanma Barranquero <lekktu@gmail.com>
4145
4146 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4147
a8031457
PE
41482011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4149
4150 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4151
dd889327
LMI
41522011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4153
750c33f7
LMI
4154 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4155 it's used from the C level.
4156
dd889327
LMI
4157 * process.c: Use the same condition for POLL_FOR_INPUT in both
4158 keyboard.c and process.c (bug#1858).
4159
87e86684
LM
41602011-07-09 Lawrence Mitchell <wence@gmx.li>
4161
4162 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4163 (Fgnutls_boot): Use it.
4164
64348f40
AS
41652011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4166
4167 * doc.c (Fsubstitute_command_keys): Revert last change.
4168
1d698799
LMI
41692011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4170
f863868c
LMI
4171 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4172 quotes the next character, and doesn't affect other longer
4173 sequences (bug#8935).
4174
1d698799
LMI
4175 * lread.c (syms_of_lread): Clarify that is isn't only
4176 `eval-buffer' and `eval-defun' that's affected by
4177 `lexical-binding' (bug#8460).
4178
aa4b6df6
EZ
41792011-07-15 Eli Zaretskii <eliz@gnu.org>
4180
4181 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4182 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4183
5d856da6
PE
41842011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4185
ad6042bb
PE
4186 Fix minor problems found by static checking.
4187 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4188 (elsz): Now a signed constant, not a size_t var. We prefer signed
4189 types to unsigned, to avoid integer comparison confusion. Without
4190 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4191 "cannot optimize loop, the loop counter may overflow", a symptom
4192 of the confusion.
f00bbb22 4193 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4194 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4195
6468f31c
LMI
41962011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4197
49080b10
LMI
4198 * search.c (Fre_search_backward): Mention `case-fold-search' in
4199 all the re_search_* functions (bug#8138).
4200
6468f31c
LMI
4201 * keyboard.c (Fopen_dribble_file): Document when the file is
4202 closed (bug#8056).
4203
c965adc5
EZ
42042011-07-14 Eli Zaretskii <eliz@gnu.org>
4205
df9733bf
EZ
4206 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4207 bidi_cache_idx.
4208
0bb23927
EZ
4209 Support bidi reordering of display and overlay strings.
4210 * xdisp.c (compute_display_string_pos)
4211 (compute_display_string_end): Accept additional argument STRING.
4212 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4213 (reseat_to_string): Initialize bidi_it->string.s and
4214 bidi_it->string.schars.
4215 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4216 NULL (avoids a crash in bidi_paragraph_init).
4217 Initialize itb.string.lstring.
0bb23927
EZ
4218 (init_iterator): Call bidi_init_it only of a valid
4219 buffer position was specified. Initialize paragraph_embedding to
4220 L2R.
4221 (reseat_to_string): Initialize the bidi iterator.
4222 (display_string): If we need to ignore text properties of
4223 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4224 original value of -1 will not work with bidi.)
4225 (compute_display_string_pos): First arg is now struct
4226 `text_pos *'; all callers changed. Support display properties on
4227 Lisp strings.
4228 (compute_display_string_end): Support display properties on Lisp
4229 strings.
4230 (init_iterator, reseat_1, reseat_to_string): Initialize the
4231 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4232 when iterating on a string not from display properties).
640c8776
SM
4233 (compute_display_string_pos, compute_display_string_end):
4234 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4235 arrow keys.
4236 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4237 base_level_stop; instead, set base_level_stop to BEGV.
4238 Fixes crashes in vertical-motion.
0bb23927
EZ
4239 (next_element_from_buffer): Improve commentary for when
4240 the iterator is before prev_stop.
4241 (init_iterator): Initialize bidi_p from the default value of
4242 bidi-display-reordering, not from buffer-local value. Use the
4243 buffer-local value only if initializing for buffer iteration.
4244 (handle_invisible_prop): Support invisible properties on strings
4245 that are being bidi-reordered.
4246 (set_iterator_to_next): Support bidi reordering of C strings and
4247 Lisp strings.
4248 (next_element_from_string): Support bidi reordering of Lisp
4249 strings.
4250 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4251 (display_string): Support display of R2L glyph rows.
4252 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4253 (init_iterator): Don't initialize it->bidi_p for strings
4254 here.
4255 (reseat_to_string): Initialize it->bidi_p for strings here.
4256 (next_element_from_string, next_element_from_c_string)
4257 (next_element_from_buffer): Add xassert's for correspondence
4258 between IT's object being iterated and it->bidi_it.string
4259 structure.
4260 (face_before_or_after_it_pos): Support bidi iteration.
4261 (next_element_from_c_string): Handle the case of the first string
4262 character that is not the first one in the visual order.
4263 (get_visually_first_element): New function, refactored from common
4264 parts of next_element_from_buffer, next_element_from_string, and
4265 next_element_from_c_string.
4266 (tool_bar_lines_needed, redisplay_tool_bar)
4267 (display_menu_bar): Force left-to-right direction. Add a FIXME
4268 comment for making that be controlled by a user option.
4269 (push_it, pop_it): Save and restore the state of the
4270 bidi iterator. Save and restore the bidi_p flag.
4271 (pop_it): Iterate out of display property for string iteration as
4272 well.
4273 (iterate_out_of_display_property): Support iteration over strings.
4274 (handle_single_display_spec): Set up it->bidi_it for iteration
4275 over a display string, and call bidi_init_it.
4276 (handle_single_display_spec, next_overlay_string)
4277 (get_overlay_strings_1, push_display_prop): Set up the bidi
4278 iterator for displaying display or overlay strings.
4279 (forward_to_next_line_start): Don't use the shortcut if
4280 bidi-iterating.
4281 (back_to_previous_visible_line_start): If handle_display_prop
4282 pushed the iterator stack, restore the internal state of the bidi
4283 iterator by calling bidi_pop_it same number of times.
4284 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4285 and we are bidi-iterating, don't decrement the iterator position;
4286 instead, set the first_elt flag in the bidi iterator, to produce
4287 the same effect.
4288 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4289 (push_display_prop): xassert that we are iterating a buffer.
4290 (push_it, pop_it): Save and restore paragraph_embedding member.
4291 (handle_single_display_spec, next_overlay_string)
4292 (get_overlay_strings_1, reseat_1, reseat_to_string)
4293 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4294 correctly. Don't assume unibyte strings are not bidi-reordered.
4295 (compute_display_string_pos)
4296 (compute_display_string_end): Fix handling the case of C string.
4297 (push_it, pop_it): Save and restore from_disp_prop_p.
4298 (handle_single_display_spec, push_display_prop): Set the
4299 from_disp_prop_p flag.
4300 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4301 (pop_it): Call iterate_out_of_display_property only if we are
4302 popping after iteration over a string that came from a display
4303 property. Fix a typo in popping stretch info. Add an assertion
4304 for verifying that the iterator position is in sync with the bidi
4305 iterator.
4306 (handle_single_display_spec, get_overlay_strings_1)
4307 (push_display_prop): Fix initialization of paragraph direction for
4308 string when that of the parent object is not yet determined.
4309 (reseat_1): Call bidi_init_it to resync the bidi
4310 iterator with IT's position. (Bug#7616)
4311 (find_row_edges): If ROW->start.pos gives position
4312 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4313 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4314 Reset the from_disp_prop_p flag.
4315 (SAVE_IT, RESTORE_IT): New macros.
4316 (pos_visible_p, face_before_or_after_it_pos)
4317 (back_to_previous_visible_line_start)
4318 (move_it_in_display_line_to, move_it_in_display_line)
4319 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4320 (try_scrolling, redisplay_window, display_line): Use them when
4321 saving a temporary copy of the iterator and restoring it back.
4322 (back_to_previous_visible_line_start, reseat_1)
4323 (init_iterator): Empty the bidi cache "stack".
4324 (move_it_in_display_line_to): If iterator ended up at
4325 EOL, but we never saw any buffer positions smaller than
4326 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4327 motion in bidi-reordered lines.
4328 (move_it_in_display_line_to): Record prev_method and prev_pos
4329 immediately before the call to set_iterator_to_next. Fixes cursor
4330 motion in bidi-reordered lines with stretch glyphs and strings
4331 displayed in margins. (Bug#8133) (Bug#8867)
4332 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4333 TO_CHARPOS.
640c8776
SM
4334 (pos_visible_p): Support positions in bidi-reordered lines.
4335 Save and restore bidi cache.
0bb23927
EZ
4336
4337 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4338 (bidi_paragraph_info): Delete unused struct.
4339 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4340 (bidi_cache_start): New variable.
4341 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4342 to zero.
4343 (bidi_cache_fetch_state, bidi_cache_search)
4344 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4345 (bidi_cache_find, bidi_peek_at_next_level)
4346 (bidi_level_of_next_char, bidi_find_other_level_edge)
4347 (bidi_move_to_visually_next): Compare cache index with
4348 bidi_cache_start rather than with zero.
4349 (bidi_fetch_char): Accept new argument STRING; all callers
4350 changed. Support iteration over a string. Support strings with
4351 display properties. Support unibyte strings. Fix the type of
4352 `len' according to what STRING_CHAR_AND_LENGTH expects.
4353 (bidi_paragraph_init, bidi_resolve_explicit_1)
4354 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4355 (bidi_level_of_next_char, bidi_move_to_visually_next):
4356 Support iteration over a string.
0bb23927
EZ
4357 (bidi_set_sor_type, bidi_resolve_explicit_1)
4358 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4359 can now be zero (for strings); special values 0 and -1 were
4360 changed to -1 and -2, respectively.
4361 (bidi_char_at_pos): New function.
4362 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4363 Call it instead of FETCH_MULTIBYTE_CHAR.
4364 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4365 initialized to valid values.
4366 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4367 values.
4368 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4369 the test for valid cached positions. Fix the logic for looking up
4370 the sentinel state in the cache. GCPRO the Lisp string we are
4371 iterating.
4372 (bidi_push_it, bidi_pop_it): New functions.
4373 (bidi_initialize): Initialize the bidi cache start stack pointer.
4374 (bidi_cache_ensure_space): New function, refactored from part of
4375 bidi_cache_iterator_state. Don't assume the required size is just
4376 one BIDI_CACHE_CHUNK away.
4377 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4378 (bidi_count_bytes, bidi_char_at_pos): New functions.
4379 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4380 always valid if bidi_cache_idx is valid.
4381 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4382 is valid if it's going to be used.
4383 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4384 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4385 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4386 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4387 (bidi_find_other_level_edge, bidi_cache_start_stack):
4388 All variables related to cache indices are now EMACS_INT.
c965adc5 4389
0bb23927
EZ
4390 * dispextern.h (struct bidi_string_data): New structure.
4391 (struct bidi_it): New member `string'. Make flag members be 1-bit
4392 fields, and put them last in the struct.
640c8776
SM
4393 (compute_display_string_pos, compute_display_string_end):
4394 Update prototypes.
0bb23927
EZ
4395 (bidi_push_it, bidi_pop_it): Add prototypes.
4396 (struct iterator_stack_entry): New members bidi_p,
4397 paragraph_embedding, and from_disp_prop_p.
4398 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4399 (bidi_shelve_cache, bidi_unshelve_cache):
4400 Declare prototypes.
0bb23927
EZ
4401
4402 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4403 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4404 and vector-like objects.
4405
4406 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4407 cache around display iteration.
4408
4409 * window.c (Fwindow_end, window_scroll_pixel_based)
4410 (displayed_window_lines, Frecenter): Save and restore the bidi
4411 cache around display iteration.
4412
3bbd2265
LMI
44132011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4414
4415 * editfns.c (Fdelete_region): Clarify the use of the named
4416 parameters (bug#6788).
4417
adc47434
MR
44182011-07-14 Martin Rudalics <rudalics@gmx.at>
4419
4420 * indent.c (Fvertical_motion): Set and restore w->pointm when
4421 saving and restoring the window's buffer (Bug#9006).
4422
837c31f8
LMI
44232011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4424
4425 * editfns.c (Fstring_to_char): Clarify just what is returned
4426 (bug#6576). Text by Eli Zaretskii.
4427
ac389d0c
JB
44282011-07-13 Juanma Barranquero <lekktu@gmail.com>
4429
4430 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4431
0be0ce47
EZ
44322011-07-13 Eli Zaretskii <eliz@gnu.org>
4433
4434 * buffer.c (mmap_find): Fix a typo.
4435
cd18e7e3
JB
44362011-07-13 Johan Bockgård <bojohan@gnu.org>
4437
4438 Fix execution of x selection hooks.
4439 * xselect.c (Qx_lost_selection_functions)
4440 (Qx_sent_selection_functions): New vars.
4441 (syms_of_xselect): DEFSYM them.
4442 (x_handle_selection_request): Pass Qx_sent_selection_functions
4443 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4444 (x_handle_selection_clear,x_clear_frame_selections):
4445 Pass Qx_lost_selection_functions rather than
4446 Vx_lost_selection_functions to Frun_hook_with_args.
4447
47ea7f44
PE
44482011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4449
ac389d0c 4450 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4451 The old code sometimes used this field without initializing it.
4452
47ea7f44
PE
4453 * alloc.c (gc_sweep): Don't read past end of array.
4454 In theory, the old code could also have corrupted Emacs internals,
4455 though it'd be very unlikely.
4456
bc985c87
AS
44572011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4458
4459 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4460 argument. (Bug#4026)
bc985c87 4461
0cf34688
LMI
44622011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4463
b3dadd76
LMI
4464 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4465 key" (bug#4257).
4466
0cf34688
LMI
4467 * window.c (Fset_window_start): Doc fix (bug#4199).
4468 (Fset_window_hscroll): Ditto.
4469
270768cd
PE
44702011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4471
077e3dda 4472 Fix minor new problems caught by GCC 4.6.1.
270768cd 4473 * term.c (init_tty): Remove unused local.
490011a6 4474 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4475 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4476 not used otherwise.
270768cd 4477
b1f58454
CY
44782011-07-12 Chong Yidong <cyd@stupidchicken.com>
4479
4480 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4481
22b9578d
LMI
44822011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4483
6e70ab07
LMI
4484 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4485 are the mini-buffer and the echo area (bug#3320).
4486
22b9578d
LMI
4487 * term.c (init_tty): Remove support for supdup, c10 and perq
4488 terminals, which are no longer supported (bug#1482).
4489
8974cc9f
JB
44902011-07-10 Johan Bockgård <bojohan@gnu.org>
4491
4492 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4493
a560d974
JD
44942011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4495
4496 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4497 for non-popups (Bug#3642).
4498
1dae0f0a
AS
44992011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4500
268c2c36 4501 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4502 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4503 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4504 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4505 * data.c (fmod): Likewise.
4506 * dispnew.c (swap_glyphs_in_rows): Likewise.
4507 * emacs.c (memory_warning_signal): Likewise.
4508 * floatfns.c (float_error): Likewise.
4509 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4510 (otf_open, font_otf_capability, generate_otf_features)
4511 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4512 Likewise.
4513 * image.c (pbm_read_file): Likewise.
4514 * indent.c (string_display_width): Likewise.
4515 * intervals.c (check_for_interval, search_for_interval)
4516 (inc_interval_count, count_intervals, root_interval)
4517 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4518 * lread.c (defalias): Likewise.
268c2c36 4519 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4520 * regex.c (set_image_of_range_1, set_image_of_range)
4521 (regex_grow_registers): Likewise.
4522 * sysdep.c (strerror): Likewise.
4523 * termcap.c (valid_filename_p, tprint, main): Likewise.
4524 * tparam.c (main): Likewise.
4525 * unexhp9k800.c (run_time_remap, save_data_space)
4526 (update_file_ptrs, read_header, write_header, calculate_checksum)
4527 (copy_file, copy_rest, display_header): Likewise.
4528 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4529 Likewise.
4530 * xdisp.c (check_it): Likewise.
4531 * xfaces.c (register_color, unregister_color, unregister_colors):
4532 Likewise.
4533 * xfns.c (print_fontset_result): Likewise.
4534 * xrdb.c (member, fatal, main): Likewise.
4535
99033785
PE
45362011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4537
4538 Fix minor problems found by static checking (Bug#9031).
4539 * chartab.c (char_table_set_range, map_sub_char_table):
4540 Remove unused locals.
4541 (uniprop_table): Now static.
4542 * composite.c (_work_char): Remove unused static var.
4543
9cb2ac56
JB
45442011-07-09 Juanma Barranquero <lekktu@gmail.com>
4545
4546 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4547
f25661f0
JD
45482011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4549
4550 * gtkutil.c (qttip_cb): Remove code without function.
4551
8278c4fe
EZ
45522011-07-09 Eli Zaretskii <eliz@gnu.org>
4553
4554 * w32.c (pthread_sigmask): New stub.
4555
1692ae2d 45562011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4557
8a6ebd58 4558 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4559 sigprocmask is portable only for single-threaded applications, and
4560 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4561 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4562 (LIBES): Use it.
4563 * callproc.c (Fcall_process):
4564 * process.c (create_process):
4565 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4566 Use pthread_sigmask, not sigprocmask.
123403e4 4567
1b854618
JD
45682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4569
4570 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4571 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4572 wrong (Bug#8591).
4573
3fe4b549
JD
45742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4575
0ce7e563
JD
4576 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4577 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4578 (xg_hide_tooltip): Fix comment.
4579
3fe4b549
JD
4580 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4581 in registerServicesMenuSendTypes.
4582 (validRequestorForSendType): Don't check ns_return_types.
4583
4584 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4585 ns_return_type.
4586
5df75e47
JR
45872011-07-08 Jason Rumney <jasonr@gnu.org>
4588
22610910
JR
4589 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4590 SH_SHOW for hidden windows (Bug#5482).
4591
5df75e47
JR
4592 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4593 frame struct members of non-existent frames (Bug#6284).
4594
699c10bd
JD
45952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4596
4393663b
JD
4597 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4598 variable firstTime not needed on OSX >= 10.6.
4599 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4600 >= 10.5. Use setKnobProportion, setDoubleValue.
4601
4602 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4603 (MAC_OS_X_VERSION_10_5): Define if not defined.
4604 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4605 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4606 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4607
4608 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4609 cString and lossyCString on OSX >= 10.4
4610
58179cce 4611 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4612 sizeToFit on OSX >= 10.2.
4613
4614 * nsimage.m (allocInitFromFile): Don't use deprecated method
4615 bestRepresentationForDevice on OSX >= 10.6.
4616
4617 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4618 to avoid warning.
4619
4620 * emacs.c: Declare unexec_init_emacs_zone.
4621
a63e0781
JD
4622 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4623
699c10bd
JD
4624 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4625
4626 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4627 on svcsMenu (Bug#8842).
4628
4629 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4630 ns_return_types.
4631 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4632
4633 * nsterm.m (QUTF8_STRING): Declare.
4634 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4635 (validRequestorForSendType): Return type is (id).
4636 Change indexOfObjectIdenticalTo to indexOfObject.
4637 Check if we have local selection before returning self (Bug#8842).
4638 (writeSelectionToPasteboard): Put local selection into paste board
4639 if we have a local selection (Bug#8842).
4640 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4641
4642 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4643 (ns_get_local_selection): Declare.
4644
54e10184
LMI
46452011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4646
9888ff71
LMI
4647 * keymap.c (describe_map_tree): Don't insert a double newline at
4648 the end of the buffer (bug#1169) and return whether we inserted
4649 something.
4650
54e10184
LMI
4651 * callint.c (Fcall_interactively): Change "reading args" to
4652 "providing args" to try to clarify what it does (bug#1010).
4653
15fa4783
KH
46542011-07-07 Kenichi Handa <handa@m17n.org>
4655
4656 * composite.c (composition_compute_stop_pos): Ignore a static
4657 composition starting before CHARPOS (Bug#8915).
4658
4659 * xdisp.c (handle_composition_prop): Likewise.
4660
a8815b00
EZ
46612011-07-07 Eli Zaretskii <eliz@gnu.org>
4662
4663 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4664 (Bug#9015)
4665
ef7b981d 46662011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4667
4668 * character.h (unicode_category_t): New enum type.
4669
4670 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4671 (Qchar_code_property_table): New variable.
4672 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4673 (UNIPROP_COMPRESSED_FORM_P): New macros.
4674 (char_table_ascii): Uncompress the compressed values.
4675 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4676 Uncompress the compressed values.
ac389d0c 4677 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4678 (char_table_ref_and_range): Uncompress the compressed values.
4679 (sub_char_table_set): New arg is_uniprop. Callers changed.
4680 Uncompress the compressed values.
4681 (sub_char_table_set_range): Args changed. Callers changed.
4682 (char_table_set_range): Adjuted for the above change.
4683 (map_sub_char_table): Delete args default_val and parent. Add arg
4684 top. Give decoded values to a Lisp function.
640c8776 4685 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4686 values to a Lisp function. Gcpro more variables.
4687 (uniprop_table_uncompress)
4688 (uniprop_decode_value_run_length): New functions.
4689 (uniprop_decoder, uniprop_decoder_count): New variables.
4690 (uniprop_get_decoder, uniprop_encode_value_character)
4691 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4692 New functions.
4693 (uniprop_encoder, uniprop_encoder_count): New variables.
4694 (uniprop_get_encoder, uniprop_table)
4695 (Funicode_property_table_internal, Fget_unicode_property_internal)
4696 (Fput_unicode_property_internal): New functions.
4697 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4698 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4699 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4700 char-code-property-alist.
4701
640c8776 4702 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4703 Vunicode_category_table.
4704
640c8776 4705 * font.c (font_range): Adjust for the change of
c805dec0
KH
4706 Vunicode_category_table.
4707
76b397fb
DN
47082011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4709
4710 * m/iris4d.h: Remove file, move contents ...
4711 * s/irix6-5.h: ... here.
4712
22b4128e
PE
47132011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4714
4715 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4716 * alloc.c (mark_buffer):
4717 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4718 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4719 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4720 This isn't true in general, and it's particularly not true
4721 if Emacs is configured with --with-wide-int.
4722 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4723 New macros, used in the buffer.c change.
4724
869795d6
JD
47252011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4726
4727 * xsettings.c: Use both GConf and GSettings if both are available.
4728 (store_config_changed_event): Add comment.
4729 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4730 (store_tool_bar_style_changed): New functions.
5e617bc2 4731 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4732 (struct xsettings): Move font inside HAVE_XFT.
4733 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4734 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4735 Move inside HAVE_XFT.
640c8776 4736 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4737 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4738 also.
4739 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4740 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4741 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4742 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4743 (parse_settings): Move check for font inside HAVE_XFT.
4744 (read_settings, apply_xft_settings): Add comment.
4745 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4746 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4747 call store_font_name_changed.
4748 (xft_settings_event): Add comment.
4749 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4750 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4751 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4752 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4753 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4754 (xsettings_get_system_font, xsettings_get_system_normal_font):
4755 Add comment.
869795d6 4756
d8ed26bd
PE
47572011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4758
4759 Random fixes. E.g., (random) never returned negative values.
4760 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4761 subseconds part to the entropy, as that's a bit more random.
4762 Prefer signed to unsigned, since the signedness doesn't matter and
4763 in general we prefer signed. When given a limit, use a
4764 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4765 latter isn't right if USE_2_TAGS_FOR_INTS.
4766 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4767 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4768
cabf1cac
SM
47692011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4770
4771 * textprop.c (text_property_stickiness):
4772 Obey Vtext_property_default_nonsticky.
4773 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4774 * w32fns.c (syms_of_w32fns):
4775 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4776
6e9b2be9
PE
47772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4778
4779 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4780 This is more efficient than Ffile_directory_p and avoids a minor race.
4781
90186c68
LMI
47822011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4783
7c301272
LMI
4784 * buffer.c (Foverlay_put): Say what the return value is
4785 (bug#7835).
4786
c4f2d8d4
LMI
4787 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4788 is a directory before asking whether to use the file name
4789 (bug#7564).
ad637907
LMI
4790 (barf_or_query_if_file_exists): Make the "File is a directory"
4791 error be more correct.
c4f2d8d4 4792
90186c68
LMI
4793 * fns.c (Frequire): Remove the mention of the .gz files, since
4794 that's installation-specific, but keep the mention of
4795 `get-load-suffixes'.
4796
da64016e
PE
47972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4798
4799 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4800 Report string overflow if the output is too long.
4801
7d47b580
JB
48022011-07-04 Juanma Barranquero <lekktu@gmail.com>
4803
a555cb87
JB
4804 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4805 (syms_of_gnutls): Remove duplicate DEFSYM for
4806 Qgnutls_bootprop_verify_hostname_error, an error for
4807 Qgnutls_bootprop_verify_error (which is no longer used).
4808
7d47b580
JB
4809 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4810 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4811 Also (re)move comments that are misplaced or no longer relevant.
4812
1e49bfab
LMI
48132011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4814
4815 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4816
1485f4c0
CY
48172011-07-03 Chong Yidong <cyd@stupidchicken.com>
4818
4819 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4820 and background color parameters if they have been changed.
4821
a9ab721e
LMI
48222011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4823
4824 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4825
cf7cff57
PE
48262011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4827
2e13213d
PE
4828 * xsettings.c (SYSTEM_FONT): Define only when used.
4829 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4830
cf7cff57
PE
4831 * keymap.c (access_keymap_1): Now static.
4832
7a8e04f7
CY
48332011-07-02 Chong Yidong <cyd@stupidchicken.com>
4834
4835 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4836 leave any prefix arg for the up event (Bug#1586).
4837
61352f62
LMI
48382011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4839
69bb1ef7
LMI
4840 * lread.c (syms_of_lread): Mention single symbols defined by
4841 `defvar' or `defconst' (bug#7154).
4842
61352f62 4843 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4844 (Frequire): Mention get-load-suffixes.
61352f62 4845
28545e04
MR
48462011-07-02 Martin Rudalics <rudalics@gmx.at>
4847
4848 * window.h (window): Remove clone_number slot.
4849 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4850 Remove.
4851 (make_parent_window, make_window, saved_window)
4852 (Fset_window_configuration, save_window_save): Don't deal with
4853 clone numbers.
4854 * buffer.c (Qclone_number): Remove declaration.
4855 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4856
3349e122
SM
48572011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4858
4859 Add multiple inheritance to keymaps.
4860 * keymap.c (Fmake_composed_keymap): New function.
4861 (Fset_keymap_parent): Simplify.
4862 (fix_submap_inheritance): Remove.
4863 (access_keymap_1): New function extracted from access_keymap to handle
4864 embedded parents and handle lists of maps.
4865 (access_keymap): Use it.
4866 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4867 (Fcopy_keymap): Handle embedded parents.
4868 (Fcommand_remapping, define_as_prefix): Simplify.
4869 (Fkey_binding): Simplify.
4870 (syms_of_keymap): Move minibuffer-local-completion-map,
4871 minibuffer-local-filename-completion-map,
4872 minibuffer-local-must-match-map, and
4873 minibuffer-local-filename-must-match-map to Elisp.
4874 (syms_of_keymap): Defsubr make-composed-keymap.
4875 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4876 (parse_menu_item): Trivial simplification.
4877
3279eb87
GM
48782011-07-01 Glenn Morris <rgm@gnu.org>
4879
4880 * Makefile.in (SETTINGS_LIBS): Fix typo.
4881
4550efdf
KI
48822011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4883
4884 * coding.c (Fencode_coding_string): Record the last coding system
4885 used, as the function doc string says (bug#8738).
4886
0949d2b6
JD
48872011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4888
4889 * xsettings.c (store_monospaced_changed): Take new font as arg and
4890 check for change against current_mono_font.
4891 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4892 (emacs_settings_constructor, emacs_settings_get_property)
4893 (emacs_settings_set_property, emacs_settings_class_init)
4894 (emacs_settings_init, gsettings_obj): Remove.
4895 (something_changedCB): New function for HAVE_GSETTINGS.
4896 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4897 with value as argument.
4898 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4899 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4900 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4901 "changed".
4902
4903 * xgselect.c: Add defined (HAVE_GSETTINGS).
4904 (xgselect_initialize): Ditto.
4905
4906 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4907 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4908 xg_select.
4909
bbc6b304
PE
49102011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4911
4912 * eval.c (struct backtrace): Simplify and port the data structure.
4913 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4914 signed bit field, as this assumption is not portable and it makes
4915 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4916 "char debug_on_exit : 1" as this is not portable either; instead,
4917 use the portable "unsigned int debug_on_exit : 1". Remove unused
4918 member evalargs. Remove obsolete comments about cc bombing out.
4919
9851bfc5
JD
49202011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4921
51bb811f 4922 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4923 Let HAVE_GSETTINGS override HAVE_GCONF.
4924 (store_monospaced_changed): New function.
4925 (EMACS_SETTINGS): A new type derived from GObject to handle
4926 GSettings notifications.
4927 (emacs_settings_constructor, emacs_settings_get_property)
4928 (emacs_settings_set_property, emacs_settings_class_init):
4929 New functions.
4930 (gsettings_client, gsettings_obj): New variables.
4931 (GSETTINGS_SCHEMA): New define.
4932 (something_changedCB): Call store_monospaced_changed.
4933 (init_gsettings): New function.
4934 (xsettings_initialize): Call init_gsettings.
4935 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4936 to NULL.
4937
640c8776 4938 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4939 GCONF_CFLAGS/LIBS.
4940
5386012d
MR
49412011-06-29 Martin Rudalics <rudalics@gmx.at>
4942
4943 * window.c (resize_root_window, grow_mini_window)
4944 (shrink_mini_window): Rename Qresize_root_window to
4945 Qwindow_resize_root_window and Qresize_root_window_vertically to
4946 Qwindow_resize_root_window_vertically.
4947
f13e0b08
PE
49482011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4949
4950 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4951
94515237
JB
49522011-06-27 Juanma Barranquero <lekktu@gmail.com>
4953
4954 * makefile.w32-in: Redesign dependencies so they reflect more
4955 clearly which files are directly included by each source file,
4956 and not through other includes.
4957
e43b6e43
MR
49582011-06-27 Martin Rudalics <rudalics@gmx.at>
4959
4960 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4961 (sort_overlays, overlay_strings): When an overlay's clone number
4962 matches the window's clone number process the overlay even if
4963 the overlay's window property doesn't match the current window.
4964
d68443dc
MR
4965 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4966 (Fwindow_hchild): Rename to Fwindow_left_child.
4967 (Fwindow_next): Rename to Fwindow_next_sibling.
4968 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4969 (resize_window_check): Rename to window_resize_check.
4970 (resize_window_apply): Rename to window_resize_apply.
4971 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4972 (Fdelete_other_windows_internal, resize_frame_windows)
4973 (Fsplit_window_internal, Fdelete_window_internal)
4974 (grow_mini_window, shrink_mini_window)
4975 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4976
c7e73be5
JD
49772011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4978
4979 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4980 (emacs_fixed_set_min_size): Remove.
4981 (emacs_fixed_new): Take frame as argument.
4982
4983 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4984 (_EmacsFixedPrivate): Remove minwidth/height.
4985 Add struct frame *f.
4986 (emacs_fixed_init): Initialize priv->f.
4987 (get_parent_class, emacs_fixed_set_min_size): Remove.
4988 (emacs_fixed_new): Set priv->f to argument.
4989 (emacs_fixed_get_preferred_width)
4990 (emacs_fixed_get_preferred_height): Use min_width/height from
4991 frames size_hint to set minimum and natural (Bug#8919).
4992 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4993 and use min_width/height from frames size_hint to set
4994 min_width/height (Bug#8919).
4995
4996 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4997 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4998 Fix indentation.
c7e73be5 4999
cf99dcf8
EZ
50002011-06-26 Eli Zaretskii <eliz@gnu.org>
5001
5002 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5003 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5004 called at ZV.
5005
029529ac
CY
50062011-06-26 Chong Yidong <cyd@stupidchicken.com>
5007
5008 * process.c (wait_reading_process_output): Bypass select if
5009 waiting for a cell while ignoring keyboard input, and input is
5010 pending. Suggested by Jan Djärv (Bug#8869).
5011
7a7ef429
PE
50122011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5013
5014 Use gnulib's dup2 module instead of rolling our own.
5015 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5016
11fdef7d 50172011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5018
5019 * dispnew.c (scrolling_window): Before scrolling, turn off a
5020 mouse-highlight in the window being scrolled.
5021
cd3520a4
JB
50222011-06-24 Juanma Barranquero <lekktu@gmail.com>
5023
5024 Move DEFSYM to lisp.h and use everywhere.
5025
5026 * character.h (DEFSYM): Move declaration...
5027 * lisp.h (DEFSYM): ...here.
5028
5029 * gnutls.c:
5030 * minibuf.c:
5031 * w32menu.c:
5032 * w32proc.c:
5033 * w32select.c: Don't include character.h.
5034
5035 * alloc.c (syms_of_alloc):
5036 * buffer.c (syms_of_buffer):
5037 * bytecode.c (syms_of_bytecode):
5038 * callint.c (syms_of_callint):
5039 * casefiddle.c (syms_of_casefiddle):
5040 * casetab.c (init_casetab_once):
5041 * category.c (init_category_once, syms_of_category):
5042 * ccl.c (syms_of_ccl):
5043 * cmds.c (syms_of_cmds):
5044 * composite.c (syms_of_composite):
5045 * dbusbind.c (syms_of_dbusbind):
5046 * dired.c (syms_of_dired):
5047 * dispnew.c (syms_of_display):
5048 * doc.c (syms_of_doc):
5049 * editfns.c (syms_of_editfns):
5050 * emacs.c (syms_of_emacs):
5051 * eval.c (syms_of_eval):
5052 * fileio.c (syms_of_fileio):
5053 * fns.c (syms_of_fns):
5054 * frame.c (syms_of_frame):
5055 * fringe.c (syms_of_fringe):
5056 * insdel.c (syms_of_insdel):
5057 * keymap.c (syms_of_keymap):
5058 * lread.c (init_obarray, syms_of_lread):
5059 * macros.c (syms_of_macros):
5060 * msdos.c (syms_of_msdos):
5061 * print.c (syms_of_print):
5062 * process.c (syms_of_process):
5063 * search.c (syms_of_search):
5064 * sound.c (syms_of_sound):
5065 * syntax.c (init_syntax_once, syms_of_syntax):
5066 * terminal.c (syms_of_terminal):
5067 * textprop.c (syms_of_textprop):
5068 * undo.c (syms_of_undo):
5069 * w32.c (globals_of_w32):
5070 * window.c (syms_of_window):
5071 * xdisp.c (syms_of_xdisp):
5072 * xfaces.c (syms_of_xfaces):
5073 * xfns.c (syms_of_xfns):
5074 * xmenu.c (syms_of_xmenu):
5075 * xsettings.c (syms_of_xsettings):
5076 * xterm.c (syms_of_xterm): Use DEFSYM.
5077
4228cf16
TZ
50782011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5079
cd3520a4 5080 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5081
7fcccf1e
PE
50822011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5083
7efb4e0e
PE
5084 Integer and buffer overflow fixes (Bug#8873).
5085
ff5844ad
PE
5086 * print.c (printchar, strout): Check for string overflow.
5087 (PRINTPREPARE, printchar, strout):
5088 Don't set size unless allocation succeeds.
5089
90532f02
PE
5090 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5091 for sizes. Check for string overflow more accurately.
5092 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5093
6d84508d
PE
5094 * macros.c: Integer and buffer overflow fixes.
5095 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5096 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5097 Use ptrdiff_t, not int, for sizes.
5098 Don't increment bufsize until after realloc succeeds.
5099 Check for size-calculation overflow.
5100 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5101
437b2cb4
PE
5102 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5103
8b9ac8b4
PE
5104 * lread.c: Integer overflow fixes.
5105 (read_integer): Radix is now EMACS_INT, not int,
5106 to improve quality of diagnostics for out-of-range radices.
5107 Calculate buffer size correctly for out-of-range radices.
5108 (read1): Check for integer overflow in radices, and in
5109 read-circle numbers.
82cb60d3
PE
5110 (read_escape): Avoid int overflow.
5111 (Fload, openp, read_buffer_size, read1)
5112 (substitute_object_recurse, read_vector, read_list, map_obarray):
5113 Use ptrdiff_t, not int, for sizes.
5114 (read1): Use EMACS_INT, not int, for sizes.
20270765 5115 Check for size overflow.
8b9ac8b4 5116
7fcccf1e
PE
5117 * image.c (cache_image): Check for size arithmetic overflow.
5118
bfbbd7e7
PE
5119 * lread.c: Integer overflow issues.
5120 (saved_doc_string_size, saved_doc_string_length)
5121 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5122 Now ptrdiff_t, not int.
5123 (read1): Don't assume doc string length fits in int. Check for
5124 out-of-range doc string lengths.
5125 (read_list): Don't assume file position fits in int.
39019e54 5126 (read_escape): Check for hex character overflow.
bfbbd7e7 5127
4e323265
LL
51282011-06-22 Leo Liu <sdl.web@gmail.com>
5129
5130 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5131 Move to minibuffer.el.
5132
85fece3e
PE
51332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5134
20b84ce9 5135 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5136 The following patches are for when GLYPH_DEBUG && !XASSERT.
5137 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5138 * dispnew.c (flush_stdout):
5139 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5140 Mark as externally visible.
5141 * dispnew.c (check_window_matrix_pointers): Now static.
5142 * dispnew.c (window_to_frame_vpos):
5143 * xfns.c (unwind_create_frame):
5144 * xterm.c (x_check_font): Remove unused local.
5145 * scroll.c (CHECK_BOUNDS):
5146 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5147 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5148 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5149 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5150 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5151 Now static.
5152 (debug_method_add): Use va_list and vsprintf rather than relying
5153 on undefined behavior with wrong number of arguments.
5154 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5155 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5156 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5157 since we're not interested in debugging glyphs with old libraries.
5158 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5159 GCC 4.6.0's static checking.
5160
0766b489
PE
51612011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5162
31fd4b32
PE
5163 Integer overflow and signedness fixes (Bug#8873).
5164 A few related buffer overrun fixes, too.
5165
b79e8648
PE
5166 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5167
0766b489
PE
5168 * dispextern.h (struct face.stipple):
5169 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5170 (x_bitmap_mask, x_allocate_bitmap_record)
5171 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5172 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5173 (x_create_bitmap_from_xpm_data):
5174 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5175 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5176 (.bitmaps_last):
5177 * xfaces.c (load_pixmap):
5178 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5179 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5180 (.bitmaps_last, struct x_output.icon_bitmap):
5181 Use ptrdiff_t, not int, for bitmap indexes.
5182 (x_allocate_bitmap_record): Check for size overflow.
5183 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5184
b081724f
PE
5185 Use ptrdiff_t, not int, for overlay counts.
5186 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5187 * editfns.c (overlays_around, get_pos_property):
5188 * textprop.c (get_char_property_and_overlay):
5189 * xdisp.c (next_overlay_change, note_mouse_highlight):
5190 * xfaces.c (face_at_buffer_position):
21514da7
PE
5191 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5192 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5193 (Fnext_overlay_change, Fprevious_overlay_change)
5194 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5195 Use ptrdiff_t, not int, for sizes.
21514da7 5196 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5197
3de73e5e
PE
5198 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5199
2606c57b
PE
5200 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5201 (x_session_initialize): Do not assume string length fits in int.
5202
aaafe47a
PE
5203 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5204 This is unlikely, but can occur if DPI is outlandish.
5205
2674ddc8 5206 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5207 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5208
28154962
PE
5209 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5210 * xrdb.c (magic_file_p, search_magic_path):
5211 Omit last arg SUFFIX; it was always 0. All callers changed.
5212 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5213
7de51af5
PE
5214 * xfont.c (xfont_match): Avoid need for strlen.
5215
25ed6cc3
PE
5216 * xfns.c: Don't assume strlen fits in int.
5217 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5218
4eab31dd
PE
5219 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5220 not unsigned long, as we prefer signed integers. All callers changed.
5221 Detect integer overflow in repeat count.
5222 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5223 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5224
171e2a58
PE
5225 * termcap.c: Don't assume sizes fit in int and never overflow.
5226 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5227 (gobble_line): Check for size-calculation overflow.
5228
ad39faca 5229 * minibuf.c (Fread_buffer):
6e5bb2dc 5230 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5231 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5232 Don't assume string length fits in int.
5233
52c61c22 5234 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5235 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5236
b5b8c9e5
PE
5237 * font.c: Don't assume string length fits in int.
5238 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5239 Use ptrdiff_t, not int.
ccd6111c
PE
5240 (font_intern_prop): Don't assume string length fits in int.
5241 Don't assume integer property fits in fixnum.
5242 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5243
882f0d81 5244 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5245 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5246 Reformulate so as not to need the command string.
5247 Invoke gzip -cd rather than gunzip, as it's more portable.
5248 (lock_info_type, lock_file_1, lock_file):
5249 Don't assume pid_t and time_t fit in unsigned long.
5250 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5251 (current_lock_owner): Prefer signed type for sizes.
5252 Use memcpy, not strncpy, where memcpy is what is really wanted.
5253 Don't assume (via atoi) that time_t and pid_t fit in int.
5254 Check for time_t and/or pid_t out of range, e.g., via a network share.
5255 Don't alloca where an auto var works fine.
5256
93f4cf88
PE
5257 * fileio.c: Fix some integer overflow issues.
5258 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5259 Don't assume string length fits in int.
5260 (directory_file_name): Don't assume string length fits in long.
5261 (make_temp_name): Don't assume pid fits in int, or that its print
5262 length is less than 20.
5263
f3e92b69
PE
5264 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5265
1bfdaf10
PE
5266 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5267
35016e9a
PE
5268 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5269
3d1e65a1
PE
5270 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5271 We prefer signed integers, even for size calculations.
5272
0b963a93
PE
5273 * emacs.c: Don't assume string length fits in 'int'.
5274 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5275 (main): Don't invoke strlen when not needed.
5276
573f4b54
PE
5277 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5278 (XD_DEBUG_MESSAGE): Don't waste a byte.
5279
989f33ba
PE
5280 * callproc.c (getenv_internal_1, getenv_internal)
5281 (Fgetenv_internal):
965d34eb
PE
5282 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5283
e4d29b33
PE
5284 * lread.c (invalid_syntax): Omit length argument.
5285 All uses changed. This doesn't fix a bug, but it simplifies the
5286 code away from its former Hollerith-constant appearance, and it's
5287 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5288 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5289
eb49b136
PE
5290 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5291 This didn't break anything, but it didn't help either.
5292 It's confusing to put a bogus integer in a place where the actual
5293 value does not matter.
9f62aeb1 5294 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5295 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5296
15375a22
PE
5297 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5298 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5299 implementation.
b61cc01c
PE
5300 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5301 We prefer signed types, and the value cannot exceed the EMACS_INT
5302 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5303 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5304 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5305 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5306
53b2623d
PE
5307 * indent.c (sane_tab_width): New function.
5308 (current_column, scan_for_column, Findent_to, position_indentation)
5309 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5310 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5311
51cab52b 5312 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5313
f2ed8a70
PE
5314 * lisp.h (lint_assume): New macro.
5315 * composite.c (composition_gstring_put_cache):
5316 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5317
abe80cc6
PE
5318 * editfns.c, insdel.c:
5319 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5320
b02c740e
PE
5321 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5322
ebc96716
PE
5323 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5324
b4e50fa0 5325 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5326 Use much-faster test for byte-length change.
311d5d7c 5327 Don't assume string byte-length fits in 'int'.
a4cf38e4 5328 Check that character arg fits in 'int'.
85461888 5329 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5330
c0c1ee9f
PE
5331 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5332
a498d7f4
PE
5333 * fns.c (concat): Catch string overflow earlier.
5334 Do not rely on integer wraparound.
5335
51cab52b
PE
5336 * dispextern.h (struct it.overlay_strings_charpos)
5337 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5338 * xdisp.c (forward_to_next_line_start)
5339 (back_to_previous_visible_line_start)
5340 (reseat_at_next_visible_line_start, next_element_from_buffer):
5341 Don't arbitrarily truncate the value of 'selective' to int.
5342
76031fad
PE
5343 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5344
5eb55db9
PE
5345 * composite.c: Don't truncate sizes to 'int'.
5346 (composition_gstring_p, composition_reseat_it)
5347 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5348 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5349 not EMACS_UINT, for indexes.
5eb55db9 5350
0703a717
PE
5351 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5352
d6202519
PE
5353 * buffer.c: Include <verify.h>.
5354 (struct sortvec.priority, struct sortstr.priority):
8961a454 5355 Now EMACS_INT, not int.
c20998a7 5356 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5357 (struct sortstr.size, record_overlay_string)
5358 (struct sortstrlist.size, struct sortlist.used):
5359 Don't truncate size to int.
5360 (record_overlay_string): Check for size-calculation overflow.
d6202519 5361 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5362
d5a19415
JM
53632011-06-22 Jim Meyering <meyering@redhat.com>
5364
029529ac 5365 Don't leak an XBM-image-sized buffer
d5a19415
JM
5366 * image.c (xbm_load): Free the image buffer after using it.
5367
a9041e6c
PE
53682011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5369
5370 Port to Sun C.
5371 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5372 that Sun C diagnosed.
5373 * fns.c (secure_hash): Fix pointer signedness issue.
5374 * intervals.c (static_offset_intervals): New function.
5375 (offset_intervals): Use it.
5376
7f3f739f
LL
53772011-06-21 Leo Liu <sdl.web@gmail.com>
5378
5379 * deps.mk (fns.o):
5380 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5381 sha512.h.
5382
5383 * fns.c (secure_hash): Rename from crypto_hash_function and change
5384 the first arg to accept symbols.
5b66d427 5385 (Fsecure_hash): New primitive.
7f3f739f
LL
5386 (syms_of_fns): New symbols.
5387
76147d94
DD
53882011-06-20 Deniz Dogan <deniz@dogan.se>
5389
5390 * process.c (Fset_process_buffer): Clarify return value in
5391 docstring.
5392
7d7d0045
CY
53932011-06-18 Chong Yidong <cyd@stupidchicken.com>
5394
5395 * dispnew.c (add_window_display_history): Use BVAR.
5396
5397 * xdisp.c (debug_method_add): Use BVAR.
5398 (check_window_end, dump_glyph_matrix, dump_glyph)
5399 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5400
5401 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5402 Likewise.
5403
5404 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5405 check till after the cache is created in init_frame_faces.
5406
ff2bc410
SM
54072011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5408
5409 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5410
28177add
PE
54112011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5412
dd3482fe
PE
5413 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5414 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5415 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5416
393d71f3 5417 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5418 * fileio.c (Finsert_file_contents):
5419 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5420 Remove the old (too-loose) buffer overflow checks.
5421 They weren't needed, since make_gap checks for buffer overflow.
5422 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5423 The old code merely checked for Emacs fixnum overflow, and relied
5424 on undefined (wraparound) behavior. The new code avoids undefined
5425 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5426
2e6813b0 5427 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5428 Tune. Don't use wider integers than needed. Don't use alloca.
5429 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5430
599a9e4f
PE
5431 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5432
99561444
PE
5433 * insdel.c, lisp.h (buffer_overflow): New function.
5434 (insert_from_buffer_1, replace_range, replace_range_2):
5435 * insdel.c (make_gap_larger):
5436 * editfns.c (Finsert_char):
5437 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5438
28177add
PE
5439 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5440
e69dafad
PE
54412011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5442
4baa020d 5443 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5444
b1c46f02
PE
5445 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5446 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5447
e69dafad
PE
5448 * fileio.c: Don't assume EMACS_INT fits in off_t.
5449 (emacs_lseek): New static function.
5450 (Finsert_file_contents, Fwrite_region): Use it.
5451 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5452
566684ea
PE
5453 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5454
e6966cd6
PE
5455 * fns.c: Don't overflow int when computing a list length.
5456 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5457 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5458 truncation on 64-bit hosts. Check for QUIT every
5459 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5460 faster and is responsive enough.
5461 (Flength): Report an error instead of overflowing an integer.
5462 (Fsafe_length): Return a float if the value is not representable
5463 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5464 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5465 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5466
dd0b0efb
PE
5467 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5468 (header_size, word_size): New constants.
5469 (allocate_vectorlike): Don't check size overflow here.
5470 (allocate_vector): Check it here instead, since this is the only
5471 caller of allocate_vectorlike that could cause overflow.
5472 Check that the new vector's length is representable as a fixnum.
5473
86fe5cfe
PE
5474 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5475 The previous code was bogus. For example, next_almost_prime (32)
5476 returned 39, which is undesirable as it is a multiple of 3; and
5477 next_almost_prime (24) returned 25, which is a multiple of 5 so
5478 why was the code bothering to check for multiples of 7?
5479
80e88859
PE
5480 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5481
4a2f0ad6
PE
5482 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5483
f66c7cf8
PE
5484 Variadic C functions now count arguments with ptrdiff_t.
5485 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5486 Back then I didn't know that the Emacs coding style prefers signed int.
5487 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5488 were being counted with int, which may truncate counts on 64-bit
5489 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5490 * lisp.h (struct Lisp_Subr.function.aMANY)
5491 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5492 Arg counts are now ptrdiff_t, not size_t.
5493 All variadic functions and their callers changed accordingly.
5494 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5495 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5496 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5497 * callint.c (Fcall_interactively): Check arg count for overflow,
5498 to avoid potential buffer overrun. Use signed char, not 'int',
5499 for 'varies' array, so that we needn't bother to check its size
5500 calculation for overflow.
5501 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5502 * eval.c (apply_lambda):
5503 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5504 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5505 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5506
a1759b76
PE
5507 * callint.c (Fcall_interactively): Don't use index var as event count.
5508
d96be9fc
PE
5509 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5510 * mem-limits.h (SIZE): Remove; no longer used.
5511
a690a978 5512 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5513
578c21e6
PE
5514 Remove unnecessary casts.
5515 * xterm.c (x_term_init):
5516 * xfns.c (x_set_border_pixel):
5517 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5518 These aren't needed now that we assume ANSI C.
5519
96f53c6c
PE
5520 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5521 It's more likely to cause problems (due to unsigned overflow)
5522 than to cure them.
5523
83c77d31
PE
5524 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5525
ee2079f1
PE
5526 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5527
6da65536
PE
5528 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5529
7147c4a4
PE
5530 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5531
193e32d9
PE
5532 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5533
e5533da6
PE
5534 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5535
9910e595
PE
5536 GLYPH_CODE_FACE returns EMACS_INT, not int.
5537 * dispextern.h (merge_faces):
5538 * xfaces.c (merge_faces):
01103c44
PE
5539 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5540 Don't assume EMACS_INT fits in int.
9910e595 5541
2638320e
PE
5542 * character.h (CHAR_VALID_P): Remove unused parameter.
5543 * fontset.c, lisp.h, xdisp.c: All uses changed.
5544
045eb8d9
PE
5545 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5546
c1f134b5
PE
5547 * fns.c (concat): Minor tuning based on overflow analysis.
5548 This doesn't fix any bugs. Use int to hold character, instead
5549 of constantly refetching from Emacs object. Use XFASTINT, not
5550 XINT, for value known to be a character. Don't bother comparing
5551 a single byte to 0400, as it's always less.
5552
395fcb93 5553 * floatfns.c (Fexpt):
327eeec8
PE
5554 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5555
abbd3d23
PE
5556 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5557 for characters.
5558
684a03ef
PE
5559 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5560
0fed43f3
PE
5561 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5562 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5563 incorrectly succeed when S was a string, because 4294967386 was
5564 truncated before it was used.
5565
8fd02eb7
PE
5566 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5567 Otherwise, an out-of-range integer could cause undefined behavior
5568 on a 64-bit host.
5569
f8c86b69
PE
5570 * composite.c: Use int, not EMACS_INT, for characters.
5571 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5572 EMACS_INT, for values that are known to be in character range.
5573 This doesn't fix any bugs but is the usual style inside Emacs and
5574 may generate better code on 32-bit machines.
5575
34206dd2
PE
5576 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5577 This is for reasons similar to the recent CHAR_STRING fix.
5578 * charset.c (Fencode_char): Check that character arg is actually
5579 a character. Pass an int to ENCODE_CHAR.
5580 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5581 wider than 'int', as a compile-time check to prevent future regressions
5582 in this area.
5583
c5958d4c 5584 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5585
5586 Make sure a 64-bit char is never passed to CHAR_STRING.
5587 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5588 by silently ignoring the top 32 bits, allowing some values
5589 that were far too large to be valid characters.
5590 * character.h: Include <verify.h>.
5591 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5592 arguments are no wider than unsigned, as a compile-time check
5593 to prevent future regressions in this area.
5594 * data.c (Faset):
01103c44 5595 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5596 (Fsubst_char_in_region):
5597 * fns.c (concat):
5598 * xdisp.c (decode_mode_spec_coding):
5599 Adjust to CHAR_STRING's new requirement.
5600 * editfns.c (Finsert_char, Fsubst_char_in_region):
5601 * fns.c (concat): Check that character args are actually
5602 characters. Without this test, these functions did the wrong
5603 thing with wildly out-of-range values on 64-bit hosts.
5604
d37ca623
PE
5605 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5606 These casts should not be needed on 32-bit hosts, either.
5607 * keyboard.c (read_char):
5608 * lread.c (Fload): Remove casts to unsigned.
5609
ea204efb
PE
5610 * lisp.h (UNSIGNED_CMP): New macro.
5611 This fixes comparison bugs on 64-bit hosts.
5612 (ASCII_CHAR_P): Use it.
5613 * casefiddle.c (casify_object):
01103c44 5614 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5615 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5616 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5617 * dispextern.h (FACE_FROM_ID):
5618 * keyboard.c (read_char): Use UNSIGNED_CMP.
5619
41cb286c
PE
5620 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5621 not to EMACS_INT, to avoid GCC warning.
5622
4a1b9832
PE
5623 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5624
55daad71
PE
5625 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5626 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5627 isn't needed on 32-bit machines.
8f95c75c 5628
01103c44
PE
5629 * buffer.c (Fgenerate_new_buffer_name):
5630 Use EMACS_INT for count, not int.
0ceccced 5631 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5632
5633 * data.c (Qcompiled_function): Now static.
5634
c6f072e7
PE
5635 * window.c (window_body_lines): Now static.
5636
20ce5912
PE
5637 * image.c (gif_load): Rename local to avoid shadowing.
5638
9c4c5f81
PE
5639 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5640 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5641 * alloc.c (make_save_value): Integer argument is now of type
5642 ptrdiff_t, not int.
5643 (mark_object): Use ptrdiff_t, not int.
5644 * lisp.h (pD): New macro.
5645 * print.c (print_object): Use it.
5646
c0c5c8ae
PE
5647 * alloc.c: Use EMACS_INT, not int, to count objects.
5648 (total_conses, total_markers, total_symbols, total_vector_size)
5649 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5650 (total_free_floats, total_floats, total_free_intervals)
5651 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5652 Now EMACS_INT, not int. All uses changed.
5653 (Fgarbage_collect): Compute overall total using a double, so that
5654 integer overflow is less likely to be a problem. Check for overflow
5655 when converting back to an integer.
5a25e253
PE
5656 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5657 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5658 These were 'int' variables that could overflow on 64-bit hosts;
5659 they were never used, so remove them instead of repairing them.
211a0b2a 5660 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5661 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5662 Previously, this ceilinged at INT_MAX, but that doesn't work on
5663 64-bit machines.
e46bb31a 5664 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5665
c78baabf 5666 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5667 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5668 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5669 when a (possibly-narrower) signed value would do just as well.
5670 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5671
c9d624c6
PE
5672 * alloc.c: Catch some string size overflows that we were missing.
5673 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5674 for convenience in STRING_BYTES_MAX.
5675 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5676 The definition here is exact; the one in lisp.h was approximate.
5677 (allocate_string_data): Check for string overflow. This catches
5678 some instances we weren't catching before. Also, it catches
5679 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5680 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5681 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5682
c9d624c6
PE
5683 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5684 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5685 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5686
353032ce
PE
5687 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5688
2bccce07
PE
5689 * alloc.c (Fmake_string): Check for out-of-range init.
5690
0ac30604
SM
56912011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5692
5693 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5694
c195f2de
JD
56952011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5696
5697 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5698 xg_get_default_scrollbar_width.
5699
5700 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5701 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5702 (style_changed_cb): Call update_theme_scrollbar_width and call
5703 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5704 all frames (Bug#8505).
5705 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5706 Call gtk_window_set_resizable if HAVE_GTK3.
5707 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5708 and height if HAVE_GTK3 (Bug#8505).
5709 (scroll_bar_width_for_theme): New variable.
5710 (update_theme_scrollbar_width): New function.
5711 (xg_get_default_scrollbar_width): Move code to
5712 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5713 (xg_initialize): Call update_theme_scrollbar_width.
5714
5715 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5716
5717 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5718
e10ac9f1
MR
57192011-06-12 Martin Rudalics <rudalics@gmx.at>
5720
5721 * frame.c (make_frame): Call other_buffer_safely instead of
5722 other_buffer.
5723
5724 * window.c (temp_output_buffer_show): Call display_buffer with
5725 second argument Vtemp_buffer_show_specifiers and reset latter
5726 immediately after the call.
5727 (Vtemp_buffer_show_specifiers): New variable.
5728 (auto_window_vscroll_p, next_screen_context_lines)
5729 (Vscroll_preserve_screen_position): Remove leading asterisks from
5730 doc-strings.
5731
2d3c217e 57322011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5733
7b7f97e8 5734 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5735 * buffer.c (Qclone_number): Remove for now, as it's unused.
5736 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5737 (record_buffer): Remove unused local.
5738 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5739 (set_frame_buffer_list): Remove; unused.
5740 * frame.h (other_visible_frames): Remove decl.
5741 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5742 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5743 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5744 if HAVE_GPM.
5745 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5746 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5747 Define only if HAVE_GPM.
5748 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5749 (update_hints_inhibit): Remove; never set. All uses removed.
5750 * widgetprv.h (emacsFrameClassRec): Remove decl.
5751 * window.c (delete_deletable_window): Now returns void, since it
5752 wasn't returning anything.
5753 (compare_window_configurations): Remove unused locals.
5754 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5755 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5756 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5757 the same widths as pointers. This follows up on the 2011-05-06 patch.
5758 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5759 * xterm.h: Likewise.
5760 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5761
1384b89e
JB
57622011-06-12 Juanma Barranquero <lekktu@gmail.com>
5763
5764 * makefile.w32-in: Update dependencies.
5765 (LISP_H): Add lib/intprops.h.
5766
1100a63c
CY
57672011-06-11 Chong Yidong <cyd@stupidchicken.com>
5768
5769 * image.c (gif_load): Add animation frame delay to the metadata.
5770 (syms_of_image): Use DEFSYM. New symbol `delay'.
5771
6198ccd0
MR
57722011-06-11 Martin Rudalics <rudalics@gmx.at>
5773
5774 * window.c (delete_deletable_window): Re-add.
5775 (Fset_window_configuration): Rewrite to handle dead buffers and
5776 consequently deletable windows.
5777 (window_tree, Fwindow_tree): Remove. Supply functionality in
5778 window.el.
5779 (compare_window_configurations): Simplify code.
5780
b6e3633c
AS
57812011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5782
1ab0dee5
AS
5783 * image.c (imagemagick_load_image): Fix type mismatch.
5784 (Fimagemagick_types): Likewise.
5785
b6e3633c
AS
5786 * window.h (replace_buffer_in_windows): Declare.
5787
9397e56f
MR
57882011-06-11 Martin Rudalics <rudalics@gmx.at>
5789
5790 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5791 Qclone_number. Remove external declaration of Qdelete_window.
5792 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5793 code.
640c8776
SM
5794 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5795 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5796 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5797 buffer list implementation.
5798 (other_buffer_safely): New function.
5799 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5800 calls to replace_buffer_in_windows and
5801 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5802 if allowed.
5803 (record_buffer): Inhibit quitting and rewrite using quittable
5804 functions. Run Qbuffer_list_update_hook if allowed.
5805 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5806 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5807 Move switch-to-buffer to window.el.
9397e56f
MR
5808 (bury-buffer): Move to window.el.
5809 (Vbuffer_list_update_hook): New variable.
5810
5811 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5812 section.
5813
5814 * window.h (resize_frame_windows): Move up in code.
5815 (Fwindow_frame): Remove EXFUN.
5816 (replace_buffer_in_all_windows): Remove prototype.
5817 (replace_buffer_in_windows_safely): Add prototype.
5818
5819 * window.c: Declare Qdelete_window static again. Move down
5820 declaration of select_count.
5821 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5822 (Fother_window): Move to window.el.
5823 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5824 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5825 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5826 window.el.
5827 (replace_buffer_in_windows): Implement by calling
5828 Qreplace_buffer_in_windows.
5829 (replace_buffer_in_all_windows): Remove with some functionality
5830 moved into replace_buffer_in_windows_safely.
5831 (replace_buffer_in_windows_safely): New function.
5832 (select_window_norecord, select_frame_norecord): Move in front
5833 of run_window_configuration_change_hook. Remove now obsolete
5834 declarations.
640c8776
SM
5835 (Fset_window_buffer): Rewrite doc-string.
5836 Call Qrecord_window_buffer.
9397e56f
MR
5837 (keys_of_window): Move binding for other-window to window.el.
5838
b50691aa
CY
58392011-06-11 Chong Yidong <cyd@stupidchicken.com>
5840
5841 * dispextern.h (struct image): Replace data member, whose int_val
5842 and ptr_val fields were not used by anything, with a single
5843 lisp_val object.
5844
5845 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5846 (gif_clear_image, gif_load, imagemagick_load_image)
5847 (gs_clear_image, gs_load): Callers changed.
5848
3f754b86
PE
58492011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5850
cca69397
PE
5851 * buffer.h: Include <time.h>, for time_t.
5852 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5853
109e28d0
PE
5854 Fix minor problems found by static checking.
5855
60737f02
PE
5856 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5857
4b66faf3
PE
5858 Make identifiers static if they are not used in other modules.
5859 * data.c (Qcompiled_function, Qframe, Qvector):
5860 * image.c (QimageMagick, Qsvg):
5861 * minibuf.c (Qmetadata):
5862 * window.c (resize_window_check, resize_root_window): Now static.
5863 * window.h (resize_window_check, resize_root_window): Remove decls.
5864
109e28d0
PE
5865 * window.c (window_deletion_count, delete_deletable_window):
5866 Remove; unused.
46a4ce9e
PE
5867 (window_body_lines): Now static.
5868 (Fdelete_other_windows_internal): Mark vars as initialized.
5869 Make sure 'resize_failed' is initialized.
5870 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5871 (resize_window_apply): Remove unused local.
5872 * window.h (delete_deletable_window): Remove decl.
5873
109e28d0 5874 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5875 (imagemagick_load_image): Fix pointer signedness problem by changing
5876 last arg from unsigned char * to char *. All uses changed.
5877 Also, fix a local for similar reasons.
5878 Remove unused locals. Remove locals to avoid shadowing.
5879 (fn_rsvg_handle_free): Remove; unused.
5880 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5881 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5882
3f754b86
PE
5883 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5884
2547adb1
CY
58852011-06-10 Chong Yidong <cyd@stupidchicken.com>
5886
5887 * image.c (gif_load): Fix omitted cast error introduced by
5888 2011-06-06 change.
5889
2c8e37d4
MR
58902011-06-10 Martin Rudalics <rudalics@gmx.at>
5891
5892 * window.h (resize_proportionally, orig_total_lines)
5893 (orig_top_line): Remove from window structure.
5894 (set_window_height, set_window_width, change_window_heights)
5895 (Fdelete_window): Remove prototypes.
5896 (resize_frame_windows): Remove duplicate declaration.
5897
440a42e3
EZ
58982011-06-10 Eli Zaretskii <eliz@gnu.org>
5899
5900 * window.h (resize_frame_windows, resize_window_check)
5901 (delete_deletable_window, resize_root_window)
5902 (resize_frame_windows): Declare prototypes.
5903
5904 * window.c (resize_window_apply): Make definition be "static" to
5905 match the prototype.
5906
562dd5e9
MR
59072011-06-10 Martin Rudalics <rudalics@gmx.at>
5908
5909 * window.c: Remove declarations of Qwindow_size_fixed,
5910 window_min_size_1, window_min_size_2, window_min_size,
5911 size_window, window_fixed_size_p, enlarge_window, delete_window.
5912 Remove static from declaration of Qdelete_window, it's
5913 temporarily needed by Fbury_buffer.
5914 (replace_window): Don't assign orig_top_line and
5915 orig_total_lines.
5916 (Fdelete_window, delete_window): Remove. Window deletion is
5917 handled by window.el.
640c8776
SM
5918 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5919 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5920 (Fdelete_other_windows): Remove. Deleting other windows is
5921 handled by window.el.
5922 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5923 handled in window.el.
5924 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5925 Window minimum sizes are handled in window.el.
5926 (shrink_windows, size_window, set_window_height)
5927 (set_window_width, change_window_heights, window_height)
5928 (window_width, CURBEG, CURSIZE, enlarge_window)
5929 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5930 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5931 handled in window.el.
5932 (make_dummy_parent): Rename to make_parent_window and give it a
5933 second argument horflag.
5934 (make_window): Don't set resize_proportionally any more.
5935 (Fsplit_window): Remove. Windows are split in window.el.
5936 (save_restore_action, save_restore_orig_size)
5937 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5938 Resize mini windows in window.el.
5939 (grow_mini_window, shrink_mini_window): Implement by calling
5940 Qresize_root_window_vertically, resize_window_check and
5941 resize_window_apply.
640c8776
SM
5942 (saved_window, Fset_window_configuration, save_window_save):
5943 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5944 resize_proportionally.
5945 (window_min_height, window_min_width): Move to window.el.
5946 (keys_of_window): Move bindings for delete-other-windows,
5947 split-window, delete-window and enlarge-window to window.el.
5948
5949 * buffer.c: Temporarily extern Qdelete_window.
5950 (Fbury_buffer): Temporarily call Qdelete_window instead of
5951 Fdelete_window (Fbury_buffer will move to window.el soon).
5952
5953 * frame.c (set_menu_bar_lines_1): Remove code handling
5954 orig_top_line and orig_total_lines.
5955
5956 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5957 set_window_height but set heights directly.
5958 (change_frame_size_1): Use resize_frame_windows.
5959
5960 * xdisp.c (init_xdisp): Don't use set_window_height but set
5961 heights directly.
5962
640c8776
SM
5963 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5964 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5965 run_window_configuration_change_hook.
5966
5967 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5968 instead of change_window_heights and run
5969 run_window_configuration_change_hook.
5970
1a13852e
MR
59712011-06-09 Martin Rudalics <rudalics@gmx.at>
5972
5973 * window.c (replace_window): Rename second argument REPLACEMENT to
5974 NEW. New third argument SETFLAG. Rewrite.
5975 (delete_window, make_dummy_parent): Call replace_window with
5976 third argument 1.
5977 (window_list_1): Move down in code.
5978 (run_window_configuration_change_hook): Move set_buffer part
5979 before select_frame_norecord part in order to unwind correctly.
5980 Rename count1 to count.
5981 (recombine_windows, delete_deletable_window, resize_root_window)
5982 (Fdelete_other_windows_internal)
5983 (Frun_window_configuration_change_hook, make_parent_window)
5984 (resize_window_check, resize_window_apply, Fresize_window_apply)
5985 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5986 (Fdelete_window_internal, Fresize_mini_window_internal):
5987 New functions.
1a13852e
MR
5988 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5989
f3d1777e
MR
59902011-06-08 Martin Rudalics <rudalics@gmx.at>
5991
496e208e
MR
5992 * window.h (window): Add some new members to window structure -
5993 normal_lines, normal_cols, new_total, new_normal, clone_number,
5994 splits, nest, prev_buffers, next_buffers.
5995 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5996 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5997
f3d1777e
MR
5998 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5999 Remove.
496e208e
MR
6000 (make_dummy_parent): Set new members of windows structure.
6001 (make_window): Move down in code. Handle new members of window
6002 structure.
6003 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6004 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6005 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6006 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6007 (Fset_window_next_buffers, Fset_window_clone_number):
6008 New functions.
496e208e
MR
6009 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6010 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6011 Doc-string fixes.
6012 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6013 Argument WINDOW can be now internal window too.
6014 (Fwindow_use_time): Move up in code.
6015 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6016 Rewrite doc-string.
6017 (Fset_window_configuration, saved_window)
6018 (Fcurrent_window_configuration, save_window_save): Handle new
6019 members of window structure.
b9e809c2
MR
6020 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6021 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6022 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6023 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6024 Qget_mru_window, Qresize_root_window,
6025 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6026 Qauto_buffer_name; staticpro them.
f3d1777e 6027
abde8f8c
MR
60282011-06-07 Martin Rudalics <rudalics@gmx.at>
6029
6030 * window.c (Fwindow_total_size, Fwindow_left_column)
6031 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6032 (Fwindow_list_1): New functions.
6033 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6034 (Fwindow_width, Fscroll_left, Fscroll_right):
6035 Use window_body_cols instead of window_box_text_cols.
6036 (delete_window, Fset_window_configuration):
6037 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6038 (delete_all_subwindows): Take a window as argument and not a
6039 structure. Rewrite.
190b47e6
MR
6040 (window_loop): Remove handling of GET_LRU_WINDOW and
6041 GET_LARGEST_WINDOW.
6042 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6043
6044 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6045 window_box_text_cols. delete_all_subwindows now takes a
6046 Lisp_Object as argument.
abde8f8c 6047
640c8776
SM
6048 * indent.c (compute_motion, Fcompute_motion):
6049 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6050
fa8a67e6
MR
6051 * frame.c (delete_frame): Call delete_all_subwindows with root
6052 window as argument.
6053
a54e3482
DC
60542011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6055
6056 * fns.c (Fputhash): Document return value.
6057
60002bf5
CY
60582011-06-06 Chong Yidong <cyd@stupidchicken.com>
6059
6060 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6061
0c671da6 60622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6063
b862a52a 6064 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6065
be44ca6c
PE
6066 Check for overflow when converting integer to cons and back.
6067 * charset.c (Fdefine_charset_internal, Fdecode_char):
6068 Use cons_to_unsigned to catch overflow.
6069 (Fencode_char): Use INTEGER_TO_CONS.
6070 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6071 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6072 * data.c (long_to_cons, cons_to_long): Remove.
6073 (cons_to_unsigned, cons_to_signed): New functions.
6074 These signal an error for invalid or out-of-range values.
6075 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6076 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6077 * font.c (Ffont_variation_glyphs):
6078 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6079 * lisp.h: Include <intprops.h>.
6080 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6081 (cons_to_signed, cons_to_unsigned): New decls.
6082 (long_to_cons, cons_to_long): Remove decls.
6083 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6084 (Fprimitive_undo): Use CONS_TO_INTEGER.
6085 * xfns.c (Fx_window_property): Likewise.
6086 * xselect.c: Include <limits.h>.
6087 (x_own_selection, selection_data_to_lisp_data):
6088 Use INTEGER_TO_CONS.
6089 (x_handle_selection_request, x_handle_selection_clear)
6090 (x_get_foreign_selection, Fx_disown_selection_internal)
6091 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6092 (lisp_data_to_selection_data): Use cons_to_unsigned.
6093 (x_fill_property_data): Use cons_to_signed.
6094 Report values out of range.
6095
d1f3d2af
PE
6096 Check for buffer and string overflow more precisely.
6097 * buffer.h (BUF_BYTES_MAX): New macro.
6098 * lisp.h (STRING_BYTES_MAX): New macro.
6099 * alloc.c (Fmake_string):
6100 * character.c (string_escape_byte8):
6101 * coding.c (coding_alloc_by_realloc):
6102 * doprnt.c (doprnt):
6103 * editfns.c (Fformat):
6104 * eval.c (verror):
6105 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6106 since they may not be the same number.
6107 * editfns.c (Finsert_char):
6108 * fileio.c (Finsert_file_contents):
6109 Likewise for BUF_BYTES_MAX.
6110
dd52fcea
PE
6111 * image.c: Use ptrdiff_t, not int, for sizes.
6112 (slurp_file): Switch from int to ptrdiff_t.
6113 All uses changed.
6114 (slurp_file): Check that file size fits in both size_t (for
6115 malloc) and ptrdiff_t (for sanity and safety).
6116
7f9bbdbb
PE
6117 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6118 if b->modtime has its maximal value.
6119
dfe18f82
PE
6120 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6121
84acfcf0
PE
6122 Don't assume time_t can fit into int.
6123 * buffer.h (struct buffer.modtime): Now time_t, not int.
6124 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6125 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6126
ccd9a01a
PE
6127 Minor fixes for signed vs unsigned integers.
6128 * character.h (MAYBE_UNIFY_CHAR):
6129 * charset.c (maybe_unify_char):
6130 * keyboard.c (read_char, reorder_modifiers):
6131 XINT -> XFASTINT, since the integer must be nonnegative.
6132 * ftfont.c (ftfont_spec_pattern):
6133 * keymap.c (access_keymap, silly_event_symbol_error):
6134 XUINT -> XFASTINT, since the integer must be nonnegative.
6135 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6136 since it makes no difference and we prefer signed.
6137 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6138 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6139 nonnegative.
6140
d6d100dd
SM
61412011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6142
6143 * window.h (Fwindow_frame): Declare.
6144
2b6148e4
PE
61452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6146
6147 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6148 (SPARE_MEMORY): Always define.
6149 (LARGE_REQUEST): Remove.
6150 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6151
f230ecc9
MR
61522011-06-06 Martin Rudalics <rudalics@gmx.at>
6153
727e958e
MR
6154 * lisp.h: Move EXFUNS for Fframe_root_window,
6155 Fframe_first_window and Fset_frame_selected_window to window.h.
6156
6157 * window.h: Move EXFUNS for Fframe_root_window,
6158 Fframe_first_window and Fset_frame_selected_window here from
6159 lisp.h.
6160
6161 * frame.c (Fwindow_frame, Fframe_first_window)
6162 (Fframe_root_window, Fframe_selected_window)
6163 (Fset_frame_selected_window): Move to window.c.
6164 (Factive_minibuffer_window): Move to minibuf.c.
6165 (Fother_visible_frames_p): New function.
6166
6167 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6168
f230ecc9
MR
6169 * window.c (decode_window, decode_any_window): Move up in code.
6170 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6171 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6172 (Fwindow_buffer): Move up and rewrite doc-string.
6173 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6174 (Fwindow_prev): New functions.
727e958e
MR
6175 (Fwindow_frame): Move here from frame.c. Accept any window as
6176 argument.
6177 (Fframe_root_window, Fframe_first_window)
6178 (Fframe_selected_window): Move here from frame.c. Accept frame
6179 or arbitrary window as argument. Update doc-strings.
6180 (Fminibuffer_window): Move up in code.
6181 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6182 (Fset_frame_selected_window): Move here from frame.c.
6183 Marginal rewrite.
727e958e
MR
6184 (Fselected_window, select_window, Fselect_window): Move up in
6185 code. Minor doc-string fixes.
f230ecc9 6186
4d09bcf6
PE
61872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6188
6189 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6190 Do not assume that spare memory exists; that assumption is valid
6191 only if SYSTEM_MALLOC.
6192 (LARGE_REQUEST): New macro, so that the issue of large requests
6193 is separated from the issue of spare memory.
6194
810928a2
AS
61952011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6196
172418ad
AS
6197 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6198 format. (Bug#8806)
6199
43f862f7
AS
6200 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6201
810928a2
AS
6202 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6203 before statements.
6204
a059fe24
JD
62052011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6206
6207 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6208
6209 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6210
6211 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6212 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6213
989bf368
JB
62142011-06-05 Juanma Barranquero <lekktu@gmail.com>
6215
6216 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6217
4b80f674
CY
62182011-06-04 Chong Yidong <cyd@stupidchicken.com>
6219
6220 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6221 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6222 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6223 New error handlers.
4b80f674
CY
6224 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6225 Obey Vx_select_enable_clipboard_manager. Catch errors in
6226 x_clipboard_manager_save (Bug#8779).
6227 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6228 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6229
99a33b77 62302011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6231
6232 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6233
99a33b77 62342011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6235
6236 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6237 in the current matrix if keep_current_p is non-zero.
6238
8264569d
EZ
62392011-06-04 Eli Zaretskii <eliz@gnu.org>
6240
6241 * bidi.c (bidi_level_of_next_char): Fix last change.
6242
57f97249
EZ
62432011-06-03 Eli Zaretskii <eliz@gnu.org>
6244
fec2107c 6245 Support bidi reordering of text covered by display properties.
57f97249 6246
fec2107c
EZ
6247 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6248 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6249 (bidi_cache_search, bidi_cache_iterator_state)
6250 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6251 (bidi_level_of_next_char, bidi_move_to_visually_next):
6252 Support character positions inside a run of characters covered by a
fec2107c
EZ
6253 display string.
6254 (bidi_paragraph_init, bidi_resolve_explicit_1)
6255 (bidi_level_of_next_char): Call bidi_fetch_char and
6256 bidi_fetch_char_advance instead of FETCH_CHAR and
6257 FETCH_CHAR_ADVANCE.
6258 (bidi_init_it): Initialize new members.
6259 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6260 definitions.
6261 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6262 instead of using explicit *_CHAR codes.
d6d100dd
SM
6263 (bidi_resolve_explicit, bidi_resolve_weak):
6264 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6265 bidirectional text is supported only in multibyte buffers.
6266 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6267 it to initialize the frame_window_p member of struct bidi_it.
6268 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6269 (bidi_resolve_explicit, bidi_resolve_weak)
6270 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6271 bidi_it->nchars is non-positive.
6272 (bidi_level_of_next_char): Don't try to lookup the cache for the
6273 next/previous character if nothing is cached there yet, or if we
6274 were just reseat()'ed to a new position.
c40e2fb2 6275
0e14fe90
EZ
6276 * xdisp.c (set_cursor_from_row): Set start and stop points
6277 according to the row's direction when priming the loop that looks
6278 for the glyph on which to display cursor.
6279 (single_display_spec_intangible_p): Function deleted.
6280 (display_prop_intangible_p): Reimplement to call
6281 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6282 Accept 3 additional arguments needed by handle_display_spec.
6283 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6284 values: lists, `(when COND...)' forms, etc.
6285 (single_display_spec_string_p): Support property values that are
6286 lists with the argument STRING its top-level element.
6287 (display_prop_string_p): Fix the condition for processing a
6288 property that is a list to be consistent with handle_display_spec.
fec2107c 6289 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6290 last portion of handle_display_prop.
6291 (compute_display_string_pos): Accept additional argument
6292 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6293 value of a `display' property is a "replacing spec".
6294 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6295 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6296 the display property, but just return a value indicating whether
6297 the display property will replace the characters it covers.
6298 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6299 frame_window_p members of struct bidi_it.
d6d100dd
SM
6300 (compute_display_string_pos, compute_display_string_end):
6301 New functions.
fec2107c
EZ
6302 (push_it): Accept second argument POSITION, where pop_it should
6303 jump to continue iteration.
6304 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6305
fec2107c
EZ
6306 * keyboard.c (adjust_point_for_property): Adjust the call to
6307 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6308
6309 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6310 (bidi_init_it): Update prototypes.
6311 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6312 (compute_display_string_pos, compute_display_string_end):
6313 Declare prototypes.
fec2107c
EZ
6314 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6315 EMACS_INT.
fc6f18ce 6316
40087514 63172011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6318
57f53182
PE
6319 Malloc failure behavior now depends on size of allocation.
6320 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6321 * lisp.h: Change signatures accordingly.
6322 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6323 All callers changed. (Bug#8762)
6324
6325 * gnutls.c: Use Emacs's memory allocators.
6326 Without this change, the gnutls library would invoke malloc etc.
6327 directly, which causes problems on non-SYNC_INPUT hosts, and which
6328 runs afoul of improving memory_full behavior. (Bug#8761)
6329 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6330 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6331 xfree instead of the default malloc, realloc, free.
6332 (Fgnutls_boot): No need to check for memory allocation failure,
6333 since xmalloc does that for us.
6334
ac32cd99 6335 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6336 * category.c (hash_get_category_set):
6337 * ccl.c (ccl_driver):
6338 * charset.c (Fdefine_charset_internal):
6339 * charset.h (struct charset.hash_index):
6340 * composite.c (get_composition_id, gstring_lookup_cache)
6341 (composition_gstring_put_cache):
6342 * composite.h (struct composition.hash_index):
6343 * dispextern.h (struct image.hash):
6344 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6345 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6346 (hashfn_equal, hashfn_user_defined, make_hash_table)
6347 (maybe_resize_hash_table, hash_lookup, hash_put)
6348 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6349 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6350 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6351 * image.c (make_image, search_image_cache, lookup_image)
6352 (xpm_put_color_table_h):
6353 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6354 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6355 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6356 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6357 * alloc.c (allocate_vectorlike):
6358 Check for overflow in vector size calculations.
6359 * ccl.c (ccl_driver):
6360 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6361 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6362 need to be updated by these changes.
40087514
PE
6363 * fns.c (make_hash_table, maybe_resize_hash_table):
6364 Check for integer overflow with large hash tables.
0de4bb68
PE
6365 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6366 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6367 (SXHASH_REDUCE): New macro.
6368 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6369 Use it instead of discarding useful hash info with large hash values.
6370 (sxhash_float): New function.
6371 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6372 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6373 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6374 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6375 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6376 Adjust signatures to match updated version of code.
6377 (consing_since_gc): Now EMACS_INT, since a single hash table can
6378 use more than INT_MAX bytes.
6379
698d32e2
DN
63802011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6381
6382 Make it possible to build with GCC-4.6+ -O2 -flto.
6383
6384 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6385
fd6fa53f
SM
63862011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6387
6388 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6389 Call minibuffer-inactive-mode.
6390
864db017
JB
63912011-05-31 Juanma Barranquero <lekktu@gmail.com>
6392
6393 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6394 Update dependencies.
6395
2ad0baf4
DN
63962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6397
6398 * data.c (init_data): Remove code for UTS, this system is not
6399 supported anymore.
6400
4fcc2638
DN
64012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6402
6403 Don't force ./temacs to start in terminal mode.
6404
6405 * frame.c (make_initial_frame): Initialize faces in all cases, not
6406 only when CANNOT_DUMP is defined.
6407 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6408
c56e0fd5
DN
64092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6410
6411 * dispnew.c (add_window_display_history): Use const for the string
6412 pointer. Remove declaration, not needed.
6413
333d54da 64142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6415
55d4c1b2 6416 Use 'inline', not 'INLINE'.
333d54da 6417 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6418 * alloc.c, fontset.c (INLINE): Remove.
6419 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6420 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6421 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6422 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6423 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6424
738db178
DN
64252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6426
6427 Make it possible to run ./temacs.
6428
6429 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6430 syms_of_callproc does the same thing. Remove test for
6431 "initialized", do it in the caller.
6432 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6433
620c53a6
SM
64342011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6435
6436 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6437 (read_minibuf): Use get_minibuffer.
6438 (syms_of_minibuf): Use DEFSYM.
6439 (Qmetadata): New var.
6440 * data.c (Qbuffer): Don't make it static.
6441 (syms_of_data): Use DEFSYM.
6442
e003a292
PE
64432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6444
6445 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6446 (CCL_CODE_MIN): New macro.
6447
ed008a6d
PE
64482011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6449
3687c2ef
PE
6450 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6451
ed008a6d
PE
6452 * eval.c (Qdebug): Now static.
6453 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6454 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6455 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6456
d66c4c7c
CY
64572011-05-29 Chong Yidong <cyd@stupidchicken.com>
6458
6459 * image.c: Various fixes to ImageMagick code comments.
6460 (Fimagemagick_types): Doc fix.
6461
5fbc2025
PE
64622011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6463
0196f88a
PE
6464 Minor fixes prompted by GCC 4.6.0 warnings.
6465
6466 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6467
5fbc2025
PE
6468 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6469 (x_clipboard_manager_save_all): Move extern decl to ...
6470 * xterm.h: ... here, so that it can be checked for consistency.
6471
1dd3c2d9
CY
64722011-05-29 Chong Yidong <cyd@stupidchicken.com>
6473
6474 * xselect.c (x_clipboard_manager_save_frame)
6475 (x_clipboard_manager_save_all): New functions.
6476 (Fx_clipboard_manager_save): Lisp function deleted.
6477
6478 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6479 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6480
6481 * xterm.h: Update prototype.
6482
5ba6571d
WX
64832011-05-28 William Xu <william.xwl@gmail.com>
6484
6485 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6486 exiting (Bug#8239).
6487
3eaff834
JM
64882011-05-28 Jim Meyering <meyering@redhat.com>
6489
e1900994 6490 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6491 * fns.c (to_uchar): Define.
6492 (crypto_hash_function): Use it to convert some newly-signed
6493 variables to unsigned, to avoid sign-extension bugs. For example,
6494 without this change, (md5 "truc") would evaluate to
6495 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6496 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6497 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6498
0f6990a7
PE
64992011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6500
6501 Integer overflow fixes.
c8a9ca5a 6502
08686060
PE
6503 * dbusbind.c: Serial number integer overflow fixes.
6504 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6505 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6506 to hold a serial number that is too large for a fixnum.
6507 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6508 Check for serial numbers out of range. Decode any serial number
59568bf0 6509 that was so large that it became a float. (Bug#8722)
08686060 6510
2d1fc3c7
PE
6511 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6512 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6513 Use XFASTINT rather than XUINT when numbers are nonnegative.
6514 (xd_append_arg, Fdbus_method_return_internal):
6515 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6516 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6517 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6518 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6519 (Bug#8722)
2d1fc3c7 6520
c8a9ca5a
PE
6521 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6522
519e1d69
PE
6523 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6524
6df6ae42 6525 ccl: Add integer overflow checks.
30569699
PE
6526 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6527 (IN_INT_RANGE): New macros.
6528 (ccl_driver): Use them to check for integer overflow when
6529 decoding a CCL program. Many of the new checks are whether XINT (x)
6530 fits in int; it doesn't always, on 64-bit hosts. The new version
6531 doesn't catch all possible integer overflows, but it's an
847044ea 6532 improvement. (Bug#8719)
30569699 6533
c11285dc
PE
6534 * alloc.c (make_event_array): Use XINT, not XUINT.
6535 There's no need for unsigned here.
6536
fdccd48e
PE
6537 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6538 This follows up to the 2011-05-06 change that substituted uintptr_t
6539 for EMACS_INT. This case wasn't caught back then.
6540
37910ab2
PE
6541 Rework Fformat to avoid integer overflow issues.
6542 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6543 now (part of C89). Include <verify.h>.
6544 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6545 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6546 (Fformat): Avoid the prepass trying to compute sizes; it was only
6547 approximate and thus did not catch overflow reliably. Instead, walk
6548 through the format just once, formatting and computing sizes as we go,
6549 checking for integer overflow at every step, and allocating a larger
6550 buffer as needed. Keep track separately whether the format is
6551 multibyte. Keep only the most-recently calculated precision, rather
6552 than them all. Record whether each argument has been converted to
6553 string. Use EMACS_INT, not int, for byte and char and arg counts.
6554 Support field widths and precisions larger than INT_MAX. Avoid
6555 sprintf's undefined behavior with conversion specifications such as %#d
6556 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6557 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6558 formatting out-of-range floating point numbers with int
9173deec 6559 formats. (Bug#8668)
37910ab2 6560
2e6578fb
PE
6561 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6562
0ae6bdee
PE
6563 * data.c: Avoid integer truncation in expressions involving floats.
6564 * data.c: Include <intprops.h>.
6565 (arith_driver): When there's an integer overflow in an expression
6566 involving floating point, convert the integers to floating point
6567 so that the resulting value does not suffer from catastrophic
6568 integer truncation. For example, on a 64-bit host (* 4
6569 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6570 Do not rely on undefined behavior after integer overflow.
6571
de883a70
PE
6572 merge count_size_as_multibyte, parse_str_to_multibyte
6573 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6574 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6575 Check for integer overflow.
6576 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6577 since it's now a duplicate of the other. This is more of
6578 a character than a buffer op, so better that it's in character.c.
6579 * fns.c, print.c: Adjust to above changes.
6580
2ff916cb
PE
65812011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6582
6583 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6584
f1b54466
PE
65852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6586
fb1ac845
PE
6587 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6588 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6589 (x_clipboard_manager_save): Now static.
6590 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6591
f1b54466
PE
6592 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6593 (crypto_hash_function): Now static.
6594 Fix pointer signedness problems. Avoid unnecessary initializations.
6595
a9f737ee
CY
65962011-05-27 Chong Yidong <cyd@stupidchicken.com>
6597
6598 * termhooks.h (Vselection_alist): Make it terminal-local.
6599
6600 * terminal.c (create_terminal): Initialize it.
6601
6602 * xselect.c: Support for clipboard managers.
6603 (Vselection_alist): Move to termhooks.h as terminal-local var.
6604 (LOCAL_SELECTION): New macro.
6605 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6606 (symbol_to_x_atom): Remove gratuitous arg.
6607 (x_handle_selection_request, lisp_data_to_selection_data)
6608 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6609 (x_own_selection, x_get_local_selection, x_convert_selection):
6610 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6611 (some_frame_on_display): Delete unused function.
6612 (Fx_own_selection_internal, Fx_get_selection_internal)
6613 (Fx_disown_selection_internal, Fx_selection_owner_p)
6614 (Fx_selection_exists_p): New optional frame arg.
6615 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6616 (x_handle_selection_clear): Don't treat other terminals with the
6617 same keyboard specially. Use the terminal-local Vselection_alist.
6618 (x_clear_frame_selections): Use Frun_hook_with_args.
6619
6620 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6621
6622 * xterm.h: Add support for those atoms.
6623
e067f0c1
CY
66242011-05-26 Chong Yidong <cyd@stupidchicken.com>
6625
6626 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6627 (converted_selections, conversion_fail_tag): New global variables.
6628 (x_selection_request_lisp_error): Free the above.
6629 (x_get_local_selection): Remove unnecessary code.
6630 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6631 of converted selections stored in converted_selections.
6632 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6633 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6634 (x_convert_selection): New function.
6635 (x_handle_selection_event): Simplify.
6636 (x_get_foreign_selection): Don't ignore incoming requests while
6637 waiting for an answer; this will fail when we implement
6638 SAVE_TARGETS, and seems unnecessary anyway.
6639 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6640 (Vx_sent_selection_functions): Doc fix.
6641
0f4aebc0
LL
66422011-05-26 Leo Liu <sdl.web@gmail.com>
6643
6644 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6645
e61124cd
YM
66462011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6647
6648 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6649
6650 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6651 for fringe update if it has periodic bitmap.
ac389d0c 6652 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6653 and fringe_bitmap_periodic_p.
6654
6655 * fringe.c (get_fringe_bitmap_data): New function.
6656 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6657 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6658 row. Mark glyph row for fringe update if periodicity changed.
6659
6660 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6661 for fringe update unless it has periodic bitmap.
6662
f16d9837
KH
66632011-05-25 Kenichi Handa <handa@m17n.org>
6664
6665 * xdisp.c (get_next_display_element): Set correct it->face_id for
6666 a static composition.
6667
e1b90ef6
LL
66682011-05-24 Leo Liu <sdl.web@gmail.com>
6669
6670 * deps.mk (fns.o):
6671 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6672
6673 * fns.c (crypto_hash_function, Fsha1): New function.
6674 (Fmd5): Use crypto_hash_function.
6675 (syms_of_fns): Add Ssha1.
6676
7400048f
PE
66772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6678
6679 * gnutls.c: Remove unused macros.
6680 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6681 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6682 Remove macros that are defined and never used.
6683 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6684
abb71cf4
CY
66852011-05-22 Chong Yidong <cyd@stupidchicken.com>
6686
6687 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6688 (Fx_get_selection_internal): Minor cleanup.
6689 (Fx_own_selection_internal): Rename arguments for consistency with
6690 select.el.
6691
6307db39
PE
66922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6693
6694 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6695
f3d4e0a4
CY
66962011-05-22 Chong Yidong <cyd@stupidchicken.com>
6697
6698 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6699
4d8ade89
YM
67002011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6701
6702 * dispnew.c (scrolling_window): Don't exclude the case that the
6703 last enabled row in the desired matrix touches the bottom boundary.
6704
32078c8d
GM
67052011-05-21 Glenn Morris <rgm@gnu.org>
6706
6707 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6708 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6709 and add some more files.
32078c8d 6710
7285dc67
EZ
67112011-05-20 Eli Zaretskii <eliz@gnu.org>
6712
6713 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6714 report_file_error introduced by the change from 2011-05-07.
6715
89d1bd22
PE
67162011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6717
6718 * systime.h (Time): Define only if emacs is defined.
6719 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6720 where the include path doesn't have X11/X.h by default. See
6721 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6722
cd394be1 67232011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6724
6725 * composite.c (find_automatic_composition): Fix previous change.
6726
b9704ad9
GM
67272011-05-20 Glenn Morris <rgm@gnu.org>
6728
6729 * lisp.mk: New file, split from Makefile.in.
6730 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6731 (shortlisp): Remove.
6732 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6733
4a720484
GM
67342011-05-19 Glenn Morris <rgm@gnu.org>
6735
6736 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6737 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6738 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6739 (lisp): Set the order to that of loadup.el.
6740 (shortlisp): Make it a copy of $lisp.
6741 (SOME_MACHINE_LISP): Remove.
6742 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6743 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6744
a28d4396
KH
67452011-05-18 Kenichi Handa <handa@m17n.org>
6746
6747 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6748 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6749 (find_automatic_composition): Mostly rewrite for efficiency.
6750
a2b1fa8e
JB
67512011-05-18 Juanma Barranquero <lekktu@gmail.com>
6752
6753 * makefile.w32-in: Update dependencies.
6754
8e1f5610
CS
67552011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6756
6757 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6758 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6759
7025ee00 67602011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6761
cdfa6eab
PE
6762 Fix some integer overflow issues, such as string length overflow.
6763
06d6db33
PE
6764 * insdel.c (count_size_as_multibyte): Check for string overflow.
6765
2b4560a8
PE
6766 * character.c (lisp_string_width): Check for string overflow.
6767 Use EMACS_INT, not int, for string indexes and lengths; in
6768 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6769 the resulting string length overflows an EMACS_INT; instead,
6770 report a string overflow if no precision given. When checking for
6771 precision exhaustion, use a check that cannot possibly have
6772 integer overflow. (Bug#8675)
6773 * character.h (lisp_string_width): Adjust to new signature.
6774
cb93f9be
PE
6775 * alloc.c (string_overflow): New function.
6776 (Fmake_string): Use it. This doesn't change behavior, but saves
6777 a few bytes and will simplify future changes.
6778 * character.c (string_escape_byte8): Likewise.
6779 * lisp.h (string_overflow): New decl.
6780
1a1f3366
PE
6781 Fixups, following up to the user-interface timestamp change.
6782 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6783 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6784 * msdos.c (mouse_get_pos): Likewise.
6785 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6786 * w32gui.h (Time): Define by including "systime.h" rather than by
6787 declaring it ourselves. (Bug#8664)
6788
d4e3e4d3
PE
6789 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6790 * image.c (clear_image_cache): Likewise.
6791
f6a24d19
PE
6792 * term.c (term_mouse_position): Don't assume time_t wraparound.
6793
08dc5ae6
PE
6794 Be more systematic about user-interface timestamps.
6795 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6796 and sometimes 'EMACS_UINT', to represent these timestamps.
6797 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6798 This makes the code easier to follow, and makes it easier to catch
6799 integer overflow bugs such as Bug#8664.
6800 * frame.c (Fmouse_position, Fmouse_pixel_position):
6801 Use Time, not unsigned long, for user-interface timestamps.
6802 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6803 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6804 * keyboard.h (last_event_timestamp): Likewise.
6805 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6806 * menu.h (xmenu_show): Likewise.
6807 * term.c (term_mouse_position): Likewise.
6808 * termhooks.h (struct input_event.timestamp): Likewise.
6809 (struct terminal.mouse_position_hook): Likewise.
6810 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6811 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6812 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6813 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6814 what it was before.
6815 * menu.h, termhooks.h: Include "systime.h", for Time.
6816
8e55734a
PE
6817 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6818 Don't assume that the difference between two unsigned long values
6819 can fit into an integer. At this point, we know button_down_time
6820 <= event->timestamp, so the difference must be nonnegative, so
6821 there's no need to cast the result if double-click-time is
6822 nonnegative, as it should be; check that it's nonnegative, just in
6823 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6824 apart (about 25 days). (Bug#8664)
8e55734a 6825
841f1b75 6826 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6827 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6828
3e26f69c
PE
6829 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6830 that always fit in int. Use a sentinel instead of a counter, to
6831 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6832 * frame.h (struct frame): Use int for menu_bar_items_used
6833 instead of EMACS_INT, since it always fits in int.
3e26f69c 6834
5cc152c0
PE
6835 * menu.c (grow_menu_items): Check for int overflow.
6836
d89eb65e
PE
6837 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6838
5235bd3e
PE
6839 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6840 Before, the code was not consistent. These values cannot exceed
6841 2**31 - 1 so there's no need to make them unsigned.
6842 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6843 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6844 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6845 as modifiers.
6846 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6847
bc827e23
PE
6848 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6849 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6850 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6851 presumably because the widths might not match.
6852
78eb494e
PE
6853 * window.c (size_window): Avoid needless test at loop start.
6854
04f2d78b
CB
68552011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6856
6857 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6858
d2fc7e3d 68592011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6860
6861 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6862
d2fc7e3d 68632011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6864
6865 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6866 `width' to `bar_area_x' and `bar_area_width', respectively.
6867 (x_scroll_run): Take account of fringe background extension.
6868
04f2d78b
CB
6869 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6870 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6871 `bar_area_width', respectively.
6872 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6873 background extension.
6874
79b70037
GM
68752011-05-10 Jim Meyering <meyering@redhat.com>
6876
6877 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6878
2f142cc5
JB
68792011-05-10 Juanma Barranquero <lekktu@gmail.com>
6880
6881 * image.c (Finit_image_library): Return t for built-in image types,
6882 like pbm and xbm. (Bug#8640)
6883
57679c86
AS
68842011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6885
6886 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6887
888c9e86
EZ
68882011-05-07 Eli Zaretskii <eliz@gnu.org>
6889
b0512a1d
EZ
6890 * w32console.c (Fset_screen_color): Doc fix.
6891 (Fget_screen_color): New function.
6892 (syms_of_ntterm): Defsubr it.
6893
7285dc67
EZ
6894 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6895 unlink the temporary file if Fcall_process didn't create it in the
6896 first place.
6897 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6898 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6899 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6900 cue to call_process_cleanup not to close that handle.
6901
4d3fcc8e
BK
69022011-05-07 Ben Key <bkey76@gmail.com>
6903
6904 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6905 one of two shell specific rules, either bootstrap-temacs-CMD or
6906 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6907 to the previous implementation of the bootstrap-temacs rule.
6908 The bootstrap-temacs-CMD rule is similar to the previous
6909 implementation of the bootstrap-temacs rule except that it
6910 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6911 variable.
6912
6913 These changes, along with some changes to nt/configure.bat,
6914 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6915 earlier fix to add support for --cflags and --ldflags options
6916 that include quotes so that it works whether make uses cmd or
6917 sh as the shell.
6918
b4289b64
MA
69192011-05-06 Michael Albinus <michael.albinus@gmx.de>
6920
6921 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6922 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6923 is a constant.
6924 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6925 a string. Handle both cases.
6926 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6927 (Fdbus_register_method): Use Qinvalid_function.
6928
af4c0e28
JB
69292011-05-06 Juanma Barranquero <lekktu@gmail.com>
6930
6931 * makefile.w32-in: Update dependencies.
6932 (LISP_H): Add inttypes.h and stdin.h.
6933 (PROCESS_H): Add unistd.h.
6934
c51453d9
EZ
69352011-05-06 Eli Zaretskii <eliz@gnu.org>
6936
6937 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6938 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6939
8ff0ac3c 69402011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6941
4c4b566b
PE
6942 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6943
aab2b9b5
PE
6944 * term.c (vfatal): Remove stray call to va_end.
6945 It's not needed and the C Standard doesn't allow it here anyway.
6946
c378da0b
PE
6947 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6948 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6949
288b08c7
PE
6950 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6951 bytes.
6952
e3601888
PE
6953 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6954
db6c0e74
PE
6955 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6956
dd5963ea
PE
6957 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6958
88c9450f
PE
6959 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6960
2f9442b8
PE
6961 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6962
c032b5f8
PE
6963 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6964 * charset.c (Fdefine_charset_internal): Don't initialize
6965 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6966 32-bit int (Bug#8600).
a108c10b
PE
6967
6968 * lread.c (read_integer): Be more consistent with string-to-number.
6969 Use string_to_number to do the actual conversion; this avoids
6970 rounding errors and fixes some other screwups. Without this fix,
6971 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6972 (digit_to_number): Move earlier, for benefit of read_integer.
6973 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6974 not a digit in any supported base. (Bug#8602)
a108c10b 6975
ad5f9eea
PE
6976 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6977
aec1708a
PE
6978 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6979 to match comment at start of function. This also removes a
6980 GCC warning about overflow in a 32+64-bit port.
6981
47be4ab5
PE
6982 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6983
371cac43
PE
6984 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6985 Reported by Stefan Monnier in
6986 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6987 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6988 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6989
d01a7826
PE
6990 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6991 (EMACS_UINTPTR): Likewise, with uintptr_t.
6992
7fd47d5c
PE
6993 * lisp.h: Prefer 64-bit EMACS_INT if available.
6994 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6995 on 32-bit hosts that have 64-bit int, so that they can access
6996 large files.
122b0c86
PE
6997 However, temporarily disable this change unless the temporary
6998 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6999
8727937b
PE
7000 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7001
8ac068ac
PE
7002 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7003 This removes an assumption that EMACS_INT and long are the same
7004 width as pointers. The assumption is true for Emacs porting targets
7005 now, but we want to make other targets possible.
7006 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7007 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7008 In the rest of the code, change types of integers that hold casted
7009 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7010 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7011 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7012 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7013 No need to cast type when ORing.
7014 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7015 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7016 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7017 assume EMACS_INT is the same width as char *.
7018 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7019 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7020 Remove no-longer-needed casts.
7021 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7022 (xg_tool_bar_help_callback, xg_make_tool_item):
7023 Use EMACS_INTPTR to hold an integer
7024 that will be cast to void *; this can avoid a GCC warning
7025 if EMACS_INT is not the same width as void *.
7026 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7027 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7028 (current_message_1, set_message_1):
7029 Use a local to convert to proper width without a cast.
7030 * xmenu.c (dialog_selection_callback): Likewise.
7031
ede49d71
PE
7032 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7033 Also, don't assume VALBITS / RAND_BITS is less than 5,
7034 and don't rely on undefined behavior when shifting a 1 left into
7035 the sign bit.
7036 * lisp.h (get_random): Change signature to match.
7037
2f30ecd0
PE
7038 * lread.c (hash_string): Use size_t, not int, for hash computation.
7039 Normally we prefer signed values; but hashing is special, because
7040 it's better to use unsigned division on hash table sizes so that
7041 the remainder is nonnegative. Also, size_t is the natural width
7042 for hashing into memory. The previous code used 'int', which doesn't
7043 retain enough info to hash well into very large tables.
7044 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7045
2a866e7b
PE
7046 * dbusbind.c: Don't possibly lose pointer info when converting.
7047 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7048 Use XPNTR rather than XHASH, so that the high-order bits of
7049 the pointer aren't lost when converting through void *.
7050
51639eac
PE
7051 * eval.c (Fautoload): Don't double-shift a pointer.
7052
92394119
PE
7053 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7054
dbdb9a7c
JB
70552011-05-06 Juanma Barranquero <lekktu@gmail.com>
7056
7057 * gnutls.c (DEF_GNUTLS_FN):
7058 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7059
db7a0b4f
AS
70602011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7061
7062 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7063 marker. (Bug#8610)
7064
cd394be1 70652011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7066
7067 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7068 New version that can reserve upto 2GB of heap space.
7069
f7ff1b0f 70702011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7071
7072 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7073
639c109b
TZ
70742011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7075
7076 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7077 `gnutls_certificate_set_x509_key_file'.
7078
d2127135
JB
70792011-05-05 Juanma Barranquero <lekktu@gmail.com>
7080
7081 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7082 Update dependencies.
7083
e968f4f3
JB
70842011-05-04 Juanma Barranquero <lekktu@gmail.com>
7085
7086 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7087 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7088 Remove unused parameter `fildes'.
7089 * process.c (read_process_output, send_process): Don't pass it.
7090
84d358f0
JB
70912011-05-04 Juanma Barranquero <lekktu@gmail.com>
7092
7093 Fix previous change: the library cache is defined in w32.c.
7094 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7095 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7096
0898ca10
JB
70972011-05-04 Juanma Barranquero <lekktu@gmail.com>
7098
7099 Implement dynamic loading of GnuTLS on Windows.
7100
7101 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7102 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7103 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7104 Declare.
7105
7106 * gnutls.c (Qgnutls_dll): Define.
7107 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7108 (gnutls_*): Declare function pointers.
7109 (init_gnutls_functions): New function to initialize function pointers.
7110 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7111 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7112 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7113 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7114 (emacs_gnutls_write, emacs_gnutls_read)
7115 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7116 (Fgnutls_available_p): New function.
7117 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7118 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7119 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7120
7121 * image.c: Include w32.h.
7122 (Vimage_type_cache): Delete.
7123 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7124 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7125 (w32_delayed_load): Move to w32.c.
7126
7127 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7128
7129 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7130 (w32_delayed_load): Move from image.c. When loading a library, record
7131 its filename in the :loaded-from property of the library id.
7132 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7133 Initialize and staticpro them.
7134 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7135
7136 * process.c: Include lisp.h before w32.h, not after.
7137 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7138 instead of gnutls_record_check_pending.
7139
7140 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7141
ff4de4aa
TZ
71422011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7143
7144 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7145 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7146 as passed in.
7147
abe95abb
JD
71482011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7149
7150 * xterm.c (x_set_frame_alpha): Do not set property on anything
7151 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7152
e16e55d4
JB
71532011-05-02 Juanma Barranquero <lekktu@gmail.com>
7154
7155 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7156
bafcf6a5
JB
71572011-05-02 Juanma Barranquero <lekktu@gmail.com>
7158
7159 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7160 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7161 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7162 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7163 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7164 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7165 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7166 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7167 (Qgnutls_bootprop_callbacks_verify): Make static.
7168
e7a6747f
AS
71692011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7170
19ed11ba
AS
7171 * callproc.c: Indentation fixup.
7172
e7a6747f 7173 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7174 (wait_for_termination, interruptible_wait_for_termination):
7175 Move after wait_for_termination_1.
e7a6747f 7176
1ef14cb4
LMI
71772011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7178
7179 * sysdep.c (interruptible_wait_for_termination): New function
7180 which is like wait_for_termination, but allows keyboard
7181 interruptions.
7182
7183 * callproc.c (Fcall_process): Add (:file "file") as an option for
7184 the STDOUT buffer.
7185 (Fcall_process_region): Ditto.
7186
330d880c
EZ
71872011-04-30 Eli Zaretskii <eliz@gnu.org>
7188
8db90b73
EZ
7189 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7190 rather than `XVECTOR (FOO)->size'.
7191
330d880c
EZ
7192 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7193 inttypes.h, as a gnulib replacement is used if it not available in
7194 system headers.
7195
15cbd324
EZ
71962011-04-21 Eli Zaretskii <eliz@gnu.org>
7197
7198 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7199 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7200 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7201
7202 * coding.c (coding_alloc_by_realloc): Error out if destination
7203 will grow beyond MOST_POSITIVE_FIXNUM.
7204 (decode_coding_emacs_mule): Abort if there isn't enough place in
7205 charbuf for the composition carryover bytes. Reserve an extra
7206 space for up to 2 characters produced in a loop.
7207 (decode_coding_iso_2022): Abort if there isn't enough place in
7208 charbuf for the composition carryover bytes.
7209
72102011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7211
ae940cca
EZ
7212 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7213 aborting when %lld or %lll format is passed.
7214 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7215 %llo or %llx format is passed. (Bug#8545)
7216
03ab8921
EZ
7217 * window.c (window_scroll_line_based): Use a marker instead of
7218 simple variables to record original value of point. (Bug#7952)
7219
afda1437
EZ
7220 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7221 produced by %s or %c overflows available buffer space. (Bug#8545)
7222
f76dee0c
PE
72232011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7224
7225 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7226 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7227
fdc5744d
JB
72282011-04-28 Juanma Barranquero <lekktu@gmail.com>
7229
7230 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7231
638f053a
JB
72322011-04-28 Juanma Barranquero <lekktu@gmail.com>
7233
7234 * keyboard.c (Qdelayed_warnings_hook): Define.
7235 (command_loop_1): Run `delayed-warnings-hook'
7236 if Vdelayed_warnings_list is non-nil.
7237 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7238 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7239
d178f871
EZ
72402011-04-28 Eli Zaretskii <eliz@gnu.org>
7241
7242 * doprnt.c (doprnt): Don't return value smaller than the buffer
7243 size if the message was truncated. (Bug#8545).
7244
b124fd93
JB
72452011-04-28 Juanma Barranquero <lekktu@gmail.com>
7246
7247 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7248 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7249
e810457d
PE
72502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7251
7252 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7253
ea51cceb
JB
72542011-04-27 Juanma Barranquero <lekktu@gmail.com>
7255
7256 * makefile.w32-in: Update dependencies.
7257
94dcfacf
EZ
72582011-04-27 Eli Zaretskii <eliz@gnu.org>
7259
7260 Improve `doprnt' and its usage. (Bug#8545)
7261 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7262 `format_end'. Remove support for %l as a conversion specifier.
7263 Don't use xrealloc. Improve diagnostics when the %l size modifier
7264 is used. Update the commentary.
7265
7266 * eval.c (verror): Simplify calculation of size_t.
7267
7268 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7269 messages.
7270
f61f41d7
PE
72712011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7272
7273 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7274 change.
7275
96fb4434
PE
72762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7277
7278 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7279 This makes this file independent of the recent pseudovector change.
7280
671875da 72812011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7282
69e9b5a3
PE
7283 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7284
b5f869a7 7285 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7286 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7287 Remove unused local.
c8926152 7288 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7289
841a1577 7290 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7291 GCC 4.6.0 optimizes based on type-based alias analysis.
7292 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7293 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7294 != &v->size, and therefore "v->size = 1; b->size = 2; return
7295 v->size;" must therefore return 1. This assumption is incorrect
7296 for Emacs, since it type-puns struct Lisp_Vector * with many other
7297 types. To fix this problem, this patch adds a new type struct
f904488f 7298 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7299 and pseudovectors, and helps optimizing compilers not get fooled
7300 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7301 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7302 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7303 the size member.
eab3844f
PE
7304 (XSETPVECTYPE): Rewrite in terms of new macro.
7305 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7306 This is a bit clearer, and further avoids the possibility of
7307 undesirable aliasing.
7308 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7309 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7310 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7311 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7312 (ASIZE): Now uses header.size rather than size.
7313 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7314 to avoid the hassle of writing XVECTOR (foo)->header.size.
7315 (struct vectorlike_header): New type.
eab3844f
PE
7316 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7317 object, to help avoid aliasing.
7318 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7319 (SUBRP): Likewise, since Lisp_Subr is a special case.
7320 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7321 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7322 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7323 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7324 changed to be "header.size" and "header.next".
7325 * buffer.h (struct buffer): Likewise.
7326 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7327 * frame.h (struct frame): Likewise.
7328 * process.h (struct Lisp_Process): Likewise.
7329 * termhooks.h (struct terminal): Likewise.
7330 * window.c (struct save_window_data, struct saved_window): Likewise.
7331 * window.h (struct window): Likewise.
7332 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7333 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7334 * buffer.c (init_buffer_once): Likewise.
7335 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7336 special case.
7337 * process.c (Fformat_network_address): Use local var for size,
7338 for brevity.
7339
0df1eac5
PE
7340 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7341
847ab9d1 7342 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7343 * data.c (atof): Remove decl; no longer used or needed.
7344 (digit_to_number): Move to lread.c.
7345 (Fstring_to_number): Use new string_to_number function, to be
7346 consistent with how the Lisp reader treats infinities and NaNs.
7347 Do not assume that floating-point numbers represent EMACS_INT
7348 without losing information; this is not true on most 64-bit hosts.
7349 Avoid double-rounding errors, by insisting on integers when
7350 parsing non-base-10 numbers, as the documentation specifies.
7351 * lisp.h (string_to_number): New decl, replacing ...
7352 (isfloat_string): Remove.
bc0a5c13 7353 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7354 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7355 appears to have been a coding error. Similarly, do not accept
7356 strings like +-1e0 as floating point numbers. Do not report
7357 overflow for integer overflows unless the base is not 10 which
7358 means we have no simple and reliable way to continue.
7359 Break out the floating-point parsing into a new
7360 function string_to_number, so that Fstring_to_number parses
7361 floating point numbers consistently with the Lisp reader.
04f2d78b 7362 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7363 (E_CHAR, EXP_INT): Remove, replacing with ...
7364 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7365 (string_to_number): New function, replacing isfloat_string.
7366 This function checks for valid syntax and produces the resulting
7367 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7368 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7369 so that overflow for non-base-10 numbers is reported only when
7370 there's no portable and simple way to convert to floating point.
452f4150 7371
67769ffc
PE
7372 * textprop.c (set_text_properties_1): Rewrite for clarity,
7373 and to avoid GCC warning about integer overflow.
7374
c20db43f
PE
7375 * intervals.h (struct interval): Use EMACS_INT for members
7376 where EMACS_UINT might cause problems. See
7377 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7378 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7379 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7380 All uses changed.
37aa2f85
PE
7381 (offset_intervals): Tell GCC not to worry about length overflow
7382 when negating a negative length.
c20db43f 7383
2538aa2f
PE
7384 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7385 (overrun_check_free): Likewise.
7386
f2d3008d
PE
7387 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7388 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7389 word size.
7390
ec8df744
PE
7391 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7392 (gnutls_make_error): Rename local to avoid shadowing.
7393 (gnutls_emacs_global_deinit): ifdef out; not used.
7394 (Fgnutls_boot): Use const for pointer to readonly storage.
7395 Comment out unused local. Fix pointer signedness problems.
7396
640ee02d
PE
7397 * lread.c (openp): Don't stuff size_t into an 'int'.
7398 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7399 about possible signed overflow.
7400
6048fb2a
PE
7401 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7402 (GDK_KEY_g): Don't define if already defined.
7403 (xg_prepare_tooltip): Avoid pointer signedness problem.
7404 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7405
fa3c87e1
PE
7406 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7407 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7408
2172544b
PE
7409 * xfns.c (Fx_window_property): Simplify a bit,
7410 to make a bit faster and to avoid GCC 4.6.0 warning.
7411 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7412
9b821a21
PE
7413 * fns.c (internal_equal): Don't assume size_t fits in int.
7414
3c616cfa
PE
7415 * alloc.c (compact_small_strings): Tighten assertion a little.
7416
c2982e87
PE
7417 Replace pEd with more-general pI, and fix some printf arg casts.
7418 * lisp.h (pI): New macro, generalizing old pEd macro to other
7419 conversion specifiers. For example, use "...%"pI"d..." rather
7420 than "...%"pEd"...".
7421 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7422 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7423 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7424 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7425 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7426 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7427 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7428 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7429 64-bit hosts.
7430 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7431 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7432 * print.c (safe_debug_print, print_object): Likewise.
7433 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7434 to int.
6f04d126
PE
7435 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7436 avoiding the 0 flag, which is not portable.
c2982e87
PE
7437 * process.c (Fmake_network_process): Use pI to avoid cast.
7438 * region-cache.c (pp_cache): Likewise.
7439 * xdisp.c (decode_mode_spec): Likewise.
7440 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7441 behavior on 64-bit hosts with printf arg.
6f04d126 7442 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7443 (x_stop_queuing_selection_requests): Likewise.
7444 (x_get_window_property): Don't truncate byte count to an 'int'
7445 when tracing.
0b432f21 7446
5e073ec7
PE
7447 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7448 here, since it parses constructs like leading '-' and spaces,
7449 which are not wanted; and it overflows with large numbers.
7450 Instead, simply match F[0-9]+, which is what is wanted anyway.
7451
36372bf9
PE
7452 * alloc.c: Remove unportable assumptions about struct layout.
7453 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7454 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7455 (allocate_vectorlike, make_pure_vector): Use the new macros,
7456 plus offsetof, to remove unportable assumptions about struct layout.
7457 These assumptions hold on all porting targets that I know of, but
7458 they are not guaranteed, they're easy to remove, and removing them
7459 makes further changes easier.
7460
0b432f21
PE
7461 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7462 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7463 (string_overrun_cookie): Now const. Use initializers that
7464 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7465 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7466 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7467 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7468 multiple of sizeof (EMACS_INT); it need not be, if
7469 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7470 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7471
895009e1
JB
74722011-04-26 Juanma Barranquero <lekktu@gmail.com>
7473
7474 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7475
6a7a1b0b
TZ
74762011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7477
7478 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7479 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7480 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7481
841a1577 74822011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7483
7484 * lisp.h (Qdebug): List symbol.
895009e1 7485 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7486 * keyboard.c (debug-on-event): New variable.
7487 (handle_user_signal): Break into debugger when debug-on-event
7488 matches the current signal symbol.
7489
f2d3ba6f
DN
74902011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7491
7492 * alloc.c (check_sblock, check_string_bytes)
7493 (check_string_free_list): Convert to standard C.
7494
42ce4c63
TZ
74952011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7496
7497 * w32.c (emacs_gnutls_push): Fix typo.
7498
825cd63c
EZ
74992011-04-25 Eli Zaretskii <eliz@gnu.org>
7500
fb11d64d
EZ
7501 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7502 "cast to pointer from integer of different size".
7503
825cd63c
EZ
7504 Improve doprnt and its use in verror. (Bug#8545)
7505 * doprnt.c (doprnt): Document the set of format control sequences
7506 supported by the function. Use SAFE_ALLOCA instead of always
7507 using `alloca'.
7508
7509 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7510 is one byte too soon. Don't use xrealloc; instead xfree and
7511 xmalloc anew.
7512
e061a11b
TZ
75132011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7514
7515 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7516 callbacks stage.
7517
7518 * gnutls.c: Renamed global_initialized to
7519 gnutls_global_initialized. Added internals for the
7520 :verify-hostname-error, :verify-error, and :verify-flags
7521 parameters of `gnutls-boot' and documented those parameters in the
7522 docstring. Start callback support.
9173deec
JB
7523 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7524 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7525 on error. Return error code.
e061a11b
TZ
7526 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7527 (emacs_gnutls_read): Likewise.
7528 (Fgnutls_boot): Return handshake error code.
7529 (emacs_gnutls_handle_error): New function.
7530 (wsaerror_to_errno): Likewise.
7531
7532 * w32.h (emacs_gnutls_pull): Add prototype.
7533 (emacs_gnutls_push): Likewise.
7534
7535 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7536 (emacs_gnutls_push): Likewise.
7537
75382011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7539
7540 * process.c (wait_reading_process_output): Check if GnuTLS
7541 buffered some data internally if no FDs are set for TLS
7542 connections.
7543
7544 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7545 (LIBS): Link to USER_LIBS.
7546 ($(BLD)/gnutls.$(0)): New target.
7547
fa6996bc
EZ
75482011-04-24 Eli Zaretskii <eliz@gnu.org>
7549
eb35682e
EZ
7550 * xdisp.c (handle_single_display_spec): Rename the
7551 display_replaced_before_p argument into display_replaced_p, to
7552 make it consistent with the commentary. Fix typos in the
7553 commentary.
7554
e2ad650c
EZ
7555 * textprop.c (syms_of_textprop): Remove dead code.
7556 (copy_text_properties): Delete obsolete commentary about an
7557 interface that was deleted long ago. Fix typos in the description
7558 of arguments.
7559
1b2de274
EZ
7560 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7561 to changes in oldXMenu/XMenu.h from 2011-04-16.
7562 <menu_help_message, prev_menu_help_message>: Constify.
7563 (IT_menu_make_room): menu->help_text is now `const char **';
7564 adjust.
7565
7566 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7567 to changes in oldXMenu/XMenu.h from 2011-04-16.
7568 (struct XMenu): Declare `help_text' `const char **'.
7569
7570 * xfaces.c <Qunspecified>: Make extern again.
7571
7572 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7573 required by POSIX.
1b2de274 7574
762b15be
EZ
7575 * doc.c (get_doc_string): Improve the format passed to `error'.
7576
7577 * doprnt.c (doprnt): Improve commentary.
7578
7579 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7580
7581 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7582 them with etags.
7583
f1052e5d
EZ
7584 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7585 changes in globals.h immediately force recompilation.
762b15be
EZ
7586 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7587 $(CURDIR)/s/ms-w32.h.
7588 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7589
fa6996bc
EZ
7590 * character.c (Fchar_direction): Function deleted.
7591 (syms_of_character): Don't defsubr it.
7592 <char-direction-table>: Deleted.
7593
e6c3da20
EZ
75942011-04-23 Eli Zaretskii <eliz@gnu.org>
7595
7596 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7597 * doprnt.c: Include limits.h.
7598 (SIZE_MAX): New macro.
04f2d78b
CB
7599 (doprnt): Return a size_t value. 2nd arg is now size_t.
7600 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7601 Improve overflow protection. Support `l' modifier for integer
7602 conversions. Support %l conversion. Don't assume an EMACS_INT
7603 argument for integer conversions and for %c.
7604
7605 * lisp.h (doprnt): Restore prototype.
7606
7607 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7608 $(SRC)/character.h.
7609
7610 * Makefile.in (base_obj): Add back doprnt.o.
7611
7612 * deps.mk (doprnt.o): Add back prerequisites.
7613 (callint.o): Depend on character.h.
7614
7615 * eval.c (internal_lisp_condition_case): Include the handler
7616 representation in the error message.
7617 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7618 when breaking from the loop.
7619
7620 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7621
7622 * callint.c (Fcall_interactively): When displaying error message
7623 about invalid control letter, pass the character's codepoint, not
7624 a pointer to its multibyte form. Improve display of the character
7625 in octal and display also its hex code.
7626
7627 * character.c (char_string): Use %x to display the (unsigned)
7628 codepoint of an invalid character, to avoid displaying a bogus
7629 negative value.
7630
7631 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7632 `error', not SYMBOL_NAME itself.
7633
7634 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7635 character arguments to `error'.
7636
7637 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7638 to `error' in error message about FINAL_CHAR argument. Make sure
7639 FINAL_CHAR is a character, and use %c when it is passed as
7640 argument to `error'.
7641
4ffd0d6b 76422011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7643
7644 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7645
7646 * w32.c: Include <time.h>.
7647 (sys_localtime): New function.
7648
4ffd0d6b 76492011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7650
7651 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7652
4ffd0d6b 7653 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7654
4ffd0d6b 76552011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7656
4ffd0d6b
GM
7657 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7658 zombies (Bug#8467).
aac0c6e3 7659
04c56954
EZ
76602011-04-19 Eli Zaretskii <eliz@gnu.org>
7661
7662 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7663 gl_state.e_property when gl_state.object is Qt.
7664
7665 * insdel.c (make_gap_larger): Remove limitation of buffer size
7666 to <= INT_MAX.
7667
16a43933
CY
76682011-04-18 Chong Yidong <cyd@stupidchicken.com>
7669
7670 * xdisp.c (lookup_glyphless_char_display)
7671 (produce_glyphless_glyph): Handle cons cell entry in
7672 glyphless-char-display.
7673 (Vglyphless_char_display): Document it.
7674
7675 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7676 glyphless-char-display.
7677
4581706e
CY
76782011-04-17 Chong Yidong <cyd@stupidchicken.com>
7679
7680 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7681
7682 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7683
7684 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7685 definition for no-X builds.
7686
4887c6e2 76872011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7688
fd35b6f9
PE
7689 Static checks with GCC 4.6.0 and non-default toolkits.
7690
5c1ccb01
PE
7691 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7692
006c5daa
PE
7693 * process.c (keyboard_bit_set): Define only if SIGIO.
7694 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7695 (send_process): Repair possible setjmp clobbering.
7696
efc736d3
PE
7697 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7698
4e2fe2e6
PE
7699 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7700
f97334a2
PE
7701 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7702
4e75f29d
PE
7703 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7704 Define only if needed.
7705
90efadd1
PE
7706 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7707 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7708 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7709
3c647824
PE
7710 * dispextern.h (struct redisplay_interface): Rename param
7711 to avoid shadowing.
e264f262 7712 * termhooks.h (struct terminal): Likewise.
761383f4 7713 * xterm.c (xembed_send_message): Likewise.
3c647824 7714
b58c5c4a
PE
7715 * insdel.c (make_gap_smaller): Define only if
7716 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7717
cad59032
PE
7718 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7719 it.
7720
c339dc2e
PE
7721 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7722 so that we aren't warned about unused symbols.
7723
91a3e27b
PE
7724 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7725
399c71d3 7726 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7727
8ffc96f5
PE
7728 * xfns.c (x_real_positions): Mark locals as initialized.
7729
eef9bc79
PE
7730 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7731
098db9dd
PE
7732 * xterm.c: Fix problems found by static analysis with other toolkits.
7733 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7734 (x_dispatch_event): Declare static if USE_GTK, and
7735 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7736 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7737 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7738 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7739 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7740
eb18f6cc
PE
7741 * xmenu.c (menu_help_callback): Pointer type fixes.
7742 Use const pointers when pointing at readonly data. Avoid pointer
7743 signedness clashes.
7744 (FALSE): Remove unused macro.
7745 (update_frame_menubar): Remove unused decl.
7746
1fe72bf8
PE
7747 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7748
60d9e1db
PE
7749 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7750 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7751 (single_menu_item): Rename local to avoid shadowing.
7752
39261c26
PE
7753 * keyboard.c (make_lispy_event): Remove unused local var.
7754
018c5e19
PE
7755 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7756 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7757
63d2b86e
PE
7758 * bitmaps: Change bitmaps from unsigned char back to the X11
7759 compatible char. Avoid the old compiler warnings about
7760 out-of-range initializers by using, for example, '\xab' rather
7761 than 0xab.
7762
aefd87e1
PE
7763 * xgselect.c (xgselect_initialize): Check vs interface
7764 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7765
bf501fb9
PE
7766 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7767
e9829fdf
PE
7768 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7769 to read-only memory.
7770
1086c095
PE
7771 * fns.c (vector): Remove; this old hack is no longer needed.
7772
2baccd04 7773 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7774 Remove unused var.
dde42981 7775 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7776
72391843 7777 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7778
436c16df 7779 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7780 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7781 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7782
92bb796d 7783 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7784 (x_term_init): Remove local to avoid shadowing.
92bb796d 7785
764430a3 7786 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7787
7788 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7789 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7790
d1dfb56c
EZ
77912011-04-16 Eli Zaretskii <eliz@gnu.org>
7792
c4354cb4
EZ
7793 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7794
d1dfb56c
EZ
7795 Fix regex.c, syntax.c and friends for buffers > 2GB.
7796 * syntax.h (struct gl_state_s): Declare character position members
7797 EMACS_INT.
7798
7799 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7800
04f2d78b
CB
7801 * textprop.c (verify_interval_modification, interval_of):
7802 Declare arguments EMACS_INT.
d1dfb56c
EZ
7803
7804 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7805 EMACS_INT.
7806
7807 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7808
7809 * indent.c (Fvertical_motion): Local variable it_start is now
7810 EMACS_INT.
7811
7812 * regex.c (re_match, re_match_2, re_match_2_internal)
7813 (bcmp_translate, regcomp, regexec, print_double_string)
7814 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7815 (re_compile_pattern, re_exec): Declare arguments and local
7816 variables `size_t' and `ssize_t' and return values `regoff_t', as
7817 appropriate.
7818 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7819 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7820 <compile_stack_type>: `size' and `avail' are now `size_t'.
7821
7822 * regex.h <regoff_t>: Use ssize_t, not int.
7823 (re_search, re_search_2, re_match, re_match_2): Arguments that
7824 specify buffer/string position and length are now ssize_t and
7825 size_t. Return type is regoff_t.
7826
613052cd
BK
78272011-04-16 Ben Key <bkey76@gmail.com>
7828
7829 * nsfont.m: Fixed bugs in ns_get_family and
7830 ns_descriptor_to_entity that were caused by using free to
7831 deallocate memory blocks that were allocated by xmalloc (via
7832 xstrdup). This caused Emacs to crash when compiled with
7833 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7834 --enable-checking=xmallocoverrun). xfree is now used to
7835 deallocate these memory blocks.
7836
4170f62f 78372011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7838
71b41406
PE
7839 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7840
9587a89d
PE
7841 emacs_write: Accept and return EMACS_INT for sizes.
7842 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7843 et seq.
7844 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7845 Accept and return EMACS_INT.
7846 (emacs_gnutls_write): Return the number of bytes written on
7847 partial writes.
7848 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7849 (emacs_read, emacs_write): Remove check for negative size, as the
7850 Emacs source code has been audited now.
9587a89d
PE
7851 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7852 (emacs_read, emacs_write): Use it.
273a5f82
PE
7853 * process.c (send_process): Adjust to the new signatures of
7854 emacs_write and emacs_gnutls_write. Do not attempt to store
7855 a byte offset into an 'int'; it might overflow.
9587a89d 7856 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7857
3e047f51
PE
7858 * sound.c: Don't assume sizes fit in 'int'.
7859 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7860 Return EMACS_INT, not int.
3e047f51 7861 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7862 Accept EMACS_INT, not int.
7863 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7864 record read return values.
7865
cc39a9db
BK
78662011-04-15 Ben Key <bkey76@gmail.com>
7867
c9d0ec6d
JB
7868 * keyboard.c (Qundefined): Don't declare static since it is used
7869 in nsfns.m.
7870 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7871 static since they are used in nsfont.m.
cc39a9db 7872
6c60eb9f
SM
78732011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7874
7875 * process.c (Qprocessp): Don't declare static.
7876 * lisp.h (Qprocessp): Declare again.
7877
7990b61a
JB
78782011-04-15 Juanma Barranquero <lekktu@gmail.com>
7879
7880 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7881
5d4cb038
PE
78822011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7883
8bd7b830 7884 Improve C-level modularity by making more things 'static'.
cd64ea1d 7885
e3b27b31
PE
7886 Don't publish debugger-only interfaces to other modules.
7887 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7888 (verify_bytepos, count_markers): Move decls to the only modules
7889 that need them.
7890 * region-cache.h (pp_cache): Likewise.
7891 * window.h (check_all_windows): Likewise.
7892 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7893
5d4cb038
PE
7894 * sysdep.c (croak): Now static, if
7895 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7896 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7897
7898 * alloc.c (refill_memory_reserve): Now static if
7899 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7900 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7901
e87b6180
PE
7902 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7903 Define only if USE_LUCID.
7904
ac64929e
PE
7905 * xrdb.c (x_customization_string, x_rm_string): Now static.
7906
6f37259d
PE
7907 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7908 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7909
1683e3ab
PE
7910 * xdisp.c (draw_row_with_mouse_face): Now static.
7911 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7912
de9c2632
PE
7913 * window.h (check_all_windows): Mark externally visible.
7914
2b96acb7
PE
7915 * window.c (window_deletion_count): Now static.
7916
7917 * undo.c: Make symbols static if they're not exported.
7918 (last_undo_buffer, last_boundary_position, pending_boundary):
7919 Now static.
7920
50436f33
PE
7921 * textprop.c (interval_insert_behind_hooks): Now static.
7922 (interval_insert_in_front_hooks): Likewise.
7923
64520e5c
PE
7924 * term.c: Make symbols static if they're not exported.
7925 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7926 (max_frame_lines, tty_set_terminal_modes):
7927 (tty_reset_terminal_modes, tty_turn_off_highlight):
7928 (get_tty_terminal): Now static.
7929 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7930 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7931 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7932 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7933 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7934
1fa53021
PE
7935 * sysdep.c: Make symbols static if they're not exported.
7936 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7937 Now static.
7938 (sigprocmask_set, full_mask): Remove; unused.
7939 (wait_debugging): Mark as visible.
7940 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7941 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7942
d4b43b22
PE
7943 * syntax.c (syntax_temp): Define only if !__GNUC__.
7944
b7c513d0
PE
7945 * sound.c (current_sound_device, current_sound): Now static.
7946
989b29ad
PE
7947 * search.c (searchbufs, searchbuf_head): Now static.
7948
13a55a78
PE
7949 * scroll.c (scroll_cost): Remove; unused.
7950 * dispextern.h (scroll_cost): Remove decl.
7951
de68a1fc
PE
7952 * region-cache.h (pp_cache): Mark as externally visible.
7953
40ccffa6
PE
7954 * process.c: Make symbols static if they're not exported.
7955 (process_tick, update_tick, create_process, chan_process):
7956 (Vprocess_alist, proc_buffered_char, datagram_access):
7957 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7958 (deactivate_process): Mark defn as static, as well as decl.
7959 * lisp.h (create_process): Remove decl.
7960 * process.h (chan_process, Vprocess_alist): Remove decls.
7961
ad64fc97
PE
7962 * print.c: Make symbols static if they're not exported.
7963 (print_depth, new_backquote_output, being_printed, print_buffer):
7964 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7965 (print_interval, print_number_index, initial_stderr_stream):
7966 Now static.
7967 * lisp.h (Fprinc): Remove decl.
7968 (debug_output_compilation_hack): Mark as externally visible.
7969
adddb265
PE
7970 * sysdep.c (croak): Move decl from here to syssignal.h.
7971 * syssignal.h (croak): Put it here, so the API can be checked when
7972 'croak' is called from dissociate_if_controlling_tty.
7973
1717ede2
PE
7974 * minibuf.c: Make symbols static if they're not exported.
7975 (minibuf_save_list, choose_minibuf_frame): Now static.
7976 * lisp.h (choose_minibuf_frame): Remove decl.
7977
fa5fb2bc
PE
7978 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7979
1e3890d1
PE
7980 * lread.c: Make symbols static if they're not exported.
7981 (read_objects, initial_obarray, oblookup_last_bucket_number):
7982 Now static.
7983 (make_symbol): Remove; unused.
7984 * lisp.h (initial_obarray, make_symbol): Remove decls.
7985
8a1414fa
PE
7986 * keyboard.c: Make symbols static if they're not exported.
7987 (single_kboard, recent_keys_index, total_keys, recent_keys):
7988 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7989 (this_single_command_key_start, echoing, last_auto_save):
7990 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7991 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7992 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7993 (Vlispy_mouse_stem, double_click_count):
7994 Now static.
7995 (force_auto_save_soon): Define only if SIGDANGER.
7996 (ignore_mouse_drag_p): Now static if
7997 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7998 (print_help): Remove; unused.
7999 (stop_character, last_timer_event): Mark as externally visible.
8000 * keyboard.h (ignore_mouse_drag_p): Declare only if
8001 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8002 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8003 * lisp.h (echoing): Remove decl.
8004 (force_auto_save_soon): Declare only if SIGDANGER.
8005 * xdisp.c (redisplay_window): Simplify code, to make it more
8006 obvious that ignore_mouse_drag_p is not accessed if !defined
8007 USE_GTK && !defined HAVE_NS.
8008
93ea6e8f
PE
8009 * intervals.c: Make symbols static if they're not exported.
8010 (merge_properties_sticky, merge_interval_right, delete_interval):
8011 Now static.
8012 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8013
77382fcc
PE
8014 * insdel.c: Make symbols static if they're not exported.
8015 However, leave prepare_to_modify_buffer alone. It's never
8016 called from outside this function, but that appears to be a bug.
8017 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8018 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8019 (adjust_after_replace_noundo): Remove; unused.
8020 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8021 (signal_before_change): Remove decls.
77382fcc 8022
9306c32e
PE
8023 * indent.c (val_compute_motion, val_vmotion): Now static.
8024
cd44d2eb
PE
8025 * image.c: Make symbols static if they're not exported.
8026 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8027 if USE_GTK.
8028 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8029 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8030
ad9a7a06
PE
8031 * fringe.c (standard_bitmaps): Now static.
8032 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8033
81626931
PE
8034 * frame.c: Make symbols static if they're not exported.
8035 (x_report_frame_params, make_terminal_frame): Now static.
8036 (get_frame_param): Now static, unless HAVE_NS.
8037 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8038 (x_get_resource_string): Remove; not used.
8039 * frame.h (make_terminal_frame, x_report_frame_params):
8040 (x_get_resource_string); Remove decls.
8041 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8042 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8043
239f9db9
PE
8044 * font.c, fontset.c: Make symbols static if they're not exported.
8045 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8046 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8047 * font.c (font_close_object): Now static.
8048 * font.h (font_close_object): Remove.
8049 * fontset.c (FONTSET_OBJLIST): Remove.
8050 (free_realized_fontset) #if-0 the body, which does nothing.
8051 (face_suitable_for_char_p): #if-0, as it's never called.
8052 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8053 * xfaces.c (face_at_string_position):
8054 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8055 since 0 is always ASCII.
8056
dfcf3579
PE
8057 * fns.c (weak_hash_tables): Now static.
8058
5045092b
PE
8059 * fileio.c: Make symbols static if they're not exported.
8060 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8061 (Vwrite_region_annotation_buffers): Now static.
8062
57a96f5c
PE
8063 * eval.c: Make symbols static if they're not exported.
8064 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8065 * lisp.h (backtrace_list): Remove decl.
8066
35f08c38
PE
8067 * emacs.c: Make symbols static if they're not exported.
8068 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8069 (fatal_error_code, fatal_error_signal_hook, standard_args):
8070 Now static.
8071 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8072 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8073 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8074 * lisp.h (fatal_error_signal_hook): Remove decl.
8075 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8076
f44bd759
PE
8077 * editfns.c: Move a (normally-unused) function to its only use.
8078 * editfns.c, lisp.h (get_operating_system_release): Remove.
8079 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8080 worth the hassle of breaking this out.
8081
b532497d
PE
8082 * xterm.c: Make symbols static if they're not exported.
8083 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8084 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8085 (x_destroy_window, x_delete_display):
8086 Now static.
8087 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8088 (x_mouse_leave): Remove; unused.
8089 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8090 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8091 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8092 Remove decls.
8093 (x_mouse_leave): Declare only if WINDOWSNT.
8094 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8095 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8096 USE_X_TOOLKIT.
8097
1675728f
PE
8098 * ftxfont.c: Make symbols static if they're not exported.
8099 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8100 HAVE_FREETYPE.
8101 * font.h (ftxfont_driver): Likewise.
8102
e4cebfca
PE
8103 * xfns.c: Make symbols static if they're not exported.
8104 (x_last_font_name, x_display_info_for_name):
8105 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8106 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8107 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8108 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8109 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8110 (last_show_tip_args): Now static.
8111 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8112 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8113 (x_screen_planes): Remove; unused.
8114 * dispextern.h (x_screen_planes): Remove decl.
8115
5bf46f05
PE
8116 * dispnew.c: Make symbols static if they're not exported.
8117 * dispextern.h (redraw_garbaged_frames, scrolling):
8118 (increment_row_positions): Remove.
8119 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8120 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8121 Now static.
8122 (redraw_garbaged_frames): Remove; unused.
8123
435f4c28
PE
8124 * xfaces.c: Make symbols static if they're not exported.
8125 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8126 Remove decls.
8127 * xterm.h (defined_color): Remove decls.
8128 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8129 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8130 (menu_face_changed_default, defined_color, free_realized_face):
8131 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8132 (ascii_face_of_lisp_face): Remove; unused.
8133
8524aef3
PE
8134 * xdisp.c: Make symbols static if they're not exported.
8135 * dispextern.h (scratch_glyph_row, window_box_edges):
8136 (glyph_to_pixel_coords, set_cursor_from_row):
8137 (get_next_display_element, set_iterator_to_next):
8138 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8139 (show_mouse_face): Remove decls
8140 * frame.h (message_buf_print): Likewise.
8141 * lisp.h (pop_message, set_message, check_point_in_composition):
8142 Likewise.
8143 * xterm.h (set_vertical_scroll_bar): Likewise.
8144 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8145 (message_buf_print, scratch_glyph_row, displayed_buffer):
8146 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8147 (get_next_display_element, show_mouse_face, window_box_edges):
8148 (frame_to_window_pixel_xy, check_point_in_composition):
8149 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8150 (glyph_to_pixel_coords): Remove; unused.
8151
16390cd2
PE
8152 * dired.c (file_name_completion): Now static.
8153
8154 * dbusbind.c (xd_in_read_queued_messages): Now static.
8155
a25f4dfa
PE
8156 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8157 * data.c (circular_list_error): Remove.
8158
14a9c8df
PE
8159 * commands.h (last_point_position, last_point_position_buffer):
8160 (last_point_position_window): Remove decls.
8161 * keyboard.c: Make these variables static.
8162
04f2d78b
CB
8163 * coding.h (coding, code_convert_region, encode_coding_gap):
8164 Remove decls.
74ab6df5
PE
8165 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8166 (iso_code_class, detect_coding, code_convert_region): Now static.
8167 (encode_coding_gap): Remove; unused.
8168
38dfbee1
PE
8169 * chartab.c (chartab_chars, chartab_bits): Now static.
8170
a2cb4e63
PE
8171 * charset.h (charset_iso_8859_1): Remove decl.
8172 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8173 Now static.
8174
127198fd
PE
8175 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8176 * ccl.c (Vccl_program_table): Now static.
8177 (check_ccl_update): Remove; unused.
8178
d85b608f
PE
8179 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8180 * category.h: ... from here.
8181 * category.c (check_category_table, set_category_set): Now static.
8182
31cd66f3
PE
8183 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8184 * lisp.h: Remove these decls.
8185
c358e587
PE
8186 * buffer.c (buffer_count): Remove unused var.
8187
e78aecca
PE
8188 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8189 so that it's not optimized away.
8190 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8191 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8192 exported only to the debugger.
8193
e192d7d3 8194 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8195 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8196
92470028
PE
8197 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8198 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8199 was inaccessible from Lisp.
8200 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8201 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8202
244ed907
PE
8203 alloc.c: Import and export fewer symbols, and remove unused items.
8204 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8205 is defined.
8206 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8207 it's not optimized away by whole-program optimization.
8208 (message_enable_multibyte, free_misc): Remove.
8209 (catchlist, handlerlist, mark_backtrace):
8210 Declare only if BYTE_MARK_STACK.
8211 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8212 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8213 (message_enable_multibyte): Remove decl.
8214 (free_misc, interval_free_list, float_block, float_block_index):
8215 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8216 (cons_free_list, last_marked_index):
8217 Now static.
8218 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8219 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8220 (mark_backtrace): Define only if BYTE_MARK_STACK.
8221 * xdisp.c (message_enable_multibyte): Now static.
8222
61c2b50e 8223 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8224 This makes it easier for human readers (and static analyzers)
8225 to see whether these variables are used from other modules.
8226 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8227 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8228 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8229 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8230 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8231 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8232 * xmenu.c, xselect.c:
8233 Declare Q* vars static if they are not used in other modules.
8234 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8235 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8236 Remove decls of unexported vars.
8237 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8238
95c82688
PE
8239 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8240
16a97296
PE
8241 Make Emacs functions such as Fatom 'static' by default.
8242 This makes it easier for human readers (and static analyzers)
8243 to see whether these functions can be called from other modules.
8244 DEFUN now defines a static function. To make the function external
8245 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8246 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8247 (Finit_image_library):
16a97296
PE
8248 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8249 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8250 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8251 Remove decls, since these functions are now static.
8252 (Funintern, Fget_internal_run_time): New decls, since these functions
8253 were already external.
95c82688 8254
16a97296
PE
8255 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8256 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8257 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8258 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8259 * keyboard.c, keymap.c, lread.c:
8260 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8261 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8262 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8263 Mark functions with DEFUE instead of DEFUN,
8264 if they are used in other modules.
8265 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8266 decls for now-static functions.
8267 * buffer.h (Fdelete_overlay): Remove decl.
8268 * callproc.c (Fgetenv_internal): Mark as internal.
8269 * composite.c (Fremove_list_of_text_properties): Remove decl.
8270 (Fcomposition_get_gstring): New forward static decl.
8271 * composite.h (Fcomposite_get_gstring): Remove decl.
8272 * dired.c (Ffile_attributes): New forward static decl.
8273 * doc.c (Fdocumntation_property): New forward static decl.
8274 * eval.c (Ffetch_bytecode): New forward static decl.
8275 (Funintern): Remove extern decl; now in .h file where it belongs.
8276 * fileio.c (Fmake_symbolic_link): New forward static decl.
8277 * image.c (Finit_image_library): New forward static decl.
8278 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8279 * intervals.h (Fprevious_property_change):
8280 (Fremove_list_of_text_properties): Remove decls.
8281 * keyboard.c (Fthis_command_keys): Remove decl.
8282 (Fcommand_execute): New forward static decl.
8283 * keymap.c (Flookup_key): New forward static decl.
8284 (Fcopy_keymap): Now static.
8285 * keymap.h (Flookup_key): Remove decl.
8286 * process.c (Fget_process): New forward static decl.
8287 (Fprocess_datagram_address): Mark as internal.
8288 * syntax.c (Fsyntax_table_p): New forward static decl.
8289 (skip_chars): Remove duplicate decl.
8290 * textprop.c (Fprevious_property_change): New forward static decl.
8291 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8292 Now internal.
8293 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8294 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8295
785bbd42
PE
8296 * editfns.c (Fformat): Remove unreachable code.
8297
8b913b57
AS
82982011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8299
8300 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8301 change. (Bug#8496)
8302
a6744a35
EZ
83032011-04-13 Eli Zaretskii <eliz@gnu.org>
8304
8305 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8306 when at ZV. (Bug#8487)
8307
e7974947
AS
83082011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8309
baad03f0
AS
8310 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8311 (Bug#8437)
8312 * keyboard.c (parse_tool_bar_item): Likewise.
8313 * sound.c (sound_cleanup, alsa_close): Likewise.
8314 * termcap.c (tgetent): Likewise.
8315 * xfns.c (x_default_font_parameter): Likewise.
8316 * xsettings.c (read_and_apply_settings): Likewise.
8317
e7974947
AS
8318 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8319 (overrun_check_free): Protoize.
8320
28272684
PE
83212011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8322
8323 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8324 since callers should never pass a negative size.
8325 Change the signature to match that of plain 'read' and 'write'; see
8326 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8327 * lisp.h: Update prototypes of emacs_write and emacs_read.
8328
11997c76
EZ
83292011-04-11 Eli Zaretskii <eliz@gnu.org>
8330
8331 * xdisp.c (redisplay_window): Don't try to determine the character
8332 position of the scroll margin if the window start point w->startp
e896f03c 8333 is outside the buffer's accessible region. (Bug#8468)
11997c76 8334
8a2cbd72
EZ
83352011-04-10 Eli Zaretskii <eliz@gnu.org>
8336
8337 Fix write-region and its subroutines for buffers > 2GB.
8338 * fileio.c (a_write, e_write): Modify declaration of arguments and
8339 local variables to support buffers larger than 2GB.
8340 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8341
8342 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8343 argument, local variables, and return value.
8344
8345 * lisp.h: Update prototypes of emacs_write and emacs_read.
8346
8347 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8348
4073e537 83492011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8350
1ebfdcb6
PE
8351 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8352
b2ded58d
PE
8353 Fix more problems found by GCC 4.6.0's static checks.
8354
7d66342c
PE
8355 * xdisp.c (vmessage): Use a better test for character truncation.
8356
bbf47d44
PE
8357 * charset.c (load_charset_map): <, not <=, for optimization,
8358 and to avoid potential problems with integer overflow.
9248994d 8359 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8360 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8361 * editfns.c (Fformat): Likewise.
1e69125e 8362 * syntax.c (skip_chars): Likewise.
3befa583 8363
e3019616
PE
8364 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8365 This also lets GCC 4.6.0 generate slightly better loop code.
8366
becfa255
PE
8367 * callint.c (Fcall_interactively): <, not <=, for optimization.
8368 (Fcall_interactively): Count the number of arguments produced,
8369 not the number of arguments given. This is simpler and lets GCC
8370 4.6.0 generate slightly better code.
8371
dae0cd48
PE
8372 * ftfont.c: Distingish more carefully between FcChar8 and char.
8373 The previous code passed unsigned char * to a functions like
8374 strlen and xstrcasecmp that expect char *, which does not
8375 conform to the C standard.
8376 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8377 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8378 char * when the C standard requires it.
8379
76032d70
PE
8380 * keyboard.c (read_char): Remove unused var.
8381
eb3f1cc8
PE
8382 * eval.c: Port to Windows vsnprintf (Bug#8435).
8383 Include <limits.h>.
8384 (SIZE_MAX): Define if the headers do not.
8385 (verror): Do not give up if vsnprintf returns a negative count.
8386 Instead, grow the buffer. This ports to Windows vsnprintf, which
8387 does not conform to C99. Problem reported by Eli Zaretskii.
8388 Also, simplify the allocation scheme, by avoiding the need for
8389 calling realloc, and removing the ALLOCATED variable.
8390
70476b54
PE
8391 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8392
12020a9e
PE
8393 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8394 But keep the doprint source code for now, as we might revamp it
8395 and use it again (Bug#8435).
ea6c7ae6
PE
8396 * lisp.h (doprnt): Remove.
8397 * Makefile.in (base_obj): Remove doprnt.o.
8398 * deps.mk (doprnt.o): Remove.
8399
5fdb398c
PE
8400 error: Print 32- and 64-bit integers portably (Bug#8435).
8401 Without this change, on typical 64-bit hosts error ("...%d...", N)
8402 was used to print both 32- and 64-bit integers N, which relied on
8403 undefined behavior.
61bdb816 8404 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8405 * lisp.h (error, verror): Mark as printf-like functions.
8406 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8407 Report overflow in size calculations when allocating printf buffer.
8408 Do not truncate output string at its first null byte.
8409 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8410 Truncate the output at a character boundary, since vsnprintf does not
8411 do that.
8412 * charset.c (check_iso_charset_parameter): Convert internal
8413 character to string before calling 'error', since %c now has the
8414 printf meaning.
8415 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8416 overflow when computing char to be passed to 'error'. Do not
8417 pass Lisp_Object to 'error'; pass the integer instead.
8418 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8419 formatted with plain %d.
8420
b189fa66
PE
8421 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8422
bff87ef0
PE
8423 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8424
7e2cac20
PE
8425 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8426
ce4d90b5
PE
8427 * xterm.c (x_catch_errors): Remove duplicate declaration.
8428
266c9547
PE
8429 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8430
79c49ad2
PE
8431 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8432
368f4090
JM
84332011-04-10 Jim Meyering <meyering@redhat.com>
8434
8435 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8436 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8437 return ssize_t not "int", and use size_t as the buffer length.
8438 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8439 * gnutls.h: Update declarations.
8440 * process.c (read_process_output): Use ssize_t, to match.
8441 (send_process): Likewise.
8442
a32d4040
CY
84432011-04-09 Chong Yidong <cyd@stupidchicken.com>
8444
8445 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8446
8546720e 84472011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8448
04f2d78b
CB
8449 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8450 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8451
8546720e
GM
8452 * xterm.c (handle_one_xevent):
8453 * xmenu.c (create_and_show_popup_menu):
8454 * xselect.c (x_decline_selection_request)
8455 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8456
0a2f5c1a 84572011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8458
8459 Fix some uses of `int' instead of EMACS_INT.
8460 * search.c (string_match_1, fast_string_match)
8461 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8462 (scan_buffer, find_next_newline_no_quit)
8463 (find_before_next_newline, search_command, Freplace_match)
8464 (Fmatch_data): Make some `int' variables be EMACS_INT.
8465
8466 * xdisp.c (display_count_lines): 3rd argument and return value now
8467 EMACS_INT. All callers changed.
8468 (pint2hrstr): Last argument is now EMACS_INT.
8469
8470 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8471 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8472 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8473 (decode_coding_utf_16, decode_coding_emacs_mule)
8474 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8475 (decode_coding_ccl, decode_coding_charset)
8476 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8477 (decode_coding_iso_2022, decode_coding_emacs_mule)
8478 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8479 <char_offset, last_offset>: Declare EMACS_INT.
8480 (encode_coding_utf_8, encode_coding_utf_16)
8481 (encode_coding_emacs_mule, encode_invocation_designation)
8482 (encode_designation_at_bol, encode_coding_iso_2022)
8483 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8484 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8485 Declare EMACS_INT.
8486 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8487 (encode_invocation_designation): Last argument P_NCHARS is now
8488 EMACS_INT.
8489 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8490 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8491
8492 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8493 All users changed.
8494
8495 * ccl.c (Fccl_execute_on_string): Declare some variables
8496 EMACS_INT.
8497
8546720e 84982011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8499
8500 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8501
4e19a977
CS
85022011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8503
8504 * process.c (Fformat_network_address): Doc fix.
8505
87302331
R
85062011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8507
ee7683eb 8508 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8509
cbb59342
CY
85102011-04-08 Chong Yidong <cyd@stupidchicken.com>
8511
8512 * keyboard.c (read_char): Call Lisp function help-form-show,
8513 instead of using internal_with_output_to_temp_buffer.
8514 (Qhelp_form_show): New var.
e0d38eeb 8515 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8516
8517 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8518
8519 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8520
e67a13ab
CY
85212011-04-06 Chong Yidong <cyd@stupidchicken.com>
8522
04f2d78b
CB
8523 * process.c (Flist_processes): Remove to Lisp.
8524 (list_processes_1): Delete.
e67a13ab 8525
973f782d
EZ
85262011-04-06 Eli Zaretskii <eliz@gnu.org>
8527
7c106b1e
EZ
8528 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8529
973f782d
EZ
8530 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8531
41cf7d1a 85322011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8533
ca23cc88
PE
8534 Fix more problems found by GCC 4.6.0's static checks.
8535
f390e2d5
PE
8536 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8537
42eea0d0
PE
8538 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8539
b69769da 8540 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8541
f9541e84
PE
8542 * xdisp.c (vmessage): Mark as a printf-like function.
8543
13841b55
PE
8544 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8545
c136c10f
PE
8546 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8547
5e2d4a30
PE
8548 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8549 printf-like functions.
8550 (tiff_load): Add casts to remove these marks before passing them
8551 to system-supplied API.
8552
583f48b9
PE
8553 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8554
b25d760e
PE
8555 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8556 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8557 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8558 directly, rather than having caller test rule sign. This avoids
8559 some unnecessary tests.
8560 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8561 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8562 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8563
bc7b6697 8564 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8565 (xfont_open): Avoid unnecessary tests.
bc7b6697 8566
27ccc379
PE
8567 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8568
dcd5c89a
PE
8569 * composite.h, composite.c (composition_gstring_put_cache):
8570 Use EMACS_INT, not int, for length.
8571
b13a45c6
PE
8572 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8573 breaking out part of COMPOSITION_DECODE_RULE.
8574 (COMPOSITION_DECODE_RULE): Use it.
8575 * composite.c (get_composition_id): Remove unused local vars,
8576 by using the new macro.
8577
1e792e4d
PE
8578 * textprop.c (set_text_properties_1): Change while to do-while,
8579 since the condition is always true at first.
8580
dc6c6455 8581 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8582 (interval_deletion_adjustment): Return unsigned value.
8583 All uses changed.
dc6c6455 8584
aba7731a
PE
8585 * process.c (list_processes_1, create_pty, read_process_output):
8586 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8587 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8588 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8589 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8590 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8591
fdfc4bf3
PE
8592 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8593
fca8fe46 8594 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8595 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8596
06a0259a 8597 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8598 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8599 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8600
e7b9e80f
PE
8601 * print.c (print_error_message): Avoid int overflow.
8602
56201685
PE
8603 * font.c (font_list_entities): Redo for clarity,
8604 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8605
78834453 8606 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8607 (font_score): Avoid potential overflow in diff calculation.
78834453 8608
0bc0b309 8609 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8610 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8611
e610eaca
PE
8612 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8613
b895abce
PE
8614 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8615 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8616 can always succeed if overflow has undefined behavior.
8617
1f1d9321 8618 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8619 (wordify): Omit three unnecessary tests.
1f1d9321 8620
c59478bc
PE
8621 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8622 All callers changed. This avoids the need for an unused var.
8623
79b73827
PE
8624 * casefiddle.c (casify_region): Remove var that is set but not used.
8625
a4db5dfe
PE
8626 * dired.c (file_name_completion): Remove var that is set but not used.
8627
43aae36e
PE
8628 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8629
2a47c44d 8630 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8631 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8632
a37c69bf
PE
8633 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8634 Check for integer overflow on size calculations.
8635
328ab8e7
PE
8636 * buffer.c (Fprevious_overlay_change): Remove var that is set
8637 but not used.
8638
e5a2a5cb
PE
8639 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8640 Remove vars that are set but not used.
8d84a6eb 8641 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8642 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8643
a60e5f68
PE
8644 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8645
f661cb61 8646 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8647 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8648
f0397f5a
PE
8649 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8650 that are set but not used.
8651
8664db06 8652 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8653 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8654
6abdaa4a
PE
8655 * xselect.c (x_get_local_selection, x_handle_property_notify):
8656 Remove vars that are set but not used.
8657
0ce7538d 8658 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8659 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8660
9ae848fc
PE
8661 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8662 Remove var that is set but not used.
0b918413
PE
8663 (scroll_bar_windows_size): Now size_t, not int.
8664 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8665 Check for overflow.
9ae848fc 8666
a5a62657
PE
8667 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8668 (map_tty_color) [!defined MSDOS]: Likewise.
8669
5c5cdd39
PE
8670 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8671
66ebf983
PE
8672 * coding.c: Remove vars that are set but not used.
8673 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8674 All callers changed.
8675 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8676 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8677 (decode_coding_charset): Remove vars that are set but not used.
8678
1be4d761
PE
8679 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8680 that is set but not used.
8681
47553fa8
PE
8682 * print.c (print_object): Remove var that is set but not used.
8683
1f7196bf 8684 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8685 The gnulib version avoids calling malloc in the usual case,
8686 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8687 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8688 * filelock.c (current_lock_owner): Likewise.
8689 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8690 * sysdep.c: Include allocator.h, careadlinkat.h.
8691 (emacs_no_realloc_allocator): New static constant.
8692 (emacs_readlink): New function.
fdb61804
PE
8693 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8694 ../lib/careadlinkat.h.
d1fdcab7 8695
f84c17c7
SM
86962011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8697
8698 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8699 first non-nil return value).
8700
ef3862ad
JD
87012011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8702
8703 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8704 if not defined (Bug#8403).
8705
376a7006
JB
87062011-04-02 Juanma Barranquero <lekktu@gmail.com>
8707
8708 * xdisp.c (display_count_lines): Remove parameter `start',
8709 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8710 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8711 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8712 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8713 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8714 and thereabouts. All callers changed.
8715 (get_per_char_metric): Remove parameter `f', unused since
8716 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8717
6ca3801d
JM
87182011-04-02 Jim Meyering <meyering@redhat.com>
8719
8720 do not dereference NULL upon failed strdup
8721 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8722 (ns_get_family): Likewise.
8723
d8e2b5ba
JB
87242011-04-02 Juanma Barranquero <lekktu@gmail.com>
8725
8726 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8727
8c74fcbd
JD
87282011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8729
8730 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8731 later (Bug#8403).
8732
7200d79c
SM
87332011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8734
03408648 8735 Add lexical binding.
7200d79c 8736
03408648
SM
8737 * window.c (Ftemp_output_buffer_show): New fun.
8738 (Fsave_window_excursion):
8739 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8740
8741 * lread.c (lisp_file_lexically_bound_p): New function.
8742 (Fload): Bind Qlexical_binding.
8743 (readevalloop): Remove `evalfun' arg.
8744 Bind Qinternal_interpreter_environment.
8745 (Feval_buffer): Bind Qlexical_binding.
8746 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8747 Mark as dynamic.
8748 (syms_of_lread): Declare `lexical-binding'.
8749
8750 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8751
8752 * keyboard.c (eval_dyn): New fun.
8753 (menu_item_eval_property): Use it.
ca105506
SM
8754
8755 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8756
03408648
SM
8757 * fns.c (concat, mapcar1): Accept byte-code-functions.
8758
8759 * eval.c (Fsetq): Handle lexical vars.
8760 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8761 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8762 (FletX, Flet): Obey lexical binding.
8763 (Fcommandp): Handle closures.
8764 (Feval): New `lexical' arg.
8765 (eval_sub): New function extracted from Feval. Use it almost
8766 everywhere where Feval was used. Look up vars in lexical env.
8767 Handle closures.
8768 (Ffunctionp): Move from subr.el.
8769 (Ffuncall): Handle closures.
8770 (apply_lambda): Remove `eval_flags'.
8771 (funcall_lambda): Handle closures and new byte-code-functions.
8772 (Fspecial_variable_p): New function.
8773 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8774 but without exporting it to Lisp.
23aba0ea 8775
23aba0ea 8776 * doc.c (Fdocumentation, store_function_docstring):
03408648 8777 * data.c (Finteractive_form): Handle closures.
23aba0ea 8778
03408648
SM
8779 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8780 interactive spec.
ba83908c 8781
04f2d78b
CB
8782 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8783 New byte-codes.
03408648
SM
8784 (exec_byte_code): New function extracted from Fbyte_code to handle new
8785 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8786
03408648 8787 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8788
03408648 8789 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8790
e2abce01
JB
87912011-03-31 Juanma Barranquero <lekktu@gmail.com>
8792
8793 * xdisp.c (redisplay_internal): Fix prototype.
8794
63696a73 87952011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8796
63696a73 8797 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8798 (try_scrolling): Use it when setting scroll_limit.
8799 Limit scrolling to 100 screen lines.
63696a73
EZ
8800 (redisplay_window): Even when falling back on "recentering",
8801 position point in the window according to scroll-conservatively,
8802 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8803
8804 (try_scrolling): When point is above the window, allow searching
8805 as far as scroll_max, or one screenful, to compute vertical
8806 distance from PT to the scroll margin position. This prevents
8807 try_scrolling from unnecessarily failing when
8808 scroll-conservatively is set to a value slightly larger than the
8809 window height. Clean up the case of PT below the margin at bottom
8810 of window: scroll_max can no longer be INT_MAX. When aggressive
8811 scrolling is in use, don't let point enter the opposite scroll
8812 margin as result of the scroll.
8813 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8814 threshold of 100 lines for never-recentering scrolling.
8815
e4cc2dfc
JB
88162011-03-31 Juanma Barranquero <lekktu@gmail.com>
8817
8818 * dispextern.h (move_it_by_lines):
8819 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8820 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8821 (message_log_check_duplicate): Remove parameters `prev_bol' and
8822 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8823 (redisplay_internal): Remove parameter `preserve_echo_area',
8824 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8825
8826 * indent.c (Fvertical_motion):
8827 * window.c (window_scroll_pixel_based, Frecenter):
8828 Don't pass `need_y_p' to `move_it_by_lines'.
8829
1c470562
SM
88302011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8831
44f230aa
SM
8832 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8833 steal a few bits to be more compact.
8834 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8835 Remove unneeded casts.
8836
1c470562
SM
8837 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8838
888adce9
ZK
88392011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8840
8841 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8842 binding" message (bug#7967).
8843
f838ed7b
PE
88442011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8845
77861b95
PE
8846 Fix more problems found by GCC 4.6.0's static checks.
8847
de6dbc14
PE
8848 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8849 Remove unused local var.
8850
f838ed7b
PE
8851 * editfns.c (Fmessage_box): Remove unused local var.
8852
792c7b2b
PE
8853 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8854 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8855 Omit unused local vars.
c499e557 8856 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8857 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8858 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8859 Omit unused local var.
8860
ba0165e1
PE
8861 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8862 Don't assume string length fits in int.
32ad8845 8863 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8864 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8865
3c59b4c9
PE
8866 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8867 instead of alloca (Bug#8344).
8868
a3eed478 8869 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8870 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8871
eb4d412d
PE
8872 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8873
1658b401
PE
8874 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8875 concerns.
8876
8877 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8878
8879 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8880
9a2c6e05
PE
8881 * keyboard.c (syms_of_keyboard): Use the same style as later
8882 in this function when indexing through an array. This also
8883 works around GCC bug 48267.
8884
03d0a109
PE
8885 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8886
44f730c8
PE
8887 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8888
fe75f926
PE
8889 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8890 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8891
ffa8c828
PE
8892 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8893 This avoids undefined behavior on integer overflow, and is a bit
8894 more convenient anyway since it is compared to a size_t variable.
8895
c5101a77
PE
8896 Variadic C functions now count arguments with size_t, not int.
8897 This avoids an unnecessary limitation on 64-bit machines, which
8898 caused (substring ...) to crash on large vectors (Bug#8344).
8899 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8900 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8901 All variadic functions and their callers changed accordingly.
c5101a77
PE
8902 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8903 * data.c (arith_driver, float_arith_driver): Likewise.
8904 * editfns.c (general_insert_function): Likewise.
8905 * eval.c (struct backtrace.nargs, interactive_p)
8906 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8907 (funcall_lambda, mark_backtrace): Likewise.
8908 * fns.c (concat): Likewise.
8909 * frame.c (x_set_frame_parameters): Likewise.
8910 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8911 0 if not found, not -1. All callers changed.
8912
dd3f25f7
PE
8913 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8914 (stack_copy_size): Now size_t, not int.
8915 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8916
461c2ab9
JB
89172011-03-28 Juanma Barranquero <lekktu@gmail.com>
8918
8919 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8920 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8921 All callers changed.
8922
8923 * lisp.h (multibyte_char_to_unibyte):
8924 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8925 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8926 * character.h (CHAR_TO_BYTE8):
8927 * cmds.c (internal_self_insert):
8928 * editfns.c (general_insert_function):
8929 * keymap.c (push_key_description):
8930 * search.c (Freplace_match):
8931 * xdisp.c (message_dolog, set_message_1): All callers changed.
8932
f6d62986
SM
89332011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8934
8935 * keyboard.c (safe_run_hook_funcall): New function.
8936 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8937 don't set the hook to nil, but remove the offending function instead.
8938 (Qcommand_hook_internal): Remove, unused.
8939 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8940 Vcommand_hook_internal.
8941
8942 * eval.c (enum run_hooks_condition): Remove.
8943 (funcall_nil, funcall_not): New functions.
8944 (run_hook_with_args): Call each function through a `funcall' argument.
8945 Remove `cond' argument, now redundant.
8946 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8947 (Frun_hook_with_args_until_failure): Adjust accordingly.
8948 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8949
1db5b1ad
JB
89502011-03-28 Juanma Barranquero <lekktu@gmail.com>
8951
8952 * dispextern.h (string_buffer_position): Remove declaration.
8953
8954 * print.c (strout): Remove parameter `multibyte', unused since
8955 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8956
8957 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8958 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8959 All callers changed.
8960
8961 * w32.c (_wsa_errlist): Use braces for struct initializers.
8962
8963 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8964 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8965 All callers changed.
8966 (string_buffer_position): Likewise. Also, make static (it's never
8967 used outside xdisp.c).
8968 (cursor_row_p): Remove parameter `w', unused since
8969 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8970 (decode_mode_spec): Remove parameter `precision', introduced during
8971 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8972 All callers changed.
8973
5ffb62aa
JD
89742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8975
8976 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8977
461c2ab9 89782011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8979
8980 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8981 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8982 (ns_update_auto_hide_menu_bar): New functions.
8983 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8984 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8985 ns_constrain_all_frames.
8986 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8987 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8988
5c380ffb
JD
89892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8990
8991 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8992
9af30bdf
GM
89932011-03-27 Glenn Morris <rgm@gnu.org>
8994
8995 * syssignal.h: Replace RETSIGTYPE with void.
8996 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8997 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8998 Replace SIGTYPE with void everywhere.
8999 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9000 * s/template.h (SIGTYPE): Remove commented out definition.
9001
e2abce01
JB
90022011-03-26 Eli Zaretskii <eliz@gnu.org>
9003
9004 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9005 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9006
f868cd8a
JB
90072011-03-26 Juanma Barranquero <lekktu@gmail.com>
9008
59eb0929
JB
9009 * w32.c (read_unc_volume): Use parameter `henum', instead of
9010 global variable `wget_enum_handle'.
9011
9012 * keymap.c (describe_vector): Remove parameters `indices' and
9013 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9014 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9015
f868cd8a
JB
9016 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9017
9018 * keyboard.c (timer_check): Remove parameter `do_it_now',
9019 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9020 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9021 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9022
9023 * keyboard.c (read_char):
9024 * w32menu.c (w32_menu_display_help):
9025 * xmenu.c (show_help_event, menu_help_callback):
9026 Adjust calls to `show_help_echo'.
9027
9028 * gtkutil.c (xg_maybe_add_timer):
9029 * keyboard.c (readable_events):
9030 * process.c (wait_reading_process_output):
9031 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9032
9033 * insdel.c (adjust_markers_gap_motion):
9034 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9035 (gap_left, gap_right): Don't call it.
9036
2ecf6fdb
CY
90372011-03-25 Chong Yidong <cyd@stupidchicken.com>
9038
9039 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9040 incurred during fontification.
9041
6b1f9ba4
JB
90422011-03-25 Juanma Barranquero <lekktu@gmail.com>
9043
9044 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9045 (DEFVAR_PER_BUFFER): Don't pass it.
9046
9047 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9048 (scrolling_window): Don't pass it.
9049
0f4a96b5
JB
90502011-03-25 Juanma Barranquero <lekktu@gmail.com>
9051
9052 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9053
9054 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9055 and `suffix'.
9056 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9057 of variables specific to SELinux and computation of `encoded_absname'.
9058
9059 * image.c (XPutPixel): Remove unused variable `height'.
9060
9061 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9062
9063 * unexw32.c (get_section_info): Remove unused variable `section'.
9064
9065 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9066 (system_process_attributes): Remove unused variable `sess'.
9067 (sys_read): Remove unused variable `err'.
9068
9069 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9070 (w32_wnd_proc): Remove unused variable `isdead'.
9071 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9072 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9073 (x_create_tip_frame): Remove unused variable `tem'.
9074
9075 * w32inevt.c (w32_console_read_socket):
9076 Remove unused variable `no_events'.
9077
9078 * w32term.c (x_draw_composite_glyph_string_foreground):
9079 Remove unused variable `width'.
9080
1149507c
JB
90812011-03-24 Juanma Barranquero <lekktu@gmail.com>
9082
9083 * w32term.c (x_set_glyph_string_clipping):
9084 Don't pass uninitialized region to CombineRgn.
9085
9c88f339
JB
90862011-03-23 Juanma Barranquero <lekktu@gmail.com>
9087
9088 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9089 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9090 (Fx_close_connection): Remove unused variable `i'.
9091
9092 * w32font.c (w32font_draw): Return number of glyphs.
9093 (w32font_open_internal): Remove unused variable `i'.
9094 (w32font_driver): Add missing initializer.
9095
9096 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9097 (fill_in_menu): Remove unused variable `items_added'.
9098
9099 * w32term.c (last_mouse_press_frame): Remove static global variable.
9100 (w32_clip_to_row): Remove unused variable `f'.
9101 (x_delete_terminal): Remove unused variable `i'.
9102
9103 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9104 (NOTHING): Remove unused static global variable.
9105 (uniscribe_check_otf): Remove unused variable `table'.
9106 (uniscribe_font_driver): Add missing initializers.
9107
dee091a3
JD
91082011-03-23 Julien Danjou <julien@danjou.info>
9109
9110 * term.c (Fsuspend_tty, Fresume_tty):
9111 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9112 * window.c (temp_output_buffer_show):
9113 * insdel.c (signal_before_change):
9114 * frame.c (Fhandle_switch_frame):
9115 * fileio.c (Fdo_auto_save):
9116 * emacs.c (Fkill_emacs):
9117 * editfns.c (save_excursion_restore):
9118 * cmds.c (internal_self_insert):
9119 * callint.c (Fcall_interactively):
9120 * buffer.c (Fkill_all_local_variables):
9121 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9122 Use Frun_hooks.
0f4a96b5 9123 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9124 unconditionally since it does the check itself.
dee091a3 9125
2c520ab5 91262011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9127
c9c49752
PE
9128 Fix more problems found by GCC 4.5.2's static checks.
9129
8abc3f12
PE
9130 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9131 the first time through the loop, since we know p0 < p1 then.
9132 This also avoids a gcc -Wstrict-overflow warning.
9133
a2d26660
PE
9134 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9135 leading to a memory leak, possible in functions like
9136 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9137 of objects (Bug#8318).
a2d26660 9138
916c72e9
PE
9139 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9140 that could (at least in theory) be that large.
9141
19ab8a18
PE
9142 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9143 This is less likely to overflow, and avoids undefined behavior if
9144 overflow does occur. All callers changed. Use strtoul to scan
9145 for the unsigned long integer.
b7cbbd6f
PE
9146 (pint2hrstr): Simplify and tune code slightly.
9147 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9148
f0641eff
PE
9149 * scroll.c (do_scrolling): Work around GCC bug 48228.
9150 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9151
7f650bb9
PE
9152 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9153 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9154 (validate_x_resource_name): Simplify count usage.
9155 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9156
37dd57d1
PE
9157 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9158 fail (Bug#8306).
81e56e61 9159
699979fc 9160 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9161
401bf9b4
PE
9162 * process.c (Fmake_network_process): Use socklen_t, not int,
9163 where POSIX says socklen_t is required in portable programs.
9164 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9165 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9166 (Fmake_network_process, server_accept_connection):
9167 (wait_reading_process_output, read_process_output):
9168 Likewise.
9169
b93aacde
PE
9170 * process.c: Rename or move locals to avoid shadowing.
9171 (list_processes_1, Fmake_network_process):
9172 (read_process_output_error_handler, exec_sentinel_error_handler):
9173 Rename or move locals.
4dc343ee 9174 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9175 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9176 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9177 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9178 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9179
af8a867c 9180 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9181 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9182 Include tparam.h instead, since it declares them.
af8a867c
PE
9183 * cm.h (PC): Remove extern decl; tparam.h now does this.
9184 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9185 * terminfo.c: Include tparam.h, to check interfaces.
9186 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9187 (tparam): Adjust signature to match interface in tparam.h;
9188 this removes some undefined behavior. Check that outstring and len
9189 are zero, which they always are with Emacs.
9190 * tparam.h (PC, BC, UP): New extern decls.
9191
0248044d 9192 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9193 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9194
8ff096c1 9195 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9196 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9197 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9198 (ftfont_list): Remove unused local.
49eaafba
PE
9199 (get_adstyle_property, ftfont_pattern_entity):
9200 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9201 Rename locals to avoid shadowing.
8ff096c1 9202
e2be39f6
PE
9203 * xfont.c (xfont_list_family): Mark var as initialized.
9204
c9735e30
PE
9205 * xml.c (make_dom): Now static.
9206
8f5201ae
PE
9207 * composite.c (composition_compute_stop_pos): Rename local to
9208 avoid shadowing.
b246f932
PE
9209 (composition_reseat_it): Remove unused locals.
9210 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9211 (composition_update_it): Mark var as initialized.
11b61122
PE
9212 (find_automatic_composition): Mark vars as initialized,
9213 with a FIXME (Bug#8290).
8f5201ae 9214
760fbc2c
PE
9215 character.h: Rename locals to avoid shadowing.
9216 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9217 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9218 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9219 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9220 to avoid shadowing.
9221
ff08eb85
PE
9222 * textprop.c (property_change_between_p): Remove; unused.
9223
fc7bf025
PE
9224 * intervals.c (interval_start_pos): Now static.
9225
235d7abc
PE
9226 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9227
44f230aa
SM
9228 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9229 Rename locals to avoid shadowing.
3e7d6594 9230
50060332
PE
9231 * sound.c (wav_play, au_play, Fplay_sound_internal):
9232 Fix pointer signedness.
d01f234b 9233 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9234 (wav_play): Initialize a variable to 0, to prevent undefined
9235 behavior (Bug#8278).
50060332 9236
c4fc4e30
PE
9237 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9238
918436ed
PE
9239 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9240
c939f91b
PE
9241 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9242 clobbering (Bug#8298).
b9c7f648
PE
9243 * sysdep.c (sys_subshell): Likewise.
9244 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9245
6bd8c144
PE
9246 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9247 This should get cleaned up, so that child_setup has the
9248 same signature on all platforms.
9249
7710357c 9250 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9251 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9252
c59da222
CY
92532011-03-22 Chong Yidong <cyd@stupidchicken.com>
9254
9255 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9256 not to be necessary, and produces flickering.
9257
66b87493
GM
92582011-03-20 Glenn Morris <rgm@gnu.org>
9259
9260 * config.in: Remove file.
9261
45b6f6d5
JB
92622011-03-20 Juanma Barranquero <lekktu@gmail.com>
9263
9264 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9265 are now in src/globals.h.
9266 (syms_of_minibuf): Remove spurious & from previous change.
9267
cd394be1 92682011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9269
9270 * minibuf.c (completing-read-function): New variable.
9271 (completing-read-default): Rename from completing-read.
9272 (completing-read): Call completing-read-function.
9273
b14e3e21
CY
92742011-03-19 Juanma Barranquero <lekktu@gmail.com>
9275
9276 * xfaces.c (Fx_load_color_file):
9277 Read color file from absolute filename (bug#8250).
9278
f2b726e6
JB
92792011-03-19 Juanma Barranquero <lekktu@gmail.com>
9280
9281 * makefile.w32-in: Update dependencies.
9282
09f6ff02
EZ
92832011-03-17 Eli Zaretskii <eliz@gnu.org>
9284
9285 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9286
29a6015a
PE
92872011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9288
a3a6c54e
PE
9289 Fix more problems found by GCC 4.5.2's static checks.
9290
b766f867
PE
9291 * process.c (make_serial_process_unwind, send_process_trap):
9292 (sigchld_handler): Now static.
9293
be02381c
PE
9294 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9295 That way, the code declares only the vars that it needs.
9296 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9297 * s/cygwin.h (PTY_ITERATION): Likewise.
9298 * s/darwin.h (PTY_ITERATION): Likewise.
9299 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9300
57048744
PE
9301 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9302 * process.c (allocate_pty): Don't declare stb unless it's needed.
9303
7914961c 9304 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9305 (CONSTANTLIM): Remove; unused.
9306 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9307 Define only if needed.
7914961c 9308
b3967b18
PE
9309 * unexelf.c (unexec): Name an expression,
9310 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9311 Use a different way to cause a compilation error if anyone uses
9312 n rather than nn, a way that does not involve shadowing.
73366a00 9313 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9314
29a6015a
PE
9315 * deps.mk (unexalpha.o): Remove; unused.
9316
43cfc33e 9317 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9318 * unexec.h: New file.
ce701a33
PE
9319 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9320 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9321 Depend on unexec.h.
9322 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9323 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9324 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9325 Change as necessary to match prototype in unexec.h.
ce701a33 9326
01f44d5a
PE
9327 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9328 shadowing.
4f63c6bb 9329 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9330
a6670b0b
PE
9331 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9332 Rename locals to avoid shadowing.
9333
cef2010d 9334 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9335 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9336
d4d7173a
PE
9337 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9338
f08b802a
PE
9339 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9340 warning when compiling print.c.
9341
3ddb0639
PE
9342 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9343 instead of using an uninitialized var.
5ad03b97 9344 (font_sort_entities): Mark var as initialized.
3ddb0639 9345
170a2692
PE
9346 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9347
e663c700
PE
9348 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9349 pointers to constants.
89bc529a 9350 (font_parse_fcname): Remove unused vars.
7b81e2d0 9351 (font_delete_unmatched): Now static.
ea838e10 9352 (font_get_spec): Remove; unused.
13a547c6
PE
9353 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9354 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9355 Rename or move locals to avoid shadowing.
e663c700 9356
2a80c887 9357 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9358 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9359
1384fa33 9360 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9361 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9362
8b2c52e9
PE
9363 * alloc.c (mark_backtrace): Move decl from here ...
9364 * lisp.h: ... to here, so that it can be checked.
9365
475545b5 9366 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9367 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9368 (lisp_indirect_variable): Name an expression,
9369 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9370 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9371
b1349114 9372 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9373 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9374 Use const pointer when appropriate.
b1349114 9375
a2928364
PE
9376 * lisp.h (get_system_name, get_operating_system_release):
9377 Move decls here, to check interfaces.
9378 * process.c (get_operating_system_release): Move decl to lisp.h.
9379 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9380 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9381 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9382 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9383 (Fformat_time_string, Fencode_time, Finsert_char):
9384 (Ftranslate_region_internal, Fformat):
9385 Rename or remove local vars to avoid shadowing.
9710023e 9386 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9387
a415e694
PE
9388 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9389 avoid shadowing.
9390
8ef4622d
PE
9391 * lisp.h (eassert): Check that the argument compiles, even if
9392 ENABLE_CHECKING is not defined.
9393
946f9a5b
PE
9394 * data.c (Findirect_variable): Name an expression, to avoid
9395 gcc -Wbad-function-cast warning.
112396d6 9396 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9397 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9398 (Fmake_variable_buffer_local, Fmake_local_variable):
9399 Mark variables as initialized.
52746918 9400 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9401
e5aab7e7 9402 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9403 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9404 Rename locals to avoid shadowing.
dff45157
PE
9405 (mark_stack): Move local variables into the #ifdef region where
9406 they're used.
7bc26fdb
PE
9407 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9408 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9409 needed otherwise.
9410 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9411 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9412 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9413
e5aab7e7
PE
9414 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9415 avoids undefined behavior in theory.
9416
4da60324
PE
9417 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9418
88043301
PE
9419 Use functions, not macros, for up- and down-casing (Bug#8254).
9420 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9421 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9422 to use the following functions instead of these macros.
9423 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9424 EMACS_INT, since callers assume the returned value fits in int.
9425 (upcase1): Likewise, for UPCASE_TABLE.
9426 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9427 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9428 the race-condition problem in the old DOWNCASE.
88043301 9429
19ed5445
PE
9430 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9431 Rename locals to avoid shadowing.
9432 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9433 (regex_compile, re_search_2, re_match_2_internal):
9434 Remove unused local vars.
952db0d7
PE
9435 (FREE_VAR): Rewrite so as not to use empty "else",
9436 which gcc can warn about.
da053e48 9437 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9438 (RETALLOC_IF): Define only if needed.
9439 (WORDCHAR_P): Likewise. This one is never needed, but is used
9440 only in a comment talking about a compiler bug, so put inside
9441 the #if 0 of that comment.
9442 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9443 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9444 Remove; unused.
19ed5445 9445
1f3561e4 9446 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9447 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9448 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9449
ded6f8f7
PE
9450 * search.c (simple_search): Remove unused var.
9451
dbd37a95
PE
9452 * dired.c (compile_pattern): Move decl from here ...
9453 * lisp.h: ... to here, so that it can be checked.
9454 (struct re_registers): New forward decl.
9455
7e47afad
PE
9456 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9457
85f24f61
PE
9458 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9459 All uses changed.
9460 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9461 Rename locals to avoid shadowing.
5671df8f 9462 (Fvertical_motion): Mark locals as initialized.
85f24f61 9463
181aa2be 9464 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9465 (casify_region): Mark local as initialized.
181aa2be 9466
930d429c
PE
9467 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9468
7082eac6
PE
9469 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9470 New macros, so that the caller can use some names other than
9471 gcpro1, gcpro2, etc.
9472 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9473 of the new macros.
9474 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9475 argument, for consistency with GCPRO2_VAR, etc: it is now the
9476 prefix of the variable, not the variable itself. All uses
9477 changed.
38b2c076
PE
9478 * dired.c (directory_files_internal, file_name_completion):
9479 Rename locals to avoid shadowing.
9480
15206ed9
PE
9481 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9482 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9483 dired.c's scmp function, had undefined behavior.
9484 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9485 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9486 * buffer.h: ... to here, because these macros use current_buffer,
9487 and the new implementation with inline functions needs to have
9488 current_buffer in scope now, rather than later when the macros
9489 are used.
9490 (downcase, upcase1): New static inline functions.
9491 (DOWNCASE, UPCASE1): Reimplement using these functions.
9492 This avoids undefined behavior in expressions like
9493 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9494 from race conditions in accessing the global variables
9495 case_temp1 and case_temp2.
9496 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9497 * lisp.h (case_temp1, case_temp2): Remove their decls.
9498 * character.h (ASCII_CHAR_P): Move from here ...
9499 * lisp.h: ... to here, so that the inline functions mentioned
9500 above can use them.
9501
4a6bea26
PE
9502 * dired.c (directory_files_internal_unwind): Now static.
9503
f14b7e14
PE
9504 * fileio.c (file_name_as_directory, directory_file_name):
9505 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9506 Now static.
2893f146
PE
9507 (file_name_as_directory): Use const pointers when appropriate.
9508 (Fexpand_file_name): Likewise. In particular, newdir might
9509 point at constant storage, so make it a const pointer.
fd4ead52 9510 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9511 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9512 signedness issues.
f839df0c
PE
9513 (Fset_file_times, Finsert_file_contents, auto_save_error):
9514 Rename locals to avoid shadowing.
f14b7e14 9515
5716756e 9516 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9517 (Ftry_completion, Fall_completions): Rename or remove locals
9518 to avoid shadowing.
5716756e 9519
b4c3046a
PE
9520 * marker.c (bytepos_to_charpos): Remove; unused.
9521
b45db522
PE
9522 * lisp.h (verify_bytepos, count_markers): New decls,
9523 so that gcc does not warn that these functions aren't declared.
9524
85876d07
PE
9525 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9526 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9527 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9528 (copy_text): Remove unused local var.
85876d07 9529
03d78a21 9530 * filelock.c (within_one_second): Now static.
b3dd38ab 9531 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9532
5df8f01b
PE
9533 * buffer.c (fix_overlays_before): Mark locals as initialized.
9534 (fix_start_end_in_overlays): Likewise. This function should be
9535 simplified by using pointers-to-pointers, but that's a different
9536 matter.
b1d876f1 9537 (switch_to_buffer_1): Now static.
8f54f30a
PE
9538 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9539 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9540
a70072c9 9541 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9542 Fix pointer signedness issue.
edced198
PE
9543 (sys_subshell): Mark local as volatile if checking for lint,
9544 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9545 (MAXPATHLEN): Define only if needed.
a70072c9 9546
a0977c44
PE
9547 * process.c (serial_open, serial_configure): Move decls from here ...
9548 * systty.h: ... to here, so that they can be checked.
9549
a884fdcc
PE
9550 * fns.c (get_random, seed_random): Move extern decls from here ...
9551 * lisp.h: ... to here, so that they can be checked.
9552
604efe86 9553 * sysdep.c (reset_io): Now static.
b8950c94 9554 (wait_for_termination_signal): Remove; unused.
604efe86 9555
38fc62d9
PE
9556 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9557 (copy_keymap_item, append_key, push_text_char_description):
9558 Now static.
1004a21a 9559 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9560 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9561 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9562 (describe_map_tree):
9563 Rename locals to avoid shadowing.
38fc62d9 9564
2f2650da
PE
9565 * keyboard.c: Declare functions static if they are not used elsewhere.
9566 (echo_char, echo_dash, cmd_error, top_level_2):
9567 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9568 (read_char, kbd_buffer_get_event, make_lispy_position):
9569 (make_lispy_event, make_lispy_movement, apply_modifiers):
9570 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9571 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9572 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9573 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9574 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9575
a053e86c 9576 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9577 (mark_kboards): Move decl here ...
9578 * alloc.c (mark_kboards): ... from here.
a053e86c 9579
4752793e
PE
9580 * lisp.h (force_auto_save_soon): New decl.
9581
74f10ca7 9582 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9583 (DEFINE_DUMMY_FUNCTION): New macro.
9584 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9585 Use it.
c03cd23f
PE
9586 (main): Add casts to avoid warnings
9587 if GCC considers string literals to be constants.
74f10ca7 9588
022e70d4
PE
9589 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9590
59d6fe83
PE
9591 * dbusbind.c: Pointer signedness fixes.
9592 (xd_signature, xd_append_arg, xd_initialize):
9593 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9594 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9595 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9596 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9597
78320123
PE
9598 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9599 if GCC considers string literals to be constants.
49cebcca 9600 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9601
35ac2a97
SM
96022011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9603
fb103ca9
SM
9604 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9605 (print_preprocess, print_object): New macro to fix last change.
9606
35ac2a97
SM
9607 * print.c (print_preprocess): Don't forget font objects.
9608
62973b41
JB
96092011-03-16 Juanma Barranquero <lekktu@gmail.com>
9610
9611 * emacs.c (USAGE3): Doc fixes.
9612
0e48bb22
AS
96132011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9614
9615 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9616 structure.
9617
7684e57b
JB
96182011-03-14 Juanma Barranquero <lekktu@gmail.com>
9619
9620 * lisp.h (VWindow_system, Qfile_name_history):
9621 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9622 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9623 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9624
9625 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9626 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9627
9628 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9629 * w32console.c (detect_input_pending, read_input_pending)
9630 (encode_terminal_code):
9631 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9632 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9633 (w32_system_caret_y, Qfile_name_history):
9634 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9635 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9636 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9637 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9638 * w32proc.c (Qlocal, report_file_error):
9639 * w32term.c (Vwindow_system, updating_frame):
9640 * w32uniscribe.c (initialized, uniscribe_font_driver):
9641 Remove unneeded extern declarations.
9642
2aa46d6c
CY
96432011-03-14 Chong Yidong <cyd@stupidchicken.com>
9644
c96bbc66 9645 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9646
cffc6f3b
CY
96472011-03-13 Chong Yidong <cyd@stupidchicken.com>
9648
9649 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9650 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9651 These macros can no longer be used for assignment.
9652
44f230aa
SM
9653 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9654 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9655 (record_buffer_markers, fetch_buffer_markers): New functions for
9656 recording and fetching special buffer markers.
9657 (set_buffer_internal_1, set_buffer_temp): Use them.
9658
9659 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9660
9661 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9662
9663 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9664 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9665
9666 * xdisp.c (hscroll_window_tree):
9667 (reconsider_clip_changes): Use PT instead of BUF_PT.
9668
d251f04b
EZ
96692011-03-13 Eli Zaretskii <eliz@gnu.org>
9670
9671 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9672 $(EMACS_ROOT)/lib/intprops.h.
9673
f0c77cd1
PE
96742011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9675
3eca4629
PE
9676 Fix more problems found by GCC 4.5.2's static checks.
9677
7c86ee98
PE
9678 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9679 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9680 (xg_free_frame_widgets): Make it clear that a local variable is
9681 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9682 (gdk_window_get_screen): Make it clear that this macro is needed
9683 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9684 (int_gtk_range_get_value): New function, which avoids a diagnostic
9685 from gcc -Wbad-function-cast.
9686 (xg_set_toolkit_scroll_bar_thumb): Use it.
9687 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9688 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9689 (get_utf8_string, xg_get_file_with_chooser):
9690 Rename locals to avoid shadowing.
9691 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9692
41729b81
PE
9693 * xgselect.c (xg_select): Remove unused var.
9694
f0c77cd1
PE
9695 * image.c (four_corners_best): Mark locals as initialized.
9696 (gif_load): Initialize transparent_p to zero (Bug#8238).
9697 Mark another local as initialized.
ec6cf4c6 9698 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9699
ce0ad53d 9700 * image.c (clear_image_cache): Now static.
d5d5a617 9701 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9702 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9703 (x_edge_detection): Remove unnecessary cast that
9704 gcc -Wbad-function-cast diagnoses.
2037898d 9705 (gif_load): Fix pointer signedness.
6ae141d6
PE
9706 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9707 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9708
33383987 97092011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9710
d32df629
PE
9711 Improve quality of tests for time stamp overflow.
9712 For example, without this patch (encode-time 0 0 0 1 1
9713 1152921504606846976) returns the obviously-bogus value (-948597
9714 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9715 reports time overflow. See
9716 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9717 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9718 * editfns.c: Include limits.h and intprops.h.
9719 (TIME_T_MIN, TIME_T_MAX): New macros.
9720 (time_overflow): Move earlier, to before first use.
9721 (hi_time, lo_time): New functions, for an accurate test for
9722 out-of-range times.
9723 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9724 (Fget_internal_run_time): Don't assume time_t fits in int.
9725 (make_time): Use list2 instead of Fcons twice.
9726 (Fdecode_time): More accurate test for out-of-range times.
9727 (check_tm_member): New function.
9728 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9729 (lisp_time_argument): Don't rely on undefined left-shift and
9730 right-shift behavior when checking for time stamp overflow.
8be6f318 9731
fe31d94c
PE
9732 * editfns.c (time_overflow): New function, refactoring common code.
9733 (Fformat_time_string, Fdecode_time, Fencode_time):
9734 (Fcurrent_time_string): Use it.
9735
8be6f318
PE
9736 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9737 * dired.c (make_time): Move to ...
9738 * editfns.c (make_time): ... here.
9739 * systime.h: Note the move.
9740
09d9db2c 97412011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9742
126bc0dc
YM
9743 * fringe.c (update_window_fringes): Remove unused variables.
9744
c47cbdfd
YM
9745 * unexmacosx.c (copy_data_segment): Also copy __got section.
9746 (Bug#8223)
9747
7ac80be9
EZ
97482011-03-12 Eli Zaretskii <eliz@gnu.org>
9749
c96bbc66 9750 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9751 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9752 Constify `char *' arguments and their references according to
9753 prototypes in tparam.h.
9754
ecb0f94d 9755 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9756
7ac80be9
EZ
9757 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9758 Adapt all references accordingly.
9759
9760 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9761
ef1fd07e
TT
97622011-03-11 Tom Tromey <tromey@redhat.com>
9763
9764 * buffer.c (syms_of_buffer): Remove obsolete comment.
9765
7ef4b50c
EZ
97662011-03-11 Eli Zaretskii <eliz@gnu.org>
9767
9768 * termhooks.h (encode_terminal_code): Declare prototype.
9769
9770 * msdos.c (encode_terminal_code): Don't declare prototype.
9771
9772 * term.c (encode_terminal_code): Now external again, used by
9773 w32console.c and msdos.c.
9774
44f230aa
SM
9775 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9776 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9777
4b1ec863 97782011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9779
1714f52b 9780 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9781
4b1ec863
PE
9782 * fringe.c (update_window_fringes): Mark locals as initialized
9783 (Bug#8227).
9784 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9785
524c7aa6
PE
9786 * alloc.c (mark_fringe_data): Move decl from here ...
9787 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9788 to check its interface.
9789 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9790
a5c0af81 9791 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9792 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9793 (fontset_font): Mark local as initialized.
a9a06e0b 9794 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9795
b4716021
PE
9796 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9797
811e9bac 9798 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9799 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9800 (x_own_selection, Fx_disown_selection_internal): Rename locals
9801 to avoid shadowing.
9802 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9803
7e3ab302
PE
9804 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9805 so that the caller can use some name other than gcpro1.
9806 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9807 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9808 (Fx_backspace_delete_keys_p):
9809 Use them to avoid shadowing, and rename vars to avoid shadowing.
9810 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9811 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9812 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9813 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9814 Remove unused locals.
7e3ab302
PE
9815 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9816 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9817 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9818 macros.
f78faa98 9819
e2b13473
PE
9820 * xterm.h (x_mouse_leave): New decl.
9821
77f23912
PE
9822 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9823 Remove unused functions.
cdf4ba58
PE
9824 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9825 (x_calc_absolute_position): Now static.
7411c686 9826 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9827 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9828 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9829 unless they are used.
38d0b34a
PE
9830 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9831 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9832 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9833 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9834 (x_error_catcher, x_connection_closed, x_error_handler):
9835 (x_error_quitter, xembed_send_message, x_iconify_frame):
9836 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9837 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9838 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9839
44f230aa
SM
9840 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9841 Rename or move locals to avoid shadowing.
6b463e58 9842 (tty_defined_color, merge_face_heights): Now static.
5967d051 9843 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9844 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9845 does not deduce is never used uninitialized.
73719eba
PE
9846 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9847 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9848
426994c3 9849 * terminal.c (store_terminal_param): Now static.
5489860b 9850
032f1620 9851 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9852 (set_frame_menubar): Remove unused local.
d4323972 9853 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9854 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9855 since they might point to immutable storage.
281585b0
PE
9856 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9857 since it's unused otherwise.
032f1620 9858
367c19e5 9859 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9860 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9861 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9862 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9863 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9864 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9865 does not deduce are never used uninitialized.
70739cbe 9866
07b48fa9
PE
9867 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9868
8868a238 9869 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9870 * window.c (window_loop, size_window):
9871 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9872
7e5cf297 9873 * window.c (display_buffer): Now static.
d6550a9f
PE
9874 (size_window): Mark variables that gcc -Wuninitialized
9875 does not deduce are never used uninitialized.
a586633d
PE
9876 * window.h (check_all_windows): New decl, to forestall
9877 gcc -Wmissing-prototypes diagnostic.
5b555da1 9878 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9879
f6095868
PE
9880 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9881 shadowing.
9882 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9883 Include <limits.h>.
9884 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9885 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9886 (load_charset_map): Mark variables that gcc -Wuninitialized
9887 does not deduce are never used uninitialized.
53df7c11 9888 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9889
f38b440c
PE
9890 * coding.c (coding_set_source, coding_set_destination):
9891 Use "else { /* comment */ }" rather than "else /* comment */;"
9892 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9893 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9894 a block, when the outer 'i' will do.
9895 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9896 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9897 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9898 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9899 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9900 Rename locals to avoid shadowing.
9901 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9902 * coding.c (emacs_mule_char, encode_invocation_designation):
9903 Now static, since they're not used elsewhere.
413bb2db 9904 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9905 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9906 (decode_coding_emacs_mule): Mark variables that gcc
9907 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9908 (detect_coding_iso_2022): Initialize a local variable that might
9909 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9910 this initialization is needed. (Bug#8211)
5f58e762
PE
9911 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9912 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9913 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9914 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9915 Remove unused macros.
f38b440c 9916
232b38b9 9917 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9918 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9919 * character.c (string_count_byte8): Likewise.
232b38b9 9920
fb90da1b
PE
9921 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9922 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9923
fb93dbc2
PE
9924 * chartab.c (copy_sub_char_table): Now static, since it's not used
9925 elsewhere.
5c156ace
PE
9926 (sub_char_table_ref_and_range, char_table_ref_and_range):
9927 Rename locals to avoid shadowing.
bbcd0949 9928 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9929
7d3b3862 9930 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9931 (BIDI_BOB): Remove unused macro.
7d3b3862 9932
6be7d3da
PE
9933 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9934 deduce are never used uninitialized.
c2ed9c8b 9935 * term.c (encode_terminal_code): Likewise.
6be7d3da 9936
75f8807f 9937 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9938
50938595
PE
9939 * tparam.h: New file.
9940 * term.c, tparam.h: Include it.
9941 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9942 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9943 Move these decls to tparam.h, and make them agree with what
9944 is actually in tparam.c. The previous trick of using incompatible
9945 decls in different modules does not conform to the C standard.
9946 All callers of tparam changed to use tparam's actual API.
9947 * tparam.c (tparam1, tparam, tgoto):
9948 Use const pointers where appropriate.
9949
fbceeba2
PE
9950 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9951 * cm.h (struct cm): Likewise.
9952 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9953 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9954 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9955 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9956 (turn_on_face, init_tty): Likewise.
9957 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9958
7f3f1250
PE
9959 * term.c (term_mouse_position): Rename local to avoid shadowing.
9960
e6ca6543
PE
9961 * alloc.c (mark_ttys): Move decl from here ...
9962 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9963
c40f8d15
AS
99642011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9965
9966 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9967
cfe0661d
JB
99682011-03-09 Juanma Barranquero <lekktu@gmail.com>
9969
9970 * search.c (compile_pattern_1): Remove argument regp, unused since
9971 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9972 (compile_pattern): Don't pass it.
9973
0afb4571
J
99742011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9975
9976 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9977 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9978 for ! HAVE_GTK3.
9979 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9980
9981 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9982
9983 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9984 gdk_window_get_screen, gdk_window_get_geometry,
9985 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9986 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9987 (xg_get_pixbuf_from_pixmap): New function.
9988 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9989 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9990 Call xg_get_pixbuf_from_pixmap instead of
9991 gdk_pixbuf_get_from_drawable.
9992 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9993 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9994 (xg_check_special_colors): Use GtkStyleContext and its functions
9995 for HAVE_GTK3.
9996 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9997 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9998 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9999 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10000 Call gtk_widget_get_preferred_size.
0afb4571
J
10001 (xg_frame_resized): gdk_window_get_geometry only takes 5
10002 parameters.
44f230aa
SM
10003 (xg_win_to_widget, xg_event_is_for_menubar):
10004 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10005 (xg_set_widget_bg): New function.
10006 (delete_cb): New function.
895009e1 10007 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10008 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10009 (xg_set_background_color): Call xg_set_widget_bg.
10010 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10011 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10012 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10013 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10014 if ! HAVE_GTK3.
10015 (update_frame_tool_bar): Call gtk_widget_hide.
10016 (xg_initialize): Use GDK_KEY_g.
10017
10018 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10019 if ! HAVE_GTK3
10020 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10021
10022 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10023 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10024 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10025
1c2cc4ef
JB
100262011-03-08 Juanma Barranquero <lekktu@gmail.com>
10027
10028 * w32xfns.c (select_palette): Check success of RealizePalette against
10029 GDI_ERROR, not zero.
10030
33383987 10031See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10032
10033;; Local Variables:
10034;; coding: utf-8
aac0c6e3
MR
10035;; End:
10036
2f097256 10037 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10038
10039 This file is part of GNU Emacs.
10040
10041 GNU Emacs is free software: you can redistribute it and/or modify
10042 it under the terms of the GNU General Public License as published by
10043 the Free Software Foundation, either version 3 of the License, or
10044 (at your option) any later version.
10045
10046 GNU Emacs is distributed in the hope that it will be useful,
10047 but WITHOUT ANY WARRANTY; without even the implied warranty of
10048 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10049 GNU General Public License for more details.
10050
10051 You should have received a copy of the GNU General Public License
10052 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.