Install self-contained ns leim files directly to their final destination
[bpt/emacs.git] / src / ChangeLog
CommitLineData
836d29b3
DA
12012-05-10 Dave Abrahams <dave@boostpro.com>
2
3 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5
5cb67954
MA
62012-05-09 Michael Albinus <michael.albinus@gmx.de>
7
8 * dbusbind.c (xd_registered_buses): New internal Lisp object.
9 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
10 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
11 Initialize xd_registered_buses.
12
3478ec45
PE
132012-05-09 Paul Eggert <eggert@cs.ucla.edu>
14
b263a6b0
PE
15 Untag more efficiently if USE_LSB_TAG.
16 This is based on a proposal by YAMAMOTO Mitsuharu in
17 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
18 For an admittedly artificial (nth 8000 longlist) benchmark on
19 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
20 Emacs's overall text size by 1%.
21 * lisp.h (XUNTAG): New macro.
22 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
23 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
24 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
25 * eval.c (Fautoload):
26 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
27 * frame.h (XFRAME): Use XUNTAG.
28
3478ec45
PE
29 Port recent dbusbind.c changes to 32-bit --with-wide-int.
30 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
31 Remove unportable assumptions about print widths of types like
32 dbus_uint32_t.
33 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
34 intptr_t when converting between pointer and integer, to avoid GCC
35 warnings about wrong width.
36
666b903b 372012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
38
39 * w32proc.c (new_child): Force Windows to reserve only 64KB of
40 stack for each reader_thread, instead of defaulting to 8MB
41 determined by the linker. This avoids failures in creating
42 subprocesses on Windows 7, see the discussion in this thread:
43 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
44
b120cc17
JC
452012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
46
47 Fix up display of the *Minibuf-0* buffer in the mini window.
48 * keyboard.c (read_char): Don't clear the echo area if there's no
49 message to clear.
50 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 51 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 52
9a4b36f8
MA
532012-05-07 Michael Albinus <michael.albinus@gmx.de>
54
55 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
56 batch mode.
57
e5f9458f
CY
582012-05-06 Chong Yidong <cyd@gnu.org>
59
60 * lisp.mk (lisp): Update.
61
eceeb5fc 622012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
63
64 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
65
71873e2b
SM
662012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
67
68 * data.c (PUT_ERROR): New macro.
69 (syms_of_data): Use it. Add new error type `user-error'.
70 * undo.c (user_error): New function.
71 (Fprimitive_undo): Use it.
72 * print.c (print_error_message): Adjust print style for `user-error'.
73 * keyboard.c (user_error): New function.
74 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
75
ab0fa4e4
PE
762012-05-03 Paul Eggert <eggert@cs.ucla.edu>
77
78 Do not limit current-time-string to years 1000..9999.
79 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
80 (Fcurrent_time_string): Support any year that is supported by the
81 underlying localtime representation. Don't use asctime, as it
82 has undefined behavior for years outside the range -999..9999.
83
7ed806a7
PE
842012-05-02 Paul Eggert <eggert@cs.ucla.edu>
85
86 Fix race conditions involving setenv, gmtime, localtime, asctime.
87 Without this fix, interrupts could mess up code that uses these
88 nonreentrant functions, since setting TZ invalidates existing
89 tm_zone or tzname values, and since most of these functions return
90 pointers to static storage.
91 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
92 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
93 Grow the critical sections to include not just invoking
94 localtime/gmtime, but also accessing these functions' results
95 including their tm_zone values if any, and any related TZ setting.
96 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
97 so that the struct tm is saved in the critical section.
98 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
99 motivated by the fact that memory allocation needs to be outside
100 the critical section.
101
0c16dfed
DA
1022012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
103
104 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
105 with RESET_INTERVAL.
106
107 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
108 Remove duplicated buffer name initialization.
109
3f83ace8
JM
1102012-05-02 Jim Meyering <jim@meyering.net>
111
112 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
113
c7b8541e
JM
114 * xfns.c (x_window): Use xstrdup (Bug#11375).
115
90207a15 1162012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
117
118 * xdisp.c (pos_visible_p): If already at a newline from the
119 display string before the 'while' loop, don't walk back the glyphs
120 from it3.glyph_row. Solves assertion violation when the display
121 string begins with a newline (egg.el). (Bug#11367)
122
b593d6a9
AH
1232012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
124
125 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
126 Move to simple.el.
127
4737362e
GM
1282012-05-01 Glenn Morris <rgm@gnu.org>
129
99cf43f9
GM
130 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
131 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
132 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
133 All were removed before 23.1.
134
9311dcff
GM
135 * dispnew.c: Remove HAVE_LIBNCURSES test;
136 it is always true on relevant platforms.
137
4d5c6349
GM
138 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
139 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
140
4737362e
GM
141 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
142
74dd3a6b
AS
1432012-04-30 Andreas Schwab <schwab@linux-m68k.org>
144
145 * .gdbinit (xpr): Remove checks for no longer existing misc types.
146 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
147 Remove.
148
13c379ee
PE
1492012-04-28 Paul Eggert <eggert@cs.ucla.edu>
150
151 Do not avoid creating empty evaporating overlays (Bug#9642).
152 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
153 That is, do not delete an evaporating overlay if it becomes
154 empty after its bounds are adjusted to fit within its buffer.
155 This fix caused other problems, and I'm reverting it until we get
156 to the bottom of them.
157
a8e7d6d7 1582012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
159
160 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
161
a8e7d6d7 1622012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
163
164 * xdisp.c (pos_visible_p): If the window start position is beyond
165 ZV, start the display from buffer beginning. Prevents assertion
166 violation in init_iterator when the minibuffer window is scrolled
167 via the scroll bar.
168
169 * window.c (window_scroll_pixel_based): Likewise.
170
a8e7d6d7 1712012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
172
173 * keymap.c (where_is_internal): Doc fix (Bug#10872).
174
a8e7d6d7 1752012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
176
177 * fileio.c (Fcopy_file, Fset_file_selinux_context):
178 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
179
a8e7d6d7 1802012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 181
b593d6a9
AH
182 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
183 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 184
1c6900d9
EZ
1852012-04-26 Eli Zaretskii <eliz@gnu.org>
186
4c3fa1d9
EZ
187 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
188 display element, check also the underlying string or buffer
189 character. (Bug#11341)
190
1c6900d9
EZ
191 * w32menu.c: Include w32heap.h.
192 (add_menu_item): If the call to AppendMenuW (via
193 unicode_append_menu) fails, disable Unicode menus only if we are
194 running on Windows 9X/Me.
195
42bf8205
AS
1962012-04-24 Andreas Schwab <schwab@linux-m68k.org>
197
198 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
199 (xgetint): Add missing shift for LSB tags.
200
b1bac16e
MR
2012012-04-24 Martin Rudalics <rudalics@gmx.at>
202
203 * keyboard.c (read_char): Don't wipe echo area for select window
204 events: These might get delayed via `mouse-autoselect-window'
205 (Bug#11304).
206
d69621cc
JB
2072012-04-24 Juanma Barranquero <lekktu@gmail.com>
208
209 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
210 manipulation of :loaded-from data.
211
02fd101b
JB
2122012-04-23 Juanma Barranquero <lekktu@gmail.com>
213
214 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
215 now a cons (bug#11311).
216
888bec30
PE
2172012-04-23 Paul Eggert <eggert@cs.ucla.edu>
218
89a438bd
PE
219 Do not create empty overlays with the evaporate property (Bug#9642).
220 * buffer.c (Fmove_overlay): Delete an evaporating overlay
221 if it becomes empty after its bounds are adjusted to fit within
222 its buffer. Without this fix, in a nonempty buffer (let ((o
223 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
224 yields an empty overlay that has the evaporate property, which is
225 not supposed to happen.
226
1068fe4d
PE
227 Fix minor GTK3 problems found by static checking.
228 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
229 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
230 (struct _EmacsFixedClass, emacs_fixed_get_type):
231 Move decls here from emacsgtkfixed.h, since they needn't be public.
232 (emacs_fixed_get_type): Now static.
233 (emacs_fixed_class_init): Omit unused local.
234 (emacs_fixed_child_type): Remove; unused.
235 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
236 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
237 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
238 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
239 (EMACS_FIXED_GET_CLASS): Remove; unused.
240 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
241
888bec30
PE
242 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
243 Problem reported by Juanma Barranquero for Windows -Wunused-function.
244
de85e130
PE
2452012-04-22 Paul Eggert <eggert@cs.ucla.edu>
246
d0baac98
PE
247 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
248 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
249 (__malloc_size_t, __malloc_ptrdiff_t):
250 Remove. All uses removed, replaced by the definiens if needed,
251 since we can assume C89 or better now.
252 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
253 (protect_malloc_state, align, get_contiguous_space)
254 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
255 (malloc_atfork_handler_child, malloc_enable_thread)
256 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
257 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
258 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
259 (special_realloc, _realloc_internal_nolock, _realloc_internal)
260 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
261 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
262 Define using prototypes, not old style.
263 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
264 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
265 (align): Don't assume that signed integer overflow wraps around.
266 Omit unused local var.
267 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
268 (_free_internal_nolock, memalign, mallochook, reallochook):
269 Omit no-longer-needed casts.
270 (valloc): Use getpagesize, not __getpagesize.
271 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
272 (struct hdr): The 'magic' member is now size_t, not unsigned long.
273
de85e130
PE
274 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
275
dcbf5805
MA
2762012-04-22 Michael Albinus <michael.albinus@gmx.de>
277
278 Move functions from C to Lisp. Make non-blocking method calls
279 the default. Implement further D-Bus standard interfaces.
280
281 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
282 (QCdbus_request_name_allow_replacement)
283 (QCdbus_request_name_replace_existing)
284 (QCdbus_request_name_do_not_queue)
285 (QCdbus_request_name_reply_primary_owner)
286 (QCdbus_request_name_reply_in_queue)
287 (QCdbus_request_name_reply_exists)
288 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
289 (QCdbus_registered_serial, QCdbus_registered_method)
290 (QCdbus_registered_signal): New Lisp objects.
291 (XD_DEBUG_MESSAGE): Use sizeof.
292 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
293 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
294 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
295 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
296 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
297 (xd_signature, xd_append_arg): Allow float for integer types.
298 (xd_get_connection_references): New function.
b593d6a9
AH
299 (xd_get_connection_address): Rename from xd_initialize.
300 Return cached address.
dcbf5805
MA
301 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
302 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
303 level.
304 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 305 Return number of refcounts.
dcbf5805
MA
306 (Fdbus_get_unique_name): Make stronger parameter check.
307 (Fdbus_message_internal): New defun.
308 (Fdbus_call_method, Fdbus_call_method_asynchronously)
309 (Fdbus_method_return_internal, Fdbus_method_error_internal)
310 (Fdbus_send_signal, Fdbus_register_service)
311 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
312 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
313 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
314 (Vdbus_compiled_version, Vdbus_runtime_version)
315 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
316 (Vdbus_message_type_method_return, Vdbus_message_type_error)
317 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
318 (Vdbus_registered_buses, Vdbus_registered_objects_table):
319 Adapt docstring.
dcbf5805 320
52828e02
PE
3212012-04-22 Paul Eggert <eggert@cs.ucla.edu>
322
da05bc4c
PE
323 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
324 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
325 Do not assume ptrdiff_t is the same width as 'int'.
326
52828e02
PE
327 * alloc.c: Handle unusual debugging option combinations.
328 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
329 since the two debugging options are incompatible.
330 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
331 is defined.
332 (mem_init, mem_insert, mem_insert_fixup):
333 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
334 (NEED_MEM_INSERT): Remove; no longer needed.
335
f01769f9
LL
3362012-04-22 Leo Liu <sdl.web@gmail.com>
337
338 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
339
5790543d
PE
3402012-04-22 Paul Eggert <eggert@cs.ucla.edu>
341
342 * sysdep.c [__FreeBSD__]: Minor cleanups.
343 (list_system_processes, system_process_attributes) [__FreeBSD__]:
344 Use Emacs indenting style more consistently. Avoid some casts.
345 Use 'double' consistently rather than mixing 'float' and 'double'.
346
b91b7e4d
EW
3472012-04-21 Eduard Wiebe <usenet@pusto.de>
348
b593d6a9
AH
349 * sysdep.c (list_system_processes, system_process_attributes):
350 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 351
6114eb15
AS
3522012-04-21 Andreas Schwab <schwab@linux-m68k.org>
353
354 * lisp.mk (lisp): Update.
355
2f38dff7
PE
3562012-04-20 Paul Eggert <eggert@cs.ucla.edu>
357
358 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
359 It is never used otherwise.
360
4ae29f89
SM
3612012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
362
363 * print.c (print_preprocess): Only check print_depth if print-circle
364 is nil.
365 (print_object): Check for cycles even when print-circle is nil and
366 print-gensym is t, but only check print_depth if print-circle is nil.
367
f30d612a
CY
3682012-04-20 Chong Yidong <cyd@gnu.org>
369
370 * process.c (wait_reading_process_output): If EIO occurs on a pty,
371 set the status to "failed" and ensure that sentinel is run.
372
c07a4c0b 3732012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
374
375 * process.c (Fset_process_inherit_coding_system_flag)
376 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 377 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 378
c07a4c0b 3792012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
380
381 * xdisp.c (string_buffer_position_lim): Limit starting position to
382 BEGV.
383 (set_cursor_from_row): If called for a mode-line or header-line
384 row, return zero immediately.
385 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
386 farther than the first row after the header line, if any.
387 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
388 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
389
c07a4c0b 3902012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 391
4ae29f89
SM
392 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
393 (bug#11238).
ad3a2b41 394
c07a4c0b 3952012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 3962012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
397
398 configure: new option --enable-gcc-warnings (Bug#11207)
399 * Makefile.in (C_WARNINGS_SWITCH): Remove.
400 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
401 (ALL_CFLAGS): Use new macros rather than old.
402 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
403 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
404 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
405 -Wunused-result, -Wunused-variable. This should go away once
406 the Emacs and Gnulib regex code is merged.
407 (xmalloc, xrealloc): Now static.
408
aba027e8
PE
4092012-04-17 Paul Eggert <eggert@cs.ucla.edu>
410
411 * dired.c (Fsystem_groups): Remove unused local.
412
e5a36063
GM
4132012-04-17 Glenn Morris <rgm@gnu.org>
414
415 * dired.c (Fsystem_users): Doc fix.
416
316411f0
DA
4172012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
418
419 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
420 (syms_of_dired): Add them.
421
9426aba4
PE
4222012-04-16 Paul Eggert <eggert@cs.ucla.edu>
423
b62a57be
PE
424 Fix minor alloc.c problems found by static checking.
425 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
426 New extern decls, to avoid calling undeclared functions.
427 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
428 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
429 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
430 (NEED_MEM_INSERT): New macro.
431 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 432 Remove one incorrect comment and fix another.
b62a57be 433
3539f31f
PE
434 Fix minor ralloc.c problems found by static checking.
435 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
436 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
437 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
438 (r_alloc_sbrk): Now static.
439
a041960a
PE
440 Improve ralloc.c interface checking.
441 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
442 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
443 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
444 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
445 [REL_ALLOC]: ... to here, to check interface.
446 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
447 Remove decls. This fixes an "It stinks!".
448
9426aba4
PE
449 * alloc.c (which_symbols): Fix alignment issue / type clash.
450
d55c12ed
AS
4512012-04-15 Andreas Schwab <schwab@linux-m68k.org>
452
453 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
454 (struct Lisp_Misc_Any): Likewise.
455 (struct Lisp_Free): Likewise.
456 * alloc.c (union aligned_Lisp_Symbol): Define.
457 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
458 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
459 (union aligned_Lisp_Misc): Define.
460 (MARKER_BLOCK_SIZE, struct marker_block): Use union
461 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 462 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 463
b948ce8b
PE
4642012-04-14 Paul Eggert <eggert@cs.ucla.edu>
465
466 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
467 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
468 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
469 * s/netbsd.h, s/sol2-6.h:
470 Remove definition of GC_MARK_STACK, since the default now works.
471 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
472 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
473 no longer the default.
474 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
475
35dc09a1 4762012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 477
35dc09a1
GM
478 * lread.c (lisp_file_lexically_bound_p):
479 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 480
35dc09a1
GM
4812012-04-14 Eli Zaretskii <eliz@gnu.org>
482
483 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
484 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
485
4862012-04-14 Jan Djärv <jan.h.d@swipnet.se>
487
488 * nsterm.m (constrainFrameRect): Always constrain when there is only
489 one screen (Bug#10962).
490
bcd86815
KB
4912012-04-13 Ken Brown <kbrown@cornell.edu>
492
493 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
494
c25df26e
RT
4952012-04-13 Reuben Thomas <rrt@sc3d.org>
496
497 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
498
0fc59f1e
DC
4992012-04-11 Daniel Colascione <dancol@dancol.org>
500
501 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
502 against is gone. It's better to use vfork now so that when Cygwin
503 gains a new, working vfork, we use it automatically (bug#10398).
504
de8c03dc
SM
5052012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
506
507 * window.c (save_window_save): Obey window-point-insertion-type.
508
2f097256
GM
5092012-04-11 Glenn Morris <rgm@gnu.org>
510
511 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
512
453b951e
SM
5132012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
514
515 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
516
75f1671a 5172012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
518
519 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
520 (force_quit_count): New var.
521 (handle_interrupt): Use it.
522
2a8ce227
JB
5232012-04-10 Juanma Barranquero <lekktu@gmail.com>
524
525 * w32.c (w32_delayed_load): Record the full path of the library
526 being loaded (bug#10424).
527
935396c0
GM
5282012-04-09 Glenn Morris <rgm@gnu.org>
529
05920a43
GM
530 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
531 not just in the obarray, before snarfing them. (Bug#11036)
532
935396c0
GM
533 * Makefile.in ($(leimdir)/leim-list.el):
534 Pass EMACS rather than BUILT_EMACS.
535
a18ecafa
TZ
5362012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
537
538 * process.c (make_process):
539 * process.h: Add integer `gnutls_handshakes_tried' member to
540 process struct.
541
6bbef4e5
JC
542 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
543 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
544
545 * gnutls.c (gnutls_log_function2i): Convenience log function.
546 (emacs_gnutls_read): Use new log functions,
547 `gnutls_handshakes_tried' process member, and
548 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
549 attempts per process (connection).
550
b4d3bc10
CY
5512012-04-09 Chong Yidong <cyd@gnu.org>
552
553 * eval.c (Fuser_variable_p, user_variable_p_eh)
554 (lisp_indirect_variable): Functions deleted.
555 (Fdefvar): Caller changed.
556
557 * callint.c (Finteractive, Fcall_interactively):
558 * minibuf.c (Fread_variable): Callers changed.
559
70f4d973
EZ
5602012-04-09 Eli Zaretskii <eliz@gnu.org>
561
562 * xdisp.c (set_cursor_from_row): If the display string appears in
563 the buffer at position that is closer to point than the position
564 after the display string, display the cursor on the first glyph of
565 the display string. Fixes cursor display when a 'display' text
566 property immediately follows invisible text. (Bug#11094)
567
cb3c2e3e
PE
5682012-04-09 Paul Eggert <eggert@cs.ucla.edu>
569
570 composite.c: use 'double' consistently
571 * composite.c (get_composition_id): Use 'double' consistently
572 instead of converting 'float' to 'double' and vice versa; this is
573 easier to understand and avoids a GCC warning.
574
fd06db5d
GM
5752012-04-09 Glenn Morris <rgm@gnu.org>
576
50fe702a
GM
577 * Makefile.in: Generate leim-list with bootstrap-emacs, in
578 preparation for dumping it with emacs. (Bug#4789)
579 (leimdir): New variable.
580 ($(leimdir)/leim-list.el): New rule.
581 (emacs$(EXEEXT)): Depend on leim-list.el.
582
fd06db5d
GM
583 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
584 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
585 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
586
55c131ee
AS
5872012-04-08 Andreas Schwab <schwab@linux-m68k.org>
588
589 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
590 proper alignment.
591
9209588f
JB
5922012-04-07 Juanma Barranquero <lekktu@gmail.com>
593
594 * xml.c (init_libxml2_functions) [WINDOWSNT]:
595 Remove unused local variable.
596
e3fb2efb
PE
5972012-04-07 Paul Eggert <eggert@cs.ucla.edu>
598
599 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
600 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
601 (mark_memory): Mark Lisp_Objects only if pointers might hide in
602 objects, as mark_maybe_pointer will catch them otherwise.
603 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
604 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
605
b5385551
PE
6062012-04-07 Paul Eggert <eggert@cs.ucla.edu>
607
608 Fix typo that broke non-Windows builds.
609 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
610
9078ead6
EZ
6112012-04-07 Eli Zaretskii <eliz@gnu.org>
612
613 Support building on MS-Windows with libxml2.
614
615 * makefile.w32-in (OBJ2): Add xml.$(O).
616 (GLOBAL_SOURCES): Add xml.c.
617 ($(BLD)/xml.$(O)): New dependency list.
618
619 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
620 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
621 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
622 [!WINDOWSNT]: New macros.
623 (init_libxml2_functions, libxml2_loaded_p): New functions.
624 (parse_region): Call fn_xmlCheckVersion instead of using the macro
625 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
626 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
627 Calls xmlCleanupParser only if libxml2 was loaded (or statically
628 linked in).
6bbef4e5
JC
629 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
630 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
631 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
632
633 * emacs.c: Don't include libxml/parser.h.
634 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
635 xmlCleanupParser directly.
636
637 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
638
3811fdf3
EZ
6392012-04-07 Eli Zaretskii <eliz@gnu.org>
640
641 * indent.c (Fvertical_motion): If there is a display string at
642 point, use it.vpos to compute how many lines to backtrack after
643 move_it_to point. (Bug#11133)
644
2f8e16b2
EZ
6452012-04-06 Eli Zaretskii <eliz@gnu.org>
646
647 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
648 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
649 about subtle differences between FETCH_CHAR* and STRING_CHAR*
650 macros related to unification of CJK characters. For the details,
651 see the discussion following the message here:
652 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
653
3d439cd1
CY
6542012-04-04 Chong Yidong <cyd@gnu.org>
655
656 * keyboard.c (Vdelayed_warnings_list): Doc fix.
657
8bc53d00
EZ
6582012-04-01 Eli Zaretskii <eliz@gnu.org>
659
660 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
661 instead of alloca. (Bug#11138)
662
3b0512a3
AS
6632012-04-01 Andreas Schwab <schwab@linux-m68k.org>
664
665 * w32menu.c (is_simple_dialog): Properly check lisp types.
666 (Bug#11141)
667
8427ddd2
EZ
6682012-03-31 Eli Zaretskii <eliz@gnu.org>
669
979022ef
EZ
670 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
671 position we get to after a call to move_it_to fails the
672 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
673 only if we wind up in a string from display property. (Bug#11063)
674
a6b1c7cc
EZ
675 * window.c (Fdelete_other_windows_internal): Invalidate the row
676 and column information about mouse highlight, so that redisplay
677 restores it after reallocating the glyph matrices. (Bug#7464)
678
8427ddd2
EZ
679 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
680 string comes from a `display' text property, use the buffer
681 position of that property as if we actually saw that position in
682 the row's glyphs.
697ba24b
EZ
683 (move_it_by_lines): Remove the assertion that
684 "it->current_x == 0 && it->hpos == 0" which can be legitimately
685 violated when there's a before-string at the beginning of a line.
686 (Bug#11063)
8427ddd2 687
65a0a738
EZ
6882012-03-30 Eli Zaretskii <eliz@gnu.org>
689
690 * xdisp.c (append_space_for_newline): If the default face was
691 remapped, use the remapped face for the appended newline.
692 (extend_face_to_end_of_line): Use the remapped default face for
693 extending the face to the end of the line.
694 (display_line): Call extend_face_to_end_of_line when the default
695 face was remapped. (Bug#11068)
696
581355cc
EZ
6972012-03-29 Eli Zaretskii <eliz@gnu.org>
698
699 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
700
e8fc049f
SM
7012012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
702
703 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
704
4fb9a543
GM
7052012-03-27 Glenn Morris <rgm@gnu.org>
706
707 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
708 Doc fixes.
709
679910f1
KH
7102012-03-26 Kenichi Handa <handa@m17n.org>
711
712 * dispextern.h (struct glyph): Fix previous change. Change the
713 bit length of glyphless.ch to 25 (Bug#11082).
714
90d49b7f
CY
7152012-03-26 Chong Yidong <cyd@gnu.org>
716
717 * keyboard.c (Vselection_inhibit_update_commands): New variable.
718 (command_loop_1): Use it; inhibit selection update for
719 handle-select-window too (Bug#8996).
720
f514f6f0
FP
7212012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
722
e8fc049f 723 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 724
bf43fa51
KH
7252012-03-25 Kenichi Handa <handa@m17n.org>
726
727 * dispextern.h (struct glyph): Change the bit length of
728 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
729
8a0c01dd
EZ
7302012-03-24 Eli Zaretskii <eliz@gnu.org>
731
732 * s/ms-w32.h (tzname): Include time.h before redirecting to
733 _tzname. Fixes the MSVC build. (Bug#9960)
734
7d1c3a76
AS
7352012-03-24 Andreas Schwab <schwab@linux-m68k.org>
736
8ed79523
AS
737 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
738 characters.
739
7d1c3a76
AS
740 * xterm.c (XTread_socket): Only modify handling_signal if
741 !SYNC_INPUT. (Bug#11080)
742
e99a9b8b
EZ
7432012-03-23 Eli Zaretskii <eliz@gnu.org>
744
745 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
746 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
747 when fetching a multibyte character consumes more bytes than
748 CHAR_BYTES returns, due to unification of CJK characters in
749 string_char. (Bug#11073)
750
5063c0e1
TN
7512012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
752
753 * process.c (wait_reading_process_output): Handle pty disconnect
754 by refraining from sending oneself a SIGCHLD (bug#10933).
755
9f851fbd
CY
7562012-03-22 Chong Yidong <cyd@gnu.org>
757
758 * dispextern.h (struct it): New member string_from_prefix_prop_p.
759
5063c0e1 760 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
761 Mark string as coming from a prefix property.
762 (handle_face_prop): Use default face for prefix strings (Bug#4281).
763 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
764
fb5b8aca
CY
7652012-03-21 Chong Yidong <cyd@gnu.org>
766
767 * xfaces.c (Vface_remapping_alist): Doc fix.
768
62356a1b
EZ
7692012-03-20 Eli Zaretskii <eliz@gnu.org>
770
771 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
772 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
773 Doc fixes.
62356a1b 774
025de85b
CY
7752012-03-20 Chong Yidong <cyd@gnu.org>
776
777 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
778 to reflect default non-nil value of redisplay-dont-pause.
779
4827f94e
KH
7802012-03-19 Kenichi Handa <handa@m17n.org>
781
782 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
783 it fit in a valid range (Bug#11003).
784
e50a24a2
EZ
7852012-03-18 Eli Zaretskii <eliz@gnu.org>
786
787 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
788 that is not from display property, accept the row as a "cursor
789 row" if one of the string's character has a non-nil `cursor'
790 property. Fixes cursor positioning when there are newlines in
791 overlay strings, e.g. in icomplete.el. (Bug#11035)
792
9af5ed87
PE
7932012-03-12 Paul Eggert <eggert@cs.ucla.edu>
794
795 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
796
d1f55f16
CY
7972012-03-12 Chong Yidong <cyd@gnu.org>
798
799 * eval.c (inhibit_lisp_code): Rename from
800 inhibit_window_configuration_change_hook; move from window.c.
801
802 * xfns.c (unwind_create_frame_1, Fx_create_frame):
803 * window.c (run_window_configuration_change_hook)
804 (syms_of_window): Callers changed.
805
66c5eebd
CY
8062012-03-11 Chong Yidong <cyd@gnu.org>
807
413df973
CY
808 * keymap.c (Fkey_description): Doc fix (Bug#9700).
809
66c5eebd
CY
810 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
811
1de11f56
CY
8122012-03-10 Chong Yidong <cyd@gnu.org>
813
814 * frame.c (other_visible_frames): Don't assume the selected frame
815 is visible (Bug#10955).
816
cae07000
SM
8172012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
818
819 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
820
89c94350
JD
8212012-03-08 Jan Djärv <jan.h.d@swipnet.se>
822
823 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
824 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
825 zero (Bug#10954).
826
999dd333
GM
8272012-03-03 Glenn Morris <rgm@gnu.org>
828
01a6dcc8 829 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 830
de0100f2
EZ
8312012-03-02 Eli Zaretskii <eliz@gnu.org>
832
833 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
834 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
835 (redisplay_window, next_element_from_string): Fix typos in
836 comments.
3e441275
EZ
837 (redisplay_window): Pass to move_it_vertically the margin in
838 pixels, not in screen lines.
de0100f2 839
96a72ee9
GM
8402012-03-02 Glenn Morris <rgm@gnu.org>
841
842 * buffer.c (buffer-list-update-hook): Doc fix.
843
312508d7
EZ
8442012-02-29 Eli Zaretskii <eliz@gnu.org>
845
846 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
847 push_it before setting up the iterator for the first overlay
848 string, even if we have an empty string loaded.
849 (next_overlay_string): If there's an empty string on the iterator
850 stack, pop the stack. (Bug#10903)
851
27f3c637
PE
8522012-02-25 Paul Eggert <eggert@cs.ucla.edu>
853
854 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
855 Suggested by Stefan Monnier in
856 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
857 * alloc.c (widen_to_Lisp_Object): New static function.
858 (mark_memory): Also mark Lisp_Objects by fetching pointer words
859 and widening them to Lisp_Objects. This would work even if
860 USE_LSB_TAG is defined and wide integers are used, which might
861 happen in a future version of Emacs.
862
3c9dfce6
CY
8632012-02-25 Chong Yidong <cyd@gnu.org>
864
fa74b241
CY
865 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
866 Doc fix.
867
3c9dfce6
CY
868 * xselect.c (Fx_selection_exists_p): Doc fix.
869 (x_clipboard_manager_save_all): Print an informative message
870 before saving to clipboard manager.
871
9486df08
CY
8722012-02-24 Chong Yidong <cyd@gnu.org>
873
874 * keyboard.c (process_special_events): Handle all X selection
875 requests in kbd_buffer, not just the next one (Bug#8869).
876
f01d3321
CY
8772012-02-23 Chong Yidong <cyd@gnu.org>
878
879 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
880 call when setting menu-bar-lines and tool-bar-lines parameters.
881 (unwind_create_frame_1): New helper function.
882
883 * window.c (inhibit_window_configuration_change_hook): New var.
884 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 885 (syms_of_window): Initialize it.
f01d3321 886
86b847b6
CY
8872012-02-22 Chong Yidong <cyd@gnu.org>
888
889 * xterm.c (x_draw_image_relief): Add missing type check for
890 Vtool_bar_button_margin (Bug#10743).
891
a59225b1
CY
8922012-02-21 Chong Yidong <cyd@gnu.org>
893
894 * fileio.c (Vfile_name_handler_alist): Doc fix.
895
896 * buffer.c (Fget_file_buffer): Protect against invalid file
897 handler return value.
898
310f5bd4
PE
8992012-02-20 Paul Eggert <eggert@cs.ucla.edu>
900
cb3a28cc
PE
901 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
902 when computing $valmask.
903
310f5bd4
PE
904 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
905 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
906 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
907 It's useless in that case, and it can cause problems on hosts
908 that allocate halves of EMACS_INT values separately.
909 Reported by Dan Horák. Diagnosed by Andreas Schwab in
910 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
911 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
912 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
913 it avoids undefined behavior on hosts where shifting right by more
914 than the word width has undefined behavior.
915
2375c96a
CY
9162012-02-19 Chong Yidong <cyd@gnu.org>
917
918 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
919 (Funhandled_file_name_directory, Ffile_name_as_directory)
920 (Fdirectory_file_name, Fexpand_file_name)
921 (Fsubstitute_in_file_name): Protect against invalid file handler
922 return values (Bug#10845).
923
3eb49e71
EZ
9242012-02-18 Eli Zaretskii <eliz@gnu.org>
925
926 * .gdbinit (pitx): Fix incorrect references to fields of the
927 iterator stack.
928
7b926f3f
CY
9292012-02-17 Chong Yidong <cyd@gnu.org>
930
931 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
932
11273115
PE
9332012-02-15 Paul Eggert <eggert@cs.ucla.edu>
934
935 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
936 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
937
c3a70e2b
CY
9382012-02-15 Chong Yidong <cyd@gnu.org>
939
940 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
941 marked as special. Also, starting docstrings with * is obsolete.
942
0ca43699
AS
9432012-02-13 Andreas Schwab <schwab@linux-m68k.org>
944
945 * gnutls.c (emacs_gnutls_write): Fix last change.
946
2e8f3c56
LI
9472012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
948
949 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
950 send_process.
951
af70074f
SM
9522012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
953
954 * keymap.c (Fsingle_key_description): Handle char ranges.
955
95986d52
CY
9562012-02-12 Chong Yidong <cyd@gnu.org>
957
afd83bd1
CY
958 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
959 as that creates a dangerous corner case.
960
95986d52
CY
961 * window.c (Fdelete_window_internal): Invalidate the mouse
962 highlight (Bug#9904).
963
bd7da63e
GM
9642012-02-12 Glenn Morris <rgm@gnu.org>
965
966 * xselect.c (Fx_own_selection_internal)
967 (Fx_get_selection_internal, Fx_disown_selection_internal)
968 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
969 * nsselect.m (Fx_own_selection_internal)
970 (Fx_disown_selection_internal, Fx_selection_exists_p)
971 (Fx_selection_owner_p, Fx_get_selection_internal):
972 Sync docs and argument specs with the xselect.c versions.
973
77abcbc2
LI
9742012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
975
976 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
977
90b671e2
EZ
9782012-02-11 Eli Zaretskii <eliz@gnu.org>
979
1c0ca0b7
EZ
980 * w32select.c (Fx_selection_exists_p): Sync doc string and
981 argument list with xselect.c. (Bug#10783)
982
983 * w16select.c (Fx_selection_exists_p): Sync doc string and
984 argument list with xselect.c. (Bug#10783)
90b671e2 985
49241268
GM
9862012-02-10 Glenn Morris <rgm@gnu.org>
987
988 * fns.c (Fsecure_hash): Doc fix.
989
f998bbe7 9902012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
991
992 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
993
0992bd9c
CY
9942012-02-07 Chong Yidong <cyd@gnu.org>
995
996 * buffer.c (Fbuffer_local_variables)
997 (buffer_lisp_local_variables): Handle unbound vars correctly;
998 don't let Qunbound leak into Lisp.
999
af008560
GM
10002012-02-07 Glenn Morris <rgm@gnu.org>
1001
dd605cc4
GM
1002 * image.c (Fimagemagick_types): Doc fix.
1003
af008560
GM
1004 * image.c (imagemagick-render-type): Change it from a lisp object
1005 to an integer. Move the doc here from the lisp manual.
1006 Treat all values not equal to 0 the same.
1007
1449fa1d
CY
10082012-02-06 Chong Yidong <cyd@gnu.org>
1009
1010 * doc.c (store_function_docstring): Avoid applying docstring of
1011 alias to base function (Bug#2603).
1012
3723ec07
AS
10132012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1014
1015 * .gdbinit (pp1, pv1): Remove redundant defines.
1016 (pr): Use pp.
1017
79c1cc1e
CY
10182012-02-04 Chong Yidong <cyd@gnu.org>
1019
1020 * nsterm.m: Declare a global (Bug#10694).
1021
d7f29f8e
EZ
10222012-02-04 Eli Zaretskii <eliz@gnu.org>
1023
cae07000
SM
1024 * w32.c (get_emacs_configuration_options):
1025 Include --enable-checking, if specified, in the return value.
d7f29f8e 1026
3b95a6f9
MR
10272012-02-04 Martin Rudalics <rudalics@gmx.at>
1028
1029 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1030 after rounding frame sizes. (Bug#9723)
1031
d6fa96a6
EZ
10322012-02-04 Eli Zaretskii <eliz@gnu.org>
1033
1034 * keyboard.c (adjust_point_for_property): Don't position point
1035 before BEGV. (Bug#10696)
1036
df0b2940
PE
10372012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1038
1039 Handle overflow when computing char display width (Bug#9496).
1040 * character.c (char_width): Return EMACS_INT, not int.
1041 (char_width, c_string_width): Check for overflow when
1042 computing the width; this is possible now that individual
1043 characters can have unbounded width. Problem introduced
1044 by merge from Emacs 23 on 2012-01-19.
1045
6bee44d6
MA
10462012-02-02 Michael Albinus <michael.albinus@gmx.de>
1047
1048 * dbusbind.c (Fdbus_register_method): Mention the return value
1049 :ignore in the docstring.
1050
44f92739
GM
10512012-02-02 Glenn Morris <rgm@gnu.org>
1052
1b9f60cc
GM
1053 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1054
44f92739
GM
1055 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1056 Unconditionally set to t. (Bug#10673)
1057 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1058 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1059 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1060
c5d3843c
KH
10612012-02-02 Kenichi Handa <handa@m17n.org>
1062
1063 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1064 0, do not call append_composite_glyph.
1065
159462d4 10662012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
1067
1068 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1069 NULL (Bug#6988).
1070 (x_produce_glyphs): If the component of a composition is a null
1071 string, set it->pixel_width to 1 to avoid zero-width glyph.
1072
78cef877
EZ
10732012-02-01 Eli Zaretskii <eliz@gnu.org>
1074
1075 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1076 first 2 arguments are identical. This makes inserting large
1077 output from a subprocess an order of magnitude faster on
1078 MS-Windows, where all sbrk'ed memory is always contiguous.
1079
97897668
GM
10802012-01-31 Glenn Morris <rgm@gnu.org>
1081
1082 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 1083 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
1084 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1085
31fd3586
GM
10862012-01-29 Glenn Morris <rgm@gnu.org>
1087
1088 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1089
0e24a8b2
CY
10902012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1091
1092 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1093
cc0adcb0
CY
10942012-01-28 Chong Yidong <cyd@gnu.org>
1095
1096 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1097
acc28cb9
CY
10982012-01-26 Chong Yidong <cyd@gnu.org>
1099
9c69cfb7
CY
1100 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1101
acc28cb9
CY
1102 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1103 repeat counts (Bug#10507).
1104
48da7392
GM
11052012-01-26 Glenn Morris <rgm@gnu.org>
1106
1107 * lread.c (syms_of_lread): Doc fix.
1108
14af5f7f
CY
11092012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1110
1111 * coding.c (encode_designation_at_bol): Change return value to
1112 EMACS_INT.
1113
0b21c100
CY
11142012-01-25 Chong Yidong <cyd@gnu.org>
1115
1116 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1117
3c2907f7
CY
11182012-01-21 Chong Yidong <cyd@gnu.org>
1119
1120 * floatfns.c (Fcopysign): Make the second argument non-optional,
1121 since nil is not allowed anyway.
1122
959ad23f
AS
11232012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1124
1125 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1126 (send_process): Likewise.
1127
34a02f46
MR
11282012-01-19 Martin Rudalics <rudalics@gmx.at>
1129
1130 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
1131 (Vwindow_persistent_parameters): Do not use Qstate.
1132 Rewrite doc-strings.
34a02f46 1133
1259009a 11342012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
1135
1136 * character.c (char_width): New function.
70d4fdf6
GM
1137 (Fchar_width, c_string_width, lisp_string_width):
1138 Use char_width (Bug#9496).
25ed9e61 1139
6a6ee00d
MR
11402012-01-16 Martin Rudalics <rudalics@gmx.at>
1141
1142 * window.c (Vwindow_persistent_parameters): New variable.
1143 (Fset_window_configuration, save_window_save): Handle persistent
1144 window parameters.
1145
c85efaf7
EZ
11462012-01-14 Eli Zaretskii <eliz@gnu.org>
1147
1148 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1149 thrashing the stack of the thread. (Bug#9087)
1150
5944709e
PE
11512012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1152
1153 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1154
e71f5d99
EZ
11552012-01-11 Eli Zaretskii <eliz@gnu.org>
1156
1157 * xdisp.c (rows_from_pos_range): Handle the case where the
1158 highlight ends on a newline. (Bug#10464)
1159 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1160 he end column for display of highlight that ends on a newline
1161 before a R2L line.
1162
ce316182
GM
11632012-01-11 Glenn Morris <rgm@gnu.org>
1164
1165 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1166 from load-path also when installation-directory is nil. (Bug#10208)
1167
5b43da69
GM
11682012-01-10 Glenn Morris <rgm@gnu.org>
1169
74cc8ff9
GM
1170 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1171
7d8d6e4e
GM
1172 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1173 Update template values to be closer to their typical values these days.
5b43da69 1174
a0db8d43
EZ
11752012-01-09 Eli Zaretskii <eliz@gnu.org>
1176
1177 * xdisp.c (rows_from_pos_range): Accept additional argument
1178 DISP_STRING, and accept any glyph in a row whose object is that
1179 string as eligible for mouse highlight. Fixes mouse highlight of
1180 display strings from overlays. (Bug#10464)
1181
9a0115ab 11822012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1183
b9110d6a 1184 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1185 * fileio.c (auto_saving_dir_umask): New static var.
1186 (Fmake_directory_internal): Use it.
1187 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1188 creating the directory. The old code temporarily assigns
1189 too-generous permissions to the directory.
1190 (do_auto_save_eh): Clear it.
b9110d6a 1191 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1192 that the var is always cleared.
1193
6c1bd3f3
EZ
11942012-01-07 Eli Zaretskii <eliz@gnu.org>
1195
1196 * search.c (scan_buffer): Pass character positions to
1197 know_region_cache, not byte positions. (Bug#6540)
1198
069d2b50
L
11992012-01-07 LynX <_LynX@bk.ru> (tiny change)
1200
1201 * w32.c (sys_rename): Report EXDEV when rename of a directory
1202 fails because the target is on another logical disk. (Bug#10284)
1203
75bf0d33
DB
12042012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1205
1206 * xterm.c (x_embed_request_focus): New function.
1207
1208 * xterm.h: Add prototype.
1209
1210 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1211
1c6e5a32
GM
12122012-01-05 Glenn Morris <rgm@gnu.org>
1213
1214 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1215
651e947e
EZ
12162012-01-01 Eli Zaretskii <eliz@gnu.org>
1217
1218 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1219 Load gnutls_transport_set_lowat only if GnuTLS version is below
1220 2.11.1.
1221 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1222 GnuTLS versions below 2.11.1.
1223
3778cdd8
AL
12242011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1225
1226 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1227 to the doc string advising against its use for altering the way
1228 windows are scrolled.
1229
0e5317f7
KH
12302011-12-28 Kenichi Handa <handa@m17n.org>
1231
1232 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1233 coding-system ASCII compatible only when it does not produce BOM
1234 on encoding (Bug#10383).
1235
93d5ca1f
JD
12362011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1237
1238 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1239 can scroll.
1240 (create_and_show_popup_menu): Always use menu_position_func for
1241 Gtk3 (Bug#10361).
1242
ca22b785
AS
12432011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1244
1245 * callint.c (Fcall_interactively): Don't truncate prompt string.
1246
d048e1e6
EZ
12472011-12-23 Eli Zaretskii <eliz@gnu.org>
1248
1249 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1250 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1251 resumed from there (after widening). (Bug#10360)
d048e1e6 1252
5ccaba1f
JD
12532011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1254
1255 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1256
204ee57f
JD
12572011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1258
b81d40f0
JB
1259 * nsterm.m (x_free_frame_resources):
1260 Release f->output_data.ns->miniimage.
204ee57f
JD
1261 (ns_index_color): Fix indentation. Do not retain
1262 color_table->colors[i].
1263
1264 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1265 before returning.
1266
1267 * nsfns.m (x_set_background_color): Assign return value from
1268 ns_index_color to face-background instead of NSColor*.
1269 (ns_implicitly_set_icon_type): Fix indentation.
1270 Change assignment in for loop to comparison.
1271
1272 * emacs.c (ns_pool): New variable.
1273 (main): Assign ns_pool.
1274 (Fkill_emacs): Call ns_release_autorelease_pool.
1275
1276 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1277 autorelease fdesc, release fdAttrs and tdict.
1278 (ns_get_covering_families): Release charset.
1279 (ns_findfonts): Release NSFontDescriptor created with new.
1280 (ns_uni_to_glyphs): Fix indentation.
1281 (setString): Release attrStr before assigning new value.
1282
c803b2b7
JD
12832011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1284
678f4426
JD
1285 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1286 and NS_IMPL_COCOA.
1287 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1288 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1289
cd394be1 12902011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1291
5fecd5fc
JD
1292 * nsterm.m (ns_term_init): Subscribe for notifications
1293 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1294 to method trackingNotification in EmacsMenu.
1295
1296 * nsmenu.m (trackingMenu): New variable.
3771cb17 1297 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1298 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1299 from Aquamacs (Bug#7030).
678f4426
JD
1300
13012011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1302
c803b2b7
JD
1303 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1304 (symbol_to_nsstring): Fix indentation.
1305 (ns_symbol_to_pb): New function.
cae07000
SM
1306 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1307 (Fns_rotate_cut_buffers_internal): Remove.
1308 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1309 Fns_store_cut_buffer_internal.
1310 (ns_get_foreign_selection, Fx_own_selection_internal)
1311 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1312 (Fns_get_selection_internal, Fns_store_selection_internal):
1313 Use ns_symbol_to_pb and check if return value is nil.
1314 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1315 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1316 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1317 renamed to Sns_store_selection_internal.
1318 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1319 and remove this function.
1320 (ns_handle_selection_clear): Remove, never used.
1321 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1322 here.
1323
e1b01a3a
KB
13242011-12-17 Ken Brown <kbrown@cornell.edu>
1325
1326 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1327 GID is unknown (Bug#10257).
1328
2adb6e85
PE
13292011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1330
1331 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1332 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1333 which caused a build failure on GNU/Linux IA-64. This problem was
1334 introduced by my 2011-10-07 patch.
1335
d1d7b339
JL
13362011-12-15 Juri Linkov <juri@jurta.org>
1337
1338 * image.c (imagemagick_error): New function. (Bug#10112)
1339 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1340 Use `imagemagick_error' where ImageMagick functions return
1341 `MagickFalse'.
1342 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1343 proper order.
1344
100d5755
KH
13452011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1346
1347 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1348 fill background (Bug#8992).
1349
454592a6
MR
13502011-12-13 Martin Rudalics <rudalics@gmx.at>
1351
1352 * window.c (Vwindow_combination_resize)
1353 (Vwindow_combination_limit): Use t instead of non-nil in
1354 doc-strings.
61d4b438
MR
1355 (Vrecenter_redisplay): Add first sentence of doc-string on
1356 separate line.
53524d93 1357 (Frecenter): Fix doc-string typo.
454592a6 1358
3633e3aa
KH
13592011-12-11 Kenichi Handa <handa@m17n.org>
1360
1361 * coding.c (Funencodable_char_position): Pay attention to the
1362 buffer text relocation (Bug#9389).
1363
7b9d523a
JD
13642011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1365
1366 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1367 gtk_init (Bug#10100).
1368
b73189c6
EZ
13692011-12-10 Eli Zaretskii <eliz@gnu.org>
1370
1371 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1372 IT->string is nil. (Bug#10263)
1373
f7dfe5d6
JD
13742011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1375
83faebb4
JD
1376 * nsterm.h (x_free_frame_resources): Declare.
1377
f7dfe5d6
JD
1378 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1379 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1380
1381 * nsterm.h (ns_get_defaults_value): Declare.
1382
1383 * nsterm.m (ns_default): Call ns_get_defaults_value.
1384
7cd4e72c
EZ
13852011-12-09 Eli Zaretskii <eliz@gnu.org>
1386
1387 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1388 (Bug#10170)
1389
b34d7317
YM
13902011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1391
1392 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1393 that where the value of an _OBJC_* symbol points to is in the .bss
1394 section (Bug#10240).
1395
76470ad1
KH
13962011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1397
1398 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1399 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1400
745fff94
KH
14012011-12-08 Kenichi Handa <handa@m17n.org>
1402
1403 * ftfont.c (get_adstyle_property): Fix previous change
1404 (Bug#10233).
1405
6e44397c
JB
14062011-12-07 Juanma Barranquero <lekktu@gmail.com>
1407
1408 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1409 dirs from the default value of EMACSLOADPATH (bug#10208).
1410
7efa6272
GM
14112011-12-07 Glenn Morris <rgm@gnu.org>
1412
1413 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1414 installation and source directories as well. (Bug#10208)
1415
f6fc4d87
CY
14162011-12-06 Chong Yidong <cyd@gnu.org>
1417
1418 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1419
2bf26180
GM
14202011-12-06 Glenn Morris <rgm@gnu.org>
1421
1422 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1423 as an error, not just -1. (Bug#10217)
1424
3a6ad4f0
CY
14252011-12-05 Chong Yidong <cyd@gnu.org>
1426
1427 * keyboard.c (process_special_events): New function.
1428 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1429
75a3b399
PE
14302011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1431
1432 * coding.c (encode_designation_at_bol): Don't use uninitialized
1433 local variable (Bug#9318).
1434
c3c9e25e
KH
14352011-12-05 Kenichi Handa <handa@m17n.org>
1436
1437 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1438 return Qnil (Bug#8046, Bug#10193).
1439
5eb05ea3
KH
14402011-12-05 Kenichi Handa <handa@m17n.org>
1441
1442 * coding.c (encode_designation_at_bol): New args charbuf_end and
1443 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1444 (coding_set_source): Return how many bytes coding->source was
1445 relocated.
1446 (coding_set_destination): Return how many bytes
1447 coding->destination was relocated.
1448 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1449 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1450
14512011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1452
1453 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1454 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1455 macro (Bug#9318).
1456
14572011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1458
1459 The following changes are to fix Bug#9318.
1460
a79703f5 1461 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1462 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1463 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1464 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1465
7dbda6df
JB
14662011-12-05 Juanma Barranquero <lekktu@gmail.com>
1467
1468 * lisp.h (process_quit_flag): Fix external declaration.
1469
6d5eb5b0
SM
14702011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1471
1472 Don't macro-inline non-performance-critical code.
1473 * eval.c (process_quit_flag): New function.
1474 * lisp.h (QUIT): Use it.
1475
a0c3fad0
JD
14762011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1477
1478 * nsfns.m (get_geometry_from_preferences): New function.
1479 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1480
6c07aac2
AS
14812011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1482
1483 * emacs.c (Qkill_emacs): Define.
1484 (syms_of_emacs): Initialize it.
1485 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1486 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1487 (quit_throw_to_read_char): Add parameter `from_signal'.
1488 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1489 * lisp.h (QUIT): Call Fkill_emacs if requested.
1490
c052ead4
JD
14912011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1492
1493 * widget.c (update_wm_hints): Return if wmshell is null.
1494 (widget_update_wm_size_hints): New function.
1495
1496 * widget.h (widget_update_wm_size_hints): Declare.
1497
1498 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1499 widget_update_wm_size_hints (Bug#10104).
1500
9e49252b
EZ
15012011-12-03 Eli Zaretskii <eliz@gnu.org>
1502
1503 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1504 before a newline, prepare the bidi iterator for consuming the
1505 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1506 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1507
02b16839
JL
15082011-12-02 Juri Linkov <juri@jurta.org>
1509
1510 * search.c (Fword_search_regexp): New Lisp function created from
1511 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1512 (Fword_search_backward, Fword_search_forward)
1513 (Fword_search_backward_lax, Fword_search_forward_lax):
1514 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1515 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1516
0068070e
SM
15172011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1518
1519 * fileio.c (Finsert_file_contents): Move after-change-function call
1520 to before the "handled:" label, since all "goto handled" appear in
1521 cases where the *-change-functions have already been properly called
1522 (bug#10117).
1523
3360a3fc
AS
15242011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1525
1526 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1527 waiting for input. (Bug#10169)
1528
73d6c093
EZ
15292011-11-30 Eli Zaretskii <eliz@gnu.org>
1530
1531 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1532 verifies glyph row's hash code--we have just reallocated the
1533 glyphs, so their contents can be complete garbage. (Bug#10164)
1534
febe6bea
JB
15352011-11-30 Juanma Barranquero <lekktu@gmail.com>
1536
1537 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1538
801a4313
EZ
15392011-11-30 Eli Zaretskii <eliz@gnu.org>
1540
1541 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1542 attributes are tested _before_ calling verify_row_hash, to protect
1543 against GCC re-ordering of the tests. (Bug#10164)
1544
2b56b87e
JD
15452011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1546
1547 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1548
1549 * xterm.c (handle_one_xevent): Only set async_visible and friends
1550 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1551 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1552 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1553
dbf31225
PE
15542011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1555
1556 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1557 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1558 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1559 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1560 All uses changed to use GCPRO1 etc.
1561 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1562 Revert to old implementation (i.e., before 2011-03-11).
1563
1305621b
YM
15642011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1565
1566 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1567 of scroll runs so as to avoid assigning disabled bogus rows and
1568 unnecessary graphics copy operations.
1569
8c9afb46
EZ
15702011-11-27 Eli Zaretskii <eliz@gnu.org>
1571
1572 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1573 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1574 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1575 (malloc, free, realloc, calloc): Redirect to e_* only when
1576 compiling Emacs.
1577
1578 * lisp.h (GCTYPEBITS): Move before first use.
1579 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1580 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1581 this macro definition.
1582
1583 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1584 _MSC_VER.
1585
54e9e3bf
JD
15862011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1587
6d5eb5b0
SM
1588 * gtkutil.c (xg_create_frame_widgets):
1589 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1590 present with Gtk+ 2.0.
1591
83aca1cb
PE
15922011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1593
1594 * fileio.c (Finsert_file_contents): Undo previous change; see
1595 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1596
5b76caa4
PE
15972011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1598
1599 Rename locals to avoid shadowing.
1600 * fileio.c (Finsert_file_contents):
1601 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1602 * process.c (wait_reading_process_output):
1603 Rename inner 'proc' to 'p' to avoid shadowing.
1604 Indent for consistency with usual Emacs style.
1605
8c535114
EZ
16062011-11-25 Eli Zaretskii <eliz@gnu.org>
1607
1608 * xdisp.c (redisplay_window): If cursor row is not fully visible
1609 after recentering, and scroll-conservatively is set to a large
1610 number, scroll window by a few more lines to make the cursor fully
1611 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1612 (start_display): Don't move to the next line if the display should
1613 start at a newline that is part of a display vector or an overlay
1614 string. (Bug#10119)
8c535114 1615
fa4fdb5c
JL
16162011-11-24 Juri Linkov <juri@jurta.org>
1617
1618 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1619 after the `MagickPingImage' call. (Bug#10112)
1620
90ec88df
CY
16212011-11-23 Chong Yidong <cyd@gnu.org>
1622
1623 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1624
56e2e794
MR
16252011-11-23 Martin Rudalics <rudalics@gmx.at>
1626
1627 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1628 making another buffer current. (Bug#10114)
1629
b6e64c41
GM
16302011-11-23 Glenn Morris <rgm@gnu.org>
1631
1632 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1633
6b21de18
CY
16342011-11-23 Chong Yidong <cyd@gnu.org>
1635
1636 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1637 using it (Bug#5984).
1638
b12cd789
EZ
16392011-11-22 Eli Zaretskii <eliz@gnu.org>
1640
1641 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1642 and header-lines, as they don't have one computed for them.
1643 (Bug#10098)
1644
1645 * .gdbinit (prow): Make displayed values more self-explaining.
1646 Add row's hash code.
1647
261b6fd4
LMI
16482011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1649
1650 * process.c (wait_reading_process_output): Fix asynchrounous
1651 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1652 (wait_reading_process_output): Add comment and URL.
261b6fd4 1653
e7cfd277
JD
16542011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1655
1656 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1657
a9b9b7f5
CY
16582011-11-21 Chong Yidong <cyd@gnu.org>
1659
1660 * window.c (Fnext_window, Fprevious_window): Doc fix.
1661
b0d15b4f
SM
16622011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1663
1664 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1665
fe7a3057
JB
16662011-11-20 Juanma Barranquero <lekktu@gmail.com>
1667
1668 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1669
d2999b1a
MR
16702011-11-20 Martin Rudalics <rudalics@gmx.at>
1671
1672 * window.c (Fset_window_combination_limit): Rename argument
1673 STATUS to LIMIT.
1674 (Vwindow_combination_limit): Remove "status" from doc-string.
1675
d5ff9cd0
AS
16762011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1677
1678 * m/ibms390.h: Remove.
1679 * m/ibms390x.h: Don't include "ibms390.h".
1680
a5bb9bd3
SM
16812011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1682
1683 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1684 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1685
cd1181db
JB
16862011-11-20 Juanma Barranquero <lekktu@gmail.com>
1687
1688 * casetab.c (Fset_case_table):
1689 * charset.c (Fcharset_after): Fix typos.
1690
615a3b8d 16912011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1692
17e845af
PE
1693 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1694 Otherwise, valgrind does not work on some platforms.
1695 Problem reported by Andreas Schwab in
6a0bf43d
PE
1696 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1697 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1698 is set, removing the need for VIRT_ADDRESS_VARIES.
1699 (PURE_P): Use a more-efficient implementation that needs just one
1700 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1701 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1702 to 4 (xorl, subq, cmpq, setbe).
1703 * alloc.c (pure): Always extern now, since that's the
1704 VIRT_ADDR_VARIES behavior.
1705 (PURE_POINTER_P): Use a single comparison, not two, for
1706 consistency with the new puresize.h.
1707 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1708 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1709 Remove VIRT_ADDR_VARIES no longer needed.
1710
f8fe6f96
EZ
17112011-11-19 Eli Zaretskii <eliz@gnu.org>
1712
1713 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1714 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1715 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1716 behave as if the cursor position were at the window margin.
1717
1718 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1719 and the cursor position is out of bounds, behave as if the cursor
1720 position were at the window margin. (Bug#10075)
1721
df05a53c
CY
17222011-11-18 Chong Yidong <cyd@gnu.org>
1723
1724 * window.c (Fwindow_combination_limit): Make first argument
1725 non-optional, since it is meaningless for live windows like the
1726 selected window.
1727
2071918e
DA
17282011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1729
1730 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1731
b50a28de
SM
17322011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1733
1734 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1735 (graft_intervals_into_buffer): Simplify.
1736
015137db
EZ
17372011-11-18 Eli Zaretskii <eliz@gnu.org>
1738
1739 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1740 hash values of the two rows.
1741 (copy_row_except_pointers): Preserve the used[] arrays and the
1742 hash values of the two rows. (Bug#10035)
68c95424 1743 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1744
1745 * xdisp.c (row_hash): New function, body extracted from
1746 compute_line_metrics.
1747 (compute_line_metrics): Call row_hash, instead of computing the
1748 hash code inline.
1749
1750 * dispnew.c (verify_row_hash): Call row_hash for computing the
1751 hash code of a row, instead of duplicating code from xdisp.c.
1752
1753 * dispextern.h (row_hash): Add prototype.
1754
a2addb04
TH
17552011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1756
1757 * frame.c (delete_frame): Don't delete the terminal when the last
1758 X frame is closed if emacs is built with GTK toolkit.
1759
df85d315
JB
17602011-11-17 Juanma Barranquero <lekktu@gmail.com>
1761
1762 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1763
a0c2d0ae
MR
17642011-11-17 Martin Rudalics <rudalics@gmx.at>
1765
1766 * window.c (Vwindow_splits): Rename to
1767 Vwindow_combination_resize. Suggested by Juri Linkov.
1768 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1769 of Vwindow_splits.
1770
58179cce
JB
17712011-11-16 Juanma Barranquero <lekktu@gmail.com>
1772
7877f373
JB
1773 * nsfns.m (Fns_font_name):
1774 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1775
b6f67890
MR
17762011-11-16 Martin Rudalics <rudalics@gmx.at>
1777
1778 * window.h (window): Rename slot "nest" to "combination_limit".
1779 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1780 (Fset_window_nest): Rename to Fset_window_combination_limit.
1781 (Vwindow_nest): Rename to Vwindow_combination_limit.
1782 (recombine_windows, make_parent_window, make_window)
1783 (Fsplit_window_internal, saved_window)
1784 (Fset_window_configuration, save_window_save): Rename all
1785 occurrences of window_nest to window_combination_limit.
1786
c7015153
JB
17872011-11-15 Juanma Barranquero <lekktu@gmail.com>
1788
1789 * image.c (imagemagick_load_image): Fix typo.
1790
322ad6ec
EZ
17912011-11-14 Eli Zaretskii <eliz@gnu.org>
1792
1793 * xdisp.c (display_line): Move the call to
1794 highlight_trailing_whitespace before the call to
1795 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1796 faces of all the glyphs to compute ROW's hash value.
1797 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1798
f067b8ec
JB
17992011-11-14 Juanma Barranquero <lekktu@gmail.com>
1800
1801 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1802 just return (bug#10044).
1803
1e5b2111
EZ
18042011-11-12 Eli Zaretskii <eliz@gnu.org>
1805
7ef3cbd5
EZ
1806 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1807 with user-defined heap size. Bump the default size of the temacs
1808 heap to 27MB, to avoid memory warning when running temacs.
1809 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1810
1e5b2111
EZ
1811 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1812 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1813 (verify_row_hash) [XASSERTS]: New function.
1814 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1815 that the hash value of glyph rows is correct.
1e5b2111 1816
89d61221
MR
18172011-11-12 Martin Rudalics <rudalics@gmx.at>
1818
1819 * window.h (window): Remove splits slot.
1820 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1821 (Fdelete_other_windows_internal, make_parent_window)
1822 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1823 (Fset_window_configuration, save_window_save): Don't deal with
1824 split status of windows.
1825 (saved_window): Remove splits slot.
1826 (Vwindow_splits): Rewrite doc-string.
1827
97f18cc8
JD
18282011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1829
1830 * xfns.c (unwind_create_frame):
1831 * nsfns.m (unwind_create_frame):
1832 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1833 Vframe_list (Bug#9999).
1834
22a648b4
DA
18352011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1836
0b381c7e 1837 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1838
659afede
KH
18392011-11-11 Kenichi Handa <handa@m17n.org>
1840
1841 * callproc.c (Fcall_process): Set the member dst_multibyte of
1842 process_coding.
1843
9ac0394b
KH
18442011-11-11 Johan Bockgård <bojohan@gnu.org>
1845
1846 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1847 avoid a crash (bug#9496).
1848
2fbdc249
CY
18492011-11-09 Chong Yidong <cyd@gnu.org>
1850
1851 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1852 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1853
ac6b1f81
PE
18542011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1855
1856 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1857
09db192c
PE
18582011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1859
1860 Avoid some portability problems by eschewing 'extern inline' functions.
1861 The trivial performance wins aren't worth the portability hassles; see
1862 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1863 et seq.
1864 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1865 (window_box_width, window_box_left, window_box_left_offset)
1866 (window_box_right, window_box_right_offset): Undo previous change,
1867 by removing the "extern"s.
1868 * intervals.c (adjust_intervals_for_insertion)
1869 (adjust_intervals_for_deletion): Undo previous change,
1870 making these static again.
1871 (offset_intervals, temp_set_point_both, temp_set_point)
1872 (copy_intervals_to_string): No longer inline.
1873 * xdisp.c (window_text_bottom_y, window_box_width)
1874 (window_box_height, window_box_left_offset)
1875 (window_box_right_offset, window_box_left, window_box_right)
1876 (window_box): No longer inline.
1877
105216ed
CY
18782011-11-08 Chong Yidong <cyd@gnu.org>
1879
1880 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1881 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1882 Signal an error if not a live window.
105216ed
CY
1883 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1884 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1885
ae9e237f
JB
18862011-11-07 Juanma Barranquero <lekktu@gmail.com>
1887
1888 * lisp.h (syms_of_abbrev): Remove declaration.
1889 Reported by CHENG Gao <chenggao@royau.me>.
1890
c7aa8333
EZ
18912011-11-07 Eli Zaretskii <eliz@gnu.org>
1892
1893 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1894 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1895 of temacs in GUI mode.
1896
be7f5545
MR
18972011-11-07 Martin Rudalics <rudalics@gmx.at>
1898
1899 * window.h: Declare delete_all_child_windows instead of
1900 delete_all_subwindows.
1901 * window.c (Fwindow_nest, Fset_window_nest)
1902 (Fset_window_new_total, Fset_window_new_normal)
1903 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1904 (delete_all_subwindows): Rename to delete_all_child_windows.
1905 (Fdelete_other_windows_internal, Fset_window_configuration):
1906 Call delete_all_child_windows instead of delete_all_subwindows.
1907 * frame.c (delete_frame): Call delete_all_child_windows instead
1908 of delete_all_subwindows.
1909
ca78dc43
PE
19102011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1911
1912 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1913 This is also needed for porting to any host where GC_MARK_STACK is
1914 not GC_MAKE_GCPROS_NOOPS.
1915 (which_symbols): Use it.
1916
a0241d01
KH
19172011-11-07 Kenichi Handa <handa@m17n.org>
1918
1919 * coding.c (coding_set_destination): Check coding->src_pos only
1920 when coding->src_object is a buffer (bug#9910).
1921
1922 * process.c (send_process): Set the member src_multibyte of coding
1923 to 0 (bug#9911) when sending a unibyte text.
1924
1925 * callproc.c (Fcall_process): Set the member src_multibyte of
1926 process_coding to 0 (bug#9912).
1927
a64bfdfa 19282011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1929
1930 * xmenu.c (cleanup_widget_value_tree): New function.
1931 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1932 calling free_menubar_widget_value_tree directly (Bug#9830).
1933
cb41b32a
PE
19342011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1935
1936 Fix some portability problems with 'inline'.
1937 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1938 (window_box_width, window_box_left, window_box_left_offset)
1939 (window_box_right, window_box_right_offset): Declare extern.
1940 Otherwise, these inline functions do not conform to C99 and
1941 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1942 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1943 * intervals.c (adjust_intervals_for_insertion)
1944 (adjust_intervals_for_deletion): Now extern, because otherwise the
1945 extern inline functions 'offset_intervals' couldn't refer to it.
1946 (static_offset_intervals): Remove.
1947 (offset_intervals): Rewrite using the old contents of
1948 static_offset_intervals. The old version didn't conform to C99
1949 because an extern inline function contained a reference to an
1950 identifier with static linkage.
1951
b7041366
AS
19522011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1953
1954 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1955 GC.
1956
88a37c4d
EZ
19572011-11-06 Eli Zaretskii <eliz@gnu.org>
1958
1959 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1960 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1961 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1962 return Qleft_to_right.
1963
49745b39
CY
19642011-11-06 Chong Yidong <cyd@gnu.org>
1965
1966 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1967 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1968 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1969 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1970 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1971 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1972 (Fwindow_vscroll): Doc fix.
1973 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1974 argument, since it makes no sense to pass a live window and for
1975 consistency with window-child.
1976
1f05cd82
CS
19772011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1978
1979 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1980 support MSVC.
1981
22610910
JR
19822011-11-05 Jason Rumney <jasonr@gnu.org>
1983
1984 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1985 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1986 fonts (Bug#6029).
1987 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1988 bitwise arithmetic preventing use of unicode-sip and non-truetype
1989 opentype fonts.
1990
a06776b2
EZ
19912011-11-05 Eli Zaretskii <eliz@gnu.org>
1992
3ad924ba
EZ
1993 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1994 "emacs"-only part.
1995
a06776b2
EZ
1996 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1997 initialization code to keep similarity to xfns.c after changes
1998 from 2011-11-05.
1999
c9e7db78
JD
20002011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2001
a97f8f3f
JD
2002 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2003 (unwind_create_frame): New function (Bug#9943).
2004 (Fx_create_frame): Restructure code to be more similar to the one in
2005 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2006 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2007 Move terminal->reference_count++ just before making the frame official
2008 (Bug#9943).
2009
2010 * nsterm.m (x_free_frame_resources): New function.
2011 (x_destroy_window): Move code to x_free_frame_resources.
2012
c9e7db78 2013 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
2014 (Fx_create_frame, x_create_tip_frame):
2015 Move terminal->reference_count++ just before making the frame
75f1671a 2016 official. Move initialization of image_cache_refcount and
c9e7db78
JD
2017 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2018
a6fc3b5c
EZ
20192011-11-05 Eli Zaretskii <eliz@gnu.org>
2020
2021 Support MSVC build with newer versions of Visual Studio.
2022 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2023 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2024 nt/gmake.defs.
2025
2026 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2027 which are not supported by MSVC.
2028 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2029 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2030 bitfields.
2031 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2032 types in bitfields.
2033 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2034
2035 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2036
58179cce 20372011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
2038
2039 Support MSVC build with newer versions of Visual Studio.
2040 * w32.c: Don't include w32api.h for MSVC.
2041 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2042
2043 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2044 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2045 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2046 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2047 e_* cousins.
2048 (alloca) [_MSC_VER]: Define to _alloca.
2049
2050 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2051
2052 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2053
a58c13ed
EZ
20542011-11-04 Eli Zaretskii <eliz@gnu.org>
2055
2056 * xdisp.c (note_mouse_highlight): If either of
2057 previous/next-single-property-change returns nil, treat that as
2058 the beginning or the end of the buffer. (Bug#9955)
2059
fe0b6370
JD
20602011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2061
a58c13ed 2062 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
2063 label is not null (Bug#9951).
2064 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2065 may be NULL.
2066
89bd5ee1
EZ
20672011-11-04 Eli Zaretskii <eliz@gnu.org>
2068
2069 * window.c (Fwindow_body_size): Mention in the doc string that the
2070 return value is in frame's canonical units. (Bug#9949)
2071
84c3edb9
EZ
20722011-11-03 Eli Zaretskii <eliz@gnu.org>
2073
4e2fb5c7
EZ
2074 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2075
84c3edb9 2076 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 2077 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 2078 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 2079
bc17a887
EZ
20802011-11-01 Eli Zaretskii <eliz@gnu.org>
2081
2082 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2083 Don't stop backward scan on the continuation glyph, even though
2084 its CHARPOS is positive.
6d5eb5b0
SM
2085 (mouse_face_from_buffer_pos, note_mouse_highlight):
2086 Rename cover_string to disp_string.
bc17a887 2087
4ee88440
MR
20882011-11-01 Martin Rudalics <rudalics@gmx.at>
2089
2090 * window.c (temp_output_buffer_show): Don't use
2091 Vtemp_buffer_show_specifiers.
2092 (Vtemp_buffer_show_specifiers): Remove unused variable.
2093
c2ff3c02
EZ
20942011-10-30 Eli Zaretskii <eliz@gnu.org>
2095
2096 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2097 past the beginning of the current glyph matrix.
2098
58179cce 20992011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
2100
2101 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2102 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2103 HAVE_GTK3 (Bug#9869).
b77a6a7f 2104
3b574623
JD
2105 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2106 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2107
b77a6a7f
JD
2108 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2109
2110 * xterm.c: Declare x_handle_net_wm_state to return int.
2111 (handle_one_xevent): Check if we are iconified but don't have
2112 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2113 (get_current_wm_state): Return non-zero if not hidden,
2114 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2115 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2116 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2117 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2118
196e41e4
PE
21192011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2120
2121 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2122 so that this new function doesn't get optimized away by a
2123 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2124
021f2e1a
AS
21252011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2126
2127 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2128
8b058d44
EZ
21292011-10-29 Eli Zaretskii <eliz@gnu.org>
2130
2131 Fix the `xbytecode' command.
2132 * .gdbinit (xprintbytestr): New command.
b50a28de 2133 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
2134 (xbytecode): Print the byte-code string as well.
2135
4452fb80
EZ
21362011-10-29 Kim Storm <storm@cua.dk>
2137
8b058d44
EZ
2138 * alloc.c (which_symbols): New function.
2139
21b72067
AS
21402011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2141
2142 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2143 line. (Bug#9903)
2144
83ed7b5c
GM
21452011-10-29 Glenn Morris <rgm@gnu.org>
2146
2147 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2148 Not clear what it was for, and it causes various bugs. (Bug#9839)
2149
5a7a728b
EZ
21502011-10-28 Eli Zaretskii <eliz@gnu.org>
2151
2152 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2153 possible random value that matches one of those tested as
2154 condition to clear the mouse face.
2155
d3d0842f
CY
21562011-10-28 Chong Yidong <cyd@gnu.org>
2157
2158 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2159
31b39d13
DN
21602011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2161
2162 * window.c (make_window): Initialize phys_cursor_on_p.
2163
9aba6043
SM
21642011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2165
2166 * lisp.h (struct Lisp_Symbol): Update comments.
2167
c20992f4
JB
21682011-10-28 Juanma Barranquero <lekktu@gmail.com>
2169
2170 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2171
db4f02f2
EZ
21722011-10-28 Eli Zaretskii <eliz@gnu.org>
2173
2174 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2175 <oslsachem@gmail.com> for helping to debug this.
2176
2177 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2178 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2179 (g_b_init_get_glyph_outline_w): New static variables.
2180 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2181 (GetGlyphOutlineW_Proc): New typedefs.
2182 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2183 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2184 New functions.
2185 (w32font_open_internal, compute_metrics):
2186 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2187 instead of calling the "wide" APIs directly.
2188
2189 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2190
2191 * w32.h (syms_of_w32font): Add prototype.
2192
87e68db4
JB
21932011-10-27 Juanma Barranquero <lekktu@gmail.com>
2194
2195 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2196 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2197 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2198 (Fmove_to_window_line): Doc fix.
2199
435c1d67
CY
22002011-10-27 Chong Yidong <cyd@gnu.org>
2201
2202 * process.c (make_process): Set gnutls_state to NULL.
2203
2204 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2205 non-NULL, regardless of GNUTLS_INITSTAGE.
2206 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2207 an error. Set process slots as soon as we allocate them.
2208
2209 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2210
9c6c6f49
CY
22112011-10-27 Chong Yidong <cyd@gnu.org>
2212
9aba6043
SM
2213 * gnutls.c (emacs_gnutls_deinit): New function.
2214 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2215 (Fgnutls_deinit, Fgnutls_boot): Use it.
2216
2217 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2218 (deactivate_process): Call emacs_gnutls_deinit.
2219
657d08d3
JB
22202011-10-27 Juanma Barranquero <lekktu@gmail.com>
2221
2222 * image.c (x_create_x_image_and_pixmap):
2223 * w32.c (sys_rename, w32_delayed_load):
2224 * w32font.c (fill_in_logfont):
2225 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2226
5430d399
JB
22272011-10-26 Juanma Barranquero <lekktu@gmail.com>
2228
2229 * w32fns.c (w32_default_color_map): New function,
2230 extracted from Fw32_default_color_map.
a7ef684b 2231 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2232
fe0055fa
PE
22332011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2234
2235 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2236
e6346438
SM
22372011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2238
2239 * keyboard.c (test_undefined): New function (bug#9751).
2240 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2241
e112cc37
ET
22422011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2243
2244 * sysdep.c (init_sys_modes): Fix the check for the controlling
2245 terminal (Bug#6649).
2246
7b5d6677
EZ
22472011-10-20 Eli Zaretskii <eliz@gnu.org>
2248
2249 * dispextern.h (struct bidi_it): New member next_en_type.
2250
2251 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2252 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2253 current character, check also for next_en_type being WEAK_EN.
2254 (bidi_resolve_weak): Don't enter the expensive loop if the current
2255 position is before next_en_pos. Record the bidi type of the first
2256 non-ET, non-BN character we find, in addition to its position.
2257 (bidi_level_of_next_char): Invalidate next_en_type when
2258 next_en_pos is over-stepped.
2259
7da0b018
PE
22602011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2261
2262 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2263 * editfns.c: Rewrite current-time-zone so that it invokes
2264 the equivalent of (format-time-string "%Z") to get the time zone name.
2265 This fixes a bug when the time zone name contains characters that
2266 need converting from the system time locale to Emacs internal format.
2267 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2268 that patch fixed format-time-string to do the conversion, but
2269 I forgot to fix current-time-zone.
2270 (format_time_string): New function, containing most of
2271 what Fformat_time_string used to contain.
2272 (Fformat_time_string): Rewrite in terms of format_time_string.
2273 This doesn't change this function's behavior.
2274 (current-time-zone): Rewrite to use format_time_string.
2275 This fixes the bug reported by Michael Schierl in
2276 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2277 Jason Rumney's 2007-06-07 change worked around this bug, but
2278 didn't fix it.
2279 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2280
8547b010
EZ
22812011-10-19 Eli Zaretskii <eliz@gnu.org>
2282
2283 * xdisp.c (start_display): If the character at POS is displayed
2284 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2285 (try_window_reusing_current_matrix): If a line ends in a display
2286 vector or the next line starts in a display vector, continue
2287 redrawing the window even though the character position of
2288 start_row was reached.
8547b010
EZ
2289 (Bug#9771, part 2)
2290
4e948d15
CY
22912011-10-18 Chong Yidong <cyd@gnu.org>
2292
2293 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2294 with nobreak-char-display too.
2295
4787455f
EZ
22962011-10-18 Eli Zaretskii <eliz@gnu.org>
2297
2298 Fix part 3 of bug#9771.
2299 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2300 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2301 non-neutral characters if the current character is a paragraph
2302 separator (a.k.a. Newline). This avoids running the same
2303 expensive loop twice, once when we consume the preceding newline
2304 and the other time when the line actually needs to be displayed.
2305 Avoid the loop when we see neutrals on the base embedding level
2306 following a character whose directionality is the same as the
2307 paragraph's. This avoids running the expensive loop when a line
2308 ends in a long sequence of neutrals, like control characters.
2309 Add assertion against STRONG_AL type. Slightly rearrange code
2310 that determines the type of a neutral given the first non-neutral
2311 that follows it.
2312 (bidi_level_of_next_char): Set next_en_pos to zero when
2313 invalidating its info.
2314
2c91f553
EZ
23152011-10-17 Eli Zaretskii <eliz@gnu.org>
2316
2317 * xdisp.c (push_display_prop): Determine whether to record string
2318 or buffer position by IT->string, not by IT->method. Allow
2319 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2320 (move_it_vertically_backward): Don't look for character position
2321 immediately after the newline when in a continuation line.
2322 (Bug#9771, part 1)
2c91f553 2323
c7b08b0d
MR
23242011-10-15 Martin Rudalics <rudalics@gmx.at>
2325
2326 * window.c (coordinates_in_window): Rewrite and delabelize
2327 vertical border check. (Bug#5357) (Bug#9618)
2328
6b02f655
SM
23292011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2330
2331 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2332 errors in XSetWindowBorder (bug#9310).
2333
81d40c92
DA
23342011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2335
2336 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2337 avoid crash when xmalloc overrun checking is enabled.
2338
d4172c3b
EZ
23392011-10-13 Eli Zaretskii <eliz@gnu.org>
2340
2341 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2342 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2343 cursor motion with <left> and <right> arrow keys.
2344
2345 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2346 some callers set that themselves.
2347
b00eea75
EZ
23482011-10-12 Eli Zaretskii <eliz@gnu.org>
2349
2350 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2351 display string and the previous row comes from the same string and
2352 is empty. (Bug#9739) (Bug#9738)
2353
8fe012c4
SM
23542011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2355
2356 * doc.c (get_doc_string): Encode file name (bug#9735).
2357
0074aef2
EZ
23582011-10-12 Eli Zaretskii <eliz@gnu.org>
2359
79beb178
EZ
2360 * bidi.c (bidi_level_of_next_char):
2361 * xdisp.c (get_visually_first_element): Remove old incorrect
2362 comments regarding the Unicode Line Separator character.
2363
0074aef2
EZ
2364 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2365
6e4b3fbe
DA
23662011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2367
2368 * alloc.c (Fgc_status): Do not access beyond zombies array
2369 boundary if nzombies > MAX_ZOMBIES.
2370 * alloc.c (dump_zombies): Add missing format specifier.
2371
0324f3af
PE
23722011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2373
b5525cac
PE
2374 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2375 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2376
0324f3af
PE
2377 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2378 Some packages use them to denote characters with modifiers.
2379
e9b5f888
AS
23802011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2381
2382 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2383 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2384 matching a pp-number. Rename parameter var to var1.
2385
127827c0
SM
23862011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2387
2388 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2389
c8fd3bd0
GM
23902011-10-08 Glenn Morris <rgm@gnu.org>
2391
2392 * callint.c (Fcall_interactively): Give a more explicit error for the
2393 'c' case with a non-character input. (Bug#8479)
2394
352ec8ff
EZ
23952011-10-08 Eli Zaretskii <eliz@gnu.org>
2396
03669ccb
EZ
2397 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2398 lines.
7061c986
EZ
2399 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2400 lines that are hscrolled on the left.
03669ccb 2401
352ec8ff
EZ
2402 * dispnew.c (buffer_posn_from_coords): Account for a possible
2403 presence of header-line. (Bug#4426)
2404
a66cfb1c
SM
24052011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2406
6b02f655
SM
2407 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2408 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2409
7c5ee88e
PE
24102011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2411
2412 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2413 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2414 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2415 this makes Emacs dump core during garbage collection on rare
2416 occasions. sizeof is obviously inferior to offsetof here, so
2417 stick with offsetof.
2418 (GC_POINTER_ALIGNMENT): New macro.
2419 (mark_memory): Omit 3rd (offset) arg; caller changed.
2420 Don't assume EMACS_INT alignment is the same as pointer alignment.
2421
df1bbe5b
SM
24222011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2423
2424 * keyboard.c (read_key_sequence_remapped): New var.
2425 (read_key_sequence): Compute remapping in the right buffer.
2426 (command_loop_1): Use read_key_sequence's remapping directly.
2427
51553db6
SM
24282011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2429
32c1fffd
SM
2430 * dired.c (file_name_completion): Don't expand file name.
2431 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2432 before checking file name handler.
2433
51553db6
SM
2434 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2435 they've been requested explicitly (bug#9591).
2436
b6bd1599 24372011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2438
2439 * keymap.c (Fsingle_key_description): Use make_specified_string
2440 instead of build_string to build string from push_key_description.
2441 (Bug#5193)
2442
f701dc2a
PE
24432011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2444
4222c55d
PE
2445 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2446 This fixes a Y2038 bug on 64-bit hosts.
2447 * buffer.c (reset_buffer):
2448 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2449 (Fclear_buffer_auto_save_failure):
2450 Use 0, not -1, to represent an unset failure time, since time_t
2451 might not be signed.
2452
f701dc2a
PE
2453 Remove dependency on glibc malloc internals.
2454 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2455 Move back here from lisp.h, but with their new implementations.
2456 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2457 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2458 * charset.c (charset_table_init): New static var.
2459 (syms_of_charset): Use it instead of xmalloc. This removes a
2460 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2461 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2462 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2463 Move back to alloc.c.
2464 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2465 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2466
9ceebf39
JD
24672011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2468
2469 * nsterm.m (windowDidResize): Call x_set_window_size only when
2470 ns_in_resize is true. Otherwise set pixelwidth/height and
2471 call change_frame_size (Bug#9628).
2472
cb993c58
PE
24732011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2474
3930c88b
PE
2475 Port --enable-checking=all to Fedora 14 x86-64.
2476 * charset.c (syms_of_charset): Also account for glibc malloc's
2477 internal overhead when calculating the initial malloc maximum.
2478
cb993c58
PE
2479 Port --enable-checking=all to Fedora 14 x86.
2480 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2481 Move to lisp.h.
2482 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2483 (overrun_check_realloc, overrun_check_free):
2484 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2485 That way, xmalloc returns a properly-aligned pointer even if
2486 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2487 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2488 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2489 into account when calculating the initial malloc maximum.
2490 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2491 Move here from alloc.c, so that charset.c can use it too.
2492 Properly align; the old code wasn't right for common 32-bit hosts
2493 when configured with --enable-checking=all.
2494 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2495 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2496
31bed486
EZ
24972011-09-29 Eli Zaretskii <eliz@gnu.org>
2498
04c70788 2499 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2500 use EDOM.
2501
fbcaa2f3
EZ
25022011-09-28 Eli Zaretskii <eliz@gnu.org>
2503
2504 * xdisp.c (compute_display_string_end): If there's no display
2505 string at CHARPOS, return -1.
2506
2507 * bidi.c (bidi_fetch_char): When compute_display_string_end
2508 returns a negative value, treat the character as a normal
2509 character not covered by a display string. (Bug#9624)
2510
a239d4e9
JB
25112011-09-28 Juanma Barranquero <lekktu@gmail.com>
2512
2513 * lread.c (Fread_from_string): Fix typo in docstring.
2514
88652fd5
EZ
25152011-09-27 Eli Zaretskii <eliz@gnu.org>
2516
2517 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2518 newline, reseat the iterator instead of bidi-iterating there one
2519 character at a time. (Bug#9610)
32c1fffd
SM
2520 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2521 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2522
ed497dd4
AS
25232011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2524
2525 * lread.c (readevalloop): Use correct code for NBSP.
2526 (read1): Likewise. (Bug#9608)
2527
b2bf61aa
MA
25282011-09-25 Michael Albinus <michael.albinus@gmx.de>
2529
2530 * dbusbind.c (Fdbus_register_signal): When service is not
2531 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2532
32bbb17c
GM
25332011-09-25 Glenn Morris <rgm@gnu.org>
2534
2535 * buffer.c (truncate-lines): Doc fix.
2536
94e0933e
CY
25372011-09-24 Chong Yidong <cyd@stupidchicken.com>
2538
2539 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2540 (Fset_window_next_buffers): Doc fix.
2541
cddde921
GM
25422011-09-24 Glenn Morris <rgm@gnu.org>
2543
2544 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2545
1260aef1
PE
25462011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2547
25b4bfa0
PE
2548 Fix minor problems found by static checking.
2549 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2550 * indent.c (Fvertical_motion): Fix == vs = typo.
2551
e3cbd34b
EZ
25522011-09-24 Eli Zaretskii <eliz@gnu.org>
2553
a66cfb1c
SM
2554 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2555 Default value is now t. Doc fix.
6bf7006f 2556
e3cbd34b 2557 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2558 logic when moving up, not only when moving down. Fix the
e3cbd34b 2559 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2560 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2561
2562 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2563 CHARPOS is covered by a display string which includes newlines.
2564 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2565 is covered by a display string with embedded newlines.
2566
a3de0cbd
MA
25672011-09-24 Michael Albinus <michael.albinus@gmx.de>
2568
2569 * dbusbind.c (Fdbus_register_signal): Add match rule to
2570 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2571 (Fdbus_register_method, Vdbus_registered_objects_table):
2572 Fix docstring.
a3de0cbd 2573
b260039d
JM
25742011-09-24 Jim Meyering <meyering@redhat.com>
2575
32c1fffd 2576 do not ignore write error for any output size
b260039d
JM
2577 The previous change was incomplete.
2578 While it makes emacs --batch detect the vast majority of stdout
2579 write failures, errors were still ignored whenever the output size is
2580 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2581 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2582 && echo FAIL: ignored write error
2583 FAIL: ignored write error
2584 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2585 && echo FAIL: ignored write error
2586 FAIL: ignored write error
2587 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2588
8eca8a7c
AS
25892011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2590
2591 * emacs.c (Fkill_emacs): In noninteractive mode exit
2592 non-successfully if a write error occurred on stdout. (Bug#9574)
2593
3341db62
EZ
25942011-09-21 Eli Zaretskii <eliz@gnu.org>
2595
2596 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2597 the xassert test.
2598
2599 * dispextern.h (struct it): Update the comment documenting what
2600 can it->OBJECT be.
2601
8c203dbf
EZ
26022011-09-20 Eli Zaretskii <eliz@gnu.org>
2603
2604 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2605 a display string, extend search for cursor position to end of row.
2606 (find_row_edges): If the row ends in a newline from a display
2607 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2608 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2609 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2610 non-empty line. Fixes confusing cursor motion with arrow keys at
2611 the beginning of a line that starts with whitespace.
8c203dbf 2612
a4824228
LMI
26132011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2614
2615 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2616 (bug#9493).
2617
33ed493b
CY
26182011-09-18 Chong Yidong <cyd@stupidchicken.com>
2619
2620 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2621 boolean (Bug#9154).
2622
56cd55c8
EZ
26232011-09-18 Eli Zaretskii <eliz@gnu.org>
2624
2625 * xdisp.c (display_line): Record maximum and minimum buffer
2626 positions even if no glyphs were produced (e.g., by a zero-width
2627 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2628 buffer positions that will be removed from the glyph row because
2629 they don't fit.
c02dcedf
EZ
2630 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2631 column is beyond frame width: don't subtract 1 "pixel" when
2632 computing width of the stretch.
3e62b7e0
EZ
2633 (reseat_at_next_visible_line_start): Undo the change made on
2634 2011-09-17 that saved paragraph information and restored it after
2635 the call to `reseat'. (Bug#9545)
56cd55c8 2636
5ed99d36 26372011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2638
2639 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2640 and turn window cursor on if cleared (Bug#9415).
2641
5ed99d36 26422011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2643
2644 * search.c (boyer_moore): Take unibyte characters from pattern
2645 literally. (Bug#9458)
2646
9bade7b2
EZ
26472011-09-18 Eli Zaretskii <eliz@gnu.org>
2648
2649 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2650
e5e9d610
PE
26512011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2652
87e4427a
PE
2653 Fix minor problem found by static checking.
2654 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2655 initialized, to pacify gcc -Wuninitialized.
2656
e5e9d610
PE
2657 * fileio.c: Report proper errno when syscall falls.
2658 (Finsert_file_contents): Save and restore errno,
2659 so that report_file_error outputs the correct diagnostic.
2660 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2661
a1674f0b
EZ
26622011-09-18 Eli Zaretskii <eliz@gnu.org>
2663
2664 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2665
fbfb6dd4
EZ
26662011-09-17 Eli Zaretskii <eliz@gnu.org>
2667
2668 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2669 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2670
bb187662
EZ
26712011-09-17 Eli Zaretskii <eliz@gnu.org>
2672
1137e8b8 2673 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2674 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2675
2676 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2677 (bidi_find_paragraph_start): Search back for paragraph beginning
2678 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2679 (bidi_move_to_visually_next): Only trigger paragraph-related
2680 computations when the last character is a newline or at EOB, not
2681 just any NEUTRAL_B. (Bug#9470)
2682
bb187662
EZ
2683 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2684 truncated lines if point is covered by a display string. (Bug#9524)
2685
2e621251
PE
26862011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2687
2688 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2689 (cons_to_x_long): New function.
2690 (lisp_data_to_selection_data): Use it. Correct the test for
2691 short-versus-long data; it was negated. Break out of vector
2692 loop, for efficiency, when a long datum is discovered.
2693
91a15bc6
SM
26942011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2695
2696 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2697
b41c3a35
EZ
26982011-09-16 Eli Zaretskii <eliz@gnu.org>
2699
2700 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2701 GCC PR/17406) by declaring this function with external scope.
2702
7812ba2d
PE
27032011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2704
2705 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2706 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2707
cf7edc2a
AS
27082011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2709
2710 * editfns.c (Fformat): Correctly handle text properties on "%%".
2711
bd01620e
EZ
27122011-09-15 Eli Zaretskii <eliz@gnu.org>
2713
2714 * xterm.c (x_draw_composite_glyph_string_foreground):
2715 * w32term.c (x_draw_composite_glyph_string_foreground):
2716 * term.c (encode_terminal_code):
2717 * composite.c (composition_update_it, get_composition_id):
2718 * xdisp.c (get_next_display_element)
2719 (fill_composite_glyph_string): Add comments about special meaning
2720 of TAB characters in a composition.
2721
a02719a3
PE
27222011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2723
2724 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2725 This occurs when processing a multibyte format.
2726 Problem reported by Wolfgang Jenker.
a02719a3 2727
72589a3c
JB
27282011-09-15 Johan Bockgård <bojohan@gnu.org>
2729
2730 * xdisp.c (try_cursor_movement): Only check for exact match if
2731 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2732
1c14176c
PE
27332011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2734
2735 Remove unused external symbols.
2736 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2737 * xdisp.c (calc_pixel_width_or_height): Now static.
2738 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2739 * indent.c (check_display_width):
2740 * w32term.c: Fix comment to match code.
2741 * xterm.c, xterm.h (x_catching_errors): Remove.
2742
d2eea5b5
PE
27432011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2744
2745 * xselect.c: Use signed conversions more consistently (Bug#9498).
2746 (selection_data_to_lisp_data): Assume incoming selection data are
2747 signed integers, not unsigned. This is to be consistent with
2748 outgoing selection data, which was modified to use signed integers
2749 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2750 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2751 expects long, not unsigned long.
2752
46888499
EZ
27532011-09-14 Eli Zaretskii <eliz@gnu.org>
2754
2755 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2756 computation of loop end. Reported by Johan Bockgård
2757 <bojohan@gnu.org>.
2758
ef8ef9fb
CY
27592011-09-13 Chong Yidong <cyd@stupidchicken.com>
2760
2761 * frame.c (Fother_visible_frames_p): Function deleted.
2762
fa819fed
EZ
27632011-09-12 Eli Zaretskii <eliz@gnu.org>
2764
2765 * indent.c (compute_motion): Process display vector front to back
2766 rather than the other way around. (Bug#2496)
2767
2ba8e008
SM
27682011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2769
2770 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2771
20f53c69
CY
27722011-09-11 Chong Yidong <cyd@stupidchicken.com>
2773
2774 * minibuf.c (Fread_from_minibuffer): Doc fix.
2775
d562d7a4
EZ
27762011-09-11 Eli Zaretskii <eliz@gnu.org>
2777
2778 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2779 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2780
1c4d7f3d
LMI
27812011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2782
2783 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2784 value for non-existent files.
2785
b885bf36
EZ
27862011-09-11 Eli Zaretskii <eliz@gnu.org>
2787
2788 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2789 set its "size" to -1. This will set the modtime_size field of
2790 the corresponding buffer to -1, which is what
2791 verify-visited-file-modtime expects for files that do not exist.
2792 (Bug#9139)
2793
6612f0bf
PE
27942011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2795
2796 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2797 here ...
2798 * lisp.h: ... from here. push_key_description is no longer
2799 defined in keyboard.c, so its declaration should not be in
2800 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2801 logically belongs with push_key_description.
2802
dfb3f755
PE
28032011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2804
2805 * buffer.h: Include <sys/types.h> instead of <time.h>.
2806 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2807 Problem reported by Herbert J. Skuhra.
2808
3134906c
LMI
28092011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2810
2811 * xml.c (parse_region): Make the parsing work for
2812 non-comment-starting XML files again (bug#9144).
2813
8d903f4e
AS
28142011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2815
2816 * image.c (gif_load): Fix calculation of bottom and right corner.
2817 (Bug#9468)
2818
80ad64f4
EZ
28192011-09-10 Eli Zaretskii <eliz@gnu.org>
2820
2821 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2822 redisplay in small windows.
2823
208a048d
EZ
28242011-09-09 Eli Zaretskii <eliz@gnu.org>
2825
2826 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2827
9b1c252e
MR
28282011-09-08 Martin Rudalics <rudalics@gmx.at>
2829
2830 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2831 Operate on live windows only.
2832
2949f33b
JB
28332011-09-08 Juanma Barranquero <lekktu@gmail.com>
2834
2835 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2836
e08dcafd
EZ
28372011-09-07 Eli Zaretskii <eliz@gnu.org>
2838
2839 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2840 only under bidi iteration.
2841
115b96bd
JD
28422011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2843
2844 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2845
c8199d0f
PE
28462011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2849 Without this fix, the command to link temacs failed due to an
2850 undefined symbol __builtin_isnan. This is because
2851 /usr/include/iso/math_c99.h #defines isnan(x) to
2852 __builtin_isnan(x), but the bundled gcc, which identifies itself
2853 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2854 a __builtin_isnan.
2855 * floatfns.c (isnan): #undef, and then #define to a clone of
2856 what's in data.c.
2857 (Fisnan): Always define, since it's always available now.
2858 (syms_of_floatfns): Always define isnan at the Lisp level.
2859
e39b275c 28602011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2861
2862 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2863
b2db44d9 28642011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2865
f4af5137 2866 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2867 The previous code assumed that file offsets (off_t values) fit in
2868 EMACS_INT variables, which is not true on typical 32-bit hosts.
2869 The code messed up by falsely reporting buffer overflow in cases
2870 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2871 when "big" contains more than 2**29 bytes, even though this
2872 inserts just one byte and does not overflow the buffer.
2873 (Finsert_file_contents): Store file offsets as off_t
2874 values, not as EMACS_INT values. Check for overflow when
2875 converting between EMACS_INT and off_t. When checking for
2876 buffer overflow or for overlap, take the offsets into account.
2877 Don't use EMACS_INT for small values where int suffices.
2878 When checking for overlap, fix a typo: ZV was used where
2879 ZV_BYTE was intended.
2880 (Fwrite_region): Don't assume off_t fits into 'long'.
2881 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2882
ecfc0a49
MA
28832011-09-05 Michael Albinus <michael.albinus@gmx.de>
2884
2885 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2886
6511acf2 28872011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2888
0999621a 2889 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2890
2891 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2892 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2893 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2894 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2895 (modify_event_symbol): Do not assume that the length of
2896 name_alist_or_stem is safe to alloca and fits in int.
2897 (Fexecute_extended_command): Likewise for function name and binding.
2898 (Frecursion_depth): Wrap around reliably on integer overflow.
2899 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2900 since some callers pass EMACS_INT values.
2901 (Fsingle_key_description): Don't crash if symbol name contains more
2902 than MAX_ALLOCA bytes.
2903 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2904 (get_minibuffer): Arg is now EMACS_INT, not int.
2905 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2906 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2907 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2908
2be7d702
PE
2909 * dbusbind.c (signature_cat): New function.
2910 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2911 Do not overrun buffer; instead, report string overflow.
2912
9d1df220
PE
2913 * dispnew.c (add_window_display_history): Don't overrun buffer.
2914 Truncate instead; this is OK since it's just a log.
2915
33ef5c64
PE
2916 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2917 even if the time zone offset is outlandishly large.
2918 Don't mishandle offset == INT_MIN.
2919
66c6fdd5
PE
2920 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2921 when creating daemon; the previous buffer-overflow check was incorrect.
2922
d749b01b
PE
2923 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2924 which has the guts of the old verror function.
2925
b5cd1905
PE
2926 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2927 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2928
6e1a67fb
PE
2929 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2930 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2931 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2932 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2933 length of string rather than counting it via multiple sprintfs;
2934 that's simpler and more reliable.
c21721cc
PE
2935 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2936 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2937 sprintf, in case result does not fit in int.
2938
c57b67fc
PE
2939 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2940 (fontset_from_font): Print it.
2941
8a401434
PE
2942 * frame.c (tty_frame_count): Now printmax_t, not int.
2943 (make_terminal_frame, set_term_frame_name): Print it.
2944 (x_report_frame_params): In X, window IDs are unsigned long,
2945 not signed long, so print them as unsigned.
2946 (validate_x_resource_name): Check for implausibly long names,
2947 and don't assume name length fits in 'int'.
2948 (x_get_resource_string): Don't blindly alloca invocation name;
2949 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2950 not fit in int.
2951
6e1a67fb
PE
2952 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2953 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2954 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2955
0df02bf3
PE
2956 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2957 Use esprintf, not sprintf, in case result does not fit in int.
2958
48e30793
PE
2959 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2960 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2961 it as a large positive number.
2962 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2963 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2964
a66ff6d8
PE
2965 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2966 in case result does not fit in int.
2967
aca216ff
PE
2968 * print.c (float_to_string): Detect width overflow more reliably.
2969 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2970 buffer overrun. Don't assume list length fits in 'int'. Treat
2971 print length of 0 as 0, not as infinity; to be consistent with other
2972 uses of print length in this function. Don't overflow print length
2973 index. Don't assume hash table size fits in 'long', or that
2974 vectorlike size fits in 'unsigned long'.
2975
31c286f7
PE
2976 * process.c (make_process): Use printmax_t, not int, to format
2977 process-name gensyms.
2978
55e5faa1
PE
2979 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2980
80f2e268
PE
2981 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2982 to avoid potential buffer overrun.
2983
670741ab
PE
2984 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2985 if X resource line is longer than 512 bytes.
2986
b7163a50
PE
2987 * xfns.c (x_window): Make sprintf buffer a bit bigger
2988 to avoid potential buffer overrun.
2989
ae58ff1f
PE
2990 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2991
c43c8a6a
PE
2992 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2993
3f8236f4
PE
29942011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2995
53e9fe90 2996 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2997 Without these, Emacs silently mishandles large integers sometimes.
2998 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2999 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3000
6511acf2
PE
3001 * xdisp.c (try_window_id): Check Emacs fixnum range before
3002 converting to 'int'.
806add1d 3003
6511acf2 3004 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
3005 Check that an Emacs fixnum is in range before assigning it to 'int'.
3006 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3007 values converted from Emacs fixnums.
3008 (Frecenter): Don't wrap around a line count if it is out of 'int'
3009 range; instead, treat it as an extreme value.
3010 (Fset_window_configuration, compare_window_configurations):
3011 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3012
6511acf2
PE
3013 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3014 that can exceed INT_MAX. Check that EMACS_INT value is in range
3015 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
3016 (match_limit): Don't assume that a fixnum can fit in 'int'.
3017
6511acf2 3018 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
3019 exceed INT_MAX.
3020
6511acf2 3021 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
3022 (Fvertical_motion): Don't wrap around LINES values that don't fit
3023 in 'int'. Instead, treat them as extreme values. This is good
3024 enough for windows, which can't have more than INT_MAX lines anyway.
3025
fcb901a7
LMI
30262011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3027
0f2f6b6d
LMI
3028 * Require libxml/parser.h to avoid compilation warning.
3029
fcb901a7
LMI
3030 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3031
3032 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3033 since this reportedly can destroy thread storage.
3034
6e20a0d4
CY
30352011-08-30 Chong Yidong <cyd@stupidchicken.com>
3036
3037 * syntax.c (find_defun_start): Update all cache variables if
3038 exiting early (Bug#9401).
3039
148ae00e
EZ
30402011-08-30 Eli Zaretskii <eliz@gnu.org>
3041
f6cfbd8f
EZ
3042 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3043
148ae00e
EZ
3044 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3045 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3046 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3047
3048 * term.c (tty_append_glyph): New function.
3049 (produce_stretch_glyph): Static function and its prototype deleted.
3050
a66cfb1c
SM
3051 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3052 Add prototypes.
148ae00e 3053
c4a07a4c
PE
30542011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3055
3056 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3057 when checking :margin (Bug#9390).
3058 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 3059 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
3060 so that the name doesn't mislead. All uses changed.
3061
6bc8cd65
JB
30622011-08-28 Johan Bockgård <bojohan@gnu.org>
3063
3064 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3065 set_tty_hooks.
3066
dca4927e
EZ
30672011-08-27 Eli Zaretskii <eliz@gnu.org>
3068
3069 * xdisp.c (move_it_to): Don't bail out early when reaching
3070 position beyond to_charpos, if we are scanning backwards.
3071 (move_it_vertically_backward): When DY == 0, make sure we get to
3072 the first character in the line after the newline.
3073
f2cad773
PE
30742011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3075
3076 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3077 (ccl_driver): Do not generate an out-of-range pointer.
3078 (Fccl_execute_on_string): Remove unnecessary check for
3079 integer overflow, noted by Stefan Monnier in
3080 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3081 Remove a FIXME that didn't need fixing.
3082 Simplify the newly-introduced buffer reallocation code.
3083
0cae2cdb
JB
30842011-08-27 Juanma Barranquero <lekktu@gmail.com>
3085
3086 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3087
5fc295a4 30882011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 3089
70c60eb2 3090 Integer and memory overflow issues (Bug#9196).
726e0ab1 3091
d31850da
PE
3092 * doc.c (get_doc_string): Rework so that
3093 get_doc_string_buffer_size is the actual buffer size, rather than
3094 being 1 less than the actual buffer size; this makes xpalloc more
3095 convenient.
3096
a69fbedb
PE
3097 * image.c (x_allocate_bitmap_record, cache_image):
3098 * xselect.c (Fx_register_dnd_atom):
3099 Simplify previous changes by using xpalloc.
3100
fe5c5d37
PE
3101 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3102 since either will do and ptrdiff_t is convenient with xpalloc.
3103
0065d054
PE
3104 * charset.c (charset_table_size)
3105 (struct charset_sort_data.priority): Now ptrdiff_t.
3106 (charset_compare): Don't overflow if priorities differ greatly.
3107 (Fsort_charsets): Don't assume list length fits in int.
3108 Check for size-calculation overflow when allocating sort data.
3109 (syms_of_charset): Allocate an initial charset table that is
3110 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3111
3112 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3113
3114 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3115 The actual value is always <= INT_MAX, and leaving it unsigned made
3116 overflow checking harder.
3117
3118 * dispextern.h (struct glyph_matrix.rows_allocated)
3119 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3120 with xpalloc. The values are still always <= INT_MAX.
3121
3122 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3123
3124 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3125 (SAFE_NALLOCA): New macro.
3126
3127 * region-cache.c (struct boundary.pos, find_cache_boundary)
3128 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3129 (set_cache_region, invalidate_region_cache)
3130 (revalidate_region_cache, know_region_cache, region_cache_forward)
3131 (region_cache_backward, pp_cache):
3132 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3133 so that ptrdiff_t * can be passed to xpalloc.
3134 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3135 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3136 (pp_cache): Don't assume cache_len fits in int.
3137 * region-cache.h: Adjust extern decls to match.
3138
3139 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3140 EMACS_INT, since either will do, for xpalloc.
3141
3142 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3143 (xnmalloc, xnrealloc, xpalloc): New functions.
3144
726e0ab1
PE
3145 * bidi.c (bidi_shelve_header_size): New constant.
3146 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3147 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3148
51f30bc5 3149 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3150 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3151 (overlay_strings):
3152 Don't update size of array until after memory allocation succeeds,
3153 because xmalloc/xrealloc may not return.
0065d054
PE
3154 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3155 now that we have proper integer overflow checking.
3156 (record_overlay_string, overlay_strings): Catch overflows when
3157 calculating size of overlay_str_buf.
726e0ab1 3158
0065d054
PE
3159 * callproc.c (Fcall_process): Check for size overflow when
3160 calculating size of args2.
3161 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3162 Normally we prefer signed values, but sticking with ptrdiff_t would
3163 require adding more-complicated checks.
726e0ab1
PE
3164
3165 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3166 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3167 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3168 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3169
3170 * character.c (Fstring): Check for size-calculation overflow.
3171
3172 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3173 unnecessary integer overflow. Check for size overflow.
3174 (encode_coding_object): Don't update size until xmalloc succeeds.
3175
3176 * composite.c (get_composition_id): Check for overflow in glyph
3177 length calculations.
3178
3179 Integer and memory overflow fixes for display code.
3180 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3181 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3182 (scrolling_window): Check for overflow in size calculations.
3183 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3184 Don't assume glyph table len fits in int.
3185 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3186 (row_table_size): Now ptrdiff_t, not int.
3187 (scrolling_window): Avoid overflow in size calculations.
3188 Don't update size until allocation succeeds.
3189 * fns.c (concat): Check for overflow in size calculations.
3190 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3191 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3192 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3193
3194 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3195 (get_doc_string): Check for size calculation overflow.
3196 Don't update size until allocation succeeds.
3197 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3198 EMACS_INT, where ptrdiff_t will do.
3199 (Fsubstitute_command_keys): Check for string overflow.
3200
3201 * editfns.c (set_time_zone_rule): Don't assume environment length
3202 fits in int.
3203 (message_length): Now ptrdiff_t, not int.
3204 (Fmessage_box): Don't update size until allocation succeeds.
3205 Don't assume message length fits in int.
3206 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3207
0065d054
PE
3208 * emacs.c (main): Do not reallocate argv, since there is a null at
3209 the end that can be overwritten, and this way there's no need to
3210 worry about size-calculation overflow.
3211 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3212
3213 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3214 alloc succeeds.
3215 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3216
3217 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3218 (x_set_scroll_bar_width, x_figure_window_size):
3219 Check for integer overflow.
3220 (x_set_alpha): Do not assume XINT fits in int.
3221
3222 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3223 This is for the members text_lines, text_cols, total_lines, total_cols,
3224 where the system imposes an 'int' limit.
3225
3226 * fringe.c (Fdefine_fringe_bitmap):
3227 Don't update size until alloc works.
3228
3229 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3230 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3231
3232 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3233 Check for size-calculation overflow.
3234 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3235 do, as we prefer signed integers.
3236 (id_to_widget.max_size, id_to_widget.used)
3237 (xg_store_widget_in_map, xg_remove_widget_from_map)
3238 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3239 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3240 Use and return ptrdiff_t, not int.
3241 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3242 * gtkutil.h: Change prototypes to match the above.
3243
3244 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3245 are duplicate now that they've been promoted to lisp.h.
3246 (x_allocate_bitmap_record, x_alloc_image_color)
3247 (make_image_cache, cache_image, xpm_load):
3248 Don't update size until alloc is done.
3249 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3250 (x_detect_edges):
3256efce 3251 Check for size calculation overflow.
726e0ab1
PE
3252 (ct_colors_allocated_max): New constant.
3253 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3254 overflow.
3256efce 3255
726e0ab1
PE
3256 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3257 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3258 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3259 Use ptrdiff_t, not int, to count maps.
3260 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3261 calculations. Don't update size until allocation succeeds.
3262 Redo calculations to avoid overflow.
726e0ab1
PE
3263 * keyboard.h: Change prototypes to match the above.
3264
3265 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3266 to count maps.
3267 (current_minor_maps): Check for size calculation overflow.
3268 * keymap.h: Change prototypes to match the above.
3269
3270 * lread.c (read1, init_obarray): Don't update size until alloc done.
3271
3272 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3273 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3274
726e0ab1
PE
3275 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3276 Now ptrdiff_t, not int.
3277 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3278 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3279
3280 * process.c (Fnetwork_interface_list): Check for overflow
3281 in size calculation.
3282
3283 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3284
3285 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3286 overflow. Don't bother calling xmalloc when xrealloc will do.
3287
3288 * search.c (Freplace_match): Check for size calculation overflow.
3289 (Fset_match_data): Don't assume list lengths fit in 'int'.
3290
3291 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3292 for command line length. Do not attempt to address one before the
3293 beginning of an array, as that's not portable.
3294
3295 * term.c (max_frame_lines): Remove; unused.
3296 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3297 not int.
3298 (encode_terminal_code, calculate_costs): Check for size
3299 calculation overflow.
3300 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3301 table lengths and related sizes. Don't update size until alloc
3302 done. Redo calculations to avoid overflow.
3303 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3304
3305 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3306 subtracting pointers.
3307 (gobble_line): Check for overflow more carefully. Don't update size
3308 until alloc done.
3309
3310 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3311 Don't update size until alloc done.
3312 Redo size calculations to avoid overflow.
3313 Check for size calculation overflow.
0065d054 3314 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3315
3316 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3317 Use ptrdiff_t, not int, for sizes.
3318 (store_mode_line_noprop_char): Don't update size until alloc done.
3319
0065d054
PE
3320 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3321 Use ptrdiff_t, not int, for sizes.
3322 (Finternal_make_lisp_face, cache_face):
3323 Check for size calculation overflow.
3324 (cache_face): Treat size calculation overflows as if they were
3325 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3326
3327 * xfns.c (x_encode_text, x_set_name_internal)
3328 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3329 sizes, since they can exceed INT_MAX in size. Check for size
3330 calculation overflow.
3331
0065d054
PE
3332 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3333 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3334 Don't update size until alloc done.
3335
0065d054 3336 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3337 as sprintf is limited to int lengths.
1d526e2f 3338
252c5ee1
PE
3339 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3340 (X_LONG_MIN): New macros.
864d7ce7
PE
3341 Use them to make the following changes clearer.
3342 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3343 This change doesn't affect the value now, but it may help remind
3344 future maintainers not to raise the value too much later.
3345 (SELECTION_QUANTUM): Remove, replacing with ...
3346 (selection_quantum): ... new function, which avoids overflow.
3347 All uses changed.
3348 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3349 assumption that selection length fits in 'int'.
3350 (x_reply_selection_request, x_handle_selection_request)
3351 (x_get_window_property, receive_incremental_selection)
3352 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3353 (lisp_data_to_selection_data, clean_local_selection_data):
3354 Use ptrdiff_t, not int, to record length of selection.
3355 (x_reply_selection_request, x_get_window_property)
3356 (receive_incremental_selection, x_property_data_to_lisp):
3357 Redo calculations to avoid overflow.
3358 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3359 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3360 something.
3361 (x_get_window_property, receive_incremental_selection)
3362 (lisp_data_to_selection_data, x_property_data_to_lisp):
3363 Check for size-calculation overflow.
3364 (x_get_window_property, receive_incremental_selection)
3365 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3366 Don't store size until memory allocation succeeds.
3367 (x_get_window_property): Plug memory leak on memory exhaustion.
3368 Don't double-block input; malloc is safe here. Don't assume 2**34
3369 - 4 fits in unsigned long. Add an xassert to check
3370 XGetWindowProperty overflow. Be more careful about overflow
3371 calculations, and distinguish size from memory overflow better.
3372 (receive_incremental_selection): When tracing, don't assume
3373 unsigned int is less than INT_MAX.
3374 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3375 harmful) conversions of unsigned short to int.
3376 (lisp_data_to_selection_data): Don't assume that integers
3377 in the range -65535 through -1 fit in an X unsigned short.
3378 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3379 result parameters unless successful. Rely on cons_to_unsigned
3380 to report problems with elements; the old code wasn't right anyway.
3381 (x_check_property_data): Check for int overflow; we cannot use
3382 a wider type due to X limits.
3383 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3384
726e0ab1 3385 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3386
0065d054
PE
3387 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3388 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3389 (x_color_cells): Don't store size until memory allocation succeeds.
3390 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3391 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3392 (x_term_init): Don't assume length fits in int (sprintf is limited
3393 to int size).
bc18e09d 3394
ebfa62c0
PE
3395 Use ptrdiff_t for composition IDs.
3396 * character.c (lisp_string_width):
3397 * composite.c (composition_table_size, n_compositions)
3398 (get_composition_id, composition_gstring_from_id):
3399 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3400 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3401 * window.c (Frecenter):
3402 Use ptrdiff_t, not int, for composition IDs.
3403 * composite.c (get_composition_id): Check for integer overflow.
3404 * composite.h: Adjust prototypes to match the above changes.
3405
d3411f89
PE
3406 Use ptrdiff_t for hash table indexes.
3407 * category.c (hash_get_category_set):
3408 * ccl.c (ccl_driver):
3409 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3410 * coding.c (coding_system_charset_list, detect_coding_system):
3411 * coding.h (struct coding_system.id):
3412 * composite.c (get_composition_id, gstring_lookup_cache):
3413 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3414 * image.c (xpm_get_color_table_h):
3415 * lisp.h (hash_lookup, hash_put):
3416 * minibuf.c (Ftest_completion):
3417 Use ptrdiff_t for hash table indexes, not int (which is too
3418 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3419 32-bit --with-wide-int hosts).
3420
e097a6fa
PE
3421 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3422 Add a FIXME comment about memory leaks.
3423 (syms_of_charset): Don't assume xmalloc returns.
3424
5637687f
PE
3425 Don't assume that stated character widths fit in int.
3426 * character.c (Fchar_width, c_string_width, lisp_string_width):
3427 * character.h (CHAR_WIDTH):
3428 * indent.c (MULTIBYTE_BYTES_WIDTH):
3429 Use sanitize_char_width to avoid undefined and/or bad behavior
3430 with outlandish widths.
a66cfb1c 3431 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3432 now that we have two such functions. All uses changed.
3433 (sanitize_char_width): New inline function.
3434
a2271ba2
PE
3435 Don't assume that tab-width fits in int.
3436 * character.h (sanitize_width): New inline function.
3437 (SANE_TAB_WIDTH): New macro.
3438 (ASCII_CHAR_WIDTH): Use it.
3439 * indent.c (sane_tab_width): Remove. All uses replaced by
3440 SANE_TAB_WIDTH (current_buffer).
3441 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3442
18c52557
PE
3443 * fileio.c: Integer overflow issues with file modes.
3444 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3445
caeeedc1
PE
3446 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3447 Remove unreachable code.
3448 (read_hex, load_charset_map_from_file): Check for integer overflow.
3449
6df6ae42 3450 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3451 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3452 (x_send_scroll_bar_event): Likewise. Check that the size does not
3453 exceed limits imposed by XClientMessageEvent, as well as the usual
3454 ptrdiff_t and size_t limits.
3455
b13995db
PE
3456 * keyboard.c: Overflow, signedness and related fixes.
3457 (make_lispy_movement): Use same integer type in forward decl
3458 that is used in the definition.
3459 (read_key_sequence, keyremap_step):
3460 Change bufsize argument back to int, undoing my 2011-03-30 change.
3461 We prefer signed types, and int is wide enough here.
3462 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3463 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3464 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3465 length, not size_t. Use ptrdiff_t for index, not int.
3466 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3467 possibility of integer overflow.
3468
13464394
PE
3469 Overflow, signedness and related fixes for images.
3470
3471 * dispextern.h (struct it.stack[0].u.image.image_id)
3472 (struct_it.image_id, struct image.id, struct image_cache.size)
3473 (struct image_cache.used, struct image_cache.ref_count):
3474 * gtkutil.c (update_frame_tool_bar):
3475 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3476 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3477 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3478 * nsmenu.m (update_frame_tool_bar):
3479 * xdisp.c (calc_pixel_width_or_height):
3480 * xfns.c (image_cache_refcount):
3481 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3482 on typical 64-bit hosts.
3483
3484 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3485 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3486 Omit unnecessary casts to int.
3487 (parse_image_spec): Check that integers fall into 'int' range
3488 when the callers expect that.
3489 (image_ascent): Redo ascent calculation to avoid int overflow.
3490 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3491 (lookup_image): Remove unnecessary tests.
3492 (xbm_image_p): Locals are now of int, not EMACS_INT,
3493 since parse_image_check makes sure they fit into int.
3494 (png_load, gif_load, svg_load_image):
3495 Prefer int to unsigned where either will do.
3496 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3497 old tiff_error_handler and tiff_warning_handler.
3498 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3499 stack buffer overflows. It uses only the features of vsnprintf
3500 that are common to both POSIX and native Microsoft.
3501 (tiff_error_handler, tiff_warning_handler): Use it.
3502 (tiff_load, gif_load, imagemagick_load_image):
3503 Don't assume :index value fits in 'int'.
3504 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3505 (imagemagick_load_image): Check that crop parameters fit into
3506 the integer types that MagickCropImage accepts. Don't assume
3507 Vimagemagick_render_type has a nonnegative value. Don't assume
3508 size_t fits in 'long'.
3509 (gs_load): Use printmax_t to print the widest integers possible.
3510 Check for integer overflow when computing image height and width.
3511
c11821d4
EZ
35122011-08-26 Eli Zaretskii <eliz@gnu.org>
3513
3514 * xdisp.c (redisplay_window): Don't force window start if point
3515 will be invisible in the resulting window. (Bug#9324)
3516
0c95fcf7
EZ
35172011-08-25 Eli Zaretskii <eliz@gnu.org>
3518
3519 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3520 the display spec is of the form `(space ...)'.
3521 (handle_display_spec): Return the value returned by
3522 handle_single_display_spec, not just 1 or zero.
3523 (handle_single_display_spec): If the display spec is of the form
3524 `(space ...)', and specifies display in the text area, return 2
3525 rather than 1.
fee65a97 3526 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3527 accurately, and prefer exact match for point under bidi.
3528 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3529
3530 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3531 into disp_prop; all users changed.
3532
3533 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3534 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3535 for the text covered by the display property.
3536
e4ed06f1
CY
35372011-08-25 Chong Yidong <cyd@stupidchicken.com>
3538
3539 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3540 Change return value to nil.
3541 (Frecord_buffer): Delete unused function.
3542
f67cdd7f
EZ
35432011-08-24 Eli Zaretskii <eliz@gnu.org>
3544
5980d4c6
EZ
3545 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3546 buffers, return left-to-right.
8610fe8b
EZ
3547 (set_cursor_from_row): Consider candidate row a win if its glyph
3548 represents a newline and point is on that newline. Fixes cursor
3549 positioning on the newline at EOL of R2L text within L2R
3550 paragraph, and vice versa.
3551 (try_cursor_movement): Check continued rows, in addition to
3552 continuation rows. Fixes unwarranted scroll when point enters a
3553 continued line of R2L text within an L2R paragraph, or vice versa.
3554 (cursor_row_p): Consider the case of point being equal to
3555 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3556 from the end of a short line to the beginning of a continued line
3557 of R2L text within L2R paragraph.
3558 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3559 composed characters.
5980d4c6 3560
f67cdd7f
EZ
3561 * bidi.c (bidi_check_type): Use xassert.
3562 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3563 members.
3564
bca633fb
EZ
35652011-08-23 Eli Zaretskii <eliz@gnu.org>
3566
3567 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3568 a character.
3569
4a5885a7
CY
35702011-08-23 Chong Yidong <cyd@stupidchicken.com>
3571
3572 * nsfont.m (ns_otf_to_script): Fix typo.
3573
0902a04e
KH
35742011-08-22 Kenichi Handa <handa@m17n.org>
3575
3576 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3577 extra slot even if the purpose is char-code-property-table.
3578
1a2e6670
EZ
35792011-08-23 Eli Zaretskii <eliz@gnu.org>
3580
8ddde651
EZ
3581 * xdisp.c (redisplay_window): When computing centering_position,
3582 account for the height of the header line. (Bug#8874)
3583
425cc014
EZ
3584 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3585 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3586 candidate is selected by the mouse, and that candidate has a
3587 composed character under the mouse.
3588
1a2e6670
EZ
3589 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3590 coordinates reported by pos-visible-in-window-p for a composed
3591 character in column zero.
3592
8b76d6f8
SM
35932011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3594
3595 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3596
dac347dd
EZ
35972011-08-22 Eli Zaretskii <eliz@gnu.org>
3598
3599 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3600 consider it a hit if to_charpos is anywhere in the range of the
3601 composed buffer positions.
3602
e013fb34
CY
36032011-08-22 Chong Yidong <cyd@stupidchicken.com>
3604
3605 * image.c (gif_load): Don't assume that each subimage has the same
3606 dimensions as the base image. Handle disposal method that is
3607 "undefined" by the gif spec (Bug#9335).
3608
bd1ba3e8
CY
36092011-08-20 Chong Yidong <cyd@stupidchicken.com>
3610
3611 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3612 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3613
54a1215b
EZ
36142011-08-19 Eli Zaretskii <eliz@gnu.org>
3615
823564e5
EZ
3616 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3617 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3618 from an Org mode buffer to a Speedbar frame.
3619
54a1215b
EZ
3620 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3621 a composition, take its buffer position from IT->cmp_it.charpos.
3622 Fixes cursor positioning at the beginning of a line that begins
3623 with a composed character.
3624
9778ebcc
EZ
36252011-08-18 Eli Zaretskii <eliz@gnu.org>
3626
0be6ee06
EZ
3627 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3628 character bidirectional type, use STRONG_L instead. Fixes crashes
3629 in a buffer produced by `describe-categories'.
3630
9778ebcc
EZ
3631 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3632 members before the level stack, so they would be saved and
3633 restored when copying iterator state. Fixes incorrect reordering
3634 around TABs covered by display properties.
3635
156bffbe
AS
36362011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3637
6b02f655 3638 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3639
72ad093b
CY
36402011-08-17 Chong Yidong <cyd@stupidchicken.com>
3641
3642 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3643 (internal_condition_case_2, internal_condition_case_n):
3644 Remove unnecessary aborts (Bug#9081).
72ad093b 3645
35774242
EZ
36462011-08-17 Eli Zaretskii <eliz@gnu.org>
3647
3648 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3649 has no `load' handler, try opening the file locally. (Bug#9311)
3650
db76dd85
KB
36512011-08-16 Ken Brown <kbrown@cornell.edu>
3652
3653 * gmalloc.c: Expand comment.
3654
b215eee5
EZ
36552011-08-16 Eli Zaretskii <eliz@gnu.org>
3656
3657 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3658 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3659
a4579d33
KB
36602011-08-16 Ken Brown <kbrown@cornell.edu>
3661
3662 Fix memory allocation problems in Cygwin build (Bug#9273).
3663
3664 * unexcw.c ( __malloc_initialized): Declare external variable.
3665 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3666
8b76d6f8
SM
3667 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3668 New variables.
a4579d33
KB
3669 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3670 dumped emacs.
3671 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3672 in the static heap.
3673 [CYGWIN] (special_realloc): New function.
3674 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3675 requests to realloc storage in the static heap.
3676
3ebec551
PE
36772011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3678
3679 * bidi.c (bidi_initialize): Remove unused local.
3680
9fd8be00
EZ
36812011-08-15 Eli Zaretskii <eliz@gnu.org>
3682
6b02f655
SM
3683 * bidimirror.h:
3684 * biditype.h: Remove file.
3685 * makefile.w32-in ($(BLD)/bidi.$(O)):
3686 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3687
3688 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3689
3690 * chartab.c: Improve commentary for the uniprop_table API.
3691
32413314
EZ
3692 * bidi.c (bidi_paragraph_init): Support zero value of
3693 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3694 (bidi_initialize): Use uniprop_table instead of including
3695 biditype.h and bidimirror.h.
32413314 3696
9fd8be00
EZ
3697 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3698 coordinates of the iterator when restoring from ppos_it.
3699 (Bug#9296)
3700
5cf2b69b
KH
37012011-08-14 Kenichi Handa <handa@m17n.org>
3702
3703 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3704 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3705
daf17d00
EZ
37062011-08-14 Eli Zaretskii <eliz@gnu.org>
3707
3708 * xdisp.c (move_it_in_display_line_to): Don't invoke
3709 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3710 ppos_it. Fixes vertical cursor motion when line beginning is
3711 covered by an image. (Bug#9296)
3712
08e3161a
JD
37132011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3714
3715 * nsterm.h (ns_run_ascript): Declare.
3716 (NSAPP_DATA2_RUNASSCRIPT): Define.
3717
3718 * nsfns.m (as_script, as_result, as_status): New static variables.
3719 (ns_run_ascript): New function.
5e617bc2 3720 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3721 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3722 the event loop. Get status from as_status (Bug#7276).
3723
3724 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3725 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3726 the event loop (Bug#7276).
3727
a3720aa2
AS
37282011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3729
3730 * gnutls.c (QCgnutls_bootprop_priority)
3731 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3732 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3733 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3734 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3735 (QCgnutls_bootprop_verify_hostname_error)
3736 (QCgnutls_bootprop_callbacks_verify): Rename from
3737 Qgnutls_bootprop_..., all uses changed.
3738
3739 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3740 uses changed.
3741
0a0d27fb
PE
37422011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3743
19d5c50c
PE
3744 * xfaces.c (Qframe_set_background_mode): Now static.
3745 * dispextern.h (Qframe_set_background_mode): Remove decl.
3746
0a0d27fb
PE
3747 * process.c (Fnetwork_interface_info): Declare local only if needed.
3748
377538cb
JD
37492011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3750
3751 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3752 (Fnetwork_interface_list): Allocate in increments of bytes instead
3753 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3754 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3755 sockaddr.
3756 (struct ifflag_def): notrailers is smart on OSX.
3757 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3758 Get hardware address with getifaddrs if available.
3759
08fff70c
EZ
37602011-08-12 Eli Zaretskii <eliz@gnu.org>
3761
3762 * xdisp.c (iterate_out_of_display_property): xassert that
3763 IT->position is set to within IT->object's boundaries. Break from
3764 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3765 when IT->position is set up wrongly due to some bug.
3766 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3767 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3768 entry. Force push_it to save on the stack the current
3769 buffer/string position, to be restored by pop_it. Fix flags in
3770 the iterator structure wrt the object coming from a display
3771 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3772 properties. (Bug#9284)
3773
7be1c708 37742011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3775
7be1c708
CY
3776 * fontset.c (fontset_get_font_group): Add proper type checks.
3777 (Bug#9172)
aac0c6e3 3778
7be1c708 37792011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3780
7be1c708
CY
3781 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3782 and LC_VERSION_MIN_MACOSX.
3783 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3784 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3785
97bb72a6
EZ
37862011-08-08 Eli Zaretskii <eliz@gnu.org>
3787
3788 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3789 no-display-properties-and-no-overlays under bidi display.
3790 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3791 properties and overlays.
97bb72a6 3792
d5617611
CY
37932011-08-08 Chong Yidong <cyd@stupidchicken.com>
3794
37e11a63
CY
3795 * editfns.c (Fset_time_zone_rule): Document relationship with the
3796 setenv function.
3797
d5617611
CY
3798 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3799 the font entity extracted from the cache (Bug#8109).
3800
58872834
CY
38012011-08-07 Chong Yidong <cyd@stupidchicken.com>
3802
3803 * composite.c (autocmp_chars): Don't reset point. That is done by
3804 restore_point_unwind (Bug#5984).
3805
75bfc667
JL
38062011-08-07 Juri Linkov <juri@jurta.org>
3807
3808 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3809 to show the arg `TIME' instead of `TIMEVAL'.
3810
d1410150
EZ
38112011-08-06 Eli Zaretskii <eliz@gnu.org>
3812
3813 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3814 display property strides EOL and includes a newline, as in
3815 longlines-mode. (Bug#9254)
75b771e4
EZ
3816 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3817 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3818
3819 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3820 is non-zero, even if the data buffer is NULL. Fixes a crash in
3821 vertical-motion with longlines-mode. (Bug#9254)
3822
35928349
EZ
38232011-08-05 Eli Zaretskii <eliz@gnu.org>
3824
ec7cc85b
EZ
3825 * bidi.c <bidi_cache_total_alloc>: Now static.
3826 (bidi_initialize): Initialize bidi_cache_total_alloc.
3827
8b76d6f8 3828 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3829 cache. (Bug#9221)
3830
3831 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3832 amount allocated this far in `bidi_cache_total_alloc'.
3833 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3834 non-zero, only free the data buffer without restoring the cache
3835 contents. All callers changed.
3836
3837 * dispextern.h (bidi_unshelve_cache): Update prototype.
3838
3839 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3840 (move_it_in_display_line, move_it_to)
3841 (move_it_vertically_backward, move_it_by_lines): Replace the call
3842 to xfree to an equivalent call to bidi_unshelve_cache.
3843 (move_it_in_display_line_to): Fix logic of returning
412b6358 3844 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3845
e2e2423b
EZ
38462011-08-05 Eli Zaretskii <eliz@gnu.org>
3847
3848 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3849 came from a string character with a `cursor' property. (Bug#9229)
3850
ae9e757a
JD
38512011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3852
3853 * Makefile.in (LIB_PTHREAD): New variable.
3854 (LIBES): Add LIB_PTHREAD (Bug#9216).
3855
3856 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3857 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3858
213bd7f2
AS
38592011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3860
6b02f655 3861 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3862
99aaf75f
JD
38632011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3864
3865 * xterm.c (x_find_topmost_parent): New function.
3866 (x_set_frame_alpha): Find topmost parent window with
3867 x_find_topmost_parent and set the property there also (bug#9181).
3868 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3869
c74e9d86
PE
38702011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3871
3872 * callproc.c (Fcall_process): Avoid vfork clobbering
3873 the local vars buffer, coding_systems, current_dir.
3874
640c8776
SM
38752011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3876
3877 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3878
f26d0e4c
PE
38792011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3880
8a10d76c
PE
3881 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3882 so that it is not optimized away.
3883
f26d0e4c
PE
3884 * xdisp.c (compute_display_string_pos): Remove unused local.
3885
55439c61
EZ
38862011-08-02 Eli Zaretskii <eliz@gnu.org>
3887
3888 Fix slow cursor motion and scrolling in large buffers with
3889 selective display, like Org Mode buffers. (Bug#9218)
3890
3891 * dispextern.h (struct bidi_it): New member disp_prop_p.
3892
3893 * xdisp.c: Remove one-slot cache of display string positions.
3894 (compute_display_string_pos): Accept an additional argument
5e617bc2 3895 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3896 for a display string or property. If found, set DISP_PROP_P
3897 non-zero.
3898
3899 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3900 DISP_PROP_P, and pass it to compute_display_string_pos.
3901 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3902 non-zero. All callers of bidi_fetch_char changed.
3903
fb33fa43
SM
39042011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3905
3906 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3907
b099e063
DM
39082010-12-03 Don March <don@ohspite.net>
3909
3910 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3911 last character M-[char] is translated to ESC [char] (bug#7541).
3912
5cc7f7af
KH
39132011-08-02 Kenichi Handa <handa@m17n.org>
3914
d0fffa3f 3915 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3916
3917 * chartab.c (uniprop_table): Make it non-static.
3918
525d5e6e
EZ
39192011-08-01 Eli Zaretskii <eliz@gnu.org>
3920
3921 * xdisp.c (forward_to_next_line_start): Accept additional argument
3922 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3923 on the newline.
3924 (reseat_at_next_visible_line_start): Use the bidi iterator state
3925 returned by forward_to_next_line_start to restore the state of
3926 it->bidi_it after backing up to previous newline. (Bug#9212)
3927
31011111
AS
39282011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3929
3930 * regex.c (re_comp): Protoize.
3931 (re_exec): Fix return type.
3932 (regexec): Fix type of `ret'. (Bug#9203)
3933
476371c4
PE
39342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3935
e5d76069
PE
3936 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3937 This is needed if max-image-size is a floating-point number.
3938
9a79b20c
AS
39392011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3940
3941 * print.c (print_object): Print empty symbol as ##.
3942
3943 * lread.c (read1): Read ## as empty symbol.
3944
d8c2fa78
AA
39452011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3946
3947 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3948 setting frame foreground color (Bug#9175).
3949 (x_set_background_color): Likewise.
3950
ffe57a7a
AA
3951 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3952 contents (Bug#9176).
3953 (EmacsTooltip -init): Remove bezels and add shadows to
3954 tooltip windows.
3955
bf3492a5
AA
3956 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3957 or scroll bar (Bug#8470).
3958
d55e9c53
AA
3959 * nsfont.m (nsfont_open): Remove assignment to voffset and
3960 unnecessary vars hshink, expand, hd, full_height, min_height.
3961 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3962
3963 * nsterm.h (nsfont_info): Remove voffset field.
3964
d8c2fa78 39652011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3966
3967 Implement strike-through and overline on NextStep (Bug#8863).
3968
3969 * nsfont.m (nsfont_open): Use underline position provided by font,
3970 instead of hard-coded value of 2.
3971 (nsfont_draw): Call ns_draw_text_decoration instead.
3972
3973 * nsterm.h: Add declaration for ns_draw_text_decoration.
3974
3975 * nsterm.m (ns_draw_text_decoration): New function for drawing
3976 underline, overline, and strike-through.
3977 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3978 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3979 accommodate underlining, etc.
4843aac3 3980
4cc60b9b
EZ
39812011-07-28 Eli Zaretskii <eliz@gnu.org>
3982
bc7ece87
EZ
3983 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3984 default.
4cc60b9b 3985
476371c4
PE
39862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3987
66606eea
PE
3988 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3989 Without this fix, if a signal arrives just after memory fills up,
3990 'malloc' might be invoked reentrantly.
3991
476371c4
PE
3992 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3993 In other words, assume that every image size is allowed, on non-X
3994 hosts. This assumption is probably wrong, but it lets Emacs compile.
3995
f3fcc40d
AS
39962011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3997
3998 * regex.c (re_iswctype): Convert return values to boolean.
3999
350c992f
EZ
40002011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4001
4002 * xdisp.c (compute_display_string_pos): Don't use cached display
4003 string position if the buffer had its restriction changed.
4004 (Bug#9184)
4005
5266b4bb
PE
40062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4007
4008 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4009
2573a837 40102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 4011
41f55ccd 4012 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 4013
39e378da
PE
4014 * bidi.c: Integer size and overflow fixes.
4015 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4016 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4017 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4018 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4019 (bidi_find_other_level_edge):
4020 Use ptrdiff_t instead of EMACS_INT where either will do.
4021 This works better on 32-bit hosts configured --with-wide-int.
4022 (bidi_cache_ensure_space): Check for size-calculation overflow.
4023 Use % rather than repeated addition, for better worst-case speed.
4024 Don't set bidi_cache_size until after xrealloc returns, because it
4025 might not return.
4026 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
4027 (bidi_cache_ensure_space): Also check that the bidi cache size
4028 does not exceed that of the largest Lisp string or buffer. See Eli
4029 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 4030
5e927815
PE
4031 * alloc.c (__malloc_size_t): Remove.
4032 All uses replaced by size_t. See Andreas Schwab's note
4033 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4034
ca4aa935
PE
4035 * image.c: Improve checking for integer overflow.
4036 (check_image_size): Assume that f is nonnull, since
4037 it is always nonnull in practice. This is one less thing to
4038 worry about when checking for integer overflow later.
4039 (x_check_image_size): New function, which checks for integer
4040 overflow issues inside X.
4041 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4042 This removes the need for a memory_full check.
4043 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4044 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4045 (xbm_read_bitmap_data): Change locals back to 'int', since
4046 their values must fit in 'int'.
4047 (xpm_load_image, png_load, tiff_load):
4048 Invoke x_create_x_image_and_pixmap earlier,
4049 to avoid much needless work if the image is too large.
4050 (tiff_load): Treat overly large images as if
4051 x_create_x_image_and_pixmap failed, not as malloc failures.
4052 (gs_load): Use x_check_image_size.
4053
5f8f9cc2
PE
4054 * gtkutil.c: Omit integer casts.
4055 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4056 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4057
5adf60bc
PE
4058 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4059
c8907a93
PE
4060 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4061 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4062 would wrongly return t on a 64-bit host.
4063
e3c25c68
PE
4064 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4065 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4066 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4067 and therefore cause GCC to emit a bogus diagnostic in some cases.
4068
3f791afe
PE
4069 * image.c: Integer signedness and overflow and related fixes.
4070 This is not an exhaustive set of fixes, but it's time to
4071 record what I've got.
4072 (lookup_pixel_color, check_image_size): Remove redundant decls.
4073 (check_image_size): Don't assume that arbitrary EMACS_INT values
4074 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4075 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4076 (tiff_load, imagemagick_load_image):
4077 Check for overflow in size calculations.
4078 (x_create_x_image_and_pixmap): Remove unnecessary test for
4079 xmalloc returning NULL; that can't happen.
4080 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4081 (xpm_color_bucket): Use better integer hashing function.
4082 (xpm_cache_color): Don't possibly over-allocate memory.
4083 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4084 (gif_memory_source):
4085 Use ptrdiff_t, not int or size_t, to record sizes.
4086 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4087 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4088 either works, as we prefer signed integers.
4089 (tiff_read_from_memory, tiff_write_from_memory):
4090 Return tsize_t, not size_t, since that's what the TIFF API wants.
4091 (tiff_read_from_memory): Don't fail simply because the read would
4092 go past EOF; instead, return a short read.
4093 (tiff_load): Omit no-longer-needed casts.
4094 (Fimagemagick_types): Don't assume size fits into 'int'.
4095
3cc5a532
PE
4096 Improve hashing quality when configured --with-wide-int.
4097 * fns.c (hash_string): New function, taken from sxhash_string.
4098 Do not discard information about ASCII character case; this
4099 discarding is no longer needed.
4100 (sxhash-string): Use it. Change sig to match it. Caller changed.
4101 * lisp.h: Declare it.
4102 * lread.c (hash_string): Remove, since we now use fns.c's version.
4103 The fns.c version returns a wider integer if --with-wide-int is
4104 specified, so this should help the quality of the hashing a bit.
4105
b312a492
PE
4106 * emacs.c: Integer overflow minor fix.
4107 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4108 Define only if GNU_LINUX.
4109 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4110
dfd153ae
PE
4111 * dispnew.c: Integer signedness and overflow fixes.
4112 Remove unnecessary forward decls, that were a maintenance hassle.
4113 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4114 All uses changed.
4115 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4116 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4117 (prepare_desired_row, line_draw_cost):
4118 Use int, not unsigned, where either works.
4119 (save_current_matrix, restore_current_matrix):
4120 Use ptrdiff_t, not size_t, where either works.
4121 (init_display): Check for overflow more accurately, and without
4122 relying on undefined behavior.
4123
a81d11a3
PE
4124 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4125 Remove, replacing with the new symbols in lisp.h. All uses changed.
4126 * fileio.c (make_temp_name):
4127 * filelock.c (lock_file_1, lock_file):
4128 * xdisp.c (message_dolog):
4129 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4130 Use pMd etc. instead.
4131 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4132 replacing the pWIDE etc. symbols removed from editfns.c.
4133
3300e6fd
PE
4134 * keyboard.h (num_input_events): Now uintmax_t.
4135 This is (very slightly) less likely to mess up due to wraparound.
4136 All uses changed.
4137
fd05c7e9
PE
4138 * buffer.c: Integer signedness fixes.
4139 (alloc_buffer_text, enlarge_buffer_text):
4140 Use ptrdiff_t rather than size_t when either will do, as we prefer
4141 signed integers.
4142
903fe15d
PE
4143 * alloc.c: Integer signedness and overflow fixes.
4144 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4145 (__malloc_size_t): Default to size_t, not to int.
4146 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4147 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4148 Prefer ptrdiff_t to size_t when either would do, as we prefer
4149 signed integers.
4150 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4151 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4152 Now const. Initialize with values that are in range even if char
4153 is signed.
4154 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4155 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4156 These functions do the right thing with sizes > 2**32.
4157 (check_depth): Now ptrdiff_t, not int.
4158 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4159 Adjust to new way of storing sizes. Check for size overflow bugs
4160 in rest of code.
4161 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4162 slightly wrong anyway, as it missed one instance of
4163 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4164 (refill_memory_reserve): Omit needless cast to size_t.
4165 (mark_object_loop_halt): Mark as externally visible.
4166
ac82cc6a
PE
4167 * xselect.c: Integer signedness and overflow fixes.
4168 (Fx_register_dnd_atom, x_handle_dnd_message):
4169 Use ptrdiff_t, not size_t, since we prefer signed.
4170 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4171 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4172 x_dnd_atoms_size and x_dnd_atoms_length.
4173
c2d1e36d
PE
4174 * doprnt.c: Prefer signed to unsigned when either works.
4175 * eval.c (verror):
4176 * doprnt.c (doprnt):
4177 * lisp.h (doprnt):
4178 * xdisp.c (vmessage):
4179 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4180 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4181 prefer signed arithmetic to avoid comparison confusion.
4182 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4183 but is a bit tricky.
4184
0e926e56
PE
4185 Assume freestanding C89 headers, string.h, stdlib.h.
4186 * data.c, doprnt.c, floatfns.c, print.c:
4187 Include float.h unconditionally.
4188 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4189 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4190 * regex.c: Likewise for stddef.h, string.h.
4191 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4192 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4193 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4194 (STDC_HEADERS): Remove obsolete defines.
4195 * sysdep.c: Include limits.h unconditionally.
4196
9cfdb3ec
PE
4197 Assume support for memcmp, memcpy, memmove, memset.
4198 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4199 * regex.c (memcmp, memcpy):
4200 Remove; we assume C89 now.
4201
4202 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4203 (__malloc_safe_bcopy): Remove; no longer needed.
4204
cf950e6b 4205 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4206 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4207 well either way, and we prefer signed to unsigned.
4208
dbf38e02
LMI
42092011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4210
4211 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4212 closes the connection while we're reading (bug#9182).
4213
d6f0886c 42142011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4215
d6f0886c
JD
4216 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4217 are specified (Bug#9168).
24e0f6b1 4218
2eb1f9e6
PE
42192011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4220
4221 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4222 Found by GCC static checking and --with-wide-int on a 32-bit host.
4223
22381272 42242011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4225
4226 * xdisp.c (compute_display_string_pos): Fix logic of caching
4227 previous display string position. Initialize cached_prev_pos to
4228 -1. Fixes slow-down at the beginning of a buffer.
4229
f25e39b4
EZ
42302011-07-24 Eli Zaretskii <eliz@gnu.org>
4231
4232 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4233 for attrs[LFACE_FONTSET_INDEX].
4234
04c4b52e
PE
42352011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4236
4237 * xml.c (parse_region): Remove unused local
4238 that was recently introduced.
4239
c1734fbd
EZ
42402011-07-23 Eli Zaretskii <eliz@gnu.org>
4241
be18c5a5
EZ
4242 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4243 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4244
c1734fbd
EZ
4245 * xdisp.c (move_it_in_display_line_to): Record the best matching
4246 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4247 exit if none of the characters scanned was an exact match.
4248 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4249 when exact match is impossible due to invisible text, and the
4250 lines are truncated.
4251
a258d627
JD
42522011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4253
4254 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4255 for OSX >= 10.7.
4256
b6d5a689
EZ
42572011-07-22 Eli Zaretskii <eliz@gnu.org>
4258
0f74f785
EZ
4259 Fix a significant slow-down of cursor motion with C-n, C-p,
4260 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4261 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4262 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4263 (next_element_from_buffer): Call compute_stop_pos_backwards to
4264 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4265 base_level_stop.
4266 (reseat): Don't look for prev_stop, as that could mean a very long
4267 run.
4268 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4269 <cached_disp_overlay_modiff>: Cache for last found display string
4270 position.
551918c1 4271 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4272 about the same buffer in the same area of character positions, and
4273 the buffer wasn't changed since the time the display string
4274 position was cached.
551918c1 4275
b2d0c91a
EZ
42762011-07-22 Eli Zaretskii <eliz@gnu.org>
4277
4278 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4279 is an integer, which is important for empty lines. (Bug#9149)
4280
043604ee
CY
42812011-07-22 Chong Yidong <cyd@stupidchicken.com>
4282
4283 * frame.c (Fmodify_frame_parameters): In tty case, update the
4284 default face if necessary (Bug#4238).
4285
da4adb04
CY
42862011-07-21 Chong Yidong <cyd@stupidchicken.com>
4287
4288 * editfns.c (Fstring_to_char): No need to explain what a character
4289 is in the docstring (Bug#6576).
4290
9abd0532
LMI
42912011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4292
4293 * xml.c (parse_region): Make sure we always return a tree.
4294
36881d16
HK
42952011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4296
4297 * xml.c (parse_region): If a document contains only comments,
4298 return that, too.
4299
1e98674d
LMI
43002011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4301
4302 * xml.c (make_dom): Return comments, too.
4303
590bd467
PE
43042011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4305
4306 Port to OpenBSD.
4307 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4308 and the surrounding thread.
4309 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4310 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4311 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4312 timer goes off.
4313 * s/openbsd.h (BROKEN_SIGIO): Define.
4314 * unexelf.c (unexec) [__OpenBSD__]:
4315 Don't update the .mdebug section of the Alpha COFF symbol table.
4316
f41628b2
LMI
43172011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4318
4319 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4320 (bug#8460).
4321
b59b67c5
PE
43222011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4323
15e3a074
PE
4324 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4325 This fixes some race conditions on the permissions of any newly
4326 created file.
4327
41bed37d
PE
4328 * alloc.c (valid_pointer_p): Use pipe, not open.
4329 This fixes some permissions issues when debugging.
4330
b59b67c5
PE
4331 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4332 If fchown fails to set both uid and gid, try to set just gid,
4333 as that is sometimes allowed. Adjust the file's mode to eliminate
4334 setuid or setgid bits that are inappropriate if fchown fails.
4335
925a6be7
SM
43362011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4337
4338 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4339 to compare Lisp_Objects.
4340 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4341 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4342 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4343
52968808
AS
43442011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4345
0a6a104b
AS
4346 * lread.c (read_integer): Unread even EOF character.
4347 (read1): Likewise. Properly record start position of symbol.
4348
52968808
AS
4349 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4350 symbol character follows.
4351
9e381cdd
PE
43522011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4353
4354 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4355 This works around a problem with the previous change to Fcopy_file.
4356 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4357 and without this change, GCC might complain about discarding
4358 fchown's return value.
4359
b5641435
JB
43602011-07-16 Juanma Barranquero <lekktu@gmail.com>
4361
4362 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4363
a8031457
PE
43642011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4365
4366 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4367
dd889327
LMI
43682011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4369
750c33f7
LMI
4370 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4371 it's used from the C level.
4372
dd889327
LMI
4373 * process.c: Use the same condition for POLL_FOR_INPUT in both
4374 keyboard.c and process.c (bug#1858).
4375
87e86684
LM
43762011-07-09 Lawrence Mitchell <wence@gmx.li>
4377
4378 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4379 (Fgnutls_boot): Use it.
4380
64348f40
AS
43812011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4382
4383 * doc.c (Fsubstitute_command_keys): Revert last change.
4384
1d698799
LMI
43852011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4386
f863868c
LMI
4387 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4388 quotes the next character, and doesn't affect other longer
4389 sequences (bug#8935).
4390
1d698799
LMI
4391 * lread.c (syms_of_lread): Clarify that is isn't only
4392 `eval-buffer' and `eval-defun' that's affected by
4393 `lexical-binding' (bug#8460).
4394
aa4b6df6
EZ
43952011-07-15 Eli Zaretskii <eliz@gnu.org>
4396
4397 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4398 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4399
5d856da6
PE
44002011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4401
ad6042bb
PE
4402 Fix minor problems found by static checking.
4403 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4404 (elsz): Now a signed constant, not a size_t var. We prefer signed
4405 types to unsigned, to avoid integer comparison confusion. Without
4406 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4407 "cannot optimize loop, the loop counter may overflow", a symptom
4408 of the confusion.
f00bbb22 4409 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4410 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4411
6468f31c
LMI
44122011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4413
49080b10
LMI
4414 * search.c (Fre_search_backward): Mention `case-fold-search' in
4415 all the re_search_* functions (bug#8138).
4416
6468f31c
LMI
4417 * keyboard.c (Fopen_dribble_file): Document when the file is
4418 closed (bug#8056).
4419
c965adc5
EZ
44202011-07-14 Eli Zaretskii <eliz@gnu.org>
4421
df9733bf
EZ
4422 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4423 bidi_cache_idx.
4424
0bb23927
EZ
4425 Support bidi reordering of display and overlay strings.
4426 * xdisp.c (compute_display_string_pos)
4427 (compute_display_string_end): Accept additional argument STRING.
4428 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4429 (reseat_to_string): Initialize bidi_it->string.s and
4430 bidi_it->string.schars.
4431 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4432 NULL (avoids a crash in bidi_paragraph_init).
4433 Initialize itb.string.lstring.
0bb23927
EZ
4434 (init_iterator): Call bidi_init_it only of a valid
4435 buffer position was specified. Initialize paragraph_embedding to
4436 L2R.
4437 (reseat_to_string): Initialize the bidi iterator.
4438 (display_string): If we need to ignore text properties of
4439 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4440 original value of -1 will not work with bidi.)
4441 (compute_display_string_pos): First arg is now struct
4442 `text_pos *'; all callers changed. Support display properties on
4443 Lisp strings.
4444 (compute_display_string_end): Support display properties on Lisp
4445 strings.
4446 (init_iterator, reseat_1, reseat_to_string): Initialize the
4447 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4448 when iterating on a string not from display properties).
640c8776
SM
4449 (compute_display_string_pos, compute_display_string_end):
4450 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4451 arrow keys.
4452 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4453 base_level_stop; instead, set base_level_stop to BEGV.
4454 Fixes crashes in vertical-motion.
0bb23927
EZ
4455 (next_element_from_buffer): Improve commentary for when
4456 the iterator is before prev_stop.
4457 (init_iterator): Initialize bidi_p from the default value of
4458 bidi-display-reordering, not from buffer-local value. Use the
4459 buffer-local value only if initializing for buffer iteration.
4460 (handle_invisible_prop): Support invisible properties on strings
4461 that are being bidi-reordered.
4462 (set_iterator_to_next): Support bidi reordering of C strings and
4463 Lisp strings.
4464 (next_element_from_string): Support bidi reordering of Lisp
4465 strings.
4466 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4467 (display_string): Support display of R2L glyph rows.
4468 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4469 (init_iterator): Don't initialize it->bidi_p for strings
4470 here.
4471 (reseat_to_string): Initialize it->bidi_p for strings here.
4472 (next_element_from_string, next_element_from_c_string)
4473 (next_element_from_buffer): Add xassert's for correspondence
4474 between IT's object being iterated and it->bidi_it.string
4475 structure.
4476 (face_before_or_after_it_pos): Support bidi iteration.
4477 (next_element_from_c_string): Handle the case of the first string
4478 character that is not the first one in the visual order.
4479 (get_visually_first_element): New function, refactored from common
4480 parts of next_element_from_buffer, next_element_from_string, and
4481 next_element_from_c_string.
4482 (tool_bar_lines_needed, redisplay_tool_bar)
4483 (display_menu_bar): Force left-to-right direction. Add a FIXME
4484 comment for making that be controlled by a user option.
4485 (push_it, pop_it): Save and restore the state of the
4486 bidi iterator. Save and restore the bidi_p flag.
4487 (pop_it): Iterate out of display property for string iteration as
4488 well.
4489 (iterate_out_of_display_property): Support iteration over strings.
4490 (handle_single_display_spec): Set up it->bidi_it for iteration
4491 over a display string, and call bidi_init_it.
4492 (handle_single_display_spec, next_overlay_string)
4493 (get_overlay_strings_1, push_display_prop): Set up the bidi
4494 iterator for displaying display or overlay strings.
4495 (forward_to_next_line_start): Don't use the shortcut if
4496 bidi-iterating.
4497 (back_to_previous_visible_line_start): If handle_display_prop
4498 pushed the iterator stack, restore the internal state of the bidi
4499 iterator by calling bidi_pop_it same number of times.
4500 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4501 and we are bidi-iterating, don't decrement the iterator position;
4502 instead, set the first_elt flag in the bidi iterator, to produce
4503 the same effect.
4504 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4505 (push_display_prop): xassert that we are iterating a buffer.
4506 (push_it, pop_it): Save and restore paragraph_embedding member.
4507 (handle_single_display_spec, next_overlay_string)
4508 (get_overlay_strings_1, reseat_1, reseat_to_string)
4509 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4510 correctly. Don't assume unibyte strings are not bidi-reordered.
4511 (compute_display_string_pos)
4512 (compute_display_string_end): Fix handling the case of C string.
4513 (push_it, pop_it): Save and restore from_disp_prop_p.
4514 (handle_single_display_spec, push_display_prop): Set the
4515 from_disp_prop_p flag.
4516 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4517 (pop_it): Call iterate_out_of_display_property only if we are
4518 popping after iteration over a string that came from a display
4519 property. Fix a typo in popping stretch info. Add an assertion
4520 for verifying that the iterator position is in sync with the bidi
4521 iterator.
4522 (handle_single_display_spec, get_overlay_strings_1)
4523 (push_display_prop): Fix initialization of paragraph direction for
4524 string when that of the parent object is not yet determined.
4525 (reseat_1): Call bidi_init_it to resync the bidi
4526 iterator with IT's position. (Bug#7616)
4527 (find_row_edges): If ROW->start.pos gives position
4528 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4529 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4530 Reset the from_disp_prop_p flag.
4531 (SAVE_IT, RESTORE_IT): New macros.
4532 (pos_visible_p, face_before_or_after_it_pos)
4533 (back_to_previous_visible_line_start)
4534 (move_it_in_display_line_to, move_it_in_display_line)
4535 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4536 (try_scrolling, redisplay_window, display_line): Use them when
4537 saving a temporary copy of the iterator and restoring it back.
4538 (back_to_previous_visible_line_start, reseat_1)
4539 (init_iterator): Empty the bidi cache "stack".
4540 (move_it_in_display_line_to): If iterator ended up at
4541 EOL, but we never saw any buffer positions smaller than
4542 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4543 motion in bidi-reordered lines.
4544 (move_it_in_display_line_to): Record prev_method and prev_pos
4545 immediately before the call to set_iterator_to_next. Fixes cursor
4546 motion in bidi-reordered lines with stretch glyphs and strings
4547 displayed in margins. (Bug#8133) (Bug#8867)
4548 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4549 TO_CHARPOS.
640c8776
SM
4550 (pos_visible_p): Support positions in bidi-reordered lines.
4551 Save and restore bidi cache.
0bb23927
EZ
4552
4553 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4554 (bidi_paragraph_info): Delete unused struct.
4555 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4556 (bidi_cache_start): New variable.
4557 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4558 to zero.
4559 (bidi_cache_fetch_state, bidi_cache_search)
4560 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4561 (bidi_cache_find, bidi_peek_at_next_level)
4562 (bidi_level_of_next_char, bidi_find_other_level_edge)
4563 (bidi_move_to_visually_next): Compare cache index with
4564 bidi_cache_start rather than with zero.
4565 (bidi_fetch_char): Accept new argument STRING; all callers
4566 changed. Support iteration over a string. Support strings with
4567 display properties. Support unibyte strings. Fix the type of
4568 `len' according to what STRING_CHAR_AND_LENGTH expects.
4569 (bidi_paragraph_init, bidi_resolve_explicit_1)
4570 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4571 (bidi_level_of_next_char, bidi_move_to_visually_next):
4572 Support iteration over a string.
0bb23927
EZ
4573 (bidi_set_sor_type, bidi_resolve_explicit_1)
4574 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4575 can now be zero (for strings); special values 0 and -1 were
4576 changed to -1 and -2, respectively.
4577 (bidi_char_at_pos): New function.
4578 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4579 Call it instead of FETCH_MULTIBYTE_CHAR.
4580 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4581 initialized to valid values.
4582 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4583 values.
4584 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4585 the test for valid cached positions. Fix the logic for looking up
4586 the sentinel state in the cache. GCPRO the Lisp string we are
4587 iterating.
4588 (bidi_push_it, bidi_pop_it): New functions.
4589 (bidi_initialize): Initialize the bidi cache start stack pointer.
4590 (bidi_cache_ensure_space): New function, refactored from part of
4591 bidi_cache_iterator_state. Don't assume the required size is just
4592 one BIDI_CACHE_CHUNK away.
4593 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4594 (bidi_count_bytes, bidi_char_at_pos): New functions.
4595 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4596 always valid if bidi_cache_idx is valid.
4597 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4598 is valid if it's going to be used.
4599 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4600 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4601 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4602 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4603 (bidi_find_other_level_edge, bidi_cache_start_stack):
4604 All variables related to cache indices are now EMACS_INT.
c965adc5 4605
0bb23927
EZ
4606 * dispextern.h (struct bidi_string_data): New structure.
4607 (struct bidi_it): New member `string'. Make flag members be 1-bit
4608 fields, and put them last in the struct.
640c8776
SM
4609 (compute_display_string_pos, compute_display_string_end):
4610 Update prototypes.
0bb23927
EZ
4611 (bidi_push_it, bidi_pop_it): Add prototypes.
4612 (struct iterator_stack_entry): New members bidi_p,
4613 paragraph_embedding, and from_disp_prop_p.
4614 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4615 (bidi_shelve_cache, bidi_unshelve_cache):
4616 Declare prototypes.
0bb23927
EZ
4617
4618 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4619 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4620 and vector-like objects.
4621
4622 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4623 cache around display iteration.
4624
4625 * window.c (Fwindow_end, window_scroll_pixel_based)
4626 (displayed_window_lines, Frecenter): Save and restore the bidi
4627 cache around display iteration.
4628
3bbd2265
LMI
46292011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4630
4631 * editfns.c (Fdelete_region): Clarify the use of the named
4632 parameters (bug#6788).
4633
adc47434
MR
46342011-07-14 Martin Rudalics <rudalics@gmx.at>
4635
4636 * indent.c (Fvertical_motion): Set and restore w->pointm when
4637 saving and restoring the window's buffer (Bug#9006).
4638
837c31f8
LMI
46392011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4640
4641 * editfns.c (Fstring_to_char): Clarify just what is returned
4642 (bug#6576). Text by Eli Zaretskii.
4643
ac389d0c
JB
46442011-07-13 Juanma Barranquero <lekktu@gmail.com>
4645
4646 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4647
0be0ce47
EZ
46482011-07-13 Eli Zaretskii <eliz@gnu.org>
4649
4650 * buffer.c (mmap_find): Fix a typo.
4651
cd18e7e3
JB
46522011-07-13 Johan Bockgård <bojohan@gnu.org>
4653
4654 Fix execution of x selection hooks.
4655 * xselect.c (Qx_lost_selection_functions)
4656 (Qx_sent_selection_functions): New vars.
4657 (syms_of_xselect): DEFSYM them.
4658 (x_handle_selection_request): Pass Qx_sent_selection_functions
4659 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4660 (x_handle_selection_clear,x_clear_frame_selections):
4661 Pass Qx_lost_selection_functions rather than
4662 Vx_lost_selection_functions to Frun_hook_with_args.
4663
47ea7f44
PE
46642011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4665
ac389d0c 4666 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4667 The old code sometimes used this field without initializing it.
4668
47ea7f44
PE
4669 * alloc.c (gc_sweep): Don't read past end of array.
4670 In theory, the old code could also have corrupted Emacs internals,
4671 though it'd be very unlikely.
4672
bc985c87
AS
46732011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4674
4675 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4676 argument. (Bug#4026)
bc985c87 4677
0cf34688
LMI
46782011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4679
b3dadd76
LMI
4680 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4681 key" (bug#4257).
4682
0cf34688
LMI
4683 * window.c (Fset_window_start): Doc fix (bug#4199).
4684 (Fset_window_hscroll): Ditto.
4685
270768cd
PE
46862011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4687
077e3dda 4688 Fix minor new problems caught by GCC 4.6.1.
270768cd 4689 * term.c (init_tty): Remove unused local.
490011a6 4690 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4691 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4692 not used otherwise.
270768cd 4693
b1f58454
CY
46942011-07-12 Chong Yidong <cyd@stupidchicken.com>
4695
4696 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4697
22b9578d
LMI
46982011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4699
6e70ab07
LMI
4700 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4701 are the mini-buffer and the echo area (bug#3320).
4702
22b9578d
LMI
4703 * term.c (init_tty): Remove support for supdup, c10 and perq
4704 terminals, which are no longer supported (bug#1482).
4705
8974cc9f
JB
47062011-07-10 Johan Bockgård <bojohan@gnu.org>
4707
4708 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4709
a560d974
JD
47102011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4711
4712 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4713 for non-popups (Bug#3642).
4714
1dae0f0a
AS
47152011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4716
268c2c36 4717 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4718 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4719 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4720 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4721 * data.c (fmod): Likewise.
4722 * dispnew.c (swap_glyphs_in_rows): Likewise.
4723 * emacs.c (memory_warning_signal): Likewise.
4724 * floatfns.c (float_error): Likewise.
4725 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4726 (otf_open, font_otf_capability, generate_otf_features)
4727 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4728 Likewise.
4729 * image.c (pbm_read_file): Likewise.
4730 * indent.c (string_display_width): Likewise.
4731 * intervals.c (check_for_interval, search_for_interval)
4732 (inc_interval_count, count_intervals, root_interval)
4733 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4734 * lread.c (defalias): Likewise.
268c2c36 4735 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4736 * regex.c (set_image_of_range_1, set_image_of_range)
4737 (regex_grow_registers): Likewise.
4738 * sysdep.c (strerror): Likewise.
4739 * termcap.c (valid_filename_p, tprint, main): Likewise.
4740 * tparam.c (main): Likewise.
4741 * unexhp9k800.c (run_time_remap, save_data_space)
4742 (update_file_ptrs, read_header, write_header, calculate_checksum)
4743 (copy_file, copy_rest, display_header): Likewise.
4744 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4745 Likewise.
4746 * xdisp.c (check_it): Likewise.
4747 * xfaces.c (register_color, unregister_color, unregister_colors):
4748 Likewise.
4749 * xfns.c (print_fontset_result): Likewise.
4750 * xrdb.c (member, fatal, main): Likewise.
4751
99033785
PE
47522011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4753
4754 Fix minor problems found by static checking (Bug#9031).
4755 * chartab.c (char_table_set_range, map_sub_char_table):
4756 Remove unused locals.
4757 (uniprop_table): Now static.
4758 * composite.c (_work_char): Remove unused static var.
4759
9cb2ac56
JB
47602011-07-09 Juanma Barranquero <lekktu@gmail.com>
4761
4762 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4763
f25661f0
JD
47642011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4765
4766 * gtkutil.c (qttip_cb): Remove code without function.
4767
8278c4fe
EZ
47682011-07-09 Eli Zaretskii <eliz@gnu.org>
4769
4770 * w32.c (pthread_sigmask): New stub.
4771
1692ae2d 47722011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4773
8a6ebd58 4774 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4775 sigprocmask is portable only for single-threaded applications, and
4776 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4777 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4778 (LIBES): Use it.
4779 * callproc.c (Fcall_process):
4780 * process.c (create_process):
4781 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4782 Use pthread_sigmask, not sigprocmask.
123403e4 4783
1b854618
JD
47842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4785
4786 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4787 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4788 wrong (Bug#8591).
4789
3fe4b549
JD
47902011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4791
0ce7e563
JD
4792 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4793 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4794 (xg_hide_tooltip): Fix comment.
4795
3fe4b549
JD
4796 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4797 in registerServicesMenuSendTypes.
4798 (validRequestorForSendType): Don't check ns_return_types.
4799
4800 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4801 ns_return_type.
4802
5df75e47
JR
48032011-07-08 Jason Rumney <jasonr@gnu.org>
4804
22610910
JR
4805 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4806 SH_SHOW for hidden windows (Bug#5482).
4807
5df75e47
JR
4808 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4809 frame struct members of non-existent frames (Bug#6284).
4810
699c10bd
JD
48112011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4812
4393663b
JD
4813 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4814 variable firstTime not needed on OSX >= 10.6.
4815 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4816 >= 10.5. Use setKnobProportion, setDoubleValue.
4817
4818 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4819 (MAC_OS_X_VERSION_10_5): Define if not defined.
4820 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4821 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4822 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4823
4824 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4825 cString and lossyCString on OSX >= 10.4
4826
58179cce 4827 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4828 sizeToFit on OSX >= 10.2.
4829
4830 * nsimage.m (allocInitFromFile): Don't use deprecated method
4831 bestRepresentationForDevice on OSX >= 10.6.
4832
4833 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4834 to avoid warning.
4835
4836 * emacs.c: Declare unexec_init_emacs_zone.
4837
a63e0781
JD
4838 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4839
699c10bd
JD
4840 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4841
4842 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4843 on svcsMenu (Bug#8842).
4844
4845 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4846 ns_return_types.
4847 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4848
4849 * nsterm.m (QUTF8_STRING): Declare.
4850 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4851 (validRequestorForSendType): Return type is (id).
4852 Change indexOfObjectIdenticalTo to indexOfObject.
4853 Check if we have local selection before returning self (Bug#8842).
4854 (writeSelectionToPasteboard): Put local selection into paste board
4855 if we have a local selection (Bug#8842).
4856 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4857
4858 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4859 (ns_get_local_selection): Declare.
4860
54e10184
LMI
48612011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4862
9888ff71
LMI
4863 * keymap.c (describe_map_tree): Don't insert a double newline at
4864 the end of the buffer (bug#1169) and return whether we inserted
4865 something.
4866
54e10184
LMI
4867 * callint.c (Fcall_interactively): Change "reading args" to
4868 "providing args" to try to clarify what it does (bug#1010).
4869
15fa4783
KH
48702011-07-07 Kenichi Handa <handa@m17n.org>
4871
4872 * composite.c (composition_compute_stop_pos): Ignore a static
4873 composition starting before CHARPOS (Bug#8915).
4874
4875 * xdisp.c (handle_composition_prop): Likewise.
4876
a8815b00
EZ
48772011-07-07 Eli Zaretskii <eliz@gnu.org>
4878
4879 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4880 (Bug#9015)
4881
ef7b981d 48822011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4883
4884 * character.h (unicode_category_t): New enum type.
4885
4886 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4887 (Qchar_code_property_table): New variable.
4888 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4889 (UNIPROP_COMPRESSED_FORM_P): New macros.
4890 (char_table_ascii): Uncompress the compressed values.
4891 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4892 Uncompress the compressed values.
ac389d0c 4893 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4894 (char_table_ref_and_range): Uncompress the compressed values.
4895 (sub_char_table_set): New arg is_uniprop. Callers changed.
4896 Uncompress the compressed values.
4897 (sub_char_table_set_range): Args changed. Callers changed.
4898 (char_table_set_range): Adjuted for the above change.
4899 (map_sub_char_table): Delete args default_val and parent. Add arg
4900 top. Give decoded values to a Lisp function.
640c8776 4901 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4902 values to a Lisp function. Gcpro more variables.
4903 (uniprop_table_uncompress)
4904 (uniprop_decode_value_run_length): New functions.
4905 (uniprop_decoder, uniprop_decoder_count): New variables.
4906 (uniprop_get_decoder, uniprop_encode_value_character)
4907 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4908 New functions.
4909 (uniprop_encoder, uniprop_encoder_count): New variables.
4910 (uniprop_get_encoder, uniprop_table)
4911 (Funicode_property_table_internal, Fget_unicode_property_internal)
4912 (Fput_unicode_property_internal): New functions.
4913 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4914 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4915 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4916 char-code-property-alist.
4917
640c8776 4918 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4919 Vunicode_category_table.
4920
640c8776 4921 * font.c (font_range): Adjust for the change of
c805dec0
KH
4922 Vunicode_category_table.
4923
76b397fb
DN
49242011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4925
4926 * m/iris4d.h: Remove file, move contents ...
4927 * s/irix6-5.h: ... here.
4928
22b4128e
PE
49292011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4930
4931 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4932 * alloc.c (mark_buffer):
4933 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4934 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4935 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4936 This isn't true in general, and it's particularly not true
4937 if Emacs is configured with --with-wide-int.
4938 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4939 New macros, used in the buffer.c change.
4940
869795d6
JD
49412011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4942
4943 * xsettings.c: Use both GConf and GSettings if both are available.
4944 (store_config_changed_event): Add comment.
4945 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4946 (store_tool_bar_style_changed): New functions.
5e617bc2 4947 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4948 (struct xsettings): Move font inside HAVE_XFT.
4949 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4950 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4951 Move inside HAVE_XFT.
640c8776 4952 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4953 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4954 also.
4955 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4956 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4957 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4958 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4959 (parse_settings): Move check for font inside HAVE_XFT.
4960 (read_settings, apply_xft_settings): Add comment.
4961 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4962 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4963 call store_font_name_changed.
4964 (xft_settings_event): Add comment.
4965 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4966 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4967 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4968 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4969 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4970 (xsettings_get_system_font, xsettings_get_system_normal_font):
4971 Add comment.
869795d6 4972
d8ed26bd
PE
49732011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4974
4975 Random fixes. E.g., (random) never returned negative values.
4976 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4977 subseconds part to the entropy, as that's a bit more random.
4978 Prefer signed to unsigned, since the signedness doesn't matter and
4979 in general we prefer signed. When given a limit, use a
4980 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4981 latter isn't right if USE_2_TAGS_FOR_INTS.
4982 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4983 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4984
cabf1cac
SM
49852011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4986
4987 * textprop.c (text_property_stickiness):
4988 Obey Vtext_property_default_nonsticky.
4989 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4990 * w32fns.c (syms_of_w32fns):
4991 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4992
6e9b2be9
PE
49932011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4994
4995 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4996 This is more efficient than Ffile_directory_p and avoids a minor race.
4997
90186c68
LMI
49982011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4999
7c301272
LMI
5000 * buffer.c (Foverlay_put): Say what the return value is
5001 (bug#7835).
5002
c4f2d8d4
LMI
5003 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5004 is a directory before asking whether to use the file name
5005 (bug#7564).
ad637907
LMI
5006 (barf_or_query_if_file_exists): Make the "File is a directory"
5007 error be more correct.
c4f2d8d4 5008
90186c68
LMI
5009 * fns.c (Frequire): Remove the mention of the .gz files, since
5010 that's installation-specific, but keep the mention of
5011 `get-load-suffixes'.
5012
da64016e
PE
50132011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5014
5015 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5016 Report string overflow if the output is too long.
5017
7d47b580
JB
50182011-07-04 Juanma Barranquero <lekktu@gmail.com>
5019
a555cb87
JB
5020 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5021 (syms_of_gnutls): Remove duplicate DEFSYM for
5022 Qgnutls_bootprop_verify_hostname_error, an error for
5023 Qgnutls_bootprop_verify_error (which is no longer used).
5024
7d47b580
JB
5025 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5026 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5027 Also (re)move comments that are misplaced or no longer relevant.
5028
1e49bfab
LMI
50292011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5030
5031 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5032
1485f4c0
CY
50332011-07-03 Chong Yidong <cyd@stupidchicken.com>
5034
5035 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5036 and background color parameters if they have been changed.
5037
a9ab721e
LMI
50382011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5039
5040 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5041
cf7cff57
PE
50422011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5043
2e13213d
PE
5044 * xsettings.c (SYSTEM_FONT): Define only when used.
5045 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5046
cf7cff57
PE
5047 * keymap.c (access_keymap_1): Now static.
5048
7a8e04f7
CY
50492011-07-02 Chong Yidong <cyd@stupidchicken.com>
5050
5051 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5052 leave any prefix arg for the up event (Bug#1586).
5053
61352f62
LMI
50542011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5055
69bb1ef7
LMI
5056 * lread.c (syms_of_lread): Mention single symbols defined by
5057 `defvar' or `defconst' (bug#7154).
5058
61352f62 5059 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 5060 (Frequire): Mention get-load-suffixes.
61352f62 5061
28545e04
MR
50622011-07-02 Martin Rudalics <rudalics@gmx.at>
5063
5064 * window.h (window): Remove clone_number slot.
5065 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5066 Remove.
5067 (make_parent_window, make_window, saved_window)
5068 (Fset_window_configuration, save_window_save): Don't deal with
5069 clone numbers.
5070 * buffer.c (Qclone_number): Remove declaration.
5071 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5072
3349e122
SM
50732011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5074
5075 Add multiple inheritance to keymaps.
5076 * keymap.c (Fmake_composed_keymap): New function.
5077 (Fset_keymap_parent): Simplify.
5078 (fix_submap_inheritance): Remove.
5079 (access_keymap_1): New function extracted from access_keymap to handle
5080 embedded parents and handle lists of maps.
5081 (access_keymap): Use it.
5082 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5083 (Fcopy_keymap): Handle embedded parents.
5084 (Fcommand_remapping, define_as_prefix): Simplify.
5085 (Fkey_binding): Simplify.
5086 (syms_of_keymap): Move minibuffer-local-completion-map,
5087 minibuffer-local-filename-completion-map,
5088 minibuffer-local-must-match-map, and
5089 minibuffer-local-filename-must-match-map to Elisp.
5090 (syms_of_keymap): Defsubr make-composed-keymap.
5091 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5092 (parse_menu_item): Trivial simplification.
5093
3279eb87
GM
50942011-07-01 Glenn Morris <rgm@gnu.org>
5095
5096 * Makefile.in (SETTINGS_LIBS): Fix typo.
5097
4550efdf
KI
50982011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5099
5100 * coding.c (Fencode_coding_string): Record the last coding system
5101 used, as the function doc string says (bug#8738).
5102
0949d2b6
JD
51032011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5104
5105 * xsettings.c (store_monospaced_changed): Take new font as arg and
5106 check for change against current_mono_font.
5107 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5108 (emacs_settings_constructor, emacs_settings_get_property)
5109 (emacs_settings_set_property, emacs_settings_class_init)
5110 (emacs_settings_init, gsettings_obj): Remove.
5111 (something_changedCB): New function for HAVE_GSETTINGS.
5112 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5113 with value as argument.
5114 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5115 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 5116 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
5117 "changed".
5118
5119 * xgselect.c: Add defined (HAVE_GSETTINGS).
5120 (xgselect_initialize): Ditto.
5121
5122 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5123 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5124 xg_select.
5125
bbc6b304
PE
51262011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5127
5128 * eval.c (struct backtrace): Simplify and port the data structure.
5129 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5130 signed bit field, as this assumption is not portable and it makes
5131 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5132 "char debug_on_exit : 1" as this is not portable either; instead,
5133 use the portable "unsigned int debug_on_exit : 1". Remove unused
5134 member evalargs. Remove obsolete comments about cc bombing out.
5135
9851bfc5
JD
51362011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5137
51bb811f 5138 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5139 Let HAVE_GSETTINGS override HAVE_GCONF.
5140 (store_monospaced_changed): New function.
5141 (EMACS_SETTINGS): A new type derived from GObject to handle
5142 GSettings notifications.
5143 (emacs_settings_constructor, emacs_settings_get_property)
5144 (emacs_settings_set_property, emacs_settings_class_init):
5145 New functions.
5146 (gsettings_client, gsettings_obj): New variables.
5147 (GSETTINGS_SCHEMA): New define.
5148 (something_changedCB): Call store_monospaced_changed.
5149 (init_gsettings): New function.
5150 (xsettings_initialize): Call init_gsettings.
5151 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5152 to NULL.
5153
640c8776 5154 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5155 GCONF_CFLAGS/LIBS.
5156
5386012d
MR
51572011-06-29 Martin Rudalics <rudalics@gmx.at>
5158
5159 * window.c (resize_root_window, grow_mini_window)
5160 (shrink_mini_window): Rename Qresize_root_window to
5161 Qwindow_resize_root_window and Qresize_root_window_vertically to
5162 Qwindow_resize_root_window_vertically.
5163
f13e0b08
PE
51642011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5165
5166 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5167
94515237
JB
51682011-06-27 Juanma Barranquero <lekktu@gmail.com>
5169
5170 * makefile.w32-in: Redesign dependencies so they reflect more
5171 clearly which files are directly included by each source file,
5172 and not through other includes.
5173
e43b6e43
MR
51742011-06-27 Martin Rudalics <rudalics@gmx.at>
5175
5176 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5177 (sort_overlays, overlay_strings): When an overlay's clone number
5178 matches the window's clone number process the overlay even if
5179 the overlay's window property doesn't match the current window.
5180
d68443dc
MR
5181 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5182 (Fwindow_hchild): Rename to Fwindow_left_child.
5183 (Fwindow_next): Rename to Fwindow_next_sibling.
5184 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5185 (resize_window_check): Rename to window_resize_check.
5186 (resize_window_apply): Rename to window_resize_apply.
5187 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5188 (Fdelete_other_windows_internal, resize_frame_windows)
5189 (Fsplit_window_internal, Fdelete_window_internal)
5190 (grow_mini_window, shrink_mini_window)
5191 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5192
c7e73be5
JD
51932011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5194
5195 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5196 (emacs_fixed_set_min_size): Remove.
5197 (emacs_fixed_new): Take frame as argument.
5198
5199 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5200 (_EmacsFixedPrivate): Remove minwidth/height.
5201 Add struct frame *f.
5202 (emacs_fixed_init): Initialize priv->f.
5203 (get_parent_class, emacs_fixed_set_min_size): Remove.
5204 (emacs_fixed_new): Set priv->f to argument.
5205 (emacs_fixed_get_preferred_width)
5206 (emacs_fixed_get_preferred_height): Use min_width/height from
5207 frames size_hint to set minimum and natural (Bug#8919).
5208 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5209 and use min_width/height from frames size_hint to set
5210 min_width/height (Bug#8919).
5211
5212 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5213 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5214 Fix indentation.
c7e73be5 5215
cf99dcf8
EZ
52162011-06-26 Eli Zaretskii <eliz@gnu.org>
5217
5218 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5219 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5220 called at ZV.
5221
029529ac
CY
52222011-06-26 Chong Yidong <cyd@stupidchicken.com>
5223
5224 * process.c (wait_reading_process_output): Bypass select if
5225 waiting for a cell while ignoring keyboard input, and input is
5226 pending. Suggested by Jan Djärv (Bug#8869).
5227
7a7ef429
PE
52282011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5229
5230 Use gnulib's dup2 module instead of rolling our own.
5231 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5232
11fdef7d 52332011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5234
5235 * dispnew.c (scrolling_window): Before scrolling, turn off a
5236 mouse-highlight in the window being scrolled.
5237
cd3520a4
JB
52382011-06-24 Juanma Barranquero <lekktu@gmail.com>
5239
5240 Move DEFSYM to lisp.h and use everywhere.
5241
5242 * character.h (DEFSYM): Move declaration...
5243 * lisp.h (DEFSYM): ...here.
5244
5245 * gnutls.c:
5246 * minibuf.c:
5247 * w32menu.c:
5248 * w32proc.c:
5249 * w32select.c: Don't include character.h.
5250
5251 * alloc.c (syms_of_alloc):
5252 * buffer.c (syms_of_buffer):
5253 * bytecode.c (syms_of_bytecode):
5254 * callint.c (syms_of_callint):
5255 * casefiddle.c (syms_of_casefiddle):
5256 * casetab.c (init_casetab_once):
5257 * category.c (init_category_once, syms_of_category):
5258 * ccl.c (syms_of_ccl):
5259 * cmds.c (syms_of_cmds):
5260 * composite.c (syms_of_composite):
5261 * dbusbind.c (syms_of_dbusbind):
5262 * dired.c (syms_of_dired):
5263 * dispnew.c (syms_of_display):
5264 * doc.c (syms_of_doc):
5265 * editfns.c (syms_of_editfns):
5266 * emacs.c (syms_of_emacs):
5267 * eval.c (syms_of_eval):
5268 * fileio.c (syms_of_fileio):
5269 * fns.c (syms_of_fns):
5270 * frame.c (syms_of_frame):
5271 * fringe.c (syms_of_fringe):
5272 * insdel.c (syms_of_insdel):
5273 * keymap.c (syms_of_keymap):
5274 * lread.c (init_obarray, syms_of_lread):
5275 * macros.c (syms_of_macros):
5276 * msdos.c (syms_of_msdos):
5277 * print.c (syms_of_print):
5278 * process.c (syms_of_process):
5279 * search.c (syms_of_search):
5280 * sound.c (syms_of_sound):
5281 * syntax.c (init_syntax_once, syms_of_syntax):
5282 * terminal.c (syms_of_terminal):
5283 * textprop.c (syms_of_textprop):
5284 * undo.c (syms_of_undo):
5285 * w32.c (globals_of_w32):
5286 * window.c (syms_of_window):
5287 * xdisp.c (syms_of_xdisp):
5288 * xfaces.c (syms_of_xfaces):
5289 * xfns.c (syms_of_xfns):
5290 * xmenu.c (syms_of_xmenu):
5291 * xsettings.c (syms_of_xsettings):
5292 * xterm.c (syms_of_xterm): Use DEFSYM.
5293
4228cf16
TZ
52942011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5295
cd3520a4 5296 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5297
7fcccf1e
PE
52982011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5299
7efb4e0e
PE
5300 Integer and buffer overflow fixes (Bug#8873).
5301
ff5844ad
PE
5302 * print.c (printchar, strout): Check for string overflow.
5303 (PRINTPREPARE, printchar, strout):
5304 Don't set size unless allocation succeeds.
5305
90532f02
PE
5306 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5307 for sizes. Check for string overflow more accurately.
5308 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5309
6d84508d
PE
5310 * macros.c: Integer and buffer overflow fixes.
5311 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5312 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5313 Use ptrdiff_t, not int, for sizes.
5314 Don't increment bufsize until after realloc succeeds.
5315 Check for size-calculation overflow.
5316 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5317
437b2cb4
PE
5318 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5319
8b9ac8b4
PE
5320 * lread.c: Integer overflow fixes.
5321 (read_integer): Radix is now EMACS_INT, not int,
5322 to improve quality of diagnostics for out-of-range radices.
5323 Calculate buffer size correctly for out-of-range radices.
5324 (read1): Check for integer overflow in radices, and in
5325 read-circle numbers.
82cb60d3
PE
5326 (read_escape): Avoid int overflow.
5327 (Fload, openp, read_buffer_size, read1)
5328 (substitute_object_recurse, read_vector, read_list, map_obarray):
5329 Use ptrdiff_t, not int, for sizes.
5330 (read1): Use EMACS_INT, not int, for sizes.
20270765 5331 Check for size overflow.
8b9ac8b4 5332
7fcccf1e
PE
5333 * image.c (cache_image): Check for size arithmetic overflow.
5334
bfbbd7e7
PE
5335 * lread.c: Integer overflow issues.
5336 (saved_doc_string_size, saved_doc_string_length)
5337 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5338 Now ptrdiff_t, not int.
5339 (read1): Don't assume doc string length fits in int. Check for
5340 out-of-range doc string lengths.
5341 (read_list): Don't assume file position fits in int.
39019e54 5342 (read_escape): Check for hex character overflow.
bfbbd7e7 5343
4e323265
LL
53442011-06-22 Leo Liu <sdl.web@gmail.com>
5345
5346 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5347 Move to minibuffer.el.
5348
85fece3e
PE
53492011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5350
20b84ce9 5351 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5352 The following patches are for when GLYPH_DEBUG && !XASSERT.
5353 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5354 * dispnew.c (flush_stdout):
5355 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5356 Mark as externally visible.
5357 * dispnew.c (check_window_matrix_pointers): Now static.
5358 * dispnew.c (window_to_frame_vpos):
5359 * xfns.c (unwind_create_frame):
5360 * xterm.c (x_check_font): Remove unused local.
5361 * scroll.c (CHECK_BOUNDS):
5362 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5363 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5364 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5365 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5366 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5367 Now static.
5368 (debug_method_add): Use va_list and vsprintf rather than relying
5369 on undefined behavior with wrong number of arguments.
5370 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5371 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5372 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5373 since we're not interested in debugging glyphs with old libraries.
5374 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5375 GCC 4.6.0's static checking.
5376
0766b489
PE
53772011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5378
31fd4b32
PE
5379 Integer overflow and signedness fixes (Bug#8873).
5380 A few related buffer overrun fixes, too.
5381
b79e8648
PE
5382 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5383
0766b489
PE
5384 * dispextern.h (struct face.stipple):
5385 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5386 (x_bitmap_mask, x_allocate_bitmap_record)
5387 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5388 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5389 (x_create_bitmap_from_xpm_data):
5390 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5391 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5392 (.bitmaps_last):
5393 * xfaces.c (load_pixmap):
5394 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5395 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5396 (.bitmaps_last, struct x_output.icon_bitmap):
5397 Use ptrdiff_t, not int, for bitmap indexes.
5398 (x_allocate_bitmap_record): Check for size overflow.
5399 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5400
b081724f
PE
5401 Use ptrdiff_t, not int, for overlay counts.
5402 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5403 * editfns.c (overlays_around, get_pos_property):
5404 * textprop.c (get_char_property_and_overlay):
5405 * xdisp.c (next_overlay_change, note_mouse_highlight):
5406 * xfaces.c (face_at_buffer_position):
21514da7
PE
5407 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5408 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5409 (Fnext_overlay_change, Fprevious_overlay_change)
5410 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5411 Use ptrdiff_t, not int, for sizes.
21514da7 5412 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5413
3de73e5e
PE
5414 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5415
2606c57b
PE
5416 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5417 (x_session_initialize): Do not assume string length fits in int.
5418
aaafe47a
PE
5419 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5420 This is unlikely, but can occur if DPI is outlandish.
5421
2674ddc8 5422 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5423 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5424
28154962
PE
5425 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5426 * xrdb.c (magic_file_p, search_magic_path):
5427 Omit last arg SUFFIX; it was always 0. All callers changed.
5428 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5429
7de51af5
PE
5430 * xfont.c (xfont_match): Avoid need for strlen.
5431
25ed6cc3
PE
5432 * xfns.c: Don't assume strlen fits in int.
5433 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5434
4eab31dd
PE
5435 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5436 not unsigned long, as we prefer signed integers. All callers changed.
5437 Detect integer overflow in repeat count.
5438 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5439 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5440
171e2a58
PE
5441 * termcap.c: Don't assume sizes fit in int and never overflow.
5442 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5443 (gobble_line): Check for size-calculation overflow.
5444
ad39faca 5445 * minibuf.c (Fread_buffer):
6e5bb2dc 5446 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5447 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5448 Don't assume string length fits in int.
5449
52c61c22 5450 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5451 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5452
b5b8c9e5
PE
5453 * font.c: Don't assume string length fits in int.
5454 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5455 Use ptrdiff_t, not int.
ccd6111c
PE
5456 (font_intern_prop): Don't assume string length fits in int.
5457 Don't assume integer property fits in fixnum.
5458 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5459
882f0d81 5460 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5461 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5462 Reformulate so as not to need the command string.
5463 Invoke gzip -cd rather than gunzip, as it's more portable.
5464 (lock_info_type, lock_file_1, lock_file):
5465 Don't assume pid_t and time_t fit in unsigned long.
5466 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5467 (current_lock_owner): Prefer signed type for sizes.
5468 Use memcpy, not strncpy, where memcpy is what is really wanted.
5469 Don't assume (via atoi) that time_t and pid_t fit in int.
5470 Check for time_t and/or pid_t out of range, e.g., via a network share.
5471 Don't alloca where an auto var works fine.
5472
93f4cf88
PE
5473 * fileio.c: Fix some integer overflow issues.
5474 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5475 Don't assume string length fits in int.
5476 (directory_file_name): Don't assume string length fits in long.
5477 (make_temp_name): Don't assume pid fits in int, or that its print
5478 length is less than 20.
5479
f3e92b69
PE
5480 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5481
1bfdaf10
PE
5482 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5483
35016e9a
PE
5484 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5485
3d1e65a1
PE
5486 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5487 We prefer signed integers, even for size calculations.
5488
0b963a93
PE
5489 * emacs.c: Don't assume string length fits in 'int'.
5490 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5491 (main): Don't invoke strlen when not needed.
5492
573f4b54
PE
5493 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5494 (XD_DEBUG_MESSAGE): Don't waste a byte.
5495
989f33ba
PE
5496 * callproc.c (getenv_internal_1, getenv_internal)
5497 (Fgetenv_internal):
965d34eb
PE
5498 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5499
e4d29b33
PE
5500 * lread.c (invalid_syntax): Omit length argument.
5501 All uses changed. This doesn't fix a bug, but it simplifies the
5502 code away from its former Hollerith-constant appearance, and it's
5503 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5504 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5505
eb49b136
PE
5506 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5507 This didn't break anything, but it didn't help either.
5508 It's confusing to put a bogus integer in a place where the actual
5509 value does not matter.
9f62aeb1 5510 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5511 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5512
15375a22
PE
5513 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5514 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5515 implementation.
b61cc01c
PE
5516 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5517 We prefer signed types, and the value cannot exceed the EMACS_INT
5518 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5519 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5520 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5521 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5522
53b2623d
PE
5523 * indent.c (sane_tab_width): New function.
5524 (current_column, scan_for_column, Findent_to, position_indentation)
5525 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5526 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5527
51cab52b 5528 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5529
f2ed8a70
PE
5530 * lisp.h (lint_assume): New macro.
5531 * composite.c (composition_gstring_put_cache):
5532 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5533
abe80cc6
PE
5534 * editfns.c, insdel.c:
5535 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5536
b02c740e
PE
5537 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5538
ebc96716
PE
5539 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5540
b4e50fa0 5541 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5542 Use much-faster test for byte-length change.
311d5d7c 5543 Don't assume string byte-length fits in 'int'.
a4cf38e4 5544 Check that character arg fits in 'int'.
85461888 5545 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5546
c0c1ee9f
PE
5547 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5548
a498d7f4
PE
5549 * fns.c (concat): Catch string overflow earlier.
5550 Do not rely on integer wraparound.
5551
51cab52b
PE
5552 * dispextern.h (struct it.overlay_strings_charpos)
5553 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5554 * xdisp.c (forward_to_next_line_start)
5555 (back_to_previous_visible_line_start)
5556 (reseat_at_next_visible_line_start, next_element_from_buffer):
5557 Don't arbitrarily truncate the value of 'selective' to int.
5558
76031fad
PE
5559 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5560
5eb55db9
PE
5561 * composite.c: Don't truncate sizes to 'int'.
5562 (composition_gstring_p, composition_reseat_it)
5563 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5564 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5565 not EMACS_UINT, for indexes.
5eb55db9 5566
0703a717
PE
5567 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5568
d6202519
PE
5569 * buffer.c: Include <verify.h>.
5570 (struct sortvec.priority, struct sortstr.priority):
8961a454 5571 Now EMACS_INT, not int.
c20998a7 5572 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5573 (struct sortstr.size, record_overlay_string)
5574 (struct sortstrlist.size, struct sortlist.used):
5575 Don't truncate size to int.
5576 (record_overlay_string): Check for size-calculation overflow.
d6202519 5577 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5578
d5a19415
JM
55792011-06-22 Jim Meyering <meyering@redhat.com>
5580
029529ac 5581 Don't leak an XBM-image-sized buffer
d5a19415
JM
5582 * image.c (xbm_load): Free the image buffer after using it.
5583
a9041e6c
PE
55842011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5585
5586 Port to Sun C.
5587 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5588 that Sun C diagnosed.
5589 * fns.c (secure_hash): Fix pointer signedness issue.
5590 * intervals.c (static_offset_intervals): New function.
5591 (offset_intervals): Use it.
5592
7f3f739f
LL
55932011-06-21 Leo Liu <sdl.web@gmail.com>
5594
5595 * deps.mk (fns.o):
5596 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5597 sha512.h.
5598
5599 * fns.c (secure_hash): Rename from crypto_hash_function and change
5600 the first arg to accept symbols.
5b66d427 5601 (Fsecure_hash): New primitive.
7f3f739f
LL
5602 (syms_of_fns): New symbols.
5603
76147d94
DD
56042011-06-20 Deniz Dogan <deniz@dogan.se>
5605
5606 * process.c (Fset_process_buffer): Clarify return value in
5607 docstring.
5608
7d7d0045
CY
56092011-06-18 Chong Yidong <cyd@stupidchicken.com>
5610
5611 * dispnew.c (add_window_display_history): Use BVAR.
5612
5613 * xdisp.c (debug_method_add): Use BVAR.
5614 (check_window_end, dump_glyph_matrix, dump_glyph)
5615 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5616
5617 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5618 Likewise.
5619
5620 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5621 check till after the cache is created in init_frame_faces.
5622
ff2bc410
SM
56232011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5624
5625 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5626
28177add
PE
56272011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5628
dd3482fe
PE
5629 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5630 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5631 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5632
393d71f3 5633 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5634 * fileio.c (Finsert_file_contents):
5635 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5636 Remove the old (too-loose) buffer overflow checks.
5637 They weren't needed, since make_gap checks for buffer overflow.
5638 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5639 The old code merely checked for Emacs fixnum overflow, and relied
5640 on undefined (wraparound) behavior. The new code avoids undefined
5641 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5642
2e6813b0 5643 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5644 Tune. Don't use wider integers than needed. Don't use alloca.
5645 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5646
599a9e4f
PE
5647 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5648
99561444
PE
5649 * insdel.c, lisp.h (buffer_overflow): New function.
5650 (insert_from_buffer_1, replace_range, replace_range_2):
5651 * insdel.c (make_gap_larger):
5652 * editfns.c (Finsert_char):
5653 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5654
28177add
PE
5655 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5656
e69dafad
PE
56572011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5658
4baa020d 5659 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5660
b1c46f02
PE
5661 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5662 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5663
e69dafad
PE
5664 * fileio.c: Don't assume EMACS_INT fits in off_t.
5665 (emacs_lseek): New static function.
5666 (Finsert_file_contents, Fwrite_region): Use it.
5667 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5668
566684ea
PE
5669 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5670
e6966cd6
PE
5671 * fns.c: Don't overflow int when computing a list length.
5672 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5673 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5674 truncation on 64-bit hosts. Check for QUIT every
5675 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5676 faster and is responsive enough.
5677 (Flength): Report an error instead of overflowing an integer.
5678 (Fsafe_length): Return a float if the value is not representable
5679 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5680 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5681 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5682
dd0b0efb
PE
5683 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5684 (header_size, word_size): New constants.
5685 (allocate_vectorlike): Don't check size overflow here.
5686 (allocate_vector): Check it here instead, since this is the only
5687 caller of allocate_vectorlike that could cause overflow.
5688 Check that the new vector's length is representable as a fixnum.
5689
86fe5cfe
PE
5690 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5691 The previous code was bogus. For example, next_almost_prime (32)
5692 returned 39, which is undesirable as it is a multiple of 3; and
5693 next_almost_prime (24) returned 25, which is a multiple of 5 so
5694 why was the code bothering to check for multiples of 7?
5695
80e88859
PE
5696 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5697
4a2f0ad6
PE
5698 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5699
f66c7cf8
PE
5700 Variadic C functions now count arguments with ptrdiff_t.
5701 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5702 Back then I didn't know that the Emacs coding style prefers signed int.
5703 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5704 were being counted with int, which may truncate counts on 64-bit
5705 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5706 * lisp.h (struct Lisp_Subr.function.aMANY)
5707 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5708 Arg counts are now ptrdiff_t, not size_t.
5709 All variadic functions and their callers changed accordingly.
5710 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5711 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5712 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5713 * callint.c (Fcall_interactively): Check arg count for overflow,
5714 to avoid potential buffer overrun. Use signed char, not 'int',
5715 for 'varies' array, so that we needn't bother to check its size
5716 calculation for overflow.
5717 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5718 * eval.c (apply_lambda):
5719 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5720 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5721 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5722
a1759b76
PE
5723 * callint.c (Fcall_interactively): Don't use index var as event count.
5724
d96be9fc
PE
5725 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5726 * mem-limits.h (SIZE): Remove; no longer used.
5727
a690a978 5728 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5729
578c21e6
PE
5730 Remove unnecessary casts.
5731 * xterm.c (x_term_init):
5732 * xfns.c (x_set_border_pixel):
5733 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5734 These aren't needed now that we assume ANSI C.
5735
96f53c6c
PE
5736 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5737 It's more likely to cause problems (due to unsigned overflow)
5738 than to cure them.
5739
83c77d31
PE
5740 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5741
ee2079f1
PE
5742 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5743
6da65536
PE
5744 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5745
7147c4a4
PE
5746 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5747
193e32d9
PE
5748 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5749
e5533da6
PE
5750 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5751
9910e595
PE
5752 GLYPH_CODE_FACE returns EMACS_INT, not int.
5753 * dispextern.h (merge_faces):
5754 * xfaces.c (merge_faces):
01103c44
PE
5755 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5756 Don't assume EMACS_INT fits in int.
9910e595 5757
2638320e
PE
5758 * character.h (CHAR_VALID_P): Remove unused parameter.
5759 * fontset.c, lisp.h, xdisp.c: All uses changed.
5760
045eb8d9
PE
5761 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5762
c1f134b5
PE
5763 * fns.c (concat): Minor tuning based on overflow analysis.
5764 This doesn't fix any bugs. Use int to hold character, instead
5765 of constantly refetching from Emacs object. Use XFASTINT, not
5766 XINT, for value known to be a character. Don't bother comparing
5767 a single byte to 0400, as it's always less.
5768
395fcb93 5769 * floatfns.c (Fexpt):
327eeec8
PE
5770 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5771
abbd3d23
PE
5772 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5773 for characters.
5774
684a03ef
PE
5775 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5776
0fed43f3
PE
5777 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5778 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5779 incorrectly succeed when S was a string, because 4294967386 was
5780 truncated before it was used.
5781
8fd02eb7
PE
5782 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5783 Otherwise, an out-of-range integer could cause undefined behavior
5784 on a 64-bit host.
5785
f8c86b69
PE
5786 * composite.c: Use int, not EMACS_INT, for characters.
5787 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5788 EMACS_INT, for values that are known to be in character range.
5789 This doesn't fix any bugs but is the usual style inside Emacs and
5790 may generate better code on 32-bit machines.
5791
34206dd2
PE
5792 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5793 This is for reasons similar to the recent CHAR_STRING fix.
5794 * charset.c (Fencode_char): Check that character arg is actually
5795 a character. Pass an int to ENCODE_CHAR.
5796 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5797 wider than 'int', as a compile-time check to prevent future regressions
5798 in this area.
5799
c5958d4c 5800 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5801
5802 Make sure a 64-bit char is never passed to CHAR_STRING.
5803 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5804 by silently ignoring the top 32 bits, allowing some values
5805 that were far too large to be valid characters.
5806 * character.h: Include <verify.h>.
5807 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5808 arguments are no wider than unsigned, as a compile-time check
5809 to prevent future regressions in this area.
5810 * data.c (Faset):
01103c44 5811 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5812 (Fsubst_char_in_region):
5813 * fns.c (concat):
5814 * xdisp.c (decode_mode_spec_coding):
5815 Adjust to CHAR_STRING's new requirement.
5816 * editfns.c (Finsert_char, Fsubst_char_in_region):
5817 * fns.c (concat): Check that character args are actually
5818 characters. Without this test, these functions did the wrong
5819 thing with wildly out-of-range values on 64-bit hosts.
5820
d37ca623
PE
5821 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5822 These casts should not be needed on 32-bit hosts, either.
5823 * keyboard.c (read_char):
5824 * lread.c (Fload): Remove casts to unsigned.
5825
ea204efb
PE
5826 * lisp.h (UNSIGNED_CMP): New macro.
5827 This fixes comparison bugs on 64-bit hosts.
5828 (ASCII_CHAR_P): Use it.
5829 * casefiddle.c (casify_object):
01103c44 5830 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5831 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5832 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5833 * dispextern.h (FACE_FROM_ID):
5834 * keyboard.c (read_char): Use UNSIGNED_CMP.
5835
41cb286c
PE
5836 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5837 not to EMACS_INT, to avoid GCC warning.
5838
4a1b9832
PE
5839 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5840
55daad71
PE
5841 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5842 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5843 isn't needed on 32-bit machines.
8f95c75c 5844
01103c44
PE
5845 * buffer.c (Fgenerate_new_buffer_name):
5846 Use EMACS_INT for count, not int.
0ceccced 5847 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5848
5849 * data.c (Qcompiled_function): Now static.
5850
c6f072e7
PE
5851 * window.c (window_body_lines): Now static.
5852
20ce5912
PE
5853 * image.c (gif_load): Rename local to avoid shadowing.
5854
9c4c5f81
PE
5855 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5856 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5857 * alloc.c (make_save_value): Integer argument is now of type
5858 ptrdiff_t, not int.
5859 (mark_object): Use ptrdiff_t, not int.
5860 * lisp.h (pD): New macro.
5861 * print.c (print_object): Use it.
5862
c0c5c8ae
PE
5863 * alloc.c: Use EMACS_INT, not int, to count objects.
5864 (total_conses, total_markers, total_symbols, total_vector_size)
5865 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5866 (total_free_floats, total_floats, total_free_intervals)
5867 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5868 Now EMACS_INT, not int. All uses changed.
5869 (Fgarbage_collect): Compute overall total using a double, so that
5870 integer overflow is less likely to be a problem. Check for overflow
5871 when converting back to an integer.
5a25e253
PE
5872 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5873 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5874 These were 'int' variables that could overflow on 64-bit hosts;
5875 they were never used, so remove them instead of repairing them.
211a0b2a 5876 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5877 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5878 Previously, this ceilinged at INT_MAX, but that doesn't work on
5879 64-bit machines.
e46bb31a 5880 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5881
c78baabf 5882 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5883 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5884 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5885 when a (possibly-narrower) signed value would do just as well.
5886 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5887
c9d624c6
PE
5888 * alloc.c: Catch some string size overflows that we were missing.
5889 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5890 for convenience in STRING_BYTES_MAX.
5891 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5892 The definition here is exact; the one in lisp.h was approximate.
5893 (allocate_string_data): Check for string overflow. This catches
5894 some instances we weren't catching before. Also, it catches
5895 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5896 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5897 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5898
c9d624c6
PE
5899 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5900 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5901 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5902
353032ce
PE
5903 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5904
2bccce07
PE
5905 * alloc.c (Fmake_string): Check for out-of-range init.
5906
0ac30604
SM
59072011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5908
5909 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5910
c195f2de
JD
59112011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5912
5913 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5914 xg_get_default_scrollbar_width.
5915
5916 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5917 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5918 (style_changed_cb): Call update_theme_scrollbar_width and call
5919 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5920 all frames (Bug#8505).
5921 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5922 Call gtk_window_set_resizable if HAVE_GTK3.
5923 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5924 and height if HAVE_GTK3 (Bug#8505).
5925 (scroll_bar_width_for_theme): New variable.
5926 (update_theme_scrollbar_width): New function.
5927 (xg_get_default_scrollbar_width): Move code to
5928 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5929 (xg_initialize): Call update_theme_scrollbar_width.
5930
5931 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5932
5933 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5934
e10ac9f1
MR
59352011-06-12 Martin Rudalics <rudalics@gmx.at>
5936
5937 * frame.c (make_frame): Call other_buffer_safely instead of
5938 other_buffer.
5939
5940 * window.c (temp_output_buffer_show): Call display_buffer with
5941 second argument Vtemp_buffer_show_specifiers and reset latter
5942 immediately after the call.
5943 (Vtemp_buffer_show_specifiers): New variable.
5944 (auto_window_vscroll_p, next_screen_context_lines)
5945 (Vscroll_preserve_screen_position): Remove leading asterisks from
5946 doc-strings.
5947
2d3c217e 59482011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5949
7b7f97e8 5950 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5951 * buffer.c (Qclone_number): Remove for now, as it's unused.
5952 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5953 (record_buffer): Remove unused local.
5954 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5955 (set_frame_buffer_list): Remove; unused.
5956 * frame.h (other_visible_frames): Remove decl.
5957 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5958 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5959 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5960 if HAVE_GPM.
5961 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5962 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5963 Define only if HAVE_GPM.
5964 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5965 (update_hints_inhibit): Remove; never set. All uses removed.
5966 * widgetprv.h (emacsFrameClassRec): Remove decl.
5967 * window.c (delete_deletable_window): Now returns void, since it
5968 wasn't returning anything.
5969 (compare_window_configurations): Remove unused locals.
5970 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5971 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5972 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5973 the same widths as pointers. This follows up on the 2011-05-06 patch.
5974 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5975 * xterm.h: Likewise.
5976 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5977
1384b89e
JB
59782011-06-12 Juanma Barranquero <lekktu@gmail.com>
5979
5980 * makefile.w32-in: Update dependencies.
5981 (LISP_H): Add lib/intprops.h.
5982
1100a63c
CY
59832011-06-11 Chong Yidong <cyd@stupidchicken.com>
5984
5985 * image.c (gif_load): Add animation frame delay to the metadata.
5986 (syms_of_image): Use DEFSYM. New symbol `delay'.
5987
6198ccd0
MR
59882011-06-11 Martin Rudalics <rudalics@gmx.at>
5989
5990 * window.c (delete_deletable_window): Re-add.
5991 (Fset_window_configuration): Rewrite to handle dead buffers and
5992 consequently deletable windows.
5993 (window_tree, Fwindow_tree): Remove. Supply functionality in
5994 window.el.
5995 (compare_window_configurations): Simplify code.
5996
b6e3633c
AS
59972011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5998
1ab0dee5
AS
5999 * image.c (imagemagick_load_image): Fix type mismatch.
6000 (Fimagemagick_types): Likewise.
6001
b6e3633c
AS
6002 * window.h (replace_buffer_in_windows): Declare.
6003
9397e56f
MR
60042011-06-11 Martin Rudalics <rudalics@gmx.at>
6005
6006 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6007 Qclone_number. Remove external declaration of Qdelete_window.
6008 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6009 code.
640c8776
SM
6010 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6011 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
6012 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6013 buffer list implementation.
6014 (other_buffer_safely): New function.
6015 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6016 calls to replace_buffer_in_windows and
6017 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6018 if allowed.
6019 (record_buffer): Inhibit quitting and rewrite using quittable
6020 functions. Run Qbuffer_list_update_hook if allowed.
6021 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
6022 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6023 Move switch-to-buffer to window.el.
9397e56f
MR
6024 (bury-buffer): Move to window.el.
6025 (Vbuffer_list_update_hook): New variable.
6026
6027 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6028 section.
6029
6030 * window.h (resize_frame_windows): Move up in code.
6031 (Fwindow_frame): Remove EXFUN.
6032 (replace_buffer_in_all_windows): Remove prototype.
6033 (replace_buffer_in_windows_safely): Add prototype.
6034
6035 * window.c: Declare Qdelete_window static again. Move down
6036 declaration of select_count.
6037 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6038 (Fother_window): Move to window.el.
6039 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6040 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6041 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6042 window.el.
6043 (replace_buffer_in_windows): Implement by calling
6044 Qreplace_buffer_in_windows.
6045 (replace_buffer_in_all_windows): Remove with some functionality
6046 moved into replace_buffer_in_windows_safely.
6047 (replace_buffer_in_windows_safely): New function.
6048 (select_window_norecord, select_frame_norecord): Move in front
6049 of run_window_configuration_change_hook. Remove now obsolete
6050 declarations.
640c8776
SM
6051 (Fset_window_buffer): Rewrite doc-string.
6052 Call Qrecord_window_buffer.
9397e56f
MR
6053 (keys_of_window): Move binding for other-window to window.el.
6054
b50691aa
CY
60552011-06-11 Chong Yidong <cyd@stupidchicken.com>
6056
6057 * dispextern.h (struct image): Replace data member, whose int_val
6058 and ptr_val fields were not used by anything, with a single
6059 lisp_val object.
6060
6061 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6062 (gif_clear_image, gif_load, imagemagick_load_image)
6063 (gs_clear_image, gs_load): Callers changed.
6064
3f754b86
PE
60652011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6066
cca69397
PE
6067 * buffer.h: Include <time.h>, for time_t.
6068 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6069
109e28d0
PE
6070 Fix minor problems found by static checking.
6071
60737f02
PE
6072 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6073
4b66faf3
PE
6074 Make identifiers static if they are not used in other modules.
6075 * data.c (Qcompiled_function, Qframe, Qvector):
6076 * image.c (QimageMagick, Qsvg):
6077 * minibuf.c (Qmetadata):
6078 * window.c (resize_window_check, resize_root_window): Now static.
6079 * window.h (resize_window_check, resize_root_window): Remove decls.
6080
109e28d0
PE
6081 * window.c (window_deletion_count, delete_deletable_window):
6082 Remove; unused.
46a4ce9e
PE
6083 (window_body_lines): Now static.
6084 (Fdelete_other_windows_internal): Mark vars as initialized.
6085 Make sure 'resize_failed' is initialized.
6086 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6087 (resize_window_apply): Remove unused local.
6088 * window.h (delete_deletable_window): Remove decl.
6089
109e28d0 6090 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
6091 (imagemagick_load_image): Fix pointer signedness problem by changing
6092 last arg from unsigned char * to char *. All uses changed.
6093 Also, fix a local for similar reasons.
6094 Remove unused locals. Remove locals to avoid shadowing.
6095 (fn_rsvg_handle_free): Remove; unused.
6096 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 6097 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 6098
3f754b86
PE
6099 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6100
2547adb1
CY
61012011-06-10 Chong Yidong <cyd@stupidchicken.com>
6102
6103 * image.c (gif_load): Fix omitted cast error introduced by
6104 2011-06-06 change.
6105
2c8e37d4
MR
61062011-06-10 Martin Rudalics <rudalics@gmx.at>
6107
6108 * window.h (resize_proportionally, orig_total_lines)
6109 (orig_top_line): Remove from window structure.
6110 (set_window_height, set_window_width, change_window_heights)
6111 (Fdelete_window): Remove prototypes.
6112 (resize_frame_windows): Remove duplicate declaration.
6113
440a42e3
EZ
61142011-06-10 Eli Zaretskii <eliz@gnu.org>
6115
6116 * window.h (resize_frame_windows, resize_window_check)
6117 (delete_deletable_window, resize_root_window)
6118 (resize_frame_windows): Declare prototypes.
6119
6120 * window.c (resize_window_apply): Make definition be "static" to
6121 match the prototype.
6122
562dd5e9
MR
61232011-06-10 Martin Rudalics <rudalics@gmx.at>
6124
6125 * window.c: Remove declarations of Qwindow_size_fixed,
6126 window_min_size_1, window_min_size_2, window_min_size,
6127 size_window, window_fixed_size_p, enlarge_window, delete_window.
6128 Remove static from declaration of Qdelete_window, it's
6129 temporarily needed by Fbury_buffer.
6130 (replace_window): Don't assign orig_top_line and
6131 orig_total_lines.
6132 (Fdelete_window, delete_window): Remove. Window deletion is
6133 handled by window.el.
640c8776
SM
6134 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6135 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
6136 (Fdelete_other_windows): Remove. Deleting other windows is
6137 handled by window.el.
6138 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6139 handled in window.el.
6140 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6141 Window minimum sizes are handled in window.el.
6142 (shrink_windows, size_window, set_window_height)
6143 (set_window_width, change_window_heights, window_height)
6144 (window_width, CURBEG, CURSIZE, enlarge_window)
6145 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6146 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6147 handled in window.el.
6148 (make_dummy_parent): Rename to make_parent_window and give it a
6149 second argument horflag.
6150 (make_window): Don't set resize_proportionally any more.
6151 (Fsplit_window): Remove. Windows are split in window.el.
6152 (save_restore_action, save_restore_orig_size)
6153 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6154 Resize mini windows in window.el.
6155 (grow_mini_window, shrink_mini_window): Implement by calling
6156 Qresize_root_window_vertically, resize_window_check and
6157 resize_window_apply.
640c8776
SM
6158 (saved_window, Fset_window_configuration, save_window_save):
6159 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6160 resize_proportionally.
6161 (window_min_height, window_min_width): Move to window.el.
6162 (keys_of_window): Move bindings for delete-other-windows,
6163 split-window, delete-window and enlarge-window to window.el.
6164
6165 * buffer.c: Temporarily extern Qdelete_window.
6166 (Fbury_buffer): Temporarily call Qdelete_window instead of
6167 Fdelete_window (Fbury_buffer will move to window.el soon).
6168
6169 * frame.c (set_menu_bar_lines_1): Remove code handling
6170 orig_top_line and orig_total_lines.
6171
6172 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6173 set_window_height but set heights directly.
6174 (change_frame_size_1): Use resize_frame_windows.
6175
6176 * xdisp.c (init_xdisp): Don't use set_window_height but set
6177 heights directly.
6178
640c8776
SM
6179 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6180 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6181 run_window_configuration_change_hook.
6182
6183 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6184 instead of change_window_heights and run
6185 run_window_configuration_change_hook.
6186
1a13852e
MR
61872011-06-09 Martin Rudalics <rudalics@gmx.at>
6188
6189 * window.c (replace_window): Rename second argument REPLACEMENT to
6190 NEW. New third argument SETFLAG. Rewrite.
6191 (delete_window, make_dummy_parent): Call replace_window with
6192 third argument 1.
6193 (window_list_1): Move down in code.
6194 (run_window_configuration_change_hook): Move set_buffer part
6195 before select_frame_norecord part in order to unwind correctly.
6196 Rename count1 to count.
6197 (recombine_windows, delete_deletable_window, resize_root_window)
6198 (Fdelete_other_windows_internal)
6199 (Frun_window_configuration_change_hook, make_parent_window)
6200 (resize_window_check, resize_window_apply, Fresize_window_apply)
6201 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6202 (Fdelete_window_internal, Fresize_mini_window_internal):
6203 New functions.
1a13852e
MR
6204 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6205
f3d1777e
MR
62062011-06-08 Martin Rudalics <rudalics@gmx.at>
6207
496e208e
MR
6208 * window.h (window): Add some new members to window structure -
6209 normal_lines, normal_cols, new_total, new_normal, clone_number,
6210 splits, nest, prev_buffers, next_buffers.
6211 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6212 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6213
f3d1777e
MR
6214 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6215 Remove.
496e208e
MR
6216 (make_dummy_parent): Set new members of windows structure.
6217 (make_window): Move down in code. Handle new members of window
6218 structure.
6219 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6220 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6221 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6222 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6223 (Fset_window_next_buffers, Fset_window_clone_number):
6224 New functions.
496e208e
MR
6225 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6226 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6227 Doc-string fixes.
6228 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6229 Argument WINDOW can be now internal window too.
6230 (Fwindow_use_time): Move up in code.
6231 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6232 Rewrite doc-string.
6233 (Fset_window_configuration, saved_window)
6234 (Fcurrent_window_configuration, save_window_save): Handle new
6235 members of window structure.
b9e809c2
MR
6236 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6237 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6238 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6239 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6240 Qget_mru_window, Qresize_root_window,
6241 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6242 Qauto_buffer_name; staticpro them.
f3d1777e 6243
abde8f8c
MR
62442011-06-07 Martin Rudalics <rudalics@gmx.at>
6245
6246 * window.c (Fwindow_total_size, Fwindow_left_column)
6247 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6248 (Fwindow_list_1): New functions.
6249 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6250 (Fwindow_width, Fscroll_left, Fscroll_right):
6251 Use window_body_cols instead of window_box_text_cols.
6252 (delete_window, Fset_window_configuration):
6253 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6254 (delete_all_subwindows): Take a window as argument and not a
6255 structure. Rewrite.
190b47e6
MR
6256 (window_loop): Remove handling of GET_LRU_WINDOW and
6257 GET_LARGEST_WINDOW.
6258 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6259
6260 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6261 window_box_text_cols. delete_all_subwindows now takes a
6262 Lisp_Object as argument.
abde8f8c 6263
640c8776
SM
6264 * indent.c (compute_motion, Fcompute_motion):
6265 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6266
fa8a67e6
MR
6267 * frame.c (delete_frame): Call delete_all_subwindows with root
6268 window as argument.
6269
a54e3482
DC
62702011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6271
6272 * fns.c (Fputhash): Document return value.
6273
60002bf5
CY
62742011-06-06 Chong Yidong <cyd@stupidchicken.com>
6275
6276 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6277
0c671da6 62782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6279
b862a52a 6280 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6281
be44ca6c
PE
6282 Check for overflow when converting integer to cons and back.
6283 * charset.c (Fdefine_charset_internal, Fdecode_char):
6284 Use cons_to_unsigned to catch overflow.
6285 (Fencode_char): Use INTEGER_TO_CONS.
6286 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6287 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6288 * data.c (long_to_cons, cons_to_long): Remove.
6289 (cons_to_unsigned, cons_to_signed): New functions.
6290 These signal an error for invalid or out-of-range values.
6291 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6292 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6293 * font.c (Ffont_variation_glyphs):
6294 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6295 * lisp.h: Include <intprops.h>.
6296 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6297 (cons_to_signed, cons_to_unsigned): New decls.
6298 (long_to_cons, cons_to_long): Remove decls.
6299 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6300 (Fprimitive_undo): Use CONS_TO_INTEGER.
6301 * xfns.c (Fx_window_property): Likewise.
6302 * xselect.c: Include <limits.h>.
6303 (x_own_selection, selection_data_to_lisp_data):
6304 Use INTEGER_TO_CONS.
6305 (x_handle_selection_request, x_handle_selection_clear)
6306 (x_get_foreign_selection, Fx_disown_selection_internal)
6307 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6308 (lisp_data_to_selection_data): Use cons_to_unsigned.
6309 (x_fill_property_data): Use cons_to_signed.
6310 Report values out of range.
6311
d1f3d2af
PE
6312 Check for buffer and string overflow more precisely.
6313 * buffer.h (BUF_BYTES_MAX): New macro.
6314 * lisp.h (STRING_BYTES_MAX): New macro.
6315 * alloc.c (Fmake_string):
6316 * character.c (string_escape_byte8):
6317 * coding.c (coding_alloc_by_realloc):
6318 * doprnt.c (doprnt):
6319 * editfns.c (Fformat):
6320 * eval.c (verror):
6321 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6322 since they may not be the same number.
6323 * editfns.c (Finsert_char):
6324 * fileio.c (Finsert_file_contents):
6325 Likewise for BUF_BYTES_MAX.
6326
dd52fcea
PE
6327 * image.c: Use ptrdiff_t, not int, for sizes.
6328 (slurp_file): Switch from int to ptrdiff_t.
6329 All uses changed.
6330 (slurp_file): Check that file size fits in both size_t (for
6331 malloc) and ptrdiff_t (for sanity and safety).
6332
7f9bbdbb
PE
6333 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6334 if b->modtime has its maximal value.
6335
dfe18f82
PE
6336 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6337
84acfcf0
PE
6338 Don't assume time_t can fit into int.
6339 * buffer.h (struct buffer.modtime): Now time_t, not int.
6340 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6341 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6342
ccd9a01a
PE
6343 Minor fixes for signed vs unsigned integers.
6344 * character.h (MAYBE_UNIFY_CHAR):
6345 * charset.c (maybe_unify_char):
6346 * keyboard.c (read_char, reorder_modifiers):
6347 XINT -> XFASTINT, since the integer must be nonnegative.
6348 * ftfont.c (ftfont_spec_pattern):
6349 * keymap.c (access_keymap, silly_event_symbol_error):
6350 XUINT -> XFASTINT, since the integer must be nonnegative.
6351 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6352 since it makes no difference and we prefer signed.
6353 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6354 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6355 nonnegative.
6356
d6d100dd
SM
63572011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6358
6359 * window.h (Fwindow_frame): Declare.
6360
2b6148e4
PE
63612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6362
6363 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6364 (SPARE_MEMORY): Always define.
6365 (LARGE_REQUEST): Remove.
6366 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6367
f230ecc9
MR
63682011-06-06 Martin Rudalics <rudalics@gmx.at>
6369
727e958e
MR
6370 * lisp.h: Move EXFUNS for Fframe_root_window,
6371 Fframe_first_window and Fset_frame_selected_window to window.h.
6372
6373 * window.h: Move EXFUNS for Fframe_root_window,
6374 Fframe_first_window and Fset_frame_selected_window here from
6375 lisp.h.
6376
6377 * frame.c (Fwindow_frame, Fframe_first_window)
6378 (Fframe_root_window, Fframe_selected_window)
6379 (Fset_frame_selected_window): Move to window.c.
6380 (Factive_minibuffer_window): Move to minibuf.c.
6381 (Fother_visible_frames_p): New function.
6382
6383 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6384
f230ecc9
MR
6385 * window.c (decode_window, decode_any_window): Move up in code.
6386 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6387 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6388 (Fwindow_buffer): Move up and rewrite doc-string.
6389 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6390 (Fwindow_prev): New functions.
727e958e
MR
6391 (Fwindow_frame): Move here from frame.c. Accept any window as
6392 argument.
6393 (Fframe_root_window, Fframe_first_window)
6394 (Fframe_selected_window): Move here from frame.c. Accept frame
6395 or arbitrary window as argument. Update doc-strings.
6396 (Fminibuffer_window): Move up in code.
6397 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6398 (Fset_frame_selected_window): Move here from frame.c.
6399 Marginal rewrite.
727e958e
MR
6400 (Fselected_window, select_window, Fselect_window): Move up in
6401 code. Minor doc-string fixes.
f230ecc9 6402
4d09bcf6
PE
64032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6404
6405 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6406 Do not assume that spare memory exists; that assumption is valid
6407 only if SYSTEM_MALLOC.
6408 (LARGE_REQUEST): New macro, so that the issue of large requests
6409 is separated from the issue of spare memory.
6410
810928a2
AS
64112011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6412
172418ad
AS
6413 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6414 format. (Bug#8806)
6415
43f862f7
AS
6416 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6417
810928a2
AS
6418 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6419 before statements.
6420
a059fe24
JD
64212011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6422
6423 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6424
6425 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6426
6427 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6428 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6429
989bf368
JB
64302011-06-05 Juanma Barranquero <lekktu@gmail.com>
6431
6432 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6433
4b80f674
CY
64342011-06-04 Chong Yidong <cyd@stupidchicken.com>
6435
6436 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6437 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6438 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6439 New error handlers.
4b80f674
CY
6440 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6441 Obey Vx_select_enable_clipboard_manager. Catch errors in
6442 x_clipboard_manager_save (Bug#8779).
6443 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6444 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6445
99a33b77 64462011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6447
6448 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6449
99a33b77 64502011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6451
6452 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6453 in the current matrix if keep_current_p is non-zero.
6454
8264569d
EZ
64552011-06-04 Eli Zaretskii <eliz@gnu.org>
6456
6457 * bidi.c (bidi_level_of_next_char): Fix last change.
6458
57f97249
EZ
64592011-06-03 Eli Zaretskii <eliz@gnu.org>
6460
fec2107c 6461 Support bidi reordering of text covered by display properties.
57f97249 6462
fec2107c
EZ
6463 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6464 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6465 (bidi_cache_search, bidi_cache_iterator_state)
6466 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6467 (bidi_level_of_next_char, bidi_move_to_visually_next):
6468 Support character positions inside a run of characters covered by a
fec2107c
EZ
6469 display string.
6470 (bidi_paragraph_init, bidi_resolve_explicit_1)
6471 (bidi_level_of_next_char): Call bidi_fetch_char and
6472 bidi_fetch_char_advance instead of FETCH_CHAR and
6473 FETCH_CHAR_ADVANCE.
6474 (bidi_init_it): Initialize new members.
6475 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6476 definitions.
6477 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6478 instead of using explicit *_CHAR codes.
d6d100dd
SM
6479 (bidi_resolve_explicit, bidi_resolve_weak):
6480 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6481 bidirectional text is supported only in multibyte buffers.
6482 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6483 it to initialize the frame_window_p member of struct bidi_it.
6484 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6485 (bidi_resolve_explicit, bidi_resolve_weak)
6486 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6487 bidi_it->nchars is non-positive.
6488 (bidi_level_of_next_char): Don't try to lookup the cache for the
6489 next/previous character if nothing is cached there yet, or if we
6490 were just reseat()'ed to a new position.
c40e2fb2 6491
0e14fe90
EZ
6492 * xdisp.c (set_cursor_from_row): Set start and stop points
6493 according to the row's direction when priming the loop that looks
6494 for the glyph on which to display cursor.
6495 (single_display_spec_intangible_p): Function deleted.
6496 (display_prop_intangible_p): Reimplement to call
6497 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6498 Accept 3 additional arguments needed by handle_display_spec.
6499 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6500 values: lists, `(when COND...)' forms, etc.
6501 (single_display_spec_string_p): Support property values that are
6502 lists with the argument STRING its top-level element.
6503 (display_prop_string_p): Fix the condition for processing a
6504 property that is a list to be consistent with handle_display_spec.
fec2107c 6505 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6506 last portion of handle_display_prop.
6507 (compute_display_string_pos): Accept additional argument
6508 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6509 value of a `display' property is a "replacing spec".
6510 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6511 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6512 the display property, but just return a value indicating whether
6513 the display property will replace the characters it covers.
6514 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6515 frame_window_p members of struct bidi_it.
d6d100dd
SM
6516 (compute_display_string_pos, compute_display_string_end):
6517 New functions.
fec2107c
EZ
6518 (push_it): Accept second argument POSITION, where pop_it should
6519 jump to continue iteration.
6520 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6521
fec2107c
EZ
6522 * keyboard.c (adjust_point_for_property): Adjust the call to
6523 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6524
6525 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6526 (bidi_init_it): Update prototypes.
6527 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6528 (compute_display_string_pos, compute_display_string_end):
6529 Declare prototypes.
fec2107c
EZ
6530 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6531 EMACS_INT.
fc6f18ce 6532
40087514 65332011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6534
57f53182
PE
6535 Malloc failure behavior now depends on size of allocation.
6536 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6537 * lisp.h: Change signatures accordingly.
6538 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6539 All callers changed. (Bug#8762)
6540
6541 * gnutls.c: Use Emacs's memory allocators.
6542 Without this change, the gnutls library would invoke malloc etc.
6543 directly, which causes problems on non-SYNC_INPUT hosts, and which
6544 runs afoul of improving memory_full behavior. (Bug#8761)
6545 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6546 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6547 xfree instead of the default malloc, realloc, free.
6548 (Fgnutls_boot): No need to check for memory allocation failure,
6549 since xmalloc does that for us.
6550
ac32cd99 6551 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6552 * category.c (hash_get_category_set):
6553 * ccl.c (ccl_driver):
6554 * charset.c (Fdefine_charset_internal):
6555 * charset.h (struct charset.hash_index):
6556 * composite.c (get_composition_id, gstring_lookup_cache)
6557 (composition_gstring_put_cache):
6558 * composite.h (struct composition.hash_index):
6559 * dispextern.h (struct image.hash):
6560 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6561 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6562 (hashfn_equal, hashfn_user_defined, make_hash_table)
6563 (maybe_resize_hash_table, hash_lookup, hash_put)
6564 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6565 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6566 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6567 * image.c (make_image, search_image_cache, lookup_image)
6568 (xpm_put_color_table_h):
6569 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6570 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6571 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6572 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6573 * alloc.c (allocate_vectorlike):
6574 Check for overflow in vector size calculations.
6575 * ccl.c (ccl_driver):
6576 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6577 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6578 need to be updated by these changes.
40087514
PE
6579 * fns.c (make_hash_table, maybe_resize_hash_table):
6580 Check for integer overflow with large hash tables.
0de4bb68
PE
6581 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6582 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6583 (SXHASH_REDUCE): New macro.
6584 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6585 Use it instead of discarding useful hash info with large hash values.
6586 (sxhash_float): New function.
6587 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6588 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6589 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6590 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6591 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6592 Adjust signatures to match updated version of code.
6593 (consing_since_gc): Now EMACS_INT, since a single hash table can
6594 use more than INT_MAX bytes.
6595
698d32e2
DN
65962011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6597
6598 Make it possible to build with GCC-4.6+ -O2 -flto.
6599
6600 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6601
fd6fa53f
SM
66022011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6603
6604 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6605 Call minibuffer-inactive-mode.
6606
864db017
JB
66072011-05-31 Juanma Barranquero <lekktu@gmail.com>
6608
6609 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6610 Update dependencies.
6611
2ad0baf4
DN
66122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6613
6614 * data.c (init_data): Remove code for UTS, this system is not
6615 supported anymore.
6616
4fcc2638
DN
66172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6618
6619 Don't force ./temacs to start in terminal mode.
6620
6621 * frame.c (make_initial_frame): Initialize faces in all cases, not
6622 only when CANNOT_DUMP is defined.
6623 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6624
c56e0fd5
DN
66252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6626
6627 * dispnew.c (add_window_display_history): Use const for the string
6628 pointer. Remove declaration, not needed.
6629
333d54da 66302011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6631
55d4c1b2 6632 Use 'inline', not 'INLINE'.
333d54da 6633 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6634 * alloc.c, fontset.c (INLINE): Remove.
6635 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6636 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6637 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6638 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6639 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6640
738db178
DN
66412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6642
6643 Make it possible to run ./temacs.
6644
6645 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6646 syms_of_callproc does the same thing. Remove test for
6647 "initialized", do it in the caller.
6648 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6649
620c53a6
SM
66502011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6651
6652 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6653 (read_minibuf): Use get_minibuffer.
6654 (syms_of_minibuf): Use DEFSYM.
6655 (Qmetadata): New var.
6656 * data.c (Qbuffer): Don't make it static.
6657 (syms_of_data): Use DEFSYM.
6658
e003a292
PE
66592011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6660
6661 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6662 (CCL_CODE_MIN): New macro.
6663
ed008a6d
PE
66642011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6665
3687c2ef
PE
6666 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6667
ed008a6d
PE
6668 * eval.c (Qdebug): Now static.
6669 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6670 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6671 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6672
d66c4c7c
CY
66732011-05-29 Chong Yidong <cyd@stupidchicken.com>
6674
6675 * image.c: Various fixes to ImageMagick code comments.
6676 (Fimagemagick_types): Doc fix.
6677
5fbc2025
PE
66782011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6679
0196f88a
PE
6680 Minor fixes prompted by GCC 4.6.0 warnings.
6681
6682 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6683
5fbc2025
PE
6684 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6685 (x_clipboard_manager_save_all): Move extern decl to ...
6686 * xterm.h: ... here, so that it can be checked for consistency.
6687
1dd3c2d9
CY
66882011-05-29 Chong Yidong <cyd@stupidchicken.com>
6689
6690 * xselect.c (x_clipboard_manager_save_frame)
6691 (x_clipboard_manager_save_all): New functions.
6692 (Fx_clipboard_manager_save): Lisp function deleted.
6693
6694 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6695 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6696
6697 * xterm.h: Update prototype.
6698
5ba6571d
WX
66992011-05-28 William Xu <william.xwl@gmail.com>
6700
6701 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6702 exiting (Bug#8239).
6703
3eaff834
JM
67042011-05-28 Jim Meyering <meyering@redhat.com>
6705
e1900994 6706 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6707 * fns.c (to_uchar): Define.
6708 (crypto_hash_function): Use it to convert some newly-signed
6709 variables to unsigned, to avoid sign-extension bugs. For example,
6710 without this change, (md5 "truc") would evaluate to
6711 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6712 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6713 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6714
0f6990a7
PE
67152011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6716
6717 Integer overflow fixes.
c8a9ca5a 6718
08686060
PE
6719 * dbusbind.c: Serial number integer overflow fixes.
6720 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6721 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6722 to hold a serial number that is too large for a fixnum.
6723 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6724 Check for serial numbers out of range. Decode any serial number
59568bf0 6725 that was so large that it became a float. (Bug#8722)
08686060 6726
2d1fc3c7
PE
6727 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6728 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6729 Use XFASTINT rather than XUINT when numbers are nonnegative.
6730 (xd_append_arg, Fdbus_method_return_internal):
6731 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6732 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6733 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6734 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6735 (Bug#8722)
2d1fc3c7 6736
c8a9ca5a
PE
6737 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6738
519e1d69
PE
6739 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6740
6df6ae42 6741 ccl: Add integer overflow checks.
30569699
PE
6742 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6743 (IN_INT_RANGE): New macros.
6744 (ccl_driver): Use them to check for integer overflow when
6745 decoding a CCL program. Many of the new checks are whether XINT (x)
6746 fits in int; it doesn't always, on 64-bit hosts. The new version
6747 doesn't catch all possible integer overflows, but it's an
847044ea 6748 improvement. (Bug#8719)
30569699 6749
c11285dc
PE
6750 * alloc.c (make_event_array): Use XINT, not XUINT.
6751 There's no need for unsigned here.
6752
fdccd48e
PE
6753 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6754 This follows up to the 2011-05-06 change that substituted uintptr_t
6755 for EMACS_INT. This case wasn't caught back then.
6756
37910ab2
PE
6757 Rework Fformat to avoid integer overflow issues.
6758 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6759 now (part of C89). Include <verify.h>.
6760 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6761 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6762 (Fformat): Avoid the prepass trying to compute sizes; it was only
6763 approximate and thus did not catch overflow reliably. Instead, walk
6764 through the format just once, formatting and computing sizes as we go,
6765 checking for integer overflow at every step, and allocating a larger
6766 buffer as needed. Keep track separately whether the format is
6767 multibyte. Keep only the most-recently calculated precision, rather
6768 than them all. Record whether each argument has been converted to
6769 string. Use EMACS_INT, not int, for byte and char and arg counts.
6770 Support field widths and precisions larger than INT_MAX. Avoid
6771 sprintf's undefined behavior with conversion specifications such as %#d
6772 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6773 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6774 formatting out-of-range floating point numbers with int
9173deec 6775 formats. (Bug#8668)
37910ab2 6776
2e6578fb
PE
6777 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6778
0ae6bdee
PE
6779 * data.c: Avoid integer truncation in expressions involving floats.
6780 * data.c: Include <intprops.h>.
6781 (arith_driver): When there's an integer overflow in an expression
6782 involving floating point, convert the integers to floating point
6783 so that the resulting value does not suffer from catastrophic
6784 integer truncation. For example, on a 64-bit host (* 4
6785 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6786 Do not rely on undefined behavior after integer overflow.
6787
de883a70
PE
6788 merge count_size_as_multibyte, parse_str_to_multibyte
6789 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6790 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6791 Check for integer overflow.
6792 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6793 since it's now a duplicate of the other. This is more of
6794 a character than a buffer op, so better that it's in character.c.
6795 * fns.c, print.c: Adjust to above changes.
6796
2ff916cb
PE
67972011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6798
6799 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6800
f1b54466
PE
68012011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6802
fb1ac845
PE
6803 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6804 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6805 (x_clipboard_manager_save): Now static.
6806 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6807
f1b54466
PE
6808 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6809 (crypto_hash_function): Now static.
6810 Fix pointer signedness problems. Avoid unnecessary initializations.
6811
a9f737ee
CY
68122011-05-27 Chong Yidong <cyd@stupidchicken.com>
6813
6814 * termhooks.h (Vselection_alist): Make it terminal-local.
6815
6816 * terminal.c (create_terminal): Initialize it.
6817
6818 * xselect.c: Support for clipboard managers.
6819 (Vselection_alist): Move to termhooks.h as terminal-local var.
6820 (LOCAL_SELECTION): New macro.
6821 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6822 (symbol_to_x_atom): Remove gratuitous arg.
6823 (x_handle_selection_request, lisp_data_to_selection_data)
6824 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6825 (x_own_selection, x_get_local_selection, x_convert_selection):
6826 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6827 (some_frame_on_display): Delete unused function.
6828 (Fx_own_selection_internal, Fx_get_selection_internal)
6829 (Fx_disown_selection_internal, Fx_selection_owner_p)
6830 (Fx_selection_exists_p): New optional frame arg.
6831 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6832 (x_handle_selection_clear): Don't treat other terminals with the
6833 same keyboard specially. Use the terminal-local Vselection_alist.
6834 (x_clear_frame_selections): Use Frun_hook_with_args.
6835
6836 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6837
6838 * xterm.h: Add support for those atoms.
6839
e067f0c1
CY
68402011-05-26 Chong Yidong <cyd@stupidchicken.com>
6841
6842 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6843 (converted_selections, conversion_fail_tag): New global variables.
6844 (x_selection_request_lisp_error): Free the above.
6845 (x_get_local_selection): Remove unnecessary code.
6846 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6847 of converted selections stored in converted_selections.
6848 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6849 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6850 (x_convert_selection): New function.
6851 (x_handle_selection_event): Simplify.
6852 (x_get_foreign_selection): Don't ignore incoming requests while
6853 waiting for an answer; this will fail when we implement
6854 SAVE_TARGETS, and seems unnecessary anyway.
6855 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6856 (Vx_sent_selection_functions): Doc fix.
6857
0f4aebc0
LL
68582011-05-26 Leo Liu <sdl.web@gmail.com>
6859
6860 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6861
e61124cd
YM
68622011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6863
6864 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6865
6866 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6867 for fringe update if it has periodic bitmap.
ac389d0c 6868 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6869 and fringe_bitmap_periodic_p.
6870
6871 * fringe.c (get_fringe_bitmap_data): New function.
6872 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6873 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6874 row. Mark glyph row for fringe update if periodicity changed.
6875
6876 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6877 for fringe update unless it has periodic bitmap.
6878
f16d9837
KH
68792011-05-25 Kenichi Handa <handa@m17n.org>
6880
6881 * xdisp.c (get_next_display_element): Set correct it->face_id for
6882 a static composition.
6883
e1b90ef6
LL
68842011-05-24 Leo Liu <sdl.web@gmail.com>
6885
6886 * deps.mk (fns.o):
6887 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6888
6889 * fns.c (crypto_hash_function, Fsha1): New function.
6890 (Fmd5): Use crypto_hash_function.
6891 (syms_of_fns): Add Ssha1.
6892
7400048f
PE
68932011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6894
6895 * gnutls.c: Remove unused macros.
6896 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6897 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6898 Remove macros that are defined and never used.
6899 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6900
abb71cf4
CY
69012011-05-22 Chong Yidong <cyd@stupidchicken.com>
6902
6903 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6904 (Fx_get_selection_internal): Minor cleanup.
6905 (Fx_own_selection_internal): Rename arguments for consistency with
6906 select.el.
6907
6307db39
PE
69082011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6909
6910 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6911
f3d4e0a4
CY
69122011-05-22 Chong Yidong <cyd@stupidchicken.com>
6913
6914 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6915
4d8ade89
YM
69162011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6917
6918 * dispnew.c (scrolling_window): Don't exclude the case that the
6919 last enabled row in the desired matrix touches the bottom boundary.
6920
32078c8d
GM
69212011-05-21 Glenn Morris <rgm@gnu.org>
6922
6923 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6924 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6925 and add some more files.
32078c8d 6926
7285dc67
EZ
69272011-05-20 Eli Zaretskii <eliz@gnu.org>
6928
6929 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6930 report_file_error introduced by the change from 2011-05-07.
6931
89d1bd22
PE
69322011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6933
6934 * systime.h (Time): Define only if emacs is defined.
6935 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6936 where the include path doesn't have X11/X.h by default. See
6937 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6938
cd394be1 69392011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6940
6941 * composite.c (find_automatic_composition): Fix previous change.
6942
b9704ad9
GM
69432011-05-20 Glenn Morris <rgm@gnu.org>
6944
6945 * lisp.mk: New file, split from Makefile.in.
6946 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6947 (shortlisp): Remove.
6948 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6949
4a720484
GM
69502011-05-19 Glenn Morris <rgm@gnu.org>
6951
6952 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6953 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6954 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6955 (lisp): Set the order to that of loadup.el.
6956 (shortlisp): Make it a copy of $lisp.
6957 (SOME_MACHINE_LISP): Remove.
6958 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6959 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6960
a28d4396
KH
69612011-05-18 Kenichi Handa <handa@m17n.org>
6962
6963 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6964 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6965 (find_automatic_composition): Mostly rewrite for efficiency.
6966
a2b1fa8e
JB
69672011-05-18 Juanma Barranquero <lekktu@gmail.com>
6968
6969 * makefile.w32-in: Update dependencies.
6970
8e1f5610
CS
69712011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6972
6973 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6974 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6975
7025ee00 69762011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6977
cdfa6eab
PE
6978 Fix some integer overflow issues, such as string length overflow.
6979
06d6db33
PE
6980 * insdel.c (count_size_as_multibyte): Check for string overflow.
6981
2b4560a8
PE
6982 * character.c (lisp_string_width): Check for string overflow.
6983 Use EMACS_INT, not int, for string indexes and lengths; in
6984 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6985 the resulting string length overflows an EMACS_INT; instead,
6986 report a string overflow if no precision given. When checking for
6987 precision exhaustion, use a check that cannot possibly have
6988 integer overflow. (Bug#8675)
6989 * character.h (lisp_string_width): Adjust to new signature.
6990
cb93f9be
PE
6991 * alloc.c (string_overflow): New function.
6992 (Fmake_string): Use it. This doesn't change behavior, but saves
6993 a few bytes and will simplify future changes.
6994 * character.c (string_escape_byte8): Likewise.
6995 * lisp.h (string_overflow): New decl.
6996
1a1f3366
PE
6997 Fixups, following up to the user-interface timestamp change.
6998 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6999 for UI timestamps, instead of unsigned long.
9fbd6841
PE
7000 * msdos.c (mouse_get_pos): Likewise.
7001 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
7002 * w32gui.h (Time): Define by including "systime.h" rather than by
7003 declaring it ourselves. (Bug#8664)
7004
d4e3e4d3
PE
7005 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7006 * image.c (clear_image_cache): Likewise.
7007
f6a24d19
PE
7008 * term.c (term_mouse_position): Don't assume time_t wraparound.
7009
08dc5ae6
PE
7010 Be more systematic about user-interface timestamps.
7011 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
7012 and sometimes 'EMACS_UINT', to represent these timestamps.
7013 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
7014 This makes the code easier to follow, and makes it easier to catch
7015 integer overflow bugs such as Bug#8664.
7016 * frame.c (Fmouse_position, Fmouse_pixel_position):
7017 Use Time, not unsigned long, for user-interface timestamps.
7018 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7019 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7020 * keyboard.h (last_event_timestamp): Likewise.
7021 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7022 * menu.h (xmenu_show): Likewise.
7023 * term.c (term_mouse_position): Likewise.
7024 * termhooks.h (struct input_event.timestamp): Likewise.
7025 (struct terminal.mouse_position_hook): Likewise.
7026 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7027 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7028 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7029 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7030 what it was before.
7031 * menu.h, termhooks.h: Include "systime.h", for Time.
7032
8e55734a
PE
7033 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7034 Don't assume that the difference between two unsigned long values
7035 can fit into an integer. At this point, we know button_down_time
7036 <= event->timestamp, so the difference must be nonnegative, so
7037 there's no need to cast the result if double-click-time is
7038 nonnegative, as it should be; check that it's nonnegative, just in
7039 case. This bug is triggered when events are more than 2**31 ms
86db42d2 7040 apart (about 25 days). (Bug#8664)
8e55734a 7041
841f1b75 7042 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 7043 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 7044
3e26f69c
PE
7045 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7046 that always fit in int. Use a sentinel instead of a counter, to
7047 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
7048 * frame.h (struct frame): Use int for menu_bar_items_used
7049 instead of EMACS_INT, since it always fits in int.
3e26f69c 7050
5cc152c0
PE
7051 * menu.c (grow_menu_items): Check for int overflow.
7052
d89eb65e
PE
7053 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7054
5235bd3e
PE
7055 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7056 Before, the code was not consistent. These values cannot exceed
7057 2**31 - 1 so there's no need to make them unsigned.
7058 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7059 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7060 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7061 as modifiers.
7062 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7063
bc827e23
PE
7064 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7065 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7066 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7067 presumably because the widths might not match.
7068
78eb494e
PE
7069 * window.c (size_window): Avoid needless test at loop start.
7070
04f2d78b
CB
70712011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7072
7073 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7074
d2fc7e3d 70752011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
7076
7077 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7078
d2fc7e3d 70792011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
7080
7081 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7082 `width' to `bar_area_x' and `bar_area_width', respectively.
7083 (x_scroll_run): Take account of fringe background extension.
7084
04f2d78b
CB
7085 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7086 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
7087 `bar_area_width', respectively.
7088 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7089 background extension.
7090
79b70037
GM
70912011-05-10 Jim Meyering <meyering@redhat.com>
7092
7093 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7094
2f142cc5
JB
70952011-05-10 Juanma Barranquero <lekktu@gmail.com>
7096
7097 * image.c (Finit_image_library): Return t for built-in image types,
7098 like pbm and xbm. (Bug#8640)
7099
57679c86
AS
71002011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7101
7102 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7103
888c9e86
EZ
71042011-05-07 Eli Zaretskii <eliz@gnu.org>
7105
b0512a1d
EZ
7106 * w32console.c (Fset_screen_color): Doc fix.
7107 (Fget_screen_color): New function.
7108 (syms_of_ntterm): Defsubr it.
7109
7285dc67
EZ
7110 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7111 unlink the temporary file if Fcall_process didn't create it in the
7112 first place.
7113 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7114 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
7115 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7116 cue to call_process_cleanup not to close that handle.
7117
4d3fcc8e
BK
71182011-05-07 Ben Key <bkey76@gmail.com>
7119
7120 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7121 one of two shell specific rules, either bootstrap-temacs-CMD or
7122 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7123 to the previous implementation of the bootstrap-temacs rule.
7124 The bootstrap-temacs-CMD rule is similar to the previous
7125 implementation of the bootstrap-temacs rule except that it
7126 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7127 variable.
7128
7129 These changes, along with some changes to nt/configure.bat,
7130 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7131 earlier fix to add support for --cflags and --ldflags options
7132 that include quotes so that it works whether make uses cmd or
7133 sh as the shell.
7134
b4289b64
MA
71352011-05-06 Michael Albinus <michael.albinus@gmx.de>
7136
7137 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7138 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7139 is a constant.
7140 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7141 a string. Handle both cases.
7142 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7143 (Fdbus_register_method): Use Qinvalid_function.
7144
af4c0e28
JB
71452011-05-06 Juanma Barranquero <lekktu@gmail.com>
7146
7147 * makefile.w32-in: Update dependencies.
7148 (LISP_H): Add inttypes.h and stdin.h.
7149 (PROCESS_H): Add unistd.h.
7150
c51453d9
EZ
71512011-05-06 Eli Zaretskii <eliz@gnu.org>
7152
7153 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7154 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7155
8ff0ac3c 71562011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7157
4c4b566b
PE
7158 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7159
aab2b9b5
PE
7160 * term.c (vfatal): Remove stray call to va_end.
7161 It's not needed and the C Standard doesn't allow it here anyway.
7162
c378da0b
PE
7163 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7164 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7165
288b08c7
PE
7166 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7167 bytes.
7168
e3601888
PE
7169 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7170
db6c0e74
PE
7171 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7172
dd5963ea
PE
7173 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7174
88c9450f
PE
7175 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7176
2f9442b8
PE
7177 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7178
c032b5f8
PE
7179 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7180 * charset.c (Fdefine_charset_internal): Don't initialize
7181 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7182 32-bit int (Bug#8600).
a108c10b
PE
7183
7184 * lread.c (read_integer): Be more consistent with string-to-number.
7185 Use string_to_number to do the actual conversion; this avoids
7186 rounding errors and fixes some other screwups. Without this fix,
7187 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7188 (digit_to_number): Move earlier, for benefit of read_integer.
7189 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7190 not a digit in any supported base. (Bug#8602)
a108c10b 7191
ad5f9eea
PE
7192 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7193
aec1708a
PE
7194 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7195 to match comment at start of function. This also removes a
7196 GCC warning about overflow in a 32+64-bit port.
7197
47be4ab5
PE
7198 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7199
371cac43
PE
7200 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7201 Reported by Stefan Monnier in
7202 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7203 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7204 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7205
d01a7826
PE
7206 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7207 (EMACS_UINTPTR): Likewise, with uintptr_t.
7208
7fd47d5c
PE
7209 * lisp.h: Prefer 64-bit EMACS_INT if available.
7210 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7211 on 32-bit hosts that have 64-bit int, so that they can access
7212 large files.
122b0c86
PE
7213 However, temporarily disable this change unless the temporary
7214 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7215
8727937b
PE
7216 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7217
8ac068ac
PE
7218 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7219 This removes an assumption that EMACS_INT and long are the same
7220 width as pointers. The assumption is true for Emacs porting targets
7221 now, but we want to make other targets possible.
7222 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7223 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7224 In the rest of the code, change types of integers that hold casted
7225 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7226 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7227 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7228 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7229 No need to cast type when ORing.
7230 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7231 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7232 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7233 assume EMACS_INT is the same width as char *.
7234 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7235 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7236 Remove no-longer-needed casts.
7237 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7238 (xg_tool_bar_help_callback, xg_make_tool_item):
7239 Use EMACS_INTPTR to hold an integer
7240 that will be cast to void *; this can avoid a GCC warning
7241 if EMACS_INT is not the same width as void *.
7242 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7243 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7244 (current_message_1, set_message_1):
7245 Use a local to convert to proper width without a cast.
7246 * xmenu.c (dialog_selection_callback): Likewise.
7247
ede49d71
PE
7248 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7249 Also, don't assume VALBITS / RAND_BITS is less than 5,
7250 and don't rely on undefined behavior when shifting a 1 left into
7251 the sign bit.
7252 * lisp.h (get_random): Change signature to match.
7253
2f30ecd0
PE
7254 * lread.c (hash_string): Use size_t, not int, for hash computation.
7255 Normally we prefer signed values; but hashing is special, because
7256 it's better to use unsigned division on hash table sizes so that
7257 the remainder is nonnegative. Also, size_t is the natural width
7258 for hashing into memory. The previous code used 'int', which doesn't
7259 retain enough info to hash well into very large tables.
7260 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7261
2a866e7b
PE
7262 * dbusbind.c: Don't possibly lose pointer info when converting.
7263 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7264 Use XPNTR rather than XHASH, so that the high-order bits of
7265 the pointer aren't lost when converting through void *.
7266
51639eac
PE
7267 * eval.c (Fautoload): Don't double-shift a pointer.
7268
92394119
PE
7269 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7270
dbdb9a7c
JB
72712011-05-06 Juanma Barranquero <lekktu@gmail.com>
7272
7273 * gnutls.c (DEF_GNUTLS_FN):
7274 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7275
db7a0b4f
AS
72762011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7277
7278 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7279 marker. (Bug#8610)
7280
cd394be1 72812011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7282
7283 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7284 New version that can reserve upto 2GB of heap space.
7285
f7ff1b0f 72862011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7287
7288 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7289
639c109b
TZ
72902011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7291
7292 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7293 `gnutls_certificate_set_x509_key_file'.
7294
d2127135
JB
72952011-05-05 Juanma Barranquero <lekktu@gmail.com>
7296
7297 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7298 Update dependencies.
7299
e968f4f3
JB
73002011-05-04 Juanma Barranquero <lekktu@gmail.com>
7301
7302 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7303 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7304 Remove unused parameter `fildes'.
7305 * process.c (read_process_output, send_process): Don't pass it.
7306
84d358f0
JB
73072011-05-04 Juanma Barranquero <lekktu@gmail.com>
7308
7309 Fix previous change: the library cache is defined in w32.c.
7310 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7311 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7312
0898ca10
JB
73132011-05-04 Juanma Barranquero <lekktu@gmail.com>
7314
7315 Implement dynamic loading of GnuTLS on Windows.
7316
7317 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7318 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7319 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7320 Declare.
7321
7322 * gnutls.c (Qgnutls_dll): Define.
7323 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7324 (gnutls_*): Declare function pointers.
7325 (init_gnutls_functions): New function to initialize function pointers.
7326 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7327 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7328 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7329 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7330 (emacs_gnutls_write, emacs_gnutls_read)
7331 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7332 (Fgnutls_available_p): New function.
7333 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7334 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7335 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7336
7337 * image.c: Include w32.h.
7338 (Vimage_type_cache): Delete.
7339 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7340 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7341 (w32_delayed_load): Move to w32.c.
7342
7343 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7344
7345 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7346 (w32_delayed_load): Move from image.c. When loading a library, record
7347 its filename in the :loaded-from property of the library id.
7348 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7349 Initialize and staticpro them.
7350 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7351
7352 * process.c: Include lisp.h before w32.h, not after.
7353 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7354 instead of gnutls_record_check_pending.
7355
7356 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7357
ff4de4aa
TZ
73582011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7359
7360 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7361 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7362 as passed in.
7363
abe95abb
JD
73642011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7365
7366 * xterm.c (x_set_frame_alpha): Do not set property on anything
7367 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7368
e16e55d4
JB
73692011-05-02 Juanma Barranquero <lekktu@gmail.com>
7370
7371 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7372
bafcf6a5
JB
73732011-05-02 Juanma Barranquero <lekktu@gmail.com>
7374
7375 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7376 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7377 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7378 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7379 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7380 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7381 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7382 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7383 (Qgnutls_bootprop_callbacks_verify): Make static.
7384
e7a6747f
AS
73852011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7386
19ed11ba
AS
7387 * callproc.c: Indentation fixup.
7388
e7a6747f 7389 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7390 (wait_for_termination, interruptible_wait_for_termination):
7391 Move after wait_for_termination_1.
e7a6747f 7392
1ef14cb4
LMI
73932011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7394
7395 * sysdep.c (interruptible_wait_for_termination): New function
7396 which is like wait_for_termination, but allows keyboard
7397 interruptions.
7398
7399 * callproc.c (Fcall_process): Add (:file "file") as an option for
7400 the STDOUT buffer.
7401 (Fcall_process_region): Ditto.
7402
330d880c
EZ
74032011-04-30 Eli Zaretskii <eliz@gnu.org>
7404
8db90b73
EZ
7405 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7406 rather than `XVECTOR (FOO)->size'.
7407
330d880c
EZ
7408 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7409 inttypes.h, as a gnulib replacement is used if it not available in
7410 system headers.
7411
15cbd324
EZ
74122011-04-21 Eli Zaretskii <eliz@gnu.org>
7413
7414 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7415 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7416 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7417
7418 * coding.c (coding_alloc_by_realloc): Error out if destination
7419 will grow beyond MOST_POSITIVE_FIXNUM.
7420 (decode_coding_emacs_mule): Abort if there isn't enough place in
7421 charbuf for the composition carryover bytes. Reserve an extra
7422 space for up to 2 characters produced in a loop.
7423 (decode_coding_iso_2022): Abort if there isn't enough place in
7424 charbuf for the composition carryover bytes.
7425
74262011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7427
ae940cca
EZ
7428 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7429 aborting when %lld or %lll format is passed.
7430 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7431 %llo or %llx format is passed. (Bug#8545)
7432
03ab8921
EZ
7433 * window.c (window_scroll_line_based): Use a marker instead of
7434 simple variables to record original value of point. (Bug#7952)
7435
afda1437
EZ
7436 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7437 produced by %s or %c overflows available buffer space. (Bug#8545)
7438
f76dee0c
PE
74392011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7440
7441 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7442 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7443
fdc5744d
JB
74442011-04-28 Juanma Barranquero <lekktu@gmail.com>
7445
7446 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7447
638f053a
JB
74482011-04-28 Juanma Barranquero <lekktu@gmail.com>
7449
7450 * keyboard.c (Qdelayed_warnings_hook): Define.
7451 (command_loop_1): Run `delayed-warnings-hook'
7452 if Vdelayed_warnings_list is non-nil.
7453 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7454 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7455
d178f871
EZ
74562011-04-28 Eli Zaretskii <eliz@gnu.org>
7457
7458 * doprnt.c (doprnt): Don't return value smaller than the buffer
7459 size if the message was truncated. (Bug#8545).
7460
b124fd93
JB
74612011-04-28 Juanma Barranquero <lekktu@gmail.com>
7462
7463 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7464 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7465
e810457d
PE
74662011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7467
7468 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7469
ea51cceb
JB
74702011-04-27 Juanma Barranquero <lekktu@gmail.com>
7471
7472 * makefile.w32-in: Update dependencies.
7473
94dcfacf
EZ
74742011-04-27 Eli Zaretskii <eliz@gnu.org>
7475
7476 Improve `doprnt' and its usage. (Bug#8545)
7477 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7478 `format_end'. Remove support for %l as a conversion specifier.
7479 Don't use xrealloc. Improve diagnostics when the %l size modifier
7480 is used. Update the commentary.
7481
7482 * eval.c (verror): Simplify calculation of size_t.
7483
7484 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7485 messages.
7486
f61f41d7
PE
74872011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7488
7489 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7490 change.
7491
96fb4434
PE
74922011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7493
7494 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7495 This makes this file independent of the recent pseudovector change.
7496
671875da 74972011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7498
69e9b5a3
PE
7499 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7500
b5f869a7 7501 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7502 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7503 Remove unused local.
c8926152 7504 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7505
841a1577 7506 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7507 GCC 4.6.0 optimizes based on type-based alias analysis.
7508 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7509 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7510 != &v->size, and therefore "v->size = 1; b->size = 2; return
7511 v->size;" must therefore return 1. This assumption is incorrect
7512 for Emacs, since it type-puns struct Lisp_Vector * with many other
7513 types. To fix this problem, this patch adds a new type struct
f904488f 7514 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7515 and pseudovectors, and helps optimizing compilers not get fooled
7516 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7517 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7518 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7519 the size member.
eab3844f
PE
7520 (XSETPVECTYPE): Rewrite in terms of new macro.
7521 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7522 This is a bit clearer, and further avoids the possibility of
7523 undesirable aliasing.
7524 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7525 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7526 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7527 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7528 (ASIZE): Now uses header.size rather than size.
7529 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7530 to avoid the hassle of writing XVECTOR (foo)->header.size.
7531 (struct vectorlike_header): New type.
eab3844f
PE
7532 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7533 object, to help avoid aliasing.
7534 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7535 (SUBRP): Likewise, since Lisp_Subr is a special case.
7536 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7537 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7538 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7539 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7540 changed to be "header.size" and "header.next".
7541 * buffer.h (struct buffer): Likewise.
7542 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7543 * frame.h (struct frame): Likewise.
7544 * process.h (struct Lisp_Process): Likewise.
7545 * termhooks.h (struct terminal): Likewise.
7546 * window.c (struct save_window_data, struct saved_window): Likewise.
7547 * window.h (struct window): Likewise.
7548 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7549 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7550 * buffer.c (init_buffer_once): Likewise.
7551 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7552 special case.
7553 * process.c (Fformat_network_address): Use local var for size,
7554 for brevity.
7555
0df1eac5
PE
7556 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7557
847ab9d1 7558 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7559 * data.c (atof): Remove decl; no longer used or needed.
7560 (digit_to_number): Move to lread.c.
7561 (Fstring_to_number): Use new string_to_number function, to be
7562 consistent with how the Lisp reader treats infinities and NaNs.
7563 Do not assume that floating-point numbers represent EMACS_INT
7564 without losing information; this is not true on most 64-bit hosts.
7565 Avoid double-rounding errors, by insisting on integers when
7566 parsing non-base-10 numbers, as the documentation specifies.
7567 * lisp.h (string_to_number): New decl, replacing ...
7568 (isfloat_string): Remove.
bc0a5c13 7569 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7570 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7571 appears to have been a coding error. Similarly, do not accept
7572 strings like +-1e0 as floating point numbers. Do not report
7573 overflow for integer overflows unless the base is not 10 which
7574 means we have no simple and reliable way to continue.
7575 Break out the floating-point parsing into a new
7576 function string_to_number, so that Fstring_to_number parses
7577 floating point numbers consistently with the Lisp reader.
04f2d78b 7578 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7579 (E_CHAR, EXP_INT): Remove, replacing with ...
7580 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7581 (string_to_number): New function, replacing isfloat_string.
7582 This function checks for valid syntax and produces the resulting
7583 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7584 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7585 so that overflow for non-base-10 numbers is reported only when
7586 there's no portable and simple way to convert to floating point.
452f4150 7587
67769ffc
PE
7588 * textprop.c (set_text_properties_1): Rewrite for clarity,
7589 and to avoid GCC warning about integer overflow.
7590
c20db43f
PE
7591 * intervals.h (struct interval): Use EMACS_INT for members
7592 where EMACS_UINT might cause problems. See
7593 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7594 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7595 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7596 All uses changed.
37aa2f85
PE
7597 (offset_intervals): Tell GCC not to worry about length overflow
7598 when negating a negative length.
c20db43f 7599
2538aa2f
PE
7600 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7601 (overrun_check_free): Likewise.
7602
f2d3008d
PE
7603 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7604 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7605 word size.
7606
ec8df744
PE
7607 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7608 (gnutls_make_error): Rename local to avoid shadowing.
7609 (gnutls_emacs_global_deinit): ifdef out; not used.
7610 (Fgnutls_boot): Use const for pointer to readonly storage.
7611 Comment out unused local. Fix pointer signedness problems.
7612
640ee02d
PE
7613 * lread.c (openp): Don't stuff size_t into an 'int'.
7614 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7615 about possible signed overflow.
7616
6048fb2a
PE
7617 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7618 (GDK_KEY_g): Don't define if already defined.
7619 (xg_prepare_tooltip): Avoid pointer signedness problem.
7620 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7621
fa3c87e1
PE
7622 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7623 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7624
2172544b
PE
7625 * xfns.c (Fx_window_property): Simplify a bit,
7626 to make a bit faster and to avoid GCC 4.6.0 warning.
7627 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7628
9b821a21
PE
7629 * fns.c (internal_equal): Don't assume size_t fits in int.
7630
3c616cfa
PE
7631 * alloc.c (compact_small_strings): Tighten assertion a little.
7632
c2982e87
PE
7633 Replace pEd with more-general pI, and fix some printf arg casts.
7634 * lisp.h (pI): New macro, generalizing old pEd macro to other
7635 conversion specifiers. For example, use "...%"pI"d..." rather
7636 than "...%"pEd"...".
7637 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7638 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7639 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7640 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7641 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7642 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7643 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7644 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7645 64-bit hosts.
7646 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7647 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7648 * print.c (safe_debug_print, print_object): Likewise.
7649 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7650 to int.
6f04d126
PE
7651 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7652 avoiding the 0 flag, which is not portable.
c2982e87
PE
7653 * process.c (Fmake_network_process): Use pI to avoid cast.
7654 * region-cache.c (pp_cache): Likewise.
7655 * xdisp.c (decode_mode_spec): Likewise.
7656 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7657 behavior on 64-bit hosts with printf arg.
6f04d126 7658 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7659 (x_stop_queuing_selection_requests): Likewise.
7660 (x_get_window_property): Don't truncate byte count to an 'int'
7661 when tracing.
0b432f21 7662
5e073ec7
PE
7663 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7664 here, since it parses constructs like leading '-' and spaces,
7665 which are not wanted; and it overflows with large numbers.
7666 Instead, simply match F[0-9]+, which is what is wanted anyway.
7667
36372bf9
PE
7668 * alloc.c: Remove unportable assumptions about struct layout.
7669 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7670 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7671 (allocate_vectorlike, make_pure_vector): Use the new macros,
7672 plus offsetof, to remove unportable assumptions about struct layout.
7673 These assumptions hold on all porting targets that I know of, but
7674 they are not guaranteed, they're easy to remove, and removing them
7675 makes further changes easier.
7676
0b432f21
PE
7677 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7678 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7679 (string_overrun_cookie): Now const. Use initializers that
7680 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7681 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7682 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7683 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7684 multiple of sizeof (EMACS_INT); it need not be, if
7685 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7686 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7687
895009e1
JB
76882011-04-26 Juanma Barranquero <lekktu@gmail.com>
7689
7690 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7691
6a7a1b0b
TZ
76922011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7693
7694 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7695 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7696 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7697
841a1577 76982011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7699
7700 * lisp.h (Qdebug): List symbol.
895009e1 7701 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7702 * keyboard.c (debug-on-event): New variable.
7703 (handle_user_signal): Break into debugger when debug-on-event
7704 matches the current signal symbol.
7705
f2d3ba6f
DN
77062011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7707
7708 * alloc.c (check_sblock, check_string_bytes)
7709 (check_string_free_list): Convert to standard C.
7710
42ce4c63
TZ
77112011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7712
7713 * w32.c (emacs_gnutls_push): Fix typo.
7714
825cd63c
EZ
77152011-04-25 Eli Zaretskii <eliz@gnu.org>
7716
fb11d64d
EZ
7717 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7718 "cast to pointer from integer of different size".
7719
825cd63c
EZ
7720 Improve doprnt and its use in verror. (Bug#8545)
7721 * doprnt.c (doprnt): Document the set of format control sequences
7722 supported by the function. Use SAFE_ALLOCA instead of always
7723 using `alloca'.
7724
7725 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7726 is one byte too soon. Don't use xrealloc; instead xfree and
7727 xmalloc anew.
7728
e061a11b
TZ
77292011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7730
7731 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7732 callbacks stage.
7733
7734 * gnutls.c: Renamed global_initialized to
7735 gnutls_global_initialized. Added internals for the
7736 :verify-hostname-error, :verify-error, and :verify-flags
7737 parameters of `gnutls-boot' and documented those parameters in the
7738 docstring. Start callback support.
9173deec
JB
7739 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7740 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7741 on error. Return error code.
e061a11b
TZ
7742 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7743 (emacs_gnutls_read): Likewise.
7744 (Fgnutls_boot): Return handshake error code.
7745 (emacs_gnutls_handle_error): New function.
7746 (wsaerror_to_errno): Likewise.
7747
7748 * w32.h (emacs_gnutls_pull): Add prototype.
7749 (emacs_gnutls_push): Likewise.
7750
7751 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7752 (emacs_gnutls_push): Likewise.
7753
77542011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7755
7756 * process.c (wait_reading_process_output): Check if GnuTLS
7757 buffered some data internally if no FDs are set for TLS
7758 connections.
7759
7760 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7761 (LIBS): Link to USER_LIBS.
7762 ($(BLD)/gnutls.$(0)): New target.
7763
fa6996bc
EZ
77642011-04-24 Eli Zaretskii <eliz@gnu.org>
7765
eb35682e
EZ
7766 * xdisp.c (handle_single_display_spec): Rename the
7767 display_replaced_before_p argument into display_replaced_p, to
7768 make it consistent with the commentary. Fix typos in the
7769 commentary.
7770
e2ad650c
EZ
7771 * textprop.c (syms_of_textprop): Remove dead code.
7772 (copy_text_properties): Delete obsolete commentary about an
7773 interface that was deleted long ago. Fix typos in the description
7774 of arguments.
7775
1b2de274
EZ
7776 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7777 to changes in oldXMenu/XMenu.h from 2011-04-16.
7778 <menu_help_message, prev_menu_help_message>: Constify.
7779 (IT_menu_make_room): menu->help_text is now `const char **';
7780 adjust.
7781
7782 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7783 to changes in oldXMenu/XMenu.h from 2011-04-16.
7784 (struct XMenu): Declare `help_text' `const char **'.
7785
7786 * xfaces.c <Qunspecified>: Make extern again.
7787
7788 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7789 required by POSIX.
1b2de274 7790
762b15be
EZ
7791 * doc.c (get_doc_string): Improve the format passed to `error'.
7792
7793 * doprnt.c (doprnt): Improve commentary.
7794
7795 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7796
7797 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7798 them with etags.
7799
f1052e5d
EZ
7800 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7801 changes in globals.h immediately force recompilation.
762b15be
EZ
7802 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7803 $(CURDIR)/s/ms-w32.h.
7804 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7805
fa6996bc
EZ
7806 * character.c (Fchar_direction): Function deleted.
7807 (syms_of_character): Don't defsubr it.
7808 <char-direction-table>: Deleted.
7809
e6c3da20
EZ
78102011-04-23 Eli Zaretskii <eliz@gnu.org>
7811
7812 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7813 * doprnt.c: Include limits.h.
7814 (SIZE_MAX): New macro.
04f2d78b
CB
7815 (doprnt): Return a size_t value. 2nd arg is now size_t.
7816 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7817 Improve overflow protection. Support `l' modifier for integer
7818 conversions. Support %l conversion. Don't assume an EMACS_INT
7819 argument for integer conversions and for %c.
7820
7821 * lisp.h (doprnt): Restore prototype.
7822
7823 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7824 $(SRC)/character.h.
7825
7826 * Makefile.in (base_obj): Add back doprnt.o.
7827
7828 * deps.mk (doprnt.o): Add back prerequisites.
7829 (callint.o): Depend on character.h.
7830
7831 * eval.c (internal_lisp_condition_case): Include the handler
7832 representation in the error message.
7833 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7834 when breaking from the loop.
7835
7836 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7837
7838 * callint.c (Fcall_interactively): When displaying error message
7839 about invalid control letter, pass the character's codepoint, not
7840 a pointer to its multibyte form. Improve display of the character
7841 in octal and display also its hex code.
7842
7843 * character.c (char_string): Use %x to display the (unsigned)
7844 codepoint of an invalid character, to avoid displaying a bogus
7845 negative value.
7846
7847 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7848 `error', not SYMBOL_NAME itself.
7849
7850 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7851 character arguments to `error'.
7852
7853 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7854 to `error' in error message about FINAL_CHAR argument. Make sure
7855 FINAL_CHAR is a character, and use %c when it is passed as
7856 argument to `error'.
7857
4ffd0d6b 78582011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7859
7860 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7861
7862 * w32.c: Include <time.h>.
7863 (sys_localtime): New function.
7864
4ffd0d6b 78652011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7866
7867 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7868
4ffd0d6b 7869 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7870
4ffd0d6b 78712011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7872
4ffd0d6b
GM
7873 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7874 zombies (Bug#8467).
aac0c6e3 7875
04c56954
EZ
78762011-04-19 Eli Zaretskii <eliz@gnu.org>
7877
7878 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7879 gl_state.e_property when gl_state.object is Qt.
7880
7881 * insdel.c (make_gap_larger): Remove limitation of buffer size
7882 to <= INT_MAX.
7883
16a43933
CY
78842011-04-18 Chong Yidong <cyd@stupidchicken.com>
7885
7886 * xdisp.c (lookup_glyphless_char_display)
7887 (produce_glyphless_glyph): Handle cons cell entry in
7888 glyphless-char-display.
7889 (Vglyphless_char_display): Document it.
7890
7891 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7892 glyphless-char-display.
7893
4581706e
CY
78942011-04-17 Chong Yidong <cyd@stupidchicken.com>
7895
7896 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7897
7898 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7899
7900 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7901 definition for no-X builds.
7902
4887c6e2 79032011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7904
fd35b6f9
PE
7905 Static checks with GCC 4.6.0 and non-default toolkits.
7906
5c1ccb01
PE
7907 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7908
006c5daa
PE
7909 * process.c (keyboard_bit_set): Define only if SIGIO.
7910 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7911 (send_process): Repair possible setjmp clobbering.
7912
efc736d3
PE
7913 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7914
4e2fe2e6
PE
7915 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7916
f97334a2
PE
7917 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7918
4e75f29d
PE
7919 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7920 Define only if needed.
7921
90efadd1
PE
7922 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7923 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7924 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7925
3c647824
PE
7926 * dispextern.h (struct redisplay_interface): Rename param
7927 to avoid shadowing.
e264f262 7928 * termhooks.h (struct terminal): Likewise.
761383f4 7929 * xterm.c (xembed_send_message): Likewise.
3c647824 7930
b58c5c4a
PE
7931 * insdel.c (make_gap_smaller): Define only if
7932 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7933
cad59032
PE
7934 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7935 it.
7936
c339dc2e
PE
7937 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7938 so that we aren't warned about unused symbols.
7939
91a3e27b
PE
7940 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7941
399c71d3 7942 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7943
8ffc96f5
PE
7944 * xfns.c (x_real_positions): Mark locals as initialized.
7945
eef9bc79
PE
7946 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7947
098db9dd
PE
7948 * xterm.c: Fix problems found by static analysis with other toolkits.
7949 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7950 (x_dispatch_event): Declare static if USE_GTK, and
7951 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7952 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7953 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7954 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7955 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7956
eb18f6cc
PE
7957 * xmenu.c (menu_help_callback): Pointer type fixes.
7958 Use const pointers when pointing at readonly data. Avoid pointer
7959 signedness clashes.
7960 (FALSE): Remove unused macro.
7961 (update_frame_menubar): Remove unused decl.
7962
1fe72bf8
PE
7963 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7964
60d9e1db
PE
7965 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7966 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7967 (single_menu_item): Rename local to avoid shadowing.
7968
39261c26
PE
7969 * keyboard.c (make_lispy_event): Remove unused local var.
7970
018c5e19
PE
7971 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7972 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7973
63d2b86e
PE
7974 * bitmaps: Change bitmaps from unsigned char back to the X11
7975 compatible char. Avoid the old compiler warnings about
7976 out-of-range initializers by using, for example, '\xab' rather
7977 than 0xab.
7978
aefd87e1
PE
7979 * xgselect.c (xgselect_initialize): Check vs interface
7980 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7981
bf501fb9
PE
7982 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7983
e9829fdf
PE
7984 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7985 to read-only memory.
7986
1086c095
PE
7987 * fns.c (vector): Remove; this old hack is no longer needed.
7988
2baccd04 7989 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7990 Remove unused var.
dde42981 7991 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7992
72391843 7993 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7994
436c16df 7995 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7996 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7997 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7998
92bb796d 7999 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 8000 (x_term_init): Remove local to avoid shadowing.
92bb796d 8001
764430a3 8002 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
8003
8004 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8005 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8006
d1dfb56c
EZ
80072011-04-16 Eli Zaretskii <eliz@gnu.org>
8008
c4354cb4
EZ
8009 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8010
d1dfb56c
EZ
8011 Fix regex.c, syntax.c and friends for buffers > 2GB.
8012 * syntax.h (struct gl_state_s): Declare character position members
8013 EMACS_INT.
8014
8015 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8016
04f2d78b
CB
8017 * textprop.c (verify_interval_modification, interval_of):
8018 Declare arguments EMACS_INT.
d1dfb56c
EZ
8019
8020 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8021 EMACS_INT.
8022
8023 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8024
8025 * indent.c (Fvertical_motion): Local variable it_start is now
8026 EMACS_INT.
8027
8028 * regex.c (re_match, re_match_2, re_match_2_internal)
8029 (bcmp_translate, regcomp, regexec, print_double_string)
8030 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8031 (re_compile_pattern, re_exec): Declare arguments and local
8032 variables `size_t' and `ssize_t' and return values `regoff_t', as
8033 appropriate.
8034 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8035 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8036 <compile_stack_type>: `size' and `avail' are now `size_t'.
8037
8038 * regex.h <regoff_t>: Use ssize_t, not int.
8039 (re_search, re_search_2, re_match, re_match_2): Arguments that
8040 specify buffer/string position and length are now ssize_t and
8041 size_t. Return type is regoff_t.
8042
613052cd
BK
80432011-04-16 Ben Key <bkey76@gmail.com>
8044
8045 * nsfont.m: Fixed bugs in ns_get_family and
8046 ns_descriptor_to_entity that were caused by using free to
8047 deallocate memory blocks that were allocated by xmalloc (via
8048 xstrdup). This caused Emacs to crash when compiled with
8049 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8050 --enable-checking=xmallocoverrun). xfree is now used to
8051 deallocate these memory blocks.
8052
4170f62f 80532011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 8054
71b41406
PE
8055 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8056
9587a89d
PE
8057 emacs_write: Accept and return EMACS_INT for sizes.
8058 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8059 et seq.
8060 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8061 Accept and return EMACS_INT.
8062 (emacs_gnutls_write): Return the number of bytes written on
8063 partial writes.
8064 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
8065 (emacs_read, emacs_write): Remove check for negative size, as the
8066 Emacs source code has been audited now.
9587a89d
PE
8067 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8068 (emacs_read, emacs_write): Use it.
273a5f82
PE
8069 * process.c (send_process): Adjust to the new signatures of
8070 emacs_write and emacs_gnutls_write. Do not attempt to store
8071 a byte offset into an 'int'; it might overflow.
9587a89d 8072 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 8073
3e047f51
PE
8074 * sound.c: Don't assume sizes fit in 'int'.
8075 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 8076 Return EMACS_INT, not int.
3e047f51 8077 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
8078 Accept EMACS_INT, not int.
8079 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
8080 record read return values.
8081
cc39a9db
BK
80822011-04-15 Ben Key <bkey76@gmail.com>
8083
c9d0ec6d
JB
8084 * keyboard.c (Qundefined): Don't declare static since it is used
8085 in nsfns.m.
8086 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8087 static since they are used in nsfont.m.
cc39a9db 8088
6c60eb9f
SM
80892011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8090
8091 * process.c (Qprocessp): Don't declare static.
8092 * lisp.h (Qprocessp): Declare again.
8093
7990b61a
JB
80942011-04-15 Juanma Barranquero <lekktu@gmail.com>
8095
8096 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8097
5d4cb038
PE
80982011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8099
8bd7b830 8100 Improve C-level modularity by making more things 'static'.
cd64ea1d 8101
e3b27b31
PE
8102 Don't publish debugger-only interfaces to other modules.
8103 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8104 (verify_bytepos, count_markers): Move decls to the only modules
8105 that need them.
8106 * region-cache.h (pp_cache): Likewise.
8107 * window.h (check_all_windows): Likewise.
8108 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8109
5d4cb038
PE
8110 * sysdep.c (croak): Now static, if
8111 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8112 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
8113
8114 * alloc.c (refill_memory_reserve): Now static if
8115 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8116 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 8117
e87b6180
PE
8118 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8119 Define only if USE_LUCID.
8120
ac64929e
PE
8121 * xrdb.c (x_customization_string, x_rm_string): Now static.
8122
6f37259d
PE
8123 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8124 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8125
1683e3ab
PE
8126 * xdisp.c (draw_row_with_mouse_face): Now static.
8127 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8128
de9c2632
PE
8129 * window.h (check_all_windows): Mark externally visible.
8130
2b96acb7
PE
8131 * window.c (window_deletion_count): Now static.
8132
8133 * undo.c: Make symbols static if they're not exported.
8134 (last_undo_buffer, last_boundary_position, pending_boundary):
8135 Now static.
8136
50436f33
PE
8137 * textprop.c (interval_insert_behind_hooks): Now static.
8138 (interval_insert_in_front_hooks): Likewise.
8139
64520e5c
PE
8140 * term.c: Make symbols static if they're not exported.
8141 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8142 (max_frame_lines, tty_set_terminal_modes):
8143 (tty_reset_terminal_modes, tty_turn_off_highlight):
8144 (get_tty_terminal): Now static.
8145 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8146 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8147 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8148 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8149 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8150
1fa53021
PE
8151 * sysdep.c: Make symbols static if they're not exported.
8152 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8153 Now static.
8154 (sigprocmask_set, full_mask): Remove; unused.
8155 (wait_debugging): Mark as visible.
8156 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8157 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8158
d4b43b22
PE
8159 * syntax.c (syntax_temp): Define only if !__GNUC__.
8160
b7c513d0
PE
8161 * sound.c (current_sound_device, current_sound): Now static.
8162
989b29ad
PE
8163 * search.c (searchbufs, searchbuf_head): Now static.
8164
13a55a78
PE
8165 * scroll.c (scroll_cost): Remove; unused.
8166 * dispextern.h (scroll_cost): Remove decl.
8167
de68a1fc
PE
8168 * region-cache.h (pp_cache): Mark as externally visible.
8169
40ccffa6
PE
8170 * process.c: Make symbols static if they're not exported.
8171 (process_tick, update_tick, create_process, chan_process):
8172 (Vprocess_alist, proc_buffered_char, datagram_access):
8173 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8174 (deactivate_process): Mark defn as static, as well as decl.
8175 * lisp.h (create_process): Remove decl.
8176 * process.h (chan_process, Vprocess_alist): Remove decls.
8177
ad64fc97
PE
8178 * print.c: Make symbols static if they're not exported.
8179 (print_depth, new_backquote_output, being_printed, print_buffer):
8180 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8181 (print_interval, print_number_index, initial_stderr_stream):
8182 Now static.
8183 * lisp.h (Fprinc): Remove decl.
8184 (debug_output_compilation_hack): Mark as externally visible.
8185
adddb265
PE
8186 * sysdep.c (croak): Move decl from here to syssignal.h.
8187 * syssignal.h (croak): Put it here, so the API can be checked when
8188 'croak' is called from dissociate_if_controlling_tty.
8189
1717ede2
PE
8190 * minibuf.c: Make symbols static if they're not exported.
8191 (minibuf_save_list, choose_minibuf_frame): Now static.
8192 * lisp.h (choose_minibuf_frame): Remove decl.
8193
fa5fb2bc
PE
8194 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8195
1e3890d1
PE
8196 * lread.c: Make symbols static if they're not exported.
8197 (read_objects, initial_obarray, oblookup_last_bucket_number):
8198 Now static.
8199 (make_symbol): Remove; unused.
8200 * lisp.h (initial_obarray, make_symbol): Remove decls.
8201
8a1414fa
PE
8202 * keyboard.c: Make symbols static if they're not exported.
8203 (single_kboard, recent_keys_index, total_keys, recent_keys):
8204 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8205 (this_single_command_key_start, echoing, last_auto_save):
8206 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8207 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8208 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8209 (Vlispy_mouse_stem, double_click_count):
8210 Now static.
8211 (force_auto_save_soon): Define only if SIGDANGER.
8212 (ignore_mouse_drag_p): Now static if
8213 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8214 (print_help): Remove; unused.
8215 (stop_character, last_timer_event): Mark as externally visible.
8216 * keyboard.h (ignore_mouse_drag_p): Declare only if
8217 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8218 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8219 * lisp.h (echoing): Remove decl.
8220 (force_auto_save_soon): Declare only if SIGDANGER.
8221 * xdisp.c (redisplay_window): Simplify code, to make it more
8222 obvious that ignore_mouse_drag_p is not accessed if !defined
8223 USE_GTK && !defined HAVE_NS.
8224
93ea6e8f
PE
8225 * intervals.c: Make symbols static if they're not exported.
8226 (merge_properties_sticky, merge_interval_right, delete_interval):
8227 Now static.
8228 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8229
77382fcc
PE
8230 * insdel.c: Make symbols static if they're not exported.
8231 However, leave prepare_to_modify_buffer alone. It's never
8232 called from outside this function, but that appears to be a bug.
8233 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8234 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8235 (adjust_after_replace_noundo): Remove; unused.
8236 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8237 (signal_before_change): Remove decls.
77382fcc 8238
9306c32e
PE
8239 * indent.c (val_compute_motion, val_vmotion): Now static.
8240
cd44d2eb
PE
8241 * image.c: Make symbols static if they're not exported.
8242 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8243 if USE_GTK.
8244 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8245 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8246
ad9a7a06
PE
8247 * fringe.c (standard_bitmaps): Now static.
8248 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8249
81626931
PE
8250 * frame.c: Make symbols static if they're not exported.
8251 (x_report_frame_params, make_terminal_frame): Now static.
8252 (get_frame_param): Now static, unless HAVE_NS.
8253 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8254 (x_get_resource_string): Remove; not used.
8255 * frame.h (make_terminal_frame, x_report_frame_params):
8256 (x_get_resource_string); Remove decls.
8257 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8258 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8259
239f9db9
PE
8260 * font.c, fontset.c: Make symbols static if they're not exported.
8261 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8262 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8263 * font.c (font_close_object): Now static.
8264 * font.h (font_close_object): Remove.
8265 * fontset.c (FONTSET_OBJLIST): Remove.
8266 (free_realized_fontset) #if-0 the body, which does nothing.
8267 (face_suitable_for_char_p): #if-0, as it's never called.
8268 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8269 * xfaces.c (face_at_string_position):
8270 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8271 since 0 is always ASCII.
8272
dfcf3579
PE
8273 * fns.c (weak_hash_tables): Now static.
8274
5045092b
PE
8275 * fileio.c: Make symbols static if they're not exported.
8276 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8277 (Vwrite_region_annotation_buffers): Now static.
8278
57a96f5c
PE
8279 * eval.c: Make symbols static if they're not exported.
8280 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8281 * lisp.h (backtrace_list): Remove decl.
8282
35f08c38
PE
8283 * emacs.c: Make symbols static if they're not exported.
8284 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8285 (fatal_error_code, fatal_error_signal_hook, standard_args):
8286 Now static.
8287 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8288 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8289 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8290 * lisp.h (fatal_error_signal_hook): Remove decl.
8291 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8292
f44bd759
PE
8293 * editfns.c: Move a (normally-unused) function to its only use.
8294 * editfns.c, lisp.h (get_operating_system_release): Remove.
8295 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8296 worth the hassle of breaking this out.
8297
b532497d
PE
8298 * xterm.c: Make symbols static if they're not exported.
8299 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8300 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8301 (x_destroy_window, x_delete_display):
8302 Now static.
8303 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8304 (x_mouse_leave): Remove; unused.
8305 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8306 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8307 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8308 Remove decls.
8309 (x_mouse_leave): Declare only if WINDOWSNT.
8310 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8311 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8312 USE_X_TOOLKIT.
8313
1675728f
PE
8314 * ftxfont.c: Make symbols static if they're not exported.
8315 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8316 HAVE_FREETYPE.
8317 * font.h (ftxfont_driver): Likewise.
8318
e4cebfca
PE
8319 * xfns.c: Make symbols static if they're not exported.
8320 (x_last_font_name, x_display_info_for_name):
8321 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8322 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8323 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8324 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8325 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8326 (last_show_tip_args): Now static.
8327 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8328 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8329 (x_screen_planes): Remove; unused.
8330 * dispextern.h (x_screen_planes): Remove decl.
8331
5bf46f05
PE
8332 * dispnew.c: Make symbols static if they're not exported.
8333 * dispextern.h (redraw_garbaged_frames, scrolling):
8334 (increment_row_positions): Remove.
8335 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8336 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8337 Now static.
8338 (redraw_garbaged_frames): Remove; unused.
8339
435f4c28
PE
8340 * xfaces.c: Make symbols static if they're not exported.
8341 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8342 Remove decls.
8343 * xterm.h (defined_color): Remove decls.
8344 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8345 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8346 (menu_face_changed_default, defined_color, free_realized_face):
8347 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8348 (ascii_face_of_lisp_face): Remove; unused.
8349
8524aef3
PE
8350 * xdisp.c: Make symbols static if they're not exported.
8351 * dispextern.h (scratch_glyph_row, window_box_edges):
8352 (glyph_to_pixel_coords, set_cursor_from_row):
8353 (get_next_display_element, set_iterator_to_next):
8354 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8355 (show_mouse_face): Remove decls
8356 * frame.h (message_buf_print): Likewise.
8357 * lisp.h (pop_message, set_message, check_point_in_composition):
8358 Likewise.
8359 * xterm.h (set_vertical_scroll_bar): Likewise.
8360 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8361 (message_buf_print, scratch_glyph_row, displayed_buffer):
8362 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8363 (get_next_display_element, show_mouse_face, window_box_edges):
8364 (frame_to_window_pixel_xy, check_point_in_composition):
8365 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8366 (glyph_to_pixel_coords): Remove; unused.
8367
16390cd2
PE
8368 * dired.c (file_name_completion): Now static.
8369
8370 * dbusbind.c (xd_in_read_queued_messages): Now static.
8371
a25f4dfa
PE
8372 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8373 * data.c (circular_list_error): Remove.
8374
14a9c8df
PE
8375 * commands.h (last_point_position, last_point_position_buffer):
8376 (last_point_position_window): Remove decls.
8377 * keyboard.c: Make these variables static.
8378
04f2d78b
CB
8379 * coding.h (coding, code_convert_region, encode_coding_gap):
8380 Remove decls.
74ab6df5
PE
8381 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8382 (iso_code_class, detect_coding, code_convert_region): Now static.
8383 (encode_coding_gap): Remove; unused.
8384
38dfbee1
PE
8385 * chartab.c (chartab_chars, chartab_bits): Now static.
8386
a2cb4e63
PE
8387 * charset.h (charset_iso_8859_1): Remove decl.
8388 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8389 Now static.
8390
127198fd
PE
8391 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8392 * ccl.c (Vccl_program_table): Now static.
8393 (check_ccl_update): Remove; unused.
8394
d85b608f
PE
8395 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8396 * category.h: ... from here.
8397 * category.c (check_category_table, set_category_set): Now static.
8398
31cd66f3
PE
8399 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8400 * lisp.h: Remove these decls.
8401
c358e587
PE
8402 * buffer.c (buffer_count): Remove unused var.
8403
e78aecca
PE
8404 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8405 so that it's not optimized away.
8406 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8407 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8408 exported only to the debugger.
8409
e192d7d3 8410 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8411 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8412
92470028
PE
8413 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8414 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8415 was inaccessible from Lisp.
8416 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8417 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8418
244ed907
PE
8419 alloc.c: Import and export fewer symbols, and remove unused items.
8420 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8421 is defined.
8422 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8423 it's not optimized away by whole-program optimization.
8424 (message_enable_multibyte, free_misc): Remove.
8425 (catchlist, handlerlist, mark_backtrace):
8426 Declare only if BYTE_MARK_STACK.
8427 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8428 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8429 (message_enable_multibyte): Remove decl.
8430 (free_misc, interval_free_list, float_block, float_block_index):
8431 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8432 (cons_free_list, last_marked_index):
8433 Now static.
8434 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8435 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8436 (mark_backtrace): Define only if BYTE_MARK_STACK.
8437 * xdisp.c (message_enable_multibyte): Now static.
8438
61c2b50e 8439 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8440 This makes it easier for human readers (and static analyzers)
8441 to see whether these variables are used from other modules.
8442 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8443 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8444 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8445 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8446 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8447 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8448 * xmenu.c, xselect.c:
8449 Declare Q* vars static if they are not used in other modules.
8450 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8451 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8452 Remove decls of unexported vars.
8453 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8454
95c82688
PE
8455 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8456
16a97296
PE
8457 Make Emacs functions such as Fatom 'static' by default.
8458 This makes it easier for human readers (and static analyzers)
8459 to see whether these functions can be called from other modules.
8460 DEFUN now defines a static function. To make the function external
8461 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8462 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8463 (Finit_image_library):
16a97296
PE
8464 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8465 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8466 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8467 Remove decls, since these functions are now static.
8468 (Funintern, Fget_internal_run_time): New decls, since these functions
8469 were already external.
95c82688 8470
16a97296
PE
8471 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8472 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8473 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8474 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8475 * keyboard.c, keymap.c, lread.c:
8476 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8477 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8478 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8479 Mark functions with DEFUE instead of DEFUN,
8480 if they are used in other modules.
8481 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8482 decls for now-static functions.
8483 * buffer.h (Fdelete_overlay): Remove decl.
8484 * callproc.c (Fgetenv_internal): Mark as internal.
8485 * composite.c (Fremove_list_of_text_properties): Remove decl.
8486 (Fcomposition_get_gstring): New forward static decl.
8487 * composite.h (Fcomposite_get_gstring): Remove decl.
8488 * dired.c (Ffile_attributes): New forward static decl.
8489 * doc.c (Fdocumntation_property): New forward static decl.
8490 * eval.c (Ffetch_bytecode): New forward static decl.
8491 (Funintern): Remove extern decl; now in .h file where it belongs.
8492 * fileio.c (Fmake_symbolic_link): New forward static decl.
8493 * image.c (Finit_image_library): New forward static decl.
8494 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8495 * intervals.h (Fprevious_property_change):
8496 (Fremove_list_of_text_properties): Remove decls.
8497 * keyboard.c (Fthis_command_keys): Remove decl.
8498 (Fcommand_execute): New forward static decl.
8499 * keymap.c (Flookup_key): New forward static decl.
8500 (Fcopy_keymap): Now static.
8501 * keymap.h (Flookup_key): Remove decl.
8502 * process.c (Fget_process): New forward static decl.
8503 (Fprocess_datagram_address): Mark as internal.
8504 * syntax.c (Fsyntax_table_p): New forward static decl.
8505 (skip_chars): Remove duplicate decl.
8506 * textprop.c (Fprevious_property_change): New forward static decl.
8507 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8508 Now internal.
8509 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8510 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8511
785bbd42
PE
8512 * editfns.c (Fformat): Remove unreachable code.
8513
8b913b57
AS
85142011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8515
8516 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8517 change. (Bug#8496)
8518
a6744a35
EZ
85192011-04-13 Eli Zaretskii <eliz@gnu.org>
8520
8521 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8522 when at ZV. (Bug#8487)
8523
e7974947
AS
85242011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8525
baad03f0
AS
8526 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8527 (Bug#8437)
8528 * keyboard.c (parse_tool_bar_item): Likewise.
8529 * sound.c (sound_cleanup, alsa_close): Likewise.
8530 * termcap.c (tgetent): Likewise.
8531 * xfns.c (x_default_font_parameter): Likewise.
8532 * xsettings.c (read_and_apply_settings): Likewise.
8533
e7974947
AS
8534 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8535 (overrun_check_free): Protoize.
8536
28272684
PE
85372011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8538
8539 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8540 since callers should never pass a negative size.
8541 Change the signature to match that of plain 'read' and 'write'; see
8542 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8543 * lisp.h: Update prototypes of emacs_write and emacs_read.
8544
11997c76
EZ
85452011-04-11 Eli Zaretskii <eliz@gnu.org>
8546
8547 * xdisp.c (redisplay_window): Don't try to determine the character
8548 position of the scroll margin if the window start point w->startp
e896f03c 8549 is outside the buffer's accessible region. (Bug#8468)
11997c76 8550
8a2cbd72
EZ
85512011-04-10 Eli Zaretskii <eliz@gnu.org>
8552
8553 Fix write-region and its subroutines for buffers > 2GB.
8554 * fileio.c (a_write, e_write): Modify declaration of arguments and
8555 local variables to support buffers larger than 2GB.
8556 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8557
8558 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8559 argument, local variables, and return value.
8560
8561 * lisp.h: Update prototypes of emacs_write and emacs_read.
8562
8563 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8564
4073e537 85652011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8566
1ebfdcb6
PE
8567 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8568
b2ded58d
PE
8569 Fix more problems found by GCC 4.6.0's static checks.
8570
7d66342c
PE
8571 * xdisp.c (vmessage): Use a better test for character truncation.
8572
bbf47d44
PE
8573 * charset.c (load_charset_map): <, not <=, for optimization,
8574 and to avoid potential problems with integer overflow.
9248994d 8575 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8576 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8577 * editfns.c (Fformat): Likewise.
1e69125e 8578 * syntax.c (skip_chars): Likewise.
3befa583 8579
e3019616
PE
8580 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8581 This also lets GCC 4.6.0 generate slightly better loop code.
8582
becfa255
PE
8583 * callint.c (Fcall_interactively): <, not <=, for optimization.
8584 (Fcall_interactively): Count the number of arguments produced,
8585 not the number of arguments given. This is simpler and lets GCC
8586 4.6.0 generate slightly better code.
8587
dae0cd48
PE
8588 * ftfont.c: Distingish more carefully between FcChar8 and char.
8589 The previous code passed unsigned char * to a functions like
8590 strlen and xstrcasecmp that expect char *, which does not
8591 conform to the C standard.
8592 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8593 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8594 char * when the C standard requires it.
8595
76032d70
PE
8596 * keyboard.c (read_char): Remove unused var.
8597
eb3f1cc8
PE
8598 * eval.c: Port to Windows vsnprintf (Bug#8435).
8599 Include <limits.h>.
8600 (SIZE_MAX): Define if the headers do not.
8601 (verror): Do not give up if vsnprintf returns a negative count.
8602 Instead, grow the buffer. This ports to Windows vsnprintf, which
8603 does not conform to C99. Problem reported by Eli Zaretskii.
8604 Also, simplify the allocation scheme, by avoiding the need for
8605 calling realloc, and removing the ALLOCATED variable.
8606
70476b54
PE
8607 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8608
12020a9e
PE
8609 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8610 But keep the doprint source code for now, as we might revamp it
8611 and use it again (Bug#8435).
ea6c7ae6
PE
8612 * lisp.h (doprnt): Remove.
8613 * Makefile.in (base_obj): Remove doprnt.o.
8614 * deps.mk (doprnt.o): Remove.
8615
5fdb398c
PE
8616 error: Print 32- and 64-bit integers portably (Bug#8435).
8617 Without this change, on typical 64-bit hosts error ("...%d...", N)
8618 was used to print both 32- and 64-bit integers N, which relied on
8619 undefined behavior.
61bdb816 8620 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8621 * lisp.h (error, verror): Mark as printf-like functions.
8622 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8623 Report overflow in size calculations when allocating printf buffer.
8624 Do not truncate output string at its first null byte.
8625 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8626 Truncate the output at a character boundary, since vsnprintf does not
8627 do that.
8628 * charset.c (check_iso_charset_parameter): Convert internal
8629 character to string before calling 'error', since %c now has the
8630 printf meaning.
8631 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8632 overflow when computing char to be passed to 'error'. Do not
8633 pass Lisp_Object to 'error'; pass the integer instead.
8634 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8635 formatted with plain %d.
8636
b189fa66
PE
8637 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8638
bff87ef0
PE
8639 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8640
7e2cac20
PE
8641 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8642
ce4d90b5
PE
8643 * xterm.c (x_catch_errors): Remove duplicate declaration.
8644
266c9547
PE
8645 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8646
79c49ad2
PE
8647 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8648
368f4090
JM
86492011-04-10 Jim Meyering <meyering@redhat.com>
8650
8651 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8652 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8653 return ssize_t not "int", and use size_t as the buffer length.
8654 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8655 * gnutls.h: Update declarations.
8656 * process.c (read_process_output): Use ssize_t, to match.
8657 (send_process): Likewise.
8658
a32d4040
CY
86592011-04-09 Chong Yidong <cyd@stupidchicken.com>
8660
8661 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8662
8546720e 86632011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8664
04f2d78b
CB
8665 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8666 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8667
8546720e
GM
8668 * xterm.c (handle_one_xevent):
8669 * xmenu.c (create_and_show_popup_menu):
8670 * xselect.c (x_decline_selection_request)
8671 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8672
0a2f5c1a 86732011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8674
8675 Fix some uses of `int' instead of EMACS_INT.
8676 * search.c (string_match_1, fast_string_match)
8677 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8678 (scan_buffer, find_next_newline_no_quit)
8679 (find_before_next_newline, search_command, Freplace_match)
8680 (Fmatch_data): Make some `int' variables be EMACS_INT.
8681
8682 * xdisp.c (display_count_lines): 3rd argument and return value now
8683 EMACS_INT. All callers changed.
8684 (pint2hrstr): Last argument is now EMACS_INT.
8685
8686 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8687 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8688 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8689 (decode_coding_utf_16, decode_coding_emacs_mule)
8690 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8691 (decode_coding_ccl, decode_coding_charset)
8692 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8693 (decode_coding_iso_2022, decode_coding_emacs_mule)
8694 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8695 <char_offset, last_offset>: Declare EMACS_INT.
8696 (encode_coding_utf_8, encode_coding_utf_16)
8697 (encode_coding_emacs_mule, encode_invocation_designation)
8698 (encode_designation_at_bol, encode_coding_iso_2022)
8699 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8700 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8701 Declare EMACS_INT.
8702 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8703 (encode_invocation_designation): Last argument P_NCHARS is now
8704 EMACS_INT.
8705 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8706 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8707
8708 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8709 All users changed.
8710
8711 * ccl.c (Fccl_execute_on_string): Declare some variables
8712 EMACS_INT.
8713
8546720e 87142011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8715
8716 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8717
4e19a977
CS
87182011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8719
8720 * process.c (Fformat_network_address): Doc fix.
8721
87302331
R
87222011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8723
ee7683eb 8724 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8725
cbb59342
CY
87262011-04-08 Chong Yidong <cyd@stupidchicken.com>
8727
8728 * keyboard.c (read_char): Call Lisp function help-form-show,
8729 instead of using internal_with_output_to_temp_buffer.
8730 (Qhelp_form_show): New var.
e0d38eeb 8731 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8732
8733 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8734
8735 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8736
e67a13ab
CY
87372011-04-06 Chong Yidong <cyd@stupidchicken.com>
8738
04f2d78b
CB
8739 * process.c (Flist_processes): Remove to Lisp.
8740 (list_processes_1): Delete.
e67a13ab 8741
973f782d
EZ
87422011-04-06 Eli Zaretskii <eliz@gnu.org>
8743
7c106b1e
EZ
8744 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8745
973f782d
EZ
8746 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8747
41cf7d1a 87482011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8749
ca23cc88
PE
8750 Fix more problems found by GCC 4.6.0's static checks.
8751
f390e2d5
PE
8752 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8753
42eea0d0
PE
8754 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8755
b69769da 8756 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8757
f9541e84
PE
8758 * xdisp.c (vmessage): Mark as a printf-like function.
8759
13841b55
PE
8760 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8761
c136c10f
PE
8762 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8763
5e2d4a30
PE
8764 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8765 printf-like functions.
8766 (tiff_load): Add casts to remove these marks before passing them
8767 to system-supplied API.
8768
583f48b9
PE
8769 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8770
b25d760e
PE
8771 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8772 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8773 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8774 directly, rather than having caller test rule sign. This avoids
8775 some unnecessary tests.
8776 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8777 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8778 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8779
bc7b6697 8780 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8781 (xfont_open): Avoid unnecessary tests.
bc7b6697 8782
27ccc379
PE
8783 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8784
dcd5c89a
PE
8785 * composite.h, composite.c (composition_gstring_put_cache):
8786 Use EMACS_INT, not int, for length.
8787
b13a45c6
PE
8788 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8789 breaking out part of COMPOSITION_DECODE_RULE.
8790 (COMPOSITION_DECODE_RULE): Use it.
8791 * composite.c (get_composition_id): Remove unused local vars,
8792 by using the new macro.
8793
1e792e4d
PE
8794 * textprop.c (set_text_properties_1): Change while to do-while,
8795 since the condition is always true at first.
8796
dc6c6455 8797 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8798 (interval_deletion_adjustment): Return unsigned value.
8799 All uses changed.
dc6c6455 8800
aba7731a
PE
8801 * process.c (list_processes_1, create_pty, read_process_output):
8802 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8803 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8804 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8805 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8806 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8807
fdfc4bf3
PE
8808 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8809
fca8fe46 8810 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8811 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8812
06a0259a 8813 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8814 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8815 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8816
e7b9e80f
PE
8817 * print.c (print_error_message): Avoid int overflow.
8818
56201685
PE
8819 * font.c (font_list_entities): Redo for clarity,
8820 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8821
78834453 8822 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8823 (font_score): Avoid potential overflow in diff calculation.
78834453 8824
0bc0b309 8825 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8826 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8827
e610eaca
PE
8828 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8829
b895abce
PE
8830 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8831 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8832 can always succeed if overflow has undefined behavior.
8833
1f1d9321 8834 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8835 (wordify): Omit three unnecessary tests.
1f1d9321 8836
c59478bc
PE
8837 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8838 All callers changed. This avoids the need for an unused var.
8839
79b73827
PE
8840 * casefiddle.c (casify_region): Remove var that is set but not used.
8841
a4db5dfe
PE
8842 * dired.c (file_name_completion): Remove var that is set but not used.
8843
43aae36e
PE
8844 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8845
2a47c44d 8846 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8847 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8848
a37c69bf
PE
8849 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8850 Check for integer overflow on size calculations.
8851
328ab8e7
PE
8852 * buffer.c (Fprevious_overlay_change): Remove var that is set
8853 but not used.
8854
e5a2a5cb
PE
8855 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8856 Remove vars that are set but not used.
8d84a6eb 8857 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8858 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8859
a60e5f68
PE
8860 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8861
f661cb61 8862 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8863 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8864
f0397f5a
PE
8865 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8866 that are set but not used.
8867
8664db06 8868 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8869 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8870
6abdaa4a
PE
8871 * xselect.c (x_get_local_selection, x_handle_property_notify):
8872 Remove vars that are set but not used.
8873
0ce7538d 8874 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8875 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8876
9ae848fc
PE
8877 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8878 Remove var that is set but not used.
0b918413
PE
8879 (scroll_bar_windows_size): Now size_t, not int.
8880 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8881 Check for overflow.
9ae848fc 8882
a5a62657
PE
8883 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8884 (map_tty_color) [!defined MSDOS]: Likewise.
8885
5c5cdd39
PE
8886 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8887
66ebf983
PE
8888 * coding.c: Remove vars that are set but not used.
8889 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8890 All callers changed.
8891 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8892 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8893 (decode_coding_charset): Remove vars that are set but not used.
8894
1be4d761
PE
8895 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8896 that is set but not used.
8897
47553fa8
PE
8898 * print.c (print_object): Remove var that is set but not used.
8899
1f7196bf 8900 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8901 The gnulib version avoids calling malloc in the usual case,
8902 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8903 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8904 * filelock.c (current_lock_owner): Likewise.
8905 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8906 * sysdep.c: Include allocator.h, careadlinkat.h.
8907 (emacs_no_realloc_allocator): New static constant.
8908 (emacs_readlink): New function.
fdb61804
PE
8909 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8910 ../lib/careadlinkat.h.
d1fdcab7 8911
f84c17c7
SM
89122011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8913
8914 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8915 first non-nil return value).
8916
ef3862ad
JD
89172011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8918
8919 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8920 if not defined (Bug#8403).
8921
376a7006
JB
89222011-04-02 Juanma Barranquero <lekktu@gmail.com>
8923
8924 * xdisp.c (display_count_lines): Remove parameter `start',
8925 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8926 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8927 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8928 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8929 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8930 and thereabouts. All callers changed.
8931 (get_per_char_metric): Remove parameter `f', unused since
8932 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8933
6ca3801d
JM
89342011-04-02 Jim Meyering <meyering@redhat.com>
8935
8936 do not dereference NULL upon failed strdup
8937 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8938 (ns_get_family): Likewise.
8939
d8e2b5ba
JB
89402011-04-02 Juanma Barranquero <lekktu@gmail.com>
8941
8942 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8943
8c74fcbd
JD
89442011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8945
8946 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8947 later (Bug#8403).
8948
7200d79c
SM
89492011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8950
03408648 8951 Add lexical binding.
7200d79c 8952
03408648
SM
8953 * window.c (Ftemp_output_buffer_show): New fun.
8954 (Fsave_window_excursion):
8955 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8956
8957 * lread.c (lisp_file_lexically_bound_p): New function.
8958 (Fload): Bind Qlexical_binding.
8959 (readevalloop): Remove `evalfun' arg.
8960 Bind Qinternal_interpreter_environment.
8961 (Feval_buffer): Bind Qlexical_binding.
8962 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8963 Mark as dynamic.
8964 (syms_of_lread): Declare `lexical-binding'.
8965
8966 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8967
8968 * keyboard.c (eval_dyn): New fun.
8969 (menu_item_eval_property): Use it.
ca105506
SM
8970
8971 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8972
03408648
SM
8973 * fns.c (concat, mapcar1): Accept byte-code-functions.
8974
8975 * eval.c (Fsetq): Handle lexical vars.
8976 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8977 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8978 (FletX, Flet): Obey lexical binding.
8979 (Fcommandp): Handle closures.
8980 (Feval): New `lexical' arg.
8981 (eval_sub): New function extracted from Feval. Use it almost
8982 everywhere where Feval was used. Look up vars in lexical env.
8983 Handle closures.
8984 (Ffunctionp): Move from subr.el.
8985 (Ffuncall): Handle closures.
8986 (apply_lambda): Remove `eval_flags'.
8987 (funcall_lambda): Handle closures and new byte-code-functions.
8988 (Fspecial_variable_p): New function.
8989 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8990 but without exporting it to Lisp.
23aba0ea 8991
23aba0ea 8992 * doc.c (Fdocumentation, store_function_docstring):
03408648 8993 * data.c (Finteractive_form): Handle closures.
23aba0ea 8994
03408648
SM
8995 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8996 interactive spec.
ba83908c 8997
04f2d78b
CB
8998 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8999 New byte-codes.
03408648
SM
9000 (exec_byte_code): New function extracted from Fbyte_code to handle new
9001 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 9002
03408648 9003 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 9004
03408648 9005 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 9006
e2abce01
JB
90072011-03-31 Juanma Barranquero <lekktu@gmail.com>
9008
9009 * xdisp.c (redisplay_internal): Fix prototype.
9010
63696a73 90112011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 9012
63696a73 9013 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
9014 (try_scrolling): Use it when setting scroll_limit.
9015 Limit scrolling to 100 screen lines.
63696a73
EZ
9016 (redisplay_window): Even when falling back on "recentering",
9017 position point in the window according to scroll-conservatively,
9018 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9019
9020 (try_scrolling): When point is above the window, allow searching
9021 as far as scroll_max, or one screenful, to compute vertical
9022 distance from PT to the scroll margin position. This prevents
9023 try_scrolling from unnecessarily failing when
9024 scroll-conservatively is set to a value slightly larger than the
9025 window height. Clean up the case of PT below the margin at bottom
9026 of window: scroll_max can no longer be INT_MAX. When aggressive
9027 scrolling is in use, don't let point enter the opposite scroll
9028 margin as result of the scroll.
9029 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
9030 threshold of 100 lines for never-recentering scrolling.
9031
e4cc2dfc
JB
90322011-03-31 Juanma Barranquero <lekktu@gmail.com>
9033
9034 * dispextern.h (move_it_by_lines):
9035 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9036 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9037 (message_log_check_duplicate): Remove parameters `prev_bol' and
9038 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9039 (redisplay_internal): Remove parameter `preserve_echo_area',
9040 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9041
9042 * indent.c (Fvertical_motion):
9043 * window.c (window_scroll_pixel_based, Frecenter):
9044 Don't pass `need_y_p' to `move_it_by_lines'.
9045
1c470562
SM
90462011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9047
44f230aa
SM
9048 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9049 steal a few bits to be more compact.
9050 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9051 Remove unneeded casts.
9052
1c470562
SM
9053 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9054
888adce9
ZK
90552011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9056
9057 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9058 binding" message (bug#7967).
9059
f838ed7b
PE
90602011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9061
77861b95
PE
9062 Fix more problems found by GCC 4.6.0's static checks.
9063
de6dbc14
PE
9064 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9065 Remove unused local var.
9066
f838ed7b
PE
9067 * editfns.c (Fmessage_box): Remove unused local var.
9068
792c7b2b
PE
9069 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9070 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9071 Omit unused local vars.
c499e557 9072 * window.c (shrink_windows): Omit unused local var.
b01a1c29 9073 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
9074 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9075 Omit unused local var.
9076
ba0165e1
PE
9077 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9078 Don't assume string length fits in int.
32ad8845 9079 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 9080 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 9081
3c59b4c9
PE
9082 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9083 instead of alloca (Bug#8344).
9084
a3eed478 9085 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 9086 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 9087
eb4d412d
PE
9088 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9089
1658b401
PE
9090 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9091 concerns.
9092
9093 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9094
9095 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 9096
9a2c6e05
PE
9097 * keyboard.c (syms_of_keyboard): Use the same style as later
9098 in this function when indexing through an array. This also
9099 works around GCC bug 48267.
9100
03d0a109
PE
9101 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9102
44f730c8
PE
9103 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9104
fe75f926
PE
9105 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9106 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9107
ffa8c828
PE
9108 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9109 This avoids undefined behavior on integer overflow, and is a bit
9110 more convenient anyway since it is compared to a size_t variable.
9111
c5101a77
PE
9112 Variadic C functions now count arguments with size_t, not int.
9113 This avoids an unnecessary limitation on 64-bit machines, which
9114 caused (substring ...) to crash on large vectors (Bug#8344).
9115 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9116 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 9117 All variadic functions and their callers changed accordingly.
c5101a77
PE
9118 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9119 * data.c (arith_driver, float_arith_driver): Likewise.
9120 * editfns.c (general_insert_function): Likewise.
9121 * eval.c (struct backtrace.nargs, interactive_p)
9122 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9123 (funcall_lambda, mark_backtrace): Likewise.
9124 * fns.c (concat): Likewise.
9125 * frame.c (x_set_frame_parameters): Likewise.
9126 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9127 0 if not found, not -1. All callers changed.
9128
dd3f25f7
PE
9129 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9130 (stack_copy_size): Now size_t, not int.
9131 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9132
461c2ab9
JB
91332011-03-28 Juanma Barranquero <lekktu@gmail.com>
9134
9135 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9136 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9137 All callers changed.
9138
9139 * lisp.h (multibyte_char_to_unibyte):
9140 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9141 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9142 * character.h (CHAR_TO_BYTE8):
9143 * cmds.c (internal_self_insert):
9144 * editfns.c (general_insert_function):
9145 * keymap.c (push_key_description):
9146 * search.c (Freplace_match):
9147 * xdisp.c (message_dolog, set_message_1): All callers changed.
9148
f6d62986
SM
91492011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9150
9151 * keyboard.c (safe_run_hook_funcall): New function.
9152 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9153 don't set the hook to nil, but remove the offending function instead.
9154 (Qcommand_hook_internal): Remove, unused.
9155 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9156 Vcommand_hook_internal.
9157
9158 * eval.c (enum run_hooks_condition): Remove.
9159 (funcall_nil, funcall_not): New functions.
9160 (run_hook_with_args): Call each function through a `funcall' argument.
9161 Remove `cond' argument, now redundant.
9162 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9163 (Frun_hook_with_args_until_failure): Adjust accordingly.
9164 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9165
1db5b1ad
JB
91662011-03-28 Juanma Barranquero <lekktu@gmail.com>
9167
9168 * dispextern.h (string_buffer_position): Remove declaration.
9169
9170 * print.c (strout): Remove parameter `multibyte', unused since
9171 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9172
9173 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9174 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9175 All callers changed.
9176
9177 * w32.c (_wsa_errlist): Use braces for struct initializers.
9178
9179 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9180 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9181 All callers changed.
9182 (string_buffer_position): Likewise. Also, make static (it's never
9183 used outside xdisp.c).
9184 (cursor_row_p): Remove parameter `w', unused since
9185 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9186 (decode_mode_spec): Remove parameter `precision', introduced during
9187 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9188 All callers changed.
9189
5ffb62aa
JD
91902011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9191
9192 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9193
461c2ab9 91942011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9195
9196 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9197 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9198 (ns_update_auto_hide_menu_bar): New functions.
9199 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9200 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9201 ns_constrain_all_frames.
9202 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9203 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9204
5c380ffb
JD
92052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9206
9207 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9208
9af30bdf
GM
92092011-03-27 Glenn Morris <rgm@gnu.org>
9210
9211 * syssignal.h: Replace RETSIGTYPE with void.
9212 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9213 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9214 Replace SIGTYPE with void everywhere.
9215 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9216 * s/template.h (SIGTYPE): Remove commented out definition.
9217
e2abce01
JB
92182011-03-26 Eli Zaretskii <eliz@gnu.org>
9219
9220 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9221 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9222
f868cd8a
JB
92232011-03-26 Juanma Barranquero <lekktu@gmail.com>
9224
59eb0929
JB
9225 * w32.c (read_unc_volume): Use parameter `henum', instead of
9226 global variable `wget_enum_handle'.
9227
9228 * keymap.c (describe_vector): Remove parameters `indices' and
9229 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9230 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9231
f868cd8a
JB
9232 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9233
9234 * keyboard.c (timer_check): Remove parameter `do_it_now',
9235 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9236 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9237 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9238
9239 * keyboard.c (read_char):
9240 * w32menu.c (w32_menu_display_help):
9241 * xmenu.c (show_help_event, menu_help_callback):
9242 Adjust calls to `show_help_echo'.
9243
9244 * gtkutil.c (xg_maybe_add_timer):
9245 * keyboard.c (readable_events):
9246 * process.c (wait_reading_process_output):
9247 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9248
9249 * insdel.c (adjust_markers_gap_motion):
9250 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9251 (gap_left, gap_right): Don't call it.
9252
2ecf6fdb
CY
92532011-03-25 Chong Yidong <cyd@stupidchicken.com>
9254
9255 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9256 incurred during fontification.
9257
6b1f9ba4
JB
92582011-03-25 Juanma Barranquero <lekktu@gmail.com>
9259
9260 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9261 (DEFVAR_PER_BUFFER): Don't pass it.
9262
9263 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9264 (scrolling_window): Don't pass it.
9265
0f4a96b5
JB
92662011-03-25 Juanma Barranquero <lekktu@gmail.com>
9267
9268 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9269
9270 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9271 and `suffix'.
9272 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9273 of variables specific to SELinux and computation of `encoded_absname'.
9274
9275 * image.c (XPutPixel): Remove unused variable `height'.
9276
9277 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9278
9279 * unexw32.c (get_section_info): Remove unused variable `section'.
9280
9281 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9282 (system_process_attributes): Remove unused variable `sess'.
9283 (sys_read): Remove unused variable `err'.
9284
9285 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9286 (w32_wnd_proc): Remove unused variable `isdead'.
9287 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9288 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9289 (x_create_tip_frame): Remove unused variable `tem'.
9290
9291 * w32inevt.c (w32_console_read_socket):
9292 Remove unused variable `no_events'.
9293
9294 * w32term.c (x_draw_composite_glyph_string_foreground):
9295 Remove unused variable `width'.
9296
1149507c
JB
92972011-03-24 Juanma Barranquero <lekktu@gmail.com>
9298
9299 * w32term.c (x_set_glyph_string_clipping):
9300 Don't pass uninitialized region to CombineRgn.
9301
9c88f339
JB
93022011-03-23 Juanma Barranquero <lekktu@gmail.com>
9303
9304 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9305 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9306 (Fx_close_connection): Remove unused variable `i'.
9307
9308 * w32font.c (w32font_draw): Return number of glyphs.
9309 (w32font_open_internal): Remove unused variable `i'.
9310 (w32font_driver): Add missing initializer.
9311
9312 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9313 (fill_in_menu): Remove unused variable `items_added'.
9314
9315 * w32term.c (last_mouse_press_frame): Remove static global variable.
9316 (w32_clip_to_row): Remove unused variable `f'.
9317 (x_delete_terminal): Remove unused variable `i'.
9318
9319 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9320 (NOTHING): Remove unused static global variable.
9321 (uniscribe_check_otf): Remove unused variable `table'.
9322 (uniscribe_font_driver): Add missing initializers.
9323
dee091a3
JD
93242011-03-23 Julien Danjou <julien@danjou.info>
9325
9326 * term.c (Fsuspend_tty, Fresume_tty):
9327 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9328 * window.c (temp_output_buffer_show):
9329 * insdel.c (signal_before_change):
9330 * frame.c (Fhandle_switch_frame):
9331 * fileio.c (Fdo_auto_save):
9332 * emacs.c (Fkill_emacs):
9333 * editfns.c (save_excursion_restore):
9334 * cmds.c (internal_self_insert):
9335 * callint.c (Fcall_interactively):
9336 * buffer.c (Fkill_all_local_variables):
9337 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9338 Use Frun_hooks.
0f4a96b5 9339 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9340 unconditionally since it does the check itself.
dee091a3 9341
2c520ab5 93422011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9343
c9c49752
PE
9344 Fix more problems found by GCC 4.5.2's static checks.
9345
8abc3f12
PE
9346 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9347 the first time through the loop, since we know p0 < p1 then.
9348 This also avoids a gcc -Wstrict-overflow warning.
9349
a2d26660
PE
9350 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9351 leading to a memory leak, possible in functions like
9352 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9353 of objects (Bug#8318).
a2d26660 9354
916c72e9
PE
9355 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9356 that could (at least in theory) be that large.
9357
19ab8a18
PE
9358 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9359 This is less likely to overflow, and avoids undefined behavior if
9360 overflow does occur. All callers changed. Use strtoul to scan
9361 for the unsigned long integer.
b7cbbd6f
PE
9362 (pint2hrstr): Simplify and tune code slightly.
9363 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9364
f0641eff
PE
9365 * scroll.c (do_scrolling): Work around GCC bug 48228.
9366 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9367
7f650bb9
PE
9368 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9369 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9370 (validate_x_resource_name): Simplify count usage.
9371 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9372
37dd57d1
PE
9373 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9374 fail (Bug#8306).
81e56e61 9375
699979fc 9376 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9377
401bf9b4
PE
9378 * process.c (Fmake_network_process): Use socklen_t, not int,
9379 where POSIX says socklen_t is required in portable programs.
9380 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9381 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9382 (Fmake_network_process, server_accept_connection):
9383 (wait_reading_process_output, read_process_output):
9384 Likewise.
9385
b93aacde
PE
9386 * process.c: Rename or move locals to avoid shadowing.
9387 (list_processes_1, Fmake_network_process):
9388 (read_process_output_error_handler, exec_sentinel_error_handler):
9389 Rename or move locals.
4dc343ee 9390 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9391 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9392 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9393 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9394 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9395
af8a867c 9396 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9397 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9398 Include tparam.h instead, since it declares them.
af8a867c
PE
9399 * cm.h (PC): Remove extern decl; tparam.h now does this.
9400 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9401 * terminfo.c: Include tparam.h, to check interfaces.
9402 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9403 (tparam): Adjust signature to match interface in tparam.h;
9404 this removes some undefined behavior. Check that outstring and len
9405 are zero, which they always are with Emacs.
9406 * tparam.h (PC, BC, UP): New extern decls.
9407
0248044d 9408 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9409 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9410
8ff096c1 9411 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9412 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9413 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9414 (ftfont_list): Remove unused local.
49eaafba
PE
9415 (get_adstyle_property, ftfont_pattern_entity):
9416 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9417 Rename locals to avoid shadowing.
8ff096c1 9418
e2be39f6
PE
9419 * xfont.c (xfont_list_family): Mark var as initialized.
9420
c9735e30
PE
9421 * xml.c (make_dom): Now static.
9422
8f5201ae
PE
9423 * composite.c (composition_compute_stop_pos): Rename local to
9424 avoid shadowing.
b246f932
PE
9425 (composition_reseat_it): Remove unused locals.
9426 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9427 (composition_update_it): Mark var as initialized.
11b61122
PE
9428 (find_automatic_composition): Mark vars as initialized,
9429 with a FIXME (Bug#8290).
8f5201ae 9430
760fbc2c
PE
9431 character.h: Rename locals to avoid shadowing.
9432 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9433 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9434 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9435 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9436 to avoid shadowing.
9437
ff08eb85
PE
9438 * textprop.c (property_change_between_p): Remove; unused.
9439
fc7bf025
PE
9440 * intervals.c (interval_start_pos): Now static.
9441
235d7abc
PE
9442 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9443
44f230aa
SM
9444 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9445 Rename locals to avoid shadowing.
3e7d6594 9446
50060332
PE
9447 * sound.c (wav_play, au_play, Fplay_sound_internal):
9448 Fix pointer signedness.
d01f234b 9449 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9450 (wav_play): Initialize a variable to 0, to prevent undefined
9451 behavior (Bug#8278).
50060332 9452
c4fc4e30
PE
9453 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9454
918436ed
PE
9455 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9456
c939f91b
PE
9457 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9458 clobbering (Bug#8298).
b9c7f648
PE
9459 * sysdep.c (sys_subshell): Likewise.
9460 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9461
6bd8c144
PE
9462 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9463 This should get cleaned up, so that child_setup has the
9464 same signature on all platforms.
9465
7710357c 9466 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9467 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9468
c59da222
CY
94692011-03-22 Chong Yidong <cyd@stupidchicken.com>
9470
9471 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9472 not to be necessary, and produces flickering.
9473
66b87493
GM
94742011-03-20 Glenn Morris <rgm@gnu.org>
9475
9476 * config.in: Remove file.
9477
45b6f6d5
JB
94782011-03-20 Juanma Barranquero <lekktu@gmail.com>
9479
9480 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9481 are now in src/globals.h.
9482 (syms_of_minibuf): Remove spurious & from previous change.
9483
cd394be1 94842011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9485
9486 * minibuf.c (completing-read-function): New variable.
9487 (completing-read-default): Rename from completing-read.
9488 (completing-read): Call completing-read-function.
9489
b14e3e21
CY
94902011-03-19 Juanma Barranquero <lekktu@gmail.com>
9491
9492 * xfaces.c (Fx_load_color_file):
9493 Read color file from absolute filename (bug#8250).
9494
f2b726e6
JB
94952011-03-19 Juanma Barranquero <lekktu@gmail.com>
9496
9497 * makefile.w32-in: Update dependencies.
9498
09f6ff02
EZ
94992011-03-17 Eli Zaretskii <eliz@gnu.org>
9500
9501 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9502
29a6015a
PE
95032011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9504
a3a6c54e
PE
9505 Fix more problems found by GCC 4.5.2's static checks.
9506
b766f867
PE
9507 * process.c (make_serial_process_unwind, send_process_trap):
9508 (sigchld_handler): Now static.
9509
be02381c
PE
9510 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9511 That way, the code declares only the vars that it needs.
9512 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9513 * s/cygwin.h (PTY_ITERATION): Likewise.
9514 * s/darwin.h (PTY_ITERATION): Likewise.
9515 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9516
57048744
PE
9517 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9518 * process.c (allocate_pty): Don't declare stb unless it's needed.
9519
7914961c 9520 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9521 (CONSTANTLIM): Remove; unused.
9522 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9523 Define only if needed.
7914961c 9524
b3967b18
PE
9525 * unexelf.c (unexec): Name an expression,
9526 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9527 Use a different way to cause a compilation error if anyone uses
9528 n rather than nn, a way that does not involve shadowing.
73366a00 9529 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9530
29a6015a
PE
9531 * deps.mk (unexalpha.o): Remove; unused.
9532
43cfc33e 9533 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9534 * unexec.h: New file.
ce701a33
PE
9535 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9536 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9537 Depend on unexec.h.
9538 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9539 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9540 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9541 Change as necessary to match prototype in unexec.h.
ce701a33 9542
01f44d5a
PE
9543 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9544 shadowing.
4f63c6bb 9545 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9546
a6670b0b
PE
9547 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9548 Rename locals to avoid shadowing.
9549
cef2010d 9550 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9551 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9552
d4d7173a
PE
9553 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9554
f08b802a
PE
9555 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9556 warning when compiling print.c.
9557
3ddb0639
PE
9558 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9559 instead of using an uninitialized var.
5ad03b97 9560 (font_sort_entities): Mark var as initialized.
3ddb0639 9561
170a2692
PE
9562 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9563
e663c700
PE
9564 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9565 pointers to constants.
89bc529a 9566 (font_parse_fcname): Remove unused vars.
7b81e2d0 9567 (font_delete_unmatched): Now static.
ea838e10 9568 (font_get_spec): Remove; unused.
13a547c6
PE
9569 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9570 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9571 Rename or move locals to avoid shadowing.
e663c700 9572
2a80c887 9573 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9574 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9575
1384fa33 9576 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9577 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9578
8b2c52e9
PE
9579 * alloc.c (mark_backtrace): Move decl from here ...
9580 * lisp.h: ... to here, so that it can be checked.
9581
475545b5 9582 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9583 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9584 (lisp_indirect_variable): Name an expression,
9585 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9586 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9587
b1349114 9588 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9589 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9590 Use const pointer when appropriate.
b1349114 9591
a2928364
PE
9592 * lisp.h (get_system_name, get_operating_system_release):
9593 Move decls here, to check interfaces.
9594 * process.c (get_operating_system_release): Move decl to lisp.h.
9595 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9596 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9597 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9598 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9599 (Fformat_time_string, Fencode_time, Finsert_char):
9600 (Ftranslate_region_internal, Fformat):
9601 Rename or remove local vars to avoid shadowing.
9710023e 9602 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9603
a415e694
PE
9604 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9605 avoid shadowing.
9606
8ef4622d
PE
9607 * lisp.h (eassert): Check that the argument compiles, even if
9608 ENABLE_CHECKING is not defined.
9609
946f9a5b
PE
9610 * data.c (Findirect_variable): Name an expression, to avoid
9611 gcc -Wbad-function-cast warning.
112396d6 9612 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9613 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9614 (Fmake_variable_buffer_local, Fmake_local_variable):
9615 Mark variables as initialized.
52746918 9616 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9617
e5aab7e7 9618 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9619 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9620 Rename locals to avoid shadowing.
dff45157
PE
9621 (mark_stack): Move local variables into the #ifdef region where
9622 they're used.
7bc26fdb
PE
9623 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9624 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9625 needed otherwise.
9626 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9627 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9628 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9629
e5aab7e7
PE
9630 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9631 avoids undefined behavior in theory.
9632
4da60324
PE
9633 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9634
88043301
PE
9635 Use functions, not macros, for up- and down-casing (Bug#8254).
9636 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9637 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9638 to use the following functions instead of these macros.
9639 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9640 EMACS_INT, since callers assume the returned value fits in int.
9641 (upcase1): Likewise, for UPCASE_TABLE.
9642 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9643 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9644 the race-condition problem in the old DOWNCASE.
88043301 9645
19ed5445
PE
9646 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9647 Rename locals to avoid shadowing.
9648 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9649 (regex_compile, re_search_2, re_match_2_internal):
9650 Remove unused local vars.
952db0d7
PE
9651 (FREE_VAR): Rewrite so as not to use empty "else",
9652 which gcc can warn about.
da053e48 9653 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9654 (RETALLOC_IF): Define only if needed.
9655 (WORDCHAR_P): Likewise. This one is never needed, but is used
9656 only in a comment talking about a compiler bug, so put inside
9657 the #if 0 of that comment.
9658 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9659 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9660 Remove; unused.
19ed5445 9661
1f3561e4 9662 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9663 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9664 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9665
ded6f8f7
PE
9666 * search.c (simple_search): Remove unused var.
9667
dbd37a95
PE
9668 * dired.c (compile_pattern): Move decl from here ...
9669 * lisp.h: ... to here, so that it can be checked.
9670 (struct re_registers): New forward decl.
9671
7e47afad
PE
9672 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9673
85f24f61
PE
9674 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9675 All uses changed.
9676 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9677 Rename locals to avoid shadowing.
5671df8f 9678 (Fvertical_motion): Mark locals as initialized.
85f24f61 9679
181aa2be 9680 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9681 (casify_region): Mark local as initialized.
181aa2be 9682
930d429c
PE
9683 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9684
7082eac6
PE
9685 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9686 New macros, so that the caller can use some names other than
9687 gcpro1, gcpro2, etc.
9688 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9689 of the new macros.
9690 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9691 argument, for consistency with GCPRO2_VAR, etc: it is now the
9692 prefix of the variable, not the variable itself. All uses
9693 changed.
38b2c076
PE
9694 * dired.c (directory_files_internal, file_name_completion):
9695 Rename locals to avoid shadowing.
9696
15206ed9
PE
9697 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9698 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9699 dired.c's scmp function, had undefined behavior.
9700 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9701 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9702 * buffer.h: ... to here, because these macros use current_buffer,
9703 and the new implementation with inline functions needs to have
9704 current_buffer in scope now, rather than later when the macros
9705 are used.
9706 (downcase, upcase1): New static inline functions.
9707 (DOWNCASE, UPCASE1): Reimplement using these functions.
9708 This avoids undefined behavior in expressions like
9709 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9710 from race conditions in accessing the global variables
9711 case_temp1 and case_temp2.
9712 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9713 * lisp.h (case_temp1, case_temp2): Remove their decls.
9714 * character.h (ASCII_CHAR_P): Move from here ...
9715 * lisp.h: ... to here, so that the inline functions mentioned
9716 above can use them.
9717
4a6bea26
PE
9718 * dired.c (directory_files_internal_unwind): Now static.
9719
f14b7e14
PE
9720 * fileio.c (file_name_as_directory, directory_file_name):
9721 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9722 Now static.
2893f146
PE
9723 (file_name_as_directory): Use const pointers when appropriate.
9724 (Fexpand_file_name): Likewise. In particular, newdir might
9725 point at constant storage, so make it a const pointer.
fd4ead52 9726 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9727 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9728 signedness issues.
f839df0c
PE
9729 (Fset_file_times, Finsert_file_contents, auto_save_error):
9730 Rename locals to avoid shadowing.
f14b7e14 9731
5716756e 9732 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9733 (Ftry_completion, Fall_completions): Rename or remove locals
9734 to avoid shadowing.
5716756e 9735
b4c3046a
PE
9736 * marker.c (bytepos_to_charpos): Remove; unused.
9737
b45db522
PE
9738 * lisp.h (verify_bytepos, count_markers): New decls,
9739 so that gcc does not warn that these functions aren't declared.
9740
85876d07
PE
9741 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9742 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9743 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9744 (copy_text): Remove unused local var.
85876d07 9745
03d78a21 9746 * filelock.c (within_one_second): Now static.
b3dd38ab 9747 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9748
5df8f01b
PE
9749 * buffer.c (fix_overlays_before): Mark locals as initialized.
9750 (fix_start_end_in_overlays): Likewise. This function should be
9751 simplified by using pointers-to-pointers, but that's a different
9752 matter.
b1d876f1 9753 (switch_to_buffer_1): Now static.
8f54f30a
PE
9754 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9755 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9756
a70072c9 9757 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9758 Fix pointer signedness issue.
edced198
PE
9759 (sys_subshell): Mark local as volatile if checking for lint,
9760 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9761 (MAXPATHLEN): Define only if needed.
a70072c9 9762
a0977c44
PE
9763 * process.c (serial_open, serial_configure): Move decls from here ...
9764 * systty.h: ... to here, so that they can be checked.
9765
a884fdcc
PE
9766 * fns.c (get_random, seed_random): Move extern decls from here ...
9767 * lisp.h: ... to here, so that they can be checked.
9768
604efe86 9769 * sysdep.c (reset_io): Now static.
b8950c94 9770 (wait_for_termination_signal): Remove; unused.
604efe86 9771
38fc62d9
PE
9772 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9773 (copy_keymap_item, append_key, push_text_char_description):
9774 Now static.
1004a21a 9775 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9776 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9777 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9778 (describe_map_tree):
9779 Rename locals to avoid shadowing.
38fc62d9 9780
2f2650da
PE
9781 * keyboard.c: Declare functions static if they are not used elsewhere.
9782 (echo_char, echo_dash, cmd_error, top_level_2):
9783 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9784 (read_char, kbd_buffer_get_event, make_lispy_position):
9785 (make_lispy_event, make_lispy_movement, apply_modifiers):
9786 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9787 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9788 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9789 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9790 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9791
a053e86c 9792 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9793 (mark_kboards): Move decl here ...
9794 * alloc.c (mark_kboards): ... from here.
a053e86c 9795
4752793e
PE
9796 * lisp.h (force_auto_save_soon): New decl.
9797
74f10ca7 9798 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9799 (DEFINE_DUMMY_FUNCTION): New macro.
9800 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9801 Use it.
c03cd23f
PE
9802 (main): Add casts to avoid warnings
9803 if GCC considers string literals to be constants.
74f10ca7 9804
022e70d4
PE
9805 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9806
59d6fe83
PE
9807 * dbusbind.c: Pointer signedness fixes.
9808 (xd_signature, xd_append_arg, xd_initialize):
9809 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9810 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9811 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9812 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9813
78320123
PE
9814 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9815 if GCC considers string literals to be constants.
49cebcca 9816 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9817
35ac2a97
SM
98182011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9819
fb103ca9
SM
9820 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9821 (print_preprocess, print_object): New macro to fix last change.
9822
35ac2a97
SM
9823 * print.c (print_preprocess): Don't forget font objects.
9824
62973b41
JB
98252011-03-16 Juanma Barranquero <lekktu@gmail.com>
9826
9827 * emacs.c (USAGE3): Doc fixes.
9828
0e48bb22
AS
98292011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9830
9831 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9832 structure.
9833
7684e57b
JB
98342011-03-14 Juanma Barranquero <lekktu@gmail.com>
9835
9836 * lisp.h (VWindow_system, Qfile_name_history):
9837 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9838 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9839 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9840
9841 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9842 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9843
9844 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9845 * w32console.c (detect_input_pending, read_input_pending)
9846 (encode_terminal_code):
9847 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9848 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9849 (w32_system_caret_y, Qfile_name_history):
9850 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9851 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9852 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9853 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9854 * w32proc.c (Qlocal, report_file_error):
9855 * w32term.c (Vwindow_system, updating_frame):
9856 * w32uniscribe.c (initialized, uniscribe_font_driver):
9857 Remove unneeded extern declarations.
9858
2aa46d6c
CY
98592011-03-14 Chong Yidong <cyd@stupidchicken.com>
9860
c96bbc66 9861 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9862
cffc6f3b
CY
98632011-03-13 Chong Yidong <cyd@stupidchicken.com>
9864
9865 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9866 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9867 These macros can no longer be used for assignment.
9868
44f230aa
SM
9869 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9870 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9871 (record_buffer_markers, fetch_buffer_markers): New functions for
9872 recording and fetching special buffer markers.
9873 (set_buffer_internal_1, set_buffer_temp): Use them.
9874
9875 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9876
9877 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9878
9879 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9880 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9881
9882 * xdisp.c (hscroll_window_tree):
9883 (reconsider_clip_changes): Use PT instead of BUF_PT.
9884
d251f04b
EZ
98852011-03-13 Eli Zaretskii <eliz@gnu.org>
9886
9887 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9888 $(EMACS_ROOT)/lib/intprops.h.
9889
f0c77cd1
PE
98902011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9891
3eca4629
PE
9892 Fix more problems found by GCC 4.5.2's static checks.
9893
7c86ee98
PE
9894 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9895 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9896 (xg_free_frame_widgets): Make it clear that a local variable is
9897 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9898 (gdk_window_get_screen): Make it clear that this macro is needed
9899 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9900 (int_gtk_range_get_value): New function, which avoids a diagnostic
9901 from gcc -Wbad-function-cast.
9902 (xg_set_toolkit_scroll_bar_thumb): Use it.
9903 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9904 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9905 (get_utf8_string, xg_get_file_with_chooser):
9906 Rename locals to avoid shadowing.
9907 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9908
41729b81
PE
9909 * xgselect.c (xg_select): Remove unused var.
9910
f0c77cd1
PE
9911 * image.c (four_corners_best): Mark locals as initialized.
9912 (gif_load): Initialize transparent_p to zero (Bug#8238).
9913 Mark another local as initialized.
ec6cf4c6 9914 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9915
ce0ad53d 9916 * image.c (clear_image_cache): Now static.
d5d5a617 9917 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9918 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9919 (x_edge_detection): Remove unnecessary cast that
9920 gcc -Wbad-function-cast diagnoses.
2037898d 9921 (gif_load): Fix pointer signedness.
6ae141d6
PE
9922 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9923 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9924
33383987 99252011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9926
d32df629
PE
9927 Improve quality of tests for time stamp overflow.
9928 For example, without this patch (encode-time 0 0 0 1 1
9929 1152921504606846976) returns the obviously-bogus value (-948597
9930 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9931 reports time overflow. See
9932 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9933 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9934 * editfns.c: Include limits.h and intprops.h.
9935 (TIME_T_MIN, TIME_T_MAX): New macros.
9936 (time_overflow): Move earlier, to before first use.
9937 (hi_time, lo_time): New functions, for an accurate test for
9938 out-of-range times.
9939 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9940 (Fget_internal_run_time): Don't assume time_t fits in int.
9941 (make_time): Use list2 instead of Fcons twice.
9942 (Fdecode_time): More accurate test for out-of-range times.
9943 (check_tm_member): New function.
9944 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9945 (lisp_time_argument): Don't rely on undefined left-shift and
9946 right-shift behavior when checking for time stamp overflow.
8be6f318 9947
fe31d94c
PE
9948 * editfns.c (time_overflow): New function, refactoring common code.
9949 (Fformat_time_string, Fdecode_time, Fencode_time):
9950 (Fcurrent_time_string): Use it.
9951
8be6f318
PE
9952 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9953 * dired.c (make_time): Move to ...
9954 * editfns.c (make_time): ... here.
9955 * systime.h: Note the move.
9956
09d9db2c 99572011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9958
126bc0dc
YM
9959 * fringe.c (update_window_fringes): Remove unused variables.
9960
c47cbdfd
YM
9961 * unexmacosx.c (copy_data_segment): Also copy __got section.
9962 (Bug#8223)
9963
7ac80be9
EZ
99642011-03-12 Eli Zaretskii <eliz@gnu.org>
9965
c96bbc66 9966 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9967 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9968 Constify `char *' arguments and their references according to
9969 prototypes in tparam.h.
9970
ecb0f94d 9971 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9972
7ac80be9
EZ
9973 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9974 Adapt all references accordingly.
9975
9976 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9977
ef1fd07e
TT
99782011-03-11 Tom Tromey <tromey@redhat.com>
9979
9980 * buffer.c (syms_of_buffer): Remove obsolete comment.
9981
7ef4b50c
EZ
99822011-03-11 Eli Zaretskii <eliz@gnu.org>
9983
9984 * termhooks.h (encode_terminal_code): Declare prototype.
9985
9986 * msdos.c (encode_terminal_code): Don't declare prototype.
9987
9988 * term.c (encode_terminal_code): Now external again, used by
9989 w32console.c and msdos.c.
9990
44f230aa
SM
9991 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9992 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9993
4b1ec863 99942011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9995
1714f52b 9996 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9997
4b1ec863
PE
9998 * fringe.c (update_window_fringes): Mark locals as initialized
9999 (Bug#8227).
10000 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 10001
524c7aa6
PE
10002 * alloc.c (mark_fringe_data): Move decl from here ...
10003 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10004 to check its interface.
10005 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10006
a5c0af81 10007 * fontset.c (free_realized_fontset): Now static.
7519b8cd 10008 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 10009 (fontset_font): Mark local as initialized.
a9a06e0b 10010 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 10011
b4716021
PE
10012 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10013
811e9bac 10014 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 10015 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
10016 (x_own_selection, Fx_disown_selection_internal): Rename locals
10017 to avoid shadowing.
10018 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 10019
7e3ab302
PE
10020 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10021 so that the caller can use some name other than gcpro1.
10022 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
10023 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10024 (Fx_backspace_delete_keys_p):
10025 Use them to avoid shadowing, and rename vars to avoid shadowing.
10026 (x_decode_color, x_set_name, x_window): Now static.
6b437900 10027 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 10028 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
10029 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10030 Remove unused locals.
7e3ab302
PE
10031 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10032 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10033 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10034 macros.
f78faa98 10035
e2b13473
PE
10036 * xterm.h (x_mouse_leave): New decl.
10037
77f23912
PE
10038 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10039 Remove unused functions.
cdf4ba58
PE
10040 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10041 (x_calc_absolute_position): Now static.
7411c686 10042 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 10043 Don't declare local "event" unless it's used.
ed7bf3a5
PE
10044 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10045 unless they are used.
38d0b34a
PE
10046 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10047 (x_fatal_error_signal): Remove; not used.
a6067996
PE
10048 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10049 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10050 (x_error_catcher, x_connection_closed, x_error_handler):
10051 (x_error_quitter, xembed_send_message, x_iconify_frame):
10052 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 10053 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 10054 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 10055
44f230aa
SM
10056 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10057 Rename or move locals to avoid shadowing.
6b463e58 10058 (tty_defined_color, merge_face_heights): Now static.
5967d051 10059 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
10060 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10061 does not deduce is never used uninitialized.
73719eba
PE
10062 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10063 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 10064
426994c3 10065 * terminal.c (store_terminal_param): Now static.
5489860b 10066
032f1620 10067 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 10068 (set_frame_menubar): Remove unused local.
d4323972 10069 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
10070 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10071 since they might point to immutable storage.
281585b0
PE
10072 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10073 since it's unused otherwise.
032f1620 10074
367c19e5 10075 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 10076 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
10077 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10078 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 10079 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
10080 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10081 does not deduce are never used uninitialized.
70739cbe 10082
07b48fa9
PE
10083 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10084
8868a238 10085 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
10086 * window.c (window_loop, size_window):
10087 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 10088
7e5cf297 10089 * window.c (display_buffer): Now static.
d6550a9f
PE
10090 (size_window): Mark variables that gcc -Wuninitialized
10091 does not deduce are never used uninitialized.
a586633d
PE
10092 * window.h (check_all_windows): New decl, to forestall
10093 gcc -Wmissing-prototypes diagnostic.
5b555da1 10094 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 10095
f6095868
PE
10096 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10097 shadowing.
10098 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
10099 Include <limits.h>.
10100 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10101 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
10102 (load_charset_map): Mark variables that gcc -Wuninitialized
10103 does not deduce are never used uninitialized.
53df7c11 10104 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 10105
f38b440c
PE
10106 * coding.c (coding_set_source, coding_set_destination):
10107 Use "else { /* comment */ }" rather than "else /* comment */;"
10108 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
10109 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10110 a block, when the outer 'i' will do.
10111 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10112 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10113 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10114 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10115 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10116 Rename locals to avoid shadowing.
10117 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
10118 * coding.c (emacs_mule_char, encode_invocation_designation):
10119 Now static, since they're not used elsewhere.
413bb2db 10120 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 10121 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
10122 (decode_coding_emacs_mule): Mark variables that gcc
10123 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
10124 (detect_coding_iso_2022): Initialize a local variable that might
10125 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 10126 this initialization is needed. (Bug#8211)
5f58e762
PE
10127 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10128 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10129 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10130 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10131 Remove unused macros.
f38b440c 10132
232b38b9 10133 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 10134 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 10135 * character.c (string_count_byte8): Likewise.
232b38b9 10136
fb90da1b
PE
10137 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10138 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10139
fb93dbc2
PE
10140 * chartab.c (copy_sub_char_table): Now static, since it's not used
10141 elsewhere.
5c156ace
PE
10142 (sub_char_table_ref_and_range, char_table_ref_and_range):
10143 Rename locals to avoid shadowing.
bbcd0949 10144 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10145
7d3b3862 10146 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10147 (BIDI_BOB): Remove unused macro.
7d3b3862 10148
6be7d3da
PE
10149 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10150 deduce are never used uninitialized.
c2ed9c8b 10151 * term.c (encode_terminal_code): Likewise.
6be7d3da 10152
75f8807f 10153 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10154
50938595
PE
10155 * tparam.h: New file.
10156 * term.c, tparam.h: Include it.
10157 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10158 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10159 Move these decls to tparam.h, and make them agree with what
10160 is actually in tparam.c. The previous trick of using incompatible
10161 decls in different modules does not conform to the C standard.
10162 All callers of tparam changed to use tparam's actual API.
10163 * tparam.c (tparam1, tparam, tgoto):
10164 Use const pointers where appropriate.
10165
fbceeba2
PE
10166 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10167 * cm.h (struct cm): Likewise.
10168 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10169 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10170 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10171 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10172 (turn_on_face, init_tty): Likewise.
10173 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10174
7f3f1250
PE
10175 * term.c (term_mouse_position): Rename local to avoid shadowing.
10176
e6ca6543
PE
10177 * alloc.c (mark_ttys): Move decl from here ...
10178 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10179
c40f8d15
AS
101802011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10181
10182 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10183
cfe0661d
JB
101842011-03-09 Juanma Barranquero <lekktu@gmail.com>
10185
10186 * search.c (compile_pattern_1): Remove argument regp, unused since
10187 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10188 (compile_pattern): Don't pass it.
10189
0afb4571
J
101902011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10191
10192 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10193 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10194 for ! HAVE_GTK3.
10195 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10196
10197 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10198
10199 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10200 gdk_window_get_screen, gdk_window_get_geometry,
10201 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10202 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10203 (xg_get_pixbuf_from_pixmap): New function.
10204 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10205 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10206 Call xg_get_pixbuf_from_pixmap instead of
10207 gdk_pixbuf_get_from_drawable.
10208 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10209 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10210 (xg_check_special_colors): Use GtkStyleContext and its functions
10211 for HAVE_GTK3.
10212 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10213 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10214 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10215 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10216 Call gtk_widget_get_preferred_size.
0afb4571
J
10217 (xg_frame_resized): gdk_window_get_geometry only takes 5
10218 parameters.
44f230aa
SM
10219 (xg_win_to_widget, xg_event_is_for_menubar):
10220 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10221 (xg_set_widget_bg): New function.
10222 (delete_cb): New function.
895009e1 10223 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10224 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10225 (xg_set_background_color): Call xg_set_widget_bg.
10226 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10227 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10228 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10229 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10230 if ! HAVE_GTK3.
10231 (update_frame_tool_bar): Call gtk_widget_hide.
10232 (xg_initialize): Use GDK_KEY_g.
10233
10234 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10235 if ! HAVE_GTK3
10236 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10237
10238 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10239 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10240 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10241
1c2cc4ef
JB
102422011-03-08 Juanma Barranquero <lekktu@gmail.com>
10243
10244 * w32xfns.c (select_palette): Check success of RealizePalette against
10245 GDI_ERROR, not zero.
10246
33383987 10247See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10248
10249;; Local Variables:
10250;; coding: utf-8
aac0c6e3
MR
10251;; End:
10252
2f097256 10253 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10254
10255 This file is part of GNU Emacs.
10256
10257 GNU Emacs is free software: you can redistribute it and/or modify
10258 it under the terms of the GNU General Public License as published by
10259 the Free Software Foundation, either version 3 of the License, or
10260 (at your option) any later version.
10261
10262 GNU Emacs is distributed in the hope that it will be useful,
10263 but WITHOUT ANY WARRANTY; without even the implied warranty of
10264 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10265 GNU General Public License for more details.
10266
10267 You should have received a copy of the GNU General Public License
10268 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.