Macro-expand interpreted code during load.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
972debf2
SM
12012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
4 eager (load-time) macro-expansion.
5 * lisp.mk (lisp): Add macroexp.
6
1088b922
PE
72012-09-04 Paul Eggert <eggert@cs.ucla.edu>
8
9 Simplify redefinition of 'abort' (Bug#12316).
10 Do not try to redefine the 'abort' function. Instead, redo
11 the code so that it calls 'emacs_abort' rather than 'abort'.
12 This removes the need for the NO_ABORT configure-time macro
13 and makes it easier to change the abort code to do a backtrace.
14 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
15 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
16 Remove; sysdep.c's emacs_abort now takes its place.
17 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
18 'abort' changed to use 'emacs_abort'.
19 * msdos.c (dos_abort) [defined abort]: Remove; not used.
20 (abort) [!defined abort]: Rename to ...
21 (emacs_abort): ... new name.
22 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
23 the place of the old 'abort' in emacs.c.
24 * w32.c, w32fns.c (abort): Do not #undef.
25 * w32.c (emacs_abort): Rename from w32_abort.
26
30934d33
EZ
272012-09-04 Eli Zaretskii <eliz@gnu.org>
28
29 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
30 offsets[j].dv, since the y axis of the screen coordinates points
31 down, while the y axis of the font definition coordinates points
32 up. This fixes display of Arabic diacritics such as KASRA and
33 KASRATAN. (Bug#11860)
34
af26b72c
PE
352012-09-04 Paul Eggert <eggert@cs.ucla.edu>
36
37 Be more systematic about _setjmp vs setjmp.
38 * alloc.c (test_setjmp, mark_stack):
39 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
40 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
41 (png_load, my_error_exit, jpeg_load):
42 * process.c (send_process_trap, send_process):
43 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
44 The underscored versions are up to 30x faster on some hosts.
45 Formerly, the code used setjmp+longjmp sometimes and
46 _setjmp+_longjmp at other times, with no particular reason to
47 prefer setjmp+longjmp.
48
26d4541d
PE
492012-09-03 Paul Eggert <eggert@cs.ucla.edu>
50
d42f4f0f 51 Fix minor problem found by static checking.
26d4541d 52 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 53
c5e28e39
MR
542012-09-03 Martin Rudalics <rudalics@gmx.at>
55
56 * buffer.c (Fdelete_all_overlays): New function.
57
3eab3ca9
CY
582012-09-03 Chong Yidong <cyd@gnu.org>
59
60 * gtkutil.c: Add extern decl for Qxft.
61
c04889f8
PE
622012-09-02 Paul Eggert <eggert@cs.ucla.edu>
63
1882aa38
PE
64 * emacs.c, eval.c: Use bool for boolean.
65 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
66 (malloc_using_checking) [DOUG_LEA_MALLOC]:
67 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
68 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
69 (main, decode_env_path, Fdaemon_initialized):
70 * eval.c (call_debugger, Finteractive_p, interactive_p):
71 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
72 (maybe_call_debugger, Fbacktrace):
73 * process.c (read_process_output, exec_sentinel):
74 Use bool for booleans.
75 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
76 All callers changed.
77 * eval.c (interactive_p): Omit always-true boolean argument
78 EXCLUDE_SUBRS_P. All callers changed.
79 * dispextern.h, lisp.h: Reflect above API changes.
80 * firstfile.c (dummy): Use the address of 'main', whose signature
81 won't change, instead of the address of 'initialize', whose
82 signature just changed from int to bool.
83 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
84 * msdos.c (fatal_error_in_progress): ... from here.
85 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
86 of incrementing it.
87 (redisplay_internal, unwind_redisplay): Simply clear
88 REDISPLAYING_P when unwinding, instead of saving its previous,
89 always-false value and then restoring it.
90
a411ac43
PE
91 Clean up some extern decls.
92 Mostly, this hoists extern decls out of .c files and into .h files.
93 That way, we're more likely to catch errors if the interfaces change.
94 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
95 declare xg_mark_data.
96 * dispextern.h (x_frame_parm_handlers):
97 * font.h (Qxft):
98 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
99 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
100 (Qultra_bold, Qoblique, Qitalic):
101 Move extern decl here from .c file.
102 * alloc.c (xg_mark_data) [USE_GTK]:
103 * doc.c (Qclosure):
104 * eval.c (Qlexical_binding):
105 * fns.c (time) [!HAVE_UNISTD_H]:
106 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
107 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
108 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
109 * lread.c (Qinternal_interpreter_environment):
110 * minibuf.c (Qbuffer):
111 * process.c (QCfamily, QCfilter):
112 * widget.c (free_frame_faces):
113 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
114 * xfont.c (x_clear_errors):
115 * xterm.c (x_frame_parm_handlers):
116 Remove now-redundant extern decls.
117 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
118 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
119 Now static.
120 * xfaces.c: Remove unnecessary static decls.
121 * xterm.c (updating_frame): Remove decl of nonexistent object.
122
c04889f8
PE
123 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
124 when building globals.h, as the objects that are not built on
125 this host are not needed to compile C files on this host.
126
8b339673
JD
1272012-09-02 Jan Djärv <jan.h.d@swipnet.se>
128
129 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
130
131 * frame.h: Add missing prototype for x_wm_set_size_hint.
132
a08d4ba7
PE
1332012-09-02 Paul Eggert <eggert@cs.ucla.edu>
134
135 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
136 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
137 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
138 (Fsubstitute_command_keys):
139 * editfns.c (region_limit, find_field, Fconstrain_to_field)
140 (save_excursion_save, save_excursion_restore)
141 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
142 (format_time_string, general_insert_function)
143 (make_buffer_string, make_buffer_string_both)
144 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
145 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
146 (copy_text, insert_1, insert_1_both, insert_from_string)
147 (insert_from_string_before_markers, insert_from_string_1)
148 (insert_from_buffer, insert_from_buffer_1, replace_range)
149 (replace_range_2, del_range_1, del_range_byte, del_range_both)
150 (del_range_2, modify_region):
151 * intervals.c (intervals_equal, balance_possible_root_interval)
152 (adjust_intervals_for_insertion, merge_properties_sticky)
153 (graft_intervals_into_buffer, lookup_char_property)
154 (adjust_for_invis_intang, set_point_both)
155 (get_property_and_range, compare_string_intervals)
156 (set_intervals_multibyte_1, set_intervals_multibyte):
157 * keyboard.c (decode_timer):
158 Use bool for boolean.
159 * intervals.h, lisp.h, systime.h: Reflect above API changes.
160 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
161
48c948de
CY
1622012-09-02 Chong Yidong <cyd@gnu.org>
163
164 * keymap.c (push_key_description): Print M-TAB as C-M-i
165 (Bug#11758).
166
6c49a40b
JB
1672012-09-02 Juanma Barranquero <lekktu@gmail.com>
168
169 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
170 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
171 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
172 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
173 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
174 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
175 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
176
4dfbd238
EZ
1772012-09-01 Eli Zaretskii <eliz@gnu.org>
178
7e510e28
EZ
179 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
180 more than one grapheme cluster passed to the shaper: compute the
181 offset adjustment values separately for each cluster. (Bug#11860)
182
4dfbd238
EZ
183 * image.c: Restore mistakenly removed inclusion of w32.h. Without
184 it, GCC doesn't see prototypes of w32_delayed_load, and complains
185 about implicit conversions from integer to pointer.
186
86571ae0
DC
1872012-09-01 Daniel Colascione <dancol@dancol.org>
188
189 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
190 system used too early.
191
0e23ef9d
PE
1922012-09-01 Paul Eggert <eggert@cs.ucla.edu>
193
194 Better seed support for (random).
195 * emacs.c (main): Call init_random.
196 * fns.c (Frandom): Set the seed from a string argument, if given.
197 Remove long-obsolete Gentzel cruft.
198 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
199 (init_random): New function.
200
17a2cbbd
DC
2012012-09-01 Daniel Colascione <dancol@dancol.org>
202
203 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
204 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
205 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
206 x_wm_set_size_hint, x_query_colors, x_real_positions,
207 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
208 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
209 all of which have been moved to common code.
210
211 * xfaces.c: Include TERM_HEADER instead of listing all possible
212 window-system headers.
213
214 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
215 to match header.
216
217 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
218 directly accessing frame internals.
219
f18cbb28 220 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
221 globals_of_w32font.
222
223 * process.c: Include TERM_HEADER instead of listing all possible
224 window-system headers.
225
226 * nsterm.h: Remove declarations now in frame.h. Define
227 FRAME_X_SCREEN, FRAME_X_VISUAL.
228
229 * menu.c: Include TERM_HEADER instead of listing all possible
230 window-system headers.
231
232 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
233 window system.
234
235 * keyboard.c: Include TERM_HEADER instead of listing all possible
236 window-system headers.
237
238 * image.c: Include TERM_HEADER instead of listing all possible
239 window-system headers. Declare Vlibrary_cache when compiling for
240 Windows.
241
242 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
243 window system declarations.
244
245 * frame.h: Move common functions here: set_frame_menubar,
246 x_set_window_size, x_sync, x_get_focus_frame,
247 x_set_mouse_position, x_set_mouse_pixel_position,
248 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
249 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
250 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
251 x_activate_menubar, x_real_positions, x_bitmap_icon,
252 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
253 and x_query_colors.
254
255 * frame.c: Include TERM_HEADER instead of listing all possible
256 window-system headers.
257
258 * font.c: Include TERM_HEADER instead of listing all possible
259 window-system headers.
260
261 * emacs.c: Include TERM_HEADER.
262
f18cbb28
EZ
263 * dispnew.c: Include TERM_HEADER instead of listing all possible
264 window-system headers.
17a2cbbd 265
f18cbb28 266 * ccl.h: Include character.h.
17a2cbbd
DC
267
268 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
269 the current window system; include in list of objects to link into
270 Emacs.
271
c650a5de
DA
2722012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
273
274 Remove mark_ttys function and fix tty_display_info initialization.
275 * lisp.h (mark_ttys): Remove prototype.
276 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
277 to mark_ttys because all possible values of 'top_frame' slot are
278 the frames which are reachable from Vframe_list.
279 * term.c (mark_ttys): Remove.
280 (init_tty): Safely initialize 'top_frame' slot with Qnil.
281
4e0f6479
DA
2822012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
283
284 Change struct frame bitfields from unsigned char to unsigned.
285 * frame.h (struct frame): Change type of 'display_preempted',
286 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
287 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
288 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
289 bitfields from unsigned char to unsigned.
290
8b96a52c
DA
2912012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
292
293 Remove unused member of struct x_output and struct w32_output.
294 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
295 * w32term.h (struct w32_output): Likewise.
296
b4444c8a
JD
2972012-08-30 Jan Djärv <jan.h.d@swipnet.se>
298
299 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
300 does not become zero (Bug#12234).
301
b98521db
PE
3022012-08-30 Paul Eggert <eggert@cs.ucla.edu>
303
304 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
305 for GCC 4.7.1 x86-64.
306
31d02438
GM
3072012-08-30 Glenn Morris <rgm@gnu.org>
308
309 * lread.c (init_lread): For out-of-tree builds, only add the
310 source directory's site-lisp dir to the load-path if it exists,
311 consistent with in-tree builds. (Bug#12302)
312
7f8941d8
JD
3132012-08-28 Jan Djärv <jan.h.d@swipnet.se>
314
315 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
316 button_values to NULL. Call setStykeMask so dialogs get a close button.
317 (windowShouldClose:): Set window_closed.
318 (dealloc): New member, free button_values.
319 (process_dialog:): Make member function. Remove window argument,
320 replace window with self. Count buttons and allocate and store values
321 in button_values.
322 (addButton:value:row:): value is int with the name tag. Call setTag
323 with tag. Remove return self, declare return value as void.
324 (addString:row:): Remove return self, declare return value as void.
325 (addSplit): Remove return self, declare return value as void.
326 (clicked:): Remove return self, declare return value as void.
327 Set dialog_return to button_values[seltag]. Code formatting change.
328 (initFromContents:isQuestion:): Adjust call to process_dialog.
329 Code formatting change.
330 (timeout_handler:): Set timer_fired to YES.
331 (runDialogAt:): Set timer_fired to NO.
332 Handle click on close button as quit.
333
334 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
335 Add window_closed and button_values. Add void as return value for
336 add(Button|String|Split). addButton takes int instead of Lisp_Object.
337 Add process_dialog as new member.
338
eada0861 3392012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 340
eada0861
GM
341 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
342 is not one of the heaps we manage. (Bug#12242)
343
3442012-08-28 Glenn Morris <rgm@gnu.org>
345
346 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
347
457294dd
MR
3482012-08-28 Martin Rudalics <rudalics@gmx.at>
349
350 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
351 auto-buffer-name window parameter. Install revision of reverted
352 fix.
457294dd 353
4f2daf31
DA
3542012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
355
356 Do not allow to set major mode for a dead buffer.
357 * buffer.c (Fset_buffer_major_mode): Signal an error
358 if the buffer is dead.
359 (Fother_buffer, other_buffer_safely): Remove redundant
360 nested declaration.
361
66322887
DA
3622012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
363
364 Always use set_buffer_if_live to restore original buffer at unwind.
365 * buffer.h (record_unwind_current_buffer): New function.
366 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
367 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
368 * undo.c, window.c: Adjust users.
369 * buffer.c (set_buffer_if_live): Fix comment.
370
a3d794a1
DA
3712012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
372
373 Fix usage of set_buffer_internal.
374 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
375 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
376 * coding.c (decode_coding): Omit redundant test.
377 * fileio.c (decide_coding_unwind): Likewise.
378 * fns.c (secure_hash): Likewise.
379 * insdel.c (modify_region): Likewise.
380 * keyboard.c (command_loop_1): Likewise.
381 * print.c (PRINTFINISH): Likewise.
382 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
383
59ea14cd
PE
3842012-08-27 Paul Eggert <eggert@cs.ucla.edu>
385
386 * dispnew.c: Use bool for boolean.
387 (frame_garbaged, display_completed, delayed_size_change)
388 (fonts_changed_p, add_window_display_history)
389 (add_frame_display_history, verify_row_hash)
390 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
391 (row_equal_p, realloc_glyph_pool)
392 (allocate_matrices_for_frame_redisplay)
393 (showing_window_margins_p)
394 (adjust_frame_glyphs_for_frame_redisplay)
395 (build_frame_matrix_from_leaf_window, make_current)
396 (mirrored_line_dance, mirror_line_dance, update_frame)
397 (update_window_tree, update_single_window)
398 (check_current_matrix_flags, update_window, update_text_area)
399 (update_window_line, set_window_update_flags, scrolling_window)
400 (update_frame_1, scrolling, buffer_posn_from_coords)
401 (do_pending_window_change, change_frame_size)
402 (change_frame_size_1, sit_for):
403 Use bool for boolean.
404 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
405 and remove last int (actually boolean) argument, which was always 0.
406 All callers changed.
407 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
408 * dispextern.h (struct composition_it): Use bool for boolean.
409 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
410 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
411 * dired.c (file_name_completion):
412 Use bool for boolean. (This was missed in an earlier change.)
413
95072a94
MR
4142012-08-27 Martin Rudalics <rudalics@gmx.at>
415
416 * window.c (Fset_window_configuration): Revert first part of
417 last change.
418
0f19feff
JD
4192012-08-27 Jan Djärv <jan.h.d@swipnet.se>
420
421 * nsterm.h (NSPanel): New class variable dialog_return.
422
423 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
424 dialog_return.
425 (windowShouldClose:): Use stop instead of stopModalWithCode.
426 (clicked:): Ditto, and also set dialog_return (Bug#12258).
427 (timeout_handler:): Use stop instead of abortModal. Send a dummy
428 event.
429 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
430 modal loop returns.
431
f10fe38f
PE
4322012-08-27 Paul Eggert <eggert@cs.ucla.edu>
433
de1339b0
PE
434 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
435 * composite.c (find_composition, composition_gstring_p)
436 (composition_reseat_it, find_automatic_composition):
437 * data.c (let_shadows_buffer_binding_p)
438 (let_shadows_global_binding_p, set_internal, make_blv)
439 (Fmake_variable_buffer_local, Fmake_local_variable)
440 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
441 (cons_to_signed, arith_driver):
442 * dbusbind.c (xd_in_read_queued_messages):
443 * dired.c (directory_files_internal, file_name_completion):
444 Use bool for booleans.
445 * dired.c (file_name_completion):
446 * process.h (fd_callback):
447 Omit int (actually boolean) argument. It wasn't being used.
448 All uses changed.
449 * composite.h, lisp.h: Reflect above API changes.
450
f10fe38f
PE
451 * cmds.c, coding.c: Use bool for booleans.
452 * cmds.c (move_point, Fself_insert_command):
453 * coding.h (struct composition status, struct coding_system):
454 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
455 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
456 (emacs_mule_char, decode_coding_emacs_mule)
457 (encode_coding_emacs_mule, detect_coding_iso_2022)
458 (decode_coding_iso_2022, encode_invocation_designation)
459 (encode_designation_at_bol, encode_coding_iso_2022)
460 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
461 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
462 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
463 (encode_coding_raw_text, detect_coding_charset)
464 (decode_coding_charset, encode_coding_charset, detect_eol)
465 (detect_coding, get_translation_table, produce_chars)
466 (consume_chars, reused_workbuf_in_use)
467 (make_conversion_work_buffer, code_conversion_save)
468 (decode_coding_object, encode_coding_object)
469 (detect_coding_system, char_encodable_p)
470 (Funencodable_char_position, code_convert_region)
471 (code_convert_string, code_convert_string_norecord)
472 (Fset_coding_system_priority):
473 * fileio.c (Finsert_file_contents):
474 Use bool for booleans.
475 * coding.h, lisp.h: Reflect above API changes.
476 * coding.c: Remove unnecessary static function decls.
477 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
478 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
479 not a boolean 'int', since callers never look at the return value.
480 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
481 * coding.h (decoding_buffer_size, encoding_buffer_size)
482 (emacs_mule_string_char): Remove unused extern decls.
483 (struct iso_2022_spec, struct coding_system):
484 Use 'unsigned int : 1' for boolean fields, since there's more than one.
485 (struct emacs_mule_spec): Remove unused field 'full_support'.
486 All initializations removed.
487 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
488
5474c384
DA
4892012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
490
f10fe38f 491 Fix spare memory change (Bug#12286).
5474c384
DA
492 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
493 (valid_lisp_object_p): Likewise.
494
c4b6914d
MR
4952012-08-27 Martin Rudalics <rudalics@gmx.at>
496
497 * window.c (Fset_window_configuration): Record any window's old
498 buffer if it's replaced (see Bug#8789). If the new current
499 buffer doesn't appear in the selected window, go to its old
500 point (Bug#12208).
501
35aaa1ea
DA
5022012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
503
504 Special MEM_TYPE_SPARE to denote reserved memory.
505 * alloc.c (enum mem_type): New memory type.
506 (refill_memory_reserve): Use new type for spare memory.
507 This prevents live_cons_p and live_string_p from incorrect
508 detection of uninitialized objects from spare memory as live.
509
6af64513
PE
5102012-08-26 Paul Eggert <eggert@cs.ucla.edu>
511
8b2e00a3
PE
512 Spelling fixes.
513 * Makefile.in (.PHONY): versioclean -> versionclean.
514
b52d6985
PE
515 Remove unused external symbols.
516 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
517 * window.c (Qwindow_valid_p, decode_valid_window):
518 Now static, not extern.
519 * data.c (Qinterval): Remove; unused.
520 (syms_of_data): Do not define 'interval'.
521 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
522 * window.h (decode_valid_window):
523 Remove decls.
524
d5172d4f
PE
525 * character.c, charset.c, chartab.c: Use bool for booleans.
526 * character.c (lisp_string_width, string_count_byte8)
527 (string_escape_byte8):
528 * charset.c (charset_map_loaded, load_charset_map, read_hex):
529 (load_charset_map_from_file, map_charset_chars)
530 (Fdefine_charset_internal, define_charset_internal)
531 (Fdeclare_equiv_charset, find_charsets_in_text)
532 (Ffind_charset_region, char_charset, Fiso_charset):
533 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
534 (sub_char_table_set, sub_char_table_set_range)
535 (char_table_set_range, optimize_sub_char_table)
536 (map_sub_char_table):
537 Use bool for boolean.
538 * character.c (str_to_unibyte): Omit last boolean argument; it was
539 always 0. All callers changed.
540 * character.h, charset.h: Adjust to match previous changes.
541 * character.h (char_printable_p): Remove decl of nonexistent function.
542 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
543 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
544 are all boolean, so make them single-bit bitfields.
545
6af64513
PE
546 * lisp.h (ASET): Remove attempt to detect side effects.
547 It was meant to be temporary and it often doesn't work,
548 because when IDX has side effects the behavior of IDX==IDX
549 is undefined. See Stefan Monnier in
550 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
551
e1f29348
BR
5522012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
553
554 * lisp.h (functionp): New function (extracted from Ffunctionp).
555 (FUNCTIONP): Use it.
556 * eval.c (Ffunctionp): Use it.
557
17c05d74
PE
5582012-08-25 Paul Eggert <eggert@cs.ucla.edu>
559
0f46bc75
PE
560 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
561 as that's faster and simpler than static storage. Don't bother
562 with the g_main_context_query overhead if g_main_context_pending
563 says no events are pending.
564 (gfds, gfds_size): Remove these static vars.
565 (xgselect_initialize): Remove; no longer needed.
566 All uses and decls removed.
567
ee4c0f69
PE
568 * emacs.c (fatal_error_signal_hook): Remove.
569 All uses removed. This leftover from old code was always 0.
570
17c05d74
PE
571 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
572 * casefiddle.c (casify_object, casify_region):
573 * casetab.c (set_case_table):
574 * category.c, category.h (word_boundary_p):
575 * category.h (CHAR_HAS_CATEGORY):
576 Use bool for booleans, instead of int.
577
391ceac5
EZ
5782012-08-25 Eli Zaretskii <eliz@gnu.org>
579
580 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
581
2f221583
PE
5822012-08-25 Paul Eggert <eggert@cs.ucla.edu>
583
f4a681b0
PE
584 On assertion failure, print backtrace if available.
585 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
586 (die) [ENABLE_CHECKING]: Print a backtrace if available.
587 * Makefile.in (LIB_EXECINFO): New macro.
588 (LIBES): Use it.
589
2f221583
PE
590 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
591 * bytecode.c (exec_byte_code):
592 * callint.c (check_mark, Fcall_interactively):
593 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
594 (getenv_internal, sync_process_alive, call_process_exited):
595 * lisp.h (USE_SAFE_ALLOCA):
596 Use bool for booleans, instead of int.
597 * lisp.h, process.h: Adjust prototypes to match above changes.
598 * callint.c (Fcall_interactively): Don't assume the mark's
599 offset fits in 'int'.
600
37ef52bb
PE
6012012-08-24 Paul Eggert <eggert@cs.ucla.edu>
602
603 * buffer.c, buffer.h: Use bool for boolean.
604 * buffer.c (reset_buffer_local_variables)
605 (buffer_lisp_local_variables, Fset_buffer_modified_p)
606 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
607 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
608 (overlay_touches_p, overlay_strings, Foverlay_put)
609 (report_overlay_modification, call_overlay_mod_hooks):
610 (mmap_enlarge, mmap_set_vars):
611 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
612 Use bool for booleans, instead of int.
613 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
614 since the 1-or-0 return value is always ignored anyway.
615 (mmap_initialized_p):
616 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
617 * buffer.h, lisp.h: Adjust prototypes to match above changes.
618
2cc21167
PE
6192012-08-23 Paul Eggert <eggert@cs.ucla.edu>
620
621 * bidi.c: Use bool for boolean.
622 This is a bit more readable, and makes the text segment of bidi.o
623 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
624 Presumably it's faster too.
625 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
626 Now bool.
627 (bidi_cache_find_level_change, bidi_cache_iterator_state)
628 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
629 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
630 (bidi_explicit_dir_char, bidi_level_of_next_char)
631 (bidi_find_other_level_edge, bidi_move_to_visually_next):
632 Use bool for booleans, instead of int.
633 * dispextern.h (bidi_init_it, bidi_paragraph_init)
634 (bidi_unshelve_cache): Adjust decls to match code.
635
7db4ddf4
MR
6362012-08-23 Martin Rudalics <rudalics@gmx.at>
637
638 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
639 argument.
640
b1bb8011
PE
6412012-08-23 Paul Eggert <eggert@cs.ucla.edu>
642
643 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
644 * atimer.h: Include <stdbool.h>.
645
ff687885
DN
6462012-08-22 Dan Nicolaescu <dann@gnu.org>
647
648 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
649 compile time tests instead of run time tests on systems that do
650 not use them.
651 (FRAME_MAC_P): Remove leftover from deleted code.
652 * frame.c (syms_of_frame): Remove leftover from deleted code.
653
4ce7a138
JD
6542012-08-22 Jan Djärv <jan.h.d@swipnet.se>
655
656 * nsterm.m (insertText:): Don't clear modifiers if code is space.
657
d733ec6d
PE
6582012-08-22 Paul Eggert <eggert@cs.ucla.edu>
659
660 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
661 Otherwise, the compiler complains about (A?B:C) where B is void
662 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
663 (fontset_add): Return void, for FONTSET_ADD.
664
d0d2d26f
PE
6652012-08-21 Paul Eggert <eggert@cs.ucla.edu>
666
fce31d69
PE
667 * alloc.c: Use bool for booleans.
668 (gc_in_progress, abort_on_gc)
669 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
670 (dont_register_blocks) [GC_MALLOC_CHECK]:
671 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
672 (check_string_bytes, make_specified_string, memory_full)
673 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
674 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
675 (mark_stack, valid_pointer_p, make_pure_string)
676 (Fgarbage_collect, survives_gc_p, gc_sweep):
677 Use bool for booleans, instead of int.
678 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
679 Remove unused local.
680 * alloc.c (PURE_POINTER_P):
681 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
682 * editfns.c (Fformat):
683 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
684 (Fdo_auto_save):
685 * fns.c (sweep_weak_table):
686 * lisp.h (suppress_checking, push_message, survives_gc_p)
687 (make_pure_string, gc_in_progress, abort_on_gc):
688 * lread.c (readchar, read1):
689 * print.c (Fprin1_to_string):
690 * xdisp.c (push_message):
691 Use bool for booleans affected directly or indirectly by
692 alloc.c's changes.
693
d0d2d26f
PE
694 Make recently-introduced setters macros.
695 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
696 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
697 (set_fontset_default, set_fontset_fallback): Rename from their
698 upper-case counterparts, and make them functions rather than macros.
699 This is more consistent with the other recently-introduced setters.
700 These don't need to be inline, since they're local.
701
d18e2bb6
JD
7022012-08-21 Jan Djärv <jan.h.d@swipnet.se>
703
704 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
705 the loop (Bug#12247).
706
1b9d9d16
PE
7072012-08-21 Paul Eggert <eggert@cs.ucla.edu>
708
709 * lisp.h (vcopy): Use memcpy rather than our own loop.
710 This fixes a performance regression introduced by the recent
711 addition of vcopy. This means 'vcopy' will need to be modified
712 for a copying collector, but that's OK. Also, tighten the
713 checking in the assertion.
714
b2f09701
EZ
7152012-08-21 Eli Zaretskii <eliz@gnu.org>
716
717 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
718 components for RTL text (Bug#11860). Adjust X-OFFSET of each
719 non-base glyph for the width of the base character, according to
e1f29348
BR
720 what x_draw_composite_glyph_string_foreground expects.
721 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
722 expectations, to produce correct width of the composed character.
723 Reverse the sign of the DU offset produced by ScriptPlace.
724
9b994fed
PE
7252012-08-21 Paul Eggert <eggert@cs.ucla.edu>
726
727 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
728
086ca913
DA
7292012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
730
731 Avoid direct writes to contents member of struct Lisp_Vector.
732 * lisp.h (vcopy): New function to copy data into vector.
733 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
734 * fns.c (Ffillarray): Use ASET.
735 * keyboard.c (timer_check_2): Use AREF and ASET.
736 (append_tool_bar_item, Frecent_keys): Use vcopy.
737 * lread.c (read_vector): Use ASET.
738 * msdos.c (Frecent_doskeys): Use vcopy.
739 * xface.c (Finternal_copy_lisp_face): Use vcopy.
740 (Finternal_merge_in_global_face): Use ASET and vcopy.
741 * xfont.c (xfont_list_pattern): Likewise.
742
5481664a
MR
7432012-08-21 Martin Rudalics <rudalics@gmx.at>
744
745 * window.c (Fwindow_point): For the selected window always return
746 the position of its buffer's point.
747 (Fset_window_point): For the selected window always go in its
748 buffer to the specified position.
749
6d470bdd
DA
7502012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
751
752 Setter macros for fontsets.
753 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
754 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
755 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
756 Adjust users.
757
24564fe1
GM
7582012-08-20 Glenn Morris <rgm@gnu.org>
759
760 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
761 Don't assume that `ln -f' works.
762
0a05a035
EZ
7632012-08-20 Eli Zaretskii <eliz@gnu.org>
764
765 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
766 and later about non-assignments with no effect. See discussion at
767 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
768 details.
769
e46f2325
DA
7702012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
771
772 Inline setter functions for Lisp_Objects slots of struct specbinding.
773 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
774 Adjust users.
775
734fbd86
MR
7762012-08-20 Martin Rudalics <rudalics@gmx.at>
777
778 * window.c (select_window): Always make selected window's buffer
779 current.
780
f1a95992
DA
7812012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
782
783 Use AREF and ASET for docstrings of category tables.
784 * category.h (CATEGORY_DOCSTRING): Use AREF.
785 (SET_CATEGORY_DOCSTRING): Use ASET.
786 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
787
e83064be
DA
7882012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
789
790 Inline setter functions for hash table members.
791 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
792 (set_hash_hash, set_hash_index): Rename with _slot suffix.
793 (set_hash_key_and_value, set_hash_index, set_hash_next)
794 (set_hash_hash): New functions.
795 * charset.c, fns.c: Adjust users.
796
4ce60d2e
DA
7972012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
798
799 Inline getter and setter functions for per-buffer values.
800 * buffer.h (per_buffer_default, set_per_buffer_default)
801 (per_buffer_value, set_per_buffer_value): New functions.
802 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
803 * buffer.c, data.c: Adjust users.
804
c06c9690
JB
8052012-08-20 Juanma Barranquero <lekktu@gmail.com>
806
807 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
808
32bd4250
PE
8092012-08-19 Paul Eggert <eggert@cs.ucla.edu>
810
bad03192 811 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
812 as gnulib does this if the system doesn't.
813 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
814 Remove declaration. MS-Windows declares it on stdlib.h which is
815 included by conf_post.h.
b69a6d22
PE
816 * emacs.c (environ) [DOUG_LEA_MALLOC]:
817 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
818 * vm-limit.c: Include <unistd.h>, for 'environ'.
819
22d7feb2
PE
820 * unexaix.c, unexcoff.c: Include "mem-limits.h".
821 (start_of_data): Remove decl; mem-limits.h provides it.
822
32bd4250
PE
823 * xdisp.c (handle_invisible_prop): Make it a bit faster
824 and avoid a gcc -Wmaybe-uninitialized diagnostic.
825
450809af
CY
8262012-08-19 Chong Yidong <cyd@gnu.org>
827
828 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
829 ends (Bug#3874).
830
9e677988
AS
8312012-08-19 Andreas Schwab <schwab@linux-m68k.org>
832
6b1319ce
AS
833 * .gdbinit: Use call instead of set when calling a function in the
834 inferior.
835
9e677988
AS
836 * data.c (set_internal): Don't use set_blv_found.
837 (Fkill_local_variable): Likewise.
838
d7191076
AA
8392012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
840
841 * nsfont.m (ns_ascii_average_width): Ensure the string
842 ascii_printable is initialized with a null-terminated character
843 array. Otherwise, it can contain undesired extra characters.
844
e757f1c6
PE
8452012-08-18 Paul Eggert <eggert@cs.ucla.edu>
846
847 port new setting code to Sun C 5.8 2005/10/13
848 * chartab.c, lisp.h (char_table_set, char_table_set_range):
849 Return void, not Lisp_Object. Otherwise, the compiler
850 complains about (A?B:C) where B is void and C is Lisp_Object
851 when compiling CHAR_TABLE_SET, due to the recent change to
852 the API of sub_char_table_set_contents.
853
a999ce26
CY
8542012-08-18 Chong Yidong <cyd@gnu.org>
855
856 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
857 for the string case (Bug#3874).
858
3f22b86f
PE
8592012-08-18 Paul Eggert <eggert@cs.ucla.edu>
860
39eb03f1
PE
861 * buffer.h (BSET): Remove (Bug#12215).
862 Replace all uses with calls to new setter functions.
863 (bset_bidi_paragraph_direction, bset_case_canon_table)
864 (bset_case_eqv_table, bset_directory, bset_display_count)
865 (bset_display_time, bset_downcase_table)
866 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
867 (bset_last_selected_window, bset_local_var_alist)
868 (bset_mark_active, bset_point_before_scroll, bset_read_only)
869 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
870 (bset_width_table):
871 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
872 (bset_auto_fill_function, bset_auto_save_file_format)
873 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
874 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
875 (bset_cache_long_line_scans, bset_case_fold_search)
876 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
877 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
878 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
879 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
880 (bset_header_line_format, bset_indicate_buffer_boundaries)
881 (bset_indicate_empty_lines, bset_invisibility_spec)
882 (bset_left_fringe_width, bset_major_mode, bset_mark)
883 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
884 (bset_name, bset_overwrite_mode, bset_pt_marker)
885 (bset_right_fringe_width, bset_save_length)
886 (bset_scroll_bar_width, bset_scroll_down_aggressively)
887 (bset_scroll_up_aggressively, bset_selective_display)
888 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
889 (bset_word_wrap, bset_zv_marker):
890 * category.c (bset_category_table):
891 * syntax.c (bset_syntax_table):
892 New setter functions.
893
6a09a33b
PE
894 * process.h (PSET): Remove (Bug#12215).
895 Replace all uses with calls to new setter functions.
896 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
897 (PROCESS_INLINE): New macro.
898 (pset_childp): New setter function.
899 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
900 * process.c (PROCESS_INLINE):
901 Define to EXTERN_INLINE, so that the corresponding functions
902 are compiled into code.
903 (pset_buffer, pset_command, pset_decode_coding_system)
904 (pset_decoding_buf, pset_encode_coding_system)
905 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
906 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
907 (pset_type, pset_write_queue): New setter functions.
908
e8c17b81
PE
909 * window.h (WSET): Remove (Bug#12215).
910 Replace all uses with calls to new setter functions.
911 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
912 (WINDOW_INLINE): New macro.
913 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
914 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
915 (wset_total_lines, wset_vertical_scroll_bar)
916 (wset_window_end_pos, wset_window_end_valid)
917 (wset_window_end_vpos): New setter functions.
918 * window.c (WINDOW_INLINE):
919 Define to EXTERN_INLINE, so that the corresponding functions
920 are compiled into code.
921 (wset_combination_limit, wset_dedicated, wset_display_table)
922 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
923 (wset_new_normal, wset_new_total, wset_next_buffers)
924 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
925 (wset_prev_buffers, wset_right_fringe_width)
926 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
927 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
928 (wset_window_parameters):
929 * xdisp.c (wset_base_line_number, wset_base_line_pos)
930 (wset_column_number_displayed, wset_region_showing):
931 New setter functions.
932
3f22b86f
PE
933 * termhooks.h (TSET): Remove (Bug#12215).
934 Replace all uses with calls to new setter functions.
935 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
936 (TERMHOOKS_INLINE): New macro.
937 (tset_charset_list, tset_selection_alist): New setter functions.
938 * terminal.c (TERMHOOKS_INLINE):
939 Define to EXTERN_INLINE, so that the corresponding functions
940 are compiled into code.
941 (tset_param_alist): New setter function.
942
742af32f
PE
9432012-08-17 Paul Eggert <eggert@cs.ucla.edu>
944
15dbb4d6
PE
945 * keyboard.h (KSET): Remove (Bug#12215).
946 Replace all uses with calls to new setter functions.
947 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
948 (KEYBOARD_INLINE): New macro.
949 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
950 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
951 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
952 New setter functions.
953 * keyboard.c (KEYBOARD_INLINE):
954 Define to EXTERN_INLINE, so that the corresponding functions
955 are compiled into code.
956 (kset_echo_string, kset_kbd_queue)
957 (kset_keyboard_translate_table, kset_last_prefix_arg)
958 (kset_last_repeatable_command, kset_local_function_key_map)
959 (kset_overriding_terminal_local_map, kset_real_last_command)
960 (kset_system_key_syms): New setter functions.
961
f00af5b1
PE
962 * frame.h (FSET): Remove (Bug#12215).
963 Replace all uses with calls to new setter functions.
964 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
965 (FRAME_INLINE): New macro.
966 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
967 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
968 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
969 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
970 (fset_param_alist, fset_root_window, fset_scroll_bars)
971 (fset_selected_window, fset_title, fset_tool_bar_items)
972 (fset_tool_bar_position, fset_tool_bar_window): New functions.
973 * frame.c (FRAME_INLINE):
974 Define to EXTERN_INLINE, so that the corresponding functions
975 are compiled into code.
976 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
977
0c94c8d6
PE
978 A few more naming-convention fixes for getters and setters.
979 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
980 and rename from buffer_overlays_set_before.
981 (set_buffer_overlays_after): Move here from buffer.h, and rename
982 from buffer_overlays_set_after.
983 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
984 All uses changed.
985 (set_buffer_intervals): Rename from buffer_set_intervals.
986 * intervals.c (set_interval_object): Move here from intervals.h,
987 and rename from interval_set_object.
988 (set_interval_left): Move here from intervals.h, and rename from
989 interval_set_left.
990 (set_interval_right): Move here from intervals.h, and rename from
991 interval_set_right.
992 (copy_interval_parent): Move here from intervals.h, and rename from
993 interval_copy_parent.
994 * intervals.h (set_interval_parent): Rename from interval_set_parent.
995 (set_interval_plist): Rename from interval_set_plist.
996 Return void, not Lisp_Object, since no caller uses the result.
997 * lisp.h (string_intervals): Rename from string_get_intervals.
998 (set_string_intervals): Rename from string_set_intervals.
999
34dabdb7
PE
1000 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
1001 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 1002 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
1003 All uses changed. See the end of
1004 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
1005
742af32f
PE
1006 * lisp.h (CSET): Remove (Bug#12215).
1007 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
1008 (set_char_table_purpose): New functions,
1009 replacing CSET. All uses changed. For example, replace
1010 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 1011 "set_char_table_parent (char_table, parent);".
742af32f
PE
1012 The old version was confusing because it used the same name
1013 'parent' for two different things.
1014
a04e2c62
DA
10152012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1016
1017 Functions to get and set Lisp_Object fields of buffer-local variables.
1018 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
1019 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
1020 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
1021 * data.c, eval.c, frame.c: Adjust users.
1022
383dcbf9
CY
10232012-08-17 Chong Yidong <cyd@gnu.org>
1024
1025 * xfaces.c (merge_face_vectors): If the target font specfies a
1026 font spec, make the font's attributes take precedence over
1027 directly-specified attributes.
1028 (merge_face_ref): Recognize :font.
1029
44386687
DA
10302012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1031
1032 Do not use memcpy for copying intervals.
1033 * intervals.c (reproduce_interval): New function.
1034 (reproduce_tree, reproduce_tree_obj): Use it.
1035 (reproduce_tree_obj): Remove prototype.
1036
927c7216
PE
10372012-08-17 Paul Eggert <eggert@cs.ucla.edu>
1038
1039 * lisp.h (duration_to_sec_usec): Remove unused decl.
1040
93044f7b
AA
10412012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
1042
1043 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
1044 to an allocated instance of NSString, not to the class itself.
1045
9851e4a5
JB
10462012-08-17 Juanma Barranquero <lekktu@gmail.com>
1047
1048 * makefile.w32-in (C_CTYPE_H): New macro.
1049 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
1050 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
1051 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
1052
620f13b0
PE
10532012-08-16 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 Use ASCII tests for character types.
1056 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
1057 * xfns.c, xterm.c:
1058 Don't include <ctype.h>; was not needed.
1059 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
1060 * sysdep.c, xfaces.c:
1061 Include <c-ctype.h> instead of <ctype.h>.
1062 * nsterm.m: Include <c-ctype.h>.
1063 * charset.c (read_hex):
1064 * doc.c (Fsnarf_documentation):
1065 * fileio.c (IS_DRIVE) [WINDOWSNT]:
1066 (DRIVE_LETTER) [DOS_NT]:
1067 (Ffile_name_directory, Fexpand_file_name)
1068 (Fsubstitute_in_file_name):
1069 * font.c (font_parse_xlfd, font_parse_fcname):
1070 * frame.c (x_set_font_backend):
1071 * gtkutil.c (xg_get_font):
1072 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
1073 * nsimage.m (hexchar):
1074 * nsterm.m (ns_xlfd_to_fontname):
1075 * sysdep.c (system_process_attributes):
1076 * xfaces.c (hash_string_case_insensitive):
1077 Use C-locale tests instead of locale-specific tests for character
1078 types, since we want the ASCII interpretation here, not the
1079 interpretation suitable for whatever happens to be the current locale.
1080
52162052
MR
10812012-08-16 Martin Rudalics <rudalics@gmx.at>
1082
1083 Consistently check windows for validity/liveness
1084 (Bug#11984, Bug#12025, Bug#12026).
1085 * lisp.h (CHECK_VALID_WINDOW): New macro.
1086 * window.c (decode_window): Rename to decode_live_window.
1087 (decode_valid_window, Fwindow_valid_p): New functions.
1088 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
1089 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
1090 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
1091 (Fwindow_prev_sibling, Fwindow_combination_limit)
1092 (Fset_window_combination_limit, Fwindow_use_time)
1093 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
1094 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
1095 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
1096 (Fwindow_hscroll, Fset_window_hscroll)
1097 (Fwindow_redisplay_end_trigger)
1098 (Fset_window_redisplay_end_trigger, Fwindow_edges)
1099 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
1100 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1101 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
1102 (Fwindow_end, Fset_window_point, Fset_window_start)
1103 (Fpos_visible_in_window_p, Fwindow_line_height)
1104 (Fwindow_dedicated_p, Fset_window_dedicated_p)
1105 (Fwindow_prev_buffers, Fset_window_prev_buffers)
1106 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
1107 (Fset_window_parameter, Fwindow_display_table)
1108 (Fset_window_display_table, Fdelete_other_windows_internal)
1109 (Fset_window_buffer, Fset_window_new_total)
1110 (Fset_window_new_normal, Fdelete_window_internal)
1111 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
1112 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
1113 (Fwindow_scroll_bars): Check whether argument window is a valid or
1114 live window. Update doc-strings.
1115 (syms_of_window): New symbol Qwindow_valid_p.
1116 * keyboard.c (Fposn_at_x_y): Check whether argument
1117 frame_or_window denotes a valid window.
1118
2751c80f
DA
11192012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1120
1121 Fix previous char table change.
1122 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
1123 * chartab.c (optimize_sub_char_table): Likewise.
1124
032a42c8
CY
11252012-08-16 Chong Yidong <cyd@gnu.org>
1126
a2d19368
CY
1127 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
1128
032a42c8
CY
1129 * xfont.c (xfont_open):
1130 * xftfont.c (xftfont_open): Set the font's max_width field.
1131
1132 * nsfont.m (nsfont_open): Similar to the Xft backend, set
1133 min_width to space_width and average_width to the average over
1134 printable ASCII characters.
1135 (ns_char_width): Code cleanup.
1136 (ns_ascii_average_width): New utility function.
1137
1138 * font.h (struct font): Update comments.
1139
a098c930
DA
11402012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1141
032a42c8 1142 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
1143 * lisp.h (CSET): New macro.
1144 (char_table_set_extras, char_table_set_contents)
1145 (sub_char_table_set_contents): New function.
1146 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
1147 * syntax.c: Adjust users.
1148
8be3a09c
SM
11492012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
1150
1151 * eval.c (eval_sub): Bind lexical-binding.
1152 * lread.c (Qlexical_binding): Make non-static.
1153
ac4845a6
JD
11542012-08-15 Jan Djärv <jan.h.d@swipnet.se>
1155
ddee6515
JD
1156 * nsmenu.m (popupSession): Remove.
1157 (pop_down_menu): Remove endModalSession.
1158 (timeout_handler:): New method.
1159 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
1160 Call runModalForWindow. Check timer_fired when it returns.
1161 If not set, cancel timer and break out of loop.
1162 Otherwise loop again, with a new timeout.
1163
1164 * nsterm.m: Include fcntl.h if present.
1165 (fd_entry, t_readfds, inNsSelect): Remove.
1166 (select_writefds, select_valid, select_timeout, selfds)
1167 (select_mutex, apploopnr): Add.
1168 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
1169 Otherwise call kbd_buffer_store_event.
1170 (ns_send_appdefined): Remove release of fd_entry.
1171 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
1172 Increment and decrement apploopnr.
1173 (ns_select): If no file descriptors, just do a NSTimer.
1174 Otherwise copy read/write masks and start select thread (fd_handler).
1175 Start main loop and wait for application defined event.
1176 Inform select thread to stop selecting after main loop is exited.
1177 (ns_term_init): Create selfds pipe and set non-blocking.
1178 Initialize select_mutex. Start the select thread (fd_handler).
1179 (fd_handler:): Loop forever, wait for info from the main thread
1180 to either start or stop selecting. When select returns, send
1181 and appdefined event.
1182 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
1183 If not call kbd_buffer_store_event.
1184
1185 * nsterm.h (EmacsApp): fd_handler takes id argument.
1186 (EmacsDialogPanel): Add timer_fired and timeout_handler.
1187
ac4845a6
JD
1188 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
1189
eb424fe3
EZ
11902012-08-15 Eli Zaretskii <eliz@gnu.org>
1191
1192 * region-cache.c (move_cache_gap): Update gap_len using the actual
1193 growth of the boundaries array. Do not change cache_len.
1194 (Bug#12196)
1195
4e6a86c6
DA
11962012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1197
1198 Generalize and cleanup font subsystem checks.
1199 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
1200 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
1201 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 1202
5bf192ca
DA
12032012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1204
1205 * gtkutil.c (xg_get_font): Use pango_units_to_double.
1206
f2045622
CY
12072012-08-15 Chong Yidong <cyd@gnu.org>
1208
8be3a09c
SM
1209 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
1210 When using the new font chooser, use gtk_font_chooser_get_font_desc to
1211 extract the font descriptor instead of just the font name.
1212 In that case, return a font spec instead of a string.
f2045622
CY
1213 (x_last_font_name): Move to this file from xfns.c.
1214
1215 * xfns.c (Fx_select_font): The return value can also be a font
1216 spec. Move x_last_font_name management to gtkutil.c.
1217
1218 * xfaces.c: Make font weight and style symbols non-static.
1219
7f6feb56
SM
12202012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
1221
1222 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
1223 (bug#12117).
1224
fecbd8ff
SM
12252012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
1226
1227 * alloc.c (Fgarbage_collect): Use plural form consistently.
1228
9b8d5165
EZ
12292012-08-14 Eli Zaretskii <eliz@gnu.org>
1230
1231 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
1232 iteration through the command loop. Fixes a problem whereby mouse
1233 movements are ignored until the first mouse click.
1234
f5d9e83a
PE
12352012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1236
1237 Use bool, not int, for Lisp booleans.
1238 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
1239 makes Emacs a bit smaller and presumably a bit faster.
1240 * lisp.h: Include <stdbool.h>.
1241 (struct Lisp_Boolfwd, defvar_bool):
1242 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
1243 * regex.c [!emacs]: Include <stdbool.h>.
1244 (false, true): Remove; <stdbool.h> does this for us now.
1245
55802e4a
CY
12462012-08-14 Chong Yidong <cyd@gnu.org>
1247
4abcdac8
CY
1248 * character.c (Fcharacterp): Doc fix (Bug#12076).
1249
1250 * data.c (Findirect_variable): Doc fix (Bug#11040).
1251
55802e4a
CY
1252 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
1253
1254 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 1255 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 1256
8e99d072
BR
12572012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1258
1259 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
1260 (bug#12022).
1261
08908aca
MR
12622012-08-14 Martin Rudalics <rudalics@gmx.at>
1263
1264 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
1265 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1266 * minibuf.c (choose_minibuf_frame, read_minibuf):
1267 * w32fns.c (x_create_tip_frame):
1268 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
1269 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
1270
56120d6f
PE
12712012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1272
1273 * intervals.c (offset_intervals): Remove obsolete comment.
1274
67b77c0b
AS
12752012-08-14 Andreas Schwab <schwab@linux-m68k.org>
1276
1277 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
1278
f48b82fd
GR
12792012-08-14 Gergely Risko <gergely@risko.hu>
1280
1281 * coding.c (decode_coding): Record buffer modification before
1282 disabling undo_list (Bug#11773).
1283
fd318b54
DA
12842012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1285
1286 Revert and cleanup some recent overlay changes.
1287 * buffer.h (enum overlay_type): Remove.
1288 (buffer_get_overlays, buffer_set_overlays): Likewise.
1289 (buffer_set_overlays_before, buffer_set_overlays_after):
1290 New function. Adjust users.
1291 (unchain_both): Add eassert.
1292
41a62dd9
DA
12932012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1294
1295 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
1296
5884c324
PE
12972012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1298
1299 * gtkutil.c (xg_mark_data): Don't assume C99.
1300
ca06f160
JD
13012012-08-13 Jan Djärv <jan.h.d@swipnet.se>
1302
1303 * gtkutil.c (xg_frame_tb_info): New struct.
1304 (TB_INFO_KEY): New define.
1305 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
1306 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
1307 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
1308 if not present.
1309 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
1310 is up to date. Otherwise store new data.
1311 (free_frame_tool_bar): Free xg_frame_tb_info if present.
1312
7864a3f7
DA
13132012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1314
1315 Use KSET for write access to Lisp_Object members of struct kboard.
1316 * keyboard.h (KSET): New macro.
1317 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
1318 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
1319 * xterm.c: Adjust users.
1320
4c31be61
DA
13212012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1322
1323 Use BSET for write access to Lisp_Object members of struct buffer.
1324 * buffer.h (BSET): New macro.
1325 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
1326 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
1327 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
1328 * window.c, xdisp.c, xfns.c: Adjust users.
1329
14ae4239
BT
13302012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
1331
1332 * lread.c (syms_of_lread): Initialize Vlexical_binding.
1333
32bcadb4
JD
13342012-08-11 Jan Djärv <jan.h.d@swipnet.se>
1335
3d29b2ce
JD
1336 * nsterm.m (not_in_argv): New function.
1337 (application:openFile, application:openTempFile:):
1338 (application:openFileWithoutUI:, application:openFiles:): Open file
1339 if not_in_argv returns non-zero (bug#12171).
1340
32bcadb4 1341 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
1342 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
1343 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
1344 (xg_get_font_name): Use those functions/macros here.
1345 Reported by Frans Oilinki <moilinki@gmail.com>.
1346
9ff9402d 13472012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
1348
1349 * unexmacosx.c (copy_data_segment): Copy initialized data in
1350 statically linked libraries from input file rather than memory.
1351
db74a5fc
YM
1352 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
1353 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
1354 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
1355
25e65510
GM
13562012-08-10 Glenn Morris <rgm@gnu.org>
1357
1358 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
1359 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
1360
7961135c
DA
13612012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1362
1363 Fix last change to allow compilation with low optimization levels.
1364 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
1365 Reported by Jan Djärv <jan.h.d@swipnet.se>.
1366
42b3a444
DA
13672012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1368
1369 Use common inline syntax in intervals.h.
1370 * intervals.h (INTERVALS_INLINE): New macro.
1371 Change all users from LISP_INLINE.
1372
9fb0c957
DA
13732012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1374
1375 Define Qnone once for all platforms.
1376 * frame.c (Qnone): Define here.
1377 (syms_of_frame): DEFSYM it.
1378 * lisp.h (Qnone): New declaration.
1379 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
1380 * xfns.c: Remove duplication. Adjust users.
1381
65e8ee52
DA
13822012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1383
1384 Remove unused macros from intervals.h.
1385 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
1386 * intervals.c: Adjust comment.
1387
9b855fd6
EZ
13882012-08-10 Eli Zaretskii <eliz@gnu.org>
1389
1390 * w32fns.c <w32_unicode_gui>: New static variable.
1391 (globals_of_w32fns): Initialize it according to os_subtype.
1392 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
1393 testing os_subtype.
1394
39cb9e56 13952012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
1396 Eli Zaretskii <eliz@gnu.org>
1397
1398 Fix bug #10299 with Unicode characters sent by customized
1399 keyboards created by MSKLC.
1400 * w32fns.c (INIT_WINDOW_CLASS): New macro.
1401 (w32_init_class): Use it to initialize the Emacs class with either
1402 ANSI or Unicode API calls.
1403 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
1404 later.
1405 (w32_wnd_proc): If the character code sent by WM_CHAR or
1406 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
1407 original message. Call DefWindowProcW on NT and later.
1408
9374581a
GM
14092012-08-10 Glenn Morris <rgm@gnu.org>
1410
4b94e8cf
GM
1411 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
1412
9374581a
GM
1413 * lisp.h (DIRECTORY_SEP): Let configure set it.
1414
a2752828
DA
14152012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1416
1417 Use TSET for write access to Lisp_Object slots of struct terminal.
1418 * termhooks.h (TSET): New macro.
1419 * coding.c, terminal.c, xselect.c: Adjust users.
1420
cc92c454
SM
14212012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
1422
1423 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
1424 the failing expression, include them in the error message.
1425 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
1426 * lisp.h (internal_condition_case_n): Update declaration.
1427
4cb3e6b3
DA
14282012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1429
1430 Inline functions to examine and change buffer overlays.
1431 * buffer.c (unchain_both): New function.
1432 * buffer.h (buffer_get_overlays, buffer_set_overlays):
1433 (buffer_has_overlays): New function.
1434 (enum overlay_type): New enum.
1435 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
1436 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
1437
8707c1e5
DA
14382012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1439
1440 Inline functions to examine and change buffer intervals.
1441 * alloc.c (mark_interval_tree): Remove.
1442 (MARK_INTERVAL_TREE): Simplify.
1443 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
1444 * intervals.c (buffer_balance_intervals): New function.
1445 (graft_intervals_into_buffer): Adjust indentation.
1446 (set_intervals_multibyte): Simplify.
1447 * buffer.h (BUF_INTERVALS): Remove.
1448 (buffer_get_intervals, buffer_set_intervals): New function.
1449 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
1450 * intervals.c, textprop.c: Adjust users.
1451
ad8c997f
DA
14522012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1453
1454 Inline functions to examine and change string intervals.
1455 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
1456 (string_get_intervals, string_set_intervals): New function.
1457 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1458 * lread.c, print.c, textprop.c: Adjust users.
1459
32ac3a6b
GM
14602012-08-08 Glenn Morris <rgm@gnu.org>
1461
1462 * lisp.mk (lisp): Remove language/persian.elc.
1463
77c7bcb1
DA
14642012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1465
1466 Cleanup intervals.
1467 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
1468 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
1469 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
1470 Adjust comment. Move under #if 0.
77c7bcb1
DA
1471 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1472 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
1473
9c08a8d4
DA
14742012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1475
1476 Check total length of intervals with eassert.
1477 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
1478 * intervals.c: Change all users to eassert.
1479
26d16b35
EZ
14802012-08-07 Eli Zaretskii <eliz@gnu.org>
1481
14ae4239
BT
1482 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
1483 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
1484 INTERNAL_FIELD in Lisp_Cons.
1485
c644523b
DA
14862012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1487
1488 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
1489 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
1490 name since all xname users are fixed long time ago. Do not
1491 use INTERNAL_FIELD.
1492 (set_symbol_name, set_symbol_function, set_symbol_plist):
1493 (set_symbol_next, set_overlay_plist): New function.
1494 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
1495 (struct Lisp_Overlay): Likewise.
1496 (CVAR, MVAR, SVAR): Remove.
1497 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
1498 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
1499 * xterm.c: Adjust users.
1500 * .gdbinit: Change to use name field of struct Lisp_Symbol
1501 where appropriate.
1502
6a3d20cc
DA
15032012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1504
1505 Basic functions to set Lisp_Object and pointer slots of intervals.
1506 * intervals.h (interval_set_parent, interval_set_object):
1507 (interval_set_left, interval_set_right, interval_set_plist):
1508 (interval_copy_parent): New function.
1509 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
1510 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
1511 Adjust indentation.
6a3d20cc
DA
1512 (INTERVAL_SIZE): Remove. Adjust users.
1513 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
1514
4d2b044c
DA
15152012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1516
1517 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
1518 * process.h (PGET): Remove.
1519 (struct Lisp_Process): Do not use INTERNAL_FIELD.
1520 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1521
d3d50620
DA
15222012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1523
1524 Drop WGET and revert read access to Lisp_Objects slots of struct window.
1525 * window.h (WGET): Remove.
1526 (struct window): Do not use INTERNAL_FIELD.
1527 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1528 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1529 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1530 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1531 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1532 Adjust users.
1533
d10a51dc
CY
15342012-08-07 Chong Yidong <cyd@gnu.org>
1535
1536 * window.c (Fwindow_edges, Fwindow_pixel_edges)
1537 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
1538 (Fdelete_window_internal): Signal an error if the window is not on
1539 a live frame (Bug#12025).
1540
e69b0960
DA
15412012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1542
1543 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
1544 * frame.h (FGET): Remove.
1545 (struct frame): Do not use INTERNAL_FIELD.
1546 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1547 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1548 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1549 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1550
25a20a3a
JB
15512012-08-06 Juanma Barranquero <lekktu@gmail.com>
1552
1553 * w32.c: Silence compiler warnings.
1554 (map_w32_filename): Remove unused variable `is_fat'.
1555 (chase_symlinks): Add parentheses around expression.
1556
1c6f11f4
GM
15572012-08-06 Glenn Morris <rgm@gnu.org>
1558
1db4583a
GM
1559 * sysdep.c: Respect BROKEN_GETWD.
1560
1c6f11f4
GM
1561 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
1562 Let configure handle it.
1563 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
1564
2b90362b
DA
15652012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1566
1567 Use GCALIGNMENT where appropriate.
1568 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
1569 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
1570 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
1571
5f50daf2
EZ
15722012-08-06 Eli Zaretskii <eliz@gnu.org>
1573
14ae4239
BT
1574 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
1575 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 1576
cbcc7007
SM
15772012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
1578
1579 * buffer.h (struct buffer): Revert `indirections' to a simple int;
1580 that should be sufficient for everyone.
1581
4d365fa4
JD
15822012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1583
1584 * keyboard.c (timer_check_2): Add break so timer_check returns next
1585 timeout.
1586
dd86bd82
DA
15872012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1588
1589 Fix Windows build errors introduced after converting to WGET and WSET.
1590 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
1591 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1592
054e1668
JD
15932012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1594
1595 * nsterm.m (ns_frame_rehighlight): Use FSET.
1596
1597 * nsmenu.m (ns_update_menubar): Use FSET.
1598
21238f11
DA
15992012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1600
1601 Separate read and write access to Lisp_Object slots of Lisp_Process.
1602 * process.h (PGET, PSET): New macros similar to AREF and ASET.
1603 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1604
077288cf
DA
16052012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1606
1607 Separate read and write access to Lisp_Object slots of struct window.
1608 * window.h (WGET, WSET): New macros similar to AREF and ASET.
1609 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1610 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1611 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1612 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1613 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1614 Adjust users.
1615
71688bd7
DA
16162012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1617
1618 Fix Windows build errors introduced after converting to FGET and FSET.
1619 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
1620 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
1621 (w32_judge_scroll_bars): Change to use FSET.
1622 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1623
f99bac93
DA
16242012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1625
1626 Fix replacement typo.
1627 * window.c (replace_window): Set root_window instead of
1628 selected_window. This fixes a total window subsystem
1629 malfunction reported by Bastien Guerry <bzg@gnu.org>.
1630
8c2a0f2d
GM
16312012-08-06 Glenn Morris <rgm@gnu.org>
1632
1633 * lisp.mk (lisp): Add language/persian.elc.
1634
edd74c35
DA
16352012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1636
1637 Separate read and write access to Lisp_Object slots of struct frame.
1638 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
1639 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1640 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1641 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1642 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1643
8671676c
AS
16442012-08-05 Andreas Schwab <schwab@linux-m68k.org>
1645
1646 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
1647
663e2b3f
DA
16482012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1649
1650 Generalize common compile-time constants.
1651 * lisp.h (header_size, bool_header_size, word_size): Now here.
1652 (struct Lisp_Vector): Add comment.
1653 (struct Lisp_Bool_Vector): Move up to define handy constants.
1654 (VECSIZE, PSEUDOVECSIZE): Simplify.
1655 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
1656 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
1657 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
1658 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
1659 * xfont.c, xmenu.c: Use word_size where appropriate.
1660
d32e47af
LM
16612012-08-05 Lawrence Mitchell <wence@gmx.li>
1662
1663 * search.c (Freplace_match): Treat \? in the replacement text
1664 literally (Bug#8161).
1665
e5d9c0d1
CY
16662012-08-05 Chong Yidong <cyd@gnu.org>
1667
1668 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
1669 * frame.c (Vdelete_frame_functions):
1670 * emacs.c (Vkill_emacs_hook): Doc fix.
1671
8da0576b
EZ
16722012-08-04 Eli Zaretskii <eliz@gnu.org>
1673
1674 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
1675 --with-x-toolkit=no builds.
1676 Reported by Carsten Mattner <carstenmattner@gmail.com>.
1677
02676e5d
CY
16782012-08-04 Chong Yidong <cyd@gnu.org>
1679
1680 * syntax.c (Fmodify_syntax_entry): Doc fix.
1681
97147da9
EZ
16822012-08-04 Eli Zaretskii <eliz@gnu.org>
1683
76151e2c
EZ
1684 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
1685 * w32.c (init_environment): Change the default values of many
1686 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
1687 them into environment when they were not already defined.
1688 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 1689 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
1690 (check_windows_init_file): Now external, not static.
1691 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
1692 called when Vload_path is already set up.
1693
1694 * w32.h (check_windows_init_file): Add prototype.
1695
1696 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
1697 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
1698 compatibility with Posix platforms.
1699 (main): Move the call to check_windows_init_file to here from
1700 w32.c.
1701 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
1702 any, in the DEFALT argument into the root of the Emacs build or
1703 installation tree, as appropriate.
1704
1705 * callproc.c (init_callproc_1): Call decode_env_path instead of
1706 doing its equivalent by hand.
1707 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
1708 the code that sets Vexec_path run on MS-Windows.
1709
1710 * lread.c (init_lread): Add comments to #ifdef's.
1711
97147da9
EZ
1712 * msdos.c (dos_set_window_size, IT_update_begin)
1713 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
1714 instead of direct references.
1715
185ee146
PE
17162012-08-04 Paul Eggert <eggert@cs.ucla.edu>
1717
1718 Export DEFAULT_REHASH_* to GDB.
1719 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
1720 Now constants, not macros.
1721
8834c57a
PE
17222012-08-03 Paul Eggert <eggert@cs.ucla.edu>
1723
98c6f1e3
PE
1724 Remove unnecessary casts involving pointers.
1725 These casts are no longer needed now that we assume C89 or later,
1726 since they involve casting to or from void *.
1727 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
1728 (make_pure_float, make_pure_vector):
1729 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
1730 * macros.c (Fstart_kbd_macro):
1731 * menu.c (find_and_return_menu_selection):
1732 * minibuf.c (read_minibuf_noninteractive):
1733 * sysdep.c (closedir):
1734 * xdisp.c (x_produce_glyphs):
1735 * xfaces.c (compare_fonts_by_sort_order):
1736 * xfns.c (x_real_positions, select_visual):
1737 * xselect.c (x_stop_queuing_selection_requests)
1738 (x_get_window_property, x_get_window_property_as_lisp_data):
1739 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
1740 Remove unnecessary pointer casts.
1741 * alloc.c (record_xmalloc): New function.
1742 * lisp.h (record_xmalloc): New decl.
1743 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
1744 more like a function. This is because the pointer cast is not
1745 needed. All uses changed.
1746 * print.c (print_string, print_error_message): Avoid length recalc.
1747
8834c57a
PE
1748 Improve fix for macroexp crash with debugging (Bug#12118).
1749 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
1750 ARRAY_MARK_FLAG when checking subscripts, because ASET is
1751 not supposed to be invoked from the garbage collector.
1752 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
1753 (gc_aset): New function, which is like ASET but can be
1754 used in the garbage collector.
1755 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1756 (set_hash_index): Use it instead of ASET.
1757
6dad7178
EZ
17582012-08-03 Eli Zaretskii <eliz@gnu.org>
1759
1760 Support symlinks on latest versions of MS-Windows.
1761 * w32.c: Include winioctl.h and aclapi.h.
1762 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
1763 (revert_to_self): Forward declarations of static functions.
1764 <static BOOL g_b_init_get_security_info>:
1765 <g_b_init_create_symbolic_link>: New static flags.
1766 (globals_of_w32): Initialize them to zero.
1767 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
1768 (map_w32_filename): Improve commentary. Simplify switch.
1769 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
1770 headers (most versions of MinGW w32api don't).
1771 (get_security_info, create_symbolic_link)
1772 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
1773 New functions.
1774 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
1775 in the argument file name.
1776 (sys_access): Call unc_volume_file_attributes only if
1777 GetFileAttributes fails with network-related error codes.
1778 (sys_rename): Diagnose renaming of a symlink when the user doesn't
1779 have the required privileges.
14ae4239 1780 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
1781 get_file_security_desc.
1782 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
1783 with addition of handling of symlinks and support for 'lstat'.
1784 If possible, get file's attributes and security information by
6dad7178
EZ
1785 handle, not by name. Produce S_IFLNK bit for symlinks, when
1786 called from 'lstat'.
1787 (stat, lstat): New functions, call 'stat_worker'.
1788 (symlink, readlink, careadlinkat): Rewritten to create and resolve
1789 symlinks when the underlying filesystem supports them.
1790
f162bcc3
PE
17912012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1792
79ea6c20
PE
1793 Fix macroexp crash on Windows with debugging (Bug#12118).
1794 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
1795 checking subscripts; problem introduced with the recent
1796 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
1797 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
1798 since it's used in non-static inline functions now.
1799
c0ce93fd
PE
1800 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
1801 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 1802
f162bcc3
PE
1803 Use C99-style 'extern inline' if available.
1804 * buffer.h (BUFFER_INLINE):
1805 * category.h (CATEGORY_INLINE):
1806 * character.h (CHARACTER_INLINE):
1807 * charset.h (CHARSET_INLINE):
1808 * composite.h (COMPOSITE_INLINE):
1809 * dispextern.h (DISPEXTERN_INLINE):
1810 * lisp.h (LISP_INLINE):
1811 * systime.h (SYSTIME_INLINE):
1812 New macro, replacing 'static inline' in this header.
1813 * buffer.h, category.h, character.h, charset.h, composite.h:
1814 * dispextern.h, lisp.h, systime.h:
1815 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1816 * alloc.c (LISP_INLINE):
1817 * buffer.c (BUFFER_INLINE):
1818 * category.c (CATEGORY_INLINE):
1819 * character.c (CHARACTER_INLINE):
1820 * charset.c (CHARSET_INLINE):
1821 * composite.c (COMPOSITE_INLINE):
1822 * dispnew.c (DISPEXTERN_INLINE):
1823 * sysdep.c (SYSTIME_INLINE):
1824 Define to EXTERN_INLINE, so that the corresponding functions
1825 are compiled into code.
1826 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
1827 (INLINE_HEADER_END): New macros.
1828 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
1829 since it's used in non-static inline functions now.
a8333d03 1830 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 1831
837b365b
GM
18322012-08-02 Glenn Morris <rgm@gnu.org>
1833
d66b744d
GM
1834 * s/: Remove empty directory.
1835
837b365b
GM
1836 * s/ms-w32.h: Move to ../nt/inc.
1837 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
1838 Update for new ms-w32.h location.
1839
13294f95
PE
18402012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1841
1842 Port to Solaris 8.
1843 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
1844
90df0db3
GM
18452012-08-02 Glenn Morris <rgm@gnu.org>
1846
1847 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
1848 hard-coding the path separator.
1849
4939150c
PE
18502012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1851
1852 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
1853 This how ASET and AREF are supposed to work, and makes
1854 it easier to think about future improvements. See
1855 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
1856 * charset.h (set_charset_attr): New function.
1857 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
1858 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
1859 (aref_addr): New function. All uses of &AREF(...) changed.
1860 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1861 (set_hash_index): New functions. All lvalue-style uses of
1862 HASH_KEY etc. changed.
1863 * keyboard.c (set_prop): New function. All lvalue-style uses
1864 of PROP changed.
1865
947b2afd
AA
18662012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
1867
1868 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
1869 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
1870 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
1871 * nsfns.m (ns_set_name_as_filename): Likewise.
1872 * nsmenu.m (ns_update_menubar): Likewise.
1873 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
1874
4f5d0325
EZ
18752012-08-01 Eli Zaretskii <eliz@gnu.org>
1876
2008beae
EZ
1877 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
1878 Adapt to latest changes in field names of the corresponding Lisp
288479f6 1879 objects.
2008beae 1880
4f5d0325
EZ
1881 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
1882
fe3cc771
GM
18832012-08-01 Glenn Morris <rgm@gnu.org>
1884
1885 * s/msdos.h: Remove file.
1886 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
1887 * Makefile.in (S_FILE): Remove.
1888 (config_h): Remove S_FILE.
1889
c90acc54
JB
18902012-08-01 Juanma Barranquero <lekktu@gmail.com>
1891
1892 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
1893 Remove; moved to nt/config.nt.
1894
d8a05828
DA
18952012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1896
1897 Use INTERNAL_FIELD for conses and overlays.
1898 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
1899 Remove obsolete comment.
1900 (MVAR): New macro.
1901 (struct Lisp_Overlay): Use INTERNAL_FIELD.
1902 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
1903
8271d590
DA
19042012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1905
1906 Use INTERNAL_FIELD for symbols.
1907 * lisp.h (SVAR): New macro. Adjust users.
1908 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
1909 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
1910
3193acd2
DA
19112012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1912
1913 Use INTERNAL_FIELD for processes.
1914 * process.h (PVAR): New macro. Adjust style.
1915 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
1916 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
1917
3a45383a
DA
19182012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1919
1920 Use INTERNAL_FIELD for windows.
1921 * window.h (WVAR): New macro.
1922 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
1923 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1924 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1925 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
1926 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
1927 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1928
c1dbc63c
PE
19292012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1930
1931 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
1932
5c0c0e8a
GM
19332012-08-01 Glenn Morris <rgm@gnu.org>
1934
1935 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
1936 Move to configure.ac.
1937
552a99b4
JB
19382012-08-01 Juanma Barranquero <lekktu@gmail.com>
1939
1940 * makefile.w32-in (CONFIG_H): Update dependencies.
1941 (CONF_POST_H): New macro.
1942
1943 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
1944
8d8e2dfe
GM
19452012-07-31 Glenn Morris <rgm@gnu.org>
1946
bc96620a
GM
1947 * Makefile.in (S_FILE): No longer set by configure.
1948
476b1b2d
GM
1949 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
1950 is available.
1951 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
1952
b2c7a106
GM
1953 * process.h (NULL_DEVICE):
1954 * emacs.c (SEPCHAR):
1955 * editfns.c (USER_FULL_NAME): Let configure set them.
1956
d53d062a
GM
1957 * s/README, s/template.h: Remove files.
1958
4515017f
GM
1959 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
1960
8d8e2dfe
GM
1961 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
1962 Move to configure.ac.
1963
5b20b3cc
EZ
19642012-07-31 Eli Zaretskii <eliz@gnu.org>
1965
1e0afd9a
EZ
1966 * .gdbinit (xframe): Adapt to introduction of FVAR and the
1967 resulting renaming of 'struct frame' members.
1968
5b20b3cc
EZ
1969 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
1970
1971 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
1972 after introduction of FVAR.
1973
f1310128
JD
19742012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1975
79e721e0
JD
1976 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
1977
1978 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
1979 instead of compositeToPoint.
1980 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
1981
8d7c7eed 1982 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 1983
e34f7f79
DA
19842012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1985
1986 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
1987 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 1988 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
1989 (BVAR): Change to use INTERNAL_FIELD.
1990 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
1991 (KVAR): Change to use INTERNAL_FIELD.
1992 * frame.h (FVAR): New macro.
1993 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
1994 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
1995 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
1996 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
1997 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1998
c09bfb2f
DA
19992012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2000
2001 Miscellaneous fixes for non-default X toolkits.
2002 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
2003 * xterm.c (x_frame_of_widget): Remove redundant prototype.
2004 Move under #ifdef USE_LUCID.
2005 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
2006 definition and usage to avoid warnings.
2007
14c114ae
JD
20082012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2009
2010 * nsterm.m (openFiles): Fix previous checkin.
2011
3bd21e82
PE
20122012-07-31 Paul Eggert <eggert@cs.ucla.edu>
2013
2014 * indent.c (compute_motion): Remove unused local.
2015
c1529ded
GM
20162012-07-31 Glenn Morris <rgm@gnu.org>
2017
400d5621
GM
2018 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
2019
268e2432
GM
2020 * conf_post.h [USG5_4]:
2021 Move remaining contents of s/usg5-4-common.h here.
2022 * s/usg5-4-common.h: Remove file.
2023
7552f3ee
GM
2024 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
2025 * s/irix6-5.h: Remove file.
2026
6a381852
GM
2027 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
2028 * s/darwin.h: Remove file.
2029
c1529ded
GM
2030 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
2031 * s/hpux10-20.h: Remove file, which is now empty.
2032
b429a4ee
GM
20332012-07-30 Glenn Morris <rgm@gnu.org>
2034
2035 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
2036 * Makefile.in (config_h): Add conf_post.h.
2037 * makefile.w32-in (CONFIG_H): Add conf_post.h.
2038
adff3182
JD
20392012-07-30 Jan Djärv <jan.h.d@swipnet.se>
2040
2041 * nsterm.m (ns_do_open_file): New variable.
b9031d69 2042 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
2043 (openFile, openTempFile, openFileWithoutUI, openFiles):
2044 Open files only if ns_do_open_file.
adff3182 2045
c32af1e4
PE
20462012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2047
7393bcbb
PE
2048 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
2049 This no-op macro hasn't been needed for many years.
2050 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
2051
c32af1e4
PE
2052 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
2053 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
2054 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
2055 gdb_make_enums_visible.
2056 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
2057 (DIRECTORY_SEP): Now a constant, not a macro.
2058
302fc036
EZ
20592012-07-30 Eli Zaretskii <eliz@gnu.org>
2060
2061 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
2062 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
2063
2064 * w32term.c <w32_keyboard_codepage>: Renamed from
2065 keyboard_codepage and now external. All users changed.
2066
2067 * w32term.h: Add declaration of w32_keyboard_codepage.
2068
2069 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
2070 the codepage to translate keys to Unicode. If this argument is
2071 -1, use the value returned by GetConsoleCP. All callers changed.
2072
88fb40b4
PE
20732012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2074
0aee6912
PE
2075 Update .PHONY listings in makefiles.
2076 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
2077 bootstrap-clean, distclean, maintainer-clean, versioclean,
2078 extraclean, frc.
2079
88fb40b4
PE
2080 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
2081 This is a bit clearer. Fix some commentary typos.
2082
0a763bd1
GM
20832012-07-30 Glenn Morris <rgm@gnu.org>
2084
32bac6d6
GM
2085 * s/netbsd.h: Let configure include signal.h if needed.
2086 Remove file, which is now empty.
2087
b65e7c46
GM
2088 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
2089 Let configure set them.
2090 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
2091 No more need to undefine.
0a763bd1 2092
169304bd
AS
20932012-07-30 Andreas Schwab <schwab@linux-m68k.org>
2094
2095 * keymap.c (Fkey_description): Don't remove 0x80 bit from
2096 non-single-byte char when adding meta modifier. (Bug#12090)
2097
6cd7a139
DA
20982012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2099
2100 Convert safe_call to use variable number of arguments.
2101 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
2102 (safe_call2): Fix comment.
2103 * lisp.h (safe_call): Adjust prototype.
2104 * coding.c (encode_coding_object): Change to use safe_call2.
2105 * xfaces.c (merge_face_heights): Change to use safe_call1.
2106
d34d6ffc
GM
21072012-07-30 Glenn Morris <rgm@gnu.org>
2108
7b8a48e4 2109 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 2110 does that unconditionally. Remove file, which is now empty.
7b8a48e4 2111
d34d6ffc
GM
2112 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
2113 Remove empty files.
2114
03a660a6
PE
21152012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2116
2117 Export to GDB most of lisp.h's remaining object-like macros.
2118 * lisp.h (min, max): Move earlier, because they're used earlier now.
2119 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
2120 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
2121 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
2122 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
2123 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
2124 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
2125 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
2126 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
2127 Now constants, for GDB. They need not be macros.
2128 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
2129 Now constants, for GDB, as well as macros, for static initializers.
2130 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
2131 Move to after the definition of struct Lisp_Char_Table,
2132 since the former now needs that type defined.
2133 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
2134 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
2135 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
2136 New enums, for gdb_make_enums_visible.
2137 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 2138 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
2139 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
2140 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
2141 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
2142 enum maxargs, enum MAX_ALLOCA.
2143 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
2144 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
2145 no longer needed, now that they are done in lisp.h.
2146
e499d0ee
DA
21472012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2148
2149 Cleanup string bytes checking.
2150 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
2151 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
2152 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
2153 (check_sblock, compact_small_strings): Simplify.
2154
d5040d2d
PE
21552012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2156
2157 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
2158 These macros are confusing and no longer need to be defined, as
2159 the enum values now suffice. All uses replaced with definiens.
2160 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
2161
7f259ae6
JB
21622012-07-29 Juanma Barranquero <lekktu@gmail.com>
2163
2164 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
2165 ($(BLD)/w32console.$(O)): Update dependencies.
2166
7e63e0c3
DA
21672012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2168
2169 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
2170 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
2171 time. Adjust users.
2172 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
2173
ffd817eb
JD
21742012-07-29 Jan Djärv <jan.h.d@swipnet.se>
2175
2176 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
2177 setting sitelisp (Bug#12010).
2178
417a7a0e
EZ
21792012-07-29 Eli Zaretskii <eliz@gnu.org>
2180
14ae4239 2181 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
2182
2183 * w32heap.c (cache_system_info):
2184 * w32.c (sys_rename):
2185 * w32proc.c (find_child_console, sys_kill): All users changed.
2186
387d4d92
PE
21872012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2188
2189 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
2190
55a6cca6
EZ
21912012-07-29 Eli Zaretskii <eliz@gnu.org>
2192
2193 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
2194
dbcf001c
DA
21952012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2196
2197 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
2198 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
2199 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 2200
e2688e4a
DA
22012012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2202
2203 Generalize marker debugging code under MARKER_DEBUG and use eassert.
2204 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
2205 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
2206 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
2207 (replace_range, replace_range_2, del_range_2): Change to eassert.
2208 * marker.c (byte_char_debug_check): Adjust style.
2209
b46a6a83
PE
22102012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2211
2212 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
2213 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
2214 long-ago-commented-out code that talks about "WIN32".
2215 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
2216 All uses changed.
2217
e32a5799
PE
22182012-07-28 Paul Eggert <eggert@cs.ucla.edu>
2219
2220 Use Gnulib stdalign module (Bug#9772, Bug#9960).
2221 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
2222 Simplify by using alignof.
2223 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
2224 * lisp.h: Include <stdalign.h>.
2225 (GCALIGNMENT): New macro and constant.
2226 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
2227 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
2228 (stdalign): New macro, if not already defined.
2229
df81cd29
EZ
22302012-07-28 Eli Zaretskii <eliz@gnu.org>
2231
01bd1b0d
EZ
2232 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
2233 * w32inevt.c: Include w32inevt.h.
2234 (w32_read_console_input): New inline function, calls either
2235 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
2236 w32_console_unicode_input.
2237 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
2238 (w32_kbd_patch_key, key_event): Use the codepage returned by
2239 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
2240 (key_event): use uChar.UnicodeChar only if
2241 w32_console_unicode_input is non-zero.
2242
2243 * w32console.c: Include w32heap.h.
2244 <w32_console_unicode_input>: New global variable.
2245 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
2246 family of Windows, zero otherwise.
2247
2248 * w32inevt.h: Declare w32_console_unicode_input.
2249
df81cd29
EZ
2250 * xdisp.c (init_iterator): Don't reference tip_frame in a build
2251 --without-x. (Bug#11742)
2252
c20fdd9e
PE
22532012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2254
2255 Adjust GDB to reflect pvec_type changes (Bug#12036).
2256 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
2257 2012-07-04 changes to pseudovector representation.
2258 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 2259
32770973 22602012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
2261
2262 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
2263 bus address.
2264 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
2265
3438fe21
EZ
22662012-07-27 Eli Zaretskii <eliz@gnu.org>
2267
bcfbc9de
EZ
2268 * alloc.c (listn): Fix the order the arguments are consed onto the
2269 list.
2270
3438fe21
EZ
2271 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
2272 enumeration constants, as PURE and HEAP are too general, and clash
2273 with other headers and sources, such as gmalloc.c and the
2274 MS-Windows system headers. All users changed.
2275
eeaea515
DA
22762012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2277
2278 Revert last save_excursion_save and save_excursion_restore changes.
2279 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
2280 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
2281
073c88c2
DA
22822012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2283
2284 Fix recently-introduced typos in Windows port.
2285 Reported by Martin Rudalics <rudalics@gmx.at>.
2286 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 2287 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 2288
4706125e
PE
22892012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2290
2291 Improve GDB symbol export (Bug#12036).
2292 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
2293 arms of an 'if', not using conditional expressions; otherwise GDB
2294 complains about the types in the unevaluated arm when the argument
2295 is an integer literal.
2296 (xgetint): Simplify expression.
2297 * alloc.c (gdb_make_enums_visible): New constant. This ports to
2298 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
2299 Zaretskii in <http://bugs.gnu.org/12036#13>.
2300 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
2301 needed now that we have gdb_make_enums_visible.
2302 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
2303 (enum enum_USE_LSB_TAG):
2304 New enum types, packaging up enums that need to be exported to GDB.
2305
694b6c97
DA
23062012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2307
2308 Utility function to make a list from specified amount of objects.
2309 * lisp.h (enum constype): New datatype.
2310 (listn): New prototype.
2311 * alloc.c (listn): New function.
2312 (Fmemory_use_count, syms_of_alloc): Use it.
2313 * buffer.c (syms_of_buffer): Likewise.
2314 * callint.c (syms_of_callint): Likewise.
2315 * charset.c (define_charset_internal): Likewise.
2316 * coding.c (syms_of_coding): Likewise.
2317 * keymap.c (syms_of_keymap): Likewise.
2318 * search.c (syms_of_search): Likewise.
2319 * syntax.c (syms_of_syntax): Likewise.
2320 * w32.c (init_environment): Likewise.
2321 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
2322 * xdisp.c (syms_of_xdisp): Likewise.
2323 * xfns.c (syms_of_xfns): Likewise.
2324
6195f384
DA
23252012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2326
2327 Fast save_excursion_save and save_excursion_restore.
2328 * lisp.h (struct Lisp_Excursion): New data type.
2329 (PVEC_EXCURSION): New pseudovector type.
2330 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
2331 to deal with it. Adjust comments.
2332 (init_marker, attach_marker): New prototype.
2333 (unchain_marker): Adjust prototype.
2334 * marker.c (attach_marker): Change to global.
2335 (init_marker): New function.
2336 * alloc.c (Fmake_marker, build_marker): Use it.
2337 (build_marker): More easserts.
2338 (mark_object): Handle struct Lisp_Excursion.
2339 * editfns.c (save_excursion_save, save_excursion_restore):
2340 Reimplement to use struct Lisp_Excursion. Add comments.
2341
5eceb8fb
PE
23422012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2343
2344 Fix export of symbols to GDB (Bug#12036).
2345 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
2346 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
2347 emacs.c, as this is a more-suitable home. Had this been done earlier
2348 the fix for 12036 would have avoided some of the problems noted in
2349 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
2350 would have been more obvious.
562157c8
PE
2351 * emacs.c: Do not include <verify.h>; no longer needed.
2352 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
2353 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
2354 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2355 Remove; now done in lisp.h.
2356 * lisp.h (PUBLISH_TO_GDB): New macro.
2357 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
2358 (DATA_SEG_BITS): Use it.
2359 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
2360 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
2361 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
2362 not be usable in #if. This simplifies things.
2363
d6749401
JB
23642012-07-26 Juanma Barranquero <lekktu@gmail.com>
2365
2366 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
2367
1781b9e9
PE
23682012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2369
d89518db 2370 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
2371 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
2372 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
2373 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
2374 Adjust to changes in lisp.h and emacs.c, by using
2375 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
2376 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
2377 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
2378 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
2379 instead of gdb_valbits.
2380 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
2381 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
2382 instead of gdb_array_mark_flag.
2383 (xboolvector): Get size from $->size, not $->header.size.
2384 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
2385 (xreload, hook-run, hookpost-run): Remove.
2386 * emacs.c: Include <verify.h>.
2387 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
2388 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
2389 Remove.
2390 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
2391 (gdb_USE_LSB_TAG): New enum constants.
2392 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2393 Also define these as enum constants, so they're visible to GDB.
2394 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
2395 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
2396 as constants, so they're visible to GDB.
2397 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
2398 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
2399 Now enum constants, not macros, so they're visible to GDB.
2400 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
2401 more convenient now. All uses changed.
2402 (VALMASK) [USE_LSB_TAG]: Also define in this case.
2403 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
2404
3628596a
DA
24052012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
2406
2407 Explicitly free restriction data that are not needed anymore.
2408 * editfns.c (save_restriction_restore): Free restriction data.
2409
7abaf5cc
SM
24102012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2411
2412 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
2413 add argument, tune behavior, and adjust all callers.
2414
71f88e00
PE
24152012-07-25 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 Use typedef for EMACS_INT, EMACS_UINT.
2418 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
2419 than macros. This simplifies debugging in the usual case, since
2420 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
2421 and it allows expressions involving EMACS_INT casts.
2422 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
2423
57ec3034
JD
24242012-07-25 Jan Djärv <jan.h.d@swipnet.se>
2425
2426 * nsterm.m (ns_read_socket): Return early if there is a modal
2427 window (Bug#12043).
2428
8137e7b3
MR
24292012-07-25 Martin Rudalics <rudalics@gmx.at>
2430
2431 * frame.c (Fredirect_frame_focus): In doc-string don't mention
2432 that FOCUS-FRAME can be omitted.
2433
04e9897c
DA
24342012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
2435
2436 Adjust buffer text indirection counters at the end of Fkill_buffer.
2437 * buffer.c (Fkill_buffer): Adjust indirection counters when the
2438 buffer is definitely dead. This should really fix an issue reported
2439 by Christoph Scholtes again. (Bug#12007).
2440 (init_buffer_once): Initialize indirection counters of
2441 buffer_defaults and buffer_local_symbols (for sanity and safety).
2442
8a0484e1
EZ
24432012-07-24 Eli Zaretskii <eliz@gnu.org>
2444
2445 * xdisp.c (init_iterator): Don't compute dimensions of truncation
2446 and continuation glyphs on tooltip frames, leave them at zero.
2447 Avoids continued lines in tooltips. (Bug#11832)
2448
fa691a83
DA
24492012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
2450
2451 Simplify copy_overlay.
04e9897c 2452 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
2453 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
2454
436bc8e0
EZ
24552012-07-23 Eli Zaretskii <eliz@gnu.org>
2456
2457 * print.c (print_object): Don't crash when a frame's name is nil
2458 or invalid. (Bug#12025)
2459
2460 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
2461 it signals an error when a tooltip frame is being created.
2462
d7a7fda3
DA
24632012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
2464
2465 Cleanup miscellaneous objects allocation and initialization.
2466 * alloc.c (allocate_misc): Change to static. Add argument to
2467 specify the subtype. Adjust comment and users.
2468 (build_overlay): New function.
2469 * buffer.c (copy_overlays, Fmake_overlay): Use it.
2470 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
2471 (allocate_misc): Remove prototype.
2472 (build_overlay): Add prototype.
2473
24742012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
2475
2476 Swap buffer text indirection counters in Fbuffer_swap_text.
2477 * buffer.c (Fbuffer_swap_text): Swap indirections too.
2478 This avoids crash reported by Christoph Scholtes at
2479 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
2480
9d7fa573
JD
24812012-07-22 Jan Djärv <jan.h.d@swipnet.se>
2482
2483 * nsmenu.m (Popdown_data): New struct.
2484 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
2485 free Popdown_data.
2486 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
2487 (initWithContentRect): Make imgView and contentView non-static
2488 and autorelease them. Also autorelease img and matrix (Bug#12005).
2489 (dealloc): Remove (Bug#12005).
2490
0dd6d66d
DA
24912012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2492
2493 Adjust consing_since_gc when objects are explicitly freed.
2494 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
2495 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
2496 (free_cons, free_misc): Subtract object size from consing_since_gc.
2497
d36d71df
DA
24982012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2499
2500 Simplify and cleanup markers positioning code.
2501 * marker.c (attach_marker): More useful eassert.
2502 (live_buffer, set_marker_internal): New function.
2503 (Fset_marker, set_marker_restricted): Use set_marker_internal.
2504 (set_marker_both, set_marker_restricted_both): Use live_buffer.
2505
fb9ea40f
PE
25062012-07-22 Paul Eggert <eggert@cs.ucla.edu>
2507
2508 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
2509 as it's limited by the amount of memory, not by INT_MAX.
2510
2d5c5f7d
EZ
25112012-07-21 Eli Zaretskii <eliz@gnu.org>
2512
07fb592e
EZ
2513 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
2514 in special-event-map. See the discussion at
2515 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
2516 for the reasons.
2517
37a9eac8 2518 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
2519 info.dwItemData. Fixes crashes on 64-bit Windows.
2520 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 2521
c4328746
JD
25222012-07-21 Jan Djärv <jan.h.d@swipnet.se>
2523
2524 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 2525 (conversationIdentifier): Return value is NSInteger.
784051c4 2526 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 2527
6e5d1c12
CY
25282012-07-21 Chong Yidong <cyd@gnu.org>
2529
2530 * window.c (decode_any_window): Signal an error if the window is
2531 on a dead frame (Bug#11984).
2532
9928463d
DA
25332012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2534
2535 Add indirection counting to speed up Fkill_buffer.
2536 * buffer.h (struct buffer): New member.
2537 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
2538 (Fmake_indirect_buffer): Set indirection counter to -1, increment
2539 base buffer indirection counter.
2540 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
2541 (Fkill_buffer): Adjust indirection counters as needed, don't walk
2542 through buffer list if indirection counter is 0.
2543
f8643a6b
DA
25442012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2545
2546 Extend the value returned by Fgarbage_collect with heap statistics.
2547 * alloc.c (Qheap): New symbol.
2548 (syms_of_alloc): DEFSYM it.
2549 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
2550 (Fmemory_free): Remove.
2551 (syms_of_alloc): Don't defsubr it.
2552 * buffer.c (Fcompact_buffer): Remove.
2553 (syms_of_buffer): Don't defsubr it.
2554
dac616ff
DA
25552012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2556
2557 Make maybe_gc inline.
2558 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
2559 * lisp.h (consing_since_gc, gc_relative_threshold)
2560 (memory_full_cons_threshold): Revert declaration.
2561 (maybe_gc): Remove prototype, define as inline.
2562 * alloc.c: Remove old commented-out code.
2563 (consing_since_gc, gc_relative_threshold)
2564 (memory_full_cons_threshold): Revert to global.
2565 (maybe_gc): Remove.
2566
d7ea76b4
DA
25672012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2568
2569 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
2570 * lisp.h (build_unibyte_string): New function.
2571 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
2572 * sysdep.c, w32fns.c, xfns.c: Use it.
2573 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
2574 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
2575 Adjust users accordingly.
2576 * font.h (font_open_by_name): Adjust prototype.
2577
765e61e3
DA
25782012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2579
2580 Cleanup calls to Fgarbage_collect.
2581 * lisp.h (maybe_gc): New prototype.
2582 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2583 Remove declarations.
2584 * alloc.c (maybe_gc): New function.
2585 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2586 Make them static.
2587 * bytecode.c (MAYBE_GC): Use maybe_gc.
2588 * eval.c (eval_sub, Ffuncall): Likewise.
2589 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
2590 to avoid dependency from auto-save feature.
2591
52b852c7
PE
25922012-07-19 Paul Eggert <eggert@cs.ucla.edu>
2593
2594 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
2595 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
2596 'for_each_per_buffer_object_at'.
2597 All uses changed. It's better to use upper-case for macros that
2598 cannot be implemented as functions, to give the reader a clue
2599 that they're special.
2600
5db81e33
SM
26012012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
2602
2603 * alloc.c (Fgarbage_collect): Tweak docstring.
2604
5b835e1d
DA
26052012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2606
2607 Tweak the value returned from Fgarbage_collect again.
2608 * alloc.c (Fgarbage_collect): New return value, as confirmed in
2609 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
2610 Adjust documentation.
2611 (total_vector_bytes): Rename to total_vector_slots, adjust
2612 accounting.
2613 (total_free_vector_bytes): Rename to total_free_vector_slots,
2614 adjust accounting.
2615 (Qstring_bytes, Qvector_slots): New symbols.
2616 (syms_of_alloc): DEFSYM them.
2617
9cd47b72
DA
26182012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2619
2620 Buffer compaction primitive which may be used from Lisp.
2621 * buffer.c (compact_buffer, Fcompact_buffer): New function.
2622 (syms_of_buffer): Register Fcompact_buffer.
2623 * alloc.c (Fgarbage_collect): Use compact_buffer.
2624 * buffer.h (compact_buffer): New prototype.
2625 (struct buffer_text): New member.
2626
d17337e5
DA
26272012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2628
2629 New macro to iterate over all buffers, miscellaneous cleanups.
2630 * lisp.h (all_buffers): Remove declaration.
2631 * buffer.h (all_buffers): Add declaration, with comment.
2632 (for_each_buffer): New macro.
2633 * alloc.c (Fgarbage_collect, mark_object): Use it.
2634 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
2635 (init_buffer): Likewise.
2636 * data.c (Fset_default): Likewise.
2637 * coding.c (code_conversion_restore): Remove redundant check
2638 for dead buffer.
2639 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
2640
60cfd278
AS
26412012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2642
2643 Fix bug that created negative-length intervals.
2644 * intervals.c (merge_interval_right, merge_interval_left):
2645 Do not zero out this interval if it is absorbed by its children,
2646 as this interval's total length doesn't change in that case. See
2647 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
2648
d06714cb
PE
26492012-07-18 Paul Eggert <eggert@cs.ucla.edu>
2650
83713154
PE
2651 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
2652 when invoking (make-bool-vector N t) and N is a positive
2653 multiple of 8 -- the last 8 bits were mistakenly cleared.
2654
d06714cb
PE
2655 Remove some struct layout assumptions in bool vectors.
2656 * alloc.c (bool_header_size): New constant.
2657 (header_size, word_size): Move earlier, as they're now used earlier.
2658 Use 'word_size' in a few more places, where it's appropriate.
2659 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
2660 padding before the data member of a bool vector.
2661 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
2662 than doing the check by hand with an abort ().
2663
464d5a5e
SM
26642012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2665
5fbc0409
SM
2666 * eval.c (Fdefvar): Don't check constants since we only set the var if
2667 it's not yet defined anyway (bug#11904).
2668
464d5a5e
SM
2669 * lisp.h (last_undo_boundary): Declare new var.
2670 * keyboard.c (command_loop_1): Set it.
2671 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
2672 were auto-added by the command loop (bug#11774).
2673
8dc2e44a
AS
26742012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2675
2676 * w32font.c (Qsymbol): Remove local definition.
2677 (syms_of_w32font): Don't DEFSYM it.
2678
169925ec
DA
26792012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2680
2681 Fix sweep_vectors to handle large bool vectors correctly.
2682 * alloc.c (sweep_vectors): Account total_vector_bytes for
2683 bool vectors larger than VBLOCK_BYTES_MAX.
2684
5fbfb018
CY
26852012-07-18 Chong Yidong <cyd@gnu.org>
2686
2687 * frame.c (x_set_frame_parameters): Revert bogus change introduced
2688 in 2012-05-25 commit by Paul Eggert (Bug#11738).
2689
3ab6e069
DA
26902012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2691
2692 Return more descriptive data from Fgarbage_collect.
2693 Suggested by Stefan Monnier in
2694 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
2695 * alloc.c (bounded_number): New function.
2696 (total_buffers, total_vectors): New variable.
2697 (total_string_size): Rename to total_string_bytes, adjust users.
2698 (total_vector_size): Rename to total_vector_bytes, adjust users.
2699 (sweep_vectors): Account total_vectors and total_vector_bytes.
2700 (Fgarbage_collect): New return value. Adjust documentation.
2701 (gc_sweep): Account total_buffers.
2702 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
2703 (VECTOR_SIZE): Remove.
2704 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
2705 (Qinterval, Qmisc): New symbols.
2706 (syms_of_data): Initialize them.
2707 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
2708 (Qcons, Qbuffer): New declarations.
2709
6d02fe5b
PE
27102012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2711
2712 * alloc.c (Fmemory_free): Account for memory-free's own storage.
2713 Round up, not down. Improve doc.
2714
b7ffe040
DA
27152012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2716
2717 Restore old code in allocate_string_data to avoid Faset breakage.
2718 Reported by Julien Danjou <julien@danjou.info> in
2719 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
2720 * alloc.c (allocate_string_data): Restore old code with minor
2721 adjustments, fix comment to explain this subtle issue.
2722
4dc7c8d5
SM
27232012-07-17 Eli Zaretskii <eliz@gnu.org>
2724
2725 Remove FILE_SYSTEM_CASE.
2726 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
2727
2728 * fileio.c (FILE_SYSTEM_CASE): Don't define.
2729 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
2730 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
2731 call-process-region passes it through expand-file-name.
2732
2733 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
2734
27352012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2736
2737 Fix crash when creating indirect buffer (Bug#11917)
2738 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
2739 Don't handle unbound variables specially if non-zero.
2740 (Fbuffer_local_variables): Pass zero.
2741 (clone_per_buffer_values): Pass non-zero.
2742
27432012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2744
2745 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
2746 to make the loop interruptible.
2747
27482012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2749
2750 * gnutls.c (emacs_gnutls_handshake): Only retry if
2751 GNUTLS_E_INTERRUPTED.
2752
cce7fefc
DA
27532012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2754
2755 Cleanup and convert miscellaneous checks to eassert.
2756 * alloc.c (mark_interval): Fix comment, partially rephrase
2757 old comment from intervals.h (see below).
2758 * intervals.c (find_interval, adjust_intervals_for_insertion)
2759 (delete_interval, adjust_intervals_for_deletion)
2760 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
2761 Convert to eassert.
2762 (adjust_intervals_for_insertion, make_new_interval):
2763 Remove obsolete and unused code.
2764 * intervals.h (struct interval): Remove obsolete comment.
2765 * textprotp.c (erase_properties): Remove unused code.
2766 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
2767 (Fremove_list_of_text_properties): Convert to eassert.
2768
9ea10cc3
CY
27692012-07-17 Chong Yidong <cyd@gnu.org>
2770
2771 * editfns.c (Finsert_char): Doc fix.
2772
3900d5de
DA
27732012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2774
2775 Fix previous change to make Fmemory_free always accurate.
2776 * alloc.c (make_interval): Update total_free_intervals.
2777 (make_float): Likewise for total_free_floats.
2778 (free_cons, Fcons): Likewise for total_free_conses.
2779 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
2780 Likewise for total_free_vector_bytes.
2781 (Fmake_symbol): Likewise for total_free_symbols.
2782 (bytes_free): Remove.
2783
7098646f
DA
27842012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2785
2786 Simple free memory accounting feature.
2787 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
2788 (sweep_vectors): Accumulate size of free vectors.
2789 (Fgarbage_collect): Setup bytes_free.
2790 (Fmemory_free): New function.
2791 (syms_of_alloc): Register it.
2792
22657b40
DA
27932012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2794
2795 Cleanup overlays checking.
2796 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
2797 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
2798 eassert and OVERLAYP.
2799 (sort_overlays): Change to use OVERLAYP.
2800
ddfc8813
RK
28012012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
2802
2803 * editfns.c (Finsert_char): Make it interactive, and make the
2804 second arg optional. Copy interactive spec and docstring from
2805 ucs-insert.
2806
7c26cf3c
PE
28072012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2808
2809 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
2810 Unlike the other wrapped functions, fabs has an unspecified
2811 effect on errno.
2812
5d127af9
JD
28132012-07-16 Jan Djärv <jan.h.d@swipnet.se>
2814
2815 * nsterm.m (keyDown): Interpret flags without left/right bits
2816 as the left key (Bug#11670).
2817
6a0dd1d7
DA
28182012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2819
2820 Remove empty and useless init functions.
2821 * lisp.h (init_character_once, init_fns, init_image)
2822 (init_filelock, init_sound): Remove prototype.
2823 * character.c (init_character_once): Remove.
2824 * filelock.c (init_filelock): Likewise.
2825 * fns.c (init_fns): Likewise.
2826 * image.c (init_image): Likewise.
2827 * sound.c (init_sound): Likewise.
2828 * emacs.c (main): Adjust accordingly.
2829
7a6136fd
DA
28302012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2831
2832 * gtkutil.h: Tiny cleanups.
2833 (use_old_gtk_file_dialog): Remove useless declaration.
2834 (xg_uses_old_file_dialog): Add suggested const attribute.
2835
ce811ad9
EZ
28362012-07-15 Eli Zaretskii <eliz@gnu.org>
2837
2838 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
2839 (bidi_paragraph_init): Use it to limit search forward for a strong
2840 directional character in abnormally large paragraphs full of
2841 neutral or weak characters. (Bug#11943)
2842
c9adfeaa
SF
28432012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
2844
2845 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
2846 the toolbar (Bug#9451).
2847 (xg_make_tool_item): Give the widget event box a transparent
2848 background.
2849
fff62aa9
DA
28502012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2851
2852 Cleanup basic allocation variables and functions.
2853 * alloc.c (ignore_warnings, init_intervals, init_float)
2854 (init_cons, init_symbol, init_marker): Remove.
2855 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
2856 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
2857 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
2858 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
2859 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
2860 (staticidx, init_alloc_once, init_strings, free_ablock):
2861 Remove redundant initialization.
2862 * fns.c (init_weak_hash_tables): Remove.
2863 * lisp.h (init_weak_hash_tables): Remove prototype.
2864
9730daca
DA
28652012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2866
2867 Use zero_vector where appropriate.
2868 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
2869 accordingly.
2870 * lisp.h (zero_vector): New declaration.
2871 * font.c (null_vector): Remove.
2872 (syms_of_font): Remove initialization and staticpro.
2873 (font_list_entities, font_find_for_lface): Change to use zero_vector.
2874 * keymap.c (Faccessible_keymaps): Likewise.
2875
2e2d2a13
LL
28762012-07-15 Leo Liu <sdl.web@gmail.com>
2877
2878 * fringe.c: Fix typo in comments.
2879
cd276f6e
LL
28802012-07-14 Leo Liu <sdl.web@gmail.com>
2881
2882 * fringe.c: Add a new bitmap exclamation-mark.
2883
5a1131d9
EZ
28842012-07-14 Eli Zaretskii <eliz@gnu.org>
2885
2886 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
2887
2888 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
2889 (HAVE_MENUS): Don't define, defined by editing config.in with
2890 msdos/sed2v2.inp.
2891 (GMALLOC_INHIBIT_VALLOC): Don't define.
2892 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
2893
22e983b7
JB
28942012-07-14 Juanma Barranquero <lekktu@gmail.com>
2895
2896 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
2897
5b3f250f
GM
28982012-07-14 Glenn Morris <rgm@gnu.org>
2899
2900 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
2901 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
2902 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
2903
33d63ff4
GM
29042012-07-13 Glenn Morris <rgm@gnu.org>
2905
5b633342
GM
2906 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
2907
33d63ff4
GM
2908 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
2909 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
2910
b55b9f85
JD
29112012-07-13 Jan Djärv <jan.h.d@swipnet.se>
2912
0dc8cf50
JD
2913 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
2914 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
2915 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
2916 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
2917 where appropriate.
2918 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
2919 as boolean expression.
2920 (x_set_window_size): Remove unused variable toolbar.
2921 (ns_get_color_default, ns_mod_to_lisp): Remove.
2922 (ns_mouse_position): Remove unused variables xchar and ychar.
2923 (ns_compute_glyph_string_overhangs): Remove unused variable face.
2924 (ns_set_vertical_scroll_bar): Remove unused variable count.
2925 (ns_delete_terminal): Remove unused variable i.
2926 (ns_term_init): Remove unused variables r, g and b.
2927 (mouseDown): Remove unused variable window.
2928 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
2929 (initFrameFromEmacs): Remove unused variable vbextra.
2930 (mouseEntered): Remove unused variables p and dpyinfo.
2931 (mouseExited): Remove unused variables p and r.
2932 (ns_define_frame_cursor, ns_clear_frame_area)
2933 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
2934 (menuDown): Assign [sender tag] to variable and cast the variable.
2935
2936 * nsterm.h (menuDown): Add id as type to argument sender.
2937 (ns_display_info_for_name): Add Lisp_Object argument.
2938 (ns_term_init): Add Lisp_Object argument.
2939 (ns_map_event_to_object): Add void argument.
2940 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
2941 prototype with arguments and only declare if __OBJC__.
2942 (nxatoms_of_nsselect): Add void argument.
2943 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
2944 (ns_alloc_autorelease_pool): Add void argument.
2945 (ns_release_autorelease_pool): Add void* argument.
2946 (ns_get_defaults_value): Add const char* argument.
2947
2948 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
2949 (initFromContents): Use SSDATA where appropriate.
2950 (ns_update_menubar): Add braces to ambigous if-else.
2951 (initWithTitle): Put () around assignment in if statement.
2952 (ns_menu_show): Remove unused variables window and keymap.
2953 (update_frame_tool_bar): Remove unused variable selected_p.
2954 (initWithContentRect): Remove unused variable this_cmd_name.
2955
2956 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
2957 appropriate.
2958 (setXBMColor): Remove unused variable len.
2959 (setPixmapData): Put () around assignment in loop statement.
2960
2961 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
2962 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
2963 where appropriate.
2964 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
2965 around assignment in loop statement.
2966 (nsfont_open): Remove unused variable i.
2967 (nsfont_open): Remove unused variable len.
2968 (nsfont_draw): Remove unused variable cs.
2969
2970 * nsfns.m (x_set_icon_name, ns_set_name_internal)
2971 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
2972 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
2973 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
2974 (Fns_font_name, Fns_perform_service)
2975 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
2976 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
2977 (ns_set_name): Remove unused variable view.
2978 (x_set_menu_bar_lines): Remove unused variable olines.
2979 (x_set_tool_bar_lines): Remove unused variable root_window.
2980 (Fns_list_colors): Put () around assignment in while statement.
2981 (Fns_perform_service): Remove unused variable len.
2982 (Fns_display_usable_bounds): Remove unused variable top.
2983 (syms_of_nsfns): Remove unused variable i.
2984
b55b9f85
JD
2985 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
2986 memcpy (Bug#11907).
2987
ed9265fc 29882012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
2989
2990 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
2991 and free it with DestroyExceptionInfo (Bug#11558).
2992
ef099b57
JB
29932012-07-13 Juanma Barranquero <lekktu@gmail.com>
2994
2995 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
2996 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
2997 Set here, not in nt/config.nt.
2998
ea814a5d
EZ
29992012-07-13 Eli Zaretskii <eliz@gnu.org>
3000
3001 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
3002 cursor overflow into the last glyph on display line when the right
3003 fringe is off. (Bug#11832)
3004
1a952767
PE
30052012-07-13 Paul Eggert <eggert@cs.ucla.edu>
3006
3007 * xdisp.c (produce_special_glyphs): Now static.
3008 * dispextern.h (produce_special_glyphs): Remove decl.
3009
983188fd
GM
30102012-07-13 Glenn Morris <rgm@gnu.org>
3011
8d7c7eed 3012 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
3013 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
3014
983188fd
GM
3015 * s/usg5-4-common.h (USG, USG5):
3016 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
3017 * s/sol2-6.h (SOLARIS2):
3018 * s/irix6-5.h (IRIX6_5):
3019 * s/hpux10-20.h (USG, USG5, HPUX):
3020 * s/gnu-linux.h (USG, GNU_LINUX):
3021 * s/freebsd.h (BSD_SYSTEM):
3022 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
3023 * s/cygwin.h (CYGWIN):
3024 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
3025 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
3026
d1e68667 30272012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
3028
3029 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 3030
6de0e799
GM
30312012-07-13 Glenn Morris <rgm@gnu.org>
3032
739ae010
GM
3033 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
3034
dbee5793
GM
3035 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
3036
6de0e799
GM
3037 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
3038 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
3039
b82da769
GM
30402012-07-12 Glenn Morris <rgm@gnu.org>
3041
4fae5a7a 3042 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
3043
3044 * process.c (init_process_emacs): Rename from init_process.
3045 The old name is also the name of a Mach system call.
3046 * lisp.h, emacs.c: Update for this name change.
3047 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
3048 longer needed.
3049
5a979817
EZ
30502012-07-12 Eli Zaretskii <eliz@gnu.org>
3051
3052 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
3053 memmove call that removes glyphs covered by the left truncation
3054 glyph. Improve commentary.
3055 (display_line): Fix display of continuation glyphs on GUI frames
3056 when the right fringe is turned off and variable-size fonts are
3057 used in the window. Move the code that appends a stretch glyph to
3058 produce_special_glyphs, so that it could be used for truncation
3059 and continuation glyphs alike.
3060 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
3061 glyph of a suitably computed width, to align the special glyphs at
3062 the window margin. Code moved from display_line. (Bug#11832)
3063
3e91a053
GM
30642012-07-12 Glenn Morris <rgm@gnu.org>
3065
ba9e4b84
GM
3066 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
3067
3068 * s/gnu-linux.h, s/hpux10-20.h:
3069 Do not unconditionally define HAVE_XRMSETDATABASE.
3070
3e91a053
GM
3071 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
3072
b300b1f4
PE
30732012-07-12 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 Fix typos that broke OS X build.
3076 Reported by Randal L. Schwartz in
3077 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
3078 * nsterm.m (ns_timeout): Add missing local decl.
3079 (ns_get_color): snprintf -> sprintf, to fix typo.
3080
6e777848
GM
30812012-07-12 Glenn Morris <rgm@gnu.org>
3082
3f922c37
GM
3083 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
3084 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
3085 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
3086 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
3087
0ab7b23a
GM
3088 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
3089 Move PTY_OPEN to configure.
3090
6e777848
GM
3091 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3092 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
3093 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
3094
4a7edc24
DA
30952012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
3096
3097 Use empty_unibyte_string where applicable.
3098 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
3099 * lread.c (read1): Likewise.
3100 * xsettings.c (syms_of_xsettings): Likewise.
3101
308aab79
GM
31022012-07-12 Glenn Morris <rgm@gnu.org>
3103
42bd1719
GM
3104 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
3105 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
3106 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
3107 * s/hpux10-20.h (RUN_TIME_REMAP):
3108 * s/bsd-common.h (TABDLY): Move to configure.
3109
3110 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
3111
3112 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
3113
ea0bbd17 3114 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 3115 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
3116
3117 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 3118
308aab79
GM
3119 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
3120 * s/template.h: Move NARROWPROTO to configure.
3121
ee1cf5cf
GM
31222012-07-11 Glenn Morris <rgm@gnu.org>
3123
30fe9bf4
GM
3124 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
3125 unused since 2011-01-17 change to systty.h.
3126
ee1cf5cf
GM
3127 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
3128 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3129 Move HAVE_PTYS and HAVE_SOCKETS to configure.
3130
63e47e07
PE
31312012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3132
3133 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
3134
c43fb4c3
GM
31352012-07-11 Glenn Morris <rgm@gnu.org>
3136
3137 * s/darwin.h, s/gnu-linux.h, s/template.h:
3138 Move INTERRUPT_INPUT to configure.
3139
e8df9267
DA
31402012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3141
3142 Minor adjustments to interning code.
3143 * lisp.h (intern, intern_c_string): Redefine as static inline
3144 wrappers for intern_1 and intern_c_string_1, respectively.
3145 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
3146 * lread.c (intern_1, intern_c_string_1, oblookup):
3147 Simplify Vobarray checking.
e8df9267
DA
3148 * font.c (font_intern_prop): Likewise. Adjust comment.
3149 * w32font.c (intern_font_name): Likewise.
3150
34348bd4
AS
31512012-07-11 Andreas Schwab <schwab@linux-m68k.org>
3152
d96a1e0c
AS
3153 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
3154
34348bd4
AS
3155 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
3156 of Fcar/Fcdr if possible.
3157 * font.c (check_otf_features): Likewise.
3158 * fontset.c (Fnew_fontset): Likewise.
3159 * gnutls.c (Fgnutls_boot): Likewise.
3160 * minibuf.c (read_minibuf): Likewise.
3161 * msdos.c (IT_set_frame_parameters): Likewise.
3162 * xmenu.c (Fx_popup_dialog): Likewise.
3163 * w32menu.c (Fx_popup_dialog): Likewise.
3164
c8add24e
GM
31652012-07-11 Glenn Morris <rgm@gnu.org>
3166
4b575b3c
GM
3167 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
3168 since nothing has defined it on these platforms.
3169
09f4e3b0
GM
3170 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
3171 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
3172
172bedef
GM
3173 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3174 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3175 Move CLASH_DETECTION to configure.
3176
249685df
GM
3177 * s/gnu.h: Remove file, which is now empty.
3178
c8add24e
GM
3179 * s/gnu.h, s/gnu-linux.h:
3180 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
3181
b41253a3
JW
31822012-07-11 John Wiegley <johnw@newartisans.com>
3183
3184 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
3185 function attribute, so we only use it if it exists in the
3186 compiler.
3187
d923b542
DA
31882012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3189
3190 Avoid call to strlen in fast_c_string_match_ignore_case.
3191 * search.c (fast_c_string_match_ignore_case): Change to use
3192 length argument. Adjust users accordingly.
3193 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
3194
5ebbef1d
PE
31952012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3196
bb352260
PE
3197 Assume mkdir, rmdir.
3198 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
3199 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
3200
57054ddd
PE
3201 Assume rename.
3202 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
3203
b747d3f7
PE
3204 Assume perror.
3205 * s/hpux10-20.h (HAVE_PERROR): Remove.
3206 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
3207 Remove dummy definition, as this problem was obsolete long ago.
3208
5ebbef1d
PE
3209 Assume strerror.
3210 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
3211
984e7f30
DA
32122012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3213
3214 Avoid calls to strlen in font processing functions.
3215 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
3216 (font_open_by_name): Change to use length argument.
3217 Adjust users accordingly.
d923b542
DA
3218 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
3219 Adjust prototypes.
3220 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
3221 Change to return ptrdiff_t.
984e7f30
DA
3222 (xfont_list_pattern, xfont_match): Use length returned by
3223 xfont_decode_coding_xlfd.
3224 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
3225
20e94fdd
GM
32262012-07-11 Glenn Morris <rgm@gnu.org>
3227
9d596af3
GM
3228 * s/darwin.h, s/freebsd.h, s/netbsd.h:
3229 Move DONT_REOPEN_PTY to configure.
3230
20e94fdd
GM
3231 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
3232 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
3233
e99a530f
PE
32342012-07-10 Paul Eggert <eggert@cs.ucla.edu>
3235
22ffb973
PE
3236 Remove "#define unix" that is no longer needed (Bug#11905).
3237 * s/aix4-2.h (unix): Remove; no longer needed.
3238
e9a9ae03
PE
3239 EMACS_TIME simplification (Bug#11875).
3240 This replaces macros (which typically do not work in GDB)
3241 with functions, typedefs and enums, making the code easier to debug.
3242 The functional style also makes code easier to read and maintain.
3243 * systime.h: Include <sys/time.h> on all hosts, not just if
3244 WINDOWSNT, since 'struct timeval' is needed in general.
3245 (EMACS_TIME): Now a typedef, not a macro.
3246 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
3247 not macros.
3248 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
3249 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
3250 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
3251 (EMACS_TIME_LE): Now functions, not macros.
3252 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
3253 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
3254 which are not functions. All uses rewritten to use:
3255 (make_emacs_time): New function.
3256 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
3257 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
3258 not functions. All uses rewritten to use the following, respectively:
3259 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
3260 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 3261 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
3262 * fileio.c (Fcopy_file):
3263 * xterm.c (XTflash): Get the current time closer to when it's used.
3264 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
3265
ffacb126
PE
3266 * bytecode.c (targets): Suppress -Woverride-init warnings.
3267
e99a530f
PE
3268 Simplify by avoiding confusing use of strncpy etc.
3269 * doc.c (Fsnarf_documentation):
3270 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
3271 * frame.c (Fmake_terminal_frame):
3272 * gtkutil.c (get_utf8_string):
3273 * lread.c (openp):
3274 * nsmenu.m (ns_update_menubar):
3275 * regex.c (regerror):
3276 Prefer memcpy to strncpy and strncat when either will do.
3277 * fileio.c (Fsubstitute_in_file_name):
3278 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
3279 (menu_separator_name_p):
3280 * nsmenu.m (ns_update_menubar):
3281 Prefer memcmp to strncmp when either will do.
3282 * nsterm.m: Include <ftoastr.h>.
3283 (ns_get_color):
3284 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
3285 Prefer snprintf to strncpy.
3286 * nsterm.m (ns_term_init):
3287 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
3288 * nsterm.m (ns_term_init):
3289 Avoid the need for strncpy, by using build_string or
3290 make_unibyte_string directly. Use dtoastr, not snprintf.
3291 * process.c (Fmake_network_process): Diagnose service names that
3292 are too long, rather than silently truncating them or creating
3293 non-null-terminated names.
3294 (Fnetwork_interface_info): Likewise, for interface names.
3295 * sysdep.c (system_process_attributes) [GNU_LINUX]:
3296 Prefer sprintf to strncat.
3297 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
3298 Prefer vsnprintf to vsprintf + strncpy.
3299
c59592b3
GM
33002012-07-10 Glenn Morris <rgm@gnu.org>
3301
3302 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
3303 Clarify fallback case.
3304
7d7bbefd
DA
33052012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3306
3307 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
3308 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
3309 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 3310 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
3311 where argument type is known to be a Lisp_Cons.
3312
3a4c8000
TT
33132012-07-10 Tom Tromey <tromey@redhat.com>
3314
3315 * bytecode.c (BYTE_CODE_THREADED): New macro.
3316 (BYTE_CODES): New macro. Replaces all old byte-code defines.
3317 (enum byte_code_op): New type.
3318 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
3319 (exec_byte_code): Use them. Use token threading when applicable.
3320
2a0213a6
DA
33212012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3322
3323 Optimize pure C strings initialization.
3324 * lisp.h (make_pure_string): Fix prototype.
3325 (build_pure_c_string): New function, defined as static inline. This
3326 provides a better opportunity to optimize away calls to strlen when
3327 the function is called with compile-time constant argument.
3328 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
3329 argument, adjust users accordingly. Use build_pure_c_string where
3330 appropriate.
3331 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
3332 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
3333 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
3334
cb1caeaf
DA
33352012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3336
3337 Avoid calls to strlen in miscellaneous functions.
3338 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
3339 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
3340 * lread.c (openp): Likewise.
3341
c293e30c
DA
33422012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3343
3344 Avoid calls to strlen in path processing functions.
3345 * fileio.c (file_name_as_directory): Add comment. Change to add
3346 srclen argument and return the length of result. Adjust users
3347 accordingly.
3348 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
3349 swap 1st and 2nd arguments to obey the common convention.
3350 Adjust users accordingly.
c293e30c
DA
3351 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
3352
9e059e3f
GM
33532012-07-10 Glenn Morris <rgm@gnu.org>
3354
d02eb359
GM
3355 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
3356 Move PENDING_OUTPUT_COUNT definition to configure.
3357
882cf227
GM
3358 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
3359 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
3360 * s/gnu.h (DATA_START): Move definitions to configure.
3361
af6e839f
GM
3362 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
3363 We include usg5-4-common.h, which defines them both.
3364
40289a12
GM
3365 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
3366 O_RDONLY already includes it).
3367
9e059e3f
GM
3368 Stop ns builds setting the EMACSLOADPATH environment variable.
3369 * nsterm.m (ns_load_path): Rename from ns_init_paths.
3370 Now it does not set EMACSLOADPATH, just returns the load-path string.
3371 * nsterm.h: Update accordingly.
3372 * lread.c [HAVE_NS]: Include nsterm.h.
3373 (init_lread) [HAVE_NS]: Use ns_load_path.
3374 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
3375
7c4e8ec0
GM
33762012-07-09 Glenn Morris <rgm@gnu.org>
3377
d4f600ff
GM
3378 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
3379 since the included bsd-common.h does so.
3380
cbb31951
GM
3381 Stop ns builds setting the EMACSPATH environment variable.
3382 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
3383 (ns_init_paths): Do not set EMACSPATH.
3384 * nsterm.h (ns_exec_path): Add it.
3385 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
3386 Use ns_exec_path.
3387
7c4e8ec0
GM
3388 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
3389
26bccfae
PE
33902012-07-09 Paul Eggert <eggert@cs.ucla.edu>
3391
a0bee46f
PE
3392 * process.c (wait_reading_process_output): 'waitchannels' was unset
3393 when read_kbd || !NILP (wait_for_cell); fix this.
3394
5994c183
PE
3395 Add GCC-style 'const' attribute to functions that can use it.
3396 * character.h (char_resolve_modifier_mask):
3397 * keyboard.h (make_ctrl_char):
3398 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
3399 (init_character_once, next_almost_prime, init_fns, init_image)
3400 (flush_pending_output, init_sound):
3401 * mem-limits.h (start_of_data):
3402 * menu.h (finish_menu_items):
3403 Add ATTRIBUTE_CONST.
3404 * emacs.c (DEFINE_DUMMY_FUNCTION):
3405 Declare the dummy function with ATTRIBUTE_CONST.
3406 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
3407 Add decls with ATTRIBUTE_CONST.
3408
26bccfae
PE
3409 Minor improvements to make_formatted_string.
3410 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
3411 where int is good enough, as vsprintf returns an int.
3412 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
3413
a8290ec3
DA
34142012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3415
3416 Use make_formatted_string to avoid double length calculation.
3417 * lisp.h (make_formatted_string): New prototype.
3418 * alloc.c (make_formatted_string): New function.
3419 * buffer.c (Fgenerate_new_buffer_name): Use it.
3420 * dbus.c (syms_of_dbusbind): Likewise.
3421 * editfns.c (Fcurrent_time_zone): Likewise.
3422 * filelock.c (get_boot_time): Likewise.
3423 * frame.c (make_terminal_frame, set_term_frame_name)
3424 (x_report_frame_params): Likewise.
3425 * image.c (gs_load): Likewise.
3426 * minibuf.c (get_minibuffer): Likewise.
3427 * msdos.c (dos_set_window_size): Likewise.
3428 * process.c (make_process): Likewise.
3429 * xdisp.c (ensure_echo_area_buffers): Likewise.
3430 * xsettings.c (apply_xft_settings): Likewise.
3431
d01ba2f1
GM
34322012-07-09 Glenn Morris <rgm@gnu.org>
3433
3434 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
3435 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
3436 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
3437 * nsterm.h (ns_etc_directory): Add it.
3438 * callproc.c [HAVE_NS]: Include nsterm.h.
3439 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
3440
f1f924b6
DA
34412012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3442
3443 Move marker debugging code under MARKER_DEBUG.
3444 * marker.c (MARKER_DEBUG): Move marker debugging code under
3445 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
3446 for bootstrap with --enable-checking (~3x slowdown reported
3447 by Juanma Barranquero <lekktu@gmail.com>).
3448 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
3449
ab531b66
PE
34502012-07-08 Paul Eggert <eggert@cs.ucla.edu>
3451
3452 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
3453 See <http://bugs.gnu.org/11825#29>.
3454
c4b3bc8a
EZ
34552012-07-08 Eli Zaretskii <eliz@gnu.org>
3456
3457 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
3458 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
3459 (display_line): Add commentary about displaying truncation glyphs
3460 on GUI frames.
3461 (produce_special_glyphs): Move here from term.c.
3462
3463 * term.c (produce_special_glyphs): Move to xdisp.c.
3464
3465 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
3466 section.
c4b3bc8a 3467
b676b881
AS
34682012-07-07 Andreas Schwab <schwab@linux-m68k.org>
3469
f17c5273
AS
3470 * xdisp.c (display_line): Avoid warning about implicit declaration
3471 of FRAME_FONT.
3472
298819b9
AS
3473 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
3474
b676b881
AS
3475 * lisp.h: Remove empty conditional.
3476
6045c4fd
PE
34772012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3478
b3350bf9
PE
3479 * lread.c (load_path_check): Now static.
3480
6045c4fd
PE
3481 Fix some minor --with-ns problems found by static checking.
3482 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
3483 (x_set_font) [!HAVE_X_WINDOWS]:
3484 * image.c (xpm_load_image) [HAVE_NS]:
3485 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
3486 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
3487 Remove unused local.
3488 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
3489 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
3490 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
3491 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
3492 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
3493 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
3494 Fix pointer signedness problem.
3495 * xfaces.c (FRAME_X_FONT_TABLE):
3496 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
3497
929e7845
GM
34982012-07-07 Glenn Morris <rgm@gnu.org>
3499
3500 * lread.c (load_path_check): New function, split from init_lread.
3501 (init_lread): Reorganize. Motivation:
3502 If EMACSLOADPATH is set, check/warn about that rather than the
3503 defaults, which we are not going to use. Hence we can remove
3504 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
3505 Don't warn if site-lisp directories are missing.
3506 If not installed, start from a blank load-path, since
3507 PATH_LOADSEARCH refers to the eventual installation directories.
3508
58dd0aa4
EZ
35092012-07-07 Eli Zaretskii <eliz@gnu.org>
3510
3511 Support truncation and continuation glyphs on GUI frames, when
3512 fringes are disabled. (Bug#11832)
3513 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
3514 continuation glyphs even if on GUI frames.
3515 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
3516 or both, are absent.
3517 (start_display, move_it_in_display_line_to): Handle the case of a
3518 GUI frame without a fringe to display continuation or truncation
3519 glyphs.
3520 (insert_left_trunc_glyphs): Support GUI frames: make sure
3521 truncation glyphs overwrite enough glyphs from the current line to
3522 have sufficient space in pixels.
3523 (display_line): Support truncation and continuation glyphs on GUI
3524 frames. If some spare pixels are left on the line after inserting
3525 the truncation glyphs, fill that space with a stretch glyph of a
3526 suitably computed width.
3527
3528 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
3529 produce_glyphs, to support GUI sessions.
3530
31571fd7
PE
35312012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3532
5a16b9bc
PE
3533 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
3534
f3047c75
PE
3535 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
3536
31571fd7
PE
3537 Do not require float-time's arg to fit in time_t (Bug#11825).
3538 This works better on hosts where time_t is unsigned, and where
3539 float-time is applied to the (negative) difference between two times.
3540 * editfns.c (decode_time_components): Last arg is now double *,
3541 not int *, and means to store all the result as a double, without
3542 worrying about whether the seconds part fits in time_t.
3543 All callers changed.
3544 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
3545 All callers changed.
3546 (Ffloat_time): Do not fail merely because the specified time falls
3547 outside of time_t range.
3548
4516fbef
GM
35492012-07-07 Glenn Morris <rgm@gnu.org>
3550
3551 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
3552 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
3553 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
3554
07adc2c6
JB
35552012-07-07 Juanma Barranquero <lekktu@gmail.com>
3556
3557 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
3558 Update dependencies.
3559
3560 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
3561
fd573f31
PE
35622012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3563
fee5959d
PE
3564 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
3565 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
3566 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
3567 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
3568 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
3569 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
3570
fd573f31
PE
3571 * xfont.c (compare_font_names): Redo to omit the need for casts.
3572
ddadbc0e
AS
35732012-07-06 Andreas Schwab <schwab@linux-m68k.org>
3574
fca8d6b6
AS
3575 * xfns.c (Fx_change_window_property): Doc fix.
3576 * w32fns.c (Fx_change_window_property): Doc fix.
3577
ddadbc0e
AS
3578 * w32fns.c (Fx_window_property): Accept the same arguments as the
3579 X Windows version. Doc fix.
3580 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
3581
ed9265fc 35822012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
3583 Eli Zaretskii <eliz@gnu.org>
3584
3585 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
3586 Windows-specific code from nt/config.nt moved here.
3587 Obsolete settings removed.
3588
216ee680
PE
35892012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3590
3591 * process.c: Avoid unnecessary calls to gettime.
3592 (wait_reading_process_output): Don't get the time of day
3593 when gobbling data immediately and not waiting, as there's no need
3594 for it in that case. This removes a FIXME.
3595
bdd091e4
JD
35962012-07-06 Jan Djärv <jan.h.d@swipnet.se>
3597
3598 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
3599 is defined (Bug#11768).
3600
9d44f8ce
DA
36012012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3602
3603 Fix marker debugging code.
3604 * marker.c (byte_char_debug_check): Do not perform the check
3605 if buffer is not multibyte.
090bd7cb
JB
3606 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3607 Call byte_char_debug_check with correct arguments.
9d44f8ce 3608
90fc4786
DA
36092012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3610
3611 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
3612 * marker.c (byte_char_debug_check, count_markers):
3613 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
3614 (byte_debug_flag): Remove.
3615 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3616 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
3617
7b7ae965
DA
36182012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3619
4e57b342
DA
3620 Avoid code repetition in marker-related functions.
3621 * marker.c (attach_marker): New function.
3622 (Fset_marker, set_marker_restricted, set_marker_both)
3623 (set_marker_restricted_both): Use it.
3624 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
3625 Consistently rename charno to charpos.
3626 (marker_position): Add eassert.
3627 (marker_byte_position): Convert to eassert.
3628
36292012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3630
3631 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 3632 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 3633 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 3634
657924ff
DA
36352012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3636
3637 Introduce fast path for the widely used marker operation.
3638 * alloc.c (build_marker): New function.
3639 * lisp.h (build_marker): New prototype.
3640 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
3641 * composite.c (autocmp_chars): Likewise.
3642 * editfns.c (buildmark): Remove.
3643 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
3644 (save_restriction_save): Use build_marker.
3645 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
3646 * window.c (save_window_save): Likewise.
3647
041a49a6
DA
36482012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3649
3650 Do not use Fdelete_overlay in delete_all_overlays
3651 to avoid redundant calls to unchain_overlay.
3652 * buffer.c (drop_overlay): New function.
3653 (delete_all_overlays, Fdelete_overlay): Use it.
3654 * minibuf.c (get_minibuffer): Fix comment.
3655
7dca65a4
PE
36562012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3657
3658 Port to OpenBSD 5.1 amd64.
3659 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
3660 This is needed for OpenBSD, and should be harmless on all BSD systems.
3661 Also, include <sys/sysctl.h>, as it should be available on all
3662 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
3663 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
3664 use p_pid member, not kp_proc.pid.
3665
8eb876e2
GM
36662012-07-06 Glenn Morris <rgm@gnu.org>
3667
3668 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
3669
38182d90
PE
36702012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3671
3672 More xmalloc and related cleanup.
3673 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
3674 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
3675 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
3676 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
3677 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
3678 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
3679 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
3680 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
3681 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
3682 * xterm.c:
3683 Omit needless casts involving void * pointers and allocation.
3684 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
3685 as the former is more robust if P's type is changed.
3686 Prefer xzalloc to xmalloc + memset 0.
3687 Simplify malloc-or-realloc to realloc.
3688 Don't worry about xmalloc returning a null pointer.
3689 Prefer xstrdup to xmalloc + strcpy.
3690 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
3691 growing it.
3692 * keyboard.c (apply_modifiers_uncached): Prefer local array to
3693 alloca of a constant.
3694
6dd5a677
EZ
36952012-07-05 Eli Zaretskii <eliz@gnu.org>
3696
3697 * xdisp.c (display_line): Fix horizontal pixel coordinates when
3698 hscroll is larger than the line width. Fixes long and futile
3699 looping inside extend_face_to_end_of_line (on a TTY) producing
3700 glyphs that are not needed and thrown away.
3701
6b312f0f
DA
37022012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3703
3704 * marker.c (set_marker_restricted_both): Simplify by using
3705 clip_to_bounds.
3706
f520ef9b
PE
37072012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3708
3709 * editfns.c (region_limit): Simplify by using clip_to_bounds.
3710
383b7c95
JD
37112012-07-05 Jan Djärv <jan.h.d@swipnet.se>
3712
3713 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
3714 not defined (Bug#11768).
3715 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
3716 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
3717 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
3718 followed by gtk_box_set_homogeneous (Bug#11768).
3719 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
3720 (update_theme_scrollbar_width, xg_create_scroll_bar):
3721 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
3722 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
3723 (is_box_type): New function (Bug#11768).
3724 (xg_tool_item_stale_p): Call is_box_type.
5293d758 3725 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
3726 with default display (Bug#11768).
3727
d6e7bf45
EZ
37282012-07-05 Eli Zaretskii <eliz@gnu.org>
3729
3730 * xdisp.c (window_hscroll_limited): New function.
3731 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
3732 coordinates when window's hscroll is set to insanely large
3733 values. (Bug#11857)
3734
431391ec
JB
37352012-07-05 Juanma Barranquero <lekktu@gmail.com>
3736
3737 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
3738 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
3739
23f86fce
DA
37402012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3741
3742 Cleanup xmalloc.
3743 * lisp.h (xzalloc): New prototype. Omit needless casts.
3744 * alloc.c (xzalloc): New function. Omit needless casts.
3745 * charset.c: Omit needless casts. Convert all calls to
3746 xmalloc with following memset to xzalloc.
3747 * dispnew.c: Likewise.
3748 * fringe.c: Likewise.
3749 * image.c: Likewise.
3750 * sound.c: Likewise.
3751 * term.c: Likewise.
3752 * w32fns.c: Likewise.
3753 * w32font.c: Likewise.
3754 * w32term.c: Likewise.
3755 * xfaces.c: Likewise.
3756 * xfns.c: Likewise.
3757 * xterm.c: Likewise.
3758 * atimer.c: Omit needless casts.
3759 * buffer.c: Likewise.
3760 * callproc.c: Likewise.
3761 * ccl.c: Likewise.
3762 * coding.c: Likewise.
3763 * composite.c: Likewise.
3764 * doc.c: Likewise.
3765 * doprnt.c: Likewise.
3766 * editfns.c: Likewise.
3767 * emacs.c: Likewise.
3768 * eval.c: Likewise.
3769 * filelock.c: Likewise.
3770 * fns.c: Likewise.
3771 * gtkutil.c: Likewise.
3772 * keyboard.c: Likewise.
3773 * lisp.h: Likewise.
3774 * lread.c: Likewise.
3775 * minibuf.c: Likewise.
3776 * msdos.c: Likewise.
3777 * print.c: Likewise.
3778 * process.c: Likewise.
3779 * region-cache.c: Likewise.
3780 * search.c: Likewise.
3781 * sysdep.c: Likewise.
3782 * termcap.c: Likewise.
3783 * terminal.c: Likewise.
3784 * tparam.c: Likewise.
3785 * w16select.c: Likewise.
3786 * w32.c: Likewise.
3787 * w32reg.c: Likewise.
3788 * w32select.c: Likewise.
3789 * w32uniscribe.c: Likewise.
3790 * widget.c: Likewise.
3791 * xdisp.c: Likewise.
3792 * xmenu.c: Likewise.
3793 * xrdb.c: Likewise.
3794 * xselect.c: Likewise.
3795
0497dc44
PE
37962012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3797
3798 * fileio.c (time_error_value): Check the right error number.
3799 Problem reported by Troels Nielsen in
3800 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
3801
356e7178
PE
38022012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3803
4e71fd89
PE
3804 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
3805 This should be fixed in a better way; see Eli Zaretskii in
3806 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
3807 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
3808
f0941253
PE
3809 * fileio.c (time_error_value): Rename from special_mtime.
3810 The old name's problems were noted by Eli Zaretskii in
3811 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
3812
065c9eb4
PE
3813 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
3814 This variable's comment says Emacs needs at least one GDB-visible
3815 symbol of type enum pvec_type, to work around GDB problems.
3816 The symbol's value doesn't matter.
3817
356e7178
PE
3818 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
3819 that causes compilation to fail on pre-C99 compilers.
3820
ed9265fc 38212012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
3822
3823 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
3824 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
3825
3884d954
DA
38262012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3827
d209e2fb 3828 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
3829 headers for buffer_defaults and buffer_local_symbols.
3830 Reported by Juanma Barranquero <lekktu@gmail.com>.
3831
ee28be33
SM
38322012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3833
3834 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
3835 * lisp.h (enum pvec_type): Use fewer bits.
3836 (PSEUDOVECTOR_SIZE_BITS): New constant.
3837 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
3838 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
3839 change in pvec_type.
3840 (PSEUDOVECTOR_TYPEP): New macro.
3841 (TYPED_PSEUDOVECTORP): Use it.
3842 * fns.c (internal_equal): Adapt code to extract pvectype.
3843 * emacs.c (gdb_pvec_type): Update type.
3844 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
3845 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
3846 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
3847 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
3848 (sweep_vectors): Use it. Use local var `total_bytes' instead of
3849 abusing vector->header.next.nbytes.
3850 (live_vector_p): Use PVEC_TYPE.
3851 (mark_object): Adapt code to extract pvectype. Use switch.
3852
c7f2cd7f
PE
38532012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3854
3855 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
3856 Tighten new eassert a bit.
3857
8ce70ed2
DA
38582012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3859
3860 Fix compilation with --enable-gcc-warnings and -O1
3861 optimization level.
3862 * doprnt.c (doprnt): Change type of tem to int, initialize
3863 to avoid compiler warning. Add eassert.
3864 * search.c (simple_search): Initialize match_byte to avoid
3865 compiler warning. Add eassert.
3866
dea7f1e5
PE
38672012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3868
24a212eb
PE
3869 Avoid weird behavior with large horizontal scrolls.
3870 Without this change, for example, large hscroll values would
3871 mess up Emacs's display on Fedora 15 x86, presumably due to
3872 overflows in int calculations in the display code.
3873 Also, if buffers had long lines, Emacs would freeze.
3874 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
3875 (set_window_hscroll): New function, containing the old guts of
3876 Fset_window_hscroll. Return the clipped value.
3877 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
3878 This avoids the need to check against PTRDIFF_MAX.
3879
dea7f1e5
PE
3880 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
3881
76046526
DA
38822012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3883
3884 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
3885
39adff0d
PE
38862012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3887
63807d47
PE
3888 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
3889 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
3890 since GCC 4.4.6 issues a bogus warning for them.
3891
39adff0d
PE
3892 Fix bugs in file timestamp newness comparisons.
3893 * fileio.c (Ffile_newer_than_file_p):
3894 * lread.c (Fload): Use full timestamp resolution of files,
3895 not just the 1-second resolution, so that files that are only
3896 slightly newer still count as newer.
3897 * fileio.c (Ffile_newer_than_file_p): Don't assume file
3898 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
3899
dbeed9a6
PE
39002012-07-03 Paul Eggert <eggert@cs.ucla.edu>
3901
3902 * fileio.c: Improve handling of file time marker. (Bug#11852)
3903 (special_mtime): New function.
3904 (Finsert_file_contents, Fverify_visited_file_modtime):
3905 Use it to set special mtime values consistently.
3906
636334d6
AS
39072012-07-03 Andreas Schwab <schwab@linux-m68k.org>
3908
3909 * fileio.c (Finsert_file_contents): Properly handle st_mtime
3910 marker for non-existing file. (Bug#11852)
3911
e2017fe2
GM
39122012-07-03 Glenn Morris <rgm@gnu.org>
3913
3914 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
3915 and did not make it into globals.h).
3916
404dbd37
TT
39172012-07-03 Tom Tromey <tromey@redhat.com>
3918
3919 * window.c (Fset_window_margins, Fset_window_fringes)
3920 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
3921 * textprop.c (Fprevious_property_change): No longer static.
3922 * syntax.c (Fsyntax_table_p): No longer static.
3923 * process.c (Fget_process, Fprocess_datagram_address): No longer
3924 static.
3925 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
3926 * keyboard.c (Fcommand_execute): No longer static.
3927 Remove EXFUN.
3928 * insdel.c (Fcombine_after_change_execute): No longer static.
3929 * image.c (Finit_image_library): No longer static.
3930 * fileio.c (Fmake_symbolic_link): No longer static.
3931 * eval.c (Ffetch_bytecode): No longer static.
3932 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
3933 * doc.c (Fdocumentation_property, Fsnarf_documentation):
3934 No longer static.
404dbd37
TT
3935 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
3936 static.
3937 * dired.c (Ffile_attributes): No longer static.
3938 * composite.c (Fcomposition_get_gstring): No longer static.
3939 * callproc.c (Fgetenv_internal): No longer static.
3940
3941 * ccl.h: Remove EXFUNs.
3942 * buffer.h: Remove EXFUNs.
3943 * dispextern.h: Remove EXFUNs.
3944 * intervals.h: Remove EXFUNs.
3945 * fontset.h: Remove EXFUN.
3946 * font.h: Remove EXFUNs.
3947 * dosfns.c (system_process_attributes): Remove EXFUN.
3948 * keymap.h: Remove EXFUNs.
3949 * lisp.h: Remove EXFUNs.
3950 * w32term.h: Remove EXFUNs.
3951 * window.h: Remove EXFUNs.
3952 * xsettings.h: Remove EXFUN.
3953 * xterm.h: Remove EXFUN.
3954
8e4fd1e1
GM
39552012-07-03 Glenn Morris <rgm@gnu.org>
3956
3957 * lisp.h (Frandom): Make it visible to C.
3958 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
3959 buffer for invisible buffers. (Bug#1229)
3960
ca95b3eb
DA
39612012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3962
3963 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
3964 values which aren't power of 2.
14ae4239
BT
3965 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
3966 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
3967 accordingly.
3968
7555c33f
SM
39692012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
3970
3971 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
3972
3973 * alloc.c (mark_object): Revert part of last patch to use `switch'.
3974
d12e8f5a
DA
39752012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3976
3977 * alloc.c (allocate_vector_block): Remove redundant
3978 calls to mallopt if DOUG_LEA_MALLOC is defined.
3979 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
3980 avoid calls to mallopt if zero_vector is returned.
3981
296094c3
DA
39822012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3983
3984 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
3985 is enabled, avoid dereferencing NULL current_sblock if
3986 running undumped.
3987
36429c89
DA
39882012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3989
3990 Cleanup basic buffer management.
3991 * buffer.h (struct buffer): Change layout to use generic vector
3992 marking code. Fix some comments. Change type of 'clip_changed'
3993 to bitfield. Remove unused #ifndef old.
3994 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
3995 (GET_OVERLAYS_AT): Fix indentation.
3996 (for_each_per_buffer_object_at): New macro.
3997 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
3998 (Fbuffer_local_variables): Use it.
3999 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
4000 * alloc.c (allocate_buffer): Adjust to match new layout of
4001 struct buffer. Fix comment.
4002 (mark_overlay): New function.
4003 (mark_buffer): Use it. Use mark_vectorlike to mark normal
4004 Lisp area of struct buffer.
4005 (mark_object): Use it. Adjust marking of misc objects
4006 and related comments.
4007
3b3e4cac
PE
40082012-07-02 Paul Eggert <eggert@cs.ucla.edu>
4009
4010 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
4011 wrapper that is not needed because the wrapped code is a no-op (zero
4012 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
4013 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
4014
cf5c0175
DA
40152012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
4016
4017 * alloc.c (mark_buffer): Simplify. Remove prototype.
4018 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 4019 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
4020 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
4021 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 4022
ca26824c
GM
40232012-06-30 Glenn Morris <rgm@gnu.org>
4024
2e4c5312
GM
4025 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
4026
ca26824c
GM
4027 * epaths.in (PATH_SITELOADSEARCH): New.
4028 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
4029 This is rather than relying on --enable-locallisppath elements
4030 having "site-lisp" in their names. (Bug#10208#25, 11658)
4031
0d23c240
EZ
40322012-06-30 Eli Zaretskii <eliz@gnu.org>
4033
c9240d7a
EZ
4034 * w32proc.c (sys_select): Accept and ignore one more argument.
4035
4036 * w32.c (emacs_gnutls_pull): Call select with one more argument.
4037
0d23c240 4038 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 4039 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
4040
4041 * sysdep.c: Don't include dos.h and dosfns.h.
4042
4043 * process.c (sys_select):
4044 * msdos.c (sys_select): Accept one more argument and ignore it.
4045
4046 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
4047 adapt data types and code to that.
4048
4049 * dosfns.c:
4050 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
4051 which clashes with the gnulib function of the same name.
4052
af5a5a98
AS
40532012-06-30 Andreas Schwab <schwab@linux-m68k.org>
4054
c5e4379c
AS
4055 * font.c (font_style_to_value, font_style_symbolic)
4056 (font_prop_validate_style): Add type checks for values in
4057 font_style_table.
4058
af5a5a98
AS
4059 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
4060 argument.
4061 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
4062 uses.
4063
8d38f461
EZ
40642012-06-29 Eli Zaretskii <eliz@gnu.org>
4065
2e5a6631
EZ
4066 * xdisp.c (try_window_id): Undo last change.
4067
8d38f461
EZ
4068 * w32.c (getwd): Adjust commentary about startup_dir.
4069 (init_environment): Always call sys_access, even in non-MSVC
4070 builds. Don't chdir to the directory of the Emacs executable.
4071 This undoes code from 1997 which was justified by the need to
4072 "avoid conflicts when removing and renaming directories". But its
4073 downside was that every relative file name was being interpreted
4074 relative to the directory of the Emacs executable, which can never
4075 be TRT. In particular, it broke sys_access when called with
4076 relative file names.
4077 (sys_access): Map GetLastError to errno.
4078
2af3565e
DA
40792012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4080
4081 * window.h (struct window): Change type of 'fringes_outside_margins'
4082 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 4083 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
4084 Adjust comment.
4085 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
4086 to ptrdiff_t.
4087
c8d3a25c 40882012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 4089
c8d3a25c
GM
4090 * gnutls.c (emacs_gnutls_handshake):
4091 Add QUIT to make the loop interruptible.
57570cd3 4092
c8d3a25c 40932012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 4094
c8d3a25c
GM
4095 * charset.c (init_charset): Make lack of etc/charsets fatal.
4096
3e984ee8
DA
40972012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4098
4099 * editfns.c (region_limit): Fix type mismatch.
4100
ef884f23
DA
41012012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4102
4103 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
4104 undefined. Convert from xassert to eassert.
4105 * nsmenu.m: Convert from xassert to eassert.
4106 * nsterm.m: Likewise.
4107
7d7e0027
SM
41082012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
4109
4110 * editfns.c (region_limit): Clip to narrowing (bug#11770).
4111
aa754e6a
PE
41122012-06-28 Paul Eggert <eggert@cs.ucla.edu>
4113
4114 Avoid integer overflow on scroll-left and scroll-right.
4115 * window.c (HSCROLL_MAX): New macro.
4116 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
4117 overflow when requested scroll falls outside ptrdiff_t range.
4118
80b00b08
DA
41192012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4120
4121 * window.h (struct window): Change type of 'hscroll',
4122 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
4123 'last_modified' and 'last_overlay_modified' to EMACS_INT.
4124 Adjust users accordingly.
4125 * xdisp.c (try_cursor_movement): Replace type check with eassert.
4126 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
4127 from EMACS_INT to ptrdiff_t.
4128 (make_window): Omit redundant initialization.
4129
62b2bcf6
JB
41302012-06-28 Juanma Barranquero <lekktu@gmail.com>
4131
4132 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
4133
45942c7d
DA
41342012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4135
4136 * window.h (struct window): Change type of 'use_time' and
4137 'sequence_number' from Lisp_Object to int.
4138 * frame.c (make_frame): Adjust users accordingly.
4139 * print.c (print_object): Likewise.
4140 * window.c (select_window, Fwindow_use_time, make_parent_window)
4141 (make_window): Likewise.
4142
e509cfa6
DA
41432012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4144
4145 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
4146 enabled with --enable-checking=[all,glyphs] configure option.
4147 Fix GLYPH_DEBUG usage assuming that it may be undefined,
4148 adjust comments accordingly.
4149 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
4150 undefined, adjust comments accordingly.
4151 * image.c: Likewise.
4152 * scroll.c: Likewise.
4153 * w32fns.c: Likewise.
4154 * w32term.c: Likewise.
4155 * xdisp.c: Likewise.
4156 * xfaces.c: Likewise.
4157 * xfns.c: Likewise.
4158 * xterm.c: Likewise.
4159
a54e2c05
DA
41602012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4161
4162 Generalize run-time debugging checks.
4163 * dispextern.h (XASSERTS): Remove.
4164 * fontset.c (xassert): Remove.
4165 Convert from xassert to eassert.
4166 * alloc.c: Convert from xassert to eassert.
4167 * bidi.c: Likewise.
4168 * dispnew.c: Likewise.
4169 * fns.c: Likewise.
4170 * fringe.c: Likewise.
4171 * ftfont.c: Likewise.
4172 * gtkutil.c: Likewise.
4173 * image.c: Likewise.
4174 * keyboard.c: Likewise.
4175 * menu.c: Likewise.
4176 * process.c: Likewise.
4177 * scroll.c: Likewise.
4178 * sound.c: Likewise.
4179 * term.c: Likewise.
4180 * w32console.c: Likewise.
4181 * w32fns.c: Likewise.
4182 * w32term.c: Likewise.
4183 * window.c: Likewise.
4184 * xdisp.c: Likewise.
4185 * xfaces.c: Likewise.
4186 * xfns.c: Likewise.
4187 * xselect.c: Likewise.
4188 * xterm.c: Likewise.
4189
1ec4b7b2
SM
41902012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
4191
4192 * fns.c (maybe_resize_hash_table): Output message when growing the
4193 purify-hashtable.
4194
2014308a
DA
41952012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4196
4197 * alloc.c (allocate_string_data): Remove dead code.
4198 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
4199 avoid GCC warning about unused macro.
4200
246155eb
DA
42012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4202
4203 * alloc.c (allocate_string): Omit intervals initialization.
4204 * alloc.c (make_uninit_multibyte_string): Initialize intervals
4205 as in make_pure_string and make_pure_c_string.
4206
43184b7b
DA
42072012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4208
d209e2fb 4209 * alloc.c (allocate_string): Fix last change.
43184b7b 4210
3fe6dd74
DA
42112012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4212
d209e2fb 4213 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
4214 to memset, add explicit initialization where appropriate.
4215
1ba6038a
GM
42162012-06-27 Glenn Morris <rgm@gnu.org>
4217
4218 * lisp.mk (lisp): Remove paths.elc.
4219
c89926a5
CY
42202012-06-27 Chong Yidong <cyd@gnu.org>
4221
4222 * doc.c (Fsubstitute_command_keys): Fix punctuation.
4223
ed6b3510
JW
42242012-06-26 John Wiegley <johnw@newartisans.com>
4225
1ec4b7b2 4226 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
4227 on Mac OS X Lion: __mod_init_func and __mod_term_func.
4228
ed6b3510
JW
4229 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
4230 when building with Clang.
4231
8edd4a2b
SM
42322012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
4233
4234 * eval.c (Fapply): Allow calling it with a single argument.
4235
f6f62d1b
EZ
42362012-06-26 Eli Zaretskii <eliz@gnu.org>
4237
4238 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
4239 _stricmp and _strnicmp.
4240 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
4241
62efea5e
DA
42422012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4243
4244 * alloc.c (allocate_window): Zero out non-Lisp part of newly
4245 allocated window.
4246 (allocate_process): Likewise for new process.
8edd4a2b 4247 (allocate_terminal): Change to use offsetof.
62efea5e
DA
4248 (allocate_frame): Likewise.
4249 * frame.c (make_frame): Omit redundant initialization.
4250 * window.c (make_parent_window): Use memset.
4251 (make_window): Omit redundant initialization.
4252 * process.c (make_process): Omit redundant initialization.
4253 * terminal.c (create_terminal): Likewise.
4254
42997f4d
DA
42552012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4256
4257 * term.c (delete_tty): Remove redundant call to memset.
4258
1130ecfc
DA
42592012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4260
4261 * alloc.c: Remove build_string.
4262 * lisp.h: Define build_string as static inline. This provides
4263 a better opportunity to optimize away calls to strlen when the
4264 function is called with compile-time constant argument.
4265 * image.c (imagemagick_error): Convert to build_string.
4266 * w32proc.c (sys_spawnve): Likewise.
4267 * xterm.c (x_term_init): Likewise.
4268
cf38a720
PE
42692012-06-26 Paul Eggert <eggert@cs.ucla.edu>
4270
99027bdd
PE
4271 Use sprintf return value instead of invoking strlen on result.
4272 In the old days this wasn't portable, since some sprintf
4273 implementations returned char *. But they died out years ago and
4274 Emacs already assumes sprintf returns int.
4275 Similarly for float_to_string.
4276 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
4277 * ccl.c (ccl_driver):
4278 * character.c (string_escape_byte8):
4279 * data.c (Fnumber_to_string):
4280 * doprnt.c (doprnt):
4281 * print.c (print_object):
4282 * xdisp.c (message_dolog):
4283 * xfns.c (syms_of_xfns):
4284 Use sprintf or float_to_string result to avoid need to call strlen.
4285 * data.c (Fnumber_to_string):
4286 Use make_unibyte_string, since the string must be ASCII.
4287 * lisp.h, print.c (float_to_string): Now returns int length.
4288 * term.c (produce_glyphless_glyph):
4289 Use sprintf result rather than recomputing it.
4290
cf38a720
PE
4291 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
4292 * Makefile.in (ALL_CFLAGS):
4293 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
4294 * gmalloc.c, regex.c: Include <config.h> unconditionally.
4295
3511c784
DA
42962012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4297
0a08eb21 4298 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
4299 strcasecmp if available.
4300 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
4301
fb7da12e
AS
43022012-06-25 Andreas Schwab <schwab@linux-m68k.org>
4303
4304 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
4305 Avoid comma operator.
4306 * menu.c (push_submenu_start, push_submenu_end)
4307 (push_left_right_boundary, push_menu_pane): Likewise.
4308 * msdos.c (dos_rawgetc): Likewise.
4309
afa2ffd8
DA
43102012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4311
4312 * xfns.c (xic_create_fontsetname): Remove redundant calls
4313 to memset.
4314
b3b4476b
PE
43152012-06-25 Paul Eggert <eggert@cs.ucla.edu>
4316
4495ff38
PE
4317 * gtkutil.c (get_utf8_string): Remove redundant assignment.
4318 sprintf already null-terminates its output.
4319
b3b4476b
PE
4320 * xfns.c (x_window): Remove redundant cast.
4321
b00876c9
DA
43222012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4323
4324 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
4325 `const char *' to `char *' to avoid compiler warning.
4326
d188e26b
PE
43272012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4328
885d1d74
PE
4329 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
4330 instead of truncating it to 63 (admittedly a generous limit).
4331
d188e26b
PE
4332 * process.c: Fix spelling and caps in comments.
4333
e2f560b1
DN
43342012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
4335
e86db54b 4336 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
4337 * sysdep.c (setpgrp): Remove definition, not used in this file.
4338
7583a3a1
JB
43392012-06-24 Juanma Barranquero <lekktu@gmail.com>
4340
4341 * makefile.w32-in: Update dependencies.
4342
696056c2
EZ
43432012-06-24 Eli Zaretskii <eliz@gnu.org>
4344
4345 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
4346 (SYSTIME_H): Add nt/inc/sys/time.h.
4347
4348 * systime.h [WINDOWSNT]: Include sys/time.h.
4349
4350 * s/ms-w32.h (struct timespec): Definition moved from
4351 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
4352
845ca893
PE
43532012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4354
4355 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
4356 * buffer.h (buffer_slot_type_mismatch):
4357 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4358 * eval.c (unwind_to_catch):
4359 * image.c (my_png_error, my_error_exit):
4360 * keyboard.c (quit_throw_to_read_char, user_error)
4361 (Fexit_recursive_edit, Fabort_recursive_edit):
4362 * lisp.h (die, args_out_of_range, args_out_of_range_3)
4363 (wrong_type_argument, buffer_overflow, __executable_start)
4364 (memory_full, buffer_memory_full, string_overflow, Fthrow)
4365 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
4366 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
4367 (fatal):
4368 (child_setup) [!DOS_NT]:
4369 * lread.c (end_of_file_error, invalid_syntax):
4370 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4371 * puresize.h (pure_write_error):
4372 * search.c (matcher_overflow):
4373 * sound.c (sound_perror, alsa_sound_perror):
4374 * sysdep.c, syssignal.h (croak):
4375 * term.c (maybe_fatal, vfatal):
4376 * textprop.c (text_read_only):
4377 * undo.c (user_error):
4378 * unexmacosx.c (unexec_error):
4379 * xterm.c (x_ins_del_lines, x_delete_glyphs):
4380 Use _Noreturn rather than NO_RETURN.
4381 No need for separate decl merely because of _Noreturn.
4382 * sound.c (sound_warning, parse_sound):
4383 Remove unnecessary forward decls.
4384
f1dd8073
PE
43852012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4386
4387 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
4388 * lisp.h (WAIT_READING_MAX): New macro.
4389 * dispnew.c (Fsleep_for, sit_for):
4390 * keyboard.c (kbd_buffer_get_event):
4391 * process.c (Faccept_process_output):
4392 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
4393 This improves on the previous patch, which introduced a bug
4394 when time_t is unsigned and as wide as intmax_t.
4395 See <http://bugs.gnu.org/9000#51>.
4396
b82c1755
EZ
43972012-06-23 Eli Zaretskii <eliz@gnu.org>
4398
4399 * dispnew.c (sit_for, Fsleep_for):
4400 * keyboard.c (kbd_buffer_get_event):
4401 * process.c (Faccept_process_output): Avoid compiler warnings when
4402 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
4403
ca300656
JB
44042012-06-23 Juanma Barranquero <lekktu@gmail.com>
4405
049ec95b
JB
4406 * makefile.w32-in: Update dependencies.
4407
ca300656
JB
4408 * w32.c (ltime): Add return type and declare static.
4409 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
4410
db7b8d06
PE
44112012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4412
4413 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
4414 Privately reported by Herbert J. Skuhra.
4415 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
4416 All uses changed.
4417 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
4418 not make_lisp_timeval, when the argument is of type EMACS_TIME.
4419
0bd8297f
EZ
44202012-06-23 Eli Zaretskii <eliz@gnu.org>
4421
96512555
EZ
4422 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
4423 last argument of make_unibyte_string.
4424
0bd8297f
EZ
4425 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
4426 language ID in the event parameters.
4427
4428 * w32term.c (w32_read_socket): Put the new keyboard codepage into
4429 event.code, not the obscure "character set ID".
4430
63def6b6
CY
44312012-06-23 Chong Yidong <cyd@gnu.org>
4432
4433 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
4434
e8a02204
EZ
44352012-06-23 Eli Zaretskii <eliz@gnu.org>
4436
388cdec0
EZ
4437 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
4438 * w32.c (fdutimens): New function.
4439
4440 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
4441
4442 * s/ms-w32.h (pselect): Redirect to sys_select.
4443
4444 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
4445
e8a02204
EZ
4446 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
4447 in the logic of incrementing and decrementing the value of
4448 use_relocatable_buffers.
4449
d054f3fb
PE
44502012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4451
4452 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
4453 Privately reported by Herbert J. Skuhra.
4454 [__FreeBSD__]: Remove "*/" typo after "#include".
4455 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
4456 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
4457 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
4458 Don't assume EMACS_TIME and struct timeval are the same type.
4459
d35af63c
PE
44602012-06-22 Paul Eggert <eggert@cs.ucla.edu>
4461
4462 Support higher-resolution time stamps (Bug#9000).
4463 The time stamps are only nanosecond-resolution at the C level,
4464 since that's the best that any real-world system supports now.
4465 But they are picosecond-resolution at the Lisp level, as that's
4466 easy, and leaves room for future OS improvements.
4467
4468 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
4469 (LIBES): Use it.
4470
4471 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
4472 Don't get current time unless it's needed.
4473
4474 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
4475 now provides it if it's absent.
4476 (start_atimer): Port to higher-res time stamps.
4477 Check for time stamp overflow. Don't get current time more
4478 often than is needed.
4479
4480 * buffer.h (struct buffer): Buffer modtime now has high resolution.
4481 Include systime.h, not time.h.
4482 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
4483
4484 * dired.c: Include stat-time.h.
4485 (Ffile-attributes): File times now have higher resolution.
4486
4487 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
4488 (struct image): Timestamp now has higher resolution.
4489
4490 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
4491 has at least microseconds now. All uses removed.
4492 (update_frame, update_single_window, update_window, update_frame_1)
4493 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 4494 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
4495
4496 * editfns.c (time_overflow): Now extern.
4497 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
4498 (float-time, Fformat_time_string, Fcurrent_time_string)
4499 (Fcurrent_time_zone): Accept and generate higher-resolution
4500 time stamps.
4501 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
4502 (decode_time_components, lisp_seconds_argument): New functions.
4503 (make_time): Now static.
4504 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
4505 Report an error if the time is invalid, rather than having the caller
4506 do that.
4507
4508 * fileio.c: Include <stat-time.h>
4509 (Fcopy_file): Copy higher-resolution time stamps.
4510 Prefer to set the time stamp via a file descriptor if that works.
4511 (Fset_file_times, Finsert_file_contents, Fwrite_region)
4512 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
4513 (Fvisited_file_modtime, Fset_visited_file_modtime):
4514 Support higher-resolution time stamps.
4515
4516 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
4517
4518 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
4519
4520 * image.c (prepare_image_for_display, clear_image_cache)
4521 (lookup_image): Port to higer-resolution time stamps.
4522
4523 * keyboard.c (start_polling, bind_polling_period):
4524 Check for time stamp overflow.
4525 (read_char, kbd_buffer_get_event, timer_start_idle)
4526 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
4527 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
4528 Port to higher-resolution time stamps. Do not assume time_t is signed.
4529 (decode_timer): New function. Timers are now vectors of length 9,
4530 not 8, to accommodate the picosecond component.
4531 (timer_check_2): Use it.
4532
4533 * nsterm.m (select_timeout, timeval_subtract): Remove.
4534 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
4535 as they're a bit more accurate and handle overflow better.
4536 (ns_select): Change prototype to be compatible with pselect.
4537 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
4538 * nsterm.h (ns_select): Adjust prototype.
4539
4540 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
4541 us-resolution time stamps.
4542 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
4543
4544 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
4545
4546 * lisp.h (time_overflow): New decl.
4547 (wait_reading_process_output): First arg is now intmax_t, not int,
4548 to accommodate larger waits.
4549
4550 * process.h (struct Lisp_Process.read_output_delay):
4551 Now counts nanoseconds, not microseconds.
4552 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
4553 EMACS_HAS_USECS.
4554 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
4555 (wait_reading_process_output):
4556 Port to ns-resolution time stamps.
4557 (Faccept_process_output, wait_reading_process_output):
4558 Check for time stamp overflow. Do not assume time_t is signed.
4559 (select_wrapper): Remove; we now use pselect.
4560 (Fprocess_attributes): Now generates ns-resolution time stamps.
4561
4562 * sysdep.c: Include utimens.h. Don't include utime.h
4563 or worry about struct utimbuf; gnulib does that for us now.
4564 (gettimeofday): Remove; gnulib provides a substitute.
4565 (make_timeval): New function.
4566 (set_file_times): Now sets ns-resolution time stamps.
4567 New arg FD; all uses changed.
4568 (time_from_jiffies, ltime_from_jiffies, get_up_time)
4569 (system_process_attributes):
4570 Now returns ns-resolution time stamp. All uses changed.
4571 Check for time stamp overflow.
4572
4573 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
4574 provides a substitute now.
4575
4576 * systime.h: Include timespec.h rather than sys/time.h and time.h,
4577 since it guarantees struct timespec.
4578 (EMACS_TIME): Now struct timespec, so that we can support
4579 ns-resolution time stamps.
4580 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
4581 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
4582 (EMACS_USECS): Remove.
4583 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
4584 so multiply the arg by 1000 before storing it.
4585 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
4586 New macros.
4587 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
4588 Port to ns-resolution time stamps.
4589 (EMACS_TIME_NEG_P): Remove; replaced by....
4590 (EMACS_TIME_SIGN): New macro.
4591 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
4592 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
4593 (set_file_times, make_time, lisp_time_argument): Adjust signature.
4594 (make_timeval, make_lisp_time, decode_time_components): New decls.
4595 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
4596 that it mishandled time_t overflow. You can't compare by subtracting!
4597 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
4598 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
4599
4600 * term.c: Include <sys/time.h>.
4601 (timeval_to_Time): New function, for proper overflow wraparound.
4602 (term_mouse_position, term_mouse_click): Use it.
4603
4604 * undo.c (record_first_change): Support higher-resolution time stamps
4605 in the undo buffer.
4606 (Fprimitive_undo): Use them when restoring time stamps.
4607
4608 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
4609 (w32_get_internal_run_time):
4610 Port to higher-resolution Emacs time stamps.
4611 (ltime): Now accepts single 64-bit integer, as that's more convenient
4612 for callers.
4613
4614 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
4615
4616 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
4617 for compatibility with pselect. Support ns-resolution time stamps.
4618
4619 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
4620
4621 * xselect.c (wait_for_property_change, x_get_foreign_selection):
4622 Check for time stamp overflow, and support ns-resolution time stamps.
4623
4624 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
4625 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
4626 (timeval_subtract): Remove; no longer needed.
4627 (XTflash, XTring_bell, x_wait_for_event):
4628 Port to ns-resolution time stamps. Don't assume time_t is signed.
4629
b6a92dfe
CY
46302012-06-22 Chong Yidong <cyd@gnu.org>
4631
4632 * xdisp.c (x_consider_frame_title): Revert last change.
4633
d251c37c
EZ
46342012-06-22 Eli Zaretskii <eliz@gnu.org>
4635
4636 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
4637 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
4638 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
4639 staticidx goes up to 1597 out of 1600 = 0x640.)
4640
f10deafb
PE
46412012-06-20 Paul Eggert <eggert@cs.ucla.edu>
4642
4643 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
4644 Otherwise, the umask might be mistakenly 0 while handling input signals.
4645
ec6de1e2
SM
46462012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
4647
4648 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
4649
28be1ada
DA
46502012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
4651
4652 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
4653 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
4654 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
4655 access to `contents' member of Lisp_Vector objects with AREF and ASET
4656 where appropriate.
4657
c6bf3022
CY
46582012-06-19 Chong Yidong <cyd@gnu.org>
4659
4660 * frame.c (delete_frame): When selecting a frame on a different
4661 text terminal, do not alter the terminal's top-frame.
4662
4663 * xdisp.c (format_mode_line_unwind_data): Record the target
4664 frame's selected window and its terminal's top-frame.
4665 (unwind_format_mode_line): Restore them.
4666 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
4667 Callers changed.
4668 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
4669 since tty frames can be explicitly named.
4670 (prepare_menu_bars): Likewise.
4671
4672 * term.c (Ftty_top_frame): New function.
4673
defd4196
PE
46742012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4675
4676 Port byte-code-meter to modern targets.
4677 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
4678 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 4679 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
4680 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
4681 (METER_1, METER_2): Simplify.
4682
1053a871
SM
46832012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
4684
4685 * data.c (Fdefalias): Return `symbol' (bug#11686).
4686
b7e8d081
MR
46872012-06-18 Martin Rudalics <rudalics@gmx.at>
4688
4689 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
4690 gets killed during executing of this function (Bug#11665).
4691 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
4692 (Vkill_buffer_query_functions): In doc-string say that functions
4693 run by this hook should not change the current buffer.
4694
7ea2b339
PE
46952012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4696
4697 Fix recently-introduced process.c problems found by static checking.
4698 * process.c (write_queue_push, write_queue_pop, send_process):
4699 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
4700 (write_queue_pop): Fix pointer signedness problem.
4701 (send_process): Remove unused local.
4702
96a313a1
CY
47032012-06-17 Chong Yidong <cyd@gnu.org>
4704
4705 * xdisp.c (redisplay_internal): No need to redisplay terminal
4706 frames that are not on top.
4707
20ca2e94
TN
47082012-06-17 Troels Nielsen <bn.troels@gmail.com>
4709
4710 * process.c (make_process): Initialize write_queue.
4711 (write_queue_push, write_queue_pop): New functions.
4712 (send_process): Use them to maintain correct ordering of process
4713 writes (Bug#10815).
4714
9a900ca9
PE
47152012-06-17 Paul Eggert <eggert@cs.ucla.edu>
4716
310fbfa8
PE
4717 * lisp.h (eassert): Assume C89 or later.
4718 This removes the need for CHECK.
4719 (CHECK): Remove. Its comments about always evaluating its
4720 argument were confusing, as 'eassert' typically does not evaluate
4721 its argument.
4722
27bb1ca4
PE
4723 * coding.c (produce_chars): Use ptrdiff_t, not int.
4724
9a900ca9
PE
4725 * xterm.c (x_draw_underwave): Check for integer overflow.
4726 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
4727
41b7f8bc 47282012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
4729
4730 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
4731 referenced (Bug#11583).
4732
9b0e3eba
AA
47332012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
4734
4735 Implement wave-style variant of underlining.
4736 * dispextern.h (face_underline_type): New enum.
4737 (face): Add field for underline type.
4738 * nsterm.m (ns_draw_underwave): New function.
4739 (ns_draw_text_decoration): Use it.
4740 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
4741 New functions.
4742 (x_draw_glyph_string): Use them.
4743 * xfaces.c (Qline, Qwave): New Lisp objects.
4744 (check_lface_attrs, merge_face_ref)
1053a871
SM
4745 (Finternal_set_lisp_face_attribute, realize_x_face):
4746 Handle wave-style underline face attributes.
9b0e3eba
AA
4747 * xterm.c (x_draw_underwave): New function.
4748 (x_draw_glyph_string): Use it.
4749
0fb52f11
JB
47502012-06-16 Juanma Barranquero <lekktu@gmail.com>
4751
4752 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
4753 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
4754 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
4755 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
4756 ($(BLD)/w32select.$(O)): Update dependencies.
4757
e5560ff7
AS
47582012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4759
4760 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
4761 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
4762 * character.c (_fetch_multibyte_char_p): Remove.
4763 * alloc.c: Include "character.h" before "buffer.h".
4764 * bidi.c: Likewise.
4765 * buffer.c: Likewise.
4766 * bytecode.c: Likewise.
4767 * callint.c: Likewise.
4768 * callproc.c: Likewise.
4769 * casefiddle.c: Likewise.
4770 * casetab.c: Likewise.
4771 * category.c: Likewise.
4772 * cmds.c: Likewise.
4773 * coding.c: Likewise.
4774 * composite.c: Likewise.
4775 * dired.c: Likewise.
4776 * dispnew.c: Likewise.
4777 * doc.c: Likewise.
4778 * dosfns.c: Likewise.
4779 * editfns.c: Likewise.
4780 * emacs.c: Likewise.
4781 * fileio.c: Likewise.
4782 * filelock.c: Likewise.
4783 * font.c: Likewise.
4784 * fontset.c: Likewise.
4785 * fringe.c: Likewise.
4786 * indent.c: Likewise.
4787 * insdel.c: Likewise.
4788 * intervals.c: Likewise.
4789 * keyboard.c: Likewise.
4790 * keymap.c: Likewise.
4791 * lread.c: Likewise.
4792 * macros.c: Likewise.
4793 * marker.c: Likewise.
4794 * minibuf.c: Likewise.
4795 * nsfns.m: Likewise.
4796 * nsmenu.m: Likewise.
4797 * print.c: Likewise.
4798 * process.c: Likewise.
4799 * regex.c: Likewise.
4800 * region-cache.c: Likewise.
4801 * search.c: Likewise.
4802 * syntax.c: Likewise.
4803 * term.c: Likewise.
4804 * textprop.c: Likewise.
4805 * undo.c: Likewise.
4806 * unexsol.c: Likewise.
4807 * w16select.c: Likewise.
4808 * w32fns.c: Likewise.
4809 * w32menu.c: Likewise.
4810 * window.c: Likewise.
4811 * xdisp.c: Likewise.
4812 * xfns.c: Likewise.
4813 * xmenu.c: Likewise.
4814 * xml.c: Likewise.
4815 * xselect.c: Likewise.
4816
2f07e6af
EZ
48172012-06-16 Eli Zaretskii <eliz@gnu.org>
4818
1053a871
SM
4819 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
4820 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 4821 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
4822 row.
4823 (handle_face_prop): Use chunk-relative overlay string index when
4824 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
4825 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
4826 the rightmost. (Bug#11720)
2f07e6af 4827
29b83cec
AS
48282012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4829
4830 * category.h (CHAR_HAS_CATEGORY): Define as inline.
4831 (CATEGORY_MEMBER): Enforce 1/0 value.
4832 * category.c (_temp_category_set): Remove.
4833
4c5501e9
EZ
48342012-06-16 Eli Zaretskii <eliz@gnu.org>
4835
4836 * window.c (Fdelete_other_windows_internal)
4837 (Fdelete_window_internal): Don't access frame's mouse highlight
4838 info of the initial frame. (Bug#11677)
4839
2b570124
PE
48402012-06-14 Paul Eggert <eggert@cs.ucla.edu>
4841
e93864f9
PE
4842 * .gdbinit (xgetint): Fix recently-introduced paren typo.
4843 Assume USE_2_TAGS_FOR_INTS.
4844 (xreload): Adjust $tagmask width to match recent lisp.h change.
4845
2b570124
PE
4846 Simplify lisp.h in minor ways that should not affect code.
4847 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
4848 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
4849 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
4850 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
4851 (INTTYPEBITS): New macro, for clarity.
4852 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
4853 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
4854 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
4855 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
4856 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
4857
81755f69
JB
48582012-06-13 Juanma Barranquero <lekktu@gmail.com>
4859
4860 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
4861
16192a57
GM
48622012-06-13 Glenn Morris <rgm@gnu.org>
4863
4864 * s/bsd-common.h (BSD4_3):
4865 * s/usg5-4-common.h (USG5_4): No longer define; unused.
4866
646b5f55
AS
48672012-06-13 Andreas Schwab <schwab@linux-m68k.org>
4868
4869 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
4870 instead of union.
4871 (XLI, XIL): Define.
1053a871
SM
4872 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
4873 Use them.
4874 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 4875 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 4876 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
4877 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
4878 * frame.c (delete_frame): Remove outdated comment.
4879 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
4880 USE_LISP_UNION_TYPE.
4881 (Fw32_unregister_hot_key): Likewise.
4882 (Fw32_toggle_lock_key): Likewise.
4883 * w32menu.c (add_menu_item): Likewise.
4884 (w32_menu_display_help): Use XIL instead of checking
4885 USE_LISP_UNION_TYPE.
4886 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
4887 (init_heap): Likewise.
4888 * w32term.c (w32_read_socket): Update comment.
4889
1d3823c9
GM
48902012-06-13 Glenn Morris <rgm@gnu.org>
4891
c62ff706
GM
4892 * s/usg5-4-common.h, src/s/unixware.h:
4893 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
4894
1d3823c9
GM
4895 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
4896
bfe3e0a2
PE
48972012-06-13 Paul Eggert <eggert@cs.ucla.edu>
4898
4899 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
4900 * alloc.c (make_number) [!defined make_number]:
4901 Remove, as lisp.h always defines this now.
4902 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
4903 (roundup_size): Verify that it is a power of 2.
4904 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
4905 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
4906 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
4907 -DUSE_LSB_TAG=0, to override the automatically-selected default.
4908 USE_LSB_TAG now is always defined to be either 0 or 1.
4909 All uses changed.
4910 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
4911 code works fine either way, and efficiency is not a concern here,
4912 as the union type is for debugging, not for production.
4913 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
4914 Use an inline function on all platforms when using the union type,
4915 since this is simpler and 'static inline' can be used portably
4916 within Emacs now.
4917 (LISP_INITIALLY_ZERO): New macro.
4918 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
4919 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
4920
45fa9c0f
GM
49212012-06-12 Glenn Morris <rgm@gnu.org>
4922
b4492cba
GM
4923 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
4924
4925 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 4926
45fa9c0f
GM
4927 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
4928 Move BROKEN_SIGIO to configure.
4929
4930 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
4931 Move NO_TERMIO to configure.
4932
0e25d334
CY
49332012-06-12 Chong Yidong <cyd@gnu.org>
4934
4935 * image.c (imagemagick_load_image): Use MagickFlattenImage if
4936 MagickMergeImageLayers is undefined. Use pixel pusher loop if
4937 MagickExportImagePixels is undefined.
4938
43682bb6
PE
49392012-06-12 Paul Eggert <eggert@cs.ucla.edu>
4940
4941 * image.c (imagemagick_load_image): Remove unused label.
4942
a9be7d2b
GM
49432012-06-11 Glenn Morris <rgm@gnu.org>
4944
4945 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4946 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
4947 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
4948 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
4949
3017f87f
SM
49502012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
4951
4952 * alloc.c (make_byte_code): New function.
4953 (Fmake_byte_code): Use it. Don't purify here.
4954 * lread.c (read1): Use it as well to avoid extra allocation.
4955
1b9b4cf4
CY
49562012-06-11 Chong Yidong <cyd@gnu.org>
4957
4958 * image.c (imagemagick_load_image): Implement transparency.
4959
95988fcf
AS
49602012-06-10 Andreas Schwab <schwab@linux-m68k.org>
4961
4962 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
4963 account for preceding backslashes. (Bug#11663)
4964
cd4eb164
CY
49652012-06-09 Chong Yidong <cyd@gnu.org>
4966
4967 * term.c: Support italics in capable terminals (Bug#9652).
4968 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
4969 (turn_on_face): Output using TS_enter_italic_mode if available.
4970 Don't handle unused blinking and alt-charset cases.
4971 (turn_off_face): Handle italic case; discard unused tty_blinking_p
4972 and tty_alt_charset_p cases.
4973 (tty_capable_p, init_tty): Support italics.
4974
4975 * termchar.h (struct tty_display_info): Add field for italics.
4976 Remove unused blink field.
4977
4978 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
4979 Handle slant.
4980
4981 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
4982 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
4983 tty_alt_charset_p. Add tty_italic_p.
4984
ff88beb8
MA
49852012-06-09 Michael Albinus <michael.albinus@gmx.de>
4986
4987 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
4988 dbus_type_is_basic if available.
4989 (xd_extract_signed, xd_extract_unsigned): Rename from
4990 extract_signed and extract_unsigned, respectively. Adapt callers.
4991
44286096
CY
49922012-06-09 Chong Yidong <cyd@gnu.org>
4993
1682701f
CY
4994 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
4995
44286096
CY
4996 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
4997 case (Bug#9752).
4998
d86feb17
PE
49992012-06-08 Paul Eggert <eggert@cs.ucla.edu>
5000
5001 * xdisp.c (vmessage): Treat frame message as multibyte.
5002 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
5003 would generate the diagnostic "Making \302\247 buffer-local while
5004 let-bound!".
5005
d5c20fe8
EZ
50062012-06-08 Eli Zaretskii <eliz@gnu.org>
5007
5008 * dispnew.c (showing_window_margins_p): Undo last change, which
5009 was done due to an inadvertent commit.
5010 (adjust_frame_glyphs_for_frame_redisplay): Do call
5011 showing_window_margins_p.
5012
513749ee
SM
50132012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5014
5015 * eval.c (Fmake_var_non_special): New primitive.
5016 (syms_of_eval): Defsubr it.
5017 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
5018
d4a8f5c1
JB
50192012-06-08 Juanma Barranquero <lekktu@gmail.com>
5020
5021 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
5022 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
5023
8bbbc977
EZ
50242012-06-08 Eli Zaretskii <eliz@gnu.org>
5025
5026 * alloc.c (allocate_vectorlike): Fix last change.
5027
f3372c87
DA
50282012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
5029
5030 Block-based vector allocation of small vectors.
5031 * lisp.h (struct vectorlike_header): New field `nbytes',
5032 adjust comment accordingly.
5033 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
5034 to denote vector blocks. Adjust users (live_vector_p,
5035 mark_maybe_pointer, valid_lisp_object_p) accordingly.
5036 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
5037 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
5038 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
5039 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
5040 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
5041 (roundup_size): New constant.
5042 (struct vector_block): New data type.
5043 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 5044 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
5045 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
5046 (sweep_vectors): New functions.
5047 (allocate_vectorlike): Return `zero_vector' as the only vector of
5048 0 items. Allocate new vector from block if vector size is less than
5049 or equal to VBLOCK_BYTES_MAX.
5050 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
5051 (init_alloc_once): Add call to init_vectors.
5052
4f18a4ed
SM
50532012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5054
5055 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
5056
86f158bc
PE
50572012-06-07 Paul Eggert <eggert@cs.ucla.edu>
5058
5059 * doprnt.c (doprnt): Truncate multibyte char correctly.
5060 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
5061 would mishandle a string argument "Xc" if X was a multibyte
5062 character of length 2: it would truncate after X's first byte
5063 rather than including all of X.
5064
c5cfcbe0
CY
50652012-06-06 Chong Yidong <cyd@gnu.org>
5066
5067 * buffer.c (word_wrap): Doc fix.
5068
c05cf390
PE
50692012-06-04 Paul Eggert <eggert@cs.ucla.edu>
5070
5071 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
5072
0c3461de
GM
50732012-06-03 Glenn Morris <rgm@gnu.org>
5074
5075 * xdisp.c (tool-bar-style): Doc fix.
5076
c71232db
UM
50772012-06-03 Ulrich Müller <ulm@gentoo.org>
5078
5079 * Makefile.in (PAXCTL): Define.
5080 (temacs$(EXEEXT)): Disable memory randomization for the temacs
5081 binary via PaX flags if the paxctl utility is available.
5082 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
5083 Restore PaX flags to their default. (Bug#11398)
5084
383f7350
CY
50852012-06-03 Chong Yidong <cyd@gnu.org>
5086
5087 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
5088 buffer (Bug#11226).
5089
5f2c76c6
CY
50902012-06-03 Chong Yidong <cyd@gnu.org>
5091
5092 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
5093 (note_mode_line_or_margin_highlight): If there is no help echo,
5094 use mode-line-default-help-echo. Handle the case where the mouse
5095 position is past the end of the mode line string.
5096
5097 * buffer.c (buffer_local_value_1): New function, split from
5098 Fbuffer_local_value; can return Qunbound.
5099 (Fbuffer_local_value): Use it.
5100 (Vmode_line_format): Docstring tweaks.
5101
773d47f6
PE
51022012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5103
5104 * sysdep.c (system_process_attributes): Improve comment.
5105
f2d6a3df
SM
51062012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
5107
5108 * keyboard.c: Export real-this-command to Elisp.
5109 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
5110 and DEFVAR it. Update all users.
5111
63810350
PE
51122012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5113
7bd5c1f4
PE
5114 * minibuf.c (Fassoc_string): Remove duplicate declaration.
5115
63810350
PE
5116 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
5117 Convert pctcpu and pctmem to Lisp float properly.
5118 Let the compiler fold better, as 100.0/0x8000 is exact.
5119
a2821611
AS
51202012-06-02 Andreas Schwab <schwab@linux-m68k.org>
5121
5122 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
5123 cons_block.
5124
5fceba1d
PE
51252012-06-01 Paul Eggert <eggert@cs.ucla.edu>
5126
5127 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
5128
c98ff5dd
DA
51292012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
5130
5131 For a 'struct window', replace some Lisp_Object fields to
5132 bitfields where appropriate, remove unused fields.
5133 * window.h (struct window): Remove unused 'last_mark_x' and
5134 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
5135 change it's type from Lisp_Object to bitfield.
5136 Change type of 'force_start', 'optional_new_start',
5137 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
5138 fields from Lisp_Object to bitfield. Adjust users accordingly.
5139
ca34e0be
PE
51402012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5141
5142 Pacify gcc -Wdouble-precision when using Xaw.
5143 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
5144 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
5145 Use 'float' consistently, rather than 'float' in most places
5146 and 'double' in a couple of places.
5147
efc00ab1 51482012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
5149
5150 * xdisp.c (handle_stop): Detect whether we have overlay strings
5151 loaded by testing it->current.overlay_string_index to be
5152 non-negative, instead of checking whether n_overlay_strings is
5153 positive. (Bug#11587)
5154
efc00ab1 51552012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
5156
5157 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
5158
5159 * doc.c (Fsubstitute_command_keys): Doc fix.
5160
efc00ab1 51612012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
5162
5163 * search.c (search_buffer): Remove calls to
5164 r_alloc_inhibit_buffer_relocation, as it is now called by
5165 maybe_unify_char, which was the cause of relocation of buffer text
5166 in bug#11519.
5167
efc00ab1 51682012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
5169
5170 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
5171 for the duration of call to load_charset, to avoid problems with
5172 callers of maybe_unify_char that access buffer text through C
5173 pointers.
5174
5175 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
5176 decrement the inhibition flag, instead of just setting or
5177 resetting it.
5178
ba93a187
PE
51792012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5180
5181 Remove obsolete '#define static' cruft.
5182 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
5183 This #undef was "temporary" in 2000; it is no longer needed
5184 now that '#define static' has gone away.
5185 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
5186 (gray_bitmap_bits): Remove; no longer needed.
5187 All uses replaced with definiens.
5188 * xterm.c: Include "bitmaps/gray.xbm".
5189
9e4bf381
PE
51902012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5191
5192 Clean up __executable_start, monstartup when --enable-profiling.
5193 The following changes affect the code only when profiling.
5194 * dispnew.c (__executable_start): Rename from safe_bcopy.
5195 Define only on platforms that need it.
5196 * emacs.c: Include <sys/gmon.h> when profiling.
5197 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
5198 (__executable_start): Remove decl, since lisp.h does it now.
5199 (safe_bcopy): Remove decl; no longer has that name.
5200 (main): Coalesce #if into single bit of code, for simplicity.
5201 Cast pointers to uintptr_t, since standard libraries want integers
5202 and not pointers.
5203 * lisp.h (__executable_start): New decl.
5204
32d72c2f
GM
52052012-05-31 Glenn Morris <rgm@gnu.org>
5206
5207 * image.c (Fimagemagick_types): Doc fix.
5208
baac5bc7
JM
52092012-05-30 Jim Meyering <meyering@redhat.com>
5210
5211 * callproc.c (Fcall_process_region): Include directory component
5212 in mkstemp error message (Bug#11586).
5213
72cb32cf
PE
52142012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5215
5216 * alloc.c, lisp.h (make_pure_vector): Now static.
5217
61b108cc
SM
52182012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
5219
5220 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
5221 Move to byte-run.el.
5222 (Fautoload): Do the hash-doc more carefully.
5223 * data.c (Fdefalias): Purify definition, except for keymaps.
5224 (Qdefun): Move from eval.c.
5225 * lisp.h (Qdefun): Remove.
5226 * lread.c (read1): Tiny simplification.
5227
471fe23d
TN
52282012-05-29 Troels Nielsen <bn.troels@gmail.com>
5229
934f3f58 5230 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
5231 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
5232 Bug#9642, but explicitly check that the buffer the overlay would
5233 be moved to is live and rearrange lines to make sure that errors
5234 will not put the overlay in an inconsistent state.
5235 (Fdelete_overlay): Cosmetics.
5236
85d0efd1
EZ
52372012-05-28 Eli Zaretskii <eliz@gnu.org>
5238
5239 * w32term.c (my_bring_window_to_top): New function.
5240 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
5241 could be different from the original one.
5242 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
5243 (Bug#11513)
5244
5245 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
5246 by calling BringWindowToTop.
5247
5248 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
5249 (WM_EMACS_END): Increase by one.
5250
da92a98c
PE
52512012-05-28 Paul Eggert <eggert@cs.ucla.edu>
5252
5253 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
5254 This avoids undefined behavior that might cause the eassert
5255 to not catch an out-of-range value.
5256
74d1f848
JB
52572012-05-28 Juanma Barranquero <lekktu@gmail.com>
5258
5259 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
5260 Update dependencies.
5261
9e1a06fc
EZ
52622012-05-27 Eli Zaretskii <eliz@gnu.org>
5263
5264 * bidi.c (bidi_mirror_char): Fix last change.
5265
f3dd7312
AS
52662012-05-27 Andreas Schwab <schwab@linux-m68k.org>
5267
5268 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
5269 when referring to sectname field in printf format.
5270
81899c91
PE
52712012-05-27 Paul Eggert <eggert@cs.ucla.edu>
5272
57b81a9f
PE
5273 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
5274 Only r_alloc_inhibit_buffer_relocation needed to be added;
5275 the others were already declared.
5276
81899c91
PE
5277 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
5278 before checking whether it's out of range. Put the check inside
5279 eassert. See
5280 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
5281
33017faf 52822012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
5283
5284 * callproc.c (Fcall_process): Restore a line that was accidentally
5285 commented out in the 2011-02-13 change (bug#11547).
5286
33017faf 52872012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
5288
5289 * lisp.h [REL_ALLOC]: Add prototypes for external functions
5290 defined on ralloc.c.
5291
5292 * buffer.c [REL_ALLOC]: Remove prototypes of
5293 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
5294 they are now on lisp.h.
5295
5296 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
5297
5298 * search.c (search_buffer): Use it to inhibit relocation of buffer
5299 text while re_search_2 is doing its job, because re_search_2 is
5300 passed C pointers to buffer text. (Bug#11519)
5301
23415acf
EZ
5302 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
5303 Update value to 24.
5304
44e27368
EZ
5305 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
5306 state after an additional call to move_it_in_display_line_to, keep
5307 the values of it->max_ascent and it->max_descent found for the
5308 entire line.
5309 (pos_visible_p): Revert the comparison against bottom_y to what it
5310 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
5311 (Bug#11464)
5312
c1892f11
PE
53132012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5314
5315 Fix coding-related core dumps with gcc -ftrapv.
5316 The code was computing A - B, where A and B are pointers, and B is
5317 random garbage. This can lead to core dumps on platforms that
5318 have special pointer registers, and it also leads to core dumps on
5319 x86-64 when compiled with gcc -ftrapv. The fix is to compute
5320 A - B only when B is initialized properly.
5321 * coding.c (coding_set_source, coding_set_destination): Return void.
5322 (coding_change_source, coding_change_destinations): New functions,
5323 with the old behaviors of coding_set_source and coding_set_destination.
5324 All callers that need an offset changed to use these new functions.
5325
eb7afdad
GM
53262012-05-26 Glenn Morris <rgm@gnu.org>
5327
5328 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
5329
f12fdf02
EZ
53302012-05-26 Eli Zaretskii <eliz@gnu.org>
5331
53a63be6 5332 Extend mouse support on W32 text-mode console.
61b108cc
SM
5333 * xdisp.c (draw_row_with_mouse_face):
5334 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 5335
eb3f6f01 5336 * w32console.c: Include window.h.
61b108cc
SM
5337 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
5338 New functions.
eb3f6f01
EZ
5339 (initialize_w32_display): Initialize mouse-highlight data.
5340
53a63be6
EZ
5341 * w32inevt.c: Include termchar.h and window.h.
5342 (do_mouse_event): Support mouse-autoselect-window. When the mouse
5343 moves, call note_mouse_highlight. If help_echo changed, call
5344 gen_help_event to produce help-echo message in the echo area.
5345 Call clear_mouse_face if mouse_face_hidden is set in the mouse
5346 highlight info.
5347
4cfd81f6
PE
53482012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5349
5350 * lread.c (read1): Simplify slightly to avoid an overflow warning
5351 with GCC 4.7.0 on x86-64.
5352
4446092a
EZ
53532012-05-26 Eli Zaretskii <eliz@gnu.org>
5354
5355 * bidi.c (bidi_mirror_char): Revert last change: an int is
5356 definitely wide enough here.
5357
42b2a986 53582012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 5359
42b2a986 5360 Fix integer width and related bugs (Bug#9874).
eb106a49 5361 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5362 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5363 (string_bytes, check_sblock, allocate_string_data):
5364 (compact_small_strings, Fmake_bool_vector, make_string)
5365 (make_unibyte_string, make_multibyte_string)
5366 (make_string_from_bytes, make_specified_string)
5367 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
5368 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
5369 (mark_vectorlike):
5370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5371 (allocate_pseudovector):
5372 Use int, not EMACS_INT, where int is wide enough.
5373 (inhibit_garbage_collection, Fgarbage_collect):
5374 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5375 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
5376 int might not be wide enough.
5377 (bidi_cache_search, bidi_cache_find, bidi_init_it)
5378 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
5379 (bidi_at_paragraph_end, bidi_find_paragraph_start)
5380 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5381 (bidi_level_of_next_char, bidi_move_to_visually_next):
5382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5383 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
5384 (Fkill_buffer, Fset_buffer_major_mode)
5385 (advance_to_char_boundary, Fbuffer_swap_text)
5386 (Fset_buffer_multibyte, overlays_at, overlays_in)
5387 (overlay_touches_p, struct sortvec, record_overlay_string)
5388 (overlay_strings, recenter_overlay_lists)
5389 (adjust_overlays_for_insert, adjust_overlays_for_delete)
5390 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
5391 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
5392 (Foverlay_recenter, last_overlay_modification_hooks_used)
5393 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
5394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
5395 (validate_region): Omit unnecessary test for b <= e,
5396 since that's guaranteed by the previous test.
d311d28c
PE
5397 (adjust_overlays_for_delete): Avoid pos + length overflow.
5398 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
5399 (report_overlay_modification):
5400 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5401 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
5402 Omit pointer cast, which isn't needed anyway, and doesn't work
5403 after the EMACS_INT -> ptrdiff_t change.
02481186 5404 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
5405 * buffer.h: Adjust decls to match defn changes elsewhere.
5406 (struct buffer_text, struct buffer):
5407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5408 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
5409 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
5410 not int, to avoid needless 32-bit limit on 64-bit hosts.
5411 (exec_byte_code): Use tighter memory-full test, one that checks
5412 for alloca overflow. Don't compute the address of the object just
5413 before an array, as that's not portable. Use EMACS_INT, not
5414 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
5415 * callint.c (Fcall_interactively):
5416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5417 * callproc.c (call_process_kill, Fcall_process):
5418 Don't assume pid_t fits into an Emacs fixnum.
5419 (call_process_cleanup, Fcall_process, child_setup):
5420 Don't assume pid_t fits into int.
5421 (call_process_cleanup, Fcall_process, delete_temp_file)
5422 (Fcall_process_region):
5423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5424 (Fcall_process): Simplify handling of volatile integers.
5425 Use int, not EMACS_INT, where int will do.
5426 * casefiddle.c (casify_object, casify_region, operate_on_word)
5427 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
5428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5429 (casify_object): Avoid integer overflow when overallocating buffer.
5430 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 5431 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
5432 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
5433 * category.h (CATEGORYP): Don't assume arg is nonnegative.
5434 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
5435 integers are now checked earlier. All uses replaced with XINT.
5436 (ccl_driver):
5437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5438 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
5439 (ccl_driver, Fregister_code_conversion_map):
5440 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
5441 (resolve_symbol_ccl_program): Check that vector header is in range.
5442 Always copy the vector, so that we can check its contents reliably
5443 now rather than having to recheck each instruction as it's being
5444 executed. Check that vector words fit in 'int'.
5445 (ccl_get_compiled_code, Fregister_ccl_program)
5446 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
5447 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
5448 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
5449 contents are in range.
5450 (Fccl_execute_on_string): Check that status is in range.
5451 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
5452 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
5453 Accept and return EMACS_INT, not int, because callers can pass values
5454 out of 'int' range.
5455 (c_string_width, strwidth, lisp_string_width, chars_in_text)
5456 (multibyte_chars_in_text, parse_str_as_multibyte)
5457 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
5458 (str_as_unibyte, str_to_unibyte, string_count_byte8)
5459 (string_escape_byte8, Fget_byte):
5460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 5461 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
5462 avoid mishandling large integers.
5463 * character.h: Adjust decls to match defn changes elsewhere.
5464 * charset.c (load_charset_map_from_file, find_charsets_in_text)
5465 (Ffind_charset_region):
5466 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5467 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
5468 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 5469 Don't assume fixnum fits in int.
d311d28c
PE
5470 (load_charset_map_from_vector, Fmap_charset_chars):
5471 Remove now-unnecessary CHECK_NATNUMs.
5472 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
5473 Don't rely on undefined behavior with signed left shift overflow.
5474 Don't assume unsigned int fits into fixnum, or that fixnum fits
5475 into unsigned int. Don't require max_code to be a valid fixnum;
5476 that's not true for gb10830 4-byte on a 32-bit host. Allow
5477 invalid_code to be a cons, for the same reason. Require code_offset
5478 to be a character. Avoid int overflow if max_char is close
5479 to INT_MAX.
5480 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
5481 this is intended anyway and avoids some undefined behavior.
5482 (load_charset_map): Pass unsigned, not int, as 2nd arg of
5483 INDEX_TO_CODE_POINT, as that's what it expects.
5484 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
5485 * charset.h (DECODE_CHAR): Return int, not unsigned;
5486 this is what was intended anyway, and it avoids undefined behavior.
5487 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
5488 integer-overflow issues.
5489 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
5490 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
5491 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
5492 * chartab.c (Fmake_char_table, Fset_char_table_range)
5493 (uniprop_get_decoder, uniprop_get_encoder):
5494 Don't assume fixnum fits in int.
5495 * cmds.c (move_point): New function, that does the gist of
5496 Fforward_char and Fbackward_char, but does so while checking
5497 for integer overflow more accurately.
c96e5d6a 5498 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
5499 (Fforward_line, Fend_of_line, internal_self_insert)
5500 (internal_self_insert):
5501 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5502 Fix a FIXME, by checking for integer overflow when calculating
5503 target_clm and actual_clm.
5504 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 5505 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
5506 (ASSURE_DESTINATION, coding_alloc_by_realloc)
5507 (coding_alloc_by_making_gap, alloc_destination)
5508 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
5509 (encode_coding_utf_16, detect_coding_emacs_mule)
5510 (decode_coding_emacs_mule, encode_coding_emacs_mule)
5511 (detect_coding_iso_2022, decode_coding_iso_2022)
5512 (encode_invocation_designation, encode_designation_at_bol)
5513 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5514 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
5515 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
5516 (encode_coding_ccl, encode_coding_raw_text)
5517 (detect_coding_charset, decode_coding_charset)
5518 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
5519 (produce_composition, produce_charset, produce_annotation)
5520 (decode_coding, handle_composition_annotation)
5521 (handle_charset_annotation, consume_chars, decode_coding_gap)
5522 (decode_coding_object, encode_coding_object, detect_coding_system)
5523 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
5524 (code_convert_region, code_convert_string)
8f50130c
PE
5525 (Fdefine_coding_system_internal)
5526 (coding_set_source, coding_set_destination):
d311d28c
PE
5527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5528 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
5529 (Fdefine_coding_system_internal):
5530 Don't assume fixnums fit in int.
5531 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 5532 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
5533 (Funencodable_char_position, Fcheck_coding_systems_region)
5534 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 5535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 5536 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 5537 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 5538 Don't access memory outside of the args array.
d311d28c 5539 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
5540 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
5541 result of ENCODE_CHAR.
d311d28c
PE
5542 * coding.h: Adjust decls to match defn changes elsewhere.
5543 (struct coding_system):
5544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5545 * composite.c (get_composition_id, find_composition)
5546 (run_composition_function, update_compositions)
5547 (compose_text, composition_gstring_put_cache)
5548 (composition_gstring_p, composition_gstring_width)
5549 (fill_gstring_header, fill_gstring_body, autocmp_chars)
5550 (composition_compute_stop_pos, composition_reseat_it)
5551 (composition_update_it, struct position_record)
5552 (find_automatic_composition, composition_adjust_point)
5553 (Fcomposition_get_gstring, Ffind_composition_internal):
5554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5555 (update_compositions):
5556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5557 * composite.h: Adjust decls to match defn changes elsewhere.
5558 (struct composition):
5559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5560 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
5561 Do not attempt to compute the address of the object just before a
5562 buffer; this is not portable.
5563 (Faref, Faset):
5564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5565 (Faset): Use int, not EMACS_INT, where int is wide enough.
5566 (Fstring_to_number): Don't assume fixnums fit in int.
5567 (Frem): Don't assume arg is nonnegative.
5568 * dbusbind.c (xd_append_arg): Check for integers out of range.
5569 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 5570 (extract_signed, extract_unsigned): New functions.
243e0530
PE
5571 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
5572 (xd_get_connection_references): Return ptrdiff_t, not int.
5573 All uses changed.
5574 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
5575 (xd_read_message_1):
5576 Use int, not unsigned, where the dbus API uses int.
5577 (Fdbus_message_internal): Don't overflow mtype.
5578 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
5579 * dired.c (directory_files_internal, file_name_completion, scmp)
5580 (file_name_completion_stat):
5581 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5582 (file_name_completion): Don't overflow matchcount.
5583 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
5584 * dispextern.h: Adjust decls to match defn changes elsewhere.
5585 (struct text_pos, struct glyph, struct bidi_saved_info)
5586 (struct bidi_string_data, struct bidi_it, struct composition_it)
5587 (struct it):
5588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5589 (struct display_pos, struct composition_it, struct it):
5590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5591 * dispnew.c (increment_matrix_positions)
5592 (increment_row_positions, mode_line_string)
5593 (marginal_area_string):
5594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 5595 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
5596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5597 (duration_to_sec_usec): New function, to check for overflow better.
5598 (Fsleep_for, sit_for): Use it.
5599 * doc.c (get_doc_string, store_function_docstring):
5600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5601 (get_doc_string, Fsnarf_documentation):
5602 Use int, not EMACS_INT, where int is wide enough.
5603 (get_doc_string):
5604 Use SAFE_ALLOCA, not alloca.
5605 Check for overflow when converting EMACS_INT to off_t.
5606 * doprnt.c (doprnt):
5607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5608 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
5609 Don't assume uid_t fits into fixnum.
5610 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
5611 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
5612 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
5613 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
5614 (general_insert_function)
5615 (Finsert_char, make_buffer_string, make_buffer_string_both)
5616 (update_buffer_properties, Fbuffer_substring)
5617 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
5618 (Fsubst_char_in_region, check_translation)
5619 (Ftranslate_region_internal, save_restriction_restore, Fformat)
5620 (transpose_markers, Ftranspose_regions):
5621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5622 (clip_to_bounds): Move to lisp.h as an inline function).
5623 (Fconstrain_to_field): Don't assume integers are nonnegative.
5624 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
5625 (Fsubst_char_in_region, Fsave_restriction):
5626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5627 (Femacs_pid): Don't assume pid_t fits into fixnum.
5628 (lo_time): Use int, not EMACS_INT, when int suffices.
5629 (lisp_time_argument): Check for usec out of range.
5630 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
5631 (Fuser_login_name, Fuser_full_name): Signal an error
5632 if a uid argument is out of range, rather than relying on
5633 undefined behavior.
c8d5c857
PE
5634 (Fformat_time_string): Remove now-unnecessary check.
5635 lisp_time_argument checks for out-of-range usec now.
243e0530 5636 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
5637 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
5638 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
5639 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
5640 (init_cmdargs, Fdump_emacs):
5641 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5642 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
5643 the bottom (typically) 32 bits of the fixnum.
5644 * eval.c (specpdl_size, call_debugger):
5645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5646 (when_entered_debugger, Fbacktrace_debug):
5647 Don't assume fixnum can fit in int.
5648 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
5649 the object just before a buffer; this is not portable.
5650 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
5651 (grow_specpdl, unbind_to):
5652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5653 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
5654 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 5655 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
5656 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
5657 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
5658 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5659 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
5660 (a_write, e_write):
5661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5662 (Fcopy_file, non_regular_nbytes, read_non_regular)
5663 (Finsert_file_contents):
5664 Use int, not EMACS_INT, where int is wide enough.
5665 (READ_BUF_SIZE): Verify that it fits in int.
5666 (Finsert_file_contents): Check that counts are in proper range,
5667 rather than assuming fixnums fit into ptrdiff_t etc.
5668 Don't assume fixnums fit into int.
125b3835 5669 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
5670 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
5671 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
5672 (string_char_to_byte, string_byte_to_char)
5673 (string_make_multibyte, string_to_multibyte)
5674 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
5675 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
5676 (substring_both, Fdelete, internal_equal, Ffillarray)
5677 (Fclear_string, mapcar1)
5678 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
5679 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
5680 (larger_vector, make_hash_table, maybe_resize_hash_table)
5681 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
5682 (Fmaphash, secure_hash):
5683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5684 (concat): Check for string index and length overflow.
5685 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
5686 (Frequire):
5687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5688 (larger_vector): New API (vec, incr_min, size_max) replaces old
5689 one (vec, new_size, init). This catches size overflow.
5690 INIT was removed because it was always Qnil.
5691 All callers changed.
5692 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
5693 the upper bound on a hash table index size.
5694 (make_hash_table, maybe_resize_hash_table): Use it.
5695 (secure_hash): Computer start_byte and end_byte only after
5696 they're known to be in ptrdiff_t range.
5697 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
5698 (Ffont_get_glyphs, Ffont_at):
5699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5700 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
5701 (Flist_fonts, Fopen_font):
5702 Don't assume fixnum can fit in int.
5703 (check_gstring): Don't assume index can fit in int.
5704 (font_match_p): Check that fixnum is a character, not a nonnegative
5705 fixnum, since the later code needs to stuff it into an int.
5706 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
5707 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
5708 conversion overflow issues.
5709 (Fopen_font): Check for integer out of range.
5710 (Ffont_get_glyphs): Don't assume index can fit in int.
5711 * font.h: Adjust decls to match defn changes elsewhere.
5712 * fontset.c (reorder_font_vector): Redo score calculation to avoid
5713 integer overflow.
5714 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
5715 printmax_t, where ptrdiff_t is wide enough.
5716 (Finternal_char_font):
5717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5718 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
5719 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
5720 (Fset_frame_position, x_set_frame_parameters)
5721 (x_set_line_spacing, x_set_border_width)
5722 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
5723 Check that fixnums are in proper range for system types.
5724 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
5725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5726 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
5727 Use SAFE_ALLOCA_LISP, not alloca.
5728 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
5729 intptr_t is wide enough.
5730 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
5731 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
5732 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
5733 Check for fixnum out of range.
5734 * ftfont.c (ftfont_list): Don't assume index fits in int.
5735 Check that fixnums are in proper range for system types.
5736 (ftfont_shape_by_flt):
5737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
5738 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5740 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
5741 Check that fixnums are in proper range for system types.
5742 * gnutls.h: Adjust decls to match defn changes elsewhere.
5743 * gtkutil.c (xg_dialog_run):
5744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5745 (update_frame_tool_bar):
5746 Check that fixnums are in proper range for system types.
5747 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 5748 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
5749 * indent.c (last_known_column, last_known_column_point):
5750 (current_column_bol_cache):
5751 (skip_invisible, current_column, check_display_width):
5752 (check_display_width, scan_for_column, current_column_1)
5753 (Findent_to, Fcurrent_indentation, position_indentation)
5754 (indented_beyond_p, Fmove_to_column, compute_motion):
5755 (Fcompute_motion, Fvertical_motion):
5756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5757 (last_known_column_modified): Use EMACS_INT, not int.
5758 (check_display_width):
5759 (Fcompute_motion):
5760 Check that fixnums and floats are in proper range for system types.
5761 (compute_motion): Don't assume index or fixnum fits in int.
5762 (compute_motion, Fcompute_motion):
5763 Use int, not EMACS_INT, when it is wide enough.
5764 (vmotion): Omit local var start_hpos that is always 0; that way
5765 we don't need to worry about overflow in expressions involving it.
5766 * indent.h: Adjust decls to match defn changes elsewhere.
5767 (struct position):
5768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5769 Use int, not EMACS_INT, where int is wide enough.
5770 Remove unused members ovstring_chars_done and tab_offset;
5771 all uses removed.
5772 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
5773 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
5774 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
5775 (make_gap, copy_text, insert, insert_and_inherit)
5776 (insert_before_markers, insert_before_markers_and_inherit)
5777 (insert_1, count_combining_before, count_combining_after)
5778 (insert_1_both, insert_from_string)
5779 (insert_from_string_before_markers, insert_from_string_1)
5780 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
5781 (adjust_after_replace, adjust_after_insert, replace_range)
5782 (replace_range_2, del_range, del_range_1, del_range_byte)
5783 (del_range_both, del_range_2, modify_region)
5784 (prepare_to_modify_buffer, signal_before_change)
5785 (signal_after_change, Fcombine_after_change_execute):
5786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5787 * intervals.c (traverse_intervals, rotate_right, rotate_left)
5788 (balance_an_interval, split_interval_right, split_interval_left)
5789 (find_interval, next_interval, update_interval)
5790 (adjust_intervals_for_insertion, delete_node, delete_interval)
5791 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5792 (static_offset_intervals, offset_intervals)
5793 (merge_interval_right, merge_interval_left, make_new_interval)
5794 (graft_intervals_into_buffer, temp_set_point_both)
5795 (temp_set_point, set_point, adjust_for_invis_intang)
5796 (set_point_both, move_if_not_intangible, get_property_and_range)
5797 (get_local_map, copy_intervals, copy_intervals_to_string)
5798 (compare_string_intervals, set_intervals_multibyte_1):
5799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5800 * intervals.h: Adjust decls to match defn changes elsewhere.
5801 (struct interval):
5802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5803 * keyboard.c (this_command_key_count, this_single_command_key_start)
5804 (before_command_key_count, before_command_echo_length, echo_now)
5805 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
5806 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
5807 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
5808 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
5809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5810 (last_non_minibuf_size, last_point_position, echo_truncate)
5811 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
5812 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
5813 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
5814 (stuff_buffered_input):
5815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5816 (last_auto_save, command_loop_1, read_char):
5817 Use EMACS_INT, not int, to avoid integer overflow.
5818 (record_char): Avoid overflow in total_keys computation.
5819 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
5820 * keyboard.h: Adjust decls to match defn changes elsewhere.
5821 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
5822 (Fkey_description, Fdescribe_vector, Flookup_key):
5823 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5824 (click_position): New function, to check that positions are in range.
5825 (Fcurrent_active_maps):
5826 (describe_command):
5827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5828 (Faccessible_keymaps, Fkey_description):
5829 (preferred_sequence_p):
5830 Don't assume fixnum can fit into int.
5831 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
5832 Check for integer overflow in size calculations.
5833 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
5834 avoid mishandling large integers.
5835 * lisp.h: Adjust decls to match defn changes elsewhere.
5836 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
5837 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
5838 (struct Lisp_Marker):
5839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5840 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
5841 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
5842 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
5843 All callers changed.
5844 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
5845 Assume the arg has valid form, since it always does.
5846 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
5847 unsigned integer system type.
5848 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
5849 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
5850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5851 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
5852 (duration_to_sec_usec): New decl.
5853 * lread.c (read_from_string_index, read_from_string_index_byte)
5854 (read_from_string_limit, readchar, unreadchar, openp)
5855 (read_internal_start, read1, oblookup):
5856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5857 (Fload, readevalloop, Feval_buffer, Feval_region):
5858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5859 (openp): Check for out-of-range argument to 'access'.
5860 (read1): Use int, not EMACS_INT, where int is wide enough.
5861 Don't assume fixnum fits into int.
6efdadfd 5862 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
5863 (read_filtered_event): Use duration_to_sec_usec
5864 to do proper overflow checking on durations.
d311d28c
PE
5865 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
5866 in size calculation.
5867 (Fexecute_kbd_macro):
5868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5869 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
5870 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
5871 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
5872 (set_marker_both, set_marker_restricted_both, marker_position)
5873 (marker_byte_position, Fbuffer_has_markers_at):
5874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5875 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 5876 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
5877 It now merely ensures that the menu is large enough, without
5878 necessarily growing it, as this avoids some integer overflow issues.
5879 All callers changed.
5880 (keymap_panes, parse_single_submenu, Fx_popup_menu):
5881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5882 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
5883 Use SAFE_ALLOCA_LISP, not alloca.
5884 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
5885 to EMACS_INT. Check that fixnums are in proper range for system types.
5886 * minibuf.c (minibuf_prompt_width, string_to_object)
5887 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
5888 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
5889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5890 (get_minibuffer, read_minibuf_unwind):
5891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5892 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
5893 this simplifies overflow checking. All callers changed.
5894 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
5895 (Ftest_completion):
5896 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5897 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
5898 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
5899 Check that fixnums are in proper range for system types.
5900 (Fx_create_frame, Fx_show_tip):
5901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5902 * nsfont.m (ns_findfonts, nsfont_list_family):
5903 Don't assume fixnum fits in long.
5904 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
5905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5906 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
5907 wide enough.
17fdb222 5908 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
5909 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5910 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
5911 (PRINTDECLARE, PRINTPREPARE):
5912 (strout, print_string):
5913 (print, print_preprocess, print_check_string_charset_prop)
5914 (print_object):
5915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5916 (PRINTDECLARE):
5917 (temp_output_buffer_setup, Fprin1_to_string, print_object):
5918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5919 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 5920 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 5921 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
5922 (print_error_message): Use SAFE_ALLOCA, not alloca.
5923 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
5924 (print_depth, new_backquote_output, print_number_index):
5925 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
5926 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
5927 (Fset_process_window_size, Fformat_network_address)
5928 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 5929 (sigchld_handler):
d311d28c 5930 Check that fixnums are in proper range for system types.
d44287d4 5931 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
5932 Check for process-ids out of pid_t range rather than relying on
5933 undefined behavior.
e4d81efc 5934 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
5935 (Fformat_network_address, read_process_output, send_process)
5936 (Fprocess_send_region, status_notify):
5937 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5938 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
5939 (wait_reading_process_output, read_process_output, exec_sentinel):
5940 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5941 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
5942 (Faccept_process_output): Use duration_to_sec_usec to do proper
5943 overflow checking on durations.
dde14581
PE
5944 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
5945 Don't assume pid_t fits in int.
02481186
PE
5946 * process.h (struct Lisp_Process): Members tick and update_tick
5947 are now of type EMACS_INT, not int.
b62b53e8
PE
5948 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
5949 configured --with-wide-int.
d311d28c
PE
5950 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
5951 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
5952 * search.c (looking_at_1, string_match_1):
5953 (fast_string_match, fast_c_string_match_ignore_case)
5954 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
5955 (scan_newline, find_before_next_newline, search_command)
5956 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
5957 (set_search_regs, wordify):
5958 (Freplace_match):
5959 (Fmatch_data):
5960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5961 (string_match_1, search_buffer, set_search_regs):
5962 (Fmatch_data):
5963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5964 (wordify): Check for overflow in size calculation.
5965 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
5966 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
5967 Check that fixnums are in proper range for system types.
5968 * sound.c (struct sound_device)
5969 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
5970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5971 (Fplay_sound_internal):
5972 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 5973 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
5974 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
5975 (Fparse_partial_sexp):
5976 Don't assume fixnums can fit in int.
5977 (struct lisp_parse_state, find_start_pos, find_start_value)
5978 (find_start_value_byte, find_start_begv)
5979 (update_syntax_table, char_quoted, dec_bytepos)
5980 (find_defun_start, prev_char_comend_first, back_comment):
5981 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
5982 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
5983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5984 (Finternal_describe_syntax_value): Check that match_lisp is a
5985 character, not an integer, since the code stuffs it into int.
5986 (scan_words, scan_sexps_forward):
5987 Check that fixnums are in proper range for system types.
5988 (Fforward_word):
5989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5990 (scan_sexps_forward):
5991 Use CHARACTERP, not INTEGERP, since the value must fit into int.
5992 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
5993 * syntax.h: Adjust decls to match defn changes elsewhere.
5994 (struct gl_state_s):
5995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
5996 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
5997 MOST_POSITIVE_FIXNUM.
d311d28c
PE
5998 * sysdep.c (wait_for_termination_1, wait_for_termination)
5999 (interruptible_wait_for_termination, mkdir):
6000 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
6001 (emacs_read, emacs_write):
6002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
6003 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
6004 and double all fit in int.
d311d28c
PE
6005 * term.c (set_tty_color_mode):
6006 Check that fixnums are in proper range for system types.
6007 * termhooks.h (struct input_event):
6008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6009 * textprop.c (validate_interval_range, interval_of)
6010 (Fadd_text_properties, set_text_properties_1)
6011 (Fremove_text_properties, Fremove_list_of_text_properties)
6012 (Ftext_property_any, Ftext_property_not_all)
6013 (copy_text_properties, text_property_list, extend_property_ranges)
6014 (verify_interval_modification):
6015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6016 (Fnext_single_char_property_change)
6017 (Fprevious_single_char_property_change):
6018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
6019 (copy_text_properties):
6020 Check for integer overflow in index calculation.
d311d28c
PE
6021 * undo.c (last_boundary_position, record_point, record_insert)
6022 (record_delete, record_marker_adjustment, record_change)
6023 (record_property_change):
6024 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6025 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
6026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6027 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6028 (Fx_hide_tip, Fx_file_dialog):
6029 * w32menu.c (set_frame_menubar):
6030 Use ptrdiff_t, not int, for consistency with rest of code.
6031 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
6032 (select_window, Fdelete_other_windows_internal)
6033 (window_scroll_pixel_based, window_scroll_line_based)
6034 (Frecenter, Fset_window_configuration):
6035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6036 (Fset_window_hscroll, run_window_configuration_change_hook)
6037 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 6038 (Fscroll_other_window, Frecenter):
d311d28c
PE
6039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6040 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
6041 Don't assume fixnum fits in int.
6042 (Fset_window_scroll_bars):
6043 Check that fixnums are in proper range for system types.
6044 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
6045 (string_pos, c_string_pos, number_of_chars, init_iterator)
6046 (in_ellipses_for_invisible_text_p, init_from_display_pos)
6047 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
6048 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
6049 (face_before_or_after_it_pos, handle_invisible_prop)
6050 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
6051 (display_prop_intangible_p, string_buffer_position_lim)
6052 (string_buffer_position, handle_composition_prop, load_overlay_strings)
6053 (get_overlay_strings_1, get_overlay_strings)
6054 (iterate_out_of_display_property, forward_to_next_line_start)
6055 (back_to_previous_visible_line_start, reseat, reseat_to_string)
6056 (get_next_display_element, set_iterator_to_next)
6057 (get_visually_first_element, compute_stop_pos_backwards)
6058 (handle_stop_backwards, next_element_from_buffer)
6059 (move_it_in_display_line_to, move_it_in_display_line)
6060 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6061 (add_to_log, message_dolog, message_log_check_duplicate)
6062 (message2, message2_nolog, message3, message3_nolog
6063 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
6064 (current_message_1, truncate_echo_area, truncate_message_1)
6065 (set_message, set_message_1, store_mode_line_noprop)
6066 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
6067 (text_outside_line_unchanged_p, check_point_in_composition)
6068 (reconsider_clip_changes)
6069 (redisplay_internal, set_cursor_from_row, try_scrolling)
6070 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
6071 (redisplay_window, find_last_unchanged_at_beg_row)
6072 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
6073 (trailing_whitespace_p, find_row_edges, display_line)
6074 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
6075 (display_mode_element, store_mode_line_string)
6076 (pint2str, pint2hrstr, decode_mode_spec)
6077 (display_count_lines, display_string, draw_glyphs)
6078 (x_produce_glyphs, x_insert_glyphs)
6079 (rows_from_pos_range, mouse_face_from_buffer_pos)
6080 (fast_find_string_pos, mouse_face_from_string_pos)
6081 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6083 (safe_call, init_from_display_pos, handle_fontified_prop)
6084 (handle_single_display_spec, load_overlay_strings)
6085 (with_echo_area_buffer, setup_echo_area_for_printing)
6086 (display_echo_area, echo_area_display)
6087 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
6088 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
6089 (redisplay_window, dump_glyph_row, display_mode_line)
6090 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 6091 (handle_display_spec, display_prop_string_p):
d311d28c
PE
6092 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6093 (handle_single_display_spec, build_desired_tool_bar_string)
6094 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
6095 (get_specified_cursor_type):
6096 Check that fixnums are in proper range for system types.
6097 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
6098 (Flookup_image_map):
6099 Don't assume fixnums fit in int.
6100 (compare_overlay_entries):
6101 Avoid mishandling comparisons due to subtraction overflow.
6102 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
6103 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
6104 (handle_tool_bar_click):
6105 Use int, not unsigned, since we prefer signed and the signedness
6106 doesn't matter here.
6107 (get_next_display_element, next_element_from_display_vector):
6108 Use int, not EMACS_INT, when int is wide enough.
6109 (start_hourglass): Use duration_to_sec_usec to do proper
6110 overflow checking on durations.
6111 * xfaces.c (Fbitmap_spec_p):
6112 Check that fixnums are in proper range for system types.
6113 (compare_fonts_by_sort_order):
6114 Avoid mishandling comparisons due to subtraction overflow.
6115 (Fx_family_fonts, realize_basic_faces):
6116 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6117 (Fx_family_fonts):
6118 Don't assume fixnum fits in int.
6119 Use SAFE_ALLOCA_LISP, not alloca.
6120 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
6121 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
6122 (face_at_buffer_position, face_for_overlay_string)
6123 (face_at_string_position):
6124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6125 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
6126 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
6127 (Fx_show_tip):
6128 Check that fixnums are in proper range for system types.
6129 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6130 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
6131 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6132 (Fx_change_window_property): Don't assume fixnums fit in int.
6133 * xfont.c (xfont_chars_supported):
6134 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6135 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
6136 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
6137 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6138 * xml.c (parse_region):
6139 * xrdb.c (magic_file_p):
6140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6141 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
6142 (x_get_local_selection, x_reply_selection_request)
6143 (x_handle_selection_request, wait_for_property_change):
6144 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6145 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
6146 short is wide enough.
6147 (x_send_client_event): Don't assume fixnum fits in int.
6148 * xterm.c (x_x_to_emacs_modifiers):
6149 Don't assume EMACS_INT overflows nicely into int.
6150 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
6151 may come from Lisp.
6152 (handle_one_xevent): NATNUMP can eval its arg twice.
6153 (x_connection_closed):
6154 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6155 * xterm.h: Adjust decls to match defn changes elsewhere.
6156 (struct scroll_bar): Use struct vectorlike_header
6157 rather than rolling our own approximation.
6158 (SCROLL_BAR_VEC_SIZE): Remove; not used.
6159
c6574eb5
GM
61602012-05-25 Glenn Morris <rgm@gnu.org>
6161
6162 * lisp.mk (lisp): Update for more files being compiled now.
6163
e8d32c7e
SM
61642012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
6165
48def666
SM
6166 * lread.c: Remove `read_pure' which makes no difference.
6167 (read_pure): Remove var.
6168 (unreadpure): Remove function.
6169 (readevalloop): Don't call read_list with -1 flag.
6170 (read1, read_vector): Don't test read_pure any more.
6171 (read_list): Simplify.
6172
e8d32c7e
SM
6173 * fileio.c, character.h: Minor style tweaks.
6174
4b2addb7
DA
61752012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
6176
6177 * window.h (clip_changed): Remove useless declaration.
6178
584461b2
JB
61792012-05-22 Juanma Barranquero <lekktu@gmail.com>
6180
6181 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
6182 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
6183
34374650
PE
61842012-05-22 Paul Eggert <eggert@cs.ucla.edu>
6185
6186 Remove src/m/*.
6187 This directory predates autoconf and is no longer needed nowadays.
6188 Move its few remaining bits of functionality to where they're needed.
6189 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
6190 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
6191 * m/template.h: Remove.
6192 * Makefile.in (M_FILE): Remove. All uses removed.
6193 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
6194 * lisp.h (USE_LSB_TAG):
6195 * mem-limits.h (EXCEEDS_LISP_PTR):
6196 Use VAL_MAX, not VALBITS, in #if.
6197 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
6198 (EMACS_UINT): Define unconditionally now.
6199 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
6200 (BITS_PER_EMACS_INT): New constants, replacing
6201 what used to be in config.h, but not useful in #if.
6202 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
6203 define them any more.
6204 (VAL_MAX): New macro.
6205 (VALMASK): Use it.
6206 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
6207 BITS_PER_EMACS_INT, in #if.
6208 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
6209 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
6210 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
6211 * s/ms-w32.h (DATA_START):
6212 Move here from removed file m/intel386.h.
6213 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
6214 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
6215
261cb4bb
PE
62162012-05-21 Paul Eggert <eggert@cs.ucla.edu>
6217
6218 Assume C89 or later.
6219 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
6220 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
6221 (xrealloc):
6222 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
6223 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
6224 * textprop.c, tparam.c (NULL): Remove.
6225 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
6226 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
6227 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
6228 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
6229 * xterm.c (input_signal_count): Assume volatile works.
6230
ff23cd9f
KB
62312012-05-21 Ken Brown <kbrown@cornell.edu>
6232
6233 * xgselect.c (xg_select): Fix first argument in call to 'select'
6234 (bug#11508).
6235
1b170bc6
KB
62362012-05-20 Ken Brown <kbrown@cornell.edu>
6237
6238 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 6239 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 6240
b2f4d39f
KB
62412012-05-19 Ken Brown <kbrown@cornell.edu>
6242
6243 * xfns.c (x_in_use): Remove `static' qualifier.
6244 * xterm.h (x_in_use): Declare.
6245 * xgselect.c: Include xterm.h.
6246 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
6247 and `display_arg' (bug#9754).
6248
003fdae2
PE
62492012-05-19 Paul Eggert <eggert@cs.ucla.edu>
6250
9232a6d9
PE
6251 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
6252
003fdae2
PE
6253 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
6254 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
6255
784b56e2
EZ
62562012-05-18 Eli Zaretskii <eliz@gnu.org>
6257
6258 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
6259
6260 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 6261 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
6262
6263 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
6264 reference to image_cache->refcount.
6265 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
6266
a0a79cde
JL
62672012-05-17 Juri Linkov <juri@jurta.org>
6268
6269 * search.c (Fword_search_regexp, Fword_search_backward)
6270 (Fword_search_forward, Fword_search_backward_lax)
6271 (Fword_search_forward_lax): Move functions to isearch.el
6272 (bug#10145, bug#11381).
6273
b0572523
PE
62742012-05-16 Paul Eggert <eggert@cs.ucla.edu>
6275
6276 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
6277
9660f5fc
SM
62782012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
6279
6280 * lread.c (init_obarray): Declare Qt and Qnil as special.
6281
4374de83
GM
62822012-05-14 Glenn Morris <rgm@gnu.org>
6283
6284 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 6285 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 6286
dc44c39a
PE
62872012-05-14 Paul Eggert <eggert@cs.ucla.edu>
6288
078c97cb
PE
6289 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
6290
dc44c39a
PE
6291 * unexaix.c: Port to more-recent AIX compilers.
6292 (report_error, report_error_1, make_hdr, copy_sym)
6293 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
6294 Make arguments const char *, not char *, to avoid violations of C
6295 standard and to fix some AIX warnings reported by Gilles Pion.
6296
e18afed7 62972012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
6298
6299 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
6300 already have overlays loaded.
6301 (handle_single_display_spec): Before returning without displaying
6302 fringe bitmap, synchronize the bidi iterator with the main display
6303 iterator, by calling iterate_out_of_display_property.
6304 (iterate_out_of_display_property): Detect buffer iteration by
6305 testing that it->string is a Lisp string.
6306 (get_next_display_element): When the current object is exhausted,
6307 and there's something on it->stack, call set_iterator_to_next to
6308 proceed with what's on the stack, instead of returning zero.
6309 (set_iterator_to_next): If called at the end of a Lisp string,
6310 proceed to consider_string_end without incrementing string
6311 position. Don't increment display vector index past the end of
6312 the display vector. (Bug#11417)
c8fb9dc6
EZ
6313 (pos_visible_p): Don't report a position visible when move_it_to
6314 stopped at the last line of window, which happens to be scanned
6315 backwards by the bidi iteration. (Bug#11464)
ac268e67 6316
e18afed7 63172012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
6318
6319 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
6320 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
6321 are on a TTY, and thus unable to display on the fringes.
6322 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
6323 so we need to signal to the caller that this is a "replacing"
6324 display spec. This fixes display when the spec is invalid or we
6325 are on a TTY.
6326
e18afed7 63272012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
6328
6329 * unexaix.c (make_hdr): Fix typo in prototype.
6330 This bug broke the build on AIX. Problem reported by Gilles Pion.
6331
9d0a235a
MA
63322012-05-14 Michael Albinus <michael.albinus@gmx.de>
6333
6334 * keyboard.c (kbd_buffer_get_event): Read special events also in
6335 batch mode. (Bug#11415)
6336
9e6b06ed
GM
63372012-05-12 Glenn Morris <rgm@gnu.org>
6338
6339 * ns.mk: Update for ns_appbindir no longer having trailing "/".
6340
c1a1d7a3
EZ
63412012-05-12 Eli Zaretskii <eliz@gnu.org>
6342
6343 * lisp.mk (lisp): Add newcomment.elc.
6344
3fe7cdc8
GM
63452012-05-12 Glenn Morris <rgm@gnu.org>
6346
6347 * Makefile.in (MKDIR_P): New, set by configure.
6348 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
6349
53f7d2c0
PE
63502012-05-11 Paul Eggert <eggert@cs.ucla.edu>
6351
6352 Remove unused function hourglass_started.
6353 * dispextern.h (hourglass_started):
6354 * w32fns.c (hourglass_started):
6355 * xdisp.c (hourglass_started): Remove.
6356
75aafb17
JB
63572012-05-10 Juanma Barranquero <lekktu@gmail.com>
6358
6359 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
6360 Update dependencies.
6361
12959e8e
PE
63622012-05-10 Paul Eggert <eggert@cs.ucla.edu>
6363
97107e2e
PE
6364 * xgselect.c (xg_select): Put maxfds+1 into a var.
6365 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
6366
12959e8e
PE
6367 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
6368
836d29b3
DA
63692012-05-10 Dave Abrahams <dave@boostpro.com>
6370
6371 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
6372 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
6373
5cb67954
MA
63742012-05-09 Michael Albinus <michael.albinus@gmx.de>
6375
6376 * dbusbind.c (xd_registered_buses): New internal Lisp object.
6377 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
6378 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
6379 Initialize xd_registered_buses.
6380
3478ec45
PE
63812012-05-09 Paul Eggert <eggert@cs.ucla.edu>
6382
b263a6b0
PE
6383 Untag more efficiently if USE_LSB_TAG.
6384 This is based on a proposal by YAMAMOTO Mitsuharu in
6385 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
6386 For an admittedly artificial (nth 8000 longlist) benchmark on
6387 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
6388 Emacs's overall text size by 1%.
6389 * lisp.h (XUNTAG): New macro.
6390 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
6391 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
6392 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
6393 * eval.c (Fautoload):
6394 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
6395 * frame.h (XFRAME): Use XUNTAG.
6396
3478ec45
PE
6397 Port recent dbusbind.c changes to 32-bit --with-wide-int.
6398 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
6399 Remove unportable assumptions about print widths of types like
6400 dbus_uint32_t.
6401 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
6402 intptr_t when converting between pointer and integer, to avoid GCC
6403 warnings about wrong width.
6404
666b903b 64052012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
6406
6407 * w32proc.c (new_child): Force Windows to reserve only 64KB of
6408 stack for each reader_thread, instead of defaulting to 8MB
6409 determined by the linker. This avoids failures in creating
6410 subprocesses on Windows 7, see the discussion in this thread:
6411 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
6412
b120cc17
JC
64132012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
6414
6415 Fix up display of the *Minibuf-0* buffer in the mini window.
6416 * keyboard.c (read_char): Don't clear the echo area if there's no
6417 message to clear.
6418 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 6419 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 6420
9a4b36f8
MA
64212012-05-07 Michael Albinus <michael.albinus@gmx.de>
6422
6423 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
6424 batch mode.
6425
e5f9458f
CY
64262012-05-06 Chong Yidong <cyd@gnu.org>
6427
6428 * lisp.mk (lisp): Update.
6429
eceeb5fc 64302012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
6431
6432 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
6433
71873e2b
SM
64342012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
6435
6436 * data.c (PUT_ERROR): New macro.
6437 (syms_of_data): Use it. Add new error type `user-error'.
6438 * undo.c (user_error): New function.
6439 (Fprimitive_undo): Use it.
6440 * print.c (print_error_message): Adjust print style for `user-error'.
6441 * keyboard.c (user_error): New function.
6442 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
6443
ab0fa4e4
PE
64442012-05-03 Paul Eggert <eggert@cs.ucla.edu>
6445
6446 Do not limit current-time-string to years 1000..9999.
6447 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
6448 (Fcurrent_time_string): Support any year that is supported by the
6449 underlying localtime representation. Don't use asctime, as it
6450 has undefined behavior for years outside the range -999..9999.
6451
7ed806a7
PE
64522012-05-02 Paul Eggert <eggert@cs.ucla.edu>
6453
6454 Fix race conditions involving setenv, gmtime, localtime, asctime.
6455 Without this fix, interrupts could mess up code that uses these
6456 nonreentrant functions, since setting TZ invalidates existing
6457 tm_zone or tzname values, and since most of these functions return
6458 pointers to static storage.
6459 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
6460 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
6461 Grow the critical sections to include not just invoking
6462 localtime/gmtime, but also accessing these functions' results
6463 including their tm_zone values if any, and any related TZ setting.
6464 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
6465 so that the struct tm is saved in the critical section.
6466 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
6467 motivated by the fact that memory allocation needs to be outside
6468 the critical section.
6469
0c16dfed
DA
64702012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
6471
6472 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
6473 with RESET_INTERVAL.
6474
6475 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6476 Remove duplicated buffer name initialization.
6477
3f83ace8
JM
64782012-05-02 Jim Meyering <jim@meyering.net>
6479
6480 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
6481
c7b8541e
JM
6482 * xfns.c (x_window): Use xstrdup (Bug#11375).
6483
90207a15 64842012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
6485
6486 * xdisp.c (pos_visible_p): If already at a newline from the
6487 display string before the 'while' loop, don't walk back the glyphs
6488 from it3.glyph_row. Solves assertion violation when the display
6489 string begins with a newline (egg.el). (Bug#11367)
6490
b593d6a9
AH
64912012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
6492
6493 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
6494 Move to simple.el.
6495
4737362e
GM
64962012-05-01 Glenn Morris <rgm@gnu.org>
6497
99cf43f9
GM
6498 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
6499 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
6500 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
6501 All were removed before 23.1.
6502
9311dcff
GM
6503 * dispnew.c: Remove HAVE_LIBNCURSES test;
6504 it is always true on relevant platforms.
6505
4d5c6349
GM
6506 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
6507 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
6508
4737362e
GM
6509 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
6510
74dd3a6b
AS
65112012-04-30 Andreas Schwab <schwab@linux-m68k.org>
6512
6513 * .gdbinit (xpr): Remove checks for no longer existing misc types.
6514 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
6515 Remove.
6516
13c379ee
PE
65172012-04-28 Paul Eggert <eggert@cs.ucla.edu>
6518
6519 Do not avoid creating empty evaporating overlays (Bug#9642).
6520 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
6521 That is, do not delete an evaporating overlay if it becomes
6522 empty after its bounds are adjusted to fit within its buffer.
6523 This fix caused other problems, and I'm reverting it until we get
6524 to the bottom of them.
6525
a8e7d6d7 65262012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
6527
6528 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
6529
a8e7d6d7 65302012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
6531
6532 * xdisp.c (pos_visible_p): If the window start position is beyond
6533 ZV, start the display from buffer beginning. Prevents assertion
6534 violation in init_iterator when the minibuffer window is scrolled
6535 via the scroll bar.
6536
6537 * window.c (window_scroll_pixel_based): Likewise.
6538
a8e7d6d7 65392012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
6540
6541 * keymap.c (where_is_internal): Doc fix (Bug#10872).
6542
a8e7d6d7 65432012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
6544
6545 * fileio.c (Fcopy_file, Fset_file_selinux_context):
6546 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
6547
a8e7d6d7 65482012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 6549
b593d6a9
AH
6550 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
6551 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 6552
1c6900d9
EZ
65532012-04-26 Eli Zaretskii <eliz@gnu.org>
6554
4c3fa1d9
EZ
6555 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
6556 display element, check also the underlying string or buffer
6557 character. (Bug#11341)
6558
1c6900d9
EZ
6559 * w32menu.c: Include w32heap.h.
6560 (add_menu_item): If the call to AppendMenuW (via
6561 unicode_append_menu) fails, disable Unicode menus only if we are
6562 running on Windows 9X/Me.
6563
42bf8205
AS
65642012-04-24 Andreas Schwab <schwab@linux-m68k.org>
6565
6566 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
6567 (xgetint): Add missing shift for LSB tags.
6568
b1bac16e
MR
65692012-04-24 Martin Rudalics <rudalics@gmx.at>
6570
6571 * keyboard.c (read_char): Don't wipe echo area for select window
6572 events: These might get delayed via `mouse-autoselect-window'
6573 (Bug#11304).
6574
d69621cc
JB
65752012-04-24 Juanma Barranquero <lekktu@gmail.com>
6576
6577 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
6578 manipulation of :loaded-from data.
6579
02fd101b
JB
65802012-04-23 Juanma Barranquero <lekktu@gmail.com>
6581
6582 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
6583 now a cons (bug#11311).
6584
888bec30
PE
65852012-04-23 Paul Eggert <eggert@cs.ucla.edu>
6586
89a438bd
PE
6587 Do not create empty overlays with the evaporate property (Bug#9642).
6588 * buffer.c (Fmove_overlay): Delete an evaporating overlay
6589 if it becomes empty after its bounds are adjusted to fit within
6590 its buffer. Without this fix, in a nonempty buffer (let ((o
6591 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
6592 yields an empty overlay that has the evaporate property, which is
6593 not supposed to happen.
6594
1068fe4d
PE
6595 Fix minor GTK3 problems found by static checking.
6596 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6597 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6598 (struct _EmacsFixedClass, emacs_fixed_get_type):
6599 Move decls here from emacsgtkfixed.h, since they needn't be public.
6600 (emacs_fixed_get_type): Now static.
6601 (emacs_fixed_class_init): Omit unused local.
6602 (emacs_fixed_child_type): Remove; unused.
6603 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6604 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6605 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
6606 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
6607 (EMACS_FIXED_GET_CLASS): Remove; unused.
6608 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
6609
888bec30
PE
6610 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
6611 Problem reported by Juanma Barranquero for Windows -Wunused-function.
6612
de85e130
PE
66132012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6614
d0baac98 6615 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 6616 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
6617 (__malloc_size_t, __malloc_ptrdiff_t):
6618 Remove. All uses removed, replaced by the definiens if needed,
6619 since we can assume C89 or better now.
6620 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
6621 (protect_malloc_state, align, get_contiguous_space)
6622 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
6623 (malloc_atfork_handler_child, malloc_enable_thread)
6624 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
6625 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
6626 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
6627 (special_realloc, _realloc_internal_nolock, _realloc_internal)
6628 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
6629 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
6630 Define using prototypes, not old style.
6631 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
6632 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
6633 (align): Don't assume that signed integer overflow wraps around.
6634 Omit unused local var.
6635 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
6636 (_free_internal_nolock, memalign, mallochook, reallochook):
6637 Omit no-longer-needed casts.
6638 (valloc): Use getpagesize, not __getpagesize.
6639 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
6640 (struct hdr): The 'magic' member is now size_t, not unsigned long.
6641
de85e130
PE
6642 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
6643
dcbf5805
MA
66442012-04-22 Michael Albinus <michael.albinus@gmx.de>
6645
6646 Move functions from C to Lisp. Make non-blocking method calls
6647 the default. Implement further D-Bus standard interfaces.
6648
6649 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
6650 (QCdbus_request_name_allow_replacement)
6651 (QCdbus_request_name_replace_existing)
6652 (QCdbus_request_name_do_not_queue)
6653 (QCdbus_request_name_reply_primary_owner)
6654 (QCdbus_request_name_reply_in_queue)
6655 (QCdbus_request_name_reply_exists)
6656 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
6657 (QCdbus_registered_serial, QCdbus_registered_method)
6658 (QCdbus_registered_signal): New Lisp objects.
6659 (XD_DEBUG_MESSAGE): Use sizeof.
6660 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
6661 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
6662 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
6663 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
6664 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
6665 (xd_signature, xd_append_arg): Allow float for integer types.
6666 (xd_get_connection_references): New function.
b593d6a9
AH
6667 (xd_get_connection_address): Rename from xd_initialize.
6668 Return cached address.
dcbf5805
MA
6669 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
6670 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
6671 level.
6672 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 6673 Return number of refcounts.
dcbf5805
MA
6674 (Fdbus_get_unique_name): Make stronger parameter check.
6675 (Fdbus_message_internal): New defun.
6676 (Fdbus_call_method, Fdbus_call_method_asynchronously)
6677 (Fdbus_method_return_internal, Fdbus_method_error_internal)
6678 (Fdbus_send_signal, Fdbus_register_service)
6679 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
6680 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
6681 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
6682 (Vdbus_compiled_version, Vdbus_runtime_version)
6683 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
6684 (Vdbus_message_type_method_return, Vdbus_message_type_error)
6685 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
6686 (Vdbus_registered_buses, Vdbus_registered_objects_table):
6687 Adapt docstring.
dcbf5805 6688
52828e02
PE
66892012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6690
da05bc4c
PE
6691 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
6692 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
6693 Do not assume ptrdiff_t is the same width as 'int'.
6694
52828e02
PE
6695 * alloc.c: Handle unusual debugging option combinations.
6696 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
6697 since the two debugging options are incompatible.
6698 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
6699 is defined.
6700 (mem_init, mem_insert, mem_insert_fixup):
6701 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
6702 (NEED_MEM_INSERT): Remove; no longer needed.
6703
f01769f9
LL
67042012-04-22 Leo Liu <sdl.web@gmail.com>
6705
6706 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
6707
5790543d
PE
67082012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6709
6710 * sysdep.c [__FreeBSD__]: Minor cleanups.
6711 (list_system_processes, system_process_attributes) [__FreeBSD__]:
6712 Use Emacs indenting style more consistently. Avoid some casts.
6713 Use 'double' consistently rather than mixing 'float' and 'double'.
6714
b91b7e4d
EW
67152012-04-21 Eduard Wiebe <usenet@pusto.de>
6716
b593d6a9
AH
6717 * sysdep.c (list_system_processes, system_process_attributes):
6718 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 6719
6114eb15
AS
67202012-04-21 Andreas Schwab <schwab@linux-m68k.org>
6721
6722 * lisp.mk (lisp): Update.
6723
2f38dff7
PE
67242012-04-20 Paul Eggert <eggert@cs.ucla.edu>
6725
6726 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
6727 It is never used otherwise.
6728
4ae29f89
SM
67292012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
6730
6731 * print.c (print_preprocess): Only check print_depth if print-circle
6732 is nil.
6733 (print_object): Check for cycles even when print-circle is nil and
6734 print-gensym is t, but only check print_depth if print-circle is nil.
6735
f30d612a
CY
67362012-04-20 Chong Yidong <cyd@gnu.org>
6737
6738 * process.c (wait_reading_process_output): If EIO occurs on a pty,
6739 set the status to "failed" and ensure that sentinel is run.
6740
c07a4c0b 67412012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
6742
6743 * process.c (Fset_process_inherit_coding_system_flag)
6744 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 6745 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 6746
c07a4c0b 67472012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
6748
6749 * xdisp.c (string_buffer_position_lim): Limit starting position to
6750 BEGV.
6751 (set_cursor_from_row): If called for a mode-line or header-line
6752 row, return zero immediately.
6753 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
6754 farther than the first row after the header line, if any.
6755 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
6756 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
6757
c07a4c0b 67582012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6759
4ae29f89
SM
6760 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
6761 (bug#11238).
ad3a2b41 6762
c07a4c0b 67632012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 67642012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
6765
6766 configure: new option --enable-gcc-warnings (Bug#11207)
6767 * Makefile.in (C_WARNINGS_SWITCH): Remove.
6768 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
6769 (ALL_CFLAGS): Use new macros rather than old.
6770 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
6771 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
6772 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
6773 -Wunused-result, -Wunused-variable. This should go away once
6774 the Emacs and Gnulib regex code is merged.
6775 (xmalloc, xrealloc): Now static.
6776
aba027e8
PE
67772012-04-17 Paul Eggert <eggert@cs.ucla.edu>
6778
6779 * dired.c (Fsystem_groups): Remove unused local.
6780
e5a36063
GM
67812012-04-17 Glenn Morris <rgm@gnu.org>
6782
6783 * dired.c (Fsystem_users): Doc fix.
6784
316411f0
DA
67852012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
6786
6787 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
6788 (syms_of_dired): Add them.
6789
9426aba4
PE
67902012-04-16 Paul Eggert <eggert@cs.ucla.edu>
6791
b62a57be
PE
6792 Fix minor alloc.c problems found by static checking.
6793 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
6794 New extern decls, to avoid calling undeclared functions.
6795 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
6796 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
6797 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
6798 (NEED_MEM_INSERT): New macro.
6799 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 6800 Remove one incorrect comment and fix another.
b62a57be 6801
3539f31f
PE
6802 Fix minor ralloc.c problems found by static checking.
6803 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6804 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
6805 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
6806 (r_alloc_sbrk): Now static.
6807
a041960a
PE
6808 Improve ralloc.c interface checking.
6809 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6810 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
6811 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
6812 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
6813 [REL_ALLOC]: ... to here, to check interface.
6814 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
6815 Remove decls. This fixes an "It stinks!".
6816
9426aba4
PE
6817 * alloc.c (which_symbols): Fix alignment issue / type clash.
6818
d55c12ed
AS
68192012-04-15 Andreas Schwab <schwab@linux-m68k.org>
6820
6821 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
6822 (struct Lisp_Misc_Any): Likewise.
6823 (struct Lisp_Free): Likewise.
6824 * alloc.c (union aligned_Lisp_Symbol): Define.
6825 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
6826 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
6827 (union aligned_Lisp_Misc): Define.
6828 (MARKER_BLOCK_SIZE, struct marker_block): Use union
6829 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 6830 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 6831
b948ce8b
PE
68322012-04-14 Paul Eggert <eggert@cs.ucla.edu>
6833
6834 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
6835 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
6836 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
6837 * s/netbsd.h, s/sol2-6.h:
6838 Remove definition of GC_MARK_STACK, since the default now works.
6839 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
6840 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
6841 no longer the default.
6842 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
6843
35dc09a1 68442012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6845
35dc09a1
GM
6846 * lread.c (lisp_file_lexically_bound_p):
6847 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 6848
35dc09a1
GM
68492012-04-14 Eli Zaretskii <eliz@gnu.org>
6850
6851 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
6852 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
6853
68542012-04-14 Jan Djärv <jan.h.d@swipnet.se>
6855
6856 * nsterm.m (constrainFrameRect): Always constrain when there is only
6857 one screen (Bug#10962).
6858
bcd86815
KB
68592012-04-13 Ken Brown <kbrown@cornell.edu>
6860
6861 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
6862
c25df26e
RT
68632012-04-13 Reuben Thomas <rrt@sc3d.org>
6864
6865 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
6866
0fc59f1e
DC
68672012-04-11 Daniel Colascione <dancol@dancol.org>
6868
6869 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
6870 against is gone. It's better to use vfork now so that when Cygwin
6871 gains a new, working vfork, we use it automatically (bug#10398).
6872
de8c03dc
SM
68732012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6874
6875 * window.c (save_window_save): Obey window-point-insertion-type.
6876
2f097256
GM
68772012-04-11 Glenn Morris <rgm@gnu.org>
6878
6879 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
6880
453b951e
SM
68812012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6882
6883 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
6884
75f1671a 68852012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
6886
6887 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
6888 (force_quit_count): New var.
6889 (handle_interrupt): Use it.
6890
2a8ce227
JB
68912012-04-10 Juanma Barranquero <lekktu@gmail.com>
6892
6893 * w32.c (w32_delayed_load): Record the full path of the library
6894 being loaded (bug#10424).
6895
935396c0
GM
68962012-04-09 Glenn Morris <rgm@gnu.org>
6897
05920a43
GM
6898 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
6899 not just in the obarray, before snarfing them. (Bug#11036)
6900
935396c0
GM
6901 * Makefile.in ($(leimdir)/leim-list.el):
6902 Pass EMACS rather than BUILT_EMACS.
6903
a18ecafa
TZ
69042012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
6905
6906 * process.c (make_process):
6907 * process.h: Add integer `gnutls_handshakes_tried' member to
6908 process struct.
6909
6bbef4e5
JC
6910 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
6911 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
6912
6913 * gnutls.c (gnutls_log_function2i): Convenience log function.
6914 (emacs_gnutls_read): Use new log functions,
6915 `gnutls_handshakes_tried' process member, and
6916 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
6917 attempts per process (connection).
6918
b4d3bc10
CY
69192012-04-09 Chong Yidong <cyd@gnu.org>
6920
6921 * eval.c (Fuser_variable_p, user_variable_p_eh)
6922 (lisp_indirect_variable): Functions deleted.
6923 (Fdefvar): Caller changed.
6924
6925 * callint.c (Finteractive, Fcall_interactively):
6926 * minibuf.c (Fread_variable): Callers changed.
6927
70f4d973
EZ
69282012-04-09 Eli Zaretskii <eliz@gnu.org>
6929
6930 * xdisp.c (set_cursor_from_row): If the display string appears in
6931 the buffer at position that is closer to point than the position
6932 after the display string, display the cursor on the first glyph of
6933 the display string. Fixes cursor display when a 'display' text
6934 property immediately follows invisible text. (Bug#11094)
6935
cb3c2e3e
PE
69362012-04-09 Paul Eggert <eggert@cs.ucla.edu>
6937
6938 composite.c: use 'double' consistently
6939 * composite.c (get_composition_id): Use 'double' consistently
6940 instead of converting 'float' to 'double' and vice versa; this is
6941 easier to understand and avoids a GCC warning.
6942
fd06db5d
GM
69432012-04-09 Glenn Morris <rgm@gnu.org>
6944
50fe702a
GM
6945 * Makefile.in: Generate leim-list with bootstrap-emacs, in
6946 preparation for dumping it with emacs. (Bug#4789)
6947 (leimdir): New variable.
6948 ($(leimdir)/leim-list.el): New rule.
6949 (emacs$(EXEEXT)): Depend on leim-list.el.
6950
fd06db5d
GM
6951 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
6952 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
6953 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
6954
55c131ee
AS
69552012-04-08 Andreas Schwab <schwab@linux-m68k.org>
6956
6957 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
6958 proper alignment.
6959
9209588f
JB
69602012-04-07 Juanma Barranquero <lekktu@gmail.com>
6961
6962 * xml.c (init_libxml2_functions) [WINDOWSNT]:
6963 Remove unused local variable.
6964
e3fb2efb
PE
69652012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6966
6967 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
6968 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
6969 (mark_memory): Mark Lisp_Objects only if pointers might hide in
6970 objects, as mark_maybe_pointer will catch them otherwise.
6971 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
6972 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
6973
b5385551
PE
69742012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6975
6976 Fix typo that broke non-Windows builds.
6977 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
6978
9078ead6
EZ
69792012-04-07 Eli Zaretskii <eliz@gnu.org>
6980
6981 Support building on MS-Windows with libxml2.
6982
6983 * makefile.w32-in (OBJ2): Add xml.$(O).
6984 (GLOBAL_SOURCES): Add xml.c.
6985 ($(BLD)/xml.$(O)): New dependency list.
6986
6987 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
6988 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
6989 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
6990 [!WINDOWSNT]: New macros.
6991 (init_libxml2_functions, libxml2_loaded_p): New functions.
6992 (parse_region): Call fn_xmlCheckVersion instead of using the macro
6993 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
6994 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
6995 Calls xmlCleanupParser only if libxml2 was loaded (or statically
6996 linked in).
6bbef4e5
JC
6997 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
6998 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
6999 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
7000
7001 * emacs.c: Don't include libxml/parser.h.
7002 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
7003 xmlCleanupParser directly.
7004
7005 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
7006
3811fdf3
EZ
70072012-04-07 Eli Zaretskii <eliz@gnu.org>
7008
7009 * indent.c (Fvertical_motion): If there is a display string at
7010 point, use it.vpos to compute how many lines to backtrack after
7011 move_it_to point. (Bug#11133)
7012
2f8e16b2
EZ
70132012-04-06 Eli Zaretskii <eliz@gnu.org>
7014
7015 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
7016 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
7017 about subtle differences between FETCH_CHAR* and STRING_CHAR*
7018 macros related to unification of CJK characters. For the details,
7019 see the discussion following the message here:
7020 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
7021
3d439cd1
CY
70222012-04-04 Chong Yidong <cyd@gnu.org>
7023
7024 * keyboard.c (Vdelayed_warnings_list): Doc fix.
7025
8bc53d00
EZ
70262012-04-01 Eli Zaretskii <eliz@gnu.org>
7027
7028 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
7029 instead of alloca. (Bug#11138)
7030
3b0512a3
AS
70312012-04-01 Andreas Schwab <schwab@linux-m68k.org>
7032
7033 * w32menu.c (is_simple_dialog): Properly check lisp types.
7034 (Bug#11141)
7035
8427ddd2
EZ
70362012-03-31 Eli Zaretskii <eliz@gnu.org>
7037
979022ef
EZ
7038 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
7039 position we get to after a call to move_it_to fails the
7040 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
7041 only if we wind up in a string from display property. (Bug#11063)
7042
a6b1c7cc
EZ
7043 * window.c (Fdelete_other_windows_internal): Invalidate the row
7044 and column information about mouse highlight, so that redisplay
7045 restores it after reallocating the glyph matrices. (Bug#7464)
7046
8427ddd2
EZ
7047 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
7048 string comes from a `display' text property, use the buffer
7049 position of that property as if we actually saw that position in
7050 the row's glyphs.
697ba24b
EZ
7051 (move_it_by_lines): Remove the assertion that
7052 "it->current_x == 0 && it->hpos == 0" which can be legitimately
7053 violated when there's a before-string at the beginning of a line.
7054 (Bug#11063)
8427ddd2 7055
65a0a738
EZ
70562012-03-30 Eli Zaretskii <eliz@gnu.org>
7057
7058 * xdisp.c (append_space_for_newline): If the default face was
7059 remapped, use the remapped face for the appended newline.
7060 (extend_face_to_end_of_line): Use the remapped default face for
7061 extending the face to the end of the line.
7062 (display_line): Call extend_face_to_end_of_line when the default
7063 face was remapped. (Bug#11068)
7064
581355cc
EZ
70652012-03-29 Eli Zaretskii <eliz@gnu.org>
7066
7067 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
7068
e8fc049f
SM
70692012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7070
7071 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
7072
4fb9a543
GM
70732012-03-27 Glenn Morris <rgm@gnu.org>
7074
7075 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
7076 Doc fixes.
7077
679910f1
KH
70782012-03-26 Kenichi Handa <handa@m17n.org>
7079
7080 * dispextern.h (struct glyph): Fix previous change. Change the
7081 bit length of glyphless.ch to 25 (Bug#11082).
7082
90d49b7f
CY
70832012-03-26 Chong Yidong <cyd@gnu.org>
7084
7085 * keyboard.c (Vselection_inhibit_update_commands): New variable.
7086 (command_loop_1): Use it; inhibit selection update for
7087 handle-select-window too (Bug#8996).
7088
f514f6f0
FP
70892012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
7090
e8fc049f 7091 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 7092
bf43fa51
KH
70932012-03-25 Kenichi Handa <handa@m17n.org>
7094
7095 * dispextern.h (struct glyph): Change the bit length of
7096 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
7097
8a0c01dd
EZ
70982012-03-24 Eli Zaretskii <eliz@gnu.org>
7099
7100 * s/ms-w32.h (tzname): Include time.h before redirecting to
7101 _tzname. Fixes the MSVC build. (Bug#9960)
7102
7d1c3a76
AS
71032012-03-24 Andreas Schwab <schwab@linux-m68k.org>
7104
8ed79523
AS
7105 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
7106 characters.
7107
7d1c3a76
AS
7108 * xterm.c (XTread_socket): Only modify handling_signal if
7109 !SYNC_INPUT. (Bug#11080)
7110
e99a9b8b
EZ
71112012-03-23 Eli Zaretskii <eliz@gnu.org>
7112
7113 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
7114 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
7115 when fetching a multibyte character consumes more bytes than
7116 CHAR_BYTES returns, due to unification of CJK characters in
7117 string_char. (Bug#11073)
7118
5063c0e1
TN
71192012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
7120
7121 * process.c (wait_reading_process_output): Handle pty disconnect
7122 by refraining from sending oneself a SIGCHLD (bug#10933).
7123
9f851fbd
CY
71242012-03-22 Chong Yidong <cyd@gnu.org>
7125
7126 * dispextern.h (struct it): New member string_from_prefix_prop_p.
7127
5063c0e1 7128 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
7129 Mark string as coming from a prefix property.
7130 (handle_face_prop): Use default face for prefix strings (Bug#4281).
7131 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
7132
fb5b8aca
CY
71332012-03-21 Chong Yidong <cyd@gnu.org>
7134
7135 * xfaces.c (Vface_remapping_alist): Doc fix.
7136
62356a1b
EZ
71372012-03-20 Eli Zaretskii <eliz@gnu.org>
7138
7139 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
7140 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
7141 Doc fixes.
62356a1b 7142
025de85b
CY
71432012-03-20 Chong Yidong <cyd@gnu.org>
7144
7145 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
7146 to reflect default non-nil value of redisplay-dont-pause.
7147
4827f94e
KH
71482012-03-19 Kenichi Handa <handa@m17n.org>
7149
7150 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
7151 it fit in a valid range (Bug#11003).
7152
e50a24a2
EZ
71532012-03-18 Eli Zaretskii <eliz@gnu.org>
7154
7155 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
7156 that is not from display property, accept the row as a "cursor
7157 row" if one of the string's character has a non-nil `cursor'
7158 property. Fixes cursor positioning when there are newlines in
7159 overlay strings, e.g. in icomplete.el. (Bug#11035)
7160
9af5ed87
PE
71612012-03-12 Paul Eggert <eggert@cs.ucla.edu>
7162
7163 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
7164
d1f55f16
CY
71652012-03-12 Chong Yidong <cyd@gnu.org>
7166
7167 * eval.c (inhibit_lisp_code): Rename from
7168 inhibit_window_configuration_change_hook; move from window.c.
7169
7170 * xfns.c (unwind_create_frame_1, Fx_create_frame):
7171 * window.c (run_window_configuration_change_hook)
7172 (syms_of_window): Callers changed.
7173
66c5eebd
CY
71742012-03-11 Chong Yidong <cyd@gnu.org>
7175
413df973
CY
7176 * keymap.c (Fkey_description): Doc fix (Bug#9700).
7177
66c5eebd
CY
7178 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
7179
1de11f56
CY
71802012-03-10 Chong Yidong <cyd@gnu.org>
7181
7182 * frame.c (other_visible_frames): Don't assume the selected frame
7183 is visible (Bug#10955).
7184
cae07000
SM
71852012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
7186
7187 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
7188
89c94350
JD
71892012-03-08 Jan Djärv <jan.h.d@swipnet.se>
7190
7191 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
7192 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
7193 zero (Bug#10954).
7194
999dd333
GM
71952012-03-03 Glenn Morris <rgm@gnu.org>
7196
01a6dcc8 7197 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 7198
de0100f2
EZ
71992012-03-02 Eli Zaretskii <eliz@gnu.org>
7200
7201 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
7202 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
7203 (redisplay_window, next_element_from_string): Fix typos in
7204 comments.
3e441275
EZ
7205 (redisplay_window): Pass to move_it_vertically the margin in
7206 pixels, not in screen lines.
de0100f2 7207
96a72ee9
GM
72082012-03-02 Glenn Morris <rgm@gnu.org>
7209
7210 * buffer.c (buffer-list-update-hook): Doc fix.
7211
312508d7
EZ
72122012-02-29 Eli Zaretskii <eliz@gnu.org>
7213
7214 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
7215 push_it before setting up the iterator for the first overlay
7216 string, even if we have an empty string loaded.
7217 (next_overlay_string): If there's an empty string on the iterator
7218 stack, pop the stack. (Bug#10903)
7219
27f3c637
PE
72202012-02-25 Paul Eggert <eggert@cs.ucla.edu>
7221
7222 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
7223 Suggested by Stefan Monnier in
7224 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
7225 * alloc.c (widen_to_Lisp_Object): New static function.
7226 (mark_memory): Also mark Lisp_Objects by fetching pointer words
7227 and widening them to Lisp_Objects. This would work even if
7228 USE_LSB_TAG is defined and wide integers are used, which might
7229 happen in a future version of Emacs.
7230
3c9dfce6
CY
72312012-02-25 Chong Yidong <cyd@gnu.org>
7232
fa74b241
CY
7233 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
7234 Doc fix.
7235
3c9dfce6
CY
7236 * xselect.c (Fx_selection_exists_p): Doc fix.
7237 (x_clipboard_manager_save_all): Print an informative message
7238 before saving to clipboard manager.
7239
9486df08
CY
72402012-02-24 Chong Yidong <cyd@gnu.org>
7241
7242 * keyboard.c (process_special_events): Handle all X selection
7243 requests in kbd_buffer, not just the next one (Bug#8869).
7244
f01d3321
CY
72452012-02-23 Chong Yidong <cyd@gnu.org>
7246
7247 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
7248 call when setting menu-bar-lines and tool-bar-lines parameters.
7249 (unwind_create_frame_1): New helper function.
7250
7251 * window.c (inhibit_window_configuration_change_hook): New var.
7252 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 7253 (syms_of_window): Initialize it.
f01d3321 7254
86b847b6
CY
72552012-02-22 Chong Yidong <cyd@gnu.org>
7256
7257 * xterm.c (x_draw_image_relief): Add missing type check for
7258 Vtool_bar_button_margin (Bug#10743).
7259
a59225b1
CY
72602012-02-21 Chong Yidong <cyd@gnu.org>
7261
7262 * fileio.c (Vfile_name_handler_alist): Doc fix.
7263
7264 * buffer.c (Fget_file_buffer): Protect against invalid file
7265 handler return value.
7266
310f5bd4
PE
72672012-02-20 Paul Eggert <eggert@cs.ucla.edu>
7268
cb3a28cc
PE
7269 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
7270 when computing $valmask.
7271
310f5bd4
PE
7272 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
7273 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
7274 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
7275 It's useless in that case, and it can cause problems on hosts
7276 that allocate halves of EMACS_INT values separately.
7277 Reported by Dan Horák. Diagnosed by Andreas Schwab in
7278 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
7279 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
7280 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
7281 it avoids undefined behavior on hosts where shifting right by more
7282 than the word width has undefined behavior.
7283
2375c96a
CY
72842012-02-19 Chong Yidong <cyd@gnu.org>
7285
7286 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
7287 (Funhandled_file_name_directory, Ffile_name_as_directory)
7288 (Fdirectory_file_name, Fexpand_file_name)
7289 (Fsubstitute_in_file_name): Protect against invalid file handler
7290 return values (Bug#10845).
7291
3eb49e71
EZ
72922012-02-18 Eli Zaretskii <eliz@gnu.org>
7293
7294 * .gdbinit (pitx): Fix incorrect references to fields of the
7295 iterator stack.
7296
7b926f3f
CY
72972012-02-17 Chong Yidong <cyd@gnu.org>
7298
7299 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
7300
11273115
PE
73012012-02-15 Paul Eggert <eggert@cs.ucla.edu>
7302
7303 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
7304 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
7305
c3a70e2b
CY
73062012-02-15 Chong Yidong <cyd@gnu.org>
7307
7308 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
7309 marked as special. Also, starting docstrings with * is obsolete.
7310
0ca43699
AS
73112012-02-13 Andreas Schwab <schwab@linux-m68k.org>
7312
7313 * gnutls.c (emacs_gnutls_write): Fix last change.
7314
2e8f3c56
LI
73152012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
7316
7317 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
7318 send_process.
7319
af70074f
SM
73202012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
7321
7322 * keymap.c (Fsingle_key_description): Handle char ranges.
7323
95986d52
CY
73242012-02-12 Chong Yidong <cyd@gnu.org>
7325
afd83bd1
CY
7326 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
7327 as that creates a dangerous corner case.
7328
95986d52
CY
7329 * window.c (Fdelete_window_internal): Invalidate the mouse
7330 highlight (Bug#9904).
7331
bd7da63e
GM
73322012-02-12 Glenn Morris <rgm@gnu.org>
7333
7334 * xselect.c (Fx_own_selection_internal)
7335 (Fx_get_selection_internal, Fx_disown_selection_internal)
7336 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
7337 * nsselect.m (Fx_own_selection_internal)
7338 (Fx_disown_selection_internal, Fx_selection_exists_p)
7339 (Fx_selection_owner_p, Fx_get_selection_internal):
7340 Sync docs and argument specs with the xselect.c versions.
7341
77abcbc2
LI
73422012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
7343
7344 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
7345
90b671e2
EZ
73462012-02-11 Eli Zaretskii <eliz@gnu.org>
7347
1c0ca0b7
EZ
7348 * w32select.c (Fx_selection_exists_p): Sync doc string and
7349 argument list with xselect.c. (Bug#10783)
7350
7351 * w16select.c (Fx_selection_exists_p): Sync doc string and
7352 argument list with xselect.c. (Bug#10783)
90b671e2 7353
49241268
GM
73542012-02-10 Glenn Morris <rgm@gnu.org>
7355
7356 * fns.c (Fsecure_hash): Doc fix.
7357
f998bbe7 73582012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
7359
7360 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
7361
0992bd9c
CY
73622012-02-07 Chong Yidong <cyd@gnu.org>
7363
7364 * buffer.c (Fbuffer_local_variables)
7365 (buffer_lisp_local_variables): Handle unbound vars correctly;
7366 don't let Qunbound leak into Lisp.
7367
af008560
GM
73682012-02-07 Glenn Morris <rgm@gnu.org>
7369
dd605cc4
GM
7370 * image.c (Fimagemagick_types): Doc fix.
7371
af008560
GM
7372 * image.c (imagemagick-render-type): Change it from a lisp object
7373 to an integer. Move the doc here from the lisp manual.
7374 Treat all values not equal to 0 the same.
7375
1449fa1d
CY
73762012-02-06 Chong Yidong <cyd@gnu.org>
7377
7378 * doc.c (store_function_docstring): Avoid applying docstring of
7379 alias to base function (Bug#2603).
7380
3723ec07
AS
73812012-02-04 Andreas Schwab <schwab@linux-m68k.org>
7382
7383 * .gdbinit (pp1, pv1): Remove redundant defines.
7384 (pr): Use pp.
7385
79c1cc1e
CY
73862012-02-04 Chong Yidong <cyd@gnu.org>
7387
7388 * nsterm.m: Declare a global (Bug#10694).
7389
d7f29f8e
EZ
73902012-02-04 Eli Zaretskii <eliz@gnu.org>
7391
cae07000
SM
7392 * w32.c (get_emacs_configuration_options):
7393 Include --enable-checking, if specified, in the return value.
d7f29f8e 7394
3b95a6f9
MR
73952012-02-04 Martin Rudalics <rudalics@gmx.at>
7396
7397 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
7398 after rounding frame sizes. (Bug#9723)
7399
d6fa96a6
EZ
74002012-02-04 Eli Zaretskii <eliz@gnu.org>
7401
7402 * keyboard.c (adjust_point_for_property): Don't position point
7403 before BEGV. (Bug#10696)
7404
df0b2940
PE
74052012-02-03 Paul Eggert <eggert@cs.ucla.edu>
7406
7407 Handle overflow when computing char display width (Bug#9496).
7408 * character.c (char_width): Return EMACS_INT, not int.
7409 (char_width, c_string_width): Check for overflow when
7410 computing the width; this is possible now that individual
7411 characters can have unbounded width. Problem introduced
7412 by merge from Emacs 23 on 2012-01-19.
7413
6bee44d6
MA
74142012-02-02 Michael Albinus <michael.albinus@gmx.de>
7415
7416 * dbusbind.c (Fdbus_register_method): Mention the return value
7417 :ignore in the docstring.
7418
44f92739
GM
74192012-02-02 Glenn Morris <rgm@gnu.org>
7420
1b9f60cc
GM
7421 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
7422
44f92739
GM
7423 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7424 Unconditionally set to t. (Bug#10673)
7425 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7426 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
7427 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
7428
c5d3843c
KH
74292012-02-02 Kenichi Handa <handa@m17n.org>
7430
7431 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
7432 0, do not call append_composite_glyph.
7433
159462d4 74342012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
7435
7436 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
7437 NULL (Bug#6988).
7438 (x_produce_glyphs): If the component of a composition is a null
7439 string, set it->pixel_width to 1 to avoid zero-width glyph.
7440
78cef877
EZ
74412012-02-01 Eli Zaretskii <eliz@gnu.org>
7442
7443 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
7444 first 2 arguments are identical. This makes inserting large
7445 output from a subprocess an order of magnitude faster on
7446 MS-Windows, where all sbrk'ed memory is always contiguous.
7447
97897668
GM
74482012-01-31 Glenn Morris <rgm@gnu.org>
7449
7450 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 7451 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
7452 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
7453
31fd3586
GM
74542012-01-29 Glenn Morris <rgm@gnu.org>
7455
7456 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
7457
0e24a8b2
CY
74582012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
7459
7460 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
7461
cc0adcb0
CY
74622012-01-28 Chong Yidong <cyd@gnu.org>
7463
7464 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
7465
acc28cb9
CY
74662012-01-26 Chong Yidong <cyd@gnu.org>
7467
9c69cfb7
CY
7468 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
7469
acc28cb9
CY
7470 * search.c (Fsearch_forward, Fsearch_backward): Document negative
7471 repeat counts (Bug#10507).
7472
48da7392
GM
74732012-01-26 Glenn Morris <rgm@gnu.org>
7474
7475 * lread.c (syms_of_lread): Doc fix.
7476
14af5f7f
CY
74772012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
7478
7479 * coding.c (encode_designation_at_bol): Change return value to
7480 EMACS_INT.
7481
0b21c100
CY
74822012-01-25 Chong Yidong <cyd@gnu.org>
7483
7484 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
7485
3c2907f7
CY
74862012-01-21 Chong Yidong <cyd@gnu.org>
7487
7488 * floatfns.c (Fcopysign): Make the second argument non-optional,
7489 since nil is not allowed anyway.
7490
959ad23f
AS
74912012-01-21 Andreas Schwab <schwab@linux-m68k.org>
7492
7493 * process.c (read_process_output): Use p instead of XPROCESS (proc).
7494 (send_process): Likewise.
7495
34a02f46
MR
74962012-01-19 Martin Rudalics <rudalics@gmx.at>
7497
7498 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
7499 (Vwindow_persistent_parameters): Do not use Qstate.
7500 Rewrite doc-strings.
34a02f46 7501
1259009a 75022012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
7503
7504 * character.c (char_width): New function.
70d4fdf6
GM
7505 (Fchar_width, c_string_width, lisp_string_width):
7506 Use char_width (Bug#9496).
25ed9e61 7507
6a6ee00d
MR
75082012-01-16 Martin Rudalics <rudalics@gmx.at>
7509
7510 * window.c (Vwindow_persistent_parameters): New variable.
7511 (Fset_window_configuration, save_window_save): Handle persistent
7512 window parameters.
7513
c85efaf7
EZ
75142012-01-14 Eli Zaretskii <eliz@gnu.org>
7515
7516 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
7517 thrashing the stack of the thread. (Bug#9087)
7518
5944709e
PE
75192012-01-12 Paul Eggert <eggert@cs.ucla.edu>
7520
7521 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
7522
e71f5d99
EZ
75232012-01-11 Eli Zaretskii <eliz@gnu.org>
7524
7525 * xdisp.c (rows_from_pos_range): Handle the case where the
7526 highlight ends on a newline. (Bug#10464)
7527 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
7528 he end column for display of highlight that ends on a newline
7529 before a R2L line.
7530
ce316182
GM
75312012-01-11 Glenn Morris <rgm@gnu.org>
7532
7533 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
7534 from load-path also when installation-directory is nil. (Bug#10208)
7535
5b43da69
GM
75362012-01-10 Glenn Morris <rgm@gnu.org>
7537
74cc8ff9
GM
7538 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
7539
7d8d6e4e
GM
7540 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
7541 Update template values to be closer to their typical values these days.
5b43da69 7542
a0db8d43
EZ
75432012-01-09 Eli Zaretskii <eliz@gnu.org>
7544
7545 * xdisp.c (rows_from_pos_range): Accept additional argument
7546 DISP_STRING, and accept any glyph in a row whose object is that
7547 string as eligible for mouse highlight. Fixes mouse highlight of
7548 display strings from overlays. (Bug#10464)
7549
9a0115ab 75502012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 7551
b9110d6a 7552 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
7553 * fileio.c (auto_saving_dir_umask): New static var.
7554 (Fmake_directory_internal): Use it.
7555 (do_auto_save_make_dir): Set it, instead of invoking chmod after
7556 creating the directory. The old code temporarily assigns
7557 too-generous permissions to the directory.
7558 (do_auto_save_eh): Clear it.
b9110d6a 7559 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
7560 that the var is always cleared.
7561
6c1bd3f3
EZ
75622012-01-07 Eli Zaretskii <eliz@gnu.org>
7563
7564 * search.c (scan_buffer): Pass character positions to
7565 know_region_cache, not byte positions. (Bug#6540)
7566
069d2b50
L
75672012-01-07 LynX <_LynX@bk.ru> (tiny change)
7568
7569 * w32.c (sys_rename): Report EXDEV when rename of a directory
7570 fails because the target is on another logical disk. (Bug#10284)
7571
75bf0d33
DB
75722012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
7573
7574 * xterm.c (x_embed_request_focus): New function.
7575
7576 * xterm.h: Add prototype.
7577
7578 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
7579
1c6e5a32
GM
75802012-01-05 Glenn Morris <rgm@gnu.org>
7581
7582 * emacs.c (emacs_copyright): Update short copyright year to 2012.
7583
651e947e
EZ
75842012-01-01 Eli Zaretskii <eliz@gnu.org>
7585
7586 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
7587 Load gnutls_transport_set_lowat only if GnuTLS version is below
7588 2.11.1.
7589 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
7590 GnuTLS versions below 2.11.1.
7591
3778cdd8
AL
75922011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
7593
7594 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
7595 to the doc string advising against its use for altering the way
7596 windows are scrolled.
7597
0e5317f7
KH
75982011-12-28 Kenichi Handa <handa@m17n.org>
7599
7600 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
7601 coding-system ASCII compatible only when it does not produce BOM
7602 on encoding (Bug#10383).
7603
93d5ca1f
JD
76042011-12-26 Jan Djärv <jan.h.d@swipnet.se>
7605
7606 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
7607 can scroll.
7608 (create_and_show_popup_menu): Always use menu_position_func for
7609 Gtk3 (Bug#10361).
7610
ca22b785
AS
76112011-12-24 Andreas Schwab <schwab@linux-m68k.org>
7612
7613 * callint.c (Fcall_interactively): Don't truncate prompt string.
7614
d048e1e6
EZ
76152011-12-23 Eli Zaretskii <eliz@gnu.org>
7616
7617 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
7618 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 7619 resumed from there (after widening). (Bug#10360)
d048e1e6 7620
5ccaba1f
JD
76212011-12-22 Jan Djärv <jan.h.d@swipnet.se>
7622
7623 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
7624
204ee57f
JD
76252011-12-21 Jan Djärv <jan.h.d@swipnet.se>
7626
b81d40f0
JB
7627 * nsterm.m (x_free_frame_resources):
7628 Release f->output_data.ns->miniimage.
204ee57f
JD
7629 (ns_index_color): Fix indentation. Do not retain
7630 color_table->colors[i].
7631
7632 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
7633 before returning.
7634
7635 * nsfns.m (x_set_background_color): Assign return value from
7636 ns_index_color to face-background instead of NSColor*.
7637 (ns_implicitly_set_icon_type): Fix indentation.
7638 Change assignment in for loop to comparison.
7639
7640 * emacs.c (ns_pool): New variable.
7641 (main): Assign ns_pool.
7642 (Fkill_emacs): Call ns_release_autorelease_pool.
7643
7644 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
7645 autorelease fdesc, release fdAttrs and tdict.
7646 (ns_get_covering_families): Release charset.
7647 (ns_findfonts): Release NSFontDescriptor created with new.
7648 (ns_uni_to_glyphs): Fix indentation.
7649 (setString): Release attrStr before assigning new value.
7650
c803b2b7
JD
76512011-12-18 Jan Djärv <jan.h.d@swipnet.se>
7652
678f4426
JD
7653 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
7654 and NS_IMPL_COCOA.
7655 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
7656 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
7657
cd394be1 76582011-12-18 David Reitter <reitter@cmu.edu>
678f4426 7659
5fecd5fc
JD
7660 * nsterm.m (ns_term_init): Subscribe for notifications
7661 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
7662 to method trackingNotification in EmacsMenu.
7663
7664 * nsmenu.m (trackingMenu): New variable.
3771cb17 7665 (trackingNotification): New method (from Aquamacs).
5fecd5fc 7666 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 7667 from Aquamacs (Bug#7030).
678f4426
JD
7668
76692011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 7670
c803b2b7
JD
7671 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
7672 (symbol_to_nsstring): Fix indentation.
7673 (ns_symbol_to_pb): New function.
cae07000
SM
7674 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
7675 (Fns_rotate_cut_buffers_internal): Remove.
7676 (Fns_store_selection_internal): Rename from
c803b2b7
JD
7677 Fns_store_cut_buffer_internal.
7678 (ns_get_foreign_selection, Fx_own_selection_internal)
7679 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
7680 (Fns_get_selection_internal, Fns_store_selection_internal):
7681 Use ns_symbol_to_pb and check if return value is nil.
7682 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
7683 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
7684 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
7685 renamed to Sns_store_selection_internal.
7686 (ns_handle_selection_request): Move code to Fx_own_selection_internal
7687 and remove this function.
7688 (ns_handle_selection_clear): Remove, never used.
7689 (Fx_own_selection_internal): Move code from ns_handle_selection_request
7690 here.
7691
e1b01a3a
KB
76922011-12-17 Ken Brown <kbrown@cornell.edu>
7693
7694 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
7695 GID is unknown (Bug#10257).
7696
2adb6e85
PE
76972011-12-17 Paul Eggert <eggert@cs.ucla.edu>
7698
7699 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
7700 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
7701 which caused a build failure on GNU/Linux IA-64. This problem was
7702 introduced by my 2011-10-07 patch.
7703
d1d7b339
JL
77042011-12-15 Juri Linkov <juri@jurta.org>
7705
7706 * image.c (imagemagick_error): New function. (Bug#10112)
7707 (imagemagick_load_image): Comment out `MagickSetResolution' call.
7708 Use `imagemagick_error' where ImageMagick functions return
7709 `MagickFalse'.
7710 (Fimagemagick_types): Add `Fnreverse' to return the list in the
7711 proper order.
7712
100d5755
KH
77132011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7714
7715 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
7716 fill background (Bug#8992).
7717
454592a6
MR
77182011-12-13 Martin Rudalics <rudalics@gmx.at>
7719
7720 * window.c (Vwindow_combination_resize)
7721 (Vwindow_combination_limit): Use t instead of non-nil in
7722 doc-strings.
61d4b438
MR
7723 (Vrecenter_redisplay): Add first sentence of doc-string on
7724 separate line.
53524d93 7725 (Frecenter): Fix doc-string typo.
454592a6 7726
3633e3aa
KH
77272011-12-11 Kenichi Handa <handa@m17n.org>
7728
7729 * coding.c (Funencodable_char_position): Pay attention to the
7730 buffer text relocation (Bug#9389).
7731
7b9d523a 77322011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 7733
7b9d523a
JD
7734 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
7735 gtk_init (Bug#10100).
7736
b73189c6
EZ
77372011-12-10 Eli Zaretskii <eliz@gnu.org>
7738
7739 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
7740 IT->string is nil. (Bug#10263)
7741
f7dfe5d6
JD
77422011-12-10 Jan Djärv <jan.h.d@swipnet.se>
7743
83faebb4
JD
7744 * nsterm.h (x_free_frame_resources): Declare.
7745
f7dfe5d6
JD
7746 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
7747 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
7748
7749 * nsterm.h (ns_get_defaults_value): Declare.
7750
7751 * nsterm.m (ns_default): Call ns_get_defaults_value.
7752
7cd4e72c
EZ
77532011-12-09 Eli Zaretskii <eliz@gnu.org>
7754
7755 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
7756 (Bug#10170)
7757
b34d7317
YM
77582011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7759
7760 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
7761 that where the value of an _OBJC_* symbol points to is in the .bss
7762 section (Bug#10240).
7763
76470ad1
KH
77642011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7765
7766 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 7767 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 7768
745fff94
KH
77692011-12-08 Kenichi Handa <handa@m17n.org>
7770
7771 * ftfont.c (get_adstyle_property): Fix previous change
7772 (Bug#10233).
7773
6e44397c
JB
77742011-12-07 Juanma Barranquero <lekktu@gmail.com>
7775
7776 * w32.c (init_environment): If no_site_lisp, remove site-lisp
7777 dirs from the default value of EMACSLOADPATH (bug#10208).
7778
7efa6272
GM
77792011-12-07 Glenn Morris <rgm@gnu.org>
7780
7781 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
7782 installation and source directories as well. (Bug#10208)
7783
f6fc4d87
CY
77842011-12-06 Chong Yidong <cyd@gnu.org>
7785
7786 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
7787
2bf26180
GM
77882011-12-06 Glenn Morris <rgm@gnu.org>
7789
7790 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
7791 as an error, not just -1. (Bug#10217)
7792
3a6ad4f0
CY
77932011-12-05 Chong Yidong <cyd@gnu.org>
7794
7795 * keyboard.c (process_special_events): New function.
7796 (swallow_events, Finput_pending_p): Use it (Bug#10195).
7797
75a3b399
PE
77982011-12-05 Paul Eggert <eggert@cs.ucla.edu>
7799
7800 * coding.c (encode_designation_at_bol): Don't use uninitialized
7801 local variable (Bug#9318).
7802
c3c9e25e
KH
78032011-12-05 Kenichi Handa <handa@m17n.org>
7804
7805 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
7806 return Qnil (Bug#8046, Bug#10193).
7807
5eb05ea3
KH
78082011-12-05 Kenichi Handa <handa@m17n.org>
7809
7810 * coding.c (encode_designation_at_bol): New args charbuf_end and
7811 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
7812 (coding_set_source): Return how many bytes coding->source was
7813 relocated.
7814 (coding_set_destination): Return how many bytes
7815 coding->destination was relocated.
7816 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 7817 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
7818
78192011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7820
7821 * coding.c (CODING_CHAR_CHARSET_P): New macro.
7822 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
7823 macro (Bug#9318).
7824
78252011-12-05 Andreas Schwab <schwab@linux-m68k.org>
7826
7827 The following changes are to fix Bug#9318.
7828
a79703f5 7829 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
7830 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
7831 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 7832 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 7833
7dbda6df
JB
78342011-12-05 Juanma Barranquero <lekktu@gmail.com>
7835
7836 * lisp.h (process_quit_flag): Fix external declaration.
7837
6d5eb5b0
SM
78382011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
7839
7840 Don't macro-inline non-performance-critical code.
7841 * eval.c (process_quit_flag): New function.
7842 * lisp.h (QUIT): Use it.
7843
a0c3fad0
JD
78442011-12-04 Jan Djärv <jan.h.d@swipnet.se>
7845
7846 * nsfns.m (get_geometry_from_preferences): New function.
7847 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
7848
6c07aac2
AS
78492011-12-04 Andreas Schwab <schwab@linux-m68k.org>
7850
7851 * emacs.c (Qkill_emacs): Define.
7852 (syms_of_emacs): Initialize it.
7853 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
7854 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
7855 (quit_throw_to_read_char): Add parameter `from_signal'.
7856 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
7857 * lisp.h (QUIT): Call Fkill_emacs if requested.
7858
c052ead4
JD
78592011-12-03 Jan Djärv <jan.h.d@swipnet.se>
7860
7861 * widget.c (update_wm_hints): Return if wmshell is null.
7862 (widget_update_wm_size_hints): New function.
7863
7864 * widget.h (widget_update_wm_size_hints): Declare.
7865
7866 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
7867 widget_update_wm_size_hints (Bug#10104).
7868
9e49252b
EZ
78692011-12-03 Eli Zaretskii <eliz@gnu.org>
7870
7871 * xdisp.c (handle_invisible_prop): If the invisible text ends just
7872 before a newline, prepare the bidi iterator for consuming the
7873 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 7874 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 7875
02b16839
JL
78762011-12-02 Juri Linkov <juri@jurta.org>
7877
7878 * search.c (Fword_search_regexp): New Lisp function created from
7879 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
7880 (Fword_search_backward, Fword_search_forward)
7881 (Fword_search_backward_lax, Fword_search_forward_lax):
7882 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
7883 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
7884
0068070e
SM
78852011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
7886
7887 * fileio.c (Finsert_file_contents): Move after-change-function call
7888 to before the "handled:" label, since all "goto handled" appear in
7889 cases where the *-change-functions have already been properly called
7890 (bug#10117).
7891
3360a3fc
AS
78922011-12-01 Andreas Schwab <schwab@linux-m68k.org>
7893
7894 * keyboard.c (interrupt_signal): Don't call kill-emacs when
7895 waiting for input. (Bug#10169)
7896
73d6c093
EZ
78972011-11-30 Eli Zaretskii <eliz@gnu.org>
7898
7899 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
7900 verifies glyph row's hash code--we have just reallocated the
7901 glyphs, so their contents can be complete garbage. (Bug#10164)
7902
febe6bea
JB
79032011-11-30 Juanma Barranquero <lekktu@gmail.com>
7904
7905 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
7906
801a4313
EZ
79072011-11-30 Eli Zaretskii <eliz@gnu.org>
7908
7909 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
7910 attributes are tested _before_ calling verify_row_hash, to protect
7911 against GCC re-ordering of the tests. (Bug#10164)
7912
2b56b87e
JD
79132011-11-29 Jan Djärv <jan.h.d@swipnet.se>
7914
7915 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
7916
7917 * xterm.c (handle_one_xevent): Only set async_visible and friends
7918 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 7919 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
7920 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
7921
dbf31225
PE
79222011-11-28 Paul Eggert <eggert@cs.ucla.edu>
7923
7924 Remove GCPRO-related macros that exist only to avoid shadowing locals.
7925 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
7926 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
7927 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7928 All uses changed to use GCPRO1 etc.
7929 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
7930 Revert to old implementation (i.e., before 2011-03-11).
7931
1305621b
YM
79322011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7933
7934 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
7935 of scroll runs so as to avoid assigning disabled bogus rows and
7936 unnecessary graphics copy operations.
7937
8c9afb46
EZ
79382011-11-27 Eli Zaretskii <eliz@gnu.org>
7939
7940 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
7941 (snprintf) [_MSC_VER]: Redirect to _snprintf.
7942 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
7943 (malloc, free, realloc, calloc): Redirect to e_* only when
7944 compiling Emacs.
7945
7946 * lisp.h (GCTYPEBITS): Move before first use.
7947 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
7948 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
7949 this macro definition.
7950
7951 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
7952 _MSC_VER.
7953
54e9e3bf
JD
79542011-11-27 Jan Djärv <jan.h.d@swipnet.se>
7955
6d5eb5b0
SM
7956 * gtkutil.c (xg_create_frame_widgets):
7957 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
7958 present with Gtk+ 2.0.
7959
83aca1cb
PE
79602011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7961
7962 * fileio.c (Finsert_file_contents): Undo previous change; see
7963 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7964
5b76caa4
PE
79652011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7966
7967 Rename locals to avoid shadowing.
7968 * fileio.c (Finsert_file_contents):
7969 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
7970 * process.c (wait_reading_process_output):
7971 Rename inner 'proc' to 'p' to avoid shadowing.
7972 Indent for consistency with usual Emacs style.
7973
8c535114
EZ
79742011-11-25 Eli Zaretskii <eliz@gnu.org>
7975
7976 * xdisp.c (redisplay_window): If cursor row is not fully visible
7977 after recentering, and scroll-conservatively is set to a large
7978 number, scroll window by a few more lines to make the cursor fully
7979 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
7980 (start_display): Don't move to the next line if the display should
7981 start at a newline that is part of a display vector or an overlay
7982 string. (Bug#10119)
8c535114 7983
fa4fdb5c
JL
79842011-11-24 Juri Linkov <juri@jurta.org>
7985
7986 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
7987 after the `MagickPingImage' call. (Bug#10112)
7988
90ec88df
CY
79892011-11-23 Chong Yidong <cyd@gnu.org>
7990
7991 * window.c (Fcoordinates_in_window_p): Accept only live windows.
7992
56e2e794
MR
79932011-11-23 Martin Rudalics <rudalics@gmx.at>
7994
7995 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
7996 making another buffer current. (Bug#10114)
7997
b6e64c41
GM
79982011-11-23 Glenn Morris <rgm@gnu.org>
7999
8000 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
8001
6b21de18
CY
80022011-11-23 Chong Yidong <cyd@gnu.org>
8003
8004 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
8005 using it (Bug#5984).
8006
b12cd789
EZ
80072011-11-22 Eli Zaretskii <eliz@gnu.org>
8008
8009 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
8010 and header-lines, as they don't have one computed for them.
8011 (Bug#10098)
8012
8013 * .gdbinit (prow): Make displayed values more self-explaining.
8014 Add row's hash code.
8015
261b6fd4
LMI
80162011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
8017
8018 * process.c (wait_reading_process_output): Fix asynchrounous
8019 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 8020 (wait_reading_process_output): Add comment and URL.
261b6fd4 8021
e7cfd277
JD
80222011-11-21 Jan Djärv <jan.h.d@swipnet.se>
8023
8024 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
8025
a9b9b7f5
CY
80262011-11-21 Chong Yidong <cyd@gnu.org>
8027
8028 * window.c (Fnext_window, Fprevious_window): Doc fix.
8029
b0d15b4f
SM
80302011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8031
8032 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
8033
fe7a3057
JB
80342011-11-20 Juanma Barranquero <lekktu@gmail.com>
8035
8036 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
8037
d2999b1a
MR
80382011-11-20 Martin Rudalics <rudalics@gmx.at>
8039
8040 * window.c (Fset_window_combination_limit): Rename argument
8041 STATUS to LIMIT.
8042 (Vwindow_combination_limit): Remove "status" from doc-string.
8043
d5ff9cd0
AS
80442011-11-20 Andreas Schwab <schwab@linux-m68k.org>
8045
8046 * m/ibms390.h: Remove.
8047 * m/ibms390x.h: Don't include "ibms390.h".
8048
a5bb9bd3
SM
80492011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8050
8051 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
8052 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
8053
cd1181db
JB
80542011-11-20 Juanma Barranquero <lekktu@gmail.com>
8055
8056 * casetab.c (Fset_case_table):
8057 * charset.c (Fcharset_after): Fix typos.
8058
615a3b8d 80592011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 8060
17e845af
PE
8061 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
8062 Otherwise, valgrind does not work on some platforms.
8063 Problem reported by Andreas Schwab in
6a0bf43d
PE
8064 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
8065 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
8066 is set, removing the need for VIRT_ADDRESS_VARIES.
8067 (PURE_P): Use a more-efficient implementation that needs just one
8068 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
8069 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
8070 to 4 (xorl, subq, cmpq, setbe).
8071 * alloc.c (pure): Always extern now, since that's the
8072 VIRT_ADDR_VARIES behavior.
8073 (PURE_POINTER_P): Use a single comparison, not two, for
8074 consistency with the new puresize.h.
8075 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
8076 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
8077 Remove VIRT_ADDR_VARIES no longer needed.
8078
f8fe6f96
EZ
80792011-11-19 Eli Zaretskii <eliz@gnu.org>
8080
8081 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
8082 (erase_phys_cursor, update_window_cursor, show_mouse_face)
8083 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
8084 behave as if the cursor position were at the window margin.
8085
8086 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
8087 and the cursor position is out of bounds, behave as if the cursor
8088 position were at the window margin. (Bug#10075)
8089
df05a53c
CY
80902011-11-18 Chong Yidong <cyd@gnu.org>
8091
8092 * window.c (Fwindow_combination_limit): Make first argument
8093 non-optional, since it is meaningless for live windows like the
8094 selected window.
61ccba97 8095
2071918e
DA
80962011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
8097
8098 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
8099
b50a28de
SM
81002011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
8101
8102 * intervals.c: Fix grafting over the whole buffer (bug#10071).
8103 (graft_intervals_into_buffer): Simplify.
8104
015137db
EZ
81052011-11-18 Eli Zaretskii <eliz@gnu.org>
8106
8107 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
8108 hash values of the two rows.
8109 (copy_row_except_pointers): Preserve the used[] arrays and the
8110 hash values of the two rows. (Bug#10035)
68c95424 8111 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
8112
8113 * xdisp.c (row_hash): New function, body extracted from
8114 compute_line_metrics.
8115 (compute_line_metrics): Call row_hash, instead of computing the
8116 hash code inline.
8117
8118 * dispnew.c (verify_row_hash): Call row_hash for computing the
8119 hash code of a row, instead of duplicating code from xdisp.c.
8120
8121 * dispextern.h (row_hash): Add prototype.
8122
a2addb04
TH
81232011-11-18 Tassilo Horn <tassilo@member.fsf.org>
8124
8125 * frame.c (delete_frame): Don't delete the terminal when the last
8126 X frame is closed if emacs is built with GTK toolkit.
8127
df85d315
JB
81282011-11-17 Juanma Barranquero <lekktu@gmail.com>
8129
8130 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
8131
a0c2d0ae
MR
81322011-11-17 Martin Rudalics <rudalics@gmx.at>
8133
8134 * window.c (Vwindow_splits): Rename to
8135 Vwindow_combination_resize. Suggested by Juri Linkov.
8136 (Fsplit_window_internal): Use Vwindow_combination_resize instead
8137 of Vwindow_splits.
8138
58179cce
JB
81392011-11-16 Juanma Barranquero <lekktu@gmail.com>
8140
7877f373
JB
8141 * nsfns.m (Fns_font_name):
8142 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 8143
b6f67890
MR
81442011-11-16 Martin Rudalics <rudalics@gmx.at>
8145
8146 * window.h (window): Rename slot "nest" to "combination_limit".
8147 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
8148 (Fset_window_nest): Rename to Fset_window_combination_limit.
8149 (Vwindow_nest): Rename to Vwindow_combination_limit.
8150 (recombine_windows, make_parent_window, make_window)
8151 (Fsplit_window_internal, saved_window)
8152 (Fset_window_configuration, save_window_save): Rename all
8153 occurrences of window_nest to window_combination_limit.
8154
c7015153
JB
81552011-11-15 Juanma Barranquero <lekktu@gmail.com>
8156
8157 * image.c (imagemagick_load_image): Fix typo.
8158
322ad6ec
EZ
81592011-11-14 Eli Zaretskii <eliz@gnu.org>
8160
8161 * xdisp.c (display_line): Move the call to
8162 highlight_trailing_whitespace before the call to
8163 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
8164 faces of all the glyphs to compute ROW's hash value.
8165 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 8166
f067b8ec
JB
81672011-11-14 Juanma Barranquero <lekktu@gmail.com>
8168
8169 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
8170 just return (bug#10044).
8171
1e5b2111
EZ
81722011-11-12 Eli Zaretskii <eliz@gnu.org>
8173
7ef3cbd5
EZ
8174 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
8175 with user-defined heap size. Bump the default size of the temacs
8176 heap to 27MB, to avoid memory warning when running temacs.
8177 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
8178
1e5b2111
EZ
8179 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
8180 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
8181 (verify_row_hash) [XASSERTS]: New function.
8182 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
8183 that the hash value of glyph rows is correct.
1e5b2111 8184
89d61221
MR
81852011-11-12 Martin Rudalics <rudalics@gmx.at>
8186
8187 * window.h (window): Remove splits slot.
8188 * window.c (Fwindow_splits, Fset_window_splits): Remove.
8189 (Fdelete_other_windows_internal, make_parent_window)
8190 (make_window, Fsplit_window_internal, Fdelete_window_internal)
8191 (Fset_window_configuration, save_window_save): Don't deal with
8192 split status of windows.
8193 (saved_window): Remove splits slot.
8194 (Vwindow_splits): Rewrite doc-string.
8195
97f18cc8
JD
81962011-11-11 Jan Djärv <jan.h.d@swipnet.se>
8197
8198 * xfns.c (unwind_create_frame):
8199 * nsfns.m (unwind_create_frame):
8200 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
8201 Vframe_list (Bug#9999).
8202
22a648b4
DA
82032011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
8204
0b381c7e 8205 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 8206
659afede
KH
82072011-11-11 Kenichi Handa <handa@m17n.org>
8208
8209 * callproc.c (Fcall_process): Set the member dst_multibyte of
8210 process_coding.
8211
9ac0394b
KH
82122011-11-11 Johan Bockgård <bojohan@gnu.org>
8213
8214 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
8215 avoid a crash (bug#9496).
8216
2fbdc249
CY
82172011-11-09 Chong Yidong <cyd@gnu.org>
8218
8219 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
8220 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
8221
ac6b1f81
PE
82222011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8223
8224 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
8225
09db192c
PE
82262011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8227
8228 Avoid some portability problems by eschewing 'extern inline' functions.
8229 The trivial performance wins aren't worth the portability hassles; see
8230 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
8231 et seq.
8232 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8233 (window_box_width, window_box_left, window_box_left_offset)
8234 (window_box_right, window_box_right_offset): Undo previous change,
8235 by removing the "extern"s.
8236 * intervals.c (adjust_intervals_for_insertion)
8237 (adjust_intervals_for_deletion): Undo previous change,
8238 making these static again.
8239 (offset_intervals, temp_set_point_both, temp_set_point)
8240 (copy_intervals_to_string): No longer inline.
8241 * xdisp.c (window_text_bottom_y, window_box_width)
8242 (window_box_height, window_box_left_offset)
8243 (window_box_right_offset, window_box_left, window_box_right)
8244 (window_box): No longer inline.
8245
105216ed
CY
82462011-11-08 Chong Yidong <cyd@gnu.org>
8247
8248 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
8249 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
8250 Signal an error if not a live window.
105216ed
CY
8251 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
8252 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
8253
ae9e237f
JB
82542011-11-07 Juanma Barranquero <lekktu@gmail.com>
8255
8256 * lisp.h (syms_of_abbrev): Remove declaration.
8257 Reported by CHENG Gao <chenggao@royau.me>.
8258
c7aa8333
EZ
82592011-11-07 Eli Zaretskii <eliz@gnu.org>
8260
8261 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
8262 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
8263 of temacs in GUI mode.
8264
be7f5545
MR
82652011-11-07 Martin Rudalics <rudalics@gmx.at>
8266
8267 * window.h: Declare delete_all_child_windows instead of
8268 delete_all_subwindows.
8269 * window.c (Fwindow_nest, Fset_window_nest)
8270 (Fset_window_new_total, Fset_window_new_normal)
8271 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
8272 (delete_all_subwindows): Rename to delete_all_child_windows.
8273 (Fdelete_other_windows_internal, Fset_window_configuration):
8274 Call delete_all_child_windows instead of delete_all_subwindows.
8275 * frame.c (delete_frame): Call delete_all_child_windows instead
8276 of delete_all_subwindows.
8277
ca78dc43
PE
82782011-11-07 Paul Eggert <eggert@cs.ucla.edu>
8279
8280 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
8281 This is also needed for porting to any host where GC_MARK_STACK is
8282 not GC_MAKE_GCPROS_NOOPS.
8283 (which_symbols): Use it.
8284
a0241d01
KH
82852011-11-07 Kenichi Handa <handa@m17n.org>
8286
8287 * coding.c (coding_set_destination): Check coding->src_pos only
8288 when coding->src_object is a buffer (bug#9910).
8289
8290 * process.c (send_process): Set the member src_multibyte of coding
8291 to 0 (bug#9911) when sending a unibyte text.
8292
8293 * callproc.c (Fcall_process): Set the member src_multibyte of
8294 process_coding to 0 (bug#9912).
8295
a64bfdfa 82962011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
8297
8298 * xmenu.c (cleanup_widget_value_tree): New function.
8299 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
8300 calling free_menubar_widget_value_tree directly (Bug#9830).
8301
cb41b32a
PE
83022011-11-06 Paul Eggert <eggert@cs.ucla.edu>
8303
8304 Fix some portability problems with 'inline'.
8305 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8306 (window_box_width, window_box_left, window_box_left_offset)
8307 (window_box_right, window_box_right_offset): Declare extern.
8308 Otherwise, these inline functions do not conform to C99 and
8309 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
8310 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
8311 * intervals.c (adjust_intervals_for_insertion)
8312 (adjust_intervals_for_deletion): Now extern, because otherwise the
8313 extern inline functions 'offset_intervals' couldn't refer to it.
8314 (static_offset_intervals): Remove.
8315 (offset_intervals): Rewrite using the old contents of
8316 static_offset_intervals. The old version didn't conform to C99
8317 because an extern inline function contained a reference to an
8318 identifier with static linkage.
8319
b7041366
AS
83202011-11-06 Andreas Schwab <schwab@linux-m68k.org>
8321
8322 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
8323 GC.
8324
88a37c4d
EZ
83252011-11-06 Eli Zaretskii <eliz@gnu.org>
8326
8327 * xdisp.c (init_iterator, reseat_to_string): Don't set the
8328 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
8329 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
8330 return Qleft_to_right.
8331
49745b39
CY
83322011-11-06 Chong Yidong <cyd@gnu.org>
8333
8334 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
8335 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
8336 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
8337 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
8338 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
8339 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
8340 (Fwindow_vscroll): Doc fix.
8341 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
8342 argument, since it makes no sense to pass a live window and for
8343 consistency with window-child.
8344
1f05cd82
CS
83452011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
8346
8347 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
8348 support MSVC.
8349
22610910
JR
83502011-11-05 Jason Rumney <jasonr@gnu.org>
8351
8352 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
8353 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
8354 fonts (Bug#6029).
8355 (add_font_entity_to_list): Fix logic errors in mixed boolean and
8356 bitwise arithmetic preventing use of unicode-sip and non-truetype
8357 opentype fonts.
8358
a06776b2
EZ
83592011-11-05 Eli Zaretskii <eliz@gnu.org>
8360
3ad924ba
EZ
8361 * s/ms-w32.h (fstat, stat, utime): Move redirections to
8362 "emacs"-only part.
8363
a06776b2
EZ
8364 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
8365 initialization code to keep similarity to xfns.c after changes
8366 from 2011-11-05.
8367
c9e7db78
JD
83682011-11-05 Jan Djärv <jan.h.d@swipnet.se>
8369
a97f8f3f
JD
8370 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
8371 (unwind_create_frame): New function (Bug#9943).
8372 (Fx_create_frame): Restructure code to be more similar to the one in
8373 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
8374 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
8375 Move terminal->reference_count++ just before making the frame official
8376 (Bug#9943).
8377
8378 * nsterm.m (x_free_frame_resources): New function.
8379 (x_destroy_window): Move code to x_free_frame_resources.
8380
c9e7db78 8381 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
8382 (Fx_create_frame, x_create_tip_frame):
8383 Move terminal->reference_count++ just before making the frame
75f1671a 8384 official. Move initialization of image_cache_refcount and
c9e7db78
JD
8385 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
8386
a6fc3b5c
EZ
83872011-11-05 Eli Zaretskii <eliz@gnu.org>
8388
8389 Support MSVC build with newer versions of Visual Studio.
8390 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
8391 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
8392 nt/gmake.defs.
8393
8394 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
8395 which are not supported by MSVC.
8396 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
8397 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
8398 bitfields.
8399 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
8400 types in bitfields.
8401 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
8402
8403 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
8404
58179cce 84052011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
8406
8407 Support MSVC build with newer versions of Visual Studio.
8408 * w32.c: Don't include w32api.h for MSVC.
8409 (init_environment) [_MSC_VER]: Call sys_access, not _access.
8410
8411 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
8412 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
8413 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
8414 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
8415 e_* cousins.
8416 (alloca) [_MSC_VER]: Define to _alloca.
8417
8418 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
8419
8420 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
8421
a58c13ed
EZ
84222011-11-04 Eli Zaretskii <eliz@gnu.org>
8423
8424 * xdisp.c (note_mouse_highlight): If either of
8425 previous/next-single-property-change returns nil, treat that as
8426 the beginning or the end of the buffer. (Bug#9955)
8427
fe0b6370
JD
84282011-11-04 Jan Djärv <jan.h.d@swipnet.se>
8429
a58c13ed 8430 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
8431 label is not null (Bug#9951).
8432 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
8433 may be NULL.
8434
89bd5ee1
EZ
84352011-11-04 Eli Zaretskii <eliz@gnu.org>
8436
8437 * window.c (Fwindow_body_size): Mention in the doc string that the
8438 return value is in frame's canonical units. (Bug#9949)
8439
84c3edb9
EZ
84402011-11-03 Eli Zaretskii <eliz@gnu.org>
8441
4e2fb5c7
EZ
8442 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
8443
84c3edb9 8444 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 8445 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 8446 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 8447
bc17a887
EZ
84482011-11-01 Eli Zaretskii <eliz@gnu.org>
8449
8450 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
8451 Don't stop backward scan on the continuation glyph, even though
8452 its CHARPOS is positive.
6d5eb5b0
SM
8453 (mouse_face_from_buffer_pos, note_mouse_highlight):
8454 Rename cover_string to disp_string.
bc17a887 8455
4ee88440
MR
84562011-11-01 Martin Rudalics <rudalics@gmx.at>
8457
8458 * window.c (temp_output_buffer_show): Don't use
8459 Vtemp_buffer_show_specifiers.
8460 (Vtemp_buffer_show_specifiers): Remove unused variable.
8461
c2ff3c02
EZ
84622011-10-30 Eli Zaretskii <eliz@gnu.org>
8463
8464 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
8465 past the beginning of the current glyph matrix.
8466
58179cce 84672011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
8468
8469 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
8470 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
8471 HAVE_GTK3 (Bug#9869).
b77a6a7f 8472
3b574623
JD
8473 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
8474 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
8475
b77a6a7f
JD
8476 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
8477
8478 * xterm.c: Declare x_handle_net_wm_state to return int.
8479 (handle_one_xevent): Check if we are iconified but don't have
8480 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
8481 (get_current_wm_state): Return non-zero if not hidden,
8482 check for _NET_WM_STATE_HIDDEN (Bug#9893).
8483 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
8484 (x_handle_net_wm_state): Return what get_current_wm_state returns.
8485 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
8486
196e41e4
PE
84872011-10-29 Paul Eggert <eggert@cs.ucla.edu>
8488
8489 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
8490 so that this new function doesn't get optimized away by a
8491 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
8492
021f2e1a
AS
84932011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8494
8495 * frame.h (MOUSE_HL_INFO): Remove excess parens.
8496
8b058d44
EZ
84972011-10-29 Eli Zaretskii <eliz@gnu.org>
8498
8499 Fix the `xbytecode' command.
8500 * .gdbinit (xprintbytestr): New command.
b50a28de 8501 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
8502 (xbytecode): Print the byte-code string as well.
8503
4452fb80
EZ
85042011-10-29 Kim Storm <storm@cua.dk>
8505
8b058d44
EZ
8506 * alloc.c (which_symbols): New function.
8507
21b72067
AS
85082011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8509
8510 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
8511 line. (Bug#9903)
8512
83ed7b5c
GM
85132011-10-29 Glenn Morris <rgm@gnu.org>
8514
8515 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
8516 Not clear what it was for, and it causes various bugs. (Bug#9839)
8517
5a7a728b
EZ
85182011-10-28 Eli Zaretskii <eliz@gnu.org>
8519
8520 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
8521 possible random value that matches one of those tested as
8522 condition to clear the mouse face.
8523
d3d0842f
CY
85242011-10-28 Chong Yidong <cyd@gnu.org>
8525
8526 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
8527
31b39d13
DN
85282011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
8529
8530 * window.c (make_window): Initialize phys_cursor_on_p.
8531
9aba6043
SM
85322011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
8533
8534 * lisp.h (struct Lisp_Symbol): Update comments.
8535
c20992f4
JB
85362011-10-28 Juanma Barranquero <lekktu@gmail.com>
8537
8538 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
8539
db4f02f2
EZ
85402011-10-28 Eli Zaretskii <eliz@gnu.org>
8541
8542 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
8543 <oslsachem@gmail.com> for helping to debug this.
8544
8545 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
8546 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
8547 (g_b_init_get_glyph_outline_w): New static variables.
8548 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
8549 (GetGlyphOutlineW_Proc): New typedefs.
8550 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
8551 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
8552 New functions.
8553 (w32font_open_internal, compute_metrics):
8554 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
8555 instead of calling the "wide" APIs directly.
8556
8557 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
8558
8559 * w32.h (syms_of_w32font): Add prototype.
8560
87e68db4
JB
85612011-10-27 Juanma Barranquero <lekktu@gmail.com>
8562
8563 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
8564 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
8565 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
8566 (Fmove_to_window_line): Doc fix.
8567
435c1d67
CY
85682011-10-27 Chong Yidong <cyd@gnu.org>
8569
8570 * process.c (make_process): Set gnutls_state to NULL.
8571
8572 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
8573 non-NULL, regardless of GNUTLS_INITSTAGE.
8574 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
8575 an error. Set process slots as soon as we allocate them.
8576
8577 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
8578
9c6c6f49
CY
85792011-10-27 Chong Yidong <cyd@gnu.org>
8580
9aba6043
SM
8581 * gnutls.c (emacs_gnutls_deinit): New function.
8582 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
8583 (Fgnutls_deinit, Fgnutls_boot): Use it.
8584
8585 * process.c (make_process): Initialize GnuTLS credentials to NULL.
8586 (deactivate_process): Call emacs_gnutls_deinit.
8587
657d08d3
JB
85882011-10-27 Juanma Barranquero <lekktu@gmail.com>
8589
8590 * image.c (x_create_x_image_and_pixmap):
8591 * w32.c (sys_rename, w32_delayed_load):
8592 * w32font.c (fill_in_logfont):
8593 * w32reg.c (x_get_string_resource): Silence compiler warnings.
8594
5430d399
JB
85952011-10-26 Juanma Barranquero <lekktu@gmail.com>
8596
8597 * w32fns.c (w32_default_color_map): New function,
8598 extracted from Fw32_default_color_map.
a7ef684b 8599 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 8600
fe0055fa
PE
86012011-10-25 Paul Eggert <eggert@cs.ucla.edu>
8602
8603 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
8604
e6346438
SM
86052011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
8606
8607 * keyboard.c (test_undefined): New function (bug#9751).
8608 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
8609
e112cc37
ET
86102011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
8611
8612 * sysdep.c (init_sys_modes): Fix the check for the controlling
8613 terminal (Bug#6649).
8614
7b5d6677
EZ
86152011-10-20 Eli Zaretskii <eliz@gnu.org>
8616
8617 * dispextern.h (struct bidi_it): New member next_en_type.
8618
8619 * bidi.c (bidi_line_init): Initialize the next_en_type member.
8620 (bidi_resolve_explicit_1): When next_en_pos is valid for the
8621 current character, check also for next_en_type being WEAK_EN.
8622 (bidi_resolve_weak): Don't enter the expensive loop if the current
8623 position is before next_en_pos. Record the bidi type of the first
8624 non-ET, non-BN character we find, in addition to its position.
8625 (bidi_level_of_next_char): Invalidate next_en_type when
8626 next_en_pos is over-stepped.
8627
7da0b018
PE
86282011-10-20 Paul Eggert <eggert@cs.ucla.edu>
8629
8630 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
8631 * editfns.c: Rewrite current-time-zone so that it invokes
8632 the equivalent of (format-time-string "%Z") to get the time zone name.
8633 This fixes a bug when the time zone name contains characters that
8634 need converting from the system time locale to Emacs internal format.
8635 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
8636 that patch fixed format-time-string to do the conversion, but
8637 I forgot to fix current-time-zone.
8638 (format_time_string): New function, containing most of
8639 what Fformat_time_string used to contain.
8640 (Fformat_time_string): Rewrite in terms of format_time_string.
8641 This doesn't change this function's behavior.
8642 (current-time-zone): Rewrite to use format_time_string.
8643 This fixes the bug reported by Michael Schierl in
8644 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
8645 Jason Rumney's 2007-06-07 change worked around this bug, but
8646 didn't fix it.
8647 * systime.h (tzname, timezone): Remove no-longer-used declarations.
8648
8547b010
EZ
86492011-10-19 Eli Zaretskii <eliz@gnu.org>
8650
8651 * xdisp.c (start_display): If the character at POS is displayed
8652 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
8653 (try_window_reusing_current_matrix): If a line ends in a display
8654 vector or the next line starts in a display vector, continue
8655 redrawing the window even though the character position of
8656 start_row was reached.
8547b010
EZ
8657 (Bug#9771, part 2)
8658
4e948d15
CY
86592011-10-18 Chong Yidong <cyd@gnu.org>
8660
8661 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
8662 with nobreak-char-display too.
8663
4787455f
EZ
86642011-10-18 Eli Zaretskii <eliz@gnu.org>
8665
8666 Fix part 3 of bug#9771.
8667 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
8668 (bidi_resolve_neutral): Don't enter the expensive loop looking for
8669 non-neutral characters if the current character is a paragraph
8670 separator (a.k.a. Newline). This avoids running the same
8671 expensive loop twice, once when we consume the preceding newline
8672 and the other time when the line actually needs to be displayed.
8673 Avoid the loop when we see neutrals on the base embedding level
8674 following a character whose directionality is the same as the
8675 paragraph's. This avoids running the expensive loop when a line
8676 ends in a long sequence of neutrals, like control characters.
8677 Add assertion against STRONG_AL type. Slightly rearrange code
8678 that determines the type of a neutral given the first non-neutral
8679 that follows it.
8680 (bidi_level_of_next_char): Set next_en_pos to zero when
8681 invalidating its info.
8682
2c91f553
EZ
86832011-10-17 Eli Zaretskii <eliz@gnu.org>
8684
8685 * xdisp.c (push_display_prop): Determine whether to record string
8686 or buffer position by IT->string, not by IT->method. Allow
8687 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
8688 (move_it_vertically_backward): Don't look for character position
8689 immediately after the newline when in a continuation line.
8690 (Bug#9771, part 1)
2c91f553 8691
c7b08b0d
MR
86922011-10-15 Martin Rudalics <rudalics@gmx.at>
8693
8694 * window.c (coordinates_in_window): Rewrite and delabelize
8695 vertical border check. (Bug#5357) (Bug#9618)
8696
6b02f655
SM
86972011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
8698
8699 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
8700 errors in XSetWindowBorder (bug#9310).
8701
81d40c92
DA
87022011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
8703
8704 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
8705 avoid crash when xmalloc overrun checking is enabled.
8706
d4172c3b
EZ
87072011-10-13 Eli Zaretskii <eliz@gnu.org>
8708
8709 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
8710 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
8711 cursor motion with <left> and <right> arrow keys.
8712
8713 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
8714 some callers set that themselves.
8715
b00eea75
EZ
87162011-10-12 Eli Zaretskii <eliz@gnu.org>
8717
8718 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
8719 display string and the previous row comes from the same string and
8720 is empty. (Bug#9739) (Bug#9738)
8721
8fe012c4
SM
87222011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
8723
8724 * doc.c (get_doc_string): Encode file name (bug#9735).
8725
0074aef2
EZ
87262011-10-12 Eli Zaretskii <eliz@gnu.org>
8727
79beb178
EZ
8728 * bidi.c (bidi_level_of_next_char):
8729 * xdisp.c (get_visually_first_element): Remove old incorrect
8730 comments regarding the Unicode Line Separator character.
8731
0074aef2
EZ
8732 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
8733
6e4b3fbe
DA
87342011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
8735
8736 * alloc.c (Fgc_status): Do not access beyond zombies array
8737 boundary if nzombies > MAX_ZOMBIES.
8738 * alloc.c (dump_zombies): Add missing format specifier.
8739
0324f3af
PE
87402011-10-12 Paul Eggert <eggert@cs.ucla.edu>
8741
b5525cac
PE
8742 * xdisp.c (set_cursor_from_row): Simplify conditionals,
8743 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
8744
0324f3af
PE
8745 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
8746 Some packages use them to denote characters with modifiers.
8747
e9b5f888
AS
87482011-10-11 Andreas Schwab <schwab@linux-m68k.org>
8749
8750 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
8751 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
8752 matching a pp-number. Rename parameter var to var1.
8753
127827c0
SM
87542011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
8755
8756 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
8757
c8fd3bd0
GM
87582011-10-08 Glenn Morris <rgm@gnu.org>
8759
8760 * callint.c (Fcall_interactively): Give a more explicit error for the
8761 'c' case with a non-character input. (Bug#8479)
8762
352ec8ff
EZ
87632011-10-08 Eli Zaretskii <eliz@gnu.org>
8764
03669ccb
EZ
8765 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
8766 lines.
7061c986
EZ
8767 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
8768 lines that are hscrolled on the left.
03669ccb 8769
352ec8ff
EZ
8770 * dispnew.c (buffer_posn_from_coords): Account for a possible
8771 presence of header-line. (Bug#4426)
8772
a66cfb1c
SM
87732011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
8774
6b02f655
SM
8775 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
8776 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 8777
7c5ee88e
PE
87782011-10-07 Paul Eggert <eggert@cs.ucla.edu>
8779
8780 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
8781 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
8782 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
8783 this makes Emacs dump core during garbage collection on rare
8784 occasions. sizeof is obviously inferior to offsetof here, so
8785 stick with offsetof.
8786 (GC_POINTER_ALIGNMENT): New macro.
8787 (mark_memory): Omit 3rd (offset) arg; caller changed.
8788 Don't assume EMACS_INT alignment is the same as pointer alignment.
8789
df1bbe5b
SM
87902011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
8791
8792 * keyboard.c (read_key_sequence_remapped): New var.
8793 (read_key_sequence): Compute remapping in the right buffer.
8794 (command_loop_1): Use read_key_sequence's remapping directly.
8795
51553db6
SM
87962011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
8797
32c1fffd
SM
8798 * dired.c (file_name_completion): Don't expand file name.
8799 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
8800 before checking file name handler.
8801
51553db6
SM
8802 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
8803 they've been requested explicitly (bug#9591).
8804
b6bd1599 88052011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
8806
8807 * keymap.c (Fsingle_key_description): Use make_specified_string
8808 instead of build_string to build string from push_key_description.
8809 (Bug#5193)
8810
f701dc2a
PE
88112011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8812
4222c55d
PE
8813 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
8814 This fixes a Y2038 bug on 64-bit hosts.
8815 * buffer.c (reset_buffer):
8816 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
8817 (Fclear_buffer_auto_save_failure):
8818 Use 0, not -1, to represent an unset failure time, since time_t
8819 might not be signed.
8820
f701dc2a
PE
8821 Remove dependency on glibc malloc internals.
8822 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8823 Move back here from lisp.h, but with their new implementations.
8824 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8825 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
8826 * charset.c (charset_table_init): New static var.
8827 (syms_of_charset): Use it instead of xmalloc. This removes a
8828 dependency on glibc malloc internals. See Eli Zaretskii's comment in
8829 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
8830 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8831 Move back to alloc.c.
8832 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8833 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
8834
9ceebf39
JD
88352011-09-30 Jan Djärv <jan.h.d@swipnet.se>
8836
8837 * nsterm.m (windowDidResize): Call x_set_window_size only when
8838 ns_in_resize is true. Otherwise set pixelwidth/height and
8839 call change_frame_size (Bug#9628).
8840
cb993c58
PE
88412011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8842
3930c88b
PE
8843 Port --enable-checking=all to Fedora 14 x86-64.
8844 * charset.c (syms_of_charset): Also account for glibc malloc's
8845 internal overhead when calculating the initial malloc maximum.
8846
cb993c58
PE
8847 Port --enable-checking=all to Fedora 14 x86.
8848 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8849 Move to lisp.h.
8850 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
8851 (overrun_check_realloc, overrun_check_free):
8852 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
8853 That way, xmalloc returns a properly-aligned pointer even if
8854 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
8855 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
8856 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
8857 into account when calculating the initial malloc maximum.
8858 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8859 Move here from alloc.c, so that charset.c can use it too.
8860 Properly align; the old code wasn't right for common 32-bit hosts
8861 when configured with --enable-checking=all.
8862 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8863 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
8864
31bed486
EZ
88652011-09-29 Eli Zaretskii <eliz@gnu.org>
8866
04c70788 8867 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
8868 use EDOM.
8869
fbcaa2f3
EZ
88702011-09-28 Eli Zaretskii <eliz@gnu.org>
8871
8872 * xdisp.c (compute_display_string_end): If there's no display
8873 string at CHARPOS, return -1.
8874
8875 * bidi.c (bidi_fetch_char): When compute_display_string_end
8876 returns a negative value, treat the character as a normal
8877 character not covered by a display string. (Bug#9624)
8878
a239d4e9
JB
88792011-09-28 Juanma Barranquero <lekktu@gmail.com>
8880
8881 * lread.c (Fread_from_string): Fix typo in docstring.
8882
88652fd5
EZ
88832011-09-27 Eli Zaretskii <eliz@gnu.org>
8884
8885 * xdisp.c (handle_invisible_prop): If invisible text ends on a
8886 newline, reseat the iterator instead of bidi-iterating there one
8887 character at a time. (Bug#9610)
32c1fffd
SM
8888 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
8889 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 8890
ed497dd4
AS
88912011-09-27 Andreas Schwab <schwab@linux-m68k.org>
8892
8893 * lread.c (readevalloop): Use correct code for NBSP.
8894 (read1): Likewise. (Bug#9608)
8895
b2bf61aa
MA
88962011-09-25 Michael Albinus <michael.albinus@gmx.de>
8897
8898 * dbusbind.c (Fdbus_register_signal): When service is not
8899 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
8900
32bbb17c
GM
89012011-09-25 Glenn Morris <rgm@gnu.org>
8902
8903 * buffer.c (truncate-lines): Doc fix.
8904
94e0933e
CY
89052011-09-24 Chong Yidong <cyd@stupidchicken.com>
8906
8907 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
8908 (Fset_window_next_buffers): Doc fix.
8909
cddde921
GM
89102011-09-24 Glenn Morris <rgm@gnu.org>
8911
8912 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
8913
1260aef1
PE
89142011-09-24 Paul Eggert <eggert@cs.ucla.edu>
8915
25b4bfa0
PE
8916 Fix minor problems found by static checking.
8917 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
8918 * indent.c (Fvertical_motion): Fix == vs = typo.
8919
e3cbd34b
EZ
89202011-09-24 Eli Zaretskii <eliz@gnu.org>
8921
a66cfb1c
SM
8922 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
8923 Default value is now t. Doc fix.
6bf7006f 8924
e3cbd34b 8925 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 8926 logic when moving up, not only when moving down. Fix the
e3cbd34b 8927 confusing name and values of the it_overshoot_expected variable;
32c1fffd 8928 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
8929
8930 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
8931 CHARPOS is covered by a display string which includes newlines.
8932 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
8933 is covered by a display string with embedded newlines.
8934
a3de0cbd
MA
89352011-09-24 Michael Albinus <michael.albinus@gmx.de>
8936
8937 * dbusbind.c (Fdbus_register_signal): Add match rule to
8938 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
8939 (Fdbus_register_method, Vdbus_registered_objects_table):
8940 Fix docstring.
a3de0cbd 8941
b260039d
JM
89422011-09-24 Jim Meyering <meyering@redhat.com>
8943
32c1fffd 8944 do not ignore write error for any output size
b260039d
JM
8945 The previous change was incomplete.
8946 While it makes emacs --batch detect the vast majority of stdout
8947 write failures, errors were still ignored whenever the output size is
8948 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
8949 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
8950 && echo FAIL: ignored write error
8951 FAIL: ignored write error
8952 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
8953 && echo FAIL: ignored write error
8954 FAIL: ignored write error
8955 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
8956
8eca8a7c
AS
89572011-09-23 Andreas Schwab <schwab@linux-m68k.org>
8958
8959 * emacs.c (Fkill_emacs): In noninteractive mode exit
8960 non-successfully if a write error occurred on stdout. (Bug#9574)
8961
3341db62
EZ
89622011-09-21 Eli Zaretskii <eliz@gnu.org>
8963
8964 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
8965 the xassert test.
8966
8967 * dispextern.h (struct it): Update the comment documenting what
8968 can it->OBJECT be.
8969
8c203dbf
EZ
89702011-09-20 Eli Zaretskii <eliz@gnu.org>
8971
8972 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
8973 a display string, extend search for cursor position to end of row.
8974 (find_row_edges): If the row ends in a newline from a display
8975 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
8976 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
8977 (Fcurrent_bidi_paragraph_direction): Fix search for previous
8978 non-empty line. Fixes confusing cursor motion with arrow keys at
8979 the beginning of a line that starts with whitespace.
8c203dbf 8980
a4824228
LMI
89812011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8982
8983 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
8984 (bug#9493).
8985
33ed493b
CY
89862011-09-18 Chong Yidong <cyd@stupidchicken.com>
8987
8988 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
8989 boolean (Bug#9154).
8990
56cd55c8
EZ
89912011-09-18 Eli Zaretskii <eliz@gnu.org>
8992
8993 * xdisp.c (display_line): Record maximum and minimum buffer
8994 positions even if no glyphs were produced (e.g., by a zero-width
8995 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
8996 buffer positions that will be removed from the glyph row because
8997 they don't fit.
c02dcedf
EZ
8998 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
8999 column is beyond frame width: don't subtract 1 "pixel" when
9000 computing width of the stretch.
3e62b7e0
EZ
9001 (reseat_at_next_visible_line_start): Undo the change made on
9002 2011-09-17 that saved paragraph information and restored it after
9003 the call to `reseat'. (Bug#9545)
56cd55c8 9004
5ed99d36 90052011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
9006
9007 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
9008 and turn window cursor on if cleared (Bug#9415).
9009
5ed99d36 90102011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
9011
9012 * search.c (boyer_moore): Take unibyte characters from pattern
9013 literally. (Bug#9458)
9014
9bade7b2
EZ
90152011-09-18 Eli Zaretskii <eliz@gnu.org>
9016
9017 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
9018
e5e9d610
PE
90192011-09-18 Paul Eggert <eggert@cs.ucla.edu>
9020
87e4427a
PE
9021 Fix minor problem found by static checking.
9022 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
9023 initialized, to pacify gcc -Wuninitialized.
9024
e5e9d610
PE
9025 * fileio.c: Report proper errno when syscall falls.
9026 (Finsert_file_contents): Save and restore errno,
9027 so that report_file_error outputs the correct diagnostic.
9028 (Fwrite_region) [CLASH_DETECTION]: Likewise.
9029
a1674f0b
EZ
90302011-09-18 Eli Zaretskii <eliz@gnu.org>
9031
9032 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
9033
fbfb6dd4
EZ
90342011-09-17 Eli Zaretskii <eliz@gnu.org>
9035
9036 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
9037 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
9038
bb187662
EZ
90392011-09-17 Eli Zaretskii <eliz@gnu.org>
9040
1137e8b8 9041 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 9042 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
9043
9044 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
9045 (bidi_find_paragraph_start): Search back for paragraph beginning
9046 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
9047 (bidi_move_to_visually_next): Only trigger paragraph-related
9048 computations when the last character is a newline or at EOB, not
9049 just any NEUTRAL_B. (Bug#9470)
9050
bb187662
EZ
9051 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
9052 truncated lines if point is covered by a display string. (Bug#9524)
9053
2e621251
PE
90542011-09-16 Paul Eggert <eggert@cs.ucla.edu>
9055
9056 * xselect.c: Relax test for outgoing X longs (Bug#9498).
9057 (cons_to_x_long): New function.
9058 (lisp_data_to_selection_data): Use it. Correct the test for
9059 short-versus-long data; it was negated. Break out of vector
9060 loop, for efficiency, when a long datum is discovered.
9061
91a15bc6
SM
90622011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
9063
9064 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
9065
b41c3a35
EZ
90662011-09-16 Eli Zaretskii <eliz@gnu.org>
9067
9068 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
9069 GCC PR/17406) by declaring this function with external scope.
9070
7812ba2d
PE
90712011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9072
9073 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
9074 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
9075
cf7edc2a
AS
90762011-09-15 Andreas Schwab <schwab@linux-m68k.org>
9077
9078 * editfns.c (Fformat): Correctly handle text properties on "%%".
9079
bd01620e
EZ
90802011-09-15 Eli Zaretskii <eliz@gnu.org>
9081
9082 * xterm.c (x_draw_composite_glyph_string_foreground):
9083 * w32term.c (x_draw_composite_glyph_string_foreground):
9084 * term.c (encode_terminal_code):
9085 * composite.c (composition_update_it, get_composition_id):
9086 * xdisp.c (get_next_display_element)
9087 (fill_composite_glyph_string): Add comments about special meaning
9088 of TAB characters in a composition.
9089
a02719a3
PE
90902011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9091
9092 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
9093 This occurs when processing a multibyte format.
9094 Problem reported by Wolfgang Jenker.
a02719a3 9095
72589a3c
JB
90962011-09-15 Johan Bockgård <bojohan@gnu.org>
9097
9098 * xdisp.c (try_cursor_movement): Only check for exact match if
9099 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
9100
1c14176c
PE
91012011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9102
9103 Remove unused external symbols.
9104 * dispextern.h (calc_pixel_width_or_height): Remove decl.
9105 * xdisp.c (calc_pixel_width_or_height): Now static.
9106 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
9107 * indent.c (check_display_width):
9108 * w32term.c: Fix comment to match code.
9109 * xterm.c, xterm.h (x_catching_errors): Remove.
9110
d2eea5b5
PE
91112011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9112
9113 * xselect.c: Use signed conversions more consistently (Bug#9498).
9114 (selection_data_to_lisp_data): Assume incoming selection data are
9115 signed integers, not unsigned. This is to be consistent with
9116 outgoing selection data, which was modified to use signed integers
9117 in as part of the fix to Bug#9196 in response to Jan D.'s comment
9118 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
9119 expects long, not unsigned long.
9120
46888499
EZ
91212011-09-14 Eli Zaretskii <eliz@gnu.org>
9122
9123 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
9124 computation of loop end. Reported by Johan Bockgård
9125 <bojohan@gnu.org>.
9126
ef8ef9fb
CY
91272011-09-13 Chong Yidong <cyd@stupidchicken.com>
9128
9129 * frame.c (Fother_visible_frames_p): Function deleted.
9130
fa819fed
EZ
91312011-09-12 Eli Zaretskii <eliz@gnu.org>
9132
9133 * indent.c (compute_motion): Process display vector front to back
9134 rather than the other way around. (Bug#2496)
9135
2ba8e008
SM
91362011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
9137
9138 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
9139
20f53c69
CY
91402011-09-11 Chong Yidong <cyd@stupidchicken.com>
9141
9142 * minibuf.c (Fread_from_minibuffer): Doc fix.
9143
d562d7a4
EZ
91442011-09-11 Eli Zaretskii <eliz@gnu.org>
9145
9146 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
9147 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
9148
1c4d7f3d
LMI
91492011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9150
9151 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
9152 value for non-existent files.
9153
b885bf36
EZ
91542011-09-11 Eli Zaretskii <eliz@gnu.org>
9155
9156 * fileio.c (Finsert_file_contents): If the file cannot be opened,
9157 set its "size" to -1. This will set the modtime_size field of
9158 the corresponding buffer to -1, which is what
9159 verify-visited-file-modtime expects for files that do not exist.
9160 (Bug#9139)
9161
6612f0bf
PE
91622011-09-11 Paul Eggert <eggert@cs.ucla.edu>
9163
9164 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
9165 here ...
9166 * lisp.h: ... from here. push_key_description is no longer
9167 defined in keyboard.c, so its declaration should not be in
9168 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
9169 logically belongs with push_key_description.
9170
dfb3f755
PE
91712011-09-10 Paul Eggert <eggert@cs.ucla.edu>
9172
9173 * buffer.h: Include <sys/types.h> instead of <time.h>.
9174 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
9175 Problem reported by Herbert J. Skuhra.
9176
3134906c
LMI
91772011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
9178
9179 * xml.c (parse_region): Make the parsing work for
9180 non-comment-starting XML files again (bug#9144).
9181
8d903f4e
AS
91822011-09-10 Andreas Schwab <schwab@linux-m68k.org>
9183
9184 * image.c (gif_load): Fix calculation of bottom and right corner.
9185 (Bug#9468)
9186
80ad64f4
EZ
91872011-09-10 Eli Zaretskii <eliz@gnu.org>
9188
9189 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
9190 redisplay in small windows.
9191
208a048d
EZ
91922011-09-09 Eli Zaretskii <eliz@gnu.org>
9193
9194 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
9195
9b1c252e
MR
91962011-09-08 Martin Rudalics <rudalics@gmx.at>
9197
9198 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
9199 Operate on live windows only.
9200
2949f33b
JB
92012011-09-08 Juanma Barranquero <lekktu@gmail.com>
9202
9203 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
9204
e08dcafd
EZ
92052011-09-07 Eli Zaretskii <eliz@gnu.org>
9206
9207 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
9208 only under bidi iteration.
9209
115b96bd
JD
92102011-09-07 Jan Djärv <jan.h.d@swipnet.se>
9211
9212 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
9213
c8199d0f
PE
92142011-09-06 Paul Eggert <eggert@cs.ucla.edu>
9215
9216 isnan: Fix porting problem to Solaris 10 with bundled gcc.
9217 Without this fix, the command to link temacs failed due to an
9218 undefined symbol __builtin_isnan. This is because
9219 /usr/include/iso/math_c99.h #defines isnan(x) to
9220 __builtin_isnan(x), but the bundled gcc, which identifies itself
9221 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
9222 a __builtin_isnan.
9223 * floatfns.c (isnan): #undef, and then #define to a clone of
9224 what's in data.c.
9225 (Fisnan): Always define, since it's always available now.
9226 (syms_of_floatfns): Always define isnan at the Lisp level.
9227
e39b275c 92282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
9229
9230 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
9231
b2db44d9 92322011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 9233
f4af5137 9234 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
9235 The previous code assumed that file offsets (off_t values) fit in
9236 EMACS_INT variables, which is not true on typical 32-bit hosts.
9237 The code messed up by falsely reporting buffer overflow in cases
9238 such as (insert-file-contents "big" nil 1 2) into an empty buffer
9239 when "big" contains more than 2**29 bytes, even though this
9240 inserts just one byte and does not overflow the buffer.
9241 (Finsert_file_contents): Store file offsets as off_t
9242 values, not as EMACS_INT values. Check for overflow when
9243 converting between EMACS_INT and off_t. When checking for
9244 buffer overflow or for overlap, take the offsets into account.
9245 Don't use EMACS_INT for small values where int suffices.
9246 When checking for overlap, fix a typo: ZV was used where
9247 ZV_BYTE was intended.
9248 (Fwrite_region): Don't assume off_t fits into 'long'.
9249 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
9250
ecfc0a49
MA
92512011-09-05 Michael Albinus <michael.albinus@gmx.de>
9252
9253 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
9254
6511acf2 92552011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 9256
0999621a 9257 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
9258
9259 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 9260 (esprintf, exprintf, evxprintf): New functions.
62f19c19 9261 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 9262 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
9263 (modify_event_symbol): Do not assume that the length of
9264 name_alist_or_stem is safe to alloca and fits in int.
9265 (Fexecute_extended_command): Likewise for function name and binding.
9266 (Frecursion_depth): Wrap around reliably on integer overflow.
9267 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
9268 since some callers pass EMACS_INT values.
9269 (Fsingle_key_description): Don't crash if symbol name contains more
9270 than MAX_ALLOCA bytes.
9271 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
9272 (get_minibuffer): Arg is now EMACS_INT, not int.
9273 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 9274 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
9275 * window.h (command_loop_level, minibuf_level): Reflect API changes.
9276
2be7d702
PE
9277 * dbusbind.c (signature_cat): New function.
9278 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
9279 Do not overrun buffer; instead, report string overflow.
9280
9d1df220
PE
9281 * dispnew.c (add_window_display_history): Don't overrun buffer.
9282 Truncate instead; this is OK since it's just a log.
9283
33ef5c64
PE
9284 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
9285 even if the time zone offset is outlandishly large.
9286 Don't mishandle offset == INT_MIN.
9287
66c6fdd5
PE
9288 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
9289 when creating daemon; the previous buffer-overflow check was incorrect.
9290
d749b01b
PE
9291 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
9292 which has the guts of the old verror function.
9293
b5cd1905
PE
9294 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
9295 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
9296
6e1a67fb
PE
9297 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
9298 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 9299 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 9300 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
9301 length of string rather than counting it via multiple sprintfs;
9302 that's simpler and more reliable.
c21721cc
PE
9303 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
9304 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
9305 sprintf, in case result does not fit in int.
9306
c57b67fc
PE
9307 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
9308 (fontset_from_font): Print it.
9309
8a401434
PE
9310 * frame.c (tty_frame_count): Now printmax_t, not int.
9311 (make_terminal_frame, set_term_frame_name): Print it.
9312 (x_report_frame_params): In X, window IDs are unsigned long,
9313 not signed long, so print them as unsigned.
9314 (validate_x_resource_name): Check for implausibly long names,
9315 and don't assume name length fits in 'int'.
9316 (x_get_resource_string): Don't blindly alloca invocation name;
9317 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
9318 not fit in int.
9319
6e1a67fb
PE
9320 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
9321 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
9322 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
9323
0df02bf3
PE
9324 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
9325 Use esprintf, not sprintf, in case result does not fit in int.
9326
48e30793
PE
9327 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9328 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
9329 it as a large positive number.
9330 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
9331 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9332
a66ff6d8
PE
9333 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
9334 in case result does not fit in int.
9335
aca216ff
PE
9336 * print.c (float_to_string): Detect width overflow more reliably.
9337 (print_object): Make sprintf buffer a bit bigger, to avoid potential
9338 buffer overrun. Don't assume list length fits in 'int'. Treat
9339 print length of 0 as 0, not as infinity; to be consistent with other
9340 uses of print length in this function. Don't overflow print length
9341 index. Don't assume hash table size fits in 'long', or that
9342 vectorlike size fits in 'unsigned long'.
9343
31c286f7
PE
9344 * process.c (make_process): Use printmax_t, not int, to format
9345 process-name gensyms.
9346
55e5faa1
PE
9347 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
9348
80f2e268
PE
9349 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
9350 to avoid potential buffer overrun.
9351
670741ab
PE
9352 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
9353 if X resource line is longer than 512 bytes.
9354
b7163a50
PE
9355 * xfns.c (x_window): Make sprintf buffer a bit bigger
9356 to avoid potential buffer overrun.
9357
ae58ff1f
PE
9358 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
9359
c43c8a6a
PE
9360 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
9361
3f8236f4
PE
93622011-09-04 Paul Eggert <eggert@cs.ucla.edu>
9363
53e9fe90 9364 Integer overflow fixes for scrolling, etc.
6511acf2
PE
9365 Without these, Emacs silently mishandles large integers sometimes.
9366 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
9367 it were "C-u 1 M-x recenter" on a typical 64-bit host.
9368
6511acf2
PE
9369 * xdisp.c (try_window_id): Check Emacs fixnum range before
9370 converting to 'int'.
806add1d 9371
6511acf2 9372 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
9373 Check that an Emacs fixnum is in range before assigning it to 'int'.
9374 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
9375 values converted from Emacs fixnums.
9376 (Frecenter): Don't wrap around a line count if it is out of 'int'
9377 range; instead, treat it as an extreme value.
9378 (Fset_window_configuration, compare_window_configurations):
9379 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
9380
6511acf2
PE
9381 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
9382 that can exceed INT_MAX. Check that EMACS_INT value is in range
9383 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
9384 (match_limit): Don't assume that a fixnum can fit in 'int'.
9385
6511acf2 9386 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
9387 exceed INT_MAX.
9388
6511acf2 9389 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
9390 (Fvertical_motion): Don't wrap around LINES values that don't fit
9391 in 'int'. Instead, treat them as extreme values. This is good
9392 enough for windows, which can't have more than INT_MAX lines anyway.
9393
fcb901a7
LMI
93942011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9395
0f2f6b6d
LMI
9396 * Require libxml/parser.h to avoid compilation warning.
9397
fcb901a7
LMI
9398 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
9399
9400 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
9401 since this reportedly can destroy thread storage.
9402
6e20a0d4
CY
94032011-08-30 Chong Yidong <cyd@stupidchicken.com>
9404
9405 * syntax.c (find_defun_start): Update all cache variables if
9406 exiting early (Bug#9401).
9407
148ae00e
EZ
94082011-08-30 Eli Zaretskii <eliz@gnu.org>
9409
f6cfbd8f
EZ
9410 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
9411
148ae00e
EZ
9412 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
9413 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
9414 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
9415
9416 * term.c (tty_append_glyph): New function.
9417 (produce_stretch_glyph): Static function and its prototype deleted.
9418
a66cfb1c
SM
9419 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
9420 Add prototypes.
148ae00e 9421
c4a07a4c
PE
94222011-08-29 Paul Eggert <eggert@cs.ucla.edu>
9423
9424 * image.c (parse_image_spec): Check for nonnegative, not for positive,
9425 when checking :margin (Bug#9390).
9426 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 9427 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
9428 so that the name doesn't mislead. All uses changed.
9429
6bc8cd65
JB
94302011-08-28 Johan Bockgård <bojohan@gnu.org>
9431
9432 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
9433 set_tty_hooks.
9434
dca4927e
EZ
94352011-08-27 Eli Zaretskii <eliz@gnu.org>
9436
9437 * xdisp.c (move_it_to): Don't bail out early when reaching
9438 position beyond to_charpos, if we are scanning backwards.
9439 (move_it_vertically_backward): When DY == 0, make sure we get to
9440 the first character in the line after the newline.
9441
f2cad773
PE
94422011-08-27 Paul Eggert <eggert@cs.ucla.edu>
9443
9444 * ccl.c: Improve and simplify overflow checking (Bug#9196).
9445 (ccl_driver): Do not generate an out-of-range pointer.
9446 (Fccl_execute_on_string): Remove unnecessary check for
9447 integer overflow, noted by Stefan Monnier in
9448 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
9449 Remove a FIXME that didn't need fixing.
9450 Simplify the newly-introduced buffer reallocation code.
9451
0cae2cdb
JB
94522011-08-27 Juanma Barranquero <lekktu@gmail.com>
9453
9454 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
9455
5fc295a4 94562011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 9457
70c60eb2 9458 Integer and memory overflow issues (Bug#9196).
726e0ab1 9459
d31850da
PE
9460 * doc.c (get_doc_string): Rework so that
9461 get_doc_string_buffer_size is the actual buffer size, rather than
9462 being 1 less than the actual buffer size; this makes xpalloc more
9463 convenient.
9464
a69fbedb
PE
9465 * image.c (x_allocate_bitmap_record, cache_image):
9466 * xselect.c (Fx_register_dnd_atom):
9467 Simplify previous changes by using xpalloc.
9468
fe5c5d37
PE
9469 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
9470 since either will do and ptrdiff_t is convenient with xpalloc.
9471
0065d054
PE
9472 * charset.c (charset_table_size)
9473 (struct charset_sort_data.priority): Now ptrdiff_t.
9474 (charset_compare): Don't overflow if priorities differ greatly.
9475 (Fsort_charsets): Don't assume list length fits in int.
9476 Check for size-calculation overflow when allocating sort data.
9477 (syms_of_charset): Allocate an initial charset table that is
9478 just under 64 KiB, to avoid problems with glibc malloc and mmap.
9479
9480 * cmds.c (internal_self_insert): Check for size-calculation overflow.
9481
9482 * composite.h (struct composition.glyph_len): Now int, not unsigned.
9483 The actual value is always <= INT_MAX, and leaving it unsigned made
9484 overflow checking harder.
9485
9486 * dispextern.h (struct glyph_matrix.rows_allocated)
9487 (struct face_cache.size): Now ptrdiff_t, for convenience in use
9488 with xpalloc. The values are still always <= INT_MAX.
9489
9490 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
9491
9492 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
9493 (SAFE_NALLOCA): New macro.
9494
9495 * region-cache.c (struct boundary.pos, find_cache_boundary)
9496 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
9497 (set_cache_region, invalidate_region_cache)
9498 (revalidate_region_cache, know_region_cache, region_cache_forward)
9499 (region_cache_backward, pp_cache):
9500 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
9501 so that ptrdiff_t * can be passed to xpalloc.
9502 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
9503 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
9504 (pp_cache): Don't assume cache_len fits in int.
9505 * region-cache.h: Adjust extern decls to match.
9506
9507 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
9508 EMACS_INT, since either will do, for xpalloc.
9509
9510 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
9511 (xnmalloc, xnrealloc, xpalloc): New functions.
9512
726e0ab1
PE
9513 * bidi.c (bidi_shelve_header_size): New constant.
9514 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
9515 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
9516
51f30bc5 9517 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
9518 * buffer.c (overlays_at, overlays_in, record_overlay_string)
9519 (overlay_strings):
9520 Don't update size of array until after memory allocation succeeds,
9521 because xmalloc/xrealloc may not return.
0065d054
PE
9522 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
9523 now that we have proper integer overflow checking.
9524 (record_overlay_string, overlay_strings): Catch overflows when
9525 calculating size of overlay_str_buf.
726e0ab1 9526
0065d054
PE
9527 * callproc.c (Fcall_process): Check for size overflow when
9528 calculating size of args2.
9529 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
9530 Normally we prefer signed values, but sticking with ptrdiff_t would
9531 require adding more-complicated checks.
726e0ab1
PE
9532
9533 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
9534 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
9535 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 9536 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
9537
9538 * character.c (Fstring): Check for size-calculation overflow.
9539
9540 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
9541 unnecessary integer overflow. Check for size overflow.
9542 (encode_coding_object): Don't update size until xmalloc succeeds.
9543
9544 * composite.c (get_composition_id): Check for overflow in glyph
9545 length calculations.
9546
9547 Integer and memory overflow fixes for display code.
9548 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
9549 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
9550 (scrolling_window): Check for overflow in size calculations.
9551 (line_draw_cost, realloc_glyph_pool, add_row_entry):
9552 Don't assume glyph table len fits in int.
9553 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
9554 (row_table_size): Now ptrdiff_t, not int.
9555 (scrolling_window): Avoid overflow in size calculations.
9556 Don't update size until allocation succeeds.
9557 * fns.c (concat): Check for overflow in size calculations.
9558 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
9559 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9560 (NEXT_ALMOST_PRIME_LIMIT): New constant.
9561
9562 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
9563 (get_doc_string): Check for size calculation overflow.
9564 Don't update size until allocation succeeds.
9565 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
9566 EMACS_INT, where ptrdiff_t will do.
9567 (Fsubstitute_command_keys): Check for string overflow.
9568
9569 * editfns.c (set_time_zone_rule): Don't assume environment length
9570 fits in int.
9571 (message_length): Now ptrdiff_t, not int.
9572 (Fmessage_box): Don't update size until allocation succeeds.
9573 Don't assume message length fits in int.
9574 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
9575
0065d054
PE
9576 * emacs.c (main): Do not reallocate argv, since there is a null at
9577 the end that can be overwritten, and this way there's no need to
9578 worry about size-calculation overflow.
9579 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
9580
9581 * eval.c (init_eval_once, grow_specpdl): Don't update size until
9582 alloc succeeds.
9583 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
9584
9585 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
9586 (x_set_scroll_bar_width, x_figure_window_size):
9587 Check for integer overflow.
9588 (x_set_alpha): Do not assume XINT fits in int.
9589
9590 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
9591 This is for the members text_lines, text_cols, total_lines, total_cols,
9592 where the system imposes an 'int' limit.
9593
9594 * fringe.c (Fdefine_fringe_bitmap):
9595 Don't update size until alloc works.
9596
9597 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
9598 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
9599
9600 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
9601 Check for size-calculation overflow.
9602 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
9603 do, as we prefer signed integers.
9604 (id_to_widget.max_size, id_to_widget.used)
9605 (xg_store_widget_in_map, xg_remove_widget_from_map)
9606 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
9607 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
9608 Use and return ptrdiff_t, not int.
9609 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
9610 * gtkutil.h: Change prototypes to match the above.
9611
9612 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
9613 are duplicate now that they've been promoted to lisp.h.
9614 (x_allocate_bitmap_record, x_alloc_image_color)
9615 (make_image_cache, cache_image, xpm_load):
9616 Don't update size until alloc is done.
9617 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
9618 (x_detect_edges):
3256efce 9619 Check for size calculation overflow.
726e0ab1
PE
9620 (ct_colors_allocated_max): New constant.
9621 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
9622 overflow.
3256efce 9623
726e0ab1
PE
9624 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
9625 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
9626 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
9627 Use ptrdiff_t, not int, to count maps.
9628 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
9629 calculations. Don't update size until allocation succeeds.
9630 Redo calculations to avoid overflow.
726e0ab1
PE
9631 * keyboard.h: Change prototypes to match the above.
9632
9633 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
9634 to count maps.
9635 (current_minor_maps): Check for size calculation overflow.
9636 * keymap.h: Change prototypes to match the above.
9637
9638 * lread.c (read1, init_obarray): Don't update size until alloc done.
9639
9640 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
9641 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
9642
726e0ab1
PE
9643 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
9644 Now ptrdiff_t, not int.
9645 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
9646 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
9647
9648 * process.c (Fnetwork_interface_list): Check for overflow
9649 in size calculation.
9650
9651 * region-cache.c (move_cache_gap): Check for size calculation overflow.
9652
9653 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
9654 overflow. Don't bother calling xmalloc when xrealloc will do.
9655
9656 * search.c (Freplace_match): Check for size calculation overflow.
9657 (Fset_match_data): Don't assume list lengths fit in 'int'.
9658
9659 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
9660 for command line length. Do not attempt to address one before the
9661 beginning of an array, as that's not portable.
9662
9663 * term.c (max_frame_lines): Remove; unused.
9664 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
9665 not int.
9666 (encode_terminal_code, calculate_costs): Check for size
9667 calculation overflow.
9668 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
9669 table lengths and related sizes. Don't update size until alloc
9670 done. Redo calculations to avoid overflow.
9671 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
9672
9673 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
9674 subtracting pointers.
9675 (gobble_line): Check for overflow more carefully. Don't update size
9676 until alloc done.
9677
9678 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
9679 Don't update size until alloc done.
9680 Redo size calculations to avoid overflow.
9681 Check for size calculation overflow.
0065d054 9682 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
9683
9684 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
9685 Use ptrdiff_t, not int, for sizes.
9686 (store_mode_line_noprop_char): Don't update size until alloc done.
9687
0065d054
PE
9688 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
9689 Use ptrdiff_t, not int, for sizes.
9690 (Finternal_make_lisp_face, cache_face):
9691 Check for size calculation overflow.
9692 (cache_face): Treat size calculation overflows as if they were
9693 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
9694
9695 * xfns.c (x_encode_text, x_set_name_internal)
9696 (Fx_change_window_property): Use ptrdiff_t, not int, to count
9697 sizes, since they can exceed INT_MAX in size. Check for size
9698 calculation overflow.
9699
0065d054
PE
9700 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
9701 (xg_select): Check for size calculation overflow.
726e0ab1
PE
9702 Don't update size until alloc done.
9703
0065d054 9704 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 9705 as sprintf is limited to int lengths.
1d526e2f 9706
252c5ee1
PE
9707 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
9708 (X_LONG_MIN): New macros.
864d7ce7
PE
9709 Use them to make the following changes clearer.
9710 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
9711 This change doesn't affect the value now, but it may help remind
9712 future maintainers not to raise the value too much later.
9713 (SELECTION_QUANTUM): Remove, replacing with ...
9714 (selection_quantum): ... new function, which avoids overflow.
9715 All uses changed.
9716 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
9717 assumption that selection length fits in 'int'.
9718 (x_reply_selection_request, x_handle_selection_request)
9719 (x_get_window_property, receive_incremental_selection)
9720 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
9721 (lisp_data_to_selection_data, clean_local_selection_data):
9722 Use ptrdiff_t, not int, to record length of selection.
9723 (x_reply_selection_request, x_get_window_property)
9724 (receive_incremental_selection, x_property_data_to_lisp):
9725 Redo calculations to avoid overflow.
9726 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 9727 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
9728 something.
9729 (x_get_window_property, receive_incremental_selection)
9730 (lisp_data_to_selection_data, x_property_data_to_lisp):
9731 Check for size-calculation overflow.
9732 (x_get_window_property, receive_incremental_selection)
9733 (lisp_data_to_selection_data, Fx_register_dnd_atom):
9734 Don't store size until memory allocation succeeds.
9735 (x_get_window_property): Plug memory leak on memory exhaustion.
9736 Don't double-block input; malloc is safe here. Don't assume 2**34
9737 - 4 fits in unsigned long. Add an xassert to check
9738 XGetWindowProperty overflow. Be more careful about overflow
9739 calculations, and distinguish size from memory overflow better.
9740 (receive_incremental_selection): When tracing, don't assume
9741 unsigned int is less than INT_MAX.
9742 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
9743 harmful) conversions of unsigned short to int.
9744 (lisp_data_to_selection_data): Don't assume that integers
9745 in the range -65535 through -1 fit in an X unsigned short.
9746 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
9747 result parameters unless successful. Rely on cons_to_unsigned
9748 to report problems with elements; the old code wasn't right anyway.
9749 (x_check_property_data): Check for int overflow; we cannot use
9750 a wider type due to X limits.
9751 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
9752
726e0ab1 9753 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 9754
0065d054
PE
9755 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
9756 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
9757 (x_color_cells): Don't store size until memory allocation succeeds.
9758 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 9759 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
9760 (x_term_init): Don't assume length fits in int (sprintf is limited
9761 to int size).
bc18e09d 9762
ebfa62c0
PE
9763 Use ptrdiff_t for composition IDs.
9764 * character.c (lisp_string_width):
9765 * composite.c (composition_table_size, n_compositions)
9766 (get_composition_id, composition_gstring_from_id):
9767 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
9768 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
9769 * window.c (Frecenter):
9770 Use ptrdiff_t, not int, for composition IDs.
9771 * composite.c (get_composition_id): Check for integer overflow.
9772 * composite.h: Adjust prototypes to match the above changes.
9773
d3411f89
PE
9774 Use ptrdiff_t for hash table indexes.
9775 * category.c (hash_get_category_set):
9776 * ccl.c (ccl_driver):
9777 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
9778 * coding.c (coding_system_charset_list, detect_coding_system):
9779 * coding.h (struct coding_system.id):
9780 * composite.c (get_composition_id, gstring_lookup_cache):
9781 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
9782 * image.c (xpm_get_color_table_h):
9783 * lisp.h (hash_lookup, hash_put):
9784 * minibuf.c (Ftest_completion):
9785 Use ptrdiff_t for hash table indexes, not int (which is too
9786 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
9787 32-bit --with-wide-int hosts).
9788
e097a6fa
PE
9789 * charset.c (Fdefine_charset_internal): Check for integer overflow.
9790 Add a FIXME comment about memory leaks.
9791 (syms_of_charset): Don't assume xmalloc returns.
9792
5637687f
PE
9793 Don't assume that stated character widths fit in int.
9794 * character.c (Fchar_width, c_string_width, lisp_string_width):
9795 * character.h (CHAR_WIDTH):
9796 * indent.c (MULTIBYTE_BYTES_WIDTH):
9797 Use sanitize_char_width to avoid undefined and/or bad behavior
9798 with outlandish widths.
a66cfb1c 9799 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
9800 now that we have two such functions. All uses changed.
9801 (sanitize_char_width): New inline function.
9802
a2271ba2
PE
9803 Don't assume that tab-width fits in int.
9804 * character.h (sanitize_width): New inline function.
9805 (SANE_TAB_WIDTH): New macro.
9806 (ASCII_CHAR_WIDTH): Use it.
9807 * indent.c (sane_tab_width): Remove. All uses replaced by
9808 SANE_TAB_WIDTH (current_buffer).
9809 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
9810
18c52557
PE
9811 * fileio.c: Integer overflow issues with file modes.
9812 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
9813
caeeedc1
PE
9814 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
9815 Remove unreachable code.
9816 (read_hex, load_charset_map_from_file): Check for integer overflow.
9817
6df6ae42 9818 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
9819 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
9820 (x_send_scroll_bar_event): Likewise. Check that the size does not
9821 exceed limits imposed by XClientMessageEvent, as well as the usual
9822 ptrdiff_t and size_t limits.
9823
b13995db
PE
9824 * keyboard.c: Overflow, signedness and related fixes.
9825 (make_lispy_movement): Use same integer type in forward decl
9826 that is used in the definition.
9827 (read_key_sequence, keyremap_step):
9828 Change bufsize argument back to int, undoing my 2011-03-30 change.
9829 We prefer signed types, and int is wide enough here.
9830 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
9831 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
9832 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
9833 length, not size_t. Use ptrdiff_t for index, not int.
9834 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
9835 possibility of integer overflow.
9836
13464394
PE
9837 Overflow, signedness and related fixes for images.
9838
9839 * dispextern.h (struct it.stack[0].u.image.image_id)
9840 (struct_it.image_id, struct image.id, struct image_cache.size)
9841 (struct image_cache.used, struct image_cache.ref_count):
9842 * gtkutil.c (update_frame_tool_bar):
9843 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
9844 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
9845 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
9846 * nsmenu.m (update_frame_tool_bar):
9847 * xdisp.c (calc_pixel_width_or_height):
9848 * xfns.c (image_cache_refcount):
9849 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
9850 on typical 64-bit hosts.
9851
9852 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9853 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
9854 Omit unnecessary casts to int.
9855 (parse_image_spec): Check that integers fall into 'int' range
9856 when the callers expect that.
9857 (image_ascent): Redo ascent calculation to avoid int overflow.
9858 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
9859 (lookup_image): Remove unnecessary tests.
9860 (xbm_image_p): Locals are now of int, not EMACS_INT,
9861 since parse_image_check makes sure they fit into int.
9862 (png_load, gif_load, svg_load_image):
9863 Prefer int to unsigned where either will do.
9864 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
9865 old tiff_error_handler and tiff_warning_handler.
9866 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
9867 stack buffer overflows. It uses only the features of vsnprintf
9868 that are common to both POSIX and native Microsoft.
9869 (tiff_error_handler, tiff_warning_handler): Use it.
9870 (tiff_load, gif_load, imagemagick_load_image):
9871 Don't assume :index value fits in 'int'.
9872 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
9873 (imagemagick_load_image): Check that crop parameters fit into
9874 the integer types that MagickCropImage accepts. Don't assume
9875 Vimagemagick_render_type has a nonnegative value. Don't assume
9876 size_t fits in 'long'.
9877 (gs_load): Use printmax_t to print the widest integers possible.
9878 Check for integer overflow when computing image height and width.
9879
c11821d4
EZ
98802011-08-26 Eli Zaretskii <eliz@gnu.org>
9881
9882 * xdisp.c (redisplay_window): Don't force window start if point
9883 will be invisible in the resulting window. (Bug#9324)
9884
0c95fcf7
EZ
98852011-08-25 Eli Zaretskii <eliz@gnu.org>
9886
9887 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
9888 the display spec is of the form `(space ...)'.
9889 (handle_display_spec): Return the value returned by
9890 handle_single_display_spec, not just 1 or zero.
9891 (handle_single_display_spec): If the display spec is of the form
9892 `(space ...)', and specifies display in the text area, return 2
9893 rather than 1.
fee65a97 9894 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
9895 accurately, and prefer exact match for point under bidi.
9896 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
9897
9898 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
9899 into disp_prop; all users changed.
9900
9901 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
9902 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
9903 for the text covered by the display property.
9904
e4ed06f1
CY
99052011-08-25 Chong Yidong <cyd@stupidchicken.com>
9906
9907 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
9908 Change return value to nil.
9909 (Frecord_buffer): Delete unused function.
9910
f67cdd7f
EZ
99112011-08-24 Eli Zaretskii <eliz@gnu.org>
9912
5980d4c6
EZ
9913 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
9914 buffers, return left-to-right.
8610fe8b
EZ
9915 (set_cursor_from_row): Consider candidate row a win if its glyph
9916 represents a newline and point is on that newline. Fixes cursor
9917 positioning on the newline at EOL of R2L text within L2R
9918 paragraph, and vice versa.
9919 (try_cursor_movement): Check continued rows, in addition to
9920 continuation rows. Fixes unwarranted scroll when point enters a
9921 continued line of R2L text within an L2R paragraph, or vice versa.
9922 (cursor_row_p): Consider the case of point being equal to
9923 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
9924 from the end of a short line to the beginning of a continued line
9925 of R2L text within L2R paragraph.
9926 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
9927 composed characters.
5980d4c6 9928
f67cdd7f
EZ
9929 * bidi.c (bidi_check_type): Use xassert.
9930 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
9931 members.
9932
bca633fb
EZ
99332011-08-23 Eli Zaretskii <eliz@gnu.org>
9934
9935 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
9936 a character.
9937
4a5885a7
CY
99382011-08-23 Chong Yidong <cyd@stupidchicken.com>
9939
9940 * nsfont.m (ns_otf_to_script): Fix typo.
9941
0902a04e
KH
99422011-08-22 Kenichi Handa <handa@m17n.org>
9943
9944 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
9945 extra slot even if the purpose is char-code-property-table.
9946
1a2e6670
EZ
99472011-08-23 Eli Zaretskii <eliz@gnu.org>
9948
8ddde651
EZ
9949 * xdisp.c (redisplay_window): When computing centering_position,
9950 account for the height of the header line. (Bug#8874)
9951
425cc014
EZ
9952 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
9953 instead of CHAR_TO_BYTE. Fixes a crash when a completion
9954 candidate is selected by the mouse, and that candidate has a
9955 composed character under the mouse.
9956
1a2e6670
EZ
9957 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
9958 coordinates reported by pos-visible-in-window-p for a composed
9959 character in column zero.
9960
8b76d6f8
SM
99612011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
9962
9963 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
9964
dac347dd
EZ
99652011-08-22 Eli Zaretskii <eliz@gnu.org>
9966
9967 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
9968 consider it a hit if to_charpos is anywhere in the range of the
9969 composed buffer positions.
9970
e013fb34
CY
99712011-08-22 Chong Yidong <cyd@stupidchicken.com>
9972
9973 * image.c (gif_load): Don't assume that each subimage has the same
9974 dimensions as the base image. Handle disposal method that is
9975 "undefined" by the gif spec (Bug#9335).
9976
bd1ba3e8
CY
99772011-08-20 Chong Yidong <cyd@stupidchicken.com>
9978
9979 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 9980 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 9981
54a1215b
EZ
99822011-08-19 Eli Zaretskii <eliz@gnu.org>
9983
823564e5
EZ
9984 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
9985 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
9986 from an Org mode buffer to a Speedbar frame.
9987
54a1215b
EZ
9988 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
9989 a composition, take its buffer position from IT->cmp_it.charpos.
9990 Fixes cursor positioning at the beginning of a line that begins
9991 with a composed character.
9992
9778ebcc
EZ
99932011-08-18 Eli Zaretskii <eliz@gnu.org>
9994
0be6ee06
EZ
9995 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
9996 character bidirectional type, use STRONG_L instead. Fixes crashes
9997 in a buffer produced by `describe-categories'.
9998
9778ebcc
EZ
9999 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
10000 members before the level stack, so they would be saved and
10001 restored when copying iterator state. Fixes incorrect reordering
10002 around TABs covered by display properties.
10003
156bffbe
AS
100042011-08-18 Andreas Schwab <schwab@linux-m68k.org>
10005
6b02f655 10006 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 10007
72ad093b
CY
100082011-08-17 Chong Yidong <cyd@stupidchicken.com>
10009
10010 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
10011 (internal_condition_case_2, internal_condition_case_n):
10012 Remove unnecessary aborts (Bug#9081).
72ad093b 10013
35774242
EZ
100142011-08-17 Eli Zaretskii <eliz@gnu.org>
10015
10016 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
10017 has no `load' handler, try opening the file locally. (Bug#9311)
10018
db76dd85
KB
100192011-08-16 Ken Brown <kbrown@cornell.edu>
10020
10021 * gmalloc.c: Expand comment.
10022
b215eee5
EZ
100232011-08-16 Eli Zaretskii <eliz@gnu.org>
10024
10025 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
10026 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
10027
a4579d33
KB
100282011-08-16 Ken Brown <kbrown@cornell.edu>
10029
10030 Fix memory allocation problems in Cygwin build (Bug#9273).
10031
10032 * unexcw.c ( __malloc_initialized): Declare external variable.
10033 (fixup_executable): Force the dumped emacs to reinitialize malloc.
10034
8b76d6f8
SM
10035 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
10036 New variables.
a4579d33
KB
10037 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
10038 dumped emacs.
10039 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
10040 in the static heap.
10041 [CYGWIN] (special_realloc): New function.
10042 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
10043 requests to realloc storage in the static heap.
10044
3ebec551
PE
100452011-08-15 Paul Eggert <eggert@cs.ucla.edu>
10046
10047 * bidi.c (bidi_initialize): Remove unused local.
10048
9fd8be00
EZ
100492011-08-15 Eli Zaretskii <eliz@gnu.org>
10050
6b02f655
SM
10051 * bidimirror.h:
10052 * biditype.h: Remove file.
10053 * makefile.w32-in ($(BLD)/bidi.$(O)):
10054 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
10055
10056 * dispextern.h: Fix a typo in the comment to bidi_type_t.
10057
10058 * chartab.c: Improve commentary for the uniprop_table API.
10059
32413314
EZ
10060 * bidi.c (bidi_paragraph_init): Support zero value of
10061 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
10062 (bidi_initialize): Use uniprop_table instead of including
10063 biditype.h and bidimirror.h.
32413314 10064
9fd8be00
EZ
10065 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
10066 coordinates of the iterator when restoring from ppos_it.
10067 (Bug#9296)
10068
5cf2b69b
KH
100692011-08-14 Kenichi Handa <handa@m17n.org>
10070
10071 * process.c (create_process): Call setup_process_coding_systems
72ad093b 10072 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 10073
daf17d00
EZ
100742011-08-14 Eli Zaretskii <eliz@gnu.org>
10075
10076 * xdisp.c (move_it_in_display_line_to): Don't invoke
10077 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
10078 ppos_it. Fixes vertical cursor motion when line beginning is
10079 covered by an image. (Bug#9296)
10080
08e3161a
JD
100812011-08-14 Jan Djärv <jan.h.d@swipnet.se>
10082
10083 * nsterm.h (ns_run_ascript): Declare.
10084 (NSAPP_DATA2_RUNASSCRIPT): Define.
10085
10086 * nsfns.m (as_script, as_result, as_status): New static variables.
10087 (ns_run_ascript): New function.
5e617bc2 10088 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
10089 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
10090 the event loop. Get status from as_status (Bug#7276).
10091
10092 * nsterm.m (sendEvent): If event is NSApplicationDefined and
10093 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
10094 the event loop (Bug#7276).
10095
a3720aa2
AS
100962011-08-14 Andreas Schwab <schwab@linux-m68k.org>
10097
10098 * gnutls.c (QCgnutls_bootprop_priority)
10099 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
10100 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
10101 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
10102 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
10103 (QCgnutls_bootprop_verify_hostname_error)
10104 (QCgnutls_bootprop_callbacks_verify): Rename from
10105 Qgnutls_bootprop_..., all uses changed.
10106
10107 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
10108 uses changed.
10109
0a0d27fb
PE
101102011-08-14 Paul Eggert <eggert@cs.ucla.edu>
10111
19d5c50c
PE
10112 * xfaces.c (Qframe_set_background_mode): Now static.
10113 * dispextern.h (Qframe_set_background_mode): Remove decl.
10114
0a0d27fb
PE
10115 * process.c (Fnetwork_interface_info): Declare local only if needed.
10116
377538cb
JD
101172011-08-13 Jan Djärv <jan.h.d@swipnet.se>
10118
10119 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
10120 (Fnetwork_interface_list): Allocate in increments of bytes instead
10121 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
10122 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
10123 sockaddr.
10124 (struct ifflag_def): notrailers is smart on OSX.
10125 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
10126 Get hardware address with getifaddrs if available.
10127
08fff70c
EZ
101282011-08-12 Eli Zaretskii <eliz@gnu.org>
10129
10130 * xdisp.c (iterate_out_of_display_property): xassert that
10131 IT->position is set to within IT->object's boundaries. Break from
10132 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
10133 when IT->position is set up wrongly due to some bug.
10134 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
10135 (push_display_prop): Allow GET_FROM_STRING as IT->method on
10136 entry. Force push_it to save on the stack the current
10137 buffer/string position, to be restored by pop_it. Fix flags in
10138 the iterator structure wrt the object coming from a display
10139 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
10140 properties. (Bug#9284)
10141
7be1c708 101422011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 10143
7be1c708
CY
10144 * fontset.c (fontset_get_font_group): Add proper type checks.
10145 (Bug#9172)
aac0c6e3 10146
7be1c708 101472011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 10148
7be1c708
CY
10149 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
10150 and LC_VERSION_MIN_MACOSX.
10151 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
10152 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 10153
97bb72a6
EZ
101542011-08-08 Eli Zaretskii <eliz@gnu.org>
10155
10156 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
10157 no-display-properties-and-no-overlays under bidi display.
10158 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 10159 properties and overlays.
97bb72a6 10160
d5617611
CY
101612011-08-08 Chong Yidong <cyd@stupidchicken.com>
10162
37e11a63
CY
10163 * editfns.c (Fset_time_zone_rule): Document relationship with the
10164 setenv function.
10165
d5617611
CY
10166 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
10167 the font entity extracted from the cache (Bug#8109).
10168
58872834
CY
101692011-08-07 Chong Yidong <cyd@stupidchicken.com>
10170
10171 * composite.c (autocmp_chars): Don't reset point. That is done by
10172 restore_point_unwind (Bug#5984).
10173
75bfc667
JL
101742011-08-07 Juri Linkov <juri@jurta.org>
10175
10176 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
10177 to show the arg `TIME' instead of `TIMEVAL'.
10178
d1410150
EZ
101792011-08-06 Eli Zaretskii <eliz@gnu.org>
10180
10181 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
10182 display property strides EOL and includes a newline, as in
10183 longlines-mode. (Bug#9254)
75b771e4
EZ
10184 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
10185 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
10186
10187 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
10188 is non-zero, even if the data buffer is NULL. Fixes a crash in
10189 vertical-motion with longlines-mode. (Bug#9254)
10190
35928349
EZ
101912011-08-05 Eli Zaretskii <eliz@gnu.org>
10192
ec7cc85b
EZ
10193 * bidi.c <bidi_cache_total_alloc>: Now static.
10194 (bidi_initialize): Initialize bidi_cache_total_alloc.
10195
8b76d6f8 10196 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
10197 cache. (Bug#9221)
10198
10199 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
10200 amount allocated this far in `bidi_cache_total_alloc'.
10201 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
10202 non-zero, only free the data buffer without restoring the cache
10203 contents. All callers changed.
10204
10205 * dispextern.h (bidi_unshelve_cache): Update prototype.
10206
10207 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
10208 (move_it_in_display_line, move_it_to)
10209 (move_it_vertically_backward, move_it_by_lines): Replace the call
10210 to xfree to an equivalent call to bidi_unshelve_cache.
10211 (move_it_in_display_line_to): Fix logic of returning
412b6358 10212 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 10213
e2e2423b
EZ
102142011-08-05 Eli Zaretskii <eliz@gnu.org>
10215
10216 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
10217 came from a string character with a `cursor' property. (Bug#9229)
10218
ae9e757a
JD
102192011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10220
10221 * Makefile.in (LIB_PTHREAD): New variable.
10222 (LIBES): Add LIB_PTHREAD (Bug#9216).
10223
10224 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
10225 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
10226
213bd7f2
AS
102272011-08-04 Andreas Schwab <schwab@linux-m68k.org>
10228
6b02f655 10229 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 10230
99aaf75f
JD
102312011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10232
10233 * xterm.c (x_find_topmost_parent): New function.
10234 (x_set_frame_alpha): Find topmost parent window with
10235 x_find_topmost_parent and set the property there also (bug#9181).
10236 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
10237
c74e9d86
PE
102382011-08-04 Paul Eggert <eggert@cs.ucla.edu>
10239
10240 * callproc.c (Fcall_process): Avoid vfork clobbering
10241 the local vars buffer, coding_systems, current_dir.
10242
640c8776
SM
102432011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
10244
10245 * keymap.c (Fmake_composed_keymap): Move to subr.el.
10246
f26d0e4c
PE
102472011-08-03 Paul Eggert <eggert@cs.ucla.edu>
10248
8a10d76c
PE
10249 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
10250 so that it is not optimized away.
10251
f26d0e4c
PE
10252 * xdisp.c (compute_display_string_pos): Remove unused local.
10253
55439c61
EZ
102542011-08-02 Eli Zaretskii <eliz@gnu.org>
10255
10256 Fix slow cursor motion and scrolling in large buffers with
10257 selective display, like Org Mode buffers. (Bug#9218)
10258
10259 * dispextern.h (struct bidi_it): New member disp_prop_p.
10260
10261 * xdisp.c: Remove one-slot cache of display string positions.
10262 (compute_display_string_pos): Accept an additional argument
5e617bc2 10263 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
10264 for a display string or property. If found, set DISP_PROP_P
10265 non-zero.
10266
10267 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
10268 DISP_PROP_P, and pass it to compute_display_string_pos.
10269 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
10270 non-zero. All callers of bidi_fetch_char changed.
10271
fb33fa43
SM
102722011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
10273
10274 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
10275
b099e063
DM
102762010-12-03 Don March <don@ohspite.net>
10277
10278 * keymap.c (Fdefine_key): Fix non-prefix key error message when
10279 last character M-[char] is translated to ESC [char] (bug#7541).
10280
5cc7f7af
KH
102812011-08-02 Kenichi Handa <handa@m17n.org>
10282
d0fffa3f 10283 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
10284
10285 * chartab.c (uniprop_table): Make it non-static.
10286
525d5e6e
EZ
102872011-08-01 Eli Zaretskii <eliz@gnu.org>
10288
10289 * xdisp.c (forward_to_next_line_start): Accept additional argument
10290 BIDI_IT_PREV, and store into it the state of the bidi iterator had
10291 on the newline.
10292 (reseat_at_next_visible_line_start): Use the bidi iterator state
10293 returned by forward_to_next_line_start to restore the state of
10294 it->bidi_it after backing up to previous newline. (Bug#9212)
10295
31011111
AS
102962011-07-30 Andreas Schwab <schwab@linux-m68k.org>
10297
10298 * regex.c (re_comp): Protoize.
10299 (re_exec): Fix return type.
10300 (regexec): Fix type of `ret'. (Bug#9203)
10301
476371c4
PE
103022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10303
e5d76069
PE
10304 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
10305 This is needed if max-image-size is a floating-point number.
10306
9a79b20c
AS
103072011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10308
10309 * print.c (print_object): Print empty symbol as ##.
10310
10311 * lread.c (read1): Read ## as empty symbol.
10312
d8c2fa78
AA
103132011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
10314
10315 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
10316 setting frame foreground color (Bug#9175).
10317 (x_set_background_color): Likewise.
10318
ffe57a7a
AA
10319 * nsmenu.m (-setText): Size tooltip dimensions precisely to
10320 contents (Bug#9176).
10321 (EmacsTooltip -init): Remove bezels and add shadows to
10322 tooltip windows.
10323
bf3492a5
AA
10324 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
10325 or scroll bar (Bug#8470).
10326
d55e9c53
AA
10327 * nsfont.m (nsfont_open): Remove assignment to voffset and
10328 unnecessary vars hshink, expand, hd, full_height, min_height.
10329 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
10330
10331 * nsterm.h (nsfont_info): Remove voffset field.
10332
d8c2fa78 103332011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
10334
10335 Implement strike-through and overline on NextStep (Bug#8863).
10336
10337 * nsfont.m (nsfont_open): Use underline position provided by font,
10338 instead of hard-coded value of 2.
10339 (nsfont_draw): Call ns_draw_text_decoration instead.
10340
10341 * nsterm.h: Add declaration for ns_draw_text_decoration.
10342
10343 * nsterm.m (ns_draw_text_decoration): New function for drawing
10344 underline, overline, and strike-through.
10345 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
10346 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 10347 accommodate underlining, etc.
4843aac3 10348
4cc60b9b
EZ
103492011-07-28 Eli Zaretskii <eliz@gnu.org>
10350
bc7ece87
EZ
10351 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
10352 default.
4cc60b9b 10353
476371c4
PE
103542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10355
66606eea
PE
10356 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
10357 Without this fix, if a signal arrives just after memory fills up,
10358 'malloc' might be invoked reentrantly.
10359
476371c4
PE
10360 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
10361 In other words, assume that every image size is allowed, on non-X
10362 hosts. This assumption is probably wrong, but it lets Emacs compile.
10363
f3fcc40d
AS
103642011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10365
10366 * regex.c (re_iswctype): Convert return values to boolean.
10367
350c992f
EZ
103682011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
10369
10370 * xdisp.c (compute_display_string_pos): Don't use cached display
10371 string position if the buffer had its restriction changed.
10372 (Bug#9184)
10373
5266b4bb
PE
103742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10375
10376 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10377
2573a837 103782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 10379
41f55ccd 10380 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 10381
39e378da
PE
10382 * bidi.c: Integer size and overflow fixes.
10383 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
10384 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
10385 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10386 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
10387 (bidi_find_other_level_edge):
10388 Use ptrdiff_t instead of EMACS_INT where either will do.
10389 This works better on 32-bit hosts configured --with-wide-int.
10390 (bidi_cache_ensure_space): Check for size-calculation overflow.
10391 Use % rather than repeated addition, for better worst-case speed.
10392 Don't set bidi_cache_size until after xrealloc returns, because it
10393 might not return.
10394 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
10395 (bidi_cache_ensure_space): Also check that the bidi cache size
10396 does not exceed that of the largest Lisp string or buffer. See Eli
10397 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 10398
5e927815
PE
10399 * alloc.c (__malloc_size_t): Remove.
10400 All uses replaced by size_t. See Andreas Schwab's note
10401 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
10402
ca4aa935
PE
10403 * image.c: Improve checking for integer overflow.
10404 (check_image_size): Assume that f is nonnull, since
10405 it is always nonnull in practice. This is one less thing to
10406 worry about when checking for integer overflow later.
10407 (x_check_image_size): New function, which checks for integer
10408 overflow issues inside X.
10409 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
10410 This removes the need for a memory_full check.
10411 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
10412 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
10413 (xbm_read_bitmap_data): Change locals back to 'int', since
10414 their values must fit in 'int'.
10415 (xpm_load_image, png_load, tiff_load):
10416 Invoke x_create_x_image_and_pixmap earlier,
10417 to avoid much needless work if the image is too large.
10418 (tiff_load): Treat overly large images as if
10419 x_create_x_image_and_pixmap failed, not as malloc failures.
10420 (gs_load): Use x_check_image_size.
10421
5f8f9cc2
PE
10422 * gtkutil.c: Omit integer casts.
10423 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
10424 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
10425
5adf60bc
PE
10426 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
10427
c8907a93
PE
10428 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
10429 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
10430 would wrongly return t on a 64-bit host.
10431
e3c25c68
PE
10432 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
10433 The plain *_OVERFLOW macros run afoul of GCC bug 49705
10434 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
10435 and therefore cause GCC to emit a bogus diagnostic in some cases.
10436
3f791afe
PE
10437 * image.c: Integer signedness and overflow and related fixes.
10438 This is not an exhaustive set of fixes, but it's time to
10439 record what I've got.
10440 (lookup_pixel_color, check_image_size): Remove redundant decls.
10441 (check_image_size): Don't assume that arbitrary EMACS_INT values
10442 fit in 'int', or that arbitrary 'double' values fit in 'int'.
10443 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
10444 (tiff_load, imagemagick_load_image):
10445 Check for overflow in size calculations.
10446 (x_create_x_image_and_pixmap): Remove unnecessary test for
10447 xmalloc returning NULL; that can't happen.
10448 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
10449 (xpm_color_bucket): Use better integer hashing function.
10450 (xpm_cache_color): Don't possibly over-allocate memory.
10451 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
10452 (gif_memory_source):
10453 Use ptrdiff_t, not int or size_t, to record sizes.
10454 (png_load): Don't assume values greater than 2**31 fit in 'int'.
10455 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
10456 either works, as we prefer signed integers.
10457 (tiff_read_from_memory, tiff_write_from_memory):
10458 Return tsize_t, not size_t, since that's what the TIFF API wants.
10459 (tiff_read_from_memory): Don't fail simply because the read would
10460 go past EOF; instead, return a short read.
10461 (tiff_load): Omit no-longer-needed casts.
10462 (Fimagemagick_types): Don't assume size fits into 'int'.
10463
3cc5a532
PE
10464 Improve hashing quality when configured --with-wide-int.
10465 * fns.c (hash_string): New function, taken from sxhash_string.
10466 Do not discard information about ASCII character case; this
10467 discarding is no longer needed.
10468 (sxhash-string): Use it. Change sig to match it. Caller changed.
10469 * lisp.h: Declare it.
10470 * lread.c (hash_string): Remove, since we now use fns.c's version.
10471 The fns.c version returns a wider integer if --with-wide-int is
10472 specified, so this should help the quality of the hashing a bit.
10473
b312a492
PE
10474 * emacs.c: Integer overflow minor fix.
10475 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
10476 Define only if GNU_LINUX.
10477 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
10478
dfd153ae
PE
10479 * dispnew.c: Integer signedness and overflow fixes.
10480 Remove unnecessary forward decls, that were a maintenance hassle.
10481 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
10482 All uses changed.
10483 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
10484 (scrolling_window): Use ptrdiff_t, not int, for byte count.
10485 (prepare_desired_row, line_draw_cost):
10486 Use int, not unsigned, where either works.
10487 (save_current_matrix, restore_current_matrix):
10488 Use ptrdiff_t, not size_t, where either works.
10489 (init_display): Check for overflow more accurately, and without
10490 relying on undefined behavior.
10491
a81d11a3
PE
10492 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
10493 Remove, replacing with the new symbols in lisp.h. All uses changed.
10494 * fileio.c (make_temp_name):
10495 * filelock.c (lock_file_1, lock_file):
10496 * xdisp.c (message_dolog):
10497 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
10498 Use pMd etc. instead.
10499 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
10500 replacing the pWIDE etc. symbols removed from editfns.c.
10501
3300e6fd
PE
10502 * keyboard.h (num_input_events): Now uintmax_t.
10503 This is (very slightly) less likely to mess up due to wraparound.
10504 All uses changed.
10505
fd05c7e9
PE
10506 * buffer.c: Integer signedness fixes.
10507 (alloc_buffer_text, enlarge_buffer_text):
10508 Use ptrdiff_t rather than size_t when either will do, as we prefer
10509 signed integers.
10510
903fe15d
PE
10511 * alloc.c: Integer signedness and overflow fixes.
10512 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
10513 (__malloc_size_t): Default to size_t, not to int.
10514 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
10515 (Fgarbage_collect, mark_object_loop_halt, mark_object):
10516 Prefer ptrdiff_t to size_t when either would do, as we prefer
10517 signed integers.
10518 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
10519 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
10520 Now const. Initialize with values that are in range even if char
10521 is signed.
10522 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
10523 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
10524 These functions do the right thing with sizes > 2**32.
10525 (check_depth): Now ptrdiff_t, not int.
10526 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
10527 Adjust to new way of storing sizes. Check for size overflow bugs
10528 in rest of code.
10529 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
10530 slightly wrong anyway, as it missed one instance of
10531 XMALLOC_OVERRUN_CHECK_OVERHEAD.
10532 (refill_memory_reserve): Omit needless cast to size_t.
10533 (mark_object_loop_halt): Mark as externally visible.
10534
ac82cc6a
PE
10535 * xselect.c: Integer signedness and overflow fixes.
10536 (Fx_register_dnd_atom, x_handle_dnd_message):
10537 Use ptrdiff_t, not size_t, since we prefer signed.
10538 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
10539 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
10540 x_dnd_atoms_size and x_dnd_atoms_length.
10541
c2d1e36d
PE
10542 * doprnt.c: Prefer signed to unsigned when either works.
10543 * eval.c (verror):
10544 * doprnt.c (doprnt):
10545 * lisp.h (doprnt):
10546 * xdisp.c (vmessage):
10547 Use ptrdiff_t, not size_t, when using or implementing doprnt,
10548 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
10549 prefer signed arithmetic to avoid comparison confusion.
10550 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
10551 but is a bit tricky.
10552
0e926e56
PE
10553 Assume freestanding C89 headers, string.h, stdlib.h.
10554 * data.c, doprnt.c, floatfns.c, print.c:
10555 Include float.h unconditionally.
10556 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
10557 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
10558 * regex.c: Likewise for stddef.h, string.h.
10559 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
10560 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
10561 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
10562 (STDC_HEADERS): Remove obsolete defines.
10563 * sysdep.c: Include limits.h unconditionally.
10564
9cfdb3ec
PE
10565 Assume support for memcmp, memcpy, memmove, memset.
10566 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
10567 * regex.c (memcmp, memcpy):
10568 Remove; we assume C89 now.
10569
10570 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
10571 (__malloc_safe_bcopy): Remove; no longer needed.
10572
cf950e6b 10573 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
10574 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
10575 well either way, and we prefer signed to unsigned.
10576
dbf38e02
LMI
105772011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
10578
10579 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
10580 closes the connection while we're reading (bug#9182).
10581
d6f0886c 105822011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 10583
d6f0886c
JD
10584 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
10585 are specified (Bug#9168).
24e0f6b1 10586
2eb1f9e6
PE
105872011-07-25 Paul Eggert <eggert@cs.ucla.edu>
10588
10589 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
10590 Found by GCC static checking and --with-wide-int on a 32-bit host.
10591
22381272 105922011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
10593
10594 * xdisp.c (compute_display_string_pos): Fix logic of caching
10595 previous display string position. Initialize cached_prev_pos to
10596 -1. Fixes slow-down at the beginning of a buffer.
10597
f25e39b4
EZ
105982011-07-24 Eli Zaretskii <eliz@gnu.org>
10599
10600 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
10601 for attrs[LFACE_FONTSET_INDEX].
10602
04c4b52e
PE
106032011-07-23 Paul Eggert <eggert@cs.ucla.edu>
10604
10605 * xml.c (parse_region): Remove unused local
10606 that was recently introduced.
10607
c1734fbd
EZ
106082011-07-23 Eli Zaretskii <eliz@gnu.org>
10609
be18c5a5
EZ
10610 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
10611 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
10612
c1734fbd
EZ
10613 * xdisp.c (move_it_in_display_line_to): Record the best matching
10614 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
10615 exit if none of the characters scanned was an exact match.
10616 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
10617 when exact match is impossible due to invisible text, and the
10618 lines are truncated.
10619
a258d627
JD
106202011-07-23 Jan Djärv <jan.h.d@swipnet.se>
10621
10622 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
10623 for OSX >= 10.7.
10624
b6d5a689
EZ
106252011-07-22 Eli Zaretskii <eliz@gnu.org>
10626
0f74f785
EZ
10627 Fix a significant slow-down of cursor motion with C-n, C-p,
10628 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
10629 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 10630 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
10631 (next_element_from_buffer): Call compute_stop_pos_backwards to
10632 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
10633 base_level_stop.
10634 (reseat): Don't look for prev_stop, as that could mean a very long
10635 run.
10636 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
10637 <cached_disp_overlay_modiff>: Cache for last found display string
10638 position.
551918c1 10639 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
10640 about the same buffer in the same area of character positions, and
10641 the buffer wasn't changed since the time the display string
10642 position was cached.
551918c1 10643
b2d0c91a
EZ
106442011-07-22 Eli Zaretskii <eliz@gnu.org>
10645
10646 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
10647 is an integer, which is important for empty lines. (Bug#9149)
10648
043604ee
CY
106492011-07-22 Chong Yidong <cyd@stupidchicken.com>
10650
10651 * frame.c (Fmodify_frame_parameters): In tty case, update the
10652 default face if necessary (Bug#4238).
10653
da4adb04
CY
106542011-07-21 Chong Yidong <cyd@stupidchicken.com>
10655
10656 * editfns.c (Fstring_to_char): No need to explain what a character
10657 is in the docstring (Bug#6576).
10658
9abd0532
LMI
106592011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10660
10661 * xml.c (parse_region): Make sure we always return a tree.
10662
36881d16
HK
106632011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
10664
10665 * xml.c (parse_region): If a document contains only comments,
10666 return that, too.
10667
1e98674d
LMI
106682011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10669
10670 * xml.c (make_dom): Return comments, too.
10671
590bd467
PE
106722011-07-19 Paul Eggert <eggert@cs.ucla.edu>
10673
10674 Port to OpenBSD.
10675 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
10676 and the surrounding thread.
10677 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
10678 rather than fgets, and retry after EINTR. Otherwise, 'emacs
10679 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
10680 timer goes off.
10681 * s/openbsd.h (BROKEN_SIGIO): Define.
10682 * unexelf.c (unexec) [__OpenBSD__]:
10683 Don't update the .mdebug section of the Alpha COFF symbol table.
10684
f41628b2
LMI
106852011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10686
10687 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
10688 (bug#8460).
10689
b59b67c5
PE
106902011-07-18 Paul Eggert <eggert@cs.ucla.edu>
10691
15e3a074
PE
10692 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
10693 This fixes some race conditions on the permissions of any newly
10694 created file.
10695
41bed37d
PE
10696 * alloc.c (valid_pointer_p): Use pipe, not open.
10697 This fixes some permissions issues when debugging.
10698
b59b67c5
PE
10699 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
10700 If fchown fails to set both uid and gid, try to set just gid,
10701 as that is sometimes allowed. Adjust the file's mode to eliminate
10702 setuid or setgid bits that are inappropriate if fchown fails.
10703
925a6be7
SM
107042011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
10705
10706 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
10707 to compare Lisp_Objects.
10708 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
10709 global_gnutls_log_level, don't mistake it for a Lisp_Object.
10710 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
10711
52968808
AS
107122011-07-17 Andreas Schwab <schwab@linux-m68k.org>
10713
0a6a104b
AS
10714 * lread.c (read_integer): Unread even EOF character.
10715 (read1): Likewise. Properly record start position of symbol.
10716
52968808
AS
10717 * lread.c (read1): Read `#:' as empty uninterned symbol if no
10718 symbol character follows.
10719
9e381cdd
PE
107202011-07-17 Paul Eggert <eggert@cs.ucla.edu>
10721
10722 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
10723 This works around a problem with the previous change to Fcopy_file.
10724 Recent glibc declares fchown with __attribute__((warn_unused_result)),
10725 and without this change, GCC might complain about discarding
10726 fchown's return value.
10727
b5641435
JB
107282011-07-16 Juanma Barranquero <lekktu@gmail.com>
10729
10730 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
10731
a8031457
PE
107322011-07-16 Paul Eggert <eggert@cs.ucla.edu>
10733
10734 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
10735
dd889327
LMI
107362011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
10737
750c33f7
LMI
10738 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
10739 it's used from the C level.
10740
dd889327
LMI
10741 * process.c: Use the same condition for POLL_FOR_INPUT in both
10742 keyboard.c and process.c (bug#1858).
10743
87e86684
LM
107442011-07-09 Lawrence Mitchell <wence@gmx.li>
10745
10746 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
10747 (Fgnutls_boot): Use it.
10748
64348f40
AS
107492011-07-15 Andreas Schwab <schwab@linux-m68k.org>
10750
10751 * doc.c (Fsubstitute_command_keys): Revert last change.
10752
1d698799
LMI
107532011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
10754
f863868c
LMI
10755 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
10756 quotes the next character, and doesn't affect other longer
10757 sequences (bug#8935).
10758
1d698799
LMI
10759 * lread.c (syms_of_lread): Clarify that is isn't only
10760 `eval-buffer' and `eval-defun' that's affected by
10761 `lexical-binding' (bug#8460).
10762
aa4b6df6
EZ
107632011-07-15 Eli Zaretskii <eliz@gnu.org>
10764
10765 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 10766 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 10767
5d856da6
PE
107682011-07-14 Paul Eggert <eggert@cs.ucla.edu>
10769
ad6042bb
PE
10770 Fix minor problems found by static checking.
10771 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
10772 (elsz): Now a signed constant, not a size_t var. We prefer signed
10773 types to unsigned, to avoid integer comparison confusion. Without
10774 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
10775 "cannot optimize loop, the loop counter may overflow", a symptom
10776 of the confusion.
f00bbb22 10777 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
10778 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
10779
6468f31c
LMI
107802011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10781
49080b10
LMI
10782 * search.c (Fre_search_backward): Mention `case-fold-search' in
10783 all the re_search_* functions (bug#8138).
10784
6468f31c
LMI
10785 * keyboard.c (Fopen_dribble_file): Document when the file is
10786 closed (bug#8056).
10787
c965adc5
EZ
107882011-07-14 Eli Zaretskii <eliz@gnu.org>
10789
df9733bf
EZ
10790 * bidi.c (bidi_dump_cached_states): Fix format of displaying
10791 bidi_cache_idx.
10792
0bb23927
EZ
10793 Support bidi reordering of display and overlay strings.
10794 * xdisp.c (compute_display_string_pos)
10795 (compute_display_string_end): Accept additional argument STRING.
10796 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
10797 (reseat_to_string): Initialize bidi_it->string.s and
10798 bidi_it->string.schars.
10799 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
10800 NULL (avoids a crash in bidi_paragraph_init).
10801 Initialize itb.string.lstring.
0bb23927
EZ
10802 (init_iterator): Call bidi_init_it only of a valid
10803 buffer position was specified. Initialize paragraph_embedding to
10804 L2R.
10805 (reseat_to_string): Initialize the bidi iterator.
10806 (display_string): If we need to ignore text properties of
10807 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
10808 original value of -1 will not work with bidi.)
10809 (compute_display_string_pos): First arg is now struct
10810 `text_pos *'; all callers changed. Support display properties on
10811 Lisp strings.
10812 (compute_display_string_end): Support display properties on Lisp
10813 strings.
10814 (init_iterator, reseat_1, reseat_to_string): Initialize the
10815 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
10816 when iterating on a string not from display properties).
640c8776
SM
10817 (compute_display_string_pos, compute_display_string_end):
10818 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
10819 arrow keys.
10820 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
10821 base_level_stop; instead, set base_level_stop to BEGV.
10822 Fixes crashes in vertical-motion.
0bb23927
EZ
10823 (next_element_from_buffer): Improve commentary for when
10824 the iterator is before prev_stop.
10825 (init_iterator): Initialize bidi_p from the default value of
10826 bidi-display-reordering, not from buffer-local value. Use the
10827 buffer-local value only if initializing for buffer iteration.
10828 (handle_invisible_prop): Support invisible properties on strings
10829 that are being bidi-reordered.
10830 (set_iterator_to_next): Support bidi reordering of C strings and
10831 Lisp strings.
10832 (next_element_from_string): Support bidi reordering of Lisp
10833 strings.
10834 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
10835 (display_string): Support display of R2L glyph rows.
10836 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
10837 (init_iterator): Don't initialize it->bidi_p for strings
10838 here.
10839 (reseat_to_string): Initialize it->bidi_p for strings here.
10840 (next_element_from_string, next_element_from_c_string)
10841 (next_element_from_buffer): Add xassert's for correspondence
10842 between IT's object being iterated and it->bidi_it.string
10843 structure.
10844 (face_before_or_after_it_pos): Support bidi iteration.
10845 (next_element_from_c_string): Handle the case of the first string
10846 character that is not the first one in the visual order.
10847 (get_visually_first_element): New function, refactored from common
10848 parts of next_element_from_buffer, next_element_from_string, and
10849 next_element_from_c_string.
10850 (tool_bar_lines_needed, redisplay_tool_bar)
10851 (display_menu_bar): Force left-to-right direction. Add a FIXME
10852 comment for making that be controlled by a user option.
10853 (push_it, pop_it): Save and restore the state of the
10854 bidi iterator. Save and restore the bidi_p flag.
10855 (pop_it): Iterate out of display property for string iteration as
10856 well.
10857 (iterate_out_of_display_property): Support iteration over strings.
10858 (handle_single_display_spec): Set up it->bidi_it for iteration
10859 over a display string, and call bidi_init_it.
10860 (handle_single_display_spec, next_overlay_string)
10861 (get_overlay_strings_1, push_display_prop): Set up the bidi
10862 iterator for displaying display or overlay strings.
10863 (forward_to_next_line_start): Don't use the shortcut if
10864 bidi-iterating.
10865 (back_to_previous_visible_line_start): If handle_display_prop
10866 pushed the iterator stack, restore the internal state of the bidi
10867 iterator by calling bidi_pop_it same number of times.
10868 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
10869 and we are bidi-iterating, don't decrement the iterator position;
10870 instead, set the first_elt flag in the bidi iterator, to produce
10871 the same effect.
10872 (reseat_1): Remove redundant setting of string_from_display_prop_p.
10873 (push_display_prop): xassert that we are iterating a buffer.
10874 (push_it, pop_it): Save and restore paragraph_embedding member.
10875 (handle_single_display_spec, next_overlay_string)
10876 (get_overlay_strings_1, reseat_1, reseat_to_string)
10877 (push_display_prop): Set up the `unibyte' member of bidi_it.string
10878 correctly. Don't assume unibyte strings are not bidi-reordered.
10879 (compute_display_string_pos)
10880 (compute_display_string_end): Fix handling the case of C string.
10881 (push_it, pop_it): Save and restore from_disp_prop_p.
10882 (handle_single_display_spec, push_display_prop): Set the
10883 from_disp_prop_p flag.
10884 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
10885 (pop_it): Call iterate_out_of_display_property only if we are
10886 popping after iteration over a string that came from a display
10887 property. Fix a typo in popping stretch info. Add an assertion
10888 for verifying that the iterator position is in sync with the bidi
10889 iterator.
10890 (handle_single_display_spec, get_overlay_strings_1)
10891 (push_display_prop): Fix initialization of paragraph direction for
10892 string when that of the parent object is not yet determined.
10893 (reseat_1): Call bidi_init_it to resync the bidi
10894 iterator with IT's position. (Bug#7616)
10895 (find_row_edges): If ROW->start.pos gives position
10896 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
10897 (handle_stop, back_to_previous_visible_line_start, reseat_1):
10898 Reset the from_disp_prop_p flag.
10899 (SAVE_IT, RESTORE_IT): New macros.
10900 (pos_visible_p, face_before_or_after_it_pos)
10901 (back_to_previous_visible_line_start)
10902 (move_it_in_display_line_to, move_it_in_display_line)
10903 (move_it_to, move_it_vertically_backward, move_it_by_lines)
10904 (try_scrolling, redisplay_window, display_line): Use them when
10905 saving a temporary copy of the iterator and restoring it back.
10906 (back_to_previous_visible_line_start, reseat_1)
10907 (init_iterator): Empty the bidi cache "stack".
10908 (move_it_in_display_line_to): If iterator ended up at
10909 EOL, but we never saw any buffer positions smaller than
10910 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
10911 motion in bidi-reordered lines.
10912 (move_it_in_display_line_to): Record prev_method and prev_pos
10913 immediately before the call to set_iterator_to_next. Fixes cursor
10914 motion in bidi-reordered lines with stretch glyphs and strings
10915 displayed in margins. (Bug#8133) (Bug#8867)
10916 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
10917 TO_CHARPOS.
640c8776
SM
10918 (pos_visible_p): Support positions in bidi-reordered lines.
10919 Save and restore bidi cache.
0bb23927
EZ
10920
10921 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
10922 (bidi_paragraph_info): Delete unused struct.
10923 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
10924 (bidi_cache_start): New variable.
10925 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
10926 to zero.
10927 (bidi_cache_fetch_state, bidi_cache_search)
10928 (bidi_cache_find_level_change, bidi_cache_iterator_state)
10929 (bidi_cache_find, bidi_peek_at_next_level)
10930 (bidi_level_of_next_char, bidi_find_other_level_edge)
10931 (bidi_move_to_visually_next): Compare cache index with
10932 bidi_cache_start rather than with zero.
10933 (bidi_fetch_char): Accept new argument STRING; all callers
10934 changed. Support iteration over a string. Support strings with
10935 display properties. Support unibyte strings. Fix the type of
10936 `len' according to what STRING_CHAR_AND_LENGTH expects.
10937 (bidi_paragraph_init, bidi_resolve_explicit_1)
10938 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
10939 (bidi_level_of_next_char, bidi_move_to_visually_next):
10940 Support iteration over a string.
0bb23927
EZ
10941 (bidi_set_sor_type, bidi_resolve_explicit_1)
10942 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
10943 can now be zero (for strings); special values 0 and -1 were
10944 changed to -1 and -2, respectively.
10945 (bidi_char_at_pos): New function.
10946 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
10947 Call it instead of FETCH_MULTIBYTE_CHAR.
10948 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
10949 initialized to valid values.
10950 (bidi_init_it): Don't initialize charpos and bytepos with invalid
10951 values.
10952 (bidi_level_of_next_char): Allow the sentinel "position" to pass
10953 the test for valid cached positions. Fix the logic for looking up
10954 the sentinel state in the cache. GCPRO the Lisp string we are
10955 iterating.
10956 (bidi_push_it, bidi_pop_it): New functions.
10957 (bidi_initialize): Initialize the bidi cache start stack pointer.
10958 (bidi_cache_ensure_space): New function, refactored from part of
10959 bidi_cache_iterator_state. Don't assume the required size is just
10960 one BIDI_CACHE_CHUNK away.
10961 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
10962 (bidi_count_bytes, bidi_char_at_pos): New functions.
10963 (bidi_cache_search): Don't assume bidi_cache_last_idx is
10964 always valid if bidi_cache_idx is valid.
10965 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
10966 is valid if it's going to be used.
10967 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
10968 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
10969 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10970 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
10971 (bidi_find_other_level_edge, bidi_cache_start_stack):
10972 All variables related to cache indices are now EMACS_INT.
c965adc5 10973
0bb23927
EZ
10974 * dispextern.h (struct bidi_string_data): New structure.
10975 (struct bidi_it): New member `string'. Make flag members be 1-bit
10976 fields, and put them last in the struct.
640c8776
SM
10977 (compute_display_string_pos, compute_display_string_end):
10978 Update prototypes.
0bb23927
EZ
10979 (bidi_push_it, bidi_pop_it): Add prototypes.
10980 (struct iterator_stack_entry): New members bidi_p,
10981 paragraph_embedding, and from_disp_prop_p.
10982 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
10983 (bidi_shelve_cache, bidi_unshelve_cache):
10984 Declare prototypes.
0bb23927
EZ
10985
10986 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
10987 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
10988 and vector-like objects.
10989
10990 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
10991 cache around display iteration.
10992
10993 * window.c (Fwindow_end, window_scroll_pixel_based)
10994 (displayed_window_lines, Frecenter): Save and restore the bidi
10995 cache around display iteration.
10996
3bbd2265
LMI
109972011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10998
10999 * editfns.c (Fdelete_region): Clarify the use of the named
11000 parameters (bug#6788).
11001
adc47434
MR
110022011-07-14 Martin Rudalics <rudalics@gmx.at>
11003
11004 * indent.c (Fvertical_motion): Set and restore w->pointm when
11005 saving and restoring the window's buffer (Bug#9006).
11006
837c31f8
LMI
110072011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
11008
11009 * editfns.c (Fstring_to_char): Clarify just what is returned
11010 (bug#6576). Text by Eli Zaretskii.
11011
ac389d0c
JB
110122011-07-13 Juanma Barranquero <lekktu@gmail.com>
11013
11014 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
11015
0be0ce47
EZ
110162011-07-13 Eli Zaretskii <eliz@gnu.org>
11017
11018 * buffer.c (mmap_find): Fix a typo.
11019
cd18e7e3
JB
110202011-07-13 Johan Bockgård <bojohan@gnu.org>
11021
11022 Fix execution of x selection hooks.
11023 * xselect.c (Qx_lost_selection_functions)
11024 (Qx_sent_selection_functions): New vars.
11025 (syms_of_xselect): DEFSYM them.
11026 (x_handle_selection_request): Pass Qx_sent_selection_functions
11027 rather than Vx_sent_selection_functions to Frun_hook_with_args.
11028 (x_handle_selection_clear,x_clear_frame_selections):
11029 Pass Qx_lost_selection_functions rather than
11030 Vx_lost_selection_functions to Frun_hook_with_args.
11031
47ea7f44
PE
110322011-07-13 Paul Eggert <eggert@cs.ucla.edu>
11033
ac389d0c 11034 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
11035 The old code sometimes used this field without initializing it.
11036
47ea7f44
PE
11037 * alloc.c (gc_sweep): Don't read past end of array.
11038 In theory, the old code could also have corrupted Emacs internals,
11039 though it'd be very unlikely.
11040
bc985c87
AS
110412011-07-12 Andreas Schwab <schwab@linux-m68k.org>
11042
11043 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 11044 argument. (Bug#4026)
bc985c87 11045
0cf34688
LMI
110462011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
11047
b3dadd76
LMI
11048 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
11049 key" (bug#4257).
11050
0cf34688
LMI
11051 * window.c (Fset_window_start): Doc fix (bug#4199).
11052 (Fset_window_hscroll): Ditto.
11053
270768cd
PE
110542011-07-12 Paul Eggert <eggert@cs.ucla.edu>
11055
077e3dda 11056 Fix minor new problems caught by GCC 4.6.1.
270768cd 11057 * term.c (init_tty): Remove unused local.
490011a6 11058 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 11059 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 11060 not used otherwise.
270768cd 11061
b1f58454
CY
110622011-07-12 Chong Yidong <cyd@stupidchicken.com>
11063
11064 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
11065
22b9578d
LMI
110662011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
11067
6e70ab07
LMI
11068 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
11069 are the mini-buffer and the echo area (bug#3320).
11070
22b9578d
LMI
11071 * term.c (init_tty): Remove support for supdup, c10 and perq
11072 terminals, which are no longer supported (bug#1482).
11073
8974cc9f
JB
110742011-07-10 Johan Bockgård <bojohan@gnu.org>
11075
11076 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
11077
a560d974
JD
110782011-07-10 Jan Djärv <jan.h.d@swipnet.se>
11079
11080 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
11081 for non-popups (Bug#3642).
11082
1dae0f0a
AS
110832011-07-10 Andreas Schwab <schwab@linux-m68k.org>
11084
268c2c36 11085 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 11086 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
11087 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
11088 * cm.c (losecursor): Likewise.
1dae0f0a
AS
11089 * data.c (fmod): Likewise.
11090 * dispnew.c (swap_glyphs_in_rows): Likewise.
11091 * emacs.c (memory_warning_signal): Likewise.
11092 * floatfns.c (float_error): Likewise.
11093 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
11094 (otf_open, font_otf_capability, generate_otf_features)
11095 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
11096 Likewise.
11097 * image.c (pbm_read_file): Likewise.
11098 * indent.c (string_display_width): Likewise.
11099 * intervals.c (check_for_interval, search_for_interval)
11100 (inc_interval_count, count_intervals, root_interval)
11101 (adjust_intervals_for_insertion, make_new_interval): Likewise.
11102 * lread.c (defalias): Likewise.
268c2c36 11103 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
11104 * regex.c (set_image_of_range_1, set_image_of_range)
11105 (regex_grow_registers): Likewise.
11106 * sysdep.c (strerror): Likewise.
11107 * termcap.c (valid_filename_p, tprint, main): Likewise.
11108 * tparam.c (main): Likewise.
11109 * unexhp9k800.c (run_time_remap, save_data_space)
11110 (update_file_ptrs, read_header, write_header, calculate_checksum)
11111 (copy_file, copy_rest, display_header): Likewise.
11112 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
11113 Likewise.
11114 * xdisp.c (check_it): Likewise.
11115 * xfaces.c (register_color, unregister_color, unregister_colors):
11116 Likewise.
11117 * xfns.c (print_fontset_result): Likewise.
11118 * xrdb.c (member, fatal, main): Likewise.
11119
99033785
PE
111202011-07-10 Paul Eggert <eggert@cs.ucla.edu>
11121
11122 Fix minor problems found by static checking (Bug#9031).
11123 * chartab.c (char_table_set_range, map_sub_char_table):
11124 Remove unused locals.
11125 (uniprop_table): Now static.
11126 * composite.c (_work_char): Remove unused static var.
11127
9cb2ac56
JB
111282011-07-09 Juanma Barranquero <lekktu@gmail.com>
11129
11130 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
11131
f25661f0
JD
111322011-07-09 Jan Djärv <jan.h.d@swipnet.se>
11133
11134 * gtkutil.c (qttip_cb): Remove code without function.
11135
8278c4fe
EZ
111362011-07-09 Eli Zaretskii <eliz@gnu.org>
11137
11138 * w32.c (pthread_sigmask): New stub.
11139
1692ae2d 111402011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 11141
8a6ebd58 11142 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
11143 sigprocmask is portable only for single-threaded applications, and
11144 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
11145 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
11146 (LIBES): Use it.
11147 * callproc.c (Fcall_process):
11148 * process.c (create_process):
11149 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
11150 Use pthread_sigmask, not sigprocmask.
123403e4 11151
1b854618
JD
111522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11153
11154 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
11155 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
11156 wrong (Bug#8591).
11157
3fe4b549
JD
111582011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11159
0ce7e563
JD
11160 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
11161 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
11162 (xg_hide_tooltip): Fix comment.
11163
3fe4b549
JD
11164 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
11165 in registerServicesMenuSendTypes.
11166 (validRequestorForSendType): Don't check ns_return_types.
11167
11168 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
11169 ns_return_type.
11170
5df75e47
JR
111712011-07-08 Jason Rumney <jasonr@gnu.org>
11172
22610910
JR
11173 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
11174 SH_SHOW for hidden windows (Bug#5482).
11175
5df75e47
JR
11176 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
11177 frame struct members of non-existent frames (Bug#6284).
11178
699c10bd
JD
111792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11180
4393663b
JD
11181 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
11182 variable firstTime not needed on OSX >= 10.6.
11183 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
11184 >= 10.5. Use setKnobProportion, setDoubleValue.
11185
11186 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
11187 (MAC_OS_X_VERSION_10_5): Define if not defined.
11188 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
11189 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
11190 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
11191
11192 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 11193 cString and lossyCString on OSX >= 10.4.
4393663b 11194
58179cce 11195 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
11196 sizeToFit on OSX >= 10.2.
11197
11198 * nsimage.m (allocInitFromFile): Don't use deprecated method
11199 bestRepresentationForDevice on OSX >= 10.6.
11200
11201 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
11202 to avoid warning.
11203
11204 * emacs.c: Declare unexec_init_emacs_zone.
11205
a63e0781
JD
11206 * nsgui.h: Fix compiler warning about gnulib redefining verify.
11207
699c10bd
JD
11208 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
11209
11210 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
11211 on svcsMenu (Bug#8842).
11212
11213 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
11214 ns_return_types.
11215 (Fns_list_services): Just return Qnil on 10.6, code not working there.
11216
11217 * nsterm.m (QUTF8_STRING): Declare.
11218 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
11219 (validRequestorForSendType): Return type is (id).
11220 Change indexOfObjectIdenticalTo to indexOfObject.
11221 Check if we have local selection before returning self (Bug#8842).
11222 (writeSelectionToPasteboard): Put local selection into paste board
11223 if we have a local selection (Bug#8842).
11224 (syms_of_nsterm): DEFSYM QUTF8_STRING.
11225
11226 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
11227 (ns_get_local_selection): Declare.
11228
54e10184
LMI
112292011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
11230
9888ff71
LMI
11231 * keymap.c (describe_map_tree): Don't insert a double newline at
11232 the end of the buffer (bug#1169) and return whether we inserted
11233 something.
11234
54e10184
LMI
11235 * callint.c (Fcall_interactively): Change "reading args" to
11236 "providing args" to try to clarify what it does (bug#1010).
11237
15fa4783
KH
112382011-07-07 Kenichi Handa <handa@m17n.org>
11239
11240 * composite.c (composition_compute_stop_pos): Ignore a static
11241 composition starting before CHARPOS (Bug#8915).
11242
11243 * xdisp.c (handle_composition_prop): Likewise.
11244
a8815b00
EZ
112452011-07-07 Eli Zaretskii <eliz@gnu.org>
11246
11247 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
11248 (Bug#9015)
11249
ef7b981d 112502011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
11251
11252 * character.h (unicode_category_t): New enum type.
11253
11254 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
11255 (Qchar_code_property_table): New variable.
11256 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
11257 (UNIPROP_COMPRESSED_FORM_P): New macros.
11258 (char_table_ascii): Uncompress the compressed values.
11259 (sub_char_table_ref): New arg is_uniprop. Callers changed.
11260 Uncompress the compressed values.
ac389d0c 11261 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
11262 (char_table_ref_and_range): Uncompress the compressed values.
11263 (sub_char_table_set): New arg is_uniprop. Callers changed.
11264 Uncompress the compressed values.
11265 (sub_char_table_set_range): Args changed. Callers changed.
11266 (char_table_set_range): Adjuted for the above change.
11267 (map_sub_char_table): Delete args default_val and parent. Add arg
11268 top. Give decoded values to a Lisp function.
640c8776 11269 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
11270 values to a Lisp function. Gcpro more variables.
11271 (uniprop_table_uncompress)
11272 (uniprop_decode_value_run_length): New functions.
11273 (uniprop_decoder, uniprop_decoder_count): New variables.
11274 (uniprop_get_decoder, uniprop_encode_value_character)
11275 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
11276 New functions.
11277 (uniprop_encoder, uniprop_encoder_count): New variables.
11278 (uniprop_get_encoder, uniprop_table)
11279 (Funicode_property_table_internal, Fget_unicode_property_internal)
11280 (Fput_unicode_property_internal): New functions.
11281 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
11282 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 11283 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
11284 char-code-property-alist.
11285
640c8776 11286 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
11287 Vunicode_category_table.
11288
640c8776 11289 * font.c (font_range): Adjust for the change of
c805dec0
KH
11290 Vunicode_category_table.
11291
76b397fb
DN
112922011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
11293
11294 * m/iris4d.h: Remove file, move contents ...
11295 * s/irix6-5.h: ... here.
11296
22b4128e
PE
112972011-07-06 Paul Eggert <eggert@cs.ucla.edu>
11298
11299 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
11300 * alloc.c (mark_buffer):
11301 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
11302 (clone_per_buffer_values): Don't assume that
22b4128e
PE
11303 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
11304 This isn't true in general, and it's particularly not true
11305 if Emacs is configured with --with-wide-int.
11306 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
11307 New macros, used in the buffer.c change.
11308
869795d6
JD
113092011-07-05 Jan Djärv <jan.h.d@swipnet.se>
11310
11311 * xsettings.c: Use both GConf and GSettings if both are available.
11312 (store_config_changed_event): Add comment.
11313 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
11314 (store_tool_bar_style_changed): New functions.
5e617bc2 11315 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
11316 (struct xsettings): Move font inside HAVE_XFT.
11317 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 11318 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 11319 Move inside HAVE_XFT.
640c8776 11320 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
11321 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
11322 also.
11323 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 11324 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 11325 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
11326 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
11327 (parse_settings): Move check for font inside HAVE_XFT.
11328 (read_settings, apply_xft_settings): Add comment.
11329 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
11330 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
11331 call store_font_name_changed.
11332 (xft_settings_event): Add comment.
11333 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
11334 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
11335 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
11336 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
11337 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
11338 (xsettings_get_system_font, xsettings_get_system_normal_font):
11339 Add comment.
869795d6 11340
d8ed26bd
PE
113412011-07-05 Paul Eggert <eggert@cs.ucla.edu>
11342
11343 Random fixes. E.g., (random) never returned negative values.
11344 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
11345 subseconds part to the entropy, as that's a bit more random.
11346 Prefer signed to unsigned, since the signedness doesn't matter and
11347 in general we prefer signed. When given a limit, use a
11348 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
11349 latter isn't right if USE_2_TAGS_FOR_INTS.
11350 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
11351 not 0..VALMASK. Don't discard "excess" bits that random () returns.
11352
cabf1cac
SM
113532011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
11354
11355 * textprop.c (text_property_stickiness):
11356 Obey Vtext_property_default_nonsticky.
11357 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
11358 * w32fns.c (syms_of_w32fns):
11359 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
11360
6e9b2be9
PE
113612011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11362
11363 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
11364 This is more efficient than Ffile_directory_p and avoids a minor race.
11365
90186c68
LMI
113662011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
11367
7c301272
LMI
11368 * buffer.c (Foverlay_put): Say what the return value is
11369 (bug#7835).
11370
c4f2d8d4
LMI
11371 * fileio.c (barf_or_query_if_file_exists): Check first if the file
11372 is a directory before asking whether to use the file name
11373 (bug#7564).
ad637907
LMI
11374 (barf_or_query_if_file_exists): Make the "File is a directory"
11375 error be more correct.
c4f2d8d4 11376
90186c68
LMI
11377 * fns.c (Frequire): Remove the mention of the .gz files, since
11378 that's installation-specific, but keep the mention of
11379 `get-load-suffixes'.
11380
da64016e
PE
113812011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11382
11383 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
11384 Report string overflow if the output is too long.
11385
7d47b580
JB
113862011-07-04 Juanma Barranquero <lekktu@gmail.com>
11387
a555cb87
JB
11388 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
11389 (syms_of_gnutls): Remove duplicate DEFSYM for
11390 Qgnutls_bootprop_verify_hostname_error, an error for
11391 Qgnutls_bootprop_verify_error (which is no longer used).
11392
7d47b580
JB
11393 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
11394 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
11395 Also (re)move comments that are misplaced or no longer relevant.
11396
1e49bfab
LMI
113972011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11398
11399 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
11400
1485f4c0
CY
114012011-07-03 Chong Yidong <cyd@stupidchicken.com>
11402
11403 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
11404 and background color parameters if they have been changed.
11405
a9ab721e
LMI
114062011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11407
11408 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
11409
cf7cff57
PE
114102011-07-03 Paul Eggert <eggert@cs.ucla.edu>
11411
2e13213d
PE
11412 * xsettings.c (SYSTEM_FONT): Define only when used.
11413 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
11414
cf7cff57
PE
11415 * keymap.c (access_keymap_1): Now static.
11416
7a8e04f7
CY
114172011-07-02 Chong Yidong <cyd@stupidchicken.com>
11418
11419 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
11420 leave any prefix arg for the up event (Bug#1586).
11421
61352f62
LMI
114222011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
11423
69bb1ef7
LMI
11424 * lread.c (syms_of_lread): Mention single symbols defined by
11425 `defvar' or `defconst' (bug#7154).
11426
61352f62 11427 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 11428 (Frequire): Mention get-load-suffixes.
61352f62 11429
28545e04
MR
114302011-07-02 Martin Rudalics <rudalics@gmx.at>
11431
11432 * window.h (window): Remove clone_number slot.
11433 * window.c (Fwindow_clone_number, Fset_window_clone_number):
11434 Remove.
11435 (make_parent_window, make_window, saved_window)
11436 (Fset_window_configuration, save_window_save): Don't deal with
11437 clone numbers.
11438 * buffer.c (Qclone_number): Remove declaration.
11439 (sort_overlays, overlay_strings): Don't deal with clone numbers.
11440
3349e122
SM
114412011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
11442
11443 Add multiple inheritance to keymaps.
11444 * keymap.c (Fmake_composed_keymap): New function.
11445 (Fset_keymap_parent): Simplify.
11446 (fix_submap_inheritance): Remove.
11447 (access_keymap_1): New function extracted from access_keymap to handle
11448 embedded parents and handle lists of maps.
11449 (access_keymap): Use it.
11450 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
11451 (Fcopy_keymap): Handle embedded parents.
11452 (Fcommand_remapping, define_as_prefix): Simplify.
11453 (Fkey_binding): Simplify.
11454 (syms_of_keymap): Move minibuffer-local-completion-map,
11455 minibuffer-local-filename-completion-map,
11456 minibuffer-local-must-match-map, and
11457 minibuffer-local-filename-must-match-map to Elisp.
11458 (syms_of_keymap): Defsubr make-composed-keymap.
11459 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
11460 (parse_menu_item): Trivial simplification.
11461
3279eb87
GM
114622011-07-01 Glenn Morris <rgm@gnu.org>
11463
11464 * Makefile.in (SETTINGS_LIBS): Fix typo.
11465
39cb9e56 114662011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
11467
11468 * coding.c (Fencode_coding_string): Record the last coding system
11469 used, as the function doc string says (bug#8738).
11470
0949d2b6
JD
114712011-07-01 Jan Djärv <jan.h.d@swipnet.se>
11472
11473 * xsettings.c (store_monospaced_changed): Take new font as arg and
11474 check for change against current_mono_font.
11475 (EMACS_TYPE_SETTINGS): Remove this and related defines.
11476 (emacs_settings_constructor, emacs_settings_get_property)
11477 (emacs_settings_set_property, emacs_settings_class_init)
11478 (emacs_settings_init, gsettings_obj): Remove.
11479 (something_changedCB): New function for HAVE_GSETTINGS.
11480 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
11481 with value as argument.
11482 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
11483 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 11484 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
11485 "changed".
11486
11487 * xgselect.c: Add defined (HAVE_GSETTINGS).
11488 (xgselect_initialize): Ditto.
11489
11490 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
11491 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
11492 xg_select.
11493
bbc6b304
PE
114942011-07-01 Paul Eggert <eggert@cs.ucla.edu>
11495
11496 * eval.c (struct backtrace): Simplify and port the data structure.
11497 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
11498 signed bit field, as this assumption is not portable and it makes
11499 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
11500 "char debug_on_exit : 1" as this is not portable either; instead,
11501 use the portable "unsigned int debug_on_exit : 1". Remove unused
11502 member evalargs. Remove obsolete comments about cc bombing out.
11503
9851bfc5
JD
115042011-06-30 Jan Djärv <jan.h.d@swipnet.se>
11505
51bb811f 11506 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
11507 Let HAVE_GSETTINGS override HAVE_GCONF.
11508 (store_monospaced_changed): New function.
11509 (EMACS_SETTINGS): A new type derived from GObject to handle
11510 GSettings notifications.
11511 (emacs_settings_constructor, emacs_settings_get_property)
11512 (emacs_settings_set_property, emacs_settings_class_init):
11513 New functions.
11514 (gsettings_client, gsettings_obj): New variables.
11515 (GSETTINGS_SCHEMA): New define.
11516 (something_changedCB): Call store_monospaced_changed.
11517 (init_gsettings): New function.
11518 (xsettings_initialize): Call init_gsettings.
11519 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
11520 to NULL.
11521
640c8776 11522 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
11523 GCONF_CFLAGS/LIBS.
11524
5386012d
MR
115252011-06-29 Martin Rudalics <rudalics@gmx.at>
11526
11527 * window.c (resize_root_window, grow_mini_window)
11528 (shrink_mini_window): Rename Qresize_root_window to
11529 Qwindow_resize_root_window and Qresize_root_window_vertically to
11530 Qwindow_resize_root_window_vertically.
11531
f13e0b08
PE
115322011-06-28 Paul Eggert <eggert@cs.ucla.edu>
11533
11534 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
11535
94515237
JB
115362011-06-27 Juanma Barranquero <lekktu@gmail.com>
11537
11538 * makefile.w32-in: Redesign dependencies so they reflect more
11539 clearly which files are directly included by each source file,
11540 and not through other includes.
11541
e43b6e43
MR
115422011-06-27 Martin Rudalics <rudalics@gmx.at>
11543
11544 * buffer.c (Qclone_number): Declare static and DEFSYM it.
11545 (sort_overlays, overlay_strings): When an overlay's clone number
11546 matches the window's clone number process the overlay even if
11547 the overlay's window property doesn't match the current window.
11548
d68443dc
MR
11549 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
11550 (Fwindow_hchild): Rename to Fwindow_left_child.
11551 (Fwindow_next): Rename to Fwindow_next_sibling.
11552 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
11553 (resize_window_check): Rename to window_resize_check.
11554 (resize_window_apply): Rename to window_resize_apply.
11555 (Fresize_window_apply): Rename to Fwindow_resize_apply.
11556 (Fdelete_other_windows_internal, resize_frame_windows)
11557 (Fsplit_window_internal, Fdelete_window_internal)
11558 (grow_mini_window, shrink_mini_window)
11559 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 11560
c7e73be5
JD
115612011-06-26 Jan Djärv <jan.h.d@swipnet.se>
11562
11563 * emacsgtkfixed.h: State that this is only used with Gtk+3.
11564 (emacs_fixed_set_min_size): Remove.
11565 (emacs_fixed_new): Take frame as argument.
11566
11567 * emacsgtkfixed.c: State that this is only used with Gtk+3.
11568 (_EmacsFixedPrivate): Remove minwidth/height.
11569 Add struct frame *f.
11570 (emacs_fixed_init): Initialize priv->f.
11571 (get_parent_class, emacs_fixed_set_min_size): Remove.
11572 (emacs_fixed_new): Set priv->f to argument.
11573 (emacs_fixed_get_preferred_width)
11574 (emacs_fixed_get_preferred_height): Use min_width/height from
11575 frames size_hint to set minimum and natural (Bug#8919).
11576 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
11577 and use min_width/height from frames size_hint to set
11578 min_width/height (Bug#8919).
11579
11580 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
11581 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
11582 Fix indentation.
c7e73be5 11583
cf99dcf8
EZ
115842011-06-26 Eli Zaretskii <eliz@gnu.org>
11585
11586 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
11587 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
11588 called at ZV.
11589
029529ac
CY
115902011-06-26 Chong Yidong <cyd@stupidchicken.com>
11591
11592 * process.c (wait_reading_process_output): Bypass select if
11593 waiting for a cell while ignoring keyboard input, and input is
11594 pending. Suggested by Jan Djärv (Bug#8869).
11595
7a7ef429
PE
115962011-06-25 Paul Eggert <eggert@cs.ucla.edu>
11597
11598 Use gnulib's dup2 module instead of rolling our own.
11599 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
11600
11fdef7d 116012011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
11602
11603 * dispnew.c (scrolling_window): Before scrolling, turn off a
11604 mouse-highlight in the window being scrolled.
11605
cd3520a4
JB
116062011-06-24 Juanma Barranquero <lekktu@gmail.com>
11607
11608 Move DEFSYM to lisp.h and use everywhere.
11609
11610 * character.h (DEFSYM): Move declaration...
11611 * lisp.h (DEFSYM): ...here.
11612
11613 * gnutls.c:
11614 * minibuf.c:
11615 * w32menu.c:
11616 * w32proc.c:
11617 * w32select.c: Don't include character.h.
11618
11619 * alloc.c (syms_of_alloc):
11620 * buffer.c (syms_of_buffer):
11621 * bytecode.c (syms_of_bytecode):
11622 * callint.c (syms_of_callint):
11623 * casefiddle.c (syms_of_casefiddle):
11624 * casetab.c (init_casetab_once):
11625 * category.c (init_category_once, syms_of_category):
11626 * ccl.c (syms_of_ccl):
11627 * cmds.c (syms_of_cmds):
11628 * composite.c (syms_of_composite):
11629 * dbusbind.c (syms_of_dbusbind):
11630 * dired.c (syms_of_dired):
11631 * dispnew.c (syms_of_display):
11632 * doc.c (syms_of_doc):
11633 * editfns.c (syms_of_editfns):
11634 * emacs.c (syms_of_emacs):
11635 * eval.c (syms_of_eval):
11636 * fileio.c (syms_of_fileio):
11637 * fns.c (syms_of_fns):
11638 * frame.c (syms_of_frame):
11639 * fringe.c (syms_of_fringe):
11640 * insdel.c (syms_of_insdel):
11641 * keymap.c (syms_of_keymap):
11642 * lread.c (init_obarray, syms_of_lread):
11643 * macros.c (syms_of_macros):
11644 * msdos.c (syms_of_msdos):
11645 * print.c (syms_of_print):
11646 * process.c (syms_of_process):
11647 * search.c (syms_of_search):
11648 * sound.c (syms_of_sound):
11649 * syntax.c (init_syntax_once, syms_of_syntax):
11650 * terminal.c (syms_of_terminal):
11651 * textprop.c (syms_of_textprop):
11652 * undo.c (syms_of_undo):
11653 * w32.c (globals_of_w32):
11654 * window.c (syms_of_window):
11655 * xdisp.c (syms_of_xdisp):
11656 * xfaces.c (syms_of_xfaces):
11657 * xfns.c (syms_of_xfns):
11658 * xmenu.c (syms_of_xmenu):
11659 * xsettings.c (syms_of_xsettings):
11660 * xterm.c (syms_of_xterm): Use DEFSYM.
11661
4228cf16
TZ
116622011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
11663
cd3520a4 11664 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 11665
7fcccf1e
PE
116662011-06-23 Paul Eggert <eggert@cs.ucla.edu>
11667
7efb4e0e
PE
11668 Integer and buffer overflow fixes (Bug#8873).
11669
ff5844ad
PE
11670 * print.c (printchar, strout): Check for string overflow.
11671 (PRINTPREPARE, printchar, strout):
11672 Don't set size unless allocation succeeds.
11673
90532f02
PE
11674 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
11675 for sizes. Check for string overflow more accurately.
11676 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
11677
6d84508d
PE
11678 * macros.c: Integer and buffer overflow fixes.
11679 * keyboard.h (struct keyboard.kbd_macro_bufsize):
11680 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
11681 Use ptrdiff_t, not int, for sizes.
11682 Don't increment bufsize until after realloc succeeds.
11683 Check for size-calculation overflow.
11684 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
11685
437b2cb4
PE
11686 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
11687
8b9ac8b4
PE
11688 * lread.c: Integer overflow fixes.
11689 (read_integer): Radix is now EMACS_INT, not int,
11690 to improve quality of diagnostics for out-of-range radices.
11691 Calculate buffer size correctly for out-of-range radices.
11692 (read1): Check for integer overflow in radices, and in
11693 read-circle numbers.
82cb60d3
PE
11694 (read_escape): Avoid int overflow.
11695 (Fload, openp, read_buffer_size, read1)
11696 (substitute_object_recurse, read_vector, read_list, map_obarray):
11697 Use ptrdiff_t, not int, for sizes.
11698 (read1): Use EMACS_INT, not int, for sizes.
20270765 11699 Check for size overflow.
8b9ac8b4 11700
7fcccf1e
PE
11701 * image.c (cache_image): Check for size arithmetic overflow.
11702
bfbbd7e7
PE
11703 * lread.c: Integer overflow issues.
11704 (saved_doc_string_size, saved_doc_string_length)
11705 (prev_saved_doc_string_size, prev_saved_doc_string_length):
11706 Now ptrdiff_t, not int.
11707 (read1): Don't assume doc string length fits in int. Check for
11708 out-of-range doc string lengths.
11709 (read_list): Don't assume file position fits in int.
39019e54 11710 (read_escape): Check for hex character overflow.
bfbbd7e7 11711
4e323265
LL
117122011-06-22 Leo Liu <sdl.web@gmail.com>
11713
11714 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
11715 Move to minibuffer.el.
11716
85fece3e
PE
117172011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11718
20b84ce9 11719 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
11720 The following patches are for when GLYPH_DEBUG && !XASSERT.
11721 * dispextern.h (trace_redisplay_p, dump_glyph_string):
11722 * dispnew.c (flush_stdout):
11723 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
11724 Mark as externally visible.
11725 * dispnew.c (check_window_matrix_pointers): Now static.
11726 * dispnew.c (window_to_frame_vpos):
11727 * xfns.c (unwind_create_frame):
11728 * xterm.c (x_check_font): Remove unused local.
11729 * scroll.c (CHECK_BOUNDS):
11730 * xfaces.c (cache_fache): Rename local to avoid shadowing.
11731 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
11732 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
11733 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
11734 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
11735 Now static.
11736 (debug_method_add): Use va_list and vsprintf rather than relying
11737 on undefined behavior with wrong number of arguments.
11738 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
11739 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
11740 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
11741 since we're not interested in debugging glyphs with old libraries.
11742 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
11743 GCC 4.6.0's static checking.
11744
0766b489
PE
117452011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11746
31fd4b32
PE
11747 Integer overflow and signedness fixes (Bug#8873).
11748 A few related buffer overrun fixes, too.
11749
b79e8648
PE
11750 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
11751
0766b489
PE
11752 * dispextern.h (struct face.stipple):
11753 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
11754 (x_bitmap_mask, x_allocate_bitmap_record)
11755 (x_create_bitmap_from_data, x_create_bitmap_from_file)
11756 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
11757 (x_create_bitmap_from_xpm_data):
11758 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
11759 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
11760 (.bitmaps_last):
11761 * xfaces.c (load_pixmap):
11762 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
11763 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
11764 (.bitmaps_last, struct x_output.icon_bitmap):
11765 Use ptrdiff_t, not int, for bitmap indexes.
11766 (x_allocate_bitmap_record): Check for size overflow.
11767 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
11768
b081724f
PE
11769 Use ptrdiff_t, not int, for overlay counts.
11770 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
11771 * editfns.c (overlays_around, get_pos_property):
11772 * textprop.c (get_char_property_and_overlay):
11773 * xdisp.c (next_overlay_change, note_mouse_highlight):
11774 * xfaces.c (face_at_buffer_position):
21514da7
PE
11775 * buffer.c (OVERLAY_COUNT_MAX): New macro.
11776 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
11777 (Fnext_overlay_change, Fprevious_overlay_change)
11778 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 11779 Use ptrdiff_t, not int, for sizes.
21514da7 11780 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 11781
3de73e5e
PE
11782 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
11783
2606c57b
PE
11784 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
11785 (x_session_initialize): Do not assume string length fits in int.
11786
aaafe47a
PE
11787 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
11788 This is unlikely, but can occur if DPI is outlandish.
11789
2674ddc8 11790 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
11791 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
11792
28154962
PE
11793 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
11794 * xrdb.c (magic_file_p, search_magic_path):
11795 Omit last arg SUFFIX; it was always 0. All callers changed.
11796 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
11797
7de51af5
PE
11798 * xfont.c (xfont_match): Avoid need for strlen.
11799
25ed6cc3
PE
11800 * xfns.c: Don't assume strlen fits in int.
11801 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
11802
4eab31dd
PE
11803 * xdisp.c (message_log_check_duplicate): Return intmax_t,
11804 not unsigned long, as we prefer signed integers. All callers changed.
11805 Detect integer overflow in repeat count.
11806 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 11807 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 11808
171e2a58
PE
11809 * termcap.c: Don't assume sizes fit in int and never overflow.
11810 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
11811 (gobble_line): Check for size-calculation overflow.
11812
ad39faca 11813 * minibuf.c (Fread_buffer):
6e5bb2dc 11814 * lread.c (intern, intern_c_string):
74ca2eb3
PE
11815 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
11816 Don't assume string length fits in int.
11817
52c61c22 11818 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
11819 * gtkutil.c (style_changed_cb): Avoid need for strlen.
11820
b5b8c9e5
PE
11821 * font.c: Don't assume string length fits in int.
11822 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
11823 Use ptrdiff_t, not int.
ccd6111c
PE
11824 (font_intern_prop): Don't assume string length fits in int.
11825 Don't assume integer property fits in fixnum.
11826 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 11827
882f0d81 11828 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 11829 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
11830 Reformulate so as not to need the command string.
11831 Invoke gzip -cd rather than gunzip, as it's more portable.
11832 (lock_info_type, lock_file_1, lock_file):
11833 Don't assume pid_t and time_t fit in unsigned long.
11834 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
11835 (current_lock_owner): Prefer signed type for sizes.
11836 Use memcpy, not strncpy, where memcpy is what is really wanted.
11837 Don't assume (via atoi) that time_t and pid_t fit in int.
11838 Check for time_t and/or pid_t out of range, e.g., via a network share.
11839 Don't alloca where an auto var works fine.
11840
93f4cf88
PE
11841 * fileio.c: Fix some integer overflow issues.
11842 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
11843 Don't assume string length fits in int.
11844 (directory_file_name): Don't assume string length fits in long.
11845 (make_temp_name): Don't assume pid fits in int, or that its print
11846 length is less than 20.
11847
f3e92b69
PE
11848 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
11849
1bfdaf10
PE
11850 * coding.c (make_subsidiaries): Don't assume string length fits in int.
11851
35016e9a
PE
11852 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
11853
3d1e65a1
PE
11854 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
11855 We prefer signed integers, even for size calculations.
11856
0b963a93
PE
11857 * emacs.c: Don't assume string length fits in 'int'.
11858 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
11859 (main): Don't invoke strlen when not needed.
11860
573f4b54
PE
11861 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
11862 (XD_DEBUG_MESSAGE): Don't waste a byte.
11863
989f33ba
PE
11864 * callproc.c (getenv_internal_1, getenv_internal)
11865 (Fgetenv_internal):
965d34eb
PE
11866 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
11867
e4d29b33
PE
11868 * lread.c (invalid_syntax): Omit length argument.
11869 All uses changed. This doesn't fix a bug, but it simplifies the
11870 code away from its former Hollerith-constant appearance, and it's
11871 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 11872 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 11873
eb49b136
PE
11874 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
11875 This didn't break anything, but it didn't help either.
11876 It's confusing to put a bogus integer in a place where the actual
11877 value does not matter.
9f62aeb1 11878 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 11879 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 11880
15375a22
PE
11881 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
11882 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
11883 implementation.
b61cc01c
PE
11884 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
11885 We prefer signed types, and the value cannot exceed the EMACS_INT
11886 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
11887 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
11888 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
11889 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 11890
53b2623d
PE
11891 * indent.c (sane_tab_width): New function.
11892 (current_column, scan_for_column, Findent_to, position_indentation)
11893 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 11894 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 11895
51cab52b 11896 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 11897
f2ed8a70
PE
11898 * lisp.h (lint_assume): New macro.
11899 * composite.c (composition_gstring_put_cache):
11900 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
11901
abe80cc6
PE
11902 * editfns.c, insdel.c:
11903 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 11904
b02c740e
PE
11905 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
11906
ebc96716
PE
11907 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
11908
b4e50fa0 11909 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 11910 Use much-faster test for byte-length change.
311d5d7c 11911 Don't assume string byte-length fits in 'int'.
a4cf38e4 11912 Check that character arg fits in 'int'.
85461888 11913 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 11914
c0c1ee9f
PE
11915 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
11916
a498d7f4
PE
11917 * fns.c (concat): Catch string overflow earlier.
11918 Do not rely on integer wraparound.
11919
51cab52b
PE
11920 * dispextern.h (struct it.overlay_strings_charpos)
11921 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
11922 * xdisp.c (forward_to_next_line_start)
11923 (back_to_previous_visible_line_start)
11924 (reseat_at_next_visible_line_start, next_element_from_buffer):
11925 Don't arbitrarily truncate the value of 'selective' to int.
11926
76031fad
PE
11927 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
11928
5eb55db9
PE
11929 * composite.c: Don't truncate sizes to 'int'.
11930 (composition_gstring_p, composition_reseat_it)
11931 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
11932 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
11933 not EMACS_UINT, for indexes.
5eb55db9 11934
0703a717
PE
11935 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
11936
d6202519
PE
11937 * buffer.c: Include <verify.h>.
11938 (struct sortvec.priority, struct sortstr.priority):
8961a454 11939 Now EMACS_INT, not int.
c20998a7 11940 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
11941 (struct sortstr.size, record_overlay_string)
11942 (struct sortstrlist.size, struct sortlist.used):
11943 Don't truncate size to int.
11944 (record_overlay_string): Check for size-calculation overflow.
d6202519 11945 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 11946
d5a19415
JM
119472011-06-22 Jim Meyering <meyering@redhat.com>
11948
029529ac 11949 Don't leak an XBM-image-sized buffer
d5a19415
JM
11950 * image.c (xbm_load): Free the image buffer after using it.
11951
a9041e6c
PE
119522011-06-21 Paul Eggert <eggert@cs.ucla.edu>
11953
11954 Port to Sun C.
11955 * composite.c (find_automatic_composition): Omit needless 'return 0;'
11956 that Sun C diagnosed.
11957 * fns.c (secure_hash): Fix pointer signedness issue.
11958 * intervals.c (static_offset_intervals): New function.
11959 (offset_intervals): Use it.
11960
7f3f739f
LL
119612011-06-21 Leo Liu <sdl.web@gmail.com>
11962
11963 * deps.mk (fns.o):
11964 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
11965 sha512.h.
11966
11967 * fns.c (secure_hash): Rename from crypto_hash_function and change
11968 the first arg to accept symbols.
5b66d427 11969 (Fsecure_hash): New primitive.
7f3f739f
LL
11970 (syms_of_fns): New symbols.
11971
76147d94
DD
119722011-06-20 Deniz Dogan <deniz@dogan.se>
11973
11974 * process.c (Fset_process_buffer): Clarify return value in
11975 docstring.
11976
7d7d0045
CY
119772011-06-18 Chong Yidong <cyd@stupidchicken.com>
11978
11979 * dispnew.c (add_window_display_history): Use BVAR.
11980
11981 * xdisp.c (debug_method_add): Use BVAR.
11982 (check_window_end, dump_glyph_matrix, dump_glyph)
11983 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
11984
11985 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
11986 Likewise.
11987
11988 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
11989 check till after the cache is created in init_frame_faces.
11990
ff2bc410
SM
119912011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
11992
11993 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
11994
28177add
PE
119952011-06-16 Paul Eggert <eggert@cs.ucla.edu>
11996
dd3482fe
PE
11997 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
11998 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
11999 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
12000
393d71f3 12001 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
12002 * fileio.c (Finsert_file_contents):
12003 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
12004 Remove the old (too-loose) buffer overflow checks.
12005 They weren't needed, since make_gap checks for buffer overflow.
12006 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
12007 The old code merely checked for Emacs fixnum overflow, and relied
12008 on undefined (wraparound) behavior. The new code avoids undefined
12009 behavior, and also checks for ptrdiff_t and/or size_t overflow.
12010
2e6813b0 12011 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
12012 Tune. Don't use wider integers than needed. Don't use alloca.
12013 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 12014
599a9e4f
PE
12015 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
12016
99561444
PE
12017 * insdel.c, lisp.h (buffer_overflow): New function.
12018 (insert_from_buffer_1, replace_range, replace_range_2):
12019 * insdel.c (make_gap_larger):
12020 * editfns.c (Finsert_char):
12021 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
12022
28177add
PE
12023 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
12024
e69dafad
PE
120252011-06-15 Paul Eggert <eggert@cs.ucla.edu>
12026
4baa020d 12027 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 12028
b1c46f02
PE
12029 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
12030 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
12031
e69dafad
PE
12032 * fileio.c: Don't assume EMACS_INT fits in off_t.
12033 (emacs_lseek): New static function.
12034 (Finsert_file_contents, Fwrite_region): Use it.
12035 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
12036
566684ea
PE
12037 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
12038
e6966cd6
PE
12039 * fns.c: Don't overflow int when computing a list length.
12040 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
12041 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
12042 truncation on 64-bit hosts. Check for QUIT every
12043 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
12044 faster and is responsive enough.
12045 (Flength): Report an error instead of overflowing an integer.
12046 (Fsafe_length): Return a float if the value is not representable
12047 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 12048 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 12049 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 12050
dd0b0efb
PE
12051 * alloc.c: Check that resized vectors' lengths fit in fixnums.
12052 (header_size, word_size): New constants.
12053 (allocate_vectorlike): Don't check size overflow here.
12054 (allocate_vector): Check it here instead, since this is the only
12055 caller of allocate_vectorlike that could cause overflow.
12056 Check that the new vector's length is representable as a fixnum.
12057
86fe5cfe
PE
12058 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
12059 The previous code was bogus. For example, next_almost_prime (32)
12060 returned 39, which is undesirable as it is a multiple of 3; and
12061 next_almost_prime (24) returned 25, which is a multiple of 5 so
12062 why was the code bothering to check for multiples of 7?
12063
80e88859
PE
12064 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
12065
4a2f0ad6
PE
12066 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
12067
f66c7cf8
PE
12068 Variadic C functions now count arguments with ptrdiff_t.
12069 This partly undoes my 2011-03-30 change, which replaced int with size_t.
12070 Back then I didn't know that the Emacs coding style prefers signed int.
12071 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
12072 were being counted with int, which may truncate counts on 64-bit
12073 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
12074 * lisp.h (struct Lisp_Subr.function.aMANY)
12075 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
12076 Arg counts are now ptrdiff_t, not size_t.
12077 All variadic functions and their callers changed accordingly.
12078 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
12079 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
12080 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
12081 * callint.c (Fcall_interactively): Check arg count for overflow,
12082 to avoid potential buffer overrun. Use signed char, not 'int',
12083 for 'varies' array, so that we needn't bother to check its size
12084 calculation for overflow.
12085 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
12086 * eval.c (apply_lambda):
12087 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
12088 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
12089 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
12090
a1759b76
PE
12091 * callint.c (Fcall_interactively): Don't use index var as event count.
12092
d96be9fc
PE
12093 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
12094 * mem-limits.h (SIZE): Remove; no longer used.
12095
a690a978 12096 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 12097
578c21e6
PE
12098 Remove unnecessary casts.
12099 * xterm.c (x_term_init):
12100 * xfns.c (x_set_border_pixel):
12101 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
12102 These aren't needed now that we assume ANSI C.
12103
96f53c6c
PE
12104 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
12105 It's more likely to cause problems (due to unsigned overflow)
12106 than to cure them.
12107
83c77d31
PE
12108 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
12109
ee2079f1
PE
12110 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
12111
6da65536
PE
12112 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
12113
7147c4a4
PE
12114 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
12115
193e32d9
PE
12116 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
12117
e5533da6
PE
12118 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
12119
9910e595
PE
12120 GLYPH_CODE_FACE returns EMACS_INT, not int.
12121 * dispextern.h (merge_faces):
12122 * xfaces.c (merge_faces):
01103c44
PE
12123 * xdisp.c (get_next_display_element, next_element_from_display_vector):
12124 Don't assume EMACS_INT fits in int.
9910e595 12125
2638320e
PE
12126 * character.h (CHAR_VALID_P): Remove unused parameter.
12127 * fontset.c, lisp.h, xdisp.c: All uses changed.
12128
045eb8d9
PE
12129 * editfns.c (Ftranslate_region_internal): Omit redundant test.
12130
c1f134b5
PE
12131 * fns.c (concat): Minor tuning based on overflow analysis.
12132 This doesn't fix any bugs. Use int to hold character, instead
12133 of constantly refetching from Emacs object. Use XFASTINT, not
12134 XINT, for value known to be a character. Don't bother comparing
12135 a single byte to 0400, as it's always less.
12136
395fcb93 12137 * floatfns.c (Fexpt):
327eeec8
PE
12138 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
12139
abbd3d23
PE
12140 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
12141 for characters.
12142
684a03ef
PE
12143 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
12144
0fed43f3
PE
12145 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
12146 Without this fix, on a 64-bit host (aset S 0 4294967386) would
12147 incorrectly succeed when S was a string, because 4294967386 was
12148 truncated before it was used.
12149
8fd02eb7
PE
12150 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
12151 Otherwise, an out-of-range integer could cause undefined behavior
12152 on a 64-bit host.
12153
f8c86b69
PE
12154 * composite.c: Use int, not EMACS_INT, for characters.
12155 (fill_gstring_body, composition_compute_stop_pos): Use int, not
12156 EMACS_INT, for values that are known to be in character range.
12157 This doesn't fix any bugs but is the usual style inside Emacs and
12158 may generate better code on 32-bit machines.
12159
34206dd2
PE
12160 Make sure a 64-bit char is never passed to ENCODE_CHAR.
12161 This is for reasons similar to the recent CHAR_STRING fix.
12162 * charset.c (Fencode_char): Check that character arg is actually
12163 a character. Pass an int to ENCODE_CHAR.
12164 * charset.h (ENCODE_CHAR): Verify that the character argument is no
12165 wider than 'int', as a compile-time check to prevent future regressions
12166 in this area.
12167
c5958d4c 12168 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
12169
12170 Make sure a 64-bit char is never passed to CHAR_STRING.
12171 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
12172 by silently ignoring the top 32 bits, allowing some values
12173 that were far too large to be valid characters.
12174 * character.h: Include <verify.h>.
12175 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
12176 arguments are no wider than unsigned, as a compile-time check
12177 to prevent future regressions in this area.
12178 * data.c (Faset):
01103c44 12179 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
12180 (Fsubst_char_in_region):
12181 * fns.c (concat):
12182 * xdisp.c (decode_mode_spec_coding):
12183 Adjust to CHAR_STRING's new requirement.
12184 * editfns.c (Finsert_char, Fsubst_char_in_region):
12185 * fns.c (concat): Check that character args are actually
12186 characters. Without this test, these functions did the wrong
12187 thing with wildly out-of-range values on 64-bit hosts.
12188
d37ca623
PE
12189 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
12190 These casts should not be needed on 32-bit hosts, either.
12191 * keyboard.c (read_char):
12192 * lread.c (Fload): Remove casts to unsigned.
12193
ea204efb
PE
12194 * lisp.h (UNSIGNED_CMP): New macro.
12195 This fixes comparison bugs on 64-bit hosts.
12196 (ASCII_CHAR_P): Use it.
12197 * casefiddle.c (casify_object):
01103c44 12198 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
12199 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
12200 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
12201 * dispextern.h (FACE_FROM_ID):
12202 * keyboard.c (read_char): Use UNSIGNED_CMP.
12203
41cb286c
PE
12204 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
12205 not to EMACS_INT, to avoid GCC warning.
12206
4a1b9832
PE
12207 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
12208
55daad71
PE
12209 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
12210 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
12211 isn't needed on 32-bit machines.
8f95c75c 12212
01103c44
PE
12213 * buffer.c (Fgenerate_new_buffer_name):
12214 Use EMACS_INT for count, not int.
0ceccced 12215 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
12216
12217 * data.c (Qcompiled_function): Now static.
12218
c6f072e7
PE
12219 * window.c (window_body_lines): Now static.
12220
20ce5912
PE
12221 * image.c (gif_load): Rename local to avoid shadowing.
12222
9c4c5f81
PE
12223 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
12224 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
12225 * alloc.c (make_save_value): Integer argument is now of type
12226 ptrdiff_t, not int.
12227 (mark_object): Use ptrdiff_t, not int.
12228 * lisp.h (pD): New macro.
12229 * print.c (print_object): Use it.
12230
c0c5c8ae
PE
12231 * alloc.c: Use EMACS_INT, not int, to count objects.
12232 (total_conses, total_markers, total_symbols, total_vector_size)
12233 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
12234 (total_free_floats, total_floats, total_free_intervals)
12235 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
12236 Now EMACS_INT, not int. All uses changed.
12237 (Fgarbage_collect): Compute overall total using a double, so that
12238 integer overflow is less likely to be a problem. Check for overflow
12239 when converting back to an integer.
5a25e253
PE
12240 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
12241 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
12242 These were 'int' variables that could overflow on 64-bit hosts;
12243 they were never used, so remove them instead of repairing them.
211a0b2a 12244 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
12245 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
12246 Previously, this ceilinged at INT_MAX, but that doesn't work on
12247 64-bit machines.
e46bb31a 12248 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 12249
c78baabf 12250 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 12251 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
12252 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
12253 when a (possibly-narrower) signed value would do just as well.
12254 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 12255
c9d624c6
PE
12256 * alloc.c: Catch some string size overflows that we were missing.
12257 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
12258 for convenience in STRING_BYTES_MAX.
12259 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
12260 The definition here is exact; the one in lisp.h was approximate.
12261 (allocate_string_data): Check for string overflow. This catches
12262 some instances we weren't catching before. Also, it catches
12263 size_t overflow on (unusual) hosts where SIZE_MAX <= min
12264 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
12265 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 12266
c9d624c6
PE
12267 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
12268 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 12269 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 12270
353032ce
PE
12271 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
12272
2bccce07
PE
12273 * alloc.c (Fmake_string): Check for out-of-range init.
12274
0ac30604
SM
122752011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
12276
12277 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
12278
c195f2de
JD
122792011-06-14 Jan Djärv <jan.h.d@swipnet.se>
12280
12281 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
12282 xg_get_default_scrollbar_width.
12283
12284 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
12285 (int_gtk_range_get_value): Move to the scroll bar part of the file.
12286 (style_changed_cb): Call update_theme_scrollbar_width and call
12287 x_set_scroll_bar_default_width and xg_frame_set_char_size for
12288 all frames (Bug#8505).
12289 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
12290 Call gtk_window_set_resizable if HAVE_GTK3.
12291 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
12292 and height if HAVE_GTK3 (Bug#8505).
12293 (scroll_bar_width_for_theme): New variable.
12294 (update_theme_scrollbar_width): New function.
12295 (xg_get_default_scrollbar_width): Move code to
12296 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
12297 (xg_initialize): Call update_theme_scrollbar_width.
12298
12299 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
12300
12301 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
12302
e10ac9f1
MR
123032011-06-12 Martin Rudalics <rudalics@gmx.at>
12304
12305 * frame.c (make_frame): Call other_buffer_safely instead of
12306 other_buffer.
12307
12308 * window.c (temp_output_buffer_show): Call display_buffer with
12309 second argument Vtemp_buffer_show_specifiers and reset latter
12310 immediately after the call.
12311 (Vtemp_buffer_show_specifiers): New variable.
12312 (auto_window_vscroll_p, next_screen_context_lines)
12313 (Vscroll_preserve_screen_position): Remove leading asterisks from
12314 doc-strings.
12315
2d3c217e 123162011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 12317
7b7f97e8 12318 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
12319 * buffer.c (Qclone_number): Remove for now, as it's unused.
12320 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
12321 (record_buffer): Remove unused local.
12322 * frame.c (other_visible_frames, frame_buffer_list): Now static.
12323 (set_frame_buffer_list): Remove; unused.
12324 * frame.h (other_visible_frames): Remove decl.
12325 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
12326 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
12327 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
12328 if HAVE_GPM.
12329 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
12330 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
12331 Define only if HAVE_GPM.
12332 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
12333 (update_hints_inhibit): Remove; never set. All uses removed.
12334 * widgetprv.h (emacsFrameClassRec): Remove decl.
12335 * window.c (delete_deletable_window): Now returns void, since it
12336 wasn't returning anything.
12337 (compare_window_configurations): Remove unused locals.
12338 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
12339 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
12340 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
12341 the same widths as pointers. This follows up on the 2011-05-06 patch.
12342 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
12343 * xterm.h: Likewise.
12344 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
12345
1384b89e
JB
123462011-06-12 Juanma Barranquero <lekktu@gmail.com>
12347
12348 * makefile.w32-in: Update dependencies.
12349 (LISP_H): Add lib/intprops.h.
12350
1100a63c
CY
123512011-06-11 Chong Yidong <cyd@stupidchicken.com>
12352
12353 * image.c (gif_load): Add animation frame delay to the metadata.
12354 (syms_of_image): Use DEFSYM. New symbol `delay'.
12355
6198ccd0
MR
123562011-06-11 Martin Rudalics <rudalics@gmx.at>
12357
12358 * window.c (delete_deletable_window): Re-add.
12359 (Fset_window_configuration): Rewrite to handle dead buffers and
12360 consequently deletable windows.
12361 (window_tree, Fwindow_tree): Remove. Supply functionality in
12362 window.el.
12363 (compare_window_configurations): Simplify code.
12364
b6e3633c
AS
123652011-06-11 Andreas Schwab <schwab@linux-m68k.org>
12366
1ab0dee5
AS
12367 * image.c (imagemagick_load_image): Fix type mismatch.
12368 (Fimagemagick_types): Likewise.
12369
b6e3633c
AS
12370 * window.h (replace_buffer_in_windows): Declare.
12371
9397e56f
MR
123722011-06-11 Martin Rudalics <rudalics@gmx.at>
12373
12374 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
12375 Qclone_number. Remove external declaration of Qdelete_window.
12376 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
12377 code.
640c8776
SM
12378 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
12379 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
12380 (Fother_buffer): Rewrite doc-string. Major rewrite for new
12381 buffer list implementation.
12382 (other_buffer_safely): New function.
12383 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
12384 calls to replace_buffer_in_windows and
12385 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
12386 if allowed.
12387 (record_buffer): Inhibit quitting and rewrite using quittable
12388 functions. Run Qbuffer_list_update_hook if allowed.
12389 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
12390 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
12391 Move switch-to-buffer to window.el.
9397e56f
MR
12392 (bury-buffer): Move to window.el.
12393 (Vbuffer_list_update_hook): New variable.
12394
12395 * lisp.h (other_buffer_safely): Add prototype in buffer.c
12396 section.
12397
12398 * window.h (resize_frame_windows): Move up in code.
12399 (Fwindow_frame): Remove EXFUN.
12400 (replace_buffer_in_all_windows): Remove prototype.
12401 (replace_buffer_in_windows_safely): Add prototype.
12402
12403 * window.c: Declare Qdelete_window static again. Move down
12404 declaration of select_count.
12405 (Fnext_window, Fprevious_window): Rewrite doc-strings.
12406 (Fother_window): Move to window.el.
12407 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
12408 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
12409 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
12410 window.el.
12411 (replace_buffer_in_windows): Implement by calling
12412 Qreplace_buffer_in_windows.
12413 (replace_buffer_in_all_windows): Remove with some functionality
12414 moved into replace_buffer_in_windows_safely.
12415 (replace_buffer_in_windows_safely): New function.
12416 (select_window_norecord, select_frame_norecord): Move in front
12417 of run_window_configuration_change_hook. Remove now obsolete
12418 declarations.
640c8776
SM
12419 (Fset_window_buffer): Rewrite doc-string.
12420 Call Qrecord_window_buffer.
9397e56f
MR
12421 (keys_of_window): Move binding for other-window to window.el.
12422
b50691aa
CY
124232011-06-11 Chong Yidong <cyd@stupidchicken.com>
12424
12425 * dispextern.h (struct image): Replace data member, whose int_val
12426 and ptr_val fields were not used by anything, with a single
12427 lisp_val object.
12428
12429 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
12430 (gif_clear_image, gif_load, imagemagick_load_image)
12431 (gs_clear_image, gs_load): Callers changed.
12432
3f754b86
PE
124332011-06-10 Paul Eggert <eggert@cs.ucla.edu>
12434
cca69397
PE
12435 * buffer.h: Include <time.h>, for time_t.
12436 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
12437
109e28d0
PE
12438 Fix minor problems found by static checking.
12439
60737f02
PE
12440 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
12441
4b66faf3
PE
12442 Make identifiers static if they are not used in other modules.
12443 * data.c (Qcompiled_function, Qframe, Qvector):
12444 * image.c (QimageMagick, Qsvg):
12445 * minibuf.c (Qmetadata):
12446 * window.c (resize_window_check, resize_root_window): Now static.
12447 * window.h (resize_window_check, resize_root_window): Remove decls.
12448
109e28d0
PE
12449 * window.c (window_deletion_count, delete_deletable_window):
12450 Remove; unused.
46a4ce9e
PE
12451 (window_body_lines): Now static.
12452 (Fdelete_other_windows_internal): Mark vars as initialized.
12453 Make sure 'resize_failed' is initialized.
12454 (run_window_configuration_change_hook): Rename local to avoid shadowing.
12455 (resize_window_apply): Remove unused local.
12456 * window.h (delete_deletable_window): Remove decl.
12457
109e28d0 12458 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
12459 (imagemagick_load_image): Fix pointer signedness problem by changing
12460 last arg from unsigned char * to char *. All uses changed.
12461 Also, fix a local for similar reasons.
12462 Remove unused locals. Remove locals to avoid shadowing.
12463 (fn_rsvg_handle_free): Remove; unused.
12464 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 12465 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 12466
3f754b86
PE
12467 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
12468
2547adb1
CY
124692011-06-10 Chong Yidong <cyd@stupidchicken.com>
12470
12471 * image.c (gif_load): Fix omitted cast error introduced by
12472 2011-06-06 change.
12473
2c8e37d4
MR
124742011-06-10 Martin Rudalics <rudalics@gmx.at>
12475
12476 * window.h (resize_proportionally, orig_total_lines)
12477 (orig_top_line): Remove from window structure.
12478 (set_window_height, set_window_width, change_window_heights)
12479 (Fdelete_window): Remove prototypes.
12480 (resize_frame_windows): Remove duplicate declaration.
12481
440a42e3
EZ
124822011-06-10 Eli Zaretskii <eliz@gnu.org>
12483
12484 * window.h (resize_frame_windows, resize_window_check)
12485 (delete_deletable_window, resize_root_window)
12486 (resize_frame_windows): Declare prototypes.
12487
12488 * window.c (resize_window_apply): Make definition be "static" to
12489 match the prototype.
12490
562dd5e9
MR
124912011-06-10 Martin Rudalics <rudalics@gmx.at>
12492
12493 * window.c: Remove declarations of Qwindow_size_fixed,
12494 window_min_size_1, window_min_size_2, window_min_size,
12495 size_window, window_fixed_size_p, enlarge_window, delete_window.
12496 Remove static from declaration of Qdelete_window, it's
12497 temporarily needed by Fbury_buffer.
12498 (replace_window): Don't assign orig_top_line and
12499 orig_total_lines.
12500 (Fdelete_window, delete_window): Remove. Window deletion is
12501 handled by window.el.
640c8776
SM
12502 (window_loop): Remove DELETE_OTHER_WINDOWS case.
12503 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
12504 (Fdelete_other_windows): Remove. Deleting other windows is
12505 handled by window.el.
12506 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
12507 handled in window.el.
12508 (window_min_size_2, window_min_size_1, window_min_size): Remove.
12509 Window minimum sizes are handled in window.el.
12510 (shrink_windows, size_window, set_window_height)
12511 (set_window_width, change_window_heights, window_height)
12512 (window_width, CURBEG, CURSIZE, enlarge_window)
12513 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
12514 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
12515 handled in window.el.
12516 (make_dummy_parent): Rename to make_parent_window and give it a
12517 second argument horflag.
12518 (make_window): Don't set resize_proportionally any more.
12519 (Fsplit_window): Remove. Windows are split in window.el.
12520 (save_restore_action, save_restore_orig_size)
12521 (shrink_window_lowest_first, save_restore_orig_size): Remove.
12522 Resize mini windows in window.el.
12523 (grow_mini_window, shrink_mini_window): Implement by calling
12524 Qresize_root_window_vertically, resize_window_check and
12525 resize_window_apply.
640c8776
SM
12526 (saved_window, Fset_window_configuration, save_window_save):
12527 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
12528 resize_proportionally.
12529 (window_min_height, window_min_width): Move to window.el.
12530 (keys_of_window): Move bindings for delete-other-windows,
12531 split-window, delete-window and enlarge-window to window.el.
12532
12533 * buffer.c: Temporarily extern Qdelete_window.
12534 (Fbury_buffer): Temporarily call Qdelete_window instead of
12535 Fdelete_window (Fbury_buffer will move to window.el soon).
12536
12537 * frame.c (set_menu_bar_lines_1): Remove code handling
12538 orig_top_line and orig_total_lines.
12539
12540 * dispnew.c (adjust_frame_glyphs_initially): Don't use
12541 set_window_height but set heights directly.
12542 (change_frame_size_1): Use resize_frame_windows.
12543
12544 * xdisp.c (init_xdisp): Don't use set_window_height but set
12545 heights directly.
12546
640c8776
SM
12547 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
12548 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
12549 run_window_configuration_change_hook.
12550
12551 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
12552 instead of change_window_heights and run
12553 run_window_configuration_change_hook.
12554
1a13852e
MR
125552011-06-09 Martin Rudalics <rudalics@gmx.at>
12556
12557 * window.c (replace_window): Rename second argument REPLACEMENT to
12558 NEW. New third argument SETFLAG. Rewrite.
12559 (delete_window, make_dummy_parent): Call replace_window with
12560 third argument 1.
12561 (window_list_1): Move down in code.
12562 (run_window_configuration_change_hook): Move set_buffer part
12563 before select_frame_norecord part in order to unwind correctly.
12564 Rename count1 to count.
12565 (recombine_windows, delete_deletable_window, resize_root_window)
12566 (Fdelete_other_windows_internal)
12567 (Frun_window_configuration_change_hook, make_parent_window)
12568 (resize_window_check, resize_window_apply, Fresize_window_apply)
12569 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
12570 (Fdelete_window_internal, Fresize_mini_window_internal):
12571 New functions.
1a13852e
MR
12572 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
12573
f3d1777e
MR
125742011-06-08 Martin Rudalics <rudalics@gmx.at>
12575
496e208e
MR
12576 * window.h (window): Add some new members to window structure -
12577 normal_lines, normal_cols, new_total, new_normal, clone_number,
12578 splits, nest, prev_buffers, next_buffers.
12579 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 12580 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 12581
f3d1777e
MR
12582 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
12583 Remove.
496e208e
MR
12584 (make_dummy_parent): Set new members of windows structure.
12585 (make_window): Move down in code. Handle new members of window
12586 structure.
12587 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
12588 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
12589 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
12590 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
12591 (Fset_window_next_buffers, Fset_window_clone_number):
12592 New functions.
496e208e
MR
12593 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
12594 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
12595 Doc-string fixes.
12596 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
12597 Argument WINDOW can be now internal window too.
12598 (Fwindow_use_time): Move up in code.
12599 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
12600 Rewrite doc-string.
12601 (Fset_window_configuration, saved_window)
12602 (Fcurrent_window_configuration, save_window_save): Handle new
12603 members of window structure.
b9e809c2
MR
12604 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
12605 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
12606 (syms_of_window): New Lisp objects Qrecord_window_buffer,
12607 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
12608 Qget_mru_window, Qresize_root_window,
12609 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
12610 Qauto_buffer_name; staticpro them.
f3d1777e 12611
abde8f8c
MR
126122011-06-07 Martin Rudalics <rudalics@gmx.at>
12613
12614 * window.c (Fwindow_total_size, Fwindow_left_column)
12615 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
12616 (Fwindow_list_1): New functions.
12617 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
12618 (Fwindow_width, Fscroll_left, Fscroll_right):
12619 Use window_body_cols instead of window_box_text_cols.
12620 (delete_window, Fset_window_configuration):
12621 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
12622 (delete_all_subwindows): Take a window as argument and not a
12623 structure. Rewrite.
190b47e6
MR
12624 (window_loop): Remove handling of GET_LRU_WINDOW and
12625 GET_LARGEST_WINDOW.
12626 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
12627
12628 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
12629 window_box_text_cols. delete_all_subwindows now takes a
12630 Lisp_Object as argument.
abde8f8c 12631
640c8776
SM
12632 * indent.c (compute_motion, Fcompute_motion):
12633 Use window_body_cols instead of window_box_text_cols.
abde8f8c 12634
fa8a67e6
MR
12635 * frame.c (delete_frame): Call delete_all_subwindows with root
12636 window as argument.
12637
a54e3482
DC
126382011-06-07 Daniel Colascione <dan.colascione@gmail.com>
12639
12640 * fns.c (Fputhash): Document return value.
12641
60002bf5
CY
126422011-06-06 Chong Yidong <cyd@stupidchicken.com>
12643
12644 * image.c (gif_load): Implement gif89a spec "no disposal" method.
12645
0c671da6 126462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 12647
b862a52a 12648 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 12649
be44ca6c
PE
12650 Check for overflow when converting integer to cons and back.
12651 * charset.c (Fdefine_charset_internal, Fdecode_char):
12652 Use cons_to_unsigned to catch overflow.
12653 (Fencode_char): Use INTEGER_TO_CONS.
12654 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
12655 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
12656 * data.c (long_to_cons, cons_to_long): Remove.
12657 (cons_to_unsigned, cons_to_signed): New functions.
12658 These signal an error for invalid or out-of-range values.
12659 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
12660 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
12661 * font.c (Ffont_variation_glyphs):
12662 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
12663 * lisp.h: Include <intprops.h>.
12664 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
12665 (cons_to_signed, cons_to_unsigned): New decls.
12666 (long_to_cons, cons_to_long): Remove decls.
12667 * undo.c (record_first_change): Use INTEGER_TO_CONS.
12668 (Fprimitive_undo): Use CONS_TO_INTEGER.
12669 * xfns.c (Fx_window_property): Likewise.
12670 * xselect.c: Include <limits.h>.
12671 (x_own_selection, selection_data_to_lisp_data):
12672 Use INTEGER_TO_CONS.
12673 (x_handle_selection_request, x_handle_selection_clear)
12674 (x_get_foreign_selection, Fx_disown_selection_internal)
12675 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
12676 (lisp_data_to_selection_data): Use cons_to_unsigned.
12677 (x_fill_property_data): Use cons_to_signed.
12678 Report values out of range.
12679
d1f3d2af
PE
12680 Check for buffer and string overflow more precisely.
12681 * buffer.h (BUF_BYTES_MAX): New macro.
12682 * lisp.h (STRING_BYTES_MAX): New macro.
12683 * alloc.c (Fmake_string):
12684 * character.c (string_escape_byte8):
12685 * coding.c (coding_alloc_by_realloc):
12686 * doprnt.c (doprnt):
12687 * editfns.c (Fformat):
12688 * eval.c (verror):
12689 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
12690 since they may not be the same number.
12691 * editfns.c (Finsert_char):
12692 * fileio.c (Finsert_file_contents):
12693 Likewise for BUF_BYTES_MAX.
12694
dd52fcea
PE
12695 * image.c: Use ptrdiff_t, not int, for sizes.
12696 (slurp_file): Switch from int to ptrdiff_t.
12697 All uses changed.
12698 (slurp_file): Check that file size fits in both size_t (for
12699 malloc) and ptrdiff_t (for sanity and safety).
12700
7f9bbdbb
PE
12701 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
12702 if b->modtime has its maximal value.
12703
dfe18f82
PE
12704 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
12705
84acfcf0
PE
12706 Don't assume time_t can fit into int.
12707 * buffer.h (struct buffer.modtime): Now time_t, not int.
12708 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
12709 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
12710
ccd9a01a
PE
12711 Minor fixes for signed vs unsigned integers.
12712 * character.h (MAYBE_UNIFY_CHAR):
12713 * charset.c (maybe_unify_char):
12714 * keyboard.c (read_char, reorder_modifiers):
12715 XINT -> XFASTINT, since the integer must be nonnegative.
12716 * ftfont.c (ftfont_spec_pattern):
12717 * keymap.c (access_keymap, silly_event_symbol_error):
12718 XUINT -> XFASTINT, since the integer must be nonnegative.
12719 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
12720 since it makes no difference and we prefer signed.
12721 * keyboard.c (record_char): Use XUINT when all the neighbors do.
12722 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
12723 nonnegative.
12724
d6d100dd
SM
127252011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
12726
12727 * window.h (Fwindow_frame): Declare.
12728
2b6148e4
PE
127292011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12730
12731 * alloc.c: Simplify handling of large-request failures (Bug#8800).
12732 (SPARE_MEMORY): Always define.
12733 (LARGE_REQUEST): Remove.
12734 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
12735
f230ecc9
MR
127362011-06-06 Martin Rudalics <rudalics@gmx.at>
12737
727e958e
MR
12738 * lisp.h: Move EXFUNS for Fframe_root_window,
12739 Fframe_first_window and Fset_frame_selected_window to window.h.
12740
12741 * window.h: Move EXFUNS for Fframe_root_window,
12742 Fframe_first_window and Fset_frame_selected_window here from
12743 lisp.h.
12744
12745 * frame.c (Fwindow_frame, Fframe_first_window)
12746 (Fframe_root_window, Fframe_selected_window)
12747 (Fset_frame_selected_window): Move to window.c.
12748 (Factive_minibuffer_window): Move to minibuf.c.
12749 (Fother_visible_frames_p): New function.
12750
12751 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
12752
f230ecc9
MR
12753 * window.c (decode_window, decode_any_window): Move up in code.
12754 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
12755 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
12756 (Fwindow_buffer): Move up and rewrite doc-string.
12757 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
12758 (Fwindow_prev): New functions.
727e958e
MR
12759 (Fwindow_frame): Move here from frame.c. Accept any window as
12760 argument.
12761 (Fframe_root_window, Fframe_first_window)
12762 (Fframe_selected_window): Move here from frame.c. Accept frame
12763 or arbitrary window as argument. Update doc-strings.
12764 (Fminibuffer_window): Move up in code.
12765 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
12766 (Fset_frame_selected_window): Move here from frame.c.
12767 Marginal rewrite.
727e958e
MR
12768 (Fselected_window, select_window, Fselect_window): Move up in
12769 code. Minor doc-string fixes.
f230ecc9 12770
4d09bcf6
PE
127712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12772
12773 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
12774 Do not assume that spare memory exists; that assumption is valid
12775 only if SYSTEM_MALLOC.
12776 (LARGE_REQUEST): New macro, so that the issue of large requests
12777 is separated from the issue of spare memory.
12778
810928a2
AS
127792011-06-05 Andreas Schwab <schwab@linux-m68k.org>
12780
172418ad
AS
12781 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
12782 format. (Bug#8806)
12783
43f862f7
AS
12784 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
12785
810928a2
AS
12786 * xfns.c (x_set_scroll_bar_default_width): Move declarations
12787 before statements.
12788
a059fe24
JD
127892011-06-05 Jan Djärv <jan.h.d@swipnet.se>
12790
12791 * gtkutil.c (xg_get_default_scrollbar_width): New function.
12792
12793 * gtkutil.h: Declare xg_get_default_scrollbar_width.
12794
12795 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
12796 min width by calling x_set_scroll_bar_default_width (Bug#8505).
12797
989bf368
JB
127982011-06-05 Juanma Barranquero <lekktu@gmail.com>
12799
12800 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
12801
4b80f674
CY
128022011-06-04 Chong Yidong <cyd@stupidchicken.com>
12803
12804 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
12805 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
12806 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
12807 New error handlers.
4b80f674
CY
12808 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
12809 Obey Vx_select_enable_clipboard_manager. Catch errors in
12810 x_clipboard_manager_save (Bug#8779).
12811 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 12812 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 12813
99a33b77 128142011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
12815
12816 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
12817
99a33b77 128182011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
12819
12820 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
12821 in the current matrix if keep_current_p is non-zero.
12822
8264569d
EZ
128232011-06-04 Eli Zaretskii <eliz@gnu.org>
12824
12825 * bidi.c (bidi_level_of_next_char): Fix last change.
12826
57f97249
EZ
128272011-06-03 Eli Zaretskii <eliz@gnu.org>
12828
fec2107c 12829 Support bidi reordering of text covered by display properties.
57f97249 12830
fec2107c
EZ
12831 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
12832 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
12833 (bidi_cache_search, bidi_cache_iterator_state)
12834 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
12835 (bidi_level_of_next_char, bidi_move_to_visually_next):
12836 Support character positions inside a run of characters covered by a
fec2107c
EZ
12837 display string.
12838 (bidi_paragraph_init, bidi_resolve_explicit_1)
12839 (bidi_level_of_next_char): Call bidi_fetch_char and
12840 bidi_fetch_char_advance instead of FETCH_CHAR and
12841 FETCH_CHAR_ADVANCE.
12842 (bidi_init_it): Initialize new members.
12843 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
12844 definitions.
12845 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
12846 instead of using explicit *_CHAR codes.
d6d100dd
SM
12847 (bidi_resolve_explicit, bidi_resolve_weak):
12848 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
12849 bidirectional text is supported only in multibyte buffers.
12850 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
12851 it to initialize the frame_window_p member of struct bidi_it.
12852 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
12853 (bidi_resolve_explicit, bidi_resolve_weak)
12854 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
12855 bidi_it->nchars is non-positive.
12856 (bidi_level_of_next_char): Don't try to lookup the cache for the
12857 next/previous character if nothing is cached there yet, or if we
12858 were just reseat()'ed to a new position.
c40e2fb2 12859
0e14fe90
EZ
12860 * xdisp.c (set_cursor_from_row): Set start and stop points
12861 according to the row's direction when priming the loop that looks
12862 for the glyph on which to display cursor.
12863 (single_display_spec_intangible_p): Function deleted.
12864 (display_prop_intangible_p): Reimplement to call
12865 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
12866 Accept 3 additional arguments needed by handle_display_spec.
12867 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
12868 values: lists, `(when COND...)' forms, etc.
12869 (single_display_spec_string_p): Support property values that are
12870 lists with the argument STRING its top-level element.
12871 (display_prop_string_p): Fix the condition for processing a
12872 property that is a list to be consistent with handle_display_spec.
fec2107c 12873 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
12874 last portion of handle_display_prop.
12875 (compute_display_string_pos): Accept additional argument
12876 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
12877 value of a `display' property is a "replacing spec".
12878 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
12879 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
12880 the display property, but just return a value indicating whether
12881 the display property will replace the characters it covers.
12882 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
12883 frame_window_p members of struct bidi_it.
d6d100dd
SM
12884 (compute_display_string_pos, compute_display_string_end):
12885 New functions.
fec2107c
EZ
12886 (push_it): Accept second argument POSITION, where pop_it should
12887 jump to continue iteration.
12888 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 12889
fec2107c
EZ
12890 * keyboard.c (adjust_point_for_property): Adjust the call to
12891 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
12892
12893 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
12894 (bidi_init_it): Update prototypes.
12895 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
12896 (compute_display_string_pos, compute_display_string_end):
12897 Declare prototypes.
fec2107c
EZ
12898 (struct bidi_it): New members nchars and disp_pos. ch_len is now
12899 EMACS_INT.
fc6f18ce 12900
40087514 129012011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 12902
57f53182
PE
12903 Malloc failure behavior now depends on size of allocation.
12904 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
12905 * lisp.h: Change signatures accordingly.
12906 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
12907 All callers changed. (Bug#8762)
12908
12909 * gnutls.c: Use Emacs's memory allocators.
12910 Without this change, the gnutls library would invoke malloc etc.
12911 directly, which causes problems on non-SYNC_INPUT hosts, and which
12912 runs afoul of improving memory_full behavior. (Bug#8761)
12913 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
12914 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
12915 xfree instead of the default malloc, realloc, free.
12916 (Fgnutls_boot): No need to check for memory allocation failure,
12917 since xmalloc does that for us.
12918
ac32cd99 12919 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
12920 * category.c (hash_get_category_set):
12921 * ccl.c (ccl_driver):
12922 * charset.c (Fdefine_charset_internal):
12923 * charset.h (struct charset.hash_index):
12924 * composite.c (get_composition_id, gstring_lookup_cache)
12925 (composition_gstring_put_cache):
12926 * composite.h (struct composition.hash_index):
12927 * dispextern.h (struct image.hash):
12928 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
12929 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
12930 (hashfn_equal, hashfn_user_defined, make_hash_table)
12931 (maybe_resize_hash_table, hash_lookup, hash_put)
12932 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
12933 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
12934 (Fsxhash, Fgethash, Fputhash, Fmaphash):
12935 * image.c (make_image, search_image_cache, lookup_image)
12936 (xpm_put_color_table_h):
12937 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 12938 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 12939 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 12940 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
12941 * alloc.c (allocate_vectorlike):
12942 Check for overflow in vector size calculations.
12943 * ccl.c (ccl_driver):
12944 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
12945 * fns.c, image.c: Remove unnecessary static decls that would otherwise
12946 need to be updated by these changes.
40087514
PE
12947 * fns.c (make_hash_table, maybe_resize_hash_table):
12948 Check for integer overflow with large hash tables.
0de4bb68
PE
12949 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
12950 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
12951 (SXHASH_REDUCE): New macro.
12952 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
12953 Use it instead of discarding useful hash info with large hash values.
12954 (sxhash_float): New function.
12955 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
12956 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
12957 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
12958 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
12959 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
12960 Adjust signatures to match updated version of code.
12961 (consing_since_gc): Now EMACS_INT, since a single hash table can
12962 use more than INT_MAX bytes.
12963
698d32e2
DN
129642011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
12965
12966 Make it possible to build with GCC-4.6+ -O2 -flto.
12967
12968 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
12969
fd6fa53f
SM
129702011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
12971
12972 * minibuf.c (get_minibuffer, read_minibuf_unwind):
12973 Call minibuffer-inactive-mode.
12974
864db017
JB
129752011-05-31 Juanma Barranquero <lekktu@gmail.com>
12976
12977 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
12978 Update dependencies.
12979
2ad0baf4
DN
129802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12981
12982 * data.c (init_data): Remove code for UTS, this system is not
12983 supported anymore.
12984
4fcc2638
DN
129852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12986
12987 Don't force ./temacs to start in terminal mode.
12988
12989 * frame.c (make_initial_frame): Initialize faces in all cases, not
12990 only when CANNOT_DUMP is defined.
12991 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
12992
c56e0fd5
DN
129932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12994
12995 * dispnew.c (add_window_display_history): Use const for the string
12996 pointer. Remove declaration, not needed.
12997
333d54da 129982011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 12999
55d4c1b2 13000 Use 'inline', not 'INLINE'.
333d54da 13001 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
13002 * alloc.c, fontset.c (INLINE): Remove.
13003 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
13004 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
13005 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
13006 * gmalloc.c (register_heapinfo): Use inline unconditionally.
13007 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
13008
738db178
DN
130092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13010
13011 Make it possible to run ./temacs.
13012
13013 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
13014 syms_of_callproc does the same thing. Remove test for
13015 "initialized", do it in the caller.
13016 * emacs.c (main): Avoid calling set_initial_environment when dumping.
13017
620c53a6
SM
130182011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
13019
13020 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
13021 (read_minibuf): Use get_minibuffer.
13022 (syms_of_minibuf): Use DEFSYM.
13023 (Qmetadata): New var.
13024 * data.c (Qbuffer): Don't make it static.
13025 (syms_of_data): Use DEFSYM.
13026
e003a292
PE
130272011-05-31 Paul Eggert <eggert@cs.ucla.edu>
13028
13029 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
13030 (CCL_CODE_MIN): New macro.
13031
ed008a6d
PE
130322011-05-30 Paul Eggert <eggert@cs.ucla.edu>
13033
3687c2ef
PE
13034 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
13035
ed008a6d
PE
13036 * eval.c (Qdebug): Now static.
13037 * lisp.h (Qdebug): Remove decl. This reverts a part of the
13038 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
13039 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
13040
d66c4c7c
CY
130412011-05-29 Chong Yidong <cyd@stupidchicken.com>
13042
13043 * image.c: Various fixes to ImageMagick code comments.
13044 (Fimagemagick_types): Doc fix.
13045
5fbc2025
PE
130462011-05-29 Paul Eggert <eggert@cs.ucla.edu>
13047
0196f88a
PE
13048 Minor fixes prompted by GCC 4.6.0 warnings.
13049
13050 * xselect.c (converted_selections, conversion_fail_tag): Now static.
13051
5fbc2025
PE
13052 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
13053 (x_clipboard_manager_save_all): Move extern decl to ...
13054 * xterm.h: ... here, so that it can be checked for consistency.
13055
1dd3c2d9
CY
130562011-05-29 Chong Yidong <cyd@stupidchicken.com>
13057
13058 * xselect.c (x_clipboard_manager_save_frame)
13059 (x_clipboard_manager_save_all): New functions.
13060 (Fx_clipboard_manager_save): Lisp function deleted.
13061
13062 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
13063 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
13064
13065 * xterm.h: Update prototype.
13066
5ba6571d
WX
130672011-05-28 William Xu <william.xwl@gmail.com>
13068
13069 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
13070 exiting (Bug#8239).
13071
3eaff834
JM
130722011-05-28 Jim Meyering <meyering@redhat.com>
13073
e1900994 13074 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
13075 * fns.c (to_uchar): Define.
13076 (crypto_hash_function): Use it to convert some newly-signed
13077 variables to unsigned, to avoid sign-extension bugs. For example,
13078 without this change, (md5 "truc") would evaluate to
13079 45723a2aff78ff4fff7fff1114760e62 rather than the expected
13080 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 13081 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 13082
0f6990a7
PE
130832011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13084
13085 Integer overflow fixes.
c8a9ca5a 13086
08686060
PE
13087 * dbusbind.c: Serial number integer overflow fixes.
13088 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
13089 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
13090 to hold a serial number that is too large for a fixnum.
13091 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13092 Check for serial numbers out of range. Decode any serial number
59568bf0 13093 that was so large that it became a float. (Bug#8722)
08686060 13094
2d1fc3c7
PE
13095 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
13096 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13097 Use XFASTINT rather than XUINT when numbers are nonnegative.
13098 (xd_append_arg, Fdbus_method_return_internal):
13099 (Fdbus_method_error_internal): Likewise. Also, for unsigned
13100 arguments, check that Lisp number is nonnegative, rather than
59568bf0 13101 silently wrapping negative numbers around. (Bug#8722)
30217ff0 13102 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 13103 (Bug#8722)
2d1fc3c7 13104
c8a9ca5a
PE
13105 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
13106
519e1d69
PE
13107 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
13108
6df6ae42 13109 ccl: Add integer overflow checks.
30569699
PE
13110 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
13111 (IN_INT_RANGE): New macros.
13112 (ccl_driver): Use them to check for integer overflow when
13113 decoding a CCL program. Many of the new checks are whether XINT (x)
13114 fits in int; it doesn't always, on 64-bit hosts. The new version
13115 doesn't catch all possible integer overflows, but it's an
847044ea 13116 improvement. (Bug#8719)
30569699 13117
c11285dc
PE
13118 * alloc.c (make_event_array): Use XINT, not XUINT.
13119 There's no need for unsigned here.
13120
fdccd48e
PE
13121 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
13122 This follows up to the 2011-05-06 change that substituted uintptr_t
13123 for EMACS_INT. This case wasn't caught back then.
13124
37910ab2
PE
13125 Rework Fformat to avoid integer overflow issues.
13126 * editfns.c: Include <float.h> unconditionally, as it's everywhere
13127 now (part of C89). Include <verify.h>.
13128 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
13129 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
13130 (Fformat): Avoid the prepass trying to compute sizes; it was only
13131 approximate and thus did not catch overflow reliably. Instead, walk
13132 through the format just once, formatting and computing sizes as we go,
13133 checking for integer overflow at every step, and allocating a larger
13134 buffer as needed. Keep track separately whether the format is
13135 multibyte. Keep only the most-recently calculated precision, rather
13136 than them all. Record whether each argument has been converted to
13137 string. Use EMACS_INT, not int, for byte and char and arg counts.
13138 Support field widths and precisions larger than INT_MAX. Avoid
13139 sprintf's undefined behavior with conversion specifications such as %#d
13140 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
13141 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
13142 formatting out-of-range floating point numbers with int
9173deec 13143 formats. (Bug#8668)
37910ab2 13144
2e6578fb
PE
13145 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
13146
0ae6bdee
PE
13147 * data.c: Avoid integer truncation in expressions involving floats.
13148 * data.c: Include <intprops.h>.
13149 (arith_driver): When there's an integer overflow in an expression
13150 involving floating point, convert the integers to floating point
13151 so that the resulting value does not suffer from catastrophic
13152 integer truncation. For example, on a 64-bit host (* 4
13153 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
13154 Do not rely on undefined behavior after integer overflow.
13155
de883a70
PE
13156 merge count_size_as_multibyte, parse_str_to_multibyte
13157 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 13158 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
13159 Check for integer overflow.
13160 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
13161 since it's now a duplicate of the other. This is more of
13162 a character than a buffer op, so better that it's in character.c.
13163 * fns.c, print.c: Adjust to above changes.
13164
2ff916cb
PE
131652011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
13166
13167 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
13168
f1b54466
PE
131692011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13170
fb1ac845
PE
13171 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13172 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
13173 (x_clipboard_manager_save): Now static.
13174 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
13175
f1b54466
PE
13176 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13177 (crypto_hash_function): Now static.
13178 Fix pointer signedness problems. Avoid unnecessary initializations.
13179
a9f737ee
CY
131802011-05-27 Chong Yidong <cyd@stupidchicken.com>
13181
13182 * termhooks.h (Vselection_alist): Make it terminal-local.
13183
13184 * terminal.c (create_terminal): Initialize it.
13185
13186 * xselect.c: Support for clipboard managers.
13187 (Vselection_alist): Move to termhooks.h as terminal-local var.
13188 (LOCAL_SELECTION): New macro.
13189 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
13190 (symbol_to_x_atom): Remove gratuitous arg.
13191 (x_handle_selection_request, lisp_data_to_selection_data)
13192 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
13193 (x_own_selection, x_get_local_selection, x_convert_selection):
13194 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
13195 (some_frame_on_display): Delete unused function.
13196 (Fx_own_selection_internal, Fx_get_selection_internal)
13197 (Fx_disown_selection_internal, Fx_selection_owner_p)
13198 (Fx_selection_exists_p): New optional frame arg.
13199 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
13200 (x_handle_selection_clear): Don't treat other terminals with the
13201 same keyboard specially. Use the terminal-local Vselection_alist.
13202 (x_clear_frame_selections): Use Frun_hook_with_args.
13203
13204 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
13205
13206 * xterm.h: Add support for those atoms.
13207
e067f0c1
CY
132082011-05-26 Chong Yidong <cyd@stupidchicken.com>
13209
13210 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
13211 (converted_selections, conversion_fail_tag): New global variables.
13212 (x_selection_request_lisp_error): Free the above.
13213 (x_get_local_selection): Remove unnecessary code.
13214 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
13215 of converted selections stored in converted_selections.
13216 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
13217 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
13218 (x_convert_selection): New function.
13219 (x_handle_selection_event): Simplify.
13220 (x_get_foreign_selection): Don't ignore incoming requests while
13221 waiting for an answer; this will fail when we implement
13222 SAVE_TARGETS, and seems unnecessary anyway.
13223 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
13224 (Vx_sent_selection_functions): Doc fix.
13225
0f4aebc0
LL
132262011-05-26 Leo Liu <sdl.web@gmail.com>
13227
13228 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
13229
e61124cd
YM
132302011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13231
13232 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
13233
13234 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
13235 for fringe update if it has periodic bitmap.
ac389d0c 13236 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
13237 and fringe_bitmap_periodic_p.
13238
13239 * fringe.c (get_fringe_bitmap_data): New function.
13240 (draw_fringe_bitmap_1, update_window_fringes): Use it.
13241 (update_window_fringes): Record periodicity of fringe bitmap in glyph
13242 row. Mark glyph row for fringe update if periodicity changed.
13243
13244 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
13245 for fringe update unless it has periodic bitmap.
13246
f16d9837
KH
132472011-05-25 Kenichi Handa <handa@m17n.org>
13248
13249 * xdisp.c (get_next_display_element): Set correct it->face_id for
13250 a static composition.
13251
e1b90ef6
LL
132522011-05-24 Leo Liu <sdl.web@gmail.com>
13253
13254 * deps.mk (fns.o):
13255 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
13256
13257 * fns.c (crypto_hash_function, Fsha1): New function.
13258 (Fmd5): Use crypto_hash_function.
13259 (syms_of_fns): Add Ssha1.
13260
7400048f
PE
132612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13262
13263 * gnutls.c: Remove unused macros.
13264 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
13265 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
13266 Remove macros that are defined and never used.
13267 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
13268
abb71cf4
CY
132692011-05-22 Chong Yidong <cyd@stupidchicken.com>
13270
13271 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
13272 (Fx_get_selection_internal): Minor cleanup.
13273 (Fx_own_selection_internal): Rename arguments for consistency with
13274 select.el.
13275
6307db39
PE
132762011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13277
13278 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
13279
f3d4e0a4
CY
132802011-05-22 Chong Yidong <cyd@stupidchicken.com>
13281
13282 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
13283
4d8ade89
YM
132842011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13285
13286 * dispnew.c (scrolling_window): Don't exclude the case that the
13287 last enabled row in the desired matrix touches the bottom boundary.
13288
32078c8d
GM
132892011-05-21 Glenn Morris <rgm@gnu.org>
13290
13291 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
13292 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
13293 and add some more files.
32078c8d 13294
7285dc67
EZ
132952011-05-20 Eli Zaretskii <eliz@gnu.org>
13296
13297 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
13298 report_file_error introduced by the change from 2011-05-07.
13299
89d1bd22
PE
133002011-05-20 Paul Eggert <eggert@cs.ucla.edu>
13301
13302 * systime.h (Time): Define only if emacs is defined.
13303 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
13304 where the include path doesn't have X11/X.h by default. See
13305 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
13306
cd394be1 133072011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
13308
13309 * composite.c (find_automatic_composition): Fix previous change.
13310
b9704ad9
GM
133112011-05-20 Glenn Morris <rgm@gnu.org>
13312
13313 * lisp.mk: New file, split from Makefile.in.
13314 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
13315 (shortlisp): Remove.
13316 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
13317
4a720484
GM
133182011-05-19 Glenn Morris <rgm@gnu.org>
13319
13320 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
13321 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
13322 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
13323 (lisp): Set the order to that of loadup.el.
13324 (shortlisp): Make it a copy of $lisp.
13325 (SOME_MACHINE_LISP): Remove.
13326 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
13327 Use just $shortlisp, not $SOME_MACHINE_LISP too.
13328
a28d4396
KH
133292011-05-18 Kenichi Handa <handa@m17n.org>
13330
13331 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
13332 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
13333 (find_automatic_composition): Mostly rewrite for efficiency.
13334
a2b1fa8e
JB
133352011-05-18 Juanma Barranquero <lekktu@gmail.com>
13336
13337 * makefile.w32-in: Update dependencies.
13338
8e1f5610
CS
133392011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
13340
13341 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 13342 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 13343
7025ee00 133442011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 13345
cdfa6eab
PE
13346 Fix some integer overflow issues, such as string length overflow.
13347
06d6db33
PE
13348 * insdel.c (count_size_as_multibyte): Check for string overflow.
13349
2b4560a8
PE
13350 * character.c (lisp_string_width): Check for string overflow.
13351 Use EMACS_INT, not int, for string indexes and lengths; in
13352 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
13353 the resulting string length overflows an EMACS_INT; instead,
13354 report a string overflow if no precision given. When checking for
13355 precision exhaustion, use a check that cannot possibly have
13356 integer overflow. (Bug#8675)
13357 * character.h (lisp_string_width): Adjust to new signature.
13358
cb93f9be
PE
13359 * alloc.c (string_overflow): New function.
13360 (Fmake_string): Use it. This doesn't change behavior, but saves
13361 a few bytes and will simplify future changes.
13362 * character.c (string_escape_byte8): Likewise.
13363 * lisp.h (string_overflow): New decl.
13364
1a1f3366
PE
13365 Fixups, following up to the user-interface timestamp change.
13366 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
13367 for UI timestamps, instead of unsigned long.
9fbd6841
PE
13368 * msdos.c (mouse_get_pos): Likewise.
13369 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
13370 * w32gui.h (Time): Define by including "systime.h" rather than by
13371 declaring it ourselves. (Bug#8664)
13372
d4e3e4d3
PE
13373 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
13374 * image.c (clear_image_cache): Likewise.
13375
f6a24d19
PE
13376 * term.c (term_mouse_position): Don't assume time_t wraparound.
13377
08dc5ae6
PE
13378 Be more systematic about user-interface timestamps.
13379 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
13380 and sometimes 'EMACS_UINT', to represent these timestamps.
13381 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
13382 This makes the code easier to follow, and makes it easier to catch
13383 integer overflow bugs such as Bug#8664.
13384 * frame.c (Fmouse_position, Fmouse_pixel_position):
13385 Use Time, not unsigned long, for user-interface timestamps.
13386 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
13387 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
13388 * keyboard.h (last_event_timestamp): Likewise.
13389 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
13390 * menu.h (xmenu_show): Likewise.
13391 * term.c (term_mouse_position): Likewise.
13392 * termhooks.h (struct input_event.timestamp): Likewise.
13393 (struct terminal.mouse_position_hook): Likewise.
13394 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
13395 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
13396 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
13397 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
13398 what it was before.
13399 * menu.h, termhooks.h: Include "systime.h", for Time.
13400
8e55734a
PE
13401 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
13402 Don't assume that the difference between two unsigned long values
13403 can fit into an integer. At this point, we know button_down_time
13404 <= event->timestamp, so the difference must be nonnegative, so
13405 there's no need to cast the result if double-click-time is
13406 nonnegative, as it should be; check that it's nonnegative, just in
13407 case. This bug is triggered when events are more than 2**31 ms
86db42d2 13408 apart (about 25 days). (Bug#8664)
8e55734a 13409
841f1b75 13410 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 13411 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 13412
3e26f69c
PE
13413 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
13414 that always fit in int. Use a sentinel instead of a counter, to
13415 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
13416 * frame.h (struct frame): Use int for menu_bar_items_used
13417 instead of EMACS_INT, since it always fits in int.
3e26f69c 13418
5cc152c0
PE
13419 * menu.c (grow_menu_items): Check for int overflow.
13420
d89eb65e
PE
13421 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
13422
5235bd3e
PE
13423 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
13424 Before, the code was not consistent. These values cannot exceed
13425 2**31 - 1 so there's no need to make them unsigned.
13426 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
13427 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
13428 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
13429 as modifiers.
13430 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
13431
bc827e23
PE
13432 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
13433 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
13434 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
13435 presumably because the widths might not match.
13436
78eb494e
PE
13437 * window.c (size_window): Avoid needless test at loop start.
13438
04f2d78b
CB
134392011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
13440
13441 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
13442
d2fc7e3d 134432011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
13444
13445 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
13446
d2fc7e3d 134472011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
13448
13449 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
13450 `width' to `bar_area_x' and `bar_area_width', respectively.
13451 (x_scroll_run): Take account of fringe background extension.
13452
04f2d78b
CB
13453 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
13454 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
13455 `bar_area_width', respectively.
13456 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
13457 background extension.
13458
79b70037
GM
134592011-05-10 Jim Meyering <meyering@redhat.com>
13460
13461 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
13462
2f142cc5
JB
134632011-05-10 Juanma Barranquero <lekktu@gmail.com>
13464
13465 * image.c (Finit_image_library): Return t for built-in image types,
13466 like pbm and xbm. (Bug#8640)
13467
57679c86
AS
134682011-05-09 Andreas Schwab <schwab@linux-m68k.org>
13469
13470 * w32menu.c (set_frame_menubar): Fix submenu allocation.
13471
888c9e86
EZ
134722011-05-07 Eli Zaretskii <eliz@gnu.org>
13473
b0512a1d
EZ
13474 * w32console.c (Fset_screen_color): Doc fix.
13475 (Fget_screen_color): New function.
13476 (syms_of_ntterm): Defsubr it.
13477
7285dc67
EZ
13478 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
13479 unlink the temporary file if Fcall_process didn't create it in the
13480 first place.
13481 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
13482 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
13483 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
13484 cue to call_process_cleanup not to close that handle.
13485
4d3fcc8e
BK
134862011-05-07 Ben Key <bkey76@gmail.com>
13487
13488 * makefile.w32-in: The bootstrap-temacs rule now makes use of
13489 one of two shell specific rules, either bootstrap-temacs-CMD or
13490 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
13491 to the previous implementation of the bootstrap-temacs rule.
13492 The bootstrap-temacs-CMD rule is similar to the previous
13493 implementation of the bootstrap-temacs rule except that it
13494 makes use of the ESC_CFLAGS variable instead of the CFLAGS
13495 variable.
13496
13497 These changes, along with some changes to nt/configure.bat,
13498 nt/gmake.defs, and nt/nmake.defs, are required to extend my
13499 earlier fix to add support for --cflags and --ldflags options
13500 that include quotes so that it works whether make uses cmd or
13501 sh as the shell.
13502
b4289b64
MA
135032011-05-06 Michael Albinus <michael.albinus@gmx.de>
13504
13505 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
13506 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
13507 is a constant.
13508 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
13509 a string. Handle both cases.
13510 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
13511 (Fdbus_register_method): Use Qinvalid_function.
13512
af4c0e28
JB
135132011-05-06 Juanma Barranquero <lekktu@gmail.com>
13514
13515 * makefile.w32-in: Update dependencies.
13516 (LISP_H): Add inttypes.h and stdin.h.
13517 (PROCESS_H): Add unistd.h.
13518
c51453d9
EZ
135192011-05-06 Eli Zaretskii <eliz@gnu.org>
13520
13521 * lread.c: Include limits.h (fixes the MS-Windows build broken by
13522 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
13523
8ff0ac3c 135242011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 13525
4c4b566b
PE
13526 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
13527
aab2b9b5
PE
13528 * term.c (vfatal): Remove stray call to va_end.
13529 It's not needed and the C Standard doesn't allow it here anyway.
13530
c378da0b
PE
13531 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
13532 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
13533
288b08c7
PE
13534 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
13535 bytes.
13536
e3601888
PE
13537 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
13538
db6c0e74
PE
13539 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
13540
dd5963ea
PE
13541 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
13542
88c9450f
PE
13543 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
13544
2f9442b8
PE
13545 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
13546
c032b5f8
PE
13547 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
13548 * charset.c (Fdefine_charset_internal): Don't initialize
13549 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 13550 32-bit int (Bug#8600).
a108c10b
PE
13551
13552 * lread.c (read_integer): Be more consistent with string-to-number.
13553 Use string_to_number to do the actual conversion; this avoids
13554 rounding errors and fixes some other screwups. Without this fix,
13555 for example, #x1fffffffffffffff was misread as -2305843009213693952.
13556 (digit_to_number): Move earlier, for benefit of read_integer.
13557 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 13558 not a digit in any supported base. (Bug#8602)
a108c10b 13559
ad5f9eea
PE
13560 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
13561
aec1708a
PE
13562 * dispnew.c (scrolling_window): Return 1 if we scrolled,
13563 to match comment at start of function. This also removes a
13564 GCC warning about overflow in a 32+64-bit port.
13565
47be4ab5
PE
13566 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
13567
371cac43
PE
13568 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
13569 Reported by Stefan Monnier in
13570 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
13571 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13572 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 13573
d01a7826
PE
13574 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
13575 (EMACS_UINTPTR): Likewise, with uintptr_t.
13576
7fd47d5c
PE
13577 * lisp.h: Prefer 64-bit EMACS_INT if available.
13578 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
13579 on 32-bit hosts that have 64-bit int, so that they can access
13580 large files.
122b0c86
PE
13581 However, temporarily disable this change unless the temporary
13582 symbol WIDE_EMACS_INT is defined.
7fd47d5c 13583
8727937b
PE
13584 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
13585
8ac068ac
PE
13586 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
13587 This removes an assumption that EMACS_INT and long are the same
13588 width as pointers. The assumption is true for Emacs porting targets
13589 now, but we want to make other targets possible.
13590 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
13591 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
13592 In the rest of the code, change types of integers that hold casted
13593 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
13594 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
13595 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
13596 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
13597 No need to cast type when ORing.
13598 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
13599 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
13600 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
13601 assume EMACS_INT is the same width as char *.
13602 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
13603 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
13604 Remove no-longer-needed casts.
13605 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
13606 (xg_tool_bar_help_callback, xg_make_tool_item):
13607 Use EMACS_INTPTR to hold an integer
13608 that will be cast to void *; this can avoid a GCC warning
13609 if EMACS_INT is not the same width as void *.
13610 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
13611 * xdisp.c (display_echo_area_1, resize_mini_window_1):
13612 (current_message_1, set_message_1):
13613 Use a local to convert to proper width without a cast.
13614 * xmenu.c (dialog_selection_callback): Likewise.
13615
ede49d71
PE
13616 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
13617 Also, don't assume VALBITS / RAND_BITS is less than 5,
13618 and don't rely on undefined behavior when shifting a 1 left into
13619 the sign bit.
13620 * lisp.h (get_random): Change signature to match.
13621
2f30ecd0
PE
13622 * lread.c (hash_string): Use size_t, not int, for hash computation.
13623 Normally we prefer signed values; but hashing is special, because
13624 it's better to use unsigned division on hash table sizes so that
13625 the remainder is nonnegative. Also, size_t is the natural width
13626 for hashing into memory. The previous code used 'int', which doesn't
13627 retain enough info to hash well into very large tables.
13628 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
13629
2a866e7b
PE
13630 * dbusbind.c: Don't possibly lose pointer info when converting.
13631 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13632 Use XPNTR rather than XHASH, so that the high-order bits of
13633 the pointer aren't lost when converting through void *.
13634
51639eac
PE
13635 * eval.c (Fautoload): Don't double-shift a pointer.
13636
92394119
PE
13637 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
13638
dbdb9a7c
JB
136392011-05-06 Juanma Barranquero <lekktu@gmail.com>
13640
13641 * gnutls.c (DEF_GNUTLS_FN):
13642 * image.c (DEF_IMGLIB_FN): Make function pointers static.
13643
db7a0b4f
AS
136442011-05-05 Andreas Schwab <schwab@linux-m68k.org>
13645
13646 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
13647 marker. (Bug#8610)
13648
cd394be1 136492011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
13650
13651 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
13652 New version that can reserve upto 2GB of heap space.
13653
f7ff1b0f 136542011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
13655
13656 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
13657
639c109b
TZ
136582011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
13659
13660 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
13661 `gnutls_certificate_set_x509_key_file'.
13662
d2127135
JB
136632011-05-05 Juanma Barranquero <lekktu@gmail.com>
13664
13665 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
13666 Update dependencies.
13667
e968f4f3
JB
136682011-05-04 Juanma Barranquero <lekktu@gmail.com>
13669
13670 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
13671 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
13672 Remove unused parameter `fildes'.
13673 * process.c (read_process_output, send_process): Don't pass it.
13674
84d358f0
JB
136752011-05-04 Juanma Barranquero <lekktu@gmail.com>
13676
13677 Fix previous change: the library cache is defined in w32.c.
13678 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
13679 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
13680
0898ca10
JB
136812011-05-04 Juanma Barranquero <lekktu@gmail.com>
13682
13683 Implement dynamic loading of GnuTLS on Windows.
13684
13685 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
13686 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
13687 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13688 Declare.
13689
13690 * gnutls.c (Qgnutls_dll): Define.
13691 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
13692 (gnutls_*): Declare function pointers.
13693 (init_gnutls_functions): New function to initialize function pointers.
13694 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
13695 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
13696 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13697 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
13698 (emacs_gnutls_write, emacs_gnutls_read)
13699 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
13700 (Fgnutls_available_p): New function.
13701 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
13702 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
13703 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
13704
13705 * image.c: Include w32.h.
13706 (Vimage_type_cache): Delete.
13707 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
13708 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
13709 (w32_delayed_load): Move to w32.c.
13710
13711 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
13712
13713 * w32.c (QCloaded_from, Vlibrary_cache): Define.
13714 (w32_delayed_load): Move from image.c. When loading a library, record
13715 its filename in the :loaded-from property of the library id.
13716 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
13717 Initialize and staticpro them.
13718 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
13719
13720 * process.c: Include lisp.h before w32.h, not after.
13721 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
13722 instead of gnutls_record_check_pending.
13723
13724 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
13725
ff4de4aa
TZ
137262011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
13727
13728 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
13729 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
13730 as passed in.
13731
abe95abb
JD
137322011-05-03 Jan Djärv <jan.h.d@swipnet.se>
13733
13734 * xterm.c (x_set_frame_alpha): Do not set property on anything
13735 else than FRAME_X_OUTER_WINDOW (Bug#8608).
13736
e16e55d4
JB
137372011-05-02 Juanma Barranquero <lekktu@gmail.com>
13738
13739 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
13740
bafcf6a5
JB
137412011-05-02 Juanma Barranquero <lekktu@gmail.com>
13742
13743 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
13744 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
13745 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
13746 (gnutls_global_initialized, Qgnutls_bootprop_priority)
13747 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
13748 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
13749 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
13750 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
13751 (Qgnutls_bootprop_callbacks_verify): Make static.
13752
e7a6747f
AS
137532011-05-01 Andreas Schwab <schwab@linux-m68k.org>
13754
19ed11ba
AS
13755 * callproc.c: Indentation fixup.
13756
e7a6747f 13757 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
13758 (wait_for_termination, interruptible_wait_for_termination):
13759 Move after wait_for_termination_1.
e7a6747f 13760
1ef14cb4
LMI
137612011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
13762
13763 * sysdep.c (interruptible_wait_for_termination): New function
13764 which is like wait_for_termination, but allows keyboard
13765 interruptions.
13766
13767 * callproc.c (Fcall_process): Add (:file "file") as an option for
13768 the STDOUT buffer.
13769 (Fcall_process_region): Ditto.
13770
330d880c
EZ
137712011-04-30 Eli Zaretskii <eliz@gnu.org>
13772
8db90b73
EZ
13773 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
13774 rather than `XVECTOR (FOO)->size'.
13775
330d880c
EZ
13776 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
13777 inttypes.h, as a gnulib replacement is used if it not available in
13778 system headers.
13779
15cbd324
EZ
137802011-04-21 Eli Zaretskii <eliz@gnu.org>
13781
13782 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
13783 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
13784 of MOST_POSITIVE_FIXNUM. (Bug#8528)
13785
13786 * coding.c (coding_alloc_by_realloc): Error out if destination
13787 will grow beyond MOST_POSITIVE_FIXNUM.
13788 (decode_coding_emacs_mule): Abort if there isn't enough place in
13789 charbuf for the composition carryover bytes. Reserve an extra
13790 space for up to 2 characters produced in a loop.
13791 (decode_coding_iso_2022): Abort if there isn't enough place in
13792 charbuf for the composition carryover bytes.
13793
137942011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 13795
ae940cca
EZ
13796 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
13797 aborting when %lld or %lll format is passed.
13798 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
13799 %llo or %llx format is passed. (Bug#8545)
13800
03ab8921
EZ
13801 * window.c (window_scroll_line_based): Use a marker instead of
13802 simple variables to record original value of point. (Bug#7952)
13803
afda1437
EZ
13804 * doprnt.c (doprnt): Fix the case where a multibyte sequence
13805 produced by %s or %c overflows available buffer space. (Bug#8545)
13806
f76dee0c
PE
138072011-04-28 Paul Eggert <eggert@cs.ucla.edu>
13808
13809 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 13810 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 13811
fdc5744d
JB
138122011-04-28 Juanma Barranquero <lekktu@gmail.com>
13813
13814 * w32.c (init_environment): Warn about defaulting HOME to C:\.
13815
638f053a
JB
138162011-04-28 Juanma Barranquero <lekktu@gmail.com>
13817
13818 * keyboard.c (Qdelayed_warnings_hook): Define.
13819 (command_loop_1): Run `delayed-warnings-hook'
13820 if Vdelayed_warnings_list is non-nil.
13821 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
13822 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
13823
d178f871
EZ
138242011-04-28 Eli Zaretskii <eliz@gnu.org>
13825
13826 * doprnt.c (doprnt): Don't return value smaller than the buffer
13827 size if the message was truncated. (Bug#8545).
13828
b124fd93
JB
138292011-04-28 Juanma Barranquero <lekktu@gmail.com>
13830
13831 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
13832 (Fx_window_property): #if-0 the whole functions, not just the bodies.
13833
e810457d
PE
138342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13835
13836 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
13837
ea51cceb
JB
138382011-04-27 Juanma Barranquero <lekktu@gmail.com>
13839
13840 * makefile.w32-in: Update dependencies.
13841
94dcfacf
EZ
138422011-04-27 Eli Zaretskii <eliz@gnu.org>
13843
13844 Improve `doprnt' and its usage. (Bug#8545)
13845 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
13846 `format_end'. Remove support for %l as a conversion specifier.
13847 Don't use xrealloc. Improve diagnostics when the %l size modifier
13848 is used. Update the commentary.
13849
13850 * eval.c (verror): Simplify calculation of size_t.
13851
13852 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
13853 messages.
13854
f61f41d7
PE
138552011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
13856
13857 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
13858 change.
13859
96fb4434
PE
138602011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13861
13862 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
13863 This makes this file independent of the recent pseudovector change.
13864
671875da 138652011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 13866
69e9b5a3
PE
13867 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
13868
b5f869a7 13869 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 13870 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 13871 Remove unused local.
c8926152 13872 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 13873
841a1577 13874 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
13875 GCC 4.6.0 optimizes based on type-based alias analysis.
13876 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
13877 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
13878 != &v->size, and therefore "v->size = 1; b->size = 2; return
13879 v->size;" must therefore return 1. This assumption is incorrect
13880 for Emacs, since it type-puns struct Lisp_Vector * with many other
13881 types. To fix this problem, this patch adds a new type struct
f904488f 13882 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
13883 and pseudovectors, and helps optimizing compilers not get fooled
13884 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
13885 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
13886 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
13887 the size member.
eab3844f
PE
13888 (XSETPVECTYPE): Rewrite in terms of new macro.
13889 (XSETPVECTYPESIZE): New macro, specifying both type and size.
13890 This is a bit clearer, and further avoids the possibility of
13891 undesirable aliasing.
13892 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 13893 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
13894 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
13895 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
13896 (ASIZE): Now uses header.size rather than size.
13897 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
13898 to avoid the hassle of writing XVECTOR (foo)->header.size.
13899 (struct vectorlike_header): New type.
eab3844f
PE
13900 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
13901 object, to help avoid aliasing.
13902 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
13903 (SUBRP): Likewise, since Lisp_Subr is a special case.
13904 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
13905 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
13906 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 13907 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
13908 changed to be "header.size" and "header.next".
13909 * buffer.h (struct buffer): Likewise.
13910 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
13911 * frame.h (struct frame): Likewise.
13912 * process.h (struct Lisp_Process): Likewise.
13913 * termhooks.h (struct terminal): Likewise.
13914 * window.c (struct save_window_data, struct saved_window): Likewise.
13915 * window.h (struct window): Likewise.
13916 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
13917 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
13918 * buffer.c (init_buffer_once): Likewise.
13919 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
13920 special case.
13921 * process.c (Fformat_network_address): Use local var for size,
13922 for brevity.
13923
0df1eac5
PE
13924 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
13925
847ab9d1 13926 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
13927 * data.c (atof): Remove decl; no longer used or needed.
13928 (digit_to_number): Move to lread.c.
13929 (Fstring_to_number): Use new string_to_number function, to be
13930 consistent with how the Lisp reader treats infinities and NaNs.
13931 Do not assume that floating-point numbers represent EMACS_INT
13932 without losing information; this is not true on most 64-bit hosts.
13933 Avoid double-rounding errors, by insisting on integers when
13934 parsing non-base-10 numbers, as the documentation specifies.
13935 * lisp.h (string_to_number): New decl, replacing ...
13936 (isfloat_string): Remove.
bc0a5c13 13937 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 13938 (read1): Do not accept +. and -. as integers; this
452f4150
PE
13939 appears to have been a coding error. Similarly, do not accept
13940 strings like +-1e0 as floating point numbers. Do not report
13941 overflow for integer overflows unless the base is not 10 which
13942 means we have no simple and reliable way to continue.
13943 Break out the floating-point parsing into a new
13944 function string_to_number, so that Fstring_to_number parses
13945 floating point numbers consistently with the Lisp reader.
04f2d78b 13946 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
13947 (E_CHAR, EXP_INT): Remove, replacing with ...
13948 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
13949 (string_to_number): New function, replacing isfloat_string.
13950 This function checks for valid syntax and produces the resulting
13951 Lisp float number too. Rework it so that string-to-number
bc0a5c13 13952 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
13953 so that overflow for non-base-10 numbers is reported only when
13954 there's no portable and simple way to convert to floating point.
452f4150 13955
67769ffc
PE
13956 * textprop.c (set_text_properties_1): Rewrite for clarity,
13957 and to avoid GCC warning about integer overflow.
13958
c20db43f
PE
13959 * intervals.h (struct interval): Use EMACS_INT for members
13960 where EMACS_UINT might cause problems. See
13961 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
13962 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
13963 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
13964 All uses changed.
37aa2f85
PE
13965 (offset_intervals): Tell GCC not to worry about length overflow
13966 when negating a negative length.
c20db43f 13967
2538aa2f
PE
13968 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
13969 (overrun_check_free): Likewise.
13970
f2d3008d
PE
13971 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
13972 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
13973 word size.
13974
ec8df744
PE
13975 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13976 (gnutls_make_error): Rename local to avoid shadowing.
13977 (gnutls_emacs_global_deinit): ifdef out; not used.
13978 (Fgnutls_boot): Use const for pointer to readonly storage.
13979 Comment out unused local. Fix pointer signedness problems.
13980
640ee02d
PE
13981 * lread.c (openp): Don't stuff size_t into an 'int'.
13982 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
13983 about possible signed overflow.
13984
6048fb2a
PE
13985 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13986 (GDK_KEY_g): Don't define if already defined.
13987 (xg_prepare_tooltip): Avoid pointer signedness problem.
13988 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
13989
fa3c87e1
PE
13990 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
13991 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
13992
2172544b
PE
13993 * xfns.c (Fx_window_property): Simplify a bit,
13994 to make a bit faster and to avoid GCC 4.6.0 warning.
13995 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
13996
9b821a21
PE
13997 * fns.c (internal_equal): Don't assume size_t fits in int.
13998
3c616cfa
PE
13999 * alloc.c (compact_small_strings): Tighten assertion a little.
14000
c2982e87
PE
14001 Replace pEd with more-general pI, and fix some printf arg casts.
14002 * lisp.h (pI): New macro, generalizing old pEd macro to other
14003 conversion specifiers. For example, use "...%"pI"d..." rather
14004 than "...%"pEd"...".
14005 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 14006 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
14007 * alloc.c (check_pure_size): Don't overflow by converting size to int.
14008 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
14009 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
14010 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
14011 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
14012 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
14013 64-bit hosts.
14014 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
14015 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
14016 * print.c (safe_debug_print, print_object): Likewise.
14017 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
14018 to int.
6f04d126
PE
14019 Use pI instead of if-then-else-abort. Use %p to avoid casts,
14020 avoiding the 0 flag, which is not portable.
c2982e87
PE
14021 * process.c (Fmake_network_process): Use pI to avoid cast.
14022 * region-cache.c (pp_cache): Likewise.
14023 * xdisp.c (decode_mode_spec): Likewise.
14024 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
14025 behavior on 64-bit hosts with printf arg.
6f04d126 14026 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
14027 (x_stop_queuing_selection_requests): Likewise.
14028 (x_get_window_property): Don't truncate byte count to an 'int'
14029 when tracing.
0b432f21 14030
5e073ec7
PE
14031 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
14032 here, since it parses constructs like leading '-' and spaces,
14033 which are not wanted; and it overflows with large numbers.
14034 Instead, simply match F[0-9]+, which is what is wanted anyway.
14035
36372bf9
PE
14036 * alloc.c: Remove unportable assumptions about struct layout.
14037 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
14038 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
14039 (allocate_vectorlike, make_pure_vector): Use the new macros,
14040 plus offsetof, to remove unportable assumptions about struct layout.
14041 These assumptions hold on all porting targets that I know of, but
14042 they are not guaranteed, they're easy to remove, and removing them
14043 makes further changes easier.
14044
0b432f21
PE
14045 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
14046 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
14047 (string_overrun_cookie): Now const. Use initializers that
14048 don't formally overflow signed char, to avoid warnings.
000098c1
PE
14049 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
14050 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
14051 (allocate_buffer): Don't assume sizeof (struct buffer) is a
14052 multiple of sizeof (EMACS_INT); it need not be, if
14053 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 14054 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 14055
895009e1
JB
140562011-04-26 Juanma Barranquero <lekktu@gmail.com>
14057
14058 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
14059
6a7a1b0b
TZ
140602011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
14061
14062 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 14063 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
14064 Reported by Paul Eggert <eggert@cs.ucla.edu>.
14065
841a1577 140662011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
14067
14068 * lisp.h (Qdebug): List symbol.
895009e1 14069 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
14070 * keyboard.c (debug-on-event): New variable.
14071 (handle_user_signal): Break into debugger when debug-on-event
14072 matches the current signal symbol.
14073
f2d3ba6f
DN
140742011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
14075
14076 * alloc.c (check_sblock, check_string_bytes)
14077 (check_string_free_list): Convert to standard C.
14078
42ce4c63
TZ
140792011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
14080
14081 * w32.c (emacs_gnutls_push): Fix typo.
14082
825cd63c
EZ
140832011-04-25 Eli Zaretskii <eliz@gnu.org>
14084
fb11d64d
EZ
14085 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
14086 "cast to pointer from integer of different size".
14087
825cd63c
EZ
14088 Improve doprnt and its use in verror. (Bug#8545)
14089 * doprnt.c (doprnt): Document the set of format control sequences
14090 supported by the function. Use SAFE_ALLOCA instead of always
14091 using `alloca'.
14092
14093 * eval.c (verror): Don't limit the buffer size at size_max-1, that
14094 is one byte too soon. Don't use xrealloc; instead xfree and
14095 xmalloc anew.
14096
e061a11b
TZ
140972011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
14098
14099 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
14100 callbacks stage.
14101
14102 * gnutls.c: Renamed global_initialized to
14103 gnutls_global_initialized. Added internals for the
14104 :verify-hostname-error, :verify-error, and :verify-flags
14105 parameters of `gnutls-boot' and documented those parameters in the
14106 docstring. Start callback support.
9173deec
JB
14107 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
14108 unless a fatal error occurred. Call gnutls_alert_send_appropriate
14109 on error. Return error code.
e061a11b
TZ
14110 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
14111 (emacs_gnutls_read): Likewise.
14112 (Fgnutls_boot): Return handshake error code.
14113 (emacs_gnutls_handle_error): New function.
14114 (wsaerror_to_errno): Likewise.
14115
14116 * w32.h (emacs_gnutls_pull): Add prototype.
14117 (emacs_gnutls_push): Likewise.
14118
14119 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
14120 (emacs_gnutls_push): Likewise.
14121
141222011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
14123
14124 * process.c (wait_reading_process_output): Check if GnuTLS
14125 buffered some data internally if no FDs are set for TLS
14126 connections.
14127
14128 * makefile.w32-in (OBJ2): Add gnutls.$(O).
14129 (LIBS): Link to USER_LIBS.
14130 ($(BLD)/gnutls.$(0)): New target.
14131
fa6996bc
EZ
141322011-04-24 Eli Zaretskii <eliz@gnu.org>
14133
eb35682e
EZ
14134 * xdisp.c (handle_single_display_spec): Rename the
14135 display_replaced_before_p argument into display_replaced_p, to
14136 make it consistent with the commentary. Fix typos in the
14137 commentary.
14138
e2ad650c
EZ
14139 * textprop.c (syms_of_textprop): Remove dead code.
14140 (copy_text_properties): Delete obsolete commentary about an
14141 interface that was deleted long ago. Fix typos in the description
14142 of arguments.
14143
1b2de274
EZ
14144 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
14145 to changes in oldXMenu/XMenu.h from 2011-04-16.
14146 <menu_help_message, prev_menu_help_message>: Constify.
14147 (IT_menu_make_room): menu->help_text is now `const char **';
14148 adjust.
14149
14150 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
14151 to changes in oldXMenu/XMenu.h from 2011-04-16.
14152 (struct XMenu): Declare `help_text' `const char **'.
14153
14154 * xfaces.c <Qunspecified>: Make extern again.
14155
14156 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 14157 required by POSIX.
1b2de274 14158
762b15be
EZ
14159 * doc.c (get_doc_string): Improve the format passed to `error'.
14160
14161 * doprnt.c (doprnt): Improve commentary.
14162
14163 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
14164
14165 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
14166 them with etags.
14167
f1052e5d
EZ
14168 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
14169 changes in globals.h immediately force recompilation.
762b15be
EZ
14170 (TAGS): Depend on $(CURDIR)/m/intel386.h and
14171 $(CURDIR)/s/ms-w32.h.
14172 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 14173
fa6996bc
EZ
14174 * character.c (Fchar_direction): Function deleted.
14175 (syms_of_character): Don't defsubr it.
14176 <char-direction-table>: Deleted.
14177
e6c3da20
EZ
141782011-04-23 Eli Zaretskii <eliz@gnu.org>
14179
14180 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
14181 * doprnt.c: Include limits.h.
14182 (SIZE_MAX): New macro.
04f2d78b
CB
14183 (doprnt): Return a size_t value. 2nd arg is now size_t.
14184 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
14185 Improve overflow protection. Support `l' modifier for integer
14186 conversions. Support %l conversion. Don't assume an EMACS_INT
14187 argument for integer conversions and for %c.
14188
14189 * lisp.h (doprnt): Restore prototype.
14190
14191 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
14192 $(SRC)/character.h.
14193
14194 * Makefile.in (base_obj): Add back doprnt.o.
14195
14196 * deps.mk (doprnt.o): Add back prerequisites.
14197 (callint.o): Depend on character.h.
14198
14199 * eval.c (internal_lisp_condition_case): Include the handler
14200 representation in the error message.
14201 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
14202 when breaking from the loop.
14203
14204 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
14205
14206 * callint.c (Fcall_interactively): When displaying error message
14207 about invalid control letter, pass the character's codepoint, not
14208 a pointer to its multibyte form. Improve display of the character
14209 in octal and display also its hex code.
14210
14211 * character.c (char_string): Use %x to display the (unsigned)
14212 codepoint of an invalid character, to avoid displaying a bogus
14213 negative value.
14214
14215 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
14216 `error', not SYMBOL_NAME itself.
14217
14218 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
14219 character arguments to `error'.
14220
14221 * charset.c (check_iso_charset_parameter): Fix incorrect argument
14222 to `error' in error message about FINAL_CHAR argument. Make sure
14223 FINAL_CHAR is a character, and use %c when it is passed as
14224 argument to `error'.
14225
4ffd0d6b 142262011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
14227
14228 * s/ms-w32.h (localtime): Redirect to sys_localtime.
14229
14230 * w32.c: Include <time.h>.
14231 (sys_localtime): New function.
14232
4ffd0d6b 142332011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
14234
14235 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
14236
4ffd0d6b 14237 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 14238
4ffd0d6b 142392011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 14240
4ffd0d6b
GM
14241 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
14242 zombies (Bug#8467).
aac0c6e3 14243
04c56954
EZ
142442011-04-19 Eli Zaretskii <eliz@gnu.org>
14245
14246 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
14247 gl_state.e_property when gl_state.object is Qt.
14248
14249 * insdel.c (make_gap_larger): Remove limitation of buffer size
14250 to <= INT_MAX.
14251
16a43933
CY
142522011-04-18 Chong Yidong <cyd@stupidchicken.com>
14253
14254 * xdisp.c (lookup_glyphless_char_display)
14255 (produce_glyphless_glyph): Handle cons cell entry in
14256 glyphless-char-display.
14257 (Vglyphless_char_display): Document it.
14258
14259 * term.c (produce_glyphless_glyph): Handle cons cell entry in
14260 glyphless-char-display.
14261
4581706e
CY
142622011-04-17 Chong Yidong <cyd@stupidchicken.com>
14263
14264 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
14265
14266 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
14267
14268 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
14269 definition for no-X builds.
14270
4887c6e2 142712011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 14272
fd35b6f9
PE
14273 Static checks with GCC 4.6.0 and non-default toolkits.
14274
5c1ccb01
PE
14275 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
14276
006c5daa
PE
14277 * process.c (keyboard_bit_set): Define only if SIGIO.
14278 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
14279 (send_process): Repair possible setjmp clobbering.
14280
efc736d3
PE
14281 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
14282
4e2fe2e6
PE
14283 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
14284
f97334a2
PE
14285 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
14286
4e75f29d
PE
14287 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
14288 Define only if needed.
14289
90efadd1
PE
14290 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
14291 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 14292 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 14293
3c647824
PE
14294 * dispextern.h (struct redisplay_interface): Rename param
14295 to avoid shadowing.
e264f262 14296 * termhooks.h (struct terminal): Likewise.
761383f4 14297 * xterm.c (xembed_send_message): Likewise.
3c647824 14298
b58c5c4a
PE
14299 * insdel.c (make_gap_smaller): Define only if
14300 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
14301
cad59032
PE
14302 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
14303 it.
14304
c339dc2e
PE
14305 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
14306 so that we aren't warned about unused symbols.
14307
91a3e27b
PE
14308 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
14309
399c71d3 14310 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 14311
8ffc96f5
PE
14312 * xfns.c (x_real_positions): Mark locals as initialized.
14313
eef9bc79
PE
14314 * xmenu.c (xmenu_show): Don't use uninitialized vars.
14315
098db9dd
PE
14316 * xterm.c: Fix problems found by static analysis with other toolkits.
14317 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
14318 (x_dispatch_event): Declare static if USE_GTK, and
14319 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 14320 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 14321 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
14322 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
14323 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 14324
eb18f6cc
PE
14325 * xmenu.c (menu_help_callback): Pointer type fixes.
14326 Use const pointers when pointing at readonly data. Avoid pointer
14327 signedness clashes.
14328 (FALSE): Remove unused macro.
14329 (update_frame_menubar): Remove unused decl.
14330
1fe72bf8
PE
14331 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
14332
60d9e1db
PE
14333 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
14334 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
14335 (single_menu_item): Rename local to avoid shadowing.
14336
39261c26
PE
14337 * keyboard.c (make_lispy_event): Remove unused local var.
14338
018c5e19
PE
14339 * frame.c, frame.h (x_get_resource_string): Bring this back, but
14340 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
14341
63d2b86e
PE
14342 * bitmaps: Change bitmaps from unsigned char back to the X11
14343 compatible char. Avoid the old compiler warnings about
14344 out-of-range initializers by using, for example, '\xab' rather
14345 than 0xab.
14346
aefd87e1
PE
14347 * xgselect.c (xgselect_initialize): Check vs interface
14348 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
14349
bf501fb9
PE
14350 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
14351
e9829fdf
PE
14352 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
14353 to read-only memory.
14354
1086c095
PE
14355 * fns.c (vector): Remove; this old hack is no longer needed.
14356
2baccd04 14357 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 14358 Remove unused var.
dde42981 14359 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 14360
72391843 14361 * xrdb.c (x_load_resources): Omit unused local.
3565b346 14362
436c16df 14363 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 14364 (x_window): Rename locals to avoid shadowing.
dc5ddd85 14365 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 14366
92bb796d 14367 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 14368 (x_term_init): Remove local to avoid shadowing.
92bb796d 14369
764430a3 14370 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
14371
14372 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
14373 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
14374
d1dfb56c
EZ
143752011-04-16 Eli Zaretskii <eliz@gnu.org>
14376
c4354cb4
EZ
14377 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
14378
d1dfb56c
EZ
14379 Fix regex.c, syntax.c and friends for buffers > 2GB.
14380 * syntax.h (struct gl_state_s): Declare character position members
14381 EMACS_INT.
14382
14383 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
14384
04f2d78b
CB
14385 * textprop.c (verify_interval_modification, interval_of):
14386 Declare arguments EMACS_INT.
d1dfb56c
EZ
14387
14388 * intervals.c (adjust_intervals_for_insertion): Declare arguments
14389 EMACS_INT.
14390
14391 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
14392
14393 * indent.c (Fvertical_motion): Local variable it_start is now
14394 EMACS_INT.
14395
14396 * regex.c (re_match, re_match_2, re_match_2_internal)
14397 (bcmp_translate, regcomp, regexec, print_double_string)
14398 (group_in_compile_stack, re_search, re_search_2, regex_compile)
14399 (re_compile_pattern, re_exec): Declare arguments and local
14400 variables `size_t' and `ssize_t' and return values `regoff_t', as
14401 appropriate.
14402 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
14403 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
14404 <compile_stack_type>: `size' and `avail' are now `size_t'.
14405
14406 * regex.h <regoff_t>: Use ssize_t, not int.
14407 (re_search, re_search_2, re_match, re_match_2): Arguments that
14408 specify buffer/string position and length are now ssize_t and
14409 size_t. Return type is regoff_t.
14410
613052cd
BK
144112011-04-16 Ben Key <bkey76@gmail.com>
14412
14413 * nsfont.m: Fixed bugs in ns_get_family and
14414 ns_descriptor_to_entity that were caused by using free to
14415 deallocate memory blocks that were allocated by xmalloc (via
14416 xstrdup). This caused Emacs to crash when compiled with
14417 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
14418 --enable-checking=xmallocoverrun). xfree is now used to
14419 deallocate these memory blocks.
14420
4170f62f 144212011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 14422
71b41406
PE
14423 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
14424
9587a89d
PE
14425 emacs_write: Accept and return EMACS_INT for sizes.
14426 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
14427 et seq.
14428 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
14429 Accept and return EMACS_INT.
14430 (emacs_gnutls_write): Return the number of bytes written on
14431 partial writes.
14432 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
14433 (emacs_read, emacs_write): Remove check for negative size, as the
14434 Emacs source code has been audited now.
9587a89d
PE
14435 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
14436 (emacs_read, emacs_write): Use it.
273a5f82
PE
14437 * process.c (send_process): Adjust to the new signatures of
14438 emacs_write and emacs_gnutls_write. Do not attempt to store
14439 a byte offset into an 'int'; it might overflow.
9587a89d 14440 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 14441
3e047f51
PE
14442 * sound.c: Don't assume sizes fit in 'int'.
14443 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 14444 Return EMACS_INT, not int.
3e047f51 14445 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
14446 Accept EMACS_INT, not int.
14447 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
14448 record read return values.
14449
cc39a9db
BK
144502011-04-15 Ben Key <bkey76@gmail.com>
14451
c9d0ec6d
JB
14452 * keyboard.c (Qundefined): Don't declare static since it is used
14453 in nsfns.m.
14454 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
14455 static since they are used in nsfont.m.
cc39a9db 14456
6c60eb9f
SM
144572011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
14458
14459 * process.c (Qprocessp): Don't declare static.
14460 * lisp.h (Qprocessp): Declare again.
14461
7990b61a
JB
144622011-04-15 Juanma Barranquero <lekktu@gmail.com>
14463
14464 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
14465
5d4cb038
PE
144662011-04-14 Paul Eggert <eggert@cs.ucla.edu>
14467
8bd7b830 14468 Improve C-level modularity by making more things 'static'.
cd64ea1d 14469
e3b27b31
PE
14470 Don't publish debugger-only interfaces to other modules.
14471 * lisp.h (safe_debug_print, debug_output_compilation_hack):
14472 (verify_bytepos, count_markers): Move decls to the only modules
14473 that need them.
14474 * region-cache.h (pp_cache): Likewise.
14475 * window.h (check_all_windows): Likewise.
14476 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
14477
5d4cb038
PE
14478 * sysdep.c (croak): Now static, if
14479 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
14480 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
14481
14482 * alloc.c (refill_memory_reserve): Now static if
14483 !defined REL_ALLOC || defined SYSTEM_MALLOC.
14484 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 14485
e87b6180
PE
14486 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
14487 Define only if USE_LUCID.
14488
ac64929e
PE
14489 * xrdb.c (x_customization_string, x_rm_string): Now static.
14490
6f37259d
PE
14491 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
14492 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
14493
1683e3ab
PE
14494 * xdisp.c (draw_row_with_mouse_face): Now static.
14495 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
14496
de9c2632
PE
14497 * window.h (check_all_windows): Mark externally visible.
14498
2b96acb7
PE
14499 * window.c (window_deletion_count): Now static.
14500
14501 * undo.c: Make symbols static if they're not exported.
14502 (last_undo_buffer, last_boundary_position, pending_boundary):
14503 Now static.
14504
50436f33
PE
14505 * textprop.c (interval_insert_behind_hooks): Now static.
14506 (interval_insert_in_front_hooks): Likewise.
14507
64520e5c
PE
14508 * term.c: Make symbols static if they're not exported.
14509 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
14510 (max_frame_lines, tty_set_terminal_modes):
14511 (tty_reset_terminal_modes, tty_turn_off_highlight):
14512 (get_tty_terminal): Now static.
14513 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
14514 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 14515 HAVE_WINDOW_SYSTEM.
64520e5c
PE
14516 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
14517 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
14518
1fa53021
PE
14519 * sysdep.c: Make symbols static if they're not exported.
14520 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
14521 Now static.
14522 (sigprocmask_set, full_mask): Remove; unused.
14523 (wait_debugging): Mark as visible.
14524 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
14525 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
14526
d4b43b22
PE
14527 * syntax.c (syntax_temp): Define only if !__GNUC__.
14528
b7c513d0
PE
14529 * sound.c (current_sound_device, current_sound): Now static.
14530
989b29ad
PE
14531 * search.c (searchbufs, searchbuf_head): Now static.
14532
13a55a78
PE
14533 * scroll.c (scroll_cost): Remove; unused.
14534 * dispextern.h (scroll_cost): Remove decl.
14535
de68a1fc
PE
14536 * region-cache.h (pp_cache): Mark as externally visible.
14537
40ccffa6
PE
14538 * process.c: Make symbols static if they're not exported.
14539 (process_tick, update_tick, create_process, chan_process):
14540 (Vprocess_alist, proc_buffered_char, datagram_access):
14541 (fd_callback_data, send_process_frame, process_sent_to): Now static.
14542 (deactivate_process): Mark defn as static, as well as decl.
14543 * lisp.h (create_process): Remove decl.
14544 * process.h (chan_process, Vprocess_alist): Remove decls.
14545
ad64fc97
PE
14546 * print.c: Make symbols static if they're not exported.
14547 (print_depth, new_backquote_output, being_printed, print_buffer):
14548 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
14549 (print_interval, print_number_index, initial_stderr_stream):
14550 Now static.
14551 * lisp.h (Fprinc): Remove decl.
14552 (debug_output_compilation_hack): Mark as externally visible.
14553
adddb265
PE
14554 * sysdep.c (croak): Move decl from here to syssignal.h.
14555 * syssignal.h (croak): Put it here, so the API can be checked when
14556 'croak' is called from dissociate_if_controlling_tty.
14557
1717ede2
PE
14558 * minibuf.c: Make symbols static if they're not exported.
14559 (minibuf_save_list, choose_minibuf_frame): Now static.
14560 * lisp.h (choose_minibuf_frame): Remove decl.
14561
fa5fb2bc
PE
14562 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
14563
1e3890d1
PE
14564 * lread.c: Make symbols static if they're not exported.
14565 (read_objects, initial_obarray, oblookup_last_bucket_number):
14566 Now static.
14567 (make_symbol): Remove; unused.
14568 * lisp.h (initial_obarray, make_symbol): Remove decls.
14569
8a1414fa
PE
14570 * keyboard.c: Make symbols static if they're not exported.
14571 (single_kboard, recent_keys_index, total_keys, recent_keys):
14572 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
14573 (this_single_command_key_start, echoing, last_auto_save):
14574 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
14575 (command_loop, echo_now, keyboard_init_hook, help_char_p):
14576 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
14577 (Vlispy_mouse_stem, double_click_count):
14578 Now static.
14579 (force_auto_save_soon): Define only if SIGDANGER.
14580 (ignore_mouse_drag_p): Now static if
14581 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
14582 (print_help): Remove; unused.
14583 (stop_character, last_timer_event): Mark as externally visible.
14584 * keyboard.h (ignore_mouse_drag_p): Declare only if
14585 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
14586 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
14587 * lisp.h (echoing): Remove decl.
14588 (force_auto_save_soon): Declare only if SIGDANGER.
14589 * xdisp.c (redisplay_window): Simplify code, to make it more
14590 obvious that ignore_mouse_drag_p is not accessed if !defined
14591 USE_GTK && !defined HAVE_NS.
14592
93ea6e8f
PE
14593 * intervals.c: Make symbols static if they're not exported.
14594 (merge_properties_sticky, merge_interval_right, delete_interval):
14595 Now static.
14596 * intervals.h (merge_interval_right, delete_interval): Remove decls.
14597
77382fcc
PE
14598 * insdel.c: Make symbols static if they're not exported.
14599 However, leave prepare_to_modify_buffer alone. It's never
14600 called from outside this function, but that appears to be a bug.
14601 (combine_after_change_list, combine_after_change_buffer):
4889fc82 14602 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
14603 (adjust_after_replace_noundo): Remove; unused.
14604 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 14605 (signal_before_change): Remove decls.
77382fcc 14606
9306c32e
PE
14607 * indent.c (val_compute_motion, val_vmotion): Now static.
14608
cd44d2eb
PE
14609 * image.c: Make symbols static if they're not exported.
14610 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
14611 if USE_GTK.
14612 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
14613 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
14614
ad9a7a06
PE
14615 * fringe.c (standard_bitmaps): Now static.
14616 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
14617
81626931
PE
14618 * frame.c: Make symbols static if they're not exported.
14619 (x_report_frame_params, make_terminal_frame): Now static.
14620 (get_frame_param): Now static, unless HAVE_NS.
14621 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
14622 (x_get_resource_string): Remove; not used.
14623 * frame.h (make_terminal_frame, x_report_frame_params):
14624 (x_get_resource_string); Remove decls.
14625 (x_fullscreen_adjust): Declare only if WINDOWSNT.
14626 * lisp.h (get_frame_param): Declare only if HAVE_NS.
14627
239f9db9
PE
14628 * font.c, fontset.c: Make symbols static if they're not exported.
14629 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
14630 (FACE_SUITABLE_FOR_CHAR_P): Use it.
14631 * font.c (font_close_object): Now static.
14632 * font.h (font_close_object): Remove.
14633 * fontset.c (FONTSET_OBJLIST): Remove.
14634 (free_realized_fontset) #if-0 the body, which does nothing.
14635 (face_suitable_for_char_p): #if-0, as it's never called.
14636 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
14637 * xfaces.c (face_at_string_position):
14638 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
14639 since 0 is always ASCII.
14640
dfcf3579
PE
14641 * fns.c (weak_hash_tables): Now static.
14642
5045092b
PE
14643 * fileio.c: Make symbols static if they're not exported.
14644 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
14645 (Vwrite_region_annotation_buffers): Now static.
14646
57a96f5c
PE
14647 * eval.c: Make symbols static if they're not exported.
14648 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
14649 * lisp.h (backtrace_list): Remove decl.
14650
35f08c38
PE
14651 * emacs.c: Make symbols static if they're not exported.
14652 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
14653 (fatal_error_code, fatal_error_signal_hook, standard_args):
14654 Now static.
14655 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
14656 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
14657 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
14658 * lisp.h (fatal_error_signal_hook): Remove decl.
14659 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
14660
f44bd759
PE
14661 * editfns.c: Move a (normally-unused) function to its only use.
14662 * editfns.c, lisp.h (get_operating_system_release): Remove.
14663 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
14664 worth the hassle of breaking this out.
14665
b532497d
PE
14666 * xterm.c: Make symbols static if they're not exported.
14667 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
14668 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
14669 (x_destroy_window, x_delete_display):
14670 Now static.
14671 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
14672 (x_mouse_leave): Remove; unused.
14673 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
14674 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
14675 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
14676 Remove decls.
14677 (x_mouse_leave): Declare only if WINDOWSNT.
14678 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
14679 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
14680 USE_X_TOOLKIT.
14681
1675728f
PE
14682 * ftxfont.c: Make symbols static if they're not exported.
14683 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
14684 HAVE_FREETYPE.
14685 * font.h (ftxfont_driver): Likewise.
14686
e4cebfca
PE
14687 * xfns.c: Make symbols static if they're not exported.
14688 (x_last_font_name, x_display_info_for_name):
14689 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
14690 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
14691 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
14692 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
14693 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
14694 (last_show_tip_args): Now static.
14695 (xic_defaut_fontset, xic_create_fontsetname): Define only if
14696 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
14697 (x_screen_planes): Remove; unused.
14698 * dispextern.h (x_screen_planes): Remove decl.
14699
5bf46f05
PE
14700 * dispnew.c: Make symbols static if they're not exported.
14701 * dispextern.h (redraw_garbaged_frames, scrolling):
14702 (increment_row_positions): Remove.
14703 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
14704 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
14705 Now static.
14706 (redraw_garbaged_frames): Remove; unused.
14707
435f4c28
PE
14708 * xfaces.c: Make symbols static if they're not exported.
14709 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
14710 Remove decls.
14711 * xterm.h (defined_color): Remove decls.
14712 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
14713 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
14714 (menu_face_changed_default, defined_color, free_realized_face):
14715 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
14716 (ascii_face_of_lisp_face): Remove; unused.
14717
8524aef3
PE
14718 * xdisp.c: Make symbols static if they're not exported.
14719 * dispextern.h (scratch_glyph_row, window_box_edges):
14720 (glyph_to_pixel_coords, set_cursor_from_row):
14721 (get_next_display_element, set_iterator_to_next):
14722 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
14723 (show_mouse_face): Remove decls
14724 * frame.h (message_buf_print): Likewise.
14725 * lisp.h (pop_message, set_message, check_point_in_composition):
14726 Likewise.
14727 * xterm.h (set_vertical_scroll_bar): Likewise.
14728 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
14729 (message_buf_print, scratch_glyph_row, displayed_buffer):
14730 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
14731 (get_next_display_element, show_mouse_face, window_box_edges):
14732 (frame_to_window_pixel_xy, check_point_in_composition):
14733 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
14734 (glyph_to_pixel_coords): Remove; unused.
14735
16390cd2
PE
14736 * dired.c (file_name_completion): Now static.
14737
14738 * dbusbind.c (xd_in_read_queued_messages): Now static.
14739
a25f4dfa
PE
14740 * lisp.h (circular_list_error, FOREACH): Remove; unused.
14741 * data.c (circular_list_error): Remove.
14742
14a9c8df
PE
14743 * commands.h (last_point_position, last_point_position_buffer):
14744 (last_point_position_window): Remove decls.
14745 * keyboard.c: Make these variables static.
14746
04f2d78b
CB
14747 * coding.h (coding, code_convert_region, encode_coding_gap):
14748 Remove decls.
74ab6df5
PE
14749 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
14750 (iso_code_class, detect_coding, code_convert_region): Now static.
14751 (encode_coding_gap): Remove; unused.
14752
38dfbee1
PE
14753 * chartab.c (chartab_chars, chartab_bits): Now static.
14754
a2cb4e63
PE
14755 * charset.h (charset_iso_8859_1): Remove decl.
14756 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
14757 Now static.
14758
127198fd
PE
14759 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
14760 * ccl.c (Vccl_program_table): Now static.
14761 (check_ccl_update): Remove; unused.
14762
d85b608f
PE
14763 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
14764 * category.h: ... from here.
14765 * category.c (check_category_table, set_category_set): Now static.
14766
31cd66f3
PE
14767 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
14768 * lisp.h: Remove these decls.
14769
c358e587
PE
14770 * buffer.c (buffer_count): Remove unused var.
14771
e78aecca
PE
14772 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
14773 so that it's not optimized away.
14774 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
14775 * dispextern.h (bidi_dump_cached_states): Remove, since it's
14776 exported only to the debugger.
14777
e192d7d3 14778 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 14779 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 14780
92470028
PE
14781 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
14782 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
14783 was inaccessible from Lisp.
14784 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
14785 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
14786
244ed907
PE
14787 alloc.c: Import and export fewer symbols, and remove unused items.
14788 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
14789 is defined.
14790 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
14791 it's not optimized away by whole-program optimization.
14792 (message_enable_multibyte, free_misc): Remove.
14793 (catchlist, handlerlist, mark_backtrace):
14794 Declare only if BYTE_MARK_STACK.
14795 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
14796 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
14797 (message_enable_multibyte): Remove decl.
14798 (free_misc, interval_free_list, float_block, float_block_index):
14799 (n_float_blocks, float_free_list, cons_block, cons_block_index):
14800 (cons_free_list, last_marked_index):
14801 Now static.
14802 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
14803 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
14804 (mark_backtrace): Define only if BYTE_MARK_STACK.
14805 * xdisp.c (message_enable_multibyte): Now static.
14806
61c2b50e 14807 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
14808 This makes it easier for human readers (and static analyzers)
14809 to see whether these variables are used from other modules.
14810 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
14811 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
14812 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
14813 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
14814 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
14815 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
14816 * xmenu.c, xselect.c:
14817 Declare Q* vars static if they are not used in other modules.
14818 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
14819 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
14820 Remove decls of unexported vars.
14821 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
14822
95c82688
PE
14823 * lisp.h (DEFINE_FUNC): Make sname 'static'.
14824
16a97296
PE
14825 Make Emacs functions such as Fatom 'static' by default.
14826 This makes it easier for human readers (and static analyzers)
14827 to see whether these functions can be called from other modules.
14828 DEFUN now defines a static function. To make the function external
14829 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
14830 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
14831 (Finit_image_library):
16a97296
PE
14832 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
14833 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
14834 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
14835 Remove decls, since these functions are now static.
14836 (Funintern, Fget_internal_run_time): New decls, since these functions
14837 were already external.
95c82688 14838
16a97296
PE
14839 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
14840 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
14841 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
14842 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
14843 * keyboard.c, keymap.c, lread.c:
14844 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
14845 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
14846 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
14847 Mark functions with DEFUE instead of DEFUN,
14848 if they are used in other modules.
14849 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
14850 decls for now-static functions.
14851 * buffer.h (Fdelete_overlay): Remove decl.
14852 * callproc.c (Fgetenv_internal): Mark as internal.
14853 * composite.c (Fremove_list_of_text_properties): Remove decl.
14854 (Fcomposition_get_gstring): New forward static decl.
14855 * composite.h (Fcomposite_get_gstring): Remove decl.
14856 * dired.c (Ffile_attributes): New forward static decl.
14857 * doc.c (Fdocumntation_property): New forward static decl.
14858 * eval.c (Ffetch_bytecode): New forward static decl.
14859 (Funintern): Remove extern decl; now in .h file where it belongs.
14860 * fileio.c (Fmake_symbolic_link): New forward static decl.
14861 * image.c (Finit_image_library): New forward static decl.
14862 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
14863 * intervals.h (Fprevious_property_change):
14864 (Fremove_list_of_text_properties): Remove decls.
14865 * keyboard.c (Fthis_command_keys): Remove decl.
14866 (Fcommand_execute): New forward static decl.
14867 * keymap.c (Flookup_key): New forward static decl.
14868 (Fcopy_keymap): Now static.
14869 * keymap.h (Flookup_key): Remove decl.
14870 * process.c (Fget_process): New forward static decl.
14871 (Fprocess_datagram_address): Mark as internal.
14872 * syntax.c (Fsyntax_table_p): New forward static decl.
14873 (skip_chars): Remove duplicate decl.
14874 * textprop.c (Fprevious_property_change): New forward static decl.
14875 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
14876 Now internal.
14877 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
14878 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
14879
785bbd42
PE
14880 * editfns.c (Fformat): Remove unreachable code.
14881
8b913b57
AS
148822011-04-14 Andreas Schwab <schwab@linux-m68k.org>
14883
14884 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
14885 change. (Bug#8496)
14886
a6744a35
EZ
148872011-04-13 Eli Zaretskii <eliz@gnu.org>
14888
14889 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
14890 when at ZV. (Bug#8487)
14891
e7974947
AS
148922011-04-12 Andreas Schwab <schwab@linux-m68k.org>
14893
baad03f0
AS
14894 * charset.c (Fclear_charset_maps): Use xfree instead of free.
14895 (Bug#8437)
14896 * keyboard.c (parse_tool_bar_item): Likewise.
14897 * sound.c (sound_cleanup, alsa_close): Likewise.
14898 * termcap.c (tgetent): Likewise.
14899 * xfns.c (x_default_font_parameter): Likewise.
14900 * xsettings.c (read_and_apply_settings): Likewise.
14901
e7974947
AS
14902 * alloc.c (overrun_check_malloc, overrun_check_realloc)
14903 (overrun_check_free): Protoize.
14904
28272684
PE
149052011-04-12 Paul Eggert <eggert@cs.ucla.edu>
14906
14907 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
14908 since callers should never pass a negative size.
14909 Change the signature to match that of plain 'read' and 'write'; see
14910 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
14911 * lisp.h: Update prototypes of emacs_write and emacs_read.
14912
11997c76
EZ
149132011-04-11 Eli Zaretskii <eliz@gnu.org>
14914
14915 * xdisp.c (redisplay_window): Don't try to determine the character
14916 position of the scroll margin if the window start point w->startp
e896f03c 14917 is outside the buffer's accessible region. (Bug#8468)
11997c76 14918
8a2cbd72
EZ
149192011-04-10 Eli Zaretskii <eliz@gnu.org>
14920
14921 Fix write-region and its subroutines for buffers > 2GB.
14922 * fileio.c (a_write, e_write): Modify declaration of arguments and
14923 local variables to support buffers larger than 2GB.
14924 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
14925
14926 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
14927 argument, local variables, and return value.
14928
14929 * lisp.h: Update prototypes of emacs_write and emacs_read.
14930
14931 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
14932
4073e537 149332011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 14934
1ebfdcb6
PE
14935 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
14936
b2ded58d
PE
14937 Fix more problems found by GCC 4.6.0's static checks.
14938
7d66342c
PE
14939 * xdisp.c (vmessage): Use a better test for character truncation.
14940
bbf47d44
PE
14941 * charset.c (load_charset_map): <, not <=, for optimization,
14942 and to avoid potential problems with integer overflow.
9248994d 14943 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 14944 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 14945 * editfns.c (Fformat): Likewise.
1e69125e 14946 * syntax.c (skip_chars): Likewise.
3befa583 14947
e3019616
PE
14948 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
14949 This also lets GCC 4.6.0 generate slightly better loop code.
14950
becfa255
PE
14951 * callint.c (Fcall_interactively): <, not <=, for optimization.
14952 (Fcall_interactively): Count the number of arguments produced,
14953 not the number of arguments given. This is simpler and lets GCC
14954 4.6.0 generate slightly better code.
14955
dae0cd48
PE
14956 * ftfont.c: Distingish more carefully between FcChar8 and char.
14957 The previous code passed unsigned char * to a functions like
14958 strlen and xstrcasecmp that expect char *, which does not
14959 conform to the C standard.
14960 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
14961 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
14962 char * when the C standard requires it.
14963
76032d70
PE
14964 * keyboard.c (read_char): Remove unused var.
14965
eb3f1cc8
PE
14966 * eval.c: Port to Windows vsnprintf (Bug#8435).
14967 Include <limits.h>.
14968 (SIZE_MAX): Define if the headers do not.
14969 (verror): Do not give up if vsnprintf returns a negative count.
14970 Instead, grow the buffer. This ports to Windows vsnprintf, which
14971 does not conform to C99. Problem reported by Eli Zaretskii.
14972 Also, simplify the allocation scheme, by avoiding the need for
14973 calling realloc, and removing the ALLOCATED variable.
14974
70476b54
PE
14975 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
14976
12020a9e
PE
14977 Remove invocations of doprnt, as Emacs now uses vsnprintf.
14978 But keep the doprint source code for now, as we might revamp it
14979 and use it again (Bug#8435).
ea6c7ae6
PE
14980 * lisp.h (doprnt): Remove.
14981 * Makefile.in (base_obj): Remove doprnt.o.
14982 * deps.mk (doprnt.o): Remove.
14983
5fdb398c
PE
14984 error: Print 32- and 64-bit integers portably (Bug#8435).
14985 Without this change, on typical 64-bit hosts error ("...%d...", N)
14986 was used to print both 32- and 64-bit integers N, which relied on
14987 undefined behavior.
61bdb816 14988 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
14989 * lisp.h (error, verror): Mark as printf-like functions.
14990 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
14991 Report overflow in size calculations when allocating printf buffer.
14992 Do not truncate output string at its first null byte.
14993 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
14994 Truncate the output at a character boundary, since vsnprintf does not
14995 do that.
14996 * charset.c (check_iso_charset_parameter): Convert internal
14997 character to string before calling 'error', since %c now has the
14998 printf meaning.
14999 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
15000 overflow when computing char to be passed to 'error'. Do not
15001 pass Lisp_Object to 'error'; pass the integer instead.
15002 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
15003 formatted with plain %d.
15004
b189fa66
PE
15005 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
15006
bff87ef0
PE
15007 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
15008
7e2cac20
PE
15009 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
15010
ce4d90b5
PE
15011 * xterm.c (x_catch_errors): Remove duplicate declaration.
15012
266c9547
PE
15013 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
15014
79c49ad2
PE
15015 * xdisp.c, lisp.h (message_nolog): Remove; unused.
15016
368f4090
JM
150172011-04-10 Jim Meyering <meyering@redhat.com>
15018
15019 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
15020 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
15021 return ssize_t not "int", and use size_t as the buffer length.
15022 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
15023 * gnutls.h: Update declarations.
15024 * process.c (read_process_output): Use ssize_t, to match.
15025 (send_process): Likewise.
15026
a32d4040
CY
150272011-04-09 Chong Yidong <cyd@stupidchicken.com>
15028
15029 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
15030
8546720e 150312011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 15032
04f2d78b
CB
15033 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
15034 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 15035
8546720e
GM
15036 * xterm.c (handle_one_xevent):
15037 * xmenu.c (create_and_show_popup_menu):
15038 * xselect.c (x_decline_selection_request)
15039 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 15040
0a2f5c1a 150412011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
15042
15043 Fix some uses of `int' instead of EMACS_INT.
15044 * search.c (string_match_1, fast_string_match)
15045 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
15046 (scan_buffer, find_next_newline_no_quit)
15047 (find_before_next_newline, search_command, Freplace_match)
15048 (Fmatch_data): Make some `int' variables be EMACS_INT.
15049
15050 * xdisp.c (display_count_lines): 3rd argument and return value now
15051 EMACS_INT. All callers changed.
15052 (pint2hrstr): Last argument is now EMACS_INT.
15053
15054 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
15055 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
15056 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
15057 (decode_coding_utf_16, decode_coding_emacs_mule)
15058 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
15059 (decode_coding_ccl, decode_coding_charset)
15060 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
15061 (decode_coding_iso_2022, decode_coding_emacs_mule)
15062 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
15063 <char_offset, last_offset>: Declare EMACS_INT.
15064 (encode_coding_utf_8, encode_coding_utf_16)
15065 (encode_coding_emacs_mule, encode_invocation_designation)
15066 (encode_designation_at_bol, encode_coding_iso_2022)
15067 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
15068 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
15069 Declare EMACS_INT.
15070 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
15071 (encode_invocation_designation): Last argument P_NCHARS is now
15072 EMACS_INT.
15073 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
15074 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
15075
15076 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
15077 All users changed.
15078
15079 * ccl.c (Fccl_execute_on_string): Declare some variables
15080 EMACS_INT.
15081
8546720e 150822011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
15083
15084 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
15085
4e19a977
CS
150862011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
15087
15088 * process.c (Fformat_network_address): Doc fix.
15089
87302331
R
150902011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
15091
ee7683eb 15092 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 15093
cbb59342
CY
150942011-04-08 Chong Yidong <cyd@stupidchicken.com>
15095
15096 * keyboard.c (read_char): Call Lisp function help-form-show,
15097 instead of using internal_with_output_to_temp_buffer.
15098 (Qhelp_form_show): New var.
e0d38eeb 15099 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
15100
15101 * print.c (internal_with_output_to_temp_buffer): Function deleted.
15102
15103 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
15104
e67a13ab
CY
151052011-04-06 Chong Yidong <cyd@stupidchicken.com>
15106
04f2d78b
CB
15107 * process.c (Flist_processes): Remove to Lisp.
15108 (list_processes_1): Delete.
e67a13ab 15109
973f782d
EZ
151102011-04-06 Eli Zaretskii <eliz@gnu.org>
15111
7c106b1e
EZ
15112 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
15113
973f782d
EZ
15114 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
15115
41cf7d1a 151162011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 15117
ca23cc88
PE
15118 Fix more problems found by GCC 4.6.0's static checks.
15119
f390e2d5
PE
15120 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
15121
42eea0d0
PE
15122 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
15123
b69769da 15124 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 15125
f9541e84
PE
15126 * xdisp.c (vmessage): Mark as a printf-like function.
15127
13841b55
PE
15128 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
15129
c136c10f
PE
15130 * sound.c (sound_warning): Don't crash if arg contains a printf format.
15131
5e2d4a30
PE
15132 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
15133 printf-like functions.
15134 (tiff_load): Add casts to remove these marks before passing them
15135 to system-supplied API.
15136
583f48b9
PE
15137 * eval.c (Fsignal): Remove excess argument to 'fatal'.
15138
b25d760e
PE
15139 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
15140 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
15141 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
15142 directly, rather than having caller test rule sign. This avoids
15143 some unnecessary tests.
15144 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
15145 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
15146 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 15147
bc7b6697 15148 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 15149 (xfont_open): Avoid unnecessary tests.
bc7b6697 15150
27ccc379
PE
15151 * composite.c (composition_gstring_put_cache): Use unsigned integer.
15152
dcd5c89a
PE
15153 * composite.h, composite.c (composition_gstring_put_cache):
15154 Use EMACS_INT, not int, for length.
15155
b13a45c6
PE
15156 * composite.h (COMPOSITION_DECODE_REFS): New macro,
15157 breaking out part of COMPOSITION_DECODE_RULE.
15158 (COMPOSITION_DECODE_RULE): Use it.
15159 * composite.c (get_composition_id): Remove unused local vars,
15160 by using the new macro.
15161
1e792e4d
PE
15162 * textprop.c (set_text_properties_1): Change while to do-while,
15163 since the condition is always true at first.
15164
dc6c6455 15165 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
15166 (interval_deletion_adjustment): Return unsigned value.
15167 All uses changed.
dc6c6455 15168
aba7731a
PE
15169 * process.c (list_processes_1, create_pty, read_process_output):
15170 (exec_sentinel): Remove vars that were set but not used.
afd4052b 15171 (create_pty): Remove unnecessary "volatile"s.
bc57d757 15172 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 15173 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 15174 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 15175
fdfc4bf3
PE
15176 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
15177
fca8fe46 15178 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 15179 (update_syntax_table): Use unsigned instead of int.
fca8fe46 15180
06a0259a 15181 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 15182 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 15183 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 15184
e7b9e80f
PE
15185 * print.c (print_error_message): Avoid int overflow.
15186
56201685
PE
15187 * font.c (font_list_entities): Redo for clarity,
15188 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
15189
78834453 15190 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 15191 (font_score): Avoid potential overflow in diff calculation.
78834453 15192
0bc0b309 15193 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 15194 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 15195
e610eaca
PE
15196 * eval.c (funcall_lambda): Rename local to avoid shadowing.
15197
b895abce
PE
15198 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
15199 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
15200 can always succeed if overflow has undefined behavior.
15201
1f1d9321 15202 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 15203 (wordify): Omit three unnecessary tests.
1f1d9321 15204
c59478bc
PE
15205 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
15206 All callers changed. This avoids the need for an unused var.
15207
79b73827
PE
15208 * casefiddle.c (casify_region): Remove var that is set but not used.
15209
a4db5dfe
PE
15210 * dired.c (file_name_completion): Remove var that is set but not used.
15211
43aae36e
PE
15212 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
15213
2a47c44d 15214 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 15215 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 15216
a37c69bf
PE
15217 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
15218 Check for integer overflow on size calculations.
15219
328ab8e7
PE
15220 * buffer.c (Fprevious_overlay_change): Remove var that is set
15221 but not used.
15222
e5a2a5cb
PE
15223 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
15224 Remove vars that are set but not used.
8d84a6eb 15225 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 15226 (timer_check_2): Mark vars as initialized.
e5a2a5cb 15227
a60e5f68
PE
15228 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
15229
f661cb61 15230 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 15231 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 15232
f0397f5a
PE
15233 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
15234 that are set but not used.
15235
8664db06 15236 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 15237 if XCreateBitmapFromData fails (Bug#8410).
8664db06 15238
6abdaa4a
PE
15239 * xselect.c (x_get_local_selection, x_handle_property_notify):
15240 Remove vars that are set but not used.
15241
0ce7538d 15242 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 15243 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 15244
9ae848fc
PE
15245 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
15246 Remove var that is set but not used.
0b918413
PE
15247 (scroll_bar_windows_size): Now size_t, not int.
15248 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
15249 Check for overflow.
9ae848fc 15250
a5a62657
PE
15251 * xfaces.c (realize_named_face): Remove vars that are set but not used.
15252 (map_tty_color) [!defined MSDOS]: Likewise.
15253
5c5cdd39
PE
15254 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
15255
66ebf983
PE
15256 * coding.c: Remove vars that are set but not used.
15257 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
15258 All callers changed.
15259 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
15260 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
15261 (decode_coding_charset): Remove vars that are set but not used.
15262
1be4d761
PE
15263 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
15264 that is set but not used.
15265
47553fa8
PE
15266 * print.c (print_object): Remove var that is set but not used.
15267
1f7196bf 15268 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
15269 The gnulib version avoids calling malloc in the usual case,
15270 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
15271 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
15272 * filelock.c (current_lock_owner): Likewise.
15273 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
15274 * sysdep.c: Include allocator.h, careadlinkat.h.
15275 (emacs_no_realloc_allocator): New static constant.
15276 (emacs_readlink): New function.
fdb61804
PE
15277 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
15278 ../lib/careadlinkat.h.
d1fdcab7 15279
f84c17c7
SM
152802011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
15281
15282 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
15283 first non-nil return value).
15284
ef3862ad
JD
152852011-04-03 Jan Djärv <jan.h.d@swipnet.se>
15286
15287 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
15288 if not defined (Bug#8403).
15289
376a7006
JB
152902011-04-02 Juanma Barranquero <lekktu@gmail.com>
15291
15292 * xdisp.c (display_count_lines): Remove parameter `start',
15293 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15294 (get_char_face_and_encoding): Remove parameter `multibyte_p',
15295 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15296 (fill_stretch_glyph_string): Remove parameters `row' and `area',
15297 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
15298 and thereabouts. All callers changed.
15299 (get_per_char_metric): Remove parameter `f', unused since
15300 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15301
6ca3801d
JM
153022011-04-02 Jim Meyering <meyering@redhat.com>
15303
15304 do not dereference NULL upon failed strdup
15305 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
15306 (ns_get_family): Likewise.
15307
d8e2b5ba
JB
153082011-04-02 Juanma Barranquero <lekktu@gmail.com>
15309
15310 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
15311
8c74fcbd
JD
153122011-04-02 Jan Djärv <jan.h.d@swipnet.se>
15313
15314 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
15315 later (Bug#8403).
15316
7200d79c
SM
153172011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
15318
03408648 15319 Add lexical binding.
7200d79c 15320
03408648
SM
15321 * window.c (Ftemp_output_buffer_show): New fun.
15322 (Fsave_window_excursion):
15323 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
15324
15325 * lread.c (lisp_file_lexically_bound_p): New function.
15326 (Fload): Bind Qlexical_binding.
15327 (readevalloop): Remove `evalfun' arg.
15328 Bind Qinternal_interpreter_environment.
15329 (Feval_buffer): Bind Qlexical_binding.
15330 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
15331 Mark as dynamic.
15332 (syms_of_lread): Declare `lexical-binding'.
15333
15334 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
15335
15336 * keyboard.c (eval_dyn): New fun.
15337 (menu_item_eval_property): Use it.
ca105506
SM
15338
15339 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 15340
03408648
SM
15341 * fns.c (concat, mapcar1): Accept byte-code-functions.
15342
15343 * eval.c (Fsetq): Handle lexical vars.
15344 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
15345 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
15346 (FletX, Flet): Obey lexical binding.
15347 (Fcommandp): Handle closures.
15348 (Feval): New `lexical' arg.
15349 (eval_sub): New function extracted from Feval. Use it almost
15350 everywhere where Feval was used. Look up vars in lexical env.
15351 Handle closures.
15352 (Ffunctionp): Move from subr.el.
15353 (Ffuncall): Handle closures.
15354 (apply_lambda): Remove `eval_flags'.
15355 (funcall_lambda): Handle closures and new byte-code-functions.
15356 (Fspecial_variable_p): New function.
15357 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
15358 but without exporting it to Lisp.
23aba0ea 15359
23aba0ea 15360 * doc.c (Fdocumentation, store_function_docstring):
03408648 15361 * data.c (Finteractive_form): Handle closures.
23aba0ea 15362
03408648
SM
15363 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
15364 interactive spec.
ba83908c 15365
04f2d78b
CB
15366 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
15367 New byte-codes.
03408648
SM
15368 (exec_byte_code): New function extracted from Fbyte_code to handle new
15369 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 15370
03408648 15371 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 15372
03408648 15373 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 15374
e2abce01
JB
153752011-03-31 Juanma Barranquero <lekktu@gmail.com>
15376
15377 * xdisp.c (redisplay_internal): Fix prototype.
15378
63696a73 153792011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 15380
63696a73 15381 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
15382 (try_scrolling): Use it when setting scroll_limit.
15383 Limit scrolling to 100 screen lines.
63696a73
EZ
15384 (redisplay_window): Even when falling back on "recentering",
15385 position point in the window according to scroll-conservatively,
15386 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
15387
15388 (try_scrolling): When point is above the window, allow searching
15389 as far as scroll_max, or one screenful, to compute vertical
15390 distance from PT to the scroll margin position. This prevents
15391 try_scrolling from unnecessarily failing when
15392 scroll-conservatively is set to a value slightly larger than the
15393 window height. Clean up the case of PT below the margin at bottom
15394 of window: scroll_max can no longer be INT_MAX. When aggressive
15395 scrolling is in use, don't let point enter the opposite scroll
15396 margin as result of the scroll.
15397 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
15398 threshold of 100 lines for never-recentering scrolling.
15399
e4cc2dfc
JB
154002011-03-31 Juanma Barranquero <lekktu@gmail.com>
15401
15402 * dispextern.h (move_it_by_lines):
15403 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
15404 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
15405 (message_log_check_duplicate): Remove parameters `prev_bol' and
15406 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15407 (redisplay_internal): Remove parameter `preserve_echo_area',
15408 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
15409
15410 * indent.c (Fvertical_motion):
15411 * window.c (window_scroll_pixel_based, Frecenter):
15412 Don't pass `need_y_p' to `move_it_by_lines'.
15413
1c470562
SM
154142011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
15415
44f230aa
SM
15416 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
15417 steal a few bits to be more compact.
15418 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
15419 Remove unneeded casts.
15420
1c470562
SM
15421 * bytecode.c (Fbyte_code): CAR and CDR can GC.
15422
888adce9
ZK
154232011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
15424
15425 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
15426 binding" message (bug#7967).
15427
f838ed7b
PE
154282011-03-30 Paul Eggert <eggert@cs.ucla.edu>
15429
77861b95
PE
15430 Fix more problems found by GCC 4.6.0's static checks.
15431
de6dbc14
PE
15432 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
15433 Remove unused local var.
15434
f838ed7b
PE
15435 * editfns.c (Fmessage_box): Remove unused local var.
15436
792c7b2b
PE
15437 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
15438 (note_mode_line_or_margin_highlight, note_mouse_highlight):
15439 Omit unused local vars.
c499e557 15440 * window.c (shrink_windows): Omit unused local var.
b01a1c29 15441 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
15442 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
15443 Omit unused local var.
15444
ba0165e1
PE
15445 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
15446 Don't assume string length fits in int.
32ad8845 15447 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 15448 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 15449
3c59b4c9
PE
15450 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
15451 instead of alloca (Bug#8344).
15452
a3eed478 15453 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 15454 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 15455
eb4d412d
PE
15456 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
15457
1658b401
PE
15458 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
15459 concerns.
15460
15461 * term.c (produce_glyphless_glyph): Remove unnecessary test.
15462
15463 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 15464
9a2c6e05
PE
15465 * keyboard.c (syms_of_keyboard): Use the same style as later
15466 in this function when indexing through an array. This also
15467 works around GCC bug 48267.
15468
03d0a109
PE
15469 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
15470
44f730c8
PE
15471 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
15472
fe75f926
PE
15473 * chartab.c (sub_char_table_ref_and_range): Redo for slight
15474 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
15475
ffa8c828
PE
15476 * keyboard.c, keyboard.h (num_input_events): Now size_t.
15477 This avoids undefined behavior on integer overflow, and is a bit
15478 more convenient anyway since it is compared to a size_t variable.
15479
c5101a77
PE
15480 Variadic C functions now count arguments with size_t, not int.
15481 This avoids an unnecessary limitation on 64-bit machines, which
15482 caused (substring ...) to crash on large vectors (Bug#8344).
15483 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
15484 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 15485 All variadic functions and their callers changed accordingly.
c5101a77
PE
15486 (struct gcpro.nvars): Now size_t, not int. All uses changed.
15487 * data.c (arith_driver, float_arith_driver): Likewise.
15488 * editfns.c (general_insert_function): Likewise.
15489 * eval.c (struct backtrace.nargs, interactive_p)
15490 (internal_condition_case_n, run_hook_with_args, apply_lambda)
15491 (funcall_lambda, mark_backtrace): Likewise.
15492 * fns.c (concat): Likewise.
15493 * frame.c (x_set_frame_parameters): Likewise.
15494 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
15495 0 if not found, not -1. All callers changed.
15496
dd3f25f7
PE
15497 * alloc.c (garbage_collect): Don't assume stack size fits in int.
15498 (stack_copy_size): Now size_t, not int.
15499 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
15500
461c2ab9
JB
155012011-03-28 Juanma Barranquero <lekktu@gmail.com>
15502
15503 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
15504 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15505 All callers changed.
15506
15507 * lisp.h (multibyte_char_to_unibyte):
15508 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
15509 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15510 * character.h (CHAR_TO_BYTE8):
15511 * cmds.c (internal_self_insert):
15512 * editfns.c (general_insert_function):
15513 * keymap.c (push_key_description):
15514 * search.c (Freplace_match):
15515 * xdisp.c (message_dolog, set_message_1): All callers changed.
15516
f6d62986
SM
155172011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
15518
15519 * keyboard.c (safe_run_hook_funcall): New function.
15520 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
15521 don't set the hook to nil, but remove the offending function instead.
15522 (Qcommand_hook_internal): Remove, unused.
15523 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
15524 Vcommand_hook_internal.
15525
15526 * eval.c (enum run_hooks_condition): Remove.
15527 (funcall_nil, funcall_not): New functions.
15528 (run_hook_with_args): Call each function through a `funcall' argument.
15529 Remove `cond' argument, now redundant.
15530 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
15531 (Frun_hook_with_args_until_failure): Adjust accordingly.
15532 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
15533
1db5b1ad
JB
155342011-03-28 Juanma Barranquero <lekktu@gmail.com>
15535
15536 * dispextern.h (string_buffer_position): Remove declaration.
15537
15538 * print.c (strout): Remove parameter `multibyte', unused since
15539 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
15540
15541 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
15542 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
15543 All callers changed.
15544
15545 * w32.c (_wsa_errlist): Use braces for struct initializers.
15546
15547 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
15548 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
15549 All callers changed.
15550 (string_buffer_position): Likewise. Also, make static (it's never
15551 used outside xdisp.c).
15552 (cursor_row_p): Remove parameter `w', unused since
15553 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
15554 (decode_mode_spec): Remove parameter `precision', introduced during
15555 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
15556 All callers changed.
15557
5ffb62aa
JD
155582011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15559
15560 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
15561
461c2ab9 155622011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
15563
15564 * nsterm.m (ns_menu_bar_is_hidden): New variable.
15565 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
15566 (ns_update_auto_hide_menu_bar): New functions.
15567 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
15568 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
15569 ns_constrain_all_frames.
15570 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
15571 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
15572
5c380ffb
JD
155732011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15574
15575 * nsmenu.m (runDialogAt): Remove argument to timer_check.
15576
9af30bdf
GM
155772011-03-27 Glenn Morris <rgm@gnu.org>
15578
15579 * syssignal.h: Replace RETSIGTYPE with void.
15580 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
15581 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
15582 Replace SIGTYPE with void everywhere.
15583 * s/usg5-4-common.h (SIGTYPE): Remove definition.
15584 * s/template.h (SIGTYPE): Remove commented out definition.
15585
e2abce01
JB
155862011-03-26 Eli Zaretskii <eliz@gnu.org>
15587
15588 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
15589 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
15590
f868cd8a
JB
155912011-03-26 Juanma Barranquero <lekktu@gmail.com>
15592
59eb0929
JB
15593 * w32.c (read_unc_volume): Use parameter `henum', instead of
15594 global variable `wget_enum_handle'.
15595
15596 * keymap.c (describe_vector): Remove parameters `indices' and
15597 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
15598 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
15599
f868cd8a
JB
15600 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
15601
15602 * keyboard.c (timer_check): Remove parameter `do_it_now',
15603 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
15604 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
15605 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
15606
15607 * keyboard.c (read_char):
15608 * w32menu.c (w32_menu_display_help):
15609 * xmenu.c (show_help_event, menu_help_callback):
15610 Adjust calls to `show_help_echo'.
15611
15612 * gtkutil.c (xg_maybe_add_timer):
15613 * keyboard.c (readable_events):
15614 * process.c (wait_reading_process_output):
15615 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
15616
15617 * insdel.c (adjust_markers_gap_motion):
15618 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
15619 (gap_left, gap_right): Don't call it.
15620
2ecf6fdb
CY
156212011-03-25 Chong Yidong <cyd@stupidchicken.com>
15622
15623 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
15624 incurred during fontification.
15625
6b1f9ba4
JB
156262011-03-25 Juanma Barranquero <lekktu@gmail.com>
15627
15628 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
15629 (DEFVAR_PER_BUFFER): Don't pass it.
15630
15631 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
15632 (scrolling_window): Don't pass it.
15633
0f4a96b5
JB
156342011-03-25 Juanma Barranquero <lekktu@gmail.com>
15635
15636 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
15637
15638 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
15639 and `suffix'.
15640 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
15641 of variables specific to SELinux and computation of `encoded_absname'.
15642
15643 * image.c (XPutPixel): Remove unused variable `height'.
15644
15645 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
15646
15647 * unexw32.c (get_section_info): Remove unused variable `section'.
15648
15649 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
15650 (system_process_attributes): Remove unused variable `sess'.
15651 (sys_read): Remove unused variable `err'.
15652
15653 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
15654 (w32_wnd_proc): Remove unused variable `isdead'.
15655 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
15656 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
15657 (x_create_tip_frame): Remove unused variable `tem'.
15658
15659 * w32inevt.c (w32_console_read_socket):
15660 Remove unused variable `no_events'.
15661
15662 * w32term.c (x_draw_composite_glyph_string_foreground):
15663 Remove unused variable `width'.
15664
1149507c
JB
156652011-03-24 Juanma Barranquero <lekktu@gmail.com>
15666
15667 * w32term.c (x_set_glyph_string_clipping):
15668 Don't pass uninitialized region to CombineRgn.
15669
9c88f339
JB
156702011-03-23 Juanma Barranquero <lekktu@gmail.com>
15671
15672 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
15673 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
15674 (Fx_close_connection): Remove unused variable `i'.
15675
15676 * w32font.c (w32font_draw): Return number of glyphs.
15677 (w32font_open_internal): Remove unused variable `i'.
15678 (w32font_driver): Add missing initializer.
15679
15680 * w32menu.c (utf8to16): Remove unused variable `utf16'.
15681 (fill_in_menu): Remove unused variable `items_added'.
15682
15683 * w32term.c (last_mouse_press_frame): Remove static global variable.
15684 (w32_clip_to_row): Remove unused variable `f'.
15685 (x_delete_terminal): Remove unused variable `i'.
15686
15687 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
15688 (NOTHING): Remove unused static global variable.
15689 (uniscribe_check_otf): Remove unused variable `table'.
15690 (uniscribe_font_driver): Add missing initializers.
15691
dee091a3
JD
156922011-03-23 Julien Danjou <julien@danjou.info>
15693
15694 * term.c (Fsuspend_tty, Fresume_tty):
15695 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
15696 * window.c (temp_output_buffer_show):
15697 * insdel.c (signal_before_change):
15698 * frame.c (Fhandle_switch_frame):
15699 * fileio.c (Fdo_auto_save):
15700 * emacs.c (Fkill_emacs):
15701 * editfns.c (save_excursion_restore):
15702 * cmds.c (internal_self_insert):
15703 * callint.c (Fcall_interactively):
15704 * buffer.c (Fkill_all_local_variables):
15705 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
15706 Use Frun_hooks.
0f4a96b5 15707 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 15708 unconditionally since it does the check itself.
dee091a3 15709
2c520ab5 157102011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 15711
c9c49752
PE
15712 Fix more problems found by GCC 4.5.2's static checks.
15713
8abc3f12
PE
15714 * coding.c (encode_coding_raw_text): Avoid unnecessary test
15715 the first time through the loop, since we know p0 < p1 then.
15716 This also avoids a gcc -Wstrict-overflow warning.
15717
a2d26660
PE
15718 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
15719 leading to a memory leak, possible in functions like
15720 load_charset_map_from_file that can allocate an unbounded number
b12ef411 15721 of objects (Bug#8318).
a2d26660 15722
916c72e9
PE
15723 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
15724 that could (at least in theory) be that large.
15725
19ab8a18
PE
15726 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
15727 This is less likely to overflow, and avoids undefined behavior if
15728 overflow does occur. All callers changed. Use strtoul to scan
15729 for the unsigned long integer.
b7cbbd6f
PE
15730 (pint2hrstr): Simplify and tune code slightly.
15731 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 15732
f0641eff
PE
15733 * scroll.c (do_scrolling): Work around GCC bug 48228.
15734 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
15735
7f650bb9
PE
15736 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
15737 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
15738 (validate_x_resource_name): Simplify count usage.
15739 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 15740
37dd57d1
PE
15741 * fileio.c (Fcopy_file): Report error if fchown or fchmod
15742 fail (Bug#8306).
81e56e61 15743
699979fc 15744 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 15745
401bf9b4
PE
15746 * process.c (Fmake_network_process): Use socklen_t, not int,
15747 where POSIX says socklen_t is required in portable programs.
15748 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 15749 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
15750 (Fmake_network_process, server_accept_connection):
15751 (wait_reading_process_output, read_process_output):
15752 Likewise.
15753
b93aacde
PE
15754 * process.c: Rename or move locals to avoid shadowing.
15755 (list_processes_1, Fmake_network_process):
15756 (read_process_output_error_handler, exec_sentinel_error_handler):
15757 Rename or move locals.
4dc343ee 15758 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 15759 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 15760 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 15761 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 15762 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 15763
af8a867c 15764 Make tparam.h and terminfo.c consistent.
44f230aa
SM
15765 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
15766 Include tparam.h instead, since it declares them.
af8a867c
PE
15767 * cm.h (PC): Remove extern decl; tparam.h now does this.
15768 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
15769 * terminfo.c: Include tparam.h, to check interfaces.
15770 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
15771 (tparam): Adjust signature to match interface in tparam.h;
15772 this removes some undefined behavior. Check that outstring and len
15773 are zero, which they always are with Emacs.
15774 * tparam.h (PC, BC, UP): New extern decls.
15775
0248044d 15776 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 15777 (xftfont_open): Rename locals to avoid shadowing.
0248044d 15778
8ff096c1 15779 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
15780 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
15781 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 15782 (ftfont_list): Remove unused local.
49eaafba
PE
15783 (get_adstyle_property, ftfont_pattern_entity):
15784 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
15785 Rename locals to avoid shadowing.
8ff096c1 15786
e2be39f6
PE
15787 * xfont.c (xfont_list_family): Mark var as initialized.
15788
c9735e30
PE
15789 * xml.c (make_dom): Now static.
15790
8f5201ae
PE
15791 * composite.c (composition_compute_stop_pos): Rename local to
15792 avoid shadowing.
b246f932
PE
15793 (composition_reseat_it): Remove unused locals.
15794 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 15795 (composition_update_it): Mark var as initialized.
11b61122
PE
15796 (find_automatic_composition): Mark vars as initialized,
15797 with a FIXME (Bug#8290).
8f5201ae 15798
760fbc2c
PE
15799 character.h: Rename locals to avoid shadowing.
15800 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
15801 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
15802 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
15803 (BUF_DEC_POS): Be more systematic about renaming local temporaries
15804 to avoid shadowing.
15805
ff08eb85
PE
15806 * textprop.c (property_change_between_p): Remove; unused.
15807
fc7bf025
PE
15808 * intervals.c (interval_start_pos): Now static.
15809
235d7abc
PE
15810 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
15811
44f230aa
SM
15812 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
15813 Rename locals to avoid shadowing.
3e7d6594 15814
50060332
PE
15815 * sound.c (wav_play, au_play, Fplay_sound_internal):
15816 Fix pointer signedness.
d01f234b 15817 (alsa_choose_format): Remove unused local var.
c83b8872
PE
15818 (wav_play): Initialize a variable to 0, to prevent undefined
15819 behavior (Bug#8278).
50060332 15820
c4fc4e30
PE
15821 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
15822
918436ed
PE
15823 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
15824
c939f91b
PE
15825 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
15826 clobbering (Bug#8298).
b9c7f648
PE
15827 * sysdep.c (sys_subshell): Likewise.
15828 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 15829
6bd8c144
PE
15830 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
15831 This should get cleaned up, so that child_setup has the
15832 same signature on all platforms.
15833
7710357c 15834 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 15835 (relocate_fd): Rename locals to avoid shadowing.
7710357c 15836
c59da222
CY
158372011-03-22 Chong Yidong <cyd@stupidchicken.com>
15838
15839 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
15840 not to be necessary, and produces flickering.
15841
66b87493
GM
158422011-03-20 Glenn Morris <rgm@gnu.org>
15843
15844 * config.in: Remove file.
15845
45b6f6d5
JB
158462011-03-20 Juanma Barranquero <lekktu@gmail.com>
15847
15848 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
15849 are now in src/globals.h.
15850 (syms_of_minibuf): Remove spurious & from previous change.
15851
cd394be1 158522011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
15853
15854 * minibuf.c (completing-read-function): New variable.
15855 (completing-read-default): Rename from completing-read.
15856 (completing-read): Call completing-read-function.
15857
b14e3e21
CY
158582011-03-19 Juanma Barranquero <lekktu@gmail.com>
15859
15860 * xfaces.c (Fx_load_color_file):
15861 Read color file from absolute filename (bug#8250).
15862
f2b726e6
JB
158632011-03-19 Juanma Barranquero <lekktu@gmail.com>
15864
15865 * makefile.w32-in: Update dependencies.
15866
09f6ff02
EZ
158672011-03-17 Eli Zaretskii <eliz@gnu.org>
15868
15869 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
15870
29a6015a
PE
158712011-03-17 Paul Eggert <eggert@cs.ucla.edu>
15872
a3a6c54e
PE
15873 Fix more problems found by GCC 4.5.2's static checks.
15874
b766f867
PE
15875 * process.c (make_serial_process_unwind, send_process_trap):
15876 (sigchld_handler): Now static.
15877
be02381c
PE
15878 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
15879 That way, the code declares only the vars that it needs.
15880 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
15881 * s/cygwin.h (PTY_ITERATION): Likewise.
15882 * s/darwin.h (PTY_ITERATION): Likewise.
15883 * s/gnu-linux.h (PTY_ITERATION): Likewise.
15884
57048744
PE
15885 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
15886 * process.c (allocate_pty): Don't declare stb unless it's needed.
15887
7914961c 15888 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
15889 (CONSTANTLIM): Remove; unused.
15890 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
15891 Define only if needed.
7914961c 15892
b3967b18
PE
15893 * unexelf.c (unexec): Name an expression,
15894 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
15895 Use a different way to cause a compilation error if anyone uses
15896 n rather than nn, a way that does not involve shadowing.
73366a00 15897 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 15898
29a6015a
PE
15899 * deps.mk (unexalpha.o): Remove; unused.
15900
43cfc33e 15901 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 15902 * unexec.h: New file.
ce701a33
PE
15903 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
15904 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
15905 Depend on unexec.h.
15906 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
15907 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
15908 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 15909 Change as necessary to match prototype in unexec.h.
ce701a33 15910
01f44d5a
PE
15911 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
15912 shadowing.
4f63c6bb 15913 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 15914
a6670b0b
PE
15915 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
15916 Rename locals to avoid shadowing.
15917
cef2010d 15918 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 15919 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 15920
d4d7173a
PE
15921 * print.c (Fredirect_debugging_output): Fix pointer signedess.
15922
f08b802a
PE
15923 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
15924 warning when compiling print.c.
15925
3ddb0639
PE
15926 * font.c (font_unparse_fcname): Abort in an "impossible" situation
15927 instead of using an uninitialized var.
5ad03b97 15928 (font_sort_entities): Mark var as initialized.
3ddb0639 15929
170a2692
PE
15930 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
15931
e663c700
PE
15932 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
15933 pointers to constants.
89bc529a 15934 (font_parse_fcname): Remove unused vars.
7b81e2d0 15935 (font_delete_unmatched): Now static.
ea838e10 15936 (font_get_spec): Remove; unused.
13a547c6
PE
15937 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
15938 (font_update_drivers, Ffont_get_glyphs, font_add_log):
15939 Rename or move locals to avoid shadowing.
e663c700 15940
2a80c887 15941 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 15942 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 15943
1384fa33 15944 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 15945 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 15946
8b2c52e9
PE
15947 * alloc.c (mark_backtrace): Move decl from here ...
15948 * lisp.h: ... to here, so that it can be checked.
15949
475545b5 15950 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 15951 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
15952 (lisp_indirect_variable): Name an expression,
15953 to avoid gcc -Wbad-function-cast warning.
1faed8ae 15954 (Fdefvar): Rename locals to avoid shadowing.
475545b5 15955
b1349114 15956 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 15957 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 15958 Use const pointer when appropriate.
b1349114 15959
a2928364
PE
15960 * lisp.h (get_system_name, get_operating_system_release):
15961 Move decls here, to check interfaces.
15962 * process.c (get_operating_system_release): Move decl to lisp.h.
15963 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
15964 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
15965 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
15966 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
15967 (Fformat_time_string, Fencode_time, Finsert_char):
15968 (Ftranslate_region_internal, Fformat):
15969 Rename or remove local vars to avoid shadowing.
9710023e 15970 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 15971
a415e694
PE
15972 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
15973 avoid shadowing.
15974
8ef4622d
PE
15975 * lisp.h (eassert): Check that the argument compiles, even if
15976 ENABLE_CHECKING is not defined.
15977
946f9a5b
PE
15978 * data.c (Findirect_variable): Name an expression, to avoid
15979 gcc -Wbad-function-cast warning.
112396d6 15980 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 15981 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
15982 (Fmake_variable_buffer_local, Fmake_local_variable):
15983 Mark variables as initialized.
52746918 15984 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 15985
e5aab7e7 15986 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
15987 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
15988 Rename locals to avoid shadowing.
dff45157
PE
15989 (mark_stack): Move local variables into the #ifdef region where
15990 they're used.
7bc26fdb
PE
15991 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
15992 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
15993 needed otherwise.
15994 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
15995 (GC_STRING_CHARS): Remove; not used.
d40d4be1 15996 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 15997
e5aab7e7
PE
15998 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
15999 avoids undefined behavior in theory.
16000
4da60324
PE
16001 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
16002
88043301
PE
16003 Use functions, not macros, for up- and down-casing (Bug#8254).
16004 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16005 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
16006 to use the following functions instead of these macros.
16007 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
16008 EMACS_INT, since callers assume the returned value fits in int.
16009 (upcase1): Likewise, for UPCASE_TABLE.
16010 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 16011 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 16012 the race-condition problem in the old DOWNCASE.
88043301 16013
19ed5445
PE
16014 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
16015 Rename locals to avoid shadowing.
16016 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
16017 (regex_compile, re_search_2, re_match_2_internal):
16018 Remove unused local vars.
952db0d7
PE
16019 (FREE_VAR): Rewrite so as not to use empty "else",
16020 which gcc can warn about.
da053e48 16021 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
16022 (RETALLOC_IF): Define only if needed.
16023 (WORDCHAR_P): Likewise. This one is never needed, but is used
16024 only in a comment talking about a compiler bug, so put inside
16025 the #if 0 of that comment.
16026 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
16027 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
16028 Remove; unused.
19ed5445 16029
1f3561e4 16030 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
16031 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
16032 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 16033
ded6f8f7
PE
16034 * search.c (simple_search): Remove unused var.
16035
dbd37a95
PE
16036 * dired.c (compile_pattern): Move decl from here ...
16037 * lisp.h: ... to here, so that it can be checked.
16038 (struct re_registers): New forward decl.
16039
7e47afad
PE
16040 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
16041
85f24f61
PE
16042 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
16043 All uses changed.
16044 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
16045 Rename locals to avoid shadowing.
5671df8f 16046 (Fvertical_motion): Mark locals as initialized.
85f24f61 16047
181aa2be 16048 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 16049 (casify_region): Mark local as initialized.
181aa2be 16050
930d429c
PE
16051 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
16052
7082eac6
PE
16053 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
16054 New macros, so that the caller can use some names other than
16055 gcpro1, gcpro2, etc.
16056 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
16057 of the new macros.
16058 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
16059 argument, for consistency with GCPRO2_VAR, etc: it is now the
16060 prefix of the variable, not the variable itself. All uses
16061 changed.
38b2c076
PE
16062 * dired.c (directory_files_internal, file_name_completion):
16063 Rename locals to avoid shadowing.
16064
15206ed9
PE
16065 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
16066 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
16067 dired.c's scmp function, had undefined behavior.
16068 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16069 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
16070 * buffer.h: ... to here, because these macros use current_buffer,
16071 and the new implementation with inline functions needs to have
16072 current_buffer in scope now, rather than later when the macros
16073 are used.
16074 (downcase, upcase1): New static inline functions.
16075 (DOWNCASE, UPCASE1): Reimplement using these functions.
16076 This avoids undefined behavior in expressions like
16077 DOWNCASE (x) == DOWNCASE (y), which previously suffered
16078 from race conditions in accessing the global variables
16079 case_temp1 and case_temp2.
16080 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
16081 * lisp.h (case_temp1, case_temp2): Remove their decls.
16082 * character.h (ASCII_CHAR_P): Move from here ...
16083 * lisp.h: ... to here, so that the inline functions mentioned
16084 above can use them.
16085
4a6bea26
PE
16086 * dired.c (directory_files_internal_unwind): Now static.
16087
f14b7e14
PE
16088 * fileio.c (file_name_as_directory, directory_file_name):
16089 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
16090 Now static.
2893f146
PE
16091 (file_name_as_directory): Use const pointers when appropriate.
16092 (Fexpand_file_name): Likewise. In particular, newdir might
16093 point at constant storage, so make it a const pointer.
fd4ead52 16094 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
16095 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
16096 signedness issues.
f839df0c
PE
16097 (Fset_file_times, Finsert_file_contents, auto_save_error):
16098 Rename locals to avoid shadowing.
f14b7e14 16099
5716756e 16100 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
16101 (Ftry_completion, Fall_completions): Rename or remove locals
16102 to avoid shadowing.
5716756e 16103
b4c3046a
PE
16104 * marker.c (bytepos_to_charpos): Remove; unused.
16105
b45db522
PE
16106 * lisp.h (verify_bytepos, count_markers): New decls,
16107 so that gcc does not warn that these functions aren't declared.
16108
85876d07
PE
16109 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
16110 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 16111 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 16112 (copy_text): Remove unused local var.
85876d07 16113
03d78a21 16114 * filelock.c (within_one_second): Now static.
b3dd38ab 16115 (lock_file_1): Rename local to avoid shadowing.
03d78a21 16116
5df8f01b
PE
16117 * buffer.c (fix_overlays_before): Mark locals as initialized.
16118 (fix_start_end_in_overlays): Likewise. This function should be
16119 simplified by using pointers-to-pointers, but that's a different
16120 matter.
b1d876f1 16121 (switch_to_buffer_1): Now static.
8f54f30a
PE
16122 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
16123 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 16124
a70072c9 16125 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 16126 Fix pointer signedness issue.
edced198
PE
16127 (sys_subshell): Mark local as volatile if checking for lint,
16128 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 16129 (MAXPATHLEN): Define only if needed.
a70072c9 16130
a0977c44
PE
16131 * process.c (serial_open, serial_configure): Move decls from here ...
16132 * systty.h: ... to here, so that they can be checked.
16133
a884fdcc
PE
16134 * fns.c (get_random, seed_random): Move extern decls from here ...
16135 * lisp.h: ... to here, so that they can be checked.
16136
604efe86 16137 * sysdep.c (reset_io): Now static.
b8950c94 16138 (wait_for_termination_signal): Remove; unused.
604efe86 16139
38fc62d9
PE
16140 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
16141 (copy_keymap_item, append_key, push_text_char_description):
16142 Now static.
1004a21a 16143 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 16144 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
16145 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
16146 (describe_map_tree):
16147 Rename locals to avoid shadowing.
38fc62d9 16148
2f2650da
PE
16149 * keyboard.c: Declare functions static if they are not used elsewhere.
16150 (echo_char, echo_dash, cmd_error, top_level_2):
16151 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
16152 (read_char, kbd_buffer_get_event, make_lispy_position):
16153 (make_lispy_event, make_lispy_movement, apply_modifiers):
16154 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
16155 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
16156 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 16157 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 16158 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 16159
a053e86c 16160 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
16161 (mark_kboards): Move decl here ...
16162 * alloc.c (mark_kboards): ... from here.
a053e86c 16163
4752793e
PE
16164 * lisp.h (force_auto_save_soon): New decl.
16165
74f10ca7 16166 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
16167 (DEFINE_DUMMY_FUNCTION): New macro.
16168 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
16169 Use it.
c03cd23f
PE
16170 (main): Add casts to avoid warnings
16171 if GCC considers string literals to be constants.
74f10ca7 16172
022e70d4
PE
16173 * lisp.h (fatal_error_signal): Add decl, since it's exported.
16174
59d6fe83
PE
16175 * dbusbind.c: Pointer signedness fixes.
16176 (xd_signature, xd_append_arg, xd_initialize):
16177 (Fdbus_call_method, Fdbus_call_method_asynchronously):
16178 (Fdbus_method_return_internal, Fdbus_method_error_internal):
16179 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
16180 (Fdbus_register_signal): Use SSDATA when the context wants char *.
16181
78320123
PE
16182 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
16183 if GCC considers string literals to be constants.
49cebcca 16184 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 16185
35ac2a97
SM
161862011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
16187
fb103ca9
SM
16188 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
16189 (print_preprocess, print_object): New macro to fix last change.
16190
35ac2a97
SM
16191 * print.c (print_preprocess): Don't forget font objects.
16192
62973b41
JB
161932011-03-16 Juanma Barranquero <lekktu@gmail.com>
16194
16195 * emacs.c (USAGE3): Doc fixes.
16196
0e48bb22
AS
161972011-03-15 Andreas Schwab <schwab@linux-m68k.org>
16198
16199 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
16200 structure.
16201
7684e57b
JB
162022011-03-14 Juanma Barranquero <lekktu@gmail.com>
16203
16204 * lisp.h (VWindow_system, Qfile_name_history):
16205 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
16206 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
16207 (w32_system_caret_x, w32_system_caret_y): Declare extern.
16208
16209 * w32select.c: Don't #include "keyboard.h".
c96bbc66 16210 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
16211
16212 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
16213 * w32console.c (detect_input_pending, read_input_pending)
16214 (encode_terminal_code):
16215 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
16216 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
16217 (w32_system_caret_y, Qfile_name_history):
16218 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
16219 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
16220 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
16221 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
16222 * w32proc.c (Qlocal, report_file_error):
16223 * w32term.c (Vwindow_system, updating_frame):
16224 * w32uniscribe.c (initialized, uniscribe_font_driver):
16225 Remove unneeded extern declarations.
16226
2aa46d6c
CY
162272011-03-14 Chong Yidong <cyd@stupidchicken.com>
16228
c96bbc66 16229 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 16230
cffc6f3b
CY
162312011-03-13 Chong Yidong <cyd@stupidchicken.com>
16232
16233 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
16234 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
16235 These macros can no longer be used for assignment.
16236
44f230aa
SM
16237 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
16238 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
16239 (record_buffer_markers, fetch_buffer_markers): New functions for
16240 recording and fetching special buffer markers.
16241 (set_buffer_internal_1, set_buffer_temp): Use them.
16242
16243 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
16244
16245 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
16246
16247 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
16248 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
16249
16250 * xdisp.c (hscroll_window_tree):
16251 (reconsider_clip_changes): Use PT instead of BUF_PT.
16252
d251f04b
EZ
162532011-03-13 Eli Zaretskii <eliz@gnu.org>
16254
16255 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
16256 $(EMACS_ROOT)/lib/intprops.h.
16257
f0c77cd1
PE
162582011-03-13 Paul Eggert <eggert@cs.ucla.edu>
16259
3eca4629
PE
16260 Fix more problems found by GCC 4.5.2's static checks.
16261
7c86ee98
PE
16262 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
16263 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
16264 (xg_free_frame_widgets): Make it clear that a local variable is
16265 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
16266 (gdk_window_get_screen): Make it clear that this macro is needed
16267 only if USE_GTK_TOOLTIP.
1e5524e7
PE
16268 (int_gtk_range_get_value): New function, which avoids a diagnostic
16269 from gcc -Wbad-function-cast.
16270 (xg_set_toolkit_scroll_bar_thumb): Use it.
16271 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
16272 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
16273 (get_utf8_string, xg_get_file_with_chooser):
16274 Rename locals to avoid shadowing.
16275 (create_dialog): Move locals to avoid shadowing.
7c86ee98 16276
41729b81
PE
16277 * xgselect.c (xg_select): Remove unused var.
16278
f0c77cd1
PE
16279 * image.c (four_corners_best): Mark locals as initialized.
16280 (gif_load): Initialize transparent_p to zero (Bug#8238).
16281 Mark another local as initialized.
ec6cf4c6 16282 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 16283
ce0ad53d 16284 * image.c (clear_image_cache): Now static.
d5d5a617 16285 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 16286 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
16287 (x_edge_detection): Remove unnecessary cast that
16288 gcc -Wbad-function-cast diagnoses.
2037898d 16289 (gif_load): Fix pointer signedness.
6ae141d6
PE
16290 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
16291 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 16292
33383987 162932011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 16294
d32df629
PE
16295 Improve quality of tests for time stamp overflow.
16296 For example, without this patch (encode-time 0 0 0 1 1
16297 1152921504606846976) returns the obviously-bogus value (-948597
16298 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
16299 reports time overflow. See
16300 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
16301 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
16302 * editfns.c: Include limits.h and intprops.h.
16303 (TIME_T_MIN, TIME_T_MAX): New macros.
16304 (time_overflow): Move earlier, to before first use.
16305 (hi_time, lo_time): New functions, for an accurate test for
16306 out-of-range times.
16307 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
16308 (Fget_internal_run_time): Don't assume time_t fits in int.
16309 (make_time): Use list2 instead of Fcons twice.
16310 (Fdecode_time): More accurate test for out-of-range times.
16311 (check_tm_member): New function.
16312 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
16313 (lisp_time_argument): Don't rely on undefined left-shift and
16314 right-shift behavior when checking for time stamp overflow.
8be6f318 16315
fe31d94c
PE
16316 * editfns.c (time_overflow): New function, refactoring common code.
16317 (Fformat_time_string, Fdecode_time, Fencode_time):
16318 (Fcurrent_time_string): Use it.
16319
8be6f318
PE
16320 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
16321 * dired.c (make_time): Move to ...
16322 * editfns.c (make_time): ... here.
16323 * systime.h: Note the move.
16324
09d9db2c 163252011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 16326
126bc0dc
YM
16327 * fringe.c (update_window_fringes): Remove unused variables.
16328
c47cbdfd
YM
16329 * unexmacosx.c (copy_data_segment): Also copy __got section.
16330 (Bug#8223)
16331
7ac80be9
EZ
163322011-03-12 Eli Zaretskii <eliz@gnu.org>
16333
c96bbc66 16334 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
16335 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
16336 Constify `char *' arguments and their references according to
16337 prototypes in tparam.h.
16338
ecb0f94d 16339 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 16340
7ac80be9
EZ
16341 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
16342 Adapt all references accordingly.
16343
16344 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
16345
ef1fd07e
TT
163462011-03-11 Tom Tromey <tromey@redhat.com>
16347
16348 * buffer.c (syms_of_buffer): Remove obsolete comment.
16349
7ef4b50c
EZ
163502011-03-11 Eli Zaretskii <eliz@gnu.org>
16351
16352 * termhooks.h (encode_terminal_code): Declare prototype.
16353
16354 * msdos.c (encode_terminal_code): Don't declare prototype.
16355
16356 * term.c (encode_terminal_code): Now external again, used by
16357 w32console.c and msdos.c.
16358
44f230aa
SM
16359 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
16360 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 16361
4b1ec863 163622011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 16363
1714f52b 16364 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 16365
4b1ec863
PE
16366 * fringe.c (update_window_fringes): Mark locals as initialized
16367 (Bug#8227).
16368 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 16369
524c7aa6
PE
16370 * alloc.c (mark_fringe_data): Move decl from here ...
16371 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
16372 to check its interface.
16373 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
16374
a5c0af81 16375 * fontset.c (free_realized_fontset): Now static.
7519b8cd 16376 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 16377 (fontset_font): Mark local as initialized.
a9a06e0b 16378 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 16379
b4716021
PE
16380 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
16381
811e9bac 16382 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 16383 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
16384 (x_own_selection, Fx_disown_selection_internal): Rename locals
16385 to avoid shadowing.
16386 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 16387
7e3ab302
PE
16388 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
16389 so that the caller can use some name other than gcpro1.
16390 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
16391 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16392 (Fx_backspace_delete_keys_p):
16393 Use them to avoid shadowing, and rename vars to avoid shadowing.
16394 (x_decode_color, x_set_name, x_window): Now static.
6b437900 16395 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 16396 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
16397 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
16398 Remove unused locals.
7e3ab302
PE
16399 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16400 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
16401 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
16402 macros.
f78faa98 16403
e2b13473
PE
16404 * xterm.h (x_mouse_leave): New decl.
16405
77f23912
PE
16406 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
16407 Remove unused functions.
cdf4ba58
PE
16408 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
16409 (x_calc_absolute_position): Now static.
7411c686 16410 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 16411 Don't declare local "event" unless it's used.
ed7bf3a5
PE
16412 (x_iconify_frame, x_free_frame_resources): Don't declare locals
16413 unless they are used.
38d0b34a
PE
16414 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
16415 (x_fatal_error_signal): Remove; not used.
a6067996
PE
16416 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
16417 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
16418 (x_error_catcher, x_connection_closed, x_error_handler):
16419 (x_error_quitter, xembed_send_message, x_iconify_frame):
16420 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 16421 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 16422 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 16423
44f230aa
SM
16424 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
16425 Rename or move locals to avoid shadowing.
6b463e58 16426 (tty_defined_color, merge_face_heights): Now static.
5967d051 16427 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
16428 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
16429 does not deduce is never used uninitialized.
73719eba
PE
16430 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
16431 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 16432
426994c3 16433 * terminal.c (store_terminal_param): Now static.
5489860b 16434
032f1620 16435 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 16436 (set_frame_menubar): Remove unused local.
d4323972 16437 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
16438 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
16439 since they might point to immutable storage.
281585b0
PE
16440 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
16441 since it's unused otherwise.
032f1620 16442
367c19e5 16443 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 16444 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
16445 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
16446 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 16447 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
16448 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
16449 does not deduce are never used uninitialized.
70739cbe 16450
07b48fa9
PE
16451 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
16452
8868a238 16453 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
16454 * window.c (window_loop, size_window):
16455 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 16456
7e5cf297 16457 * window.c (display_buffer): Now static.
d6550a9f
PE
16458 (size_window): Mark variables that gcc -Wuninitialized
16459 does not deduce are never used uninitialized.
a586633d
PE
16460 * window.h (check_all_windows): New decl, to forestall
16461 gcc -Wmissing-prototypes diagnostic.
5b555da1 16462 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 16463
f6095868
PE
16464 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
16465 shadowing.
16466 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
16467 Include <limits.h>.
16468 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
16469 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
16470 (load_charset_map): Mark variables that gcc -Wuninitialized
16471 does not deduce are never used uninitialized.
53df7c11 16472 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 16473
f38b440c
PE
16474 * coding.c (coding_set_source, coding_set_destination):
16475 Use "else { /* comment */ }" rather than "else /* comment */;"
16476 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
16477 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
16478 a block, when the outer 'i' will do.
16479 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
16480 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
16481 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
16482 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
16483 (Fdecode_sjis_char, Fdefine_coding_system_internal):
16484 Rename locals to avoid shadowing.
16485 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
16486 * coding.c (emacs_mule_char, encode_invocation_designation):
16487 Now static, since they're not used elsewhere.
413bb2db 16488 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 16489 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
16490 (decode_coding_emacs_mule): Mark variables that gcc
16491 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
16492 (detect_coding_iso_2022): Initialize a local variable that might
16493 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 16494 this initialization is needed. (Bug#8211)
5f58e762
PE
16495 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
16496 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
16497 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
16498 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
16499 Remove unused macros.
f38b440c 16500
232b38b9 16501 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 16502 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 16503 * character.c (string_count_byte8): Likewise.
232b38b9 16504
fb90da1b
PE
16505 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
16506 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
16507
fb93dbc2
PE
16508 * chartab.c (copy_sub_char_table): Now static, since it's not used
16509 elsewhere.
5c156ace
PE
16510 (sub_char_table_ref_and_range, char_table_ref_and_range):
16511 Rename locals to avoid shadowing.
bbcd0949 16512 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 16513
7d3b3862 16514 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 16515 (BIDI_BOB): Remove unused macro.
7d3b3862 16516
6be7d3da
PE
16517 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
16518 deduce are never used uninitialized.
c2ed9c8b 16519 * term.c (encode_terminal_code): Likewise.
6be7d3da 16520
75f8807f 16521 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 16522
50938595
PE
16523 * tparam.h: New file.
16524 * term.c, tparam.h: Include it.
16525 * deps.mk (term.o, tparam.o): Depend on tparam.h.
16526 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
16527 Move these decls to tparam.h, and make them agree with what
16528 is actually in tparam.c. The previous trick of using incompatible
16529 decls in different modules does not conform to the C standard.
16530 All callers of tparam changed to use tparam's actual API.
16531 * tparam.c (tparam1, tparam, tgoto):
16532 Use const pointers where appropriate.
16533
fbceeba2
PE
16534 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
16535 * cm.h (struct cm): Likewise.
16536 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
16537 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
16538 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
16539 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
16540 (turn_on_face, init_tty): Likewise.
16541 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 16542
7f3f1250
PE
16543 * term.c (term_mouse_position): Rename local to avoid shadowing.
16544
e6ca6543
PE
16545 * alloc.c (mark_ttys): Move decl from here ...
16546 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
16547
c40f8d15
AS
165482011-03-11 Andreas Schwab <schwab@linux-m68k.org>
16549
16550 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
16551
cfe0661d
JB
165522011-03-09 Juanma Barranquero <lekktu@gmail.com>
16553
16554 * search.c (compile_pattern_1): Remove argument regp, unused since
16555 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
16556 (compile_pattern): Don't pass it.
16557
0afb4571
J
165582011-03-08 Jan Djärv <jan.h.d@swipnet.se>
16559
16560 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
16561 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
16562 for ! HAVE_GTK3.
16563 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
16564
16565 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
16566
16567 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
16568 gdk_window_get_screen, gdk_window_get_geometry,
16569 gdk_x11_window_lookup_for_display and GDK_KEY_g.
16570 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
16571 (xg_get_pixbuf_from_pixmap): New function.
16572 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
16573 to Pixmap, take frame as parameter, remove GdkColormap parameter.
16574 Call xg_get_pixbuf_from_pixmap instead of
16575 gdk_pixbuf_get_from_drawable.
16576 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
16577 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
16578 (xg_check_special_colors): Use GtkStyleContext and its functions
16579 for HAVE_GTK3.
16580 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
16581 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
16582 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
16583 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
16584 Call gtk_widget_get_preferred_size.
0afb4571
J
16585 (xg_frame_resized): gdk_window_get_geometry only takes 5
16586 parameters.
44f230aa
SM
16587 (xg_win_to_widget, xg_event_is_for_menubar):
16588 Call gdk_x11_window_lookup_for_display.
0afb4571
J
16589 (xg_set_widget_bg): New function.
16590 (delete_cb): New function.
895009e1 16591 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 16592 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
16593 (xg_set_background_color): Call xg_set_widget_bg.
16594 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
16595 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
16596 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
16597 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
16598 if ! HAVE_GTK3.
16599 (update_frame_tool_bar): Call gtk_widget_hide.
16600 (xg_initialize): Use GDK_KEY_g.
16601
16602 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
16603 if ! HAVE_GTK3
16604 (x_session_initialize): Call gdk_x11_set_sm_client_id.
16605
16606 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
16607 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
16608 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
16609
1c2cc4ef
JB
166102011-03-08 Juanma Barranquero <lekktu@gmail.com>
16611
16612 * w32xfns.c (select_palette): Check success of RealizePalette against
16613 GDI_ERROR, not zero.
16614
33383987 16615See ChangeLog.11 for earlier changes.
aac0c6e3
MR
16616
16617;; Local Variables:
16618;; coding: utf-8
aac0c6e3
MR
16619;; End:
16620
2f097256 16621 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
16622
16623 This file is part of GNU Emacs.
16624
16625 GNU Emacs is free software: you can redistribute it and/or modify
16626 it under the terms of the GNU General Public License as published by
16627 the Free Software Foundation, either version 3 of the License, or
16628 (at your option) any later version.
16629
16630 GNU Emacs is distributed in the hope that it will be useful,
16631 but WITHOUT ANY WARRANTY; without even the implied warranty of
16632 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16633 GNU General Public License for more details.
16634
16635 You should have received a copy of the GNU General Public License
16636 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.