* data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
0fed43f3
PE
3 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5 incorrectly succeed when S was a string, because 4294967386 was
6 truncated before it was used.
7
8fd02eb7
PE
8 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9 Otherwise, an out-of-range integer could cause undefined behavior
10 on a 64-bit host.
11
f8c86b69
PE
12 * composite.c: Use int, not EMACS_INT, for characters.
13 (fill_gstring_body, composition_compute_stop_pos): Use int, not
14 EMACS_INT, for values that are known to be in character range.
15 This doesn't fix any bugs but is the usual style inside Emacs and
16 may generate better code on 32-bit machines.
17
34206dd2
PE
18 Make sure a 64-bit char is never passed to ENCODE_CHAR.
19 This is for reasons similar to the recent CHAR_STRING fix.
20 * charset.c (Fencode_char): Check that character arg is actually
21 a character. Pass an int to ENCODE_CHAR.
22 * charset.h (ENCODE_CHAR): Verify that the character argument is no
23 wider than 'int', as a compile-time check to prevent future regressions
24 in this area.
25
c5958d4c 26 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
27
28 Make sure a 64-bit char is never passed to CHAR_STRING.
29 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
30 by silently ignoring the top 32 bits, allowing some values
31 that were far too large to be valid characters.
32 * character.h: Include <verify.h>.
33 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
34 arguments are no wider than unsigned, as a compile-time check
35 to prevent future regressions in this area.
36 * data.c (Faset):
37 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char):
38 (Fsubst_char_in_region):
39 * fns.c (concat):
40 * xdisp.c (decode_mode_spec_coding):
41 Adjust to CHAR_STRING's new requirement.
42 * editfns.c (Finsert_char, Fsubst_char_in_region):
43 * fns.c (concat): Check that character args are actually
44 characters. Without this test, these functions did the wrong
45 thing with wildly out-of-range values on 64-bit hosts.
46
ea204efb
PE
472011-06-12 Paul Eggert <eggert@cs.ucla.edu>
48
d37ca623
PE
49 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
50 These casts should not be needed on 32-bit hosts, either.
51 * keyboard.c (read_char):
52 * lread.c (Fload): Remove casts to unsigned.
53
ea204efb
PE
54 * lisp.h (UNSIGNED_CMP): New macro.
55 This fixes comparison bugs on 64-bit hosts.
56 (ASCII_CHAR_P): Use it.
57 * casefiddle.c (casify_object):
58 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
59 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
60 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
61 * dispextern.h (FACE_FROM_ID):
62 * keyboard.c (read_char): Use UNSIGNED_CMP.
63
fc83f7d3 642011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 65
41cb286c
PE
66 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
67 not to EMACS_INT, to avoid GCC warning.
68
4a1b9832
PE
69 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
70
55daad71
PE
71 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
72 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
73 isn't needed on 32-bit machines.
8f95c75c 74
666398f3 75 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 76 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
77
78 * data.c (Qcompiled_function): Now static.
79
c6f072e7
PE
80 * window.c (window_body_lines): Now static.
81
20ce5912
PE
82 * image.c (gif_load): Rename local to avoid shadowing.
83
9c4c5f81
PE
84 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
85 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
86 * alloc.c (make_save_value): Integer argument is now of type
87 ptrdiff_t, not int.
88 (mark_object): Use ptrdiff_t, not int.
89 * lisp.h (pD): New macro.
90 * print.c (print_object): Use it.
91
c0c5c8ae
PE
92 * alloc.c: Use EMACS_INT, not int, to count objects.
93 (total_conses, total_markers, total_symbols, total_vector_size)
94 (total_free_conses, total_free_markers, total_free_symbols)
95 (total_free_floats, total_floats, total_free_intervals, total_intervals)
96 (total_strings, total_free_strings):
97 Now EMACS_INT, not int. All uses changed.
98 (Fgarbage_collect): Compute overall total using a double, so that
99 integer overflow is less likely to be a problem. Check for overflow
100 when converting back to an integer.
5a25e253
PE
101 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
102 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
103 These were 'int' variables that could overflow on 64-bit hosts;
104 they were never used, so remove them instead of repairing them.
211a0b2a 105 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
106 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
107 Previously, this ceilinged at INT_MAX, but that doesn't work on
108 64-bit machines.
e46bb31a 109 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 110
c78baabf 111 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 112 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
113 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
114 when a (possibly-narrower) signed value would do just as well.
115 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 116
c9d624c6
PE
117 * alloc.c: Catch some string size overflows that we were missing.
118 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
119 for convenience in STRING_BYTES_MAX.
120 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
121 The definition here is exact; the one in lisp.h was approximate.
122 (allocate_string_data): Check for string overflow. This catches
123 some instances we weren't catching before. Also, it catches
124 size_t overflow on (unusual) hosts where SIZE_MAX <= min
125 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
126 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 127
c9d624c6
PE
128 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
129 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
130 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
131
353032ce
PE
132 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
133
2bccce07
PE
134 * alloc.c (Fmake_string): Check for out-of-range init.
135
b50691aa
CY
1362011-06-11 Chong Yidong <cyd@stupidchicken.com>
137
138 * dispextern.h (struct image): Replace data member, whose int_val
139 and ptr_val fields were not used by anything, with a single
140 lisp_val object.
141
142 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
143 (gif_clear_image, gif_load, imagemagick_load_image)
144 (gs_clear_image, gs_load): Callers changed.
145
3f754b86
PE
1462011-06-10 Paul Eggert <eggert@cs.ucla.edu>
147
cca69397
PE
148 * buffer.h: Include <time.h>, for time_t.
149 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
150
109e28d0
PE
151 Fix minor problems found by static checking.
152
60737f02
PE
153 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
154
4b66faf3
PE
155 Make identifiers static if they are not used in other modules.
156 * data.c (Qcompiled_function, Qframe, Qvector):
157 * image.c (QimageMagick, Qsvg):
158 * minibuf.c (Qmetadata):
159 * window.c (resize_window_check, resize_root_window): Now static.
160 * window.h (resize_window_check, resize_root_window): Remove decls.
161
109e28d0
PE
162 * window.c (window_deletion_count, delete_deletable_window):
163 Remove; unused.
46a4ce9e
PE
164 (window_body_lines): Now static.
165 (Fdelete_other_windows_internal): Mark vars as initialized.
166 Make sure 'resize_failed' is initialized.
167 (run_window_configuration_change_hook): Rename local to avoid shadowing.
168 (resize_window_apply): Remove unused local.
169 * window.h (delete_deletable_window): Remove decl.
170
109e28d0 171 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
172 (imagemagick_load_image): Fix pointer signedness problem by changing
173 last arg from unsigned char * to char *. All uses changed.
174 Also, fix a local for similar reasons.
175 Remove unused locals. Remove locals to avoid shadowing.
176 (fn_rsvg_handle_free): Remove; unused.
177 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 178 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 179
3f754b86
PE
180 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
181
2547adb1
CY
1822011-06-10 Chong Yidong <cyd@stupidchicken.com>
183
184 * image.c (gif_load): Fix omitted cast error introduced by
185 2011-06-06 change.
186
2c8e37d4
MR
1872011-06-10 Martin Rudalics <rudalics@gmx.at>
188
189 * window.h (resize_proportionally, orig_total_lines)
190 (orig_top_line): Remove from window structure.
191 (set_window_height, set_window_width, change_window_heights)
192 (Fdelete_window): Remove prototypes.
193 (resize_frame_windows): Remove duplicate declaration.
194
440a42e3
EZ
1952011-06-10 Eli Zaretskii <eliz@gnu.org>
196
197 * window.h (resize_frame_windows, resize_window_check)
198 (delete_deletable_window, resize_root_window)
199 (resize_frame_windows): Declare prototypes.
200
201 * window.c (resize_window_apply): Make definition be "static" to
202 match the prototype.
203
562dd5e9
MR
2042011-06-10 Martin Rudalics <rudalics@gmx.at>
205
206 * window.c: Remove declarations of Qwindow_size_fixed,
207 window_min_size_1, window_min_size_2, window_min_size,
208 size_window, window_fixed_size_p, enlarge_window, delete_window.
209 Remove static from declaration of Qdelete_window, it's
210 temporarily needed by Fbury_buffer.
211 (replace_window): Don't assign orig_top_line and
212 orig_total_lines.
213 (Fdelete_window, delete_window): Remove. Window deletion is
214 handled by window.el.
215 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
216 Fdelete_window calls with calls to Qdelete_window.
217 (Fdelete_other_windows): Remove. Deleting other windows is
218 handled by window.el.
219 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
220 handled in window.el.
221 (window_min_size_2, window_min_size_1, window_min_size): Remove.
222 Window minimum sizes are handled in window.el.
223 (shrink_windows, size_window, set_window_height)
224 (set_window_width, change_window_heights, window_height)
225 (window_width, CURBEG, CURSIZE, enlarge_window)
226 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
227 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
228 handled in window.el.
229 (make_dummy_parent): Rename to make_parent_window and give it a
230 second argument horflag.
231 (make_window): Don't set resize_proportionally any more.
232 (Fsplit_window): Remove. Windows are split in window.el.
233 (save_restore_action, save_restore_orig_size)
234 (shrink_window_lowest_first, save_restore_orig_size): Remove.
235 Resize mini windows in window.el.
236 (grow_mini_window, shrink_mini_window): Implement by calling
237 Qresize_root_window_vertically, resize_window_check and
238 resize_window_apply.
239 (saved_window, Fset_window_configuration, save_window_save): Do
240 not handle orig_top_line, orig_total_lines, and
241 resize_proportionally.
242 (window_min_height, window_min_width): Move to window.el.
243 (keys_of_window): Move bindings for delete-other-windows,
244 split-window, delete-window and enlarge-window to window.el.
245
246 * buffer.c: Temporarily extern Qdelete_window.
247 (Fbury_buffer): Temporarily call Qdelete_window instead of
248 Fdelete_window (Fbury_buffer will move to window.el soon).
249
250 * frame.c (set_menu_bar_lines_1): Remove code handling
251 orig_top_line and orig_total_lines.
252
253 * dispnew.c (adjust_frame_glyphs_initially): Don't use
254 set_window_height but set heights directly.
255 (change_frame_size_1): Use resize_frame_windows.
256
257 * xdisp.c (init_xdisp): Don't use set_window_height but set
258 heights directly.
259
260 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
261 resize_frame_windows instead of change_window_heights and run
262 run_window_configuration_change_hook.
263
264 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
265 instead of change_window_heights and run
266 run_window_configuration_change_hook.
267
1a13852e
MR
2682011-06-09 Martin Rudalics <rudalics@gmx.at>
269
270 * window.c (replace_window): Rename second argument REPLACEMENT to
271 NEW. New third argument SETFLAG. Rewrite.
272 (delete_window, make_dummy_parent): Call replace_window with
273 third argument 1.
274 (window_list_1): Move down in code.
275 (run_window_configuration_change_hook): Move set_buffer part
276 before select_frame_norecord part in order to unwind correctly.
277 Rename count1 to count.
278 (recombine_windows, delete_deletable_window, resize_root_window)
279 (Fdelete_other_windows_internal)
280 (Frun_window_configuration_change_hook, make_parent_window)
281 (resize_window_check, resize_window_apply, Fresize_window_apply)
282 (resize_frame_windows, Fsplit_window_internal)
283 (Fdelete_window_internal, Fresize_mini_window_internal): New
284 functions.
285 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
286
f3d1777e
MR
2872011-06-08 Martin Rudalics <rudalics@gmx.at>
288
496e208e
MR
289 * window.h (window): Add some new members to window structure -
290 normal_lines, normal_cols, new_total, new_normal, clone_number,
291 splits, nest, prev_buffers, next_buffers.
292 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 293 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 294
f3d1777e
MR
295 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
296 Remove.
496e208e
MR
297 (make_dummy_parent): Set new members of windows structure.
298 (make_window): Move down in code. Handle new members of window
299 structure.
300 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
301 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
302 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
303 (Fset_window_prev_buffers, Fwindow_next_buffers)
304 (Fset_window_next_buffers, Fset_window_clone_number): New
305 functions.
306 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
307 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
308 Doc-string fixes.
309 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
310 Argument WINDOW can be now internal window too.
311 (Fwindow_use_time): Move up in code.
312 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
313 Rewrite doc-string.
314 (Fset_window_configuration, saved_window)
315 (Fcurrent_window_configuration, save_window_save): Handle new
316 members of window structure.
b9e809c2
MR
317 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
318 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
319 (syms_of_window): New Lisp objects Qrecord_window_buffer,
320 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
321 Qget_mru_window, Qresize_root_window,
322 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
323 Qauto_buffer_name; staticpro them.
f3d1777e 324
abde8f8c
MR
3252011-06-07 Martin Rudalics <rudalics@gmx.at>
326
327 * window.c (Fwindow_total_size, Fwindow_left_column)
328 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
329 (Fwindow_list_1): New functions.
330 (window_box_text_cols): Replace with window_body_cols.
331 (Fwindow_width, Fscroll_left, Fscroll_right): Use
332 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
333 (delete_window, Fset_window_configuration): Call
334 delete_all_subwindows with window as argument.
335 (delete_all_subwindows): Take a window as argument and not a
336 structure. Rewrite.
190b47e6
MR
337 (window_loop): Remove handling of GET_LRU_WINDOW and
338 GET_LARGEST_WINDOW.
339 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
340
341 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
342 window_box_text_cols. delete_all_subwindows now takes a
343 Lisp_Object as argument.
abde8f8c
MR
344
345 * indent.c (compute_motion, Fcompute_motion): Use
346 window_body_cols instead of window_box_text_cols.
347
fa8a67e6
MR
348 * frame.c (delete_frame): Call delete_all_subwindows with root
349 window as argument.
350
a54e3482
DC
3512011-06-07 Daniel Colascione <dan.colascione@gmail.com>
352
353 * fns.c (Fputhash): Document return value.
354
60002bf5
CY
3552011-06-06 Chong Yidong <cyd@stupidchicken.com>
356
357 * image.c (gif_load): Implement gif89a spec "no disposal" method.
358
0c671da6 3592011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 360
b862a52a 361 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 362
be44ca6c
PE
363 Check for overflow when converting integer to cons and back.
364 * charset.c (Fdefine_charset_internal, Fdecode_char):
365 Use cons_to_unsigned to catch overflow.
366 (Fencode_char): Use INTEGER_TO_CONS.
367 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
368 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
369 * data.c (long_to_cons, cons_to_long): Remove.
370 (cons_to_unsigned, cons_to_signed): New functions.
371 These signal an error for invalid or out-of-range values.
372 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
373 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
374 * font.c (Ffont_variation_glyphs):
375 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
376 * lisp.h: Include <intprops.h>.
377 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
378 (cons_to_signed, cons_to_unsigned): New decls.
379 (long_to_cons, cons_to_long): Remove decls.
380 * undo.c (record_first_change): Use INTEGER_TO_CONS.
381 (Fprimitive_undo): Use CONS_TO_INTEGER.
382 * xfns.c (Fx_window_property): Likewise.
383 * xselect.c: Include <limits.h>.
384 (x_own_selection, selection_data_to_lisp_data):
385 Use INTEGER_TO_CONS.
386 (x_handle_selection_request, x_handle_selection_clear)
387 (x_get_foreign_selection, Fx_disown_selection_internal)
388 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
389 (lisp_data_to_selection_data): Use cons_to_unsigned.
390 (x_fill_property_data): Use cons_to_signed.
391 Report values out of range.
392
d1f3d2af
PE
393 Check for buffer and string overflow more precisely.
394 * buffer.h (BUF_BYTES_MAX): New macro.
395 * lisp.h (STRING_BYTES_MAX): New macro.
396 * alloc.c (Fmake_string):
397 * character.c (string_escape_byte8):
398 * coding.c (coding_alloc_by_realloc):
399 * doprnt.c (doprnt):
400 * editfns.c (Fformat):
401 * eval.c (verror):
402 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
403 since they may not be the same number.
404 * editfns.c (Finsert_char):
405 * fileio.c (Finsert_file_contents):
406 Likewise for BUF_BYTES_MAX.
407
dd52fcea
PE
408 * image.c: Use ptrdiff_t, not int, for sizes.
409 (slurp_file): Switch from int to ptrdiff_t.
410 All uses changed.
411 (slurp_file): Check that file size fits in both size_t (for
412 malloc) and ptrdiff_t (for sanity and safety).
413
7f9bbdbb
PE
414 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
415 if b->modtime has its maximal value.
416
dfe18f82
PE
417 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
418
84acfcf0
PE
419 Don't assume time_t can fit into int.
420 * buffer.h (struct buffer.modtime): Now time_t, not int.
421 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
422 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
423
ccd9a01a
PE
424 Minor fixes for signed vs unsigned integers.
425 * character.h (MAYBE_UNIFY_CHAR):
426 * charset.c (maybe_unify_char):
427 * keyboard.c (read_char, reorder_modifiers):
428 XINT -> XFASTINT, since the integer must be nonnegative.
429 * ftfont.c (ftfont_spec_pattern):
430 * keymap.c (access_keymap, silly_event_symbol_error):
431 XUINT -> XFASTINT, since the integer must be nonnegative.
432 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
433 since it makes no difference and we prefer signed.
434 * keyboard.c (record_char): Use XUINT when all the neighbors do.
435 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
436 nonnegative.
437
d6d100dd
SM
4382011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
439
440 * window.h (Fwindow_frame): Declare.
441
2b6148e4
PE
4422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
443
444 * alloc.c: Simplify handling of large-request failures (Bug#8800).
445 (SPARE_MEMORY): Always define.
446 (LARGE_REQUEST): Remove.
447 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
448
f230ecc9
MR
4492011-06-06 Martin Rudalics <rudalics@gmx.at>
450
727e958e
MR
451 * lisp.h: Move EXFUNS for Fframe_root_window,
452 Fframe_first_window and Fset_frame_selected_window to window.h.
453
454 * window.h: Move EXFUNS for Fframe_root_window,
455 Fframe_first_window and Fset_frame_selected_window here from
456 lisp.h.
457
458 * frame.c (Fwindow_frame, Fframe_first_window)
459 (Fframe_root_window, Fframe_selected_window)
460 (Fset_frame_selected_window): Move to window.c.
461 (Factive_minibuffer_window): Move to minibuf.c.
462 (Fother_visible_frames_p): New function.
463
464 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
465
f230ecc9
MR
466 * window.c (decode_window, decode_any_window): Move up in code.
467 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
468 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
469 (Fwindow_buffer): Move up and rewrite doc-string.
470 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
471 (Fwindow_prev): New functions.
727e958e
MR
472 (Fwindow_frame): Move here from frame.c. Accept any window as
473 argument.
474 (Fframe_root_window, Fframe_first_window)
475 (Fframe_selected_window): Move here from frame.c. Accept frame
476 or arbitrary window as argument. Update doc-strings.
477 (Fminibuffer_window): Move up in code.
478 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
479 (Fset_frame_selected_window): Move here from frame.c.
480 Marginal rewrite.
727e958e
MR
481 (Fselected_window, select_window, Fselect_window): Move up in
482 code. Minor doc-string fixes.
f230ecc9 483
4d09bcf6
PE
4842011-06-06 Paul Eggert <eggert@cs.ucla.edu>
485
486 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
487 Do not assume that spare memory exists; that assumption is valid
488 only if SYSTEM_MALLOC.
489 (LARGE_REQUEST): New macro, so that the issue of large requests
490 is separated from the issue of spare memory.
491
810928a2
AS
4922011-06-05 Andreas Schwab <schwab@linux-m68k.org>
493
172418ad
AS
494 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
495 format. (Bug#8806)
496
43f862f7
AS
497 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
498
810928a2
AS
499 * xfns.c (x_set_scroll_bar_default_width): Move declarations
500 before statements.
501
a059fe24
JD
5022011-06-05 Jan Djärv <jan.h.d@swipnet.se>
503
504 * gtkutil.c (xg_get_default_scrollbar_width): New function.
505
506 * gtkutil.h: Declare xg_get_default_scrollbar_width.
507
508 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
509 min width by calling x_set_scroll_bar_default_width (Bug#8505).
510
989bf368
JB
5112011-06-05 Juanma Barranquero <lekktu@gmail.com>
512
513 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
514
4b80f674
CY
5152011-06-04 Chong Yidong <cyd@stupidchicken.com>
516
517 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
518 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
519 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
520 New error handlers.
4b80f674
CY
521 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
522 Obey Vx_select_enable_clipboard_manager. Catch errors in
523 x_clipboard_manager_save (Bug#8779).
524 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 525 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 526
99a33b77 5272011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
528
529 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
530
99a33b77 5312011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
532
533 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
534 in the current matrix if keep_current_p is non-zero.
535
8264569d
EZ
5362011-06-04 Eli Zaretskii <eliz@gnu.org>
537
538 * bidi.c (bidi_level_of_next_char): Fix last change.
539
57f97249
EZ
5402011-06-03 Eli Zaretskii <eliz@gnu.org>
541
fec2107c 542 Support bidi reordering of text covered by display properties.
57f97249 543
fec2107c
EZ
544 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
545 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
546 (bidi_cache_search, bidi_cache_iterator_state)
547 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
548 (bidi_level_of_next_char, bidi_move_to_visually_next):
549 Support character positions inside a run of characters covered by a
fec2107c
EZ
550 display string.
551 (bidi_paragraph_init, bidi_resolve_explicit_1)
552 (bidi_level_of_next_char): Call bidi_fetch_char and
553 bidi_fetch_char_advance instead of FETCH_CHAR and
554 FETCH_CHAR_ADVANCE.
555 (bidi_init_it): Initialize new members.
556 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
557 definitions.
558 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
559 instead of using explicit *_CHAR codes.
d6d100dd
SM
560 (bidi_resolve_explicit, bidi_resolve_weak):
561 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
562 bidirectional text is supported only in multibyte buffers.
563 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
564 it to initialize the frame_window_p member of struct bidi_it.
565 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
566 (bidi_resolve_explicit, bidi_resolve_weak)
567 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
568 bidi_it->nchars is non-positive.
569 (bidi_level_of_next_char): Don't try to lookup the cache for the
570 next/previous character if nothing is cached there yet, or if we
571 were just reseat()'ed to a new position.
c40e2fb2 572
0e14fe90
EZ
573 * xdisp.c (set_cursor_from_row): Set start and stop points
574 according to the row's direction when priming the loop that looks
575 for the glyph on which to display cursor.
576 (single_display_spec_intangible_p): Function deleted.
577 (display_prop_intangible_p): Reimplement to call
578 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
579 Accept 3 additional arguments needed by handle_display_spec.
580 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
581 values: lists, `(when COND...)' forms, etc.
582 (single_display_spec_string_p): Support property values that are
583 lists with the argument STRING its top-level element.
584 (display_prop_string_p): Fix the condition for processing a
585 property that is a list to be consistent with handle_display_spec.
fec2107c 586 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
587 last portion of handle_display_prop.
588 (compute_display_string_pos): Accept additional argument
589 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
590 value of a `display' property is a "replacing spec".
591 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
592 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
593 the display property, but just return a value indicating whether
594 the display property will replace the characters it covers.
595 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
596 frame_window_p members of struct bidi_it.
d6d100dd
SM
597 (compute_display_string_pos, compute_display_string_end):
598 New functions.
fec2107c
EZ
599 (push_it): Accept second argument POSITION, where pop_it should
600 jump to continue iteration.
601 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 602
fec2107c
EZ
603 * keyboard.c (adjust_point_for_property): Adjust the call to
604 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
605
606 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
607 (bidi_init_it): Update prototypes.
608 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
609 (compute_display_string_pos, compute_display_string_end):
610 Declare prototypes.
fec2107c
EZ
611 (struct bidi_it): New members nchars and disp_pos. ch_len is now
612 EMACS_INT.
fc6f18ce 613
40087514 6142011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 615
57f53182
PE
616 Malloc failure behavior now depends on size of allocation.
617 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
618 * lisp.h: Change signatures accordingly.
619 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
620 All callers changed. (Bug#8762)
621
622 * gnutls.c: Use Emacs's memory allocators.
623 Without this change, the gnutls library would invoke malloc etc.
624 directly, which causes problems on non-SYNC_INPUT hosts, and which
625 runs afoul of improving memory_full behavior. (Bug#8761)
626 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
627 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
628 xfree instead of the default malloc, realloc, free.
629 (Fgnutls_boot): No need to check for memory allocation failure,
630 since xmalloc does that for us.
631
ac32cd99 632 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
633 * category.c (hash_get_category_set):
634 * ccl.c (ccl_driver):
635 * charset.c (Fdefine_charset_internal):
636 * charset.h (struct charset.hash_index):
637 * composite.c (get_composition_id, gstring_lookup_cache)
638 (composition_gstring_put_cache):
639 * composite.h (struct composition.hash_index):
640 * dispextern.h (struct image.hash):
641 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
642 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
643 (hashfn_equal, hashfn_user_defined, make_hash_table)
644 (maybe_resize_hash_table, hash_lookup, hash_put)
645 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
646 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
647 (Fsxhash, Fgethash, Fputhash, Fmaphash):
648 * image.c (make_image, search_image_cache, lookup_image)
649 (xpm_put_color_table_h):
650 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 651 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
652 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
653 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
654 * alloc.c (allocate_vectorlike):
655 Check for overflow in vector size calculations.
656 * ccl.c (ccl_driver):
657 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
658 * fns.c, image.c: Remove unnecessary static decls that would otherwise
659 need to be updated by these changes.
40087514
PE
660 * fns.c (make_hash_table, maybe_resize_hash_table):
661 Check for integer overflow with large hash tables.
0de4bb68
PE
662 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
663 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
664 (SXHASH_REDUCE): New macro.
665 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
666 Use it instead of discarding useful hash info with large hash values.
667 (sxhash_float): New function.
668 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
669 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
670 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
671 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
672 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
673 Adjust signatures to match updated version of code.
674 (consing_since_gc): Now EMACS_INT, since a single hash table can
675 use more than INT_MAX bytes.
676
698d32e2
DN
6772011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
678
679 Make it possible to build with GCC-4.6+ -O2 -flto.
680
681 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
682
fd6fa53f
SM
6832011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
684
685 * minibuf.c (get_minibuffer, read_minibuf_unwind):
686 Call minibuffer-inactive-mode.
687
864db017
JB
6882011-05-31 Juanma Barranquero <lekktu@gmail.com>
689
690 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
691 Update dependencies.
692
2ad0baf4
DN
6932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
694
695 * data.c (init_data): Remove code for UTS, this system is not
696 supported anymore.
697
4fcc2638
DN
6982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
699
700 Don't force ./temacs to start in terminal mode.
701
702 * frame.c (make_initial_frame): Initialize faces in all cases, not
703 only when CANNOT_DUMP is defined.
704 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
705
c56e0fd5
DN
7062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
707
708 * dispnew.c (add_window_display_history): Use const for the string
709 pointer. Remove declaration, not needed.
710
333d54da 7112011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 712
55d4c1b2 713 Use 'inline', not 'INLINE'.
333d54da 714 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
715 * alloc.c, fontset.c (INLINE): Remove.
716 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
717 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
718 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
719 * gmalloc.c (register_heapinfo): Use inline unconditionally.
720 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
721
738db178
DN
7222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
723
724 Make it possible to run ./temacs.
725
726 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
727 syms_of_callproc does the same thing. Remove test for
728 "initialized", do it in the caller.
729 * emacs.c (main): Avoid calling set_initial_environment when dumping.
730
620c53a6
SM
7312011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
732
733 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
734 (read_minibuf): Use get_minibuffer.
735 (syms_of_minibuf): Use DEFSYM.
736 (Qmetadata): New var.
737 * data.c (Qbuffer): Don't make it static.
738 (syms_of_data): Use DEFSYM.
739
e003a292
PE
7402011-05-31 Paul Eggert <eggert@cs.ucla.edu>
741
742 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
743 (CCL_CODE_MIN): New macro.
744
ed008a6d
PE
7452011-05-30 Paul Eggert <eggert@cs.ucla.edu>
746
3687c2ef
PE
747 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
748
ed008a6d
PE
749 * eval.c (Qdebug): Now static.
750 * lisp.h (Qdebug): Remove decl. This reverts a part of the
751 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
752 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
753
d66c4c7c
CY
7542011-05-29 Chong Yidong <cyd@stupidchicken.com>
755
756 * image.c: Various fixes to ImageMagick code comments.
757 (Fimagemagick_types): Doc fix.
758
5fbc2025
PE
7592011-05-29 Paul Eggert <eggert@cs.ucla.edu>
760
0196f88a
PE
761 Minor fixes prompted by GCC 4.6.0 warnings.
762
763 * xselect.c (converted_selections, conversion_fail_tag): Now static.
764
5fbc2025
PE
765 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
766 (x_clipboard_manager_save_all): Move extern decl to ...
767 * xterm.h: ... here, so that it can be checked for consistency.
768
1dd3c2d9
CY
7692011-05-29 Chong Yidong <cyd@stupidchicken.com>
770
771 * xselect.c (x_clipboard_manager_save_frame)
772 (x_clipboard_manager_save_all): New functions.
773 (Fx_clipboard_manager_save): Lisp function deleted.
774
775 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
776 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
777
778 * xterm.h: Update prototype.
779
5ba6571d
WX
7802011-05-28 William Xu <william.xwl@gmail.com>
781
782 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
783 exiting (Bug#8239).
784
3eaff834
JM
7852011-05-28 Jim Meyering <meyering@redhat.com>
786
e1900994 787 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
788 * fns.c (to_uchar): Define.
789 (crypto_hash_function): Use it to convert some newly-signed
790 variables to unsigned, to avoid sign-extension bugs. For example,
791 without this change, (md5 "truc") would evaluate to
792 45723a2aff78ff4fff7fff1114760e62 rather than the expected
793 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 794 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 795
0f6990a7
PE
7962011-05-27 Paul Eggert <eggert@cs.ucla.edu>
797
798 Integer overflow fixes.
c8a9ca5a 799
08686060
PE
800 * dbusbind.c: Serial number integer overflow fixes.
801 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
802 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
803 to hold a serial number that is too large for a fixnum.
804 (Fdbus_method_return_internal, Fdbus_method_error_internal):
805 Check for serial numbers out of range. Decode any serial number
59568bf0 806 that was so large that it became a float. (Bug#8722)
08686060 807
2d1fc3c7
PE
808 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
809 (Fdbus_call_method, Fdbus_call_method_asynchronously):
810 Use XFASTINT rather than XUINT when numbers are nonnegative.
811 (xd_append_arg, Fdbus_method_return_internal):
812 (Fdbus_method_error_internal): Likewise. Also, for unsigned
813 arguments, check that Lisp number is nonnegative, rather than
59568bf0 814 silently wrapping negative numbers around. (Bug#8722)
30217ff0 815 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 816 (Bug#8722)
2d1fc3c7 817
c8a9ca5a
PE
818 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
819
519e1d69
PE
820 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
821
30569699
PE
822 ccl: add integer overflow checks
823 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
824 (IN_INT_RANGE): New macros.
825 (ccl_driver): Use them to check for integer overflow when
826 decoding a CCL program. Many of the new checks are whether XINT (x)
827 fits in int; it doesn't always, on 64-bit hosts. The new version
828 doesn't catch all possible integer overflows, but it's an
847044ea 829 improvement. (Bug#8719)
30569699 830
c11285dc
PE
831 * alloc.c (make_event_array): Use XINT, not XUINT.
832 There's no need for unsigned here.
833
fdccd48e
PE
834 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
835 This follows up to the 2011-05-06 change that substituted uintptr_t
836 for EMACS_INT. This case wasn't caught back then.
837
37910ab2
PE
838 Rework Fformat to avoid integer overflow issues.
839 * editfns.c: Include <float.h> unconditionally, as it's everywhere
840 now (part of C89). Include <verify.h>.
841 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
842 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
843 (Fformat): Avoid the prepass trying to compute sizes; it was only
844 approximate and thus did not catch overflow reliably. Instead, walk
845 through the format just once, formatting and computing sizes as we go,
846 checking for integer overflow at every step, and allocating a larger
847 buffer as needed. Keep track separately whether the format is
848 multibyte. Keep only the most-recently calculated precision, rather
849 than them all. Record whether each argument has been converted to
850 string. Use EMACS_INT, not int, for byte and char and arg counts.
851 Support field widths and precisions larger than INT_MAX. Avoid
852 sprintf's undefined behavior with conversion specifications such as %#d
853 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
854 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
855 formatting out-of-range floating point numbers with int
856 formats. (Bug#8668)
857
2e6578fb
PE
858 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
859
0ae6bdee
PE
860 * data.c: Avoid integer truncation in expressions involving floats.
861 * data.c: Include <intprops.h>.
862 (arith_driver): When there's an integer overflow in an expression
863 involving floating point, convert the integers to floating point
864 so that the resulting value does not suffer from catastrophic
865 integer truncation. For example, on a 64-bit host (* 4
866 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
867 Do not rely on undefined behavior after integer overflow.
868
de883a70
PE
869 merge count_size_as_multibyte, parse_str_to_multibyte
870 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 871 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
872 Check for integer overflow.
873 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
874 since it's now a duplicate of the other. This is more of
875 a character than a buffer op, so better that it's in character.c.
876 * fns.c, print.c: Adjust to above changes.
877
2ff916cb
PE
8782011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
879
880 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
881
f1b54466
PE
8822011-05-27 Paul Eggert <eggert@cs.ucla.edu>
883
fb1ac845
PE
884 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
885 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
886 (x_clipboard_manager_save): Now static.
887 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
888
f1b54466
PE
889 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
890 (crypto_hash_function): Now static.
891 Fix pointer signedness problems. Avoid unnecessary initializations.
892
a9f737ee
CY
8932011-05-27 Chong Yidong <cyd@stupidchicken.com>
894
895 * termhooks.h (Vselection_alist): Make it terminal-local.
896
897 * terminal.c (create_terminal): Initialize it.
898
899 * xselect.c: Support for clipboard managers.
900 (Vselection_alist): Move to termhooks.h as terminal-local var.
901 (LOCAL_SELECTION): New macro.
902 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
903 (symbol_to_x_atom): Remove gratuitous arg.
904 (x_handle_selection_request, lisp_data_to_selection_data)
905 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
906 (x_own_selection, x_get_local_selection, x_convert_selection):
907 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
908 (some_frame_on_display): Delete unused function.
909 (Fx_own_selection_internal, Fx_get_selection_internal)
910 (Fx_disown_selection_internal, Fx_selection_owner_p)
911 (Fx_selection_exists_p): New optional frame arg.
912 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
913 (x_handle_selection_clear): Don't treat other terminals with the
914 same keyboard specially. Use the terminal-local Vselection_alist.
915 (x_clear_frame_selections): Use Frun_hook_with_args.
916
917 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
918
919 * xterm.h: Add support for those atoms.
920
e067f0c1
CY
9212011-05-26 Chong Yidong <cyd@stupidchicken.com>
922
923 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
924 (converted_selections, conversion_fail_tag): New global variables.
925 (x_selection_request_lisp_error): Free the above.
926 (x_get_local_selection): Remove unnecessary code.
927 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
928 of converted selections stored in converted_selections.
929 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
930 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
931 (x_convert_selection): New function.
932 (x_handle_selection_event): Simplify.
933 (x_get_foreign_selection): Don't ignore incoming requests while
934 waiting for an answer; this will fail when we implement
935 SAVE_TARGETS, and seems unnecessary anyway.
936 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
937 (Vx_sent_selection_functions): Doc fix.
938
0f4aebc0
LL
9392011-05-26 Leo Liu <sdl.web@gmail.com>
940
941 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
942
e61124cd
YM
9432011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
944
945 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
946
947 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
948 for fringe update if it has periodic bitmap.
949 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
950 and fringe_bitmap_periodic_p.
951
952 * fringe.c (get_fringe_bitmap_data): New function.
953 (draw_fringe_bitmap_1, update_window_fringes): Use it.
954 (update_window_fringes): Record periodicity of fringe bitmap in glyph
955 row. Mark glyph row for fringe update if periodicity changed.
956
957 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
958 for fringe update unless it has periodic bitmap.
959
f16d9837
KH
9602011-05-25 Kenichi Handa <handa@m17n.org>
961
962 * xdisp.c (get_next_display_element): Set correct it->face_id for
963 a static composition.
964
e1b90ef6
LL
9652011-05-24 Leo Liu <sdl.web@gmail.com>
966
967 * deps.mk (fns.o):
968 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
969
970 * fns.c (crypto_hash_function, Fsha1): New function.
971 (Fmd5): Use crypto_hash_function.
972 (syms_of_fns): Add Ssha1.
973
7400048f
PE
9742011-05-22 Paul Eggert <eggert@cs.ucla.edu>
975
976 * gnutls.c: Remove unused macros.
977 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
978 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
979 Remove macros that are defined and never used.
980 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
981
abb71cf4
CY
9822011-05-22 Chong Yidong <cyd@stupidchicken.com>
983
984 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
985 (Fx_get_selection_internal): Minor cleanup.
986 (Fx_own_selection_internal): Rename arguments for consistency with
987 select.el.
988
6307db39
PE
9892011-05-22 Paul Eggert <eggert@cs.ucla.edu>
990
991 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
992
f3d4e0a4
CY
9932011-05-22 Chong Yidong <cyd@stupidchicken.com>
994
995 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
996
4d8ade89
YM
9972011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
998
999 * dispnew.c (scrolling_window): Don't exclude the case that the
1000 last enabled row in the desired matrix touches the bottom boundary.
1001
32078c8d
GM
10022011-05-21 Glenn Morris <rgm@gnu.org>
1003
1004 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1005 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1006 and add some more files.
32078c8d 1007
7285dc67
EZ
10082011-05-20 Eli Zaretskii <eliz@gnu.org>
1009
1010 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1011 report_file_error introduced by the change from 2011-05-07.
1012
89d1bd22
PE
10132011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1014
1015 * systime.h (Time): Define only if emacs is defined.
1016 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1017 where the include path doesn't have X11/X.h by default. See
1018 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1019
e23640bb 10202011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1021
1022 * composite.c (find_automatic_composition): Fix previous change.
1023
b9704ad9
GM
10242011-05-20 Glenn Morris <rgm@gnu.org>
1025
1026 * lisp.mk: New file, split from Makefile.in.
1027 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1028 (shortlisp): Remove.
1029 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1030
4a720484
GM
10312011-05-19 Glenn Morris <rgm@gnu.org>
1032
1033 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1034 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1035 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1036 (lisp): Set the order to that of loadup.el.
1037 (shortlisp): Make it a copy of $lisp.
1038 (SOME_MACHINE_LISP): Remove.
1039 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1040 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1041
a28d4396
KH
10422011-05-18 Kenichi Handa <handa@m17n.org>
1043
1044 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1045 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1046 (find_automatic_composition): Mostly rewrite for efficiency.
1047
a2b1fa8e
JB
10482011-05-18 Juanma Barranquero <lekktu@gmail.com>
1049
1050 * makefile.w32-in: Update dependencies.
1051
8e1f5610
CS
10522011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1053
1054 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1055 revision 104625).
1056
7025ee00 10572011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1058
cdfa6eab
PE
1059 Fix some integer overflow issues, such as string length overflow.
1060
06d6db33
PE
1061 * insdel.c (count_size_as_multibyte): Check for string overflow.
1062
2b4560a8
PE
1063 * character.c (lisp_string_width): Check for string overflow.
1064 Use EMACS_INT, not int, for string indexes and lengths; in
1065 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1066 the resulting string length overflows an EMACS_INT; instead,
1067 report a string overflow if no precision given. When checking for
1068 precision exhaustion, use a check that cannot possibly have
1069 integer overflow. (Bug#8675)
1070 * character.h (lisp_string_width): Adjust to new signature.
1071
cb93f9be
PE
1072 * alloc.c (string_overflow): New function.
1073 (Fmake_string): Use it. This doesn't change behavior, but saves
1074 a few bytes and will simplify future changes.
1075 * character.c (string_escape_byte8): Likewise.
1076 * lisp.h (string_overflow): New decl.
1077
1a1f3366
PE
1078 Fixups, following up to the user-interface timestamp change.
1079 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1080 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1081 * msdos.c (mouse_get_pos): Likewise.
1082 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1083 * w32gui.h (Time): Define by including "systime.h" rather than by
1084 declaring it ourselves. (Bug#8664)
1085
d4e3e4d3
PE
1086 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1087 * image.c (clear_image_cache): Likewise.
1088
f6a24d19
PE
1089 * term.c (term_mouse_position): Don't assume time_t wraparound.
1090
08dc5ae6
PE
1091 Be more systematic about user-interface timestamps.
1092 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1093 and sometimes 'EMACS_UINT', to represent these timestamps.
1094 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1095 This makes the code easier to follow, and makes it easier to catch
1096 integer overflow bugs such as Bug#8664.
1097 * frame.c (Fmouse_position, Fmouse_pixel_position):
1098 Use Time, not unsigned long, for user-interface timestamps.
1099 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1100 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1101 * keyboard.h (last_event_timestamp): Likewise.
1102 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1103 * menu.h (xmenu_show): Likewise.
1104 * term.c (term_mouse_position): Likewise.
1105 * termhooks.h (struct input_event.timestamp): Likewise.
1106 (struct terminal.mouse_position_hook): Likewise.
1107 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1108 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1109 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1110 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1111 what it was before.
1112 * menu.h, termhooks.h: Include "systime.h", for Time.
1113
8e55734a
PE
1114 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1115 Don't assume that the difference between two unsigned long values
1116 can fit into an integer. At this point, we know button_down_time
1117 <= event->timestamp, so the difference must be nonnegative, so
1118 there's no need to cast the result if double-click-time is
1119 nonnegative, as it should be; check that it's nonnegative, just in
1120 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1121 apart (about 25 days). (Bug#8664)
8e55734a 1122
841f1b75 1123 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1124 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1125
3e26f69c
PE
1126 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1127 that always fit in int. Use a sentinel instead of a counter, to
1128 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1129 * frame.h (struct frame): Use int for menu_bar_items_used
1130 instead of EMACS_INT, since it always fits in int.
3e26f69c 1131
5cc152c0
PE
1132 * menu.c (grow_menu_items): Check for int overflow.
1133
d89eb65e
PE
1134 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1135
5235bd3e
PE
1136 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1137 Before, the code was not consistent. These values cannot exceed
1138 2**31 - 1 so there's no need to make them unsigned.
1139 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1140 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1141 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1142 as modifiers.
1143 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1144
bc827e23
PE
1145 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1146 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1147 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1148 presumably because the widths might not match.
1149
78eb494e
PE
1150 * window.c (size_window): Avoid needless test at loop start.
1151
04f2d78b
CB
11522011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1153
1154 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1155
d2fc7e3d 11562011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1157
1158 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1159
d2fc7e3d 11602011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1161
1162 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1163 `width' to `bar_area_x' and `bar_area_width', respectively.
1164 (x_scroll_run): Take account of fringe background extension.
1165
04f2d78b
CB
1166 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1167 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1168 `bar_area_width', respectively.
1169 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1170 background extension.
1171
79b70037
GM
11722011-05-10 Jim Meyering <meyering@redhat.com>
1173
1174 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1175
2f142cc5
JB
11762011-05-10 Juanma Barranquero <lekktu@gmail.com>
1177
1178 * image.c (Finit_image_library): Return t for built-in image types,
1179 like pbm and xbm. (Bug#8640)
1180
57679c86
AS
11812011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1182
1183 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1184
888c9e86
EZ
11852011-05-07 Eli Zaretskii <eliz@gnu.org>
1186
b0512a1d
EZ
1187 * w32console.c (Fset_screen_color): Doc fix.
1188 (Fget_screen_color): New function.
1189 (syms_of_ntterm): Defsubr it.
1190
7285dc67
EZ
1191 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1192 unlink the temporary file if Fcall_process didn't create it in the
1193 first place.
1194 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1195 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1196 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1197 cue to call_process_cleanup not to close that handle.
1198
4d3fcc8e
BK
11992011-05-07 Ben Key <bkey76@gmail.com>
1200
1201 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1202 one of two shell specific rules, either bootstrap-temacs-CMD or
1203 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1204 to the previous implementation of the bootstrap-temacs rule.
1205 The bootstrap-temacs-CMD rule is similar to the previous
1206 implementation of the bootstrap-temacs rule except that it
1207 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1208 variable.
1209
1210 These changes, along with some changes to nt/configure.bat,
1211 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1212 earlier fix to add support for --cflags and --ldflags options
1213 that include quotes so that it works whether make uses cmd or
1214 sh as the shell.
1215
b4289b64
MA
12162011-05-06 Michael Albinus <michael.albinus@gmx.de>
1217
1218 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1219 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1220 is a constant.
1221 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1222 a string. Handle both cases.
1223 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1224 (Fdbus_register_method): Use Qinvalid_function.
1225
af4c0e28
JB
12262011-05-06 Juanma Barranquero <lekktu@gmail.com>
1227
1228 * makefile.w32-in: Update dependencies.
1229 (LISP_H): Add inttypes.h and stdin.h.
1230 (PROCESS_H): Add unistd.h.
1231
c51453d9
EZ
12322011-05-06 Eli Zaretskii <eliz@gnu.org>
1233
1234 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1235 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1236
8ff0ac3c 12372011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1238
4c4b566b
PE
1239 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1240
aab2b9b5
PE
1241 * term.c (vfatal): Remove stray call to va_end.
1242 It's not needed and the C Standard doesn't allow it here anyway.
1243
c378da0b
PE
1244 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1245 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1246
288b08c7
PE
1247 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1248 bytes.
1249
e3601888
PE
1250 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1251
db6c0e74
PE
1252 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1253
dd5963ea
PE
1254 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1255
88c9450f
PE
1256 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1257
2f9442b8
PE
1258 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1259
c032b5f8
PE
1260 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1261 * charset.c (Fdefine_charset_internal): Don't initialize
1262 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1263 32-bit int (Bug#8600).
a108c10b
PE
1264
1265 * lread.c (read_integer): Be more consistent with string-to-number.
1266 Use string_to_number to do the actual conversion; this avoids
1267 rounding errors and fixes some other screwups. Without this fix,
1268 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1269 (digit_to_number): Move earlier, for benefit of read_integer.
1270 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1271 not a digit in any supported base. (Bug#8602)
a108c10b 1272
ad5f9eea
PE
1273 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1274
aec1708a
PE
1275 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1276 to match comment at start of function. This also removes a
1277 GCC warning about overflow in a 32+64-bit port.
1278
47be4ab5
PE
1279 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1280
371cac43
PE
1281 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1282 Reported by Stefan Monnier in
1283 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1284 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1285 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1286
d01a7826
PE
1287 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1288 (EMACS_UINTPTR): Likewise, with uintptr_t.
1289
7fd47d5c
PE
1290 * lisp.h: Prefer 64-bit EMACS_INT if available.
1291 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1292 on 32-bit hosts that have 64-bit int, so that they can access
1293 large files.
122b0c86
PE
1294 However, temporarily disable this change unless the temporary
1295 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1296
8727937b
PE
1297 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1298
8ac068ac
PE
1299 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1300 This removes an assumption that EMACS_INT and long are the same
1301 width as pointers. The assumption is true for Emacs porting targets
1302 now, but we want to make other targets possible.
1303 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1304 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1305 In the rest of the code, change types of integers that hold casted
1306 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1307 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1308 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1309 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1310 No need to cast type when ORing.
1311 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1312 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1313 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1314 assume EMACS_INT is the same width as char *.
1315 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1316 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1317 Remove no-longer-needed casts.
1318 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1319 (xg_tool_bar_help_callback, xg_make_tool_item):
1320 Use EMACS_INTPTR to hold an integer
1321 that will be cast to void *; this can avoid a GCC warning
1322 if EMACS_INT is not the same width as void *.
1323 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1324 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1325 (current_message_1, set_message_1):
1326 Use a local to convert to proper width without a cast.
1327 * xmenu.c (dialog_selection_callback): Likewise.
1328
ede49d71
PE
1329 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1330 Also, don't assume VALBITS / RAND_BITS is less than 5,
1331 and don't rely on undefined behavior when shifting a 1 left into
1332 the sign bit.
1333 * lisp.h (get_random): Change signature to match.
1334
2f30ecd0
PE
1335 * lread.c (hash_string): Use size_t, not int, for hash computation.
1336 Normally we prefer signed values; but hashing is special, because
1337 it's better to use unsigned division on hash table sizes so that
1338 the remainder is nonnegative. Also, size_t is the natural width
1339 for hashing into memory. The previous code used 'int', which doesn't
1340 retain enough info to hash well into very large tables.
1341 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1342
2a866e7b
PE
1343 * dbusbind.c: Don't possibly lose pointer info when converting.
1344 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1345 Use XPNTR rather than XHASH, so that the high-order bits of
1346 the pointer aren't lost when converting through void *.
1347
51639eac
PE
1348 * eval.c (Fautoload): Don't double-shift a pointer.
1349
92394119
PE
1350 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1351
dbdb9a7c
JB
13522011-05-06 Juanma Barranquero <lekktu@gmail.com>
1353
1354 * gnutls.c (DEF_GNUTLS_FN):
1355 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1356
db7a0b4f
AS
13572011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1358
1359 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1360 marker. (Bug#8610)
1361
f7ff1b0f 13622011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1363
1364 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1365 New version that can reserve upto 2GB of heap space.
1366
f7ff1b0f 13672011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1368
1369 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1370
639c109b
TZ
13712011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1372
1373 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1374 `gnutls_certificate_set_x509_key_file'.
1375
d2127135
JB
13762011-05-05 Juanma Barranquero <lekktu@gmail.com>
1377
1378 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1379 Update dependencies.
1380
e968f4f3
JB
13812011-05-04 Juanma Barranquero <lekktu@gmail.com>
1382
1383 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1384 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1385 Remove unused parameter `fildes'.
1386 * process.c (read_process_output, send_process): Don't pass it.
1387
84d358f0
JB
13882011-05-04 Juanma Barranquero <lekktu@gmail.com>
1389
1390 Fix previous change: the library cache is defined in w32.c.
1391 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1392 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1393
0898ca10
JB
13942011-05-04 Juanma Barranquero <lekktu@gmail.com>
1395
1396 Implement dynamic loading of GnuTLS on Windows.
1397
1398 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1399 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1400 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1401 Declare.
1402
1403 * gnutls.c (Qgnutls_dll): Define.
1404 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1405 (gnutls_*): Declare function pointers.
1406 (init_gnutls_functions): New function to initialize function pointers.
1407 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1408 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1409 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1410 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1411 (emacs_gnutls_write, emacs_gnutls_read)
1412 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1413 (Fgnutls_available_p): New function.
1414 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1415 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1416 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1417
1418 * image.c: Include w32.h.
1419 (Vimage_type_cache): Delete.
1420 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1421 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1422 (w32_delayed_load): Move to w32.c.
1423
1424 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1425
1426 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1427 (w32_delayed_load): Move from image.c. When loading a library, record
1428 its filename in the :loaded-from property of the library id.
1429 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1430 Initialize and staticpro them.
1431 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1432
1433 * process.c: Include lisp.h before w32.h, not after.
1434 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1435 instead of gnutls_record_check_pending.
1436
1437 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1438
ff4de4aa
TZ
14392011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1440
1441 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1442 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1443 as passed in.
1444
abe95abb
JD
14452011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1446
1447 * xterm.c (x_set_frame_alpha): Do not set property on anything
1448 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1449
e16e55d4
JB
14502011-05-02 Juanma Barranquero <lekktu@gmail.com>
1451
1452 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1453
bafcf6a5
JB
14542011-05-02 Juanma Barranquero <lekktu@gmail.com>
1455
1456 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1457 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1458 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1459 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1460 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1461 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1462 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1463 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1464 (Qgnutls_bootprop_callbacks_verify): Make static.
1465
e7a6747f
AS
14662011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1467
19ed11ba
AS
1468 * callproc.c: Indentation fixup.
1469
e7a6747f 1470 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1471 (wait_for_termination, interruptible_wait_for_termination):
1472 Move after wait_for_termination_1.
e7a6747f 1473
1ef14cb4
LMI
14742011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1475
1476 * sysdep.c (interruptible_wait_for_termination): New function
1477 which is like wait_for_termination, but allows keyboard
1478 interruptions.
1479
1480 * callproc.c (Fcall_process): Add (:file "file") as an option for
1481 the STDOUT buffer.
1482 (Fcall_process_region): Ditto.
1483
330d880c
EZ
14842011-04-30 Eli Zaretskii <eliz@gnu.org>
1485
8db90b73
EZ
1486 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1487 rather than `XVECTOR (FOO)->size'.
1488
330d880c
EZ
1489 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1490 inttypes.h, as a gnulib replacement is used if it not available in
1491 system headers.
1492
15cbd324
EZ
14932011-04-21 Eli Zaretskii <eliz@gnu.org>
1494
1495 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1496 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1497 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1498
1499 * coding.c (coding_alloc_by_realloc): Error out if destination
1500 will grow beyond MOST_POSITIVE_FIXNUM.
1501 (decode_coding_emacs_mule): Abort if there isn't enough place in
1502 charbuf for the composition carryover bytes. Reserve an extra
1503 space for up to 2 characters produced in a loop.
1504 (decode_coding_iso_2022): Abort if there isn't enough place in
1505 charbuf for the composition carryover bytes.
1506
15072011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1508
ae940cca
EZ
1509 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1510 aborting when %lld or %lll format is passed.
1511 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1512 %llo or %llx format is passed. (Bug#8545)
1513
03ab8921
EZ
1514 * window.c (window_scroll_line_based): Use a marker instead of
1515 simple variables to record original value of point. (Bug#7952)
1516
afda1437
EZ
1517 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1518 produced by %s or %c overflows available buffer space. (Bug#8545)
1519
f76dee0c
PE
15202011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1521
1522 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1523 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1524
fdc5744d
JB
15252011-04-28 Juanma Barranquero <lekktu@gmail.com>
1526
1527 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1528
638f053a
JB
15292011-04-28 Juanma Barranquero <lekktu@gmail.com>
1530
1531 * keyboard.c (Qdelayed_warnings_hook): Define.
1532 (command_loop_1): Run `delayed-warnings-hook'
1533 if Vdelayed_warnings_list is non-nil.
1534 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1535 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1536
d178f871
EZ
15372011-04-28 Eli Zaretskii <eliz@gnu.org>
1538
1539 * doprnt.c (doprnt): Don't return value smaller than the buffer
1540 size if the message was truncated. (Bug#8545).
1541
b124fd93
JB
15422011-04-28 Juanma Barranquero <lekktu@gmail.com>
1543
1544 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1545 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1546
e810457d
PE
15472011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1548
1549 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1550
ea51cceb
JB
15512011-04-27 Juanma Barranquero <lekktu@gmail.com>
1552
1553 * makefile.w32-in: Update dependencies.
1554
94dcfacf
EZ
15552011-04-27 Eli Zaretskii <eliz@gnu.org>
1556
1557 Improve `doprnt' and its usage. (Bug#8545)
1558 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1559 `format_end'. Remove support for %l as a conversion specifier.
1560 Don't use xrealloc. Improve diagnostics when the %l size modifier
1561 is used. Update the commentary.
1562
1563 * eval.c (verror): Simplify calculation of size_t.
1564
1565 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1566 messages.
1567
f61f41d7
PE
15682011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1569
1570 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1571 change.
1572
96fb4434
PE
15732011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1574
1575 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1576 This makes this file independent of the recent pseudovector change.
1577
671875da 15782011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1579
69e9b5a3
PE
1580 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1581
b5f869a7 1582 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1583 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1584 Remove unused local.
c8926152 1585 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1586
841a1577 1587 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1588 GCC 4.6.0 optimizes based on type-based alias analysis.
1589 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1590 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1591 != &v->size, and therefore "v->size = 1; b->size = 2; return
1592 v->size;" must therefore return 1. This assumption is incorrect
1593 for Emacs, since it type-puns struct Lisp_Vector * with many other
1594 types. To fix this problem, this patch adds a new type struct
f904488f 1595 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1596 and pseudovectors, and helps optimizing compilers not get fooled
1597 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1598 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1599 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1600 the size member.
eab3844f
PE
1601 (XSETPVECTYPE): Rewrite in terms of new macro.
1602 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1603 This is a bit clearer, and further avoids the possibility of
1604 undesirable aliasing.
1605 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1606 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1607 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1608 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1609 (ASIZE): Now uses header.size rather than size.
1610 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1611 to avoid the hassle of writing XVECTOR (foo)->header.size.
1612 (struct vectorlike_header): New type.
eab3844f
PE
1613 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1614 object, to help avoid aliasing.
1615 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1616 (SUBRP): Likewise, since Lisp_Subr is a special case.
1617 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1618 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1619 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1620 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1621 changed to be "header.size" and "header.next".
1622 * buffer.h (struct buffer): Likewise.
1623 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1624 * frame.h (struct frame): Likewise.
1625 * process.h (struct Lisp_Process): Likewise.
1626 * termhooks.h (struct terminal): Likewise.
1627 * window.c (struct save_window_data, struct saved_window): Likewise.
1628 * window.h (struct window): Likewise.
1629 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1630 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1631 * buffer.c (init_buffer_once): Likewise.
1632 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1633 special case.
1634 * process.c (Fformat_network_address): Use local var for size,
1635 for brevity.
1636
0df1eac5
PE
1637 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1638
847ab9d1 1639 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1640 * data.c (atof): Remove decl; no longer used or needed.
1641 (digit_to_number): Move to lread.c.
1642 (Fstring_to_number): Use new string_to_number function, to be
1643 consistent with how the Lisp reader treats infinities and NaNs.
1644 Do not assume that floating-point numbers represent EMACS_INT
1645 without losing information; this is not true on most 64-bit hosts.
1646 Avoid double-rounding errors, by insisting on integers when
1647 parsing non-base-10 numbers, as the documentation specifies.
1648 * lisp.h (string_to_number): New decl, replacing ...
1649 (isfloat_string): Remove.
bc0a5c13 1650 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1651 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1652 appears to have been a coding error. Similarly, do not accept
1653 strings like +-1e0 as floating point numbers. Do not report
1654 overflow for integer overflows unless the base is not 10 which
1655 means we have no simple and reliable way to continue.
1656 Break out the floating-point parsing into a new
1657 function string_to_number, so that Fstring_to_number parses
1658 floating point numbers consistently with the Lisp reader.
04f2d78b 1659 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1660 (E_CHAR, EXP_INT): Remove, replacing with ...
1661 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1662 (string_to_number): New function, replacing isfloat_string.
1663 This function checks for valid syntax and produces the resulting
1664 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1665 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1666 so that overflow for non-base-10 numbers is reported only when
1667 there's no portable and simple way to convert to floating point.
452f4150 1668
67769ffc
PE
1669 * textprop.c (set_text_properties_1): Rewrite for clarity,
1670 and to avoid GCC warning about integer overflow.
1671
c20db43f
PE
1672 * intervals.h (struct interval): Use EMACS_INT for members
1673 where EMACS_UINT might cause problems. See
1674 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1675 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1676 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1677 All uses changed.
37aa2f85
PE
1678 (offset_intervals): Tell GCC not to worry about length overflow
1679 when negating a negative length.
c20db43f 1680
2538aa2f
PE
1681 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1682 (overrun_check_free): Likewise.
1683
f2d3008d
PE
1684 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1685 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1686 word size.
1687
ec8df744
PE
1688 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1689 (gnutls_make_error): Rename local to avoid shadowing.
1690 (gnutls_emacs_global_deinit): ifdef out; not used.
1691 (Fgnutls_boot): Use const for pointer to readonly storage.
1692 Comment out unused local. Fix pointer signedness problems.
1693
640ee02d
PE
1694 * lread.c (openp): Don't stuff size_t into an 'int'.
1695 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1696 about possible signed overflow.
1697
6048fb2a
PE
1698 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1699 (GDK_KEY_g): Don't define if already defined.
1700 (xg_prepare_tooltip): Avoid pointer signedness problem.
1701 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1702
fa3c87e1
PE
1703 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1704 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1705
2172544b
PE
1706 * xfns.c (Fx_window_property): Simplify a bit,
1707 to make a bit faster and to avoid GCC 4.6.0 warning.
1708 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1709
9b821a21
PE
1710 * fns.c (internal_equal): Don't assume size_t fits in int.
1711
3c616cfa
PE
1712 * alloc.c (compact_small_strings): Tighten assertion a little.
1713
c2982e87
PE
1714 Replace pEd with more-general pI, and fix some printf arg casts.
1715 * lisp.h (pI): New macro, generalizing old pEd macro to other
1716 conversion specifiers. For example, use "...%"pI"d..." rather
1717 than "...%"pEd"...".
1718 (pEd): Remove. All uses replaced with similar uses of pI.
1719 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1720 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1721 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1722 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1723 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1724 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1725 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1726 64-bit hosts.
1727 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1728 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1729 * print.c (safe_debug_print, print_object): Likewise.
1730 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1731 to int.
6f04d126
PE
1732 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1733 avoiding the 0 flag, which is not portable.
c2982e87
PE
1734 * process.c (Fmake_network_process): Use pI to avoid cast.
1735 * region-cache.c (pp_cache): Likewise.
1736 * xdisp.c (decode_mode_spec): Likewise.
1737 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1738 behavior on 64-bit hosts with printf arg.
6f04d126 1739 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1740 (x_stop_queuing_selection_requests): Likewise.
1741 (x_get_window_property): Don't truncate byte count to an 'int'
1742 when tracing.
0b432f21 1743
5e073ec7
PE
1744 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1745 here, since it parses constructs like leading '-' and spaces,
1746 which are not wanted; and it overflows with large numbers.
1747 Instead, simply match F[0-9]+, which is what is wanted anyway.
1748
36372bf9
PE
1749 * alloc.c: Remove unportable assumptions about struct layout.
1750 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1751 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1752 (allocate_vectorlike, make_pure_vector): Use the new macros,
1753 plus offsetof, to remove unportable assumptions about struct layout.
1754 These assumptions hold on all porting targets that I know of, but
1755 they are not guaranteed, they're easy to remove, and removing them
1756 makes further changes easier.
1757
0b432f21
PE
1758 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1759 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1760 (string_overrun_cookie): Now const. Use initializers that
1761 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1762 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1763 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1764 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1765 multiple of sizeof (EMACS_INT); it need not be, if
1766 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1767 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1768
895009e1
JB
17692011-04-26 Juanma Barranquero <lekktu@gmail.com>
1770
1771 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1772
6a7a1b0b
TZ
17732011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1774
1775 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1776 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1777 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1778
841a1577 17792011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1780
1781 * lisp.h (Qdebug): List symbol.
895009e1 1782 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1783 * keyboard.c (debug-on-event): New variable.
1784 (handle_user_signal): Break into debugger when debug-on-event
1785 matches the current signal symbol.
1786
f2d3ba6f
DN
17872011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1788
1789 * alloc.c (check_sblock, check_string_bytes)
1790 (check_string_free_list): Convert to standard C.
1791
42ce4c63
TZ
17922011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1793
1794 * w32.c (emacs_gnutls_push): Fix typo.
1795
825cd63c
EZ
17962011-04-25 Eli Zaretskii <eliz@gnu.org>
1797
fb11d64d
EZ
1798 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1799 "cast to pointer from integer of different size".
1800
825cd63c
EZ
1801 Improve doprnt and its use in verror. (Bug#8545)
1802 * doprnt.c (doprnt): Document the set of format control sequences
1803 supported by the function. Use SAFE_ALLOCA instead of always
1804 using `alloca'.
1805
1806 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1807 is one byte too soon. Don't use xrealloc; instead xfree and
1808 xmalloc anew.
1809
e061a11b
TZ
18102011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1811
1812 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1813 callbacks stage.
1814
1815 * gnutls.c: Renamed global_initialized to
1816 gnutls_global_initialized. Added internals for the
1817 :verify-hostname-error, :verify-error, and :verify-flags
1818 parameters of `gnutls-boot' and documented those parameters in the
1819 docstring. Start callback support.
1820 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1821 unless a fatal error occured. Call gnutls_alert_send_appropriate
1822 on error. Return error code.
1823 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1824 (emacs_gnutls_read): Likewise.
1825 (Fgnutls_boot): Return handshake error code.
1826 (emacs_gnutls_handle_error): New function.
1827 (wsaerror_to_errno): Likewise.
1828
1829 * w32.h (emacs_gnutls_pull): Add prototype.
1830 (emacs_gnutls_push): Likewise.
1831
1832 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1833 (emacs_gnutls_push): Likewise.
1834
18352011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1836
1837 * process.c (wait_reading_process_output): Check if GnuTLS
1838 buffered some data internally if no FDs are set for TLS
1839 connections.
1840
1841 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1842 (LIBS): Link to USER_LIBS.
1843 ($(BLD)/gnutls.$(0)): New target.
1844
fa6996bc
EZ
18452011-04-24 Eli Zaretskii <eliz@gnu.org>
1846
eb35682e
EZ
1847 * xdisp.c (handle_single_display_spec): Rename the
1848 display_replaced_before_p argument into display_replaced_p, to
1849 make it consistent with the commentary. Fix typos in the
1850 commentary.
1851
e2ad650c
EZ
1852 * textprop.c (syms_of_textprop): Remove dead code.
1853 (copy_text_properties): Delete obsolete commentary about an
1854 interface that was deleted long ago. Fix typos in the description
1855 of arguments.
1856
1b2de274
EZ
1857 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1858 to changes in oldXMenu/XMenu.h from 2011-04-16.
1859 <menu_help_message, prev_menu_help_message>: Constify.
1860 (IT_menu_make_room): menu->help_text is now `const char **';
1861 adjust.
1862
1863 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1864 to changes in oldXMenu/XMenu.h from 2011-04-16.
1865 (struct XMenu): Declare `help_text' `const char **'.
1866
1867 * xfaces.c <Qunspecified>: Make extern again.
1868
1869 * syntax.c: Include sys/types.h before including regex.h, as
1870 required by Posix.
1871
762b15be
EZ
1872 * doc.c (get_doc_string): Improve the format passed to `error'.
1873
1874 * doprnt.c (doprnt): Improve commentary.
1875
1876 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1877
1878 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1879 them with etags.
1880
f1052e5d
EZ
1881 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1882 changes in globals.h immediately force recompilation.
762b15be
EZ
1883 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1884 $(CURDIR)/s/ms-w32.h.
1885 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1886
fa6996bc
EZ
1887 * character.c (Fchar_direction): Function deleted.
1888 (syms_of_character): Don't defsubr it.
1889 <char-direction-table>: Deleted.
1890
e6c3da20
EZ
18912011-04-23 Eli Zaretskii <eliz@gnu.org>
1892
1893 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1894 * doprnt.c: Include limits.h.
1895 (SIZE_MAX): New macro.
04f2d78b
CB
1896 (doprnt): Return a size_t value. 2nd arg is now size_t.
1897 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1898 Improve overflow protection. Support `l' modifier for integer
1899 conversions. Support %l conversion. Don't assume an EMACS_INT
1900 argument for integer conversions and for %c.
1901
1902 * lisp.h (doprnt): Restore prototype.
1903
1904 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1905 $(SRC)/character.h.
1906
1907 * Makefile.in (base_obj): Add back doprnt.o.
1908
1909 * deps.mk (doprnt.o): Add back prerequisites.
1910 (callint.o): Depend on character.h.
1911
1912 * eval.c (internal_lisp_condition_case): Include the handler
1913 representation in the error message.
1914 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1915 when breaking from the loop.
1916
1917 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1918
1919 * callint.c (Fcall_interactively): When displaying error message
1920 about invalid control letter, pass the character's codepoint, not
1921 a pointer to its multibyte form. Improve display of the character
1922 in octal and display also its hex code.
1923
1924 * character.c (char_string): Use %x to display the (unsigned)
1925 codepoint of an invalid character, to avoid displaying a bogus
1926 negative value.
1927
1928 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1929 `error', not SYMBOL_NAME itself.
1930
1931 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1932 character arguments to `error'.
1933
1934 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1935 to `error' in error message about FINAL_CHAR argument. Make sure
1936 FINAL_CHAR is a character, and use %c when it is passed as
1937 argument to `error'.
1938
4ffd0d6b 19392011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1940
1941 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1942
1943 * w32.c: Include <time.h>.
1944 (sys_localtime): New function.
1945
4ffd0d6b 19462011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1947
1948 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1949
4ffd0d6b 1950 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1951
4ffd0d6b 19522011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1953
4ffd0d6b
GM
1954 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1955 zombies (Bug#8467).
aac0c6e3 1956
04c56954
EZ
19572011-04-19 Eli Zaretskii <eliz@gnu.org>
1958
1959 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1960 gl_state.e_property when gl_state.object is Qt.
1961
1962 * insdel.c (make_gap_larger): Remove limitation of buffer size
1963 to <= INT_MAX.
1964
16a43933
CY
19652011-04-18 Chong Yidong <cyd@stupidchicken.com>
1966
1967 * xdisp.c (lookup_glyphless_char_display)
1968 (produce_glyphless_glyph): Handle cons cell entry in
1969 glyphless-char-display.
1970 (Vglyphless_char_display): Document it.
1971
1972 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1973 glyphless-char-display.
1974
4581706e
CY
19752011-04-17 Chong Yidong <cyd@stupidchicken.com>
1976
1977 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1978
1979 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1980
1981 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1982 definition for no-X builds.
1983
4887c6e2 19842011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1985
fd35b6f9
PE
1986 Static checks with GCC 4.6.0 and non-default toolkits.
1987
5c1ccb01
PE
1988 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1989
006c5daa
PE
1990 * process.c (keyboard_bit_set): Define only if SIGIO.
1991 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1992 (send_process): Repair possible setjmp clobbering.
1993
efc736d3
PE
1994 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1995
4e2fe2e6
PE
1996 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1997
f97334a2
PE
1998 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1999
4e75f29d
PE
2000 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2001 Define only if needed.
2002
90efadd1
PE
2003 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2004 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2005 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2006
3c647824
PE
2007 * dispextern.h (struct redisplay_interface): Rename param
2008 to avoid shadowing.
e264f262 2009 * termhooks.h (struct terminal): Likewise.
761383f4 2010 * xterm.c (xembed_send_message): Likewise.
3c647824 2011
b58c5c4a
PE
2012 * insdel.c (make_gap_smaller): Define only if
2013 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2014
cad59032
PE
2015 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2016 it.
2017
c339dc2e
PE
2018 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2019 so that we aren't warned about unused symbols.
2020
91a3e27b
PE
2021 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2022
399c71d3 2023 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2024
8ffc96f5
PE
2025 * xfns.c (x_real_positions): Mark locals as initialized.
2026
eef9bc79
PE
2027 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2028
098db9dd
PE
2029 * xterm.c: Fix problems found by static analysis with other toolkits.
2030 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2031 (x_dispatch_event): Declare static if USE_GTK, and
2032 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2033 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2034 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2035 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2036 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2037
eb18f6cc
PE
2038 * xmenu.c (menu_help_callback): Pointer type fixes.
2039 Use const pointers when pointing at readonly data. Avoid pointer
2040 signedness clashes.
2041 (FALSE): Remove unused macro.
2042 (update_frame_menubar): Remove unused decl.
2043
1fe72bf8
PE
2044 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2045
60d9e1db
PE
2046 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2047 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2048 (single_menu_item): Rename local to avoid shadowing.
2049
39261c26
PE
2050 * keyboard.c (make_lispy_event): Remove unused local var.
2051
018c5e19
PE
2052 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2053 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2054
63d2b86e
PE
2055 * bitmaps: Change bitmaps from unsigned char back to the X11
2056 compatible char. Avoid the old compiler warnings about
2057 out-of-range initializers by using, for example, '\xab' rather
2058 than 0xab.
2059
aefd87e1
PE
2060 * xgselect.c (xgselect_initialize): Check vs interface
2061 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2062
bf501fb9
PE
2063 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2064
e9829fdf
PE
2065 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2066 to read-only memory.
2067
1086c095
PE
2068 * fns.c (vector): Remove; this old hack is no longer needed.
2069
2baccd04 2070 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2071 Remove unused var.
dde42981 2072 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2073
72391843 2074 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2075
436c16df 2076 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2077 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2078 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2079
92bb796d 2080 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2081 (x_term_init): Remove local to avoid shadowing.
92bb796d 2082
764430a3 2083 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2084
2085 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2086 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2087
d1dfb56c
EZ
20882011-04-16 Eli Zaretskii <eliz@gnu.org>
2089
c4354cb4
EZ
2090 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2091
d1dfb56c
EZ
2092 Fix regex.c, syntax.c and friends for buffers > 2GB.
2093 * syntax.h (struct gl_state_s): Declare character position members
2094 EMACS_INT.
2095
2096 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2097
04f2d78b
CB
2098 * textprop.c (verify_interval_modification, interval_of):
2099 Declare arguments EMACS_INT.
d1dfb56c
EZ
2100
2101 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2102 EMACS_INT.
2103
2104 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2105
2106 * indent.c (Fvertical_motion): Local variable it_start is now
2107 EMACS_INT.
2108
2109 * regex.c (re_match, re_match_2, re_match_2_internal)
2110 (bcmp_translate, regcomp, regexec, print_double_string)
2111 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2112 (re_compile_pattern, re_exec): Declare arguments and local
2113 variables `size_t' and `ssize_t' and return values `regoff_t', as
2114 appropriate.
2115 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2116 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2117 <compile_stack_type>: `size' and `avail' are now `size_t'.
2118
2119 * regex.h <regoff_t>: Use ssize_t, not int.
2120 (re_search, re_search_2, re_match, re_match_2): Arguments that
2121 specify buffer/string position and length are now ssize_t and
2122 size_t. Return type is regoff_t.
2123
613052cd
BK
21242011-04-16 Ben Key <bkey76@gmail.com>
2125
2126 * nsfont.m: Fixed bugs in ns_get_family and
2127 ns_descriptor_to_entity that were caused by using free to
2128 deallocate memory blocks that were allocated by xmalloc (via
2129 xstrdup). This caused Emacs to crash when compiled with
2130 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2131 --enable-checking=xmallocoverrun). xfree is now used to
2132 deallocate these memory blocks.
2133
4170f62f 21342011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2135
71b41406
PE
2136 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2137
9587a89d
PE
2138 emacs_write: Accept and return EMACS_INT for sizes.
2139 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2140 et seq.
2141 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2142 Accept and return EMACS_INT.
2143 (emacs_gnutls_write): Return the number of bytes written on
2144 partial writes.
2145 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2146 (emacs_read, emacs_write): Remove check for negative size, as the
2147 Emacs source code has been audited now.
9587a89d
PE
2148 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2149 (emacs_read, emacs_write): Use it.
273a5f82
PE
2150 * process.c (send_process): Adjust to the new signatures of
2151 emacs_write and emacs_gnutls_write. Do not attempt to store
2152 a byte offset into an 'int'; it might overflow.
9587a89d 2153 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2154
3e047f51
PE
2155 * sound.c: Don't assume sizes fit in 'int'.
2156 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2157 Return EMACS_INT, not int.
3e047f51 2158 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2159 Accept EMACS_INT, not int.
2160 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2161 record read return values.
2162
cc39a9db
BK
21632011-04-15 Ben Key <bkey76@gmail.com>
2164
c9d0ec6d
JB
2165 * keyboard.c (Qundefined): Don't declare static since it is used
2166 in nsfns.m.
2167 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2168 static since they are used in nsfont.m.
cc39a9db 2169
6c60eb9f
SM
21702011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2171
2172 * process.c (Qprocessp): Don't declare static.
2173 * lisp.h (Qprocessp): Declare again.
2174
7990b61a
JB
21752011-04-15 Juanma Barranquero <lekktu@gmail.com>
2176
2177 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2178
5d4cb038
PE
21792011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2180
8bd7b830 2181 Improve C-level modularity by making more things 'static'.
cd64ea1d 2182
e3b27b31
PE
2183 Don't publish debugger-only interfaces to other modules.
2184 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2185 (verify_bytepos, count_markers): Move decls to the only modules
2186 that need them.
2187 * region-cache.h (pp_cache): Likewise.
2188 * window.h (check_all_windows): Likewise.
2189 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2190
5d4cb038
PE
2191 * sysdep.c (croak): Now static, if
2192 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2193 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2194
2195 * alloc.c (refill_memory_reserve): Now static if
2196 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2197 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2198
e87b6180
PE
2199 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2200 Define only if USE_LUCID.
2201
ac64929e
PE
2202 * xrdb.c (x_customization_string, x_rm_string): Now static.
2203
6f37259d
PE
2204 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2205 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2206
1683e3ab
PE
2207 * xdisp.c (draw_row_with_mouse_face): Now static.
2208 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2209
de9c2632
PE
2210 * window.h (check_all_windows): Mark externally visible.
2211
2b96acb7
PE
2212 * window.c (window_deletion_count): Now static.
2213
2214 * undo.c: Make symbols static if they're not exported.
2215 (last_undo_buffer, last_boundary_position, pending_boundary):
2216 Now static.
2217
50436f33
PE
2218 * textprop.c (interval_insert_behind_hooks): Now static.
2219 (interval_insert_in_front_hooks): Likewise.
2220
64520e5c
PE
2221 * term.c: Make symbols static if they're not exported.
2222 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2223 (max_frame_lines, tty_set_terminal_modes):
2224 (tty_reset_terminal_modes, tty_turn_off_highlight):
2225 (get_tty_terminal): Now static.
2226 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2227 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2228 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2229 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2230 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2231
1fa53021
PE
2232 * sysdep.c: Make symbols static if they're not exported.
2233 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2234 Now static.
2235 (sigprocmask_set, full_mask): Remove; unused.
2236 (wait_debugging): Mark as visible.
2237 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2238 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2239
d4b43b22
PE
2240 * syntax.c (syntax_temp): Define only if !__GNUC__.
2241
b7c513d0
PE
2242 * sound.c (current_sound_device, current_sound): Now static.
2243
989b29ad
PE
2244 * search.c (searchbufs, searchbuf_head): Now static.
2245
13a55a78
PE
2246 * scroll.c (scroll_cost): Remove; unused.
2247 * dispextern.h (scroll_cost): Remove decl.
2248
de68a1fc
PE
2249 * region-cache.h (pp_cache): Mark as externally visible.
2250
40ccffa6
PE
2251 * process.c: Make symbols static if they're not exported.
2252 (process_tick, update_tick, create_process, chan_process):
2253 (Vprocess_alist, proc_buffered_char, datagram_access):
2254 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2255 (deactivate_process): Mark defn as static, as well as decl.
2256 * lisp.h (create_process): Remove decl.
2257 * process.h (chan_process, Vprocess_alist): Remove decls.
2258
ad64fc97
PE
2259 * print.c: Make symbols static if they're not exported.
2260 (print_depth, new_backquote_output, being_printed, print_buffer):
2261 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2262 (print_interval, print_number_index, initial_stderr_stream):
2263 Now static.
2264 * lisp.h (Fprinc): Remove decl.
2265 (debug_output_compilation_hack): Mark as externally visible.
2266
adddb265
PE
2267 * sysdep.c (croak): Move decl from here to syssignal.h.
2268 * syssignal.h (croak): Put it here, so the API can be checked when
2269 'croak' is called from dissociate_if_controlling_tty.
2270
1717ede2
PE
2271 * minibuf.c: Make symbols static if they're not exported.
2272 (minibuf_save_list, choose_minibuf_frame): Now static.
2273 * lisp.h (choose_minibuf_frame): Remove decl.
2274
fa5fb2bc
PE
2275 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2276
1e3890d1
PE
2277 * lread.c: Make symbols static if they're not exported.
2278 (read_objects, initial_obarray, oblookup_last_bucket_number):
2279 Now static.
2280 (make_symbol): Remove; unused.
2281 * lisp.h (initial_obarray, make_symbol): Remove decls.
2282
8a1414fa
PE
2283 * keyboard.c: Make symbols static if they're not exported.
2284 (single_kboard, recent_keys_index, total_keys, recent_keys):
2285 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2286 (this_single_command_key_start, echoing, last_auto_save):
2287 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2288 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2289 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2290 (Vlispy_mouse_stem, double_click_count):
2291 Now static.
2292 (force_auto_save_soon): Define only if SIGDANGER.
2293 (ignore_mouse_drag_p): Now static if
2294 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2295 (print_help): Remove; unused.
2296 (stop_character, last_timer_event): Mark as externally visible.
2297 * keyboard.h (ignore_mouse_drag_p): Declare only if
2298 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2299 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2300 * lisp.h (echoing): Remove decl.
2301 (force_auto_save_soon): Declare only if SIGDANGER.
2302 * xdisp.c (redisplay_window): Simplify code, to make it more
2303 obvious that ignore_mouse_drag_p is not accessed if !defined
2304 USE_GTK && !defined HAVE_NS.
2305
93ea6e8f
PE
2306 * intervals.c: Make symbols static if they're not exported.
2307 (merge_properties_sticky, merge_interval_right, delete_interval):
2308 Now static.
2309 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2310
77382fcc
PE
2311 * insdel.c: Make symbols static if they're not exported.
2312 However, leave prepare_to_modify_buffer alone. It's never
2313 called from outside this function, but that appears to be a bug.
2314 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2315 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2316 (adjust_after_replace_noundo): Remove; unused.
2317 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2318 (signal_before_change): Remove decls.
77382fcc 2319
9306c32e
PE
2320 * indent.c (val_compute_motion, val_vmotion): Now static.
2321
cd44d2eb
PE
2322 * image.c: Make symbols static if they're not exported.
2323 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2324 if USE_GTK.
2325 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2326 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2327
ad9a7a06
PE
2328 * fringe.c (standard_bitmaps): Now static.
2329 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2330
81626931
PE
2331 * frame.c: Make symbols static if they're not exported.
2332 (x_report_frame_params, make_terminal_frame): Now static.
2333 (get_frame_param): Now static, unless HAVE_NS.
2334 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2335 (x_get_resource_string): Remove; not used.
2336 * frame.h (make_terminal_frame, x_report_frame_params):
2337 (x_get_resource_string); Remove decls.
2338 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2339 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2340
239f9db9
PE
2341 * font.c, fontset.c: Make symbols static if they're not exported.
2342 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2343 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2344 * font.c (font_close_object): Now static.
2345 * font.h (font_close_object): Remove.
2346 * fontset.c (FONTSET_OBJLIST): Remove.
2347 (free_realized_fontset) #if-0 the body, which does nothing.
2348 (face_suitable_for_char_p): #if-0, as it's never called.
2349 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2350 * xfaces.c (face_at_string_position):
2351 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2352 since 0 is always ASCII.
2353
dfcf3579
PE
2354 * fns.c (weak_hash_tables): Now static.
2355
5045092b
PE
2356 * fileio.c: Make symbols static if they're not exported.
2357 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2358 (Vwrite_region_annotation_buffers): Now static.
2359
57a96f5c
PE
2360 * eval.c: Make symbols static if they're not exported.
2361 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2362 * lisp.h (backtrace_list): Remove decl.
2363
35f08c38
PE
2364 * emacs.c: Make symbols static if they're not exported.
2365 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2366 (fatal_error_code, fatal_error_signal_hook, standard_args):
2367 Now static.
2368 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2369 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2370 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2371 * lisp.h (fatal_error_signal_hook): Remove decl.
2372 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2373
f44bd759
PE
2374 * editfns.c: Move a (normally-unused) function to its only use.
2375 * editfns.c, lisp.h (get_operating_system_release): Remove.
2376 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2377 worth the hassle of breaking this out.
2378
b532497d
PE
2379 * xterm.c: Make symbols static if they're not exported.
2380 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2381 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2382 (x_destroy_window, x_delete_display):
2383 Now static.
2384 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2385 (x_mouse_leave): Remove; unused.
2386 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2387 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2388 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2389 Remove decls.
2390 (x_mouse_leave): Declare only if WINDOWSNT.
2391 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2392 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2393 USE_X_TOOLKIT.
2394
1675728f
PE
2395 * ftxfont.c: Make symbols static if they're not exported.
2396 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2397 HAVE_FREETYPE.
2398 * font.h (ftxfont_driver): Likewise.
2399
e4cebfca
PE
2400 * xfns.c: Make symbols static if they're not exported.
2401 (x_last_font_name, x_display_info_for_name):
2402 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2403 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2404 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2405 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2406 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2407 (last_show_tip_args): Now static.
2408 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2409 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2410 (x_screen_planes): Remove; unused.
2411 * dispextern.h (x_screen_planes): Remove decl.
2412
5bf46f05
PE
2413 * dispnew.c: Make symbols static if they're not exported.
2414 * dispextern.h (redraw_garbaged_frames, scrolling):
2415 (increment_row_positions): Remove.
2416 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2417 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2418 Now static.
2419 (redraw_garbaged_frames): Remove; unused.
2420
435f4c28
PE
2421 * xfaces.c: Make symbols static if they're not exported.
2422 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2423 Remove decls.
2424 * xterm.h (defined_color): Remove decls.
2425 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2426 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2427 (menu_face_changed_default, defined_color, free_realized_face):
2428 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2429 (ascii_face_of_lisp_face): Remove; unused.
2430
8524aef3
PE
2431 * xdisp.c: Make symbols static if they're not exported.
2432 * dispextern.h (scratch_glyph_row, window_box_edges):
2433 (glyph_to_pixel_coords, set_cursor_from_row):
2434 (get_next_display_element, set_iterator_to_next):
2435 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2436 (show_mouse_face): Remove decls
2437 * frame.h (message_buf_print): Likewise.
2438 * lisp.h (pop_message, set_message, check_point_in_composition):
2439 Likewise.
2440 * xterm.h (set_vertical_scroll_bar): Likewise.
2441 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2442 (message_buf_print, scratch_glyph_row, displayed_buffer):
2443 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2444 (get_next_display_element, show_mouse_face, window_box_edges):
2445 (frame_to_window_pixel_xy, check_point_in_composition):
2446 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2447 (glyph_to_pixel_coords): Remove; unused.
2448
16390cd2
PE
2449 * dired.c (file_name_completion): Now static.
2450
2451 * dbusbind.c (xd_in_read_queued_messages): Now static.
2452
a25f4dfa
PE
2453 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2454 * data.c (circular_list_error): Remove.
2455
14a9c8df
PE
2456 * commands.h (last_point_position, last_point_position_buffer):
2457 (last_point_position_window): Remove decls.
2458 * keyboard.c: Make these variables static.
2459
04f2d78b
CB
2460 * coding.h (coding, code_convert_region, encode_coding_gap):
2461 Remove decls.
74ab6df5
PE
2462 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2463 (iso_code_class, detect_coding, code_convert_region): Now static.
2464 (encode_coding_gap): Remove; unused.
2465
38dfbee1
PE
2466 * chartab.c (chartab_chars, chartab_bits): Now static.
2467
a2cb4e63
PE
2468 * charset.h (charset_iso_8859_1): Remove decl.
2469 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2470 Now static.
2471
127198fd
PE
2472 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2473 * ccl.c (Vccl_program_table): Now static.
2474 (check_ccl_update): Remove; unused.
2475
d85b608f
PE
2476 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2477 * category.h: ... from here.
2478 * category.c (check_category_table, set_category_set): Now static.
2479
31cd66f3
PE
2480 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2481 * lisp.h: Remove these decls.
2482
c358e587
PE
2483 * buffer.c (buffer_count): Remove unused var.
2484
e78aecca
PE
2485 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2486 so that it's not optimized away.
2487 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2488 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2489 exported only to the debugger.
2490
e192d7d3 2491 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2492 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2493
92470028
PE
2494 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2495 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2496 was inaccessible from Lisp.
2497 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2498 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2499
244ed907
PE
2500 alloc.c: Import and export fewer symbols, and remove unused items.
2501 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2502 is defined.
2503 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2504 it's not optimized away by whole-program optimization.
2505 (message_enable_multibyte, free_misc): Remove.
2506 (catchlist, handlerlist, mark_backtrace):
2507 Declare only if BYTE_MARK_STACK.
2508 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2509 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2510 (message_enable_multibyte): Remove decl.
2511 (free_misc, interval_free_list, float_block, float_block_index):
2512 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2513 (cons_free_list, last_marked_index):
2514 Now static.
2515 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2516 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2517 (mark_backtrace): Define only if BYTE_MARK_STACK.
2518 * xdisp.c (message_enable_multibyte): Now static.
2519
61c2b50e 2520 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2521 This makes it easier for human readers (and static analyzers)
2522 to see whether these variables are used from other modules.
2523 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2524 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2525 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2526 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2527 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2528 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2529 * xmenu.c, xselect.c:
2530 Declare Q* vars static if they are not used in other modules.
2531 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2532 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2533 Remove decls of unexported vars.
2534 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2535
95c82688
PE
2536 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2537
16a97296
PE
2538 Make Emacs functions such as Fatom 'static' by default.
2539 This makes it easier for human readers (and static analyzers)
2540 to see whether these functions can be called from other modules.
2541 DEFUN now defines a static function. To make the function external
2542 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2543 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2544 (Finit_image_library):
16a97296
PE
2545 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2546 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2547 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2548 Remove decls, since these functions are now static.
2549 (Funintern, Fget_internal_run_time): New decls, since these functions
2550 were already external.
95c82688 2551
16a97296
PE
2552 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2553 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2554 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2555 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2556 * keyboard.c, keymap.c, lread.c:
2557 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2558 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2559 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2560 Mark functions with DEFUE instead of DEFUN,
2561 if they are used in other modules.
2562 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2563 decls for now-static functions.
2564 * buffer.h (Fdelete_overlay): Remove decl.
2565 * callproc.c (Fgetenv_internal): Mark as internal.
2566 * composite.c (Fremove_list_of_text_properties): Remove decl.
2567 (Fcomposition_get_gstring): New forward static decl.
2568 * composite.h (Fcomposite_get_gstring): Remove decl.
2569 * dired.c (Ffile_attributes): New forward static decl.
2570 * doc.c (Fdocumntation_property): New forward static decl.
2571 * eval.c (Ffetch_bytecode): New forward static decl.
2572 (Funintern): Remove extern decl; now in .h file where it belongs.
2573 * fileio.c (Fmake_symbolic_link): New forward static decl.
2574 * image.c (Finit_image_library): New forward static decl.
2575 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2576 * intervals.h (Fprevious_property_change):
2577 (Fremove_list_of_text_properties): Remove decls.
2578 * keyboard.c (Fthis_command_keys): Remove decl.
2579 (Fcommand_execute): New forward static decl.
2580 * keymap.c (Flookup_key): New forward static decl.
2581 (Fcopy_keymap): Now static.
2582 * keymap.h (Flookup_key): Remove decl.
2583 * process.c (Fget_process): New forward static decl.
2584 (Fprocess_datagram_address): Mark as internal.
2585 * syntax.c (Fsyntax_table_p): New forward static decl.
2586 (skip_chars): Remove duplicate decl.
2587 * textprop.c (Fprevious_property_change): New forward static decl.
2588 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2589 Now internal.
2590 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2591 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2592
785bbd42
PE
2593 * editfns.c (Fformat): Remove unreachable code.
2594
8b913b57
AS
25952011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2596
2597 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2598 change. (Bug#8496)
2599
a6744a35
EZ
26002011-04-13 Eli Zaretskii <eliz@gnu.org>
2601
2602 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2603 when at ZV. (Bug#8487)
2604
e7974947
AS
26052011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2606
baad03f0
AS
2607 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2608 (Bug#8437)
2609 * keyboard.c (parse_tool_bar_item): Likewise.
2610 * sound.c (sound_cleanup, alsa_close): Likewise.
2611 * termcap.c (tgetent): Likewise.
2612 * xfns.c (x_default_font_parameter): Likewise.
2613 * xsettings.c (read_and_apply_settings): Likewise.
2614
e7974947
AS
2615 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2616 (overrun_check_free): Protoize.
2617
28272684
PE
26182011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2619
2620 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2621 since callers should never pass a negative size.
2622 Change the signature to match that of plain 'read' and 'write'; see
2623 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2624 * lisp.h: Update prototypes of emacs_write and emacs_read.
2625
11997c76
EZ
26262011-04-11 Eli Zaretskii <eliz@gnu.org>
2627
2628 * xdisp.c (redisplay_window): Don't try to determine the character
2629 position of the scroll margin if the window start point w->startp
e896f03c 2630 is outside the buffer's accessible region. (Bug#8468)
11997c76 2631
8a2cbd72
EZ
26322011-04-10 Eli Zaretskii <eliz@gnu.org>
2633
2634 Fix write-region and its subroutines for buffers > 2GB.
2635 * fileio.c (a_write, e_write): Modify declaration of arguments and
2636 local variables to support buffers larger than 2GB.
2637 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2638
2639 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2640 argument, local variables, and return value.
2641
2642 * lisp.h: Update prototypes of emacs_write and emacs_read.
2643
2644 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2645
4073e537 26462011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2647
1ebfdcb6
PE
2648 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2649
b2ded58d
PE
2650 Fix more problems found by GCC 4.6.0's static checks.
2651
7d66342c
PE
2652 * xdisp.c (vmessage): Use a better test for character truncation.
2653
bbf47d44
PE
2654 * charset.c (load_charset_map): <, not <=, for optimization,
2655 and to avoid potential problems with integer overflow.
9248994d 2656 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2657 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2658 * editfns.c (Fformat): Likewise.
1e69125e 2659 * syntax.c (skip_chars): Likewise.
3befa583 2660
e3019616
PE
2661 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2662 This also lets GCC 4.6.0 generate slightly better loop code.
2663
becfa255
PE
2664 * callint.c (Fcall_interactively): <, not <=, for optimization.
2665 (Fcall_interactively): Count the number of arguments produced,
2666 not the number of arguments given. This is simpler and lets GCC
2667 4.6.0 generate slightly better code.
2668
dae0cd48
PE
2669 * ftfont.c: Distingish more carefully between FcChar8 and char.
2670 The previous code passed unsigned char * to a functions like
2671 strlen and xstrcasecmp that expect char *, which does not
2672 conform to the C standard.
2673 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2674 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2675 char * when the C standard requires it.
2676
76032d70
PE
2677 * keyboard.c (read_char): Remove unused var.
2678
eb3f1cc8
PE
2679 * eval.c: Port to Windows vsnprintf (Bug#8435).
2680 Include <limits.h>.
2681 (SIZE_MAX): Define if the headers do not.
2682 (verror): Do not give up if vsnprintf returns a negative count.
2683 Instead, grow the buffer. This ports to Windows vsnprintf, which
2684 does not conform to C99. Problem reported by Eli Zaretskii.
2685 Also, simplify the allocation scheme, by avoiding the need for
2686 calling realloc, and removing the ALLOCATED variable.
2687
70476b54
PE
2688 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2689
12020a9e
PE
2690 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2691 But keep the doprint source code for now, as we might revamp it
2692 and use it again (Bug#8435).
ea6c7ae6
PE
2693 * lisp.h (doprnt): Remove.
2694 * Makefile.in (base_obj): Remove doprnt.o.
2695 * deps.mk (doprnt.o): Remove.
2696
5fdb398c
PE
2697 error: Print 32- and 64-bit integers portably (Bug#8435).
2698 Without this change, on typical 64-bit hosts error ("...%d...", N)
2699 was used to print both 32- and 64-bit integers N, which relied on
2700 undefined behavior.
2701 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2702 New macro.
2703 * lisp.h (error, verror): Mark as printf-like functions.
2704 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2705 Report overflow in size calculations when allocating printf buffer.
2706 Do not truncate output string at its first null byte.
2707 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2708 Truncate the output at a character boundary, since vsnprintf does not
2709 do that.
2710 * charset.c (check_iso_charset_parameter): Convert internal
2711 character to string before calling 'error', since %c now has the
2712 printf meaning.
2713 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2714 overflow when computing char to be passed to 'error'. Do not
2715 pass Lisp_Object to 'error'; pass the integer instead.
2716 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2717 formatted with plain %d.
2718
b189fa66
PE
2719 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2720
bff87ef0
PE
2721 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2722
7e2cac20
PE
2723 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2724
ce4d90b5
PE
2725 * xterm.c (x_catch_errors): Remove duplicate declaration.
2726
266c9547
PE
2727 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2728
79c49ad2
PE
2729 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2730
368f4090
JM
27312011-04-10 Jim Meyering <meyering@redhat.com>
2732
2733 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2734 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2735 return ssize_t not "int", and use size_t as the buffer length.
2736 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2737 * gnutls.h: Update declarations.
2738 * process.c (read_process_output): Use ssize_t, to match.
2739 (send_process): Likewise.
2740
a32d4040
CY
27412011-04-09 Chong Yidong <cyd@stupidchicken.com>
2742
2743 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2744
8546720e 27452011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2746
04f2d78b
CB
2747 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2748 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2749
8546720e
GM
2750 * xterm.c (handle_one_xevent):
2751 * xmenu.c (create_and_show_popup_menu):
2752 * xselect.c (x_decline_selection_request)
2753 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2754
0a2f5c1a 27552011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2756
2757 Fix some uses of `int' instead of EMACS_INT.
2758 * search.c (string_match_1, fast_string_match)
2759 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2760 (scan_buffer, find_next_newline_no_quit)
2761 (find_before_next_newline, search_command, Freplace_match)
2762 (Fmatch_data): Make some `int' variables be EMACS_INT.
2763
2764 * xdisp.c (display_count_lines): 3rd argument and return value now
2765 EMACS_INT. All callers changed.
2766 (pint2hrstr): Last argument is now EMACS_INT.
2767
2768 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2769 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2770 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2771 (decode_coding_utf_16, decode_coding_emacs_mule)
2772 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2773 (decode_coding_ccl, decode_coding_charset)
2774 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2775 (decode_coding_iso_2022, decode_coding_emacs_mule)
2776 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2777 <char_offset, last_offset>: Declare EMACS_INT.
2778 (encode_coding_utf_8, encode_coding_utf_16)
2779 (encode_coding_emacs_mule, encode_invocation_designation)
2780 (encode_designation_at_bol, encode_coding_iso_2022)
2781 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2782 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2783 Declare EMACS_INT.
2784 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2785 (encode_invocation_designation): Last argument P_NCHARS is now
2786 EMACS_INT.
2787 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2788 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2789
2790 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2791 All users changed.
2792
2793 * ccl.c (Fccl_execute_on_string): Declare some variables
2794 EMACS_INT.
2795
8546720e 27962011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2797
2798 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2799
4e19a977
CS
28002011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2801
2802 * process.c (Fformat_network_address): Doc fix.
2803
87302331
R
28042011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2805
2806 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2807
cbb59342
CY
28082011-04-08 Chong Yidong <cyd@stupidchicken.com>
2809
2810 * keyboard.c (read_char): Call Lisp function help-form-show,
2811 instead of using internal_with_output_to_temp_buffer.
2812 (Qhelp_form_show): New var.
e0d38eeb 2813 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2814
2815 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2816
2817 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2818
e67a13ab
CY
28192011-04-06 Chong Yidong <cyd@stupidchicken.com>
2820
04f2d78b
CB
2821 * process.c (Flist_processes): Remove to Lisp.
2822 (list_processes_1): Delete.
e67a13ab 2823
973f782d
EZ
28242011-04-06 Eli Zaretskii <eliz@gnu.org>
2825
7c106b1e
EZ
2826 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2827
973f782d
EZ
2828 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2829
41cf7d1a 28302011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2831
ca23cc88
PE
2832 Fix more problems found by GCC 4.6.0's static checks.
2833
f390e2d5
PE
2834 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2835
42eea0d0
PE
2836 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2837
b69769da 2838 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2839
f9541e84
PE
2840 * xdisp.c (vmessage): Mark as a printf-like function.
2841
13841b55
PE
2842 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2843
c136c10f
PE
2844 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2845
5e2d4a30
PE
2846 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2847 printf-like functions.
2848 (tiff_load): Add casts to remove these marks before passing them
2849 to system-supplied API.
2850
583f48b9
PE
2851 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2852
b25d760e
PE
2853 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2854 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2855 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2856 directly, rather than having caller test rule sign. This avoids
2857 some unnecessary tests.
2858 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2859 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2860 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2861
bc7b6697 2862 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2863 (xfont_open): Avoid unnecessary tests.
bc7b6697 2864
27ccc379
PE
2865 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2866
dcd5c89a
PE
2867 * composite.h, composite.c (composition_gstring_put_cache):
2868 Use EMACS_INT, not int, for length.
2869
b13a45c6
PE
2870 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2871 breaking out part of COMPOSITION_DECODE_RULE.
2872 (COMPOSITION_DECODE_RULE): Use it.
2873 * composite.c (get_composition_id): Remove unused local vars,
2874 by using the new macro.
2875
1e792e4d
PE
2876 * textprop.c (set_text_properties_1): Change while to do-while,
2877 since the condition is always true at first.
2878
dc6c6455 2879 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2880 (interval_deletion_adjustment): Return unsigned value.
2881 All uses changed.
dc6c6455 2882
aba7731a
PE
2883 * process.c (list_processes_1, create_pty, read_process_output):
2884 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2885 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2886 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2887 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2888 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2889
fdfc4bf3
PE
2890 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2891
fca8fe46 2892 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2893 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2894
06a0259a 2895 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2896 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2897 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2898
e7b9e80f
PE
2899 * print.c (print_error_message): Avoid int overflow.
2900
56201685
PE
2901 * font.c (font_list_entities): Redo for clarity,
2902 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2903
78834453 2904 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2905 (font_score): Avoid potential overflow in diff calculation.
78834453 2906
0bc0b309 2907 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2908 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2909
e610eaca
PE
2910 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2911
b895abce
PE
2912 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2913 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2914 can always succeed if overflow has undefined behavior.
2915
1f1d9321 2916 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2917 (wordify): Omit three unnecessary tests.
1f1d9321 2918
c59478bc
PE
2919 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2920 All callers changed. This avoids the need for an unused var.
2921
79b73827
PE
2922 * casefiddle.c (casify_region): Remove var that is set but not used.
2923
a4db5dfe
PE
2924 * dired.c (file_name_completion): Remove var that is set but not used.
2925
43aae36e
PE
2926 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2927
2a47c44d 2928 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2929 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2930
a37c69bf
PE
2931 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2932 Check for integer overflow on size calculations.
2933
328ab8e7
PE
2934 * buffer.c (Fprevious_overlay_change): Remove var that is set
2935 but not used.
2936
e5a2a5cb
PE
2937 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2938 Remove vars that are set but not used.
8d84a6eb 2939 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2940 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2941
a60e5f68
PE
2942 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2943
f661cb61 2944 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2945 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2946
f0397f5a
PE
2947 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2948 that are set but not used.
2949
8664db06 2950 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2951 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2952
6abdaa4a
PE
2953 * xselect.c (x_get_local_selection, x_handle_property_notify):
2954 Remove vars that are set but not used.
2955
0ce7538d 2956 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2957 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2958
9ae848fc
PE
2959 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2960 Remove var that is set but not used.
0b918413
PE
2961 (scroll_bar_windows_size): Now size_t, not int.
2962 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2963 Check for overflow.
9ae848fc 2964
a5a62657
PE
2965 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2966 (map_tty_color) [!defined MSDOS]: Likewise.
2967
5c5cdd39
PE
2968 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2969
66ebf983
PE
2970 * coding.c: Remove vars that are set but not used.
2971 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2972 All callers changed.
2973 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2974 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2975 (decode_coding_charset): Remove vars that are set but not used.
2976
1be4d761
PE
2977 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2978 that is set but not used.
2979
47553fa8
PE
2980 * print.c (print_object): Remove var that is set but not used.
2981
1f7196bf 2982 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2983 The gnulib version avoids calling malloc in the usual case,
2984 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2985 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2986 * filelock.c (current_lock_owner): Likewise.
2987 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2988 * sysdep.c: Include allocator.h, careadlinkat.h.
2989 (emacs_no_realloc_allocator): New static constant.
2990 (emacs_readlink): New function.
fdb61804
PE
2991 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2992 ../lib/careadlinkat.h.
d1fdcab7 2993
f84c17c7
SM
29942011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2995
2996 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2997 first non-nil return value).
2998
ef3862ad
JD
29992011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3000
3001 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3002 if not defined (Bug#8403).
3003
376a7006
JB
30042011-04-02 Juanma Barranquero <lekktu@gmail.com>
3005
3006 * xdisp.c (display_count_lines): Remove parameter `start',
3007 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3008 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3009 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3010 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3011 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3012 and thereabouts. All callers changed.
3013 (get_per_char_metric): Remove parameter `f', unused since
3014 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3015
6ca3801d
JM
30162011-04-02 Jim Meyering <meyering@redhat.com>
3017
3018 do not dereference NULL upon failed strdup
3019 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3020 (ns_get_family): Likewise.
3021
d8e2b5ba
JB
30222011-04-02 Juanma Barranquero <lekktu@gmail.com>
3023
3024 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3025
8c74fcbd
JD
30262011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3027
3028 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3029 later (Bug#8403).
3030
7200d79c
SM
30312011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3032
03408648 3033 Add lexical binding.
7200d79c 3034
03408648
SM
3035 * window.c (Ftemp_output_buffer_show): New fun.
3036 (Fsave_window_excursion):
3037 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3038
3039 * lread.c (lisp_file_lexically_bound_p): New function.
3040 (Fload): Bind Qlexical_binding.
3041 (readevalloop): Remove `evalfun' arg.
3042 Bind Qinternal_interpreter_environment.
3043 (Feval_buffer): Bind Qlexical_binding.
3044 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3045 Mark as dynamic.
3046 (syms_of_lread): Declare `lexical-binding'.
3047
3048 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3049
3050 * keyboard.c (eval_dyn): New fun.
3051 (menu_item_eval_property): Use it.
ca105506
SM
3052
3053 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3054
03408648
SM
3055 * fns.c (concat, mapcar1): Accept byte-code-functions.
3056
3057 * eval.c (Fsetq): Handle lexical vars.
3058 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3059 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3060 (FletX, Flet): Obey lexical binding.
3061 (Fcommandp): Handle closures.
3062 (Feval): New `lexical' arg.
3063 (eval_sub): New function extracted from Feval. Use it almost
3064 everywhere where Feval was used. Look up vars in lexical env.
3065 Handle closures.
3066 (Ffunctionp): Move from subr.el.
3067 (Ffuncall): Handle closures.
3068 (apply_lambda): Remove `eval_flags'.
3069 (funcall_lambda): Handle closures and new byte-code-functions.
3070 (Fspecial_variable_p): New function.
3071 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3072 but without exporting it to Lisp.
23aba0ea 3073
23aba0ea 3074 * doc.c (Fdocumentation, store_function_docstring):
03408648 3075 * data.c (Finteractive_form): Handle closures.
23aba0ea 3076
03408648
SM
3077 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3078 interactive spec.
ba83908c 3079
04f2d78b
CB
3080 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3081 New byte-codes.
03408648
SM
3082 (exec_byte_code): New function extracted from Fbyte_code to handle new
3083 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3084
03408648 3085 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3086
03408648 3087 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3088
e2abce01
JB
30892011-03-31 Juanma Barranquero <lekktu@gmail.com>
3090
3091 * xdisp.c (redisplay_internal): Fix prototype.
3092
63696a73 30932011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3094
63696a73 3095 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3096 (try_scrolling): Use it when setting scroll_limit.
3097 Limit scrolling to 100 screen lines.
63696a73
EZ
3098 (redisplay_window): Even when falling back on "recentering",
3099 position point in the window according to scroll-conservatively,
3100 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3101
3102 (try_scrolling): When point is above the window, allow searching
3103 as far as scroll_max, or one screenful, to compute vertical
3104 distance from PT to the scroll margin position. This prevents
3105 try_scrolling from unnecessarily failing when
3106 scroll-conservatively is set to a value slightly larger than the
3107 window height. Clean up the case of PT below the margin at bottom
3108 of window: scroll_max can no longer be INT_MAX. When aggressive
3109 scrolling is in use, don't let point enter the opposite scroll
3110 margin as result of the scroll.
3111 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3112 threshold of 100 lines for never-recentering scrolling.
3113
e4cc2dfc
JB
31142011-03-31 Juanma Barranquero <lekktu@gmail.com>
3115
3116 * dispextern.h (move_it_by_lines):
3117 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3118 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3119 (message_log_check_duplicate): Remove parameters `prev_bol' and
3120 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3121 (redisplay_internal): Remove parameter `preserve_echo_area',
3122 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3123
3124 * indent.c (Fvertical_motion):
3125 * window.c (window_scroll_pixel_based, Frecenter):
3126 Don't pass `need_y_p' to `move_it_by_lines'.
3127
1c470562
SM
31282011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3129
44f230aa
SM
3130 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3131 steal a few bits to be more compact.
3132 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3133 Remove unneeded casts.
3134
1c470562
SM
3135 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3136
888adce9
ZK
31372011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3138
3139 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3140 binding" message (bug#7967).
3141
f838ed7b
PE
31422011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3143
77861b95
PE
3144 Fix more problems found by GCC 4.6.0's static checks.
3145
de6dbc14
PE
3146 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3147 Remove unused local var.
3148
f838ed7b
PE
3149 * editfns.c (Fmessage_box): Remove unused local var.
3150
792c7b2b
PE
3151 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3152 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3153 Omit unused local vars.
c499e557 3154 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3155 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3156 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3157 Omit unused local var.
3158
ba0165e1
PE
3159 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3160 Don't assume string length fits in int.
32ad8845 3161 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3162 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3163
3c59b4c9
PE
3164 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3165 instead of alloca (Bug#8344).
3166
a3eed478 3167 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3168 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3169
eb4d412d
PE
3170 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3171
1658b401
PE
3172 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3173 concerns.
3174
3175 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3176
3177 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3178
9a2c6e05
PE
3179 * keyboard.c (syms_of_keyboard): Use the same style as later
3180 in this function when indexing through an array. This also
3181 works around GCC bug 48267.
3182
03d0a109
PE
3183 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3184
44f730c8
PE
3185 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3186
fe75f926
PE
3187 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3188 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3189
ffa8c828
PE
3190 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3191 This avoids undefined behavior on integer overflow, and is a bit
3192 more convenient anyway since it is compared to a size_t variable.
3193
c5101a77
PE
3194 Variadic C functions now count arguments with size_t, not int.
3195 This avoids an unnecessary limitation on 64-bit machines, which
3196 caused (substring ...) to crash on large vectors (Bug#8344).
3197 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3198 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3199 All variadic functions and their callers changed accordingly.
c5101a77
PE
3200 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3201 * data.c (arith_driver, float_arith_driver): Likewise.
3202 * editfns.c (general_insert_function): Likewise.
3203 * eval.c (struct backtrace.nargs, interactive_p)
3204 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3205 (funcall_lambda, mark_backtrace): Likewise.
3206 * fns.c (concat): Likewise.
3207 * frame.c (x_set_frame_parameters): Likewise.
3208 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3209 0 if not found, not -1. All callers changed.
3210
dd3f25f7
PE
3211 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3212 (stack_copy_size): Now size_t, not int.
3213 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3214
461c2ab9
JB
32152011-03-28 Juanma Barranquero <lekktu@gmail.com>
3216
3217 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3218 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3219 All callers changed.
3220
3221 * lisp.h (multibyte_char_to_unibyte):
3222 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3223 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3224 * character.h (CHAR_TO_BYTE8):
3225 * cmds.c (internal_self_insert):
3226 * editfns.c (general_insert_function):
3227 * keymap.c (push_key_description):
3228 * search.c (Freplace_match):
3229 * xdisp.c (message_dolog, set_message_1): All callers changed.
3230
f6d62986
SM
32312011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3232
3233 * keyboard.c (safe_run_hook_funcall): New function.
3234 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3235 don't set the hook to nil, but remove the offending function instead.
3236 (Qcommand_hook_internal): Remove, unused.
3237 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3238 Vcommand_hook_internal.
3239
3240 * eval.c (enum run_hooks_condition): Remove.
3241 (funcall_nil, funcall_not): New functions.
3242 (run_hook_with_args): Call each function through a `funcall' argument.
3243 Remove `cond' argument, now redundant.
3244 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3245 (Frun_hook_with_args_until_failure): Adjust accordingly.
3246 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3247
1db5b1ad
JB
32482011-03-28 Juanma Barranquero <lekktu@gmail.com>
3249
3250 * dispextern.h (string_buffer_position): Remove declaration.
3251
3252 * print.c (strout): Remove parameter `multibyte', unused since
3253 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3254
3255 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3256 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3257 All callers changed.
3258
3259 * w32.c (_wsa_errlist): Use braces for struct initializers.
3260
3261 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3262 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3263 All callers changed.
3264 (string_buffer_position): Likewise. Also, make static (it's never
3265 used outside xdisp.c).
3266 (cursor_row_p): Remove parameter `w', unused since
3267 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3268 (decode_mode_spec): Remove parameter `precision', introduced during
3269 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3270 All callers changed.
3271
5ffb62aa
JD
32722011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3273
3274 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3275
461c2ab9 32762011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3277
3278 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3279 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3280 (ns_update_auto_hide_menu_bar): New functions.
3281 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3282 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3283 ns_constrain_all_frames.
3284 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3285 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3286
5c380ffb
JD
32872011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3288
3289 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3290
9af30bdf
GM
32912011-03-27 Glenn Morris <rgm@gnu.org>
3292
3293 * syssignal.h: Replace RETSIGTYPE with void.
3294 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3295 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3296 Replace SIGTYPE with void everywhere.
3297 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3298 * s/template.h (SIGTYPE): Remove commented out definition.
3299
e2abce01
JB
33002011-03-26 Eli Zaretskii <eliz@gnu.org>
3301
3302 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3303 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3304
f868cd8a
JB
33052011-03-26 Juanma Barranquero <lekktu@gmail.com>
3306
59eb0929
JB
3307 * w32.c (read_unc_volume): Use parameter `henum', instead of
3308 global variable `wget_enum_handle'.
3309
3310 * keymap.c (describe_vector): Remove parameters `indices' and
3311 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3312 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3313
f868cd8a
JB
3314 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3315
3316 * keyboard.c (timer_check): Remove parameter `do_it_now',
3317 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3318 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3319 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3320
3321 * keyboard.c (read_char):
3322 * w32menu.c (w32_menu_display_help):
3323 * xmenu.c (show_help_event, menu_help_callback):
3324 Adjust calls to `show_help_echo'.
3325
3326 * gtkutil.c (xg_maybe_add_timer):
3327 * keyboard.c (readable_events):
3328 * process.c (wait_reading_process_output):
3329 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3330
3331 * insdel.c (adjust_markers_gap_motion):
3332 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3333 (gap_left, gap_right): Don't call it.
3334
2ecf6fdb
CY
33352011-03-25 Chong Yidong <cyd@stupidchicken.com>
3336
3337 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3338 incurred during fontification.
3339
6b1f9ba4
JB
33402011-03-25 Juanma Barranquero <lekktu@gmail.com>
3341
3342 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3343 (DEFVAR_PER_BUFFER): Don't pass it.
3344
3345 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3346 (scrolling_window): Don't pass it.
3347
0f4a96b5
JB
33482011-03-25 Juanma Barranquero <lekktu@gmail.com>
3349
3350 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3351
3352 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3353 and `suffix'.
3354 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3355 of variables specific to SELinux and computation of `encoded_absname'.
3356
3357 * image.c (XPutPixel): Remove unused variable `height'.
3358
3359 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3360
3361 * unexw32.c (get_section_info): Remove unused variable `section'.
3362
3363 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3364 (system_process_attributes): Remove unused variable `sess'.
3365 (sys_read): Remove unused variable `err'.
3366
3367 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3368 (w32_wnd_proc): Remove unused variable `isdead'.
3369 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3370 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3371 (x_create_tip_frame): Remove unused variable `tem'.
3372
3373 * w32inevt.c (w32_console_read_socket):
3374 Remove unused variable `no_events'.
3375
3376 * w32term.c (x_draw_composite_glyph_string_foreground):
3377 Remove unused variable `width'.
3378
1149507c
JB
33792011-03-24 Juanma Barranquero <lekktu@gmail.com>
3380
3381 * w32term.c (x_set_glyph_string_clipping):
3382 Don't pass uninitialized region to CombineRgn.
3383
9c88f339
JB
33842011-03-23 Juanma Barranquero <lekktu@gmail.com>
3385
3386 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3387 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3388 (Fx_close_connection): Remove unused variable `i'.
3389
3390 * w32font.c (w32font_draw): Return number of glyphs.
3391 (w32font_open_internal): Remove unused variable `i'.
3392 (w32font_driver): Add missing initializer.
3393
3394 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3395 (fill_in_menu): Remove unused variable `items_added'.
3396
3397 * w32term.c (last_mouse_press_frame): Remove static global variable.
3398 (w32_clip_to_row): Remove unused variable `f'.
3399 (x_delete_terminal): Remove unused variable `i'.
3400
3401 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3402 (NOTHING): Remove unused static global variable.
3403 (uniscribe_check_otf): Remove unused variable `table'.
3404 (uniscribe_font_driver): Add missing initializers.
3405
dee091a3
JD
34062011-03-23 Julien Danjou <julien@danjou.info>
3407
3408 * term.c (Fsuspend_tty, Fresume_tty):
3409 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3410 * window.c (temp_output_buffer_show):
3411 * insdel.c (signal_before_change):
3412 * frame.c (Fhandle_switch_frame):
3413 * fileio.c (Fdo_auto_save):
3414 * emacs.c (Fkill_emacs):
3415 * editfns.c (save_excursion_restore):
3416 * cmds.c (internal_self_insert):
3417 * callint.c (Fcall_interactively):
3418 * buffer.c (Fkill_all_local_variables):
3419 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3420 Use Frun_hooks.
0f4a96b5 3421 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3422 unconditionnaly since it does the check itself.
3423
2c520ab5 34242011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3425
c9c49752
PE
3426 Fix more problems found by GCC 4.5.2's static checks.
3427
8abc3f12
PE
3428 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3429 the first time through the loop, since we know p0 < p1 then.
3430 This also avoids a gcc -Wstrict-overflow warning.
3431
a2d26660
PE
3432 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3433 leading to a memory leak, possible in functions like
3434 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3435 of objects (Bug#8318).
a2d26660 3436
916c72e9
PE
3437 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3438 that could (at least in theory) be that large.
3439
19ab8a18
PE
3440 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3441 This is less likely to overflow, and avoids undefined behavior if
3442 overflow does occur. All callers changed. Use strtoul to scan
3443 for the unsigned long integer.
b7cbbd6f
PE
3444 (pint2hrstr): Simplify and tune code slightly.
3445 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3446
f0641eff
PE
3447 * scroll.c (do_scrolling): Work around GCC bug 48228.
3448 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3449
7f650bb9
PE
3450 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3451 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3452 (validate_x_resource_name): Simplify count usage.
3453 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3454
37dd57d1
PE
3455 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3456 fail (Bug#8306).
81e56e61 3457
699979fc 3458 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3459
401bf9b4
PE
3460 * process.c (Fmake_network_process): Use socklen_t, not int,
3461 where POSIX says socklen_t is required in portable programs.
3462 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3463 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3464 (Fmake_network_process, server_accept_connection):
3465 (wait_reading_process_output, read_process_output):
3466 Likewise.
3467
b93aacde
PE
3468 * process.c: Rename or move locals to avoid shadowing.
3469 (list_processes_1, Fmake_network_process):
3470 (read_process_output_error_handler, exec_sentinel_error_handler):
3471 Rename or move locals.
4dc343ee 3472 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3473 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3474 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3475 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3476 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3477
af8a867c 3478 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3479 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3480 Include tparam.h instead, since it declares them.
af8a867c
PE
3481 * cm.h (PC): Remove extern decl; tparam.h now does this.
3482 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3483 * terminfo.c: Include tparam.h, to check interfaces.
3484 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3485 (tparam): Adjust signature to match interface in tparam.h;
3486 this removes some undefined behavior. Check that outstring and len
3487 are zero, which they always are with Emacs.
3488 * tparam.h (PC, BC, UP): New extern decls.
3489
0248044d 3490 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3491 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3492
8ff096c1 3493 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3494 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3495 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3496 (ftfont_list): Remove unused local.
49eaafba
PE
3497 (get_adstyle_property, ftfont_pattern_entity):
3498 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3499 Rename locals to avoid shadowing.
8ff096c1 3500
e2be39f6
PE
3501 * xfont.c (xfont_list_family): Mark var as initialized.
3502
c9735e30
PE
3503 * xml.c (make_dom): Now static.
3504
8f5201ae
PE
3505 * composite.c (composition_compute_stop_pos): Rename local to
3506 avoid shadowing.
b246f932
PE
3507 (composition_reseat_it): Remove unused locals.
3508 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3509 (composition_update_it): Mark var as initialized.
11b61122
PE
3510 (find_automatic_composition): Mark vars as initialized,
3511 with a FIXME (Bug#8290).
8f5201ae 3512
760fbc2c
PE
3513 character.h: Rename locals to avoid shadowing.
3514 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3515 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3516 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3517 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3518 to avoid shadowing.
3519
ff08eb85
PE
3520 * textprop.c (property_change_between_p): Remove; unused.
3521
fc7bf025
PE
3522 * intervals.c (interval_start_pos): Now static.
3523
235d7abc
PE
3524 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3525
44f230aa
SM
3526 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3527 Rename locals to avoid shadowing.
3e7d6594 3528
50060332
PE
3529 * sound.c (wav_play, au_play, Fplay_sound_internal):
3530 Fix pointer signedness.
d01f234b 3531 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3532 (wav_play): Initialize a variable to 0, to prevent undefined
3533 behavior (Bug#8278).
50060332 3534
c4fc4e30
PE
3535 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3536
918436ed
PE
3537 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3538
c939f91b
PE
3539 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3540 clobbering (Bug#8298).
b9c7f648
PE
3541 * sysdep.c (sys_subshell): Likewise.
3542 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3543
6bd8c144
PE
3544 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3545 This should get cleaned up, so that child_setup has the
3546 same signature on all platforms.
3547
7710357c 3548 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3549 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3550
c59da222
CY
35512011-03-22 Chong Yidong <cyd@stupidchicken.com>
3552
3553 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3554 not to be necessary, and produces flickering.
3555
66b87493
GM
35562011-03-20 Glenn Morris <rgm@gnu.org>
3557
3558 * config.in: Remove file.
3559
45b6f6d5
JB
35602011-03-20 Juanma Barranquero <lekktu@gmail.com>
3561
3562 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3563 are now in src/globals.h.
3564 (syms_of_minibuf): Remove spurious & from previous change.
3565
3ec03f7e
LL
35662011-03-20 Leo <sdl.web@gmail.com>
3567
3568 * minibuf.c (completing-read-function): New variable.
3569 (completing-read-default): Rename from completing-read.
3570 (completing-read): Call completing-read-function.
3571
b14e3e21
CY
35722011-03-19 Juanma Barranquero <lekktu@gmail.com>
3573
3574 * xfaces.c (Fx_load_color_file):
3575 Read color file from absolute filename (bug#8250).
3576
f2b726e6
JB
35772011-03-19 Juanma Barranquero <lekktu@gmail.com>
3578
3579 * makefile.w32-in: Update dependencies.
3580
09f6ff02
EZ
35812011-03-17 Eli Zaretskii <eliz@gnu.org>
3582
3583 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3584
29a6015a
PE
35852011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3586
a3a6c54e
PE
3587 Fix more problems found by GCC 4.5.2's static checks.
3588
b766f867
PE
3589 * process.c (make_serial_process_unwind, send_process_trap):
3590 (sigchld_handler): Now static.
3591
be02381c
PE
3592 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3593 That way, the code declares only the vars that it needs.
3594 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3595 * s/cygwin.h (PTY_ITERATION): Likewise.
3596 * s/darwin.h (PTY_ITERATION): Likewise.
3597 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3598
57048744
PE
3599 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3600 * process.c (allocate_pty): Don't declare stb unless it's needed.
3601
7914961c 3602 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3603 (CONSTANTLIM): Remove; unused.
3604 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3605 Define only if needed.
7914961c 3606
b3967b18
PE
3607 * unexelf.c (unexec): Name an expression,
3608 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3609 Use a different way to cause a compilation error if anyone uses
3610 n rather than nn, a way that does not involve shadowing.
73366a00 3611 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3612
29a6015a
PE
3613 * deps.mk (unexalpha.o): Remove; unused.
3614
43cfc33e 3615 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3616 * unexec.h: New file.
ce701a33
PE
3617 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3618 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3619 Depend on unexec.h.
3620 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3621 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3622 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3623 Change as necessary to match prototype in unexec.h.
ce701a33 3624
01f44d5a
PE
3625 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3626 shadowing.
4f63c6bb 3627 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3628
a6670b0b
PE
3629 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3630 Rename locals to avoid shadowing.
3631
cef2010d 3632 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3633 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3634
d4d7173a
PE
3635 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3636
f08b802a
PE
3637 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3638 warning when compiling print.c.
3639
3ddb0639
PE
3640 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3641 instead of using an uninitialized var.
5ad03b97 3642 (font_sort_entities): Mark var as initialized.
3ddb0639 3643
170a2692
PE
3644 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3645
e663c700
PE
3646 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3647 pointers to constants.
89bc529a 3648 (font_parse_fcname): Remove unused vars.
7b81e2d0 3649 (font_delete_unmatched): Now static.
ea838e10 3650 (font_get_spec): Remove; unused.
13a547c6
PE
3651 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3652 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3653 Rename or move locals to avoid shadowing.
e663c700 3654
2a80c887 3655 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3656 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3657
1384fa33 3658 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3659 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3660
8b2c52e9
PE
3661 * alloc.c (mark_backtrace): Move decl from here ...
3662 * lisp.h: ... to here, so that it can be checked.
3663
475545b5 3664 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3665 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3666 (lisp_indirect_variable): Name an expression,
3667 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3668 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3669
b1349114 3670 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3671 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3672 Use const pointer when appropriate.
b1349114 3673
a2928364
PE
3674 * lisp.h (get_system_name, get_operating_system_release):
3675 Move decls here, to check interfaces.
3676 * process.c (get_operating_system_release): Move decl to lisp.h.
3677 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3678 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3679 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3680 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3681 (Fformat_time_string, Fencode_time, Finsert_char):
3682 (Ftranslate_region_internal, Fformat):
3683 Rename or remove local vars to avoid shadowing.
9710023e 3684 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3685
a415e694
PE
3686 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3687 avoid shadowing.
3688
8ef4622d
PE
3689 * lisp.h (eassert): Check that the argument compiles, even if
3690 ENABLE_CHECKING is not defined.
3691
946f9a5b
PE
3692 * data.c (Findirect_variable): Name an expression, to avoid
3693 gcc -Wbad-function-cast warning.
112396d6 3694 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3695 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3696 (Fmake_variable_buffer_local, Fmake_local_variable):
3697 Mark variables as initialized.
52746918 3698 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3699
e5aab7e7 3700 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3701 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3702 Rename locals to avoid shadowing.
dff45157
PE
3703 (mark_stack): Move local variables into the #ifdef region where
3704 they're used.
7bc26fdb
PE
3705 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3706 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3707 needed otherwise.
3708 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3709 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3710 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3711
e5aab7e7
PE
3712 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3713 avoids undefined behavior in theory.
3714
4da60324
PE
3715 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3716
88043301
PE
3717 Use functions, not macros, for up- and down-casing (Bug#8254).
3718 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3719 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3720 to use the following functions instead of these macros.
3721 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3722 EMACS_INT, since callers assume the returned value fits in int.
3723 (upcase1): Likewise, for UPCASE_TABLE.
3724 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3725 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3726 the race-condition problem in the old DOWNCASE.
88043301 3727
19ed5445
PE
3728 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3729 Rename locals to avoid shadowing.
3730 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3731 (regex_compile, re_search_2, re_match_2_internal):
3732 Remove unused local vars.
952db0d7
PE
3733 (FREE_VAR): Rewrite so as not to use empty "else",
3734 which gcc can warn about.
da053e48 3735 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3736 (RETALLOC_IF): Define only if needed.
3737 (WORDCHAR_P): Likewise. This one is never needed, but is used
3738 only in a comment talking about a compiler bug, so put inside
3739 the #if 0 of that comment.
3740 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3741 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3742 Remove; unused.
19ed5445 3743
1f3561e4 3744 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3745 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3746 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3747
ded6f8f7
PE
3748 * search.c (simple_search): Remove unused var.
3749
dbd37a95
PE
3750 * dired.c (compile_pattern): Move decl from here ...
3751 * lisp.h: ... to here, so that it can be checked.
3752 (struct re_registers): New forward decl.
3753
7e47afad
PE
3754 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3755
85f24f61
PE
3756 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3757 All uses changed.
3758 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3759 Rename locals to avoid shadowing.
5671df8f 3760 (Fvertical_motion): Mark locals as initialized.
85f24f61 3761
181aa2be 3762 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3763 (casify_region): Mark local as initialized.
181aa2be 3764
930d429c
PE
3765 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3766
7082eac6
PE
3767 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3768 New macros, so that the caller can use some names other than
3769 gcpro1, gcpro2, etc.
3770 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3771 of the new macros.
3772 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3773 argument, for consistency with GCPRO2_VAR, etc: it is now the
3774 prefix of the variable, not the variable itself. All uses
3775 changed.
38b2c076
PE
3776 * dired.c (directory_files_internal, file_name_completion):
3777 Rename locals to avoid shadowing.
3778
15206ed9
PE
3779 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3780 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3781 dired.c's scmp function, had undefined behavior.
3782 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3783 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3784 * buffer.h: ... to here, because these macros use current_buffer,
3785 and the new implementation with inline functions needs to have
3786 current_buffer in scope now, rather than later when the macros
3787 are used.
3788 (downcase, upcase1): New static inline functions.
3789 (DOWNCASE, UPCASE1): Reimplement using these functions.
3790 This avoids undefined behavior in expressions like
3791 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3792 from race conditions in accessing the global variables
3793 case_temp1 and case_temp2.
3794 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3795 * lisp.h (case_temp1, case_temp2): Remove their decls.
3796 * character.h (ASCII_CHAR_P): Move from here ...
3797 * lisp.h: ... to here, so that the inline functions mentioned
3798 above can use them.
3799
4a6bea26
PE
3800 * dired.c (directory_files_internal_unwind): Now static.
3801
f14b7e14
PE
3802 * fileio.c (file_name_as_directory, directory_file_name):
3803 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3804 Now static.
2893f146
PE
3805 (file_name_as_directory): Use const pointers when appropriate.
3806 (Fexpand_file_name): Likewise. In particular, newdir might
3807 point at constant storage, so make it a const pointer.
fd4ead52 3808 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3809 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3810 signedness issues.
f839df0c
PE
3811 (Fset_file_times, Finsert_file_contents, auto_save_error):
3812 Rename locals to avoid shadowing.
f14b7e14 3813
5716756e 3814 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3815 (Ftry_completion, Fall_completions): Rename or remove locals
3816 to avoid shadowing.
5716756e 3817
b4c3046a
PE
3818 * marker.c (bytepos_to_charpos): Remove; unused.
3819
b45db522
PE
3820 * lisp.h (verify_bytepos, count_markers): New decls,
3821 so that gcc does not warn that these functions aren't declared.
3822
85876d07
PE
3823 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3824 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3825 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3826 (copy_text): Remove unused local var.
85876d07 3827
03d78a21 3828 * filelock.c (within_one_second): Now static.
b3dd38ab 3829 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3830
5df8f01b
PE
3831 * buffer.c (fix_overlays_before): Mark locals as initialized.
3832 (fix_start_end_in_overlays): Likewise. This function should be
3833 simplified by using pointers-to-pointers, but that's a different
3834 matter.
b1d876f1 3835 (switch_to_buffer_1): Now static.
8f54f30a
PE
3836 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3837 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3838
a70072c9 3839 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3840 Fix pointer signedness issue.
edced198
PE
3841 (sys_subshell): Mark local as volatile if checking for lint,
3842 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3843 (MAXPATHLEN): Define only if needed.
a70072c9 3844
a0977c44
PE
3845 * process.c (serial_open, serial_configure): Move decls from here ...
3846 * systty.h: ... to here, so that they can be checked.
3847
a884fdcc
PE
3848 * fns.c (get_random, seed_random): Move extern decls from here ...
3849 * lisp.h: ... to here, so that they can be checked.
3850
604efe86 3851 * sysdep.c (reset_io): Now static.
b8950c94 3852 (wait_for_termination_signal): Remove; unused.
604efe86 3853
38fc62d9
PE
3854 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3855 (copy_keymap_item, append_key, push_text_char_description):
3856 Now static.
1004a21a 3857 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3858 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3859 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3860 (describe_map_tree):
3861 Rename locals to avoid shadowing.
38fc62d9 3862
2f2650da
PE
3863 * keyboard.c: Declare functions static if they are not used elsewhere.
3864 (echo_char, echo_dash, cmd_error, top_level_2):
3865 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3866 (read_char, kbd_buffer_get_event, make_lispy_position):
3867 (make_lispy_event, make_lispy_movement, apply_modifiers):
3868 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3869 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3870 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3871 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3872 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3873
a053e86c 3874 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3875 (mark_kboards): Move decl here ...
3876 * alloc.c (mark_kboards): ... from here.
a053e86c 3877
4752793e
PE
3878 * lisp.h (force_auto_save_soon): New decl.
3879
74f10ca7 3880 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3881 (DEFINE_DUMMY_FUNCTION): New macro.
3882 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3883 Use it.
c03cd23f
PE
3884 (main): Add casts to avoid warnings
3885 if GCC considers string literals to be constants.
74f10ca7 3886
022e70d4
PE
3887 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3888
59d6fe83
PE
3889 * dbusbind.c: Pointer signedness fixes.
3890 (xd_signature, xd_append_arg, xd_initialize):
3891 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3892 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3893 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3894 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3895
78320123
PE
3896 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3897 if GCC considers string literals to be constants.
49cebcca 3898 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3899
35ac2a97
SM
39002011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3901
fb103ca9
SM
3902 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3903 (print_preprocess, print_object): New macro to fix last change.
3904
35ac2a97
SM
3905 * print.c (print_preprocess): Don't forget font objects.
3906
62973b41
JB
39072011-03-16 Juanma Barranquero <lekktu@gmail.com>
3908
3909 * emacs.c (USAGE3): Doc fixes.
3910
0e48bb22
AS
39112011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3912
3913 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3914 structure.
3915
7684e57b
JB
39162011-03-14 Juanma Barranquero <lekktu@gmail.com>
3917
3918 * lisp.h (VWindow_system, Qfile_name_history):
3919 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3920 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3921 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3922
3923 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3924 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3925
3926 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3927 * w32console.c (detect_input_pending, read_input_pending)
3928 (encode_terminal_code):
3929 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3930 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3931 (w32_system_caret_y, Qfile_name_history):
3932 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3933 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3934 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3935 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3936 * w32proc.c (Qlocal, report_file_error):
3937 * w32term.c (Vwindow_system, updating_frame):
3938 * w32uniscribe.c (initialized, uniscribe_font_driver):
3939 Remove unneeded extern declarations.
3940
2aa46d6c
CY
39412011-03-14 Chong Yidong <cyd@stupidchicken.com>
3942
c96bbc66 3943 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3944
cffc6f3b
CY
39452011-03-13 Chong Yidong <cyd@stupidchicken.com>
3946
3947 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3948 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3949 These macros can no longer be used for assignment.
3950
44f230aa
SM
3951 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3952 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3953 (record_buffer_markers, fetch_buffer_markers): New functions for
3954 recording and fetching special buffer markers.
3955 (set_buffer_internal_1, set_buffer_temp): Use them.
3956
3957 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3958
3959 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3960
3961 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3962 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3963
3964 * xdisp.c (hscroll_window_tree):
3965 (reconsider_clip_changes): Use PT instead of BUF_PT.
3966
d251f04b
EZ
39672011-03-13 Eli Zaretskii <eliz@gnu.org>
3968
3969 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3970 $(EMACS_ROOT)/lib/intprops.h.
3971
f0c77cd1
PE
39722011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3973
3eca4629
PE
3974 Fix more problems found by GCC 4.5.2's static checks.
3975
7c86ee98
PE
3976 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3977 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3978 (xg_free_frame_widgets): Make it clear that a local variable is
3979 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3980 (gdk_window_get_screen): Make it clear that this macro is needed
3981 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3982 (int_gtk_range_get_value): New function, which avoids a diagnostic
3983 from gcc -Wbad-function-cast.
3984 (xg_set_toolkit_scroll_bar_thumb): Use it.
3985 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3986 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3987 (get_utf8_string, xg_get_file_with_chooser):
3988 Rename locals to avoid shadowing.
3989 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3990
41729b81
PE
3991 * xgselect.c (xg_select): Remove unused var.
3992
f0c77cd1
PE
3993 * image.c (four_corners_best): Mark locals as initialized.
3994 (gif_load): Initialize transparent_p to zero (Bug#8238).
3995 Mark another local as initialized.
ec6cf4c6 3996 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3997
ce0ad53d 3998 * image.c (clear_image_cache): Now static.
d5d5a617 3999 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4000 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4001 (x_edge_detection): Remove unnecessary cast that
4002 gcc -Wbad-function-cast diagnoses.
2037898d 4003 (gif_load): Fix pointer signedness.
6ae141d6
PE
4004 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4005 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4006
33383987 40072011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4008
d32df629
PE
4009 Improve quality of tests for time stamp overflow.
4010 For example, without this patch (encode-time 0 0 0 1 1
4011 1152921504606846976) returns the obviously-bogus value (-948597
4012 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4013 reports time overflow. See
4014 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4015 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4016 * editfns.c: Include limits.h and intprops.h.
4017 (TIME_T_MIN, TIME_T_MAX): New macros.
4018 (time_overflow): Move earlier, to before first use.
4019 (hi_time, lo_time): New functions, for an accurate test for
4020 out-of-range times.
4021 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4022 (Fget_internal_run_time): Don't assume time_t fits in int.
4023 (make_time): Use list2 instead of Fcons twice.
4024 (Fdecode_time): More accurate test for out-of-range times.
4025 (check_tm_member): New function.
4026 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4027 (lisp_time_argument): Don't rely on undefined left-shift and
4028 right-shift behavior when checking for time stamp overflow.
8be6f318 4029
fe31d94c
PE
4030 * editfns.c (time_overflow): New function, refactoring common code.
4031 (Fformat_time_string, Fdecode_time, Fencode_time):
4032 (Fcurrent_time_string): Use it.
4033
8be6f318
PE
4034 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4035 * dired.c (make_time): Move to ...
4036 * editfns.c (make_time): ... here.
4037 * systime.h: Note the move.
4038
09d9db2c 40392011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4040
126bc0dc
YM
4041 * fringe.c (update_window_fringes): Remove unused variables.
4042
c47cbdfd
YM
4043 * unexmacosx.c (copy_data_segment): Also copy __got section.
4044 (Bug#8223)
4045
7ac80be9
EZ
40462011-03-12 Eli Zaretskii <eliz@gnu.org>
4047
c96bbc66 4048 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4049 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4050 Constify `char *' arguments and their references according to
4051 prototypes in tparam.h.
4052
ecb0f94d 4053 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4054
7ac80be9
EZ
4055 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4056 Adapt all references accordingly.
4057
4058 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4059
ef1fd07e
TT
40602011-03-11 Tom Tromey <tromey@redhat.com>
4061
4062 * buffer.c (syms_of_buffer): Remove obsolete comment.
4063
7ef4b50c
EZ
40642011-03-11 Eli Zaretskii <eliz@gnu.org>
4065
4066 * termhooks.h (encode_terminal_code): Declare prototype.
4067
4068 * msdos.c (encode_terminal_code): Don't declare prototype.
4069
4070 * term.c (encode_terminal_code): Now external again, used by
4071 w32console.c and msdos.c.
4072
44f230aa
SM
4073 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4074 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4075
4b1ec863 40762011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4077
1714f52b 4078 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4079
4b1ec863
PE
4080 * fringe.c (update_window_fringes): Mark locals as initialized
4081 (Bug#8227).
4082 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4083
524c7aa6
PE
4084 * alloc.c (mark_fringe_data): Move decl from here ...
4085 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4086 to check its interface.
4087 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4088
a5c0af81 4089 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4090 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4091 (fontset_font): Mark local as initialized.
a9a06e0b 4092 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4093
b4716021
PE
4094 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4095
811e9bac 4096 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4097 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4098 (x_own_selection, Fx_disown_selection_internal): Rename locals
4099 to avoid shadowing.
4100 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4101
7e3ab302
PE
4102 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4103 so that the caller can use some name other than gcpro1.
4104 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4105 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4106 (Fx_backspace_delete_keys_p):
4107 Use them to avoid shadowing, and rename vars to avoid shadowing.
4108 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4109 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4110 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4111 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4112 Remove unused locals.
7e3ab302
PE
4113 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4114 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4115 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4116 macros.
f78faa98 4117
e2b13473
PE
4118 * xterm.h (x_mouse_leave): New decl.
4119
77f23912
PE
4120 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4121 Remove unused functions.
cdf4ba58
PE
4122 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4123 (x_calc_absolute_position): Now static.
7411c686 4124 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4125 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4126 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4127 unless they are used.
38d0b34a
PE
4128 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4129 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4130 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4131 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4132 (x_error_catcher, x_connection_closed, x_error_handler):
4133 (x_error_quitter, xembed_send_message, x_iconify_frame):
4134 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4135 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4136 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4137
44f230aa
SM
4138 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4139 Rename or move locals to avoid shadowing.
6b463e58 4140 (tty_defined_color, merge_face_heights): Now static.
5967d051 4141 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4142 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4143 does not deduce is never used uninitialized.
73719eba
PE
4144 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4145 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4146
426994c3 4147 * terminal.c (store_terminal_param): Now static.
5489860b 4148
032f1620 4149 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4150 (set_frame_menubar): Remove unused local.
d4323972 4151 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4152 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4153 since they might point to immutable storage.
281585b0
PE
4154 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4155 since it's unused otherwise.
032f1620 4156
367c19e5 4157 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4158 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4159 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4160 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4161 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4162 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4163 does not deduce are never used uninitialized.
70739cbe 4164
07b48fa9
PE
4165 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4166
8868a238 4167 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4168 * window.c (window_loop, size_window):
4169 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4170
7e5cf297 4171 * window.c (display_buffer): Now static.
d6550a9f
PE
4172 (size_window): Mark variables that gcc -Wuninitialized
4173 does not deduce are never used uninitialized.
a586633d
PE
4174 * window.h (check_all_windows): New decl, to forestall
4175 gcc -Wmissing-prototypes diagnostic.
5b555da1 4176 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4177
f6095868
PE
4178 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4179 shadowing.
4180 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4181 Include <limits.h>.
4182 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4183 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4184 (load_charset_map): Mark variables that gcc -Wuninitialized
4185 does not deduce are never used uninitialized.
53df7c11 4186 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4187
f38b440c
PE
4188 * coding.c (coding_set_source, coding_set_destination):
4189 Use "else { /* comment */ }" rather than "else /* comment */;"
4190 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4191 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4192 a block, when the outer 'i' will do.
4193 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4194 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4195 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4196 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4197 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4198 Rename locals to avoid shadowing.
4199 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4200 * coding.c (emacs_mule_char, encode_invocation_designation):
4201 Now static, since they're not used elsewhere.
413bb2db 4202 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4203 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4204 (decode_coding_emacs_mule): Mark variables that gcc
4205 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4206 (detect_coding_iso_2022): Initialize a local variable that might
4207 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4208 this initialization is needed. (Bug#8211)
5f58e762
PE
4209 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4210 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4211 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4212 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4213 Remove unused macros.
f38b440c 4214
232b38b9 4215 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4216 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4217 * character.c (string_count_byte8): Likewise.
232b38b9 4218
fb90da1b
PE
4219 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4220 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4221
fb93dbc2
PE
4222 * chartab.c (copy_sub_char_table): Now static, since it's not used
4223 elsewhere.
5c156ace
PE
4224 (sub_char_table_ref_and_range, char_table_ref_and_range):
4225 Rename locals to avoid shadowing.
bbcd0949 4226 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4227
7d3b3862 4228 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4229 (BIDI_BOB): Remove unused macro.
7d3b3862 4230
6be7d3da
PE
4231 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4232 deduce are never used uninitialized.
c2ed9c8b 4233 * term.c (encode_terminal_code): Likewise.
6be7d3da 4234
75f8807f 4235 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4236
50938595
PE
4237 * tparam.h: New file.
4238 * term.c, tparam.h: Include it.
4239 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4240 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4241 Move these decls to tparam.h, and make them agree with what
4242 is actually in tparam.c. The previous trick of using incompatible
4243 decls in different modules does not conform to the C standard.
4244 All callers of tparam changed to use tparam's actual API.
4245 * tparam.c (tparam1, tparam, tgoto):
4246 Use const pointers where appropriate.
4247
fbceeba2
PE
4248 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4249 * cm.h (struct cm): Likewise.
4250 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4251 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4252 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4253 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4254 (turn_on_face, init_tty): Likewise.
4255 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4256
7f3f1250
PE
4257 * term.c (term_mouse_position): Rename local to avoid shadowing.
4258
e6ca6543
PE
4259 * alloc.c (mark_ttys): Move decl from here ...
4260 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4261
c40f8d15
AS
42622011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4263
4264 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4265
cfe0661d
JB
42662011-03-09 Juanma Barranquero <lekktu@gmail.com>
4267
4268 * search.c (compile_pattern_1): Remove argument regp, unused since
4269 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4270 (compile_pattern): Don't pass it.
4271
0afb4571
J
42722011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4273
4274 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4275 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4276 for ! HAVE_GTK3.
4277 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4278
4279 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4280
4281 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4282 gdk_window_get_screen, gdk_window_get_geometry,
4283 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4284 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4285 (xg_get_pixbuf_from_pixmap): New function.
4286 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4287 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4288 Call xg_get_pixbuf_from_pixmap instead of
4289 gdk_pixbuf_get_from_drawable.
4290 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4291 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4292 (xg_check_special_colors): Use GtkStyleContext and its functions
4293 for HAVE_GTK3.
4294 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4295 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4296 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4297 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4298 Call gtk_widget_get_preferred_size.
0afb4571
J
4299 (xg_frame_resized): gdk_window_get_geometry only takes 5
4300 parameters.
44f230aa
SM
4301 (xg_win_to_widget, xg_event_is_for_menubar):
4302 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4303 (xg_set_widget_bg): New function.
4304 (delete_cb): New function.
895009e1 4305 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4306 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4307 (xg_set_background_color): Call xg_set_widget_bg.
4308 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4309 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4310 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4311 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4312 if ! HAVE_GTK3.
4313 (update_frame_tool_bar): Call gtk_widget_hide.
4314 (xg_initialize): Use GDK_KEY_g.
4315
4316 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4317 if ! HAVE_GTK3
4318 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4319
4320 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4321 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4322 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4323
1c2cc4ef
JB
43242011-03-08 Juanma Barranquero <lekktu@gmail.com>
4325
4326 * w32xfns.c (select_palette): Check success of RealizePalette against
4327 GDI_ERROR, not zero.
4328
33383987 4329See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4330
4331;; Local Variables:
4332;; coding: utf-8
aac0c6e3
MR
4333;; End:
4334
33383987 4335 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4336
4337 This file is part of GNU Emacs.
4338
4339 GNU Emacs is free software: you can redistribute it and/or modify
4340 it under the terms of the GNU General Public License as published by
4341 the Free Software Foundation, either version 3 of the License, or
4342 (at your option) any later version.
4343
4344 GNU Emacs is distributed in the hope that it will be useful,
4345 but WITHOUT ANY WARRANTY; without even the implied warranty of
4346 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4347 GNU General Public License for more details.
4348
4349 You should have received a copy of the GNU General Public License
4350 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.