* net/tramp-sh.el (tramp-remote-path): Set tramp-autoload cookie.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c85efaf7
EZ
12012-01-14 Eli Zaretskii <eliz@gnu.org>
2
3 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4 thrashing the stack of the thread. (Bug#9087)
5
5944709e
PE
62012-01-12 Paul Eggert <eggert@cs.ucla.edu>
7
8 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
9
e71f5d99
EZ
102012-01-11 Eli Zaretskii <eliz@gnu.org>
11
12 * xdisp.c (rows_from_pos_range): Handle the case where the
13 highlight ends on a newline. (Bug#10464)
14 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
15 he end column for display of highlight that ends on a newline
16 before a R2L line.
17
ce316182
GM
182012-01-11 Glenn Morris <rgm@gnu.org>
19
20 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
21 from load-path also when installation-directory is nil. (Bug#10208)
22
5b43da69
GM
232012-01-10 Glenn Morris <rgm@gnu.org>
24
74cc8ff9
GM
25 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
26
7d8d6e4e
GM
27 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
28 Update template values to be closer to their typical values these days.
5b43da69 29
a0db8d43
EZ
302012-01-09 Eli Zaretskii <eliz@gnu.org>
31
32 * xdisp.c (rows_from_pos_range): Accept additional argument
33 DISP_STRING, and accept any glyph in a row whose object is that
34 string as eligible for mouse highlight. Fixes mouse highlight of
35 display strings from overlays. (Bug#10464)
36
9a0115ab 372012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 38
b9110d6a 39 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
40 * fileio.c (auto_saving_dir_umask): New static var.
41 (Fmake_directory_internal): Use it.
42 (do_auto_save_make_dir): Set it, instead of invoking chmod after
43 creating the directory. The old code temporarily assigns
44 too-generous permissions to the directory.
45 (do_auto_save_eh): Clear it.
b9110d6a 46 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
47 that the var is always cleared.
48
6c1bd3f3
EZ
492012-01-07 Eli Zaretskii <eliz@gnu.org>
50
51 * search.c (scan_buffer): Pass character positions to
52 know_region_cache, not byte positions. (Bug#6540)
53
069d2b50
L
542012-01-07 LynX <_LynX@bk.ru> (tiny change)
55
56 * w32.c (sys_rename): Report EXDEV when rename of a directory
57 fails because the target is on another logical disk. (Bug#10284)
58
75bf0d33
DB
592012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
60
61 * xterm.c (x_embed_request_focus): New function.
62
63 * xterm.h: Add prototype.
64
65 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
66
1c6e5a32
GM
672012-01-05 Glenn Morris <rgm@gnu.org>
68
69 * emacs.c (emacs_copyright): Update short copyright year to 2012.
70
651e947e
EZ
712012-01-01 Eli Zaretskii <eliz@gnu.org>
72
73 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
74 Load gnutls_transport_set_lowat only if GnuTLS version is below
75 2.11.1.
76 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
77 GnuTLS versions below 2.11.1.
78
3778cdd8
AL
792011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
80
81 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
82 to the doc string advising against its use for altering the way
83 windows are scrolled.
84
0e5317f7
KH
852011-12-28 Kenichi Handa <handa@m17n.org>
86
87 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
88 coding-system ASCII compatible only when it does not produce BOM
89 on encoding (Bug#10383).
90
93d5ca1f
JD
912011-12-26 Jan Djärv <jan.h.d@swipnet.se>
92
93 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
94 can scroll.
95 (create_and_show_popup_menu): Always use menu_position_func for
96 Gtk3 (Bug#10361).
97
ca22b785
AS
982011-12-24 Andreas Schwab <schwab@linux-m68k.org>
99
100 * callint.c (Fcall_interactively): Don't truncate prompt string.
101
d048e1e6
EZ
1022011-12-23 Eli Zaretskii <eliz@gnu.org>
103
104 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
105 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 106 resumed from there (after widening). (Bug#10360)
d048e1e6 107
5ccaba1f
JD
1082011-12-22 Jan Djärv <jan.h.d@swipnet.se>
109
110 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
111
204ee57f
JD
1122011-12-21 Jan Djärv <jan.h.d@swipnet.se>
113
b81d40f0
JB
114 * nsterm.m (x_free_frame_resources):
115 Release f->output_data.ns->miniimage.
204ee57f
JD
116 (ns_index_color): Fix indentation. Do not retain
117 color_table->colors[i].
118
119 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
120 before returning.
121
122 * nsfns.m (x_set_background_color): Assign return value from
123 ns_index_color to face-background instead of NSColor*.
124 (ns_implicitly_set_icon_type): Fix indentation.
125 Change assignment in for loop to comparison.
126
127 * emacs.c (ns_pool): New variable.
128 (main): Assign ns_pool.
129 (Fkill_emacs): Call ns_release_autorelease_pool.
130
131 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
132 autorelease fdesc, release fdAttrs and tdict.
133 (ns_get_covering_families): Release charset.
134 (ns_findfonts): Release NSFontDescriptor created with new.
135 (ns_uni_to_glyphs): Fix indentation.
136 (setString): Release attrStr before assigning new value.
137
c803b2b7
JD
1382011-12-18 Jan Djärv <jan.h.d@swipnet.se>
139
678f4426
JD
140 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
141 and NS_IMPL_COCOA.
142 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
143 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
144
cd394be1 1452011-12-18 David Reitter <reitter@cmu.edu>
678f4426 146
5fecd5fc
JD
147 * nsterm.m (ns_term_init): Subscribe for notifications
148 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
149 to method trackingNotification in EmacsMenu.
150
151 * nsmenu.m (trackingMenu): New variable.
3771cb17 152 (trackingNotification): New method (from Aquamacs).
5fecd5fc 153 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 154 from Aquamacs (Bug#7030).
678f4426
JD
155
1562011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 157
c803b2b7
JD
158 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
159 (symbol_to_nsstring): Fix indentation.
160 (ns_symbol_to_pb): New function.
161 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
162 (Fns_rotate_cut_buffers_internal): Removed.
163 (Fns_store_selection_internal): Renamed from
164 Fns_store_cut_buffer_internal.
165 (ns_get_foreign_selection, Fx_own_selection_internal)
166 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
167 (Fns_get_selection_internal, Fns_store_selection_internal):
168 Use ns_symbol_to_pb and check if return value is nil.
169 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
170 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
171 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
172 renamed to Sns_store_selection_internal.
173 (ns_handle_selection_request): Move code to Fx_own_selection_internal
174 and remove this function.
175 (ns_handle_selection_clear): Remove, never used.
176 (Fx_own_selection_internal): Move code from ns_handle_selection_request
177 here.
178
e1b01a3a
KB
1792011-12-17 Ken Brown <kbrown@cornell.edu>
180
181 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
182 GID is unknown (Bug#10257).
183
2adb6e85
PE
1842011-12-17 Paul Eggert <eggert@cs.ucla.edu>
185
186 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
187 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
188 which caused a build failure on GNU/Linux IA-64. This problem was
189 introduced by my 2011-10-07 patch.
190
d1d7b339
JL
1912011-12-15 Juri Linkov <juri@jurta.org>
192
193 * image.c (imagemagick_error): New function. (Bug#10112)
194 (imagemagick_load_image): Comment out `MagickSetResolution' call.
195 Use `imagemagick_error' where ImageMagick functions return
196 `MagickFalse'.
197 (Fimagemagick_types): Add `Fnreverse' to return the list in the
198 proper order.
199
100d5755
KH
2002011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
201
202 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
203 fill background (Bug#8992).
204
454592a6
MR
2052011-12-13 Martin Rudalics <rudalics@gmx.at>
206
207 * window.c (Vwindow_combination_resize)
208 (Vwindow_combination_limit): Use t instead of non-nil in
209 doc-strings.
61d4b438
MR
210 (Vrecenter_redisplay): Add first sentence of doc-string on
211 separate line.
53524d93 212 (Frecenter): Fix doc-string typo.
454592a6 213
3633e3aa
KH
2142011-12-11 Kenichi Handa <handa@m17n.org>
215
216 * coding.c (Funencodable_char_position): Pay attention to the
217 buffer text relocation (Bug#9389).
218
7b9d523a
JD
2192011-12-10 Jan Djärv <jan.h.d@swipnet.se>
220
221 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
222 gtk_init (Bug#10100).
223
b73189c6
EZ
2242011-12-10 Eli Zaretskii <eliz@gnu.org>
225
226 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
227 IT->string is nil. (Bug#10263)
228
f7dfe5d6
JD
2292011-12-10 Jan Djärv <jan.h.d@swipnet.se>
230
83faebb4
JD
231 * nsterm.h (x_free_frame_resources): Declare.
232
f7dfe5d6
JD
233 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
234 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
235
236 * nsterm.h (ns_get_defaults_value): Declare.
237
238 * nsterm.m (ns_default): Call ns_get_defaults_value.
239
7cd4e72c
EZ
2402011-12-09 Eli Zaretskii <eliz@gnu.org>
241
242 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
243 (Bug#10170)
244
b34d7317
YM
2452011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
246
247 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
248 that where the value of an _OBJC_* symbol points to is in the .bss
249 section (Bug#10240).
250
76470ad1
KH
2512011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
252
253 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 254 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 255
745fff94
KH
2562011-12-08 Kenichi Handa <handa@m17n.org>
257
258 * ftfont.c (get_adstyle_property): Fix previous change
259 (Bug#10233).
260
6e44397c
JB
2612011-12-07 Juanma Barranquero <lekktu@gmail.com>
262
263 * w32.c (init_environment): If no_site_lisp, remove site-lisp
264 dirs from the default value of EMACSLOADPATH (bug#10208).
265
7efa6272
GM
2662011-12-07 Glenn Morris <rgm@gnu.org>
267
268 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
269 installation and source directories as well. (Bug#10208)
270
f6fc4d87
CY
2712011-12-06 Chong Yidong <cyd@gnu.org>
272
273 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
274
2bf26180
GM
2752011-12-06 Glenn Morris <rgm@gnu.org>
276
277 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
278 as an error, not just -1. (Bug#10217)
279
3a6ad4f0
CY
2802011-12-05 Chong Yidong <cyd@gnu.org>
281
282 * keyboard.c (process_special_events): New function.
283 (swallow_events, Finput_pending_p): Use it (Bug#10195).
284
75a3b399
PE
2852011-12-05 Paul Eggert <eggert@cs.ucla.edu>
286
287 * coding.c (encode_designation_at_bol): Don't use uninitialized
288 local variable (Bug#9318).
289
c3c9e25e
KH
2902011-12-05 Kenichi Handa <handa@m17n.org>
291
292 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
293 return Qnil (Bug#8046, Bug#10193).
294
5eb05ea3
KH
2952011-12-05 Kenichi Handa <handa@m17n.org>
296
297 * coding.c (encode_designation_at_bol): New args charbuf_end and
298 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
299 (coding_set_source): Return how many bytes coding->source was
300 relocated.
301 (coding_set_destination): Return how many bytes
302 coding->destination was relocated.
303 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
304 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
305
3062011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
307
308 * coding.c (CODING_CHAR_CHARSET_P): New macro.
309 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
310 macro (Bug#9318).
311
3122011-12-05 Andreas Schwab <schwab@linux-m68k.org>
313
314 The following changes are to fix Bug#9318.
315
a79703f5 316 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
317 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
318 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 319 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 320
7dbda6df
JB
3212011-12-05 Juanma Barranquero <lekktu@gmail.com>
322
323 * lisp.h (process_quit_flag): Fix external declaration.
324
6d5eb5b0
SM
3252011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
326
327 Don't macro-inline non-performance-critical code.
328 * eval.c (process_quit_flag): New function.
329 * lisp.h (QUIT): Use it.
330
a0c3fad0
JD
3312011-12-04 Jan Djärv <jan.h.d@swipnet.se>
332
333 * nsfns.m (get_geometry_from_preferences): New function.
334 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
335
6c07aac2
AS
3362011-12-04 Andreas Schwab <schwab@linux-m68k.org>
337
338 * emacs.c (Qkill_emacs): Define.
339 (syms_of_emacs): Initialize it.
340 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
341 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
342 (quit_throw_to_read_char): Add parameter `from_signal'.
343 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
344 * lisp.h (QUIT): Call Fkill_emacs if requested.
345
c052ead4
JD
3462011-12-03 Jan Djärv <jan.h.d@swipnet.se>
347
348 * widget.c (update_wm_hints): Return if wmshell is null.
349 (widget_update_wm_size_hints): New function.
350
351 * widget.h (widget_update_wm_size_hints): Declare.
352
353 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
354 widget_update_wm_size_hints (Bug#10104).
355
9e49252b
EZ
3562011-12-03 Eli Zaretskii <eliz@gnu.org>
357
358 * xdisp.c (handle_invisible_prop): If the invisible text ends just
359 before a newline, prepare the bidi iterator for consuming the
360 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 361 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 362
02b16839
JL
3632011-12-02 Juri Linkov <juri@jurta.org>
364
365 * search.c (Fword_search_regexp): New Lisp function created from
366 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
367 (Fword_search_backward, Fword_search_forward)
368 (Fword_search_backward_lax, Fword_search_forward_lax):
369 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
370 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
371
0068070e
SM
3722011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
373
374 * fileio.c (Finsert_file_contents): Move after-change-function call
375 to before the "handled:" label, since all "goto handled" appear in
376 cases where the *-change-functions have already been properly called
377 (bug#10117).
378
3360a3fc
AS
3792011-12-01 Andreas Schwab <schwab@linux-m68k.org>
380
381 * keyboard.c (interrupt_signal): Don't call kill-emacs when
382 waiting for input. (Bug#10169)
383
73d6c093
EZ
3842011-11-30 Eli Zaretskii <eliz@gnu.org>
385
386 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
387 verifies glyph row's hash code--we have just reallocated the
388 glyphs, so their contents can be complete garbage. (Bug#10164)
389
febe6bea
JB
3902011-11-30 Juanma Barranquero <lekktu@gmail.com>
391
392 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
393
801a4313
EZ
3942011-11-30 Eli Zaretskii <eliz@gnu.org>
395
396 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
397 attributes are tested _before_ calling verify_row_hash, to protect
398 against GCC re-ordering of the tests. (Bug#10164)
399
2b56b87e
JD
4002011-11-29 Jan Djärv <jan.h.d@swipnet.se>
401
402 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
403
404 * xterm.c (handle_one_xevent): Only set async_visible and friends
405 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 406 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
407 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
408
dbf31225
PE
4092011-11-28 Paul Eggert <eggert@cs.ucla.edu>
410
411 Remove GCPRO-related macros that exist only to avoid shadowing locals.
412 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
413 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
414 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
415 All uses changed to use GCPRO1 etc.
416 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
417 Revert to old implementation (i.e., before 2011-03-11).
418
1305621b
YM
4192011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
420
421 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
422 of scroll runs so as to avoid assigning disabled bogus rows and
423 unnecessary graphics copy operations.
424
8c9afb46
EZ
4252011-11-27 Eli Zaretskii <eliz@gnu.org>
426
427 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
428 (snprintf) [_MSC_VER]: Redirect to _snprintf.
429 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
430 (malloc, free, realloc, calloc): Redirect to e_* only when
431 compiling Emacs.
432
433 * lisp.h (GCTYPEBITS): Move before first use.
434 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
435 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
436 this macro definition.
437
438 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
439 _MSC_VER.
440
54e9e3bf
JD
4412011-11-27 Jan Djärv <jan.h.d@swipnet.se>
442
6d5eb5b0
SM
443 * gtkutil.c (xg_create_frame_widgets):
444 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
445 present with Gtk+ 2.0.
446
83aca1cb
PE
4472011-11-26 Paul Eggert <eggert@cs.ucla.edu>
448
449 * fileio.c (Finsert_file_contents): Undo previous change; see
450 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
451
5b76caa4
PE
4522011-11-26 Paul Eggert <eggert@cs.ucla.edu>
453
454 Rename locals to avoid shadowing.
455 * fileio.c (Finsert_file_contents):
456 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
457 * process.c (wait_reading_process_output):
458 Rename inner 'proc' to 'p' to avoid shadowing.
459 Indent for consistency with usual Emacs style.
460
8c535114
EZ
4612011-11-25 Eli Zaretskii <eliz@gnu.org>
462
463 * xdisp.c (redisplay_window): If cursor row is not fully visible
464 after recentering, and scroll-conservatively is set to a large
465 number, scroll window by a few more lines to make the cursor fully
466 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
467 (start_display): Don't move to the next line if the display should
468 start at a newline that is part of a display vector or an overlay
469 string. (Bug#10119)
8c535114 470
fa4fdb5c
JL
4712011-11-24 Juri Linkov <juri@jurta.org>
472
473 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
474 after the `MagickPingImage' call. (Bug#10112)
475
90ec88df
CY
4762011-11-23 Chong Yidong <cyd@gnu.org>
477
478 * window.c (Fcoordinates_in_window_p): Accept only live windows.
479
56e2e794
MR
4802011-11-23 Martin Rudalics <rudalics@gmx.at>
481
482 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
483 making another buffer current. (Bug#10114)
484
b6e64c41
GM
4852011-11-23 Glenn Morris <rgm@gnu.org>
486
487 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
488
6b21de18
CY
4892011-11-23 Chong Yidong <cyd@gnu.org>
490
491 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
492 using it (Bug#5984).
493
b12cd789
EZ
4942011-11-22 Eli Zaretskii <eliz@gnu.org>
495
496 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
497 and header-lines, as they don't have one computed for them.
498 (Bug#10098)
499
500 * .gdbinit (prow): Make displayed values more self-explaining.
501 Add row's hash code.
502
261b6fd4
LMI
5032011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
504
505 * process.c (wait_reading_process_output): Fix asynchrounous
506 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 507 (wait_reading_process_output): Add comment and URL.
261b6fd4 508
e7cfd277
JD
5092011-11-21 Jan Djärv <jan.h.d@swipnet.se>
510
511 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
512
a9b9b7f5
CY
5132011-11-21 Chong Yidong <cyd@gnu.org>
514
515 * window.c (Fnext_window, Fprevious_window): Doc fix.
516
b0d15b4f
SM
5172011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
518
519 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
520
fe7a3057
JB
5212011-11-20 Juanma Barranquero <lekktu@gmail.com>
522
523 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
524
d2999b1a
MR
5252011-11-20 Martin Rudalics <rudalics@gmx.at>
526
527 * window.c (Fset_window_combination_limit): Rename argument
528 STATUS to LIMIT.
529 (Vwindow_combination_limit): Remove "status" from doc-string.
530
d5ff9cd0
AS
5312011-11-20 Andreas Schwab <schwab@linux-m68k.org>
532
533 * m/ibms390.h: Remove.
534 * m/ibms390x.h: Don't include "ibms390.h".
535
a5bb9bd3
SM
5362011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
537
538 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
539 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
540
cd1181db
JB
5412011-11-20 Juanma Barranquero <lekktu@gmail.com>
542
543 * casetab.c (Fset_case_table):
544 * charset.c (Fcharset_after): Fix typos.
545
615a3b8d 5462011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 547
17e845af
PE
548 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
549 Otherwise, valgrind does not work on some platforms.
550 Problem reported by Andreas Schwab in
6a0bf43d
PE
551 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
552 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
553 is set, removing the need for VIRT_ADDRESS_VARIES.
554 (PURE_P): Use a more-efficient implementation that needs just one
555 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
556 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
557 to 4 (xorl, subq, cmpq, setbe).
558 * alloc.c (pure): Always extern now, since that's the
559 VIRT_ADDR_VARIES behavior.
560 (PURE_POINTER_P): Use a single comparison, not two, for
561 consistency with the new puresize.h.
562 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
563 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
564 Remove VIRT_ADDR_VARIES no longer needed.
565
f8fe6f96
EZ
5662011-11-19 Eli Zaretskii <eliz@gnu.org>
567
568 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
569 (erase_phys_cursor, update_window_cursor, show_mouse_face)
570 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
571 behave as if the cursor position were at the window margin.
572
573 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
574 and the cursor position is out of bounds, behave as if the cursor
575 position were at the window margin. (Bug#10075)
576
df05a53c
CY
5772011-11-18 Chong Yidong <cyd@gnu.org>
578
579 * window.c (Fwindow_combination_limit): Make first argument
580 non-optional, since it is meaningless for live windows like the
581 selected window.
582
2071918e
DA
5832011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
584
585 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
586
b50a28de
SM
5872011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
588
589 * intervals.c: Fix grafting over the whole buffer (bug#10071).
590 (graft_intervals_into_buffer): Simplify.
591
015137db
EZ
5922011-11-18 Eli Zaretskii <eliz@gnu.org>
593
594 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
595 hash values of the two rows.
596 (copy_row_except_pointers): Preserve the used[] arrays and the
597 hash values of the two rows. (Bug#10035)
68c95424 598 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
599
600 * xdisp.c (row_hash): New function, body extracted from
601 compute_line_metrics.
602 (compute_line_metrics): Call row_hash, instead of computing the
603 hash code inline.
604
605 * dispnew.c (verify_row_hash): Call row_hash for computing the
606 hash code of a row, instead of duplicating code from xdisp.c.
607
608 * dispextern.h (row_hash): Add prototype.
609
a2addb04
TH
6102011-11-18 Tassilo Horn <tassilo@member.fsf.org>
611
612 * frame.c (delete_frame): Don't delete the terminal when the last
613 X frame is closed if emacs is built with GTK toolkit.
614
df85d315
JB
6152011-11-17 Juanma Barranquero <lekktu@gmail.com>
616
617 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
618
a0c2d0ae
MR
6192011-11-17 Martin Rudalics <rudalics@gmx.at>
620
621 * window.c (Vwindow_splits): Rename to
622 Vwindow_combination_resize. Suggested by Juri Linkov.
623 (Fsplit_window_internal): Use Vwindow_combination_resize instead
624 of Vwindow_splits.
625
58179cce
JB
6262011-11-16 Juanma Barranquero <lekktu@gmail.com>
627
7877f373
JB
628 * nsfns.m (Fns_font_name):
629 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 630
b6f67890
MR
6312011-11-16 Martin Rudalics <rudalics@gmx.at>
632
633 * window.h (window): Rename slot "nest" to "combination_limit".
634 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
635 (Fset_window_nest): Rename to Fset_window_combination_limit.
636 (Vwindow_nest): Rename to Vwindow_combination_limit.
637 (recombine_windows, make_parent_window, make_window)
638 (Fsplit_window_internal, saved_window)
639 (Fset_window_configuration, save_window_save): Rename all
640 occurrences of window_nest to window_combination_limit.
641
c7015153
JB
6422011-11-15 Juanma Barranquero <lekktu@gmail.com>
643
644 * image.c (imagemagick_load_image): Fix typo.
645
322ad6ec
EZ
6462011-11-14 Eli Zaretskii <eliz@gnu.org>
647
648 * xdisp.c (display_line): Move the call to
649 highlight_trailing_whitespace before the call to
650 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
651 faces of all the glyphs to compute ROW's hash value.
652 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 653
f067b8ec
JB
6542011-11-14 Juanma Barranquero <lekktu@gmail.com>
655
656 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
657 just return (bug#10044).
658
1e5b2111
EZ
6592011-11-12 Eli Zaretskii <eliz@gnu.org>
660
7ef3cbd5
EZ
661 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
662 with user-defined heap size. Bump the default size of the temacs
663 heap to 27MB, to avoid memory warning when running temacs.
664 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
665
1e5b2111
EZ
666 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
667 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
668 (verify_row_hash) [XASSERTS]: New function.
669 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
670 that the hash value of glyph rows is correct.
1e5b2111 671
89d61221
MR
6722011-11-12 Martin Rudalics <rudalics@gmx.at>
673
674 * window.h (window): Remove splits slot.
675 * window.c (Fwindow_splits, Fset_window_splits): Remove.
676 (Fdelete_other_windows_internal, make_parent_window)
677 (make_window, Fsplit_window_internal, Fdelete_window_internal)
678 (Fset_window_configuration, save_window_save): Don't deal with
679 split status of windows.
680 (saved_window): Remove splits slot.
681 (Vwindow_splits): Rewrite doc-string.
682
97f18cc8
JD
6832011-11-11 Jan Djärv <jan.h.d@swipnet.se>
684
685 * xfns.c (unwind_create_frame):
686 * nsfns.m (unwind_create_frame):
687 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
688 Vframe_list (Bug#9999).
689
22a648b4
DA
6902011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
691
0b381c7e 692 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 693
659afede
KH
6942011-11-11 Kenichi Handa <handa@m17n.org>
695
696 * callproc.c (Fcall_process): Set the member dst_multibyte of
697 process_coding.
698
9ac0394b
KH
6992011-11-11 Johan Bockgård <bojohan@gnu.org>
700
701 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
702 avoid a crash (bug#9496).
703
2fbdc249
CY
7042011-11-09 Chong Yidong <cyd@gnu.org>
705
706 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
707 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
708
ac6b1f81
PE
7092011-11-08 Paul Eggert <eggert@cs.ucla.edu>
710
711 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
712
09db192c
PE
7132011-11-08 Paul Eggert <eggert@cs.ucla.edu>
714
715 Avoid some portability problems by eschewing 'extern inline' functions.
716 The trivial performance wins aren't worth the portability hassles; see
717 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
718 et seq.
719 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
720 (window_box_width, window_box_left, window_box_left_offset)
721 (window_box_right, window_box_right_offset): Undo previous change,
722 by removing the "extern"s.
723 * intervals.c (adjust_intervals_for_insertion)
724 (adjust_intervals_for_deletion): Undo previous change,
725 making these static again.
726 (offset_intervals, temp_set_point_both, temp_set_point)
727 (copy_intervals_to_string): No longer inline.
728 * xdisp.c (window_text_bottom_y, window_box_width)
729 (window_box_height, window_box_left_offset)
730 (window_box_right_offset, window_box_left, window_box_right)
731 (window_box): No longer inline.
732
105216ed
CY
7332011-11-08 Chong Yidong <cyd@gnu.org>
734
735 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
736 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
737 Signal an error if not a live window.
105216ed
CY
738 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
739 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
740
ae9e237f
JB
7412011-11-07 Juanma Barranquero <lekktu@gmail.com>
742
743 * lisp.h (syms_of_abbrev): Remove declaration.
744 Reported by CHENG Gao <chenggao@royau.me>.
745
c7aa8333
EZ
7462011-11-07 Eli Zaretskii <eliz@gnu.org>
747
748 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
749 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
750 of temacs in GUI mode.
751
be7f5545
MR
7522011-11-07 Martin Rudalics <rudalics@gmx.at>
753
754 * window.h: Declare delete_all_child_windows instead of
755 delete_all_subwindows.
756 * window.c (Fwindow_nest, Fset_window_nest)
757 (Fset_window_new_total, Fset_window_new_normal)
758 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
759 (delete_all_subwindows): Rename to delete_all_child_windows.
760 (Fdelete_other_windows_internal, Fset_window_configuration):
761 Call delete_all_child_windows instead of delete_all_subwindows.
762 * frame.c (delete_frame): Call delete_all_child_windows instead
763 of delete_all_subwindows.
764
ca78dc43
PE
7652011-11-07 Paul Eggert <eggert@cs.ucla.edu>
766
767 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
768 This is also needed for porting to any host where GC_MARK_STACK is
769 not GC_MAKE_GCPROS_NOOPS.
770 (which_symbols): Use it.
771
a0241d01
KH
7722011-11-07 Kenichi Handa <handa@m17n.org>
773
774 * coding.c (coding_set_destination): Check coding->src_pos only
775 when coding->src_object is a buffer (bug#9910).
776
777 * process.c (send_process): Set the member src_multibyte of coding
778 to 0 (bug#9911) when sending a unibyte text.
779
780 * callproc.c (Fcall_process): Set the member src_multibyte of
781 process_coding to 0 (bug#9912).
782
a64bfdfa 7832011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
784
785 * xmenu.c (cleanup_widget_value_tree): New function.
786 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
787 calling free_menubar_widget_value_tree directly (Bug#9830).
788
cb41b32a
PE
7892011-11-06 Paul Eggert <eggert@cs.ucla.edu>
790
791 Fix some portability problems with 'inline'.
792 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
793 (window_box_width, window_box_left, window_box_left_offset)
794 (window_box_right, window_box_right_offset): Declare extern.
795 Otherwise, these inline functions do not conform to C99 and
796 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
797 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
798 * intervals.c (adjust_intervals_for_insertion)
799 (adjust_intervals_for_deletion): Now extern, because otherwise the
800 extern inline functions 'offset_intervals' couldn't refer to it.
801 (static_offset_intervals): Remove.
802 (offset_intervals): Rewrite using the old contents of
803 static_offset_intervals. The old version didn't conform to C99
804 because an extern inline function contained a reference to an
805 identifier with static linkage.
806
b7041366
AS
8072011-11-06 Andreas Schwab <schwab@linux-m68k.org>
808
809 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
810 GC.
811
88a37c4d
EZ
8122011-11-06 Eli Zaretskii <eliz@gnu.org>
813
814 * xdisp.c (init_iterator, reseat_to_string): Don't set the
815 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
816 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
817 return Qleft_to_right.
818
49745b39
CY
8192011-11-06 Chong Yidong <cyd@gnu.org>
820
821 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
822 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
823 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
824 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
825 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
826 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
827 (Fwindow_vscroll): Doc fix.
828 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
829 argument, since it makes no sense to pass a live window and for
830 consistency with window-child.
831
1f05cd82
CS
8322011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
833
834 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
835 support MSVC.
836
22610910
JR
8372011-11-05 Jason Rumney <jasonr@gnu.org>
838
839 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
840 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
841 fonts (Bug#6029).
842 (add_font_entity_to_list): Fix logic errors in mixed boolean and
843 bitwise arithmetic preventing use of unicode-sip and non-truetype
844 opentype fonts.
845
a06776b2
EZ
8462011-11-05 Eli Zaretskii <eliz@gnu.org>
847
3ad924ba
EZ
848 * s/ms-w32.h (fstat, stat, utime): Move redirections to
849 "emacs"-only part.
850
a06776b2
EZ
851 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
852 initialization code to keep similarity to xfns.c after changes
853 from 2011-11-05.
854
c9e7db78
JD
8552011-11-05 Jan Djärv <jan.h.d@swipnet.se>
856
a97f8f3f
JD
857 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
858 (unwind_create_frame): New function (Bug#9943).
859 (Fx_create_frame): Restructure code to be more similar to the one in
860 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
861 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
862 Move terminal->reference_count++ just before making the frame official
863 (Bug#9943).
864
865 * nsterm.m (x_free_frame_resources): New function.
866 (x_destroy_window): Move code to x_free_frame_resources.
867
c9e7db78 868 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
869 (Fx_create_frame, x_create_tip_frame):
870 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
871 official. Move initialization of image_cache_refcount and
872 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
873
a6fc3b5c
EZ
8742011-11-05 Eli Zaretskii <eliz@gnu.org>
875
876 Support MSVC build with newer versions of Visual Studio.
877 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
878 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
879 nt/gmake.defs.
880
881 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
882 which are not supported by MSVC.
883 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
884 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
885 bitfields.
886 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
887 types in bitfields.
888 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
889
890 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
891
58179cce 8922011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
893
894 Support MSVC build with newer versions of Visual Studio.
895 * w32.c: Don't include w32api.h for MSVC.
896 (init_environment) [_MSC_VER]: Call sys_access, not _access.
897
898 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
899 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
900 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
901 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
902 e_* cousins.
903 (alloca) [_MSC_VER]: Define to _alloca.
904
905 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
906
907 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
908
a58c13ed
EZ
9092011-11-04 Eli Zaretskii <eliz@gnu.org>
910
911 * xdisp.c (note_mouse_highlight): If either of
912 previous/next-single-property-change returns nil, treat that as
913 the beginning or the end of the buffer. (Bug#9955)
914
fe0b6370
JD
9152011-11-04 Jan Djärv <jan.h.d@swipnet.se>
916
a58c13ed 917 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
918 label is not null (Bug#9951).
919 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
920 may be NULL.
921
89bd5ee1
EZ
9222011-11-04 Eli Zaretskii <eliz@gnu.org>
923
924 * window.c (Fwindow_body_size): Mention in the doc string that the
925 return value is in frame's canonical units. (Bug#9949)
926
84c3edb9
EZ
9272011-11-03 Eli Zaretskii <eliz@gnu.org>
928
4e2fb5c7
EZ
929 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
930
84c3edb9 931 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 932 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 933 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 934
bc17a887
EZ
9352011-11-01 Eli Zaretskii <eliz@gnu.org>
936
937 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
938 Don't stop backward scan on the continuation glyph, even though
939 its CHARPOS is positive.
6d5eb5b0
SM
940 (mouse_face_from_buffer_pos, note_mouse_highlight):
941 Rename cover_string to disp_string.
bc17a887 942
4ee88440
MR
9432011-11-01 Martin Rudalics <rudalics@gmx.at>
944
945 * window.c (temp_output_buffer_show): Don't use
946 Vtemp_buffer_show_specifiers.
947 (Vtemp_buffer_show_specifiers): Remove unused variable.
948
c2ff3c02
EZ
9492011-10-30 Eli Zaretskii <eliz@gnu.org>
950
951 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
952 past the beginning of the current glyph matrix.
953
58179cce 9542011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
955
956 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
957 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
958 HAVE_GTK3 (Bug#9869).
b77a6a7f 959
3b574623
JD
960 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
961 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
962
b77a6a7f
JD
963 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
964
965 * xterm.c: Declare x_handle_net_wm_state to return int.
966 (handle_one_xevent): Check if we are iconified but don't have
967 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
968 (get_current_wm_state): Return non-zero if not hidden,
969 check for _NET_WM_STATE_HIDDEN (Bug#9893).
970 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
971 (x_handle_net_wm_state): Return what get_current_wm_state returns.
972 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
973
196e41e4
PE
9742011-10-29 Paul Eggert <eggert@cs.ucla.edu>
975
976 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
977 so that this new function doesn't get optimized away by a
978 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
979
021f2e1a
AS
9802011-10-29 Andreas Schwab <schwab@linux-m68k.org>
981
982 * frame.h (MOUSE_HL_INFO): Remove excess parens.
983
8b058d44
EZ
9842011-10-29 Eli Zaretskii <eliz@gnu.org>
985
986 Fix the `xbytecode' command.
987 * .gdbinit (xprintbytestr): New command.
b50a28de 988 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
989 (xbytecode): Print the byte-code string as well.
990
4452fb80
EZ
9912011-10-29 Kim Storm <storm@cua.dk>
992
8b058d44
EZ
993 * alloc.c (which_symbols): New function.
994
21b72067
AS
9952011-10-29 Andreas Schwab <schwab@linux-m68k.org>
996
997 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
998 line. (Bug#9903)
999
83ed7b5c
GM
10002011-10-29 Glenn Morris <rgm@gnu.org>
1001
1002 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1003 Not clear what it was for, and it causes various bugs. (Bug#9839)
1004
5a7a728b
EZ
10052011-10-28 Eli Zaretskii <eliz@gnu.org>
1006
1007 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1008 possible random value that matches one of those tested as
1009 condition to clear the mouse face.
1010
d3d0842f
CY
10112011-10-28 Chong Yidong <cyd@gnu.org>
1012
1013 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1014
31b39d13
DN
10152011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1016
1017 * window.c (make_window): Initialize phys_cursor_on_p.
1018
9aba6043
SM
10192011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1020
1021 * lisp.h (struct Lisp_Symbol): Update comments.
1022
c20992f4
JB
10232011-10-28 Juanma Barranquero <lekktu@gmail.com>
1024
1025 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1026
db4f02f2
EZ
10272011-10-28 Eli Zaretskii <eliz@gnu.org>
1028
1029 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1030 <oslsachem@gmail.com> for helping to debug this.
1031
1032 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1033 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1034 (g_b_init_get_glyph_outline_w): New static variables.
1035 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1036 (GetGlyphOutlineW_Proc): New typedefs.
1037 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1038 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1039 New functions.
1040 (w32font_open_internal, compute_metrics):
1041 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1042 instead of calling the "wide" APIs directly.
1043
1044 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1045
1046 * w32.h (syms_of_w32font): Add prototype.
1047
87e68db4
JB
10482011-10-27 Juanma Barranquero <lekktu@gmail.com>
1049
1050 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1051 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1052 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1053 (Fmove_to_window_line): Doc fix.
1054
435c1d67
CY
10552011-10-27 Chong Yidong <cyd@gnu.org>
1056
1057 * process.c (make_process): Set gnutls_state to NULL.
1058
1059 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1060 non-NULL, regardless of GNUTLS_INITSTAGE.
1061 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1062 an error. Set process slots as soon as we allocate them.
1063
1064 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1065
9c6c6f49
CY
10662011-10-27 Chong Yidong <cyd@gnu.org>
1067
9aba6043
SM
1068 * gnutls.c (emacs_gnutls_deinit): New function.
1069 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1070 (Fgnutls_deinit, Fgnutls_boot): Use it.
1071
1072 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1073 (deactivate_process): Call emacs_gnutls_deinit.
1074
657d08d3
JB
10752011-10-27 Juanma Barranquero <lekktu@gmail.com>
1076
1077 * image.c (x_create_x_image_and_pixmap):
1078 * w32.c (sys_rename, w32_delayed_load):
1079 * w32font.c (fill_in_logfont):
1080 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1081
5430d399
JB
10822011-10-26 Juanma Barranquero <lekktu@gmail.com>
1083
1084 * w32fns.c (w32_default_color_map): New function,
1085 extracted from Fw32_default_color_map.
a7ef684b 1086 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1087
fe0055fa
PE
10882011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1089
1090 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1091
e6346438
SM
10922011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1093
1094 * keyboard.c (test_undefined): New function (bug#9751).
1095 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1096
e112cc37
ET
10972011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1098
1099 * sysdep.c (init_sys_modes): Fix the check for the controlling
1100 terminal (Bug#6649).
1101
7b5d6677
EZ
11022011-10-20 Eli Zaretskii <eliz@gnu.org>
1103
1104 * dispextern.h (struct bidi_it): New member next_en_type.
1105
1106 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1107 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1108 current character, check also for next_en_type being WEAK_EN.
1109 (bidi_resolve_weak): Don't enter the expensive loop if the current
1110 position is before next_en_pos. Record the bidi type of the first
1111 non-ET, non-BN character we find, in addition to its position.
1112 (bidi_level_of_next_char): Invalidate next_en_type when
1113 next_en_pos is over-stepped.
1114
7da0b018
PE
11152011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1116
1117 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1118 * editfns.c: Rewrite current-time-zone so that it invokes
1119 the equivalent of (format-time-string "%Z") to get the time zone name.
1120 This fixes a bug when the time zone name contains characters that
1121 need converting from the system time locale to Emacs internal format.
1122 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1123 that patch fixed format-time-string to do the conversion, but
1124 I forgot to fix current-time-zone.
1125 (format_time_string): New function, containing most of
1126 what Fformat_time_string used to contain.
1127 (Fformat_time_string): Rewrite in terms of format_time_string.
1128 This doesn't change this function's behavior.
1129 (current-time-zone): Rewrite to use format_time_string.
1130 This fixes the bug reported by Michael Schierl in
1131 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1132 Jason Rumney's 2007-06-07 change worked around this bug, but
1133 didn't fix it.
1134 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1135
8547b010
EZ
11362011-10-19 Eli Zaretskii <eliz@gnu.org>
1137
1138 * xdisp.c (start_display): If the character at POS is displayed
1139 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1140 (try_window_reusing_current_matrix): If a line ends in a display
1141 vector or the next line starts in a display vector, continue
1142 redrawing the window even though the character position of
1143 start_row was reached.
8547b010
EZ
1144 (Bug#9771, part 2)
1145
4e948d15
CY
11462011-10-18 Chong Yidong <cyd@gnu.org>
1147
1148 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1149 with nobreak-char-display too.
1150
4787455f
EZ
11512011-10-18 Eli Zaretskii <eliz@gnu.org>
1152
1153 Fix part 3 of bug#9771.
1154 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1155 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1156 non-neutral characters if the current character is a paragraph
1157 separator (a.k.a. Newline). This avoids running the same
1158 expensive loop twice, once when we consume the preceding newline
1159 and the other time when the line actually needs to be displayed.
1160 Avoid the loop when we see neutrals on the base embedding level
1161 following a character whose directionality is the same as the
1162 paragraph's. This avoids running the expensive loop when a line
1163 ends in a long sequence of neutrals, like control characters.
1164 Add assertion against STRONG_AL type. Slightly rearrange code
1165 that determines the type of a neutral given the first non-neutral
1166 that follows it.
1167 (bidi_level_of_next_char): Set next_en_pos to zero when
1168 invalidating its info.
1169
2c91f553
EZ
11702011-10-17 Eli Zaretskii <eliz@gnu.org>
1171
1172 * xdisp.c (push_display_prop): Determine whether to record string
1173 or buffer position by IT->string, not by IT->method. Allow
1174 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1175 (move_it_vertically_backward): Don't look for character position
1176 immediately after the newline when in a continuation line.
1177 (Bug#9771, part 1)
2c91f553 1178
c7b08b0d
MR
11792011-10-15 Martin Rudalics <rudalics@gmx.at>
1180
1181 * window.c (coordinates_in_window): Rewrite and delabelize
1182 vertical border check. (Bug#5357) (Bug#9618)
1183
6b02f655
SM
11842011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1185
1186 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1187 errors in XSetWindowBorder (bug#9310).
1188
81d40c92
DA
11892011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1190
1191 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1192 avoid crash when xmalloc overrun checking is enabled.
1193
d4172c3b
EZ
11942011-10-13 Eli Zaretskii <eliz@gnu.org>
1195
1196 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1197 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1198 cursor motion with <left> and <right> arrow keys.
1199
1200 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1201 some callers set that themselves.
1202
b00eea75
EZ
12032011-10-12 Eli Zaretskii <eliz@gnu.org>
1204
1205 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1206 display string and the previous row comes from the same string and
1207 is empty. (Bug#9739) (Bug#9738)
1208
8fe012c4
SM
12092011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1210
1211 * doc.c (get_doc_string): Encode file name (bug#9735).
1212
0074aef2
EZ
12132011-10-12 Eli Zaretskii <eliz@gnu.org>
1214
79beb178
EZ
1215 * bidi.c (bidi_level_of_next_char):
1216 * xdisp.c (get_visually_first_element): Remove old incorrect
1217 comments regarding the Unicode Line Separator character.
1218
0074aef2
EZ
1219 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1220
6e4b3fbe
DA
12212011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1222
1223 * alloc.c (Fgc_status): Do not access beyond zombies array
1224 boundary if nzombies > MAX_ZOMBIES.
1225 * alloc.c (dump_zombies): Add missing format specifier.
1226
0324f3af
PE
12272011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1228
b5525cac
PE
1229 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1230 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1231
0324f3af
PE
1232 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1233 Some packages use them to denote characters with modifiers.
1234
e9b5f888
AS
12352011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1236
1237 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1238 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1239 matching a pp-number. Rename parameter var to var1.
1240
127827c0
SM
12412011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1242
1243 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1244
c8fd3bd0
GM
12452011-10-08 Glenn Morris <rgm@gnu.org>
1246
1247 * callint.c (Fcall_interactively): Give a more explicit error for the
1248 'c' case with a non-character input. (Bug#8479)
1249
352ec8ff
EZ
12502011-10-08 Eli Zaretskii <eliz@gnu.org>
1251
03669ccb
EZ
1252 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1253 lines.
7061c986
EZ
1254 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1255 lines that are hscrolled on the left.
03669ccb 1256
352ec8ff
EZ
1257 * dispnew.c (buffer_posn_from_coords): Account for a possible
1258 presence of header-line. (Bug#4426)
1259
a66cfb1c
SM
12602011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1261
6b02f655
SM
1262 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1263 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1264
7c5ee88e
PE
12652011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1266
1267 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1268 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1269 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1270 this makes Emacs dump core during garbage collection on rare
1271 occasions. sizeof is obviously inferior to offsetof here, so
1272 stick with offsetof.
1273 (GC_POINTER_ALIGNMENT): New macro.
1274 (mark_memory): Omit 3rd (offset) arg; caller changed.
1275 Don't assume EMACS_INT alignment is the same as pointer alignment.
1276
df1bbe5b
SM
12772011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1278
1279 * keyboard.c (read_key_sequence_remapped): New var.
1280 (read_key_sequence): Compute remapping in the right buffer.
1281 (command_loop_1): Use read_key_sequence's remapping directly.
1282
51553db6
SM
12832011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1284
32c1fffd
SM
1285 * dired.c (file_name_completion): Don't expand file name.
1286 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1287 before checking file name handler.
1288
51553db6
SM
1289 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1290 they've been requested explicitly (bug#9591).
1291
b6bd1599 12922011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1293
1294 * keymap.c (Fsingle_key_description): Use make_specified_string
1295 instead of build_string to build string from push_key_description.
1296 (Bug#5193)
1297
f701dc2a
PE
12982011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1299
4222c55d
PE
1300 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1301 This fixes a Y2038 bug on 64-bit hosts.
1302 * buffer.c (reset_buffer):
1303 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1304 (Fclear_buffer_auto_save_failure):
1305 Use 0, not -1, to represent an unset failure time, since time_t
1306 might not be signed.
1307
f701dc2a
PE
1308 Remove dependency on glibc malloc internals.
1309 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1310 Move back here from lisp.h, but with their new implementations.
1311 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1312 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1313 * charset.c (charset_table_init): New static var.
1314 (syms_of_charset): Use it instead of xmalloc. This removes a
1315 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1316 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1317 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1318 Move back to alloc.c.
1319 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1320 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1321
9ceebf39
JD
13222011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1323
1324 * nsterm.m (windowDidResize): Call x_set_window_size only when
1325 ns_in_resize is true. Otherwise set pixelwidth/height and
1326 call change_frame_size (Bug#9628).
1327
cb993c58
PE
13282011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1329
3930c88b
PE
1330 Port --enable-checking=all to Fedora 14 x86-64.
1331 * charset.c (syms_of_charset): Also account for glibc malloc's
1332 internal overhead when calculating the initial malloc maximum.
1333
cb993c58
PE
1334 Port --enable-checking=all to Fedora 14 x86.
1335 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1336 Move to lisp.h.
1337 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1338 (overrun_check_realloc, overrun_check_free):
1339 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1340 That way, xmalloc returns a properly-aligned pointer even if
1341 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1342 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1343 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1344 into account when calculating the initial malloc maximum.
1345 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1346 Move here from alloc.c, so that charset.c can use it too.
1347 Properly align; the old code wasn't right for common 32-bit hosts
1348 when configured with --enable-checking=all.
1349 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1350 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1351
31bed486
EZ
13522011-09-29 Eli Zaretskii <eliz@gnu.org>
1353
04c70788 1354 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1355 use EDOM.
1356
fbcaa2f3
EZ
13572011-09-28 Eli Zaretskii <eliz@gnu.org>
1358
1359 * xdisp.c (compute_display_string_end): If there's no display
1360 string at CHARPOS, return -1.
1361
1362 * bidi.c (bidi_fetch_char): When compute_display_string_end
1363 returns a negative value, treat the character as a normal
1364 character not covered by a display string. (Bug#9624)
1365
a239d4e9
JB
13662011-09-28 Juanma Barranquero <lekktu@gmail.com>
1367
1368 * lread.c (Fread_from_string): Fix typo in docstring.
1369
88652fd5
EZ
13702011-09-27 Eli Zaretskii <eliz@gnu.org>
1371
1372 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1373 newline, reseat the iterator instead of bidi-iterating there one
1374 character at a time. (Bug#9610)
32c1fffd
SM
1375 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1376 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1377
ed497dd4
AS
13782011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1379
1380 * lread.c (readevalloop): Use correct code for NBSP.
1381 (read1): Likewise. (Bug#9608)
1382
b2bf61aa
MA
13832011-09-25 Michael Albinus <michael.albinus@gmx.de>
1384
1385 * dbusbind.c (Fdbus_register_signal): When service is not
1386 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1387
32bbb17c
GM
13882011-09-25 Glenn Morris <rgm@gnu.org>
1389
1390 * buffer.c (truncate-lines): Doc fix.
1391
94e0933e
CY
13922011-09-24 Chong Yidong <cyd@stupidchicken.com>
1393
1394 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1395 (Fset_window_next_buffers): Doc fix.
1396
cddde921
GM
13972011-09-24 Glenn Morris <rgm@gnu.org>
1398
1399 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1400
1260aef1
PE
14012011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1402
25b4bfa0
PE
1403 Fix minor problems found by static checking.
1404 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1405 * indent.c (Fvertical_motion): Fix == vs = typo.
1406
e3cbd34b
EZ
14072011-09-24 Eli Zaretskii <eliz@gnu.org>
1408
a66cfb1c
SM
1409 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1410 Default value is now t. Doc fix.
6bf7006f 1411
e3cbd34b 1412 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1413 logic when moving up, not only when moving down. Fix the
e3cbd34b 1414 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1415 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1416
1417 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1418 CHARPOS is covered by a display string which includes newlines.
1419 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1420 is covered by a display string with embedded newlines.
1421
a3de0cbd
MA
14222011-09-24 Michael Albinus <michael.albinus@gmx.de>
1423
1424 * dbusbind.c (Fdbus_register_signal): Add match rule to
1425 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1426 (Fdbus_register_method, Vdbus_registered_objects_table):
1427 Fix docstring.
a3de0cbd 1428
b260039d
JM
14292011-09-24 Jim Meyering <meyering@redhat.com>
1430
32c1fffd 1431 do not ignore write error for any output size
b260039d
JM
1432 The previous change was incomplete.
1433 While it makes emacs --batch detect the vast majority of stdout
1434 write failures, errors were still ignored whenever the output size is
1435 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1436 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1437 && echo FAIL: ignored write error
1438 FAIL: ignored write error
1439 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1440 && echo FAIL: ignored write error
1441 FAIL: ignored write error
1442 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1443
8eca8a7c
AS
14442011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1445
1446 * emacs.c (Fkill_emacs): In noninteractive mode exit
1447 non-successfully if a write error occurred on stdout. (Bug#9574)
1448
3341db62
EZ
14492011-09-21 Eli Zaretskii <eliz@gnu.org>
1450
1451 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1452 the xassert test.
1453
1454 * dispextern.h (struct it): Update the comment documenting what
1455 can it->OBJECT be.
1456
8c203dbf
EZ
14572011-09-20 Eli Zaretskii <eliz@gnu.org>
1458
1459 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1460 a display string, extend search for cursor position to end of row.
1461 (find_row_edges): If the row ends in a newline from a display
1462 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1463 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1464 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1465 non-empty line. Fixes confusing cursor motion with arrow keys at
1466 the beginning of a line that starts with whitespace.
8c203dbf 1467
a4824228
LMI
14682011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1469
1470 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1471 (bug#9493).
1472
33ed493b
CY
14732011-09-18 Chong Yidong <cyd@stupidchicken.com>
1474
1475 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1476 boolean (Bug#9154).
1477
56cd55c8
EZ
14782011-09-18 Eli Zaretskii <eliz@gnu.org>
1479
1480 * xdisp.c (display_line): Record maximum and minimum buffer
1481 positions even if no glyphs were produced (e.g., by a zero-width
1482 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1483 buffer positions that will be removed from the glyph row because
1484 they don't fit.
c02dcedf
EZ
1485 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1486 column is beyond frame width: don't subtract 1 "pixel" when
1487 computing width of the stretch.
3e62b7e0
EZ
1488 (reseat_at_next_visible_line_start): Undo the change made on
1489 2011-09-17 that saved paragraph information and restored it after
1490 the call to `reseat'. (Bug#9545)
56cd55c8 1491
5ed99d36 14922011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1493
1494 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1495 and turn window cursor on if cleared (Bug#9415).
1496
5ed99d36 14972011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1498
1499 * search.c (boyer_moore): Take unibyte characters from pattern
1500 literally. (Bug#9458)
1501
9bade7b2
EZ
15022011-09-18 Eli Zaretskii <eliz@gnu.org>
1503
1504 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1505
e5e9d610
PE
15062011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1507
87e4427a
PE
1508 Fix minor problem found by static checking.
1509 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1510 initialized, to pacify gcc -Wuninitialized.
1511
e5e9d610
PE
1512 * fileio.c: Report proper errno when syscall falls.
1513 (Finsert_file_contents): Save and restore errno,
1514 so that report_file_error outputs the correct diagnostic.
1515 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1516
a1674f0b
EZ
15172011-09-18 Eli Zaretskii <eliz@gnu.org>
1518
1519 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1520
fbfb6dd4
EZ
15212011-09-17 Eli Zaretskii <eliz@gnu.org>
1522
1523 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1524 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1525
bb187662
EZ
15262011-09-17 Eli Zaretskii <eliz@gnu.org>
1527
1137e8b8 1528 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1529 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1530
1531 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1532 (bidi_find_paragraph_start): Search back for paragraph beginning
1533 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1534 (bidi_move_to_visually_next): Only trigger paragraph-related
1535 computations when the last character is a newline or at EOB, not
1536 just any NEUTRAL_B. (Bug#9470)
1537
bb187662
EZ
1538 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1539 truncated lines if point is covered by a display string. (Bug#9524)
1540
2e621251
PE
15412011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1542
1543 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1544 (cons_to_x_long): New function.
1545 (lisp_data_to_selection_data): Use it. Correct the test for
1546 short-versus-long data; it was negated. Break out of vector
1547 loop, for efficiency, when a long datum is discovered.
1548
91a15bc6
SM
15492011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1550
1551 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1552
b41c3a35
EZ
15532011-09-16 Eli Zaretskii <eliz@gnu.org>
1554
1555 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1556 GCC PR/17406) by declaring this function with external scope.
1557
7812ba2d
PE
15582011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1559
1560 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1561 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1562
cf7edc2a
AS
15632011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1564
1565 * editfns.c (Fformat): Correctly handle text properties on "%%".
1566
bd01620e
EZ
15672011-09-15 Eli Zaretskii <eliz@gnu.org>
1568
1569 * xterm.c (x_draw_composite_glyph_string_foreground):
1570 * w32term.c (x_draw_composite_glyph_string_foreground):
1571 * term.c (encode_terminal_code):
1572 * composite.c (composition_update_it, get_composition_id):
1573 * xdisp.c (get_next_display_element)
1574 (fill_composite_glyph_string): Add comments about special meaning
1575 of TAB characters in a composition.
1576
a02719a3
PE
15772011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1578
1579 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1580 This occurs when processing a multibyte format.
1581 Problem reported by Wolfgang Jenker.
a02719a3 1582
72589a3c
JB
15832011-09-15 Johan Bockgård <bojohan@gnu.org>
1584
1585 * xdisp.c (try_cursor_movement): Only check for exact match if
1586 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1587
1c14176c
PE
15882011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1589
1590 Remove unused external symbols.
1591 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1592 * xdisp.c (calc_pixel_width_or_height): Now static.
1593 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1594 * indent.c (check_display_width):
1595 * w32term.c: Fix comment to match code.
1596 * xterm.c, xterm.h (x_catching_errors): Remove.
1597
d2eea5b5
PE
15982011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1599
1600 * xselect.c: Use signed conversions more consistently (Bug#9498).
1601 (selection_data_to_lisp_data): Assume incoming selection data are
1602 signed integers, not unsigned. This is to be consistent with
1603 outgoing selection data, which was modified to use signed integers
1604 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1605 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1606 expects long, not unsigned long.
1607
46888499
EZ
16082011-09-14 Eli Zaretskii <eliz@gnu.org>
1609
1610 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1611 computation of loop end. Reported by Johan Bockgård
1612 <bojohan@gnu.org>.
1613
ef8ef9fb
CY
16142011-09-13 Chong Yidong <cyd@stupidchicken.com>
1615
1616 * frame.c (Fother_visible_frames_p): Function deleted.
1617
fa819fed
EZ
16182011-09-12 Eli Zaretskii <eliz@gnu.org>
1619
1620 * indent.c (compute_motion): Process display vector front to back
1621 rather than the other way around. (Bug#2496)
1622
2ba8e008
SM
16232011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1624
1625 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1626
20f53c69
CY
16272011-09-11 Chong Yidong <cyd@stupidchicken.com>
1628
1629 * minibuf.c (Fread_from_minibuffer): Doc fix.
1630
d562d7a4
EZ
16312011-09-11 Eli Zaretskii <eliz@gnu.org>
1632
1633 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1634 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1635
1c4d7f3d
LMI
16362011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1637
1638 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1639 value for non-existent files.
1640
b885bf36
EZ
16412011-09-11 Eli Zaretskii <eliz@gnu.org>
1642
1643 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1644 set its "size" to -1. This will set the modtime_size field of
1645 the corresponding buffer to -1, which is what
1646 verify-visited-file-modtime expects for files that do not exist.
1647 (Bug#9139)
1648
6612f0bf
PE
16492011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1650
1651 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1652 here ...
1653 * lisp.h: ... from here. push_key_description is no longer
1654 defined in keyboard.c, so its declaration should not be in
1655 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1656 logically belongs with push_key_description.
1657
dfb3f755
PE
16582011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1659
1660 * buffer.h: Include <sys/types.h> instead of <time.h>.
1661 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1662 Problem reported by Herbert J. Skuhra.
1663
3134906c
LMI
16642011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1665
1666 * xml.c (parse_region): Make the parsing work for
1667 non-comment-starting XML files again (bug#9144).
1668
8d903f4e
AS
16692011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1670
1671 * image.c (gif_load): Fix calculation of bottom and right corner.
1672 (Bug#9468)
1673
80ad64f4
EZ
16742011-09-10 Eli Zaretskii <eliz@gnu.org>
1675
1676 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1677 redisplay in small windows.
1678
208a048d
EZ
16792011-09-09 Eli Zaretskii <eliz@gnu.org>
1680
1681 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1682
9b1c252e
MR
16832011-09-08 Martin Rudalics <rudalics@gmx.at>
1684
1685 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1686 Operate on live windows only.
1687
2949f33b
JB
16882011-09-08 Juanma Barranquero <lekktu@gmail.com>
1689
1690 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1691
e08dcafd
EZ
16922011-09-07 Eli Zaretskii <eliz@gnu.org>
1693
1694 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1695 only under bidi iteration.
1696
115b96bd
JD
16972011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1698
1699 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1700
c8199d0f
PE
17012011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1702
1703 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1704 Without this fix, the command to link temacs failed due to an
1705 undefined symbol __builtin_isnan. This is because
1706 /usr/include/iso/math_c99.h #defines isnan(x) to
1707 __builtin_isnan(x), but the bundled gcc, which identifies itself
1708 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1709 a __builtin_isnan.
1710 * floatfns.c (isnan): #undef, and then #define to a clone of
1711 what's in data.c.
1712 (Fisnan): Always define, since it's always available now.
1713 (syms_of_floatfns): Always define isnan at the Lisp level.
1714
e39b275c 17152011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1716
1717 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1718
b2db44d9 17192011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1720
f4af5137 1721 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1722 The previous code assumed that file offsets (off_t values) fit in
1723 EMACS_INT variables, which is not true on typical 32-bit hosts.
1724 The code messed up by falsely reporting buffer overflow in cases
1725 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1726 when "big" contains more than 2**29 bytes, even though this
1727 inserts just one byte and does not overflow the buffer.
1728 (Finsert_file_contents): Store file offsets as off_t
1729 values, not as EMACS_INT values. Check for overflow when
1730 converting between EMACS_INT and off_t. When checking for
1731 buffer overflow or for overlap, take the offsets into account.
1732 Don't use EMACS_INT for small values where int suffices.
1733 When checking for overlap, fix a typo: ZV was used where
1734 ZV_BYTE was intended.
1735 (Fwrite_region): Don't assume off_t fits into 'long'.
1736 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1737
ecfc0a49
MA
17382011-09-05 Michael Albinus <michael.albinus@gmx.de>
1739
1740 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1741
6511acf2 17422011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1743
0999621a 1744 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1745
1746 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1747 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1748 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1749 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1750 (modify_event_symbol): Do not assume that the length of
1751 name_alist_or_stem is safe to alloca and fits in int.
1752 (Fexecute_extended_command): Likewise for function name and binding.
1753 (Frecursion_depth): Wrap around reliably on integer overflow.
1754 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1755 since some callers pass EMACS_INT values.
1756 (Fsingle_key_description): Don't crash if symbol name contains more
1757 than MAX_ALLOCA bytes.
1758 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1759 (get_minibuffer): Arg is now EMACS_INT, not int.
1760 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1761 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1762 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1763
2be7d702
PE
1764 * dbusbind.c (signature_cat): New function.
1765 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1766 Do not overrun buffer; instead, report string overflow.
1767
9d1df220
PE
1768 * dispnew.c (add_window_display_history): Don't overrun buffer.
1769 Truncate instead; this is OK since it's just a log.
1770
33ef5c64
PE
1771 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1772 even if the time zone offset is outlandishly large.
1773 Don't mishandle offset == INT_MIN.
1774
66c6fdd5
PE
1775 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1776 when creating daemon; the previous buffer-overflow check was incorrect.
1777
d749b01b
PE
1778 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1779 which has the guts of the old verror function.
1780
b5cd1905
PE
1781 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1782 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1783
6e1a67fb
PE
1784 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1785 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1786 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1787 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1788 length of string rather than counting it via multiple sprintfs;
1789 that's simpler and more reliable.
c21721cc
PE
1790 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1791 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1792 sprintf, in case result does not fit in int.
1793
c57b67fc
PE
1794 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1795 (fontset_from_font): Print it.
1796
8a401434
PE
1797 * frame.c (tty_frame_count): Now printmax_t, not int.
1798 (make_terminal_frame, set_term_frame_name): Print it.
1799 (x_report_frame_params): In X, window IDs are unsigned long,
1800 not signed long, so print them as unsigned.
1801 (validate_x_resource_name): Check for implausibly long names,
1802 and don't assume name length fits in 'int'.
1803 (x_get_resource_string): Don't blindly alloca invocation name;
1804 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1805 not fit in int.
1806
6e1a67fb
PE
1807 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1808 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1809 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1810
0df02bf3
PE
1811 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1812 Use esprintf, not sprintf, in case result does not fit in int.
1813
48e30793
PE
1814 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1815 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1816 it as a large positive number.
1817 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1818 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1819
a66ff6d8
PE
1820 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1821 in case result does not fit in int.
1822
aca216ff
PE
1823 * print.c (float_to_string): Detect width overflow more reliably.
1824 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1825 buffer overrun. Don't assume list length fits in 'int'. Treat
1826 print length of 0 as 0, not as infinity; to be consistent with other
1827 uses of print length in this function. Don't overflow print length
1828 index. Don't assume hash table size fits in 'long', or that
1829 vectorlike size fits in 'unsigned long'.
1830
31c286f7
PE
1831 * process.c (make_process): Use printmax_t, not int, to format
1832 process-name gensyms.
1833
55e5faa1
PE
1834 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1835
80f2e268
PE
1836 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1837 to avoid potential buffer overrun.
1838
670741ab
PE
1839 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1840 if X resource line is longer than 512 bytes.
1841
b7163a50
PE
1842 * xfns.c (x_window): Make sprintf buffer a bit bigger
1843 to avoid potential buffer overrun.
1844
ae58ff1f
PE
1845 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1846
c43c8a6a
PE
1847 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1848
3f8236f4
PE
18492011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1850
53e9fe90 1851 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1852 Without these, Emacs silently mishandles large integers sometimes.
1853 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1854 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1855
6511acf2
PE
1856 * xdisp.c (try_window_id): Check Emacs fixnum range before
1857 converting to 'int'.
806add1d 1858
6511acf2 1859 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1860 Check that an Emacs fixnum is in range before assigning it to 'int'.
1861 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1862 values converted from Emacs fixnums.
1863 (Frecenter): Don't wrap around a line count if it is out of 'int'
1864 range; instead, treat it as an extreme value.
1865 (Fset_window_configuration, compare_window_configurations):
1866 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1867
6511acf2
PE
1868 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1869 that can exceed INT_MAX. Check that EMACS_INT value is in range
1870 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1871 (match_limit): Don't assume that a fixnum can fit in 'int'.
1872
6511acf2 1873 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1874 exceed INT_MAX.
1875
6511acf2 1876 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1877 (Fvertical_motion): Don't wrap around LINES values that don't fit
1878 in 'int'. Instead, treat them as extreme values. This is good
1879 enough for windows, which can't have more than INT_MAX lines anyway.
1880
fcb901a7
LMI
18812011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1882
0f2f6b6d
LMI
1883 * Require libxml/parser.h to avoid compilation warning.
1884
fcb901a7
LMI
1885 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1886
1887 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1888 since this reportedly can destroy thread storage.
1889
6e20a0d4
CY
18902011-08-30 Chong Yidong <cyd@stupidchicken.com>
1891
1892 * syntax.c (find_defun_start): Update all cache variables if
1893 exiting early (Bug#9401).
1894
148ae00e
EZ
18952011-08-30 Eli Zaretskii <eliz@gnu.org>
1896
f6cfbd8f
EZ
1897 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1898
148ae00e
EZ
1899 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1900 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1901 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1902
1903 * term.c (tty_append_glyph): New function.
1904 (produce_stretch_glyph): Static function and its prototype deleted.
1905
a66cfb1c
SM
1906 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1907 Add prototypes.
148ae00e 1908
c4a07a4c
PE
19092011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1910
1911 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1912 when checking :margin (Bug#9390).
1913 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1914 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1915 so that the name doesn't mislead. All uses changed.
1916
6bc8cd65
JB
19172011-08-28 Johan Bockgård <bojohan@gnu.org>
1918
1919 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1920 set_tty_hooks.
1921
dca4927e
EZ
19222011-08-27 Eli Zaretskii <eliz@gnu.org>
1923
1924 * xdisp.c (move_it_to): Don't bail out early when reaching
1925 position beyond to_charpos, if we are scanning backwards.
1926 (move_it_vertically_backward): When DY == 0, make sure we get to
1927 the first character in the line after the newline.
1928
f2cad773
PE
19292011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1930
1931 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1932 (ccl_driver): Do not generate an out-of-range pointer.
1933 (Fccl_execute_on_string): Remove unnecessary check for
1934 integer overflow, noted by Stefan Monnier in
1935 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1936 Remove a FIXME that didn't need fixing.
1937 Simplify the newly-introduced buffer reallocation code.
1938
0cae2cdb
JB
19392011-08-27 Juanma Barranquero <lekktu@gmail.com>
1940
1941 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1942
5fc295a4 19432011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1944
70c60eb2 1945 Integer and memory overflow issues (Bug#9196).
726e0ab1 1946
d31850da
PE
1947 * doc.c (get_doc_string): Rework so that
1948 get_doc_string_buffer_size is the actual buffer size, rather than
1949 being 1 less than the actual buffer size; this makes xpalloc more
1950 convenient.
1951
a69fbedb
PE
1952 * image.c (x_allocate_bitmap_record, cache_image):
1953 * xselect.c (Fx_register_dnd_atom):
1954 Simplify previous changes by using xpalloc.
1955
fe5c5d37
PE
1956 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1957 since either will do and ptrdiff_t is convenient with xpalloc.
1958
0065d054
PE
1959 * charset.c (charset_table_size)
1960 (struct charset_sort_data.priority): Now ptrdiff_t.
1961 (charset_compare): Don't overflow if priorities differ greatly.
1962 (Fsort_charsets): Don't assume list length fits in int.
1963 Check for size-calculation overflow when allocating sort data.
1964 (syms_of_charset): Allocate an initial charset table that is
1965 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1966
1967 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1968
1969 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1970 The actual value is always <= INT_MAX, and leaving it unsigned made
1971 overflow checking harder.
1972
1973 * dispextern.h (struct glyph_matrix.rows_allocated)
1974 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1975 with xpalloc. The values are still always <= INT_MAX.
1976
1977 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1978
1979 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1980 (SAFE_NALLOCA): New macro.
1981
1982 * region-cache.c (struct boundary.pos, find_cache_boundary)
1983 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1984 (set_cache_region, invalidate_region_cache)
1985 (revalidate_region_cache, know_region_cache, region_cache_forward)
1986 (region_cache_backward, pp_cache):
1987 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1988 so that ptrdiff_t * can be passed to xpalloc.
1989 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1990 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1991 (pp_cache): Don't assume cache_len fits in int.
1992 * region-cache.h: Adjust extern decls to match.
1993
1994 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1995 EMACS_INT, since either will do, for xpalloc.
1996
1997 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1998 (xnmalloc, xnrealloc, xpalloc): New functions.
1999
726e0ab1
PE
2000 * bidi.c (bidi_shelve_header_size): New constant.
2001 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2002 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2003
51f30bc5 2004 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2005 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2006 (overlay_strings):
2007 Don't update size of array until after memory allocation succeeds,
2008 because xmalloc/xrealloc may not return.
0065d054
PE
2009 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2010 now that we have proper integer overflow checking.
2011 (record_overlay_string, overlay_strings): Catch overflows when
2012 calculating size of overlay_str_buf.
726e0ab1 2013
0065d054
PE
2014 * callproc.c (Fcall_process): Check for size overflow when
2015 calculating size of args2.
2016 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2017 Normally we prefer signed values, but sticking with ptrdiff_t would
2018 require adding more-complicated checks.
726e0ab1
PE
2019
2020 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2021 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2022 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2023 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2024
2025 * character.c (Fstring): Check for size-calculation overflow.
2026
2027 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2028 unnecessary integer overflow. Check for size overflow.
2029 (encode_coding_object): Don't update size until xmalloc succeeds.
2030
2031 * composite.c (get_composition_id): Check for overflow in glyph
2032 length calculations.
2033
2034 Integer and memory overflow fixes for display code.
2035 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2036 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2037 (scrolling_window): Check for overflow in size calculations.
2038 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2039 Don't assume glyph table len fits in int.
2040 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2041 (row_table_size): Now ptrdiff_t, not int.
2042 (scrolling_window): Avoid overflow in size calculations.
2043 Don't update size until allocation succeeds.
2044 * fns.c (concat): Check for overflow in size calculations.
2045 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2046 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2047 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2048
2049 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2050 (get_doc_string): Check for size calculation overflow.
2051 Don't update size until allocation succeeds.
2052 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2053 EMACS_INT, where ptrdiff_t will do.
2054 (Fsubstitute_command_keys): Check for string overflow.
2055
2056 * editfns.c (set_time_zone_rule): Don't assume environment length
2057 fits in int.
2058 (message_length): Now ptrdiff_t, not int.
2059 (Fmessage_box): Don't update size until allocation succeeds.
2060 Don't assume message length fits in int.
2061 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2062
0065d054
PE
2063 * emacs.c (main): Do not reallocate argv, since there is a null at
2064 the end that can be overwritten, and this way there's no need to
2065 worry about size-calculation overflow.
2066 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2067
2068 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2069 alloc succeeds.
2070 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2071
2072 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2073 (x_set_scroll_bar_width, x_figure_window_size):
2074 Check for integer overflow.
2075 (x_set_alpha): Do not assume XINT fits in int.
2076
2077 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2078 This is for the members text_lines, text_cols, total_lines, total_cols,
2079 where the system imposes an 'int' limit.
2080
2081 * fringe.c (Fdefine_fringe_bitmap):
2082 Don't update size until alloc works.
2083
2084 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2085 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2086
2087 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2088 Check for size-calculation overflow.
2089 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2090 do, as we prefer signed integers.
2091 (id_to_widget.max_size, id_to_widget.used)
2092 (xg_store_widget_in_map, xg_remove_widget_from_map)
2093 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2094 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2095 Use and return ptrdiff_t, not int.
2096 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2097 * gtkutil.h: Change prototypes to match the above.
2098
2099 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2100 are duplicate now that they've been promoted to lisp.h.
2101 (x_allocate_bitmap_record, x_alloc_image_color)
2102 (make_image_cache, cache_image, xpm_load):
2103 Don't update size until alloc is done.
2104 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2105 (x_detect_edges):
3256efce 2106 Check for size calculation overflow.
726e0ab1
PE
2107 (ct_colors_allocated_max): New constant.
2108 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2109 overflow.
3256efce 2110
726e0ab1
PE
2111 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2112 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2113 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2114 Use ptrdiff_t, not int, to count maps.
2115 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2116 calculations. Don't update size until allocation succeeds.
2117 Redo calculations to avoid overflow.
726e0ab1
PE
2118 * keyboard.h: Change prototypes to match the above.
2119
2120 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2121 to count maps.
2122 (current_minor_maps): Check for size calculation overflow.
2123 * keymap.h: Change prototypes to match the above.
2124
2125 * lread.c (read1, init_obarray): Don't update size until alloc done.
2126
2127 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2128 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2129
726e0ab1
PE
2130 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2131 Now ptrdiff_t, not int.
2132 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2133 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2134
2135 * process.c (Fnetwork_interface_list): Check for overflow
2136 in size calculation.
2137
2138 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2139
2140 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2141 overflow. Don't bother calling xmalloc when xrealloc will do.
2142
2143 * search.c (Freplace_match): Check for size calculation overflow.
2144 (Fset_match_data): Don't assume list lengths fit in 'int'.
2145
2146 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2147 for command line length. Do not attempt to address one before the
2148 beginning of an array, as that's not portable.
2149
2150 * term.c (max_frame_lines): Remove; unused.
2151 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2152 not int.
2153 (encode_terminal_code, calculate_costs): Check for size
2154 calculation overflow.
2155 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2156 table lengths and related sizes. Don't update size until alloc
2157 done. Redo calculations to avoid overflow.
2158 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2159
2160 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2161 subtracting pointers.
2162 (gobble_line): Check for overflow more carefully. Don't update size
2163 until alloc done.
2164
2165 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2166 Don't update size until alloc done.
2167 Redo size calculations to avoid overflow.
2168 Check for size calculation overflow.
0065d054 2169 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2170
2171 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2172 Use ptrdiff_t, not int, for sizes.
2173 (store_mode_line_noprop_char): Don't update size until alloc done.
2174
0065d054
PE
2175 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2176 Use ptrdiff_t, not int, for sizes.
2177 (Finternal_make_lisp_face, cache_face):
2178 Check for size calculation overflow.
2179 (cache_face): Treat size calculation overflows as if they were
2180 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2181
2182 * xfns.c (x_encode_text, x_set_name_internal)
2183 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2184 sizes, since they can exceed INT_MAX in size. Check for size
2185 calculation overflow.
2186
0065d054
PE
2187 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2188 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2189 Don't update size until alloc done.
2190
0065d054 2191 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2192 as sprintf is limited to int lengths.
1d526e2f 2193
252c5ee1
PE
2194 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2195 (X_LONG_MIN): New macros.
864d7ce7
PE
2196 Use them to make the following changes clearer.
2197 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2198 This change doesn't affect the value now, but it may help remind
2199 future maintainers not to raise the value too much later.
2200 (SELECTION_QUANTUM): Remove, replacing with ...
2201 (selection_quantum): ... new function, which avoids overflow.
2202 All uses changed.
2203 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2204 assumption that selection length fits in 'int'.
2205 (x_reply_selection_request, x_handle_selection_request)
2206 (x_get_window_property, receive_incremental_selection)
2207 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2208 (lisp_data_to_selection_data, clean_local_selection_data):
2209 Use ptrdiff_t, not int, to record length of selection.
2210 (x_reply_selection_request, x_get_window_property)
2211 (receive_incremental_selection, x_property_data_to_lisp):
2212 Redo calculations to avoid overflow.
2213 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2214 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2215 something.
2216 (x_get_window_property, receive_incremental_selection)
2217 (lisp_data_to_selection_data, x_property_data_to_lisp):
2218 Check for size-calculation overflow.
2219 (x_get_window_property, receive_incremental_selection)
2220 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2221 Don't store size until memory allocation succeeds.
2222 (x_get_window_property): Plug memory leak on memory exhaustion.
2223 Don't double-block input; malloc is safe here. Don't assume 2**34
2224 - 4 fits in unsigned long. Add an xassert to check
2225 XGetWindowProperty overflow. Be more careful about overflow
2226 calculations, and distinguish size from memory overflow better.
2227 (receive_incremental_selection): When tracing, don't assume
2228 unsigned int is less than INT_MAX.
2229 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2230 harmful) conversions of unsigned short to int.
2231 (lisp_data_to_selection_data): Don't assume that integers
2232 in the range -65535 through -1 fit in an X unsigned short.
2233 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2234 result parameters unless successful. Rely on cons_to_unsigned
2235 to report problems with elements; the old code wasn't right anyway.
2236 (x_check_property_data): Check for int overflow; we cannot use
2237 a wider type due to X limits.
2238 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2239
726e0ab1 2240 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2241
0065d054
PE
2242 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2243 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2244 (x_color_cells): Don't store size until memory allocation succeeds.
2245 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2246 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2247 (x_term_init): Don't assume length fits in int (sprintf is limited
2248 to int size).
bc18e09d 2249
ebfa62c0
PE
2250 Use ptrdiff_t for composition IDs.
2251 * character.c (lisp_string_width):
2252 * composite.c (composition_table_size, n_compositions)
2253 (get_composition_id, composition_gstring_from_id):
2254 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2255 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2256 * window.c (Frecenter):
2257 Use ptrdiff_t, not int, for composition IDs.
2258 * composite.c (get_composition_id): Check for integer overflow.
2259 * composite.h: Adjust prototypes to match the above changes.
2260
d3411f89
PE
2261 Use ptrdiff_t for hash table indexes.
2262 * category.c (hash_get_category_set):
2263 * ccl.c (ccl_driver):
2264 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2265 * coding.c (coding_system_charset_list, detect_coding_system):
2266 * coding.h (struct coding_system.id):
2267 * composite.c (get_composition_id, gstring_lookup_cache):
2268 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2269 * image.c (xpm_get_color_table_h):
2270 * lisp.h (hash_lookup, hash_put):
2271 * minibuf.c (Ftest_completion):
2272 Use ptrdiff_t for hash table indexes, not int (which is too
2273 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2274 32-bit --with-wide-int hosts).
2275
e097a6fa
PE
2276 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2277 Add a FIXME comment about memory leaks.
2278 (syms_of_charset): Don't assume xmalloc returns.
2279
5637687f
PE
2280 Don't assume that stated character widths fit in int.
2281 * character.c (Fchar_width, c_string_width, lisp_string_width):
2282 * character.h (CHAR_WIDTH):
2283 * indent.c (MULTIBYTE_BYTES_WIDTH):
2284 Use sanitize_char_width to avoid undefined and/or bad behavior
2285 with outlandish widths.
a66cfb1c 2286 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2287 now that we have two such functions. All uses changed.
2288 (sanitize_char_width): New inline function.
2289
a2271ba2
PE
2290 Don't assume that tab-width fits in int.
2291 * character.h (sanitize_width): New inline function.
2292 (SANE_TAB_WIDTH): New macro.
2293 (ASCII_CHAR_WIDTH): Use it.
2294 * indent.c (sane_tab_width): Remove. All uses replaced by
2295 SANE_TAB_WIDTH (current_buffer).
2296 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2297
18c52557
PE
2298 * fileio.c: Integer overflow issues with file modes.
2299 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2300
caeeedc1
PE
2301 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2302 Remove unreachable code.
2303 (read_hex, load_charset_map_from_file): Check for integer overflow.
2304
50849c52
PE
2305 * xterm.c: don't go over XClientMessageEvent limit
2306 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2307 (x_send_scroll_bar_event): Likewise. Check that the size does not
2308 exceed limits imposed by XClientMessageEvent, as well as the usual
2309 ptrdiff_t and size_t limits.
2310
b13995db
PE
2311 * keyboard.c: Overflow, signedness and related fixes.
2312 (make_lispy_movement): Use same integer type in forward decl
2313 that is used in the definition.
2314 (read_key_sequence, keyremap_step):
2315 Change bufsize argument back to int, undoing my 2011-03-30 change.
2316 We prefer signed types, and int is wide enough here.
2317 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2318 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2319 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2320 length, not size_t. Use ptrdiff_t for index, not int.
2321 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2322 possibility of integer overflow.
2323
13464394
PE
2324 Overflow, signedness and related fixes for images.
2325
2326 * dispextern.h (struct it.stack[0].u.image.image_id)
2327 (struct_it.image_id, struct image.id, struct image_cache.size)
2328 (struct image_cache.used, struct image_cache.ref_count):
2329 * gtkutil.c (update_frame_tool_bar):
2330 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2331 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2332 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2333 * nsmenu.m (update_frame_tool_bar):
2334 * xdisp.c (calc_pixel_width_or_height):
2335 * xfns.c (image_cache_refcount):
2336 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2337 on typical 64-bit hosts.
2338
2339 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2340 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2341 Omit unnecessary casts to int.
2342 (parse_image_spec): Check that integers fall into 'int' range
2343 when the callers expect that.
2344 (image_ascent): Redo ascent calculation to avoid int overflow.
2345 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2346 (lookup_image): Remove unnecessary tests.
2347 (xbm_image_p): Locals are now of int, not EMACS_INT,
2348 since parse_image_check makes sure they fit into int.
2349 (png_load, gif_load, svg_load_image):
2350 Prefer int to unsigned where either will do.
2351 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2352 old tiff_error_handler and tiff_warning_handler.
2353 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2354 stack buffer overflows. It uses only the features of vsnprintf
2355 that are common to both POSIX and native Microsoft.
2356 (tiff_error_handler, tiff_warning_handler): Use it.
2357 (tiff_load, gif_load, imagemagick_load_image):
2358 Don't assume :index value fits in 'int'.
2359 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2360 (imagemagick_load_image): Check that crop parameters fit into
2361 the integer types that MagickCropImage accepts. Don't assume
2362 Vimagemagick_render_type has a nonnegative value. Don't assume
2363 size_t fits in 'long'.
2364 (gs_load): Use printmax_t to print the widest integers possible.
2365 Check for integer overflow when computing image height and width.
2366
c11821d4
EZ
23672011-08-26 Eli Zaretskii <eliz@gnu.org>
2368
2369 * xdisp.c (redisplay_window): Don't force window start if point
2370 will be invisible in the resulting window. (Bug#9324)
2371
0c95fcf7
EZ
23722011-08-25 Eli Zaretskii <eliz@gnu.org>
2373
2374 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2375 the display spec is of the form `(space ...)'.
2376 (handle_display_spec): Return the value returned by
2377 handle_single_display_spec, not just 1 or zero.
2378 (handle_single_display_spec): If the display spec is of the form
2379 `(space ...)', and specifies display in the text area, return 2
2380 rather than 1.
fee65a97 2381 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2382 accurately, and prefer exact match for point under bidi.
2383 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2384
2385 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2386 into disp_prop; all users changed.
2387
2388 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2389 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2390 for the text covered by the display property.
2391
e4ed06f1
CY
23922011-08-25 Chong Yidong <cyd@stupidchicken.com>
2393
2394 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2395 Change return value to nil.
2396 (Frecord_buffer): Delete unused function.
2397
f67cdd7f
EZ
23982011-08-24 Eli Zaretskii <eliz@gnu.org>
2399
5980d4c6
EZ
2400 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2401 buffers, return left-to-right.
8610fe8b
EZ
2402 (set_cursor_from_row): Consider candidate row a win if its glyph
2403 represents a newline and point is on that newline. Fixes cursor
2404 positioning on the newline at EOL of R2L text within L2R
2405 paragraph, and vice versa.
2406 (try_cursor_movement): Check continued rows, in addition to
2407 continuation rows. Fixes unwarranted scroll when point enters a
2408 continued line of R2L text within an L2R paragraph, or vice versa.
2409 (cursor_row_p): Consider the case of point being equal to
2410 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2411 from the end of a short line to the beginning of a continued line
2412 of R2L text within L2R paragraph.
2413 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2414 composed characters.
5980d4c6 2415
f67cdd7f
EZ
2416 * bidi.c (bidi_check_type): Use xassert.
2417 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2418 members.
2419
bca633fb
EZ
24202011-08-23 Eli Zaretskii <eliz@gnu.org>
2421
2422 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2423 a character.
2424
4a5885a7
CY
24252011-08-23 Chong Yidong <cyd@stupidchicken.com>
2426
2427 * nsfont.m (ns_otf_to_script): Fix typo.
2428
0902a04e
KH
24292011-08-22 Kenichi Handa <handa@m17n.org>
2430
2431 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2432 extra slot even if the purpose is char-code-property-table.
2433
1a2e6670
EZ
24342011-08-23 Eli Zaretskii <eliz@gnu.org>
2435
8ddde651
EZ
2436 * xdisp.c (redisplay_window): When computing centering_position,
2437 account for the height of the header line. (Bug#8874)
2438
425cc014
EZ
2439 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2440 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2441 candidate is selected by the mouse, and that candidate has a
2442 composed character under the mouse.
2443
1a2e6670
EZ
2444 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2445 coordinates reported by pos-visible-in-window-p for a composed
2446 character in column zero.
2447
8b76d6f8
SM
24482011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2449
2450 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2451
dac347dd
EZ
24522011-08-22 Eli Zaretskii <eliz@gnu.org>
2453
2454 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2455 consider it a hit if to_charpos is anywhere in the range of the
2456 composed buffer positions.
2457
e013fb34
CY
24582011-08-22 Chong Yidong <cyd@stupidchicken.com>
2459
2460 * image.c (gif_load): Don't assume that each subimage has the same
2461 dimensions as the base image. Handle disposal method that is
2462 "undefined" by the gif spec (Bug#9335).
2463
bd1ba3e8
CY
24642011-08-20 Chong Yidong <cyd@stupidchicken.com>
2465
2466 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2467 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2468
54a1215b
EZ
24692011-08-19 Eli Zaretskii <eliz@gnu.org>
2470
823564e5
EZ
2471 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2472 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2473 from an Org mode buffer to a Speedbar frame.
2474
54a1215b
EZ
2475 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2476 a composition, take its buffer position from IT->cmp_it.charpos.
2477 Fixes cursor positioning at the beginning of a line that begins
2478 with a composed character.
2479
9778ebcc
EZ
24802011-08-18 Eli Zaretskii <eliz@gnu.org>
2481
0be6ee06
EZ
2482 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2483 character bidirectional type, use STRONG_L instead. Fixes crashes
2484 in a buffer produced by `describe-categories'.
2485
9778ebcc
EZ
2486 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2487 members before the level stack, so they would be saved and
2488 restored when copying iterator state. Fixes incorrect reordering
2489 around TABs covered by display properties.
2490
156bffbe
AS
24912011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2492
6b02f655 2493 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2494
72ad093b
CY
24952011-08-17 Chong Yidong <cyd@stupidchicken.com>
2496
2497 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2498 (internal_condition_case_2, internal_condition_case_n):
2499 Remove unnecessary aborts (Bug#9081).
72ad093b 2500
35774242
EZ
25012011-08-17 Eli Zaretskii <eliz@gnu.org>
2502
2503 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2504 has no `load' handler, try opening the file locally. (Bug#9311)
2505
db76dd85
KB
25062011-08-16 Ken Brown <kbrown@cornell.edu>
2507
2508 * gmalloc.c: Expand comment.
2509
b215eee5
EZ
25102011-08-16 Eli Zaretskii <eliz@gnu.org>
2511
2512 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2513 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2514
a4579d33
KB
25152011-08-16 Ken Brown <kbrown@cornell.edu>
2516
2517 Fix memory allocation problems in Cygwin build (Bug#9273).
2518
2519 * unexcw.c ( __malloc_initialized): Declare external variable.
2520 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2521
8b76d6f8
SM
2522 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2523 New variables.
a4579d33
KB
2524 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2525 dumped emacs.
2526 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2527 in the static heap.
2528 [CYGWIN] (special_realloc): New function.
2529 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2530 requests to realloc storage in the static heap.
2531
3ebec551
PE
25322011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2533
2534 * bidi.c (bidi_initialize): Remove unused local.
2535
9fd8be00
EZ
25362011-08-15 Eli Zaretskii <eliz@gnu.org>
2537
6b02f655
SM
2538 * bidimirror.h:
2539 * biditype.h: Remove file.
2540 * makefile.w32-in ($(BLD)/bidi.$(O)):
2541 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2542
2543 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2544
2545 * chartab.c: Improve commentary for the uniprop_table API.
2546
32413314
EZ
2547 * bidi.c (bidi_paragraph_init): Support zero value of
2548 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2549 (bidi_initialize): Use uniprop_table instead of including
2550 biditype.h and bidimirror.h.
32413314 2551
9fd8be00
EZ
2552 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2553 coordinates of the iterator when restoring from ppos_it.
2554 (Bug#9296)
2555
5cf2b69b
KH
25562011-08-14 Kenichi Handa <handa@m17n.org>
2557
2558 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2559 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2560
daf17d00
EZ
25612011-08-14 Eli Zaretskii <eliz@gnu.org>
2562
2563 * xdisp.c (move_it_in_display_line_to): Don't invoke
2564 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2565 ppos_it. Fixes vertical cursor motion when line beginning is
2566 covered by an image. (Bug#9296)
2567
08e3161a
JD
25682011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2569
2570 * nsterm.h (ns_run_ascript): Declare.
2571 (NSAPP_DATA2_RUNASSCRIPT): Define.
2572
2573 * nsfns.m (as_script, as_result, as_status): New static variables.
2574 (ns_run_ascript): New function.
5e617bc2 2575 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2576 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2577 the event loop. Get status from as_status (Bug#7276).
2578
2579 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2580 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2581 the event loop (Bug#7276).
2582
a3720aa2
AS
25832011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2584
2585 * gnutls.c (QCgnutls_bootprop_priority)
2586 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2587 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2588 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2589 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2590 (QCgnutls_bootprop_verify_hostname_error)
2591 (QCgnutls_bootprop_callbacks_verify): Rename from
2592 Qgnutls_bootprop_..., all uses changed.
2593
2594 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2595 uses changed.
2596
0a0d27fb
PE
25972011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2598
19d5c50c
PE
2599 * xfaces.c (Qframe_set_background_mode): Now static.
2600 * dispextern.h (Qframe_set_background_mode): Remove decl.
2601
0a0d27fb
PE
2602 * process.c (Fnetwork_interface_info): Declare local only if needed.
2603
377538cb
JD
26042011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2605
2606 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2607 (Fnetwork_interface_list): Allocate in increments of bytes instead
2608 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2609 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2610 sockaddr.
2611 (struct ifflag_def): notrailers is smart on OSX.
2612 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2613 Get hardware address with getifaddrs if available.
2614
08fff70c
EZ
26152011-08-12 Eli Zaretskii <eliz@gnu.org>
2616
2617 * xdisp.c (iterate_out_of_display_property): xassert that
2618 IT->position is set to within IT->object's boundaries. Break from
2619 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2620 when IT->position is set up wrongly due to some bug.
2621 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2622 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2623 entry. Force push_it to save on the stack the current
2624 buffer/string position, to be restored by pop_it. Fix flags in
2625 the iterator structure wrt the object coming from a display
2626 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2627 properties. (Bug#9284)
2628
7be1c708 26292011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2630
7be1c708
CY
2631 * fontset.c (fontset_get_font_group): Add proper type checks.
2632 (Bug#9172)
aac0c6e3 2633
7be1c708 26342011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2635
7be1c708
CY
2636 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2637 and LC_VERSION_MIN_MACOSX.
2638 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2639 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2640
97bb72a6
EZ
26412011-08-08 Eli Zaretskii <eliz@gnu.org>
2642
2643 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2644 no-display-properties-and-no-overlays under bidi display.
2645 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2646 properties and overlays.
97bb72a6 2647
d5617611
CY
26482011-08-08 Chong Yidong <cyd@stupidchicken.com>
2649
37e11a63
CY
2650 * editfns.c (Fset_time_zone_rule): Document relationship with the
2651 setenv function.
2652
d5617611
CY
2653 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2654 the font entity extracted from the cache (Bug#8109).
2655
58872834
CY
26562011-08-07 Chong Yidong <cyd@stupidchicken.com>
2657
2658 * composite.c (autocmp_chars): Don't reset point. That is done by
2659 restore_point_unwind (Bug#5984).
2660
75bfc667
JL
26612011-08-07 Juri Linkov <juri@jurta.org>
2662
2663 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2664 to show the arg `TIME' instead of `TIMEVAL'.
2665
d1410150
EZ
26662011-08-06 Eli Zaretskii <eliz@gnu.org>
2667
2668 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2669 display property strides EOL and includes a newline, as in
2670 longlines-mode. (Bug#9254)
75b771e4
EZ
2671 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2672 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2673
2674 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2675 is non-zero, even if the data buffer is NULL. Fixes a crash in
2676 vertical-motion with longlines-mode. (Bug#9254)
2677
35928349
EZ
26782011-08-05 Eli Zaretskii <eliz@gnu.org>
2679
ec7cc85b
EZ
2680 * bidi.c <bidi_cache_total_alloc>: Now static.
2681 (bidi_initialize): Initialize bidi_cache_total_alloc.
2682
8b76d6f8 2683 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2684 cache. (Bug#9221)
2685
2686 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2687 amount allocated this far in `bidi_cache_total_alloc'.
2688 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2689 non-zero, only free the data buffer without restoring the cache
2690 contents. All callers changed.
2691
2692 * dispextern.h (bidi_unshelve_cache): Update prototype.
2693
2694 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2695 (move_it_in_display_line, move_it_to)
2696 (move_it_vertically_backward, move_it_by_lines): Replace the call
2697 to xfree to an equivalent call to bidi_unshelve_cache.
2698 (move_it_in_display_line_to): Fix logic of returning
412b6358 2699 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2700
e2e2423b
EZ
27012011-08-05 Eli Zaretskii <eliz@gnu.org>
2702
2703 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2704 came from a string character with a `cursor' property. (Bug#9229)
2705
ae9e757a
JD
27062011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2707
2708 * Makefile.in (LIB_PTHREAD): New variable.
2709 (LIBES): Add LIB_PTHREAD (Bug#9216).
2710
2711 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2712 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2713
213bd7f2
AS
27142011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2715
6b02f655 2716 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2717
99aaf75f
JD
27182011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2719
2720 * xterm.c (x_find_topmost_parent): New function.
2721 (x_set_frame_alpha): Find topmost parent window with
2722 x_find_topmost_parent and set the property there also (bug#9181).
2723 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2724
c74e9d86
PE
27252011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2726
2727 * callproc.c (Fcall_process): Avoid vfork clobbering
2728 the local vars buffer, coding_systems, current_dir.
2729
640c8776
SM
27302011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2731
2732 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2733
f26d0e4c
PE
27342011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2735
8a10d76c
PE
2736 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2737 so that it is not optimized away.
2738
f26d0e4c
PE
2739 * xdisp.c (compute_display_string_pos): Remove unused local.
2740
55439c61
EZ
27412011-08-02 Eli Zaretskii <eliz@gnu.org>
2742
2743 Fix slow cursor motion and scrolling in large buffers with
2744 selective display, like Org Mode buffers. (Bug#9218)
2745
2746 * dispextern.h (struct bidi_it): New member disp_prop_p.
2747
2748 * xdisp.c: Remove one-slot cache of display string positions.
2749 (compute_display_string_pos): Accept an additional argument
5e617bc2 2750 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2751 for a display string or property. If found, set DISP_PROP_P
2752 non-zero.
2753
2754 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2755 DISP_PROP_P, and pass it to compute_display_string_pos.
2756 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2757 non-zero. All callers of bidi_fetch_char changed.
2758
fb33fa43
SM
27592011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2760
2761 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2762
b099e063
DM
27632010-12-03 Don March <don@ohspite.net>
2764
2765 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2766 last character M-[char] is translated to ESC [char] (bug#7541).
2767
5cc7f7af
KH
27682011-08-02 Kenichi Handa <handa@m17n.org>
2769
d0fffa3f 2770 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2771
2772 * chartab.c (uniprop_table): Make it non-static.
2773
525d5e6e
EZ
27742011-08-01 Eli Zaretskii <eliz@gnu.org>
2775
2776 * xdisp.c (forward_to_next_line_start): Accept additional argument
2777 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2778 on the newline.
2779 (reseat_at_next_visible_line_start): Use the bidi iterator state
2780 returned by forward_to_next_line_start to restore the state of
2781 it->bidi_it after backing up to previous newline. (Bug#9212)
2782
31011111
AS
27832011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2784
2785 * regex.c (re_comp): Protoize.
2786 (re_exec): Fix return type.
2787 (regexec): Fix type of `ret'. (Bug#9203)
2788
476371c4
PE
27892011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2790
e5d76069
PE
2791 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2792 This is needed if max-image-size is a floating-point number.
2793
9a79b20c
AS
27942011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2795
2796 * print.c (print_object): Print empty symbol as ##.
2797
2798 * lread.c (read1): Read ## as empty symbol.
2799
d8c2fa78
AA
28002011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2801
2802 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2803 setting frame foreground color (Bug#9175).
2804 (x_set_background_color): Likewise.
2805
ffe57a7a
AA
2806 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2807 contents (Bug#9176).
2808 (EmacsTooltip -init): Remove bezels and add shadows to
2809 tooltip windows.
2810
bf3492a5
AA
2811 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2812 or scroll bar (Bug#8470).
2813
d55e9c53
AA
2814 * nsfont.m (nsfont_open): Remove assignment to voffset and
2815 unnecessary vars hshink, expand, hd, full_height, min_height.
2816 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2817
2818 * nsterm.h (nsfont_info): Remove voffset field.
2819
d8c2fa78 28202011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2821
2822 Implement strike-through and overline on NextStep (Bug#8863).
2823
2824 * nsfont.m (nsfont_open): Use underline position provided by font,
2825 instead of hard-coded value of 2.
2826 (nsfont_draw): Call ns_draw_text_decoration instead.
2827
2828 * nsterm.h: Add declaration for ns_draw_text_decoration.
2829
2830 * nsterm.m (ns_draw_text_decoration): New function for drawing
2831 underline, overline, and strike-through.
2832 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2833 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2834 accommodate underlining, etc.
4843aac3 2835
4cc60b9b
EZ
28362011-07-28 Eli Zaretskii <eliz@gnu.org>
2837
bc7ece87
EZ
2838 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2839 default.
4cc60b9b 2840
476371c4
PE
28412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2842
66606eea
PE
2843 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2844 Without this fix, if a signal arrives just after memory fills up,
2845 'malloc' might be invoked reentrantly.
2846
476371c4
PE
2847 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2848 In other words, assume that every image size is allowed, on non-X
2849 hosts. This assumption is probably wrong, but it lets Emacs compile.
2850
f3fcc40d
AS
28512011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2852
2853 * regex.c (re_iswctype): Convert return values to boolean.
2854
350c992f
EZ
28552011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2856
2857 * xdisp.c (compute_display_string_pos): Don't use cached display
2858 string position if the buffer had its restriction changed.
2859 (Bug#9184)
2860
5266b4bb
PE
28612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2862
2863 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2864
2573a837 28652011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2866
41f55ccd 2867 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2868
39e378da
PE
2869 * bidi.c: Integer size and overflow fixes.
2870 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2871 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2872 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2873 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2874 (bidi_find_other_level_edge):
2875 Use ptrdiff_t instead of EMACS_INT where either will do.
2876 This works better on 32-bit hosts configured --with-wide-int.
2877 (bidi_cache_ensure_space): Check for size-calculation overflow.
2878 Use % rather than repeated addition, for better worst-case speed.
2879 Don't set bidi_cache_size until after xrealloc returns, because it
2880 might not return.
2881 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2882 (bidi_cache_ensure_space): Also check that the bidi cache size
2883 does not exceed that of the largest Lisp string or buffer. See Eli
2884 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2885
5e927815
PE
2886 * alloc.c (__malloc_size_t): Remove.
2887 All uses replaced by size_t. See Andreas Schwab's note
2888 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2889
ca4aa935
PE
2890 * image.c: Improve checking for integer overflow.
2891 (check_image_size): Assume that f is nonnull, since
2892 it is always nonnull in practice. This is one less thing to
2893 worry about when checking for integer overflow later.
2894 (x_check_image_size): New function, which checks for integer
2895 overflow issues inside X.
2896 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2897 This removes the need for a memory_full check.
2898 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2899 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2900 (xbm_read_bitmap_data): Change locals back to 'int', since
2901 their values must fit in 'int'.
2902 (xpm_load_image, png_load, tiff_load):
2903 Invoke x_create_x_image_and_pixmap earlier,
2904 to avoid much needless work if the image is too large.
2905 (tiff_load): Treat overly large images as if
2906 x_create_x_image_and_pixmap failed, not as malloc failures.
2907 (gs_load): Use x_check_image_size.
2908
5f8f9cc2
PE
2909 * gtkutil.c: Omit integer casts.
2910 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2911 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2912
5adf60bc
PE
2913 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2914
c8907a93
PE
2915 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2916 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2917 would wrongly return t on a 64-bit host.
2918
e3c25c68
PE
2919 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2920 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2921 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2922 and therefore cause GCC to emit a bogus diagnostic in some cases.
2923
3f791afe
PE
2924 * image.c: Integer signedness and overflow and related fixes.
2925 This is not an exhaustive set of fixes, but it's time to
2926 record what I've got.
2927 (lookup_pixel_color, check_image_size): Remove redundant decls.
2928 (check_image_size): Don't assume that arbitrary EMACS_INT values
2929 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2930 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2931 (tiff_load, imagemagick_load_image):
2932 Check for overflow in size calculations.
2933 (x_create_x_image_and_pixmap): Remove unnecessary test for
2934 xmalloc returning NULL; that can't happen.
2935 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2936 (xpm_color_bucket): Use better integer hashing function.
2937 (xpm_cache_color): Don't possibly over-allocate memory.
2938 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2939 (gif_memory_source):
2940 Use ptrdiff_t, not int or size_t, to record sizes.
2941 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2942 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2943 either works, as we prefer signed integers.
2944 (tiff_read_from_memory, tiff_write_from_memory):
2945 Return tsize_t, not size_t, since that's what the TIFF API wants.
2946 (tiff_read_from_memory): Don't fail simply because the read would
2947 go past EOF; instead, return a short read.
2948 (tiff_load): Omit no-longer-needed casts.
2949 (Fimagemagick_types): Don't assume size fits into 'int'.
2950
3cc5a532
PE
2951 Improve hashing quality when configured --with-wide-int.
2952 * fns.c (hash_string): New function, taken from sxhash_string.
2953 Do not discard information about ASCII character case; this
2954 discarding is no longer needed.
2955 (sxhash-string): Use it. Change sig to match it. Caller changed.
2956 * lisp.h: Declare it.
2957 * lread.c (hash_string): Remove, since we now use fns.c's version.
2958 The fns.c version returns a wider integer if --with-wide-int is
2959 specified, so this should help the quality of the hashing a bit.
2960
b312a492
PE
2961 * emacs.c: Integer overflow minor fix.
2962 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2963 Define only if GNU_LINUX.
2964 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2965
dfd153ae
PE
2966 * dispnew.c: Integer signedness and overflow fixes.
2967 Remove unnecessary forward decls, that were a maintenance hassle.
2968 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2969 All uses changed.
2970 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2971 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2972 (prepare_desired_row, line_draw_cost):
2973 Use int, not unsigned, where either works.
2974 (save_current_matrix, restore_current_matrix):
2975 Use ptrdiff_t, not size_t, where either works.
2976 (init_display): Check for overflow more accurately, and without
2977 relying on undefined behavior.
2978
a81d11a3
PE
2979 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2980 Remove, replacing with the new symbols in lisp.h. All uses changed.
2981 * fileio.c (make_temp_name):
2982 * filelock.c (lock_file_1, lock_file):
2983 * xdisp.c (message_dolog):
2984 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2985 Use pMd etc. instead.
2986 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2987 replacing the pWIDE etc. symbols removed from editfns.c.
2988
3300e6fd
PE
2989 * keyboard.h (num_input_events): Now uintmax_t.
2990 This is (very slightly) less likely to mess up due to wraparound.
2991 All uses changed.
2992
fd05c7e9
PE
2993 * buffer.c: Integer signedness fixes.
2994 (alloc_buffer_text, enlarge_buffer_text):
2995 Use ptrdiff_t rather than size_t when either will do, as we prefer
2996 signed integers.
2997
903fe15d
PE
2998 * alloc.c: Integer signedness and overflow fixes.
2999 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3000 (__malloc_size_t): Default to size_t, not to int.
3001 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3002 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3003 Prefer ptrdiff_t to size_t when either would do, as we prefer
3004 signed integers.
3005 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3006 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3007 Now const. Initialize with values that are in range even if char
3008 is signed.
3009 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3010 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3011 These functions do the right thing with sizes > 2**32.
3012 (check_depth): Now ptrdiff_t, not int.
3013 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3014 Adjust to new way of storing sizes. Check for size overflow bugs
3015 in rest of code.
3016 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3017 slightly wrong anyway, as it missed one instance of
3018 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3019 (refill_memory_reserve): Omit needless cast to size_t.
3020 (mark_object_loop_halt): Mark as externally visible.
3021
ac82cc6a
PE
3022 * xselect.c: Integer signedness and overflow fixes.
3023 (Fx_register_dnd_atom, x_handle_dnd_message):
3024 Use ptrdiff_t, not size_t, since we prefer signed.
3025 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3026 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3027 x_dnd_atoms_size and x_dnd_atoms_length.
3028
c2d1e36d
PE
3029 * doprnt.c: Prefer signed to unsigned when either works.
3030 * eval.c (verror):
3031 * doprnt.c (doprnt):
3032 * lisp.h (doprnt):
3033 * xdisp.c (vmessage):
3034 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3035 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3036 prefer signed arithmetic to avoid comparison confusion.
3037 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3038 but is a bit tricky.
3039
0e926e56
PE
3040 Assume freestanding C89 headers, string.h, stdlib.h.
3041 * data.c, doprnt.c, floatfns.c, print.c:
3042 Include float.h unconditionally.
3043 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3044 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3045 * regex.c: Likewise for stddef.h, string.h.
3046 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3047 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3048 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3049 (STDC_HEADERS): Remove obsolete defines.
3050 * sysdep.c: Include limits.h unconditionally.
3051
9cfdb3ec
PE
3052 Assume support for memcmp, memcpy, memmove, memset.
3053 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3054 * regex.c (memcmp, memcpy):
3055 Remove; we assume C89 now.
3056
3057 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3058 (__malloc_safe_bcopy): Remove; no longer needed.
3059
cf950e6b 3060 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3061 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3062 well either way, and we prefer signed to unsigned.
3063
dbf38e02
LMI
30642011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3065
3066 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3067 closes the connection while we're reading (bug#9182).
3068
d6f0886c 30692011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3070
d6f0886c
JD
3071 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3072 are specified (Bug#9168).
24e0f6b1 3073
2eb1f9e6
PE
30742011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3075
3076 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3077 Found by GCC static checking and --with-wide-int on a 32-bit host.
3078
22381272 30792011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3080
3081 * xdisp.c (compute_display_string_pos): Fix logic of caching
3082 previous display string position. Initialize cached_prev_pos to
3083 -1. Fixes slow-down at the beginning of a buffer.
3084
f25e39b4
EZ
30852011-07-24 Eli Zaretskii <eliz@gnu.org>
3086
3087 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3088 for attrs[LFACE_FONTSET_INDEX].
3089
04c4b52e
PE
30902011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 * xml.c (parse_region): Remove unused local
3093 that was recently introduced.
3094
c1734fbd
EZ
30952011-07-23 Eli Zaretskii <eliz@gnu.org>
3096
be18c5a5
EZ
3097 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3098 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3099
c1734fbd
EZ
3100 * xdisp.c (move_it_in_display_line_to): Record the best matching
3101 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3102 exit if none of the characters scanned was an exact match.
3103 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3104 when exact match is impossible due to invisible text, and the
3105 lines are truncated.
3106
a258d627
JD
31072011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3108
3109 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3110 for OSX >= 10.7.
3111
b6d5a689
EZ
31122011-07-22 Eli Zaretskii <eliz@gnu.org>
3113
0f74f785
EZ
3114 Fix a significant slow-down of cursor motion with C-n, C-p,
3115 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3116 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3117 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3118 (next_element_from_buffer): Call compute_stop_pos_backwards to
3119 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3120 base_level_stop.
3121 (reseat): Don't look for prev_stop, as that could mean a very long
3122 run.
3123 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3124 <cached_disp_overlay_modiff>: Cache for last found display string
3125 position.
551918c1 3126 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3127 about the same buffer in the same area of character positions, and
3128 the buffer wasn't changed since the time the display string
3129 position was cached.
551918c1 3130
b2d0c91a
EZ
31312011-07-22 Eli Zaretskii <eliz@gnu.org>
3132
3133 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3134 is an integer, which is important for empty lines. (Bug#9149)
3135
043604ee
CY
31362011-07-22 Chong Yidong <cyd@stupidchicken.com>
3137
3138 * frame.c (Fmodify_frame_parameters): In tty case, update the
3139 default face if necessary (Bug#4238).
3140
da4adb04
CY
31412011-07-21 Chong Yidong <cyd@stupidchicken.com>
3142
3143 * editfns.c (Fstring_to_char): No need to explain what a character
3144 is in the docstring (Bug#6576).
3145
9abd0532
LMI
31462011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3147
3148 * xml.c (parse_region): Make sure we always return a tree.
3149
36881d16
HK
31502011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3151
3152 * xml.c (parse_region): If a document contains only comments,
3153 return that, too.
3154
1e98674d
LMI
31552011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3156
3157 * xml.c (make_dom): Return comments, too.
3158
590bd467
PE
31592011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3160
3161 Port to OpenBSD.
3162 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3163 and the surrounding thread.
3164 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3165 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3166 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3167 timer goes off.
3168 * s/openbsd.h (BROKEN_SIGIO): Define.
3169 * unexelf.c (unexec) [__OpenBSD__]:
3170 Don't update the .mdebug section of the Alpha COFF symbol table.
3171
f41628b2
LMI
31722011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3173
3174 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3175 (bug#8460).
3176
b59b67c5
PE
31772011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3178
15e3a074
PE
3179 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3180 This fixes some race conditions on the permissions of any newly
3181 created file.
3182
41bed37d
PE
3183 * alloc.c (valid_pointer_p): Use pipe, not open.
3184 This fixes some permissions issues when debugging.
3185
b59b67c5
PE
3186 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3187 If fchown fails to set both uid and gid, try to set just gid,
3188 as that is sometimes allowed. Adjust the file's mode to eliminate
3189 setuid or setgid bits that are inappropriate if fchown fails.
3190
925a6be7
SM
31912011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3192
3193 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3194 to compare Lisp_Objects.
3195 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3196 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3197 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3198
52968808
AS
31992011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3200
0a6a104b
AS
3201 * lread.c (read_integer): Unread even EOF character.
3202 (read1): Likewise. Properly record start position of symbol.
3203
52968808
AS
3204 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3205 symbol character follows.
3206
9e381cdd
PE
32072011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3208
3209 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3210 This works around a problem with the previous change to Fcopy_file.
3211 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3212 and without this change, GCC might complain about discarding
3213 fchown's return value.
3214
b5641435
JB
32152011-07-16 Juanma Barranquero <lekktu@gmail.com>
3216
3217 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3218
a8031457
PE
32192011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3220
3221 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3222
dd889327
LMI
32232011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3224
750c33f7
LMI
3225 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3226 it's used from the C level.
3227
dd889327
LMI
3228 * process.c: Use the same condition for POLL_FOR_INPUT in both
3229 keyboard.c and process.c (bug#1858).
3230
87e86684
LM
32312011-07-09 Lawrence Mitchell <wence@gmx.li>
3232
3233 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3234 (Fgnutls_boot): Use it.
3235
64348f40
AS
32362011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3237
3238 * doc.c (Fsubstitute_command_keys): Revert last change.
3239
1d698799
LMI
32402011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3241
f863868c
LMI
3242 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3243 quotes the next character, and doesn't affect other longer
3244 sequences (bug#8935).
3245
1d698799
LMI
3246 * lread.c (syms_of_lread): Clarify that is isn't only
3247 `eval-buffer' and `eval-defun' that's affected by
3248 `lexical-binding' (bug#8460).
3249
aa4b6df6
EZ
32502011-07-15 Eli Zaretskii <eliz@gnu.org>
3251
3252 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3253 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3254
5d856da6
PE
32552011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3256
ad6042bb
PE
3257 Fix minor problems found by static checking.
3258 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3259 (elsz): Now a signed constant, not a size_t var. We prefer signed
3260 types to unsigned, to avoid integer comparison confusion. Without
3261 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3262 "cannot optimize loop, the loop counter may overflow", a symptom
3263 of the confusion.
f00bbb22 3264 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3265 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3266
6468f31c
LMI
32672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3268
49080b10
LMI
3269 * search.c (Fre_search_backward): Mention `case-fold-search' in
3270 all the re_search_* functions (bug#8138).
3271
6468f31c
LMI
3272 * keyboard.c (Fopen_dribble_file): Document when the file is
3273 closed (bug#8056).
3274
c965adc5
EZ
32752011-07-14 Eli Zaretskii <eliz@gnu.org>
3276
df9733bf
EZ
3277 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3278 bidi_cache_idx.
3279
0bb23927
EZ
3280 Support bidi reordering of display and overlay strings.
3281 * xdisp.c (compute_display_string_pos)
3282 (compute_display_string_end): Accept additional argument STRING.
3283 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3284 (reseat_to_string): Initialize bidi_it->string.s and
3285 bidi_it->string.schars.
3286 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3287 NULL (avoids a crash in bidi_paragraph_init).
3288 Initialize itb.string.lstring.
0bb23927
EZ
3289 (init_iterator): Call bidi_init_it only of a valid
3290 buffer position was specified. Initialize paragraph_embedding to
3291 L2R.
3292 (reseat_to_string): Initialize the bidi iterator.
3293 (display_string): If we need to ignore text properties of
3294 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3295 original value of -1 will not work with bidi.)
3296 (compute_display_string_pos): First arg is now struct
3297 `text_pos *'; all callers changed. Support display properties on
3298 Lisp strings.
3299 (compute_display_string_end): Support display properties on Lisp
3300 strings.
3301 (init_iterator, reseat_1, reseat_to_string): Initialize the
3302 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3303 when iterating on a string not from display properties).
640c8776
SM
3304 (compute_display_string_pos, compute_display_string_end):
3305 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3306 arrow keys.
3307 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3308 base_level_stop; instead, set base_level_stop to BEGV.
3309 Fixes crashes in vertical-motion.
0bb23927
EZ
3310 (next_element_from_buffer): Improve commentary for when
3311 the iterator is before prev_stop.
3312 (init_iterator): Initialize bidi_p from the default value of
3313 bidi-display-reordering, not from buffer-local value. Use the
3314 buffer-local value only if initializing for buffer iteration.
3315 (handle_invisible_prop): Support invisible properties on strings
3316 that are being bidi-reordered.
3317 (set_iterator_to_next): Support bidi reordering of C strings and
3318 Lisp strings.
3319 (next_element_from_string): Support bidi reordering of Lisp
3320 strings.
3321 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3322 (display_string): Support display of R2L glyph rows.
3323 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3324 (init_iterator): Don't initialize it->bidi_p for strings
3325 here.
3326 (reseat_to_string): Initialize it->bidi_p for strings here.
3327 (next_element_from_string, next_element_from_c_string)
3328 (next_element_from_buffer): Add xassert's for correspondence
3329 between IT's object being iterated and it->bidi_it.string
3330 structure.
3331 (face_before_or_after_it_pos): Support bidi iteration.
3332 (next_element_from_c_string): Handle the case of the first string
3333 character that is not the first one in the visual order.
3334 (get_visually_first_element): New function, refactored from common
3335 parts of next_element_from_buffer, next_element_from_string, and
3336 next_element_from_c_string.
3337 (tool_bar_lines_needed, redisplay_tool_bar)
3338 (display_menu_bar): Force left-to-right direction. Add a FIXME
3339 comment for making that be controlled by a user option.
3340 (push_it, pop_it): Save and restore the state of the
3341 bidi iterator. Save and restore the bidi_p flag.
3342 (pop_it): Iterate out of display property for string iteration as
3343 well.
3344 (iterate_out_of_display_property): Support iteration over strings.
3345 (handle_single_display_spec): Set up it->bidi_it for iteration
3346 over a display string, and call bidi_init_it.
3347 (handle_single_display_spec, next_overlay_string)
3348 (get_overlay_strings_1, push_display_prop): Set up the bidi
3349 iterator for displaying display or overlay strings.
3350 (forward_to_next_line_start): Don't use the shortcut if
3351 bidi-iterating.
3352 (back_to_previous_visible_line_start): If handle_display_prop
3353 pushed the iterator stack, restore the internal state of the bidi
3354 iterator by calling bidi_pop_it same number of times.
3355 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3356 and we are bidi-iterating, don't decrement the iterator position;
3357 instead, set the first_elt flag in the bidi iterator, to produce
3358 the same effect.
3359 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3360 (push_display_prop): xassert that we are iterating a buffer.
3361 (push_it, pop_it): Save and restore paragraph_embedding member.
3362 (handle_single_display_spec, next_overlay_string)
3363 (get_overlay_strings_1, reseat_1, reseat_to_string)
3364 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3365 correctly. Don't assume unibyte strings are not bidi-reordered.
3366 (compute_display_string_pos)
3367 (compute_display_string_end): Fix handling the case of C string.
3368 (push_it, pop_it): Save and restore from_disp_prop_p.
3369 (handle_single_display_spec, push_display_prop): Set the
3370 from_disp_prop_p flag.
3371 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3372 (pop_it): Call iterate_out_of_display_property only if we are
3373 popping after iteration over a string that came from a display
3374 property. Fix a typo in popping stretch info. Add an assertion
3375 for verifying that the iterator position is in sync with the bidi
3376 iterator.
3377 (handle_single_display_spec, get_overlay_strings_1)
3378 (push_display_prop): Fix initialization of paragraph direction for
3379 string when that of the parent object is not yet determined.
3380 (reseat_1): Call bidi_init_it to resync the bidi
3381 iterator with IT's position. (Bug#7616)
3382 (find_row_edges): If ROW->start.pos gives position
3383 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3384 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3385 Reset the from_disp_prop_p flag.
3386 (SAVE_IT, RESTORE_IT): New macros.
3387 (pos_visible_p, face_before_or_after_it_pos)
3388 (back_to_previous_visible_line_start)
3389 (move_it_in_display_line_to, move_it_in_display_line)
3390 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3391 (try_scrolling, redisplay_window, display_line): Use them when
3392 saving a temporary copy of the iterator and restoring it back.
3393 (back_to_previous_visible_line_start, reseat_1)
3394 (init_iterator): Empty the bidi cache "stack".
3395 (move_it_in_display_line_to): If iterator ended up at
3396 EOL, but we never saw any buffer positions smaller than
3397 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3398 motion in bidi-reordered lines.
3399 (move_it_in_display_line_to): Record prev_method and prev_pos
3400 immediately before the call to set_iterator_to_next. Fixes cursor
3401 motion in bidi-reordered lines with stretch glyphs and strings
3402 displayed in margins. (Bug#8133) (Bug#8867)
3403 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3404 TO_CHARPOS.
640c8776
SM
3405 (pos_visible_p): Support positions in bidi-reordered lines.
3406 Save and restore bidi cache.
0bb23927
EZ
3407
3408 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3409 (bidi_paragraph_info): Delete unused struct.
3410 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3411 (bidi_cache_start): New variable.
3412 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3413 to zero.
3414 (bidi_cache_fetch_state, bidi_cache_search)
3415 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3416 (bidi_cache_find, bidi_peek_at_next_level)
3417 (bidi_level_of_next_char, bidi_find_other_level_edge)
3418 (bidi_move_to_visually_next): Compare cache index with
3419 bidi_cache_start rather than with zero.
3420 (bidi_fetch_char): Accept new argument STRING; all callers
3421 changed. Support iteration over a string. Support strings with
3422 display properties. Support unibyte strings. Fix the type of
3423 `len' according to what STRING_CHAR_AND_LENGTH expects.
3424 (bidi_paragraph_init, bidi_resolve_explicit_1)
3425 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3426 (bidi_level_of_next_char, bidi_move_to_visually_next):
3427 Support iteration over a string.
0bb23927
EZ
3428 (bidi_set_sor_type, bidi_resolve_explicit_1)
3429 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3430 can now be zero (for strings); special values 0 and -1 were
3431 changed to -1 and -2, respectively.
3432 (bidi_char_at_pos): New function.
3433 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3434 Call it instead of FETCH_MULTIBYTE_CHAR.
3435 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3436 initialized to valid values.
3437 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3438 values.
3439 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3440 the test for valid cached positions. Fix the logic for looking up
3441 the sentinel state in the cache. GCPRO the Lisp string we are
3442 iterating.
3443 (bidi_push_it, bidi_pop_it): New functions.
3444 (bidi_initialize): Initialize the bidi cache start stack pointer.
3445 (bidi_cache_ensure_space): New function, refactored from part of
3446 bidi_cache_iterator_state. Don't assume the required size is just
3447 one BIDI_CACHE_CHUNK away.
3448 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3449 (bidi_count_bytes, bidi_char_at_pos): New functions.
3450 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3451 always valid if bidi_cache_idx is valid.
3452 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3453 is valid if it's going to be used.
3454 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3455 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3456 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3457 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3458 (bidi_find_other_level_edge, bidi_cache_start_stack):
3459 All variables related to cache indices are now EMACS_INT.
c965adc5 3460
0bb23927
EZ
3461 * dispextern.h (struct bidi_string_data): New structure.
3462 (struct bidi_it): New member `string'. Make flag members be 1-bit
3463 fields, and put them last in the struct.
640c8776
SM
3464 (compute_display_string_pos, compute_display_string_end):
3465 Update prototypes.
0bb23927
EZ
3466 (bidi_push_it, bidi_pop_it): Add prototypes.
3467 (struct iterator_stack_entry): New members bidi_p,
3468 paragraph_embedding, and from_disp_prop_p.
3469 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3470 (bidi_shelve_cache, bidi_unshelve_cache):
3471 Declare prototypes.
0bb23927
EZ
3472
3473 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3474 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3475 and vector-like objects.
3476
3477 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3478 cache around display iteration.
3479
3480 * window.c (Fwindow_end, window_scroll_pixel_based)
3481 (displayed_window_lines, Frecenter): Save and restore the bidi
3482 cache around display iteration.
3483
3bbd2265
LMI
34842011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3485
3486 * editfns.c (Fdelete_region): Clarify the use of the named
3487 parameters (bug#6788).
3488
adc47434
MR
34892011-07-14 Martin Rudalics <rudalics@gmx.at>
3490
3491 * indent.c (Fvertical_motion): Set and restore w->pointm when
3492 saving and restoring the window's buffer (Bug#9006).
3493
837c31f8
LMI
34942011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3495
3496 * editfns.c (Fstring_to_char): Clarify just what is returned
3497 (bug#6576). Text by Eli Zaretskii.
3498
ac389d0c
JB
34992011-07-13 Juanma Barranquero <lekktu@gmail.com>
3500
3501 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3502
0be0ce47
EZ
35032011-07-13 Eli Zaretskii <eliz@gnu.org>
3504
3505 * buffer.c (mmap_find): Fix a typo.
3506
cd18e7e3
JB
35072011-07-13 Johan Bockgård <bojohan@gnu.org>
3508
3509 Fix execution of x selection hooks.
3510 * xselect.c (Qx_lost_selection_functions)
3511 (Qx_sent_selection_functions): New vars.
3512 (syms_of_xselect): DEFSYM them.
3513 (x_handle_selection_request): Pass Qx_sent_selection_functions
3514 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3515 (x_handle_selection_clear,x_clear_frame_selections):
3516 Pass Qx_lost_selection_functions rather than
3517 Vx_lost_selection_functions to Frun_hook_with_args.
3518
47ea7f44
PE
35192011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3520
ac389d0c 3521 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3522 The old code sometimes used this field without initializing it.
3523
47ea7f44
PE
3524 * alloc.c (gc_sweep): Don't read past end of array.
3525 In theory, the old code could also have corrupted Emacs internals,
3526 though it'd be very unlikely.
3527
bc985c87
AS
35282011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3529
3530 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3531 argument. (Bug#4026)
bc985c87 3532
0cf34688
LMI
35332011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3534
b3dadd76
LMI
3535 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3536 key" (bug#4257).
3537
0cf34688
LMI
3538 * window.c (Fset_window_start): Doc fix (bug#4199).
3539 (Fset_window_hscroll): Ditto.
3540
270768cd
PE
35412011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3542
077e3dda 3543 Fix minor new problems caught by GCC 4.6.1.
270768cd 3544 * term.c (init_tty): Remove unused local.
490011a6 3545 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3546 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3547 not used otherwise.
270768cd 3548
b1f58454
CY
35492011-07-12 Chong Yidong <cyd@stupidchicken.com>
3550
3551 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3552
22b9578d
LMI
35532011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3554
6e70ab07
LMI
3555 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3556 are the mini-buffer and the echo area (bug#3320).
3557
22b9578d
LMI
3558 * term.c (init_tty): Remove support for supdup, c10 and perq
3559 terminals, which are no longer supported (bug#1482).
3560
8974cc9f
JB
35612011-07-10 Johan Bockgård <bojohan@gnu.org>
3562
3563 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3564
a560d974
JD
35652011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3566
3567 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3568 for non-popups (Bug#3642).
3569
1dae0f0a
AS
35702011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3571
268c2c36 3572 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3573 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3574 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3575 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3576 * data.c (fmod): Likewise.
3577 * dispnew.c (swap_glyphs_in_rows): Likewise.
3578 * emacs.c (memory_warning_signal): Likewise.
3579 * floatfns.c (float_error): Likewise.
3580 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3581 (otf_open, font_otf_capability, generate_otf_features)
3582 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3583 Likewise.
3584 * image.c (pbm_read_file): Likewise.
3585 * indent.c (string_display_width): Likewise.
3586 * intervals.c (check_for_interval, search_for_interval)
3587 (inc_interval_count, count_intervals, root_interval)
3588 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3589 * lread.c (defalias): Likewise.
268c2c36 3590 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3591 * regex.c (set_image_of_range_1, set_image_of_range)
3592 (regex_grow_registers): Likewise.
3593 * sysdep.c (strerror): Likewise.
3594 * termcap.c (valid_filename_p, tprint, main): Likewise.
3595 * tparam.c (main): Likewise.
3596 * unexhp9k800.c (run_time_remap, save_data_space)
3597 (update_file_ptrs, read_header, write_header, calculate_checksum)
3598 (copy_file, copy_rest, display_header): Likewise.
3599 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3600 Likewise.
3601 * xdisp.c (check_it): Likewise.
3602 * xfaces.c (register_color, unregister_color, unregister_colors):
3603 Likewise.
3604 * xfns.c (print_fontset_result): Likewise.
3605 * xrdb.c (member, fatal, main): Likewise.
3606
99033785
PE
36072011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3608
3609 Fix minor problems found by static checking (Bug#9031).
3610 * chartab.c (char_table_set_range, map_sub_char_table):
3611 Remove unused locals.
3612 (uniprop_table): Now static.
3613 * composite.c (_work_char): Remove unused static var.
3614
9cb2ac56
JB
36152011-07-09 Juanma Barranquero <lekktu@gmail.com>
3616
3617 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3618
f25661f0
JD
36192011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3620
3621 * gtkutil.c (qttip_cb): Remove code without function.
3622
8278c4fe
EZ
36232011-07-09 Eli Zaretskii <eliz@gnu.org>
3624
3625 * w32.c (pthread_sigmask): New stub.
3626
1692ae2d 36272011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3628
8a6ebd58 3629 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3630 sigprocmask is portable only for single-threaded applications, and
3631 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3632 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3633 (LIBES): Use it.
3634 * callproc.c (Fcall_process):
3635 * process.c (create_process):
3636 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3637 Use pthread_sigmask, not sigprocmask.
123403e4 3638
1b854618
JD
36392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3640
3641 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3642 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3643 wrong (Bug#8591).
3644
3fe4b549
JD
36452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3646
0ce7e563
JD
3647 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3648 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3649 (xg_hide_tooltip): Fix comment.
3650
3fe4b549
JD
3651 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3652 in registerServicesMenuSendTypes.
3653 (validRequestorForSendType): Don't check ns_return_types.
3654
3655 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3656 ns_return_type.
3657
5df75e47
JR
36582011-07-08 Jason Rumney <jasonr@gnu.org>
3659
22610910
JR
3660 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3661 SH_SHOW for hidden windows (Bug#5482).
3662
5df75e47
JR
3663 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3664 frame struct members of non-existent frames (Bug#6284).
3665
699c10bd
JD
36662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3667
4393663b
JD
3668 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3669 variable firstTime not needed on OSX >= 10.6.
3670 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3671 >= 10.5. Use setKnobProportion, setDoubleValue.
3672
3673 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3674 (MAC_OS_X_VERSION_10_5): Define if not defined.
3675 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3676 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3677 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3678
3679 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3680 cString and lossyCString on OSX >= 10.4
3681
58179cce 3682 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3683 sizeToFit on OSX >= 10.2.
3684
3685 * nsimage.m (allocInitFromFile): Don't use deprecated method
3686 bestRepresentationForDevice on OSX >= 10.6.
3687
3688 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3689 to avoid warning.
3690
3691 * emacs.c: Declare unexec_init_emacs_zone.
3692
a63e0781
JD
3693 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3694
699c10bd
JD
3695 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3696
3697 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3698 on svcsMenu (Bug#8842).
3699
3700 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3701 ns_return_types.
3702 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3703
3704 * nsterm.m (QUTF8_STRING): Declare.
3705 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3706 (validRequestorForSendType): Return type is (id).
3707 Change indexOfObjectIdenticalTo to indexOfObject.
3708 Check if we have local selection before returning self (Bug#8842).
3709 (writeSelectionToPasteboard): Put local selection into paste board
3710 if we have a local selection (Bug#8842).
3711 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3712
3713 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3714 (ns_get_local_selection): Declare.
3715
54e10184
LMI
37162011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3717
9888ff71
LMI
3718 * keymap.c (describe_map_tree): Don't insert a double newline at
3719 the end of the buffer (bug#1169) and return whether we inserted
3720 something.
3721
54e10184
LMI
3722 * callint.c (Fcall_interactively): Change "reading args" to
3723 "providing args" to try to clarify what it does (bug#1010).
3724
15fa4783
KH
37252011-07-07 Kenichi Handa <handa@m17n.org>
3726
3727 * composite.c (composition_compute_stop_pos): Ignore a static
3728 composition starting before CHARPOS (Bug#8915).
3729
3730 * xdisp.c (handle_composition_prop): Likewise.
3731
a8815b00
EZ
37322011-07-07 Eli Zaretskii <eliz@gnu.org>
3733
3734 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3735 (Bug#9015)
3736
ef7b981d 37372011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3738
3739 * character.h (unicode_category_t): New enum type.
3740
3741 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3742 (Qchar_code_property_table): New variable.
3743 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3744 (UNIPROP_COMPRESSED_FORM_P): New macros.
3745 (char_table_ascii): Uncompress the compressed values.
3746 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3747 Uncompress the compressed values.
ac389d0c 3748 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3749 (char_table_ref_and_range): Uncompress the compressed values.
3750 (sub_char_table_set): New arg is_uniprop. Callers changed.
3751 Uncompress the compressed values.
3752 (sub_char_table_set_range): Args changed. Callers changed.
3753 (char_table_set_range): Adjuted for the above change.
3754 (map_sub_char_table): Delete args default_val and parent. Add arg
3755 top. Give decoded values to a Lisp function.
640c8776 3756 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3757 values to a Lisp function. Gcpro more variables.
3758 (uniprop_table_uncompress)
3759 (uniprop_decode_value_run_length): New functions.
3760 (uniprop_decoder, uniprop_decoder_count): New variables.
3761 (uniprop_get_decoder, uniprop_encode_value_character)
3762 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3763 New functions.
3764 (uniprop_encoder, uniprop_encoder_count): New variables.
3765 (uniprop_get_encoder, uniprop_table)
3766 (Funicode_property_table_internal, Fget_unicode_property_internal)
3767 (Fput_unicode_property_internal): New functions.
3768 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3769 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3770 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3771 char-code-property-alist.
3772
640c8776 3773 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3774 Vunicode_category_table.
3775
640c8776 3776 * font.c (font_range): Adjust for the change of
c805dec0
KH
3777 Vunicode_category_table.
3778
76b397fb
DN
37792011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3780
3781 * m/iris4d.h: Remove file, move contents ...
3782 * s/irix6-5.h: ... here.
3783
22b4128e
PE
37842011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3785
3786 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3787 * alloc.c (mark_buffer):
3788 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3789 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3790 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3791 This isn't true in general, and it's particularly not true
3792 if Emacs is configured with --with-wide-int.
3793 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3794 New macros, used in the buffer.c change.
3795
869795d6
JD
37962011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3797
3798 * xsettings.c: Use both GConf and GSettings if both are available.
3799 (store_config_changed_event): Add comment.
3800 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3801 (store_tool_bar_style_changed): New functions.
5e617bc2 3802 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3803 (struct xsettings): Move font inside HAVE_XFT.
3804 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3805 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3806 Move inside HAVE_XFT.
640c8776 3807 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3808 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3809 also.
3810 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3811 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3812 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3813 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3814 (parse_settings): Move check for font inside HAVE_XFT.
3815 (read_settings, apply_xft_settings): Add comment.
3816 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3817 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3818 call store_font_name_changed.
3819 (xft_settings_event): Add comment.
3820 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3821 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3822 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3823 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3824 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3825 (xsettings_get_system_font, xsettings_get_system_normal_font):
3826 Add comment.
869795d6 3827
d8ed26bd
PE
38282011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3829
3830 Random fixes. E.g., (random) never returned negative values.
3831 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3832 subseconds part to the entropy, as that's a bit more random.
3833 Prefer signed to unsigned, since the signedness doesn't matter and
3834 in general we prefer signed. When given a limit, use a
3835 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3836 latter isn't right if USE_2_TAGS_FOR_INTS.
3837 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3838 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3839
cabf1cac
SM
38402011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3841
3842 * textprop.c (text_property_stickiness):
3843 Obey Vtext_property_default_nonsticky.
3844 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3845 * w32fns.c (syms_of_w32fns):
3846 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3847
6e9b2be9
PE
38482011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3849
3850 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3851 This is more efficient than Ffile_directory_p and avoids a minor race.
3852
90186c68
LMI
38532011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3854
7c301272
LMI
3855 * buffer.c (Foverlay_put): Say what the return value is
3856 (bug#7835).
3857
c4f2d8d4
LMI
3858 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3859 is a directory before asking whether to use the file name
3860 (bug#7564).
ad637907
LMI
3861 (barf_or_query_if_file_exists): Make the "File is a directory"
3862 error be more correct.
c4f2d8d4 3863
90186c68
LMI
3864 * fns.c (Frequire): Remove the mention of the .gz files, since
3865 that's installation-specific, but keep the mention of
3866 `get-load-suffixes'.
3867
da64016e
PE
38682011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3869
3870 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3871 Report string overflow if the output is too long.
3872
7d47b580
JB
38732011-07-04 Juanma Barranquero <lekktu@gmail.com>
3874
a555cb87
JB
3875 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3876 (syms_of_gnutls): Remove duplicate DEFSYM for
3877 Qgnutls_bootprop_verify_hostname_error, an error for
3878 Qgnutls_bootprop_verify_error (which is no longer used).
3879
7d47b580
JB
3880 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3881 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3882 Also (re)move comments that are misplaced or no longer relevant.
3883
1e49bfab
LMI
38842011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3885
3886 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3887
1485f4c0
CY
38882011-07-03 Chong Yidong <cyd@stupidchicken.com>
3889
3890 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3891 and background color parameters if they have been changed.
3892
a9ab721e
LMI
38932011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3894
3895 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3896
cf7cff57
PE
38972011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3898
2e13213d
PE
3899 * xsettings.c (SYSTEM_FONT): Define only when used.
3900 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3901
cf7cff57
PE
3902 * keymap.c (access_keymap_1): Now static.
3903
7a8e04f7
CY
39042011-07-02 Chong Yidong <cyd@stupidchicken.com>
3905
3906 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3907 leave any prefix arg for the up event (Bug#1586).
3908
61352f62
LMI
39092011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3910
69bb1ef7
LMI
3911 * lread.c (syms_of_lread): Mention single symbols defined by
3912 `defvar' or `defconst' (bug#7154).
3913
61352f62 3914 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3915 (Frequire): Mention get-load-suffixes.
61352f62 3916
28545e04
MR
39172011-07-02 Martin Rudalics <rudalics@gmx.at>
3918
3919 * window.h (window): Remove clone_number slot.
3920 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3921 Remove.
3922 (make_parent_window, make_window, saved_window)
3923 (Fset_window_configuration, save_window_save): Don't deal with
3924 clone numbers.
3925 * buffer.c (Qclone_number): Remove declaration.
3926 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3927
3349e122
SM
39282011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3929
3930 Add multiple inheritance to keymaps.
3931 * keymap.c (Fmake_composed_keymap): New function.
3932 (Fset_keymap_parent): Simplify.
3933 (fix_submap_inheritance): Remove.
3934 (access_keymap_1): New function extracted from access_keymap to handle
3935 embedded parents and handle lists of maps.
3936 (access_keymap): Use it.
3937 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3938 (Fcopy_keymap): Handle embedded parents.
3939 (Fcommand_remapping, define_as_prefix): Simplify.
3940 (Fkey_binding): Simplify.
3941 (syms_of_keymap): Move minibuffer-local-completion-map,
3942 minibuffer-local-filename-completion-map,
3943 minibuffer-local-must-match-map, and
3944 minibuffer-local-filename-must-match-map to Elisp.
3945 (syms_of_keymap): Defsubr make-composed-keymap.
3946 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3947 (parse_menu_item): Trivial simplification.
3948
3279eb87
GM
39492011-07-01 Glenn Morris <rgm@gnu.org>
3950
3951 * Makefile.in (SETTINGS_LIBS): Fix typo.
3952
4550efdf
KI
39532011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3954
3955 * coding.c (Fencode_coding_string): Record the last coding system
3956 used, as the function doc string says (bug#8738).
3957
0949d2b6
JD
39582011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3959
3960 * xsettings.c (store_monospaced_changed): Take new font as arg and
3961 check for change against current_mono_font.
3962 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3963 (emacs_settings_constructor, emacs_settings_get_property)
3964 (emacs_settings_set_property, emacs_settings_class_init)
3965 (emacs_settings_init, gsettings_obj): Remove.
3966 (something_changedCB): New function for HAVE_GSETTINGS.
3967 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3968 with value as argument.
3969 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3970 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3971 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3972 "changed".
3973
3974 * xgselect.c: Add defined (HAVE_GSETTINGS).
3975 (xgselect_initialize): Ditto.
3976
3977 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3978 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3979 xg_select.
3980
bbc6b304
PE
39812011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3982
3983 * eval.c (struct backtrace): Simplify and port the data structure.
3984 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3985 signed bit field, as this assumption is not portable and it makes
3986 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3987 "char debug_on_exit : 1" as this is not portable either; instead,
3988 use the portable "unsigned int debug_on_exit : 1". Remove unused
3989 member evalargs. Remove obsolete comments about cc bombing out.
3990
9851bfc5
JD
39912011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3992
51bb811f 3993 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3994 Let HAVE_GSETTINGS override HAVE_GCONF.
3995 (store_monospaced_changed): New function.
3996 (EMACS_SETTINGS): A new type derived from GObject to handle
3997 GSettings notifications.
3998 (emacs_settings_constructor, emacs_settings_get_property)
3999 (emacs_settings_set_property, emacs_settings_class_init):
4000 New functions.
4001 (gsettings_client, gsettings_obj): New variables.
4002 (GSETTINGS_SCHEMA): New define.
4003 (something_changedCB): Call store_monospaced_changed.
4004 (init_gsettings): New function.
4005 (xsettings_initialize): Call init_gsettings.
4006 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4007 to NULL.
4008
640c8776 4009 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4010 GCONF_CFLAGS/LIBS.
4011
5386012d
MR
40122011-06-29 Martin Rudalics <rudalics@gmx.at>
4013
4014 * window.c (resize_root_window, grow_mini_window)
4015 (shrink_mini_window): Rename Qresize_root_window to
4016 Qwindow_resize_root_window and Qresize_root_window_vertically to
4017 Qwindow_resize_root_window_vertically.
4018
f13e0b08
PE
40192011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4020
4021 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4022
94515237
JB
40232011-06-27 Juanma Barranquero <lekktu@gmail.com>
4024
4025 * makefile.w32-in: Redesign dependencies so they reflect more
4026 clearly which files are directly included by each source file,
4027 and not through other includes.
4028
e43b6e43
MR
40292011-06-27 Martin Rudalics <rudalics@gmx.at>
4030
4031 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4032 (sort_overlays, overlay_strings): When an overlay's clone number
4033 matches the window's clone number process the overlay even if
4034 the overlay's window property doesn't match the current window.
4035
d68443dc
MR
4036 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4037 (Fwindow_hchild): Rename to Fwindow_left_child.
4038 (Fwindow_next): Rename to Fwindow_next_sibling.
4039 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4040 (resize_window_check): Rename to window_resize_check.
4041 (resize_window_apply): Rename to window_resize_apply.
4042 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4043 (Fdelete_other_windows_internal, resize_frame_windows)
4044 (Fsplit_window_internal, Fdelete_window_internal)
4045 (grow_mini_window, shrink_mini_window)
4046 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4047
c7e73be5
JD
40482011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4049
4050 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4051 (emacs_fixed_set_min_size): Remove.
4052 (emacs_fixed_new): Take frame as argument.
4053
4054 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4055 (_EmacsFixedPrivate): Remove minwidth/height.
4056 Add struct frame *f.
4057 (emacs_fixed_init): Initialize priv->f.
4058 (get_parent_class, emacs_fixed_set_min_size): Remove.
4059 (emacs_fixed_new): Set priv->f to argument.
4060 (emacs_fixed_get_preferred_width)
4061 (emacs_fixed_get_preferred_height): Use min_width/height from
4062 frames size_hint to set minimum and natural (Bug#8919).
4063 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4064 and use min_width/height from frames size_hint to set
4065 min_width/height (Bug#8919).
4066
4067 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4068 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4069 Fix indentation.
c7e73be5 4070
cf99dcf8
EZ
40712011-06-26 Eli Zaretskii <eliz@gnu.org>
4072
4073 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4074 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4075 called at ZV.
4076
029529ac
CY
40772011-06-26 Chong Yidong <cyd@stupidchicken.com>
4078
4079 * process.c (wait_reading_process_output): Bypass select if
4080 waiting for a cell while ignoring keyboard input, and input is
4081 pending. Suggested by Jan Djärv (Bug#8869).
4082
7a7ef429
PE
40832011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4084
4085 Use gnulib's dup2 module instead of rolling our own.
4086 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4087
11fdef7d 40882011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4089
4090 * dispnew.c (scrolling_window): Before scrolling, turn off a
4091 mouse-highlight in the window being scrolled.
4092
cd3520a4
JB
40932011-06-24 Juanma Barranquero <lekktu@gmail.com>
4094
4095 Move DEFSYM to lisp.h and use everywhere.
4096
4097 * character.h (DEFSYM): Move declaration...
4098 * lisp.h (DEFSYM): ...here.
4099
4100 * gnutls.c:
4101 * minibuf.c:
4102 * w32menu.c:
4103 * w32proc.c:
4104 * w32select.c: Don't include character.h.
4105
4106 * alloc.c (syms_of_alloc):
4107 * buffer.c (syms_of_buffer):
4108 * bytecode.c (syms_of_bytecode):
4109 * callint.c (syms_of_callint):
4110 * casefiddle.c (syms_of_casefiddle):
4111 * casetab.c (init_casetab_once):
4112 * category.c (init_category_once, syms_of_category):
4113 * ccl.c (syms_of_ccl):
4114 * cmds.c (syms_of_cmds):
4115 * composite.c (syms_of_composite):
4116 * dbusbind.c (syms_of_dbusbind):
4117 * dired.c (syms_of_dired):
4118 * dispnew.c (syms_of_display):
4119 * doc.c (syms_of_doc):
4120 * editfns.c (syms_of_editfns):
4121 * emacs.c (syms_of_emacs):
4122 * eval.c (syms_of_eval):
4123 * fileio.c (syms_of_fileio):
4124 * fns.c (syms_of_fns):
4125 * frame.c (syms_of_frame):
4126 * fringe.c (syms_of_fringe):
4127 * insdel.c (syms_of_insdel):
4128 * keymap.c (syms_of_keymap):
4129 * lread.c (init_obarray, syms_of_lread):
4130 * macros.c (syms_of_macros):
4131 * msdos.c (syms_of_msdos):
4132 * print.c (syms_of_print):
4133 * process.c (syms_of_process):
4134 * search.c (syms_of_search):
4135 * sound.c (syms_of_sound):
4136 * syntax.c (init_syntax_once, syms_of_syntax):
4137 * terminal.c (syms_of_terminal):
4138 * textprop.c (syms_of_textprop):
4139 * undo.c (syms_of_undo):
4140 * w32.c (globals_of_w32):
4141 * window.c (syms_of_window):
4142 * xdisp.c (syms_of_xdisp):
4143 * xfaces.c (syms_of_xfaces):
4144 * xfns.c (syms_of_xfns):
4145 * xmenu.c (syms_of_xmenu):
4146 * xsettings.c (syms_of_xsettings):
4147 * xterm.c (syms_of_xterm): Use DEFSYM.
4148
4228cf16
TZ
41492011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4150
cd3520a4 4151 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4152
7fcccf1e
PE
41532011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4154
7efb4e0e
PE
4155 Integer and buffer overflow fixes (Bug#8873).
4156
ff5844ad
PE
4157 * print.c (printchar, strout): Check for string overflow.
4158 (PRINTPREPARE, printchar, strout):
4159 Don't set size unless allocation succeeds.
4160
90532f02
PE
4161 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4162 for sizes. Check for string overflow more accurately.
4163 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4164
6d84508d
PE
4165 * macros.c: Integer and buffer overflow fixes.
4166 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4167 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4168 Use ptrdiff_t, not int, for sizes.
4169 Don't increment bufsize until after realloc succeeds.
4170 Check for size-calculation overflow.
4171 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4172
437b2cb4
PE
4173 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4174
8b9ac8b4
PE
4175 * lread.c: Integer overflow fixes.
4176 (read_integer): Radix is now EMACS_INT, not int,
4177 to improve quality of diagnostics for out-of-range radices.
4178 Calculate buffer size correctly for out-of-range radices.
4179 (read1): Check for integer overflow in radices, and in
4180 read-circle numbers.
82cb60d3
PE
4181 (read_escape): Avoid int overflow.
4182 (Fload, openp, read_buffer_size, read1)
4183 (substitute_object_recurse, read_vector, read_list, map_obarray):
4184 Use ptrdiff_t, not int, for sizes.
4185 (read1): Use EMACS_INT, not int, for sizes.
20270765 4186 Check for size overflow.
8b9ac8b4 4187
7fcccf1e
PE
4188 * image.c (cache_image): Check for size arithmetic overflow.
4189
bfbbd7e7
PE
4190 * lread.c: Integer overflow issues.
4191 (saved_doc_string_size, saved_doc_string_length)
4192 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4193 Now ptrdiff_t, not int.
4194 (read1): Don't assume doc string length fits in int. Check for
4195 out-of-range doc string lengths.
4196 (read_list): Don't assume file position fits in int.
39019e54 4197 (read_escape): Check for hex character overflow.
bfbbd7e7 4198
4e323265
LL
41992011-06-22 Leo Liu <sdl.web@gmail.com>
4200
4201 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4202 Move to minibuffer.el.
4203
85fece3e
PE
42042011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4205
20b84ce9 4206 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4207 The following patches are for when GLYPH_DEBUG && !XASSERT.
4208 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4209 * dispnew.c (flush_stdout):
4210 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4211 Mark as externally visible.
4212 * dispnew.c (check_window_matrix_pointers): Now static.
4213 * dispnew.c (window_to_frame_vpos):
4214 * xfns.c (unwind_create_frame):
4215 * xterm.c (x_check_font): Remove unused local.
4216 * scroll.c (CHECK_BOUNDS):
4217 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4218 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4219 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4220 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4221 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4222 Now static.
4223 (debug_method_add): Use va_list and vsprintf rather than relying
4224 on undefined behavior with wrong number of arguments.
4225 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4226 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4227 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4228 since we're not interested in debugging glyphs with old libraries.
4229 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4230 GCC 4.6.0's static checking.
4231
0766b489
PE
42322011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4233
31fd4b32
PE
4234 Integer overflow and signedness fixes (Bug#8873).
4235 A few related buffer overrun fixes, too.
4236
b79e8648
PE
4237 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4238
0766b489
PE
4239 * dispextern.h (struct face.stipple):
4240 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4241 (x_bitmap_mask, x_allocate_bitmap_record)
4242 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4243 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4244 (x_create_bitmap_from_xpm_data):
4245 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4246 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4247 (.bitmaps_last):
4248 * xfaces.c (load_pixmap):
4249 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4250 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4251 (.bitmaps_last, struct x_output.icon_bitmap):
4252 Use ptrdiff_t, not int, for bitmap indexes.
4253 (x_allocate_bitmap_record): Check for size overflow.
4254 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4255
b081724f
PE
4256 Use ptrdiff_t, not int, for overlay counts.
4257 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4258 * editfns.c (overlays_around, get_pos_property):
4259 * textprop.c (get_char_property_and_overlay):
4260 * xdisp.c (next_overlay_change, note_mouse_highlight):
4261 * xfaces.c (face_at_buffer_position):
21514da7
PE
4262 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4263 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4264 (Fnext_overlay_change, Fprevious_overlay_change)
4265 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4266 Use ptrdiff_t, not int, for sizes.
21514da7 4267 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4268
3de73e5e
PE
4269 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4270
2606c57b
PE
4271 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4272 (x_session_initialize): Do not assume string length fits in int.
4273
aaafe47a
PE
4274 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4275 This is unlikely, but can occur if DPI is outlandish.
4276
2674ddc8 4277 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4278 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4279
28154962
PE
4280 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4281 * xrdb.c (magic_file_p, search_magic_path):
4282 Omit last arg SUFFIX; it was always 0. All callers changed.
4283 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4284
7de51af5
PE
4285 * xfont.c (xfont_match): Avoid need for strlen.
4286
25ed6cc3
PE
4287 * xfns.c: Don't assume strlen fits in int.
4288 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4289
4eab31dd
PE
4290 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4291 not unsigned long, as we prefer signed integers. All callers changed.
4292 Detect integer overflow in repeat count.
4293 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4294 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4295
171e2a58
PE
4296 * termcap.c: Don't assume sizes fit in int and never overflow.
4297 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4298 (gobble_line): Check for size-calculation overflow.
4299
ad39faca 4300 * minibuf.c (Fread_buffer):
6e5bb2dc 4301 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4302 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4303 Don't assume string length fits in int.
4304
52c61c22 4305 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4306 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4307
b5b8c9e5
PE
4308 * font.c: Don't assume string length fits in int.
4309 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4310 Use ptrdiff_t, not int.
ccd6111c
PE
4311 (font_intern_prop): Don't assume string length fits in int.
4312 Don't assume integer property fits in fixnum.
4313 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4314
882f0d81 4315 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4316 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4317 Reformulate so as not to need the command string.
4318 Invoke gzip -cd rather than gunzip, as it's more portable.
4319 (lock_info_type, lock_file_1, lock_file):
4320 Don't assume pid_t and time_t fit in unsigned long.
4321 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4322 (current_lock_owner): Prefer signed type for sizes.
4323 Use memcpy, not strncpy, where memcpy is what is really wanted.
4324 Don't assume (via atoi) that time_t and pid_t fit in int.
4325 Check for time_t and/or pid_t out of range, e.g., via a network share.
4326 Don't alloca where an auto var works fine.
4327
93f4cf88
PE
4328 * fileio.c: Fix some integer overflow issues.
4329 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4330 Don't assume string length fits in int.
4331 (directory_file_name): Don't assume string length fits in long.
4332 (make_temp_name): Don't assume pid fits in int, or that its print
4333 length is less than 20.
4334
f3e92b69
PE
4335 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4336
1bfdaf10
PE
4337 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4338
35016e9a
PE
4339 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4340
3d1e65a1
PE
4341 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4342 We prefer signed integers, even for size calculations.
4343
0b963a93
PE
4344 * emacs.c: Don't assume string length fits in 'int'.
4345 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4346 (main): Don't invoke strlen when not needed.
4347
573f4b54
PE
4348 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4349 (XD_DEBUG_MESSAGE): Don't waste a byte.
4350
989f33ba
PE
4351 * callproc.c (getenv_internal_1, getenv_internal)
4352 (Fgetenv_internal):
965d34eb
PE
4353 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4354
e4d29b33
PE
4355 * lread.c (invalid_syntax): Omit length argument.
4356 All uses changed. This doesn't fix a bug, but it simplifies the
4357 code away from its former Hollerith-constant appearance, and it's
4358 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4359 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4360
eb49b136
PE
4361 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4362 This didn't break anything, but it didn't help either.
4363 It's confusing to put a bogus integer in a place where the actual
4364 value does not matter.
9f62aeb1 4365 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4366 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4367
15375a22
PE
4368 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4369 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4370 implementation.
b61cc01c
PE
4371 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4372 We prefer signed types, and the value cannot exceed the EMACS_INT
4373 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4374 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4375 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4376 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4377
53b2623d
PE
4378 * indent.c (sane_tab_width): New function.
4379 (current_column, scan_for_column, Findent_to, position_indentation)
4380 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4381 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4382
51cab52b 4383 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4384
f2ed8a70
PE
4385 * lisp.h (lint_assume): New macro.
4386 * composite.c (composition_gstring_put_cache):
4387 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4388
abe80cc6
PE
4389 * editfns.c, insdel.c:
4390 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4391
b02c740e
PE
4392 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4393
ebc96716
PE
4394 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4395
b4e50fa0 4396 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4397 Use much-faster test for byte-length change.
311d5d7c 4398 Don't assume string byte-length fits in 'int'.
a4cf38e4 4399 Check that character arg fits in 'int'.
85461888 4400 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4401
c0c1ee9f
PE
4402 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4403
a498d7f4
PE
4404 * fns.c (concat): Catch string overflow earlier.
4405 Do not rely on integer wraparound.
4406
51cab52b
PE
4407 * dispextern.h (struct it.overlay_strings_charpos)
4408 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4409 * xdisp.c (forward_to_next_line_start)
4410 (back_to_previous_visible_line_start)
4411 (reseat_at_next_visible_line_start, next_element_from_buffer):
4412 Don't arbitrarily truncate the value of 'selective' to int.
4413
76031fad
PE
4414 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4415
5eb55db9
PE
4416 * composite.c: Don't truncate sizes to 'int'.
4417 (composition_gstring_p, composition_reseat_it)
4418 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4419 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4420 not EMACS_UINT, for indexes.
5eb55db9 4421
0703a717
PE
4422 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4423
d6202519
PE
4424 * buffer.c: Include <verify.h>.
4425 (struct sortvec.priority, struct sortstr.priority):
8961a454 4426 Now EMACS_INT, not int.
c20998a7 4427 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4428 (struct sortstr.size, record_overlay_string)
4429 (struct sortstrlist.size, struct sortlist.used):
4430 Don't truncate size to int.
4431 (record_overlay_string): Check for size-calculation overflow.
d6202519 4432 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4433
d5a19415
JM
44342011-06-22 Jim Meyering <meyering@redhat.com>
4435
029529ac 4436 Don't leak an XBM-image-sized buffer
d5a19415
JM
4437 * image.c (xbm_load): Free the image buffer after using it.
4438
a9041e6c
PE
44392011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4440
4441 Port to Sun C.
4442 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4443 that Sun C diagnosed.
4444 * fns.c (secure_hash): Fix pointer signedness issue.
4445 * intervals.c (static_offset_intervals): New function.
4446 (offset_intervals): Use it.
4447
7f3f739f
LL
44482011-06-21 Leo Liu <sdl.web@gmail.com>
4449
4450 * deps.mk (fns.o):
4451 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4452 sha512.h.
4453
4454 * fns.c (secure_hash): Rename from crypto_hash_function and change
4455 the first arg to accept symbols.
5b66d427 4456 (Fsecure_hash): New primitive.
7f3f739f
LL
4457 (syms_of_fns): New symbols.
4458
76147d94
DD
44592011-06-20 Deniz Dogan <deniz@dogan.se>
4460
4461 * process.c (Fset_process_buffer): Clarify return value in
4462 docstring.
4463
7d7d0045
CY
44642011-06-18 Chong Yidong <cyd@stupidchicken.com>
4465
4466 * dispnew.c (add_window_display_history): Use BVAR.
4467
4468 * xdisp.c (debug_method_add): Use BVAR.
4469 (check_window_end, dump_glyph_matrix, dump_glyph)
4470 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4471
4472 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4473 Likewise.
4474
4475 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4476 check till after the cache is created in init_frame_faces.
4477
ff2bc410
SM
44782011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4479
4480 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4481
28177add
PE
44822011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4483
dd3482fe
PE
4484 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4485 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4486 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4487
393d71f3 4488 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4489 * fileio.c (Finsert_file_contents):
4490 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4491 Remove the old (too-loose) buffer overflow checks.
4492 They weren't needed, since make_gap checks for buffer overflow.
4493 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4494 The old code merely checked for Emacs fixnum overflow, and relied
4495 on undefined (wraparound) behavior. The new code avoids undefined
4496 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4497
2e6813b0 4498 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4499 Tune. Don't use wider integers than needed. Don't use alloca.
4500 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4501
599a9e4f
PE
4502 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4503
99561444
PE
4504 * insdel.c, lisp.h (buffer_overflow): New function.
4505 (insert_from_buffer_1, replace_range, replace_range_2):
4506 * insdel.c (make_gap_larger):
4507 * editfns.c (Finsert_char):
4508 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4509
28177add
PE
4510 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4511
e69dafad
PE
45122011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4513
4baa020d 4514 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4515
b1c46f02
PE
4516 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4517 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4518
e69dafad
PE
4519 * fileio.c: Don't assume EMACS_INT fits in off_t.
4520 (emacs_lseek): New static function.
4521 (Finsert_file_contents, Fwrite_region): Use it.
4522 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4523
566684ea
PE
4524 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4525
e6966cd6
PE
4526 * fns.c: Don't overflow int when computing a list length.
4527 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4528 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4529 truncation on 64-bit hosts. Check for QUIT every
4530 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4531 faster and is responsive enough.
4532 (Flength): Report an error instead of overflowing an integer.
4533 (Fsafe_length): Return a float if the value is not representable
4534 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4535 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4536 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4537
dd0b0efb
PE
4538 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4539 (header_size, word_size): New constants.
4540 (allocate_vectorlike): Don't check size overflow here.
4541 (allocate_vector): Check it here instead, since this is the only
4542 caller of allocate_vectorlike that could cause overflow.
4543 Check that the new vector's length is representable as a fixnum.
4544
86fe5cfe
PE
4545 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4546 The previous code was bogus. For example, next_almost_prime (32)
4547 returned 39, which is undesirable as it is a multiple of 3; and
4548 next_almost_prime (24) returned 25, which is a multiple of 5 so
4549 why was the code bothering to check for multiples of 7?
4550
80e88859
PE
4551 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4552
4a2f0ad6
PE
4553 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4554
f66c7cf8
PE
4555 Variadic C functions now count arguments with ptrdiff_t.
4556 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4557 Back then I didn't know that the Emacs coding style prefers signed int.
4558 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4559 were being counted with int, which may truncate counts on 64-bit
4560 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4561 * lisp.h (struct Lisp_Subr.function.aMANY)
4562 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4563 Arg counts are now ptrdiff_t, not size_t.
4564 All variadic functions and their callers changed accordingly.
4565 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4566 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4567 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4568 * callint.c (Fcall_interactively): Check arg count for overflow,
4569 to avoid potential buffer overrun. Use signed char, not 'int',
4570 for 'varies' array, so that we needn't bother to check its size
4571 calculation for overflow.
4572 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4573 * eval.c (apply_lambda):
4574 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4575 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4576 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4577
a1759b76
PE
4578 * callint.c (Fcall_interactively): Don't use index var as event count.
4579
d96be9fc
PE
4580 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4581 * mem-limits.h (SIZE): Remove; no longer used.
4582
a690a978 4583 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4584
578c21e6
PE
4585 Remove unnecessary casts.
4586 * xterm.c (x_term_init):
4587 * xfns.c (x_set_border_pixel):
4588 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4589 These aren't needed now that we assume ANSI C.
4590
96f53c6c
PE
4591 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4592 It's more likely to cause problems (due to unsigned overflow)
4593 than to cure them.
4594
83c77d31
PE
4595 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4596
ee2079f1
PE
4597 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4598
6da65536
PE
4599 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4600
7147c4a4
PE
4601 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4602
193e32d9
PE
4603 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4604
e5533da6
PE
4605 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4606
9910e595
PE
4607 GLYPH_CODE_FACE returns EMACS_INT, not int.
4608 * dispextern.h (merge_faces):
4609 * xfaces.c (merge_faces):
01103c44
PE
4610 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4611 Don't assume EMACS_INT fits in int.
9910e595 4612
2638320e
PE
4613 * character.h (CHAR_VALID_P): Remove unused parameter.
4614 * fontset.c, lisp.h, xdisp.c: All uses changed.
4615
045eb8d9
PE
4616 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4617
c1f134b5
PE
4618 * fns.c (concat): Minor tuning based on overflow analysis.
4619 This doesn't fix any bugs. Use int to hold character, instead
4620 of constantly refetching from Emacs object. Use XFASTINT, not
4621 XINT, for value known to be a character. Don't bother comparing
4622 a single byte to 0400, as it's always less.
4623
395fcb93 4624 * floatfns.c (Fexpt):
327eeec8
PE
4625 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4626
abbd3d23
PE
4627 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4628 for characters.
4629
684a03ef
PE
4630 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4631
0fed43f3
PE
4632 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4633 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4634 incorrectly succeed when S was a string, because 4294967386 was
4635 truncated before it was used.
4636
8fd02eb7
PE
4637 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4638 Otherwise, an out-of-range integer could cause undefined behavior
4639 on a 64-bit host.
4640
f8c86b69
PE
4641 * composite.c: Use int, not EMACS_INT, for characters.
4642 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4643 EMACS_INT, for values that are known to be in character range.
4644 This doesn't fix any bugs but is the usual style inside Emacs and
4645 may generate better code on 32-bit machines.
4646
34206dd2
PE
4647 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4648 This is for reasons similar to the recent CHAR_STRING fix.
4649 * charset.c (Fencode_char): Check that character arg is actually
4650 a character. Pass an int to ENCODE_CHAR.
4651 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4652 wider than 'int', as a compile-time check to prevent future regressions
4653 in this area.
4654
c5958d4c 4655 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4656
4657 Make sure a 64-bit char is never passed to CHAR_STRING.
4658 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4659 by silently ignoring the top 32 bits, allowing some values
4660 that were far too large to be valid characters.
4661 * character.h: Include <verify.h>.
4662 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4663 arguments are no wider than unsigned, as a compile-time check
4664 to prevent future regressions in this area.
4665 * data.c (Faset):
01103c44 4666 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4667 (Fsubst_char_in_region):
4668 * fns.c (concat):
4669 * xdisp.c (decode_mode_spec_coding):
4670 Adjust to CHAR_STRING's new requirement.
4671 * editfns.c (Finsert_char, Fsubst_char_in_region):
4672 * fns.c (concat): Check that character args are actually
4673 characters. Without this test, these functions did the wrong
4674 thing with wildly out-of-range values on 64-bit hosts.
4675
d37ca623
PE
4676 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4677 These casts should not be needed on 32-bit hosts, either.
4678 * keyboard.c (read_char):
4679 * lread.c (Fload): Remove casts to unsigned.
4680
ea204efb
PE
4681 * lisp.h (UNSIGNED_CMP): New macro.
4682 This fixes comparison bugs on 64-bit hosts.
4683 (ASCII_CHAR_P): Use it.
4684 * casefiddle.c (casify_object):
01103c44 4685 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4686 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4687 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4688 * dispextern.h (FACE_FROM_ID):
4689 * keyboard.c (read_char): Use UNSIGNED_CMP.
4690
41cb286c
PE
4691 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4692 not to EMACS_INT, to avoid GCC warning.
4693
4a1b9832
PE
4694 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4695
55daad71
PE
4696 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4697 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4698 isn't needed on 32-bit machines.
8f95c75c 4699
01103c44
PE
4700 * buffer.c (Fgenerate_new_buffer_name):
4701 Use EMACS_INT for count, not int.
0ceccced 4702 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4703
4704 * data.c (Qcompiled_function): Now static.
4705
c6f072e7
PE
4706 * window.c (window_body_lines): Now static.
4707
20ce5912
PE
4708 * image.c (gif_load): Rename local to avoid shadowing.
4709
9c4c5f81
PE
4710 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4711 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4712 * alloc.c (make_save_value): Integer argument is now of type
4713 ptrdiff_t, not int.
4714 (mark_object): Use ptrdiff_t, not int.
4715 * lisp.h (pD): New macro.
4716 * print.c (print_object): Use it.
4717
c0c5c8ae
PE
4718 * alloc.c: Use EMACS_INT, not int, to count objects.
4719 (total_conses, total_markers, total_symbols, total_vector_size)
4720 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4721 (total_free_floats, total_floats, total_free_intervals)
4722 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4723 Now EMACS_INT, not int. All uses changed.
4724 (Fgarbage_collect): Compute overall total using a double, so that
4725 integer overflow is less likely to be a problem. Check for overflow
4726 when converting back to an integer.
5a25e253
PE
4727 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4728 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4729 These were 'int' variables that could overflow on 64-bit hosts;
4730 they were never used, so remove them instead of repairing them.
211a0b2a 4731 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4732 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4733 Previously, this ceilinged at INT_MAX, but that doesn't work on
4734 64-bit machines.
e46bb31a 4735 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4736
c78baabf 4737 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4738 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4739 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4740 when a (possibly-narrower) signed value would do just as well.
4741 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4742
c9d624c6
PE
4743 * alloc.c: Catch some string size overflows that we were missing.
4744 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4745 for convenience in STRING_BYTES_MAX.
4746 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4747 The definition here is exact; the one in lisp.h was approximate.
4748 (allocate_string_data): Check for string overflow. This catches
4749 some instances we weren't catching before. Also, it catches
4750 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4751 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4752 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4753
c9d624c6
PE
4754 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4755 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4756 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4757
353032ce
PE
4758 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4759
2bccce07
PE
4760 * alloc.c (Fmake_string): Check for out-of-range init.
4761
0ac30604
SM
47622011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4763
4764 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4765
c195f2de
JD
47662011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4767
4768 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4769 xg_get_default_scrollbar_width.
4770
4771 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4772 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4773 (style_changed_cb): Call update_theme_scrollbar_width and call
4774 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4775 all frames (Bug#8505).
4776 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4777 Call gtk_window_set_resizable if HAVE_GTK3.
4778 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4779 and height if HAVE_GTK3 (Bug#8505).
4780 (scroll_bar_width_for_theme): New variable.
4781 (update_theme_scrollbar_width): New function.
4782 (xg_get_default_scrollbar_width): Move code to
4783 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4784 (xg_initialize): Call update_theme_scrollbar_width.
4785
4786 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4787
4788 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4789
e10ac9f1
MR
47902011-06-12 Martin Rudalics <rudalics@gmx.at>
4791
4792 * frame.c (make_frame): Call other_buffer_safely instead of
4793 other_buffer.
4794
4795 * window.c (temp_output_buffer_show): Call display_buffer with
4796 second argument Vtemp_buffer_show_specifiers and reset latter
4797 immediately after the call.
4798 (Vtemp_buffer_show_specifiers): New variable.
4799 (auto_window_vscroll_p, next_screen_context_lines)
4800 (Vscroll_preserve_screen_position): Remove leading asterisks from
4801 doc-strings.
4802
2d3c217e 48032011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4804
7b7f97e8 4805 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4806 * buffer.c (Qclone_number): Remove for now, as it's unused.
4807 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4808 (record_buffer): Remove unused local.
4809 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4810 (set_frame_buffer_list): Remove; unused.
4811 * frame.h (other_visible_frames): Remove decl.
4812 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4813 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4814 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4815 if HAVE_GPM.
4816 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4817 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4818 Define only if HAVE_GPM.
4819 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4820 (update_hints_inhibit): Remove; never set. All uses removed.
4821 * widgetprv.h (emacsFrameClassRec): Remove decl.
4822 * window.c (delete_deletable_window): Now returns void, since it
4823 wasn't returning anything.
4824 (compare_window_configurations): Remove unused locals.
4825 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4826 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4827 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4828 the same widths as pointers. This follows up on the 2011-05-06 patch.
4829 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4830 * xterm.h: Likewise.
4831 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4832
1384b89e
JB
48332011-06-12 Juanma Barranquero <lekktu@gmail.com>
4834
4835 * makefile.w32-in: Update dependencies.
4836 (LISP_H): Add lib/intprops.h.
4837
1100a63c
CY
48382011-06-11 Chong Yidong <cyd@stupidchicken.com>
4839
4840 * image.c (gif_load): Add animation frame delay to the metadata.
4841 (syms_of_image): Use DEFSYM. New symbol `delay'.
4842
6198ccd0
MR
48432011-06-11 Martin Rudalics <rudalics@gmx.at>
4844
4845 * window.c (delete_deletable_window): Re-add.
4846 (Fset_window_configuration): Rewrite to handle dead buffers and
4847 consequently deletable windows.
4848 (window_tree, Fwindow_tree): Remove. Supply functionality in
4849 window.el.
4850 (compare_window_configurations): Simplify code.
4851
b6e3633c
AS
48522011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4853
1ab0dee5
AS
4854 * image.c (imagemagick_load_image): Fix type mismatch.
4855 (Fimagemagick_types): Likewise.
4856
b6e3633c
AS
4857 * window.h (replace_buffer_in_windows): Declare.
4858
9397e56f
MR
48592011-06-11 Martin Rudalics <rudalics@gmx.at>
4860
4861 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4862 Qclone_number. Remove external declaration of Qdelete_window.
4863 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4864 code.
640c8776
SM
4865 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4866 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4867 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4868 buffer list implementation.
4869 (other_buffer_safely): New function.
4870 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4871 calls to replace_buffer_in_windows and
4872 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4873 if allowed.
4874 (record_buffer): Inhibit quitting and rewrite using quittable
4875 functions. Run Qbuffer_list_update_hook if allowed.
4876 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4877 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4878 Move switch-to-buffer to window.el.
9397e56f
MR
4879 (bury-buffer): Move to window.el.
4880 (Vbuffer_list_update_hook): New variable.
4881
4882 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4883 section.
4884
4885 * window.h (resize_frame_windows): Move up in code.
4886 (Fwindow_frame): Remove EXFUN.
4887 (replace_buffer_in_all_windows): Remove prototype.
4888 (replace_buffer_in_windows_safely): Add prototype.
4889
4890 * window.c: Declare Qdelete_window static again. Move down
4891 declaration of select_count.
4892 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4893 (Fother_window): Move to window.el.
4894 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4895 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4896 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4897 window.el.
4898 (replace_buffer_in_windows): Implement by calling
4899 Qreplace_buffer_in_windows.
4900 (replace_buffer_in_all_windows): Remove with some functionality
4901 moved into replace_buffer_in_windows_safely.
4902 (replace_buffer_in_windows_safely): New function.
4903 (select_window_norecord, select_frame_norecord): Move in front
4904 of run_window_configuration_change_hook. Remove now obsolete
4905 declarations.
640c8776
SM
4906 (Fset_window_buffer): Rewrite doc-string.
4907 Call Qrecord_window_buffer.
9397e56f
MR
4908 (keys_of_window): Move binding for other-window to window.el.
4909
b50691aa
CY
49102011-06-11 Chong Yidong <cyd@stupidchicken.com>
4911
4912 * dispextern.h (struct image): Replace data member, whose int_val
4913 and ptr_val fields were not used by anything, with a single
4914 lisp_val object.
4915
4916 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4917 (gif_clear_image, gif_load, imagemagick_load_image)
4918 (gs_clear_image, gs_load): Callers changed.
4919
3f754b86
PE
49202011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4921
cca69397
PE
4922 * buffer.h: Include <time.h>, for time_t.
4923 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4924
109e28d0
PE
4925 Fix minor problems found by static checking.
4926
60737f02
PE
4927 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4928
4b66faf3
PE
4929 Make identifiers static if they are not used in other modules.
4930 * data.c (Qcompiled_function, Qframe, Qvector):
4931 * image.c (QimageMagick, Qsvg):
4932 * minibuf.c (Qmetadata):
4933 * window.c (resize_window_check, resize_root_window): Now static.
4934 * window.h (resize_window_check, resize_root_window): Remove decls.
4935
109e28d0
PE
4936 * window.c (window_deletion_count, delete_deletable_window):
4937 Remove; unused.
46a4ce9e
PE
4938 (window_body_lines): Now static.
4939 (Fdelete_other_windows_internal): Mark vars as initialized.
4940 Make sure 'resize_failed' is initialized.
4941 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4942 (resize_window_apply): Remove unused local.
4943 * window.h (delete_deletable_window): Remove decl.
4944
109e28d0 4945 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4946 (imagemagick_load_image): Fix pointer signedness problem by changing
4947 last arg from unsigned char * to char *. All uses changed.
4948 Also, fix a local for similar reasons.
4949 Remove unused locals. Remove locals to avoid shadowing.
4950 (fn_rsvg_handle_free): Remove; unused.
4951 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4952 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4953
3f754b86
PE
4954 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4955
2547adb1
CY
49562011-06-10 Chong Yidong <cyd@stupidchicken.com>
4957
4958 * image.c (gif_load): Fix omitted cast error introduced by
4959 2011-06-06 change.
4960
2c8e37d4
MR
49612011-06-10 Martin Rudalics <rudalics@gmx.at>
4962
4963 * window.h (resize_proportionally, orig_total_lines)
4964 (orig_top_line): Remove from window structure.
4965 (set_window_height, set_window_width, change_window_heights)
4966 (Fdelete_window): Remove prototypes.
4967 (resize_frame_windows): Remove duplicate declaration.
4968
440a42e3
EZ
49692011-06-10 Eli Zaretskii <eliz@gnu.org>
4970
4971 * window.h (resize_frame_windows, resize_window_check)
4972 (delete_deletable_window, resize_root_window)
4973 (resize_frame_windows): Declare prototypes.
4974
4975 * window.c (resize_window_apply): Make definition be "static" to
4976 match the prototype.
4977
562dd5e9
MR
49782011-06-10 Martin Rudalics <rudalics@gmx.at>
4979
4980 * window.c: Remove declarations of Qwindow_size_fixed,
4981 window_min_size_1, window_min_size_2, window_min_size,
4982 size_window, window_fixed_size_p, enlarge_window, delete_window.
4983 Remove static from declaration of Qdelete_window, it's
4984 temporarily needed by Fbury_buffer.
4985 (replace_window): Don't assign orig_top_line and
4986 orig_total_lines.
4987 (Fdelete_window, delete_window): Remove. Window deletion is
4988 handled by window.el.
640c8776
SM
4989 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4990 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4991 (Fdelete_other_windows): Remove. Deleting other windows is
4992 handled by window.el.
4993 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4994 handled in window.el.
4995 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4996 Window minimum sizes are handled in window.el.
4997 (shrink_windows, size_window, set_window_height)
4998 (set_window_width, change_window_heights, window_height)
4999 (window_width, CURBEG, CURSIZE, enlarge_window)
5000 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5001 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5002 handled in window.el.
5003 (make_dummy_parent): Rename to make_parent_window and give it a
5004 second argument horflag.
5005 (make_window): Don't set resize_proportionally any more.
5006 (Fsplit_window): Remove. Windows are split in window.el.
5007 (save_restore_action, save_restore_orig_size)
5008 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5009 Resize mini windows in window.el.
5010 (grow_mini_window, shrink_mini_window): Implement by calling
5011 Qresize_root_window_vertically, resize_window_check and
5012 resize_window_apply.
640c8776
SM
5013 (saved_window, Fset_window_configuration, save_window_save):
5014 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5015 resize_proportionally.
5016 (window_min_height, window_min_width): Move to window.el.
5017 (keys_of_window): Move bindings for delete-other-windows,
5018 split-window, delete-window and enlarge-window to window.el.
5019
5020 * buffer.c: Temporarily extern Qdelete_window.
5021 (Fbury_buffer): Temporarily call Qdelete_window instead of
5022 Fdelete_window (Fbury_buffer will move to window.el soon).
5023
5024 * frame.c (set_menu_bar_lines_1): Remove code handling
5025 orig_top_line and orig_total_lines.
5026
5027 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5028 set_window_height but set heights directly.
5029 (change_frame_size_1): Use resize_frame_windows.
5030
5031 * xdisp.c (init_xdisp): Don't use set_window_height but set
5032 heights directly.
5033
640c8776
SM
5034 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5035 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5036 run_window_configuration_change_hook.
5037
5038 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5039 instead of change_window_heights and run
5040 run_window_configuration_change_hook.
5041
1a13852e
MR
50422011-06-09 Martin Rudalics <rudalics@gmx.at>
5043
5044 * window.c (replace_window): Rename second argument REPLACEMENT to
5045 NEW. New third argument SETFLAG. Rewrite.
5046 (delete_window, make_dummy_parent): Call replace_window with
5047 third argument 1.
5048 (window_list_1): Move down in code.
5049 (run_window_configuration_change_hook): Move set_buffer part
5050 before select_frame_norecord part in order to unwind correctly.
5051 Rename count1 to count.
5052 (recombine_windows, delete_deletable_window, resize_root_window)
5053 (Fdelete_other_windows_internal)
5054 (Frun_window_configuration_change_hook, make_parent_window)
5055 (resize_window_check, resize_window_apply, Fresize_window_apply)
5056 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5057 (Fdelete_window_internal, Fresize_mini_window_internal):
5058 New functions.
1a13852e
MR
5059 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5060
f3d1777e
MR
50612011-06-08 Martin Rudalics <rudalics@gmx.at>
5062
496e208e
MR
5063 * window.h (window): Add some new members to window structure -
5064 normal_lines, normal_cols, new_total, new_normal, clone_number,
5065 splits, nest, prev_buffers, next_buffers.
5066 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5067 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5068
f3d1777e
MR
5069 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5070 Remove.
496e208e
MR
5071 (make_dummy_parent): Set new members of windows structure.
5072 (make_window): Move down in code. Handle new members of window
5073 structure.
5074 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5075 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5076 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5077 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5078 (Fset_window_next_buffers, Fset_window_clone_number):
5079 New functions.
496e208e
MR
5080 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5081 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5082 Doc-string fixes.
5083 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5084 Argument WINDOW can be now internal window too.
5085 (Fwindow_use_time): Move up in code.
5086 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5087 Rewrite doc-string.
5088 (Fset_window_configuration, saved_window)
5089 (Fcurrent_window_configuration, save_window_save): Handle new
5090 members of window structure.
b9e809c2
MR
5091 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5092 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5093 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5094 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5095 Qget_mru_window, Qresize_root_window,
5096 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5097 Qauto_buffer_name; staticpro them.
f3d1777e 5098
abde8f8c
MR
50992011-06-07 Martin Rudalics <rudalics@gmx.at>
5100
5101 * window.c (Fwindow_total_size, Fwindow_left_column)
5102 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5103 (Fwindow_list_1): New functions.
5104 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5105 (Fwindow_width, Fscroll_left, Fscroll_right):
5106 Use window_body_cols instead of window_box_text_cols.
5107 (delete_window, Fset_window_configuration):
5108 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5109 (delete_all_subwindows): Take a window as argument and not a
5110 structure. Rewrite.
190b47e6
MR
5111 (window_loop): Remove handling of GET_LRU_WINDOW and
5112 GET_LARGEST_WINDOW.
5113 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5114
5115 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5116 window_box_text_cols. delete_all_subwindows now takes a
5117 Lisp_Object as argument.
abde8f8c 5118
640c8776
SM
5119 * indent.c (compute_motion, Fcompute_motion):
5120 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5121
fa8a67e6
MR
5122 * frame.c (delete_frame): Call delete_all_subwindows with root
5123 window as argument.
5124
a54e3482
DC
51252011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5126
5127 * fns.c (Fputhash): Document return value.
5128
60002bf5
CY
51292011-06-06 Chong Yidong <cyd@stupidchicken.com>
5130
5131 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5132
0c671da6 51332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5134
b862a52a 5135 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5136
be44ca6c
PE
5137 Check for overflow when converting integer to cons and back.
5138 * charset.c (Fdefine_charset_internal, Fdecode_char):
5139 Use cons_to_unsigned to catch overflow.
5140 (Fencode_char): Use INTEGER_TO_CONS.
5141 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5142 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5143 * data.c (long_to_cons, cons_to_long): Remove.
5144 (cons_to_unsigned, cons_to_signed): New functions.
5145 These signal an error for invalid or out-of-range values.
5146 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5147 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5148 * font.c (Ffont_variation_glyphs):
5149 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5150 * lisp.h: Include <intprops.h>.
5151 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5152 (cons_to_signed, cons_to_unsigned): New decls.
5153 (long_to_cons, cons_to_long): Remove decls.
5154 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5155 (Fprimitive_undo): Use CONS_TO_INTEGER.
5156 * xfns.c (Fx_window_property): Likewise.
5157 * xselect.c: Include <limits.h>.
5158 (x_own_selection, selection_data_to_lisp_data):
5159 Use INTEGER_TO_CONS.
5160 (x_handle_selection_request, x_handle_selection_clear)
5161 (x_get_foreign_selection, Fx_disown_selection_internal)
5162 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5163 (lisp_data_to_selection_data): Use cons_to_unsigned.
5164 (x_fill_property_data): Use cons_to_signed.
5165 Report values out of range.
5166
d1f3d2af
PE
5167 Check for buffer and string overflow more precisely.
5168 * buffer.h (BUF_BYTES_MAX): New macro.
5169 * lisp.h (STRING_BYTES_MAX): New macro.
5170 * alloc.c (Fmake_string):
5171 * character.c (string_escape_byte8):
5172 * coding.c (coding_alloc_by_realloc):
5173 * doprnt.c (doprnt):
5174 * editfns.c (Fformat):
5175 * eval.c (verror):
5176 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5177 since they may not be the same number.
5178 * editfns.c (Finsert_char):
5179 * fileio.c (Finsert_file_contents):
5180 Likewise for BUF_BYTES_MAX.
5181
dd52fcea
PE
5182 * image.c: Use ptrdiff_t, not int, for sizes.
5183 (slurp_file): Switch from int to ptrdiff_t.
5184 All uses changed.
5185 (slurp_file): Check that file size fits in both size_t (for
5186 malloc) and ptrdiff_t (for sanity and safety).
5187
7f9bbdbb
PE
5188 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5189 if b->modtime has its maximal value.
5190
dfe18f82
PE
5191 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5192
84acfcf0
PE
5193 Don't assume time_t can fit into int.
5194 * buffer.h (struct buffer.modtime): Now time_t, not int.
5195 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5196 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5197
ccd9a01a
PE
5198 Minor fixes for signed vs unsigned integers.
5199 * character.h (MAYBE_UNIFY_CHAR):
5200 * charset.c (maybe_unify_char):
5201 * keyboard.c (read_char, reorder_modifiers):
5202 XINT -> XFASTINT, since the integer must be nonnegative.
5203 * ftfont.c (ftfont_spec_pattern):
5204 * keymap.c (access_keymap, silly_event_symbol_error):
5205 XUINT -> XFASTINT, since the integer must be nonnegative.
5206 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5207 since it makes no difference and we prefer signed.
5208 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5209 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5210 nonnegative.
5211
d6d100dd
SM
52122011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5213
5214 * window.h (Fwindow_frame): Declare.
5215
2b6148e4
PE
52162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5217
5218 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5219 (SPARE_MEMORY): Always define.
5220 (LARGE_REQUEST): Remove.
5221 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5222
f230ecc9
MR
52232011-06-06 Martin Rudalics <rudalics@gmx.at>
5224
727e958e
MR
5225 * lisp.h: Move EXFUNS for Fframe_root_window,
5226 Fframe_first_window and Fset_frame_selected_window to window.h.
5227
5228 * window.h: Move EXFUNS for Fframe_root_window,
5229 Fframe_first_window and Fset_frame_selected_window here from
5230 lisp.h.
5231
5232 * frame.c (Fwindow_frame, Fframe_first_window)
5233 (Fframe_root_window, Fframe_selected_window)
5234 (Fset_frame_selected_window): Move to window.c.
5235 (Factive_minibuffer_window): Move to minibuf.c.
5236 (Fother_visible_frames_p): New function.
5237
5238 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5239
f230ecc9
MR
5240 * window.c (decode_window, decode_any_window): Move up in code.
5241 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5242 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5243 (Fwindow_buffer): Move up and rewrite doc-string.
5244 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5245 (Fwindow_prev): New functions.
727e958e
MR
5246 (Fwindow_frame): Move here from frame.c. Accept any window as
5247 argument.
5248 (Fframe_root_window, Fframe_first_window)
5249 (Fframe_selected_window): Move here from frame.c. Accept frame
5250 or arbitrary window as argument. Update doc-strings.
5251 (Fminibuffer_window): Move up in code.
5252 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5253 (Fset_frame_selected_window): Move here from frame.c.
5254 Marginal rewrite.
727e958e
MR
5255 (Fselected_window, select_window, Fselect_window): Move up in
5256 code. Minor doc-string fixes.
f230ecc9 5257
4d09bcf6
PE
52582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5259
5260 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5261 Do not assume that spare memory exists; that assumption is valid
5262 only if SYSTEM_MALLOC.
5263 (LARGE_REQUEST): New macro, so that the issue of large requests
5264 is separated from the issue of spare memory.
5265
810928a2
AS
52662011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5267
172418ad
AS
5268 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5269 format. (Bug#8806)
5270
43f862f7
AS
5271 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5272
810928a2
AS
5273 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5274 before statements.
5275
a059fe24
JD
52762011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5277
5278 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5279
5280 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5281
5282 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5283 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5284
989bf368
JB
52852011-06-05 Juanma Barranquero <lekktu@gmail.com>
5286
5287 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5288
4b80f674
CY
52892011-06-04 Chong Yidong <cyd@stupidchicken.com>
5290
5291 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5292 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5293 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5294 New error handlers.
4b80f674
CY
5295 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5296 Obey Vx_select_enable_clipboard_manager. Catch errors in
5297 x_clipboard_manager_save (Bug#8779).
5298 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5299 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5300
99a33b77 53012011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5302
5303 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5304
99a33b77 53052011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5306
5307 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5308 in the current matrix if keep_current_p is non-zero.
5309
8264569d
EZ
53102011-06-04 Eli Zaretskii <eliz@gnu.org>
5311
5312 * bidi.c (bidi_level_of_next_char): Fix last change.
5313
57f97249
EZ
53142011-06-03 Eli Zaretskii <eliz@gnu.org>
5315
fec2107c 5316 Support bidi reordering of text covered by display properties.
57f97249 5317
fec2107c
EZ
5318 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5319 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5320 (bidi_cache_search, bidi_cache_iterator_state)
5321 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5322 (bidi_level_of_next_char, bidi_move_to_visually_next):
5323 Support character positions inside a run of characters covered by a
fec2107c
EZ
5324 display string.
5325 (bidi_paragraph_init, bidi_resolve_explicit_1)
5326 (bidi_level_of_next_char): Call bidi_fetch_char and
5327 bidi_fetch_char_advance instead of FETCH_CHAR and
5328 FETCH_CHAR_ADVANCE.
5329 (bidi_init_it): Initialize new members.
5330 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5331 definitions.
5332 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5333 instead of using explicit *_CHAR codes.
d6d100dd
SM
5334 (bidi_resolve_explicit, bidi_resolve_weak):
5335 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5336 bidirectional text is supported only in multibyte buffers.
5337 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5338 it to initialize the frame_window_p member of struct bidi_it.
5339 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5340 (bidi_resolve_explicit, bidi_resolve_weak)
5341 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5342 bidi_it->nchars is non-positive.
5343 (bidi_level_of_next_char): Don't try to lookup the cache for the
5344 next/previous character if nothing is cached there yet, or if we
5345 were just reseat()'ed to a new position.
c40e2fb2 5346
0e14fe90
EZ
5347 * xdisp.c (set_cursor_from_row): Set start and stop points
5348 according to the row's direction when priming the loop that looks
5349 for the glyph on which to display cursor.
5350 (single_display_spec_intangible_p): Function deleted.
5351 (display_prop_intangible_p): Reimplement to call
5352 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5353 Accept 3 additional arguments needed by handle_display_spec.
5354 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5355 values: lists, `(when COND...)' forms, etc.
5356 (single_display_spec_string_p): Support property values that are
5357 lists with the argument STRING its top-level element.
5358 (display_prop_string_p): Fix the condition for processing a
5359 property that is a list to be consistent with handle_display_spec.
fec2107c 5360 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5361 last portion of handle_display_prop.
5362 (compute_display_string_pos): Accept additional argument
5363 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5364 value of a `display' property is a "replacing spec".
5365 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5366 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5367 the display property, but just return a value indicating whether
5368 the display property will replace the characters it covers.
5369 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5370 frame_window_p members of struct bidi_it.
d6d100dd
SM
5371 (compute_display_string_pos, compute_display_string_end):
5372 New functions.
fec2107c
EZ
5373 (push_it): Accept second argument POSITION, where pop_it should
5374 jump to continue iteration.
5375 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5376
fec2107c
EZ
5377 * keyboard.c (adjust_point_for_property): Adjust the call to
5378 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5379
5380 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5381 (bidi_init_it): Update prototypes.
5382 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5383 (compute_display_string_pos, compute_display_string_end):
5384 Declare prototypes.
fec2107c
EZ
5385 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5386 EMACS_INT.
fc6f18ce 5387
40087514 53882011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5389
57f53182
PE
5390 Malloc failure behavior now depends on size of allocation.
5391 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5392 * lisp.h: Change signatures accordingly.
5393 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5394 All callers changed. (Bug#8762)
5395
5396 * gnutls.c: Use Emacs's memory allocators.
5397 Without this change, the gnutls library would invoke malloc etc.
5398 directly, which causes problems on non-SYNC_INPUT hosts, and which
5399 runs afoul of improving memory_full behavior. (Bug#8761)
5400 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5401 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5402 xfree instead of the default malloc, realloc, free.
5403 (Fgnutls_boot): No need to check for memory allocation failure,
5404 since xmalloc does that for us.
5405
ac32cd99 5406 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5407 * category.c (hash_get_category_set):
5408 * ccl.c (ccl_driver):
5409 * charset.c (Fdefine_charset_internal):
5410 * charset.h (struct charset.hash_index):
5411 * composite.c (get_composition_id, gstring_lookup_cache)
5412 (composition_gstring_put_cache):
5413 * composite.h (struct composition.hash_index):
5414 * dispextern.h (struct image.hash):
5415 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5416 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5417 (hashfn_equal, hashfn_user_defined, make_hash_table)
5418 (maybe_resize_hash_table, hash_lookup, hash_put)
5419 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5420 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5421 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5422 * image.c (make_image, search_image_cache, lookup_image)
5423 (xpm_put_color_table_h):
5424 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5425 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5426 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5427 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5428 * alloc.c (allocate_vectorlike):
5429 Check for overflow in vector size calculations.
5430 * ccl.c (ccl_driver):
5431 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5432 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5433 need to be updated by these changes.
40087514
PE
5434 * fns.c (make_hash_table, maybe_resize_hash_table):
5435 Check for integer overflow with large hash tables.
0de4bb68
PE
5436 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5437 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5438 (SXHASH_REDUCE): New macro.
5439 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5440 Use it instead of discarding useful hash info with large hash values.
5441 (sxhash_float): New function.
5442 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5443 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5444 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5445 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5446 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5447 Adjust signatures to match updated version of code.
5448 (consing_since_gc): Now EMACS_INT, since a single hash table can
5449 use more than INT_MAX bytes.
5450
698d32e2
DN
54512011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5452
5453 Make it possible to build with GCC-4.6+ -O2 -flto.
5454
5455 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5456
fd6fa53f
SM
54572011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5458
5459 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5460 Call minibuffer-inactive-mode.
5461
864db017
JB
54622011-05-31 Juanma Barranquero <lekktu@gmail.com>
5463
5464 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5465 Update dependencies.
5466
2ad0baf4
DN
54672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5468
5469 * data.c (init_data): Remove code for UTS, this system is not
5470 supported anymore.
5471
4fcc2638
DN
54722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5473
5474 Don't force ./temacs to start in terminal mode.
5475
5476 * frame.c (make_initial_frame): Initialize faces in all cases, not
5477 only when CANNOT_DUMP is defined.
5478 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5479
c56e0fd5
DN
54802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5481
5482 * dispnew.c (add_window_display_history): Use const for the string
5483 pointer. Remove declaration, not needed.
5484
333d54da 54852011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5486
55d4c1b2 5487 Use 'inline', not 'INLINE'.
333d54da 5488 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5489 * alloc.c, fontset.c (INLINE): Remove.
5490 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5491 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5492 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5493 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5494 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5495
738db178
DN
54962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5497
5498 Make it possible to run ./temacs.
5499
5500 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5501 syms_of_callproc does the same thing. Remove test for
5502 "initialized", do it in the caller.
5503 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5504
620c53a6
SM
55052011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5506
5507 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5508 (read_minibuf): Use get_minibuffer.
5509 (syms_of_minibuf): Use DEFSYM.
5510 (Qmetadata): New var.
5511 * data.c (Qbuffer): Don't make it static.
5512 (syms_of_data): Use DEFSYM.
5513
e003a292
PE
55142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5515
5516 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5517 (CCL_CODE_MIN): New macro.
5518
ed008a6d
PE
55192011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5520
3687c2ef
PE
5521 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5522
ed008a6d
PE
5523 * eval.c (Qdebug): Now static.
5524 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5525 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5526 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5527
d66c4c7c
CY
55282011-05-29 Chong Yidong <cyd@stupidchicken.com>
5529
5530 * image.c: Various fixes to ImageMagick code comments.
5531 (Fimagemagick_types): Doc fix.
5532
5fbc2025
PE
55332011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5534
0196f88a
PE
5535 Minor fixes prompted by GCC 4.6.0 warnings.
5536
5537 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5538
5fbc2025
PE
5539 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5540 (x_clipboard_manager_save_all): Move extern decl to ...
5541 * xterm.h: ... here, so that it can be checked for consistency.
5542
1dd3c2d9
CY
55432011-05-29 Chong Yidong <cyd@stupidchicken.com>
5544
5545 * xselect.c (x_clipboard_manager_save_frame)
5546 (x_clipboard_manager_save_all): New functions.
5547 (Fx_clipboard_manager_save): Lisp function deleted.
5548
5549 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5550 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5551
5552 * xterm.h: Update prototype.
5553
5ba6571d
WX
55542011-05-28 William Xu <william.xwl@gmail.com>
5555
5556 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5557 exiting (Bug#8239).
5558
3eaff834
JM
55592011-05-28 Jim Meyering <meyering@redhat.com>
5560
e1900994 5561 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5562 * fns.c (to_uchar): Define.
5563 (crypto_hash_function): Use it to convert some newly-signed
5564 variables to unsigned, to avoid sign-extension bugs. For example,
5565 without this change, (md5 "truc") would evaluate to
5566 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5567 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5568 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5569
0f6990a7
PE
55702011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5571
5572 Integer overflow fixes.
c8a9ca5a 5573
08686060
PE
5574 * dbusbind.c: Serial number integer overflow fixes.
5575 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5576 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5577 to hold a serial number that is too large for a fixnum.
5578 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5579 Check for serial numbers out of range. Decode any serial number
59568bf0 5580 that was so large that it became a float. (Bug#8722)
08686060 5581
2d1fc3c7
PE
5582 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5583 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5584 Use XFASTINT rather than XUINT when numbers are nonnegative.
5585 (xd_append_arg, Fdbus_method_return_internal):
5586 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5587 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5588 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5589 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5590 (Bug#8722)
2d1fc3c7 5591
c8a9ca5a
PE
5592 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5593
519e1d69
PE
5594 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5595
30569699
PE
5596 ccl: add integer overflow checks
5597 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5598 (IN_INT_RANGE): New macros.
5599 (ccl_driver): Use them to check for integer overflow when
5600 decoding a CCL program. Many of the new checks are whether XINT (x)
5601 fits in int; it doesn't always, on 64-bit hosts. The new version
5602 doesn't catch all possible integer overflows, but it's an
847044ea 5603 improvement. (Bug#8719)
30569699 5604
c11285dc
PE
5605 * alloc.c (make_event_array): Use XINT, not XUINT.
5606 There's no need for unsigned here.
5607
fdccd48e
PE
5608 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5609 This follows up to the 2011-05-06 change that substituted uintptr_t
5610 for EMACS_INT. This case wasn't caught back then.
5611
37910ab2
PE
5612 Rework Fformat to avoid integer overflow issues.
5613 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5614 now (part of C89). Include <verify.h>.
5615 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5616 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5617 (Fformat): Avoid the prepass trying to compute sizes; it was only
5618 approximate and thus did not catch overflow reliably. Instead, walk
5619 through the format just once, formatting and computing sizes as we go,
5620 checking for integer overflow at every step, and allocating a larger
5621 buffer as needed. Keep track separately whether the format is
5622 multibyte. Keep only the most-recently calculated precision, rather
5623 than them all. Record whether each argument has been converted to
5624 string. Use EMACS_INT, not int, for byte and char and arg counts.
5625 Support field widths and precisions larger than INT_MAX. Avoid
5626 sprintf's undefined behavior with conversion specifications such as %#d
5627 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5628 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5629 formatting out-of-range floating point numbers with int
9173deec 5630 formats. (Bug#8668)
37910ab2 5631
2e6578fb
PE
5632 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5633
0ae6bdee
PE
5634 * data.c: Avoid integer truncation in expressions involving floats.
5635 * data.c: Include <intprops.h>.
5636 (arith_driver): When there's an integer overflow in an expression
5637 involving floating point, convert the integers to floating point
5638 so that the resulting value does not suffer from catastrophic
5639 integer truncation. For example, on a 64-bit host (* 4
5640 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5641 Do not rely on undefined behavior after integer overflow.
5642
de883a70
PE
5643 merge count_size_as_multibyte, parse_str_to_multibyte
5644 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5645 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5646 Check for integer overflow.
5647 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5648 since it's now a duplicate of the other. This is more of
5649 a character than a buffer op, so better that it's in character.c.
5650 * fns.c, print.c: Adjust to above changes.
5651
2ff916cb
PE
56522011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5653
5654 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5655
f1b54466
PE
56562011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5657
fb1ac845
PE
5658 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5659 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5660 (x_clipboard_manager_save): Now static.
5661 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5662
f1b54466
PE
5663 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5664 (crypto_hash_function): Now static.
5665 Fix pointer signedness problems. Avoid unnecessary initializations.
5666
a9f737ee
CY
56672011-05-27 Chong Yidong <cyd@stupidchicken.com>
5668
5669 * termhooks.h (Vselection_alist): Make it terminal-local.
5670
5671 * terminal.c (create_terminal): Initialize it.
5672
5673 * xselect.c: Support for clipboard managers.
5674 (Vselection_alist): Move to termhooks.h as terminal-local var.
5675 (LOCAL_SELECTION): New macro.
5676 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5677 (symbol_to_x_atom): Remove gratuitous arg.
5678 (x_handle_selection_request, lisp_data_to_selection_data)
5679 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5680 (x_own_selection, x_get_local_selection, x_convert_selection):
5681 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5682 (some_frame_on_display): Delete unused function.
5683 (Fx_own_selection_internal, Fx_get_selection_internal)
5684 (Fx_disown_selection_internal, Fx_selection_owner_p)
5685 (Fx_selection_exists_p): New optional frame arg.
5686 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5687 (x_handle_selection_clear): Don't treat other terminals with the
5688 same keyboard specially. Use the terminal-local Vselection_alist.
5689 (x_clear_frame_selections): Use Frun_hook_with_args.
5690
5691 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5692
5693 * xterm.h: Add support for those atoms.
5694
e067f0c1
CY
56952011-05-26 Chong Yidong <cyd@stupidchicken.com>
5696
5697 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5698 (converted_selections, conversion_fail_tag): New global variables.
5699 (x_selection_request_lisp_error): Free the above.
5700 (x_get_local_selection): Remove unnecessary code.
5701 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5702 of converted selections stored in converted_selections.
5703 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5704 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5705 (x_convert_selection): New function.
5706 (x_handle_selection_event): Simplify.
5707 (x_get_foreign_selection): Don't ignore incoming requests while
5708 waiting for an answer; this will fail when we implement
5709 SAVE_TARGETS, and seems unnecessary anyway.
5710 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5711 (Vx_sent_selection_functions): Doc fix.
5712
0f4aebc0
LL
57132011-05-26 Leo Liu <sdl.web@gmail.com>
5714
5715 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5716
e61124cd
YM
57172011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5718
5719 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5720
5721 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5722 for fringe update if it has periodic bitmap.
ac389d0c 5723 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5724 and fringe_bitmap_periodic_p.
5725
5726 * fringe.c (get_fringe_bitmap_data): New function.
5727 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5728 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5729 row. Mark glyph row for fringe update if periodicity changed.
5730
5731 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5732 for fringe update unless it has periodic bitmap.
5733
f16d9837
KH
57342011-05-25 Kenichi Handa <handa@m17n.org>
5735
5736 * xdisp.c (get_next_display_element): Set correct it->face_id for
5737 a static composition.
5738
e1b90ef6
LL
57392011-05-24 Leo Liu <sdl.web@gmail.com>
5740
5741 * deps.mk (fns.o):
5742 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5743
5744 * fns.c (crypto_hash_function, Fsha1): New function.
5745 (Fmd5): Use crypto_hash_function.
5746 (syms_of_fns): Add Ssha1.
5747
7400048f
PE
57482011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5749
5750 * gnutls.c: Remove unused macros.
5751 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5752 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5753 Remove macros that are defined and never used.
5754 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5755
abb71cf4
CY
57562011-05-22 Chong Yidong <cyd@stupidchicken.com>
5757
5758 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5759 (Fx_get_selection_internal): Minor cleanup.
5760 (Fx_own_selection_internal): Rename arguments for consistency with
5761 select.el.
5762
6307db39
PE
57632011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5764
5765 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5766
f3d4e0a4
CY
57672011-05-22 Chong Yidong <cyd@stupidchicken.com>
5768
5769 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5770
4d8ade89
YM
57712011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5772
5773 * dispnew.c (scrolling_window): Don't exclude the case that the
5774 last enabled row in the desired matrix touches the bottom boundary.
5775
32078c8d
GM
57762011-05-21 Glenn Morris <rgm@gnu.org>
5777
5778 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5779 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5780 and add some more files.
32078c8d 5781
7285dc67
EZ
57822011-05-20 Eli Zaretskii <eliz@gnu.org>
5783
5784 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5785 report_file_error introduced by the change from 2011-05-07.
5786
89d1bd22
PE
57872011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5788
5789 * systime.h (Time): Define only if emacs is defined.
5790 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5791 where the include path doesn't have X11/X.h by default. See
5792 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5793
cd394be1 57942011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5795
5796 * composite.c (find_automatic_composition): Fix previous change.
5797
b9704ad9
GM
57982011-05-20 Glenn Morris <rgm@gnu.org>
5799
5800 * lisp.mk: New file, split from Makefile.in.
5801 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5802 (shortlisp): Remove.
5803 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5804
4a720484
GM
58052011-05-19 Glenn Morris <rgm@gnu.org>
5806
5807 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5808 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5809 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5810 (lisp): Set the order to that of loadup.el.
5811 (shortlisp): Make it a copy of $lisp.
5812 (SOME_MACHINE_LISP): Remove.
5813 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5814 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5815
a28d4396
KH
58162011-05-18 Kenichi Handa <handa@m17n.org>
5817
5818 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5819 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5820 (find_automatic_composition): Mostly rewrite for efficiency.
5821
a2b1fa8e
JB
58222011-05-18 Juanma Barranquero <lekktu@gmail.com>
5823
5824 * makefile.w32-in: Update dependencies.
5825
8e1f5610
CS
58262011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5827
5828 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5829 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5830
7025ee00 58312011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5832
cdfa6eab
PE
5833 Fix some integer overflow issues, such as string length overflow.
5834
06d6db33
PE
5835 * insdel.c (count_size_as_multibyte): Check for string overflow.
5836
2b4560a8
PE
5837 * character.c (lisp_string_width): Check for string overflow.
5838 Use EMACS_INT, not int, for string indexes and lengths; in
5839 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5840 the resulting string length overflows an EMACS_INT; instead,
5841 report a string overflow if no precision given. When checking for
5842 precision exhaustion, use a check that cannot possibly have
5843 integer overflow. (Bug#8675)
5844 * character.h (lisp_string_width): Adjust to new signature.
5845
cb93f9be
PE
5846 * alloc.c (string_overflow): New function.
5847 (Fmake_string): Use it. This doesn't change behavior, but saves
5848 a few bytes and will simplify future changes.
5849 * character.c (string_escape_byte8): Likewise.
5850 * lisp.h (string_overflow): New decl.
5851
1a1f3366
PE
5852 Fixups, following up to the user-interface timestamp change.
5853 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5854 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5855 * msdos.c (mouse_get_pos): Likewise.
5856 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5857 * w32gui.h (Time): Define by including "systime.h" rather than by
5858 declaring it ourselves. (Bug#8664)
5859
d4e3e4d3
PE
5860 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5861 * image.c (clear_image_cache): Likewise.
5862
f6a24d19
PE
5863 * term.c (term_mouse_position): Don't assume time_t wraparound.
5864
08dc5ae6
PE
5865 Be more systematic about user-interface timestamps.
5866 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5867 and sometimes 'EMACS_UINT', to represent these timestamps.
5868 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5869 This makes the code easier to follow, and makes it easier to catch
5870 integer overflow bugs such as Bug#8664.
5871 * frame.c (Fmouse_position, Fmouse_pixel_position):
5872 Use Time, not unsigned long, for user-interface timestamps.
5873 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5874 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5875 * keyboard.h (last_event_timestamp): Likewise.
5876 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5877 * menu.h (xmenu_show): Likewise.
5878 * term.c (term_mouse_position): Likewise.
5879 * termhooks.h (struct input_event.timestamp): Likewise.
5880 (struct terminal.mouse_position_hook): Likewise.
5881 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5882 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5883 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5884 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5885 what it was before.
5886 * menu.h, termhooks.h: Include "systime.h", for Time.
5887
8e55734a
PE
5888 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5889 Don't assume that the difference between two unsigned long values
5890 can fit into an integer. At this point, we know button_down_time
5891 <= event->timestamp, so the difference must be nonnegative, so
5892 there's no need to cast the result if double-click-time is
5893 nonnegative, as it should be; check that it's nonnegative, just in
5894 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5895 apart (about 25 days). (Bug#8664)
8e55734a 5896
841f1b75 5897 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5898 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5899
3e26f69c
PE
5900 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5901 that always fit in int. Use a sentinel instead of a counter, to
5902 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5903 * frame.h (struct frame): Use int for menu_bar_items_used
5904 instead of EMACS_INT, since it always fits in int.
3e26f69c 5905
5cc152c0
PE
5906 * menu.c (grow_menu_items): Check for int overflow.
5907
d89eb65e
PE
5908 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5909
5235bd3e
PE
5910 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5911 Before, the code was not consistent. These values cannot exceed
5912 2**31 - 1 so there's no need to make them unsigned.
5913 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5914 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5915 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5916 as modifiers.
5917 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5918
bc827e23
PE
5919 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5920 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5921 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5922 presumably because the widths might not match.
5923
78eb494e
PE
5924 * window.c (size_window): Avoid needless test at loop start.
5925
04f2d78b
CB
59262011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5927
5928 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5929
d2fc7e3d 59302011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5931
5932 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5933
d2fc7e3d 59342011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5935
5936 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5937 `width' to `bar_area_x' and `bar_area_width', respectively.
5938 (x_scroll_run): Take account of fringe background extension.
5939
04f2d78b
CB
5940 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5941 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5942 `bar_area_width', respectively.
5943 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5944 background extension.
5945
79b70037
GM
59462011-05-10 Jim Meyering <meyering@redhat.com>
5947
5948 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5949
2f142cc5
JB
59502011-05-10 Juanma Barranquero <lekktu@gmail.com>
5951
5952 * image.c (Finit_image_library): Return t for built-in image types,
5953 like pbm and xbm. (Bug#8640)
5954
57679c86
AS
59552011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5956
5957 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5958
888c9e86
EZ
59592011-05-07 Eli Zaretskii <eliz@gnu.org>
5960
b0512a1d
EZ
5961 * w32console.c (Fset_screen_color): Doc fix.
5962 (Fget_screen_color): New function.
5963 (syms_of_ntterm): Defsubr it.
5964
7285dc67
EZ
5965 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5966 unlink the temporary file if Fcall_process didn't create it in the
5967 first place.
5968 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5969 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5970 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5971 cue to call_process_cleanup not to close that handle.
5972
4d3fcc8e
BK
59732011-05-07 Ben Key <bkey76@gmail.com>
5974
5975 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5976 one of two shell specific rules, either bootstrap-temacs-CMD or
5977 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5978 to the previous implementation of the bootstrap-temacs rule.
5979 The bootstrap-temacs-CMD rule is similar to the previous
5980 implementation of the bootstrap-temacs rule except that it
5981 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5982 variable.
5983
5984 These changes, along with some changes to nt/configure.bat,
5985 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5986 earlier fix to add support for --cflags and --ldflags options
5987 that include quotes so that it works whether make uses cmd or
5988 sh as the shell.
5989
b4289b64
MA
59902011-05-06 Michael Albinus <michael.albinus@gmx.de>
5991
5992 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5993 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5994 is a constant.
5995 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5996 a string. Handle both cases.
5997 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5998 (Fdbus_register_method): Use Qinvalid_function.
5999
af4c0e28
JB
60002011-05-06 Juanma Barranquero <lekktu@gmail.com>
6001
6002 * makefile.w32-in: Update dependencies.
6003 (LISP_H): Add inttypes.h and stdin.h.
6004 (PROCESS_H): Add unistd.h.
6005
c51453d9
EZ
60062011-05-06 Eli Zaretskii <eliz@gnu.org>
6007
6008 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6009 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6010
8ff0ac3c 60112011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6012
4c4b566b
PE
6013 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6014
aab2b9b5
PE
6015 * term.c (vfatal): Remove stray call to va_end.
6016 It's not needed and the C Standard doesn't allow it here anyway.
6017
c378da0b
PE
6018 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6019 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6020
288b08c7
PE
6021 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6022 bytes.
6023
e3601888
PE
6024 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6025
db6c0e74
PE
6026 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6027
dd5963ea
PE
6028 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6029
88c9450f
PE
6030 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6031
2f9442b8
PE
6032 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6033
c032b5f8
PE
6034 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6035 * charset.c (Fdefine_charset_internal): Don't initialize
6036 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6037 32-bit int (Bug#8600).
a108c10b
PE
6038
6039 * lread.c (read_integer): Be more consistent with string-to-number.
6040 Use string_to_number to do the actual conversion; this avoids
6041 rounding errors and fixes some other screwups. Without this fix,
6042 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6043 (digit_to_number): Move earlier, for benefit of read_integer.
6044 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6045 not a digit in any supported base. (Bug#8602)
a108c10b 6046
ad5f9eea
PE
6047 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6048
aec1708a
PE
6049 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6050 to match comment at start of function. This also removes a
6051 GCC warning about overflow in a 32+64-bit port.
6052
47be4ab5
PE
6053 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6054
371cac43
PE
6055 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6056 Reported by Stefan Monnier in
6057 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6058 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6059 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6060
d01a7826
PE
6061 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6062 (EMACS_UINTPTR): Likewise, with uintptr_t.
6063
7fd47d5c
PE
6064 * lisp.h: Prefer 64-bit EMACS_INT if available.
6065 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6066 on 32-bit hosts that have 64-bit int, so that they can access
6067 large files.
122b0c86
PE
6068 However, temporarily disable this change unless the temporary
6069 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6070
8727937b
PE
6071 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6072
8ac068ac
PE
6073 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6074 This removes an assumption that EMACS_INT and long are the same
6075 width as pointers. The assumption is true for Emacs porting targets
6076 now, but we want to make other targets possible.
6077 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6078 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6079 In the rest of the code, change types of integers that hold casted
6080 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6081 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6082 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6083 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6084 No need to cast type when ORing.
6085 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6086 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6087 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6088 assume EMACS_INT is the same width as char *.
6089 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6090 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6091 Remove no-longer-needed casts.
6092 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6093 (xg_tool_bar_help_callback, xg_make_tool_item):
6094 Use EMACS_INTPTR to hold an integer
6095 that will be cast to void *; this can avoid a GCC warning
6096 if EMACS_INT is not the same width as void *.
6097 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6098 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6099 (current_message_1, set_message_1):
6100 Use a local to convert to proper width without a cast.
6101 * xmenu.c (dialog_selection_callback): Likewise.
6102
ede49d71
PE
6103 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6104 Also, don't assume VALBITS / RAND_BITS is less than 5,
6105 and don't rely on undefined behavior when shifting a 1 left into
6106 the sign bit.
6107 * lisp.h (get_random): Change signature to match.
6108
2f30ecd0
PE
6109 * lread.c (hash_string): Use size_t, not int, for hash computation.
6110 Normally we prefer signed values; but hashing is special, because
6111 it's better to use unsigned division on hash table sizes so that
6112 the remainder is nonnegative. Also, size_t is the natural width
6113 for hashing into memory. The previous code used 'int', which doesn't
6114 retain enough info to hash well into very large tables.
6115 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6116
2a866e7b
PE
6117 * dbusbind.c: Don't possibly lose pointer info when converting.
6118 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6119 Use XPNTR rather than XHASH, so that the high-order bits of
6120 the pointer aren't lost when converting through void *.
6121
51639eac
PE
6122 * eval.c (Fautoload): Don't double-shift a pointer.
6123
92394119
PE
6124 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6125
dbdb9a7c
JB
61262011-05-06 Juanma Barranquero <lekktu@gmail.com>
6127
6128 * gnutls.c (DEF_GNUTLS_FN):
6129 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6130
db7a0b4f
AS
61312011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6132
6133 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6134 marker. (Bug#8610)
6135
cd394be1 61362011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6137
6138 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6139 New version that can reserve upto 2GB of heap space.
6140
f7ff1b0f 61412011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6142
6143 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6144
639c109b
TZ
61452011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6146
6147 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6148 `gnutls_certificate_set_x509_key_file'.
6149
d2127135
JB
61502011-05-05 Juanma Barranquero <lekktu@gmail.com>
6151
6152 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6153 Update dependencies.
6154
e968f4f3
JB
61552011-05-04 Juanma Barranquero <lekktu@gmail.com>
6156
6157 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6158 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6159 Remove unused parameter `fildes'.
6160 * process.c (read_process_output, send_process): Don't pass it.
6161
84d358f0
JB
61622011-05-04 Juanma Barranquero <lekktu@gmail.com>
6163
6164 Fix previous change: the library cache is defined in w32.c.
6165 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6166 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6167
0898ca10
JB
61682011-05-04 Juanma Barranquero <lekktu@gmail.com>
6169
6170 Implement dynamic loading of GnuTLS on Windows.
6171
6172 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6173 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6174 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6175 Declare.
6176
6177 * gnutls.c (Qgnutls_dll): Define.
6178 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6179 (gnutls_*): Declare function pointers.
6180 (init_gnutls_functions): New function to initialize function pointers.
6181 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6182 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6183 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6184 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6185 (emacs_gnutls_write, emacs_gnutls_read)
6186 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6187 (Fgnutls_available_p): New function.
6188 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6189 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6190 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6191
6192 * image.c: Include w32.h.
6193 (Vimage_type_cache): Delete.
6194 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6195 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6196 (w32_delayed_load): Move to w32.c.
6197
6198 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6199
6200 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6201 (w32_delayed_load): Move from image.c. When loading a library, record
6202 its filename in the :loaded-from property of the library id.
6203 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6204 Initialize and staticpro them.
6205 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6206
6207 * process.c: Include lisp.h before w32.h, not after.
6208 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6209 instead of gnutls_record_check_pending.
6210
6211 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6212
ff4de4aa
TZ
62132011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6214
6215 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6216 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6217 as passed in.
6218
abe95abb
JD
62192011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6220
6221 * xterm.c (x_set_frame_alpha): Do not set property on anything
6222 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6223
e16e55d4
JB
62242011-05-02 Juanma Barranquero <lekktu@gmail.com>
6225
6226 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6227
bafcf6a5
JB
62282011-05-02 Juanma Barranquero <lekktu@gmail.com>
6229
6230 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6231 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6232 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6233 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6234 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6235 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6236 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6237 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6238 (Qgnutls_bootprop_callbacks_verify): Make static.
6239
e7a6747f
AS
62402011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6241
19ed11ba
AS
6242 * callproc.c: Indentation fixup.
6243
e7a6747f 6244 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6245 (wait_for_termination, interruptible_wait_for_termination):
6246 Move after wait_for_termination_1.
e7a6747f 6247
1ef14cb4
LMI
62482011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6249
6250 * sysdep.c (interruptible_wait_for_termination): New function
6251 which is like wait_for_termination, but allows keyboard
6252 interruptions.
6253
6254 * callproc.c (Fcall_process): Add (:file "file") as an option for
6255 the STDOUT buffer.
6256 (Fcall_process_region): Ditto.
6257
330d880c
EZ
62582011-04-30 Eli Zaretskii <eliz@gnu.org>
6259
8db90b73
EZ
6260 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6261 rather than `XVECTOR (FOO)->size'.
6262
330d880c
EZ
6263 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6264 inttypes.h, as a gnulib replacement is used if it not available in
6265 system headers.
6266
15cbd324
EZ
62672011-04-21 Eli Zaretskii <eliz@gnu.org>
6268
6269 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6270 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6271 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6272
6273 * coding.c (coding_alloc_by_realloc): Error out if destination
6274 will grow beyond MOST_POSITIVE_FIXNUM.
6275 (decode_coding_emacs_mule): Abort if there isn't enough place in
6276 charbuf for the composition carryover bytes. Reserve an extra
6277 space for up to 2 characters produced in a loop.
6278 (decode_coding_iso_2022): Abort if there isn't enough place in
6279 charbuf for the composition carryover bytes.
6280
62812011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6282
ae940cca
EZ
6283 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6284 aborting when %lld or %lll format is passed.
6285 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6286 %llo or %llx format is passed. (Bug#8545)
6287
03ab8921
EZ
6288 * window.c (window_scroll_line_based): Use a marker instead of
6289 simple variables to record original value of point. (Bug#7952)
6290
afda1437
EZ
6291 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6292 produced by %s or %c overflows available buffer space. (Bug#8545)
6293
f76dee0c
PE
62942011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6295
6296 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6297 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6298
fdc5744d
JB
62992011-04-28 Juanma Barranquero <lekktu@gmail.com>
6300
6301 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6302
638f053a
JB
63032011-04-28 Juanma Barranquero <lekktu@gmail.com>
6304
6305 * keyboard.c (Qdelayed_warnings_hook): Define.
6306 (command_loop_1): Run `delayed-warnings-hook'
6307 if Vdelayed_warnings_list is non-nil.
6308 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6309 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6310
d178f871
EZ
63112011-04-28 Eli Zaretskii <eliz@gnu.org>
6312
6313 * doprnt.c (doprnt): Don't return value smaller than the buffer
6314 size if the message was truncated. (Bug#8545).
6315
b124fd93
JB
63162011-04-28 Juanma Barranquero <lekktu@gmail.com>
6317
6318 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6319 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6320
e810457d
PE
63212011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6322
6323 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6324
ea51cceb
JB
63252011-04-27 Juanma Barranquero <lekktu@gmail.com>
6326
6327 * makefile.w32-in: Update dependencies.
6328
94dcfacf
EZ
63292011-04-27 Eli Zaretskii <eliz@gnu.org>
6330
6331 Improve `doprnt' and its usage. (Bug#8545)
6332 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6333 `format_end'. Remove support for %l as a conversion specifier.
6334 Don't use xrealloc. Improve diagnostics when the %l size modifier
6335 is used. Update the commentary.
6336
6337 * eval.c (verror): Simplify calculation of size_t.
6338
6339 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6340 messages.
6341
f61f41d7
PE
63422011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6343
6344 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6345 change.
6346
96fb4434
PE
63472011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6348
6349 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6350 This makes this file independent of the recent pseudovector change.
6351
671875da 63522011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6353
69e9b5a3
PE
6354 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6355
b5f869a7 6356 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6357 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6358 Remove unused local.
c8926152 6359 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6360
841a1577 6361 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6362 GCC 4.6.0 optimizes based on type-based alias analysis.
6363 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6364 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6365 != &v->size, and therefore "v->size = 1; b->size = 2; return
6366 v->size;" must therefore return 1. This assumption is incorrect
6367 for Emacs, since it type-puns struct Lisp_Vector * with many other
6368 types. To fix this problem, this patch adds a new type struct
f904488f 6369 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6370 and pseudovectors, and helps optimizing compilers not get fooled
6371 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6372 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6373 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6374 the size member.
eab3844f
PE
6375 (XSETPVECTYPE): Rewrite in terms of new macro.
6376 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6377 This is a bit clearer, and further avoids the possibility of
6378 undesirable aliasing.
6379 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6380 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6381 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6382 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6383 (ASIZE): Now uses header.size rather than size.
6384 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6385 to avoid the hassle of writing XVECTOR (foo)->header.size.
6386 (struct vectorlike_header): New type.
eab3844f
PE
6387 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6388 object, to help avoid aliasing.
6389 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6390 (SUBRP): Likewise, since Lisp_Subr is a special case.
6391 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6392 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6393 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6394 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6395 changed to be "header.size" and "header.next".
6396 * buffer.h (struct buffer): Likewise.
6397 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6398 * frame.h (struct frame): Likewise.
6399 * process.h (struct Lisp_Process): Likewise.
6400 * termhooks.h (struct terminal): Likewise.
6401 * window.c (struct save_window_data, struct saved_window): Likewise.
6402 * window.h (struct window): Likewise.
6403 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6404 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6405 * buffer.c (init_buffer_once): Likewise.
6406 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6407 special case.
6408 * process.c (Fformat_network_address): Use local var for size,
6409 for brevity.
6410
0df1eac5
PE
6411 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6412
847ab9d1 6413 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6414 * data.c (atof): Remove decl; no longer used or needed.
6415 (digit_to_number): Move to lread.c.
6416 (Fstring_to_number): Use new string_to_number function, to be
6417 consistent with how the Lisp reader treats infinities and NaNs.
6418 Do not assume that floating-point numbers represent EMACS_INT
6419 without losing information; this is not true on most 64-bit hosts.
6420 Avoid double-rounding errors, by insisting on integers when
6421 parsing non-base-10 numbers, as the documentation specifies.
6422 * lisp.h (string_to_number): New decl, replacing ...
6423 (isfloat_string): Remove.
bc0a5c13 6424 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6425 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6426 appears to have been a coding error. Similarly, do not accept
6427 strings like +-1e0 as floating point numbers. Do not report
6428 overflow for integer overflows unless the base is not 10 which
6429 means we have no simple and reliable way to continue.
6430 Break out the floating-point parsing into a new
6431 function string_to_number, so that Fstring_to_number parses
6432 floating point numbers consistently with the Lisp reader.
04f2d78b 6433 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6434 (E_CHAR, EXP_INT): Remove, replacing with ...
6435 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6436 (string_to_number): New function, replacing isfloat_string.
6437 This function checks for valid syntax and produces the resulting
6438 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6439 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6440 so that overflow for non-base-10 numbers is reported only when
6441 there's no portable and simple way to convert to floating point.
452f4150 6442
67769ffc
PE
6443 * textprop.c (set_text_properties_1): Rewrite for clarity,
6444 and to avoid GCC warning about integer overflow.
6445
c20db43f
PE
6446 * intervals.h (struct interval): Use EMACS_INT for members
6447 where EMACS_UINT might cause problems. See
6448 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6449 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6450 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6451 All uses changed.
37aa2f85
PE
6452 (offset_intervals): Tell GCC not to worry about length overflow
6453 when negating a negative length.
c20db43f 6454
2538aa2f
PE
6455 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6456 (overrun_check_free): Likewise.
6457
f2d3008d
PE
6458 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6459 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6460 word size.
6461
ec8df744
PE
6462 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6463 (gnutls_make_error): Rename local to avoid shadowing.
6464 (gnutls_emacs_global_deinit): ifdef out; not used.
6465 (Fgnutls_boot): Use const for pointer to readonly storage.
6466 Comment out unused local. Fix pointer signedness problems.
6467
640ee02d
PE
6468 * lread.c (openp): Don't stuff size_t into an 'int'.
6469 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6470 about possible signed overflow.
6471
6048fb2a
PE
6472 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6473 (GDK_KEY_g): Don't define if already defined.
6474 (xg_prepare_tooltip): Avoid pointer signedness problem.
6475 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6476
fa3c87e1
PE
6477 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6478 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6479
2172544b
PE
6480 * xfns.c (Fx_window_property): Simplify a bit,
6481 to make a bit faster and to avoid GCC 4.6.0 warning.
6482 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6483
9b821a21
PE
6484 * fns.c (internal_equal): Don't assume size_t fits in int.
6485
3c616cfa
PE
6486 * alloc.c (compact_small_strings): Tighten assertion a little.
6487
c2982e87
PE
6488 Replace pEd with more-general pI, and fix some printf arg casts.
6489 * lisp.h (pI): New macro, generalizing old pEd macro to other
6490 conversion specifiers. For example, use "...%"pI"d..." rather
6491 than "...%"pEd"...".
6492 (pEd): Remove. All uses replaced with similar uses of pI.
6493 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6494 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6495 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6496 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6497 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6498 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6499 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6500 64-bit hosts.
6501 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6502 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6503 * print.c (safe_debug_print, print_object): Likewise.
6504 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6505 to int.
6f04d126
PE
6506 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6507 avoiding the 0 flag, which is not portable.
c2982e87
PE
6508 * process.c (Fmake_network_process): Use pI to avoid cast.
6509 * region-cache.c (pp_cache): Likewise.
6510 * xdisp.c (decode_mode_spec): Likewise.
6511 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6512 behavior on 64-bit hosts with printf arg.
6f04d126 6513 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6514 (x_stop_queuing_selection_requests): Likewise.
6515 (x_get_window_property): Don't truncate byte count to an 'int'
6516 when tracing.
0b432f21 6517
5e073ec7
PE
6518 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6519 here, since it parses constructs like leading '-' and spaces,
6520 which are not wanted; and it overflows with large numbers.
6521 Instead, simply match F[0-9]+, which is what is wanted anyway.
6522
36372bf9
PE
6523 * alloc.c: Remove unportable assumptions about struct layout.
6524 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6525 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6526 (allocate_vectorlike, make_pure_vector): Use the new macros,
6527 plus offsetof, to remove unportable assumptions about struct layout.
6528 These assumptions hold on all porting targets that I know of, but
6529 they are not guaranteed, they're easy to remove, and removing them
6530 makes further changes easier.
6531
0b432f21
PE
6532 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6533 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6534 (string_overrun_cookie): Now const. Use initializers that
6535 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6536 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6537 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6538 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6539 multiple of sizeof (EMACS_INT); it need not be, if
6540 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6541 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6542
895009e1
JB
65432011-04-26 Juanma Barranquero <lekktu@gmail.com>
6544
6545 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6546
6a7a1b0b
TZ
65472011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6548
6549 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6550 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6551 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6552
841a1577 65532011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6554
6555 * lisp.h (Qdebug): List symbol.
895009e1 6556 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6557 * keyboard.c (debug-on-event): New variable.
6558 (handle_user_signal): Break into debugger when debug-on-event
6559 matches the current signal symbol.
6560
f2d3ba6f
DN
65612011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6562
6563 * alloc.c (check_sblock, check_string_bytes)
6564 (check_string_free_list): Convert to standard C.
6565
42ce4c63
TZ
65662011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6567
6568 * w32.c (emacs_gnutls_push): Fix typo.
6569
825cd63c
EZ
65702011-04-25 Eli Zaretskii <eliz@gnu.org>
6571
fb11d64d
EZ
6572 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6573 "cast to pointer from integer of different size".
6574
825cd63c
EZ
6575 Improve doprnt and its use in verror. (Bug#8545)
6576 * doprnt.c (doprnt): Document the set of format control sequences
6577 supported by the function. Use SAFE_ALLOCA instead of always
6578 using `alloca'.
6579
6580 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6581 is one byte too soon. Don't use xrealloc; instead xfree and
6582 xmalloc anew.
6583
e061a11b
TZ
65842011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6585
6586 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6587 callbacks stage.
6588
6589 * gnutls.c: Renamed global_initialized to
6590 gnutls_global_initialized. Added internals for the
6591 :verify-hostname-error, :verify-error, and :verify-flags
6592 parameters of `gnutls-boot' and documented those parameters in the
6593 docstring. Start callback support.
9173deec
JB
6594 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6595 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6596 on error. Return error code.
e061a11b
TZ
6597 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6598 (emacs_gnutls_read): Likewise.
6599 (Fgnutls_boot): Return handshake error code.
6600 (emacs_gnutls_handle_error): New function.
6601 (wsaerror_to_errno): Likewise.
6602
6603 * w32.h (emacs_gnutls_pull): Add prototype.
6604 (emacs_gnutls_push): Likewise.
6605
6606 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6607 (emacs_gnutls_push): Likewise.
6608
66092011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6610
6611 * process.c (wait_reading_process_output): Check if GnuTLS
6612 buffered some data internally if no FDs are set for TLS
6613 connections.
6614
6615 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6616 (LIBS): Link to USER_LIBS.
6617 ($(BLD)/gnutls.$(0)): New target.
6618
fa6996bc
EZ
66192011-04-24 Eli Zaretskii <eliz@gnu.org>
6620
eb35682e
EZ
6621 * xdisp.c (handle_single_display_spec): Rename the
6622 display_replaced_before_p argument into display_replaced_p, to
6623 make it consistent with the commentary. Fix typos in the
6624 commentary.
6625
e2ad650c
EZ
6626 * textprop.c (syms_of_textprop): Remove dead code.
6627 (copy_text_properties): Delete obsolete commentary about an
6628 interface that was deleted long ago. Fix typos in the description
6629 of arguments.
6630
1b2de274
EZ
6631 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6632 to changes in oldXMenu/XMenu.h from 2011-04-16.
6633 <menu_help_message, prev_menu_help_message>: Constify.
6634 (IT_menu_make_room): menu->help_text is now `const char **';
6635 adjust.
6636
6637 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6638 to changes in oldXMenu/XMenu.h from 2011-04-16.
6639 (struct XMenu): Declare `help_text' `const char **'.
6640
6641 * xfaces.c <Qunspecified>: Make extern again.
6642
6643 * syntax.c: Include sys/types.h before including regex.h, as
6644 required by Posix.
6645
762b15be
EZ
6646 * doc.c (get_doc_string): Improve the format passed to `error'.
6647
6648 * doprnt.c (doprnt): Improve commentary.
6649
6650 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6651
6652 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6653 them with etags.
6654
f1052e5d
EZ
6655 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6656 changes in globals.h immediately force recompilation.
762b15be
EZ
6657 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6658 $(CURDIR)/s/ms-w32.h.
6659 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6660
fa6996bc
EZ
6661 * character.c (Fchar_direction): Function deleted.
6662 (syms_of_character): Don't defsubr it.
6663 <char-direction-table>: Deleted.
6664
e6c3da20
EZ
66652011-04-23 Eli Zaretskii <eliz@gnu.org>
6666
6667 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6668 * doprnt.c: Include limits.h.
6669 (SIZE_MAX): New macro.
04f2d78b
CB
6670 (doprnt): Return a size_t value. 2nd arg is now size_t.
6671 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6672 Improve overflow protection. Support `l' modifier for integer
6673 conversions. Support %l conversion. Don't assume an EMACS_INT
6674 argument for integer conversions and for %c.
6675
6676 * lisp.h (doprnt): Restore prototype.
6677
6678 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6679 $(SRC)/character.h.
6680
6681 * Makefile.in (base_obj): Add back doprnt.o.
6682
6683 * deps.mk (doprnt.o): Add back prerequisites.
6684 (callint.o): Depend on character.h.
6685
6686 * eval.c (internal_lisp_condition_case): Include the handler
6687 representation in the error message.
6688 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6689 when breaking from the loop.
6690
6691 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6692
6693 * callint.c (Fcall_interactively): When displaying error message
6694 about invalid control letter, pass the character's codepoint, not
6695 a pointer to its multibyte form. Improve display of the character
6696 in octal and display also its hex code.
6697
6698 * character.c (char_string): Use %x to display the (unsigned)
6699 codepoint of an invalid character, to avoid displaying a bogus
6700 negative value.
6701
6702 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6703 `error', not SYMBOL_NAME itself.
6704
6705 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6706 character arguments to `error'.
6707
6708 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6709 to `error' in error message about FINAL_CHAR argument. Make sure
6710 FINAL_CHAR is a character, and use %c when it is passed as
6711 argument to `error'.
6712
4ffd0d6b 67132011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6714
6715 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6716
6717 * w32.c: Include <time.h>.
6718 (sys_localtime): New function.
6719
4ffd0d6b 67202011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6721
6722 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6723
4ffd0d6b 6724 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6725
4ffd0d6b 67262011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6727
4ffd0d6b
GM
6728 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6729 zombies (Bug#8467).
aac0c6e3 6730
04c56954
EZ
67312011-04-19 Eli Zaretskii <eliz@gnu.org>
6732
6733 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6734 gl_state.e_property when gl_state.object is Qt.
6735
6736 * insdel.c (make_gap_larger): Remove limitation of buffer size
6737 to <= INT_MAX.
6738
16a43933
CY
67392011-04-18 Chong Yidong <cyd@stupidchicken.com>
6740
6741 * xdisp.c (lookup_glyphless_char_display)
6742 (produce_glyphless_glyph): Handle cons cell entry in
6743 glyphless-char-display.
6744 (Vglyphless_char_display): Document it.
6745
6746 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6747 glyphless-char-display.
6748
4581706e
CY
67492011-04-17 Chong Yidong <cyd@stupidchicken.com>
6750
6751 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6752
6753 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6754
6755 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6756 definition for no-X builds.
6757
4887c6e2 67582011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6759
fd35b6f9
PE
6760 Static checks with GCC 4.6.0 and non-default toolkits.
6761
5c1ccb01
PE
6762 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6763
006c5daa
PE
6764 * process.c (keyboard_bit_set): Define only if SIGIO.
6765 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6766 (send_process): Repair possible setjmp clobbering.
6767
efc736d3
PE
6768 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6769
4e2fe2e6
PE
6770 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6771
f97334a2
PE
6772 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6773
4e75f29d
PE
6774 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6775 Define only if needed.
6776
90efadd1
PE
6777 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6778 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6779 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6780
3c647824
PE
6781 * dispextern.h (struct redisplay_interface): Rename param
6782 to avoid shadowing.
e264f262 6783 * termhooks.h (struct terminal): Likewise.
761383f4 6784 * xterm.c (xembed_send_message): Likewise.
3c647824 6785
b58c5c4a
PE
6786 * insdel.c (make_gap_smaller): Define only if
6787 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6788
cad59032
PE
6789 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6790 it.
6791
c339dc2e
PE
6792 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6793 so that we aren't warned about unused symbols.
6794
91a3e27b
PE
6795 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6796
399c71d3 6797 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6798
8ffc96f5
PE
6799 * xfns.c (x_real_positions): Mark locals as initialized.
6800
eef9bc79
PE
6801 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6802
098db9dd
PE
6803 * xterm.c: Fix problems found by static analysis with other toolkits.
6804 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6805 (x_dispatch_event): Declare static if USE_GTK, and
6806 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6807 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6808 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6809 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6810 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6811
eb18f6cc
PE
6812 * xmenu.c (menu_help_callback): Pointer type fixes.
6813 Use const pointers when pointing at readonly data. Avoid pointer
6814 signedness clashes.
6815 (FALSE): Remove unused macro.
6816 (update_frame_menubar): Remove unused decl.
6817
1fe72bf8
PE
6818 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6819
60d9e1db
PE
6820 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6821 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6822 (single_menu_item): Rename local to avoid shadowing.
6823
39261c26
PE
6824 * keyboard.c (make_lispy_event): Remove unused local var.
6825
018c5e19
PE
6826 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6827 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6828
63d2b86e
PE
6829 * bitmaps: Change bitmaps from unsigned char back to the X11
6830 compatible char. Avoid the old compiler warnings about
6831 out-of-range initializers by using, for example, '\xab' rather
6832 than 0xab.
6833
aefd87e1
PE
6834 * xgselect.c (xgselect_initialize): Check vs interface
6835 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6836
bf501fb9
PE
6837 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6838
e9829fdf
PE
6839 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6840 to read-only memory.
6841
1086c095
PE
6842 * fns.c (vector): Remove; this old hack is no longer needed.
6843
2baccd04 6844 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6845 Remove unused var.
dde42981 6846 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6847
72391843 6848 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6849
436c16df 6850 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6851 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6852 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6853
92bb796d 6854 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6855 (x_term_init): Remove local to avoid shadowing.
92bb796d 6856
764430a3 6857 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6858
6859 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6860 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6861
d1dfb56c
EZ
68622011-04-16 Eli Zaretskii <eliz@gnu.org>
6863
c4354cb4
EZ
6864 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6865
d1dfb56c
EZ
6866 Fix regex.c, syntax.c and friends for buffers > 2GB.
6867 * syntax.h (struct gl_state_s): Declare character position members
6868 EMACS_INT.
6869
6870 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6871
04f2d78b
CB
6872 * textprop.c (verify_interval_modification, interval_of):
6873 Declare arguments EMACS_INT.
d1dfb56c
EZ
6874
6875 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6876 EMACS_INT.
6877
6878 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6879
6880 * indent.c (Fvertical_motion): Local variable it_start is now
6881 EMACS_INT.
6882
6883 * regex.c (re_match, re_match_2, re_match_2_internal)
6884 (bcmp_translate, regcomp, regexec, print_double_string)
6885 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6886 (re_compile_pattern, re_exec): Declare arguments and local
6887 variables `size_t' and `ssize_t' and return values `regoff_t', as
6888 appropriate.
6889 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6890 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6891 <compile_stack_type>: `size' and `avail' are now `size_t'.
6892
6893 * regex.h <regoff_t>: Use ssize_t, not int.
6894 (re_search, re_search_2, re_match, re_match_2): Arguments that
6895 specify buffer/string position and length are now ssize_t and
6896 size_t. Return type is regoff_t.
6897
613052cd
BK
68982011-04-16 Ben Key <bkey76@gmail.com>
6899
6900 * nsfont.m: Fixed bugs in ns_get_family and
6901 ns_descriptor_to_entity that were caused by using free to
6902 deallocate memory blocks that were allocated by xmalloc (via
6903 xstrdup). This caused Emacs to crash when compiled with
6904 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6905 --enable-checking=xmallocoverrun). xfree is now used to
6906 deallocate these memory blocks.
6907
4170f62f 69082011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6909
71b41406
PE
6910 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6911
9587a89d
PE
6912 emacs_write: Accept and return EMACS_INT for sizes.
6913 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6914 et seq.
6915 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6916 Accept and return EMACS_INT.
6917 (emacs_gnutls_write): Return the number of bytes written on
6918 partial writes.
6919 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6920 (emacs_read, emacs_write): Remove check for negative size, as the
6921 Emacs source code has been audited now.
9587a89d
PE
6922 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6923 (emacs_read, emacs_write): Use it.
273a5f82
PE
6924 * process.c (send_process): Adjust to the new signatures of
6925 emacs_write and emacs_gnutls_write. Do not attempt to store
6926 a byte offset into an 'int'; it might overflow.
9587a89d 6927 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6928
3e047f51
PE
6929 * sound.c: Don't assume sizes fit in 'int'.
6930 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6931 Return EMACS_INT, not int.
3e047f51 6932 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6933 Accept EMACS_INT, not int.
6934 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6935 record read return values.
6936
cc39a9db
BK
69372011-04-15 Ben Key <bkey76@gmail.com>
6938
c9d0ec6d
JB
6939 * keyboard.c (Qundefined): Don't declare static since it is used
6940 in nsfns.m.
6941 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6942 static since they are used in nsfont.m.
cc39a9db 6943
6c60eb9f
SM
69442011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6945
6946 * process.c (Qprocessp): Don't declare static.
6947 * lisp.h (Qprocessp): Declare again.
6948
7990b61a
JB
69492011-04-15 Juanma Barranquero <lekktu@gmail.com>
6950
6951 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6952
5d4cb038
PE
69532011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6954
8bd7b830 6955 Improve C-level modularity by making more things 'static'.
cd64ea1d 6956
e3b27b31
PE
6957 Don't publish debugger-only interfaces to other modules.
6958 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6959 (verify_bytepos, count_markers): Move decls to the only modules
6960 that need them.
6961 * region-cache.h (pp_cache): Likewise.
6962 * window.h (check_all_windows): Likewise.
6963 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6964
5d4cb038
PE
6965 * sysdep.c (croak): Now static, if
6966 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6967 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6968
6969 * alloc.c (refill_memory_reserve): Now static if
6970 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6971 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6972
e87b6180
PE
6973 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6974 Define only if USE_LUCID.
6975
ac64929e
PE
6976 * xrdb.c (x_customization_string, x_rm_string): Now static.
6977
6f37259d
PE
6978 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6979 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6980
1683e3ab
PE
6981 * xdisp.c (draw_row_with_mouse_face): Now static.
6982 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6983
de9c2632
PE
6984 * window.h (check_all_windows): Mark externally visible.
6985
2b96acb7
PE
6986 * window.c (window_deletion_count): Now static.
6987
6988 * undo.c: Make symbols static if they're not exported.
6989 (last_undo_buffer, last_boundary_position, pending_boundary):
6990 Now static.
6991
50436f33
PE
6992 * textprop.c (interval_insert_behind_hooks): Now static.
6993 (interval_insert_in_front_hooks): Likewise.
6994
64520e5c
PE
6995 * term.c: Make symbols static if they're not exported.
6996 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6997 (max_frame_lines, tty_set_terminal_modes):
6998 (tty_reset_terminal_modes, tty_turn_off_highlight):
6999 (get_tty_terminal): Now static.
7000 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7001 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7002 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7003 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7004 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7005
1fa53021
PE
7006 * sysdep.c: Make symbols static if they're not exported.
7007 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7008 Now static.
7009 (sigprocmask_set, full_mask): Remove; unused.
7010 (wait_debugging): Mark as visible.
7011 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7012 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7013
d4b43b22
PE
7014 * syntax.c (syntax_temp): Define only if !__GNUC__.
7015
b7c513d0
PE
7016 * sound.c (current_sound_device, current_sound): Now static.
7017
989b29ad
PE
7018 * search.c (searchbufs, searchbuf_head): Now static.
7019
13a55a78
PE
7020 * scroll.c (scroll_cost): Remove; unused.
7021 * dispextern.h (scroll_cost): Remove decl.
7022
de68a1fc
PE
7023 * region-cache.h (pp_cache): Mark as externally visible.
7024
40ccffa6
PE
7025 * process.c: Make symbols static if they're not exported.
7026 (process_tick, update_tick, create_process, chan_process):
7027 (Vprocess_alist, proc_buffered_char, datagram_access):
7028 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7029 (deactivate_process): Mark defn as static, as well as decl.
7030 * lisp.h (create_process): Remove decl.
7031 * process.h (chan_process, Vprocess_alist): Remove decls.
7032
ad64fc97
PE
7033 * print.c: Make symbols static if they're not exported.
7034 (print_depth, new_backquote_output, being_printed, print_buffer):
7035 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7036 (print_interval, print_number_index, initial_stderr_stream):
7037 Now static.
7038 * lisp.h (Fprinc): Remove decl.
7039 (debug_output_compilation_hack): Mark as externally visible.
7040
adddb265
PE
7041 * sysdep.c (croak): Move decl from here to syssignal.h.
7042 * syssignal.h (croak): Put it here, so the API can be checked when
7043 'croak' is called from dissociate_if_controlling_tty.
7044
1717ede2
PE
7045 * minibuf.c: Make symbols static if they're not exported.
7046 (minibuf_save_list, choose_minibuf_frame): Now static.
7047 * lisp.h (choose_minibuf_frame): Remove decl.
7048
fa5fb2bc
PE
7049 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7050
1e3890d1
PE
7051 * lread.c: Make symbols static if they're not exported.
7052 (read_objects, initial_obarray, oblookup_last_bucket_number):
7053 Now static.
7054 (make_symbol): Remove; unused.
7055 * lisp.h (initial_obarray, make_symbol): Remove decls.
7056
8a1414fa
PE
7057 * keyboard.c: Make symbols static if they're not exported.
7058 (single_kboard, recent_keys_index, total_keys, recent_keys):
7059 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7060 (this_single_command_key_start, echoing, last_auto_save):
7061 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7062 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7063 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7064 (Vlispy_mouse_stem, double_click_count):
7065 Now static.
7066 (force_auto_save_soon): Define only if SIGDANGER.
7067 (ignore_mouse_drag_p): Now static if
7068 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7069 (print_help): Remove; unused.
7070 (stop_character, last_timer_event): Mark as externally visible.
7071 * keyboard.h (ignore_mouse_drag_p): Declare only if
7072 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7073 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7074 * lisp.h (echoing): Remove decl.
7075 (force_auto_save_soon): Declare only if SIGDANGER.
7076 * xdisp.c (redisplay_window): Simplify code, to make it more
7077 obvious that ignore_mouse_drag_p is not accessed if !defined
7078 USE_GTK && !defined HAVE_NS.
7079
93ea6e8f
PE
7080 * intervals.c: Make symbols static if they're not exported.
7081 (merge_properties_sticky, merge_interval_right, delete_interval):
7082 Now static.
7083 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7084
77382fcc
PE
7085 * insdel.c: Make symbols static if they're not exported.
7086 However, leave prepare_to_modify_buffer alone. It's never
7087 called from outside this function, but that appears to be a bug.
7088 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7089 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7090 (adjust_after_replace_noundo): Remove; unused.
7091 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7092 (signal_before_change): Remove decls.
77382fcc 7093
9306c32e
PE
7094 * indent.c (val_compute_motion, val_vmotion): Now static.
7095
cd44d2eb
PE
7096 * image.c: Make symbols static if they're not exported.
7097 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7098 if USE_GTK.
7099 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7100 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7101
ad9a7a06
PE
7102 * fringe.c (standard_bitmaps): Now static.
7103 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7104
81626931
PE
7105 * frame.c: Make symbols static if they're not exported.
7106 (x_report_frame_params, make_terminal_frame): Now static.
7107 (get_frame_param): Now static, unless HAVE_NS.
7108 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7109 (x_get_resource_string): Remove; not used.
7110 * frame.h (make_terminal_frame, x_report_frame_params):
7111 (x_get_resource_string); Remove decls.
7112 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7113 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7114
239f9db9
PE
7115 * font.c, fontset.c: Make symbols static if they're not exported.
7116 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7117 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7118 * font.c (font_close_object): Now static.
7119 * font.h (font_close_object): Remove.
7120 * fontset.c (FONTSET_OBJLIST): Remove.
7121 (free_realized_fontset) #if-0 the body, which does nothing.
7122 (face_suitable_for_char_p): #if-0, as it's never called.
7123 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7124 * xfaces.c (face_at_string_position):
7125 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7126 since 0 is always ASCII.
7127
dfcf3579
PE
7128 * fns.c (weak_hash_tables): Now static.
7129
5045092b
PE
7130 * fileio.c: Make symbols static if they're not exported.
7131 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7132 (Vwrite_region_annotation_buffers): Now static.
7133
57a96f5c
PE
7134 * eval.c: Make symbols static if they're not exported.
7135 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7136 * lisp.h (backtrace_list): Remove decl.
7137
35f08c38
PE
7138 * emacs.c: Make symbols static if they're not exported.
7139 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7140 (fatal_error_code, fatal_error_signal_hook, standard_args):
7141 Now static.
7142 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7143 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7144 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7145 * lisp.h (fatal_error_signal_hook): Remove decl.
7146 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7147
f44bd759
PE
7148 * editfns.c: Move a (normally-unused) function to its only use.
7149 * editfns.c, lisp.h (get_operating_system_release): Remove.
7150 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7151 worth the hassle of breaking this out.
7152
b532497d
PE
7153 * xterm.c: Make symbols static if they're not exported.
7154 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7155 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7156 (x_destroy_window, x_delete_display):
7157 Now static.
7158 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7159 (x_mouse_leave): Remove; unused.
7160 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7161 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7162 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7163 Remove decls.
7164 (x_mouse_leave): Declare only if WINDOWSNT.
7165 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7166 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7167 USE_X_TOOLKIT.
7168
1675728f
PE
7169 * ftxfont.c: Make symbols static if they're not exported.
7170 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7171 HAVE_FREETYPE.
7172 * font.h (ftxfont_driver): Likewise.
7173
e4cebfca
PE
7174 * xfns.c: Make symbols static if they're not exported.
7175 (x_last_font_name, x_display_info_for_name):
7176 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7177 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7178 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7179 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7180 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7181 (last_show_tip_args): Now static.
7182 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7183 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7184 (x_screen_planes): Remove; unused.
7185 * dispextern.h (x_screen_planes): Remove decl.
7186
5bf46f05
PE
7187 * dispnew.c: Make symbols static if they're not exported.
7188 * dispextern.h (redraw_garbaged_frames, scrolling):
7189 (increment_row_positions): Remove.
7190 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7191 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7192 Now static.
7193 (redraw_garbaged_frames): Remove; unused.
7194
435f4c28
PE
7195 * xfaces.c: Make symbols static if they're not exported.
7196 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7197 Remove decls.
7198 * xterm.h (defined_color): Remove decls.
7199 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7200 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7201 (menu_face_changed_default, defined_color, free_realized_face):
7202 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7203 (ascii_face_of_lisp_face): Remove; unused.
7204
8524aef3
PE
7205 * xdisp.c: Make symbols static if they're not exported.
7206 * dispextern.h (scratch_glyph_row, window_box_edges):
7207 (glyph_to_pixel_coords, set_cursor_from_row):
7208 (get_next_display_element, set_iterator_to_next):
7209 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7210 (show_mouse_face): Remove decls
7211 * frame.h (message_buf_print): Likewise.
7212 * lisp.h (pop_message, set_message, check_point_in_composition):
7213 Likewise.
7214 * xterm.h (set_vertical_scroll_bar): Likewise.
7215 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7216 (message_buf_print, scratch_glyph_row, displayed_buffer):
7217 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7218 (get_next_display_element, show_mouse_face, window_box_edges):
7219 (frame_to_window_pixel_xy, check_point_in_composition):
7220 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7221 (glyph_to_pixel_coords): Remove; unused.
7222
16390cd2
PE
7223 * dired.c (file_name_completion): Now static.
7224
7225 * dbusbind.c (xd_in_read_queued_messages): Now static.
7226
a25f4dfa
PE
7227 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7228 * data.c (circular_list_error): Remove.
7229
14a9c8df
PE
7230 * commands.h (last_point_position, last_point_position_buffer):
7231 (last_point_position_window): Remove decls.
7232 * keyboard.c: Make these variables static.
7233
04f2d78b
CB
7234 * coding.h (coding, code_convert_region, encode_coding_gap):
7235 Remove decls.
74ab6df5
PE
7236 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7237 (iso_code_class, detect_coding, code_convert_region): Now static.
7238 (encode_coding_gap): Remove; unused.
7239
38dfbee1
PE
7240 * chartab.c (chartab_chars, chartab_bits): Now static.
7241
a2cb4e63
PE
7242 * charset.h (charset_iso_8859_1): Remove decl.
7243 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7244 Now static.
7245
127198fd
PE
7246 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7247 * ccl.c (Vccl_program_table): Now static.
7248 (check_ccl_update): Remove; unused.
7249
d85b608f
PE
7250 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7251 * category.h: ... from here.
7252 * category.c (check_category_table, set_category_set): Now static.
7253
31cd66f3
PE
7254 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7255 * lisp.h: Remove these decls.
7256
c358e587
PE
7257 * buffer.c (buffer_count): Remove unused var.
7258
e78aecca
PE
7259 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7260 so that it's not optimized away.
7261 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7262 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7263 exported only to the debugger.
7264
e192d7d3 7265 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7266 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7267
92470028
PE
7268 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7269 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7270 was inaccessible from Lisp.
7271 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7272 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7273
244ed907
PE
7274 alloc.c: Import and export fewer symbols, and remove unused items.
7275 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7276 is defined.
7277 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7278 it's not optimized away by whole-program optimization.
7279 (message_enable_multibyte, free_misc): Remove.
7280 (catchlist, handlerlist, mark_backtrace):
7281 Declare only if BYTE_MARK_STACK.
7282 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7283 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7284 (message_enable_multibyte): Remove decl.
7285 (free_misc, interval_free_list, float_block, float_block_index):
7286 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7287 (cons_free_list, last_marked_index):
7288 Now static.
7289 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7290 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7291 (mark_backtrace): Define only if BYTE_MARK_STACK.
7292 * xdisp.c (message_enable_multibyte): Now static.
7293
61c2b50e 7294 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7295 This makes it easier for human readers (and static analyzers)
7296 to see whether these variables are used from other modules.
7297 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7298 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7299 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7300 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7301 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7302 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7303 * xmenu.c, xselect.c:
7304 Declare Q* vars static if they are not used in other modules.
7305 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7306 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7307 Remove decls of unexported vars.
7308 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7309
95c82688
PE
7310 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7311
16a97296
PE
7312 Make Emacs functions such as Fatom 'static' by default.
7313 This makes it easier for human readers (and static analyzers)
7314 to see whether these functions can be called from other modules.
7315 DEFUN now defines a static function. To make the function external
7316 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7317 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7318 (Finit_image_library):
16a97296
PE
7319 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7320 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7321 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7322 Remove decls, since these functions are now static.
7323 (Funintern, Fget_internal_run_time): New decls, since these functions
7324 were already external.
95c82688 7325
16a97296
PE
7326 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7327 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7328 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7329 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7330 * keyboard.c, keymap.c, lread.c:
7331 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7332 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7333 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7334 Mark functions with DEFUE instead of DEFUN,
7335 if they are used in other modules.
7336 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7337 decls for now-static functions.
7338 * buffer.h (Fdelete_overlay): Remove decl.
7339 * callproc.c (Fgetenv_internal): Mark as internal.
7340 * composite.c (Fremove_list_of_text_properties): Remove decl.
7341 (Fcomposition_get_gstring): New forward static decl.
7342 * composite.h (Fcomposite_get_gstring): Remove decl.
7343 * dired.c (Ffile_attributes): New forward static decl.
7344 * doc.c (Fdocumntation_property): New forward static decl.
7345 * eval.c (Ffetch_bytecode): New forward static decl.
7346 (Funintern): Remove extern decl; now in .h file where it belongs.
7347 * fileio.c (Fmake_symbolic_link): New forward static decl.
7348 * image.c (Finit_image_library): New forward static decl.
7349 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7350 * intervals.h (Fprevious_property_change):
7351 (Fremove_list_of_text_properties): Remove decls.
7352 * keyboard.c (Fthis_command_keys): Remove decl.
7353 (Fcommand_execute): New forward static decl.
7354 * keymap.c (Flookup_key): New forward static decl.
7355 (Fcopy_keymap): Now static.
7356 * keymap.h (Flookup_key): Remove decl.
7357 * process.c (Fget_process): New forward static decl.
7358 (Fprocess_datagram_address): Mark as internal.
7359 * syntax.c (Fsyntax_table_p): New forward static decl.
7360 (skip_chars): Remove duplicate decl.
7361 * textprop.c (Fprevious_property_change): New forward static decl.
7362 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7363 Now internal.
7364 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7365 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7366
785bbd42
PE
7367 * editfns.c (Fformat): Remove unreachable code.
7368
8b913b57
AS
73692011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7370
7371 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7372 change. (Bug#8496)
7373
a6744a35
EZ
73742011-04-13 Eli Zaretskii <eliz@gnu.org>
7375
7376 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7377 when at ZV. (Bug#8487)
7378
e7974947
AS
73792011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7380
baad03f0
AS
7381 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7382 (Bug#8437)
7383 * keyboard.c (parse_tool_bar_item): Likewise.
7384 * sound.c (sound_cleanup, alsa_close): Likewise.
7385 * termcap.c (tgetent): Likewise.
7386 * xfns.c (x_default_font_parameter): Likewise.
7387 * xsettings.c (read_and_apply_settings): Likewise.
7388
e7974947
AS
7389 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7390 (overrun_check_free): Protoize.
7391
28272684
PE
73922011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7393
7394 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7395 since callers should never pass a negative size.
7396 Change the signature to match that of plain 'read' and 'write'; see
7397 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7398 * lisp.h: Update prototypes of emacs_write and emacs_read.
7399
11997c76
EZ
74002011-04-11 Eli Zaretskii <eliz@gnu.org>
7401
7402 * xdisp.c (redisplay_window): Don't try to determine the character
7403 position of the scroll margin if the window start point w->startp
e896f03c 7404 is outside the buffer's accessible region. (Bug#8468)
11997c76 7405
8a2cbd72
EZ
74062011-04-10 Eli Zaretskii <eliz@gnu.org>
7407
7408 Fix write-region and its subroutines for buffers > 2GB.
7409 * fileio.c (a_write, e_write): Modify declaration of arguments and
7410 local variables to support buffers larger than 2GB.
7411 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7412
7413 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7414 argument, local variables, and return value.
7415
7416 * lisp.h: Update prototypes of emacs_write and emacs_read.
7417
7418 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7419
4073e537 74202011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7421
1ebfdcb6
PE
7422 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7423
b2ded58d
PE
7424 Fix more problems found by GCC 4.6.0's static checks.
7425
7d66342c
PE
7426 * xdisp.c (vmessage): Use a better test for character truncation.
7427
bbf47d44
PE
7428 * charset.c (load_charset_map): <, not <=, for optimization,
7429 and to avoid potential problems with integer overflow.
9248994d 7430 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7431 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7432 * editfns.c (Fformat): Likewise.
1e69125e 7433 * syntax.c (skip_chars): Likewise.
3befa583 7434
e3019616
PE
7435 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7436 This also lets GCC 4.6.0 generate slightly better loop code.
7437
becfa255
PE
7438 * callint.c (Fcall_interactively): <, not <=, for optimization.
7439 (Fcall_interactively): Count the number of arguments produced,
7440 not the number of arguments given. This is simpler and lets GCC
7441 4.6.0 generate slightly better code.
7442
dae0cd48
PE
7443 * ftfont.c: Distingish more carefully between FcChar8 and char.
7444 The previous code passed unsigned char * to a functions like
7445 strlen and xstrcasecmp that expect char *, which does not
7446 conform to the C standard.
7447 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7448 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7449 char * when the C standard requires it.
7450
76032d70
PE
7451 * keyboard.c (read_char): Remove unused var.
7452
eb3f1cc8
PE
7453 * eval.c: Port to Windows vsnprintf (Bug#8435).
7454 Include <limits.h>.
7455 (SIZE_MAX): Define if the headers do not.
7456 (verror): Do not give up if vsnprintf returns a negative count.
7457 Instead, grow the buffer. This ports to Windows vsnprintf, which
7458 does not conform to C99. Problem reported by Eli Zaretskii.
7459 Also, simplify the allocation scheme, by avoiding the need for
7460 calling realloc, and removing the ALLOCATED variable.
7461
70476b54
PE
7462 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7463
12020a9e
PE
7464 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7465 But keep the doprint source code for now, as we might revamp it
7466 and use it again (Bug#8435).
ea6c7ae6
PE
7467 * lisp.h (doprnt): Remove.
7468 * Makefile.in (base_obj): Remove doprnt.o.
7469 * deps.mk (doprnt.o): Remove.
7470
5fdb398c
PE
7471 error: Print 32- and 64-bit integers portably (Bug#8435).
7472 Without this change, on typical 64-bit hosts error ("...%d...", N)
7473 was used to print both 32- and 64-bit integers N, which relied on
7474 undefined behavior.
7475 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7476 New macro.
7477 * lisp.h (error, verror): Mark as printf-like functions.
7478 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7479 Report overflow in size calculations when allocating printf buffer.
7480 Do not truncate output string at its first null byte.
7481 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7482 Truncate the output at a character boundary, since vsnprintf does not
7483 do that.
7484 * charset.c (check_iso_charset_parameter): Convert internal
7485 character to string before calling 'error', since %c now has the
7486 printf meaning.
7487 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7488 overflow when computing char to be passed to 'error'. Do not
7489 pass Lisp_Object to 'error'; pass the integer instead.
7490 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7491 formatted with plain %d.
7492
b189fa66
PE
7493 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7494
bff87ef0
PE
7495 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7496
7e2cac20
PE
7497 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7498
ce4d90b5
PE
7499 * xterm.c (x_catch_errors): Remove duplicate declaration.
7500
266c9547
PE
7501 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7502
79c49ad2
PE
7503 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7504
368f4090
JM
75052011-04-10 Jim Meyering <meyering@redhat.com>
7506
7507 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7508 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7509 return ssize_t not "int", and use size_t as the buffer length.
7510 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7511 * gnutls.h: Update declarations.
7512 * process.c (read_process_output): Use ssize_t, to match.
7513 (send_process): Likewise.
7514
a32d4040
CY
75152011-04-09 Chong Yidong <cyd@stupidchicken.com>
7516
7517 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7518
8546720e 75192011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7520
04f2d78b
CB
7521 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7522 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7523
8546720e
GM
7524 * xterm.c (handle_one_xevent):
7525 * xmenu.c (create_and_show_popup_menu):
7526 * xselect.c (x_decline_selection_request)
7527 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7528
0a2f5c1a 75292011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7530
7531 Fix some uses of `int' instead of EMACS_INT.
7532 * search.c (string_match_1, fast_string_match)
7533 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7534 (scan_buffer, find_next_newline_no_quit)
7535 (find_before_next_newline, search_command, Freplace_match)
7536 (Fmatch_data): Make some `int' variables be EMACS_INT.
7537
7538 * xdisp.c (display_count_lines): 3rd argument and return value now
7539 EMACS_INT. All callers changed.
7540 (pint2hrstr): Last argument is now EMACS_INT.
7541
7542 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7543 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7544 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7545 (decode_coding_utf_16, decode_coding_emacs_mule)
7546 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7547 (decode_coding_ccl, decode_coding_charset)
7548 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7549 (decode_coding_iso_2022, decode_coding_emacs_mule)
7550 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7551 <char_offset, last_offset>: Declare EMACS_INT.
7552 (encode_coding_utf_8, encode_coding_utf_16)
7553 (encode_coding_emacs_mule, encode_invocation_designation)
7554 (encode_designation_at_bol, encode_coding_iso_2022)
7555 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7556 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7557 Declare EMACS_INT.
7558 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7559 (encode_invocation_designation): Last argument P_NCHARS is now
7560 EMACS_INT.
7561 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7562 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7563
7564 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7565 All users changed.
7566
7567 * ccl.c (Fccl_execute_on_string): Declare some variables
7568 EMACS_INT.
7569
8546720e 75702011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7571
7572 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7573
4e19a977
CS
75742011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7575
7576 * process.c (Fformat_network_address): Doc fix.
7577
87302331
R
75782011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7579
ee7683eb 7580 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7581
cbb59342
CY
75822011-04-08 Chong Yidong <cyd@stupidchicken.com>
7583
7584 * keyboard.c (read_char): Call Lisp function help-form-show,
7585 instead of using internal_with_output_to_temp_buffer.
7586 (Qhelp_form_show): New var.
e0d38eeb 7587 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7588
7589 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7590
7591 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7592
e67a13ab
CY
75932011-04-06 Chong Yidong <cyd@stupidchicken.com>
7594
04f2d78b
CB
7595 * process.c (Flist_processes): Remove to Lisp.
7596 (list_processes_1): Delete.
e67a13ab 7597
973f782d
EZ
75982011-04-06 Eli Zaretskii <eliz@gnu.org>
7599
7c106b1e
EZ
7600 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7601
973f782d
EZ
7602 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7603
41cf7d1a 76042011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7605
ca23cc88
PE
7606 Fix more problems found by GCC 4.6.0's static checks.
7607
f390e2d5
PE
7608 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7609
42eea0d0
PE
7610 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7611
b69769da 7612 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7613
f9541e84
PE
7614 * xdisp.c (vmessage): Mark as a printf-like function.
7615
13841b55
PE
7616 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7617
c136c10f
PE
7618 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7619
5e2d4a30
PE
7620 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7621 printf-like functions.
7622 (tiff_load): Add casts to remove these marks before passing them
7623 to system-supplied API.
7624
583f48b9
PE
7625 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7626
b25d760e
PE
7627 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7628 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7629 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7630 directly, rather than having caller test rule sign. This avoids
7631 some unnecessary tests.
7632 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7633 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7634 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7635
bc7b6697 7636 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7637 (xfont_open): Avoid unnecessary tests.
bc7b6697 7638
27ccc379
PE
7639 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7640
dcd5c89a
PE
7641 * composite.h, composite.c (composition_gstring_put_cache):
7642 Use EMACS_INT, not int, for length.
7643
b13a45c6
PE
7644 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7645 breaking out part of COMPOSITION_DECODE_RULE.
7646 (COMPOSITION_DECODE_RULE): Use it.
7647 * composite.c (get_composition_id): Remove unused local vars,
7648 by using the new macro.
7649
1e792e4d
PE
7650 * textprop.c (set_text_properties_1): Change while to do-while,
7651 since the condition is always true at first.
7652
dc6c6455 7653 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7654 (interval_deletion_adjustment): Return unsigned value.
7655 All uses changed.
dc6c6455 7656
aba7731a
PE
7657 * process.c (list_processes_1, create_pty, read_process_output):
7658 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7659 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7660 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7661 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7662 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7663
fdfc4bf3
PE
7664 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7665
fca8fe46 7666 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7667 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7668
06a0259a 7669 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7670 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7671 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7672
e7b9e80f
PE
7673 * print.c (print_error_message): Avoid int overflow.
7674
56201685
PE
7675 * font.c (font_list_entities): Redo for clarity,
7676 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7677
78834453 7678 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7679 (font_score): Avoid potential overflow in diff calculation.
78834453 7680
0bc0b309 7681 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7682 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7683
e610eaca
PE
7684 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7685
b895abce
PE
7686 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7687 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7688 can always succeed if overflow has undefined behavior.
7689
1f1d9321 7690 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7691 (wordify): Omit three unnecessary tests.
1f1d9321 7692
c59478bc
PE
7693 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7694 All callers changed. This avoids the need for an unused var.
7695
79b73827
PE
7696 * casefiddle.c (casify_region): Remove var that is set but not used.
7697
a4db5dfe
PE
7698 * dired.c (file_name_completion): Remove var that is set but not used.
7699
43aae36e
PE
7700 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7701
2a47c44d 7702 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7703 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7704
a37c69bf
PE
7705 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7706 Check for integer overflow on size calculations.
7707
328ab8e7
PE
7708 * buffer.c (Fprevious_overlay_change): Remove var that is set
7709 but not used.
7710
e5a2a5cb
PE
7711 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7712 Remove vars that are set but not used.
8d84a6eb 7713 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7714 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7715
a60e5f68
PE
7716 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7717
f661cb61 7718 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7719 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7720
f0397f5a
PE
7721 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7722 that are set but not used.
7723
8664db06 7724 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7725 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7726
6abdaa4a
PE
7727 * xselect.c (x_get_local_selection, x_handle_property_notify):
7728 Remove vars that are set but not used.
7729
0ce7538d 7730 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7731 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7732
9ae848fc
PE
7733 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7734 Remove var that is set but not used.
0b918413
PE
7735 (scroll_bar_windows_size): Now size_t, not int.
7736 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7737 Check for overflow.
9ae848fc 7738
a5a62657
PE
7739 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7740 (map_tty_color) [!defined MSDOS]: Likewise.
7741
5c5cdd39
PE
7742 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7743
66ebf983
PE
7744 * coding.c: Remove vars that are set but not used.
7745 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7746 All callers changed.
7747 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7748 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7749 (decode_coding_charset): Remove vars that are set but not used.
7750
1be4d761
PE
7751 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7752 that is set but not used.
7753
47553fa8
PE
7754 * print.c (print_object): Remove var that is set but not used.
7755
1f7196bf 7756 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7757 The gnulib version avoids calling malloc in the usual case,
7758 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7759 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7760 * filelock.c (current_lock_owner): Likewise.
7761 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7762 * sysdep.c: Include allocator.h, careadlinkat.h.
7763 (emacs_no_realloc_allocator): New static constant.
7764 (emacs_readlink): New function.
fdb61804
PE
7765 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7766 ../lib/careadlinkat.h.
d1fdcab7 7767
f84c17c7
SM
77682011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7769
7770 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7771 first non-nil return value).
7772
ef3862ad
JD
77732011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7774
7775 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7776 if not defined (Bug#8403).
7777
376a7006
JB
77782011-04-02 Juanma Barranquero <lekktu@gmail.com>
7779
7780 * xdisp.c (display_count_lines): Remove parameter `start',
7781 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7782 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7783 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7784 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7785 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7786 and thereabouts. All callers changed.
7787 (get_per_char_metric): Remove parameter `f', unused since
7788 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7789
6ca3801d
JM
77902011-04-02 Jim Meyering <meyering@redhat.com>
7791
7792 do not dereference NULL upon failed strdup
7793 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7794 (ns_get_family): Likewise.
7795
d8e2b5ba
JB
77962011-04-02 Juanma Barranquero <lekktu@gmail.com>
7797
7798 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7799
8c74fcbd
JD
78002011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7801
7802 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7803 later (Bug#8403).
7804
7200d79c
SM
78052011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7806
03408648 7807 Add lexical binding.
7200d79c 7808
03408648
SM
7809 * window.c (Ftemp_output_buffer_show): New fun.
7810 (Fsave_window_excursion):
7811 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7812
7813 * lread.c (lisp_file_lexically_bound_p): New function.
7814 (Fload): Bind Qlexical_binding.
7815 (readevalloop): Remove `evalfun' arg.
7816 Bind Qinternal_interpreter_environment.
7817 (Feval_buffer): Bind Qlexical_binding.
7818 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7819 Mark as dynamic.
7820 (syms_of_lread): Declare `lexical-binding'.
7821
7822 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7823
7824 * keyboard.c (eval_dyn): New fun.
7825 (menu_item_eval_property): Use it.
ca105506
SM
7826
7827 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7828
03408648
SM
7829 * fns.c (concat, mapcar1): Accept byte-code-functions.
7830
7831 * eval.c (Fsetq): Handle lexical vars.
7832 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7833 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7834 (FletX, Flet): Obey lexical binding.
7835 (Fcommandp): Handle closures.
7836 (Feval): New `lexical' arg.
7837 (eval_sub): New function extracted from Feval. Use it almost
7838 everywhere where Feval was used. Look up vars in lexical env.
7839 Handle closures.
7840 (Ffunctionp): Move from subr.el.
7841 (Ffuncall): Handle closures.
7842 (apply_lambda): Remove `eval_flags'.
7843 (funcall_lambda): Handle closures and new byte-code-functions.
7844 (Fspecial_variable_p): New function.
7845 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7846 but without exporting it to Lisp.
23aba0ea 7847
23aba0ea 7848 * doc.c (Fdocumentation, store_function_docstring):
03408648 7849 * data.c (Finteractive_form): Handle closures.
23aba0ea 7850
03408648
SM
7851 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7852 interactive spec.
ba83908c 7853
04f2d78b
CB
7854 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7855 New byte-codes.
03408648
SM
7856 (exec_byte_code): New function extracted from Fbyte_code to handle new
7857 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7858
03408648 7859 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7860
03408648 7861 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7862
e2abce01
JB
78632011-03-31 Juanma Barranquero <lekktu@gmail.com>
7864
7865 * xdisp.c (redisplay_internal): Fix prototype.
7866
63696a73 78672011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7868
63696a73 7869 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7870 (try_scrolling): Use it when setting scroll_limit.
7871 Limit scrolling to 100 screen lines.
63696a73
EZ
7872 (redisplay_window): Even when falling back on "recentering",
7873 position point in the window according to scroll-conservatively,
7874 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7875
7876 (try_scrolling): When point is above the window, allow searching
7877 as far as scroll_max, or one screenful, to compute vertical
7878 distance from PT to the scroll margin position. This prevents
7879 try_scrolling from unnecessarily failing when
7880 scroll-conservatively is set to a value slightly larger than the
7881 window height. Clean up the case of PT below the margin at bottom
7882 of window: scroll_max can no longer be INT_MAX. When aggressive
7883 scrolling is in use, don't let point enter the opposite scroll
7884 margin as result of the scroll.
7885 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7886 threshold of 100 lines for never-recentering scrolling.
7887
e4cc2dfc
JB
78882011-03-31 Juanma Barranquero <lekktu@gmail.com>
7889
7890 * dispextern.h (move_it_by_lines):
7891 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7892 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7893 (message_log_check_duplicate): Remove parameters `prev_bol' and
7894 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7895 (redisplay_internal): Remove parameter `preserve_echo_area',
7896 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7897
7898 * indent.c (Fvertical_motion):
7899 * window.c (window_scroll_pixel_based, Frecenter):
7900 Don't pass `need_y_p' to `move_it_by_lines'.
7901
1c470562
SM
79022011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7903
44f230aa
SM
7904 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7905 steal a few bits to be more compact.
7906 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7907 Remove unneeded casts.
7908
1c470562
SM
7909 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7910
888adce9
ZK
79112011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7912
7913 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7914 binding" message (bug#7967).
7915
f838ed7b
PE
79162011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7917
77861b95
PE
7918 Fix more problems found by GCC 4.6.0's static checks.
7919
de6dbc14
PE
7920 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7921 Remove unused local var.
7922
f838ed7b
PE
7923 * editfns.c (Fmessage_box): Remove unused local var.
7924
792c7b2b
PE
7925 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7926 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7927 Omit unused local vars.
c499e557 7928 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7929 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7930 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7931 Omit unused local var.
7932
ba0165e1
PE
7933 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7934 Don't assume string length fits in int.
32ad8845 7935 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7936 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7937
3c59b4c9
PE
7938 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7939 instead of alloca (Bug#8344).
7940
a3eed478 7941 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7942 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7943
eb4d412d
PE
7944 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7945
1658b401
PE
7946 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7947 concerns.
7948
7949 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7950
7951 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7952
9a2c6e05
PE
7953 * keyboard.c (syms_of_keyboard): Use the same style as later
7954 in this function when indexing through an array. This also
7955 works around GCC bug 48267.
7956
03d0a109
PE
7957 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7958
44f730c8
PE
7959 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7960
fe75f926
PE
7961 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7962 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7963
ffa8c828
PE
7964 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7965 This avoids undefined behavior on integer overflow, and is a bit
7966 more convenient anyway since it is compared to a size_t variable.
7967
c5101a77
PE
7968 Variadic C functions now count arguments with size_t, not int.
7969 This avoids an unnecessary limitation on 64-bit machines, which
7970 caused (substring ...) to crash on large vectors (Bug#8344).
7971 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7972 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7973 All variadic functions and their callers changed accordingly.
c5101a77
PE
7974 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7975 * data.c (arith_driver, float_arith_driver): Likewise.
7976 * editfns.c (general_insert_function): Likewise.
7977 * eval.c (struct backtrace.nargs, interactive_p)
7978 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7979 (funcall_lambda, mark_backtrace): Likewise.
7980 * fns.c (concat): Likewise.
7981 * frame.c (x_set_frame_parameters): Likewise.
7982 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7983 0 if not found, not -1. All callers changed.
7984
dd3f25f7
PE
7985 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7986 (stack_copy_size): Now size_t, not int.
7987 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7988
461c2ab9
JB
79892011-03-28 Juanma Barranquero <lekktu@gmail.com>
7990
7991 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7992 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7993 All callers changed.
7994
7995 * lisp.h (multibyte_char_to_unibyte):
7996 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7997 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7998 * character.h (CHAR_TO_BYTE8):
7999 * cmds.c (internal_self_insert):
8000 * editfns.c (general_insert_function):
8001 * keymap.c (push_key_description):
8002 * search.c (Freplace_match):
8003 * xdisp.c (message_dolog, set_message_1): All callers changed.
8004
f6d62986
SM
80052011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8006
8007 * keyboard.c (safe_run_hook_funcall): New function.
8008 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8009 don't set the hook to nil, but remove the offending function instead.
8010 (Qcommand_hook_internal): Remove, unused.
8011 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8012 Vcommand_hook_internal.
8013
8014 * eval.c (enum run_hooks_condition): Remove.
8015 (funcall_nil, funcall_not): New functions.
8016 (run_hook_with_args): Call each function through a `funcall' argument.
8017 Remove `cond' argument, now redundant.
8018 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8019 (Frun_hook_with_args_until_failure): Adjust accordingly.
8020 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8021
1db5b1ad
JB
80222011-03-28 Juanma Barranquero <lekktu@gmail.com>
8023
8024 * dispextern.h (string_buffer_position): Remove declaration.
8025
8026 * print.c (strout): Remove parameter `multibyte', unused since
8027 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8028
8029 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8030 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8031 All callers changed.
8032
8033 * w32.c (_wsa_errlist): Use braces for struct initializers.
8034
8035 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8036 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8037 All callers changed.
8038 (string_buffer_position): Likewise. Also, make static (it's never
8039 used outside xdisp.c).
8040 (cursor_row_p): Remove parameter `w', unused since
8041 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8042 (decode_mode_spec): Remove parameter `precision', introduced during
8043 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8044 All callers changed.
8045
5ffb62aa
JD
80462011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8047
8048 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8049
461c2ab9 80502011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8051
8052 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8053 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8054 (ns_update_auto_hide_menu_bar): New functions.
8055 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8056 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8057 ns_constrain_all_frames.
8058 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8059 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8060
5c380ffb
JD
80612011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8062
8063 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8064
9af30bdf
GM
80652011-03-27 Glenn Morris <rgm@gnu.org>
8066
8067 * syssignal.h: Replace RETSIGTYPE with void.
8068 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8069 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8070 Replace SIGTYPE with void everywhere.
8071 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8072 * s/template.h (SIGTYPE): Remove commented out definition.
8073
e2abce01
JB
80742011-03-26 Eli Zaretskii <eliz@gnu.org>
8075
8076 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8077 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8078
f868cd8a
JB
80792011-03-26 Juanma Barranquero <lekktu@gmail.com>
8080
59eb0929
JB
8081 * w32.c (read_unc_volume): Use parameter `henum', instead of
8082 global variable `wget_enum_handle'.
8083
8084 * keymap.c (describe_vector): Remove parameters `indices' and
8085 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8086 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8087
f868cd8a
JB
8088 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8089
8090 * keyboard.c (timer_check): Remove parameter `do_it_now',
8091 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8092 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8093 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8094
8095 * keyboard.c (read_char):
8096 * w32menu.c (w32_menu_display_help):
8097 * xmenu.c (show_help_event, menu_help_callback):
8098 Adjust calls to `show_help_echo'.
8099
8100 * gtkutil.c (xg_maybe_add_timer):
8101 * keyboard.c (readable_events):
8102 * process.c (wait_reading_process_output):
8103 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8104
8105 * insdel.c (adjust_markers_gap_motion):
8106 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8107 (gap_left, gap_right): Don't call it.
8108
2ecf6fdb
CY
81092011-03-25 Chong Yidong <cyd@stupidchicken.com>
8110
8111 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8112 incurred during fontification.
8113
6b1f9ba4
JB
81142011-03-25 Juanma Barranquero <lekktu@gmail.com>
8115
8116 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8117 (DEFVAR_PER_BUFFER): Don't pass it.
8118
8119 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8120 (scrolling_window): Don't pass it.
8121
0f4a96b5
JB
81222011-03-25 Juanma Barranquero <lekktu@gmail.com>
8123
8124 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8125
8126 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8127 and `suffix'.
8128 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8129 of variables specific to SELinux and computation of `encoded_absname'.
8130
8131 * image.c (XPutPixel): Remove unused variable `height'.
8132
8133 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8134
8135 * unexw32.c (get_section_info): Remove unused variable `section'.
8136
8137 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8138 (system_process_attributes): Remove unused variable `sess'.
8139 (sys_read): Remove unused variable `err'.
8140
8141 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8142 (w32_wnd_proc): Remove unused variable `isdead'.
8143 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8144 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8145 (x_create_tip_frame): Remove unused variable `tem'.
8146
8147 * w32inevt.c (w32_console_read_socket):
8148 Remove unused variable `no_events'.
8149
8150 * w32term.c (x_draw_composite_glyph_string_foreground):
8151 Remove unused variable `width'.
8152
1149507c
JB
81532011-03-24 Juanma Barranquero <lekktu@gmail.com>
8154
8155 * w32term.c (x_set_glyph_string_clipping):
8156 Don't pass uninitialized region to CombineRgn.
8157
9c88f339
JB
81582011-03-23 Juanma Barranquero <lekktu@gmail.com>
8159
8160 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8161 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8162 (Fx_close_connection): Remove unused variable `i'.
8163
8164 * w32font.c (w32font_draw): Return number of glyphs.
8165 (w32font_open_internal): Remove unused variable `i'.
8166 (w32font_driver): Add missing initializer.
8167
8168 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8169 (fill_in_menu): Remove unused variable `items_added'.
8170
8171 * w32term.c (last_mouse_press_frame): Remove static global variable.
8172 (w32_clip_to_row): Remove unused variable `f'.
8173 (x_delete_terminal): Remove unused variable `i'.
8174
8175 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8176 (NOTHING): Remove unused static global variable.
8177 (uniscribe_check_otf): Remove unused variable `table'.
8178 (uniscribe_font_driver): Add missing initializers.
8179
dee091a3
JD
81802011-03-23 Julien Danjou <julien@danjou.info>
8181
8182 * term.c (Fsuspend_tty, Fresume_tty):
8183 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8184 * window.c (temp_output_buffer_show):
8185 * insdel.c (signal_before_change):
8186 * frame.c (Fhandle_switch_frame):
8187 * fileio.c (Fdo_auto_save):
8188 * emacs.c (Fkill_emacs):
8189 * editfns.c (save_excursion_restore):
8190 * cmds.c (internal_self_insert):
8191 * callint.c (Fcall_interactively):
8192 * buffer.c (Fkill_all_local_variables):
8193 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8194 Use Frun_hooks.
0f4a96b5 8195 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8196 unconditionally since it does the check itself.
dee091a3 8197
2c520ab5 81982011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8199
c9c49752
PE
8200 Fix more problems found by GCC 4.5.2's static checks.
8201
8abc3f12
PE
8202 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8203 the first time through the loop, since we know p0 < p1 then.
8204 This also avoids a gcc -Wstrict-overflow warning.
8205
a2d26660
PE
8206 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8207 leading to a memory leak, possible in functions like
8208 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8209 of objects (Bug#8318).
a2d26660 8210
916c72e9
PE
8211 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8212 that could (at least in theory) be that large.
8213
19ab8a18
PE
8214 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8215 This is less likely to overflow, and avoids undefined behavior if
8216 overflow does occur. All callers changed. Use strtoul to scan
8217 for the unsigned long integer.
b7cbbd6f
PE
8218 (pint2hrstr): Simplify and tune code slightly.
8219 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8220
f0641eff
PE
8221 * scroll.c (do_scrolling): Work around GCC bug 48228.
8222 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8223
7f650bb9
PE
8224 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8225 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8226 (validate_x_resource_name): Simplify count usage.
8227 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8228
37dd57d1
PE
8229 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8230 fail (Bug#8306).
81e56e61 8231
699979fc 8232 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8233
401bf9b4
PE
8234 * process.c (Fmake_network_process): Use socklen_t, not int,
8235 where POSIX says socklen_t is required in portable programs.
8236 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8237 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8238 (Fmake_network_process, server_accept_connection):
8239 (wait_reading_process_output, read_process_output):
8240 Likewise.
8241
b93aacde
PE
8242 * process.c: Rename or move locals to avoid shadowing.
8243 (list_processes_1, Fmake_network_process):
8244 (read_process_output_error_handler, exec_sentinel_error_handler):
8245 Rename or move locals.
4dc343ee 8246 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8247 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8248 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8249 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8250 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8251
af8a867c 8252 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8253 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8254 Include tparam.h instead, since it declares them.
af8a867c
PE
8255 * cm.h (PC): Remove extern decl; tparam.h now does this.
8256 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8257 * terminfo.c: Include tparam.h, to check interfaces.
8258 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8259 (tparam): Adjust signature to match interface in tparam.h;
8260 this removes some undefined behavior. Check that outstring and len
8261 are zero, which they always are with Emacs.
8262 * tparam.h (PC, BC, UP): New extern decls.
8263
0248044d 8264 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8265 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8266
8ff096c1 8267 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8268 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8269 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8270 (ftfont_list): Remove unused local.
49eaafba
PE
8271 (get_adstyle_property, ftfont_pattern_entity):
8272 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8273 Rename locals to avoid shadowing.
8ff096c1 8274
e2be39f6
PE
8275 * xfont.c (xfont_list_family): Mark var as initialized.
8276
c9735e30
PE
8277 * xml.c (make_dom): Now static.
8278
8f5201ae
PE
8279 * composite.c (composition_compute_stop_pos): Rename local to
8280 avoid shadowing.
b246f932
PE
8281 (composition_reseat_it): Remove unused locals.
8282 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8283 (composition_update_it): Mark var as initialized.
11b61122
PE
8284 (find_automatic_composition): Mark vars as initialized,
8285 with a FIXME (Bug#8290).
8f5201ae 8286
760fbc2c
PE
8287 character.h: Rename locals to avoid shadowing.
8288 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8289 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8290 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8291 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8292 to avoid shadowing.
8293
ff08eb85
PE
8294 * textprop.c (property_change_between_p): Remove; unused.
8295
fc7bf025
PE
8296 * intervals.c (interval_start_pos): Now static.
8297
235d7abc
PE
8298 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8299
44f230aa
SM
8300 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8301 Rename locals to avoid shadowing.
3e7d6594 8302
50060332
PE
8303 * sound.c (wav_play, au_play, Fplay_sound_internal):
8304 Fix pointer signedness.
d01f234b 8305 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8306 (wav_play): Initialize a variable to 0, to prevent undefined
8307 behavior (Bug#8278).
50060332 8308
c4fc4e30
PE
8309 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8310
918436ed
PE
8311 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8312
c939f91b
PE
8313 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8314 clobbering (Bug#8298).
b9c7f648
PE
8315 * sysdep.c (sys_subshell): Likewise.
8316 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8317
6bd8c144
PE
8318 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8319 This should get cleaned up, so that child_setup has the
8320 same signature on all platforms.
8321
7710357c 8322 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8323 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8324
c59da222
CY
83252011-03-22 Chong Yidong <cyd@stupidchicken.com>
8326
8327 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8328 not to be necessary, and produces flickering.
8329
66b87493
GM
83302011-03-20 Glenn Morris <rgm@gnu.org>
8331
8332 * config.in: Remove file.
8333
45b6f6d5
JB
83342011-03-20 Juanma Barranquero <lekktu@gmail.com>
8335
8336 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8337 are now in src/globals.h.
8338 (syms_of_minibuf): Remove spurious & from previous change.
8339
cd394be1 83402011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8341
8342 * minibuf.c (completing-read-function): New variable.
8343 (completing-read-default): Rename from completing-read.
8344 (completing-read): Call completing-read-function.
8345
b14e3e21
CY
83462011-03-19 Juanma Barranquero <lekktu@gmail.com>
8347
8348 * xfaces.c (Fx_load_color_file):
8349 Read color file from absolute filename (bug#8250).
8350
f2b726e6
JB
83512011-03-19 Juanma Barranquero <lekktu@gmail.com>
8352
8353 * makefile.w32-in: Update dependencies.
8354
09f6ff02
EZ
83552011-03-17 Eli Zaretskii <eliz@gnu.org>
8356
8357 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8358
29a6015a
PE
83592011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8360
a3a6c54e
PE
8361 Fix more problems found by GCC 4.5.2's static checks.
8362
b766f867
PE
8363 * process.c (make_serial_process_unwind, send_process_trap):
8364 (sigchld_handler): Now static.
8365
be02381c
PE
8366 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8367 That way, the code declares only the vars that it needs.
8368 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8369 * s/cygwin.h (PTY_ITERATION): Likewise.
8370 * s/darwin.h (PTY_ITERATION): Likewise.
8371 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8372
57048744
PE
8373 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8374 * process.c (allocate_pty): Don't declare stb unless it's needed.
8375
7914961c 8376 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8377 (CONSTANTLIM): Remove; unused.
8378 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8379 Define only if needed.
7914961c 8380
b3967b18
PE
8381 * unexelf.c (unexec): Name an expression,
8382 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8383 Use a different way to cause a compilation error if anyone uses
8384 n rather than nn, a way that does not involve shadowing.
73366a00 8385 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8386
29a6015a
PE
8387 * deps.mk (unexalpha.o): Remove; unused.
8388
43cfc33e 8389 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8390 * unexec.h: New file.
ce701a33
PE
8391 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8392 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8393 Depend on unexec.h.
8394 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8395 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8396 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8397 Change as necessary to match prototype in unexec.h.
ce701a33 8398
01f44d5a
PE
8399 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8400 shadowing.
4f63c6bb 8401 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8402
a6670b0b
PE
8403 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8404 Rename locals to avoid shadowing.
8405
cef2010d 8406 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8407 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8408
d4d7173a
PE
8409 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8410
f08b802a
PE
8411 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8412 warning when compiling print.c.
8413
3ddb0639
PE
8414 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8415 instead of using an uninitialized var.
5ad03b97 8416 (font_sort_entities): Mark var as initialized.
3ddb0639 8417
170a2692
PE
8418 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8419
e663c700
PE
8420 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8421 pointers to constants.
89bc529a 8422 (font_parse_fcname): Remove unused vars.
7b81e2d0 8423 (font_delete_unmatched): Now static.
ea838e10 8424 (font_get_spec): Remove; unused.
13a547c6
PE
8425 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8426 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8427 Rename or move locals to avoid shadowing.
e663c700 8428
2a80c887 8429 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8430 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8431
1384fa33 8432 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8433 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8434
8b2c52e9
PE
8435 * alloc.c (mark_backtrace): Move decl from here ...
8436 * lisp.h: ... to here, so that it can be checked.
8437
475545b5 8438 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8439 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8440 (lisp_indirect_variable): Name an expression,
8441 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8442 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8443
b1349114 8444 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8445 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8446 Use const pointer when appropriate.
b1349114 8447
a2928364
PE
8448 * lisp.h (get_system_name, get_operating_system_release):
8449 Move decls here, to check interfaces.
8450 * process.c (get_operating_system_release): Move decl to lisp.h.
8451 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8452 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8453 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8454 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8455 (Fformat_time_string, Fencode_time, Finsert_char):
8456 (Ftranslate_region_internal, Fformat):
8457 Rename or remove local vars to avoid shadowing.
9710023e 8458 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8459
a415e694
PE
8460 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8461 avoid shadowing.
8462
8ef4622d
PE
8463 * lisp.h (eassert): Check that the argument compiles, even if
8464 ENABLE_CHECKING is not defined.
8465
946f9a5b
PE
8466 * data.c (Findirect_variable): Name an expression, to avoid
8467 gcc -Wbad-function-cast warning.
112396d6 8468 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8469 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8470 (Fmake_variable_buffer_local, Fmake_local_variable):
8471 Mark variables as initialized.
52746918 8472 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8473
e5aab7e7 8474 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8475 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8476 Rename locals to avoid shadowing.
dff45157
PE
8477 (mark_stack): Move local variables into the #ifdef region where
8478 they're used.
7bc26fdb
PE
8479 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8480 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8481 needed otherwise.
8482 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8483 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8484 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8485
e5aab7e7
PE
8486 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8487 avoids undefined behavior in theory.
8488
4da60324
PE
8489 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8490
88043301
PE
8491 Use functions, not macros, for up- and down-casing (Bug#8254).
8492 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8493 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8494 to use the following functions instead of these macros.
8495 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8496 EMACS_INT, since callers assume the returned value fits in int.
8497 (upcase1): Likewise, for UPCASE_TABLE.
8498 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8499 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8500 the race-condition problem in the old DOWNCASE.
88043301 8501
19ed5445
PE
8502 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8503 Rename locals to avoid shadowing.
8504 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8505 (regex_compile, re_search_2, re_match_2_internal):
8506 Remove unused local vars.
952db0d7
PE
8507 (FREE_VAR): Rewrite so as not to use empty "else",
8508 which gcc can warn about.
da053e48 8509 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8510 (RETALLOC_IF): Define only if needed.
8511 (WORDCHAR_P): Likewise. This one is never needed, but is used
8512 only in a comment talking about a compiler bug, so put inside
8513 the #if 0 of that comment.
8514 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8515 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8516 Remove; unused.
19ed5445 8517
1f3561e4 8518 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8519 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8520 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8521
ded6f8f7
PE
8522 * search.c (simple_search): Remove unused var.
8523
dbd37a95
PE
8524 * dired.c (compile_pattern): Move decl from here ...
8525 * lisp.h: ... to here, so that it can be checked.
8526 (struct re_registers): New forward decl.
8527
7e47afad
PE
8528 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8529
85f24f61
PE
8530 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8531 All uses changed.
8532 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8533 Rename locals to avoid shadowing.
5671df8f 8534 (Fvertical_motion): Mark locals as initialized.
85f24f61 8535
181aa2be 8536 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8537 (casify_region): Mark local as initialized.
181aa2be 8538
930d429c
PE
8539 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8540
7082eac6
PE
8541 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8542 New macros, so that the caller can use some names other than
8543 gcpro1, gcpro2, etc.
8544 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8545 of the new macros.
8546 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8547 argument, for consistency with GCPRO2_VAR, etc: it is now the
8548 prefix of the variable, not the variable itself. All uses
8549 changed.
38b2c076
PE
8550 * dired.c (directory_files_internal, file_name_completion):
8551 Rename locals to avoid shadowing.
8552
15206ed9
PE
8553 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8554 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8555 dired.c's scmp function, had undefined behavior.
8556 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8557 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8558 * buffer.h: ... to here, because these macros use current_buffer,
8559 and the new implementation with inline functions needs to have
8560 current_buffer in scope now, rather than later when the macros
8561 are used.
8562 (downcase, upcase1): New static inline functions.
8563 (DOWNCASE, UPCASE1): Reimplement using these functions.
8564 This avoids undefined behavior in expressions like
8565 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8566 from race conditions in accessing the global variables
8567 case_temp1 and case_temp2.
8568 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8569 * lisp.h (case_temp1, case_temp2): Remove their decls.
8570 * character.h (ASCII_CHAR_P): Move from here ...
8571 * lisp.h: ... to here, so that the inline functions mentioned
8572 above can use them.
8573
4a6bea26
PE
8574 * dired.c (directory_files_internal_unwind): Now static.
8575
f14b7e14
PE
8576 * fileio.c (file_name_as_directory, directory_file_name):
8577 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8578 Now static.
2893f146
PE
8579 (file_name_as_directory): Use const pointers when appropriate.
8580 (Fexpand_file_name): Likewise. In particular, newdir might
8581 point at constant storage, so make it a const pointer.
fd4ead52 8582 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8583 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8584 signedness issues.
f839df0c
PE
8585 (Fset_file_times, Finsert_file_contents, auto_save_error):
8586 Rename locals to avoid shadowing.
f14b7e14 8587
5716756e 8588 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8589 (Ftry_completion, Fall_completions): Rename or remove locals
8590 to avoid shadowing.
5716756e 8591
b4c3046a
PE
8592 * marker.c (bytepos_to_charpos): Remove; unused.
8593
b45db522
PE
8594 * lisp.h (verify_bytepos, count_markers): New decls,
8595 so that gcc does not warn that these functions aren't declared.
8596
85876d07
PE
8597 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8598 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8599 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8600 (copy_text): Remove unused local var.
85876d07 8601
03d78a21 8602 * filelock.c (within_one_second): Now static.
b3dd38ab 8603 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8604
5df8f01b
PE
8605 * buffer.c (fix_overlays_before): Mark locals as initialized.
8606 (fix_start_end_in_overlays): Likewise. This function should be
8607 simplified by using pointers-to-pointers, but that's a different
8608 matter.
b1d876f1 8609 (switch_to_buffer_1): Now static.
8f54f30a
PE
8610 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8611 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8612
a70072c9 8613 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8614 Fix pointer signedness issue.
edced198
PE
8615 (sys_subshell): Mark local as volatile if checking for lint,
8616 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8617 (MAXPATHLEN): Define only if needed.
a70072c9 8618
a0977c44
PE
8619 * process.c (serial_open, serial_configure): Move decls from here ...
8620 * systty.h: ... to here, so that they can be checked.
8621
a884fdcc
PE
8622 * fns.c (get_random, seed_random): Move extern decls from here ...
8623 * lisp.h: ... to here, so that they can be checked.
8624
604efe86 8625 * sysdep.c (reset_io): Now static.
b8950c94 8626 (wait_for_termination_signal): Remove; unused.
604efe86 8627
38fc62d9
PE
8628 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8629 (copy_keymap_item, append_key, push_text_char_description):
8630 Now static.
1004a21a 8631 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8632 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8633 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8634 (describe_map_tree):
8635 Rename locals to avoid shadowing.
38fc62d9 8636
2f2650da
PE
8637 * keyboard.c: Declare functions static if they are not used elsewhere.
8638 (echo_char, echo_dash, cmd_error, top_level_2):
8639 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8640 (read_char, kbd_buffer_get_event, make_lispy_position):
8641 (make_lispy_event, make_lispy_movement, apply_modifiers):
8642 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8643 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8644 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8645 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8646 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8647
a053e86c 8648 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8649 (mark_kboards): Move decl here ...
8650 * alloc.c (mark_kboards): ... from here.
a053e86c 8651
4752793e
PE
8652 * lisp.h (force_auto_save_soon): New decl.
8653
74f10ca7 8654 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8655 (DEFINE_DUMMY_FUNCTION): New macro.
8656 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8657 Use it.
c03cd23f
PE
8658 (main): Add casts to avoid warnings
8659 if GCC considers string literals to be constants.
74f10ca7 8660
022e70d4
PE
8661 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8662
59d6fe83
PE
8663 * dbusbind.c: Pointer signedness fixes.
8664 (xd_signature, xd_append_arg, xd_initialize):
8665 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8666 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8667 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8668 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8669
78320123
PE
8670 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8671 if GCC considers string literals to be constants.
49cebcca 8672 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8673
35ac2a97
SM
86742011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8675
fb103ca9
SM
8676 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8677 (print_preprocess, print_object): New macro to fix last change.
8678
35ac2a97
SM
8679 * print.c (print_preprocess): Don't forget font objects.
8680
62973b41
JB
86812011-03-16 Juanma Barranquero <lekktu@gmail.com>
8682
8683 * emacs.c (USAGE3): Doc fixes.
8684
0e48bb22
AS
86852011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8686
8687 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8688 structure.
8689
7684e57b
JB
86902011-03-14 Juanma Barranquero <lekktu@gmail.com>
8691
8692 * lisp.h (VWindow_system, Qfile_name_history):
8693 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8694 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8695 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8696
8697 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8698 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8699
8700 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8701 * w32console.c (detect_input_pending, read_input_pending)
8702 (encode_terminal_code):
8703 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8704 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8705 (w32_system_caret_y, Qfile_name_history):
8706 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8707 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8708 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8709 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8710 * w32proc.c (Qlocal, report_file_error):
8711 * w32term.c (Vwindow_system, updating_frame):
8712 * w32uniscribe.c (initialized, uniscribe_font_driver):
8713 Remove unneeded extern declarations.
8714
2aa46d6c
CY
87152011-03-14 Chong Yidong <cyd@stupidchicken.com>
8716
c96bbc66 8717 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8718
cffc6f3b
CY
87192011-03-13 Chong Yidong <cyd@stupidchicken.com>
8720
8721 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8722 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8723 These macros can no longer be used for assignment.
8724
44f230aa
SM
8725 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8726 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8727 (record_buffer_markers, fetch_buffer_markers): New functions for
8728 recording and fetching special buffer markers.
8729 (set_buffer_internal_1, set_buffer_temp): Use them.
8730
8731 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8732
8733 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8734
8735 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8736 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8737
8738 * xdisp.c (hscroll_window_tree):
8739 (reconsider_clip_changes): Use PT instead of BUF_PT.
8740
d251f04b
EZ
87412011-03-13 Eli Zaretskii <eliz@gnu.org>
8742
8743 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8744 $(EMACS_ROOT)/lib/intprops.h.
8745
f0c77cd1
PE
87462011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8747
3eca4629
PE
8748 Fix more problems found by GCC 4.5.2's static checks.
8749
7c86ee98
PE
8750 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8751 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8752 (xg_free_frame_widgets): Make it clear that a local variable is
8753 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8754 (gdk_window_get_screen): Make it clear that this macro is needed
8755 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8756 (int_gtk_range_get_value): New function, which avoids a diagnostic
8757 from gcc -Wbad-function-cast.
8758 (xg_set_toolkit_scroll_bar_thumb): Use it.
8759 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8760 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8761 (get_utf8_string, xg_get_file_with_chooser):
8762 Rename locals to avoid shadowing.
8763 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8764
41729b81
PE
8765 * xgselect.c (xg_select): Remove unused var.
8766
f0c77cd1
PE
8767 * image.c (four_corners_best): Mark locals as initialized.
8768 (gif_load): Initialize transparent_p to zero (Bug#8238).
8769 Mark another local as initialized.
ec6cf4c6 8770 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8771
ce0ad53d 8772 * image.c (clear_image_cache): Now static.
d5d5a617 8773 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8774 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8775 (x_edge_detection): Remove unnecessary cast that
8776 gcc -Wbad-function-cast diagnoses.
2037898d 8777 (gif_load): Fix pointer signedness.
6ae141d6
PE
8778 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8779 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8780
33383987 87812011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8782
d32df629
PE
8783 Improve quality of tests for time stamp overflow.
8784 For example, without this patch (encode-time 0 0 0 1 1
8785 1152921504606846976) returns the obviously-bogus value (-948597
8786 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8787 reports time overflow. See
8788 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8789 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8790 * editfns.c: Include limits.h and intprops.h.
8791 (TIME_T_MIN, TIME_T_MAX): New macros.
8792 (time_overflow): Move earlier, to before first use.
8793 (hi_time, lo_time): New functions, for an accurate test for
8794 out-of-range times.
8795 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8796 (Fget_internal_run_time): Don't assume time_t fits in int.
8797 (make_time): Use list2 instead of Fcons twice.
8798 (Fdecode_time): More accurate test for out-of-range times.
8799 (check_tm_member): New function.
8800 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8801 (lisp_time_argument): Don't rely on undefined left-shift and
8802 right-shift behavior when checking for time stamp overflow.
8be6f318 8803
fe31d94c
PE
8804 * editfns.c (time_overflow): New function, refactoring common code.
8805 (Fformat_time_string, Fdecode_time, Fencode_time):
8806 (Fcurrent_time_string): Use it.
8807
8be6f318
PE
8808 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8809 * dired.c (make_time): Move to ...
8810 * editfns.c (make_time): ... here.
8811 * systime.h: Note the move.
8812
09d9db2c 88132011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8814
126bc0dc
YM
8815 * fringe.c (update_window_fringes): Remove unused variables.
8816
c47cbdfd
YM
8817 * unexmacosx.c (copy_data_segment): Also copy __got section.
8818 (Bug#8223)
8819
7ac80be9
EZ
88202011-03-12 Eli Zaretskii <eliz@gnu.org>
8821
c96bbc66 8822 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8823 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8824 Constify `char *' arguments and their references according to
8825 prototypes in tparam.h.
8826
ecb0f94d 8827 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8828
7ac80be9
EZ
8829 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8830 Adapt all references accordingly.
8831
8832 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8833
ef1fd07e
TT
88342011-03-11 Tom Tromey <tromey@redhat.com>
8835
8836 * buffer.c (syms_of_buffer): Remove obsolete comment.
8837
7ef4b50c
EZ
88382011-03-11 Eli Zaretskii <eliz@gnu.org>
8839
8840 * termhooks.h (encode_terminal_code): Declare prototype.
8841
8842 * msdos.c (encode_terminal_code): Don't declare prototype.
8843
8844 * term.c (encode_terminal_code): Now external again, used by
8845 w32console.c and msdos.c.
8846
44f230aa
SM
8847 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8848 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8849
4b1ec863 88502011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8851
1714f52b 8852 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8853
4b1ec863
PE
8854 * fringe.c (update_window_fringes): Mark locals as initialized
8855 (Bug#8227).
8856 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8857
524c7aa6
PE
8858 * alloc.c (mark_fringe_data): Move decl from here ...
8859 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8860 to check its interface.
8861 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8862
a5c0af81 8863 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8864 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8865 (fontset_font): Mark local as initialized.
a9a06e0b 8866 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8867
b4716021
PE
8868 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8869
811e9bac 8870 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8871 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8872 (x_own_selection, Fx_disown_selection_internal): Rename locals
8873 to avoid shadowing.
8874 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8875
7e3ab302
PE
8876 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8877 so that the caller can use some name other than gcpro1.
8878 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8879 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8880 (Fx_backspace_delete_keys_p):
8881 Use them to avoid shadowing, and rename vars to avoid shadowing.
8882 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8883 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8884 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8885 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8886 Remove unused locals.
7e3ab302
PE
8887 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8888 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8889 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8890 macros.
f78faa98 8891
e2b13473
PE
8892 * xterm.h (x_mouse_leave): New decl.
8893
77f23912
PE
8894 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8895 Remove unused functions.
cdf4ba58
PE
8896 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8897 (x_calc_absolute_position): Now static.
7411c686 8898 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8899 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8900 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8901 unless they are used.
38d0b34a
PE
8902 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8903 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8904 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8905 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8906 (x_error_catcher, x_connection_closed, x_error_handler):
8907 (x_error_quitter, xembed_send_message, x_iconify_frame):
8908 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8909 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8910 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8911
44f230aa
SM
8912 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8913 Rename or move locals to avoid shadowing.
6b463e58 8914 (tty_defined_color, merge_face_heights): Now static.
5967d051 8915 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8916 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8917 does not deduce is never used uninitialized.
73719eba
PE
8918 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8919 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8920
426994c3 8921 * terminal.c (store_terminal_param): Now static.
5489860b 8922
032f1620 8923 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8924 (set_frame_menubar): Remove unused local.
d4323972 8925 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8926 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8927 since they might point to immutable storage.
281585b0
PE
8928 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8929 since it's unused otherwise.
032f1620 8930
367c19e5 8931 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8932 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8933 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8934 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8935 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8936 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8937 does not deduce are never used uninitialized.
70739cbe 8938
07b48fa9
PE
8939 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8940
8868a238 8941 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8942 * window.c (window_loop, size_window):
8943 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8944
7e5cf297 8945 * window.c (display_buffer): Now static.
d6550a9f
PE
8946 (size_window): Mark variables that gcc -Wuninitialized
8947 does not deduce are never used uninitialized.
a586633d
PE
8948 * window.h (check_all_windows): New decl, to forestall
8949 gcc -Wmissing-prototypes diagnostic.
5b555da1 8950 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8951
f6095868
PE
8952 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8953 shadowing.
8954 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8955 Include <limits.h>.
8956 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8957 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8958 (load_charset_map): Mark variables that gcc -Wuninitialized
8959 does not deduce are never used uninitialized.
53df7c11 8960 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8961
f38b440c
PE
8962 * coding.c (coding_set_source, coding_set_destination):
8963 Use "else { /* comment */ }" rather than "else /* comment */;"
8964 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8965 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8966 a block, when the outer 'i' will do.
8967 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8968 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8969 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8970 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8971 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8972 Rename locals to avoid shadowing.
8973 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8974 * coding.c (emacs_mule_char, encode_invocation_designation):
8975 Now static, since they're not used elsewhere.
413bb2db 8976 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8977 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8978 (decode_coding_emacs_mule): Mark variables that gcc
8979 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8980 (detect_coding_iso_2022): Initialize a local variable that might
8981 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8982 this initialization is needed. (Bug#8211)
5f58e762
PE
8983 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8984 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8985 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8986 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8987 Remove unused macros.
f38b440c 8988
232b38b9 8989 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8990 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8991 * character.c (string_count_byte8): Likewise.
232b38b9 8992
fb90da1b
PE
8993 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8994 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8995
fb93dbc2
PE
8996 * chartab.c (copy_sub_char_table): Now static, since it's not used
8997 elsewhere.
5c156ace
PE
8998 (sub_char_table_ref_and_range, char_table_ref_and_range):
8999 Rename locals to avoid shadowing.
bbcd0949 9000 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9001
7d3b3862 9002 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9003 (BIDI_BOB): Remove unused macro.
7d3b3862 9004
6be7d3da
PE
9005 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9006 deduce are never used uninitialized.
c2ed9c8b 9007 * term.c (encode_terminal_code): Likewise.
6be7d3da 9008
75f8807f 9009 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9010
50938595
PE
9011 * tparam.h: New file.
9012 * term.c, tparam.h: Include it.
9013 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9014 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9015 Move these decls to tparam.h, and make them agree with what
9016 is actually in tparam.c. The previous trick of using incompatible
9017 decls in different modules does not conform to the C standard.
9018 All callers of tparam changed to use tparam's actual API.
9019 * tparam.c (tparam1, tparam, tgoto):
9020 Use const pointers where appropriate.
9021
fbceeba2
PE
9022 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9023 * cm.h (struct cm): Likewise.
9024 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9025 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9026 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9027 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9028 (turn_on_face, init_tty): Likewise.
9029 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9030
7f3f1250
PE
9031 * term.c (term_mouse_position): Rename local to avoid shadowing.
9032
e6ca6543
PE
9033 * alloc.c (mark_ttys): Move decl from here ...
9034 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9035
c40f8d15
AS
90362011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9037
9038 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9039
cfe0661d
JB
90402011-03-09 Juanma Barranquero <lekktu@gmail.com>
9041
9042 * search.c (compile_pattern_1): Remove argument regp, unused since
9043 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9044 (compile_pattern): Don't pass it.
9045
0afb4571
J
90462011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9047
9048 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9049 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9050 for ! HAVE_GTK3.
9051 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9052
9053 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9054
9055 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9056 gdk_window_get_screen, gdk_window_get_geometry,
9057 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9058 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9059 (xg_get_pixbuf_from_pixmap): New function.
9060 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9061 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9062 Call xg_get_pixbuf_from_pixmap instead of
9063 gdk_pixbuf_get_from_drawable.
9064 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9065 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9066 (xg_check_special_colors): Use GtkStyleContext and its functions
9067 for HAVE_GTK3.
9068 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9069 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9070 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9071 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9072 Call gtk_widget_get_preferred_size.
0afb4571
J
9073 (xg_frame_resized): gdk_window_get_geometry only takes 5
9074 parameters.
44f230aa
SM
9075 (xg_win_to_widget, xg_event_is_for_menubar):
9076 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9077 (xg_set_widget_bg): New function.
9078 (delete_cb): New function.
895009e1 9079 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9080 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9081 (xg_set_background_color): Call xg_set_widget_bg.
9082 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9083 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9084 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9085 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9086 if ! HAVE_GTK3.
9087 (update_frame_tool_bar): Call gtk_widget_hide.
9088 (xg_initialize): Use GDK_KEY_g.
9089
9090 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9091 if ! HAVE_GTK3
9092 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9093
9094 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9095 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9096 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9097
1c2cc4ef
JB
90982011-03-08 Juanma Barranquero <lekktu@gmail.com>
9099
9100 * w32xfns.c (select_palette): Check success of RealizePalette against
9101 GDI_ERROR, not zero.
9102
33383987 9103See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9104
9105;; Local Variables:
9106;; coding: utf-8
aac0c6e3
MR
9107;; End:
9108
acaf905b 9109 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9110
9111 This file is part of GNU Emacs.
9112
9113 GNU Emacs is free software: you can redistribute it and/or modify
9114 it under the terms of the GNU General Public License as published by
9115 the Free Software Foundation, either version 3 of the License, or
9116 (at your option) any later version.
9117
9118 GNU Emacs is distributed in the hope that it will be useful,
9119 but WITHOUT ANY WARRANTY; without even the implied warranty of
9120 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9121 GNU General Public License for more details.
9122
9123 You should have received a copy of the GNU General Public License
9124 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.