* gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
41a62dd9
DA
12012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
4
5884c324
PE
52012-08-14 Paul Eggert <eggert@cs.ucla.edu>
6
7 * gtkutil.c (xg_mark_data): Don't assume C99.
8
ca06f160
JD
92012-08-13 Jan Djärv <jan.h.d@swipnet.se>
10
11 * gtkutil.c (xg_frame_tb_info): New struct.
12 (TB_INFO_KEY): New define.
13 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
14 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
15 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
16 if not present.
17 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
18 is up to date. Otherwise store new data.
19 (free_frame_tool_bar): Free xg_frame_tb_info if present.
20
7864a3f7
DA
212012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
22
23 Use KSET for write access to Lisp_Object members of struct kboard.
24 * keyboard.h (KSET): New macro.
25 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
26 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
27 * xterm.c: Adjust users.
28
4c31be61
DA
292012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
30
31 Use BSET for write access to Lisp_Object members of struct buffer.
32 * buffer.h (BSET): New macro.
33 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
34 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
35 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
36 * window.c, xdisp.c, xfns.c: Adjust users.
37
14ae4239
BT
382012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
39
40 * lread.c (syms_of_lread): Initialize Vlexical_binding.
41
32bcadb4
JD
422012-08-11 Jan Djärv <jan.h.d@swipnet.se>
43
3d29b2ce
JD
44 * nsterm.m (not_in_argv): New function.
45 (application:openFile, application:openTempFile:):
46 (application:openFileWithoutUI:, application:openFiles:): Open file
47 if not_in_argv returns non-zero (bug#12171).
48
32bcadb4 49 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
50 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
51 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
52 (xg_get_font_name): Use those functions/macros here.
53 Reported by Frans Oilinki <moilinki@gmail.com>.
54
9ff9402d 552012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
56
57 * unexmacosx.c (copy_data_segment): Copy initialized data in
58 statically linked libraries from input file rather than memory.
59
db74a5fc
YM
60 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
61 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
62 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
63
25e65510
GM
642012-08-10 Glenn Morris <rgm@gnu.org>
65
66 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
67 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
68
7961135c
DA
692012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
70
71 Fix last change to allow compilation with low optimization levels.
72 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
73 Reported by Jan Djärv <jan.h.d@swipnet.se>.
74
42b3a444
DA
752012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
76
77 Use common inline syntax in intervals.h.
78 * intervals.h (INTERVALS_INLINE): New macro.
79 Change all users from LISP_INLINE.
80
9fb0c957
DA
812012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
82
83 Define Qnone once for all platforms.
84 * frame.c (Qnone): Define here.
85 (syms_of_frame): DEFSYM it.
86 * lisp.h (Qnone): New declaration.
87 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
88 * xfns.c: Remove duplication. Adjust users.
89
65e8ee52
DA
902012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
91
92 Remove unused macros from intervals.h.
93 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
94 * intervals.c: Adjust comment.
95
9b855fd6
EZ
962012-08-10 Eli Zaretskii <eliz@gnu.org>
97
98 * w32fns.c <w32_unicode_gui>: New static variable.
99 (globals_of_w32fns): Initialize it according to os_subtype.
100 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
101 testing os_subtype.
102
39cb9e56 1032012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
104 Eli Zaretskii <eliz@gnu.org>
105
106 Fix bug #10299 with Unicode characters sent by customized
107 keyboards created by MSKLC.
108 * w32fns.c (INIT_WINDOW_CLASS): New macro.
109 (w32_init_class): Use it to initialize the Emacs class with either
110 ANSI or Unicode API calls.
111 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
112 later.
113 (w32_wnd_proc): If the character code sent by WM_CHAR or
114 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
115 original message. Call DefWindowProcW on NT and later.
116
9374581a
GM
1172012-08-10 Glenn Morris <rgm@gnu.org>
118
4b94e8cf
GM
119 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
120
9374581a
GM
121 * lisp.h (DIRECTORY_SEP): Let configure set it.
122
a2752828
DA
1232012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
124
125 Use TSET for write access to Lisp_Object slots of struct terminal.
126 * termhooks.h (TSET): New macro.
127 * coding.c, terminal.c, xselect.c: Adjust users.
128
cc92c454
SM
1292012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
130
131 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
132 the failing expression, include them in the error message.
133 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
134 * lisp.h (internal_condition_case_n): Update declaration.
135
4cb3e6b3
DA
1362012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
137
138 Inline functions to examine and change buffer overlays.
139 * buffer.c (unchain_both): New function.
140 * buffer.h (buffer_get_overlays, buffer_set_overlays):
141 (buffer_has_overlays): New function.
142 (enum overlay_type): New enum.
143 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
144 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
145
8707c1e5
DA
1462012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
147
148 Inline functions to examine and change buffer intervals.
149 * alloc.c (mark_interval_tree): Remove.
150 (MARK_INTERVAL_TREE): Simplify.
151 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
152 * intervals.c (buffer_balance_intervals): New function.
153 (graft_intervals_into_buffer): Adjust indentation.
154 (set_intervals_multibyte): Simplify.
155 * buffer.h (BUF_INTERVALS): Remove.
156 (buffer_get_intervals, buffer_set_intervals): New function.
157 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
158 * intervals.c, textprop.c: Adjust users.
159
ad8c997f
DA
1602012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
161
162 Inline functions to examine and change string intervals.
163 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
164 (string_get_intervals, string_set_intervals): New function.
165 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
166 * lread.c, print.c, textprop.c: Adjust users.
167
32ac3a6b
GM
1682012-08-08 Glenn Morris <rgm@gnu.org>
169
170 * lisp.mk (lisp): Remove language/persian.elc.
171
77c7bcb1
DA
1722012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
173
174 Cleanup intervals.
175 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
176 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
177 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
178 Adjust comment. Move under #if 0.
77c7bcb1
DA
179 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
180 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
181
9c08a8d4
DA
1822012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
183
184 Check total length of intervals with eassert.
185 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
186 * intervals.c: Change all users to eassert.
187
26d16b35
EZ
1882012-08-07 Eli Zaretskii <eliz@gnu.org>
189
14ae4239
BT
190 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
191 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
192 INTERNAL_FIELD in Lisp_Cons.
193
c644523b
DA
1942012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
195
196 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
197 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
198 name since all xname users are fixed long time ago. Do not
199 use INTERNAL_FIELD.
200 (set_symbol_name, set_symbol_function, set_symbol_plist):
201 (set_symbol_next, set_overlay_plist): New function.
202 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
203 (struct Lisp_Overlay): Likewise.
204 (CVAR, MVAR, SVAR): Remove.
205 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
206 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
207 * xterm.c: Adjust users.
208 * .gdbinit: Change to use name field of struct Lisp_Symbol
209 where appropriate.
210
6a3d20cc
DA
2112012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
212
213 Basic functions to set Lisp_Object and pointer slots of intervals.
214 * intervals.h (interval_set_parent, interval_set_object):
215 (interval_set_left, interval_set_right, interval_set_plist):
216 (interval_copy_parent): New function.
217 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
218 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
219 Adjust indentation.
6a3d20cc
DA
220 (INTERVAL_SIZE): Remove. Adjust users.
221 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
222
4d2b044c
DA
2232012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
224
225 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
226 * process.h (PGET): Remove.
227 (struct Lisp_Process): Do not use INTERNAL_FIELD.
228 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
229
d3d50620
DA
2302012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
231
232 Drop WGET and revert read access to Lisp_Objects slots of struct window.
233 * window.h (WGET): Remove.
234 (struct window): Do not use INTERNAL_FIELD.
235 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
236 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
237 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
238 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
239 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
240 Adjust users.
241
d10a51dc
CY
2422012-08-07 Chong Yidong <cyd@gnu.org>
243
244 * window.c (Fwindow_edges, Fwindow_pixel_edges)
245 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
246 (Fdelete_window_internal): Signal an error if the window is not on
247 a live frame (Bug#12025).
248
e69b0960
DA
2492012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
250
251 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
252 * frame.h (FGET): Remove.
253 (struct frame): Do not use INTERNAL_FIELD.
254 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
255 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
256 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
257 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
258
25a20a3a
JB
2592012-08-06 Juanma Barranquero <lekktu@gmail.com>
260
261 * w32.c: Silence compiler warnings.
262 (map_w32_filename): Remove unused variable `is_fat'.
263 (chase_symlinks): Add parentheses around expression.
264
1c6f11f4
GM
2652012-08-06 Glenn Morris <rgm@gnu.org>
266
1db4583a
GM
267 * sysdep.c: Respect BROKEN_GETWD.
268
1c6f11f4
GM
269 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
270 Let configure handle it.
271 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
272
2b90362b
DA
2732012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
274
275 Use GCALIGNMENT where appropriate.
276 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
277 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
278 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
279
5f50daf2
EZ
2802012-08-06 Eli Zaretskii <eliz@gnu.org>
281
14ae4239
BT
282 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
283 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 284
cbcc7007
SM
2852012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
286
287 * buffer.h (struct buffer): Revert `indirections' to a simple int;
288 that should be sufficient for everyone.
289
4d365fa4
JD
2902012-08-06 Jan Djärv <jan.h.d@swipnet.se>
291
292 * keyboard.c (timer_check_2): Add break so timer_check returns next
293 timeout.
294
dd86bd82
DA
2952012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
296
297 Fix Windows build errors introduced after converting to WGET and WSET.
298 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
299 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
300
054e1668
JD
3012012-08-06 Jan Djärv <jan.h.d@swipnet.se>
302
303 * nsterm.m (ns_frame_rehighlight): Use FSET.
304
305 * nsmenu.m (ns_update_menubar): Use FSET.
306
21238f11
DA
3072012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
308
309 Separate read and write access to Lisp_Object slots of Lisp_Process.
310 * process.h (PGET, PSET): New macros similar to AREF and ASET.
311 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
312
077288cf
DA
3132012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
314
315 Separate read and write access to Lisp_Object slots of struct window.
316 * window.h (WGET, WSET): New macros similar to AREF and ASET.
317 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
318 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
319 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
320 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
321 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
322 Adjust users.
323
71688bd7
DA
3242012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
325
326 Fix Windows build errors introduced after converting to FGET and FSET.
327 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
328 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
329 (w32_judge_scroll_bars): Change to use FSET.
330 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
331
f99bac93
DA
3322012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
333
334 Fix replacement typo.
335 * window.c (replace_window): Set root_window instead of
336 selected_window. This fixes a total window subsystem
337 malfunction reported by Bastien Guerry <bzg@gnu.org>.
338
8c2a0f2d
GM
3392012-08-06 Glenn Morris <rgm@gnu.org>
340
341 * lisp.mk (lisp): Add language/persian.elc.
342
edd74c35
DA
3432012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
344
345 Separate read and write access to Lisp_Object slots of struct frame.
346 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
347 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
348 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
349 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
350 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
351
8671676c
AS
3522012-08-05 Andreas Schwab <schwab@linux-m68k.org>
353
354 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
355
663e2b3f
DA
3562012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
357
358 Generalize common compile-time constants.
359 * lisp.h (header_size, bool_header_size, word_size): Now here.
360 (struct Lisp_Vector): Add comment.
361 (struct Lisp_Bool_Vector): Move up to define handy constants.
362 (VECSIZE, PSEUDOVECSIZE): Simplify.
363 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
364 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
365 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
366 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
367 * xfont.c, xmenu.c: Use word_size where appropriate.
368
d32e47af
LM
3692012-08-05 Lawrence Mitchell <wence@gmx.li>
370
371 * search.c (Freplace_match): Treat \? in the replacement text
372 literally (Bug#8161).
373
e5d9c0d1
CY
3742012-08-05 Chong Yidong <cyd@gnu.org>
375
376 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
377 * frame.c (Vdelete_frame_functions):
378 * emacs.c (Vkill_emacs_hook): Doc fix.
379
8da0576b
EZ
3802012-08-04 Eli Zaretskii <eliz@gnu.org>
381
382 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
383 --with-x-toolkit=no builds.
384 Reported by Carsten Mattner <carstenmattner@gmail.com>.
385
02676e5d
CY
3862012-08-04 Chong Yidong <cyd@gnu.org>
387
388 * syntax.c (Fmodify_syntax_entry): Doc fix.
389
97147da9
EZ
3902012-08-04 Eli Zaretskii <eliz@gnu.org>
391
76151e2c
EZ
392 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
393 * w32.c (init_environment): Change the default values of many
394 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
395 them into environment when they were not already defined.
396 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 397 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
398 (check_windows_init_file): Now external, not static.
399 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
400 called when Vload_path is already set up.
401
402 * w32.h (check_windows_init_file): Add prototype.
403
404 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
405 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
406 compatibility with Posix platforms.
407 (main): Move the call to check_windows_init_file to here from
408 w32.c.
409 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
410 any, in the DEFALT argument into the root of the Emacs build or
411 installation tree, as appropriate.
412
413 * callproc.c (init_callproc_1): Call decode_env_path instead of
414 doing its equivalent by hand.
415 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
416 the code that sets Vexec_path run on MS-Windows.
417
418 * lread.c (init_lread): Add comments to #ifdef's.
419
97147da9
EZ
420 * msdos.c (dos_set_window_size, IT_update_begin)
421 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
422 instead of direct references.
423
185ee146
PE
4242012-08-04 Paul Eggert <eggert@cs.ucla.edu>
425
426 Export DEFAULT_REHASH_* to GDB.
427 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
428 Now constants, not macros.
429
8834c57a
PE
4302012-08-03 Paul Eggert <eggert@cs.ucla.edu>
431
98c6f1e3
PE
432 Remove unnecessary casts involving pointers.
433 These casts are no longer needed now that we assume C89 or later,
434 since they involve casting to or from void *.
435 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
436 (make_pure_float, make_pure_vector):
437 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
438 * macros.c (Fstart_kbd_macro):
439 * menu.c (find_and_return_menu_selection):
440 * minibuf.c (read_minibuf_noninteractive):
441 * sysdep.c (closedir):
442 * xdisp.c (x_produce_glyphs):
443 * xfaces.c (compare_fonts_by_sort_order):
444 * xfns.c (x_real_positions, select_visual):
445 * xselect.c (x_stop_queuing_selection_requests)
446 (x_get_window_property, x_get_window_property_as_lisp_data):
447 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
448 Remove unnecessary pointer casts.
449 * alloc.c (record_xmalloc): New function.
450 * lisp.h (record_xmalloc): New decl.
451 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
452 more like a function. This is because the pointer cast is not
453 needed. All uses changed.
454 * print.c (print_string, print_error_message): Avoid length recalc.
455
8834c57a
PE
456 Improve fix for macroexp crash with debugging (Bug#12118).
457 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
458 ARRAY_MARK_FLAG when checking subscripts, because ASET is
459 not supposed to be invoked from the garbage collector.
460 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
461 (gc_aset): New function, which is like ASET but can be
462 used in the garbage collector.
463 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
464 (set_hash_index): Use it instead of ASET.
465
6dad7178
EZ
4662012-08-03 Eli Zaretskii <eliz@gnu.org>
467
468 Support symlinks on latest versions of MS-Windows.
469 * w32.c: Include winioctl.h and aclapi.h.
470 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
471 (revert_to_self): Forward declarations of static functions.
472 <static BOOL g_b_init_get_security_info>:
473 <g_b_init_create_symbolic_link>: New static flags.
474 (globals_of_w32): Initialize them to zero.
475 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
476 (map_w32_filename): Improve commentary. Simplify switch.
477 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
478 headers (most versions of MinGW w32api don't).
479 (get_security_info, create_symbolic_link)
480 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
481 New functions.
482 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
483 in the argument file name.
484 (sys_access): Call unc_volume_file_attributes only if
485 GetFileAttributes fails with network-related error codes.
486 (sys_rename): Diagnose renaming of a symlink when the user doesn't
487 have the required privileges.
14ae4239 488 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
489 get_file_security_desc.
490 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
491 with addition of handling of symlinks and support for 'lstat'.
492 If possible, get file's attributes and security information by
6dad7178
EZ
493 handle, not by name. Produce S_IFLNK bit for symlinks, when
494 called from 'lstat'.
495 (stat, lstat): New functions, call 'stat_worker'.
496 (symlink, readlink, careadlinkat): Rewritten to create and resolve
497 symlinks when the underlying filesystem supports them.
498
f162bcc3
PE
4992012-08-02 Paul Eggert <eggert@cs.ucla.edu>
500
79ea6c20
PE
501 Fix macroexp crash on Windows with debugging (Bug#12118).
502 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
503 checking subscripts; problem introduced with the recent
504 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
505 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
506 since it's used in non-static inline functions now.
507
c0ce93fd
PE
508 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
509 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 510
f162bcc3
PE
511 Use C99-style 'extern inline' if available.
512 * buffer.h (BUFFER_INLINE):
513 * category.h (CATEGORY_INLINE):
514 * character.h (CHARACTER_INLINE):
515 * charset.h (CHARSET_INLINE):
516 * composite.h (COMPOSITE_INLINE):
517 * dispextern.h (DISPEXTERN_INLINE):
518 * lisp.h (LISP_INLINE):
519 * systime.h (SYSTIME_INLINE):
520 New macro, replacing 'static inline' in this header.
521 * buffer.h, category.h, character.h, charset.h, composite.h:
522 * dispextern.h, lisp.h, systime.h:
523 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
524 * alloc.c (LISP_INLINE):
525 * buffer.c (BUFFER_INLINE):
526 * category.c (CATEGORY_INLINE):
527 * character.c (CHARACTER_INLINE):
528 * charset.c (CHARSET_INLINE):
529 * composite.c (COMPOSITE_INLINE):
530 * dispnew.c (DISPEXTERN_INLINE):
531 * sysdep.c (SYSTIME_INLINE):
532 Define to EXTERN_INLINE, so that the corresponding functions
533 are compiled into code.
534 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
535 (INLINE_HEADER_END): New macros.
536 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
537 since it's used in non-static inline functions now.
a8333d03 538 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 539
837b365b
GM
5402012-08-02 Glenn Morris <rgm@gnu.org>
541
d66b744d
GM
542 * s/: Remove empty directory.
543
837b365b
GM
544 * s/ms-w32.h: Move to ../nt/inc.
545 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
546 Update for new ms-w32.h location.
547
13294f95
PE
5482012-08-02 Paul Eggert <eggert@cs.ucla.edu>
549
550 Port to Solaris 8.
551 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
552
90df0db3
GM
5532012-08-02 Glenn Morris <rgm@gnu.org>
554
555 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
556 hard-coding the path separator.
557
4939150c
PE
5582012-08-01 Paul Eggert <eggert@cs.ucla.edu>
559
560 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
561 This how ASET and AREF are supposed to work, and makes
562 it easier to think about future improvements. See
563 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
564 * charset.h (set_charset_attr): New function.
565 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
566 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
567 (aref_addr): New function. All uses of &AREF(...) changed.
568 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
569 (set_hash_index): New functions. All lvalue-style uses of
570 HASH_KEY etc. changed.
571 * keyboard.c (set_prop): New function. All lvalue-style uses
572 of PROP changed.
573
947b2afd
AA
5742012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
575
576 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
577 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
578 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
579 * nsfns.m (ns_set_name_as_filename): Likewise.
580 * nsmenu.m (ns_update_menubar): Likewise.
581 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
582
4f5d0325
EZ
5832012-08-01 Eli Zaretskii <eliz@gnu.org>
584
2008beae
EZ
585 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
586 Adapt to latest changes in field names of the corresponding Lisp
288479f6 587 objects.
2008beae 588
4f5d0325
EZ
589 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
590
fe3cc771
GM
5912012-08-01 Glenn Morris <rgm@gnu.org>
592
593 * s/msdos.h: Remove file.
594 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
595 * Makefile.in (S_FILE): Remove.
596 (config_h): Remove S_FILE.
597
c90acc54
JB
5982012-08-01 Juanma Barranquero <lekktu@gmail.com>
599
600 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
601 Remove; moved to nt/config.nt.
602
d8a05828
DA
6032012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
604
605 Use INTERNAL_FIELD for conses and overlays.
606 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
607 Remove obsolete comment.
608 (MVAR): New macro.
609 (struct Lisp_Overlay): Use INTERNAL_FIELD.
610 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
611
8271d590
DA
6122012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
613
614 Use INTERNAL_FIELD for symbols.
615 * lisp.h (SVAR): New macro. Adjust users.
616 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
617 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
618
3193acd2
DA
6192012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
620
621 Use INTERNAL_FIELD for processes.
622 * process.h (PVAR): New macro. Adjust style.
623 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
624 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
625
3a45383a
DA
6262012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
627
628 Use INTERNAL_FIELD for windows.
629 * window.h (WVAR): New macro.
630 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
631 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
632 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
633 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
634 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
635 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
636
c1dbc63c
PE
6372012-08-01 Paul Eggert <eggert@cs.ucla.edu>
638
639 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
640
5c0c0e8a
GM
6412012-08-01 Glenn Morris <rgm@gnu.org>
642
643 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
644 Move to configure.ac.
645
552a99b4
JB
6462012-08-01 Juanma Barranquero <lekktu@gmail.com>
647
648 * makefile.w32-in (CONFIG_H): Update dependencies.
649 (CONF_POST_H): New macro.
650
651 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
652
8d8e2dfe
GM
6532012-07-31 Glenn Morris <rgm@gnu.org>
654
bc96620a
GM
655 * Makefile.in (S_FILE): No longer set by configure.
656
476b1b2d
GM
657 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
658 is available.
659 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
660
b2c7a106
GM
661 * process.h (NULL_DEVICE):
662 * emacs.c (SEPCHAR):
663 * editfns.c (USER_FULL_NAME): Let configure set them.
664
d53d062a
GM
665 * s/README, s/template.h: Remove files.
666
4515017f
GM
667 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
668
8d8e2dfe
GM
669 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
670 Move to configure.ac.
671
5b20b3cc
EZ
6722012-07-31 Eli Zaretskii <eliz@gnu.org>
673
1e0afd9a
EZ
674 * .gdbinit (xframe): Adapt to introduction of FVAR and the
675 resulting renaming of 'struct frame' members.
676
5b20b3cc
EZ
677 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
678
679 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
680 after introduction of FVAR.
681
f1310128
JD
6822012-07-31 Jan Djärv <jan.h.d@swipnet.se>
683
79e721e0
JD
684 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
685
686 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
687 instead of compositeToPoint.
688 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
689
8d7c7eed 690 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 691
e34f7f79
DA
6922012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
693
694 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
695 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 696 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
697 (BVAR): Change to use INTERNAL_FIELD.
698 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
699 (KVAR): Change to use INTERNAL_FIELD.
700 * frame.h (FVAR): New macro.
701 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
702 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
703 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
704 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
705 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
706
c09bfb2f
DA
7072012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
708
709 Miscellaneous fixes for non-default X toolkits.
710 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
711 * xterm.c (x_frame_of_widget): Remove redundant prototype.
712 Move under #ifdef USE_LUCID.
713 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
714 definition and usage to avoid warnings.
715
14c114ae
JD
7162012-07-31 Jan Djärv <jan.h.d@swipnet.se>
717
718 * nsterm.m (openFiles): Fix previous checkin.
719
3bd21e82
PE
7202012-07-31 Paul Eggert <eggert@cs.ucla.edu>
721
722 * indent.c (compute_motion): Remove unused local.
723
c1529ded
GM
7242012-07-31 Glenn Morris <rgm@gnu.org>
725
400d5621
GM
726 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
727
268e2432
GM
728 * conf_post.h [USG5_4]:
729 Move remaining contents of s/usg5-4-common.h here.
730 * s/usg5-4-common.h: Remove file.
731
7552f3ee
GM
732 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
733 * s/irix6-5.h: Remove file.
734
6a381852
GM
735 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
736 * s/darwin.h: Remove file.
737
c1529ded
GM
738 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
739 * s/hpux10-20.h: Remove file, which is now empty.
740
b429a4ee
GM
7412012-07-30 Glenn Morris <rgm@gnu.org>
742
743 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
744 * Makefile.in (config_h): Add conf_post.h.
745 * makefile.w32-in (CONFIG_H): Add conf_post.h.
746
adff3182
JD
7472012-07-30 Jan Djärv <jan.h.d@swipnet.se>
748
749 * nsterm.m (ns_do_open_file): New variable.
b9031d69 750 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
751 (openFile, openTempFile, openFileWithoutUI, openFiles):
752 Open files only if ns_do_open_file.
adff3182 753
c32af1e4
PE
7542012-07-30 Paul Eggert <eggert@cs.ucla.edu>
755
7393bcbb
PE
756 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
757 This no-op macro hasn't been needed for many years.
758 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
759
c32af1e4
PE
760 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
761 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
762 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
763 gdb_make_enums_visible.
764 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
765 (DIRECTORY_SEP): Now a constant, not a macro.
766
302fc036
EZ
7672012-07-30 Eli Zaretskii <eliz@gnu.org>
768
769 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
770 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
771
772 * w32term.c <w32_keyboard_codepage>: Renamed from
773 keyboard_codepage and now external. All users changed.
774
775 * w32term.h: Add declaration of w32_keyboard_codepage.
776
777 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
778 the codepage to translate keys to Unicode. If this argument is
779 -1, use the value returned by GetConsoleCP. All callers changed.
780
88fb40b4
PE
7812012-07-30 Paul Eggert <eggert@cs.ucla.edu>
782
0aee6912
PE
783 Update .PHONY listings in makefiles.
784 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
785 bootstrap-clean, distclean, maintainer-clean, versioclean,
786 extraclean, frc.
787
88fb40b4
PE
788 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
789 This is a bit clearer. Fix some commentary typos.
790
0a763bd1
GM
7912012-07-30 Glenn Morris <rgm@gnu.org>
792
32bac6d6
GM
793 * s/netbsd.h: Let configure include signal.h if needed.
794 Remove file, which is now empty.
795
b65e7c46
GM
796 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
797 Let configure set them.
798 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
799 No more need to undefine.
0a763bd1 800
169304bd
AS
8012012-07-30 Andreas Schwab <schwab@linux-m68k.org>
802
803 * keymap.c (Fkey_description): Don't remove 0x80 bit from
804 non-single-byte char when adding meta modifier. (Bug#12090)
805
6cd7a139
DA
8062012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
807
808 Convert safe_call to use variable number of arguments.
809 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
810 (safe_call2): Fix comment.
811 * lisp.h (safe_call): Adjust prototype.
812 * coding.c (encode_coding_object): Change to use safe_call2.
813 * xfaces.c (merge_face_heights): Change to use safe_call1.
814
d34d6ffc
GM
8152012-07-30 Glenn Morris <rgm@gnu.org>
816
7b8a48e4 817 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 818 does that unconditionally. Remove file, which is now empty.
7b8a48e4 819
d34d6ffc
GM
820 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
821 Remove empty files.
822
03a660a6
PE
8232012-07-30 Paul Eggert <eggert@cs.ucla.edu>
824
825 Export to GDB most of lisp.h's remaining object-like macros.
826 * lisp.h (min, max): Move earlier, because they're used earlier now.
827 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
828 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
829 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
830 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
831 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
832 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
833 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
834 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
835 Now constants, for GDB. They need not be macros.
836 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
837 Now constants, for GDB, as well as macros, for static initializers.
838 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
839 Move to after the definition of struct Lisp_Char_Table,
840 since the former now needs that type defined.
841 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
842 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
843 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
844 New enums, for gdb_make_enums_visible.
845 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 846 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
847 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
848 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
849 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
850 enum maxargs, enum MAX_ALLOCA.
851 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
852 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
853 no longer needed, now that they are done in lisp.h.
854
e499d0ee
DA
8552012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
856
857 Cleanup string bytes checking.
858 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
859 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
860 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
861 (check_sblock, compact_small_strings): Simplify.
862
d5040d2d
PE
8632012-07-29 Paul Eggert <eggert@cs.ucla.edu>
864
865 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
866 These macros are confusing and no longer need to be defined, as
867 the enum values now suffice. All uses replaced with definiens.
868 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
869
7f259ae6
JB
8702012-07-29 Juanma Barranquero <lekktu@gmail.com>
871
872 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
873 ($(BLD)/w32console.$(O)): Update dependencies.
874
7e63e0c3
DA
8752012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
876
877 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
878 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
879 time. Adjust users.
880 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
881
ffd817eb
JD
8822012-07-29 Jan Djärv <jan.h.d@swipnet.se>
883
884 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
885 setting sitelisp (Bug#12010).
886
417a7a0e
EZ
8872012-07-29 Eli Zaretskii <eliz@gnu.org>
888
14ae4239 889 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
890
891 * w32heap.c (cache_system_info):
892 * w32.c (sys_rename):
893 * w32proc.c (find_child_console, sys_kill): All users changed.
894
387d4d92
PE
8952012-07-29 Paul Eggert <eggert@cs.ucla.edu>
896
897 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
898
55a6cca6
EZ
8992012-07-29 Eli Zaretskii <eliz@gnu.org>
900
901 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
902
dbcf001c
DA
9032012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
904
905 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
906 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
907 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 908
e2688e4a
DA
9092012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
910
911 Generalize marker debugging code under MARKER_DEBUG and use eassert.
912 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
913 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
914 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
915 (replace_range, replace_range_2, del_range_2): Change to eassert.
916 * marker.c (byte_char_debug_check): Adjust style.
917
b46a6a83
PE
9182012-07-29 Paul Eggert <eggert@cs.ucla.edu>
919
920 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
921 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
922 long-ago-commented-out code that talks about "WIN32".
923 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
924 All uses changed.
925
e32a5799
PE
9262012-07-28 Paul Eggert <eggert@cs.ucla.edu>
927
928 Use Gnulib stdalign module (Bug#9772, Bug#9960).
929 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
930 Simplify by using alignof.
931 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
932 * lisp.h: Include <stdalign.h>.
933 (GCALIGNMENT): New macro and constant.
934 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
935 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
936 (stdalign): New macro, if not already defined.
937
df81cd29
EZ
9382012-07-28 Eli Zaretskii <eliz@gnu.org>
939
01bd1b0d
EZ
940 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
941 * w32inevt.c: Include w32inevt.h.
942 (w32_read_console_input): New inline function, calls either
943 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
944 w32_console_unicode_input.
945 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
946 (w32_kbd_patch_key, key_event): Use the codepage returned by
947 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
948 (key_event): use uChar.UnicodeChar only if
949 w32_console_unicode_input is non-zero.
950
951 * w32console.c: Include w32heap.h.
952 <w32_console_unicode_input>: New global variable.
953 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
954 family of Windows, zero otherwise.
955
956 * w32inevt.h: Declare w32_console_unicode_input.
957
df81cd29
EZ
958 * xdisp.c (init_iterator): Don't reference tip_frame in a build
959 --without-x. (Bug#11742)
960
c20fdd9e
PE
9612012-07-27 Paul Eggert <eggert@cs.ucla.edu>
962
963 Adjust GDB to reflect pvec_type changes (Bug#12036).
964 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
965 2012-07-04 changes to pseudovector representation.
966 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 967
32770973 9682012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
969
970 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
971 bus address.
972 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
973
3438fe21
EZ
9742012-07-27 Eli Zaretskii <eliz@gnu.org>
975
bcfbc9de
EZ
976 * alloc.c (listn): Fix the order the arguments are consed onto the
977 list.
978
3438fe21
EZ
979 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
980 enumeration constants, as PURE and HEAP are too general, and clash
981 with other headers and sources, such as gmalloc.c and the
982 MS-Windows system headers. All users changed.
983
eeaea515
DA
9842012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
985
986 Revert last save_excursion_save and save_excursion_restore changes.
987 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
988 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
989
073c88c2
DA
9902012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
991
992 Fix recently-introduced typos in Windows port.
993 Reported by Martin Rudalics <rudalics@gmx.at>.
994 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 995 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 996
4706125e
PE
9972012-07-27 Paul Eggert <eggert@cs.ucla.edu>
998
999 Improve GDB symbol export (Bug#12036).
1000 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1001 arms of an 'if', not using conditional expressions; otherwise GDB
1002 complains about the types in the unevaluated arm when the argument
1003 is an integer literal.
1004 (xgetint): Simplify expression.
1005 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1006 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1007 Zaretskii in <http://bugs.gnu.org/12036#13>.
1008 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1009 needed now that we have gdb_make_enums_visible.
1010 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1011 (enum enum_USE_LSB_TAG):
1012 New enum types, packaging up enums that need to be exported to GDB.
1013
694b6c97
DA
10142012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1015
1016 Utility function to make a list from specified amount of objects.
1017 * lisp.h (enum constype): New datatype.
1018 (listn): New prototype.
1019 * alloc.c (listn): New function.
1020 (Fmemory_use_count, syms_of_alloc): Use it.
1021 * buffer.c (syms_of_buffer): Likewise.
1022 * callint.c (syms_of_callint): Likewise.
1023 * charset.c (define_charset_internal): Likewise.
1024 * coding.c (syms_of_coding): Likewise.
1025 * keymap.c (syms_of_keymap): Likewise.
1026 * search.c (syms_of_search): Likewise.
1027 * syntax.c (syms_of_syntax): Likewise.
1028 * w32.c (init_environment): Likewise.
1029 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1030 * xdisp.c (syms_of_xdisp): Likewise.
1031 * xfns.c (syms_of_xfns): Likewise.
1032
6195f384
DA
10332012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1034
1035 Fast save_excursion_save and save_excursion_restore.
1036 * lisp.h (struct Lisp_Excursion): New data type.
1037 (PVEC_EXCURSION): New pseudovector type.
1038 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1039 to deal with it. Adjust comments.
1040 (init_marker, attach_marker): New prototype.
1041 (unchain_marker): Adjust prototype.
1042 * marker.c (attach_marker): Change to global.
1043 (init_marker): New function.
1044 * alloc.c (Fmake_marker, build_marker): Use it.
1045 (build_marker): More easserts.
1046 (mark_object): Handle struct Lisp_Excursion.
1047 * editfns.c (save_excursion_save, save_excursion_restore):
1048 Reimplement to use struct Lisp_Excursion. Add comments.
1049
5eceb8fb
PE
10502012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 Fix export of symbols to GDB (Bug#12036).
1053 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1054 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1055 emacs.c, as this is a more-suitable home. Had this been done earlier
1056 the fix for 12036 would have avoided some of the problems noted in
1057 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1058 would have been more obvious.
562157c8
PE
1059 * emacs.c: Do not include <verify.h>; no longer needed.
1060 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1061 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1062 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1063 Remove; now done in lisp.h.
1064 * lisp.h (PUBLISH_TO_GDB): New macro.
1065 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1066 (DATA_SEG_BITS): Use it.
1067 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1068 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1069 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1070 not be usable in #if. This simplifies things.
1071
d6749401
JB
10722012-07-26 Juanma Barranquero <lekktu@gmail.com>
1073
1074 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1075
1781b9e9
PE
10762012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1077
d89518db 1078 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1079 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1080 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1081 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1082 Adjust to changes in lisp.h and emacs.c, by using
1083 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1084 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1085 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1086 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1087 instead of gdb_valbits.
1088 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1089 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1090 instead of gdb_array_mark_flag.
1091 (xboolvector): Get size from $->size, not $->header.size.
1092 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1093 (xreload, hook-run, hookpost-run): Remove.
1094 * emacs.c: Include <verify.h>.
1095 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1096 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1097 Remove.
1098 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1099 (gdb_USE_LSB_TAG): New enum constants.
1100 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1101 Also define these as enum constants, so they're visible to GDB.
1102 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1103 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1104 as constants, so they're visible to GDB.
1105 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1106 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1107 Now enum constants, not macros, so they're visible to GDB.
1108 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1109 more convenient now. All uses changed.
1110 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1111 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1112
3628596a
DA
11132012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1114
1115 Explicitly free restriction data that are not needed anymore.
1116 * editfns.c (save_restriction_restore): Free restriction data.
1117
7abaf5cc
SM
11182012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1119
1120 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1121 add argument, tune behavior, and adjust all callers.
1122
71f88e00
PE
11232012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1124
1125 Use typedef for EMACS_INT, EMACS_UINT.
1126 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1127 than macros. This simplifies debugging in the usual case, since
1128 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1129 and it allows expressions involving EMACS_INT casts.
1130 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1131
57ec3034
JD
11322012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1133
1134 * nsterm.m (ns_read_socket): Return early if there is a modal
1135 window (Bug#12043).
1136
8137e7b3
MR
11372012-07-25 Martin Rudalics <rudalics@gmx.at>
1138
1139 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1140 that FOCUS-FRAME can be omitted.
1141
04e9897c
DA
11422012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1143
1144 Adjust buffer text indirection counters at the end of Fkill_buffer.
1145 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1146 buffer is definitely dead. This should really fix an issue reported
1147 by Christoph Scholtes again. (Bug#12007).
1148 (init_buffer_once): Initialize indirection counters of
1149 buffer_defaults and buffer_local_symbols (for sanity and safety).
1150
8a0484e1
EZ
11512012-07-24 Eli Zaretskii <eliz@gnu.org>
1152
1153 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1154 and continuation glyphs on tooltip frames, leave them at zero.
1155 Avoids continued lines in tooltips. (Bug#11832)
1156
fa691a83
DA
11572012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1158
1159 Simplify copy_overlay.
04e9897c 1160 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1161 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1162
436bc8e0
EZ
11632012-07-23 Eli Zaretskii <eliz@gnu.org>
1164
1165 * print.c (print_object): Don't crash when a frame's name is nil
1166 or invalid. (Bug#12025)
1167
1168 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1169 it signals an error when a tooltip frame is being created.
1170
d7a7fda3
DA
11712012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1172
1173 Cleanup miscellaneous objects allocation and initialization.
1174 * alloc.c (allocate_misc): Change to static. Add argument to
1175 specify the subtype. Adjust comment and users.
1176 (build_overlay): New function.
1177 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1178 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1179 (allocate_misc): Remove prototype.
1180 (build_overlay): Add prototype.
1181
11822012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1183
1184 Swap buffer text indirection counters in Fbuffer_swap_text.
1185 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1186 This avoids crash reported by Christoph Scholtes at
1187 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1188
9d7fa573
JD
11892012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1190
1191 * nsmenu.m (Popdown_data): New struct.
1192 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1193 free Popdown_data.
1194 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1195 (initWithContentRect): Make imgView and contentView non-static
1196 and autorelease them. Also autorelease img and matrix (Bug#12005).
1197 (dealloc): Remove (Bug#12005).
1198
0dd6d66d
DA
11992012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1200
1201 Adjust consing_since_gc when objects are explicitly freed.
1202 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1203 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1204 (free_cons, free_misc): Subtract object size from consing_since_gc.
1205
d36d71df
DA
12062012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1207
1208 Simplify and cleanup markers positioning code.
1209 * marker.c (attach_marker): More useful eassert.
1210 (live_buffer, set_marker_internal): New function.
1211 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1212 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1213
fb9ea40f
PE
12142012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1215
1216 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1217 as it's limited by the amount of memory, not by INT_MAX.
1218
2d5c5f7d
EZ
12192012-07-21 Eli Zaretskii <eliz@gnu.org>
1220
07fb592e
EZ
1221 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1222 in special-event-map. See the discussion at
1223 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1224 for the reasons.
1225
37a9eac8 1226 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1227 info.dwItemData. Fixes crashes on 64-bit Windows.
1228 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1229
c4328746
JD
12302012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1231
1232 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1233 (conversationIdentifier): Return value is NSInteger.
784051c4 1234 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1235
6e5d1c12
CY
12362012-07-21 Chong Yidong <cyd@gnu.org>
1237
1238 * window.c (decode_any_window): Signal an error if the window is
1239 on a dead frame (Bug#11984).
1240
9928463d
DA
12412012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1242
1243 Add indirection counting to speed up Fkill_buffer.
1244 * buffer.h (struct buffer): New member.
1245 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1246 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1247 base buffer indirection counter.
1248 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1249 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1250 through buffer list if indirection counter is 0.
1251
f8643a6b
DA
12522012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1253
1254 Extend the value returned by Fgarbage_collect with heap statistics.
1255 * alloc.c (Qheap): New symbol.
1256 (syms_of_alloc): DEFSYM it.
1257 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1258 (Fmemory_free): Remove.
1259 (syms_of_alloc): Don't defsubr it.
1260 * buffer.c (Fcompact_buffer): Remove.
1261 (syms_of_buffer): Don't defsubr it.
1262
dac616ff
DA
12632012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1264
1265 Make maybe_gc inline.
1266 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1267 * lisp.h (consing_since_gc, gc_relative_threshold)
1268 (memory_full_cons_threshold): Revert declaration.
1269 (maybe_gc): Remove prototype, define as inline.
1270 * alloc.c: Remove old commented-out code.
1271 (consing_since_gc, gc_relative_threshold)
1272 (memory_full_cons_threshold): Revert to global.
1273 (maybe_gc): Remove.
1274
d7ea76b4
DA
12752012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1276
1277 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1278 * lisp.h (build_unibyte_string): New function.
1279 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1280 * sysdep.c, w32fns.c, xfns.c: Use it.
1281 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1282 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1283 Adjust users accordingly.
1284 * font.h (font_open_by_name): Adjust prototype.
1285
765e61e3
DA
12862012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1287
1288 Cleanup calls to Fgarbage_collect.
1289 * lisp.h (maybe_gc): New prototype.
1290 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1291 Remove declarations.
1292 * alloc.c (maybe_gc): New function.
1293 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1294 Make them static.
1295 * bytecode.c (MAYBE_GC): Use maybe_gc.
1296 * eval.c (eval_sub, Ffuncall): Likewise.
1297 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1298 to avoid dependency from auto-save feature.
1299
52b852c7
PE
13002012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1303 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1304 'for_each_per_buffer_object_at'.
1305 All uses changed. It's better to use upper-case for macros that
1306 cannot be implemented as functions, to give the reader a clue
1307 that they're special.
1308
5db81e33
SM
13092012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1310
1311 * alloc.c (Fgarbage_collect): Tweak docstring.
1312
5b835e1d
DA
13132012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1314
1315 Tweak the value returned from Fgarbage_collect again.
1316 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1317 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1318 Adjust documentation.
1319 (total_vector_bytes): Rename to total_vector_slots, adjust
1320 accounting.
1321 (total_free_vector_bytes): Rename to total_free_vector_slots,
1322 adjust accounting.
1323 (Qstring_bytes, Qvector_slots): New symbols.
1324 (syms_of_alloc): DEFSYM them.
1325
9cd47b72
DA
13262012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1327
1328 Buffer compaction primitive which may be used from Lisp.
1329 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1330 (syms_of_buffer): Register Fcompact_buffer.
1331 * alloc.c (Fgarbage_collect): Use compact_buffer.
1332 * buffer.h (compact_buffer): New prototype.
1333 (struct buffer_text): New member.
1334
d17337e5
DA
13352012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1336
1337 New macro to iterate over all buffers, miscellaneous cleanups.
1338 * lisp.h (all_buffers): Remove declaration.
1339 * buffer.h (all_buffers): Add declaration, with comment.
1340 (for_each_buffer): New macro.
1341 * alloc.c (Fgarbage_collect, mark_object): Use it.
1342 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1343 (init_buffer): Likewise.
1344 * data.c (Fset_default): Likewise.
1345 * coding.c (code_conversion_restore): Remove redundant check
1346 for dead buffer.
1347 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1348
60cfd278
AS
13492012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1350
1351 Fix bug that created negative-length intervals.
1352 * intervals.c (merge_interval_right, merge_interval_left):
1353 Do not zero out this interval if it is absorbed by its children,
1354 as this interval's total length doesn't change in that case. See
1355 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1356
d06714cb
PE
13572012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1358
83713154
PE
1359 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1360 when invoking (make-bool-vector N t) and N is a positive
1361 multiple of 8 -- the last 8 bits were mistakenly cleared.
1362
d06714cb
PE
1363 Remove some struct layout assumptions in bool vectors.
1364 * alloc.c (bool_header_size): New constant.
1365 (header_size, word_size): Move earlier, as they're now used earlier.
1366 Use 'word_size' in a few more places, where it's appropriate.
1367 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1368 padding before the data member of a bool vector.
1369 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1370 than doing the check by hand with an abort ().
1371
464d5a5e
SM
13722012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1373
5fbc0409
SM
1374 * eval.c (Fdefvar): Don't check constants since we only set the var if
1375 it's not yet defined anyway (bug#11904).
1376
464d5a5e
SM
1377 * lisp.h (last_undo_boundary): Declare new var.
1378 * keyboard.c (command_loop_1): Set it.
1379 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1380 were auto-added by the command loop (bug#11774).
1381
8dc2e44a
AS
13822012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1383
1384 * w32font.c (Qsymbol): Remove local definition.
1385 (syms_of_w32font): Don't DEFSYM it.
1386
169925ec
DA
13872012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1388
1389 Fix sweep_vectors to handle large bool vectors correctly.
1390 * alloc.c (sweep_vectors): Account total_vector_bytes for
1391 bool vectors larger than VBLOCK_BYTES_MAX.
1392
5fbfb018
CY
13932012-07-18 Chong Yidong <cyd@gnu.org>
1394
1395 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1396 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1397
3ab6e069
DA
13982012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1399
1400 Return more descriptive data from Fgarbage_collect.
1401 Suggested by Stefan Monnier in
1402 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1403 * alloc.c (bounded_number): New function.
1404 (total_buffers, total_vectors): New variable.
1405 (total_string_size): Rename to total_string_bytes, adjust users.
1406 (total_vector_size): Rename to total_vector_bytes, adjust users.
1407 (sweep_vectors): Account total_vectors and total_vector_bytes.
1408 (Fgarbage_collect): New return value. Adjust documentation.
1409 (gc_sweep): Account total_buffers.
1410 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1411 (VECTOR_SIZE): Remove.
1412 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1413 (Qinterval, Qmisc): New symbols.
1414 (syms_of_data): Initialize them.
1415 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1416 (Qcons, Qbuffer): New declarations.
1417
6d02fe5b
PE
14182012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1419
1420 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1421 Round up, not down. Improve doc.
1422
b7ffe040
DA
14232012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1424
1425 Restore old code in allocate_string_data to avoid Faset breakage.
1426 Reported by Julien Danjou <julien@danjou.info> in
1427 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1428 * alloc.c (allocate_string_data): Restore old code with minor
1429 adjustments, fix comment to explain this subtle issue.
1430
4dc7c8d5
SM
14312012-07-17 Eli Zaretskii <eliz@gnu.org>
1432
1433 Remove FILE_SYSTEM_CASE.
1434 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1435
1436 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1437 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1438 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1439 call-process-region passes it through expand-file-name.
1440
1441 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1442
14432012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1444
1445 Fix crash when creating indirect buffer (Bug#11917)
1446 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1447 Don't handle unbound variables specially if non-zero.
1448 (Fbuffer_local_variables): Pass zero.
1449 (clone_per_buffer_values): Pass non-zero.
1450
14512012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1452
1453 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1454 to make the loop interruptible.
1455
14562012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1457
1458 * gnutls.c (emacs_gnutls_handshake): Only retry if
1459 GNUTLS_E_INTERRUPTED.
1460
cce7fefc
DA
14612012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1462
1463 Cleanup and convert miscellaneous checks to eassert.
1464 * alloc.c (mark_interval): Fix comment, partially rephrase
1465 old comment from intervals.h (see below).
1466 * intervals.c (find_interval, adjust_intervals_for_insertion)
1467 (delete_interval, adjust_intervals_for_deletion)
1468 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1469 Convert to eassert.
1470 (adjust_intervals_for_insertion, make_new_interval):
1471 Remove obsolete and unused code.
1472 * intervals.h (struct interval): Remove obsolete comment.
1473 * textprotp.c (erase_properties): Remove unused code.
1474 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1475 (Fremove_list_of_text_properties): Convert to eassert.
1476
9ea10cc3
CY
14772012-07-17 Chong Yidong <cyd@gnu.org>
1478
1479 * editfns.c (Finsert_char): Doc fix.
1480
3900d5de
DA
14812012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1482
1483 Fix previous change to make Fmemory_free always accurate.
1484 * alloc.c (make_interval): Update total_free_intervals.
1485 (make_float): Likewise for total_free_floats.
1486 (free_cons, Fcons): Likewise for total_free_conses.
1487 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1488 Likewise for total_free_vector_bytes.
1489 (Fmake_symbol): Likewise for total_free_symbols.
1490 (bytes_free): Remove.
1491
7098646f
DA
14922012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1493
1494 Simple free memory accounting feature.
1495 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1496 (sweep_vectors): Accumulate size of free vectors.
1497 (Fgarbage_collect): Setup bytes_free.
1498 (Fmemory_free): New function.
1499 (syms_of_alloc): Register it.
1500
22657b40
DA
15012012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1502
1503 Cleanup overlays checking.
1504 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1505 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1506 eassert and OVERLAYP.
1507 (sort_overlays): Change to use OVERLAYP.
1508
ddfc8813
RK
15092012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1510
1511 * editfns.c (Finsert_char): Make it interactive, and make the
1512 second arg optional. Copy interactive spec and docstring from
1513 ucs-insert.
1514
7c26cf3c
PE
15152012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1516
1517 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1518 Unlike the other wrapped functions, fabs has an unspecified
1519 effect on errno.
1520
5d127af9
JD
15212012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1522
1523 * nsterm.m (keyDown): Interpret flags without left/right bits
1524 as the left key (Bug#11670).
1525
6a0dd1d7
DA
15262012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1527
1528 Remove empty and useless init functions.
1529 * lisp.h (init_character_once, init_fns, init_image)
1530 (init_filelock, init_sound): Remove prototype.
1531 * character.c (init_character_once): Remove.
1532 * filelock.c (init_filelock): Likewise.
1533 * fns.c (init_fns): Likewise.
1534 * image.c (init_image): Likewise.
1535 * sound.c (init_sound): Likewise.
1536 * emacs.c (main): Adjust accordingly.
1537
7a6136fd
DA
15382012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1539
1540 * gtkutil.h: Tiny cleanups.
1541 (use_old_gtk_file_dialog): Remove useless declaration.
1542 (xg_uses_old_file_dialog): Add suggested const attribute.
1543
ce811ad9
EZ
15442012-07-15 Eli Zaretskii <eliz@gnu.org>
1545
1546 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1547 (bidi_paragraph_init): Use it to limit search forward for a strong
1548 directional character in abnormally large paragraphs full of
1549 neutral or weak characters. (Bug#11943)
1550
c9adfeaa
SF
15512012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1552
1553 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1554 the toolbar (Bug#9451).
1555 (xg_make_tool_item): Give the widget event box a transparent
1556 background.
1557
fff62aa9
DA
15582012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1559
1560 Cleanup basic allocation variables and functions.
1561 * alloc.c (ignore_warnings, init_intervals, init_float)
1562 (init_cons, init_symbol, init_marker): Remove.
1563 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1564 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1565 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1566 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1567 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1568 (staticidx, init_alloc_once, init_strings, free_ablock):
1569 Remove redundant initialization.
1570 * fns.c (init_weak_hash_tables): Remove.
1571 * lisp.h (init_weak_hash_tables): Remove prototype.
1572
9730daca
DA
15732012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1574
1575 Use zero_vector where appropriate.
1576 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1577 accordingly.
1578 * lisp.h (zero_vector): New declaration.
1579 * font.c (null_vector): Remove.
1580 (syms_of_font): Remove initialization and staticpro.
1581 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1582 * keymap.c (Faccessible_keymaps): Likewise.
1583
2e2d2a13
LL
15842012-07-15 Leo Liu <sdl.web@gmail.com>
1585
1586 * fringe.c: Fix typo in comments.
1587
cd276f6e
LL
15882012-07-14 Leo Liu <sdl.web@gmail.com>
1589
1590 * fringe.c: Add a new bitmap exclamation-mark.
1591
5a1131d9
EZ
15922012-07-14 Eli Zaretskii <eliz@gnu.org>
1593
1594 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1595
1596 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1597 (HAVE_MENUS): Don't define, defined by editing config.in with
1598 msdos/sed2v2.inp.
1599 (GMALLOC_INHIBIT_VALLOC): Don't define.
1600 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1601
22e983b7
JB
16022012-07-14 Juanma Barranquero <lekktu@gmail.com>
1603
1604 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1605
5b3f250f
GM
16062012-07-14 Glenn Morris <rgm@gnu.org>
1607
1608 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1609 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1610 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1611
33d63ff4
GM
16122012-07-13 Glenn Morris <rgm@gnu.org>
1613
5b633342
GM
1614 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1615
33d63ff4
GM
1616 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1617 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1618
b55b9f85
JD
16192012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1620
0dc8cf50
JD
1621 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1622 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1623 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1624 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1625 where appropriate.
1626 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1627 as boolean expression.
1628 (x_set_window_size): Remove unused variable toolbar.
1629 (ns_get_color_default, ns_mod_to_lisp): Remove.
1630 (ns_mouse_position): Remove unused variables xchar and ychar.
1631 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1632 (ns_set_vertical_scroll_bar): Remove unused variable count.
1633 (ns_delete_terminal): Remove unused variable i.
1634 (ns_term_init): Remove unused variables r, g and b.
1635 (mouseDown): Remove unused variable window.
1636 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1637 (initFrameFromEmacs): Remove unused variable vbextra.
1638 (mouseEntered): Remove unused variables p and dpyinfo.
1639 (mouseExited): Remove unused variables p and r.
1640 (ns_define_frame_cursor, ns_clear_frame_area)
1641 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1642 (menuDown): Assign [sender tag] to variable and cast the variable.
1643
1644 * nsterm.h (menuDown): Add id as type to argument sender.
1645 (ns_display_info_for_name): Add Lisp_Object argument.
1646 (ns_term_init): Add Lisp_Object argument.
1647 (ns_map_event_to_object): Add void argument.
1648 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1649 prototype with arguments and only declare if __OBJC__.
1650 (nxatoms_of_nsselect): Add void argument.
1651 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1652 (ns_alloc_autorelease_pool): Add void argument.
1653 (ns_release_autorelease_pool): Add void* argument.
1654 (ns_get_defaults_value): Add const char* argument.
1655
1656 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1657 (initFromContents): Use SSDATA where appropriate.
1658 (ns_update_menubar): Add braces to ambigous if-else.
1659 (initWithTitle): Put () around assignment in if statement.
1660 (ns_menu_show): Remove unused variables window and keymap.
1661 (update_frame_tool_bar): Remove unused variable selected_p.
1662 (initWithContentRect): Remove unused variable this_cmd_name.
1663
1664 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1665 appropriate.
1666 (setXBMColor): Remove unused variable len.
1667 (setPixmapData): Put () around assignment in loop statement.
1668
1669 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1670 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1671 where appropriate.
1672 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1673 around assignment in loop statement.
1674 (nsfont_open): Remove unused variable i.
1675 (nsfont_open): Remove unused variable len.
1676 (nsfont_draw): Remove unused variable cs.
1677
1678 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1679 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1680 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1681 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1682 (Fns_font_name, Fns_perform_service)
1683 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1684 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1685 (ns_set_name): Remove unused variable view.
1686 (x_set_menu_bar_lines): Remove unused variable olines.
1687 (x_set_tool_bar_lines): Remove unused variable root_window.
1688 (Fns_list_colors): Put () around assignment in while statement.
1689 (Fns_perform_service): Remove unused variable len.
1690 (Fns_display_usable_bounds): Remove unused variable top.
1691 (syms_of_nsfns): Remove unused variable i.
1692
b55b9f85
JD
1693 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1694 memcpy (Bug#11907).
1695
ed9265fc 16962012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1697
1698 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1699 and free it with DestroyExceptionInfo (Bug#11558).
1700
ef099b57
JB
17012012-07-13 Juanma Barranquero <lekktu@gmail.com>
1702
1703 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1704 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1705 Set here, not in nt/config.nt.
1706
ea814a5d
EZ
17072012-07-13 Eli Zaretskii <eliz@gnu.org>
1708
1709 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1710 cursor overflow into the last glyph on display line when the right
1711 fringe is off. (Bug#11832)
1712
1a952767
PE
17132012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1714
1715 * xdisp.c (produce_special_glyphs): Now static.
1716 * dispextern.h (produce_special_glyphs): Remove decl.
1717
983188fd
GM
17182012-07-13 Glenn Morris <rgm@gnu.org>
1719
8d7c7eed 1720 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1721 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1722
983188fd
GM
1723 * s/usg5-4-common.h (USG, USG5):
1724 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1725 * s/sol2-6.h (SOLARIS2):
1726 * s/irix6-5.h (IRIX6_5):
1727 * s/hpux10-20.h (USG, USG5, HPUX):
1728 * s/gnu-linux.h (USG, GNU_LINUX):
1729 * s/freebsd.h (BSD_SYSTEM):
1730 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1731 * s/cygwin.h (CYGWIN):
1732 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1733 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1734
d1e68667 17352012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1736
1737 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1738
6de0e799
GM
17392012-07-13 Glenn Morris <rgm@gnu.org>
1740
739ae010
GM
1741 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1742
dbee5793
GM
1743 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1744
6de0e799
GM
1745 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1746 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1747
b82da769
GM
17482012-07-12 Glenn Morris <rgm@gnu.org>
1749
4fae5a7a 1750 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1751
1752 * process.c (init_process_emacs): Rename from init_process.
1753 The old name is also the name of a Mach system call.
1754 * lisp.h, emacs.c: Update for this name change.
1755 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1756 longer needed.
1757
5a979817
EZ
17582012-07-12 Eli Zaretskii <eliz@gnu.org>
1759
1760 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1761 memmove call that removes glyphs covered by the left truncation
1762 glyph. Improve commentary.
1763 (display_line): Fix display of continuation glyphs on GUI frames
1764 when the right fringe is turned off and variable-size fonts are
1765 used in the window. Move the code that appends a stretch glyph to
1766 produce_special_glyphs, so that it could be used for truncation
1767 and continuation glyphs alike.
1768 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1769 glyph of a suitably computed width, to align the special glyphs at
1770 the window margin. Code moved from display_line. (Bug#11832)
1771
3e91a053
GM
17722012-07-12 Glenn Morris <rgm@gnu.org>
1773
ba9e4b84
GM
1774 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1775
1776 * s/gnu-linux.h, s/hpux10-20.h:
1777 Do not unconditionally define HAVE_XRMSETDATABASE.
1778
3e91a053
GM
1779 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1780
b300b1f4
PE
17812012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1782
1783 Fix typos that broke OS X build.
1784 Reported by Randal L. Schwartz in
1785 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1786 * nsterm.m (ns_timeout): Add missing local decl.
1787 (ns_get_color): snprintf -> sprintf, to fix typo.
1788
6e777848
GM
17892012-07-12 Glenn Morris <rgm@gnu.org>
1790
3f922c37
GM
1791 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1792 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1793 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1794 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1795
0ab7b23a
GM
1796 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1797 Move PTY_OPEN to configure.
1798
6e777848
GM
1799 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1800 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1801 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1802
4a7edc24
DA
18032012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1804
1805 Use empty_unibyte_string where applicable.
1806 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1807 * lread.c (read1): Likewise.
1808 * xsettings.c (syms_of_xsettings): Likewise.
1809
308aab79
GM
18102012-07-12 Glenn Morris <rgm@gnu.org>
1811
42bd1719
GM
1812 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1813 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1814 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1815 * s/hpux10-20.h (RUN_TIME_REMAP):
1816 * s/bsd-common.h (TABDLY): Move to configure.
1817
1818 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1819
1820 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1821
ea0bbd17 1822 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1823 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1824
1825 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1826
308aab79
GM
1827 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1828 * s/template.h: Move NARROWPROTO to configure.
1829
ee1cf5cf
GM
18302012-07-11 Glenn Morris <rgm@gnu.org>
1831
30fe9bf4
GM
1832 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1833 unused since 2011-01-17 change to systty.h.
1834
ee1cf5cf
GM
1835 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1836 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1837 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1838
63e47e07
PE
18392012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1842
c43fb4c3
GM
18432012-07-11 Glenn Morris <rgm@gnu.org>
1844
1845 * s/darwin.h, s/gnu-linux.h, s/template.h:
1846 Move INTERRUPT_INPUT to configure.
1847
e8df9267
DA
18482012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1849
1850 Minor adjustments to interning code.
1851 * lisp.h (intern, intern_c_string): Redefine as static inline
1852 wrappers for intern_1 and intern_c_string_1, respectively.
1853 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
1854 * lread.c (intern_1, intern_c_string_1, oblookup):
1855 Simplify Vobarray checking.
e8df9267
DA
1856 * font.c (font_intern_prop): Likewise. Adjust comment.
1857 * w32font.c (intern_font_name): Likewise.
1858
34348bd4
AS
18592012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1860
d96a1e0c
AS
1861 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1862
34348bd4
AS
1863 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1864 of Fcar/Fcdr if possible.
1865 * font.c (check_otf_features): Likewise.
1866 * fontset.c (Fnew_fontset): Likewise.
1867 * gnutls.c (Fgnutls_boot): Likewise.
1868 * minibuf.c (read_minibuf): Likewise.
1869 * msdos.c (IT_set_frame_parameters): Likewise.
1870 * xmenu.c (Fx_popup_dialog): Likewise.
1871 * w32menu.c (Fx_popup_dialog): Likewise.
1872
c8add24e
GM
18732012-07-11 Glenn Morris <rgm@gnu.org>
1874
4b575b3c
GM
1875 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1876 since nothing has defined it on these platforms.
1877
09f4e3b0
GM
1878 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1879 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1880
172bedef
GM
1881 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1882 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1883 Move CLASH_DETECTION to configure.
1884
249685df
GM
1885 * s/gnu.h: Remove file, which is now empty.
1886
c8add24e
GM
1887 * s/gnu.h, s/gnu-linux.h:
1888 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1889
b41253a3
JW
18902012-07-11 John Wiegley <johnw@newartisans.com>
1891
1892 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1893 function attribute, so we only use it if it exists in the
1894 compiler.
1895
d923b542
DA
18962012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1897
1898 Avoid call to strlen in fast_c_string_match_ignore_case.
1899 * search.c (fast_c_string_match_ignore_case): Change to use
1900 length argument. Adjust users accordingly.
1901 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1902
5ebbef1d
PE
19032012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1904
bb352260
PE
1905 Assume mkdir, rmdir.
1906 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1907 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1908
57054ddd
PE
1909 Assume rename.
1910 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1911
b747d3f7
PE
1912 Assume perror.
1913 * s/hpux10-20.h (HAVE_PERROR): Remove.
1914 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1915 Remove dummy definition, as this problem was obsolete long ago.
1916
5ebbef1d
PE
1917 Assume strerror.
1918 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1919
984e7f30
DA
19202012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1921
1922 Avoid calls to strlen in font processing functions.
1923 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
1924 (font_open_by_name): Change to use length argument.
1925 Adjust users accordingly.
d923b542
DA
1926 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1927 Adjust prototypes.
1928 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1929 Change to return ptrdiff_t.
984e7f30
DA
1930 (xfont_list_pattern, xfont_match): Use length returned by
1931 xfont_decode_coding_xlfd.
1932 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1933
20e94fdd
GM
19342012-07-11 Glenn Morris <rgm@gnu.org>
1935
9d596af3
GM
1936 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1937 Move DONT_REOPEN_PTY to configure.
1938
20e94fdd
GM
1939 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1940 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1941
e99a530f
PE
19422012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1943
22ffb973
PE
1944 Remove "#define unix" that is no longer needed (Bug#11905).
1945 * s/aix4-2.h (unix): Remove; no longer needed.
1946
e9a9ae03
PE
1947 EMACS_TIME simplification (Bug#11875).
1948 This replaces macros (which typically do not work in GDB)
1949 with functions, typedefs and enums, making the code easier to debug.
1950 The functional style also makes code easier to read and maintain.
1951 * systime.h: Include <sys/time.h> on all hosts, not just if
1952 WINDOWSNT, since 'struct timeval' is needed in general.
1953 (EMACS_TIME): Now a typedef, not a macro.
1954 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1955 not macros.
1956 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1957 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1958 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1959 (EMACS_TIME_LE): Now functions, not macros.
1960 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1961 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1962 which are not functions. All uses rewritten to use:
1963 (make_emacs_time): New function.
1964 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1965 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1966 not functions. All uses rewritten to use the following, respectively:
1967 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1968 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1969 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1970 * fileio.c (Fcopy_file):
1971 * xterm.c (XTflash): Get the current time closer to when it's used.
1972 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1973
ffacb126
PE
1974 * bytecode.c (targets): Suppress -Woverride-init warnings.
1975
e99a530f
PE
1976 Simplify by avoiding confusing use of strncpy etc.
1977 * doc.c (Fsnarf_documentation):
1978 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1979 * frame.c (Fmake_terminal_frame):
1980 * gtkutil.c (get_utf8_string):
1981 * lread.c (openp):
1982 * nsmenu.m (ns_update_menubar):
1983 * regex.c (regerror):
1984 Prefer memcpy to strncpy and strncat when either will do.
1985 * fileio.c (Fsubstitute_in_file_name):
1986 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1987 (menu_separator_name_p):
1988 * nsmenu.m (ns_update_menubar):
1989 Prefer memcmp to strncmp when either will do.
1990 * nsterm.m: Include <ftoastr.h>.
1991 (ns_get_color):
1992 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1993 Prefer snprintf to strncpy.
1994 * nsterm.m (ns_term_init):
1995 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1996 * nsterm.m (ns_term_init):
1997 Avoid the need for strncpy, by using build_string or
1998 make_unibyte_string directly. Use dtoastr, not snprintf.
1999 * process.c (Fmake_network_process): Diagnose service names that
2000 are too long, rather than silently truncating them or creating
2001 non-null-terminated names.
2002 (Fnetwork_interface_info): Likewise, for interface names.
2003 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2004 Prefer sprintf to strncat.
2005 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2006 Prefer vsnprintf to vsprintf + strncpy.
2007
c59592b3
GM
20082012-07-10 Glenn Morris <rgm@gnu.org>
2009
2010 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2011 Clarify fallback case.
2012
7d7bbefd
DA
20132012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2014
2015 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2016 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2017 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2018 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2019 where argument type is known to be a Lisp_Cons.
2020
3a4c8000
TT
20212012-07-10 Tom Tromey <tromey@redhat.com>
2022
2023 * bytecode.c (BYTE_CODE_THREADED): New macro.
2024 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2025 (enum byte_code_op): New type.
2026 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2027 (exec_byte_code): Use them. Use token threading when applicable.
2028
2a0213a6
DA
20292012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2030
2031 Optimize pure C strings initialization.
2032 * lisp.h (make_pure_string): Fix prototype.
2033 (build_pure_c_string): New function, defined as static inline. This
2034 provides a better opportunity to optimize away calls to strlen when
2035 the function is called with compile-time constant argument.
2036 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2037 argument, adjust users accordingly. Use build_pure_c_string where
2038 appropriate.
2039 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2040 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2041 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2042
cb1caeaf
DA
20432012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2044
2045 Avoid calls to strlen in miscellaneous functions.
2046 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2047 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2048 * lread.c (openp): Likewise.
2049
c293e30c
DA
20502012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2051
2052 Avoid calls to strlen in path processing functions.
2053 * fileio.c (file_name_as_directory): Add comment. Change to add
2054 srclen argument and return the length of result. Adjust users
2055 accordingly.
2056 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2057 swap 1st and 2nd arguments to obey the common convention.
2058 Adjust users accordingly.
c293e30c
DA
2059 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2060
9e059e3f
GM
20612012-07-10 Glenn Morris <rgm@gnu.org>
2062
d02eb359
GM
2063 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2064 Move PENDING_OUTPUT_COUNT definition to configure.
2065
882cf227
GM
2066 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2067 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2068 * s/gnu.h (DATA_START): Move definitions to configure.
2069
af6e839f
GM
2070 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2071 We include usg5-4-common.h, which defines them both.
2072
40289a12
GM
2073 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2074 O_RDONLY already includes it).
2075
9e059e3f
GM
2076 Stop ns builds setting the EMACSLOADPATH environment variable.
2077 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2078 Now it does not set EMACSLOADPATH, just returns the load-path string.
2079 * nsterm.h: Update accordingly.
2080 * lread.c [HAVE_NS]: Include nsterm.h.
2081 (init_lread) [HAVE_NS]: Use ns_load_path.
2082 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2083
7c4e8ec0
GM
20842012-07-09 Glenn Morris <rgm@gnu.org>
2085
d4f600ff
GM
2086 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2087 since the included bsd-common.h does so.
2088
cbb31951
GM
2089 Stop ns builds setting the EMACSPATH environment variable.
2090 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2091 (ns_init_paths): Do not set EMACSPATH.
2092 * nsterm.h (ns_exec_path): Add it.
2093 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2094 Use ns_exec_path.
2095
7c4e8ec0
GM
2096 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2097
26bccfae
PE
20982012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2099
a0bee46f
PE
2100 * process.c (wait_reading_process_output): 'waitchannels' was unset
2101 when read_kbd || !NILP (wait_for_cell); fix this.
2102
5994c183
PE
2103 Add GCC-style 'const' attribute to functions that can use it.
2104 * character.h (char_resolve_modifier_mask):
2105 * keyboard.h (make_ctrl_char):
2106 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2107 (init_character_once, next_almost_prime, init_fns, init_image)
2108 (flush_pending_output, init_sound):
2109 * mem-limits.h (start_of_data):
2110 * menu.h (finish_menu_items):
2111 Add ATTRIBUTE_CONST.
2112 * emacs.c (DEFINE_DUMMY_FUNCTION):
2113 Declare the dummy function with ATTRIBUTE_CONST.
2114 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2115 Add decls with ATTRIBUTE_CONST.
2116
26bccfae
PE
2117 Minor improvements to make_formatted_string.
2118 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2119 where int is good enough, as vsprintf returns an int.
2120 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2121
a8290ec3
DA
21222012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2123
2124 Use make_formatted_string to avoid double length calculation.
2125 * lisp.h (make_formatted_string): New prototype.
2126 * alloc.c (make_formatted_string): New function.
2127 * buffer.c (Fgenerate_new_buffer_name): Use it.
2128 * dbus.c (syms_of_dbusbind): Likewise.
2129 * editfns.c (Fcurrent_time_zone): Likewise.
2130 * filelock.c (get_boot_time): Likewise.
2131 * frame.c (make_terminal_frame, set_term_frame_name)
2132 (x_report_frame_params): Likewise.
2133 * image.c (gs_load): Likewise.
2134 * minibuf.c (get_minibuffer): Likewise.
2135 * msdos.c (dos_set_window_size): Likewise.
2136 * process.c (make_process): Likewise.
2137 * xdisp.c (ensure_echo_area_buffers): Likewise.
2138 * xsettings.c (apply_xft_settings): Likewise.
2139
d01ba2f1
GM
21402012-07-09 Glenn Morris <rgm@gnu.org>
2141
2142 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2143 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2144 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2145 * nsterm.h (ns_etc_directory): Add it.
2146 * callproc.c [HAVE_NS]: Include nsterm.h.
2147 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2148
f1f924b6
DA
21492012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2150
2151 Move marker debugging code under MARKER_DEBUG.
2152 * marker.c (MARKER_DEBUG): Move marker debugging code under
2153 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2154 for bootstrap with --enable-checking (~3x slowdown reported
2155 by Juanma Barranquero <lekktu@gmail.com>).
2156 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2157
ab531b66
PE
21582012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2159
2160 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2161 See <http://bugs.gnu.org/11825#29>.
2162
c4b3bc8a
EZ
21632012-07-08 Eli Zaretskii <eliz@gnu.org>
2164
2165 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2166 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2167 (display_line): Add commentary about displaying truncation glyphs
2168 on GUI frames.
2169 (produce_special_glyphs): Move here from term.c.
2170
2171 * term.c (produce_special_glyphs): Move to xdisp.c.
2172
2173 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2174 section.
c4b3bc8a 2175
b676b881
AS
21762012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2177
f17c5273
AS
2178 * xdisp.c (display_line): Avoid warning about implicit declaration
2179 of FRAME_FONT.
2180
298819b9
AS
2181 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2182
b676b881
AS
2183 * lisp.h: Remove empty conditional.
2184
6045c4fd
PE
21852012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2186
b3350bf9
PE
2187 * lread.c (load_path_check): Now static.
2188
6045c4fd
PE
2189 Fix some minor --with-ns problems found by static checking.
2190 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2191 (x_set_font) [!HAVE_X_WINDOWS]:
2192 * image.c (xpm_load_image) [HAVE_NS]:
2193 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2194 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2195 Remove unused local.
2196 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2197 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2198 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2199 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2200 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2201 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2202 Fix pointer signedness problem.
2203 * xfaces.c (FRAME_X_FONT_TABLE):
2204 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2205
929e7845
GM
22062012-07-07 Glenn Morris <rgm@gnu.org>
2207
2208 * lread.c (load_path_check): New function, split from init_lread.
2209 (init_lread): Reorganize. Motivation:
2210 If EMACSLOADPATH is set, check/warn about that rather than the
2211 defaults, which we are not going to use. Hence we can remove
2212 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2213 Don't warn if site-lisp directories are missing.
2214 If not installed, start from a blank load-path, since
2215 PATH_LOADSEARCH refers to the eventual installation directories.
2216
58dd0aa4
EZ
22172012-07-07 Eli Zaretskii <eliz@gnu.org>
2218
2219 Support truncation and continuation glyphs on GUI frames, when
2220 fringes are disabled. (Bug#11832)
2221 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2222 continuation glyphs even if on GUI frames.
2223 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2224 or both, are absent.
2225 (start_display, move_it_in_display_line_to): Handle the case of a
2226 GUI frame without a fringe to display continuation or truncation
2227 glyphs.
2228 (insert_left_trunc_glyphs): Support GUI frames: make sure
2229 truncation glyphs overwrite enough glyphs from the current line to
2230 have sufficient space in pixels.
2231 (display_line): Support truncation and continuation glyphs on GUI
2232 frames. If some spare pixels are left on the line after inserting
2233 the truncation glyphs, fill that space with a stretch glyph of a
2234 suitably computed width.
2235
2236 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2237 produce_glyphs, to support GUI sessions.
2238
31571fd7
PE
22392012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2240
5a16b9bc
PE
2241 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2242
f3047c75
PE
2243 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2244
31571fd7
PE
2245 Do not require float-time's arg to fit in time_t (Bug#11825).
2246 This works better on hosts where time_t is unsigned, and where
2247 float-time is applied to the (negative) difference between two times.
2248 * editfns.c (decode_time_components): Last arg is now double *,
2249 not int *, and means to store all the result as a double, without
2250 worrying about whether the seconds part fits in time_t.
2251 All callers changed.
2252 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2253 All callers changed.
2254 (Ffloat_time): Do not fail merely because the specified time falls
2255 outside of time_t range.
2256
4516fbef
GM
22572012-07-07 Glenn Morris <rgm@gnu.org>
2258
2259 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2260 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2261 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2262
07adc2c6
JB
22632012-07-07 Juanma Barranquero <lekktu@gmail.com>
2264
2265 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2266 Update dependencies.
2267
2268 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2269
fd573f31
PE
22702012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2271
fee5959d
PE
2272 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2273 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2274 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2275 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2276 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2277 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2278
fd573f31
PE
2279 * xfont.c (compare_font_names): Redo to omit the need for casts.
2280
ddadbc0e
AS
22812012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2282
fca8d6b6
AS
2283 * xfns.c (Fx_change_window_property): Doc fix.
2284 * w32fns.c (Fx_change_window_property): Doc fix.
2285
ddadbc0e
AS
2286 * w32fns.c (Fx_window_property): Accept the same arguments as the
2287 X Windows version. Doc fix.
2288 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2289
ed9265fc 22902012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2291 Eli Zaretskii <eliz@gnu.org>
2292
2293 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2294 Windows-specific code from nt/config.nt moved here.
2295 Obsolete settings removed.
2296
216ee680
PE
22972012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2298
2299 * process.c: Avoid unnecessary calls to gettime.
2300 (wait_reading_process_output): Don't get the time of day
2301 when gobbling data immediately and not waiting, as there's no need
2302 for it in that case. This removes a FIXME.
2303
bdd091e4
JD
23042012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2305
2306 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2307 is defined (Bug#11768).
2308
9d44f8ce
DA
23092012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2310
2311 Fix marker debugging code.
2312 * marker.c (byte_char_debug_check): Do not perform the check
2313 if buffer is not multibyte.
090bd7cb
JB
2314 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2315 Call byte_char_debug_check with correct arguments.
9d44f8ce 2316
90fc4786
DA
23172012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2318
2319 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2320 * marker.c (byte_char_debug_check, count_markers):
2321 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2322 (byte_debug_flag): Remove.
2323 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2324 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2325
7b7ae965
DA
23262012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2327
4e57b342
DA
2328 Avoid code repetition in marker-related functions.
2329 * marker.c (attach_marker): New function.
2330 (Fset_marker, set_marker_restricted, set_marker_both)
2331 (set_marker_restricted_both): Use it.
2332 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2333 Consistently rename charno to charpos.
2334 (marker_position): Add eassert.
2335 (marker_byte_position): Convert to eassert.
2336
23372012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2338
2339 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2340 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2341 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2342
657924ff
DA
23432012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2344
2345 Introduce fast path for the widely used marker operation.
2346 * alloc.c (build_marker): New function.
2347 * lisp.h (build_marker): New prototype.
2348 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2349 * composite.c (autocmp_chars): Likewise.
2350 * editfns.c (buildmark): Remove.
2351 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2352 (save_restriction_save): Use build_marker.
2353 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2354 * window.c (save_window_save): Likewise.
2355
041a49a6
DA
23562012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2357
2358 Do not use Fdelete_overlay in delete_all_overlays
2359 to avoid redundant calls to unchain_overlay.
2360 * buffer.c (drop_overlay): New function.
2361 (delete_all_overlays, Fdelete_overlay): Use it.
2362 * minibuf.c (get_minibuffer): Fix comment.
2363
7dca65a4
PE
23642012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2365
2366 Port to OpenBSD 5.1 amd64.
2367 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2368 This is needed for OpenBSD, and should be harmless on all BSD systems.
2369 Also, include <sys/sysctl.h>, as it should be available on all
2370 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2371 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2372 use p_pid member, not kp_proc.pid.
2373
8eb876e2
GM
23742012-07-06 Glenn Morris <rgm@gnu.org>
2375
2376 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2377
38182d90
PE
23782012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 More xmalloc and related cleanup.
2381 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2382 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2383 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2384 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2385 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2386 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2387 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2388 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2389 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2390 * xterm.c:
2391 Omit needless casts involving void * pointers and allocation.
2392 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2393 as the former is more robust if P's type is changed.
2394 Prefer xzalloc to xmalloc + memset 0.
2395 Simplify malloc-or-realloc to realloc.
2396 Don't worry about xmalloc returning a null pointer.
2397 Prefer xstrdup to xmalloc + strcpy.
2398 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2399 growing it.
2400 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2401 alloca of a constant.
2402
6dd5a677
EZ
24032012-07-05 Eli Zaretskii <eliz@gnu.org>
2404
2405 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2406 hscroll is larger than the line width. Fixes long and futile
2407 looping inside extend_face_to_end_of_line (on a TTY) producing
2408 glyphs that are not needed and thrown away.
2409
6b312f0f
DA
24102012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2411
2412 * marker.c (set_marker_restricted_both): Simplify by using
2413 clip_to_bounds.
2414
f520ef9b
PE
24152012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2418
383b7c95
JD
24192012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2420
2421 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2422 not defined (Bug#11768).
2423 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2424 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2425 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2426 followed by gtk_box_set_homogeneous (Bug#11768).
2427 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2428 (update_theme_scrollbar_width, xg_create_scroll_bar):
2429 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2430 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2431 (is_box_type): New function (Bug#11768).
2432 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2433 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2434 with default display (Bug#11768).
2435
d6e7bf45
EZ
24362012-07-05 Eli Zaretskii <eliz@gnu.org>
2437
2438 * xdisp.c (window_hscroll_limited): New function.
2439 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2440 coordinates when window's hscroll is set to insanely large
2441 values. (Bug#11857)
2442
431391ec
JB
24432012-07-05 Juanma Barranquero <lekktu@gmail.com>
2444
2445 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2446 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2447
23f86fce
DA
24482012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2449
2450 Cleanup xmalloc.
2451 * lisp.h (xzalloc): New prototype. Omit needless casts.
2452 * alloc.c (xzalloc): New function. Omit needless casts.
2453 * charset.c: Omit needless casts. Convert all calls to
2454 xmalloc with following memset to xzalloc.
2455 * dispnew.c: Likewise.
2456 * fringe.c: Likewise.
2457 * image.c: Likewise.
2458 * sound.c: Likewise.
2459 * term.c: Likewise.
2460 * w32fns.c: Likewise.
2461 * w32font.c: Likewise.
2462 * w32term.c: Likewise.
2463 * xfaces.c: Likewise.
2464 * xfns.c: Likewise.
2465 * xterm.c: Likewise.
2466 * atimer.c: Omit needless casts.
2467 * buffer.c: Likewise.
2468 * callproc.c: Likewise.
2469 * ccl.c: Likewise.
2470 * coding.c: Likewise.
2471 * composite.c: Likewise.
2472 * doc.c: Likewise.
2473 * doprnt.c: Likewise.
2474 * editfns.c: Likewise.
2475 * emacs.c: Likewise.
2476 * eval.c: Likewise.
2477 * filelock.c: Likewise.
2478 * fns.c: Likewise.
2479 * gtkutil.c: Likewise.
2480 * keyboard.c: Likewise.
2481 * lisp.h: Likewise.
2482 * lread.c: Likewise.
2483 * minibuf.c: Likewise.
2484 * msdos.c: Likewise.
2485 * print.c: Likewise.
2486 * process.c: Likewise.
2487 * region-cache.c: Likewise.
2488 * search.c: Likewise.
2489 * sysdep.c: Likewise.
2490 * termcap.c: Likewise.
2491 * terminal.c: Likewise.
2492 * tparam.c: Likewise.
2493 * w16select.c: Likewise.
2494 * w32.c: Likewise.
2495 * w32reg.c: Likewise.
2496 * w32select.c: Likewise.
2497 * w32uniscribe.c: Likewise.
2498 * widget.c: Likewise.
2499 * xdisp.c: Likewise.
2500 * xmenu.c: Likewise.
2501 * xrdb.c: Likewise.
2502 * xselect.c: Likewise.
2503
0497dc44
PE
25042012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2505
2506 * fileio.c (time_error_value): Check the right error number.
2507 Problem reported by Troels Nielsen in
2508 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2509
356e7178
PE
25102012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2511
4e71fd89
PE
2512 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2513 This should be fixed in a better way; see Eli Zaretskii in
2514 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2515 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2516
f0941253
PE
2517 * fileio.c (time_error_value): Rename from special_mtime.
2518 The old name's problems were noted by Eli Zaretskii in
2519 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2520
065c9eb4
PE
2521 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2522 This variable's comment says Emacs needs at least one GDB-visible
2523 symbol of type enum pvec_type, to work around GDB problems.
2524 The symbol's value doesn't matter.
2525
356e7178
PE
2526 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2527 that causes compilation to fail on pre-C99 compilers.
2528
ed9265fc 25292012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2530
2531 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2532 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2533
3884d954
DA
25342012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2535
d209e2fb 2536 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2537 headers for buffer_defaults and buffer_local_symbols.
2538 Reported by Juanma Barranquero <lekktu@gmail.com>.
2539
ee28be33
SM
25402012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2541
2542 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2543 * lisp.h (enum pvec_type): Use fewer bits.
2544 (PSEUDOVECTOR_SIZE_BITS): New constant.
2545 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2546 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2547 change in pvec_type.
2548 (PSEUDOVECTOR_TYPEP): New macro.
2549 (TYPED_PSEUDOVECTORP): Use it.
2550 * fns.c (internal_equal): Adapt code to extract pvectype.
2551 * emacs.c (gdb_pvec_type): Update type.
2552 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2553 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2554 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2555 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2556 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2557 abusing vector->header.next.nbytes.
2558 (live_vector_p): Use PVEC_TYPE.
2559 (mark_object): Adapt code to extract pvectype. Use switch.
2560
c7f2cd7f
PE
25612012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2562
2563 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2564 Tighten new eassert a bit.
2565
8ce70ed2
DA
25662012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2567
2568 Fix compilation with --enable-gcc-warnings and -O1
2569 optimization level.
2570 * doprnt.c (doprnt): Change type of tem to int, initialize
2571 to avoid compiler warning. Add eassert.
2572 * search.c (simple_search): Initialize match_byte to avoid
2573 compiler warning. Add eassert.
2574
dea7f1e5
PE
25752012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2576
24a212eb
PE
2577 Avoid weird behavior with large horizontal scrolls.
2578 Without this change, for example, large hscroll values would
2579 mess up Emacs's display on Fedora 15 x86, presumably due to
2580 overflows in int calculations in the display code.
2581 Also, if buffers had long lines, Emacs would freeze.
2582 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2583 (set_window_hscroll): New function, containing the old guts of
2584 Fset_window_hscroll. Return the clipped value.
2585 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2586 This avoids the need to check against PTRDIFF_MAX.
2587
dea7f1e5
PE
2588 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2589
76046526
DA
25902012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2591
2592 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2593
39adff0d
PE
25942012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2595
63807d47
PE
2596 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2597 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2598 since GCC 4.4.6 issues a bogus warning for them.
2599
39adff0d
PE
2600 Fix bugs in file timestamp newness comparisons.
2601 * fileio.c (Ffile_newer_than_file_p):
2602 * lread.c (Fload): Use full timestamp resolution of files,
2603 not just the 1-second resolution, so that files that are only
2604 slightly newer still count as newer.
2605 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2606 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2607
dbeed9a6
PE
26082012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2609
2610 * fileio.c: Improve handling of file time marker. (Bug#11852)
2611 (special_mtime): New function.
2612 (Finsert_file_contents, Fverify_visited_file_modtime):
2613 Use it to set special mtime values consistently.
2614
636334d6
AS
26152012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2616
2617 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2618 marker for non-existing file. (Bug#11852)
2619
e2017fe2
GM
26202012-07-03 Glenn Morris <rgm@gnu.org>
2621
2622 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2623 and did not make it into globals.h).
2624
404dbd37
TT
26252012-07-03 Tom Tromey <tromey@redhat.com>
2626
2627 * window.c (Fset_window_margins, Fset_window_fringes)
2628 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2629 * textprop.c (Fprevious_property_change): No longer static.
2630 * syntax.c (Fsyntax_table_p): No longer static.
2631 * process.c (Fget_process, Fprocess_datagram_address): No longer
2632 static.
2633 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2634 * keyboard.c (Fcommand_execute): No longer static.
2635 Remove EXFUN.
2636 * insdel.c (Fcombine_after_change_execute): No longer static.
2637 * image.c (Finit_image_library): No longer static.
2638 * fileio.c (Fmake_symbolic_link): No longer static.
2639 * eval.c (Ffetch_bytecode): No longer static.
2640 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2641 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2642 No longer static.
404dbd37
TT
2643 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2644 static.
2645 * dired.c (Ffile_attributes): No longer static.
2646 * composite.c (Fcomposition_get_gstring): No longer static.
2647 * callproc.c (Fgetenv_internal): No longer static.
2648
2649 * ccl.h: Remove EXFUNs.
2650 * buffer.h: Remove EXFUNs.
2651 * dispextern.h: Remove EXFUNs.
2652 * intervals.h: Remove EXFUNs.
2653 * fontset.h: Remove EXFUN.
2654 * font.h: Remove EXFUNs.
2655 * dosfns.c (system_process_attributes): Remove EXFUN.
2656 * keymap.h: Remove EXFUNs.
2657 * lisp.h: Remove EXFUNs.
2658 * w32term.h: Remove EXFUNs.
2659 * window.h: Remove EXFUNs.
2660 * xsettings.h: Remove EXFUN.
2661 * xterm.h: Remove EXFUN.
2662
8e4fd1e1
GM
26632012-07-03 Glenn Morris <rgm@gnu.org>
2664
2665 * lisp.h (Frandom): Make it visible to C.
2666 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2667 buffer for invisible buffers. (Bug#1229)
2668
ca95b3eb
DA
26692012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2670
2671 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2672 values which aren't power of 2.
14ae4239
BT
2673 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2674 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2675 accordingly.
2676
7555c33f
SM
26772012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2678
2679 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2680
2681 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2682
d12e8f5a
DA
26832012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2684
2685 * alloc.c (allocate_vector_block): Remove redundant
2686 calls to mallopt if DOUG_LEA_MALLOC is defined.
2687 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2688 avoid calls to mallopt if zero_vector is returned.
2689
296094c3
DA
26902012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2691
2692 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2693 is enabled, avoid dereferencing NULL current_sblock if
2694 running undumped.
2695
36429c89
DA
26962012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2697
2698 Cleanup basic buffer management.
2699 * buffer.h (struct buffer): Change layout to use generic vector
2700 marking code. Fix some comments. Change type of 'clip_changed'
2701 to bitfield. Remove unused #ifndef old.
2702 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2703 (GET_OVERLAYS_AT): Fix indentation.
2704 (for_each_per_buffer_object_at): New macro.
2705 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2706 (Fbuffer_local_variables): Use it.
2707 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2708 * alloc.c (allocate_buffer): Adjust to match new layout of
2709 struct buffer. Fix comment.
2710 (mark_overlay): New function.
2711 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2712 Lisp area of struct buffer.
2713 (mark_object): Use it. Adjust marking of misc objects
2714 and related comments.
2715
3b3e4cac
PE
27162012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2717
2718 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2719 wrapper that is not needed because the wrapped code is a no-op (zero
2720 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2721 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2722
cf5c0175
DA
27232012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2724
2725 * alloc.c (mark_buffer): Simplify. Remove prototype.
2726 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2727 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2728 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2729 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2730
ca26824c
GM
27312012-06-30 Glenn Morris <rgm@gnu.org>
2732
2e4c5312
GM
2733 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2734
ca26824c
GM
2735 * epaths.in (PATH_SITELOADSEARCH): New.
2736 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2737 This is rather than relying on --enable-locallisppath elements
2738 having "site-lisp" in their names. (Bug#10208#25, 11658)
2739
0d23c240
EZ
27402012-06-30 Eli Zaretskii <eliz@gnu.org>
2741
c9240d7a
EZ
2742 * w32proc.c (sys_select): Accept and ignore one more argument.
2743
2744 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2745
0d23c240 2746 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2747 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2748
2749 * sysdep.c: Don't include dos.h and dosfns.h.
2750
2751 * process.c (sys_select):
2752 * msdos.c (sys_select): Accept one more argument and ignore it.
2753
2754 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2755 adapt data types and code to that.
2756
2757 * dosfns.c:
2758 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2759 which clashes with the gnulib function of the same name.
2760
af5a5a98
AS
27612012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2762
c5e4379c
AS
2763 * font.c (font_style_to_value, font_style_symbolic)
2764 (font_prop_validate_style): Add type checks for values in
2765 font_style_table.
2766
af5a5a98
AS
2767 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2768 argument.
2769 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2770 uses.
2771
8d38f461
EZ
27722012-06-29 Eli Zaretskii <eliz@gnu.org>
2773
2e5a6631
EZ
2774 * xdisp.c (try_window_id): Undo last change.
2775
8d38f461
EZ
2776 * w32.c (getwd): Adjust commentary about startup_dir.
2777 (init_environment): Always call sys_access, even in non-MSVC
2778 builds. Don't chdir to the directory of the Emacs executable.
2779 This undoes code from 1997 which was justified by the need to
2780 "avoid conflicts when removing and renaming directories". But its
2781 downside was that every relative file name was being interpreted
2782 relative to the directory of the Emacs executable, which can never
2783 be TRT. In particular, it broke sys_access when called with
2784 relative file names.
2785 (sys_access): Map GetLastError to errno.
2786
2af3565e
DA
27872012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2788
2789 * window.h (struct window): Change type of 'fringes_outside_margins'
2790 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2791 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2792 Adjust comment.
2793 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2794 to ptrdiff_t.
2795
c8d3a25c 27962012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2797
c8d3a25c
GM
2798 * gnutls.c (emacs_gnutls_handshake):
2799 Add QUIT to make the loop interruptible.
57570cd3 2800
c8d3a25c 28012012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2802
c8d3a25c
GM
2803 * charset.c (init_charset): Make lack of etc/charsets fatal.
2804
3e984ee8
DA
28052012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2806
2807 * editfns.c (region_limit): Fix type mismatch.
2808
ef884f23
DA
28092012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2810
2811 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2812 undefined. Convert from xassert to eassert.
2813 * nsmenu.m: Convert from xassert to eassert.
2814 * nsterm.m: Likewise.
2815
7d7e0027
SM
28162012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2817
2818 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2819
aa754e6a
PE
28202012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2821
2822 Avoid integer overflow on scroll-left and scroll-right.
2823 * window.c (HSCROLL_MAX): New macro.
2824 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2825 overflow when requested scroll falls outside ptrdiff_t range.
2826
80b00b08
DA
28272012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2828
2829 * window.h (struct window): Change type of 'hscroll',
2830 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2831 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2832 Adjust users accordingly.
2833 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2834 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2835 from EMACS_INT to ptrdiff_t.
2836 (make_window): Omit redundant initialization.
2837
62b2bcf6
JB
28382012-06-28 Juanma Barranquero <lekktu@gmail.com>
2839
2840 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2841
45942c7d
DA
28422012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2843
2844 * window.h (struct window): Change type of 'use_time' and
2845 'sequence_number' from Lisp_Object to int.
2846 * frame.c (make_frame): Adjust users accordingly.
2847 * print.c (print_object): Likewise.
2848 * window.c (select_window, Fwindow_use_time, make_parent_window)
2849 (make_window): Likewise.
2850
e509cfa6
DA
28512012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2852
2853 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2854 enabled with --enable-checking=[all,glyphs] configure option.
2855 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2856 adjust comments accordingly.
2857 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2858 undefined, adjust comments accordingly.
2859 * image.c: Likewise.
2860 * scroll.c: Likewise.
2861 * w32fns.c: Likewise.
2862 * w32term.c: Likewise.
2863 * xdisp.c: Likewise.
2864 * xfaces.c: Likewise.
2865 * xfns.c: Likewise.
2866 * xterm.c: Likewise.
2867
a54e2c05
DA
28682012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2869
2870 Generalize run-time debugging checks.
2871 * dispextern.h (XASSERTS): Remove.
2872 * fontset.c (xassert): Remove.
2873 Convert from xassert to eassert.
2874 * alloc.c: Convert from xassert to eassert.
2875 * bidi.c: Likewise.
2876 * dispnew.c: Likewise.
2877 * fns.c: Likewise.
2878 * fringe.c: Likewise.
2879 * ftfont.c: Likewise.
2880 * gtkutil.c: Likewise.
2881 * image.c: Likewise.
2882 * keyboard.c: Likewise.
2883 * menu.c: Likewise.
2884 * process.c: Likewise.
2885 * scroll.c: Likewise.
2886 * sound.c: Likewise.
2887 * term.c: Likewise.
2888 * w32console.c: Likewise.
2889 * w32fns.c: Likewise.
2890 * w32term.c: Likewise.
2891 * window.c: Likewise.
2892 * xdisp.c: Likewise.
2893 * xfaces.c: Likewise.
2894 * xfns.c: Likewise.
2895 * xselect.c: Likewise.
2896 * xterm.c: Likewise.
2897
1ec4b7b2
SM
28982012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2899
2900 * fns.c (maybe_resize_hash_table): Output message when growing the
2901 purify-hashtable.
2902
2014308a
DA
29032012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2904
2905 * alloc.c (allocate_string_data): Remove dead code.
2906 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2907 avoid GCC warning about unused macro.
2908
246155eb
DA
29092012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2910
2911 * alloc.c (allocate_string): Omit intervals initialization.
2912 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2913 as in make_pure_string and make_pure_c_string.
2914
43184b7b
DA
29152012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2916
d209e2fb 2917 * alloc.c (allocate_string): Fix last change.
43184b7b 2918
3fe6dd74
DA
29192012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2920
d209e2fb 2921 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2922 to memset, add explicit initialization where appropriate.
2923
1ba6038a
GM
29242012-06-27 Glenn Morris <rgm@gnu.org>
2925
2926 * lisp.mk (lisp): Remove paths.elc.
2927
c89926a5
CY
29282012-06-27 Chong Yidong <cyd@gnu.org>
2929
2930 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2931
ed6b3510
JW
29322012-06-26 John Wiegley <johnw@newartisans.com>
2933
1ec4b7b2 2934 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2935 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2936
ed6b3510
JW
2937 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2938 when building with Clang.
2939
8edd4a2b
SM
29402012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2941
2942 * eval.c (Fapply): Allow calling it with a single argument.
2943
f6f62d1b
EZ
29442012-06-26 Eli Zaretskii <eliz@gnu.org>
2945
2946 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2947 _stricmp and _strnicmp.
2948 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2949
62efea5e
DA
29502012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2951
2952 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2953 allocated window.
2954 (allocate_process): Likewise for new process.
8edd4a2b 2955 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2956 (allocate_frame): Likewise.
2957 * frame.c (make_frame): Omit redundant initialization.
2958 * window.c (make_parent_window): Use memset.
2959 (make_window): Omit redundant initialization.
2960 * process.c (make_process): Omit redundant initialization.
2961 * terminal.c (create_terminal): Likewise.
2962
42997f4d
DA
29632012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2964
2965 * term.c (delete_tty): Remove redundant call to memset.
2966
1130ecfc
DA
29672012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2968
2969 * alloc.c: Remove build_string.
2970 * lisp.h: Define build_string as static inline. This provides
2971 a better opportunity to optimize away calls to strlen when the
2972 function is called with compile-time constant argument.
2973 * image.c (imagemagick_error): Convert to build_string.
2974 * w32proc.c (sys_spawnve): Likewise.
2975 * xterm.c (x_term_init): Likewise.
2976
cf38a720
PE
29772012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2978
99027bdd
PE
2979 Use sprintf return value instead of invoking strlen on result.
2980 In the old days this wasn't portable, since some sprintf
2981 implementations returned char *. But they died out years ago and
2982 Emacs already assumes sprintf returns int.
2983 Similarly for float_to_string.
2984 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2985 * ccl.c (ccl_driver):
2986 * character.c (string_escape_byte8):
2987 * data.c (Fnumber_to_string):
2988 * doprnt.c (doprnt):
2989 * print.c (print_object):
2990 * xdisp.c (message_dolog):
2991 * xfns.c (syms_of_xfns):
2992 Use sprintf or float_to_string result to avoid need to call strlen.
2993 * data.c (Fnumber_to_string):
2994 Use make_unibyte_string, since the string must be ASCII.
2995 * lisp.h, print.c (float_to_string): Now returns int length.
2996 * term.c (produce_glyphless_glyph):
2997 Use sprintf result rather than recomputing it.
2998
cf38a720
PE
2999 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3000 * Makefile.in (ALL_CFLAGS):
3001 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3002 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3003
3511c784
DA
30042012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3005
0a08eb21 3006 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3007 strcasecmp if available.
3008 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3009
fb7da12e
AS
30102012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3011
3012 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3013 Avoid comma operator.
3014 * menu.c (push_submenu_start, push_submenu_end)
3015 (push_left_right_boundary, push_menu_pane): Likewise.
3016 * msdos.c (dos_rawgetc): Likewise.
3017
afa2ffd8
DA
30182012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3019
3020 * xfns.c (xic_create_fontsetname): Remove redundant calls
3021 to memset.
3022
b3b4476b
PE
30232012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3024
4495ff38
PE
3025 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3026 sprintf already null-terminates its output.
3027
b3b4476b
PE
3028 * xfns.c (x_window): Remove redundant cast.
3029
b00876c9
DA
30302012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3031
3032 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3033 `const char *' to `char *' to avoid compiler warning.
3034
d188e26b
PE
30352012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3036
885d1d74
PE
3037 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3038 instead of truncating it to 63 (admittedly a generous limit).
3039
d188e26b
PE
3040 * process.c: Fix spelling and caps in comments.
3041
e2f560b1
DN
30422012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3043
e86db54b 3044 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3045 * sysdep.c (setpgrp): Remove definition, not used in this file.
3046
7583a3a1
JB
30472012-06-24 Juanma Barranquero <lekktu@gmail.com>
3048
3049 * makefile.w32-in: Update dependencies.
3050
696056c2
EZ
30512012-06-24 Eli Zaretskii <eliz@gnu.org>
3052
3053 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3054 (SYSTIME_H): Add nt/inc/sys/time.h.
3055
3056 * systime.h [WINDOWSNT]: Include sys/time.h.
3057
3058 * s/ms-w32.h (struct timespec): Definition moved from
3059 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3060
845ca893
PE
30612012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3062
3063 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3064 * buffer.h (buffer_slot_type_mismatch):
3065 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3066 * eval.c (unwind_to_catch):
3067 * image.c (my_png_error, my_error_exit):
3068 * keyboard.c (quit_throw_to_read_char, user_error)
3069 (Fexit_recursive_edit, Fabort_recursive_edit):
3070 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3071 (wrong_type_argument, buffer_overflow, __executable_start)
3072 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3073 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3074 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3075 (fatal):
3076 (child_setup) [!DOS_NT]:
3077 * lread.c (end_of_file_error, invalid_syntax):
3078 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3079 * puresize.h (pure_write_error):
3080 * search.c (matcher_overflow):
3081 * sound.c (sound_perror, alsa_sound_perror):
3082 * sysdep.c, syssignal.h (croak):
3083 * term.c (maybe_fatal, vfatal):
3084 * textprop.c (text_read_only):
3085 * undo.c (user_error):
3086 * unexmacosx.c (unexec_error):
3087 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3088 Use _Noreturn rather than NO_RETURN.
3089 No need for separate decl merely because of _Noreturn.
3090 * sound.c (sound_warning, parse_sound):
3091 Remove unnecessary forward decls.
3092
f1dd8073
PE
30932012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3094
3095 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3096 * lisp.h (WAIT_READING_MAX): New macro.
3097 * dispnew.c (Fsleep_for, sit_for):
3098 * keyboard.c (kbd_buffer_get_event):
3099 * process.c (Faccept_process_output):
3100 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3101 This improves on the previous patch, which introduced a bug
3102 when time_t is unsigned and as wide as intmax_t.
3103 See <http://bugs.gnu.org/9000#51>.
3104
b82c1755
EZ
31052012-06-23 Eli Zaretskii <eliz@gnu.org>
3106
3107 * dispnew.c (sit_for, Fsleep_for):
3108 * keyboard.c (kbd_buffer_get_event):
3109 * process.c (Faccept_process_output): Avoid compiler warnings when
3110 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3111
ca300656
JB
31122012-06-23 Juanma Barranquero <lekktu@gmail.com>
3113
049ec95b
JB
3114 * makefile.w32-in: Update dependencies.
3115
ca300656
JB
3116 * w32.c (ltime): Add return type and declare static.
3117 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3118
db7b8d06
PE
31192012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3120
3121 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3122 Privately reported by Herbert J. Skuhra.
3123 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3124 All uses changed.
3125 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3126 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3127
0bd8297f
EZ
31282012-06-23 Eli Zaretskii <eliz@gnu.org>
3129
96512555
EZ
3130 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3131 last argument of make_unibyte_string.
3132
0bd8297f
EZ
3133 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3134 language ID in the event parameters.
3135
3136 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3137 event.code, not the obscure "character set ID".
3138
63def6b6
CY
31392012-06-23 Chong Yidong <cyd@gnu.org>
3140
3141 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3142
e8a02204
EZ
31432012-06-23 Eli Zaretskii <eliz@gnu.org>
3144
388cdec0
EZ
3145 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3146 * w32.c (fdutimens): New function.
3147
3148 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3149
3150 * s/ms-w32.h (pselect): Redirect to sys_select.
3151
3152 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3153
e8a02204
EZ
3154 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3155 in the logic of incrementing and decrementing the value of
3156 use_relocatable_buffers.
3157
d054f3fb
PE
31582012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3159
3160 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3161 Privately reported by Herbert J. Skuhra.
3162 [__FreeBSD__]: Remove "*/" typo after "#include".
3163 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3164 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3165 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3166 Don't assume EMACS_TIME and struct timeval are the same type.
3167
d35af63c
PE
31682012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3169
3170 Support higher-resolution time stamps (Bug#9000).
3171 The time stamps are only nanosecond-resolution at the C level,
3172 since that's the best that any real-world system supports now.
3173 But they are picosecond-resolution at the Lisp level, as that's
3174 easy, and leaves room for future OS improvements.
3175
3176 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3177 (LIBES): Use it.
3178
3179 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3180 Don't get current time unless it's needed.
3181
3182 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3183 now provides it if it's absent.
3184 (start_atimer): Port to higher-res time stamps.
3185 Check for time stamp overflow. Don't get current time more
3186 often than is needed.
3187
3188 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3189 Include systime.h, not time.h.
3190 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3191
3192 * dired.c: Include stat-time.h.
3193 (Ffile-attributes): File times now have higher resolution.
3194
3195 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3196 (struct image): Timestamp now has higher resolution.
3197
3198 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3199 has at least microseconds now. All uses removed.
3200 (update_frame, update_single_window, update_window, update_frame_1)
3201 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3202
3203 * editfns.c (time_overflow): Now extern.
3204 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3205 (float-time, Fformat_time_string, Fcurrent_time_string)
3206 (Fcurrent_time_zone): Accept and generate higher-resolution
3207 time stamps.
3208 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3209 (decode_time_components, lisp_seconds_argument): New functions.
3210 (make_time): Now static.
3211 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3212 Report an error if the time is invalid, rather than having the caller
3213 do that.
3214
3215 * fileio.c: Include <stat-time.h>
3216 (Fcopy_file): Copy higher-resolution time stamps.
3217 Prefer to set the time stamp via a file descriptor if that works.
3218 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3219 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3220 (Fvisited_file_modtime, Fset_visited_file_modtime):
3221 Support higher-resolution time stamps.
3222
3223 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3224
3225 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3226
3227 * image.c (prepare_image_for_display, clear_image_cache)
3228 (lookup_image): Port to higer-resolution time stamps.
3229
3230 * keyboard.c (start_polling, bind_polling_period):
3231 Check for time stamp overflow.
3232 (read_char, kbd_buffer_get_event, timer_start_idle)
3233 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3234 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3235 Port to higher-resolution time stamps. Do not assume time_t is signed.
3236 (decode_timer): New function. Timers are now vectors of length 9,
3237 not 8, to accommodate the picosecond component.
3238 (timer_check_2): Use it.
3239
3240 * nsterm.m (select_timeout, timeval_subtract): Remove.
3241 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3242 as they're a bit more accurate and handle overflow better.
3243 (ns_select): Change prototype to be compatible with pselect.
3244 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3245 * nsterm.h (ns_select): Adjust prototype.
3246
3247 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3248 us-resolution time stamps.
3249 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3250
3251 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3252
3253 * lisp.h (time_overflow): New decl.
3254 (wait_reading_process_output): First arg is now intmax_t, not int,
3255 to accommodate larger waits.
3256
3257 * process.h (struct Lisp_Process.read_output_delay):
3258 Now counts nanoseconds, not microseconds.
3259 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3260 EMACS_HAS_USECS.
3261 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3262 (wait_reading_process_output):
3263 Port to ns-resolution time stamps.
3264 (Faccept_process_output, wait_reading_process_output):
3265 Check for time stamp overflow. Do not assume time_t is signed.
3266 (select_wrapper): Remove; we now use pselect.
3267 (Fprocess_attributes): Now generates ns-resolution time stamps.
3268
3269 * sysdep.c: Include utimens.h. Don't include utime.h
3270 or worry about struct utimbuf; gnulib does that for us now.
3271 (gettimeofday): Remove; gnulib provides a substitute.
3272 (make_timeval): New function.
3273 (set_file_times): Now sets ns-resolution time stamps.
3274 New arg FD; all uses changed.
3275 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3276 (system_process_attributes):
3277 Now returns ns-resolution time stamp. All uses changed.
3278 Check for time stamp overflow.
3279
3280 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3281 provides a substitute now.
3282
3283 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3284 since it guarantees struct timespec.
3285 (EMACS_TIME): Now struct timespec, so that we can support
3286 ns-resolution time stamps.
3287 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3288 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3289 (EMACS_USECS): Remove.
3290 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3291 so multiply the arg by 1000 before storing it.
3292 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3293 New macros.
3294 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3295 Port to ns-resolution time stamps.
3296 (EMACS_TIME_NEG_P): Remove; replaced by....
3297 (EMACS_TIME_SIGN): New macro.
3298 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3299 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3300 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3301 (make_timeval, make_lisp_time, decode_time_components): New decls.
3302 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3303 that it mishandled time_t overflow. You can't compare by subtracting!
3304 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3305 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3306
3307 * term.c: Include <sys/time.h>.
3308 (timeval_to_Time): New function, for proper overflow wraparound.
3309 (term_mouse_position, term_mouse_click): Use it.
3310
3311 * undo.c (record_first_change): Support higher-resolution time stamps
3312 in the undo buffer.
3313 (Fprimitive_undo): Use them when restoring time stamps.
3314
3315 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3316 (w32_get_internal_run_time):
3317 Port to higher-resolution Emacs time stamps.
3318 (ltime): Now accepts single 64-bit integer, as that's more convenient
3319 for callers.
3320
3321 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3322
3323 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3324 for compatibility with pselect. Support ns-resolution time stamps.
3325
3326 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3327
3328 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3329 Check for time stamp overflow, and support ns-resolution time stamps.
3330
3331 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3332 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3333 (timeval_subtract): Remove; no longer needed.
3334 (XTflash, XTring_bell, x_wait_for_event):
3335 Port to ns-resolution time stamps. Don't assume time_t is signed.
3336
b6a92dfe
CY
33372012-06-22 Chong Yidong <cyd@gnu.org>
3338
3339 * xdisp.c (x_consider_frame_title): Revert last change.
3340
d251c37c
EZ
33412012-06-22 Eli Zaretskii <eliz@gnu.org>
3342
3343 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3344 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3345 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3346 staticidx goes up to 1597 out of 1600 = 0x640.)
3347
f10deafb
PE
33482012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3349
3350 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3351 Otherwise, the umask might be mistakenly 0 while handling input signals.
3352
ec6de1e2
SM
33532012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3354
3355 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3356
28be1ada
DA
33572012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3358
3359 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3360 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3361 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3362 access to `contents' member of Lisp_Vector objects with AREF and ASET
3363 where appropriate.
3364
c6bf3022
CY
33652012-06-19 Chong Yidong <cyd@gnu.org>
3366
3367 * frame.c (delete_frame): When selecting a frame on a different
3368 text terminal, do not alter the terminal's top-frame.
3369
3370 * xdisp.c (format_mode_line_unwind_data): Record the target
3371 frame's selected window and its terminal's top-frame.
3372 (unwind_format_mode_line): Restore them.
3373 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3374 Callers changed.
3375 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3376 since tty frames can be explicitly named.
3377 (prepare_menu_bars): Likewise.
3378
3379 * term.c (Ftty_top_frame): New function.
3380
defd4196
PE
33812012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3382
3383 Port byte-code-meter to modern targets.
3384 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3385 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3386 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3387 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3388 (METER_1, METER_2): Simplify.
3389
1053a871
SM
33902012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3391
3392 * data.c (Fdefalias): Return `symbol' (bug#11686).
3393
b7e8d081
MR
33942012-06-18 Martin Rudalics <rudalics@gmx.at>
3395
3396 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3397 gets killed during executing of this function (Bug#11665).
3398 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3399 (Vkill_buffer_query_functions): In doc-string say that functions
3400 run by this hook should not change the current buffer.
3401
7ea2b339
PE
34022012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3403
3404 Fix recently-introduced process.c problems found by static checking.
3405 * process.c (write_queue_push, write_queue_pop, send_process):
3406 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3407 (write_queue_pop): Fix pointer signedness problem.
3408 (send_process): Remove unused local.
3409
96a313a1
CY
34102012-06-17 Chong Yidong <cyd@gnu.org>
3411
3412 * xdisp.c (redisplay_internal): No need to redisplay terminal
3413 frames that are not on top.
3414
20ca2e94
TN
34152012-06-17 Troels Nielsen <bn.troels@gmail.com>
3416
3417 * process.c (make_process): Initialize write_queue.
3418 (write_queue_push, write_queue_pop): New functions.
3419 (send_process): Use them to maintain correct ordering of process
3420 writes (Bug#10815).
3421
9a900ca9
PE
34222012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3423
310fbfa8
PE
3424 * lisp.h (eassert): Assume C89 or later.
3425 This removes the need for CHECK.
3426 (CHECK): Remove. Its comments about always evaluating its
3427 argument were confusing, as 'eassert' typically does not evaluate
3428 its argument.
3429
27bb1ca4
PE
3430 * coding.c (produce_chars): Use ptrdiff_t, not int.
3431
9a900ca9
PE
3432 * xterm.c (x_draw_underwave): Check for integer overflow.
3433 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3434
41b7f8bc 34352012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3436
3437 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3438 referenced (Bug#11583).
3439
9b0e3eba
AA
34402012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3441
3442 Implement wave-style variant of underlining.
3443 * dispextern.h (face_underline_type): New enum.
3444 (face): Add field for underline type.
3445 * nsterm.m (ns_draw_underwave): New function.
3446 (ns_draw_text_decoration): Use it.
3447 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3448 New functions.
3449 (x_draw_glyph_string): Use them.
3450 * xfaces.c (Qline, Qwave): New Lisp objects.
3451 (check_lface_attrs, merge_face_ref)
1053a871
SM
3452 (Finternal_set_lisp_face_attribute, realize_x_face):
3453 Handle wave-style underline face attributes.
9b0e3eba
AA
3454 * xterm.c (x_draw_underwave): New function.
3455 (x_draw_glyph_string): Use it.
3456
0fb52f11
JB
34572012-06-16 Juanma Barranquero <lekktu@gmail.com>
3458
3459 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3460 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3461 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3462 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3463 ($(BLD)/w32select.$(O)): Update dependencies.
3464
e5560ff7
AS
34652012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3466
3467 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3468 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3469 * character.c (_fetch_multibyte_char_p): Remove.
3470 * alloc.c: Include "character.h" before "buffer.h".
3471 * bidi.c: Likewise.
3472 * buffer.c: Likewise.
3473 * bytecode.c: Likewise.
3474 * callint.c: Likewise.
3475 * callproc.c: Likewise.
3476 * casefiddle.c: Likewise.
3477 * casetab.c: Likewise.
3478 * category.c: Likewise.
3479 * cmds.c: Likewise.
3480 * coding.c: Likewise.
3481 * composite.c: Likewise.
3482 * dired.c: Likewise.
3483 * dispnew.c: Likewise.
3484 * doc.c: Likewise.
3485 * dosfns.c: Likewise.
3486 * editfns.c: Likewise.
3487 * emacs.c: Likewise.
3488 * fileio.c: Likewise.
3489 * filelock.c: Likewise.
3490 * font.c: Likewise.
3491 * fontset.c: Likewise.
3492 * fringe.c: Likewise.
3493 * indent.c: Likewise.
3494 * insdel.c: Likewise.
3495 * intervals.c: Likewise.
3496 * keyboard.c: Likewise.
3497 * keymap.c: Likewise.
3498 * lread.c: Likewise.
3499 * macros.c: Likewise.
3500 * marker.c: Likewise.
3501 * minibuf.c: Likewise.
3502 * nsfns.m: Likewise.
3503 * nsmenu.m: Likewise.
3504 * print.c: Likewise.
3505 * process.c: Likewise.
3506 * regex.c: Likewise.
3507 * region-cache.c: Likewise.
3508 * search.c: Likewise.
3509 * syntax.c: Likewise.
3510 * term.c: Likewise.
3511 * textprop.c: Likewise.
3512 * undo.c: Likewise.
3513 * unexsol.c: Likewise.
3514 * w16select.c: Likewise.
3515 * w32fns.c: Likewise.
3516 * w32menu.c: Likewise.
3517 * window.c: Likewise.
3518 * xdisp.c: Likewise.
3519 * xfns.c: Likewise.
3520 * xmenu.c: Likewise.
3521 * xml.c: Likewise.
3522 * xselect.c: Likewise.
3523
2f07e6af
EZ
35242012-06-16 Eli Zaretskii <eliz@gnu.org>
3525
1053a871
SM
3526 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3527 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3528 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3529 row.
3530 (handle_face_prop): Use chunk-relative overlay string index when
3531 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3532 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3533 the rightmost. (Bug#11720)
2f07e6af 3534
29b83cec
AS
35352012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3536
3537 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3538 (CATEGORY_MEMBER): Enforce 1/0 value.
3539 * category.c (_temp_category_set): Remove.
3540
4c5501e9
EZ
35412012-06-16 Eli Zaretskii <eliz@gnu.org>
3542
3543 * window.c (Fdelete_other_windows_internal)
3544 (Fdelete_window_internal): Don't access frame's mouse highlight
3545 info of the initial frame. (Bug#11677)
3546
2b570124
PE
35472012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3548
e93864f9
PE
3549 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3550 Assume USE_2_TAGS_FOR_INTS.
3551 (xreload): Adjust $tagmask width to match recent lisp.h change.
3552
2b570124
PE
3553 Simplify lisp.h in minor ways that should not affect code.
3554 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3555 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3556 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3557 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3558 (INTTYPEBITS): New macro, for clarity.
3559 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3560 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3561 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3562 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3563 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3564
81755f69
JB
35652012-06-13 Juanma Barranquero <lekktu@gmail.com>
3566
3567 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3568
16192a57
GM
35692012-06-13 Glenn Morris <rgm@gnu.org>
3570
3571 * s/bsd-common.h (BSD4_3):
3572 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3573
646b5f55
AS
35742012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3575
3576 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3577 instead of union.
3578 (XLI, XIL): Define.
1053a871
SM
3579 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3580 Use them.
3581 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3582 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3583 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3584 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3585 * frame.c (delete_frame): Remove outdated comment.
3586 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3587 USE_LISP_UNION_TYPE.
3588 (Fw32_unregister_hot_key): Likewise.
3589 (Fw32_toggle_lock_key): Likewise.
3590 * w32menu.c (add_menu_item): Likewise.
3591 (w32_menu_display_help): Use XIL instead of checking
3592 USE_LISP_UNION_TYPE.
3593 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3594 (init_heap): Likewise.
3595 * w32term.c (w32_read_socket): Update comment.
3596
1d3823c9
GM
35972012-06-13 Glenn Morris <rgm@gnu.org>
3598
c62ff706
GM
3599 * s/usg5-4-common.h, src/s/unixware.h:
3600 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3601
1d3823c9
GM
3602 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3603
bfe3e0a2
PE
36042012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3605
3606 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3607 * alloc.c (make_number) [!defined make_number]:
3608 Remove, as lisp.h always defines this now.
3609 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3610 (roundup_size): Verify that it is a power of 2.
3611 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3612 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3613 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3614 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3615 USE_LSB_TAG now is always defined to be either 0 or 1.
3616 All uses changed.
3617 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3618 code works fine either way, and efficiency is not a concern here,
3619 as the union type is for debugging, not for production.
3620 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3621 Use an inline function on all platforms when using the union type,
3622 since this is simpler and 'static inline' can be used portably
3623 within Emacs now.
3624 (LISP_INITIALLY_ZERO): New macro.
3625 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3626 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3627
45fa9c0f
GM
36282012-06-12 Glenn Morris <rgm@gnu.org>
3629
b4492cba
GM
3630 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3631
3632 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3633
45fa9c0f
GM
3634 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3635 Move BROKEN_SIGIO to configure.
3636
3637 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3638 Move NO_TERMIO to configure.
3639
0e25d334
CY
36402012-06-12 Chong Yidong <cyd@gnu.org>
3641
3642 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3643 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3644 MagickExportImagePixels is undefined.
3645
43682bb6
PE
36462012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3647
3648 * image.c (imagemagick_load_image): Remove unused label.
3649
a9be7d2b
GM
36502012-06-11 Glenn Morris <rgm@gnu.org>
3651
3652 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3653 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3654 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3655 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3656
3017f87f
SM
36572012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3658
3659 * alloc.c (make_byte_code): New function.
3660 (Fmake_byte_code): Use it. Don't purify here.
3661 * lread.c (read1): Use it as well to avoid extra allocation.
3662
1b9b4cf4
CY
36632012-06-11 Chong Yidong <cyd@gnu.org>
3664
3665 * image.c (imagemagick_load_image): Implement transparency.
3666
95988fcf
AS
36672012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3668
3669 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3670 account for preceding backslashes. (Bug#11663)
3671
cd4eb164
CY
36722012-06-09 Chong Yidong <cyd@gnu.org>
3673
3674 * term.c: Support italics in capable terminals (Bug#9652).
3675 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3676 (turn_on_face): Output using TS_enter_italic_mode if available.
3677 Don't handle unused blinking and alt-charset cases.
3678 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3679 and tty_alt_charset_p cases.
3680 (tty_capable_p, init_tty): Support italics.
3681
3682 * termchar.h (struct tty_display_info): Add field for italics.
3683 Remove unused blink field.
3684
3685 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3686 Handle slant.
3687
3688 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3689 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3690 tty_alt_charset_p. Add tty_italic_p.
3691
ff88beb8
MA
36922012-06-09 Michael Albinus <michael.albinus@gmx.de>
3693
3694 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3695 dbus_type_is_basic if available.
3696 (xd_extract_signed, xd_extract_unsigned): Rename from
3697 extract_signed and extract_unsigned, respectively. Adapt callers.
3698
44286096
CY
36992012-06-09 Chong Yidong <cyd@gnu.org>
3700
1682701f
CY
3701 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3702
44286096
CY
3703 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3704 case (Bug#9752).
3705
d86feb17
PE
37062012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3707
3708 * xdisp.c (vmessage): Treat frame message as multibyte.
3709 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3710 would generate the diagnostic "Making \302\247 buffer-local while
3711 let-bound!".
3712
d5c20fe8
EZ
37132012-06-08 Eli Zaretskii <eliz@gnu.org>
3714
3715 * dispnew.c (showing_window_margins_p): Undo last change, which
3716 was done due to an inadvertent commit.
3717 (adjust_frame_glyphs_for_frame_redisplay): Do call
3718 showing_window_margins_p.
3719
513749ee
SM
37202012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3721
3722 * eval.c (Fmake_var_non_special): New primitive.
3723 (syms_of_eval): Defsubr it.
3724 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3725
d4a8f5c1
JB
37262012-06-08 Juanma Barranquero <lekktu@gmail.com>
3727
3728 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3729 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3730
8bbbc977
EZ
37312012-06-08 Eli Zaretskii <eliz@gnu.org>
3732
3733 * alloc.c (allocate_vectorlike): Fix last change.
3734
f3372c87
DA
37352012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3736
3737 Block-based vector allocation of small vectors.
3738 * lisp.h (struct vectorlike_header): New field `nbytes',
3739 adjust comment accordingly.
3740 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3741 to denote vector blocks. Adjust users (live_vector_p,
3742 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3743 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3744 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3745 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3746 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3747 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3748 (roundup_size): New constant.
3749 (struct vector_block): New data type.
3750 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3751 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3752 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3753 (sweep_vectors): New functions.
3754 (allocate_vectorlike): Return `zero_vector' as the only vector of
3755 0 items. Allocate new vector from block if vector size is less than
3756 or equal to VBLOCK_BYTES_MAX.
3757 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3758 (init_alloc_once): Add call to init_vectors.
3759
4f18a4ed
SM
37602012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3761
3762 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3763
86f158bc
PE
37642012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3765
3766 * doprnt.c (doprnt): Truncate multibyte char correctly.
3767 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3768 would mishandle a string argument "Xc" if X was a multibyte
3769 character of length 2: it would truncate after X's first byte
3770 rather than including all of X.
3771
c5cfcbe0
CY
37722012-06-06 Chong Yidong <cyd@gnu.org>
3773
3774 * buffer.c (word_wrap): Doc fix.
3775
c05cf390
PE
37762012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3777
3778 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3779
0c3461de
GM
37802012-06-03 Glenn Morris <rgm@gnu.org>
3781
3782 * xdisp.c (tool-bar-style): Doc fix.
3783
c71232db
UM
37842012-06-03 Ulrich Müller <ulm@gentoo.org>
3785
3786 * Makefile.in (PAXCTL): Define.
3787 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3788 binary via PaX flags if the paxctl utility is available.
3789 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3790 Restore PaX flags to their default. (Bug#11398)
3791
383f7350
CY
37922012-06-03 Chong Yidong <cyd@gnu.org>
3793
3794 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3795 buffer (Bug#11226).
3796
5f2c76c6
CY
37972012-06-03 Chong Yidong <cyd@gnu.org>
3798
3799 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3800 (note_mode_line_or_margin_highlight): If there is no help echo,
3801 use mode-line-default-help-echo. Handle the case where the mouse
3802 position is past the end of the mode line string.
3803
3804 * buffer.c (buffer_local_value_1): New function, split from
3805 Fbuffer_local_value; can return Qunbound.
3806 (Fbuffer_local_value): Use it.
3807 (Vmode_line_format): Docstring tweaks.
3808
773d47f6
PE
38092012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3810
3811 * sysdep.c (system_process_attributes): Improve comment.
3812
f2d6a3df
SM
38132012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3814
3815 * keyboard.c: Export real-this-command to Elisp.
3816 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3817 and DEFVAR it. Update all users.
3818
63810350
PE
38192012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3820
7bd5c1f4
PE
3821 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3822
63810350
PE
3823 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3824 Convert pctcpu and pctmem to Lisp float properly.
3825 Let the compiler fold better, as 100.0/0x8000 is exact.
3826
a2821611
AS
38272012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3828
3829 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3830 cons_block.
3831
5fceba1d
PE
38322012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3833
3834 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3835
c98ff5dd
DA
38362012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3837
3838 For a 'struct window', replace some Lisp_Object fields to
3839 bitfields where appropriate, remove unused fields.
3840 * window.h (struct window): Remove unused 'last_mark_x' and
3841 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3842 change it's type from Lisp_Object to bitfield.
3843 Change type of 'force_start', 'optional_new_start',
3844 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3845 fields from Lisp_Object to bitfield. Adjust users accordingly.
3846
ca34e0be
PE
38472012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3848
3849 Pacify gcc -Wdouble-precision when using Xaw.
3850 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3851 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3852 Use 'float' consistently, rather than 'float' in most places
3853 and 'double' in a couple of places.
3854
efc00ab1 38552012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3856
3857 * xdisp.c (handle_stop): Detect whether we have overlay strings
3858 loaded by testing it->current.overlay_string_index to be
3859 non-negative, instead of checking whether n_overlay_strings is
3860 positive. (Bug#11587)
3861
efc00ab1 38622012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3863
3864 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3865
3866 * doc.c (Fsubstitute_command_keys): Doc fix.
3867
efc00ab1 38682012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3869
3870 * search.c (search_buffer): Remove calls to
3871 r_alloc_inhibit_buffer_relocation, as it is now called by
3872 maybe_unify_char, which was the cause of relocation of buffer text
3873 in bug#11519.
3874
efc00ab1 38752012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3876
3877 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3878 for the duration of call to load_charset, to avoid problems with
3879 callers of maybe_unify_char that access buffer text through C
3880 pointers.
3881
3882 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3883 decrement the inhibition flag, instead of just setting or
3884 resetting it.
3885
ba93a187
PE
38862012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3887
3888 Remove obsolete '#define static' cruft.
3889 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3890 This #undef was "temporary" in 2000; it is no longer needed
3891 now that '#define static' has gone away.
3892 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3893 (gray_bitmap_bits): Remove; no longer needed.
3894 All uses replaced with definiens.
3895 * xterm.c: Include "bitmaps/gray.xbm".
3896
9e4bf381
PE
38972012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3898
3899 Clean up __executable_start, monstartup when --enable-profiling.
3900 The following changes affect the code only when profiling.
3901 * dispnew.c (__executable_start): Rename from safe_bcopy.
3902 Define only on platforms that need it.
3903 * emacs.c: Include <sys/gmon.h> when profiling.
3904 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3905 (__executable_start): Remove decl, since lisp.h does it now.
3906 (safe_bcopy): Remove decl; no longer has that name.
3907 (main): Coalesce #if into single bit of code, for simplicity.
3908 Cast pointers to uintptr_t, since standard libraries want integers
3909 and not pointers.
3910 * lisp.h (__executable_start): New decl.
3911
32d72c2f
GM
39122012-05-31 Glenn Morris <rgm@gnu.org>
3913
3914 * image.c (Fimagemagick_types): Doc fix.
3915
baac5bc7
JM
39162012-05-30 Jim Meyering <meyering@redhat.com>
3917
3918 * callproc.c (Fcall_process_region): Include directory component
3919 in mkstemp error message (Bug#11586).
3920
72cb32cf
PE
39212012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3922
3923 * alloc.c, lisp.h (make_pure_vector): Now static.
3924
61b108cc
SM
39252012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3926
3927 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3928 Move to byte-run.el.
3929 (Fautoload): Do the hash-doc more carefully.
3930 * data.c (Fdefalias): Purify definition, except for keymaps.
3931 (Qdefun): Move from eval.c.
3932 * lisp.h (Qdefun): Remove.
3933 * lread.c (read1): Tiny simplification.
3934
471fe23d
TN
39352012-05-29 Troels Nielsen <bn.troels@gmail.com>
3936
934f3f58 3937 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3938 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3939 Bug#9642, but explicitly check that the buffer the overlay would
3940 be moved to is live and rearrange lines to make sure that errors
3941 will not put the overlay in an inconsistent state.
3942 (Fdelete_overlay): Cosmetics.
3943
85d0efd1
EZ
39442012-05-28 Eli Zaretskii <eliz@gnu.org>
3945
3946 * w32term.c (my_bring_window_to_top): New function.
3947 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3948 could be different from the original one.
3949 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3950 (Bug#11513)
3951
3952 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3953 by calling BringWindowToTop.
3954
3955 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3956 (WM_EMACS_END): Increase by one.
3957
da92a98c
PE
39582012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3959
3960 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3961 This avoids undefined behavior that might cause the eassert
3962 to not catch an out-of-range value.
3963
74d1f848
JB
39642012-05-28 Juanma Barranquero <lekktu@gmail.com>
3965
3966 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3967 Update dependencies.
3968
9e1a06fc
EZ
39692012-05-27 Eli Zaretskii <eliz@gnu.org>
3970
3971 * bidi.c (bidi_mirror_char): Fix last change.
3972
f3dd7312
AS
39732012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3974
3975 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3976 when referring to sectname field in printf format.
3977
81899c91
PE
39782012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3979
57b81a9f
PE
3980 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3981 Only r_alloc_inhibit_buffer_relocation needed to be added;
3982 the others were already declared.
3983
81899c91
PE
3984 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3985 before checking whether it's out of range. Put the check inside
3986 eassert. See
3987 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3988
33017faf 39892012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3990
3991 * callproc.c (Fcall_process): Restore a line that was accidentally
3992 commented out in the 2011-02-13 change (bug#11547).
3993
33017faf 39942012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3995
3996 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3997 defined on ralloc.c.
3998
3999 * buffer.c [REL_ALLOC]: Remove prototypes of
4000 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4001 they are now on lisp.h.
4002
4003 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4004
4005 * search.c (search_buffer): Use it to inhibit relocation of buffer
4006 text while re_search_2 is doing its job, because re_search_2 is
4007 passed C pointers to buffer text. (Bug#11519)
4008
23415acf
EZ
4009 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4010 Update value to 24.
4011
44e27368
EZ
4012 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4013 state after an additional call to move_it_in_display_line_to, keep
4014 the values of it->max_ascent and it->max_descent found for the
4015 entire line.
4016 (pos_visible_p): Revert the comparison against bottom_y to what it
4017 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4018 (Bug#11464)
4019
c1892f11
PE
40202012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 Fix coding-related core dumps with gcc -ftrapv.
4023 The code was computing A - B, where A and B are pointers, and B is
4024 random garbage. This can lead to core dumps on platforms that
4025 have special pointer registers, and it also leads to core dumps on
4026 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4027 A - B only when B is initialized properly.
4028 * coding.c (coding_set_source, coding_set_destination): Return void.
4029 (coding_change_source, coding_change_destinations): New functions,
4030 with the old behaviors of coding_set_source and coding_set_destination.
4031 All callers that need an offset changed to use these new functions.
4032
eb7afdad
GM
40332012-05-26 Glenn Morris <rgm@gnu.org>
4034
4035 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4036
f12fdf02
EZ
40372012-05-26 Eli Zaretskii <eliz@gnu.org>
4038
53a63be6 4039 Extend mouse support on W32 text-mode console.
61b108cc
SM
4040 * xdisp.c (draw_row_with_mouse_face):
4041 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4042
eb3f6f01 4043 * w32console.c: Include window.h.
61b108cc
SM
4044 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4045 New functions.
eb3f6f01
EZ
4046 (initialize_w32_display): Initialize mouse-highlight data.
4047
53a63be6
EZ
4048 * w32inevt.c: Include termchar.h and window.h.
4049 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4050 moves, call note_mouse_highlight. If help_echo changed, call
4051 gen_help_event to produce help-echo message in the echo area.
4052 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4053 highlight info.
4054
4cfd81f6
PE
40552012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4056
4057 * lread.c (read1): Simplify slightly to avoid an overflow warning
4058 with GCC 4.7.0 on x86-64.
4059
4446092a
EZ
40602012-05-26 Eli Zaretskii <eliz@gnu.org>
4061
4062 * bidi.c (bidi_mirror_char): Revert last change: an int is
4063 definitely wide enough here.
4064
42b2a986 40652012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4066
42b2a986 4067 Fix integer width and related bugs (Bug#9874).
eb106a49 4068 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4069 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4070 (string_bytes, check_sblock, allocate_string_data):
4071 (compact_small_strings, Fmake_bool_vector, make_string)
4072 (make_unibyte_string, make_multibyte_string)
4073 (make_string_from_bytes, make_specified_string)
4074 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4075 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4076 (mark_vectorlike):
4077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4078 (allocate_pseudovector):
4079 Use int, not EMACS_INT, where int is wide enough.
4080 (inhibit_garbage_collection, Fgarbage_collect):
4081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4082 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4083 int might not be wide enough.
4084 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4085 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4086 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4087 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4088 (bidi_level_of_next_char, bidi_move_to_visually_next):
4089 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4090 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4091 (Fkill_buffer, Fset_buffer_major_mode)
4092 (advance_to_char_boundary, Fbuffer_swap_text)
4093 (Fset_buffer_multibyte, overlays_at, overlays_in)
4094 (overlay_touches_p, struct sortvec, record_overlay_string)
4095 (overlay_strings, recenter_overlay_lists)
4096 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4097 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4098 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4099 (Foverlay_recenter, last_overlay_modification_hooks_used)
4100 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4102 (validate_region): Omit unnecessary test for b <= e,
4103 since that's guaranteed by the previous test.
d311d28c
PE
4104 (adjust_overlays_for_delete): Avoid pos + length overflow.
4105 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4106 (report_overlay_modification):
4107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4108 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4109 Omit pointer cast, which isn't needed anyway, and doesn't work
4110 after the EMACS_INT -> ptrdiff_t change.
02481186 4111 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4112 * buffer.h: Adjust decls to match defn changes elsewhere.
4113 (struct buffer_text, struct buffer):
4114 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4115 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4116 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4117 not int, to avoid needless 32-bit limit on 64-bit hosts.
4118 (exec_byte_code): Use tighter memory-full test, one that checks
4119 for alloca overflow. Don't compute the address of the object just
4120 before an array, as that's not portable. Use EMACS_INT, not
4121 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4122 * callint.c (Fcall_interactively):
4123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4124 * callproc.c (call_process_kill, Fcall_process):
4125 Don't assume pid_t fits into an Emacs fixnum.
4126 (call_process_cleanup, Fcall_process, child_setup):
4127 Don't assume pid_t fits into int.
4128 (call_process_cleanup, Fcall_process, delete_temp_file)
4129 (Fcall_process_region):
4130 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4131 (Fcall_process): Simplify handling of volatile integers.
4132 Use int, not EMACS_INT, where int will do.
4133 * casefiddle.c (casify_object, casify_region, operate_on_word)
4134 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4136 (casify_object): Avoid integer overflow when overallocating buffer.
4137 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4138 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4139 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4140 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4141 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4142 integers are now checked earlier. All uses replaced with XINT.
4143 (ccl_driver):
4144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4145 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4146 (ccl_driver, Fregister_code_conversion_map):
4147 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4148 (resolve_symbol_ccl_program): Check that vector header is in range.
4149 Always copy the vector, so that we can check its contents reliably
4150 now rather than having to recheck each instruction as it's being
4151 executed. Check that vector words fit in 'int'.
4152 (ccl_get_compiled_code, Fregister_ccl_program)
4153 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4154 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4155 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4156 contents are in range.
4157 (Fccl_execute_on_string): Check that status is in range.
4158 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4159 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4160 Accept and return EMACS_INT, not int, because callers can pass values
4161 out of 'int' range.
4162 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4163 (multibyte_chars_in_text, parse_str_as_multibyte)
4164 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4165 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4166 (string_escape_byte8, Fget_byte):
4167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4168 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4169 avoid mishandling large integers.
4170 * character.h: Adjust decls to match defn changes elsewhere.
4171 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4172 (Ffind_charset_region):
4173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4174 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4175 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4176 Don't assume fixnum fits in int.
d311d28c
PE
4177 (load_charset_map_from_vector, Fmap_charset_chars):
4178 Remove now-unnecessary CHECK_NATNUMs.
4179 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4180 Don't rely on undefined behavior with signed left shift overflow.
4181 Don't assume unsigned int fits into fixnum, or that fixnum fits
4182 into unsigned int. Don't require max_code to be a valid fixnum;
4183 that's not true for gb10830 4-byte on a 32-bit host. Allow
4184 invalid_code to be a cons, for the same reason. Require code_offset
4185 to be a character. Avoid int overflow if max_char is close
4186 to INT_MAX.
4187 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4188 this is intended anyway and avoids some undefined behavior.
4189 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4190 INDEX_TO_CODE_POINT, as that's what it expects.
4191 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4192 * charset.h (DECODE_CHAR): Return int, not unsigned;
4193 this is what was intended anyway, and it avoids undefined behavior.
4194 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4195 integer-overflow issues.
4196 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4197 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4198 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4199 * chartab.c (Fmake_char_table, Fset_char_table_range)
4200 (uniprop_get_decoder, uniprop_get_encoder):
4201 Don't assume fixnum fits in int.
4202 * cmds.c (move_point): New function, that does the gist of
4203 Fforward_char and Fbackward_char, but does so while checking
4204 for integer overflow more accurately.
c96e5d6a 4205 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4206 (Fforward_line, Fend_of_line, internal_self_insert)
4207 (internal_self_insert):
4208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4209 Fix a FIXME, by checking for integer overflow when calculating
4210 target_clm and actual_clm.
4211 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4212 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4213 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4214 (coding_alloc_by_making_gap, alloc_destination)
4215 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4216 (encode_coding_utf_16, detect_coding_emacs_mule)
4217 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4218 (detect_coding_iso_2022, decode_coding_iso_2022)
4219 (encode_invocation_designation, encode_designation_at_bol)
4220 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4221 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4222 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4223 (encode_coding_ccl, encode_coding_raw_text)
4224 (detect_coding_charset, decode_coding_charset)
4225 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4226 (produce_composition, produce_charset, produce_annotation)
4227 (decode_coding, handle_composition_annotation)
4228 (handle_charset_annotation, consume_chars, decode_coding_gap)
4229 (decode_coding_object, encode_coding_object, detect_coding_system)
4230 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4231 (code_convert_region, code_convert_string)
8f50130c
PE
4232 (Fdefine_coding_system_internal)
4233 (coding_set_source, coding_set_destination):
d311d28c
PE
4234 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4235 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4236 (Fdefine_coding_system_internal):
4237 Don't assume fixnums fit in int.
4238 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4239 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4240 (Funencodable_char_position, Fcheck_coding_systems_region)
4241 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4242 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4243 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4244 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4245 Don't access memory outside of the args array.
d311d28c 4246 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4247 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4248 result of ENCODE_CHAR.
d311d28c
PE
4249 * coding.h: Adjust decls to match defn changes elsewhere.
4250 (struct coding_system):
4251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4252 * composite.c (get_composition_id, find_composition)
4253 (run_composition_function, update_compositions)
4254 (compose_text, composition_gstring_put_cache)
4255 (composition_gstring_p, composition_gstring_width)
4256 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4257 (composition_compute_stop_pos, composition_reseat_it)
4258 (composition_update_it, struct position_record)
4259 (find_automatic_composition, composition_adjust_point)
4260 (Fcomposition_get_gstring, Ffind_composition_internal):
4261 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4262 (update_compositions):
4263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4264 * composite.h: Adjust decls to match defn changes elsewhere.
4265 (struct composition):
4266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4267 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4268 Do not attempt to compute the address of the object just before a
4269 buffer; this is not portable.
4270 (Faref, Faset):
4271 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4272 (Faset): Use int, not EMACS_INT, where int is wide enough.
4273 (Fstring_to_number): Don't assume fixnums fit in int.
4274 (Frem): Don't assume arg is nonnegative.
4275 * dbusbind.c (xd_append_arg): Check for integers out of range.
4276 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4277 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4278 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4279 (xd_get_connection_references): Return ptrdiff_t, not int.
4280 All uses changed.
4281 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4282 (xd_read_message_1):
4283 Use int, not unsigned, where the dbus API uses int.
4284 (Fdbus_message_internal): Don't overflow mtype.
4285 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4286 * dired.c (directory_files_internal, file_name_completion, scmp)
4287 (file_name_completion_stat):
4288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4289 (file_name_completion): Don't overflow matchcount.
4290 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4291 * dispextern.h: Adjust decls to match defn changes elsewhere.
4292 (struct text_pos, struct glyph, struct bidi_saved_info)
4293 (struct bidi_string_data, struct bidi_it, struct composition_it)
4294 (struct it):
4295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4296 (struct display_pos, struct composition_it, struct it):
4297 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4298 * dispnew.c (increment_matrix_positions)
4299 (increment_row_positions, mode_line_string)
4300 (marginal_area_string):
4301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4302 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4303 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4304 (duration_to_sec_usec): New function, to check for overflow better.
4305 (Fsleep_for, sit_for): Use it.
4306 * doc.c (get_doc_string, store_function_docstring):
4307 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4308 (get_doc_string, Fsnarf_documentation):
4309 Use int, not EMACS_INT, where int is wide enough.
4310 (get_doc_string):
4311 Use SAFE_ALLOCA, not alloca.
4312 Check for overflow when converting EMACS_INT to off_t.
4313 * doprnt.c (doprnt):
4314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4315 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4316 Don't assume uid_t fits into fixnum.
4317 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4318 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4319 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4320 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4321 (general_insert_function)
4322 (Finsert_char, make_buffer_string, make_buffer_string_both)
4323 (update_buffer_properties, Fbuffer_substring)
4324 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4325 (Fsubst_char_in_region, check_translation)
4326 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4327 (transpose_markers, Ftranspose_regions):
4328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4329 (clip_to_bounds): Move to lisp.h as an inline function).
4330 (Fconstrain_to_field): Don't assume integers are nonnegative.
4331 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4332 (Fsubst_char_in_region, Fsave_restriction):
4333 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4334 (Femacs_pid): Don't assume pid_t fits into fixnum.
4335 (lo_time): Use int, not EMACS_INT, when int suffices.
4336 (lisp_time_argument): Check for usec out of range.
4337 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4338 (Fuser_login_name, Fuser_full_name): Signal an error
4339 if a uid argument is out of range, rather than relying on
4340 undefined behavior.
c8d5c857
PE
4341 (Fformat_time_string): Remove now-unnecessary check.
4342 lisp_time_argument checks for out-of-range usec now.
243e0530 4343 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4344 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4345 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4346 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4347 (init_cmdargs, Fdump_emacs):
4348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4349 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4350 the bottom (typically) 32 bits of the fixnum.
4351 * eval.c (specpdl_size, call_debugger):
4352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4353 (when_entered_debugger, Fbacktrace_debug):
4354 Don't assume fixnum can fit in int.
4355 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4356 the object just before a buffer; this is not portable.
4357 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4358 (grow_specpdl, unbind_to):
4359 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4360 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4361 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4362 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4363 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4364 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4366 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4367 (a_write, e_write):
4368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4369 (Fcopy_file, non_regular_nbytes, read_non_regular)
4370 (Finsert_file_contents):
4371 Use int, not EMACS_INT, where int is wide enough.
4372 (READ_BUF_SIZE): Verify that it fits in int.
4373 (Finsert_file_contents): Check that counts are in proper range,
4374 rather than assuming fixnums fit into ptrdiff_t etc.
4375 Don't assume fixnums fit into int.
125b3835 4376 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4377 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4378 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4379 (string_char_to_byte, string_byte_to_char)
4380 (string_make_multibyte, string_to_multibyte)
4381 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4382 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4383 (substring_both, Fdelete, internal_equal, Ffillarray)
4384 (Fclear_string, mapcar1)
4385 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4386 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4387 (larger_vector, make_hash_table, maybe_resize_hash_table)
4388 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4389 (Fmaphash, secure_hash):
4390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4391 (concat): Check for string index and length overflow.
4392 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4393 (Frequire):
4394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4395 (larger_vector): New API (vec, incr_min, size_max) replaces old
4396 one (vec, new_size, init). This catches size overflow.
4397 INIT was removed because it was always Qnil.
4398 All callers changed.
4399 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4400 the upper bound on a hash table index size.
4401 (make_hash_table, maybe_resize_hash_table): Use it.
4402 (secure_hash): Computer start_byte and end_byte only after
4403 they're known to be in ptrdiff_t range.
4404 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4405 (Ffont_get_glyphs, Ffont_at):
4406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4407 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4408 (Flist_fonts, Fopen_font):
4409 Don't assume fixnum can fit in int.
4410 (check_gstring): Don't assume index can fit in int.
4411 (font_match_p): Check that fixnum is a character, not a nonnegative
4412 fixnum, since the later code needs to stuff it into an int.
4413 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4414 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4415 conversion overflow issues.
4416 (Fopen_font): Check for integer out of range.
4417 (Ffont_get_glyphs): Don't assume index can fit in int.
4418 * font.h: Adjust decls to match defn changes elsewhere.
4419 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4420 integer overflow.
4421 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4422 printmax_t, where ptrdiff_t is wide enough.
4423 (Finternal_char_font):
4424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4425 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4426 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4427 (Fset_frame_position, x_set_frame_parameters)
4428 (x_set_line_spacing, x_set_border_width)
4429 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4430 Check that fixnums are in proper range for system types.
4431 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4433 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4434 Use SAFE_ALLOCA_LISP, not alloca.
4435 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4436 intptr_t is wide enough.
4437 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4438 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4439 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4440 Check for fixnum out of range.
4441 * ftfont.c (ftfont_list): Don't assume index fits in int.
4442 Check that fixnums are in proper range for system types.
4443 (ftfont_shape_by_flt):
4444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4445 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4447 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4448 Check that fixnums are in proper range for system types.
4449 * gnutls.h: Adjust decls to match defn changes elsewhere.
4450 * gtkutil.c (xg_dialog_run):
4451 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4452 (update_frame_tool_bar):
4453 Check that fixnums are in proper range for system types.
4454 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4455 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4456 * indent.c (last_known_column, last_known_column_point):
4457 (current_column_bol_cache):
4458 (skip_invisible, current_column, check_display_width):
4459 (check_display_width, scan_for_column, current_column_1)
4460 (Findent_to, Fcurrent_indentation, position_indentation)
4461 (indented_beyond_p, Fmove_to_column, compute_motion):
4462 (Fcompute_motion, Fvertical_motion):
4463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4464 (last_known_column_modified): Use EMACS_INT, not int.
4465 (check_display_width):
4466 (Fcompute_motion):
4467 Check that fixnums and floats are in proper range for system types.
4468 (compute_motion): Don't assume index or fixnum fits in int.
4469 (compute_motion, Fcompute_motion):
4470 Use int, not EMACS_INT, when it is wide enough.
4471 (vmotion): Omit local var start_hpos that is always 0; that way
4472 we don't need to worry about overflow in expressions involving it.
4473 * indent.h: Adjust decls to match defn changes elsewhere.
4474 (struct position):
4475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4476 Use int, not EMACS_INT, where int is wide enough.
4477 Remove unused members ovstring_chars_done and tab_offset;
4478 all uses removed.
4479 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4480 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4481 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4482 (make_gap, copy_text, insert, insert_and_inherit)
4483 (insert_before_markers, insert_before_markers_and_inherit)
4484 (insert_1, count_combining_before, count_combining_after)
4485 (insert_1_both, insert_from_string)
4486 (insert_from_string_before_markers, insert_from_string_1)
4487 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4488 (adjust_after_replace, adjust_after_insert, replace_range)
4489 (replace_range_2, del_range, del_range_1, del_range_byte)
4490 (del_range_both, del_range_2, modify_region)
4491 (prepare_to_modify_buffer, signal_before_change)
4492 (signal_after_change, Fcombine_after_change_execute):
4493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4494 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4495 (balance_an_interval, split_interval_right, split_interval_left)
4496 (find_interval, next_interval, update_interval)
4497 (adjust_intervals_for_insertion, delete_node, delete_interval)
4498 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4499 (static_offset_intervals, offset_intervals)
4500 (merge_interval_right, merge_interval_left, make_new_interval)
4501 (graft_intervals_into_buffer, temp_set_point_both)
4502 (temp_set_point, set_point, adjust_for_invis_intang)
4503 (set_point_both, move_if_not_intangible, get_property_and_range)
4504 (get_local_map, copy_intervals, copy_intervals_to_string)
4505 (compare_string_intervals, set_intervals_multibyte_1):
4506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4507 * intervals.h: Adjust decls to match defn changes elsewhere.
4508 (struct interval):
4509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4510 * keyboard.c (this_command_key_count, this_single_command_key_start)
4511 (before_command_key_count, before_command_echo_length, echo_now)
4512 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4513 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4514 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4515 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4517 (last_non_minibuf_size, last_point_position, echo_truncate)
4518 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4519 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4520 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4521 (stuff_buffered_input):
4522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4523 (last_auto_save, command_loop_1, read_char):
4524 Use EMACS_INT, not int, to avoid integer overflow.
4525 (record_char): Avoid overflow in total_keys computation.
4526 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4527 * keyboard.h: Adjust decls to match defn changes elsewhere.
4528 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4529 (Fkey_description, Fdescribe_vector, Flookup_key):
4530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4531 (click_position): New function, to check that positions are in range.
4532 (Fcurrent_active_maps):
4533 (describe_command):
4534 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4535 (Faccessible_keymaps, Fkey_description):
4536 (preferred_sequence_p):
4537 Don't assume fixnum can fit into int.
4538 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4539 Check for integer overflow in size calculations.
4540 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4541 avoid mishandling large integers.
4542 * lisp.h: Adjust decls to match defn changes elsewhere.
4543 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4544 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4545 (struct Lisp_Marker):
4546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4547 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4548 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4549 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4550 All callers changed.
4551 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4552 Assume the arg has valid form, since it always does.
4553 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4554 unsigned integer system type.
4555 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4556 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4558 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4559 (duration_to_sec_usec): New decl.
4560 * lread.c (read_from_string_index, read_from_string_index_byte)
4561 (read_from_string_limit, readchar, unreadchar, openp)
4562 (read_internal_start, read1, oblookup):
4563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4564 (Fload, readevalloop, Feval_buffer, Feval_region):
4565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4566 (openp): Check for out-of-range argument to 'access'.
4567 (read1): Use int, not EMACS_INT, where int is wide enough.
4568 Don't assume fixnum fits into int.
6efdadfd 4569 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4570 (read_filtered_event): Use duration_to_sec_usec
4571 to do proper overflow checking on durations.
d311d28c
PE
4572 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4573 in size calculation.
4574 (Fexecute_kbd_macro):
4575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4576 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4577 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4578 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4579 (set_marker_both, set_marker_restricted_both, marker_position)
4580 (marker_byte_position, Fbuffer_has_markers_at):
4581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4582 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4583 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4584 It now merely ensures that the menu is large enough, without
4585 necessarily growing it, as this avoids some integer overflow issues.
4586 All callers changed.
4587 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4589 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4590 Use SAFE_ALLOCA_LISP, not alloca.
4591 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4592 to EMACS_INT. Check that fixnums are in proper range for system types.
4593 * minibuf.c (minibuf_prompt_width, string_to_object)
4594 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4595 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4596 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4597 (get_minibuffer, read_minibuf_unwind):
4598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4599 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4600 this simplifies overflow checking. All callers changed.
4601 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4602 (Ftest_completion):
4603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4604 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4605 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4606 Check that fixnums are in proper range for system types.
4607 (Fx_create_frame, Fx_show_tip):
4608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4609 * nsfont.m (ns_findfonts, nsfont_list_family):
4610 Don't assume fixnum fits in long.
4611 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4613 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4614 wide enough.
17fdb222 4615 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4617 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4618 (PRINTDECLARE, PRINTPREPARE):
4619 (strout, print_string):
4620 (print, print_preprocess, print_check_string_charset_prop)
4621 (print_object):
4622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4623 (PRINTDECLARE):
4624 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4626 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4627 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4628 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4629 (print_error_message): Use SAFE_ALLOCA, not alloca.
4630 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4631 (print_depth, new_backquote_output, print_number_index):
4632 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4633 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4634 (Fset_process_window_size, Fformat_network_address)
4635 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4636 (sigchld_handler):
d311d28c 4637 Check that fixnums are in proper range for system types.
d44287d4 4638 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4639 Check for process-ids out of pid_t range rather than relying on
4640 undefined behavior.
e4d81efc 4641 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4642 (Fformat_network_address, read_process_output, send_process)
4643 (Fprocess_send_region, status_notify):
4644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4645 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4646 (wait_reading_process_output, read_process_output, exec_sentinel):
4647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4648 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4649 (Faccept_process_output): Use duration_to_sec_usec to do proper
4650 overflow checking on durations.
dde14581
PE
4651 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4652 Don't assume pid_t fits in int.
02481186
PE
4653 * process.h (struct Lisp_Process): Members tick and update_tick
4654 are now of type EMACS_INT, not int.
b62b53e8
PE
4655 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4656 configured --with-wide-int.
d311d28c
PE
4657 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4658 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4659 * search.c (looking_at_1, string_match_1):
4660 (fast_string_match, fast_c_string_match_ignore_case)
4661 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4662 (scan_newline, find_before_next_newline, search_command)
4663 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4664 (set_search_regs, wordify):
4665 (Freplace_match):
4666 (Fmatch_data):
4667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4668 (string_match_1, search_buffer, set_search_regs):
4669 (Fmatch_data):
4670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4671 (wordify): Check for overflow in size calculation.
4672 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4673 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4674 Check that fixnums are in proper range for system types.
4675 * sound.c (struct sound_device)
4676 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4678 (Fplay_sound_internal):
4679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4680 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4681 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4682 (Fparse_partial_sexp):
4683 Don't assume fixnums can fit in int.
4684 (struct lisp_parse_state, find_start_pos, find_start_value)
4685 (find_start_value_byte, find_start_begv)
4686 (update_syntax_table, char_quoted, dec_bytepos)
4687 (find_defun_start, prev_char_comend_first, back_comment):
4688 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4689 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4691 (Finternal_describe_syntax_value): Check that match_lisp is a
4692 character, not an integer, since the code stuffs it into int.
4693 (scan_words, scan_sexps_forward):
4694 Check that fixnums are in proper range for system types.
4695 (Fforward_word):
4696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4697 (scan_sexps_forward):
4698 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4699 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4700 * syntax.h: Adjust decls to match defn changes elsewhere.
4701 (struct gl_state_s):
4702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4703 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4704 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4705 * sysdep.c (wait_for_termination_1, wait_for_termination)
4706 (interruptible_wait_for_termination, mkdir):
4707 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4708 (emacs_read, emacs_write):
4709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4710 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4711 and double all fit in int.
d311d28c
PE
4712 * term.c (set_tty_color_mode):
4713 Check that fixnums are in proper range for system types.
4714 * termhooks.h (struct input_event):
4715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4716 * textprop.c (validate_interval_range, interval_of)
4717 (Fadd_text_properties, set_text_properties_1)
4718 (Fremove_text_properties, Fremove_list_of_text_properties)
4719 (Ftext_property_any, Ftext_property_not_all)
4720 (copy_text_properties, text_property_list, extend_property_ranges)
4721 (verify_interval_modification):
4722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4723 (Fnext_single_char_property_change)
4724 (Fprevious_single_char_property_change):
4725 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4726 (copy_text_properties):
4727 Check for integer overflow in index calculation.
d311d28c
PE
4728 * undo.c (last_boundary_position, record_point, record_insert)
4729 (record_delete, record_marker_adjustment, record_change)
4730 (record_property_change):
4731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4732 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4734 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4735 (Fx_hide_tip, Fx_file_dialog):
4736 * w32menu.c (set_frame_menubar):
4737 Use ptrdiff_t, not int, for consistency with rest of code.
4738 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4739 (select_window, Fdelete_other_windows_internal)
4740 (window_scroll_pixel_based, window_scroll_line_based)
4741 (Frecenter, Fset_window_configuration):
4742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4743 (Fset_window_hscroll, run_window_configuration_change_hook)
4744 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4745 (Fscroll_other_window, Frecenter):
d311d28c
PE
4746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4747 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4748 Don't assume fixnum fits in int.
4749 (Fset_window_scroll_bars):
4750 Check that fixnums are in proper range for system types.
4751 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4752 (string_pos, c_string_pos, number_of_chars, init_iterator)
4753 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4754 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4755 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4756 (face_before_or_after_it_pos, handle_invisible_prop)
4757 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4758 (display_prop_intangible_p, string_buffer_position_lim)
4759 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4760 (get_overlay_strings_1, get_overlay_strings)
4761 (iterate_out_of_display_property, forward_to_next_line_start)
4762 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4763 (get_next_display_element, set_iterator_to_next)
4764 (get_visually_first_element, compute_stop_pos_backwards)
4765 (handle_stop_backwards, next_element_from_buffer)
4766 (move_it_in_display_line_to, move_it_in_display_line)
4767 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4768 (add_to_log, message_dolog, message_log_check_duplicate)
4769 (message2, message2_nolog, message3, message3_nolog
4770 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4771 (current_message_1, truncate_echo_area, truncate_message_1)
4772 (set_message, set_message_1, store_mode_line_noprop)
4773 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4774 (text_outside_line_unchanged_p, check_point_in_composition)
4775 (reconsider_clip_changes)
4776 (redisplay_internal, set_cursor_from_row, try_scrolling)
4777 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4778 (redisplay_window, find_last_unchanged_at_beg_row)
4779 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4780 (trailing_whitespace_p, find_row_edges, display_line)
4781 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4782 (display_mode_element, store_mode_line_string)
4783 (pint2str, pint2hrstr, decode_mode_spec)
4784 (display_count_lines, display_string, draw_glyphs)
4785 (x_produce_glyphs, x_insert_glyphs)
4786 (rows_from_pos_range, mouse_face_from_buffer_pos)
4787 (fast_find_string_pos, mouse_face_from_string_pos)
4788 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4790 (safe_call, init_from_display_pos, handle_fontified_prop)
4791 (handle_single_display_spec, load_overlay_strings)
4792 (with_echo_area_buffer, setup_echo_area_for_printing)
4793 (display_echo_area, echo_area_display)
4794 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4795 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4796 (redisplay_window, dump_glyph_row, display_mode_line)
4797 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4798 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4800 (handle_single_display_spec, build_desired_tool_bar_string)
4801 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4802 (get_specified_cursor_type):
4803 Check that fixnums are in proper range for system types.
4804 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4805 (Flookup_image_map):
4806 Don't assume fixnums fit in int.
4807 (compare_overlay_entries):
4808 Avoid mishandling comparisons due to subtraction overflow.
4809 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4810 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4811 (handle_tool_bar_click):
4812 Use int, not unsigned, since we prefer signed and the signedness
4813 doesn't matter here.
4814 (get_next_display_element, next_element_from_display_vector):
4815 Use int, not EMACS_INT, when int is wide enough.
4816 (start_hourglass): Use duration_to_sec_usec to do proper
4817 overflow checking on durations.
4818 * xfaces.c (Fbitmap_spec_p):
4819 Check that fixnums are in proper range for system types.
4820 (compare_fonts_by_sort_order):
4821 Avoid mishandling comparisons due to subtraction overflow.
4822 (Fx_family_fonts, realize_basic_faces):
4823 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4824 (Fx_family_fonts):
4825 Don't assume fixnum fits in int.
4826 Use SAFE_ALLOCA_LISP, not alloca.
4827 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4828 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4829 (face_at_buffer_position, face_for_overlay_string)
4830 (face_at_string_position):
4831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4832 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4833 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4834 (Fx_show_tip):
4835 Check that fixnums are in proper range for system types.
4836 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4837 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4839 (Fx_change_window_property): Don't assume fixnums fit in int.
4840 * xfont.c (xfont_chars_supported):
4841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4842 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4843 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4845 * xml.c (parse_region):
4846 * xrdb.c (magic_file_p):
4847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4848 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4849 (x_get_local_selection, x_reply_selection_request)
4850 (x_handle_selection_request, wait_for_property_change):
4851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4852 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4853 short is wide enough.
4854 (x_send_client_event): Don't assume fixnum fits in int.
4855 * xterm.c (x_x_to_emacs_modifiers):
4856 Don't assume EMACS_INT overflows nicely into int.
4857 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4858 may come from Lisp.
4859 (handle_one_xevent): NATNUMP can eval its arg twice.
4860 (x_connection_closed):
4861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4862 * xterm.h: Adjust decls to match defn changes elsewhere.
4863 (struct scroll_bar): Use struct vectorlike_header
4864 rather than rolling our own approximation.
4865 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4866
c6574eb5
GM
48672012-05-25 Glenn Morris <rgm@gnu.org>
4868
4869 * lisp.mk (lisp): Update for more files being compiled now.
4870
e8d32c7e
SM
48712012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4872
48def666
SM
4873 * lread.c: Remove `read_pure' which makes no difference.
4874 (read_pure): Remove var.
4875 (unreadpure): Remove function.
4876 (readevalloop): Don't call read_list with -1 flag.
4877 (read1, read_vector): Don't test read_pure any more.
4878 (read_list): Simplify.
4879
e8d32c7e
SM
4880 * fileio.c, character.h: Minor style tweaks.
4881
4b2addb7
DA
48822012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4883
4884 * window.h (clip_changed): Remove useless declaration.
4885
584461b2
JB
48862012-05-22 Juanma Barranquero <lekktu@gmail.com>
4887
4888 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4889 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4890
34374650
PE
48912012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4892
4893 Remove src/m/*.
4894 This directory predates autoconf and is no longer needed nowadays.
4895 Move its few remaining bits of functionality to where they're needed.
4896 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4897 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4898 * m/template.h: Remove.
4899 * Makefile.in (M_FILE): Remove. All uses removed.
4900 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4901 * lisp.h (USE_LSB_TAG):
4902 * mem-limits.h (EXCEEDS_LISP_PTR):
4903 Use VAL_MAX, not VALBITS, in #if.
4904 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4905 (EMACS_UINT): Define unconditionally now.
4906 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4907 (BITS_PER_EMACS_INT): New constants, replacing
4908 what used to be in config.h, but not useful in #if.
4909 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4910 define them any more.
4911 (VAL_MAX): New macro.
4912 (VALMASK): Use it.
4913 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4914 BITS_PER_EMACS_INT, in #if.
4915 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4916 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4917 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4918 * s/ms-w32.h (DATA_START):
4919 Move here from removed file m/intel386.h.
4920 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4921 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4922
261cb4bb
PE
49232012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4924
4925 Assume C89 or later.
4926 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4927 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4928 (xrealloc):
4929 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4930 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4931 * textprop.c, tparam.c (NULL): Remove.
4932 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4933 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4934 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4935 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4936 * xterm.c (input_signal_count): Assume volatile works.
4937
ff23cd9f
KB
49382012-05-21 Ken Brown <kbrown@cornell.edu>
4939
4940 * xgselect.c (xg_select): Fix first argument in call to 'select'
4941 (bug#11508).
4942
1b170bc6
KB
49432012-05-20 Ken Brown <kbrown@cornell.edu>
4944
4945 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4946 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4947
b2f4d39f
KB
49482012-05-19 Ken Brown <kbrown@cornell.edu>
4949
4950 * xfns.c (x_in_use): Remove `static' qualifier.
4951 * xterm.h (x_in_use): Declare.
4952 * xgselect.c: Include xterm.h.
4953 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4954 and `display_arg' (bug#9754).
4955
003fdae2
PE
49562012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4957
9232a6d9
PE
4958 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4959
003fdae2
PE
4960 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4961 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4962
784b56e2
EZ
49632012-05-18 Eli Zaretskii <eliz@gnu.org>
4964
4965 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4966
4967 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4968 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4969
4970 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4971 reference to image_cache->refcount.
4972 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4973
a0a79cde
JL
49742012-05-17 Juri Linkov <juri@jurta.org>
4975
4976 * search.c (Fword_search_regexp, Fword_search_backward)
4977 (Fword_search_forward, Fword_search_backward_lax)
4978 (Fword_search_forward_lax): Move functions to isearch.el
4979 (bug#10145, bug#11381).
4980
b0572523
PE
49812012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4982
4983 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4984
9660f5fc
SM
49852012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4986
4987 * lread.c (init_obarray): Declare Qt and Qnil as special.
4988
4374de83
GM
49892012-05-14 Glenn Morris <rgm@gnu.org>
4990
4991 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4992 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4993
dc44c39a
PE
49942012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4995
078c97cb
PE
4996 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4997
dc44c39a
PE
4998 * unexaix.c: Port to more-recent AIX compilers.
4999 (report_error, report_error_1, make_hdr, copy_sym)
5000 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5001 Make arguments const char *, not char *, to avoid violations of C
5002 standard and to fix some AIX warnings reported by Gilles Pion.
5003
e18afed7 50042012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5005
5006 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5007 already have overlays loaded.
5008 (handle_single_display_spec): Before returning without displaying
5009 fringe bitmap, synchronize the bidi iterator with the main display
5010 iterator, by calling iterate_out_of_display_property.
5011 (iterate_out_of_display_property): Detect buffer iteration by
5012 testing that it->string is a Lisp string.
5013 (get_next_display_element): When the current object is exhausted,
5014 and there's something on it->stack, call set_iterator_to_next to
5015 proceed with what's on the stack, instead of returning zero.
5016 (set_iterator_to_next): If called at the end of a Lisp string,
5017 proceed to consider_string_end without incrementing string
5018 position. Don't increment display vector index past the end of
5019 the display vector. (Bug#11417)
c8fb9dc6
EZ
5020 (pos_visible_p): Don't report a position visible when move_it_to
5021 stopped at the last line of window, which happens to be scanned
5022 backwards by the bidi iteration. (Bug#11464)
ac268e67 5023
e18afed7 50242012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5025
5026 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5027 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5028 are on a TTY, and thus unable to display on the fringes.
5029 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5030 so we need to signal to the caller that this is a "replacing"
5031 display spec. This fixes display when the spec is invalid or we
5032 are on a TTY.
5033
e18afed7 50342012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5035
5036 * unexaix.c (make_hdr): Fix typo in prototype.
5037 This bug broke the build on AIX. Problem reported by Gilles Pion.
5038
9d0a235a
MA
50392012-05-14 Michael Albinus <michael.albinus@gmx.de>
5040
5041 * keyboard.c (kbd_buffer_get_event): Read special events also in
5042 batch mode. (Bug#11415)
5043
9e6b06ed
GM
50442012-05-12 Glenn Morris <rgm@gnu.org>
5045
5046 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5047
c1a1d7a3
EZ
50482012-05-12 Eli Zaretskii <eliz@gnu.org>
5049
5050 * lisp.mk (lisp): Add newcomment.elc.
5051
3fe7cdc8
GM
50522012-05-12 Glenn Morris <rgm@gnu.org>
5053
5054 * Makefile.in (MKDIR_P): New, set by configure.
5055 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5056
53f7d2c0
PE
50572012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5058
5059 Remove unused function hourglass_started.
5060 * dispextern.h (hourglass_started):
5061 * w32fns.c (hourglass_started):
5062 * xdisp.c (hourglass_started): Remove.
5063
75aafb17
JB
50642012-05-10 Juanma Barranquero <lekktu@gmail.com>
5065
5066 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5067 Update dependencies.
5068
12959e8e
PE
50692012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5070
97107e2e
PE
5071 * xgselect.c (xg_select): Put maxfds+1 into a var.
5072 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5073
12959e8e
PE
5074 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5075
836d29b3
DA
50762012-05-10 Dave Abrahams <dave@boostpro.com>
5077
5078 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5079 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5080
5cb67954
MA
50812012-05-09 Michael Albinus <michael.albinus@gmx.de>
5082
5083 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5084 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5085 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5086 Initialize xd_registered_buses.
5087
3478ec45
PE
50882012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5089
b263a6b0
PE
5090 Untag more efficiently if USE_LSB_TAG.
5091 This is based on a proposal by YAMAMOTO Mitsuharu in
5092 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5093 For an admittedly artificial (nth 8000 longlist) benchmark on
5094 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5095 Emacs's overall text size by 1%.
5096 * lisp.h (XUNTAG): New macro.
5097 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5098 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5099 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5100 * eval.c (Fautoload):
5101 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5102 * frame.h (XFRAME): Use XUNTAG.
5103
3478ec45
PE
5104 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5105 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5106 Remove unportable assumptions about print widths of types like
5107 dbus_uint32_t.
5108 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5109 intptr_t when converting between pointer and integer, to avoid GCC
5110 warnings about wrong width.
5111
666b903b 51122012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5113
5114 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5115 stack for each reader_thread, instead of defaulting to 8MB
5116 determined by the linker. This avoids failures in creating
5117 subprocesses on Windows 7, see the discussion in this thread:
5118 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5119
b120cc17
JC
51202012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5121
5122 Fix up display of the *Minibuf-0* buffer in the mini window.
5123 * keyboard.c (read_char): Don't clear the echo area if there's no
5124 message to clear.
5125 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5126 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5127
9a4b36f8
MA
51282012-05-07 Michael Albinus <michael.albinus@gmx.de>
5129
5130 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5131 batch mode.
5132
e5f9458f
CY
51332012-05-06 Chong Yidong <cyd@gnu.org>
5134
5135 * lisp.mk (lisp): Update.
5136
eceeb5fc 51372012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5138
5139 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5140
71873e2b
SM
51412012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5142
5143 * data.c (PUT_ERROR): New macro.
5144 (syms_of_data): Use it. Add new error type `user-error'.
5145 * undo.c (user_error): New function.
5146 (Fprimitive_undo): Use it.
5147 * print.c (print_error_message): Adjust print style for `user-error'.
5148 * keyboard.c (user_error): New function.
5149 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5150
ab0fa4e4
PE
51512012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5152
5153 Do not limit current-time-string to years 1000..9999.
5154 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5155 (Fcurrent_time_string): Support any year that is supported by the
5156 underlying localtime representation. Don't use asctime, as it
5157 has undefined behavior for years outside the range -999..9999.
5158
7ed806a7
PE
51592012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5160
5161 Fix race conditions involving setenv, gmtime, localtime, asctime.
5162 Without this fix, interrupts could mess up code that uses these
5163 nonreentrant functions, since setting TZ invalidates existing
5164 tm_zone or tzname values, and since most of these functions return
5165 pointers to static storage.
5166 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5167 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5168 Grow the critical sections to include not just invoking
5169 localtime/gmtime, but also accessing these functions' results
5170 including their tm_zone values if any, and any related TZ setting.
5171 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5172 so that the struct tm is saved in the critical section.
5173 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5174 motivated by the fact that memory allocation needs to be outside
5175 the critical section.
5176
0c16dfed
DA
51772012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5178
5179 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5180 with RESET_INTERVAL.
5181
5182 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5183 Remove duplicated buffer name initialization.
5184
3f83ace8
JM
51852012-05-02 Jim Meyering <jim@meyering.net>
5186
5187 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5188
c7b8541e
JM
5189 * xfns.c (x_window): Use xstrdup (Bug#11375).
5190
90207a15 51912012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5192
5193 * xdisp.c (pos_visible_p): If already at a newline from the
5194 display string before the 'while' loop, don't walk back the glyphs
5195 from it3.glyph_row. Solves assertion violation when the display
5196 string begins with a newline (egg.el). (Bug#11367)
5197
b593d6a9
AH
51982012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5199
5200 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5201 Move to simple.el.
5202
4737362e
GM
52032012-05-01 Glenn Morris <rgm@gnu.org>
5204
99cf43f9
GM
5205 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5206 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5207 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5208 All were removed before 23.1.
5209
9311dcff
GM
5210 * dispnew.c: Remove HAVE_LIBNCURSES test;
5211 it is always true on relevant platforms.
5212
4d5c6349
GM
5213 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5214 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5215
4737362e
GM
5216 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5217
74dd3a6b
AS
52182012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5219
5220 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5221 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5222 Remove.
5223
13c379ee
PE
52242012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5225
5226 Do not avoid creating empty evaporating overlays (Bug#9642).
5227 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5228 That is, do not delete an evaporating overlay if it becomes
5229 empty after its bounds are adjusted to fit within its buffer.
5230 This fix caused other problems, and I'm reverting it until we get
5231 to the bottom of them.
5232
a8e7d6d7 52332012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5234
5235 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5236
a8e7d6d7 52372012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5238
5239 * xdisp.c (pos_visible_p): If the window start position is beyond
5240 ZV, start the display from buffer beginning. Prevents assertion
5241 violation in init_iterator when the minibuffer window is scrolled
5242 via the scroll bar.
5243
5244 * window.c (window_scroll_pixel_based): Likewise.
5245
a8e7d6d7 52462012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5247
5248 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5249
a8e7d6d7 52502012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5251
5252 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5253 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5254
a8e7d6d7 52552012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5256
b593d6a9
AH
5257 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5258 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5259
1c6900d9
EZ
52602012-04-26 Eli Zaretskii <eliz@gnu.org>
5261
4c3fa1d9
EZ
5262 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5263 display element, check also the underlying string or buffer
5264 character. (Bug#11341)
5265
1c6900d9
EZ
5266 * w32menu.c: Include w32heap.h.
5267 (add_menu_item): If the call to AppendMenuW (via
5268 unicode_append_menu) fails, disable Unicode menus only if we are
5269 running on Windows 9X/Me.
5270
42bf8205
AS
52712012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5272
5273 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5274 (xgetint): Add missing shift for LSB tags.
5275
b1bac16e
MR
52762012-04-24 Martin Rudalics <rudalics@gmx.at>
5277
5278 * keyboard.c (read_char): Don't wipe echo area for select window
5279 events: These might get delayed via `mouse-autoselect-window'
5280 (Bug#11304).
5281
d69621cc
JB
52822012-04-24 Juanma Barranquero <lekktu@gmail.com>
5283
5284 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5285 manipulation of :loaded-from data.
5286
02fd101b
JB
52872012-04-23 Juanma Barranquero <lekktu@gmail.com>
5288
5289 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5290 now a cons (bug#11311).
5291
888bec30
PE
52922012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5293
89a438bd
PE
5294 Do not create empty overlays with the evaporate property (Bug#9642).
5295 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5296 if it becomes empty after its bounds are adjusted to fit within
5297 its buffer. Without this fix, in a nonempty buffer (let ((o
5298 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5299 yields an empty overlay that has the evaporate property, which is
5300 not supposed to happen.
5301
1068fe4d
PE
5302 Fix minor GTK3 problems found by static checking.
5303 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5304 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5305 (struct _EmacsFixedClass, emacs_fixed_get_type):
5306 Move decls here from emacsgtkfixed.h, since they needn't be public.
5307 (emacs_fixed_get_type): Now static.
5308 (emacs_fixed_class_init): Omit unused local.
5309 (emacs_fixed_child_type): Remove; unused.
5310 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5311 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5312 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5313 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5314 (EMACS_FIXED_GET_CLASS): Remove; unused.
5315 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5316
888bec30
PE
5317 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5318 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5319
de85e130
PE
53202012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5321
d0baac98 5322 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5323 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5324 (__malloc_size_t, __malloc_ptrdiff_t):
5325 Remove. All uses removed, replaced by the definiens if needed,
5326 since we can assume C89 or better now.
5327 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5328 (protect_malloc_state, align, get_contiguous_space)
5329 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5330 (malloc_atfork_handler_child, malloc_enable_thread)
5331 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5332 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5333 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5334 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5335 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5336 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5337 Define using prototypes, not old style.
5338 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5339 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5340 (align): Don't assume that signed integer overflow wraps around.
5341 Omit unused local var.
5342 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5343 (_free_internal_nolock, memalign, mallochook, reallochook):
5344 Omit no-longer-needed casts.
5345 (valloc): Use getpagesize, not __getpagesize.
5346 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5347 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5348
de85e130
PE
5349 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5350
dcbf5805
MA
53512012-04-22 Michael Albinus <michael.albinus@gmx.de>
5352
5353 Move functions from C to Lisp. Make non-blocking method calls
5354 the default. Implement further D-Bus standard interfaces.
5355
5356 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5357 (QCdbus_request_name_allow_replacement)
5358 (QCdbus_request_name_replace_existing)
5359 (QCdbus_request_name_do_not_queue)
5360 (QCdbus_request_name_reply_primary_owner)
5361 (QCdbus_request_name_reply_in_queue)
5362 (QCdbus_request_name_reply_exists)
5363 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5364 (QCdbus_registered_serial, QCdbus_registered_method)
5365 (QCdbus_registered_signal): New Lisp objects.
5366 (XD_DEBUG_MESSAGE): Use sizeof.
5367 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5368 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5369 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5370 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5371 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5372 (xd_signature, xd_append_arg): Allow float for integer types.
5373 (xd_get_connection_references): New function.
b593d6a9
AH
5374 (xd_get_connection_address): Rename from xd_initialize.
5375 Return cached address.
dcbf5805
MA
5376 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5377 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5378 level.
5379 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5380 Return number of refcounts.
dcbf5805
MA
5381 (Fdbus_get_unique_name): Make stronger parameter check.
5382 (Fdbus_message_internal): New defun.
5383 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5384 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5385 (Fdbus_send_signal, Fdbus_register_service)
5386 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5387 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5388 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5389 (Vdbus_compiled_version, Vdbus_runtime_version)
5390 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5391 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5392 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5393 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5394 Adapt docstring.
dcbf5805 5395
52828e02
PE
53962012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5397
da05bc4c
PE
5398 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5399 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5400 Do not assume ptrdiff_t is the same width as 'int'.
5401
52828e02
PE
5402 * alloc.c: Handle unusual debugging option combinations.
5403 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5404 since the two debugging options are incompatible.
5405 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5406 is defined.
5407 (mem_init, mem_insert, mem_insert_fixup):
5408 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5409 (NEED_MEM_INSERT): Remove; no longer needed.
5410
f01769f9
LL
54112012-04-22 Leo Liu <sdl.web@gmail.com>
5412
5413 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5414
5790543d
PE
54152012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5416
5417 * sysdep.c [__FreeBSD__]: Minor cleanups.
5418 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5419 Use Emacs indenting style more consistently. Avoid some casts.
5420 Use 'double' consistently rather than mixing 'float' and 'double'.
5421
b91b7e4d
EW
54222012-04-21 Eduard Wiebe <usenet@pusto.de>
5423
b593d6a9
AH
5424 * sysdep.c (list_system_processes, system_process_attributes):
5425 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5426
6114eb15
AS
54272012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5428
5429 * lisp.mk (lisp): Update.
5430
2f38dff7
PE
54312012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5432
5433 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5434 It is never used otherwise.
5435
4ae29f89
SM
54362012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5437
5438 * print.c (print_preprocess): Only check print_depth if print-circle
5439 is nil.
5440 (print_object): Check for cycles even when print-circle is nil and
5441 print-gensym is t, but only check print_depth if print-circle is nil.
5442
f30d612a
CY
54432012-04-20 Chong Yidong <cyd@gnu.org>
5444
5445 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5446 set the status to "failed" and ensure that sentinel is run.
5447
c07a4c0b 54482012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5449
5450 * process.c (Fset_process_inherit_coding_system_flag)
5451 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5452 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5453
c07a4c0b 54542012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5455
5456 * xdisp.c (string_buffer_position_lim): Limit starting position to
5457 BEGV.
5458 (set_cursor_from_row): If called for a mode-line or header-line
5459 row, return zero immediately.
5460 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5461 farther than the first row after the header line, if any.
5462 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5463 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5464
c07a4c0b 54652012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5466
4ae29f89
SM
5467 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5468 (bug#11238).
ad3a2b41 5469
c07a4c0b 54702012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 54712012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5472
5473 configure: new option --enable-gcc-warnings (Bug#11207)
5474 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5475 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5476 (ALL_CFLAGS): Use new macros rather than old.
5477 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5478 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5479 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5480 -Wunused-result, -Wunused-variable. This should go away once
5481 the Emacs and Gnulib regex code is merged.
5482 (xmalloc, xrealloc): Now static.
5483
aba027e8
PE
54842012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5485
5486 * dired.c (Fsystem_groups): Remove unused local.
5487
e5a36063
GM
54882012-04-17 Glenn Morris <rgm@gnu.org>
5489
5490 * dired.c (Fsystem_users): Doc fix.
5491
316411f0
DA
54922012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5493
5494 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5495 (syms_of_dired): Add them.
5496
9426aba4
PE
54972012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5498
b62a57be
PE
5499 Fix minor alloc.c problems found by static checking.
5500 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5501 New extern decls, to avoid calling undeclared functions.
5502 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5503 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5504 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5505 (NEED_MEM_INSERT): New macro.
5506 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5507 Remove one incorrect comment and fix another.
b62a57be 5508
3539f31f
PE
5509 Fix minor ralloc.c problems found by static checking.
5510 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5511 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5512 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5513 (r_alloc_sbrk): Now static.
5514
a041960a
PE
5515 Improve ralloc.c interface checking.
5516 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5517 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5518 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5519 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5520 [REL_ALLOC]: ... to here, to check interface.
5521 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5522 Remove decls. This fixes an "It stinks!".
5523
9426aba4
PE
5524 * alloc.c (which_symbols): Fix alignment issue / type clash.
5525
d55c12ed
AS
55262012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5527
5528 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5529 (struct Lisp_Misc_Any): Likewise.
5530 (struct Lisp_Free): Likewise.
5531 * alloc.c (union aligned_Lisp_Symbol): Define.
5532 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5533 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5534 (union aligned_Lisp_Misc): Define.
5535 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5536 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5537 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5538
b948ce8b
PE
55392012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5540
5541 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5542 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5543 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5544 * s/netbsd.h, s/sol2-6.h:
5545 Remove definition of GC_MARK_STACK, since the default now works.
5546 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5547 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5548 no longer the default.
5549 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5550
35dc09a1 55512012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5552
35dc09a1
GM
5553 * lread.c (lisp_file_lexically_bound_p):
5554 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5555
35dc09a1
GM
55562012-04-14 Eli Zaretskii <eliz@gnu.org>
5557
5558 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5559 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5560
55612012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5562
5563 * nsterm.m (constrainFrameRect): Always constrain when there is only
5564 one screen (Bug#10962).
5565
bcd86815
KB
55662012-04-13 Ken Brown <kbrown@cornell.edu>
5567
5568 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5569
c25df26e
RT
55702012-04-13 Reuben Thomas <rrt@sc3d.org>
5571
5572 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5573
0fc59f1e
DC
55742012-04-11 Daniel Colascione <dancol@dancol.org>
5575
5576 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5577 against is gone. It's better to use vfork now so that when Cygwin
5578 gains a new, working vfork, we use it automatically (bug#10398).
5579
de8c03dc
SM
55802012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5581
5582 * window.c (save_window_save): Obey window-point-insertion-type.
5583
2f097256
GM
55842012-04-11 Glenn Morris <rgm@gnu.org>
5585
5586 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5587
453b951e
SM
55882012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5589
5590 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5591
75f1671a 55922012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5593
5594 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5595 (force_quit_count): New var.
5596 (handle_interrupt): Use it.
5597
2a8ce227
JB
55982012-04-10 Juanma Barranquero <lekktu@gmail.com>
5599
5600 * w32.c (w32_delayed_load): Record the full path of the library
5601 being loaded (bug#10424).
5602
935396c0
GM
56032012-04-09 Glenn Morris <rgm@gnu.org>
5604
05920a43
GM
5605 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5606 not just in the obarray, before snarfing them. (Bug#11036)
5607
935396c0
GM
5608 * Makefile.in ($(leimdir)/leim-list.el):
5609 Pass EMACS rather than BUILT_EMACS.
5610
a18ecafa
TZ
56112012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5612
5613 * process.c (make_process):
5614 * process.h: Add integer `gnutls_handshakes_tried' member to
5615 process struct.
5616
6bbef4e5
JC
5617 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5618 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5619
5620 * gnutls.c (gnutls_log_function2i): Convenience log function.
5621 (emacs_gnutls_read): Use new log functions,
5622 `gnutls_handshakes_tried' process member, and
5623 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5624 attempts per process (connection).
5625
b4d3bc10
CY
56262012-04-09 Chong Yidong <cyd@gnu.org>
5627
5628 * eval.c (Fuser_variable_p, user_variable_p_eh)
5629 (lisp_indirect_variable): Functions deleted.
5630 (Fdefvar): Caller changed.
5631
5632 * callint.c (Finteractive, Fcall_interactively):
5633 * minibuf.c (Fread_variable): Callers changed.
5634
70f4d973
EZ
56352012-04-09 Eli Zaretskii <eliz@gnu.org>
5636
5637 * xdisp.c (set_cursor_from_row): If the display string appears in
5638 the buffer at position that is closer to point than the position
5639 after the display string, display the cursor on the first glyph of
5640 the display string. Fixes cursor display when a 'display' text
5641 property immediately follows invisible text. (Bug#11094)
5642
cb3c2e3e
PE
56432012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5644
5645 composite.c: use 'double' consistently
5646 * composite.c (get_composition_id): Use 'double' consistently
5647 instead of converting 'float' to 'double' and vice versa; this is
5648 easier to understand and avoids a GCC warning.
5649
fd06db5d
GM
56502012-04-09 Glenn Morris <rgm@gnu.org>
5651
50fe702a
GM
5652 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5653 preparation for dumping it with emacs. (Bug#4789)
5654 (leimdir): New variable.
5655 ($(leimdir)/leim-list.el): New rule.
5656 (emacs$(EXEEXT)): Depend on leim-list.el.
5657
fd06db5d
GM
5658 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5659 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5660 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5661
55c131ee
AS
56622012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5663
5664 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5665 proper alignment.
5666
9209588f
JB
56672012-04-07 Juanma Barranquero <lekktu@gmail.com>
5668
5669 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5670 Remove unused local variable.
5671
e3fb2efb
PE
56722012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5673
5674 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5675 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5676 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5677 objects, as mark_maybe_pointer will catch them otherwise.
5678 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5679 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5680
b5385551
PE
56812012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5682
5683 Fix typo that broke non-Windows builds.
5684 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5685
9078ead6
EZ
56862012-04-07 Eli Zaretskii <eliz@gnu.org>
5687
5688 Support building on MS-Windows with libxml2.
5689
5690 * makefile.w32-in (OBJ2): Add xml.$(O).
5691 (GLOBAL_SOURCES): Add xml.c.
5692 ($(BLD)/xml.$(O)): New dependency list.
5693
5694 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5695 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5696 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5697 [!WINDOWSNT]: New macros.
5698 (init_libxml2_functions, libxml2_loaded_p): New functions.
5699 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5700 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5701 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5702 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5703 linked in).
6bbef4e5
JC
5704 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5705 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5706 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5707
5708 * emacs.c: Don't include libxml/parser.h.
5709 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5710 xmlCleanupParser directly.
5711
5712 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5713
3811fdf3
EZ
57142012-04-07 Eli Zaretskii <eliz@gnu.org>
5715
5716 * indent.c (Fvertical_motion): If there is a display string at
5717 point, use it.vpos to compute how many lines to backtrack after
5718 move_it_to point. (Bug#11133)
5719
2f8e16b2
EZ
57202012-04-06 Eli Zaretskii <eliz@gnu.org>
5721
5722 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5723 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5724 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5725 macros related to unification of CJK characters. For the details,
5726 see the discussion following the message here:
5727 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5728
3d439cd1
CY
57292012-04-04 Chong Yidong <cyd@gnu.org>
5730
5731 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5732
8bc53d00
EZ
57332012-04-01 Eli Zaretskii <eliz@gnu.org>
5734
5735 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5736 instead of alloca. (Bug#11138)
5737
3b0512a3
AS
57382012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5739
5740 * w32menu.c (is_simple_dialog): Properly check lisp types.
5741 (Bug#11141)
5742
8427ddd2
EZ
57432012-03-31 Eli Zaretskii <eliz@gnu.org>
5744
979022ef
EZ
5745 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5746 position we get to after a call to move_it_to fails the
5747 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5748 only if we wind up in a string from display property. (Bug#11063)
5749
a6b1c7cc
EZ
5750 * window.c (Fdelete_other_windows_internal): Invalidate the row
5751 and column information about mouse highlight, so that redisplay
5752 restores it after reallocating the glyph matrices. (Bug#7464)
5753
8427ddd2
EZ
5754 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5755 string comes from a `display' text property, use the buffer
5756 position of that property as if we actually saw that position in
5757 the row's glyphs.
697ba24b
EZ
5758 (move_it_by_lines): Remove the assertion that
5759 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5760 violated when there's a before-string at the beginning of a line.
5761 (Bug#11063)
8427ddd2 5762
65a0a738
EZ
57632012-03-30 Eli Zaretskii <eliz@gnu.org>
5764
5765 * xdisp.c (append_space_for_newline): If the default face was
5766 remapped, use the remapped face for the appended newline.
5767 (extend_face_to_end_of_line): Use the remapped default face for
5768 extending the face to the end of the line.
5769 (display_line): Call extend_face_to_end_of_line when the default
5770 face was remapped. (Bug#11068)
5771
581355cc
EZ
57722012-03-29 Eli Zaretskii <eliz@gnu.org>
5773
5774 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5775
e8fc049f
SM
57762012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5777
5778 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5779
4fb9a543
GM
57802012-03-27 Glenn Morris <rgm@gnu.org>
5781
5782 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5783 Doc fixes.
5784
679910f1
KH
57852012-03-26 Kenichi Handa <handa@m17n.org>
5786
5787 * dispextern.h (struct glyph): Fix previous change. Change the
5788 bit length of glyphless.ch to 25 (Bug#11082).
5789
90d49b7f
CY
57902012-03-26 Chong Yidong <cyd@gnu.org>
5791
5792 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5793 (command_loop_1): Use it; inhibit selection update for
5794 handle-select-window too (Bug#8996).
5795
f514f6f0
FP
57962012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5797
e8fc049f 5798 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5799
bf43fa51
KH
58002012-03-25 Kenichi Handa <handa@m17n.org>
5801
5802 * dispextern.h (struct glyph): Change the bit length of
5803 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5804
8a0c01dd
EZ
58052012-03-24 Eli Zaretskii <eliz@gnu.org>
5806
5807 * s/ms-w32.h (tzname): Include time.h before redirecting to
5808 _tzname. Fixes the MSVC build. (Bug#9960)
5809
7d1c3a76
AS
58102012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5811
8ed79523
AS
5812 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5813 characters.
5814
7d1c3a76
AS
5815 * xterm.c (XTread_socket): Only modify handling_signal if
5816 !SYNC_INPUT. (Bug#11080)
5817
e99a9b8b
EZ
58182012-03-23 Eli Zaretskii <eliz@gnu.org>
5819
5820 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5821 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5822 when fetching a multibyte character consumes more bytes than
5823 CHAR_BYTES returns, due to unification of CJK characters in
5824 string_char. (Bug#11073)
5825
5063c0e1
TN
58262012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5827
5828 * process.c (wait_reading_process_output): Handle pty disconnect
5829 by refraining from sending oneself a SIGCHLD (bug#10933).
5830
9f851fbd
CY
58312012-03-22 Chong Yidong <cyd@gnu.org>
5832
5833 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5834
5063c0e1 5835 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5836 Mark string as coming from a prefix property.
5837 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5838 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5839
fb5b8aca
CY
58402012-03-21 Chong Yidong <cyd@gnu.org>
5841
5842 * xfaces.c (Vface_remapping_alist): Doc fix.
5843
62356a1b
EZ
58442012-03-20 Eli Zaretskii <eliz@gnu.org>
5845
5846 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5847 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5848 Doc fixes.
62356a1b 5849
025de85b
CY
58502012-03-20 Chong Yidong <cyd@gnu.org>
5851
5852 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5853 to reflect default non-nil value of redisplay-dont-pause.
5854
4827f94e
KH
58552012-03-19 Kenichi Handa <handa@m17n.org>
5856
5857 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5858 it fit in a valid range (Bug#11003).
5859
e50a24a2
EZ
58602012-03-18 Eli Zaretskii <eliz@gnu.org>
5861
5862 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5863 that is not from display property, accept the row as a "cursor
5864 row" if one of the string's character has a non-nil `cursor'
5865 property. Fixes cursor positioning when there are newlines in
5866 overlay strings, e.g. in icomplete.el. (Bug#11035)
5867
9af5ed87
PE
58682012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5869
5870 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5871
d1f55f16
CY
58722012-03-12 Chong Yidong <cyd@gnu.org>
5873
5874 * eval.c (inhibit_lisp_code): Rename from
5875 inhibit_window_configuration_change_hook; move from window.c.
5876
5877 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5878 * window.c (run_window_configuration_change_hook)
5879 (syms_of_window): Callers changed.
5880
66c5eebd
CY
58812012-03-11 Chong Yidong <cyd@gnu.org>
5882
413df973
CY
5883 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5884
66c5eebd
CY
5885 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5886
1de11f56
CY
58872012-03-10 Chong Yidong <cyd@gnu.org>
5888
5889 * frame.c (other_visible_frames): Don't assume the selected frame
5890 is visible (Bug#10955).
5891
cae07000
SM
58922012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5893
5894 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5895
89c94350
JD
58962012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5897
5898 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5899 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5900 zero (Bug#10954).
5901
999dd333
GM
59022012-03-03 Glenn Morris <rgm@gnu.org>
5903
01a6dcc8 5904 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5905
de0100f2
EZ
59062012-03-02 Eli Zaretskii <eliz@gnu.org>
5907
5908 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5909 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5910 (redisplay_window, next_element_from_string): Fix typos in
5911 comments.
3e441275
EZ
5912 (redisplay_window): Pass to move_it_vertically the margin in
5913 pixels, not in screen lines.
de0100f2 5914
96a72ee9
GM
59152012-03-02 Glenn Morris <rgm@gnu.org>
5916
5917 * buffer.c (buffer-list-update-hook): Doc fix.
5918
312508d7
EZ
59192012-02-29 Eli Zaretskii <eliz@gnu.org>
5920
5921 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5922 push_it before setting up the iterator for the first overlay
5923 string, even if we have an empty string loaded.
5924 (next_overlay_string): If there's an empty string on the iterator
5925 stack, pop the stack. (Bug#10903)
5926
27f3c637
PE
59272012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5928
5929 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5930 Suggested by Stefan Monnier in
5931 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5932 * alloc.c (widen_to_Lisp_Object): New static function.
5933 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5934 and widening them to Lisp_Objects. This would work even if
5935 USE_LSB_TAG is defined and wide integers are used, which might
5936 happen in a future version of Emacs.
5937
3c9dfce6
CY
59382012-02-25 Chong Yidong <cyd@gnu.org>
5939
fa74b241
CY
5940 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5941 Doc fix.
5942
3c9dfce6
CY
5943 * xselect.c (Fx_selection_exists_p): Doc fix.
5944 (x_clipboard_manager_save_all): Print an informative message
5945 before saving to clipboard manager.
5946
9486df08
CY
59472012-02-24 Chong Yidong <cyd@gnu.org>
5948
5949 * keyboard.c (process_special_events): Handle all X selection
5950 requests in kbd_buffer, not just the next one (Bug#8869).
5951
f01d3321
CY
59522012-02-23 Chong Yidong <cyd@gnu.org>
5953
5954 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5955 call when setting menu-bar-lines and tool-bar-lines parameters.
5956 (unwind_create_frame_1): New helper function.
5957
5958 * window.c (inhibit_window_configuration_change_hook): New var.
5959 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5960 (syms_of_window): Initialize it.
f01d3321 5961
86b847b6
CY
59622012-02-22 Chong Yidong <cyd@gnu.org>
5963
5964 * xterm.c (x_draw_image_relief): Add missing type check for
5965 Vtool_bar_button_margin (Bug#10743).
5966
a59225b1
CY
59672012-02-21 Chong Yidong <cyd@gnu.org>
5968
5969 * fileio.c (Vfile_name_handler_alist): Doc fix.
5970
5971 * buffer.c (Fget_file_buffer): Protect against invalid file
5972 handler return value.
5973
310f5bd4
PE
59742012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5975
cb3a28cc
PE
5976 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5977 when computing $valmask.
5978
310f5bd4
PE
5979 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5980 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5981 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5982 It's useless in that case, and it can cause problems on hosts
5983 that allocate halves of EMACS_INT values separately.
5984 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5985 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5986 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5987 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5988 it avoids undefined behavior on hosts where shifting right by more
5989 than the word width has undefined behavior.
5990
2375c96a
CY
59912012-02-19 Chong Yidong <cyd@gnu.org>
5992
5993 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5994 (Funhandled_file_name_directory, Ffile_name_as_directory)
5995 (Fdirectory_file_name, Fexpand_file_name)
5996 (Fsubstitute_in_file_name): Protect against invalid file handler
5997 return values (Bug#10845).
5998
3eb49e71
EZ
59992012-02-18 Eli Zaretskii <eliz@gnu.org>
6000
6001 * .gdbinit (pitx): Fix incorrect references to fields of the
6002 iterator stack.
6003
7b926f3f
CY
60042012-02-17 Chong Yidong <cyd@gnu.org>
6005
6006 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6007
11273115
PE
60082012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6009
6010 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6011 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6012
c3a70e2b
CY
60132012-02-15 Chong Yidong <cyd@gnu.org>
6014
6015 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6016 marked as special. Also, starting docstrings with * is obsolete.
6017
0ca43699
AS
60182012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6019
6020 * gnutls.c (emacs_gnutls_write): Fix last change.
6021
2e8f3c56
LI
60222012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6023
6024 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6025 send_process.
6026
af70074f
SM
60272012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6028
6029 * keymap.c (Fsingle_key_description): Handle char ranges.
6030
95986d52
CY
60312012-02-12 Chong Yidong <cyd@gnu.org>
6032
afd83bd1
CY
6033 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6034 as that creates a dangerous corner case.
6035
95986d52
CY
6036 * window.c (Fdelete_window_internal): Invalidate the mouse
6037 highlight (Bug#9904).
6038
bd7da63e
GM
60392012-02-12 Glenn Morris <rgm@gnu.org>
6040
6041 * xselect.c (Fx_own_selection_internal)
6042 (Fx_get_selection_internal, Fx_disown_selection_internal)
6043 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6044 * nsselect.m (Fx_own_selection_internal)
6045 (Fx_disown_selection_internal, Fx_selection_exists_p)
6046 (Fx_selection_owner_p, Fx_get_selection_internal):
6047 Sync docs and argument specs with the xselect.c versions.
6048
77abcbc2
LI
60492012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6050
6051 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6052
90b671e2
EZ
60532012-02-11 Eli Zaretskii <eliz@gnu.org>
6054
1c0ca0b7
EZ
6055 * w32select.c (Fx_selection_exists_p): Sync doc string and
6056 argument list with xselect.c. (Bug#10783)
6057
6058 * w16select.c (Fx_selection_exists_p): Sync doc string and
6059 argument list with xselect.c. (Bug#10783)
90b671e2 6060
49241268
GM
60612012-02-10 Glenn Morris <rgm@gnu.org>
6062
6063 * fns.c (Fsecure_hash): Doc fix.
6064
f998bbe7 60652012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6066
6067 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6068
0992bd9c
CY
60692012-02-07 Chong Yidong <cyd@gnu.org>
6070
6071 * buffer.c (Fbuffer_local_variables)
6072 (buffer_lisp_local_variables): Handle unbound vars correctly;
6073 don't let Qunbound leak into Lisp.
6074
af008560
GM
60752012-02-07 Glenn Morris <rgm@gnu.org>
6076
dd605cc4
GM
6077 * image.c (Fimagemagick_types): Doc fix.
6078
af008560
GM
6079 * image.c (imagemagick-render-type): Change it from a lisp object
6080 to an integer. Move the doc here from the lisp manual.
6081 Treat all values not equal to 0 the same.
6082
1449fa1d
CY
60832012-02-06 Chong Yidong <cyd@gnu.org>
6084
6085 * doc.c (store_function_docstring): Avoid applying docstring of
6086 alias to base function (Bug#2603).
6087
3723ec07
AS
60882012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6089
6090 * .gdbinit (pp1, pv1): Remove redundant defines.
6091 (pr): Use pp.
6092
79c1cc1e
CY
60932012-02-04 Chong Yidong <cyd@gnu.org>
6094
6095 * nsterm.m: Declare a global (Bug#10694).
6096
d7f29f8e
EZ
60972012-02-04 Eli Zaretskii <eliz@gnu.org>
6098
cae07000
SM
6099 * w32.c (get_emacs_configuration_options):
6100 Include --enable-checking, if specified, in the return value.
d7f29f8e 6101
3b95a6f9
MR
61022012-02-04 Martin Rudalics <rudalics@gmx.at>
6103
6104 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6105 after rounding frame sizes. (Bug#9723)
6106
d6fa96a6
EZ
61072012-02-04 Eli Zaretskii <eliz@gnu.org>
6108
6109 * keyboard.c (adjust_point_for_property): Don't position point
6110 before BEGV. (Bug#10696)
6111
df0b2940
PE
61122012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6113
6114 Handle overflow when computing char display width (Bug#9496).
6115 * character.c (char_width): Return EMACS_INT, not int.
6116 (char_width, c_string_width): Check for overflow when
6117 computing the width; this is possible now that individual
6118 characters can have unbounded width. Problem introduced
6119 by merge from Emacs 23 on 2012-01-19.
6120
6bee44d6
MA
61212012-02-02 Michael Albinus <michael.albinus@gmx.de>
6122
6123 * dbusbind.c (Fdbus_register_method): Mention the return value
6124 :ignore in the docstring.
6125
44f92739
GM
61262012-02-02 Glenn Morris <rgm@gnu.org>
6127
1b9f60cc
GM
6128 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6129
44f92739
GM
6130 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6131 Unconditionally set to t. (Bug#10673)
6132 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6133 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6134 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6135
c5d3843c
KH
61362012-02-02 Kenichi Handa <handa@m17n.org>
6137
6138 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6139 0, do not call append_composite_glyph.
6140
159462d4 61412012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6142
6143 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6144 NULL (Bug#6988).
6145 (x_produce_glyphs): If the component of a composition is a null
6146 string, set it->pixel_width to 1 to avoid zero-width glyph.
6147
78cef877
EZ
61482012-02-01 Eli Zaretskii <eliz@gnu.org>
6149
6150 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6151 first 2 arguments are identical. This makes inserting large
6152 output from a subprocess an order of magnitude faster on
6153 MS-Windows, where all sbrk'ed memory is always contiguous.
6154
97897668
GM
61552012-01-31 Glenn Morris <rgm@gnu.org>
6156
6157 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6158 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6159 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6160
31fd3586
GM
61612012-01-29 Glenn Morris <rgm@gnu.org>
6162
6163 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6164
0e24a8b2
CY
61652012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6166
6167 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6168
cc0adcb0
CY
61692012-01-28 Chong Yidong <cyd@gnu.org>
6170
6171 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6172
acc28cb9
CY
61732012-01-26 Chong Yidong <cyd@gnu.org>
6174
9c69cfb7
CY
6175 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6176
acc28cb9
CY
6177 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6178 repeat counts (Bug#10507).
6179
48da7392
GM
61802012-01-26 Glenn Morris <rgm@gnu.org>
6181
6182 * lread.c (syms_of_lread): Doc fix.
6183
14af5f7f
CY
61842012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6185
6186 * coding.c (encode_designation_at_bol): Change return value to
6187 EMACS_INT.
6188
0b21c100
CY
61892012-01-25 Chong Yidong <cyd@gnu.org>
6190
6191 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6192
3c2907f7
CY
61932012-01-21 Chong Yidong <cyd@gnu.org>
6194
6195 * floatfns.c (Fcopysign): Make the second argument non-optional,
6196 since nil is not allowed anyway.
6197
959ad23f
AS
61982012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6199
6200 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6201 (send_process): Likewise.
6202
34a02f46
MR
62032012-01-19 Martin Rudalics <rudalics@gmx.at>
6204
6205 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6206 (Vwindow_persistent_parameters): Do not use Qstate.
6207 Rewrite doc-strings.
34a02f46 6208
1259009a 62092012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6210
6211 * character.c (char_width): New function.
70d4fdf6
GM
6212 (Fchar_width, c_string_width, lisp_string_width):
6213 Use char_width (Bug#9496).
25ed9e61 6214
6a6ee00d
MR
62152012-01-16 Martin Rudalics <rudalics@gmx.at>
6216
6217 * window.c (Vwindow_persistent_parameters): New variable.
6218 (Fset_window_configuration, save_window_save): Handle persistent
6219 window parameters.
6220
c85efaf7
EZ
62212012-01-14 Eli Zaretskii <eliz@gnu.org>
6222
6223 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6224 thrashing the stack of the thread. (Bug#9087)
6225
5944709e
PE
62262012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6227
6228 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6229
e71f5d99
EZ
62302012-01-11 Eli Zaretskii <eliz@gnu.org>
6231
6232 * xdisp.c (rows_from_pos_range): Handle the case where the
6233 highlight ends on a newline. (Bug#10464)
6234 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6235 he end column for display of highlight that ends on a newline
6236 before a R2L line.
6237
ce316182
GM
62382012-01-11 Glenn Morris <rgm@gnu.org>
6239
6240 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6241 from load-path also when installation-directory is nil. (Bug#10208)
6242
5b43da69
GM
62432012-01-10 Glenn Morris <rgm@gnu.org>
6244
74cc8ff9
GM
6245 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6246
7d8d6e4e
GM
6247 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6248 Update template values to be closer to their typical values these days.
5b43da69 6249
a0db8d43
EZ
62502012-01-09 Eli Zaretskii <eliz@gnu.org>
6251
6252 * xdisp.c (rows_from_pos_range): Accept additional argument
6253 DISP_STRING, and accept any glyph in a row whose object is that
6254 string as eligible for mouse highlight. Fixes mouse highlight of
6255 display strings from overlays. (Bug#10464)
6256
9a0115ab 62572012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6258
b9110d6a 6259 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6260 * fileio.c (auto_saving_dir_umask): New static var.
6261 (Fmake_directory_internal): Use it.
6262 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6263 creating the directory. The old code temporarily assigns
6264 too-generous permissions to the directory.
6265 (do_auto_save_eh): Clear it.
b9110d6a 6266 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6267 that the var is always cleared.
6268
6c1bd3f3
EZ
62692012-01-07 Eli Zaretskii <eliz@gnu.org>
6270
6271 * search.c (scan_buffer): Pass character positions to
6272 know_region_cache, not byte positions. (Bug#6540)
6273
069d2b50
L
62742012-01-07 LynX <_LynX@bk.ru> (tiny change)
6275
6276 * w32.c (sys_rename): Report EXDEV when rename of a directory
6277 fails because the target is on another logical disk. (Bug#10284)
6278
75bf0d33
DB
62792012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6280
6281 * xterm.c (x_embed_request_focus): New function.
6282
6283 * xterm.h: Add prototype.
6284
6285 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6286
1c6e5a32
GM
62872012-01-05 Glenn Morris <rgm@gnu.org>
6288
6289 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6290
651e947e
EZ
62912012-01-01 Eli Zaretskii <eliz@gnu.org>
6292
6293 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6294 Load gnutls_transport_set_lowat only if GnuTLS version is below
6295 2.11.1.
6296 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6297 GnuTLS versions below 2.11.1.
6298
3778cdd8
AL
62992011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6300
6301 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6302 to the doc string advising against its use for altering the way
6303 windows are scrolled.
6304
0e5317f7
KH
63052011-12-28 Kenichi Handa <handa@m17n.org>
6306
6307 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6308 coding-system ASCII compatible only when it does not produce BOM
6309 on encoding (Bug#10383).
6310
93d5ca1f
JD
63112011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6312
6313 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6314 can scroll.
6315 (create_and_show_popup_menu): Always use menu_position_func for
6316 Gtk3 (Bug#10361).
6317
ca22b785
AS
63182011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6319
6320 * callint.c (Fcall_interactively): Don't truncate prompt string.
6321
d048e1e6
EZ
63222011-12-23 Eli Zaretskii <eliz@gnu.org>
6323
6324 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6325 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6326 resumed from there (after widening). (Bug#10360)
d048e1e6 6327
5ccaba1f
JD
63282011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6329
6330 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6331
204ee57f
JD
63322011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6333
b81d40f0
JB
6334 * nsterm.m (x_free_frame_resources):
6335 Release f->output_data.ns->miniimage.
204ee57f
JD
6336 (ns_index_color): Fix indentation. Do not retain
6337 color_table->colors[i].
6338
6339 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6340 before returning.
6341
6342 * nsfns.m (x_set_background_color): Assign return value from
6343 ns_index_color to face-background instead of NSColor*.
6344 (ns_implicitly_set_icon_type): Fix indentation.
6345 Change assignment in for loop to comparison.
6346
6347 * emacs.c (ns_pool): New variable.
6348 (main): Assign ns_pool.
6349 (Fkill_emacs): Call ns_release_autorelease_pool.
6350
6351 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6352 autorelease fdesc, release fdAttrs and tdict.
6353 (ns_get_covering_families): Release charset.
6354 (ns_findfonts): Release NSFontDescriptor created with new.
6355 (ns_uni_to_glyphs): Fix indentation.
6356 (setString): Release attrStr before assigning new value.
6357
c803b2b7
JD
63582011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6359
678f4426
JD
6360 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6361 and NS_IMPL_COCOA.
6362 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6363 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6364
cd394be1 63652011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6366
5fecd5fc
JD
6367 * nsterm.m (ns_term_init): Subscribe for notifications
6368 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6369 to method trackingNotification in EmacsMenu.
6370
6371 * nsmenu.m (trackingMenu): New variable.
3771cb17 6372 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6373 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6374 from Aquamacs (Bug#7030).
678f4426
JD
6375
63762011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6377
c803b2b7
JD
6378 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6379 (symbol_to_nsstring): Fix indentation.
6380 (ns_symbol_to_pb): New function.
cae07000
SM
6381 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6382 (Fns_rotate_cut_buffers_internal): Remove.
6383 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6384 Fns_store_cut_buffer_internal.
6385 (ns_get_foreign_selection, Fx_own_selection_internal)
6386 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6387 (Fns_get_selection_internal, Fns_store_selection_internal):
6388 Use ns_symbol_to_pb and check if return value is nil.
6389 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6390 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6391 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6392 renamed to Sns_store_selection_internal.
6393 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6394 and remove this function.
6395 (ns_handle_selection_clear): Remove, never used.
6396 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6397 here.
6398
e1b01a3a
KB
63992011-12-17 Ken Brown <kbrown@cornell.edu>
6400
6401 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6402 GID is unknown (Bug#10257).
6403
2adb6e85
PE
64042011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6405
6406 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6407 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6408 which caused a build failure on GNU/Linux IA-64. This problem was
6409 introduced by my 2011-10-07 patch.
6410
d1d7b339
JL
64112011-12-15 Juri Linkov <juri@jurta.org>
6412
6413 * image.c (imagemagick_error): New function. (Bug#10112)
6414 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6415 Use `imagemagick_error' where ImageMagick functions return
6416 `MagickFalse'.
6417 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6418 proper order.
6419
100d5755
KH
64202011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6421
6422 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6423 fill background (Bug#8992).
6424
454592a6
MR
64252011-12-13 Martin Rudalics <rudalics@gmx.at>
6426
6427 * window.c (Vwindow_combination_resize)
6428 (Vwindow_combination_limit): Use t instead of non-nil in
6429 doc-strings.
61d4b438
MR
6430 (Vrecenter_redisplay): Add first sentence of doc-string on
6431 separate line.
53524d93 6432 (Frecenter): Fix doc-string typo.
454592a6 6433
3633e3aa
KH
64342011-12-11 Kenichi Handa <handa@m17n.org>
6435
6436 * coding.c (Funencodable_char_position): Pay attention to the
6437 buffer text relocation (Bug#9389).
6438
7b9d523a 64392011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6440
7b9d523a
JD
6441 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6442 gtk_init (Bug#10100).
6443
b73189c6
EZ
64442011-12-10 Eli Zaretskii <eliz@gnu.org>
6445
6446 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6447 IT->string is nil. (Bug#10263)
6448
f7dfe5d6
JD
64492011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6450
83faebb4
JD
6451 * nsterm.h (x_free_frame_resources): Declare.
6452
f7dfe5d6
JD
6453 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6454 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6455
6456 * nsterm.h (ns_get_defaults_value): Declare.
6457
6458 * nsterm.m (ns_default): Call ns_get_defaults_value.
6459
7cd4e72c
EZ
64602011-12-09 Eli Zaretskii <eliz@gnu.org>
6461
6462 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6463 (Bug#10170)
6464
b34d7317
YM
64652011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6466
6467 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6468 that where the value of an _OBJC_* symbol points to is in the .bss
6469 section (Bug#10240).
6470
76470ad1
KH
64712011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6472
6473 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6474 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6475
745fff94
KH
64762011-12-08 Kenichi Handa <handa@m17n.org>
6477
6478 * ftfont.c (get_adstyle_property): Fix previous change
6479 (Bug#10233).
6480
6e44397c
JB
64812011-12-07 Juanma Barranquero <lekktu@gmail.com>
6482
6483 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6484 dirs from the default value of EMACSLOADPATH (bug#10208).
6485
7efa6272
GM
64862011-12-07 Glenn Morris <rgm@gnu.org>
6487
6488 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6489 installation and source directories as well. (Bug#10208)
6490
f6fc4d87
CY
64912011-12-06 Chong Yidong <cyd@gnu.org>
6492
6493 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6494
2bf26180
GM
64952011-12-06 Glenn Morris <rgm@gnu.org>
6496
6497 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6498 as an error, not just -1. (Bug#10217)
6499
3a6ad4f0
CY
65002011-12-05 Chong Yidong <cyd@gnu.org>
6501
6502 * keyboard.c (process_special_events): New function.
6503 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6504
75a3b399
PE
65052011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6506
6507 * coding.c (encode_designation_at_bol): Don't use uninitialized
6508 local variable (Bug#9318).
6509
c3c9e25e
KH
65102011-12-05 Kenichi Handa <handa@m17n.org>
6511
6512 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6513 return Qnil (Bug#8046, Bug#10193).
6514
5eb05ea3
KH
65152011-12-05 Kenichi Handa <handa@m17n.org>
6516
6517 * coding.c (encode_designation_at_bol): New args charbuf_end and
6518 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6519 (coding_set_source): Return how many bytes coding->source was
6520 relocated.
6521 (coding_set_destination): Return how many bytes
6522 coding->destination was relocated.
6523 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6524 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6525
65262011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6527
6528 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6529 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6530 macro (Bug#9318).
6531
65322011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6533
6534 The following changes are to fix Bug#9318.
6535
a79703f5 6536 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6537 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6538 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6539 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6540
7dbda6df
JB
65412011-12-05 Juanma Barranquero <lekktu@gmail.com>
6542
6543 * lisp.h (process_quit_flag): Fix external declaration.
6544
6d5eb5b0
SM
65452011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6546
6547 Don't macro-inline non-performance-critical code.
6548 * eval.c (process_quit_flag): New function.
6549 * lisp.h (QUIT): Use it.
6550
a0c3fad0
JD
65512011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6552
6553 * nsfns.m (get_geometry_from_preferences): New function.
6554 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6555
6c07aac2
AS
65562011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6557
6558 * emacs.c (Qkill_emacs): Define.
6559 (syms_of_emacs): Initialize it.
6560 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6561 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6562 (quit_throw_to_read_char): Add parameter `from_signal'.
6563 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6564 * lisp.h (QUIT): Call Fkill_emacs if requested.
6565
c052ead4
JD
65662011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6567
6568 * widget.c (update_wm_hints): Return if wmshell is null.
6569 (widget_update_wm_size_hints): New function.
6570
6571 * widget.h (widget_update_wm_size_hints): Declare.
6572
6573 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6574 widget_update_wm_size_hints (Bug#10104).
6575
9e49252b
EZ
65762011-12-03 Eli Zaretskii <eliz@gnu.org>
6577
6578 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6579 before a newline, prepare the bidi iterator for consuming the
6580 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6581 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6582
02b16839
JL
65832011-12-02 Juri Linkov <juri@jurta.org>
6584
6585 * search.c (Fword_search_regexp): New Lisp function created from
6586 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6587 (Fword_search_backward, Fword_search_forward)
6588 (Fword_search_backward_lax, Fword_search_forward_lax):
6589 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6590 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6591
0068070e
SM
65922011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6593
6594 * fileio.c (Finsert_file_contents): Move after-change-function call
6595 to before the "handled:" label, since all "goto handled" appear in
6596 cases where the *-change-functions have already been properly called
6597 (bug#10117).
6598
3360a3fc
AS
65992011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6600
6601 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6602 waiting for input. (Bug#10169)
6603
73d6c093
EZ
66042011-11-30 Eli Zaretskii <eliz@gnu.org>
6605
6606 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6607 verifies glyph row's hash code--we have just reallocated the
6608 glyphs, so their contents can be complete garbage. (Bug#10164)
6609
febe6bea
JB
66102011-11-30 Juanma Barranquero <lekktu@gmail.com>
6611
6612 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6613
801a4313
EZ
66142011-11-30 Eli Zaretskii <eliz@gnu.org>
6615
6616 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6617 attributes are tested _before_ calling verify_row_hash, to protect
6618 against GCC re-ordering of the tests. (Bug#10164)
6619
2b56b87e
JD
66202011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6621
6622 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6623
6624 * xterm.c (handle_one_xevent): Only set async_visible and friends
6625 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6626 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6627 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6628
dbf31225
PE
66292011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6630
6631 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6632 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6633 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6634 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6635 All uses changed to use GCPRO1 etc.
6636 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6637 Revert to old implementation (i.e., before 2011-03-11).
6638
1305621b
YM
66392011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6640
6641 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6642 of scroll runs so as to avoid assigning disabled bogus rows and
6643 unnecessary graphics copy operations.
6644
8c9afb46
EZ
66452011-11-27 Eli Zaretskii <eliz@gnu.org>
6646
6647 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6648 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6649 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6650 (malloc, free, realloc, calloc): Redirect to e_* only when
6651 compiling Emacs.
6652
6653 * lisp.h (GCTYPEBITS): Move before first use.
6654 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6655 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6656 this macro definition.
6657
6658 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6659 _MSC_VER.
6660
54e9e3bf
JD
66612011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6662
6d5eb5b0
SM
6663 * gtkutil.c (xg_create_frame_widgets):
6664 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6665 present with Gtk+ 2.0.
6666
83aca1cb
PE
66672011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6668
6669 * fileio.c (Finsert_file_contents): Undo previous change; see
6670 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6671
5b76caa4
PE
66722011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6673
6674 Rename locals to avoid shadowing.
6675 * fileio.c (Finsert_file_contents):
6676 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6677 * process.c (wait_reading_process_output):
6678 Rename inner 'proc' to 'p' to avoid shadowing.
6679 Indent for consistency with usual Emacs style.
6680
8c535114
EZ
66812011-11-25 Eli Zaretskii <eliz@gnu.org>
6682
6683 * xdisp.c (redisplay_window): If cursor row is not fully visible
6684 after recentering, and scroll-conservatively is set to a large
6685 number, scroll window by a few more lines to make the cursor fully
6686 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6687 (start_display): Don't move to the next line if the display should
6688 start at a newline that is part of a display vector or an overlay
6689 string. (Bug#10119)
8c535114 6690
fa4fdb5c
JL
66912011-11-24 Juri Linkov <juri@jurta.org>
6692
6693 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6694 after the `MagickPingImage' call. (Bug#10112)
6695
90ec88df
CY
66962011-11-23 Chong Yidong <cyd@gnu.org>
6697
6698 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6699
56e2e794
MR
67002011-11-23 Martin Rudalics <rudalics@gmx.at>
6701
6702 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6703 making another buffer current. (Bug#10114)
6704
b6e64c41
GM
67052011-11-23 Glenn Morris <rgm@gnu.org>
6706
6707 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6708
6b21de18
CY
67092011-11-23 Chong Yidong <cyd@gnu.org>
6710
6711 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6712 using it (Bug#5984).
6713
b12cd789
EZ
67142011-11-22 Eli Zaretskii <eliz@gnu.org>
6715
6716 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6717 and header-lines, as they don't have one computed for them.
6718 (Bug#10098)
6719
6720 * .gdbinit (prow): Make displayed values more self-explaining.
6721 Add row's hash code.
6722
261b6fd4
LMI
67232011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6724
6725 * process.c (wait_reading_process_output): Fix asynchrounous
6726 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6727 (wait_reading_process_output): Add comment and URL.
261b6fd4 6728
e7cfd277
JD
67292011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6730
6731 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6732
a9b9b7f5
CY
67332011-11-21 Chong Yidong <cyd@gnu.org>
6734
6735 * window.c (Fnext_window, Fprevious_window): Doc fix.
6736
b0d15b4f
SM
67372011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6738
6739 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6740
fe7a3057
JB
67412011-11-20 Juanma Barranquero <lekktu@gmail.com>
6742
6743 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6744
d2999b1a
MR
67452011-11-20 Martin Rudalics <rudalics@gmx.at>
6746
6747 * window.c (Fset_window_combination_limit): Rename argument
6748 STATUS to LIMIT.
6749 (Vwindow_combination_limit): Remove "status" from doc-string.
6750
d5ff9cd0
AS
67512011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6752
6753 * m/ibms390.h: Remove.
6754 * m/ibms390x.h: Don't include "ibms390.h".
6755
a5bb9bd3
SM
67562011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6757
6758 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6759 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6760
cd1181db
JB
67612011-11-20 Juanma Barranquero <lekktu@gmail.com>
6762
6763 * casetab.c (Fset_case_table):
6764 * charset.c (Fcharset_after): Fix typos.
6765
615a3b8d 67662011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6767
17e845af
PE
6768 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6769 Otherwise, valgrind does not work on some platforms.
6770 Problem reported by Andreas Schwab in
6a0bf43d
PE
6771 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6772 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6773 is set, removing the need for VIRT_ADDRESS_VARIES.
6774 (PURE_P): Use a more-efficient implementation that needs just one
6775 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6776 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6777 to 4 (xorl, subq, cmpq, setbe).
6778 * alloc.c (pure): Always extern now, since that's the
6779 VIRT_ADDR_VARIES behavior.
6780 (PURE_POINTER_P): Use a single comparison, not two, for
6781 consistency with the new puresize.h.
6782 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6783 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6784 Remove VIRT_ADDR_VARIES no longer needed.
6785
f8fe6f96
EZ
67862011-11-19 Eli Zaretskii <eliz@gnu.org>
6787
6788 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6789 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6790 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6791 behave as if the cursor position were at the window margin.
6792
6793 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6794 and the cursor position is out of bounds, behave as if the cursor
6795 position were at the window margin. (Bug#10075)
6796
df05a53c
CY
67972011-11-18 Chong Yidong <cyd@gnu.org>
6798
6799 * window.c (Fwindow_combination_limit): Make first argument
6800 non-optional, since it is meaningless for live windows like the
6801 selected window.
61ccba97 6802
2071918e
DA
68032011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6804
6805 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6806
b50a28de
SM
68072011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6808
6809 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6810 (graft_intervals_into_buffer): Simplify.
6811
015137db
EZ
68122011-11-18 Eli Zaretskii <eliz@gnu.org>
6813
6814 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6815 hash values of the two rows.
6816 (copy_row_except_pointers): Preserve the used[] arrays and the
6817 hash values of the two rows. (Bug#10035)
68c95424 6818 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6819
6820 * xdisp.c (row_hash): New function, body extracted from
6821 compute_line_metrics.
6822 (compute_line_metrics): Call row_hash, instead of computing the
6823 hash code inline.
6824
6825 * dispnew.c (verify_row_hash): Call row_hash for computing the
6826 hash code of a row, instead of duplicating code from xdisp.c.
6827
6828 * dispextern.h (row_hash): Add prototype.
6829
a2addb04
TH
68302011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6831
6832 * frame.c (delete_frame): Don't delete the terminal when the last
6833 X frame is closed if emacs is built with GTK toolkit.
6834
df85d315
JB
68352011-11-17 Juanma Barranquero <lekktu@gmail.com>
6836
6837 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6838
a0c2d0ae
MR
68392011-11-17 Martin Rudalics <rudalics@gmx.at>
6840
6841 * window.c (Vwindow_splits): Rename to
6842 Vwindow_combination_resize. Suggested by Juri Linkov.
6843 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6844 of Vwindow_splits.
6845
58179cce
JB
68462011-11-16 Juanma Barranquero <lekktu@gmail.com>
6847
7877f373
JB
6848 * nsfns.m (Fns_font_name):
6849 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6850
b6f67890
MR
68512011-11-16 Martin Rudalics <rudalics@gmx.at>
6852
6853 * window.h (window): Rename slot "nest" to "combination_limit".
6854 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6855 (Fset_window_nest): Rename to Fset_window_combination_limit.
6856 (Vwindow_nest): Rename to Vwindow_combination_limit.
6857 (recombine_windows, make_parent_window, make_window)
6858 (Fsplit_window_internal, saved_window)
6859 (Fset_window_configuration, save_window_save): Rename all
6860 occurrences of window_nest to window_combination_limit.
6861
c7015153
JB
68622011-11-15 Juanma Barranquero <lekktu@gmail.com>
6863
6864 * image.c (imagemagick_load_image): Fix typo.
6865
322ad6ec
EZ
68662011-11-14 Eli Zaretskii <eliz@gnu.org>
6867
6868 * xdisp.c (display_line): Move the call to
6869 highlight_trailing_whitespace before the call to
6870 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6871 faces of all the glyphs to compute ROW's hash value.
6872 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6873
f067b8ec
JB
68742011-11-14 Juanma Barranquero <lekktu@gmail.com>
6875
6876 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6877 just return (bug#10044).
6878
1e5b2111
EZ
68792011-11-12 Eli Zaretskii <eliz@gnu.org>
6880
7ef3cbd5
EZ
6881 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6882 with user-defined heap size. Bump the default size of the temacs
6883 heap to 27MB, to avoid memory warning when running temacs.
6884 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6885
1e5b2111
EZ
6886 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6887 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6888 (verify_row_hash) [XASSERTS]: New function.
6889 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6890 that the hash value of glyph rows is correct.
1e5b2111 6891
89d61221
MR
68922011-11-12 Martin Rudalics <rudalics@gmx.at>
6893
6894 * window.h (window): Remove splits slot.
6895 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6896 (Fdelete_other_windows_internal, make_parent_window)
6897 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6898 (Fset_window_configuration, save_window_save): Don't deal with
6899 split status of windows.
6900 (saved_window): Remove splits slot.
6901 (Vwindow_splits): Rewrite doc-string.
6902
97f18cc8
JD
69032011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6904
6905 * xfns.c (unwind_create_frame):
6906 * nsfns.m (unwind_create_frame):
6907 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6908 Vframe_list (Bug#9999).
6909
22a648b4
DA
69102011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6911
0b381c7e 6912 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6913
659afede
KH
69142011-11-11 Kenichi Handa <handa@m17n.org>
6915
6916 * callproc.c (Fcall_process): Set the member dst_multibyte of
6917 process_coding.
6918
9ac0394b
KH
69192011-11-11 Johan Bockgård <bojohan@gnu.org>
6920
6921 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6922 avoid a crash (bug#9496).
6923
2fbdc249
CY
69242011-11-09 Chong Yidong <cyd@gnu.org>
6925
6926 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6927 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6928
ac6b1f81
PE
69292011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6930
6931 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6932
09db192c
PE
69332011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6934
6935 Avoid some portability problems by eschewing 'extern inline' functions.
6936 The trivial performance wins aren't worth the portability hassles; see
6937 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6938 et seq.
6939 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6940 (window_box_width, window_box_left, window_box_left_offset)
6941 (window_box_right, window_box_right_offset): Undo previous change,
6942 by removing the "extern"s.
6943 * intervals.c (adjust_intervals_for_insertion)
6944 (adjust_intervals_for_deletion): Undo previous change,
6945 making these static again.
6946 (offset_intervals, temp_set_point_both, temp_set_point)
6947 (copy_intervals_to_string): No longer inline.
6948 * xdisp.c (window_text_bottom_y, window_box_width)
6949 (window_box_height, window_box_left_offset)
6950 (window_box_right_offset, window_box_left, window_box_right)
6951 (window_box): No longer inline.
6952
105216ed
CY
69532011-11-08 Chong Yidong <cyd@gnu.org>
6954
6955 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6956 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6957 Signal an error if not a live window.
105216ed
CY
6958 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6959 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6960
ae9e237f
JB
69612011-11-07 Juanma Barranquero <lekktu@gmail.com>
6962
6963 * lisp.h (syms_of_abbrev): Remove declaration.
6964 Reported by CHENG Gao <chenggao@royau.me>.
6965
c7aa8333
EZ
69662011-11-07 Eli Zaretskii <eliz@gnu.org>
6967
6968 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6969 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6970 of temacs in GUI mode.
6971
be7f5545
MR
69722011-11-07 Martin Rudalics <rudalics@gmx.at>
6973
6974 * window.h: Declare delete_all_child_windows instead of
6975 delete_all_subwindows.
6976 * window.c (Fwindow_nest, Fset_window_nest)
6977 (Fset_window_new_total, Fset_window_new_normal)
6978 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6979 (delete_all_subwindows): Rename to delete_all_child_windows.
6980 (Fdelete_other_windows_internal, Fset_window_configuration):
6981 Call delete_all_child_windows instead of delete_all_subwindows.
6982 * frame.c (delete_frame): Call delete_all_child_windows instead
6983 of delete_all_subwindows.
6984
ca78dc43
PE
69852011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6986
6987 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6988 This is also needed for porting to any host where GC_MARK_STACK is
6989 not GC_MAKE_GCPROS_NOOPS.
6990 (which_symbols): Use it.
6991
a0241d01
KH
69922011-11-07 Kenichi Handa <handa@m17n.org>
6993
6994 * coding.c (coding_set_destination): Check coding->src_pos only
6995 when coding->src_object is a buffer (bug#9910).
6996
6997 * process.c (send_process): Set the member src_multibyte of coding
6998 to 0 (bug#9911) when sending a unibyte text.
6999
7000 * callproc.c (Fcall_process): Set the member src_multibyte of
7001 process_coding to 0 (bug#9912).
7002
a64bfdfa 70032011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7004
7005 * xmenu.c (cleanup_widget_value_tree): New function.
7006 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7007 calling free_menubar_widget_value_tree directly (Bug#9830).
7008
cb41b32a
PE
70092011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7010
7011 Fix some portability problems with 'inline'.
7012 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7013 (window_box_width, window_box_left, window_box_left_offset)
7014 (window_box_right, window_box_right_offset): Declare extern.
7015 Otherwise, these inline functions do not conform to C99 and
7016 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7017 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7018 * intervals.c (adjust_intervals_for_insertion)
7019 (adjust_intervals_for_deletion): Now extern, because otherwise the
7020 extern inline functions 'offset_intervals' couldn't refer to it.
7021 (static_offset_intervals): Remove.
7022 (offset_intervals): Rewrite using the old contents of
7023 static_offset_intervals. The old version didn't conform to C99
7024 because an extern inline function contained a reference to an
7025 identifier with static linkage.
7026
b7041366
AS
70272011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7028
7029 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7030 GC.
7031
88a37c4d
EZ
70322011-11-06 Eli Zaretskii <eliz@gnu.org>
7033
7034 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7035 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7036 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7037 return Qleft_to_right.
7038
49745b39
CY
70392011-11-06 Chong Yidong <cyd@gnu.org>
7040
7041 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7042 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7043 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7044 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7045 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7046 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7047 (Fwindow_vscroll): Doc fix.
7048 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7049 argument, since it makes no sense to pass a live window and for
7050 consistency with window-child.
7051
1f05cd82
CS
70522011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7053
7054 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7055 support MSVC.
7056
22610910
JR
70572011-11-05 Jason Rumney <jasonr@gnu.org>
7058
7059 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7060 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7061 fonts (Bug#6029).
7062 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7063 bitwise arithmetic preventing use of unicode-sip and non-truetype
7064 opentype fonts.
7065
a06776b2
EZ
70662011-11-05 Eli Zaretskii <eliz@gnu.org>
7067
3ad924ba
EZ
7068 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7069 "emacs"-only part.
7070
a06776b2
EZ
7071 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7072 initialization code to keep similarity to xfns.c after changes
7073 from 2011-11-05.
7074
c9e7db78
JD
70752011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7076
a97f8f3f
JD
7077 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7078 (unwind_create_frame): New function (Bug#9943).
7079 (Fx_create_frame): Restructure code to be more similar to the one in
7080 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7081 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7082 Move terminal->reference_count++ just before making the frame official
7083 (Bug#9943).
7084
7085 * nsterm.m (x_free_frame_resources): New function.
7086 (x_destroy_window): Move code to x_free_frame_resources.
7087
c9e7db78 7088 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7089 (Fx_create_frame, x_create_tip_frame):
7090 Move terminal->reference_count++ just before making the frame
75f1671a 7091 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7092 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7093
a6fc3b5c
EZ
70942011-11-05 Eli Zaretskii <eliz@gnu.org>
7095
7096 Support MSVC build with newer versions of Visual Studio.
7097 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7098 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7099 nt/gmake.defs.
7100
7101 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7102 which are not supported by MSVC.
7103 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7104 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7105 bitfields.
7106 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7107 types in bitfields.
7108 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7109
7110 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7111
58179cce 71122011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7113
7114 Support MSVC build with newer versions of Visual Studio.
7115 * w32.c: Don't include w32api.h for MSVC.
7116 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7117
7118 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7119 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7120 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7121 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7122 e_* cousins.
7123 (alloca) [_MSC_VER]: Define to _alloca.
7124
7125 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7126
7127 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7128
a58c13ed
EZ
71292011-11-04 Eli Zaretskii <eliz@gnu.org>
7130
7131 * xdisp.c (note_mouse_highlight): If either of
7132 previous/next-single-property-change returns nil, treat that as
7133 the beginning or the end of the buffer. (Bug#9955)
7134
fe0b6370
JD
71352011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7136
a58c13ed 7137 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7138 label is not null (Bug#9951).
7139 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7140 may be NULL.
7141
89bd5ee1
EZ
71422011-11-04 Eli Zaretskii <eliz@gnu.org>
7143
7144 * window.c (Fwindow_body_size): Mention in the doc string that the
7145 return value is in frame's canonical units. (Bug#9949)
7146
84c3edb9
EZ
71472011-11-03 Eli Zaretskii <eliz@gnu.org>
7148
4e2fb5c7
EZ
7149 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7150
84c3edb9 7151 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7152 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7153 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7154
bc17a887
EZ
71552011-11-01 Eli Zaretskii <eliz@gnu.org>
7156
7157 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7158 Don't stop backward scan on the continuation glyph, even though
7159 its CHARPOS is positive.
6d5eb5b0
SM
7160 (mouse_face_from_buffer_pos, note_mouse_highlight):
7161 Rename cover_string to disp_string.
bc17a887 7162
4ee88440
MR
71632011-11-01 Martin Rudalics <rudalics@gmx.at>
7164
7165 * window.c (temp_output_buffer_show): Don't use
7166 Vtemp_buffer_show_specifiers.
7167 (Vtemp_buffer_show_specifiers): Remove unused variable.
7168
c2ff3c02
EZ
71692011-10-30 Eli Zaretskii <eliz@gnu.org>
7170
7171 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7172 past the beginning of the current glyph matrix.
7173
58179cce 71742011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7175
7176 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7177 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7178 HAVE_GTK3 (Bug#9869).
b77a6a7f 7179
3b574623
JD
7180 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7181 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7182
b77a6a7f
JD
7183 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7184
7185 * xterm.c: Declare x_handle_net_wm_state to return int.
7186 (handle_one_xevent): Check if we are iconified but don't have
7187 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7188 (get_current_wm_state): Return non-zero if not hidden,
7189 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7190 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7191 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7192 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7193
196e41e4
PE
71942011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7195
7196 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7197 so that this new function doesn't get optimized away by a
7198 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7199
021f2e1a
AS
72002011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7201
7202 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7203
8b058d44
EZ
72042011-10-29 Eli Zaretskii <eliz@gnu.org>
7205
7206 Fix the `xbytecode' command.
7207 * .gdbinit (xprintbytestr): New command.
b50a28de 7208 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7209 (xbytecode): Print the byte-code string as well.
7210
4452fb80
EZ
72112011-10-29 Kim Storm <storm@cua.dk>
7212
8b058d44
EZ
7213 * alloc.c (which_symbols): New function.
7214
21b72067
AS
72152011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7216
7217 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7218 line. (Bug#9903)
7219
83ed7b5c
GM
72202011-10-29 Glenn Morris <rgm@gnu.org>
7221
7222 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7223 Not clear what it was for, and it causes various bugs. (Bug#9839)
7224
5a7a728b
EZ
72252011-10-28 Eli Zaretskii <eliz@gnu.org>
7226
7227 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7228 possible random value that matches one of those tested as
7229 condition to clear the mouse face.
7230
d3d0842f
CY
72312011-10-28 Chong Yidong <cyd@gnu.org>
7232
7233 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7234
31b39d13
DN
72352011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7236
7237 * window.c (make_window): Initialize phys_cursor_on_p.
7238
9aba6043
SM
72392011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7240
7241 * lisp.h (struct Lisp_Symbol): Update comments.
7242
c20992f4
JB
72432011-10-28 Juanma Barranquero <lekktu@gmail.com>
7244
7245 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7246
db4f02f2
EZ
72472011-10-28 Eli Zaretskii <eliz@gnu.org>
7248
7249 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7250 <oslsachem@gmail.com> for helping to debug this.
7251
7252 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7253 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7254 (g_b_init_get_glyph_outline_w): New static variables.
7255 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7256 (GetGlyphOutlineW_Proc): New typedefs.
7257 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7258 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7259 New functions.
7260 (w32font_open_internal, compute_metrics):
7261 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7262 instead of calling the "wide" APIs directly.
7263
7264 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7265
7266 * w32.h (syms_of_w32font): Add prototype.
7267
87e68db4
JB
72682011-10-27 Juanma Barranquero <lekktu@gmail.com>
7269
7270 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7271 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7272 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7273 (Fmove_to_window_line): Doc fix.
7274
435c1d67
CY
72752011-10-27 Chong Yidong <cyd@gnu.org>
7276
7277 * process.c (make_process): Set gnutls_state to NULL.
7278
7279 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7280 non-NULL, regardless of GNUTLS_INITSTAGE.
7281 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7282 an error. Set process slots as soon as we allocate them.
7283
7284 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7285
9c6c6f49
CY
72862011-10-27 Chong Yidong <cyd@gnu.org>
7287
9aba6043
SM
7288 * gnutls.c (emacs_gnutls_deinit): New function.
7289 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7290 (Fgnutls_deinit, Fgnutls_boot): Use it.
7291
7292 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7293 (deactivate_process): Call emacs_gnutls_deinit.
7294
657d08d3
JB
72952011-10-27 Juanma Barranquero <lekktu@gmail.com>
7296
7297 * image.c (x_create_x_image_and_pixmap):
7298 * w32.c (sys_rename, w32_delayed_load):
7299 * w32font.c (fill_in_logfont):
7300 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7301
5430d399
JB
73022011-10-26 Juanma Barranquero <lekktu@gmail.com>
7303
7304 * w32fns.c (w32_default_color_map): New function,
7305 extracted from Fw32_default_color_map.
a7ef684b 7306 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7307
fe0055fa
PE
73082011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7309
7310 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7311
e6346438
SM
73122011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7313
7314 * keyboard.c (test_undefined): New function (bug#9751).
7315 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7316
e112cc37
ET
73172011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7318
7319 * sysdep.c (init_sys_modes): Fix the check for the controlling
7320 terminal (Bug#6649).
7321
7b5d6677
EZ
73222011-10-20 Eli Zaretskii <eliz@gnu.org>
7323
7324 * dispextern.h (struct bidi_it): New member next_en_type.
7325
7326 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7327 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7328 current character, check also for next_en_type being WEAK_EN.
7329 (bidi_resolve_weak): Don't enter the expensive loop if the current
7330 position is before next_en_pos. Record the bidi type of the first
7331 non-ET, non-BN character we find, in addition to its position.
7332 (bidi_level_of_next_char): Invalidate next_en_type when
7333 next_en_pos is over-stepped.
7334
7da0b018
PE
73352011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7336
7337 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7338 * editfns.c: Rewrite current-time-zone so that it invokes
7339 the equivalent of (format-time-string "%Z") to get the time zone name.
7340 This fixes a bug when the time zone name contains characters that
7341 need converting from the system time locale to Emacs internal format.
7342 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7343 that patch fixed format-time-string to do the conversion, but
7344 I forgot to fix current-time-zone.
7345 (format_time_string): New function, containing most of
7346 what Fformat_time_string used to contain.
7347 (Fformat_time_string): Rewrite in terms of format_time_string.
7348 This doesn't change this function's behavior.
7349 (current-time-zone): Rewrite to use format_time_string.
7350 This fixes the bug reported by Michael Schierl in
7351 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7352 Jason Rumney's 2007-06-07 change worked around this bug, but
7353 didn't fix it.
7354 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7355
8547b010
EZ
73562011-10-19 Eli Zaretskii <eliz@gnu.org>
7357
7358 * xdisp.c (start_display): If the character at POS is displayed
7359 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7360 (try_window_reusing_current_matrix): If a line ends in a display
7361 vector or the next line starts in a display vector, continue
7362 redrawing the window even though the character position of
7363 start_row was reached.
8547b010
EZ
7364 (Bug#9771, part 2)
7365
4e948d15
CY
73662011-10-18 Chong Yidong <cyd@gnu.org>
7367
7368 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7369 with nobreak-char-display too.
7370
4787455f
EZ
73712011-10-18 Eli Zaretskii <eliz@gnu.org>
7372
7373 Fix part 3 of bug#9771.
7374 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7375 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7376 non-neutral characters if the current character is a paragraph
7377 separator (a.k.a. Newline). This avoids running the same
7378 expensive loop twice, once when we consume the preceding newline
7379 and the other time when the line actually needs to be displayed.
7380 Avoid the loop when we see neutrals on the base embedding level
7381 following a character whose directionality is the same as the
7382 paragraph's. This avoids running the expensive loop when a line
7383 ends in a long sequence of neutrals, like control characters.
7384 Add assertion against STRONG_AL type. Slightly rearrange code
7385 that determines the type of a neutral given the first non-neutral
7386 that follows it.
7387 (bidi_level_of_next_char): Set next_en_pos to zero when
7388 invalidating its info.
7389
2c91f553
EZ
73902011-10-17 Eli Zaretskii <eliz@gnu.org>
7391
7392 * xdisp.c (push_display_prop): Determine whether to record string
7393 or buffer position by IT->string, not by IT->method. Allow
7394 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7395 (move_it_vertically_backward): Don't look for character position
7396 immediately after the newline when in a continuation line.
7397 (Bug#9771, part 1)
2c91f553 7398
c7b08b0d
MR
73992011-10-15 Martin Rudalics <rudalics@gmx.at>
7400
7401 * window.c (coordinates_in_window): Rewrite and delabelize
7402 vertical border check. (Bug#5357) (Bug#9618)
7403
6b02f655
SM
74042011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7405
7406 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7407 errors in XSetWindowBorder (bug#9310).
7408
81d40c92
DA
74092011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7410
7411 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7412 avoid crash when xmalloc overrun checking is enabled.
7413
d4172c3b
EZ
74142011-10-13 Eli Zaretskii <eliz@gnu.org>
7415
7416 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7417 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7418 cursor motion with <left> and <right> arrow keys.
7419
7420 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7421 some callers set that themselves.
7422
b00eea75
EZ
74232011-10-12 Eli Zaretskii <eliz@gnu.org>
7424
7425 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7426 display string and the previous row comes from the same string and
7427 is empty. (Bug#9739) (Bug#9738)
7428
8fe012c4
SM
74292011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7430
7431 * doc.c (get_doc_string): Encode file name (bug#9735).
7432
0074aef2
EZ
74332011-10-12 Eli Zaretskii <eliz@gnu.org>
7434
79beb178
EZ
7435 * bidi.c (bidi_level_of_next_char):
7436 * xdisp.c (get_visually_first_element): Remove old incorrect
7437 comments regarding the Unicode Line Separator character.
7438
0074aef2
EZ
7439 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7440
6e4b3fbe
DA
74412011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7442
7443 * alloc.c (Fgc_status): Do not access beyond zombies array
7444 boundary if nzombies > MAX_ZOMBIES.
7445 * alloc.c (dump_zombies): Add missing format specifier.
7446
0324f3af
PE
74472011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7448
b5525cac
PE
7449 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7450 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7451
0324f3af
PE
7452 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7453 Some packages use them to denote characters with modifiers.
7454
e9b5f888
AS
74552011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7456
7457 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7458 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7459 matching a pp-number. Rename parameter var to var1.
7460
127827c0
SM
74612011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7462
7463 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7464
c8fd3bd0
GM
74652011-10-08 Glenn Morris <rgm@gnu.org>
7466
7467 * callint.c (Fcall_interactively): Give a more explicit error for the
7468 'c' case with a non-character input. (Bug#8479)
7469
352ec8ff
EZ
74702011-10-08 Eli Zaretskii <eliz@gnu.org>
7471
03669ccb
EZ
7472 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7473 lines.
7061c986
EZ
7474 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7475 lines that are hscrolled on the left.
03669ccb 7476
352ec8ff
EZ
7477 * dispnew.c (buffer_posn_from_coords): Account for a possible
7478 presence of header-line. (Bug#4426)
7479
a66cfb1c
SM
74802011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7481
6b02f655
SM
7482 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7483 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7484
7c5ee88e
PE
74852011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7486
7487 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7488 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7489 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7490 this makes Emacs dump core during garbage collection on rare
7491 occasions. sizeof is obviously inferior to offsetof here, so
7492 stick with offsetof.
7493 (GC_POINTER_ALIGNMENT): New macro.
7494 (mark_memory): Omit 3rd (offset) arg; caller changed.
7495 Don't assume EMACS_INT alignment is the same as pointer alignment.
7496
df1bbe5b
SM
74972011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7498
7499 * keyboard.c (read_key_sequence_remapped): New var.
7500 (read_key_sequence): Compute remapping in the right buffer.
7501 (command_loop_1): Use read_key_sequence's remapping directly.
7502
51553db6
SM
75032011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7504
32c1fffd
SM
7505 * dired.c (file_name_completion): Don't expand file name.
7506 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7507 before checking file name handler.
7508
51553db6
SM
7509 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7510 they've been requested explicitly (bug#9591).
7511
b6bd1599 75122011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7513
7514 * keymap.c (Fsingle_key_description): Use make_specified_string
7515 instead of build_string to build string from push_key_description.
7516 (Bug#5193)
7517
f701dc2a
PE
75182011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7519
4222c55d
PE
7520 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7521 This fixes a Y2038 bug on 64-bit hosts.
7522 * buffer.c (reset_buffer):
7523 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7524 (Fclear_buffer_auto_save_failure):
7525 Use 0, not -1, to represent an unset failure time, since time_t
7526 might not be signed.
7527
f701dc2a
PE
7528 Remove dependency on glibc malloc internals.
7529 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7530 Move back here from lisp.h, but with their new implementations.
7531 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7532 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7533 * charset.c (charset_table_init): New static var.
7534 (syms_of_charset): Use it instead of xmalloc. This removes a
7535 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7536 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7537 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7538 Move back to alloc.c.
7539 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7540 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7541
9ceebf39
JD
75422011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7543
7544 * nsterm.m (windowDidResize): Call x_set_window_size only when
7545 ns_in_resize is true. Otherwise set pixelwidth/height and
7546 call change_frame_size (Bug#9628).
7547
cb993c58
PE
75482011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7549
3930c88b
PE
7550 Port --enable-checking=all to Fedora 14 x86-64.
7551 * charset.c (syms_of_charset): Also account for glibc malloc's
7552 internal overhead when calculating the initial malloc maximum.
7553
cb993c58
PE
7554 Port --enable-checking=all to Fedora 14 x86.
7555 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7556 Move to lisp.h.
7557 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7558 (overrun_check_realloc, overrun_check_free):
7559 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7560 That way, xmalloc returns a properly-aligned pointer even if
7561 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7562 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7563 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7564 into account when calculating the initial malloc maximum.
7565 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7566 Move here from alloc.c, so that charset.c can use it too.
7567 Properly align; the old code wasn't right for common 32-bit hosts
7568 when configured with --enable-checking=all.
7569 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7570 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7571
31bed486
EZ
75722011-09-29 Eli Zaretskii <eliz@gnu.org>
7573
04c70788 7574 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7575 use EDOM.
7576
fbcaa2f3
EZ
75772011-09-28 Eli Zaretskii <eliz@gnu.org>
7578
7579 * xdisp.c (compute_display_string_end): If there's no display
7580 string at CHARPOS, return -1.
7581
7582 * bidi.c (bidi_fetch_char): When compute_display_string_end
7583 returns a negative value, treat the character as a normal
7584 character not covered by a display string. (Bug#9624)
7585
a239d4e9
JB
75862011-09-28 Juanma Barranquero <lekktu@gmail.com>
7587
7588 * lread.c (Fread_from_string): Fix typo in docstring.
7589
88652fd5
EZ
75902011-09-27 Eli Zaretskii <eliz@gnu.org>
7591
7592 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7593 newline, reseat the iterator instead of bidi-iterating there one
7594 character at a time. (Bug#9610)
32c1fffd
SM
7595 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7596 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7597
ed497dd4
AS
75982011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7599
7600 * lread.c (readevalloop): Use correct code for NBSP.
7601 (read1): Likewise. (Bug#9608)
7602
b2bf61aa
MA
76032011-09-25 Michael Albinus <michael.albinus@gmx.de>
7604
7605 * dbusbind.c (Fdbus_register_signal): When service is not
7606 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7607
32bbb17c
GM
76082011-09-25 Glenn Morris <rgm@gnu.org>
7609
7610 * buffer.c (truncate-lines): Doc fix.
7611
94e0933e
CY
76122011-09-24 Chong Yidong <cyd@stupidchicken.com>
7613
7614 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7615 (Fset_window_next_buffers): Doc fix.
7616
cddde921
GM
76172011-09-24 Glenn Morris <rgm@gnu.org>
7618
7619 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7620
1260aef1
PE
76212011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7622
25b4bfa0
PE
7623 Fix minor problems found by static checking.
7624 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7625 * indent.c (Fvertical_motion): Fix == vs = typo.
7626
e3cbd34b
EZ
76272011-09-24 Eli Zaretskii <eliz@gnu.org>
7628
a66cfb1c
SM
7629 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7630 Default value is now t. Doc fix.
6bf7006f 7631
e3cbd34b 7632 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7633 logic when moving up, not only when moving down. Fix the
e3cbd34b 7634 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7635 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7636
7637 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7638 CHARPOS is covered by a display string which includes newlines.
7639 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7640 is covered by a display string with embedded newlines.
7641
a3de0cbd
MA
76422011-09-24 Michael Albinus <michael.albinus@gmx.de>
7643
7644 * dbusbind.c (Fdbus_register_signal): Add match rule to
7645 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7646 (Fdbus_register_method, Vdbus_registered_objects_table):
7647 Fix docstring.
a3de0cbd 7648
b260039d
JM
76492011-09-24 Jim Meyering <meyering@redhat.com>
7650
32c1fffd 7651 do not ignore write error for any output size
b260039d
JM
7652 The previous change was incomplete.
7653 While it makes emacs --batch detect the vast majority of stdout
7654 write failures, errors were still ignored whenever the output size is
7655 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7656 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7657 && echo FAIL: ignored write error
7658 FAIL: ignored write error
7659 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7660 && echo FAIL: ignored write error
7661 FAIL: ignored write error
7662 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7663
8eca8a7c
AS
76642011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7665
7666 * emacs.c (Fkill_emacs): In noninteractive mode exit
7667 non-successfully if a write error occurred on stdout. (Bug#9574)
7668
3341db62
EZ
76692011-09-21 Eli Zaretskii <eliz@gnu.org>
7670
7671 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7672 the xassert test.
7673
7674 * dispextern.h (struct it): Update the comment documenting what
7675 can it->OBJECT be.
7676
8c203dbf
EZ
76772011-09-20 Eli Zaretskii <eliz@gnu.org>
7678
7679 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7680 a display string, extend search for cursor position to end of row.
7681 (find_row_edges): If the row ends in a newline from a display
7682 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7683 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7684 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7685 non-empty line. Fixes confusing cursor motion with arrow keys at
7686 the beginning of a line that starts with whitespace.
8c203dbf 7687
a4824228
LMI
76882011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7689
7690 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7691 (bug#9493).
7692
33ed493b
CY
76932011-09-18 Chong Yidong <cyd@stupidchicken.com>
7694
7695 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7696 boolean (Bug#9154).
7697
56cd55c8
EZ
76982011-09-18 Eli Zaretskii <eliz@gnu.org>
7699
7700 * xdisp.c (display_line): Record maximum and minimum buffer
7701 positions even if no glyphs were produced (e.g., by a zero-width
7702 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7703 buffer positions that will be removed from the glyph row because
7704 they don't fit.
c02dcedf
EZ
7705 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7706 column is beyond frame width: don't subtract 1 "pixel" when
7707 computing width of the stretch.
3e62b7e0
EZ
7708 (reseat_at_next_visible_line_start): Undo the change made on
7709 2011-09-17 that saved paragraph information and restored it after
7710 the call to `reseat'. (Bug#9545)
56cd55c8 7711
5ed99d36 77122011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7713
7714 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7715 and turn window cursor on if cleared (Bug#9415).
7716
5ed99d36 77172011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7718
7719 * search.c (boyer_moore): Take unibyte characters from pattern
7720 literally. (Bug#9458)
7721
9bade7b2
EZ
77222011-09-18 Eli Zaretskii <eliz@gnu.org>
7723
7724 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7725
e5e9d610
PE
77262011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7727
87e4427a
PE
7728 Fix minor problem found by static checking.
7729 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7730 initialized, to pacify gcc -Wuninitialized.
7731
e5e9d610
PE
7732 * fileio.c: Report proper errno when syscall falls.
7733 (Finsert_file_contents): Save and restore errno,
7734 so that report_file_error outputs the correct diagnostic.
7735 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7736
a1674f0b
EZ
77372011-09-18 Eli Zaretskii <eliz@gnu.org>
7738
7739 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7740
fbfb6dd4
EZ
77412011-09-17 Eli Zaretskii <eliz@gnu.org>
7742
7743 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7744 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7745
bb187662
EZ
77462011-09-17 Eli Zaretskii <eliz@gnu.org>
7747
1137e8b8 7748 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7749 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7750
7751 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7752 (bidi_find_paragraph_start): Search back for paragraph beginning
7753 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7754 (bidi_move_to_visually_next): Only trigger paragraph-related
7755 computations when the last character is a newline or at EOB, not
7756 just any NEUTRAL_B. (Bug#9470)
7757
bb187662
EZ
7758 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7759 truncated lines if point is covered by a display string. (Bug#9524)
7760
2e621251
PE
77612011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7762
7763 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7764 (cons_to_x_long): New function.
7765 (lisp_data_to_selection_data): Use it. Correct the test for
7766 short-versus-long data; it was negated. Break out of vector
7767 loop, for efficiency, when a long datum is discovered.
7768
91a15bc6
SM
77692011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7770
7771 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7772
b41c3a35
EZ
77732011-09-16 Eli Zaretskii <eliz@gnu.org>
7774
7775 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7776 GCC PR/17406) by declaring this function with external scope.
7777
7812ba2d
PE
77782011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7779
7780 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7781 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7782
cf7edc2a
AS
77832011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7784
7785 * editfns.c (Fformat): Correctly handle text properties on "%%".
7786
bd01620e
EZ
77872011-09-15 Eli Zaretskii <eliz@gnu.org>
7788
7789 * xterm.c (x_draw_composite_glyph_string_foreground):
7790 * w32term.c (x_draw_composite_glyph_string_foreground):
7791 * term.c (encode_terminal_code):
7792 * composite.c (composition_update_it, get_composition_id):
7793 * xdisp.c (get_next_display_element)
7794 (fill_composite_glyph_string): Add comments about special meaning
7795 of TAB characters in a composition.
7796
a02719a3
PE
77972011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7798
7799 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7800 This occurs when processing a multibyte format.
7801 Problem reported by Wolfgang Jenker.
a02719a3 7802
72589a3c
JB
78032011-09-15 Johan Bockgård <bojohan@gnu.org>
7804
7805 * xdisp.c (try_cursor_movement): Only check for exact match if
7806 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7807
1c14176c
PE
78082011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7809
7810 Remove unused external symbols.
7811 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7812 * xdisp.c (calc_pixel_width_or_height): Now static.
7813 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7814 * indent.c (check_display_width):
7815 * w32term.c: Fix comment to match code.
7816 * xterm.c, xterm.h (x_catching_errors): Remove.
7817
d2eea5b5
PE
78182011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7819
7820 * xselect.c: Use signed conversions more consistently (Bug#9498).
7821 (selection_data_to_lisp_data): Assume incoming selection data are
7822 signed integers, not unsigned. This is to be consistent with
7823 outgoing selection data, which was modified to use signed integers
7824 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7825 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7826 expects long, not unsigned long.
7827
46888499
EZ
78282011-09-14 Eli Zaretskii <eliz@gnu.org>
7829
7830 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7831 computation of loop end. Reported by Johan Bockgård
7832 <bojohan@gnu.org>.
7833
ef8ef9fb
CY
78342011-09-13 Chong Yidong <cyd@stupidchicken.com>
7835
7836 * frame.c (Fother_visible_frames_p): Function deleted.
7837
fa819fed
EZ
78382011-09-12 Eli Zaretskii <eliz@gnu.org>
7839
7840 * indent.c (compute_motion): Process display vector front to back
7841 rather than the other way around. (Bug#2496)
7842
2ba8e008
SM
78432011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7844
7845 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7846
20f53c69
CY
78472011-09-11 Chong Yidong <cyd@stupidchicken.com>
7848
7849 * minibuf.c (Fread_from_minibuffer): Doc fix.
7850
d562d7a4
EZ
78512011-09-11 Eli Zaretskii <eliz@gnu.org>
7852
7853 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7854 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7855
1c4d7f3d
LMI
78562011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7857
7858 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7859 value for non-existent files.
7860
b885bf36
EZ
78612011-09-11 Eli Zaretskii <eliz@gnu.org>
7862
7863 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7864 set its "size" to -1. This will set the modtime_size field of
7865 the corresponding buffer to -1, which is what
7866 verify-visited-file-modtime expects for files that do not exist.
7867 (Bug#9139)
7868
6612f0bf
PE
78692011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7870
7871 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7872 here ...
7873 * lisp.h: ... from here. push_key_description is no longer
7874 defined in keyboard.c, so its declaration should not be in
7875 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7876 logically belongs with push_key_description.
7877
dfb3f755
PE
78782011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7879
7880 * buffer.h: Include <sys/types.h> instead of <time.h>.
7881 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7882 Problem reported by Herbert J. Skuhra.
7883
3134906c
LMI
78842011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7885
7886 * xml.c (parse_region): Make the parsing work for
7887 non-comment-starting XML files again (bug#9144).
7888
8d903f4e
AS
78892011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7890
7891 * image.c (gif_load): Fix calculation of bottom and right corner.
7892 (Bug#9468)
7893
80ad64f4
EZ
78942011-09-10 Eli Zaretskii <eliz@gnu.org>
7895
7896 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7897 redisplay in small windows.
7898
208a048d
EZ
78992011-09-09 Eli Zaretskii <eliz@gnu.org>
7900
7901 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7902
9b1c252e
MR
79032011-09-08 Martin Rudalics <rudalics@gmx.at>
7904
7905 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7906 Operate on live windows only.
7907
2949f33b
JB
79082011-09-08 Juanma Barranquero <lekktu@gmail.com>
7909
7910 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7911
e08dcafd
EZ
79122011-09-07 Eli Zaretskii <eliz@gnu.org>
7913
7914 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7915 only under bidi iteration.
7916
115b96bd
JD
79172011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7918
7919 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7920
c8199d0f
PE
79212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7922
7923 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7924 Without this fix, the command to link temacs failed due to an
7925 undefined symbol __builtin_isnan. This is because
7926 /usr/include/iso/math_c99.h #defines isnan(x) to
7927 __builtin_isnan(x), but the bundled gcc, which identifies itself
7928 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7929 a __builtin_isnan.
7930 * floatfns.c (isnan): #undef, and then #define to a clone of
7931 what's in data.c.
7932 (Fisnan): Always define, since it's always available now.
7933 (syms_of_floatfns): Always define isnan at the Lisp level.
7934
e39b275c 79352011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7936
7937 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7938
b2db44d9 79392011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7940
f4af5137 7941 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7942 The previous code assumed that file offsets (off_t values) fit in
7943 EMACS_INT variables, which is not true on typical 32-bit hosts.
7944 The code messed up by falsely reporting buffer overflow in cases
7945 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7946 when "big" contains more than 2**29 bytes, even though this
7947 inserts just one byte and does not overflow the buffer.
7948 (Finsert_file_contents): Store file offsets as off_t
7949 values, not as EMACS_INT values. Check for overflow when
7950 converting between EMACS_INT and off_t. When checking for
7951 buffer overflow or for overlap, take the offsets into account.
7952 Don't use EMACS_INT for small values where int suffices.
7953 When checking for overlap, fix a typo: ZV was used where
7954 ZV_BYTE was intended.
7955 (Fwrite_region): Don't assume off_t fits into 'long'.
7956 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7957
ecfc0a49
MA
79582011-09-05 Michael Albinus <michael.albinus@gmx.de>
7959
7960 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7961
6511acf2 79622011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7963
0999621a 7964 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7965
7966 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7967 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7968 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7969 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7970 (modify_event_symbol): Do not assume that the length of
7971 name_alist_or_stem is safe to alloca and fits in int.
7972 (Fexecute_extended_command): Likewise for function name and binding.
7973 (Frecursion_depth): Wrap around reliably on integer overflow.
7974 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7975 since some callers pass EMACS_INT values.
7976 (Fsingle_key_description): Don't crash if symbol name contains more
7977 than MAX_ALLOCA bytes.
7978 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7979 (get_minibuffer): Arg is now EMACS_INT, not int.
7980 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7981 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7982 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7983
2be7d702
PE
7984 * dbusbind.c (signature_cat): New function.
7985 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7986 Do not overrun buffer; instead, report string overflow.
7987
9d1df220
PE
7988 * dispnew.c (add_window_display_history): Don't overrun buffer.
7989 Truncate instead; this is OK since it's just a log.
7990
33ef5c64
PE
7991 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7992 even if the time zone offset is outlandishly large.
7993 Don't mishandle offset == INT_MIN.
7994
66c6fdd5
PE
7995 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7996 when creating daemon; the previous buffer-overflow check was incorrect.
7997
d749b01b
PE
7998 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7999 which has the guts of the old verror function.
8000
b5cd1905
PE
8001 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8002 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8003
6e1a67fb
PE
8004 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8005 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8006 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8007 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8008 length of string rather than counting it via multiple sprintfs;
8009 that's simpler and more reliable.
c21721cc
PE
8010 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8011 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8012 sprintf, in case result does not fit in int.
8013
c57b67fc
PE
8014 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8015 (fontset_from_font): Print it.
8016
8a401434
PE
8017 * frame.c (tty_frame_count): Now printmax_t, not int.
8018 (make_terminal_frame, set_term_frame_name): Print it.
8019 (x_report_frame_params): In X, window IDs are unsigned long,
8020 not signed long, so print them as unsigned.
8021 (validate_x_resource_name): Check for implausibly long names,
8022 and don't assume name length fits in 'int'.
8023 (x_get_resource_string): Don't blindly alloca invocation name;
8024 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8025 not fit in int.
8026
6e1a67fb
PE
8027 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8028 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8029 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8030
0df02bf3
PE
8031 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8032 Use esprintf, not sprintf, in case result does not fit in int.
8033
48e30793
PE
8034 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8035 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8036 it as a large positive number.
8037 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8038 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8039
a66ff6d8
PE
8040 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8041 in case result does not fit in int.
8042
aca216ff
PE
8043 * print.c (float_to_string): Detect width overflow more reliably.
8044 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8045 buffer overrun. Don't assume list length fits in 'int'. Treat
8046 print length of 0 as 0, not as infinity; to be consistent with other
8047 uses of print length in this function. Don't overflow print length
8048 index. Don't assume hash table size fits in 'long', or that
8049 vectorlike size fits in 'unsigned long'.
8050
31c286f7
PE
8051 * process.c (make_process): Use printmax_t, not int, to format
8052 process-name gensyms.
8053
55e5faa1
PE
8054 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8055
80f2e268
PE
8056 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8057 to avoid potential buffer overrun.
8058
670741ab
PE
8059 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8060 if X resource line is longer than 512 bytes.
8061
b7163a50
PE
8062 * xfns.c (x_window): Make sprintf buffer a bit bigger
8063 to avoid potential buffer overrun.
8064
ae58ff1f
PE
8065 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8066
c43c8a6a
PE
8067 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8068
3f8236f4
PE
80692011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8070
53e9fe90 8071 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8072 Without these, Emacs silently mishandles large integers sometimes.
8073 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8074 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8075
6511acf2
PE
8076 * xdisp.c (try_window_id): Check Emacs fixnum range before
8077 converting to 'int'.
806add1d 8078
6511acf2 8079 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8080 Check that an Emacs fixnum is in range before assigning it to 'int'.
8081 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8082 values converted from Emacs fixnums.
8083 (Frecenter): Don't wrap around a line count if it is out of 'int'
8084 range; instead, treat it as an extreme value.
8085 (Fset_window_configuration, compare_window_configurations):
8086 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8087
6511acf2
PE
8088 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8089 that can exceed INT_MAX. Check that EMACS_INT value is in range
8090 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8091 (match_limit): Don't assume that a fixnum can fit in 'int'.
8092
6511acf2 8093 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8094 exceed INT_MAX.
8095
6511acf2 8096 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8097 (Fvertical_motion): Don't wrap around LINES values that don't fit
8098 in 'int'. Instead, treat them as extreme values. This is good
8099 enough for windows, which can't have more than INT_MAX lines anyway.
8100
fcb901a7
LMI
81012011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8102
0f2f6b6d
LMI
8103 * Require libxml/parser.h to avoid compilation warning.
8104
fcb901a7
LMI
8105 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8106
8107 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8108 since this reportedly can destroy thread storage.
8109
6e20a0d4
CY
81102011-08-30 Chong Yidong <cyd@stupidchicken.com>
8111
8112 * syntax.c (find_defun_start): Update all cache variables if
8113 exiting early (Bug#9401).
8114
148ae00e
EZ
81152011-08-30 Eli Zaretskii <eliz@gnu.org>
8116
f6cfbd8f
EZ
8117 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8118
148ae00e
EZ
8119 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8120 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8121 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8122
8123 * term.c (tty_append_glyph): New function.
8124 (produce_stretch_glyph): Static function and its prototype deleted.
8125
a66cfb1c
SM
8126 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8127 Add prototypes.
148ae00e 8128
c4a07a4c
PE
81292011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8130
8131 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8132 when checking :margin (Bug#9390).
8133 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8134 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8135 so that the name doesn't mislead. All uses changed.
8136
6bc8cd65
JB
81372011-08-28 Johan Bockgård <bojohan@gnu.org>
8138
8139 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8140 set_tty_hooks.
8141
dca4927e
EZ
81422011-08-27 Eli Zaretskii <eliz@gnu.org>
8143
8144 * xdisp.c (move_it_to): Don't bail out early when reaching
8145 position beyond to_charpos, if we are scanning backwards.
8146 (move_it_vertically_backward): When DY == 0, make sure we get to
8147 the first character in the line after the newline.
8148
f2cad773
PE
81492011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8150
8151 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8152 (ccl_driver): Do not generate an out-of-range pointer.
8153 (Fccl_execute_on_string): Remove unnecessary check for
8154 integer overflow, noted by Stefan Monnier in
8155 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8156 Remove a FIXME that didn't need fixing.
8157 Simplify the newly-introduced buffer reallocation code.
8158
0cae2cdb
JB
81592011-08-27 Juanma Barranquero <lekktu@gmail.com>
8160
8161 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8162
5fc295a4 81632011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8164
70c60eb2 8165 Integer and memory overflow issues (Bug#9196).
726e0ab1 8166
d31850da
PE
8167 * doc.c (get_doc_string): Rework so that
8168 get_doc_string_buffer_size is the actual buffer size, rather than
8169 being 1 less than the actual buffer size; this makes xpalloc more
8170 convenient.
8171
a69fbedb
PE
8172 * image.c (x_allocate_bitmap_record, cache_image):
8173 * xselect.c (Fx_register_dnd_atom):
8174 Simplify previous changes by using xpalloc.
8175
fe5c5d37
PE
8176 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8177 since either will do and ptrdiff_t is convenient with xpalloc.
8178
0065d054
PE
8179 * charset.c (charset_table_size)
8180 (struct charset_sort_data.priority): Now ptrdiff_t.
8181 (charset_compare): Don't overflow if priorities differ greatly.
8182 (Fsort_charsets): Don't assume list length fits in int.
8183 Check for size-calculation overflow when allocating sort data.
8184 (syms_of_charset): Allocate an initial charset table that is
8185 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8186
8187 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8188
8189 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8190 The actual value is always <= INT_MAX, and leaving it unsigned made
8191 overflow checking harder.
8192
8193 * dispextern.h (struct glyph_matrix.rows_allocated)
8194 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8195 with xpalloc. The values are still always <= INT_MAX.
8196
8197 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8198
8199 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8200 (SAFE_NALLOCA): New macro.
8201
8202 * region-cache.c (struct boundary.pos, find_cache_boundary)
8203 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8204 (set_cache_region, invalidate_region_cache)
8205 (revalidate_region_cache, know_region_cache, region_cache_forward)
8206 (region_cache_backward, pp_cache):
8207 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8208 so that ptrdiff_t * can be passed to xpalloc.
8209 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8210 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8211 (pp_cache): Don't assume cache_len fits in int.
8212 * region-cache.h: Adjust extern decls to match.
8213
8214 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8215 EMACS_INT, since either will do, for xpalloc.
8216
8217 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8218 (xnmalloc, xnrealloc, xpalloc): New functions.
8219
726e0ab1
PE
8220 * bidi.c (bidi_shelve_header_size): New constant.
8221 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8222 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8223
51f30bc5 8224 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8225 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8226 (overlay_strings):
8227 Don't update size of array until after memory allocation succeeds,
8228 because xmalloc/xrealloc may not return.
0065d054
PE
8229 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8230 now that we have proper integer overflow checking.
8231 (record_overlay_string, overlay_strings): Catch overflows when
8232 calculating size of overlay_str_buf.
726e0ab1 8233
0065d054
PE
8234 * callproc.c (Fcall_process): Check for size overflow when
8235 calculating size of args2.
8236 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8237 Normally we prefer signed values, but sticking with ptrdiff_t would
8238 require adding more-complicated checks.
726e0ab1
PE
8239
8240 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8241 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8242 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8243 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8244
8245 * character.c (Fstring): Check for size-calculation overflow.
8246
8247 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8248 unnecessary integer overflow. Check for size overflow.
8249 (encode_coding_object): Don't update size until xmalloc succeeds.
8250
8251 * composite.c (get_composition_id): Check for overflow in glyph
8252 length calculations.
8253
8254 Integer and memory overflow fixes for display code.
8255 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8256 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8257 (scrolling_window): Check for overflow in size calculations.
8258 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8259 Don't assume glyph table len fits in int.
8260 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8261 (row_table_size): Now ptrdiff_t, not int.
8262 (scrolling_window): Avoid overflow in size calculations.
8263 Don't update size until allocation succeeds.
8264 * fns.c (concat): Check for overflow in size calculations.
8265 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8266 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8267 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8268
8269 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8270 (get_doc_string): Check for size calculation overflow.
8271 Don't update size until allocation succeeds.
8272 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8273 EMACS_INT, where ptrdiff_t will do.
8274 (Fsubstitute_command_keys): Check for string overflow.
8275
8276 * editfns.c (set_time_zone_rule): Don't assume environment length
8277 fits in int.
8278 (message_length): Now ptrdiff_t, not int.
8279 (Fmessage_box): Don't update size until allocation succeeds.
8280 Don't assume message length fits in int.
8281 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8282
0065d054
PE
8283 * emacs.c (main): Do not reallocate argv, since there is a null at
8284 the end that can be overwritten, and this way there's no need to
8285 worry about size-calculation overflow.
8286 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8287
8288 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8289 alloc succeeds.
8290 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8291
8292 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8293 (x_set_scroll_bar_width, x_figure_window_size):
8294 Check for integer overflow.
8295 (x_set_alpha): Do not assume XINT fits in int.
8296
8297 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8298 This is for the members text_lines, text_cols, total_lines, total_cols,
8299 where the system imposes an 'int' limit.
8300
8301 * fringe.c (Fdefine_fringe_bitmap):
8302 Don't update size until alloc works.
8303
8304 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8305 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8306
8307 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8308 Check for size-calculation overflow.
8309 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8310 do, as we prefer signed integers.
8311 (id_to_widget.max_size, id_to_widget.used)
8312 (xg_store_widget_in_map, xg_remove_widget_from_map)
8313 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8314 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8315 Use and return ptrdiff_t, not int.
8316 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8317 * gtkutil.h: Change prototypes to match the above.
8318
8319 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8320 are duplicate now that they've been promoted to lisp.h.
8321 (x_allocate_bitmap_record, x_alloc_image_color)
8322 (make_image_cache, cache_image, xpm_load):
8323 Don't update size until alloc is done.
8324 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8325 (x_detect_edges):
3256efce 8326 Check for size calculation overflow.
726e0ab1
PE
8327 (ct_colors_allocated_max): New constant.
8328 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8329 overflow.
3256efce 8330
726e0ab1
PE
8331 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8332 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8333 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8334 Use ptrdiff_t, not int, to count maps.
8335 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8336 calculations. Don't update size until allocation succeeds.
8337 Redo calculations to avoid overflow.
726e0ab1
PE
8338 * keyboard.h: Change prototypes to match the above.
8339
8340 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8341 to count maps.
8342 (current_minor_maps): Check for size calculation overflow.
8343 * keymap.h: Change prototypes to match the above.
8344
8345 * lread.c (read1, init_obarray): Don't update size until alloc done.
8346
8347 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8348 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8349
726e0ab1
PE
8350 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8351 Now ptrdiff_t, not int.
8352 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8353 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8354
8355 * process.c (Fnetwork_interface_list): Check for overflow
8356 in size calculation.
8357
8358 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8359
8360 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8361 overflow. Don't bother calling xmalloc when xrealloc will do.
8362
8363 * search.c (Freplace_match): Check for size calculation overflow.
8364 (Fset_match_data): Don't assume list lengths fit in 'int'.
8365
8366 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8367 for command line length. Do not attempt to address one before the
8368 beginning of an array, as that's not portable.
8369
8370 * term.c (max_frame_lines): Remove; unused.
8371 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8372 not int.
8373 (encode_terminal_code, calculate_costs): Check for size
8374 calculation overflow.
8375 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8376 table lengths and related sizes. Don't update size until alloc
8377 done. Redo calculations to avoid overflow.
8378 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8379
8380 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8381 subtracting pointers.
8382 (gobble_line): Check for overflow more carefully. Don't update size
8383 until alloc done.
8384
8385 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8386 Don't update size until alloc done.
8387 Redo size calculations to avoid overflow.
8388 Check for size calculation overflow.
0065d054 8389 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8390
8391 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8392 Use ptrdiff_t, not int, for sizes.
8393 (store_mode_line_noprop_char): Don't update size until alloc done.
8394
0065d054
PE
8395 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8396 Use ptrdiff_t, not int, for sizes.
8397 (Finternal_make_lisp_face, cache_face):
8398 Check for size calculation overflow.
8399 (cache_face): Treat size calculation overflows as if they were
8400 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8401
8402 * xfns.c (x_encode_text, x_set_name_internal)
8403 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8404 sizes, since they can exceed INT_MAX in size. Check for size
8405 calculation overflow.
8406
0065d054
PE
8407 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8408 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8409 Don't update size until alloc done.
8410
0065d054 8411 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8412 as sprintf is limited to int lengths.
1d526e2f 8413
252c5ee1
PE
8414 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8415 (X_LONG_MIN): New macros.
864d7ce7
PE
8416 Use them to make the following changes clearer.
8417 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8418 This change doesn't affect the value now, but it may help remind
8419 future maintainers not to raise the value too much later.
8420 (SELECTION_QUANTUM): Remove, replacing with ...
8421 (selection_quantum): ... new function, which avoids overflow.
8422 All uses changed.
8423 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8424 assumption that selection length fits in 'int'.
8425 (x_reply_selection_request, x_handle_selection_request)
8426 (x_get_window_property, receive_incremental_selection)
8427 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8428 (lisp_data_to_selection_data, clean_local_selection_data):
8429 Use ptrdiff_t, not int, to record length of selection.
8430 (x_reply_selection_request, x_get_window_property)
8431 (receive_incremental_selection, x_property_data_to_lisp):
8432 Redo calculations to avoid overflow.
8433 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8434 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8435 something.
8436 (x_get_window_property, receive_incremental_selection)
8437 (lisp_data_to_selection_data, x_property_data_to_lisp):
8438 Check for size-calculation overflow.
8439 (x_get_window_property, receive_incremental_selection)
8440 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8441 Don't store size until memory allocation succeeds.
8442 (x_get_window_property): Plug memory leak on memory exhaustion.
8443 Don't double-block input; malloc is safe here. Don't assume 2**34
8444 - 4 fits in unsigned long. Add an xassert to check
8445 XGetWindowProperty overflow. Be more careful about overflow
8446 calculations, and distinguish size from memory overflow better.
8447 (receive_incremental_selection): When tracing, don't assume
8448 unsigned int is less than INT_MAX.
8449 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8450 harmful) conversions of unsigned short to int.
8451 (lisp_data_to_selection_data): Don't assume that integers
8452 in the range -65535 through -1 fit in an X unsigned short.
8453 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8454 result parameters unless successful. Rely on cons_to_unsigned
8455 to report problems with elements; the old code wasn't right anyway.
8456 (x_check_property_data): Check for int overflow; we cannot use
8457 a wider type due to X limits.
8458 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8459
726e0ab1 8460 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8461
0065d054
PE
8462 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8463 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8464 (x_color_cells): Don't store size until memory allocation succeeds.
8465 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8466 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8467 (x_term_init): Don't assume length fits in int (sprintf is limited
8468 to int size).
bc18e09d 8469
ebfa62c0
PE
8470 Use ptrdiff_t for composition IDs.
8471 * character.c (lisp_string_width):
8472 * composite.c (composition_table_size, n_compositions)
8473 (get_composition_id, composition_gstring_from_id):
8474 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8475 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8476 * window.c (Frecenter):
8477 Use ptrdiff_t, not int, for composition IDs.
8478 * composite.c (get_composition_id): Check for integer overflow.
8479 * composite.h: Adjust prototypes to match the above changes.
8480
d3411f89
PE
8481 Use ptrdiff_t for hash table indexes.
8482 * category.c (hash_get_category_set):
8483 * ccl.c (ccl_driver):
8484 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8485 * coding.c (coding_system_charset_list, detect_coding_system):
8486 * coding.h (struct coding_system.id):
8487 * composite.c (get_composition_id, gstring_lookup_cache):
8488 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8489 * image.c (xpm_get_color_table_h):
8490 * lisp.h (hash_lookup, hash_put):
8491 * minibuf.c (Ftest_completion):
8492 Use ptrdiff_t for hash table indexes, not int (which is too
8493 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8494 32-bit --with-wide-int hosts).
8495
e097a6fa
PE
8496 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8497 Add a FIXME comment about memory leaks.
8498 (syms_of_charset): Don't assume xmalloc returns.
8499
5637687f
PE
8500 Don't assume that stated character widths fit in int.
8501 * character.c (Fchar_width, c_string_width, lisp_string_width):
8502 * character.h (CHAR_WIDTH):
8503 * indent.c (MULTIBYTE_BYTES_WIDTH):
8504 Use sanitize_char_width to avoid undefined and/or bad behavior
8505 with outlandish widths.
a66cfb1c 8506 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8507 now that we have two such functions. All uses changed.
8508 (sanitize_char_width): New inline function.
8509
a2271ba2
PE
8510 Don't assume that tab-width fits in int.
8511 * character.h (sanitize_width): New inline function.
8512 (SANE_TAB_WIDTH): New macro.
8513 (ASCII_CHAR_WIDTH): Use it.
8514 * indent.c (sane_tab_width): Remove. All uses replaced by
8515 SANE_TAB_WIDTH (current_buffer).
8516 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8517
18c52557
PE
8518 * fileio.c: Integer overflow issues with file modes.
8519 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8520
caeeedc1
PE
8521 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8522 Remove unreachable code.
8523 (read_hex, load_charset_map_from_file): Check for integer overflow.
8524
6df6ae42 8525 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8526 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8527 (x_send_scroll_bar_event): Likewise. Check that the size does not
8528 exceed limits imposed by XClientMessageEvent, as well as the usual
8529 ptrdiff_t and size_t limits.
8530
b13995db
PE
8531 * keyboard.c: Overflow, signedness and related fixes.
8532 (make_lispy_movement): Use same integer type in forward decl
8533 that is used in the definition.
8534 (read_key_sequence, keyremap_step):
8535 Change bufsize argument back to int, undoing my 2011-03-30 change.
8536 We prefer signed types, and int is wide enough here.
8537 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8538 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8539 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8540 length, not size_t. Use ptrdiff_t for index, not int.
8541 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8542 possibility of integer overflow.
8543
13464394
PE
8544 Overflow, signedness and related fixes for images.
8545
8546 * dispextern.h (struct it.stack[0].u.image.image_id)
8547 (struct_it.image_id, struct image.id, struct image_cache.size)
8548 (struct image_cache.used, struct image_cache.ref_count):
8549 * gtkutil.c (update_frame_tool_bar):
8550 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8551 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8552 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8553 * nsmenu.m (update_frame_tool_bar):
8554 * xdisp.c (calc_pixel_width_or_height):
8555 * xfns.c (image_cache_refcount):
8556 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8557 on typical 64-bit hosts.
8558
8559 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8560 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8561 Omit unnecessary casts to int.
8562 (parse_image_spec): Check that integers fall into 'int' range
8563 when the callers expect that.
8564 (image_ascent): Redo ascent calculation to avoid int overflow.
8565 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8566 (lookup_image): Remove unnecessary tests.
8567 (xbm_image_p): Locals are now of int, not EMACS_INT,
8568 since parse_image_check makes sure they fit into int.
8569 (png_load, gif_load, svg_load_image):
8570 Prefer int to unsigned where either will do.
8571 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8572 old tiff_error_handler and tiff_warning_handler.
8573 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8574 stack buffer overflows. It uses only the features of vsnprintf
8575 that are common to both POSIX and native Microsoft.
8576 (tiff_error_handler, tiff_warning_handler): Use it.
8577 (tiff_load, gif_load, imagemagick_load_image):
8578 Don't assume :index value fits in 'int'.
8579 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8580 (imagemagick_load_image): Check that crop parameters fit into
8581 the integer types that MagickCropImage accepts. Don't assume
8582 Vimagemagick_render_type has a nonnegative value. Don't assume
8583 size_t fits in 'long'.
8584 (gs_load): Use printmax_t to print the widest integers possible.
8585 Check for integer overflow when computing image height and width.
8586
c11821d4
EZ
85872011-08-26 Eli Zaretskii <eliz@gnu.org>
8588
8589 * xdisp.c (redisplay_window): Don't force window start if point
8590 will be invisible in the resulting window. (Bug#9324)
8591
0c95fcf7
EZ
85922011-08-25 Eli Zaretskii <eliz@gnu.org>
8593
8594 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8595 the display spec is of the form `(space ...)'.
8596 (handle_display_spec): Return the value returned by
8597 handle_single_display_spec, not just 1 or zero.
8598 (handle_single_display_spec): If the display spec is of the form
8599 `(space ...)', and specifies display in the text area, return 2
8600 rather than 1.
fee65a97 8601 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8602 accurately, and prefer exact match for point under bidi.
8603 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8604
8605 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8606 into disp_prop; all users changed.
8607
8608 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8609 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8610 for the text covered by the display property.
8611
e4ed06f1
CY
86122011-08-25 Chong Yidong <cyd@stupidchicken.com>
8613
8614 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8615 Change return value to nil.
8616 (Frecord_buffer): Delete unused function.
8617
f67cdd7f
EZ
86182011-08-24 Eli Zaretskii <eliz@gnu.org>
8619
5980d4c6
EZ
8620 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8621 buffers, return left-to-right.
8610fe8b
EZ
8622 (set_cursor_from_row): Consider candidate row a win if its glyph
8623 represents a newline and point is on that newline. Fixes cursor
8624 positioning on the newline at EOL of R2L text within L2R
8625 paragraph, and vice versa.
8626 (try_cursor_movement): Check continued rows, in addition to
8627 continuation rows. Fixes unwarranted scroll when point enters a
8628 continued line of R2L text within an L2R paragraph, or vice versa.
8629 (cursor_row_p): Consider the case of point being equal to
8630 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8631 from the end of a short line to the beginning of a continued line
8632 of R2L text within L2R paragraph.
8633 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8634 composed characters.
5980d4c6 8635
f67cdd7f
EZ
8636 * bidi.c (bidi_check_type): Use xassert.
8637 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8638 members.
8639
bca633fb
EZ
86402011-08-23 Eli Zaretskii <eliz@gnu.org>
8641
8642 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8643 a character.
8644
4a5885a7
CY
86452011-08-23 Chong Yidong <cyd@stupidchicken.com>
8646
8647 * nsfont.m (ns_otf_to_script): Fix typo.
8648
0902a04e
KH
86492011-08-22 Kenichi Handa <handa@m17n.org>
8650
8651 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8652 extra slot even if the purpose is char-code-property-table.
8653
1a2e6670
EZ
86542011-08-23 Eli Zaretskii <eliz@gnu.org>
8655
8ddde651
EZ
8656 * xdisp.c (redisplay_window): When computing centering_position,
8657 account for the height of the header line. (Bug#8874)
8658
425cc014
EZ
8659 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8660 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8661 candidate is selected by the mouse, and that candidate has a
8662 composed character under the mouse.
8663
1a2e6670
EZ
8664 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8665 coordinates reported by pos-visible-in-window-p for a composed
8666 character in column zero.
8667
8b76d6f8
SM
86682011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8669
8670 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8671
dac347dd
EZ
86722011-08-22 Eli Zaretskii <eliz@gnu.org>
8673
8674 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8675 consider it a hit if to_charpos is anywhere in the range of the
8676 composed buffer positions.
8677
e013fb34
CY
86782011-08-22 Chong Yidong <cyd@stupidchicken.com>
8679
8680 * image.c (gif_load): Don't assume that each subimage has the same
8681 dimensions as the base image. Handle disposal method that is
8682 "undefined" by the gif spec (Bug#9335).
8683
bd1ba3e8
CY
86842011-08-20 Chong Yidong <cyd@stupidchicken.com>
8685
8686 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8687 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8688
54a1215b
EZ
86892011-08-19 Eli Zaretskii <eliz@gnu.org>
8690
823564e5
EZ
8691 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8692 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8693 from an Org mode buffer to a Speedbar frame.
8694
54a1215b
EZ
8695 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8696 a composition, take its buffer position from IT->cmp_it.charpos.
8697 Fixes cursor positioning at the beginning of a line that begins
8698 with a composed character.
8699
9778ebcc
EZ
87002011-08-18 Eli Zaretskii <eliz@gnu.org>
8701
0be6ee06
EZ
8702 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8703 character bidirectional type, use STRONG_L instead. Fixes crashes
8704 in a buffer produced by `describe-categories'.
8705
9778ebcc
EZ
8706 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8707 members before the level stack, so they would be saved and
8708 restored when copying iterator state. Fixes incorrect reordering
8709 around TABs covered by display properties.
8710
156bffbe
AS
87112011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8712
6b02f655 8713 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8714
72ad093b
CY
87152011-08-17 Chong Yidong <cyd@stupidchicken.com>
8716
8717 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8718 (internal_condition_case_2, internal_condition_case_n):
8719 Remove unnecessary aborts (Bug#9081).
72ad093b 8720
35774242
EZ
87212011-08-17 Eli Zaretskii <eliz@gnu.org>
8722
8723 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8724 has no `load' handler, try opening the file locally. (Bug#9311)
8725
db76dd85
KB
87262011-08-16 Ken Brown <kbrown@cornell.edu>
8727
8728 * gmalloc.c: Expand comment.
8729
b215eee5
EZ
87302011-08-16 Eli Zaretskii <eliz@gnu.org>
8731
8732 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8733 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8734
a4579d33
KB
87352011-08-16 Ken Brown <kbrown@cornell.edu>
8736
8737 Fix memory allocation problems in Cygwin build (Bug#9273).
8738
8739 * unexcw.c ( __malloc_initialized): Declare external variable.
8740 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8741
8b76d6f8
SM
8742 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8743 New variables.
a4579d33
KB
8744 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8745 dumped emacs.
8746 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8747 in the static heap.
8748 [CYGWIN] (special_realloc): New function.
8749 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8750 requests to realloc storage in the static heap.
8751
3ebec551
PE
87522011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8753
8754 * bidi.c (bidi_initialize): Remove unused local.
8755
9fd8be00
EZ
87562011-08-15 Eli Zaretskii <eliz@gnu.org>
8757
6b02f655
SM
8758 * bidimirror.h:
8759 * biditype.h: Remove file.
8760 * makefile.w32-in ($(BLD)/bidi.$(O)):
8761 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8762
8763 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8764
8765 * chartab.c: Improve commentary for the uniprop_table API.
8766
32413314
EZ
8767 * bidi.c (bidi_paragraph_init): Support zero value of
8768 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8769 (bidi_initialize): Use uniprop_table instead of including
8770 biditype.h and bidimirror.h.
32413314 8771
9fd8be00
EZ
8772 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8773 coordinates of the iterator when restoring from ppos_it.
8774 (Bug#9296)
8775
5cf2b69b
KH
87762011-08-14 Kenichi Handa <handa@m17n.org>
8777
8778 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8779 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8780
daf17d00
EZ
87812011-08-14 Eli Zaretskii <eliz@gnu.org>
8782
8783 * xdisp.c (move_it_in_display_line_to): Don't invoke
8784 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8785 ppos_it. Fixes vertical cursor motion when line beginning is
8786 covered by an image. (Bug#9296)
8787
08e3161a
JD
87882011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8789
8790 * nsterm.h (ns_run_ascript): Declare.
8791 (NSAPP_DATA2_RUNASSCRIPT): Define.
8792
8793 * nsfns.m (as_script, as_result, as_status): New static variables.
8794 (ns_run_ascript): New function.
5e617bc2 8795 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8796 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8797 the event loop. Get status from as_status (Bug#7276).
8798
8799 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8800 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8801 the event loop (Bug#7276).
8802
a3720aa2
AS
88032011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8804
8805 * gnutls.c (QCgnutls_bootprop_priority)
8806 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8807 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8808 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8809 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8810 (QCgnutls_bootprop_verify_hostname_error)
8811 (QCgnutls_bootprop_callbacks_verify): Rename from
8812 Qgnutls_bootprop_..., all uses changed.
8813
8814 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8815 uses changed.
8816
0a0d27fb
PE
88172011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8818
19d5c50c
PE
8819 * xfaces.c (Qframe_set_background_mode): Now static.
8820 * dispextern.h (Qframe_set_background_mode): Remove decl.
8821
0a0d27fb
PE
8822 * process.c (Fnetwork_interface_info): Declare local only if needed.
8823
377538cb
JD
88242011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8825
8826 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8827 (Fnetwork_interface_list): Allocate in increments of bytes instead
8828 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8829 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8830 sockaddr.
8831 (struct ifflag_def): notrailers is smart on OSX.
8832 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8833 Get hardware address with getifaddrs if available.
8834
08fff70c
EZ
88352011-08-12 Eli Zaretskii <eliz@gnu.org>
8836
8837 * xdisp.c (iterate_out_of_display_property): xassert that
8838 IT->position is set to within IT->object's boundaries. Break from
8839 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8840 when IT->position is set up wrongly due to some bug.
8841 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8842 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8843 entry. Force push_it to save on the stack the current
8844 buffer/string position, to be restored by pop_it. Fix flags in
8845 the iterator structure wrt the object coming from a display
8846 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8847 properties. (Bug#9284)
8848
7be1c708 88492011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8850
7be1c708
CY
8851 * fontset.c (fontset_get_font_group): Add proper type checks.
8852 (Bug#9172)
aac0c6e3 8853
7be1c708 88542011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8855
7be1c708
CY
8856 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8857 and LC_VERSION_MIN_MACOSX.
8858 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8859 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8860
97bb72a6
EZ
88612011-08-08 Eli Zaretskii <eliz@gnu.org>
8862
8863 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8864 no-display-properties-and-no-overlays under bidi display.
8865 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8866 properties and overlays.
97bb72a6 8867
d5617611
CY
88682011-08-08 Chong Yidong <cyd@stupidchicken.com>
8869
37e11a63
CY
8870 * editfns.c (Fset_time_zone_rule): Document relationship with the
8871 setenv function.
8872
d5617611
CY
8873 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8874 the font entity extracted from the cache (Bug#8109).
8875
58872834
CY
88762011-08-07 Chong Yidong <cyd@stupidchicken.com>
8877
8878 * composite.c (autocmp_chars): Don't reset point. That is done by
8879 restore_point_unwind (Bug#5984).
8880
75bfc667
JL
88812011-08-07 Juri Linkov <juri@jurta.org>
8882
8883 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8884 to show the arg `TIME' instead of `TIMEVAL'.
8885
d1410150
EZ
88862011-08-06 Eli Zaretskii <eliz@gnu.org>
8887
8888 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8889 display property strides EOL and includes a newline, as in
8890 longlines-mode. (Bug#9254)
75b771e4
EZ
8891 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8892 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8893
8894 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8895 is non-zero, even if the data buffer is NULL. Fixes a crash in
8896 vertical-motion with longlines-mode. (Bug#9254)
8897
35928349
EZ
88982011-08-05 Eli Zaretskii <eliz@gnu.org>
8899
ec7cc85b
EZ
8900 * bidi.c <bidi_cache_total_alloc>: Now static.
8901 (bidi_initialize): Initialize bidi_cache_total_alloc.
8902
8b76d6f8 8903 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8904 cache. (Bug#9221)
8905
8906 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8907 amount allocated this far in `bidi_cache_total_alloc'.
8908 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8909 non-zero, only free the data buffer without restoring the cache
8910 contents. All callers changed.
8911
8912 * dispextern.h (bidi_unshelve_cache): Update prototype.
8913
8914 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8915 (move_it_in_display_line, move_it_to)
8916 (move_it_vertically_backward, move_it_by_lines): Replace the call
8917 to xfree to an equivalent call to bidi_unshelve_cache.
8918 (move_it_in_display_line_to): Fix logic of returning
412b6358 8919 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8920
e2e2423b
EZ
89212011-08-05 Eli Zaretskii <eliz@gnu.org>
8922
8923 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8924 came from a string character with a `cursor' property. (Bug#9229)
8925
ae9e757a
JD
89262011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8927
8928 * Makefile.in (LIB_PTHREAD): New variable.
8929 (LIBES): Add LIB_PTHREAD (Bug#9216).
8930
8931 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8932 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8933
213bd7f2
AS
89342011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8935
6b02f655 8936 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8937
99aaf75f
JD
89382011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8939
8940 * xterm.c (x_find_topmost_parent): New function.
8941 (x_set_frame_alpha): Find topmost parent window with
8942 x_find_topmost_parent and set the property there also (bug#9181).
8943 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8944
c74e9d86
PE
89452011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8946
8947 * callproc.c (Fcall_process): Avoid vfork clobbering
8948 the local vars buffer, coding_systems, current_dir.
8949
640c8776
SM
89502011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8951
8952 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8953
f26d0e4c
PE
89542011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8955
8a10d76c
PE
8956 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8957 so that it is not optimized away.
8958
f26d0e4c
PE
8959 * xdisp.c (compute_display_string_pos): Remove unused local.
8960
55439c61
EZ
89612011-08-02 Eli Zaretskii <eliz@gnu.org>
8962
8963 Fix slow cursor motion and scrolling in large buffers with
8964 selective display, like Org Mode buffers. (Bug#9218)
8965
8966 * dispextern.h (struct bidi_it): New member disp_prop_p.
8967
8968 * xdisp.c: Remove one-slot cache of display string positions.
8969 (compute_display_string_pos): Accept an additional argument
5e617bc2 8970 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8971 for a display string or property. If found, set DISP_PROP_P
8972 non-zero.
8973
8974 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8975 DISP_PROP_P, and pass it to compute_display_string_pos.
8976 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8977 non-zero. All callers of bidi_fetch_char changed.
8978
fb33fa43
SM
89792011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8980
8981 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8982
b099e063
DM
89832010-12-03 Don March <don@ohspite.net>
8984
8985 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8986 last character M-[char] is translated to ESC [char] (bug#7541).
8987
5cc7f7af
KH
89882011-08-02 Kenichi Handa <handa@m17n.org>
8989
d0fffa3f 8990 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8991
8992 * chartab.c (uniprop_table): Make it non-static.
8993
525d5e6e
EZ
89942011-08-01 Eli Zaretskii <eliz@gnu.org>
8995
8996 * xdisp.c (forward_to_next_line_start): Accept additional argument
8997 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8998 on the newline.
8999 (reseat_at_next_visible_line_start): Use the bidi iterator state
9000 returned by forward_to_next_line_start to restore the state of
9001 it->bidi_it after backing up to previous newline. (Bug#9212)
9002
31011111
AS
90032011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9004
9005 * regex.c (re_comp): Protoize.
9006 (re_exec): Fix return type.
9007 (regexec): Fix type of `ret'. (Bug#9203)
9008
476371c4
PE
90092011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9010
e5d76069
PE
9011 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9012 This is needed if max-image-size is a floating-point number.
9013
9a79b20c
AS
90142011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9015
9016 * print.c (print_object): Print empty symbol as ##.
9017
9018 * lread.c (read1): Read ## as empty symbol.
9019
d8c2fa78
AA
90202011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9021
9022 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9023 setting frame foreground color (Bug#9175).
9024 (x_set_background_color): Likewise.
9025
ffe57a7a
AA
9026 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9027 contents (Bug#9176).
9028 (EmacsTooltip -init): Remove bezels and add shadows to
9029 tooltip windows.
9030
bf3492a5
AA
9031 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9032 or scroll bar (Bug#8470).
9033
d55e9c53
AA
9034 * nsfont.m (nsfont_open): Remove assignment to voffset and
9035 unnecessary vars hshink, expand, hd, full_height, min_height.
9036 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9037
9038 * nsterm.h (nsfont_info): Remove voffset field.
9039
d8c2fa78 90402011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9041
9042 Implement strike-through and overline on NextStep (Bug#8863).
9043
9044 * nsfont.m (nsfont_open): Use underline position provided by font,
9045 instead of hard-coded value of 2.
9046 (nsfont_draw): Call ns_draw_text_decoration instead.
9047
9048 * nsterm.h: Add declaration for ns_draw_text_decoration.
9049
9050 * nsterm.m (ns_draw_text_decoration): New function for drawing
9051 underline, overline, and strike-through.
9052 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9053 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9054 accommodate underlining, etc.
4843aac3 9055
4cc60b9b
EZ
90562011-07-28 Eli Zaretskii <eliz@gnu.org>
9057
bc7ece87
EZ
9058 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9059 default.
4cc60b9b 9060
476371c4
PE
90612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9062
66606eea
PE
9063 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9064 Without this fix, if a signal arrives just after memory fills up,
9065 'malloc' might be invoked reentrantly.
9066
476371c4
PE
9067 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9068 In other words, assume that every image size is allowed, on non-X
9069 hosts. This assumption is probably wrong, but it lets Emacs compile.
9070
f3fcc40d
AS
90712011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9072
9073 * regex.c (re_iswctype): Convert return values to boolean.
9074
350c992f
EZ
90752011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9076
9077 * xdisp.c (compute_display_string_pos): Don't use cached display
9078 string position if the buffer had its restriction changed.
9079 (Bug#9184)
9080
5266b4bb
PE
90812011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9082
9083 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9084
2573a837 90852011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9086
41f55ccd 9087 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9088
39e378da
PE
9089 * bidi.c: Integer size and overflow fixes.
9090 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9091 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9092 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9093 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9094 (bidi_find_other_level_edge):
9095 Use ptrdiff_t instead of EMACS_INT where either will do.
9096 This works better on 32-bit hosts configured --with-wide-int.
9097 (bidi_cache_ensure_space): Check for size-calculation overflow.
9098 Use % rather than repeated addition, for better worst-case speed.
9099 Don't set bidi_cache_size until after xrealloc returns, because it
9100 might not return.
9101 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9102 (bidi_cache_ensure_space): Also check that the bidi cache size
9103 does not exceed that of the largest Lisp string or buffer. See Eli
9104 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9105
5e927815
PE
9106 * alloc.c (__malloc_size_t): Remove.
9107 All uses replaced by size_t. See Andreas Schwab's note
9108 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9109
ca4aa935
PE
9110 * image.c: Improve checking for integer overflow.
9111 (check_image_size): Assume that f is nonnull, since
9112 it is always nonnull in practice. This is one less thing to
9113 worry about when checking for integer overflow later.
9114 (x_check_image_size): New function, which checks for integer
9115 overflow issues inside X.
9116 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9117 This removes the need for a memory_full check.
9118 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9119 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9120 (xbm_read_bitmap_data): Change locals back to 'int', since
9121 their values must fit in 'int'.
9122 (xpm_load_image, png_load, tiff_load):
9123 Invoke x_create_x_image_and_pixmap earlier,
9124 to avoid much needless work if the image is too large.
9125 (tiff_load): Treat overly large images as if
9126 x_create_x_image_and_pixmap failed, not as malloc failures.
9127 (gs_load): Use x_check_image_size.
9128
5f8f9cc2
PE
9129 * gtkutil.c: Omit integer casts.
9130 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9131 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9132
5adf60bc
PE
9133 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9134
c8907a93
PE
9135 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9136 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9137 would wrongly return t on a 64-bit host.
9138
e3c25c68
PE
9139 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9140 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9141 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9142 and therefore cause GCC to emit a bogus diagnostic in some cases.
9143
3f791afe
PE
9144 * image.c: Integer signedness and overflow and related fixes.
9145 This is not an exhaustive set of fixes, but it's time to
9146 record what I've got.
9147 (lookup_pixel_color, check_image_size): Remove redundant decls.
9148 (check_image_size): Don't assume that arbitrary EMACS_INT values
9149 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9150 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9151 (tiff_load, imagemagick_load_image):
9152 Check for overflow in size calculations.
9153 (x_create_x_image_and_pixmap): Remove unnecessary test for
9154 xmalloc returning NULL; that can't happen.
9155 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9156 (xpm_color_bucket): Use better integer hashing function.
9157 (xpm_cache_color): Don't possibly over-allocate memory.
9158 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9159 (gif_memory_source):
9160 Use ptrdiff_t, not int or size_t, to record sizes.
9161 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9162 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9163 either works, as we prefer signed integers.
9164 (tiff_read_from_memory, tiff_write_from_memory):
9165 Return tsize_t, not size_t, since that's what the TIFF API wants.
9166 (tiff_read_from_memory): Don't fail simply because the read would
9167 go past EOF; instead, return a short read.
9168 (tiff_load): Omit no-longer-needed casts.
9169 (Fimagemagick_types): Don't assume size fits into 'int'.
9170
3cc5a532
PE
9171 Improve hashing quality when configured --with-wide-int.
9172 * fns.c (hash_string): New function, taken from sxhash_string.
9173 Do not discard information about ASCII character case; this
9174 discarding is no longer needed.
9175 (sxhash-string): Use it. Change sig to match it. Caller changed.
9176 * lisp.h: Declare it.
9177 * lread.c (hash_string): Remove, since we now use fns.c's version.
9178 The fns.c version returns a wider integer if --with-wide-int is
9179 specified, so this should help the quality of the hashing a bit.
9180
b312a492
PE
9181 * emacs.c: Integer overflow minor fix.
9182 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9183 Define only if GNU_LINUX.
9184 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9185
dfd153ae
PE
9186 * dispnew.c: Integer signedness and overflow fixes.
9187 Remove unnecessary forward decls, that were a maintenance hassle.
9188 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9189 All uses changed.
9190 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9191 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9192 (prepare_desired_row, line_draw_cost):
9193 Use int, not unsigned, where either works.
9194 (save_current_matrix, restore_current_matrix):
9195 Use ptrdiff_t, not size_t, where either works.
9196 (init_display): Check for overflow more accurately, and without
9197 relying on undefined behavior.
9198
a81d11a3
PE
9199 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9200 Remove, replacing with the new symbols in lisp.h. All uses changed.
9201 * fileio.c (make_temp_name):
9202 * filelock.c (lock_file_1, lock_file):
9203 * xdisp.c (message_dolog):
9204 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9205 Use pMd etc. instead.
9206 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9207 replacing the pWIDE etc. symbols removed from editfns.c.
9208
3300e6fd
PE
9209 * keyboard.h (num_input_events): Now uintmax_t.
9210 This is (very slightly) less likely to mess up due to wraparound.
9211 All uses changed.
9212
fd05c7e9
PE
9213 * buffer.c: Integer signedness fixes.
9214 (alloc_buffer_text, enlarge_buffer_text):
9215 Use ptrdiff_t rather than size_t when either will do, as we prefer
9216 signed integers.
9217
903fe15d
PE
9218 * alloc.c: Integer signedness and overflow fixes.
9219 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9220 (__malloc_size_t): Default to size_t, not to int.
9221 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9222 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9223 Prefer ptrdiff_t to size_t when either would do, as we prefer
9224 signed integers.
9225 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9226 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9227 Now const. Initialize with values that are in range even if char
9228 is signed.
9229 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9230 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9231 These functions do the right thing with sizes > 2**32.
9232 (check_depth): Now ptrdiff_t, not int.
9233 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9234 Adjust to new way of storing sizes. Check for size overflow bugs
9235 in rest of code.
9236 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9237 slightly wrong anyway, as it missed one instance of
9238 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9239 (refill_memory_reserve): Omit needless cast to size_t.
9240 (mark_object_loop_halt): Mark as externally visible.
9241
ac82cc6a
PE
9242 * xselect.c: Integer signedness and overflow fixes.
9243 (Fx_register_dnd_atom, x_handle_dnd_message):
9244 Use ptrdiff_t, not size_t, since we prefer signed.
9245 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9246 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9247 x_dnd_atoms_size and x_dnd_atoms_length.
9248
c2d1e36d
PE
9249 * doprnt.c: Prefer signed to unsigned when either works.
9250 * eval.c (verror):
9251 * doprnt.c (doprnt):
9252 * lisp.h (doprnt):
9253 * xdisp.c (vmessage):
9254 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9255 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9256 prefer signed arithmetic to avoid comparison confusion.
9257 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9258 but is a bit tricky.
9259
0e926e56
PE
9260 Assume freestanding C89 headers, string.h, stdlib.h.
9261 * data.c, doprnt.c, floatfns.c, print.c:
9262 Include float.h unconditionally.
9263 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9264 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9265 * regex.c: Likewise for stddef.h, string.h.
9266 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9267 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9268 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9269 (STDC_HEADERS): Remove obsolete defines.
9270 * sysdep.c: Include limits.h unconditionally.
9271
9cfdb3ec
PE
9272 Assume support for memcmp, memcpy, memmove, memset.
9273 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9274 * regex.c (memcmp, memcpy):
9275 Remove; we assume C89 now.
9276
9277 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9278 (__malloc_safe_bcopy): Remove; no longer needed.
9279
cf950e6b 9280 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9281 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9282 well either way, and we prefer signed to unsigned.
9283
dbf38e02
LMI
92842011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9285
9286 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9287 closes the connection while we're reading (bug#9182).
9288
d6f0886c 92892011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9290
d6f0886c
JD
9291 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9292 are specified (Bug#9168).
24e0f6b1 9293
2eb1f9e6
PE
92942011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9295
9296 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9297 Found by GCC static checking and --with-wide-int on a 32-bit host.
9298
22381272 92992011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9300
9301 * xdisp.c (compute_display_string_pos): Fix logic of caching
9302 previous display string position. Initialize cached_prev_pos to
9303 -1. Fixes slow-down at the beginning of a buffer.
9304
f25e39b4
EZ
93052011-07-24 Eli Zaretskii <eliz@gnu.org>
9306
9307 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9308 for attrs[LFACE_FONTSET_INDEX].
9309
04c4b52e
PE
93102011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9311
9312 * xml.c (parse_region): Remove unused local
9313 that was recently introduced.
9314
c1734fbd
EZ
93152011-07-23 Eli Zaretskii <eliz@gnu.org>
9316
be18c5a5
EZ
9317 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9318 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9319
c1734fbd
EZ
9320 * xdisp.c (move_it_in_display_line_to): Record the best matching
9321 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9322 exit if none of the characters scanned was an exact match.
9323 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9324 when exact match is impossible due to invisible text, and the
9325 lines are truncated.
9326
a258d627
JD
93272011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9328
9329 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9330 for OSX >= 10.7.
9331
b6d5a689
EZ
93322011-07-22 Eli Zaretskii <eliz@gnu.org>
9333
0f74f785
EZ
9334 Fix a significant slow-down of cursor motion with C-n, C-p,
9335 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9336 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9337 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9338 (next_element_from_buffer): Call compute_stop_pos_backwards to
9339 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9340 base_level_stop.
9341 (reseat): Don't look for prev_stop, as that could mean a very long
9342 run.
9343 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9344 <cached_disp_overlay_modiff>: Cache for last found display string
9345 position.
551918c1 9346 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9347 about the same buffer in the same area of character positions, and
9348 the buffer wasn't changed since the time the display string
9349 position was cached.
551918c1 9350
b2d0c91a
EZ
93512011-07-22 Eli Zaretskii <eliz@gnu.org>
9352
9353 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9354 is an integer, which is important for empty lines. (Bug#9149)
9355
043604ee
CY
93562011-07-22 Chong Yidong <cyd@stupidchicken.com>
9357
9358 * frame.c (Fmodify_frame_parameters): In tty case, update the
9359 default face if necessary (Bug#4238).
9360
da4adb04
CY
93612011-07-21 Chong Yidong <cyd@stupidchicken.com>
9362
9363 * editfns.c (Fstring_to_char): No need to explain what a character
9364 is in the docstring (Bug#6576).
9365
9abd0532
LMI
93662011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9367
9368 * xml.c (parse_region): Make sure we always return a tree.
9369
36881d16
HK
93702011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9371
9372 * xml.c (parse_region): If a document contains only comments,
9373 return that, too.
9374
1e98674d
LMI
93752011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9376
9377 * xml.c (make_dom): Return comments, too.
9378
590bd467
PE
93792011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9380
9381 Port to OpenBSD.
9382 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9383 and the surrounding thread.
9384 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9385 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9386 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9387 timer goes off.
9388 * s/openbsd.h (BROKEN_SIGIO): Define.
9389 * unexelf.c (unexec) [__OpenBSD__]:
9390 Don't update the .mdebug section of the Alpha COFF symbol table.
9391
f41628b2
LMI
93922011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9393
9394 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9395 (bug#8460).
9396
b59b67c5
PE
93972011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9398
15e3a074
PE
9399 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9400 This fixes some race conditions on the permissions of any newly
9401 created file.
9402
41bed37d
PE
9403 * alloc.c (valid_pointer_p): Use pipe, not open.
9404 This fixes some permissions issues when debugging.
9405
b59b67c5
PE
9406 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9407 If fchown fails to set both uid and gid, try to set just gid,
9408 as that is sometimes allowed. Adjust the file's mode to eliminate
9409 setuid or setgid bits that are inappropriate if fchown fails.
9410
925a6be7
SM
94112011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9412
9413 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9414 to compare Lisp_Objects.
9415 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9416 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9417 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9418
52968808
AS
94192011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9420
0a6a104b
AS
9421 * lread.c (read_integer): Unread even EOF character.
9422 (read1): Likewise. Properly record start position of symbol.
9423
52968808
AS
9424 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9425 symbol character follows.
9426
9e381cdd
PE
94272011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9428
9429 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9430 This works around a problem with the previous change to Fcopy_file.
9431 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9432 and without this change, GCC might complain about discarding
9433 fchown's return value.
9434
b5641435
JB
94352011-07-16 Juanma Barranquero <lekktu@gmail.com>
9436
9437 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9438
a8031457
PE
94392011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9440
9441 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9442
dd889327
LMI
94432011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9444
750c33f7
LMI
9445 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9446 it's used from the C level.
9447
dd889327
LMI
9448 * process.c: Use the same condition for POLL_FOR_INPUT in both
9449 keyboard.c and process.c (bug#1858).
9450
87e86684
LM
94512011-07-09 Lawrence Mitchell <wence@gmx.li>
9452
9453 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9454 (Fgnutls_boot): Use it.
9455
64348f40
AS
94562011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9457
9458 * doc.c (Fsubstitute_command_keys): Revert last change.
9459
1d698799
LMI
94602011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9461
f863868c
LMI
9462 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9463 quotes the next character, and doesn't affect other longer
9464 sequences (bug#8935).
9465
1d698799
LMI
9466 * lread.c (syms_of_lread): Clarify that is isn't only
9467 `eval-buffer' and `eval-defun' that's affected by
9468 `lexical-binding' (bug#8460).
9469
aa4b6df6
EZ
94702011-07-15 Eli Zaretskii <eliz@gnu.org>
9471
9472 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9473 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9474
5d856da6
PE
94752011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9476
ad6042bb
PE
9477 Fix minor problems found by static checking.
9478 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9479 (elsz): Now a signed constant, not a size_t var. We prefer signed
9480 types to unsigned, to avoid integer comparison confusion. Without
9481 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9482 "cannot optimize loop, the loop counter may overflow", a symptom
9483 of the confusion.
f00bbb22 9484 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9485 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9486
6468f31c
LMI
94872011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9488
49080b10
LMI
9489 * search.c (Fre_search_backward): Mention `case-fold-search' in
9490 all the re_search_* functions (bug#8138).
9491
6468f31c
LMI
9492 * keyboard.c (Fopen_dribble_file): Document when the file is
9493 closed (bug#8056).
9494
c965adc5
EZ
94952011-07-14 Eli Zaretskii <eliz@gnu.org>
9496
df9733bf
EZ
9497 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9498 bidi_cache_idx.
9499
0bb23927
EZ
9500 Support bidi reordering of display and overlay strings.
9501 * xdisp.c (compute_display_string_pos)
9502 (compute_display_string_end): Accept additional argument STRING.
9503 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9504 (reseat_to_string): Initialize bidi_it->string.s and
9505 bidi_it->string.schars.
9506 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9507 NULL (avoids a crash in bidi_paragraph_init).
9508 Initialize itb.string.lstring.
0bb23927
EZ
9509 (init_iterator): Call bidi_init_it only of a valid
9510 buffer position was specified. Initialize paragraph_embedding to
9511 L2R.
9512 (reseat_to_string): Initialize the bidi iterator.
9513 (display_string): If we need to ignore text properties of
9514 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9515 original value of -1 will not work with bidi.)
9516 (compute_display_string_pos): First arg is now struct
9517 `text_pos *'; all callers changed. Support display properties on
9518 Lisp strings.
9519 (compute_display_string_end): Support display properties on Lisp
9520 strings.
9521 (init_iterator, reseat_1, reseat_to_string): Initialize the
9522 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9523 when iterating on a string not from display properties).
640c8776
SM
9524 (compute_display_string_pos, compute_display_string_end):
9525 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9526 arrow keys.
9527 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9528 base_level_stop; instead, set base_level_stop to BEGV.
9529 Fixes crashes in vertical-motion.
0bb23927
EZ
9530 (next_element_from_buffer): Improve commentary for when
9531 the iterator is before prev_stop.
9532 (init_iterator): Initialize bidi_p from the default value of
9533 bidi-display-reordering, not from buffer-local value. Use the
9534 buffer-local value only if initializing for buffer iteration.
9535 (handle_invisible_prop): Support invisible properties on strings
9536 that are being bidi-reordered.
9537 (set_iterator_to_next): Support bidi reordering of C strings and
9538 Lisp strings.
9539 (next_element_from_string): Support bidi reordering of Lisp
9540 strings.
9541 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9542 (display_string): Support display of R2L glyph rows.
9543 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9544 (init_iterator): Don't initialize it->bidi_p for strings
9545 here.
9546 (reseat_to_string): Initialize it->bidi_p for strings here.
9547 (next_element_from_string, next_element_from_c_string)
9548 (next_element_from_buffer): Add xassert's for correspondence
9549 between IT's object being iterated and it->bidi_it.string
9550 structure.
9551 (face_before_or_after_it_pos): Support bidi iteration.
9552 (next_element_from_c_string): Handle the case of the first string
9553 character that is not the first one in the visual order.
9554 (get_visually_first_element): New function, refactored from common
9555 parts of next_element_from_buffer, next_element_from_string, and
9556 next_element_from_c_string.
9557 (tool_bar_lines_needed, redisplay_tool_bar)
9558 (display_menu_bar): Force left-to-right direction. Add a FIXME
9559 comment for making that be controlled by a user option.
9560 (push_it, pop_it): Save and restore the state of the
9561 bidi iterator. Save and restore the bidi_p flag.
9562 (pop_it): Iterate out of display property for string iteration as
9563 well.
9564 (iterate_out_of_display_property): Support iteration over strings.
9565 (handle_single_display_spec): Set up it->bidi_it for iteration
9566 over a display string, and call bidi_init_it.
9567 (handle_single_display_spec, next_overlay_string)
9568 (get_overlay_strings_1, push_display_prop): Set up the bidi
9569 iterator for displaying display or overlay strings.
9570 (forward_to_next_line_start): Don't use the shortcut if
9571 bidi-iterating.
9572 (back_to_previous_visible_line_start): If handle_display_prop
9573 pushed the iterator stack, restore the internal state of the bidi
9574 iterator by calling bidi_pop_it same number of times.
9575 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9576 and we are bidi-iterating, don't decrement the iterator position;
9577 instead, set the first_elt flag in the bidi iterator, to produce
9578 the same effect.
9579 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9580 (push_display_prop): xassert that we are iterating a buffer.
9581 (push_it, pop_it): Save and restore paragraph_embedding member.
9582 (handle_single_display_spec, next_overlay_string)
9583 (get_overlay_strings_1, reseat_1, reseat_to_string)
9584 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9585 correctly. Don't assume unibyte strings are not bidi-reordered.
9586 (compute_display_string_pos)
9587 (compute_display_string_end): Fix handling the case of C string.
9588 (push_it, pop_it): Save and restore from_disp_prop_p.
9589 (handle_single_display_spec, push_display_prop): Set the
9590 from_disp_prop_p flag.
9591 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9592 (pop_it): Call iterate_out_of_display_property only if we are
9593 popping after iteration over a string that came from a display
9594 property. Fix a typo in popping stretch info. Add an assertion
9595 for verifying that the iterator position is in sync with the bidi
9596 iterator.
9597 (handle_single_display_spec, get_overlay_strings_1)
9598 (push_display_prop): Fix initialization of paragraph direction for
9599 string when that of the parent object is not yet determined.
9600 (reseat_1): Call bidi_init_it to resync the bidi
9601 iterator with IT's position. (Bug#7616)
9602 (find_row_edges): If ROW->start.pos gives position
9603 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9604 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9605 Reset the from_disp_prop_p flag.
9606 (SAVE_IT, RESTORE_IT): New macros.
9607 (pos_visible_p, face_before_or_after_it_pos)
9608 (back_to_previous_visible_line_start)
9609 (move_it_in_display_line_to, move_it_in_display_line)
9610 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9611 (try_scrolling, redisplay_window, display_line): Use them when
9612 saving a temporary copy of the iterator and restoring it back.
9613 (back_to_previous_visible_line_start, reseat_1)
9614 (init_iterator): Empty the bidi cache "stack".
9615 (move_it_in_display_line_to): If iterator ended up at
9616 EOL, but we never saw any buffer positions smaller than
9617 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9618 motion in bidi-reordered lines.
9619 (move_it_in_display_line_to): Record prev_method and prev_pos
9620 immediately before the call to set_iterator_to_next. Fixes cursor
9621 motion in bidi-reordered lines with stretch glyphs and strings
9622 displayed in margins. (Bug#8133) (Bug#8867)
9623 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9624 TO_CHARPOS.
640c8776
SM
9625 (pos_visible_p): Support positions in bidi-reordered lines.
9626 Save and restore bidi cache.
0bb23927
EZ
9627
9628 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9629 (bidi_paragraph_info): Delete unused struct.
9630 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9631 (bidi_cache_start): New variable.
9632 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9633 to zero.
9634 (bidi_cache_fetch_state, bidi_cache_search)
9635 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9636 (bidi_cache_find, bidi_peek_at_next_level)
9637 (bidi_level_of_next_char, bidi_find_other_level_edge)
9638 (bidi_move_to_visually_next): Compare cache index with
9639 bidi_cache_start rather than with zero.
9640 (bidi_fetch_char): Accept new argument STRING; all callers
9641 changed. Support iteration over a string. Support strings with
9642 display properties. Support unibyte strings. Fix the type of
9643 `len' according to what STRING_CHAR_AND_LENGTH expects.
9644 (bidi_paragraph_init, bidi_resolve_explicit_1)
9645 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9646 (bidi_level_of_next_char, bidi_move_to_visually_next):
9647 Support iteration over a string.
0bb23927
EZ
9648 (bidi_set_sor_type, bidi_resolve_explicit_1)
9649 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9650 can now be zero (for strings); special values 0 and -1 were
9651 changed to -1 and -2, respectively.
9652 (bidi_char_at_pos): New function.
9653 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9654 Call it instead of FETCH_MULTIBYTE_CHAR.
9655 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9656 initialized to valid values.
9657 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9658 values.
9659 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9660 the test for valid cached positions. Fix the logic for looking up
9661 the sentinel state in the cache. GCPRO the Lisp string we are
9662 iterating.
9663 (bidi_push_it, bidi_pop_it): New functions.
9664 (bidi_initialize): Initialize the bidi cache start stack pointer.
9665 (bidi_cache_ensure_space): New function, refactored from part of
9666 bidi_cache_iterator_state. Don't assume the required size is just
9667 one BIDI_CACHE_CHUNK away.
9668 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9669 (bidi_count_bytes, bidi_char_at_pos): New functions.
9670 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9671 always valid if bidi_cache_idx is valid.
9672 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9673 is valid if it's going to be used.
9674 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9675 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9676 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9677 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9678 (bidi_find_other_level_edge, bidi_cache_start_stack):
9679 All variables related to cache indices are now EMACS_INT.
c965adc5 9680
0bb23927
EZ
9681 * dispextern.h (struct bidi_string_data): New structure.
9682 (struct bidi_it): New member `string'. Make flag members be 1-bit
9683 fields, and put them last in the struct.
640c8776
SM
9684 (compute_display_string_pos, compute_display_string_end):
9685 Update prototypes.
0bb23927
EZ
9686 (bidi_push_it, bidi_pop_it): Add prototypes.
9687 (struct iterator_stack_entry): New members bidi_p,
9688 paragraph_embedding, and from_disp_prop_p.
9689 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9690 (bidi_shelve_cache, bidi_unshelve_cache):
9691 Declare prototypes.
0bb23927
EZ
9692
9693 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9694 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9695 and vector-like objects.
9696
9697 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9698 cache around display iteration.
9699
9700 * window.c (Fwindow_end, window_scroll_pixel_based)
9701 (displayed_window_lines, Frecenter): Save and restore the bidi
9702 cache around display iteration.
9703
3bbd2265
LMI
97042011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9705
9706 * editfns.c (Fdelete_region): Clarify the use of the named
9707 parameters (bug#6788).
9708
adc47434
MR
97092011-07-14 Martin Rudalics <rudalics@gmx.at>
9710
9711 * indent.c (Fvertical_motion): Set and restore w->pointm when
9712 saving and restoring the window's buffer (Bug#9006).
9713
837c31f8
LMI
97142011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9715
9716 * editfns.c (Fstring_to_char): Clarify just what is returned
9717 (bug#6576). Text by Eli Zaretskii.
9718
ac389d0c
JB
97192011-07-13 Juanma Barranquero <lekktu@gmail.com>
9720
9721 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9722
0be0ce47
EZ
97232011-07-13 Eli Zaretskii <eliz@gnu.org>
9724
9725 * buffer.c (mmap_find): Fix a typo.
9726
cd18e7e3
JB
97272011-07-13 Johan Bockgård <bojohan@gnu.org>
9728
9729 Fix execution of x selection hooks.
9730 * xselect.c (Qx_lost_selection_functions)
9731 (Qx_sent_selection_functions): New vars.
9732 (syms_of_xselect): DEFSYM them.
9733 (x_handle_selection_request): Pass Qx_sent_selection_functions
9734 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9735 (x_handle_selection_clear,x_clear_frame_selections):
9736 Pass Qx_lost_selection_functions rather than
9737 Vx_lost_selection_functions to Frun_hook_with_args.
9738
47ea7f44
PE
97392011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9740
ac389d0c 9741 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9742 The old code sometimes used this field without initializing it.
9743
47ea7f44
PE
9744 * alloc.c (gc_sweep): Don't read past end of array.
9745 In theory, the old code could also have corrupted Emacs internals,
9746 though it'd be very unlikely.
9747
bc985c87
AS
97482011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9749
9750 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9751 argument. (Bug#4026)
bc985c87 9752
0cf34688
LMI
97532011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9754
b3dadd76
LMI
9755 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9756 key" (bug#4257).
9757
0cf34688
LMI
9758 * window.c (Fset_window_start): Doc fix (bug#4199).
9759 (Fset_window_hscroll): Ditto.
9760
270768cd
PE
97612011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9762
077e3dda 9763 Fix minor new problems caught by GCC 4.6.1.
270768cd 9764 * term.c (init_tty): Remove unused local.
490011a6 9765 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9766 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9767 not used otherwise.
270768cd 9768
b1f58454
CY
97692011-07-12 Chong Yidong <cyd@stupidchicken.com>
9770
9771 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9772
22b9578d
LMI
97732011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9774
6e70ab07
LMI
9775 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9776 are the mini-buffer and the echo area (bug#3320).
9777
22b9578d
LMI
9778 * term.c (init_tty): Remove support for supdup, c10 and perq
9779 terminals, which are no longer supported (bug#1482).
9780
8974cc9f
JB
97812011-07-10 Johan Bockgård <bojohan@gnu.org>
9782
9783 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9784
a560d974
JD
97852011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9786
9787 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9788 for non-popups (Bug#3642).
9789
1dae0f0a
AS
97902011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9791
268c2c36 9792 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9793 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9794 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9795 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9796 * data.c (fmod): Likewise.
9797 * dispnew.c (swap_glyphs_in_rows): Likewise.
9798 * emacs.c (memory_warning_signal): Likewise.
9799 * floatfns.c (float_error): Likewise.
9800 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9801 (otf_open, font_otf_capability, generate_otf_features)
9802 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9803 Likewise.
9804 * image.c (pbm_read_file): Likewise.
9805 * indent.c (string_display_width): Likewise.
9806 * intervals.c (check_for_interval, search_for_interval)
9807 (inc_interval_count, count_intervals, root_interval)
9808 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9809 * lread.c (defalias): Likewise.
268c2c36 9810 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9811 * regex.c (set_image_of_range_1, set_image_of_range)
9812 (regex_grow_registers): Likewise.
9813 * sysdep.c (strerror): Likewise.
9814 * termcap.c (valid_filename_p, tprint, main): Likewise.
9815 * tparam.c (main): Likewise.
9816 * unexhp9k800.c (run_time_remap, save_data_space)
9817 (update_file_ptrs, read_header, write_header, calculate_checksum)
9818 (copy_file, copy_rest, display_header): Likewise.
9819 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9820 Likewise.
9821 * xdisp.c (check_it): Likewise.
9822 * xfaces.c (register_color, unregister_color, unregister_colors):
9823 Likewise.
9824 * xfns.c (print_fontset_result): Likewise.
9825 * xrdb.c (member, fatal, main): Likewise.
9826
99033785
PE
98272011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9828
9829 Fix minor problems found by static checking (Bug#9031).
9830 * chartab.c (char_table_set_range, map_sub_char_table):
9831 Remove unused locals.
9832 (uniprop_table): Now static.
9833 * composite.c (_work_char): Remove unused static var.
9834
9cb2ac56
JB
98352011-07-09 Juanma Barranquero <lekktu@gmail.com>
9836
9837 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9838
f25661f0
JD
98392011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9840
9841 * gtkutil.c (qttip_cb): Remove code without function.
9842
8278c4fe
EZ
98432011-07-09 Eli Zaretskii <eliz@gnu.org>
9844
9845 * w32.c (pthread_sigmask): New stub.
9846
1692ae2d 98472011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9848
8a6ebd58 9849 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9850 sigprocmask is portable only for single-threaded applications, and
9851 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9852 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9853 (LIBES): Use it.
9854 * callproc.c (Fcall_process):
9855 * process.c (create_process):
9856 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9857 Use pthread_sigmask, not sigprocmask.
123403e4 9858
1b854618
JD
98592011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9860
9861 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9862 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9863 wrong (Bug#8591).
9864
3fe4b549
JD
98652011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9866
0ce7e563
JD
9867 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9868 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9869 (xg_hide_tooltip): Fix comment.
9870
3fe4b549
JD
9871 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9872 in registerServicesMenuSendTypes.
9873 (validRequestorForSendType): Don't check ns_return_types.
9874
9875 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9876 ns_return_type.
9877
5df75e47
JR
98782011-07-08 Jason Rumney <jasonr@gnu.org>
9879
22610910
JR
9880 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9881 SH_SHOW for hidden windows (Bug#5482).
9882
5df75e47
JR
9883 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9884 frame struct members of non-existent frames (Bug#6284).
9885
699c10bd
JD
98862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9887
4393663b
JD
9888 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9889 variable firstTime not needed on OSX >= 10.6.
9890 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9891 >= 10.5. Use setKnobProportion, setDoubleValue.
9892
9893 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9894 (MAC_OS_X_VERSION_10_5): Define if not defined.
9895 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9896 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9897 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9898
9899 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9900 cString and lossyCString on OSX >= 10.4.
4393663b 9901
58179cce 9902 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9903 sizeToFit on OSX >= 10.2.
9904
9905 * nsimage.m (allocInitFromFile): Don't use deprecated method
9906 bestRepresentationForDevice on OSX >= 10.6.
9907
9908 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9909 to avoid warning.
9910
9911 * emacs.c: Declare unexec_init_emacs_zone.
9912
a63e0781
JD
9913 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9914
699c10bd
JD
9915 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9916
9917 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9918 on svcsMenu (Bug#8842).
9919
9920 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9921 ns_return_types.
9922 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9923
9924 * nsterm.m (QUTF8_STRING): Declare.
9925 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9926 (validRequestorForSendType): Return type is (id).
9927 Change indexOfObjectIdenticalTo to indexOfObject.
9928 Check if we have local selection before returning self (Bug#8842).
9929 (writeSelectionToPasteboard): Put local selection into paste board
9930 if we have a local selection (Bug#8842).
9931 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9932
9933 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9934 (ns_get_local_selection): Declare.
9935
54e10184
LMI
99362011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9937
9888ff71
LMI
9938 * keymap.c (describe_map_tree): Don't insert a double newline at
9939 the end of the buffer (bug#1169) and return whether we inserted
9940 something.
9941
54e10184
LMI
9942 * callint.c (Fcall_interactively): Change "reading args" to
9943 "providing args" to try to clarify what it does (bug#1010).
9944
15fa4783
KH
99452011-07-07 Kenichi Handa <handa@m17n.org>
9946
9947 * composite.c (composition_compute_stop_pos): Ignore a static
9948 composition starting before CHARPOS (Bug#8915).
9949
9950 * xdisp.c (handle_composition_prop): Likewise.
9951
a8815b00
EZ
99522011-07-07 Eli Zaretskii <eliz@gnu.org>
9953
9954 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9955 (Bug#9015)
9956
ef7b981d 99572011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9958
9959 * character.h (unicode_category_t): New enum type.
9960
9961 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9962 (Qchar_code_property_table): New variable.
9963 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9964 (UNIPROP_COMPRESSED_FORM_P): New macros.
9965 (char_table_ascii): Uncompress the compressed values.
9966 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9967 Uncompress the compressed values.
ac389d0c 9968 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9969 (char_table_ref_and_range): Uncompress the compressed values.
9970 (sub_char_table_set): New arg is_uniprop. Callers changed.
9971 Uncompress the compressed values.
9972 (sub_char_table_set_range): Args changed. Callers changed.
9973 (char_table_set_range): Adjuted for the above change.
9974 (map_sub_char_table): Delete args default_val and parent. Add arg
9975 top. Give decoded values to a Lisp function.
640c8776 9976 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9977 values to a Lisp function. Gcpro more variables.
9978 (uniprop_table_uncompress)
9979 (uniprop_decode_value_run_length): New functions.
9980 (uniprop_decoder, uniprop_decoder_count): New variables.
9981 (uniprop_get_decoder, uniprop_encode_value_character)
9982 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9983 New functions.
9984 (uniprop_encoder, uniprop_encoder_count): New variables.
9985 (uniprop_get_encoder, uniprop_table)
9986 (Funicode_property_table_internal, Fget_unicode_property_internal)
9987 (Fput_unicode_property_internal): New functions.
9988 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9989 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9990 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9991 char-code-property-alist.
9992
640c8776 9993 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9994 Vunicode_category_table.
9995
640c8776 9996 * font.c (font_range): Adjust for the change of
c805dec0
KH
9997 Vunicode_category_table.
9998
76b397fb
DN
99992011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10000
10001 * m/iris4d.h: Remove file, move contents ...
10002 * s/irix6-5.h: ... here.
10003
22b4128e
PE
100042011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10005
10006 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10007 * alloc.c (mark_buffer):
10008 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10009 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10010 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10011 This isn't true in general, and it's particularly not true
10012 if Emacs is configured with --with-wide-int.
10013 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10014 New macros, used in the buffer.c change.
10015
869795d6
JD
100162011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10017
10018 * xsettings.c: Use both GConf and GSettings if both are available.
10019 (store_config_changed_event): Add comment.
10020 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10021 (store_tool_bar_style_changed): New functions.
5e617bc2 10022 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10023 (struct xsettings): Move font inside HAVE_XFT.
10024 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10025 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10026 Move inside HAVE_XFT.
640c8776 10027 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10028 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10029 also.
10030 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10031 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10032 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10033 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10034 (parse_settings): Move check for font inside HAVE_XFT.
10035 (read_settings, apply_xft_settings): Add comment.
10036 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10037 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10038 call store_font_name_changed.
10039 (xft_settings_event): Add comment.
10040 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10041 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10042 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10043 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10044 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10045 (xsettings_get_system_font, xsettings_get_system_normal_font):
10046 Add comment.
869795d6 10047
d8ed26bd
PE
100482011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10049
10050 Random fixes. E.g., (random) never returned negative values.
10051 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10052 subseconds part to the entropy, as that's a bit more random.
10053 Prefer signed to unsigned, since the signedness doesn't matter and
10054 in general we prefer signed. When given a limit, use a
10055 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10056 latter isn't right if USE_2_TAGS_FOR_INTS.
10057 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10058 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10059
cabf1cac
SM
100602011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10061
10062 * textprop.c (text_property_stickiness):
10063 Obey Vtext_property_default_nonsticky.
10064 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10065 * w32fns.c (syms_of_w32fns):
10066 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10067
6e9b2be9
PE
100682011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10069
10070 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10071 This is more efficient than Ffile_directory_p and avoids a minor race.
10072
90186c68
LMI
100732011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10074
7c301272
LMI
10075 * buffer.c (Foverlay_put): Say what the return value is
10076 (bug#7835).
10077
c4f2d8d4
LMI
10078 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10079 is a directory before asking whether to use the file name
10080 (bug#7564).
ad637907
LMI
10081 (barf_or_query_if_file_exists): Make the "File is a directory"
10082 error be more correct.
c4f2d8d4 10083
90186c68
LMI
10084 * fns.c (Frequire): Remove the mention of the .gz files, since
10085 that's installation-specific, but keep the mention of
10086 `get-load-suffixes'.
10087
da64016e
PE
100882011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10089
10090 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10091 Report string overflow if the output is too long.
10092
7d47b580
JB
100932011-07-04 Juanma Barranquero <lekktu@gmail.com>
10094
a555cb87
JB
10095 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10096 (syms_of_gnutls): Remove duplicate DEFSYM for
10097 Qgnutls_bootprop_verify_hostname_error, an error for
10098 Qgnutls_bootprop_verify_error (which is no longer used).
10099
7d47b580
JB
10100 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10101 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10102 Also (re)move comments that are misplaced or no longer relevant.
10103
1e49bfab
LMI
101042011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10105
10106 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10107
1485f4c0
CY
101082011-07-03 Chong Yidong <cyd@stupidchicken.com>
10109
10110 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10111 and background color parameters if they have been changed.
10112
a9ab721e
LMI
101132011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10114
10115 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10116
cf7cff57
PE
101172011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10118
2e13213d
PE
10119 * xsettings.c (SYSTEM_FONT): Define only when used.
10120 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10121
cf7cff57
PE
10122 * keymap.c (access_keymap_1): Now static.
10123
7a8e04f7
CY
101242011-07-02 Chong Yidong <cyd@stupidchicken.com>
10125
10126 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10127 leave any prefix arg for the up event (Bug#1586).
10128
61352f62
LMI
101292011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10130
69bb1ef7
LMI
10131 * lread.c (syms_of_lread): Mention single symbols defined by
10132 `defvar' or `defconst' (bug#7154).
10133
61352f62 10134 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10135 (Frequire): Mention get-load-suffixes.
61352f62 10136
28545e04
MR
101372011-07-02 Martin Rudalics <rudalics@gmx.at>
10138
10139 * window.h (window): Remove clone_number slot.
10140 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10141 Remove.
10142 (make_parent_window, make_window, saved_window)
10143 (Fset_window_configuration, save_window_save): Don't deal with
10144 clone numbers.
10145 * buffer.c (Qclone_number): Remove declaration.
10146 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10147
3349e122
SM
101482011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10149
10150 Add multiple inheritance to keymaps.
10151 * keymap.c (Fmake_composed_keymap): New function.
10152 (Fset_keymap_parent): Simplify.
10153 (fix_submap_inheritance): Remove.
10154 (access_keymap_1): New function extracted from access_keymap to handle
10155 embedded parents and handle lists of maps.
10156 (access_keymap): Use it.
10157 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10158 (Fcopy_keymap): Handle embedded parents.
10159 (Fcommand_remapping, define_as_prefix): Simplify.
10160 (Fkey_binding): Simplify.
10161 (syms_of_keymap): Move minibuffer-local-completion-map,
10162 minibuffer-local-filename-completion-map,
10163 minibuffer-local-must-match-map, and
10164 minibuffer-local-filename-must-match-map to Elisp.
10165 (syms_of_keymap): Defsubr make-composed-keymap.
10166 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10167 (parse_menu_item): Trivial simplification.
10168
3279eb87
GM
101692011-07-01 Glenn Morris <rgm@gnu.org>
10170
10171 * Makefile.in (SETTINGS_LIBS): Fix typo.
10172
39cb9e56 101732011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10174
10175 * coding.c (Fencode_coding_string): Record the last coding system
10176 used, as the function doc string says (bug#8738).
10177
0949d2b6
JD
101782011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10179
10180 * xsettings.c (store_monospaced_changed): Take new font as arg and
10181 check for change against current_mono_font.
10182 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10183 (emacs_settings_constructor, emacs_settings_get_property)
10184 (emacs_settings_set_property, emacs_settings_class_init)
10185 (emacs_settings_init, gsettings_obj): Remove.
10186 (something_changedCB): New function for HAVE_GSETTINGS.
10187 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10188 with value as argument.
10189 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10190 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10191 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10192 "changed".
10193
10194 * xgselect.c: Add defined (HAVE_GSETTINGS).
10195 (xgselect_initialize): Ditto.
10196
10197 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10198 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10199 xg_select.
10200
bbc6b304
PE
102012011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10202
10203 * eval.c (struct backtrace): Simplify and port the data structure.
10204 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10205 signed bit field, as this assumption is not portable and it makes
10206 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10207 "char debug_on_exit : 1" as this is not portable either; instead,
10208 use the portable "unsigned int debug_on_exit : 1". Remove unused
10209 member evalargs. Remove obsolete comments about cc bombing out.
10210
9851bfc5
JD
102112011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10212
51bb811f 10213 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10214 Let HAVE_GSETTINGS override HAVE_GCONF.
10215 (store_monospaced_changed): New function.
10216 (EMACS_SETTINGS): A new type derived from GObject to handle
10217 GSettings notifications.
10218 (emacs_settings_constructor, emacs_settings_get_property)
10219 (emacs_settings_set_property, emacs_settings_class_init):
10220 New functions.
10221 (gsettings_client, gsettings_obj): New variables.
10222 (GSETTINGS_SCHEMA): New define.
10223 (something_changedCB): Call store_monospaced_changed.
10224 (init_gsettings): New function.
10225 (xsettings_initialize): Call init_gsettings.
10226 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10227 to NULL.
10228
640c8776 10229 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10230 GCONF_CFLAGS/LIBS.
10231
5386012d
MR
102322011-06-29 Martin Rudalics <rudalics@gmx.at>
10233
10234 * window.c (resize_root_window, grow_mini_window)
10235 (shrink_mini_window): Rename Qresize_root_window to
10236 Qwindow_resize_root_window and Qresize_root_window_vertically to
10237 Qwindow_resize_root_window_vertically.
10238
f13e0b08
PE
102392011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10240
10241 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10242
94515237
JB
102432011-06-27 Juanma Barranquero <lekktu@gmail.com>
10244
10245 * makefile.w32-in: Redesign dependencies so they reflect more
10246 clearly which files are directly included by each source file,
10247 and not through other includes.
10248
e43b6e43
MR
102492011-06-27 Martin Rudalics <rudalics@gmx.at>
10250
10251 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10252 (sort_overlays, overlay_strings): When an overlay's clone number
10253 matches the window's clone number process the overlay even if
10254 the overlay's window property doesn't match the current window.
10255
d68443dc
MR
10256 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10257 (Fwindow_hchild): Rename to Fwindow_left_child.
10258 (Fwindow_next): Rename to Fwindow_next_sibling.
10259 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10260 (resize_window_check): Rename to window_resize_check.
10261 (resize_window_apply): Rename to window_resize_apply.
10262 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10263 (Fdelete_other_windows_internal, resize_frame_windows)
10264 (Fsplit_window_internal, Fdelete_window_internal)
10265 (grow_mini_window, shrink_mini_window)
10266 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10267
c7e73be5
JD
102682011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10269
10270 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10271 (emacs_fixed_set_min_size): Remove.
10272 (emacs_fixed_new): Take frame as argument.
10273
10274 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10275 (_EmacsFixedPrivate): Remove minwidth/height.
10276 Add struct frame *f.
10277 (emacs_fixed_init): Initialize priv->f.
10278 (get_parent_class, emacs_fixed_set_min_size): Remove.
10279 (emacs_fixed_new): Set priv->f to argument.
10280 (emacs_fixed_get_preferred_width)
10281 (emacs_fixed_get_preferred_height): Use min_width/height from
10282 frames size_hint to set minimum and natural (Bug#8919).
10283 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10284 and use min_width/height from frames size_hint to set
10285 min_width/height (Bug#8919).
10286
10287 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10288 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10289 Fix indentation.
c7e73be5 10290
cf99dcf8
EZ
102912011-06-26 Eli Zaretskii <eliz@gnu.org>
10292
10293 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10294 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10295 called at ZV.
10296
029529ac
CY
102972011-06-26 Chong Yidong <cyd@stupidchicken.com>
10298
10299 * process.c (wait_reading_process_output): Bypass select if
10300 waiting for a cell while ignoring keyboard input, and input is
10301 pending. Suggested by Jan Djärv (Bug#8869).
10302
7a7ef429
PE
103032011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10304
10305 Use gnulib's dup2 module instead of rolling our own.
10306 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10307
11fdef7d 103082011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10309
10310 * dispnew.c (scrolling_window): Before scrolling, turn off a
10311 mouse-highlight in the window being scrolled.
10312
cd3520a4
JB
103132011-06-24 Juanma Barranquero <lekktu@gmail.com>
10314
10315 Move DEFSYM to lisp.h and use everywhere.
10316
10317 * character.h (DEFSYM): Move declaration...
10318 * lisp.h (DEFSYM): ...here.
10319
10320 * gnutls.c:
10321 * minibuf.c:
10322 * w32menu.c:
10323 * w32proc.c:
10324 * w32select.c: Don't include character.h.
10325
10326 * alloc.c (syms_of_alloc):
10327 * buffer.c (syms_of_buffer):
10328 * bytecode.c (syms_of_bytecode):
10329 * callint.c (syms_of_callint):
10330 * casefiddle.c (syms_of_casefiddle):
10331 * casetab.c (init_casetab_once):
10332 * category.c (init_category_once, syms_of_category):
10333 * ccl.c (syms_of_ccl):
10334 * cmds.c (syms_of_cmds):
10335 * composite.c (syms_of_composite):
10336 * dbusbind.c (syms_of_dbusbind):
10337 * dired.c (syms_of_dired):
10338 * dispnew.c (syms_of_display):
10339 * doc.c (syms_of_doc):
10340 * editfns.c (syms_of_editfns):
10341 * emacs.c (syms_of_emacs):
10342 * eval.c (syms_of_eval):
10343 * fileio.c (syms_of_fileio):
10344 * fns.c (syms_of_fns):
10345 * frame.c (syms_of_frame):
10346 * fringe.c (syms_of_fringe):
10347 * insdel.c (syms_of_insdel):
10348 * keymap.c (syms_of_keymap):
10349 * lread.c (init_obarray, syms_of_lread):
10350 * macros.c (syms_of_macros):
10351 * msdos.c (syms_of_msdos):
10352 * print.c (syms_of_print):
10353 * process.c (syms_of_process):
10354 * search.c (syms_of_search):
10355 * sound.c (syms_of_sound):
10356 * syntax.c (init_syntax_once, syms_of_syntax):
10357 * terminal.c (syms_of_terminal):
10358 * textprop.c (syms_of_textprop):
10359 * undo.c (syms_of_undo):
10360 * w32.c (globals_of_w32):
10361 * window.c (syms_of_window):
10362 * xdisp.c (syms_of_xdisp):
10363 * xfaces.c (syms_of_xfaces):
10364 * xfns.c (syms_of_xfns):
10365 * xmenu.c (syms_of_xmenu):
10366 * xsettings.c (syms_of_xsettings):
10367 * xterm.c (syms_of_xterm): Use DEFSYM.
10368
4228cf16
TZ
103692011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10370
cd3520a4 10371 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10372
7fcccf1e
PE
103732011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10374
7efb4e0e
PE
10375 Integer and buffer overflow fixes (Bug#8873).
10376
ff5844ad
PE
10377 * print.c (printchar, strout): Check for string overflow.
10378 (PRINTPREPARE, printchar, strout):
10379 Don't set size unless allocation succeeds.
10380
90532f02
PE
10381 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10382 for sizes. Check for string overflow more accurately.
10383 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10384
6d84508d
PE
10385 * macros.c: Integer and buffer overflow fixes.
10386 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10387 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10388 Use ptrdiff_t, not int, for sizes.
10389 Don't increment bufsize until after realloc succeeds.
10390 Check for size-calculation overflow.
10391 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10392
437b2cb4
PE
10393 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10394
8b9ac8b4
PE
10395 * lread.c: Integer overflow fixes.
10396 (read_integer): Radix is now EMACS_INT, not int,
10397 to improve quality of diagnostics for out-of-range radices.
10398 Calculate buffer size correctly for out-of-range radices.
10399 (read1): Check for integer overflow in radices, and in
10400 read-circle numbers.
82cb60d3
PE
10401 (read_escape): Avoid int overflow.
10402 (Fload, openp, read_buffer_size, read1)
10403 (substitute_object_recurse, read_vector, read_list, map_obarray):
10404 Use ptrdiff_t, not int, for sizes.
10405 (read1): Use EMACS_INT, not int, for sizes.
20270765 10406 Check for size overflow.
8b9ac8b4 10407
7fcccf1e
PE
10408 * image.c (cache_image): Check for size arithmetic overflow.
10409
bfbbd7e7
PE
10410 * lread.c: Integer overflow issues.
10411 (saved_doc_string_size, saved_doc_string_length)
10412 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10413 Now ptrdiff_t, not int.
10414 (read1): Don't assume doc string length fits in int. Check for
10415 out-of-range doc string lengths.
10416 (read_list): Don't assume file position fits in int.
39019e54 10417 (read_escape): Check for hex character overflow.
bfbbd7e7 10418
4e323265
LL
104192011-06-22 Leo Liu <sdl.web@gmail.com>
10420
10421 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10422 Move to minibuffer.el.
10423
85fece3e
PE
104242011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10425
20b84ce9 10426 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10427 The following patches are for when GLYPH_DEBUG && !XASSERT.
10428 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10429 * dispnew.c (flush_stdout):
10430 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10431 Mark as externally visible.
10432 * dispnew.c (check_window_matrix_pointers): Now static.
10433 * dispnew.c (window_to_frame_vpos):
10434 * xfns.c (unwind_create_frame):
10435 * xterm.c (x_check_font): Remove unused local.
10436 * scroll.c (CHECK_BOUNDS):
10437 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10438 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10439 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10440 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10441 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10442 Now static.
10443 (debug_method_add): Use va_list and vsprintf rather than relying
10444 on undefined behavior with wrong number of arguments.
10445 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10446 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10447 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10448 since we're not interested in debugging glyphs with old libraries.
10449 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10450 GCC 4.6.0's static checking.
10451
0766b489
PE
104522011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10453
31fd4b32
PE
10454 Integer overflow and signedness fixes (Bug#8873).
10455 A few related buffer overrun fixes, too.
10456
b79e8648
PE
10457 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10458
0766b489
PE
10459 * dispextern.h (struct face.stipple):
10460 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10461 (x_bitmap_mask, x_allocate_bitmap_record)
10462 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10463 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10464 (x_create_bitmap_from_xpm_data):
10465 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10466 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10467 (.bitmaps_last):
10468 * xfaces.c (load_pixmap):
10469 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10470 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10471 (.bitmaps_last, struct x_output.icon_bitmap):
10472 Use ptrdiff_t, not int, for bitmap indexes.
10473 (x_allocate_bitmap_record): Check for size overflow.
10474 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10475
b081724f
PE
10476 Use ptrdiff_t, not int, for overlay counts.
10477 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10478 * editfns.c (overlays_around, get_pos_property):
10479 * textprop.c (get_char_property_and_overlay):
10480 * xdisp.c (next_overlay_change, note_mouse_highlight):
10481 * xfaces.c (face_at_buffer_position):
21514da7
PE
10482 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10483 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10484 (Fnext_overlay_change, Fprevious_overlay_change)
10485 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10486 Use ptrdiff_t, not int, for sizes.
21514da7 10487 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10488
3de73e5e
PE
10489 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10490
2606c57b
PE
10491 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10492 (x_session_initialize): Do not assume string length fits in int.
10493
aaafe47a
PE
10494 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10495 This is unlikely, but can occur if DPI is outlandish.
10496
2674ddc8 10497 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10498 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10499
28154962
PE
10500 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10501 * xrdb.c (magic_file_p, search_magic_path):
10502 Omit last arg SUFFIX; it was always 0. All callers changed.
10503 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10504
7de51af5
PE
10505 * xfont.c (xfont_match): Avoid need for strlen.
10506
25ed6cc3
PE
10507 * xfns.c: Don't assume strlen fits in int.
10508 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10509
4eab31dd
PE
10510 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10511 not unsigned long, as we prefer signed integers. All callers changed.
10512 Detect integer overflow in repeat count.
10513 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10514 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10515
171e2a58
PE
10516 * termcap.c: Don't assume sizes fit in int and never overflow.
10517 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10518 (gobble_line): Check for size-calculation overflow.
10519
ad39faca 10520 * minibuf.c (Fread_buffer):
6e5bb2dc 10521 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10522 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10523 Don't assume string length fits in int.
10524
52c61c22 10525 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10526 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10527
b5b8c9e5
PE
10528 * font.c: Don't assume string length fits in int.
10529 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10530 Use ptrdiff_t, not int.
ccd6111c
PE
10531 (font_intern_prop): Don't assume string length fits in int.
10532 Don't assume integer property fits in fixnum.
10533 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10534
882f0d81 10535 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10536 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10537 Reformulate so as not to need the command string.
10538 Invoke gzip -cd rather than gunzip, as it's more portable.
10539 (lock_info_type, lock_file_1, lock_file):
10540 Don't assume pid_t and time_t fit in unsigned long.
10541 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10542 (current_lock_owner): Prefer signed type for sizes.
10543 Use memcpy, not strncpy, where memcpy is what is really wanted.
10544 Don't assume (via atoi) that time_t and pid_t fit in int.
10545 Check for time_t and/or pid_t out of range, e.g., via a network share.
10546 Don't alloca where an auto var works fine.
10547
93f4cf88
PE
10548 * fileio.c: Fix some integer overflow issues.
10549 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10550 Don't assume string length fits in int.
10551 (directory_file_name): Don't assume string length fits in long.
10552 (make_temp_name): Don't assume pid fits in int, or that its print
10553 length is less than 20.
10554
f3e92b69
PE
10555 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10556
1bfdaf10
PE
10557 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10558
35016e9a
PE
10559 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10560
3d1e65a1
PE
10561 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10562 We prefer signed integers, even for size calculations.
10563
0b963a93
PE
10564 * emacs.c: Don't assume string length fits in 'int'.
10565 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10566 (main): Don't invoke strlen when not needed.
10567
573f4b54
PE
10568 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10569 (XD_DEBUG_MESSAGE): Don't waste a byte.
10570
989f33ba
PE
10571 * callproc.c (getenv_internal_1, getenv_internal)
10572 (Fgetenv_internal):
965d34eb
PE
10573 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10574
e4d29b33
PE
10575 * lread.c (invalid_syntax): Omit length argument.
10576 All uses changed. This doesn't fix a bug, but it simplifies the
10577 code away from its former Hollerith-constant appearance, and it's
10578 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10579 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10580
eb49b136
PE
10581 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10582 This didn't break anything, but it didn't help either.
10583 It's confusing to put a bogus integer in a place where the actual
10584 value does not matter.
9f62aeb1 10585 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10586 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10587
15375a22
PE
10588 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10589 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10590 implementation.
b61cc01c
PE
10591 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10592 We prefer signed types, and the value cannot exceed the EMACS_INT
10593 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10594 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10595 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10596 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10597
53b2623d
PE
10598 * indent.c (sane_tab_width): New function.
10599 (current_column, scan_for_column, Findent_to, position_indentation)
10600 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10601 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10602
51cab52b 10603 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10604
f2ed8a70
PE
10605 * lisp.h (lint_assume): New macro.
10606 * composite.c (composition_gstring_put_cache):
10607 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10608
abe80cc6
PE
10609 * editfns.c, insdel.c:
10610 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10611
b02c740e
PE
10612 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10613
ebc96716
PE
10614 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10615
b4e50fa0 10616 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10617 Use much-faster test for byte-length change.
311d5d7c 10618 Don't assume string byte-length fits in 'int'.
a4cf38e4 10619 Check that character arg fits in 'int'.
85461888 10620 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10621
c0c1ee9f
PE
10622 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10623
a498d7f4
PE
10624 * fns.c (concat): Catch string overflow earlier.
10625 Do not rely on integer wraparound.
10626
51cab52b
PE
10627 * dispextern.h (struct it.overlay_strings_charpos)
10628 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10629 * xdisp.c (forward_to_next_line_start)
10630 (back_to_previous_visible_line_start)
10631 (reseat_at_next_visible_line_start, next_element_from_buffer):
10632 Don't arbitrarily truncate the value of 'selective' to int.
10633
76031fad
PE
10634 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10635
5eb55db9
PE
10636 * composite.c: Don't truncate sizes to 'int'.
10637 (composition_gstring_p, composition_reseat_it)
10638 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10639 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10640 not EMACS_UINT, for indexes.
5eb55db9 10641
0703a717
PE
10642 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10643
d6202519
PE
10644 * buffer.c: Include <verify.h>.
10645 (struct sortvec.priority, struct sortstr.priority):
8961a454 10646 Now EMACS_INT, not int.
c20998a7 10647 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10648 (struct sortstr.size, record_overlay_string)
10649 (struct sortstrlist.size, struct sortlist.used):
10650 Don't truncate size to int.
10651 (record_overlay_string): Check for size-calculation overflow.
d6202519 10652 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10653
d5a19415
JM
106542011-06-22 Jim Meyering <meyering@redhat.com>
10655
029529ac 10656 Don't leak an XBM-image-sized buffer
d5a19415
JM
10657 * image.c (xbm_load): Free the image buffer after using it.
10658
a9041e6c
PE
106592011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10660
10661 Port to Sun C.
10662 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10663 that Sun C diagnosed.
10664 * fns.c (secure_hash): Fix pointer signedness issue.
10665 * intervals.c (static_offset_intervals): New function.
10666 (offset_intervals): Use it.
10667
7f3f739f
LL
106682011-06-21 Leo Liu <sdl.web@gmail.com>
10669
10670 * deps.mk (fns.o):
10671 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10672 sha512.h.
10673
10674 * fns.c (secure_hash): Rename from crypto_hash_function and change
10675 the first arg to accept symbols.
5b66d427 10676 (Fsecure_hash): New primitive.
7f3f739f
LL
10677 (syms_of_fns): New symbols.
10678
76147d94
DD
106792011-06-20 Deniz Dogan <deniz@dogan.se>
10680
10681 * process.c (Fset_process_buffer): Clarify return value in
10682 docstring.
10683
7d7d0045
CY
106842011-06-18 Chong Yidong <cyd@stupidchicken.com>
10685
10686 * dispnew.c (add_window_display_history): Use BVAR.
10687
10688 * xdisp.c (debug_method_add): Use BVAR.
10689 (check_window_end, dump_glyph_matrix, dump_glyph)
10690 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10691
10692 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10693 Likewise.
10694
10695 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10696 check till after the cache is created in init_frame_faces.
10697
ff2bc410
SM
106982011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10699
10700 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10701
28177add
PE
107022011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10703
dd3482fe
PE
10704 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10705 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10706 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10707
393d71f3 10708 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10709 * fileio.c (Finsert_file_contents):
10710 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10711 Remove the old (too-loose) buffer overflow checks.
10712 They weren't needed, since make_gap checks for buffer overflow.
10713 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10714 The old code merely checked for Emacs fixnum overflow, and relied
10715 on undefined (wraparound) behavior. The new code avoids undefined
10716 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10717
2e6813b0 10718 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10719 Tune. Don't use wider integers than needed. Don't use alloca.
10720 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10721
599a9e4f
PE
10722 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10723
99561444
PE
10724 * insdel.c, lisp.h (buffer_overflow): New function.
10725 (insert_from_buffer_1, replace_range, replace_range_2):
10726 * insdel.c (make_gap_larger):
10727 * editfns.c (Finsert_char):
10728 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10729
28177add
PE
10730 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10731
e69dafad
PE
107322011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10733
4baa020d 10734 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10735
b1c46f02
PE
10736 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10737 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10738
e69dafad
PE
10739 * fileio.c: Don't assume EMACS_INT fits in off_t.
10740 (emacs_lseek): New static function.
10741 (Finsert_file_contents, Fwrite_region): Use it.
10742 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10743
566684ea
PE
10744 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10745
e6966cd6
PE
10746 * fns.c: Don't overflow int when computing a list length.
10747 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10748 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10749 truncation on 64-bit hosts. Check for QUIT every
10750 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10751 faster and is responsive enough.
10752 (Flength): Report an error instead of overflowing an integer.
10753 (Fsafe_length): Return a float if the value is not representable
10754 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10755 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10756 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10757
dd0b0efb
PE
10758 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10759 (header_size, word_size): New constants.
10760 (allocate_vectorlike): Don't check size overflow here.
10761 (allocate_vector): Check it here instead, since this is the only
10762 caller of allocate_vectorlike that could cause overflow.
10763 Check that the new vector's length is representable as a fixnum.
10764
86fe5cfe
PE
10765 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10766 The previous code was bogus. For example, next_almost_prime (32)
10767 returned 39, which is undesirable as it is a multiple of 3; and
10768 next_almost_prime (24) returned 25, which is a multiple of 5 so
10769 why was the code bothering to check for multiples of 7?
10770
80e88859
PE
10771 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10772
4a2f0ad6
PE
10773 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10774
f66c7cf8
PE
10775 Variadic C functions now count arguments with ptrdiff_t.
10776 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10777 Back then I didn't know that the Emacs coding style prefers signed int.
10778 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10779 were being counted with int, which may truncate counts on 64-bit
10780 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10781 * lisp.h (struct Lisp_Subr.function.aMANY)
10782 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10783 Arg counts are now ptrdiff_t, not size_t.
10784 All variadic functions and their callers changed accordingly.
10785 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10786 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10787 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10788 * callint.c (Fcall_interactively): Check arg count for overflow,
10789 to avoid potential buffer overrun. Use signed char, not 'int',
10790 for 'varies' array, so that we needn't bother to check its size
10791 calculation for overflow.
10792 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10793 * eval.c (apply_lambda):
10794 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10795 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10796 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10797
a1759b76
PE
10798 * callint.c (Fcall_interactively): Don't use index var as event count.
10799
d96be9fc
PE
10800 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10801 * mem-limits.h (SIZE): Remove; no longer used.
10802
a690a978 10803 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10804
578c21e6
PE
10805 Remove unnecessary casts.
10806 * xterm.c (x_term_init):
10807 * xfns.c (x_set_border_pixel):
10808 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10809 These aren't needed now that we assume ANSI C.
10810
96f53c6c
PE
10811 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10812 It's more likely to cause problems (due to unsigned overflow)
10813 than to cure them.
10814
83c77d31
PE
10815 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10816
ee2079f1
PE
10817 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10818
6da65536
PE
10819 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10820
7147c4a4
PE
10821 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10822
193e32d9
PE
10823 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10824
e5533da6
PE
10825 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10826
9910e595
PE
10827 GLYPH_CODE_FACE returns EMACS_INT, not int.
10828 * dispextern.h (merge_faces):
10829 * xfaces.c (merge_faces):
01103c44
PE
10830 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10831 Don't assume EMACS_INT fits in int.
9910e595 10832
2638320e
PE
10833 * character.h (CHAR_VALID_P): Remove unused parameter.
10834 * fontset.c, lisp.h, xdisp.c: All uses changed.
10835
045eb8d9
PE
10836 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10837
c1f134b5
PE
10838 * fns.c (concat): Minor tuning based on overflow analysis.
10839 This doesn't fix any bugs. Use int to hold character, instead
10840 of constantly refetching from Emacs object. Use XFASTINT, not
10841 XINT, for value known to be a character. Don't bother comparing
10842 a single byte to 0400, as it's always less.
10843
395fcb93 10844 * floatfns.c (Fexpt):
327eeec8
PE
10845 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10846
abbd3d23
PE
10847 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10848 for characters.
10849
684a03ef
PE
10850 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10851
0fed43f3
PE
10852 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10853 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10854 incorrectly succeed when S was a string, because 4294967386 was
10855 truncated before it was used.
10856
8fd02eb7
PE
10857 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10858 Otherwise, an out-of-range integer could cause undefined behavior
10859 on a 64-bit host.
10860
f8c86b69
PE
10861 * composite.c: Use int, not EMACS_INT, for characters.
10862 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10863 EMACS_INT, for values that are known to be in character range.
10864 This doesn't fix any bugs but is the usual style inside Emacs and
10865 may generate better code on 32-bit machines.
10866
34206dd2
PE
10867 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10868 This is for reasons similar to the recent CHAR_STRING fix.
10869 * charset.c (Fencode_char): Check that character arg is actually
10870 a character. Pass an int to ENCODE_CHAR.
10871 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10872 wider than 'int', as a compile-time check to prevent future regressions
10873 in this area.
10874
c5958d4c 10875 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10876
10877 Make sure a 64-bit char is never passed to CHAR_STRING.
10878 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10879 by silently ignoring the top 32 bits, allowing some values
10880 that were far too large to be valid characters.
10881 * character.h: Include <verify.h>.
10882 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10883 arguments are no wider than unsigned, as a compile-time check
10884 to prevent future regressions in this area.
10885 * data.c (Faset):
01103c44 10886 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10887 (Fsubst_char_in_region):
10888 * fns.c (concat):
10889 * xdisp.c (decode_mode_spec_coding):
10890 Adjust to CHAR_STRING's new requirement.
10891 * editfns.c (Finsert_char, Fsubst_char_in_region):
10892 * fns.c (concat): Check that character args are actually
10893 characters. Without this test, these functions did the wrong
10894 thing with wildly out-of-range values on 64-bit hosts.
10895
d37ca623
PE
10896 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10897 These casts should not be needed on 32-bit hosts, either.
10898 * keyboard.c (read_char):
10899 * lread.c (Fload): Remove casts to unsigned.
10900
ea204efb
PE
10901 * lisp.h (UNSIGNED_CMP): New macro.
10902 This fixes comparison bugs on 64-bit hosts.
10903 (ASCII_CHAR_P): Use it.
10904 * casefiddle.c (casify_object):
01103c44 10905 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10906 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10907 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10908 * dispextern.h (FACE_FROM_ID):
10909 * keyboard.c (read_char): Use UNSIGNED_CMP.
10910
41cb286c
PE
10911 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10912 not to EMACS_INT, to avoid GCC warning.
10913
4a1b9832
PE
10914 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10915
55daad71
PE
10916 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10917 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10918 isn't needed on 32-bit machines.
8f95c75c 10919
01103c44
PE
10920 * buffer.c (Fgenerate_new_buffer_name):
10921 Use EMACS_INT for count, not int.
0ceccced 10922 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10923
10924 * data.c (Qcompiled_function): Now static.
10925
c6f072e7
PE
10926 * window.c (window_body_lines): Now static.
10927
20ce5912
PE
10928 * image.c (gif_load): Rename local to avoid shadowing.
10929
9c4c5f81
PE
10930 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10931 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10932 * alloc.c (make_save_value): Integer argument is now of type
10933 ptrdiff_t, not int.
10934 (mark_object): Use ptrdiff_t, not int.
10935 * lisp.h (pD): New macro.
10936 * print.c (print_object): Use it.
10937
c0c5c8ae
PE
10938 * alloc.c: Use EMACS_INT, not int, to count objects.
10939 (total_conses, total_markers, total_symbols, total_vector_size)
10940 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10941 (total_free_floats, total_floats, total_free_intervals)
10942 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10943 Now EMACS_INT, not int. All uses changed.
10944 (Fgarbage_collect): Compute overall total using a double, so that
10945 integer overflow is less likely to be a problem. Check for overflow
10946 when converting back to an integer.
5a25e253
PE
10947 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10948 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10949 These were 'int' variables that could overflow on 64-bit hosts;
10950 they were never used, so remove them instead of repairing them.
211a0b2a 10951 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10952 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10953 Previously, this ceilinged at INT_MAX, but that doesn't work on
10954 64-bit machines.
e46bb31a 10955 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10956
c78baabf 10957 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10958 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10959 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10960 when a (possibly-narrower) signed value would do just as well.
10961 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10962
c9d624c6
PE
10963 * alloc.c: Catch some string size overflows that we were missing.
10964 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10965 for convenience in STRING_BYTES_MAX.
10966 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10967 The definition here is exact; the one in lisp.h was approximate.
10968 (allocate_string_data): Check for string overflow. This catches
10969 some instances we weren't catching before. Also, it catches
10970 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10971 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10972 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10973
c9d624c6
PE
10974 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10975 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10976 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10977
353032ce
PE
10978 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10979
2bccce07
PE
10980 * alloc.c (Fmake_string): Check for out-of-range init.
10981
0ac30604
SM
109822011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10983
10984 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10985
c195f2de
JD
109862011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10987
10988 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10989 xg_get_default_scrollbar_width.
10990
10991 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10992 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10993 (style_changed_cb): Call update_theme_scrollbar_width and call
10994 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10995 all frames (Bug#8505).
10996 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10997 Call gtk_window_set_resizable if HAVE_GTK3.
10998 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10999 and height if HAVE_GTK3 (Bug#8505).
11000 (scroll_bar_width_for_theme): New variable.
11001 (update_theme_scrollbar_width): New function.
11002 (xg_get_default_scrollbar_width): Move code to
11003 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11004 (xg_initialize): Call update_theme_scrollbar_width.
11005
11006 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11007
11008 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11009
e10ac9f1
MR
110102011-06-12 Martin Rudalics <rudalics@gmx.at>
11011
11012 * frame.c (make_frame): Call other_buffer_safely instead of
11013 other_buffer.
11014
11015 * window.c (temp_output_buffer_show): Call display_buffer with
11016 second argument Vtemp_buffer_show_specifiers and reset latter
11017 immediately after the call.
11018 (Vtemp_buffer_show_specifiers): New variable.
11019 (auto_window_vscroll_p, next_screen_context_lines)
11020 (Vscroll_preserve_screen_position): Remove leading asterisks from
11021 doc-strings.
11022
2d3c217e 110232011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11024
7b7f97e8 11025 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11026 * buffer.c (Qclone_number): Remove for now, as it's unused.
11027 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11028 (record_buffer): Remove unused local.
11029 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11030 (set_frame_buffer_list): Remove; unused.
11031 * frame.h (other_visible_frames): Remove decl.
11032 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11033 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11034 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11035 if HAVE_GPM.
11036 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11037 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11038 Define only if HAVE_GPM.
11039 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11040 (update_hints_inhibit): Remove; never set. All uses removed.
11041 * widgetprv.h (emacsFrameClassRec): Remove decl.
11042 * window.c (delete_deletable_window): Now returns void, since it
11043 wasn't returning anything.
11044 (compare_window_configurations): Remove unused locals.
11045 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11046 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11047 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11048 the same widths as pointers. This follows up on the 2011-05-06 patch.
11049 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11050 * xterm.h: Likewise.
11051 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11052
1384b89e
JB
110532011-06-12 Juanma Barranquero <lekktu@gmail.com>
11054
11055 * makefile.w32-in: Update dependencies.
11056 (LISP_H): Add lib/intprops.h.
11057
1100a63c
CY
110582011-06-11 Chong Yidong <cyd@stupidchicken.com>
11059
11060 * image.c (gif_load): Add animation frame delay to the metadata.
11061 (syms_of_image): Use DEFSYM. New symbol `delay'.
11062
6198ccd0
MR
110632011-06-11 Martin Rudalics <rudalics@gmx.at>
11064
11065 * window.c (delete_deletable_window): Re-add.
11066 (Fset_window_configuration): Rewrite to handle dead buffers and
11067 consequently deletable windows.
11068 (window_tree, Fwindow_tree): Remove. Supply functionality in
11069 window.el.
11070 (compare_window_configurations): Simplify code.
11071
b6e3633c
AS
110722011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11073
1ab0dee5
AS
11074 * image.c (imagemagick_load_image): Fix type mismatch.
11075 (Fimagemagick_types): Likewise.
11076
b6e3633c
AS
11077 * window.h (replace_buffer_in_windows): Declare.
11078
9397e56f
MR
110792011-06-11 Martin Rudalics <rudalics@gmx.at>
11080
11081 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11082 Qclone_number. Remove external declaration of Qdelete_window.
11083 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11084 code.
640c8776
SM
11085 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11086 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11087 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11088 buffer list implementation.
11089 (other_buffer_safely): New function.
11090 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11091 calls to replace_buffer_in_windows and
11092 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11093 if allowed.
11094 (record_buffer): Inhibit quitting and rewrite using quittable
11095 functions. Run Qbuffer_list_update_hook if allowed.
11096 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11097 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11098 Move switch-to-buffer to window.el.
9397e56f
MR
11099 (bury-buffer): Move to window.el.
11100 (Vbuffer_list_update_hook): New variable.
11101
11102 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11103 section.
11104
11105 * window.h (resize_frame_windows): Move up in code.
11106 (Fwindow_frame): Remove EXFUN.
11107 (replace_buffer_in_all_windows): Remove prototype.
11108 (replace_buffer_in_windows_safely): Add prototype.
11109
11110 * window.c: Declare Qdelete_window static again. Move down
11111 declaration of select_count.
11112 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11113 (Fother_window): Move to window.el.
11114 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11115 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11116 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11117 window.el.
11118 (replace_buffer_in_windows): Implement by calling
11119 Qreplace_buffer_in_windows.
11120 (replace_buffer_in_all_windows): Remove with some functionality
11121 moved into replace_buffer_in_windows_safely.
11122 (replace_buffer_in_windows_safely): New function.
11123 (select_window_norecord, select_frame_norecord): Move in front
11124 of run_window_configuration_change_hook. Remove now obsolete
11125 declarations.
640c8776
SM
11126 (Fset_window_buffer): Rewrite doc-string.
11127 Call Qrecord_window_buffer.
9397e56f
MR
11128 (keys_of_window): Move binding for other-window to window.el.
11129
b50691aa
CY
111302011-06-11 Chong Yidong <cyd@stupidchicken.com>
11131
11132 * dispextern.h (struct image): Replace data member, whose int_val
11133 and ptr_val fields were not used by anything, with a single
11134 lisp_val object.
11135
11136 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11137 (gif_clear_image, gif_load, imagemagick_load_image)
11138 (gs_clear_image, gs_load): Callers changed.
11139
3f754b86
PE
111402011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11141
cca69397
PE
11142 * buffer.h: Include <time.h>, for time_t.
11143 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11144
109e28d0
PE
11145 Fix minor problems found by static checking.
11146
60737f02
PE
11147 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11148
4b66faf3
PE
11149 Make identifiers static if they are not used in other modules.
11150 * data.c (Qcompiled_function, Qframe, Qvector):
11151 * image.c (QimageMagick, Qsvg):
11152 * minibuf.c (Qmetadata):
11153 * window.c (resize_window_check, resize_root_window): Now static.
11154 * window.h (resize_window_check, resize_root_window): Remove decls.
11155
109e28d0
PE
11156 * window.c (window_deletion_count, delete_deletable_window):
11157 Remove; unused.
46a4ce9e
PE
11158 (window_body_lines): Now static.
11159 (Fdelete_other_windows_internal): Mark vars as initialized.
11160 Make sure 'resize_failed' is initialized.
11161 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11162 (resize_window_apply): Remove unused local.
11163 * window.h (delete_deletable_window): Remove decl.
11164
109e28d0 11165 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11166 (imagemagick_load_image): Fix pointer signedness problem by changing
11167 last arg from unsigned char * to char *. All uses changed.
11168 Also, fix a local for similar reasons.
11169 Remove unused locals. Remove locals to avoid shadowing.
11170 (fn_rsvg_handle_free): Remove; unused.
11171 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11172 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11173
3f754b86
PE
11174 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11175
2547adb1
CY
111762011-06-10 Chong Yidong <cyd@stupidchicken.com>
11177
11178 * image.c (gif_load): Fix omitted cast error introduced by
11179 2011-06-06 change.
11180
2c8e37d4
MR
111812011-06-10 Martin Rudalics <rudalics@gmx.at>
11182
11183 * window.h (resize_proportionally, orig_total_lines)
11184 (orig_top_line): Remove from window structure.
11185 (set_window_height, set_window_width, change_window_heights)
11186 (Fdelete_window): Remove prototypes.
11187 (resize_frame_windows): Remove duplicate declaration.
11188
440a42e3
EZ
111892011-06-10 Eli Zaretskii <eliz@gnu.org>
11190
11191 * window.h (resize_frame_windows, resize_window_check)
11192 (delete_deletable_window, resize_root_window)
11193 (resize_frame_windows): Declare prototypes.
11194
11195 * window.c (resize_window_apply): Make definition be "static" to
11196 match the prototype.
11197
562dd5e9
MR
111982011-06-10 Martin Rudalics <rudalics@gmx.at>
11199
11200 * window.c: Remove declarations of Qwindow_size_fixed,
11201 window_min_size_1, window_min_size_2, window_min_size,
11202 size_window, window_fixed_size_p, enlarge_window, delete_window.
11203 Remove static from declaration of Qdelete_window, it's
11204 temporarily needed by Fbury_buffer.
11205 (replace_window): Don't assign orig_top_line and
11206 orig_total_lines.
11207 (Fdelete_window, delete_window): Remove. Window deletion is
11208 handled by window.el.
640c8776
SM
11209 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11210 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11211 (Fdelete_other_windows): Remove. Deleting other windows is
11212 handled by window.el.
11213 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11214 handled in window.el.
11215 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11216 Window minimum sizes are handled in window.el.
11217 (shrink_windows, size_window, set_window_height)
11218 (set_window_width, change_window_heights, window_height)
11219 (window_width, CURBEG, CURSIZE, enlarge_window)
11220 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11221 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11222 handled in window.el.
11223 (make_dummy_parent): Rename to make_parent_window and give it a
11224 second argument horflag.
11225 (make_window): Don't set resize_proportionally any more.
11226 (Fsplit_window): Remove. Windows are split in window.el.
11227 (save_restore_action, save_restore_orig_size)
11228 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11229 Resize mini windows in window.el.
11230 (grow_mini_window, shrink_mini_window): Implement by calling
11231 Qresize_root_window_vertically, resize_window_check and
11232 resize_window_apply.
640c8776
SM
11233 (saved_window, Fset_window_configuration, save_window_save):
11234 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11235 resize_proportionally.
11236 (window_min_height, window_min_width): Move to window.el.
11237 (keys_of_window): Move bindings for delete-other-windows,
11238 split-window, delete-window and enlarge-window to window.el.
11239
11240 * buffer.c: Temporarily extern Qdelete_window.
11241 (Fbury_buffer): Temporarily call Qdelete_window instead of
11242 Fdelete_window (Fbury_buffer will move to window.el soon).
11243
11244 * frame.c (set_menu_bar_lines_1): Remove code handling
11245 orig_top_line and orig_total_lines.
11246
11247 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11248 set_window_height but set heights directly.
11249 (change_frame_size_1): Use resize_frame_windows.
11250
11251 * xdisp.c (init_xdisp): Don't use set_window_height but set
11252 heights directly.
11253
640c8776
SM
11254 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11255 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11256 run_window_configuration_change_hook.
11257
11258 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11259 instead of change_window_heights and run
11260 run_window_configuration_change_hook.
11261
1a13852e
MR
112622011-06-09 Martin Rudalics <rudalics@gmx.at>
11263
11264 * window.c (replace_window): Rename second argument REPLACEMENT to
11265 NEW. New third argument SETFLAG. Rewrite.
11266 (delete_window, make_dummy_parent): Call replace_window with
11267 third argument 1.
11268 (window_list_1): Move down in code.
11269 (run_window_configuration_change_hook): Move set_buffer part
11270 before select_frame_norecord part in order to unwind correctly.
11271 Rename count1 to count.
11272 (recombine_windows, delete_deletable_window, resize_root_window)
11273 (Fdelete_other_windows_internal)
11274 (Frun_window_configuration_change_hook, make_parent_window)
11275 (resize_window_check, resize_window_apply, Fresize_window_apply)
11276 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11277 (Fdelete_window_internal, Fresize_mini_window_internal):
11278 New functions.
1a13852e
MR
11279 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11280
f3d1777e
MR
112812011-06-08 Martin Rudalics <rudalics@gmx.at>
11282
496e208e
MR
11283 * window.h (window): Add some new members to window structure -
11284 normal_lines, normal_cols, new_total, new_normal, clone_number,
11285 splits, nest, prev_buffers, next_buffers.
11286 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11287 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11288
f3d1777e
MR
11289 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11290 Remove.
496e208e
MR
11291 (make_dummy_parent): Set new members of windows structure.
11292 (make_window): Move down in code. Handle new members of window
11293 structure.
11294 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11295 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11296 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11297 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11298 (Fset_window_next_buffers, Fset_window_clone_number):
11299 New functions.
496e208e
MR
11300 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11301 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11302 Doc-string fixes.
11303 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11304 Argument WINDOW can be now internal window too.
11305 (Fwindow_use_time): Move up in code.
11306 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11307 Rewrite doc-string.
11308 (Fset_window_configuration, saved_window)
11309 (Fcurrent_window_configuration, save_window_save): Handle new
11310 members of window structure.
b9e809c2
MR
11311 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11312 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11313 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11314 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11315 Qget_mru_window, Qresize_root_window,
11316 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11317 Qauto_buffer_name; staticpro them.
f3d1777e 11318
abde8f8c
MR
113192011-06-07 Martin Rudalics <rudalics@gmx.at>
11320
11321 * window.c (Fwindow_total_size, Fwindow_left_column)
11322 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11323 (Fwindow_list_1): New functions.
11324 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11325 (Fwindow_width, Fscroll_left, Fscroll_right):
11326 Use window_body_cols instead of window_box_text_cols.
11327 (delete_window, Fset_window_configuration):
11328 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11329 (delete_all_subwindows): Take a window as argument and not a
11330 structure. Rewrite.
190b47e6
MR
11331 (window_loop): Remove handling of GET_LRU_WINDOW and
11332 GET_LARGEST_WINDOW.
11333 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11334
11335 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11336 window_box_text_cols. delete_all_subwindows now takes a
11337 Lisp_Object as argument.
abde8f8c 11338
640c8776
SM
11339 * indent.c (compute_motion, Fcompute_motion):
11340 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11341
fa8a67e6
MR
11342 * frame.c (delete_frame): Call delete_all_subwindows with root
11343 window as argument.
11344
a54e3482
DC
113452011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11346
11347 * fns.c (Fputhash): Document return value.
11348
60002bf5
CY
113492011-06-06 Chong Yidong <cyd@stupidchicken.com>
11350
11351 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11352
0c671da6 113532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11354
b862a52a 11355 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11356
be44ca6c
PE
11357 Check for overflow when converting integer to cons and back.
11358 * charset.c (Fdefine_charset_internal, Fdecode_char):
11359 Use cons_to_unsigned to catch overflow.
11360 (Fencode_char): Use INTEGER_TO_CONS.
11361 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11362 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11363 * data.c (long_to_cons, cons_to_long): Remove.
11364 (cons_to_unsigned, cons_to_signed): New functions.
11365 These signal an error for invalid or out-of-range values.
11366 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11367 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11368 * font.c (Ffont_variation_glyphs):
11369 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11370 * lisp.h: Include <intprops.h>.
11371 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11372 (cons_to_signed, cons_to_unsigned): New decls.
11373 (long_to_cons, cons_to_long): Remove decls.
11374 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11375 (Fprimitive_undo): Use CONS_TO_INTEGER.
11376 * xfns.c (Fx_window_property): Likewise.
11377 * xselect.c: Include <limits.h>.
11378 (x_own_selection, selection_data_to_lisp_data):
11379 Use INTEGER_TO_CONS.
11380 (x_handle_selection_request, x_handle_selection_clear)
11381 (x_get_foreign_selection, Fx_disown_selection_internal)
11382 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11383 (lisp_data_to_selection_data): Use cons_to_unsigned.
11384 (x_fill_property_data): Use cons_to_signed.
11385 Report values out of range.
11386
d1f3d2af
PE
11387 Check for buffer and string overflow more precisely.
11388 * buffer.h (BUF_BYTES_MAX): New macro.
11389 * lisp.h (STRING_BYTES_MAX): New macro.
11390 * alloc.c (Fmake_string):
11391 * character.c (string_escape_byte8):
11392 * coding.c (coding_alloc_by_realloc):
11393 * doprnt.c (doprnt):
11394 * editfns.c (Fformat):
11395 * eval.c (verror):
11396 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11397 since they may not be the same number.
11398 * editfns.c (Finsert_char):
11399 * fileio.c (Finsert_file_contents):
11400 Likewise for BUF_BYTES_MAX.
11401
dd52fcea
PE
11402 * image.c: Use ptrdiff_t, not int, for sizes.
11403 (slurp_file): Switch from int to ptrdiff_t.
11404 All uses changed.
11405 (slurp_file): Check that file size fits in both size_t (for
11406 malloc) and ptrdiff_t (for sanity and safety).
11407
7f9bbdbb
PE
11408 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11409 if b->modtime has its maximal value.
11410
dfe18f82
PE
11411 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11412
84acfcf0
PE
11413 Don't assume time_t can fit into int.
11414 * buffer.h (struct buffer.modtime): Now time_t, not int.
11415 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11416 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11417
ccd9a01a
PE
11418 Minor fixes for signed vs unsigned integers.
11419 * character.h (MAYBE_UNIFY_CHAR):
11420 * charset.c (maybe_unify_char):
11421 * keyboard.c (read_char, reorder_modifiers):
11422 XINT -> XFASTINT, since the integer must be nonnegative.
11423 * ftfont.c (ftfont_spec_pattern):
11424 * keymap.c (access_keymap, silly_event_symbol_error):
11425 XUINT -> XFASTINT, since the integer must be nonnegative.
11426 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11427 since it makes no difference and we prefer signed.
11428 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11429 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11430 nonnegative.
11431
d6d100dd
SM
114322011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11433
11434 * window.h (Fwindow_frame): Declare.
11435
2b6148e4
PE
114362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11437
11438 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11439 (SPARE_MEMORY): Always define.
11440 (LARGE_REQUEST): Remove.
11441 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11442
f230ecc9
MR
114432011-06-06 Martin Rudalics <rudalics@gmx.at>
11444
727e958e
MR
11445 * lisp.h: Move EXFUNS for Fframe_root_window,
11446 Fframe_first_window and Fset_frame_selected_window to window.h.
11447
11448 * window.h: Move EXFUNS for Fframe_root_window,
11449 Fframe_first_window and Fset_frame_selected_window here from
11450 lisp.h.
11451
11452 * frame.c (Fwindow_frame, Fframe_first_window)
11453 (Fframe_root_window, Fframe_selected_window)
11454 (Fset_frame_selected_window): Move to window.c.
11455 (Factive_minibuffer_window): Move to minibuf.c.
11456 (Fother_visible_frames_p): New function.
11457
11458 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11459
f230ecc9
MR
11460 * window.c (decode_window, decode_any_window): Move up in code.
11461 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11462 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11463 (Fwindow_buffer): Move up and rewrite doc-string.
11464 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11465 (Fwindow_prev): New functions.
727e958e
MR
11466 (Fwindow_frame): Move here from frame.c. Accept any window as
11467 argument.
11468 (Fframe_root_window, Fframe_first_window)
11469 (Fframe_selected_window): Move here from frame.c. Accept frame
11470 or arbitrary window as argument. Update doc-strings.
11471 (Fminibuffer_window): Move up in code.
11472 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11473 (Fset_frame_selected_window): Move here from frame.c.
11474 Marginal rewrite.
727e958e
MR
11475 (Fselected_window, select_window, Fselect_window): Move up in
11476 code. Minor doc-string fixes.
f230ecc9 11477
4d09bcf6
PE
114782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11479
11480 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11481 Do not assume that spare memory exists; that assumption is valid
11482 only if SYSTEM_MALLOC.
11483 (LARGE_REQUEST): New macro, so that the issue of large requests
11484 is separated from the issue of spare memory.
11485
810928a2
AS
114862011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11487
172418ad
AS
11488 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11489 format. (Bug#8806)
11490
43f862f7
AS
11491 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11492
810928a2
AS
11493 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11494 before statements.
11495
a059fe24
JD
114962011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11497
11498 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11499
11500 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11501
11502 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11503 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11504
989bf368
JB
115052011-06-05 Juanma Barranquero <lekktu@gmail.com>
11506
11507 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11508
4b80f674
CY
115092011-06-04 Chong Yidong <cyd@stupidchicken.com>
11510
11511 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11512 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11513 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11514 New error handlers.
4b80f674
CY
11515 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11516 Obey Vx_select_enable_clipboard_manager. Catch errors in
11517 x_clipboard_manager_save (Bug#8779).
11518 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11519 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11520
99a33b77 115212011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11522
11523 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11524
99a33b77 115252011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11526
11527 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11528 in the current matrix if keep_current_p is non-zero.
11529
8264569d
EZ
115302011-06-04 Eli Zaretskii <eliz@gnu.org>
11531
11532 * bidi.c (bidi_level_of_next_char): Fix last change.
11533
57f97249
EZ
115342011-06-03 Eli Zaretskii <eliz@gnu.org>
11535
fec2107c 11536 Support bidi reordering of text covered by display properties.
57f97249 11537
fec2107c
EZ
11538 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11539 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11540 (bidi_cache_search, bidi_cache_iterator_state)
11541 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11542 (bidi_level_of_next_char, bidi_move_to_visually_next):
11543 Support character positions inside a run of characters covered by a
fec2107c
EZ
11544 display string.
11545 (bidi_paragraph_init, bidi_resolve_explicit_1)
11546 (bidi_level_of_next_char): Call bidi_fetch_char and
11547 bidi_fetch_char_advance instead of FETCH_CHAR and
11548 FETCH_CHAR_ADVANCE.
11549 (bidi_init_it): Initialize new members.
11550 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11551 definitions.
11552 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11553 instead of using explicit *_CHAR codes.
d6d100dd
SM
11554 (bidi_resolve_explicit, bidi_resolve_weak):
11555 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11556 bidirectional text is supported only in multibyte buffers.
11557 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11558 it to initialize the frame_window_p member of struct bidi_it.
11559 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11560 (bidi_resolve_explicit, bidi_resolve_weak)
11561 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11562 bidi_it->nchars is non-positive.
11563 (bidi_level_of_next_char): Don't try to lookup the cache for the
11564 next/previous character if nothing is cached there yet, or if we
11565 were just reseat()'ed to a new position.
c40e2fb2 11566
0e14fe90
EZ
11567 * xdisp.c (set_cursor_from_row): Set start and stop points
11568 according to the row's direction when priming the loop that looks
11569 for the glyph on which to display cursor.
11570 (single_display_spec_intangible_p): Function deleted.
11571 (display_prop_intangible_p): Reimplement to call
11572 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11573 Accept 3 additional arguments needed by handle_display_spec.
11574 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11575 values: lists, `(when COND...)' forms, etc.
11576 (single_display_spec_string_p): Support property values that are
11577 lists with the argument STRING its top-level element.
11578 (display_prop_string_p): Fix the condition for processing a
11579 property that is a list to be consistent with handle_display_spec.
fec2107c 11580 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11581 last portion of handle_display_prop.
11582 (compute_display_string_pos): Accept additional argument
11583 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11584 value of a `display' property is a "replacing spec".
11585 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11586 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11587 the display property, but just return a value indicating whether
11588 the display property will replace the characters it covers.
11589 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11590 frame_window_p members of struct bidi_it.
d6d100dd
SM
11591 (compute_display_string_pos, compute_display_string_end):
11592 New functions.
fec2107c
EZ
11593 (push_it): Accept second argument POSITION, where pop_it should
11594 jump to continue iteration.
11595 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11596
fec2107c
EZ
11597 * keyboard.c (adjust_point_for_property): Adjust the call to
11598 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11599
11600 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11601 (bidi_init_it): Update prototypes.
11602 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11603 (compute_display_string_pos, compute_display_string_end):
11604 Declare prototypes.
fec2107c
EZ
11605 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11606 EMACS_INT.
fc6f18ce 11607
40087514 116082011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11609
57f53182
PE
11610 Malloc failure behavior now depends on size of allocation.
11611 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11612 * lisp.h: Change signatures accordingly.
11613 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11614 All callers changed. (Bug#8762)
11615
11616 * gnutls.c: Use Emacs's memory allocators.
11617 Without this change, the gnutls library would invoke malloc etc.
11618 directly, which causes problems on non-SYNC_INPUT hosts, and which
11619 runs afoul of improving memory_full behavior. (Bug#8761)
11620 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11621 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11622 xfree instead of the default malloc, realloc, free.
11623 (Fgnutls_boot): No need to check for memory allocation failure,
11624 since xmalloc does that for us.
11625
ac32cd99 11626 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11627 * category.c (hash_get_category_set):
11628 * ccl.c (ccl_driver):
11629 * charset.c (Fdefine_charset_internal):
11630 * charset.h (struct charset.hash_index):
11631 * composite.c (get_composition_id, gstring_lookup_cache)
11632 (composition_gstring_put_cache):
11633 * composite.h (struct composition.hash_index):
11634 * dispextern.h (struct image.hash):
11635 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11636 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11637 (hashfn_equal, hashfn_user_defined, make_hash_table)
11638 (maybe_resize_hash_table, hash_lookup, hash_put)
11639 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11640 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11641 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11642 * image.c (make_image, search_image_cache, lookup_image)
11643 (xpm_put_color_table_h):
11644 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11645 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11646 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11647 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11648 * alloc.c (allocate_vectorlike):
11649 Check for overflow in vector size calculations.
11650 * ccl.c (ccl_driver):
11651 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11652 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11653 need to be updated by these changes.
40087514
PE
11654 * fns.c (make_hash_table, maybe_resize_hash_table):
11655 Check for integer overflow with large hash tables.
0de4bb68
PE
11656 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11657 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11658 (SXHASH_REDUCE): New macro.
11659 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11660 Use it instead of discarding useful hash info with large hash values.
11661 (sxhash_float): New function.
11662 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11663 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11664 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11665 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11666 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11667 Adjust signatures to match updated version of code.
11668 (consing_since_gc): Now EMACS_INT, since a single hash table can
11669 use more than INT_MAX bytes.
11670
698d32e2
DN
116712011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11672
11673 Make it possible to build with GCC-4.6+ -O2 -flto.
11674
11675 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11676
fd6fa53f
SM
116772011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11678
11679 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11680 Call minibuffer-inactive-mode.
11681
864db017
JB
116822011-05-31 Juanma Barranquero <lekktu@gmail.com>
11683
11684 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11685 Update dependencies.
11686
2ad0baf4
DN
116872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11688
11689 * data.c (init_data): Remove code for UTS, this system is not
11690 supported anymore.
11691
4fcc2638
DN
116922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11693
11694 Don't force ./temacs to start in terminal mode.
11695
11696 * frame.c (make_initial_frame): Initialize faces in all cases, not
11697 only when CANNOT_DUMP is defined.
11698 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11699
c56e0fd5
DN
117002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11701
11702 * dispnew.c (add_window_display_history): Use const for the string
11703 pointer. Remove declaration, not needed.
11704
333d54da 117052011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11706
55d4c1b2 11707 Use 'inline', not 'INLINE'.
333d54da 11708 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11709 * alloc.c, fontset.c (INLINE): Remove.
11710 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11711 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11712 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11713 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11714 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11715
738db178
DN
117162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11717
11718 Make it possible to run ./temacs.
11719
11720 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11721 syms_of_callproc does the same thing. Remove test for
11722 "initialized", do it in the caller.
11723 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11724
620c53a6
SM
117252011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11726
11727 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11728 (read_minibuf): Use get_minibuffer.
11729 (syms_of_minibuf): Use DEFSYM.
11730 (Qmetadata): New var.
11731 * data.c (Qbuffer): Don't make it static.
11732 (syms_of_data): Use DEFSYM.
11733
e003a292
PE
117342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11735
11736 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11737 (CCL_CODE_MIN): New macro.
11738
ed008a6d
PE
117392011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11740
3687c2ef
PE
11741 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11742
ed008a6d
PE
11743 * eval.c (Qdebug): Now static.
11744 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11745 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11746 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11747
d66c4c7c
CY
117482011-05-29 Chong Yidong <cyd@stupidchicken.com>
11749
11750 * image.c: Various fixes to ImageMagick code comments.
11751 (Fimagemagick_types): Doc fix.
11752
5fbc2025
PE
117532011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11754
0196f88a
PE
11755 Minor fixes prompted by GCC 4.6.0 warnings.
11756
11757 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11758
5fbc2025
PE
11759 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11760 (x_clipboard_manager_save_all): Move extern decl to ...
11761 * xterm.h: ... here, so that it can be checked for consistency.
11762
1dd3c2d9
CY
117632011-05-29 Chong Yidong <cyd@stupidchicken.com>
11764
11765 * xselect.c (x_clipboard_manager_save_frame)
11766 (x_clipboard_manager_save_all): New functions.
11767 (Fx_clipboard_manager_save): Lisp function deleted.
11768
11769 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11770 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11771
11772 * xterm.h: Update prototype.
11773
5ba6571d
WX
117742011-05-28 William Xu <william.xwl@gmail.com>
11775
11776 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11777 exiting (Bug#8239).
11778
3eaff834
JM
117792011-05-28 Jim Meyering <meyering@redhat.com>
11780
e1900994 11781 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11782 * fns.c (to_uchar): Define.
11783 (crypto_hash_function): Use it to convert some newly-signed
11784 variables to unsigned, to avoid sign-extension bugs. For example,
11785 without this change, (md5 "truc") would evaluate to
11786 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11787 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11788 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11789
0f6990a7
PE
117902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11791
11792 Integer overflow fixes.
c8a9ca5a 11793
08686060
PE
11794 * dbusbind.c: Serial number integer overflow fixes.
11795 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11796 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11797 to hold a serial number that is too large for a fixnum.
11798 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11799 Check for serial numbers out of range. Decode any serial number
59568bf0 11800 that was so large that it became a float. (Bug#8722)
08686060 11801
2d1fc3c7
PE
11802 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11803 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11804 Use XFASTINT rather than XUINT when numbers are nonnegative.
11805 (xd_append_arg, Fdbus_method_return_internal):
11806 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11807 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11808 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11809 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11810 (Bug#8722)
2d1fc3c7 11811
c8a9ca5a
PE
11812 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11813
519e1d69
PE
11814 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11815
6df6ae42 11816 ccl: Add integer overflow checks.
30569699
PE
11817 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11818 (IN_INT_RANGE): New macros.
11819 (ccl_driver): Use them to check for integer overflow when
11820 decoding a CCL program. Many of the new checks are whether XINT (x)
11821 fits in int; it doesn't always, on 64-bit hosts. The new version
11822 doesn't catch all possible integer overflows, but it's an
847044ea 11823 improvement. (Bug#8719)
30569699 11824
c11285dc
PE
11825 * alloc.c (make_event_array): Use XINT, not XUINT.
11826 There's no need for unsigned here.
11827
fdccd48e
PE
11828 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11829 This follows up to the 2011-05-06 change that substituted uintptr_t
11830 for EMACS_INT. This case wasn't caught back then.
11831
37910ab2
PE
11832 Rework Fformat to avoid integer overflow issues.
11833 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11834 now (part of C89). Include <verify.h>.
11835 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11836 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11837 (Fformat): Avoid the prepass trying to compute sizes; it was only
11838 approximate and thus did not catch overflow reliably. Instead, walk
11839 through the format just once, formatting and computing sizes as we go,
11840 checking for integer overflow at every step, and allocating a larger
11841 buffer as needed. Keep track separately whether the format is
11842 multibyte. Keep only the most-recently calculated precision, rather
11843 than them all. Record whether each argument has been converted to
11844 string. Use EMACS_INT, not int, for byte and char and arg counts.
11845 Support field widths and precisions larger than INT_MAX. Avoid
11846 sprintf's undefined behavior with conversion specifications such as %#d
11847 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11848 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11849 formatting out-of-range floating point numbers with int
9173deec 11850 formats. (Bug#8668)
37910ab2 11851
2e6578fb
PE
11852 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11853
0ae6bdee
PE
11854 * data.c: Avoid integer truncation in expressions involving floats.
11855 * data.c: Include <intprops.h>.
11856 (arith_driver): When there's an integer overflow in an expression
11857 involving floating point, convert the integers to floating point
11858 so that the resulting value does not suffer from catastrophic
11859 integer truncation. For example, on a 64-bit host (* 4
11860 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11861 Do not rely on undefined behavior after integer overflow.
11862
de883a70
PE
11863 merge count_size_as_multibyte, parse_str_to_multibyte
11864 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11865 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11866 Check for integer overflow.
11867 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11868 since it's now a duplicate of the other. This is more of
11869 a character than a buffer op, so better that it's in character.c.
11870 * fns.c, print.c: Adjust to above changes.
11871
2ff916cb
PE
118722011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11873
11874 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11875
f1b54466
PE
118762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11877
fb1ac845
PE
11878 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11879 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11880 (x_clipboard_manager_save): Now static.
11881 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11882
f1b54466
PE
11883 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11884 (crypto_hash_function): Now static.
11885 Fix pointer signedness problems. Avoid unnecessary initializations.
11886
a9f737ee
CY
118872011-05-27 Chong Yidong <cyd@stupidchicken.com>
11888
11889 * termhooks.h (Vselection_alist): Make it terminal-local.
11890
11891 * terminal.c (create_terminal): Initialize it.
11892
11893 * xselect.c: Support for clipboard managers.
11894 (Vselection_alist): Move to termhooks.h as terminal-local var.
11895 (LOCAL_SELECTION): New macro.
11896 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11897 (symbol_to_x_atom): Remove gratuitous arg.
11898 (x_handle_selection_request, lisp_data_to_selection_data)
11899 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11900 (x_own_selection, x_get_local_selection, x_convert_selection):
11901 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11902 (some_frame_on_display): Delete unused function.
11903 (Fx_own_selection_internal, Fx_get_selection_internal)
11904 (Fx_disown_selection_internal, Fx_selection_owner_p)
11905 (Fx_selection_exists_p): New optional frame arg.
11906 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11907 (x_handle_selection_clear): Don't treat other terminals with the
11908 same keyboard specially. Use the terminal-local Vselection_alist.
11909 (x_clear_frame_selections): Use Frun_hook_with_args.
11910
11911 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11912
11913 * xterm.h: Add support for those atoms.
11914
e067f0c1
CY
119152011-05-26 Chong Yidong <cyd@stupidchicken.com>
11916
11917 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11918 (converted_selections, conversion_fail_tag): New global variables.
11919 (x_selection_request_lisp_error): Free the above.
11920 (x_get_local_selection): Remove unnecessary code.
11921 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11922 of converted selections stored in converted_selections.
11923 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11924 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11925 (x_convert_selection): New function.
11926 (x_handle_selection_event): Simplify.
11927 (x_get_foreign_selection): Don't ignore incoming requests while
11928 waiting for an answer; this will fail when we implement
11929 SAVE_TARGETS, and seems unnecessary anyway.
11930 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11931 (Vx_sent_selection_functions): Doc fix.
11932
0f4aebc0
LL
119332011-05-26 Leo Liu <sdl.web@gmail.com>
11934
11935 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11936
e61124cd
YM
119372011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11938
11939 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11940
11941 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11942 for fringe update if it has periodic bitmap.
ac389d0c 11943 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11944 and fringe_bitmap_periodic_p.
11945
11946 * fringe.c (get_fringe_bitmap_data): New function.
11947 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11948 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11949 row. Mark glyph row for fringe update if periodicity changed.
11950
11951 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11952 for fringe update unless it has periodic bitmap.
11953
f16d9837
KH
119542011-05-25 Kenichi Handa <handa@m17n.org>
11955
11956 * xdisp.c (get_next_display_element): Set correct it->face_id for
11957 a static composition.
11958
e1b90ef6
LL
119592011-05-24 Leo Liu <sdl.web@gmail.com>
11960
11961 * deps.mk (fns.o):
11962 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11963
11964 * fns.c (crypto_hash_function, Fsha1): New function.
11965 (Fmd5): Use crypto_hash_function.
11966 (syms_of_fns): Add Ssha1.
11967
7400048f
PE
119682011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11969
11970 * gnutls.c: Remove unused macros.
11971 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11972 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11973 Remove macros that are defined and never used.
11974 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11975
abb71cf4
CY
119762011-05-22 Chong Yidong <cyd@stupidchicken.com>
11977
11978 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11979 (Fx_get_selection_internal): Minor cleanup.
11980 (Fx_own_selection_internal): Rename arguments for consistency with
11981 select.el.
11982
6307db39
PE
119832011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11984
11985 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11986
f3d4e0a4
CY
119872011-05-22 Chong Yidong <cyd@stupidchicken.com>
11988
11989 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11990
4d8ade89
YM
119912011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11992
11993 * dispnew.c (scrolling_window): Don't exclude the case that the
11994 last enabled row in the desired matrix touches the bottom boundary.
11995
32078c8d
GM
119962011-05-21 Glenn Morris <rgm@gnu.org>
11997
11998 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11999 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12000 and add some more files.
32078c8d 12001
7285dc67
EZ
120022011-05-20 Eli Zaretskii <eliz@gnu.org>
12003
12004 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12005 report_file_error introduced by the change from 2011-05-07.
12006
89d1bd22
PE
120072011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12008
12009 * systime.h (Time): Define only if emacs is defined.
12010 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12011 where the include path doesn't have X11/X.h by default. See
12012 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12013
cd394be1 120142011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12015
12016 * composite.c (find_automatic_composition): Fix previous change.
12017
b9704ad9
GM
120182011-05-20 Glenn Morris <rgm@gnu.org>
12019
12020 * lisp.mk: New file, split from Makefile.in.
12021 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12022 (shortlisp): Remove.
12023 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12024
4a720484
GM
120252011-05-19 Glenn Morris <rgm@gnu.org>
12026
12027 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12028 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12029 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12030 (lisp): Set the order to that of loadup.el.
12031 (shortlisp): Make it a copy of $lisp.
12032 (SOME_MACHINE_LISP): Remove.
12033 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12034 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12035
a28d4396
KH
120362011-05-18 Kenichi Handa <handa@m17n.org>
12037
12038 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12039 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12040 (find_automatic_composition): Mostly rewrite for efficiency.
12041
a2b1fa8e
JB
120422011-05-18 Juanma Barranquero <lekktu@gmail.com>
12043
12044 * makefile.w32-in: Update dependencies.
12045
8e1f5610
CS
120462011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12047
12048 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12049 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12050
7025ee00 120512011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12052
cdfa6eab
PE
12053 Fix some integer overflow issues, such as string length overflow.
12054
06d6db33
PE
12055 * insdel.c (count_size_as_multibyte): Check for string overflow.
12056
2b4560a8
PE
12057 * character.c (lisp_string_width): Check for string overflow.
12058 Use EMACS_INT, not int, for string indexes and lengths; in
12059 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12060 the resulting string length overflows an EMACS_INT; instead,
12061 report a string overflow if no precision given. When checking for
12062 precision exhaustion, use a check that cannot possibly have
12063 integer overflow. (Bug#8675)
12064 * character.h (lisp_string_width): Adjust to new signature.
12065
cb93f9be
PE
12066 * alloc.c (string_overflow): New function.
12067 (Fmake_string): Use it. This doesn't change behavior, but saves
12068 a few bytes and will simplify future changes.
12069 * character.c (string_escape_byte8): Likewise.
12070 * lisp.h (string_overflow): New decl.
12071
1a1f3366
PE
12072 Fixups, following up to the user-interface timestamp change.
12073 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12074 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12075 * msdos.c (mouse_get_pos): Likewise.
12076 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12077 * w32gui.h (Time): Define by including "systime.h" rather than by
12078 declaring it ourselves. (Bug#8664)
12079
d4e3e4d3
PE
12080 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12081 * image.c (clear_image_cache): Likewise.
12082
f6a24d19
PE
12083 * term.c (term_mouse_position): Don't assume time_t wraparound.
12084
08dc5ae6
PE
12085 Be more systematic about user-interface timestamps.
12086 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12087 and sometimes 'EMACS_UINT', to represent these timestamps.
12088 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12089 This makes the code easier to follow, and makes it easier to catch
12090 integer overflow bugs such as Bug#8664.
12091 * frame.c (Fmouse_position, Fmouse_pixel_position):
12092 Use Time, not unsigned long, for user-interface timestamps.
12093 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12094 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12095 * keyboard.h (last_event_timestamp): Likewise.
12096 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12097 * menu.h (xmenu_show): Likewise.
12098 * term.c (term_mouse_position): Likewise.
12099 * termhooks.h (struct input_event.timestamp): Likewise.
12100 (struct terminal.mouse_position_hook): Likewise.
12101 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12102 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12103 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12104 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12105 what it was before.
12106 * menu.h, termhooks.h: Include "systime.h", for Time.
12107
8e55734a
PE
12108 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12109 Don't assume that the difference between two unsigned long values
12110 can fit into an integer. At this point, we know button_down_time
12111 <= event->timestamp, so the difference must be nonnegative, so
12112 there's no need to cast the result if double-click-time is
12113 nonnegative, as it should be; check that it's nonnegative, just in
12114 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12115 apart (about 25 days). (Bug#8664)
8e55734a 12116
841f1b75 12117 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12118 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12119
3e26f69c
PE
12120 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12121 that always fit in int. Use a sentinel instead of a counter, to
12122 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12123 * frame.h (struct frame): Use int for menu_bar_items_used
12124 instead of EMACS_INT, since it always fits in int.
3e26f69c 12125
5cc152c0
PE
12126 * menu.c (grow_menu_items): Check for int overflow.
12127
d89eb65e
PE
12128 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12129
5235bd3e
PE
12130 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12131 Before, the code was not consistent. These values cannot exceed
12132 2**31 - 1 so there's no need to make them unsigned.
12133 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12134 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12135 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12136 as modifiers.
12137 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12138
bc827e23
PE
12139 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12140 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12141 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12142 presumably because the widths might not match.
12143
78eb494e
PE
12144 * window.c (size_window): Avoid needless test at loop start.
12145
04f2d78b
CB
121462011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12147
12148 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12149
d2fc7e3d 121502011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12151
12152 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12153
d2fc7e3d 121542011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12155
12156 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12157 `width' to `bar_area_x' and `bar_area_width', respectively.
12158 (x_scroll_run): Take account of fringe background extension.
12159
04f2d78b
CB
12160 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12161 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12162 `bar_area_width', respectively.
12163 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12164 background extension.
12165
79b70037
GM
121662011-05-10 Jim Meyering <meyering@redhat.com>
12167
12168 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12169
2f142cc5
JB
121702011-05-10 Juanma Barranquero <lekktu@gmail.com>
12171
12172 * image.c (Finit_image_library): Return t for built-in image types,
12173 like pbm and xbm. (Bug#8640)
12174
57679c86
AS
121752011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12176
12177 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12178
888c9e86
EZ
121792011-05-07 Eli Zaretskii <eliz@gnu.org>
12180
b0512a1d
EZ
12181 * w32console.c (Fset_screen_color): Doc fix.
12182 (Fget_screen_color): New function.
12183 (syms_of_ntterm): Defsubr it.
12184
7285dc67
EZ
12185 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12186 unlink the temporary file if Fcall_process didn't create it in the
12187 first place.
12188 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12189 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12190 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12191 cue to call_process_cleanup not to close that handle.
12192
4d3fcc8e
BK
121932011-05-07 Ben Key <bkey76@gmail.com>
12194
12195 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12196 one of two shell specific rules, either bootstrap-temacs-CMD or
12197 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12198 to the previous implementation of the bootstrap-temacs rule.
12199 The bootstrap-temacs-CMD rule is similar to the previous
12200 implementation of the bootstrap-temacs rule except that it
12201 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12202 variable.
12203
12204 These changes, along with some changes to nt/configure.bat,
12205 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12206 earlier fix to add support for --cflags and --ldflags options
12207 that include quotes so that it works whether make uses cmd or
12208 sh as the shell.
12209
b4289b64
MA
122102011-05-06 Michael Albinus <michael.albinus@gmx.de>
12211
12212 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12213 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12214 is a constant.
12215 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12216 a string. Handle both cases.
12217 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12218 (Fdbus_register_method): Use Qinvalid_function.
12219
af4c0e28
JB
122202011-05-06 Juanma Barranquero <lekktu@gmail.com>
12221
12222 * makefile.w32-in: Update dependencies.
12223 (LISP_H): Add inttypes.h and stdin.h.
12224 (PROCESS_H): Add unistd.h.
12225
c51453d9
EZ
122262011-05-06 Eli Zaretskii <eliz@gnu.org>
12227
12228 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12229 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12230
8ff0ac3c 122312011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12232
4c4b566b
PE
12233 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12234
aab2b9b5
PE
12235 * term.c (vfatal): Remove stray call to va_end.
12236 It's not needed and the C Standard doesn't allow it here anyway.
12237
c378da0b
PE
12238 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12239 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12240
288b08c7
PE
12241 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12242 bytes.
12243
e3601888
PE
12244 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12245
db6c0e74
PE
12246 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12247
dd5963ea
PE
12248 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12249
88c9450f
PE
12250 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12251
2f9442b8
PE
12252 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12253
c032b5f8
PE
12254 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12255 * charset.c (Fdefine_charset_internal): Don't initialize
12256 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12257 32-bit int (Bug#8600).
a108c10b
PE
12258
12259 * lread.c (read_integer): Be more consistent with string-to-number.
12260 Use string_to_number to do the actual conversion; this avoids
12261 rounding errors and fixes some other screwups. Without this fix,
12262 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12263 (digit_to_number): Move earlier, for benefit of read_integer.
12264 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12265 not a digit in any supported base. (Bug#8602)
a108c10b 12266
ad5f9eea
PE
12267 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12268
aec1708a
PE
12269 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12270 to match comment at start of function. This also removes a
12271 GCC warning about overflow in a 32+64-bit port.
12272
47be4ab5
PE
12273 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12274
371cac43
PE
12275 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12276 Reported by Stefan Monnier in
12277 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12278 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12279 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12280
d01a7826
PE
12281 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12282 (EMACS_UINTPTR): Likewise, with uintptr_t.
12283
7fd47d5c
PE
12284 * lisp.h: Prefer 64-bit EMACS_INT if available.
12285 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12286 on 32-bit hosts that have 64-bit int, so that they can access
12287 large files.
122b0c86
PE
12288 However, temporarily disable this change unless the temporary
12289 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12290
8727937b
PE
12291 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12292
8ac068ac
PE
12293 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12294 This removes an assumption that EMACS_INT and long are the same
12295 width as pointers. The assumption is true for Emacs porting targets
12296 now, but we want to make other targets possible.
12297 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12298 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12299 In the rest of the code, change types of integers that hold casted
12300 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12301 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12302 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12303 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12304 No need to cast type when ORing.
12305 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12306 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12307 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12308 assume EMACS_INT is the same width as char *.
12309 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12310 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12311 Remove no-longer-needed casts.
12312 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12313 (xg_tool_bar_help_callback, xg_make_tool_item):
12314 Use EMACS_INTPTR to hold an integer
12315 that will be cast to void *; this can avoid a GCC warning
12316 if EMACS_INT is not the same width as void *.
12317 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12318 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12319 (current_message_1, set_message_1):
12320 Use a local to convert to proper width without a cast.
12321 * xmenu.c (dialog_selection_callback): Likewise.
12322
ede49d71
PE
12323 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12324 Also, don't assume VALBITS / RAND_BITS is less than 5,
12325 and don't rely on undefined behavior when shifting a 1 left into
12326 the sign bit.
12327 * lisp.h (get_random): Change signature to match.
12328
2f30ecd0
PE
12329 * lread.c (hash_string): Use size_t, not int, for hash computation.
12330 Normally we prefer signed values; but hashing is special, because
12331 it's better to use unsigned division on hash table sizes so that
12332 the remainder is nonnegative. Also, size_t is the natural width
12333 for hashing into memory. The previous code used 'int', which doesn't
12334 retain enough info to hash well into very large tables.
12335 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12336
2a866e7b
PE
12337 * dbusbind.c: Don't possibly lose pointer info when converting.
12338 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12339 Use XPNTR rather than XHASH, so that the high-order bits of
12340 the pointer aren't lost when converting through void *.
12341
51639eac
PE
12342 * eval.c (Fautoload): Don't double-shift a pointer.
12343
92394119
PE
12344 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12345
dbdb9a7c
JB
123462011-05-06 Juanma Barranquero <lekktu@gmail.com>
12347
12348 * gnutls.c (DEF_GNUTLS_FN):
12349 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12350
db7a0b4f
AS
123512011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12352
12353 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12354 marker. (Bug#8610)
12355
cd394be1 123562011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12357
12358 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12359 New version that can reserve upto 2GB of heap space.
12360
f7ff1b0f 123612011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12362
12363 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12364
639c109b
TZ
123652011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12366
12367 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12368 `gnutls_certificate_set_x509_key_file'.
12369
d2127135
JB
123702011-05-05 Juanma Barranquero <lekktu@gmail.com>
12371
12372 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12373 Update dependencies.
12374
e968f4f3
JB
123752011-05-04 Juanma Barranquero <lekktu@gmail.com>
12376
12377 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12378 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12379 Remove unused parameter `fildes'.
12380 * process.c (read_process_output, send_process): Don't pass it.
12381
84d358f0
JB
123822011-05-04 Juanma Barranquero <lekktu@gmail.com>
12383
12384 Fix previous change: the library cache is defined in w32.c.
12385 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12386 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12387
0898ca10
JB
123882011-05-04 Juanma Barranquero <lekktu@gmail.com>
12389
12390 Implement dynamic loading of GnuTLS on Windows.
12391
12392 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12393 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12394 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12395 Declare.
12396
12397 * gnutls.c (Qgnutls_dll): Define.
12398 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12399 (gnutls_*): Declare function pointers.
12400 (init_gnutls_functions): New function to initialize function pointers.
12401 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12402 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12403 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12404 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12405 (emacs_gnutls_write, emacs_gnutls_read)
12406 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12407 (Fgnutls_available_p): New function.
12408 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12409 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12410 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12411
12412 * image.c: Include w32.h.
12413 (Vimage_type_cache): Delete.
12414 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12415 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12416 (w32_delayed_load): Move to w32.c.
12417
12418 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12419
12420 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12421 (w32_delayed_load): Move from image.c. When loading a library, record
12422 its filename in the :loaded-from property of the library id.
12423 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12424 Initialize and staticpro them.
12425 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12426
12427 * process.c: Include lisp.h before w32.h, not after.
12428 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12429 instead of gnutls_record_check_pending.
12430
12431 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12432
ff4de4aa
TZ
124332011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12434
12435 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12436 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12437 as passed in.
12438
abe95abb
JD
124392011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12440
12441 * xterm.c (x_set_frame_alpha): Do not set property on anything
12442 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12443
e16e55d4
JB
124442011-05-02 Juanma Barranquero <lekktu@gmail.com>
12445
12446 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12447
bafcf6a5
JB
124482011-05-02 Juanma Barranquero <lekktu@gmail.com>
12449
12450 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12451 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12452 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12453 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12454 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12455 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12456 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12457 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12458 (Qgnutls_bootprop_callbacks_verify): Make static.
12459
e7a6747f
AS
124602011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12461
19ed11ba
AS
12462 * callproc.c: Indentation fixup.
12463
e7a6747f 12464 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12465 (wait_for_termination, interruptible_wait_for_termination):
12466 Move after wait_for_termination_1.
e7a6747f 12467
1ef14cb4
LMI
124682011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12469
12470 * sysdep.c (interruptible_wait_for_termination): New function
12471 which is like wait_for_termination, but allows keyboard
12472 interruptions.
12473
12474 * callproc.c (Fcall_process): Add (:file "file") as an option for
12475 the STDOUT buffer.
12476 (Fcall_process_region): Ditto.
12477
330d880c
EZ
124782011-04-30 Eli Zaretskii <eliz@gnu.org>
12479
8db90b73
EZ
12480 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12481 rather than `XVECTOR (FOO)->size'.
12482
330d880c
EZ
12483 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12484 inttypes.h, as a gnulib replacement is used if it not available in
12485 system headers.
12486
15cbd324
EZ
124872011-04-21 Eli Zaretskii <eliz@gnu.org>
12488
12489 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12490 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12491 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12492
12493 * coding.c (coding_alloc_by_realloc): Error out if destination
12494 will grow beyond MOST_POSITIVE_FIXNUM.
12495 (decode_coding_emacs_mule): Abort if there isn't enough place in
12496 charbuf for the composition carryover bytes. Reserve an extra
12497 space for up to 2 characters produced in a loop.
12498 (decode_coding_iso_2022): Abort if there isn't enough place in
12499 charbuf for the composition carryover bytes.
12500
125012011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12502
ae940cca
EZ
12503 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12504 aborting when %lld or %lll format is passed.
12505 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12506 %llo or %llx format is passed. (Bug#8545)
12507
03ab8921
EZ
12508 * window.c (window_scroll_line_based): Use a marker instead of
12509 simple variables to record original value of point. (Bug#7952)
12510
afda1437
EZ
12511 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12512 produced by %s or %c overflows available buffer space. (Bug#8545)
12513
f76dee0c
PE
125142011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12515
12516 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12517 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12518
fdc5744d
JB
125192011-04-28 Juanma Barranquero <lekktu@gmail.com>
12520
12521 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12522
638f053a
JB
125232011-04-28 Juanma Barranquero <lekktu@gmail.com>
12524
12525 * keyboard.c (Qdelayed_warnings_hook): Define.
12526 (command_loop_1): Run `delayed-warnings-hook'
12527 if Vdelayed_warnings_list is non-nil.
12528 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12529 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12530
d178f871
EZ
125312011-04-28 Eli Zaretskii <eliz@gnu.org>
12532
12533 * doprnt.c (doprnt): Don't return value smaller than the buffer
12534 size if the message was truncated. (Bug#8545).
12535
b124fd93
JB
125362011-04-28 Juanma Barranquero <lekktu@gmail.com>
12537
12538 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12539 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12540
e810457d
PE
125412011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12542
12543 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12544
ea51cceb
JB
125452011-04-27 Juanma Barranquero <lekktu@gmail.com>
12546
12547 * makefile.w32-in: Update dependencies.
12548
94dcfacf
EZ
125492011-04-27 Eli Zaretskii <eliz@gnu.org>
12550
12551 Improve `doprnt' and its usage. (Bug#8545)
12552 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12553 `format_end'. Remove support for %l as a conversion specifier.
12554 Don't use xrealloc. Improve diagnostics when the %l size modifier
12555 is used. Update the commentary.
12556
12557 * eval.c (verror): Simplify calculation of size_t.
12558
12559 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12560 messages.
12561
f61f41d7
PE
125622011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12563
12564 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12565 change.
12566
96fb4434
PE
125672011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12568
12569 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12570 This makes this file independent of the recent pseudovector change.
12571
671875da 125722011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12573
69e9b5a3
PE
12574 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12575
b5f869a7 12576 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12577 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12578 Remove unused local.
c8926152 12579 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12580
841a1577 12581 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12582 GCC 4.6.0 optimizes based on type-based alias analysis.
12583 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12584 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12585 != &v->size, and therefore "v->size = 1; b->size = 2; return
12586 v->size;" must therefore return 1. This assumption is incorrect
12587 for Emacs, since it type-puns struct Lisp_Vector * with many other
12588 types. To fix this problem, this patch adds a new type struct
f904488f 12589 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12590 and pseudovectors, and helps optimizing compilers not get fooled
12591 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12592 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12593 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12594 the size member.
eab3844f
PE
12595 (XSETPVECTYPE): Rewrite in terms of new macro.
12596 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12597 This is a bit clearer, and further avoids the possibility of
12598 undesirable aliasing.
12599 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12600 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12601 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12602 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12603 (ASIZE): Now uses header.size rather than size.
12604 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12605 to avoid the hassle of writing XVECTOR (foo)->header.size.
12606 (struct vectorlike_header): New type.
eab3844f
PE
12607 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12608 object, to help avoid aliasing.
12609 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12610 (SUBRP): Likewise, since Lisp_Subr is a special case.
12611 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12612 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12613 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12614 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12615 changed to be "header.size" and "header.next".
12616 * buffer.h (struct buffer): Likewise.
12617 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12618 * frame.h (struct frame): Likewise.
12619 * process.h (struct Lisp_Process): Likewise.
12620 * termhooks.h (struct terminal): Likewise.
12621 * window.c (struct save_window_data, struct saved_window): Likewise.
12622 * window.h (struct window): Likewise.
12623 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12624 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12625 * buffer.c (init_buffer_once): Likewise.
12626 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12627 special case.
12628 * process.c (Fformat_network_address): Use local var for size,
12629 for brevity.
12630
0df1eac5
PE
12631 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12632
847ab9d1 12633 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12634 * data.c (atof): Remove decl; no longer used or needed.
12635 (digit_to_number): Move to lread.c.
12636 (Fstring_to_number): Use new string_to_number function, to be
12637 consistent with how the Lisp reader treats infinities and NaNs.
12638 Do not assume that floating-point numbers represent EMACS_INT
12639 without losing information; this is not true on most 64-bit hosts.
12640 Avoid double-rounding errors, by insisting on integers when
12641 parsing non-base-10 numbers, as the documentation specifies.
12642 * lisp.h (string_to_number): New decl, replacing ...
12643 (isfloat_string): Remove.
bc0a5c13 12644 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12645 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12646 appears to have been a coding error. Similarly, do not accept
12647 strings like +-1e0 as floating point numbers. Do not report
12648 overflow for integer overflows unless the base is not 10 which
12649 means we have no simple and reliable way to continue.
12650 Break out the floating-point parsing into a new
12651 function string_to_number, so that Fstring_to_number parses
12652 floating point numbers consistently with the Lisp reader.
04f2d78b 12653 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12654 (E_CHAR, EXP_INT): Remove, replacing with ...
12655 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12656 (string_to_number): New function, replacing isfloat_string.
12657 This function checks for valid syntax and produces the resulting
12658 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12659 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12660 so that overflow for non-base-10 numbers is reported only when
12661 there's no portable and simple way to convert to floating point.
452f4150 12662
67769ffc
PE
12663 * textprop.c (set_text_properties_1): Rewrite for clarity,
12664 and to avoid GCC warning about integer overflow.
12665
c20db43f
PE
12666 * intervals.h (struct interval): Use EMACS_INT for members
12667 where EMACS_UINT might cause problems. See
12668 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12669 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12670 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12671 All uses changed.
37aa2f85
PE
12672 (offset_intervals): Tell GCC not to worry about length overflow
12673 when negating a negative length.
c20db43f 12674
2538aa2f
PE
12675 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12676 (overrun_check_free): Likewise.
12677
f2d3008d
PE
12678 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12679 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12680 word size.
12681
ec8df744
PE
12682 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12683 (gnutls_make_error): Rename local to avoid shadowing.
12684 (gnutls_emacs_global_deinit): ifdef out; not used.
12685 (Fgnutls_boot): Use const for pointer to readonly storage.
12686 Comment out unused local. Fix pointer signedness problems.
12687
640ee02d
PE
12688 * lread.c (openp): Don't stuff size_t into an 'int'.
12689 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12690 about possible signed overflow.
12691
6048fb2a
PE
12692 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12693 (GDK_KEY_g): Don't define if already defined.
12694 (xg_prepare_tooltip): Avoid pointer signedness problem.
12695 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12696
fa3c87e1
PE
12697 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12698 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12699
2172544b
PE
12700 * xfns.c (Fx_window_property): Simplify a bit,
12701 to make a bit faster and to avoid GCC 4.6.0 warning.
12702 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12703
9b821a21
PE
12704 * fns.c (internal_equal): Don't assume size_t fits in int.
12705
3c616cfa
PE
12706 * alloc.c (compact_small_strings): Tighten assertion a little.
12707
c2982e87
PE
12708 Replace pEd with more-general pI, and fix some printf arg casts.
12709 * lisp.h (pI): New macro, generalizing old pEd macro to other
12710 conversion specifiers. For example, use "...%"pI"d..." rather
12711 than "...%"pEd"...".
12712 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12713 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12714 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12715 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12716 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12717 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12718 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12719 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12720 64-bit hosts.
12721 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12722 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12723 * print.c (safe_debug_print, print_object): Likewise.
12724 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12725 to int.
6f04d126
PE
12726 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12727 avoiding the 0 flag, which is not portable.
c2982e87
PE
12728 * process.c (Fmake_network_process): Use pI to avoid cast.
12729 * region-cache.c (pp_cache): Likewise.
12730 * xdisp.c (decode_mode_spec): Likewise.
12731 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12732 behavior on 64-bit hosts with printf arg.
6f04d126 12733 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12734 (x_stop_queuing_selection_requests): Likewise.
12735 (x_get_window_property): Don't truncate byte count to an 'int'
12736 when tracing.
0b432f21 12737
5e073ec7
PE
12738 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12739 here, since it parses constructs like leading '-' and spaces,
12740 which are not wanted; and it overflows with large numbers.
12741 Instead, simply match F[0-9]+, which is what is wanted anyway.
12742
36372bf9
PE
12743 * alloc.c: Remove unportable assumptions about struct layout.
12744 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12745 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12746 (allocate_vectorlike, make_pure_vector): Use the new macros,
12747 plus offsetof, to remove unportable assumptions about struct layout.
12748 These assumptions hold on all porting targets that I know of, but
12749 they are not guaranteed, they're easy to remove, and removing them
12750 makes further changes easier.
12751
0b432f21
PE
12752 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12753 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12754 (string_overrun_cookie): Now const. Use initializers that
12755 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12756 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12757 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12758 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12759 multiple of sizeof (EMACS_INT); it need not be, if
12760 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12761 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12762
895009e1
JB
127632011-04-26 Juanma Barranquero <lekktu@gmail.com>
12764
12765 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12766
6a7a1b0b
TZ
127672011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12768
12769 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12770 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12771 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12772
841a1577 127732011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12774
12775 * lisp.h (Qdebug): List symbol.
895009e1 12776 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12777 * keyboard.c (debug-on-event): New variable.
12778 (handle_user_signal): Break into debugger when debug-on-event
12779 matches the current signal symbol.
12780
f2d3ba6f
DN
127812011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12782
12783 * alloc.c (check_sblock, check_string_bytes)
12784 (check_string_free_list): Convert to standard C.
12785
42ce4c63
TZ
127862011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12787
12788 * w32.c (emacs_gnutls_push): Fix typo.
12789
825cd63c
EZ
127902011-04-25 Eli Zaretskii <eliz@gnu.org>
12791
fb11d64d
EZ
12792 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12793 "cast to pointer from integer of different size".
12794
825cd63c
EZ
12795 Improve doprnt and its use in verror. (Bug#8545)
12796 * doprnt.c (doprnt): Document the set of format control sequences
12797 supported by the function. Use SAFE_ALLOCA instead of always
12798 using `alloca'.
12799
12800 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12801 is one byte too soon. Don't use xrealloc; instead xfree and
12802 xmalloc anew.
12803
e061a11b
TZ
128042011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12805
12806 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12807 callbacks stage.
12808
12809 * gnutls.c: Renamed global_initialized to
12810 gnutls_global_initialized. Added internals for the
12811 :verify-hostname-error, :verify-error, and :verify-flags
12812 parameters of `gnutls-boot' and documented those parameters in the
12813 docstring. Start callback support.
9173deec
JB
12814 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12815 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12816 on error. Return error code.
e061a11b
TZ
12817 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12818 (emacs_gnutls_read): Likewise.
12819 (Fgnutls_boot): Return handshake error code.
12820 (emacs_gnutls_handle_error): New function.
12821 (wsaerror_to_errno): Likewise.
12822
12823 * w32.h (emacs_gnutls_pull): Add prototype.
12824 (emacs_gnutls_push): Likewise.
12825
12826 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12827 (emacs_gnutls_push): Likewise.
12828
128292011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12830
12831 * process.c (wait_reading_process_output): Check if GnuTLS
12832 buffered some data internally if no FDs are set for TLS
12833 connections.
12834
12835 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12836 (LIBS): Link to USER_LIBS.
12837 ($(BLD)/gnutls.$(0)): New target.
12838
fa6996bc
EZ
128392011-04-24 Eli Zaretskii <eliz@gnu.org>
12840
eb35682e
EZ
12841 * xdisp.c (handle_single_display_spec): Rename the
12842 display_replaced_before_p argument into display_replaced_p, to
12843 make it consistent with the commentary. Fix typos in the
12844 commentary.
12845
e2ad650c
EZ
12846 * textprop.c (syms_of_textprop): Remove dead code.
12847 (copy_text_properties): Delete obsolete commentary about an
12848 interface that was deleted long ago. Fix typos in the description
12849 of arguments.
12850
1b2de274
EZ
12851 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12852 to changes in oldXMenu/XMenu.h from 2011-04-16.
12853 <menu_help_message, prev_menu_help_message>: Constify.
12854 (IT_menu_make_room): menu->help_text is now `const char **';
12855 adjust.
12856
12857 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12858 to changes in oldXMenu/XMenu.h from 2011-04-16.
12859 (struct XMenu): Declare `help_text' `const char **'.
12860
12861 * xfaces.c <Qunspecified>: Make extern again.
12862
12863 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12864 required by POSIX.
1b2de274 12865
762b15be
EZ
12866 * doc.c (get_doc_string): Improve the format passed to `error'.
12867
12868 * doprnt.c (doprnt): Improve commentary.
12869
12870 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12871
12872 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12873 them with etags.
12874
f1052e5d
EZ
12875 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12876 changes in globals.h immediately force recompilation.
762b15be
EZ
12877 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12878 $(CURDIR)/s/ms-w32.h.
12879 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12880
fa6996bc
EZ
12881 * character.c (Fchar_direction): Function deleted.
12882 (syms_of_character): Don't defsubr it.
12883 <char-direction-table>: Deleted.
12884
e6c3da20
EZ
128852011-04-23 Eli Zaretskii <eliz@gnu.org>
12886
12887 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12888 * doprnt.c: Include limits.h.
12889 (SIZE_MAX): New macro.
04f2d78b
CB
12890 (doprnt): Return a size_t value. 2nd arg is now size_t.
12891 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12892 Improve overflow protection. Support `l' modifier for integer
12893 conversions. Support %l conversion. Don't assume an EMACS_INT
12894 argument for integer conversions and for %c.
12895
12896 * lisp.h (doprnt): Restore prototype.
12897
12898 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12899 $(SRC)/character.h.
12900
12901 * Makefile.in (base_obj): Add back doprnt.o.
12902
12903 * deps.mk (doprnt.o): Add back prerequisites.
12904 (callint.o): Depend on character.h.
12905
12906 * eval.c (internal_lisp_condition_case): Include the handler
12907 representation in the error message.
12908 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12909 when breaking from the loop.
12910
12911 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12912
12913 * callint.c (Fcall_interactively): When displaying error message
12914 about invalid control letter, pass the character's codepoint, not
12915 a pointer to its multibyte form. Improve display of the character
12916 in octal and display also its hex code.
12917
12918 * character.c (char_string): Use %x to display the (unsigned)
12919 codepoint of an invalid character, to avoid displaying a bogus
12920 negative value.
12921
12922 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12923 `error', not SYMBOL_NAME itself.
12924
12925 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12926 character arguments to `error'.
12927
12928 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12929 to `error' in error message about FINAL_CHAR argument. Make sure
12930 FINAL_CHAR is a character, and use %c when it is passed as
12931 argument to `error'.
12932
4ffd0d6b 129332011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12934
12935 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12936
12937 * w32.c: Include <time.h>.
12938 (sys_localtime): New function.
12939
4ffd0d6b 129402011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12941
12942 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12943
4ffd0d6b 12944 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12945
4ffd0d6b 129462011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12947
4ffd0d6b
GM
12948 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12949 zombies (Bug#8467).
aac0c6e3 12950
04c56954
EZ
129512011-04-19 Eli Zaretskii <eliz@gnu.org>
12952
12953 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12954 gl_state.e_property when gl_state.object is Qt.
12955
12956 * insdel.c (make_gap_larger): Remove limitation of buffer size
12957 to <= INT_MAX.
12958
16a43933
CY
129592011-04-18 Chong Yidong <cyd@stupidchicken.com>
12960
12961 * xdisp.c (lookup_glyphless_char_display)
12962 (produce_glyphless_glyph): Handle cons cell entry in
12963 glyphless-char-display.
12964 (Vglyphless_char_display): Document it.
12965
12966 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12967 glyphless-char-display.
12968
4581706e
CY
129692011-04-17 Chong Yidong <cyd@stupidchicken.com>
12970
12971 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12972
12973 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12974
12975 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12976 definition for no-X builds.
12977
4887c6e2 129782011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12979
fd35b6f9
PE
12980 Static checks with GCC 4.6.0 and non-default toolkits.
12981
5c1ccb01
PE
12982 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12983
006c5daa
PE
12984 * process.c (keyboard_bit_set): Define only if SIGIO.
12985 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12986 (send_process): Repair possible setjmp clobbering.
12987
efc736d3
PE
12988 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12989
4e2fe2e6
PE
12990 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12991
f97334a2
PE
12992 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12993
4e75f29d
PE
12994 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12995 Define only if needed.
12996
90efadd1
PE
12997 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12998 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12999 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13000
3c647824
PE
13001 * dispextern.h (struct redisplay_interface): Rename param
13002 to avoid shadowing.
e264f262 13003 * termhooks.h (struct terminal): Likewise.
761383f4 13004 * xterm.c (xembed_send_message): Likewise.
3c647824 13005
b58c5c4a
PE
13006 * insdel.c (make_gap_smaller): Define only if
13007 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13008
cad59032
PE
13009 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13010 it.
13011
c339dc2e
PE
13012 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13013 so that we aren't warned about unused symbols.
13014
91a3e27b
PE
13015 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13016
399c71d3 13017 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13018
8ffc96f5
PE
13019 * xfns.c (x_real_positions): Mark locals as initialized.
13020
eef9bc79
PE
13021 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13022
098db9dd
PE
13023 * xterm.c: Fix problems found by static analysis with other toolkits.
13024 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13025 (x_dispatch_event): Declare static if USE_GTK, and
13026 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13027 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13028 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13029 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13030 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13031
eb18f6cc
PE
13032 * xmenu.c (menu_help_callback): Pointer type fixes.
13033 Use const pointers when pointing at readonly data. Avoid pointer
13034 signedness clashes.
13035 (FALSE): Remove unused macro.
13036 (update_frame_menubar): Remove unused decl.
13037
1fe72bf8
PE
13038 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13039
60d9e1db
PE
13040 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13041 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13042 (single_menu_item): Rename local to avoid shadowing.
13043
39261c26
PE
13044 * keyboard.c (make_lispy_event): Remove unused local var.
13045
018c5e19
PE
13046 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13047 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13048
63d2b86e
PE
13049 * bitmaps: Change bitmaps from unsigned char back to the X11
13050 compatible char. Avoid the old compiler warnings about
13051 out-of-range initializers by using, for example, '\xab' rather
13052 than 0xab.
13053
aefd87e1
PE
13054 * xgselect.c (xgselect_initialize): Check vs interface
13055 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13056
bf501fb9
PE
13057 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13058
e9829fdf
PE
13059 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13060 to read-only memory.
13061
1086c095
PE
13062 * fns.c (vector): Remove; this old hack is no longer needed.
13063
2baccd04 13064 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13065 Remove unused var.
dde42981 13066 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13067
72391843 13068 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13069
436c16df 13070 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13071 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13072 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13073
92bb796d 13074 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13075 (x_term_init): Remove local to avoid shadowing.
92bb796d 13076
764430a3 13077 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13078
13079 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13080 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13081
d1dfb56c
EZ
130822011-04-16 Eli Zaretskii <eliz@gnu.org>
13083
c4354cb4
EZ
13084 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13085
d1dfb56c
EZ
13086 Fix regex.c, syntax.c and friends for buffers > 2GB.
13087 * syntax.h (struct gl_state_s): Declare character position members
13088 EMACS_INT.
13089
13090 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13091
04f2d78b
CB
13092 * textprop.c (verify_interval_modification, interval_of):
13093 Declare arguments EMACS_INT.
d1dfb56c
EZ
13094
13095 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13096 EMACS_INT.
13097
13098 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13099
13100 * indent.c (Fvertical_motion): Local variable it_start is now
13101 EMACS_INT.
13102
13103 * regex.c (re_match, re_match_2, re_match_2_internal)
13104 (bcmp_translate, regcomp, regexec, print_double_string)
13105 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13106 (re_compile_pattern, re_exec): Declare arguments and local
13107 variables `size_t' and `ssize_t' and return values `regoff_t', as
13108 appropriate.
13109 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13110 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13111 <compile_stack_type>: `size' and `avail' are now `size_t'.
13112
13113 * regex.h <regoff_t>: Use ssize_t, not int.
13114 (re_search, re_search_2, re_match, re_match_2): Arguments that
13115 specify buffer/string position and length are now ssize_t and
13116 size_t. Return type is regoff_t.
13117
613052cd
BK
131182011-04-16 Ben Key <bkey76@gmail.com>
13119
13120 * nsfont.m: Fixed bugs in ns_get_family and
13121 ns_descriptor_to_entity that were caused by using free to
13122 deallocate memory blocks that were allocated by xmalloc (via
13123 xstrdup). This caused Emacs to crash when compiled with
13124 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13125 --enable-checking=xmallocoverrun). xfree is now used to
13126 deallocate these memory blocks.
13127
4170f62f 131282011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13129
71b41406
PE
13130 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13131
9587a89d
PE
13132 emacs_write: Accept and return EMACS_INT for sizes.
13133 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13134 et seq.
13135 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13136 Accept and return EMACS_INT.
13137 (emacs_gnutls_write): Return the number of bytes written on
13138 partial writes.
13139 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13140 (emacs_read, emacs_write): Remove check for negative size, as the
13141 Emacs source code has been audited now.
9587a89d
PE
13142 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13143 (emacs_read, emacs_write): Use it.
273a5f82
PE
13144 * process.c (send_process): Adjust to the new signatures of
13145 emacs_write and emacs_gnutls_write. Do not attempt to store
13146 a byte offset into an 'int'; it might overflow.
9587a89d 13147 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13148
3e047f51
PE
13149 * sound.c: Don't assume sizes fit in 'int'.
13150 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13151 Return EMACS_INT, not int.
3e047f51 13152 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13153 Accept EMACS_INT, not int.
13154 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13155 record read return values.
13156
cc39a9db
BK
131572011-04-15 Ben Key <bkey76@gmail.com>
13158
c9d0ec6d
JB
13159 * keyboard.c (Qundefined): Don't declare static since it is used
13160 in nsfns.m.
13161 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13162 static since they are used in nsfont.m.
cc39a9db 13163
6c60eb9f
SM
131642011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13165
13166 * process.c (Qprocessp): Don't declare static.
13167 * lisp.h (Qprocessp): Declare again.
13168
7990b61a
JB
131692011-04-15 Juanma Barranquero <lekktu@gmail.com>
13170
13171 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13172
5d4cb038
PE
131732011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13174
8bd7b830 13175 Improve C-level modularity by making more things 'static'.
cd64ea1d 13176
e3b27b31
PE
13177 Don't publish debugger-only interfaces to other modules.
13178 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13179 (verify_bytepos, count_markers): Move decls to the only modules
13180 that need them.
13181 * region-cache.h (pp_cache): Likewise.
13182 * window.h (check_all_windows): Likewise.
13183 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13184
5d4cb038
PE
13185 * sysdep.c (croak): Now static, if
13186 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13187 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13188
13189 * alloc.c (refill_memory_reserve): Now static if
13190 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13191 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13192
e87b6180
PE
13193 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13194 Define only if USE_LUCID.
13195
ac64929e
PE
13196 * xrdb.c (x_customization_string, x_rm_string): Now static.
13197
6f37259d
PE
13198 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13199 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13200
1683e3ab
PE
13201 * xdisp.c (draw_row_with_mouse_face): Now static.
13202 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13203
de9c2632
PE
13204 * window.h (check_all_windows): Mark externally visible.
13205
2b96acb7
PE
13206 * window.c (window_deletion_count): Now static.
13207
13208 * undo.c: Make symbols static if they're not exported.
13209 (last_undo_buffer, last_boundary_position, pending_boundary):
13210 Now static.
13211
50436f33
PE
13212 * textprop.c (interval_insert_behind_hooks): Now static.
13213 (interval_insert_in_front_hooks): Likewise.
13214
64520e5c
PE
13215 * term.c: Make symbols static if they're not exported.
13216 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13217 (max_frame_lines, tty_set_terminal_modes):
13218 (tty_reset_terminal_modes, tty_turn_off_highlight):
13219 (get_tty_terminal): Now static.
13220 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13221 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13222 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13223 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13224 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13225
1fa53021
PE
13226 * sysdep.c: Make symbols static if they're not exported.
13227 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13228 Now static.
13229 (sigprocmask_set, full_mask): Remove; unused.
13230 (wait_debugging): Mark as visible.
13231 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13232 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13233
d4b43b22
PE
13234 * syntax.c (syntax_temp): Define only if !__GNUC__.
13235
b7c513d0
PE
13236 * sound.c (current_sound_device, current_sound): Now static.
13237
989b29ad
PE
13238 * search.c (searchbufs, searchbuf_head): Now static.
13239
13a55a78
PE
13240 * scroll.c (scroll_cost): Remove; unused.
13241 * dispextern.h (scroll_cost): Remove decl.
13242
de68a1fc
PE
13243 * region-cache.h (pp_cache): Mark as externally visible.
13244
40ccffa6
PE
13245 * process.c: Make symbols static if they're not exported.
13246 (process_tick, update_tick, create_process, chan_process):
13247 (Vprocess_alist, proc_buffered_char, datagram_access):
13248 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13249 (deactivate_process): Mark defn as static, as well as decl.
13250 * lisp.h (create_process): Remove decl.
13251 * process.h (chan_process, Vprocess_alist): Remove decls.
13252
ad64fc97
PE
13253 * print.c: Make symbols static if they're not exported.
13254 (print_depth, new_backquote_output, being_printed, print_buffer):
13255 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13256 (print_interval, print_number_index, initial_stderr_stream):
13257 Now static.
13258 * lisp.h (Fprinc): Remove decl.
13259 (debug_output_compilation_hack): Mark as externally visible.
13260
adddb265
PE
13261 * sysdep.c (croak): Move decl from here to syssignal.h.
13262 * syssignal.h (croak): Put it here, so the API can be checked when
13263 'croak' is called from dissociate_if_controlling_tty.
13264
1717ede2
PE
13265 * minibuf.c: Make symbols static if they're not exported.
13266 (minibuf_save_list, choose_minibuf_frame): Now static.
13267 * lisp.h (choose_minibuf_frame): Remove decl.
13268
fa5fb2bc
PE
13269 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13270
1e3890d1
PE
13271 * lread.c: Make symbols static if they're not exported.
13272 (read_objects, initial_obarray, oblookup_last_bucket_number):
13273 Now static.
13274 (make_symbol): Remove; unused.
13275 * lisp.h (initial_obarray, make_symbol): Remove decls.
13276
8a1414fa
PE
13277 * keyboard.c: Make symbols static if they're not exported.
13278 (single_kboard, recent_keys_index, total_keys, recent_keys):
13279 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13280 (this_single_command_key_start, echoing, last_auto_save):
13281 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13282 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13283 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13284 (Vlispy_mouse_stem, double_click_count):
13285 Now static.
13286 (force_auto_save_soon): Define only if SIGDANGER.
13287 (ignore_mouse_drag_p): Now static if
13288 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13289 (print_help): Remove; unused.
13290 (stop_character, last_timer_event): Mark as externally visible.
13291 * keyboard.h (ignore_mouse_drag_p): Declare only if
13292 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13293 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13294 * lisp.h (echoing): Remove decl.
13295 (force_auto_save_soon): Declare only if SIGDANGER.
13296 * xdisp.c (redisplay_window): Simplify code, to make it more
13297 obvious that ignore_mouse_drag_p is not accessed if !defined
13298 USE_GTK && !defined HAVE_NS.
13299
93ea6e8f
PE
13300 * intervals.c: Make symbols static if they're not exported.
13301 (merge_properties_sticky, merge_interval_right, delete_interval):
13302 Now static.
13303 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13304
77382fcc
PE
13305 * insdel.c: Make symbols static if they're not exported.
13306 However, leave prepare_to_modify_buffer alone. It's never
13307 called from outside this function, but that appears to be a bug.
13308 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13309 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13310 (adjust_after_replace_noundo): Remove; unused.
13311 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13312 (signal_before_change): Remove decls.
77382fcc 13313
9306c32e
PE
13314 * indent.c (val_compute_motion, val_vmotion): Now static.
13315
cd44d2eb
PE
13316 * image.c: Make symbols static if they're not exported.
13317 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13318 if USE_GTK.
13319 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13320 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13321
ad9a7a06
PE
13322 * fringe.c (standard_bitmaps): Now static.
13323 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13324
81626931
PE
13325 * frame.c: Make symbols static if they're not exported.
13326 (x_report_frame_params, make_terminal_frame): Now static.
13327 (get_frame_param): Now static, unless HAVE_NS.
13328 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13329 (x_get_resource_string): Remove; not used.
13330 * frame.h (make_terminal_frame, x_report_frame_params):
13331 (x_get_resource_string); Remove decls.
13332 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13333 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13334
239f9db9
PE
13335 * font.c, fontset.c: Make symbols static if they're not exported.
13336 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13337 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13338 * font.c (font_close_object): Now static.
13339 * font.h (font_close_object): Remove.
13340 * fontset.c (FONTSET_OBJLIST): Remove.
13341 (free_realized_fontset) #if-0 the body, which does nothing.
13342 (face_suitable_for_char_p): #if-0, as it's never called.
13343 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13344 * xfaces.c (face_at_string_position):
13345 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13346 since 0 is always ASCII.
13347
dfcf3579
PE
13348 * fns.c (weak_hash_tables): Now static.
13349
5045092b
PE
13350 * fileio.c: Make symbols static if they're not exported.
13351 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13352 (Vwrite_region_annotation_buffers): Now static.
13353
57a96f5c
PE
13354 * eval.c: Make symbols static if they're not exported.
13355 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13356 * lisp.h (backtrace_list): Remove decl.
13357
35f08c38
PE
13358 * emacs.c: Make symbols static if they're not exported.
13359 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13360 (fatal_error_code, fatal_error_signal_hook, standard_args):
13361 Now static.
13362 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13363 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13364 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13365 * lisp.h (fatal_error_signal_hook): Remove decl.
13366 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13367
f44bd759
PE
13368 * editfns.c: Move a (normally-unused) function to its only use.
13369 * editfns.c, lisp.h (get_operating_system_release): Remove.
13370 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13371 worth the hassle of breaking this out.
13372
b532497d
PE
13373 * xterm.c: Make symbols static if they're not exported.
13374 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13375 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13376 (x_destroy_window, x_delete_display):
13377 Now static.
13378 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13379 (x_mouse_leave): Remove; unused.
13380 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13381 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13382 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13383 Remove decls.
13384 (x_mouse_leave): Declare only if WINDOWSNT.
13385 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13386 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13387 USE_X_TOOLKIT.
13388
1675728f
PE
13389 * ftxfont.c: Make symbols static if they're not exported.
13390 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13391 HAVE_FREETYPE.
13392 * font.h (ftxfont_driver): Likewise.
13393
e4cebfca
PE
13394 * xfns.c: Make symbols static if they're not exported.
13395 (x_last_font_name, x_display_info_for_name):
13396 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13397 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13398 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13399 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13400 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13401 (last_show_tip_args): Now static.
13402 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13403 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13404 (x_screen_planes): Remove; unused.
13405 * dispextern.h (x_screen_planes): Remove decl.
13406
5bf46f05
PE
13407 * dispnew.c: Make symbols static if they're not exported.
13408 * dispextern.h (redraw_garbaged_frames, scrolling):
13409 (increment_row_positions): Remove.
13410 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13411 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13412 Now static.
13413 (redraw_garbaged_frames): Remove; unused.
13414
435f4c28
PE
13415 * xfaces.c: Make symbols static if they're not exported.
13416 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13417 Remove decls.
13418 * xterm.h (defined_color): Remove decls.
13419 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13420 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13421 (menu_face_changed_default, defined_color, free_realized_face):
13422 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13423 (ascii_face_of_lisp_face): Remove; unused.
13424
8524aef3
PE
13425 * xdisp.c: Make symbols static if they're not exported.
13426 * dispextern.h (scratch_glyph_row, window_box_edges):
13427 (glyph_to_pixel_coords, set_cursor_from_row):
13428 (get_next_display_element, set_iterator_to_next):
13429 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13430 (show_mouse_face): Remove decls
13431 * frame.h (message_buf_print): Likewise.
13432 * lisp.h (pop_message, set_message, check_point_in_composition):
13433 Likewise.
13434 * xterm.h (set_vertical_scroll_bar): Likewise.
13435 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13436 (message_buf_print, scratch_glyph_row, displayed_buffer):
13437 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13438 (get_next_display_element, show_mouse_face, window_box_edges):
13439 (frame_to_window_pixel_xy, check_point_in_composition):
13440 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13441 (glyph_to_pixel_coords): Remove; unused.
13442
16390cd2
PE
13443 * dired.c (file_name_completion): Now static.
13444
13445 * dbusbind.c (xd_in_read_queued_messages): Now static.
13446
a25f4dfa
PE
13447 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13448 * data.c (circular_list_error): Remove.
13449
14a9c8df
PE
13450 * commands.h (last_point_position, last_point_position_buffer):
13451 (last_point_position_window): Remove decls.
13452 * keyboard.c: Make these variables static.
13453
04f2d78b
CB
13454 * coding.h (coding, code_convert_region, encode_coding_gap):
13455 Remove decls.
74ab6df5
PE
13456 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13457 (iso_code_class, detect_coding, code_convert_region): Now static.
13458 (encode_coding_gap): Remove; unused.
13459
38dfbee1
PE
13460 * chartab.c (chartab_chars, chartab_bits): Now static.
13461
a2cb4e63
PE
13462 * charset.h (charset_iso_8859_1): Remove decl.
13463 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13464 Now static.
13465
127198fd
PE
13466 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13467 * ccl.c (Vccl_program_table): Now static.
13468 (check_ccl_update): Remove; unused.
13469
d85b608f
PE
13470 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13471 * category.h: ... from here.
13472 * category.c (check_category_table, set_category_set): Now static.
13473
31cd66f3
PE
13474 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13475 * lisp.h: Remove these decls.
13476
c358e587
PE
13477 * buffer.c (buffer_count): Remove unused var.
13478
e78aecca
PE
13479 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13480 so that it's not optimized away.
13481 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13482 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13483 exported only to the debugger.
13484
e192d7d3 13485 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13486 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13487
92470028
PE
13488 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13489 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13490 was inaccessible from Lisp.
13491 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13492 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13493
244ed907
PE
13494 alloc.c: Import and export fewer symbols, and remove unused items.
13495 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13496 is defined.
13497 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13498 it's not optimized away by whole-program optimization.
13499 (message_enable_multibyte, free_misc): Remove.
13500 (catchlist, handlerlist, mark_backtrace):
13501 Declare only if BYTE_MARK_STACK.
13502 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13503 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13504 (message_enable_multibyte): Remove decl.
13505 (free_misc, interval_free_list, float_block, float_block_index):
13506 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13507 (cons_free_list, last_marked_index):
13508 Now static.
13509 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13510 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13511 (mark_backtrace): Define only if BYTE_MARK_STACK.
13512 * xdisp.c (message_enable_multibyte): Now static.
13513
61c2b50e 13514 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13515 This makes it easier for human readers (and static analyzers)
13516 to see whether these variables are used from other modules.
13517 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13518 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13519 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13520 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13521 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13522 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13523 * xmenu.c, xselect.c:
13524 Declare Q* vars static if they are not used in other modules.
13525 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13526 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13527 Remove decls of unexported vars.
13528 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13529
95c82688
PE
13530 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13531
16a97296
PE
13532 Make Emacs functions such as Fatom 'static' by default.
13533 This makes it easier for human readers (and static analyzers)
13534 to see whether these functions can be called from other modules.
13535 DEFUN now defines a static function. To make the function external
13536 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13537 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13538 (Finit_image_library):
16a97296
PE
13539 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13540 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13541 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13542 Remove decls, since these functions are now static.
13543 (Funintern, Fget_internal_run_time): New decls, since these functions
13544 were already external.
95c82688 13545
16a97296
PE
13546 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13547 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13548 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13549 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13550 * keyboard.c, keymap.c, lread.c:
13551 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13552 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13553 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13554 Mark functions with DEFUE instead of DEFUN,
13555 if they are used in other modules.
13556 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13557 decls for now-static functions.
13558 * buffer.h (Fdelete_overlay): Remove decl.
13559 * callproc.c (Fgetenv_internal): Mark as internal.
13560 * composite.c (Fremove_list_of_text_properties): Remove decl.
13561 (Fcomposition_get_gstring): New forward static decl.
13562 * composite.h (Fcomposite_get_gstring): Remove decl.
13563 * dired.c (Ffile_attributes): New forward static decl.
13564 * doc.c (Fdocumntation_property): New forward static decl.
13565 * eval.c (Ffetch_bytecode): New forward static decl.
13566 (Funintern): Remove extern decl; now in .h file where it belongs.
13567 * fileio.c (Fmake_symbolic_link): New forward static decl.
13568 * image.c (Finit_image_library): New forward static decl.
13569 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13570 * intervals.h (Fprevious_property_change):
13571 (Fremove_list_of_text_properties): Remove decls.
13572 * keyboard.c (Fthis_command_keys): Remove decl.
13573 (Fcommand_execute): New forward static decl.
13574 * keymap.c (Flookup_key): New forward static decl.
13575 (Fcopy_keymap): Now static.
13576 * keymap.h (Flookup_key): Remove decl.
13577 * process.c (Fget_process): New forward static decl.
13578 (Fprocess_datagram_address): Mark as internal.
13579 * syntax.c (Fsyntax_table_p): New forward static decl.
13580 (skip_chars): Remove duplicate decl.
13581 * textprop.c (Fprevious_property_change): New forward static decl.
13582 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13583 Now internal.
13584 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13585 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13586
785bbd42
PE
13587 * editfns.c (Fformat): Remove unreachable code.
13588
8b913b57
AS
135892011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13590
13591 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13592 change. (Bug#8496)
13593
a6744a35
EZ
135942011-04-13 Eli Zaretskii <eliz@gnu.org>
13595
13596 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13597 when at ZV. (Bug#8487)
13598
e7974947
AS
135992011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13600
baad03f0
AS
13601 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13602 (Bug#8437)
13603 * keyboard.c (parse_tool_bar_item): Likewise.
13604 * sound.c (sound_cleanup, alsa_close): Likewise.
13605 * termcap.c (tgetent): Likewise.
13606 * xfns.c (x_default_font_parameter): Likewise.
13607 * xsettings.c (read_and_apply_settings): Likewise.
13608
e7974947
AS
13609 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13610 (overrun_check_free): Protoize.
13611
28272684
PE
136122011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13613
13614 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13615 since callers should never pass a negative size.
13616 Change the signature to match that of plain 'read' and 'write'; see
13617 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13618 * lisp.h: Update prototypes of emacs_write and emacs_read.
13619
11997c76
EZ
136202011-04-11 Eli Zaretskii <eliz@gnu.org>
13621
13622 * xdisp.c (redisplay_window): Don't try to determine the character
13623 position of the scroll margin if the window start point w->startp
e896f03c 13624 is outside the buffer's accessible region. (Bug#8468)
11997c76 13625
8a2cbd72
EZ
136262011-04-10 Eli Zaretskii <eliz@gnu.org>
13627
13628 Fix write-region and its subroutines for buffers > 2GB.
13629 * fileio.c (a_write, e_write): Modify declaration of arguments and
13630 local variables to support buffers larger than 2GB.
13631 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13632
13633 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13634 argument, local variables, and return value.
13635
13636 * lisp.h: Update prototypes of emacs_write and emacs_read.
13637
13638 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13639
4073e537 136402011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13641
1ebfdcb6
PE
13642 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13643
b2ded58d
PE
13644 Fix more problems found by GCC 4.6.0's static checks.
13645
7d66342c
PE
13646 * xdisp.c (vmessage): Use a better test for character truncation.
13647
bbf47d44
PE
13648 * charset.c (load_charset_map): <, not <=, for optimization,
13649 and to avoid potential problems with integer overflow.
9248994d 13650 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13651 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13652 * editfns.c (Fformat): Likewise.
1e69125e 13653 * syntax.c (skip_chars): Likewise.
3befa583 13654
e3019616
PE
13655 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13656 This also lets GCC 4.6.0 generate slightly better loop code.
13657
becfa255
PE
13658 * callint.c (Fcall_interactively): <, not <=, for optimization.
13659 (Fcall_interactively): Count the number of arguments produced,
13660 not the number of arguments given. This is simpler and lets GCC
13661 4.6.0 generate slightly better code.
13662
dae0cd48
PE
13663 * ftfont.c: Distingish more carefully between FcChar8 and char.
13664 The previous code passed unsigned char * to a functions like
13665 strlen and xstrcasecmp that expect char *, which does not
13666 conform to the C standard.
13667 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13668 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13669 char * when the C standard requires it.
13670
76032d70
PE
13671 * keyboard.c (read_char): Remove unused var.
13672
eb3f1cc8
PE
13673 * eval.c: Port to Windows vsnprintf (Bug#8435).
13674 Include <limits.h>.
13675 (SIZE_MAX): Define if the headers do not.
13676 (verror): Do not give up if vsnprintf returns a negative count.
13677 Instead, grow the buffer. This ports to Windows vsnprintf, which
13678 does not conform to C99. Problem reported by Eli Zaretskii.
13679 Also, simplify the allocation scheme, by avoiding the need for
13680 calling realloc, and removing the ALLOCATED variable.
13681
70476b54
PE
13682 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13683
12020a9e
PE
13684 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13685 But keep the doprint source code for now, as we might revamp it
13686 and use it again (Bug#8435).
ea6c7ae6
PE
13687 * lisp.h (doprnt): Remove.
13688 * Makefile.in (base_obj): Remove doprnt.o.
13689 * deps.mk (doprnt.o): Remove.
13690
5fdb398c
PE
13691 error: Print 32- and 64-bit integers portably (Bug#8435).
13692 Without this change, on typical 64-bit hosts error ("...%d...", N)
13693 was used to print both 32- and 64-bit integers N, which relied on
13694 undefined behavior.
61bdb816 13695 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13696 * lisp.h (error, verror): Mark as printf-like functions.
13697 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13698 Report overflow in size calculations when allocating printf buffer.
13699 Do not truncate output string at its first null byte.
13700 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13701 Truncate the output at a character boundary, since vsnprintf does not
13702 do that.
13703 * charset.c (check_iso_charset_parameter): Convert internal
13704 character to string before calling 'error', since %c now has the
13705 printf meaning.
13706 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13707 overflow when computing char to be passed to 'error'. Do not
13708 pass Lisp_Object to 'error'; pass the integer instead.
13709 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13710 formatted with plain %d.
13711
b189fa66
PE
13712 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13713
bff87ef0
PE
13714 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13715
7e2cac20
PE
13716 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13717
ce4d90b5
PE
13718 * xterm.c (x_catch_errors): Remove duplicate declaration.
13719
266c9547
PE
13720 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13721
79c49ad2
PE
13722 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13723
368f4090
JM
137242011-04-10 Jim Meyering <meyering@redhat.com>
13725
13726 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13727 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13728 return ssize_t not "int", and use size_t as the buffer length.
13729 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13730 * gnutls.h: Update declarations.
13731 * process.c (read_process_output): Use ssize_t, to match.
13732 (send_process): Likewise.
13733
a32d4040
CY
137342011-04-09 Chong Yidong <cyd@stupidchicken.com>
13735
13736 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13737
8546720e 137382011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13739
04f2d78b
CB
13740 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13741 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13742
8546720e
GM
13743 * xterm.c (handle_one_xevent):
13744 * xmenu.c (create_and_show_popup_menu):
13745 * xselect.c (x_decline_selection_request)
13746 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13747
0a2f5c1a 137482011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13749
13750 Fix some uses of `int' instead of EMACS_INT.
13751 * search.c (string_match_1, fast_string_match)
13752 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13753 (scan_buffer, find_next_newline_no_quit)
13754 (find_before_next_newline, search_command, Freplace_match)
13755 (Fmatch_data): Make some `int' variables be EMACS_INT.
13756
13757 * xdisp.c (display_count_lines): 3rd argument and return value now
13758 EMACS_INT. All callers changed.
13759 (pint2hrstr): Last argument is now EMACS_INT.
13760
13761 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13762 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13763 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13764 (decode_coding_utf_16, decode_coding_emacs_mule)
13765 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13766 (decode_coding_ccl, decode_coding_charset)
13767 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13768 (decode_coding_iso_2022, decode_coding_emacs_mule)
13769 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13770 <char_offset, last_offset>: Declare EMACS_INT.
13771 (encode_coding_utf_8, encode_coding_utf_16)
13772 (encode_coding_emacs_mule, encode_invocation_designation)
13773 (encode_designation_at_bol, encode_coding_iso_2022)
13774 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13775 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13776 Declare EMACS_INT.
13777 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13778 (encode_invocation_designation): Last argument P_NCHARS is now
13779 EMACS_INT.
13780 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13781 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13782
13783 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13784 All users changed.
13785
13786 * ccl.c (Fccl_execute_on_string): Declare some variables
13787 EMACS_INT.
13788
8546720e 137892011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13790
13791 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13792
4e19a977
CS
137932011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13794
13795 * process.c (Fformat_network_address): Doc fix.
13796
87302331
R
137972011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13798
ee7683eb 13799 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13800
cbb59342
CY
138012011-04-08 Chong Yidong <cyd@stupidchicken.com>
13802
13803 * keyboard.c (read_char): Call Lisp function help-form-show,
13804 instead of using internal_with_output_to_temp_buffer.
13805 (Qhelp_form_show): New var.
e0d38eeb 13806 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13807
13808 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13809
13810 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13811
e67a13ab
CY
138122011-04-06 Chong Yidong <cyd@stupidchicken.com>
13813
04f2d78b
CB
13814 * process.c (Flist_processes): Remove to Lisp.
13815 (list_processes_1): Delete.
e67a13ab 13816
973f782d
EZ
138172011-04-06 Eli Zaretskii <eliz@gnu.org>
13818
7c106b1e
EZ
13819 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13820
973f782d
EZ
13821 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13822
41cf7d1a 138232011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13824
ca23cc88
PE
13825 Fix more problems found by GCC 4.6.0's static checks.
13826
f390e2d5
PE
13827 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13828
42eea0d0
PE
13829 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13830
b69769da 13831 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13832
f9541e84
PE
13833 * xdisp.c (vmessage): Mark as a printf-like function.
13834
13841b55
PE
13835 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13836
c136c10f
PE
13837 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13838
5e2d4a30
PE
13839 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13840 printf-like functions.
13841 (tiff_load): Add casts to remove these marks before passing them
13842 to system-supplied API.
13843
583f48b9
PE
13844 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13845
b25d760e
PE
13846 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13847 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13848 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13849 directly, rather than having caller test rule sign. This avoids
13850 some unnecessary tests.
13851 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13852 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13853 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13854
bc7b6697 13855 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13856 (xfont_open): Avoid unnecessary tests.
bc7b6697 13857
27ccc379
PE
13858 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13859
dcd5c89a
PE
13860 * composite.h, composite.c (composition_gstring_put_cache):
13861 Use EMACS_INT, not int, for length.
13862
b13a45c6
PE
13863 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13864 breaking out part of COMPOSITION_DECODE_RULE.
13865 (COMPOSITION_DECODE_RULE): Use it.
13866 * composite.c (get_composition_id): Remove unused local vars,
13867 by using the new macro.
13868
1e792e4d
PE
13869 * textprop.c (set_text_properties_1): Change while to do-while,
13870 since the condition is always true at first.
13871
dc6c6455 13872 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13873 (interval_deletion_adjustment): Return unsigned value.
13874 All uses changed.
dc6c6455 13875
aba7731a
PE
13876 * process.c (list_processes_1, create_pty, read_process_output):
13877 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13878 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13879 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13880 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13881 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13882
fdfc4bf3
PE
13883 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13884
fca8fe46 13885 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13886 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13887
06a0259a 13888 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13889 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13890 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13891
e7b9e80f
PE
13892 * print.c (print_error_message): Avoid int overflow.
13893
56201685
PE
13894 * font.c (font_list_entities): Redo for clarity,
13895 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13896
78834453 13897 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13898 (font_score): Avoid potential overflow in diff calculation.
78834453 13899
0bc0b309 13900 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13901 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13902
e610eaca
PE
13903 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13904
b895abce
PE
13905 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13906 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13907 can always succeed if overflow has undefined behavior.
13908
1f1d9321 13909 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13910 (wordify): Omit three unnecessary tests.
1f1d9321 13911
c59478bc
PE
13912 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13913 All callers changed. This avoids the need for an unused var.
13914
79b73827
PE
13915 * casefiddle.c (casify_region): Remove var that is set but not used.
13916
a4db5dfe
PE
13917 * dired.c (file_name_completion): Remove var that is set but not used.
13918
43aae36e
PE
13919 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13920
2a47c44d 13921 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13922 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13923
a37c69bf
PE
13924 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13925 Check for integer overflow on size calculations.
13926
328ab8e7
PE
13927 * buffer.c (Fprevious_overlay_change): Remove var that is set
13928 but not used.
13929
e5a2a5cb
PE
13930 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13931 Remove vars that are set but not used.
8d84a6eb 13932 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13933 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13934
a60e5f68
PE
13935 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13936
f661cb61 13937 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13938 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13939
f0397f5a
PE
13940 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13941 that are set but not used.
13942
8664db06 13943 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13944 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13945
6abdaa4a
PE
13946 * xselect.c (x_get_local_selection, x_handle_property_notify):
13947 Remove vars that are set but not used.
13948
0ce7538d 13949 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13950 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13951
9ae848fc
PE
13952 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13953 Remove var that is set but not used.
0b918413
PE
13954 (scroll_bar_windows_size): Now size_t, not int.
13955 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13956 Check for overflow.
9ae848fc 13957
a5a62657
PE
13958 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13959 (map_tty_color) [!defined MSDOS]: Likewise.
13960
5c5cdd39
PE
13961 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13962
66ebf983
PE
13963 * coding.c: Remove vars that are set but not used.
13964 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13965 All callers changed.
13966 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13967 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13968 (decode_coding_charset): Remove vars that are set but not used.
13969
1be4d761
PE
13970 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13971 that is set but not used.
13972
47553fa8
PE
13973 * print.c (print_object): Remove var that is set but not used.
13974
1f7196bf 13975 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13976 The gnulib version avoids calling malloc in the usual case,
13977 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13978 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13979 * filelock.c (current_lock_owner): Likewise.
13980 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13981 * sysdep.c: Include allocator.h, careadlinkat.h.
13982 (emacs_no_realloc_allocator): New static constant.
13983 (emacs_readlink): New function.
fdb61804
PE
13984 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13985 ../lib/careadlinkat.h.
d1fdcab7 13986
f84c17c7
SM
139872011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13988
13989 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13990 first non-nil return value).
13991
ef3862ad
JD
139922011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13993
13994 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13995 if not defined (Bug#8403).
13996
376a7006
JB
139972011-04-02 Juanma Barranquero <lekktu@gmail.com>
13998
13999 * xdisp.c (display_count_lines): Remove parameter `start',
14000 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14001 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14002 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14003 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14004 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14005 and thereabouts. All callers changed.
14006 (get_per_char_metric): Remove parameter `f', unused since
14007 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14008
6ca3801d
JM
140092011-04-02 Jim Meyering <meyering@redhat.com>
14010
14011 do not dereference NULL upon failed strdup
14012 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14013 (ns_get_family): Likewise.
14014
d8e2b5ba
JB
140152011-04-02 Juanma Barranquero <lekktu@gmail.com>
14016
14017 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14018
8c74fcbd
JD
140192011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14020
14021 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14022 later (Bug#8403).
14023
7200d79c
SM
140242011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14025
03408648 14026 Add lexical binding.
7200d79c 14027
03408648
SM
14028 * window.c (Ftemp_output_buffer_show): New fun.
14029 (Fsave_window_excursion):
14030 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14031
14032 * lread.c (lisp_file_lexically_bound_p): New function.
14033 (Fload): Bind Qlexical_binding.
14034 (readevalloop): Remove `evalfun' arg.
14035 Bind Qinternal_interpreter_environment.
14036 (Feval_buffer): Bind Qlexical_binding.
14037 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14038 Mark as dynamic.
14039 (syms_of_lread): Declare `lexical-binding'.
14040
14041 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14042
14043 * keyboard.c (eval_dyn): New fun.
14044 (menu_item_eval_property): Use it.
ca105506
SM
14045
14046 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14047
03408648
SM
14048 * fns.c (concat, mapcar1): Accept byte-code-functions.
14049
14050 * eval.c (Fsetq): Handle lexical vars.
14051 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14052 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14053 (FletX, Flet): Obey lexical binding.
14054 (Fcommandp): Handle closures.
14055 (Feval): New `lexical' arg.
14056 (eval_sub): New function extracted from Feval. Use it almost
14057 everywhere where Feval was used. Look up vars in lexical env.
14058 Handle closures.
14059 (Ffunctionp): Move from subr.el.
14060 (Ffuncall): Handle closures.
14061 (apply_lambda): Remove `eval_flags'.
14062 (funcall_lambda): Handle closures and new byte-code-functions.
14063 (Fspecial_variable_p): New function.
14064 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14065 but without exporting it to Lisp.
23aba0ea 14066
23aba0ea 14067 * doc.c (Fdocumentation, store_function_docstring):
03408648 14068 * data.c (Finteractive_form): Handle closures.
23aba0ea 14069
03408648
SM
14070 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14071 interactive spec.
ba83908c 14072
04f2d78b
CB
14073 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14074 New byte-codes.
03408648
SM
14075 (exec_byte_code): New function extracted from Fbyte_code to handle new
14076 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14077
03408648 14078 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14079
03408648 14080 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14081
e2abce01
JB
140822011-03-31 Juanma Barranquero <lekktu@gmail.com>
14083
14084 * xdisp.c (redisplay_internal): Fix prototype.
14085
63696a73 140862011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14087
63696a73 14088 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14089 (try_scrolling): Use it when setting scroll_limit.
14090 Limit scrolling to 100 screen lines.
63696a73
EZ
14091 (redisplay_window): Even when falling back on "recentering",
14092 position point in the window according to scroll-conservatively,
14093 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14094
14095 (try_scrolling): When point is above the window, allow searching
14096 as far as scroll_max, or one screenful, to compute vertical
14097 distance from PT to the scroll margin position. This prevents
14098 try_scrolling from unnecessarily failing when
14099 scroll-conservatively is set to a value slightly larger than the
14100 window height. Clean up the case of PT below the margin at bottom
14101 of window: scroll_max can no longer be INT_MAX. When aggressive
14102 scrolling is in use, don't let point enter the opposite scroll
14103 margin as result of the scroll.
14104 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14105 threshold of 100 lines for never-recentering scrolling.
14106
e4cc2dfc
JB
141072011-03-31 Juanma Barranquero <lekktu@gmail.com>
14108
14109 * dispextern.h (move_it_by_lines):
14110 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14111 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14112 (message_log_check_duplicate): Remove parameters `prev_bol' and
14113 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14114 (redisplay_internal): Remove parameter `preserve_echo_area',
14115 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14116
14117 * indent.c (Fvertical_motion):
14118 * window.c (window_scroll_pixel_based, Frecenter):
14119 Don't pass `need_y_p' to `move_it_by_lines'.
14120
1c470562
SM
141212011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14122
44f230aa
SM
14123 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14124 steal a few bits to be more compact.
14125 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14126 Remove unneeded casts.
14127
1c470562
SM
14128 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14129
888adce9
ZK
141302011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14131
14132 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14133 binding" message (bug#7967).
14134
f838ed7b
PE
141352011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14136
77861b95
PE
14137 Fix more problems found by GCC 4.6.0's static checks.
14138
de6dbc14
PE
14139 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14140 Remove unused local var.
14141
f838ed7b
PE
14142 * editfns.c (Fmessage_box): Remove unused local var.
14143
792c7b2b
PE
14144 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14145 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14146 Omit unused local vars.
c499e557 14147 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14148 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14149 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14150 Omit unused local var.
14151
ba0165e1
PE
14152 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14153 Don't assume string length fits in int.
32ad8845 14154 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14155 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14156
3c59b4c9
PE
14157 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14158 instead of alloca (Bug#8344).
14159
a3eed478 14160 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14161 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14162
eb4d412d
PE
14163 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14164
1658b401
PE
14165 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14166 concerns.
14167
14168 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14169
14170 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14171
9a2c6e05
PE
14172 * keyboard.c (syms_of_keyboard): Use the same style as later
14173 in this function when indexing through an array. This also
14174 works around GCC bug 48267.
14175
03d0a109
PE
14176 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14177
44f730c8
PE
14178 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14179
fe75f926
PE
14180 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14181 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14182
ffa8c828
PE
14183 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14184 This avoids undefined behavior on integer overflow, and is a bit
14185 more convenient anyway since it is compared to a size_t variable.
14186
c5101a77
PE
14187 Variadic C functions now count arguments with size_t, not int.
14188 This avoids an unnecessary limitation on 64-bit machines, which
14189 caused (substring ...) to crash on large vectors (Bug#8344).
14190 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14191 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14192 All variadic functions and their callers changed accordingly.
c5101a77
PE
14193 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14194 * data.c (arith_driver, float_arith_driver): Likewise.
14195 * editfns.c (general_insert_function): Likewise.
14196 * eval.c (struct backtrace.nargs, interactive_p)
14197 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14198 (funcall_lambda, mark_backtrace): Likewise.
14199 * fns.c (concat): Likewise.
14200 * frame.c (x_set_frame_parameters): Likewise.
14201 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14202 0 if not found, not -1. All callers changed.
14203
dd3f25f7
PE
14204 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14205 (stack_copy_size): Now size_t, not int.
14206 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14207
461c2ab9
JB
142082011-03-28 Juanma Barranquero <lekktu@gmail.com>
14209
14210 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14211 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14212 All callers changed.
14213
14214 * lisp.h (multibyte_char_to_unibyte):
14215 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14216 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14217 * character.h (CHAR_TO_BYTE8):
14218 * cmds.c (internal_self_insert):
14219 * editfns.c (general_insert_function):
14220 * keymap.c (push_key_description):
14221 * search.c (Freplace_match):
14222 * xdisp.c (message_dolog, set_message_1): All callers changed.
14223
f6d62986
SM
142242011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14225
14226 * keyboard.c (safe_run_hook_funcall): New function.
14227 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14228 don't set the hook to nil, but remove the offending function instead.
14229 (Qcommand_hook_internal): Remove, unused.
14230 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14231 Vcommand_hook_internal.
14232
14233 * eval.c (enum run_hooks_condition): Remove.
14234 (funcall_nil, funcall_not): New functions.
14235 (run_hook_with_args): Call each function through a `funcall' argument.
14236 Remove `cond' argument, now redundant.
14237 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14238 (Frun_hook_with_args_until_failure): Adjust accordingly.
14239 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14240
1db5b1ad
JB
142412011-03-28 Juanma Barranquero <lekktu@gmail.com>
14242
14243 * dispextern.h (string_buffer_position): Remove declaration.
14244
14245 * print.c (strout): Remove parameter `multibyte', unused since
14246 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14247
14248 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14249 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14250 All callers changed.
14251
14252 * w32.c (_wsa_errlist): Use braces for struct initializers.
14253
14254 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14255 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14256 All callers changed.
14257 (string_buffer_position): Likewise. Also, make static (it's never
14258 used outside xdisp.c).
14259 (cursor_row_p): Remove parameter `w', unused since
14260 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14261 (decode_mode_spec): Remove parameter `precision', introduced during
14262 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14263 All callers changed.
14264
5ffb62aa
JD
142652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14266
14267 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14268
461c2ab9 142692011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14270
14271 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14272 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14273 (ns_update_auto_hide_menu_bar): New functions.
14274 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14275 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14276 ns_constrain_all_frames.
14277 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14278 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14279
5c380ffb
JD
142802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14281
14282 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14283
9af30bdf
GM
142842011-03-27 Glenn Morris <rgm@gnu.org>
14285
14286 * syssignal.h: Replace RETSIGTYPE with void.
14287 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14288 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14289 Replace SIGTYPE with void everywhere.
14290 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14291 * s/template.h (SIGTYPE): Remove commented out definition.
14292
e2abce01
JB
142932011-03-26 Eli Zaretskii <eliz@gnu.org>
14294
14295 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14296 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14297
f868cd8a
JB
142982011-03-26 Juanma Barranquero <lekktu@gmail.com>
14299
59eb0929
JB
14300 * w32.c (read_unc_volume): Use parameter `henum', instead of
14301 global variable `wget_enum_handle'.
14302
14303 * keymap.c (describe_vector): Remove parameters `indices' and
14304 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14305 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14306
f868cd8a
JB
14307 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14308
14309 * keyboard.c (timer_check): Remove parameter `do_it_now',
14310 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14311 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14312 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14313
14314 * keyboard.c (read_char):
14315 * w32menu.c (w32_menu_display_help):
14316 * xmenu.c (show_help_event, menu_help_callback):
14317 Adjust calls to `show_help_echo'.
14318
14319 * gtkutil.c (xg_maybe_add_timer):
14320 * keyboard.c (readable_events):
14321 * process.c (wait_reading_process_output):
14322 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14323
14324 * insdel.c (adjust_markers_gap_motion):
14325 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14326 (gap_left, gap_right): Don't call it.
14327
2ecf6fdb
CY
143282011-03-25 Chong Yidong <cyd@stupidchicken.com>
14329
14330 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14331 incurred during fontification.
14332
6b1f9ba4
JB
143332011-03-25 Juanma Barranquero <lekktu@gmail.com>
14334
14335 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14336 (DEFVAR_PER_BUFFER): Don't pass it.
14337
14338 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14339 (scrolling_window): Don't pass it.
14340
0f4a96b5
JB
143412011-03-25 Juanma Barranquero <lekktu@gmail.com>
14342
14343 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14344
14345 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14346 and `suffix'.
14347 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14348 of variables specific to SELinux and computation of `encoded_absname'.
14349
14350 * image.c (XPutPixel): Remove unused variable `height'.
14351
14352 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14353
14354 * unexw32.c (get_section_info): Remove unused variable `section'.
14355
14356 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14357 (system_process_attributes): Remove unused variable `sess'.
14358 (sys_read): Remove unused variable `err'.
14359
14360 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14361 (w32_wnd_proc): Remove unused variable `isdead'.
14362 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14363 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14364 (x_create_tip_frame): Remove unused variable `tem'.
14365
14366 * w32inevt.c (w32_console_read_socket):
14367 Remove unused variable `no_events'.
14368
14369 * w32term.c (x_draw_composite_glyph_string_foreground):
14370 Remove unused variable `width'.
14371
1149507c
JB
143722011-03-24 Juanma Barranquero <lekktu@gmail.com>
14373
14374 * w32term.c (x_set_glyph_string_clipping):
14375 Don't pass uninitialized region to CombineRgn.
14376
9c88f339
JB
143772011-03-23 Juanma Barranquero <lekktu@gmail.com>
14378
14379 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14380 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14381 (Fx_close_connection): Remove unused variable `i'.
14382
14383 * w32font.c (w32font_draw): Return number of glyphs.
14384 (w32font_open_internal): Remove unused variable `i'.
14385 (w32font_driver): Add missing initializer.
14386
14387 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14388 (fill_in_menu): Remove unused variable `items_added'.
14389
14390 * w32term.c (last_mouse_press_frame): Remove static global variable.
14391 (w32_clip_to_row): Remove unused variable `f'.
14392 (x_delete_terminal): Remove unused variable `i'.
14393
14394 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14395 (NOTHING): Remove unused static global variable.
14396 (uniscribe_check_otf): Remove unused variable `table'.
14397 (uniscribe_font_driver): Add missing initializers.
14398
dee091a3
JD
143992011-03-23 Julien Danjou <julien@danjou.info>
14400
14401 * term.c (Fsuspend_tty, Fresume_tty):
14402 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14403 * window.c (temp_output_buffer_show):
14404 * insdel.c (signal_before_change):
14405 * frame.c (Fhandle_switch_frame):
14406 * fileio.c (Fdo_auto_save):
14407 * emacs.c (Fkill_emacs):
14408 * editfns.c (save_excursion_restore):
14409 * cmds.c (internal_self_insert):
14410 * callint.c (Fcall_interactively):
14411 * buffer.c (Fkill_all_local_variables):
14412 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14413 Use Frun_hooks.
0f4a96b5 14414 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14415 unconditionally since it does the check itself.
dee091a3 14416
2c520ab5 144172011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14418
c9c49752
PE
14419 Fix more problems found by GCC 4.5.2's static checks.
14420
8abc3f12
PE
14421 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14422 the first time through the loop, since we know p0 < p1 then.
14423 This also avoids a gcc -Wstrict-overflow warning.
14424
a2d26660
PE
14425 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14426 leading to a memory leak, possible in functions like
14427 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14428 of objects (Bug#8318).
a2d26660 14429
916c72e9
PE
14430 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14431 that could (at least in theory) be that large.
14432
19ab8a18
PE
14433 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14434 This is less likely to overflow, and avoids undefined behavior if
14435 overflow does occur. All callers changed. Use strtoul to scan
14436 for the unsigned long integer.
b7cbbd6f
PE
14437 (pint2hrstr): Simplify and tune code slightly.
14438 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14439
f0641eff
PE
14440 * scroll.c (do_scrolling): Work around GCC bug 48228.
14441 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14442
7f650bb9
PE
14443 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14444 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14445 (validate_x_resource_name): Simplify count usage.
14446 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14447
37dd57d1
PE
14448 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14449 fail (Bug#8306).
81e56e61 14450
699979fc 14451 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14452
401bf9b4
PE
14453 * process.c (Fmake_network_process): Use socklen_t, not int,
14454 where POSIX says socklen_t is required in portable programs.
14455 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14456 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14457 (Fmake_network_process, server_accept_connection):
14458 (wait_reading_process_output, read_process_output):
14459 Likewise.
14460
b93aacde
PE
14461 * process.c: Rename or move locals to avoid shadowing.
14462 (list_processes_1, Fmake_network_process):
14463 (read_process_output_error_handler, exec_sentinel_error_handler):
14464 Rename or move locals.
4dc343ee 14465 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14466 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14467 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14468 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14469 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14470
af8a867c 14471 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14472 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14473 Include tparam.h instead, since it declares them.
af8a867c
PE
14474 * cm.h (PC): Remove extern decl; tparam.h now does this.
14475 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14476 * terminfo.c: Include tparam.h, to check interfaces.
14477 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14478 (tparam): Adjust signature to match interface in tparam.h;
14479 this removes some undefined behavior. Check that outstring and len
14480 are zero, which they always are with Emacs.
14481 * tparam.h (PC, BC, UP): New extern decls.
14482
0248044d 14483 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14484 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14485
8ff096c1 14486 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14487 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14488 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14489 (ftfont_list): Remove unused local.
49eaafba
PE
14490 (get_adstyle_property, ftfont_pattern_entity):
14491 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14492 Rename locals to avoid shadowing.
8ff096c1 14493
e2be39f6
PE
14494 * xfont.c (xfont_list_family): Mark var as initialized.
14495
c9735e30
PE
14496 * xml.c (make_dom): Now static.
14497
8f5201ae
PE
14498 * composite.c (composition_compute_stop_pos): Rename local to
14499 avoid shadowing.
b246f932
PE
14500 (composition_reseat_it): Remove unused locals.
14501 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14502 (composition_update_it): Mark var as initialized.
11b61122
PE
14503 (find_automatic_composition): Mark vars as initialized,
14504 with a FIXME (Bug#8290).
8f5201ae 14505
760fbc2c
PE
14506 character.h: Rename locals to avoid shadowing.
14507 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14508 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14509 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14510 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14511 to avoid shadowing.
14512
ff08eb85
PE
14513 * textprop.c (property_change_between_p): Remove; unused.
14514
fc7bf025
PE
14515 * intervals.c (interval_start_pos): Now static.
14516
235d7abc
PE
14517 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14518
44f230aa
SM
14519 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14520 Rename locals to avoid shadowing.
3e7d6594 14521
50060332
PE
14522 * sound.c (wav_play, au_play, Fplay_sound_internal):
14523 Fix pointer signedness.
d01f234b 14524 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14525 (wav_play): Initialize a variable to 0, to prevent undefined
14526 behavior (Bug#8278).
50060332 14527
c4fc4e30
PE
14528 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14529
918436ed
PE
14530 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14531
c939f91b
PE
14532 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14533 clobbering (Bug#8298).
b9c7f648
PE
14534 * sysdep.c (sys_subshell): Likewise.
14535 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14536
6bd8c144
PE
14537 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14538 This should get cleaned up, so that child_setup has the
14539 same signature on all platforms.
14540
7710357c 14541 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14542 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14543
c59da222
CY
145442011-03-22 Chong Yidong <cyd@stupidchicken.com>
14545
14546 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14547 not to be necessary, and produces flickering.
14548
66b87493
GM
145492011-03-20 Glenn Morris <rgm@gnu.org>
14550
14551 * config.in: Remove file.
14552
45b6f6d5
JB
145532011-03-20 Juanma Barranquero <lekktu@gmail.com>
14554
14555 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14556 are now in src/globals.h.
14557 (syms_of_minibuf): Remove spurious & from previous change.
14558
cd394be1 145592011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14560
14561 * minibuf.c (completing-read-function): New variable.
14562 (completing-read-default): Rename from completing-read.
14563 (completing-read): Call completing-read-function.
14564
b14e3e21
CY
145652011-03-19 Juanma Barranquero <lekktu@gmail.com>
14566
14567 * xfaces.c (Fx_load_color_file):
14568 Read color file from absolute filename (bug#8250).
14569
f2b726e6
JB
145702011-03-19 Juanma Barranquero <lekktu@gmail.com>
14571
14572 * makefile.w32-in: Update dependencies.
14573
09f6ff02
EZ
145742011-03-17 Eli Zaretskii <eliz@gnu.org>
14575
14576 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14577
29a6015a
PE
145782011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14579
a3a6c54e
PE
14580 Fix more problems found by GCC 4.5.2's static checks.
14581
b766f867
PE
14582 * process.c (make_serial_process_unwind, send_process_trap):
14583 (sigchld_handler): Now static.
14584
be02381c
PE
14585 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14586 That way, the code declares only the vars that it needs.
14587 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14588 * s/cygwin.h (PTY_ITERATION): Likewise.
14589 * s/darwin.h (PTY_ITERATION): Likewise.
14590 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14591
57048744
PE
14592 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14593 * process.c (allocate_pty): Don't declare stb unless it's needed.
14594
7914961c 14595 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14596 (CONSTANTLIM): Remove; unused.
14597 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14598 Define only if needed.
7914961c 14599
b3967b18
PE
14600 * unexelf.c (unexec): Name an expression,
14601 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14602 Use a different way to cause a compilation error if anyone uses
14603 n rather than nn, a way that does not involve shadowing.
73366a00 14604 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14605
29a6015a
PE
14606 * deps.mk (unexalpha.o): Remove; unused.
14607
43cfc33e 14608 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14609 * unexec.h: New file.
ce701a33
PE
14610 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14611 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14612 Depend on unexec.h.
14613 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14614 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14615 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14616 Change as necessary to match prototype in unexec.h.
ce701a33 14617
01f44d5a
PE
14618 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14619 shadowing.
4f63c6bb 14620 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14621
a6670b0b
PE
14622 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14623 Rename locals to avoid shadowing.
14624
cef2010d 14625 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14626 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14627
d4d7173a
PE
14628 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14629
f08b802a
PE
14630 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14631 warning when compiling print.c.
14632
3ddb0639
PE
14633 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14634 instead of using an uninitialized var.
5ad03b97 14635 (font_sort_entities): Mark var as initialized.
3ddb0639 14636
170a2692
PE
14637 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14638
e663c700
PE
14639 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14640 pointers to constants.
89bc529a 14641 (font_parse_fcname): Remove unused vars.
7b81e2d0 14642 (font_delete_unmatched): Now static.
ea838e10 14643 (font_get_spec): Remove; unused.
13a547c6
PE
14644 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14645 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14646 Rename or move locals to avoid shadowing.
e663c700 14647
2a80c887 14648 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14649 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14650
1384fa33 14651 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14652 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14653
8b2c52e9
PE
14654 * alloc.c (mark_backtrace): Move decl from here ...
14655 * lisp.h: ... to here, so that it can be checked.
14656
475545b5 14657 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14658 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14659 (lisp_indirect_variable): Name an expression,
14660 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14661 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14662
b1349114 14663 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14664 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14665 Use const pointer when appropriate.
b1349114 14666
a2928364
PE
14667 * lisp.h (get_system_name, get_operating_system_release):
14668 Move decls here, to check interfaces.
14669 * process.c (get_operating_system_release): Move decl to lisp.h.
14670 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14671 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14672 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14673 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14674 (Fformat_time_string, Fencode_time, Finsert_char):
14675 (Ftranslate_region_internal, Fformat):
14676 Rename or remove local vars to avoid shadowing.
9710023e 14677 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14678
a415e694
PE
14679 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14680 avoid shadowing.
14681
8ef4622d
PE
14682 * lisp.h (eassert): Check that the argument compiles, even if
14683 ENABLE_CHECKING is not defined.
14684
946f9a5b
PE
14685 * data.c (Findirect_variable): Name an expression, to avoid
14686 gcc -Wbad-function-cast warning.
112396d6 14687 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14688 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14689 (Fmake_variable_buffer_local, Fmake_local_variable):
14690 Mark variables as initialized.
52746918 14691 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14692
e5aab7e7 14693 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14694 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14695 Rename locals to avoid shadowing.
dff45157
PE
14696 (mark_stack): Move local variables into the #ifdef region where
14697 they're used.
7bc26fdb
PE
14698 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14699 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14700 needed otherwise.
14701 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14702 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14703 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14704
e5aab7e7
PE
14705 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14706 avoids undefined behavior in theory.
14707
4da60324
PE
14708 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14709
88043301
PE
14710 Use functions, not macros, for up- and down-casing (Bug#8254).
14711 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14712 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14713 to use the following functions instead of these macros.
14714 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14715 EMACS_INT, since callers assume the returned value fits in int.
14716 (upcase1): Likewise, for UPCASE_TABLE.
14717 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14718 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14719 the race-condition problem in the old DOWNCASE.
88043301 14720
19ed5445
PE
14721 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14722 Rename locals to avoid shadowing.
14723 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14724 (regex_compile, re_search_2, re_match_2_internal):
14725 Remove unused local vars.
952db0d7
PE
14726 (FREE_VAR): Rewrite so as not to use empty "else",
14727 which gcc can warn about.
da053e48 14728 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14729 (RETALLOC_IF): Define only if needed.
14730 (WORDCHAR_P): Likewise. This one is never needed, but is used
14731 only in a comment talking about a compiler bug, so put inside
14732 the #if 0 of that comment.
14733 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14734 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14735 Remove; unused.
19ed5445 14736
1f3561e4 14737 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14738 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14739 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14740
ded6f8f7
PE
14741 * search.c (simple_search): Remove unused var.
14742
dbd37a95
PE
14743 * dired.c (compile_pattern): Move decl from here ...
14744 * lisp.h: ... to here, so that it can be checked.
14745 (struct re_registers): New forward decl.
14746
7e47afad
PE
14747 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14748
85f24f61
PE
14749 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14750 All uses changed.
14751 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14752 Rename locals to avoid shadowing.
5671df8f 14753 (Fvertical_motion): Mark locals as initialized.
85f24f61 14754
181aa2be 14755 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14756 (casify_region): Mark local as initialized.
181aa2be 14757
930d429c
PE
14758 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14759
7082eac6
PE
14760 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14761 New macros, so that the caller can use some names other than
14762 gcpro1, gcpro2, etc.
14763 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14764 of the new macros.
14765 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14766 argument, for consistency with GCPRO2_VAR, etc: it is now the
14767 prefix of the variable, not the variable itself. All uses
14768 changed.
38b2c076
PE
14769 * dired.c (directory_files_internal, file_name_completion):
14770 Rename locals to avoid shadowing.
14771
15206ed9
PE
14772 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14773 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14774 dired.c's scmp function, had undefined behavior.
14775 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14776 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14777 * buffer.h: ... to here, because these macros use current_buffer,
14778 and the new implementation with inline functions needs to have
14779 current_buffer in scope now, rather than later when the macros
14780 are used.
14781 (downcase, upcase1): New static inline functions.
14782 (DOWNCASE, UPCASE1): Reimplement using these functions.
14783 This avoids undefined behavior in expressions like
14784 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14785 from race conditions in accessing the global variables
14786 case_temp1 and case_temp2.
14787 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14788 * lisp.h (case_temp1, case_temp2): Remove their decls.
14789 * character.h (ASCII_CHAR_P): Move from here ...
14790 * lisp.h: ... to here, so that the inline functions mentioned
14791 above can use them.
14792
4a6bea26
PE
14793 * dired.c (directory_files_internal_unwind): Now static.
14794
f14b7e14
PE
14795 * fileio.c (file_name_as_directory, directory_file_name):
14796 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14797 Now static.
2893f146
PE
14798 (file_name_as_directory): Use const pointers when appropriate.
14799 (Fexpand_file_name): Likewise. In particular, newdir might
14800 point at constant storage, so make it a const pointer.
fd4ead52 14801 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14802 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14803 signedness issues.
f839df0c
PE
14804 (Fset_file_times, Finsert_file_contents, auto_save_error):
14805 Rename locals to avoid shadowing.
f14b7e14 14806
5716756e 14807 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14808 (Ftry_completion, Fall_completions): Rename or remove locals
14809 to avoid shadowing.
5716756e 14810
b4c3046a
PE
14811 * marker.c (bytepos_to_charpos): Remove; unused.
14812
b45db522
PE
14813 * lisp.h (verify_bytepos, count_markers): New decls,
14814 so that gcc does not warn that these functions aren't declared.
14815
85876d07
PE
14816 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14817 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14818 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14819 (copy_text): Remove unused local var.
85876d07 14820
03d78a21 14821 * filelock.c (within_one_second): Now static.
b3dd38ab 14822 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14823
5df8f01b
PE
14824 * buffer.c (fix_overlays_before): Mark locals as initialized.
14825 (fix_start_end_in_overlays): Likewise. This function should be
14826 simplified by using pointers-to-pointers, but that's a different
14827 matter.
b1d876f1 14828 (switch_to_buffer_1): Now static.
8f54f30a
PE
14829 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14830 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14831
a70072c9 14832 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14833 Fix pointer signedness issue.
edced198
PE
14834 (sys_subshell): Mark local as volatile if checking for lint,
14835 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14836 (MAXPATHLEN): Define only if needed.
a70072c9 14837
a0977c44
PE
14838 * process.c (serial_open, serial_configure): Move decls from here ...
14839 * systty.h: ... to here, so that they can be checked.
14840
a884fdcc
PE
14841 * fns.c (get_random, seed_random): Move extern decls from here ...
14842 * lisp.h: ... to here, so that they can be checked.
14843
604efe86 14844 * sysdep.c (reset_io): Now static.
b8950c94 14845 (wait_for_termination_signal): Remove; unused.
604efe86 14846
38fc62d9
PE
14847 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14848 (copy_keymap_item, append_key, push_text_char_description):
14849 Now static.
1004a21a 14850 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14851 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14852 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14853 (describe_map_tree):
14854 Rename locals to avoid shadowing.
38fc62d9 14855
2f2650da
PE
14856 * keyboard.c: Declare functions static if they are not used elsewhere.
14857 (echo_char, echo_dash, cmd_error, top_level_2):
14858 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14859 (read_char, kbd_buffer_get_event, make_lispy_position):
14860 (make_lispy_event, make_lispy_movement, apply_modifiers):
14861 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14862 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14863 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14864 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14865 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14866
a053e86c 14867 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14868 (mark_kboards): Move decl here ...
14869 * alloc.c (mark_kboards): ... from here.
a053e86c 14870
4752793e
PE
14871 * lisp.h (force_auto_save_soon): New decl.
14872
74f10ca7 14873 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14874 (DEFINE_DUMMY_FUNCTION): New macro.
14875 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14876 Use it.
c03cd23f
PE
14877 (main): Add casts to avoid warnings
14878 if GCC considers string literals to be constants.
74f10ca7 14879
022e70d4
PE
14880 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14881
59d6fe83
PE
14882 * dbusbind.c: Pointer signedness fixes.
14883 (xd_signature, xd_append_arg, xd_initialize):
14884 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14885 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14886 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14887 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14888
78320123
PE
14889 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14890 if GCC considers string literals to be constants.
49cebcca 14891 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14892
35ac2a97
SM
148932011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14894
fb103ca9
SM
14895 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14896 (print_preprocess, print_object): New macro to fix last change.
14897
35ac2a97
SM
14898 * print.c (print_preprocess): Don't forget font objects.
14899
62973b41
JB
149002011-03-16 Juanma Barranquero <lekktu@gmail.com>
14901
14902 * emacs.c (USAGE3): Doc fixes.
14903
0e48bb22
AS
149042011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14905
14906 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14907 structure.
14908
7684e57b
JB
149092011-03-14 Juanma Barranquero <lekktu@gmail.com>
14910
14911 * lisp.h (VWindow_system, Qfile_name_history):
14912 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14913 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14914 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14915
14916 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14917 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14918
14919 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14920 * w32console.c (detect_input_pending, read_input_pending)
14921 (encode_terminal_code):
14922 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14923 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14924 (w32_system_caret_y, Qfile_name_history):
14925 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14926 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14927 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14928 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14929 * w32proc.c (Qlocal, report_file_error):
14930 * w32term.c (Vwindow_system, updating_frame):
14931 * w32uniscribe.c (initialized, uniscribe_font_driver):
14932 Remove unneeded extern declarations.
14933
2aa46d6c
CY
149342011-03-14 Chong Yidong <cyd@stupidchicken.com>
14935
c96bbc66 14936 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14937
cffc6f3b
CY
149382011-03-13 Chong Yidong <cyd@stupidchicken.com>
14939
14940 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14941 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14942 These macros can no longer be used for assignment.
14943
44f230aa
SM
14944 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14945 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14946 (record_buffer_markers, fetch_buffer_markers): New functions for
14947 recording and fetching special buffer markers.
14948 (set_buffer_internal_1, set_buffer_temp): Use them.
14949
14950 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14951
14952 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14953
14954 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14955 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14956
14957 * xdisp.c (hscroll_window_tree):
14958 (reconsider_clip_changes): Use PT instead of BUF_PT.
14959
d251f04b
EZ
149602011-03-13 Eli Zaretskii <eliz@gnu.org>
14961
14962 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14963 $(EMACS_ROOT)/lib/intprops.h.
14964
f0c77cd1
PE
149652011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14966
3eca4629
PE
14967 Fix more problems found by GCC 4.5.2's static checks.
14968
7c86ee98
PE
14969 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14970 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14971 (xg_free_frame_widgets): Make it clear that a local variable is
14972 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14973 (gdk_window_get_screen): Make it clear that this macro is needed
14974 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14975 (int_gtk_range_get_value): New function, which avoids a diagnostic
14976 from gcc -Wbad-function-cast.
14977 (xg_set_toolkit_scroll_bar_thumb): Use it.
14978 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14979 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14980 (get_utf8_string, xg_get_file_with_chooser):
14981 Rename locals to avoid shadowing.
14982 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14983
41729b81
PE
14984 * xgselect.c (xg_select): Remove unused var.
14985
f0c77cd1
PE
14986 * image.c (four_corners_best): Mark locals as initialized.
14987 (gif_load): Initialize transparent_p to zero (Bug#8238).
14988 Mark another local as initialized.
ec6cf4c6 14989 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14990
ce0ad53d 14991 * image.c (clear_image_cache): Now static.
d5d5a617 14992 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14993 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14994 (x_edge_detection): Remove unnecessary cast that
14995 gcc -Wbad-function-cast diagnoses.
2037898d 14996 (gif_load): Fix pointer signedness.
6ae141d6
PE
14997 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14998 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14999
33383987 150002011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15001
d32df629
PE
15002 Improve quality of tests for time stamp overflow.
15003 For example, without this patch (encode-time 0 0 0 1 1
15004 1152921504606846976) returns the obviously-bogus value (-948597
15005 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15006 reports time overflow. See
15007 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15008 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15009 * editfns.c: Include limits.h and intprops.h.
15010 (TIME_T_MIN, TIME_T_MAX): New macros.
15011 (time_overflow): Move earlier, to before first use.
15012 (hi_time, lo_time): New functions, for an accurate test for
15013 out-of-range times.
15014 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15015 (Fget_internal_run_time): Don't assume time_t fits in int.
15016 (make_time): Use list2 instead of Fcons twice.
15017 (Fdecode_time): More accurate test for out-of-range times.
15018 (check_tm_member): New function.
15019 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15020 (lisp_time_argument): Don't rely on undefined left-shift and
15021 right-shift behavior when checking for time stamp overflow.
8be6f318 15022
fe31d94c
PE
15023 * editfns.c (time_overflow): New function, refactoring common code.
15024 (Fformat_time_string, Fdecode_time, Fencode_time):
15025 (Fcurrent_time_string): Use it.
15026
8be6f318
PE
15027 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15028 * dired.c (make_time): Move to ...
15029 * editfns.c (make_time): ... here.
15030 * systime.h: Note the move.
15031
09d9db2c 150322011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15033
126bc0dc
YM
15034 * fringe.c (update_window_fringes): Remove unused variables.
15035
c47cbdfd
YM
15036 * unexmacosx.c (copy_data_segment): Also copy __got section.
15037 (Bug#8223)
15038
7ac80be9
EZ
150392011-03-12 Eli Zaretskii <eliz@gnu.org>
15040
c96bbc66 15041 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15042 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15043 Constify `char *' arguments and their references according to
15044 prototypes in tparam.h.
15045
ecb0f94d 15046 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15047
7ac80be9
EZ
15048 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15049 Adapt all references accordingly.
15050
15051 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15052
ef1fd07e
TT
150532011-03-11 Tom Tromey <tromey@redhat.com>
15054
15055 * buffer.c (syms_of_buffer): Remove obsolete comment.
15056
7ef4b50c
EZ
150572011-03-11 Eli Zaretskii <eliz@gnu.org>
15058
15059 * termhooks.h (encode_terminal_code): Declare prototype.
15060
15061 * msdos.c (encode_terminal_code): Don't declare prototype.
15062
15063 * term.c (encode_terminal_code): Now external again, used by
15064 w32console.c and msdos.c.
15065
44f230aa
SM
15066 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15067 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15068
4b1ec863 150692011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15070
1714f52b 15071 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15072
4b1ec863
PE
15073 * fringe.c (update_window_fringes): Mark locals as initialized
15074 (Bug#8227).
15075 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15076
524c7aa6
PE
15077 * alloc.c (mark_fringe_data): Move decl from here ...
15078 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15079 to check its interface.
15080 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15081
a5c0af81 15082 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15083 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15084 (fontset_font): Mark local as initialized.
a9a06e0b 15085 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15086
b4716021
PE
15087 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15088
811e9bac 15089 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15090 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15091 (x_own_selection, Fx_disown_selection_internal): Rename locals
15092 to avoid shadowing.
15093 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15094
7e3ab302
PE
15095 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15096 so that the caller can use some name other than gcpro1.
15097 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15098 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15099 (Fx_backspace_delete_keys_p):
15100 Use them to avoid shadowing, and rename vars to avoid shadowing.
15101 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15102 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15103 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15104 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15105 Remove unused locals.
7e3ab302
PE
15106 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15107 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15108 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15109 macros.
f78faa98 15110
e2b13473
PE
15111 * xterm.h (x_mouse_leave): New decl.
15112
77f23912
PE
15113 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15114 Remove unused functions.
cdf4ba58
PE
15115 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15116 (x_calc_absolute_position): Now static.
7411c686 15117 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15118 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15119 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15120 unless they are used.
38d0b34a
PE
15121 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15122 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15123 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15124 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15125 (x_error_catcher, x_connection_closed, x_error_handler):
15126 (x_error_quitter, xembed_send_message, x_iconify_frame):
15127 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15128 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15129 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15130
44f230aa
SM
15131 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15132 Rename or move locals to avoid shadowing.
6b463e58 15133 (tty_defined_color, merge_face_heights): Now static.
5967d051 15134 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15135 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15136 does not deduce is never used uninitialized.
73719eba
PE
15137 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15138 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15139
426994c3 15140 * terminal.c (store_terminal_param): Now static.
5489860b 15141
032f1620 15142 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15143 (set_frame_menubar): Remove unused local.
d4323972 15144 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15145 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15146 since they might point to immutable storage.
281585b0
PE
15147 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15148 since it's unused otherwise.
032f1620 15149
367c19e5 15150 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15151 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15152 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15153 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15154 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15155 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15156 does not deduce are never used uninitialized.
70739cbe 15157
07b48fa9
PE
15158 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15159
8868a238 15160 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15161 * window.c (window_loop, size_window):
15162 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15163
7e5cf297 15164 * window.c (display_buffer): Now static.
d6550a9f
PE
15165 (size_window): Mark variables that gcc -Wuninitialized
15166 does not deduce are never used uninitialized.
a586633d
PE
15167 * window.h (check_all_windows): New decl, to forestall
15168 gcc -Wmissing-prototypes diagnostic.
5b555da1 15169 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15170
f6095868
PE
15171 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15172 shadowing.
15173 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15174 Include <limits.h>.
15175 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15176 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15177 (load_charset_map): Mark variables that gcc -Wuninitialized
15178 does not deduce are never used uninitialized.
53df7c11 15179 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15180
f38b440c
PE
15181 * coding.c (coding_set_source, coding_set_destination):
15182 Use "else { /* comment */ }" rather than "else /* comment */;"
15183 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15184 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15185 a block, when the outer 'i' will do.
15186 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15187 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15188 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15189 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15190 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15191 Rename locals to avoid shadowing.
15192 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15193 * coding.c (emacs_mule_char, encode_invocation_designation):
15194 Now static, since they're not used elsewhere.
413bb2db 15195 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15196 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15197 (decode_coding_emacs_mule): Mark variables that gcc
15198 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15199 (detect_coding_iso_2022): Initialize a local variable that might
15200 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15201 this initialization is needed. (Bug#8211)
5f58e762
PE
15202 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15203 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15204 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15205 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15206 Remove unused macros.
f38b440c 15207
232b38b9 15208 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15209 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15210 * character.c (string_count_byte8): Likewise.
232b38b9 15211
fb90da1b
PE
15212 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15213 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15214
fb93dbc2
PE
15215 * chartab.c (copy_sub_char_table): Now static, since it's not used
15216 elsewhere.
5c156ace
PE
15217 (sub_char_table_ref_and_range, char_table_ref_and_range):
15218 Rename locals to avoid shadowing.
bbcd0949 15219 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15220
7d3b3862 15221 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15222 (BIDI_BOB): Remove unused macro.
7d3b3862 15223
6be7d3da
PE
15224 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15225 deduce are never used uninitialized.
c2ed9c8b 15226 * term.c (encode_terminal_code): Likewise.
6be7d3da 15227
75f8807f 15228 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15229
50938595
PE
15230 * tparam.h: New file.
15231 * term.c, tparam.h: Include it.
15232 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15233 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15234 Move these decls to tparam.h, and make them agree with what
15235 is actually in tparam.c. The previous trick of using incompatible
15236 decls in different modules does not conform to the C standard.
15237 All callers of tparam changed to use tparam's actual API.
15238 * tparam.c (tparam1, tparam, tgoto):
15239 Use const pointers where appropriate.
15240
fbceeba2
PE
15241 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15242 * cm.h (struct cm): Likewise.
15243 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15244 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15245 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15246 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15247 (turn_on_face, init_tty): Likewise.
15248 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15249
7f3f1250
PE
15250 * term.c (term_mouse_position): Rename local to avoid shadowing.
15251
e6ca6543
PE
15252 * alloc.c (mark_ttys): Move decl from here ...
15253 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15254
c40f8d15
AS
152552011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15256
15257 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15258
cfe0661d
JB
152592011-03-09 Juanma Barranquero <lekktu@gmail.com>
15260
15261 * search.c (compile_pattern_1): Remove argument regp, unused since
15262 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15263 (compile_pattern): Don't pass it.
15264
0afb4571
J
152652011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15266
15267 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15268 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15269 for ! HAVE_GTK3.
15270 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15271
15272 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15273
15274 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15275 gdk_window_get_screen, gdk_window_get_geometry,
15276 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15277 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15278 (xg_get_pixbuf_from_pixmap): New function.
15279 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15280 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15281 Call xg_get_pixbuf_from_pixmap instead of
15282 gdk_pixbuf_get_from_drawable.
15283 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15284 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15285 (xg_check_special_colors): Use GtkStyleContext and its functions
15286 for HAVE_GTK3.
15287 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15288 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15289 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15290 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15291 Call gtk_widget_get_preferred_size.
0afb4571
J
15292 (xg_frame_resized): gdk_window_get_geometry only takes 5
15293 parameters.
44f230aa
SM
15294 (xg_win_to_widget, xg_event_is_for_menubar):
15295 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15296 (xg_set_widget_bg): New function.
15297 (delete_cb): New function.
895009e1 15298 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15299 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15300 (xg_set_background_color): Call xg_set_widget_bg.
15301 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15302 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15303 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15304 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15305 if ! HAVE_GTK3.
15306 (update_frame_tool_bar): Call gtk_widget_hide.
15307 (xg_initialize): Use GDK_KEY_g.
15308
15309 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15310 if ! HAVE_GTK3
15311 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15312
15313 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15314 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15315 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15316
1c2cc4ef
JB
153172011-03-08 Juanma Barranquero <lekktu@gmail.com>
15318
15319 * w32xfns.c (select_palette): Check success of RealizePalette against
15320 GDI_ERROR, not zero.
15321
33383987 15322See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15323
15324;; Local Variables:
15325;; coding: utf-8
aac0c6e3
MR
15326;; End:
15327
2f097256 15328 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15329
15330 This file is part of GNU Emacs.
15331
15332 GNU Emacs is free software: you can redistribute it and/or modify
15333 it under the terms of the GNU General Public License as published by
15334 the Free Software Foundation, either version 3 of the License, or
15335 (at your option) any later version.
15336
15337 GNU Emacs is distributed in the hope that it will be useful,
15338 but WITHOUT ANY WARRANTY; without even the implied warranty of
15339 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15340 GNU General Public License for more details.
15341
15342 You should have received a copy of the GNU General Public License
15343 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.