* org-list.el (org-list-send-item): Use sort instead of sort*.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d5ff9cd0
AS
12011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2
3 * m/ibms390.h: Remove.
4 * m/ibms390x.h: Don't include "ibms390.h".
5
a5bb9bd3
SM
62011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7
8 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
9 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
10
cd1181db
JB
112011-11-20 Juanma Barranquero <lekktu@gmail.com>
12
13 * casetab.c (Fset_case_table):
14 * charset.c (Fcharset_after): Fix typos.
15
615a3b8d 162011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 17
17e845af
PE
18 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
19 Otherwise, valgrind does not work on some platforms.
20 Problem reported by Andreas Schwab in
6a0bf43d
PE
21 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
22 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
23 is set, removing the need for VIRT_ADDRESS_VARIES.
24 (PURE_P): Use a more-efficient implementation that needs just one
25 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
26 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
27 to 4 (xorl, subq, cmpq, setbe).
28 * alloc.c (pure): Always extern now, since that's the
29 VIRT_ADDR_VARIES behavior.
30 (PURE_POINTER_P): Use a single comparison, not two, for
31 consistency with the new puresize.h.
32 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
33 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
34 Remove VIRT_ADDR_VARIES no longer needed.
35
f8fe6f96
EZ
362011-11-19 Eli Zaretskii <eliz@gnu.org>
37
38 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
39 (erase_phys_cursor, update_window_cursor, show_mouse_face)
40 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
41 behave as if the cursor position were at the window margin.
42
43 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
44 and the cursor position is out of bounds, behave as if the cursor
45 position were at the window margin. (Bug#10075)
46
df05a53c
CY
472011-11-18 Chong Yidong <cyd@gnu.org>
48
49 * window.c (Fwindow_combination_limit): Make first argument
50 non-optional, since it is meaningless for live windows like the
51 selected window.
52
2071918e
DA
532011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
54
55 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
56
b50a28de
SM
572011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
58
59 * intervals.c: Fix grafting over the whole buffer (bug#10071).
60 (graft_intervals_into_buffer): Simplify.
61
015137db
EZ
622011-11-18 Eli Zaretskii <eliz@gnu.org>
63
64 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
65 hash values of the two rows.
66 (copy_row_except_pointers): Preserve the used[] arrays and the
67 hash values of the two rows. (Bug#10035)
68c95424 68 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
69
70 * xdisp.c (row_hash): New function, body extracted from
71 compute_line_metrics.
72 (compute_line_metrics): Call row_hash, instead of computing the
73 hash code inline.
74
75 * dispnew.c (verify_row_hash): Call row_hash for computing the
76 hash code of a row, instead of duplicating code from xdisp.c.
77
78 * dispextern.h (row_hash): Add prototype.
79
a2addb04
TH
802011-11-18 Tassilo Horn <tassilo@member.fsf.org>
81
82 * frame.c (delete_frame): Don't delete the terminal when the last
83 X frame is closed if emacs is built with GTK toolkit.
84
df85d315
JB
852011-11-17 Juanma Barranquero <lekktu@gmail.com>
86
87 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
88
a0c2d0ae
MR
892011-11-17 Martin Rudalics <rudalics@gmx.at>
90
91 * window.c (Vwindow_splits): Rename to
92 Vwindow_combination_resize. Suggested by Juri Linkov.
93 (Fsplit_window_internal): Use Vwindow_combination_resize instead
94 of Vwindow_splits.
95
58179cce
JB
962011-11-16 Juanma Barranquero <lekktu@gmail.com>
97
7877f373
JB
98 * nsfns.m (Fns_font_name):
99 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 100
b6f67890
MR
1012011-11-16 Martin Rudalics <rudalics@gmx.at>
102
103 * window.h (window): Rename slot "nest" to "combination_limit".
104 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
105 (Fset_window_nest): Rename to Fset_window_combination_limit.
106 (Vwindow_nest): Rename to Vwindow_combination_limit.
107 (recombine_windows, make_parent_window, make_window)
108 (Fsplit_window_internal, saved_window)
109 (Fset_window_configuration, save_window_save): Rename all
110 occurrences of window_nest to window_combination_limit.
111
c7015153
JB
1122011-11-15 Juanma Barranquero <lekktu@gmail.com>
113
114 * image.c (imagemagick_load_image): Fix typo.
115
322ad6ec
EZ
1162011-11-14 Eli Zaretskii <eliz@gnu.org>
117
118 * xdisp.c (display_line): Move the call to
119 highlight_trailing_whitespace before the call to
120 compute_line_metrics, since the latter needs to see the final
121 faces of all the glyphs to compute ROW's hash value. Fixes
122 assertion violations in row_equal_p. (Bug#10035)
123
f067b8ec
JB
1242011-11-14 Juanma Barranquero <lekktu@gmail.com>
125
126 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
127 just return (bug#10044).
128
1e5b2111
EZ
1292011-11-12 Eli Zaretskii <eliz@gnu.org>
130
7ef3cbd5
EZ
131 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
132 with user-defined heap size. Bump the default size of the temacs
133 heap to 27MB, to avoid memory warning when running temacs.
134 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
135
1e5b2111
EZ
136 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
137 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
138 (verify_row_hash) [XASSERTS]: New function.
139 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
140 that the hash value of glyph rows is correct.
1e5b2111 141
89d61221
MR
1422011-11-12 Martin Rudalics <rudalics@gmx.at>
143
144 * window.h (window): Remove splits slot.
145 * window.c (Fwindow_splits, Fset_window_splits): Remove.
146 (Fdelete_other_windows_internal, make_parent_window)
147 (make_window, Fsplit_window_internal, Fdelete_window_internal)
148 (Fset_window_configuration, save_window_save): Don't deal with
149 split status of windows.
150 (saved_window): Remove splits slot.
151 (Vwindow_splits): Rewrite doc-string.
152
97f18cc8
JD
1532011-11-11 Jan Djärv <jan.h.d@swipnet.se>
154
155 * xfns.c (unwind_create_frame):
156 * nsfns.m (unwind_create_frame):
157 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
158 Vframe_list (Bug#9999).
159
22a648b4
DA
1602011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
161
0b381c7e 162 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 163
659afede
KH
1642011-11-11 Kenichi Handa <handa@m17n.org>
165
166 * callproc.c (Fcall_process): Set the member dst_multibyte of
167 process_coding.
168
9ac0394b
KH
1692011-11-11 Johan Bockgård <bojohan@gnu.org>
170
171 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
172 avoid a crash (bug#9496).
173
2fbdc249
CY
1742011-11-09 Chong Yidong <cyd@gnu.org>
175
176 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
177 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
178
ac6b1f81
PE
1792011-11-08 Paul Eggert <eggert@cs.ucla.edu>
180
181 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
182
09db192c
PE
1832011-11-08 Paul Eggert <eggert@cs.ucla.edu>
184
185 Avoid some portability problems by eschewing 'extern inline' functions.
186 The trivial performance wins aren't worth the portability hassles; see
187 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
188 et seq.
189 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
190 (window_box_width, window_box_left, window_box_left_offset)
191 (window_box_right, window_box_right_offset): Undo previous change,
192 by removing the "extern"s.
193 * intervals.c (adjust_intervals_for_insertion)
194 (adjust_intervals_for_deletion): Undo previous change,
195 making these static again.
196 (offset_intervals, temp_set_point_both, temp_set_point)
197 (copy_intervals_to_string): No longer inline.
198 * xdisp.c (window_text_bottom_y, window_box_width)
199 (window_box_height, window_box_left_offset)
200 (window_box_right_offset, window_box_left, window_box_right)
201 (window_box): No longer inline.
202
105216ed
CY
2032011-11-08 Chong Yidong <cyd@gnu.org>
204
205 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
206 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
207 an error if not a live window.
208 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
209 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
210
ae9e237f
JB
2112011-11-07 Juanma Barranquero <lekktu@gmail.com>
212
213 * lisp.h (syms_of_abbrev): Remove declaration.
214 Reported by CHENG Gao <chenggao@royau.me>.
215
c7aa8333
EZ
2162011-11-07 Eli Zaretskii <eliz@gnu.org>
217
218 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
219 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
220 of temacs in GUI mode.
221
be7f5545
MR
2222011-11-07 Martin Rudalics <rudalics@gmx.at>
223
224 * window.h: Declare delete_all_child_windows instead of
225 delete_all_subwindows.
226 * window.c (Fwindow_nest, Fset_window_nest)
227 (Fset_window_new_total, Fset_window_new_normal)
228 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
229 (delete_all_subwindows): Rename to delete_all_child_windows.
230 (Fdelete_other_windows_internal, Fset_window_configuration):
231 Call delete_all_child_windows instead of delete_all_subwindows.
232 * frame.c (delete_frame): Call delete_all_child_windows instead
233 of delete_all_subwindows.
234
ca78dc43
PE
2352011-11-07 Paul Eggert <eggert@cs.ucla.edu>
236
237 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
238 This is also needed for porting to any host where GC_MARK_STACK is
239 not GC_MAKE_GCPROS_NOOPS.
240 (which_symbols): Use it.
241
a0241d01
KH
2422011-11-07 Kenichi Handa <handa@m17n.org>
243
244 * coding.c (coding_set_destination): Check coding->src_pos only
245 when coding->src_object is a buffer (bug#9910).
246
247 * process.c (send_process): Set the member src_multibyte of coding
248 to 0 (bug#9911) when sending a unibyte text.
249
250 * callproc.c (Fcall_process): Set the member src_multibyte of
251 process_coding to 0 (bug#9912).
252
a64bfdfa 2532011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
254
255 * xmenu.c (cleanup_widget_value_tree): New function.
256 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
257 calling free_menubar_widget_value_tree directly (Bug#9830).
258
cb41b32a
PE
2592011-11-06 Paul Eggert <eggert@cs.ucla.edu>
260
261 Fix some portability problems with 'inline'.
262 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
263 (window_box_width, window_box_left, window_box_left_offset)
264 (window_box_right, window_box_right_offset): Declare extern.
265 Otherwise, these inline functions do not conform to C99 and
266 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
267 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
268 * intervals.c (adjust_intervals_for_insertion)
269 (adjust_intervals_for_deletion): Now extern, because otherwise the
270 extern inline functions 'offset_intervals' couldn't refer to it.
271 (static_offset_intervals): Remove.
272 (offset_intervals): Rewrite using the old contents of
273 static_offset_intervals. The old version didn't conform to C99
274 because an extern inline function contained a reference to an
275 identifier with static linkage.
276
b7041366
AS
2772011-11-06 Andreas Schwab <schwab@linux-m68k.org>
278
279 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
280 GC.
281
88a37c4d
EZ
2822011-11-06 Eli Zaretskii <eliz@gnu.org>
283
284 * xdisp.c (init_iterator, reseat_to_string): Don't set the
285 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
286 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
287 return Qleft_to_right.
288
49745b39
CY
2892011-11-06 Chong Yidong <cyd@gnu.org>
290
291 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
292 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
293 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
294 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
295 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
296 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
297 (Fwindow_vscroll): Doc fix.
298 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
299 argument, since it makes no sense to pass a live window and for
300 consistency with window-child.
301
1f05cd82
CS
3022011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
303
304 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
305 support MSVC.
306
22610910
JR
3072011-11-05 Jason Rumney <jasonr@gnu.org>
308
309 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
310 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
311 fonts (Bug#6029).
312 (add_font_entity_to_list): Fix logic errors in mixed boolean and
313 bitwise arithmetic preventing use of unicode-sip and non-truetype
314 opentype fonts.
315
a06776b2
EZ
3162011-11-05 Eli Zaretskii <eliz@gnu.org>
317
3ad924ba
EZ
318 * s/ms-w32.h (fstat, stat, utime): Move redirections to
319 "emacs"-only part.
320
a06776b2
EZ
321 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
322 initialization code to keep similarity to xfns.c after changes
323 from 2011-11-05.
324
c9e7db78
JD
3252011-11-05 Jan Djärv <jan.h.d@swipnet.se>
326
a97f8f3f
JD
327 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
328 (unwind_create_frame): New function (Bug#9943).
329 (Fx_create_frame): Restructure code to be more similar to the one in
330 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
331 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
332 Move terminal->reference_count++ just before making the frame official
333 (Bug#9943).
334
335 * nsterm.m (x_free_frame_resources): New function.
336 (x_destroy_window): Move code to x_free_frame_resources.
337
c9e7db78
JD
338 * xfns.c (unwind_create_frame): Fix comment.
339 (Fx_create_frame, x_create_tip_frame): Move
340 terminal->reference_count++ just before making the frame
341 official. Move initialization of image_cache_refcount and
342 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
343
a6fc3b5c
EZ
3442011-11-05 Eli Zaretskii <eliz@gnu.org>
345
346 Support MSVC build with newer versions of Visual Studio.
347 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
348 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
349 nt/gmake.defs.
350
351 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
352 which are not supported by MSVC.
353 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
354 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
355 bitfields.
356 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
357 types in bitfields.
358 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
359
360 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
361
58179cce 3622011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
363
364 Support MSVC build with newer versions of Visual Studio.
365 * w32.c: Don't include w32api.h for MSVC.
366 (init_environment) [_MSC_VER]: Call sys_access, not _access.
367
368 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
369 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
370 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
371 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
372 e_* cousins.
373 (alloca) [_MSC_VER]: Define to _alloca.
374
375 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
376
377 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
378
a58c13ed
EZ
3792011-11-04 Eli Zaretskii <eliz@gnu.org>
380
381 * xdisp.c (note_mouse_highlight): If either of
382 previous/next-single-property-change returns nil, treat that as
383 the beginning or the end of the buffer. (Bug#9955)
384
fe0b6370
JD
3852011-11-04 Jan Djärv <jan.h.d@swipnet.se>
386
a58c13ed 387 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
388 label is not null (Bug#9951).
389 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
390 may be NULL.
391
89bd5ee1
EZ
3922011-11-04 Eli Zaretskii <eliz@gnu.org>
393
394 * window.c (Fwindow_body_size): Mention in the doc string that the
395 return value is in frame's canonical units. (Bug#9949)
396
84c3edb9
EZ
3972011-11-03 Eli Zaretskii <eliz@gnu.org>
398
4e2fb5c7
EZ
399 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
400
84c3edb9 401 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 402 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 403 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 404
bc17a887
EZ
4052011-11-01 Eli Zaretskii <eliz@gnu.org>
406
407 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
408 Don't stop backward scan on the continuation glyph, even though
409 its CHARPOS is positive.
26b46e51
EZ
410 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
411 cover_string to disp_string.
bc17a887 412
4ee88440
MR
4132011-11-01 Martin Rudalics <rudalics@gmx.at>
414
415 * window.c (temp_output_buffer_show): Don't use
416 Vtemp_buffer_show_specifiers.
417 (Vtemp_buffer_show_specifiers): Remove unused variable.
418
c2ff3c02
EZ
4192011-10-30 Eli Zaretskii <eliz@gnu.org>
420
421 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
422 past the beginning of the current glyph matrix.
423
58179cce 4242011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
425
426 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
427 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
428 HAVE_GTK3 (Bug#9869).
b77a6a7f 429
3b574623
JD
430 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
431 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
432
b77a6a7f
JD
433 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
434
435 * xterm.c: Declare x_handle_net_wm_state to return int.
436 (handle_one_xevent): Check if we are iconified but don't have
437 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
438 (get_current_wm_state): Return non-zero if not hidden,
439 check for _NET_WM_STATE_HIDDEN (Bug#9893).
440 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
441 (x_handle_net_wm_state): Return what get_current_wm_state returns.
442 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
443
196e41e4
PE
4442011-10-29 Paul Eggert <eggert@cs.ucla.edu>
445
446 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
447 so that this new function doesn't get optimized away by a
448 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
449
021f2e1a
AS
4502011-10-29 Andreas Schwab <schwab@linux-m68k.org>
451
452 * frame.h (MOUSE_HL_INFO): Remove excess parens.
453
8b058d44
EZ
4542011-10-29 Eli Zaretskii <eliz@gnu.org>
455
456 Fix the `xbytecode' command.
457 * .gdbinit (xprintbytestr): New command.
b50a28de 458 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
459 (xbytecode): Print the byte-code string as well.
460
4452fb80
EZ
4612011-10-29 Kim Storm <storm@cua.dk>
462
8b058d44
EZ
463 * alloc.c (which_symbols): New function.
464
21b72067
AS
4652011-10-29 Andreas Schwab <schwab@linux-m68k.org>
466
467 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
468 line. (Bug#9903)
469
83ed7b5c
GM
4702011-10-29 Glenn Morris <rgm@gnu.org>
471
472 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
473 Not clear what it was for, and it causes various bugs. (Bug#9839)
474
5a7a728b
EZ
4752011-10-28 Eli Zaretskii <eliz@gnu.org>
476
477 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
478 possible random value that matches one of those tested as
479 condition to clear the mouse face.
480
d3d0842f
CY
4812011-10-28 Chong Yidong <cyd@gnu.org>
482
483 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
484
31b39d13
DN
4852011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
486
487 * window.c (make_window): Initialize phys_cursor_on_p.
488
9aba6043
SM
4892011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
490
491 * lisp.h (struct Lisp_Symbol): Update comments.
492
c20992f4
JB
4932011-10-28 Juanma Barranquero <lekktu@gmail.com>
494
495 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
496
db4f02f2
EZ
4972011-10-28 Eli Zaretskii <eliz@gnu.org>
498
499 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
500 <oslsachem@gmail.com> for helping to debug this.
501
502 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
503 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
504 (g_b_init_get_glyph_outline_w): New static variables.
505 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
506 (GetGlyphOutlineW_Proc): New typedefs.
507 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
508 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
509 New functions.
510 (w32font_open_internal, compute_metrics):
511 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
512 instead of calling the "wide" APIs directly.
513
514 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
515
516 * w32.h (syms_of_w32font): Add prototype.
517
87e68db4
JB
5182011-10-27 Juanma Barranquero <lekktu@gmail.com>
519
520 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
521 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
522 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
523 (Fmove_to_window_line): Doc fix.
524
435c1d67
CY
5252011-10-27 Chong Yidong <cyd@gnu.org>
526
527 * process.c (make_process): Set gnutls_state to NULL.
528
529 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
530 non-NULL, regardless of GNUTLS_INITSTAGE.
531 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
532 an error. Set process slots as soon as we allocate them.
533
534 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
535
9c6c6f49
CY
5362011-10-27 Chong Yidong <cyd@gnu.org>
537
9aba6043
SM
538 * gnutls.c (emacs_gnutls_deinit): New function.
539 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
540 (Fgnutls_deinit, Fgnutls_boot): Use it.
541
542 * process.c (make_process): Initialize GnuTLS credentials to NULL.
543 (deactivate_process): Call emacs_gnutls_deinit.
544
657d08d3
JB
5452011-10-27 Juanma Barranquero <lekktu@gmail.com>
546
547 * image.c (x_create_x_image_and_pixmap):
548 * w32.c (sys_rename, w32_delayed_load):
549 * w32font.c (fill_in_logfont):
550 * w32reg.c (x_get_string_resource): Silence compiler warnings.
551
5430d399
JB
5522011-10-26 Juanma Barranquero <lekktu@gmail.com>
553
554 * w32fns.c (w32_default_color_map): New function,
555 extracted from Fw32_default_color_map.
a7ef684b 556 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 557
fe0055fa
PE
5582011-10-25 Paul Eggert <eggert@cs.ucla.edu>
559
560 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
561
e6346438
SM
5622011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
563
564 * keyboard.c (test_undefined): New function (bug#9751).
565 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
566
e112cc37
ET
5672011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
568
569 * sysdep.c (init_sys_modes): Fix the check for the controlling
570 terminal (Bug#6649).
571
7b5d6677
EZ
5722011-10-20 Eli Zaretskii <eliz@gnu.org>
573
574 * dispextern.h (struct bidi_it): New member next_en_type.
575
576 * bidi.c (bidi_line_init): Initialize the next_en_type member.
577 (bidi_resolve_explicit_1): When next_en_pos is valid for the
578 current character, check also for next_en_type being WEAK_EN.
579 (bidi_resolve_weak): Don't enter the expensive loop if the current
580 position is before next_en_pos. Record the bidi type of the first
581 non-ET, non-BN character we find, in addition to its position.
582 (bidi_level_of_next_char): Invalidate next_en_type when
583 next_en_pos is over-stepped.
584
7da0b018
PE
5852011-10-20 Paul Eggert <eggert@cs.ucla.edu>
586
587 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
588 * editfns.c: Rewrite current-time-zone so that it invokes
589 the equivalent of (format-time-string "%Z") to get the time zone name.
590 This fixes a bug when the time zone name contains characters that
591 need converting from the system time locale to Emacs internal format.
592 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
593 that patch fixed format-time-string to do the conversion, but
594 I forgot to fix current-time-zone.
595 (format_time_string): New function, containing most of
596 what Fformat_time_string used to contain.
597 (Fformat_time_string): Rewrite in terms of format_time_string.
598 This doesn't change this function's behavior.
599 (current-time-zone): Rewrite to use format_time_string.
600 This fixes the bug reported by Michael Schierl in
601 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
602 Jason Rumney's 2007-06-07 change worked around this bug, but
603 didn't fix it.
604 * systime.h (tzname, timezone): Remove no-longer-used declarations.
605
8547b010
EZ
6062011-10-19 Eli Zaretskii <eliz@gnu.org>
607
608 * xdisp.c (start_display): If the character at POS is displayed
609 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
610 (try_window_reusing_current_matrix): If a line ends in a display
611 vector or the next line starts in a display vector, continue
612 redrawing the window even though the character position of
613 start_row was reached.
8547b010
EZ
614 (Bug#9771, part 2)
615
4e948d15
CY
6162011-10-18 Chong Yidong <cyd@gnu.org>
617
618 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
619 with nobreak-char-display too.
620
4787455f
EZ
6212011-10-18 Eli Zaretskii <eliz@gnu.org>
622
623 Fix part 3 of bug#9771.
624 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
625 (bidi_resolve_neutral): Don't enter the expensive loop looking for
626 non-neutral characters if the current character is a paragraph
627 separator (a.k.a. Newline). This avoids running the same
628 expensive loop twice, once when we consume the preceding newline
629 and the other time when the line actually needs to be displayed.
630 Avoid the loop when we see neutrals on the base embedding level
631 following a character whose directionality is the same as the
632 paragraph's. This avoids running the expensive loop when a line
633 ends in a long sequence of neutrals, like control characters.
634 Add assertion against STRONG_AL type. Slightly rearrange code
635 that determines the type of a neutral given the first non-neutral
636 that follows it.
637 (bidi_level_of_next_char): Set next_en_pos to zero when
638 invalidating its info.
639
2c91f553
EZ
6402011-10-17 Eli Zaretskii <eliz@gnu.org>
641
642 * xdisp.c (push_display_prop): Determine whether to record string
643 or buffer position by IT->string, not by IT->method. Allow
644 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
645 (move_it_vertically_backward): Don't look for character position
646 immediately after the newline when in a continuation line.
647 (Bug#9771, part 1)
2c91f553 648
c7b08b0d
MR
6492011-10-15 Martin Rudalics <rudalics@gmx.at>
650
651 * window.c (coordinates_in_window): Rewrite and delabelize
652 vertical border check. (Bug#5357) (Bug#9618)
653
6b02f655
SM
6542011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
655
656 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
657 errors in XSetWindowBorder (bug#9310).
658
81d40c92
DA
6592011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
660
661 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
662 avoid crash when xmalloc overrun checking is enabled.
663
d4172c3b
EZ
6642011-10-13 Eli Zaretskii <eliz@gnu.org>
665
666 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
667 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
668 cursor motion with <left> and <right> arrow keys.
669
670 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
671 some callers set that themselves.
672
b00eea75
EZ
6732011-10-12 Eli Zaretskii <eliz@gnu.org>
674
675 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
676 display string and the previous row comes from the same string and
677 is empty. (Bug#9739) (Bug#9738)
678
8fe012c4
SM
6792011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
680
681 * doc.c (get_doc_string): Encode file name (bug#9735).
682
0074aef2
EZ
6832011-10-12 Eli Zaretskii <eliz@gnu.org>
684
79beb178
EZ
685 * bidi.c (bidi_level_of_next_char):
686 * xdisp.c (get_visually_first_element): Remove old incorrect
687 comments regarding the Unicode Line Separator character.
688
0074aef2
EZ
689 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
690
6e4b3fbe
DA
6912011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
692
693 * alloc.c (Fgc_status): Do not access beyond zombies array
694 boundary if nzombies > MAX_ZOMBIES.
695 * alloc.c (dump_zombies): Add missing format specifier.
696
0324f3af
PE
6972011-10-12 Paul Eggert <eggert@cs.ucla.edu>
698
b5525cac
PE
699 * xdisp.c (set_cursor_from_row): Simplify conditionals,
700 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
701
0324f3af
PE
702 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
703 Some packages use them to denote characters with modifiers.
704
e9b5f888
AS
7052011-10-11 Andreas Schwab <schwab@linux-m68k.org>
706
707 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
708 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
709 matching a pp-number. Rename parameter var to var1.
710
127827c0
SM
7112011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
712
713 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
714
c8fd3bd0
GM
7152011-10-08 Glenn Morris <rgm@gnu.org>
716
717 * callint.c (Fcall_interactively): Give a more explicit error for the
718 'c' case with a non-character input. (Bug#8479)
719
352ec8ff
EZ
7202011-10-08 Eli Zaretskii <eliz@gnu.org>
721
03669ccb
EZ
722 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
723 lines.
7061c986
EZ
724 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
725 lines that are hscrolled on the left.
03669ccb 726
352ec8ff
EZ
727 * dispnew.c (buffer_posn_from_coords): Account for a possible
728 presence of header-line. (Bug#4426)
729
a66cfb1c
SM
7302011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
731
6b02f655
SM
732 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
733 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 734
7c5ee88e
PE
7352011-10-07 Paul Eggert <eggert@cs.ucla.edu>
736
737 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
738 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
739 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
740 this makes Emacs dump core during garbage collection on rare
741 occasions. sizeof is obviously inferior to offsetof here, so
742 stick with offsetof.
743 (GC_POINTER_ALIGNMENT): New macro.
744 (mark_memory): Omit 3rd (offset) arg; caller changed.
745 Don't assume EMACS_INT alignment is the same as pointer alignment.
746
df1bbe5b
SM
7472011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
748
749 * keyboard.c (read_key_sequence_remapped): New var.
750 (read_key_sequence): Compute remapping in the right buffer.
751 (command_loop_1): Use read_key_sequence's remapping directly.
752
51553db6
SM
7532011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
754
32c1fffd
SM
755 * dired.c (file_name_completion): Don't expand file name.
756 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
757 before checking file name handler.
758
51553db6
SM
759 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
760 they've been requested explicitly (bug#9591).
761
b6bd1599 7622011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
763
764 * keymap.c (Fsingle_key_description): Use make_specified_string
765 instead of build_string to build string from push_key_description.
766 (Bug#5193)
767
f701dc2a
PE
7682011-09-30 Paul Eggert <eggert@cs.ucla.edu>
769
4222c55d
PE
770 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
771 This fixes a Y2038 bug on 64-bit hosts.
772 * buffer.c (reset_buffer):
773 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
774 (Fclear_buffer_auto_save_failure):
775 Use 0, not -1, to represent an unset failure time, since time_t
776 might not be signed.
777
f701dc2a
PE
778 Remove dependency on glibc malloc internals.
779 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
780 Move back here from lisp.h, but with their new implementations.
781 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
782 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
783 * charset.c (charset_table_init): New static var.
784 (syms_of_charset): Use it instead of xmalloc. This removes a
785 dependency on glibc malloc internals. See Eli Zaretskii's comment in
786 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
787 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
788 Move back to alloc.c.
789 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
790 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
791
9ceebf39
JD
7922011-09-30 Jan Djärv <jan.h.d@swipnet.se>
793
794 * nsterm.m (windowDidResize): Call x_set_window_size only when
795 ns_in_resize is true. Otherwise set pixelwidth/height and
796 call change_frame_size (Bug#9628).
797
cb993c58
PE
7982011-09-30 Paul Eggert <eggert@cs.ucla.edu>
799
3930c88b
PE
800 Port --enable-checking=all to Fedora 14 x86-64.
801 * charset.c (syms_of_charset): Also account for glibc malloc's
802 internal overhead when calculating the initial malloc maximum.
803
cb993c58
PE
804 Port --enable-checking=all to Fedora 14 x86.
805 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
806 Move to lisp.h.
807 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
808 (overrun_check_realloc, overrun_check_free):
809 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
810 That way, xmalloc returns a properly-aligned pointer even if
811 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
812 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
813 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
814 into account when calculating the initial malloc maximum.
815 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
816 Move here from alloc.c, so that charset.c can use it too.
817 Properly align; the old code wasn't right for common 32-bit hosts
818 when configured with --enable-checking=all.
819 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
820 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
821
31bed486
EZ
8222011-09-29 Eli Zaretskii <eliz@gnu.org>
823
04c70788 824 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
825 use EDOM.
826
fbcaa2f3
EZ
8272011-09-28 Eli Zaretskii <eliz@gnu.org>
828
829 * xdisp.c (compute_display_string_end): If there's no display
830 string at CHARPOS, return -1.
831
832 * bidi.c (bidi_fetch_char): When compute_display_string_end
833 returns a negative value, treat the character as a normal
834 character not covered by a display string. (Bug#9624)
835
a239d4e9
JB
8362011-09-28 Juanma Barranquero <lekktu@gmail.com>
837
838 * lread.c (Fread_from_string): Fix typo in docstring.
839
88652fd5
EZ
8402011-09-27 Eli Zaretskii <eliz@gnu.org>
841
842 * xdisp.c (handle_invisible_prop): If invisible text ends on a
843 newline, reseat the iterator instead of bidi-iterating there one
844 character at a time. (Bug#9610)
32c1fffd
SM
845 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
846 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 847
ed497dd4
AS
8482011-09-27 Andreas Schwab <schwab@linux-m68k.org>
849
850 * lread.c (readevalloop): Use correct code for NBSP.
851 (read1): Likewise. (Bug#9608)
852
b2bf61aa
MA
8532011-09-25 Michael Albinus <michael.albinus@gmx.de>
854
855 * dbusbind.c (Fdbus_register_signal): When service is not
856 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
857
32bbb17c
GM
8582011-09-25 Glenn Morris <rgm@gnu.org>
859
860 * buffer.c (truncate-lines): Doc fix.
861
94e0933e
CY
8622011-09-24 Chong Yidong <cyd@stupidchicken.com>
863
864 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
865 (Fset_window_next_buffers): Doc fix.
866
cddde921
GM
8672011-09-24 Glenn Morris <rgm@gnu.org>
868
869 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
870
1260aef1
PE
8712011-09-24 Paul Eggert <eggert@cs.ucla.edu>
872
25b4bfa0
PE
873 Fix minor problems found by static checking.
874 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
875 * indent.c (Fvertical_motion): Fix == vs = typo.
876
e3cbd34b
EZ
8772011-09-24 Eli Zaretskii <eliz@gnu.org>
878
a66cfb1c
SM
879 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
880 Default value is now t. Doc fix.
6bf7006f 881
e3cbd34b 882 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 883 logic when moving up, not only when moving down. Fix the
e3cbd34b 884 confusing name and values of the it_overshoot_expected variable;
32c1fffd 885 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
886
887 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
888 CHARPOS is covered by a display string which includes newlines.
889 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
890 is covered by a display string with embedded newlines.
891
a3de0cbd
MA
8922011-09-24 Michael Albinus <michael.albinus@gmx.de>
893
894 * dbusbind.c (Fdbus_register_signal): Add match rule to
895 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
896 (Fdbus_register_method, Vdbus_registered_objects_table):
897 Fix docstring.
a3de0cbd 898
b260039d
JM
8992011-09-24 Jim Meyering <meyering@redhat.com>
900
32c1fffd 901 do not ignore write error for any output size
b260039d
JM
902 The previous change was incomplete.
903 While it makes emacs --batch detect the vast majority of stdout
904 write failures, errors were still ignored whenever the output size is
905 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
906 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
907 && echo FAIL: ignored write error
908 FAIL: ignored write error
909 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
910 && echo FAIL: ignored write error
911 FAIL: ignored write error
912 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
913
8eca8a7c
AS
9142011-09-23 Andreas Schwab <schwab@linux-m68k.org>
915
916 * emacs.c (Fkill_emacs): In noninteractive mode exit
917 non-successfully if a write error occurred on stdout. (Bug#9574)
918
3341db62
EZ
9192011-09-21 Eli Zaretskii <eliz@gnu.org>
920
921 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
922 the xassert test.
923
924 * dispextern.h (struct it): Update the comment documenting what
925 can it->OBJECT be.
926
8c203dbf
EZ
9272011-09-20 Eli Zaretskii <eliz@gnu.org>
928
929 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
930 a display string, extend search for cursor position to end of row.
931 (find_row_edges): If the row ends in a newline from a display
932 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
933 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
934 (Fcurrent_bidi_paragraph_direction): Fix search for previous
935 non-empty line. Fixes confusing cursor motion with arrow keys at
936 the beginning of a line that starts with whitespace.
8c203dbf 937
a4824228
LMI
9382011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
939
940 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
941 (bug#9493).
942
33ed493b
CY
9432011-09-18 Chong Yidong <cyd@stupidchicken.com>
944
945 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
946 boolean (Bug#9154).
947
56cd55c8
EZ
9482011-09-18 Eli Zaretskii <eliz@gnu.org>
949
950 * xdisp.c (display_line): Record maximum and minimum buffer
951 positions even if no glyphs were produced (e.g., by a zero-width
952 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
953 buffer positions that will be removed from the glyph row because
954 they don't fit.
c02dcedf
EZ
955 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
956 column is beyond frame width: don't subtract 1 "pixel" when
957 computing width of the stretch.
3e62b7e0
EZ
958 (reseat_at_next_visible_line_start): Undo the change made on
959 2011-09-17 that saved paragraph information and restored it after
960 the call to `reseat'. (Bug#9545)
56cd55c8 961
5ed99d36 9622011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
963
964 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
965 and turn window cursor on if cleared (Bug#9415).
966
5ed99d36 9672011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
968
969 * search.c (boyer_moore): Take unibyte characters from pattern
970 literally. (Bug#9458)
971
9bade7b2
EZ
9722011-09-18 Eli Zaretskii <eliz@gnu.org>
973
974 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
975
e5e9d610
PE
9762011-09-18 Paul Eggert <eggert@cs.ucla.edu>
977
87e4427a
PE
978 Fix minor problem found by static checking.
979 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
980 initialized, to pacify gcc -Wuninitialized.
981
e5e9d610
PE
982 * fileio.c: Report proper errno when syscall falls.
983 (Finsert_file_contents): Save and restore errno,
984 so that report_file_error outputs the correct diagnostic.
985 (Fwrite_region) [CLASH_DETECTION]: Likewise.
986
a1674f0b
EZ
9872011-09-18 Eli Zaretskii <eliz@gnu.org>
988
989 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
990
fbfb6dd4
EZ
9912011-09-17 Eli Zaretskii <eliz@gnu.org>
992
993 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
994 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
995
bb187662
EZ
9962011-09-17 Eli Zaretskii <eliz@gnu.org>
997
1137e8b8 998 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 999 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1000
1001 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1002 (bidi_find_paragraph_start): Search back for paragraph beginning
1003 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1004 (bidi_move_to_visually_next): Only trigger paragraph-related
1005 computations when the last character is a newline or at EOB, not
1006 just any NEUTRAL_B. (Bug#9470)
1007
bb187662
EZ
1008 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1009 truncated lines if point is covered by a display string. (Bug#9524)
1010
2e621251
PE
10112011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1012
1013 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1014 (cons_to_x_long): New function.
1015 (lisp_data_to_selection_data): Use it. Correct the test for
1016 short-versus-long data; it was negated. Break out of vector
1017 loop, for efficiency, when a long datum is discovered.
1018
91a15bc6
SM
10192011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1020
1021 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1022
b41c3a35
EZ
10232011-09-16 Eli Zaretskii <eliz@gnu.org>
1024
1025 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1026 GCC PR/17406) by declaring this function with external scope.
1027
7812ba2d
PE
10282011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1029
1030 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1031 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1032
cf7edc2a
AS
10332011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1034
1035 * editfns.c (Fformat): Correctly handle text properties on "%%".
1036
bd01620e
EZ
10372011-09-15 Eli Zaretskii <eliz@gnu.org>
1038
1039 * xterm.c (x_draw_composite_glyph_string_foreground):
1040 * w32term.c (x_draw_composite_glyph_string_foreground):
1041 * term.c (encode_terminal_code):
1042 * composite.c (composition_update_it, get_composition_id):
1043 * xdisp.c (get_next_display_element)
1044 (fill_composite_glyph_string): Add comments about special meaning
1045 of TAB characters in a composition.
1046
a02719a3
PE
10472011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1048
1049 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1050 This occurs when processing a multibyte format.
1051 Problem reported by Wolfgang Jenker.
a02719a3 1052
72589a3c
JB
10532011-09-15 Johan Bockgård <bojohan@gnu.org>
1054
1055 * xdisp.c (try_cursor_movement): Only check for exact match if
1056 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1057
1c14176c
PE
10582011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1059
1060 Remove unused external symbols.
1061 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1062 * xdisp.c (calc_pixel_width_or_height): Now static.
1063 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1064 * indent.c (check_display_width):
1065 * w32term.c: Fix comment to match code.
1066 * xterm.c, xterm.h (x_catching_errors): Remove.
1067
d2eea5b5
PE
10682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1069
1070 * xselect.c: Use signed conversions more consistently (Bug#9498).
1071 (selection_data_to_lisp_data): Assume incoming selection data are
1072 signed integers, not unsigned. This is to be consistent with
1073 outgoing selection data, which was modified to use signed integers
1074 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1075 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1076 expects long, not unsigned long.
1077
46888499
EZ
10782011-09-14 Eli Zaretskii <eliz@gnu.org>
1079
1080 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1081 computation of loop end. Reported by Johan Bockgård
1082 <bojohan@gnu.org>.
1083
ef8ef9fb
CY
10842011-09-13 Chong Yidong <cyd@stupidchicken.com>
1085
1086 * frame.c (Fother_visible_frames_p): Function deleted.
1087
fa819fed
EZ
10882011-09-12 Eli Zaretskii <eliz@gnu.org>
1089
1090 * indent.c (compute_motion): Process display vector front to back
1091 rather than the other way around. (Bug#2496)
1092
2ba8e008
SM
10932011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1094
1095 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1096
20f53c69
CY
10972011-09-11 Chong Yidong <cyd@stupidchicken.com>
1098
1099 * minibuf.c (Fread_from_minibuffer): Doc fix.
1100
d562d7a4
EZ
11012011-09-11 Eli Zaretskii <eliz@gnu.org>
1102
1103 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1104 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1105
1c4d7f3d
LMI
11062011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1107
1108 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1109 value for non-existent files.
1110
b885bf36
EZ
11112011-09-11 Eli Zaretskii <eliz@gnu.org>
1112
1113 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1114 set its "size" to -1. This will set the modtime_size field of
1115 the corresponding buffer to -1, which is what
1116 verify-visited-file-modtime expects for files that do not exist.
1117 (Bug#9139)
1118
6612f0bf
PE
11192011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1120
1121 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1122 here ...
1123 * lisp.h: ... from here. push_key_description is no longer
1124 defined in keyboard.c, so its declaration should not be in
1125 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1126 logically belongs with push_key_description.
1127
dfb3f755
PE
11282011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1129
1130 * buffer.h: Include <sys/types.h> instead of <time.h>.
1131 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1132 Problem reported by Herbert J. Skuhra.
1133
3134906c
LMI
11342011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1135
1136 * xml.c (parse_region): Make the parsing work for
1137 non-comment-starting XML files again (bug#9144).
1138
8d903f4e
AS
11392011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1140
1141 * image.c (gif_load): Fix calculation of bottom and right corner.
1142 (Bug#9468)
1143
80ad64f4
EZ
11442011-09-10 Eli Zaretskii <eliz@gnu.org>
1145
1146 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1147 redisplay in small windows.
1148
208a048d
EZ
11492011-09-09 Eli Zaretskii <eliz@gnu.org>
1150
1151 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1152
9b1c252e
MR
11532011-09-08 Martin Rudalics <rudalics@gmx.at>
1154
1155 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1156 Operate on live windows only.
1157
2949f33b
JB
11582011-09-08 Juanma Barranquero <lekktu@gmail.com>
1159
1160 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1161
e08dcafd
EZ
11622011-09-07 Eli Zaretskii <eliz@gnu.org>
1163
1164 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1165 only under bidi iteration.
1166
115b96bd
JD
11672011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1168
1169 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1170
c8199d0f
PE
11712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1172
1173 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1174 Without this fix, the command to link temacs failed due to an
1175 undefined symbol __builtin_isnan. This is because
1176 /usr/include/iso/math_c99.h #defines isnan(x) to
1177 __builtin_isnan(x), but the bundled gcc, which identifies itself
1178 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1179 a __builtin_isnan.
1180 * floatfns.c (isnan): #undef, and then #define to a clone of
1181 what's in data.c.
1182 (Fisnan): Always define, since it's always available now.
1183 (syms_of_floatfns): Always define isnan at the Lisp level.
1184
e39b275c 11852011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1186
1187 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1188
b2db44d9 11892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1190
f4af5137 1191 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1192 The previous code assumed that file offsets (off_t values) fit in
1193 EMACS_INT variables, which is not true on typical 32-bit hosts.
1194 The code messed up by falsely reporting buffer overflow in cases
1195 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1196 when "big" contains more than 2**29 bytes, even though this
1197 inserts just one byte and does not overflow the buffer.
1198 (Finsert_file_contents): Store file offsets as off_t
1199 values, not as EMACS_INT values. Check for overflow when
1200 converting between EMACS_INT and off_t. When checking for
1201 buffer overflow or for overlap, take the offsets into account.
1202 Don't use EMACS_INT for small values where int suffices.
1203 When checking for overlap, fix a typo: ZV was used where
1204 ZV_BYTE was intended.
1205 (Fwrite_region): Don't assume off_t fits into 'long'.
1206 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1207
ecfc0a49
MA
12082011-09-05 Michael Albinus <michael.albinus@gmx.de>
1209
1210 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1211
6511acf2 12122011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1213
0999621a 1214 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1215
1216 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1217 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1218 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1219 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1220 (modify_event_symbol): Do not assume that the length of
1221 name_alist_or_stem is safe to alloca and fits in int.
1222 (Fexecute_extended_command): Likewise for function name and binding.
1223 (Frecursion_depth): Wrap around reliably on integer overflow.
1224 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1225 since some callers pass EMACS_INT values.
1226 (Fsingle_key_description): Don't crash if symbol name contains more
1227 than MAX_ALLOCA bytes.
1228 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1229 (get_minibuffer): Arg is now EMACS_INT, not int.
1230 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1231 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1232 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1233
2be7d702
PE
1234 * dbusbind.c (signature_cat): New function.
1235 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1236 Do not overrun buffer; instead, report string overflow.
1237
9d1df220
PE
1238 * dispnew.c (add_window_display_history): Don't overrun buffer.
1239 Truncate instead; this is OK since it's just a log.
1240
33ef5c64
PE
1241 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1242 even if the time zone offset is outlandishly large.
1243 Don't mishandle offset == INT_MIN.
1244
66c6fdd5
PE
1245 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1246 when creating daemon; the previous buffer-overflow check was incorrect.
1247
d749b01b
PE
1248 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1249 which has the guts of the old verror function.
1250
b5cd1905
PE
1251 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1252 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1253
6e1a67fb
PE
1254 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1255 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1256 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1257 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1258 length of string rather than counting it via multiple sprintfs;
1259 that's simpler and more reliable.
c21721cc
PE
1260 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1261 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1262 sprintf, in case result does not fit in int.
1263
c57b67fc
PE
1264 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1265 (fontset_from_font): Print it.
1266
8a401434
PE
1267 * frame.c (tty_frame_count): Now printmax_t, not int.
1268 (make_terminal_frame, set_term_frame_name): Print it.
1269 (x_report_frame_params): In X, window IDs are unsigned long,
1270 not signed long, so print them as unsigned.
1271 (validate_x_resource_name): Check for implausibly long names,
1272 and don't assume name length fits in 'int'.
1273 (x_get_resource_string): Don't blindly alloca invocation name;
1274 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1275 not fit in int.
1276
6e1a67fb
PE
1277 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1278 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1279 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1280
0df02bf3
PE
1281 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1282 Use esprintf, not sprintf, in case result does not fit in int.
1283
48e30793
PE
1284 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1285 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1286 it as a large positive number.
1287 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1288 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1289
a66ff6d8
PE
1290 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1291 in case result does not fit in int.
1292
aca216ff
PE
1293 * print.c (float_to_string): Detect width overflow more reliably.
1294 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1295 buffer overrun. Don't assume list length fits in 'int'. Treat
1296 print length of 0 as 0, not as infinity; to be consistent with other
1297 uses of print length in this function. Don't overflow print length
1298 index. Don't assume hash table size fits in 'long', or that
1299 vectorlike size fits in 'unsigned long'.
1300
31c286f7
PE
1301 * process.c (make_process): Use printmax_t, not int, to format
1302 process-name gensyms.
1303
55e5faa1
PE
1304 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1305
80f2e268
PE
1306 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1307 to avoid potential buffer overrun.
1308
670741ab
PE
1309 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1310 if X resource line is longer than 512 bytes.
1311
b7163a50
PE
1312 * xfns.c (x_window): Make sprintf buffer a bit bigger
1313 to avoid potential buffer overrun.
1314
ae58ff1f
PE
1315 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1316
c43c8a6a
PE
1317 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1318
3f8236f4
PE
13192011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1320
53e9fe90 1321 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1322 Without these, Emacs silently mishandles large integers sometimes.
1323 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1324 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1325
6511acf2
PE
1326 * xdisp.c (try_window_id): Check Emacs fixnum range before
1327 converting to 'int'.
806add1d 1328
6511acf2 1329 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1330 Check that an Emacs fixnum is in range before assigning it to 'int'.
1331 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1332 values converted from Emacs fixnums.
1333 (Frecenter): Don't wrap around a line count if it is out of 'int'
1334 range; instead, treat it as an extreme value.
1335 (Fset_window_configuration, compare_window_configurations):
1336 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1337
6511acf2
PE
1338 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1339 that can exceed INT_MAX. Check that EMACS_INT value is in range
1340 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1341 (match_limit): Don't assume that a fixnum can fit in 'int'.
1342
6511acf2 1343 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1344 exceed INT_MAX.
1345
6511acf2 1346 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1347 (Fvertical_motion): Don't wrap around LINES values that don't fit
1348 in 'int'. Instead, treat them as extreme values. This is good
1349 enough for windows, which can't have more than INT_MAX lines anyway.
1350
fcb901a7
LMI
13512011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1352
0f2f6b6d
LMI
1353 * Require libxml/parser.h to avoid compilation warning.
1354
fcb901a7
LMI
1355 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1356
1357 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1358 since this reportedly can destroy thread storage.
1359
6e20a0d4
CY
13602011-08-30 Chong Yidong <cyd@stupidchicken.com>
1361
1362 * syntax.c (find_defun_start): Update all cache variables if
1363 exiting early (Bug#9401).
1364
148ae00e
EZ
13652011-08-30 Eli Zaretskii <eliz@gnu.org>
1366
f6cfbd8f
EZ
1367 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1368
148ae00e
EZ
1369 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1370 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1371 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1372
1373 * term.c (tty_append_glyph): New function.
1374 (produce_stretch_glyph): Static function and its prototype deleted.
1375
a66cfb1c
SM
1376 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1377 Add prototypes.
148ae00e 1378
c4a07a4c
PE
13792011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1380
1381 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1382 when checking :margin (Bug#9390).
1383 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1384 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1385 so that the name doesn't mislead. All uses changed.
1386
6bc8cd65
JB
13872011-08-28 Johan Bockgård <bojohan@gnu.org>
1388
1389 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1390 set_tty_hooks.
1391
dca4927e
EZ
13922011-08-27 Eli Zaretskii <eliz@gnu.org>
1393
1394 * xdisp.c (move_it_to): Don't bail out early when reaching
1395 position beyond to_charpos, if we are scanning backwards.
1396 (move_it_vertically_backward): When DY == 0, make sure we get to
1397 the first character in the line after the newline.
1398
f2cad773
PE
13992011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1400
1401 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1402 (ccl_driver): Do not generate an out-of-range pointer.
1403 (Fccl_execute_on_string): Remove unnecessary check for
1404 integer overflow, noted by Stefan Monnier in
1405 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1406 Remove a FIXME that didn't need fixing.
1407 Simplify the newly-introduced buffer reallocation code.
1408
0cae2cdb
JB
14092011-08-27 Juanma Barranquero <lekktu@gmail.com>
1410
1411 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1412
5fc295a4 14132011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1414
70c60eb2 1415 Integer and memory overflow issues (Bug#9196).
726e0ab1 1416
d31850da
PE
1417 * doc.c (get_doc_string): Rework so that
1418 get_doc_string_buffer_size is the actual buffer size, rather than
1419 being 1 less than the actual buffer size; this makes xpalloc more
1420 convenient.
1421
a69fbedb
PE
1422 * image.c (x_allocate_bitmap_record, cache_image):
1423 * xselect.c (Fx_register_dnd_atom):
1424 Simplify previous changes by using xpalloc.
1425
fe5c5d37
PE
1426 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1427 since either will do and ptrdiff_t is convenient with xpalloc.
1428
0065d054
PE
1429 * charset.c (charset_table_size)
1430 (struct charset_sort_data.priority): Now ptrdiff_t.
1431 (charset_compare): Don't overflow if priorities differ greatly.
1432 (Fsort_charsets): Don't assume list length fits in int.
1433 Check for size-calculation overflow when allocating sort data.
1434 (syms_of_charset): Allocate an initial charset table that is
1435 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1436
1437 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1438
1439 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1440 The actual value is always <= INT_MAX, and leaving it unsigned made
1441 overflow checking harder.
1442
1443 * dispextern.h (struct glyph_matrix.rows_allocated)
1444 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1445 with xpalloc. The values are still always <= INT_MAX.
1446
1447 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1448
1449 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1450 (SAFE_NALLOCA): New macro.
1451
1452 * region-cache.c (struct boundary.pos, find_cache_boundary)
1453 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1454 (set_cache_region, invalidate_region_cache)
1455 (revalidate_region_cache, know_region_cache, region_cache_forward)
1456 (region_cache_backward, pp_cache):
1457 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1458 so that ptrdiff_t * can be passed to xpalloc.
1459 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1460 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1461 (pp_cache): Don't assume cache_len fits in int.
1462 * region-cache.h: Adjust extern decls to match.
1463
1464 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1465 EMACS_INT, since either will do, for xpalloc.
1466
1467 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1468 (xnmalloc, xnrealloc, xpalloc): New functions.
1469
726e0ab1
PE
1470 * bidi.c (bidi_shelve_header_size): New constant.
1471 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1472 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1473
51f30bc5 1474 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1475 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1476 (overlay_strings):
1477 Don't update size of array until after memory allocation succeeds,
1478 because xmalloc/xrealloc may not return.
0065d054
PE
1479 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1480 now that we have proper integer overflow checking.
1481 (record_overlay_string, overlay_strings): Catch overflows when
1482 calculating size of overlay_str_buf.
726e0ab1 1483
0065d054
PE
1484 * callproc.c (Fcall_process): Check for size overflow when
1485 calculating size of args2.
1486 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1487 Normally we prefer signed values, but sticking with ptrdiff_t would
1488 require adding more-complicated checks.
726e0ab1
PE
1489
1490 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1491 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1492 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1493 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1494
1495 * character.c (Fstring): Check for size-calculation overflow.
1496
1497 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1498 unnecessary integer overflow. Check for size overflow.
1499 (encode_coding_object): Don't update size until xmalloc succeeds.
1500
1501 * composite.c (get_composition_id): Check for overflow in glyph
1502 length calculations.
1503
1504 Integer and memory overflow fixes for display code.
1505 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1506 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1507 (scrolling_window): Check for overflow in size calculations.
1508 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1509 Don't assume glyph table len fits in int.
1510 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1511 (row_table_size): Now ptrdiff_t, not int.
1512 (scrolling_window): Avoid overflow in size calculations.
1513 Don't update size until allocation succeeds.
1514 * fns.c (concat): Check for overflow in size calculations.
1515 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1516 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1517 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1518
1519 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1520 (get_doc_string): Check for size calculation overflow.
1521 Don't update size until allocation succeeds.
1522 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1523 EMACS_INT, where ptrdiff_t will do.
1524 (Fsubstitute_command_keys): Check for string overflow.
1525
1526 * editfns.c (set_time_zone_rule): Don't assume environment length
1527 fits in int.
1528 (message_length): Now ptrdiff_t, not int.
1529 (Fmessage_box): Don't update size until allocation succeeds.
1530 Don't assume message length fits in int.
1531 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1532
0065d054
PE
1533 * emacs.c (main): Do not reallocate argv, since there is a null at
1534 the end that can be overwritten, and this way there's no need to
1535 worry about size-calculation overflow.
1536 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1537
1538 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1539 alloc succeeds.
1540 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1541
1542 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1543 (x_set_scroll_bar_width, x_figure_window_size):
1544 Check for integer overflow.
1545 (x_set_alpha): Do not assume XINT fits in int.
1546
1547 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1548 This is for the members text_lines, text_cols, total_lines, total_cols,
1549 where the system imposes an 'int' limit.
1550
1551 * fringe.c (Fdefine_fringe_bitmap):
1552 Don't update size until alloc works.
1553
1554 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1555 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1556
1557 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1558 Check for size-calculation overflow.
1559 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1560 do, as we prefer signed integers.
1561 (id_to_widget.max_size, id_to_widget.used)
1562 (xg_store_widget_in_map, xg_remove_widget_from_map)
1563 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1564 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1565 Use and return ptrdiff_t, not int.
1566 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1567 * gtkutil.h: Change prototypes to match the above.
1568
1569 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1570 are duplicate now that they've been promoted to lisp.h.
1571 (x_allocate_bitmap_record, x_alloc_image_color)
1572 (make_image_cache, cache_image, xpm_load):
1573 Don't update size until alloc is done.
1574 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1575 (x_detect_edges):
3256efce 1576 Check for size calculation overflow.
726e0ab1
PE
1577 (ct_colors_allocated_max): New constant.
1578 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1579 overflow.
3256efce 1580
726e0ab1
PE
1581 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1582 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1583 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1584 Use ptrdiff_t, not int, to count maps.
1585 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1586 calculations. Don't update size until allocation succeeds.
1587 Redo calculations to avoid overflow.
726e0ab1
PE
1588 * keyboard.h: Change prototypes to match the above.
1589
1590 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1591 to count maps.
1592 (current_minor_maps): Check for size calculation overflow.
1593 * keymap.h: Change prototypes to match the above.
1594
1595 * lread.c (read1, init_obarray): Don't update size until alloc done.
1596
1597 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1598 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1599
726e0ab1
PE
1600 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1601 Now ptrdiff_t, not int.
1602 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1603 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1604
1605 * process.c (Fnetwork_interface_list): Check for overflow
1606 in size calculation.
1607
1608 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1609
1610 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1611 overflow. Don't bother calling xmalloc when xrealloc will do.
1612
1613 * search.c (Freplace_match): Check for size calculation overflow.
1614 (Fset_match_data): Don't assume list lengths fit in 'int'.
1615
1616 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1617 for command line length. Do not attempt to address one before the
1618 beginning of an array, as that's not portable.
1619
1620 * term.c (max_frame_lines): Remove; unused.
1621 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1622 not int.
1623 (encode_terminal_code, calculate_costs): Check for size
1624 calculation overflow.
1625 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1626 table lengths and related sizes. Don't update size until alloc
1627 done. Redo calculations to avoid overflow.
1628 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1629
1630 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1631 subtracting pointers.
1632 (gobble_line): Check for overflow more carefully. Don't update size
1633 until alloc done.
1634
1635 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1636 Don't update size until alloc done.
1637 Redo size calculations to avoid overflow.
1638 Check for size calculation overflow.
0065d054 1639 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1640
1641 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1642 Use ptrdiff_t, not int, for sizes.
1643 (store_mode_line_noprop_char): Don't update size until alloc done.
1644
0065d054
PE
1645 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1646 Use ptrdiff_t, not int, for sizes.
1647 (Finternal_make_lisp_face, cache_face):
1648 Check for size calculation overflow.
1649 (cache_face): Treat size calculation overflows as if they were
1650 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1651
1652 * xfns.c (x_encode_text, x_set_name_internal)
1653 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1654 sizes, since they can exceed INT_MAX in size. Check for size
1655 calculation overflow.
1656
0065d054
PE
1657 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1658 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1659 Don't update size until alloc done.
1660
0065d054 1661 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1662 as sprintf is limited to int lengths.
1d526e2f 1663
252c5ee1
PE
1664 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1665 (X_LONG_MIN): New macros.
864d7ce7
PE
1666 Use them to make the following changes clearer.
1667 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1668 This change doesn't affect the value now, but it may help remind
1669 future maintainers not to raise the value too much later.
1670 (SELECTION_QUANTUM): Remove, replacing with ...
1671 (selection_quantum): ... new function, which avoids overflow.
1672 All uses changed.
1673 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1674 assumption that selection length fits in 'int'.
1675 (x_reply_selection_request, x_handle_selection_request)
1676 (x_get_window_property, receive_incremental_selection)
1677 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1678 (lisp_data_to_selection_data, clean_local_selection_data):
1679 Use ptrdiff_t, not int, to record length of selection.
1680 (x_reply_selection_request, x_get_window_property)
1681 (receive_incremental_selection, x_property_data_to_lisp):
1682 Redo calculations to avoid overflow.
1683 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1684 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1685 something.
1686 (x_get_window_property, receive_incremental_selection)
1687 (lisp_data_to_selection_data, x_property_data_to_lisp):
1688 Check for size-calculation overflow.
1689 (x_get_window_property, receive_incremental_selection)
1690 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1691 Don't store size until memory allocation succeeds.
1692 (x_get_window_property): Plug memory leak on memory exhaustion.
1693 Don't double-block input; malloc is safe here. Don't assume 2**34
1694 - 4 fits in unsigned long. Add an xassert to check
1695 XGetWindowProperty overflow. Be more careful about overflow
1696 calculations, and distinguish size from memory overflow better.
1697 (receive_incremental_selection): When tracing, don't assume
1698 unsigned int is less than INT_MAX.
1699 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1700 harmful) conversions of unsigned short to int.
1701 (lisp_data_to_selection_data): Don't assume that integers
1702 in the range -65535 through -1 fit in an X unsigned short.
1703 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1704 result parameters unless successful. Rely on cons_to_unsigned
1705 to report problems with elements; the old code wasn't right anyway.
1706 (x_check_property_data): Check for int overflow; we cannot use
1707 a wider type due to X limits.
1708 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1709
726e0ab1 1710 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1711
0065d054
PE
1712 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1713 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1714 (x_color_cells): Don't store size until memory allocation succeeds.
1715 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1716 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1717 (x_term_init): Don't assume length fits in int (sprintf is limited
1718 to int size).
bc18e09d 1719
ebfa62c0
PE
1720 Use ptrdiff_t for composition IDs.
1721 * character.c (lisp_string_width):
1722 * composite.c (composition_table_size, n_compositions)
1723 (get_composition_id, composition_gstring_from_id):
1724 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1725 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1726 * window.c (Frecenter):
1727 Use ptrdiff_t, not int, for composition IDs.
1728 * composite.c (get_composition_id): Check for integer overflow.
1729 * composite.h: Adjust prototypes to match the above changes.
1730
d3411f89
PE
1731 Use ptrdiff_t for hash table indexes.
1732 * category.c (hash_get_category_set):
1733 * ccl.c (ccl_driver):
1734 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1735 * coding.c (coding_system_charset_list, detect_coding_system):
1736 * coding.h (struct coding_system.id):
1737 * composite.c (get_composition_id, gstring_lookup_cache):
1738 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1739 * image.c (xpm_get_color_table_h):
1740 * lisp.h (hash_lookup, hash_put):
1741 * minibuf.c (Ftest_completion):
1742 Use ptrdiff_t for hash table indexes, not int (which is too
1743 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1744 32-bit --with-wide-int hosts).
1745
e097a6fa
PE
1746 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1747 Add a FIXME comment about memory leaks.
1748 (syms_of_charset): Don't assume xmalloc returns.
1749
5637687f
PE
1750 Don't assume that stated character widths fit in int.
1751 * character.c (Fchar_width, c_string_width, lisp_string_width):
1752 * character.h (CHAR_WIDTH):
1753 * indent.c (MULTIBYTE_BYTES_WIDTH):
1754 Use sanitize_char_width to avoid undefined and/or bad behavior
1755 with outlandish widths.
a66cfb1c 1756 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1757 now that we have two such functions. All uses changed.
1758 (sanitize_char_width): New inline function.
1759
a2271ba2
PE
1760 Don't assume that tab-width fits in int.
1761 * character.h (sanitize_width): New inline function.
1762 (SANE_TAB_WIDTH): New macro.
1763 (ASCII_CHAR_WIDTH): Use it.
1764 * indent.c (sane_tab_width): Remove. All uses replaced by
1765 SANE_TAB_WIDTH (current_buffer).
1766 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1767
18c52557
PE
1768 * fileio.c: Integer overflow issues with file modes.
1769 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1770
caeeedc1
PE
1771 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1772 Remove unreachable code.
1773 (read_hex, load_charset_map_from_file): Check for integer overflow.
1774
50849c52
PE
1775 * xterm.c: don't go over XClientMessageEvent limit
1776 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1777 (x_send_scroll_bar_event): Likewise. Check that the size does not
1778 exceed limits imposed by XClientMessageEvent, as well as the usual
1779 ptrdiff_t and size_t limits.
1780
b13995db
PE
1781 * keyboard.c: Overflow, signedness and related fixes.
1782 (make_lispy_movement): Use same integer type in forward decl
1783 that is used in the definition.
1784 (read_key_sequence, keyremap_step):
1785 Change bufsize argument back to int, undoing my 2011-03-30 change.
1786 We prefer signed types, and int is wide enough here.
1787 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1788 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1789 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1790 length, not size_t. Use ptrdiff_t for index, not int.
1791 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1792 possibility of integer overflow.
1793
13464394
PE
1794 Overflow, signedness and related fixes for images.
1795
1796 * dispextern.h (struct it.stack[0].u.image.image_id)
1797 (struct_it.image_id, struct image.id, struct image_cache.size)
1798 (struct image_cache.used, struct image_cache.ref_count):
1799 * gtkutil.c (update_frame_tool_bar):
1800 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1801 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1802 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1803 * nsmenu.m (update_frame_tool_bar):
1804 * xdisp.c (calc_pixel_width_or_height):
1805 * xfns.c (image_cache_refcount):
1806 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1807 on typical 64-bit hosts.
1808
1809 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1810 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1811 Omit unnecessary casts to int.
1812 (parse_image_spec): Check that integers fall into 'int' range
1813 when the callers expect that.
1814 (image_ascent): Redo ascent calculation to avoid int overflow.
1815 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1816 (lookup_image): Remove unnecessary tests.
1817 (xbm_image_p): Locals are now of int, not EMACS_INT,
1818 since parse_image_check makes sure they fit into int.
1819 (png_load, gif_load, svg_load_image):
1820 Prefer int to unsigned where either will do.
1821 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1822 old tiff_error_handler and tiff_warning_handler.
1823 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1824 stack buffer overflows. It uses only the features of vsnprintf
1825 that are common to both POSIX and native Microsoft.
1826 (tiff_error_handler, tiff_warning_handler): Use it.
1827 (tiff_load, gif_load, imagemagick_load_image):
1828 Don't assume :index value fits in 'int'.
1829 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1830 (imagemagick_load_image): Check that crop parameters fit into
1831 the integer types that MagickCropImage accepts. Don't assume
1832 Vimagemagick_render_type has a nonnegative value. Don't assume
1833 size_t fits in 'long'.
1834 (gs_load): Use printmax_t to print the widest integers possible.
1835 Check for integer overflow when computing image height and width.
1836
c11821d4
EZ
18372011-08-26 Eli Zaretskii <eliz@gnu.org>
1838
1839 * xdisp.c (redisplay_window): Don't force window start if point
1840 will be invisible in the resulting window. (Bug#9324)
1841
0c95fcf7
EZ
18422011-08-25 Eli Zaretskii <eliz@gnu.org>
1843
1844 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1845 the display spec is of the form `(space ...)'.
1846 (handle_display_spec): Return the value returned by
1847 handle_single_display_spec, not just 1 or zero.
1848 (handle_single_display_spec): If the display spec is of the form
1849 `(space ...)', and specifies display in the text area, return 2
1850 rather than 1.
fee65a97 1851 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1852 accurately, and prefer exact match for point under bidi.
1853 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1854
1855 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1856 into disp_prop; all users changed.
1857
1858 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1859 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1860 for the text covered by the display property.
1861
e4ed06f1
CY
18622011-08-25 Chong Yidong <cyd@stupidchicken.com>
1863
1864 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1865 Change return value to nil.
1866 (Frecord_buffer): Delete unused function.
1867
f67cdd7f
EZ
18682011-08-24 Eli Zaretskii <eliz@gnu.org>
1869
5980d4c6
EZ
1870 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1871 buffers, return left-to-right.
8610fe8b
EZ
1872 (set_cursor_from_row): Consider candidate row a win if its glyph
1873 represents a newline and point is on that newline. Fixes cursor
1874 positioning on the newline at EOL of R2L text within L2R
1875 paragraph, and vice versa.
1876 (try_cursor_movement): Check continued rows, in addition to
1877 continuation rows. Fixes unwarranted scroll when point enters a
1878 continued line of R2L text within an L2R paragraph, or vice versa.
1879 (cursor_row_p): Consider the case of point being equal to
1880 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1881 from the end of a short line to the beginning of a continued line
1882 of R2L text within L2R paragraph.
1883 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1884 composed characters.
5980d4c6 1885
f67cdd7f
EZ
1886 * bidi.c (bidi_check_type): Use xassert.
1887 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1888 members.
1889
bca633fb
EZ
18902011-08-23 Eli Zaretskii <eliz@gnu.org>
1891
1892 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1893 a character.
1894
4a5885a7
CY
18952011-08-23 Chong Yidong <cyd@stupidchicken.com>
1896
1897 * nsfont.m (ns_otf_to_script): Fix typo.
1898
0902a04e
KH
18992011-08-22 Kenichi Handa <handa@m17n.org>
1900
1901 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1902 extra slot even if the purpose is char-code-property-table.
1903
1a2e6670
EZ
19042011-08-23 Eli Zaretskii <eliz@gnu.org>
1905
8ddde651
EZ
1906 * xdisp.c (redisplay_window): When computing centering_position,
1907 account for the height of the header line. (Bug#8874)
1908
425cc014
EZ
1909 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1910 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1911 candidate is selected by the mouse, and that candidate has a
1912 composed character under the mouse.
1913
1a2e6670
EZ
1914 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1915 coordinates reported by pos-visible-in-window-p for a composed
1916 character in column zero.
1917
8b76d6f8
SM
19182011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1919
1920 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1921
dac347dd
EZ
19222011-08-22 Eli Zaretskii <eliz@gnu.org>
1923
1924 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1925 consider it a hit if to_charpos is anywhere in the range of the
1926 composed buffer positions.
1927
e013fb34
CY
19282011-08-22 Chong Yidong <cyd@stupidchicken.com>
1929
1930 * image.c (gif_load): Don't assume that each subimage has the same
1931 dimensions as the base image. Handle disposal method that is
1932 "undefined" by the gif spec (Bug#9335).
1933
bd1ba3e8
CY
19342011-08-20 Chong Yidong <cyd@stupidchicken.com>
1935
1936 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1937 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1938
54a1215b
EZ
19392011-08-19 Eli Zaretskii <eliz@gnu.org>
1940
823564e5
EZ
1941 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1942 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1943 from an Org mode buffer to a Speedbar frame.
1944
54a1215b
EZ
1945 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1946 a composition, take its buffer position from IT->cmp_it.charpos.
1947 Fixes cursor positioning at the beginning of a line that begins
1948 with a composed character.
1949
9778ebcc
EZ
19502011-08-18 Eli Zaretskii <eliz@gnu.org>
1951
0be6ee06
EZ
1952 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1953 character bidirectional type, use STRONG_L instead. Fixes crashes
1954 in a buffer produced by `describe-categories'.
1955
9778ebcc
EZ
1956 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1957 members before the level stack, so they would be saved and
1958 restored when copying iterator state. Fixes incorrect reordering
1959 around TABs covered by display properties.
1960
156bffbe
AS
19612011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1962
6b02f655 1963 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1964
72ad093b
CY
19652011-08-17 Chong Yidong <cyd@stupidchicken.com>
1966
1967 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1968 (internal_condition_case_2, internal_condition_case_n):
1969 Remove unnecessary aborts (Bug#9081).
72ad093b 1970
35774242
EZ
19712011-08-17 Eli Zaretskii <eliz@gnu.org>
1972
1973 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1974 has no `load' handler, try opening the file locally. (Bug#9311)
1975
db76dd85
KB
19762011-08-16 Ken Brown <kbrown@cornell.edu>
1977
1978 * gmalloc.c: Expand comment.
1979
b215eee5
EZ
19802011-08-16 Eli Zaretskii <eliz@gnu.org>
1981
1982 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1983 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1984
a4579d33
KB
19852011-08-16 Ken Brown <kbrown@cornell.edu>
1986
1987 Fix memory allocation problems in Cygwin build (Bug#9273).
1988
1989 * unexcw.c ( __malloc_initialized): Declare external variable.
1990 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1991
8b76d6f8
SM
1992 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1993 New variables.
a4579d33
KB
1994 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1995 dumped emacs.
1996 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1997 in the static heap.
1998 [CYGWIN] (special_realloc): New function.
1999 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2000 requests to realloc storage in the static heap.
2001
3ebec551
PE
20022011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2003
2004 * bidi.c (bidi_initialize): Remove unused local.
2005
9fd8be00
EZ
20062011-08-15 Eli Zaretskii <eliz@gnu.org>
2007
6b02f655
SM
2008 * bidimirror.h:
2009 * biditype.h: Remove file.
2010 * makefile.w32-in ($(BLD)/bidi.$(O)):
2011 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2012
2013 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2014
2015 * chartab.c: Improve commentary for the uniprop_table API.
2016
32413314
EZ
2017 * bidi.c (bidi_paragraph_init): Support zero value of
2018 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2019 (bidi_initialize): Use uniprop_table instead of including
2020 biditype.h and bidimirror.h.
32413314 2021
9fd8be00
EZ
2022 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2023 coordinates of the iterator when restoring from ppos_it.
2024 (Bug#9296)
2025
5cf2b69b
KH
20262011-08-14 Kenichi Handa <handa@m17n.org>
2027
2028 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2029 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2030
daf17d00
EZ
20312011-08-14 Eli Zaretskii <eliz@gnu.org>
2032
2033 * xdisp.c (move_it_in_display_line_to): Don't invoke
2034 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2035 ppos_it. Fixes vertical cursor motion when line beginning is
2036 covered by an image. (Bug#9296)
2037
08e3161a
JD
20382011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2039
2040 * nsterm.h (ns_run_ascript): Declare.
2041 (NSAPP_DATA2_RUNASSCRIPT): Define.
2042
2043 * nsfns.m (as_script, as_result, as_status): New static variables.
2044 (ns_run_ascript): New function.
5e617bc2 2045 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2046 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2047 the event loop. Get status from as_status (Bug#7276).
2048
2049 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2050 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2051 the event loop (Bug#7276).
2052
a3720aa2
AS
20532011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2054
2055 * gnutls.c (QCgnutls_bootprop_priority)
2056 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2057 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2058 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2059 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2060 (QCgnutls_bootprop_verify_hostname_error)
2061 (QCgnutls_bootprop_callbacks_verify): Rename from
2062 Qgnutls_bootprop_..., all uses changed.
2063
2064 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2065 uses changed.
2066
0a0d27fb
PE
20672011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2068
19d5c50c
PE
2069 * xfaces.c (Qframe_set_background_mode): Now static.
2070 * dispextern.h (Qframe_set_background_mode): Remove decl.
2071
0a0d27fb
PE
2072 * process.c (Fnetwork_interface_info): Declare local only if needed.
2073
377538cb
JD
20742011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2075
2076 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2077 (Fnetwork_interface_list): Allocate in increments of bytes instead
2078 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2079 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2080 sockaddr.
2081 (struct ifflag_def): notrailers is smart on OSX.
2082 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2083 Get hardware address with getifaddrs if available.
2084
08fff70c
EZ
20852011-08-12 Eli Zaretskii <eliz@gnu.org>
2086
2087 * xdisp.c (iterate_out_of_display_property): xassert that
2088 IT->position is set to within IT->object's boundaries. Break from
2089 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2090 when IT->position is set up wrongly due to some bug.
2091 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2092 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2093 entry. Force push_it to save on the stack the current
2094 buffer/string position, to be restored by pop_it. Fix flags in
2095 the iterator structure wrt the object coming from a display
2096 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2097 properties. (Bug#9284)
2098
7be1c708 20992011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2100
7be1c708
CY
2101 * fontset.c (fontset_get_font_group): Add proper type checks.
2102 (Bug#9172)
aac0c6e3 2103
7be1c708 21042011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2105
7be1c708
CY
2106 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2107 and LC_VERSION_MIN_MACOSX.
2108 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2109 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2110
97bb72a6
EZ
21112011-08-08 Eli Zaretskii <eliz@gnu.org>
2112
2113 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2114 no-display-properties-and-no-overlays under bidi display.
2115 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2116 properties and overlays.
97bb72a6 2117
d5617611
CY
21182011-08-08 Chong Yidong <cyd@stupidchicken.com>
2119
37e11a63
CY
2120 * editfns.c (Fset_time_zone_rule): Document relationship with the
2121 setenv function.
2122
d5617611
CY
2123 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2124 the font entity extracted from the cache (Bug#8109).
2125
58872834
CY
21262011-08-07 Chong Yidong <cyd@stupidchicken.com>
2127
2128 * composite.c (autocmp_chars): Don't reset point. That is done by
2129 restore_point_unwind (Bug#5984).
2130
75bfc667
JL
21312011-08-07 Juri Linkov <juri@jurta.org>
2132
2133 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2134 to show the arg `TIME' instead of `TIMEVAL'.
2135
d1410150
EZ
21362011-08-06 Eli Zaretskii <eliz@gnu.org>
2137
2138 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2139 display property strides EOL and includes a newline, as in
2140 longlines-mode. (Bug#9254)
75b771e4
EZ
2141 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2142 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2143
2144 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2145 is non-zero, even if the data buffer is NULL. Fixes a crash in
2146 vertical-motion with longlines-mode. (Bug#9254)
2147
35928349
EZ
21482011-08-05 Eli Zaretskii <eliz@gnu.org>
2149
ec7cc85b
EZ
2150 * bidi.c <bidi_cache_total_alloc>: Now static.
2151 (bidi_initialize): Initialize bidi_cache_total_alloc.
2152
8b76d6f8 2153 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2154 cache. (Bug#9221)
2155
2156 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2157 amount allocated this far in `bidi_cache_total_alloc'.
2158 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2159 non-zero, only free the data buffer without restoring the cache
2160 contents. All callers changed.
2161
2162 * dispextern.h (bidi_unshelve_cache): Update prototype.
2163
2164 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2165 (move_it_in_display_line, move_it_to)
2166 (move_it_vertically_backward, move_it_by_lines): Replace the call
2167 to xfree to an equivalent call to bidi_unshelve_cache.
2168 (move_it_in_display_line_to): Fix logic of returning
412b6358 2169 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2170
e2e2423b
EZ
21712011-08-05 Eli Zaretskii <eliz@gnu.org>
2172
2173 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2174 came from a string character with a `cursor' property. (Bug#9229)
2175
ae9e757a
JD
21762011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2177
2178 * Makefile.in (LIB_PTHREAD): New variable.
2179 (LIBES): Add LIB_PTHREAD (Bug#9216).
2180
2181 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2182 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2183
213bd7f2
AS
21842011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2185
6b02f655 2186 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2187
99aaf75f
JD
21882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2189
2190 * xterm.c (x_find_topmost_parent): New function.
2191 (x_set_frame_alpha): Find topmost parent window with
2192 x_find_topmost_parent and set the property there also (bug#9181).
2193 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2194
c74e9d86
PE
21952011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2196
2197 * callproc.c (Fcall_process): Avoid vfork clobbering
2198 the local vars buffer, coding_systems, current_dir.
2199
640c8776
SM
22002011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2201
2202 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2203
f26d0e4c
PE
22042011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2205
8a10d76c
PE
2206 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2207 so that it is not optimized away.
2208
f26d0e4c
PE
2209 * xdisp.c (compute_display_string_pos): Remove unused local.
2210
55439c61
EZ
22112011-08-02 Eli Zaretskii <eliz@gnu.org>
2212
2213 Fix slow cursor motion and scrolling in large buffers with
2214 selective display, like Org Mode buffers. (Bug#9218)
2215
2216 * dispextern.h (struct bidi_it): New member disp_prop_p.
2217
2218 * xdisp.c: Remove one-slot cache of display string positions.
2219 (compute_display_string_pos): Accept an additional argument
5e617bc2 2220 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2221 for a display string or property. If found, set DISP_PROP_P
2222 non-zero.
2223
2224 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2225 DISP_PROP_P, and pass it to compute_display_string_pos.
2226 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2227 non-zero. All callers of bidi_fetch_char changed.
2228
fb33fa43
SM
22292011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2230
2231 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2232
b099e063
DM
22332010-12-03 Don March <don@ohspite.net>
2234
2235 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2236 last character M-[char] is translated to ESC [char] (bug#7541).
2237
5cc7f7af
KH
22382011-08-02 Kenichi Handa <handa@m17n.org>
2239
d0fffa3f 2240 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2241
2242 * chartab.c (uniprop_table): Make it non-static.
2243
525d5e6e
EZ
22442011-08-01 Eli Zaretskii <eliz@gnu.org>
2245
2246 * xdisp.c (forward_to_next_line_start): Accept additional argument
2247 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2248 on the newline.
2249 (reseat_at_next_visible_line_start): Use the bidi iterator state
2250 returned by forward_to_next_line_start to restore the state of
2251 it->bidi_it after backing up to previous newline. (Bug#9212)
2252
31011111
AS
22532011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2254
2255 * regex.c (re_comp): Protoize.
2256 (re_exec): Fix return type.
2257 (regexec): Fix type of `ret'. (Bug#9203)
2258
476371c4
PE
22592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2260
e5d76069
PE
2261 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2262 This is needed if max-image-size is a floating-point number.
2263
9a79b20c
AS
22642011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2265
2266 * print.c (print_object): Print empty symbol as ##.
2267
2268 * lread.c (read1): Read ## as empty symbol.
2269
d8c2fa78
AA
22702011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2271
2272 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2273 setting frame foreground color (Bug#9175).
2274 (x_set_background_color): Likewise.
2275
ffe57a7a
AA
2276 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2277 contents (Bug#9176).
2278 (EmacsTooltip -init): Remove bezels and add shadows to
2279 tooltip windows.
2280
bf3492a5
AA
2281 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2282 or scroll bar (Bug#8470).
2283
d55e9c53
AA
2284 * nsfont.m (nsfont_open): Remove assignment to voffset and
2285 unnecessary vars hshink, expand, hd, full_height, min_height.
2286 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2287
2288 * nsterm.h (nsfont_info): Remove voffset field.
2289
d8c2fa78 22902011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2291
2292 Implement strike-through and overline on NextStep (Bug#8863).
2293
2294 * nsfont.m (nsfont_open): Use underline position provided by font,
2295 instead of hard-coded value of 2.
2296 (nsfont_draw): Call ns_draw_text_decoration instead.
2297
2298 * nsterm.h: Add declaration for ns_draw_text_decoration.
2299
2300 * nsterm.m (ns_draw_text_decoration): New function for drawing
2301 underline, overline, and strike-through.
2302 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2303 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2304 accommodate underlining, etc.
4843aac3 2305
4cc60b9b
EZ
23062011-07-28 Eli Zaretskii <eliz@gnu.org>
2307
bc7ece87
EZ
2308 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2309 default.
4cc60b9b 2310
476371c4
PE
23112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2312
66606eea
PE
2313 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2314 Without this fix, if a signal arrives just after memory fills up,
2315 'malloc' might be invoked reentrantly.
2316
476371c4
PE
2317 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2318 In other words, assume that every image size is allowed, on non-X
2319 hosts. This assumption is probably wrong, but it lets Emacs compile.
2320
f3fcc40d
AS
23212011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2322
2323 * regex.c (re_iswctype): Convert return values to boolean.
2324
350c992f
EZ
23252011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2326
2327 * xdisp.c (compute_display_string_pos): Don't use cached display
2328 string position if the buffer had its restriction changed.
2329 (Bug#9184)
2330
5266b4bb
PE
23312011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2332
2333 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2334
2573a837 23352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2336
41f55ccd 2337 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2338
39e378da
PE
2339 * bidi.c: Integer size and overflow fixes.
2340 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2341 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2342 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2343 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2344 (bidi_find_other_level_edge):
2345 Use ptrdiff_t instead of EMACS_INT where either will do.
2346 This works better on 32-bit hosts configured --with-wide-int.
2347 (bidi_cache_ensure_space): Check for size-calculation overflow.
2348 Use % rather than repeated addition, for better worst-case speed.
2349 Don't set bidi_cache_size until after xrealloc returns, because it
2350 might not return.
2351 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2352 (bidi_cache_ensure_space): Also check that the bidi cache size
2353 does not exceed that of the largest Lisp string or buffer. See Eli
2354 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2355
5e927815
PE
2356 * alloc.c (__malloc_size_t): Remove.
2357 All uses replaced by size_t. See Andreas Schwab's note
2358 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2359
ca4aa935
PE
2360 * image.c: Improve checking for integer overflow.
2361 (check_image_size): Assume that f is nonnull, since
2362 it is always nonnull in practice. This is one less thing to
2363 worry about when checking for integer overflow later.
2364 (x_check_image_size): New function, which checks for integer
2365 overflow issues inside X.
2366 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2367 This removes the need for a memory_full check.
2368 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2369 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2370 (xbm_read_bitmap_data): Change locals back to 'int', since
2371 their values must fit in 'int'.
2372 (xpm_load_image, png_load, tiff_load):
2373 Invoke x_create_x_image_and_pixmap earlier,
2374 to avoid much needless work if the image is too large.
2375 (tiff_load): Treat overly large images as if
2376 x_create_x_image_and_pixmap failed, not as malloc failures.
2377 (gs_load): Use x_check_image_size.
2378
5f8f9cc2
PE
2379 * gtkutil.c: Omit integer casts.
2380 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2381 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2382
5adf60bc
PE
2383 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2384
c8907a93
PE
2385 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2386 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2387 would wrongly return t on a 64-bit host.
2388
e3c25c68
PE
2389 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2390 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2391 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2392 and therefore cause GCC to emit a bogus diagnostic in some cases.
2393
3f791afe
PE
2394 * image.c: Integer signedness and overflow and related fixes.
2395 This is not an exhaustive set of fixes, but it's time to
2396 record what I've got.
2397 (lookup_pixel_color, check_image_size): Remove redundant decls.
2398 (check_image_size): Don't assume that arbitrary EMACS_INT values
2399 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2400 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2401 (tiff_load, imagemagick_load_image):
2402 Check for overflow in size calculations.
2403 (x_create_x_image_and_pixmap): Remove unnecessary test for
2404 xmalloc returning NULL; that can't happen.
2405 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2406 (xpm_color_bucket): Use better integer hashing function.
2407 (xpm_cache_color): Don't possibly over-allocate memory.
2408 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2409 (gif_memory_source):
2410 Use ptrdiff_t, not int or size_t, to record sizes.
2411 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2412 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2413 either works, as we prefer signed integers.
2414 (tiff_read_from_memory, tiff_write_from_memory):
2415 Return tsize_t, not size_t, since that's what the TIFF API wants.
2416 (tiff_read_from_memory): Don't fail simply because the read would
2417 go past EOF; instead, return a short read.
2418 (tiff_load): Omit no-longer-needed casts.
2419 (Fimagemagick_types): Don't assume size fits into 'int'.
2420
3cc5a532
PE
2421 Improve hashing quality when configured --with-wide-int.
2422 * fns.c (hash_string): New function, taken from sxhash_string.
2423 Do not discard information about ASCII character case; this
2424 discarding is no longer needed.
2425 (sxhash-string): Use it. Change sig to match it. Caller changed.
2426 * lisp.h: Declare it.
2427 * lread.c (hash_string): Remove, since we now use fns.c's version.
2428 The fns.c version returns a wider integer if --with-wide-int is
2429 specified, so this should help the quality of the hashing a bit.
2430
b312a492
PE
2431 * emacs.c: Integer overflow minor fix.
2432 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2433 Define only if GNU_LINUX.
2434 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2435
dfd153ae
PE
2436 * dispnew.c: Integer signedness and overflow fixes.
2437 Remove unnecessary forward decls, that were a maintenance hassle.
2438 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2439 All uses changed.
2440 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2441 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2442 (prepare_desired_row, line_draw_cost):
2443 Use int, not unsigned, where either works.
2444 (save_current_matrix, restore_current_matrix):
2445 Use ptrdiff_t, not size_t, where either works.
2446 (init_display): Check for overflow more accurately, and without
2447 relying on undefined behavior.
2448
a81d11a3
PE
2449 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2450 Remove, replacing with the new symbols in lisp.h. All uses changed.
2451 * fileio.c (make_temp_name):
2452 * filelock.c (lock_file_1, lock_file):
2453 * xdisp.c (message_dolog):
2454 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2455 Use pMd etc. instead.
2456 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2457 replacing the pWIDE etc. symbols removed from editfns.c.
2458
3300e6fd
PE
2459 * keyboard.h (num_input_events): Now uintmax_t.
2460 This is (very slightly) less likely to mess up due to wraparound.
2461 All uses changed.
2462
fd05c7e9
PE
2463 * buffer.c: Integer signedness fixes.
2464 (alloc_buffer_text, enlarge_buffer_text):
2465 Use ptrdiff_t rather than size_t when either will do, as we prefer
2466 signed integers.
2467
903fe15d
PE
2468 * alloc.c: Integer signedness and overflow fixes.
2469 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2470 (__malloc_size_t): Default to size_t, not to int.
2471 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2472 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2473 Prefer ptrdiff_t to size_t when either would do, as we prefer
2474 signed integers.
2475 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2476 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2477 Now const. Initialize with values that are in range even if char
2478 is signed.
2479 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2480 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2481 These functions do the right thing with sizes > 2**32.
2482 (check_depth): Now ptrdiff_t, not int.
2483 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2484 Adjust to new way of storing sizes. Check for size overflow bugs
2485 in rest of code.
2486 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2487 slightly wrong anyway, as it missed one instance of
2488 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2489 (refill_memory_reserve): Omit needless cast to size_t.
2490 (mark_object_loop_halt): Mark as externally visible.
2491
ac82cc6a
PE
2492 * xselect.c: Integer signedness and overflow fixes.
2493 (Fx_register_dnd_atom, x_handle_dnd_message):
2494 Use ptrdiff_t, not size_t, since we prefer signed.
2495 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2496 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2497 x_dnd_atoms_size and x_dnd_atoms_length.
2498
c2d1e36d
PE
2499 * doprnt.c: Prefer signed to unsigned when either works.
2500 * eval.c (verror):
2501 * doprnt.c (doprnt):
2502 * lisp.h (doprnt):
2503 * xdisp.c (vmessage):
2504 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2505 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2506 prefer signed arithmetic to avoid comparison confusion.
2507 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2508 but is a bit tricky.
2509
0e926e56
PE
2510 Assume freestanding C89 headers, string.h, stdlib.h.
2511 * data.c, doprnt.c, floatfns.c, print.c:
2512 Include float.h unconditionally.
2513 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2514 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2515 * regex.c: Likewise for stddef.h, string.h.
2516 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2517 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2518 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2519 (STDC_HEADERS): Remove obsolete defines.
2520 * sysdep.c: Include limits.h unconditionally.
2521
9cfdb3ec
PE
2522 Assume support for memcmp, memcpy, memmove, memset.
2523 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2524 * regex.c (memcmp, memcpy):
2525 Remove; we assume C89 now.
2526
2527 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2528 (__malloc_safe_bcopy): Remove; no longer needed.
2529
cf950e6b 2530 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2531 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2532 well either way, and we prefer signed to unsigned.
2533
dbf38e02
LMI
25342011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2535
2536 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2537 closes the connection while we're reading (bug#9182).
2538
d6f0886c 25392011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2540
d6f0886c
JD
2541 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2542 are specified (Bug#9168).
24e0f6b1 2543
2eb1f9e6
PE
25442011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2545
2546 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2547 Found by GCC static checking and --with-wide-int on a 32-bit host.
2548
22381272 25492011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2550
2551 * xdisp.c (compute_display_string_pos): Fix logic of caching
2552 previous display string position. Initialize cached_prev_pos to
2553 -1. Fixes slow-down at the beginning of a buffer.
2554
f25e39b4
EZ
25552011-07-24 Eli Zaretskii <eliz@gnu.org>
2556
2557 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2558 for attrs[LFACE_FONTSET_INDEX].
2559
04c4b52e
PE
25602011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2561
2562 * xml.c (parse_region): Remove unused local
2563 that was recently introduced.
2564
c1734fbd
EZ
25652011-07-23 Eli Zaretskii <eliz@gnu.org>
2566
be18c5a5
EZ
2567 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2568 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2569
c1734fbd
EZ
2570 * xdisp.c (move_it_in_display_line_to): Record the best matching
2571 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2572 exit if none of the characters scanned was an exact match.
2573 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2574 when exact match is impossible due to invisible text, and the
2575 lines are truncated.
2576
a258d627
JD
25772011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2578
2579 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2580 for OSX >= 10.7.
2581
b6d5a689
EZ
25822011-07-22 Eli Zaretskii <eliz@gnu.org>
2583
0f74f785
EZ
2584 Fix a significant slow-down of cursor motion with C-n, C-p,
2585 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2586 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2587 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2588 (next_element_from_buffer): Call compute_stop_pos_backwards to
2589 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2590 base_level_stop.
2591 (reseat): Don't look for prev_stop, as that could mean a very long
2592 run.
2593 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2594 <cached_disp_overlay_modiff>: Cache for last found display string
2595 position.
551918c1 2596 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2597 about the same buffer in the same area of character positions, and
2598 the buffer wasn't changed since the time the display string
2599 position was cached.
551918c1 2600
b2d0c91a
EZ
26012011-07-22 Eli Zaretskii <eliz@gnu.org>
2602
2603 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2604 is an integer, which is important for empty lines. (Bug#9149)
2605
043604ee
CY
26062011-07-22 Chong Yidong <cyd@stupidchicken.com>
2607
2608 * frame.c (Fmodify_frame_parameters): In tty case, update the
2609 default face if necessary (Bug#4238).
2610
da4adb04
CY
26112011-07-21 Chong Yidong <cyd@stupidchicken.com>
2612
2613 * editfns.c (Fstring_to_char): No need to explain what a character
2614 is in the docstring (Bug#6576).
2615
9abd0532
LMI
26162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2617
2618 * xml.c (parse_region): Make sure we always return a tree.
2619
36881d16
HK
26202011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2621
2622 * xml.c (parse_region): If a document contains only comments,
2623 return that, too.
2624
1e98674d
LMI
26252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2626
2627 * xml.c (make_dom): Return comments, too.
2628
590bd467
PE
26292011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2630
2631 Port to OpenBSD.
2632 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2633 and the surrounding thread.
2634 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2635 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2636 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2637 timer goes off.
2638 * s/openbsd.h (BROKEN_SIGIO): Define.
2639 * unexelf.c (unexec) [__OpenBSD__]:
2640 Don't update the .mdebug section of the Alpha COFF symbol table.
2641
f41628b2
LMI
26422011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2643
2644 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2645 (bug#8460).
2646
b59b67c5
PE
26472011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2648
15e3a074
PE
2649 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2650 This fixes some race conditions on the permissions of any newly
2651 created file.
2652
41bed37d
PE
2653 * alloc.c (valid_pointer_p): Use pipe, not open.
2654 This fixes some permissions issues when debugging.
2655
b59b67c5
PE
2656 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2657 If fchown fails to set both uid and gid, try to set just gid,
2658 as that is sometimes allowed. Adjust the file's mode to eliminate
2659 setuid or setgid bits that are inappropriate if fchown fails.
2660
925a6be7
SM
26612011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2662
2663 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2664 to compare Lisp_Objects.
2665 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2666 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2667 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2668
52968808
AS
26692011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2670
0a6a104b
AS
2671 * lread.c (read_integer): Unread even EOF character.
2672 (read1): Likewise. Properly record start position of symbol.
2673
52968808
AS
2674 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2675 symbol character follows.
2676
9e381cdd
PE
26772011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2678
2679 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2680 This works around a problem with the previous change to Fcopy_file.
2681 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2682 and without this change, GCC might complain about discarding
2683 fchown's return value.
2684
b5641435
JB
26852011-07-16 Juanma Barranquero <lekktu@gmail.com>
2686
2687 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2688
a8031457
PE
26892011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2690
2691 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2692
dd889327
LMI
26932011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2694
750c33f7
LMI
2695 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2696 it's used from the C level.
2697
dd889327
LMI
2698 * process.c: Use the same condition for POLL_FOR_INPUT in both
2699 keyboard.c and process.c (bug#1858).
2700
87e86684
LM
27012011-07-09 Lawrence Mitchell <wence@gmx.li>
2702
2703 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2704 (Fgnutls_boot): Use it.
2705
64348f40
AS
27062011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2707
2708 * doc.c (Fsubstitute_command_keys): Revert last change.
2709
1d698799
LMI
27102011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2711
f863868c
LMI
2712 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2713 quotes the next character, and doesn't affect other longer
2714 sequences (bug#8935).
2715
1d698799
LMI
2716 * lread.c (syms_of_lread): Clarify that is isn't only
2717 `eval-buffer' and `eval-defun' that's affected by
2718 `lexical-binding' (bug#8460).
2719
aa4b6df6
EZ
27202011-07-15 Eli Zaretskii <eliz@gnu.org>
2721
2722 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2723 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2724
5d856da6
PE
27252011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2726
ad6042bb
PE
2727 Fix minor problems found by static checking.
2728 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2729 (elsz): Now a signed constant, not a size_t var. We prefer signed
2730 types to unsigned, to avoid integer comparison confusion. Without
2731 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2732 "cannot optimize loop, the loop counter may overflow", a symptom
2733 of the confusion.
f00bbb22 2734 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2735 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2736
6468f31c
LMI
27372011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2738
49080b10
LMI
2739 * search.c (Fre_search_backward): Mention `case-fold-search' in
2740 all the re_search_* functions (bug#8138).
2741
6468f31c
LMI
2742 * keyboard.c (Fopen_dribble_file): Document when the file is
2743 closed (bug#8056).
2744
c965adc5
EZ
27452011-07-14 Eli Zaretskii <eliz@gnu.org>
2746
df9733bf
EZ
2747 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2748 bidi_cache_idx.
2749
0bb23927
EZ
2750 Support bidi reordering of display and overlay strings.
2751 * xdisp.c (compute_display_string_pos)
2752 (compute_display_string_end): Accept additional argument STRING.
2753 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2754 (reseat_to_string): Initialize bidi_it->string.s and
2755 bidi_it->string.schars.
2756 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2757 NULL (avoids a crash in bidi_paragraph_init).
2758 Initialize itb.string.lstring.
0bb23927
EZ
2759 (init_iterator): Call bidi_init_it only of a valid
2760 buffer position was specified. Initialize paragraph_embedding to
2761 L2R.
2762 (reseat_to_string): Initialize the bidi iterator.
2763 (display_string): If we need to ignore text properties of
2764 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2765 original value of -1 will not work with bidi.)
2766 (compute_display_string_pos): First arg is now struct
2767 `text_pos *'; all callers changed. Support display properties on
2768 Lisp strings.
2769 (compute_display_string_end): Support display properties on Lisp
2770 strings.
2771 (init_iterator, reseat_1, reseat_to_string): Initialize the
2772 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2773 when iterating on a string not from display properties).
640c8776
SM
2774 (compute_display_string_pos, compute_display_string_end):
2775 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2776 arrow keys.
2777 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2778 base_level_stop; instead, set base_level_stop to BEGV.
2779 Fixes crashes in vertical-motion.
0bb23927
EZ
2780 (next_element_from_buffer): Improve commentary for when
2781 the iterator is before prev_stop.
2782 (init_iterator): Initialize bidi_p from the default value of
2783 bidi-display-reordering, not from buffer-local value. Use the
2784 buffer-local value only if initializing for buffer iteration.
2785 (handle_invisible_prop): Support invisible properties on strings
2786 that are being bidi-reordered.
2787 (set_iterator_to_next): Support bidi reordering of C strings and
2788 Lisp strings.
2789 (next_element_from_string): Support bidi reordering of Lisp
2790 strings.
2791 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2792 (display_string): Support display of R2L glyph rows.
2793 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2794 (init_iterator): Don't initialize it->bidi_p for strings
2795 here.
2796 (reseat_to_string): Initialize it->bidi_p for strings here.
2797 (next_element_from_string, next_element_from_c_string)
2798 (next_element_from_buffer): Add xassert's for correspondence
2799 between IT's object being iterated and it->bidi_it.string
2800 structure.
2801 (face_before_or_after_it_pos): Support bidi iteration.
2802 (next_element_from_c_string): Handle the case of the first string
2803 character that is not the first one in the visual order.
2804 (get_visually_first_element): New function, refactored from common
2805 parts of next_element_from_buffer, next_element_from_string, and
2806 next_element_from_c_string.
2807 (tool_bar_lines_needed, redisplay_tool_bar)
2808 (display_menu_bar): Force left-to-right direction. Add a FIXME
2809 comment for making that be controlled by a user option.
2810 (push_it, pop_it): Save and restore the state of the
2811 bidi iterator. Save and restore the bidi_p flag.
2812 (pop_it): Iterate out of display property for string iteration as
2813 well.
2814 (iterate_out_of_display_property): Support iteration over strings.
2815 (handle_single_display_spec): Set up it->bidi_it for iteration
2816 over a display string, and call bidi_init_it.
2817 (handle_single_display_spec, next_overlay_string)
2818 (get_overlay_strings_1, push_display_prop): Set up the bidi
2819 iterator for displaying display or overlay strings.
2820 (forward_to_next_line_start): Don't use the shortcut if
2821 bidi-iterating.
2822 (back_to_previous_visible_line_start): If handle_display_prop
2823 pushed the iterator stack, restore the internal state of the bidi
2824 iterator by calling bidi_pop_it same number of times.
2825 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2826 and we are bidi-iterating, don't decrement the iterator position;
2827 instead, set the first_elt flag in the bidi iterator, to produce
2828 the same effect.
2829 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2830 (push_display_prop): xassert that we are iterating a buffer.
2831 (push_it, pop_it): Save and restore paragraph_embedding member.
2832 (handle_single_display_spec, next_overlay_string)
2833 (get_overlay_strings_1, reseat_1, reseat_to_string)
2834 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2835 correctly. Don't assume unibyte strings are not bidi-reordered.
2836 (compute_display_string_pos)
2837 (compute_display_string_end): Fix handling the case of C string.
2838 (push_it, pop_it): Save and restore from_disp_prop_p.
2839 (handle_single_display_spec, push_display_prop): Set the
2840 from_disp_prop_p flag.
2841 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2842 (pop_it): Call iterate_out_of_display_property only if we are
2843 popping after iteration over a string that came from a display
2844 property. Fix a typo in popping stretch info. Add an assertion
2845 for verifying that the iterator position is in sync with the bidi
2846 iterator.
2847 (handle_single_display_spec, get_overlay_strings_1)
2848 (push_display_prop): Fix initialization of paragraph direction for
2849 string when that of the parent object is not yet determined.
2850 (reseat_1): Call bidi_init_it to resync the bidi
2851 iterator with IT's position. (Bug#7616)
2852 (find_row_edges): If ROW->start.pos gives position
2853 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2854 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2855 Reset the from_disp_prop_p flag.
2856 (SAVE_IT, RESTORE_IT): New macros.
2857 (pos_visible_p, face_before_or_after_it_pos)
2858 (back_to_previous_visible_line_start)
2859 (move_it_in_display_line_to, move_it_in_display_line)
2860 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2861 (try_scrolling, redisplay_window, display_line): Use them when
2862 saving a temporary copy of the iterator and restoring it back.
2863 (back_to_previous_visible_line_start, reseat_1)
2864 (init_iterator): Empty the bidi cache "stack".
2865 (move_it_in_display_line_to): If iterator ended up at
2866 EOL, but we never saw any buffer positions smaller than
2867 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2868 motion in bidi-reordered lines.
2869 (move_it_in_display_line_to): Record prev_method and prev_pos
2870 immediately before the call to set_iterator_to_next. Fixes cursor
2871 motion in bidi-reordered lines with stretch glyphs and strings
2872 displayed in margins. (Bug#8133) (Bug#8867)
2873 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2874 TO_CHARPOS.
640c8776
SM
2875 (pos_visible_p): Support positions in bidi-reordered lines.
2876 Save and restore bidi cache.
0bb23927
EZ
2877
2878 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2879 (bidi_paragraph_info): Delete unused struct.
2880 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2881 (bidi_cache_start): New variable.
2882 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2883 to zero.
2884 (bidi_cache_fetch_state, bidi_cache_search)
2885 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2886 (bidi_cache_find, bidi_peek_at_next_level)
2887 (bidi_level_of_next_char, bidi_find_other_level_edge)
2888 (bidi_move_to_visually_next): Compare cache index with
2889 bidi_cache_start rather than with zero.
2890 (bidi_fetch_char): Accept new argument STRING; all callers
2891 changed. Support iteration over a string. Support strings with
2892 display properties. Support unibyte strings. Fix the type of
2893 `len' according to what STRING_CHAR_AND_LENGTH expects.
2894 (bidi_paragraph_init, bidi_resolve_explicit_1)
2895 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2896 (bidi_level_of_next_char, bidi_move_to_visually_next):
2897 Support iteration over a string.
0bb23927
EZ
2898 (bidi_set_sor_type, bidi_resolve_explicit_1)
2899 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2900 can now be zero (for strings); special values 0 and -1 were
2901 changed to -1 and -2, respectively.
2902 (bidi_char_at_pos): New function.
2903 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2904 Call it instead of FETCH_MULTIBYTE_CHAR.
2905 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2906 initialized to valid values.
2907 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2908 values.
2909 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2910 the test for valid cached positions. Fix the logic for looking up
2911 the sentinel state in the cache. GCPRO the Lisp string we are
2912 iterating.
2913 (bidi_push_it, bidi_pop_it): New functions.
2914 (bidi_initialize): Initialize the bidi cache start stack pointer.
2915 (bidi_cache_ensure_space): New function, refactored from part of
2916 bidi_cache_iterator_state. Don't assume the required size is just
2917 one BIDI_CACHE_CHUNK away.
2918 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2919 (bidi_count_bytes, bidi_char_at_pos): New functions.
2920 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2921 always valid if bidi_cache_idx is valid.
2922 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2923 is valid if it's going to be used.
2924 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2925 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2926 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2927 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2928 (bidi_find_other_level_edge, bidi_cache_start_stack):
2929 All variables related to cache indices are now EMACS_INT.
c965adc5 2930
0bb23927
EZ
2931 * dispextern.h (struct bidi_string_data): New structure.
2932 (struct bidi_it): New member `string'. Make flag members be 1-bit
2933 fields, and put them last in the struct.
640c8776
SM
2934 (compute_display_string_pos, compute_display_string_end):
2935 Update prototypes.
0bb23927
EZ
2936 (bidi_push_it, bidi_pop_it): Add prototypes.
2937 (struct iterator_stack_entry): New members bidi_p,
2938 paragraph_embedding, and from_disp_prop_p.
2939 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2940 (bidi_shelve_cache, bidi_unshelve_cache):
2941 Declare prototypes.
0bb23927
EZ
2942
2943 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2944 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2945 and vector-like objects.
2946
2947 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2948 cache around display iteration.
2949
2950 * window.c (Fwindow_end, window_scroll_pixel_based)
2951 (displayed_window_lines, Frecenter): Save and restore the bidi
2952 cache around display iteration.
2953
3bbd2265
LMI
29542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2955
2956 * editfns.c (Fdelete_region): Clarify the use of the named
2957 parameters (bug#6788).
2958
adc47434
MR
29592011-07-14 Martin Rudalics <rudalics@gmx.at>
2960
2961 * indent.c (Fvertical_motion): Set and restore w->pointm when
2962 saving and restoring the window's buffer (Bug#9006).
2963
837c31f8
LMI
29642011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2965
2966 * editfns.c (Fstring_to_char): Clarify just what is returned
2967 (bug#6576). Text by Eli Zaretskii.
2968
ac389d0c
JB
29692011-07-13 Juanma Barranquero <lekktu@gmail.com>
2970
2971 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2972
0be0ce47
EZ
29732011-07-13 Eli Zaretskii <eliz@gnu.org>
2974
2975 * buffer.c (mmap_find): Fix a typo.
2976
cd18e7e3
JB
29772011-07-13 Johan Bockgård <bojohan@gnu.org>
2978
2979 Fix execution of x selection hooks.
2980 * xselect.c (Qx_lost_selection_functions)
2981 (Qx_sent_selection_functions): New vars.
2982 (syms_of_xselect): DEFSYM them.
2983 (x_handle_selection_request): Pass Qx_sent_selection_functions
2984 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2985 (x_handle_selection_clear,x_clear_frame_selections):
2986 Pass Qx_lost_selection_functions rather than
2987 Vx_lost_selection_functions to Frun_hook_with_args.
2988
47ea7f44
PE
29892011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2990
ac389d0c 2991 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2992 The old code sometimes used this field without initializing it.
2993
47ea7f44
PE
2994 * alloc.c (gc_sweep): Don't read past end of array.
2995 In theory, the old code could also have corrupted Emacs internals,
2996 though it'd be very unlikely.
2997
bc985c87
AS
29982011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2999
3000 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3001 argument. (Bug#4026)
bc985c87 3002
0cf34688
LMI
30032011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3004
b3dadd76
LMI
3005 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3006 key" (bug#4257).
3007
0cf34688
LMI
3008 * window.c (Fset_window_start): Doc fix (bug#4199).
3009 (Fset_window_hscroll): Ditto.
3010
270768cd
PE
30112011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3012
077e3dda 3013 Fix minor new problems caught by GCC 4.6.1.
270768cd 3014 * term.c (init_tty): Remove unused local.
490011a6 3015 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3016 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3017 not used otherwise.
270768cd 3018
b1f58454
CY
30192011-07-12 Chong Yidong <cyd@stupidchicken.com>
3020
3021 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3022
22b9578d
LMI
30232011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3024
6e70ab07
LMI
3025 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3026 are the mini-buffer and the echo area (bug#3320).
3027
22b9578d
LMI
3028 * term.c (init_tty): Remove support for supdup, c10 and perq
3029 terminals, which are no longer supported (bug#1482).
3030
8974cc9f
JB
30312011-07-10 Johan Bockgård <bojohan@gnu.org>
3032
3033 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3034
a560d974
JD
30352011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3036
3037 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3038 for non-popups (Bug#3642).
3039
1dae0f0a
AS
30402011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3041
268c2c36 3042 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3043 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3044 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3045 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3046 * data.c (fmod): Likewise.
3047 * dispnew.c (swap_glyphs_in_rows): Likewise.
3048 * emacs.c (memory_warning_signal): Likewise.
3049 * floatfns.c (float_error): Likewise.
3050 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3051 (otf_open, font_otf_capability, generate_otf_features)
3052 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3053 Likewise.
3054 * image.c (pbm_read_file): Likewise.
3055 * indent.c (string_display_width): Likewise.
3056 * intervals.c (check_for_interval, search_for_interval)
3057 (inc_interval_count, count_intervals, root_interval)
3058 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3059 * lread.c (defalias): Likewise.
268c2c36 3060 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3061 * regex.c (set_image_of_range_1, set_image_of_range)
3062 (regex_grow_registers): Likewise.
3063 * sysdep.c (strerror): Likewise.
3064 * termcap.c (valid_filename_p, tprint, main): Likewise.
3065 * tparam.c (main): Likewise.
3066 * unexhp9k800.c (run_time_remap, save_data_space)
3067 (update_file_ptrs, read_header, write_header, calculate_checksum)
3068 (copy_file, copy_rest, display_header): Likewise.
3069 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3070 Likewise.
3071 * xdisp.c (check_it): Likewise.
3072 * xfaces.c (register_color, unregister_color, unregister_colors):
3073 Likewise.
3074 * xfns.c (print_fontset_result): Likewise.
3075 * xrdb.c (member, fatal, main): Likewise.
3076
99033785
PE
30772011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3078
3079 Fix minor problems found by static checking (Bug#9031).
3080 * chartab.c (char_table_set_range, map_sub_char_table):
3081 Remove unused locals.
3082 (uniprop_table): Now static.
3083 * composite.c (_work_char): Remove unused static var.
3084
9cb2ac56
JB
30852011-07-09 Juanma Barranquero <lekktu@gmail.com>
3086
3087 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3088
f25661f0
JD
30892011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3090
3091 * gtkutil.c (qttip_cb): Remove code without function.
3092
8278c4fe
EZ
30932011-07-09 Eli Zaretskii <eliz@gnu.org>
3094
3095 * w32.c (pthread_sigmask): New stub.
3096
1692ae2d 30972011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3098
8a6ebd58 3099 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3100 sigprocmask is portable only for single-threaded applications, and
3101 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3102 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3103 (LIBES): Use it.
3104 * callproc.c (Fcall_process):
3105 * process.c (create_process):
3106 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3107 Use pthread_sigmask, not sigprocmask.
123403e4 3108
1b854618
JD
31092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3110
3111 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3112 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3113 wrong (Bug#8591).
3114
3fe4b549
JD
31152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3116
0ce7e563
JD
3117 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3118 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3119 (xg_hide_tooltip): Fix comment.
3120
3fe4b549
JD
3121 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3122 in registerServicesMenuSendTypes.
3123 (validRequestorForSendType): Don't check ns_return_types.
3124
3125 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3126 ns_return_type.
3127
5df75e47
JR
31282011-07-08 Jason Rumney <jasonr@gnu.org>
3129
22610910
JR
3130 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3131 SH_SHOW for hidden windows (Bug#5482).
3132
5df75e47
JR
3133 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3134 frame struct members of non-existent frames (Bug#6284).
3135
699c10bd
JD
31362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3137
4393663b
JD
3138 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3139 variable firstTime not needed on OSX >= 10.6.
3140 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3141 >= 10.5. Use setKnobProportion, setDoubleValue.
3142
3143 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3144 (MAC_OS_X_VERSION_10_5): Define if not defined.
3145 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3146 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3147 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3148
3149 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3150 cString and lossyCString on OSX >= 10.4
3151
58179cce 3152 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3153 sizeToFit on OSX >= 10.2.
3154
3155 * nsimage.m (allocInitFromFile): Don't use deprecated method
3156 bestRepresentationForDevice on OSX >= 10.6.
3157
3158 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3159 to avoid warning.
3160
3161 * emacs.c: Declare unexec_init_emacs_zone.
3162
a63e0781
JD
3163 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3164
699c10bd
JD
3165 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3166
3167 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3168 on svcsMenu (Bug#8842).
3169
3170 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3171 ns_return_types.
3172 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3173
3174 * nsterm.m (QUTF8_STRING): Declare.
3175 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3176 (validRequestorForSendType): Return type is (id).
3177 Change indexOfObjectIdenticalTo to indexOfObject.
3178 Check if we have local selection before returning self (Bug#8842).
3179 (writeSelectionToPasteboard): Put local selection into paste board
3180 if we have a local selection (Bug#8842).
3181 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3182
3183 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3184 (ns_get_local_selection): Declare.
3185
54e10184
LMI
31862011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3187
9888ff71
LMI
3188 * keymap.c (describe_map_tree): Don't insert a double newline at
3189 the end of the buffer (bug#1169) and return whether we inserted
3190 something.
3191
54e10184
LMI
3192 * callint.c (Fcall_interactively): Change "reading args" to
3193 "providing args" to try to clarify what it does (bug#1010).
3194
15fa4783
KH
31952011-07-07 Kenichi Handa <handa@m17n.org>
3196
3197 * composite.c (composition_compute_stop_pos): Ignore a static
3198 composition starting before CHARPOS (Bug#8915).
3199
3200 * xdisp.c (handle_composition_prop): Likewise.
3201
a8815b00
EZ
32022011-07-07 Eli Zaretskii <eliz@gnu.org>
3203
3204 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3205 (Bug#9015)
3206
ef7b981d 32072011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3208
3209 * character.h (unicode_category_t): New enum type.
3210
3211 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3212 (Qchar_code_property_table): New variable.
3213 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3214 (UNIPROP_COMPRESSED_FORM_P): New macros.
3215 (char_table_ascii): Uncompress the compressed values.
3216 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3217 Uncompress the compressed values.
ac389d0c 3218 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3219 (char_table_ref_and_range): Uncompress the compressed values.
3220 (sub_char_table_set): New arg is_uniprop. Callers changed.
3221 Uncompress the compressed values.
3222 (sub_char_table_set_range): Args changed. Callers changed.
3223 (char_table_set_range): Adjuted for the above change.
3224 (map_sub_char_table): Delete args default_val and parent. Add arg
3225 top. Give decoded values to a Lisp function.
640c8776 3226 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3227 values to a Lisp function. Gcpro more variables.
3228 (uniprop_table_uncompress)
3229 (uniprop_decode_value_run_length): New functions.
3230 (uniprop_decoder, uniprop_decoder_count): New variables.
3231 (uniprop_get_decoder, uniprop_encode_value_character)
3232 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3233 New functions.
3234 (uniprop_encoder, uniprop_encoder_count): New variables.
3235 (uniprop_get_encoder, uniprop_table)
3236 (Funicode_property_table_internal, Fget_unicode_property_internal)
3237 (Fput_unicode_property_internal): New functions.
3238 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3239 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3240 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3241 char-code-property-alist.
3242
640c8776 3243 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3244 Vunicode_category_table.
3245
640c8776 3246 * font.c (font_range): Adjust for the change of
c805dec0
KH
3247 Vunicode_category_table.
3248
76b397fb
DN
32492011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3250
3251 * m/iris4d.h: Remove file, move contents ...
3252 * s/irix6-5.h: ... here.
3253
22b4128e
PE
32542011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3255
3256 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3257 * alloc.c (mark_buffer):
3258 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3259 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3260 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3261 This isn't true in general, and it's particularly not true
3262 if Emacs is configured with --with-wide-int.
3263 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3264 New macros, used in the buffer.c change.
3265
869795d6
JD
32662011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3267
3268 * xsettings.c: Use both GConf and GSettings if both are available.
3269 (store_config_changed_event): Add comment.
3270 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3271 (store_tool_bar_style_changed): New functions.
5e617bc2 3272 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3273 (struct xsettings): Move font inside HAVE_XFT.
3274 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3275 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3276 Move inside HAVE_XFT.
640c8776 3277 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3278 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3279 also.
3280 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3281 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3282 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3283 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3284 (parse_settings): Move check for font inside HAVE_XFT.
3285 (read_settings, apply_xft_settings): Add comment.
3286 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3287 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3288 call store_font_name_changed.
3289 (xft_settings_event): Add comment.
3290 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3291 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3292 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3293 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3294 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3295 (xsettings_get_system_font, xsettings_get_system_normal_font):
3296 Add comment.
869795d6 3297
d8ed26bd
PE
32982011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3299
3300 Random fixes. E.g., (random) never returned negative values.
3301 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3302 subseconds part to the entropy, as that's a bit more random.
3303 Prefer signed to unsigned, since the signedness doesn't matter and
3304 in general we prefer signed. When given a limit, use a
3305 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3306 latter isn't right if USE_2_TAGS_FOR_INTS.
3307 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3308 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3309
cabf1cac
SM
33102011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3311
3312 * textprop.c (text_property_stickiness):
3313 Obey Vtext_property_default_nonsticky.
3314 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3315 * w32fns.c (syms_of_w32fns):
3316 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3317
6e9b2be9
PE
33182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3319
3320 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3321 This is more efficient than Ffile_directory_p and avoids a minor race.
3322
90186c68
LMI
33232011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3324
7c301272
LMI
3325 * buffer.c (Foverlay_put): Say what the return value is
3326 (bug#7835).
3327
c4f2d8d4
LMI
3328 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3329 is a directory before asking whether to use the file name
3330 (bug#7564).
ad637907
LMI
3331 (barf_or_query_if_file_exists): Make the "File is a directory"
3332 error be more correct.
c4f2d8d4 3333
90186c68
LMI
3334 * fns.c (Frequire): Remove the mention of the .gz files, since
3335 that's installation-specific, but keep the mention of
3336 `get-load-suffixes'.
3337
da64016e
PE
33382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3339
3340 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3341 Report string overflow if the output is too long.
3342
7d47b580
JB
33432011-07-04 Juanma Barranquero <lekktu@gmail.com>
3344
a555cb87
JB
3345 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3346 (syms_of_gnutls): Remove duplicate DEFSYM for
3347 Qgnutls_bootprop_verify_hostname_error, an error for
3348 Qgnutls_bootprop_verify_error (which is no longer used).
3349
7d47b580
JB
3350 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3351 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3352 Also (re)move comments that are misplaced or no longer relevant.
3353
1e49bfab
LMI
33542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3355
3356 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3357
1485f4c0
CY
33582011-07-03 Chong Yidong <cyd@stupidchicken.com>
3359
3360 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3361 and background color parameters if they have been changed.
3362
a9ab721e
LMI
33632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3364
3365 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3366
cf7cff57
PE
33672011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3368
2e13213d
PE
3369 * xsettings.c (SYSTEM_FONT): Define only when used.
3370 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3371
cf7cff57
PE
3372 * keymap.c (access_keymap_1): Now static.
3373
7a8e04f7
CY
33742011-07-02 Chong Yidong <cyd@stupidchicken.com>
3375
3376 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3377 leave any prefix arg for the up event (Bug#1586).
3378
61352f62
LMI
33792011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3380
69bb1ef7
LMI
3381 * lread.c (syms_of_lread): Mention single symbols defined by
3382 `defvar' or `defconst' (bug#7154).
3383
61352f62 3384 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3385 (Frequire): Mention get-load-suffixes.
61352f62 3386
28545e04
MR
33872011-07-02 Martin Rudalics <rudalics@gmx.at>
3388
3389 * window.h (window): Remove clone_number slot.
3390 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3391 Remove.
3392 (make_parent_window, make_window, saved_window)
3393 (Fset_window_configuration, save_window_save): Don't deal with
3394 clone numbers.
3395 * buffer.c (Qclone_number): Remove declaration.
3396 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3397
3349e122
SM
33982011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3399
3400 Add multiple inheritance to keymaps.
3401 * keymap.c (Fmake_composed_keymap): New function.
3402 (Fset_keymap_parent): Simplify.
3403 (fix_submap_inheritance): Remove.
3404 (access_keymap_1): New function extracted from access_keymap to handle
3405 embedded parents and handle lists of maps.
3406 (access_keymap): Use it.
3407 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3408 (Fcopy_keymap): Handle embedded parents.
3409 (Fcommand_remapping, define_as_prefix): Simplify.
3410 (Fkey_binding): Simplify.
3411 (syms_of_keymap): Move minibuffer-local-completion-map,
3412 minibuffer-local-filename-completion-map,
3413 minibuffer-local-must-match-map, and
3414 minibuffer-local-filename-must-match-map to Elisp.
3415 (syms_of_keymap): Defsubr make-composed-keymap.
3416 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3417 (parse_menu_item): Trivial simplification.
3418
3279eb87
GM
34192011-07-01 Glenn Morris <rgm@gnu.org>
3420
3421 * Makefile.in (SETTINGS_LIBS): Fix typo.
3422
4550efdf
KI
34232011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3424
3425 * coding.c (Fencode_coding_string): Record the last coding system
3426 used, as the function doc string says (bug#8738).
3427
0949d2b6
JD
34282011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3429
3430 * xsettings.c (store_monospaced_changed): Take new font as arg and
3431 check for change against current_mono_font.
3432 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3433 (emacs_settings_constructor, emacs_settings_get_property)
3434 (emacs_settings_set_property, emacs_settings_class_init)
3435 (emacs_settings_init, gsettings_obj): Remove.
3436 (something_changedCB): New function for HAVE_GSETTINGS.
3437 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3438 with value as argument.
3439 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3440 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3441 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3442 "changed".
3443
3444 * xgselect.c: Add defined (HAVE_GSETTINGS).
3445 (xgselect_initialize): Ditto.
3446
3447 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3448 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3449 xg_select.
3450
bbc6b304
PE
34512011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3452
3453 * eval.c (struct backtrace): Simplify and port the data structure.
3454 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3455 signed bit field, as this assumption is not portable and it makes
3456 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3457 "char debug_on_exit : 1" as this is not portable either; instead,
3458 use the portable "unsigned int debug_on_exit : 1". Remove unused
3459 member evalargs. Remove obsolete comments about cc bombing out.
3460
9851bfc5
JD
34612011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3462
51bb811f 3463 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3464 Let HAVE_GSETTINGS override HAVE_GCONF.
3465 (store_monospaced_changed): New function.
3466 (EMACS_SETTINGS): A new type derived from GObject to handle
3467 GSettings notifications.
3468 (emacs_settings_constructor, emacs_settings_get_property)
3469 (emacs_settings_set_property, emacs_settings_class_init):
3470 New functions.
3471 (gsettings_client, gsettings_obj): New variables.
3472 (GSETTINGS_SCHEMA): New define.
3473 (something_changedCB): Call store_monospaced_changed.
3474 (init_gsettings): New function.
3475 (xsettings_initialize): Call init_gsettings.
3476 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3477 to NULL.
3478
640c8776 3479 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3480 GCONF_CFLAGS/LIBS.
3481
5386012d
MR
34822011-06-29 Martin Rudalics <rudalics@gmx.at>
3483
3484 * window.c (resize_root_window, grow_mini_window)
3485 (shrink_mini_window): Rename Qresize_root_window to
3486 Qwindow_resize_root_window and Qresize_root_window_vertically to
3487 Qwindow_resize_root_window_vertically.
3488
f13e0b08
PE
34892011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3490
3491 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3492
94515237
JB
34932011-06-27 Juanma Barranquero <lekktu@gmail.com>
3494
3495 * makefile.w32-in: Redesign dependencies so they reflect more
3496 clearly which files are directly included by each source file,
3497 and not through other includes.
3498
e43b6e43
MR
34992011-06-27 Martin Rudalics <rudalics@gmx.at>
3500
3501 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3502 (sort_overlays, overlay_strings): When an overlay's clone number
3503 matches the window's clone number process the overlay even if
3504 the overlay's window property doesn't match the current window.
3505
d68443dc
MR
3506 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3507 (Fwindow_hchild): Rename to Fwindow_left_child.
3508 (Fwindow_next): Rename to Fwindow_next_sibling.
3509 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3510 (resize_window_check): Rename to window_resize_check.
3511 (resize_window_apply): Rename to window_resize_apply.
3512 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3513 (Fdelete_other_windows_internal, resize_frame_windows)
3514 (Fsplit_window_internal, Fdelete_window_internal)
3515 (grow_mini_window, shrink_mini_window)
3516 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3517
c7e73be5
JD
35182011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3519
3520 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3521 (emacs_fixed_set_min_size): Remove.
3522 (emacs_fixed_new): Take frame as argument.
3523
3524 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3525 (_EmacsFixedPrivate): Remove minwidth/height.
3526 Add struct frame *f.
3527 (emacs_fixed_init): Initialize priv->f.
3528 (get_parent_class, emacs_fixed_set_min_size): Remove.
3529 (emacs_fixed_new): Set priv->f to argument.
3530 (emacs_fixed_get_preferred_width)
3531 (emacs_fixed_get_preferred_height): Use min_width/height from
3532 frames size_hint to set minimum and natural (Bug#8919).
3533 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3534 and use min_width/height from frames size_hint to set
3535 min_width/height (Bug#8919).
3536
3537 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3538 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3539 Fix indentation.
c7e73be5 3540
cf99dcf8
EZ
35412011-06-26 Eli Zaretskii <eliz@gnu.org>
3542
3543 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3544 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3545 called at ZV.
3546
029529ac
CY
35472011-06-26 Chong Yidong <cyd@stupidchicken.com>
3548
3549 * process.c (wait_reading_process_output): Bypass select if
3550 waiting for a cell while ignoring keyboard input, and input is
3551 pending. Suggested by Jan Djärv (Bug#8869).
3552
7a7ef429
PE
35532011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3554
3555 Use gnulib's dup2 module instead of rolling our own.
3556 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3557
11fdef7d 35582011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3559
3560 * dispnew.c (scrolling_window): Before scrolling, turn off a
3561 mouse-highlight in the window being scrolled.
3562
cd3520a4
JB
35632011-06-24 Juanma Barranquero <lekktu@gmail.com>
3564
3565 Move DEFSYM to lisp.h and use everywhere.
3566
3567 * character.h (DEFSYM): Move declaration...
3568 * lisp.h (DEFSYM): ...here.
3569
3570 * gnutls.c:
3571 * minibuf.c:
3572 * w32menu.c:
3573 * w32proc.c:
3574 * w32select.c: Don't include character.h.
3575
3576 * alloc.c (syms_of_alloc):
3577 * buffer.c (syms_of_buffer):
3578 * bytecode.c (syms_of_bytecode):
3579 * callint.c (syms_of_callint):
3580 * casefiddle.c (syms_of_casefiddle):
3581 * casetab.c (init_casetab_once):
3582 * category.c (init_category_once, syms_of_category):
3583 * ccl.c (syms_of_ccl):
3584 * cmds.c (syms_of_cmds):
3585 * composite.c (syms_of_composite):
3586 * dbusbind.c (syms_of_dbusbind):
3587 * dired.c (syms_of_dired):
3588 * dispnew.c (syms_of_display):
3589 * doc.c (syms_of_doc):
3590 * editfns.c (syms_of_editfns):
3591 * emacs.c (syms_of_emacs):
3592 * eval.c (syms_of_eval):
3593 * fileio.c (syms_of_fileio):
3594 * fns.c (syms_of_fns):
3595 * frame.c (syms_of_frame):
3596 * fringe.c (syms_of_fringe):
3597 * insdel.c (syms_of_insdel):
3598 * keymap.c (syms_of_keymap):
3599 * lread.c (init_obarray, syms_of_lread):
3600 * macros.c (syms_of_macros):
3601 * msdos.c (syms_of_msdos):
3602 * print.c (syms_of_print):
3603 * process.c (syms_of_process):
3604 * search.c (syms_of_search):
3605 * sound.c (syms_of_sound):
3606 * syntax.c (init_syntax_once, syms_of_syntax):
3607 * terminal.c (syms_of_terminal):
3608 * textprop.c (syms_of_textprop):
3609 * undo.c (syms_of_undo):
3610 * w32.c (globals_of_w32):
3611 * window.c (syms_of_window):
3612 * xdisp.c (syms_of_xdisp):
3613 * xfaces.c (syms_of_xfaces):
3614 * xfns.c (syms_of_xfns):
3615 * xmenu.c (syms_of_xmenu):
3616 * xsettings.c (syms_of_xsettings):
3617 * xterm.c (syms_of_xterm): Use DEFSYM.
3618
4228cf16
TZ
36192011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3620
cd3520a4 3621 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3622
7fcccf1e
PE
36232011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3624
7efb4e0e
PE
3625 Integer and buffer overflow fixes (Bug#8873).
3626
ff5844ad
PE
3627 * print.c (printchar, strout): Check for string overflow.
3628 (PRINTPREPARE, printchar, strout):
3629 Don't set size unless allocation succeeds.
3630
90532f02
PE
3631 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3632 for sizes. Check for string overflow more accurately.
3633 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3634
6d84508d
PE
3635 * macros.c: Integer and buffer overflow fixes.
3636 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3637 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3638 Use ptrdiff_t, not int, for sizes.
3639 Don't increment bufsize until after realloc succeeds.
3640 Check for size-calculation overflow.
3641 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3642
437b2cb4
PE
3643 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3644
8b9ac8b4
PE
3645 * lread.c: Integer overflow fixes.
3646 (read_integer): Radix is now EMACS_INT, not int,
3647 to improve quality of diagnostics for out-of-range radices.
3648 Calculate buffer size correctly for out-of-range radices.
3649 (read1): Check for integer overflow in radices, and in
3650 read-circle numbers.
82cb60d3
PE
3651 (read_escape): Avoid int overflow.
3652 (Fload, openp, read_buffer_size, read1)
3653 (substitute_object_recurse, read_vector, read_list, map_obarray):
3654 Use ptrdiff_t, not int, for sizes.
3655 (read1): Use EMACS_INT, not int, for sizes.
20270765 3656 Check for size overflow.
8b9ac8b4 3657
7fcccf1e
PE
3658 * image.c (cache_image): Check for size arithmetic overflow.
3659
bfbbd7e7
PE
3660 * lread.c: Integer overflow issues.
3661 (saved_doc_string_size, saved_doc_string_length)
3662 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3663 Now ptrdiff_t, not int.
3664 (read1): Don't assume doc string length fits in int. Check for
3665 out-of-range doc string lengths.
3666 (read_list): Don't assume file position fits in int.
39019e54 3667 (read_escape): Check for hex character overflow.
bfbbd7e7 3668
4e323265
LL
36692011-06-22 Leo Liu <sdl.web@gmail.com>
3670
3671 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3672 Move to minibuffer.el.
3673
85fece3e
PE
36742011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3675
20b84ce9 3676 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3677 The following patches are for when GLYPH_DEBUG && !XASSERT.
3678 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3679 * dispnew.c (flush_stdout):
3680 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3681 Mark as externally visible.
3682 * dispnew.c (check_window_matrix_pointers): Now static.
3683 * dispnew.c (window_to_frame_vpos):
3684 * xfns.c (unwind_create_frame):
3685 * xterm.c (x_check_font): Remove unused local.
3686 * scroll.c (CHECK_BOUNDS):
3687 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3688 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3689 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3690 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3691 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3692 Now static.
3693 (debug_method_add): Use va_list and vsprintf rather than relying
3694 on undefined behavior with wrong number of arguments.
3695 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3696 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3697 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3698 since we're not interested in debugging glyphs with old libraries.
3699 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3700 GCC 4.6.0's static checking.
3701
0766b489
PE
37022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3703
31fd4b32
PE
3704 Integer overflow and signedness fixes (Bug#8873).
3705 A few related buffer overrun fixes, too.
3706
b79e8648
PE
3707 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3708
0766b489
PE
3709 * dispextern.h (struct face.stipple):
3710 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3711 (x_bitmap_mask, x_allocate_bitmap_record)
3712 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3713 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3714 (x_create_bitmap_from_xpm_data):
3715 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3716 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3717 (.bitmaps_last):
3718 * xfaces.c (load_pixmap):
3719 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3720 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3721 (.bitmaps_last, struct x_output.icon_bitmap):
3722 Use ptrdiff_t, not int, for bitmap indexes.
3723 (x_allocate_bitmap_record): Check for size overflow.
3724 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3725
b081724f
PE
3726 Use ptrdiff_t, not int, for overlay counts.
3727 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3728 * editfns.c (overlays_around, get_pos_property):
3729 * textprop.c (get_char_property_and_overlay):
3730 * xdisp.c (next_overlay_change, note_mouse_highlight):
3731 * xfaces.c (face_at_buffer_position):
21514da7
PE
3732 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3733 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3734 (Fnext_overlay_change, Fprevious_overlay_change)
3735 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3736 Use ptrdiff_t, not int, for sizes.
21514da7 3737 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3738
3de73e5e
PE
3739 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3740
2606c57b
PE
3741 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3742 (x_session_initialize): Do not assume string length fits in int.
3743
aaafe47a
PE
3744 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3745 This is unlikely, but can occur if DPI is outlandish.
3746
2674ddc8 3747 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3748 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3749
28154962
PE
3750 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3751 * xrdb.c (magic_file_p, search_magic_path):
3752 Omit last arg SUFFIX; it was always 0. All callers changed.
3753 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3754
7de51af5
PE
3755 * xfont.c (xfont_match): Avoid need for strlen.
3756
25ed6cc3
PE
3757 * xfns.c: Don't assume strlen fits in int.
3758 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3759
4eab31dd
PE
3760 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3761 not unsigned long, as we prefer signed integers. All callers changed.
3762 Detect integer overflow in repeat count.
3763 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3764 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3765
171e2a58
PE
3766 * termcap.c: Don't assume sizes fit in int and never overflow.
3767 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3768 (gobble_line): Check for size-calculation overflow.
3769
ad39faca 3770 * minibuf.c (Fread_buffer):
6e5bb2dc 3771 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3772 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3773 Don't assume string length fits in int.
3774
52c61c22 3775 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3776 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3777
b5b8c9e5
PE
3778 * font.c: Don't assume string length fits in int.
3779 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3780 Use ptrdiff_t, not int.
ccd6111c
PE
3781 (font_intern_prop): Don't assume string length fits in int.
3782 Don't assume integer property fits in fixnum.
3783 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3784
882f0d81 3785 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3786 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3787 Reformulate so as not to need the command string.
3788 Invoke gzip -cd rather than gunzip, as it's more portable.
3789 (lock_info_type, lock_file_1, lock_file):
3790 Don't assume pid_t and time_t fit in unsigned long.
3791 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3792 (current_lock_owner): Prefer signed type for sizes.
3793 Use memcpy, not strncpy, where memcpy is what is really wanted.
3794 Don't assume (via atoi) that time_t and pid_t fit in int.
3795 Check for time_t and/or pid_t out of range, e.g., via a network share.
3796 Don't alloca where an auto var works fine.
3797
93f4cf88
PE
3798 * fileio.c: Fix some integer overflow issues.
3799 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3800 Don't assume string length fits in int.
3801 (directory_file_name): Don't assume string length fits in long.
3802 (make_temp_name): Don't assume pid fits in int, or that its print
3803 length is less than 20.
3804
f3e92b69
PE
3805 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3806
1bfdaf10
PE
3807 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3808
35016e9a
PE
3809 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3810
3d1e65a1
PE
3811 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3812 We prefer signed integers, even for size calculations.
3813
0b963a93
PE
3814 * emacs.c: Don't assume string length fits in 'int'.
3815 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3816 (main): Don't invoke strlen when not needed.
3817
573f4b54
PE
3818 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3819 (XD_DEBUG_MESSAGE): Don't waste a byte.
3820
989f33ba
PE
3821 * callproc.c (getenv_internal_1, getenv_internal)
3822 (Fgetenv_internal):
965d34eb
PE
3823 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3824
e4d29b33
PE
3825 * lread.c (invalid_syntax): Omit length argument.
3826 All uses changed. This doesn't fix a bug, but it simplifies the
3827 code away from its former Hollerith-constant appearance, and it's
3828 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3829 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3830
eb49b136
PE
3831 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3832 This didn't break anything, but it didn't help either.
3833 It's confusing to put a bogus integer in a place where the actual
3834 value does not matter.
9f62aeb1 3835 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3836 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3837
15375a22
PE
3838 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3839 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3840 implementation.
b61cc01c
PE
3841 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3842 We prefer signed types, and the value cannot exceed the EMACS_INT
3843 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3844 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3845 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3846 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3847
53b2623d
PE
3848 * indent.c (sane_tab_width): New function.
3849 (current_column, scan_for_column, Findent_to, position_indentation)
3850 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3851 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3852
51cab52b 3853 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3854
f2ed8a70
PE
3855 * lisp.h (lint_assume): New macro.
3856 * composite.c (composition_gstring_put_cache):
3857 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3858
abe80cc6
PE
3859 * editfns.c, insdel.c:
3860 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3861
b02c740e
PE
3862 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3863
ebc96716
PE
3864 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3865
b4e50fa0 3866 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3867 Use much-faster test for byte-length change.
311d5d7c 3868 Don't assume string byte-length fits in 'int'.
a4cf38e4 3869 Check that character arg fits in 'int'.
85461888 3870 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3871
c0c1ee9f
PE
3872 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3873
a498d7f4
PE
3874 * fns.c (concat): Catch string overflow earlier.
3875 Do not rely on integer wraparound.
3876
51cab52b
PE
3877 * dispextern.h (struct it.overlay_strings_charpos)
3878 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3879 * xdisp.c (forward_to_next_line_start)
3880 (back_to_previous_visible_line_start)
3881 (reseat_at_next_visible_line_start, next_element_from_buffer):
3882 Don't arbitrarily truncate the value of 'selective' to int.
3883
76031fad
PE
3884 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3885
5eb55db9
PE
3886 * composite.c: Don't truncate sizes to 'int'.
3887 (composition_gstring_p, composition_reseat_it)
3888 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3889 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3890 not EMACS_UINT, for indexes.
5eb55db9 3891
0703a717
PE
3892 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3893
d6202519
PE
3894 * buffer.c: Include <verify.h>.
3895 (struct sortvec.priority, struct sortstr.priority):
8961a454 3896 Now EMACS_INT, not int.
c20998a7 3897 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3898 (struct sortstr.size, record_overlay_string)
3899 (struct sortstrlist.size, struct sortlist.used):
3900 Don't truncate size to int.
3901 (record_overlay_string): Check for size-calculation overflow.
d6202519 3902 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3903
d5a19415
JM
39042011-06-22 Jim Meyering <meyering@redhat.com>
3905
029529ac 3906 Don't leak an XBM-image-sized buffer
d5a19415
JM
3907 * image.c (xbm_load): Free the image buffer after using it.
3908
a9041e6c
PE
39092011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3910
3911 Port to Sun C.
3912 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3913 that Sun C diagnosed.
3914 * fns.c (secure_hash): Fix pointer signedness issue.
3915 * intervals.c (static_offset_intervals): New function.
3916 (offset_intervals): Use it.
3917
7f3f739f
LL
39182011-06-21 Leo Liu <sdl.web@gmail.com>
3919
3920 * deps.mk (fns.o):
3921 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3922 sha512.h.
3923
3924 * fns.c (secure_hash): Rename from crypto_hash_function and change
3925 the first arg to accept symbols.
5b66d427 3926 (Fsecure_hash): New primitive.
7f3f739f
LL
3927 (syms_of_fns): New symbols.
3928
76147d94
DD
39292011-06-20 Deniz Dogan <deniz@dogan.se>
3930
3931 * process.c (Fset_process_buffer): Clarify return value in
3932 docstring.
3933
7d7d0045
CY
39342011-06-18 Chong Yidong <cyd@stupidchicken.com>
3935
3936 * dispnew.c (add_window_display_history): Use BVAR.
3937
3938 * xdisp.c (debug_method_add): Use BVAR.
3939 (check_window_end, dump_glyph_matrix, dump_glyph)
3940 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3941
3942 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3943 Likewise.
3944
3945 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3946 check till after the cache is created in init_frame_faces.
3947
ff2bc410
SM
39482011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3949
3950 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3951
28177add
PE
39522011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3953
dd3482fe
PE
3954 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3955 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3956 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3957
393d71f3 3958 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3959 * fileio.c (Finsert_file_contents):
3960 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3961 Remove the old (too-loose) buffer overflow checks.
3962 They weren't needed, since make_gap checks for buffer overflow.
3963 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3964 The old code merely checked for Emacs fixnum overflow, and relied
3965 on undefined (wraparound) behavior. The new code avoids undefined
3966 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3967
2e6813b0 3968 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3969 Tune. Don't use wider integers than needed. Don't use alloca.
3970 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3971
599a9e4f
PE
3972 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3973
99561444
PE
3974 * insdel.c, lisp.h (buffer_overflow): New function.
3975 (insert_from_buffer_1, replace_range, replace_range_2):
3976 * insdel.c (make_gap_larger):
3977 * editfns.c (Finsert_char):
3978 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3979
28177add
PE
3980 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3981
e69dafad
PE
39822011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3983
a7af7fde 3984 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3985
b1c46f02
PE
3986 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3987 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3988
e69dafad
PE
3989 * fileio.c: Don't assume EMACS_INT fits in off_t.
3990 (emacs_lseek): New static function.
3991 (Finsert_file_contents, Fwrite_region): Use it.
3992 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3993
566684ea
PE
3994 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3995
e6966cd6
PE
3996 * fns.c: Don't overflow int when computing a list length.
3997 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3998 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3999 truncation on 64-bit hosts. Check for QUIT every
4000 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4001 faster and is responsive enough.
4002 (Flength): Report an error instead of overflowing an integer.
4003 (Fsafe_length): Return a float if the value is not representable
4004 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4005 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4006 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4007
dd0b0efb
PE
4008 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4009 (header_size, word_size): New constants.
4010 (allocate_vectorlike): Don't check size overflow here.
4011 (allocate_vector): Check it here instead, since this is the only
4012 caller of allocate_vectorlike that could cause overflow.
4013 Check that the new vector's length is representable as a fixnum.
4014
86fe5cfe
PE
4015 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4016 The previous code was bogus. For example, next_almost_prime (32)
4017 returned 39, which is undesirable as it is a multiple of 3; and
4018 next_almost_prime (24) returned 25, which is a multiple of 5 so
4019 why was the code bothering to check for multiples of 7?
4020
80e88859
PE
4021 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4022
4a2f0ad6
PE
4023 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4024
f66c7cf8
PE
4025 Variadic C functions now count arguments with ptrdiff_t.
4026 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4027 Back then I didn't know that the Emacs coding style prefers signed int.
4028 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4029 were being counted with int, which may truncate counts on 64-bit
4030 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4031 * lisp.h (struct Lisp_Subr.function.aMANY)
4032 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4033 Arg counts are now ptrdiff_t, not size_t.
4034 All variadic functions and their callers changed accordingly.
4035 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4036 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4037 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4038 * callint.c (Fcall_interactively): Check arg count for overflow,
4039 to avoid potential buffer overrun. Use signed char, not 'int',
4040 for 'varies' array, so that we needn't bother to check its size
4041 calculation for overflow.
4042 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4043 * eval.c (apply_lambda):
4044 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4045 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4046 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4047
a1759b76
PE
4048 * callint.c (Fcall_interactively): Don't use index var as event count.
4049
d96be9fc
PE
4050 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4051 * mem-limits.h (SIZE): Remove; no longer used.
4052
a690a978 4053 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4054
578c21e6
PE
4055 Remove unnecessary casts.
4056 * xterm.c (x_term_init):
4057 * xfns.c (x_set_border_pixel):
4058 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4059 These aren't needed now that we assume ANSI C.
4060
96f53c6c
PE
4061 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4062 It's more likely to cause problems (due to unsigned overflow)
4063 than to cure them.
4064
83c77d31
PE
4065 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4066
ee2079f1
PE
4067 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4068
6da65536
PE
4069 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4070
7147c4a4
PE
4071 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4072
193e32d9
PE
4073 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4074
e5533da6
PE
4075 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4076
9910e595
PE
4077 GLYPH_CODE_FACE returns EMACS_INT, not int.
4078 * dispextern.h (merge_faces):
4079 * xfaces.c (merge_faces):
01103c44
PE
4080 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4081 Don't assume EMACS_INT fits in int.
9910e595 4082
2638320e
PE
4083 * character.h (CHAR_VALID_P): Remove unused parameter.
4084 * fontset.c, lisp.h, xdisp.c: All uses changed.
4085
045eb8d9
PE
4086 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4087
c1f134b5
PE
4088 * fns.c (concat): Minor tuning based on overflow analysis.
4089 This doesn't fix any bugs. Use int to hold character, instead
4090 of constantly refetching from Emacs object. Use XFASTINT, not
4091 XINT, for value known to be a character. Don't bother comparing
4092 a single byte to 0400, as it's always less.
4093
395fcb93 4094 * floatfns.c (Fexpt):
327eeec8
PE
4095 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4096
abbd3d23
PE
4097 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4098 for characters.
4099
684a03ef
PE
4100 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4101
0fed43f3
PE
4102 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4103 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4104 incorrectly succeed when S was a string, because 4294967386 was
4105 truncated before it was used.
4106
8fd02eb7
PE
4107 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4108 Otherwise, an out-of-range integer could cause undefined behavior
4109 on a 64-bit host.
4110
f8c86b69
PE
4111 * composite.c: Use int, not EMACS_INT, for characters.
4112 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4113 EMACS_INT, for values that are known to be in character range.
4114 This doesn't fix any bugs but is the usual style inside Emacs and
4115 may generate better code on 32-bit machines.
4116
34206dd2
PE
4117 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4118 This is for reasons similar to the recent CHAR_STRING fix.
4119 * charset.c (Fencode_char): Check that character arg is actually
4120 a character. Pass an int to ENCODE_CHAR.
4121 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4122 wider than 'int', as a compile-time check to prevent future regressions
4123 in this area.
4124
c5958d4c 4125 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4126
4127 Make sure a 64-bit char is never passed to CHAR_STRING.
4128 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4129 by silently ignoring the top 32 bits, allowing some values
4130 that were far too large to be valid characters.
4131 * character.h: Include <verify.h>.
4132 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4133 arguments are no wider than unsigned, as a compile-time check
4134 to prevent future regressions in this area.
4135 * data.c (Faset):
01103c44 4136 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4137 (Fsubst_char_in_region):
4138 * fns.c (concat):
4139 * xdisp.c (decode_mode_spec_coding):
4140 Adjust to CHAR_STRING's new requirement.
4141 * editfns.c (Finsert_char, Fsubst_char_in_region):
4142 * fns.c (concat): Check that character args are actually
4143 characters. Without this test, these functions did the wrong
4144 thing with wildly out-of-range values on 64-bit hosts.
4145
d37ca623
PE
4146 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4147 These casts should not be needed on 32-bit hosts, either.
4148 * keyboard.c (read_char):
4149 * lread.c (Fload): Remove casts to unsigned.
4150
ea204efb
PE
4151 * lisp.h (UNSIGNED_CMP): New macro.
4152 This fixes comparison bugs on 64-bit hosts.
4153 (ASCII_CHAR_P): Use it.
4154 * casefiddle.c (casify_object):
01103c44 4155 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4156 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4157 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4158 * dispextern.h (FACE_FROM_ID):
4159 * keyboard.c (read_char): Use UNSIGNED_CMP.
4160
41cb286c
PE
4161 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4162 not to EMACS_INT, to avoid GCC warning.
4163
4a1b9832
PE
4164 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4165
55daad71
PE
4166 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4167 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4168 isn't needed on 32-bit machines.
8f95c75c 4169
01103c44
PE
4170 * buffer.c (Fgenerate_new_buffer_name):
4171 Use EMACS_INT for count, not int.
0ceccced 4172 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4173
4174 * data.c (Qcompiled_function): Now static.
4175
c6f072e7
PE
4176 * window.c (window_body_lines): Now static.
4177
20ce5912
PE
4178 * image.c (gif_load): Rename local to avoid shadowing.
4179
9c4c5f81
PE
4180 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4181 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4182 * alloc.c (make_save_value): Integer argument is now of type
4183 ptrdiff_t, not int.
4184 (mark_object): Use ptrdiff_t, not int.
4185 * lisp.h (pD): New macro.
4186 * print.c (print_object): Use it.
4187
c0c5c8ae
PE
4188 * alloc.c: Use EMACS_INT, not int, to count objects.
4189 (total_conses, total_markers, total_symbols, total_vector_size)
4190 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4191 (total_free_floats, total_floats, total_free_intervals)
4192 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4193 Now EMACS_INT, not int. All uses changed.
4194 (Fgarbage_collect): Compute overall total using a double, so that
4195 integer overflow is less likely to be a problem. Check for overflow
4196 when converting back to an integer.
5a25e253
PE
4197 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4198 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4199 These were 'int' variables that could overflow on 64-bit hosts;
4200 they were never used, so remove them instead of repairing them.
211a0b2a 4201 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4202 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4203 Previously, this ceilinged at INT_MAX, but that doesn't work on
4204 64-bit machines.
e46bb31a 4205 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4206
c78baabf 4207 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4208 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4209 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4210 when a (possibly-narrower) signed value would do just as well.
4211 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4212
c9d624c6
PE
4213 * alloc.c: Catch some string size overflows that we were missing.
4214 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4215 for convenience in STRING_BYTES_MAX.
4216 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4217 The definition here is exact; the one in lisp.h was approximate.
4218 (allocate_string_data): Check for string overflow. This catches
4219 some instances we weren't catching before. Also, it catches
4220 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4221 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4222 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4223
c9d624c6
PE
4224 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4225 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4226 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4227
353032ce
PE
4228 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4229
2bccce07
PE
4230 * alloc.c (Fmake_string): Check for out-of-range init.
4231
0ac30604
SM
42322011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4233
4234 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4235
c195f2de
JD
42362011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4237
4238 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4239 xg_get_default_scrollbar_width.
4240
4241 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4242 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4243 (style_changed_cb): Call update_theme_scrollbar_width and call
4244 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4245 all frames (Bug#8505).
4246 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4247 Call gtk_window_set_resizable if HAVE_GTK3.
4248 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4249 and height if HAVE_GTK3 (Bug#8505).
4250 (scroll_bar_width_for_theme): New variable.
4251 (update_theme_scrollbar_width): New function.
4252 (xg_get_default_scrollbar_width): Move code to
4253 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4254 (xg_initialize): Call update_theme_scrollbar_width.
4255
4256 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4257
4258 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4259
e10ac9f1
MR
42602011-06-12 Martin Rudalics <rudalics@gmx.at>
4261
4262 * frame.c (make_frame): Call other_buffer_safely instead of
4263 other_buffer.
4264
4265 * window.c (temp_output_buffer_show): Call display_buffer with
4266 second argument Vtemp_buffer_show_specifiers and reset latter
4267 immediately after the call.
4268 (Vtemp_buffer_show_specifiers): New variable.
4269 (auto_window_vscroll_p, next_screen_context_lines)
4270 (Vscroll_preserve_screen_position): Remove leading asterisks from
4271 doc-strings.
4272
2d3c217e 42732011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4274
7b7f97e8 4275 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4276 * buffer.c (Qclone_number): Remove for now, as it's unused.
4277 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4278 (record_buffer): Remove unused local.
4279 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4280 (set_frame_buffer_list): Remove; unused.
4281 * frame.h (other_visible_frames): Remove decl.
4282 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4283 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4284 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4285 if HAVE_GPM.
4286 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4287 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4288 Define only if HAVE_GPM.
4289 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4290 (update_hints_inhibit): Remove; never set. All uses removed.
4291 * widgetprv.h (emacsFrameClassRec): Remove decl.
4292 * window.c (delete_deletable_window): Now returns void, since it
4293 wasn't returning anything.
4294 (compare_window_configurations): Remove unused locals.
4295 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4296 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4297 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4298 the same widths as pointers. This follows up on the 2011-05-06 patch.
4299 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4300 * xterm.h: Likewise.
4301 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4302
1384b89e
JB
43032011-06-12 Juanma Barranquero <lekktu@gmail.com>
4304
4305 * makefile.w32-in: Update dependencies.
4306 (LISP_H): Add lib/intprops.h.
4307
1100a63c
CY
43082011-06-11 Chong Yidong <cyd@stupidchicken.com>
4309
4310 * image.c (gif_load): Add animation frame delay to the metadata.
4311 (syms_of_image): Use DEFSYM. New symbol `delay'.
4312
6198ccd0
MR
43132011-06-11 Martin Rudalics <rudalics@gmx.at>
4314
4315 * window.c (delete_deletable_window): Re-add.
4316 (Fset_window_configuration): Rewrite to handle dead buffers and
4317 consequently deletable windows.
4318 (window_tree, Fwindow_tree): Remove. Supply functionality in
4319 window.el.
4320 (compare_window_configurations): Simplify code.
4321
b6e3633c
AS
43222011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4323
1ab0dee5
AS
4324 * image.c (imagemagick_load_image): Fix type mismatch.
4325 (Fimagemagick_types): Likewise.
4326
b6e3633c
AS
4327 * window.h (replace_buffer_in_windows): Declare.
4328
9397e56f
MR
43292011-06-11 Martin Rudalics <rudalics@gmx.at>
4330
4331 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4332 Qclone_number. Remove external declaration of Qdelete_window.
4333 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4334 code.
640c8776
SM
4335 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4336 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4337 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4338 buffer list implementation.
4339 (other_buffer_safely): New function.
4340 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4341 calls to replace_buffer_in_windows and
4342 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4343 if allowed.
4344 (record_buffer): Inhibit quitting and rewrite using quittable
4345 functions. Run Qbuffer_list_update_hook if allowed.
4346 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4347 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4348 Move switch-to-buffer to window.el.
9397e56f
MR
4349 (bury-buffer): Move to window.el.
4350 (Vbuffer_list_update_hook): New variable.
4351
4352 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4353 section.
4354
4355 * window.h (resize_frame_windows): Move up in code.
4356 (Fwindow_frame): Remove EXFUN.
4357 (replace_buffer_in_all_windows): Remove prototype.
4358 (replace_buffer_in_windows_safely): Add prototype.
4359
4360 * window.c: Declare Qdelete_window static again. Move down
4361 declaration of select_count.
4362 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4363 (Fother_window): Move to window.el.
4364 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4365 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4366 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4367 window.el.
4368 (replace_buffer_in_windows): Implement by calling
4369 Qreplace_buffer_in_windows.
4370 (replace_buffer_in_all_windows): Remove with some functionality
4371 moved into replace_buffer_in_windows_safely.
4372 (replace_buffer_in_windows_safely): New function.
4373 (select_window_norecord, select_frame_norecord): Move in front
4374 of run_window_configuration_change_hook. Remove now obsolete
4375 declarations.
640c8776
SM
4376 (Fset_window_buffer): Rewrite doc-string.
4377 Call Qrecord_window_buffer.
9397e56f
MR
4378 (keys_of_window): Move binding for other-window to window.el.
4379
b50691aa
CY
43802011-06-11 Chong Yidong <cyd@stupidchicken.com>
4381
4382 * dispextern.h (struct image): Replace data member, whose int_val
4383 and ptr_val fields were not used by anything, with a single
4384 lisp_val object.
4385
4386 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4387 (gif_clear_image, gif_load, imagemagick_load_image)
4388 (gs_clear_image, gs_load): Callers changed.
4389
3f754b86
PE
43902011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4391
cca69397
PE
4392 * buffer.h: Include <time.h>, for time_t.
4393 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4394
109e28d0
PE
4395 Fix minor problems found by static checking.
4396
60737f02
PE
4397 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4398
4b66faf3
PE
4399 Make identifiers static if they are not used in other modules.
4400 * data.c (Qcompiled_function, Qframe, Qvector):
4401 * image.c (QimageMagick, Qsvg):
4402 * minibuf.c (Qmetadata):
4403 * window.c (resize_window_check, resize_root_window): Now static.
4404 * window.h (resize_window_check, resize_root_window): Remove decls.
4405
109e28d0
PE
4406 * window.c (window_deletion_count, delete_deletable_window):
4407 Remove; unused.
46a4ce9e
PE
4408 (window_body_lines): Now static.
4409 (Fdelete_other_windows_internal): Mark vars as initialized.
4410 Make sure 'resize_failed' is initialized.
4411 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4412 (resize_window_apply): Remove unused local.
4413 * window.h (delete_deletable_window): Remove decl.
4414
109e28d0 4415 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4416 (imagemagick_load_image): Fix pointer signedness problem by changing
4417 last arg from unsigned char * to char *. All uses changed.
4418 Also, fix a local for similar reasons.
4419 Remove unused locals. Remove locals to avoid shadowing.
4420 (fn_rsvg_handle_free): Remove; unused.
4421 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4422 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4423
3f754b86
PE
4424 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4425
2547adb1
CY
44262011-06-10 Chong Yidong <cyd@stupidchicken.com>
4427
4428 * image.c (gif_load): Fix omitted cast error introduced by
4429 2011-06-06 change.
4430
2c8e37d4
MR
44312011-06-10 Martin Rudalics <rudalics@gmx.at>
4432
4433 * window.h (resize_proportionally, orig_total_lines)
4434 (orig_top_line): Remove from window structure.
4435 (set_window_height, set_window_width, change_window_heights)
4436 (Fdelete_window): Remove prototypes.
4437 (resize_frame_windows): Remove duplicate declaration.
4438
440a42e3
EZ
44392011-06-10 Eli Zaretskii <eliz@gnu.org>
4440
4441 * window.h (resize_frame_windows, resize_window_check)
4442 (delete_deletable_window, resize_root_window)
4443 (resize_frame_windows): Declare prototypes.
4444
4445 * window.c (resize_window_apply): Make definition be "static" to
4446 match the prototype.
4447
562dd5e9
MR
44482011-06-10 Martin Rudalics <rudalics@gmx.at>
4449
4450 * window.c: Remove declarations of Qwindow_size_fixed,
4451 window_min_size_1, window_min_size_2, window_min_size,
4452 size_window, window_fixed_size_p, enlarge_window, delete_window.
4453 Remove static from declaration of Qdelete_window, it's
4454 temporarily needed by Fbury_buffer.
4455 (replace_window): Don't assign orig_top_line and
4456 orig_total_lines.
4457 (Fdelete_window, delete_window): Remove. Window deletion is
4458 handled by window.el.
640c8776
SM
4459 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4460 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4461 (Fdelete_other_windows): Remove. Deleting other windows is
4462 handled by window.el.
4463 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4464 handled in window.el.
4465 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4466 Window minimum sizes are handled in window.el.
4467 (shrink_windows, size_window, set_window_height)
4468 (set_window_width, change_window_heights, window_height)
4469 (window_width, CURBEG, CURSIZE, enlarge_window)
4470 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4471 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4472 handled in window.el.
4473 (make_dummy_parent): Rename to make_parent_window and give it a
4474 second argument horflag.
4475 (make_window): Don't set resize_proportionally any more.
4476 (Fsplit_window): Remove. Windows are split in window.el.
4477 (save_restore_action, save_restore_orig_size)
4478 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4479 Resize mini windows in window.el.
4480 (grow_mini_window, shrink_mini_window): Implement by calling
4481 Qresize_root_window_vertically, resize_window_check and
4482 resize_window_apply.
640c8776
SM
4483 (saved_window, Fset_window_configuration, save_window_save):
4484 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4485 resize_proportionally.
4486 (window_min_height, window_min_width): Move to window.el.
4487 (keys_of_window): Move bindings for delete-other-windows,
4488 split-window, delete-window and enlarge-window to window.el.
4489
4490 * buffer.c: Temporarily extern Qdelete_window.
4491 (Fbury_buffer): Temporarily call Qdelete_window instead of
4492 Fdelete_window (Fbury_buffer will move to window.el soon).
4493
4494 * frame.c (set_menu_bar_lines_1): Remove code handling
4495 orig_top_line and orig_total_lines.
4496
4497 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4498 set_window_height but set heights directly.
4499 (change_frame_size_1): Use resize_frame_windows.
4500
4501 * xdisp.c (init_xdisp): Don't use set_window_height but set
4502 heights directly.
4503
640c8776
SM
4504 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4505 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4506 run_window_configuration_change_hook.
4507
4508 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4509 instead of change_window_heights and run
4510 run_window_configuration_change_hook.
4511
1a13852e
MR
45122011-06-09 Martin Rudalics <rudalics@gmx.at>
4513
4514 * window.c (replace_window): Rename second argument REPLACEMENT to
4515 NEW. New third argument SETFLAG. Rewrite.
4516 (delete_window, make_dummy_parent): Call replace_window with
4517 third argument 1.
4518 (window_list_1): Move down in code.
4519 (run_window_configuration_change_hook): Move set_buffer part
4520 before select_frame_norecord part in order to unwind correctly.
4521 Rename count1 to count.
4522 (recombine_windows, delete_deletable_window, resize_root_window)
4523 (Fdelete_other_windows_internal)
4524 (Frun_window_configuration_change_hook, make_parent_window)
4525 (resize_window_check, resize_window_apply, Fresize_window_apply)
4526 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4527 (Fdelete_window_internal, Fresize_mini_window_internal):
4528 New functions.
1a13852e
MR
4529 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4530
f3d1777e
MR
45312011-06-08 Martin Rudalics <rudalics@gmx.at>
4532
496e208e
MR
4533 * window.h (window): Add some new members to window structure -
4534 normal_lines, normal_cols, new_total, new_normal, clone_number,
4535 splits, nest, prev_buffers, next_buffers.
4536 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4537 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4538
f3d1777e
MR
4539 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4540 Remove.
496e208e
MR
4541 (make_dummy_parent): Set new members of windows structure.
4542 (make_window): Move down in code. Handle new members of window
4543 structure.
4544 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4545 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4546 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4547 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4548 (Fset_window_next_buffers, Fset_window_clone_number):
4549 New functions.
496e208e
MR
4550 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4551 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4552 Doc-string fixes.
4553 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4554 Argument WINDOW can be now internal window too.
4555 (Fwindow_use_time): Move up in code.
4556 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4557 Rewrite doc-string.
4558 (Fset_window_configuration, saved_window)
4559 (Fcurrent_window_configuration, save_window_save): Handle new
4560 members of window structure.
b9e809c2
MR
4561 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4562 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4563 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4564 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4565 Qget_mru_window, Qresize_root_window,
4566 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4567 Qauto_buffer_name; staticpro them.
f3d1777e 4568
abde8f8c
MR
45692011-06-07 Martin Rudalics <rudalics@gmx.at>
4570
4571 * window.c (Fwindow_total_size, Fwindow_left_column)
4572 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4573 (Fwindow_list_1): New functions.
4574 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4575 (Fwindow_width, Fscroll_left, Fscroll_right):
4576 Use window_body_cols instead of window_box_text_cols.
4577 (delete_window, Fset_window_configuration):
4578 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4579 (delete_all_subwindows): Take a window as argument and not a
4580 structure. Rewrite.
190b47e6
MR
4581 (window_loop): Remove handling of GET_LRU_WINDOW and
4582 GET_LARGEST_WINDOW.
4583 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4584
4585 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4586 window_box_text_cols. delete_all_subwindows now takes a
4587 Lisp_Object as argument.
abde8f8c 4588
640c8776
SM
4589 * indent.c (compute_motion, Fcompute_motion):
4590 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4591
fa8a67e6
MR
4592 * frame.c (delete_frame): Call delete_all_subwindows with root
4593 window as argument.
4594
a54e3482
DC
45952011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4596
4597 * fns.c (Fputhash): Document return value.
4598
60002bf5
CY
45992011-06-06 Chong Yidong <cyd@stupidchicken.com>
4600
4601 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4602
0c671da6 46032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4604
b862a52a 4605 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4606
be44ca6c
PE
4607 Check for overflow when converting integer to cons and back.
4608 * charset.c (Fdefine_charset_internal, Fdecode_char):
4609 Use cons_to_unsigned to catch overflow.
4610 (Fencode_char): Use INTEGER_TO_CONS.
4611 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4612 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4613 * data.c (long_to_cons, cons_to_long): Remove.
4614 (cons_to_unsigned, cons_to_signed): New functions.
4615 These signal an error for invalid or out-of-range values.
4616 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4617 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4618 * font.c (Ffont_variation_glyphs):
4619 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4620 * lisp.h: Include <intprops.h>.
4621 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4622 (cons_to_signed, cons_to_unsigned): New decls.
4623 (long_to_cons, cons_to_long): Remove decls.
4624 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4625 (Fprimitive_undo): Use CONS_TO_INTEGER.
4626 * xfns.c (Fx_window_property): Likewise.
4627 * xselect.c: Include <limits.h>.
4628 (x_own_selection, selection_data_to_lisp_data):
4629 Use INTEGER_TO_CONS.
4630 (x_handle_selection_request, x_handle_selection_clear)
4631 (x_get_foreign_selection, Fx_disown_selection_internal)
4632 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4633 (lisp_data_to_selection_data): Use cons_to_unsigned.
4634 (x_fill_property_data): Use cons_to_signed.
4635 Report values out of range.
4636
d1f3d2af
PE
4637 Check for buffer and string overflow more precisely.
4638 * buffer.h (BUF_BYTES_MAX): New macro.
4639 * lisp.h (STRING_BYTES_MAX): New macro.
4640 * alloc.c (Fmake_string):
4641 * character.c (string_escape_byte8):
4642 * coding.c (coding_alloc_by_realloc):
4643 * doprnt.c (doprnt):
4644 * editfns.c (Fformat):
4645 * eval.c (verror):
4646 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4647 since they may not be the same number.
4648 * editfns.c (Finsert_char):
4649 * fileio.c (Finsert_file_contents):
4650 Likewise for BUF_BYTES_MAX.
4651
dd52fcea
PE
4652 * image.c: Use ptrdiff_t, not int, for sizes.
4653 (slurp_file): Switch from int to ptrdiff_t.
4654 All uses changed.
4655 (slurp_file): Check that file size fits in both size_t (for
4656 malloc) and ptrdiff_t (for sanity and safety).
4657
7f9bbdbb
PE
4658 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4659 if b->modtime has its maximal value.
4660
dfe18f82
PE
4661 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4662
84acfcf0
PE
4663 Don't assume time_t can fit into int.
4664 * buffer.h (struct buffer.modtime): Now time_t, not int.
4665 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4666 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4667
ccd9a01a
PE
4668 Minor fixes for signed vs unsigned integers.
4669 * character.h (MAYBE_UNIFY_CHAR):
4670 * charset.c (maybe_unify_char):
4671 * keyboard.c (read_char, reorder_modifiers):
4672 XINT -> XFASTINT, since the integer must be nonnegative.
4673 * ftfont.c (ftfont_spec_pattern):
4674 * keymap.c (access_keymap, silly_event_symbol_error):
4675 XUINT -> XFASTINT, since the integer must be nonnegative.
4676 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4677 since it makes no difference and we prefer signed.
4678 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4679 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4680 nonnegative.
4681
d6d100dd
SM
46822011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4683
4684 * window.h (Fwindow_frame): Declare.
4685
2b6148e4
PE
46862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4687
4688 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4689 (SPARE_MEMORY): Always define.
4690 (LARGE_REQUEST): Remove.
4691 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4692
f230ecc9
MR
46932011-06-06 Martin Rudalics <rudalics@gmx.at>
4694
727e958e
MR
4695 * lisp.h: Move EXFUNS for Fframe_root_window,
4696 Fframe_first_window and Fset_frame_selected_window to window.h.
4697
4698 * window.h: Move EXFUNS for Fframe_root_window,
4699 Fframe_first_window and Fset_frame_selected_window here from
4700 lisp.h.
4701
4702 * frame.c (Fwindow_frame, Fframe_first_window)
4703 (Fframe_root_window, Fframe_selected_window)
4704 (Fset_frame_selected_window): Move to window.c.
4705 (Factive_minibuffer_window): Move to minibuf.c.
4706 (Fother_visible_frames_p): New function.
4707
4708 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4709
f230ecc9
MR
4710 * window.c (decode_window, decode_any_window): Move up in code.
4711 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4712 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4713 (Fwindow_buffer): Move up and rewrite doc-string.
4714 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4715 (Fwindow_prev): New functions.
727e958e
MR
4716 (Fwindow_frame): Move here from frame.c. Accept any window as
4717 argument.
4718 (Fframe_root_window, Fframe_first_window)
4719 (Fframe_selected_window): Move here from frame.c. Accept frame
4720 or arbitrary window as argument. Update doc-strings.
4721 (Fminibuffer_window): Move up in code.
4722 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4723 (Fset_frame_selected_window): Move here from frame.c.
4724 Marginal rewrite.
727e958e
MR
4725 (Fselected_window, select_window, Fselect_window): Move up in
4726 code. Minor doc-string fixes.
f230ecc9 4727
4d09bcf6
PE
47282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4729
4730 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4731 Do not assume that spare memory exists; that assumption is valid
4732 only if SYSTEM_MALLOC.
4733 (LARGE_REQUEST): New macro, so that the issue of large requests
4734 is separated from the issue of spare memory.
4735
810928a2
AS
47362011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4737
172418ad
AS
4738 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4739 format. (Bug#8806)
4740
43f862f7
AS
4741 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4742
810928a2
AS
4743 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4744 before statements.
4745
a059fe24
JD
47462011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4747
4748 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4749
4750 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4751
4752 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4753 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4754
989bf368
JB
47552011-06-05 Juanma Barranquero <lekktu@gmail.com>
4756
4757 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4758
4b80f674
CY
47592011-06-04 Chong Yidong <cyd@stupidchicken.com>
4760
4761 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4762 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4763 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4764 New error handlers.
4b80f674
CY
4765 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4766 Obey Vx_select_enable_clipboard_manager. Catch errors in
4767 x_clipboard_manager_save (Bug#8779).
4768 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4769 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4770
99a33b77 47712011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4772
4773 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4774
99a33b77 47752011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4776
4777 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4778 in the current matrix if keep_current_p is non-zero.
4779
8264569d
EZ
47802011-06-04 Eli Zaretskii <eliz@gnu.org>
4781
4782 * bidi.c (bidi_level_of_next_char): Fix last change.
4783
57f97249
EZ
47842011-06-03 Eli Zaretskii <eliz@gnu.org>
4785
fec2107c 4786 Support bidi reordering of text covered by display properties.
57f97249 4787
fec2107c
EZ
4788 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4789 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4790 (bidi_cache_search, bidi_cache_iterator_state)
4791 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4792 (bidi_level_of_next_char, bidi_move_to_visually_next):
4793 Support character positions inside a run of characters covered by a
fec2107c
EZ
4794 display string.
4795 (bidi_paragraph_init, bidi_resolve_explicit_1)
4796 (bidi_level_of_next_char): Call bidi_fetch_char and
4797 bidi_fetch_char_advance instead of FETCH_CHAR and
4798 FETCH_CHAR_ADVANCE.
4799 (bidi_init_it): Initialize new members.
4800 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4801 definitions.
4802 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4803 instead of using explicit *_CHAR codes.
d6d100dd
SM
4804 (bidi_resolve_explicit, bidi_resolve_weak):
4805 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4806 bidirectional text is supported only in multibyte buffers.
4807 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4808 it to initialize the frame_window_p member of struct bidi_it.
4809 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4810 (bidi_resolve_explicit, bidi_resolve_weak)
4811 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4812 bidi_it->nchars is non-positive.
4813 (bidi_level_of_next_char): Don't try to lookup the cache for the
4814 next/previous character if nothing is cached there yet, or if we
4815 were just reseat()'ed to a new position.
c40e2fb2 4816
0e14fe90
EZ
4817 * xdisp.c (set_cursor_from_row): Set start and stop points
4818 according to the row's direction when priming the loop that looks
4819 for the glyph on which to display cursor.
4820 (single_display_spec_intangible_p): Function deleted.
4821 (display_prop_intangible_p): Reimplement to call
4822 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4823 Accept 3 additional arguments needed by handle_display_spec.
4824 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4825 values: lists, `(when COND...)' forms, etc.
4826 (single_display_spec_string_p): Support property values that are
4827 lists with the argument STRING its top-level element.
4828 (display_prop_string_p): Fix the condition for processing a
4829 property that is a list to be consistent with handle_display_spec.
fec2107c 4830 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4831 last portion of handle_display_prop.
4832 (compute_display_string_pos): Accept additional argument
4833 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4834 value of a `display' property is a "replacing spec".
4835 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4836 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4837 the display property, but just return a value indicating whether
4838 the display property will replace the characters it covers.
4839 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4840 frame_window_p members of struct bidi_it.
d6d100dd
SM
4841 (compute_display_string_pos, compute_display_string_end):
4842 New functions.
fec2107c
EZ
4843 (push_it): Accept second argument POSITION, where pop_it should
4844 jump to continue iteration.
4845 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4846
fec2107c
EZ
4847 * keyboard.c (adjust_point_for_property): Adjust the call to
4848 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4849
4850 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4851 (bidi_init_it): Update prototypes.
4852 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4853 (compute_display_string_pos, compute_display_string_end):
4854 Declare prototypes.
fec2107c
EZ
4855 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4856 EMACS_INT.
fc6f18ce 4857
40087514 48582011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4859
57f53182
PE
4860 Malloc failure behavior now depends on size of allocation.
4861 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4862 * lisp.h: Change signatures accordingly.
4863 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4864 All callers changed. (Bug#8762)
4865
4866 * gnutls.c: Use Emacs's memory allocators.
4867 Without this change, the gnutls library would invoke malloc etc.
4868 directly, which causes problems on non-SYNC_INPUT hosts, and which
4869 runs afoul of improving memory_full behavior. (Bug#8761)
4870 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4871 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4872 xfree instead of the default malloc, realloc, free.
4873 (Fgnutls_boot): No need to check for memory allocation failure,
4874 since xmalloc does that for us.
4875
ac32cd99 4876 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4877 * category.c (hash_get_category_set):
4878 * ccl.c (ccl_driver):
4879 * charset.c (Fdefine_charset_internal):
4880 * charset.h (struct charset.hash_index):
4881 * composite.c (get_composition_id, gstring_lookup_cache)
4882 (composition_gstring_put_cache):
4883 * composite.h (struct composition.hash_index):
4884 * dispextern.h (struct image.hash):
4885 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4886 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4887 (hashfn_equal, hashfn_user_defined, make_hash_table)
4888 (maybe_resize_hash_table, hash_lookup, hash_put)
4889 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4890 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4891 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4892 * image.c (make_image, search_image_cache, lookup_image)
4893 (xpm_put_color_table_h):
4894 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4895 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4896 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4897 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4898 * alloc.c (allocate_vectorlike):
4899 Check for overflow in vector size calculations.
4900 * ccl.c (ccl_driver):
4901 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4902 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4903 need to be updated by these changes.
40087514
PE
4904 * fns.c (make_hash_table, maybe_resize_hash_table):
4905 Check for integer overflow with large hash tables.
0de4bb68
PE
4906 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4907 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4908 (SXHASH_REDUCE): New macro.
4909 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4910 Use it instead of discarding useful hash info with large hash values.
4911 (sxhash_float): New function.
4912 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4913 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4914 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4915 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4916 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4917 Adjust signatures to match updated version of code.
4918 (consing_since_gc): Now EMACS_INT, since a single hash table can
4919 use more than INT_MAX bytes.
4920
698d32e2
DN
49212011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4922
4923 Make it possible to build with GCC-4.6+ -O2 -flto.
4924
4925 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4926
fd6fa53f
SM
49272011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4928
4929 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4930 Call minibuffer-inactive-mode.
4931
864db017
JB
49322011-05-31 Juanma Barranquero <lekktu@gmail.com>
4933
4934 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4935 Update dependencies.
4936
2ad0baf4
DN
49372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4938
4939 * data.c (init_data): Remove code for UTS, this system is not
4940 supported anymore.
4941
4fcc2638
DN
49422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4943
4944 Don't force ./temacs to start in terminal mode.
4945
4946 * frame.c (make_initial_frame): Initialize faces in all cases, not
4947 only when CANNOT_DUMP is defined.
4948 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4949
c56e0fd5
DN
49502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4951
4952 * dispnew.c (add_window_display_history): Use const for the string
4953 pointer. Remove declaration, not needed.
4954
333d54da 49552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4956
55d4c1b2 4957 Use 'inline', not 'INLINE'.
333d54da 4958 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4959 * alloc.c, fontset.c (INLINE): Remove.
4960 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4961 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4962 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4963 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4964 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4965
738db178
DN
49662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4967
4968 Make it possible to run ./temacs.
4969
4970 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4971 syms_of_callproc does the same thing. Remove test for
4972 "initialized", do it in the caller.
4973 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4974
620c53a6
SM
49752011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4976
4977 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4978 (read_minibuf): Use get_minibuffer.
4979 (syms_of_minibuf): Use DEFSYM.
4980 (Qmetadata): New var.
4981 * data.c (Qbuffer): Don't make it static.
4982 (syms_of_data): Use DEFSYM.
4983
e003a292
PE
49842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4985
4986 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4987 (CCL_CODE_MIN): New macro.
4988
ed008a6d
PE
49892011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4990
3687c2ef
PE
4991 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4992
ed008a6d
PE
4993 * eval.c (Qdebug): Now static.
4994 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4995 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4996 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4997
d66c4c7c
CY
49982011-05-29 Chong Yidong <cyd@stupidchicken.com>
4999
5000 * image.c: Various fixes to ImageMagick code comments.
5001 (Fimagemagick_types): Doc fix.
5002
5fbc2025
PE
50032011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5004
0196f88a
PE
5005 Minor fixes prompted by GCC 4.6.0 warnings.
5006
5007 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5008
5fbc2025
PE
5009 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5010 (x_clipboard_manager_save_all): Move extern decl to ...
5011 * xterm.h: ... here, so that it can be checked for consistency.
5012
1dd3c2d9
CY
50132011-05-29 Chong Yidong <cyd@stupidchicken.com>
5014
5015 * xselect.c (x_clipboard_manager_save_frame)
5016 (x_clipboard_manager_save_all): New functions.
5017 (Fx_clipboard_manager_save): Lisp function deleted.
5018
5019 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5020 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5021
5022 * xterm.h: Update prototype.
5023
5ba6571d
WX
50242011-05-28 William Xu <william.xwl@gmail.com>
5025
5026 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5027 exiting (Bug#8239).
5028
3eaff834
JM
50292011-05-28 Jim Meyering <meyering@redhat.com>
5030
e1900994 5031 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5032 * fns.c (to_uchar): Define.
5033 (crypto_hash_function): Use it to convert some newly-signed
5034 variables to unsigned, to avoid sign-extension bugs. For example,
5035 without this change, (md5 "truc") would evaluate to
5036 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5037 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5038 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5039
0f6990a7
PE
50402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5041
5042 Integer overflow fixes.
c8a9ca5a 5043
08686060
PE
5044 * dbusbind.c: Serial number integer overflow fixes.
5045 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5046 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5047 to hold a serial number that is too large for a fixnum.
5048 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5049 Check for serial numbers out of range. Decode any serial number
59568bf0 5050 that was so large that it became a float. (Bug#8722)
08686060 5051
2d1fc3c7
PE
5052 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5053 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5054 Use XFASTINT rather than XUINT when numbers are nonnegative.
5055 (xd_append_arg, Fdbus_method_return_internal):
5056 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5057 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5058 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5059 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5060 (Bug#8722)
2d1fc3c7 5061
c8a9ca5a
PE
5062 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5063
519e1d69
PE
5064 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5065
30569699
PE
5066 ccl: add integer overflow checks
5067 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5068 (IN_INT_RANGE): New macros.
5069 (ccl_driver): Use them to check for integer overflow when
5070 decoding a CCL program. Many of the new checks are whether XINT (x)
5071 fits in int; it doesn't always, on 64-bit hosts. The new version
5072 doesn't catch all possible integer overflows, but it's an
847044ea 5073 improvement. (Bug#8719)
30569699 5074
c11285dc
PE
5075 * alloc.c (make_event_array): Use XINT, not XUINT.
5076 There's no need for unsigned here.
5077
fdccd48e
PE
5078 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5079 This follows up to the 2011-05-06 change that substituted uintptr_t
5080 for EMACS_INT. This case wasn't caught back then.
5081
37910ab2
PE
5082 Rework Fformat to avoid integer overflow issues.
5083 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5084 now (part of C89). Include <verify.h>.
5085 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5086 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5087 (Fformat): Avoid the prepass trying to compute sizes; it was only
5088 approximate and thus did not catch overflow reliably. Instead, walk
5089 through the format just once, formatting and computing sizes as we go,
5090 checking for integer overflow at every step, and allocating a larger
5091 buffer as needed. Keep track separately whether the format is
5092 multibyte. Keep only the most-recently calculated precision, rather
5093 than them all. Record whether each argument has been converted to
5094 string. Use EMACS_INT, not int, for byte and char and arg counts.
5095 Support field widths and precisions larger than INT_MAX. Avoid
5096 sprintf's undefined behavior with conversion specifications such as %#d
5097 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5098 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5099 formatting out-of-range floating point numbers with int
9173deec 5100 formats. (Bug#8668)
37910ab2 5101
2e6578fb
PE
5102 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5103
0ae6bdee
PE
5104 * data.c: Avoid integer truncation in expressions involving floats.
5105 * data.c: Include <intprops.h>.
5106 (arith_driver): When there's an integer overflow in an expression
5107 involving floating point, convert the integers to floating point
5108 so that the resulting value does not suffer from catastrophic
5109 integer truncation. For example, on a 64-bit host (* 4
5110 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5111 Do not rely on undefined behavior after integer overflow.
5112
de883a70
PE
5113 merge count_size_as_multibyte, parse_str_to_multibyte
5114 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5115 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5116 Check for integer overflow.
5117 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5118 since it's now a duplicate of the other. This is more of
5119 a character than a buffer op, so better that it's in character.c.
5120 * fns.c, print.c: Adjust to above changes.
5121
2ff916cb
PE
51222011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5123
5124 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5125
f1b54466
PE
51262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5127
fb1ac845
PE
5128 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5129 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5130 (x_clipboard_manager_save): Now static.
5131 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5132
f1b54466
PE
5133 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5134 (crypto_hash_function): Now static.
5135 Fix pointer signedness problems. Avoid unnecessary initializations.
5136
a9f737ee
CY
51372011-05-27 Chong Yidong <cyd@stupidchicken.com>
5138
5139 * termhooks.h (Vselection_alist): Make it terminal-local.
5140
5141 * terminal.c (create_terminal): Initialize it.
5142
5143 * xselect.c: Support for clipboard managers.
5144 (Vselection_alist): Move to termhooks.h as terminal-local var.
5145 (LOCAL_SELECTION): New macro.
5146 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5147 (symbol_to_x_atom): Remove gratuitous arg.
5148 (x_handle_selection_request, lisp_data_to_selection_data)
5149 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5150 (x_own_selection, x_get_local_selection, x_convert_selection):
5151 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5152 (some_frame_on_display): Delete unused function.
5153 (Fx_own_selection_internal, Fx_get_selection_internal)
5154 (Fx_disown_selection_internal, Fx_selection_owner_p)
5155 (Fx_selection_exists_p): New optional frame arg.
5156 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5157 (x_handle_selection_clear): Don't treat other terminals with the
5158 same keyboard specially. Use the terminal-local Vselection_alist.
5159 (x_clear_frame_selections): Use Frun_hook_with_args.
5160
5161 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5162
5163 * xterm.h: Add support for those atoms.
5164
e067f0c1
CY
51652011-05-26 Chong Yidong <cyd@stupidchicken.com>
5166
5167 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5168 (converted_selections, conversion_fail_tag): New global variables.
5169 (x_selection_request_lisp_error): Free the above.
5170 (x_get_local_selection): Remove unnecessary code.
5171 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5172 of converted selections stored in converted_selections.
5173 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5174 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5175 (x_convert_selection): New function.
5176 (x_handle_selection_event): Simplify.
5177 (x_get_foreign_selection): Don't ignore incoming requests while
5178 waiting for an answer; this will fail when we implement
5179 SAVE_TARGETS, and seems unnecessary anyway.
5180 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5181 (Vx_sent_selection_functions): Doc fix.
5182
0f4aebc0
LL
51832011-05-26 Leo Liu <sdl.web@gmail.com>
5184
5185 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5186
e61124cd
YM
51872011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5188
5189 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5190
5191 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5192 for fringe update if it has periodic bitmap.
ac389d0c 5193 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5194 and fringe_bitmap_periodic_p.
5195
5196 * fringe.c (get_fringe_bitmap_data): New function.
5197 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5198 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5199 row. Mark glyph row for fringe update if periodicity changed.
5200
5201 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5202 for fringe update unless it has periodic bitmap.
5203
f16d9837
KH
52042011-05-25 Kenichi Handa <handa@m17n.org>
5205
5206 * xdisp.c (get_next_display_element): Set correct it->face_id for
5207 a static composition.
5208
e1b90ef6
LL
52092011-05-24 Leo Liu <sdl.web@gmail.com>
5210
5211 * deps.mk (fns.o):
5212 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5213
5214 * fns.c (crypto_hash_function, Fsha1): New function.
5215 (Fmd5): Use crypto_hash_function.
5216 (syms_of_fns): Add Ssha1.
5217
7400048f
PE
52182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5219
5220 * gnutls.c: Remove unused macros.
5221 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5222 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5223 Remove macros that are defined and never used.
5224 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5225
abb71cf4
CY
52262011-05-22 Chong Yidong <cyd@stupidchicken.com>
5227
5228 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5229 (Fx_get_selection_internal): Minor cleanup.
5230 (Fx_own_selection_internal): Rename arguments for consistency with
5231 select.el.
5232
6307db39
PE
52332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5234
5235 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5236
f3d4e0a4
CY
52372011-05-22 Chong Yidong <cyd@stupidchicken.com>
5238
5239 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5240
4d8ade89
YM
52412011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5242
5243 * dispnew.c (scrolling_window): Don't exclude the case that the
5244 last enabled row in the desired matrix touches the bottom boundary.
5245
32078c8d
GM
52462011-05-21 Glenn Morris <rgm@gnu.org>
5247
5248 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5249 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5250 and add some more files.
32078c8d 5251
7285dc67
EZ
52522011-05-20 Eli Zaretskii <eliz@gnu.org>
5253
5254 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5255 report_file_error introduced by the change from 2011-05-07.
5256
89d1bd22
PE
52572011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5258
5259 * systime.h (Time): Define only if emacs is defined.
5260 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5261 where the include path doesn't have X11/X.h by default. See
5262 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5263
e23640bb 52642011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5265
5266 * composite.c (find_automatic_composition): Fix previous change.
5267
b9704ad9
GM
52682011-05-20 Glenn Morris <rgm@gnu.org>
5269
5270 * lisp.mk: New file, split from Makefile.in.
5271 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5272 (shortlisp): Remove.
5273 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5274
4a720484
GM
52752011-05-19 Glenn Morris <rgm@gnu.org>
5276
5277 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5278 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5279 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5280 (lisp): Set the order to that of loadup.el.
5281 (shortlisp): Make it a copy of $lisp.
5282 (SOME_MACHINE_LISP): Remove.
5283 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5284 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5285
a28d4396
KH
52862011-05-18 Kenichi Handa <handa@m17n.org>
5287
5288 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5289 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5290 (find_automatic_composition): Mostly rewrite for efficiency.
5291
a2b1fa8e
JB
52922011-05-18 Juanma Barranquero <lekktu@gmail.com>
5293
5294 * makefile.w32-in: Update dependencies.
5295
8e1f5610
CS
52962011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5297
5298 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5299 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5300
7025ee00 53012011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5302
cdfa6eab
PE
5303 Fix some integer overflow issues, such as string length overflow.
5304
06d6db33
PE
5305 * insdel.c (count_size_as_multibyte): Check for string overflow.
5306
2b4560a8
PE
5307 * character.c (lisp_string_width): Check for string overflow.
5308 Use EMACS_INT, not int, for string indexes and lengths; in
5309 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5310 the resulting string length overflows an EMACS_INT; instead,
5311 report a string overflow if no precision given. When checking for
5312 precision exhaustion, use a check that cannot possibly have
5313 integer overflow. (Bug#8675)
5314 * character.h (lisp_string_width): Adjust to new signature.
5315
cb93f9be
PE
5316 * alloc.c (string_overflow): New function.
5317 (Fmake_string): Use it. This doesn't change behavior, but saves
5318 a few bytes and will simplify future changes.
5319 * character.c (string_escape_byte8): Likewise.
5320 * lisp.h (string_overflow): New decl.
5321
1a1f3366
PE
5322 Fixups, following up to the user-interface timestamp change.
5323 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5324 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5325 * msdos.c (mouse_get_pos): Likewise.
5326 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5327 * w32gui.h (Time): Define by including "systime.h" rather than by
5328 declaring it ourselves. (Bug#8664)
5329
d4e3e4d3
PE
5330 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5331 * image.c (clear_image_cache): Likewise.
5332
f6a24d19
PE
5333 * term.c (term_mouse_position): Don't assume time_t wraparound.
5334
08dc5ae6
PE
5335 Be more systematic about user-interface timestamps.
5336 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5337 and sometimes 'EMACS_UINT', to represent these timestamps.
5338 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5339 This makes the code easier to follow, and makes it easier to catch
5340 integer overflow bugs such as Bug#8664.
5341 * frame.c (Fmouse_position, Fmouse_pixel_position):
5342 Use Time, not unsigned long, for user-interface timestamps.
5343 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5344 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5345 * keyboard.h (last_event_timestamp): Likewise.
5346 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5347 * menu.h (xmenu_show): Likewise.
5348 * term.c (term_mouse_position): Likewise.
5349 * termhooks.h (struct input_event.timestamp): Likewise.
5350 (struct terminal.mouse_position_hook): Likewise.
5351 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5352 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5353 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5354 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5355 what it was before.
5356 * menu.h, termhooks.h: Include "systime.h", for Time.
5357
8e55734a
PE
5358 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5359 Don't assume that the difference between two unsigned long values
5360 can fit into an integer. At this point, we know button_down_time
5361 <= event->timestamp, so the difference must be nonnegative, so
5362 there's no need to cast the result if double-click-time is
5363 nonnegative, as it should be; check that it's nonnegative, just in
5364 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5365 apart (about 25 days). (Bug#8664)
8e55734a 5366
841f1b75 5367 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5368 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5369
3e26f69c
PE
5370 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5371 that always fit in int. Use a sentinel instead of a counter, to
5372 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5373 * frame.h (struct frame): Use int for menu_bar_items_used
5374 instead of EMACS_INT, since it always fits in int.
3e26f69c 5375
5cc152c0
PE
5376 * menu.c (grow_menu_items): Check for int overflow.
5377
d89eb65e
PE
5378 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5379
5235bd3e
PE
5380 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5381 Before, the code was not consistent. These values cannot exceed
5382 2**31 - 1 so there's no need to make them unsigned.
5383 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5384 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5385 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5386 as modifiers.
5387 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5388
bc827e23
PE
5389 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5390 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5391 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5392 presumably because the widths might not match.
5393
78eb494e
PE
5394 * window.c (size_window): Avoid needless test at loop start.
5395
04f2d78b
CB
53962011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5397
5398 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5399
d2fc7e3d 54002011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5401
5402 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5403
d2fc7e3d 54042011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5405
5406 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5407 `width' to `bar_area_x' and `bar_area_width', respectively.
5408 (x_scroll_run): Take account of fringe background extension.
5409
04f2d78b
CB
5410 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5411 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5412 `bar_area_width', respectively.
5413 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5414 background extension.
5415
79b70037
GM
54162011-05-10 Jim Meyering <meyering@redhat.com>
5417
5418 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5419
2f142cc5
JB
54202011-05-10 Juanma Barranquero <lekktu@gmail.com>
5421
5422 * image.c (Finit_image_library): Return t for built-in image types,
5423 like pbm and xbm. (Bug#8640)
5424
57679c86
AS
54252011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5426
5427 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5428
888c9e86
EZ
54292011-05-07 Eli Zaretskii <eliz@gnu.org>
5430
b0512a1d
EZ
5431 * w32console.c (Fset_screen_color): Doc fix.
5432 (Fget_screen_color): New function.
5433 (syms_of_ntterm): Defsubr it.
5434
7285dc67
EZ
5435 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5436 unlink the temporary file if Fcall_process didn't create it in the
5437 first place.
5438 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5439 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5440 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5441 cue to call_process_cleanup not to close that handle.
5442
4d3fcc8e
BK
54432011-05-07 Ben Key <bkey76@gmail.com>
5444
5445 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5446 one of two shell specific rules, either bootstrap-temacs-CMD or
5447 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5448 to the previous implementation of the bootstrap-temacs rule.
5449 The bootstrap-temacs-CMD rule is similar to the previous
5450 implementation of the bootstrap-temacs rule except that it
5451 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5452 variable.
5453
5454 These changes, along with some changes to nt/configure.bat,
5455 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5456 earlier fix to add support for --cflags and --ldflags options
5457 that include quotes so that it works whether make uses cmd or
5458 sh as the shell.
5459
b4289b64
MA
54602011-05-06 Michael Albinus <michael.albinus@gmx.de>
5461
5462 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5463 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5464 is a constant.
5465 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5466 a string. Handle both cases.
5467 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5468 (Fdbus_register_method): Use Qinvalid_function.
5469
af4c0e28
JB
54702011-05-06 Juanma Barranquero <lekktu@gmail.com>
5471
5472 * makefile.w32-in: Update dependencies.
5473 (LISP_H): Add inttypes.h and stdin.h.
5474 (PROCESS_H): Add unistd.h.
5475
c51453d9
EZ
54762011-05-06 Eli Zaretskii <eliz@gnu.org>
5477
5478 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5479 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5480
8ff0ac3c 54812011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5482
4c4b566b
PE
5483 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5484
aab2b9b5
PE
5485 * term.c (vfatal): Remove stray call to va_end.
5486 It's not needed and the C Standard doesn't allow it here anyway.
5487
c378da0b
PE
5488 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5489 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5490
288b08c7
PE
5491 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5492 bytes.
5493
e3601888
PE
5494 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5495
db6c0e74
PE
5496 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5497
dd5963ea
PE
5498 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5499
88c9450f
PE
5500 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5501
2f9442b8
PE
5502 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5503
c032b5f8
PE
5504 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5505 * charset.c (Fdefine_charset_internal): Don't initialize
5506 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5507 32-bit int (Bug#8600).
a108c10b
PE
5508
5509 * lread.c (read_integer): Be more consistent with string-to-number.
5510 Use string_to_number to do the actual conversion; this avoids
5511 rounding errors and fixes some other screwups. Without this fix,
5512 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5513 (digit_to_number): Move earlier, for benefit of read_integer.
5514 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5515 not a digit in any supported base. (Bug#8602)
a108c10b 5516
ad5f9eea
PE
5517 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5518
aec1708a
PE
5519 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5520 to match comment at start of function. This also removes a
5521 GCC warning about overflow in a 32+64-bit port.
5522
47be4ab5
PE
5523 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5524
371cac43
PE
5525 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5526 Reported by Stefan Monnier in
5527 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5528 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5529 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5530
d01a7826
PE
5531 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5532 (EMACS_UINTPTR): Likewise, with uintptr_t.
5533
7fd47d5c
PE
5534 * lisp.h: Prefer 64-bit EMACS_INT if available.
5535 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5536 on 32-bit hosts that have 64-bit int, so that they can access
5537 large files.
122b0c86
PE
5538 However, temporarily disable this change unless the temporary
5539 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5540
8727937b
PE
5541 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5542
8ac068ac
PE
5543 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5544 This removes an assumption that EMACS_INT and long are the same
5545 width as pointers. The assumption is true for Emacs porting targets
5546 now, but we want to make other targets possible.
5547 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5548 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5549 In the rest of the code, change types of integers that hold casted
5550 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5551 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5552 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5553 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5554 No need to cast type when ORing.
5555 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5556 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5557 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5558 assume EMACS_INT is the same width as char *.
5559 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5560 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5561 Remove no-longer-needed casts.
5562 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5563 (xg_tool_bar_help_callback, xg_make_tool_item):
5564 Use EMACS_INTPTR to hold an integer
5565 that will be cast to void *; this can avoid a GCC warning
5566 if EMACS_INT is not the same width as void *.
5567 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5568 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5569 (current_message_1, set_message_1):
5570 Use a local to convert to proper width without a cast.
5571 * xmenu.c (dialog_selection_callback): Likewise.
5572
ede49d71
PE
5573 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5574 Also, don't assume VALBITS / RAND_BITS is less than 5,
5575 and don't rely on undefined behavior when shifting a 1 left into
5576 the sign bit.
5577 * lisp.h (get_random): Change signature to match.
5578
2f30ecd0
PE
5579 * lread.c (hash_string): Use size_t, not int, for hash computation.
5580 Normally we prefer signed values; but hashing is special, because
5581 it's better to use unsigned division on hash table sizes so that
5582 the remainder is nonnegative. Also, size_t is the natural width
5583 for hashing into memory. The previous code used 'int', which doesn't
5584 retain enough info to hash well into very large tables.
5585 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5586
2a866e7b
PE
5587 * dbusbind.c: Don't possibly lose pointer info when converting.
5588 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5589 Use XPNTR rather than XHASH, so that the high-order bits of
5590 the pointer aren't lost when converting through void *.
5591
51639eac
PE
5592 * eval.c (Fautoload): Don't double-shift a pointer.
5593
92394119
PE
5594 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5595
dbdb9a7c
JB
55962011-05-06 Juanma Barranquero <lekktu@gmail.com>
5597
5598 * gnutls.c (DEF_GNUTLS_FN):
5599 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5600
db7a0b4f
AS
56012011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5602
5603 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5604 marker. (Bug#8610)
5605
f7ff1b0f 56062011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5607
5608 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5609 New version that can reserve upto 2GB of heap space.
5610
f7ff1b0f 56112011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5612
5613 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5614
639c109b
TZ
56152011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5616
5617 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5618 `gnutls_certificate_set_x509_key_file'.
5619
d2127135
JB
56202011-05-05 Juanma Barranquero <lekktu@gmail.com>
5621
5622 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5623 Update dependencies.
5624
e968f4f3
JB
56252011-05-04 Juanma Barranquero <lekktu@gmail.com>
5626
5627 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5628 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5629 Remove unused parameter `fildes'.
5630 * process.c (read_process_output, send_process): Don't pass it.
5631
84d358f0
JB
56322011-05-04 Juanma Barranquero <lekktu@gmail.com>
5633
5634 Fix previous change: the library cache is defined in w32.c.
5635 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5636 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5637
0898ca10
JB
56382011-05-04 Juanma Barranquero <lekktu@gmail.com>
5639
5640 Implement dynamic loading of GnuTLS on Windows.
5641
5642 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5643 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5644 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5645 Declare.
5646
5647 * gnutls.c (Qgnutls_dll): Define.
5648 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5649 (gnutls_*): Declare function pointers.
5650 (init_gnutls_functions): New function to initialize function pointers.
5651 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5652 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5653 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5654 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5655 (emacs_gnutls_write, emacs_gnutls_read)
5656 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5657 (Fgnutls_available_p): New function.
5658 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5659 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5660 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5661
5662 * image.c: Include w32.h.
5663 (Vimage_type_cache): Delete.
5664 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5665 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5666 (w32_delayed_load): Move to w32.c.
5667
5668 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5669
5670 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5671 (w32_delayed_load): Move from image.c. When loading a library, record
5672 its filename in the :loaded-from property of the library id.
5673 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5674 Initialize and staticpro them.
5675 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5676
5677 * process.c: Include lisp.h before w32.h, not after.
5678 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5679 instead of gnutls_record_check_pending.
5680
5681 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5682
ff4de4aa
TZ
56832011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5684
5685 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5686 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5687 as passed in.
5688
abe95abb
JD
56892011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5690
5691 * xterm.c (x_set_frame_alpha): Do not set property on anything
5692 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5693
e16e55d4
JB
56942011-05-02 Juanma Barranquero <lekktu@gmail.com>
5695
5696 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5697
bafcf6a5
JB
56982011-05-02 Juanma Barranquero <lekktu@gmail.com>
5699
5700 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5701 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5702 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5703 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5704 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5705 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5706 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5707 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5708 (Qgnutls_bootprop_callbacks_verify): Make static.
5709
e7a6747f
AS
57102011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5711
19ed11ba
AS
5712 * callproc.c: Indentation fixup.
5713
e7a6747f 5714 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5715 (wait_for_termination, interruptible_wait_for_termination):
5716 Move after wait_for_termination_1.
e7a6747f 5717
1ef14cb4
LMI
57182011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5719
5720 * sysdep.c (interruptible_wait_for_termination): New function
5721 which is like wait_for_termination, but allows keyboard
5722 interruptions.
5723
5724 * callproc.c (Fcall_process): Add (:file "file") as an option for
5725 the STDOUT buffer.
5726 (Fcall_process_region): Ditto.
5727
330d880c
EZ
57282011-04-30 Eli Zaretskii <eliz@gnu.org>
5729
8db90b73
EZ
5730 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5731 rather than `XVECTOR (FOO)->size'.
5732
330d880c
EZ
5733 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5734 inttypes.h, as a gnulib replacement is used if it not available in
5735 system headers.
5736
15cbd324
EZ
57372011-04-21 Eli Zaretskii <eliz@gnu.org>
5738
5739 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5740 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5741 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5742
5743 * coding.c (coding_alloc_by_realloc): Error out if destination
5744 will grow beyond MOST_POSITIVE_FIXNUM.
5745 (decode_coding_emacs_mule): Abort if there isn't enough place in
5746 charbuf for the composition carryover bytes. Reserve an extra
5747 space for up to 2 characters produced in a loop.
5748 (decode_coding_iso_2022): Abort if there isn't enough place in
5749 charbuf for the composition carryover bytes.
5750
57512011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5752
ae940cca
EZ
5753 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5754 aborting when %lld or %lll format is passed.
5755 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5756 %llo or %llx format is passed. (Bug#8545)
5757
03ab8921
EZ
5758 * window.c (window_scroll_line_based): Use a marker instead of
5759 simple variables to record original value of point. (Bug#7952)
5760
afda1437
EZ
5761 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5762 produced by %s or %c overflows available buffer space. (Bug#8545)
5763
f76dee0c
PE
57642011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5765
5766 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5767 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5768
fdc5744d
JB
57692011-04-28 Juanma Barranquero <lekktu@gmail.com>
5770
5771 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5772
638f053a
JB
57732011-04-28 Juanma Barranquero <lekktu@gmail.com>
5774
5775 * keyboard.c (Qdelayed_warnings_hook): Define.
5776 (command_loop_1): Run `delayed-warnings-hook'
5777 if Vdelayed_warnings_list is non-nil.
5778 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5779 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5780
d178f871
EZ
57812011-04-28 Eli Zaretskii <eliz@gnu.org>
5782
5783 * doprnt.c (doprnt): Don't return value smaller than the buffer
5784 size if the message was truncated. (Bug#8545).
5785
b124fd93
JB
57862011-04-28 Juanma Barranquero <lekktu@gmail.com>
5787
5788 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5789 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5790
e810457d
PE
57912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5792
5793 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5794
ea51cceb
JB
57952011-04-27 Juanma Barranquero <lekktu@gmail.com>
5796
5797 * makefile.w32-in: Update dependencies.
5798
94dcfacf
EZ
57992011-04-27 Eli Zaretskii <eliz@gnu.org>
5800
5801 Improve `doprnt' and its usage. (Bug#8545)
5802 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5803 `format_end'. Remove support for %l as a conversion specifier.
5804 Don't use xrealloc. Improve diagnostics when the %l size modifier
5805 is used. Update the commentary.
5806
5807 * eval.c (verror): Simplify calculation of size_t.
5808
5809 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5810 messages.
5811
f61f41d7
PE
58122011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5813
5814 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5815 change.
5816
96fb4434
PE
58172011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5818
5819 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5820 This makes this file independent of the recent pseudovector change.
5821
671875da 58222011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5823
69e9b5a3
PE
5824 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5825
b5f869a7 5826 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5827 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5828 Remove unused local.
c8926152 5829 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5830
841a1577 5831 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5832 GCC 4.6.0 optimizes based on type-based alias analysis.
5833 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5834 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5835 != &v->size, and therefore "v->size = 1; b->size = 2; return
5836 v->size;" must therefore return 1. This assumption is incorrect
5837 for Emacs, since it type-puns struct Lisp_Vector * with many other
5838 types. To fix this problem, this patch adds a new type struct
f904488f 5839 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5840 and pseudovectors, and helps optimizing compilers not get fooled
5841 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5842 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5843 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5844 the size member.
eab3844f
PE
5845 (XSETPVECTYPE): Rewrite in terms of new macro.
5846 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5847 This is a bit clearer, and further avoids the possibility of
5848 undesirable aliasing.
5849 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5850 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5851 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5852 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5853 (ASIZE): Now uses header.size rather than size.
5854 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5855 to avoid the hassle of writing XVECTOR (foo)->header.size.
5856 (struct vectorlike_header): New type.
eab3844f
PE
5857 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5858 object, to help avoid aliasing.
5859 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5860 (SUBRP): Likewise, since Lisp_Subr is a special case.
5861 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5862 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5863 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5864 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5865 changed to be "header.size" and "header.next".
5866 * buffer.h (struct buffer): Likewise.
5867 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5868 * frame.h (struct frame): Likewise.
5869 * process.h (struct Lisp_Process): Likewise.
5870 * termhooks.h (struct terminal): Likewise.
5871 * window.c (struct save_window_data, struct saved_window): Likewise.
5872 * window.h (struct window): Likewise.
5873 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5874 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5875 * buffer.c (init_buffer_once): Likewise.
5876 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5877 special case.
5878 * process.c (Fformat_network_address): Use local var for size,
5879 for brevity.
5880
0df1eac5
PE
5881 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5882
847ab9d1 5883 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5884 * data.c (atof): Remove decl; no longer used or needed.
5885 (digit_to_number): Move to lread.c.
5886 (Fstring_to_number): Use new string_to_number function, to be
5887 consistent with how the Lisp reader treats infinities and NaNs.
5888 Do not assume that floating-point numbers represent EMACS_INT
5889 without losing information; this is not true on most 64-bit hosts.
5890 Avoid double-rounding errors, by insisting on integers when
5891 parsing non-base-10 numbers, as the documentation specifies.
5892 * lisp.h (string_to_number): New decl, replacing ...
5893 (isfloat_string): Remove.
bc0a5c13 5894 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5895 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5896 appears to have been a coding error. Similarly, do not accept
5897 strings like +-1e0 as floating point numbers. Do not report
5898 overflow for integer overflows unless the base is not 10 which
5899 means we have no simple and reliable way to continue.
5900 Break out the floating-point parsing into a new
5901 function string_to_number, so that Fstring_to_number parses
5902 floating point numbers consistently with the Lisp reader.
04f2d78b 5903 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5904 (E_CHAR, EXP_INT): Remove, replacing with ...
5905 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5906 (string_to_number): New function, replacing isfloat_string.
5907 This function checks for valid syntax and produces the resulting
5908 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5909 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5910 so that overflow for non-base-10 numbers is reported only when
5911 there's no portable and simple way to convert to floating point.
452f4150 5912
67769ffc
PE
5913 * textprop.c (set_text_properties_1): Rewrite for clarity,
5914 and to avoid GCC warning about integer overflow.
5915
c20db43f
PE
5916 * intervals.h (struct interval): Use EMACS_INT for members
5917 where EMACS_UINT might cause problems. See
5918 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5919 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5920 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5921 All uses changed.
37aa2f85
PE
5922 (offset_intervals): Tell GCC not to worry about length overflow
5923 when negating a negative length.
c20db43f 5924
2538aa2f
PE
5925 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5926 (overrun_check_free): Likewise.
5927
f2d3008d
PE
5928 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5929 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5930 word size.
5931
ec8df744
PE
5932 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5933 (gnutls_make_error): Rename local to avoid shadowing.
5934 (gnutls_emacs_global_deinit): ifdef out; not used.
5935 (Fgnutls_boot): Use const for pointer to readonly storage.
5936 Comment out unused local. Fix pointer signedness problems.
5937
640ee02d
PE
5938 * lread.c (openp): Don't stuff size_t into an 'int'.
5939 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5940 about possible signed overflow.
5941
6048fb2a
PE
5942 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5943 (GDK_KEY_g): Don't define if already defined.
5944 (xg_prepare_tooltip): Avoid pointer signedness problem.
5945 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5946
fa3c87e1
PE
5947 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5948 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5949
2172544b
PE
5950 * xfns.c (Fx_window_property): Simplify a bit,
5951 to make a bit faster and to avoid GCC 4.6.0 warning.
5952 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5953
9b821a21
PE
5954 * fns.c (internal_equal): Don't assume size_t fits in int.
5955
3c616cfa
PE
5956 * alloc.c (compact_small_strings): Tighten assertion a little.
5957
c2982e87
PE
5958 Replace pEd with more-general pI, and fix some printf arg casts.
5959 * lisp.h (pI): New macro, generalizing old pEd macro to other
5960 conversion specifiers. For example, use "...%"pI"d..." rather
5961 than "...%"pEd"...".
5962 (pEd): Remove. All uses replaced with similar uses of pI.
5963 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5964 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5965 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5966 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5967 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5968 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5969 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5970 64-bit hosts.
5971 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5972 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5973 * print.c (safe_debug_print, print_object): Likewise.
5974 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5975 to int.
6f04d126
PE
5976 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5977 avoiding the 0 flag, which is not portable.
c2982e87
PE
5978 * process.c (Fmake_network_process): Use pI to avoid cast.
5979 * region-cache.c (pp_cache): Likewise.
5980 * xdisp.c (decode_mode_spec): Likewise.
5981 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5982 behavior on 64-bit hosts with printf arg.
6f04d126 5983 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5984 (x_stop_queuing_selection_requests): Likewise.
5985 (x_get_window_property): Don't truncate byte count to an 'int'
5986 when tracing.
0b432f21 5987
5e073ec7
PE
5988 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5989 here, since it parses constructs like leading '-' and spaces,
5990 which are not wanted; and it overflows with large numbers.
5991 Instead, simply match F[0-9]+, which is what is wanted anyway.
5992
36372bf9
PE
5993 * alloc.c: Remove unportable assumptions about struct layout.
5994 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5995 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5996 (allocate_vectorlike, make_pure_vector): Use the new macros,
5997 plus offsetof, to remove unportable assumptions about struct layout.
5998 These assumptions hold on all porting targets that I know of, but
5999 they are not guaranteed, they're easy to remove, and removing them
6000 makes further changes easier.
6001
0b432f21
PE
6002 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6003 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6004 (string_overrun_cookie): Now const. Use initializers that
6005 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6006 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6007 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6008 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6009 multiple of sizeof (EMACS_INT); it need not be, if
6010 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6011 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6012
895009e1
JB
60132011-04-26 Juanma Barranquero <lekktu@gmail.com>
6014
6015 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6016
6a7a1b0b
TZ
60172011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6018
6019 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6020 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6021 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6022
841a1577 60232011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6024
6025 * lisp.h (Qdebug): List symbol.
895009e1 6026 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6027 * keyboard.c (debug-on-event): New variable.
6028 (handle_user_signal): Break into debugger when debug-on-event
6029 matches the current signal symbol.
6030
f2d3ba6f
DN
60312011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6032
6033 * alloc.c (check_sblock, check_string_bytes)
6034 (check_string_free_list): Convert to standard C.
6035
42ce4c63
TZ
60362011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6037
6038 * w32.c (emacs_gnutls_push): Fix typo.
6039
825cd63c
EZ
60402011-04-25 Eli Zaretskii <eliz@gnu.org>
6041
fb11d64d
EZ
6042 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6043 "cast to pointer from integer of different size".
6044
825cd63c
EZ
6045 Improve doprnt and its use in verror. (Bug#8545)
6046 * doprnt.c (doprnt): Document the set of format control sequences
6047 supported by the function. Use SAFE_ALLOCA instead of always
6048 using `alloca'.
6049
6050 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6051 is one byte too soon. Don't use xrealloc; instead xfree and
6052 xmalloc anew.
6053
e061a11b
TZ
60542011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6055
6056 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6057 callbacks stage.
6058
6059 * gnutls.c: Renamed global_initialized to
6060 gnutls_global_initialized. Added internals for the
6061 :verify-hostname-error, :verify-error, and :verify-flags
6062 parameters of `gnutls-boot' and documented those parameters in the
6063 docstring. Start callback support.
9173deec
JB
6064 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6065 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6066 on error. Return error code.
e061a11b
TZ
6067 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6068 (emacs_gnutls_read): Likewise.
6069 (Fgnutls_boot): Return handshake error code.
6070 (emacs_gnutls_handle_error): New function.
6071 (wsaerror_to_errno): Likewise.
6072
6073 * w32.h (emacs_gnutls_pull): Add prototype.
6074 (emacs_gnutls_push): Likewise.
6075
6076 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6077 (emacs_gnutls_push): Likewise.
6078
60792011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6080
6081 * process.c (wait_reading_process_output): Check if GnuTLS
6082 buffered some data internally if no FDs are set for TLS
6083 connections.
6084
6085 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6086 (LIBS): Link to USER_LIBS.
6087 ($(BLD)/gnutls.$(0)): New target.
6088
fa6996bc
EZ
60892011-04-24 Eli Zaretskii <eliz@gnu.org>
6090
eb35682e
EZ
6091 * xdisp.c (handle_single_display_spec): Rename the
6092 display_replaced_before_p argument into display_replaced_p, to
6093 make it consistent with the commentary. Fix typos in the
6094 commentary.
6095
e2ad650c
EZ
6096 * textprop.c (syms_of_textprop): Remove dead code.
6097 (copy_text_properties): Delete obsolete commentary about an
6098 interface that was deleted long ago. Fix typos in the description
6099 of arguments.
6100
1b2de274
EZ
6101 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6102 to changes in oldXMenu/XMenu.h from 2011-04-16.
6103 <menu_help_message, prev_menu_help_message>: Constify.
6104 (IT_menu_make_room): menu->help_text is now `const char **';
6105 adjust.
6106
6107 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6108 to changes in oldXMenu/XMenu.h from 2011-04-16.
6109 (struct XMenu): Declare `help_text' `const char **'.
6110
6111 * xfaces.c <Qunspecified>: Make extern again.
6112
6113 * syntax.c: Include sys/types.h before including regex.h, as
6114 required by Posix.
6115
762b15be
EZ
6116 * doc.c (get_doc_string): Improve the format passed to `error'.
6117
6118 * doprnt.c (doprnt): Improve commentary.
6119
6120 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6121
6122 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6123 them with etags.
6124
f1052e5d
EZ
6125 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6126 changes in globals.h immediately force recompilation.
762b15be
EZ
6127 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6128 $(CURDIR)/s/ms-w32.h.
6129 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6130
fa6996bc
EZ
6131 * character.c (Fchar_direction): Function deleted.
6132 (syms_of_character): Don't defsubr it.
6133 <char-direction-table>: Deleted.
6134
e6c3da20
EZ
61352011-04-23 Eli Zaretskii <eliz@gnu.org>
6136
6137 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6138 * doprnt.c: Include limits.h.
6139 (SIZE_MAX): New macro.
04f2d78b
CB
6140 (doprnt): Return a size_t value. 2nd arg is now size_t.
6141 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6142 Improve overflow protection. Support `l' modifier for integer
6143 conversions. Support %l conversion. Don't assume an EMACS_INT
6144 argument for integer conversions and for %c.
6145
6146 * lisp.h (doprnt): Restore prototype.
6147
6148 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6149 $(SRC)/character.h.
6150
6151 * Makefile.in (base_obj): Add back doprnt.o.
6152
6153 * deps.mk (doprnt.o): Add back prerequisites.
6154 (callint.o): Depend on character.h.
6155
6156 * eval.c (internal_lisp_condition_case): Include the handler
6157 representation in the error message.
6158 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6159 when breaking from the loop.
6160
6161 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6162
6163 * callint.c (Fcall_interactively): When displaying error message
6164 about invalid control letter, pass the character's codepoint, not
6165 a pointer to its multibyte form. Improve display of the character
6166 in octal and display also its hex code.
6167
6168 * character.c (char_string): Use %x to display the (unsigned)
6169 codepoint of an invalid character, to avoid displaying a bogus
6170 negative value.
6171
6172 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6173 `error', not SYMBOL_NAME itself.
6174
6175 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6176 character arguments to `error'.
6177
6178 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6179 to `error' in error message about FINAL_CHAR argument. Make sure
6180 FINAL_CHAR is a character, and use %c when it is passed as
6181 argument to `error'.
6182
4ffd0d6b 61832011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6184
6185 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6186
6187 * w32.c: Include <time.h>.
6188 (sys_localtime): New function.
6189
4ffd0d6b 61902011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6191
6192 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6193
4ffd0d6b 6194 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6195
4ffd0d6b 61962011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6197
4ffd0d6b
GM
6198 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6199 zombies (Bug#8467).
aac0c6e3 6200
04c56954
EZ
62012011-04-19 Eli Zaretskii <eliz@gnu.org>
6202
6203 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6204 gl_state.e_property when gl_state.object is Qt.
6205
6206 * insdel.c (make_gap_larger): Remove limitation of buffer size
6207 to <= INT_MAX.
6208
16a43933
CY
62092011-04-18 Chong Yidong <cyd@stupidchicken.com>
6210
6211 * xdisp.c (lookup_glyphless_char_display)
6212 (produce_glyphless_glyph): Handle cons cell entry in
6213 glyphless-char-display.
6214 (Vglyphless_char_display): Document it.
6215
6216 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6217 glyphless-char-display.
6218
4581706e
CY
62192011-04-17 Chong Yidong <cyd@stupidchicken.com>
6220
6221 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6222
6223 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6224
6225 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6226 definition for no-X builds.
6227
4887c6e2 62282011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6229
fd35b6f9
PE
6230 Static checks with GCC 4.6.0 and non-default toolkits.
6231
5c1ccb01
PE
6232 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6233
006c5daa
PE
6234 * process.c (keyboard_bit_set): Define only if SIGIO.
6235 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6236 (send_process): Repair possible setjmp clobbering.
6237
efc736d3
PE
6238 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6239
4e2fe2e6
PE
6240 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6241
f97334a2
PE
6242 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6243
4e75f29d
PE
6244 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6245 Define only if needed.
6246
90efadd1
PE
6247 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6248 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6249 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6250
3c647824
PE
6251 * dispextern.h (struct redisplay_interface): Rename param
6252 to avoid shadowing.
e264f262 6253 * termhooks.h (struct terminal): Likewise.
761383f4 6254 * xterm.c (xembed_send_message): Likewise.
3c647824 6255
b58c5c4a
PE
6256 * insdel.c (make_gap_smaller): Define only if
6257 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6258
cad59032
PE
6259 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6260 it.
6261
c339dc2e
PE
6262 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6263 so that we aren't warned about unused symbols.
6264
91a3e27b
PE
6265 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6266
399c71d3 6267 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6268
8ffc96f5
PE
6269 * xfns.c (x_real_positions): Mark locals as initialized.
6270
eef9bc79
PE
6271 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6272
098db9dd
PE
6273 * xterm.c: Fix problems found by static analysis with other toolkits.
6274 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6275 (x_dispatch_event): Declare static if USE_GTK, and
6276 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6277 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6278 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6279 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6280 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6281
eb18f6cc
PE
6282 * xmenu.c (menu_help_callback): Pointer type fixes.
6283 Use const pointers when pointing at readonly data. Avoid pointer
6284 signedness clashes.
6285 (FALSE): Remove unused macro.
6286 (update_frame_menubar): Remove unused decl.
6287
1fe72bf8
PE
6288 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6289
60d9e1db
PE
6290 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6291 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6292 (single_menu_item): Rename local to avoid shadowing.
6293
39261c26
PE
6294 * keyboard.c (make_lispy_event): Remove unused local var.
6295
018c5e19
PE
6296 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6297 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6298
63d2b86e
PE
6299 * bitmaps: Change bitmaps from unsigned char back to the X11
6300 compatible char. Avoid the old compiler warnings about
6301 out-of-range initializers by using, for example, '\xab' rather
6302 than 0xab.
6303
aefd87e1
PE
6304 * xgselect.c (xgselect_initialize): Check vs interface
6305 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6306
bf501fb9
PE
6307 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6308
e9829fdf
PE
6309 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6310 to read-only memory.
6311
1086c095
PE
6312 * fns.c (vector): Remove; this old hack is no longer needed.
6313
2baccd04 6314 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6315 Remove unused var.
dde42981 6316 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6317
72391843 6318 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6319
436c16df 6320 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6321 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6322 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6323
92bb796d 6324 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6325 (x_term_init): Remove local to avoid shadowing.
92bb796d 6326
764430a3 6327 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6328
6329 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6330 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6331
d1dfb56c
EZ
63322011-04-16 Eli Zaretskii <eliz@gnu.org>
6333
c4354cb4
EZ
6334 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6335
d1dfb56c
EZ
6336 Fix regex.c, syntax.c and friends for buffers > 2GB.
6337 * syntax.h (struct gl_state_s): Declare character position members
6338 EMACS_INT.
6339
6340 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6341
04f2d78b
CB
6342 * textprop.c (verify_interval_modification, interval_of):
6343 Declare arguments EMACS_INT.
d1dfb56c
EZ
6344
6345 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6346 EMACS_INT.
6347
6348 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6349
6350 * indent.c (Fvertical_motion): Local variable it_start is now
6351 EMACS_INT.
6352
6353 * regex.c (re_match, re_match_2, re_match_2_internal)
6354 (bcmp_translate, regcomp, regexec, print_double_string)
6355 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6356 (re_compile_pattern, re_exec): Declare arguments and local
6357 variables `size_t' and `ssize_t' and return values `regoff_t', as
6358 appropriate.
6359 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6360 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6361 <compile_stack_type>: `size' and `avail' are now `size_t'.
6362
6363 * regex.h <regoff_t>: Use ssize_t, not int.
6364 (re_search, re_search_2, re_match, re_match_2): Arguments that
6365 specify buffer/string position and length are now ssize_t and
6366 size_t. Return type is regoff_t.
6367
613052cd
BK
63682011-04-16 Ben Key <bkey76@gmail.com>
6369
6370 * nsfont.m: Fixed bugs in ns_get_family and
6371 ns_descriptor_to_entity that were caused by using free to
6372 deallocate memory blocks that were allocated by xmalloc (via
6373 xstrdup). This caused Emacs to crash when compiled with
6374 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6375 --enable-checking=xmallocoverrun). xfree is now used to
6376 deallocate these memory blocks.
6377
4170f62f 63782011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6379
71b41406
PE
6380 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6381
9587a89d
PE
6382 emacs_write: Accept and return EMACS_INT for sizes.
6383 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6384 et seq.
6385 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6386 Accept and return EMACS_INT.
6387 (emacs_gnutls_write): Return the number of bytes written on
6388 partial writes.
6389 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6390 (emacs_read, emacs_write): Remove check for negative size, as the
6391 Emacs source code has been audited now.
9587a89d
PE
6392 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6393 (emacs_read, emacs_write): Use it.
273a5f82
PE
6394 * process.c (send_process): Adjust to the new signatures of
6395 emacs_write and emacs_gnutls_write. Do not attempt to store
6396 a byte offset into an 'int'; it might overflow.
9587a89d 6397 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6398
3e047f51
PE
6399 * sound.c: Don't assume sizes fit in 'int'.
6400 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6401 Return EMACS_INT, not int.
3e047f51 6402 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6403 Accept EMACS_INT, not int.
6404 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6405 record read return values.
6406
cc39a9db
BK
64072011-04-15 Ben Key <bkey76@gmail.com>
6408
c9d0ec6d
JB
6409 * keyboard.c (Qundefined): Don't declare static since it is used
6410 in nsfns.m.
6411 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6412 static since they are used in nsfont.m.
cc39a9db 6413
6c60eb9f
SM
64142011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6415
6416 * process.c (Qprocessp): Don't declare static.
6417 * lisp.h (Qprocessp): Declare again.
6418
7990b61a
JB
64192011-04-15 Juanma Barranquero <lekktu@gmail.com>
6420
6421 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6422
5d4cb038
PE
64232011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6424
8bd7b830 6425 Improve C-level modularity by making more things 'static'.
cd64ea1d 6426
e3b27b31
PE
6427 Don't publish debugger-only interfaces to other modules.
6428 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6429 (verify_bytepos, count_markers): Move decls to the only modules
6430 that need them.
6431 * region-cache.h (pp_cache): Likewise.
6432 * window.h (check_all_windows): Likewise.
6433 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6434
5d4cb038
PE
6435 * sysdep.c (croak): Now static, if
6436 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6437 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6438
6439 * alloc.c (refill_memory_reserve): Now static if
6440 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6441 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6442
e87b6180
PE
6443 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6444 Define only if USE_LUCID.
6445
ac64929e
PE
6446 * xrdb.c (x_customization_string, x_rm_string): Now static.
6447
6f37259d
PE
6448 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6449 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6450
1683e3ab
PE
6451 * xdisp.c (draw_row_with_mouse_face): Now static.
6452 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6453
de9c2632
PE
6454 * window.h (check_all_windows): Mark externally visible.
6455
2b96acb7
PE
6456 * window.c (window_deletion_count): Now static.
6457
6458 * undo.c: Make symbols static if they're not exported.
6459 (last_undo_buffer, last_boundary_position, pending_boundary):
6460 Now static.
6461
50436f33
PE
6462 * textprop.c (interval_insert_behind_hooks): Now static.
6463 (interval_insert_in_front_hooks): Likewise.
6464
64520e5c
PE
6465 * term.c: Make symbols static if they're not exported.
6466 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6467 (max_frame_lines, tty_set_terminal_modes):
6468 (tty_reset_terminal_modes, tty_turn_off_highlight):
6469 (get_tty_terminal): Now static.
6470 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6471 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6472 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6473 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6474 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6475
1fa53021
PE
6476 * sysdep.c: Make symbols static if they're not exported.
6477 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6478 Now static.
6479 (sigprocmask_set, full_mask): Remove; unused.
6480 (wait_debugging): Mark as visible.
6481 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6482 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6483
d4b43b22
PE
6484 * syntax.c (syntax_temp): Define only if !__GNUC__.
6485
b7c513d0
PE
6486 * sound.c (current_sound_device, current_sound): Now static.
6487
989b29ad
PE
6488 * search.c (searchbufs, searchbuf_head): Now static.
6489
13a55a78
PE
6490 * scroll.c (scroll_cost): Remove; unused.
6491 * dispextern.h (scroll_cost): Remove decl.
6492
de68a1fc
PE
6493 * region-cache.h (pp_cache): Mark as externally visible.
6494
40ccffa6
PE
6495 * process.c: Make symbols static if they're not exported.
6496 (process_tick, update_tick, create_process, chan_process):
6497 (Vprocess_alist, proc_buffered_char, datagram_access):
6498 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6499 (deactivate_process): Mark defn as static, as well as decl.
6500 * lisp.h (create_process): Remove decl.
6501 * process.h (chan_process, Vprocess_alist): Remove decls.
6502
ad64fc97
PE
6503 * print.c: Make symbols static if they're not exported.
6504 (print_depth, new_backquote_output, being_printed, print_buffer):
6505 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6506 (print_interval, print_number_index, initial_stderr_stream):
6507 Now static.
6508 * lisp.h (Fprinc): Remove decl.
6509 (debug_output_compilation_hack): Mark as externally visible.
6510
adddb265
PE
6511 * sysdep.c (croak): Move decl from here to syssignal.h.
6512 * syssignal.h (croak): Put it here, so the API can be checked when
6513 'croak' is called from dissociate_if_controlling_tty.
6514
1717ede2
PE
6515 * minibuf.c: Make symbols static if they're not exported.
6516 (minibuf_save_list, choose_minibuf_frame): Now static.
6517 * lisp.h (choose_minibuf_frame): Remove decl.
6518
fa5fb2bc
PE
6519 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6520
1e3890d1
PE
6521 * lread.c: Make symbols static if they're not exported.
6522 (read_objects, initial_obarray, oblookup_last_bucket_number):
6523 Now static.
6524 (make_symbol): Remove; unused.
6525 * lisp.h (initial_obarray, make_symbol): Remove decls.
6526
8a1414fa
PE
6527 * keyboard.c: Make symbols static if they're not exported.
6528 (single_kboard, recent_keys_index, total_keys, recent_keys):
6529 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6530 (this_single_command_key_start, echoing, last_auto_save):
6531 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6532 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6533 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6534 (Vlispy_mouse_stem, double_click_count):
6535 Now static.
6536 (force_auto_save_soon): Define only if SIGDANGER.
6537 (ignore_mouse_drag_p): Now static if
6538 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6539 (print_help): Remove; unused.
6540 (stop_character, last_timer_event): Mark as externally visible.
6541 * keyboard.h (ignore_mouse_drag_p): Declare only if
6542 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6543 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6544 * lisp.h (echoing): Remove decl.
6545 (force_auto_save_soon): Declare only if SIGDANGER.
6546 * xdisp.c (redisplay_window): Simplify code, to make it more
6547 obvious that ignore_mouse_drag_p is not accessed if !defined
6548 USE_GTK && !defined HAVE_NS.
6549
93ea6e8f
PE
6550 * intervals.c: Make symbols static if they're not exported.
6551 (merge_properties_sticky, merge_interval_right, delete_interval):
6552 Now static.
6553 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6554
77382fcc
PE
6555 * insdel.c: Make symbols static if they're not exported.
6556 However, leave prepare_to_modify_buffer alone. It's never
6557 called from outside this function, but that appears to be a bug.
6558 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6559 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6560 (adjust_after_replace_noundo): Remove; unused.
6561 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6562 (signal_before_change): Remove decls.
77382fcc 6563
9306c32e
PE
6564 * indent.c (val_compute_motion, val_vmotion): Now static.
6565
cd44d2eb
PE
6566 * image.c: Make symbols static if they're not exported.
6567 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6568 if USE_GTK.
6569 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6570 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6571
ad9a7a06
PE
6572 * fringe.c (standard_bitmaps): Now static.
6573 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6574
81626931
PE
6575 * frame.c: Make symbols static if they're not exported.
6576 (x_report_frame_params, make_terminal_frame): Now static.
6577 (get_frame_param): Now static, unless HAVE_NS.
6578 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6579 (x_get_resource_string): Remove; not used.
6580 * frame.h (make_terminal_frame, x_report_frame_params):
6581 (x_get_resource_string); Remove decls.
6582 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6583 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6584
239f9db9
PE
6585 * font.c, fontset.c: Make symbols static if they're not exported.
6586 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6587 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6588 * font.c (font_close_object): Now static.
6589 * font.h (font_close_object): Remove.
6590 * fontset.c (FONTSET_OBJLIST): Remove.
6591 (free_realized_fontset) #if-0 the body, which does nothing.
6592 (face_suitable_for_char_p): #if-0, as it's never called.
6593 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6594 * xfaces.c (face_at_string_position):
6595 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6596 since 0 is always ASCII.
6597
dfcf3579
PE
6598 * fns.c (weak_hash_tables): Now static.
6599
5045092b
PE
6600 * fileio.c: Make symbols static if they're not exported.
6601 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6602 (Vwrite_region_annotation_buffers): Now static.
6603
57a96f5c
PE
6604 * eval.c: Make symbols static if they're not exported.
6605 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6606 * lisp.h (backtrace_list): Remove decl.
6607
35f08c38
PE
6608 * emacs.c: Make symbols static if they're not exported.
6609 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6610 (fatal_error_code, fatal_error_signal_hook, standard_args):
6611 Now static.
6612 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6613 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6614 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6615 * lisp.h (fatal_error_signal_hook): Remove decl.
6616 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6617
f44bd759
PE
6618 * editfns.c: Move a (normally-unused) function to its only use.
6619 * editfns.c, lisp.h (get_operating_system_release): Remove.
6620 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6621 worth the hassle of breaking this out.
6622
b532497d
PE
6623 * xterm.c: Make symbols static if they're not exported.
6624 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6625 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6626 (x_destroy_window, x_delete_display):
6627 Now static.
6628 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6629 (x_mouse_leave): Remove; unused.
6630 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6631 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6632 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6633 Remove decls.
6634 (x_mouse_leave): Declare only if WINDOWSNT.
6635 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6636 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6637 USE_X_TOOLKIT.
6638
1675728f
PE
6639 * ftxfont.c: Make symbols static if they're not exported.
6640 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6641 HAVE_FREETYPE.
6642 * font.h (ftxfont_driver): Likewise.
6643
e4cebfca
PE
6644 * xfns.c: Make symbols static if they're not exported.
6645 (x_last_font_name, x_display_info_for_name):
6646 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6647 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6648 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6649 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6650 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6651 (last_show_tip_args): Now static.
6652 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6653 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6654 (x_screen_planes): Remove; unused.
6655 * dispextern.h (x_screen_planes): Remove decl.
6656
5bf46f05
PE
6657 * dispnew.c: Make symbols static if they're not exported.
6658 * dispextern.h (redraw_garbaged_frames, scrolling):
6659 (increment_row_positions): Remove.
6660 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6661 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6662 Now static.
6663 (redraw_garbaged_frames): Remove; unused.
6664
435f4c28
PE
6665 * xfaces.c: Make symbols static if they're not exported.
6666 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6667 Remove decls.
6668 * xterm.h (defined_color): Remove decls.
6669 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6670 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6671 (menu_face_changed_default, defined_color, free_realized_face):
6672 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6673 (ascii_face_of_lisp_face): Remove; unused.
6674
8524aef3
PE
6675 * xdisp.c: Make symbols static if they're not exported.
6676 * dispextern.h (scratch_glyph_row, window_box_edges):
6677 (glyph_to_pixel_coords, set_cursor_from_row):
6678 (get_next_display_element, set_iterator_to_next):
6679 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6680 (show_mouse_face): Remove decls
6681 * frame.h (message_buf_print): Likewise.
6682 * lisp.h (pop_message, set_message, check_point_in_composition):
6683 Likewise.
6684 * xterm.h (set_vertical_scroll_bar): Likewise.
6685 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6686 (message_buf_print, scratch_glyph_row, displayed_buffer):
6687 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6688 (get_next_display_element, show_mouse_face, window_box_edges):
6689 (frame_to_window_pixel_xy, check_point_in_composition):
6690 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6691 (glyph_to_pixel_coords): Remove; unused.
6692
16390cd2
PE
6693 * dired.c (file_name_completion): Now static.
6694
6695 * dbusbind.c (xd_in_read_queued_messages): Now static.
6696
a25f4dfa
PE
6697 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6698 * data.c (circular_list_error): Remove.
6699
14a9c8df
PE
6700 * commands.h (last_point_position, last_point_position_buffer):
6701 (last_point_position_window): Remove decls.
6702 * keyboard.c: Make these variables static.
6703
04f2d78b
CB
6704 * coding.h (coding, code_convert_region, encode_coding_gap):
6705 Remove decls.
74ab6df5
PE
6706 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6707 (iso_code_class, detect_coding, code_convert_region): Now static.
6708 (encode_coding_gap): Remove; unused.
6709
38dfbee1
PE
6710 * chartab.c (chartab_chars, chartab_bits): Now static.
6711
a2cb4e63
PE
6712 * charset.h (charset_iso_8859_1): Remove decl.
6713 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6714 Now static.
6715
127198fd
PE
6716 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6717 * ccl.c (Vccl_program_table): Now static.
6718 (check_ccl_update): Remove; unused.
6719
d85b608f
PE
6720 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6721 * category.h: ... from here.
6722 * category.c (check_category_table, set_category_set): Now static.
6723
31cd66f3
PE
6724 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6725 * lisp.h: Remove these decls.
6726
c358e587
PE
6727 * buffer.c (buffer_count): Remove unused var.
6728
e78aecca
PE
6729 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6730 so that it's not optimized away.
6731 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6732 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6733 exported only to the debugger.
6734
e192d7d3 6735 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6736 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6737
92470028
PE
6738 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6739 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6740 was inaccessible from Lisp.
6741 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6742 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6743
244ed907
PE
6744 alloc.c: Import and export fewer symbols, and remove unused items.
6745 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6746 is defined.
6747 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6748 it's not optimized away by whole-program optimization.
6749 (message_enable_multibyte, free_misc): Remove.
6750 (catchlist, handlerlist, mark_backtrace):
6751 Declare only if BYTE_MARK_STACK.
6752 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6753 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6754 (message_enable_multibyte): Remove decl.
6755 (free_misc, interval_free_list, float_block, float_block_index):
6756 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6757 (cons_free_list, last_marked_index):
6758 Now static.
6759 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6760 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6761 (mark_backtrace): Define only if BYTE_MARK_STACK.
6762 * xdisp.c (message_enable_multibyte): Now static.
6763
61c2b50e 6764 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6765 This makes it easier for human readers (and static analyzers)
6766 to see whether these variables are used from other modules.
6767 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6768 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6769 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6770 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6771 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6772 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6773 * xmenu.c, xselect.c:
6774 Declare Q* vars static if they are not used in other modules.
6775 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6776 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6777 Remove decls of unexported vars.
6778 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6779
95c82688
PE
6780 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6781
16a97296
PE
6782 Make Emacs functions such as Fatom 'static' by default.
6783 This makes it easier for human readers (and static analyzers)
6784 to see whether these functions can be called from other modules.
6785 DEFUN now defines a static function. To make the function external
6786 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6787 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6788 (Finit_image_library):
16a97296
PE
6789 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6790 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6791 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6792 Remove decls, since these functions are now static.
6793 (Funintern, Fget_internal_run_time): New decls, since these functions
6794 were already external.
95c82688 6795
16a97296
PE
6796 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6797 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6798 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6799 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6800 * keyboard.c, keymap.c, lread.c:
6801 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6802 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6803 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6804 Mark functions with DEFUE instead of DEFUN,
6805 if they are used in other modules.
6806 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6807 decls for now-static functions.
6808 * buffer.h (Fdelete_overlay): Remove decl.
6809 * callproc.c (Fgetenv_internal): Mark as internal.
6810 * composite.c (Fremove_list_of_text_properties): Remove decl.
6811 (Fcomposition_get_gstring): New forward static decl.
6812 * composite.h (Fcomposite_get_gstring): Remove decl.
6813 * dired.c (Ffile_attributes): New forward static decl.
6814 * doc.c (Fdocumntation_property): New forward static decl.
6815 * eval.c (Ffetch_bytecode): New forward static decl.
6816 (Funintern): Remove extern decl; now in .h file where it belongs.
6817 * fileio.c (Fmake_symbolic_link): New forward static decl.
6818 * image.c (Finit_image_library): New forward static decl.
6819 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6820 * intervals.h (Fprevious_property_change):
6821 (Fremove_list_of_text_properties): Remove decls.
6822 * keyboard.c (Fthis_command_keys): Remove decl.
6823 (Fcommand_execute): New forward static decl.
6824 * keymap.c (Flookup_key): New forward static decl.
6825 (Fcopy_keymap): Now static.
6826 * keymap.h (Flookup_key): Remove decl.
6827 * process.c (Fget_process): New forward static decl.
6828 (Fprocess_datagram_address): Mark as internal.
6829 * syntax.c (Fsyntax_table_p): New forward static decl.
6830 (skip_chars): Remove duplicate decl.
6831 * textprop.c (Fprevious_property_change): New forward static decl.
6832 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6833 Now internal.
6834 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6835 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6836
785bbd42
PE
6837 * editfns.c (Fformat): Remove unreachable code.
6838
8b913b57
AS
68392011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6840
6841 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6842 change. (Bug#8496)
6843
a6744a35
EZ
68442011-04-13 Eli Zaretskii <eliz@gnu.org>
6845
6846 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6847 when at ZV. (Bug#8487)
6848
e7974947
AS
68492011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6850
baad03f0
AS
6851 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6852 (Bug#8437)
6853 * keyboard.c (parse_tool_bar_item): Likewise.
6854 * sound.c (sound_cleanup, alsa_close): Likewise.
6855 * termcap.c (tgetent): Likewise.
6856 * xfns.c (x_default_font_parameter): Likewise.
6857 * xsettings.c (read_and_apply_settings): Likewise.
6858
e7974947
AS
6859 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6860 (overrun_check_free): Protoize.
6861
28272684
PE
68622011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6863
6864 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6865 since callers should never pass a negative size.
6866 Change the signature to match that of plain 'read' and 'write'; see
6867 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6868 * lisp.h: Update prototypes of emacs_write and emacs_read.
6869
11997c76
EZ
68702011-04-11 Eli Zaretskii <eliz@gnu.org>
6871
6872 * xdisp.c (redisplay_window): Don't try to determine the character
6873 position of the scroll margin if the window start point w->startp
e896f03c 6874 is outside the buffer's accessible region. (Bug#8468)
11997c76 6875
8a2cbd72
EZ
68762011-04-10 Eli Zaretskii <eliz@gnu.org>
6877
6878 Fix write-region and its subroutines for buffers > 2GB.
6879 * fileio.c (a_write, e_write): Modify declaration of arguments and
6880 local variables to support buffers larger than 2GB.
6881 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6882
6883 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6884 argument, local variables, and return value.
6885
6886 * lisp.h: Update prototypes of emacs_write and emacs_read.
6887
6888 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6889
4073e537 68902011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6891
1ebfdcb6
PE
6892 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6893
b2ded58d
PE
6894 Fix more problems found by GCC 4.6.0's static checks.
6895
7d66342c
PE
6896 * xdisp.c (vmessage): Use a better test for character truncation.
6897
bbf47d44
PE
6898 * charset.c (load_charset_map): <, not <=, for optimization,
6899 and to avoid potential problems with integer overflow.
9248994d 6900 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6901 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6902 * editfns.c (Fformat): Likewise.
1e69125e 6903 * syntax.c (skip_chars): Likewise.
3befa583 6904
e3019616
PE
6905 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6906 This also lets GCC 4.6.0 generate slightly better loop code.
6907
becfa255
PE
6908 * callint.c (Fcall_interactively): <, not <=, for optimization.
6909 (Fcall_interactively): Count the number of arguments produced,
6910 not the number of arguments given. This is simpler and lets GCC
6911 4.6.0 generate slightly better code.
6912
dae0cd48
PE
6913 * ftfont.c: Distingish more carefully between FcChar8 and char.
6914 The previous code passed unsigned char * to a functions like
6915 strlen and xstrcasecmp that expect char *, which does not
6916 conform to the C standard.
6917 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6918 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6919 char * when the C standard requires it.
6920
76032d70
PE
6921 * keyboard.c (read_char): Remove unused var.
6922
eb3f1cc8
PE
6923 * eval.c: Port to Windows vsnprintf (Bug#8435).
6924 Include <limits.h>.
6925 (SIZE_MAX): Define if the headers do not.
6926 (verror): Do not give up if vsnprintf returns a negative count.
6927 Instead, grow the buffer. This ports to Windows vsnprintf, which
6928 does not conform to C99. Problem reported by Eli Zaretskii.
6929 Also, simplify the allocation scheme, by avoiding the need for
6930 calling realloc, and removing the ALLOCATED variable.
6931
70476b54
PE
6932 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6933
12020a9e
PE
6934 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6935 But keep the doprint source code for now, as we might revamp it
6936 and use it again (Bug#8435).
ea6c7ae6
PE
6937 * lisp.h (doprnt): Remove.
6938 * Makefile.in (base_obj): Remove doprnt.o.
6939 * deps.mk (doprnt.o): Remove.
6940
5fdb398c
PE
6941 error: Print 32- and 64-bit integers portably (Bug#8435).
6942 Without this change, on typical 64-bit hosts error ("...%d...", N)
6943 was used to print both 32- and 64-bit integers N, which relied on
6944 undefined behavior.
6945 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6946 New macro.
6947 * lisp.h (error, verror): Mark as printf-like functions.
6948 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6949 Report overflow in size calculations when allocating printf buffer.
6950 Do not truncate output string at its first null byte.
6951 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6952 Truncate the output at a character boundary, since vsnprintf does not
6953 do that.
6954 * charset.c (check_iso_charset_parameter): Convert internal
6955 character to string before calling 'error', since %c now has the
6956 printf meaning.
6957 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6958 overflow when computing char to be passed to 'error'. Do not
6959 pass Lisp_Object to 'error'; pass the integer instead.
6960 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6961 formatted with plain %d.
6962
b189fa66
PE
6963 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6964
bff87ef0
PE
6965 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6966
7e2cac20
PE
6967 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6968
ce4d90b5
PE
6969 * xterm.c (x_catch_errors): Remove duplicate declaration.
6970
266c9547
PE
6971 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6972
79c49ad2
PE
6973 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6974
368f4090
JM
69752011-04-10 Jim Meyering <meyering@redhat.com>
6976
6977 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6978 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6979 return ssize_t not "int", and use size_t as the buffer length.
6980 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6981 * gnutls.h: Update declarations.
6982 * process.c (read_process_output): Use ssize_t, to match.
6983 (send_process): Likewise.
6984
a32d4040
CY
69852011-04-09 Chong Yidong <cyd@stupidchicken.com>
6986
6987 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6988
8546720e 69892011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6990
04f2d78b
CB
6991 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6992 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6993
8546720e
GM
6994 * xterm.c (handle_one_xevent):
6995 * xmenu.c (create_and_show_popup_menu):
6996 * xselect.c (x_decline_selection_request)
6997 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6998
0a2f5c1a 69992011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7000
7001 Fix some uses of `int' instead of EMACS_INT.
7002 * search.c (string_match_1, fast_string_match)
7003 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7004 (scan_buffer, find_next_newline_no_quit)
7005 (find_before_next_newline, search_command, Freplace_match)
7006 (Fmatch_data): Make some `int' variables be EMACS_INT.
7007
7008 * xdisp.c (display_count_lines): 3rd argument and return value now
7009 EMACS_INT. All callers changed.
7010 (pint2hrstr): Last argument is now EMACS_INT.
7011
7012 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7013 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7014 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7015 (decode_coding_utf_16, decode_coding_emacs_mule)
7016 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7017 (decode_coding_ccl, decode_coding_charset)
7018 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7019 (decode_coding_iso_2022, decode_coding_emacs_mule)
7020 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7021 <char_offset, last_offset>: Declare EMACS_INT.
7022 (encode_coding_utf_8, encode_coding_utf_16)
7023 (encode_coding_emacs_mule, encode_invocation_designation)
7024 (encode_designation_at_bol, encode_coding_iso_2022)
7025 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7026 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7027 Declare EMACS_INT.
7028 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7029 (encode_invocation_designation): Last argument P_NCHARS is now
7030 EMACS_INT.
7031 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7032 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7033
7034 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7035 All users changed.
7036
7037 * ccl.c (Fccl_execute_on_string): Declare some variables
7038 EMACS_INT.
7039
8546720e 70402011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7041
7042 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7043
4e19a977
CS
70442011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7045
7046 * process.c (Fformat_network_address): Doc fix.
7047
87302331
R
70482011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7049
7050 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7051
cbb59342
CY
70522011-04-08 Chong Yidong <cyd@stupidchicken.com>
7053
7054 * keyboard.c (read_char): Call Lisp function help-form-show,
7055 instead of using internal_with_output_to_temp_buffer.
7056 (Qhelp_form_show): New var.
e0d38eeb 7057 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7058
7059 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7060
7061 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7062
e67a13ab
CY
70632011-04-06 Chong Yidong <cyd@stupidchicken.com>
7064
04f2d78b
CB
7065 * process.c (Flist_processes): Remove to Lisp.
7066 (list_processes_1): Delete.
e67a13ab 7067
973f782d
EZ
70682011-04-06 Eli Zaretskii <eliz@gnu.org>
7069
7c106b1e
EZ
7070 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7071
973f782d
EZ
7072 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7073
41cf7d1a 70742011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7075
ca23cc88
PE
7076 Fix more problems found by GCC 4.6.0's static checks.
7077
f390e2d5
PE
7078 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7079
42eea0d0
PE
7080 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7081
b69769da 7082 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7083
f9541e84
PE
7084 * xdisp.c (vmessage): Mark as a printf-like function.
7085
13841b55
PE
7086 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7087
c136c10f
PE
7088 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7089
5e2d4a30
PE
7090 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7091 printf-like functions.
7092 (tiff_load): Add casts to remove these marks before passing them
7093 to system-supplied API.
7094
583f48b9
PE
7095 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7096
b25d760e
PE
7097 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7098 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7099 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7100 directly, rather than having caller test rule sign. This avoids
7101 some unnecessary tests.
7102 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7103 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7104 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7105
bc7b6697 7106 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7107 (xfont_open): Avoid unnecessary tests.
bc7b6697 7108
27ccc379
PE
7109 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7110
dcd5c89a
PE
7111 * composite.h, composite.c (composition_gstring_put_cache):
7112 Use EMACS_INT, not int, for length.
7113
b13a45c6
PE
7114 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7115 breaking out part of COMPOSITION_DECODE_RULE.
7116 (COMPOSITION_DECODE_RULE): Use it.
7117 * composite.c (get_composition_id): Remove unused local vars,
7118 by using the new macro.
7119
1e792e4d
PE
7120 * textprop.c (set_text_properties_1): Change while to do-while,
7121 since the condition is always true at first.
7122
dc6c6455 7123 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7124 (interval_deletion_adjustment): Return unsigned value.
7125 All uses changed.
dc6c6455 7126
aba7731a
PE
7127 * process.c (list_processes_1, create_pty, read_process_output):
7128 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7129 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7130 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7131 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7132 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7133
fdfc4bf3
PE
7134 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7135
fca8fe46 7136 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7137 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7138
06a0259a 7139 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7140 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7141 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7142
e7b9e80f
PE
7143 * print.c (print_error_message): Avoid int overflow.
7144
56201685
PE
7145 * font.c (font_list_entities): Redo for clarity,
7146 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7147
78834453 7148 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7149 (font_score): Avoid potential overflow in diff calculation.
78834453 7150
0bc0b309 7151 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7152 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7153
e610eaca
PE
7154 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7155
b895abce
PE
7156 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7157 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7158 can always succeed if overflow has undefined behavior.
7159
1f1d9321 7160 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7161 (wordify): Omit three unnecessary tests.
1f1d9321 7162
c59478bc
PE
7163 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7164 All callers changed. This avoids the need for an unused var.
7165
79b73827
PE
7166 * casefiddle.c (casify_region): Remove var that is set but not used.
7167
a4db5dfe
PE
7168 * dired.c (file_name_completion): Remove var that is set but not used.
7169
43aae36e
PE
7170 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7171
2a47c44d 7172 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7173 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7174
a37c69bf
PE
7175 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7176 Check for integer overflow on size calculations.
7177
328ab8e7
PE
7178 * buffer.c (Fprevious_overlay_change): Remove var that is set
7179 but not used.
7180
e5a2a5cb
PE
7181 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7182 Remove vars that are set but not used.
8d84a6eb 7183 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7184 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7185
a60e5f68
PE
7186 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7187
f661cb61 7188 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7189 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7190
f0397f5a
PE
7191 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7192 that are set but not used.
7193
8664db06 7194 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7195 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7196
6abdaa4a
PE
7197 * xselect.c (x_get_local_selection, x_handle_property_notify):
7198 Remove vars that are set but not used.
7199
0ce7538d 7200 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7201 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7202
9ae848fc
PE
7203 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7204 Remove var that is set but not used.
0b918413
PE
7205 (scroll_bar_windows_size): Now size_t, not int.
7206 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7207 Check for overflow.
9ae848fc 7208
a5a62657
PE
7209 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7210 (map_tty_color) [!defined MSDOS]: Likewise.
7211
5c5cdd39
PE
7212 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7213
66ebf983
PE
7214 * coding.c: Remove vars that are set but not used.
7215 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7216 All callers changed.
7217 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7218 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7219 (decode_coding_charset): Remove vars that are set but not used.
7220
1be4d761
PE
7221 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7222 that is set but not used.
7223
47553fa8
PE
7224 * print.c (print_object): Remove var that is set but not used.
7225
1f7196bf 7226 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7227 The gnulib version avoids calling malloc in the usual case,
7228 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7229 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7230 * filelock.c (current_lock_owner): Likewise.
7231 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7232 * sysdep.c: Include allocator.h, careadlinkat.h.
7233 (emacs_no_realloc_allocator): New static constant.
7234 (emacs_readlink): New function.
fdb61804
PE
7235 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7236 ../lib/careadlinkat.h.
d1fdcab7 7237
f84c17c7
SM
72382011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7239
7240 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7241 first non-nil return value).
7242
ef3862ad
JD
72432011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7244
7245 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7246 if not defined (Bug#8403).
7247
376a7006
JB
72482011-04-02 Juanma Barranquero <lekktu@gmail.com>
7249
7250 * xdisp.c (display_count_lines): Remove parameter `start',
7251 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7252 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7253 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7254 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7255 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7256 and thereabouts. All callers changed.
7257 (get_per_char_metric): Remove parameter `f', unused since
7258 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7259
6ca3801d
JM
72602011-04-02 Jim Meyering <meyering@redhat.com>
7261
7262 do not dereference NULL upon failed strdup
7263 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7264 (ns_get_family): Likewise.
7265
d8e2b5ba
JB
72662011-04-02 Juanma Barranquero <lekktu@gmail.com>
7267
7268 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7269
8c74fcbd
JD
72702011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7271
7272 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7273 later (Bug#8403).
7274
7200d79c
SM
72752011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7276
03408648 7277 Add lexical binding.
7200d79c 7278
03408648
SM
7279 * window.c (Ftemp_output_buffer_show): New fun.
7280 (Fsave_window_excursion):
7281 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7282
7283 * lread.c (lisp_file_lexically_bound_p): New function.
7284 (Fload): Bind Qlexical_binding.
7285 (readevalloop): Remove `evalfun' arg.
7286 Bind Qinternal_interpreter_environment.
7287 (Feval_buffer): Bind Qlexical_binding.
7288 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7289 Mark as dynamic.
7290 (syms_of_lread): Declare `lexical-binding'.
7291
7292 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7293
7294 * keyboard.c (eval_dyn): New fun.
7295 (menu_item_eval_property): Use it.
ca105506
SM
7296
7297 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7298
03408648
SM
7299 * fns.c (concat, mapcar1): Accept byte-code-functions.
7300
7301 * eval.c (Fsetq): Handle lexical vars.
7302 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7303 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7304 (FletX, Flet): Obey lexical binding.
7305 (Fcommandp): Handle closures.
7306 (Feval): New `lexical' arg.
7307 (eval_sub): New function extracted from Feval. Use it almost
7308 everywhere where Feval was used. Look up vars in lexical env.
7309 Handle closures.
7310 (Ffunctionp): Move from subr.el.
7311 (Ffuncall): Handle closures.
7312 (apply_lambda): Remove `eval_flags'.
7313 (funcall_lambda): Handle closures and new byte-code-functions.
7314 (Fspecial_variable_p): New function.
7315 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7316 but without exporting it to Lisp.
23aba0ea 7317
23aba0ea 7318 * doc.c (Fdocumentation, store_function_docstring):
03408648 7319 * data.c (Finteractive_form): Handle closures.
23aba0ea 7320
03408648
SM
7321 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7322 interactive spec.
ba83908c 7323
04f2d78b
CB
7324 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7325 New byte-codes.
03408648
SM
7326 (exec_byte_code): New function extracted from Fbyte_code to handle new
7327 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7328
03408648 7329 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7330
03408648 7331 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7332
e2abce01
JB
73332011-03-31 Juanma Barranquero <lekktu@gmail.com>
7334
7335 * xdisp.c (redisplay_internal): Fix prototype.
7336
63696a73 73372011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7338
63696a73 7339 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7340 (try_scrolling): Use it when setting scroll_limit.
7341 Limit scrolling to 100 screen lines.
63696a73
EZ
7342 (redisplay_window): Even when falling back on "recentering",
7343 position point in the window according to scroll-conservatively,
7344 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7345
7346 (try_scrolling): When point is above the window, allow searching
7347 as far as scroll_max, or one screenful, to compute vertical
7348 distance from PT to the scroll margin position. This prevents
7349 try_scrolling from unnecessarily failing when
7350 scroll-conservatively is set to a value slightly larger than the
7351 window height. Clean up the case of PT below the margin at bottom
7352 of window: scroll_max can no longer be INT_MAX. When aggressive
7353 scrolling is in use, don't let point enter the opposite scroll
7354 margin as result of the scroll.
7355 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7356 threshold of 100 lines for never-recentering scrolling.
7357
e4cc2dfc
JB
73582011-03-31 Juanma Barranquero <lekktu@gmail.com>
7359
7360 * dispextern.h (move_it_by_lines):
7361 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7362 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7363 (message_log_check_duplicate): Remove parameters `prev_bol' and
7364 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7365 (redisplay_internal): Remove parameter `preserve_echo_area',
7366 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7367
7368 * indent.c (Fvertical_motion):
7369 * window.c (window_scroll_pixel_based, Frecenter):
7370 Don't pass `need_y_p' to `move_it_by_lines'.
7371
1c470562
SM
73722011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7373
44f230aa
SM
7374 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7375 steal a few bits to be more compact.
7376 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7377 Remove unneeded casts.
7378
1c470562
SM
7379 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7380
888adce9
ZK
73812011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7382
7383 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7384 binding" message (bug#7967).
7385
f838ed7b
PE
73862011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7387
77861b95
PE
7388 Fix more problems found by GCC 4.6.0's static checks.
7389
de6dbc14
PE
7390 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7391 Remove unused local var.
7392
f838ed7b
PE
7393 * editfns.c (Fmessage_box): Remove unused local var.
7394
792c7b2b
PE
7395 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7396 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7397 Omit unused local vars.
c499e557 7398 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7399 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7400 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7401 Omit unused local var.
7402
ba0165e1
PE
7403 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7404 Don't assume string length fits in int.
32ad8845 7405 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7406 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7407
3c59b4c9
PE
7408 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7409 instead of alloca (Bug#8344).
7410
a3eed478 7411 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7412 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7413
eb4d412d
PE
7414 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7415
1658b401
PE
7416 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7417 concerns.
7418
7419 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7420
7421 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7422
9a2c6e05
PE
7423 * keyboard.c (syms_of_keyboard): Use the same style as later
7424 in this function when indexing through an array. This also
7425 works around GCC bug 48267.
7426
03d0a109
PE
7427 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7428
44f730c8
PE
7429 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7430
fe75f926
PE
7431 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7432 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7433
ffa8c828
PE
7434 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7435 This avoids undefined behavior on integer overflow, and is a bit
7436 more convenient anyway since it is compared to a size_t variable.
7437
c5101a77
PE
7438 Variadic C functions now count arguments with size_t, not int.
7439 This avoids an unnecessary limitation on 64-bit machines, which
7440 caused (substring ...) to crash on large vectors (Bug#8344).
7441 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7442 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7443 All variadic functions and their callers changed accordingly.
c5101a77
PE
7444 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7445 * data.c (arith_driver, float_arith_driver): Likewise.
7446 * editfns.c (general_insert_function): Likewise.
7447 * eval.c (struct backtrace.nargs, interactive_p)
7448 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7449 (funcall_lambda, mark_backtrace): Likewise.
7450 * fns.c (concat): Likewise.
7451 * frame.c (x_set_frame_parameters): Likewise.
7452 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7453 0 if not found, not -1. All callers changed.
7454
dd3f25f7
PE
7455 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7456 (stack_copy_size): Now size_t, not int.
7457 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7458
461c2ab9
JB
74592011-03-28 Juanma Barranquero <lekktu@gmail.com>
7460
7461 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7462 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7463 All callers changed.
7464
7465 * lisp.h (multibyte_char_to_unibyte):
7466 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7467 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7468 * character.h (CHAR_TO_BYTE8):
7469 * cmds.c (internal_self_insert):
7470 * editfns.c (general_insert_function):
7471 * keymap.c (push_key_description):
7472 * search.c (Freplace_match):
7473 * xdisp.c (message_dolog, set_message_1): All callers changed.
7474
f6d62986
SM
74752011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7476
7477 * keyboard.c (safe_run_hook_funcall): New function.
7478 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7479 don't set the hook to nil, but remove the offending function instead.
7480 (Qcommand_hook_internal): Remove, unused.
7481 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7482 Vcommand_hook_internal.
7483
7484 * eval.c (enum run_hooks_condition): Remove.
7485 (funcall_nil, funcall_not): New functions.
7486 (run_hook_with_args): Call each function through a `funcall' argument.
7487 Remove `cond' argument, now redundant.
7488 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7489 (Frun_hook_with_args_until_failure): Adjust accordingly.
7490 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7491
1db5b1ad
JB
74922011-03-28 Juanma Barranquero <lekktu@gmail.com>
7493
7494 * dispextern.h (string_buffer_position): Remove declaration.
7495
7496 * print.c (strout): Remove parameter `multibyte', unused since
7497 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7498
7499 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7500 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7501 All callers changed.
7502
7503 * w32.c (_wsa_errlist): Use braces for struct initializers.
7504
7505 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7506 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7507 All callers changed.
7508 (string_buffer_position): Likewise. Also, make static (it's never
7509 used outside xdisp.c).
7510 (cursor_row_p): Remove parameter `w', unused since
7511 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7512 (decode_mode_spec): Remove parameter `precision', introduced during
7513 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7514 All callers changed.
7515
5ffb62aa
JD
75162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7517
7518 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7519
461c2ab9 75202011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7521
7522 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7523 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7524 (ns_update_auto_hide_menu_bar): New functions.
7525 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7526 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7527 ns_constrain_all_frames.
7528 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7529 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7530
5c380ffb
JD
75312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7532
7533 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7534
9af30bdf
GM
75352011-03-27 Glenn Morris <rgm@gnu.org>
7536
7537 * syssignal.h: Replace RETSIGTYPE with void.
7538 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7539 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7540 Replace SIGTYPE with void everywhere.
7541 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7542 * s/template.h (SIGTYPE): Remove commented out definition.
7543
e2abce01
JB
75442011-03-26 Eli Zaretskii <eliz@gnu.org>
7545
7546 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7547 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7548
f868cd8a
JB
75492011-03-26 Juanma Barranquero <lekktu@gmail.com>
7550
59eb0929
JB
7551 * w32.c (read_unc_volume): Use parameter `henum', instead of
7552 global variable `wget_enum_handle'.
7553
7554 * keymap.c (describe_vector): Remove parameters `indices' and
7555 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7556 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7557
f868cd8a
JB
7558 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7559
7560 * keyboard.c (timer_check): Remove parameter `do_it_now',
7561 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7562 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7563 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7564
7565 * keyboard.c (read_char):
7566 * w32menu.c (w32_menu_display_help):
7567 * xmenu.c (show_help_event, menu_help_callback):
7568 Adjust calls to `show_help_echo'.
7569
7570 * gtkutil.c (xg_maybe_add_timer):
7571 * keyboard.c (readable_events):
7572 * process.c (wait_reading_process_output):
7573 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7574
7575 * insdel.c (adjust_markers_gap_motion):
7576 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7577 (gap_left, gap_right): Don't call it.
7578
2ecf6fdb
CY
75792011-03-25 Chong Yidong <cyd@stupidchicken.com>
7580
7581 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7582 incurred during fontification.
7583
6b1f9ba4
JB
75842011-03-25 Juanma Barranquero <lekktu@gmail.com>
7585
7586 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7587 (DEFVAR_PER_BUFFER): Don't pass it.
7588
7589 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7590 (scrolling_window): Don't pass it.
7591
0f4a96b5
JB
75922011-03-25 Juanma Barranquero <lekktu@gmail.com>
7593
7594 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7595
7596 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7597 and `suffix'.
7598 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7599 of variables specific to SELinux and computation of `encoded_absname'.
7600
7601 * image.c (XPutPixel): Remove unused variable `height'.
7602
7603 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7604
7605 * unexw32.c (get_section_info): Remove unused variable `section'.
7606
7607 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7608 (system_process_attributes): Remove unused variable `sess'.
7609 (sys_read): Remove unused variable `err'.
7610
7611 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7612 (w32_wnd_proc): Remove unused variable `isdead'.
7613 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7614 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7615 (x_create_tip_frame): Remove unused variable `tem'.
7616
7617 * w32inevt.c (w32_console_read_socket):
7618 Remove unused variable `no_events'.
7619
7620 * w32term.c (x_draw_composite_glyph_string_foreground):
7621 Remove unused variable `width'.
7622
1149507c
JB
76232011-03-24 Juanma Barranquero <lekktu@gmail.com>
7624
7625 * w32term.c (x_set_glyph_string_clipping):
7626 Don't pass uninitialized region to CombineRgn.
7627
9c88f339
JB
76282011-03-23 Juanma Barranquero <lekktu@gmail.com>
7629
7630 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7631 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7632 (Fx_close_connection): Remove unused variable `i'.
7633
7634 * w32font.c (w32font_draw): Return number of glyphs.
7635 (w32font_open_internal): Remove unused variable `i'.
7636 (w32font_driver): Add missing initializer.
7637
7638 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7639 (fill_in_menu): Remove unused variable `items_added'.
7640
7641 * w32term.c (last_mouse_press_frame): Remove static global variable.
7642 (w32_clip_to_row): Remove unused variable `f'.
7643 (x_delete_terminal): Remove unused variable `i'.
7644
7645 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7646 (NOTHING): Remove unused static global variable.
7647 (uniscribe_check_otf): Remove unused variable `table'.
7648 (uniscribe_font_driver): Add missing initializers.
7649
dee091a3
JD
76502011-03-23 Julien Danjou <julien@danjou.info>
7651
7652 * term.c (Fsuspend_tty, Fresume_tty):
7653 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7654 * window.c (temp_output_buffer_show):
7655 * insdel.c (signal_before_change):
7656 * frame.c (Fhandle_switch_frame):
7657 * fileio.c (Fdo_auto_save):
7658 * emacs.c (Fkill_emacs):
7659 * editfns.c (save_excursion_restore):
7660 * cmds.c (internal_self_insert):
7661 * callint.c (Fcall_interactively):
7662 * buffer.c (Fkill_all_local_variables):
7663 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7664 Use Frun_hooks.
0f4a96b5 7665 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7666 unconditionnaly since it does the check itself.
7667
2c520ab5 76682011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7669
c9c49752
PE
7670 Fix more problems found by GCC 4.5.2's static checks.
7671
8abc3f12
PE
7672 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7673 the first time through the loop, since we know p0 < p1 then.
7674 This also avoids a gcc -Wstrict-overflow warning.
7675
a2d26660
PE
7676 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7677 leading to a memory leak, possible in functions like
7678 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7679 of objects (Bug#8318).
a2d26660 7680
916c72e9
PE
7681 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7682 that could (at least in theory) be that large.
7683
19ab8a18
PE
7684 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7685 This is less likely to overflow, and avoids undefined behavior if
7686 overflow does occur. All callers changed. Use strtoul to scan
7687 for the unsigned long integer.
b7cbbd6f
PE
7688 (pint2hrstr): Simplify and tune code slightly.
7689 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7690
f0641eff
PE
7691 * scroll.c (do_scrolling): Work around GCC bug 48228.
7692 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7693
7f650bb9
PE
7694 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7695 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7696 (validate_x_resource_name): Simplify count usage.
7697 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7698
37dd57d1
PE
7699 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7700 fail (Bug#8306).
81e56e61 7701
699979fc 7702 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7703
401bf9b4
PE
7704 * process.c (Fmake_network_process): Use socklen_t, not int,
7705 where POSIX says socklen_t is required in portable programs.
7706 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7707 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7708 (Fmake_network_process, server_accept_connection):
7709 (wait_reading_process_output, read_process_output):
7710 Likewise.
7711
b93aacde
PE
7712 * process.c: Rename or move locals to avoid shadowing.
7713 (list_processes_1, Fmake_network_process):
7714 (read_process_output_error_handler, exec_sentinel_error_handler):
7715 Rename or move locals.
4dc343ee 7716 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7717 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7718 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7719 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7720 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7721
af8a867c 7722 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7723 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7724 Include tparam.h instead, since it declares them.
af8a867c
PE
7725 * cm.h (PC): Remove extern decl; tparam.h now does this.
7726 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7727 * terminfo.c: Include tparam.h, to check interfaces.
7728 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7729 (tparam): Adjust signature to match interface in tparam.h;
7730 this removes some undefined behavior. Check that outstring and len
7731 are zero, which they always are with Emacs.
7732 * tparam.h (PC, BC, UP): New extern decls.
7733
0248044d 7734 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7735 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7736
8ff096c1 7737 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7738 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7739 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7740 (ftfont_list): Remove unused local.
49eaafba
PE
7741 (get_adstyle_property, ftfont_pattern_entity):
7742 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7743 Rename locals to avoid shadowing.
8ff096c1 7744
e2be39f6
PE
7745 * xfont.c (xfont_list_family): Mark var as initialized.
7746
c9735e30
PE
7747 * xml.c (make_dom): Now static.
7748
8f5201ae
PE
7749 * composite.c (composition_compute_stop_pos): Rename local to
7750 avoid shadowing.
b246f932
PE
7751 (composition_reseat_it): Remove unused locals.
7752 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7753 (composition_update_it): Mark var as initialized.
11b61122
PE
7754 (find_automatic_composition): Mark vars as initialized,
7755 with a FIXME (Bug#8290).
8f5201ae 7756
760fbc2c
PE
7757 character.h: Rename locals to avoid shadowing.
7758 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7759 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7760 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7761 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7762 to avoid shadowing.
7763
ff08eb85
PE
7764 * textprop.c (property_change_between_p): Remove; unused.
7765
fc7bf025
PE
7766 * intervals.c (interval_start_pos): Now static.
7767
235d7abc
PE
7768 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7769
44f230aa
SM
7770 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7771 Rename locals to avoid shadowing.
3e7d6594 7772
50060332
PE
7773 * sound.c (wav_play, au_play, Fplay_sound_internal):
7774 Fix pointer signedness.
d01f234b 7775 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7776 (wav_play): Initialize a variable to 0, to prevent undefined
7777 behavior (Bug#8278).
50060332 7778
c4fc4e30
PE
7779 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7780
918436ed
PE
7781 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7782
c939f91b
PE
7783 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7784 clobbering (Bug#8298).
b9c7f648
PE
7785 * sysdep.c (sys_subshell): Likewise.
7786 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7787
6bd8c144
PE
7788 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7789 This should get cleaned up, so that child_setup has the
7790 same signature on all platforms.
7791
7710357c 7792 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7793 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7794
c59da222
CY
77952011-03-22 Chong Yidong <cyd@stupidchicken.com>
7796
7797 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7798 not to be necessary, and produces flickering.
7799
66b87493
GM
78002011-03-20 Glenn Morris <rgm@gnu.org>
7801
7802 * config.in: Remove file.
7803
45b6f6d5
JB
78042011-03-20 Juanma Barranquero <lekktu@gmail.com>
7805
7806 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7807 are now in src/globals.h.
7808 (syms_of_minibuf): Remove spurious & from previous change.
7809
3ec03f7e
LL
78102011-03-20 Leo <sdl.web@gmail.com>
7811
7812 * minibuf.c (completing-read-function): New variable.
7813 (completing-read-default): Rename from completing-read.
7814 (completing-read): Call completing-read-function.
7815
b14e3e21
CY
78162011-03-19 Juanma Barranquero <lekktu@gmail.com>
7817
7818 * xfaces.c (Fx_load_color_file):
7819 Read color file from absolute filename (bug#8250).
7820
f2b726e6
JB
78212011-03-19 Juanma Barranquero <lekktu@gmail.com>
7822
7823 * makefile.w32-in: Update dependencies.
7824
09f6ff02
EZ
78252011-03-17 Eli Zaretskii <eliz@gnu.org>
7826
7827 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7828
29a6015a
PE
78292011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7830
a3a6c54e
PE
7831 Fix more problems found by GCC 4.5.2's static checks.
7832
b766f867
PE
7833 * process.c (make_serial_process_unwind, send_process_trap):
7834 (sigchld_handler): Now static.
7835
be02381c
PE
7836 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7837 That way, the code declares only the vars that it needs.
7838 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7839 * s/cygwin.h (PTY_ITERATION): Likewise.
7840 * s/darwin.h (PTY_ITERATION): Likewise.
7841 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7842
57048744
PE
7843 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7844 * process.c (allocate_pty): Don't declare stb unless it's needed.
7845
7914961c 7846 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7847 (CONSTANTLIM): Remove; unused.
7848 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7849 Define only if needed.
7914961c 7850
b3967b18
PE
7851 * unexelf.c (unexec): Name an expression,
7852 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7853 Use a different way to cause a compilation error if anyone uses
7854 n rather than nn, a way that does not involve shadowing.
73366a00 7855 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7856
29a6015a
PE
7857 * deps.mk (unexalpha.o): Remove; unused.
7858
43cfc33e 7859 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7860 * unexec.h: New file.
ce701a33
PE
7861 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7862 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7863 Depend on unexec.h.
7864 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7865 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7866 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7867 Change as necessary to match prototype in unexec.h.
ce701a33 7868
01f44d5a
PE
7869 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7870 shadowing.
4f63c6bb 7871 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7872
a6670b0b
PE
7873 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7874 Rename locals to avoid shadowing.
7875
cef2010d 7876 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7877 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7878
d4d7173a
PE
7879 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7880
f08b802a
PE
7881 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7882 warning when compiling print.c.
7883
3ddb0639
PE
7884 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7885 instead of using an uninitialized var.
5ad03b97 7886 (font_sort_entities): Mark var as initialized.
3ddb0639 7887
170a2692
PE
7888 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7889
e663c700
PE
7890 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7891 pointers to constants.
89bc529a 7892 (font_parse_fcname): Remove unused vars.
7b81e2d0 7893 (font_delete_unmatched): Now static.
ea838e10 7894 (font_get_spec): Remove; unused.
13a547c6
PE
7895 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7896 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7897 Rename or move locals to avoid shadowing.
e663c700 7898
2a80c887 7899 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7900 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7901
1384fa33 7902 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7903 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7904
8b2c52e9
PE
7905 * alloc.c (mark_backtrace): Move decl from here ...
7906 * lisp.h: ... to here, so that it can be checked.
7907
475545b5 7908 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7909 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7910 (lisp_indirect_variable): Name an expression,
7911 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7912 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7913
b1349114 7914 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7915 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7916 Use const pointer when appropriate.
b1349114 7917
a2928364
PE
7918 * lisp.h (get_system_name, get_operating_system_release):
7919 Move decls here, to check interfaces.
7920 * process.c (get_operating_system_release): Move decl to lisp.h.
7921 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7922 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7923 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7924 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7925 (Fformat_time_string, Fencode_time, Finsert_char):
7926 (Ftranslate_region_internal, Fformat):
7927 Rename or remove local vars to avoid shadowing.
9710023e 7928 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7929
a415e694
PE
7930 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7931 avoid shadowing.
7932
8ef4622d
PE
7933 * lisp.h (eassert): Check that the argument compiles, even if
7934 ENABLE_CHECKING is not defined.
7935
946f9a5b
PE
7936 * data.c (Findirect_variable): Name an expression, to avoid
7937 gcc -Wbad-function-cast warning.
112396d6 7938 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7939 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7940 (Fmake_variable_buffer_local, Fmake_local_variable):
7941 Mark variables as initialized.
52746918 7942 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7943
e5aab7e7 7944 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7945 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7946 Rename locals to avoid shadowing.
dff45157
PE
7947 (mark_stack): Move local variables into the #ifdef region where
7948 they're used.
7bc26fdb
PE
7949 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7950 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7951 needed otherwise.
7952 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7953 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7954 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7955
e5aab7e7
PE
7956 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7957 avoids undefined behavior in theory.
7958
4da60324
PE
7959 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7960
88043301
PE
7961 Use functions, not macros, for up- and down-casing (Bug#8254).
7962 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7963 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7964 to use the following functions instead of these macros.
7965 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7966 EMACS_INT, since callers assume the returned value fits in int.
7967 (upcase1): Likewise, for UPCASE_TABLE.
7968 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7969 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7970 the race-condition problem in the old DOWNCASE.
88043301 7971
19ed5445
PE
7972 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7973 Rename locals to avoid shadowing.
7974 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7975 (regex_compile, re_search_2, re_match_2_internal):
7976 Remove unused local vars.
952db0d7
PE
7977 (FREE_VAR): Rewrite so as not to use empty "else",
7978 which gcc can warn about.
da053e48 7979 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7980 (RETALLOC_IF): Define only if needed.
7981 (WORDCHAR_P): Likewise. This one is never needed, but is used
7982 only in a comment talking about a compiler bug, so put inside
7983 the #if 0 of that comment.
7984 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7985 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7986 Remove; unused.
19ed5445 7987
1f3561e4 7988 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7989 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7990 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7991
ded6f8f7
PE
7992 * search.c (simple_search): Remove unused var.
7993
dbd37a95
PE
7994 * dired.c (compile_pattern): Move decl from here ...
7995 * lisp.h: ... to here, so that it can be checked.
7996 (struct re_registers): New forward decl.
7997
7e47afad
PE
7998 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7999
85f24f61
PE
8000 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8001 All uses changed.
8002 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8003 Rename locals to avoid shadowing.
5671df8f 8004 (Fvertical_motion): Mark locals as initialized.
85f24f61 8005
181aa2be 8006 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8007 (casify_region): Mark local as initialized.
181aa2be 8008
930d429c
PE
8009 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8010
7082eac6
PE
8011 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8012 New macros, so that the caller can use some names other than
8013 gcpro1, gcpro2, etc.
8014 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8015 of the new macros.
8016 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8017 argument, for consistency with GCPRO2_VAR, etc: it is now the
8018 prefix of the variable, not the variable itself. All uses
8019 changed.
38b2c076
PE
8020 * dired.c (directory_files_internal, file_name_completion):
8021 Rename locals to avoid shadowing.
8022
15206ed9
PE
8023 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8024 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8025 dired.c's scmp function, had undefined behavior.
8026 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8027 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8028 * buffer.h: ... to here, because these macros use current_buffer,
8029 and the new implementation with inline functions needs to have
8030 current_buffer in scope now, rather than later when the macros
8031 are used.
8032 (downcase, upcase1): New static inline functions.
8033 (DOWNCASE, UPCASE1): Reimplement using these functions.
8034 This avoids undefined behavior in expressions like
8035 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8036 from race conditions in accessing the global variables
8037 case_temp1 and case_temp2.
8038 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8039 * lisp.h (case_temp1, case_temp2): Remove their decls.
8040 * character.h (ASCII_CHAR_P): Move from here ...
8041 * lisp.h: ... to here, so that the inline functions mentioned
8042 above can use them.
8043
4a6bea26
PE
8044 * dired.c (directory_files_internal_unwind): Now static.
8045
f14b7e14
PE
8046 * fileio.c (file_name_as_directory, directory_file_name):
8047 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8048 Now static.
2893f146
PE
8049 (file_name_as_directory): Use const pointers when appropriate.
8050 (Fexpand_file_name): Likewise. In particular, newdir might
8051 point at constant storage, so make it a const pointer.
fd4ead52 8052 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8053 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8054 signedness issues.
f839df0c
PE
8055 (Fset_file_times, Finsert_file_contents, auto_save_error):
8056 Rename locals to avoid shadowing.
f14b7e14 8057
5716756e 8058 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8059 (Ftry_completion, Fall_completions): Rename or remove locals
8060 to avoid shadowing.
5716756e 8061
b4c3046a
PE
8062 * marker.c (bytepos_to_charpos): Remove; unused.
8063
b45db522
PE
8064 * lisp.h (verify_bytepos, count_markers): New decls,
8065 so that gcc does not warn that these functions aren't declared.
8066
85876d07
PE
8067 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8068 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8069 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8070 (copy_text): Remove unused local var.
85876d07 8071
03d78a21 8072 * filelock.c (within_one_second): Now static.
b3dd38ab 8073 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8074
5df8f01b
PE
8075 * buffer.c (fix_overlays_before): Mark locals as initialized.
8076 (fix_start_end_in_overlays): Likewise. This function should be
8077 simplified by using pointers-to-pointers, but that's a different
8078 matter.
b1d876f1 8079 (switch_to_buffer_1): Now static.
8f54f30a
PE
8080 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8081 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8082
a70072c9 8083 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8084 Fix pointer signedness issue.
edced198
PE
8085 (sys_subshell): Mark local as volatile if checking for lint,
8086 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8087 (MAXPATHLEN): Define only if needed.
a70072c9 8088
a0977c44
PE
8089 * process.c (serial_open, serial_configure): Move decls from here ...
8090 * systty.h: ... to here, so that they can be checked.
8091
a884fdcc
PE
8092 * fns.c (get_random, seed_random): Move extern decls from here ...
8093 * lisp.h: ... to here, so that they can be checked.
8094
604efe86 8095 * sysdep.c (reset_io): Now static.
b8950c94 8096 (wait_for_termination_signal): Remove; unused.
604efe86 8097
38fc62d9
PE
8098 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8099 (copy_keymap_item, append_key, push_text_char_description):
8100 Now static.
1004a21a 8101 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8102 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8103 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8104 (describe_map_tree):
8105 Rename locals to avoid shadowing.
38fc62d9 8106
2f2650da
PE
8107 * keyboard.c: Declare functions static if they are not used elsewhere.
8108 (echo_char, echo_dash, cmd_error, top_level_2):
8109 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8110 (read_char, kbd_buffer_get_event, make_lispy_position):
8111 (make_lispy_event, make_lispy_movement, apply_modifiers):
8112 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8113 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8114 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8115 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8116 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8117
a053e86c 8118 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8119 (mark_kboards): Move decl here ...
8120 * alloc.c (mark_kboards): ... from here.
a053e86c 8121
4752793e
PE
8122 * lisp.h (force_auto_save_soon): New decl.
8123
74f10ca7 8124 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8125 (DEFINE_DUMMY_FUNCTION): New macro.
8126 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8127 Use it.
c03cd23f
PE
8128 (main): Add casts to avoid warnings
8129 if GCC considers string literals to be constants.
74f10ca7 8130
022e70d4
PE
8131 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8132
59d6fe83
PE
8133 * dbusbind.c: Pointer signedness fixes.
8134 (xd_signature, xd_append_arg, xd_initialize):
8135 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8136 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8137 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8138 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8139
78320123
PE
8140 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8141 if GCC considers string literals to be constants.
49cebcca 8142 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8143
35ac2a97
SM
81442011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8145
fb103ca9
SM
8146 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8147 (print_preprocess, print_object): New macro to fix last change.
8148
35ac2a97
SM
8149 * print.c (print_preprocess): Don't forget font objects.
8150
62973b41
JB
81512011-03-16 Juanma Barranquero <lekktu@gmail.com>
8152
8153 * emacs.c (USAGE3): Doc fixes.
8154
0e48bb22
AS
81552011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8156
8157 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8158 structure.
8159
7684e57b
JB
81602011-03-14 Juanma Barranquero <lekktu@gmail.com>
8161
8162 * lisp.h (VWindow_system, Qfile_name_history):
8163 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8164 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8165 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8166
8167 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8168 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8169
8170 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8171 * w32console.c (detect_input_pending, read_input_pending)
8172 (encode_terminal_code):
8173 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8174 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8175 (w32_system_caret_y, Qfile_name_history):
8176 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8177 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8178 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8179 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8180 * w32proc.c (Qlocal, report_file_error):
8181 * w32term.c (Vwindow_system, updating_frame):
8182 * w32uniscribe.c (initialized, uniscribe_font_driver):
8183 Remove unneeded extern declarations.
8184
2aa46d6c
CY
81852011-03-14 Chong Yidong <cyd@stupidchicken.com>
8186
c96bbc66 8187 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8188
cffc6f3b
CY
81892011-03-13 Chong Yidong <cyd@stupidchicken.com>
8190
8191 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8192 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8193 These macros can no longer be used for assignment.
8194
44f230aa
SM
8195 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8196 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8197 (record_buffer_markers, fetch_buffer_markers): New functions for
8198 recording and fetching special buffer markers.
8199 (set_buffer_internal_1, set_buffer_temp): Use them.
8200
8201 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8202
8203 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8204
8205 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8206 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8207
8208 * xdisp.c (hscroll_window_tree):
8209 (reconsider_clip_changes): Use PT instead of BUF_PT.
8210
d251f04b
EZ
82112011-03-13 Eli Zaretskii <eliz@gnu.org>
8212
8213 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8214 $(EMACS_ROOT)/lib/intprops.h.
8215
f0c77cd1
PE
82162011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8217
3eca4629
PE
8218 Fix more problems found by GCC 4.5.2's static checks.
8219
7c86ee98
PE
8220 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8221 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8222 (xg_free_frame_widgets): Make it clear that a local variable is
8223 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8224 (gdk_window_get_screen): Make it clear that this macro is needed
8225 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8226 (int_gtk_range_get_value): New function, which avoids a diagnostic
8227 from gcc -Wbad-function-cast.
8228 (xg_set_toolkit_scroll_bar_thumb): Use it.
8229 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8230 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8231 (get_utf8_string, xg_get_file_with_chooser):
8232 Rename locals to avoid shadowing.
8233 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8234
41729b81
PE
8235 * xgselect.c (xg_select): Remove unused var.
8236
f0c77cd1
PE
8237 * image.c (four_corners_best): Mark locals as initialized.
8238 (gif_load): Initialize transparent_p to zero (Bug#8238).
8239 Mark another local as initialized.
ec6cf4c6 8240 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8241
ce0ad53d 8242 * image.c (clear_image_cache): Now static.
d5d5a617 8243 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8244 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8245 (x_edge_detection): Remove unnecessary cast that
8246 gcc -Wbad-function-cast diagnoses.
2037898d 8247 (gif_load): Fix pointer signedness.
6ae141d6
PE
8248 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8249 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8250
33383987 82512011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8252
d32df629
PE
8253 Improve quality of tests for time stamp overflow.
8254 For example, without this patch (encode-time 0 0 0 1 1
8255 1152921504606846976) returns the obviously-bogus value (-948597
8256 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8257 reports time overflow. See
8258 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8259 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8260 * editfns.c: Include limits.h and intprops.h.
8261 (TIME_T_MIN, TIME_T_MAX): New macros.
8262 (time_overflow): Move earlier, to before first use.
8263 (hi_time, lo_time): New functions, for an accurate test for
8264 out-of-range times.
8265 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8266 (Fget_internal_run_time): Don't assume time_t fits in int.
8267 (make_time): Use list2 instead of Fcons twice.
8268 (Fdecode_time): More accurate test for out-of-range times.
8269 (check_tm_member): New function.
8270 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8271 (lisp_time_argument): Don't rely on undefined left-shift and
8272 right-shift behavior when checking for time stamp overflow.
8be6f318 8273
fe31d94c
PE
8274 * editfns.c (time_overflow): New function, refactoring common code.
8275 (Fformat_time_string, Fdecode_time, Fencode_time):
8276 (Fcurrent_time_string): Use it.
8277
8be6f318
PE
8278 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8279 * dired.c (make_time): Move to ...
8280 * editfns.c (make_time): ... here.
8281 * systime.h: Note the move.
8282
09d9db2c 82832011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8284
126bc0dc
YM
8285 * fringe.c (update_window_fringes): Remove unused variables.
8286
c47cbdfd
YM
8287 * unexmacosx.c (copy_data_segment): Also copy __got section.
8288 (Bug#8223)
8289
7ac80be9
EZ
82902011-03-12 Eli Zaretskii <eliz@gnu.org>
8291
c96bbc66 8292 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8293 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8294 Constify `char *' arguments and their references according to
8295 prototypes in tparam.h.
8296
ecb0f94d 8297 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8298
7ac80be9
EZ
8299 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8300 Adapt all references accordingly.
8301
8302 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8303
ef1fd07e
TT
83042011-03-11 Tom Tromey <tromey@redhat.com>
8305
8306 * buffer.c (syms_of_buffer): Remove obsolete comment.
8307
7ef4b50c
EZ
83082011-03-11 Eli Zaretskii <eliz@gnu.org>
8309
8310 * termhooks.h (encode_terminal_code): Declare prototype.
8311
8312 * msdos.c (encode_terminal_code): Don't declare prototype.
8313
8314 * term.c (encode_terminal_code): Now external again, used by
8315 w32console.c and msdos.c.
8316
44f230aa
SM
8317 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8318 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8319
4b1ec863 83202011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8321
1714f52b 8322 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8323
4b1ec863
PE
8324 * fringe.c (update_window_fringes): Mark locals as initialized
8325 (Bug#8227).
8326 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8327
524c7aa6
PE
8328 * alloc.c (mark_fringe_data): Move decl from here ...
8329 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8330 to check its interface.
8331 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8332
a5c0af81 8333 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8334 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8335 (fontset_font): Mark local as initialized.
a9a06e0b 8336 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8337
b4716021
PE
8338 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8339
811e9bac 8340 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8341 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8342 (x_own_selection, Fx_disown_selection_internal): Rename locals
8343 to avoid shadowing.
8344 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8345
7e3ab302
PE
8346 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8347 so that the caller can use some name other than gcpro1.
8348 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8349 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8350 (Fx_backspace_delete_keys_p):
8351 Use them to avoid shadowing, and rename vars to avoid shadowing.
8352 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8353 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8354 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8355 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8356 Remove unused locals.
7e3ab302
PE
8357 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8358 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8359 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8360 macros.
f78faa98 8361
e2b13473
PE
8362 * xterm.h (x_mouse_leave): New decl.
8363
77f23912
PE
8364 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8365 Remove unused functions.
cdf4ba58
PE
8366 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8367 (x_calc_absolute_position): Now static.
7411c686 8368 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8369 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8370 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8371 unless they are used.
38d0b34a
PE
8372 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8373 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8374 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8375 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8376 (x_error_catcher, x_connection_closed, x_error_handler):
8377 (x_error_quitter, xembed_send_message, x_iconify_frame):
8378 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8379 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8380 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8381
44f230aa
SM
8382 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8383 Rename or move locals to avoid shadowing.
6b463e58 8384 (tty_defined_color, merge_face_heights): Now static.
5967d051 8385 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8386 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8387 does not deduce is never used uninitialized.
73719eba
PE
8388 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8389 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8390
426994c3 8391 * terminal.c (store_terminal_param): Now static.
5489860b 8392
032f1620 8393 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8394 (set_frame_menubar): Remove unused local.
d4323972 8395 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8396 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8397 since they might point to immutable storage.
281585b0
PE
8398 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8399 since it's unused otherwise.
032f1620 8400
367c19e5 8401 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8402 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8403 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8404 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8405 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8406 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8407 does not deduce are never used uninitialized.
70739cbe 8408
07b48fa9
PE
8409 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8410
8868a238 8411 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8412 * window.c (window_loop, size_window):
8413 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8414
7e5cf297 8415 * window.c (display_buffer): Now static.
d6550a9f
PE
8416 (size_window): Mark variables that gcc -Wuninitialized
8417 does not deduce are never used uninitialized.
a586633d
PE
8418 * window.h (check_all_windows): New decl, to forestall
8419 gcc -Wmissing-prototypes diagnostic.
5b555da1 8420 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8421
f6095868
PE
8422 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8423 shadowing.
8424 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8425 Include <limits.h>.
8426 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8427 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8428 (load_charset_map): Mark variables that gcc -Wuninitialized
8429 does not deduce are never used uninitialized.
53df7c11 8430 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8431
f38b440c
PE
8432 * coding.c (coding_set_source, coding_set_destination):
8433 Use "else { /* comment */ }" rather than "else /* comment */;"
8434 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8435 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8436 a block, when the outer 'i' will do.
8437 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8438 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8439 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8440 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8441 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8442 Rename locals to avoid shadowing.
8443 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8444 * coding.c (emacs_mule_char, encode_invocation_designation):
8445 Now static, since they're not used elsewhere.
413bb2db 8446 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8447 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8448 (decode_coding_emacs_mule): Mark variables that gcc
8449 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8450 (detect_coding_iso_2022): Initialize a local variable that might
8451 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8452 this initialization is needed. (Bug#8211)
5f58e762
PE
8453 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8454 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8455 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8456 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8457 Remove unused macros.
f38b440c 8458
232b38b9 8459 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8460 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8461 * character.c (string_count_byte8): Likewise.
232b38b9 8462
fb90da1b
PE
8463 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8464 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8465
fb93dbc2
PE
8466 * chartab.c (copy_sub_char_table): Now static, since it's not used
8467 elsewhere.
5c156ace
PE
8468 (sub_char_table_ref_and_range, char_table_ref_and_range):
8469 Rename locals to avoid shadowing.
bbcd0949 8470 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8471
7d3b3862 8472 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8473 (BIDI_BOB): Remove unused macro.
7d3b3862 8474
6be7d3da
PE
8475 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8476 deduce are never used uninitialized.
c2ed9c8b 8477 * term.c (encode_terminal_code): Likewise.
6be7d3da 8478
75f8807f 8479 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8480
50938595
PE
8481 * tparam.h: New file.
8482 * term.c, tparam.h: Include it.
8483 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8484 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8485 Move these decls to tparam.h, and make them agree with what
8486 is actually in tparam.c. The previous trick of using incompatible
8487 decls in different modules does not conform to the C standard.
8488 All callers of tparam changed to use tparam's actual API.
8489 * tparam.c (tparam1, tparam, tgoto):
8490 Use const pointers where appropriate.
8491
fbceeba2
PE
8492 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8493 * cm.h (struct cm): Likewise.
8494 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8495 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8496 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8497 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8498 (turn_on_face, init_tty): Likewise.
8499 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8500
7f3f1250
PE
8501 * term.c (term_mouse_position): Rename local to avoid shadowing.
8502
e6ca6543
PE
8503 * alloc.c (mark_ttys): Move decl from here ...
8504 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8505
c40f8d15
AS
85062011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8507
8508 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8509
cfe0661d
JB
85102011-03-09 Juanma Barranquero <lekktu@gmail.com>
8511
8512 * search.c (compile_pattern_1): Remove argument regp, unused since
8513 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8514 (compile_pattern): Don't pass it.
8515
0afb4571
J
85162011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8517
8518 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8519 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8520 for ! HAVE_GTK3.
8521 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8522
8523 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8524
8525 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8526 gdk_window_get_screen, gdk_window_get_geometry,
8527 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8528 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8529 (xg_get_pixbuf_from_pixmap): New function.
8530 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8531 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8532 Call xg_get_pixbuf_from_pixmap instead of
8533 gdk_pixbuf_get_from_drawable.
8534 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8535 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8536 (xg_check_special_colors): Use GtkStyleContext and its functions
8537 for HAVE_GTK3.
8538 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8539 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8540 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8541 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8542 Call gtk_widget_get_preferred_size.
0afb4571
J
8543 (xg_frame_resized): gdk_window_get_geometry only takes 5
8544 parameters.
44f230aa
SM
8545 (xg_win_to_widget, xg_event_is_for_menubar):
8546 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8547 (xg_set_widget_bg): New function.
8548 (delete_cb): New function.
895009e1 8549 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8550 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8551 (xg_set_background_color): Call xg_set_widget_bg.
8552 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8553 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8554 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8555 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8556 if ! HAVE_GTK3.
8557 (update_frame_tool_bar): Call gtk_widget_hide.
8558 (xg_initialize): Use GDK_KEY_g.
8559
8560 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8561 if ! HAVE_GTK3
8562 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8563
8564 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8565 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8566 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8567
1c2cc4ef
JB
85682011-03-08 Juanma Barranquero <lekktu@gmail.com>
8569
8570 * w32xfns.c (select_palette): Check success of RealizePalette against
8571 GDI_ERROR, not zero.
8572
33383987 8573See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8574
8575;; Local Variables:
8576;; coding: utf-8
aac0c6e3
MR
8577;; End:
8578
33383987 8579 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8580
8581 This file is part of GNU Emacs.
8582
8583 GNU Emacs is free software: you can redistribute it and/or modify
8584 it under the terms of the GNU General Public License as published by
8585 the Free Software Foundation, either version 3 of the License, or
8586 (at your option) any later version.
8587
8588 GNU Emacs is distributed in the hope that it will be useful,
8589 but WITHOUT ANY WARRANTY; without even the implied warranty of
8590 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8591 GNU General Public License for more details.
8592
8593 You should have received a copy of the GNU General Public License
8594 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.