ChangeLog fixes
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5c0c0e8a
GM
12012-08-01 Glenn Morris <rgm@gnu.org>
2
3 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
4 Move to configure.ac.
5
552a99b4
JB
62012-08-01 Juanma Barranquero <lekktu@gmail.com>
7
8 * makefile.w32-in (CONFIG_H): Update dependencies.
9 (CONF_POST_H): New macro.
10
11 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
12
8d8e2dfe
GM
132012-07-31 Glenn Morris <rgm@gnu.org>
14
bc96620a
GM
15 * Makefile.in (S_FILE): No longer set by configure.
16
476b1b2d
GM
17 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
18 is available.
19 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
20
b2c7a106
GM
21 * process.h (NULL_DEVICE):
22 * emacs.c (SEPCHAR):
23 * editfns.c (USER_FULL_NAME): Let configure set them.
24
d53d062a
GM
25 * s/README, s/template.h: Remove files.
26
4515017f
GM
27 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
28
8d8e2dfe
GM
29 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
30 Move to configure.ac.
31
5b20b3cc
EZ
322012-07-31 Eli Zaretskii <eliz@gnu.org>
33
1e0afd9a
EZ
34 * .gdbinit (xframe): Adapt to introduction of FVAR and the
35 resulting renaming of 'struct frame' members.
36
5b20b3cc
EZ
37 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
38
39 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
40 after introduction of FVAR.
41
f1310128
JD
422012-07-31 Jan Djärv <jan.h.d@swipnet.se>
43
79e721e0
JD
44 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
45
46 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
47 instead of compositeToPoint.
48 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
49
8d7c7eed 50 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 51
e34f7f79
DA
522012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
53
54 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
55 * lisp.h (INTERNAL_FIELD): New macro.
56 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
57 (BVAR): Change to use INTERNAL_FIELD.
58 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
59 (KVAR): Change to use INTERNAL_FIELD.
60 * frame.h (FVAR): New macro.
61 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
62 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c
63 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c
64 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h,
65 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
66
c09bfb2f
DA
672012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
68
69 Miscellaneous fixes for non-default X toolkits.
70 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
71 * xterm.c (x_frame_of_widget): Remove redundant prototype.
72 Move under #ifdef USE_LUCID.
73 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
74 definition and usage to avoid warnings.
75
14c114ae
JD
762012-07-31 Jan Djärv <jan.h.d@swipnet.se>
77
78 * nsterm.m (openFiles): Fix previous checkin.
79
3bd21e82
PE
802012-07-31 Paul Eggert <eggert@cs.ucla.edu>
81
82 * indent.c (compute_motion): Remove unused local.
83
c1529ded
GM
842012-07-31 Glenn Morris <rgm@gnu.org>
85
400d5621
GM
86 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
87
268e2432
GM
88 * conf_post.h [USG5_4]:
89 Move remaining contents of s/usg5-4-common.h here.
90 * s/usg5-4-common.h: Remove file.
91
7552f3ee
GM
92 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
93 * s/irix6-5.h: Remove file.
94
6a381852
GM
95 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
96 * s/darwin.h: Remove file.
97
c1529ded
GM
98 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
99 * s/hpux10-20.h: Remove file, which is now empty.
100
b429a4ee
GM
1012012-07-30 Glenn Morris <rgm@gnu.org>
102
103 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
104 * Makefile.in (config_h): Add conf_post.h.
105 * makefile.w32-in (CONFIG_H): Add conf_post.h.
106
adff3182
JD
1072012-07-30 Jan Djärv <jan.h.d@swipnet.se>
108
109 * nsterm.m (ns_do_open_file): New variable.
b9031d69 110 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
111 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
112 files only if ns_do_open_file.
113
c32af1e4
PE
1142012-07-30 Paul Eggert <eggert@cs.ucla.edu>
115
7393bcbb
PE
116 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
117 This no-op macro hasn't been needed for many years.
118 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
119
c32af1e4
PE
120 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
121 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
122 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
123 gdb_make_enums_visible.
124 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
125 (DIRECTORY_SEP): Now a constant, not a macro.
126
302fc036
EZ
1272012-07-30 Eli Zaretskii <eliz@gnu.org>
128
129 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
130 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
131
132 * w32term.c <w32_keyboard_codepage>: Renamed from
133 keyboard_codepage and now external. All users changed.
134
135 * w32term.h: Add declaration of w32_keyboard_codepage.
136
137 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
138 the codepage to translate keys to Unicode. If this argument is
139 -1, use the value returned by GetConsoleCP. All callers changed.
140
88fb40b4
PE
1412012-07-30 Paul Eggert <eggert@cs.ucla.edu>
142
0aee6912
PE
143 Update .PHONY listings in makefiles.
144 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
145 bootstrap-clean, distclean, maintainer-clean, versioclean,
146 extraclean, frc.
147
88fb40b4
PE
148 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
149 This is a bit clearer. Fix some commentary typos.
150
0a763bd1
GM
1512012-07-30 Glenn Morris <rgm@gnu.org>
152
32bac6d6
GM
153 * s/netbsd.h: Let configure include signal.h if needed.
154 Remove file, which is now empty.
155
b65e7c46
GM
156 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
157 Let configure set them.
158 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
159 No more need to undefine.
0a763bd1 160
169304bd
AS
1612012-07-30 Andreas Schwab <schwab@linux-m68k.org>
162
163 * keymap.c (Fkey_description): Don't remove 0x80 bit from
164 non-single-byte char when adding meta modifier. (Bug#12090)
165
6cd7a139
DA
1662012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
167
168 Convert safe_call to use variable number of arguments.
169 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
170 (safe_call2): Fix comment.
171 * lisp.h (safe_call): Adjust prototype.
172 * coding.c (encode_coding_object): Change to use safe_call2.
173 * xfaces.c (merge_face_heights): Change to use safe_call1.
174
d34d6ffc
GM
1752012-07-30 Glenn Morris <rgm@gnu.org>
176
7b8a48e4 177 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 178 does that unconditionally. Remove file, which is now empty.
7b8a48e4 179
d34d6ffc
GM
180 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
181 Remove empty files.
182
03a660a6
PE
1832012-07-30 Paul Eggert <eggert@cs.ucla.edu>
184
185 Export to GDB most of lisp.h's remaining object-like macros.
186 * lisp.h (min, max): Move earlier, because they're used earlier now.
187 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
188 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
189 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
190 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
191 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
192 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
193 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
194 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
195 Now constants, for GDB. They need not be macros.
196 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
197 Now constants, for GDB, as well as macros, for static initializers.
198 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
199 Move to after the definition of struct Lisp_Char_Table,
200 since the former now needs that type defined.
201 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
202 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
203 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
204 New enums, for gdb_make_enums_visible.
205 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 206 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
207 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
208 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
209 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
210 enum maxargs, enum MAX_ALLOCA.
211 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
212 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
213 no longer needed, now that they are done in lisp.h.
214
e499d0ee
DA
2152012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
216
217 Cleanup string bytes checking.
218 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
219 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
220 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
221 (check_sblock, compact_small_strings): Simplify.
222
d5040d2d
PE
2232012-07-29 Paul Eggert <eggert@cs.ucla.edu>
224
225 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
226 These macros are confusing and no longer need to be defined, as
227 the enum values now suffice. All uses replaced with definiens.
228 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
229
7f259ae6
JB
2302012-07-29 Juanma Barranquero <lekktu@gmail.com>
231
232 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
233 ($(BLD)/w32console.$(O)): Update dependencies.
234
7e63e0c3
DA
2352012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
236
237 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
238 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
239 time. Adjust users.
240 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
241
ffd817eb
JD
2422012-07-29 Jan Djärv <jan.h.d@swipnet.se>
243
244 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
245 setting sitelisp (Bug#12010).
246
417a7a0e
EZ
2472012-07-29 Eli Zaretskii <eliz@gnu.org>
248
249 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
250
251 * w32heap.c (cache_system_info):
252 * w32.c (sys_rename):
253 * w32proc.c (find_child_console, sys_kill): All users changed.
254
387d4d92
PE
2552012-07-29 Paul Eggert <eggert@cs.ucla.edu>
256
257 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
258
55a6cca6
EZ
2592012-07-29 Eli Zaretskii <eliz@gnu.org>
260
261 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
262
dbcf001c
DA
2632012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
264
265 Cleanup statistics calculation in Fgarbage_collect.
266 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
267 zombies percentage calculation. Simplify elapsed time calculation.
268
e2688e4a
DA
2692012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
270
271 Generalize marker debugging code under MARKER_DEBUG and use eassert.
272 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
273 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
274 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
275 (replace_range, replace_range_2, del_range_2): Change to eassert.
276 * marker.c (byte_char_debug_check): Adjust style.
277
b46a6a83
PE
2782012-07-29 Paul Eggert <eggert@cs.ucla.edu>
279
280 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
281 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
282 long-ago-commented-out code that talks about "WIN32".
283 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
284 All uses changed.
285
e32a5799
PE
2862012-07-28 Paul Eggert <eggert@cs.ucla.edu>
287
288 Use Gnulib stdalign module (Bug#9772, Bug#9960).
289 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
290 Simplify by using alignof.
291 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
292 * lisp.h: Include <stdalign.h>.
293 (GCALIGNMENT): New macro and constant.
294 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
295 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
296 (stdalign): New macro, if not already defined.
297
df81cd29
EZ
2982012-07-28 Eli Zaretskii <eliz@gnu.org>
299
01bd1b0d
EZ
300 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
301 * w32inevt.c: Include w32inevt.h.
302 (w32_read_console_input): New inline function, calls either
303 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
304 w32_console_unicode_input.
305 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
306 (w32_kbd_patch_key, key_event): Use the codepage returned by
307 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
308 (key_event): use uChar.UnicodeChar only if
309 w32_console_unicode_input is non-zero.
310
311 * w32console.c: Include w32heap.h.
312 <w32_console_unicode_input>: New global variable.
313 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
314 family of Windows, zero otherwise.
315
316 * w32inevt.h: Declare w32_console_unicode_input.
317
df81cd29
EZ
318 * xdisp.c (init_iterator): Don't reference tip_frame in a build
319 --without-x. (Bug#11742)
320
c20fdd9e
PE
3212012-07-27 Paul Eggert <eggert@cs.ucla.edu>
322
323 Adjust GDB to reflect pvec_type changes (Bug#12036).
324 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
325 2012-07-04 changes to pseudovector representation. Problem
326 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
327
32770973 3282012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
329
330 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
331 bus address.
332 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
333
3438fe21
EZ
3342012-07-27 Eli Zaretskii <eliz@gnu.org>
335
bcfbc9de
EZ
336 * alloc.c (listn): Fix the order the arguments are consed onto the
337 list.
338
3438fe21
EZ
339 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
340 enumeration constants, as PURE and HEAP are too general, and clash
341 with other headers and sources, such as gmalloc.c and the
342 MS-Windows system headers. All users changed.
343
eeaea515
DA
3442012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
345
346 Revert last save_excursion_save and save_excursion_restore changes.
347 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
348 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
349
073c88c2
DA
3502012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
351
352 Fix recently-introduced typos in Windows port.
353 Reported by Martin Rudalics <rudalics@gmx.at>.
354 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 355 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 356
4706125e
PE
3572012-07-27 Paul Eggert <eggert@cs.ucla.edu>
358
359 Improve GDB symbol export (Bug#12036).
360 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
361 arms of an 'if', not using conditional expressions; otherwise GDB
362 complains about the types in the unevaluated arm when the argument
363 is an integer literal.
364 (xgetint): Simplify expression.
365 * alloc.c (gdb_make_enums_visible): New constant. This ports to
366 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
367 Zaretskii in <http://bugs.gnu.org/12036#13>.
368 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
369 needed now that we have gdb_make_enums_visible.
370 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
371 (enum enum_USE_LSB_TAG):
372 New enum types, packaging up enums that need to be exported to GDB.
373
694b6c97
DA
3742012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
375
376 Utility function to make a list from specified amount of objects.
377 * lisp.h (enum constype): New datatype.
378 (listn): New prototype.
379 * alloc.c (listn): New function.
380 (Fmemory_use_count, syms_of_alloc): Use it.
381 * buffer.c (syms_of_buffer): Likewise.
382 * callint.c (syms_of_callint): Likewise.
383 * charset.c (define_charset_internal): Likewise.
384 * coding.c (syms_of_coding): Likewise.
385 * keymap.c (syms_of_keymap): Likewise.
386 * search.c (syms_of_search): Likewise.
387 * syntax.c (syms_of_syntax): Likewise.
388 * w32.c (init_environment): Likewise.
389 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
390 * xdisp.c (syms_of_xdisp): Likewise.
391 * xfns.c (syms_of_xfns): Likewise.
392
6195f384
DA
3932012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
394
395 Fast save_excursion_save and save_excursion_restore.
396 * lisp.h (struct Lisp_Excursion): New data type.
397 (PVEC_EXCURSION): New pseudovector type.
398 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
399 to deal with it. Adjust comments.
400 (init_marker, attach_marker): New prototype.
401 (unchain_marker): Adjust prototype.
402 * marker.c (attach_marker): Change to global.
403 (init_marker): New function.
404 * alloc.c (Fmake_marker, build_marker): Use it.
405 (build_marker): More easserts.
406 (mark_object): Handle struct Lisp_Excursion.
407 * editfns.c (save_excursion_save, save_excursion_restore):
408 Reimplement to use struct Lisp_Excursion. Add comments.
409
5eceb8fb
PE
4102012-07-26 Paul Eggert <eggert@cs.ucla.edu>
411
412 Fix export of symbols to GDB (Bug#12036).
413 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
414 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
415 emacs.c, as this is a more-suitable home. Had this been done earlier
416 the fix for 12036 would have avoided some of the problems noted in
417 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
418 would have been more obvious.
562157c8
PE
419 * emacs.c: Do not include <verify.h>; no longer needed.
420 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
421 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
422 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
423 Remove; now done in lisp.h.
424 * lisp.h (PUBLISH_TO_GDB): New macro.
425 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
426 (DATA_SEG_BITS): Use it.
427 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
428 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
429 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
430 not be usable in #if. This simplifies things.
431
d6749401
JB
4322012-07-26 Juanma Barranquero <lekktu@gmail.com>
433
434 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
435
1781b9e9
PE
4362012-07-26 Paul Eggert <eggert@cs.ucla.edu>
437
d89518db 438 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
439 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
440 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
441 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
442 Adjust to changes in lisp.h and emacs.c, by using
443 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
444 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
445 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
446 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
447 instead of gdb_valbits.
448 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
449 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
450 instead of gdb_array_mark_flag.
451 (xboolvector): Get size from $->size, not $->header.size.
452 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
453 (xreload, hook-run, hookpost-run): Remove.
454 * emacs.c: Include <verify.h>.
455 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
456 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
457 Remove.
458 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
459 (gdb_USE_LSB_TAG): New enum constants.
460 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
461 Also define these as enum constants, so they're visible to GDB.
462 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
463 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
464 as constants, so they're visible to GDB.
465 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
466 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
467 Now enum constants, not macros, so they're visible to GDB.
468 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
469 more convenient now. All uses changed.
470 (VALMASK) [USE_LSB_TAG]: Also define in this case.
471 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
472
3628596a
DA
4732012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
474
475 Explicitly free restriction data that are not needed anymore.
476 * editfns.c (save_restriction_restore): Free restriction data.
477
7abaf5cc
SM
4782012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
479
480 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
481 add argument, tune behavior, and adjust all callers.
482
71f88e00
PE
4832012-07-25 Paul Eggert <eggert@cs.ucla.edu>
484
485 Use typedef for EMACS_INT, EMACS_UINT.
486 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
487 than macros. This simplifies debugging in the usual case, since
488 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
489 and it allows expressions involving EMACS_INT casts.
490 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
491
57ec3034
JD
4922012-07-25 Jan Djärv <jan.h.d@swipnet.se>
493
494 * nsterm.m (ns_read_socket): Return early if there is a modal
495 window (Bug#12043).
496
8137e7b3
MR
4972012-07-25 Martin Rudalics <rudalics@gmx.at>
498
499 * frame.c (Fredirect_frame_focus): In doc-string don't mention
500 that FOCUS-FRAME can be omitted.
501
04e9897c
DA
5022012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
503
504 Adjust buffer text indirection counters at the end of Fkill_buffer.
505 * buffer.c (Fkill_buffer): Adjust indirection counters when the
506 buffer is definitely dead. This should really fix an issue reported
507 by Christoph Scholtes again. (Bug#12007).
508 (init_buffer_once): Initialize indirection counters of
509 buffer_defaults and buffer_local_symbols (for sanity and safety).
510
8a0484e1
EZ
5112012-07-24 Eli Zaretskii <eliz@gnu.org>
512
513 * xdisp.c (init_iterator): Don't compute dimensions of truncation
514 and continuation glyphs on tooltip frames, leave them at zero.
515 Avoids continued lines in tooltips. (Bug#11832)
516
fa691a83
DA
5172012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
518
519 Simplify copy_overlay.
04e9897c 520 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
521 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
522
436bc8e0
EZ
5232012-07-23 Eli Zaretskii <eliz@gnu.org>
524
525 * print.c (print_object): Don't crash when a frame's name is nil
526 or invalid. (Bug#12025)
527
528 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
529 it signals an error when a tooltip frame is being created.
530
d7a7fda3
DA
5312012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
532
533 Cleanup miscellaneous objects allocation and initialization.
534 * alloc.c (allocate_misc): Change to static. Add argument to
535 specify the subtype. Adjust comment and users.
536 (build_overlay): New function.
537 * buffer.c (copy_overlays, Fmake_overlay): Use it.
538 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
539 (allocate_misc): Remove prototype.
540 (build_overlay): Add prototype.
541
5422012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
543
544 Swap buffer text indirection counters in Fbuffer_swap_text.
545 * buffer.c (Fbuffer_swap_text): Swap indirections too.
546 This avoids crash reported by Christoph Scholtes at
547 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
548
9d7fa573
JD
5492012-07-22 Jan Djärv <jan.h.d@swipnet.se>
550
551 * nsmenu.m (Popdown_data): New struct.
552 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
553 free Popdown_data.
554 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
555 (initWithContentRect): Make imgView and contentView non-static
556 and autorelease them. Also autorelease img and matrix (Bug#12005).
557 (dealloc): Remove (Bug#12005).
558
0dd6d66d
DA
5592012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
560
561 Adjust consing_since_gc when objects are explicitly freed.
562 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
563 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
564 (free_cons, free_misc): Subtract object size from consing_since_gc.
565
d36d71df
DA
5662012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
567
568 Simplify and cleanup markers positioning code.
569 * marker.c (attach_marker): More useful eassert.
570 (live_buffer, set_marker_internal): New function.
571 (Fset_marker, set_marker_restricted): Use set_marker_internal.
572 (set_marker_both, set_marker_restricted_both): Use live_buffer.
573
fb9ea40f
PE
5742012-07-22 Paul Eggert <eggert@cs.ucla.edu>
575
576 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
577 as it's limited by the amount of memory, not by INT_MAX.
578
2d5c5f7d
EZ
5792012-07-21 Eli Zaretskii <eliz@gnu.org>
580
07fb592e
EZ
581 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
582 in special-event-map. See the discussion at
583 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
584 for the reasons.
585
37a9eac8 586 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
587 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
588 Fabrice Popineau <fabrice.popineau@supelec.fr>.
589
c4328746
JD
5902012-07-21 Jan Djärv <jan.h.d@swipnet.se>
591
592 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 593 (conversationIdentifier): Return value is NSInteger.
784051c4 594 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 595
6e5d1c12
CY
5962012-07-21 Chong Yidong <cyd@gnu.org>
597
598 * window.c (decode_any_window): Signal an error if the window is
599 on a dead frame (Bug#11984).
600
9928463d
DA
6012012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
602
603 Add indirection counting to speed up Fkill_buffer.
604 * buffer.h (struct buffer): New member.
605 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
606 (Fmake_indirect_buffer): Set indirection counter to -1, increment
607 base buffer indirection counter.
608 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
609 (Fkill_buffer): Adjust indirection counters as needed, don't walk
610 through buffer list if indirection counter is 0.
611
f8643a6b
DA
6122012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
613
614 Extend the value returned by Fgarbage_collect with heap statistics.
615 * alloc.c (Qheap): New symbol.
616 (syms_of_alloc): DEFSYM it.
617 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
618 (Fmemory_free): Remove.
619 (syms_of_alloc): Don't defsubr it.
620 * buffer.c (Fcompact_buffer): Remove.
621 (syms_of_buffer): Don't defsubr it.
622
dac616ff
DA
6232012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
624
625 Make maybe_gc inline.
626 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
627 * lisp.h (consing_since_gc, gc_relative_threshold)
628 (memory_full_cons_threshold): Revert declaration.
629 (maybe_gc): Remove prototype, define as inline.
630 * alloc.c: Remove old commented-out code.
631 (consing_since_gc, gc_relative_threshold)
632 (memory_full_cons_threshold): Revert to global.
633 (maybe_gc): Remove.
634
d7ea76b4
DA
6352012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
636
637 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
638 * lisp.h (build_unibyte_string): New function.
639 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
640 * sysdep.c, w32fns.c, xfns.c: Use it.
641 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
642 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
643 Adjust users accordingly.
644 * font.h (font_open_by_name): Adjust prototype.
645
765e61e3
DA
6462012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
647
648 Cleanup calls to Fgarbage_collect.
649 * lisp.h (maybe_gc): New prototype.
650 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
651 Remove declarations.
652 * alloc.c (maybe_gc): New function.
653 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
654 Make them static.
655 * bytecode.c (MAYBE_GC): Use maybe_gc.
656 * eval.c (eval_sub, Ffuncall): Likewise.
657 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
658 to avoid dependency from auto-save feature.
659
52b852c7
PE
6602012-07-19 Paul Eggert <eggert@cs.ucla.edu>
661
662 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
663 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
664 'for_each_per_buffer_object_at'.
665 All uses changed. It's better to use upper-case for macros that
666 cannot be implemented as functions, to give the reader a clue
667 that they're special.
668
5db81e33
SM
6692012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
670
671 * alloc.c (Fgarbage_collect): Tweak docstring.
672
5b835e1d
DA
6732012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
674
675 Tweak the value returned from Fgarbage_collect again.
676 * alloc.c (Fgarbage_collect): New return value, as confirmed in
677 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
678 Adjust documentation.
679 (total_vector_bytes): Rename to total_vector_slots, adjust
680 accounting.
681 (total_free_vector_bytes): Rename to total_free_vector_slots,
682 adjust accounting.
683 (Qstring_bytes, Qvector_slots): New symbols.
684 (syms_of_alloc): DEFSYM them.
685
9cd47b72
DA
6862012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
687
688 Buffer compaction primitive which may be used from Lisp.
689 * buffer.c (compact_buffer, Fcompact_buffer): New function.
690 (syms_of_buffer): Register Fcompact_buffer.
691 * alloc.c (Fgarbage_collect): Use compact_buffer.
692 * buffer.h (compact_buffer): New prototype.
693 (struct buffer_text): New member.
694
d17337e5
DA
6952012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
696
697 New macro to iterate over all buffers, miscellaneous cleanups.
698 * lisp.h (all_buffers): Remove declaration.
699 * buffer.h (all_buffers): Add declaration, with comment.
700 (for_each_buffer): New macro.
701 * alloc.c (Fgarbage_collect, mark_object): Use it.
702 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
703 (init_buffer): Likewise.
704 * data.c (Fset_default): Likewise.
705 * coding.c (code_conversion_restore): Remove redundant check
706 for dead buffer.
707 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
708
60cfd278
AS
7092012-07-18 Andreas Schwab <schwab@linux-m68k.org>
710
711 Fix bug that created negative-length intervals.
712 * intervals.c (merge_interval_right, merge_interval_left):
713 Do not zero out this interval if it is absorbed by its children,
714 as this interval's total length doesn't change in that case. See
715 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
716
d06714cb
PE
7172012-07-18 Paul Eggert <eggert@cs.ucla.edu>
718
83713154
PE
719 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
720 when invoking (make-bool-vector N t) and N is a positive
721 multiple of 8 -- the last 8 bits were mistakenly cleared.
722
d06714cb
PE
723 Remove some struct layout assumptions in bool vectors.
724 * alloc.c (bool_header_size): New constant.
725 (header_size, word_size): Move earlier, as they're now used earlier.
726 Use 'word_size' in a few more places, where it's appropriate.
727 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
728 padding before the data member of a bool vector.
729 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
730 than doing the check by hand with an abort ().
731
464d5a5e
SM
7322012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
733
5fbc0409
SM
734 * eval.c (Fdefvar): Don't check constants since we only set the var if
735 it's not yet defined anyway (bug#11904).
736
464d5a5e
SM
737 * lisp.h (last_undo_boundary): Declare new var.
738 * keyboard.c (command_loop_1): Set it.
739 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
740 were auto-added by the command loop (bug#11774).
741
8dc2e44a
AS
7422012-07-18 Andreas Schwab <schwab@linux-m68k.org>
743
744 * w32font.c (Qsymbol): Remove local definition.
745 (syms_of_w32font): Don't DEFSYM it.
746
169925ec
DA
7472012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
748
749 Fix sweep_vectors to handle large bool vectors correctly.
750 * alloc.c (sweep_vectors): Account total_vector_bytes for
751 bool vectors larger than VBLOCK_BYTES_MAX.
752
5fbfb018
CY
7532012-07-18 Chong Yidong <cyd@gnu.org>
754
755 * frame.c (x_set_frame_parameters): Revert bogus change introduced
756 in 2012-05-25 commit by Paul Eggert (Bug#11738).
757
3ab6e069
DA
7582012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
759
760 Return more descriptive data from Fgarbage_collect.
761 Suggested by Stefan Monnier in
762 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
763 * alloc.c (bounded_number): New function.
764 (total_buffers, total_vectors): New variable.
765 (total_string_size): Rename to total_string_bytes, adjust users.
766 (total_vector_size): Rename to total_vector_bytes, adjust users.
767 (sweep_vectors): Account total_vectors and total_vector_bytes.
768 (Fgarbage_collect): New return value. Adjust documentation.
769 (gc_sweep): Account total_buffers.
770 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
771 (VECTOR_SIZE): Remove.
772 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
773 (Qinterval, Qmisc): New symbols.
774 (syms_of_data): Initialize them.
775 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
776 (Qcons, Qbuffer): New declarations.
777
6d02fe5b
PE
7782012-07-17 Paul Eggert <eggert@cs.ucla.edu>
779
780 * alloc.c (Fmemory_free): Account for memory-free's own storage.
781 Round up, not down. Improve doc.
782
b7ffe040
DA
7832012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
784
785 Restore old code in allocate_string_data to avoid Faset breakage.
786 Reported by Julien Danjou <julien@danjou.info> in
787 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
788 * alloc.c (allocate_string_data): Restore old code with minor
789 adjustments, fix comment to explain this subtle issue.
790
4dc7c8d5
SM
7912012-07-17 Eli Zaretskii <eliz@gnu.org>
792
793 Remove FILE_SYSTEM_CASE.
794 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
795
796 * fileio.c (FILE_SYSTEM_CASE): Don't define.
797 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
798 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
799 call-process-region passes it through expand-file-name.
800
801 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
802
8032012-07-17 Andreas Schwab <schwab@linux-m68k.org>
804
805 Fix crash when creating indirect buffer (Bug#11917)
806 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
807 Don't handle unbound variables specially if non-zero.
808 (Fbuffer_local_variables): Pass zero.
809 (clone_per_buffer_values): Pass non-zero.
810
8112012-07-17 Andreas Schwab <schwab@linux-m68k.org>
812
813 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
814 to make the loop interruptible.
815
8162012-07-17 Andreas Schwab <schwab@linux-m68k.org>
817
818 * gnutls.c (emacs_gnutls_handshake): Only retry if
819 GNUTLS_E_INTERRUPTED.
820
cce7fefc
DA
8212012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
822
823 Cleanup and convert miscellaneous checks to eassert.
824 * alloc.c (mark_interval): Fix comment, partially rephrase
825 old comment from intervals.h (see below).
826 * intervals.c (find_interval, adjust_intervals_for_insertion)
827 (delete_interval, adjust_intervals_for_deletion)
828 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
829 Convert to eassert.
830 (adjust_intervals_for_insertion, make_new_interval):
831 Remove obsolete and unused code.
832 * intervals.h (struct interval): Remove obsolete comment.
833 * textprotp.c (erase_properties): Remove unused code.
834 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
835 (Fremove_list_of_text_properties): Convert to eassert.
836
9ea10cc3
CY
8372012-07-17 Chong Yidong <cyd@gnu.org>
838
839 * editfns.c (Finsert_char): Doc fix.
840
3900d5de
DA
8412012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
842
843 Fix previous change to make Fmemory_free always accurate.
844 * alloc.c (make_interval): Update total_free_intervals.
845 (make_float): Likewise for total_free_floats.
846 (free_cons, Fcons): Likewise for total_free_conses.
847 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
848 Likewise for total_free_vector_bytes.
849 (Fmake_symbol): Likewise for total_free_symbols.
850 (bytes_free): Remove.
851
7098646f
DA
8522012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
853
854 Simple free memory accounting feature.
855 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
856 (sweep_vectors): Accumulate size of free vectors.
857 (Fgarbage_collect): Setup bytes_free.
858 (Fmemory_free): New function.
859 (syms_of_alloc): Register it.
860
22657b40
DA
8612012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
862
863 Cleanup overlays checking.
864 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
865 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
866 eassert and OVERLAYP.
867 (sort_overlays): Change to use OVERLAYP.
868
ddfc8813
RK
8692012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
870
871 * editfns.c (Finsert_char): Make it interactive, and make the
872 second arg optional. Copy interactive spec and docstring from
873 ucs-insert.
874
7c26cf3c
PE
8752012-07-17 Paul Eggert <eggert@cs.ucla.edu>
876
877 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
878 Unlike the other wrapped functions, fabs has an unspecified
879 effect on errno.
880
5d127af9
JD
8812012-07-16 Jan Djärv <jan.h.d@swipnet.se>
882
883 * nsterm.m (keyDown): Interpret flags without left/right bits
884 as the left key (Bug#11670).
885
6a0dd1d7
DA
8862012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
887
888 Remove empty and useless init functions.
889 * lisp.h (init_character_once, init_fns, init_image)
890 (init_filelock, init_sound): Remove prototype.
891 * character.c (init_character_once): Remove.
892 * filelock.c (init_filelock): Likewise.
893 * fns.c (init_fns): Likewise.
894 * image.c (init_image): Likewise.
895 * sound.c (init_sound): Likewise.
896 * emacs.c (main): Adjust accordingly.
897
7a6136fd
DA
8982012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
899
900 * gtkutil.h: Tiny cleanups.
901 (use_old_gtk_file_dialog): Remove useless declaration.
902 (xg_uses_old_file_dialog): Add suggested const attribute.
903
ce811ad9
EZ
9042012-07-15 Eli Zaretskii <eliz@gnu.org>
905
906 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
907 (bidi_paragraph_init): Use it to limit search forward for a strong
908 directional character in abnormally large paragraphs full of
909 neutral or weak characters. (Bug#11943)
910
c9adfeaa
SF
9112012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
912
913 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
914 the toolbar (Bug#9451).
915 (xg_make_tool_item): Give the widget event box a transparent
916 background.
917
fff62aa9
DA
9182012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
919
920 Cleanup basic allocation variables and functions.
921 * alloc.c (ignore_warnings, init_intervals, init_float)
922 (init_cons, init_symbol, init_marker): Remove.
923 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
924 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
925 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
926 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
927 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
928 (staticidx, init_alloc_once, init_strings, free_ablock):
929 Remove redundant initialization.
930 * fns.c (init_weak_hash_tables): Remove.
931 * lisp.h (init_weak_hash_tables): Remove prototype.
932
9730daca
DA
9332012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
934
935 Use zero_vector where appropriate.
936 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
937 accordingly.
938 * lisp.h (zero_vector): New declaration.
939 * font.c (null_vector): Remove.
940 (syms_of_font): Remove initialization and staticpro.
941 (font_list_entities, font_find_for_lface): Change to use zero_vector.
942 * keymap.c (Faccessible_keymaps): Likewise.
943
2e2d2a13
LL
9442012-07-15 Leo Liu <sdl.web@gmail.com>
945
946 * fringe.c: Fix typo in comments.
947
cd276f6e
LL
9482012-07-14 Leo Liu <sdl.web@gmail.com>
949
950 * fringe.c: Add a new bitmap exclamation-mark.
951
5a1131d9
EZ
9522012-07-14 Eli Zaretskii <eliz@gnu.org>
953
954 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
955
956 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
957 (HAVE_MENUS): Don't define, defined by editing config.in with
958 msdos/sed2v2.inp.
959 (GMALLOC_INHIBIT_VALLOC): Don't define.
960 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
961
22e983b7
JB
9622012-07-14 Juanma Barranquero <lekktu@gmail.com>
963
964 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
965
5b3f250f
GM
9662012-07-14 Glenn Morris <rgm@gnu.org>
967
968 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
969 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
970 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
971
33d63ff4
GM
9722012-07-13 Glenn Morris <rgm@gnu.org>
973
5b633342
GM
974 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
975
33d63ff4
GM
976 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
977 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
978
b55b9f85
JD
9792012-07-13 Jan Djärv <jan.h.d@swipnet.se>
980
0dc8cf50
JD
981 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
982 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
983 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
984 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
985 where appropriate.
986 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
987 as boolean expression.
988 (x_set_window_size): Remove unused variable toolbar.
989 (ns_get_color_default, ns_mod_to_lisp): Remove.
990 (ns_mouse_position): Remove unused variables xchar and ychar.
991 (ns_compute_glyph_string_overhangs): Remove unused variable face.
992 (ns_set_vertical_scroll_bar): Remove unused variable count.
993 (ns_delete_terminal): Remove unused variable i.
994 (ns_term_init): Remove unused variables r, g and b.
995 (mouseDown): Remove unused variable window.
996 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
997 (initFrameFromEmacs): Remove unused variable vbextra.
998 (mouseEntered): Remove unused variables p and dpyinfo.
999 (mouseExited): Remove unused variables p and r.
1000 (ns_define_frame_cursor, ns_clear_frame_area)
1001 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1002 (menuDown): Assign [sender tag] to variable and cast the variable.
1003
1004 * nsterm.h (menuDown): Add id as type to argument sender.
1005 (ns_display_info_for_name): Add Lisp_Object argument.
1006 (ns_term_init): Add Lisp_Object argument.
1007 (ns_map_event_to_object): Add void argument.
1008 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1009 prototype with arguments and only declare if __OBJC__.
1010 (nxatoms_of_nsselect): Add void argument.
1011 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1012 (ns_alloc_autorelease_pool): Add void argument.
1013 (ns_release_autorelease_pool): Add void* argument.
1014 (ns_get_defaults_value): Add const char* argument.
1015
1016 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1017 (initFromContents): Use SSDATA where appropriate.
1018 (ns_update_menubar): Add braces to ambigous if-else.
1019 (initWithTitle): Put () around assignment in if statement.
1020 (ns_menu_show): Remove unused variables window and keymap.
1021 (update_frame_tool_bar): Remove unused variable selected_p.
1022 (initWithContentRect): Remove unused variable this_cmd_name.
1023
1024 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1025 appropriate.
1026 (setXBMColor): Remove unused variable len.
1027 (setPixmapData): Put () around assignment in loop statement.
1028
1029 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1030 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1031 where appropriate.
1032 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1033 around assignment in loop statement.
1034 (nsfont_open): Remove unused variable i.
1035 (nsfont_open): Remove unused variable len.
1036 (nsfont_draw): Remove unused variable cs.
1037
1038 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1039 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1040 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1041 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1042 (Fns_font_name, Fns_perform_service)
1043 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1044 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1045 (ns_set_name): Remove unused variable view.
1046 (x_set_menu_bar_lines): Remove unused variable olines.
1047 (x_set_tool_bar_lines): Remove unused variable root_window.
1048 (Fns_list_colors): Put () around assignment in while statement.
1049 (Fns_perform_service): Remove unused variable len.
1050 (Fns_display_usable_bounds): Remove unused variable top.
1051 (syms_of_nsfns): Remove unused variable i.
1052
b55b9f85
JD
1053 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1054 memcpy (Bug#11907).
1055
ed9265fc 10562012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1057
1058 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1059 and free it with DestroyExceptionInfo (Bug#11558).
1060
ef099b57
JB
10612012-07-13 Juanma Barranquero <lekktu@gmail.com>
1062
1063 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1064 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1065 Set here, not in nt/config.nt.
1066
ea814a5d
EZ
10672012-07-13 Eli Zaretskii <eliz@gnu.org>
1068
1069 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1070 cursor overflow into the last glyph on display line when the right
1071 fringe is off. (Bug#11832)
1072
1a952767
PE
10732012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1074
1075 * xdisp.c (produce_special_glyphs): Now static.
1076 * dispextern.h (produce_special_glyphs): Remove decl.
1077
983188fd
GM
10782012-07-13 Glenn Morris <rgm@gnu.org>
1079
8d7c7eed 1080 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1081 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1082
983188fd
GM
1083 * s/usg5-4-common.h (USG, USG5):
1084 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1085 * s/sol2-6.h (SOLARIS2):
1086 * s/irix6-5.h (IRIX6_5):
1087 * s/hpux10-20.h (USG, USG5, HPUX):
1088 * s/gnu-linux.h (USG, GNU_LINUX):
1089 * s/freebsd.h (BSD_SYSTEM):
1090 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1091 * s/cygwin.h (CYGWIN):
1092 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1093 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1094
d1e68667 10952012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1096
1097 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1098
6de0e799
GM
10992012-07-13 Glenn Morris <rgm@gnu.org>
1100
739ae010
GM
1101 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1102
dbee5793
GM
1103 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1104
6de0e799
GM
1105 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1106 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1107
b82da769
GM
11082012-07-12 Glenn Morris <rgm@gnu.org>
1109
4fae5a7a 1110 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1111
1112 * process.c (init_process_emacs): Rename from init_process.
1113 The old name is also the name of a Mach system call.
1114 * lisp.h, emacs.c: Update for this name change.
1115 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1116 longer needed.
1117
5a979817
EZ
11182012-07-12 Eli Zaretskii <eliz@gnu.org>
1119
1120 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1121 memmove call that removes glyphs covered by the left truncation
1122 glyph. Improve commentary.
1123 (display_line): Fix display of continuation glyphs on GUI frames
1124 when the right fringe is turned off and variable-size fonts are
1125 used in the window. Move the code that appends a stretch glyph to
1126 produce_special_glyphs, so that it could be used for truncation
1127 and continuation glyphs alike.
1128 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1129 glyph of a suitably computed width, to align the special glyphs at
1130 the window margin. Code moved from display_line. (Bug#11832)
1131
3e91a053
GM
11322012-07-12 Glenn Morris <rgm@gnu.org>
1133
ba9e4b84
GM
1134 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1135
1136 * s/gnu-linux.h, s/hpux10-20.h:
1137 Do not unconditionally define HAVE_XRMSETDATABASE.
1138
3e91a053
GM
1139 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1140
b300b1f4
PE
11412012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1142
1143 Fix typos that broke OS X build.
1144 Reported by Randal L. Schwartz in
1145 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1146 * nsterm.m (ns_timeout): Add missing local decl.
1147 (ns_get_color): snprintf -> sprintf, to fix typo.
1148
6e777848
GM
11492012-07-12 Glenn Morris <rgm@gnu.org>
1150
3f922c37
GM
1151 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1152 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1153 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1154 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1155
0ab7b23a
GM
1156 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1157 Move PTY_OPEN to configure.
1158
6e777848
GM
1159 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1160 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1161 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1162
4a7edc24
DA
11632012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1164
1165 Use empty_unibyte_string where applicable.
1166 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1167 * lread.c (read1): Likewise.
1168 * xsettings.c (syms_of_xsettings): Likewise.
1169
308aab79
GM
11702012-07-12 Glenn Morris <rgm@gnu.org>
1171
42bd1719
GM
1172 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1173 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1174 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1175 * s/hpux10-20.h (RUN_TIME_REMAP):
1176 * s/bsd-common.h (TABDLY): Move to configure.
1177
1178 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1179
1180 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1181
ea0bbd17 1182 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1183 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1184
1185 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1186
308aab79
GM
1187 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1188 * s/template.h: Move NARROWPROTO to configure.
1189
ee1cf5cf
GM
11902012-07-11 Glenn Morris <rgm@gnu.org>
1191
30fe9bf4
GM
1192 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1193 unused since 2011-01-17 change to systty.h.
1194
ee1cf5cf
GM
1195 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1196 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1197 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1198
63e47e07
PE
11992012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1202
c43fb4c3
GM
12032012-07-11 Glenn Morris <rgm@gnu.org>
1204
1205 * s/darwin.h, s/gnu-linux.h, s/template.h:
1206 Move INTERRUPT_INPUT to configure.
1207
e8df9267
DA
12082012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1209
1210 Minor adjustments to interning code.
1211 * lisp.h (intern, intern_c_string): Redefine as static inline
1212 wrappers for intern_1 and intern_c_string_1, respectively.
1213 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1214 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1215 Vobarray checking.
e8df9267
DA
1216 * font.c (font_intern_prop): Likewise. Adjust comment.
1217 * w32font.c (intern_font_name): Likewise.
1218
34348bd4
AS
12192012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1220
d96a1e0c
AS
1221 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1222
34348bd4
AS
1223 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1224 of Fcar/Fcdr if possible.
1225 * font.c (check_otf_features): Likewise.
1226 * fontset.c (Fnew_fontset): Likewise.
1227 * gnutls.c (Fgnutls_boot): Likewise.
1228 * minibuf.c (read_minibuf): Likewise.
1229 * msdos.c (IT_set_frame_parameters): Likewise.
1230 * xmenu.c (Fx_popup_dialog): Likewise.
1231 * w32menu.c (Fx_popup_dialog): Likewise.
1232
c8add24e
GM
12332012-07-11 Glenn Morris <rgm@gnu.org>
1234
4b575b3c
GM
1235 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1236 since nothing has defined it on these platforms.
1237
09f4e3b0
GM
1238 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1239 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1240
172bedef
GM
1241 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1242 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1243 Move CLASH_DETECTION to configure.
1244
249685df
GM
1245 * s/gnu.h: Remove file, which is now empty.
1246
c8add24e
GM
1247 * s/gnu.h, s/gnu-linux.h:
1248 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1249
b41253a3
JW
12502012-07-11 John Wiegley <johnw@newartisans.com>
1251
1252 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1253 function attribute, so we only use it if it exists in the
1254 compiler.
1255
d923b542
DA
12562012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1257
1258 Avoid call to strlen in fast_c_string_match_ignore_case.
1259 * search.c (fast_c_string_match_ignore_case): Change to use
1260 length argument. Adjust users accordingly.
1261 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1262
5ebbef1d
PE
12632012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1264
bb352260
PE
1265 Assume mkdir, rmdir.
1266 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1267 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1268
57054ddd
PE
1269 Assume rename.
1270 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1271
b747d3f7
PE
1272 Assume perror.
1273 * s/hpux10-20.h (HAVE_PERROR): Remove.
1274 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1275 Remove dummy definition, as this problem was obsolete long ago.
1276
5ebbef1d
PE
1277 Assume strerror.
1278 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1279
984e7f30
DA
12802012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1281
1282 Avoid calls to strlen in font processing functions.
1283 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1284 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1285 users accordingly.
d923b542
DA
1286 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1287 Adjust prototypes.
1288 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1289 Change to return ptrdiff_t.
984e7f30
DA
1290 (xfont_list_pattern, xfont_match): Use length returned by
1291 xfont_decode_coding_xlfd.
1292 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1293
20e94fdd
GM
12942012-07-11 Glenn Morris <rgm@gnu.org>
1295
9d596af3
GM
1296 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1297 Move DONT_REOPEN_PTY to configure.
1298
20e94fdd
GM
1299 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1300 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1301
e99a530f
PE
13022012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1303
22ffb973
PE
1304 Remove "#define unix" that is no longer needed (Bug#11905).
1305 * s/aix4-2.h (unix): Remove; no longer needed.
1306
e9a9ae03
PE
1307 EMACS_TIME simplification (Bug#11875).
1308 This replaces macros (which typically do not work in GDB)
1309 with functions, typedefs and enums, making the code easier to debug.
1310 The functional style also makes code easier to read and maintain.
1311 * systime.h: Include <sys/time.h> on all hosts, not just if
1312 WINDOWSNT, since 'struct timeval' is needed in general.
1313 (EMACS_TIME): Now a typedef, not a macro.
1314 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1315 not macros.
1316 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1317 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1318 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1319 (EMACS_TIME_LE): Now functions, not macros.
1320 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1321 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1322 which are not functions. All uses rewritten to use:
1323 (make_emacs_time): New function.
1324 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1325 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1326 not functions. All uses rewritten to use the following, respectively:
1327 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1328 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1329 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1330 * fileio.c (Fcopy_file):
1331 * xterm.c (XTflash): Get the current time closer to when it's used.
1332 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1333
ffacb126
PE
1334 * bytecode.c (targets): Suppress -Woverride-init warnings.
1335
e99a530f
PE
1336 Simplify by avoiding confusing use of strncpy etc.
1337 * doc.c (Fsnarf_documentation):
1338 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1339 * frame.c (Fmake_terminal_frame):
1340 * gtkutil.c (get_utf8_string):
1341 * lread.c (openp):
1342 * nsmenu.m (ns_update_menubar):
1343 * regex.c (regerror):
1344 Prefer memcpy to strncpy and strncat when either will do.
1345 * fileio.c (Fsubstitute_in_file_name):
1346 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1347 (menu_separator_name_p):
1348 * nsmenu.m (ns_update_menubar):
1349 Prefer memcmp to strncmp when either will do.
1350 * nsterm.m: Include <ftoastr.h>.
1351 (ns_get_color):
1352 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1353 Prefer snprintf to strncpy.
1354 * nsterm.m (ns_term_init):
1355 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1356 * nsterm.m (ns_term_init):
1357 Avoid the need for strncpy, by using build_string or
1358 make_unibyte_string directly. Use dtoastr, not snprintf.
1359 * process.c (Fmake_network_process): Diagnose service names that
1360 are too long, rather than silently truncating them or creating
1361 non-null-terminated names.
1362 (Fnetwork_interface_info): Likewise, for interface names.
1363 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1364 Prefer sprintf to strncat.
1365 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1366 Prefer vsnprintf to vsprintf + strncpy.
1367
c59592b3
GM
13682012-07-10 Glenn Morris <rgm@gnu.org>
1369
1370 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1371 Clarify fallback case.
1372
7d7bbefd
DA
13732012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1374
1375 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1376 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1377 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1378 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1379 where argument type is known to be a Lisp_Cons.
1380
3a4c8000
TT
13812012-07-10 Tom Tromey <tromey@redhat.com>
1382
1383 * bytecode.c (BYTE_CODE_THREADED): New macro.
1384 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1385 (enum byte_code_op): New type.
1386 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1387 (exec_byte_code): Use them. Use token threading when applicable.
1388
2a0213a6
DA
13892012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1390
1391 Optimize pure C strings initialization.
1392 * lisp.h (make_pure_string): Fix prototype.
1393 (build_pure_c_string): New function, defined as static inline. This
1394 provides a better opportunity to optimize away calls to strlen when
1395 the function is called with compile-time constant argument.
1396 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1397 argument, adjust users accordingly. Use build_pure_c_string where
1398 appropriate.
1399 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1400 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1401 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1402
cb1caeaf
DA
14032012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1404
1405 Avoid calls to strlen in miscellaneous functions.
1406 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1407 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1408 * lread.c (openp): Likewise.
1409
c293e30c
DA
14102012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1411
1412 Avoid calls to strlen in path processing functions.
1413 * fileio.c (file_name_as_directory): Add comment. Change to add
1414 srclen argument and return the length of result. Adjust users
1415 accordingly.
1416 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1417 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1418 users accordingly.
1419 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1420
9e059e3f
GM
14212012-07-10 Glenn Morris <rgm@gnu.org>
1422
d02eb359
GM
1423 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1424 Move PENDING_OUTPUT_COUNT definition to configure.
1425
882cf227
GM
1426 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1427 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1428 * s/gnu.h (DATA_START): Move definitions to configure.
1429
af6e839f
GM
1430 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1431 We include usg5-4-common.h, which defines them both.
1432
40289a12
GM
1433 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1434 O_RDONLY already includes it).
1435
9e059e3f
GM
1436 Stop ns builds setting the EMACSLOADPATH environment variable.
1437 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1438 Now it does not set EMACSLOADPATH, just returns the load-path string.
1439 * nsterm.h: Update accordingly.
1440 * lread.c [HAVE_NS]: Include nsterm.h.
1441 (init_lread) [HAVE_NS]: Use ns_load_path.
1442 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1443
7c4e8ec0
GM
14442012-07-09 Glenn Morris <rgm@gnu.org>
1445
d4f600ff
GM
1446 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1447 since the included bsd-common.h does so.
1448
cbb31951
GM
1449 Stop ns builds setting the EMACSPATH environment variable.
1450 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1451 (ns_init_paths): Do not set EMACSPATH.
1452 * nsterm.h (ns_exec_path): Add it.
1453 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1454 Use ns_exec_path.
1455
7c4e8ec0
GM
1456 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1457
26bccfae
PE
14582012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1459
a0bee46f
PE
1460 * process.c (wait_reading_process_output): 'waitchannels' was unset
1461 when read_kbd || !NILP (wait_for_cell); fix this.
1462
5994c183
PE
1463 Add GCC-style 'const' attribute to functions that can use it.
1464 * character.h (char_resolve_modifier_mask):
1465 * keyboard.h (make_ctrl_char):
1466 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1467 (init_character_once, next_almost_prime, init_fns, init_image)
1468 (flush_pending_output, init_sound):
1469 * mem-limits.h (start_of_data):
1470 * menu.h (finish_menu_items):
1471 Add ATTRIBUTE_CONST.
1472 * emacs.c (DEFINE_DUMMY_FUNCTION):
1473 Declare the dummy function with ATTRIBUTE_CONST.
1474 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1475 Add decls with ATTRIBUTE_CONST.
1476
26bccfae
PE
1477 Minor improvements to make_formatted_string.
1478 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1479 where int is good enough, as vsprintf returns an int.
1480 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1481
a8290ec3
DA
14822012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1483
1484 Use make_formatted_string to avoid double length calculation.
1485 * lisp.h (make_formatted_string): New prototype.
1486 * alloc.c (make_formatted_string): New function.
1487 * buffer.c (Fgenerate_new_buffer_name): Use it.
1488 * dbus.c (syms_of_dbusbind): Likewise.
1489 * editfns.c (Fcurrent_time_zone): Likewise.
1490 * filelock.c (get_boot_time): Likewise.
1491 * frame.c (make_terminal_frame, set_term_frame_name)
1492 (x_report_frame_params): Likewise.
1493 * image.c (gs_load): Likewise.
1494 * minibuf.c (get_minibuffer): Likewise.
1495 * msdos.c (dos_set_window_size): Likewise.
1496 * process.c (make_process): Likewise.
1497 * xdisp.c (ensure_echo_area_buffers): Likewise.
1498 * xsettings.c (apply_xft_settings): Likewise.
1499
d01ba2f1
GM
15002012-07-09 Glenn Morris <rgm@gnu.org>
1501
1502 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1503 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1504 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1505 * nsterm.h (ns_etc_directory): Add it.
1506 * callproc.c [HAVE_NS]: Include nsterm.h.
1507 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1508
f1f924b6
DA
15092012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1510
1511 Move marker debugging code under MARKER_DEBUG.
1512 * marker.c (MARKER_DEBUG): Move marker debugging code under
1513 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1514 for bootstrap with --enable-checking (~3x slowdown reported
1515 by Juanma Barranquero <lekktu@gmail.com>).
1516 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1517
ab531b66
PE
15182012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1521 See <http://bugs.gnu.org/11825#29>.
1522
c4b3bc8a
EZ
15232012-07-08 Eli Zaretskii <eliz@gnu.org>
1524
1525 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1526 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1527 (display_line): Add commentary about displaying truncation glyphs
1528 on GUI frames.
1529 (produce_special_glyphs): Move here from term.c.
1530
1531 * term.c (produce_special_glyphs): Move to xdisp.c.
1532
1533 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1534 section.
c4b3bc8a 1535
b676b881
AS
15362012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1537
f17c5273
AS
1538 * xdisp.c (display_line): Avoid warning about implicit declaration
1539 of FRAME_FONT.
1540
298819b9
AS
1541 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1542
b676b881
AS
1543 * lisp.h: Remove empty conditional.
1544
6045c4fd
PE
15452012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1546
b3350bf9
PE
1547 * lread.c (load_path_check): Now static.
1548
6045c4fd
PE
1549 Fix some minor --with-ns problems found by static checking.
1550 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1551 (x_set_font) [!HAVE_X_WINDOWS]:
1552 * image.c (xpm_load_image) [HAVE_NS]:
1553 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1554 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1555 Remove unused local.
1556 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1557 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1558 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1559 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1560 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1561 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1562 Fix pointer signedness problem.
1563 * xfaces.c (FRAME_X_FONT_TABLE):
1564 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1565
929e7845
GM
15662012-07-07 Glenn Morris <rgm@gnu.org>
1567
1568 * lread.c (load_path_check): New function, split from init_lread.
1569 (init_lread): Reorganize. Motivation:
1570 If EMACSLOADPATH is set, check/warn about that rather than the
1571 defaults, which we are not going to use. Hence we can remove
1572 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1573 Don't warn if site-lisp directories are missing.
1574 If not installed, start from a blank load-path, since
1575 PATH_LOADSEARCH refers to the eventual installation directories.
1576
58dd0aa4
EZ
15772012-07-07 Eli Zaretskii <eliz@gnu.org>
1578
1579 Support truncation and continuation glyphs on GUI frames, when
1580 fringes are disabled. (Bug#11832)
1581 * xdisp.c (init_iterator): Get dimensions of truncation and
1582 continuation glyphs even if on GUI frames. Adjust
1583 it->last_visible_x on GUI frames when the left or right fringes,
1584 or both, are absent.
1585 (start_display, move_it_in_display_line_to): Handle the case of a
1586 GUI frame without a fringe to display continuation or truncation
1587 glyphs.
1588 (insert_left_trunc_glyphs): Support GUI frames: make sure
1589 truncation glyphs overwrite enough glyphs from the current line to
1590 have sufficient space in pixels.
1591 (display_line): Support truncation and continuation glyphs on GUI
1592 frames. If some spare pixels are left on the line after inserting
1593 the truncation glyphs, fill that space with a stretch glyph of a
1594 suitably computed width.
1595
1596 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1597 produce_glyphs, to support GUI sessions.
1598
31571fd7
PE
15992012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1600
5a16b9bc
PE
1601 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1602
f3047c75
PE
1603 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1604
31571fd7
PE
1605 Do not require float-time's arg to fit in time_t (Bug#11825).
1606 This works better on hosts where time_t is unsigned, and where
1607 float-time is applied to the (negative) difference between two times.
1608 * editfns.c (decode_time_components): Last arg is now double *,
1609 not int *, and means to store all the result as a double, without
1610 worrying about whether the seconds part fits in time_t.
1611 All callers changed.
1612 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1613 All callers changed.
1614 (Ffloat_time): Do not fail merely because the specified time falls
1615 outside of time_t range.
1616
4516fbef
GM
16172012-07-07 Glenn Morris <rgm@gnu.org>
1618
1619 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1620 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1621 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1622
07adc2c6
JB
16232012-07-07 Juanma Barranquero <lekktu@gmail.com>
1624
1625 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1626 Update dependencies.
1627
1628 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1629
fd573f31
PE
16302012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1631
fee5959d
PE
1632 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1633 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1634 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1635 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1636 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1637 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1638
fd573f31
PE
1639 * xfont.c (compare_font_names): Redo to omit the need for casts.
1640
ddadbc0e
AS
16412012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1642
fca8d6b6
AS
1643 * xfns.c (Fx_change_window_property): Doc fix.
1644 * w32fns.c (Fx_change_window_property): Doc fix.
1645
ddadbc0e
AS
1646 * w32fns.c (Fx_window_property): Accept the same arguments as the
1647 X Windows version. Doc fix.
1648 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1649
ed9265fc 16502012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1651 Eli Zaretskii <eliz@gnu.org>
1652
1653 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1654 Windows-specific code from nt/config.nt moved here.
1655 Obsolete settings removed.
1656
216ee680
PE
16572012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1658
1659 * process.c: Avoid unnecessary calls to gettime.
1660 (wait_reading_process_output): Don't get the time of day
1661 when gobbling data immediately and not waiting, as there's no need
1662 for it in that case. This removes a FIXME.
1663
bdd091e4
JD
16642012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1665
1666 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1667 is defined (Bug#11768).
1668
9d44f8ce
DA
16692012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1670
1671 Fix marker debugging code.
1672 * marker.c (byte_char_debug_check): Do not perform the check
1673 if buffer is not multibyte.
090bd7cb
JB
1674 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1675 Call byte_char_debug_check with correct arguments.
9d44f8ce 1676
90fc4786
DA
16772012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1678
1679 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1680 * marker.c (byte_char_debug_check, count_markers):
1681 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1682 (byte_debug_flag): Remove.
1683 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1684 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1685
7b7ae965
DA
16862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1687
4e57b342
DA
1688 Avoid code repetition in marker-related functions.
1689 * marker.c (attach_marker): New function.
1690 (Fset_marker, set_marker_restricted, set_marker_both)
1691 (set_marker_restricted_both): Use it.
1692 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1693 Consistently rename charno to charpos.
1694 (marker_position): Add eassert.
1695 (marker_byte_position): Convert to eassert.
1696
16972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1698
1699 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1700 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1701 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1702
657924ff
DA
17032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1704
1705 Introduce fast path for the widely used marker operation.
1706 * alloc.c (build_marker): New function.
1707 * lisp.h (build_marker): New prototype.
1708 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1709 * composite.c (autocmp_chars): Likewise.
1710 * editfns.c (buildmark): Remove.
1711 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1712 (save_restriction_save): Use build_marker.
1713 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1714 * window.c (save_window_save): Likewise.
1715
041a49a6
DA
17162012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1717
1718 Do not use Fdelete_overlay in delete_all_overlays
1719 to avoid redundant calls to unchain_overlay.
1720 * buffer.c (drop_overlay): New function.
1721 (delete_all_overlays, Fdelete_overlay): Use it.
1722 * minibuf.c (get_minibuffer): Fix comment.
1723
7dca65a4
PE
17242012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1725
1726 Port to OpenBSD 5.1 amd64.
1727 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1728 This is needed for OpenBSD, and should be harmless on all BSD systems.
1729 Also, include <sys/sysctl.h>, as it should be available on all
1730 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1731 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1732 use p_pid member, not kp_proc.pid.
1733
8eb876e2
GM
17342012-07-06 Glenn Morris <rgm@gnu.org>
1735
1736 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1737
38182d90
PE
17382012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1739
1740 More xmalloc and related cleanup.
1741 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1742 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1743 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1744 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1745 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1746 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1747 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1748 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1749 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1750 * xterm.c:
1751 Omit needless casts involving void * pointers and allocation.
1752 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1753 as the former is more robust if P's type is changed.
1754 Prefer xzalloc to xmalloc + memset 0.
1755 Simplify malloc-or-realloc to realloc.
1756 Don't worry about xmalloc returning a null pointer.
1757 Prefer xstrdup to xmalloc + strcpy.
1758 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1759 growing it.
1760 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1761 alloca of a constant.
1762
6dd5a677
EZ
17632012-07-05 Eli Zaretskii <eliz@gnu.org>
1764
1765 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1766 hscroll is larger than the line width. Fixes long and futile
1767 looping inside extend_face_to_end_of_line (on a TTY) producing
1768 glyphs that are not needed and thrown away.
1769
6b312f0f
DA
17702012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1771
1772 * marker.c (set_marker_restricted_both): Simplify by using
1773 clip_to_bounds.
1774
f520ef9b
PE
17752012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1776
1777 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1778
383b7c95
JD
17792012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1780
1781 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1782 not defined (Bug#11768).
1783 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1784 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1785 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1786 followed by gtk_box_set_homogeneous (Bug#11768).
1787 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1788 (update_theme_scrollbar_width, xg_create_scroll_bar):
1789 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1790 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1791 (is_box_type): New function (Bug#11768).
1792 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1793 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1794 with default display (Bug#11768).
1795
d6e7bf45
EZ
17962012-07-05 Eli Zaretskii <eliz@gnu.org>
1797
1798 * xdisp.c (window_hscroll_limited): New function.
1799 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1800 coordinates when window's hscroll is set to insanely large
1801 values. (Bug#11857)
1802
431391ec
JB
18032012-07-05 Juanma Barranquero <lekktu@gmail.com>
1804
1805 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1806 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1807
23f86fce
DA
18082012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1809
1810 Cleanup xmalloc.
1811 * lisp.h (xzalloc): New prototype. Omit needless casts.
1812 * alloc.c (xzalloc): New function. Omit needless casts.
1813 * charset.c: Omit needless casts. Convert all calls to
1814 xmalloc with following memset to xzalloc.
1815 * dispnew.c: Likewise.
1816 * fringe.c: Likewise.
1817 * image.c: Likewise.
1818 * sound.c: Likewise.
1819 * term.c: Likewise.
1820 * w32fns.c: Likewise.
1821 * w32font.c: Likewise.
1822 * w32term.c: Likewise.
1823 * xfaces.c: Likewise.
1824 * xfns.c: Likewise.
1825 * xterm.c: Likewise.
1826 * atimer.c: Omit needless casts.
1827 * buffer.c: Likewise.
1828 * callproc.c: Likewise.
1829 * ccl.c: Likewise.
1830 * coding.c: Likewise.
1831 * composite.c: Likewise.
1832 * doc.c: Likewise.
1833 * doprnt.c: Likewise.
1834 * editfns.c: Likewise.
1835 * emacs.c: Likewise.
1836 * eval.c: Likewise.
1837 * filelock.c: Likewise.
1838 * fns.c: Likewise.
1839 * gtkutil.c: Likewise.
1840 * keyboard.c: Likewise.
1841 * lisp.h: Likewise.
1842 * lread.c: Likewise.
1843 * minibuf.c: Likewise.
1844 * msdos.c: Likewise.
1845 * print.c: Likewise.
1846 * process.c: Likewise.
1847 * region-cache.c: Likewise.
1848 * search.c: Likewise.
1849 * sysdep.c: Likewise.
1850 * termcap.c: Likewise.
1851 * terminal.c: Likewise.
1852 * tparam.c: Likewise.
1853 * w16select.c: Likewise.
1854 * w32.c: Likewise.
1855 * w32reg.c: Likewise.
1856 * w32select.c: Likewise.
1857 * w32uniscribe.c: Likewise.
1858 * widget.c: Likewise.
1859 * xdisp.c: Likewise.
1860 * xmenu.c: Likewise.
1861 * xrdb.c: Likewise.
1862 * xselect.c: Likewise.
1863
0497dc44
PE
18642012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1865
1866 * fileio.c (time_error_value): Check the right error number.
1867 Problem reported by Troels Nielsen in
1868 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1869
356e7178
PE
18702012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1871
4e71fd89
PE
1872 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1873 This should be fixed in a better way; see Eli Zaretskii in
1874 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1875 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1876
f0941253
PE
1877 * fileio.c (time_error_value): Rename from special_mtime.
1878 The old name's problems were noted by Eli Zaretskii in
1879 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1880
065c9eb4
PE
1881 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1882 This variable's comment says Emacs needs at least one GDB-visible
1883 symbol of type enum pvec_type, to work around GDB problems.
1884 The symbol's value doesn't matter.
1885
356e7178
PE
1886 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1887 that causes compilation to fail on pre-C99 compilers.
1888
ed9265fc 18892012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1890
1891 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1892 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1893
3884d954
DA
18942012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1895
d209e2fb 1896 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1897 headers for buffer_defaults and buffer_local_symbols.
1898 Reported by Juanma Barranquero <lekktu@gmail.com>.
1899
ee28be33
SM
19002012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1901
1902 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1903 * lisp.h (enum pvec_type): Use fewer bits.
1904 (PSEUDOVECTOR_SIZE_BITS): New constant.
1905 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1906 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1907 change in pvec_type.
1908 (PSEUDOVECTOR_TYPEP): New macro.
1909 (TYPED_PSEUDOVECTORP): Use it.
1910 * fns.c (internal_equal): Adapt code to extract pvectype.
1911 * emacs.c (gdb_pvec_type): Update type.
1912 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1913 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1914 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1915 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1916 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1917 abusing vector->header.next.nbytes.
1918 (live_vector_p): Use PVEC_TYPE.
1919 (mark_object): Adapt code to extract pvectype. Use switch.
1920
c7f2cd7f
PE
19212012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1922
1923 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1924 Tighten new eassert a bit.
1925
8ce70ed2
DA
19262012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1927
1928 Fix compilation with --enable-gcc-warnings and -O1
1929 optimization level.
1930 * doprnt.c (doprnt): Change type of tem to int, initialize
1931 to avoid compiler warning. Add eassert.
1932 * search.c (simple_search): Initialize match_byte to avoid
1933 compiler warning. Add eassert.
1934
dea7f1e5
PE
19352012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1936
24a212eb
PE
1937 Avoid weird behavior with large horizontal scrolls.
1938 Without this change, for example, large hscroll values would
1939 mess up Emacs's display on Fedora 15 x86, presumably due to
1940 overflows in int calculations in the display code.
1941 Also, if buffers had long lines, Emacs would freeze.
1942 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1943 (set_window_hscroll): New function, containing the old guts of
1944 Fset_window_hscroll. Return the clipped value.
1945 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1946 This avoids the need to check against PTRDIFF_MAX.
1947
dea7f1e5
PE
1948 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1949
76046526
DA
19502012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1951
1952 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1953
39adff0d
PE
19542012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1955
63807d47
PE
1956 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1957 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1958 since GCC 4.4.6 issues a bogus warning for them.
1959
39adff0d
PE
1960 Fix bugs in file timestamp newness comparisons.
1961 * fileio.c (Ffile_newer_than_file_p):
1962 * lread.c (Fload): Use full timestamp resolution of files,
1963 not just the 1-second resolution, so that files that are only
1964 slightly newer still count as newer.
1965 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1966 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1967
dbeed9a6
PE
19682012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1969
1970 * fileio.c: Improve handling of file time marker. (Bug#11852)
1971 (special_mtime): New function.
1972 (Finsert_file_contents, Fverify_visited_file_modtime):
1973 Use it to set special mtime values consistently.
1974
636334d6
AS
19752012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1976
1977 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1978 marker for non-existing file. (Bug#11852)
1979
e2017fe2
GM
19802012-07-03 Glenn Morris <rgm@gnu.org>
1981
1982 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1983 and did not make it into globals.h).
1984
404dbd37
TT
19852012-07-03 Tom Tromey <tromey@redhat.com>
1986
1987 * window.c (Fset_window_margins, Fset_window_fringes)
1988 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1989 * textprop.c (Fprevious_property_change): No longer static.
1990 * syntax.c (Fsyntax_table_p): No longer static.
1991 * process.c (Fget_process, Fprocess_datagram_address): No longer
1992 static.
1993 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1994 * keyboard.c (Fcommand_execute): No longer static.
1995 Remove EXFUN.
1996 * insdel.c (Fcombine_after_change_execute): No longer static.
1997 * image.c (Finit_image_library): No longer static.
1998 * fileio.c (Fmake_symbolic_link): No longer static.
1999 * eval.c (Ffetch_bytecode): No longer static.
2000 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2001 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2002 No longer static.
404dbd37
TT
2003 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2004 static.
2005 * dired.c (Ffile_attributes): No longer static.
2006 * composite.c (Fcomposition_get_gstring): No longer static.
2007 * callproc.c (Fgetenv_internal): No longer static.
2008
2009 * ccl.h: Remove EXFUNs.
2010 * buffer.h: Remove EXFUNs.
2011 * dispextern.h: Remove EXFUNs.
2012 * intervals.h: Remove EXFUNs.
2013 * fontset.h: Remove EXFUN.
2014 * font.h: Remove EXFUNs.
2015 * dosfns.c (system_process_attributes): Remove EXFUN.
2016 * keymap.h: Remove EXFUNs.
2017 * lisp.h: Remove EXFUNs.
2018 * w32term.h: Remove EXFUNs.
2019 * window.h: Remove EXFUNs.
2020 * xsettings.h: Remove EXFUN.
2021 * xterm.h: Remove EXFUN.
2022
8e4fd1e1
GM
20232012-07-03 Glenn Morris <rgm@gnu.org>
2024
2025 * lisp.h (Frandom): Make it visible to C.
2026 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2027 buffer for invisible buffers. (Bug#1229)
2028
ca95b3eb
DA
20292012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2030
2031 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2032 values which aren't power of 2.
2033 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2034 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2035 accordingly.
2036
7555c33f
SM
20372012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2038
2039 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2040
2041 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2042
d12e8f5a
DA
20432012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2044
2045 * alloc.c (allocate_vector_block): Remove redundant
2046 calls to mallopt if DOUG_LEA_MALLOC is defined.
2047 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2048 avoid calls to mallopt if zero_vector is returned.
2049
296094c3
DA
20502012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2051
2052 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2053 is enabled, avoid dereferencing NULL current_sblock if
2054 running undumped.
2055
36429c89
DA
20562012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2057
2058 Cleanup basic buffer management.
2059 * buffer.h (struct buffer): Change layout to use generic vector
2060 marking code. Fix some comments. Change type of 'clip_changed'
2061 to bitfield. Remove unused #ifndef old.
2062 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2063 (GET_OVERLAYS_AT): Fix indentation.
2064 (for_each_per_buffer_object_at): New macro.
2065 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2066 (Fbuffer_local_variables): Use it.
2067 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2068 * alloc.c (allocate_buffer): Adjust to match new layout of
2069 struct buffer. Fix comment.
2070 (mark_overlay): New function.
2071 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2072 Lisp area of struct buffer.
2073 (mark_object): Use it. Adjust marking of misc objects
2074 and related comments.
2075
3b3e4cac
PE
20762012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2077
2078 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2079 wrapper that is not needed because the wrapped code is a no-op (zero
2080 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2081 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2082
cf5c0175
DA
20832012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2084
2085 * alloc.c (mark_buffer): Simplify. Remove prototype.
2086 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2087 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2088 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2089 redundant calls to mark_vectorlike for bool vectors.
2090
ca26824c
GM
20912012-06-30 Glenn Morris <rgm@gnu.org>
2092
2e4c5312
GM
2093 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2094
ca26824c
GM
2095 * epaths.in (PATH_SITELOADSEARCH): New.
2096 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2097 This is rather than relying on --enable-locallisppath elements
2098 having "site-lisp" in their names. (Bug#10208#25, 11658)
2099
0d23c240
EZ
21002012-06-30 Eli Zaretskii <eliz@gnu.org>
2101
c9240d7a
EZ
2102 * w32proc.c (sys_select): Accept and ignore one more argument.
2103
2104 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2105
0d23c240 2106 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2107 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2108
2109 * sysdep.c: Don't include dos.h and dosfns.h.
2110
2111 * process.c (sys_select):
2112 * msdos.c (sys_select): Accept one more argument and ignore it.
2113
2114 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2115 adapt data types and code to that.
2116
2117 * dosfns.c:
2118 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2119 which clashes with the gnulib function of the same name.
2120
af5a5a98
AS
21212012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2122
c5e4379c
AS
2123 * font.c (font_style_to_value, font_style_symbolic)
2124 (font_prop_validate_style): Add type checks for values in
2125 font_style_table.
2126
af5a5a98
AS
2127 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2128 argument.
2129 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2130 uses.
2131
8d38f461
EZ
21322012-06-29 Eli Zaretskii <eliz@gnu.org>
2133
2e5a6631
EZ
2134 * xdisp.c (try_window_id): Undo last change.
2135
8d38f461
EZ
2136 * w32.c (getwd): Adjust commentary about startup_dir.
2137 (init_environment): Always call sys_access, even in non-MSVC
2138 builds. Don't chdir to the directory of the Emacs executable.
2139 This undoes code from 1997 which was justified by the need to
2140 "avoid conflicts when removing and renaming directories". But its
2141 downside was that every relative file name was being interpreted
2142 relative to the directory of the Emacs executable, which can never
2143 be TRT. In particular, it broke sys_access when called with
2144 relative file names.
2145 (sys_access): Map GetLastError to errno.
2146
2af3565e
DA
21472012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2148
2149 * window.h (struct window): Change type of 'fringes_outside_margins'
2150 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2151 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2152 Adjust comment.
2153 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2154 to ptrdiff_t.
2155
c8d3a25c 21562012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2157
c8d3a25c
GM
2158 * gnutls.c (emacs_gnutls_handshake):
2159 Add QUIT to make the loop interruptible.
57570cd3 2160
c8d3a25c 21612012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2162
c8d3a25c
GM
2163 * charset.c (init_charset): Make lack of etc/charsets fatal.
2164
3e984ee8
DA
21652012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2166
2167 * editfns.c (region_limit): Fix type mismatch.
2168
ef884f23
DA
21692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2170
2171 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2172 undefined. Convert from xassert to eassert.
2173 * nsmenu.m: Convert from xassert to eassert.
2174 * nsterm.m: Likewise.
2175
7d7e0027
SM
21762012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2177
2178 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2179
aa754e6a
PE
21802012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2181
2182 Avoid integer overflow on scroll-left and scroll-right.
2183 * window.c (HSCROLL_MAX): New macro.
2184 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2185 overflow when requested scroll falls outside ptrdiff_t range.
2186
80b00b08
DA
21872012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2188
2189 * window.h (struct window): Change type of 'hscroll',
2190 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2191 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2192 Adjust users accordingly.
2193 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2194 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2195 from EMACS_INT to ptrdiff_t.
2196 (make_window): Omit redundant initialization.
2197
62b2bcf6
JB
21982012-06-28 Juanma Barranquero <lekktu@gmail.com>
2199
2200 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2201
45942c7d
DA
22022012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2203
2204 * window.h (struct window): Change type of 'use_time' and
2205 'sequence_number' from Lisp_Object to int.
2206 * frame.c (make_frame): Adjust users accordingly.
2207 * print.c (print_object): Likewise.
2208 * window.c (select_window, Fwindow_use_time, make_parent_window)
2209 (make_window): Likewise.
2210
e509cfa6
DA
22112012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2212
2213 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2214 enabled with --enable-checking=[all,glyphs] configure option.
2215 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2216 adjust comments accordingly.
2217 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2218 undefined, adjust comments accordingly.
2219 * image.c: Likewise.
2220 * scroll.c: Likewise.
2221 * w32fns.c: Likewise.
2222 * w32term.c: Likewise.
2223 * xdisp.c: Likewise.
2224 * xfaces.c: Likewise.
2225 * xfns.c: Likewise.
2226 * xterm.c: Likewise.
2227
a54e2c05
DA
22282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2229
2230 Generalize run-time debugging checks.
2231 * dispextern.h (XASSERTS): Remove.
2232 * fontset.c (xassert): Remove.
2233 Convert from xassert to eassert.
2234 * alloc.c: Convert from xassert to eassert.
2235 * bidi.c: Likewise.
2236 * dispnew.c: Likewise.
2237 * fns.c: Likewise.
2238 * fringe.c: Likewise.
2239 * ftfont.c: Likewise.
2240 * gtkutil.c: Likewise.
2241 * image.c: Likewise.
2242 * keyboard.c: Likewise.
2243 * menu.c: Likewise.
2244 * process.c: Likewise.
2245 * scroll.c: Likewise.
2246 * sound.c: Likewise.
2247 * term.c: Likewise.
2248 * w32console.c: Likewise.
2249 * w32fns.c: Likewise.
2250 * w32term.c: Likewise.
2251 * window.c: Likewise.
2252 * xdisp.c: Likewise.
2253 * xfaces.c: Likewise.
2254 * xfns.c: Likewise.
2255 * xselect.c: Likewise.
2256 * xterm.c: Likewise.
2257
1ec4b7b2
SM
22582012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2259
2260 * fns.c (maybe_resize_hash_table): Output message when growing the
2261 purify-hashtable.
2262
2014308a
DA
22632012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2264
2265 * alloc.c (allocate_string_data): Remove dead code.
2266 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2267 avoid GCC warning about unused macro.
2268
246155eb
DA
22692012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2270
2271 * alloc.c (allocate_string): Omit intervals initialization.
2272 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2273 as in make_pure_string and make_pure_c_string.
2274
43184b7b
DA
22752012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2276
d209e2fb 2277 * alloc.c (allocate_string): Fix last change.
43184b7b 2278
3fe6dd74
DA
22792012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2280
d209e2fb 2281 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2282 to memset, add explicit initialization where appropriate.
2283
1ba6038a
GM
22842012-06-27 Glenn Morris <rgm@gnu.org>
2285
2286 * lisp.mk (lisp): Remove paths.elc.
2287
c89926a5
CY
22882012-06-27 Chong Yidong <cyd@gnu.org>
2289
2290 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2291
ed6b3510
JW
22922012-06-26 John Wiegley <johnw@newartisans.com>
2293
1ec4b7b2 2294 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2295 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2296
ed6b3510
JW
2297 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2298 when building with Clang.
2299
8edd4a2b
SM
23002012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2301
2302 * eval.c (Fapply): Allow calling it with a single argument.
2303
f6f62d1b
EZ
23042012-06-26 Eli Zaretskii <eliz@gnu.org>
2305
2306 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2307 _stricmp and _strnicmp.
2308 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2309
62efea5e
DA
23102012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2311
2312 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2313 allocated window.
2314 (allocate_process): Likewise for new process.
8edd4a2b 2315 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2316 (allocate_frame): Likewise.
2317 * frame.c (make_frame): Omit redundant initialization.
2318 * window.c (make_parent_window): Use memset.
2319 (make_window): Omit redundant initialization.
2320 * process.c (make_process): Omit redundant initialization.
2321 * terminal.c (create_terminal): Likewise.
2322
42997f4d
DA
23232012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2324
2325 * term.c (delete_tty): Remove redundant call to memset.
2326
1130ecfc
DA
23272012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2328
2329 * alloc.c: Remove build_string.
2330 * lisp.h: Define build_string as static inline. This provides
2331 a better opportunity to optimize away calls to strlen when the
2332 function is called with compile-time constant argument.
2333 * image.c (imagemagick_error): Convert to build_string.
2334 * w32proc.c (sys_spawnve): Likewise.
2335 * xterm.c (x_term_init): Likewise.
2336
cf38a720
PE
23372012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2338
99027bdd
PE
2339 Use sprintf return value instead of invoking strlen on result.
2340 In the old days this wasn't portable, since some sprintf
2341 implementations returned char *. But they died out years ago and
2342 Emacs already assumes sprintf returns int.
2343 Similarly for float_to_string.
2344 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2345 * ccl.c (ccl_driver):
2346 * character.c (string_escape_byte8):
2347 * data.c (Fnumber_to_string):
2348 * doprnt.c (doprnt):
2349 * print.c (print_object):
2350 * xdisp.c (message_dolog):
2351 * xfns.c (syms_of_xfns):
2352 Use sprintf or float_to_string result to avoid need to call strlen.
2353 * data.c (Fnumber_to_string):
2354 Use make_unibyte_string, since the string must be ASCII.
2355 * lisp.h, print.c (float_to_string): Now returns int length.
2356 * term.c (produce_glyphless_glyph):
2357 Use sprintf result rather than recomputing it.
2358
cf38a720
PE
2359 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2360 * Makefile.in (ALL_CFLAGS):
2361 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2362 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2363
3511c784
DA
23642012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2365
0a08eb21 2366 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2367 strcasecmp if available.
2368 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2369
fb7da12e
AS
23702012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2371
2372 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2373 Avoid comma operator.
2374 * menu.c (push_submenu_start, push_submenu_end)
2375 (push_left_right_boundary, push_menu_pane): Likewise.
2376 * msdos.c (dos_rawgetc): Likewise.
2377
afa2ffd8
DA
23782012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2379
2380 * xfns.c (xic_create_fontsetname): Remove redundant calls
2381 to memset.
2382
b3b4476b
PE
23832012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2384
4495ff38
PE
2385 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2386 sprintf already null-terminates its output.
2387
b3b4476b
PE
2388 * xfns.c (x_window): Remove redundant cast.
2389
b00876c9
DA
23902012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2391
2392 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2393 `const char *' to `char *' to avoid compiler warning.
2394
d188e26b
PE
23952012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2396
885d1d74
PE
2397 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2398 instead of truncating it to 63 (admittedly a generous limit).
2399
d188e26b
PE
2400 * process.c: Fix spelling and caps in comments.
2401
e2f560b1
DN
24022012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2403
e86db54b 2404 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2405 * sysdep.c (setpgrp): Remove definition, not used in this file.
2406
7583a3a1
JB
24072012-06-24 Juanma Barranquero <lekktu@gmail.com>
2408
2409 * makefile.w32-in: Update dependencies.
2410
696056c2
EZ
24112012-06-24 Eli Zaretskii <eliz@gnu.org>
2412
2413 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2414 (SYSTIME_H): Add nt/inc/sys/time.h.
2415
2416 * systime.h [WINDOWSNT]: Include sys/time.h.
2417
2418 * s/ms-w32.h (struct timespec): Definition moved from
2419 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2420
845ca893
PE
24212012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2424 * buffer.h (buffer_slot_type_mismatch):
2425 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2426 * eval.c (unwind_to_catch):
2427 * image.c (my_png_error, my_error_exit):
2428 * keyboard.c (quit_throw_to_read_char, user_error)
2429 (Fexit_recursive_edit, Fabort_recursive_edit):
2430 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2431 (wrong_type_argument, buffer_overflow, __executable_start)
2432 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2433 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2434 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2435 (fatal):
2436 (child_setup) [!DOS_NT]:
2437 * lread.c (end_of_file_error, invalid_syntax):
2438 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2439 * puresize.h (pure_write_error):
2440 * search.c (matcher_overflow):
2441 * sound.c (sound_perror, alsa_sound_perror):
2442 * sysdep.c, syssignal.h (croak):
2443 * term.c (maybe_fatal, vfatal):
2444 * textprop.c (text_read_only):
2445 * undo.c (user_error):
2446 * unexmacosx.c (unexec_error):
2447 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2448 Use _Noreturn rather than NO_RETURN.
2449 No need for separate decl merely because of _Noreturn.
2450 * sound.c (sound_warning, parse_sound):
2451 Remove unnecessary forward decls.
2452
f1dd8073
PE
24532012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2454
2455 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2456 * lisp.h (WAIT_READING_MAX): New macro.
2457 * dispnew.c (Fsleep_for, sit_for):
2458 * keyboard.c (kbd_buffer_get_event):
2459 * process.c (Faccept_process_output):
2460 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2461 This improves on the previous patch, which introduced a bug
2462 when time_t is unsigned and as wide as intmax_t.
2463 See <http://bugs.gnu.org/9000#51>.
2464
b82c1755
EZ
24652012-06-23 Eli Zaretskii <eliz@gnu.org>
2466
2467 * dispnew.c (sit_for, Fsleep_for):
2468 * keyboard.c (kbd_buffer_get_event):
2469 * process.c (Faccept_process_output): Avoid compiler warnings when
2470 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2471
ca300656
JB
24722012-06-23 Juanma Barranquero <lekktu@gmail.com>
2473
049ec95b
JB
2474 * makefile.w32-in: Update dependencies.
2475
ca300656
JB
2476 * w32.c (ltime): Add return type and declare static.
2477 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2478
db7b8d06
PE
24792012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2480
2481 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2482 Privately reported by Herbert J. Skuhra.
2483 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2484 All uses changed.
2485 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2486 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2487
0bd8297f
EZ
24882012-06-23 Eli Zaretskii <eliz@gnu.org>
2489
96512555
EZ
2490 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2491 last argument of make_unibyte_string.
2492
0bd8297f
EZ
2493 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2494 language ID in the event parameters.
2495
2496 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2497 event.code, not the obscure "character set ID".
2498
63def6b6
CY
24992012-06-23 Chong Yidong <cyd@gnu.org>
2500
2501 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2502
e8a02204
EZ
25032012-06-23 Eli Zaretskii <eliz@gnu.org>
2504
388cdec0
EZ
2505 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2506 * w32.c (fdutimens): New function.
2507
2508 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2509
2510 * s/ms-w32.h (pselect): Redirect to sys_select.
2511
2512 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2513
e8a02204
EZ
2514 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2515 in the logic of incrementing and decrementing the value of
2516 use_relocatable_buffers.
2517
d054f3fb
PE
25182012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2519
2520 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2521 Privately reported by Herbert J. Skuhra.
2522 [__FreeBSD__]: Remove "*/" typo after "#include".
2523 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2524 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2525 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2526 Don't assume EMACS_TIME and struct timeval are the same type.
2527
d35af63c
PE
25282012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2529
2530 Support higher-resolution time stamps (Bug#9000).
2531 The time stamps are only nanosecond-resolution at the C level,
2532 since that's the best that any real-world system supports now.
2533 But they are picosecond-resolution at the Lisp level, as that's
2534 easy, and leaves room for future OS improvements.
2535
2536 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2537 (LIBES): Use it.
2538
2539 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2540 Don't get current time unless it's needed.
2541
2542 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2543 now provides it if it's absent.
2544 (start_atimer): Port to higher-res time stamps.
2545 Check for time stamp overflow. Don't get current time more
2546 often than is needed.
2547
2548 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2549 Include systime.h, not time.h.
2550 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2551
2552 * dired.c: Include stat-time.h.
2553 (Ffile-attributes): File times now have higher resolution.
2554
2555 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2556 (struct image): Timestamp now has higher resolution.
2557
2558 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2559 has at least microseconds now. All uses removed.
2560 (update_frame, update_single_window, update_window, update_frame_1)
2561 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2562
2563 * editfns.c (time_overflow): Now extern.
2564 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2565 (float-time, Fformat_time_string, Fcurrent_time_string)
2566 (Fcurrent_time_zone): Accept and generate higher-resolution
2567 time stamps.
2568 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2569 (decode_time_components, lisp_seconds_argument): New functions.
2570 (make_time): Now static.
2571 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2572 Report an error if the time is invalid, rather than having the caller
2573 do that.
2574
2575 * fileio.c: Include <stat-time.h>
2576 (Fcopy_file): Copy higher-resolution time stamps.
2577 Prefer to set the time stamp via a file descriptor if that works.
2578 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2579 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2580 (Fvisited_file_modtime, Fset_visited_file_modtime):
2581 Support higher-resolution time stamps.
2582
2583 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2584
2585 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2586
2587 * image.c (prepare_image_for_display, clear_image_cache)
2588 (lookup_image): Port to higer-resolution time stamps.
2589
2590 * keyboard.c (start_polling, bind_polling_period):
2591 Check for time stamp overflow.
2592 (read_char, kbd_buffer_get_event, timer_start_idle)
2593 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2594 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2595 Port to higher-resolution time stamps. Do not assume time_t is signed.
2596 (decode_timer): New function. Timers are now vectors of length 9,
2597 not 8, to accommodate the picosecond component.
2598 (timer_check_2): Use it.
2599
2600 * nsterm.m (select_timeout, timeval_subtract): Remove.
2601 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2602 as they're a bit more accurate and handle overflow better.
2603 (ns_select): Change prototype to be compatible with pselect.
2604 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2605 * nsterm.h (ns_select): Adjust prototype.
2606
2607 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2608 us-resolution time stamps.
2609 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2610
2611 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2612
2613 * lisp.h (time_overflow): New decl.
2614 (wait_reading_process_output): First arg is now intmax_t, not int,
2615 to accommodate larger waits.
2616
2617 * process.h (struct Lisp_Process.read_output_delay):
2618 Now counts nanoseconds, not microseconds.
2619 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2620 EMACS_HAS_USECS.
2621 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2622 (wait_reading_process_output):
2623 Port to ns-resolution time stamps.
2624 (Faccept_process_output, wait_reading_process_output):
2625 Check for time stamp overflow. Do not assume time_t is signed.
2626 (select_wrapper): Remove; we now use pselect.
2627 (Fprocess_attributes): Now generates ns-resolution time stamps.
2628
2629 * sysdep.c: Include utimens.h. Don't include utime.h
2630 or worry about struct utimbuf; gnulib does that for us now.
2631 (gettimeofday): Remove; gnulib provides a substitute.
2632 (make_timeval): New function.
2633 (set_file_times): Now sets ns-resolution time stamps.
2634 New arg FD; all uses changed.
2635 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2636 (system_process_attributes):
2637 Now returns ns-resolution time stamp. All uses changed.
2638 Check for time stamp overflow.
2639
2640 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2641 provides a substitute now.
2642
2643 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2644 since it guarantees struct timespec.
2645 (EMACS_TIME): Now struct timespec, so that we can support
2646 ns-resolution time stamps.
2647 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2648 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2649 (EMACS_USECS): Remove.
2650 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2651 so multiply the arg by 1000 before storing it.
2652 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2653 New macros.
2654 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2655 Port to ns-resolution time stamps.
2656 (EMACS_TIME_NEG_P): Remove; replaced by....
2657 (EMACS_TIME_SIGN): New macro.
2658 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2659 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2660 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2661 (make_timeval, make_lisp_time, decode_time_components): New decls.
2662 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2663 that it mishandled time_t overflow. You can't compare by subtracting!
2664 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2665 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2666
2667 * term.c: Include <sys/time.h>.
2668 (timeval_to_Time): New function, for proper overflow wraparound.
2669 (term_mouse_position, term_mouse_click): Use it.
2670
2671 * undo.c (record_first_change): Support higher-resolution time stamps
2672 in the undo buffer.
2673 (Fprimitive_undo): Use them when restoring time stamps.
2674
2675 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2676 (w32_get_internal_run_time):
2677 Port to higher-resolution Emacs time stamps.
2678 (ltime): Now accepts single 64-bit integer, as that's more convenient
2679 for callers.
2680
2681 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2682
2683 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2684 for compatibility with pselect. Support ns-resolution time stamps.
2685
2686 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2687
2688 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2689 Check for time stamp overflow, and support ns-resolution time stamps.
2690
2691 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2692 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2693 (timeval_subtract): Remove; no longer needed.
2694 (XTflash, XTring_bell, x_wait_for_event):
2695 Port to ns-resolution time stamps. Don't assume time_t is signed.
2696
b6a92dfe
CY
26972012-06-22 Chong Yidong <cyd@gnu.org>
2698
2699 * xdisp.c (x_consider_frame_title): Revert last change.
2700
d251c37c
EZ
27012012-06-22 Eli Zaretskii <eliz@gnu.org>
2702
2703 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2704 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2705 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2706 staticidx goes up to 1597 out of 1600 = 0x640.)
2707
f10deafb
PE
27082012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2709
2710 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2711 Otherwise, the umask might be mistakenly 0 while handling input signals.
2712
ec6de1e2
SM
27132012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2714
2715 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2716
28be1ada
DA
27172012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2718
2719 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2720 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2721 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2722 access to `contents' member of Lisp_Vector objects with AREF and ASET
2723 where appropriate.
2724
c6bf3022
CY
27252012-06-19 Chong Yidong <cyd@gnu.org>
2726
2727 * frame.c (delete_frame): When selecting a frame on a different
2728 text terminal, do not alter the terminal's top-frame.
2729
2730 * xdisp.c (format_mode_line_unwind_data): Record the target
2731 frame's selected window and its terminal's top-frame.
2732 (unwind_format_mode_line): Restore them.
2733 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2734 Callers changed.
2735 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2736 since tty frames can be explicitly named.
2737 (prepare_menu_bars): Likewise.
2738
2739 * term.c (Ftty_top_frame): New function.
2740
defd4196
PE
27412012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2742
2743 Port byte-code-meter to modern targets.
2744 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2745 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2746 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2747 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2748 (METER_1, METER_2): Simplify.
2749
1053a871
SM
27502012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2751
2752 * data.c (Fdefalias): Return `symbol' (bug#11686).
2753
b7e8d081
MR
27542012-06-18 Martin Rudalics <rudalics@gmx.at>
2755
2756 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2757 gets killed during executing of this function (Bug#11665).
2758 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2759 (Vkill_buffer_query_functions): In doc-string say that functions
2760 run by this hook should not change the current buffer.
2761
7ea2b339
PE
27622012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2763
2764 Fix recently-introduced process.c problems found by static checking.
2765 * process.c (write_queue_push, write_queue_pop, send_process):
2766 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2767 (write_queue_pop): Fix pointer signedness problem.
2768 (send_process): Remove unused local.
2769
96a313a1
CY
27702012-06-17 Chong Yidong <cyd@gnu.org>
2771
2772 * xdisp.c (redisplay_internal): No need to redisplay terminal
2773 frames that are not on top.
2774
20ca2e94
TN
27752012-06-17 Troels Nielsen <bn.troels@gmail.com>
2776
2777 * process.c (make_process): Initialize write_queue.
2778 (write_queue_push, write_queue_pop): New functions.
2779 (send_process): Use them to maintain correct ordering of process
2780 writes (Bug#10815).
2781
9a900ca9
PE
27822012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2783
310fbfa8
PE
2784 * lisp.h (eassert): Assume C89 or later.
2785 This removes the need for CHECK.
2786 (CHECK): Remove. Its comments about always evaluating its
2787 argument were confusing, as 'eassert' typically does not evaluate
2788 its argument.
2789
27bb1ca4
PE
2790 * coding.c (produce_chars): Use ptrdiff_t, not int.
2791
9a900ca9
PE
2792 * xterm.c (x_draw_underwave): Check for integer overflow.
2793 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2794
41b7f8bc 27952012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2796
2797 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2798 referenced (Bug#11583).
2799
9b0e3eba
AA
28002012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2801
2802 Implement wave-style variant of underlining.
2803 * dispextern.h (face_underline_type): New enum.
2804 (face): Add field for underline type.
2805 * nsterm.m (ns_draw_underwave): New function.
2806 (ns_draw_text_decoration): Use it.
2807 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2808 New functions.
2809 (x_draw_glyph_string): Use them.
2810 * xfaces.c (Qline, Qwave): New Lisp objects.
2811 (check_lface_attrs, merge_face_ref)
1053a871
SM
2812 (Finternal_set_lisp_face_attribute, realize_x_face):
2813 Handle wave-style underline face attributes.
9b0e3eba
AA
2814 * xterm.c (x_draw_underwave): New function.
2815 (x_draw_glyph_string): Use it.
2816
0fb52f11
JB
28172012-06-16 Juanma Barranquero <lekktu@gmail.com>
2818
2819 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2820 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2821 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2822 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2823 ($(BLD)/w32select.$(O)): Update dependencies.
2824
e5560ff7
AS
28252012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2826
2827 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2828 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2829 * character.c (_fetch_multibyte_char_p): Remove.
2830 * alloc.c: Include "character.h" before "buffer.h".
2831 * bidi.c: Likewise.
2832 * buffer.c: Likewise.
2833 * bytecode.c: Likewise.
2834 * callint.c: Likewise.
2835 * callproc.c: Likewise.
2836 * casefiddle.c: Likewise.
2837 * casetab.c: Likewise.
2838 * category.c: Likewise.
2839 * cmds.c: Likewise.
2840 * coding.c: Likewise.
2841 * composite.c: Likewise.
2842 * dired.c: Likewise.
2843 * dispnew.c: Likewise.
2844 * doc.c: Likewise.
2845 * dosfns.c: Likewise.
2846 * editfns.c: Likewise.
2847 * emacs.c: Likewise.
2848 * fileio.c: Likewise.
2849 * filelock.c: Likewise.
2850 * font.c: Likewise.
2851 * fontset.c: Likewise.
2852 * fringe.c: Likewise.
2853 * indent.c: Likewise.
2854 * insdel.c: Likewise.
2855 * intervals.c: Likewise.
2856 * keyboard.c: Likewise.
2857 * keymap.c: Likewise.
2858 * lread.c: Likewise.
2859 * macros.c: Likewise.
2860 * marker.c: Likewise.
2861 * minibuf.c: Likewise.
2862 * nsfns.m: Likewise.
2863 * nsmenu.m: Likewise.
2864 * print.c: Likewise.
2865 * process.c: Likewise.
2866 * regex.c: Likewise.
2867 * region-cache.c: Likewise.
2868 * search.c: Likewise.
2869 * syntax.c: Likewise.
2870 * term.c: Likewise.
2871 * textprop.c: Likewise.
2872 * undo.c: Likewise.
2873 * unexsol.c: Likewise.
2874 * w16select.c: Likewise.
2875 * w32fns.c: Likewise.
2876 * w32menu.c: Likewise.
2877 * window.c: Likewise.
2878 * xdisp.c: Likewise.
2879 * xfns.c: Likewise.
2880 * xmenu.c: Likewise.
2881 * xml.c: Likewise.
2882 * xselect.c: Likewise.
2883
2f07e6af
EZ
28842012-06-16 Eli Zaretskii <eliz@gnu.org>
2885
1053a871
SM
2886 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2887 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2888 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2889 row.
2890 (handle_face_prop): Use chunk-relative overlay string index when
2891 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2892 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2893 the rightmost. (Bug#11720)
2f07e6af 2894
29b83cec
AS
28952012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2896
2897 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2898 (CATEGORY_MEMBER): Enforce 1/0 value.
2899 * category.c (_temp_category_set): Remove.
2900
4c5501e9
EZ
29012012-06-16 Eli Zaretskii <eliz@gnu.org>
2902
2903 * window.c (Fdelete_other_windows_internal)
2904 (Fdelete_window_internal): Don't access frame's mouse highlight
2905 info of the initial frame. (Bug#11677)
2906
2b570124
PE
29072012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2908
e93864f9
PE
2909 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2910 Assume USE_2_TAGS_FOR_INTS.
2911 (xreload): Adjust $tagmask width to match recent lisp.h change.
2912
2b570124
PE
2913 Simplify lisp.h in minor ways that should not affect code.
2914 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2915 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2916 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2917 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2918 (INTTYPEBITS): New macro, for clarity.
2919 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2920 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2921 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2922 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2923 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2924
81755f69
JB
29252012-06-13 Juanma Barranquero <lekktu@gmail.com>
2926
2927 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2928
16192a57
GM
29292012-06-13 Glenn Morris <rgm@gnu.org>
2930
2931 * s/bsd-common.h (BSD4_3):
2932 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2933
646b5f55
AS
29342012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2935
2936 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2937 instead of union.
2938 (XLI, XIL): Define.
1053a871
SM
2939 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2940 Use them.
2941 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2942 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2943 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2944 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2945 * frame.c (delete_frame): Remove outdated comment.
2946 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2947 USE_LISP_UNION_TYPE.
2948 (Fw32_unregister_hot_key): Likewise.
2949 (Fw32_toggle_lock_key): Likewise.
2950 * w32menu.c (add_menu_item): Likewise.
2951 (w32_menu_display_help): Use XIL instead of checking
2952 USE_LISP_UNION_TYPE.
2953 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2954 (init_heap): Likewise.
2955 * w32term.c (w32_read_socket): Update comment.
2956
1d3823c9
GM
29572012-06-13 Glenn Morris <rgm@gnu.org>
2958
c62ff706
GM
2959 * s/usg5-4-common.h, src/s/unixware.h:
2960 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2961
1d3823c9
GM
2962 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2963
bfe3e0a2
PE
29642012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2965
2966 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2967 * alloc.c (make_number) [!defined make_number]:
2968 Remove, as lisp.h always defines this now.
2969 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2970 (roundup_size): Verify that it is a power of 2.
2971 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2972 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2973 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2974 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2975 USE_LSB_TAG now is always defined to be either 0 or 1.
2976 All uses changed.
2977 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2978 code works fine either way, and efficiency is not a concern here,
2979 as the union type is for debugging, not for production.
2980 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2981 Use an inline function on all platforms when using the union type,
2982 since this is simpler and 'static inline' can be used portably
2983 within Emacs now.
2984 (LISP_INITIALLY_ZERO): New macro.
2985 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2986 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2987
45fa9c0f
GM
29882012-06-12 Glenn Morris <rgm@gnu.org>
2989
b4492cba
GM
2990 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2991
2992 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2993
45fa9c0f
GM
2994 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2995 Move BROKEN_SIGIO to configure.
2996
2997 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2998 Move NO_TERMIO to configure.
2999
0e25d334
CY
30002012-06-12 Chong Yidong <cyd@gnu.org>
3001
3002 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3003 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3004 MagickExportImagePixels is undefined.
3005
43682bb6
PE
30062012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3007
3008 * image.c (imagemagick_load_image): Remove unused label.
3009
a9be7d2b
GM
30102012-06-11 Glenn Morris <rgm@gnu.org>
3011
3012 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3013 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3014 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3015 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3016
3017f87f
SM
30172012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3018
3019 * alloc.c (make_byte_code): New function.
3020 (Fmake_byte_code): Use it. Don't purify here.
3021 * lread.c (read1): Use it as well to avoid extra allocation.
3022
1b9b4cf4
CY
30232012-06-11 Chong Yidong <cyd@gnu.org>
3024
3025 * image.c (imagemagick_load_image): Implement transparency.
3026
95988fcf
AS
30272012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3028
3029 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3030 account for preceding backslashes. (Bug#11663)
3031
cd4eb164
CY
30322012-06-09 Chong Yidong <cyd@gnu.org>
3033
3034 * term.c: Support italics in capable terminals (Bug#9652).
3035 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3036 (turn_on_face): Output using TS_enter_italic_mode if available.
3037 Don't handle unused blinking and alt-charset cases.
3038 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3039 and tty_alt_charset_p cases.
3040 (tty_capable_p, init_tty): Support italics.
3041
3042 * termchar.h (struct tty_display_info): Add field for italics.
3043 Remove unused blink field.
3044
3045 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3046 Handle slant.
3047
3048 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3049 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3050 tty_alt_charset_p. Add tty_italic_p.
3051
ff88beb8
MA
30522012-06-09 Michael Albinus <michael.albinus@gmx.de>
3053
3054 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3055 dbus_type_is_basic if available.
3056 (xd_extract_signed, xd_extract_unsigned): Rename from
3057 extract_signed and extract_unsigned, respectively. Adapt callers.
3058
44286096
CY
30592012-06-09 Chong Yidong <cyd@gnu.org>
3060
1682701f
CY
3061 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3062
44286096
CY
3063 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3064 case (Bug#9752).
3065
d86feb17
PE
30662012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3067
3068 * xdisp.c (vmessage): Treat frame message as multibyte.
3069 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3070 would generate the diagnostic "Making \302\247 buffer-local while
3071 let-bound!".
3072
d5c20fe8
EZ
30732012-06-08 Eli Zaretskii <eliz@gnu.org>
3074
3075 * dispnew.c (showing_window_margins_p): Undo last change, which
3076 was done due to an inadvertent commit.
3077 (adjust_frame_glyphs_for_frame_redisplay): Do call
3078 showing_window_margins_p.
3079
513749ee
SM
30802012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3081
3082 * eval.c (Fmake_var_non_special): New primitive.
3083 (syms_of_eval): Defsubr it.
3084 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3085
d4a8f5c1
JB
30862012-06-08 Juanma Barranquero <lekktu@gmail.com>
3087
3088 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3089 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3090
8bbbc977
EZ
30912012-06-08 Eli Zaretskii <eliz@gnu.org>
3092
3093 * alloc.c (allocate_vectorlike): Fix last change.
3094
f3372c87
DA
30952012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3096
3097 Block-based vector allocation of small vectors.
3098 * lisp.h (struct vectorlike_header): New field `nbytes',
3099 adjust comment accordingly.
3100 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3101 to denote vector blocks. Adjust users (live_vector_p,
3102 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3103 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3104 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3105 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3106 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3107 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3108 (roundup_size): New constant.
3109 (struct vector_block): New data type.
3110 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3111 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3112 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3113 (sweep_vectors): New functions.
3114 (allocate_vectorlike): Return `zero_vector' as the only vector of
3115 0 items. Allocate new vector from block if vector size is less than
3116 or equal to VBLOCK_BYTES_MAX.
3117 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3118 (init_alloc_once): Add call to init_vectors.
3119
4f18a4ed
SM
31202012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3121
3122 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3123
86f158bc
PE
31242012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3125
3126 * doprnt.c (doprnt): Truncate multibyte char correctly.
3127 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3128 would mishandle a string argument "Xc" if X was a multibyte
3129 character of length 2: it would truncate after X's first byte
3130 rather than including all of X.
3131
c5cfcbe0
CY
31322012-06-06 Chong Yidong <cyd@gnu.org>
3133
3134 * buffer.c (word_wrap): Doc fix.
3135
c05cf390
PE
31362012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3137
3138 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3139
0c3461de
GM
31402012-06-03 Glenn Morris <rgm@gnu.org>
3141
3142 * xdisp.c (tool-bar-style): Doc fix.
3143
c71232db
UM
31442012-06-03 Ulrich Müller <ulm@gentoo.org>
3145
3146 * Makefile.in (PAXCTL): Define.
3147 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3148 binary via PaX flags if the paxctl utility is available.
3149 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3150 Restore PaX flags to their default. (Bug#11398)
3151
383f7350
CY
31522012-06-03 Chong Yidong <cyd@gnu.org>
3153
3154 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3155 buffer (Bug#11226).
3156
5f2c76c6
CY
31572012-06-03 Chong Yidong <cyd@gnu.org>
3158
3159 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3160 (note_mode_line_or_margin_highlight): If there is no help echo,
3161 use mode-line-default-help-echo. Handle the case where the mouse
3162 position is past the end of the mode line string.
3163
3164 * buffer.c (buffer_local_value_1): New function, split from
3165 Fbuffer_local_value; can return Qunbound.
3166 (Fbuffer_local_value): Use it.
3167 (Vmode_line_format): Docstring tweaks.
3168
773d47f6
PE
31692012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3170
3171 * sysdep.c (system_process_attributes): Improve comment.
3172
f2d6a3df
SM
31732012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3174
3175 * keyboard.c: Export real-this-command to Elisp.
3176 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3177 and DEFVAR it. Update all users.
3178
63810350
PE
31792012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3180
7bd5c1f4
PE
3181 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3182
63810350
PE
3183 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3184 Convert pctcpu and pctmem to Lisp float properly.
3185 Let the compiler fold better, as 100.0/0x8000 is exact.
3186
a2821611
AS
31872012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3188
3189 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3190 cons_block.
3191
5fceba1d
PE
31922012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3193
3194 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3195
c98ff5dd
DA
31962012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3197
3198 For a 'struct window', replace some Lisp_Object fields to
3199 bitfields where appropriate, remove unused fields.
3200 * window.h (struct window): Remove unused 'last_mark_x' and
3201 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3202 change it's type from Lisp_Object to bitfield.
3203 Change type of 'force_start', 'optional_new_start',
3204 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3205 fields from Lisp_Object to bitfield. Adjust users accordingly.
3206
ca34e0be
PE
32072012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3208
3209 Pacify gcc -Wdouble-precision when using Xaw.
3210 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3211 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3212 Use 'float' consistently, rather than 'float' in most places
3213 and 'double' in a couple of places.
3214
efc00ab1 32152012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3216
3217 * xdisp.c (handle_stop): Detect whether we have overlay strings
3218 loaded by testing it->current.overlay_string_index to be
3219 non-negative, instead of checking whether n_overlay_strings is
3220 positive. (Bug#11587)
3221
efc00ab1 32222012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3223
3224 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3225
3226 * doc.c (Fsubstitute_command_keys): Doc fix.
3227
efc00ab1 32282012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3229
3230 * search.c (search_buffer): Remove calls to
3231 r_alloc_inhibit_buffer_relocation, as it is now called by
3232 maybe_unify_char, which was the cause of relocation of buffer text
3233 in bug#11519.
3234
efc00ab1 32352012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3236
3237 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3238 for the duration of call to load_charset, to avoid problems with
3239 callers of maybe_unify_char that access buffer text through C
3240 pointers.
3241
3242 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3243 decrement the inhibition flag, instead of just setting or
3244 resetting it.
3245
ba93a187
PE
32462012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3247
3248 Remove obsolete '#define static' cruft.
3249 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3250 This #undef was "temporary" in 2000; it is no longer needed
3251 now that '#define static' has gone away.
3252 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3253 (gray_bitmap_bits): Remove; no longer needed.
3254 All uses replaced with definiens.
3255 * xterm.c: Include "bitmaps/gray.xbm".
3256
9e4bf381
PE
32572012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3258
3259 Clean up __executable_start, monstartup when --enable-profiling.
3260 The following changes affect the code only when profiling.
3261 * dispnew.c (__executable_start): Rename from safe_bcopy.
3262 Define only on platforms that need it.
3263 * emacs.c: Include <sys/gmon.h> when profiling.
3264 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3265 (__executable_start): Remove decl, since lisp.h does it now.
3266 (safe_bcopy): Remove decl; no longer has that name.
3267 (main): Coalesce #if into single bit of code, for simplicity.
3268 Cast pointers to uintptr_t, since standard libraries want integers
3269 and not pointers.
3270 * lisp.h (__executable_start): New decl.
3271
32d72c2f
GM
32722012-05-31 Glenn Morris <rgm@gnu.org>
3273
3274 * image.c (Fimagemagick_types): Doc fix.
3275
baac5bc7
JM
32762012-05-30 Jim Meyering <meyering@redhat.com>
3277
3278 * callproc.c (Fcall_process_region): Include directory component
3279 in mkstemp error message (Bug#11586).
3280
72cb32cf
PE
32812012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3282
3283 * alloc.c, lisp.h (make_pure_vector): Now static.
3284
61b108cc
SM
32852012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3286
3287 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3288 Move to byte-run.el.
3289 (Fautoload): Do the hash-doc more carefully.
3290 * data.c (Fdefalias): Purify definition, except for keymaps.
3291 (Qdefun): Move from eval.c.
3292 * lisp.h (Qdefun): Remove.
3293 * lread.c (read1): Tiny simplification.
3294
471fe23d
TN
32952012-05-29 Troels Nielsen <bn.troels@gmail.com>
3296
934f3f58 3297 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3298 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3299 Bug#9642, but explicitly check that the buffer the overlay would
3300 be moved to is live and rearrange lines to make sure that errors
3301 will not put the overlay in an inconsistent state.
3302 (Fdelete_overlay): Cosmetics.
3303
85d0efd1
EZ
33042012-05-28 Eli Zaretskii <eliz@gnu.org>
3305
3306 * w32term.c (my_bring_window_to_top): New function.
3307 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3308 could be different from the original one.
3309 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3310 (Bug#11513)
3311
3312 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3313 by calling BringWindowToTop.
3314
3315 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3316 (WM_EMACS_END): Increase by one.
3317
da92a98c
PE
33182012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3319
3320 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3321 This avoids undefined behavior that might cause the eassert
3322 to not catch an out-of-range value.
3323
74d1f848
JB
33242012-05-28 Juanma Barranquero <lekktu@gmail.com>
3325
3326 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3327 Update dependencies.
3328
9e1a06fc
EZ
33292012-05-27 Eli Zaretskii <eliz@gnu.org>
3330
3331 * bidi.c (bidi_mirror_char): Fix last change.
3332
f3dd7312
AS
33332012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3334
3335 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3336 when referring to sectname field in printf format.
3337
81899c91
PE
33382012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3339
57b81a9f
PE
3340 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3341 Only r_alloc_inhibit_buffer_relocation needed to be added;
3342 the others were already declared.
3343
81899c91
PE
3344 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3345 before checking whether it's out of range. Put the check inside
3346 eassert. See
3347 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3348
33017faf 33492012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3350
3351 * callproc.c (Fcall_process): Restore a line that was accidentally
3352 commented out in the 2011-02-13 change (bug#11547).
3353
33017faf 33542012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3355
3356 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3357 defined on ralloc.c.
3358
3359 * buffer.c [REL_ALLOC]: Remove prototypes of
3360 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3361 they are now on lisp.h.
3362
3363 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3364
3365 * search.c (search_buffer): Use it to inhibit relocation of buffer
3366 text while re_search_2 is doing its job, because re_search_2 is
3367 passed C pointers to buffer text. (Bug#11519)
3368
23415acf
EZ
3369 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3370 Update value to 24.
3371
44e27368
EZ
3372 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3373 state after an additional call to move_it_in_display_line_to, keep
3374 the values of it->max_ascent and it->max_descent found for the
3375 entire line.
3376 (pos_visible_p): Revert the comparison against bottom_y to what it
3377 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3378 (Bug#11464)
3379
c1892f11
PE
33802012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3381
3382 Fix coding-related core dumps with gcc -ftrapv.
3383 The code was computing A - B, where A and B are pointers, and B is
3384 random garbage. This can lead to core dumps on platforms that
3385 have special pointer registers, and it also leads to core dumps on
3386 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3387 A - B only when B is initialized properly.
3388 * coding.c (coding_set_source, coding_set_destination): Return void.
3389 (coding_change_source, coding_change_destinations): New functions,
3390 with the old behaviors of coding_set_source and coding_set_destination.
3391 All callers that need an offset changed to use these new functions.
3392
eb7afdad
GM
33932012-05-26 Glenn Morris <rgm@gnu.org>
3394
3395 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3396
f12fdf02
EZ
33972012-05-26 Eli Zaretskii <eliz@gnu.org>
3398
53a63be6 3399 Extend mouse support on W32 text-mode console.
61b108cc
SM
3400 * xdisp.c (draw_row_with_mouse_face):
3401 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3402
eb3f6f01 3403 * w32console.c: Include window.h.
61b108cc
SM
3404 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3405 New functions.
eb3f6f01
EZ
3406 (initialize_w32_display): Initialize mouse-highlight data.
3407
53a63be6
EZ
3408 * w32inevt.c: Include termchar.h and window.h.
3409 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3410 moves, call note_mouse_highlight. If help_echo changed, call
3411 gen_help_event to produce help-echo message in the echo area.
3412 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3413 highlight info.
3414
4cfd81f6
PE
34152012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3416
3417 * lread.c (read1): Simplify slightly to avoid an overflow warning
3418 with GCC 4.7.0 on x86-64.
3419
4446092a
EZ
34202012-05-26 Eli Zaretskii <eliz@gnu.org>
3421
3422 * bidi.c (bidi_mirror_char): Revert last change: an int is
3423 definitely wide enough here.
3424
42b2a986 34252012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3426
42b2a986 3427 Fix integer width and related bugs (Bug#9874).
eb106a49 3428 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3429 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3430 (string_bytes, check_sblock, allocate_string_data):
3431 (compact_small_strings, Fmake_bool_vector, make_string)
3432 (make_unibyte_string, make_multibyte_string)
3433 (make_string_from_bytes, make_specified_string)
3434 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3435 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3436 (mark_vectorlike):
3437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3438 (allocate_pseudovector):
3439 Use int, not EMACS_INT, where int is wide enough.
3440 (inhibit_garbage_collection, Fgarbage_collect):
3441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3442 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3443 int might not be wide enough.
3444 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3445 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3446 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3447 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3448 (bidi_level_of_next_char, bidi_move_to_visually_next):
3449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3450 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3451 (Fkill_buffer, Fset_buffer_major_mode)
3452 (advance_to_char_boundary, Fbuffer_swap_text)
3453 (Fset_buffer_multibyte, overlays_at, overlays_in)
3454 (overlay_touches_p, struct sortvec, record_overlay_string)
3455 (overlay_strings, recenter_overlay_lists)
3456 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3457 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3458 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3459 (Foverlay_recenter, last_overlay_modification_hooks_used)
3460 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3462 (validate_region): Omit unnecessary test for b <= e,
3463 since that's guaranteed by the previous test.
d311d28c
PE
3464 (adjust_overlays_for_delete): Avoid pos + length overflow.
3465 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3466 (report_overlay_modification):
3467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3468 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3469 Omit pointer cast, which isn't needed anyway, and doesn't work
3470 after the EMACS_INT -> ptrdiff_t change.
02481186 3471 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3472 * buffer.h: Adjust decls to match defn changes elsewhere.
3473 (struct buffer_text, struct buffer):
3474 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3475 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3476 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3477 not int, to avoid needless 32-bit limit on 64-bit hosts.
3478 (exec_byte_code): Use tighter memory-full test, one that checks
3479 for alloca overflow. Don't compute the address of the object just
3480 before an array, as that's not portable. Use EMACS_INT, not
3481 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3482 * callint.c (Fcall_interactively):
3483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3484 * callproc.c (call_process_kill, Fcall_process):
3485 Don't assume pid_t fits into an Emacs fixnum.
3486 (call_process_cleanup, Fcall_process, child_setup):
3487 Don't assume pid_t fits into int.
3488 (call_process_cleanup, Fcall_process, delete_temp_file)
3489 (Fcall_process_region):
3490 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3491 (Fcall_process): Simplify handling of volatile integers.
3492 Use int, not EMACS_INT, where int will do.
3493 * casefiddle.c (casify_object, casify_region, operate_on_word)
3494 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3496 (casify_object): Avoid integer overflow when overallocating buffer.
3497 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3498 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3499 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3500 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3501 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3502 integers are now checked earlier. All uses replaced with XINT.
3503 (ccl_driver):
3504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3505 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3506 (ccl_driver, Fregister_code_conversion_map):
3507 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3508 (resolve_symbol_ccl_program): Check that vector header is in range.
3509 Always copy the vector, so that we can check its contents reliably
3510 now rather than having to recheck each instruction as it's being
3511 executed. Check that vector words fit in 'int'.
3512 (ccl_get_compiled_code, Fregister_ccl_program)
3513 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3514 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3515 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3516 contents are in range.
3517 (Fccl_execute_on_string): Check that status is in range.
3518 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3519 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3520 Accept and return EMACS_INT, not int, because callers can pass values
3521 out of 'int' range.
3522 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3523 (multibyte_chars_in_text, parse_str_as_multibyte)
3524 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3525 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3526 (string_escape_byte8, Fget_byte):
3527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3528 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3529 avoid mishandling large integers.
3530 * character.h: Adjust decls to match defn changes elsewhere.
3531 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3532 (Ffind_charset_region):
3533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3534 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3535 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3536 Don't assume fixnum fits in int.
d311d28c
PE
3537 (load_charset_map_from_vector, Fmap_charset_chars):
3538 Remove now-unnecessary CHECK_NATNUMs.
3539 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3540 Don't rely on undefined behavior with signed left shift overflow.
3541 Don't assume unsigned int fits into fixnum, or that fixnum fits
3542 into unsigned int. Don't require max_code to be a valid fixnum;
3543 that's not true for gb10830 4-byte on a 32-bit host. Allow
3544 invalid_code to be a cons, for the same reason. Require code_offset
3545 to be a character. Avoid int overflow if max_char is close
3546 to INT_MAX.
3547 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3548 this is intended anyway and avoids some undefined behavior.
3549 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3550 INDEX_TO_CODE_POINT, as that's what it expects.
3551 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3552 * charset.h (DECODE_CHAR): Return int, not unsigned;
3553 this is what was intended anyway, and it avoids undefined behavior.
3554 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3555 integer-overflow issues.
3556 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3557 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3558 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3559 * chartab.c (Fmake_char_table, Fset_char_table_range)
3560 (uniprop_get_decoder, uniprop_get_encoder):
3561 Don't assume fixnum fits in int.
3562 * cmds.c (move_point): New function, that does the gist of
3563 Fforward_char and Fbackward_char, but does so while checking
3564 for integer overflow more accurately.
c96e5d6a 3565 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3566 (Fforward_line, Fend_of_line, internal_self_insert)
3567 (internal_self_insert):
3568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3569 Fix a FIXME, by checking for integer overflow when calculating
3570 target_clm and actual_clm.
3571 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3572 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3573 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3574 (coding_alloc_by_making_gap, alloc_destination)
3575 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3576 (encode_coding_utf_16, detect_coding_emacs_mule)
3577 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3578 (detect_coding_iso_2022, decode_coding_iso_2022)
3579 (encode_invocation_designation, encode_designation_at_bol)
3580 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3581 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3582 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3583 (encode_coding_ccl, encode_coding_raw_text)
3584 (detect_coding_charset, decode_coding_charset)
3585 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3586 (produce_composition, produce_charset, produce_annotation)
3587 (decode_coding, handle_composition_annotation)
3588 (handle_charset_annotation, consume_chars, decode_coding_gap)
3589 (decode_coding_object, encode_coding_object, detect_coding_system)
3590 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3591 (code_convert_region, code_convert_string)
8f50130c
PE
3592 (Fdefine_coding_system_internal)
3593 (coding_set_source, coding_set_destination):
d311d28c
PE
3594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3595 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3596 (Fdefine_coding_system_internal):
3597 Don't assume fixnums fit in int.
3598 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3599 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3600 (Funencodable_char_position, Fcheck_coding_systems_region)
3601 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3603 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3604 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3605 Don't access memory outside of the args array.
d311d28c 3606 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3607 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3608 result of ENCODE_CHAR.
d311d28c
PE
3609 * coding.h: Adjust decls to match defn changes elsewhere.
3610 (struct coding_system):
3611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3612 * composite.c (get_composition_id, find_composition)
3613 (run_composition_function, update_compositions)
3614 (compose_text, composition_gstring_put_cache)
3615 (composition_gstring_p, composition_gstring_width)
3616 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3617 (composition_compute_stop_pos, composition_reseat_it)
3618 (composition_update_it, struct position_record)
3619 (find_automatic_composition, composition_adjust_point)
3620 (Fcomposition_get_gstring, Ffind_composition_internal):
3621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3622 (update_compositions):
3623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3624 * composite.h: Adjust decls to match defn changes elsewhere.
3625 (struct composition):
3626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3627 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3628 Do not attempt to compute the address of the object just before a
3629 buffer; this is not portable.
3630 (Faref, Faset):
3631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3632 (Faset): Use int, not EMACS_INT, where int is wide enough.
3633 (Fstring_to_number): Don't assume fixnums fit in int.
3634 (Frem): Don't assume arg is nonnegative.
3635 * dbusbind.c (xd_append_arg): Check for integers out of range.
3636 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3637 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3638 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3639 (xd_get_connection_references): Return ptrdiff_t, not int.
3640 All uses changed.
3641 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3642 (xd_read_message_1):
3643 Use int, not unsigned, where the dbus API uses int.
3644 (Fdbus_message_internal): Don't overflow mtype.
3645 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3646 * dired.c (directory_files_internal, file_name_completion, scmp)
3647 (file_name_completion_stat):
3648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3649 (file_name_completion): Don't overflow matchcount.
3650 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3651 * dispextern.h: Adjust decls to match defn changes elsewhere.
3652 (struct text_pos, struct glyph, struct bidi_saved_info)
3653 (struct bidi_string_data, struct bidi_it, struct composition_it)
3654 (struct it):
3655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3656 (struct display_pos, struct composition_it, struct it):
3657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3658 * dispnew.c (increment_matrix_positions)
3659 (increment_row_positions, mode_line_string)
3660 (marginal_area_string):
3661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3662 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3663 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3664 (duration_to_sec_usec): New function, to check for overflow better.
3665 (Fsleep_for, sit_for): Use it.
3666 * doc.c (get_doc_string, store_function_docstring):
3667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3668 (get_doc_string, Fsnarf_documentation):
3669 Use int, not EMACS_INT, where int is wide enough.
3670 (get_doc_string):
3671 Use SAFE_ALLOCA, not alloca.
3672 Check for overflow when converting EMACS_INT to off_t.
3673 * doprnt.c (doprnt):
3674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3675 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3676 Don't assume uid_t fits into fixnum.
3677 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3678 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3679 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3680 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3681 (general_insert_function)
3682 (Finsert_char, make_buffer_string, make_buffer_string_both)
3683 (update_buffer_properties, Fbuffer_substring)
3684 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3685 (Fsubst_char_in_region, check_translation)
3686 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3687 (transpose_markers, Ftranspose_regions):
3688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3689 (clip_to_bounds): Move to lisp.h as an inline function).
3690 (Fconstrain_to_field): Don't assume integers are nonnegative.
3691 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3692 (Fsubst_char_in_region, Fsave_restriction):
3693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3694 (Femacs_pid): Don't assume pid_t fits into fixnum.
3695 (lo_time): Use int, not EMACS_INT, when int suffices.
3696 (lisp_time_argument): Check for usec out of range.
3697 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3698 (Fuser_login_name, Fuser_full_name): Signal an error
3699 if a uid argument is out of range, rather than relying on
3700 undefined behavior.
c8d5c857
PE
3701 (Fformat_time_string): Remove now-unnecessary check.
3702 lisp_time_argument checks for out-of-range usec now.
243e0530 3703 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3704 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3705 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3706 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3707 (init_cmdargs, Fdump_emacs):
3708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3709 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3710 the bottom (typically) 32 bits of the fixnum.
3711 * eval.c (specpdl_size, call_debugger):
3712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3713 (when_entered_debugger, Fbacktrace_debug):
3714 Don't assume fixnum can fit in int.
3715 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3716 the object just before a buffer; this is not portable.
3717 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3718 (grow_specpdl, unbind_to):
3719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3720 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3721 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3722 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3723 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3724 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3725 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3726 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3727 (a_write, e_write):
3728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3729 (Fcopy_file, non_regular_nbytes, read_non_regular)
3730 (Finsert_file_contents):
3731 Use int, not EMACS_INT, where int is wide enough.
3732 (READ_BUF_SIZE): Verify that it fits in int.
3733 (Finsert_file_contents): Check that counts are in proper range,
3734 rather than assuming fixnums fit into ptrdiff_t etc.
3735 Don't assume fixnums fit into int.
125b3835 3736 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3737 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3738 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3739 (string_char_to_byte, string_byte_to_char)
3740 (string_make_multibyte, string_to_multibyte)
3741 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3742 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3743 (substring_both, Fdelete, internal_equal, Ffillarray)
3744 (Fclear_string, mapcar1)
3745 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3746 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3747 (larger_vector, make_hash_table, maybe_resize_hash_table)
3748 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3749 (Fmaphash, secure_hash):
3750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3751 (concat): Check for string index and length overflow.
3752 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3753 (Frequire):
3754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3755 (larger_vector): New API (vec, incr_min, size_max) replaces old
3756 one (vec, new_size, init). This catches size overflow.
3757 INIT was removed because it was always Qnil.
3758 All callers changed.
3759 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3760 the upper bound on a hash table index size.
3761 (make_hash_table, maybe_resize_hash_table): Use it.
3762 (secure_hash): Computer start_byte and end_byte only after
3763 they're known to be in ptrdiff_t range.
3764 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3765 (Ffont_get_glyphs, Ffont_at):
3766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3767 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3768 (Flist_fonts, Fopen_font):
3769 Don't assume fixnum can fit in int.
3770 (check_gstring): Don't assume index can fit in int.
3771 (font_match_p): Check that fixnum is a character, not a nonnegative
3772 fixnum, since the later code needs to stuff it into an int.
3773 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3774 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3775 conversion overflow issues.
3776 (Fopen_font): Check for integer out of range.
3777 (Ffont_get_glyphs): Don't assume index can fit in int.
3778 * font.h: Adjust decls to match defn changes elsewhere.
3779 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3780 integer overflow.
3781 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3782 printmax_t, where ptrdiff_t is wide enough.
3783 (Finternal_char_font):
3784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3785 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3786 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3787 (Fset_frame_position, x_set_frame_parameters)
3788 (x_set_line_spacing, x_set_border_width)
3789 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3790 Check that fixnums are in proper range for system types.
3791 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3793 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3794 Use SAFE_ALLOCA_LISP, not alloca.
3795 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3796 intptr_t is wide enough.
3797 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3798 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3799 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3800 Check for fixnum out of range.
3801 * ftfont.c (ftfont_list): Don't assume index fits in int.
3802 Check that fixnums are in proper range for system types.
3803 (ftfont_shape_by_flt):
3804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3805 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3807 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3808 Check that fixnums are in proper range for system types.
3809 * gnutls.h: Adjust decls to match defn changes elsewhere.
3810 * gtkutil.c (xg_dialog_run):
3811 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3812 (update_frame_tool_bar):
3813 Check that fixnums are in proper range for system types.
3814 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3815 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3816 * indent.c (last_known_column, last_known_column_point):
3817 (current_column_bol_cache):
3818 (skip_invisible, current_column, check_display_width):
3819 (check_display_width, scan_for_column, current_column_1)
3820 (Findent_to, Fcurrent_indentation, position_indentation)
3821 (indented_beyond_p, Fmove_to_column, compute_motion):
3822 (Fcompute_motion, Fvertical_motion):
3823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3824 (last_known_column_modified): Use EMACS_INT, not int.
3825 (check_display_width):
3826 (Fcompute_motion):
3827 Check that fixnums and floats are in proper range for system types.
3828 (compute_motion): Don't assume index or fixnum fits in int.
3829 (compute_motion, Fcompute_motion):
3830 Use int, not EMACS_INT, when it is wide enough.
3831 (vmotion): Omit local var start_hpos that is always 0; that way
3832 we don't need to worry about overflow in expressions involving it.
3833 * indent.h: Adjust decls to match defn changes elsewhere.
3834 (struct position):
3835 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3836 Use int, not EMACS_INT, where int is wide enough.
3837 Remove unused members ovstring_chars_done and tab_offset;
3838 all uses removed.
3839 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3840 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3841 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3842 (make_gap, copy_text, insert, insert_and_inherit)
3843 (insert_before_markers, insert_before_markers_and_inherit)
3844 (insert_1, count_combining_before, count_combining_after)
3845 (insert_1_both, insert_from_string)
3846 (insert_from_string_before_markers, insert_from_string_1)
3847 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3848 (adjust_after_replace, adjust_after_insert, replace_range)
3849 (replace_range_2, del_range, del_range_1, del_range_byte)
3850 (del_range_both, del_range_2, modify_region)
3851 (prepare_to_modify_buffer, signal_before_change)
3852 (signal_after_change, Fcombine_after_change_execute):
3853 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3854 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3855 (balance_an_interval, split_interval_right, split_interval_left)
3856 (find_interval, next_interval, update_interval)
3857 (adjust_intervals_for_insertion, delete_node, delete_interval)
3858 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3859 (static_offset_intervals, offset_intervals)
3860 (merge_interval_right, merge_interval_left, make_new_interval)
3861 (graft_intervals_into_buffer, temp_set_point_both)
3862 (temp_set_point, set_point, adjust_for_invis_intang)
3863 (set_point_both, move_if_not_intangible, get_property_and_range)
3864 (get_local_map, copy_intervals, copy_intervals_to_string)
3865 (compare_string_intervals, set_intervals_multibyte_1):
3866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3867 * intervals.h: Adjust decls to match defn changes elsewhere.
3868 (struct interval):
3869 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3870 * keyboard.c (this_command_key_count, this_single_command_key_start)
3871 (before_command_key_count, before_command_echo_length, echo_now)
3872 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3873 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3874 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3875 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3877 (last_non_minibuf_size, last_point_position, echo_truncate)
3878 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3879 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3880 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3881 (stuff_buffered_input):
3882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3883 (last_auto_save, command_loop_1, read_char):
3884 Use EMACS_INT, not int, to avoid integer overflow.
3885 (record_char): Avoid overflow in total_keys computation.
3886 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3887 * keyboard.h: Adjust decls to match defn changes elsewhere.
3888 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3889 (Fkey_description, Fdescribe_vector, Flookup_key):
3890 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3891 (click_position): New function, to check that positions are in range.
3892 (Fcurrent_active_maps):
3893 (describe_command):
3894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3895 (Faccessible_keymaps, Fkey_description):
3896 (preferred_sequence_p):
3897 Don't assume fixnum can fit into int.
3898 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3899 Check for integer overflow in size calculations.
3900 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3901 avoid mishandling large integers.
3902 * lisp.h: Adjust decls to match defn changes elsewhere.
3903 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3904 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3905 (struct Lisp_Marker):
3906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3907 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3908 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3909 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3910 All callers changed.
3911 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3912 Assume the arg has valid form, since it always does.
3913 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3914 unsigned integer system type.
3915 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3916 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3918 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3919 (duration_to_sec_usec): New decl.
3920 * lread.c (read_from_string_index, read_from_string_index_byte)
3921 (read_from_string_limit, readchar, unreadchar, openp)
3922 (read_internal_start, read1, oblookup):
3923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3924 (Fload, readevalloop, Feval_buffer, Feval_region):
3925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3926 (openp): Check for out-of-range argument to 'access'.
3927 (read1): Use int, not EMACS_INT, where int is wide enough.
3928 Don't assume fixnum fits into int.
6efdadfd 3929 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3930 (read_filtered_event): Use duration_to_sec_usec
3931 to do proper overflow checking on durations.
d311d28c
PE
3932 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3933 in size calculation.
3934 (Fexecute_kbd_macro):
3935 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3936 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3937 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3938 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3939 (set_marker_both, set_marker_restricted_both, marker_position)
3940 (marker_byte_position, Fbuffer_has_markers_at):
3941 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3942 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3943 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3944 It now merely ensures that the menu is large enough, without
3945 necessarily growing it, as this avoids some integer overflow issues.
3946 All callers changed.
3947 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3948 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3949 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3950 Use SAFE_ALLOCA_LISP, not alloca.
3951 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3952 to EMACS_INT. Check that fixnums are in proper range for system types.
3953 * minibuf.c (minibuf_prompt_width, string_to_object)
3954 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3955 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3957 (get_minibuffer, read_minibuf_unwind):
3958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3959 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3960 this simplifies overflow checking. All callers changed.
3961 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3962 (Ftest_completion):
3963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3964 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3965 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3966 Check that fixnums are in proper range for system types.
3967 (Fx_create_frame, Fx_show_tip):
3968 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3969 * nsfont.m (ns_findfonts, nsfont_list_family):
3970 Don't assume fixnum fits in long.
3971 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3972 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3973 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3974 wide enough.
17fdb222 3975 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3977 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3978 (PRINTDECLARE, PRINTPREPARE):
3979 (strout, print_string):
3980 (print, print_preprocess, print_check_string_charset_prop)
3981 (print_object):
3982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3983 (PRINTDECLARE):
3984 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3986 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3987 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3988 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3989 (print_error_message): Use SAFE_ALLOCA, not alloca.
3990 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3991 (print_depth, new_backquote_output, print_number_index):
3992 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3993 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3994 (Fset_process_window_size, Fformat_network_address)
3995 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3996 (sigchld_handler):
d311d28c 3997 Check that fixnums are in proper range for system types.
d44287d4 3998 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3999 Check for process-ids out of pid_t range rather than relying on
4000 undefined behavior.
e4d81efc 4001 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4002 (Fformat_network_address, read_process_output, send_process)
4003 (Fprocess_send_region, status_notify):
4004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4005 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4006 (wait_reading_process_output, read_process_output, exec_sentinel):
4007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4008 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4009 (Faccept_process_output): Use duration_to_sec_usec to do proper
4010 overflow checking on durations.
dde14581
PE
4011 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4012 Don't assume pid_t fits in int.
02481186
PE
4013 * process.h (struct Lisp_Process): Members tick and update_tick
4014 are now of type EMACS_INT, not int.
b62b53e8
PE
4015 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4016 configured --with-wide-int.
d311d28c
PE
4017 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4018 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4019 * search.c (looking_at_1, string_match_1):
4020 (fast_string_match, fast_c_string_match_ignore_case)
4021 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4022 (scan_newline, find_before_next_newline, search_command)
4023 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4024 (set_search_regs, wordify):
4025 (Freplace_match):
4026 (Fmatch_data):
4027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4028 (string_match_1, search_buffer, set_search_regs):
4029 (Fmatch_data):
4030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4031 (wordify): Check for overflow in size calculation.
4032 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4033 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4034 Check that fixnums are in proper range for system types.
4035 * sound.c (struct sound_device)
4036 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4038 (Fplay_sound_internal):
4039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4040 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4041 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4042 (Fparse_partial_sexp):
4043 Don't assume fixnums can fit in int.
4044 (struct lisp_parse_state, find_start_pos, find_start_value)
4045 (find_start_value_byte, find_start_begv)
4046 (update_syntax_table, char_quoted, dec_bytepos)
4047 (find_defun_start, prev_char_comend_first, back_comment):
4048 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4049 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4050 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4051 (Finternal_describe_syntax_value): Check that match_lisp is a
4052 character, not an integer, since the code stuffs it into int.
4053 (scan_words, scan_sexps_forward):
4054 Check that fixnums are in proper range for system types.
4055 (Fforward_word):
4056 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4057 (scan_sexps_forward):
4058 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4059 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4060 * syntax.h: Adjust decls to match defn changes elsewhere.
4061 (struct gl_state_s):
4062 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4063 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4064 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4065 * sysdep.c (wait_for_termination_1, wait_for_termination)
4066 (interruptible_wait_for_termination, mkdir):
4067 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4068 (emacs_read, emacs_write):
4069 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4070 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4071 and double all fit in int.
d311d28c
PE
4072 * term.c (set_tty_color_mode):
4073 Check that fixnums are in proper range for system types.
4074 * termhooks.h (struct input_event):
4075 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4076 * textprop.c (validate_interval_range, interval_of)
4077 (Fadd_text_properties, set_text_properties_1)
4078 (Fremove_text_properties, Fremove_list_of_text_properties)
4079 (Ftext_property_any, Ftext_property_not_all)
4080 (copy_text_properties, text_property_list, extend_property_ranges)
4081 (verify_interval_modification):
4082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4083 (Fnext_single_char_property_change)
4084 (Fprevious_single_char_property_change):
4085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4086 (copy_text_properties):
4087 Check for integer overflow in index calculation.
d311d28c
PE
4088 * undo.c (last_boundary_position, record_point, record_insert)
4089 (record_delete, record_marker_adjustment, record_change)
4090 (record_property_change):
4091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4092 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4094 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4095 (Fx_hide_tip, Fx_file_dialog):
4096 * w32menu.c (set_frame_menubar):
4097 Use ptrdiff_t, not int, for consistency with rest of code.
4098 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4099 (select_window, Fdelete_other_windows_internal)
4100 (window_scroll_pixel_based, window_scroll_line_based)
4101 (Frecenter, Fset_window_configuration):
4102 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4103 (Fset_window_hscroll, run_window_configuration_change_hook)
4104 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4105 (Fscroll_other_window, Frecenter):
d311d28c
PE
4106 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4107 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4108 Don't assume fixnum fits in int.
4109 (Fset_window_scroll_bars):
4110 Check that fixnums are in proper range for system types.
4111 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4112 (string_pos, c_string_pos, number_of_chars, init_iterator)
4113 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4114 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4115 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4116 (face_before_or_after_it_pos, handle_invisible_prop)
4117 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4118 (display_prop_intangible_p, string_buffer_position_lim)
4119 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4120 (get_overlay_strings_1, get_overlay_strings)
4121 (iterate_out_of_display_property, forward_to_next_line_start)
4122 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4123 (get_next_display_element, set_iterator_to_next)
4124 (get_visually_first_element, compute_stop_pos_backwards)
4125 (handle_stop_backwards, next_element_from_buffer)
4126 (move_it_in_display_line_to, move_it_in_display_line)
4127 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4128 (add_to_log, message_dolog, message_log_check_duplicate)
4129 (message2, message2_nolog, message3, message3_nolog
4130 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4131 (current_message_1, truncate_echo_area, truncate_message_1)
4132 (set_message, set_message_1, store_mode_line_noprop)
4133 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4134 (text_outside_line_unchanged_p, check_point_in_composition)
4135 (reconsider_clip_changes)
4136 (redisplay_internal, set_cursor_from_row, try_scrolling)
4137 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4138 (redisplay_window, find_last_unchanged_at_beg_row)
4139 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4140 (trailing_whitespace_p, find_row_edges, display_line)
4141 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4142 (display_mode_element, store_mode_line_string)
4143 (pint2str, pint2hrstr, decode_mode_spec)
4144 (display_count_lines, display_string, draw_glyphs)
4145 (x_produce_glyphs, x_insert_glyphs)
4146 (rows_from_pos_range, mouse_face_from_buffer_pos)
4147 (fast_find_string_pos, mouse_face_from_string_pos)
4148 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4150 (safe_call, init_from_display_pos, handle_fontified_prop)
4151 (handle_single_display_spec, load_overlay_strings)
4152 (with_echo_area_buffer, setup_echo_area_for_printing)
4153 (display_echo_area, echo_area_display)
4154 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4155 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4156 (redisplay_window, dump_glyph_row, display_mode_line)
4157 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4158 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4160 (handle_single_display_spec, build_desired_tool_bar_string)
4161 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4162 (get_specified_cursor_type):
4163 Check that fixnums are in proper range for system types.
4164 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4165 (Flookup_image_map):
4166 Don't assume fixnums fit in int.
4167 (compare_overlay_entries):
4168 Avoid mishandling comparisons due to subtraction overflow.
4169 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4170 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4171 (handle_tool_bar_click):
4172 Use int, not unsigned, since we prefer signed and the signedness
4173 doesn't matter here.
4174 (get_next_display_element, next_element_from_display_vector):
4175 Use int, not EMACS_INT, when int is wide enough.
4176 (start_hourglass): Use duration_to_sec_usec to do proper
4177 overflow checking on durations.
4178 * xfaces.c (Fbitmap_spec_p):
4179 Check that fixnums are in proper range for system types.
4180 (compare_fonts_by_sort_order):
4181 Avoid mishandling comparisons due to subtraction overflow.
4182 (Fx_family_fonts, realize_basic_faces):
4183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4184 (Fx_family_fonts):
4185 Don't assume fixnum fits in int.
4186 Use SAFE_ALLOCA_LISP, not alloca.
4187 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4188 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4189 (face_at_buffer_position, face_for_overlay_string)
4190 (face_at_string_position):
4191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4192 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4193 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4194 (Fx_show_tip):
4195 Check that fixnums are in proper range for system types.
4196 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4197 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4198 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4199 (Fx_change_window_property): Don't assume fixnums fit in int.
4200 * xfont.c (xfont_chars_supported):
4201 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4202 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4203 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4204 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4205 * xml.c (parse_region):
4206 * xrdb.c (magic_file_p):
4207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4208 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4209 (x_get_local_selection, x_reply_selection_request)
4210 (x_handle_selection_request, wait_for_property_change):
4211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4212 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4213 short is wide enough.
4214 (x_send_client_event): Don't assume fixnum fits in int.
4215 * xterm.c (x_x_to_emacs_modifiers):
4216 Don't assume EMACS_INT overflows nicely into int.
4217 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4218 may come from Lisp.
4219 (handle_one_xevent): NATNUMP can eval its arg twice.
4220 (x_connection_closed):
4221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4222 * xterm.h: Adjust decls to match defn changes elsewhere.
4223 (struct scroll_bar): Use struct vectorlike_header
4224 rather than rolling our own approximation.
4225 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4226
c6574eb5
GM
42272012-05-25 Glenn Morris <rgm@gnu.org>
4228
4229 * lisp.mk (lisp): Update for more files being compiled now.
4230
e8d32c7e
SM
42312012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4232
48def666
SM
4233 * lread.c: Remove `read_pure' which makes no difference.
4234 (read_pure): Remove var.
4235 (unreadpure): Remove function.
4236 (readevalloop): Don't call read_list with -1 flag.
4237 (read1, read_vector): Don't test read_pure any more.
4238 (read_list): Simplify.
4239
e8d32c7e
SM
4240 * fileio.c, character.h: Minor style tweaks.
4241
4b2addb7
DA
42422012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4243
4244 * window.h (clip_changed): Remove useless declaration.
4245
584461b2
JB
42462012-05-22 Juanma Barranquero <lekktu@gmail.com>
4247
4248 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4249 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4250
34374650
PE
42512012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4252
4253 Remove src/m/*.
4254 This directory predates autoconf and is no longer needed nowadays.
4255 Move its few remaining bits of functionality to where they're needed.
4256 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4257 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4258 * m/template.h: Remove.
4259 * Makefile.in (M_FILE): Remove. All uses removed.
4260 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4261 * lisp.h (USE_LSB_TAG):
4262 * mem-limits.h (EXCEEDS_LISP_PTR):
4263 Use VAL_MAX, not VALBITS, in #if.
4264 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4265 (EMACS_UINT): Define unconditionally now.
4266 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4267 (BITS_PER_EMACS_INT): New constants, replacing
4268 what used to be in config.h, but not useful in #if.
4269 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4270 define them any more.
4271 (VAL_MAX): New macro.
4272 (VALMASK): Use it.
4273 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4274 BITS_PER_EMACS_INT, in #if.
4275 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4276 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4277 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4278 * s/ms-w32.h (DATA_START):
4279 Move here from removed file m/intel386.h.
4280 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4281 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4282
261cb4bb
PE
42832012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4284
4285 Assume C89 or later.
4286 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4287 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4288 (xrealloc):
4289 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4290 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4291 * textprop.c, tparam.c (NULL): Remove.
4292 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4293 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4294 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4295 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4296 * xterm.c (input_signal_count): Assume volatile works.
4297
ff23cd9f
KB
42982012-05-21 Ken Brown <kbrown@cornell.edu>
4299
4300 * xgselect.c (xg_select): Fix first argument in call to 'select'
4301 (bug#11508).
4302
1b170bc6
KB
43032012-05-20 Ken Brown <kbrown@cornell.edu>
4304
4305 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4306 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4307
b2f4d39f
KB
43082012-05-19 Ken Brown <kbrown@cornell.edu>
4309
4310 * xfns.c (x_in_use): Remove `static' qualifier.
4311 * xterm.h (x_in_use): Declare.
4312 * xgselect.c: Include xterm.h.
4313 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4314 and `display_arg' (bug#9754).
4315
003fdae2
PE
43162012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4317
9232a6d9
PE
4318 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4319
003fdae2
PE
4320 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4321 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4322
784b56e2
EZ
43232012-05-18 Eli Zaretskii <eliz@gnu.org>
4324
4325 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4326
4327 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4328 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4329
4330 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4331 reference to image_cache->refcount.
4332 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4333
a0a79cde
JL
43342012-05-17 Juri Linkov <juri@jurta.org>
4335
4336 * search.c (Fword_search_regexp, Fword_search_backward)
4337 (Fword_search_forward, Fword_search_backward_lax)
4338 (Fword_search_forward_lax): Move functions to isearch.el
4339 (bug#10145, bug#11381).
4340
b0572523
PE
43412012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4342
4343 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4344
9660f5fc
SM
43452012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4346
4347 * lread.c (init_obarray): Declare Qt and Qnil as special.
4348
4374de83
GM
43492012-05-14 Glenn Morris <rgm@gnu.org>
4350
4351 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4352 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4353
dc44c39a
PE
43542012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4355
078c97cb
PE
4356 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4357
dc44c39a
PE
4358 * unexaix.c: Port to more-recent AIX compilers.
4359 (report_error, report_error_1, make_hdr, copy_sym)
4360 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4361 Make arguments const char *, not char *, to avoid violations of C
4362 standard and to fix some AIX warnings reported by Gilles Pion.
4363
e18afed7 43642012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4365
4366 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4367 already have overlays loaded.
4368 (handle_single_display_spec): Before returning without displaying
4369 fringe bitmap, synchronize the bidi iterator with the main display
4370 iterator, by calling iterate_out_of_display_property.
4371 (iterate_out_of_display_property): Detect buffer iteration by
4372 testing that it->string is a Lisp string.
4373 (get_next_display_element): When the current object is exhausted,
4374 and there's something on it->stack, call set_iterator_to_next to
4375 proceed with what's on the stack, instead of returning zero.
4376 (set_iterator_to_next): If called at the end of a Lisp string,
4377 proceed to consider_string_end without incrementing string
4378 position. Don't increment display vector index past the end of
4379 the display vector. (Bug#11417)
c8fb9dc6
EZ
4380 (pos_visible_p): Don't report a position visible when move_it_to
4381 stopped at the last line of window, which happens to be scanned
4382 backwards by the bidi iteration. (Bug#11464)
ac268e67 4383
e18afed7 43842012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4385
4386 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4387 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4388 are on a TTY, and thus unable to display on the fringes.
4389 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4390 so we need to signal to the caller that this is a "replacing"
4391 display spec. This fixes display when the spec is invalid or we
4392 are on a TTY.
4393
e18afed7 43942012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4395
4396 * unexaix.c (make_hdr): Fix typo in prototype.
4397 This bug broke the build on AIX. Problem reported by Gilles Pion.
4398
9d0a235a
MA
43992012-05-14 Michael Albinus <michael.albinus@gmx.de>
4400
4401 * keyboard.c (kbd_buffer_get_event): Read special events also in
4402 batch mode. (Bug#11415)
4403
9e6b06ed
GM
44042012-05-12 Glenn Morris <rgm@gnu.org>
4405
4406 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4407
c1a1d7a3
EZ
44082012-05-12 Eli Zaretskii <eliz@gnu.org>
4409
4410 * lisp.mk (lisp): Add newcomment.elc.
4411
3fe7cdc8
GM
44122012-05-12 Glenn Morris <rgm@gnu.org>
4413
4414 * Makefile.in (MKDIR_P): New, set by configure.
4415 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4416
53f7d2c0
PE
44172012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4418
4419 Remove unused function hourglass_started.
4420 * dispextern.h (hourglass_started):
4421 * w32fns.c (hourglass_started):
4422 * xdisp.c (hourglass_started): Remove.
4423
75aafb17
JB
44242012-05-10 Juanma Barranquero <lekktu@gmail.com>
4425
4426 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4427 Update dependencies.
4428
12959e8e
PE
44292012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4430
97107e2e
PE
4431 * xgselect.c (xg_select): Put maxfds+1 into a var.
4432 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4433
12959e8e
PE
4434 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4435
836d29b3
DA
44362012-05-10 Dave Abrahams <dave@boostpro.com>
4437
4438 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4439 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4440
5cb67954
MA
44412012-05-09 Michael Albinus <michael.albinus@gmx.de>
4442
4443 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4444 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4445 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4446 Initialize xd_registered_buses.
4447
3478ec45
PE
44482012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4449
b263a6b0
PE
4450 Untag more efficiently if USE_LSB_TAG.
4451 This is based on a proposal by YAMAMOTO Mitsuharu in
4452 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4453 For an admittedly artificial (nth 8000 longlist) benchmark on
4454 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4455 Emacs's overall text size by 1%.
4456 * lisp.h (XUNTAG): New macro.
4457 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4458 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4459 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4460 * eval.c (Fautoload):
4461 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4462 * frame.h (XFRAME): Use XUNTAG.
4463
3478ec45
PE
4464 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4465 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4466 Remove unportable assumptions about print widths of types like
4467 dbus_uint32_t.
4468 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4469 intptr_t when converting between pointer and integer, to avoid GCC
4470 warnings about wrong width.
4471
666b903b 44722012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4473
4474 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4475 stack for each reader_thread, instead of defaulting to 8MB
4476 determined by the linker. This avoids failures in creating
4477 subprocesses on Windows 7, see the discussion in this thread:
4478 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4479
b120cc17
JC
44802012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4481
4482 Fix up display of the *Minibuf-0* buffer in the mini window.
4483 * keyboard.c (read_char): Don't clear the echo area if there's no
4484 message to clear.
4485 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4486 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4487
9a4b36f8
MA
44882012-05-07 Michael Albinus <michael.albinus@gmx.de>
4489
4490 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4491 batch mode.
4492
e5f9458f
CY
44932012-05-06 Chong Yidong <cyd@gnu.org>
4494
4495 * lisp.mk (lisp): Update.
4496
eceeb5fc 44972012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4498
4499 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4500
71873e2b
SM
45012012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4502
4503 * data.c (PUT_ERROR): New macro.
4504 (syms_of_data): Use it. Add new error type `user-error'.
4505 * undo.c (user_error): New function.
4506 (Fprimitive_undo): Use it.
4507 * print.c (print_error_message): Adjust print style for `user-error'.
4508 * keyboard.c (user_error): New function.
4509 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4510
ab0fa4e4
PE
45112012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4512
4513 Do not limit current-time-string to years 1000..9999.
4514 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4515 (Fcurrent_time_string): Support any year that is supported by the
4516 underlying localtime representation. Don't use asctime, as it
4517 has undefined behavior for years outside the range -999..9999.
4518
7ed806a7
PE
45192012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4520
4521 Fix race conditions involving setenv, gmtime, localtime, asctime.
4522 Without this fix, interrupts could mess up code that uses these
4523 nonreentrant functions, since setting TZ invalidates existing
4524 tm_zone or tzname values, and since most of these functions return
4525 pointers to static storage.
4526 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4527 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4528 Grow the critical sections to include not just invoking
4529 localtime/gmtime, but also accessing these functions' results
4530 including their tm_zone values if any, and any related TZ setting.
4531 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4532 so that the struct tm is saved in the critical section.
4533 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4534 motivated by the fact that memory allocation needs to be outside
4535 the critical section.
4536
0c16dfed
DA
45372012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4538
4539 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4540 with RESET_INTERVAL.
4541
4542 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4543 Remove duplicated buffer name initialization.
4544
3f83ace8
JM
45452012-05-02 Jim Meyering <jim@meyering.net>
4546
4547 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4548
c7b8541e
JM
4549 * xfns.c (x_window): Use xstrdup (Bug#11375).
4550
90207a15 45512012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4552
4553 * xdisp.c (pos_visible_p): If already at a newline from the
4554 display string before the 'while' loop, don't walk back the glyphs
4555 from it3.glyph_row. Solves assertion violation when the display
4556 string begins with a newline (egg.el). (Bug#11367)
4557
b593d6a9
AH
45582012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4559
4560 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4561 Move to simple.el.
4562
4737362e
GM
45632012-05-01 Glenn Morris <rgm@gnu.org>
4564
99cf43f9
GM
4565 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4566 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4567 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4568 All were removed before 23.1.
4569
9311dcff
GM
4570 * dispnew.c: Remove HAVE_LIBNCURSES test;
4571 it is always true on relevant platforms.
4572
4d5c6349
GM
4573 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4574 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4575
4737362e
GM
4576 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4577
74dd3a6b
AS
45782012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4579
4580 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4581 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4582 Remove.
4583
13c379ee
PE
45842012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4585
4586 Do not avoid creating empty evaporating overlays (Bug#9642).
4587 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4588 That is, do not delete an evaporating overlay if it becomes
4589 empty after its bounds are adjusted to fit within its buffer.
4590 This fix caused other problems, and I'm reverting it until we get
4591 to the bottom of them.
4592
a8e7d6d7 45932012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4594
4595 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4596
a8e7d6d7 45972012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4598
4599 * xdisp.c (pos_visible_p): If the window start position is beyond
4600 ZV, start the display from buffer beginning. Prevents assertion
4601 violation in init_iterator when the minibuffer window is scrolled
4602 via the scroll bar.
4603
4604 * window.c (window_scroll_pixel_based): Likewise.
4605
a8e7d6d7 46062012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4607
4608 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4609
a8e7d6d7 46102012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4611
4612 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4613 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4614
a8e7d6d7 46152012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4616
b593d6a9
AH
4617 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4618 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4619
1c6900d9
EZ
46202012-04-26 Eli Zaretskii <eliz@gnu.org>
4621
4c3fa1d9
EZ
4622 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4623 display element, check also the underlying string or buffer
4624 character. (Bug#11341)
4625
1c6900d9
EZ
4626 * w32menu.c: Include w32heap.h.
4627 (add_menu_item): If the call to AppendMenuW (via
4628 unicode_append_menu) fails, disable Unicode menus only if we are
4629 running on Windows 9X/Me.
4630
42bf8205
AS
46312012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4632
4633 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4634 (xgetint): Add missing shift for LSB tags.
4635
b1bac16e
MR
46362012-04-24 Martin Rudalics <rudalics@gmx.at>
4637
4638 * keyboard.c (read_char): Don't wipe echo area for select window
4639 events: These might get delayed via `mouse-autoselect-window'
4640 (Bug#11304).
4641
d69621cc
JB
46422012-04-24 Juanma Barranquero <lekktu@gmail.com>
4643
4644 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4645 manipulation of :loaded-from data.
4646
02fd101b
JB
46472012-04-23 Juanma Barranquero <lekktu@gmail.com>
4648
4649 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4650 now a cons (bug#11311).
4651
888bec30
PE
46522012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4653
89a438bd
PE
4654 Do not create empty overlays with the evaporate property (Bug#9642).
4655 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4656 if it becomes empty after its bounds are adjusted to fit within
4657 its buffer. Without this fix, in a nonempty buffer (let ((o
4658 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4659 yields an empty overlay that has the evaporate property, which is
4660 not supposed to happen.
4661
1068fe4d
PE
4662 Fix minor GTK3 problems found by static checking.
4663 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4664 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4665 (struct _EmacsFixedClass, emacs_fixed_get_type):
4666 Move decls here from emacsgtkfixed.h, since they needn't be public.
4667 (emacs_fixed_get_type): Now static.
4668 (emacs_fixed_class_init): Omit unused local.
4669 (emacs_fixed_child_type): Remove; unused.
4670 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4671 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4672 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4673 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4674 (EMACS_FIXED_GET_CLASS): Remove; unused.
4675 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4676
888bec30
PE
4677 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4678 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4679
de85e130
PE
46802012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4681
d0baac98 4682 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4683 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4684 (__malloc_size_t, __malloc_ptrdiff_t):
4685 Remove. All uses removed, replaced by the definiens if needed,
4686 since we can assume C89 or better now.
4687 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4688 (protect_malloc_state, align, get_contiguous_space)
4689 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4690 (malloc_atfork_handler_child, malloc_enable_thread)
4691 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4692 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4693 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4694 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4695 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4696 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4697 Define using prototypes, not old style.
4698 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4699 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4700 (align): Don't assume that signed integer overflow wraps around.
4701 Omit unused local var.
4702 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4703 (_free_internal_nolock, memalign, mallochook, reallochook):
4704 Omit no-longer-needed casts.
4705 (valloc): Use getpagesize, not __getpagesize.
4706 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4707 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4708
de85e130
PE
4709 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4710
dcbf5805
MA
47112012-04-22 Michael Albinus <michael.albinus@gmx.de>
4712
4713 Move functions from C to Lisp. Make non-blocking method calls
4714 the default. Implement further D-Bus standard interfaces.
4715
4716 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4717 (QCdbus_request_name_allow_replacement)
4718 (QCdbus_request_name_replace_existing)
4719 (QCdbus_request_name_do_not_queue)
4720 (QCdbus_request_name_reply_primary_owner)
4721 (QCdbus_request_name_reply_in_queue)
4722 (QCdbus_request_name_reply_exists)
4723 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4724 (QCdbus_registered_serial, QCdbus_registered_method)
4725 (QCdbus_registered_signal): New Lisp objects.
4726 (XD_DEBUG_MESSAGE): Use sizeof.
4727 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4728 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4729 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4730 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4731 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4732 (xd_signature, xd_append_arg): Allow float for integer types.
4733 (xd_get_connection_references): New function.
b593d6a9
AH
4734 (xd_get_connection_address): Rename from xd_initialize.
4735 Return cached address.
dcbf5805
MA
4736 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4737 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4738 level.
4739 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4740 Return number of refcounts.
dcbf5805
MA
4741 (Fdbus_get_unique_name): Make stronger parameter check.
4742 (Fdbus_message_internal): New defun.
4743 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4744 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4745 (Fdbus_send_signal, Fdbus_register_service)
4746 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4747 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4748 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4749 (Vdbus_compiled_version, Vdbus_runtime_version)
4750 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4751 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4752 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4753 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4754 Adapt docstring.
dcbf5805 4755
52828e02
PE
47562012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4757
da05bc4c
PE
4758 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4759 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4760 Do not assume ptrdiff_t is the same width as 'int'.
4761
52828e02
PE
4762 * alloc.c: Handle unusual debugging option combinations.
4763 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4764 since the two debugging options are incompatible.
4765 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4766 is defined.
4767 (mem_init, mem_insert, mem_insert_fixup):
4768 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4769 (NEED_MEM_INSERT): Remove; no longer needed.
4770
f01769f9
LL
47712012-04-22 Leo Liu <sdl.web@gmail.com>
4772
4773 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4774
5790543d
PE
47752012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4776
4777 * sysdep.c [__FreeBSD__]: Minor cleanups.
4778 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4779 Use Emacs indenting style more consistently. Avoid some casts.
4780 Use 'double' consistently rather than mixing 'float' and 'double'.
4781
b91b7e4d
EW
47822012-04-21 Eduard Wiebe <usenet@pusto.de>
4783
b593d6a9
AH
4784 * sysdep.c (list_system_processes, system_process_attributes):
4785 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4786
6114eb15
AS
47872012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4788
4789 * lisp.mk (lisp): Update.
4790
2f38dff7
PE
47912012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4792
4793 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4794 It is never used otherwise.
4795
4ae29f89
SM
47962012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4797
4798 * print.c (print_preprocess): Only check print_depth if print-circle
4799 is nil.
4800 (print_object): Check for cycles even when print-circle is nil and
4801 print-gensym is t, but only check print_depth if print-circle is nil.
4802
f30d612a
CY
48032012-04-20 Chong Yidong <cyd@gnu.org>
4804
4805 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4806 set the status to "failed" and ensure that sentinel is run.
4807
c07a4c0b 48082012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4809
4810 * process.c (Fset_process_inherit_coding_system_flag)
4811 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4812 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4813
c07a4c0b 48142012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4815
4816 * xdisp.c (string_buffer_position_lim): Limit starting position to
4817 BEGV.
4818 (set_cursor_from_row): If called for a mode-line or header-line
4819 row, return zero immediately.
4820 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4821 farther than the first row after the header line, if any.
4822 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4823 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4824
c07a4c0b 48252012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4826
4ae29f89
SM
4827 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4828 (bug#11238).
ad3a2b41 4829
c07a4c0b 48302012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 48312012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4832
4833 configure: new option --enable-gcc-warnings (Bug#11207)
4834 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4835 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4836 (ALL_CFLAGS): Use new macros rather than old.
4837 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4838 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4839 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4840 -Wunused-result, -Wunused-variable. This should go away once
4841 the Emacs and Gnulib regex code is merged.
4842 (xmalloc, xrealloc): Now static.
4843
aba027e8
PE
48442012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4845
4846 * dired.c (Fsystem_groups): Remove unused local.
4847
e5a36063
GM
48482012-04-17 Glenn Morris <rgm@gnu.org>
4849
4850 * dired.c (Fsystem_users): Doc fix.
4851
316411f0
DA
48522012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4853
4854 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4855 (syms_of_dired): Add them.
4856
9426aba4
PE
48572012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4858
b62a57be
PE
4859 Fix minor alloc.c problems found by static checking.
4860 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4861 New extern decls, to avoid calling undeclared functions.
4862 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4863 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4864 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4865 (NEED_MEM_INSERT): New macro.
4866 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4867 Remove one incorrect comment and fix another.
b62a57be 4868
3539f31f
PE
4869 Fix minor ralloc.c problems found by static checking.
4870 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4871 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4872 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4873 (r_alloc_sbrk): Now static.
4874
a041960a
PE
4875 Improve ralloc.c interface checking.
4876 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4877 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4878 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4879 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4880 [REL_ALLOC]: ... to here, to check interface.
4881 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4882 Remove decls. This fixes an "It stinks!".
4883
9426aba4
PE
4884 * alloc.c (which_symbols): Fix alignment issue / type clash.
4885
d55c12ed
AS
48862012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4887
4888 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4889 (struct Lisp_Misc_Any): Likewise.
4890 (struct Lisp_Free): Likewise.
4891 * alloc.c (union aligned_Lisp_Symbol): Define.
4892 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4893 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4894 (union aligned_Lisp_Misc): Define.
4895 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4896 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4897 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4898
b948ce8b
PE
48992012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4900
4901 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4902 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4903 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4904 * s/netbsd.h, s/sol2-6.h:
4905 Remove definition of GC_MARK_STACK, since the default now works.
4906 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4907 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4908 no longer the default.
4909 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4910
35dc09a1 49112012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4912
35dc09a1
GM
4913 * lread.c (lisp_file_lexically_bound_p):
4914 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4915
35dc09a1
GM
49162012-04-14 Eli Zaretskii <eliz@gnu.org>
4917
4918 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4919 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4920
49212012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4922
4923 * nsterm.m (constrainFrameRect): Always constrain when there is only
4924 one screen (Bug#10962).
4925
bcd86815
KB
49262012-04-13 Ken Brown <kbrown@cornell.edu>
4927
4928 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4929
c25df26e
RT
49302012-04-13 Reuben Thomas <rrt@sc3d.org>
4931
4932 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4933
0fc59f1e
DC
49342012-04-11 Daniel Colascione <dancol@dancol.org>
4935
4936 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4937 against is gone. It's better to use vfork now so that when Cygwin
4938 gains a new, working vfork, we use it automatically (bug#10398).
4939
de8c03dc
SM
49402012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4941
4942 * window.c (save_window_save): Obey window-point-insertion-type.
4943
2f097256
GM
49442012-04-11 Glenn Morris <rgm@gnu.org>
4945
4946 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4947
453b951e
SM
49482012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4949
4950 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4951
75f1671a 49522012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4953
4954 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4955 (force_quit_count): New var.
4956 (handle_interrupt): Use it.
4957
2a8ce227
JB
49582012-04-10 Juanma Barranquero <lekktu@gmail.com>
4959
4960 * w32.c (w32_delayed_load): Record the full path of the library
4961 being loaded (bug#10424).
4962
935396c0
GM
49632012-04-09 Glenn Morris <rgm@gnu.org>
4964
05920a43
GM
4965 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4966 not just in the obarray, before snarfing them. (Bug#11036)
4967
935396c0
GM
4968 * Makefile.in ($(leimdir)/leim-list.el):
4969 Pass EMACS rather than BUILT_EMACS.
4970
a18ecafa
TZ
49712012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4972
4973 * process.c (make_process):
4974 * process.h: Add integer `gnutls_handshakes_tried' member to
4975 process struct.
4976
6bbef4e5
JC
4977 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4978 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4979
4980 * gnutls.c (gnutls_log_function2i): Convenience log function.
4981 (emacs_gnutls_read): Use new log functions,
4982 `gnutls_handshakes_tried' process member, and
4983 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4984 attempts per process (connection).
4985
b4d3bc10
CY
49862012-04-09 Chong Yidong <cyd@gnu.org>
4987
4988 * eval.c (Fuser_variable_p, user_variable_p_eh)
4989 (lisp_indirect_variable): Functions deleted.
4990 (Fdefvar): Caller changed.
4991
4992 * callint.c (Finteractive, Fcall_interactively):
4993 * minibuf.c (Fread_variable): Callers changed.
4994
70f4d973
EZ
49952012-04-09 Eli Zaretskii <eliz@gnu.org>
4996
4997 * xdisp.c (set_cursor_from_row): If the display string appears in
4998 the buffer at position that is closer to point than the position
4999 after the display string, display the cursor on the first glyph of
5000 the display string. Fixes cursor display when a 'display' text
5001 property immediately follows invisible text. (Bug#11094)
5002
cb3c2e3e
PE
50032012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5004
5005 composite.c: use 'double' consistently
5006 * composite.c (get_composition_id): Use 'double' consistently
5007 instead of converting 'float' to 'double' and vice versa; this is
5008 easier to understand and avoids a GCC warning.
5009
fd06db5d
GM
50102012-04-09 Glenn Morris <rgm@gnu.org>
5011
50fe702a
GM
5012 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5013 preparation for dumping it with emacs. (Bug#4789)
5014 (leimdir): New variable.
5015 ($(leimdir)/leim-list.el): New rule.
5016 (emacs$(EXEEXT)): Depend on leim-list.el.
5017
fd06db5d
GM
5018 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5019 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5020 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5021
55c131ee
AS
50222012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5023
5024 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5025 proper alignment.
5026
9209588f
JB
50272012-04-07 Juanma Barranquero <lekktu@gmail.com>
5028
5029 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5030 Remove unused local variable.
5031
e3fb2efb
PE
50322012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5033
5034 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5035 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5036 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5037 objects, as mark_maybe_pointer will catch them otherwise.
5038 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5039 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5040
b5385551
PE
50412012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5042
5043 Fix typo that broke non-Windows builds.
5044 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5045
9078ead6
EZ
50462012-04-07 Eli Zaretskii <eliz@gnu.org>
5047
5048 Support building on MS-Windows with libxml2.
5049
5050 * makefile.w32-in (OBJ2): Add xml.$(O).
5051 (GLOBAL_SOURCES): Add xml.c.
5052 ($(BLD)/xml.$(O)): New dependency list.
5053
5054 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5055 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5056 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5057 [!WINDOWSNT]: New macros.
5058 (init_libxml2_functions, libxml2_loaded_p): New functions.
5059 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5060 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5061 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5062 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5063 linked in).
6bbef4e5
JC
5064 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5065 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5066 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5067
5068 * emacs.c: Don't include libxml/parser.h.
5069 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5070 xmlCleanupParser directly.
5071
5072 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5073
3811fdf3
EZ
50742012-04-07 Eli Zaretskii <eliz@gnu.org>
5075
5076 * indent.c (Fvertical_motion): If there is a display string at
5077 point, use it.vpos to compute how many lines to backtrack after
5078 move_it_to point. (Bug#11133)
5079
2f8e16b2
EZ
50802012-04-06 Eli Zaretskii <eliz@gnu.org>
5081
5082 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5083 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5084 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5085 macros related to unification of CJK characters. For the details,
5086 see the discussion following the message here:
5087 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5088
3d439cd1
CY
50892012-04-04 Chong Yidong <cyd@gnu.org>
5090
5091 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5092
8bc53d00
EZ
50932012-04-01 Eli Zaretskii <eliz@gnu.org>
5094
5095 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5096 instead of alloca. (Bug#11138)
5097
3b0512a3
AS
50982012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5099
5100 * w32menu.c (is_simple_dialog): Properly check lisp types.
5101 (Bug#11141)
5102
8427ddd2
EZ
51032012-03-31 Eli Zaretskii <eliz@gnu.org>
5104
979022ef
EZ
5105 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5106 position we get to after a call to move_it_to fails the
5107 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5108 only if we wind up in a string from display property. (Bug#11063)
5109
a6b1c7cc
EZ
5110 * window.c (Fdelete_other_windows_internal): Invalidate the row
5111 and column information about mouse highlight, so that redisplay
5112 restores it after reallocating the glyph matrices. (Bug#7464)
5113
8427ddd2
EZ
5114 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5115 string comes from a `display' text property, use the buffer
5116 position of that property as if we actually saw that position in
5117 the row's glyphs.
697ba24b
EZ
5118 (move_it_by_lines): Remove the assertion that
5119 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5120 violated when there's a before-string at the beginning of a line.
5121 (Bug#11063)
8427ddd2 5122
65a0a738
EZ
51232012-03-30 Eli Zaretskii <eliz@gnu.org>
5124
5125 * xdisp.c (append_space_for_newline): If the default face was
5126 remapped, use the remapped face for the appended newline.
5127 (extend_face_to_end_of_line): Use the remapped default face for
5128 extending the face to the end of the line.
5129 (display_line): Call extend_face_to_end_of_line when the default
5130 face was remapped. (Bug#11068)
5131
581355cc
EZ
51322012-03-29 Eli Zaretskii <eliz@gnu.org>
5133
5134 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5135
e8fc049f
SM
51362012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5137
5138 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5139
4fb9a543
GM
51402012-03-27 Glenn Morris <rgm@gnu.org>
5141
5142 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5143 Doc fixes.
5144
679910f1
KH
51452012-03-26 Kenichi Handa <handa@m17n.org>
5146
5147 * dispextern.h (struct glyph): Fix previous change. Change the
5148 bit length of glyphless.ch to 25 (Bug#11082).
5149
90d49b7f
CY
51502012-03-26 Chong Yidong <cyd@gnu.org>
5151
5152 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5153 (command_loop_1): Use it; inhibit selection update for
5154 handle-select-window too (Bug#8996).
5155
f514f6f0
FP
51562012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5157
e8fc049f 5158 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5159
bf43fa51
KH
51602012-03-25 Kenichi Handa <handa@m17n.org>
5161
5162 * dispextern.h (struct glyph): Change the bit length of
5163 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5164
8a0c01dd
EZ
51652012-03-24 Eli Zaretskii <eliz@gnu.org>
5166
5167 * s/ms-w32.h (tzname): Include time.h before redirecting to
5168 _tzname. Fixes the MSVC build. (Bug#9960)
5169
7d1c3a76
AS
51702012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5171
8ed79523
AS
5172 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5173 characters.
5174
7d1c3a76
AS
5175 * xterm.c (XTread_socket): Only modify handling_signal if
5176 !SYNC_INPUT. (Bug#11080)
5177
e99a9b8b
EZ
51782012-03-23 Eli Zaretskii <eliz@gnu.org>
5179
5180 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5181 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5182 when fetching a multibyte character consumes more bytes than
5183 CHAR_BYTES returns, due to unification of CJK characters in
5184 string_char. (Bug#11073)
5185
5063c0e1
TN
51862012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5187
5188 * process.c (wait_reading_process_output): Handle pty disconnect
5189 by refraining from sending oneself a SIGCHLD (bug#10933).
5190
9f851fbd
CY
51912012-03-22 Chong Yidong <cyd@gnu.org>
5192
5193 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5194
5063c0e1 5195 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5196 Mark string as coming from a prefix property.
5197 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5198 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5199
fb5b8aca
CY
52002012-03-21 Chong Yidong <cyd@gnu.org>
5201
5202 * xfaces.c (Vface_remapping_alist): Doc fix.
5203
62356a1b
EZ
52042012-03-20 Eli Zaretskii <eliz@gnu.org>
5205
5206 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5207 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5208 Doc fixes.
62356a1b 5209
025de85b
CY
52102012-03-20 Chong Yidong <cyd@gnu.org>
5211
5212 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5213 to reflect default non-nil value of redisplay-dont-pause.
5214
4827f94e
KH
52152012-03-19 Kenichi Handa <handa@m17n.org>
5216
5217 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5218 it fit in a valid range (Bug#11003).
5219
e50a24a2
EZ
52202012-03-18 Eli Zaretskii <eliz@gnu.org>
5221
5222 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5223 that is not from display property, accept the row as a "cursor
5224 row" if one of the string's character has a non-nil `cursor'
5225 property. Fixes cursor positioning when there are newlines in
5226 overlay strings, e.g. in icomplete.el. (Bug#11035)
5227
9af5ed87
PE
52282012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5229
5230 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5231
d1f55f16
CY
52322012-03-12 Chong Yidong <cyd@gnu.org>
5233
5234 * eval.c (inhibit_lisp_code): Rename from
5235 inhibit_window_configuration_change_hook; move from window.c.
5236
5237 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5238 * window.c (run_window_configuration_change_hook)
5239 (syms_of_window): Callers changed.
5240
66c5eebd
CY
52412012-03-11 Chong Yidong <cyd@gnu.org>
5242
413df973
CY
5243 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5244
66c5eebd
CY
5245 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5246
1de11f56
CY
52472012-03-10 Chong Yidong <cyd@gnu.org>
5248
5249 * frame.c (other_visible_frames): Don't assume the selected frame
5250 is visible (Bug#10955).
5251
cae07000
SM
52522012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5253
5254 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5255
89c94350
JD
52562012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5257
5258 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5259 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5260 zero (Bug#10954).
5261
999dd333
GM
52622012-03-03 Glenn Morris <rgm@gnu.org>
5263
01a6dcc8 5264 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5265
de0100f2
EZ
52662012-03-02 Eli Zaretskii <eliz@gnu.org>
5267
5268 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5269 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5270 (redisplay_window, next_element_from_string): Fix typos in
5271 comments.
3e441275
EZ
5272 (redisplay_window): Pass to move_it_vertically the margin in
5273 pixels, not in screen lines.
de0100f2 5274
96a72ee9
GM
52752012-03-02 Glenn Morris <rgm@gnu.org>
5276
5277 * buffer.c (buffer-list-update-hook): Doc fix.
5278
312508d7
EZ
52792012-02-29 Eli Zaretskii <eliz@gnu.org>
5280
5281 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5282 push_it before setting up the iterator for the first overlay
5283 string, even if we have an empty string loaded.
5284 (next_overlay_string): If there's an empty string on the iterator
5285 stack, pop the stack. (Bug#10903)
5286
27f3c637
PE
52872012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5288
5289 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5290 Suggested by Stefan Monnier in
5291 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5292 * alloc.c (widen_to_Lisp_Object): New static function.
5293 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5294 and widening them to Lisp_Objects. This would work even if
5295 USE_LSB_TAG is defined and wide integers are used, which might
5296 happen in a future version of Emacs.
5297
3c9dfce6
CY
52982012-02-25 Chong Yidong <cyd@gnu.org>
5299
fa74b241
CY
5300 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5301 Doc fix.
5302
3c9dfce6
CY
5303 * xselect.c (Fx_selection_exists_p): Doc fix.
5304 (x_clipboard_manager_save_all): Print an informative message
5305 before saving to clipboard manager.
5306
9486df08
CY
53072012-02-24 Chong Yidong <cyd@gnu.org>
5308
5309 * keyboard.c (process_special_events): Handle all X selection
5310 requests in kbd_buffer, not just the next one (Bug#8869).
5311
f01d3321
CY
53122012-02-23 Chong Yidong <cyd@gnu.org>
5313
5314 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5315 call when setting menu-bar-lines and tool-bar-lines parameters.
5316 (unwind_create_frame_1): New helper function.
5317
5318 * window.c (inhibit_window_configuration_change_hook): New var.
5319 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5320 (syms_of_window): Initialize it.
f01d3321 5321
86b847b6
CY
53222012-02-22 Chong Yidong <cyd@gnu.org>
5323
5324 * xterm.c (x_draw_image_relief): Add missing type check for
5325 Vtool_bar_button_margin (Bug#10743).
5326
a59225b1
CY
53272012-02-21 Chong Yidong <cyd@gnu.org>
5328
5329 * fileio.c (Vfile_name_handler_alist): Doc fix.
5330
5331 * buffer.c (Fget_file_buffer): Protect against invalid file
5332 handler return value.
5333
310f5bd4
PE
53342012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5335
cb3a28cc
PE
5336 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5337 when computing $valmask.
5338
310f5bd4
PE
5339 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5340 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5341 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5342 It's useless in that case, and it can cause problems on hosts
5343 that allocate halves of EMACS_INT values separately.
5344 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5345 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5346 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5347 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5348 it avoids undefined behavior on hosts where shifting right by more
5349 than the word width has undefined behavior.
5350
2375c96a
CY
53512012-02-19 Chong Yidong <cyd@gnu.org>
5352
5353 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5354 (Funhandled_file_name_directory, Ffile_name_as_directory)
5355 (Fdirectory_file_name, Fexpand_file_name)
5356 (Fsubstitute_in_file_name): Protect against invalid file handler
5357 return values (Bug#10845).
5358
3eb49e71
EZ
53592012-02-18 Eli Zaretskii <eliz@gnu.org>
5360
5361 * .gdbinit (pitx): Fix incorrect references to fields of the
5362 iterator stack.
5363
7b926f3f
CY
53642012-02-17 Chong Yidong <cyd@gnu.org>
5365
5366 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5367
11273115
PE
53682012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5369
5370 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5371 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5372
c3a70e2b
CY
53732012-02-15 Chong Yidong <cyd@gnu.org>
5374
5375 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5376 marked as special. Also, starting docstrings with * is obsolete.
5377
0ca43699
AS
53782012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5379
5380 * gnutls.c (emacs_gnutls_write): Fix last change.
5381
2e8f3c56
LI
53822012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5383
5384 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5385 send_process.
5386
af70074f
SM
53872012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5388
5389 * keymap.c (Fsingle_key_description): Handle char ranges.
5390
95986d52
CY
53912012-02-12 Chong Yidong <cyd@gnu.org>
5392
afd83bd1
CY
5393 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5394 as that creates a dangerous corner case.
5395
95986d52
CY
5396 * window.c (Fdelete_window_internal): Invalidate the mouse
5397 highlight (Bug#9904).
5398
bd7da63e
GM
53992012-02-12 Glenn Morris <rgm@gnu.org>
5400
5401 * xselect.c (Fx_own_selection_internal)
5402 (Fx_get_selection_internal, Fx_disown_selection_internal)
5403 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5404 * nsselect.m (Fx_own_selection_internal)
5405 (Fx_disown_selection_internal, Fx_selection_exists_p)
5406 (Fx_selection_owner_p, Fx_get_selection_internal):
5407 Sync docs and argument specs with the xselect.c versions.
5408
77abcbc2
LI
54092012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5410
5411 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5412
90b671e2
EZ
54132012-02-11 Eli Zaretskii <eliz@gnu.org>
5414
1c0ca0b7
EZ
5415 * w32select.c (Fx_selection_exists_p): Sync doc string and
5416 argument list with xselect.c. (Bug#10783)
5417
5418 * w16select.c (Fx_selection_exists_p): Sync doc string and
5419 argument list with xselect.c. (Bug#10783)
90b671e2 5420
49241268
GM
54212012-02-10 Glenn Morris <rgm@gnu.org>
5422
5423 * fns.c (Fsecure_hash): Doc fix.
5424
f998bbe7 54252012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5426
5427 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5428
0992bd9c
CY
54292012-02-07 Chong Yidong <cyd@gnu.org>
5430
5431 * buffer.c (Fbuffer_local_variables)
5432 (buffer_lisp_local_variables): Handle unbound vars correctly;
5433 don't let Qunbound leak into Lisp.
5434
af008560
GM
54352012-02-07 Glenn Morris <rgm@gnu.org>
5436
dd605cc4
GM
5437 * image.c (Fimagemagick_types): Doc fix.
5438
af008560
GM
5439 * image.c (imagemagick-render-type): Change it from a lisp object
5440 to an integer. Move the doc here from the lisp manual.
5441 Treat all values not equal to 0 the same.
5442
1449fa1d
CY
54432012-02-06 Chong Yidong <cyd@gnu.org>
5444
5445 * doc.c (store_function_docstring): Avoid applying docstring of
5446 alias to base function (Bug#2603).
5447
3723ec07
AS
54482012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5449
5450 * .gdbinit (pp1, pv1): Remove redundant defines.
5451 (pr): Use pp.
5452
79c1cc1e
CY
54532012-02-04 Chong Yidong <cyd@gnu.org>
5454
5455 * nsterm.m: Declare a global (Bug#10694).
5456
d7f29f8e
EZ
54572012-02-04 Eli Zaretskii <eliz@gnu.org>
5458
cae07000
SM
5459 * w32.c (get_emacs_configuration_options):
5460 Include --enable-checking, if specified, in the return value.
d7f29f8e 5461
3b95a6f9
MR
54622012-02-04 Martin Rudalics <rudalics@gmx.at>
5463
5464 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5465 after rounding frame sizes. (Bug#9723)
5466
d6fa96a6
EZ
54672012-02-04 Eli Zaretskii <eliz@gnu.org>
5468
5469 * keyboard.c (adjust_point_for_property): Don't position point
5470 before BEGV. (Bug#10696)
5471
df0b2940
PE
54722012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5473
5474 Handle overflow when computing char display width (Bug#9496).
5475 * character.c (char_width): Return EMACS_INT, not int.
5476 (char_width, c_string_width): Check for overflow when
5477 computing the width; this is possible now that individual
5478 characters can have unbounded width. Problem introduced
5479 by merge from Emacs 23 on 2012-01-19.
5480
6bee44d6
MA
54812012-02-02 Michael Albinus <michael.albinus@gmx.de>
5482
5483 * dbusbind.c (Fdbus_register_method): Mention the return value
5484 :ignore in the docstring.
5485
44f92739
GM
54862012-02-02 Glenn Morris <rgm@gnu.org>
5487
1b9f60cc
GM
5488 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5489
44f92739
GM
5490 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5491 Unconditionally set to t. (Bug#10673)
5492 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5493 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5494 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5495
c5d3843c
KH
54962012-02-02 Kenichi Handa <handa@m17n.org>
5497
5498 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5499 0, do not call append_composite_glyph.
5500
159462d4 55012012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5502
5503 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5504 NULL (Bug#6988).
5505 (x_produce_glyphs): If the component of a composition is a null
5506 string, set it->pixel_width to 1 to avoid zero-width glyph.
5507
78cef877
EZ
55082012-02-01 Eli Zaretskii <eliz@gnu.org>
5509
5510 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5511 first 2 arguments are identical. This makes inserting large
5512 output from a subprocess an order of magnitude faster on
5513 MS-Windows, where all sbrk'ed memory is always contiguous.
5514
97897668
GM
55152012-01-31 Glenn Morris <rgm@gnu.org>
5516
5517 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5518 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5519 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5520
31fd3586
GM
55212012-01-29 Glenn Morris <rgm@gnu.org>
5522
5523 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5524
0e24a8b2
CY
55252012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5526
5527 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5528
cc0adcb0
CY
55292012-01-28 Chong Yidong <cyd@gnu.org>
5530
5531 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5532
acc28cb9
CY
55332012-01-26 Chong Yidong <cyd@gnu.org>
5534
9c69cfb7
CY
5535 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5536
acc28cb9
CY
5537 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5538 repeat counts (Bug#10507).
5539
48da7392
GM
55402012-01-26 Glenn Morris <rgm@gnu.org>
5541
5542 * lread.c (syms_of_lread): Doc fix.
5543
14af5f7f
CY
55442012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5545
5546 * coding.c (encode_designation_at_bol): Change return value to
5547 EMACS_INT.
5548
0b21c100
CY
55492012-01-25 Chong Yidong <cyd@gnu.org>
5550
5551 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5552
3c2907f7
CY
55532012-01-21 Chong Yidong <cyd@gnu.org>
5554
5555 * floatfns.c (Fcopysign): Make the second argument non-optional,
5556 since nil is not allowed anyway.
5557
959ad23f
AS
55582012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5559
5560 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5561 (send_process): Likewise.
5562
34a02f46
MR
55632012-01-19 Martin Rudalics <rudalics@gmx.at>
5564
5565 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5566 (Vwindow_persistent_parameters): Do not use Qstate.
5567 Rewrite doc-strings.
34a02f46 5568
1259009a 55692012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5570
5571 * character.c (char_width): New function.
70d4fdf6
GM
5572 (Fchar_width, c_string_width, lisp_string_width):
5573 Use char_width (Bug#9496).
25ed9e61 5574
6a6ee00d
MR
55752012-01-16 Martin Rudalics <rudalics@gmx.at>
5576
5577 * window.c (Vwindow_persistent_parameters): New variable.
5578 (Fset_window_configuration, save_window_save): Handle persistent
5579 window parameters.
5580
c85efaf7
EZ
55812012-01-14 Eli Zaretskii <eliz@gnu.org>
5582
5583 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5584 thrashing the stack of the thread. (Bug#9087)
5585
5944709e
PE
55862012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5587
5588 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5589
e71f5d99
EZ
55902012-01-11 Eli Zaretskii <eliz@gnu.org>
5591
5592 * xdisp.c (rows_from_pos_range): Handle the case where the
5593 highlight ends on a newline. (Bug#10464)
5594 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5595 he end column for display of highlight that ends on a newline
5596 before a R2L line.
5597
ce316182
GM
55982012-01-11 Glenn Morris <rgm@gnu.org>
5599
5600 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5601 from load-path also when installation-directory is nil. (Bug#10208)
5602
5b43da69
GM
56032012-01-10 Glenn Morris <rgm@gnu.org>
5604
74cc8ff9
GM
5605 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5606
7d8d6e4e
GM
5607 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5608 Update template values to be closer to their typical values these days.
5b43da69 5609
a0db8d43
EZ
56102012-01-09 Eli Zaretskii <eliz@gnu.org>
5611
5612 * xdisp.c (rows_from_pos_range): Accept additional argument
5613 DISP_STRING, and accept any glyph in a row whose object is that
5614 string as eligible for mouse highlight. Fixes mouse highlight of
5615 display strings from overlays. (Bug#10464)
5616
9a0115ab 56172012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5618
b9110d6a 5619 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5620 * fileio.c (auto_saving_dir_umask): New static var.
5621 (Fmake_directory_internal): Use it.
5622 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5623 creating the directory. The old code temporarily assigns
5624 too-generous permissions to the directory.
5625 (do_auto_save_eh): Clear it.
b9110d6a 5626 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5627 that the var is always cleared.
5628
6c1bd3f3
EZ
56292012-01-07 Eli Zaretskii <eliz@gnu.org>
5630
5631 * search.c (scan_buffer): Pass character positions to
5632 know_region_cache, not byte positions. (Bug#6540)
5633
069d2b50
L
56342012-01-07 LynX <_LynX@bk.ru> (tiny change)
5635
5636 * w32.c (sys_rename): Report EXDEV when rename of a directory
5637 fails because the target is on another logical disk. (Bug#10284)
5638
75bf0d33
DB
56392012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5640
5641 * xterm.c (x_embed_request_focus): New function.
5642
5643 * xterm.h: Add prototype.
5644
5645 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5646
1c6e5a32
GM
56472012-01-05 Glenn Morris <rgm@gnu.org>
5648
5649 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5650
651e947e
EZ
56512012-01-01 Eli Zaretskii <eliz@gnu.org>
5652
5653 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5654 Load gnutls_transport_set_lowat only if GnuTLS version is below
5655 2.11.1.
5656 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5657 GnuTLS versions below 2.11.1.
5658
3778cdd8
AL
56592011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5660
5661 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5662 to the doc string advising against its use for altering the way
5663 windows are scrolled.
5664
0e5317f7
KH
56652011-12-28 Kenichi Handa <handa@m17n.org>
5666
5667 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5668 coding-system ASCII compatible only when it does not produce BOM
5669 on encoding (Bug#10383).
5670
93d5ca1f
JD
56712011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5672
5673 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5674 can scroll.
5675 (create_and_show_popup_menu): Always use menu_position_func for
5676 Gtk3 (Bug#10361).
5677
ca22b785
AS
56782011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5679
5680 * callint.c (Fcall_interactively): Don't truncate prompt string.
5681
d048e1e6
EZ
56822011-12-23 Eli Zaretskii <eliz@gnu.org>
5683
5684 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5685 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5686 resumed from there (after widening). (Bug#10360)
d048e1e6 5687
5ccaba1f
JD
56882011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5689
5690 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5691
204ee57f
JD
56922011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5693
b81d40f0
JB
5694 * nsterm.m (x_free_frame_resources):
5695 Release f->output_data.ns->miniimage.
204ee57f
JD
5696 (ns_index_color): Fix indentation. Do not retain
5697 color_table->colors[i].
5698
5699 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5700 before returning.
5701
5702 * nsfns.m (x_set_background_color): Assign return value from
5703 ns_index_color to face-background instead of NSColor*.
5704 (ns_implicitly_set_icon_type): Fix indentation.
5705 Change assignment in for loop to comparison.
5706
5707 * emacs.c (ns_pool): New variable.
5708 (main): Assign ns_pool.
5709 (Fkill_emacs): Call ns_release_autorelease_pool.
5710
5711 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5712 autorelease fdesc, release fdAttrs and tdict.
5713 (ns_get_covering_families): Release charset.
5714 (ns_findfonts): Release NSFontDescriptor created with new.
5715 (ns_uni_to_glyphs): Fix indentation.
5716 (setString): Release attrStr before assigning new value.
5717
c803b2b7
JD
57182011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5719
678f4426
JD
5720 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5721 and NS_IMPL_COCOA.
5722 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5723 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5724
cd394be1 57252011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5726
5fecd5fc
JD
5727 * nsterm.m (ns_term_init): Subscribe for notifications
5728 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5729 to method trackingNotification in EmacsMenu.
5730
5731 * nsmenu.m (trackingMenu): New variable.
3771cb17 5732 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5733 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5734 from Aquamacs (Bug#7030).
678f4426
JD
5735
57362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5737
c803b2b7
JD
5738 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5739 (symbol_to_nsstring): Fix indentation.
5740 (ns_symbol_to_pb): New function.
cae07000
SM
5741 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5742 (Fns_rotate_cut_buffers_internal): Remove.
5743 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5744 Fns_store_cut_buffer_internal.
5745 (ns_get_foreign_selection, Fx_own_selection_internal)
5746 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5747 (Fns_get_selection_internal, Fns_store_selection_internal):
5748 Use ns_symbol_to_pb and check if return value is nil.
5749 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5750 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5751 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5752 renamed to Sns_store_selection_internal.
5753 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5754 and remove this function.
5755 (ns_handle_selection_clear): Remove, never used.
5756 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5757 here.
5758
e1b01a3a
KB
57592011-12-17 Ken Brown <kbrown@cornell.edu>
5760
5761 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5762 GID is unknown (Bug#10257).
5763
2adb6e85
PE
57642011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5765
5766 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5767 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5768 which caused a build failure on GNU/Linux IA-64. This problem was
5769 introduced by my 2011-10-07 patch.
5770
d1d7b339
JL
57712011-12-15 Juri Linkov <juri@jurta.org>
5772
5773 * image.c (imagemagick_error): New function. (Bug#10112)
5774 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5775 Use `imagemagick_error' where ImageMagick functions return
5776 `MagickFalse'.
5777 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5778 proper order.
5779
100d5755
KH
57802011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5781
5782 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5783 fill background (Bug#8992).
5784
454592a6
MR
57852011-12-13 Martin Rudalics <rudalics@gmx.at>
5786
5787 * window.c (Vwindow_combination_resize)
5788 (Vwindow_combination_limit): Use t instead of non-nil in
5789 doc-strings.
61d4b438
MR
5790 (Vrecenter_redisplay): Add first sentence of doc-string on
5791 separate line.
53524d93 5792 (Frecenter): Fix doc-string typo.
454592a6 5793
3633e3aa
KH
57942011-12-11 Kenichi Handa <handa@m17n.org>
5795
5796 * coding.c (Funencodable_char_position): Pay attention to the
5797 buffer text relocation (Bug#9389).
5798
7b9d523a 57992011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5800
7b9d523a
JD
5801 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5802 gtk_init (Bug#10100).
5803
b73189c6
EZ
58042011-12-10 Eli Zaretskii <eliz@gnu.org>
5805
5806 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5807 IT->string is nil. (Bug#10263)
5808
f7dfe5d6
JD
58092011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5810
83faebb4
JD
5811 * nsterm.h (x_free_frame_resources): Declare.
5812
f7dfe5d6
JD
5813 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5814 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5815
5816 * nsterm.h (ns_get_defaults_value): Declare.
5817
5818 * nsterm.m (ns_default): Call ns_get_defaults_value.
5819
7cd4e72c
EZ
58202011-12-09 Eli Zaretskii <eliz@gnu.org>
5821
5822 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5823 (Bug#10170)
5824
b34d7317
YM
58252011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5826
5827 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5828 that where the value of an _OBJC_* symbol points to is in the .bss
5829 section (Bug#10240).
5830
76470ad1
KH
58312011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5832
5833 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5834 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5835
745fff94
KH
58362011-12-08 Kenichi Handa <handa@m17n.org>
5837
5838 * ftfont.c (get_adstyle_property): Fix previous change
5839 (Bug#10233).
5840
6e44397c
JB
58412011-12-07 Juanma Barranquero <lekktu@gmail.com>
5842
5843 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5844 dirs from the default value of EMACSLOADPATH (bug#10208).
5845
7efa6272
GM
58462011-12-07 Glenn Morris <rgm@gnu.org>
5847
5848 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5849 installation and source directories as well. (Bug#10208)
5850
f6fc4d87
CY
58512011-12-06 Chong Yidong <cyd@gnu.org>
5852
5853 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5854
2bf26180
GM
58552011-12-06 Glenn Morris <rgm@gnu.org>
5856
5857 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5858 as an error, not just -1. (Bug#10217)
5859
3a6ad4f0
CY
58602011-12-05 Chong Yidong <cyd@gnu.org>
5861
5862 * keyboard.c (process_special_events): New function.
5863 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5864
75a3b399
PE
58652011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5866
5867 * coding.c (encode_designation_at_bol): Don't use uninitialized
5868 local variable (Bug#9318).
5869
c3c9e25e
KH
58702011-12-05 Kenichi Handa <handa@m17n.org>
5871
5872 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5873 return Qnil (Bug#8046, Bug#10193).
5874
5eb05ea3
KH
58752011-12-05 Kenichi Handa <handa@m17n.org>
5876
5877 * coding.c (encode_designation_at_bol): New args charbuf_end and
5878 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5879 (coding_set_source): Return how many bytes coding->source was
5880 relocated.
5881 (coding_set_destination): Return how many bytes
5882 coding->destination was relocated.
5883 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5884 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5885
58862011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5887
5888 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5889 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5890 macro (Bug#9318).
5891
58922011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5893
5894 The following changes are to fix Bug#9318.
5895
a79703f5 5896 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5897 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5898 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5899 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5900
7dbda6df
JB
59012011-12-05 Juanma Barranquero <lekktu@gmail.com>
5902
5903 * lisp.h (process_quit_flag): Fix external declaration.
5904
6d5eb5b0
SM
59052011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5906
5907 Don't macro-inline non-performance-critical code.
5908 * eval.c (process_quit_flag): New function.
5909 * lisp.h (QUIT): Use it.
5910
a0c3fad0
JD
59112011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5912
5913 * nsfns.m (get_geometry_from_preferences): New function.
5914 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5915
6c07aac2
AS
59162011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5917
5918 * emacs.c (Qkill_emacs): Define.
5919 (syms_of_emacs): Initialize it.
5920 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5921 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5922 (quit_throw_to_read_char): Add parameter `from_signal'.
5923 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5924 * lisp.h (QUIT): Call Fkill_emacs if requested.
5925
c052ead4
JD
59262011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5927
5928 * widget.c (update_wm_hints): Return if wmshell is null.
5929 (widget_update_wm_size_hints): New function.
5930
5931 * widget.h (widget_update_wm_size_hints): Declare.
5932
5933 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5934 widget_update_wm_size_hints (Bug#10104).
5935
9e49252b
EZ
59362011-12-03 Eli Zaretskii <eliz@gnu.org>
5937
5938 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5939 before a newline, prepare the bidi iterator for consuming the
5940 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5941 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5942
02b16839
JL
59432011-12-02 Juri Linkov <juri@jurta.org>
5944
5945 * search.c (Fword_search_regexp): New Lisp function created from
5946 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5947 (Fword_search_backward, Fword_search_forward)
5948 (Fword_search_backward_lax, Fword_search_forward_lax):
5949 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5950 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5951
0068070e
SM
59522011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5953
5954 * fileio.c (Finsert_file_contents): Move after-change-function call
5955 to before the "handled:" label, since all "goto handled" appear in
5956 cases where the *-change-functions have already been properly called
5957 (bug#10117).
5958
3360a3fc
AS
59592011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5960
5961 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5962 waiting for input. (Bug#10169)
5963
73d6c093
EZ
59642011-11-30 Eli Zaretskii <eliz@gnu.org>
5965
5966 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5967 verifies glyph row's hash code--we have just reallocated the
5968 glyphs, so their contents can be complete garbage. (Bug#10164)
5969
febe6bea
JB
59702011-11-30 Juanma Barranquero <lekktu@gmail.com>
5971
5972 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5973
801a4313
EZ
59742011-11-30 Eli Zaretskii <eliz@gnu.org>
5975
5976 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5977 attributes are tested _before_ calling verify_row_hash, to protect
5978 against GCC re-ordering of the tests. (Bug#10164)
5979
2b56b87e
JD
59802011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5981
5982 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5983
5984 * xterm.c (handle_one_xevent): Only set async_visible and friends
5985 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5986 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5987 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5988
dbf31225
PE
59892011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5990
5991 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5992 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5993 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5994 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5995 All uses changed to use GCPRO1 etc.
5996 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5997 Revert to old implementation (i.e., before 2011-03-11).
5998
1305621b
YM
59992011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6000
6001 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6002 of scroll runs so as to avoid assigning disabled bogus rows and
6003 unnecessary graphics copy operations.
6004
8c9afb46
EZ
60052011-11-27 Eli Zaretskii <eliz@gnu.org>
6006
6007 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6008 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6009 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6010 (malloc, free, realloc, calloc): Redirect to e_* only when
6011 compiling Emacs.
6012
6013 * lisp.h (GCTYPEBITS): Move before first use.
6014 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6015 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6016 this macro definition.
6017
6018 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6019 _MSC_VER.
6020
54e9e3bf
JD
60212011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6022
6d5eb5b0
SM
6023 * gtkutil.c (xg_create_frame_widgets):
6024 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6025 present with Gtk+ 2.0.
6026
83aca1cb
PE
60272011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6028
6029 * fileio.c (Finsert_file_contents): Undo previous change; see
6030 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6031
5b76caa4
PE
60322011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6033
6034 Rename locals to avoid shadowing.
6035 * fileio.c (Finsert_file_contents):
6036 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6037 * process.c (wait_reading_process_output):
6038 Rename inner 'proc' to 'p' to avoid shadowing.
6039 Indent for consistency with usual Emacs style.
6040
8c535114
EZ
60412011-11-25 Eli Zaretskii <eliz@gnu.org>
6042
6043 * xdisp.c (redisplay_window): If cursor row is not fully visible
6044 after recentering, and scroll-conservatively is set to a large
6045 number, scroll window by a few more lines to make the cursor fully
6046 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6047 (start_display): Don't move to the next line if the display should
6048 start at a newline that is part of a display vector or an overlay
6049 string. (Bug#10119)
8c535114 6050
fa4fdb5c
JL
60512011-11-24 Juri Linkov <juri@jurta.org>
6052
6053 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6054 after the `MagickPingImage' call. (Bug#10112)
6055
90ec88df
CY
60562011-11-23 Chong Yidong <cyd@gnu.org>
6057
6058 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6059
56e2e794
MR
60602011-11-23 Martin Rudalics <rudalics@gmx.at>
6061
6062 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6063 making another buffer current. (Bug#10114)
6064
b6e64c41
GM
60652011-11-23 Glenn Morris <rgm@gnu.org>
6066
6067 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6068
6b21de18
CY
60692011-11-23 Chong Yidong <cyd@gnu.org>
6070
6071 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6072 using it (Bug#5984).
6073
b12cd789
EZ
60742011-11-22 Eli Zaretskii <eliz@gnu.org>
6075
6076 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6077 and header-lines, as they don't have one computed for them.
6078 (Bug#10098)
6079
6080 * .gdbinit (prow): Make displayed values more self-explaining.
6081 Add row's hash code.
6082
261b6fd4
LMI
60832011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6084
6085 * process.c (wait_reading_process_output): Fix asynchrounous
6086 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6087 (wait_reading_process_output): Add comment and URL.
261b6fd4 6088
e7cfd277
JD
60892011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6090
6091 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6092
a9b9b7f5
CY
60932011-11-21 Chong Yidong <cyd@gnu.org>
6094
6095 * window.c (Fnext_window, Fprevious_window): Doc fix.
6096
b0d15b4f
SM
60972011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6098
6099 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6100
fe7a3057
JB
61012011-11-20 Juanma Barranquero <lekktu@gmail.com>
6102
6103 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6104
d2999b1a
MR
61052011-11-20 Martin Rudalics <rudalics@gmx.at>
6106
6107 * window.c (Fset_window_combination_limit): Rename argument
6108 STATUS to LIMIT.
6109 (Vwindow_combination_limit): Remove "status" from doc-string.
6110
d5ff9cd0
AS
61112011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6112
6113 * m/ibms390.h: Remove.
6114 * m/ibms390x.h: Don't include "ibms390.h".
6115
a5bb9bd3
SM
61162011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6117
6118 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6119 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6120
cd1181db
JB
61212011-11-20 Juanma Barranquero <lekktu@gmail.com>
6122
6123 * casetab.c (Fset_case_table):
6124 * charset.c (Fcharset_after): Fix typos.
6125
615a3b8d 61262011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6127
17e845af
PE
6128 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6129 Otherwise, valgrind does not work on some platforms.
6130 Problem reported by Andreas Schwab in
6a0bf43d
PE
6131 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6132 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6133 is set, removing the need for VIRT_ADDRESS_VARIES.
6134 (PURE_P): Use a more-efficient implementation that needs just one
6135 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6136 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6137 to 4 (xorl, subq, cmpq, setbe).
6138 * alloc.c (pure): Always extern now, since that's the
6139 VIRT_ADDR_VARIES behavior.
6140 (PURE_POINTER_P): Use a single comparison, not two, for
6141 consistency with the new puresize.h.
6142 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6143 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6144 Remove VIRT_ADDR_VARIES no longer needed.
6145
f8fe6f96
EZ
61462011-11-19 Eli Zaretskii <eliz@gnu.org>
6147
6148 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6149 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6150 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6151 behave as if the cursor position were at the window margin.
6152
6153 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6154 and the cursor position is out of bounds, behave as if the cursor
6155 position were at the window margin. (Bug#10075)
6156
df05a53c
CY
61572011-11-18 Chong Yidong <cyd@gnu.org>
6158
6159 * window.c (Fwindow_combination_limit): Make first argument
6160 non-optional, since it is meaningless for live windows like the
6161 selected window.
61ccba97 6162
2071918e
DA
61632011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6164
6165 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6166
b50a28de
SM
61672011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6168
6169 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6170 (graft_intervals_into_buffer): Simplify.
6171
015137db
EZ
61722011-11-18 Eli Zaretskii <eliz@gnu.org>
6173
6174 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6175 hash values of the two rows.
6176 (copy_row_except_pointers): Preserve the used[] arrays and the
6177 hash values of the two rows. (Bug#10035)
68c95424 6178 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6179
6180 * xdisp.c (row_hash): New function, body extracted from
6181 compute_line_metrics.
6182 (compute_line_metrics): Call row_hash, instead of computing the
6183 hash code inline.
6184
6185 * dispnew.c (verify_row_hash): Call row_hash for computing the
6186 hash code of a row, instead of duplicating code from xdisp.c.
6187
6188 * dispextern.h (row_hash): Add prototype.
6189
a2addb04
TH
61902011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6191
6192 * frame.c (delete_frame): Don't delete the terminal when the last
6193 X frame is closed if emacs is built with GTK toolkit.
6194
df85d315
JB
61952011-11-17 Juanma Barranquero <lekktu@gmail.com>
6196
6197 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6198
a0c2d0ae
MR
61992011-11-17 Martin Rudalics <rudalics@gmx.at>
6200
6201 * window.c (Vwindow_splits): Rename to
6202 Vwindow_combination_resize. Suggested by Juri Linkov.
6203 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6204 of Vwindow_splits.
6205
58179cce
JB
62062011-11-16 Juanma Barranquero <lekktu@gmail.com>
6207
7877f373
JB
6208 * nsfns.m (Fns_font_name):
6209 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6210
b6f67890
MR
62112011-11-16 Martin Rudalics <rudalics@gmx.at>
6212
6213 * window.h (window): Rename slot "nest" to "combination_limit".
6214 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6215 (Fset_window_nest): Rename to Fset_window_combination_limit.
6216 (Vwindow_nest): Rename to Vwindow_combination_limit.
6217 (recombine_windows, make_parent_window, make_window)
6218 (Fsplit_window_internal, saved_window)
6219 (Fset_window_configuration, save_window_save): Rename all
6220 occurrences of window_nest to window_combination_limit.
6221
c7015153
JB
62222011-11-15 Juanma Barranquero <lekktu@gmail.com>
6223
6224 * image.c (imagemagick_load_image): Fix typo.
6225
322ad6ec
EZ
62262011-11-14 Eli Zaretskii <eliz@gnu.org>
6227
6228 * xdisp.c (display_line): Move the call to
6229 highlight_trailing_whitespace before the call to
6230 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6231 faces of all the glyphs to compute ROW's hash value.
6232 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6233
f067b8ec
JB
62342011-11-14 Juanma Barranquero <lekktu@gmail.com>
6235
6236 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6237 just return (bug#10044).
6238
1e5b2111
EZ
62392011-11-12 Eli Zaretskii <eliz@gnu.org>
6240
7ef3cbd5
EZ
6241 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6242 with user-defined heap size. Bump the default size of the temacs
6243 heap to 27MB, to avoid memory warning when running temacs.
6244 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6245
1e5b2111
EZ
6246 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6247 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6248 (verify_row_hash) [XASSERTS]: New function.
6249 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6250 that the hash value of glyph rows is correct.
1e5b2111 6251
89d61221
MR
62522011-11-12 Martin Rudalics <rudalics@gmx.at>
6253
6254 * window.h (window): Remove splits slot.
6255 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6256 (Fdelete_other_windows_internal, make_parent_window)
6257 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6258 (Fset_window_configuration, save_window_save): Don't deal with
6259 split status of windows.
6260 (saved_window): Remove splits slot.
6261 (Vwindow_splits): Rewrite doc-string.
6262
97f18cc8
JD
62632011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6264
6265 * xfns.c (unwind_create_frame):
6266 * nsfns.m (unwind_create_frame):
6267 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6268 Vframe_list (Bug#9999).
6269
22a648b4
DA
62702011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6271
0b381c7e 6272 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6273
659afede
KH
62742011-11-11 Kenichi Handa <handa@m17n.org>
6275
6276 * callproc.c (Fcall_process): Set the member dst_multibyte of
6277 process_coding.
6278
9ac0394b
KH
62792011-11-11 Johan Bockgård <bojohan@gnu.org>
6280
6281 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6282 avoid a crash (bug#9496).
6283
2fbdc249
CY
62842011-11-09 Chong Yidong <cyd@gnu.org>
6285
6286 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6287 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6288
ac6b1f81
PE
62892011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6290
6291 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6292
09db192c
PE
62932011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6294
6295 Avoid some portability problems by eschewing 'extern inline' functions.
6296 The trivial performance wins aren't worth the portability hassles; see
6297 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6298 et seq.
6299 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6300 (window_box_width, window_box_left, window_box_left_offset)
6301 (window_box_right, window_box_right_offset): Undo previous change,
6302 by removing the "extern"s.
6303 * intervals.c (adjust_intervals_for_insertion)
6304 (adjust_intervals_for_deletion): Undo previous change,
6305 making these static again.
6306 (offset_intervals, temp_set_point_both, temp_set_point)
6307 (copy_intervals_to_string): No longer inline.
6308 * xdisp.c (window_text_bottom_y, window_box_width)
6309 (window_box_height, window_box_left_offset)
6310 (window_box_right_offset, window_box_left, window_box_right)
6311 (window_box): No longer inline.
6312
105216ed
CY
63132011-11-08 Chong Yidong <cyd@gnu.org>
6314
6315 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6316 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6317 Signal an error if not a live window.
105216ed
CY
6318 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6319 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6320
ae9e237f
JB
63212011-11-07 Juanma Barranquero <lekktu@gmail.com>
6322
6323 * lisp.h (syms_of_abbrev): Remove declaration.
6324 Reported by CHENG Gao <chenggao@royau.me>.
6325
c7aa8333
EZ
63262011-11-07 Eli Zaretskii <eliz@gnu.org>
6327
6328 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6329 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6330 of temacs in GUI mode.
6331
be7f5545
MR
63322011-11-07 Martin Rudalics <rudalics@gmx.at>
6333
6334 * window.h: Declare delete_all_child_windows instead of
6335 delete_all_subwindows.
6336 * window.c (Fwindow_nest, Fset_window_nest)
6337 (Fset_window_new_total, Fset_window_new_normal)
6338 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6339 (delete_all_subwindows): Rename to delete_all_child_windows.
6340 (Fdelete_other_windows_internal, Fset_window_configuration):
6341 Call delete_all_child_windows instead of delete_all_subwindows.
6342 * frame.c (delete_frame): Call delete_all_child_windows instead
6343 of delete_all_subwindows.
6344
ca78dc43
PE
63452011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6346
6347 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6348 This is also needed for porting to any host where GC_MARK_STACK is
6349 not GC_MAKE_GCPROS_NOOPS.
6350 (which_symbols): Use it.
6351
a0241d01
KH
63522011-11-07 Kenichi Handa <handa@m17n.org>
6353
6354 * coding.c (coding_set_destination): Check coding->src_pos only
6355 when coding->src_object is a buffer (bug#9910).
6356
6357 * process.c (send_process): Set the member src_multibyte of coding
6358 to 0 (bug#9911) when sending a unibyte text.
6359
6360 * callproc.c (Fcall_process): Set the member src_multibyte of
6361 process_coding to 0 (bug#9912).
6362
a64bfdfa 63632011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6364
6365 * xmenu.c (cleanup_widget_value_tree): New function.
6366 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6367 calling free_menubar_widget_value_tree directly (Bug#9830).
6368
cb41b32a
PE
63692011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6370
6371 Fix some portability problems with 'inline'.
6372 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6373 (window_box_width, window_box_left, window_box_left_offset)
6374 (window_box_right, window_box_right_offset): Declare extern.
6375 Otherwise, these inline functions do not conform to C99 and
6376 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6377 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6378 * intervals.c (adjust_intervals_for_insertion)
6379 (adjust_intervals_for_deletion): Now extern, because otherwise the
6380 extern inline functions 'offset_intervals' couldn't refer to it.
6381 (static_offset_intervals): Remove.
6382 (offset_intervals): Rewrite using the old contents of
6383 static_offset_intervals. The old version didn't conform to C99
6384 because an extern inline function contained a reference to an
6385 identifier with static linkage.
6386
b7041366
AS
63872011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6388
6389 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6390 GC.
6391
88a37c4d
EZ
63922011-11-06 Eli Zaretskii <eliz@gnu.org>
6393
6394 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6395 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6396 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6397 return Qleft_to_right.
6398
49745b39
CY
63992011-11-06 Chong Yidong <cyd@gnu.org>
6400
6401 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6402 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6403 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6404 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6405 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6406 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6407 (Fwindow_vscroll): Doc fix.
6408 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6409 argument, since it makes no sense to pass a live window and for
6410 consistency with window-child.
6411
1f05cd82
CS
64122011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6413
6414 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6415 support MSVC.
6416
22610910
JR
64172011-11-05 Jason Rumney <jasonr@gnu.org>
6418
6419 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6420 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6421 fonts (Bug#6029).
6422 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6423 bitwise arithmetic preventing use of unicode-sip and non-truetype
6424 opentype fonts.
6425
a06776b2
EZ
64262011-11-05 Eli Zaretskii <eliz@gnu.org>
6427
3ad924ba
EZ
6428 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6429 "emacs"-only part.
6430
a06776b2
EZ
6431 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6432 initialization code to keep similarity to xfns.c after changes
6433 from 2011-11-05.
6434
c9e7db78
JD
64352011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6436
a97f8f3f
JD
6437 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6438 (unwind_create_frame): New function (Bug#9943).
6439 (Fx_create_frame): Restructure code to be more similar to the one in
6440 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6441 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6442 Move terminal->reference_count++ just before making the frame official
6443 (Bug#9943).
6444
6445 * nsterm.m (x_free_frame_resources): New function.
6446 (x_destroy_window): Move code to x_free_frame_resources.
6447
c9e7db78 6448 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6449 (Fx_create_frame, x_create_tip_frame):
6450 Move terminal->reference_count++ just before making the frame
75f1671a 6451 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6452 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6453
a6fc3b5c
EZ
64542011-11-05 Eli Zaretskii <eliz@gnu.org>
6455
6456 Support MSVC build with newer versions of Visual Studio.
6457 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6458 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6459 nt/gmake.defs.
6460
6461 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6462 which are not supported by MSVC.
6463 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6464 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6465 bitfields.
6466 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6467 types in bitfields.
6468 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6469
6470 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6471
58179cce 64722011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6473
6474 Support MSVC build with newer versions of Visual Studio.
6475 * w32.c: Don't include w32api.h for MSVC.
6476 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6477
6478 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6479 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6480 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6481 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6482 e_* cousins.
6483 (alloca) [_MSC_VER]: Define to _alloca.
6484
6485 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6486
6487 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6488
a58c13ed
EZ
64892011-11-04 Eli Zaretskii <eliz@gnu.org>
6490
6491 * xdisp.c (note_mouse_highlight): If either of
6492 previous/next-single-property-change returns nil, treat that as
6493 the beginning or the end of the buffer. (Bug#9955)
6494
fe0b6370
JD
64952011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6496
a58c13ed 6497 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6498 label is not null (Bug#9951).
6499 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6500 may be NULL.
6501
89bd5ee1
EZ
65022011-11-04 Eli Zaretskii <eliz@gnu.org>
6503
6504 * window.c (Fwindow_body_size): Mention in the doc string that the
6505 return value is in frame's canonical units. (Bug#9949)
6506
84c3edb9
EZ
65072011-11-03 Eli Zaretskii <eliz@gnu.org>
6508
4e2fb5c7
EZ
6509 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6510
84c3edb9 6511 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6512 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6513 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6514
bc17a887
EZ
65152011-11-01 Eli Zaretskii <eliz@gnu.org>
6516
6517 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6518 Don't stop backward scan on the continuation glyph, even though
6519 its CHARPOS is positive.
6d5eb5b0
SM
6520 (mouse_face_from_buffer_pos, note_mouse_highlight):
6521 Rename cover_string to disp_string.
bc17a887 6522
4ee88440
MR
65232011-11-01 Martin Rudalics <rudalics@gmx.at>
6524
6525 * window.c (temp_output_buffer_show): Don't use
6526 Vtemp_buffer_show_specifiers.
6527 (Vtemp_buffer_show_specifiers): Remove unused variable.
6528
c2ff3c02
EZ
65292011-10-30 Eli Zaretskii <eliz@gnu.org>
6530
6531 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6532 past the beginning of the current glyph matrix.
6533
58179cce 65342011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6535
6536 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6537 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6538 HAVE_GTK3 (Bug#9869).
b77a6a7f 6539
3b574623
JD
6540 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6541 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6542
b77a6a7f
JD
6543 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6544
6545 * xterm.c: Declare x_handle_net_wm_state to return int.
6546 (handle_one_xevent): Check if we are iconified but don't have
6547 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6548 (get_current_wm_state): Return non-zero if not hidden,
6549 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6550 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6551 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6552 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6553
196e41e4
PE
65542011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6555
6556 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6557 so that this new function doesn't get optimized away by a
6558 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6559
021f2e1a
AS
65602011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6561
6562 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6563
8b058d44
EZ
65642011-10-29 Eli Zaretskii <eliz@gnu.org>
6565
6566 Fix the `xbytecode' command.
6567 * .gdbinit (xprintbytestr): New command.
b50a28de 6568 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6569 (xbytecode): Print the byte-code string as well.
6570
4452fb80
EZ
65712011-10-29 Kim Storm <storm@cua.dk>
6572
8b058d44
EZ
6573 * alloc.c (which_symbols): New function.
6574
21b72067
AS
65752011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6576
6577 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6578 line. (Bug#9903)
6579
83ed7b5c
GM
65802011-10-29 Glenn Morris <rgm@gnu.org>
6581
6582 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6583 Not clear what it was for, and it causes various bugs. (Bug#9839)
6584
5a7a728b
EZ
65852011-10-28 Eli Zaretskii <eliz@gnu.org>
6586
6587 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6588 possible random value that matches one of those tested as
6589 condition to clear the mouse face.
6590
d3d0842f
CY
65912011-10-28 Chong Yidong <cyd@gnu.org>
6592
6593 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6594
31b39d13
DN
65952011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6596
6597 * window.c (make_window): Initialize phys_cursor_on_p.
6598
9aba6043
SM
65992011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6600
6601 * lisp.h (struct Lisp_Symbol): Update comments.
6602
c20992f4
JB
66032011-10-28 Juanma Barranquero <lekktu@gmail.com>
6604
6605 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6606
db4f02f2
EZ
66072011-10-28 Eli Zaretskii <eliz@gnu.org>
6608
6609 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6610 <oslsachem@gmail.com> for helping to debug this.
6611
6612 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6613 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6614 (g_b_init_get_glyph_outline_w): New static variables.
6615 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6616 (GetGlyphOutlineW_Proc): New typedefs.
6617 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6618 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6619 New functions.
6620 (w32font_open_internal, compute_metrics):
6621 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6622 instead of calling the "wide" APIs directly.
6623
6624 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6625
6626 * w32.h (syms_of_w32font): Add prototype.
6627
87e68db4
JB
66282011-10-27 Juanma Barranquero <lekktu@gmail.com>
6629
6630 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6631 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6632 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6633 (Fmove_to_window_line): Doc fix.
6634
435c1d67
CY
66352011-10-27 Chong Yidong <cyd@gnu.org>
6636
6637 * process.c (make_process): Set gnutls_state to NULL.
6638
6639 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6640 non-NULL, regardless of GNUTLS_INITSTAGE.
6641 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6642 an error. Set process slots as soon as we allocate them.
6643
6644 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6645
9c6c6f49
CY
66462011-10-27 Chong Yidong <cyd@gnu.org>
6647
9aba6043
SM
6648 * gnutls.c (emacs_gnutls_deinit): New function.
6649 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6650 (Fgnutls_deinit, Fgnutls_boot): Use it.
6651
6652 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6653 (deactivate_process): Call emacs_gnutls_deinit.
6654
657d08d3
JB
66552011-10-27 Juanma Barranquero <lekktu@gmail.com>
6656
6657 * image.c (x_create_x_image_and_pixmap):
6658 * w32.c (sys_rename, w32_delayed_load):
6659 * w32font.c (fill_in_logfont):
6660 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6661
5430d399
JB
66622011-10-26 Juanma Barranquero <lekktu@gmail.com>
6663
6664 * w32fns.c (w32_default_color_map): New function,
6665 extracted from Fw32_default_color_map.
a7ef684b 6666 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6667
fe0055fa
PE
66682011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6669
6670 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6671
e6346438
SM
66722011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6673
6674 * keyboard.c (test_undefined): New function (bug#9751).
6675 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6676
e112cc37
ET
66772011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6678
6679 * sysdep.c (init_sys_modes): Fix the check for the controlling
6680 terminal (Bug#6649).
6681
7b5d6677
EZ
66822011-10-20 Eli Zaretskii <eliz@gnu.org>
6683
6684 * dispextern.h (struct bidi_it): New member next_en_type.
6685
6686 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6687 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6688 current character, check also for next_en_type being WEAK_EN.
6689 (bidi_resolve_weak): Don't enter the expensive loop if the current
6690 position is before next_en_pos. Record the bidi type of the first
6691 non-ET, non-BN character we find, in addition to its position.
6692 (bidi_level_of_next_char): Invalidate next_en_type when
6693 next_en_pos is over-stepped.
6694
7da0b018
PE
66952011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6696
6697 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6698 * editfns.c: Rewrite current-time-zone so that it invokes
6699 the equivalent of (format-time-string "%Z") to get the time zone name.
6700 This fixes a bug when the time zone name contains characters that
6701 need converting from the system time locale to Emacs internal format.
6702 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6703 that patch fixed format-time-string to do the conversion, but
6704 I forgot to fix current-time-zone.
6705 (format_time_string): New function, containing most of
6706 what Fformat_time_string used to contain.
6707 (Fformat_time_string): Rewrite in terms of format_time_string.
6708 This doesn't change this function's behavior.
6709 (current-time-zone): Rewrite to use format_time_string.
6710 This fixes the bug reported by Michael Schierl in
6711 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6712 Jason Rumney's 2007-06-07 change worked around this bug, but
6713 didn't fix it.
6714 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6715
8547b010
EZ
67162011-10-19 Eli Zaretskii <eliz@gnu.org>
6717
6718 * xdisp.c (start_display): If the character at POS is displayed
6719 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6720 (try_window_reusing_current_matrix): If a line ends in a display
6721 vector or the next line starts in a display vector, continue
6722 redrawing the window even though the character position of
6723 start_row was reached.
8547b010
EZ
6724 (Bug#9771, part 2)
6725
4e948d15
CY
67262011-10-18 Chong Yidong <cyd@gnu.org>
6727
6728 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6729 with nobreak-char-display too.
6730
4787455f
EZ
67312011-10-18 Eli Zaretskii <eliz@gnu.org>
6732
6733 Fix part 3 of bug#9771.
6734 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6735 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6736 non-neutral characters if the current character is a paragraph
6737 separator (a.k.a. Newline). This avoids running the same
6738 expensive loop twice, once when we consume the preceding newline
6739 and the other time when the line actually needs to be displayed.
6740 Avoid the loop when we see neutrals on the base embedding level
6741 following a character whose directionality is the same as the
6742 paragraph's. This avoids running the expensive loop when a line
6743 ends in a long sequence of neutrals, like control characters.
6744 Add assertion against STRONG_AL type. Slightly rearrange code
6745 that determines the type of a neutral given the first non-neutral
6746 that follows it.
6747 (bidi_level_of_next_char): Set next_en_pos to zero when
6748 invalidating its info.
6749
2c91f553
EZ
67502011-10-17 Eli Zaretskii <eliz@gnu.org>
6751
6752 * xdisp.c (push_display_prop): Determine whether to record string
6753 or buffer position by IT->string, not by IT->method. Allow
6754 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6755 (move_it_vertically_backward): Don't look for character position
6756 immediately after the newline when in a continuation line.
6757 (Bug#9771, part 1)
2c91f553 6758
c7b08b0d
MR
67592011-10-15 Martin Rudalics <rudalics@gmx.at>
6760
6761 * window.c (coordinates_in_window): Rewrite and delabelize
6762 vertical border check. (Bug#5357) (Bug#9618)
6763
6b02f655
SM
67642011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6765
6766 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6767 errors in XSetWindowBorder (bug#9310).
6768
81d40c92
DA
67692011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6770
6771 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6772 avoid crash when xmalloc overrun checking is enabled.
6773
d4172c3b
EZ
67742011-10-13 Eli Zaretskii <eliz@gnu.org>
6775
6776 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6777 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6778 cursor motion with <left> and <right> arrow keys.
6779
6780 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6781 some callers set that themselves.
6782
b00eea75
EZ
67832011-10-12 Eli Zaretskii <eliz@gnu.org>
6784
6785 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6786 display string and the previous row comes from the same string and
6787 is empty. (Bug#9739) (Bug#9738)
6788
8fe012c4
SM
67892011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6790
6791 * doc.c (get_doc_string): Encode file name (bug#9735).
6792
0074aef2
EZ
67932011-10-12 Eli Zaretskii <eliz@gnu.org>
6794
79beb178
EZ
6795 * bidi.c (bidi_level_of_next_char):
6796 * xdisp.c (get_visually_first_element): Remove old incorrect
6797 comments regarding the Unicode Line Separator character.
6798
0074aef2
EZ
6799 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6800
6e4b3fbe
DA
68012011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6802
6803 * alloc.c (Fgc_status): Do not access beyond zombies array
6804 boundary if nzombies > MAX_ZOMBIES.
6805 * alloc.c (dump_zombies): Add missing format specifier.
6806
0324f3af
PE
68072011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6808
b5525cac
PE
6809 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6810 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6811
0324f3af
PE
6812 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6813 Some packages use them to denote characters with modifiers.
6814
e9b5f888
AS
68152011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6816
6817 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6818 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6819 matching a pp-number. Rename parameter var to var1.
6820
127827c0
SM
68212011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6822
6823 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6824
c8fd3bd0
GM
68252011-10-08 Glenn Morris <rgm@gnu.org>
6826
6827 * callint.c (Fcall_interactively): Give a more explicit error for the
6828 'c' case with a non-character input. (Bug#8479)
6829
352ec8ff
EZ
68302011-10-08 Eli Zaretskii <eliz@gnu.org>
6831
03669ccb
EZ
6832 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6833 lines.
7061c986
EZ
6834 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6835 lines that are hscrolled on the left.
03669ccb 6836
352ec8ff
EZ
6837 * dispnew.c (buffer_posn_from_coords): Account for a possible
6838 presence of header-line. (Bug#4426)
6839
a66cfb1c
SM
68402011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6841
6b02f655
SM
6842 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6843 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6844
7c5ee88e
PE
68452011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6846
6847 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6848 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6849 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6850 this makes Emacs dump core during garbage collection on rare
6851 occasions. sizeof is obviously inferior to offsetof here, so
6852 stick with offsetof.
6853 (GC_POINTER_ALIGNMENT): New macro.
6854 (mark_memory): Omit 3rd (offset) arg; caller changed.
6855 Don't assume EMACS_INT alignment is the same as pointer alignment.
6856
df1bbe5b
SM
68572011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6858
6859 * keyboard.c (read_key_sequence_remapped): New var.
6860 (read_key_sequence): Compute remapping in the right buffer.
6861 (command_loop_1): Use read_key_sequence's remapping directly.
6862
51553db6
SM
68632011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6864
32c1fffd
SM
6865 * dired.c (file_name_completion): Don't expand file name.
6866 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6867 before checking file name handler.
6868
51553db6
SM
6869 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6870 they've been requested explicitly (bug#9591).
6871
b6bd1599 68722011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6873
6874 * keymap.c (Fsingle_key_description): Use make_specified_string
6875 instead of build_string to build string from push_key_description.
6876 (Bug#5193)
6877
f701dc2a
PE
68782011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6879
4222c55d
PE
6880 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6881 This fixes a Y2038 bug on 64-bit hosts.
6882 * buffer.c (reset_buffer):
6883 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6884 (Fclear_buffer_auto_save_failure):
6885 Use 0, not -1, to represent an unset failure time, since time_t
6886 might not be signed.
6887
f701dc2a
PE
6888 Remove dependency on glibc malloc internals.
6889 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6890 Move back here from lisp.h, but with their new implementations.
6891 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6892 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6893 * charset.c (charset_table_init): New static var.
6894 (syms_of_charset): Use it instead of xmalloc. This removes a
6895 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6896 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6897 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6898 Move back to alloc.c.
6899 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6900 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6901
9ceebf39
JD
69022011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6903
6904 * nsterm.m (windowDidResize): Call x_set_window_size only when
6905 ns_in_resize is true. Otherwise set pixelwidth/height and
6906 call change_frame_size (Bug#9628).
6907
cb993c58
PE
69082011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6909
3930c88b
PE
6910 Port --enable-checking=all to Fedora 14 x86-64.
6911 * charset.c (syms_of_charset): Also account for glibc malloc's
6912 internal overhead when calculating the initial malloc maximum.
6913
cb993c58
PE
6914 Port --enable-checking=all to Fedora 14 x86.
6915 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6916 Move to lisp.h.
6917 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6918 (overrun_check_realloc, overrun_check_free):
6919 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6920 That way, xmalloc returns a properly-aligned pointer even if
6921 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6922 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6923 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6924 into account when calculating the initial malloc maximum.
6925 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6926 Move here from alloc.c, so that charset.c can use it too.
6927 Properly align; the old code wasn't right for common 32-bit hosts
6928 when configured with --enable-checking=all.
6929 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6930 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6931
31bed486
EZ
69322011-09-29 Eli Zaretskii <eliz@gnu.org>
6933
04c70788 6934 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6935 use EDOM.
6936
fbcaa2f3
EZ
69372011-09-28 Eli Zaretskii <eliz@gnu.org>
6938
6939 * xdisp.c (compute_display_string_end): If there's no display
6940 string at CHARPOS, return -1.
6941
6942 * bidi.c (bidi_fetch_char): When compute_display_string_end
6943 returns a negative value, treat the character as a normal
6944 character not covered by a display string. (Bug#9624)
6945
a239d4e9
JB
69462011-09-28 Juanma Barranquero <lekktu@gmail.com>
6947
6948 * lread.c (Fread_from_string): Fix typo in docstring.
6949
88652fd5
EZ
69502011-09-27 Eli Zaretskii <eliz@gnu.org>
6951
6952 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6953 newline, reseat the iterator instead of bidi-iterating there one
6954 character at a time. (Bug#9610)
32c1fffd
SM
6955 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6956 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6957
ed497dd4
AS
69582011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6959
6960 * lread.c (readevalloop): Use correct code for NBSP.
6961 (read1): Likewise. (Bug#9608)
6962
b2bf61aa
MA
69632011-09-25 Michael Albinus <michael.albinus@gmx.de>
6964
6965 * dbusbind.c (Fdbus_register_signal): When service is not
6966 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6967
32bbb17c
GM
69682011-09-25 Glenn Morris <rgm@gnu.org>
6969
6970 * buffer.c (truncate-lines): Doc fix.
6971
94e0933e
CY
69722011-09-24 Chong Yidong <cyd@stupidchicken.com>
6973
6974 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6975 (Fset_window_next_buffers): Doc fix.
6976
cddde921
GM
69772011-09-24 Glenn Morris <rgm@gnu.org>
6978
6979 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6980
1260aef1
PE
69812011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6982
25b4bfa0
PE
6983 Fix minor problems found by static checking.
6984 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6985 * indent.c (Fvertical_motion): Fix == vs = typo.
6986
e3cbd34b
EZ
69872011-09-24 Eli Zaretskii <eliz@gnu.org>
6988
a66cfb1c
SM
6989 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6990 Default value is now t. Doc fix.
6bf7006f 6991
e3cbd34b 6992 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6993 logic when moving up, not only when moving down. Fix the
e3cbd34b 6994 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6995 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6996
6997 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6998 CHARPOS is covered by a display string which includes newlines.
6999 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7000 is covered by a display string with embedded newlines.
7001
a3de0cbd
MA
70022011-09-24 Michael Albinus <michael.albinus@gmx.de>
7003
7004 * dbusbind.c (Fdbus_register_signal): Add match rule to
7005 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7006 (Fdbus_register_method, Vdbus_registered_objects_table):
7007 Fix docstring.
a3de0cbd 7008
b260039d
JM
70092011-09-24 Jim Meyering <meyering@redhat.com>
7010
32c1fffd 7011 do not ignore write error for any output size
b260039d
JM
7012 The previous change was incomplete.
7013 While it makes emacs --batch detect the vast majority of stdout
7014 write failures, errors were still ignored whenever the output size is
7015 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7016 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7017 && echo FAIL: ignored write error
7018 FAIL: ignored write error
7019 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7020 && echo FAIL: ignored write error
7021 FAIL: ignored write error
7022 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7023
8eca8a7c
AS
70242011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7025
7026 * emacs.c (Fkill_emacs): In noninteractive mode exit
7027 non-successfully if a write error occurred on stdout. (Bug#9574)
7028
3341db62
EZ
70292011-09-21 Eli Zaretskii <eliz@gnu.org>
7030
7031 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7032 the xassert test.
7033
7034 * dispextern.h (struct it): Update the comment documenting what
7035 can it->OBJECT be.
7036
8c203dbf
EZ
70372011-09-20 Eli Zaretskii <eliz@gnu.org>
7038
7039 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7040 a display string, extend search for cursor position to end of row.
7041 (find_row_edges): If the row ends in a newline from a display
7042 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7043 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7044 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7045 non-empty line. Fixes confusing cursor motion with arrow keys at
7046 the beginning of a line that starts with whitespace.
8c203dbf 7047
a4824228
LMI
70482011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7049
7050 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7051 (bug#9493).
7052
33ed493b
CY
70532011-09-18 Chong Yidong <cyd@stupidchicken.com>
7054
7055 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7056 boolean (Bug#9154).
7057
56cd55c8
EZ
70582011-09-18 Eli Zaretskii <eliz@gnu.org>
7059
7060 * xdisp.c (display_line): Record maximum and minimum buffer
7061 positions even if no glyphs were produced (e.g., by a zero-width
7062 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7063 buffer positions that will be removed from the glyph row because
7064 they don't fit.
c02dcedf
EZ
7065 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7066 column is beyond frame width: don't subtract 1 "pixel" when
7067 computing width of the stretch.
3e62b7e0
EZ
7068 (reseat_at_next_visible_line_start): Undo the change made on
7069 2011-09-17 that saved paragraph information and restored it after
7070 the call to `reseat'. (Bug#9545)
56cd55c8 7071
5ed99d36 70722011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7073
7074 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7075 and turn window cursor on if cleared (Bug#9415).
7076
5ed99d36 70772011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7078
7079 * search.c (boyer_moore): Take unibyte characters from pattern
7080 literally. (Bug#9458)
7081
9bade7b2
EZ
70822011-09-18 Eli Zaretskii <eliz@gnu.org>
7083
7084 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7085
e5e9d610
PE
70862011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7087
87e4427a
PE
7088 Fix minor problem found by static checking.
7089 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7090 initialized, to pacify gcc -Wuninitialized.
7091
e5e9d610
PE
7092 * fileio.c: Report proper errno when syscall falls.
7093 (Finsert_file_contents): Save and restore errno,
7094 so that report_file_error outputs the correct diagnostic.
7095 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7096
a1674f0b
EZ
70972011-09-18 Eli Zaretskii <eliz@gnu.org>
7098
7099 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7100
fbfb6dd4
EZ
71012011-09-17 Eli Zaretskii <eliz@gnu.org>
7102
7103 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7104 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7105
bb187662
EZ
71062011-09-17 Eli Zaretskii <eliz@gnu.org>
7107
1137e8b8 7108 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7109 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7110
7111 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7112 (bidi_find_paragraph_start): Search back for paragraph beginning
7113 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7114 (bidi_move_to_visually_next): Only trigger paragraph-related
7115 computations when the last character is a newline or at EOB, not
7116 just any NEUTRAL_B. (Bug#9470)
7117
bb187662
EZ
7118 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7119 truncated lines if point is covered by a display string. (Bug#9524)
7120
2e621251
PE
71212011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7122
7123 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7124 (cons_to_x_long): New function.
7125 (lisp_data_to_selection_data): Use it. Correct the test for
7126 short-versus-long data; it was negated. Break out of vector
7127 loop, for efficiency, when a long datum is discovered.
7128
91a15bc6
SM
71292011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7130
7131 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7132
b41c3a35
EZ
71332011-09-16 Eli Zaretskii <eliz@gnu.org>
7134
7135 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7136 GCC PR/17406) by declaring this function with external scope.
7137
7812ba2d
PE
71382011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7139
7140 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7141 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7142
cf7edc2a
AS
71432011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7144
7145 * editfns.c (Fformat): Correctly handle text properties on "%%".
7146
bd01620e
EZ
71472011-09-15 Eli Zaretskii <eliz@gnu.org>
7148
7149 * xterm.c (x_draw_composite_glyph_string_foreground):
7150 * w32term.c (x_draw_composite_glyph_string_foreground):
7151 * term.c (encode_terminal_code):
7152 * composite.c (composition_update_it, get_composition_id):
7153 * xdisp.c (get_next_display_element)
7154 (fill_composite_glyph_string): Add comments about special meaning
7155 of TAB characters in a composition.
7156
a02719a3
PE
71572011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7158
7159 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7160 This occurs when processing a multibyte format.
7161 Problem reported by Wolfgang Jenker.
a02719a3 7162
72589a3c
JB
71632011-09-15 Johan Bockgård <bojohan@gnu.org>
7164
7165 * xdisp.c (try_cursor_movement): Only check for exact match if
7166 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7167
1c14176c
PE
71682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7169
7170 Remove unused external symbols.
7171 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7172 * xdisp.c (calc_pixel_width_or_height): Now static.
7173 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7174 * indent.c (check_display_width):
7175 * w32term.c: Fix comment to match code.
7176 * xterm.c, xterm.h (x_catching_errors): Remove.
7177
d2eea5b5
PE
71782011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7179
7180 * xselect.c: Use signed conversions more consistently (Bug#9498).
7181 (selection_data_to_lisp_data): Assume incoming selection data are
7182 signed integers, not unsigned. This is to be consistent with
7183 outgoing selection data, which was modified to use signed integers
7184 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7185 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7186 expects long, not unsigned long.
7187
46888499
EZ
71882011-09-14 Eli Zaretskii <eliz@gnu.org>
7189
7190 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7191 computation of loop end. Reported by Johan Bockgård
7192 <bojohan@gnu.org>.
7193
ef8ef9fb
CY
71942011-09-13 Chong Yidong <cyd@stupidchicken.com>
7195
7196 * frame.c (Fother_visible_frames_p): Function deleted.
7197
fa819fed
EZ
71982011-09-12 Eli Zaretskii <eliz@gnu.org>
7199
7200 * indent.c (compute_motion): Process display vector front to back
7201 rather than the other way around. (Bug#2496)
7202
2ba8e008
SM
72032011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7204
7205 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7206
20f53c69
CY
72072011-09-11 Chong Yidong <cyd@stupidchicken.com>
7208
7209 * minibuf.c (Fread_from_minibuffer): Doc fix.
7210
d562d7a4
EZ
72112011-09-11 Eli Zaretskii <eliz@gnu.org>
7212
7213 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7214 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7215
1c4d7f3d
LMI
72162011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7217
7218 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7219 value for non-existent files.
7220
b885bf36
EZ
72212011-09-11 Eli Zaretskii <eliz@gnu.org>
7222
7223 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7224 set its "size" to -1. This will set the modtime_size field of
7225 the corresponding buffer to -1, which is what
7226 verify-visited-file-modtime expects for files that do not exist.
7227 (Bug#9139)
7228
6612f0bf
PE
72292011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7230
7231 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7232 here ...
7233 * lisp.h: ... from here. push_key_description is no longer
7234 defined in keyboard.c, so its declaration should not be in
7235 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7236 logically belongs with push_key_description.
7237
dfb3f755
PE
72382011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7239
7240 * buffer.h: Include <sys/types.h> instead of <time.h>.
7241 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7242 Problem reported by Herbert J. Skuhra.
7243
3134906c
LMI
72442011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7245
7246 * xml.c (parse_region): Make the parsing work for
7247 non-comment-starting XML files again (bug#9144).
7248
8d903f4e
AS
72492011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7250
7251 * image.c (gif_load): Fix calculation of bottom and right corner.
7252 (Bug#9468)
7253
80ad64f4
EZ
72542011-09-10 Eli Zaretskii <eliz@gnu.org>
7255
7256 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7257 redisplay in small windows.
7258
208a048d
EZ
72592011-09-09 Eli Zaretskii <eliz@gnu.org>
7260
7261 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7262
9b1c252e
MR
72632011-09-08 Martin Rudalics <rudalics@gmx.at>
7264
7265 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7266 Operate on live windows only.
7267
2949f33b
JB
72682011-09-08 Juanma Barranquero <lekktu@gmail.com>
7269
7270 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7271
e08dcafd
EZ
72722011-09-07 Eli Zaretskii <eliz@gnu.org>
7273
7274 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7275 only under bidi iteration.
7276
115b96bd
JD
72772011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7278
7279 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7280
c8199d0f
PE
72812011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7282
7283 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7284 Without this fix, the command to link temacs failed due to an
7285 undefined symbol __builtin_isnan. This is because
7286 /usr/include/iso/math_c99.h #defines isnan(x) to
7287 __builtin_isnan(x), but the bundled gcc, which identifies itself
7288 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7289 a __builtin_isnan.
7290 * floatfns.c (isnan): #undef, and then #define to a clone of
7291 what's in data.c.
7292 (Fisnan): Always define, since it's always available now.
7293 (syms_of_floatfns): Always define isnan at the Lisp level.
7294
e39b275c 72952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7296
7297 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7298
b2db44d9 72992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7300
f4af5137 7301 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7302 The previous code assumed that file offsets (off_t values) fit in
7303 EMACS_INT variables, which is not true on typical 32-bit hosts.
7304 The code messed up by falsely reporting buffer overflow in cases
7305 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7306 when "big" contains more than 2**29 bytes, even though this
7307 inserts just one byte and does not overflow the buffer.
7308 (Finsert_file_contents): Store file offsets as off_t
7309 values, not as EMACS_INT values. Check for overflow when
7310 converting between EMACS_INT and off_t. When checking for
7311 buffer overflow or for overlap, take the offsets into account.
7312 Don't use EMACS_INT for small values where int suffices.
7313 When checking for overlap, fix a typo: ZV was used where
7314 ZV_BYTE was intended.
7315 (Fwrite_region): Don't assume off_t fits into 'long'.
7316 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7317
ecfc0a49
MA
73182011-09-05 Michael Albinus <michael.albinus@gmx.de>
7319
7320 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7321
6511acf2 73222011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7323
0999621a 7324 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7325
7326 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7327 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7328 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7329 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7330 (modify_event_symbol): Do not assume that the length of
7331 name_alist_or_stem is safe to alloca and fits in int.
7332 (Fexecute_extended_command): Likewise for function name and binding.
7333 (Frecursion_depth): Wrap around reliably on integer overflow.
7334 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7335 since some callers pass EMACS_INT values.
7336 (Fsingle_key_description): Don't crash if symbol name contains more
7337 than MAX_ALLOCA bytes.
7338 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7339 (get_minibuffer): Arg is now EMACS_INT, not int.
7340 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7341 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7342 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7343
2be7d702
PE
7344 * dbusbind.c (signature_cat): New function.
7345 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7346 Do not overrun buffer; instead, report string overflow.
7347
9d1df220
PE
7348 * dispnew.c (add_window_display_history): Don't overrun buffer.
7349 Truncate instead; this is OK since it's just a log.
7350
33ef5c64
PE
7351 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7352 even if the time zone offset is outlandishly large.
7353 Don't mishandle offset == INT_MIN.
7354
66c6fdd5
PE
7355 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7356 when creating daemon; the previous buffer-overflow check was incorrect.
7357
d749b01b
PE
7358 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7359 which has the guts of the old verror function.
7360
b5cd1905
PE
7361 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7362 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7363
6e1a67fb
PE
7364 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7365 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7366 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7367 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7368 length of string rather than counting it via multiple sprintfs;
7369 that's simpler and more reliable.
c21721cc
PE
7370 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7371 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7372 sprintf, in case result does not fit in int.
7373
c57b67fc
PE
7374 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7375 (fontset_from_font): Print it.
7376
8a401434
PE
7377 * frame.c (tty_frame_count): Now printmax_t, not int.
7378 (make_terminal_frame, set_term_frame_name): Print it.
7379 (x_report_frame_params): In X, window IDs are unsigned long,
7380 not signed long, so print them as unsigned.
7381 (validate_x_resource_name): Check for implausibly long names,
7382 and don't assume name length fits in 'int'.
7383 (x_get_resource_string): Don't blindly alloca invocation name;
7384 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7385 not fit in int.
7386
6e1a67fb
PE
7387 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7388 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7389 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7390
0df02bf3
PE
7391 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7392 Use esprintf, not sprintf, in case result does not fit in int.
7393
48e30793
PE
7394 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7395 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7396 it as a large positive number.
7397 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7398 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7399
a66ff6d8
PE
7400 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7401 in case result does not fit in int.
7402
aca216ff
PE
7403 * print.c (float_to_string): Detect width overflow more reliably.
7404 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7405 buffer overrun. Don't assume list length fits in 'int'. Treat
7406 print length of 0 as 0, not as infinity; to be consistent with other
7407 uses of print length in this function. Don't overflow print length
7408 index. Don't assume hash table size fits in 'long', or that
7409 vectorlike size fits in 'unsigned long'.
7410
31c286f7
PE
7411 * process.c (make_process): Use printmax_t, not int, to format
7412 process-name gensyms.
7413
55e5faa1
PE
7414 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7415
80f2e268
PE
7416 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7417 to avoid potential buffer overrun.
7418
670741ab
PE
7419 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7420 if X resource line is longer than 512 bytes.
7421
b7163a50
PE
7422 * xfns.c (x_window): Make sprintf buffer a bit bigger
7423 to avoid potential buffer overrun.
7424
ae58ff1f
PE
7425 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7426
c43c8a6a
PE
7427 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7428
3f8236f4
PE
74292011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7430
53e9fe90 7431 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7432 Without these, Emacs silently mishandles large integers sometimes.
7433 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7434 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7435
6511acf2
PE
7436 * xdisp.c (try_window_id): Check Emacs fixnum range before
7437 converting to 'int'.
806add1d 7438
6511acf2 7439 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7440 Check that an Emacs fixnum is in range before assigning it to 'int'.
7441 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7442 values converted from Emacs fixnums.
7443 (Frecenter): Don't wrap around a line count if it is out of 'int'
7444 range; instead, treat it as an extreme value.
7445 (Fset_window_configuration, compare_window_configurations):
7446 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7447
6511acf2
PE
7448 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7449 that can exceed INT_MAX. Check that EMACS_INT value is in range
7450 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7451 (match_limit): Don't assume that a fixnum can fit in 'int'.
7452
6511acf2 7453 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7454 exceed INT_MAX.
7455
6511acf2 7456 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7457 (Fvertical_motion): Don't wrap around LINES values that don't fit
7458 in 'int'. Instead, treat them as extreme values. This is good
7459 enough for windows, which can't have more than INT_MAX lines anyway.
7460
fcb901a7
LMI
74612011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7462
0f2f6b6d
LMI
7463 * Require libxml/parser.h to avoid compilation warning.
7464
fcb901a7
LMI
7465 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7466
7467 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7468 since this reportedly can destroy thread storage.
7469
6e20a0d4
CY
74702011-08-30 Chong Yidong <cyd@stupidchicken.com>
7471
7472 * syntax.c (find_defun_start): Update all cache variables if
7473 exiting early (Bug#9401).
7474
148ae00e
EZ
74752011-08-30 Eli Zaretskii <eliz@gnu.org>
7476
f6cfbd8f
EZ
7477 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7478
148ae00e
EZ
7479 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7480 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7481 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7482
7483 * term.c (tty_append_glyph): New function.
7484 (produce_stretch_glyph): Static function and its prototype deleted.
7485
a66cfb1c
SM
7486 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7487 Add prototypes.
148ae00e 7488
c4a07a4c
PE
74892011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7490
7491 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7492 when checking :margin (Bug#9390).
7493 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7494 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7495 so that the name doesn't mislead. All uses changed.
7496
6bc8cd65
JB
74972011-08-28 Johan Bockgård <bojohan@gnu.org>
7498
7499 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7500 set_tty_hooks.
7501
dca4927e
EZ
75022011-08-27 Eli Zaretskii <eliz@gnu.org>
7503
7504 * xdisp.c (move_it_to): Don't bail out early when reaching
7505 position beyond to_charpos, if we are scanning backwards.
7506 (move_it_vertically_backward): When DY == 0, make sure we get to
7507 the first character in the line after the newline.
7508
f2cad773
PE
75092011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7510
7511 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7512 (ccl_driver): Do not generate an out-of-range pointer.
7513 (Fccl_execute_on_string): Remove unnecessary check for
7514 integer overflow, noted by Stefan Monnier in
7515 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7516 Remove a FIXME that didn't need fixing.
7517 Simplify the newly-introduced buffer reallocation code.
7518
0cae2cdb
JB
75192011-08-27 Juanma Barranquero <lekktu@gmail.com>
7520
7521 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7522
5fc295a4 75232011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7524
70c60eb2 7525 Integer and memory overflow issues (Bug#9196).
726e0ab1 7526
d31850da
PE
7527 * doc.c (get_doc_string): Rework so that
7528 get_doc_string_buffer_size is the actual buffer size, rather than
7529 being 1 less than the actual buffer size; this makes xpalloc more
7530 convenient.
7531
a69fbedb
PE
7532 * image.c (x_allocate_bitmap_record, cache_image):
7533 * xselect.c (Fx_register_dnd_atom):
7534 Simplify previous changes by using xpalloc.
7535
fe5c5d37
PE
7536 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7537 since either will do and ptrdiff_t is convenient with xpalloc.
7538
0065d054
PE
7539 * charset.c (charset_table_size)
7540 (struct charset_sort_data.priority): Now ptrdiff_t.
7541 (charset_compare): Don't overflow if priorities differ greatly.
7542 (Fsort_charsets): Don't assume list length fits in int.
7543 Check for size-calculation overflow when allocating sort data.
7544 (syms_of_charset): Allocate an initial charset table that is
7545 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7546
7547 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7548
7549 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7550 The actual value is always <= INT_MAX, and leaving it unsigned made
7551 overflow checking harder.
7552
7553 * dispextern.h (struct glyph_matrix.rows_allocated)
7554 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7555 with xpalloc. The values are still always <= INT_MAX.
7556
7557 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7558
7559 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7560 (SAFE_NALLOCA): New macro.
7561
7562 * region-cache.c (struct boundary.pos, find_cache_boundary)
7563 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7564 (set_cache_region, invalidate_region_cache)
7565 (revalidate_region_cache, know_region_cache, region_cache_forward)
7566 (region_cache_backward, pp_cache):
7567 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7568 so that ptrdiff_t * can be passed to xpalloc.
7569 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7570 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7571 (pp_cache): Don't assume cache_len fits in int.
7572 * region-cache.h: Adjust extern decls to match.
7573
7574 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7575 EMACS_INT, since either will do, for xpalloc.
7576
7577 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7578 (xnmalloc, xnrealloc, xpalloc): New functions.
7579
726e0ab1
PE
7580 * bidi.c (bidi_shelve_header_size): New constant.
7581 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7582 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7583
51f30bc5 7584 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7585 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7586 (overlay_strings):
7587 Don't update size of array until after memory allocation succeeds,
7588 because xmalloc/xrealloc may not return.
0065d054
PE
7589 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7590 now that we have proper integer overflow checking.
7591 (record_overlay_string, overlay_strings): Catch overflows when
7592 calculating size of overlay_str_buf.
726e0ab1 7593
0065d054
PE
7594 * callproc.c (Fcall_process): Check for size overflow when
7595 calculating size of args2.
7596 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7597 Normally we prefer signed values, but sticking with ptrdiff_t would
7598 require adding more-complicated checks.
726e0ab1
PE
7599
7600 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7601 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7602 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7603 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7604
7605 * character.c (Fstring): Check for size-calculation overflow.
7606
7607 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7608 unnecessary integer overflow. Check for size overflow.
7609 (encode_coding_object): Don't update size until xmalloc succeeds.
7610
7611 * composite.c (get_composition_id): Check for overflow in glyph
7612 length calculations.
7613
7614 Integer and memory overflow fixes for display code.
7615 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7616 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7617 (scrolling_window): Check for overflow in size calculations.
7618 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7619 Don't assume glyph table len fits in int.
7620 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7621 (row_table_size): Now ptrdiff_t, not int.
7622 (scrolling_window): Avoid overflow in size calculations.
7623 Don't update size until allocation succeeds.
7624 * fns.c (concat): Check for overflow in size calculations.
7625 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7626 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7627 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7628
7629 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7630 (get_doc_string): Check for size calculation overflow.
7631 Don't update size until allocation succeeds.
7632 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7633 EMACS_INT, where ptrdiff_t will do.
7634 (Fsubstitute_command_keys): Check for string overflow.
7635
7636 * editfns.c (set_time_zone_rule): Don't assume environment length
7637 fits in int.
7638 (message_length): Now ptrdiff_t, not int.
7639 (Fmessage_box): Don't update size until allocation succeeds.
7640 Don't assume message length fits in int.
7641 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7642
0065d054
PE
7643 * emacs.c (main): Do not reallocate argv, since there is a null at
7644 the end that can be overwritten, and this way there's no need to
7645 worry about size-calculation overflow.
7646 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7647
7648 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7649 alloc succeeds.
7650 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7651
7652 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7653 (x_set_scroll_bar_width, x_figure_window_size):
7654 Check for integer overflow.
7655 (x_set_alpha): Do not assume XINT fits in int.
7656
7657 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7658 This is for the members text_lines, text_cols, total_lines, total_cols,
7659 where the system imposes an 'int' limit.
7660
7661 * fringe.c (Fdefine_fringe_bitmap):
7662 Don't update size until alloc works.
7663
7664 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7665 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7666
7667 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7668 Check for size-calculation overflow.
7669 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7670 do, as we prefer signed integers.
7671 (id_to_widget.max_size, id_to_widget.used)
7672 (xg_store_widget_in_map, xg_remove_widget_from_map)
7673 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7674 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7675 Use and return ptrdiff_t, not int.
7676 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7677 * gtkutil.h: Change prototypes to match the above.
7678
7679 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7680 are duplicate now that they've been promoted to lisp.h.
7681 (x_allocate_bitmap_record, x_alloc_image_color)
7682 (make_image_cache, cache_image, xpm_load):
7683 Don't update size until alloc is done.
7684 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7685 (x_detect_edges):
3256efce 7686 Check for size calculation overflow.
726e0ab1
PE
7687 (ct_colors_allocated_max): New constant.
7688 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7689 overflow.
3256efce 7690
726e0ab1
PE
7691 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7692 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7693 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7694 Use ptrdiff_t, not int, to count maps.
7695 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7696 calculations. Don't update size until allocation succeeds.
7697 Redo calculations to avoid overflow.
726e0ab1
PE
7698 * keyboard.h: Change prototypes to match the above.
7699
7700 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7701 to count maps.
7702 (current_minor_maps): Check for size calculation overflow.
7703 * keymap.h: Change prototypes to match the above.
7704
7705 * lread.c (read1, init_obarray): Don't update size until alloc done.
7706
7707 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7708 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7709
726e0ab1
PE
7710 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7711 Now ptrdiff_t, not int.
7712 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7713 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7714
7715 * process.c (Fnetwork_interface_list): Check for overflow
7716 in size calculation.
7717
7718 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7719
7720 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7721 overflow. Don't bother calling xmalloc when xrealloc will do.
7722
7723 * search.c (Freplace_match): Check for size calculation overflow.
7724 (Fset_match_data): Don't assume list lengths fit in 'int'.
7725
7726 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7727 for command line length. Do not attempt to address one before the
7728 beginning of an array, as that's not portable.
7729
7730 * term.c (max_frame_lines): Remove; unused.
7731 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7732 not int.
7733 (encode_terminal_code, calculate_costs): Check for size
7734 calculation overflow.
7735 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7736 table lengths and related sizes. Don't update size until alloc
7737 done. Redo calculations to avoid overflow.
7738 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7739
7740 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7741 subtracting pointers.
7742 (gobble_line): Check for overflow more carefully. Don't update size
7743 until alloc done.
7744
7745 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7746 Don't update size until alloc done.
7747 Redo size calculations to avoid overflow.
7748 Check for size calculation overflow.
0065d054 7749 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7750
7751 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7752 Use ptrdiff_t, not int, for sizes.
7753 (store_mode_line_noprop_char): Don't update size until alloc done.
7754
0065d054
PE
7755 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7756 Use ptrdiff_t, not int, for sizes.
7757 (Finternal_make_lisp_face, cache_face):
7758 Check for size calculation overflow.
7759 (cache_face): Treat size calculation overflows as if they were
7760 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7761
7762 * xfns.c (x_encode_text, x_set_name_internal)
7763 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7764 sizes, since they can exceed INT_MAX in size. Check for size
7765 calculation overflow.
7766
0065d054
PE
7767 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7768 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7769 Don't update size until alloc done.
7770
0065d054 7771 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7772 as sprintf is limited to int lengths.
1d526e2f 7773
252c5ee1
PE
7774 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7775 (X_LONG_MIN): New macros.
864d7ce7
PE
7776 Use them to make the following changes clearer.
7777 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7778 This change doesn't affect the value now, but it may help remind
7779 future maintainers not to raise the value too much later.
7780 (SELECTION_QUANTUM): Remove, replacing with ...
7781 (selection_quantum): ... new function, which avoids overflow.
7782 All uses changed.
7783 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7784 assumption that selection length fits in 'int'.
7785 (x_reply_selection_request, x_handle_selection_request)
7786 (x_get_window_property, receive_incremental_selection)
7787 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7788 (lisp_data_to_selection_data, clean_local_selection_data):
7789 Use ptrdiff_t, not int, to record length of selection.
7790 (x_reply_selection_request, x_get_window_property)
7791 (receive_incremental_selection, x_property_data_to_lisp):
7792 Redo calculations to avoid overflow.
7793 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7794 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7795 something.
7796 (x_get_window_property, receive_incremental_selection)
7797 (lisp_data_to_selection_data, x_property_data_to_lisp):
7798 Check for size-calculation overflow.
7799 (x_get_window_property, receive_incremental_selection)
7800 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7801 Don't store size until memory allocation succeeds.
7802 (x_get_window_property): Plug memory leak on memory exhaustion.
7803 Don't double-block input; malloc is safe here. Don't assume 2**34
7804 - 4 fits in unsigned long. Add an xassert to check
7805 XGetWindowProperty overflow. Be more careful about overflow
7806 calculations, and distinguish size from memory overflow better.
7807 (receive_incremental_selection): When tracing, don't assume
7808 unsigned int is less than INT_MAX.
7809 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7810 harmful) conversions of unsigned short to int.
7811 (lisp_data_to_selection_data): Don't assume that integers
7812 in the range -65535 through -1 fit in an X unsigned short.
7813 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7814 result parameters unless successful. Rely on cons_to_unsigned
7815 to report problems with elements; the old code wasn't right anyway.
7816 (x_check_property_data): Check for int overflow; we cannot use
7817 a wider type due to X limits.
7818 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7819
726e0ab1 7820 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7821
0065d054
PE
7822 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7823 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7824 (x_color_cells): Don't store size until memory allocation succeeds.
7825 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7826 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7827 (x_term_init): Don't assume length fits in int (sprintf is limited
7828 to int size).
bc18e09d 7829
ebfa62c0
PE
7830 Use ptrdiff_t for composition IDs.
7831 * character.c (lisp_string_width):
7832 * composite.c (composition_table_size, n_compositions)
7833 (get_composition_id, composition_gstring_from_id):
7834 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7835 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7836 * window.c (Frecenter):
7837 Use ptrdiff_t, not int, for composition IDs.
7838 * composite.c (get_composition_id): Check for integer overflow.
7839 * composite.h: Adjust prototypes to match the above changes.
7840
d3411f89
PE
7841 Use ptrdiff_t for hash table indexes.
7842 * category.c (hash_get_category_set):
7843 * ccl.c (ccl_driver):
7844 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7845 * coding.c (coding_system_charset_list, detect_coding_system):
7846 * coding.h (struct coding_system.id):
7847 * composite.c (get_composition_id, gstring_lookup_cache):
7848 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7849 * image.c (xpm_get_color_table_h):
7850 * lisp.h (hash_lookup, hash_put):
7851 * minibuf.c (Ftest_completion):
7852 Use ptrdiff_t for hash table indexes, not int (which is too
7853 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7854 32-bit --with-wide-int hosts).
7855
e097a6fa
PE
7856 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7857 Add a FIXME comment about memory leaks.
7858 (syms_of_charset): Don't assume xmalloc returns.
7859
5637687f
PE
7860 Don't assume that stated character widths fit in int.
7861 * character.c (Fchar_width, c_string_width, lisp_string_width):
7862 * character.h (CHAR_WIDTH):
7863 * indent.c (MULTIBYTE_BYTES_WIDTH):
7864 Use sanitize_char_width to avoid undefined and/or bad behavior
7865 with outlandish widths.
a66cfb1c 7866 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7867 now that we have two such functions. All uses changed.
7868 (sanitize_char_width): New inline function.
7869
a2271ba2
PE
7870 Don't assume that tab-width fits in int.
7871 * character.h (sanitize_width): New inline function.
7872 (SANE_TAB_WIDTH): New macro.
7873 (ASCII_CHAR_WIDTH): Use it.
7874 * indent.c (sane_tab_width): Remove. All uses replaced by
7875 SANE_TAB_WIDTH (current_buffer).
7876 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7877
18c52557
PE
7878 * fileio.c: Integer overflow issues with file modes.
7879 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7880
caeeedc1
PE
7881 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7882 Remove unreachable code.
7883 (read_hex, load_charset_map_from_file): Check for integer overflow.
7884
6df6ae42 7885 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7886 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7887 (x_send_scroll_bar_event): Likewise. Check that the size does not
7888 exceed limits imposed by XClientMessageEvent, as well as the usual
7889 ptrdiff_t and size_t limits.
7890
b13995db
PE
7891 * keyboard.c: Overflow, signedness and related fixes.
7892 (make_lispy_movement): Use same integer type in forward decl
7893 that is used in the definition.
7894 (read_key_sequence, keyremap_step):
7895 Change bufsize argument back to int, undoing my 2011-03-30 change.
7896 We prefer signed types, and int is wide enough here.
7897 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7898 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7899 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7900 length, not size_t. Use ptrdiff_t for index, not int.
7901 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7902 possibility of integer overflow.
7903
13464394
PE
7904 Overflow, signedness and related fixes for images.
7905
7906 * dispextern.h (struct it.stack[0].u.image.image_id)
7907 (struct_it.image_id, struct image.id, struct image_cache.size)
7908 (struct image_cache.used, struct image_cache.ref_count):
7909 * gtkutil.c (update_frame_tool_bar):
7910 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7911 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7912 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7913 * nsmenu.m (update_frame_tool_bar):
7914 * xdisp.c (calc_pixel_width_or_height):
7915 * xfns.c (image_cache_refcount):
7916 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7917 on typical 64-bit hosts.
7918
7919 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7920 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7921 Omit unnecessary casts to int.
7922 (parse_image_spec): Check that integers fall into 'int' range
7923 when the callers expect that.
7924 (image_ascent): Redo ascent calculation to avoid int overflow.
7925 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7926 (lookup_image): Remove unnecessary tests.
7927 (xbm_image_p): Locals are now of int, not EMACS_INT,
7928 since parse_image_check makes sure they fit into int.
7929 (png_load, gif_load, svg_load_image):
7930 Prefer int to unsigned where either will do.
7931 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7932 old tiff_error_handler and tiff_warning_handler.
7933 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7934 stack buffer overflows. It uses only the features of vsnprintf
7935 that are common to both POSIX and native Microsoft.
7936 (tiff_error_handler, tiff_warning_handler): Use it.
7937 (tiff_load, gif_load, imagemagick_load_image):
7938 Don't assume :index value fits in 'int'.
7939 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7940 (imagemagick_load_image): Check that crop parameters fit into
7941 the integer types that MagickCropImage accepts. Don't assume
7942 Vimagemagick_render_type has a nonnegative value. Don't assume
7943 size_t fits in 'long'.
7944 (gs_load): Use printmax_t to print the widest integers possible.
7945 Check for integer overflow when computing image height and width.
7946
c11821d4
EZ
79472011-08-26 Eli Zaretskii <eliz@gnu.org>
7948
7949 * xdisp.c (redisplay_window): Don't force window start if point
7950 will be invisible in the resulting window. (Bug#9324)
7951
0c95fcf7
EZ
79522011-08-25 Eli Zaretskii <eliz@gnu.org>
7953
7954 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7955 the display spec is of the form `(space ...)'.
7956 (handle_display_spec): Return the value returned by
7957 handle_single_display_spec, not just 1 or zero.
7958 (handle_single_display_spec): If the display spec is of the form
7959 `(space ...)', and specifies display in the text area, return 2
7960 rather than 1.
fee65a97 7961 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7962 accurately, and prefer exact match for point under bidi.
7963 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7964
7965 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7966 into disp_prop; all users changed.
7967
7968 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7969 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7970 for the text covered by the display property.
7971
e4ed06f1
CY
79722011-08-25 Chong Yidong <cyd@stupidchicken.com>
7973
7974 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7975 Change return value to nil.
7976 (Frecord_buffer): Delete unused function.
7977
f67cdd7f
EZ
79782011-08-24 Eli Zaretskii <eliz@gnu.org>
7979
5980d4c6
EZ
7980 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7981 buffers, return left-to-right.
8610fe8b
EZ
7982 (set_cursor_from_row): Consider candidate row a win if its glyph
7983 represents a newline and point is on that newline. Fixes cursor
7984 positioning on the newline at EOL of R2L text within L2R
7985 paragraph, and vice versa.
7986 (try_cursor_movement): Check continued rows, in addition to
7987 continuation rows. Fixes unwarranted scroll when point enters a
7988 continued line of R2L text within an L2R paragraph, or vice versa.
7989 (cursor_row_p): Consider the case of point being equal to
7990 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7991 from the end of a short line to the beginning of a continued line
7992 of R2L text within L2R paragraph.
7993 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7994 composed characters.
5980d4c6 7995
f67cdd7f
EZ
7996 * bidi.c (bidi_check_type): Use xassert.
7997 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7998 members.
7999
bca633fb
EZ
80002011-08-23 Eli Zaretskii <eliz@gnu.org>
8001
8002 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8003 a character.
8004
4a5885a7
CY
80052011-08-23 Chong Yidong <cyd@stupidchicken.com>
8006
8007 * nsfont.m (ns_otf_to_script): Fix typo.
8008
0902a04e
KH
80092011-08-22 Kenichi Handa <handa@m17n.org>
8010
8011 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8012 extra slot even if the purpose is char-code-property-table.
8013
1a2e6670
EZ
80142011-08-23 Eli Zaretskii <eliz@gnu.org>
8015
8ddde651
EZ
8016 * xdisp.c (redisplay_window): When computing centering_position,
8017 account for the height of the header line. (Bug#8874)
8018
425cc014
EZ
8019 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8020 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8021 candidate is selected by the mouse, and that candidate has a
8022 composed character under the mouse.
8023
1a2e6670
EZ
8024 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8025 coordinates reported by pos-visible-in-window-p for a composed
8026 character in column zero.
8027
8b76d6f8
SM
80282011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8029
8030 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8031
dac347dd
EZ
80322011-08-22 Eli Zaretskii <eliz@gnu.org>
8033
8034 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8035 consider it a hit if to_charpos is anywhere in the range of the
8036 composed buffer positions.
8037
e013fb34
CY
80382011-08-22 Chong Yidong <cyd@stupidchicken.com>
8039
8040 * image.c (gif_load): Don't assume that each subimage has the same
8041 dimensions as the base image. Handle disposal method that is
8042 "undefined" by the gif spec (Bug#9335).
8043
bd1ba3e8
CY
80442011-08-20 Chong Yidong <cyd@stupidchicken.com>
8045
8046 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8047 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8048
54a1215b
EZ
80492011-08-19 Eli Zaretskii <eliz@gnu.org>
8050
823564e5
EZ
8051 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8052 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8053 from an Org mode buffer to a Speedbar frame.
8054
54a1215b
EZ
8055 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8056 a composition, take its buffer position from IT->cmp_it.charpos.
8057 Fixes cursor positioning at the beginning of a line that begins
8058 with a composed character.
8059
9778ebcc
EZ
80602011-08-18 Eli Zaretskii <eliz@gnu.org>
8061
0be6ee06
EZ
8062 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8063 character bidirectional type, use STRONG_L instead. Fixes crashes
8064 in a buffer produced by `describe-categories'.
8065
9778ebcc
EZ
8066 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8067 members before the level stack, so they would be saved and
8068 restored when copying iterator state. Fixes incorrect reordering
8069 around TABs covered by display properties.
8070
156bffbe
AS
80712011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8072
6b02f655 8073 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8074
72ad093b
CY
80752011-08-17 Chong Yidong <cyd@stupidchicken.com>
8076
8077 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8078 (internal_condition_case_2, internal_condition_case_n):
8079 Remove unnecessary aborts (Bug#9081).
72ad093b 8080
35774242
EZ
80812011-08-17 Eli Zaretskii <eliz@gnu.org>
8082
8083 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8084 has no `load' handler, try opening the file locally. (Bug#9311)
8085
db76dd85
KB
80862011-08-16 Ken Brown <kbrown@cornell.edu>
8087
8088 * gmalloc.c: Expand comment.
8089
b215eee5
EZ
80902011-08-16 Eli Zaretskii <eliz@gnu.org>
8091
8092 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8093 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8094
a4579d33
KB
80952011-08-16 Ken Brown <kbrown@cornell.edu>
8096
8097 Fix memory allocation problems in Cygwin build (Bug#9273).
8098
8099 * unexcw.c ( __malloc_initialized): Declare external variable.
8100 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8101
8b76d6f8
SM
8102 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8103 New variables.
a4579d33
KB
8104 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8105 dumped emacs.
8106 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8107 in the static heap.
8108 [CYGWIN] (special_realloc): New function.
8109 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8110 requests to realloc storage in the static heap.
8111
3ebec551
PE
81122011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8113
8114 * bidi.c (bidi_initialize): Remove unused local.
8115
9fd8be00
EZ
81162011-08-15 Eli Zaretskii <eliz@gnu.org>
8117
6b02f655
SM
8118 * bidimirror.h:
8119 * biditype.h: Remove file.
8120 * makefile.w32-in ($(BLD)/bidi.$(O)):
8121 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8122
8123 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8124
8125 * chartab.c: Improve commentary for the uniprop_table API.
8126
32413314
EZ
8127 * bidi.c (bidi_paragraph_init): Support zero value of
8128 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8129 (bidi_initialize): Use uniprop_table instead of including
8130 biditype.h and bidimirror.h.
32413314 8131
9fd8be00
EZ
8132 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8133 coordinates of the iterator when restoring from ppos_it.
8134 (Bug#9296)
8135
5cf2b69b
KH
81362011-08-14 Kenichi Handa <handa@m17n.org>
8137
8138 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8139 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8140
daf17d00
EZ
81412011-08-14 Eli Zaretskii <eliz@gnu.org>
8142
8143 * xdisp.c (move_it_in_display_line_to): Don't invoke
8144 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8145 ppos_it. Fixes vertical cursor motion when line beginning is
8146 covered by an image. (Bug#9296)
8147
08e3161a
JD
81482011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8149
8150 * nsterm.h (ns_run_ascript): Declare.
8151 (NSAPP_DATA2_RUNASSCRIPT): Define.
8152
8153 * nsfns.m (as_script, as_result, as_status): New static variables.
8154 (ns_run_ascript): New function.
5e617bc2 8155 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8156 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8157 the event loop. Get status from as_status (Bug#7276).
8158
8159 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8160 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8161 the event loop (Bug#7276).
8162
a3720aa2
AS
81632011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8164
8165 * gnutls.c (QCgnutls_bootprop_priority)
8166 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8167 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8168 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8169 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8170 (QCgnutls_bootprop_verify_hostname_error)
8171 (QCgnutls_bootprop_callbacks_verify): Rename from
8172 Qgnutls_bootprop_..., all uses changed.
8173
8174 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8175 uses changed.
8176
0a0d27fb
PE
81772011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8178
19d5c50c
PE
8179 * xfaces.c (Qframe_set_background_mode): Now static.
8180 * dispextern.h (Qframe_set_background_mode): Remove decl.
8181
0a0d27fb
PE
8182 * process.c (Fnetwork_interface_info): Declare local only if needed.
8183
377538cb
JD
81842011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8185
8186 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8187 (Fnetwork_interface_list): Allocate in increments of bytes instead
8188 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8189 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8190 sockaddr.
8191 (struct ifflag_def): notrailers is smart on OSX.
8192 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8193 Get hardware address with getifaddrs if available.
8194
08fff70c
EZ
81952011-08-12 Eli Zaretskii <eliz@gnu.org>
8196
8197 * xdisp.c (iterate_out_of_display_property): xassert that
8198 IT->position is set to within IT->object's boundaries. Break from
8199 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8200 when IT->position is set up wrongly due to some bug.
8201 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8202 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8203 entry. Force push_it to save on the stack the current
8204 buffer/string position, to be restored by pop_it. Fix flags in
8205 the iterator structure wrt the object coming from a display
8206 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8207 properties. (Bug#9284)
8208
7be1c708 82092011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8210
7be1c708
CY
8211 * fontset.c (fontset_get_font_group): Add proper type checks.
8212 (Bug#9172)
aac0c6e3 8213
7be1c708 82142011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8215
7be1c708
CY
8216 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8217 and LC_VERSION_MIN_MACOSX.
8218 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8219 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8220
97bb72a6
EZ
82212011-08-08 Eli Zaretskii <eliz@gnu.org>
8222
8223 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8224 no-display-properties-and-no-overlays under bidi display.
8225 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8226 properties and overlays.
97bb72a6 8227
d5617611
CY
82282011-08-08 Chong Yidong <cyd@stupidchicken.com>
8229
37e11a63
CY
8230 * editfns.c (Fset_time_zone_rule): Document relationship with the
8231 setenv function.
8232
d5617611
CY
8233 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8234 the font entity extracted from the cache (Bug#8109).
8235
58872834
CY
82362011-08-07 Chong Yidong <cyd@stupidchicken.com>
8237
8238 * composite.c (autocmp_chars): Don't reset point. That is done by
8239 restore_point_unwind (Bug#5984).
8240
75bfc667
JL
82412011-08-07 Juri Linkov <juri@jurta.org>
8242
8243 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8244 to show the arg `TIME' instead of `TIMEVAL'.
8245
d1410150
EZ
82462011-08-06 Eli Zaretskii <eliz@gnu.org>
8247
8248 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8249 display property strides EOL and includes a newline, as in
8250 longlines-mode. (Bug#9254)
75b771e4
EZ
8251 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8252 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8253
8254 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8255 is non-zero, even if the data buffer is NULL. Fixes a crash in
8256 vertical-motion with longlines-mode. (Bug#9254)
8257
35928349
EZ
82582011-08-05 Eli Zaretskii <eliz@gnu.org>
8259
ec7cc85b
EZ
8260 * bidi.c <bidi_cache_total_alloc>: Now static.
8261 (bidi_initialize): Initialize bidi_cache_total_alloc.
8262
8b76d6f8 8263 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8264 cache. (Bug#9221)
8265
8266 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8267 amount allocated this far in `bidi_cache_total_alloc'.
8268 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8269 non-zero, only free the data buffer without restoring the cache
8270 contents. All callers changed.
8271
8272 * dispextern.h (bidi_unshelve_cache): Update prototype.
8273
8274 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8275 (move_it_in_display_line, move_it_to)
8276 (move_it_vertically_backward, move_it_by_lines): Replace the call
8277 to xfree to an equivalent call to bidi_unshelve_cache.
8278 (move_it_in_display_line_to): Fix logic of returning
412b6358 8279 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8280
e2e2423b
EZ
82812011-08-05 Eli Zaretskii <eliz@gnu.org>
8282
8283 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8284 came from a string character with a `cursor' property. (Bug#9229)
8285
ae9e757a
JD
82862011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8287
8288 * Makefile.in (LIB_PTHREAD): New variable.
8289 (LIBES): Add LIB_PTHREAD (Bug#9216).
8290
8291 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8292 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8293
213bd7f2
AS
82942011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8295
6b02f655 8296 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8297
99aaf75f
JD
82982011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8299
8300 * xterm.c (x_find_topmost_parent): New function.
8301 (x_set_frame_alpha): Find topmost parent window with
8302 x_find_topmost_parent and set the property there also (bug#9181).
8303 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8304
c74e9d86
PE
83052011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8306
8307 * callproc.c (Fcall_process): Avoid vfork clobbering
8308 the local vars buffer, coding_systems, current_dir.
8309
640c8776
SM
83102011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8311
8312 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8313
f26d0e4c
PE
83142011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8315
8a10d76c
PE
8316 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8317 so that it is not optimized away.
8318
f26d0e4c
PE
8319 * xdisp.c (compute_display_string_pos): Remove unused local.
8320
55439c61
EZ
83212011-08-02 Eli Zaretskii <eliz@gnu.org>
8322
8323 Fix slow cursor motion and scrolling in large buffers with
8324 selective display, like Org Mode buffers. (Bug#9218)
8325
8326 * dispextern.h (struct bidi_it): New member disp_prop_p.
8327
8328 * xdisp.c: Remove one-slot cache of display string positions.
8329 (compute_display_string_pos): Accept an additional argument
5e617bc2 8330 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8331 for a display string or property. If found, set DISP_PROP_P
8332 non-zero.
8333
8334 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8335 DISP_PROP_P, and pass it to compute_display_string_pos.
8336 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8337 non-zero. All callers of bidi_fetch_char changed.
8338
fb33fa43
SM
83392011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8340
8341 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8342
b099e063
DM
83432010-12-03 Don March <don@ohspite.net>
8344
8345 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8346 last character M-[char] is translated to ESC [char] (bug#7541).
8347
5cc7f7af
KH
83482011-08-02 Kenichi Handa <handa@m17n.org>
8349
d0fffa3f 8350 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8351
8352 * chartab.c (uniprop_table): Make it non-static.
8353
525d5e6e
EZ
83542011-08-01 Eli Zaretskii <eliz@gnu.org>
8355
8356 * xdisp.c (forward_to_next_line_start): Accept additional argument
8357 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8358 on the newline.
8359 (reseat_at_next_visible_line_start): Use the bidi iterator state
8360 returned by forward_to_next_line_start to restore the state of
8361 it->bidi_it after backing up to previous newline. (Bug#9212)
8362
31011111
AS
83632011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8364
8365 * regex.c (re_comp): Protoize.
8366 (re_exec): Fix return type.
8367 (regexec): Fix type of `ret'. (Bug#9203)
8368
476371c4
PE
83692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8370
e5d76069
PE
8371 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8372 This is needed if max-image-size is a floating-point number.
8373
9a79b20c
AS
83742011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8375
8376 * print.c (print_object): Print empty symbol as ##.
8377
8378 * lread.c (read1): Read ## as empty symbol.
8379
d8c2fa78
AA
83802011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8381
8382 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8383 setting frame foreground color (Bug#9175).
8384 (x_set_background_color): Likewise.
8385
ffe57a7a
AA
8386 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8387 contents (Bug#9176).
8388 (EmacsTooltip -init): Remove bezels and add shadows to
8389 tooltip windows.
8390
bf3492a5
AA
8391 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8392 or scroll bar (Bug#8470).
8393
d55e9c53
AA
8394 * nsfont.m (nsfont_open): Remove assignment to voffset and
8395 unnecessary vars hshink, expand, hd, full_height, min_height.
8396 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8397
8398 * nsterm.h (nsfont_info): Remove voffset field.
8399
d8c2fa78 84002011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8401
8402 Implement strike-through and overline on NextStep (Bug#8863).
8403
8404 * nsfont.m (nsfont_open): Use underline position provided by font,
8405 instead of hard-coded value of 2.
8406 (nsfont_draw): Call ns_draw_text_decoration instead.
8407
8408 * nsterm.h: Add declaration for ns_draw_text_decoration.
8409
8410 * nsterm.m (ns_draw_text_decoration): New function for drawing
8411 underline, overline, and strike-through.
8412 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8413 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8414 accommodate underlining, etc.
4843aac3 8415
4cc60b9b
EZ
84162011-07-28 Eli Zaretskii <eliz@gnu.org>
8417
bc7ece87
EZ
8418 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8419 default.
4cc60b9b 8420
476371c4
PE
84212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8422
66606eea
PE
8423 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8424 Without this fix, if a signal arrives just after memory fills up,
8425 'malloc' might be invoked reentrantly.
8426
476371c4
PE
8427 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8428 In other words, assume that every image size is allowed, on non-X
8429 hosts. This assumption is probably wrong, but it lets Emacs compile.
8430
f3fcc40d
AS
84312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8432
8433 * regex.c (re_iswctype): Convert return values to boolean.
8434
350c992f
EZ
84352011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8436
8437 * xdisp.c (compute_display_string_pos): Don't use cached display
8438 string position if the buffer had its restriction changed.
8439 (Bug#9184)
8440
5266b4bb
PE
84412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8442
8443 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8444
2573a837 84452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8446
41f55ccd 8447 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8448
39e378da
PE
8449 * bidi.c: Integer size and overflow fixes.
8450 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8451 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8452 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8453 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8454 (bidi_find_other_level_edge):
8455 Use ptrdiff_t instead of EMACS_INT where either will do.
8456 This works better on 32-bit hosts configured --with-wide-int.
8457 (bidi_cache_ensure_space): Check for size-calculation overflow.
8458 Use % rather than repeated addition, for better worst-case speed.
8459 Don't set bidi_cache_size until after xrealloc returns, because it
8460 might not return.
8461 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8462 (bidi_cache_ensure_space): Also check that the bidi cache size
8463 does not exceed that of the largest Lisp string or buffer. See Eli
8464 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8465
5e927815
PE
8466 * alloc.c (__malloc_size_t): Remove.
8467 All uses replaced by size_t. See Andreas Schwab's note
8468 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8469
ca4aa935
PE
8470 * image.c: Improve checking for integer overflow.
8471 (check_image_size): Assume that f is nonnull, since
8472 it is always nonnull in practice. This is one less thing to
8473 worry about when checking for integer overflow later.
8474 (x_check_image_size): New function, which checks for integer
8475 overflow issues inside X.
8476 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8477 This removes the need for a memory_full check.
8478 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8479 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8480 (xbm_read_bitmap_data): Change locals back to 'int', since
8481 their values must fit in 'int'.
8482 (xpm_load_image, png_load, tiff_load):
8483 Invoke x_create_x_image_and_pixmap earlier,
8484 to avoid much needless work if the image is too large.
8485 (tiff_load): Treat overly large images as if
8486 x_create_x_image_and_pixmap failed, not as malloc failures.
8487 (gs_load): Use x_check_image_size.
8488
5f8f9cc2
PE
8489 * gtkutil.c: Omit integer casts.
8490 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8491 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8492
5adf60bc
PE
8493 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8494
c8907a93
PE
8495 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8496 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8497 would wrongly return t on a 64-bit host.
8498
e3c25c68
PE
8499 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8500 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8501 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8502 and therefore cause GCC to emit a bogus diagnostic in some cases.
8503
3f791afe
PE
8504 * image.c: Integer signedness and overflow and related fixes.
8505 This is not an exhaustive set of fixes, but it's time to
8506 record what I've got.
8507 (lookup_pixel_color, check_image_size): Remove redundant decls.
8508 (check_image_size): Don't assume that arbitrary EMACS_INT values
8509 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8510 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8511 (tiff_load, imagemagick_load_image):
8512 Check for overflow in size calculations.
8513 (x_create_x_image_and_pixmap): Remove unnecessary test for
8514 xmalloc returning NULL; that can't happen.
8515 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8516 (xpm_color_bucket): Use better integer hashing function.
8517 (xpm_cache_color): Don't possibly over-allocate memory.
8518 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8519 (gif_memory_source):
8520 Use ptrdiff_t, not int or size_t, to record sizes.
8521 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8522 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8523 either works, as we prefer signed integers.
8524 (tiff_read_from_memory, tiff_write_from_memory):
8525 Return tsize_t, not size_t, since that's what the TIFF API wants.
8526 (tiff_read_from_memory): Don't fail simply because the read would
8527 go past EOF; instead, return a short read.
8528 (tiff_load): Omit no-longer-needed casts.
8529 (Fimagemagick_types): Don't assume size fits into 'int'.
8530
3cc5a532
PE
8531 Improve hashing quality when configured --with-wide-int.
8532 * fns.c (hash_string): New function, taken from sxhash_string.
8533 Do not discard information about ASCII character case; this
8534 discarding is no longer needed.
8535 (sxhash-string): Use it. Change sig to match it. Caller changed.
8536 * lisp.h: Declare it.
8537 * lread.c (hash_string): Remove, since we now use fns.c's version.
8538 The fns.c version returns a wider integer if --with-wide-int is
8539 specified, so this should help the quality of the hashing a bit.
8540
b312a492
PE
8541 * emacs.c: Integer overflow minor fix.
8542 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8543 Define only if GNU_LINUX.
8544 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8545
dfd153ae
PE
8546 * dispnew.c: Integer signedness and overflow fixes.
8547 Remove unnecessary forward decls, that were a maintenance hassle.
8548 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8549 All uses changed.
8550 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8551 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8552 (prepare_desired_row, line_draw_cost):
8553 Use int, not unsigned, where either works.
8554 (save_current_matrix, restore_current_matrix):
8555 Use ptrdiff_t, not size_t, where either works.
8556 (init_display): Check for overflow more accurately, and without
8557 relying on undefined behavior.
8558
a81d11a3
PE
8559 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8560 Remove, replacing with the new symbols in lisp.h. All uses changed.
8561 * fileio.c (make_temp_name):
8562 * filelock.c (lock_file_1, lock_file):
8563 * xdisp.c (message_dolog):
8564 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8565 Use pMd etc. instead.
8566 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8567 replacing the pWIDE etc. symbols removed from editfns.c.
8568
3300e6fd
PE
8569 * keyboard.h (num_input_events): Now uintmax_t.
8570 This is (very slightly) less likely to mess up due to wraparound.
8571 All uses changed.
8572
fd05c7e9
PE
8573 * buffer.c: Integer signedness fixes.
8574 (alloc_buffer_text, enlarge_buffer_text):
8575 Use ptrdiff_t rather than size_t when either will do, as we prefer
8576 signed integers.
8577
903fe15d
PE
8578 * alloc.c: Integer signedness and overflow fixes.
8579 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8580 (__malloc_size_t): Default to size_t, not to int.
8581 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8582 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8583 Prefer ptrdiff_t to size_t when either would do, as we prefer
8584 signed integers.
8585 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8586 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8587 Now const. Initialize with values that are in range even if char
8588 is signed.
8589 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8590 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8591 These functions do the right thing with sizes > 2**32.
8592 (check_depth): Now ptrdiff_t, not int.
8593 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8594 Adjust to new way of storing sizes. Check for size overflow bugs
8595 in rest of code.
8596 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8597 slightly wrong anyway, as it missed one instance of
8598 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8599 (refill_memory_reserve): Omit needless cast to size_t.
8600 (mark_object_loop_halt): Mark as externally visible.
8601
ac82cc6a
PE
8602 * xselect.c: Integer signedness and overflow fixes.
8603 (Fx_register_dnd_atom, x_handle_dnd_message):
8604 Use ptrdiff_t, not size_t, since we prefer signed.
8605 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8606 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8607 x_dnd_atoms_size and x_dnd_atoms_length.
8608
c2d1e36d
PE
8609 * doprnt.c: Prefer signed to unsigned when either works.
8610 * eval.c (verror):
8611 * doprnt.c (doprnt):
8612 * lisp.h (doprnt):
8613 * xdisp.c (vmessage):
8614 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8615 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8616 prefer signed arithmetic to avoid comparison confusion.
8617 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8618 but is a bit tricky.
8619
0e926e56
PE
8620 Assume freestanding C89 headers, string.h, stdlib.h.
8621 * data.c, doprnt.c, floatfns.c, print.c:
8622 Include float.h unconditionally.
8623 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8624 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8625 * regex.c: Likewise for stddef.h, string.h.
8626 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8627 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8628 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8629 (STDC_HEADERS): Remove obsolete defines.
8630 * sysdep.c: Include limits.h unconditionally.
8631
9cfdb3ec
PE
8632 Assume support for memcmp, memcpy, memmove, memset.
8633 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8634 * regex.c (memcmp, memcpy):
8635 Remove; we assume C89 now.
8636
8637 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8638 (__malloc_safe_bcopy): Remove; no longer needed.
8639
cf950e6b 8640 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8641 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8642 well either way, and we prefer signed to unsigned.
8643
dbf38e02
LMI
86442011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8645
8646 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8647 closes the connection while we're reading (bug#9182).
8648
d6f0886c 86492011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8650
d6f0886c
JD
8651 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8652 are specified (Bug#9168).
24e0f6b1 8653
2eb1f9e6
PE
86542011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8655
8656 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8657 Found by GCC static checking and --with-wide-int on a 32-bit host.
8658
22381272 86592011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8660
8661 * xdisp.c (compute_display_string_pos): Fix logic of caching
8662 previous display string position. Initialize cached_prev_pos to
8663 -1. Fixes slow-down at the beginning of a buffer.
8664
f25e39b4
EZ
86652011-07-24 Eli Zaretskii <eliz@gnu.org>
8666
8667 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8668 for attrs[LFACE_FONTSET_INDEX].
8669
04c4b52e
PE
86702011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8671
8672 * xml.c (parse_region): Remove unused local
8673 that was recently introduced.
8674
c1734fbd
EZ
86752011-07-23 Eli Zaretskii <eliz@gnu.org>
8676
be18c5a5
EZ
8677 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8678 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8679
c1734fbd
EZ
8680 * xdisp.c (move_it_in_display_line_to): Record the best matching
8681 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8682 exit if none of the characters scanned was an exact match.
8683 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8684 when exact match is impossible due to invisible text, and the
8685 lines are truncated.
8686
a258d627
JD
86872011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8688
8689 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8690 for OSX >= 10.7.
8691
b6d5a689
EZ
86922011-07-22 Eli Zaretskii <eliz@gnu.org>
8693
0f74f785
EZ
8694 Fix a significant slow-down of cursor motion with C-n, C-p,
8695 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8696 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8697 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8698 (next_element_from_buffer): Call compute_stop_pos_backwards to
8699 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8700 base_level_stop.
8701 (reseat): Don't look for prev_stop, as that could mean a very long
8702 run.
8703 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8704 <cached_disp_overlay_modiff>: Cache for last found display string
8705 position.
551918c1 8706 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8707 about the same buffer in the same area of character positions, and
8708 the buffer wasn't changed since the time the display string
8709 position was cached.
551918c1 8710
b2d0c91a
EZ
87112011-07-22 Eli Zaretskii <eliz@gnu.org>
8712
8713 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8714 is an integer, which is important for empty lines. (Bug#9149)
8715
043604ee
CY
87162011-07-22 Chong Yidong <cyd@stupidchicken.com>
8717
8718 * frame.c (Fmodify_frame_parameters): In tty case, update the
8719 default face if necessary (Bug#4238).
8720
da4adb04
CY
87212011-07-21 Chong Yidong <cyd@stupidchicken.com>
8722
8723 * editfns.c (Fstring_to_char): No need to explain what a character
8724 is in the docstring (Bug#6576).
8725
9abd0532
LMI
87262011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8727
8728 * xml.c (parse_region): Make sure we always return a tree.
8729
36881d16
HK
87302011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8731
8732 * xml.c (parse_region): If a document contains only comments,
8733 return that, too.
8734
1e98674d
LMI
87352011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8736
8737 * xml.c (make_dom): Return comments, too.
8738
590bd467
PE
87392011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8740
8741 Port to OpenBSD.
8742 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8743 and the surrounding thread.
8744 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8745 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8746 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8747 timer goes off.
8748 * s/openbsd.h (BROKEN_SIGIO): Define.
8749 * unexelf.c (unexec) [__OpenBSD__]:
8750 Don't update the .mdebug section of the Alpha COFF symbol table.
8751
f41628b2
LMI
87522011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8753
8754 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8755 (bug#8460).
8756
b59b67c5
PE
87572011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8758
15e3a074
PE
8759 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8760 This fixes some race conditions on the permissions of any newly
8761 created file.
8762
41bed37d
PE
8763 * alloc.c (valid_pointer_p): Use pipe, not open.
8764 This fixes some permissions issues when debugging.
8765
b59b67c5
PE
8766 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8767 If fchown fails to set both uid and gid, try to set just gid,
8768 as that is sometimes allowed. Adjust the file's mode to eliminate
8769 setuid or setgid bits that are inappropriate if fchown fails.
8770
925a6be7
SM
87712011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8772
8773 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8774 to compare Lisp_Objects.
8775 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8776 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8777 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8778
52968808
AS
87792011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8780
0a6a104b
AS
8781 * lread.c (read_integer): Unread even EOF character.
8782 (read1): Likewise. Properly record start position of symbol.
8783
52968808
AS
8784 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8785 symbol character follows.
8786
9e381cdd
PE
87872011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8788
8789 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8790 This works around a problem with the previous change to Fcopy_file.
8791 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8792 and without this change, GCC might complain about discarding
8793 fchown's return value.
8794
b5641435
JB
87952011-07-16 Juanma Barranquero <lekktu@gmail.com>
8796
8797 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8798
a8031457
PE
87992011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8800
8801 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8802
dd889327
LMI
88032011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8804
750c33f7
LMI
8805 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8806 it's used from the C level.
8807
dd889327
LMI
8808 * process.c: Use the same condition for POLL_FOR_INPUT in both
8809 keyboard.c and process.c (bug#1858).
8810
87e86684
LM
88112011-07-09 Lawrence Mitchell <wence@gmx.li>
8812
8813 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8814 (Fgnutls_boot): Use it.
8815
64348f40
AS
88162011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8817
8818 * doc.c (Fsubstitute_command_keys): Revert last change.
8819
1d698799
LMI
88202011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8821
f863868c
LMI
8822 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8823 quotes the next character, and doesn't affect other longer
8824 sequences (bug#8935).
8825
1d698799
LMI
8826 * lread.c (syms_of_lread): Clarify that is isn't only
8827 `eval-buffer' and `eval-defun' that's affected by
8828 `lexical-binding' (bug#8460).
8829
aa4b6df6
EZ
88302011-07-15 Eli Zaretskii <eliz@gnu.org>
8831
8832 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8833 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8834
5d856da6
PE
88352011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8836
ad6042bb
PE
8837 Fix minor problems found by static checking.
8838 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8839 (elsz): Now a signed constant, not a size_t var. We prefer signed
8840 types to unsigned, to avoid integer comparison confusion. Without
8841 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8842 "cannot optimize loop, the loop counter may overflow", a symptom
8843 of the confusion.
f00bbb22 8844 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8845 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8846
6468f31c
LMI
88472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8848
49080b10
LMI
8849 * search.c (Fre_search_backward): Mention `case-fold-search' in
8850 all the re_search_* functions (bug#8138).
8851
6468f31c
LMI
8852 * keyboard.c (Fopen_dribble_file): Document when the file is
8853 closed (bug#8056).
8854
c965adc5
EZ
88552011-07-14 Eli Zaretskii <eliz@gnu.org>
8856
df9733bf
EZ
8857 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8858 bidi_cache_idx.
8859
0bb23927
EZ
8860 Support bidi reordering of display and overlay strings.
8861 * xdisp.c (compute_display_string_pos)
8862 (compute_display_string_end): Accept additional argument STRING.
8863 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8864 (reseat_to_string): Initialize bidi_it->string.s and
8865 bidi_it->string.schars.
8866 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8867 NULL (avoids a crash in bidi_paragraph_init).
8868 Initialize itb.string.lstring.
0bb23927
EZ
8869 (init_iterator): Call bidi_init_it only of a valid
8870 buffer position was specified. Initialize paragraph_embedding to
8871 L2R.
8872 (reseat_to_string): Initialize the bidi iterator.
8873 (display_string): If we need to ignore text properties of
8874 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8875 original value of -1 will not work with bidi.)
8876 (compute_display_string_pos): First arg is now struct
8877 `text_pos *'; all callers changed. Support display properties on
8878 Lisp strings.
8879 (compute_display_string_end): Support display properties on Lisp
8880 strings.
8881 (init_iterator, reseat_1, reseat_to_string): Initialize the
8882 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8883 when iterating on a string not from display properties).
640c8776
SM
8884 (compute_display_string_pos, compute_display_string_end):
8885 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8886 arrow keys.
8887 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8888 base_level_stop; instead, set base_level_stop to BEGV.
8889 Fixes crashes in vertical-motion.
0bb23927
EZ
8890 (next_element_from_buffer): Improve commentary for when
8891 the iterator is before prev_stop.
8892 (init_iterator): Initialize bidi_p from the default value of
8893 bidi-display-reordering, not from buffer-local value. Use the
8894 buffer-local value only if initializing for buffer iteration.
8895 (handle_invisible_prop): Support invisible properties on strings
8896 that are being bidi-reordered.
8897 (set_iterator_to_next): Support bidi reordering of C strings and
8898 Lisp strings.
8899 (next_element_from_string): Support bidi reordering of Lisp
8900 strings.
8901 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8902 (display_string): Support display of R2L glyph rows.
8903 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8904 (init_iterator): Don't initialize it->bidi_p for strings
8905 here.
8906 (reseat_to_string): Initialize it->bidi_p for strings here.
8907 (next_element_from_string, next_element_from_c_string)
8908 (next_element_from_buffer): Add xassert's for correspondence
8909 between IT's object being iterated and it->bidi_it.string
8910 structure.
8911 (face_before_or_after_it_pos): Support bidi iteration.
8912 (next_element_from_c_string): Handle the case of the first string
8913 character that is not the first one in the visual order.
8914 (get_visually_first_element): New function, refactored from common
8915 parts of next_element_from_buffer, next_element_from_string, and
8916 next_element_from_c_string.
8917 (tool_bar_lines_needed, redisplay_tool_bar)
8918 (display_menu_bar): Force left-to-right direction. Add a FIXME
8919 comment for making that be controlled by a user option.
8920 (push_it, pop_it): Save and restore the state of the
8921 bidi iterator. Save and restore the bidi_p flag.
8922 (pop_it): Iterate out of display property for string iteration as
8923 well.
8924 (iterate_out_of_display_property): Support iteration over strings.
8925 (handle_single_display_spec): Set up it->bidi_it for iteration
8926 over a display string, and call bidi_init_it.
8927 (handle_single_display_spec, next_overlay_string)
8928 (get_overlay_strings_1, push_display_prop): Set up the bidi
8929 iterator for displaying display or overlay strings.
8930 (forward_to_next_line_start): Don't use the shortcut if
8931 bidi-iterating.
8932 (back_to_previous_visible_line_start): If handle_display_prop
8933 pushed the iterator stack, restore the internal state of the bidi
8934 iterator by calling bidi_pop_it same number of times.
8935 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8936 and we are bidi-iterating, don't decrement the iterator position;
8937 instead, set the first_elt flag in the bidi iterator, to produce
8938 the same effect.
8939 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8940 (push_display_prop): xassert that we are iterating a buffer.
8941 (push_it, pop_it): Save and restore paragraph_embedding member.
8942 (handle_single_display_spec, next_overlay_string)
8943 (get_overlay_strings_1, reseat_1, reseat_to_string)
8944 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8945 correctly. Don't assume unibyte strings are not bidi-reordered.
8946 (compute_display_string_pos)
8947 (compute_display_string_end): Fix handling the case of C string.
8948 (push_it, pop_it): Save and restore from_disp_prop_p.
8949 (handle_single_display_spec, push_display_prop): Set the
8950 from_disp_prop_p flag.
8951 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8952 (pop_it): Call iterate_out_of_display_property only if we are
8953 popping after iteration over a string that came from a display
8954 property. Fix a typo in popping stretch info. Add an assertion
8955 for verifying that the iterator position is in sync with the bidi
8956 iterator.
8957 (handle_single_display_spec, get_overlay_strings_1)
8958 (push_display_prop): Fix initialization of paragraph direction for
8959 string when that of the parent object is not yet determined.
8960 (reseat_1): Call bidi_init_it to resync the bidi
8961 iterator with IT's position. (Bug#7616)
8962 (find_row_edges): If ROW->start.pos gives position
8963 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8964 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8965 Reset the from_disp_prop_p flag.
8966 (SAVE_IT, RESTORE_IT): New macros.
8967 (pos_visible_p, face_before_or_after_it_pos)
8968 (back_to_previous_visible_line_start)
8969 (move_it_in_display_line_to, move_it_in_display_line)
8970 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8971 (try_scrolling, redisplay_window, display_line): Use them when
8972 saving a temporary copy of the iterator and restoring it back.
8973 (back_to_previous_visible_line_start, reseat_1)
8974 (init_iterator): Empty the bidi cache "stack".
8975 (move_it_in_display_line_to): If iterator ended up at
8976 EOL, but we never saw any buffer positions smaller than
8977 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8978 motion in bidi-reordered lines.
8979 (move_it_in_display_line_to): Record prev_method and prev_pos
8980 immediately before the call to set_iterator_to_next. Fixes cursor
8981 motion in bidi-reordered lines with stretch glyphs and strings
8982 displayed in margins. (Bug#8133) (Bug#8867)
8983 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8984 TO_CHARPOS.
640c8776
SM
8985 (pos_visible_p): Support positions in bidi-reordered lines.
8986 Save and restore bidi cache.
0bb23927
EZ
8987
8988 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8989 (bidi_paragraph_info): Delete unused struct.
8990 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8991 (bidi_cache_start): New variable.
8992 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8993 to zero.
8994 (bidi_cache_fetch_state, bidi_cache_search)
8995 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8996 (bidi_cache_find, bidi_peek_at_next_level)
8997 (bidi_level_of_next_char, bidi_find_other_level_edge)
8998 (bidi_move_to_visually_next): Compare cache index with
8999 bidi_cache_start rather than with zero.
9000 (bidi_fetch_char): Accept new argument STRING; all callers
9001 changed. Support iteration over a string. Support strings with
9002 display properties. Support unibyte strings. Fix the type of
9003 `len' according to what STRING_CHAR_AND_LENGTH expects.
9004 (bidi_paragraph_init, bidi_resolve_explicit_1)
9005 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9006 (bidi_level_of_next_char, bidi_move_to_visually_next):
9007 Support iteration over a string.
0bb23927
EZ
9008 (bidi_set_sor_type, bidi_resolve_explicit_1)
9009 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9010 can now be zero (for strings); special values 0 and -1 were
9011 changed to -1 and -2, respectively.
9012 (bidi_char_at_pos): New function.
9013 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9014 Call it instead of FETCH_MULTIBYTE_CHAR.
9015 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9016 initialized to valid values.
9017 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9018 values.
9019 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9020 the test for valid cached positions. Fix the logic for looking up
9021 the sentinel state in the cache. GCPRO the Lisp string we are
9022 iterating.
9023 (bidi_push_it, bidi_pop_it): New functions.
9024 (bidi_initialize): Initialize the bidi cache start stack pointer.
9025 (bidi_cache_ensure_space): New function, refactored from part of
9026 bidi_cache_iterator_state. Don't assume the required size is just
9027 one BIDI_CACHE_CHUNK away.
9028 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9029 (bidi_count_bytes, bidi_char_at_pos): New functions.
9030 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9031 always valid if bidi_cache_idx is valid.
9032 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9033 is valid if it's going to be used.
9034 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9035 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9036 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9037 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9038 (bidi_find_other_level_edge, bidi_cache_start_stack):
9039 All variables related to cache indices are now EMACS_INT.
c965adc5 9040
0bb23927
EZ
9041 * dispextern.h (struct bidi_string_data): New structure.
9042 (struct bidi_it): New member `string'. Make flag members be 1-bit
9043 fields, and put them last in the struct.
640c8776
SM
9044 (compute_display_string_pos, compute_display_string_end):
9045 Update prototypes.
0bb23927
EZ
9046 (bidi_push_it, bidi_pop_it): Add prototypes.
9047 (struct iterator_stack_entry): New members bidi_p,
9048 paragraph_embedding, and from_disp_prop_p.
9049 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9050 (bidi_shelve_cache, bidi_unshelve_cache):
9051 Declare prototypes.
0bb23927
EZ
9052
9053 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9054 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9055 and vector-like objects.
9056
9057 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9058 cache around display iteration.
9059
9060 * window.c (Fwindow_end, window_scroll_pixel_based)
9061 (displayed_window_lines, Frecenter): Save and restore the bidi
9062 cache around display iteration.
9063
3bbd2265
LMI
90642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9065
9066 * editfns.c (Fdelete_region): Clarify the use of the named
9067 parameters (bug#6788).
9068
adc47434
MR
90692011-07-14 Martin Rudalics <rudalics@gmx.at>
9070
9071 * indent.c (Fvertical_motion): Set and restore w->pointm when
9072 saving and restoring the window's buffer (Bug#9006).
9073
837c31f8
LMI
90742011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9075
9076 * editfns.c (Fstring_to_char): Clarify just what is returned
9077 (bug#6576). Text by Eli Zaretskii.
9078
ac389d0c
JB
90792011-07-13 Juanma Barranquero <lekktu@gmail.com>
9080
9081 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9082
0be0ce47
EZ
90832011-07-13 Eli Zaretskii <eliz@gnu.org>
9084
9085 * buffer.c (mmap_find): Fix a typo.
9086
cd18e7e3
JB
90872011-07-13 Johan Bockgård <bojohan@gnu.org>
9088
9089 Fix execution of x selection hooks.
9090 * xselect.c (Qx_lost_selection_functions)
9091 (Qx_sent_selection_functions): New vars.
9092 (syms_of_xselect): DEFSYM them.
9093 (x_handle_selection_request): Pass Qx_sent_selection_functions
9094 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9095 (x_handle_selection_clear,x_clear_frame_selections):
9096 Pass Qx_lost_selection_functions rather than
9097 Vx_lost_selection_functions to Frun_hook_with_args.
9098
47ea7f44
PE
90992011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9100
ac389d0c 9101 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9102 The old code sometimes used this field without initializing it.
9103
47ea7f44
PE
9104 * alloc.c (gc_sweep): Don't read past end of array.
9105 In theory, the old code could also have corrupted Emacs internals,
9106 though it'd be very unlikely.
9107
bc985c87
AS
91082011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9109
9110 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9111 argument. (Bug#4026)
bc985c87 9112
0cf34688
LMI
91132011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9114
b3dadd76
LMI
9115 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9116 key" (bug#4257).
9117
0cf34688
LMI
9118 * window.c (Fset_window_start): Doc fix (bug#4199).
9119 (Fset_window_hscroll): Ditto.
9120
270768cd
PE
91212011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9122
077e3dda 9123 Fix minor new problems caught by GCC 4.6.1.
270768cd 9124 * term.c (init_tty): Remove unused local.
490011a6 9125 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9126 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9127 not used otherwise.
270768cd 9128
b1f58454
CY
91292011-07-12 Chong Yidong <cyd@stupidchicken.com>
9130
9131 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9132
22b9578d
LMI
91332011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9134
6e70ab07
LMI
9135 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9136 are the mini-buffer and the echo area (bug#3320).
9137
22b9578d
LMI
9138 * term.c (init_tty): Remove support for supdup, c10 and perq
9139 terminals, which are no longer supported (bug#1482).
9140
8974cc9f
JB
91412011-07-10 Johan Bockgård <bojohan@gnu.org>
9142
9143 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9144
a560d974
JD
91452011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9146
9147 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9148 for non-popups (Bug#3642).
9149
1dae0f0a
AS
91502011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9151
268c2c36 9152 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9153 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9154 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9155 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9156 * data.c (fmod): Likewise.
9157 * dispnew.c (swap_glyphs_in_rows): Likewise.
9158 * emacs.c (memory_warning_signal): Likewise.
9159 * floatfns.c (float_error): Likewise.
9160 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9161 (otf_open, font_otf_capability, generate_otf_features)
9162 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9163 Likewise.
9164 * image.c (pbm_read_file): Likewise.
9165 * indent.c (string_display_width): Likewise.
9166 * intervals.c (check_for_interval, search_for_interval)
9167 (inc_interval_count, count_intervals, root_interval)
9168 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9169 * lread.c (defalias): Likewise.
268c2c36 9170 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9171 * regex.c (set_image_of_range_1, set_image_of_range)
9172 (regex_grow_registers): Likewise.
9173 * sysdep.c (strerror): Likewise.
9174 * termcap.c (valid_filename_p, tprint, main): Likewise.
9175 * tparam.c (main): Likewise.
9176 * unexhp9k800.c (run_time_remap, save_data_space)
9177 (update_file_ptrs, read_header, write_header, calculate_checksum)
9178 (copy_file, copy_rest, display_header): Likewise.
9179 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9180 Likewise.
9181 * xdisp.c (check_it): Likewise.
9182 * xfaces.c (register_color, unregister_color, unregister_colors):
9183 Likewise.
9184 * xfns.c (print_fontset_result): Likewise.
9185 * xrdb.c (member, fatal, main): Likewise.
9186
99033785
PE
91872011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9188
9189 Fix minor problems found by static checking (Bug#9031).
9190 * chartab.c (char_table_set_range, map_sub_char_table):
9191 Remove unused locals.
9192 (uniprop_table): Now static.
9193 * composite.c (_work_char): Remove unused static var.
9194
9cb2ac56
JB
91952011-07-09 Juanma Barranquero <lekktu@gmail.com>
9196
9197 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9198
f25661f0
JD
91992011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9200
9201 * gtkutil.c (qttip_cb): Remove code without function.
9202
8278c4fe
EZ
92032011-07-09 Eli Zaretskii <eliz@gnu.org>
9204
9205 * w32.c (pthread_sigmask): New stub.
9206
1692ae2d 92072011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9208
8a6ebd58 9209 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9210 sigprocmask is portable only for single-threaded applications, and
9211 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9212 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9213 (LIBES): Use it.
9214 * callproc.c (Fcall_process):
9215 * process.c (create_process):
9216 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9217 Use pthread_sigmask, not sigprocmask.
123403e4 9218
1b854618
JD
92192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9220
9221 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9222 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9223 wrong (Bug#8591).
9224
3fe4b549
JD
92252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9226
0ce7e563
JD
9227 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9228 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9229 (xg_hide_tooltip): Fix comment.
9230
3fe4b549
JD
9231 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9232 in registerServicesMenuSendTypes.
9233 (validRequestorForSendType): Don't check ns_return_types.
9234
9235 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9236 ns_return_type.
9237
5df75e47
JR
92382011-07-08 Jason Rumney <jasonr@gnu.org>
9239
22610910
JR
9240 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9241 SH_SHOW for hidden windows (Bug#5482).
9242
5df75e47
JR
9243 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9244 frame struct members of non-existent frames (Bug#6284).
9245
699c10bd
JD
92462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9247
4393663b
JD
9248 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9249 variable firstTime not needed on OSX >= 10.6.
9250 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9251 >= 10.5. Use setKnobProportion, setDoubleValue.
9252
9253 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9254 (MAC_OS_X_VERSION_10_5): Define if not defined.
9255 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9256 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9257 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9258
9259 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9260 cString and lossyCString on OSX >= 10.4.
4393663b 9261
58179cce 9262 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9263 sizeToFit on OSX >= 10.2.
9264
9265 * nsimage.m (allocInitFromFile): Don't use deprecated method
9266 bestRepresentationForDevice on OSX >= 10.6.
9267
9268 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9269 to avoid warning.
9270
9271 * emacs.c: Declare unexec_init_emacs_zone.
9272
a63e0781
JD
9273 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9274
699c10bd
JD
9275 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9276
9277 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9278 on svcsMenu (Bug#8842).
9279
9280 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9281 ns_return_types.
9282 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9283
9284 * nsterm.m (QUTF8_STRING): Declare.
9285 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9286 (validRequestorForSendType): Return type is (id).
9287 Change indexOfObjectIdenticalTo to indexOfObject.
9288 Check if we have local selection before returning self (Bug#8842).
9289 (writeSelectionToPasteboard): Put local selection into paste board
9290 if we have a local selection (Bug#8842).
9291 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9292
9293 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9294 (ns_get_local_selection): Declare.
9295
54e10184
LMI
92962011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9297
9888ff71
LMI
9298 * keymap.c (describe_map_tree): Don't insert a double newline at
9299 the end of the buffer (bug#1169) and return whether we inserted
9300 something.
9301
54e10184
LMI
9302 * callint.c (Fcall_interactively): Change "reading args" to
9303 "providing args" to try to clarify what it does (bug#1010).
9304
15fa4783
KH
93052011-07-07 Kenichi Handa <handa@m17n.org>
9306
9307 * composite.c (composition_compute_stop_pos): Ignore a static
9308 composition starting before CHARPOS (Bug#8915).
9309
9310 * xdisp.c (handle_composition_prop): Likewise.
9311
a8815b00
EZ
93122011-07-07 Eli Zaretskii <eliz@gnu.org>
9313
9314 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9315 (Bug#9015)
9316
ef7b981d 93172011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9318
9319 * character.h (unicode_category_t): New enum type.
9320
9321 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9322 (Qchar_code_property_table): New variable.
9323 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9324 (UNIPROP_COMPRESSED_FORM_P): New macros.
9325 (char_table_ascii): Uncompress the compressed values.
9326 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9327 Uncompress the compressed values.
ac389d0c 9328 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9329 (char_table_ref_and_range): Uncompress the compressed values.
9330 (sub_char_table_set): New arg is_uniprop. Callers changed.
9331 Uncompress the compressed values.
9332 (sub_char_table_set_range): Args changed. Callers changed.
9333 (char_table_set_range): Adjuted for the above change.
9334 (map_sub_char_table): Delete args default_val and parent. Add arg
9335 top. Give decoded values to a Lisp function.
640c8776 9336 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9337 values to a Lisp function. Gcpro more variables.
9338 (uniprop_table_uncompress)
9339 (uniprop_decode_value_run_length): New functions.
9340 (uniprop_decoder, uniprop_decoder_count): New variables.
9341 (uniprop_get_decoder, uniprop_encode_value_character)
9342 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9343 New functions.
9344 (uniprop_encoder, uniprop_encoder_count): New variables.
9345 (uniprop_get_encoder, uniprop_table)
9346 (Funicode_property_table_internal, Fget_unicode_property_internal)
9347 (Fput_unicode_property_internal): New functions.
9348 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9349 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9350 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9351 char-code-property-alist.
9352
640c8776 9353 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9354 Vunicode_category_table.
9355
640c8776 9356 * font.c (font_range): Adjust for the change of
c805dec0
KH
9357 Vunicode_category_table.
9358
76b397fb
DN
93592011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9360
9361 * m/iris4d.h: Remove file, move contents ...
9362 * s/irix6-5.h: ... here.
9363
22b4128e
PE
93642011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9365
9366 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9367 * alloc.c (mark_buffer):
9368 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9369 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9370 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9371 This isn't true in general, and it's particularly not true
9372 if Emacs is configured with --with-wide-int.
9373 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9374 New macros, used in the buffer.c change.
9375
869795d6
JD
93762011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9377
9378 * xsettings.c: Use both GConf and GSettings if both are available.
9379 (store_config_changed_event): Add comment.
9380 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9381 (store_tool_bar_style_changed): New functions.
5e617bc2 9382 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9383 (struct xsettings): Move font inside HAVE_XFT.
9384 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9385 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9386 Move inside HAVE_XFT.
640c8776 9387 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9388 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9389 also.
9390 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9391 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9392 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9393 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9394 (parse_settings): Move check for font inside HAVE_XFT.
9395 (read_settings, apply_xft_settings): Add comment.
9396 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9397 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9398 call store_font_name_changed.
9399 (xft_settings_event): Add comment.
9400 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9401 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9402 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9403 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9404 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9405 (xsettings_get_system_font, xsettings_get_system_normal_font):
9406 Add comment.
869795d6 9407
d8ed26bd
PE
94082011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9409
9410 Random fixes. E.g., (random) never returned negative values.
9411 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9412 subseconds part to the entropy, as that's a bit more random.
9413 Prefer signed to unsigned, since the signedness doesn't matter and
9414 in general we prefer signed. When given a limit, use a
9415 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9416 latter isn't right if USE_2_TAGS_FOR_INTS.
9417 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9418 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9419
cabf1cac
SM
94202011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9421
9422 * textprop.c (text_property_stickiness):
9423 Obey Vtext_property_default_nonsticky.
9424 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9425 * w32fns.c (syms_of_w32fns):
9426 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9427
6e9b2be9
PE
94282011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9429
9430 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9431 This is more efficient than Ffile_directory_p and avoids a minor race.
9432
90186c68
LMI
94332011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9434
7c301272
LMI
9435 * buffer.c (Foverlay_put): Say what the return value is
9436 (bug#7835).
9437
c4f2d8d4
LMI
9438 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9439 is a directory before asking whether to use the file name
9440 (bug#7564).
ad637907
LMI
9441 (barf_or_query_if_file_exists): Make the "File is a directory"
9442 error be more correct.
c4f2d8d4 9443
90186c68
LMI
9444 * fns.c (Frequire): Remove the mention of the .gz files, since
9445 that's installation-specific, but keep the mention of
9446 `get-load-suffixes'.
9447
da64016e
PE
94482011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9449
9450 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9451 Report string overflow if the output is too long.
9452
7d47b580
JB
94532011-07-04 Juanma Barranquero <lekktu@gmail.com>
9454
a555cb87
JB
9455 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9456 (syms_of_gnutls): Remove duplicate DEFSYM for
9457 Qgnutls_bootprop_verify_hostname_error, an error for
9458 Qgnutls_bootprop_verify_error (which is no longer used).
9459
7d47b580
JB
9460 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9461 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9462 Also (re)move comments that are misplaced or no longer relevant.
9463
1e49bfab
LMI
94642011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9465
9466 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9467
1485f4c0
CY
94682011-07-03 Chong Yidong <cyd@stupidchicken.com>
9469
9470 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9471 and background color parameters if they have been changed.
9472
a9ab721e
LMI
94732011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9474
9475 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9476
cf7cff57
PE
94772011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9478
2e13213d
PE
9479 * xsettings.c (SYSTEM_FONT): Define only when used.
9480 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9481
cf7cff57
PE
9482 * keymap.c (access_keymap_1): Now static.
9483
7a8e04f7
CY
94842011-07-02 Chong Yidong <cyd@stupidchicken.com>
9485
9486 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9487 leave any prefix arg for the up event (Bug#1586).
9488
61352f62
LMI
94892011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9490
69bb1ef7
LMI
9491 * lread.c (syms_of_lread): Mention single symbols defined by
9492 `defvar' or `defconst' (bug#7154).
9493
61352f62 9494 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9495 (Frequire): Mention get-load-suffixes.
61352f62 9496
28545e04
MR
94972011-07-02 Martin Rudalics <rudalics@gmx.at>
9498
9499 * window.h (window): Remove clone_number slot.
9500 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9501 Remove.
9502 (make_parent_window, make_window, saved_window)
9503 (Fset_window_configuration, save_window_save): Don't deal with
9504 clone numbers.
9505 * buffer.c (Qclone_number): Remove declaration.
9506 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9507
3349e122
SM
95082011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9509
9510 Add multiple inheritance to keymaps.
9511 * keymap.c (Fmake_composed_keymap): New function.
9512 (Fset_keymap_parent): Simplify.
9513 (fix_submap_inheritance): Remove.
9514 (access_keymap_1): New function extracted from access_keymap to handle
9515 embedded parents and handle lists of maps.
9516 (access_keymap): Use it.
9517 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9518 (Fcopy_keymap): Handle embedded parents.
9519 (Fcommand_remapping, define_as_prefix): Simplify.
9520 (Fkey_binding): Simplify.
9521 (syms_of_keymap): Move minibuffer-local-completion-map,
9522 minibuffer-local-filename-completion-map,
9523 minibuffer-local-must-match-map, and
9524 minibuffer-local-filename-must-match-map to Elisp.
9525 (syms_of_keymap): Defsubr make-composed-keymap.
9526 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9527 (parse_menu_item): Trivial simplification.
9528
3279eb87
GM
95292011-07-01 Glenn Morris <rgm@gnu.org>
9530
9531 * Makefile.in (SETTINGS_LIBS): Fix typo.
9532
4550efdf
KI
95332011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9534
9535 * coding.c (Fencode_coding_string): Record the last coding system
9536 used, as the function doc string says (bug#8738).
9537
0949d2b6
JD
95382011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9539
9540 * xsettings.c (store_monospaced_changed): Take new font as arg and
9541 check for change against current_mono_font.
9542 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9543 (emacs_settings_constructor, emacs_settings_get_property)
9544 (emacs_settings_set_property, emacs_settings_class_init)
9545 (emacs_settings_init, gsettings_obj): Remove.
9546 (something_changedCB): New function for HAVE_GSETTINGS.
9547 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9548 with value as argument.
9549 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9550 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9551 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9552 "changed".
9553
9554 * xgselect.c: Add defined (HAVE_GSETTINGS).
9555 (xgselect_initialize): Ditto.
9556
9557 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9558 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9559 xg_select.
9560
bbc6b304
PE
95612011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9562
9563 * eval.c (struct backtrace): Simplify and port the data structure.
9564 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9565 signed bit field, as this assumption is not portable and it makes
9566 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9567 "char debug_on_exit : 1" as this is not portable either; instead,
9568 use the portable "unsigned int debug_on_exit : 1". Remove unused
9569 member evalargs. Remove obsolete comments about cc bombing out.
9570
9851bfc5
JD
95712011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9572
51bb811f 9573 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9574 Let HAVE_GSETTINGS override HAVE_GCONF.
9575 (store_monospaced_changed): New function.
9576 (EMACS_SETTINGS): A new type derived from GObject to handle
9577 GSettings notifications.
9578 (emacs_settings_constructor, emacs_settings_get_property)
9579 (emacs_settings_set_property, emacs_settings_class_init):
9580 New functions.
9581 (gsettings_client, gsettings_obj): New variables.
9582 (GSETTINGS_SCHEMA): New define.
9583 (something_changedCB): Call store_monospaced_changed.
9584 (init_gsettings): New function.
9585 (xsettings_initialize): Call init_gsettings.
9586 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9587 to NULL.
9588
640c8776 9589 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9590 GCONF_CFLAGS/LIBS.
9591
5386012d
MR
95922011-06-29 Martin Rudalics <rudalics@gmx.at>
9593
9594 * window.c (resize_root_window, grow_mini_window)
9595 (shrink_mini_window): Rename Qresize_root_window to
9596 Qwindow_resize_root_window and Qresize_root_window_vertically to
9597 Qwindow_resize_root_window_vertically.
9598
f13e0b08
PE
95992011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9600
9601 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9602
94515237
JB
96032011-06-27 Juanma Barranquero <lekktu@gmail.com>
9604
9605 * makefile.w32-in: Redesign dependencies so they reflect more
9606 clearly which files are directly included by each source file,
9607 and not through other includes.
9608
e43b6e43
MR
96092011-06-27 Martin Rudalics <rudalics@gmx.at>
9610
9611 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9612 (sort_overlays, overlay_strings): When an overlay's clone number
9613 matches the window's clone number process the overlay even if
9614 the overlay's window property doesn't match the current window.
9615
d68443dc
MR
9616 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9617 (Fwindow_hchild): Rename to Fwindow_left_child.
9618 (Fwindow_next): Rename to Fwindow_next_sibling.
9619 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9620 (resize_window_check): Rename to window_resize_check.
9621 (resize_window_apply): Rename to window_resize_apply.
9622 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9623 (Fdelete_other_windows_internal, resize_frame_windows)
9624 (Fsplit_window_internal, Fdelete_window_internal)
9625 (grow_mini_window, shrink_mini_window)
9626 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9627
c7e73be5
JD
96282011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9629
9630 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9631 (emacs_fixed_set_min_size): Remove.
9632 (emacs_fixed_new): Take frame as argument.
9633
9634 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9635 (_EmacsFixedPrivate): Remove minwidth/height.
9636 Add struct frame *f.
9637 (emacs_fixed_init): Initialize priv->f.
9638 (get_parent_class, emacs_fixed_set_min_size): Remove.
9639 (emacs_fixed_new): Set priv->f to argument.
9640 (emacs_fixed_get_preferred_width)
9641 (emacs_fixed_get_preferred_height): Use min_width/height from
9642 frames size_hint to set minimum and natural (Bug#8919).
9643 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9644 and use min_width/height from frames size_hint to set
9645 min_width/height (Bug#8919).
9646
9647 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9648 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9649 Fix indentation.
c7e73be5 9650
cf99dcf8
EZ
96512011-06-26 Eli Zaretskii <eliz@gnu.org>
9652
9653 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9654 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9655 called at ZV.
9656
029529ac
CY
96572011-06-26 Chong Yidong <cyd@stupidchicken.com>
9658
9659 * process.c (wait_reading_process_output): Bypass select if
9660 waiting for a cell while ignoring keyboard input, and input is
9661 pending. Suggested by Jan Djärv (Bug#8869).
9662
7a7ef429
PE
96632011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9664
9665 Use gnulib's dup2 module instead of rolling our own.
9666 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9667
11fdef7d 96682011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9669
9670 * dispnew.c (scrolling_window): Before scrolling, turn off a
9671 mouse-highlight in the window being scrolled.
9672
cd3520a4
JB
96732011-06-24 Juanma Barranquero <lekktu@gmail.com>
9674
9675 Move DEFSYM to lisp.h and use everywhere.
9676
9677 * character.h (DEFSYM): Move declaration...
9678 * lisp.h (DEFSYM): ...here.
9679
9680 * gnutls.c:
9681 * minibuf.c:
9682 * w32menu.c:
9683 * w32proc.c:
9684 * w32select.c: Don't include character.h.
9685
9686 * alloc.c (syms_of_alloc):
9687 * buffer.c (syms_of_buffer):
9688 * bytecode.c (syms_of_bytecode):
9689 * callint.c (syms_of_callint):
9690 * casefiddle.c (syms_of_casefiddle):
9691 * casetab.c (init_casetab_once):
9692 * category.c (init_category_once, syms_of_category):
9693 * ccl.c (syms_of_ccl):
9694 * cmds.c (syms_of_cmds):
9695 * composite.c (syms_of_composite):
9696 * dbusbind.c (syms_of_dbusbind):
9697 * dired.c (syms_of_dired):
9698 * dispnew.c (syms_of_display):
9699 * doc.c (syms_of_doc):
9700 * editfns.c (syms_of_editfns):
9701 * emacs.c (syms_of_emacs):
9702 * eval.c (syms_of_eval):
9703 * fileio.c (syms_of_fileio):
9704 * fns.c (syms_of_fns):
9705 * frame.c (syms_of_frame):
9706 * fringe.c (syms_of_fringe):
9707 * insdel.c (syms_of_insdel):
9708 * keymap.c (syms_of_keymap):
9709 * lread.c (init_obarray, syms_of_lread):
9710 * macros.c (syms_of_macros):
9711 * msdos.c (syms_of_msdos):
9712 * print.c (syms_of_print):
9713 * process.c (syms_of_process):
9714 * search.c (syms_of_search):
9715 * sound.c (syms_of_sound):
9716 * syntax.c (init_syntax_once, syms_of_syntax):
9717 * terminal.c (syms_of_terminal):
9718 * textprop.c (syms_of_textprop):
9719 * undo.c (syms_of_undo):
9720 * w32.c (globals_of_w32):
9721 * window.c (syms_of_window):
9722 * xdisp.c (syms_of_xdisp):
9723 * xfaces.c (syms_of_xfaces):
9724 * xfns.c (syms_of_xfns):
9725 * xmenu.c (syms_of_xmenu):
9726 * xsettings.c (syms_of_xsettings):
9727 * xterm.c (syms_of_xterm): Use DEFSYM.
9728
4228cf16
TZ
97292011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9730
cd3520a4 9731 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9732
7fcccf1e
PE
97332011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9734
7efb4e0e
PE
9735 Integer and buffer overflow fixes (Bug#8873).
9736
ff5844ad
PE
9737 * print.c (printchar, strout): Check for string overflow.
9738 (PRINTPREPARE, printchar, strout):
9739 Don't set size unless allocation succeeds.
9740
90532f02
PE
9741 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9742 for sizes. Check for string overflow more accurately.
9743 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9744
6d84508d
PE
9745 * macros.c: Integer and buffer overflow fixes.
9746 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9747 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9748 Use ptrdiff_t, not int, for sizes.
9749 Don't increment bufsize until after realloc succeeds.
9750 Check for size-calculation overflow.
9751 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9752
437b2cb4
PE
9753 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9754
8b9ac8b4
PE
9755 * lread.c: Integer overflow fixes.
9756 (read_integer): Radix is now EMACS_INT, not int,
9757 to improve quality of diagnostics for out-of-range radices.
9758 Calculate buffer size correctly for out-of-range radices.
9759 (read1): Check for integer overflow in radices, and in
9760 read-circle numbers.
82cb60d3
PE
9761 (read_escape): Avoid int overflow.
9762 (Fload, openp, read_buffer_size, read1)
9763 (substitute_object_recurse, read_vector, read_list, map_obarray):
9764 Use ptrdiff_t, not int, for sizes.
9765 (read1): Use EMACS_INT, not int, for sizes.
20270765 9766 Check for size overflow.
8b9ac8b4 9767
7fcccf1e
PE
9768 * image.c (cache_image): Check for size arithmetic overflow.
9769
bfbbd7e7
PE
9770 * lread.c: Integer overflow issues.
9771 (saved_doc_string_size, saved_doc_string_length)
9772 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9773 Now ptrdiff_t, not int.
9774 (read1): Don't assume doc string length fits in int. Check for
9775 out-of-range doc string lengths.
9776 (read_list): Don't assume file position fits in int.
39019e54 9777 (read_escape): Check for hex character overflow.
bfbbd7e7 9778
4e323265
LL
97792011-06-22 Leo Liu <sdl.web@gmail.com>
9780
9781 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9782 Move to minibuffer.el.
9783
85fece3e
PE
97842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9785
20b84ce9 9786 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9787 The following patches are for when GLYPH_DEBUG && !XASSERT.
9788 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9789 * dispnew.c (flush_stdout):
9790 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9791 Mark as externally visible.
9792 * dispnew.c (check_window_matrix_pointers): Now static.
9793 * dispnew.c (window_to_frame_vpos):
9794 * xfns.c (unwind_create_frame):
9795 * xterm.c (x_check_font): Remove unused local.
9796 * scroll.c (CHECK_BOUNDS):
9797 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9798 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9799 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9800 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9801 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9802 Now static.
9803 (debug_method_add): Use va_list and vsprintf rather than relying
9804 on undefined behavior with wrong number of arguments.
9805 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9806 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9807 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9808 since we're not interested in debugging glyphs with old libraries.
9809 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9810 GCC 4.6.0's static checking.
9811
0766b489
PE
98122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9813
31fd4b32
PE
9814 Integer overflow and signedness fixes (Bug#8873).
9815 A few related buffer overrun fixes, too.
9816
b79e8648
PE
9817 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9818
0766b489
PE
9819 * dispextern.h (struct face.stipple):
9820 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9821 (x_bitmap_mask, x_allocate_bitmap_record)
9822 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9823 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9824 (x_create_bitmap_from_xpm_data):
9825 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9826 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9827 (.bitmaps_last):
9828 * xfaces.c (load_pixmap):
9829 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9830 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9831 (.bitmaps_last, struct x_output.icon_bitmap):
9832 Use ptrdiff_t, not int, for bitmap indexes.
9833 (x_allocate_bitmap_record): Check for size overflow.
9834 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9835
b081724f
PE
9836 Use ptrdiff_t, not int, for overlay counts.
9837 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9838 * editfns.c (overlays_around, get_pos_property):
9839 * textprop.c (get_char_property_and_overlay):
9840 * xdisp.c (next_overlay_change, note_mouse_highlight):
9841 * xfaces.c (face_at_buffer_position):
21514da7
PE
9842 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9843 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9844 (Fnext_overlay_change, Fprevious_overlay_change)
9845 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9846 Use ptrdiff_t, not int, for sizes.
21514da7 9847 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9848
3de73e5e
PE
9849 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9850
2606c57b
PE
9851 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9852 (x_session_initialize): Do not assume string length fits in int.
9853
aaafe47a
PE
9854 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9855 This is unlikely, but can occur if DPI is outlandish.
9856
2674ddc8 9857 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9858 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9859
28154962
PE
9860 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9861 * xrdb.c (magic_file_p, search_magic_path):
9862 Omit last arg SUFFIX; it was always 0. All callers changed.
9863 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9864
7de51af5
PE
9865 * xfont.c (xfont_match): Avoid need for strlen.
9866
25ed6cc3
PE
9867 * xfns.c: Don't assume strlen fits in int.
9868 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9869
4eab31dd
PE
9870 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9871 not unsigned long, as we prefer signed integers. All callers changed.
9872 Detect integer overflow in repeat count.
9873 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9874 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9875
171e2a58
PE
9876 * termcap.c: Don't assume sizes fit in int and never overflow.
9877 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9878 (gobble_line): Check for size-calculation overflow.
9879
ad39faca 9880 * minibuf.c (Fread_buffer):
6e5bb2dc 9881 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9882 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9883 Don't assume string length fits in int.
9884
52c61c22 9885 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9886 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9887
b5b8c9e5
PE
9888 * font.c: Don't assume string length fits in int.
9889 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9890 Use ptrdiff_t, not int.
ccd6111c
PE
9891 (font_intern_prop): Don't assume string length fits in int.
9892 Don't assume integer property fits in fixnum.
9893 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9894
882f0d81 9895 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9896 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9897 Reformulate so as not to need the command string.
9898 Invoke gzip -cd rather than gunzip, as it's more portable.
9899 (lock_info_type, lock_file_1, lock_file):
9900 Don't assume pid_t and time_t fit in unsigned long.
9901 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9902 (current_lock_owner): Prefer signed type for sizes.
9903 Use memcpy, not strncpy, where memcpy is what is really wanted.
9904 Don't assume (via atoi) that time_t and pid_t fit in int.
9905 Check for time_t and/or pid_t out of range, e.g., via a network share.
9906 Don't alloca where an auto var works fine.
9907
93f4cf88
PE
9908 * fileio.c: Fix some integer overflow issues.
9909 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9910 Don't assume string length fits in int.
9911 (directory_file_name): Don't assume string length fits in long.
9912 (make_temp_name): Don't assume pid fits in int, or that its print
9913 length is less than 20.
9914
f3e92b69
PE
9915 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9916
1bfdaf10
PE
9917 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9918
35016e9a
PE
9919 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9920
3d1e65a1
PE
9921 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9922 We prefer signed integers, even for size calculations.
9923
0b963a93
PE
9924 * emacs.c: Don't assume string length fits in 'int'.
9925 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9926 (main): Don't invoke strlen when not needed.
9927
573f4b54
PE
9928 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9929 (XD_DEBUG_MESSAGE): Don't waste a byte.
9930
989f33ba
PE
9931 * callproc.c (getenv_internal_1, getenv_internal)
9932 (Fgetenv_internal):
965d34eb
PE
9933 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9934
e4d29b33
PE
9935 * lread.c (invalid_syntax): Omit length argument.
9936 All uses changed. This doesn't fix a bug, but it simplifies the
9937 code away from its former Hollerith-constant appearance, and it's
9938 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9939 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9940
eb49b136
PE
9941 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9942 This didn't break anything, but it didn't help either.
9943 It's confusing to put a bogus integer in a place where the actual
9944 value does not matter.
9f62aeb1 9945 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9946 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9947
15375a22
PE
9948 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9949 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9950 implementation.
b61cc01c
PE
9951 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9952 We prefer signed types, and the value cannot exceed the EMACS_INT
9953 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9954 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9955 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9956 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9957
53b2623d
PE
9958 * indent.c (sane_tab_width): New function.
9959 (current_column, scan_for_column, Findent_to, position_indentation)
9960 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9961 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9962
51cab52b 9963 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9964
f2ed8a70
PE
9965 * lisp.h (lint_assume): New macro.
9966 * composite.c (composition_gstring_put_cache):
9967 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9968
abe80cc6
PE
9969 * editfns.c, insdel.c:
9970 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9971
b02c740e
PE
9972 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9973
ebc96716
PE
9974 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9975
b4e50fa0 9976 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9977 Use much-faster test for byte-length change.
311d5d7c 9978 Don't assume string byte-length fits in 'int'.
a4cf38e4 9979 Check that character arg fits in 'int'.
85461888 9980 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9981
c0c1ee9f
PE
9982 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9983
a498d7f4
PE
9984 * fns.c (concat): Catch string overflow earlier.
9985 Do not rely on integer wraparound.
9986
51cab52b
PE
9987 * dispextern.h (struct it.overlay_strings_charpos)
9988 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9989 * xdisp.c (forward_to_next_line_start)
9990 (back_to_previous_visible_line_start)
9991 (reseat_at_next_visible_line_start, next_element_from_buffer):
9992 Don't arbitrarily truncate the value of 'selective' to int.
9993
76031fad
PE
9994 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9995
5eb55db9
PE
9996 * composite.c: Don't truncate sizes to 'int'.
9997 (composition_gstring_p, composition_reseat_it)
9998 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9999 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10000 not EMACS_UINT, for indexes.
5eb55db9 10001
0703a717
PE
10002 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10003
d6202519
PE
10004 * buffer.c: Include <verify.h>.
10005 (struct sortvec.priority, struct sortstr.priority):
8961a454 10006 Now EMACS_INT, not int.
c20998a7 10007 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10008 (struct sortstr.size, record_overlay_string)
10009 (struct sortstrlist.size, struct sortlist.used):
10010 Don't truncate size to int.
10011 (record_overlay_string): Check for size-calculation overflow.
d6202519 10012 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10013
d5a19415
JM
100142011-06-22 Jim Meyering <meyering@redhat.com>
10015
029529ac 10016 Don't leak an XBM-image-sized buffer
d5a19415
JM
10017 * image.c (xbm_load): Free the image buffer after using it.
10018
a9041e6c
PE
100192011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10020
10021 Port to Sun C.
10022 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10023 that Sun C diagnosed.
10024 * fns.c (secure_hash): Fix pointer signedness issue.
10025 * intervals.c (static_offset_intervals): New function.
10026 (offset_intervals): Use it.
10027
7f3f739f
LL
100282011-06-21 Leo Liu <sdl.web@gmail.com>
10029
10030 * deps.mk (fns.o):
10031 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10032 sha512.h.
10033
10034 * fns.c (secure_hash): Rename from crypto_hash_function and change
10035 the first arg to accept symbols.
5b66d427 10036 (Fsecure_hash): New primitive.
7f3f739f
LL
10037 (syms_of_fns): New symbols.
10038
76147d94
DD
100392011-06-20 Deniz Dogan <deniz@dogan.se>
10040
10041 * process.c (Fset_process_buffer): Clarify return value in
10042 docstring.
10043
7d7d0045
CY
100442011-06-18 Chong Yidong <cyd@stupidchicken.com>
10045
10046 * dispnew.c (add_window_display_history): Use BVAR.
10047
10048 * xdisp.c (debug_method_add): Use BVAR.
10049 (check_window_end, dump_glyph_matrix, dump_glyph)
10050 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10051
10052 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10053 Likewise.
10054
10055 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10056 check till after the cache is created in init_frame_faces.
10057
ff2bc410
SM
100582011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10059
10060 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10061
28177add
PE
100622011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10063
dd3482fe
PE
10064 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10065 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10066 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10067
393d71f3 10068 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10069 * fileio.c (Finsert_file_contents):
10070 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10071 Remove the old (too-loose) buffer overflow checks.
10072 They weren't needed, since make_gap checks for buffer overflow.
10073 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10074 The old code merely checked for Emacs fixnum overflow, and relied
10075 on undefined (wraparound) behavior. The new code avoids undefined
10076 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10077
2e6813b0 10078 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10079 Tune. Don't use wider integers than needed. Don't use alloca.
10080 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10081
599a9e4f
PE
10082 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10083
99561444
PE
10084 * insdel.c, lisp.h (buffer_overflow): New function.
10085 (insert_from_buffer_1, replace_range, replace_range_2):
10086 * insdel.c (make_gap_larger):
10087 * editfns.c (Finsert_char):
10088 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10089
28177add
PE
10090 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10091
e69dafad
PE
100922011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10093
4baa020d 10094 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10095
b1c46f02
PE
10096 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10097 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10098
e69dafad
PE
10099 * fileio.c: Don't assume EMACS_INT fits in off_t.
10100 (emacs_lseek): New static function.
10101 (Finsert_file_contents, Fwrite_region): Use it.
10102 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10103
566684ea
PE
10104 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10105
e6966cd6
PE
10106 * fns.c: Don't overflow int when computing a list length.
10107 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10108 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10109 truncation on 64-bit hosts. Check for QUIT every
10110 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10111 faster and is responsive enough.
10112 (Flength): Report an error instead of overflowing an integer.
10113 (Fsafe_length): Return a float if the value is not representable
10114 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10115 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10116 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10117
dd0b0efb
PE
10118 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10119 (header_size, word_size): New constants.
10120 (allocate_vectorlike): Don't check size overflow here.
10121 (allocate_vector): Check it here instead, since this is the only
10122 caller of allocate_vectorlike that could cause overflow.
10123 Check that the new vector's length is representable as a fixnum.
10124
86fe5cfe
PE
10125 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10126 The previous code was bogus. For example, next_almost_prime (32)
10127 returned 39, which is undesirable as it is a multiple of 3; and
10128 next_almost_prime (24) returned 25, which is a multiple of 5 so
10129 why was the code bothering to check for multiples of 7?
10130
80e88859
PE
10131 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10132
4a2f0ad6
PE
10133 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10134
f66c7cf8
PE
10135 Variadic C functions now count arguments with ptrdiff_t.
10136 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10137 Back then I didn't know that the Emacs coding style prefers signed int.
10138 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10139 were being counted with int, which may truncate counts on 64-bit
10140 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10141 * lisp.h (struct Lisp_Subr.function.aMANY)
10142 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10143 Arg counts are now ptrdiff_t, not size_t.
10144 All variadic functions and their callers changed accordingly.
10145 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10146 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10147 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10148 * callint.c (Fcall_interactively): Check arg count for overflow,
10149 to avoid potential buffer overrun. Use signed char, not 'int',
10150 for 'varies' array, so that we needn't bother to check its size
10151 calculation for overflow.
10152 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10153 * eval.c (apply_lambda):
10154 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10155 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10156 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10157
a1759b76
PE
10158 * callint.c (Fcall_interactively): Don't use index var as event count.
10159
d96be9fc
PE
10160 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10161 * mem-limits.h (SIZE): Remove; no longer used.
10162
a690a978 10163 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10164
578c21e6
PE
10165 Remove unnecessary casts.
10166 * xterm.c (x_term_init):
10167 * xfns.c (x_set_border_pixel):
10168 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10169 These aren't needed now that we assume ANSI C.
10170
96f53c6c
PE
10171 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10172 It's more likely to cause problems (due to unsigned overflow)
10173 than to cure them.
10174
83c77d31
PE
10175 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10176
ee2079f1
PE
10177 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10178
6da65536
PE
10179 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10180
7147c4a4
PE
10181 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10182
193e32d9
PE
10183 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10184
e5533da6
PE
10185 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10186
9910e595
PE
10187 GLYPH_CODE_FACE returns EMACS_INT, not int.
10188 * dispextern.h (merge_faces):
10189 * xfaces.c (merge_faces):
01103c44
PE
10190 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10191 Don't assume EMACS_INT fits in int.
9910e595 10192
2638320e
PE
10193 * character.h (CHAR_VALID_P): Remove unused parameter.
10194 * fontset.c, lisp.h, xdisp.c: All uses changed.
10195
045eb8d9
PE
10196 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10197
c1f134b5
PE
10198 * fns.c (concat): Minor tuning based on overflow analysis.
10199 This doesn't fix any bugs. Use int to hold character, instead
10200 of constantly refetching from Emacs object. Use XFASTINT, not
10201 XINT, for value known to be a character. Don't bother comparing
10202 a single byte to 0400, as it's always less.
10203
395fcb93 10204 * floatfns.c (Fexpt):
327eeec8
PE
10205 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10206
abbd3d23
PE
10207 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10208 for characters.
10209
684a03ef
PE
10210 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10211
0fed43f3
PE
10212 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10213 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10214 incorrectly succeed when S was a string, because 4294967386 was
10215 truncated before it was used.
10216
8fd02eb7
PE
10217 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10218 Otherwise, an out-of-range integer could cause undefined behavior
10219 on a 64-bit host.
10220
f8c86b69
PE
10221 * composite.c: Use int, not EMACS_INT, for characters.
10222 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10223 EMACS_INT, for values that are known to be in character range.
10224 This doesn't fix any bugs but is the usual style inside Emacs and
10225 may generate better code on 32-bit machines.
10226
34206dd2
PE
10227 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10228 This is for reasons similar to the recent CHAR_STRING fix.
10229 * charset.c (Fencode_char): Check that character arg is actually
10230 a character. Pass an int to ENCODE_CHAR.
10231 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10232 wider than 'int', as a compile-time check to prevent future regressions
10233 in this area.
10234
c5958d4c 10235 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10236
10237 Make sure a 64-bit char is never passed to CHAR_STRING.
10238 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10239 by silently ignoring the top 32 bits, allowing some values
10240 that were far too large to be valid characters.
10241 * character.h: Include <verify.h>.
10242 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10243 arguments are no wider than unsigned, as a compile-time check
10244 to prevent future regressions in this area.
10245 * data.c (Faset):
01103c44 10246 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10247 (Fsubst_char_in_region):
10248 * fns.c (concat):
10249 * xdisp.c (decode_mode_spec_coding):
10250 Adjust to CHAR_STRING's new requirement.
10251 * editfns.c (Finsert_char, Fsubst_char_in_region):
10252 * fns.c (concat): Check that character args are actually
10253 characters. Without this test, these functions did the wrong
10254 thing with wildly out-of-range values on 64-bit hosts.
10255
d37ca623
PE
10256 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10257 These casts should not be needed on 32-bit hosts, either.
10258 * keyboard.c (read_char):
10259 * lread.c (Fload): Remove casts to unsigned.
10260
ea204efb
PE
10261 * lisp.h (UNSIGNED_CMP): New macro.
10262 This fixes comparison bugs on 64-bit hosts.
10263 (ASCII_CHAR_P): Use it.
10264 * casefiddle.c (casify_object):
01103c44 10265 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10266 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10267 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10268 * dispextern.h (FACE_FROM_ID):
10269 * keyboard.c (read_char): Use UNSIGNED_CMP.
10270
41cb286c
PE
10271 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10272 not to EMACS_INT, to avoid GCC warning.
10273
4a1b9832
PE
10274 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10275
55daad71
PE
10276 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10277 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10278 isn't needed on 32-bit machines.
8f95c75c 10279
01103c44
PE
10280 * buffer.c (Fgenerate_new_buffer_name):
10281 Use EMACS_INT for count, not int.
0ceccced 10282 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10283
10284 * data.c (Qcompiled_function): Now static.
10285
c6f072e7
PE
10286 * window.c (window_body_lines): Now static.
10287
20ce5912
PE
10288 * image.c (gif_load): Rename local to avoid shadowing.
10289
9c4c5f81
PE
10290 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10291 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10292 * alloc.c (make_save_value): Integer argument is now of type
10293 ptrdiff_t, not int.
10294 (mark_object): Use ptrdiff_t, not int.
10295 * lisp.h (pD): New macro.
10296 * print.c (print_object): Use it.
10297
c0c5c8ae
PE
10298 * alloc.c: Use EMACS_INT, not int, to count objects.
10299 (total_conses, total_markers, total_symbols, total_vector_size)
10300 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10301 (total_free_floats, total_floats, total_free_intervals)
10302 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10303 Now EMACS_INT, not int. All uses changed.
10304 (Fgarbage_collect): Compute overall total using a double, so that
10305 integer overflow is less likely to be a problem. Check for overflow
10306 when converting back to an integer.
5a25e253
PE
10307 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10308 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10309 These were 'int' variables that could overflow on 64-bit hosts;
10310 they were never used, so remove them instead of repairing them.
211a0b2a 10311 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10312 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10313 Previously, this ceilinged at INT_MAX, but that doesn't work on
10314 64-bit machines.
e46bb31a 10315 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10316
c78baabf 10317 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10318 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10319 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10320 when a (possibly-narrower) signed value would do just as well.
10321 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10322
c9d624c6
PE
10323 * alloc.c: Catch some string size overflows that we were missing.
10324 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10325 for convenience in STRING_BYTES_MAX.
10326 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10327 The definition here is exact; the one in lisp.h was approximate.
10328 (allocate_string_data): Check for string overflow. This catches
10329 some instances we weren't catching before. Also, it catches
10330 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10331 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10332 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10333
c9d624c6
PE
10334 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10335 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10336 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10337
353032ce
PE
10338 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10339
2bccce07
PE
10340 * alloc.c (Fmake_string): Check for out-of-range init.
10341
0ac30604
SM
103422011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10343
10344 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10345
c195f2de
JD
103462011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10347
10348 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10349 xg_get_default_scrollbar_width.
10350
10351 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10352 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10353 (style_changed_cb): Call update_theme_scrollbar_width and call
10354 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10355 all frames (Bug#8505).
10356 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10357 Call gtk_window_set_resizable if HAVE_GTK3.
10358 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10359 and height if HAVE_GTK3 (Bug#8505).
10360 (scroll_bar_width_for_theme): New variable.
10361 (update_theme_scrollbar_width): New function.
10362 (xg_get_default_scrollbar_width): Move code to
10363 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10364 (xg_initialize): Call update_theme_scrollbar_width.
10365
10366 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10367
10368 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10369
e10ac9f1
MR
103702011-06-12 Martin Rudalics <rudalics@gmx.at>
10371
10372 * frame.c (make_frame): Call other_buffer_safely instead of
10373 other_buffer.
10374
10375 * window.c (temp_output_buffer_show): Call display_buffer with
10376 second argument Vtemp_buffer_show_specifiers and reset latter
10377 immediately after the call.
10378 (Vtemp_buffer_show_specifiers): New variable.
10379 (auto_window_vscroll_p, next_screen_context_lines)
10380 (Vscroll_preserve_screen_position): Remove leading asterisks from
10381 doc-strings.
10382
2d3c217e 103832011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10384
7b7f97e8 10385 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10386 * buffer.c (Qclone_number): Remove for now, as it's unused.
10387 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10388 (record_buffer): Remove unused local.
10389 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10390 (set_frame_buffer_list): Remove; unused.
10391 * frame.h (other_visible_frames): Remove decl.
10392 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10393 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10394 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10395 if HAVE_GPM.
10396 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10397 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10398 Define only if HAVE_GPM.
10399 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10400 (update_hints_inhibit): Remove; never set. All uses removed.
10401 * widgetprv.h (emacsFrameClassRec): Remove decl.
10402 * window.c (delete_deletable_window): Now returns void, since it
10403 wasn't returning anything.
10404 (compare_window_configurations): Remove unused locals.
10405 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10406 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10407 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10408 the same widths as pointers. This follows up on the 2011-05-06 patch.
10409 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10410 * xterm.h: Likewise.
10411 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10412
1384b89e
JB
104132011-06-12 Juanma Barranquero <lekktu@gmail.com>
10414
10415 * makefile.w32-in: Update dependencies.
10416 (LISP_H): Add lib/intprops.h.
10417
1100a63c
CY
104182011-06-11 Chong Yidong <cyd@stupidchicken.com>
10419
10420 * image.c (gif_load): Add animation frame delay to the metadata.
10421 (syms_of_image): Use DEFSYM. New symbol `delay'.
10422
6198ccd0
MR
104232011-06-11 Martin Rudalics <rudalics@gmx.at>
10424
10425 * window.c (delete_deletable_window): Re-add.
10426 (Fset_window_configuration): Rewrite to handle dead buffers and
10427 consequently deletable windows.
10428 (window_tree, Fwindow_tree): Remove. Supply functionality in
10429 window.el.
10430 (compare_window_configurations): Simplify code.
10431
b6e3633c
AS
104322011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10433
1ab0dee5
AS
10434 * image.c (imagemagick_load_image): Fix type mismatch.
10435 (Fimagemagick_types): Likewise.
10436
b6e3633c
AS
10437 * window.h (replace_buffer_in_windows): Declare.
10438
9397e56f
MR
104392011-06-11 Martin Rudalics <rudalics@gmx.at>
10440
10441 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10442 Qclone_number. Remove external declaration of Qdelete_window.
10443 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10444 code.
640c8776
SM
10445 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10446 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10447 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10448 buffer list implementation.
10449 (other_buffer_safely): New function.
10450 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10451 calls to replace_buffer_in_windows and
10452 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10453 if allowed.
10454 (record_buffer): Inhibit quitting and rewrite using quittable
10455 functions. Run Qbuffer_list_update_hook if allowed.
10456 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10457 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10458 Move switch-to-buffer to window.el.
9397e56f
MR
10459 (bury-buffer): Move to window.el.
10460 (Vbuffer_list_update_hook): New variable.
10461
10462 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10463 section.
10464
10465 * window.h (resize_frame_windows): Move up in code.
10466 (Fwindow_frame): Remove EXFUN.
10467 (replace_buffer_in_all_windows): Remove prototype.
10468 (replace_buffer_in_windows_safely): Add prototype.
10469
10470 * window.c: Declare Qdelete_window static again. Move down
10471 declaration of select_count.
10472 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10473 (Fother_window): Move to window.el.
10474 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10475 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10476 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10477 window.el.
10478 (replace_buffer_in_windows): Implement by calling
10479 Qreplace_buffer_in_windows.
10480 (replace_buffer_in_all_windows): Remove with some functionality
10481 moved into replace_buffer_in_windows_safely.
10482 (replace_buffer_in_windows_safely): New function.
10483 (select_window_norecord, select_frame_norecord): Move in front
10484 of run_window_configuration_change_hook. Remove now obsolete
10485 declarations.
640c8776
SM
10486 (Fset_window_buffer): Rewrite doc-string.
10487 Call Qrecord_window_buffer.
9397e56f
MR
10488 (keys_of_window): Move binding for other-window to window.el.
10489
b50691aa
CY
104902011-06-11 Chong Yidong <cyd@stupidchicken.com>
10491
10492 * dispextern.h (struct image): Replace data member, whose int_val
10493 and ptr_val fields were not used by anything, with a single
10494 lisp_val object.
10495
10496 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10497 (gif_clear_image, gif_load, imagemagick_load_image)
10498 (gs_clear_image, gs_load): Callers changed.
10499
3f754b86
PE
105002011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10501
cca69397
PE
10502 * buffer.h: Include <time.h>, for time_t.
10503 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10504
109e28d0
PE
10505 Fix minor problems found by static checking.
10506
60737f02
PE
10507 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10508
4b66faf3
PE
10509 Make identifiers static if they are not used in other modules.
10510 * data.c (Qcompiled_function, Qframe, Qvector):
10511 * image.c (QimageMagick, Qsvg):
10512 * minibuf.c (Qmetadata):
10513 * window.c (resize_window_check, resize_root_window): Now static.
10514 * window.h (resize_window_check, resize_root_window): Remove decls.
10515
109e28d0
PE
10516 * window.c (window_deletion_count, delete_deletable_window):
10517 Remove; unused.
46a4ce9e
PE
10518 (window_body_lines): Now static.
10519 (Fdelete_other_windows_internal): Mark vars as initialized.
10520 Make sure 'resize_failed' is initialized.
10521 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10522 (resize_window_apply): Remove unused local.
10523 * window.h (delete_deletable_window): Remove decl.
10524
109e28d0 10525 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10526 (imagemagick_load_image): Fix pointer signedness problem by changing
10527 last arg from unsigned char * to char *. All uses changed.
10528 Also, fix a local for similar reasons.
10529 Remove unused locals. Remove locals to avoid shadowing.
10530 (fn_rsvg_handle_free): Remove; unused.
10531 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10532 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10533
3f754b86
PE
10534 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10535
2547adb1
CY
105362011-06-10 Chong Yidong <cyd@stupidchicken.com>
10537
10538 * image.c (gif_load): Fix omitted cast error introduced by
10539 2011-06-06 change.
10540
2c8e37d4
MR
105412011-06-10 Martin Rudalics <rudalics@gmx.at>
10542
10543 * window.h (resize_proportionally, orig_total_lines)
10544 (orig_top_line): Remove from window structure.
10545 (set_window_height, set_window_width, change_window_heights)
10546 (Fdelete_window): Remove prototypes.
10547 (resize_frame_windows): Remove duplicate declaration.
10548
440a42e3
EZ
105492011-06-10 Eli Zaretskii <eliz@gnu.org>
10550
10551 * window.h (resize_frame_windows, resize_window_check)
10552 (delete_deletable_window, resize_root_window)
10553 (resize_frame_windows): Declare prototypes.
10554
10555 * window.c (resize_window_apply): Make definition be "static" to
10556 match the prototype.
10557
562dd5e9
MR
105582011-06-10 Martin Rudalics <rudalics@gmx.at>
10559
10560 * window.c: Remove declarations of Qwindow_size_fixed,
10561 window_min_size_1, window_min_size_2, window_min_size,
10562 size_window, window_fixed_size_p, enlarge_window, delete_window.
10563 Remove static from declaration of Qdelete_window, it's
10564 temporarily needed by Fbury_buffer.
10565 (replace_window): Don't assign orig_top_line and
10566 orig_total_lines.
10567 (Fdelete_window, delete_window): Remove. Window deletion is
10568 handled by window.el.
640c8776
SM
10569 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10570 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10571 (Fdelete_other_windows): Remove. Deleting other windows is
10572 handled by window.el.
10573 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10574 handled in window.el.
10575 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10576 Window minimum sizes are handled in window.el.
10577 (shrink_windows, size_window, set_window_height)
10578 (set_window_width, change_window_heights, window_height)
10579 (window_width, CURBEG, CURSIZE, enlarge_window)
10580 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10581 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10582 handled in window.el.
10583 (make_dummy_parent): Rename to make_parent_window and give it a
10584 second argument horflag.
10585 (make_window): Don't set resize_proportionally any more.
10586 (Fsplit_window): Remove. Windows are split in window.el.
10587 (save_restore_action, save_restore_orig_size)
10588 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10589 Resize mini windows in window.el.
10590 (grow_mini_window, shrink_mini_window): Implement by calling
10591 Qresize_root_window_vertically, resize_window_check and
10592 resize_window_apply.
640c8776
SM
10593 (saved_window, Fset_window_configuration, save_window_save):
10594 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10595 resize_proportionally.
10596 (window_min_height, window_min_width): Move to window.el.
10597 (keys_of_window): Move bindings for delete-other-windows,
10598 split-window, delete-window and enlarge-window to window.el.
10599
10600 * buffer.c: Temporarily extern Qdelete_window.
10601 (Fbury_buffer): Temporarily call Qdelete_window instead of
10602 Fdelete_window (Fbury_buffer will move to window.el soon).
10603
10604 * frame.c (set_menu_bar_lines_1): Remove code handling
10605 orig_top_line and orig_total_lines.
10606
10607 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10608 set_window_height but set heights directly.
10609 (change_frame_size_1): Use resize_frame_windows.
10610
10611 * xdisp.c (init_xdisp): Don't use set_window_height but set
10612 heights directly.
10613
640c8776
SM
10614 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10615 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10616 run_window_configuration_change_hook.
10617
10618 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10619 instead of change_window_heights and run
10620 run_window_configuration_change_hook.
10621
1a13852e
MR
106222011-06-09 Martin Rudalics <rudalics@gmx.at>
10623
10624 * window.c (replace_window): Rename second argument REPLACEMENT to
10625 NEW. New third argument SETFLAG. Rewrite.
10626 (delete_window, make_dummy_parent): Call replace_window with
10627 third argument 1.
10628 (window_list_1): Move down in code.
10629 (run_window_configuration_change_hook): Move set_buffer part
10630 before select_frame_norecord part in order to unwind correctly.
10631 Rename count1 to count.
10632 (recombine_windows, delete_deletable_window, resize_root_window)
10633 (Fdelete_other_windows_internal)
10634 (Frun_window_configuration_change_hook, make_parent_window)
10635 (resize_window_check, resize_window_apply, Fresize_window_apply)
10636 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10637 (Fdelete_window_internal, Fresize_mini_window_internal):
10638 New functions.
1a13852e
MR
10639 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10640
f3d1777e
MR
106412011-06-08 Martin Rudalics <rudalics@gmx.at>
10642
496e208e
MR
10643 * window.h (window): Add some new members to window structure -
10644 normal_lines, normal_cols, new_total, new_normal, clone_number,
10645 splits, nest, prev_buffers, next_buffers.
10646 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10647 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10648
f3d1777e
MR
10649 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10650 Remove.
496e208e
MR
10651 (make_dummy_parent): Set new members of windows structure.
10652 (make_window): Move down in code. Handle new members of window
10653 structure.
10654 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10655 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10656 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10657 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10658 (Fset_window_next_buffers, Fset_window_clone_number):
10659 New functions.
496e208e
MR
10660 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10661 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10662 Doc-string fixes.
10663 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10664 Argument WINDOW can be now internal window too.
10665 (Fwindow_use_time): Move up in code.
10666 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10667 Rewrite doc-string.
10668 (Fset_window_configuration, saved_window)
10669 (Fcurrent_window_configuration, save_window_save): Handle new
10670 members of window structure.
b9e809c2
MR
10671 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10672 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10673 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10674 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10675 Qget_mru_window, Qresize_root_window,
10676 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10677 Qauto_buffer_name; staticpro them.
f3d1777e 10678
abde8f8c
MR
106792011-06-07 Martin Rudalics <rudalics@gmx.at>
10680
10681 * window.c (Fwindow_total_size, Fwindow_left_column)
10682 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10683 (Fwindow_list_1): New functions.
10684 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10685 (Fwindow_width, Fscroll_left, Fscroll_right):
10686 Use window_body_cols instead of window_box_text_cols.
10687 (delete_window, Fset_window_configuration):
10688 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10689 (delete_all_subwindows): Take a window as argument and not a
10690 structure. Rewrite.
190b47e6
MR
10691 (window_loop): Remove handling of GET_LRU_WINDOW and
10692 GET_LARGEST_WINDOW.
10693 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10694
10695 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10696 window_box_text_cols. delete_all_subwindows now takes a
10697 Lisp_Object as argument.
abde8f8c 10698
640c8776
SM
10699 * indent.c (compute_motion, Fcompute_motion):
10700 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10701
fa8a67e6
MR
10702 * frame.c (delete_frame): Call delete_all_subwindows with root
10703 window as argument.
10704
a54e3482
DC
107052011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10706
10707 * fns.c (Fputhash): Document return value.
10708
60002bf5
CY
107092011-06-06 Chong Yidong <cyd@stupidchicken.com>
10710
10711 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10712
0c671da6 107132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10714
b862a52a 10715 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10716
be44ca6c
PE
10717 Check for overflow when converting integer to cons and back.
10718 * charset.c (Fdefine_charset_internal, Fdecode_char):
10719 Use cons_to_unsigned to catch overflow.
10720 (Fencode_char): Use INTEGER_TO_CONS.
10721 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10722 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10723 * data.c (long_to_cons, cons_to_long): Remove.
10724 (cons_to_unsigned, cons_to_signed): New functions.
10725 These signal an error for invalid or out-of-range values.
10726 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10727 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10728 * font.c (Ffont_variation_glyphs):
10729 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10730 * lisp.h: Include <intprops.h>.
10731 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10732 (cons_to_signed, cons_to_unsigned): New decls.
10733 (long_to_cons, cons_to_long): Remove decls.
10734 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10735 (Fprimitive_undo): Use CONS_TO_INTEGER.
10736 * xfns.c (Fx_window_property): Likewise.
10737 * xselect.c: Include <limits.h>.
10738 (x_own_selection, selection_data_to_lisp_data):
10739 Use INTEGER_TO_CONS.
10740 (x_handle_selection_request, x_handle_selection_clear)
10741 (x_get_foreign_selection, Fx_disown_selection_internal)
10742 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10743 (lisp_data_to_selection_data): Use cons_to_unsigned.
10744 (x_fill_property_data): Use cons_to_signed.
10745 Report values out of range.
10746
d1f3d2af
PE
10747 Check for buffer and string overflow more precisely.
10748 * buffer.h (BUF_BYTES_MAX): New macro.
10749 * lisp.h (STRING_BYTES_MAX): New macro.
10750 * alloc.c (Fmake_string):
10751 * character.c (string_escape_byte8):
10752 * coding.c (coding_alloc_by_realloc):
10753 * doprnt.c (doprnt):
10754 * editfns.c (Fformat):
10755 * eval.c (verror):
10756 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10757 since they may not be the same number.
10758 * editfns.c (Finsert_char):
10759 * fileio.c (Finsert_file_contents):
10760 Likewise for BUF_BYTES_MAX.
10761
dd52fcea
PE
10762 * image.c: Use ptrdiff_t, not int, for sizes.
10763 (slurp_file): Switch from int to ptrdiff_t.
10764 All uses changed.
10765 (slurp_file): Check that file size fits in both size_t (for
10766 malloc) and ptrdiff_t (for sanity and safety).
10767
7f9bbdbb
PE
10768 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10769 if b->modtime has its maximal value.
10770
dfe18f82
PE
10771 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10772
84acfcf0
PE
10773 Don't assume time_t can fit into int.
10774 * buffer.h (struct buffer.modtime): Now time_t, not int.
10775 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10776 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10777
ccd9a01a
PE
10778 Minor fixes for signed vs unsigned integers.
10779 * character.h (MAYBE_UNIFY_CHAR):
10780 * charset.c (maybe_unify_char):
10781 * keyboard.c (read_char, reorder_modifiers):
10782 XINT -> XFASTINT, since the integer must be nonnegative.
10783 * ftfont.c (ftfont_spec_pattern):
10784 * keymap.c (access_keymap, silly_event_symbol_error):
10785 XUINT -> XFASTINT, since the integer must be nonnegative.
10786 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10787 since it makes no difference and we prefer signed.
10788 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10789 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10790 nonnegative.
10791
d6d100dd
SM
107922011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10793
10794 * window.h (Fwindow_frame): Declare.
10795
2b6148e4
PE
107962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10797
10798 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10799 (SPARE_MEMORY): Always define.
10800 (LARGE_REQUEST): Remove.
10801 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10802
f230ecc9
MR
108032011-06-06 Martin Rudalics <rudalics@gmx.at>
10804
727e958e
MR
10805 * lisp.h: Move EXFUNS for Fframe_root_window,
10806 Fframe_first_window and Fset_frame_selected_window to window.h.
10807
10808 * window.h: Move EXFUNS for Fframe_root_window,
10809 Fframe_first_window and Fset_frame_selected_window here from
10810 lisp.h.
10811
10812 * frame.c (Fwindow_frame, Fframe_first_window)
10813 (Fframe_root_window, Fframe_selected_window)
10814 (Fset_frame_selected_window): Move to window.c.
10815 (Factive_minibuffer_window): Move to minibuf.c.
10816 (Fother_visible_frames_p): New function.
10817
10818 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10819
f230ecc9
MR
10820 * window.c (decode_window, decode_any_window): Move up in code.
10821 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10822 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10823 (Fwindow_buffer): Move up and rewrite doc-string.
10824 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10825 (Fwindow_prev): New functions.
727e958e
MR
10826 (Fwindow_frame): Move here from frame.c. Accept any window as
10827 argument.
10828 (Fframe_root_window, Fframe_first_window)
10829 (Fframe_selected_window): Move here from frame.c. Accept frame
10830 or arbitrary window as argument. Update doc-strings.
10831 (Fminibuffer_window): Move up in code.
10832 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10833 (Fset_frame_selected_window): Move here from frame.c.
10834 Marginal rewrite.
727e958e
MR
10835 (Fselected_window, select_window, Fselect_window): Move up in
10836 code. Minor doc-string fixes.
f230ecc9 10837
4d09bcf6
PE
108382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10839
10840 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10841 Do not assume that spare memory exists; that assumption is valid
10842 only if SYSTEM_MALLOC.
10843 (LARGE_REQUEST): New macro, so that the issue of large requests
10844 is separated from the issue of spare memory.
10845
810928a2
AS
108462011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10847
172418ad
AS
10848 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10849 format. (Bug#8806)
10850
43f862f7
AS
10851 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10852
810928a2
AS
10853 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10854 before statements.
10855
a059fe24
JD
108562011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10857
10858 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10859
10860 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10861
10862 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10863 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10864
989bf368
JB
108652011-06-05 Juanma Barranquero <lekktu@gmail.com>
10866
10867 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10868
4b80f674
CY
108692011-06-04 Chong Yidong <cyd@stupidchicken.com>
10870
10871 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10872 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10873 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10874 New error handlers.
4b80f674
CY
10875 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10876 Obey Vx_select_enable_clipboard_manager. Catch errors in
10877 x_clipboard_manager_save (Bug#8779).
10878 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10879 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10880
99a33b77 108812011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10882
10883 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10884
99a33b77 108852011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10886
10887 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10888 in the current matrix if keep_current_p is non-zero.
10889
8264569d
EZ
108902011-06-04 Eli Zaretskii <eliz@gnu.org>
10891
10892 * bidi.c (bidi_level_of_next_char): Fix last change.
10893
57f97249
EZ
108942011-06-03 Eli Zaretskii <eliz@gnu.org>
10895
fec2107c 10896 Support bidi reordering of text covered by display properties.
57f97249 10897
fec2107c
EZ
10898 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10899 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10900 (bidi_cache_search, bidi_cache_iterator_state)
10901 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10902 (bidi_level_of_next_char, bidi_move_to_visually_next):
10903 Support character positions inside a run of characters covered by a
fec2107c
EZ
10904 display string.
10905 (bidi_paragraph_init, bidi_resolve_explicit_1)
10906 (bidi_level_of_next_char): Call bidi_fetch_char and
10907 bidi_fetch_char_advance instead of FETCH_CHAR and
10908 FETCH_CHAR_ADVANCE.
10909 (bidi_init_it): Initialize new members.
10910 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10911 definitions.
10912 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10913 instead of using explicit *_CHAR codes.
d6d100dd
SM
10914 (bidi_resolve_explicit, bidi_resolve_weak):
10915 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10916 bidirectional text is supported only in multibyte buffers.
10917 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10918 it to initialize the frame_window_p member of struct bidi_it.
10919 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10920 (bidi_resolve_explicit, bidi_resolve_weak)
10921 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10922 bidi_it->nchars is non-positive.
10923 (bidi_level_of_next_char): Don't try to lookup the cache for the
10924 next/previous character if nothing is cached there yet, or if we
10925 were just reseat()'ed to a new position.
c40e2fb2 10926
0e14fe90
EZ
10927 * xdisp.c (set_cursor_from_row): Set start and stop points
10928 according to the row's direction when priming the loop that looks
10929 for the glyph on which to display cursor.
10930 (single_display_spec_intangible_p): Function deleted.
10931 (display_prop_intangible_p): Reimplement to call
10932 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10933 Accept 3 additional arguments needed by handle_display_spec.
10934 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10935 values: lists, `(when COND...)' forms, etc.
10936 (single_display_spec_string_p): Support property values that are
10937 lists with the argument STRING its top-level element.
10938 (display_prop_string_p): Fix the condition for processing a
10939 property that is a list to be consistent with handle_display_spec.
fec2107c 10940 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10941 last portion of handle_display_prop.
10942 (compute_display_string_pos): Accept additional argument
10943 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10944 value of a `display' property is a "replacing spec".
10945 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10946 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10947 the display property, but just return a value indicating whether
10948 the display property will replace the characters it covers.
10949 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10950 frame_window_p members of struct bidi_it.
d6d100dd
SM
10951 (compute_display_string_pos, compute_display_string_end):
10952 New functions.
fec2107c
EZ
10953 (push_it): Accept second argument POSITION, where pop_it should
10954 jump to continue iteration.
10955 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10956
fec2107c
EZ
10957 * keyboard.c (adjust_point_for_property): Adjust the call to
10958 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10959
10960 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10961 (bidi_init_it): Update prototypes.
10962 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10963 (compute_display_string_pos, compute_display_string_end):
10964 Declare prototypes.
fec2107c
EZ
10965 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10966 EMACS_INT.
fc6f18ce 10967
40087514 109682011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10969
57f53182
PE
10970 Malloc failure behavior now depends on size of allocation.
10971 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10972 * lisp.h: Change signatures accordingly.
10973 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10974 All callers changed. (Bug#8762)
10975
10976 * gnutls.c: Use Emacs's memory allocators.
10977 Without this change, the gnutls library would invoke malloc etc.
10978 directly, which causes problems on non-SYNC_INPUT hosts, and which
10979 runs afoul of improving memory_full behavior. (Bug#8761)
10980 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10981 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10982 xfree instead of the default malloc, realloc, free.
10983 (Fgnutls_boot): No need to check for memory allocation failure,
10984 since xmalloc does that for us.
10985
ac32cd99 10986 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10987 * category.c (hash_get_category_set):
10988 * ccl.c (ccl_driver):
10989 * charset.c (Fdefine_charset_internal):
10990 * charset.h (struct charset.hash_index):
10991 * composite.c (get_composition_id, gstring_lookup_cache)
10992 (composition_gstring_put_cache):
10993 * composite.h (struct composition.hash_index):
10994 * dispextern.h (struct image.hash):
10995 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10996 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10997 (hashfn_equal, hashfn_user_defined, make_hash_table)
10998 (maybe_resize_hash_table, hash_lookup, hash_put)
10999 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11000 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11001 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11002 * image.c (make_image, search_image_cache, lookup_image)
11003 (xpm_put_color_table_h):
11004 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11005 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11006 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11007 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11008 * alloc.c (allocate_vectorlike):
11009 Check for overflow in vector size calculations.
11010 * ccl.c (ccl_driver):
11011 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11012 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11013 need to be updated by these changes.
40087514
PE
11014 * fns.c (make_hash_table, maybe_resize_hash_table):
11015 Check for integer overflow with large hash tables.
0de4bb68
PE
11016 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11017 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11018 (SXHASH_REDUCE): New macro.
11019 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11020 Use it instead of discarding useful hash info with large hash values.
11021 (sxhash_float): New function.
11022 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11023 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11024 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11025 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11026 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11027 Adjust signatures to match updated version of code.
11028 (consing_since_gc): Now EMACS_INT, since a single hash table can
11029 use more than INT_MAX bytes.
11030
698d32e2
DN
110312011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11032
11033 Make it possible to build with GCC-4.6+ -O2 -flto.
11034
11035 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11036
fd6fa53f
SM
110372011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11038
11039 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11040 Call minibuffer-inactive-mode.
11041
864db017
JB
110422011-05-31 Juanma Barranquero <lekktu@gmail.com>
11043
11044 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11045 Update dependencies.
11046
2ad0baf4
DN
110472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11048
11049 * data.c (init_data): Remove code for UTS, this system is not
11050 supported anymore.
11051
4fcc2638
DN
110522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11053
11054 Don't force ./temacs to start in terminal mode.
11055
11056 * frame.c (make_initial_frame): Initialize faces in all cases, not
11057 only when CANNOT_DUMP is defined.
11058 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11059
c56e0fd5
DN
110602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11061
11062 * dispnew.c (add_window_display_history): Use const for the string
11063 pointer. Remove declaration, not needed.
11064
333d54da 110652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11066
55d4c1b2 11067 Use 'inline', not 'INLINE'.
333d54da 11068 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11069 * alloc.c, fontset.c (INLINE): Remove.
11070 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11071 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11072 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11073 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11074 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11075
738db178
DN
110762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11077
11078 Make it possible to run ./temacs.
11079
11080 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11081 syms_of_callproc does the same thing. Remove test for
11082 "initialized", do it in the caller.
11083 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11084
620c53a6
SM
110852011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11086
11087 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11088 (read_minibuf): Use get_minibuffer.
11089 (syms_of_minibuf): Use DEFSYM.
11090 (Qmetadata): New var.
11091 * data.c (Qbuffer): Don't make it static.
11092 (syms_of_data): Use DEFSYM.
11093
e003a292
PE
110942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11095
11096 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11097 (CCL_CODE_MIN): New macro.
11098
ed008a6d
PE
110992011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11100
3687c2ef
PE
11101 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11102
ed008a6d
PE
11103 * eval.c (Qdebug): Now static.
11104 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11105 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11106 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11107
d66c4c7c
CY
111082011-05-29 Chong Yidong <cyd@stupidchicken.com>
11109
11110 * image.c: Various fixes to ImageMagick code comments.
11111 (Fimagemagick_types): Doc fix.
11112
5fbc2025
PE
111132011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11114
0196f88a
PE
11115 Minor fixes prompted by GCC 4.6.0 warnings.
11116
11117 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11118
5fbc2025
PE
11119 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11120 (x_clipboard_manager_save_all): Move extern decl to ...
11121 * xterm.h: ... here, so that it can be checked for consistency.
11122
1dd3c2d9
CY
111232011-05-29 Chong Yidong <cyd@stupidchicken.com>
11124
11125 * xselect.c (x_clipboard_manager_save_frame)
11126 (x_clipboard_manager_save_all): New functions.
11127 (Fx_clipboard_manager_save): Lisp function deleted.
11128
11129 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11130 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11131
11132 * xterm.h: Update prototype.
11133
5ba6571d
WX
111342011-05-28 William Xu <william.xwl@gmail.com>
11135
11136 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11137 exiting (Bug#8239).
11138
3eaff834
JM
111392011-05-28 Jim Meyering <meyering@redhat.com>
11140
e1900994 11141 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11142 * fns.c (to_uchar): Define.
11143 (crypto_hash_function): Use it to convert some newly-signed
11144 variables to unsigned, to avoid sign-extension bugs. For example,
11145 without this change, (md5 "truc") would evaluate to
11146 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11147 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11148 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11149
0f6990a7
PE
111502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11151
11152 Integer overflow fixes.
c8a9ca5a 11153
08686060
PE
11154 * dbusbind.c: Serial number integer overflow fixes.
11155 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11156 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11157 to hold a serial number that is too large for a fixnum.
11158 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11159 Check for serial numbers out of range. Decode any serial number
59568bf0 11160 that was so large that it became a float. (Bug#8722)
08686060 11161
2d1fc3c7
PE
11162 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11163 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11164 Use XFASTINT rather than XUINT when numbers are nonnegative.
11165 (xd_append_arg, Fdbus_method_return_internal):
11166 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11167 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11168 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11169 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11170 (Bug#8722)
2d1fc3c7 11171
c8a9ca5a
PE
11172 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11173
519e1d69
PE
11174 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11175
6df6ae42 11176 ccl: Add integer overflow checks.
30569699
PE
11177 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11178 (IN_INT_RANGE): New macros.
11179 (ccl_driver): Use them to check for integer overflow when
11180 decoding a CCL program. Many of the new checks are whether XINT (x)
11181 fits in int; it doesn't always, on 64-bit hosts. The new version
11182 doesn't catch all possible integer overflows, but it's an
847044ea 11183 improvement. (Bug#8719)
30569699 11184
c11285dc
PE
11185 * alloc.c (make_event_array): Use XINT, not XUINT.
11186 There's no need for unsigned here.
11187
fdccd48e
PE
11188 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11189 This follows up to the 2011-05-06 change that substituted uintptr_t
11190 for EMACS_INT. This case wasn't caught back then.
11191
37910ab2
PE
11192 Rework Fformat to avoid integer overflow issues.
11193 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11194 now (part of C89). Include <verify.h>.
11195 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11196 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11197 (Fformat): Avoid the prepass trying to compute sizes; it was only
11198 approximate and thus did not catch overflow reliably. Instead, walk
11199 through the format just once, formatting and computing sizes as we go,
11200 checking for integer overflow at every step, and allocating a larger
11201 buffer as needed. Keep track separately whether the format is
11202 multibyte. Keep only the most-recently calculated precision, rather
11203 than them all. Record whether each argument has been converted to
11204 string. Use EMACS_INT, not int, for byte and char and arg counts.
11205 Support field widths and precisions larger than INT_MAX. Avoid
11206 sprintf's undefined behavior with conversion specifications such as %#d
11207 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11208 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11209 formatting out-of-range floating point numbers with int
9173deec 11210 formats. (Bug#8668)
37910ab2 11211
2e6578fb
PE
11212 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11213
0ae6bdee
PE
11214 * data.c: Avoid integer truncation in expressions involving floats.
11215 * data.c: Include <intprops.h>.
11216 (arith_driver): When there's an integer overflow in an expression
11217 involving floating point, convert the integers to floating point
11218 so that the resulting value does not suffer from catastrophic
11219 integer truncation. For example, on a 64-bit host (* 4
11220 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11221 Do not rely on undefined behavior after integer overflow.
11222
de883a70
PE
11223 merge count_size_as_multibyte, parse_str_to_multibyte
11224 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11225 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11226 Check for integer overflow.
11227 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11228 since it's now a duplicate of the other. This is more of
11229 a character than a buffer op, so better that it's in character.c.
11230 * fns.c, print.c: Adjust to above changes.
11231
2ff916cb
PE
112322011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11233
11234 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11235
f1b54466
PE
112362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11237
fb1ac845
PE
11238 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11239 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11240 (x_clipboard_manager_save): Now static.
11241 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11242
f1b54466
PE
11243 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11244 (crypto_hash_function): Now static.
11245 Fix pointer signedness problems. Avoid unnecessary initializations.
11246
a9f737ee
CY
112472011-05-27 Chong Yidong <cyd@stupidchicken.com>
11248
11249 * termhooks.h (Vselection_alist): Make it terminal-local.
11250
11251 * terminal.c (create_terminal): Initialize it.
11252
11253 * xselect.c: Support for clipboard managers.
11254 (Vselection_alist): Move to termhooks.h as terminal-local var.
11255 (LOCAL_SELECTION): New macro.
11256 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11257 (symbol_to_x_atom): Remove gratuitous arg.
11258 (x_handle_selection_request, lisp_data_to_selection_data)
11259 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11260 (x_own_selection, x_get_local_selection, x_convert_selection):
11261 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11262 (some_frame_on_display): Delete unused function.
11263 (Fx_own_selection_internal, Fx_get_selection_internal)
11264 (Fx_disown_selection_internal, Fx_selection_owner_p)
11265 (Fx_selection_exists_p): New optional frame arg.
11266 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11267 (x_handle_selection_clear): Don't treat other terminals with the
11268 same keyboard specially. Use the terminal-local Vselection_alist.
11269 (x_clear_frame_selections): Use Frun_hook_with_args.
11270
11271 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11272
11273 * xterm.h: Add support for those atoms.
11274
e067f0c1
CY
112752011-05-26 Chong Yidong <cyd@stupidchicken.com>
11276
11277 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11278 (converted_selections, conversion_fail_tag): New global variables.
11279 (x_selection_request_lisp_error): Free the above.
11280 (x_get_local_selection): Remove unnecessary code.
11281 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11282 of converted selections stored in converted_selections.
11283 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11284 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11285 (x_convert_selection): New function.
11286 (x_handle_selection_event): Simplify.
11287 (x_get_foreign_selection): Don't ignore incoming requests while
11288 waiting for an answer; this will fail when we implement
11289 SAVE_TARGETS, and seems unnecessary anyway.
11290 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11291 (Vx_sent_selection_functions): Doc fix.
11292
0f4aebc0
LL
112932011-05-26 Leo Liu <sdl.web@gmail.com>
11294
11295 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11296
e61124cd
YM
112972011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11298
11299 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11300
11301 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11302 for fringe update if it has periodic bitmap.
ac389d0c 11303 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11304 and fringe_bitmap_periodic_p.
11305
11306 * fringe.c (get_fringe_bitmap_data): New function.
11307 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11308 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11309 row. Mark glyph row for fringe update if periodicity changed.
11310
11311 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11312 for fringe update unless it has periodic bitmap.
11313
f16d9837
KH
113142011-05-25 Kenichi Handa <handa@m17n.org>
11315
11316 * xdisp.c (get_next_display_element): Set correct it->face_id for
11317 a static composition.
11318
e1b90ef6
LL
113192011-05-24 Leo Liu <sdl.web@gmail.com>
11320
11321 * deps.mk (fns.o):
11322 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11323
11324 * fns.c (crypto_hash_function, Fsha1): New function.
11325 (Fmd5): Use crypto_hash_function.
11326 (syms_of_fns): Add Ssha1.
11327
7400048f
PE
113282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11329
11330 * gnutls.c: Remove unused macros.
11331 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11332 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11333 Remove macros that are defined and never used.
11334 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11335
abb71cf4
CY
113362011-05-22 Chong Yidong <cyd@stupidchicken.com>
11337
11338 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11339 (Fx_get_selection_internal): Minor cleanup.
11340 (Fx_own_selection_internal): Rename arguments for consistency with
11341 select.el.
11342
6307db39
PE
113432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11344
11345 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11346
f3d4e0a4
CY
113472011-05-22 Chong Yidong <cyd@stupidchicken.com>
11348
11349 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11350
4d8ade89
YM
113512011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11352
11353 * dispnew.c (scrolling_window): Don't exclude the case that the
11354 last enabled row in the desired matrix touches the bottom boundary.
11355
32078c8d
GM
113562011-05-21 Glenn Morris <rgm@gnu.org>
11357
11358 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11359 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11360 and add some more files.
32078c8d 11361
7285dc67
EZ
113622011-05-20 Eli Zaretskii <eliz@gnu.org>
11363
11364 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11365 report_file_error introduced by the change from 2011-05-07.
11366
89d1bd22
PE
113672011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11368
11369 * systime.h (Time): Define only if emacs is defined.
11370 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11371 where the include path doesn't have X11/X.h by default. See
11372 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11373
cd394be1 113742011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11375
11376 * composite.c (find_automatic_composition): Fix previous change.
11377
b9704ad9
GM
113782011-05-20 Glenn Morris <rgm@gnu.org>
11379
11380 * lisp.mk: New file, split from Makefile.in.
11381 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11382 (shortlisp): Remove.
11383 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11384
4a720484
GM
113852011-05-19 Glenn Morris <rgm@gnu.org>
11386
11387 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11388 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11389 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11390 (lisp): Set the order to that of loadup.el.
11391 (shortlisp): Make it a copy of $lisp.
11392 (SOME_MACHINE_LISP): Remove.
11393 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11394 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11395
a28d4396
KH
113962011-05-18 Kenichi Handa <handa@m17n.org>
11397
11398 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11399 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11400 (find_automatic_composition): Mostly rewrite for efficiency.
11401
a2b1fa8e
JB
114022011-05-18 Juanma Barranquero <lekktu@gmail.com>
11403
11404 * makefile.w32-in: Update dependencies.
11405
8e1f5610
CS
114062011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11407
11408 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11409 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11410
7025ee00 114112011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11412
cdfa6eab
PE
11413 Fix some integer overflow issues, such as string length overflow.
11414
06d6db33
PE
11415 * insdel.c (count_size_as_multibyte): Check for string overflow.
11416
2b4560a8
PE
11417 * character.c (lisp_string_width): Check for string overflow.
11418 Use EMACS_INT, not int, for string indexes and lengths; in
11419 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11420 the resulting string length overflows an EMACS_INT; instead,
11421 report a string overflow if no precision given. When checking for
11422 precision exhaustion, use a check that cannot possibly have
11423 integer overflow. (Bug#8675)
11424 * character.h (lisp_string_width): Adjust to new signature.
11425
cb93f9be
PE
11426 * alloc.c (string_overflow): New function.
11427 (Fmake_string): Use it. This doesn't change behavior, but saves
11428 a few bytes and will simplify future changes.
11429 * character.c (string_escape_byte8): Likewise.
11430 * lisp.h (string_overflow): New decl.
11431
1a1f3366
PE
11432 Fixups, following up to the user-interface timestamp change.
11433 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11434 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11435 * msdos.c (mouse_get_pos): Likewise.
11436 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11437 * w32gui.h (Time): Define by including "systime.h" rather than by
11438 declaring it ourselves. (Bug#8664)
11439
d4e3e4d3
PE
11440 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11441 * image.c (clear_image_cache): Likewise.
11442
f6a24d19
PE
11443 * term.c (term_mouse_position): Don't assume time_t wraparound.
11444
08dc5ae6
PE
11445 Be more systematic about user-interface timestamps.
11446 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11447 and sometimes 'EMACS_UINT', to represent these timestamps.
11448 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11449 This makes the code easier to follow, and makes it easier to catch
11450 integer overflow bugs such as Bug#8664.
11451 * frame.c (Fmouse_position, Fmouse_pixel_position):
11452 Use Time, not unsigned long, for user-interface timestamps.
11453 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11454 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11455 * keyboard.h (last_event_timestamp): Likewise.
11456 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11457 * menu.h (xmenu_show): Likewise.
11458 * term.c (term_mouse_position): Likewise.
11459 * termhooks.h (struct input_event.timestamp): Likewise.
11460 (struct terminal.mouse_position_hook): Likewise.
11461 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11462 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11463 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11464 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11465 what it was before.
11466 * menu.h, termhooks.h: Include "systime.h", for Time.
11467
8e55734a
PE
11468 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11469 Don't assume that the difference between two unsigned long values
11470 can fit into an integer. At this point, we know button_down_time
11471 <= event->timestamp, so the difference must be nonnegative, so
11472 there's no need to cast the result if double-click-time is
11473 nonnegative, as it should be; check that it's nonnegative, just in
11474 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11475 apart (about 25 days). (Bug#8664)
8e55734a 11476
841f1b75 11477 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11478 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11479
3e26f69c
PE
11480 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11481 that always fit in int. Use a sentinel instead of a counter, to
11482 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11483 * frame.h (struct frame): Use int for menu_bar_items_used
11484 instead of EMACS_INT, since it always fits in int.
3e26f69c 11485
5cc152c0
PE
11486 * menu.c (grow_menu_items): Check for int overflow.
11487
d89eb65e
PE
11488 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11489
5235bd3e
PE
11490 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11491 Before, the code was not consistent. These values cannot exceed
11492 2**31 - 1 so there's no need to make them unsigned.
11493 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11494 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11495 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11496 as modifiers.
11497 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11498
bc827e23
PE
11499 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11500 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11501 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11502 presumably because the widths might not match.
11503
78eb494e
PE
11504 * window.c (size_window): Avoid needless test at loop start.
11505
04f2d78b
CB
115062011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11507
11508 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11509
d2fc7e3d 115102011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11511
11512 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11513
d2fc7e3d 115142011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11515
11516 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11517 `width' to `bar_area_x' and `bar_area_width', respectively.
11518 (x_scroll_run): Take account of fringe background extension.
11519
04f2d78b
CB
11520 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11521 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11522 `bar_area_width', respectively.
11523 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11524 background extension.
11525
79b70037
GM
115262011-05-10 Jim Meyering <meyering@redhat.com>
11527
11528 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11529
2f142cc5
JB
115302011-05-10 Juanma Barranquero <lekktu@gmail.com>
11531
11532 * image.c (Finit_image_library): Return t for built-in image types,
11533 like pbm and xbm. (Bug#8640)
11534
57679c86
AS
115352011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11536
11537 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11538
888c9e86
EZ
115392011-05-07 Eli Zaretskii <eliz@gnu.org>
11540
b0512a1d
EZ
11541 * w32console.c (Fset_screen_color): Doc fix.
11542 (Fget_screen_color): New function.
11543 (syms_of_ntterm): Defsubr it.
11544
7285dc67
EZ
11545 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11546 unlink the temporary file if Fcall_process didn't create it in the
11547 first place.
11548 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11549 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11550 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11551 cue to call_process_cleanup not to close that handle.
11552
4d3fcc8e
BK
115532011-05-07 Ben Key <bkey76@gmail.com>
11554
11555 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11556 one of two shell specific rules, either bootstrap-temacs-CMD or
11557 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11558 to the previous implementation of the bootstrap-temacs rule.
11559 The bootstrap-temacs-CMD rule is similar to the previous
11560 implementation of the bootstrap-temacs rule except that it
11561 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11562 variable.
11563
11564 These changes, along with some changes to nt/configure.bat,
11565 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11566 earlier fix to add support for --cflags and --ldflags options
11567 that include quotes so that it works whether make uses cmd or
11568 sh as the shell.
11569
b4289b64
MA
115702011-05-06 Michael Albinus <michael.albinus@gmx.de>
11571
11572 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11573 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11574 is a constant.
11575 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11576 a string. Handle both cases.
11577 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11578 (Fdbus_register_method): Use Qinvalid_function.
11579
af4c0e28
JB
115802011-05-06 Juanma Barranquero <lekktu@gmail.com>
11581
11582 * makefile.w32-in: Update dependencies.
11583 (LISP_H): Add inttypes.h and stdin.h.
11584 (PROCESS_H): Add unistd.h.
11585
c51453d9
EZ
115862011-05-06 Eli Zaretskii <eliz@gnu.org>
11587
11588 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11589 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11590
8ff0ac3c 115912011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11592
4c4b566b
PE
11593 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11594
aab2b9b5
PE
11595 * term.c (vfatal): Remove stray call to va_end.
11596 It's not needed and the C Standard doesn't allow it here anyway.
11597
c378da0b
PE
11598 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11599 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11600
288b08c7
PE
11601 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11602 bytes.
11603
e3601888
PE
11604 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11605
db6c0e74
PE
11606 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11607
dd5963ea
PE
11608 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11609
88c9450f
PE
11610 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11611
2f9442b8
PE
11612 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11613
c032b5f8
PE
11614 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11615 * charset.c (Fdefine_charset_internal): Don't initialize
11616 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11617 32-bit int (Bug#8600).
a108c10b
PE
11618
11619 * lread.c (read_integer): Be more consistent with string-to-number.
11620 Use string_to_number to do the actual conversion; this avoids
11621 rounding errors and fixes some other screwups. Without this fix,
11622 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11623 (digit_to_number): Move earlier, for benefit of read_integer.
11624 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11625 not a digit in any supported base. (Bug#8602)
a108c10b 11626
ad5f9eea
PE
11627 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11628
aec1708a
PE
11629 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11630 to match comment at start of function. This also removes a
11631 GCC warning about overflow in a 32+64-bit port.
11632
47be4ab5
PE
11633 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11634
371cac43
PE
11635 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11636 Reported by Stefan Monnier in
11637 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11638 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11639 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11640
d01a7826
PE
11641 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11642 (EMACS_UINTPTR): Likewise, with uintptr_t.
11643
7fd47d5c
PE
11644 * lisp.h: Prefer 64-bit EMACS_INT if available.
11645 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11646 on 32-bit hosts that have 64-bit int, so that they can access
11647 large files.
122b0c86
PE
11648 However, temporarily disable this change unless the temporary
11649 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11650
8727937b
PE
11651 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11652
8ac068ac
PE
11653 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11654 This removes an assumption that EMACS_INT and long are the same
11655 width as pointers. The assumption is true for Emacs porting targets
11656 now, but we want to make other targets possible.
11657 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11658 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11659 In the rest of the code, change types of integers that hold casted
11660 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11661 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11662 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11663 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11664 No need to cast type when ORing.
11665 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11666 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11667 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11668 assume EMACS_INT is the same width as char *.
11669 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11670 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11671 Remove no-longer-needed casts.
11672 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11673 (xg_tool_bar_help_callback, xg_make_tool_item):
11674 Use EMACS_INTPTR to hold an integer
11675 that will be cast to void *; this can avoid a GCC warning
11676 if EMACS_INT is not the same width as void *.
11677 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11678 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11679 (current_message_1, set_message_1):
11680 Use a local to convert to proper width without a cast.
11681 * xmenu.c (dialog_selection_callback): Likewise.
11682
ede49d71
PE
11683 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11684 Also, don't assume VALBITS / RAND_BITS is less than 5,
11685 and don't rely on undefined behavior when shifting a 1 left into
11686 the sign bit.
11687 * lisp.h (get_random): Change signature to match.
11688
2f30ecd0
PE
11689 * lread.c (hash_string): Use size_t, not int, for hash computation.
11690 Normally we prefer signed values; but hashing is special, because
11691 it's better to use unsigned division on hash table sizes so that
11692 the remainder is nonnegative. Also, size_t is the natural width
11693 for hashing into memory. The previous code used 'int', which doesn't
11694 retain enough info to hash well into very large tables.
11695 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11696
2a866e7b
PE
11697 * dbusbind.c: Don't possibly lose pointer info when converting.
11698 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11699 Use XPNTR rather than XHASH, so that the high-order bits of
11700 the pointer aren't lost when converting through void *.
11701
51639eac
PE
11702 * eval.c (Fautoload): Don't double-shift a pointer.
11703
92394119
PE
11704 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11705
dbdb9a7c
JB
117062011-05-06 Juanma Barranquero <lekktu@gmail.com>
11707
11708 * gnutls.c (DEF_GNUTLS_FN):
11709 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11710
db7a0b4f
AS
117112011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11712
11713 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11714 marker. (Bug#8610)
11715
cd394be1 117162011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11717
11718 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11719 New version that can reserve upto 2GB of heap space.
11720
f7ff1b0f 117212011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11722
11723 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11724
639c109b
TZ
117252011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11726
11727 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11728 `gnutls_certificate_set_x509_key_file'.
11729
d2127135
JB
117302011-05-05 Juanma Barranquero <lekktu@gmail.com>
11731
11732 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11733 Update dependencies.
11734
e968f4f3
JB
117352011-05-04 Juanma Barranquero <lekktu@gmail.com>
11736
11737 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11738 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11739 Remove unused parameter `fildes'.
11740 * process.c (read_process_output, send_process): Don't pass it.
11741
84d358f0
JB
117422011-05-04 Juanma Barranquero <lekktu@gmail.com>
11743
11744 Fix previous change: the library cache is defined in w32.c.
11745 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11746 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11747
0898ca10
JB
117482011-05-04 Juanma Barranquero <lekktu@gmail.com>
11749
11750 Implement dynamic loading of GnuTLS on Windows.
11751
11752 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11753 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11754 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11755 Declare.
11756
11757 * gnutls.c (Qgnutls_dll): Define.
11758 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11759 (gnutls_*): Declare function pointers.
11760 (init_gnutls_functions): New function to initialize function pointers.
11761 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11762 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11763 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11764 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11765 (emacs_gnutls_write, emacs_gnutls_read)
11766 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11767 (Fgnutls_available_p): New function.
11768 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11769 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11770 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11771
11772 * image.c: Include w32.h.
11773 (Vimage_type_cache): Delete.
11774 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11775 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11776 (w32_delayed_load): Move to w32.c.
11777
11778 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11779
11780 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11781 (w32_delayed_load): Move from image.c. When loading a library, record
11782 its filename in the :loaded-from property of the library id.
11783 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11784 Initialize and staticpro them.
11785 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11786
11787 * process.c: Include lisp.h before w32.h, not after.
11788 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11789 instead of gnutls_record_check_pending.
11790
11791 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11792
ff4de4aa
TZ
117932011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11794
11795 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11796 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11797 as passed in.
11798
abe95abb
JD
117992011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11800
11801 * xterm.c (x_set_frame_alpha): Do not set property on anything
11802 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11803
e16e55d4
JB
118042011-05-02 Juanma Barranquero <lekktu@gmail.com>
11805
11806 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11807
bafcf6a5
JB
118082011-05-02 Juanma Barranquero <lekktu@gmail.com>
11809
11810 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11811 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11812 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11813 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11814 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11815 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11816 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11817 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11818 (Qgnutls_bootprop_callbacks_verify): Make static.
11819
e7a6747f
AS
118202011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11821
19ed11ba
AS
11822 * callproc.c: Indentation fixup.
11823
e7a6747f 11824 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11825 (wait_for_termination, interruptible_wait_for_termination):
11826 Move after wait_for_termination_1.
e7a6747f 11827
1ef14cb4
LMI
118282011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11829
11830 * sysdep.c (interruptible_wait_for_termination): New function
11831 which is like wait_for_termination, but allows keyboard
11832 interruptions.
11833
11834 * callproc.c (Fcall_process): Add (:file "file") as an option for
11835 the STDOUT buffer.
11836 (Fcall_process_region): Ditto.
11837
330d880c
EZ
118382011-04-30 Eli Zaretskii <eliz@gnu.org>
11839
8db90b73
EZ
11840 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11841 rather than `XVECTOR (FOO)->size'.
11842
330d880c
EZ
11843 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11844 inttypes.h, as a gnulib replacement is used if it not available in
11845 system headers.
11846
15cbd324
EZ
118472011-04-21 Eli Zaretskii <eliz@gnu.org>
11848
11849 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11850 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11851 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11852
11853 * coding.c (coding_alloc_by_realloc): Error out if destination
11854 will grow beyond MOST_POSITIVE_FIXNUM.
11855 (decode_coding_emacs_mule): Abort if there isn't enough place in
11856 charbuf for the composition carryover bytes. Reserve an extra
11857 space for up to 2 characters produced in a loop.
11858 (decode_coding_iso_2022): Abort if there isn't enough place in
11859 charbuf for the composition carryover bytes.
11860
118612011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11862
ae940cca
EZ
11863 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11864 aborting when %lld or %lll format is passed.
11865 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11866 %llo or %llx format is passed. (Bug#8545)
11867
03ab8921
EZ
11868 * window.c (window_scroll_line_based): Use a marker instead of
11869 simple variables to record original value of point. (Bug#7952)
11870
afda1437
EZ
11871 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11872 produced by %s or %c overflows available buffer space. (Bug#8545)
11873
f76dee0c
PE
118742011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11875
11876 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11877 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11878
fdc5744d
JB
118792011-04-28 Juanma Barranquero <lekktu@gmail.com>
11880
11881 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11882
638f053a
JB
118832011-04-28 Juanma Barranquero <lekktu@gmail.com>
11884
11885 * keyboard.c (Qdelayed_warnings_hook): Define.
11886 (command_loop_1): Run `delayed-warnings-hook'
11887 if Vdelayed_warnings_list is non-nil.
11888 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11889 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11890
d178f871
EZ
118912011-04-28 Eli Zaretskii <eliz@gnu.org>
11892
11893 * doprnt.c (doprnt): Don't return value smaller than the buffer
11894 size if the message was truncated. (Bug#8545).
11895
b124fd93
JB
118962011-04-28 Juanma Barranquero <lekktu@gmail.com>
11897
11898 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11899 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11900
e810457d
PE
119012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11902
11903 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11904
ea51cceb
JB
119052011-04-27 Juanma Barranquero <lekktu@gmail.com>
11906
11907 * makefile.w32-in: Update dependencies.
11908
94dcfacf
EZ
119092011-04-27 Eli Zaretskii <eliz@gnu.org>
11910
11911 Improve `doprnt' and its usage. (Bug#8545)
11912 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11913 `format_end'. Remove support for %l as a conversion specifier.
11914 Don't use xrealloc. Improve diagnostics when the %l size modifier
11915 is used. Update the commentary.
11916
11917 * eval.c (verror): Simplify calculation of size_t.
11918
11919 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11920 messages.
11921
f61f41d7
PE
119222011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11923
11924 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11925 change.
11926
96fb4434
PE
119272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11928
11929 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11930 This makes this file independent of the recent pseudovector change.
11931
671875da 119322011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11933
69e9b5a3
PE
11934 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11935
b5f869a7 11936 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11937 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11938 Remove unused local.
c8926152 11939 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11940
841a1577 11941 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11942 GCC 4.6.0 optimizes based on type-based alias analysis.
11943 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11944 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11945 != &v->size, and therefore "v->size = 1; b->size = 2; return
11946 v->size;" must therefore return 1. This assumption is incorrect
11947 for Emacs, since it type-puns struct Lisp_Vector * with many other
11948 types. To fix this problem, this patch adds a new type struct
f904488f 11949 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11950 and pseudovectors, and helps optimizing compilers not get fooled
11951 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11952 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11953 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11954 the size member.
eab3844f
PE
11955 (XSETPVECTYPE): Rewrite in terms of new macro.
11956 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11957 This is a bit clearer, and further avoids the possibility of
11958 undesirable aliasing.
11959 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11960 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11961 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11962 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11963 (ASIZE): Now uses header.size rather than size.
11964 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11965 to avoid the hassle of writing XVECTOR (foo)->header.size.
11966 (struct vectorlike_header): New type.
eab3844f
PE
11967 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11968 object, to help avoid aliasing.
11969 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11970 (SUBRP): Likewise, since Lisp_Subr is a special case.
11971 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11972 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11973 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11974 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11975 changed to be "header.size" and "header.next".
11976 * buffer.h (struct buffer): Likewise.
11977 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11978 * frame.h (struct frame): Likewise.
11979 * process.h (struct Lisp_Process): Likewise.
11980 * termhooks.h (struct terminal): Likewise.
11981 * window.c (struct save_window_data, struct saved_window): Likewise.
11982 * window.h (struct window): Likewise.
11983 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11984 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11985 * buffer.c (init_buffer_once): Likewise.
11986 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11987 special case.
11988 * process.c (Fformat_network_address): Use local var for size,
11989 for brevity.
11990
0df1eac5
PE
11991 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11992
847ab9d1 11993 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11994 * data.c (atof): Remove decl; no longer used or needed.
11995 (digit_to_number): Move to lread.c.
11996 (Fstring_to_number): Use new string_to_number function, to be
11997 consistent with how the Lisp reader treats infinities and NaNs.
11998 Do not assume that floating-point numbers represent EMACS_INT
11999 without losing information; this is not true on most 64-bit hosts.
12000 Avoid double-rounding errors, by insisting on integers when
12001 parsing non-base-10 numbers, as the documentation specifies.
12002 * lisp.h (string_to_number): New decl, replacing ...
12003 (isfloat_string): Remove.
bc0a5c13 12004 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12005 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12006 appears to have been a coding error. Similarly, do not accept
12007 strings like +-1e0 as floating point numbers. Do not report
12008 overflow for integer overflows unless the base is not 10 which
12009 means we have no simple and reliable way to continue.
12010 Break out the floating-point parsing into a new
12011 function string_to_number, so that Fstring_to_number parses
12012 floating point numbers consistently with the Lisp reader.
04f2d78b 12013 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12014 (E_CHAR, EXP_INT): Remove, replacing with ...
12015 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12016 (string_to_number): New function, replacing isfloat_string.
12017 This function checks for valid syntax and produces the resulting
12018 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12019 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12020 so that overflow for non-base-10 numbers is reported only when
12021 there's no portable and simple way to convert to floating point.
452f4150 12022
67769ffc
PE
12023 * textprop.c (set_text_properties_1): Rewrite for clarity,
12024 and to avoid GCC warning about integer overflow.
12025
c20db43f
PE
12026 * intervals.h (struct interval): Use EMACS_INT for members
12027 where EMACS_UINT might cause problems. See
12028 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12029 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12030 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12031 All uses changed.
37aa2f85
PE
12032 (offset_intervals): Tell GCC not to worry about length overflow
12033 when negating a negative length.
c20db43f 12034
2538aa2f
PE
12035 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12036 (overrun_check_free): Likewise.
12037
f2d3008d
PE
12038 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12039 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12040 word size.
12041
ec8df744
PE
12042 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12043 (gnutls_make_error): Rename local to avoid shadowing.
12044 (gnutls_emacs_global_deinit): ifdef out; not used.
12045 (Fgnutls_boot): Use const for pointer to readonly storage.
12046 Comment out unused local. Fix pointer signedness problems.
12047
640ee02d
PE
12048 * lread.c (openp): Don't stuff size_t into an 'int'.
12049 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12050 about possible signed overflow.
12051
6048fb2a
PE
12052 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12053 (GDK_KEY_g): Don't define if already defined.
12054 (xg_prepare_tooltip): Avoid pointer signedness problem.
12055 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12056
fa3c87e1
PE
12057 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12058 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12059
2172544b
PE
12060 * xfns.c (Fx_window_property): Simplify a bit,
12061 to make a bit faster and to avoid GCC 4.6.0 warning.
12062 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12063
9b821a21
PE
12064 * fns.c (internal_equal): Don't assume size_t fits in int.
12065
3c616cfa
PE
12066 * alloc.c (compact_small_strings): Tighten assertion a little.
12067
c2982e87
PE
12068 Replace pEd with more-general pI, and fix some printf arg casts.
12069 * lisp.h (pI): New macro, generalizing old pEd macro to other
12070 conversion specifiers. For example, use "...%"pI"d..." rather
12071 than "...%"pEd"...".
12072 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12073 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12074 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12075 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12076 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12077 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12078 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12079 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12080 64-bit hosts.
12081 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12082 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12083 * print.c (safe_debug_print, print_object): Likewise.
12084 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12085 to int.
6f04d126
PE
12086 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12087 avoiding the 0 flag, which is not portable.
c2982e87
PE
12088 * process.c (Fmake_network_process): Use pI to avoid cast.
12089 * region-cache.c (pp_cache): Likewise.
12090 * xdisp.c (decode_mode_spec): Likewise.
12091 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12092 behavior on 64-bit hosts with printf arg.
6f04d126 12093 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12094 (x_stop_queuing_selection_requests): Likewise.
12095 (x_get_window_property): Don't truncate byte count to an 'int'
12096 when tracing.
0b432f21 12097
5e073ec7
PE
12098 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12099 here, since it parses constructs like leading '-' and spaces,
12100 which are not wanted; and it overflows with large numbers.
12101 Instead, simply match F[0-9]+, which is what is wanted anyway.
12102
36372bf9
PE
12103 * alloc.c: Remove unportable assumptions about struct layout.
12104 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12105 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12106 (allocate_vectorlike, make_pure_vector): Use the new macros,
12107 plus offsetof, to remove unportable assumptions about struct layout.
12108 These assumptions hold on all porting targets that I know of, but
12109 they are not guaranteed, they're easy to remove, and removing them
12110 makes further changes easier.
12111
0b432f21
PE
12112 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12113 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12114 (string_overrun_cookie): Now const. Use initializers that
12115 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12116 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12117 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12118 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12119 multiple of sizeof (EMACS_INT); it need not be, if
12120 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12121 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12122
895009e1
JB
121232011-04-26 Juanma Barranquero <lekktu@gmail.com>
12124
12125 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12126
6a7a1b0b
TZ
121272011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12128
12129 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12130 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12131 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12132
841a1577 121332011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12134
12135 * lisp.h (Qdebug): List symbol.
895009e1 12136 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12137 * keyboard.c (debug-on-event): New variable.
12138 (handle_user_signal): Break into debugger when debug-on-event
12139 matches the current signal symbol.
12140
f2d3ba6f
DN
121412011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12142
12143 * alloc.c (check_sblock, check_string_bytes)
12144 (check_string_free_list): Convert to standard C.
12145
42ce4c63
TZ
121462011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12147
12148 * w32.c (emacs_gnutls_push): Fix typo.
12149
825cd63c
EZ
121502011-04-25 Eli Zaretskii <eliz@gnu.org>
12151
fb11d64d
EZ
12152 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12153 "cast to pointer from integer of different size".
12154
825cd63c
EZ
12155 Improve doprnt and its use in verror. (Bug#8545)
12156 * doprnt.c (doprnt): Document the set of format control sequences
12157 supported by the function. Use SAFE_ALLOCA instead of always
12158 using `alloca'.
12159
12160 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12161 is one byte too soon. Don't use xrealloc; instead xfree and
12162 xmalloc anew.
12163
e061a11b
TZ
121642011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12165
12166 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12167 callbacks stage.
12168
12169 * gnutls.c: Renamed global_initialized to
12170 gnutls_global_initialized. Added internals for the
12171 :verify-hostname-error, :verify-error, and :verify-flags
12172 parameters of `gnutls-boot' and documented those parameters in the
12173 docstring. Start callback support.
9173deec
JB
12174 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12175 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12176 on error. Return error code.
e061a11b
TZ
12177 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12178 (emacs_gnutls_read): Likewise.
12179 (Fgnutls_boot): Return handshake error code.
12180 (emacs_gnutls_handle_error): New function.
12181 (wsaerror_to_errno): Likewise.
12182
12183 * w32.h (emacs_gnutls_pull): Add prototype.
12184 (emacs_gnutls_push): Likewise.
12185
12186 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12187 (emacs_gnutls_push): Likewise.
12188
121892011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12190
12191 * process.c (wait_reading_process_output): Check if GnuTLS
12192 buffered some data internally if no FDs are set for TLS
12193 connections.
12194
12195 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12196 (LIBS): Link to USER_LIBS.
12197 ($(BLD)/gnutls.$(0)): New target.
12198
fa6996bc
EZ
121992011-04-24 Eli Zaretskii <eliz@gnu.org>
12200
eb35682e
EZ
12201 * xdisp.c (handle_single_display_spec): Rename the
12202 display_replaced_before_p argument into display_replaced_p, to
12203 make it consistent with the commentary. Fix typos in the
12204 commentary.
12205
e2ad650c
EZ
12206 * textprop.c (syms_of_textprop): Remove dead code.
12207 (copy_text_properties): Delete obsolete commentary about an
12208 interface that was deleted long ago. Fix typos in the description
12209 of arguments.
12210
1b2de274
EZ
12211 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12212 to changes in oldXMenu/XMenu.h from 2011-04-16.
12213 <menu_help_message, prev_menu_help_message>: Constify.
12214 (IT_menu_make_room): menu->help_text is now `const char **';
12215 adjust.
12216
12217 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12218 to changes in oldXMenu/XMenu.h from 2011-04-16.
12219 (struct XMenu): Declare `help_text' `const char **'.
12220
12221 * xfaces.c <Qunspecified>: Make extern again.
12222
12223 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12224 required by POSIX.
1b2de274 12225
762b15be
EZ
12226 * doc.c (get_doc_string): Improve the format passed to `error'.
12227
12228 * doprnt.c (doprnt): Improve commentary.
12229
12230 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12231
12232 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12233 them with etags.
12234
f1052e5d
EZ
12235 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12236 changes in globals.h immediately force recompilation.
762b15be
EZ
12237 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12238 $(CURDIR)/s/ms-w32.h.
12239 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12240
fa6996bc
EZ
12241 * character.c (Fchar_direction): Function deleted.
12242 (syms_of_character): Don't defsubr it.
12243 <char-direction-table>: Deleted.
12244
e6c3da20
EZ
122452011-04-23 Eli Zaretskii <eliz@gnu.org>
12246
12247 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12248 * doprnt.c: Include limits.h.
12249 (SIZE_MAX): New macro.
04f2d78b
CB
12250 (doprnt): Return a size_t value. 2nd arg is now size_t.
12251 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12252 Improve overflow protection. Support `l' modifier for integer
12253 conversions. Support %l conversion. Don't assume an EMACS_INT
12254 argument for integer conversions and for %c.
12255
12256 * lisp.h (doprnt): Restore prototype.
12257
12258 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12259 $(SRC)/character.h.
12260
12261 * Makefile.in (base_obj): Add back doprnt.o.
12262
12263 * deps.mk (doprnt.o): Add back prerequisites.
12264 (callint.o): Depend on character.h.
12265
12266 * eval.c (internal_lisp_condition_case): Include the handler
12267 representation in the error message.
12268 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12269 when breaking from the loop.
12270
12271 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12272
12273 * callint.c (Fcall_interactively): When displaying error message
12274 about invalid control letter, pass the character's codepoint, not
12275 a pointer to its multibyte form. Improve display of the character
12276 in octal and display also its hex code.
12277
12278 * character.c (char_string): Use %x to display the (unsigned)
12279 codepoint of an invalid character, to avoid displaying a bogus
12280 negative value.
12281
12282 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12283 `error', not SYMBOL_NAME itself.
12284
12285 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12286 character arguments to `error'.
12287
12288 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12289 to `error' in error message about FINAL_CHAR argument. Make sure
12290 FINAL_CHAR is a character, and use %c when it is passed as
12291 argument to `error'.
12292
4ffd0d6b 122932011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12294
12295 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12296
12297 * w32.c: Include <time.h>.
12298 (sys_localtime): New function.
12299
4ffd0d6b 123002011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12301
12302 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12303
4ffd0d6b 12304 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12305
4ffd0d6b 123062011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12307
4ffd0d6b
GM
12308 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12309 zombies (Bug#8467).
aac0c6e3 12310
04c56954
EZ
123112011-04-19 Eli Zaretskii <eliz@gnu.org>
12312
12313 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12314 gl_state.e_property when gl_state.object is Qt.
12315
12316 * insdel.c (make_gap_larger): Remove limitation of buffer size
12317 to <= INT_MAX.
12318
16a43933
CY
123192011-04-18 Chong Yidong <cyd@stupidchicken.com>
12320
12321 * xdisp.c (lookup_glyphless_char_display)
12322 (produce_glyphless_glyph): Handle cons cell entry in
12323 glyphless-char-display.
12324 (Vglyphless_char_display): Document it.
12325
12326 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12327 glyphless-char-display.
12328
4581706e
CY
123292011-04-17 Chong Yidong <cyd@stupidchicken.com>
12330
12331 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12332
12333 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12334
12335 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12336 definition for no-X builds.
12337
4887c6e2 123382011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12339
fd35b6f9
PE
12340 Static checks with GCC 4.6.0 and non-default toolkits.
12341
5c1ccb01
PE
12342 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12343
006c5daa
PE
12344 * process.c (keyboard_bit_set): Define only if SIGIO.
12345 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12346 (send_process): Repair possible setjmp clobbering.
12347
efc736d3
PE
12348 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12349
4e2fe2e6
PE
12350 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12351
f97334a2
PE
12352 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12353
4e75f29d
PE
12354 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12355 Define only if needed.
12356
90efadd1
PE
12357 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12358 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12359 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12360
3c647824
PE
12361 * dispextern.h (struct redisplay_interface): Rename param
12362 to avoid shadowing.
e264f262 12363 * termhooks.h (struct terminal): Likewise.
761383f4 12364 * xterm.c (xembed_send_message): Likewise.
3c647824 12365
b58c5c4a
PE
12366 * insdel.c (make_gap_smaller): Define only if
12367 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12368
cad59032
PE
12369 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12370 it.
12371
c339dc2e
PE
12372 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12373 so that we aren't warned about unused symbols.
12374
91a3e27b
PE
12375 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12376
399c71d3 12377 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12378
8ffc96f5
PE
12379 * xfns.c (x_real_positions): Mark locals as initialized.
12380
eef9bc79
PE
12381 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12382
098db9dd
PE
12383 * xterm.c: Fix problems found by static analysis with other toolkits.
12384 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12385 (x_dispatch_event): Declare static if USE_GTK, and
12386 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12387 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12388 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12389 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12390 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12391
eb18f6cc
PE
12392 * xmenu.c (menu_help_callback): Pointer type fixes.
12393 Use const pointers when pointing at readonly data. Avoid pointer
12394 signedness clashes.
12395 (FALSE): Remove unused macro.
12396 (update_frame_menubar): Remove unused decl.
12397
1fe72bf8
PE
12398 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12399
60d9e1db
PE
12400 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12401 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12402 (single_menu_item): Rename local to avoid shadowing.
12403
39261c26
PE
12404 * keyboard.c (make_lispy_event): Remove unused local var.
12405
018c5e19
PE
12406 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12407 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12408
63d2b86e
PE
12409 * bitmaps: Change bitmaps from unsigned char back to the X11
12410 compatible char. Avoid the old compiler warnings about
12411 out-of-range initializers by using, for example, '\xab' rather
12412 than 0xab.
12413
aefd87e1
PE
12414 * xgselect.c (xgselect_initialize): Check vs interface
12415 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12416
bf501fb9
PE
12417 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12418
e9829fdf
PE
12419 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12420 to read-only memory.
12421
1086c095
PE
12422 * fns.c (vector): Remove; this old hack is no longer needed.
12423
2baccd04 12424 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12425 Remove unused var.
dde42981 12426 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12427
72391843 12428 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12429
436c16df 12430 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12431 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12432 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12433
92bb796d 12434 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12435 (x_term_init): Remove local to avoid shadowing.
92bb796d 12436
764430a3 12437 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12438
12439 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12440 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12441
d1dfb56c
EZ
124422011-04-16 Eli Zaretskii <eliz@gnu.org>
12443
c4354cb4
EZ
12444 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12445
d1dfb56c
EZ
12446 Fix regex.c, syntax.c and friends for buffers > 2GB.
12447 * syntax.h (struct gl_state_s): Declare character position members
12448 EMACS_INT.
12449
12450 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12451
04f2d78b
CB
12452 * textprop.c (verify_interval_modification, interval_of):
12453 Declare arguments EMACS_INT.
d1dfb56c
EZ
12454
12455 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12456 EMACS_INT.
12457
12458 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12459
12460 * indent.c (Fvertical_motion): Local variable it_start is now
12461 EMACS_INT.
12462
12463 * regex.c (re_match, re_match_2, re_match_2_internal)
12464 (bcmp_translate, regcomp, regexec, print_double_string)
12465 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12466 (re_compile_pattern, re_exec): Declare arguments and local
12467 variables `size_t' and `ssize_t' and return values `regoff_t', as
12468 appropriate.
12469 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12470 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12471 <compile_stack_type>: `size' and `avail' are now `size_t'.
12472
12473 * regex.h <regoff_t>: Use ssize_t, not int.
12474 (re_search, re_search_2, re_match, re_match_2): Arguments that
12475 specify buffer/string position and length are now ssize_t and
12476 size_t. Return type is regoff_t.
12477
613052cd
BK
124782011-04-16 Ben Key <bkey76@gmail.com>
12479
12480 * nsfont.m: Fixed bugs in ns_get_family and
12481 ns_descriptor_to_entity that were caused by using free to
12482 deallocate memory blocks that were allocated by xmalloc (via
12483 xstrdup). This caused Emacs to crash when compiled with
12484 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12485 --enable-checking=xmallocoverrun). xfree is now used to
12486 deallocate these memory blocks.
12487
4170f62f 124882011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12489
71b41406
PE
12490 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12491
9587a89d
PE
12492 emacs_write: Accept and return EMACS_INT for sizes.
12493 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12494 et seq.
12495 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12496 Accept and return EMACS_INT.
12497 (emacs_gnutls_write): Return the number of bytes written on
12498 partial writes.
12499 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12500 (emacs_read, emacs_write): Remove check for negative size, as the
12501 Emacs source code has been audited now.
9587a89d
PE
12502 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12503 (emacs_read, emacs_write): Use it.
273a5f82
PE
12504 * process.c (send_process): Adjust to the new signatures of
12505 emacs_write and emacs_gnutls_write. Do not attempt to store
12506 a byte offset into an 'int'; it might overflow.
9587a89d 12507 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12508
3e047f51
PE
12509 * sound.c: Don't assume sizes fit in 'int'.
12510 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12511 Return EMACS_INT, not int.
3e047f51 12512 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12513 Accept EMACS_INT, not int.
12514 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12515 record read return values.
12516
cc39a9db
BK
125172011-04-15 Ben Key <bkey76@gmail.com>
12518
c9d0ec6d
JB
12519 * keyboard.c (Qundefined): Don't declare static since it is used
12520 in nsfns.m.
12521 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12522 static since they are used in nsfont.m.
cc39a9db 12523
6c60eb9f
SM
125242011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12525
12526 * process.c (Qprocessp): Don't declare static.
12527 * lisp.h (Qprocessp): Declare again.
12528
7990b61a
JB
125292011-04-15 Juanma Barranquero <lekktu@gmail.com>
12530
12531 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12532
5d4cb038
PE
125332011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12534
8bd7b830 12535 Improve C-level modularity by making more things 'static'.
cd64ea1d 12536
e3b27b31
PE
12537 Don't publish debugger-only interfaces to other modules.
12538 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12539 (verify_bytepos, count_markers): Move decls to the only modules
12540 that need them.
12541 * region-cache.h (pp_cache): Likewise.
12542 * window.h (check_all_windows): Likewise.
12543 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12544
5d4cb038
PE
12545 * sysdep.c (croak): Now static, if
12546 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12547 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12548
12549 * alloc.c (refill_memory_reserve): Now static if
12550 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12551 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12552
e87b6180
PE
12553 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12554 Define only if USE_LUCID.
12555
ac64929e
PE
12556 * xrdb.c (x_customization_string, x_rm_string): Now static.
12557
6f37259d
PE
12558 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12559 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12560
1683e3ab
PE
12561 * xdisp.c (draw_row_with_mouse_face): Now static.
12562 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12563
de9c2632
PE
12564 * window.h (check_all_windows): Mark externally visible.
12565
2b96acb7
PE
12566 * window.c (window_deletion_count): Now static.
12567
12568 * undo.c: Make symbols static if they're not exported.
12569 (last_undo_buffer, last_boundary_position, pending_boundary):
12570 Now static.
12571
50436f33
PE
12572 * textprop.c (interval_insert_behind_hooks): Now static.
12573 (interval_insert_in_front_hooks): Likewise.
12574
64520e5c
PE
12575 * term.c: Make symbols static if they're not exported.
12576 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12577 (max_frame_lines, tty_set_terminal_modes):
12578 (tty_reset_terminal_modes, tty_turn_off_highlight):
12579 (get_tty_terminal): Now static.
12580 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12581 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12582 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12583 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12584 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12585
1fa53021
PE
12586 * sysdep.c: Make symbols static if they're not exported.
12587 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12588 Now static.
12589 (sigprocmask_set, full_mask): Remove; unused.
12590 (wait_debugging): Mark as visible.
12591 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12592 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12593
d4b43b22
PE
12594 * syntax.c (syntax_temp): Define only if !__GNUC__.
12595
b7c513d0
PE
12596 * sound.c (current_sound_device, current_sound): Now static.
12597
989b29ad
PE
12598 * search.c (searchbufs, searchbuf_head): Now static.
12599
13a55a78
PE
12600 * scroll.c (scroll_cost): Remove; unused.
12601 * dispextern.h (scroll_cost): Remove decl.
12602
de68a1fc
PE
12603 * region-cache.h (pp_cache): Mark as externally visible.
12604
40ccffa6
PE
12605 * process.c: Make symbols static if they're not exported.
12606 (process_tick, update_tick, create_process, chan_process):
12607 (Vprocess_alist, proc_buffered_char, datagram_access):
12608 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12609 (deactivate_process): Mark defn as static, as well as decl.
12610 * lisp.h (create_process): Remove decl.
12611 * process.h (chan_process, Vprocess_alist): Remove decls.
12612
ad64fc97
PE
12613 * print.c: Make symbols static if they're not exported.
12614 (print_depth, new_backquote_output, being_printed, print_buffer):
12615 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12616 (print_interval, print_number_index, initial_stderr_stream):
12617 Now static.
12618 * lisp.h (Fprinc): Remove decl.
12619 (debug_output_compilation_hack): Mark as externally visible.
12620
adddb265
PE
12621 * sysdep.c (croak): Move decl from here to syssignal.h.
12622 * syssignal.h (croak): Put it here, so the API can be checked when
12623 'croak' is called from dissociate_if_controlling_tty.
12624
1717ede2
PE
12625 * minibuf.c: Make symbols static if they're not exported.
12626 (minibuf_save_list, choose_minibuf_frame): Now static.
12627 * lisp.h (choose_minibuf_frame): Remove decl.
12628
fa5fb2bc
PE
12629 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12630
1e3890d1
PE
12631 * lread.c: Make symbols static if they're not exported.
12632 (read_objects, initial_obarray, oblookup_last_bucket_number):
12633 Now static.
12634 (make_symbol): Remove; unused.
12635 * lisp.h (initial_obarray, make_symbol): Remove decls.
12636
8a1414fa
PE
12637 * keyboard.c: Make symbols static if they're not exported.
12638 (single_kboard, recent_keys_index, total_keys, recent_keys):
12639 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12640 (this_single_command_key_start, echoing, last_auto_save):
12641 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12642 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12643 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12644 (Vlispy_mouse_stem, double_click_count):
12645 Now static.
12646 (force_auto_save_soon): Define only if SIGDANGER.
12647 (ignore_mouse_drag_p): Now static if
12648 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12649 (print_help): Remove; unused.
12650 (stop_character, last_timer_event): Mark as externally visible.
12651 * keyboard.h (ignore_mouse_drag_p): Declare only if
12652 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12653 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12654 * lisp.h (echoing): Remove decl.
12655 (force_auto_save_soon): Declare only if SIGDANGER.
12656 * xdisp.c (redisplay_window): Simplify code, to make it more
12657 obvious that ignore_mouse_drag_p is not accessed if !defined
12658 USE_GTK && !defined HAVE_NS.
12659
93ea6e8f
PE
12660 * intervals.c: Make symbols static if they're not exported.
12661 (merge_properties_sticky, merge_interval_right, delete_interval):
12662 Now static.
12663 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12664
77382fcc
PE
12665 * insdel.c: Make symbols static if they're not exported.
12666 However, leave prepare_to_modify_buffer alone. It's never
12667 called from outside this function, but that appears to be a bug.
12668 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12669 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12670 (adjust_after_replace_noundo): Remove; unused.
12671 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12672 (signal_before_change): Remove decls.
77382fcc 12673
9306c32e
PE
12674 * indent.c (val_compute_motion, val_vmotion): Now static.
12675
cd44d2eb
PE
12676 * image.c: Make symbols static if they're not exported.
12677 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12678 if USE_GTK.
12679 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12680 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12681
ad9a7a06
PE
12682 * fringe.c (standard_bitmaps): Now static.
12683 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12684
81626931
PE
12685 * frame.c: Make symbols static if they're not exported.
12686 (x_report_frame_params, make_terminal_frame): Now static.
12687 (get_frame_param): Now static, unless HAVE_NS.
12688 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12689 (x_get_resource_string): Remove; not used.
12690 * frame.h (make_terminal_frame, x_report_frame_params):
12691 (x_get_resource_string); Remove decls.
12692 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12693 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12694
239f9db9
PE
12695 * font.c, fontset.c: Make symbols static if they're not exported.
12696 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12697 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12698 * font.c (font_close_object): Now static.
12699 * font.h (font_close_object): Remove.
12700 * fontset.c (FONTSET_OBJLIST): Remove.
12701 (free_realized_fontset) #if-0 the body, which does nothing.
12702 (face_suitable_for_char_p): #if-0, as it's never called.
12703 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12704 * xfaces.c (face_at_string_position):
12705 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12706 since 0 is always ASCII.
12707
dfcf3579
PE
12708 * fns.c (weak_hash_tables): Now static.
12709
5045092b
PE
12710 * fileio.c: Make symbols static if they're not exported.
12711 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12712 (Vwrite_region_annotation_buffers): Now static.
12713
57a96f5c
PE
12714 * eval.c: Make symbols static if they're not exported.
12715 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12716 * lisp.h (backtrace_list): Remove decl.
12717
35f08c38
PE
12718 * emacs.c: Make symbols static if they're not exported.
12719 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12720 (fatal_error_code, fatal_error_signal_hook, standard_args):
12721 Now static.
12722 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12723 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12724 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12725 * lisp.h (fatal_error_signal_hook): Remove decl.
12726 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12727
f44bd759
PE
12728 * editfns.c: Move a (normally-unused) function to its only use.
12729 * editfns.c, lisp.h (get_operating_system_release): Remove.
12730 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12731 worth the hassle of breaking this out.
12732
b532497d
PE
12733 * xterm.c: Make symbols static if they're not exported.
12734 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12735 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12736 (x_destroy_window, x_delete_display):
12737 Now static.
12738 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12739 (x_mouse_leave): Remove; unused.
12740 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12741 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12742 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12743 Remove decls.
12744 (x_mouse_leave): Declare only if WINDOWSNT.
12745 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12746 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12747 USE_X_TOOLKIT.
12748
1675728f
PE
12749 * ftxfont.c: Make symbols static if they're not exported.
12750 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12751 HAVE_FREETYPE.
12752 * font.h (ftxfont_driver): Likewise.
12753
e4cebfca
PE
12754 * xfns.c: Make symbols static if they're not exported.
12755 (x_last_font_name, x_display_info_for_name):
12756 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12757 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12758 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12759 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12760 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12761 (last_show_tip_args): Now static.
12762 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12763 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12764 (x_screen_planes): Remove; unused.
12765 * dispextern.h (x_screen_planes): Remove decl.
12766
5bf46f05
PE
12767 * dispnew.c: Make symbols static if they're not exported.
12768 * dispextern.h (redraw_garbaged_frames, scrolling):
12769 (increment_row_positions): Remove.
12770 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12771 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12772 Now static.
12773 (redraw_garbaged_frames): Remove; unused.
12774
435f4c28
PE
12775 * xfaces.c: Make symbols static if they're not exported.
12776 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12777 Remove decls.
12778 * xterm.h (defined_color): Remove decls.
12779 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12780 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12781 (menu_face_changed_default, defined_color, free_realized_face):
12782 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12783 (ascii_face_of_lisp_face): Remove; unused.
12784
8524aef3
PE
12785 * xdisp.c: Make symbols static if they're not exported.
12786 * dispextern.h (scratch_glyph_row, window_box_edges):
12787 (glyph_to_pixel_coords, set_cursor_from_row):
12788 (get_next_display_element, set_iterator_to_next):
12789 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12790 (show_mouse_face): Remove decls
12791 * frame.h (message_buf_print): Likewise.
12792 * lisp.h (pop_message, set_message, check_point_in_composition):
12793 Likewise.
12794 * xterm.h (set_vertical_scroll_bar): Likewise.
12795 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12796 (message_buf_print, scratch_glyph_row, displayed_buffer):
12797 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12798 (get_next_display_element, show_mouse_face, window_box_edges):
12799 (frame_to_window_pixel_xy, check_point_in_composition):
12800 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12801 (glyph_to_pixel_coords): Remove; unused.
12802
16390cd2
PE
12803 * dired.c (file_name_completion): Now static.
12804
12805 * dbusbind.c (xd_in_read_queued_messages): Now static.
12806
a25f4dfa
PE
12807 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12808 * data.c (circular_list_error): Remove.
12809
14a9c8df
PE
12810 * commands.h (last_point_position, last_point_position_buffer):
12811 (last_point_position_window): Remove decls.
12812 * keyboard.c: Make these variables static.
12813
04f2d78b
CB
12814 * coding.h (coding, code_convert_region, encode_coding_gap):
12815 Remove decls.
74ab6df5
PE
12816 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12817 (iso_code_class, detect_coding, code_convert_region): Now static.
12818 (encode_coding_gap): Remove; unused.
12819
38dfbee1
PE
12820 * chartab.c (chartab_chars, chartab_bits): Now static.
12821
a2cb4e63
PE
12822 * charset.h (charset_iso_8859_1): Remove decl.
12823 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12824 Now static.
12825
127198fd
PE
12826 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12827 * ccl.c (Vccl_program_table): Now static.
12828 (check_ccl_update): Remove; unused.
12829
d85b608f
PE
12830 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12831 * category.h: ... from here.
12832 * category.c (check_category_table, set_category_set): Now static.
12833
31cd66f3
PE
12834 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12835 * lisp.h: Remove these decls.
12836
c358e587
PE
12837 * buffer.c (buffer_count): Remove unused var.
12838
e78aecca
PE
12839 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12840 so that it's not optimized away.
12841 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12842 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12843 exported only to the debugger.
12844
e192d7d3 12845 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12846 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12847
92470028
PE
12848 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12849 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12850 was inaccessible from Lisp.
12851 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12852 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12853
244ed907
PE
12854 alloc.c: Import and export fewer symbols, and remove unused items.
12855 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12856 is defined.
12857 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12858 it's not optimized away by whole-program optimization.
12859 (message_enable_multibyte, free_misc): Remove.
12860 (catchlist, handlerlist, mark_backtrace):
12861 Declare only if BYTE_MARK_STACK.
12862 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12863 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12864 (message_enable_multibyte): Remove decl.
12865 (free_misc, interval_free_list, float_block, float_block_index):
12866 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12867 (cons_free_list, last_marked_index):
12868 Now static.
12869 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12870 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12871 (mark_backtrace): Define only if BYTE_MARK_STACK.
12872 * xdisp.c (message_enable_multibyte): Now static.
12873
61c2b50e 12874 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12875 This makes it easier for human readers (and static analyzers)
12876 to see whether these variables are used from other modules.
12877 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12878 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12879 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12880 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12881 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12882 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12883 * xmenu.c, xselect.c:
12884 Declare Q* vars static if they are not used in other modules.
12885 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12886 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12887 Remove decls of unexported vars.
12888 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12889
95c82688
PE
12890 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12891
16a97296
PE
12892 Make Emacs functions such as Fatom 'static' by default.
12893 This makes it easier for human readers (and static analyzers)
12894 to see whether these functions can be called from other modules.
12895 DEFUN now defines a static function. To make the function external
12896 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12897 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12898 (Finit_image_library):
16a97296
PE
12899 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12900 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12901 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12902 Remove decls, since these functions are now static.
12903 (Funintern, Fget_internal_run_time): New decls, since these functions
12904 were already external.
95c82688 12905
16a97296
PE
12906 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12907 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12908 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12909 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12910 * keyboard.c, keymap.c, lread.c:
12911 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12912 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12913 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12914 Mark functions with DEFUE instead of DEFUN,
12915 if they are used in other modules.
12916 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12917 decls for now-static functions.
12918 * buffer.h (Fdelete_overlay): Remove decl.
12919 * callproc.c (Fgetenv_internal): Mark as internal.
12920 * composite.c (Fremove_list_of_text_properties): Remove decl.
12921 (Fcomposition_get_gstring): New forward static decl.
12922 * composite.h (Fcomposite_get_gstring): Remove decl.
12923 * dired.c (Ffile_attributes): New forward static decl.
12924 * doc.c (Fdocumntation_property): New forward static decl.
12925 * eval.c (Ffetch_bytecode): New forward static decl.
12926 (Funintern): Remove extern decl; now in .h file where it belongs.
12927 * fileio.c (Fmake_symbolic_link): New forward static decl.
12928 * image.c (Finit_image_library): New forward static decl.
12929 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12930 * intervals.h (Fprevious_property_change):
12931 (Fremove_list_of_text_properties): Remove decls.
12932 * keyboard.c (Fthis_command_keys): Remove decl.
12933 (Fcommand_execute): New forward static decl.
12934 * keymap.c (Flookup_key): New forward static decl.
12935 (Fcopy_keymap): Now static.
12936 * keymap.h (Flookup_key): Remove decl.
12937 * process.c (Fget_process): New forward static decl.
12938 (Fprocess_datagram_address): Mark as internal.
12939 * syntax.c (Fsyntax_table_p): New forward static decl.
12940 (skip_chars): Remove duplicate decl.
12941 * textprop.c (Fprevious_property_change): New forward static decl.
12942 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12943 Now internal.
12944 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12945 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12946
785bbd42
PE
12947 * editfns.c (Fformat): Remove unreachable code.
12948
8b913b57
AS
129492011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12950
12951 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12952 change. (Bug#8496)
12953
a6744a35
EZ
129542011-04-13 Eli Zaretskii <eliz@gnu.org>
12955
12956 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12957 when at ZV. (Bug#8487)
12958
e7974947
AS
129592011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12960
baad03f0
AS
12961 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12962 (Bug#8437)
12963 * keyboard.c (parse_tool_bar_item): Likewise.
12964 * sound.c (sound_cleanup, alsa_close): Likewise.
12965 * termcap.c (tgetent): Likewise.
12966 * xfns.c (x_default_font_parameter): Likewise.
12967 * xsettings.c (read_and_apply_settings): Likewise.
12968
e7974947
AS
12969 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12970 (overrun_check_free): Protoize.
12971
28272684
PE
129722011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12973
12974 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12975 since callers should never pass a negative size.
12976 Change the signature to match that of plain 'read' and 'write'; see
12977 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12978 * lisp.h: Update prototypes of emacs_write and emacs_read.
12979
11997c76
EZ
129802011-04-11 Eli Zaretskii <eliz@gnu.org>
12981
12982 * xdisp.c (redisplay_window): Don't try to determine the character
12983 position of the scroll margin if the window start point w->startp
e896f03c 12984 is outside the buffer's accessible region. (Bug#8468)
11997c76 12985
8a2cbd72
EZ
129862011-04-10 Eli Zaretskii <eliz@gnu.org>
12987
12988 Fix write-region and its subroutines for buffers > 2GB.
12989 * fileio.c (a_write, e_write): Modify declaration of arguments and
12990 local variables to support buffers larger than 2GB.
12991 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12992
12993 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12994 argument, local variables, and return value.
12995
12996 * lisp.h: Update prototypes of emacs_write and emacs_read.
12997
12998 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12999
4073e537 130002011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13001
1ebfdcb6
PE
13002 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13003
b2ded58d
PE
13004 Fix more problems found by GCC 4.6.0's static checks.
13005
7d66342c
PE
13006 * xdisp.c (vmessage): Use a better test for character truncation.
13007
bbf47d44
PE
13008 * charset.c (load_charset_map): <, not <=, for optimization,
13009 and to avoid potential problems with integer overflow.
9248994d 13010 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13011 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13012 * editfns.c (Fformat): Likewise.
1e69125e 13013 * syntax.c (skip_chars): Likewise.
3befa583 13014
e3019616
PE
13015 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13016 This also lets GCC 4.6.0 generate slightly better loop code.
13017
becfa255
PE
13018 * callint.c (Fcall_interactively): <, not <=, for optimization.
13019 (Fcall_interactively): Count the number of arguments produced,
13020 not the number of arguments given. This is simpler and lets GCC
13021 4.6.0 generate slightly better code.
13022
dae0cd48
PE
13023 * ftfont.c: Distingish more carefully between FcChar8 and char.
13024 The previous code passed unsigned char * to a functions like
13025 strlen and xstrcasecmp that expect char *, which does not
13026 conform to the C standard.
13027 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13028 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13029 char * when the C standard requires it.
13030
76032d70
PE
13031 * keyboard.c (read_char): Remove unused var.
13032
eb3f1cc8
PE
13033 * eval.c: Port to Windows vsnprintf (Bug#8435).
13034 Include <limits.h>.
13035 (SIZE_MAX): Define if the headers do not.
13036 (verror): Do not give up if vsnprintf returns a negative count.
13037 Instead, grow the buffer. This ports to Windows vsnprintf, which
13038 does not conform to C99. Problem reported by Eli Zaretskii.
13039 Also, simplify the allocation scheme, by avoiding the need for
13040 calling realloc, and removing the ALLOCATED variable.
13041
70476b54
PE
13042 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13043
12020a9e
PE
13044 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13045 But keep the doprint source code for now, as we might revamp it
13046 and use it again (Bug#8435).
ea6c7ae6
PE
13047 * lisp.h (doprnt): Remove.
13048 * Makefile.in (base_obj): Remove doprnt.o.
13049 * deps.mk (doprnt.o): Remove.
13050
5fdb398c
PE
13051 error: Print 32- and 64-bit integers portably (Bug#8435).
13052 Without this change, on typical 64-bit hosts error ("...%d...", N)
13053 was used to print both 32- and 64-bit integers N, which relied on
13054 undefined behavior.
61bdb816 13055 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13056 * lisp.h (error, verror): Mark as printf-like functions.
13057 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13058 Report overflow in size calculations when allocating printf buffer.
13059 Do not truncate output string at its first null byte.
13060 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13061 Truncate the output at a character boundary, since vsnprintf does not
13062 do that.
13063 * charset.c (check_iso_charset_parameter): Convert internal
13064 character to string before calling 'error', since %c now has the
13065 printf meaning.
13066 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13067 overflow when computing char to be passed to 'error'. Do not
13068 pass Lisp_Object to 'error'; pass the integer instead.
13069 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13070 formatted with plain %d.
13071
b189fa66
PE
13072 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13073
bff87ef0
PE
13074 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13075
7e2cac20
PE
13076 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13077
ce4d90b5
PE
13078 * xterm.c (x_catch_errors): Remove duplicate declaration.
13079
266c9547
PE
13080 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13081
79c49ad2
PE
13082 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13083
368f4090
JM
130842011-04-10 Jim Meyering <meyering@redhat.com>
13085
13086 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13087 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13088 return ssize_t not "int", and use size_t as the buffer length.
13089 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13090 * gnutls.h: Update declarations.
13091 * process.c (read_process_output): Use ssize_t, to match.
13092 (send_process): Likewise.
13093
a32d4040
CY
130942011-04-09 Chong Yidong <cyd@stupidchicken.com>
13095
13096 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13097
8546720e 130982011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13099
04f2d78b
CB
13100 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13101 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13102
8546720e
GM
13103 * xterm.c (handle_one_xevent):
13104 * xmenu.c (create_and_show_popup_menu):
13105 * xselect.c (x_decline_selection_request)
13106 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13107
0a2f5c1a 131082011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13109
13110 Fix some uses of `int' instead of EMACS_INT.
13111 * search.c (string_match_1, fast_string_match)
13112 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13113 (scan_buffer, find_next_newline_no_quit)
13114 (find_before_next_newline, search_command, Freplace_match)
13115 (Fmatch_data): Make some `int' variables be EMACS_INT.
13116
13117 * xdisp.c (display_count_lines): 3rd argument and return value now
13118 EMACS_INT. All callers changed.
13119 (pint2hrstr): Last argument is now EMACS_INT.
13120
13121 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13122 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13123 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13124 (decode_coding_utf_16, decode_coding_emacs_mule)
13125 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13126 (decode_coding_ccl, decode_coding_charset)
13127 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13128 (decode_coding_iso_2022, decode_coding_emacs_mule)
13129 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13130 <char_offset, last_offset>: Declare EMACS_INT.
13131 (encode_coding_utf_8, encode_coding_utf_16)
13132 (encode_coding_emacs_mule, encode_invocation_designation)
13133 (encode_designation_at_bol, encode_coding_iso_2022)
13134 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13135 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13136 Declare EMACS_INT.
13137 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13138 (encode_invocation_designation): Last argument P_NCHARS is now
13139 EMACS_INT.
13140 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13141 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13142
13143 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13144 All users changed.
13145
13146 * ccl.c (Fccl_execute_on_string): Declare some variables
13147 EMACS_INT.
13148
8546720e 131492011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13150
13151 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13152
4e19a977
CS
131532011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13154
13155 * process.c (Fformat_network_address): Doc fix.
13156
87302331
R
131572011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13158
ee7683eb 13159 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13160
cbb59342
CY
131612011-04-08 Chong Yidong <cyd@stupidchicken.com>
13162
13163 * keyboard.c (read_char): Call Lisp function help-form-show,
13164 instead of using internal_with_output_to_temp_buffer.
13165 (Qhelp_form_show): New var.
e0d38eeb 13166 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13167
13168 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13169
13170 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13171
e67a13ab
CY
131722011-04-06 Chong Yidong <cyd@stupidchicken.com>
13173
04f2d78b
CB
13174 * process.c (Flist_processes): Remove to Lisp.
13175 (list_processes_1): Delete.
e67a13ab 13176
973f782d
EZ
131772011-04-06 Eli Zaretskii <eliz@gnu.org>
13178
7c106b1e
EZ
13179 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13180
973f782d
EZ
13181 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13182
41cf7d1a 131832011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13184
ca23cc88
PE
13185 Fix more problems found by GCC 4.6.0's static checks.
13186
f390e2d5
PE
13187 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13188
42eea0d0
PE
13189 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13190
b69769da 13191 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13192
f9541e84
PE
13193 * xdisp.c (vmessage): Mark as a printf-like function.
13194
13841b55
PE
13195 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13196
c136c10f
PE
13197 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13198
5e2d4a30
PE
13199 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13200 printf-like functions.
13201 (tiff_load): Add casts to remove these marks before passing them
13202 to system-supplied API.
13203
583f48b9
PE
13204 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13205
b25d760e
PE
13206 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13207 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13208 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13209 directly, rather than having caller test rule sign. This avoids
13210 some unnecessary tests.
13211 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13212 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13213 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13214
bc7b6697 13215 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13216 (xfont_open): Avoid unnecessary tests.
bc7b6697 13217
27ccc379
PE
13218 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13219
dcd5c89a
PE
13220 * composite.h, composite.c (composition_gstring_put_cache):
13221 Use EMACS_INT, not int, for length.
13222
b13a45c6
PE
13223 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13224 breaking out part of COMPOSITION_DECODE_RULE.
13225 (COMPOSITION_DECODE_RULE): Use it.
13226 * composite.c (get_composition_id): Remove unused local vars,
13227 by using the new macro.
13228
1e792e4d
PE
13229 * textprop.c (set_text_properties_1): Change while to do-while,
13230 since the condition is always true at first.
13231
dc6c6455 13232 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13233 (interval_deletion_adjustment): Return unsigned value.
13234 All uses changed.
dc6c6455 13235
aba7731a
PE
13236 * process.c (list_processes_1, create_pty, read_process_output):
13237 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13238 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13239 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13240 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13241 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13242
fdfc4bf3
PE
13243 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13244
fca8fe46 13245 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13246 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13247
06a0259a 13248 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13249 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13250 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13251
e7b9e80f
PE
13252 * print.c (print_error_message): Avoid int overflow.
13253
56201685
PE
13254 * font.c (font_list_entities): Redo for clarity,
13255 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13256
78834453 13257 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13258 (font_score): Avoid potential overflow in diff calculation.
78834453 13259
0bc0b309 13260 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13261 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13262
e610eaca
PE
13263 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13264
b895abce
PE
13265 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13266 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13267 can always succeed if overflow has undefined behavior.
13268
1f1d9321 13269 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13270 (wordify): Omit three unnecessary tests.
1f1d9321 13271
c59478bc
PE
13272 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13273 All callers changed. This avoids the need for an unused var.
13274
79b73827
PE
13275 * casefiddle.c (casify_region): Remove var that is set but not used.
13276
a4db5dfe
PE
13277 * dired.c (file_name_completion): Remove var that is set but not used.
13278
43aae36e
PE
13279 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13280
2a47c44d 13281 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13282 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13283
a37c69bf
PE
13284 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13285 Check for integer overflow on size calculations.
13286
328ab8e7
PE
13287 * buffer.c (Fprevious_overlay_change): Remove var that is set
13288 but not used.
13289
e5a2a5cb
PE
13290 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13291 Remove vars that are set but not used.
8d84a6eb 13292 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13293 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13294
a60e5f68
PE
13295 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13296
f661cb61 13297 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13298 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13299
f0397f5a
PE
13300 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13301 that are set but not used.
13302
8664db06 13303 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13304 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13305
6abdaa4a
PE
13306 * xselect.c (x_get_local_selection, x_handle_property_notify):
13307 Remove vars that are set but not used.
13308
0ce7538d 13309 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13310 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13311
9ae848fc
PE
13312 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13313 Remove var that is set but not used.
0b918413
PE
13314 (scroll_bar_windows_size): Now size_t, not int.
13315 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13316 Check for overflow.
9ae848fc 13317
a5a62657
PE
13318 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13319 (map_tty_color) [!defined MSDOS]: Likewise.
13320
5c5cdd39
PE
13321 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13322
66ebf983
PE
13323 * coding.c: Remove vars that are set but not used.
13324 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13325 All callers changed.
13326 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13327 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13328 (decode_coding_charset): Remove vars that are set but not used.
13329
1be4d761
PE
13330 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13331 that is set but not used.
13332
47553fa8
PE
13333 * print.c (print_object): Remove var that is set but not used.
13334
1f7196bf 13335 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13336 The gnulib version avoids calling malloc in the usual case,
13337 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13338 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13339 * filelock.c (current_lock_owner): Likewise.
13340 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13341 * sysdep.c: Include allocator.h, careadlinkat.h.
13342 (emacs_no_realloc_allocator): New static constant.
13343 (emacs_readlink): New function.
fdb61804
PE
13344 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13345 ../lib/careadlinkat.h.
d1fdcab7 13346
f84c17c7
SM
133472011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13348
13349 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13350 first non-nil return value).
13351
ef3862ad
JD
133522011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13353
13354 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13355 if not defined (Bug#8403).
13356
376a7006
JB
133572011-04-02 Juanma Barranquero <lekktu@gmail.com>
13358
13359 * xdisp.c (display_count_lines): Remove parameter `start',
13360 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13361 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13362 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13363 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13364 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13365 and thereabouts. All callers changed.
13366 (get_per_char_metric): Remove parameter `f', unused since
13367 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13368
6ca3801d
JM
133692011-04-02 Jim Meyering <meyering@redhat.com>
13370
13371 do not dereference NULL upon failed strdup
13372 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13373 (ns_get_family): Likewise.
13374
d8e2b5ba
JB
133752011-04-02 Juanma Barranquero <lekktu@gmail.com>
13376
13377 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13378
8c74fcbd
JD
133792011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13380
13381 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13382 later (Bug#8403).
13383
7200d79c
SM
133842011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13385
03408648 13386 Add lexical binding.
7200d79c 13387
03408648
SM
13388 * window.c (Ftemp_output_buffer_show): New fun.
13389 (Fsave_window_excursion):
13390 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13391
13392 * lread.c (lisp_file_lexically_bound_p): New function.
13393 (Fload): Bind Qlexical_binding.
13394 (readevalloop): Remove `evalfun' arg.
13395 Bind Qinternal_interpreter_environment.
13396 (Feval_buffer): Bind Qlexical_binding.
13397 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13398 Mark as dynamic.
13399 (syms_of_lread): Declare `lexical-binding'.
13400
13401 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13402
13403 * keyboard.c (eval_dyn): New fun.
13404 (menu_item_eval_property): Use it.
ca105506
SM
13405
13406 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13407
03408648
SM
13408 * fns.c (concat, mapcar1): Accept byte-code-functions.
13409
13410 * eval.c (Fsetq): Handle lexical vars.
13411 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13412 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13413 (FletX, Flet): Obey lexical binding.
13414 (Fcommandp): Handle closures.
13415 (Feval): New `lexical' arg.
13416 (eval_sub): New function extracted from Feval. Use it almost
13417 everywhere where Feval was used. Look up vars in lexical env.
13418 Handle closures.
13419 (Ffunctionp): Move from subr.el.
13420 (Ffuncall): Handle closures.
13421 (apply_lambda): Remove `eval_flags'.
13422 (funcall_lambda): Handle closures and new byte-code-functions.
13423 (Fspecial_variable_p): New function.
13424 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13425 but without exporting it to Lisp.
23aba0ea 13426
23aba0ea 13427 * doc.c (Fdocumentation, store_function_docstring):
03408648 13428 * data.c (Finteractive_form): Handle closures.
23aba0ea 13429
03408648
SM
13430 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13431 interactive spec.
ba83908c 13432
04f2d78b
CB
13433 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13434 New byte-codes.
03408648
SM
13435 (exec_byte_code): New function extracted from Fbyte_code to handle new
13436 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13437
03408648 13438 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13439
03408648 13440 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13441
e2abce01
JB
134422011-03-31 Juanma Barranquero <lekktu@gmail.com>
13443
13444 * xdisp.c (redisplay_internal): Fix prototype.
13445
63696a73 134462011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13447
63696a73 13448 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13449 (try_scrolling): Use it when setting scroll_limit.
13450 Limit scrolling to 100 screen lines.
63696a73
EZ
13451 (redisplay_window): Even when falling back on "recentering",
13452 position point in the window according to scroll-conservatively,
13453 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13454
13455 (try_scrolling): When point is above the window, allow searching
13456 as far as scroll_max, or one screenful, to compute vertical
13457 distance from PT to the scroll margin position. This prevents
13458 try_scrolling from unnecessarily failing when
13459 scroll-conservatively is set to a value slightly larger than the
13460 window height. Clean up the case of PT below the margin at bottom
13461 of window: scroll_max can no longer be INT_MAX. When aggressive
13462 scrolling is in use, don't let point enter the opposite scroll
13463 margin as result of the scroll.
13464 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13465 threshold of 100 lines for never-recentering scrolling.
13466
e4cc2dfc
JB
134672011-03-31 Juanma Barranquero <lekktu@gmail.com>
13468
13469 * dispextern.h (move_it_by_lines):
13470 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13471 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13472 (message_log_check_duplicate): Remove parameters `prev_bol' and
13473 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13474 (redisplay_internal): Remove parameter `preserve_echo_area',
13475 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13476
13477 * indent.c (Fvertical_motion):
13478 * window.c (window_scroll_pixel_based, Frecenter):
13479 Don't pass `need_y_p' to `move_it_by_lines'.
13480
1c470562
SM
134812011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13482
44f230aa
SM
13483 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13484 steal a few bits to be more compact.
13485 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13486 Remove unneeded casts.
13487
1c470562
SM
13488 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13489
888adce9
ZK
134902011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13491
13492 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13493 binding" message (bug#7967).
13494
f838ed7b
PE
134952011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13496
77861b95
PE
13497 Fix more problems found by GCC 4.6.0's static checks.
13498
de6dbc14
PE
13499 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13500 Remove unused local var.
13501
f838ed7b
PE
13502 * editfns.c (Fmessage_box): Remove unused local var.
13503
792c7b2b
PE
13504 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13505 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13506 Omit unused local vars.
c499e557 13507 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13508 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13509 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13510 Omit unused local var.
13511
ba0165e1
PE
13512 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13513 Don't assume string length fits in int.
32ad8845 13514 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13515 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13516
3c59b4c9
PE
13517 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13518 instead of alloca (Bug#8344).
13519
a3eed478 13520 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13521 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13522
eb4d412d
PE
13523 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13524
1658b401
PE
13525 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13526 concerns.
13527
13528 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13529
13530 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13531
9a2c6e05
PE
13532 * keyboard.c (syms_of_keyboard): Use the same style as later
13533 in this function when indexing through an array. This also
13534 works around GCC bug 48267.
13535
03d0a109
PE
13536 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13537
44f730c8
PE
13538 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13539
fe75f926
PE
13540 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13541 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13542
ffa8c828
PE
13543 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13544 This avoids undefined behavior on integer overflow, and is a bit
13545 more convenient anyway since it is compared to a size_t variable.
13546
c5101a77
PE
13547 Variadic C functions now count arguments with size_t, not int.
13548 This avoids an unnecessary limitation on 64-bit machines, which
13549 caused (substring ...) to crash on large vectors (Bug#8344).
13550 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13551 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13552 All variadic functions and their callers changed accordingly.
c5101a77
PE
13553 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13554 * data.c (arith_driver, float_arith_driver): Likewise.
13555 * editfns.c (general_insert_function): Likewise.
13556 * eval.c (struct backtrace.nargs, interactive_p)
13557 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13558 (funcall_lambda, mark_backtrace): Likewise.
13559 * fns.c (concat): Likewise.
13560 * frame.c (x_set_frame_parameters): Likewise.
13561 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13562 0 if not found, not -1. All callers changed.
13563
dd3f25f7
PE
13564 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13565 (stack_copy_size): Now size_t, not int.
13566 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13567
461c2ab9
JB
135682011-03-28 Juanma Barranquero <lekktu@gmail.com>
13569
13570 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13571 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13572 All callers changed.
13573
13574 * lisp.h (multibyte_char_to_unibyte):
13575 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13576 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13577 * character.h (CHAR_TO_BYTE8):
13578 * cmds.c (internal_self_insert):
13579 * editfns.c (general_insert_function):
13580 * keymap.c (push_key_description):
13581 * search.c (Freplace_match):
13582 * xdisp.c (message_dolog, set_message_1): All callers changed.
13583
f6d62986
SM
135842011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13585
13586 * keyboard.c (safe_run_hook_funcall): New function.
13587 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13588 don't set the hook to nil, but remove the offending function instead.
13589 (Qcommand_hook_internal): Remove, unused.
13590 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13591 Vcommand_hook_internal.
13592
13593 * eval.c (enum run_hooks_condition): Remove.
13594 (funcall_nil, funcall_not): New functions.
13595 (run_hook_with_args): Call each function through a `funcall' argument.
13596 Remove `cond' argument, now redundant.
13597 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13598 (Frun_hook_with_args_until_failure): Adjust accordingly.
13599 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13600
1db5b1ad
JB
136012011-03-28 Juanma Barranquero <lekktu@gmail.com>
13602
13603 * dispextern.h (string_buffer_position): Remove declaration.
13604
13605 * print.c (strout): Remove parameter `multibyte', unused since
13606 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13607
13608 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13609 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13610 All callers changed.
13611
13612 * w32.c (_wsa_errlist): Use braces for struct initializers.
13613
13614 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13615 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13616 All callers changed.
13617 (string_buffer_position): Likewise. Also, make static (it's never
13618 used outside xdisp.c).
13619 (cursor_row_p): Remove parameter `w', unused since
13620 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13621 (decode_mode_spec): Remove parameter `precision', introduced during
13622 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13623 All callers changed.
13624
5ffb62aa
JD
136252011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13626
13627 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13628
461c2ab9 136292011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13630
13631 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13632 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13633 (ns_update_auto_hide_menu_bar): New functions.
13634 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13635 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13636 ns_constrain_all_frames.
13637 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13638 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13639
5c380ffb
JD
136402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13641
13642 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13643
9af30bdf
GM
136442011-03-27 Glenn Morris <rgm@gnu.org>
13645
13646 * syssignal.h: Replace RETSIGTYPE with void.
13647 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13648 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13649 Replace SIGTYPE with void everywhere.
13650 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13651 * s/template.h (SIGTYPE): Remove commented out definition.
13652
e2abce01
JB
136532011-03-26 Eli Zaretskii <eliz@gnu.org>
13654
13655 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13656 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13657
f868cd8a
JB
136582011-03-26 Juanma Barranquero <lekktu@gmail.com>
13659
59eb0929
JB
13660 * w32.c (read_unc_volume): Use parameter `henum', instead of
13661 global variable `wget_enum_handle'.
13662
13663 * keymap.c (describe_vector): Remove parameters `indices' and
13664 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13665 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13666
f868cd8a
JB
13667 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13668
13669 * keyboard.c (timer_check): Remove parameter `do_it_now',
13670 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13671 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13672 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13673
13674 * keyboard.c (read_char):
13675 * w32menu.c (w32_menu_display_help):
13676 * xmenu.c (show_help_event, menu_help_callback):
13677 Adjust calls to `show_help_echo'.
13678
13679 * gtkutil.c (xg_maybe_add_timer):
13680 * keyboard.c (readable_events):
13681 * process.c (wait_reading_process_output):
13682 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13683
13684 * insdel.c (adjust_markers_gap_motion):
13685 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13686 (gap_left, gap_right): Don't call it.
13687
2ecf6fdb
CY
136882011-03-25 Chong Yidong <cyd@stupidchicken.com>
13689
13690 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13691 incurred during fontification.
13692
6b1f9ba4
JB
136932011-03-25 Juanma Barranquero <lekktu@gmail.com>
13694
13695 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13696 (DEFVAR_PER_BUFFER): Don't pass it.
13697
13698 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13699 (scrolling_window): Don't pass it.
13700
0f4a96b5
JB
137012011-03-25 Juanma Barranquero <lekktu@gmail.com>
13702
13703 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13704
13705 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13706 and `suffix'.
13707 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13708 of variables specific to SELinux and computation of `encoded_absname'.
13709
13710 * image.c (XPutPixel): Remove unused variable `height'.
13711
13712 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13713
13714 * unexw32.c (get_section_info): Remove unused variable `section'.
13715
13716 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13717 (system_process_attributes): Remove unused variable `sess'.
13718 (sys_read): Remove unused variable `err'.
13719
13720 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13721 (w32_wnd_proc): Remove unused variable `isdead'.
13722 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13723 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13724 (x_create_tip_frame): Remove unused variable `tem'.
13725
13726 * w32inevt.c (w32_console_read_socket):
13727 Remove unused variable `no_events'.
13728
13729 * w32term.c (x_draw_composite_glyph_string_foreground):
13730 Remove unused variable `width'.
13731
1149507c
JB
137322011-03-24 Juanma Barranquero <lekktu@gmail.com>
13733
13734 * w32term.c (x_set_glyph_string_clipping):
13735 Don't pass uninitialized region to CombineRgn.
13736
9c88f339
JB
137372011-03-23 Juanma Barranquero <lekktu@gmail.com>
13738
13739 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13740 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13741 (Fx_close_connection): Remove unused variable `i'.
13742
13743 * w32font.c (w32font_draw): Return number of glyphs.
13744 (w32font_open_internal): Remove unused variable `i'.
13745 (w32font_driver): Add missing initializer.
13746
13747 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13748 (fill_in_menu): Remove unused variable `items_added'.
13749
13750 * w32term.c (last_mouse_press_frame): Remove static global variable.
13751 (w32_clip_to_row): Remove unused variable `f'.
13752 (x_delete_terminal): Remove unused variable `i'.
13753
13754 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13755 (NOTHING): Remove unused static global variable.
13756 (uniscribe_check_otf): Remove unused variable `table'.
13757 (uniscribe_font_driver): Add missing initializers.
13758
dee091a3
JD
137592011-03-23 Julien Danjou <julien@danjou.info>
13760
13761 * term.c (Fsuspend_tty, Fresume_tty):
13762 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13763 * window.c (temp_output_buffer_show):
13764 * insdel.c (signal_before_change):
13765 * frame.c (Fhandle_switch_frame):
13766 * fileio.c (Fdo_auto_save):
13767 * emacs.c (Fkill_emacs):
13768 * editfns.c (save_excursion_restore):
13769 * cmds.c (internal_self_insert):
13770 * callint.c (Fcall_interactively):
13771 * buffer.c (Fkill_all_local_variables):
13772 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13773 Use Frun_hooks.
0f4a96b5 13774 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13775 unconditionally since it does the check itself.
dee091a3 13776
2c520ab5 137772011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13778
c9c49752
PE
13779 Fix more problems found by GCC 4.5.2's static checks.
13780
8abc3f12
PE
13781 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13782 the first time through the loop, since we know p0 < p1 then.
13783 This also avoids a gcc -Wstrict-overflow warning.
13784
a2d26660
PE
13785 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13786 leading to a memory leak, possible in functions like
13787 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13788 of objects (Bug#8318).
a2d26660 13789
916c72e9
PE
13790 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13791 that could (at least in theory) be that large.
13792
19ab8a18
PE
13793 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13794 This is less likely to overflow, and avoids undefined behavior if
13795 overflow does occur. All callers changed. Use strtoul to scan
13796 for the unsigned long integer.
b7cbbd6f
PE
13797 (pint2hrstr): Simplify and tune code slightly.
13798 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13799
f0641eff
PE
13800 * scroll.c (do_scrolling): Work around GCC bug 48228.
13801 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13802
7f650bb9
PE
13803 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13804 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13805 (validate_x_resource_name): Simplify count usage.
13806 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13807
37dd57d1
PE
13808 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13809 fail (Bug#8306).
81e56e61 13810
699979fc 13811 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13812
401bf9b4
PE
13813 * process.c (Fmake_network_process): Use socklen_t, not int,
13814 where POSIX says socklen_t is required in portable programs.
13815 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13816 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13817 (Fmake_network_process, server_accept_connection):
13818 (wait_reading_process_output, read_process_output):
13819 Likewise.
13820
b93aacde
PE
13821 * process.c: Rename or move locals to avoid shadowing.
13822 (list_processes_1, Fmake_network_process):
13823 (read_process_output_error_handler, exec_sentinel_error_handler):
13824 Rename or move locals.
4dc343ee 13825 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13826 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13827 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13828 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13829 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13830
af8a867c 13831 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13832 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13833 Include tparam.h instead, since it declares them.
af8a867c
PE
13834 * cm.h (PC): Remove extern decl; tparam.h now does this.
13835 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13836 * terminfo.c: Include tparam.h, to check interfaces.
13837 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13838 (tparam): Adjust signature to match interface in tparam.h;
13839 this removes some undefined behavior. Check that outstring and len
13840 are zero, which they always are with Emacs.
13841 * tparam.h (PC, BC, UP): New extern decls.
13842
0248044d 13843 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13844 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13845
8ff096c1 13846 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13847 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13848 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13849 (ftfont_list): Remove unused local.
49eaafba
PE
13850 (get_adstyle_property, ftfont_pattern_entity):
13851 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13852 Rename locals to avoid shadowing.
8ff096c1 13853
e2be39f6
PE
13854 * xfont.c (xfont_list_family): Mark var as initialized.
13855
c9735e30
PE
13856 * xml.c (make_dom): Now static.
13857
8f5201ae
PE
13858 * composite.c (composition_compute_stop_pos): Rename local to
13859 avoid shadowing.
b246f932
PE
13860 (composition_reseat_it): Remove unused locals.
13861 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13862 (composition_update_it): Mark var as initialized.
11b61122
PE
13863 (find_automatic_composition): Mark vars as initialized,
13864 with a FIXME (Bug#8290).
8f5201ae 13865
760fbc2c
PE
13866 character.h: Rename locals to avoid shadowing.
13867 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13868 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13869 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13870 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13871 to avoid shadowing.
13872
ff08eb85
PE
13873 * textprop.c (property_change_between_p): Remove; unused.
13874
fc7bf025
PE
13875 * intervals.c (interval_start_pos): Now static.
13876
235d7abc
PE
13877 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13878
44f230aa
SM
13879 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13880 Rename locals to avoid shadowing.
3e7d6594 13881
50060332
PE
13882 * sound.c (wav_play, au_play, Fplay_sound_internal):
13883 Fix pointer signedness.
d01f234b 13884 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13885 (wav_play): Initialize a variable to 0, to prevent undefined
13886 behavior (Bug#8278).
50060332 13887
c4fc4e30
PE
13888 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13889
918436ed
PE
13890 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13891
c939f91b
PE
13892 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13893 clobbering (Bug#8298).
b9c7f648
PE
13894 * sysdep.c (sys_subshell): Likewise.
13895 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13896
6bd8c144
PE
13897 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13898 This should get cleaned up, so that child_setup has the
13899 same signature on all platforms.
13900
7710357c 13901 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13902 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13903
c59da222
CY
139042011-03-22 Chong Yidong <cyd@stupidchicken.com>
13905
13906 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13907 not to be necessary, and produces flickering.
13908
66b87493
GM
139092011-03-20 Glenn Morris <rgm@gnu.org>
13910
13911 * config.in: Remove file.
13912
45b6f6d5
JB
139132011-03-20 Juanma Barranquero <lekktu@gmail.com>
13914
13915 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13916 are now in src/globals.h.
13917 (syms_of_minibuf): Remove spurious & from previous change.
13918
cd394be1 139192011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13920
13921 * minibuf.c (completing-read-function): New variable.
13922 (completing-read-default): Rename from completing-read.
13923 (completing-read): Call completing-read-function.
13924
b14e3e21
CY
139252011-03-19 Juanma Barranquero <lekktu@gmail.com>
13926
13927 * xfaces.c (Fx_load_color_file):
13928 Read color file from absolute filename (bug#8250).
13929
f2b726e6
JB
139302011-03-19 Juanma Barranquero <lekktu@gmail.com>
13931
13932 * makefile.w32-in: Update dependencies.
13933
09f6ff02
EZ
139342011-03-17 Eli Zaretskii <eliz@gnu.org>
13935
13936 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13937
29a6015a
PE
139382011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13939
a3a6c54e
PE
13940 Fix more problems found by GCC 4.5.2's static checks.
13941
b766f867
PE
13942 * process.c (make_serial_process_unwind, send_process_trap):
13943 (sigchld_handler): Now static.
13944
be02381c
PE
13945 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13946 That way, the code declares only the vars that it needs.
13947 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13948 * s/cygwin.h (PTY_ITERATION): Likewise.
13949 * s/darwin.h (PTY_ITERATION): Likewise.
13950 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13951
57048744
PE
13952 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13953 * process.c (allocate_pty): Don't declare stb unless it's needed.
13954
7914961c 13955 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13956 (CONSTANTLIM): Remove; unused.
13957 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13958 Define only if needed.
7914961c 13959
b3967b18
PE
13960 * unexelf.c (unexec): Name an expression,
13961 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13962 Use a different way to cause a compilation error if anyone uses
13963 n rather than nn, a way that does not involve shadowing.
73366a00 13964 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13965
29a6015a
PE
13966 * deps.mk (unexalpha.o): Remove; unused.
13967
43cfc33e 13968 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13969 * unexec.h: New file.
ce701a33
PE
13970 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13971 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13972 Depend on unexec.h.
13973 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13974 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13975 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13976 Change as necessary to match prototype in unexec.h.
ce701a33 13977
01f44d5a
PE
13978 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13979 shadowing.
4f63c6bb 13980 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13981
a6670b0b
PE
13982 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13983 Rename locals to avoid shadowing.
13984
cef2010d 13985 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13986 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13987
d4d7173a
PE
13988 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13989
f08b802a
PE
13990 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13991 warning when compiling print.c.
13992
3ddb0639
PE
13993 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13994 instead of using an uninitialized var.
5ad03b97 13995 (font_sort_entities): Mark var as initialized.
3ddb0639 13996
170a2692
PE
13997 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13998
e663c700
PE
13999 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14000 pointers to constants.
89bc529a 14001 (font_parse_fcname): Remove unused vars.
7b81e2d0 14002 (font_delete_unmatched): Now static.
ea838e10 14003 (font_get_spec): Remove; unused.
13a547c6
PE
14004 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14005 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14006 Rename or move locals to avoid shadowing.
e663c700 14007
2a80c887 14008 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14009 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14010
1384fa33 14011 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14012 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14013
8b2c52e9
PE
14014 * alloc.c (mark_backtrace): Move decl from here ...
14015 * lisp.h: ... to here, so that it can be checked.
14016
475545b5 14017 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14018 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14019 (lisp_indirect_variable): Name an expression,
14020 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14021 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14022
b1349114 14023 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14024 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14025 Use const pointer when appropriate.
b1349114 14026
a2928364
PE
14027 * lisp.h (get_system_name, get_operating_system_release):
14028 Move decls here, to check interfaces.
14029 * process.c (get_operating_system_release): Move decl to lisp.h.
14030 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14031 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14032 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14033 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14034 (Fformat_time_string, Fencode_time, Finsert_char):
14035 (Ftranslate_region_internal, Fformat):
14036 Rename or remove local vars to avoid shadowing.
9710023e 14037 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14038
a415e694
PE
14039 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14040 avoid shadowing.
14041
8ef4622d
PE
14042 * lisp.h (eassert): Check that the argument compiles, even if
14043 ENABLE_CHECKING is not defined.
14044
946f9a5b
PE
14045 * data.c (Findirect_variable): Name an expression, to avoid
14046 gcc -Wbad-function-cast warning.
112396d6 14047 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14048 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14049 (Fmake_variable_buffer_local, Fmake_local_variable):
14050 Mark variables as initialized.
52746918 14051 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14052
e5aab7e7 14053 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14054 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14055 Rename locals to avoid shadowing.
dff45157
PE
14056 (mark_stack): Move local variables into the #ifdef region where
14057 they're used.
7bc26fdb
PE
14058 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14059 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14060 needed otherwise.
14061 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14062 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14063 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14064
e5aab7e7
PE
14065 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14066 avoids undefined behavior in theory.
14067
4da60324
PE
14068 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14069
88043301
PE
14070 Use functions, not macros, for up- and down-casing (Bug#8254).
14071 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14072 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14073 to use the following functions instead of these macros.
14074 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14075 EMACS_INT, since callers assume the returned value fits in int.
14076 (upcase1): Likewise, for UPCASE_TABLE.
14077 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14078 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14079 the race-condition problem in the old DOWNCASE.
88043301 14080
19ed5445
PE
14081 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14082 Rename locals to avoid shadowing.
14083 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14084 (regex_compile, re_search_2, re_match_2_internal):
14085 Remove unused local vars.
952db0d7
PE
14086 (FREE_VAR): Rewrite so as not to use empty "else",
14087 which gcc can warn about.
da053e48 14088 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14089 (RETALLOC_IF): Define only if needed.
14090 (WORDCHAR_P): Likewise. This one is never needed, but is used
14091 only in a comment talking about a compiler bug, so put inside
14092 the #if 0 of that comment.
14093 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14094 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14095 Remove; unused.
19ed5445 14096
1f3561e4 14097 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14098 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14099 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14100
ded6f8f7
PE
14101 * search.c (simple_search): Remove unused var.
14102
dbd37a95
PE
14103 * dired.c (compile_pattern): Move decl from here ...
14104 * lisp.h: ... to here, so that it can be checked.
14105 (struct re_registers): New forward decl.
14106
7e47afad
PE
14107 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14108
85f24f61
PE
14109 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14110 All uses changed.
14111 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14112 Rename locals to avoid shadowing.
5671df8f 14113 (Fvertical_motion): Mark locals as initialized.
85f24f61 14114
181aa2be 14115 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14116 (casify_region): Mark local as initialized.
181aa2be 14117
930d429c
PE
14118 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14119
7082eac6
PE
14120 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14121 New macros, so that the caller can use some names other than
14122 gcpro1, gcpro2, etc.
14123 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14124 of the new macros.
14125 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14126 argument, for consistency with GCPRO2_VAR, etc: it is now the
14127 prefix of the variable, not the variable itself. All uses
14128 changed.
38b2c076
PE
14129 * dired.c (directory_files_internal, file_name_completion):
14130 Rename locals to avoid shadowing.
14131
15206ed9
PE
14132 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14133 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14134 dired.c's scmp function, had undefined behavior.
14135 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14136 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14137 * buffer.h: ... to here, because these macros use current_buffer,
14138 and the new implementation with inline functions needs to have
14139 current_buffer in scope now, rather than later when the macros
14140 are used.
14141 (downcase, upcase1): New static inline functions.
14142 (DOWNCASE, UPCASE1): Reimplement using these functions.
14143 This avoids undefined behavior in expressions like
14144 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14145 from race conditions in accessing the global variables
14146 case_temp1 and case_temp2.
14147 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14148 * lisp.h (case_temp1, case_temp2): Remove their decls.
14149 * character.h (ASCII_CHAR_P): Move from here ...
14150 * lisp.h: ... to here, so that the inline functions mentioned
14151 above can use them.
14152
4a6bea26
PE
14153 * dired.c (directory_files_internal_unwind): Now static.
14154
f14b7e14
PE
14155 * fileio.c (file_name_as_directory, directory_file_name):
14156 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14157 Now static.
2893f146
PE
14158 (file_name_as_directory): Use const pointers when appropriate.
14159 (Fexpand_file_name): Likewise. In particular, newdir might
14160 point at constant storage, so make it a const pointer.
fd4ead52 14161 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14162 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14163 signedness issues.
f839df0c
PE
14164 (Fset_file_times, Finsert_file_contents, auto_save_error):
14165 Rename locals to avoid shadowing.
f14b7e14 14166
5716756e 14167 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14168 (Ftry_completion, Fall_completions): Rename or remove locals
14169 to avoid shadowing.
5716756e 14170
b4c3046a
PE
14171 * marker.c (bytepos_to_charpos): Remove; unused.
14172
b45db522
PE
14173 * lisp.h (verify_bytepos, count_markers): New decls,
14174 so that gcc does not warn that these functions aren't declared.
14175
85876d07
PE
14176 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14177 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14178 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14179 (copy_text): Remove unused local var.
85876d07 14180
03d78a21 14181 * filelock.c (within_one_second): Now static.
b3dd38ab 14182 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14183
5df8f01b
PE
14184 * buffer.c (fix_overlays_before): Mark locals as initialized.
14185 (fix_start_end_in_overlays): Likewise. This function should be
14186 simplified by using pointers-to-pointers, but that's a different
14187 matter.
b1d876f1 14188 (switch_to_buffer_1): Now static.
8f54f30a
PE
14189 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14190 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14191
a70072c9 14192 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14193 Fix pointer signedness issue.
edced198
PE
14194 (sys_subshell): Mark local as volatile if checking for lint,
14195 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14196 (MAXPATHLEN): Define only if needed.
a70072c9 14197
a0977c44
PE
14198 * process.c (serial_open, serial_configure): Move decls from here ...
14199 * systty.h: ... to here, so that they can be checked.
14200
a884fdcc
PE
14201 * fns.c (get_random, seed_random): Move extern decls from here ...
14202 * lisp.h: ... to here, so that they can be checked.
14203
604efe86 14204 * sysdep.c (reset_io): Now static.
b8950c94 14205 (wait_for_termination_signal): Remove; unused.
604efe86 14206
38fc62d9
PE
14207 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14208 (copy_keymap_item, append_key, push_text_char_description):
14209 Now static.
1004a21a 14210 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14211 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14212 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14213 (describe_map_tree):
14214 Rename locals to avoid shadowing.
38fc62d9 14215
2f2650da
PE
14216 * keyboard.c: Declare functions static if they are not used elsewhere.
14217 (echo_char, echo_dash, cmd_error, top_level_2):
14218 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14219 (read_char, kbd_buffer_get_event, make_lispy_position):
14220 (make_lispy_event, make_lispy_movement, apply_modifiers):
14221 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14222 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14223 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14224 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14225 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14226
a053e86c 14227 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14228 (mark_kboards): Move decl here ...
14229 * alloc.c (mark_kboards): ... from here.
a053e86c 14230
4752793e
PE
14231 * lisp.h (force_auto_save_soon): New decl.
14232
74f10ca7 14233 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14234 (DEFINE_DUMMY_FUNCTION): New macro.
14235 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14236 Use it.
c03cd23f
PE
14237 (main): Add casts to avoid warnings
14238 if GCC considers string literals to be constants.
74f10ca7 14239
022e70d4
PE
14240 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14241
59d6fe83
PE
14242 * dbusbind.c: Pointer signedness fixes.
14243 (xd_signature, xd_append_arg, xd_initialize):
14244 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14245 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14246 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14247 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14248
78320123
PE
14249 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14250 if GCC considers string literals to be constants.
49cebcca 14251 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14252
35ac2a97
SM
142532011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14254
fb103ca9
SM
14255 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14256 (print_preprocess, print_object): New macro to fix last change.
14257
35ac2a97
SM
14258 * print.c (print_preprocess): Don't forget font objects.
14259
62973b41
JB
142602011-03-16 Juanma Barranquero <lekktu@gmail.com>
14261
14262 * emacs.c (USAGE3): Doc fixes.
14263
0e48bb22
AS
142642011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14265
14266 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14267 structure.
14268
7684e57b
JB
142692011-03-14 Juanma Barranquero <lekktu@gmail.com>
14270
14271 * lisp.h (VWindow_system, Qfile_name_history):
14272 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14273 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14274 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14275
14276 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14277 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14278
14279 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14280 * w32console.c (detect_input_pending, read_input_pending)
14281 (encode_terminal_code):
14282 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14283 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14284 (w32_system_caret_y, Qfile_name_history):
14285 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14286 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14287 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14288 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14289 * w32proc.c (Qlocal, report_file_error):
14290 * w32term.c (Vwindow_system, updating_frame):
14291 * w32uniscribe.c (initialized, uniscribe_font_driver):
14292 Remove unneeded extern declarations.
14293
2aa46d6c
CY
142942011-03-14 Chong Yidong <cyd@stupidchicken.com>
14295
c96bbc66 14296 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14297
cffc6f3b
CY
142982011-03-13 Chong Yidong <cyd@stupidchicken.com>
14299
14300 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14301 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14302 These macros can no longer be used for assignment.
14303
44f230aa
SM
14304 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14305 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14306 (record_buffer_markers, fetch_buffer_markers): New functions for
14307 recording and fetching special buffer markers.
14308 (set_buffer_internal_1, set_buffer_temp): Use them.
14309
14310 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14311
14312 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14313
14314 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14315 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14316
14317 * xdisp.c (hscroll_window_tree):
14318 (reconsider_clip_changes): Use PT instead of BUF_PT.
14319
d251f04b
EZ
143202011-03-13 Eli Zaretskii <eliz@gnu.org>
14321
14322 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14323 $(EMACS_ROOT)/lib/intprops.h.
14324
f0c77cd1
PE
143252011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14326
3eca4629
PE
14327 Fix more problems found by GCC 4.5.2's static checks.
14328
7c86ee98
PE
14329 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14330 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14331 (xg_free_frame_widgets): Make it clear that a local variable is
14332 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14333 (gdk_window_get_screen): Make it clear that this macro is needed
14334 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14335 (int_gtk_range_get_value): New function, which avoids a diagnostic
14336 from gcc -Wbad-function-cast.
14337 (xg_set_toolkit_scroll_bar_thumb): Use it.
14338 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14339 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14340 (get_utf8_string, xg_get_file_with_chooser):
14341 Rename locals to avoid shadowing.
14342 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14343
41729b81
PE
14344 * xgselect.c (xg_select): Remove unused var.
14345
f0c77cd1
PE
14346 * image.c (four_corners_best): Mark locals as initialized.
14347 (gif_load): Initialize transparent_p to zero (Bug#8238).
14348 Mark another local as initialized.
ec6cf4c6 14349 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14350
ce0ad53d 14351 * image.c (clear_image_cache): Now static.
d5d5a617 14352 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14353 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14354 (x_edge_detection): Remove unnecessary cast that
14355 gcc -Wbad-function-cast diagnoses.
2037898d 14356 (gif_load): Fix pointer signedness.
6ae141d6
PE
14357 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14358 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14359
33383987 143602011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14361
d32df629
PE
14362 Improve quality of tests for time stamp overflow.
14363 For example, without this patch (encode-time 0 0 0 1 1
14364 1152921504606846976) returns the obviously-bogus value (-948597
14365 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14366 reports time overflow. See
14367 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14368 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14369 * editfns.c: Include limits.h and intprops.h.
14370 (TIME_T_MIN, TIME_T_MAX): New macros.
14371 (time_overflow): Move earlier, to before first use.
14372 (hi_time, lo_time): New functions, for an accurate test for
14373 out-of-range times.
14374 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14375 (Fget_internal_run_time): Don't assume time_t fits in int.
14376 (make_time): Use list2 instead of Fcons twice.
14377 (Fdecode_time): More accurate test for out-of-range times.
14378 (check_tm_member): New function.
14379 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14380 (lisp_time_argument): Don't rely on undefined left-shift and
14381 right-shift behavior when checking for time stamp overflow.
8be6f318 14382
fe31d94c
PE
14383 * editfns.c (time_overflow): New function, refactoring common code.
14384 (Fformat_time_string, Fdecode_time, Fencode_time):
14385 (Fcurrent_time_string): Use it.
14386
8be6f318
PE
14387 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14388 * dired.c (make_time): Move to ...
14389 * editfns.c (make_time): ... here.
14390 * systime.h: Note the move.
14391
09d9db2c 143922011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14393
126bc0dc
YM
14394 * fringe.c (update_window_fringes): Remove unused variables.
14395
c47cbdfd
YM
14396 * unexmacosx.c (copy_data_segment): Also copy __got section.
14397 (Bug#8223)
14398
7ac80be9
EZ
143992011-03-12 Eli Zaretskii <eliz@gnu.org>
14400
c96bbc66 14401 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14402 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14403 Constify `char *' arguments and their references according to
14404 prototypes in tparam.h.
14405
ecb0f94d 14406 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14407
7ac80be9
EZ
14408 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14409 Adapt all references accordingly.
14410
14411 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14412
ef1fd07e
TT
144132011-03-11 Tom Tromey <tromey@redhat.com>
14414
14415 * buffer.c (syms_of_buffer): Remove obsolete comment.
14416
7ef4b50c
EZ
144172011-03-11 Eli Zaretskii <eliz@gnu.org>
14418
14419 * termhooks.h (encode_terminal_code): Declare prototype.
14420
14421 * msdos.c (encode_terminal_code): Don't declare prototype.
14422
14423 * term.c (encode_terminal_code): Now external again, used by
14424 w32console.c and msdos.c.
14425
44f230aa
SM
14426 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14427 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14428
4b1ec863 144292011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14430
1714f52b 14431 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14432
4b1ec863
PE
14433 * fringe.c (update_window_fringes): Mark locals as initialized
14434 (Bug#8227).
14435 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14436
524c7aa6
PE
14437 * alloc.c (mark_fringe_data): Move decl from here ...
14438 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14439 to check its interface.
14440 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14441
a5c0af81 14442 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14443 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14444 (fontset_font): Mark local as initialized.
a9a06e0b 14445 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14446
b4716021
PE
14447 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14448
811e9bac 14449 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14450 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14451 (x_own_selection, Fx_disown_selection_internal): Rename locals
14452 to avoid shadowing.
14453 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14454
7e3ab302
PE
14455 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14456 so that the caller can use some name other than gcpro1.
14457 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14458 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14459 (Fx_backspace_delete_keys_p):
14460 Use them to avoid shadowing, and rename vars to avoid shadowing.
14461 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14462 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14463 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14464 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14465 Remove unused locals.
7e3ab302
PE
14466 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14467 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14468 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14469 macros.
f78faa98 14470
e2b13473
PE
14471 * xterm.h (x_mouse_leave): New decl.
14472
77f23912
PE
14473 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14474 Remove unused functions.
cdf4ba58
PE
14475 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14476 (x_calc_absolute_position): Now static.
7411c686 14477 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14478 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14479 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14480 unless they are used.
38d0b34a
PE
14481 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14482 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14483 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14484 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14485 (x_error_catcher, x_connection_closed, x_error_handler):
14486 (x_error_quitter, xembed_send_message, x_iconify_frame):
14487 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14488 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14489 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14490
44f230aa
SM
14491 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14492 Rename or move locals to avoid shadowing.
6b463e58 14493 (tty_defined_color, merge_face_heights): Now static.
5967d051 14494 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14495 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14496 does not deduce is never used uninitialized.
73719eba
PE
14497 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14498 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14499
426994c3 14500 * terminal.c (store_terminal_param): Now static.
5489860b 14501
032f1620 14502 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14503 (set_frame_menubar): Remove unused local.
d4323972 14504 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14505 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14506 since they might point to immutable storage.
281585b0
PE
14507 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14508 since it's unused otherwise.
032f1620 14509
367c19e5 14510 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14511 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14512 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14513 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14514 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14515 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14516 does not deduce are never used uninitialized.
70739cbe 14517
07b48fa9
PE
14518 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14519
8868a238 14520 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14521 * window.c (window_loop, size_window):
14522 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14523
7e5cf297 14524 * window.c (display_buffer): Now static.
d6550a9f
PE
14525 (size_window): Mark variables that gcc -Wuninitialized
14526 does not deduce are never used uninitialized.
a586633d
PE
14527 * window.h (check_all_windows): New decl, to forestall
14528 gcc -Wmissing-prototypes diagnostic.
5b555da1 14529 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14530
f6095868
PE
14531 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14532 shadowing.
14533 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14534 Include <limits.h>.
14535 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14536 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14537 (load_charset_map): Mark variables that gcc -Wuninitialized
14538 does not deduce are never used uninitialized.
53df7c11 14539 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14540
f38b440c
PE
14541 * coding.c (coding_set_source, coding_set_destination):
14542 Use "else { /* comment */ }" rather than "else /* comment */;"
14543 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14544 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14545 a block, when the outer 'i' will do.
14546 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14547 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14548 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14549 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14550 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14551 Rename locals to avoid shadowing.
14552 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14553 * coding.c (emacs_mule_char, encode_invocation_designation):
14554 Now static, since they're not used elsewhere.
413bb2db 14555 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14556 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14557 (decode_coding_emacs_mule): Mark variables that gcc
14558 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14559 (detect_coding_iso_2022): Initialize a local variable that might
14560 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14561 this initialization is needed. (Bug#8211)
5f58e762
PE
14562 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14563 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14564 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14565 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14566 Remove unused macros.
f38b440c 14567
232b38b9 14568 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14569 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14570 * character.c (string_count_byte8): Likewise.
232b38b9 14571
fb90da1b
PE
14572 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14573 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14574
fb93dbc2
PE
14575 * chartab.c (copy_sub_char_table): Now static, since it's not used
14576 elsewhere.
5c156ace
PE
14577 (sub_char_table_ref_and_range, char_table_ref_and_range):
14578 Rename locals to avoid shadowing.
bbcd0949 14579 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14580
7d3b3862 14581 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14582 (BIDI_BOB): Remove unused macro.
7d3b3862 14583
6be7d3da
PE
14584 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14585 deduce are never used uninitialized.
c2ed9c8b 14586 * term.c (encode_terminal_code): Likewise.
6be7d3da 14587
75f8807f 14588 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14589
50938595
PE
14590 * tparam.h: New file.
14591 * term.c, tparam.h: Include it.
14592 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14593 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14594 Move these decls to tparam.h, and make them agree with what
14595 is actually in tparam.c. The previous trick of using incompatible
14596 decls in different modules does not conform to the C standard.
14597 All callers of tparam changed to use tparam's actual API.
14598 * tparam.c (tparam1, tparam, tgoto):
14599 Use const pointers where appropriate.
14600
fbceeba2
PE
14601 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14602 * cm.h (struct cm): Likewise.
14603 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14604 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14605 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14606 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14607 (turn_on_face, init_tty): Likewise.
14608 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14609
7f3f1250
PE
14610 * term.c (term_mouse_position): Rename local to avoid shadowing.
14611
e6ca6543
PE
14612 * alloc.c (mark_ttys): Move decl from here ...
14613 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14614
c40f8d15
AS
146152011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14616
14617 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14618
cfe0661d
JB
146192011-03-09 Juanma Barranquero <lekktu@gmail.com>
14620
14621 * search.c (compile_pattern_1): Remove argument regp, unused since
14622 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14623 (compile_pattern): Don't pass it.
14624
0afb4571
J
146252011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14626
14627 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14628 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14629 for ! HAVE_GTK3.
14630 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14631
14632 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14633
14634 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14635 gdk_window_get_screen, gdk_window_get_geometry,
14636 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14637 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14638 (xg_get_pixbuf_from_pixmap): New function.
14639 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14640 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14641 Call xg_get_pixbuf_from_pixmap instead of
14642 gdk_pixbuf_get_from_drawable.
14643 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14644 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14645 (xg_check_special_colors): Use GtkStyleContext and its functions
14646 for HAVE_GTK3.
14647 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14648 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14649 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14650 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14651 Call gtk_widget_get_preferred_size.
0afb4571
J
14652 (xg_frame_resized): gdk_window_get_geometry only takes 5
14653 parameters.
44f230aa
SM
14654 (xg_win_to_widget, xg_event_is_for_menubar):
14655 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14656 (xg_set_widget_bg): New function.
14657 (delete_cb): New function.
895009e1 14658 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14659 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14660 (xg_set_background_color): Call xg_set_widget_bg.
14661 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14662 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14663 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14664 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14665 if ! HAVE_GTK3.
14666 (update_frame_tool_bar): Call gtk_widget_hide.
14667 (xg_initialize): Use GDK_KEY_g.
14668
14669 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14670 if ! HAVE_GTK3
14671 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14672
14673 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14674 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14675 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14676
1c2cc4ef
JB
146772011-03-08 Juanma Barranquero <lekktu@gmail.com>
14678
14679 * w32xfns.c (select_palette): Check success of RealizePalette against
14680 GDI_ERROR, not zero.
14681
33383987 14682See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14683
14684;; Local Variables:
14685;; coding: utf-8
aac0c6e3
MR
14686;; End:
14687
2f097256 14688 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14689
14690 This file is part of GNU Emacs.
14691
14692 GNU Emacs is free software: you can redistribute it and/or modify
14693 it under the terms of the GNU General Public License as published by
14694 the Free Software Foundation, either version 3 of the License, or
14695 (at your option) any later version.
14696
14697 GNU Emacs is distributed in the hope that it will be useful,
14698 but WITHOUT ANY WARRANTY; without even the implied warranty of
14699 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14700 GNU General Public License for more details.
14701
14702 You should have received a copy of the GNU General Public License
14703 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.