Don't test HAVE_INTTYPES_H in process.c.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
330d880c
EZ
12011-04-30 Eli Zaretskii <eliz@gnu.org>
2
3 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4 inttypes.h, as a gnulib replacement is used if it not available in
5 system headers.
6
15cbd324
EZ
72011-04-21 Eli Zaretskii <eliz@gnu.org>
8
9 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12
13 * coding.c (coding_alloc_by_realloc): Error out if destination
14 will grow beyond MOST_POSITIVE_FIXNUM.
15 (decode_coding_emacs_mule): Abort if there isn't enough place in
16 charbuf for the composition carryover bytes. Reserve an extra
17 space for up to 2 characters produced in a loop.
18 (decode_coding_iso_2022): Abort if there isn't enough place in
19 charbuf for the composition carryover bytes.
20
212011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 22
ae940cca
EZ
23 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
24 aborting when %lld or %lll format is passed.
25 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
26 %llo or %llx format is passed. (Bug#8545)
27
03ab8921
EZ
28 * window.c (window_scroll_line_based): Use a marker instead of
29 simple variables to record original value of point. (Bug#7952)
30
afda1437
EZ
31 * doprnt.c (doprnt): Fix the case where a multibyte sequence
32 produced by %s or %c overflows available buffer space. (Bug#8545)
33
f76dee0c
PE
342011-04-28 Paul Eggert <eggert@cs.ucla.edu>
35
36 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 37 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 38
fdc5744d
JB
392011-04-28 Juanma Barranquero <lekktu@gmail.com>
40
41 * w32.c (init_environment): Warn about defaulting HOME to C:\.
42
638f053a
JB
432011-04-28 Juanma Barranquero <lekktu@gmail.com>
44
45 * keyboard.c (Qdelayed_warnings_hook): Define.
46 (command_loop_1): Run `delayed-warnings-hook'
47 if Vdelayed_warnings_list is non-nil.
48 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
49 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
50
d178f871
EZ
512011-04-28 Eli Zaretskii <eliz@gnu.org>
52
53 * doprnt.c (doprnt): Don't return value smaller than the buffer
54 size if the message was truncated. (Bug#8545).
55
b124fd93
JB
562011-04-28 Juanma Barranquero <lekktu@gmail.com>
57
58 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
59 (Fx_window_property): #if-0 the whole functions, not just the bodies.
60
e810457d
PE
612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
62
63 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
64
ea51cceb
JB
652011-04-27 Juanma Barranquero <lekktu@gmail.com>
66
67 * makefile.w32-in: Update dependencies.
68
94dcfacf
EZ
692011-04-27 Eli Zaretskii <eliz@gnu.org>
70
71 Improve `doprnt' and its usage. (Bug#8545)
72 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
73 `format_end'. Remove support for %l as a conversion specifier.
74 Don't use xrealloc. Improve diagnostics when the %l size modifier
75 is used. Update the commentary.
76
77 * eval.c (verror): Simplify calculation of size_t.
78
79 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
80 messages.
81
f61f41d7
PE
822011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
83
84 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
85 change.
86
96fb4434
PE
872011-04-27 Paul Eggert <eggert@cs.ucla.edu>
88
89 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
90 This makes this file independent of the recent pseudovector change.
91
671875da 922011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 93
69e9b5a3
PE
94 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
95
b5f869a7 96 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 97 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 98 Remove unused local.
c8926152 99 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 100
841a1577 101 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
102 GCC 4.6.0 optimizes based on type-based alias analysis. For
103 example, if b is of type struct buffer * and v of type struct
104 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
105 != &v->size, and therefore "v->size = 1; b->size = 2; return
106 v->size;" must therefore return 1. This assumption is incorrect
107 for Emacs, since it type-puns struct Lisp_Vector * with many other
108 types. To fix this problem, this patch adds a new type struct
f904488f 109 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
110 and pseudovectors, and helps optimizing compilers not get fooled
111 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
112 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
113 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
114 the size member.
eab3844f
PE
115 (XSETPVECTYPE): Rewrite in terms of new macro.
116 (XSETPVECTYPESIZE): New macro, specifying both type and size.
117 This is a bit clearer, and further avoids the possibility of
118 undesirable aliasing.
119 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 120 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
121 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
122 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
123 (ASIZE): Now uses header.size rather than size. All
124 previous uses of XVECTOR (foo)->size replaced to use this macro,
125 to avoid the hassle of writing XVECTOR (foo)->header.size.
126 (struct vectorlike_header): New type.
eab3844f
PE
127 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
128 object, to help avoid aliasing.
129 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
130 (SUBRP): Likewise, since Lisp_Subr is a special case.
131 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
132 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
133 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 134 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
135 changed to be "header.size" and "header.next".
136 * buffer.h (struct buffer): Likewise.
137 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
138 * frame.h (struct frame): Likewise.
139 * process.h (struct Lisp_Process): Likewise.
140 * termhooks.h (struct terminal): Likewise.
141 * window.c (struct save_window_data, struct saved_window): Likewise.
142 * window.h (struct window): Likewise.
143 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
144 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
145 * buffer.c (init_buffer_once): Likewise.
146 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
147 special case.
148 * process.c (Fformat_network_address): Use local var for size,
149 for brevity.
150
0df1eac5
PE
151 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
152
847ab9d1 153 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
154 * data.c (atof): Remove decl; no longer used or needed.
155 (digit_to_number): Move to lread.c.
156 (Fstring_to_number): Use new string_to_number function, to be
157 consistent with how the Lisp reader treats infinities and NaNs.
158 Do not assume that floating-point numbers represent EMACS_INT
159 without losing information; this is not true on most 64-bit hosts.
160 Avoid double-rounding errors, by insisting on integers when
161 parsing non-base-10 numbers, as the documentation specifies.
162 * lisp.h (string_to_number): New decl, replacing ...
163 (isfloat_string): Remove.
bc0a5c13 164 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 165 (read1): Do not accept +. and -. as integers; this
452f4150
PE
166 appears to have been a coding error. Similarly, do not accept
167 strings like +-1e0 as floating point numbers. Do not report
168 overflow for integer overflows unless the base is not 10 which
169 means we have no simple and reliable way to continue.
170 Break out the floating-point parsing into a new
171 function string_to_number, so that Fstring_to_number parses
172 floating point numbers consistently with the Lisp reader.
173 (digit_to_number): Moved here from data.c. Make it static inline.
174 (E_CHAR, EXP_INT): Remove, replacing with ...
175 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
176 (string_to_number): New function, replacing isfloat_string.
177 This function checks for valid syntax and produces the resulting
178 Lisp float number too. Rework it so that string-to-number
bc0a5c13 179 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
180 so that overflow for non-base-10 numbers is reported only when
181 there's no portable and simple way to convert to floating point.
452f4150 182
67769ffc
PE
183 * textprop.c (set_text_properties_1): Rewrite for clarity,
184 and to avoid GCC warning about integer overflow.
185
c20db43f
PE
186 * intervals.h (struct interval): Use EMACS_INT for members
187 where EMACS_UINT might cause problems. See
188 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
189 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
190 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
191 All uses changed.
37aa2f85
PE
192 (offset_intervals): Tell GCC not to worry about length overflow
193 when negating a negative length.
c20db43f 194
2538aa2f
PE
195 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
196 (overrun_check_free): Likewise.
197
f2d3008d
PE
198 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
199 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
200 word size.
201
ec8df744
PE
202 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
203 (gnutls_make_error): Rename local to avoid shadowing.
204 (gnutls_emacs_global_deinit): ifdef out; not used.
205 (Fgnutls_boot): Use const for pointer to readonly storage.
206 Comment out unused local. Fix pointer signedness problems.
207
640ee02d
PE
208 * lread.c (openp): Don't stuff size_t into an 'int'.
209 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
210 about possible signed overflow.
211
6048fb2a
PE
212 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
213 (GDK_KEY_g): Don't define if already defined.
214 (xg_prepare_tooltip): Avoid pointer signedness problem.
215 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
216
fa3c87e1
PE
217 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
218 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
219
2172544b
PE
220 * xfns.c (Fx_window_property): Simplify a bit,
221 to make a bit faster and to avoid GCC 4.6.0 warning.
222 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
223
9b821a21
PE
224 * fns.c (internal_equal): Don't assume size_t fits in int.
225
3c616cfa
PE
226 * alloc.c (compact_small_strings): Tighten assertion a little.
227
c2982e87
PE
228 Replace pEd with more-general pI, and fix some printf arg casts.
229 * lisp.h (pI): New macro, generalizing old pEd macro to other
230 conversion specifiers. For example, use "...%"pI"d..." rather
231 than "...%"pEd"...".
232 (pEd): Remove. All uses replaced with similar uses of pI.
233 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
234 * alloc.c (check_pure_size): Don't overflow by converting size to int.
235 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
236 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
237 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
238 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
239 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
240 64-bit hosts.
241 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
242 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
243 * print.c (safe_debug_print, print_object): Likewise.
244 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
245 to int.
6f04d126
PE
246 Use pI instead of if-then-else-abort. Use %p to avoid casts,
247 avoiding the 0 flag, which is not portable.
c2982e87
PE
248 * process.c (Fmake_network_process): Use pI to avoid cast.
249 * region-cache.c (pp_cache): Likewise.
250 * xdisp.c (decode_mode_spec): Likewise.
251 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
252 behavior on 64-bit hosts with printf arg.
6f04d126 253 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
254 (x_stop_queuing_selection_requests): Likewise.
255 (x_get_window_property): Don't truncate byte count to an 'int'
256 when tracing.
0b432f21 257
5e073ec7
PE
258 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
259 here, since it parses constructs like leading '-' and spaces,
260 which are not wanted; and it overflows with large numbers.
261 Instead, simply match F[0-9]+, which is what is wanted anyway.
262
36372bf9
PE
263 * alloc.c: Remove unportable assumptions about struct layout.
264 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
265 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
266 (allocate_vectorlike, make_pure_vector): Use the new macros,
267 plus offsetof, to remove unportable assumptions about struct layout.
268 These assumptions hold on all porting targets that I know of, but
269 they are not guaranteed, they're easy to remove, and removing them
270 makes further changes easier.
271
0b432f21
PE
272 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
273 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
274 (string_overrun_cookie): Now const. Use initializers that
275 don't formally overflow signed char, to avoid warnings.
000098c1
PE
276 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
277 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
278 (allocate_buffer): Don't assume sizeof (struct buffer) is a
279 multiple of sizeof (EMACS_INT); it need not be, if
280 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 281 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 282
895009e1
JB
2832011-04-26 Juanma Barranquero <lekktu@gmail.com>
284
285 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
286
6a7a1b0b
TZ
2872011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
288
289 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 290 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
291 Reported by Paul Eggert <eggert@cs.ucla.edu>.
292
841a1577 2932011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
294
295 * lisp.h (Qdebug): List symbol.
895009e1 296 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
297 * keyboard.c (debug-on-event): New variable.
298 (handle_user_signal): Break into debugger when debug-on-event
299 matches the current signal symbol.
300
f2d3ba6f
DN
3012011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
302
303 * alloc.c (check_sblock, check_string_bytes)
304 (check_string_free_list): Convert to standard C.
305
42ce4c63
TZ
3062011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
307
308 * w32.c (emacs_gnutls_push): Fix typo.
309
825cd63c
EZ
3102011-04-25 Eli Zaretskii <eliz@gnu.org>
311
fb11d64d
EZ
312 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
313 "cast to pointer from integer of different size".
314
825cd63c
EZ
315 Improve doprnt and its use in verror. (Bug#8545)
316 * doprnt.c (doprnt): Document the set of format control sequences
317 supported by the function. Use SAFE_ALLOCA instead of always
318 using `alloca'.
319
320 * eval.c (verror): Don't limit the buffer size at size_max-1, that
321 is one byte too soon. Don't use xrealloc; instead xfree and
322 xmalloc anew.
323
e061a11b
TZ
3242011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
325
326 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
327 callbacks stage.
328
329 * gnutls.c: Renamed global_initialized to
330 gnutls_global_initialized. Added internals for the
331 :verify-hostname-error, :verify-error, and :verify-flags
332 parameters of `gnutls-boot' and documented those parameters in the
333 docstring. Start callback support.
334 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
335 unless a fatal error occured. Call gnutls_alert_send_appropriate
336 on error. Return error code.
337 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
338 (emacs_gnutls_read): Likewise.
339 (Fgnutls_boot): Return handshake error code.
340 (emacs_gnutls_handle_error): New function.
341 (wsaerror_to_errno): Likewise.
342
343 * w32.h (emacs_gnutls_pull): Add prototype.
344 (emacs_gnutls_push): Likewise.
345
346 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
347 (emacs_gnutls_push): Likewise.
348
3492011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
350
351 * process.c (wait_reading_process_output): Check if GnuTLS
352 buffered some data internally if no FDs are set for TLS
353 connections.
354
355 * makefile.w32-in (OBJ2): Add gnutls.$(O).
356 (LIBS): Link to USER_LIBS.
357 ($(BLD)/gnutls.$(0)): New target.
358
fa6996bc
EZ
3592011-04-24 Eli Zaretskii <eliz@gnu.org>
360
eb35682e
EZ
361 * xdisp.c (handle_single_display_spec): Rename the
362 display_replaced_before_p argument into display_replaced_p, to
363 make it consistent with the commentary. Fix typos in the
364 commentary.
365
e2ad650c
EZ
366 * textprop.c (syms_of_textprop): Remove dead code.
367 (copy_text_properties): Delete obsolete commentary about an
368 interface that was deleted long ago. Fix typos in the description
369 of arguments.
370
1b2de274
EZ
371 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
372 to changes in oldXMenu/XMenu.h from 2011-04-16.
373 <menu_help_message, prev_menu_help_message>: Constify.
374 (IT_menu_make_room): menu->help_text is now `const char **';
375 adjust.
376
377 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
378 to changes in oldXMenu/XMenu.h from 2011-04-16.
379 (struct XMenu): Declare `help_text' `const char **'.
380
381 * xfaces.c <Qunspecified>: Make extern again.
382
383 * syntax.c: Include sys/types.h before including regex.h, as
384 required by Posix.
385
762b15be
EZ
386 * doc.c (get_doc_string): Improve the format passed to `error'.
387
388 * doprnt.c (doprnt): Improve commentary.
389
390 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
391
392 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
393 them with etags.
394
f1052e5d
EZ
395 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
396 changes in globals.h immediately force recompilation.
762b15be
EZ
397 (TAGS): Depend on $(CURDIR)/m/intel386.h and
398 $(CURDIR)/s/ms-w32.h.
399 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 400
fa6996bc
EZ
401 * character.c (Fchar_direction): Function deleted.
402 (syms_of_character): Don't defsubr it.
403 <char-direction-table>: Deleted.
404
e6c3da20
EZ
4052011-04-23 Eli Zaretskii <eliz@gnu.org>
406
407 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
408 * doprnt.c: Include limits.h.
409 (SIZE_MAX): New macro.
410 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
411 local variables are now size_t instead of int or unsigned.
412 Improve overflow protection. Support `l' modifier for integer
413 conversions. Support %l conversion. Don't assume an EMACS_INT
414 argument for integer conversions and for %c.
415
416 * lisp.h (doprnt): Restore prototype.
417
418 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
419 $(SRC)/character.h.
420
421 * Makefile.in (base_obj): Add back doprnt.o.
422
423 * deps.mk (doprnt.o): Add back prerequisites.
424 (callint.o): Depend on character.h.
425
426 * eval.c (internal_lisp_condition_case): Include the handler
427 representation in the error message.
428 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
429 when breaking from the loop.
430
431 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
432
433 * callint.c (Fcall_interactively): When displaying error message
434 about invalid control letter, pass the character's codepoint, not
435 a pointer to its multibyte form. Improve display of the character
436 in octal and display also its hex code.
437
438 * character.c (char_string): Use %x to display the (unsigned)
439 codepoint of an invalid character, to avoid displaying a bogus
440 negative value.
441
442 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
443 `error', not SYMBOL_NAME itself.
444
445 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
446 character arguments to `error'.
447
448 * charset.c (check_iso_charset_parameter): Fix incorrect argument
449 to `error' in error message about FINAL_CHAR argument. Make sure
450 FINAL_CHAR is a character, and use %c when it is passed as
451 argument to `error'.
452
4ffd0d6b 4532011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
454
455 * s/ms-w32.h (localtime): Redirect to sys_localtime.
456
457 * w32.c: Include <time.h>.
458 (sys_localtime): New function.
459
4ffd0d6b 4602011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
461
462 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
463
4ffd0d6b 464 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 465
4ffd0d6b 4662011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 467
4ffd0d6b
GM
468 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
469 zombies (Bug#8467).
aac0c6e3 470
04c56954
EZ
4712011-04-19 Eli Zaretskii <eliz@gnu.org>
472
473 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
474 gl_state.e_property when gl_state.object is Qt.
475
476 * insdel.c (make_gap_larger): Remove limitation of buffer size
477 to <= INT_MAX.
478
16a43933
CY
4792011-04-18 Chong Yidong <cyd@stupidchicken.com>
480
481 * xdisp.c (lookup_glyphless_char_display)
482 (produce_glyphless_glyph): Handle cons cell entry in
483 glyphless-char-display.
484 (Vglyphless_char_display): Document it.
485
486 * term.c (produce_glyphless_glyph): Handle cons cell entry in
487 glyphless-char-display.
488
4581706e
CY
4892011-04-17 Chong Yidong <cyd@stupidchicken.com>
490
491 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
492
493 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
494
495 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
496 definition for no-X builds.
497
4887c6e2 4982011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 499
fd35b6f9
PE
500 Static checks with GCC 4.6.0 and non-default toolkits.
501
5c1ccb01
PE
502 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
503
006c5daa
PE
504 * process.c (keyboard_bit_set): Define only if SIGIO.
505 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
506 (send_process): Repair possible setjmp clobbering.
507
efc736d3
PE
508 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
509
4e2fe2e6
PE
510 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
511
f97334a2
PE
512 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
513
4e75f29d
PE
514 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
515 Define only if needed.
516
90efadd1
PE
517 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
518 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 519 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 520
3c647824
PE
521 * dispextern.h (struct redisplay_interface): Rename param
522 to avoid shadowing.
e264f262 523 * termhooks.h (struct terminal): Likewise.
761383f4 524 * xterm.c (xembed_send_message): Likewise.
3c647824 525
b58c5c4a
PE
526 * insdel.c (make_gap_smaller): Define only if
527 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
528
cad59032
PE
529 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
530 it.
531
c339dc2e
PE
532 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
533 so that we aren't warned about unused symbols.
534
91a3e27b
PE
535 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
536
399c71d3 537 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 538
8ffc96f5
PE
539 * xfns.c (x_real_positions): Mark locals as initialized.
540
eef9bc79
PE
541 * xmenu.c (xmenu_show): Don't use uninitialized vars.
542
098db9dd
PE
543 * xterm.c: Fix problems found by static analysis with other toolkits.
544 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
545 (x_dispatch_event): Declare static if USE_GTK, and
546 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 547 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 548 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
549 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
550 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 551
eb18f6cc
PE
552 * xmenu.c (menu_help_callback): Pointer type fixes.
553 Use const pointers when pointing at readonly data. Avoid pointer
554 signedness clashes.
555 (FALSE): Remove unused macro.
556 (update_frame_menubar): Remove unused decl.
557
1fe72bf8
PE
558 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
559
60d9e1db
PE
560 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
561 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
562 (single_menu_item): Rename local to avoid shadowing.
563
39261c26
PE
564 * keyboard.c (make_lispy_event): Remove unused local var.
565
018c5e19
PE
566 * frame.c, frame.h (x_get_resource_string): Bring this back, but
567 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
568
63d2b86e
PE
569 * bitmaps: Change bitmaps from unsigned char back to the X11
570 compatible char. Avoid the old compiler warnings about
571 out-of-range initializers by using, for example, '\xab' rather
572 than 0xab.
573
aefd87e1
PE
574 * xgselect.c (xgselect_initialize): Check vs interface
575 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
576
bf501fb9
PE
577 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
578
e9829fdf
PE
579 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
580 to read-only memory.
581
1086c095
PE
582 * fns.c (vector): Remove; this old hack is no longer needed.
583
2baccd04 584 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 585 Remove unused var.
dde42981 586 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 587
72391843 588 * xrdb.c (x_load_resources): Omit unused local.
3565b346 589
436c16df 590 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 591 (x_window): Rename locals to avoid shadowing.
dc5ddd85 592 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 593
92bb796d 594 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 595 (x_term_init): Remove local to avoid shadowing.
92bb796d 596
764430a3 597 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
598
599 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
600 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
601
d1dfb56c
EZ
6022011-04-16 Eli Zaretskii <eliz@gnu.org>
603
c4354cb4
EZ
604 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
605
d1dfb56c
EZ
606 Fix regex.c, syntax.c and friends for buffers > 2GB.
607 * syntax.h (struct gl_state_s): Declare character position members
608 EMACS_INT.
609
610 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
611
612 * textprop.c (verify_interval_modification, interval_of): Declare
613 arguments EMACS_INT.
614
615 * intervals.c (adjust_intervals_for_insertion): Declare arguments
616 EMACS_INT.
617
618 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
619
620 * indent.c (Fvertical_motion): Local variable it_start is now
621 EMACS_INT.
622
623 * regex.c (re_match, re_match_2, re_match_2_internal)
624 (bcmp_translate, regcomp, regexec, print_double_string)
625 (group_in_compile_stack, re_search, re_search_2, regex_compile)
626 (re_compile_pattern, re_exec): Declare arguments and local
627 variables `size_t' and `ssize_t' and return values `regoff_t', as
628 appropriate.
629 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
630 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
631 <compile_stack_type>: `size' and `avail' are now `size_t'.
632
633 * regex.h <regoff_t>: Use ssize_t, not int.
634 (re_search, re_search_2, re_match, re_match_2): Arguments that
635 specify buffer/string position and length are now ssize_t and
636 size_t. Return type is regoff_t.
637
613052cd
BK
6382011-04-16 Ben Key <bkey76@gmail.com>
639
640 * nsfont.m: Fixed bugs in ns_get_family and
641 ns_descriptor_to_entity that were caused by using free to
642 deallocate memory blocks that were allocated by xmalloc (via
643 xstrdup). This caused Emacs to crash when compiled with
644 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
645 --enable-checking=xmallocoverrun). xfree is now used to
646 deallocate these memory blocks.
647
4170f62f 6482011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 649
71b41406
PE
650 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
651
9587a89d
PE
652 emacs_write: Accept and return EMACS_INT for sizes.
653 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
654 et seq.
655 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
656 Accept and return EMACS_INT.
657 (emacs_gnutls_write): Return the number of bytes written on
658 partial writes.
659 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
660 (emacs_read, emacs_write): Remove check for negative size, as the
661 Emacs source code has been audited now.
9587a89d
PE
662 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
663 (emacs_read, emacs_write): Use it.
273a5f82
PE
664 * process.c (send_process): Adjust to the new signatures of
665 emacs_write and emacs_gnutls_write. Do not attempt to store
666 a byte offset into an 'int'; it might overflow.
9587a89d 667 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 668
3e047f51
PE
669 * sound.c: Don't assume sizes fit in 'int'.
670 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 671 Return EMACS_INT, not int.
3e047f51 672 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
673 Accept EMACS_INT, not int.
674 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
675 record read return values.
676
cc39a9db
BK
6772011-04-15 Ben Key <bkey76@gmail.com>
678
c9d0ec6d
JB
679 * keyboard.c (Qundefined): Don't declare static since it is used
680 in nsfns.m.
681 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
682 static since they are used in nsfont.m.
cc39a9db 683
6c60eb9f
SM
6842011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
685
686 * process.c (Qprocessp): Don't declare static.
687 * lisp.h (Qprocessp): Declare again.
688
7990b61a
JB
6892011-04-15 Juanma Barranquero <lekktu@gmail.com>
690
691 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
692
5d4cb038
PE
6932011-04-14 Paul Eggert <eggert@cs.ucla.edu>
694
8bd7b830 695 Improve C-level modularity by making more things 'static'.
cd64ea1d 696
e3b27b31
PE
697 Don't publish debugger-only interfaces to other modules.
698 * lisp.h (safe_debug_print, debug_output_compilation_hack):
699 (verify_bytepos, count_markers): Move decls to the only modules
700 that need them.
701 * region-cache.h (pp_cache): Likewise.
702 * window.h (check_all_windows): Likewise.
703 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
704
5d4cb038
PE
705 * sysdep.c (croak): Now static, if
706 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
707 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
708
709 * alloc.c (refill_memory_reserve): Now static if
710 !defined REL_ALLOC || defined SYSTEM_MALLOC.
711 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 712
e87b6180
PE
713 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
714 Define only if USE_LUCID.
715
ac64929e
PE
716 * xrdb.c (x_customization_string, x_rm_string): Now static.
717
6f37259d
PE
718 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
719 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
720
1683e3ab
PE
721 * xdisp.c (draw_row_with_mouse_face): Now static.
722 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
723
de9c2632
PE
724 * window.h (check_all_windows): Mark externally visible.
725
2b96acb7
PE
726 * window.c (window_deletion_count): Now static.
727
728 * undo.c: Make symbols static if they're not exported.
729 (last_undo_buffer, last_boundary_position, pending_boundary):
730 Now static.
731
50436f33
PE
732 * textprop.c (interval_insert_behind_hooks): Now static.
733 (interval_insert_in_front_hooks): Likewise.
734
64520e5c
PE
735 * term.c: Make symbols static if they're not exported.
736 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
737 (max_frame_lines, tty_set_terminal_modes):
738 (tty_reset_terminal_modes, tty_turn_off_highlight):
739 (get_tty_terminal): Now static.
740 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
741 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 742 HAVE_WINDOW_SYSTEM.
64520e5c
PE
743 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
744 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
745
1fa53021
PE
746 * sysdep.c: Make symbols static if they're not exported.
747 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
748 Now static.
749 (sigprocmask_set, full_mask): Remove; unused.
750 (wait_debugging): Mark as visible.
751 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
752 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
753
d4b43b22
PE
754 * syntax.c (syntax_temp): Define only if !__GNUC__.
755
b7c513d0
PE
756 * sound.c (current_sound_device, current_sound): Now static.
757
989b29ad
PE
758 * search.c (searchbufs, searchbuf_head): Now static.
759
13a55a78
PE
760 * scroll.c (scroll_cost): Remove; unused.
761 * dispextern.h (scroll_cost): Remove decl.
762
de68a1fc
PE
763 * region-cache.h (pp_cache): Mark as externally visible.
764
40ccffa6
PE
765 * process.c: Make symbols static if they're not exported.
766 (process_tick, update_tick, create_process, chan_process):
767 (Vprocess_alist, proc_buffered_char, datagram_access):
768 (fd_callback_data, send_process_frame, process_sent_to): Now static.
769 (deactivate_process): Mark defn as static, as well as decl.
770 * lisp.h (create_process): Remove decl.
771 * process.h (chan_process, Vprocess_alist): Remove decls.
772
ad64fc97
PE
773 * print.c: Make symbols static if they're not exported.
774 (print_depth, new_backquote_output, being_printed, print_buffer):
775 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
776 (print_interval, print_number_index, initial_stderr_stream):
777 Now static.
778 * lisp.h (Fprinc): Remove decl.
779 (debug_output_compilation_hack): Mark as externally visible.
780
adddb265
PE
781 * sysdep.c (croak): Move decl from here to syssignal.h.
782 * syssignal.h (croak): Put it here, so the API can be checked when
783 'croak' is called from dissociate_if_controlling_tty.
784
1717ede2
PE
785 * minibuf.c: Make symbols static if they're not exported.
786 (minibuf_save_list, choose_minibuf_frame): Now static.
787 * lisp.h (choose_minibuf_frame): Remove decl.
788
fa5fb2bc
PE
789 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
790
1e3890d1
PE
791 * lread.c: Make symbols static if they're not exported.
792 (read_objects, initial_obarray, oblookup_last_bucket_number):
793 Now static.
794 (make_symbol): Remove; unused.
795 * lisp.h (initial_obarray, make_symbol): Remove decls.
796
8a1414fa
PE
797 * keyboard.c: Make symbols static if they're not exported.
798 (single_kboard, recent_keys_index, total_keys, recent_keys):
799 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
800 (this_single_command_key_start, echoing, last_auto_save):
801 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
802 (command_loop, echo_now, keyboard_init_hook, help_char_p):
803 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
804 (Vlispy_mouse_stem, double_click_count):
805 Now static.
806 (force_auto_save_soon): Define only if SIGDANGER.
807 (ignore_mouse_drag_p): Now static if
808 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
809 (print_help): Remove; unused.
810 (stop_character, last_timer_event): Mark as externally visible.
811 * keyboard.h (ignore_mouse_drag_p): Declare only if
812 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
813 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
814 * lisp.h (echoing): Remove decl.
815 (force_auto_save_soon): Declare only if SIGDANGER.
816 * xdisp.c (redisplay_window): Simplify code, to make it more
817 obvious that ignore_mouse_drag_p is not accessed if !defined
818 USE_GTK && !defined HAVE_NS.
819
93ea6e8f
PE
820 * intervals.c: Make symbols static if they're not exported.
821 (merge_properties_sticky, merge_interval_right, delete_interval):
822 Now static.
823 * intervals.h (merge_interval_right, delete_interval): Remove decls.
824
77382fcc
PE
825 * insdel.c: Make symbols static if they're not exported.
826 However, leave prepare_to_modify_buffer alone. It's never
827 called from outside this function, but that appears to be a bug.
828 (combine_after_change_list, combine_after_change_buffer):
4889fc82 829 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
830 (adjust_after_replace_noundo): Remove; unused.
831 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 832 (signal_before_change): Remove decls.
77382fcc 833
9306c32e
PE
834 * indent.c (val_compute_motion, val_vmotion): Now static.
835
cd44d2eb
PE
836 * image.c: Make symbols static if they're not exported.
837 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
838 if USE_GTK.
839 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
840 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
841
ad9a7a06
PE
842 * fringe.c (standard_bitmaps): Now static.
843 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
844
81626931
PE
845 * frame.c: Make symbols static if they're not exported.
846 (x_report_frame_params, make_terminal_frame): Now static.
847 (get_frame_param): Now static, unless HAVE_NS.
848 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
849 (x_get_resource_string): Remove; not used.
850 * frame.h (make_terminal_frame, x_report_frame_params):
851 (x_get_resource_string); Remove decls.
852 (x_fullscreen_adjust): Declare only if WINDOWSNT.
853 * lisp.h (get_frame_param): Declare only if HAVE_NS.
854
239f9db9
PE
855 * font.c, fontset.c: Make symbols static if they're not exported.
856 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
857 (FACE_SUITABLE_FOR_CHAR_P): Use it.
858 * font.c (font_close_object): Now static.
859 * font.h (font_close_object): Remove.
860 * fontset.c (FONTSET_OBJLIST): Remove.
861 (free_realized_fontset) #if-0 the body, which does nothing.
862 (face_suitable_for_char_p): #if-0, as it's never called.
863 * fontset.h (face_suitable_for_char_p): Remove decl.
864 * xfaces.c (face_at_string_position): Use
865 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
866 since 0 is always ASCII.
867
dfcf3579
PE
868 * fns.c (weak_hash_tables): Now static.
869
5045092b
PE
870 * fileio.c: Make symbols static if they're not exported.
871 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
872 (Vwrite_region_annotation_buffers): Now static.
873
57a96f5c
PE
874 * eval.c: Make symbols static if they're not exported.
875 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
876 * lisp.h (backtrace_list): Remove decl.
877
35f08c38
PE
878 * emacs.c: Make symbols static if they're not exported.
879 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
880 (fatal_error_code, fatal_error_signal_hook, standard_args):
881 Now static.
882 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
883 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
884 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
885 * lisp.h (fatal_error_signal_hook): Remove decl.
886 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
887
f44bd759
PE
888 * editfns.c: Move a (normally-unused) function to its only use.
889 * editfns.c, lisp.h (get_operating_system_release): Remove.
890 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
891 worth the hassle of breaking this out.
892
b532497d
PE
893 * xterm.c: Make symbols static if they're not exported.
894 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
895 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
896 (x_destroy_window, x_delete_display):
897 Now static.
898 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
899 (x_mouse_leave): Remove; unused.
900 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
901 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
902 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
903 Remove decls.
904 (x_mouse_leave): Declare only if WINDOWSNT.
905 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
906 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
907 USE_X_TOOLKIT.
908
1675728f
PE
909 * ftxfont.c: Make symbols static if they're not exported.
910 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
911 HAVE_FREETYPE.
912 * font.h (ftxfont_driver): Likewise.
913
e4cebfca
PE
914 * xfns.c: Make symbols static if they're not exported.
915 (x_last_font_name, x_display_info_for_name):
916 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
917 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
918 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
919 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
920 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
921 (last_show_tip_args): Now static.
922 (xic_defaut_fontset, xic_create_fontsetname): Define only if
923 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
924 (x_screen_planes): Remove; unused.
925 * dispextern.h (x_screen_planes): Remove decl.
926
5bf46f05
PE
927 * dispnew.c: Make symbols static if they're not exported.
928 * dispextern.h (redraw_garbaged_frames, scrolling):
929 (increment_row_positions): Remove.
930 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
931 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
932 Now static.
933 (redraw_garbaged_frames): Remove; unused.
934
435f4c28
PE
935 * xfaces.c: Make symbols static if they're not exported.
936 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
937 Remove decls.
938 * xterm.h (defined_color): Remove decls.
939 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
940 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
941 (menu_face_changed_default, defined_color, free_realized_face):
942 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
943 (ascii_face_of_lisp_face): Remove; unused.
944
8524aef3
PE
945 * xdisp.c: Make symbols static if they're not exported.
946 * dispextern.h (scratch_glyph_row, window_box_edges):
947 (glyph_to_pixel_coords, set_cursor_from_row):
948 (get_next_display_element, set_iterator_to_next):
949 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
950 (show_mouse_face): Remove decls
951 * frame.h (message_buf_print): Likewise.
952 * lisp.h (pop_message, set_message, check_point_in_composition):
953 Likewise.
954 * xterm.h (set_vertical_scroll_bar): Likewise.
955 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
956 (message_buf_print, scratch_glyph_row, displayed_buffer):
957 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
958 (get_next_display_element, show_mouse_face, window_box_edges):
959 (frame_to_window_pixel_xy, check_point_in_composition):
960 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
961 (glyph_to_pixel_coords): Remove; unused.
962
16390cd2
PE
963 * dired.c (file_name_completion): Now static.
964
965 * dbusbind.c (xd_in_read_queued_messages): Now static.
966
a25f4dfa
PE
967 * lisp.h (circular_list_error, FOREACH): Remove; unused.
968 * data.c (circular_list_error): Remove.
969
14a9c8df
PE
970 * commands.h (last_point_position, last_point_position_buffer):
971 (last_point_position_window): Remove decls.
972 * keyboard.c: Make these variables static.
973
74ab6df5
PE
974 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
975 decls.
976 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
977 (iso_code_class, detect_coding, code_convert_region): Now static.
978 (encode_coding_gap): Remove; unused.
979
38dfbee1
PE
980 * chartab.c (chartab_chars, chartab_bits): Now static.
981
a2cb4e63
PE
982 * charset.h (charset_iso_8859_1): Remove decl.
983 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
984 Now static.
985
127198fd
PE
986 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
987 * ccl.c (Vccl_program_table): Now static.
988 (check_ccl_update): Remove; unused.
989
d85b608f
PE
990 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
991 * category.h: ... from here.
992 * category.c (check_category_table, set_category_set): Now static.
993
31cd66f3
PE
994 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
995 * lisp.h: Remove these decls.
996
c358e587
PE
997 * buffer.c (buffer_count): Remove unused var.
998
e78aecca
PE
999 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1000 so that it's not optimized away.
1001 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1002 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1003 exported only to the debugger.
1004
e192d7d3
PE
1005 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1006 * atimer.h (run_all_atimers): Removed; not exported.
1007
92470028
PE
1008 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1009 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1010 was inaccessible from Lisp.
1011 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1012 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1013
244ed907
PE
1014 alloc.c: Import and export fewer symbols, and remove unused items.
1015 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1016 is defined.
1017 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1018 it's not optimized away by whole-program optimization.
1019 (message_enable_multibyte, free_misc): Remove.
1020 (catchlist, handlerlist, mark_backtrace):
1021 Declare only if BYTE_MARK_STACK.
1022 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1023 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1024 (message_enable_multibyte): Remove decl.
1025 (free_misc, interval_free_list, float_block, float_block_index):
1026 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1027 (cons_free_list, last_marked_index):
1028 Now static.
1029 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1030 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1031 (mark_backtrace): Define only if BYTE_MARK_STACK.
1032 * xdisp.c (message_enable_multibyte): Now static.
1033
61c2b50e 1034 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1035 This makes it easier for human readers (and static analyzers)
1036 to see whether these variables are used from other modules.
1037 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1038 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1039 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1040 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1041 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1042 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1043 * xmenu.c, xselect.c:
1044 Declare Q* vars static if they are not used in other modules.
1045 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1046 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1047 Remove decls of unexported vars.
1048 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1049
95c82688
PE
1050 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1051
16a97296
PE
1052 Make Emacs functions such as Fatom 'static' by default.
1053 This makes it easier for human readers (and static analyzers)
1054 to see whether these functions can be called from other modules.
1055 DEFUN now defines a static function. To make the function external
1056 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1057 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1058 (Finit_image_library):
16a97296
PE
1059 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1060 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1061 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1062 Remove decls, since these functions are now static.
1063 (Funintern, Fget_internal_run_time): New decls, since these functions
1064 were already external.
95c82688 1065
16a97296
PE
1066 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1067 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1068 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1069 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1070 * keyboard.c, keymap.c, lread.c:
1071 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1072 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1073 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1074 Mark functions with DEFUE instead of DEFUN,
1075 if they are used in other modules.
1076 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1077 decls for now-static functions.
1078 * buffer.h (Fdelete_overlay): Remove decl.
1079 * callproc.c (Fgetenv_internal): Mark as internal.
1080 * composite.c (Fremove_list_of_text_properties): Remove decl.
1081 (Fcomposition_get_gstring): New forward static decl.
1082 * composite.h (Fcomposite_get_gstring): Remove decl.
1083 * dired.c (Ffile_attributes): New forward static decl.
1084 * doc.c (Fdocumntation_property): New forward static decl.
1085 * eval.c (Ffetch_bytecode): New forward static decl.
1086 (Funintern): Remove extern decl; now in .h file where it belongs.
1087 * fileio.c (Fmake_symbolic_link): New forward static decl.
1088 * image.c (Finit_image_library): New forward static decl.
1089 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1090 * intervals.h (Fprevious_property_change):
1091 (Fremove_list_of_text_properties): Remove decls.
1092 * keyboard.c (Fthis_command_keys): Remove decl.
1093 (Fcommand_execute): New forward static decl.
1094 * keymap.c (Flookup_key): New forward static decl.
1095 (Fcopy_keymap): Now static.
1096 * keymap.h (Flookup_key): Remove decl.
1097 * process.c (Fget_process): New forward static decl.
1098 (Fprocess_datagram_address): Mark as internal.
1099 * syntax.c (Fsyntax_table_p): New forward static decl.
1100 (skip_chars): Remove duplicate decl.
1101 * textprop.c (Fprevious_property_change): New forward static decl.
1102 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1103 Now internal.
1104 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1105 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1106
785bbd42
PE
1107 * editfns.c (Fformat): Remove unreachable code.
1108
8b913b57
AS
11092011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1110
1111 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1112 change. (Bug#8496)
1113
a6744a35
EZ
11142011-04-13 Eli Zaretskii <eliz@gnu.org>
1115
1116 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1117 when at ZV. (Bug#8487)
1118
e7974947
AS
11192011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1120
baad03f0
AS
1121 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1122 (Bug#8437)
1123 * keyboard.c (parse_tool_bar_item): Likewise.
1124 * sound.c (sound_cleanup, alsa_close): Likewise.
1125 * termcap.c (tgetent): Likewise.
1126 * xfns.c (x_default_font_parameter): Likewise.
1127 * xsettings.c (read_and_apply_settings): Likewise.
1128
e7974947
AS
1129 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1130 (overrun_check_free): Protoize.
1131
28272684
PE
11322011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1133
1134 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1135 since callers should never pass a negative size.
1136 Change the signature to match that of plain 'read' and 'write'; see
1137 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1138 * lisp.h: Update prototypes of emacs_write and emacs_read.
1139
11997c76
EZ
11402011-04-11 Eli Zaretskii <eliz@gnu.org>
1141
1142 * xdisp.c (redisplay_window): Don't try to determine the character
1143 position of the scroll margin if the window start point w->startp
e896f03c 1144 is outside the buffer's accessible region. (Bug#8468)
11997c76 1145
8a2cbd72
EZ
11462011-04-10 Eli Zaretskii <eliz@gnu.org>
1147
1148 Fix write-region and its subroutines for buffers > 2GB.
1149 * fileio.c (a_write, e_write): Modify declaration of arguments and
1150 local variables to support buffers larger than 2GB.
1151 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1152
1153 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1154 argument, local variables, and return value.
1155
1156 * lisp.h: Update prototypes of emacs_write and emacs_read.
1157
1158 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1159
4073e537 11602011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1161
1ebfdcb6
PE
1162 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1163
b2ded58d
PE
1164 Fix more problems found by GCC 4.6.0's static checks.
1165
7d66342c
PE
1166 * xdisp.c (vmessage): Use a better test for character truncation.
1167
bbf47d44
PE
1168 * charset.c (load_charset_map): <, not <=, for optimization,
1169 and to avoid potential problems with integer overflow.
9248994d 1170 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1171 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1172 * editfns.c (Fformat): Likewise.
1e69125e 1173 * syntax.c (skip_chars): Likewise.
3befa583 1174
e3019616
PE
1175 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1176 This also lets GCC 4.6.0 generate slightly better loop code.
1177
becfa255
PE
1178 * callint.c (Fcall_interactively): <, not <=, for optimization.
1179 (Fcall_interactively): Count the number of arguments produced,
1180 not the number of arguments given. This is simpler and lets GCC
1181 4.6.0 generate slightly better code.
1182
dae0cd48
PE
1183 * ftfont.c: Distingish more carefully between FcChar8 and char.
1184 The previous code passed unsigned char * to a functions like
1185 strlen and xstrcasecmp that expect char *, which does not
1186 conform to the C standard.
1187 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1188 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1189 char * when the C standard requires it.
1190
76032d70
PE
1191 * keyboard.c (read_char): Remove unused var.
1192
eb3f1cc8
PE
1193 * eval.c: Port to Windows vsnprintf (Bug#8435).
1194 Include <limits.h>.
1195 (SIZE_MAX): Define if the headers do not.
1196 (verror): Do not give up if vsnprintf returns a negative count.
1197 Instead, grow the buffer. This ports to Windows vsnprintf, which
1198 does not conform to C99. Problem reported by Eli Zaretskii.
1199 Also, simplify the allocation scheme, by avoiding the need for
1200 calling realloc, and removing the ALLOCATED variable.
1201
70476b54
PE
1202 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1203
12020a9e
PE
1204 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1205 But keep the doprint source code for now, as we might revamp it
1206 and use it again (Bug#8435).
ea6c7ae6
PE
1207 * lisp.h (doprnt): Remove.
1208 * Makefile.in (base_obj): Remove doprnt.o.
1209 * deps.mk (doprnt.o): Remove.
1210
5fdb398c
PE
1211 error: Print 32- and 64-bit integers portably (Bug#8435).
1212 Without this change, on typical 64-bit hosts error ("...%d...", N)
1213 was used to print both 32- and 64-bit integers N, which relied on
1214 undefined behavior.
1215 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1216 New macro.
1217 * lisp.h (error, verror): Mark as printf-like functions.
1218 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1219 Report overflow in size calculations when allocating printf buffer.
1220 Do not truncate output string at its first null byte.
1221 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1222 Truncate the output at a character boundary, since vsnprintf does not
1223 do that.
1224 * charset.c (check_iso_charset_parameter): Convert internal
1225 character to string before calling 'error', since %c now has the
1226 printf meaning.
1227 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1228 overflow when computing char to be passed to 'error'. Do not
1229 pass Lisp_Object to 'error'; pass the integer instead.
1230 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1231 formatted with plain %d.
1232
b189fa66
PE
1233 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1234
bff87ef0
PE
1235 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1236
7e2cac20
PE
1237 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1238
ce4d90b5
PE
1239 * xterm.c (x_catch_errors): Remove duplicate declaration.
1240
266c9547
PE
1241 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1242
79c49ad2
PE
1243 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1244
368f4090
JM
12452011-04-10 Jim Meyering <meyering@redhat.com>
1246
1247 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1248 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1249 return ssize_t not "int", and use size_t as the buffer length.
1250 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1251 * gnutls.h: Update declarations.
1252 * process.c (read_process_output): Use ssize_t, to match.
1253 (send_process): Likewise.
1254
a32d4040
CY
12552011-04-09 Chong Yidong <cyd@stupidchicken.com>
1256
1257 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1258
8546720e 12592011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1260
8546720e
GM
1261 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1262 unsigned char, to match FcChar8 type definition.
aac0c6e3 1263
8546720e
GM
1264 * xterm.c (handle_one_xevent):
1265 * xmenu.c (create_and_show_popup_menu):
1266 * xselect.c (x_decline_selection_request)
1267 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1268
0a2f5c1a 12692011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1270
1271 Fix some uses of `int' instead of EMACS_INT.
1272 * search.c (string_match_1, fast_string_match)
1273 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1274 (scan_buffer, find_next_newline_no_quit)
1275 (find_before_next_newline, search_command, Freplace_match)
1276 (Fmatch_data): Make some `int' variables be EMACS_INT.
1277
1278 * xdisp.c (display_count_lines): 3rd argument and return value now
1279 EMACS_INT. All callers changed.
1280 (pint2hrstr): Last argument is now EMACS_INT.
1281
1282 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1283 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1284 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1285 (decode_coding_utf_16, decode_coding_emacs_mule)
1286 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1287 (decode_coding_ccl, decode_coding_charset)
1288 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1289 (decode_coding_iso_2022, decode_coding_emacs_mule)
1290 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1291 <char_offset, last_offset>: Declare EMACS_INT.
1292 (encode_coding_utf_8, encode_coding_utf_16)
1293 (encode_coding_emacs_mule, encode_invocation_designation)
1294 (encode_designation_at_bol, encode_coding_iso_2022)
1295 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1296 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1297 Declare EMACS_INT.
1298 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1299 (encode_invocation_designation): Last argument P_NCHARS is now
1300 EMACS_INT.
1301 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1302 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1303
1304 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1305 All users changed.
1306
1307 * ccl.c (Fccl_execute_on_string): Declare some variables
1308 EMACS_INT.
1309
8546720e 13102011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1311
1312 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1313
4e19a977
CS
13142011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1315
1316 * process.c (Fformat_network_address): Doc fix.
1317
87302331
R
13182011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1319
1320 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1321
cbb59342
CY
13222011-04-08 Chong Yidong <cyd@stupidchicken.com>
1323
1324 * keyboard.c (read_char): Call Lisp function help-form-show,
1325 instead of using internal_with_output_to_temp_buffer.
1326 (Qhelp_form_show): New var.
e0d38eeb 1327 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1328
1329 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1330
1331 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1332
e67a13ab
CY
13332011-04-06 Chong Yidong <cyd@stupidchicken.com>
1334
1335 * process.c (Flist_processes): Removed to Lisp.
1336 (list_processes_1): Deleted.
1337
973f782d
EZ
13382011-04-06 Eli Zaretskii <eliz@gnu.org>
1339
7c106b1e
EZ
1340 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1341
973f782d
EZ
1342 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1343
41cf7d1a 13442011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1345
ca23cc88
PE
1346 Fix more problems found by GCC 4.6.0's static checks.
1347
f390e2d5
PE
1348 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1349
42eea0d0
PE
1350 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1351
b69769da 1352 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1353
f9541e84
PE
1354 * xdisp.c (vmessage): Mark as a printf-like function.
1355
13841b55
PE
1356 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1357
c136c10f
PE
1358 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1359
5e2d4a30
PE
1360 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1361 printf-like functions.
1362 (tiff_load): Add casts to remove these marks before passing them
1363 to system-supplied API.
1364
583f48b9
PE
1365 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1366
b25d760e
PE
1367 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1368 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1369 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1370 directly, rather than having caller test rule sign. This avoids
1371 some unnecessary tests.
1372 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1373 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1374 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1375
bc7b6697 1376 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1377 (xfont_open): Avoid unnecessary tests.
bc7b6697 1378
27ccc379
PE
1379 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1380
dcd5c89a
PE
1381 * composite.h, composite.c (composition_gstring_put_cache):
1382 Use EMACS_INT, not int, for length.
1383
b13a45c6
PE
1384 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1385 breaking out part of COMPOSITION_DECODE_RULE.
1386 (COMPOSITION_DECODE_RULE): Use it.
1387 * composite.c (get_composition_id): Remove unused local vars,
1388 by using the new macro.
1389
1e792e4d
PE
1390 * textprop.c (set_text_properties_1): Change while to do-while,
1391 since the condition is always true at first.
1392
dc6c6455 1393 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1394 (interval_deletion_adjustment): Return unsigned value.
1395 All uses changed.
dc6c6455 1396
aba7731a
PE
1397 * process.c (list_processes_1, create_pty, read_process_output):
1398 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1399 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1400 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1401 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1402 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1403
fdfc4bf3
PE
1404 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1405
fca8fe46 1406 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1407 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1408
06a0259a 1409 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1410 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1411 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1412
e7b9e80f
PE
1413 * print.c (print_error_message): Avoid int overflow.
1414
56201685
PE
1415 * font.c (font_list_entities): Redo for clarity,
1416 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1417
78834453 1418 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1419 (font_score): Avoid potential overflow in diff calculation.
78834453 1420
0bc0b309 1421 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1422 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1423
e610eaca
PE
1424 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1425
b895abce
PE
1426 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1427 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1428 can always succeed if overflow has undefined behavior.
1429
1f1d9321 1430 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1431 (wordify): Omit three unnecessary tests.
1f1d9321 1432
c59478bc
PE
1433 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1434 All callers changed. This avoids the need for an unused var.
1435
79b73827
PE
1436 * casefiddle.c (casify_region): Remove var that is set but not used.
1437
a4db5dfe
PE
1438 * dired.c (file_name_completion): Remove var that is set but not used.
1439
43aae36e
PE
1440 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1441
2a47c44d 1442 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1443 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1444
a37c69bf
PE
1445 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1446 Check for integer overflow on size calculations.
1447
328ab8e7
PE
1448 * buffer.c (Fprevious_overlay_change): Remove var that is set
1449 but not used.
1450
e5a2a5cb
PE
1451 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1452 Remove vars that are set but not used.
8d84a6eb 1453 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1454 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1455
a60e5f68
PE
1456 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1457
f661cb61 1458 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1459 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1460
f0397f5a
PE
1461 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1462 that are set but not used.
1463
8664db06 1464 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1465 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1466
6abdaa4a
PE
1467 * xselect.c (x_get_local_selection, x_handle_property_notify):
1468 Remove vars that are set but not used.
1469
0ce7538d 1470 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1471 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1472
9ae848fc
PE
1473 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1474 Remove var that is set but not used.
0b918413
PE
1475 (scroll_bar_windows_size): Now size_t, not int.
1476 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1477 Check for overflow.
9ae848fc 1478
a5a62657
PE
1479 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1480 (map_tty_color) [!defined MSDOS]: Likewise.
1481
5c5cdd39
PE
1482 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1483
66ebf983
PE
1484 * coding.c: Remove vars that are set but not used.
1485 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1486 All callers changed.
1487 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1488 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1489 (decode_coding_charset): Remove vars that are set but not used.
1490
1be4d761
PE
1491 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1492 that is set but not used.
1493
47553fa8
PE
1494 * print.c (print_object): Remove var that is set but not used.
1495
1f7196bf 1496 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1497 The gnulib version avoids calling malloc in the usual case,
1498 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1499 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1500 * filelock.c (current_lock_owner): Likewise.
1501 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1502 * sysdep.c: Include allocator.h, careadlinkat.h.
1503 (emacs_no_realloc_allocator): New static constant.
1504 (emacs_readlink): New function.
fdb61804
PE
1505 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1506 ../lib/careadlinkat.h.
d1fdcab7 1507
f84c17c7
SM
15082011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1509
1510 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1511 first non-nil return value).
1512
ef3862ad
JD
15132011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1514
1515 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1516 if not defined (Bug#8403).
1517
376a7006
JB
15182011-04-02 Juanma Barranquero <lekktu@gmail.com>
1519
1520 * xdisp.c (display_count_lines): Remove parameter `start',
1521 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1522 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1523 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1524 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1525 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1526 and thereabouts. All callers changed.
1527 (get_per_char_metric): Remove parameter `f', unused since
1528 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1529
6ca3801d
JM
15302011-04-02 Jim Meyering <meyering@redhat.com>
1531
1532 do not dereference NULL upon failed strdup
1533 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1534 (ns_get_family): Likewise.
1535
d8e2b5ba
JB
15362011-04-02 Juanma Barranquero <lekktu@gmail.com>
1537
1538 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1539
8c74fcbd
JD
15402011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1541
1542 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1543 later (Bug#8403).
1544
7200d79c
SM
15452011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1546
03408648 1547 Add lexical binding.
7200d79c 1548
03408648
SM
1549 * window.c (Ftemp_output_buffer_show): New fun.
1550 (Fsave_window_excursion):
1551 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1552
1553 * lread.c (lisp_file_lexically_bound_p): New function.
1554 (Fload): Bind Qlexical_binding.
1555 (readevalloop): Remove `evalfun' arg.
1556 Bind Qinternal_interpreter_environment.
1557 (Feval_buffer): Bind Qlexical_binding.
1558 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1559 Mark as dynamic.
1560 (syms_of_lread): Declare `lexical-binding'.
1561
1562 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1563
1564 * keyboard.c (eval_dyn): New fun.
1565 (menu_item_eval_property): Use it.
ca105506
SM
1566
1567 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1568
03408648
SM
1569 * fns.c (concat, mapcar1): Accept byte-code-functions.
1570
1571 * eval.c (Fsetq): Handle lexical vars.
1572 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1573 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1574 (FletX, Flet): Obey lexical binding.
1575 (Fcommandp): Handle closures.
1576 (Feval): New `lexical' arg.
1577 (eval_sub): New function extracted from Feval. Use it almost
1578 everywhere where Feval was used. Look up vars in lexical env.
1579 Handle closures.
1580 (Ffunctionp): Move from subr.el.
1581 (Ffuncall): Handle closures.
1582 (apply_lambda): Remove `eval_flags'.
1583 (funcall_lambda): Handle closures and new byte-code-functions.
1584 (Fspecial_variable_p): New function.
1585 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1586 but without exporting it to Lisp.
23aba0ea 1587
23aba0ea 1588 * doc.c (Fdocumentation, store_function_docstring):
03408648 1589 * data.c (Finteractive_form): Handle closures.
23aba0ea 1590
03408648
SM
1591 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1592 interactive spec.
ba83908c 1593
03408648
SM
1594 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1595 byte-codes.
1596 (exec_byte_code): New function extracted from Fbyte_code to handle new
1597 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1598
03408648 1599 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1600
03408648 1601 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1602
e2abce01
JB
16032011-03-31 Juanma Barranquero <lekktu@gmail.com>
1604
1605 * xdisp.c (redisplay_internal): Fix prototype.
1606
63696a73 16072011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1608
63696a73
EZ
1609 * xdisp.c (SCROLL_LIMIT): New macro.
1610 (try_scrolling): Use it when setting scroll_limit. Limit
1611 scrolling to 100 screen lines.
1612 (redisplay_window): Even when falling back on "recentering",
1613 position point in the window according to scroll-conservatively,
1614 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1615
1616 (try_scrolling): When point is above the window, allow searching
1617 as far as scroll_max, or one screenful, to compute vertical
1618 distance from PT to the scroll margin position. This prevents
1619 try_scrolling from unnecessarily failing when
1620 scroll-conservatively is set to a value slightly larger than the
1621 window height. Clean up the case of PT below the margin at bottom
1622 of window: scroll_max can no longer be INT_MAX. When aggressive
1623 scrolling is in use, don't let point enter the opposite scroll
1624 margin as result of the scroll.
1625 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1626 threshold of 100 lines for never-recentering scrolling.
1627
e4cc2dfc
JB
16282011-03-31 Juanma Barranquero <lekktu@gmail.com>
1629
1630 * dispextern.h (move_it_by_lines):
1631 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1632 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1633 (message_log_check_duplicate): Remove parameters `prev_bol' and
1634 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1635 (redisplay_internal): Remove parameter `preserve_echo_area',
1636 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1637
1638 * indent.c (Fvertical_motion):
1639 * window.c (window_scroll_pixel_based, Frecenter):
1640 Don't pass `need_y_p' to `move_it_by_lines'.
1641
1c470562
SM
16422011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1643
44f230aa
SM
1644 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1645 steal a few bits to be more compact.
1646 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1647 Remove unneeded casts.
1648
1c470562
SM
1649 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1650
888adce9
ZK
16512011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1652
1653 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1654 binding" message (bug#7967).
1655
f838ed7b
PE
16562011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1657
77861b95
PE
1658 Fix more problems found by GCC 4.6.0's static checks.
1659
de6dbc14
PE
1660 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1661 Remove unused local var.
1662
f838ed7b
PE
1663 * editfns.c (Fmessage_box): Remove unused local var.
1664
792c7b2b
PE
1665 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1666 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1667 Omit unused local vars.
c499e557 1668 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1669 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1670 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1671 Omit unused local var.
1672
ba0165e1
PE
1673 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1674 Don't assume string length fits in int.
32ad8845 1675 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1676 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1677
3c59b4c9
PE
1678 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1679 instead of alloca (Bug#8344).
1680
a3eed478 1681 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1682 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1683
eb4d412d
PE
1684 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1685
1658b401
PE
1686 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1687 concerns.
1688
1689 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1690
1691 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1692
9a2c6e05
PE
1693 * keyboard.c (syms_of_keyboard): Use the same style as later
1694 in this function when indexing through an array. This also
1695 works around GCC bug 48267.
1696
03d0a109
PE
1697 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1698
44f730c8
PE
1699 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1700
fe75f926
PE
1701 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1702 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1703
ffa8c828
PE
1704 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1705 This avoids undefined behavior on integer overflow, and is a bit
1706 more convenient anyway since it is compared to a size_t variable.
1707
c5101a77
PE
1708 Variadic C functions now count arguments with size_t, not int.
1709 This avoids an unnecessary limitation on 64-bit machines, which
1710 caused (substring ...) to crash on large vectors (Bug#8344).
1711 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1712 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1713 All variadic functions and their callers changed accordingly.
c5101a77
PE
1714 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1715 * data.c (arith_driver, float_arith_driver): Likewise.
1716 * editfns.c (general_insert_function): Likewise.
1717 * eval.c (struct backtrace.nargs, interactive_p)
1718 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1719 (funcall_lambda, mark_backtrace): Likewise.
1720 * fns.c (concat): Likewise.
1721 * frame.c (x_set_frame_parameters): Likewise.
1722 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1723 0 if not found, not -1. All callers changed.
1724
dd3f25f7
PE
1725 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1726 (stack_copy_size): Now size_t, not int.
1727 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1728
461c2ab9
JB
17292011-03-28 Juanma Barranquero <lekktu@gmail.com>
1730
1731 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1732 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1733 All callers changed.
1734
1735 * lisp.h (multibyte_char_to_unibyte):
1736 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1737 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1738 * character.h (CHAR_TO_BYTE8):
1739 * cmds.c (internal_self_insert):
1740 * editfns.c (general_insert_function):
1741 * keymap.c (push_key_description):
1742 * search.c (Freplace_match):
1743 * xdisp.c (message_dolog, set_message_1): All callers changed.
1744
f6d62986
SM
17452011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1746
1747 * keyboard.c (safe_run_hook_funcall): New function.
1748 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1749 don't set the hook to nil, but remove the offending function instead.
1750 (Qcommand_hook_internal): Remove, unused.
1751 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1752 Vcommand_hook_internal.
1753
1754 * eval.c (enum run_hooks_condition): Remove.
1755 (funcall_nil, funcall_not): New functions.
1756 (run_hook_with_args): Call each function through a `funcall' argument.
1757 Remove `cond' argument, now redundant.
1758 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1759 (Frun_hook_with_args_until_failure): Adjust accordingly.
1760 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1761
1db5b1ad
JB
17622011-03-28 Juanma Barranquero <lekktu@gmail.com>
1763
1764 * dispextern.h (string_buffer_position): Remove declaration.
1765
1766 * print.c (strout): Remove parameter `multibyte', unused since
1767 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1768
1769 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1770 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1771 All callers changed.
1772
1773 * w32.c (_wsa_errlist): Use braces for struct initializers.
1774
1775 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1776 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1777 All callers changed.
1778 (string_buffer_position): Likewise. Also, make static (it's never
1779 used outside xdisp.c).
1780 (cursor_row_p): Remove parameter `w', unused since
1781 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1782 (decode_mode_spec): Remove parameter `precision', introduced during
1783 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1784 All callers changed.
1785
5ffb62aa
JD
17862011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1787
1788 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1789
461c2ab9 17902011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1791
1792 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1793 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1794 (ns_update_auto_hide_menu_bar): New functions.
1795 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1796 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1797 ns_constrain_all_frames.
1798 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1799 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1800
5c380ffb
JD
18012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1802
1803 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1804
9af30bdf
GM
18052011-03-27 Glenn Morris <rgm@gnu.org>
1806
1807 * syssignal.h: Replace RETSIGTYPE with void.
1808 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1809 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1810 Replace SIGTYPE with void everywhere.
1811 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1812 * s/template.h (SIGTYPE): Remove commented out definition.
1813
e2abce01
JB
18142011-03-26 Eli Zaretskii <eliz@gnu.org>
1815
1816 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1817 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1818
f868cd8a
JB
18192011-03-26 Juanma Barranquero <lekktu@gmail.com>
1820
59eb0929
JB
1821 * w32.c (read_unc_volume): Use parameter `henum', instead of
1822 global variable `wget_enum_handle'.
1823
1824 * keymap.c (describe_vector): Remove parameters `indices' and
1825 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1826 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1827
f868cd8a
JB
1828 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1829
1830 * keyboard.c (timer_check): Remove parameter `do_it_now',
1831 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1832 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1833 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1834
1835 * keyboard.c (read_char):
1836 * w32menu.c (w32_menu_display_help):
1837 * xmenu.c (show_help_event, menu_help_callback):
1838 Adjust calls to `show_help_echo'.
1839
1840 * gtkutil.c (xg_maybe_add_timer):
1841 * keyboard.c (readable_events):
1842 * process.c (wait_reading_process_output):
1843 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1844
1845 * insdel.c (adjust_markers_gap_motion):
1846 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1847 (gap_left, gap_right): Don't call it.
1848
2ecf6fdb
CY
18492011-03-25 Chong Yidong <cyd@stupidchicken.com>
1850
1851 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1852 incurred during fontification.
1853
6b1f9ba4
JB
18542011-03-25 Juanma Barranquero <lekktu@gmail.com>
1855
1856 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1857 (DEFVAR_PER_BUFFER): Don't pass it.
1858
1859 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1860 (scrolling_window): Don't pass it.
1861
0f4a96b5
JB
18622011-03-25 Juanma Barranquero <lekktu@gmail.com>
1863
1864 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1865
1866 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1867 and `suffix'.
1868 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1869 of variables specific to SELinux and computation of `encoded_absname'.
1870
1871 * image.c (XPutPixel): Remove unused variable `height'.
1872
1873 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1874
1875 * unexw32.c (get_section_info): Remove unused variable `section'.
1876
1877 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1878 (system_process_attributes): Remove unused variable `sess'.
1879 (sys_read): Remove unused variable `err'.
1880
1881 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1882 (w32_wnd_proc): Remove unused variable `isdead'.
1883 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1884 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1885 (x_create_tip_frame): Remove unused variable `tem'.
1886
1887 * w32inevt.c (w32_console_read_socket):
1888 Remove unused variable `no_events'.
1889
1890 * w32term.c (x_draw_composite_glyph_string_foreground):
1891 Remove unused variable `width'.
1892
1149507c
JB
18932011-03-24 Juanma Barranquero <lekktu@gmail.com>
1894
1895 * w32term.c (x_set_glyph_string_clipping):
1896 Don't pass uninitialized region to CombineRgn.
1897
9c88f339
JB
18982011-03-23 Juanma Barranquero <lekktu@gmail.com>
1899
1900 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1901 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1902 (Fx_close_connection): Remove unused variable `i'.
1903
1904 * w32font.c (w32font_draw): Return number of glyphs.
1905 (w32font_open_internal): Remove unused variable `i'.
1906 (w32font_driver): Add missing initializer.
1907
1908 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1909 (fill_in_menu): Remove unused variable `items_added'.
1910
1911 * w32term.c (last_mouse_press_frame): Remove static global variable.
1912 (w32_clip_to_row): Remove unused variable `f'.
1913 (x_delete_terminal): Remove unused variable `i'.
1914
1915 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1916 (NOTHING): Remove unused static global variable.
1917 (uniscribe_check_otf): Remove unused variable `table'.
1918 (uniscribe_font_driver): Add missing initializers.
1919
dee091a3
JD
19202011-03-23 Julien Danjou <julien@danjou.info>
1921
1922 * term.c (Fsuspend_tty, Fresume_tty):
1923 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1924 * window.c (temp_output_buffer_show):
1925 * insdel.c (signal_before_change):
1926 * frame.c (Fhandle_switch_frame):
1927 * fileio.c (Fdo_auto_save):
1928 * emacs.c (Fkill_emacs):
1929 * editfns.c (save_excursion_restore):
1930 * cmds.c (internal_self_insert):
1931 * callint.c (Fcall_interactively):
1932 * buffer.c (Fkill_all_local_variables):
1933 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1934 Use Frun_hooks.
0f4a96b5 1935 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1936 unconditionnaly since it does the check itself.
1937
2c520ab5 19382011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1939
c9c49752
PE
1940 Fix more problems found by GCC 4.5.2's static checks.
1941
8abc3f12
PE
1942 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1943 the first time through the loop, since we know p0 < p1 then.
1944 This also avoids a gcc -Wstrict-overflow warning.
1945
a2d26660
PE
1946 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1947 leading to a memory leak, possible in functions like
1948 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1949 of objects (Bug#8318).
a2d26660 1950
916c72e9
PE
1951 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1952 that could (at least in theory) be that large.
1953
19ab8a18
PE
1954 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1955 This is less likely to overflow, and avoids undefined behavior if
1956 overflow does occur. All callers changed. Use strtoul to scan
1957 for the unsigned long integer.
b7cbbd6f
PE
1958 (pint2hrstr): Simplify and tune code slightly.
1959 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1960
f0641eff
PE
1961 * scroll.c (do_scrolling): Work around GCC bug 48228.
1962 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1963
7f650bb9
PE
1964 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1965 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1966 (validate_x_resource_name): Simplify count usage.
1967 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1968
37dd57d1
PE
1969 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1970 fail (Bug#8306).
81e56e61 1971
699979fc 1972 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1973
401bf9b4
PE
1974 * process.c (Fmake_network_process): Use socklen_t, not int,
1975 where POSIX says socklen_t is required in portable programs.
1976 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1977 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1978 (Fmake_network_process, server_accept_connection):
1979 (wait_reading_process_output, read_process_output):
1980 Likewise.
1981
b93aacde
PE
1982 * process.c: Rename or move locals to avoid shadowing.
1983 (list_processes_1, Fmake_network_process):
1984 (read_process_output_error_handler, exec_sentinel_error_handler):
1985 Rename or move locals.
4dc343ee 1986 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1987 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1988 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1989 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1990 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1991
af8a867c 1992 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1993 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1994 Include tparam.h instead, since it declares them.
af8a867c
PE
1995 * cm.h (PC): Remove extern decl; tparam.h now does this.
1996 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1997 * terminfo.c: Include tparam.h, to check interfaces.
1998 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1999 (tparam): Adjust signature to match interface in tparam.h;
2000 this removes some undefined behavior. Check that outstring and len
2001 are zero, which they always are with Emacs.
2002 * tparam.h (PC, BC, UP): New extern decls.
2003
0248044d 2004 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2005 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2006
8ff096c1 2007 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2008 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2009 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2010 (ftfont_list): Remove unused local.
49eaafba
PE
2011 (get_adstyle_property, ftfont_pattern_entity):
2012 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2013 Rename locals to avoid shadowing.
8ff096c1 2014
e2be39f6
PE
2015 * xfont.c (xfont_list_family): Mark var as initialized.
2016
c9735e30
PE
2017 * xml.c (make_dom): Now static.
2018
8f5201ae
PE
2019 * composite.c (composition_compute_stop_pos): Rename local to
2020 avoid shadowing.
b246f932
PE
2021 (composition_reseat_it): Remove unused locals.
2022 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2023 (composition_update_it): Mark var as initialized.
11b61122
PE
2024 (find_automatic_composition): Mark vars as initialized,
2025 with a FIXME (Bug#8290).
8f5201ae 2026
760fbc2c
PE
2027 character.h: Rename locals to avoid shadowing.
2028 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2029 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2030 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2031 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2032 to avoid shadowing.
2033
ff08eb85
PE
2034 * textprop.c (property_change_between_p): Remove; unused.
2035
fc7bf025
PE
2036 * intervals.c (interval_start_pos): Now static.
2037
235d7abc
PE
2038 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2039
44f230aa
SM
2040 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2041 Rename locals to avoid shadowing.
3e7d6594 2042
50060332
PE
2043 * sound.c (wav_play, au_play, Fplay_sound_internal):
2044 Fix pointer signedness.
d01f234b 2045 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2046 (wav_play): Initialize a variable to 0, to prevent undefined
2047 behavior (Bug#8278).
50060332 2048
c4fc4e30
PE
2049 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2050
918436ed
PE
2051 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2052
c939f91b
PE
2053 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2054 clobbering (Bug#8298).
b9c7f648
PE
2055 * sysdep.c (sys_subshell): Likewise.
2056 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2057
6bd8c144
PE
2058 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2059 This should get cleaned up, so that child_setup has the
2060 same signature on all platforms.
2061
7710357c 2062 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2063 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2064
c59da222
CY
20652011-03-22 Chong Yidong <cyd@stupidchicken.com>
2066
2067 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2068 not to be necessary, and produces flickering.
2069
66b87493
GM
20702011-03-20 Glenn Morris <rgm@gnu.org>
2071
2072 * config.in: Remove file.
2073
45b6f6d5
JB
20742011-03-20 Juanma Barranquero <lekktu@gmail.com>
2075
2076 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2077 are now in src/globals.h.
2078 (syms_of_minibuf): Remove spurious & from previous change.
2079
3ec03f7e
LL
20802011-03-20 Leo <sdl.web@gmail.com>
2081
2082 * minibuf.c (completing-read-function): New variable.
2083 (completing-read-default): Rename from completing-read.
2084 (completing-read): Call completing-read-function.
2085
b14e3e21
CY
20862011-03-19 Juanma Barranquero <lekktu@gmail.com>
2087
2088 * xfaces.c (Fx_load_color_file):
2089 Read color file from absolute filename (bug#8250).
2090
f2b726e6
JB
20912011-03-19 Juanma Barranquero <lekktu@gmail.com>
2092
2093 * makefile.w32-in: Update dependencies.
2094
09f6ff02
EZ
20952011-03-17 Eli Zaretskii <eliz@gnu.org>
2096
2097 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2098
29a6015a
PE
20992011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2100
a3a6c54e
PE
2101 Fix more problems found by GCC 4.5.2's static checks.
2102
b766f867
PE
2103 * process.c (make_serial_process_unwind, send_process_trap):
2104 (sigchld_handler): Now static.
2105
be02381c
PE
2106 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2107 That way, the code declares only the vars that it needs.
2108 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2109 * s/cygwin.h (PTY_ITERATION): Likewise.
2110 * s/darwin.h (PTY_ITERATION): Likewise.
2111 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2112
57048744
PE
2113 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2114 * process.c (allocate_pty): Don't declare stb unless it's needed.
2115
7914961c 2116 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2117 (CONSTANTLIM): Remove; unused.
2118 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2119 Define only if needed.
7914961c 2120
b3967b18
PE
2121 * unexelf.c (unexec): Name an expression,
2122 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2123 Use a different way to cause a compilation error if anyone uses
2124 n rather than nn, a way that does not involve shadowing.
73366a00 2125 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2126
29a6015a
PE
2127 * deps.mk (unexalpha.o): Remove; unused.
2128
43cfc33e 2129 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2130 * unexec.h: New file.
ce701a33
PE
2131 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2132 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2133 Depend on unexec.h.
2134 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2135 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2136 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2137 Change as necessary to match prototype in unexec.h.
ce701a33 2138
01f44d5a
PE
2139 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2140 shadowing.
4f63c6bb 2141 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2142
a6670b0b
PE
2143 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2144 Rename locals to avoid shadowing.
2145
cef2010d 2146 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2147 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2148
d4d7173a
PE
2149 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2150
f08b802a
PE
2151 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2152 warning when compiling print.c.
2153
3ddb0639
PE
2154 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2155 instead of using an uninitialized var.
5ad03b97 2156 (font_sort_entities): Mark var as initialized.
3ddb0639 2157
170a2692
PE
2158 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2159
e663c700
PE
2160 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2161 pointers to constants.
89bc529a 2162 (font_parse_fcname): Remove unused vars.
7b81e2d0 2163 (font_delete_unmatched): Now static.
ea838e10 2164 (font_get_spec): Remove; unused.
13a547c6
PE
2165 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2166 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2167 Rename or move locals to avoid shadowing.
e663c700 2168
2a80c887 2169 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2170 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2171
1384fa33 2172 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2173 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2174
8b2c52e9
PE
2175 * alloc.c (mark_backtrace): Move decl from here ...
2176 * lisp.h: ... to here, so that it can be checked.
2177
475545b5 2178 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2179 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2180 (lisp_indirect_variable): Name an expression,
2181 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2182 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2183
b1349114 2184 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2185 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2186 Use const pointer when appropriate.
b1349114 2187
a2928364
PE
2188 * lisp.h (get_system_name, get_operating_system_release):
2189 Move decls here, to check interfaces.
2190 * process.c (get_operating_system_release): Move decl to lisp.h.
2191 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2192 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2193 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2194 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2195 (Fformat_time_string, Fencode_time, Finsert_char):
2196 (Ftranslate_region_internal, Fformat):
2197 Rename or remove local vars to avoid shadowing.
9710023e 2198 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2199
a415e694
PE
2200 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2201 avoid shadowing.
2202
8ef4622d
PE
2203 * lisp.h (eassert): Check that the argument compiles, even if
2204 ENABLE_CHECKING is not defined.
2205
946f9a5b
PE
2206 * data.c (Findirect_variable): Name an expression, to avoid
2207 gcc -Wbad-function-cast warning.
112396d6 2208 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2209 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2210 (Fmake_variable_buffer_local, Fmake_local_variable):
2211 Mark variables as initialized.
52746918 2212 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2213
e5aab7e7 2214 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2215 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2216 Rename locals to avoid shadowing.
dff45157
PE
2217 (mark_stack): Move local variables into the #ifdef region where
2218 they're used.
7bc26fdb
PE
2219 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2220 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2221 needed otherwise.
2222 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2223 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2224 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2225
e5aab7e7
PE
2226 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2227 avoids undefined behavior in theory.
2228
4da60324
PE
2229 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2230
88043301
PE
2231 Use functions, not macros, for up- and down-casing (Bug#8254).
2232 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2233 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2234 to use the following functions instead of these macros.
2235 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2236 EMACS_INT, since callers assume the returned value fits in int.
2237 (upcase1): Likewise, for UPCASE_TABLE.
2238 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2239 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2240 the race-condition problem in the old DOWNCASE.
88043301 2241
19ed5445
PE
2242 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2243 Rename locals to avoid shadowing.
2244 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2245 (regex_compile, re_search_2, re_match_2_internal):
2246 Remove unused local vars.
952db0d7
PE
2247 (FREE_VAR): Rewrite so as not to use empty "else",
2248 which gcc can warn about.
da053e48 2249 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2250 (RETALLOC_IF): Define only if needed.
2251 (WORDCHAR_P): Likewise. This one is never needed, but is used
2252 only in a comment talking about a compiler bug, so put inside
2253 the #if 0 of that comment.
2254 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2255 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2256 Remove; unused.
19ed5445 2257
1f3561e4 2258 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2259 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2260 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2261
ded6f8f7
PE
2262 * search.c (simple_search): Remove unused var.
2263
dbd37a95
PE
2264 * dired.c (compile_pattern): Move decl from here ...
2265 * lisp.h: ... to here, so that it can be checked.
2266 (struct re_registers): New forward decl.
2267
7e47afad
PE
2268 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2269
85f24f61
PE
2270 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2271 All uses changed.
2272 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2273 Rename locals to avoid shadowing.
5671df8f 2274 (Fvertical_motion): Mark locals as initialized.
85f24f61 2275
181aa2be 2276 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2277 (casify_region): Mark local as initialized.
181aa2be 2278
930d429c
PE
2279 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2280
7082eac6
PE
2281 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2282 New macros, so that the caller can use some names other than
2283 gcpro1, gcpro2, etc.
2284 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2285 of the new macros.
2286 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2287 argument, for consistency with GCPRO2_VAR, etc: it is now the
2288 prefix of the variable, not the variable itself. All uses
2289 changed.
38b2c076
PE
2290 * dired.c (directory_files_internal, file_name_completion):
2291 Rename locals to avoid shadowing.
2292
15206ed9
PE
2293 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2294 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2295 dired.c's scmp function, had undefined behavior.
2296 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2297 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2298 * buffer.h: ... to here, because these macros use current_buffer,
2299 and the new implementation with inline functions needs to have
2300 current_buffer in scope now, rather than later when the macros
2301 are used.
2302 (downcase, upcase1): New static inline functions.
2303 (DOWNCASE, UPCASE1): Reimplement using these functions.
2304 This avoids undefined behavior in expressions like
2305 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2306 from race conditions in accessing the global variables
2307 case_temp1 and case_temp2.
2308 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2309 * lisp.h (case_temp1, case_temp2): Remove their decls.
2310 * character.h (ASCII_CHAR_P): Move from here ...
2311 * lisp.h: ... to here, so that the inline functions mentioned
2312 above can use them.
2313
4a6bea26
PE
2314 * dired.c (directory_files_internal_unwind): Now static.
2315
f14b7e14
PE
2316 * fileio.c (file_name_as_directory, directory_file_name):
2317 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2318 Now static.
2893f146
PE
2319 (file_name_as_directory): Use const pointers when appropriate.
2320 (Fexpand_file_name): Likewise. In particular, newdir might
2321 point at constant storage, so make it a const pointer.
fd4ead52 2322 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2323 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2324 signedness issues.
f839df0c
PE
2325 (Fset_file_times, Finsert_file_contents, auto_save_error):
2326 Rename locals to avoid shadowing.
f14b7e14 2327
5716756e 2328 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2329 (Ftry_completion, Fall_completions): Rename or remove locals
2330 to avoid shadowing.
5716756e 2331
b4c3046a
PE
2332 * marker.c (bytepos_to_charpos): Remove; unused.
2333
b45db522
PE
2334 * lisp.h (verify_bytepos, count_markers): New decls,
2335 so that gcc does not warn that these functions aren't declared.
2336
85876d07
PE
2337 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2338 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2339 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2340 (copy_text): Remove unused local var.
85876d07 2341
03d78a21 2342 * filelock.c (within_one_second): Now static.
b3dd38ab 2343 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2344
5df8f01b
PE
2345 * buffer.c (fix_overlays_before): Mark locals as initialized.
2346 (fix_start_end_in_overlays): Likewise. This function should be
2347 simplified by using pointers-to-pointers, but that's a different
2348 matter.
b1d876f1 2349 (switch_to_buffer_1): Now static.
8f54f30a
PE
2350 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2351 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2352
a70072c9 2353 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2354 Fix pointer signedness issue.
edced198
PE
2355 (sys_subshell): Mark local as volatile if checking for lint,
2356 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2357 (MAXPATHLEN): Define only if needed.
a70072c9 2358
a0977c44
PE
2359 * process.c (serial_open, serial_configure): Move decls from here ...
2360 * systty.h: ... to here, so that they can be checked.
2361
a884fdcc
PE
2362 * fns.c (get_random, seed_random): Move extern decls from here ...
2363 * lisp.h: ... to here, so that they can be checked.
2364
604efe86 2365 * sysdep.c (reset_io): Now static.
b8950c94 2366 (wait_for_termination_signal): Remove; unused.
604efe86 2367
38fc62d9
PE
2368 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2369 (copy_keymap_item, append_key, push_text_char_description):
2370 Now static.
1004a21a 2371 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2372 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2373 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2374 (describe_map_tree):
2375 Rename locals to avoid shadowing.
38fc62d9 2376
2f2650da
PE
2377 * keyboard.c: Declare functions static if they are not used elsewhere.
2378 (echo_char, echo_dash, cmd_error, top_level_2):
2379 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2380 (read_char, kbd_buffer_get_event, make_lispy_position):
2381 (make_lispy_event, make_lispy_movement, apply_modifiers):
2382 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2383 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2384 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2385 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2386 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2387
a053e86c 2388 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2389 (mark_kboards): Move decl here ...
2390 * alloc.c (mark_kboards): ... from here.
a053e86c 2391
4752793e
PE
2392 * lisp.h (force_auto_save_soon): New decl.
2393
74f10ca7 2394 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2395 (DEFINE_DUMMY_FUNCTION): New macro.
2396 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2397 Use it.
c03cd23f
PE
2398 (main): Add casts to avoid warnings
2399 if GCC considers string literals to be constants.
74f10ca7 2400
022e70d4
PE
2401 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2402
59d6fe83
PE
2403 * dbusbind.c: Pointer signedness fixes.
2404 (xd_signature, xd_append_arg, xd_initialize):
2405 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2406 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2407 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2408 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2409
78320123
PE
2410 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2411 if GCC considers string literals to be constants.
49cebcca 2412 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2413
35ac2a97
SM
24142011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2415
fb103ca9
SM
2416 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2417 (print_preprocess, print_object): New macro to fix last change.
2418
35ac2a97
SM
2419 * print.c (print_preprocess): Don't forget font objects.
2420
62973b41
JB
24212011-03-16 Juanma Barranquero <lekktu@gmail.com>
2422
2423 * emacs.c (USAGE3): Doc fixes.
2424
0e48bb22
AS
24252011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2426
2427 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2428 structure.
2429
7684e57b
JB
24302011-03-14 Juanma Barranquero <lekktu@gmail.com>
2431
2432 * lisp.h (VWindow_system, Qfile_name_history):
2433 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2434 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2435 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2436
2437 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2438 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2439
2440 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2441 * w32console.c (detect_input_pending, read_input_pending)
2442 (encode_terminal_code):
2443 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2444 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2445 (w32_system_caret_y, Qfile_name_history):
2446 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2447 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2448 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2449 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2450 * w32proc.c (Qlocal, report_file_error):
2451 * w32term.c (Vwindow_system, updating_frame):
2452 * w32uniscribe.c (initialized, uniscribe_font_driver):
2453 Remove unneeded extern declarations.
2454
2aa46d6c
CY
24552011-03-14 Chong Yidong <cyd@stupidchicken.com>
2456
c96bbc66 2457 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2458
cffc6f3b
CY
24592011-03-13 Chong Yidong <cyd@stupidchicken.com>
2460
2461 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2462 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2463 These macros can no longer be used for assignment.
2464
44f230aa
SM
2465 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2466 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2467 (record_buffer_markers, fetch_buffer_markers): New functions for
2468 recording and fetching special buffer markers.
2469 (set_buffer_internal_1, set_buffer_temp): Use them.
2470
2471 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2472
2473 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2474
2475 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2476 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2477
2478 * xdisp.c (hscroll_window_tree):
2479 (reconsider_clip_changes): Use PT instead of BUF_PT.
2480
d251f04b
EZ
24812011-03-13 Eli Zaretskii <eliz@gnu.org>
2482
2483 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2484 $(EMACS_ROOT)/lib/intprops.h.
2485
f0c77cd1
PE
24862011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2487
3eca4629
PE
2488 Fix more problems found by GCC 4.5.2's static checks.
2489
7c86ee98
PE
2490 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2491 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2492 (xg_free_frame_widgets): Make it clear that a local variable is
2493 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2494 (gdk_window_get_screen): Make it clear that this macro is needed
2495 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2496 (int_gtk_range_get_value): New function, which avoids a diagnostic
2497 from gcc -Wbad-function-cast.
2498 (xg_set_toolkit_scroll_bar_thumb): Use it.
2499 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2500 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2501 (get_utf8_string, xg_get_file_with_chooser):
2502 Rename locals to avoid shadowing.
2503 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2504
41729b81
PE
2505 * xgselect.c (xg_select): Remove unused var.
2506
f0c77cd1
PE
2507 * image.c (four_corners_best): Mark locals as initialized.
2508 (gif_load): Initialize transparent_p to zero (Bug#8238).
2509 Mark another local as initialized.
ec6cf4c6 2510 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2511
ce0ad53d 2512 * image.c (clear_image_cache): Now static.
d5d5a617 2513 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2514 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2515 (x_edge_detection): Remove unnecessary cast that
2516 gcc -Wbad-function-cast diagnoses.
2037898d 2517 (gif_load): Fix pointer signedness.
6ae141d6
PE
2518 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2519 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2520
33383987 25212011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2522
d32df629
PE
2523 Improve quality of tests for time stamp overflow.
2524 For example, without this patch (encode-time 0 0 0 1 1
2525 1152921504606846976) returns the obviously-bogus value (-948597
2526 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2527 reports time overflow. See
2528 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2529 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2530 * editfns.c: Include limits.h and intprops.h.
2531 (TIME_T_MIN, TIME_T_MAX): New macros.
2532 (time_overflow): Move earlier, to before first use.
2533 (hi_time, lo_time): New functions, for an accurate test for
2534 out-of-range times.
2535 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2536 (Fget_internal_run_time): Don't assume time_t fits in int.
2537 (make_time): Use list2 instead of Fcons twice.
2538 (Fdecode_time): More accurate test for out-of-range times.
2539 (check_tm_member): New function.
2540 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2541 (lisp_time_argument): Don't rely on undefined left-shift and
2542 right-shift behavior when checking for time stamp overflow.
8be6f318 2543
fe31d94c
PE
2544 * editfns.c (time_overflow): New function, refactoring common code.
2545 (Fformat_time_string, Fdecode_time, Fencode_time):
2546 (Fcurrent_time_string): Use it.
2547
8be6f318
PE
2548 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2549 * dired.c (make_time): Move to ...
2550 * editfns.c (make_time): ... here.
2551 * systime.h: Note the move.
2552
09d9db2c 25532011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2554
126bc0dc
YM
2555 * fringe.c (update_window_fringes): Remove unused variables.
2556
c47cbdfd
YM
2557 * unexmacosx.c (copy_data_segment): Also copy __got section.
2558 (Bug#8223)
2559
7ac80be9
EZ
25602011-03-12 Eli Zaretskii <eliz@gnu.org>
2561
c96bbc66 2562 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2563 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2564 Constify `char *' arguments and their references according to
2565 prototypes in tparam.h.
2566
ecb0f94d 2567 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2568
7ac80be9
EZ
2569 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2570 Adapt all references accordingly.
2571
2572 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2573
ef1fd07e
TT
25742011-03-11 Tom Tromey <tromey@redhat.com>
2575
2576 * buffer.c (syms_of_buffer): Remove obsolete comment.
2577
7ef4b50c
EZ
25782011-03-11 Eli Zaretskii <eliz@gnu.org>
2579
2580 * termhooks.h (encode_terminal_code): Declare prototype.
2581
2582 * msdos.c (encode_terminal_code): Don't declare prototype.
2583
2584 * term.c (encode_terminal_code): Now external again, used by
2585 w32console.c and msdos.c.
2586
44f230aa
SM
2587 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2588 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2589
4b1ec863 25902011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2591
1714f52b 2592 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2593
4b1ec863
PE
2594 * fringe.c (update_window_fringes): Mark locals as initialized
2595 (Bug#8227).
2596 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2597
524c7aa6
PE
2598 * alloc.c (mark_fringe_data): Move decl from here ...
2599 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2600 to check its interface.
2601 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2602
a5c0af81 2603 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2604 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2605 (fontset_font): Mark local as initialized.
a9a06e0b 2606 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2607
b4716021
PE
2608 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2609
811e9bac 2610 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2611 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2612 (x_own_selection, Fx_disown_selection_internal): Rename locals
2613 to avoid shadowing.
2614 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2615
7e3ab302
PE
2616 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2617 so that the caller can use some name other than gcpro1.
2618 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2619 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2620 (Fx_backspace_delete_keys_p):
2621 Use them to avoid shadowing, and rename vars to avoid shadowing.
2622 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2623 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2624 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2625 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2626 Remove unused locals.
7e3ab302
PE
2627 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2628 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2629 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2630 macros.
f78faa98 2631
e2b13473
PE
2632 * xterm.h (x_mouse_leave): New decl.
2633
77f23912
PE
2634 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2635 Remove unused functions.
cdf4ba58
PE
2636 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2637 (x_calc_absolute_position): Now static.
7411c686 2638 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2639 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2640 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2641 unless they are used.
38d0b34a
PE
2642 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2643 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2644 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2645 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2646 (x_error_catcher, x_connection_closed, x_error_handler):
2647 (x_error_quitter, xembed_send_message, x_iconify_frame):
2648 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2649 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2650 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2651
44f230aa
SM
2652 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2653 Rename or move locals to avoid shadowing.
6b463e58 2654 (tty_defined_color, merge_face_heights): Now static.
5967d051 2655 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2656 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2657 does not deduce is never used uninitialized.
73719eba
PE
2658 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2659 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2660
426994c3 2661 * terminal.c (store_terminal_param): Now static.
5489860b 2662
032f1620 2663 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2664 (set_frame_menubar): Remove unused local.
d4323972 2665 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2666 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2667 since they might point to immutable storage.
281585b0
PE
2668 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2669 since it's unused otherwise.
032f1620 2670
367c19e5 2671 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2672 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2673 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2674 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2675 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2676 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2677 does not deduce are never used uninitialized.
70739cbe 2678
07b48fa9
PE
2679 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2680
8868a238 2681 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2682 * window.c (window_loop, size_window):
2683 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2684
7e5cf297 2685 * window.c (display_buffer): Now static.
d6550a9f
PE
2686 (size_window): Mark variables that gcc -Wuninitialized
2687 does not deduce are never used uninitialized.
a586633d
PE
2688 * window.h (check_all_windows): New decl, to forestall
2689 gcc -Wmissing-prototypes diagnostic.
5b555da1 2690 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2691
f6095868
PE
2692 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2693 shadowing.
2694 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2695 Include <limits.h>.
2696 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2697 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2698 (load_charset_map): Mark variables that gcc -Wuninitialized
2699 does not deduce are never used uninitialized.
53df7c11 2700 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2701
f38b440c
PE
2702 * coding.c (coding_set_source, coding_set_destination):
2703 Use "else { /* comment */ }" rather than "else /* comment */;"
2704 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2705 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2706 a block, when the outer 'i' will do.
2707 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2708 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2709 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2710 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2711 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2712 Rename locals to avoid shadowing.
2713 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2714 * coding.c (emacs_mule_char, encode_invocation_designation):
2715 Now static, since they're not used elsewhere.
413bb2db 2716 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2717 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2718 (decode_coding_emacs_mule): Mark variables that gcc
2719 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2720 (detect_coding_iso_2022): Initialize a local variable that might
2721 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2722 this initialization is needed. (Bug#8211)
5f58e762
PE
2723 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2724 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2725 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2726 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2727 Remove unused macros.
f38b440c 2728
232b38b9 2729 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2730 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2731 * character.c (string_count_byte8): Likewise.
232b38b9 2732
fb90da1b
PE
2733 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2734 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2735
fb93dbc2
PE
2736 * chartab.c (copy_sub_char_table): Now static, since it's not used
2737 elsewhere.
5c156ace
PE
2738 (sub_char_table_ref_and_range, char_table_ref_and_range):
2739 Rename locals to avoid shadowing.
bbcd0949 2740 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2741
7d3b3862 2742 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2743 (BIDI_BOB): Remove unused macro.
7d3b3862 2744
6be7d3da
PE
2745 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2746 deduce are never used uninitialized.
c2ed9c8b 2747 * term.c (encode_terminal_code): Likewise.
6be7d3da 2748
75f8807f 2749 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2750
50938595
PE
2751 * tparam.h: New file.
2752 * term.c, tparam.h: Include it.
2753 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2754 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2755 Move these decls to tparam.h, and make them agree with what
2756 is actually in tparam.c. The previous trick of using incompatible
2757 decls in different modules does not conform to the C standard.
2758 All callers of tparam changed to use tparam's actual API.
2759 * tparam.c (tparam1, tparam, tgoto):
2760 Use const pointers where appropriate.
2761
fbceeba2
PE
2762 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2763 * cm.h (struct cm): Likewise.
2764 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2765 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2766 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2767 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2768 (turn_on_face, init_tty): Likewise.
2769 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2770
7f3f1250
PE
2771 * term.c (term_mouse_position): Rename local to avoid shadowing.
2772
e6ca6543
PE
2773 * alloc.c (mark_ttys): Move decl from here ...
2774 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2775
c40f8d15
AS
27762011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2777
2778 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2779
cfe0661d
JB
27802011-03-09 Juanma Barranquero <lekktu@gmail.com>
2781
2782 * search.c (compile_pattern_1): Remove argument regp, unused since
2783 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2784 (compile_pattern): Don't pass it.
2785
0afb4571
J
27862011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2787
2788 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2789 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2790 for ! HAVE_GTK3.
2791 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2792
2793 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2794
2795 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2796 gdk_window_get_screen, gdk_window_get_geometry,
2797 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2798 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2799 (xg_get_pixbuf_from_pixmap): New function.
2800 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2801 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2802 Call xg_get_pixbuf_from_pixmap instead of
2803 gdk_pixbuf_get_from_drawable.
2804 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2805 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2806 (xg_check_special_colors): Use GtkStyleContext and its functions
2807 for HAVE_GTK3.
2808 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2809 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2810 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2811 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2812 Call gtk_widget_get_preferred_size.
0afb4571
J
2813 (xg_frame_resized): gdk_window_get_geometry only takes 5
2814 parameters.
44f230aa
SM
2815 (xg_win_to_widget, xg_event_is_for_menubar):
2816 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2817 (xg_set_widget_bg): New function.
2818 (delete_cb): New function.
895009e1 2819 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
2820 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2821 (xg_set_background_color): Call xg_set_widget_bg.
2822 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2823 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2824 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2825 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2826 if ! HAVE_GTK3.
2827 (update_frame_tool_bar): Call gtk_widget_hide.
2828 (xg_initialize): Use GDK_KEY_g.
2829
2830 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2831 if ! HAVE_GTK3
2832 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2833
2834 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2835 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2836 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2837
1c2cc4ef
JB
28382011-03-08 Juanma Barranquero <lekktu@gmail.com>
2839
2840 * w32xfns.c (select_palette): Check success of RealizePalette against
2841 GDI_ERROR, not zero.
2842
33383987 2843See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2844
2845;; Local Variables:
2846;; coding: utf-8
aac0c6e3
MR
2847;; End:
2848
33383987 2849 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2850
2851 This file is part of GNU Emacs.
2852
2853 GNU Emacs is free software: you can redistribute it and/or modify
2854 it under the terms of the GNU General Public License as published by
2855 the Free Software Foundation, either version 3 of the License, or
2856 (at your option) any later version.
2857
2858 GNU Emacs is distributed in the hope that it will be useful,
2859 but WITHOUT ANY WARRANTY; without even the implied warranty of
2860 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2861 GNU General Public License for more details.
2862
2863 You should have received a copy of the GNU General Public License
2864 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.