Merge from emacs-23; up to 2010-06-12T10:58:54Z!romain@orebokech.com.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e067f0c1
CY
12011-05-26 Chong Yidong <cyd@stupidchicken.com>
2
3 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4 (converted_selections, conversion_fail_tag): New global variables.
5 (x_selection_request_lisp_error): Free the above.
6 (x_get_local_selection): Remove unnecessary code.
7 (x_reply_selection_request): Args changed; handle arbitrary array
8 of converted selections stored in converted_selections. Separate
9 the XChangeProperty and SelectionNotify steps.
10 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11 (x_convert_selection): New function.
12 (x_handle_selection_event): Simplify.
13 (x_get_foreign_selection): Don't ignore incoming requests while
14 waiting for an answer; this will fail when we implement
15 SAVE_TARGETS, and seems unnecessary anyway.
16 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
17 (Vx_sent_selection_functions): Doc fix.
18
0f4aebc0
LL
192011-05-26 Leo Liu <sdl.web@gmail.com>
20
21 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
22
e61124cd
YM
232011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
24
25 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
26
27 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
28 for fringe update if it has periodic bitmap.
29 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
30 and fringe_bitmap_periodic_p.
31
32 * fringe.c (get_fringe_bitmap_data): New function.
33 (draw_fringe_bitmap_1, update_window_fringes): Use it.
34 (update_window_fringes): Record periodicity of fringe bitmap in glyph
35 row. Mark glyph row for fringe update if periodicity changed.
36
37 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
38 for fringe update unless it has periodic bitmap.
39
f16d9837
KH
402011-05-25 Kenichi Handa <handa@m17n.org>
41
42 * xdisp.c (get_next_display_element): Set correct it->face_id for
43 a static composition.
44
e1b90ef6
LL
452011-05-24 Leo Liu <sdl.web@gmail.com>
46
47 * deps.mk (fns.o):
48 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
49
50 * fns.c (crypto_hash_function, Fsha1): New function.
51 (Fmd5): Use crypto_hash_function.
52 (syms_of_fns): Add Ssha1.
53
7400048f
PE
542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
55
56 * gnutls.c: Remove unused macros.
57 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
58 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
59 Remove macros that are defined and never used.
60 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
61
abb71cf4
CY
622011-05-22 Chong Yidong <cyd@stupidchicken.com>
63
64 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
65 (Fx_get_selection_internal): Minor cleanup.
66 (Fx_own_selection_internal): Rename arguments for consistency with
67 select.el.
68
6307db39
PE
692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
70
71 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
72
f3d4e0a4
CY
732011-05-22 Chong Yidong <cyd@stupidchicken.com>
74
75 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
76
4d8ade89
YM
772011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
78
79 * dispnew.c (scrolling_window): Don't exclude the case that the
80 last enabled row in the desired matrix touches the bottom boundary.
81
32078c8d
GM
822011-05-21 Glenn Morris <rgm@gnu.org>
83
84 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
85 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
86 and add some more files.
32078c8d 87
7285dc67
EZ
882011-05-20 Eli Zaretskii <eliz@gnu.org>
89
90 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
91 report_file_error introduced by the change from 2011-05-07.
92
89d1bd22
PE
932011-05-20 Paul Eggert <eggert@cs.ucla.edu>
94
95 * systime.h (Time): Define only if emacs is defined.
96 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
97 where the include path doesn't have X11/X.h by default. See
98 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
99
e23640bb 1002011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
101
102 * composite.c (find_automatic_composition): Fix previous change.
103
b9704ad9
GM
1042011-05-20 Glenn Morris <rgm@gnu.org>
105
106 * lisp.mk: New file, split from Makefile.in.
107 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
108 (shortlisp): Remove.
109 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
110
4a720484
GM
1112011-05-19 Glenn Morris <rgm@gnu.org>
112
113 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
114 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
115 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
116 (lisp): Set the order to that of loadup.el.
117 (shortlisp): Make it a copy of $lisp.
118 (SOME_MACHINE_LISP): Remove.
119 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
120 Use just $shortlisp, not $SOME_MACHINE_LISP too.
121
a28d4396
KH
1222011-05-18 Kenichi Handa <handa@m17n.org>
123
124 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
125 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
126 (find_automatic_composition): Mostly rewrite for efficiency.
127
a2b1fa8e
JB
1282011-05-18 Juanma Barranquero <lekktu@gmail.com>
129
130 * makefile.w32-in: Update dependencies.
131
8e1f5610
CS
1322011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
133
134 * menu.c: Include limits.h (fixes the MS-Windows build broken by
135 revision 104625).
136
7025ee00 1372011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 138
cdfa6eab
PE
139 Fix some integer overflow issues, such as string length overflow.
140
06d6db33
PE
141 * insdel.c (count_size_as_multibyte): Check for string overflow.
142
2b4560a8
PE
143 * character.c (lisp_string_width): Check for string overflow.
144 Use EMACS_INT, not int, for string indexes and lengths; in
145 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
146 the resulting string length overflows an EMACS_INT; instead,
147 report a string overflow if no precision given. When checking for
148 precision exhaustion, use a check that cannot possibly have
149 integer overflow. (Bug#8675)
150 * character.h (lisp_string_width): Adjust to new signature.
151
cb93f9be
PE
152 * alloc.c (string_overflow): New function.
153 (Fmake_string): Use it. This doesn't change behavior, but saves
154 a few bytes and will simplify future changes.
155 * character.c (string_escape_byte8): Likewise.
156 * lisp.h (string_overflow): New decl.
157
1a1f3366
PE
158 Fixups, following up to the user-interface timestamp change.
159 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
160 for UI timestamps, instead of unsigned long.
9fbd6841
PE
161 * msdos.c (mouse_get_pos): Likewise.
162 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
163 * w32gui.h (Time): Define by including "systime.h" rather than by
164 declaring it ourselves. (Bug#8664)
165
d4e3e4d3
PE
166 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
167 * image.c (clear_image_cache): Likewise.
168
f6a24d19
PE
169 * term.c (term_mouse_position): Don't assume time_t wraparound.
170
08dc5ae6
PE
171 Be more systematic about user-interface timestamps.
172 Before, the code sometimes used 'Time', sometimes 'unsigned long',
173 and sometimes 'EMACS_UINT', to represent these timestamps. This
174 change causes it to use 'Time' uniformly, as that's what X uses.
175 This makes the code easier to follow, and makes it easier to catch
176 integer overflow bugs such as Bug#8664.
177 * frame.c (Fmouse_position, Fmouse_pixel_position):
178 Use Time, not unsigned long, for user-interface timestamps.
179 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
180 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
181 * keyboard.h (last_event_timestamp): Likewise.
182 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
183 * menu.h (xmenu_show): Likewise.
184 * term.c (term_mouse_position): Likewise.
185 * termhooks.h (struct input_event.timestamp): Likewise.
186 (struct terminal.mouse_position_hook): Likewise.
187 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
188 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
189 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
190 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
191 what it was before.
192 * menu.h, termhooks.h: Include "systime.h", for Time.
193
8e55734a
PE
194 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
195 Don't assume that the difference between two unsigned long values
196 can fit into an integer. At this point, we know button_down_time
197 <= event->timestamp, so the difference must be nonnegative, so
198 there's no need to cast the result if double-click-time is
199 nonnegative, as it should be; check that it's nonnegative, just in
200 case. This bug is triggered when events are more than 2**31 ms
86db42d2 201 apart (about 25 days). (Bug#8664)
8e55734a 202
841f1b75 203 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 204 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 205
3e26f69c
PE
206 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
207 that always fit in int. Use a sentinel instead of a counter, to
208 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
209 * frame.h (struct frame): Use int for menu_bar_items_used
210 instead of EMACS_INT, since it always fits in int.
3e26f69c 211
5cc152c0
PE
212 * menu.c (grow_menu_items): Check for int overflow.
213
d89eb65e
PE
214 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
215
5235bd3e
PE
216 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
217 Before, the code was not consistent. These values cannot exceed
218 2**31 - 1 so there's no need to make them unsigned.
219 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
220 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
221 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
222 as modifiers.
223 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
224
bc827e23
PE
225 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
226 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
227 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
228 presumably because the widths might not match.
229
78eb494e
PE
230 * window.c (size_window): Avoid needless test at loop start.
231
04f2d78b
CB
2322011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
233
234 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
235
d2fc7e3d 2362011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
237
238 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
239
d2fc7e3d 2402011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
241
242 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
243 `width' to `bar_area_x' and `bar_area_width', respectively.
244 (x_scroll_run): Take account of fringe background extension.
245
04f2d78b
CB
246 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
247 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
248 `bar_area_width', respectively.
249 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
250 background extension.
251
79b70037
GM
2522011-05-10 Jim Meyering <meyering@redhat.com>
253
254 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
255
2f142cc5
JB
2562011-05-10 Juanma Barranquero <lekktu@gmail.com>
257
258 * image.c (Finit_image_library): Return t for built-in image types,
259 like pbm and xbm. (Bug#8640)
260
57679c86
AS
2612011-05-09 Andreas Schwab <schwab@linux-m68k.org>
262
263 * w32menu.c (set_frame_menubar): Fix submenu allocation.
264
888c9e86
EZ
2652011-05-07 Eli Zaretskii <eliz@gnu.org>
266
b0512a1d
EZ
267 * w32console.c (Fset_screen_color): Doc fix.
268 (Fget_screen_color): New function.
269 (syms_of_ntterm): Defsubr it.
270
7285dc67
EZ
271 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
272 unlink the temporary file if Fcall_process didn't create it in the
273 first place.
274 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
275 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
276 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
277 cue to call_process_cleanup not to close that handle.
278
4d3fcc8e
BK
2792011-05-07 Ben Key <bkey76@gmail.com>
280
281 * makefile.w32-in: The bootstrap-temacs rule now makes use of
282 one of two shell specific rules, either bootstrap-temacs-CMD or
283 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
284 to the previous implementation of the bootstrap-temacs rule.
285 The bootstrap-temacs-CMD rule is similar to the previous
286 implementation of the bootstrap-temacs rule except that it
287 makes use of the ESC_CFLAGS variable instead of the CFLAGS
288 variable.
289
290 These changes, along with some changes to nt/configure.bat,
291 nt/gmake.defs, and nt/nmake.defs, are required to extend my
292 earlier fix to add support for --cflags and --ldflags options
293 that include quotes so that it works whether make uses cmd or
294 sh as the shell.
295
b4289b64
MA
2962011-05-06 Michael Albinus <michael.albinus@gmx.de>
297
298 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
299 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
300 is a constant.
301 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
302 a string. Handle both cases.
303 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
304 (Fdbus_register_method): Use Qinvalid_function.
305
af4c0e28
JB
3062011-05-06 Juanma Barranquero <lekktu@gmail.com>
307
308 * makefile.w32-in: Update dependencies.
309 (LISP_H): Add inttypes.h and stdin.h.
310 (PROCESS_H): Add unistd.h.
311
c51453d9
EZ
3122011-05-06 Eli Zaretskii <eliz@gnu.org>
313
314 * lread.c: Include limits.h (fixes the MS-Windows build broken by
315 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
316
8ff0ac3c 3172011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 318
4c4b566b
PE
319 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
320
aab2b9b5
PE
321 * term.c (vfatal): Remove stray call to va_end.
322 It's not needed and the C Standard doesn't allow it here anyway.
323
c378da0b
PE
324 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
325 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
326
288b08c7
PE
327 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
328 bytes.
329
e3601888
PE
330 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
331
db6c0e74
PE
332 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
333
dd5963ea
PE
334 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
335
88c9450f
PE
336 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
337
2f9442b8
PE
338 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
339
c032b5f8
PE
340 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
341 * charset.c (Fdefine_charset_internal): Don't initialize
342 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 343 32-bit int (Bug#8600).
a108c10b
PE
344
345 * lread.c (read_integer): Be more consistent with string-to-number.
346 Use string_to_number to do the actual conversion; this avoids
347 rounding errors and fixes some other screwups. Without this fix,
348 for example, #x1fffffffffffffff was misread as -2305843009213693952.
349 (digit_to_number): Move earlier, for benefit of read_integer.
350 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 351 not a digit in any supported base. (Bug#8602)
a108c10b 352
ad5f9eea
PE
353 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
354
aec1708a
PE
355 * dispnew.c (scrolling_window): Return 1 if we scrolled,
356 to match comment at start of function. This also removes a
357 GCC warning about overflow in a 32+64-bit port.
358
47be4ab5
PE
359 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
360
371cac43
PE
361 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
362 Reported by Stefan Monnier in
363 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
364 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
365 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 366
d01a7826
PE
367 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
368 (EMACS_UINTPTR): Likewise, with uintptr_t.
369
7fd47d5c
PE
370 * lisp.h: Prefer 64-bit EMACS_INT if available.
371 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
372 on 32-bit hosts that have 64-bit int, so that they can access
373 large files.
122b0c86
PE
374 However, temporarily disable this change unless the temporary
375 symbol WIDE_EMACS_INT is defined.
7fd47d5c 376
8727937b
PE
377 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
378
8ac068ac
PE
379 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
380 This removes an assumption that EMACS_INT and long are the same
381 width as pointers. The assumption is true for Emacs porting targets
382 now, but we want to make other targets possible.
383 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
384 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
385 In the rest of the code, change types of integers that hold casted
386 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
387 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
388 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
389 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
390 No need to cast type when ORing.
391 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
392 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
393 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
394 assume EMACS_INT is the same width as char *.
395 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
396 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
397 Remove no-longer-needed casts.
398 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
399 (xg_tool_bar_help_callback, xg_make_tool_item):
400 Use EMACS_INTPTR to hold an integer
401 that will be cast to void *; this can avoid a GCC warning
402 if EMACS_INT is not the same width as void *.
403 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
404 * xdisp.c (display_echo_area_1, resize_mini_window_1):
405 (current_message_1, set_message_1):
406 Use a local to convert to proper width without a cast.
407 * xmenu.c (dialog_selection_callback): Likewise.
408
ede49d71
PE
409 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
410 Also, don't assume VALBITS / RAND_BITS is less than 5,
411 and don't rely on undefined behavior when shifting a 1 left into
412 the sign bit.
413 * lisp.h (get_random): Change signature to match.
414
2f30ecd0
PE
415 * lread.c (hash_string): Use size_t, not int, for hash computation.
416 Normally we prefer signed values; but hashing is special, because
417 it's better to use unsigned division on hash table sizes so that
418 the remainder is nonnegative. Also, size_t is the natural width
419 for hashing into memory. The previous code used 'int', which doesn't
420 retain enough info to hash well into very large tables.
421 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
422
2a866e7b
PE
423 * dbusbind.c: Don't possibly lose pointer info when converting.
424 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
425 Use XPNTR rather than XHASH, so that the high-order bits of
426 the pointer aren't lost when converting through void *.
427
51639eac
PE
428 * eval.c (Fautoload): Don't double-shift a pointer.
429
92394119
PE
430 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
431
dbdb9a7c
JB
4322011-05-06 Juanma Barranquero <lekktu@gmail.com>
433
434 * gnutls.c (DEF_GNUTLS_FN):
435 * image.c (DEF_IMGLIB_FN): Make function pointers static.
436
db7a0b4f
AS
4372011-05-05 Andreas Schwab <schwab@linux-m68k.org>
438
439 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
440 marker. (Bug#8610)
441
f7ff1b0f 4422011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
443
444 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
445 New version that can reserve upto 2GB of heap space.
446
f7ff1b0f 4472011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
448
449 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
450
639c109b
TZ
4512011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
452
453 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
454 `gnutls_certificate_set_x509_key_file'.
455
d2127135
JB
4562011-05-05 Juanma Barranquero <lekktu@gmail.com>
457
458 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
459 Update dependencies.
460
e968f4f3
JB
4612011-05-04 Juanma Barranquero <lekktu@gmail.com>
462
463 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
464 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
465 Remove unused parameter `fildes'.
466 * process.c (read_process_output, send_process): Don't pass it.
467
84d358f0
JB
4682011-05-04 Juanma Barranquero <lekktu@gmail.com>
469
470 Fix previous change: the library cache is defined in w32.c.
471 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
472 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
473
0898ca10
JB
4742011-05-04 Juanma Barranquero <lekktu@gmail.com>
475
476 Implement dynamic loading of GnuTLS on Windows.
477
478 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
479 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
480 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
481 Declare.
482
483 * gnutls.c (Qgnutls_dll): Define.
484 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
485 (gnutls_*): Declare function pointers.
486 (init_gnutls_functions): New function to initialize function pointers.
487 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
488 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
489 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
490 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
491 (emacs_gnutls_write, emacs_gnutls_read)
492 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
493 (Fgnutls_available_p): New function.
494 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
495 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
496 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
497
498 * image.c: Include w32.h.
499 (Vimage_type_cache): Delete.
500 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
501 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
502 (w32_delayed_load): Move to w32.c.
503
504 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
505
506 * w32.c (QCloaded_from, Vlibrary_cache): Define.
507 (w32_delayed_load): Move from image.c. When loading a library, record
508 its filename in the :loaded-from property of the library id.
509 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
510 Initialize and staticpro them.
511 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
512
513 * process.c: Include lisp.h before w32.h, not after.
514 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
515 instead of gnutls_record_check_pending.
516
517 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
518
ff4de4aa
TZ
5192011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
520
521 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
522 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
523 as passed in.
524
abe95abb
JD
5252011-05-03 Jan Djärv <jan.h.d@swipnet.se>
526
527 * xterm.c (x_set_frame_alpha): Do not set property on anything
528 else than FRAME_X_OUTER_WINDOW (Bug#8608).
529
e16e55d4
JB
5302011-05-02 Juanma Barranquero <lekktu@gmail.com>
531
532 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
533
bafcf6a5
JB
5342011-05-02 Juanma Barranquero <lekktu@gmail.com>
535
536 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
537 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
538 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
539 (gnutls_global_initialized, Qgnutls_bootprop_priority)
540 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
541 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
542 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
543 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
544 (Qgnutls_bootprop_callbacks_verify): Make static.
545
e7a6747f
AS
5462011-05-01 Andreas Schwab <schwab@linux-m68k.org>
547
19ed11ba
AS
548 * callproc.c: Indentation fixup.
549
e7a6747f 550 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
551 (wait_for_termination, interruptible_wait_for_termination):
552 Move after wait_for_termination_1.
e7a6747f 553
1ef14cb4
LMI
5542011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
555
556 * sysdep.c (interruptible_wait_for_termination): New function
557 which is like wait_for_termination, but allows keyboard
558 interruptions.
559
560 * callproc.c (Fcall_process): Add (:file "file") as an option for
561 the STDOUT buffer.
562 (Fcall_process_region): Ditto.
563
330d880c
EZ
5642011-04-30 Eli Zaretskii <eliz@gnu.org>
565
8db90b73
EZ
566 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
567 rather than `XVECTOR (FOO)->size'.
568
330d880c
EZ
569 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
570 inttypes.h, as a gnulib replacement is used if it not available in
571 system headers.
572
15cbd324
EZ
5732011-04-21 Eli Zaretskii <eliz@gnu.org>
574
575 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
576 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
577 of MOST_POSITIVE_FIXNUM. (Bug#8528)
578
579 * coding.c (coding_alloc_by_realloc): Error out if destination
580 will grow beyond MOST_POSITIVE_FIXNUM.
581 (decode_coding_emacs_mule): Abort if there isn't enough place in
582 charbuf for the composition carryover bytes. Reserve an extra
583 space for up to 2 characters produced in a loop.
584 (decode_coding_iso_2022): Abort if there isn't enough place in
585 charbuf for the composition carryover bytes.
586
5872011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 588
ae940cca
EZ
589 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
590 aborting when %lld or %lll format is passed.
591 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
592 %llo or %llx format is passed. (Bug#8545)
593
03ab8921
EZ
594 * window.c (window_scroll_line_based): Use a marker instead of
595 simple variables to record original value of point. (Bug#7952)
596
afda1437
EZ
597 * doprnt.c (doprnt): Fix the case where a multibyte sequence
598 produced by %s or %c overflows available buffer space. (Bug#8545)
599
f76dee0c
PE
6002011-04-28 Paul Eggert <eggert@cs.ucla.edu>
601
602 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 603 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 604
fdc5744d
JB
6052011-04-28 Juanma Barranquero <lekktu@gmail.com>
606
607 * w32.c (init_environment): Warn about defaulting HOME to C:\.
608
638f053a
JB
6092011-04-28 Juanma Barranquero <lekktu@gmail.com>
610
611 * keyboard.c (Qdelayed_warnings_hook): Define.
612 (command_loop_1): Run `delayed-warnings-hook'
613 if Vdelayed_warnings_list is non-nil.
614 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
615 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
616
d178f871
EZ
6172011-04-28 Eli Zaretskii <eliz@gnu.org>
618
619 * doprnt.c (doprnt): Don't return value smaller than the buffer
620 size if the message was truncated. (Bug#8545).
621
b124fd93
JB
6222011-04-28 Juanma Barranquero <lekktu@gmail.com>
623
624 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
625 (Fx_window_property): #if-0 the whole functions, not just the bodies.
626
e810457d
PE
6272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
628
629 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
630
ea51cceb
JB
6312011-04-27 Juanma Barranquero <lekktu@gmail.com>
632
633 * makefile.w32-in: Update dependencies.
634
94dcfacf
EZ
6352011-04-27 Eli Zaretskii <eliz@gnu.org>
636
637 Improve `doprnt' and its usage. (Bug#8545)
638 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
639 `format_end'. Remove support for %l as a conversion specifier.
640 Don't use xrealloc. Improve diagnostics when the %l size modifier
641 is used. Update the commentary.
642
643 * eval.c (verror): Simplify calculation of size_t.
644
645 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
646 messages.
647
f61f41d7
PE
6482011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
649
650 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
651 change.
652
96fb4434
PE
6532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
654
655 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
656 This makes this file independent of the recent pseudovector change.
657
671875da 6582011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 659
69e9b5a3
PE
660 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
661
b5f869a7 662 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 663 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 664 Remove unused local.
c8926152 665 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 666
841a1577 667 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
668 GCC 4.6.0 optimizes based on type-based alias analysis.
669 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
670 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
671 != &v->size, and therefore "v->size = 1; b->size = 2; return
672 v->size;" must therefore return 1. This assumption is incorrect
673 for Emacs, since it type-puns struct Lisp_Vector * with many other
674 types. To fix this problem, this patch adds a new type struct
f904488f 675 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
676 and pseudovectors, and helps optimizing compilers not get fooled
677 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
678 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
679 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
680 the size member.
eab3844f
PE
681 (XSETPVECTYPE): Rewrite in terms of new macro.
682 (XSETPVECTYPESIZE): New macro, specifying both type and size.
683 This is a bit clearer, and further avoids the possibility of
684 undesirable aliasing.
685 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 686 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
687 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
688 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
689 (ASIZE): Now uses header.size rather than size.
690 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
691 to avoid the hassle of writing XVECTOR (foo)->header.size.
692 (struct vectorlike_header): New type.
eab3844f
PE
693 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
694 object, to help avoid aliasing.
695 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
696 (SUBRP): Likewise, since Lisp_Subr is a special case.
697 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
698 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
699 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 700 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
701 changed to be "header.size" and "header.next".
702 * buffer.h (struct buffer): Likewise.
703 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
704 * frame.h (struct frame): Likewise.
705 * process.h (struct Lisp_Process): Likewise.
706 * termhooks.h (struct terminal): Likewise.
707 * window.c (struct save_window_data, struct saved_window): Likewise.
708 * window.h (struct window): Likewise.
709 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
710 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
711 * buffer.c (init_buffer_once): Likewise.
712 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
713 special case.
714 * process.c (Fformat_network_address): Use local var for size,
715 for brevity.
716
0df1eac5
PE
717 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
718
847ab9d1 719 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
720 * data.c (atof): Remove decl; no longer used or needed.
721 (digit_to_number): Move to lread.c.
722 (Fstring_to_number): Use new string_to_number function, to be
723 consistent with how the Lisp reader treats infinities and NaNs.
724 Do not assume that floating-point numbers represent EMACS_INT
725 without losing information; this is not true on most 64-bit hosts.
726 Avoid double-rounding errors, by insisting on integers when
727 parsing non-base-10 numbers, as the documentation specifies.
728 * lisp.h (string_to_number): New decl, replacing ...
729 (isfloat_string): Remove.
bc0a5c13 730 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 731 (read1): Do not accept +. and -. as integers; this
452f4150
PE
732 appears to have been a coding error. Similarly, do not accept
733 strings like +-1e0 as floating point numbers. Do not report
734 overflow for integer overflows unless the base is not 10 which
735 means we have no simple and reliable way to continue.
736 Break out the floating-point parsing into a new
737 function string_to_number, so that Fstring_to_number parses
738 floating point numbers consistently with the Lisp reader.
04f2d78b 739 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
740 (E_CHAR, EXP_INT): Remove, replacing with ...
741 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
742 (string_to_number): New function, replacing isfloat_string.
743 This function checks for valid syntax and produces the resulting
744 Lisp float number too. Rework it so that string-to-number
bc0a5c13 745 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
746 so that overflow for non-base-10 numbers is reported only when
747 there's no portable and simple way to convert to floating point.
452f4150 748
67769ffc
PE
749 * textprop.c (set_text_properties_1): Rewrite for clarity,
750 and to avoid GCC warning about integer overflow.
751
c20db43f
PE
752 * intervals.h (struct interval): Use EMACS_INT for members
753 where EMACS_UINT might cause problems. See
754 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
755 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
756 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
757 All uses changed.
37aa2f85
PE
758 (offset_intervals): Tell GCC not to worry about length overflow
759 when negating a negative length.
c20db43f 760
2538aa2f
PE
761 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
762 (overrun_check_free): Likewise.
763
f2d3008d
PE
764 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
765 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
766 word size.
767
ec8df744
PE
768 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
769 (gnutls_make_error): Rename local to avoid shadowing.
770 (gnutls_emacs_global_deinit): ifdef out; not used.
771 (Fgnutls_boot): Use const for pointer to readonly storage.
772 Comment out unused local. Fix pointer signedness problems.
773
640ee02d
PE
774 * lread.c (openp): Don't stuff size_t into an 'int'.
775 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
776 about possible signed overflow.
777
6048fb2a
PE
778 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
779 (GDK_KEY_g): Don't define if already defined.
780 (xg_prepare_tooltip): Avoid pointer signedness problem.
781 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
782
fa3c87e1
PE
783 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
784 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
785
2172544b
PE
786 * xfns.c (Fx_window_property): Simplify a bit,
787 to make a bit faster and to avoid GCC 4.6.0 warning.
788 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
789
9b821a21
PE
790 * fns.c (internal_equal): Don't assume size_t fits in int.
791
3c616cfa
PE
792 * alloc.c (compact_small_strings): Tighten assertion a little.
793
c2982e87
PE
794 Replace pEd with more-general pI, and fix some printf arg casts.
795 * lisp.h (pI): New macro, generalizing old pEd macro to other
796 conversion specifiers. For example, use "...%"pI"d..." rather
797 than "...%"pEd"...".
798 (pEd): Remove. All uses replaced with similar uses of pI.
799 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
800 * alloc.c (check_pure_size): Don't overflow by converting size to int.
801 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
802 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
803 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
804 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
805 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
806 64-bit hosts.
807 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
808 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
809 * print.c (safe_debug_print, print_object): Likewise.
810 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
811 to int.
6f04d126
PE
812 Use pI instead of if-then-else-abort. Use %p to avoid casts,
813 avoiding the 0 flag, which is not portable.
c2982e87
PE
814 * process.c (Fmake_network_process): Use pI to avoid cast.
815 * region-cache.c (pp_cache): Likewise.
816 * xdisp.c (decode_mode_spec): Likewise.
817 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
818 behavior on 64-bit hosts with printf arg.
6f04d126 819 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
820 (x_stop_queuing_selection_requests): Likewise.
821 (x_get_window_property): Don't truncate byte count to an 'int'
822 when tracing.
0b432f21 823
5e073ec7
PE
824 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
825 here, since it parses constructs like leading '-' and spaces,
826 which are not wanted; and it overflows with large numbers.
827 Instead, simply match F[0-9]+, which is what is wanted anyway.
828
36372bf9
PE
829 * alloc.c: Remove unportable assumptions about struct layout.
830 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
831 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
832 (allocate_vectorlike, make_pure_vector): Use the new macros,
833 plus offsetof, to remove unportable assumptions about struct layout.
834 These assumptions hold on all porting targets that I know of, but
835 they are not guaranteed, they're easy to remove, and removing them
836 makes further changes easier.
837
0b432f21
PE
838 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
839 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
840 (string_overrun_cookie): Now const. Use initializers that
841 don't formally overflow signed char, to avoid warnings.
000098c1
PE
842 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
843 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
844 (allocate_buffer): Don't assume sizeof (struct buffer) is a
845 multiple of sizeof (EMACS_INT); it need not be, if
846 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 847 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 848
895009e1
JB
8492011-04-26 Juanma Barranquero <lekktu@gmail.com>
850
851 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
852
6a7a1b0b
TZ
8532011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
854
855 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 856 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
857 Reported by Paul Eggert <eggert@cs.ucla.edu>.
858
841a1577 8592011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
860
861 * lisp.h (Qdebug): List symbol.
895009e1 862 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
863 * keyboard.c (debug-on-event): New variable.
864 (handle_user_signal): Break into debugger when debug-on-event
865 matches the current signal symbol.
866
f2d3ba6f
DN
8672011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
868
869 * alloc.c (check_sblock, check_string_bytes)
870 (check_string_free_list): Convert to standard C.
871
42ce4c63
TZ
8722011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
873
874 * w32.c (emacs_gnutls_push): Fix typo.
875
825cd63c
EZ
8762011-04-25 Eli Zaretskii <eliz@gnu.org>
877
fb11d64d
EZ
878 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
879 "cast to pointer from integer of different size".
880
825cd63c
EZ
881 Improve doprnt and its use in verror. (Bug#8545)
882 * doprnt.c (doprnt): Document the set of format control sequences
883 supported by the function. Use SAFE_ALLOCA instead of always
884 using `alloca'.
885
886 * eval.c (verror): Don't limit the buffer size at size_max-1, that
887 is one byte too soon. Don't use xrealloc; instead xfree and
888 xmalloc anew.
889
e061a11b
TZ
8902011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
891
892 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
893 callbacks stage.
894
895 * gnutls.c: Renamed global_initialized to
896 gnutls_global_initialized. Added internals for the
897 :verify-hostname-error, :verify-error, and :verify-flags
898 parameters of `gnutls-boot' and documented those parameters in the
899 docstring. Start callback support.
900 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
901 unless a fatal error occured. Call gnutls_alert_send_appropriate
902 on error. Return error code.
903 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
904 (emacs_gnutls_read): Likewise.
905 (Fgnutls_boot): Return handshake error code.
906 (emacs_gnutls_handle_error): New function.
907 (wsaerror_to_errno): Likewise.
908
909 * w32.h (emacs_gnutls_pull): Add prototype.
910 (emacs_gnutls_push): Likewise.
911
912 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
913 (emacs_gnutls_push): Likewise.
914
9152011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
916
917 * process.c (wait_reading_process_output): Check if GnuTLS
918 buffered some data internally if no FDs are set for TLS
919 connections.
920
921 * makefile.w32-in (OBJ2): Add gnutls.$(O).
922 (LIBS): Link to USER_LIBS.
923 ($(BLD)/gnutls.$(0)): New target.
924
fa6996bc
EZ
9252011-04-24 Eli Zaretskii <eliz@gnu.org>
926
eb35682e
EZ
927 * xdisp.c (handle_single_display_spec): Rename the
928 display_replaced_before_p argument into display_replaced_p, to
929 make it consistent with the commentary. Fix typos in the
930 commentary.
931
e2ad650c
EZ
932 * textprop.c (syms_of_textprop): Remove dead code.
933 (copy_text_properties): Delete obsolete commentary about an
934 interface that was deleted long ago. Fix typos in the description
935 of arguments.
936
1b2de274
EZ
937 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
938 to changes in oldXMenu/XMenu.h from 2011-04-16.
939 <menu_help_message, prev_menu_help_message>: Constify.
940 (IT_menu_make_room): menu->help_text is now `const char **';
941 adjust.
942
943 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
944 to changes in oldXMenu/XMenu.h from 2011-04-16.
945 (struct XMenu): Declare `help_text' `const char **'.
946
947 * xfaces.c <Qunspecified>: Make extern again.
948
949 * syntax.c: Include sys/types.h before including regex.h, as
950 required by Posix.
951
762b15be
EZ
952 * doc.c (get_doc_string): Improve the format passed to `error'.
953
954 * doprnt.c (doprnt): Improve commentary.
955
956 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
957
958 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
959 them with etags.
960
f1052e5d
EZ
961 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
962 changes in globals.h immediately force recompilation.
762b15be
EZ
963 (TAGS): Depend on $(CURDIR)/m/intel386.h and
964 $(CURDIR)/s/ms-w32.h.
965 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 966
fa6996bc
EZ
967 * character.c (Fchar_direction): Function deleted.
968 (syms_of_character): Don't defsubr it.
969 <char-direction-table>: Deleted.
970
e6c3da20
EZ
9712011-04-23 Eli Zaretskii <eliz@gnu.org>
972
973 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
974 * doprnt.c: Include limits.h.
975 (SIZE_MAX): New macro.
04f2d78b
CB
976 (doprnt): Return a size_t value. 2nd arg is now size_t.
977 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
978 Improve overflow protection. Support `l' modifier for integer
979 conversions. Support %l conversion. Don't assume an EMACS_INT
980 argument for integer conversions and for %c.
981
982 * lisp.h (doprnt): Restore prototype.
983
984 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
985 $(SRC)/character.h.
986
987 * Makefile.in (base_obj): Add back doprnt.o.
988
989 * deps.mk (doprnt.o): Add back prerequisites.
990 (callint.o): Depend on character.h.
991
992 * eval.c (internal_lisp_condition_case): Include the handler
993 representation in the error message.
994 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
995 when breaking from the loop.
996
997 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
998
999 * callint.c (Fcall_interactively): When displaying error message
1000 about invalid control letter, pass the character's codepoint, not
1001 a pointer to its multibyte form. Improve display of the character
1002 in octal and display also its hex code.
1003
1004 * character.c (char_string): Use %x to display the (unsigned)
1005 codepoint of an invalid character, to avoid displaying a bogus
1006 negative value.
1007
1008 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1009 `error', not SYMBOL_NAME itself.
1010
1011 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1012 character arguments to `error'.
1013
1014 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1015 to `error' in error message about FINAL_CHAR argument. Make sure
1016 FINAL_CHAR is a character, and use %c when it is passed as
1017 argument to `error'.
1018
4ffd0d6b 10192011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1020
1021 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1022
1023 * w32.c: Include <time.h>.
1024 (sys_localtime): New function.
1025
4ffd0d6b 10262011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1027
1028 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1029
4ffd0d6b 1030 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1031
4ffd0d6b 10322011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1033
4ffd0d6b
GM
1034 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1035 zombies (Bug#8467).
aac0c6e3 1036
04c56954
EZ
10372011-04-19 Eli Zaretskii <eliz@gnu.org>
1038
1039 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1040 gl_state.e_property when gl_state.object is Qt.
1041
1042 * insdel.c (make_gap_larger): Remove limitation of buffer size
1043 to <= INT_MAX.
1044
16a43933
CY
10452011-04-18 Chong Yidong <cyd@stupidchicken.com>
1046
1047 * xdisp.c (lookup_glyphless_char_display)
1048 (produce_glyphless_glyph): Handle cons cell entry in
1049 glyphless-char-display.
1050 (Vglyphless_char_display): Document it.
1051
1052 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1053 glyphless-char-display.
1054
4581706e
CY
10552011-04-17 Chong Yidong <cyd@stupidchicken.com>
1056
1057 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1058
1059 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1060
1061 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1062 definition for no-X builds.
1063
4887c6e2 10642011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1065
fd35b6f9
PE
1066 Static checks with GCC 4.6.0 and non-default toolkits.
1067
5c1ccb01
PE
1068 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1069
006c5daa
PE
1070 * process.c (keyboard_bit_set): Define only if SIGIO.
1071 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1072 (send_process): Repair possible setjmp clobbering.
1073
efc736d3
PE
1074 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1075
4e2fe2e6
PE
1076 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1077
f97334a2
PE
1078 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1079
4e75f29d
PE
1080 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1081 Define only if needed.
1082
90efadd1
PE
1083 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1084 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1085 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1086
3c647824
PE
1087 * dispextern.h (struct redisplay_interface): Rename param
1088 to avoid shadowing.
e264f262 1089 * termhooks.h (struct terminal): Likewise.
761383f4 1090 * xterm.c (xembed_send_message): Likewise.
3c647824 1091
b58c5c4a
PE
1092 * insdel.c (make_gap_smaller): Define only if
1093 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1094
cad59032
PE
1095 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1096 it.
1097
c339dc2e
PE
1098 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1099 so that we aren't warned about unused symbols.
1100
91a3e27b
PE
1101 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1102
399c71d3 1103 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1104
8ffc96f5
PE
1105 * xfns.c (x_real_positions): Mark locals as initialized.
1106
eef9bc79
PE
1107 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1108
098db9dd
PE
1109 * xterm.c: Fix problems found by static analysis with other toolkits.
1110 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1111 (x_dispatch_event): Declare static if USE_GTK, and
1112 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1113 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1114 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1115 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1116 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1117
eb18f6cc
PE
1118 * xmenu.c (menu_help_callback): Pointer type fixes.
1119 Use const pointers when pointing at readonly data. Avoid pointer
1120 signedness clashes.
1121 (FALSE): Remove unused macro.
1122 (update_frame_menubar): Remove unused decl.
1123
1fe72bf8
PE
1124 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1125
60d9e1db
PE
1126 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1127 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1128 (single_menu_item): Rename local to avoid shadowing.
1129
39261c26
PE
1130 * keyboard.c (make_lispy_event): Remove unused local var.
1131
018c5e19
PE
1132 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1133 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1134
63d2b86e
PE
1135 * bitmaps: Change bitmaps from unsigned char back to the X11
1136 compatible char. Avoid the old compiler warnings about
1137 out-of-range initializers by using, for example, '\xab' rather
1138 than 0xab.
1139
aefd87e1
PE
1140 * xgselect.c (xgselect_initialize): Check vs interface
1141 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1142
bf501fb9
PE
1143 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1144
e9829fdf
PE
1145 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1146 to read-only memory.
1147
1086c095
PE
1148 * fns.c (vector): Remove; this old hack is no longer needed.
1149
2baccd04 1150 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1151 Remove unused var.
dde42981 1152 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1153
72391843 1154 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1155
436c16df 1156 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1157 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1158 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1159
92bb796d 1160 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1161 (x_term_init): Remove local to avoid shadowing.
92bb796d 1162
764430a3 1163 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1164
1165 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1166 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1167
d1dfb56c
EZ
11682011-04-16 Eli Zaretskii <eliz@gnu.org>
1169
c4354cb4
EZ
1170 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1171
d1dfb56c
EZ
1172 Fix regex.c, syntax.c and friends for buffers > 2GB.
1173 * syntax.h (struct gl_state_s): Declare character position members
1174 EMACS_INT.
1175
1176 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1177
04f2d78b
CB
1178 * textprop.c (verify_interval_modification, interval_of):
1179 Declare arguments EMACS_INT.
d1dfb56c
EZ
1180
1181 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1182 EMACS_INT.
1183
1184 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1185
1186 * indent.c (Fvertical_motion): Local variable it_start is now
1187 EMACS_INT.
1188
1189 * regex.c (re_match, re_match_2, re_match_2_internal)
1190 (bcmp_translate, regcomp, regexec, print_double_string)
1191 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1192 (re_compile_pattern, re_exec): Declare arguments and local
1193 variables `size_t' and `ssize_t' and return values `regoff_t', as
1194 appropriate.
1195 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1196 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1197 <compile_stack_type>: `size' and `avail' are now `size_t'.
1198
1199 * regex.h <regoff_t>: Use ssize_t, not int.
1200 (re_search, re_search_2, re_match, re_match_2): Arguments that
1201 specify buffer/string position and length are now ssize_t and
1202 size_t. Return type is regoff_t.
1203
613052cd
BK
12042011-04-16 Ben Key <bkey76@gmail.com>
1205
1206 * nsfont.m: Fixed bugs in ns_get_family and
1207 ns_descriptor_to_entity that were caused by using free to
1208 deallocate memory blocks that were allocated by xmalloc (via
1209 xstrdup). This caused Emacs to crash when compiled with
1210 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1211 --enable-checking=xmallocoverrun). xfree is now used to
1212 deallocate these memory blocks.
1213
4170f62f 12142011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1215
71b41406
PE
1216 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1217
9587a89d
PE
1218 emacs_write: Accept and return EMACS_INT for sizes.
1219 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1220 et seq.
1221 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1222 Accept and return EMACS_INT.
1223 (emacs_gnutls_write): Return the number of bytes written on
1224 partial writes.
1225 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1226 (emacs_read, emacs_write): Remove check for negative size, as the
1227 Emacs source code has been audited now.
9587a89d
PE
1228 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1229 (emacs_read, emacs_write): Use it.
273a5f82
PE
1230 * process.c (send_process): Adjust to the new signatures of
1231 emacs_write and emacs_gnutls_write. Do not attempt to store
1232 a byte offset into an 'int'; it might overflow.
9587a89d 1233 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1234
3e047f51
PE
1235 * sound.c: Don't assume sizes fit in 'int'.
1236 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1237 Return EMACS_INT, not int.
3e047f51 1238 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1239 Accept EMACS_INT, not int.
1240 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1241 record read return values.
1242
cc39a9db
BK
12432011-04-15 Ben Key <bkey76@gmail.com>
1244
c9d0ec6d
JB
1245 * keyboard.c (Qundefined): Don't declare static since it is used
1246 in nsfns.m.
1247 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1248 static since they are used in nsfont.m.
cc39a9db 1249
6c60eb9f
SM
12502011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1251
1252 * process.c (Qprocessp): Don't declare static.
1253 * lisp.h (Qprocessp): Declare again.
1254
7990b61a
JB
12552011-04-15 Juanma Barranquero <lekktu@gmail.com>
1256
1257 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1258
5d4cb038
PE
12592011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1260
8bd7b830 1261 Improve C-level modularity by making more things 'static'.
cd64ea1d 1262
e3b27b31
PE
1263 Don't publish debugger-only interfaces to other modules.
1264 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1265 (verify_bytepos, count_markers): Move decls to the only modules
1266 that need them.
1267 * region-cache.h (pp_cache): Likewise.
1268 * window.h (check_all_windows): Likewise.
1269 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1270
5d4cb038
PE
1271 * sysdep.c (croak): Now static, if
1272 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1273 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1274
1275 * alloc.c (refill_memory_reserve): Now static if
1276 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1277 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1278
e87b6180
PE
1279 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1280 Define only if USE_LUCID.
1281
ac64929e
PE
1282 * xrdb.c (x_customization_string, x_rm_string): Now static.
1283
6f37259d
PE
1284 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1285 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1286
1683e3ab
PE
1287 * xdisp.c (draw_row_with_mouse_face): Now static.
1288 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1289
de9c2632
PE
1290 * window.h (check_all_windows): Mark externally visible.
1291
2b96acb7
PE
1292 * window.c (window_deletion_count): Now static.
1293
1294 * undo.c: Make symbols static if they're not exported.
1295 (last_undo_buffer, last_boundary_position, pending_boundary):
1296 Now static.
1297
50436f33
PE
1298 * textprop.c (interval_insert_behind_hooks): Now static.
1299 (interval_insert_in_front_hooks): Likewise.
1300
64520e5c
PE
1301 * term.c: Make symbols static if they're not exported.
1302 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1303 (max_frame_lines, tty_set_terminal_modes):
1304 (tty_reset_terminal_modes, tty_turn_off_highlight):
1305 (get_tty_terminal): Now static.
1306 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1307 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1308 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1309 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1310 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1311
1fa53021
PE
1312 * sysdep.c: Make symbols static if they're not exported.
1313 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1314 Now static.
1315 (sigprocmask_set, full_mask): Remove; unused.
1316 (wait_debugging): Mark as visible.
1317 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1318 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1319
d4b43b22
PE
1320 * syntax.c (syntax_temp): Define only if !__GNUC__.
1321
b7c513d0
PE
1322 * sound.c (current_sound_device, current_sound): Now static.
1323
989b29ad
PE
1324 * search.c (searchbufs, searchbuf_head): Now static.
1325
13a55a78
PE
1326 * scroll.c (scroll_cost): Remove; unused.
1327 * dispextern.h (scroll_cost): Remove decl.
1328
de68a1fc
PE
1329 * region-cache.h (pp_cache): Mark as externally visible.
1330
40ccffa6
PE
1331 * process.c: Make symbols static if they're not exported.
1332 (process_tick, update_tick, create_process, chan_process):
1333 (Vprocess_alist, proc_buffered_char, datagram_access):
1334 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1335 (deactivate_process): Mark defn as static, as well as decl.
1336 * lisp.h (create_process): Remove decl.
1337 * process.h (chan_process, Vprocess_alist): Remove decls.
1338
ad64fc97
PE
1339 * print.c: Make symbols static if they're not exported.
1340 (print_depth, new_backquote_output, being_printed, print_buffer):
1341 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1342 (print_interval, print_number_index, initial_stderr_stream):
1343 Now static.
1344 * lisp.h (Fprinc): Remove decl.
1345 (debug_output_compilation_hack): Mark as externally visible.
1346
adddb265
PE
1347 * sysdep.c (croak): Move decl from here to syssignal.h.
1348 * syssignal.h (croak): Put it here, so the API can be checked when
1349 'croak' is called from dissociate_if_controlling_tty.
1350
1717ede2
PE
1351 * minibuf.c: Make symbols static if they're not exported.
1352 (minibuf_save_list, choose_minibuf_frame): Now static.
1353 * lisp.h (choose_minibuf_frame): Remove decl.
1354
fa5fb2bc
PE
1355 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1356
1e3890d1
PE
1357 * lread.c: Make symbols static if they're not exported.
1358 (read_objects, initial_obarray, oblookup_last_bucket_number):
1359 Now static.
1360 (make_symbol): Remove; unused.
1361 * lisp.h (initial_obarray, make_symbol): Remove decls.
1362
8a1414fa
PE
1363 * keyboard.c: Make symbols static if they're not exported.
1364 (single_kboard, recent_keys_index, total_keys, recent_keys):
1365 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1366 (this_single_command_key_start, echoing, last_auto_save):
1367 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1368 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1369 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1370 (Vlispy_mouse_stem, double_click_count):
1371 Now static.
1372 (force_auto_save_soon): Define only if SIGDANGER.
1373 (ignore_mouse_drag_p): Now static if
1374 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1375 (print_help): Remove; unused.
1376 (stop_character, last_timer_event): Mark as externally visible.
1377 * keyboard.h (ignore_mouse_drag_p): Declare only if
1378 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1379 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1380 * lisp.h (echoing): Remove decl.
1381 (force_auto_save_soon): Declare only if SIGDANGER.
1382 * xdisp.c (redisplay_window): Simplify code, to make it more
1383 obvious that ignore_mouse_drag_p is not accessed if !defined
1384 USE_GTK && !defined HAVE_NS.
1385
93ea6e8f
PE
1386 * intervals.c: Make symbols static if they're not exported.
1387 (merge_properties_sticky, merge_interval_right, delete_interval):
1388 Now static.
1389 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1390
77382fcc
PE
1391 * insdel.c: Make symbols static if they're not exported.
1392 However, leave prepare_to_modify_buffer alone. It's never
1393 called from outside this function, but that appears to be a bug.
1394 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1395 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1396 (adjust_after_replace_noundo): Remove; unused.
1397 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1398 (signal_before_change): Remove decls.
77382fcc 1399
9306c32e
PE
1400 * indent.c (val_compute_motion, val_vmotion): Now static.
1401
cd44d2eb
PE
1402 * image.c: Make symbols static if they're not exported.
1403 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1404 if USE_GTK.
1405 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1406 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1407
ad9a7a06
PE
1408 * fringe.c (standard_bitmaps): Now static.
1409 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1410
81626931
PE
1411 * frame.c: Make symbols static if they're not exported.
1412 (x_report_frame_params, make_terminal_frame): Now static.
1413 (get_frame_param): Now static, unless HAVE_NS.
1414 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1415 (x_get_resource_string): Remove; not used.
1416 * frame.h (make_terminal_frame, x_report_frame_params):
1417 (x_get_resource_string); Remove decls.
1418 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1419 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1420
239f9db9
PE
1421 * font.c, fontset.c: Make symbols static if they're not exported.
1422 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1423 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1424 * font.c (font_close_object): Now static.
1425 * font.h (font_close_object): Remove.
1426 * fontset.c (FONTSET_OBJLIST): Remove.
1427 (free_realized_fontset) #if-0 the body, which does nothing.
1428 (face_suitable_for_char_p): #if-0, as it's never called.
1429 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1430 * xfaces.c (face_at_string_position):
1431 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1432 since 0 is always ASCII.
1433
dfcf3579
PE
1434 * fns.c (weak_hash_tables): Now static.
1435
5045092b
PE
1436 * fileio.c: Make symbols static if they're not exported.
1437 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1438 (Vwrite_region_annotation_buffers): Now static.
1439
57a96f5c
PE
1440 * eval.c: Make symbols static if they're not exported.
1441 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1442 * lisp.h (backtrace_list): Remove decl.
1443
35f08c38
PE
1444 * emacs.c: Make symbols static if they're not exported.
1445 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1446 (fatal_error_code, fatal_error_signal_hook, standard_args):
1447 Now static.
1448 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1449 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1450 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1451 * lisp.h (fatal_error_signal_hook): Remove decl.
1452 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1453
f44bd759
PE
1454 * editfns.c: Move a (normally-unused) function to its only use.
1455 * editfns.c, lisp.h (get_operating_system_release): Remove.
1456 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1457 worth the hassle of breaking this out.
1458
b532497d
PE
1459 * xterm.c: Make symbols static if they're not exported.
1460 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1461 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1462 (x_destroy_window, x_delete_display):
1463 Now static.
1464 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1465 (x_mouse_leave): Remove; unused.
1466 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1467 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1468 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1469 Remove decls.
1470 (x_mouse_leave): Declare only if WINDOWSNT.
1471 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1472 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1473 USE_X_TOOLKIT.
1474
1675728f
PE
1475 * ftxfont.c: Make symbols static if they're not exported.
1476 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1477 HAVE_FREETYPE.
1478 * font.h (ftxfont_driver): Likewise.
1479
e4cebfca
PE
1480 * xfns.c: Make symbols static if they're not exported.
1481 (x_last_font_name, x_display_info_for_name):
1482 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1483 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1484 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1485 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1486 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1487 (last_show_tip_args): Now static.
1488 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1489 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1490 (x_screen_planes): Remove; unused.
1491 * dispextern.h (x_screen_planes): Remove decl.
1492
5bf46f05
PE
1493 * dispnew.c: Make symbols static if they're not exported.
1494 * dispextern.h (redraw_garbaged_frames, scrolling):
1495 (increment_row_positions): Remove.
1496 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1497 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1498 Now static.
1499 (redraw_garbaged_frames): Remove; unused.
1500
435f4c28
PE
1501 * xfaces.c: Make symbols static if they're not exported.
1502 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1503 Remove decls.
1504 * xterm.h (defined_color): Remove decls.
1505 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1506 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1507 (menu_face_changed_default, defined_color, free_realized_face):
1508 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1509 (ascii_face_of_lisp_face): Remove; unused.
1510
8524aef3
PE
1511 * xdisp.c: Make symbols static if they're not exported.
1512 * dispextern.h (scratch_glyph_row, window_box_edges):
1513 (glyph_to_pixel_coords, set_cursor_from_row):
1514 (get_next_display_element, set_iterator_to_next):
1515 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1516 (show_mouse_face): Remove decls
1517 * frame.h (message_buf_print): Likewise.
1518 * lisp.h (pop_message, set_message, check_point_in_composition):
1519 Likewise.
1520 * xterm.h (set_vertical_scroll_bar): Likewise.
1521 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1522 (message_buf_print, scratch_glyph_row, displayed_buffer):
1523 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1524 (get_next_display_element, show_mouse_face, window_box_edges):
1525 (frame_to_window_pixel_xy, check_point_in_composition):
1526 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1527 (glyph_to_pixel_coords): Remove; unused.
1528
16390cd2
PE
1529 * dired.c (file_name_completion): Now static.
1530
1531 * dbusbind.c (xd_in_read_queued_messages): Now static.
1532
a25f4dfa
PE
1533 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1534 * data.c (circular_list_error): Remove.
1535
14a9c8df
PE
1536 * commands.h (last_point_position, last_point_position_buffer):
1537 (last_point_position_window): Remove decls.
1538 * keyboard.c: Make these variables static.
1539
04f2d78b
CB
1540 * coding.h (coding, code_convert_region, encode_coding_gap):
1541 Remove decls.
74ab6df5
PE
1542 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1543 (iso_code_class, detect_coding, code_convert_region): Now static.
1544 (encode_coding_gap): Remove; unused.
1545
38dfbee1
PE
1546 * chartab.c (chartab_chars, chartab_bits): Now static.
1547
a2cb4e63
PE
1548 * charset.h (charset_iso_8859_1): Remove decl.
1549 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1550 Now static.
1551
127198fd
PE
1552 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1553 * ccl.c (Vccl_program_table): Now static.
1554 (check_ccl_update): Remove; unused.
1555
d85b608f
PE
1556 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1557 * category.h: ... from here.
1558 * category.c (check_category_table, set_category_set): Now static.
1559
31cd66f3
PE
1560 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1561 * lisp.h: Remove these decls.
1562
c358e587
PE
1563 * buffer.c (buffer_count): Remove unused var.
1564
e78aecca
PE
1565 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1566 so that it's not optimized away.
1567 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1568 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1569 exported only to the debugger.
1570
e192d7d3 1571 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1572 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1573
92470028
PE
1574 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1575 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1576 was inaccessible from Lisp.
1577 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1578 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1579
244ed907
PE
1580 alloc.c: Import and export fewer symbols, and remove unused items.
1581 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1582 is defined.
1583 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1584 it's not optimized away by whole-program optimization.
1585 (message_enable_multibyte, free_misc): Remove.
1586 (catchlist, handlerlist, mark_backtrace):
1587 Declare only if BYTE_MARK_STACK.
1588 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1589 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1590 (message_enable_multibyte): Remove decl.
1591 (free_misc, interval_free_list, float_block, float_block_index):
1592 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1593 (cons_free_list, last_marked_index):
1594 Now static.
1595 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1596 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1597 (mark_backtrace): Define only if BYTE_MARK_STACK.
1598 * xdisp.c (message_enable_multibyte): Now static.
1599
61c2b50e 1600 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1601 This makes it easier for human readers (and static analyzers)
1602 to see whether these variables are used from other modules.
1603 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1604 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1605 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1606 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1607 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1608 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1609 * xmenu.c, xselect.c:
1610 Declare Q* vars static if they are not used in other modules.
1611 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1612 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1613 Remove decls of unexported vars.
1614 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1615
95c82688
PE
1616 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1617
16a97296
PE
1618 Make Emacs functions such as Fatom 'static' by default.
1619 This makes it easier for human readers (and static analyzers)
1620 to see whether these functions can be called from other modules.
1621 DEFUN now defines a static function. To make the function external
1622 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1623 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1624 (Finit_image_library):
16a97296
PE
1625 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1626 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1627 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1628 Remove decls, since these functions are now static.
1629 (Funintern, Fget_internal_run_time): New decls, since these functions
1630 were already external.
95c82688 1631
16a97296
PE
1632 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1633 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1634 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1635 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1636 * keyboard.c, keymap.c, lread.c:
1637 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1638 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1639 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1640 Mark functions with DEFUE instead of DEFUN,
1641 if they are used in other modules.
1642 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1643 decls for now-static functions.
1644 * buffer.h (Fdelete_overlay): Remove decl.
1645 * callproc.c (Fgetenv_internal): Mark as internal.
1646 * composite.c (Fremove_list_of_text_properties): Remove decl.
1647 (Fcomposition_get_gstring): New forward static decl.
1648 * composite.h (Fcomposite_get_gstring): Remove decl.
1649 * dired.c (Ffile_attributes): New forward static decl.
1650 * doc.c (Fdocumntation_property): New forward static decl.
1651 * eval.c (Ffetch_bytecode): New forward static decl.
1652 (Funintern): Remove extern decl; now in .h file where it belongs.
1653 * fileio.c (Fmake_symbolic_link): New forward static decl.
1654 * image.c (Finit_image_library): New forward static decl.
1655 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1656 * intervals.h (Fprevious_property_change):
1657 (Fremove_list_of_text_properties): Remove decls.
1658 * keyboard.c (Fthis_command_keys): Remove decl.
1659 (Fcommand_execute): New forward static decl.
1660 * keymap.c (Flookup_key): New forward static decl.
1661 (Fcopy_keymap): Now static.
1662 * keymap.h (Flookup_key): Remove decl.
1663 * process.c (Fget_process): New forward static decl.
1664 (Fprocess_datagram_address): Mark as internal.
1665 * syntax.c (Fsyntax_table_p): New forward static decl.
1666 (skip_chars): Remove duplicate decl.
1667 * textprop.c (Fprevious_property_change): New forward static decl.
1668 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1669 Now internal.
1670 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1671 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1672
785bbd42
PE
1673 * editfns.c (Fformat): Remove unreachable code.
1674
8b913b57
AS
16752011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1676
1677 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1678 change. (Bug#8496)
1679
a6744a35
EZ
16802011-04-13 Eli Zaretskii <eliz@gnu.org>
1681
1682 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1683 when at ZV. (Bug#8487)
1684
e7974947
AS
16852011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1686
baad03f0
AS
1687 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1688 (Bug#8437)
1689 * keyboard.c (parse_tool_bar_item): Likewise.
1690 * sound.c (sound_cleanup, alsa_close): Likewise.
1691 * termcap.c (tgetent): Likewise.
1692 * xfns.c (x_default_font_parameter): Likewise.
1693 * xsettings.c (read_and_apply_settings): Likewise.
1694
e7974947
AS
1695 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1696 (overrun_check_free): Protoize.
1697
28272684
PE
16982011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1699
1700 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1701 since callers should never pass a negative size.
1702 Change the signature to match that of plain 'read' and 'write'; see
1703 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1704 * lisp.h: Update prototypes of emacs_write and emacs_read.
1705
11997c76
EZ
17062011-04-11 Eli Zaretskii <eliz@gnu.org>
1707
1708 * xdisp.c (redisplay_window): Don't try to determine the character
1709 position of the scroll margin if the window start point w->startp
e896f03c 1710 is outside the buffer's accessible region. (Bug#8468)
11997c76 1711
8a2cbd72
EZ
17122011-04-10 Eli Zaretskii <eliz@gnu.org>
1713
1714 Fix write-region and its subroutines for buffers > 2GB.
1715 * fileio.c (a_write, e_write): Modify declaration of arguments and
1716 local variables to support buffers larger than 2GB.
1717 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1718
1719 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1720 argument, local variables, and return value.
1721
1722 * lisp.h: Update prototypes of emacs_write and emacs_read.
1723
1724 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1725
4073e537 17262011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1727
1ebfdcb6
PE
1728 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1729
b2ded58d
PE
1730 Fix more problems found by GCC 4.6.0's static checks.
1731
7d66342c
PE
1732 * xdisp.c (vmessage): Use a better test for character truncation.
1733
bbf47d44
PE
1734 * charset.c (load_charset_map): <, not <=, for optimization,
1735 and to avoid potential problems with integer overflow.
9248994d 1736 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1737 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1738 * editfns.c (Fformat): Likewise.
1e69125e 1739 * syntax.c (skip_chars): Likewise.
3befa583 1740
e3019616
PE
1741 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1742 This also lets GCC 4.6.0 generate slightly better loop code.
1743
becfa255
PE
1744 * callint.c (Fcall_interactively): <, not <=, for optimization.
1745 (Fcall_interactively): Count the number of arguments produced,
1746 not the number of arguments given. This is simpler and lets GCC
1747 4.6.0 generate slightly better code.
1748
dae0cd48
PE
1749 * ftfont.c: Distingish more carefully between FcChar8 and char.
1750 The previous code passed unsigned char * to a functions like
1751 strlen and xstrcasecmp that expect char *, which does not
1752 conform to the C standard.
1753 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1754 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1755 char * when the C standard requires it.
1756
76032d70
PE
1757 * keyboard.c (read_char): Remove unused var.
1758
eb3f1cc8
PE
1759 * eval.c: Port to Windows vsnprintf (Bug#8435).
1760 Include <limits.h>.
1761 (SIZE_MAX): Define if the headers do not.
1762 (verror): Do not give up if vsnprintf returns a negative count.
1763 Instead, grow the buffer. This ports to Windows vsnprintf, which
1764 does not conform to C99. Problem reported by Eli Zaretskii.
1765 Also, simplify the allocation scheme, by avoiding the need for
1766 calling realloc, and removing the ALLOCATED variable.
1767
70476b54
PE
1768 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1769
12020a9e
PE
1770 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1771 But keep the doprint source code for now, as we might revamp it
1772 and use it again (Bug#8435).
ea6c7ae6
PE
1773 * lisp.h (doprnt): Remove.
1774 * Makefile.in (base_obj): Remove doprnt.o.
1775 * deps.mk (doprnt.o): Remove.
1776
5fdb398c
PE
1777 error: Print 32- and 64-bit integers portably (Bug#8435).
1778 Without this change, on typical 64-bit hosts error ("...%d...", N)
1779 was used to print both 32- and 64-bit integers N, which relied on
1780 undefined behavior.
1781 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1782 New macro.
1783 * lisp.h (error, verror): Mark as printf-like functions.
1784 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1785 Report overflow in size calculations when allocating printf buffer.
1786 Do not truncate output string at its first null byte.
1787 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1788 Truncate the output at a character boundary, since vsnprintf does not
1789 do that.
1790 * charset.c (check_iso_charset_parameter): Convert internal
1791 character to string before calling 'error', since %c now has the
1792 printf meaning.
1793 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1794 overflow when computing char to be passed to 'error'. Do not
1795 pass Lisp_Object to 'error'; pass the integer instead.
1796 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1797 formatted with plain %d.
1798
b189fa66
PE
1799 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1800
bff87ef0
PE
1801 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1802
7e2cac20
PE
1803 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1804
ce4d90b5
PE
1805 * xterm.c (x_catch_errors): Remove duplicate declaration.
1806
266c9547
PE
1807 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1808
79c49ad2
PE
1809 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1810
368f4090
JM
18112011-04-10 Jim Meyering <meyering@redhat.com>
1812
1813 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1814 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1815 return ssize_t not "int", and use size_t as the buffer length.
1816 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1817 * gnutls.h: Update declarations.
1818 * process.c (read_process_output): Use ssize_t, to match.
1819 (send_process): Likewise.
1820
a32d4040
CY
18212011-04-09 Chong Yidong <cyd@stupidchicken.com>
1822
1823 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1824
8546720e 18252011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1826
04f2d78b
CB
1827 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1828 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1829
8546720e
GM
1830 * xterm.c (handle_one_xevent):
1831 * xmenu.c (create_and_show_popup_menu):
1832 * xselect.c (x_decline_selection_request)
1833 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1834
0a2f5c1a 18352011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1836
1837 Fix some uses of `int' instead of EMACS_INT.
1838 * search.c (string_match_1, fast_string_match)
1839 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1840 (scan_buffer, find_next_newline_no_quit)
1841 (find_before_next_newline, search_command, Freplace_match)
1842 (Fmatch_data): Make some `int' variables be EMACS_INT.
1843
1844 * xdisp.c (display_count_lines): 3rd argument and return value now
1845 EMACS_INT. All callers changed.
1846 (pint2hrstr): Last argument is now EMACS_INT.
1847
1848 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1849 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1850 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1851 (decode_coding_utf_16, decode_coding_emacs_mule)
1852 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1853 (decode_coding_ccl, decode_coding_charset)
1854 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1855 (decode_coding_iso_2022, decode_coding_emacs_mule)
1856 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1857 <char_offset, last_offset>: Declare EMACS_INT.
1858 (encode_coding_utf_8, encode_coding_utf_16)
1859 (encode_coding_emacs_mule, encode_invocation_designation)
1860 (encode_designation_at_bol, encode_coding_iso_2022)
1861 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1862 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1863 Declare EMACS_INT.
1864 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1865 (encode_invocation_designation): Last argument P_NCHARS is now
1866 EMACS_INT.
1867 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1868 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1869
1870 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1871 All users changed.
1872
1873 * ccl.c (Fccl_execute_on_string): Declare some variables
1874 EMACS_INT.
1875
8546720e 18762011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1877
1878 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1879
4e19a977
CS
18802011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1881
1882 * process.c (Fformat_network_address): Doc fix.
1883
87302331
R
18842011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1885
1886 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1887
cbb59342
CY
18882011-04-08 Chong Yidong <cyd@stupidchicken.com>
1889
1890 * keyboard.c (read_char): Call Lisp function help-form-show,
1891 instead of using internal_with_output_to_temp_buffer.
1892 (Qhelp_form_show): New var.
e0d38eeb 1893 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1894
1895 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1896
1897 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1898
e67a13ab
CY
18992011-04-06 Chong Yidong <cyd@stupidchicken.com>
1900
04f2d78b
CB
1901 * process.c (Flist_processes): Remove to Lisp.
1902 (list_processes_1): Delete.
e67a13ab 1903
973f782d
EZ
19042011-04-06 Eli Zaretskii <eliz@gnu.org>
1905
7c106b1e
EZ
1906 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1907
973f782d
EZ
1908 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1909
41cf7d1a 19102011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1911
ca23cc88
PE
1912 Fix more problems found by GCC 4.6.0's static checks.
1913
f390e2d5
PE
1914 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1915
42eea0d0
PE
1916 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1917
b69769da 1918 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1919
f9541e84
PE
1920 * xdisp.c (vmessage): Mark as a printf-like function.
1921
13841b55
PE
1922 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1923
c136c10f
PE
1924 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1925
5e2d4a30
PE
1926 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1927 printf-like functions.
1928 (tiff_load): Add casts to remove these marks before passing them
1929 to system-supplied API.
1930
583f48b9
PE
1931 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1932
b25d760e
PE
1933 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1934 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1935 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1936 directly, rather than having caller test rule sign. This avoids
1937 some unnecessary tests.
1938 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1939 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1940 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1941
bc7b6697 1942 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1943 (xfont_open): Avoid unnecessary tests.
bc7b6697 1944
27ccc379
PE
1945 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1946
dcd5c89a
PE
1947 * composite.h, composite.c (composition_gstring_put_cache):
1948 Use EMACS_INT, not int, for length.
1949
b13a45c6
PE
1950 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1951 breaking out part of COMPOSITION_DECODE_RULE.
1952 (COMPOSITION_DECODE_RULE): Use it.
1953 * composite.c (get_composition_id): Remove unused local vars,
1954 by using the new macro.
1955
1e792e4d
PE
1956 * textprop.c (set_text_properties_1): Change while to do-while,
1957 since the condition is always true at first.
1958
dc6c6455 1959 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1960 (interval_deletion_adjustment): Return unsigned value.
1961 All uses changed.
dc6c6455 1962
aba7731a
PE
1963 * process.c (list_processes_1, create_pty, read_process_output):
1964 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1965 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1966 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1967 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1968 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1969
fdfc4bf3
PE
1970 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1971
fca8fe46 1972 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1973 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1974
06a0259a 1975 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1976 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1977 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1978
e7b9e80f
PE
1979 * print.c (print_error_message): Avoid int overflow.
1980
56201685
PE
1981 * font.c (font_list_entities): Redo for clarity,
1982 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1983
78834453 1984 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1985 (font_score): Avoid potential overflow in diff calculation.
78834453 1986
0bc0b309 1987 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1988 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1989
e610eaca
PE
1990 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1991
b895abce
PE
1992 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1993 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1994 can always succeed if overflow has undefined behavior.
1995
1f1d9321 1996 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1997 (wordify): Omit three unnecessary tests.
1f1d9321 1998
c59478bc
PE
1999 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2000 All callers changed. This avoids the need for an unused var.
2001
79b73827
PE
2002 * casefiddle.c (casify_region): Remove var that is set but not used.
2003
a4db5dfe
PE
2004 * dired.c (file_name_completion): Remove var that is set but not used.
2005
43aae36e
PE
2006 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2007
2a47c44d 2008 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2009 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2010
a37c69bf
PE
2011 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2012 Check for integer overflow on size calculations.
2013
328ab8e7
PE
2014 * buffer.c (Fprevious_overlay_change): Remove var that is set
2015 but not used.
2016
e5a2a5cb
PE
2017 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2018 Remove vars that are set but not used.
8d84a6eb 2019 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2020 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2021
a60e5f68
PE
2022 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2023
f661cb61 2024 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2025 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2026
f0397f5a
PE
2027 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2028 that are set but not used.
2029
8664db06 2030 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2031 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2032
6abdaa4a
PE
2033 * xselect.c (x_get_local_selection, x_handle_property_notify):
2034 Remove vars that are set but not used.
2035
0ce7538d 2036 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2037 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2038
9ae848fc
PE
2039 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2040 Remove var that is set but not used.
0b918413
PE
2041 (scroll_bar_windows_size): Now size_t, not int.
2042 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2043 Check for overflow.
9ae848fc 2044
a5a62657
PE
2045 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2046 (map_tty_color) [!defined MSDOS]: Likewise.
2047
5c5cdd39
PE
2048 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2049
66ebf983
PE
2050 * coding.c: Remove vars that are set but not used.
2051 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2052 All callers changed.
2053 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2054 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2055 (decode_coding_charset): Remove vars that are set but not used.
2056
1be4d761
PE
2057 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2058 that is set but not used.
2059
47553fa8
PE
2060 * print.c (print_object): Remove var that is set but not used.
2061
1f7196bf 2062 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2063 The gnulib version avoids calling malloc in the usual case,
2064 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2065 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2066 * filelock.c (current_lock_owner): Likewise.
2067 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2068 * sysdep.c: Include allocator.h, careadlinkat.h.
2069 (emacs_no_realloc_allocator): New static constant.
2070 (emacs_readlink): New function.
fdb61804
PE
2071 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2072 ../lib/careadlinkat.h.
d1fdcab7 2073
f84c17c7
SM
20742011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2075
2076 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2077 first non-nil return value).
2078
ef3862ad
JD
20792011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2080
2081 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2082 if not defined (Bug#8403).
2083
376a7006
JB
20842011-04-02 Juanma Barranquero <lekktu@gmail.com>
2085
2086 * xdisp.c (display_count_lines): Remove parameter `start',
2087 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2088 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2089 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2090 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2091 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2092 and thereabouts. All callers changed.
2093 (get_per_char_metric): Remove parameter `f', unused since
2094 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2095
6ca3801d
JM
20962011-04-02 Jim Meyering <meyering@redhat.com>
2097
2098 do not dereference NULL upon failed strdup
2099 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2100 (ns_get_family): Likewise.
2101
d8e2b5ba
JB
21022011-04-02 Juanma Barranquero <lekktu@gmail.com>
2103
2104 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2105
8c74fcbd
JD
21062011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2107
2108 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2109 later (Bug#8403).
2110
7200d79c
SM
21112011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2112
03408648 2113 Add lexical binding.
7200d79c 2114
03408648
SM
2115 * window.c (Ftemp_output_buffer_show): New fun.
2116 (Fsave_window_excursion):
2117 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2118
2119 * lread.c (lisp_file_lexically_bound_p): New function.
2120 (Fload): Bind Qlexical_binding.
2121 (readevalloop): Remove `evalfun' arg.
2122 Bind Qinternal_interpreter_environment.
2123 (Feval_buffer): Bind Qlexical_binding.
2124 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2125 Mark as dynamic.
2126 (syms_of_lread): Declare `lexical-binding'.
2127
2128 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2129
2130 * keyboard.c (eval_dyn): New fun.
2131 (menu_item_eval_property): Use it.
ca105506
SM
2132
2133 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2134
03408648
SM
2135 * fns.c (concat, mapcar1): Accept byte-code-functions.
2136
2137 * eval.c (Fsetq): Handle lexical vars.
2138 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2139 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2140 (FletX, Flet): Obey lexical binding.
2141 (Fcommandp): Handle closures.
2142 (Feval): New `lexical' arg.
2143 (eval_sub): New function extracted from Feval. Use it almost
2144 everywhere where Feval was used. Look up vars in lexical env.
2145 Handle closures.
2146 (Ffunctionp): Move from subr.el.
2147 (Ffuncall): Handle closures.
2148 (apply_lambda): Remove `eval_flags'.
2149 (funcall_lambda): Handle closures and new byte-code-functions.
2150 (Fspecial_variable_p): New function.
2151 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2152 but without exporting it to Lisp.
23aba0ea 2153
23aba0ea 2154 * doc.c (Fdocumentation, store_function_docstring):
03408648 2155 * data.c (Finteractive_form): Handle closures.
23aba0ea 2156
03408648
SM
2157 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2158 interactive spec.
ba83908c 2159
04f2d78b
CB
2160 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2161 New byte-codes.
03408648
SM
2162 (exec_byte_code): New function extracted from Fbyte_code to handle new
2163 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2164
03408648 2165 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2166
03408648 2167 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2168
e2abce01
JB
21692011-03-31 Juanma Barranquero <lekktu@gmail.com>
2170
2171 * xdisp.c (redisplay_internal): Fix prototype.
2172
63696a73 21732011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2174
63696a73 2175 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2176 (try_scrolling): Use it when setting scroll_limit.
2177 Limit scrolling to 100 screen lines.
63696a73
EZ
2178 (redisplay_window): Even when falling back on "recentering",
2179 position point in the window according to scroll-conservatively,
2180 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2181
2182 (try_scrolling): When point is above the window, allow searching
2183 as far as scroll_max, or one screenful, to compute vertical
2184 distance from PT to the scroll margin position. This prevents
2185 try_scrolling from unnecessarily failing when
2186 scroll-conservatively is set to a value slightly larger than the
2187 window height. Clean up the case of PT below the margin at bottom
2188 of window: scroll_max can no longer be INT_MAX. When aggressive
2189 scrolling is in use, don't let point enter the opposite scroll
2190 margin as result of the scroll.
2191 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2192 threshold of 100 lines for never-recentering scrolling.
2193
e4cc2dfc
JB
21942011-03-31 Juanma Barranquero <lekktu@gmail.com>
2195
2196 * dispextern.h (move_it_by_lines):
2197 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2198 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2199 (message_log_check_duplicate): Remove parameters `prev_bol' and
2200 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2201 (redisplay_internal): Remove parameter `preserve_echo_area',
2202 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2203
2204 * indent.c (Fvertical_motion):
2205 * window.c (window_scroll_pixel_based, Frecenter):
2206 Don't pass `need_y_p' to `move_it_by_lines'.
2207
1c470562
SM
22082011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2209
44f230aa
SM
2210 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2211 steal a few bits to be more compact.
2212 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2213 Remove unneeded casts.
2214
1c470562
SM
2215 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2216
888adce9
ZK
22172011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2218
2219 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2220 binding" message (bug#7967).
2221
f838ed7b
PE
22222011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2223
77861b95
PE
2224 Fix more problems found by GCC 4.6.0's static checks.
2225
de6dbc14
PE
2226 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2227 Remove unused local var.
2228
f838ed7b
PE
2229 * editfns.c (Fmessage_box): Remove unused local var.
2230
792c7b2b
PE
2231 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2232 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2233 Omit unused local vars.
c499e557 2234 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2235 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2236 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2237 Omit unused local var.
2238
ba0165e1
PE
2239 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2240 Don't assume string length fits in int.
32ad8845 2241 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2242 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2243
3c59b4c9
PE
2244 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2245 instead of alloca (Bug#8344).
2246
a3eed478 2247 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2248 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2249
eb4d412d
PE
2250 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2251
1658b401
PE
2252 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2253 concerns.
2254
2255 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2256
2257 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2258
9a2c6e05
PE
2259 * keyboard.c (syms_of_keyboard): Use the same style as later
2260 in this function when indexing through an array. This also
2261 works around GCC bug 48267.
2262
03d0a109
PE
2263 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2264
44f730c8
PE
2265 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2266
fe75f926
PE
2267 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2268 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2269
ffa8c828
PE
2270 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2271 This avoids undefined behavior on integer overflow, and is a bit
2272 more convenient anyway since it is compared to a size_t variable.
2273
c5101a77
PE
2274 Variadic C functions now count arguments with size_t, not int.
2275 This avoids an unnecessary limitation on 64-bit machines, which
2276 caused (substring ...) to crash on large vectors (Bug#8344).
2277 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2278 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2279 All variadic functions and their callers changed accordingly.
c5101a77
PE
2280 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2281 * data.c (arith_driver, float_arith_driver): Likewise.
2282 * editfns.c (general_insert_function): Likewise.
2283 * eval.c (struct backtrace.nargs, interactive_p)
2284 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2285 (funcall_lambda, mark_backtrace): Likewise.
2286 * fns.c (concat): Likewise.
2287 * frame.c (x_set_frame_parameters): Likewise.
2288 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2289 0 if not found, not -1. All callers changed.
2290
dd3f25f7
PE
2291 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2292 (stack_copy_size): Now size_t, not int.
2293 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2294
461c2ab9
JB
22952011-03-28 Juanma Barranquero <lekktu@gmail.com>
2296
2297 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2298 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2299 All callers changed.
2300
2301 * lisp.h (multibyte_char_to_unibyte):
2302 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2303 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2304 * character.h (CHAR_TO_BYTE8):
2305 * cmds.c (internal_self_insert):
2306 * editfns.c (general_insert_function):
2307 * keymap.c (push_key_description):
2308 * search.c (Freplace_match):
2309 * xdisp.c (message_dolog, set_message_1): All callers changed.
2310
f6d62986
SM
23112011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2312
2313 * keyboard.c (safe_run_hook_funcall): New function.
2314 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2315 don't set the hook to nil, but remove the offending function instead.
2316 (Qcommand_hook_internal): Remove, unused.
2317 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2318 Vcommand_hook_internal.
2319
2320 * eval.c (enum run_hooks_condition): Remove.
2321 (funcall_nil, funcall_not): New functions.
2322 (run_hook_with_args): Call each function through a `funcall' argument.
2323 Remove `cond' argument, now redundant.
2324 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2325 (Frun_hook_with_args_until_failure): Adjust accordingly.
2326 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2327
1db5b1ad
JB
23282011-03-28 Juanma Barranquero <lekktu@gmail.com>
2329
2330 * dispextern.h (string_buffer_position): Remove declaration.
2331
2332 * print.c (strout): Remove parameter `multibyte', unused since
2333 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2334
2335 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2336 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2337 All callers changed.
2338
2339 * w32.c (_wsa_errlist): Use braces for struct initializers.
2340
2341 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2342 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2343 All callers changed.
2344 (string_buffer_position): Likewise. Also, make static (it's never
2345 used outside xdisp.c).
2346 (cursor_row_p): Remove parameter `w', unused since
2347 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2348 (decode_mode_spec): Remove parameter `precision', introduced during
2349 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2350 All callers changed.
2351
5ffb62aa
JD
23522011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2353
2354 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2355
461c2ab9 23562011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2357
2358 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2359 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2360 (ns_update_auto_hide_menu_bar): New functions.
2361 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2362 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2363 ns_constrain_all_frames.
2364 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2365 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2366
5c380ffb
JD
23672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2368
2369 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2370
9af30bdf
GM
23712011-03-27 Glenn Morris <rgm@gnu.org>
2372
2373 * syssignal.h: Replace RETSIGTYPE with void.
2374 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2375 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2376 Replace SIGTYPE with void everywhere.
2377 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2378 * s/template.h (SIGTYPE): Remove commented out definition.
2379
e2abce01
JB
23802011-03-26 Eli Zaretskii <eliz@gnu.org>
2381
2382 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2383 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2384
f868cd8a
JB
23852011-03-26 Juanma Barranquero <lekktu@gmail.com>
2386
59eb0929
JB
2387 * w32.c (read_unc_volume): Use parameter `henum', instead of
2388 global variable `wget_enum_handle'.
2389
2390 * keymap.c (describe_vector): Remove parameters `indices' and
2391 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2392 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2393
f868cd8a
JB
2394 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2395
2396 * keyboard.c (timer_check): Remove parameter `do_it_now',
2397 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2398 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2399 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2400
2401 * keyboard.c (read_char):
2402 * w32menu.c (w32_menu_display_help):
2403 * xmenu.c (show_help_event, menu_help_callback):
2404 Adjust calls to `show_help_echo'.
2405
2406 * gtkutil.c (xg_maybe_add_timer):
2407 * keyboard.c (readable_events):
2408 * process.c (wait_reading_process_output):
2409 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2410
2411 * insdel.c (adjust_markers_gap_motion):
2412 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2413 (gap_left, gap_right): Don't call it.
2414
2ecf6fdb
CY
24152011-03-25 Chong Yidong <cyd@stupidchicken.com>
2416
2417 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2418 incurred during fontification.
2419
6b1f9ba4
JB
24202011-03-25 Juanma Barranquero <lekktu@gmail.com>
2421
2422 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2423 (DEFVAR_PER_BUFFER): Don't pass it.
2424
2425 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2426 (scrolling_window): Don't pass it.
2427
0f4a96b5
JB
24282011-03-25 Juanma Barranquero <lekktu@gmail.com>
2429
2430 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2431
2432 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2433 and `suffix'.
2434 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2435 of variables specific to SELinux and computation of `encoded_absname'.
2436
2437 * image.c (XPutPixel): Remove unused variable `height'.
2438
2439 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2440
2441 * unexw32.c (get_section_info): Remove unused variable `section'.
2442
2443 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2444 (system_process_attributes): Remove unused variable `sess'.
2445 (sys_read): Remove unused variable `err'.
2446
2447 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2448 (w32_wnd_proc): Remove unused variable `isdead'.
2449 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2450 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2451 (x_create_tip_frame): Remove unused variable `tem'.
2452
2453 * w32inevt.c (w32_console_read_socket):
2454 Remove unused variable `no_events'.
2455
2456 * w32term.c (x_draw_composite_glyph_string_foreground):
2457 Remove unused variable `width'.
2458
1149507c
JB
24592011-03-24 Juanma Barranquero <lekktu@gmail.com>
2460
2461 * w32term.c (x_set_glyph_string_clipping):
2462 Don't pass uninitialized region to CombineRgn.
2463
9c88f339
JB
24642011-03-23 Juanma Barranquero <lekktu@gmail.com>
2465
2466 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2467 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2468 (Fx_close_connection): Remove unused variable `i'.
2469
2470 * w32font.c (w32font_draw): Return number of glyphs.
2471 (w32font_open_internal): Remove unused variable `i'.
2472 (w32font_driver): Add missing initializer.
2473
2474 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2475 (fill_in_menu): Remove unused variable `items_added'.
2476
2477 * w32term.c (last_mouse_press_frame): Remove static global variable.
2478 (w32_clip_to_row): Remove unused variable `f'.
2479 (x_delete_terminal): Remove unused variable `i'.
2480
2481 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2482 (NOTHING): Remove unused static global variable.
2483 (uniscribe_check_otf): Remove unused variable `table'.
2484 (uniscribe_font_driver): Add missing initializers.
2485
dee091a3
JD
24862011-03-23 Julien Danjou <julien@danjou.info>
2487
2488 * term.c (Fsuspend_tty, Fresume_tty):
2489 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2490 * window.c (temp_output_buffer_show):
2491 * insdel.c (signal_before_change):
2492 * frame.c (Fhandle_switch_frame):
2493 * fileio.c (Fdo_auto_save):
2494 * emacs.c (Fkill_emacs):
2495 * editfns.c (save_excursion_restore):
2496 * cmds.c (internal_self_insert):
2497 * callint.c (Fcall_interactively):
2498 * buffer.c (Fkill_all_local_variables):
2499 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2500 Use Frun_hooks.
0f4a96b5 2501 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2502 unconditionnaly since it does the check itself.
2503
2c520ab5 25042011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2505
c9c49752
PE
2506 Fix more problems found by GCC 4.5.2's static checks.
2507
8abc3f12
PE
2508 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2509 the first time through the loop, since we know p0 < p1 then.
2510 This also avoids a gcc -Wstrict-overflow warning.
2511
a2d26660
PE
2512 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2513 leading to a memory leak, possible in functions like
2514 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2515 of objects (Bug#8318).
a2d26660 2516
916c72e9
PE
2517 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2518 that could (at least in theory) be that large.
2519
19ab8a18
PE
2520 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2521 This is less likely to overflow, and avoids undefined behavior if
2522 overflow does occur. All callers changed. Use strtoul to scan
2523 for the unsigned long integer.
b7cbbd6f
PE
2524 (pint2hrstr): Simplify and tune code slightly.
2525 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2526
f0641eff
PE
2527 * scroll.c (do_scrolling): Work around GCC bug 48228.
2528 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2529
7f650bb9
PE
2530 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2531 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2532 (validate_x_resource_name): Simplify count usage.
2533 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2534
37dd57d1
PE
2535 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2536 fail (Bug#8306).
81e56e61 2537
699979fc 2538 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2539
401bf9b4
PE
2540 * process.c (Fmake_network_process): Use socklen_t, not int,
2541 where POSIX says socklen_t is required in portable programs.
2542 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2543 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2544 (Fmake_network_process, server_accept_connection):
2545 (wait_reading_process_output, read_process_output):
2546 Likewise.
2547
b93aacde
PE
2548 * process.c: Rename or move locals to avoid shadowing.
2549 (list_processes_1, Fmake_network_process):
2550 (read_process_output_error_handler, exec_sentinel_error_handler):
2551 Rename or move locals.
4dc343ee 2552 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2553 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2554 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2555 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2556 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2557
af8a867c 2558 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2559 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2560 Include tparam.h instead, since it declares them.
af8a867c
PE
2561 * cm.h (PC): Remove extern decl; tparam.h now does this.
2562 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2563 * terminfo.c: Include tparam.h, to check interfaces.
2564 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2565 (tparam): Adjust signature to match interface in tparam.h;
2566 this removes some undefined behavior. Check that outstring and len
2567 are zero, which they always are with Emacs.
2568 * tparam.h (PC, BC, UP): New extern decls.
2569
0248044d 2570 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2571 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2572
8ff096c1 2573 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2574 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2575 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2576 (ftfont_list): Remove unused local.
49eaafba
PE
2577 (get_adstyle_property, ftfont_pattern_entity):
2578 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2579 Rename locals to avoid shadowing.
8ff096c1 2580
e2be39f6
PE
2581 * xfont.c (xfont_list_family): Mark var as initialized.
2582
c9735e30
PE
2583 * xml.c (make_dom): Now static.
2584
8f5201ae
PE
2585 * composite.c (composition_compute_stop_pos): Rename local to
2586 avoid shadowing.
b246f932
PE
2587 (composition_reseat_it): Remove unused locals.
2588 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2589 (composition_update_it): Mark var as initialized.
11b61122
PE
2590 (find_automatic_composition): Mark vars as initialized,
2591 with a FIXME (Bug#8290).
8f5201ae 2592
760fbc2c
PE
2593 character.h: Rename locals to avoid shadowing.
2594 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2595 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2596 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2597 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2598 to avoid shadowing.
2599
ff08eb85
PE
2600 * textprop.c (property_change_between_p): Remove; unused.
2601
fc7bf025
PE
2602 * intervals.c (interval_start_pos): Now static.
2603
235d7abc
PE
2604 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2605
44f230aa
SM
2606 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2607 Rename locals to avoid shadowing.
3e7d6594 2608
50060332
PE
2609 * sound.c (wav_play, au_play, Fplay_sound_internal):
2610 Fix pointer signedness.
d01f234b 2611 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2612 (wav_play): Initialize a variable to 0, to prevent undefined
2613 behavior (Bug#8278).
50060332 2614
c4fc4e30
PE
2615 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2616
918436ed
PE
2617 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2618
c939f91b
PE
2619 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2620 clobbering (Bug#8298).
b9c7f648
PE
2621 * sysdep.c (sys_subshell): Likewise.
2622 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2623
6bd8c144
PE
2624 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2625 This should get cleaned up, so that child_setup has the
2626 same signature on all platforms.
2627
7710357c 2628 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2629 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2630
c59da222
CY
26312011-03-22 Chong Yidong <cyd@stupidchicken.com>
2632
2633 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2634 not to be necessary, and produces flickering.
2635
66b87493
GM
26362011-03-20 Glenn Morris <rgm@gnu.org>
2637
2638 * config.in: Remove file.
2639
45b6f6d5
JB
26402011-03-20 Juanma Barranquero <lekktu@gmail.com>
2641
2642 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2643 are now in src/globals.h.
2644 (syms_of_minibuf): Remove spurious & from previous change.
2645
3ec03f7e
LL
26462011-03-20 Leo <sdl.web@gmail.com>
2647
2648 * minibuf.c (completing-read-function): New variable.
2649 (completing-read-default): Rename from completing-read.
2650 (completing-read): Call completing-read-function.
2651
b14e3e21
CY
26522011-03-19 Juanma Barranquero <lekktu@gmail.com>
2653
2654 * xfaces.c (Fx_load_color_file):
2655 Read color file from absolute filename (bug#8250).
2656
f2b726e6
JB
26572011-03-19 Juanma Barranquero <lekktu@gmail.com>
2658
2659 * makefile.w32-in: Update dependencies.
2660
09f6ff02
EZ
26612011-03-17 Eli Zaretskii <eliz@gnu.org>
2662
2663 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2664
29a6015a
PE
26652011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2666
a3a6c54e
PE
2667 Fix more problems found by GCC 4.5.2's static checks.
2668
b766f867
PE
2669 * process.c (make_serial_process_unwind, send_process_trap):
2670 (sigchld_handler): Now static.
2671
be02381c
PE
2672 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2673 That way, the code declares only the vars that it needs.
2674 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2675 * s/cygwin.h (PTY_ITERATION): Likewise.
2676 * s/darwin.h (PTY_ITERATION): Likewise.
2677 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2678
57048744
PE
2679 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2680 * process.c (allocate_pty): Don't declare stb unless it's needed.
2681
7914961c 2682 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2683 (CONSTANTLIM): Remove; unused.
2684 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2685 Define only if needed.
7914961c 2686
b3967b18
PE
2687 * unexelf.c (unexec): Name an expression,
2688 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2689 Use a different way to cause a compilation error if anyone uses
2690 n rather than nn, a way that does not involve shadowing.
73366a00 2691 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2692
29a6015a
PE
2693 * deps.mk (unexalpha.o): Remove; unused.
2694
43cfc33e 2695 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2696 * unexec.h: New file.
ce701a33
PE
2697 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2698 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2699 Depend on unexec.h.
2700 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2701 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2702 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2703 Change as necessary to match prototype in unexec.h.
ce701a33 2704
01f44d5a
PE
2705 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2706 shadowing.
4f63c6bb 2707 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2708
a6670b0b
PE
2709 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2710 Rename locals to avoid shadowing.
2711
cef2010d 2712 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2713 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2714
d4d7173a
PE
2715 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2716
f08b802a
PE
2717 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2718 warning when compiling print.c.
2719
3ddb0639
PE
2720 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2721 instead of using an uninitialized var.
5ad03b97 2722 (font_sort_entities): Mark var as initialized.
3ddb0639 2723
170a2692
PE
2724 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2725
e663c700
PE
2726 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2727 pointers to constants.
89bc529a 2728 (font_parse_fcname): Remove unused vars.
7b81e2d0 2729 (font_delete_unmatched): Now static.
ea838e10 2730 (font_get_spec): Remove; unused.
13a547c6
PE
2731 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2732 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2733 Rename or move locals to avoid shadowing.
e663c700 2734
2a80c887 2735 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2736 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2737
1384fa33 2738 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2739 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2740
8b2c52e9
PE
2741 * alloc.c (mark_backtrace): Move decl from here ...
2742 * lisp.h: ... to here, so that it can be checked.
2743
475545b5 2744 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2745 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2746 (lisp_indirect_variable): Name an expression,
2747 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2748 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2749
b1349114 2750 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2751 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2752 Use const pointer when appropriate.
b1349114 2753
a2928364
PE
2754 * lisp.h (get_system_name, get_operating_system_release):
2755 Move decls here, to check interfaces.
2756 * process.c (get_operating_system_release): Move decl to lisp.h.
2757 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2758 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2759 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2760 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2761 (Fformat_time_string, Fencode_time, Finsert_char):
2762 (Ftranslate_region_internal, Fformat):
2763 Rename or remove local vars to avoid shadowing.
9710023e 2764 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2765
a415e694
PE
2766 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2767 avoid shadowing.
2768
8ef4622d
PE
2769 * lisp.h (eassert): Check that the argument compiles, even if
2770 ENABLE_CHECKING is not defined.
2771
946f9a5b
PE
2772 * data.c (Findirect_variable): Name an expression, to avoid
2773 gcc -Wbad-function-cast warning.
112396d6 2774 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2775 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2776 (Fmake_variable_buffer_local, Fmake_local_variable):
2777 Mark variables as initialized.
52746918 2778 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2779
e5aab7e7 2780 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2781 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2782 Rename locals to avoid shadowing.
dff45157
PE
2783 (mark_stack): Move local variables into the #ifdef region where
2784 they're used.
7bc26fdb
PE
2785 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2786 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2787 needed otherwise.
2788 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2789 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2790 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2791
e5aab7e7
PE
2792 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2793 avoids undefined behavior in theory.
2794
4da60324
PE
2795 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2796
88043301
PE
2797 Use functions, not macros, for up- and down-casing (Bug#8254).
2798 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2799 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2800 to use the following functions instead of these macros.
2801 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2802 EMACS_INT, since callers assume the returned value fits in int.
2803 (upcase1): Likewise, for UPCASE_TABLE.
2804 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2805 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2806 the race-condition problem in the old DOWNCASE.
88043301 2807
19ed5445
PE
2808 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2809 Rename locals to avoid shadowing.
2810 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2811 (regex_compile, re_search_2, re_match_2_internal):
2812 Remove unused local vars.
952db0d7
PE
2813 (FREE_VAR): Rewrite so as not to use empty "else",
2814 which gcc can warn about.
da053e48 2815 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2816 (RETALLOC_IF): Define only if needed.
2817 (WORDCHAR_P): Likewise. This one is never needed, but is used
2818 only in a comment talking about a compiler bug, so put inside
2819 the #if 0 of that comment.
2820 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2821 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2822 Remove; unused.
19ed5445 2823
1f3561e4 2824 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2825 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2826 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2827
ded6f8f7
PE
2828 * search.c (simple_search): Remove unused var.
2829
dbd37a95
PE
2830 * dired.c (compile_pattern): Move decl from here ...
2831 * lisp.h: ... to here, so that it can be checked.
2832 (struct re_registers): New forward decl.
2833
7e47afad
PE
2834 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2835
85f24f61
PE
2836 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2837 All uses changed.
2838 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2839 Rename locals to avoid shadowing.
5671df8f 2840 (Fvertical_motion): Mark locals as initialized.
85f24f61 2841
181aa2be 2842 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2843 (casify_region): Mark local as initialized.
181aa2be 2844
930d429c
PE
2845 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2846
7082eac6
PE
2847 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2848 New macros, so that the caller can use some names other than
2849 gcpro1, gcpro2, etc.
2850 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2851 of the new macros.
2852 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2853 argument, for consistency with GCPRO2_VAR, etc: it is now the
2854 prefix of the variable, not the variable itself. All uses
2855 changed.
38b2c076
PE
2856 * dired.c (directory_files_internal, file_name_completion):
2857 Rename locals to avoid shadowing.
2858
15206ed9
PE
2859 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2860 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2861 dired.c's scmp function, had undefined behavior.
2862 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2863 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2864 * buffer.h: ... to here, because these macros use current_buffer,
2865 and the new implementation with inline functions needs to have
2866 current_buffer in scope now, rather than later when the macros
2867 are used.
2868 (downcase, upcase1): New static inline functions.
2869 (DOWNCASE, UPCASE1): Reimplement using these functions.
2870 This avoids undefined behavior in expressions like
2871 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2872 from race conditions in accessing the global variables
2873 case_temp1 and case_temp2.
2874 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2875 * lisp.h (case_temp1, case_temp2): Remove their decls.
2876 * character.h (ASCII_CHAR_P): Move from here ...
2877 * lisp.h: ... to here, so that the inline functions mentioned
2878 above can use them.
2879
4a6bea26
PE
2880 * dired.c (directory_files_internal_unwind): Now static.
2881
f14b7e14
PE
2882 * fileio.c (file_name_as_directory, directory_file_name):
2883 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2884 Now static.
2893f146
PE
2885 (file_name_as_directory): Use const pointers when appropriate.
2886 (Fexpand_file_name): Likewise. In particular, newdir might
2887 point at constant storage, so make it a const pointer.
fd4ead52 2888 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2889 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2890 signedness issues.
f839df0c
PE
2891 (Fset_file_times, Finsert_file_contents, auto_save_error):
2892 Rename locals to avoid shadowing.
f14b7e14 2893
5716756e 2894 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2895 (Ftry_completion, Fall_completions): Rename or remove locals
2896 to avoid shadowing.
5716756e 2897
b4c3046a
PE
2898 * marker.c (bytepos_to_charpos): Remove; unused.
2899
b45db522
PE
2900 * lisp.h (verify_bytepos, count_markers): New decls,
2901 so that gcc does not warn that these functions aren't declared.
2902
85876d07
PE
2903 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2904 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2905 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2906 (copy_text): Remove unused local var.
85876d07 2907
03d78a21 2908 * filelock.c (within_one_second): Now static.
b3dd38ab 2909 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2910
5df8f01b
PE
2911 * buffer.c (fix_overlays_before): Mark locals as initialized.
2912 (fix_start_end_in_overlays): Likewise. This function should be
2913 simplified by using pointers-to-pointers, but that's a different
2914 matter.
b1d876f1 2915 (switch_to_buffer_1): Now static.
8f54f30a
PE
2916 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2917 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2918
a70072c9 2919 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2920 Fix pointer signedness issue.
edced198
PE
2921 (sys_subshell): Mark local as volatile if checking for lint,
2922 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2923 (MAXPATHLEN): Define only if needed.
a70072c9 2924
a0977c44
PE
2925 * process.c (serial_open, serial_configure): Move decls from here ...
2926 * systty.h: ... to here, so that they can be checked.
2927
a884fdcc
PE
2928 * fns.c (get_random, seed_random): Move extern decls from here ...
2929 * lisp.h: ... to here, so that they can be checked.
2930
604efe86 2931 * sysdep.c (reset_io): Now static.
b8950c94 2932 (wait_for_termination_signal): Remove; unused.
604efe86 2933
38fc62d9
PE
2934 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2935 (copy_keymap_item, append_key, push_text_char_description):
2936 Now static.
1004a21a 2937 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2938 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2939 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2940 (describe_map_tree):
2941 Rename locals to avoid shadowing.
38fc62d9 2942
2f2650da
PE
2943 * keyboard.c: Declare functions static if they are not used elsewhere.
2944 (echo_char, echo_dash, cmd_error, top_level_2):
2945 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2946 (read_char, kbd_buffer_get_event, make_lispy_position):
2947 (make_lispy_event, make_lispy_movement, apply_modifiers):
2948 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2949 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2950 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2951 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2952 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2953
a053e86c 2954 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2955 (mark_kboards): Move decl here ...
2956 * alloc.c (mark_kboards): ... from here.
a053e86c 2957
4752793e
PE
2958 * lisp.h (force_auto_save_soon): New decl.
2959
74f10ca7 2960 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2961 (DEFINE_DUMMY_FUNCTION): New macro.
2962 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2963 Use it.
c03cd23f
PE
2964 (main): Add casts to avoid warnings
2965 if GCC considers string literals to be constants.
74f10ca7 2966
022e70d4
PE
2967 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2968
59d6fe83
PE
2969 * dbusbind.c: Pointer signedness fixes.
2970 (xd_signature, xd_append_arg, xd_initialize):
2971 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2972 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2973 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2974 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2975
78320123
PE
2976 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2977 if GCC considers string literals to be constants.
49cebcca 2978 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2979
35ac2a97
SM
29802011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2981
fb103ca9
SM
2982 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2983 (print_preprocess, print_object): New macro to fix last change.
2984
35ac2a97
SM
2985 * print.c (print_preprocess): Don't forget font objects.
2986
62973b41
JB
29872011-03-16 Juanma Barranquero <lekktu@gmail.com>
2988
2989 * emacs.c (USAGE3): Doc fixes.
2990
0e48bb22
AS
29912011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2992
2993 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2994 structure.
2995
7684e57b
JB
29962011-03-14 Juanma Barranquero <lekktu@gmail.com>
2997
2998 * lisp.h (VWindow_system, Qfile_name_history):
2999 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3000 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3001 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3002
3003 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3004 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3005
3006 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3007 * w32console.c (detect_input_pending, read_input_pending)
3008 (encode_terminal_code):
3009 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3010 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3011 (w32_system_caret_y, Qfile_name_history):
3012 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3013 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3014 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3015 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3016 * w32proc.c (Qlocal, report_file_error):
3017 * w32term.c (Vwindow_system, updating_frame):
3018 * w32uniscribe.c (initialized, uniscribe_font_driver):
3019 Remove unneeded extern declarations.
3020
2aa46d6c
CY
30212011-03-14 Chong Yidong <cyd@stupidchicken.com>
3022
c96bbc66 3023 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3024
cffc6f3b
CY
30252011-03-13 Chong Yidong <cyd@stupidchicken.com>
3026
3027 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3028 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3029 These macros can no longer be used for assignment.
3030
44f230aa
SM
3031 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3032 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3033 (record_buffer_markers, fetch_buffer_markers): New functions for
3034 recording and fetching special buffer markers.
3035 (set_buffer_internal_1, set_buffer_temp): Use them.
3036
3037 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3038
3039 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3040
3041 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3042 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3043
3044 * xdisp.c (hscroll_window_tree):
3045 (reconsider_clip_changes): Use PT instead of BUF_PT.
3046
d251f04b
EZ
30472011-03-13 Eli Zaretskii <eliz@gnu.org>
3048
3049 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3050 $(EMACS_ROOT)/lib/intprops.h.
3051
f0c77cd1
PE
30522011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3053
3eca4629
PE
3054 Fix more problems found by GCC 4.5.2's static checks.
3055
7c86ee98
PE
3056 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3057 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3058 (xg_free_frame_widgets): Make it clear that a local variable is
3059 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3060 (gdk_window_get_screen): Make it clear that this macro is needed
3061 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3062 (int_gtk_range_get_value): New function, which avoids a diagnostic
3063 from gcc -Wbad-function-cast.
3064 (xg_set_toolkit_scroll_bar_thumb): Use it.
3065 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3066 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3067 (get_utf8_string, xg_get_file_with_chooser):
3068 Rename locals to avoid shadowing.
3069 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3070
41729b81
PE
3071 * xgselect.c (xg_select): Remove unused var.
3072
f0c77cd1
PE
3073 * image.c (four_corners_best): Mark locals as initialized.
3074 (gif_load): Initialize transparent_p to zero (Bug#8238).
3075 Mark another local as initialized.
ec6cf4c6 3076 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3077
ce0ad53d 3078 * image.c (clear_image_cache): Now static.
d5d5a617 3079 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3080 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3081 (x_edge_detection): Remove unnecessary cast that
3082 gcc -Wbad-function-cast diagnoses.
2037898d 3083 (gif_load): Fix pointer signedness.
6ae141d6
PE
3084 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3085 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3086
33383987 30872011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3088
d32df629
PE
3089 Improve quality of tests for time stamp overflow.
3090 For example, without this patch (encode-time 0 0 0 1 1
3091 1152921504606846976) returns the obviously-bogus value (-948597
3092 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3093 reports time overflow. See
3094 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3095 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3096 * editfns.c: Include limits.h and intprops.h.
3097 (TIME_T_MIN, TIME_T_MAX): New macros.
3098 (time_overflow): Move earlier, to before first use.
3099 (hi_time, lo_time): New functions, for an accurate test for
3100 out-of-range times.
3101 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3102 (Fget_internal_run_time): Don't assume time_t fits in int.
3103 (make_time): Use list2 instead of Fcons twice.
3104 (Fdecode_time): More accurate test for out-of-range times.
3105 (check_tm_member): New function.
3106 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3107 (lisp_time_argument): Don't rely on undefined left-shift and
3108 right-shift behavior when checking for time stamp overflow.
8be6f318 3109
fe31d94c
PE
3110 * editfns.c (time_overflow): New function, refactoring common code.
3111 (Fformat_time_string, Fdecode_time, Fencode_time):
3112 (Fcurrent_time_string): Use it.
3113
8be6f318
PE
3114 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3115 * dired.c (make_time): Move to ...
3116 * editfns.c (make_time): ... here.
3117 * systime.h: Note the move.
3118
09d9db2c 31192011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3120
126bc0dc
YM
3121 * fringe.c (update_window_fringes): Remove unused variables.
3122
c47cbdfd
YM
3123 * unexmacosx.c (copy_data_segment): Also copy __got section.
3124 (Bug#8223)
3125
7ac80be9
EZ
31262011-03-12 Eli Zaretskii <eliz@gnu.org>
3127
c96bbc66 3128 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3129 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3130 Constify `char *' arguments and their references according to
3131 prototypes in tparam.h.
3132
ecb0f94d 3133 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3134
7ac80be9
EZ
3135 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3136 Adapt all references accordingly.
3137
3138 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3139
ef1fd07e
TT
31402011-03-11 Tom Tromey <tromey@redhat.com>
3141
3142 * buffer.c (syms_of_buffer): Remove obsolete comment.
3143
7ef4b50c
EZ
31442011-03-11 Eli Zaretskii <eliz@gnu.org>
3145
3146 * termhooks.h (encode_terminal_code): Declare prototype.
3147
3148 * msdos.c (encode_terminal_code): Don't declare prototype.
3149
3150 * term.c (encode_terminal_code): Now external again, used by
3151 w32console.c and msdos.c.
3152
44f230aa
SM
3153 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3154 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3155
4b1ec863 31562011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3157
1714f52b 3158 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3159
4b1ec863
PE
3160 * fringe.c (update_window_fringes): Mark locals as initialized
3161 (Bug#8227).
3162 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3163
524c7aa6
PE
3164 * alloc.c (mark_fringe_data): Move decl from here ...
3165 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3166 to check its interface.
3167 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3168
a5c0af81 3169 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3170 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3171 (fontset_font): Mark local as initialized.
a9a06e0b 3172 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3173
b4716021
PE
3174 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3175
811e9bac 3176 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3177 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3178 (x_own_selection, Fx_disown_selection_internal): Rename locals
3179 to avoid shadowing.
3180 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3181
7e3ab302
PE
3182 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3183 so that the caller can use some name other than gcpro1.
3184 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3185 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3186 (Fx_backspace_delete_keys_p):
3187 Use them to avoid shadowing, and rename vars to avoid shadowing.
3188 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3189 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3190 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3191 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3192 Remove unused locals.
7e3ab302
PE
3193 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3194 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3195 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3196 macros.
f78faa98 3197
e2b13473
PE
3198 * xterm.h (x_mouse_leave): New decl.
3199
77f23912
PE
3200 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3201 Remove unused functions.
cdf4ba58
PE
3202 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3203 (x_calc_absolute_position): Now static.
7411c686 3204 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3205 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3206 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3207 unless they are used.
38d0b34a
PE
3208 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3209 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3210 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3211 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3212 (x_error_catcher, x_connection_closed, x_error_handler):
3213 (x_error_quitter, xembed_send_message, x_iconify_frame):
3214 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3215 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3216 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3217
44f230aa
SM
3218 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3219 Rename or move locals to avoid shadowing.
6b463e58 3220 (tty_defined_color, merge_face_heights): Now static.
5967d051 3221 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3222 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3223 does not deduce is never used uninitialized.
73719eba
PE
3224 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3225 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3226
426994c3 3227 * terminal.c (store_terminal_param): Now static.
5489860b 3228
032f1620 3229 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3230 (set_frame_menubar): Remove unused local.
d4323972 3231 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3232 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3233 since they might point to immutable storage.
281585b0
PE
3234 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3235 since it's unused otherwise.
032f1620 3236
367c19e5 3237 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3238 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3239 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3240 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3241 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3242 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3243 does not deduce are never used uninitialized.
70739cbe 3244
07b48fa9
PE
3245 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3246
8868a238 3247 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3248 * window.c (window_loop, size_window):
3249 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3250
7e5cf297 3251 * window.c (display_buffer): Now static.
d6550a9f
PE
3252 (size_window): Mark variables that gcc -Wuninitialized
3253 does not deduce are never used uninitialized.
a586633d
PE
3254 * window.h (check_all_windows): New decl, to forestall
3255 gcc -Wmissing-prototypes diagnostic.
5b555da1 3256 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3257
f6095868
PE
3258 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3259 shadowing.
3260 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3261 Include <limits.h>.
3262 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3263 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3264 (load_charset_map): Mark variables that gcc -Wuninitialized
3265 does not deduce are never used uninitialized.
53df7c11 3266 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3267
f38b440c
PE
3268 * coding.c (coding_set_source, coding_set_destination):
3269 Use "else { /* comment */ }" rather than "else /* comment */;"
3270 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3271 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3272 a block, when the outer 'i' will do.
3273 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3274 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3275 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3276 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3277 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3278 Rename locals to avoid shadowing.
3279 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3280 * coding.c (emacs_mule_char, encode_invocation_designation):
3281 Now static, since they're not used elsewhere.
413bb2db 3282 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3283 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3284 (decode_coding_emacs_mule): Mark variables that gcc
3285 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3286 (detect_coding_iso_2022): Initialize a local variable that might
3287 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3288 this initialization is needed. (Bug#8211)
5f58e762
PE
3289 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3290 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3291 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3292 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3293 Remove unused macros.
f38b440c 3294
232b38b9 3295 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3296 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3297 * character.c (string_count_byte8): Likewise.
232b38b9 3298
fb90da1b
PE
3299 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3300 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3301
fb93dbc2
PE
3302 * chartab.c (copy_sub_char_table): Now static, since it's not used
3303 elsewhere.
5c156ace
PE
3304 (sub_char_table_ref_and_range, char_table_ref_and_range):
3305 Rename locals to avoid shadowing.
bbcd0949 3306 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3307
7d3b3862 3308 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3309 (BIDI_BOB): Remove unused macro.
7d3b3862 3310
6be7d3da
PE
3311 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3312 deduce are never used uninitialized.
c2ed9c8b 3313 * term.c (encode_terminal_code): Likewise.
6be7d3da 3314
75f8807f 3315 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3316
50938595
PE
3317 * tparam.h: New file.
3318 * term.c, tparam.h: Include it.
3319 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3320 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3321 Move these decls to tparam.h, and make them agree with what
3322 is actually in tparam.c. The previous trick of using incompatible
3323 decls in different modules does not conform to the C standard.
3324 All callers of tparam changed to use tparam's actual API.
3325 * tparam.c (tparam1, tparam, tgoto):
3326 Use const pointers where appropriate.
3327
fbceeba2
PE
3328 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3329 * cm.h (struct cm): Likewise.
3330 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3331 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3332 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3333 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3334 (turn_on_face, init_tty): Likewise.
3335 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3336
7f3f1250
PE
3337 * term.c (term_mouse_position): Rename local to avoid shadowing.
3338
e6ca6543
PE
3339 * alloc.c (mark_ttys): Move decl from here ...
3340 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3341
c40f8d15
AS
33422011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3343
3344 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3345
cfe0661d
JB
33462011-03-09 Juanma Barranquero <lekktu@gmail.com>
3347
3348 * search.c (compile_pattern_1): Remove argument regp, unused since
3349 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3350 (compile_pattern): Don't pass it.
3351
0afb4571
J
33522011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3353
3354 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3355 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3356 for ! HAVE_GTK3.
3357 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3358
3359 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3360
3361 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3362 gdk_window_get_screen, gdk_window_get_geometry,
3363 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3364 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3365 (xg_get_pixbuf_from_pixmap): New function.
3366 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3367 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3368 Call xg_get_pixbuf_from_pixmap instead of
3369 gdk_pixbuf_get_from_drawable.
3370 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3371 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3372 (xg_check_special_colors): Use GtkStyleContext and its functions
3373 for HAVE_GTK3.
3374 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3375 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3376 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3377 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3378 Call gtk_widget_get_preferred_size.
0afb4571
J
3379 (xg_frame_resized): gdk_window_get_geometry only takes 5
3380 parameters.
44f230aa
SM
3381 (xg_win_to_widget, xg_event_is_for_menubar):
3382 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3383 (xg_set_widget_bg): New function.
3384 (delete_cb): New function.
895009e1 3385 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3386 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3387 (xg_set_background_color): Call xg_set_widget_bg.
3388 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3389 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3390 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3391 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3392 if ! HAVE_GTK3.
3393 (update_frame_tool_bar): Call gtk_widget_hide.
3394 (xg_initialize): Use GDK_KEY_g.
3395
3396 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3397 if ! HAVE_GTK3
3398 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3399
3400 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3401 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3402 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3403
1c2cc4ef
JB
34042011-03-08 Juanma Barranquero <lekktu@gmail.com>
3405
3406 * w32xfns.c (select_palette): Check success of RealizePalette against
3407 GDI_ERROR, not zero.
3408
33383987 3409See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3410
3411;; Local Variables:
3412;; coding: utf-8
aac0c6e3
MR
3413;; End:
3414
33383987 3415 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3416
3417 This file is part of GNU Emacs.
3418
3419 GNU Emacs is free software: you can redistribute it and/or modify
3420 it under the terms of the GNU General Public License as published by
3421 the Free Software Foundation, either version 3 of the License, or
3422 (at your option) any later version.
3423
3424 GNU Emacs is distributed in the hope that it will be useful,
3425 but WITHOUT ANY WARRANTY; without even the implied warranty of
3426 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3427 GNU General Public License for more details.
3428
3429 You should have received a copy of the GNU General Public License
3430 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.