* fringe.c (standard_bitmaps): Now static.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b532497d
PE
12011-04-13 Paul Eggert <eggert@cs.ucla.edu>
2
ad9a7a06
PE
3 * fringe.c (standard_bitmaps): Now static.
4 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5
81626931
PE
6 * frame.c: Make symbols static if they're not exported.
7 (x_report_frame_params, make_terminal_frame): Now static.
8 (get_frame_param): Now static, unless HAVE_NS.
9 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10 (x_get_resource_string): Remove; not used.
11 * frame.h (make_terminal_frame, x_report_frame_params):
12 (x_get_resource_string); Remove decls.
13 (x_fullscreen_adjust): Declare only if WINDOWSNT.
14 * lisp.h (get_frame_param): Declare only if HAVE_NS.
15
239f9db9
PE
16 * font.c, fontset.c: Make symbols static if they're not exported.
17 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
18 (FACE_SUITABLE_FOR_CHAR_P): Use it.
19 * font.c (font_close_object): Now static.
20 * font.h (font_close_object): Remove.
21 * fontset.c (FONTSET_OBJLIST): Remove.
22 (free_realized_fontset) #if-0 the body, which does nothing.
23 (face_suitable_for_char_p): #if-0, as it's never called.
24 * fontset.h (face_suitable_for_char_p): Remove decl.
25 * xfaces.c (face_at_string_position): Use
26 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
27 since 0 is always ASCII.
28
dfcf3579
PE
29 * fns.c (weak_hash_tables): Now static.
30
5045092b
PE
31 * fileio.c: Make symbols static if they're not exported.
32 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
33 (Vwrite_region_annotation_buffers): Now static.
34
57a96f5c
PE
35 * eval.c: Make symbols static if they're not exported.
36 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
37 * lisp.h (backtrace_list): Remove decl.
38
35f08c38
PE
39 * emacs.c: Make symbols static if they're not exported.
40 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
41 (fatal_error_code, fatal_error_signal_hook, standard_args):
42 Now static.
43 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
44 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
45 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
46 * lisp.h (fatal_error_signal_hook): Remove decl.
47 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
48
f44bd759
PE
49 * editfns.c: Move a (normally-unused) function to its only use.
50 * editfns.c, lisp.h (get_operating_system_release): Remove.
51 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
52 worth the hassle of breaking this out.
53
b532497d
PE
54 * xterm.c: Make symbols static if they're not exported.
55 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
56 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
57 (x_destroy_window, x_delete_display):
58 Now static.
59 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
60 (x_mouse_leave): Remove; unused.
61 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
62 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
63 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
64 Remove decls.
65 (x_mouse_leave): Declare only if WINDOWSNT.
66 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
67 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
68 USE_X_TOOLKIT.
69
a25f4dfa
PE
702011-04-12 Paul Eggert <eggert@cs.ucla.edu>
71
1675728f
PE
72 * ftxfont.c: Make symbols static if they're not exported.
73 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
74 HAVE_FREETYPE.
75 * font.h (ftxfont_driver): Likewise.
76
e4cebfca
PE
77 * xfns.c: Make symbols static if they're not exported.
78 (x_last_font_name, x_display_info_for_name):
79 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
80 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
81 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
82 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
83 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
84 (last_show_tip_args): Now static.
85 (xic_defaut_fontset, xic_create_fontsetname): Define only if
86 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
87 (x_screen_planes): Remove; unused.
88 * dispextern.h (x_screen_planes): Remove decl.
89
5bf46f05
PE
90 * dispnew.c: Make symbols static if they're not exported.
91 * dispextern.h (redraw_garbaged_frames, scrolling):
92 (increment_row_positions): Remove.
93 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
94 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
95 Now static.
96 (redraw_garbaged_frames): Remove; unused.
97
435f4c28
PE
98 * xfaces.c: Make symbols static if they're not exported.
99 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
100 Remove decls.
101 * xterm.h (defined_color): Remove decls.
102 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
103 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
104 (menu_face_changed_default, defined_color, free_realized_face):
105 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
106 (ascii_face_of_lisp_face): Remove; unused.
107
8524aef3
PE
108 * xdisp.c: Make symbols static if they're not exported.
109 * dispextern.h (scratch_glyph_row, window_box_edges):
110 (glyph_to_pixel_coords, set_cursor_from_row):
111 (get_next_display_element, set_iterator_to_next):
112 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
113 (show_mouse_face): Remove decls
114 * frame.h (message_buf_print): Likewise.
115 * lisp.h (pop_message, set_message, check_point_in_composition):
116 Likewise.
117 * xterm.h (set_vertical_scroll_bar): Likewise.
118 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
119 (message_buf_print, scratch_glyph_row, displayed_buffer):
120 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
121 (get_next_display_element, show_mouse_face, window_box_edges):
122 (frame_to_window_pixel_xy, check_point_in_composition):
123 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
124 (glyph_to_pixel_coords): Remove; unused.
125
16390cd2
PE
126 * dired.c (file_name_completion): Now static.
127
128 * dbusbind.c (xd_in_read_queued_messages): Now static.
129
a25f4dfa
PE
130 * lisp.h (circular_list_error, FOREACH): Remove; unused.
131 * data.c (circular_list_error): Remove.
132
16a97296
PE
1332011-04-11 Paul Eggert <eggert@cs.ucla.edu>
134
14a9c8df
PE
135 * commands.h (last_point_position, last_point_position_buffer):
136 (last_point_position_window): Remove decls.
137 * keyboard.c: Make these variables static.
138
74ab6df5
PE
139 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
140 decls.
141 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
142 (iso_code_class, detect_coding, code_convert_region): Now static.
143 (encode_coding_gap): Remove; unused.
144
38dfbee1
PE
145 * chartab.c (chartab_chars, chartab_bits): Now static.
146
a2cb4e63
PE
147 * charset.h (charset_iso_8859_1): Remove decl.
148 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
149 Now static.
150
127198fd
PE
151 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
152 * ccl.c (Vccl_program_table): Now static.
153 (check_ccl_update): Remove; unused.
154
d85b608f
PE
155 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
156 * category.h: ... from here.
157 * category.c (check_category_table, set_category_set): Now static.
158
31cd66f3
PE
159 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
160 * lisp.h: Remove these decls.
161
c358e587
PE
162 * buffer.c (buffer_count): Remove unused var.
163
e78aecca
PE
164 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
165 so that it's not optimized away.
166 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
167 * dispextern.h (bidi_dump_cached_states): Remove, since it's
168 exported only to the debugger.
169
e192d7d3
PE
170 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
171 * atimer.h (run_all_atimers): Removed; not exported.
172
92470028
PE
173 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
174 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
175 was inaccessible from Lisp.
176 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
177 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
178
244ed907
PE
179 alloc.c: Import and export fewer symbols, and remove unused items.
180 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
181 is defined.
182 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
183 it's not optimized away by whole-program optimization.
184 (message_enable_multibyte, free_misc): Remove.
185 (catchlist, handlerlist, mark_backtrace):
186 Declare only if BYTE_MARK_STACK.
187 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
188 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
189 (message_enable_multibyte): Remove decl.
190 (free_misc, interval_free_list, float_block, float_block_index):
191 (n_float_blocks, float_free_list, cons_block, cons_block_index):
192 (cons_free_list, last_marked_index):
193 Now static.
194 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
195 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
196 (mark_backtrace): Define only if BYTE_MARK_STACK.
197 * xdisp.c (message_enable_multibyte): Now static.
198
955cbe7b
PE
199 Declare Lisp_Object Q* variables to be 'static' if not exproted.
200 This makes it easier for human readers (and static analyzers)
201 to see whether these variables are used from other modules.
202 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
203 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
204 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
205 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
206 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
207 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
208 * xmenu.c, xselect.c:
209 Declare Q* vars static if they are not used in other modules.
210 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
211 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
212 Remove decls of unexported vars.
213 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
214
95c82688
PE
215 * lisp.h (DEFINE_FUNC): Make sname 'static'.
216
16a97296
PE
217 Make Emacs functions such as Fatom 'static' by default.
218 This makes it easier for human readers (and static analyzers)
219 to see whether these functions can be called from other modules.
220 DEFUN now defines a static function. To make the function external
221 so that it can be used in other C modules, use the new macro DEFUE.
222 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
223 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
224 static function definition. Use DEFUE if you want an extern one.
225 (DEFUE, INFUN): New macros.
226 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
227 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
228 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
229 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
230 Remove decls, since these functions are now static.
231 (Funintern, Fget_internal_run_time): New decls, since these functions
232 were already external.
95c82688 233
16a97296
PE
234 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
235 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
236 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
237 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
238 * keyboard.c, keymap.c, lread.c:
239 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
240 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
241 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
242 Mark functions with DEFUE instead of DEFUN,
243 if they are used in other modules.
244 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
245 decls for now-static functions.
246 * buffer.h (Fdelete_overlay): Remove decl.
247 * callproc.c (Fgetenv_internal): Mark as internal.
248 * composite.c (Fremove_list_of_text_properties): Remove decl.
249 (Fcomposition_get_gstring): New forward static decl.
250 * composite.h (Fcomposite_get_gstring): Remove decl.
251 * dired.c (Ffile_attributes): New forward static decl.
252 * doc.c (Fdocumntation_property): New forward static decl.
253 * eval.c (Ffetch_bytecode): New forward static decl.
254 (Funintern): Remove extern decl; now in .h file where it belongs.
255 * fileio.c (Fmake_symbolic_link): New forward static decl.
256 * image.c (Finit_image_library): New forward static decl.
257 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
258 * intervals.h (Fprevious_property_change):
259 (Fremove_list_of_text_properties): Remove decls.
260 * keyboard.c (Fthis_command_keys): Remove decl.
261 (Fcommand_execute): New forward static decl.
262 * keymap.c (Flookup_key): New forward static decl.
263 (Fcopy_keymap): Now static.
264 * keymap.h (Flookup_key): Remove decl.
265 * process.c (Fget_process): New forward static decl.
266 (Fprocess_datagram_address): Mark as internal.
267 * syntax.c (Fsyntax_table_p): New forward static decl.
268 (skip_chars): Remove duplicate decl.
269 * textprop.c (Fprevious_property_change): New forward static decl.
270 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
271 Now internal.
272 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
273 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
274
785bbd42
PE
2752011-04-10 Paul Eggert <eggert@cs.ucla.edu>
276
277 * editfns.c (Fformat): Remove unreachable code.
278
4073e537 2792011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 280
b2ded58d
PE
281 Fix more problems found by GCC 4.6.0's static checks.
282
7d66342c
PE
283 * xdisp.c (vmessage): Use a better test for character truncation.
284
bbf47d44
PE
285 * charset.c (load_charset_map): <, not <=, for optimization,
286 and to avoid potential problems with integer overflow.
9248994d 287 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 288 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 289 * editfns.c (Fformat): Likewise.
1e69125e 290 * syntax.c (skip_chars): Likewise.
3befa583 291
e3019616
PE
292 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
293 This also lets GCC 4.6.0 generate slightly better loop code.
294
becfa255
PE
295 * callint.c (Fcall_interactively): <, not <=, for optimization.
296 (Fcall_interactively): Count the number of arguments produced,
297 not the number of arguments given. This is simpler and lets GCC
298 4.6.0 generate slightly better code.
299
dae0cd48
PE
300 * ftfont.c: Distingish more carefully between FcChar8 and char.
301 The previous code passed unsigned char * to a functions like
302 strlen and xstrcasecmp that expect char *, which does not
303 conform to the C standard.
304 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
305 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
306 char * when the C standard requires it.
307
76032d70
PE
308 * keyboard.c (read_char): Remove unused var.
309
eb3f1cc8
PE
310 * eval.c: Port to Windows vsnprintf (Bug#8435).
311 Include <limits.h>.
312 (SIZE_MAX): Define if the headers do not.
313 (verror): Do not give up if vsnprintf returns a negative count.
314 Instead, grow the buffer. This ports to Windows vsnprintf, which
315 does not conform to C99. Problem reported by Eli Zaretskii.
316 Also, simplify the allocation scheme, by avoiding the need for
317 calling realloc, and removing the ALLOCATED variable.
318
70476b54
PE
319 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
320
12020a9e
PE
321 Remove invocations of doprnt, as Emacs now uses vsnprintf.
322 But keep the doprint source code for now, as we might revamp it
323 and use it again (Bug#8435).
ea6c7ae6
PE
324 * lisp.h (doprnt): Remove.
325 * Makefile.in (base_obj): Remove doprnt.o.
326 * deps.mk (doprnt.o): Remove.
327
5fdb398c
PE
328 error: Print 32- and 64-bit integers portably (Bug#8435).
329 Without this change, on typical 64-bit hosts error ("...%d...", N)
330 was used to print both 32- and 64-bit integers N, which relied on
331 undefined behavior.
332 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
333 New macro.
334 * lisp.h (error, verror): Mark as printf-like functions.
335 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
336 Report overflow in size calculations when allocating printf buffer.
337 Do not truncate output string at its first null byte.
338 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
339 Truncate the output at a character boundary, since vsnprintf does not
340 do that.
341 * charset.c (check_iso_charset_parameter): Convert internal
342 character to string before calling 'error', since %c now has the
343 printf meaning.
344 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
345 overflow when computing char to be passed to 'error'. Do not
346 pass Lisp_Object to 'error'; pass the integer instead.
347 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
348 formatted with plain %d.
349
b189fa66
PE
350 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
351
bff87ef0
PE
352 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
353
7e2cac20
PE
354 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
355
ce4d90b5
PE
356 * xterm.c (x_catch_errors): Remove duplicate declaration.
357
266c9547
PE
358 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
359
79c49ad2
PE
360 * xdisp.c, lisp.h (message_nolog): Remove; unused.
361
368f4090
JM
3622011-04-10 Jim Meyering <meyering@redhat.com>
363
364 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
365 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
366 return ssize_t not "int", and use size_t as the buffer length.
367 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
368 * gnutls.h: Update declarations.
369 * process.c (read_process_output): Use ssize_t, to match.
370 (send_process): Likewise.
371
a32d4040
CY
3722011-04-09 Chong Yidong <cyd@stupidchicken.com>
373
374 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
375
8546720e 3762011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 377
8546720e
GM
378 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
379 unsigned char, to match FcChar8 type definition.
aac0c6e3 380
8546720e
GM
381 * xterm.c (handle_one_xevent):
382 * xmenu.c (create_and_show_popup_menu):
383 * xselect.c (x_decline_selection_request)
384 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 385
a53e2e89
EZ
3862011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
387
388 Fix some uses of `int' instead of EMACS_INT.
389 * search.c (string_match_1, fast_string_match)
390 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
391 (scan_buffer, find_next_newline_no_quit)
392 (find_before_next_newline, search_command, Freplace_match)
393 (Fmatch_data): Make some `int' variables be EMACS_INT.
394
395 * xdisp.c (display_count_lines): 3rd argument and return value now
396 EMACS_INT. All callers changed.
397 (pint2hrstr): Last argument is now EMACS_INT.
398
399 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
400 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
401 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
402 (decode_coding_utf_16, decode_coding_emacs_mule)
403 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
404 (decode_coding_ccl, decode_coding_charset)
405 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
406 (decode_coding_iso_2022, decode_coding_emacs_mule)
407 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
408 <char_offset, last_offset>: Declare EMACS_INT.
409 (encode_coding_utf_8, encode_coding_utf_16)
410 (encode_coding_emacs_mule, encode_invocation_designation)
411 (encode_designation_at_bol, encode_coding_iso_2022)
412 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
413 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
414 Declare EMACS_INT.
415 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
416 (encode_invocation_designation): Last argument P_NCHARS is now
417 EMACS_INT.
418 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
419 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
420
421 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
422 All users changed.
423
424 * ccl.c (Fccl_execute_on_string): Declare some variables
425 EMACS_INT.
426
8546720e 4272011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
428
429 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
430
4e19a977
CS
4312011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
432
433 * process.c (Fformat_network_address): Doc fix.
434
87302331
R
4352011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
436
437 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
438
cbb59342
CY
4392011-04-08 Chong Yidong <cyd@stupidchicken.com>
440
441 * keyboard.c (read_char): Call Lisp function help-form-show,
442 instead of using internal_with_output_to_temp_buffer.
443 (Qhelp_form_show): New var.
e0d38eeb 444 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
445
446 * print.c (internal_with_output_to_temp_buffer): Function deleted.
447
448 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
449
e67a13ab
CY
4502011-04-06 Chong Yidong <cyd@stupidchicken.com>
451
452 * process.c (Flist_processes): Removed to Lisp.
453 (list_processes_1): Deleted.
454
973f782d
EZ
4552011-04-06 Eli Zaretskii <eliz@gnu.org>
456
7c106b1e
EZ
457 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
458
973f782d
EZ
459 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
460
41cf7d1a 4612011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 462
ca23cc88
PE
463 Fix more problems found by GCC 4.6.0's static checks.
464
f390e2d5
PE
465 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
466
42eea0d0
PE
467 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
468
b69769da 469 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 470
f9541e84
PE
471 * xdisp.c (vmessage): Mark as a printf-like function.
472
13841b55
PE
473 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
474
c136c10f
PE
475 * sound.c (sound_warning): Don't crash if arg contains a printf format.
476
5e2d4a30
PE
477 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
478 printf-like functions.
479 (tiff_load): Add casts to remove these marks before passing them
480 to system-supplied API.
481
583f48b9
PE
482 * eval.c (Fsignal): Remove excess argument to 'fatal'.
483
b25d760e
PE
484 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
485 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
486 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
487 directly, rather than having caller test rule sign. This avoids
488 some unnecessary tests.
489 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
490 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
491 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 492
bc7b6697 493 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 494 (xfont_open): Avoid unnecessary tests.
bc7b6697 495
27ccc379
PE
496 * composite.c (composition_gstring_put_cache): Use unsigned integer.
497
dcd5c89a
PE
498 * composite.h, composite.c (composition_gstring_put_cache):
499 Use EMACS_INT, not int, for length.
500
b13a45c6
PE
501 * composite.h (COMPOSITION_DECODE_REFS): New macro,
502 breaking out part of COMPOSITION_DECODE_RULE.
503 (COMPOSITION_DECODE_RULE): Use it.
504 * composite.c (get_composition_id): Remove unused local vars,
505 by using the new macro.
506
1e792e4d
PE
507 * textprop.c (set_text_properties_1): Change while to do-while,
508 since the condition is always true at first.
509
dc6c6455 510 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
511 (interval_deletion_adjustment): Return unsigned value.
512 All uses changed.
dc6c6455 513
aba7731a
PE
514 * process.c (list_processes_1, create_pty, read_process_output):
515 (exec_sentinel): Remove vars that were set but not used.
afd4052b 516 (create_pty): Remove unnecessary "volatile"s.
bc57d757 517 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 518 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 519 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 520
fdfc4bf3
PE
521 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
522
fca8fe46 523 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 524 (update_syntax_table): Use unsigned instead of int.
fca8fe46 525
06a0259a 526 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 527 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 528 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 529
e7b9e80f
PE
530 * print.c (print_error_message): Avoid int overflow.
531
56201685
PE
532 * font.c (font_list_entities): Redo for clarity,
533 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
534
78834453 535 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 536 (font_score): Avoid potential overflow in diff calculation.
78834453 537
0bc0b309 538 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 539 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 540
e610eaca
PE
541 * eval.c (funcall_lambda): Rename local to avoid shadowing.
542
b895abce
PE
543 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
544 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
545 can always succeed if overflow has undefined behavior.
546
1f1d9321 547 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 548 (wordify): Omit three unnecessary tests.
1f1d9321 549
c59478bc
PE
550 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
551 All callers changed. This avoids the need for an unused var.
552
79b73827
PE
553 * casefiddle.c (casify_region): Remove var that is set but not used.
554
a4db5dfe
PE
555 * dired.c (file_name_completion): Remove var that is set but not used.
556
43aae36e
PE
557 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
558
2a47c44d 559 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 560 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 561
a37c69bf
PE
562 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
563 Check for integer overflow on size calculations.
564
328ab8e7
PE
565 * buffer.c (Fprevious_overlay_change): Remove var that is set
566 but not used.
567
e5a2a5cb
PE
568 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
569 Remove vars that are set but not used.
8d84a6eb 570 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 571 (timer_check_2): Mark vars as initialized.
e5a2a5cb 572
a60e5f68
PE
573 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
574
f661cb61 575 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 576 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 577
f0397f5a
PE
578 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
579 that are set but not used.
580
8664db06 581 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 582 if XCreateBitmapFromData fails (Bug#8410).
8664db06 583
6abdaa4a
PE
584 * xselect.c (x_get_local_selection, x_handle_property_notify):
585 Remove vars that are set but not used.
586
0ce7538d 587 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 588 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 589
9ae848fc
PE
590 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
591 Remove var that is set but not used.
0b918413
PE
592 (scroll_bar_windows_size): Now size_t, not int.
593 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
594 Check for overflow.
9ae848fc 595
a5a62657
PE
596 * xfaces.c (realize_named_face): Remove vars that are set but not used.
597 (map_tty_color) [!defined MSDOS]: Likewise.
598
5c5cdd39
PE
599 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
600
66ebf983
PE
601 * coding.c: Remove vars that are set but not used.
602 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
603 All callers changed.
604 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
605 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
606 (decode_coding_charset): Remove vars that are set but not used.
607
1be4d761
PE
608 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
609 that is set but not used.
610
47553fa8
PE
611 * print.c (print_object): Remove var that is set but not used.
612
1f7196bf 613 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
614 The gnulib version avoids calling malloc in the usual case,
615 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
616 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
617 * filelock.c (current_lock_owner): Likewise.
618 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
619 * sysdep.c: Include allocator.h, careadlinkat.h.
620 (emacs_no_realloc_allocator): New static constant.
621 (emacs_readlink): New function.
fdb61804
PE
622 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
623 ../lib/careadlinkat.h.
d1fdcab7 624
f84c17c7
SM
6252011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
626
627 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
628 first non-nil return value).
629
ef3862ad
JD
6302011-04-03 Jan Djärv <jan.h.d@swipnet.se>
631
632 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
633 if not defined (Bug#8403).
634
376a7006
JB
6352011-04-02 Juanma Barranquero <lekktu@gmail.com>
636
637 * xdisp.c (display_count_lines): Remove parameter `start',
638 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
639 (get_char_face_and_encoding): Remove parameter `multibyte_p',
640 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
641 (fill_stretch_glyph_string): Remove parameters `row' and `area',
642 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
643 and thereabouts. All callers changed.
644 (get_per_char_metric): Remove parameter `f', unused since
645 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
646
6ca3801d
JM
6472011-04-02 Jim Meyering <meyering@redhat.com>
648
649 do not dereference NULL upon failed strdup
650 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
651 (ns_get_family): Likewise.
652
d8e2b5ba
JB
6532011-04-02 Juanma Barranquero <lekktu@gmail.com>
654
655 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
656
8c74fcbd
JD
6572011-04-02 Jan Djärv <jan.h.d@swipnet.se>
658
659 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
660 later (Bug#8403).
661
7200d79c
SM
6622011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
663
03408648 664 Add lexical binding.
7200d79c 665
03408648
SM
666 * window.c (Ftemp_output_buffer_show): New fun.
667 (Fsave_window_excursion):
668 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
669
670 * lread.c (lisp_file_lexically_bound_p): New function.
671 (Fload): Bind Qlexical_binding.
672 (readevalloop): Remove `evalfun' arg.
673 Bind Qinternal_interpreter_environment.
674 (Feval_buffer): Bind Qlexical_binding.
675 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
676 Mark as dynamic.
677 (syms_of_lread): Declare `lexical-binding'.
678
679 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
680
681 * keyboard.c (eval_dyn): New fun.
682 (menu_item_eval_property): Use it.
ca105506
SM
683
684 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 685
03408648
SM
686 * fns.c (concat, mapcar1): Accept byte-code-functions.
687
688 * eval.c (Fsetq): Handle lexical vars.
689 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
690 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
691 (FletX, Flet): Obey lexical binding.
692 (Fcommandp): Handle closures.
693 (Feval): New `lexical' arg.
694 (eval_sub): New function extracted from Feval. Use it almost
695 everywhere where Feval was used. Look up vars in lexical env.
696 Handle closures.
697 (Ffunctionp): Move from subr.el.
698 (Ffuncall): Handle closures.
699 (apply_lambda): Remove `eval_flags'.
700 (funcall_lambda): Handle closures and new byte-code-functions.
701 (Fspecial_variable_p): New function.
702 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
703 but without exporting it to Lisp.
23aba0ea 704
23aba0ea 705 * doc.c (Fdocumentation, store_function_docstring):
03408648 706 * data.c (Finteractive_form): Handle closures.
23aba0ea 707
03408648
SM
708 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
709 interactive spec.
ba83908c 710
03408648
SM
711 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
712 byte-codes.
713 (exec_byte_code): New function extracted from Fbyte_code to handle new
714 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 715
03408648 716 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 717
03408648 718 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 719
e2abce01
JB
7202011-03-31 Juanma Barranquero <lekktu@gmail.com>
721
722 * xdisp.c (redisplay_internal): Fix prototype.
723
63696a73 7242011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 725
63696a73
EZ
726 * xdisp.c (SCROLL_LIMIT): New macro.
727 (try_scrolling): Use it when setting scroll_limit. Limit
728 scrolling to 100 screen lines.
729 (redisplay_window): Even when falling back on "recentering",
730 position point in the window according to scroll-conservatively,
731 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
732
733 (try_scrolling): When point is above the window, allow searching
734 as far as scroll_max, or one screenful, to compute vertical
735 distance from PT to the scroll margin position. This prevents
736 try_scrolling from unnecessarily failing when
737 scroll-conservatively is set to a value slightly larger than the
738 window height. Clean up the case of PT below the margin at bottom
739 of window: scroll_max can no longer be INT_MAX. When aggressive
740 scrolling is in use, don't let point enter the opposite scroll
741 margin as result of the scroll.
742 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
743 threshold of 100 lines for never-recentering scrolling.
744
e4cc2dfc
JB
7452011-03-31 Juanma Barranquero <lekktu@gmail.com>
746
747 * dispextern.h (move_it_by_lines):
748 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
749 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
750 (message_log_check_duplicate): Remove parameters `prev_bol' and
751 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
752 (redisplay_internal): Remove parameter `preserve_echo_area',
753 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
754
755 * indent.c (Fvertical_motion):
756 * window.c (window_scroll_pixel_based, Frecenter):
757 Don't pass `need_y_p' to `move_it_by_lines'.
758
1c470562
SM
7592011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
760
44f230aa
SM
761 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
762 steal a few bits to be more compact.
763 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
764 Remove unneeded casts.
765
1c470562
SM
766 * bytecode.c (Fbyte_code): CAR and CDR can GC.
767
888adce9
ZK
7682011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
769
770 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
771 binding" message (bug#7967).
772
f838ed7b
PE
7732011-03-30 Paul Eggert <eggert@cs.ucla.edu>
774
77861b95
PE
775 Fix more problems found by GCC 4.6.0's static checks.
776
de6dbc14
PE
777 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
778 Remove unused local var.
779
f838ed7b
PE
780 * editfns.c (Fmessage_box): Remove unused local var.
781
792c7b2b
PE
782 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
783 (note_mode_line_or_margin_highlight, note_mouse_highlight):
784 Omit unused local vars.
c499e557 785 * window.c (shrink_windows): Omit unused local var.
b01a1c29 786 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
787 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
788 Omit unused local var.
789
ba0165e1
PE
790 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
791 Don't assume string length fits in int.
32ad8845 792 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 793 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 794
3c59b4c9
PE
795 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
796 instead of alloca (Bug#8344).
797
a3eed478 798 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 799 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 800
eb4d412d
PE
801 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
802
1658b401
PE
803 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
804 concerns.
805
806 * term.c (produce_glyphless_glyph): Remove unnecessary test.
807
808 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 809
9a2c6e05
PE
810 * keyboard.c (syms_of_keyboard): Use the same style as later
811 in this function when indexing through an array. This also
812 works around GCC bug 48267.
813
03d0a109
PE
814 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
815
44f730c8
PE
816 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
817
fe75f926
PE
818 * chartab.c (sub_char_table_ref_and_range): Redo for slight
819 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
820
ffa8c828
PE
821 * keyboard.c, keyboard.h (num_input_events): Now size_t.
822 This avoids undefined behavior on integer overflow, and is a bit
823 more convenient anyway since it is compared to a size_t variable.
824
c5101a77
PE
825 Variadic C functions now count arguments with size_t, not int.
826 This avoids an unnecessary limitation on 64-bit machines, which
827 caused (substring ...) to crash on large vectors (Bug#8344).
828 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
829 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 830 All variadic functions and their callers changed accordingly.
c5101a77
PE
831 (struct gcpro.nvars): Now size_t, not int. All uses changed.
832 * data.c (arith_driver, float_arith_driver): Likewise.
833 * editfns.c (general_insert_function): Likewise.
834 * eval.c (struct backtrace.nargs, interactive_p)
835 (internal_condition_case_n, run_hook_with_args, apply_lambda)
836 (funcall_lambda, mark_backtrace): Likewise.
837 * fns.c (concat): Likewise.
838 * frame.c (x_set_frame_parameters): Likewise.
839 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
840 0 if not found, not -1. All callers changed.
841
dd3f25f7
PE
842 * alloc.c (garbage_collect): Don't assume stack size fits in int.
843 (stack_copy_size): Now size_t, not int.
844 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
845
461c2ab9
JB
8462011-03-28 Juanma Barranquero <lekktu@gmail.com>
847
848 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
849 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
850 All callers changed.
851
852 * lisp.h (multibyte_char_to_unibyte):
853 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
854 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
855 * character.h (CHAR_TO_BYTE8):
856 * cmds.c (internal_self_insert):
857 * editfns.c (general_insert_function):
858 * keymap.c (push_key_description):
859 * search.c (Freplace_match):
860 * xdisp.c (message_dolog, set_message_1): All callers changed.
861
f6d62986
SM
8622011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
863
864 * keyboard.c (safe_run_hook_funcall): New function.
865 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
866 don't set the hook to nil, but remove the offending function instead.
867 (Qcommand_hook_internal): Remove, unused.
868 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
869 Vcommand_hook_internal.
870
871 * eval.c (enum run_hooks_condition): Remove.
872 (funcall_nil, funcall_not): New functions.
873 (run_hook_with_args): Call each function through a `funcall' argument.
874 Remove `cond' argument, now redundant.
875 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
876 (Frun_hook_with_args_until_failure): Adjust accordingly.
877 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
878
1db5b1ad
JB
8792011-03-28 Juanma Barranquero <lekktu@gmail.com>
880
881 * dispextern.h (string_buffer_position): Remove declaration.
882
883 * print.c (strout): Remove parameter `multibyte', unused since
884 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
885
886 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
887 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
888 All callers changed.
889
890 * w32.c (_wsa_errlist): Use braces for struct initializers.
891
892 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
893 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
894 All callers changed.
895 (string_buffer_position): Likewise. Also, make static (it's never
896 used outside xdisp.c).
897 (cursor_row_p): Remove parameter `w', unused since
898 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
899 (decode_mode_spec): Remove parameter `precision', introduced during
900 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
901 All callers changed.
902
5ffb62aa
JD
9032011-03-27 Jan Djärv <jan.h.d@swipnet.se>
904
905 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
906
461c2ab9 9072011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
908
909 * nsterm.m (ns_menu_bar_is_hidden): New variable.
910 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
911 (ns_update_auto_hide_menu_bar): New functions.
912 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
913 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
914 ns_constrain_all_frames.
915 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
916 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
917
5c380ffb
JD
9182011-03-27 Jan Djärv <jan.h.d@swipnet.se>
919
920 * nsmenu.m (runDialogAt): Remove argument to timer_check.
921
9af30bdf
GM
9222011-03-27 Glenn Morris <rgm@gnu.org>
923
924 * syssignal.h: Replace RETSIGTYPE with void.
925 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
926 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
927 Replace SIGTYPE with void everywhere.
928 * s/usg5-4-common.h (SIGTYPE): Remove definition.
929 * s/template.h (SIGTYPE): Remove commented out definition.
930
e2abce01
JB
9312011-03-26 Eli Zaretskii <eliz@gnu.org>
932
933 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
934 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
935
f868cd8a
JB
9362011-03-26 Juanma Barranquero <lekktu@gmail.com>
937
59eb0929
JB
938 * w32.c (read_unc_volume): Use parameter `henum', instead of
939 global variable `wget_enum_handle'.
940
941 * keymap.c (describe_vector): Remove parameters `indices' and
942 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
943 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
944
f868cd8a
JB
945 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
946
947 * keyboard.c (timer_check): Remove parameter `do_it_now',
948 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
949 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
950 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
951
952 * keyboard.c (read_char):
953 * w32menu.c (w32_menu_display_help):
954 * xmenu.c (show_help_event, menu_help_callback):
955 Adjust calls to `show_help_echo'.
956
957 * gtkutil.c (xg_maybe_add_timer):
958 * keyboard.c (readable_events):
959 * process.c (wait_reading_process_output):
960 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
961
962 * insdel.c (adjust_markers_gap_motion):
963 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
964 (gap_left, gap_right): Don't call it.
965
2ecf6fdb
CY
9662011-03-25 Chong Yidong <cyd@stupidchicken.com>
967
968 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
969 incurred during fontification.
970
6b1f9ba4
JB
9712011-03-25 Juanma Barranquero <lekktu@gmail.com>
972
973 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
974 (DEFVAR_PER_BUFFER): Don't pass it.
975
976 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
977 (scrolling_window): Don't pass it.
978
0f4a96b5
JB
9792011-03-25 Juanma Barranquero <lekktu@gmail.com>
980
981 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
982
983 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
984 and `suffix'.
985 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
986 of variables specific to SELinux and computation of `encoded_absname'.
987
988 * image.c (XPutPixel): Remove unused variable `height'.
989
990 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
991
992 * unexw32.c (get_section_info): Remove unused variable `section'.
993
994 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
995 (system_process_attributes): Remove unused variable `sess'.
996 (sys_read): Remove unused variable `err'.
997
998 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
999 (w32_wnd_proc): Remove unused variable `isdead'.
1000 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1001 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1002 (x_create_tip_frame): Remove unused variable `tem'.
1003
1004 * w32inevt.c (w32_console_read_socket):
1005 Remove unused variable `no_events'.
1006
1007 * w32term.c (x_draw_composite_glyph_string_foreground):
1008 Remove unused variable `width'.
1009
1149507c
JB
10102011-03-24 Juanma Barranquero <lekktu@gmail.com>
1011
1012 * w32term.c (x_set_glyph_string_clipping):
1013 Don't pass uninitialized region to CombineRgn.
1014
9c88f339
JB
10152011-03-23 Juanma Barranquero <lekktu@gmail.com>
1016
1017 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1018 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1019 (Fx_close_connection): Remove unused variable `i'.
1020
1021 * w32font.c (w32font_draw): Return number of glyphs.
1022 (w32font_open_internal): Remove unused variable `i'.
1023 (w32font_driver): Add missing initializer.
1024
1025 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1026 (fill_in_menu): Remove unused variable `items_added'.
1027
1028 * w32term.c (last_mouse_press_frame): Remove static global variable.
1029 (w32_clip_to_row): Remove unused variable `f'.
1030 (x_delete_terminal): Remove unused variable `i'.
1031
1032 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1033 (NOTHING): Remove unused static global variable.
1034 (uniscribe_check_otf): Remove unused variable `table'.
1035 (uniscribe_font_driver): Add missing initializers.
1036
dee091a3
JD
10372011-03-23 Julien Danjou <julien@danjou.info>
1038
1039 * term.c (Fsuspend_tty, Fresume_tty):
1040 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1041 * window.c (temp_output_buffer_show):
1042 * insdel.c (signal_before_change):
1043 * frame.c (Fhandle_switch_frame):
1044 * fileio.c (Fdo_auto_save):
1045 * emacs.c (Fkill_emacs):
1046 * editfns.c (save_excursion_restore):
1047 * cmds.c (internal_self_insert):
1048 * callint.c (Fcall_interactively):
1049 * buffer.c (Fkill_all_local_variables):
1050 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1051 Use Frun_hooks.
0f4a96b5 1052 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1053 unconditionnaly since it does the check itself.
1054
2c520ab5 10552011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1056
c9c49752
PE
1057 Fix more problems found by GCC 4.5.2's static checks.
1058
8abc3f12
PE
1059 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1060 the first time through the loop, since we know p0 < p1 then.
1061 This also avoids a gcc -Wstrict-overflow warning.
1062
a2d26660
PE
1063 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1064 leading to a memory leak, possible in functions like
1065 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1066 of objects (Bug#8318).
a2d26660 1067
916c72e9
PE
1068 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1069 that could (at least in theory) be that large.
1070
19ab8a18
PE
1071 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1072 This is less likely to overflow, and avoids undefined behavior if
1073 overflow does occur. All callers changed. Use strtoul to scan
1074 for the unsigned long integer.
b7cbbd6f
PE
1075 (pint2hrstr): Simplify and tune code slightly.
1076 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1077
f0641eff
PE
1078 * scroll.c (do_scrolling): Work around GCC bug 48228.
1079 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1080
7f650bb9
PE
1081 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1082 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1083 (validate_x_resource_name): Simplify count usage.
1084 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1085
37dd57d1
PE
1086 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1087 fail (Bug#8306).
81e56e61 1088
699979fc 1089 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1090
401bf9b4
PE
1091 * process.c (Fmake_network_process): Use socklen_t, not int,
1092 where POSIX says socklen_t is required in portable programs.
1093 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1094 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1095 (Fmake_network_process, server_accept_connection):
1096 (wait_reading_process_output, read_process_output):
1097 Likewise.
1098
b93aacde
PE
1099 * process.c: Rename or move locals to avoid shadowing.
1100 (list_processes_1, Fmake_network_process):
1101 (read_process_output_error_handler, exec_sentinel_error_handler):
1102 Rename or move locals.
4dc343ee 1103 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1104 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1105 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1106 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1107 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1108
af8a867c 1109 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1110 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1111 Include tparam.h instead, since it declares them.
af8a867c
PE
1112 * cm.h (PC): Remove extern decl; tparam.h now does this.
1113 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1114 * terminfo.c: Include tparam.h, to check interfaces.
1115 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1116 (tparam): Adjust signature to match interface in tparam.h;
1117 this removes some undefined behavior. Check that outstring and len
1118 are zero, which they always are with Emacs.
1119 * tparam.h (PC, BC, UP): New extern decls.
1120
0248044d 1121 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1122 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1123
8ff096c1 1124 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1125 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1126 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1127 (ftfont_list): Remove unused local.
49eaafba
PE
1128 (get_adstyle_property, ftfont_pattern_entity):
1129 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1130 Rename locals to avoid shadowing.
8ff096c1 1131
e2be39f6
PE
1132 * xfont.c (xfont_list_family): Mark var as initialized.
1133
c9735e30
PE
1134 * xml.c (make_dom): Now static.
1135
8f5201ae
PE
1136 * composite.c (composition_compute_stop_pos): Rename local to
1137 avoid shadowing.
b246f932
PE
1138 (composition_reseat_it): Remove unused locals.
1139 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1140 (composition_update_it): Mark var as initialized.
11b61122
PE
1141 (find_automatic_composition): Mark vars as initialized,
1142 with a FIXME (Bug#8290).
8f5201ae 1143
760fbc2c
PE
1144 character.h: Rename locals to avoid shadowing.
1145 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1146 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1147 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1148 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1149 to avoid shadowing.
1150
ff08eb85
PE
1151 * textprop.c (property_change_between_p): Remove; unused.
1152
fc7bf025
PE
1153 * intervals.c (interval_start_pos): Now static.
1154
235d7abc
PE
1155 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1156
44f230aa
SM
1157 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1158 Rename locals to avoid shadowing.
3e7d6594 1159
50060332
PE
1160 * sound.c (wav_play, au_play, Fplay_sound_internal):
1161 Fix pointer signedness.
d01f234b 1162 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1163 (wav_play): Initialize a variable to 0, to prevent undefined
1164 behavior (Bug#8278).
50060332 1165
c4fc4e30
PE
1166 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1167
918436ed
PE
1168 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1169
c939f91b
PE
1170 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1171 clobbering (Bug#8298).
b9c7f648
PE
1172 * sysdep.c (sys_subshell): Likewise.
1173 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1174
6bd8c144
PE
1175 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1176 This should get cleaned up, so that child_setup has the
1177 same signature on all platforms.
1178
7710357c 1179 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1180 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1181
c59da222
CY
11822011-03-22 Chong Yidong <cyd@stupidchicken.com>
1183
1184 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1185 not to be necessary, and produces flickering.
1186
66b87493
GM
11872011-03-20 Glenn Morris <rgm@gnu.org>
1188
1189 * config.in: Remove file.
1190
45b6f6d5
JB
11912011-03-20 Juanma Barranquero <lekktu@gmail.com>
1192
1193 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1194 are now in src/globals.h.
1195 (syms_of_minibuf): Remove spurious & from previous change.
1196
3ec03f7e
LL
11972011-03-20 Leo <sdl.web@gmail.com>
1198
1199 * minibuf.c (completing-read-function): New variable.
1200 (completing-read-default): Rename from completing-read.
1201 (completing-read): Call completing-read-function.
1202
b14e3e21
CY
12032011-03-19 Juanma Barranquero <lekktu@gmail.com>
1204
1205 * xfaces.c (Fx_load_color_file):
1206 Read color file from absolute filename (bug#8250).
1207
f2b726e6
JB
12082011-03-19 Juanma Barranquero <lekktu@gmail.com>
1209
1210 * makefile.w32-in: Update dependencies.
1211
09f6ff02
EZ
12122011-03-17 Eli Zaretskii <eliz@gnu.org>
1213
1214 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1215
29a6015a
PE
12162011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1217
a3a6c54e
PE
1218 Fix more problems found by GCC 4.5.2's static checks.
1219
b766f867
PE
1220 * process.c (make_serial_process_unwind, send_process_trap):
1221 (sigchld_handler): Now static.
1222
be02381c
PE
1223 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1224 That way, the code declares only the vars that it needs.
1225 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1226 * s/cygwin.h (PTY_ITERATION): Likewise.
1227 * s/darwin.h (PTY_ITERATION): Likewise.
1228 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1229
57048744
PE
1230 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1231 * process.c (allocate_pty): Don't declare stb unless it's needed.
1232
7914961c 1233 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1234 (CONSTANTLIM): Remove; unused.
1235 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1236 Define only if needed.
7914961c 1237
b3967b18
PE
1238 * unexelf.c (unexec): Name an expression,
1239 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1240 Use a different way to cause a compilation error if anyone uses
1241 n rather than nn, a way that does not involve shadowing.
73366a00 1242 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1243
29a6015a
PE
1244 * deps.mk (unexalpha.o): Remove; unused.
1245
43cfc33e 1246 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1247 * unexec.h: New file.
ce701a33
PE
1248 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1249 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1250 Depend on unexec.h.
1251 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1252 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1253 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1254 Change as necessary to match prototype in unexec.h.
ce701a33 1255
01f44d5a
PE
1256 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1257 shadowing.
4f63c6bb 1258 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1259
a6670b0b
PE
1260 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1261 Rename locals to avoid shadowing.
1262
cef2010d 1263 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1264 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1265
d4d7173a
PE
1266 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1267
f08b802a
PE
1268 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1269 warning when compiling print.c.
1270
3ddb0639
PE
1271 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1272 instead of using an uninitialized var.
5ad03b97 1273 (font_sort_entities): Mark var as initialized.
3ddb0639 1274
170a2692
PE
1275 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1276
e663c700
PE
1277 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1278 pointers to constants.
89bc529a 1279 (font_parse_fcname): Remove unused vars.
7b81e2d0 1280 (font_delete_unmatched): Now static.
ea838e10 1281 (font_get_spec): Remove; unused.
13a547c6
PE
1282 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1283 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1284 Rename or move locals to avoid shadowing.
e663c700 1285
2a80c887 1286 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1287 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1288
1384fa33 1289 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1290 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1291
8b2c52e9
PE
1292 * alloc.c (mark_backtrace): Move decl from here ...
1293 * lisp.h: ... to here, so that it can be checked.
1294
475545b5 1295 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1296 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1297 (lisp_indirect_variable): Name an expression,
1298 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1299 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1300
b1349114 1301 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1302 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1303 Use const pointer when appropriate.
b1349114 1304
a2928364
PE
1305 * lisp.h (get_system_name, get_operating_system_release):
1306 Move decls here, to check interfaces.
1307 * process.c (get_operating_system_release): Move decl to lisp.h.
1308 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1309 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1310 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1311 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1312 (Fformat_time_string, Fencode_time, Finsert_char):
1313 (Ftranslate_region_internal, Fformat):
1314 Rename or remove local vars to avoid shadowing.
9710023e 1315 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1316
a415e694
PE
1317 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1318 avoid shadowing.
1319
8ef4622d
PE
1320 * lisp.h (eassert): Check that the argument compiles, even if
1321 ENABLE_CHECKING is not defined.
1322
946f9a5b
PE
1323 * data.c (Findirect_variable): Name an expression, to avoid
1324 gcc -Wbad-function-cast warning.
112396d6 1325 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1326 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1327 (Fmake_variable_buffer_local, Fmake_local_variable):
1328 Mark variables as initialized.
52746918 1329 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1330
e5aab7e7 1331 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1332 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1333 Rename locals to avoid shadowing.
dff45157
PE
1334 (mark_stack): Move local variables into the #ifdef region where
1335 they're used.
7bc26fdb
PE
1336 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1337 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1338 needed otherwise.
1339 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1340 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1341 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1342
e5aab7e7
PE
1343 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1344 avoids undefined behavior in theory.
1345
4da60324
PE
1346 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1347
88043301
PE
1348 Use functions, not macros, for up- and down-casing (Bug#8254).
1349 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1350 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1351 to use the following functions instead of these macros.
1352 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1353 EMACS_INT, since callers assume the returned value fits in int.
1354 (upcase1): Likewise, for UPCASE_TABLE.
1355 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1356 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1357 the race-condition problem in the old DOWNCASE.
88043301 1358
19ed5445
PE
1359 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1360 Rename locals to avoid shadowing.
1361 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1362 (regex_compile, re_search_2, re_match_2_internal):
1363 Remove unused local vars.
952db0d7
PE
1364 (FREE_VAR): Rewrite so as not to use empty "else",
1365 which gcc can warn about.
da053e48 1366 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1367 (RETALLOC_IF): Define only if needed.
1368 (WORDCHAR_P): Likewise. This one is never needed, but is used
1369 only in a comment talking about a compiler bug, so put inside
1370 the #if 0 of that comment.
1371 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1372 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1373 Remove; unused.
19ed5445 1374
1f3561e4 1375 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1376 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1377 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1378
ded6f8f7
PE
1379 * search.c (simple_search): Remove unused var.
1380
dbd37a95
PE
1381 * dired.c (compile_pattern): Move decl from here ...
1382 * lisp.h: ... to here, so that it can be checked.
1383 (struct re_registers): New forward decl.
1384
7e47afad
PE
1385 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1386
85f24f61
PE
1387 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1388 All uses changed.
1389 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1390 Rename locals to avoid shadowing.
5671df8f 1391 (Fvertical_motion): Mark locals as initialized.
85f24f61 1392
181aa2be 1393 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1394 (casify_region): Mark local as initialized.
181aa2be 1395
930d429c
PE
1396 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1397
7082eac6
PE
1398 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1399 New macros, so that the caller can use some names other than
1400 gcpro1, gcpro2, etc.
1401 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1402 of the new macros.
1403 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1404 argument, for consistency with GCPRO2_VAR, etc: it is now the
1405 prefix of the variable, not the variable itself. All uses
1406 changed.
38b2c076
PE
1407 * dired.c (directory_files_internal, file_name_completion):
1408 Rename locals to avoid shadowing.
1409
15206ed9
PE
1410 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1411 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1412 dired.c's scmp function, had undefined behavior.
1413 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1414 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1415 * buffer.h: ... to here, because these macros use current_buffer,
1416 and the new implementation with inline functions needs to have
1417 current_buffer in scope now, rather than later when the macros
1418 are used.
1419 (downcase, upcase1): New static inline functions.
1420 (DOWNCASE, UPCASE1): Reimplement using these functions.
1421 This avoids undefined behavior in expressions like
1422 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1423 from race conditions in accessing the global variables
1424 case_temp1 and case_temp2.
1425 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1426 * lisp.h (case_temp1, case_temp2): Remove their decls.
1427 * character.h (ASCII_CHAR_P): Move from here ...
1428 * lisp.h: ... to here, so that the inline functions mentioned
1429 above can use them.
1430
4a6bea26
PE
1431 * dired.c (directory_files_internal_unwind): Now static.
1432
f14b7e14
PE
1433 * fileio.c (file_name_as_directory, directory_file_name):
1434 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1435 Now static.
2893f146
PE
1436 (file_name_as_directory): Use const pointers when appropriate.
1437 (Fexpand_file_name): Likewise. In particular, newdir might
1438 point at constant storage, so make it a const pointer.
fd4ead52 1439 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1440 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1441 signedness issues.
f839df0c
PE
1442 (Fset_file_times, Finsert_file_contents, auto_save_error):
1443 Rename locals to avoid shadowing.
f14b7e14 1444
5716756e 1445 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1446 (Ftry_completion, Fall_completions): Rename or remove locals
1447 to avoid shadowing.
5716756e 1448
b4c3046a
PE
1449 * marker.c (bytepos_to_charpos): Remove; unused.
1450
b45db522
PE
1451 * lisp.h (verify_bytepos, count_markers): New decls,
1452 so that gcc does not warn that these functions aren't declared.
1453
85876d07
PE
1454 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1455 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1456 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1457 (copy_text): Remove unused local var.
85876d07 1458
03d78a21 1459 * filelock.c (within_one_second): Now static.
b3dd38ab 1460 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1461
5df8f01b
PE
1462 * buffer.c (fix_overlays_before): Mark locals as initialized.
1463 (fix_start_end_in_overlays): Likewise. This function should be
1464 simplified by using pointers-to-pointers, but that's a different
1465 matter.
b1d876f1 1466 (switch_to_buffer_1): Now static.
8f54f30a
PE
1467 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1468 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1469
a70072c9 1470 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1471 Fix pointer signedness issue.
edced198
PE
1472 (sys_subshell): Mark local as volatile if checking for lint,
1473 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1474 (MAXPATHLEN): Define only if needed.
a70072c9 1475
a0977c44
PE
1476 * process.c (serial_open, serial_configure): Move decls from here ...
1477 * systty.h: ... to here, so that they can be checked.
1478
a884fdcc
PE
1479 * fns.c (get_random, seed_random): Move extern decls from here ...
1480 * lisp.h: ... to here, so that they can be checked.
1481
604efe86 1482 * sysdep.c (reset_io): Now static.
b8950c94 1483 (wait_for_termination_signal): Remove; unused.
604efe86 1484
38fc62d9
PE
1485 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1486 (copy_keymap_item, append_key, push_text_char_description):
1487 Now static.
1004a21a 1488 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1489 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1490 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1491 (describe_map_tree):
1492 Rename locals to avoid shadowing.
38fc62d9 1493
2f2650da
PE
1494 * keyboard.c: Declare functions static if they are not used elsewhere.
1495 (echo_char, echo_dash, cmd_error, top_level_2):
1496 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1497 (read_char, kbd_buffer_get_event, make_lispy_position):
1498 (make_lispy_event, make_lispy_movement, apply_modifiers):
1499 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1500 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1501 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1502 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1503 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1504
a053e86c 1505 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1506 (mark_kboards): Move decl here ...
1507 * alloc.c (mark_kboards): ... from here.
a053e86c 1508
4752793e
PE
1509 * lisp.h (force_auto_save_soon): New decl.
1510
74f10ca7 1511 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1512 (DEFINE_DUMMY_FUNCTION): New macro.
1513 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1514 Use it.
c03cd23f
PE
1515 (main): Add casts to avoid warnings
1516 if GCC considers string literals to be constants.
74f10ca7 1517
022e70d4
PE
1518 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1519
59d6fe83
PE
1520 * dbusbind.c: Pointer signedness fixes.
1521 (xd_signature, xd_append_arg, xd_initialize):
1522 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1523 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1524 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1525 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1526
78320123
PE
1527 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1528 if GCC considers string literals to be constants.
49cebcca 1529 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1530
35ac2a97
SM
15312011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1532
fb103ca9
SM
1533 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1534 (print_preprocess, print_object): New macro to fix last change.
1535
35ac2a97
SM
1536 * print.c (print_preprocess): Don't forget font objects.
1537
62973b41
JB
15382011-03-16 Juanma Barranquero <lekktu@gmail.com>
1539
1540 * emacs.c (USAGE3): Doc fixes.
1541
0e48bb22
AS
15422011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1543
1544 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1545 structure.
1546
7684e57b
JB
15472011-03-14 Juanma Barranquero <lekktu@gmail.com>
1548
1549 * lisp.h (VWindow_system, Qfile_name_history):
1550 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1551 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1552 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1553
1554 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1555 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1556
1557 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1558 * w32console.c (detect_input_pending, read_input_pending)
1559 (encode_terminal_code):
1560 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1561 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1562 (w32_system_caret_y, Qfile_name_history):
1563 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1564 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1565 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1566 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1567 * w32proc.c (Qlocal, report_file_error):
1568 * w32term.c (Vwindow_system, updating_frame):
1569 * w32uniscribe.c (initialized, uniscribe_font_driver):
1570 Remove unneeded extern declarations.
1571
2aa46d6c
CY
15722011-03-14 Chong Yidong <cyd@stupidchicken.com>
1573
c96bbc66 1574 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1575
cffc6f3b
CY
15762011-03-13 Chong Yidong <cyd@stupidchicken.com>
1577
1578 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1579 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1580 These macros can no longer be used for assignment.
1581
44f230aa
SM
1582 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1583 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1584 (record_buffer_markers, fetch_buffer_markers): New functions for
1585 recording and fetching special buffer markers.
1586 (set_buffer_internal_1, set_buffer_temp): Use them.
1587
1588 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1589
1590 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1591
1592 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1593 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1594
1595 * xdisp.c (hscroll_window_tree):
1596 (reconsider_clip_changes): Use PT instead of BUF_PT.
1597
d251f04b
EZ
15982011-03-13 Eli Zaretskii <eliz@gnu.org>
1599
1600 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1601 $(EMACS_ROOT)/lib/intprops.h.
1602
f0c77cd1
PE
16032011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1604
3eca4629
PE
1605 Fix more problems found by GCC 4.5.2's static checks.
1606
7c86ee98
PE
1607 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1608 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1609 (xg_free_frame_widgets): Make it clear that a local variable is
1610 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1611 (gdk_window_get_screen): Make it clear that this macro is needed
1612 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1613 (int_gtk_range_get_value): New function, which avoids a diagnostic
1614 from gcc -Wbad-function-cast.
1615 (xg_set_toolkit_scroll_bar_thumb): Use it.
1616 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1617 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1618 (get_utf8_string, xg_get_file_with_chooser):
1619 Rename locals to avoid shadowing.
1620 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1621
41729b81
PE
1622 * xgselect.c (xg_select): Remove unused var.
1623
f0c77cd1
PE
1624 * image.c (four_corners_best): Mark locals as initialized.
1625 (gif_load): Initialize transparent_p to zero (Bug#8238).
1626 Mark another local as initialized.
ec6cf4c6 1627 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1628
ce0ad53d 1629 * image.c (clear_image_cache): Now static.
d5d5a617 1630 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1631 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1632 (x_edge_detection): Remove unnecessary cast that
1633 gcc -Wbad-function-cast diagnoses.
2037898d 1634 (gif_load): Fix pointer signedness.
6ae141d6
PE
1635 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1636 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1637
33383987 16382011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1639
d32df629
PE
1640 Improve quality of tests for time stamp overflow.
1641 For example, without this patch (encode-time 0 0 0 1 1
1642 1152921504606846976) returns the obviously-bogus value (-948597
1643 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1644 reports time overflow. See
1645 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1646 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1647 * editfns.c: Include limits.h and intprops.h.
1648 (TIME_T_MIN, TIME_T_MAX): New macros.
1649 (time_overflow): Move earlier, to before first use.
1650 (hi_time, lo_time): New functions, for an accurate test for
1651 out-of-range times.
1652 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1653 (Fget_internal_run_time): Don't assume time_t fits in int.
1654 (make_time): Use list2 instead of Fcons twice.
1655 (Fdecode_time): More accurate test for out-of-range times.
1656 (check_tm_member): New function.
1657 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1658 (lisp_time_argument): Don't rely on undefined left-shift and
1659 right-shift behavior when checking for time stamp overflow.
8be6f318 1660
fe31d94c
PE
1661 * editfns.c (time_overflow): New function, refactoring common code.
1662 (Fformat_time_string, Fdecode_time, Fencode_time):
1663 (Fcurrent_time_string): Use it.
1664
8be6f318
PE
1665 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1666 * dired.c (make_time): Move to ...
1667 * editfns.c (make_time): ... here.
1668 * systime.h: Note the move.
1669
09d9db2c 16702011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1671
126bc0dc
YM
1672 * fringe.c (update_window_fringes): Remove unused variables.
1673
c47cbdfd
YM
1674 * unexmacosx.c (copy_data_segment): Also copy __got section.
1675 (Bug#8223)
1676
7ac80be9
EZ
16772011-03-12 Eli Zaretskii <eliz@gnu.org>
1678
c96bbc66 1679 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1680 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1681 Constify `char *' arguments and their references according to
1682 prototypes in tparam.h.
1683
ecb0f94d 1684 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1685
7ac80be9
EZ
1686 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1687 Adapt all references accordingly.
1688
1689 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1690
ef1fd07e
TT
16912011-03-11 Tom Tromey <tromey@redhat.com>
1692
1693 * buffer.c (syms_of_buffer): Remove obsolete comment.
1694
7ef4b50c
EZ
16952011-03-11 Eli Zaretskii <eliz@gnu.org>
1696
1697 * termhooks.h (encode_terminal_code): Declare prototype.
1698
1699 * msdos.c (encode_terminal_code): Don't declare prototype.
1700
1701 * term.c (encode_terminal_code): Now external again, used by
1702 w32console.c and msdos.c.
1703
44f230aa
SM
1704 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1705 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1706
4b1ec863 17072011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1708
1714f52b 1709 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1710
4b1ec863
PE
1711 * fringe.c (update_window_fringes): Mark locals as initialized
1712 (Bug#8227).
1713 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1714
524c7aa6
PE
1715 * alloc.c (mark_fringe_data): Move decl from here ...
1716 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1717 to check its interface.
1718 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1719
a5c0af81 1720 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1721 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1722 (fontset_font): Mark local as initialized.
a9a06e0b 1723 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1724
b4716021
PE
1725 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1726
811e9bac 1727 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1728 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1729 (x_own_selection, Fx_disown_selection_internal): Rename locals
1730 to avoid shadowing.
1731 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1732
7e3ab302
PE
1733 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1734 so that the caller can use some name other than gcpro1.
1735 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1736 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1737 (Fx_backspace_delete_keys_p):
1738 Use them to avoid shadowing, and rename vars to avoid shadowing.
1739 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1740 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1741 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1742 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1743 Remove unused locals.
7e3ab302
PE
1744 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1745 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1746 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1747 macros.
f78faa98 1748
e2b13473
PE
1749 * xterm.h (x_mouse_leave): New decl.
1750
77f23912
PE
1751 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1752 Remove unused functions.
cdf4ba58
PE
1753 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1754 (x_calc_absolute_position): Now static.
7411c686 1755 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1756 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1757 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1758 unless they are used.
38d0b34a
PE
1759 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1760 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1761 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1762 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1763 (x_error_catcher, x_connection_closed, x_error_handler):
1764 (x_error_quitter, xembed_send_message, x_iconify_frame):
1765 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1766 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1767 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1768
44f230aa
SM
1769 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1770 Rename or move locals to avoid shadowing.
6b463e58 1771 (tty_defined_color, merge_face_heights): Now static.
5967d051 1772 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1773 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1774 does not deduce is never used uninitialized.
73719eba
PE
1775 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1776 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1777
426994c3 1778 * terminal.c (store_terminal_param): Now static.
5489860b 1779
032f1620 1780 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1781 (set_frame_menubar): Remove unused local.
d4323972 1782 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1783 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1784 since they might point to immutable storage.
281585b0
PE
1785 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1786 since it's unused otherwise.
032f1620 1787
367c19e5 1788 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1789 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1790 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1791 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1792 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1793 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1794 does not deduce are never used uninitialized.
70739cbe 1795
07b48fa9
PE
1796 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1797
8868a238 1798 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1799 * window.c (window_loop, size_window):
1800 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1801
7e5cf297 1802 * window.c (display_buffer): Now static.
d6550a9f
PE
1803 (size_window): Mark variables that gcc -Wuninitialized
1804 does not deduce are never used uninitialized.
a586633d
PE
1805 * window.h (check_all_windows): New decl, to forestall
1806 gcc -Wmissing-prototypes diagnostic.
5b555da1 1807 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1808
f6095868
PE
1809 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1810 shadowing.
1811 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1812 Include <limits.h>.
1813 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1814 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1815 (load_charset_map): Mark variables that gcc -Wuninitialized
1816 does not deduce are never used uninitialized.
53df7c11 1817 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1818
f38b440c
PE
1819 * coding.c (coding_set_source, coding_set_destination):
1820 Use "else { /* comment */ }" rather than "else /* comment */;"
1821 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1822 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1823 a block, when the outer 'i' will do.
1824 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1825 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1826 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1827 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1828 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1829 Rename locals to avoid shadowing.
1830 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1831 * coding.c (emacs_mule_char, encode_invocation_designation):
1832 Now static, since they're not used elsewhere.
413bb2db 1833 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1834 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1835 (decode_coding_emacs_mule): Mark variables that gcc
1836 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1837 (detect_coding_iso_2022): Initialize a local variable that might
1838 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1839 this initialization is needed. (Bug#8211)
5f58e762
PE
1840 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1841 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1842 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1843 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1844 Remove unused macros.
f38b440c 1845
232b38b9 1846 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1847 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1848 * character.c (string_count_byte8): Likewise.
232b38b9 1849
fb90da1b
PE
1850 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1851 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1852
fb93dbc2
PE
1853 * chartab.c (copy_sub_char_table): Now static, since it's not used
1854 elsewhere.
5c156ace
PE
1855 (sub_char_table_ref_and_range, char_table_ref_and_range):
1856 Rename locals to avoid shadowing.
bbcd0949 1857 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1858
7d3b3862 1859 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1860 (BIDI_BOB): Remove unused macro.
7d3b3862 1861
6be7d3da
PE
1862 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1863 deduce are never used uninitialized.
c2ed9c8b 1864 * term.c (encode_terminal_code): Likewise.
6be7d3da 1865
75f8807f 1866 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1867
50938595
PE
1868 * tparam.h: New file.
1869 * term.c, tparam.h: Include it.
1870 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1871 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1872 Move these decls to tparam.h, and make them agree with what
1873 is actually in tparam.c. The previous trick of using incompatible
1874 decls in different modules does not conform to the C standard.
1875 All callers of tparam changed to use tparam's actual API.
1876 * tparam.c (tparam1, tparam, tgoto):
1877 Use const pointers where appropriate.
1878
fbceeba2
PE
1879 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1880 * cm.h (struct cm): Likewise.
1881 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1882 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1883 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1884 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1885 (turn_on_face, init_tty): Likewise.
1886 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1887
7f3f1250
PE
1888 * term.c (term_mouse_position): Rename local to avoid shadowing.
1889
e6ca6543
PE
1890 * alloc.c (mark_ttys): Move decl from here ...
1891 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1892
c40f8d15
AS
18932011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1894
1895 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1896
cfe0661d
JB
18972011-03-09 Juanma Barranquero <lekktu@gmail.com>
1898
1899 * search.c (compile_pattern_1): Remove argument regp, unused since
1900 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1901 (compile_pattern): Don't pass it.
1902
0afb4571
J
19032011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1904
1905 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1906 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1907 for ! HAVE_GTK3.
1908 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1909
1910 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1911
1912 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1913 gdk_window_get_screen, gdk_window_get_geometry,
1914 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1915 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1916 (xg_get_pixbuf_from_pixmap): New function.
1917 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1918 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1919 Call xg_get_pixbuf_from_pixmap instead of
1920 gdk_pixbuf_get_from_drawable.
1921 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1922 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1923 (xg_check_special_colors): Use GtkStyleContext and its functions
1924 for HAVE_GTK3.
1925 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1926 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1927 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1928 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1929 Call gtk_widget_get_preferred_size.
0afb4571
J
1930 (xg_frame_resized): gdk_window_get_geometry only takes 5
1931 parameters.
44f230aa
SM
1932 (xg_win_to_widget, xg_event_is_for_menubar):
1933 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1934 (xg_set_widget_bg): New function.
1935 (delete_cb): New function.
1936 (xg_create_frame_widgets): connect delete-event to delete_cb.
1937 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1938 (xg_set_background_color): Call xg_set_widget_bg.
1939 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1940 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1941 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1942 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1943 if ! HAVE_GTK3.
1944 (update_frame_tool_bar): Call gtk_widget_hide.
1945 (xg_initialize): Use GDK_KEY_g.
1946
1947 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1948 if ! HAVE_GTK3
1949 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1950
1951 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1952 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1953 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1954
1c2cc4ef
JB
19552011-03-08 Juanma Barranquero <lekktu@gmail.com>
1956
1957 * w32xfns.c (select_palette): Check success of RealizePalette against
1958 GDI_ERROR, not zero.
1959
33383987 1960See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1961
1962;; Local Variables:
1963;; coding: utf-8
aac0c6e3
MR
1964;; End:
1965
33383987 1966 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1967
1968 This file is part of GNU Emacs.
1969
1970 GNU Emacs is free software: you can redistribute it and/or modify
1971 it under the terms of the GNU General Public License as published by
1972 the Free Software Foundation, either version 3 of the License, or
1973 (at your option) any later version.
1974
1975 GNU Emacs is distributed in the hope that it will be useful,
1976 but WITHOUT ANY WARRANTY; without even the implied warranty of
1977 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1978 GNU General Public License for more details.
1979
1980 You should have received a copy of the GNU General Public License
1981 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.