Backport fix for Bug#12463 from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
cc04a16f
CY
12012-09-21 Chong Yidong <cyd@gnu.org>
2
3 * image.c (define_image_type): Avoid adding duplicate types to
4 image_types (Bug#12463). Suggested by Jörg Walter.
5
e25c1a30
YM
62012-09-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7
8 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
9 (print_load_command_name): Add case LC_DATA_IN_CODE.
10 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
11
1e9bbf47
GM
122012-09-18 Glenn Morris <rgm@gnu.org>
13
14 * eval.c (Frun_hook_with_args_until_success)
15 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
16
c6ba4138
AS
172012-09-14 Andreas Schwab <schwab@linux-m68k.org>
18
19 * fileio.c (Ffile_selinux_context): Only call freecon when
20 lgetfilecon succeeded.
21 (Fset_file_selinux_context): Likewise. (Bug#12444)
22
aa36e4d2
EZ
232012-09-12 Eli Zaretskii <eliz@gnu.org>
24
25 * xdisp.c (try_window_reusing_current_matrix): Under bidi
26 reordering, locate the cursor by calling set_cursor_from_row; if
27 that fails, clear the desired glyph matrix before returning a
28 failure indication to the caller. Fixes leaving garbled display
29 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
30 (compute_stop_pos_backwards): Fix a typo that caused crashes while
31 scrolling through multibyte text.
aa36e4d2 32
e0453b55
JD
332012-09-12 Jan Djärv <jan.h.d@swipnet.se>
34
35 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
36 does not become zero (Bug#12234). Backport from trunk.
37
19c17fc1
CY
382012-08-24 Chong Yidong <cyd@gnu.org>
39
40 * Version 24.2 released.
41
36c46f8e
EZ
422012-08-24 Eli Zaretskii <eliz@gnu.org>
43
44 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
45 is not one of the heaps we manage. (Bug#12242)
46
8c95e664
GM
472012-08-14 Glenn Morris <rgm@gnu.org>
48
49 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
50
7f654971
UM
512012-08-14 Ulrich Mueller <ulm@gentoo.org>
52
53 * systime.h (EMACS_TIME_CMP): Don't cast time_t values to long
54 (Bug#11712).
55
170aedb9
CY
562012-08-13 Eli Zaretskii <eliz@gnu.org>
57
b7f501c7
EZ
58 * w32menu.c: Include w32heap.h.
59 (add_menu_item): If the call to AppendMenuW (via
60 unicode_append_menu) fails, disable Unicode menus only if we are
61 running on Windows 9X/Me.
62
63 * makefile.w32-in ($(BLD)/w32menu.$(O)): Depend on w32heap.h.
64
170aedb9
CY
65 * window.c (Fdelete_other_windows_internal)
66 (Fdelete_window_internal): Don't access frame's mouse highlight
67 info of the initial frame. (Bug#11677)
68
c17d5a38
JD
692012-08-12 Jan Djärv <jan.h.d@swipnet.se>
70
71 * nsterm.m (ns_read_socket): Return early if there is a modal
72 window (Bug#12043).
73
74 * nsmenu.m (Popdown_data): New struct.
75 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
76 free Popdown_data.
77 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
78 (initWithContentRect): Make imgView and contentView non-static
79 and autorelease them. Also autorelease img and matrix (Bug#12005).
80 (dealloc): Remove (Bug#12005).
81
82 * nsterm.m (keyDown:): Interpret flags without left/right bits
83 as the left key (Bug#11670).
84
85 * nsmenu.m (ns_update_menubar): Add braces to ambigous if-else.
86
8ccd072a
YM
872012-08-08 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
88
89 * unexmacosx.c (copy_data_segment): Copy initialized data in
90 statically linked libraries from input file rather than memory.
91
db74a5fc
YM
922012-08-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
93
94 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
95 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
96 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
97
23dc7744
CY
982012-07-19 Chong Yidong <cyd@gnu.org>
99
100 * window.c (Fwindow_absolute_pixel_edges)
101 (Fdelete_other_windows_internal): Signal an error if the window is
102 on a dead frame (Bug#11984).
103
fbf31a9c
EZ
1042012-07-14 Eli Zaretskii <eliz@gnu.org>
105
106 Remove FILE_SYSTEM_CASE.
107 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
108
109 * fileio.c (FILE_SYSTEM_CASE): Don't define.
110 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
111 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
112 call-process-region passes it through expand-file-name.
113
114 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
115
8a05d57a
AS
1162012-07-12 Andreas Schwab <schwab@linux-m68k.org>
117
118 Fix crash when creating indirect buffer (Bug#11917)
119 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
120 Don't handle unbound variables specially if non-zero.
121 (Fbuffer_local_variables): Pass zero.
122 (clone_per_buffer_values): Pass non-zero.
123
57570cd3
AS
1242012-06-28 Andreas Schwab <schwab@linux-m68k.org>
125
126 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
127 to make the loop interruptible.
128
d01fd55f
AS
1292012-06-26 Andreas Schwab <schwab@linux-m68k.org>
130
131 * gnutls.c (emacs_gnutls_handshake): Only retry if
132 GNUTLS_E_INTERRUPTED.
133
c81b46f6
EZ
1342012-06-23 Eli Zaretskii <eliz@gnu.org>
135
136 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
137 in the logic of incrementing and decrementing the value of
138 use_relocatable_buffers.
139
63541ed8
GM
1402012-06-21 Glenn Morris <rgm@gnu.org>
141
142 * charset.c (init_charset): Make lack of etc/charsets fatal.
143
50a93863
JD
1442012-06-11 Jan Djärv <jan.h.d@swipnet.se>
145
146 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
147 referenced (Bug#11583).
148
94f0aa34
CY
1492012-06-01 Chong Yidong <cyd@gnu.org>
150
151 * Version 24.1 released.
152
d5fd2c54
EZ
1532012-05-30 Eli Zaretskii <eliz@gnu.org>
154
155 * xdisp.c (handle_stop): Detect whether we have overlay strings
156 loaded by testing it->current.overlay_string_index to be
157 non-negative, instead of checking whether n_overlay_strings is
158 positive. (Bug#11587)
159
353c87f6
CY
1602012-05-30 Chong Yidong <cyd@gnu.org>
161
162 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
163
164 * doc.c (Fsubstitute_command_keys): Doc fix.
165
a02ae4e5
EZ
1662012-05-29 Eli Zaretskii <eliz@gnu.org>
167
168 * search.c (search_buffer): Remove calls to
169 r_alloc_inhibit_buffer_relocation, as it is now called by
170 maybe_unify_char, which was the cause of relocation of buffer text
171 in bug#11519.
172
291d430f
EZ
1732012-05-23 Eli Zaretskii <eliz@gnu.org>
174
175 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
176 for the duration of call to load_charset, to avoid problems with
177 callers of maybe_unify_char that access buffer text through C
178 pointers.
179
180 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
181 decrement the inhibition flag, instead of just setting or
182 resetting it.
183
2f9b9adb
KB
1842012-05-24 Ken Brown <kbrown@cornell.edu>
185
186 * callproc.c (Fcall_process): Restore a line that was accidentally
187 commented out in the 2011-02-13 change (bug#11547).
188
52c55cc7
EZ
1892012-05-23 Eli Zaretskii <eliz@gnu.org>
190
191 * lisp.h [REL_ALLOC]: Add prototypes for external functions
192 defined on ralloc.c.
193
194 * buffer.c [REL_ALLOC]: Remove prototypes of
195 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
196 they are now on lisp.h.
197
198 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
199
200 * search.c (search_buffer): Use it to inhibit relocation of buffer
201 text while re_search_2 is doing its job, because re_search_2 is
202 passed C pointers to buffer text. (Bug#11519)
203
23415acf
EZ
2042012-05-21 Eli Zaretskii <eliz@gnu.org>
205
206 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
207 Update value to 24.
208
44e27368
EZ
2092012-05-19 Eli Zaretskii <eliz@gnu.org>
210
211 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
212 state after an additional call to move_it_in_display_line_to, keep
213 the values of it->max_ascent and it->max_descent found for the
214 entire line.
215 (pos_visible_p): Revert the comparison against bottom_y to what it
216 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
217 (Bug#11464)
218
ccbf309c
EZ
2192012-05-15 Eli Zaretskii <eliz@gnu.org>
220
221 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
222
ac268e67
EZ
2232012-05-13 Eli Zaretskii <eliz@gnu.org>
224
225 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
226 already have overlays loaded.
227 (handle_single_display_spec): Before returning without displaying
228 fringe bitmap, synchronize the bidi iterator with the main display
229 iterator, by calling iterate_out_of_display_property.
230 (iterate_out_of_display_property): Detect buffer iteration by
231 testing that it->string is a Lisp string.
232 (get_next_display_element): When the current object is exhausted,
233 and there's something on it->stack, call set_iterator_to_next to
234 proceed with what's on the stack, instead of returning zero.
235 (set_iterator_to_next): If called at the end of a Lisp string,
236 proceed to consider_string_end without incrementing string
237 position. Don't increment display vector index past the end of
238 the display vector. (Bug#11417)
c8fb9dc6
EZ
239 (pos_visible_p): Don't report a position visible when move_it_to
240 stopped at the last line of window, which happens to be scanned
241 backwards by the bidi iteration. (Bug#11464)
ac268e67 242
82f9b393
EZ
2432012-05-11 Eli Zaretskii <eliz@gnu.org>
244
245 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
246 and right-margin display specs even if the spec is invalid or we
247 are on a TTY, and thus unable to display on the fringes. That's
248 because the text with the property will not be displayed anyway,
249 so we need to signal to the caller that this is a "replacing"
250 display spec. This fixes display when the spec is invalid or we
251 are on a TTY.
252
297834cd
PE
2532012-05-09 Paul Eggert <eggert@cs.ucla.edu>
254
255 * unexaix.c (make_hdr): Fix typo in prototype.
256 This bug broke the build on AIX. Problem reported by Gilles Pion.
257
0d887c7d
EZ
2582012-05-05 Eli Zaretskii <eliz@gnu.org>
259
260 * w32proc.c (new_child): Force Windows to reserve only 64KB of
261 stack for each reader_thread, instead of defaulting to 8MB
262 determined by the linker. This avoids failures in creating
263 subprocesses on Windows 7, see the discussion in this thread:
264 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
265
bf98199c
JM
2662012-05-02 Jim Meyering <meyering@redhat.com>
267
268 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
269
2fa85638
EZ
2702012-04-29 Eli Zaretskii <eliz@gnu.org>
271
272 * xdisp.c (pos_visible_p): If already at a newline from the
273 display string before the 'while' loop, don't walk back the glyphs
274 from it3.glyph_row. Solves assertion violation when the display
275 string begins with a newline (egg.el). (Bug#11367)
276
9be2fd9b
CY
2772012-04-24 Chong Yidong <cyd@gnu.org>
278
279 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
280
f0ee99a0
EZ
2812012-04-23 Eli Zaretskii <eliz@gnu.org>
282
283 * xdisp.c (pos_visible_p): If the window start position is beyond
284 ZV, start the display from buffer beginning. Prevents assertion
285 violation in init_iterator when the minibuffer window is scrolled
286 via the scroll bar.
287
288 * window.c (window_scroll_pixel_based): Likewise.
289
9ec7751f
CY
2902012-04-23 Chong Yidong <cyd@gnu.org>
291
292 * keymap.c (where_is_internal): Doc fix (Bug#10872).
293
24c51a09
GM
2942012-04-20 Glenn Morris <rgm@gnu.org>
295
296 * fileio.c (Fcopy_file, Fset_file_selinux_context):
297 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
298
73055685
EZ
2992012-04-20 Eli Zaretskii <eliz@gnu.org>
300
301 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
302 overrun array limits of glyph row's used[] array. (Bug#11288)
303
f30d612a
CY
3042012-04-20 Chong Yidong <cyd@gnu.org>
305
306 * process.c (wait_reading_process_output): If EIO occurs on a pty,
307 set the status to "failed" and ensure that sentinel is run.
308
016a35df
GM
3092012-04-18 Glenn Morris <rgm@gnu.org>
310
311 * process.c (Fset_process_inherit_coding_system_flag)
312 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 313 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 314
20a68157
EZ
3152012-04-17 Eli Zaretskii <eliz@gnu.org>
316
317 * xdisp.c (string_buffer_position_lim): Limit starting position to
318 BEGV.
319 (set_cursor_from_row): If called for a mode-line or header-line
320 row, return zero immediately.
321 (try_cursor_movement): If inside continuation line, don't back up
322 farther than the first row after the header line, if any. Don't
323 consider the header-line row as "partially visible", even if
324 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
325
ad3a2b41
AO
3262012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
327
328 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
329
e63c261b
CY
3302012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
331
332 * process.c (make_process):
333 * process.h: Add integer `gnutls_handshakes_tried' member to
334 process struct.
335
ad3a2b41
AO
336 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
337 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
338
339 * gnutls.c (gnutls_log_function2i): Convenience log function.
340 (emacs_gnutls_read): Use new log functions,
341 `gnutls_handshakes_tried' process member, and
342 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
343 attempts per process (connection).
344
e53357c4
EZ
3452012-04-09 Eli Zaretskii <eliz@gnu.org>
346
347 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
348 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
349
aff67c82
JD
3502012-04-09 Jan Djärv <jan.h.d@swipnet.se>
351
352 * nsterm.m (constrainFrameRect): Always constrain when there is only
353 one screen (Bug#10962).
354
2f8e16b2
EZ
3552012-04-06 Eli Zaretskii <eliz@gnu.org>
356
357 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
358 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
359 about subtle differences between FETCH_CHAR* and STRING_CHAR*
360 macros related to unification of CJK characters. For the details,
361 see the discussion following the message here:
362 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
363
3d439cd1
CY
3642012-04-04 Chong Yidong <cyd@gnu.org>
365
366 * keyboard.c (Vdelayed_warnings_list): Doc fix.
367
8bc53d00
EZ
3682012-04-01 Eli Zaretskii <eliz@gnu.org>
369
370 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
371 instead of alloca. (Bug#11138)
372
3b0512a3
AS
3732012-04-01 Andreas Schwab <schwab@linux-m68k.org>
374
375 * w32menu.c (is_simple_dialog): Properly check lisp types.
376 (Bug#11141)
377
8427ddd2
EZ
3782012-03-31 Eli Zaretskii <eliz@gnu.org>
379
979022ef
EZ
380 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
381 position we get to after a call to move_it_to fails the
382 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
383 only if we wind up in a string from display property. (Bug#11063)
384
a6b1c7cc
EZ
385 * window.c (Fdelete_other_windows_internal): Invalidate the row
386 and column information about mouse highlight, so that redisplay
387 restores it after reallocating the glyph matrices. (Bug#7464)
388
8427ddd2
EZ
389 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
390 string comes from a `display' text property, use the buffer
391 position of that property as if we actually saw that position in
392 the row's glyphs.
697ba24b
EZ
393 (move_it_by_lines): Remove the assertion that
394 "it->current_x == 0 && it->hpos == 0" which can be legitimately
395 violated when there's a before-string at the beginning of a line.
396 (Bug#11063)
8427ddd2 397
65a0a738
EZ
3982012-03-30 Eli Zaretskii <eliz@gnu.org>
399
400 * xdisp.c (append_space_for_newline): If the default face was
401 remapped, use the remapped face for the appended newline.
402 (extend_face_to_end_of_line): Use the remapped default face for
403 extending the face to the end of the line.
404 (display_line): Call extend_face_to_end_of_line when the default
405 face was remapped. (Bug#11068)
406
581355cc
EZ
4072012-03-29 Eli Zaretskii <eliz@gnu.org>
408
409 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
410
e8fc049f
SM
4112012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
412
413 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
414
4fb9a543
GM
4152012-03-27 Glenn Morris <rgm@gnu.org>
416
417 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
418 Doc fixes.
419
679910f1
KH
4202012-03-26 Kenichi Handa <handa@m17n.org>
421
422 * dispextern.h (struct glyph): Fix previous change. Change the
423 bit length of glyphless.ch to 25 (Bug#11082).
424
90d49b7f
CY
4252012-03-26 Chong Yidong <cyd@gnu.org>
426
427 * keyboard.c (Vselection_inhibit_update_commands): New variable.
428 (command_loop_1): Use it; inhibit selection update for
429 handle-select-window too (Bug#8996).
430
f514f6f0
FP
4312012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
432
e8fc049f 433 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 434
bf43fa51
KH
4352012-03-25 Kenichi Handa <handa@m17n.org>
436
437 * dispextern.h (struct glyph): Change the bit length of
438 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
439
8a0c01dd
EZ
4402012-03-24 Eli Zaretskii <eliz@gnu.org>
441
442 * s/ms-w32.h (tzname): Include time.h before redirecting to
443 _tzname. Fixes the MSVC build. (Bug#9960)
444
7d1c3a76
AS
4452012-03-24 Andreas Schwab <schwab@linux-m68k.org>
446
8ed79523
AS
447 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
448 characters.
449
7d1c3a76
AS
450 * xterm.c (XTread_socket): Only modify handling_signal if
451 !SYNC_INPUT. (Bug#11080)
452
e99a9b8b
EZ
4532012-03-23 Eli Zaretskii <eliz@gnu.org>
454
455 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
456 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
457 when fetching a multibyte character consumes more bytes than
458 CHAR_BYTES returns, due to unification of CJK characters in
459 string_char. (Bug#11073)
460
5063c0e1
TN
4612012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
462
463 * process.c (wait_reading_process_output): Handle pty disconnect
464 by refraining from sending oneself a SIGCHLD (bug#10933).
465
9f851fbd
CY
4662012-03-22 Chong Yidong <cyd@gnu.org>
467
468 * dispextern.h (struct it): New member string_from_prefix_prop_p.
469
5063c0e1 470 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
471 Mark string as coming from a prefix property.
472 (handle_face_prop): Use default face for prefix strings (Bug#4281).
473 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
474
fb5b8aca
CY
4752012-03-21 Chong Yidong <cyd@gnu.org>
476
477 * xfaces.c (Vface_remapping_alist): Doc fix.
478
62356a1b
EZ
4792012-03-20 Eli Zaretskii <eliz@gnu.org>
480
481 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
482 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
483 Doc fixes.
62356a1b 484
025de85b
CY
4852012-03-20 Chong Yidong <cyd@gnu.org>
486
487 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
488 to reflect default non-nil value of redisplay-dont-pause.
489
4827f94e
KH
4902012-03-19 Kenichi Handa <handa@m17n.org>
491
492 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
493 it fit in a valid range (Bug#11003).
494
e50a24a2
EZ
4952012-03-18 Eli Zaretskii <eliz@gnu.org>
496
497 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
498 that is not from display property, accept the row as a "cursor
499 row" if one of the string's character has a non-nil `cursor'
500 property. Fixes cursor positioning when there are newlines in
501 overlay strings, e.g. in icomplete.el. (Bug#11035)
502
9af5ed87
PE
5032012-03-12 Paul Eggert <eggert@cs.ucla.edu>
504
505 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
506
d1f55f16
CY
5072012-03-12 Chong Yidong <cyd@gnu.org>
508
509 * eval.c (inhibit_lisp_code): Rename from
510 inhibit_window_configuration_change_hook; move from window.c.
511
512 * xfns.c (unwind_create_frame_1, Fx_create_frame):
513 * window.c (run_window_configuration_change_hook)
514 (syms_of_window): Callers changed.
515
66c5eebd
CY
5162012-03-11 Chong Yidong <cyd@gnu.org>
517
413df973
CY
518 * keymap.c (Fkey_description): Doc fix (Bug#9700).
519
66c5eebd
CY
520 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
521
1de11f56
CY
5222012-03-10 Chong Yidong <cyd@gnu.org>
523
524 * frame.c (other_visible_frames): Don't assume the selected frame
525 is visible (Bug#10955).
526
cae07000
SM
5272012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
528
529 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
530
89c94350
JD
5312012-03-08 Jan Djärv <jan.h.d@swipnet.se>
532
533 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
534 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
535 zero (Bug#10954).
536
999dd333
GM
5372012-03-03 Glenn Morris <rgm@gnu.org>
538
01a6dcc8 539 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 540
de0100f2
EZ
5412012-03-02 Eli Zaretskii <eliz@gnu.org>
542
543 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
544 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
545 (redisplay_window, next_element_from_string): Fix typos in
546 comments.
3e441275
EZ
547 (redisplay_window): Pass to move_it_vertically the margin in
548 pixels, not in screen lines.
de0100f2 549
96a72ee9
GM
5502012-03-02 Glenn Morris <rgm@gnu.org>
551
552 * buffer.c (buffer-list-update-hook): Doc fix.
553
312508d7
EZ
5542012-02-29 Eli Zaretskii <eliz@gnu.org>
555
556 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
557 push_it before setting up the iterator for the first overlay
558 string, even if we have an empty string loaded.
559 (next_overlay_string): If there's an empty string on the iterator
560 stack, pop the stack. (Bug#10903)
561
27f3c637
PE
5622012-02-25 Paul Eggert <eggert@cs.ucla.edu>
563
564 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
565 Suggested by Stefan Monnier in
566 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
567 * alloc.c (widen_to_Lisp_Object): New static function.
568 (mark_memory): Also mark Lisp_Objects by fetching pointer words
569 and widening them to Lisp_Objects. This would work even if
570 USE_LSB_TAG is defined and wide integers are used, which might
571 happen in a future version of Emacs.
572
3c9dfce6
CY
5732012-02-25 Chong Yidong <cyd@gnu.org>
574
fa74b241
CY
575 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
576 Doc fix.
577
3c9dfce6
CY
578 * xselect.c (Fx_selection_exists_p): Doc fix.
579 (x_clipboard_manager_save_all): Print an informative message
580 before saving to clipboard manager.
581
9486df08
CY
5822012-02-24 Chong Yidong <cyd@gnu.org>
583
584 * keyboard.c (process_special_events): Handle all X selection
585 requests in kbd_buffer, not just the next one (Bug#8869).
586
f01d3321
CY
5872012-02-23 Chong Yidong <cyd@gnu.org>
588
589 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
590 call when setting menu-bar-lines and tool-bar-lines parameters.
591 (unwind_create_frame_1): New helper function.
592
593 * window.c (inhibit_window_configuration_change_hook): New var.
594 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 595 (syms_of_window): Initialize it.
f01d3321 596
86b847b6
CY
5972012-02-22 Chong Yidong <cyd@gnu.org>
598
599 * xterm.c (x_draw_image_relief): Add missing type check for
600 Vtool_bar_button_margin (Bug#10743).
601
a59225b1
CY
6022012-02-21 Chong Yidong <cyd@gnu.org>
603
604 * fileio.c (Vfile_name_handler_alist): Doc fix.
605
606 * buffer.c (Fget_file_buffer): Protect against invalid file
607 handler return value.
608
310f5bd4
PE
6092012-02-20 Paul Eggert <eggert@cs.ucla.edu>
610
cb3a28cc
PE
611 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
612 when computing $valmask.
613
310f5bd4
PE
614 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
615 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
616 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
617 It's useless in that case, and it can cause problems on hosts
618 that allocate halves of EMACS_INT values separately.
619 Reported by Dan Horák. Diagnosed by Andreas Schwab in
620 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
621 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
622 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
623 it avoids undefined behavior on hosts where shifting right by more
624 than the word width has undefined behavior.
625
2375c96a
CY
6262012-02-19 Chong Yidong <cyd@gnu.org>
627
628 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
629 (Funhandled_file_name_directory, Ffile_name_as_directory)
630 (Fdirectory_file_name, Fexpand_file_name)
631 (Fsubstitute_in_file_name): Protect against invalid file handler
632 return values (Bug#10845).
633
3eb49e71
EZ
6342012-02-18 Eli Zaretskii <eliz@gnu.org>
635
636 * .gdbinit (pitx): Fix incorrect references to fields of the
637 iterator stack.
638
7b926f3f
CY
6392012-02-17 Chong Yidong <cyd@gnu.org>
640
641 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
642
11273115
PE
6432012-02-15 Paul Eggert <eggert@cs.ucla.edu>
644
645 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
646 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
647
c3a70e2b
CY
6482012-02-15 Chong Yidong <cyd@gnu.org>
649
650 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
651 marked as special. Also, starting docstrings with * is obsolete.
652
0ca43699
AS
6532012-02-13 Andreas Schwab <schwab@linux-m68k.org>
654
655 * gnutls.c (emacs_gnutls_write): Fix last change.
656
2e8f3c56
LI
6572012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
658
659 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
660 send_process.
661
af70074f
SM
6622012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
663
664 * keymap.c (Fsingle_key_description): Handle char ranges.
665
95986d52
CY
6662012-02-12 Chong Yidong <cyd@gnu.org>
667
afd83bd1
CY
668 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
669 as that creates a dangerous corner case.
670
95986d52
CY
671 * window.c (Fdelete_window_internal): Invalidate the mouse
672 highlight (Bug#9904).
673
bd7da63e
GM
6742012-02-12 Glenn Morris <rgm@gnu.org>
675
676 * xselect.c (Fx_own_selection_internal)
677 (Fx_get_selection_internal, Fx_disown_selection_internal)
678 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
679 * nsselect.m (Fx_own_selection_internal)
680 (Fx_disown_selection_internal, Fx_selection_exists_p)
681 (Fx_selection_owner_p, Fx_get_selection_internal):
682 Sync docs and argument specs with the xselect.c versions.
683
77abcbc2
LI
6842012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
685
686 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
687
90b671e2
EZ
6882012-02-11 Eli Zaretskii <eliz@gnu.org>
689
1c0ca0b7
EZ
690 * w32select.c (Fx_selection_exists_p): Sync doc string and
691 argument list with xselect.c. (Bug#10783)
692
693 * w16select.c (Fx_selection_exists_p): Sync doc string and
694 argument list with xselect.c. (Bug#10783)
90b671e2 695
49241268
GM
6962012-02-10 Glenn Morris <rgm@gnu.org>
697
698 * fns.c (Fsecure_hash): Doc fix.
699
f998bbe7 7002012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
701
702 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
703
0992bd9c
CY
7042012-02-07 Chong Yidong <cyd@gnu.org>
705
706 * buffer.c (Fbuffer_local_variables)
707 (buffer_lisp_local_variables): Handle unbound vars correctly;
708 don't let Qunbound leak into Lisp.
709
af008560
GM
7102012-02-07 Glenn Morris <rgm@gnu.org>
711
dd605cc4
GM
712 * image.c (Fimagemagick_types): Doc fix.
713
af008560
GM
714 * image.c (imagemagick-render-type): Change it from a lisp object
715 to an integer. Move the doc here from the lisp manual.
716 Treat all values not equal to 0 the same.
717
1449fa1d
CY
7182012-02-06 Chong Yidong <cyd@gnu.org>
719
720 * doc.c (store_function_docstring): Avoid applying docstring of
721 alias to base function (Bug#2603).
722
3723ec07
AS
7232012-02-04 Andreas Schwab <schwab@linux-m68k.org>
724
725 * .gdbinit (pp1, pv1): Remove redundant defines.
726 (pr): Use pp.
727
79c1cc1e
CY
7282012-02-04 Chong Yidong <cyd@gnu.org>
729
730 * nsterm.m: Declare a global (Bug#10694).
731
d7f29f8e
EZ
7322012-02-04 Eli Zaretskii <eliz@gnu.org>
733
cae07000
SM
734 * w32.c (get_emacs_configuration_options):
735 Include --enable-checking, if specified, in the return value.
d7f29f8e 736
3b95a6f9
MR
7372012-02-04 Martin Rudalics <rudalics@gmx.at>
738
739 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
740 after rounding frame sizes. (Bug#9723)
741
d6fa96a6
EZ
7422012-02-04 Eli Zaretskii <eliz@gnu.org>
743
744 * keyboard.c (adjust_point_for_property): Don't position point
745 before BEGV. (Bug#10696)
746
df0b2940
PE
7472012-02-03 Paul Eggert <eggert@cs.ucla.edu>
748
749 Handle overflow when computing char display width (Bug#9496).
750 * character.c (char_width): Return EMACS_INT, not int.
751 (char_width, c_string_width): Check for overflow when
752 computing the width; this is possible now that individual
753 characters can have unbounded width. Problem introduced
754 by merge from Emacs 23 on 2012-01-19.
755
6bee44d6
MA
7562012-02-02 Michael Albinus <michael.albinus@gmx.de>
757
758 * dbusbind.c (Fdbus_register_method): Mention the return value
759 :ignore in the docstring.
760
44f92739
GM
7612012-02-02 Glenn Morris <rgm@gnu.org>
762
1b9f60cc
GM
763 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
764
44f92739
GM
765 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
766 Unconditionally set to t. (Bug#10673)
767 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
768 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
769 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
770
c5d3843c
KH
7712012-02-02 Kenichi Handa <handa@m17n.org>
772
773 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
774 0, do not call append_composite_glyph.
775
159462d4 7762012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
777
778 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
779 NULL (Bug#6988).
780 (x_produce_glyphs): If the component of a composition is a null
781 string, set it->pixel_width to 1 to avoid zero-width glyph.
782
78cef877
EZ
7832012-02-01 Eli Zaretskii <eliz@gnu.org>
784
785 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
786 first 2 arguments are identical. This makes inserting large
787 output from a subprocess an order of magnitude faster on
788 MS-Windows, where all sbrk'ed memory is always contiguous.
789
97897668
GM
7902012-01-31 Glenn Morris <rgm@gnu.org>
791
792 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 793 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
794 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
795
31fd3586
GM
7962012-01-29 Glenn Morris <rgm@gnu.org>
797
798 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
799
0e24a8b2
CY
8002012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
801
802 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
803
cc0adcb0
CY
8042012-01-28 Chong Yidong <cyd@gnu.org>
805
806 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
807
acc28cb9
CY
8082012-01-26 Chong Yidong <cyd@gnu.org>
809
9c69cfb7
CY
810 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
811
acc28cb9
CY
812 * search.c (Fsearch_forward, Fsearch_backward): Document negative
813 repeat counts (Bug#10507).
814
48da7392
GM
8152012-01-26 Glenn Morris <rgm@gnu.org>
816
817 * lread.c (syms_of_lread): Doc fix.
818
14af5f7f
CY
8192012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
820
821 * coding.c (encode_designation_at_bol): Change return value to
822 EMACS_INT.
823
0b21c100
CY
8242012-01-25 Chong Yidong <cyd@gnu.org>
825
826 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
827
3c2907f7
CY
8282012-01-21 Chong Yidong <cyd@gnu.org>
829
830 * floatfns.c (Fcopysign): Make the second argument non-optional,
831 since nil is not allowed anyway.
832
959ad23f
AS
8332012-01-21 Andreas Schwab <schwab@linux-m68k.org>
834
835 * process.c (read_process_output): Use p instead of XPROCESS (proc).
836 (send_process): Likewise.
837
34a02f46
MR
8382012-01-19 Martin Rudalics <rudalics@gmx.at>
839
840 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
841 (Vwindow_persistent_parameters): Do not use Qstate.
842 Rewrite doc-strings.
34a02f46 843
1259009a 8442012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
845
846 * character.c (char_width): New function.
70d4fdf6
GM
847 (Fchar_width, c_string_width, lisp_string_width):
848 Use char_width (Bug#9496).
25ed9e61 849
6a6ee00d
MR
8502012-01-16 Martin Rudalics <rudalics@gmx.at>
851
852 * window.c (Vwindow_persistent_parameters): New variable.
853 (Fset_window_configuration, save_window_save): Handle persistent
854 window parameters.
855
c85efaf7
EZ
8562012-01-14 Eli Zaretskii <eliz@gnu.org>
857
858 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
859 thrashing the stack of the thread. (Bug#9087)
860
5944709e
PE
8612012-01-12 Paul Eggert <eggert@cs.ucla.edu>
862
863 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
864
e71f5d99
EZ
8652012-01-11 Eli Zaretskii <eliz@gnu.org>
866
867 * xdisp.c (rows_from_pos_range): Handle the case where the
868 highlight ends on a newline. (Bug#10464)
869 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
870 he end column for display of highlight that ends on a newline
871 before a R2L line.
872
ce316182
GM
8732012-01-11 Glenn Morris <rgm@gnu.org>
874
875 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
876 from load-path also when installation-directory is nil. (Bug#10208)
877
5b43da69
GM
8782012-01-10 Glenn Morris <rgm@gnu.org>
879
74cc8ff9
GM
880 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
881
7d8d6e4e
GM
882 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
883 Update template values to be closer to their typical values these days.
5b43da69 884
a0db8d43
EZ
8852012-01-09 Eli Zaretskii <eliz@gnu.org>
886
887 * xdisp.c (rows_from_pos_range): Accept additional argument
888 DISP_STRING, and accept any glyph in a row whose object is that
889 string as eligible for mouse highlight. Fixes mouse highlight of
890 display strings from overlays. (Bug#10464)
891
9a0115ab 8922012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 893
b9110d6a 894 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
895 * fileio.c (auto_saving_dir_umask): New static var.
896 (Fmake_directory_internal): Use it.
897 (do_auto_save_make_dir): Set it, instead of invoking chmod after
898 creating the directory. The old code temporarily assigns
899 too-generous permissions to the directory.
900 (do_auto_save_eh): Clear it.
b9110d6a 901 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
902 that the var is always cleared.
903
6c1bd3f3
EZ
9042012-01-07 Eli Zaretskii <eliz@gnu.org>
905
906 * search.c (scan_buffer): Pass character positions to
907 know_region_cache, not byte positions. (Bug#6540)
908
069d2b50
L
9092012-01-07 LynX <_LynX@bk.ru> (tiny change)
910
911 * w32.c (sys_rename): Report EXDEV when rename of a directory
912 fails because the target is on another logical disk. (Bug#10284)
913
75bf0d33
DB
9142012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
915
916 * xterm.c (x_embed_request_focus): New function.
917
918 * xterm.h: Add prototype.
919
920 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
921
1c6e5a32
GM
9222012-01-05 Glenn Morris <rgm@gnu.org>
923
924 * emacs.c (emacs_copyright): Update short copyright year to 2012.
925
651e947e
EZ
9262012-01-01 Eli Zaretskii <eliz@gnu.org>
927
928 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
929 Load gnutls_transport_set_lowat only if GnuTLS version is below
930 2.11.1.
931 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
932 GnuTLS versions below 2.11.1.
933
3778cdd8
AL
9342011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
935
936 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
937 to the doc string advising against its use for altering the way
938 windows are scrolled.
939
0e5317f7
KH
9402011-12-28 Kenichi Handa <handa@m17n.org>
941
942 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
943 coding-system ASCII compatible only when it does not produce BOM
944 on encoding (Bug#10383).
945
93d5ca1f
JD
9462011-12-26 Jan Djärv <jan.h.d@swipnet.se>
947
948 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
949 can scroll.
950 (create_and_show_popup_menu): Always use menu_position_func for
951 Gtk3 (Bug#10361).
952
ca22b785
AS
9532011-12-24 Andreas Schwab <schwab@linux-m68k.org>
954
955 * callint.c (Fcall_interactively): Don't truncate prompt string.
956
d048e1e6
EZ
9572011-12-23 Eli Zaretskii <eliz@gnu.org>
958
959 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
960 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 961 resumed from there (after widening). (Bug#10360)
d048e1e6 962
5ccaba1f
JD
9632011-12-22 Jan Djärv <jan.h.d@swipnet.se>
964
965 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
966
204ee57f
JD
9672011-12-21 Jan Djärv <jan.h.d@swipnet.se>
968
b81d40f0
JB
969 * nsterm.m (x_free_frame_resources):
970 Release f->output_data.ns->miniimage.
204ee57f
JD
971 (ns_index_color): Fix indentation. Do not retain
972 color_table->colors[i].
973
974 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
975 before returning.
976
977 * nsfns.m (x_set_background_color): Assign return value from
978 ns_index_color to face-background instead of NSColor*.
979 (ns_implicitly_set_icon_type): Fix indentation.
980 Change assignment in for loop to comparison.
981
982 * emacs.c (ns_pool): New variable.
983 (main): Assign ns_pool.
984 (Fkill_emacs): Call ns_release_autorelease_pool.
985
986 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
987 autorelease fdesc, release fdAttrs and tdict.
988 (ns_get_covering_families): Release charset.
989 (ns_findfonts): Release NSFontDescriptor created with new.
990 (ns_uni_to_glyphs): Fix indentation.
991 (setString): Release attrStr before assigning new value.
992
c803b2b7
JD
9932011-12-18 Jan Djärv <jan.h.d@swipnet.se>
994
678f4426
JD
995 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
996 and NS_IMPL_COCOA.
997 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
998 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
999
cd394be1 10002011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1001
5fecd5fc
JD
1002 * nsterm.m (ns_term_init): Subscribe for notifications
1003 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1004 to method trackingNotification in EmacsMenu.
1005
1006 * nsmenu.m (trackingMenu): New variable.
3771cb17 1007 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1008 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1009 from Aquamacs (Bug#7030).
678f4426
JD
1010
10112011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1012
c803b2b7
JD
1013 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1014 (symbol_to_nsstring): Fix indentation.
1015 (ns_symbol_to_pb): New function.
cae07000
SM
1016 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1017 (Fns_rotate_cut_buffers_internal): Remove.
1018 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1019 Fns_store_cut_buffer_internal.
1020 (ns_get_foreign_selection, Fx_own_selection_internal)
1021 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1022 (Fns_get_selection_internal, Fns_store_selection_internal):
1023 Use ns_symbol_to_pb and check if return value is nil.
1024 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1025 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1026 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1027 renamed to Sns_store_selection_internal.
1028 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1029 and remove this function.
1030 (ns_handle_selection_clear): Remove, never used.
1031 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1032 here.
1033
e1b01a3a
KB
10342011-12-17 Ken Brown <kbrown@cornell.edu>
1035
1036 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1037 GID is unknown (Bug#10257).
1038
2adb6e85
PE
10392011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1040
1041 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1042 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1043 which caused a build failure on GNU/Linux IA-64. This problem was
1044 introduced by my 2011-10-07 patch.
1045
d1d7b339
JL
10462011-12-15 Juri Linkov <juri@jurta.org>
1047
1048 * image.c (imagemagick_error): New function. (Bug#10112)
1049 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1050 Use `imagemagick_error' where ImageMagick functions return
1051 `MagickFalse'.
1052 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1053 proper order.
1054
100d5755
KH
10552011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1056
1057 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1058 fill background (Bug#8992).
1059
454592a6
MR
10602011-12-13 Martin Rudalics <rudalics@gmx.at>
1061
1062 * window.c (Vwindow_combination_resize)
1063 (Vwindow_combination_limit): Use t instead of non-nil in
1064 doc-strings.
61d4b438
MR
1065 (Vrecenter_redisplay): Add first sentence of doc-string on
1066 separate line.
53524d93 1067 (Frecenter): Fix doc-string typo.
454592a6 1068
3633e3aa
KH
10692011-12-11 Kenichi Handa <handa@m17n.org>
1070
1071 * coding.c (Funencodable_char_position): Pay attention to the
1072 buffer text relocation (Bug#9389).
1073
7b9d523a
JD
10742011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1075
1076 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1077 gtk_init (Bug#10100).
1078
b73189c6
EZ
10792011-12-10 Eli Zaretskii <eliz@gnu.org>
1080
1081 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1082 IT->string is nil. (Bug#10263)
1083
f7dfe5d6
JD
10842011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1085
83faebb4
JD
1086 * nsterm.h (x_free_frame_resources): Declare.
1087
f7dfe5d6
JD
1088 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1089 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1090
1091 * nsterm.h (ns_get_defaults_value): Declare.
1092
1093 * nsterm.m (ns_default): Call ns_get_defaults_value.
1094
7cd4e72c
EZ
10952011-12-09 Eli Zaretskii <eliz@gnu.org>
1096
1097 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1098 (Bug#10170)
1099
b34d7317
YM
11002011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1101
1102 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1103 that where the value of an _OBJC_* symbol points to is in the .bss
1104 section (Bug#10240).
1105
76470ad1
KH
11062011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1107
1108 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1109 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1110
745fff94
KH
11112011-12-08 Kenichi Handa <handa@m17n.org>
1112
1113 * ftfont.c (get_adstyle_property): Fix previous change
1114 (Bug#10233).
1115
6e44397c
JB
11162011-12-07 Juanma Barranquero <lekktu@gmail.com>
1117
1118 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1119 dirs from the default value of EMACSLOADPATH (bug#10208).
1120
7efa6272
GM
11212011-12-07 Glenn Morris <rgm@gnu.org>
1122
1123 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1124 installation and source directories as well. (Bug#10208)
1125
f6fc4d87
CY
11262011-12-06 Chong Yidong <cyd@gnu.org>
1127
1128 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1129
2bf26180
GM
11302011-12-06 Glenn Morris <rgm@gnu.org>
1131
1132 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1133 as an error, not just -1. (Bug#10217)
1134
3a6ad4f0
CY
11352011-12-05 Chong Yidong <cyd@gnu.org>
1136
1137 * keyboard.c (process_special_events): New function.
1138 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1139
75a3b399
PE
11402011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1141
1142 * coding.c (encode_designation_at_bol): Don't use uninitialized
1143 local variable (Bug#9318).
1144
c3c9e25e
KH
11452011-12-05 Kenichi Handa <handa@m17n.org>
1146
1147 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1148 return Qnil (Bug#8046, Bug#10193).
1149
5eb05ea3
KH
11502011-12-05 Kenichi Handa <handa@m17n.org>
1151
1152 * coding.c (encode_designation_at_bol): New args charbuf_end and
1153 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1154 (coding_set_source): Return how many bytes coding->source was
1155 relocated.
1156 (coding_set_destination): Return how many bytes
1157 coding->destination was relocated.
1158 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1159 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1160
11612011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1162
1163 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1164 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1165 macro (Bug#9318).
1166
11672011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1168
1169 The following changes are to fix Bug#9318.
1170
a79703f5 1171 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1172 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1173 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1174 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1175
7dbda6df
JB
11762011-12-05 Juanma Barranquero <lekktu@gmail.com>
1177
1178 * lisp.h (process_quit_flag): Fix external declaration.
1179
6d5eb5b0
SM
11802011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1181
1182 Don't macro-inline non-performance-critical code.
1183 * eval.c (process_quit_flag): New function.
1184 * lisp.h (QUIT): Use it.
1185
a0c3fad0
JD
11862011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1187
1188 * nsfns.m (get_geometry_from_preferences): New function.
1189 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1190
6c07aac2
AS
11912011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1192
1193 * emacs.c (Qkill_emacs): Define.
1194 (syms_of_emacs): Initialize it.
1195 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1196 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1197 (quit_throw_to_read_char): Add parameter `from_signal'.
1198 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1199 * lisp.h (QUIT): Call Fkill_emacs if requested.
1200
c052ead4
JD
12012011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1202
1203 * widget.c (update_wm_hints): Return if wmshell is null.
1204 (widget_update_wm_size_hints): New function.
1205
1206 * widget.h (widget_update_wm_size_hints): Declare.
1207
1208 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1209 widget_update_wm_size_hints (Bug#10104).
1210
9e49252b
EZ
12112011-12-03 Eli Zaretskii <eliz@gnu.org>
1212
1213 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1214 before a newline, prepare the bidi iterator for consuming the
1215 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1216 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1217
02b16839
JL
12182011-12-02 Juri Linkov <juri@jurta.org>
1219
1220 * search.c (Fword_search_regexp): New Lisp function created from
1221 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1222 (Fword_search_backward, Fword_search_forward)
1223 (Fword_search_backward_lax, Fword_search_forward_lax):
1224 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1225 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1226
0068070e
SM
12272011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1228
1229 * fileio.c (Finsert_file_contents): Move after-change-function call
1230 to before the "handled:" label, since all "goto handled" appear in
1231 cases where the *-change-functions have already been properly called
1232 (bug#10117).
1233
3360a3fc
AS
12342011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1235
1236 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1237 waiting for input. (Bug#10169)
1238
73d6c093
EZ
12392011-11-30 Eli Zaretskii <eliz@gnu.org>
1240
1241 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1242 verifies glyph row's hash code--we have just reallocated the
1243 glyphs, so their contents can be complete garbage. (Bug#10164)
1244
febe6bea
JB
12452011-11-30 Juanma Barranquero <lekktu@gmail.com>
1246
1247 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1248
801a4313
EZ
12492011-11-30 Eli Zaretskii <eliz@gnu.org>
1250
1251 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1252 attributes are tested _before_ calling verify_row_hash, to protect
1253 against GCC re-ordering of the tests. (Bug#10164)
1254
2b56b87e
JD
12552011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1256
1257 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1258
1259 * xterm.c (handle_one_xevent): Only set async_visible and friends
1260 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1261 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1262 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1263
dbf31225
PE
12642011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1265
1266 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1267 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1268 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1269 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1270 All uses changed to use GCPRO1 etc.
1271 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1272 Revert to old implementation (i.e., before 2011-03-11).
1273
1305621b
YM
12742011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1275
1276 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1277 of scroll runs so as to avoid assigning disabled bogus rows and
1278 unnecessary graphics copy operations.
1279
8c9afb46
EZ
12802011-11-27 Eli Zaretskii <eliz@gnu.org>
1281
1282 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1283 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1284 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1285 (malloc, free, realloc, calloc): Redirect to e_* only when
1286 compiling Emacs.
1287
1288 * lisp.h (GCTYPEBITS): Move before first use.
1289 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1290 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1291 this macro definition.
1292
1293 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1294 _MSC_VER.
1295
54e9e3bf
JD
12962011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1297
6d5eb5b0
SM
1298 * gtkutil.c (xg_create_frame_widgets):
1299 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1300 present with Gtk+ 2.0.
1301
83aca1cb
PE
13022011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 * fileio.c (Finsert_file_contents): Undo previous change; see
1305 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1306
5b76caa4
PE
13072011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1308
1309 Rename locals to avoid shadowing.
1310 * fileio.c (Finsert_file_contents):
1311 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1312 * process.c (wait_reading_process_output):
1313 Rename inner 'proc' to 'p' to avoid shadowing.
1314 Indent for consistency with usual Emacs style.
1315
8c535114
EZ
13162011-11-25 Eli Zaretskii <eliz@gnu.org>
1317
1318 * xdisp.c (redisplay_window): If cursor row is not fully visible
1319 after recentering, and scroll-conservatively is set to a large
1320 number, scroll window by a few more lines to make the cursor fully
1321 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1322 (start_display): Don't move to the next line if the display should
1323 start at a newline that is part of a display vector or an overlay
1324 string. (Bug#10119)
8c535114 1325
fa4fdb5c
JL
13262011-11-24 Juri Linkov <juri@jurta.org>
1327
1328 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1329 after the `MagickPingImage' call. (Bug#10112)
1330
90ec88df
CY
13312011-11-23 Chong Yidong <cyd@gnu.org>
1332
1333 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1334
56e2e794
MR
13352011-11-23 Martin Rudalics <rudalics@gmx.at>
1336
1337 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1338 making another buffer current. (Bug#10114)
1339
b6e64c41
GM
13402011-11-23 Glenn Morris <rgm@gnu.org>
1341
1342 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1343
6b21de18
CY
13442011-11-23 Chong Yidong <cyd@gnu.org>
1345
1346 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1347 using it (Bug#5984).
1348
b12cd789
EZ
13492011-11-22 Eli Zaretskii <eliz@gnu.org>
1350
1351 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1352 and header-lines, as they don't have one computed for them.
1353 (Bug#10098)
1354
1355 * .gdbinit (prow): Make displayed values more self-explaining.
1356 Add row's hash code.
1357
261b6fd4
LMI
13582011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1359
1360 * process.c (wait_reading_process_output): Fix asynchrounous
1361 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1362 (wait_reading_process_output): Add comment and URL.
261b6fd4 1363
e7cfd277
JD
13642011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1365
1366 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1367
a9b9b7f5
CY
13682011-11-21 Chong Yidong <cyd@gnu.org>
1369
1370 * window.c (Fnext_window, Fprevious_window): Doc fix.
1371
b0d15b4f
SM
13722011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1373
1374 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1375
fe7a3057
JB
13762011-11-20 Juanma Barranquero <lekktu@gmail.com>
1377
1378 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1379
d2999b1a
MR
13802011-11-20 Martin Rudalics <rudalics@gmx.at>
1381
1382 * window.c (Fset_window_combination_limit): Rename argument
1383 STATUS to LIMIT.
1384 (Vwindow_combination_limit): Remove "status" from doc-string.
1385
d5ff9cd0
AS
13862011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1387
1388 * m/ibms390.h: Remove.
1389 * m/ibms390x.h: Don't include "ibms390.h".
1390
a5bb9bd3
SM
13912011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1392
1393 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1394 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1395
cd1181db
JB
13962011-11-20 Juanma Barranquero <lekktu@gmail.com>
1397
1398 * casetab.c (Fset_case_table):
1399 * charset.c (Fcharset_after): Fix typos.
1400
615a3b8d 14012011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1402
17e845af
PE
1403 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1404 Otherwise, valgrind does not work on some platforms.
1405 Problem reported by Andreas Schwab in
6a0bf43d
PE
1406 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1407 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1408 is set, removing the need for VIRT_ADDRESS_VARIES.
1409 (PURE_P): Use a more-efficient implementation that needs just one
1410 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1411 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1412 to 4 (xorl, subq, cmpq, setbe).
1413 * alloc.c (pure): Always extern now, since that's the
1414 VIRT_ADDR_VARIES behavior.
1415 (PURE_POINTER_P): Use a single comparison, not two, for
1416 consistency with the new puresize.h.
1417 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1418 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1419 Remove VIRT_ADDR_VARIES no longer needed.
1420
f8fe6f96
EZ
14212011-11-19 Eli Zaretskii <eliz@gnu.org>
1422
1423 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1424 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1425 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1426 behave as if the cursor position were at the window margin.
1427
1428 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1429 and the cursor position is out of bounds, behave as if the cursor
1430 position were at the window margin. (Bug#10075)
1431
df05a53c
CY
14322011-11-18 Chong Yidong <cyd@gnu.org>
1433
1434 * window.c (Fwindow_combination_limit): Make first argument
1435 non-optional, since it is meaningless for live windows like the
1436 selected window.
1437
2071918e
DA
14382011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1439
1440 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1441
b50a28de
SM
14422011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1443
1444 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1445 (graft_intervals_into_buffer): Simplify.
1446
015137db
EZ
14472011-11-18 Eli Zaretskii <eliz@gnu.org>
1448
1449 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1450 hash values of the two rows.
1451 (copy_row_except_pointers): Preserve the used[] arrays and the
1452 hash values of the two rows. (Bug#10035)
68c95424 1453 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1454
1455 * xdisp.c (row_hash): New function, body extracted from
1456 compute_line_metrics.
1457 (compute_line_metrics): Call row_hash, instead of computing the
1458 hash code inline.
1459
1460 * dispnew.c (verify_row_hash): Call row_hash for computing the
1461 hash code of a row, instead of duplicating code from xdisp.c.
1462
1463 * dispextern.h (row_hash): Add prototype.
1464
a2addb04
TH
14652011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1466
1467 * frame.c (delete_frame): Don't delete the terminal when the last
1468 X frame is closed if emacs is built with GTK toolkit.
1469
df85d315
JB
14702011-11-17 Juanma Barranquero <lekktu@gmail.com>
1471
1472 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1473
a0c2d0ae
MR
14742011-11-17 Martin Rudalics <rudalics@gmx.at>
1475
1476 * window.c (Vwindow_splits): Rename to
1477 Vwindow_combination_resize. Suggested by Juri Linkov.
1478 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1479 of Vwindow_splits.
1480
58179cce
JB
14812011-11-16 Juanma Barranquero <lekktu@gmail.com>
1482
7877f373
JB
1483 * nsfns.m (Fns_font_name):
1484 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1485
b6f67890
MR
14862011-11-16 Martin Rudalics <rudalics@gmx.at>
1487
1488 * window.h (window): Rename slot "nest" to "combination_limit".
1489 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1490 (Fset_window_nest): Rename to Fset_window_combination_limit.
1491 (Vwindow_nest): Rename to Vwindow_combination_limit.
1492 (recombine_windows, make_parent_window, make_window)
1493 (Fsplit_window_internal, saved_window)
1494 (Fset_window_configuration, save_window_save): Rename all
1495 occurrences of window_nest to window_combination_limit.
1496
c7015153
JB
14972011-11-15 Juanma Barranquero <lekktu@gmail.com>
1498
1499 * image.c (imagemagick_load_image): Fix typo.
1500
322ad6ec
EZ
15012011-11-14 Eli Zaretskii <eliz@gnu.org>
1502
1503 * xdisp.c (display_line): Move the call to
1504 highlight_trailing_whitespace before the call to
1505 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1506 faces of all the glyphs to compute ROW's hash value.
1507 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1508
f067b8ec
JB
15092011-11-14 Juanma Barranquero <lekktu@gmail.com>
1510
1511 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1512 just return (bug#10044).
1513
1e5b2111
EZ
15142011-11-12 Eli Zaretskii <eliz@gnu.org>
1515
7ef3cbd5
EZ
1516 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1517 with user-defined heap size. Bump the default size of the temacs
1518 heap to 27MB, to avoid memory warning when running temacs.
1519 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1520
1e5b2111
EZ
1521 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1522 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1523 (verify_row_hash) [XASSERTS]: New function.
1524 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1525 that the hash value of glyph rows is correct.
1e5b2111 1526
89d61221
MR
15272011-11-12 Martin Rudalics <rudalics@gmx.at>
1528
1529 * window.h (window): Remove splits slot.
1530 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1531 (Fdelete_other_windows_internal, make_parent_window)
1532 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1533 (Fset_window_configuration, save_window_save): Don't deal with
1534 split status of windows.
1535 (saved_window): Remove splits slot.
1536 (Vwindow_splits): Rewrite doc-string.
1537
97f18cc8
JD
15382011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1539
1540 * xfns.c (unwind_create_frame):
1541 * nsfns.m (unwind_create_frame):
1542 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1543 Vframe_list (Bug#9999).
1544
22a648b4
DA
15452011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1546
0b381c7e 1547 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1548
659afede
KH
15492011-11-11 Kenichi Handa <handa@m17n.org>
1550
1551 * callproc.c (Fcall_process): Set the member dst_multibyte of
1552 process_coding.
1553
9ac0394b
KH
15542011-11-11 Johan Bockgård <bojohan@gnu.org>
1555
1556 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1557 avoid a crash (bug#9496).
1558
2fbdc249
CY
15592011-11-09 Chong Yidong <cyd@gnu.org>
1560
1561 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1562 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1563
ac6b1f81
PE
15642011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1565
1566 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1567
09db192c
PE
15682011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1569
1570 Avoid some portability problems by eschewing 'extern inline' functions.
1571 The trivial performance wins aren't worth the portability hassles; see
1572 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1573 et seq.
1574 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1575 (window_box_width, window_box_left, window_box_left_offset)
1576 (window_box_right, window_box_right_offset): Undo previous change,
1577 by removing the "extern"s.
1578 * intervals.c (adjust_intervals_for_insertion)
1579 (adjust_intervals_for_deletion): Undo previous change,
1580 making these static again.
1581 (offset_intervals, temp_set_point_both, temp_set_point)
1582 (copy_intervals_to_string): No longer inline.
1583 * xdisp.c (window_text_bottom_y, window_box_width)
1584 (window_box_height, window_box_left_offset)
1585 (window_box_right_offset, window_box_left, window_box_right)
1586 (window_box): No longer inline.
1587
105216ed
CY
15882011-11-08 Chong Yidong <cyd@gnu.org>
1589
1590 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1591 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1592 Signal an error if not a live window.
105216ed
CY
1593 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1594 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1595
ae9e237f
JB
15962011-11-07 Juanma Barranquero <lekktu@gmail.com>
1597
1598 * lisp.h (syms_of_abbrev): Remove declaration.
1599 Reported by CHENG Gao <chenggao@royau.me>.
1600
c7aa8333
EZ
16012011-11-07 Eli Zaretskii <eliz@gnu.org>
1602
1603 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1604 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1605 of temacs in GUI mode.
1606
be7f5545
MR
16072011-11-07 Martin Rudalics <rudalics@gmx.at>
1608
1609 * window.h: Declare delete_all_child_windows instead of
1610 delete_all_subwindows.
1611 * window.c (Fwindow_nest, Fset_window_nest)
1612 (Fset_window_new_total, Fset_window_new_normal)
1613 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1614 (delete_all_subwindows): Rename to delete_all_child_windows.
1615 (Fdelete_other_windows_internal, Fset_window_configuration):
1616 Call delete_all_child_windows instead of delete_all_subwindows.
1617 * frame.c (delete_frame): Call delete_all_child_windows instead
1618 of delete_all_subwindows.
1619
ca78dc43
PE
16202011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1621
1622 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1623 This is also needed for porting to any host where GC_MARK_STACK is
1624 not GC_MAKE_GCPROS_NOOPS.
1625 (which_symbols): Use it.
1626
a0241d01
KH
16272011-11-07 Kenichi Handa <handa@m17n.org>
1628
1629 * coding.c (coding_set_destination): Check coding->src_pos only
1630 when coding->src_object is a buffer (bug#9910).
1631
1632 * process.c (send_process): Set the member src_multibyte of coding
1633 to 0 (bug#9911) when sending a unibyte text.
1634
1635 * callproc.c (Fcall_process): Set the member src_multibyte of
1636 process_coding to 0 (bug#9912).
1637
a64bfdfa 16382011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1639
1640 * xmenu.c (cleanup_widget_value_tree): New function.
1641 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1642 calling free_menubar_widget_value_tree directly (Bug#9830).
1643
cb41b32a
PE
16442011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1645
1646 Fix some portability problems with 'inline'.
1647 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1648 (window_box_width, window_box_left, window_box_left_offset)
1649 (window_box_right, window_box_right_offset): Declare extern.
1650 Otherwise, these inline functions do not conform to C99 and
1651 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1652 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1653 * intervals.c (adjust_intervals_for_insertion)
1654 (adjust_intervals_for_deletion): Now extern, because otherwise the
1655 extern inline functions 'offset_intervals' couldn't refer to it.
1656 (static_offset_intervals): Remove.
1657 (offset_intervals): Rewrite using the old contents of
1658 static_offset_intervals. The old version didn't conform to C99
1659 because an extern inline function contained a reference to an
1660 identifier with static linkage.
1661
b7041366
AS
16622011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1663
1664 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1665 GC.
1666
88a37c4d
EZ
16672011-11-06 Eli Zaretskii <eliz@gnu.org>
1668
1669 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1670 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1671 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1672 return Qleft_to_right.
1673
49745b39
CY
16742011-11-06 Chong Yidong <cyd@gnu.org>
1675
1676 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1677 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1678 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1679 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1680 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1681 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1682 (Fwindow_vscroll): Doc fix.
1683 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1684 argument, since it makes no sense to pass a live window and for
1685 consistency with window-child.
1686
1f05cd82
CS
16872011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1688
1689 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1690 support MSVC.
1691
22610910
JR
16922011-11-05 Jason Rumney <jasonr@gnu.org>
1693
1694 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1695 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1696 fonts (Bug#6029).
1697 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1698 bitwise arithmetic preventing use of unicode-sip and non-truetype
1699 opentype fonts.
1700
a06776b2
EZ
17012011-11-05 Eli Zaretskii <eliz@gnu.org>
1702
3ad924ba
EZ
1703 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1704 "emacs"-only part.
1705
a06776b2
EZ
1706 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1707 initialization code to keep similarity to xfns.c after changes
1708 from 2011-11-05.
1709
c9e7db78
JD
17102011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1711
a97f8f3f
JD
1712 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1713 (unwind_create_frame): New function (Bug#9943).
1714 (Fx_create_frame): Restructure code to be more similar to the one in
1715 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1716 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1717 Move terminal->reference_count++ just before making the frame official
1718 (Bug#9943).
1719
1720 * nsterm.m (x_free_frame_resources): New function.
1721 (x_destroy_window): Move code to x_free_frame_resources.
1722
c9e7db78 1723 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1724 (Fx_create_frame, x_create_tip_frame):
1725 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1726 official. Move initialization of image_cache_refcount and
1727 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1728
a6fc3b5c
EZ
17292011-11-05 Eli Zaretskii <eliz@gnu.org>
1730
1731 Support MSVC build with newer versions of Visual Studio.
1732 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1733 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1734 nt/gmake.defs.
1735
1736 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1737 which are not supported by MSVC.
1738 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1739 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1740 bitfields.
1741 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1742 types in bitfields.
1743 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1744
1745 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1746
58179cce 17472011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1748
1749 Support MSVC build with newer versions of Visual Studio.
1750 * w32.c: Don't include w32api.h for MSVC.
1751 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1752
1753 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1754 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1755 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1756 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1757 e_* cousins.
1758 (alloca) [_MSC_VER]: Define to _alloca.
1759
1760 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1761
1762 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1763
a58c13ed
EZ
17642011-11-04 Eli Zaretskii <eliz@gnu.org>
1765
1766 * xdisp.c (note_mouse_highlight): If either of
1767 previous/next-single-property-change returns nil, treat that as
1768 the beginning or the end of the buffer. (Bug#9955)
1769
fe0b6370
JD
17702011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1771
a58c13ed 1772 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1773 label is not null (Bug#9951).
1774 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1775 may be NULL.
1776
89bd5ee1
EZ
17772011-11-04 Eli Zaretskii <eliz@gnu.org>
1778
1779 * window.c (Fwindow_body_size): Mention in the doc string that the
1780 return value is in frame's canonical units. (Bug#9949)
1781
84c3edb9
EZ
17822011-11-03 Eli Zaretskii <eliz@gnu.org>
1783
4e2fb5c7
EZ
1784 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1785
84c3edb9 1786 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1787 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1788 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1789
bc17a887
EZ
17902011-11-01 Eli Zaretskii <eliz@gnu.org>
1791
1792 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1793 Don't stop backward scan on the continuation glyph, even though
1794 its CHARPOS is positive.
6d5eb5b0
SM
1795 (mouse_face_from_buffer_pos, note_mouse_highlight):
1796 Rename cover_string to disp_string.
bc17a887 1797
4ee88440
MR
17982011-11-01 Martin Rudalics <rudalics@gmx.at>
1799
1800 * window.c (temp_output_buffer_show): Don't use
1801 Vtemp_buffer_show_specifiers.
1802 (Vtemp_buffer_show_specifiers): Remove unused variable.
1803
c2ff3c02
EZ
18042011-10-30 Eli Zaretskii <eliz@gnu.org>
1805
1806 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1807 past the beginning of the current glyph matrix.
1808
58179cce 18092011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1810
1811 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1812 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1813 HAVE_GTK3 (Bug#9869).
b77a6a7f 1814
3b574623
JD
1815 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1816 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1817
b77a6a7f
JD
1818 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1819
1820 * xterm.c: Declare x_handle_net_wm_state to return int.
1821 (handle_one_xevent): Check if we are iconified but don't have
1822 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1823 (get_current_wm_state): Return non-zero if not hidden,
1824 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1825 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1826 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1827 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1828
196e41e4
PE
18292011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1830
1831 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1832 so that this new function doesn't get optimized away by a
1833 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1834
021f2e1a
AS
18352011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1836
1837 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1838
8b058d44
EZ
18392011-10-29 Eli Zaretskii <eliz@gnu.org>
1840
1841 Fix the `xbytecode' command.
1842 * .gdbinit (xprintbytestr): New command.
b50a28de 1843 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1844 (xbytecode): Print the byte-code string as well.
1845
4452fb80
EZ
18462011-10-29 Kim Storm <storm@cua.dk>
1847
8b058d44
EZ
1848 * alloc.c (which_symbols): New function.
1849
21b72067
AS
18502011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1851
1852 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1853 line. (Bug#9903)
1854
83ed7b5c
GM
18552011-10-29 Glenn Morris <rgm@gnu.org>
1856
1857 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1858 Not clear what it was for, and it causes various bugs. (Bug#9839)
1859
5a7a728b
EZ
18602011-10-28 Eli Zaretskii <eliz@gnu.org>
1861
1862 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1863 possible random value that matches one of those tested as
1864 condition to clear the mouse face.
1865
d3d0842f
CY
18662011-10-28 Chong Yidong <cyd@gnu.org>
1867
1868 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1869
31b39d13
DN
18702011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1871
1872 * window.c (make_window): Initialize phys_cursor_on_p.
1873
9aba6043
SM
18742011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1875
1876 * lisp.h (struct Lisp_Symbol): Update comments.
1877
c20992f4
JB
18782011-10-28 Juanma Barranquero <lekktu@gmail.com>
1879
1880 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1881
db4f02f2
EZ
18822011-10-28 Eli Zaretskii <eliz@gnu.org>
1883
1884 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1885 <oslsachem@gmail.com> for helping to debug this.
1886
1887 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1888 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1889 (g_b_init_get_glyph_outline_w): New static variables.
1890 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1891 (GetGlyphOutlineW_Proc): New typedefs.
1892 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1893 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1894 New functions.
1895 (w32font_open_internal, compute_metrics):
1896 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1897 instead of calling the "wide" APIs directly.
1898
1899 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1900
1901 * w32.h (syms_of_w32font): Add prototype.
1902
87e68db4
JB
19032011-10-27 Juanma Barranquero <lekktu@gmail.com>
1904
1905 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1906 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1907 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1908 (Fmove_to_window_line): Doc fix.
1909
435c1d67
CY
19102011-10-27 Chong Yidong <cyd@gnu.org>
1911
1912 * process.c (make_process): Set gnutls_state to NULL.
1913
1914 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1915 non-NULL, regardless of GNUTLS_INITSTAGE.
1916 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1917 an error. Set process slots as soon as we allocate them.
1918
1919 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1920
9c6c6f49
CY
19212011-10-27 Chong Yidong <cyd@gnu.org>
1922
9aba6043
SM
1923 * gnutls.c (emacs_gnutls_deinit): New function.
1924 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1925 (Fgnutls_deinit, Fgnutls_boot): Use it.
1926
1927 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1928 (deactivate_process): Call emacs_gnutls_deinit.
1929
657d08d3
JB
19302011-10-27 Juanma Barranquero <lekktu@gmail.com>
1931
1932 * image.c (x_create_x_image_and_pixmap):
1933 * w32.c (sys_rename, w32_delayed_load):
1934 * w32font.c (fill_in_logfont):
1935 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1936
5430d399
JB
19372011-10-26 Juanma Barranquero <lekktu@gmail.com>
1938
1939 * w32fns.c (w32_default_color_map): New function,
1940 extracted from Fw32_default_color_map.
a7ef684b 1941 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1942
fe0055fa
PE
19432011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1944
1945 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1946
e6346438
SM
19472011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1948
1949 * keyboard.c (test_undefined): New function (bug#9751).
1950 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1951
e112cc37
ET
19522011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1953
1954 * sysdep.c (init_sys_modes): Fix the check for the controlling
1955 terminal (Bug#6649).
1956
7b5d6677
EZ
19572011-10-20 Eli Zaretskii <eliz@gnu.org>
1958
1959 * dispextern.h (struct bidi_it): New member next_en_type.
1960
1961 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1962 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1963 current character, check also for next_en_type being WEAK_EN.
1964 (bidi_resolve_weak): Don't enter the expensive loop if the current
1965 position is before next_en_pos. Record the bidi type of the first
1966 non-ET, non-BN character we find, in addition to its position.
1967 (bidi_level_of_next_char): Invalidate next_en_type when
1968 next_en_pos is over-stepped.
1969
7da0b018
PE
19702011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1973 * editfns.c: Rewrite current-time-zone so that it invokes
1974 the equivalent of (format-time-string "%Z") to get the time zone name.
1975 This fixes a bug when the time zone name contains characters that
1976 need converting from the system time locale to Emacs internal format.
1977 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1978 that patch fixed format-time-string to do the conversion, but
1979 I forgot to fix current-time-zone.
1980 (format_time_string): New function, containing most of
1981 what Fformat_time_string used to contain.
1982 (Fformat_time_string): Rewrite in terms of format_time_string.
1983 This doesn't change this function's behavior.
1984 (current-time-zone): Rewrite to use format_time_string.
1985 This fixes the bug reported by Michael Schierl in
1986 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1987 Jason Rumney's 2007-06-07 change worked around this bug, but
1988 didn't fix it.
1989 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1990
8547b010
EZ
19912011-10-19 Eli Zaretskii <eliz@gnu.org>
1992
1993 * xdisp.c (start_display): If the character at POS is displayed
1994 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1995 (try_window_reusing_current_matrix): If a line ends in a display
1996 vector or the next line starts in a display vector, continue
1997 redrawing the window even though the character position of
1998 start_row was reached.
8547b010
EZ
1999 (Bug#9771, part 2)
2000
4e948d15
CY
20012011-10-18 Chong Yidong <cyd@gnu.org>
2002
2003 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2004 with nobreak-char-display too.
2005
4787455f
EZ
20062011-10-18 Eli Zaretskii <eliz@gnu.org>
2007
2008 Fix part 3 of bug#9771.
2009 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2010 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2011 non-neutral characters if the current character is a paragraph
2012 separator (a.k.a. Newline). This avoids running the same
2013 expensive loop twice, once when we consume the preceding newline
2014 and the other time when the line actually needs to be displayed.
2015 Avoid the loop when we see neutrals on the base embedding level
2016 following a character whose directionality is the same as the
2017 paragraph's. This avoids running the expensive loop when a line
2018 ends in a long sequence of neutrals, like control characters.
2019 Add assertion against STRONG_AL type. Slightly rearrange code
2020 that determines the type of a neutral given the first non-neutral
2021 that follows it.
2022 (bidi_level_of_next_char): Set next_en_pos to zero when
2023 invalidating its info.
2024
2c91f553
EZ
20252011-10-17 Eli Zaretskii <eliz@gnu.org>
2026
2027 * xdisp.c (push_display_prop): Determine whether to record string
2028 or buffer position by IT->string, not by IT->method. Allow
2029 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2030 (move_it_vertically_backward): Don't look for character position
2031 immediately after the newline when in a continuation line.
2032 (Bug#9771, part 1)
2c91f553 2033
c7b08b0d
MR
20342011-10-15 Martin Rudalics <rudalics@gmx.at>
2035
2036 * window.c (coordinates_in_window): Rewrite and delabelize
2037 vertical border check. (Bug#5357) (Bug#9618)
2038
6b02f655
SM
20392011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2040
2041 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2042 errors in XSetWindowBorder (bug#9310).
2043
81d40c92
DA
20442011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2045
2046 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2047 avoid crash when xmalloc overrun checking is enabled.
2048
d4172c3b
EZ
20492011-10-13 Eli Zaretskii <eliz@gnu.org>
2050
2051 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2052 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2053 cursor motion with <left> and <right> arrow keys.
2054
2055 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2056 some callers set that themselves.
2057
b00eea75
EZ
20582011-10-12 Eli Zaretskii <eliz@gnu.org>
2059
2060 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2061 display string and the previous row comes from the same string and
2062 is empty. (Bug#9739) (Bug#9738)
2063
8fe012c4
SM
20642011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2065
2066 * doc.c (get_doc_string): Encode file name (bug#9735).
2067
0074aef2
EZ
20682011-10-12 Eli Zaretskii <eliz@gnu.org>
2069
79beb178
EZ
2070 * bidi.c (bidi_level_of_next_char):
2071 * xdisp.c (get_visually_first_element): Remove old incorrect
2072 comments regarding the Unicode Line Separator character.
2073
0074aef2
EZ
2074 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2075
6e4b3fbe
DA
20762011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2077
2078 * alloc.c (Fgc_status): Do not access beyond zombies array
2079 boundary if nzombies > MAX_ZOMBIES.
2080 * alloc.c (dump_zombies): Add missing format specifier.
2081
0324f3af
PE
20822011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2083
b5525cac
PE
2084 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2085 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2086
0324f3af
PE
2087 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2088 Some packages use them to denote characters with modifiers.
2089
e9b5f888
AS
20902011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2091
2092 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2093 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2094 matching a pp-number. Rename parameter var to var1.
2095
127827c0
SM
20962011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2097
2098 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2099
c8fd3bd0
GM
21002011-10-08 Glenn Morris <rgm@gnu.org>
2101
2102 * callint.c (Fcall_interactively): Give a more explicit error for the
2103 'c' case with a non-character input. (Bug#8479)
2104
352ec8ff
EZ
21052011-10-08 Eli Zaretskii <eliz@gnu.org>
2106
03669ccb
EZ
2107 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2108 lines.
7061c986
EZ
2109 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2110 lines that are hscrolled on the left.
03669ccb 2111
352ec8ff
EZ
2112 * dispnew.c (buffer_posn_from_coords): Account for a possible
2113 presence of header-line. (Bug#4426)
2114
a66cfb1c
SM
21152011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2116
6b02f655
SM
2117 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2118 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2119
7c5ee88e
PE
21202011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2121
2122 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2123 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2124 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2125 this makes Emacs dump core during garbage collection on rare
2126 occasions. sizeof is obviously inferior to offsetof here, so
2127 stick with offsetof.
2128 (GC_POINTER_ALIGNMENT): New macro.
2129 (mark_memory): Omit 3rd (offset) arg; caller changed.
2130 Don't assume EMACS_INT alignment is the same as pointer alignment.
2131
df1bbe5b
SM
21322011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2133
2134 * keyboard.c (read_key_sequence_remapped): New var.
2135 (read_key_sequence): Compute remapping in the right buffer.
2136 (command_loop_1): Use read_key_sequence's remapping directly.
2137
51553db6
SM
21382011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2139
32c1fffd
SM
2140 * dired.c (file_name_completion): Don't expand file name.
2141 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2142 before checking file name handler.
2143
51553db6
SM
2144 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2145 they've been requested explicitly (bug#9591).
2146
b6bd1599 21472011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2148
2149 * keymap.c (Fsingle_key_description): Use make_specified_string
2150 instead of build_string to build string from push_key_description.
2151 (Bug#5193)
2152
f701dc2a
PE
21532011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2154
4222c55d
PE
2155 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2156 This fixes a Y2038 bug on 64-bit hosts.
2157 * buffer.c (reset_buffer):
2158 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2159 (Fclear_buffer_auto_save_failure):
2160 Use 0, not -1, to represent an unset failure time, since time_t
2161 might not be signed.
2162
f701dc2a
PE
2163 Remove dependency on glibc malloc internals.
2164 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2165 Move back here from lisp.h, but with their new implementations.
2166 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2167 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2168 * charset.c (charset_table_init): New static var.
2169 (syms_of_charset): Use it instead of xmalloc. This removes a
2170 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2171 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2172 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2173 Move back to alloc.c.
2174 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2175 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2176
9ceebf39
JD
21772011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2178
2179 * nsterm.m (windowDidResize): Call x_set_window_size only when
2180 ns_in_resize is true. Otherwise set pixelwidth/height and
2181 call change_frame_size (Bug#9628).
2182
cb993c58
PE
21832011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2184
3930c88b
PE
2185 Port --enable-checking=all to Fedora 14 x86-64.
2186 * charset.c (syms_of_charset): Also account for glibc malloc's
2187 internal overhead when calculating the initial malloc maximum.
2188
cb993c58
PE
2189 Port --enable-checking=all to Fedora 14 x86.
2190 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2191 Move to lisp.h.
2192 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2193 (overrun_check_realloc, overrun_check_free):
2194 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2195 That way, xmalloc returns a properly-aligned pointer even if
2196 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2197 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2198 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2199 into account when calculating the initial malloc maximum.
2200 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2201 Move here from alloc.c, so that charset.c can use it too.
2202 Properly align; the old code wasn't right for common 32-bit hosts
2203 when configured with --enable-checking=all.
2204 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2205 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2206
31bed486
EZ
22072011-09-29 Eli Zaretskii <eliz@gnu.org>
2208
04c70788 2209 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2210 use EDOM.
2211
fbcaa2f3
EZ
22122011-09-28 Eli Zaretskii <eliz@gnu.org>
2213
2214 * xdisp.c (compute_display_string_end): If there's no display
2215 string at CHARPOS, return -1.
2216
2217 * bidi.c (bidi_fetch_char): When compute_display_string_end
2218 returns a negative value, treat the character as a normal
2219 character not covered by a display string. (Bug#9624)
2220
a239d4e9
JB
22212011-09-28 Juanma Barranquero <lekktu@gmail.com>
2222
2223 * lread.c (Fread_from_string): Fix typo in docstring.
2224
88652fd5
EZ
22252011-09-27 Eli Zaretskii <eliz@gnu.org>
2226
2227 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2228 newline, reseat the iterator instead of bidi-iterating there one
2229 character at a time. (Bug#9610)
32c1fffd
SM
2230 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2231 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2232
ed497dd4
AS
22332011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2234
2235 * lread.c (readevalloop): Use correct code for NBSP.
2236 (read1): Likewise. (Bug#9608)
2237
b2bf61aa
MA
22382011-09-25 Michael Albinus <michael.albinus@gmx.de>
2239
2240 * dbusbind.c (Fdbus_register_signal): When service is not
2241 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2242
32bbb17c
GM
22432011-09-25 Glenn Morris <rgm@gnu.org>
2244
2245 * buffer.c (truncate-lines): Doc fix.
2246
94e0933e
CY
22472011-09-24 Chong Yidong <cyd@stupidchicken.com>
2248
2249 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2250 (Fset_window_next_buffers): Doc fix.
2251
cddde921
GM
22522011-09-24 Glenn Morris <rgm@gnu.org>
2253
2254 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2255
1260aef1
PE
22562011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2257
25b4bfa0
PE
2258 Fix minor problems found by static checking.
2259 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2260 * indent.c (Fvertical_motion): Fix == vs = typo.
2261
e3cbd34b
EZ
22622011-09-24 Eli Zaretskii <eliz@gnu.org>
2263
a66cfb1c
SM
2264 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2265 Default value is now t. Doc fix.
6bf7006f 2266
e3cbd34b 2267 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2268 logic when moving up, not only when moving down. Fix the
e3cbd34b 2269 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2270 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2271
2272 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2273 CHARPOS is covered by a display string which includes newlines.
2274 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2275 is covered by a display string with embedded newlines.
2276
a3de0cbd
MA
22772011-09-24 Michael Albinus <michael.albinus@gmx.de>
2278
2279 * dbusbind.c (Fdbus_register_signal): Add match rule to
2280 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2281 (Fdbus_register_method, Vdbus_registered_objects_table):
2282 Fix docstring.
a3de0cbd 2283
b260039d
JM
22842011-09-24 Jim Meyering <meyering@redhat.com>
2285
32c1fffd 2286 do not ignore write error for any output size
b260039d
JM
2287 The previous change was incomplete.
2288 While it makes emacs --batch detect the vast majority of stdout
2289 write failures, errors were still ignored whenever the output size is
2290 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2291 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2292 && echo FAIL: ignored write error
2293 FAIL: ignored write error
2294 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2295 && echo FAIL: ignored write error
2296 FAIL: ignored write error
2297 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2298
8eca8a7c
AS
22992011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2300
2301 * emacs.c (Fkill_emacs): In noninteractive mode exit
2302 non-successfully if a write error occurred on stdout. (Bug#9574)
2303
3341db62
EZ
23042011-09-21 Eli Zaretskii <eliz@gnu.org>
2305
2306 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2307 the xassert test.
2308
2309 * dispextern.h (struct it): Update the comment documenting what
2310 can it->OBJECT be.
2311
8c203dbf
EZ
23122011-09-20 Eli Zaretskii <eliz@gnu.org>
2313
2314 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2315 a display string, extend search for cursor position to end of row.
2316 (find_row_edges): If the row ends in a newline from a display
2317 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2318 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2319 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2320 non-empty line. Fixes confusing cursor motion with arrow keys at
2321 the beginning of a line that starts with whitespace.
8c203dbf 2322
a4824228
LMI
23232011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2324
2325 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2326 (bug#9493).
2327
33ed493b
CY
23282011-09-18 Chong Yidong <cyd@stupidchicken.com>
2329
2330 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2331 boolean (Bug#9154).
2332
56cd55c8
EZ
23332011-09-18 Eli Zaretskii <eliz@gnu.org>
2334
2335 * xdisp.c (display_line): Record maximum and minimum buffer
2336 positions even if no glyphs were produced (e.g., by a zero-width
2337 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2338 buffer positions that will be removed from the glyph row because
2339 they don't fit.
c02dcedf
EZ
2340 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2341 column is beyond frame width: don't subtract 1 "pixel" when
2342 computing width of the stretch.
3e62b7e0
EZ
2343 (reseat_at_next_visible_line_start): Undo the change made on
2344 2011-09-17 that saved paragraph information and restored it after
2345 the call to `reseat'. (Bug#9545)
56cd55c8 2346
5ed99d36 23472011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2348
2349 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2350 and turn window cursor on if cleared (Bug#9415).
2351
5ed99d36 23522011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2353
2354 * search.c (boyer_moore): Take unibyte characters from pattern
2355 literally. (Bug#9458)
2356
9bade7b2
EZ
23572011-09-18 Eli Zaretskii <eliz@gnu.org>
2358
2359 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2360
e5e9d610
PE
23612011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2362
87e4427a
PE
2363 Fix minor problem found by static checking.
2364 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2365 initialized, to pacify gcc -Wuninitialized.
2366
e5e9d610
PE
2367 * fileio.c: Report proper errno when syscall falls.
2368 (Finsert_file_contents): Save and restore errno,
2369 so that report_file_error outputs the correct diagnostic.
2370 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2371
a1674f0b
EZ
23722011-09-18 Eli Zaretskii <eliz@gnu.org>
2373
2374 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2375
fbfb6dd4
EZ
23762011-09-17 Eli Zaretskii <eliz@gnu.org>
2377
2378 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2379 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2380
bb187662
EZ
23812011-09-17 Eli Zaretskii <eliz@gnu.org>
2382
1137e8b8 2383 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2384 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2385
2386 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2387 (bidi_find_paragraph_start): Search back for paragraph beginning
2388 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2389 (bidi_move_to_visually_next): Only trigger paragraph-related
2390 computations when the last character is a newline or at EOB, not
2391 just any NEUTRAL_B. (Bug#9470)
2392
bb187662
EZ
2393 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2394 truncated lines if point is covered by a display string. (Bug#9524)
2395
2e621251
PE
23962011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2397
2398 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2399 (cons_to_x_long): New function.
2400 (lisp_data_to_selection_data): Use it. Correct the test for
2401 short-versus-long data; it was negated. Break out of vector
2402 loop, for efficiency, when a long datum is discovered.
2403
91a15bc6
SM
24042011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2405
2406 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2407
b41c3a35
EZ
24082011-09-16 Eli Zaretskii <eliz@gnu.org>
2409
2410 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2411 GCC PR/17406) by declaring this function with external scope.
2412
7812ba2d
PE
24132011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2414
2415 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2416 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2417
cf7edc2a
AS
24182011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2419
2420 * editfns.c (Fformat): Correctly handle text properties on "%%".
2421
bd01620e
EZ
24222011-09-15 Eli Zaretskii <eliz@gnu.org>
2423
2424 * xterm.c (x_draw_composite_glyph_string_foreground):
2425 * w32term.c (x_draw_composite_glyph_string_foreground):
2426 * term.c (encode_terminal_code):
2427 * composite.c (composition_update_it, get_composition_id):
2428 * xdisp.c (get_next_display_element)
2429 (fill_composite_glyph_string): Add comments about special meaning
2430 of TAB characters in a composition.
2431
a02719a3
PE
24322011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2433
2434 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2435 This occurs when processing a multibyte format.
2436 Problem reported by Wolfgang Jenker.
a02719a3 2437
72589a3c
JB
24382011-09-15 Johan Bockgård <bojohan@gnu.org>
2439
2440 * xdisp.c (try_cursor_movement): Only check for exact match if
2441 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2442
1c14176c
PE
24432011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 Remove unused external symbols.
2446 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2447 * xdisp.c (calc_pixel_width_or_height): Now static.
2448 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2449 * indent.c (check_display_width):
2450 * w32term.c: Fix comment to match code.
2451 * xterm.c, xterm.h (x_catching_errors): Remove.
2452
d2eea5b5
PE
24532011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2454
2455 * xselect.c: Use signed conversions more consistently (Bug#9498).
2456 (selection_data_to_lisp_data): Assume incoming selection data are
2457 signed integers, not unsigned. This is to be consistent with
2458 outgoing selection data, which was modified to use signed integers
2459 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2460 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2461 expects long, not unsigned long.
2462
46888499
EZ
24632011-09-14 Eli Zaretskii <eliz@gnu.org>
2464
2465 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2466 computation of loop end. Reported by Johan Bockgård
2467 <bojohan@gnu.org>.
2468
ef8ef9fb
CY
24692011-09-13 Chong Yidong <cyd@stupidchicken.com>
2470
2471 * frame.c (Fother_visible_frames_p): Function deleted.
2472
fa819fed
EZ
24732011-09-12 Eli Zaretskii <eliz@gnu.org>
2474
2475 * indent.c (compute_motion): Process display vector front to back
2476 rather than the other way around. (Bug#2496)
2477
2ba8e008
SM
24782011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2479
2480 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2481
20f53c69
CY
24822011-09-11 Chong Yidong <cyd@stupidchicken.com>
2483
2484 * minibuf.c (Fread_from_minibuffer): Doc fix.
2485
d562d7a4
EZ
24862011-09-11 Eli Zaretskii <eliz@gnu.org>
2487
2488 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2489 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2490
1c4d7f3d
LMI
24912011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2492
2493 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2494 value for non-existent files.
2495
b885bf36
EZ
24962011-09-11 Eli Zaretskii <eliz@gnu.org>
2497
2498 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2499 set its "size" to -1. This will set the modtime_size field of
2500 the corresponding buffer to -1, which is what
2501 verify-visited-file-modtime expects for files that do not exist.
2502 (Bug#9139)
2503
6612f0bf
PE
25042011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2505
2506 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2507 here ...
2508 * lisp.h: ... from here. push_key_description is no longer
2509 defined in keyboard.c, so its declaration should not be in
2510 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2511 logically belongs with push_key_description.
2512
dfb3f755
PE
25132011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2514
2515 * buffer.h: Include <sys/types.h> instead of <time.h>.
2516 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2517 Problem reported by Herbert J. Skuhra.
2518
3134906c
LMI
25192011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2520
2521 * xml.c (parse_region): Make the parsing work for
2522 non-comment-starting XML files again (bug#9144).
2523
8d903f4e
AS
25242011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2525
2526 * image.c (gif_load): Fix calculation of bottom and right corner.
2527 (Bug#9468)
2528
80ad64f4
EZ
25292011-09-10 Eli Zaretskii <eliz@gnu.org>
2530
2531 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2532 redisplay in small windows.
2533
208a048d
EZ
25342011-09-09 Eli Zaretskii <eliz@gnu.org>
2535
2536 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2537
9b1c252e
MR
25382011-09-08 Martin Rudalics <rudalics@gmx.at>
2539
2540 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2541 Operate on live windows only.
2542
2949f33b
JB
25432011-09-08 Juanma Barranquero <lekktu@gmail.com>
2544
2545 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2546
e08dcafd
EZ
25472011-09-07 Eli Zaretskii <eliz@gnu.org>
2548
2549 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2550 only under bidi iteration.
2551
115b96bd
JD
25522011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2553
2554 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2555
c8199d0f
PE
25562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2557
2558 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2559 Without this fix, the command to link temacs failed due to an
2560 undefined symbol __builtin_isnan. This is because
2561 /usr/include/iso/math_c99.h #defines isnan(x) to
2562 __builtin_isnan(x), but the bundled gcc, which identifies itself
2563 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2564 a __builtin_isnan.
2565 * floatfns.c (isnan): #undef, and then #define to a clone of
2566 what's in data.c.
2567 (Fisnan): Always define, since it's always available now.
2568 (syms_of_floatfns): Always define isnan at the Lisp level.
2569
e39b275c 25702011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2571
2572 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2573
b2db44d9 25742011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2575
f4af5137 2576 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2577 The previous code assumed that file offsets (off_t values) fit in
2578 EMACS_INT variables, which is not true on typical 32-bit hosts.
2579 The code messed up by falsely reporting buffer overflow in cases
2580 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2581 when "big" contains more than 2**29 bytes, even though this
2582 inserts just one byte and does not overflow the buffer.
2583 (Finsert_file_contents): Store file offsets as off_t
2584 values, not as EMACS_INT values. Check for overflow when
2585 converting between EMACS_INT and off_t. When checking for
2586 buffer overflow or for overlap, take the offsets into account.
2587 Don't use EMACS_INT for small values where int suffices.
2588 When checking for overlap, fix a typo: ZV was used where
2589 ZV_BYTE was intended.
2590 (Fwrite_region): Don't assume off_t fits into 'long'.
2591 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2592
ecfc0a49
MA
25932011-09-05 Michael Albinus <michael.albinus@gmx.de>
2594
2595 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2596
6511acf2 25972011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2598
0999621a 2599 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2600
2601 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2602 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2603 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2604 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2605 (modify_event_symbol): Do not assume that the length of
2606 name_alist_or_stem is safe to alloca and fits in int.
2607 (Fexecute_extended_command): Likewise for function name and binding.
2608 (Frecursion_depth): Wrap around reliably on integer overflow.
2609 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2610 since some callers pass EMACS_INT values.
2611 (Fsingle_key_description): Don't crash if symbol name contains more
2612 than MAX_ALLOCA bytes.
2613 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2614 (get_minibuffer): Arg is now EMACS_INT, not int.
2615 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2616 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2617 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2618
2be7d702
PE
2619 * dbusbind.c (signature_cat): New function.
2620 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2621 Do not overrun buffer; instead, report string overflow.
2622
9d1df220
PE
2623 * dispnew.c (add_window_display_history): Don't overrun buffer.
2624 Truncate instead; this is OK since it's just a log.
2625
33ef5c64
PE
2626 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2627 even if the time zone offset is outlandishly large.
2628 Don't mishandle offset == INT_MIN.
2629
66c6fdd5
PE
2630 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2631 when creating daemon; the previous buffer-overflow check was incorrect.
2632
d749b01b
PE
2633 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2634 which has the guts of the old verror function.
2635
b5cd1905
PE
2636 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2637 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2638
6e1a67fb
PE
2639 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2640 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2641 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2642 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2643 length of string rather than counting it via multiple sprintfs;
2644 that's simpler and more reliable.
c21721cc
PE
2645 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2646 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2647 sprintf, in case result does not fit in int.
2648
c57b67fc
PE
2649 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2650 (fontset_from_font): Print it.
2651
8a401434
PE
2652 * frame.c (tty_frame_count): Now printmax_t, not int.
2653 (make_terminal_frame, set_term_frame_name): Print it.
2654 (x_report_frame_params): In X, window IDs are unsigned long,
2655 not signed long, so print them as unsigned.
2656 (validate_x_resource_name): Check for implausibly long names,
2657 and don't assume name length fits in 'int'.
2658 (x_get_resource_string): Don't blindly alloca invocation name;
2659 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2660 not fit in int.
2661
6e1a67fb
PE
2662 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2663 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2664 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2665
0df02bf3
PE
2666 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2667 Use esprintf, not sprintf, in case result does not fit in int.
2668
48e30793
PE
2669 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2670 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2671 it as a large positive number.
2672 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2673 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2674
a66ff6d8
PE
2675 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2676 in case result does not fit in int.
2677
aca216ff
PE
2678 * print.c (float_to_string): Detect width overflow more reliably.
2679 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2680 buffer overrun. Don't assume list length fits in 'int'. Treat
2681 print length of 0 as 0, not as infinity; to be consistent with other
2682 uses of print length in this function. Don't overflow print length
2683 index. Don't assume hash table size fits in 'long', or that
2684 vectorlike size fits in 'unsigned long'.
2685
31c286f7
PE
2686 * process.c (make_process): Use printmax_t, not int, to format
2687 process-name gensyms.
2688
55e5faa1
PE
2689 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2690
80f2e268
PE
2691 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2692 to avoid potential buffer overrun.
2693
670741ab
PE
2694 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2695 if X resource line is longer than 512 bytes.
2696
b7163a50
PE
2697 * xfns.c (x_window): Make sprintf buffer a bit bigger
2698 to avoid potential buffer overrun.
2699
ae58ff1f
PE
2700 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2701
c43c8a6a
PE
2702 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2703
3f8236f4
PE
27042011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2705
53e9fe90 2706 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2707 Without these, Emacs silently mishandles large integers sometimes.
2708 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2709 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2710
6511acf2
PE
2711 * xdisp.c (try_window_id): Check Emacs fixnum range before
2712 converting to 'int'.
806add1d 2713
6511acf2 2714 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2715 Check that an Emacs fixnum is in range before assigning it to 'int'.
2716 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2717 values converted from Emacs fixnums.
2718 (Frecenter): Don't wrap around a line count if it is out of 'int'
2719 range; instead, treat it as an extreme value.
2720 (Fset_window_configuration, compare_window_configurations):
2721 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2722
6511acf2
PE
2723 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2724 that can exceed INT_MAX. Check that EMACS_INT value is in range
2725 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2726 (match_limit): Don't assume that a fixnum can fit in 'int'.
2727
6511acf2 2728 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2729 exceed INT_MAX.
2730
6511acf2 2731 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2732 (Fvertical_motion): Don't wrap around LINES values that don't fit
2733 in 'int'. Instead, treat them as extreme values. This is good
2734 enough for windows, which can't have more than INT_MAX lines anyway.
2735
fcb901a7
LMI
27362011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2737
0f2f6b6d
LMI
2738 * Require libxml/parser.h to avoid compilation warning.
2739
fcb901a7
LMI
2740 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2741
2742 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2743 since this reportedly can destroy thread storage.
2744
6e20a0d4
CY
27452011-08-30 Chong Yidong <cyd@stupidchicken.com>
2746
2747 * syntax.c (find_defun_start): Update all cache variables if
2748 exiting early (Bug#9401).
2749
148ae00e
EZ
27502011-08-30 Eli Zaretskii <eliz@gnu.org>
2751
f6cfbd8f
EZ
2752 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2753
148ae00e
EZ
2754 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2755 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2756 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2757
2758 * term.c (tty_append_glyph): New function.
2759 (produce_stretch_glyph): Static function and its prototype deleted.
2760
a66cfb1c
SM
2761 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2762 Add prototypes.
148ae00e 2763
c4a07a4c
PE
27642011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2765
2766 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2767 when checking :margin (Bug#9390).
2768 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2769 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2770 so that the name doesn't mislead. All uses changed.
2771
6bc8cd65
JB
27722011-08-28 Johan Bockgård <bojohan@gnu.org>
2773
2774 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2775 set_tty_hooks.
2776
dca4927e
EZ
27772011-08-27 Eli Zaretskii <eliz@gnu.org>
2778
2779 * xdisp.c (move_it_to): Don't bail out early when reaching
2780 position beyond to_charpos, if we are scanning backwards.
2781 (move_it_vertically_backward): When DY == 0, make sure we get to
2782 the first character in the line after the newline.
2783
f2cad773
PE
27842011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2785
2786 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2787 (ccl_driver): Do not generate an out-of-range pointer.
2788 (Fccl_execute_on_string): Remove unnecessary check for
2789 integer overflow, noted by Stefan Monnier in
2790 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2791 Remove a FIXME that didn't need fixing.
2792 Simplify the newly-introduced buffer reallocation code.
2793
0cae2cdb
JB
27942011-08-27 Juanma Barranquero <lekktu@gmail.com>
2795
2796 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2797
5fc295a4 27982011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2799
70c60eb2 2800 Integer and memory overflow issues (Bug#9196).
726e0ab1 2801
d31850da
PE
2802 * doc.c (get_doc_string): Rework so that
2803 get_doc_string_buffer_size is the actual buffer size, rather than
2804 being 1 less than the actual buffer size; this makes xpalloc more
2805 convenient.
2806
a69fbedb
PE
2807 * image.c (x_allocate_bitmap_record, cache_image):
2808 * xselect.c (Fx_register_dnd_atom):
2809 Simplify previous changes by using xpalloc.
2810
fe5c5d37
PE
2811 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2812 since either will do and ptrdiff_t is convenient with xpalloc.
2813
0065d054
PE
2814 * charset.c (charset_table_size)
2815 (struct charset_sort_data.priority): Now ptrdiff_t.
2816 (charset_compare): Don't overflow if priorities differ greatly.
2817 (Fsort_charsets): Don't assume list length fits in int.
2818 Check for size-calculation overflow when allocating sort data.
2819 (syms_of_charset): Allocate an initial charset table that is
2820 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2821
2822 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2823
2824 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2825 The actual value is always <= INT_MAX, and leaving it unsigned made
2826 overflow checking harder.
2827
2828 * dispextern.h (struct glyph_matrix.rows_allocated)
2829 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2830 with xpalloc. The values are still always <= INT_MAX.
2831
2832 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2833
2834 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2835 (SAFE_NALLOCA): New macro.
2836
2837 * region-cache.c (struct boundary.pos, find_cache_boundary)
2838 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2839 (set_cache_region, invalidate_region_cache)
2840 (revalidate_region_cache, know_region_cache, region_cache_forward)
2841 (region_cache_backward, pp_cache):
2842 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2843 so that ptrdiff_t * can be passed to xpalloc.
2844 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2845 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2846 (pp_cache): Don't assume cache_len fits in int.
2847 * region-cache.h: Adjust extern decls to match.
2848
2849 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2850 EMACS_INT, since either will do, for xpalloc.
2851
2852 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2853 (xnmalloc, xnrealloc, xpalloc): New functions.
2854
726e0ab1
PE
2855 * bidi.c (bidi_shelve_header_size): New constant.
2856 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2857 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2858
51f30bc5 2859 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2860 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2861 (overlay_strings):
2862 Don't update size of array until after memory allocation succeeds,
2863 because xmalloc/xrealloc may not return.
0065d054
PE
2864 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2865 now that we have proper integer overflow checking.
2866 (record_overlay_string, overlay_strings): Catch overflows when
2867 calculating size of overlay_str_buf.
726e0ab1 2868
0065d054
PE
2869 * callproc.c (Fcall_process): Check for size overflow when
2870 calculating size of args2.
2871 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2872 Normally we prefer signed values, but sticking with ptrdiff_t would
2873 require adding more-complicated checks.
726e0ab1
PE
2874
2875 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2876 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2877 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2878 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2879
2880 * character.c (Fstring): Check for size-calculation overflow.
2881
2882 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2883 unnecessary integer overflow. Check for size overflow.
2884 (encode_coding_object): Don't update size until xmalloc succeeds.
2885
2886 * composite.c (get_composition_id): Check for overflow in glyph
2887 length calculations.
2888
2889 Integer and memory overflow fixes for display code.
2890 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2891 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2892 (scrolling_window): Check for overflow in size calculations.
2893 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2894 Don't assume glyph table len fits in int.
2895 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2896 (row_table_size): Now ptrdiff_t, not int.
2897 (scrolling_window): Avoid overflow in size calculations.
2898 Don't update size until allocation succeeds.
2899 * fns.c (concat): Check for overflow in size calculations.
2900 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2901 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2902 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2903
2904 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2905 (get_doc_string): Check for size calculation overflow.
2906 Don't update size until allocation succeeds.
2907 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2908 EMACS_INT, where ptrdiff_t will do.
2909 (Fsubstitute_command_keys): Check for string overflow.
2910
2911 * editfns.c (set_time_zone_rule): Don't assume environment length
2912 fits in int.
2913 (message_length): Now ptrdiff_t, not int.
2914 (Fmessage_box): Don't update size until allocation succeeds.
2915 Don't assume message length fits in int.
2916 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2917
0065d054
PE
2918 * emacs.c (main): Do not reallocate argv, since there is a null at
2919 the end that can be overwritten, and this way there's no need to
2920 worry about size-calculation overflow.
2921 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2922
2923 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2924 alloc succeeds.
2925 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2926
2927 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2928 (x_set_scroll_bar_width, x_figure_window_size):
2929 Check for integer overflow.
2930 (x_set_alpha): Do not assume XINT fits in int.
2931
2932 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2933 This is for the members text_lines, text_cols, total_lines, total_cols,
2934 where the system imposes an 'int' limit.
2935
2936 * fringe.c (Fdefine_fringe_bitmap):
2937 Don't update size until alloc works.
2938
2939 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2940 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2941
2942 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2943 Check for size-calculation overflow.
2944 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2945 do, as we prefer signed integers.
2946 (id_to_widget.max_size, id_to_widget.used)
2947 (xg_store_widget_in_map, xg_remove_widget_from_map)
2948 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2949 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2950 Use and return ptrdiff_t, not int.
2951 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2952 * gtkutil.h: Change prototypes to match the above.
2953
2954 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2955 are duplicate now that they've been promoted to lisp.h.
2956 (x_allocate_bitmap_record, x_alloc_image_color)
2957 (make_image_cache, cache_image, xpm_load):
2958 Don't update size until alloc is done.
2959 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2960 (x_detect_edges):
3256efce 2961 Check for size calculation overflow.
726e0ab1
PE
2962 (ct_colors_allocated_max): New constant.
2963 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2964 overflow.
3256efce 2965
726e0ab1
PE
2966 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2967 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2968 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2969 Use ptrdiff_t, not int, to count maps.
2970 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2971 calculations. Don't update size until allocation succeeds.
2972 Redo calculations to avoid overflow.
726e0ab1
PE
2973 * keyboard.h: Change prototypes to match the above.
2974
2975 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2976 to count maps.
2977 (current_minor_maps): Check for size calculation overflow.
2978 * keymap.h: Change prototypes to match the above.
2979
2980 * lread.c (read1, init_obarray): Don't update size until alloc done.
2981
2982 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2983 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2984
726e0ab1
PE
2985 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2986 Now ptrdiff_t, not int.
2987 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2988 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2989
2990 * process.c (Fnetwork_interface_list): Check for overflow
2991 in size calculation.
2992
2993 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2994
2995 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2996 overflow. Don't bother calling xmalloc when xrealloc will do.
2997
2998 * search.c (Freplace_match): Check for size calculation overflow.
2999 (Fset_match_data): Don't assume list lengths fit in 'int'.
3000
3001 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3002 for command line length. Do not attempt to address one before the
3003 beginning of an array, as that's not portable.
3004
3005 * term.c (max_frame_lines): Remove; unused.
3006 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3007 not int.
3008 (encode_terminal_code, calculate_costs): Check for size
3009 calculation overflow.
3010 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3011 table lengths and related sizes. Don't update size until alloc
3012 done. Redo calculations to avoid overflow.
3013 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3014
3015 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3016 subtracting pointers.
3017 (gobble_line): Check for overflow more carefully. Don't update size
3018 until alloc done.
3019
3020 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3021 Don't update size until alloc done.
3022 Redo size calculations to avoid overflow.
3023 Check for size calculation overflow.
0065d054 3024 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3025
3026 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3027 Use ptrdiff_t, not int, for sizes.
3028 (store_mode_line_noprop_char): Don't update size until alloc done.
3029
0065d054
PE
3030 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3031 Use ptrdiff_t, not int, for sizes.
3032 (Finternal_make_lisp_face, cache_face):
3033 Check for size calculation overflow.
3034 (cache_face): Treat size calculation overflows as if they were
3035 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3036
3037 * xfns.c (x_encode_text, x_set_name_internal)
3038 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3039 sizes, since they can exceed INT_MAX in size. Check for size
3040 calculation overflow.
3041
0065d054
PE
3042 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3043 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3044 Don't update size until alloc done.
3045
0065d054 3046 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3047 as sprintf is limited to int lengths.
1d526e2f 3048
252c5ee1
PE
3049 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3050 (X_LONG_MIN): New macros.
864d7ce7
PE
3051 Use them to make the following changes clearer.
3052 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3053 This change doesn't affect the value now, but it may help remind
3054 future maintainers not to raise the value too much later.
3055 (SELECTION_QUANTUM): Remove, replacing with ...
3056 (selection_quantum): ... new function, which avoids overflow.
3057 All uses changed.
3058 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3059 assumption that selection length fits in 'int'.
3060 (x_reply_selection_request, x_handle_selection_request)
3061 (x_get_window_property, receive_incremental_selection)
3062 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3063 (lisp_data_to_selection_data, clean_local_selection_data):
3064 Use ptrdiff_t, not int, to record length of selection.
3065 (x_reply_selection_request, x_get_window_property)
3066 (receive_incremental_selection, x_property_data_to_lisp):
3067 Redo calculations to avoid overflow.
3068 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3069 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3070 something.
3071 (x_get_window_property, receive_incremental_selection)
3072 (lisp_data_to_selection_data, x_property_data_to_lisp):
3073 Check for size-calculation overflow.
3074 (x_get_window_property, receive_incremental_selection)
3075 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3076 Don't store size until memory allocation succeeds.
3077 (x_get_window_property): Plug memory leak on memory exhaustion.
3078 Don't double-block input; malloc is safe here. Don't assume 2**34
3079 - 4 fits in unsigned long. Add an xassert to check
3080 XGetWindowProperty overflow. Be more careful about overflow
3081 calculations, and distinguish size from memory overflow better.
3082 (receive_incremental_selection): When tracing, don't assume
3083 unsigned int is less than INT_MAX.
3084 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3085 harmful) conversions of unsigned short to int.
3086 (lisp_data_to_selection_data): Don't assume that integers
3087 in the range -65535 through -1 fit in an X unsigned short.
3088 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3089 result parameters unless successful. Rely on cons_to_unsigned
3090 to report problems with elements; the old code wasn't right anyway.
3091 (x_check_property_data): Check for int overflow; we cannot use
3092 a wider type due to X limits.
3093 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3094
726e0ab1 3095 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3096
0065d054
PE
3097 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3098 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3099 (x_color_cells): Don't store size until memory allocation succeeds.
3100 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3101 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3102 (x_term_init): Don't assume length fits in int (sprintf is limited
3103 to int size).
bc18e09d 3104
ebfa62c0
PE
3105 Use ptrdiff_t for composition IDs.
3106 * character.c (lisp_string_width):
3107 * composite.c (composition_table_size, n_compositions)
3108 (get_composition_id, composition_gstring_from_id):
3109 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3110 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3111 * window.c (Frecenter):
3112 Use ptrdiff_t, not int, for composition IDs.
3113 * composite.c (get_composition_id): Check for integer overflow.
3114 * composite.h: Adjust prototypes to match the above changes.
3115
d3411f89
PE
3116 Use ptrdiff_t for hash table indexes.
3117 * category.c (hash_get_category_set):
3118 * ccl.c (ccl_driver):
3119 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3120 * coding.c (coding_system_charset_list, detect_coding_system):
3121 * coding.h (struct coding_system.id):
3122 * composite.c (get_composition_id, gstring_lookup_cache):
3123 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3124 * image.c (xpm_get_color_table_h):
3125 * lisp.h (hash_lookup, hash_put):
3126 * minibuf.c (Ftest_completion):
3127 Use ptrdiff_t for hash table indexes, not int (which is too
3128 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3129 32-bit --with-wide-int hosts).
3130
e097a6fa
PE
3131 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3132 Add a FIXME comment about memory leaks.
3133 (syms_of_charset): Don't assume xmalloc returns.
3134
5637687f
PE
3135 Don't assume that stated character widths fit in int.
3136 * character.c (Fchar_width, c_string_width, lisp_string_width):
3137 * character.h (CHAR_WIDTH):
3138 * indent.c (MULTIBYTE_BYTES_WIDTH):
3139 Use sanitize_char_width to avoid undefined and/or bad behavior
3140 with outlandish widths.
a66cfb1c 3141 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3142 now that we have two such functions. All uses changed.
3143 (sanitize_char_width): New inline function.
3144
a2271ba2
PE
3145 Don't assume that tab-width fits in int.
3146 * character.h (sanitize_width): New inline function.
3147 (SANE_TAB_WIDTH): New macro.
3148 (ASCII_CHAR_WIDTH): Use it.
3149 * indent.c (sane_tab_width): Remove. All uses replaced by
3150 SANE_TAB_WIDTH (current_buffer).
3151 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3152
18c52557
PE
3153 * fileio.c: Integer overflow issues with file modes.
3154 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3155
caeeedc1
PE
3156 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3157 Remove unreachable code.
3158 (read_hex, load_charset_map_from_file): Check for integer overflow.
3159
6df6ae42 3160 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3161 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3162 (x_send_scroll_bar_event): Likewise. Check that the size does not
3163 exceed limits imposed by XClientMessageEvent, as well as the usual
3164 ptrdiff_t and size_t limits.
3165
b13995db
PE
3166 * keyboard.c: Overflow, signedness and related fixes.
3167 (make_lispy_movement): Use same integer type in forward decl
3168 that is used in the definition.
3169 (read_key_sequence, keyremap_step):
3170 Change bufsize argument back to int, undoing my 2011-03-30 change.
3171 We prefer signed types, and int is wide enough here.
3172 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3173 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3174 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3175 length, not size_t. Use ptrdiff_t for index, not int.
3176 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3177 possibility of integer overflow.
3178
13464394
PE
3179 Overflow, signedness and related fixes for images.
3180
3181 * dispextern.h (struct it.stack[0].u.image.image_id)
3182 (struct_it.image_id, struct image.id, struct image_cache.size)
3183 (struct image_cache.used, struct image_cache.ref_count):
3184 * gtkutil.c (update_frame_tool_bar):
3185 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3186 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3187 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3188 * nsmenu.m (update_frame_tool_bar):
3189 * xdisp.c (calc_pixel_width_or_height):
3190 * xfns.c (image_cache_refcount):
3191 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3192 on typical 64-bit hosts.
3193
3194 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3195 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3196 Omit unnecessary casts to int.
3197 (parse_image_spec): Check that integers fall into 'int' range
3198 when the callers expect that.
3199 (image_ascent): Redo ascent calculation to avoid int overflow.
3200 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3201 (lookup_image): Remove unnecessary tests.
3202 (xbm_image_p): Locals are now of int, not EMACS_INT,
3203 since parse_image_check makes sure they fit into int.
3204 (png_load, gif_load, svg_load_image):
3205 Prefer int to unsigned where either will do.
3206 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3207 old tiff_error_handler and tiff_warning_handler.
3208 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3209 stack buffer overflows. It uses only the features of vsnprintf
3210 that are common to both POSIX and native Microsoft.
3211 (tiff_error_handler, tiff_warning_handler): Use it.
3212 (tiff_load, gif_load, imagemagick_load_image):
3213 Don't assume :index value fits in 'int'.
3214 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3215 (imagemagick_load_image): Check that crop parameters fit into
3216 the integer types that MagickCropImage accepts. Don't assume
3217 Vimagemagick_render_type has a nonnegative value. Don't assume
3218 size_t fits in 'long'.
3219 (gs_load): Use printmax_t to print the widest integers possible.
3220 Check for integer overflow when computing image height and width.
3221
c11821d4
EZ
32222011-08-26 Eli Zaretskii <eliz@gnu.org>
3223
3224 * xdisp.c (redisplay_window): Don't force window start if point
3225 will be invisible in the resulting window. (Bug#9324)
3226
0c95fcf7
EZ
32272011-08-25 Eli Zaretskii <eliz@gnu.org>
3228
3229 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3230 the display spec is of the form `(space ...)'.
3231 (handle_display_spec): Return the value returned by
3232 handle_single_display_spec, not just 1 or zero.
3233 (handle_single_display_spec): If the display spec is of the form
3234 `(space ...)', and specifies display in the text area, return 2
3235 rather than 1.
fee65a97 3236 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3237 accurately, and prefer exact match for point under bidi.
3238 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3239
3240 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3241 into disp_prop; all users changed.
3242
3243 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3244 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3245 for the text covered by the display property.
3246
e4ed06f1
CY
32472011-08-25 Chong Yidong <cyd@stupidchicken.com>
3248
3249 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3250 Change return value to nil.
3251 (Frecord_buffer): Delete unused function.
3252
f67cdd7f
EZ
32532011-08-24 Eli Zaretskii <eliz@gnu.org>
3254
5980d4c6
EZ
3255 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3256 buffers, return left-to-right.
8610fe8b
EZ
3257 (set_cursor_from_row): Consider candidate row a win if its glyph
3258 represents a newline and point is on that newline. Fixes cursor
3259 positioning on the newline at EOL of R2L text within L2R
3260 paragraph, and vice versa.
3261 (try_cursor_movement): Check continued rows, in addition to
3262 continuation rows. Fixes unwarranted scroll when point enters a
3263 continued line of R2L text within an L2R paragraph, or vice versa.
3264 (cursor_row_p): Consider the case of point being equal to
3265 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3266 from the end of a short line to the beginning of a continued line
3267 of R2L text within L2R paragraph.
3268 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3269 composed characters.
5980d4c6 3270
f67cdd7f
EZ
3271 * bidi.c (bidi_check_type): Use xassert.
3272 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3273 members.
3274
bca633fb
EZ
32752011-08-23 Eli Zaretskii <eliz@gnu.org>
3276
3277 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3278 a character.
3279
4a5885a7
CY
32802011-08-23 Chong Yidong <cyd@stupidchicken.com>
3281
3282 * nsfont.m (ns_otf_to_script): Fix typo.
3283
0902a04e
KH
32842011-08-22 Kenichi Handa <handa@m17n.org>
3285
3286 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3287 extra slot even if the purpose is char-code-property-table.
3288
1a2e6670
EZ
32892011-08-23 Eli Zaretskii <eliz@gnu.org>
3290
8ddde651
EZ
3291 * xdisp.c (redisplay_window): When computing centering_position,
3292 account for the height of the header line. (Bug#8874)
3293
425cc014
EZ
3294 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3295 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3296 candidate is selected by the mouse, and that candidate has a
3297 composed character under the mouse.
3298
1a2e6670
EZ
3299 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3300 coordinates reported by pos-visible-in-window-p for a composed
3301 character in column zero.
3302
8b76d6f8
SM
33032011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3304
3305 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3306
dac347dd
EZ
33072011-08-22 Eli Zaretskii <eliz@gnu.org>
3308
3309 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3310 consider it a hit if to_charpos is anywhere in the range of the
3311 composed buffer positions.
3312
e013fb34
CY
33132011-08-22 Chong Yidong <cyd@stupidchicken.com>
3314
3315 * image.c (gif_load): Don't assume that each subimage has the same
3316 dimensions as the base image. Handle disposal method that is
3317 "undefined" by the gif spec (Bug#9335).
3318
bd1ba3e8
CY
33192011-08-20 Chong Yidong <cyd@stupidchicken.com>
3320
3321 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3322 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3323
54a1215b
EZ
33242011-08-19 Eli Zaretskii <eliz@gnu.org>
3325
823564e5
EZ
3326 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3327 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3328 from an Org mode buffer to a Speedbar frame.
3329
54a1215b
EZ
3330 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3331 a composition, take its buffer position from IT->cmp_it.charpos.
3332 Fixes cursor positioning at the beginning of a line that begins
3333 with a composed character.
3334
9778ebcc
EZ
33352011-08-18 Eli Zaretskii <eliz@gnu.org>
3336
0be6ee06
EZ
3337 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3338 character bidirectional type, use STRONG_L instead. Fixes crashes
3339 in a buffer produced by `describe-categories'.
3340
9778ebcc
EZ
3341 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3342 members before the level stack, so they would be saved and
3343 restored when copying iterator state. Fixes incorrect reordering
3344 around TABs covered by display properties.
3345
156bffbe
AS
33462011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3347
6b02f655 3348 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3349
72ad093b
CY
33502011-08-17 Chong Yidong <cyd@stupidchicken.com>
3351
3352 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3353 (internal_condition_case_2, internal_condition_case_n):
3354 Remove unnecessary aborts (Bug#9081).
72ad093b 3355
35774242
EZ
33562011-08-17 Eli Zaretskii <eliz@gnu.org>
3357
3358 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3359 has no `load' handler, try opening the file locally. (Bug#9311)
3360
db76dd85
KB
33612011-08-16 Ken Brown <kbrown@cornell.edu>
3362
3363 * gmalloc.c: Expand comment.
3364
b215eee5
EZ
33652011-08-16 Eli Zaretskii <eliz@gnu.org>
3366
3367 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3368 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3369
a4579d33
KB
33702011-08-16 Ken Brown <kbrown@cornell.edu>
3371
3372 Fix memory allocation problems in Cygwin build (Bug#9273).
3373
3374 * unexcw.c ( __malloc_initialized): Declare external variable.
3375 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3376
8b76d6f8
SM
3377 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3378 New variables.
a4579d33
KB
3379 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3380 dumped emacs.
3381 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3382 in the static heap.
3383 [CYGWIN] (special_realloc): New function.
3384 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3385 requests to realloc storage in the static heap.
3386
3ebec551
PE
33872011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3388
3389 * bidi.c (bidi_initialize): Remove unused local.
3390
9fd8be00
EZ
33912011-08-15 Eli Zaretskii <eliz@gnu.org>
3392
6b02f655
SM
3393 * bidimirror.h:
3394 * biditype.h: Remove file.
3395 * makefile.w32-in ($(BLD)/bidi.$(O)):
3396 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3397
3398 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3399
3400 * chartab.c: Improve commentary for the uniprop_table API.
3401
32413314
EZ
3402 * bidi.c (bidi_paragraph_init): Support zero value of
3403 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3404 (bidi_initialize): Use uniprop_table instead of including
3405 biditype.h and bidimirror.h.
32413314 3406
9fd8be00
EZ
3407 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3408 coordinates of the iterator when restoring from ppos_it.
3409 (Bug#9296)
3410
5cf2b69b
KH
34112011-08-14 Kenichi Handa <handa@m17n.org>
3412
3413 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3414 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3415
daf17d00
EZ
34162011-08-14 Eli Zaretskii <eliz@gnu.org>
3417
3418 * xdisp.c (move_it_in_display_line_to): Don't invoke
3419 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3420 ppos_it. Fixes vertical cursor motion when line beginning is
3421 covered by an image. (Bug#9296)
3422
08e3161a
JD
34232011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3424
3425 * nsterm.h (ns_run_ascript): Declare.
3426 (NSAPP_DATA2_RUNASSCRIPT): Define.
3427
3428 * nsfns.m (as_script, as_result, as_status): New static variables.
3429 (ns_run_ascript): New function.
5e617bc2 3430 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3431 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3432 the event loop. Get status from as_status (Bug#7276).
3433
3434 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3435 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3436 the event loop (Bug#7276).
3437
a3720aa2
AS
34382011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3439
3440 * gnutls.c (QCgnutls_bootprop_priority)
3441 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3442 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3443 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3444 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3445 (QCgnutls_bootprop_verify_hostname_error)
3446 (QCgnutls_bootprop_callbacks_verify): Rename from
3447 Qgnutls_bootprop_..., all uses changed.
3448
3449 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3450 uses changed.
3451
0a0d27fb
PE
34522011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3453
19d5c50c
PE
3454 * xfaces.c (Qframe_set_background_mode): Now static.
3455 * dispextern.h (Qframe_set_background_mode): Remove decl.
3456
0a0d27fb
PE
3457 * process.c (Fnetwork_interface_info): Declare local only if needed.
3458
377538cb
JD
34592011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3460
3461 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3462 (Fnetwork_interface_list): Allocate in increments of bytes instead
3463 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3464 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3465 sockaddr.
3466 (struct ifflag_def): notrailers is smart on OSX.
3467 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3468 Get hardware address with getifaddrs if available.
3469
08fff70c
EZ
34702011-08-12 Eli Zaretskii <eliz@gnu.org>
3471
3472 * xdisp.c (iterate_out_of_display_property): xassert that
3473 IT->position is set to within IT->object's boundaries. Break from
3474 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3475 when IT->position is set up wrongly due to some bug.
3476 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3477 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3478 entry. Force push_it to save on the stack the current
3479 buffer/string position, to be restored by pop_it. Fix flags in
3480 the iterator structure wrt the object coming from a display
3481 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3482 properties. (Bug#9284)
3483
7be1c708 34842011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3485
7be1c708
CY
3486 * fontset.c (fontset_get_font_group): Add proper type checks.
3487 (Bug#9172)
aac0c6e3 3488
7be1c708 34892011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3490
7be1c708
CY
3491 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3492 and LC_VERSION_MIN_MACOSX.
3493 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3494 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3495
97bb72a6
EZ
34962011-08-08 Eli Zaretskii <eliz@gnu.org>
3497
3498 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3499 no-display-properties-and-no-overlays under bidi display.
3500 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3501 properties and overlays.
97bb72a6 3502
d5617611
CY
35032011-08-08 Chong Yidong <cyd@stupidchicken.com>
3504
37e11a63
CY
3505 * editfns.c (Fset_time_zone_rule): Document relationship with the
3506 setenv function.
3507
d5617611
CY
3508 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3509 the font entity extracted from the cache (Bug#8109).
3510
58872834
CY
35112011-08-07 Chong Yidong <cyd@stupidchicken.com>
3512
3513 * composite.c (autocmp_chars): Don't reset point. That is done by
3514 restore_point_unwind (Bug#5984).
3515
75bfc667
JL
35162011-08-07 Juri Linkov <juri@jurta.org>
3517
3518 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3519 to show the arg `TIME' instead of `TIMEVAL'.
3520
d1410150
EZ
35212011-08-06 Eli Zaretskii <eliz@gnu.org>
3522
3523 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3524 display property strides EOL and includes a newline, as in
3525 longlines-mode. (Bug#9254)
75b771e4
EZ
3526 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3527 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3528
3529 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3530 is non-zero, even if the data buffer is NULL. Fixes a crash in
3531 vertical-motion with longlines-mode. (Bug#9254)
3532
35928349
EZ
35332011-08-05 Eli Zaretskii <eliz@gnu.org>
3534
ec7cc85b
EZ
3535 * bidi.c <bidi_cache_total_alloc>: Now static.
3536 (bidi_initialize): Initialize bidi_cache_total_alloc.
3537
8b76d6f8 3538 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3539 cache. (Bug#9221)
3540
3541 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3542 amount allocated this far in `bidi_cache_total_alloc'.
3543 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3544 non-zero, only free the data buffer without restoring the cache
3545 contents. All callers changed.
3546
3547 * dispextern.h (bidi_unshelve_cache): Update prototype.
3548
3549 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3550 (move_it_in_display_line, move_it_to)
3551 (move_it_vertically_backward, move_it_by_lines): Replace the call
3552 to xfree to an equivalent call to bidi_unshelve_cache.
3553 (move_it_in_display_line_to): Fix logic of returning
412b6358 3554 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3555
e2e2423b
EZ
35562011-08-05 Eli Zaretskii <eliz@gnu.org>
3557
3558 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3559 came from a string character with a `cursor' property. (Bug#9229)
3560
ae9e757a
JD
35612011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3562
3563 * Makefile.in (LIB_PTHREAD): New variable.
3564 (LIBES): Add LIB_PTHREAD (Bug#9216).
3565
3566 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3567 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3568
213bd7f2
AS
35692011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3570
6b02f655 3571 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3572
99aaf75f
JD
35732011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3574
3575 * xterm.c (x_find_topmost_parent): New function.
3576 (x_set_frame_alpha): Find topmost parent window with
3577 x_find_topmost_parent and set the property there also (bug#9181).
3578 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3579
c74e9d86
PE
35802011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3581
3582 * callproc.c (Fcall_process): Avoid vfork clobbering
3583 the local vars buffer, coding_systems, current_dir.
3584
640c8776
SM
35852011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3586
3587 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3588
f26d0e4c
PE
35892011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3590
8a10d76c
PE
3591 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3592 so that it is not optimized away.
3593
f26d0e4c
PE
3594 * xdisp.c (compute_display_string_pos): Remove unused local.
3595
55439c61
EZ
35962011-08-02 Eli Zaretskii <eliz@gnu.org>
3597
3598 Fix slow cursor motion and scrolling in large buffers with
3599 selective display, like Org Mode buffers. (Bug#9218)
3600
3601 * dispextern.h (struct bidi_it): New member disp_prop_p.
3602
3603 * xdisp.c: Remove one-slot cache of display string positions.
3604 (compute_display_string_pos): Accept an additional argument
5e617bc2 3605 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3606 for a display string or property. If found, set DISP_PROP_P
3607 non-zero.
3608
3609 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3610 DISP_PROP_P, and pass it to compute_display_string_pos.
3611 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3612 non-zero. All callers of bidi_fetch_char changed.
3613
fb33fa43
SM
36142011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3615
3616 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3617
b099e063
DM
36182010-12-03 Don March <don@ohspite.net>
3619
3620 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3621 last character M-[char] is translated to ESC [char] (bug#7541).
3622
5cc7f7af
KH
36232011-08-02 Kenichi Handa <handa@m17n.org>
3624
d0fffa3f 3625 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3626
3627 * chartab.c (uniprop_table): Make it non-static.
3628
525d5e6e
EZ
36292011-08-01 Eli Zaretskii <eliz@gnu.org>
3630
3631 * xdisp.c (forward_to_next_line_start): Accept additional argument
3632 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3633 on the newline.
3634 (reseat_at_next_visible_line_start): Use the bidi iterator state
3635 returned by forward_to_next_line_start to restore the state of
3636 it->bidi_it after backing up to previous newline. (Bug#9212)
3637
31011111
AS
36382011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3639
3640 * regex.c (re_comp): Protoize.
3641 (re_exec): Fix return type.
3642 (regexec): Fix type of `ret'. (Bug#9203)
3643
476371c4
PE
36442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3645
e5d76069
PE
3646 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3647 This is needed if max-image-size is a floating-point number.
3648
9a79b20c
AS
36492011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3650
3651 * print.c (print_object): Print empty symbol as ##.
3652
3653 * lread.c (read1): Read ## as empty symbol.
3654
d8c2fa78
AA
36552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3656
3657 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3658 setting frame foreground color (Bug#9175).
3659 (x_set_background_color): Likewise.
3660
ffe57a7a
AA
3661 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3662 contents (Bug#9176).
3663 (EmacsTooltip -init): Remove bezels and add shadows to
3664 tooltip windows.
3665
bf3492a5
AA
3666 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3667 or scroll bar (Bug#8470).
3668
d55e9c53
AA
3669 * nsfont.m (nsfont_open): Remove assignment to voffset and
3670 unnecessary vars hshink, expand, hd, full_height, min_height.
3671 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3672
3673 * nsterm.h (nsfont_info): Remove voffset field.
3674
d8c2fa78 36752011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3676
3677 Implement strike-through and overline on NextStep (Bug#8863).
3678
3679 * nsfont.m (nsfont_open): Use underline position provided by font,
3680 instead of hard-coded value of 2.
3681 (nsfont_draw): Call ns_draw_text_decoration instead.
3682
3683 * nsterm.h: Add declaration for ns_draw_text_decoration.
3684
3685 * nsterm.m (ns_draw_text_decoration): New function for drawing
3686 underline, overline, and strike-through.
3687 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3688 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3689 accommodate underlining, etc.
4843aac3 3690
4cc60b9b
EZ
36912011-07-28 Eli Zaretskii <eliz@gnu.org>
3692
bc7ece87
EZ
3693 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3694 default.
4cc60b9b 3695
476371c4
PE
36962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3697
66606eea
PE
3698 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3699 Without this fix, if a signal arrives just after memory fills up,
3700 'malloc' might be invoked reentrantly.
3701
476371c4
PE
3702 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3703 In other words, assume that every image size is allowed, on non-X
3704 hosts. This assumption is probably wrong, but it lets Emacs compile.
3705
f3fcc40d
AS
37062011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3707
3708 * regex.c (re_iswctype): Convert return values to boolean.
3709
350c992f
EZ
37102011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3711
3712 * xdisp.c (compute_display_string_pos): Don't use cached display
3713 string position if the buffer had its restriction changed.
3714 (Bug#9184)
3715
5266b4bb
PE
37162011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3717
3718 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3719
2573a837 37202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3721
41f55ccd 3722 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3723
39e378da
PE
3724 * bidi.c: Integer size and overflow fixes.
3725 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3726 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3727 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3728 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3729 (bidi_find_other_level_edge):
3730 Use ptrdiff_t instead of EMACS_INT where either will do.
3731 This works better on 32-bit hosts configured --with-wide-int.
3732 (bidi_cache_ensure_space): Check for size-calculation overflow.
3733 Use % rather than repeated addition, for better worst-case speed.
3734 Don't set bidi_cache_size until after xrealloc returns, because it
3735 might not return.
3736 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3737 (bidi_cache_ensure_space): Also check that the bidi cache size
3738 does not exceed that of the largest Lisp string or buffer. See Eli
3739 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3740
5e927815
PE
3741 * alloc.c (__malloc_size_t): Remove.
3742 All uses replaced by size_t. See Andreas Schwab's note
3743 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3744
ca4aa935
PE
3745 * image.c: Improve checking for integer overflow.
3746 (check_image_size): Assume that f is nonnull, since
3747 it is always nonnull in practice. This is one less thing to
3748 worry about when checking for integer overflow later.
3749 (x_check_image_size): New function, which checks for integer
3750 overflow issues inside X.
3751 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3752 This removes the need for a memory_full check.
3753 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3754 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3755 (xbm_read_bitmap_data): Change locals back to 'int', since
3756 their values must fit in 'int'.
3757 (xpm_load_image, png_load, tiff_load):
3758 Invoke x_create_x_image_and_pixmap earlier,
3759 to avoid much needless work if the image is too large.
3760 (tiff_load): Treat overly large images as if
3761 x_create_x_image_and_pixmap failed, not as malloc failures.
3762 (gs_load): Use x_check_image_size.
3763
5f8f9cc2
PE
3764 * gtkutil.c: Omit integer casts.
3765 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3766 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3767
5adf60bc
PE
3768 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3769
c8907a93
PE
3770 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3771 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3772 would wrongly return t on a 64-bit host.
3773
e3c25c68
PE
3774 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3775 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3776 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3777 and therefore cause GCC to emit a bogus diagnostic in some cases.
3778
3f791afe
PE
3779 * image.c: Integer signedness and overflow and related fixes.
3780 This is not an exhaustive set of fixes, but it's time to
3781 record what I've got.
3782 (lookup_pixel_color, check_image_size): Remove redundant decls.
3783 (check_image_size): Don't assume that arbitrary EMACS_INT values
3784 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3785 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3786 (tiff_load, imagemagick_load_image):
3787 Check for overflow in size calculations.
3788 (x_create_x_image_and_pixmap): Remove unnecessary test for
3789 xmalloc returning NULL; that can't happen.
3790 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3791 (xpm_color_bucket): Use better integer hashing function.
3792 (xpm_cache_color): Don't possibly over-allocate memory.
3793 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3794 (gif_memory_source):
3795 Use ptrdiff_t, not int or size_t, to record sizes.
3796 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3797 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3798 either works, as we prefer signed integers.
3799 (tiff_read_from_memory, tiff_write_from_memory):
3800 Return tsize_t, not size_t, since that's what the TIFF API wants.
3801 (tiff_read_from_memory): Don't fail simply because the read would
3802 go past EOF; instead, return a short read.
3803 (tiff_load): Omit no-longer-needed casts.
3804 (Fimagemagick_types): Don't assume size fits into 'int'.
3805
3cc5a532
PE
3806 Improve hashing quality when configured --with-wide-int.
3807 * fns.c (hash_string): New function, taken from sxhash_string.
3808 Do not discard information about ASCII character case; this
3809 discarding is no longer needed.
3810 (sxhash-string): Use it. Change sig to match it. Caller changed.
3811 * lisp.h: Declare it.
3812 * lread.c (hash_string): Remove, since we now use fns.c's version.
3813 The fns.c version returns a wider integer if --with-wide-int is
3814 specified, so this should help the quality of the hashing a bit.
3815
b312a492
PE
3816 * emacs.c: Integer overflow minor fix.
3817 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3818 Define only if GNU_LINUX.
3819 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3820
dfd153ae
PE
3821 * dispnew.c: Integer signedness and overflow fixes.
3822 Remove unnecessary forward decls, that were a maintenance hassle.
3823 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3824 All uses changed.
3825 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3826 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3827 (prepare_desired_row, line_draw_cost):
3828 Use int, not unsigned, where either works.
3829 (save_current_matrix, restore_current_matrix):
3830 Use ptrdiff_t, not size_t, where either works.
3831 (init_display): Check for overflow more accurately, and without
3832 relying on undefined behavior.
3833
a81d11a3
PE
3834 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3835 Remove, replacing with the new symbols in lisp.h. All uses changed.
3836 * fileio.c (make_temp_name):
3837 * filelock.c (lock_file_1, lock_file):
3838 * xdisp.c (message_dolog):
3839 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3840 Use pMd etc. instead.
3841 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3842 replacing the pWIDE etc. symbols removed from editfns.c.
3843
3300e6fd
PE
3844 * keyboard.h (num_input_events): Now uintmax_t.
3845 This is (very slightly) less likely to mess up due to wraparound.
3846 All uses changed.
3847
fd05c7e9
PE
3848 * buffer.c: Integer signedness fixes.
3849 (alloc_buffer_text, enlarge_buffer_text):
3850 Use ptrdiff_t rather than size_t when either will do, as we prefer
3851 signed integers.
3852
903fe15d
PE
3853 * alloc.c: Integer signedness and overflow fixes.
3854 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3855 (__malloc_size_t): Default to size_t, not to int.
3856 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3857 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3858 Prefer ptrdiff_t to size_t when either would do, as we prefer
3859 signed integers.
3860 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3861 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3862 Now const. Initialize with values that are in range even if char
3863 is signed.
3864 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3865 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3866 These functions do the right thing with sizes > 2**32.
3867 (check_depth): Now ptrdiff_t, not int.
3868 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3869 Adjust to new way of storing sizes. Check for size overflow bugs
3870 in rest of code.
3871 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3872 slightly wrong anyway, as it missed one instance of
3873 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3874 (refill_memory_reserve): Omit needless cast to size_t.
3875 (mark_object_loop_halt): Mark as externally visible.
3876
ac82cc6a
PE
3877 * xselect.c: Integer signedness and overflow fixes.
3878 (Fx_register_dnd_atom, x_handle_dnd_message):
3879 Use ptrdiff_t, not size_t, since we prefer signed.
3880 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3881 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3882 x_dnd_atoms_size and x_dnd_atoms_length.
3883
c2d1e36d
PE
3884 * doprnt.c: Prefer signed to unsigned when either works.
3885 * eval.c (verror):
3886 * doprnt.c (doprnt):
3887 * lisp.h (doprnt):
3888 * xdisp.c (vmessage):
3889 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3890 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3891 prefer signed arithmetic to avoid comparison confusion.
3892 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3893 but is a bit tricky.
3894
0e926e56
PE
3895 Assume freestanding C89 headers, string.h, stdlib.h.
3896 * data.c, doprnt.c, floatfns.c, print.c:
3897 Include float.h unconditionally.
3898 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3899 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3900 * regex.c: Likewise for stddef.h, string.h.
3901 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3902 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3903 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3904 (STDC_HEADERS): Remove obsolete defines.
3905 * sysdep.c: Include limits.h unconditionally.
3906
9cfdb3ec
PE
3907 Assume support for memcmp, memcpy, memmove, memset.
3908 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3909 * regex.c (memcmp, memcpy):
3910 Remove; we assume C89 now.
3911
3912 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3913 (__malloc_safe_bcopy): Remove; no longer needed.
3914
cf950e6b 3915 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3916 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3917 well either way, and we prefer signed to unsigned.
3918
dbf38e02
LMI
39192011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3920
3921 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3922 closes the connection while we're reading (bug#9182).
3923
d6f0886c 39242011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3925
d6f0886c
JD
3926 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3927 are specified (Bug#9168).
24e0f6b1 3928
2eb1f9e6
PE
39292011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3930
3931 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3932 Found by GCC static checking and --with-wide-int on a 32-bit host.
3933
22381272 39342011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3935
3936 * xdisp.c (compute_display_string_pos): Fix logic of caching
3937 previous display string position. Initialize cached_prev_pos to
3938 -1. Fixes slow-down at the beginning of a buffer.
3939
f25e39b4
EZ
39402011-07-24 Eli Zaretskii <eliz@gnu.org>
3941
3942 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3943 for attrs[LFACE_FONTSET_INDEX].
3944
04c4b52e
PE
39452011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3946
3947 * xml.c (parse_region): Remove unused local
3948 that was recently introduced.
3949
c1734fbd
EZ
39502011-07-23 Eli Zaretskii <eliz@gnu.org>
3951
be18c5a5
EZ
3952 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3953 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3954
c1734fbd
EZ
3955 * xdisp.c (move_it_in_display_line_to): Record the best matching
3956 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3957 exit if none of the characters scanned was an exact match.
3958 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3959 when exact match is impossible due to invisible text, and the
3960 lines are truncated.
3961
a258d627
JD
39622011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3963
3964 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3965 for OSX >= 10.7.
3966
b6d5a689
EZ
39672011-07-22 Eli Zaretskii <eliz@gnu.org>
3968
0f74f785
EZ
3969 Fix a significant slow-down of cursor motion with C-n, C-p,
3970 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3971 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3972 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3973 (next_element_from_buffer): Call compute_stop_pos_backwards to
3974 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3975 base_level_stop.
3976 (reseat): Don't look for prev_stop, as that could mean a very long
3977 run.
3978 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3979 <cached_disp_overlay_modiff>: Cache for last found display string
3980 position.
551918c1 3981 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3982 about the same buffer in the same area of character positions, and
3983 the buffer wasn't changed since the time the display string
3984 position was cached.
551918c1 3985
b2d0c91a
EZ
39862011-07-22 Eli Zaretskii <eliz@gnu.org>
3987
3988 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3989 is an integer, which is important for empty lines. (Bug#9149)
3990
043604ee
CY
39912011-07-22 Chong Yidong <cyd@stupidchicken.com>
3992
3993 * frame.c (Fmodify_frame_parameters): In tty case, update the
3994 default face if necessary (Bug#4238).
3995
da4adb04
CY
39962011-07-21 Chong Yidong <cyd@stupidchicken.com>
3997
3998 * editfns.c (Fstring_to_char): No need to explain what a character
3999 is in the docstring (Bug#6576).
4000
9abd0532
LMI
40012011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4002
4003 * xml.c (parse_region): Make sure we always return a tree.
4004
36881d16
HK
40052011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4006
4007 * xml.c (parse_region): If a document contains only comments,
4008 return that, too.
4009
1e98674d
LMI
40102011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4011
4012 * xml.c (make_dom): Return comments, too.
4013
590bd467
PE
40142011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4015
4016 Port to OpenBSD.
4017 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4018 and the surrounding thread.
4019 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4020 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4021 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4022 timer goes off.
4023 * s/openbsd.h (BROKEN_SIGIO): Define.
4024 * unexelf.c (unexec) [__OpenBSD__]:
4025 Don't update the .mdebug section of the Alpha COFF symbol table.
4026
f41628b2
LMI
40272011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4028
4029 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4030 (bug#8460).
4031
b59b67c5
PE
40322011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4033
15e3a074
PE
4034 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4035 This fixes some race conditions on the permissions of any newly
4036 created file.
4037
41bed37d
PE
4038 * alloc.c (valid_pointer_p): Use pipe, not open.
4039 This fixes some permissions issues when debugging.
4040
b59b67c5
PE
4041 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4042 If fchown fails to set both uid and gid, try to set just gid,
4043 as that is sometimes allowed. Adjust the file's mode to eliminate
4044 setuid or setgid bits that are inappropriate if fchown fails.
4045
925a6be7
SM
40462011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4047
4048 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4049 to compare Lisp_Objects.
4050 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4051 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4052 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4053
52968808
AS
40542011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4055
0a6a104b
AS
4056 * lread.c (read_integer): Unread even EOF character.
4057 (read1): Likewise. Properly record start position of symbol.
4058
52968808
AS
4059 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4060 symbol character follows.
4061
9e381cdd
PE
40622011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4063
4064 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4065 This works around a problem with the previous change to Fcopy_file.
4066 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4067 and without this change, GCC might complain about discarding
4068 fchown's return value.
4069
b5641435
JB
40702011-07-16 Juanma Barranquero <lekktu@gmail.com>
4071
4072 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4073
a8031457
PE
40742011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4075
4076 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4077
dd889327
LMI
40782011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4079
750c33f7
LMI
4080 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4081 it's used from the C level.
4082
dd889327
LMI
4083 * process.c: Use the same condition for POLL_FOR_INPUT in both
4084 keyboard.c and process.c (bug#1858).
4085
87e86684
LM
40862011-07-09 Lawrence Mitchell <wence@gmx.li>
4087
4088 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4089 (Fgnutls_boot): Use it.
4090
64348f40
AS
40912011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4092
4093 * doc.c (Fsubstitute_command_keys): Revert last change.
4094
1d698799
LMI
40952011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4096
f863868c
LMI
4097 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4098 quotes the next character, and doesn't affect other longer
4099 sequences (bug#8935).
4100
1d698799
LMI
4101 * lread.c (syms_of_lread): Clarify that is isn't only
4102 `eval-buffer' and `eval-defun' that's affected by
4103 `lexical-binding' (bug#8460).
4104
aa4b6df6
EZ
41052011-07-15 Eli Zaretskii <eliz@gnu.org>
4106
4107 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4108 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4109
5d856da6
PE
41102011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4111
ad6042bb
PE
4112 Fix minor problems found by static checking.
4113 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4114 (elsz): Now a signed constant, not a size_t var. We prefer signed
4115 types to unsigned, to avoid integer comparison confusion. Without
4116 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4117 "cannot optimize loop, the loop counter may overflow", a symptom
4118 of the confusion.
f00bbb22 4119 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4120 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4121
6468f31c
LMI
41222011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4123
49080b10
LMI
4124 * search.c (Fre_search_backward): Mention `case-fold-search' in
4125 all the re_search_* functions (bug#8138).
4126
6468f31c
LMI
4127 * keyboard.c (Fopen_dribble_file): Document when the file is
4128 closed (bug#8056).
4129
c965adc5
EZ
41302011-07-14 Eli Zaretskii <eliz@gnu.org>
4131
df9733bf
EZ
4132 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4133 bidi_cache_idx.
4134
0bb23927
EZ
4135 Support bidi reordering of display and overlay strings.
4136 * xdisp.c (compute_display_string_pos)
4137 (compute_display_string_end): Accept additional argument STRING.
4138 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4139 (reseat_to_string): Initialize bidi_it->string.s and
4140 bidi_it->string.schars.
4141 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4142 NULL (avoids a crash in bidi_paragraph_init).
4143 Initialize itb.string.lstring.
0bb23927
EZ
4144 (init_iterator): Call bidi_init_it only of a valid
4145 buffer position was specified. Initialize paragraph_embedding to
4146 L2R.
4147 (reseat_to_string): Initialize the bidi iterator.
4148 (display_string): If we need to ignore text properties of
4149 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4150 original value of -1 will not work with bidi.)
4151 (compute_display_string_pos): First arg is now struct
4152 `text_pos *'; all callers changed. Support display properties on
4153 Lisp strings.
4154 (compute_display_string_end): Support display properties on Lisp
4155 strings.
4156 (init_iterator, reseat_1, reseat_to_string): Initialize the
4157 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4158 when iterating on a string not from display properties).
640c8776
SM
4159 (compute_display_string_pos, compute_display_string_end):
4160 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4161 arrow keys.
4162 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4163 base_level_stop; instead, set base_level_stop to BEGV.
4164 Fixes crashes in vertical-motion.
0bb23927
EZ
4165 (next_element_from_buffer): Improve commentary for when
4166 the iterator is before prev_stop.
4167 (init_iterator): Initialize bidi_p from the default value of
4168 bidi-display-reordering, not from buffer-local value. Use the
4169 buffer-local value only if initializing for buffer iteration.
4170 (handle_invisible_prop): Support invisible properties on strings
4171 that are being bidi-reordered.
4172 (set_iterator_to_next): Support bidi reordering of C strings and
4173 Lisp strings.
4174 (next_element_from_string): Support bidi reordering of Lisp
4175 strings.
4176 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4177 (display_string): Support display of R2L glyph rows.
4178 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4179 (init_iterator): Don't initialize it->bidi_p for strings
4180 here.
4181 (reseat_to_string): Initialize it->bidi_p for strings here.
4182 (next_element_from_string, next_element_from_c_string)
4183 (next_element_from_buffer): Add xassert's for correspondence
4184 between IT's object being iterated and it->bidi_it.string
4185 structure.
4186 (face_before_or_after_it_pos): Support bidi iteration.
4187 (next_element_from_c_string): Handle the case of the first string
4188 character that is not the first one in the visual order.
4189 (get_visually_first_element): New function, refactored from common
4190 parts of next_element_from_buffer, next_element_from_string, and
4191 next_element_from_c_string.
4192 (tool_bar_lines_needed, redisplay_tool_bar)
4193 (display_menu_bar): Force left-to-right direction. Add a FIXME
4194 comment for making that be controlled by a user option.
4195 (push_it, pop_it): Save and restore the state of the
4196 bidi iterator. Save and restore the bidi_p flag.
4197 (pop_it): Iterate out of display property for string iteration as
4198 well.
4199 (iterate_out_of_display_property): Support iteration over strings.
4200 (handle_single_display_spec): Set up it->bidi_it for iteration
4201 over a display string, and call bidi_init_it.
4202 (handle_single_display_spec, next_overlay_string)
4203 (get_overlay_strings_1, push_display_prop): Set up the bidi
4204 iterator for displaying display or overlay strings.
4205 (forward_to_next_line_start): Don't use the shortcut if
4206 bidi-iterating.
4207 (back_to_previous_visible_line_start): If handle_display_prop
4208 pushed the iterator stack, restore the internal state of the bidi
4209 iterator by calling bidi_pop_it same number of times.
4210 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4211 and we are bidi-iterating, don't decrement the iterator position;
4212 instead, set the first_elt flag in the bidi iterator, to produce
4213 the same effect.
4214 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4215 (push_display_prop): xassert that we are iterating a buffer.
4216 (push_it, pop_it): Save and restore paragraph_embedding member.
4217 (handle_single_display_spec, next_overlay_string)
4218 (get_overlay_strings_1, reseat_1, reseat_to_string)
4219 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4220 correctly. Don't assume unibyte strings are not bidi-reordered.
4221 (compute_display_string_pos)
4222 (compute_display_string_end): Fix handling the case of C string.
4223 (push_it, pop_it): Save and restore from_disp_prop_p.
4224 (handle_single_display_spec, push_display_prop): Set the
4225 from_disp_prop_p flag.
4226 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4227 (pop_it): Call iterate_out_of_display_property only if we are
4228 popping after iteration over a string that came from a display
4229 property. Fix a typo in popping stretch info. Add an assertion
4230 for verifying that the iterator position is in sync with the bidi
4231 iterator.
4232 (handle_single_display_spec, get_overlay_strings_1)
4233 (push_display_prop): Fix initialization of paragraph direction for
4234 string when that of the parent object is not yet determined.
4235 (reseat_1): Call bidi_init_it to resync the bidi
4236 iterator with IT's position. (Bug#7616)
4237 (find_row_edges): If ROW->start.pos gives position
4238 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4239 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4240 Reset the from_disp_prop_p flag.
4241 (SAVE_IT, RESTORE_IT): New macros.
4242 (pos_visible_p, face_before_or_after_it_pos)
4243 (back_to_previous_visible_line_start)
4244 (move_it_in_display_line_to, move_it_in_display_line)
4245 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4246 (try_scrolling, redisplay_window, display_line): Use them when
4247 saving a temporary copy of the iterator and restoring it back.
4248 (back_to_previous_visible_line_start, reseat_1)
4249 (init_iterator): Empty the bidi cache "stack".
4250 (move_it_in_display_line_to): If iterator ended up at
4251 EOL, but we never saw any buffer positions smaller than
4252 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4253 motion in bidi-reordered lines.
4254 (move_it_in_display_line_to): Record prev_method and prev_pos
4255 immediately before the call to set_iterator_to_next. Fixes cursor
4256 motion in bidi-reordered lines with stretch glyphs and strings
4257 displayed in margins. (Bug#8133) (Bug#8867)
4258 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4259 TO_CHARPOS.
640c8776
SM
4260 (pos_visible_p): Support positions in bidi-reordered lines.
4261 Save and restore bidi cache.
0bb23927
EZ
4262
4263 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4264 (bidi_paragraph_info): Delete unused struct.
4265 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4266 (bidi_cache_start): New variable.
4267 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4268 to zero.
4269 (bidi_cache_fetch_state, bidi_cache_search)
4270 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4271 (bidi_cache_find, bidi_peek_at_next_level)
4272 (bidi_level_of_next_char, bidi_find_other_level_edge)
4273 (bidi_move_to_visually_next): Compare cache index with
4274 bidi_cache_start rather than with zero.
4275 (bidi_fetch_char): Accept new argument STRING; all callers
4276 changed. Support iteration over a string. Support strings with
4277 display properties. Support unibyte strings. Fix the type of
4278 `len' according to what STRING_CHAR_AND_LENGTH expects.
4279 (bidi_paragraph_init, bidi_resolve_explicit_1)
4280 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4281 (bidi_level_of_next_char, bidi_move_to_visually_next):
4282 Support iteration over a string.
0bb23927
EZ
4283 (bidi_set_sor_type, bidi_resolve_explicit_1)
4284 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4285 can now be zero (for strings); special values 0 and -1 were
4286 changed to -1 and -2, respectively.
4287 (bidi_char_at_pos): New function.
4288 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4289 Call it instead of FETCH_MULTIBYTE_CHAR.
4290 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4291 initialized to valid values.
4292 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4293 values.
4294 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4295 the test for valid cached positions. Fix the logic for looking up
4296 the sentinel state in the cache. GCPRO the Lisp string we are
4297 iterating.
4298 (bidi_push_it, bidi_pop_it): New functions.
4299 (bidi_initialize): Initialize the bidi cache start stack pointer.
4300 (bidi_cache_ensure_space): New function, refactored from part of
4301 bidi_cache_iterator_state. Don't assume the required size is just
4302 one BIDI_CACHE_CHUNK away.
4303 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4304 (bidi_count_bytes, bidi_char_at_pos): New functions.
4305 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4306 always valid if bidi_cache_idx is valid.
4307 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4308 is valid if it's going to be used.
4309 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4310 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4311 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4312 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4313 (bidi_find_other_level_edge, bidi_cache_start_stack):
4314 All variables related to cache indices are now EMACS_INT.
c965adc5 4315
0bb23927
EZ
4316 * dispextern.h (struct bidi_string_data): New structure.
4317 (struct bidi_it): New member `string'. Make flag members be 1-bit
4318 fields, and put them last in the struct.
640c8776
SM
4319 (compute_display_string_pos, compute_display_string_end):
4320 Update prototypes.
0bb23927
EZ
4321 (bidi_push_it, bidi_pop_it): Add prototypes.
4322 (struct iterator_stack_entry): New members bidi_p,
4323 paragraph_embedding, and from_disp_prop_p.
4324 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4325 (bidi_shelve_cache, bidi_unshelve_cache):
4326 Declare prototypes.
0bb23927
EZ
4327
4328 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4329 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4330 and vector-like objects.
4331
4332 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4333 cache around display iteration.
4334
4335 * window.c (Fwindow_end, window_scroll_pixel_based)
4336 (displayed_window_lines, Frecenter): Save and restore the bidi
4337 cache around display iteration.
4338
3bbd2265
LMI
43392011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4340
4341 * editfns.c (Fdelete_region): Clarify the use of the named
4342 parameters (bug#6788).
4343
adc47434
MR
43442011-07-14 Martin Rudalics <rudalics@gmx.at>
4345
4346 * indent.c (Fvertical_motion): Set and restore w->pointm when
4347 saving and restoring the window's buffer (Bug#9006).
4348
837c31f8
LMI
43492011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4350
4351 * editfns.c (Fstring_to_char): Clarify just what is returned
4352 (bug#6576). Text by Eli Zaretskii.
4353
ac389d0c
JB
43542011-07-13 Juanma Barranquero <lekktu@gmail.com>
4355
4356 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4357
0be0ce47
EZ
43582011-07-13 Eli Zaretskii <eliz@gnu.org>
4359
4360 * buffer.c (mmap_find): Fix a typo.
4361
cd18e7e3
JB
43622011-07-13 Johan Bockgård <bojohan@gnu.org>
4363
4364 Fix execution of x selection hooks.
4365 * xselect.c (Qx_lost_selection_functions)
4366 (Qx_sent_selection_functions): New vars.
4367 (syms_of_xselect): DEFSYM them.
4368 (x_handle_selection_request): Pass Qx_sent_selection_functions
4369 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4370 (x_handle_selection_clear,x_clear_frame_selections):
4371 Pass Qx_lost_selection_functions rather than
4372 Vx_lost_selection_functions to Frun_hook_with_args.
4373
47ea7f44
PE
43742011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4375
ac389d0c 4376 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4377 The old code sometimes used this field without initializing it.
4378
47ea7f44
PE
4379 * alloc.c (gc_sweep): Don't read past end of array.
4380 In theory, the old code could also have corrupted Emacs internals,
4381 though it'd be very unlikely.
4382
bc985c87
AS
43832011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4384
4385 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4386 argument. (Bug#4026)
bc985c87 4387
0cf34688
LMI
43882011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4389
b3dadd76
LMI
4390 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4391 key" (bug#4257).
4392
0cf34688
LMI
4393 * window.c (Fset_window_start): Doc fix (bug#4199).
4394 (Fset_window_hscroll): Ditto.
4395
270768cd
PE
43962011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4397
077e3dda 4398 Fix minor new problems caught by GCC 4.6.1.
270768cd 4399 * term.c (init_tty): Remove unused local.
490011a6 4400 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4401 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4402 not used otherwise.
270768cd 4403
b1f58454
CY
44042011-07-12 Chong Yidong <cyd@stupidchicken.com>
4405
4406 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4407
22b9578d
LMI
44082011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4409
6e70ab07
LMI
4410 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4411 are the mini-buffer and the echo area (bug#3320).
4412
22b9578d
LMI
4413 * term.c (init_tty): Remove support for supdup, c10 and perq
4414 terminals, which are no longer supported (bug#1482).
4415
8974cc9f
JB
44162011-07-10 Johan Bockgård <bojohan@gnu.org>
4417
4418 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4419
a560d974
JD
44202011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4421
4422 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4423 for non-popups (Bug#3642).
4424
1dae0f0a
AS
44252011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4426
268c2c36 4427 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4428 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4429 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4430 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4431 * data.c (fmod): Likewise.
4432 * dispnew.c (swap_glyphs_in_rows): Likewise.
4433 * emacs.c (memory_warning_signal): Likewise.
4434 * floatfns.c (float_error): Likewise.
4435 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4436 (otf_open, font_otf_capability, generate_otf_features)
4437 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4438 Likewise.
4439 * image.c (pbm_read_file): Likewise.
4440 * indent.c (string_display_width): Likewise.
4441 * intervals.c (check_for_interval, search_for_interval)
4442 (inc_interval_count, count_intervals, root_interval)
4443 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4444 * lread.c (defalias): Likewise.
268c2c36 4445 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4446 * regex.c (set_image_of_range_1, set_image_of_range)
4447 (regex_grow_registers): Likewise.
4448 * sysdep.c (strerror): Likewise.
4449 * termcap.c (valid_filename_p, tprint, main): Likewise.
4450 * tparam.c (main): Likewise.
4451 * unexhp9k800.c (run_time_remap, save_data_space)
4452 (update_file_ptrs, read_header, write_header, calculate_checksum)
4453 (copy_file, copy_rest, display_header): Likewise.
4454 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4455 Likewise.
4456 * xdisp.c (check_it): Likewise.
4457 * xfaces.c (register_color, unregister_color, unregister_colors):
4458 Likewise.
4459 * xfns.c (print_fontset_result): Likewise.
4460 * xrdb.c (member, fatal, main): Likewise.
4461
99033785
PE
44622011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4463
4464 Fix minor problems found by static checking (Bug#9031).
4465 * chartab.c (char_table_set_range, map_sub_char_table):
4466 Remove unused locals.
4467 (uniprop_table): Now static.
4468 * composite.c (_work_char): Remove unused static var.
4469
9cb2ac56
JB
44702011-07-09 Juanma Barranquero <lekktu@gmail.com>
4471
4472 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4473
f25661f0
JD
44742011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4475
4476 * gtkutil.c (qttip_cb): Remove code without function.
4477
8278c4fe
EZ
44782011-07-09 Eli Zaretskii <eliz@gnu.org>
4479
4480 * w32.c (pthread_sigmask): New stub.
4481
1692ae2d 44822011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4483
8a6ebd58 4484 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4485 sigprocmask is portable only for single-threaded applications, and
4486 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4487 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4488 (LIBES): Use it.
4489 * callproc.c (Fcall_process):
4490 * process.c (create_process):
4491 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4492 Use pthread_sigmask, not sigprocmask.
123403e4 4493
1b854618
JD
44942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4495
4496 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4497 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4498 wrong (Bug#8591).
4499
3fe4b549
JD
45002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4501
0ce7e563
JD
4502 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4503 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4504 (xg_hide_tooltip): Fix comment.
4505
3fe4b549
JD
4506 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4507 in registerServicesMenuSendTypes.
4508 (validRequestorForSendType): Don't check ns_return_types.
4509
4510 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4511 ns_return_type.
4512
5df75e47
JR
45132011-07-08 Jason Rumney <jasonr@gnu.org>
4514
22610910
JR
4515 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4516 SH_SHOW for hidden windows (Bug#5482).
4517
5df75e47
JR
4518 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4519 frame struct members of non-existent frames (Bug#6284).
4520
699c10bd
JD
45212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4522
4393663b
JD
4523 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4524 variable firstTime not needed on OSX >= 10.6.
4525 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4526 >= 10.5. Use setKnobProportion, setDoubleValue.
4527
4528 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4529 (MAC_OS_X_VERSION_10_5): Define if not defined.
4530 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4531 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4532 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4533
4534 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4535 cString and lossyCString on OSX >= 10.4
4536
58179cce 4537 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4538 sizeToFit on OSX >= 10.2.
4539
4540 * nsimage.m (allocInitFromFile): Don't use deprecated method
4541 bestRepresentationForDevice on OSX >= 10.6.
4542
4543 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4544 to avoid warning.
4545
4546 * emacs.c: Declare unexec_init_emacs_zone.
4547
a63e0781
JD
4548 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4549
699c10bd
JD
4550 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4551
4552 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4553 on svcsMenu (Bug#8842).
4554
4555 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4556 ns_return_types.
4557 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4558
4559 * nsterm.m (QUTF8_STRING): Declare.
4560 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4561 (validRequestorForSendType): Return type is (id).
4562 Change indexOfObjectIdenticalTo to indexOfObject.
4563 Check if we have local selection before returning self (Bug#8842).
4564 (writeSelectionToPasteboard): Put local selection into paste board
4565 if we have a local selection (Bug#8842).
4566 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4567
4568 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4569 (ns_get_local_selection): Declare.
4570
54e10184
LMI
45712011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4572
9888ff71
LMI
4573 * keymap.c (describe_map_tree): Don't insert a double newline at
4574 the end of the buffer (bug#1169) and return whether we inserted
4575 something.
4576
54e10184
LMI
4577 * callint.c (Fcall_interactively): Change "reading args" to
4578 "providing args" to try to clarify what it does (bug#1010).
4579
15fa4783
KH
45802011-07-07 Kenichi Handa <handa@m17n.org>
4581
4582 * composite.c (composition_compute_stop_pos): Ignore a static
4583 composition starting before CHARPOS (Bug#8915).
4584
4585 * xdisp.c (handle_composition_prop): Likewise.
4586
a8815b00
EZ
45872011-07-07 Eli Zaretskii <eliz@gnu.org>
4588
4589 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4590 (Bug#9015)
4591
ef7b981d 45922011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4593
4594 * character.h (unicode_category_t): New enum type.
4595
4596 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4597 (Qchar_code_property_table): New variable.
4598 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4599 (UNIPROP_COMPRESSED_FORM_P): New macros.
4600 (char_table_ascii): Uncompress the compressed values.
4601 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4602 Uncompress the compressed values.
ac389d0c 4603 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4604 (char_table_ref_and_range): Uncompress the compressed values.
4605 (sub_char_table_set): New arg is_uniprop. Callers changed.
4606 Uncompress the compressed values.
4607 (sub_char_table_set_range): Args changed. Callers changed.
4608 (char_table_set_range): Adjuted for the above change.
4609 (map_sub_char_table): Delete args default_val and parent. Add arg
4610 top. Give decoded values to a Lisp function.
640c8776 4611 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4612 values to a Lisp function. Gcpro more variables.
4613 (uniprop_table_uncompress)
4614 (uniprop_decode_value_run_length): New functions.
4615 (uniprop_decoder, uniprop_decoder_count): New variables.
4616 (uniprop_get_decoder, uniprop_encode_value_character)
4617 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4618 New functions.
4619 (uniprop_encoder, uniprop_encoder_count): New variables.
4620 (uniprop_get_encoder, uniprop_table)
4621 (Funicode_property_table_internal, Fget_unicode_property_internal)
4622 (Fput_unicode_property_internal): New functions.
4623 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4624 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4625 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4626 char-code-property-alist.
4627
640c8776 4628 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4629 Vunicode_category_table.
4630
640c8776 4631 * font.c (font_range): Adjust for the change of
c805dec0
KH
4632 Vunicode_category_table.
4633
76b397fb
DN
46342011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4635
4636 * m/iris4d.h: Remove file, move contents ...
4637 * s/irix6-5.h: ... here.
4638
22b4128e
PE
46392011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4640
4641 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4642 * alloc.c (mark_buffer):
4643 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4644 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4645 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4646 This isn't true in general, and it's particularly not true
4647 if Emacs is configured with --with-wide-int.
4648 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4649 New macros, used in the buffer.c change.
4650
869795d6
JD
46512011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4652
4653 * xsettings.c: Use both GConf and GSettings if both are available.
4654 (store_config_changed_event): Add comment.
4655 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4656 (store_tool_bar_style_changed): New functions.
5e617bc2 4657 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4658 (struct xsettings): Move font inside HAVE_XFT.
4659 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4660 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4661 Move inside HAVE_XFT.
640c8776 4662 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4663 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4664 also.
4665 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4666 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4667 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4668 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4669 (parse_settings): Move check for font inside HAVE_XFT.
4670 (read_settings, apply_xft_settings): Add comment.
4671 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4672 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4673 call store_font_name_changed.
4674 (xft_settings_event): Add comment.
4675 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4676 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4677 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4678 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4679 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4680 (xsettings_get_system_font, xsettings_get_system_normal_font):
4681 Add comment.
869795d6 4682
d8ed26bd
PE
46832011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4684
4685 Random fixes. E.g., (random) never returned negative values.
4686 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4687 subseconds part to the entropy, as that's a bit more random.
4688 Prefer signed to unsigned, since the signedness doesn't matter and
4689 in general we prefer signed. When given a limit, use a
4690 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4691 latter isn't right if USE_2_TAGS_FOR_INTS.
4692 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4693 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4694
cabf1cac
SM
46952011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4696
4697 * textprop.c (text_property_stickiness):
4698 Obey Vtext_property_default_nonsticky.
4699 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4700 * w32fns.c (syms_of_w32fns):
4701 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4702
6e9b2be9
PE
47032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4704
4705 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4706 This is more efficient than Ffile_directory_p and avoids a minor race.
4707
90186c68
LMI
47082011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4709
7c301272
LMI
4710 * buffer.c (Foverlay_put): Say what the return value is
4711 (bug#7835).
4712
c4f2d8d4
LMI
4713 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4714 is a directory before asking whether to use the file name
4715 (bug#7564).
ad637907
LMI
4716 (barf_or_query_if_file_exists): Make the "File is a directory"
4717 error be more correct.
c4f2d8d4 4718
90186c68
LMI
4719 * fns.c (Frequire): Remove the mention of the .gz files, since
4720 that's installation-specific, but keep the mention of
4721 `get-load-suffixes'.
4722
da64016e
PE
47232011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4724
4725 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4726 Report string overflow if the output is too long.
4727
7d47b580
JB
47282011-07-04 Juanma Barranquero <lekktu@gmail.com>
4729
a555cb87
JB
4730 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4731 (syms_of_gnutls): Remove duplicate DEFSYM for
4732 Qgnutls_bootprop_verify_hostname_error, an error for
4733 Qgnutls_bootprop_verify_error (which is no longer used).
4734
7d47b580
JB
4735 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4736 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4737 Also (re)move comments that are misplaced or no longer relevant.
4738
1e49bfab
LMI
47392011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4740
4741 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4742
1485f4c0
CY
47432011-07-03 Chong Yidong <cyd@stupidchicken.com>
4744
4745 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4746 and background color parameters if they have been changed.
4747
a9ab721e
LMI
47482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4749
4750 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4751
cf7cff57
PE
47522011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4753
2e13213d
PE
4754 * xsettings.c (SYSTEM_FONT): Define only when used.
4755 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4756
cf7cff57
PE
4757 * keymap.c (access_keymap_1): Now static.
4758
7a8e04f7
CY
47592011-07-02 Chong Yidong <cyd@stupidchicken.com>
4760
4761 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4762 leave any prefix arg for the up event (Bug#1586).
4763
61352f62
LMI
47642011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4765
69bb1ef7
LMI
4766 * lread.c (syms_of_lread): Mention single symbols defined by
4767 `defvar' or `defconst' (bug#7154).
4768
61352f62 4769 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4770 (Frequire): Mention get-load-suffixes.
61352f62 4771
28545e04
MR
47722011-07-02 Martin Rudalics <rudalics@gmx.at>
4773
4774 * window.h (window): Remove clone_number slot.
4775 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4776 Remove.
4777 (make_parent_window, make_window, saved_window)
4778 (Fset_window_configuration, save_window_save): Don't deal with
4779 clone numbers.
4780 * buffer.c (Qclone_number): Remove declaration.
4781 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4782
3349e122
SM
47832011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4784
4785 Add multiple inheritance to keymaps.
4786 * keymap.c (Fmake_composed_keymap): New function.
4787 (Fset_keymap_parent): Simplify.
4788 (fix_submap_inheritance): Remove.
4789 (access_keymap_1): New function extracted from access_keymap to handle
4790 embedded parents and handle lists of maps.
4791 (access_keymap): Use it.
4792 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4793 (Fcopy_keymap): Handle embedded parents.
4794 (Fcommand_remapping, define_as_prefix): Simplify.
4795 (Fkey_binding): Simplify.
4796 (syms_of_keymap): Move minibuffer-local-completion-map,
4797 minibuffer-local-filename-completion-map,
4798 minibuffer-local-must-match-map, and
4799 minibuffer-local-filename-must-match-map to Elisp.
4800 (syms_of_keymap): Defsubr make-composed-keymap.
4801 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4802 (parse_menu_item): Trivial simplification.
4803
3279eb87
GM
48042011-07-01 Glenn Morris <rgm@gnu.org>
4805
4806 * Makefile.in (SETTINGS_LIBS): Fix typo.
4807
4550efdf
KI
48082011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4809
4810 * coding.c (Fencode_coding_string): Record the last coding system
4811 used, as the function doc string says (bug#8738).
4812
0949d2b6
JD
48132011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4814
4815 * xsettings.c (store_monospaced_changed): Take new font as arg and
4816 check for change against current_mono_font.
4817 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4818 (emacs_settings_constructor, emacs_settings_get_property)
4819 (emacs_settings_set_property, emacs_settings_class_init)
4820 (emacs_settings_init, gsettings_obj): Remove.
4821 (something_changedCB): New function for HAVE_GSETTINGS.
4822 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4823 with value as argument.
4824 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4825 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4826 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4827 "changed".
4828
4829 * xgselect.c: Add defined (HAVE_GSETTINGS).
4830 (xgselect_initialize): Ditto.
4831
4832 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4833 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4834 xg_select.
4835
bbc6b304
PE
48362011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4837
4838 * eval.c (struct backtrace): Simplify and port the data structure.
4839 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4840 signed bit field, as this assumption is not portable and it makes
4841 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4842 "char debug_on_exit : 1" as this is not portable either; instead,
4843 use the portable "unsigned int debug_on_exit : 1". Remove unused
4844 member evalargs. Remove obsolete comments about cc bombing out.
4845
9851bfc5
JD
48462011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4847
51bb811f 4848 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4849 Let HAVE_GSETTINGS override HAVE_GCONF.
4850 (store_monospaced_changed): New function.
4851 (EMACS_SETTINGS): A new type derived from GObject to handle
4852 GSettings notifications.
4853 (emacs_settings_constructor, emacs_settings_get_property)
4854 (emacs_settings_set_property, emacs_settings_class_init):
4855 New functions.
4856 (gsettings_client, gsettings_obj): New variables.
4857 (GSETTINGS_SCHEMA): New define.
4858 (something_changedCB): Call store_monospaced_changed.
4859 (init_gsettings): New function.
4860 (xsettings_initialize): Call init_gsettings.
4861 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4862 to NULL.
4863
640c8776 4864 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4865 GCONF_CFLAGS/LIBS.
4866
5386012d
MR
48672011-06-29 Martin Rudalics <rudalics@gmx.at>
4868
4869 * window.c (resize_root_window, grow_mini_window)
4870 (shrink_mini_window): Rename Qresize_root_window to
4871 Qwindow_resize_root_window and Qresize_root_window_vertically to
4872 Qwindow_resize_root_window_vertically.
4873
f13e0b08
PE
48742011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4875
4876 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4877
94515237
JB
48782011-06-27 Juanma Barranquero <lekktu@gmail.com>
4879
4880 * makefile.w32-in: Redesign dependencies so they reflect more
4881 clearly which files are directly included by each source file,
4882 and not through other includes.
4883
e43b6e43
MR
48842011-06-27 Martin Rudalics <rudalics@gmx.at>
4885
4886 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4887 (sort_overlays, overlay_strings): When an overlay's clone number
4888 matches the window's clone number process the overlay even if
4889 the overlay's window property doesn't match the current window.
4890
d68443dc
MR
4891 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4892 (Fwindow_hchild): Rename to Fwindow_left_child.
4893 (Fwindow_next): Rename to Fwindow_next_sibling.
4894 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4895 (resize_window_check): Rename to window_resize_check.
4896 (resize_window_apply): Rename to window_resize_apply.
4897 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4898 (Fdelete_other_windows_internal, resize_frame_windows)
4899 (Fsplit_window_internal, Fdelete_window_internal)
4900 (grow_mini_window, shrink_mini_window)
4901 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4902
c7e73be5
JD
49032011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4904
4905 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4906 (emacs_fixed_set_min_size): Remove.
4907 (emacs_fixed_new): Take frame as argument.
4908
4909 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4910 (_EmacsFixedPrivate): Remove minwidth/height.
4911 Add struct frame *f.
4912 (emacs_fixed_init): Initialize priv->f.
4913 (get_parent_class, emacs_fixed_set_min_size): Remove.
4914 (emacs_fixed_new): Set priv->f to argument.
4915 (emacs_fixed_get_preferred_width)
4916 (emacs_fixed_get_preferred_height): Use min_width/height from
4917 frames size_hint to set minimum and natural (Bug#8919).
4918 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4919 and use min_width/height from frames size_hint to set
4920 min_width/height (Bug#8919).
4921
4922 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4923 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4924 Fix indentation.
c7e73be5 4925
cf99dcf8
EZ
49262011-06-26 Eli Zaretskii <eliz@gnu.org>
4927
4928 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4929 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4930 called at ZV.
4931
029529ac
CY
49322011-06-26 Chong Yidong <cyd@stupidchicken.com>
4933
4934 * process.c (wait_reading_process_output): Bypass select if
4935 waiting for a cell while ignoring keyboard input, and input is
4936 pending. Suggested by Jan Djärv (Bug#8869).
4937
7a7ef429
PE
49382011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4939
4940 Use gnulib's dup2 module instead of rolling our own.
4941 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4942
11fdef7d 49432011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4944
4945 * dispnew.c (scrolling_window): Before scrolling, turn off a
4946 mouse-highlight in the window being scrolled.
4947
cd3520a4
JB
49482011-06-24 Juanma Barranquero <lekktu@gmail.com>
4949
4950 Move DEFSYM to lisp.h and use everywhere.
4951
4952 * character.h (DEFSYM): Move declaration...
4953 * lisp.h (DEFSYM): ...here.
4954
4955 * gnutls.c:
4956 * minibuf.c:
4957 * w32menu.c:
4958 * w32proc.c:
4959 * w32select.c: Don't include character.h.
4960
4961 * alloc.c (syms_of_alloc):
4962 * buffer.c (syms_of_buffer):
4963 * bytecode.c (syms_of_bytecode):
4964 * callint.c (syms_of_callint):
4965 * casefiddle.c (syms_of_casefiddle):
4966 * casetab.c (init_casetab_once):
4967 * category.c (init_category_once, syms_of_category):
4968 * ccl.c (syms_of_ccl):
4969 * cmds.c (syms_of_cmds):
4970 * composite.c (syms_of_composite):
4971 * dbusbind.c (syms_of_dbusbind):
4972 * dired.c (syms_of_dired):
4973 * dispnew.c (syms_of_display):
4974 * doc.c (syms_of_doc):
4975 * editfns.c (syms_of_editfns):
4976 * emacs.c (syms_of_emacs):
4977 * eval.c (syms_of_eval):
4978 * fileio.c (syms_of_fileio):
4979 * fns.c (syms_of_fns):
4980 * frame.c (syms_of_frame):
4981 * fringe.c (syms_of_fringe):
4982 * insdel.c (syms_of_insdel):
4983 * keymap.c (syms_of_keymap):
4984 * lread.c (init_obarray, syms_of_lread):
4985 * macros.c (syms_of_macros):
4986 * msdos.c (syms_of_msdos):
4987 * print.c (syms_of_print):
4988 * process.c (syms_of_process):
4989 * search.c (syms_of_search):
4990 * sound.c (syms_of_sound):
4991 * syntax.c (init_syntax_once, syms_of_syntax):
4992 * terminal.c (syms_of_terminal):
4993 * textprop.c (syms_of_textprop):
4994 * undo.c (syms_of_undo):
4995 * w32.c (globals_of_w32):
4996 * window.c (syms_of_window):
4997 * xdisp.c (syms_of_xdisp):
4998 * xfaces.c (syms_of_xfaces):
4999 * xfns.c (syms_of_xfns):
5000 * xmenu.c (syms_of_xmenu):
5001 * xsettings.c (syms_of_xsettings):
5002 * xterm.c (syms_of_xterm): Use DEFSYM.
5003
4228cf16
TZ
50042011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5005
cd3520a4 5006 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5007
7fcccf1e
PE
50082011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5009
7efb4e0e
PE
5010 Integer and buffer overflow fixes (Bug#8873).
5011
ff5844ad
PE
5012 * print.c (printchar, strout): Check for string overflow.
5013 (PRINTPREPARE, printchar, strout):
5014 Don't set size unless allocation succeeds.
5015
90532f02
PE
5016 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5017 for sizes. Check for string overflow more accurately.
5018 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5019
6d84508d
PE
5020 * macros.c: Integer and buffer overflow fixes.
5021 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5022 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5023 Use ptrdiff_t, not int, for sizes.
5024 Don't increment bufsize until after realloc succeeds.
5025 Check for size-calculation overflow.
5026 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5027
437b2cb4
PE
5028 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5029
8b9ac8b4
PE
5030 * lread.c: Integer overflow fixes.
5031 (read_integer): Radix is now EMACS_INT, not int,
5032 to improve quality of diagnostics for out-of-range radices.
5033 Calculate buffer size correctly for out-of-range radices.
5034 (read1): Check for integer overflow in radices, and in
5035 read-circle numbers.
82cb60d3
PE
5036 (read_escape): Avoid int overflow.
5037 (Fload, openp, read_buffer_size, read1)
5038 (substitute_object_recurse, read_vector, read_list, map_obarray):
5039 Use ptrdiff_t, not int, for sizes.
5040 (read1): Use EMACS_INT, not int, for sizes.
20270765 5041 Check for size overflow.
8b9ac8b4 5042
7fcccf1e
PE
5043 * image.c (cache_image): Check for size arithmetic overflow.
5044
bfbbd7e7
PE
5045 * lread.c: Integer overflow issues.
5046 (saved_doc_string_size, saved_doc_string_length)
5047 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5048 Now ptrdiff_t, not int.
5049 (read1): Don't assume doc string length fits in int. Check for
5050 out-of-range doc string lengths.
5051 (read_list): Don't assume file position fits in int.
39019e54 5052 (read_escape): Check for hex character overflow.
bfbbd7e7 5053
4e323265
LL
50542011-06-22 Leo Liu <sdl.web@gmail.com>
5055
5056 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5057 Move to minibuffer.el.
5058
85fece3e
PE
50592011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5060
20b84ce9 5061 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5062 The following patches are for when GLYPH_DEBUG && !XASSERT.
5063 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5064 * dispnew.c (flush_stdout):
5065 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5066 Mark as externally visible.
5067 * dispnew.c (check_window_matrix_pointers): Now static.
5068 * dispnew.c (window_to_frame_vpos):
5069 * xfns.c (unwind_create_frame):
5070 * xterm.c (x_check_font): Remove unused local.
5071 * scroll.c (CHECK_BOUNDS):
5072 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5073 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5074 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5075 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5076 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5077 Now static.
5078 (debug_method_add): Use va_list and vsprintf rather than relying
5079 on undefined behavior with wrong number of arguments.
5080 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5081 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5082 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5083 since we're not interested in debugging glyphs with old libraries.
5084 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5085 GCC 4.6.0's static checking.
5086
0766b489
PE
50872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5088
31fd4b32
PE
5089 Integer overflow and signedness fixes (Bug#8873).
5090 A few related buffer overrun fixes, too.
5091
b79e8648
PE
5092 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5093
0766b489
PE
5094 * dispextern.h (struct face.stipple):
5095 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5096 (x_bitmap_mask, x_allocate_bitmap_record)
5097 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5098 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5099 (x_create_bitmap_from_xpm_data):
5100 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5101 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5102 (.bitmaps_last):
5103 * xfaces.c (load_pixmap):
5104 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5105 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5106 (.bitmaps_last, struct x_output.icon_bitmap):
5107 Use ptrdiff_t, not int, for bitmap indexes.
5108 (x_allocate_bitmap_record): Check for size overflow.
5109 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5110
b081724f
PE
5111 Use ptrdiff_t, not int, for overlay counts.
5112 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5113 * editfns.c (overlays_around, get_pos_property):
5114 * textprop.c (get_char_property_and_overlay):
5115 * xdisp.c (next_overlay_change, note_mouse_highlight):
5116 * xfaces.c (face_at_buffer_position):
21514da7
PE
5117 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5118 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5119 (Fnext_overlay_change, Fprevious_overlay_change)
5120 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5121 Use ptrdiff_t, not int, for sizes.
21514da7 5122 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5123
3de73e5e
PE
5124 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5125
2606c57b
PE
5126 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5127 (x_session_initialize): Do not assume string length fits in int.
5128
aaafe47a
PE
5129 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5130 This is unlikely, but can occur if DPI is outlandish.
5131
2674ddc8 5132 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5133 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5134
28154962
PE
5135 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5136 * xrdb.c (magic_file_p, search_magic_path):
5137 Omit last arg SUFFIX; it was always 0. All callers changed.
5138 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5139
7de51af5
PE
5140 * xfont.c (xfont_match): Avoid need for strlen.
5141
25ed6cc3
PE
5142 * xfns.c: Don't assume strlen fits in int.
5143 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5144
4eab31dd
PE
5145 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5146 not unsigned long, as we prefer signed integers. All callers changed.
5147 Detect integer overflow in repeat count.
5148 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5149 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5150
171e2a58
PE
5151 * termcap.c: Don't assume sizes fit in int and never overflow.
5152 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5153 (gobble_line): Check for size-calculation overflow.
5154
ad39faca 5155 * minibuf.c (Fread_buffer):
6e5bb2dc 5156 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5157 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5158 Don't assume string length fits in int.
5159
52c61c22 5160 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5161 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5162
b5b8c9e5
PE
5163 * font.c: Don't assume string length fits in int.
5164 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5165 Use ptrdiff_t, not int.
ccd6111c
PE
5166 (font_intern_prop): Don't assume string length fits in int.
5167 Don't assume integer property fits in fixnum.
5168 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5169
882f0d81 5170 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5171 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5172 Reformulate so as not to need the command string.
5173 Invoke gzip -cd rather than gunzip, as it's more portable.
5174 (lock_info_type, lock_file_1, lock_file):
5175 Don't assume pid_t and time_t fit in unsigned long.
5176 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5177 (current_lock_owner): Prefer signed type for sizes.
5178 Use memcpy, not strncpy, where memcpy is what is really wanted.
5179 Don't assume (via atoi) that time_t and pid_t fit in int.
5180 Check for time_t and/or pid_t out of range, e.g., via a network share.
5181 Don't alloca where an auto var works fine.
5182
93f4cf88
PE
5183 * fileio.c: Fix some integer overflow issues.
5184 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5185 Don't assume string length fits in int.
5186 (directory_file_name): Don't assume string length fits in long.
5187 (make_temp_name): Don't assume pid fits in int, or that its print
5188 length is less than 20.
5189
f3e92b69
PE
5190 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5191
1bfdaf10
PE
5192 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5193
35016e9a
PE
5194 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5195
3d1e65a1
PE
5196 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5197 We prefer signed integers, even for size calculations.
5198
0b963a93
PE
5199 * emacs.c: Don't assume string length fits in 'int'.
5200 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5201 (main): Don't invoke strlen when not needed.
5202
573f4b54
PE
5203 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5204 (XD_DEBUG_MESSAGE): Don't waste a byte.
5205
989f33ba
PE
5206 * callproc.c (getenv_internal_1, getenv_internal)
5207 (Fgetenv_internal):
965d34eb
PE
5208 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5209
e4d29b33
PE
5210 * lread.c (invalid_syntax): Omit length argument.
5211 All uses changed. This doesn't fix a bug, but it simplifies the
5212 code away from its former Hollerith-constant appearance, and it's
5213 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5214 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5215
eb49b136
PE
5216 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5217 This didn't break anything, but it didn't help either.
5218 It's confusing to put a bogus integer in a place where the actual
5219 value does not matter.
9f62aeb1 5220 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5221 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5222
15375a22
PE
5223 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5224 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5225 implementation.
b61cc01c
PE
5226 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5227 We prefer signed types, and the value cannot exceed the EMACS_INT
5228 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5229 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5230 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5231 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5232
53b2623d
PE
5233 * indent.c (sane_tab_width): New function.
5234 (current_column, scan_for_column, Findent_to, position_indentation)
5235 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5236 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5237
51cab52b 5238 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5239
f2ed8a70
PE
5240 * lisp.h (lint_assume): New macro.
5241 * composite.c (composition_gstring_put_cache):
5242 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5243
abe80cc6
PE
5244 * editfns.c, insdel.c:
5245 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5246
b02c740e
PE
5247 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5248
ebc96716
PE
5249 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5250
b4e50fa0 5251 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5252 Use much-faster test for byte-length change.
311d5d7c 5253 Don't assume string byte-length fits in 'int'.
a4cf38e4 5254 Check that character arg fits in 'int'.
85461888 5255 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5256
c0c1ee9f
PE
5257 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5258
a498d7f4
PE
5259 * fns.c (concat): Catch string overflow earlier.
5260 Do not rely on integer wraparound.
5261
51cab52b
PE
5262 * dispextern.h (struct it.overlay_strings_charpos)
5263 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5264 * xdisp.c (forward_to_next_line_start)
5265 (back_to_previous_visible_line_start)
5266 (reseat_at_next_visible_line_start, next_element_from_buffer):
5267 Don't arbitrarily truncate the value of 'selective' to int.
5268
76031fad
PE
5269 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5270
5eb55db9
PE
5271 * composite.c: Don't truncate sizes to 'int'.
5272 (composition_gstring_p, composition_reseat_it)
5273 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5274 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5275 not EMACS_UINT, for indexes.
5eb55db9 5276
0703a717
PE
5277 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5278
d6202519
PE
5279 * buffer.c: Include <verify.h>.
5280 (struct sortvec.priority, struct sortstr.priority):
8961a454 5281 Now EMACS_INT, not int.
c20998a7 5282 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5283 (struct sortstr.size, record_overlay_string)
5284 (struct sortstrlist.size, struct sortlist.used):
5285 Don't truncate size to int.
5286 (record_overlay_string): Check for size-calculation overflow.
d6202519 5287 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5288
d5a19415
JM
52892011-06-22 Jim Meyering <meyering@redhat.com>
5290
029529ac 5291 Don't leak an XBM-image-sized buffer
d5a19415
JM
5292 * image.c (xbm_load): Free the image buffer after using it.
5293
a9041e6c
PE
52942011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5295
5296 Port to Sun C.
5297 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5298 that Sun C diagnosed.
5299 * fns.c (secure_hash): Fix pointer signedness issue.
5300 * intervals.c (static_offset_intervals): New function.
5301 (offset_intervals): Use it.
5302
7f3f739f
LL
53032011-06-21 Leo Liu <sdl.web@gmail.com>
5304
5305 * deps.mk (fns.o):
5306 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5307 sha512.h.
5308
5309 * fns.c (secure_hash): Rename from crypto_hash_function and change
5310 the first arg to accept symbols.
5b66d427 5311 (Fsecure_hash): New primitive.
7f3f739f
LL
5312 (syms_of_fns): New symbols.
5313
76147d94
DD
53142011-06-20 Deniz Dogan <deniz@dogan.se>
5315
5316 * process.c (Fset_process_buffer): Clarify return value in
5317 docstring.
5318
7d7d0045
CY
53192011-06-18 Chong Yidong <cyd@stupidchicken.com>
5320
5321 * dispnew.c (add_window_display_history): Use BVAR.
5322
5323 * xdisp.c (debug_method_add): Use BVAR.
5324 (check_window_end, dump_glyph_matrix, dump_glyph)
5325 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5326
5327 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5328 Likewise.
5329
5330 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5331 check till after the cache is created in init_frame_faces.
5332
ff2bc410
SM
53332011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5334
5335 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5336
28177add
PE
53372011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5338
dd3482fe
PE
5339 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5340 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5341 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5342
393d71f3 5343 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5344 * fileio.c (Finsert_file_contents):
5345 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5346 Remove the old (too-loose) buffer overflow checks.
5347 They weren't needed, since make_gap checks for buffer overflow.
5348 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5349 The old code merely checked for Emacs fixnum overflow, and relied
5350 on undefined (wraparound) behavior. The new code avoids undefined
5351 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5352
2e6813b0 5353 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5354 Tune. Don't use wider integers than needed. Don't use alloca.
5355 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5356
599a9e4f
PE
5357 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5358
99561444
PE
5359 * insdel.c, lisp.h (buffer_overflow): New function.
5360 (insert_from_buffer_1, replace_range, replace_range_2):
5361 * insdel.c (make_gap_larger):
5362 * editfns.c (Finsert_char):
5363 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5364
28177add
PE
5365 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5366
e69dafad
PE
53672011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5368
4baa020d 5369 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5370
b1c46f02
PE
5371 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5372 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5373
e69dafad
PE
5374 * fileio.c: Don't assume EMACS_INT fits in off_t.
5375 (emacs_lseek): New static function.
5376 (Finsert_file_contents, Fwrite_region): Use it.
5377 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5378
566684ea
PE
5379 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5380
e6966cd6
PE
5381 * fns.c: Don't overflow int when computing a list length.
5382 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5383 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5384 truncation on 64-bit hosts. Check for QUIT every
5385 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5386 faster and is responsive enough.
5387 (Flength): Report an error instead of overflowing an integer.
5388 (Fsafe_length): Return a float if the value is not representable
5389 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5390 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5391 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5392
dd0b0efb
PE
5393 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5394 (header_size, word_size): New constants.
5395 (allocate_vectorlike): Don't check size overflow here.
5396 (allocate_vector): Check it here instead, since this is the only
5397 caller of allocate_vectorlike that could cause overflow.
5398 Check that the new vector's length is representable as a fixnum.
5399
86fe5cfe
PE
5400 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5401 The previous code was bogus. For example, next_almost_prime (32)
5402 returned 39, which is undesirable as it is a multiple of 3; and
5403 next_almost_prime (24) returned 25, which is a multiple of 5 so
5404 why was the code bothering to check for multiples of 7?
5405
80e88859
PE
5406 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5407
4a2f0ad6
PE
5408 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5409
f66c7cf8
PE
5410 Variadic C functions now count arguments with ptrdiff_t.
5411 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5412 Back then I didn't know that the Emacs coding style prefers signed int.
5413 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5414 were being counted with int, which may truncate counts on 64-bit
5415 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5416 * lisp.h (struct Lisp_Subr.function.aMANY)
5417 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5418 Arg counts are now ptrdiff_t, not size_t.
5419 All variadic functions and their callers changed accordingly.
5420 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5421 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5422 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5423 * callint.c (Fcall_interactively): Check arg count for overflow,
5424 to avoid potential buffer overrun. Use signed char, not 'int',
5425 for 'varies' array, so that we needn't bother to check its size
5426 calculation for overflow.
5427 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5428 * eval.c (apply_lambda):
5429 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5430 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5431 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5432
a1759b76
PE
5433 * callint.c (Fcall_interactively): Don't use index var as event count.
5434
d96be9fc
PE
5435 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5436 * mem-limits.h (SIZE): Remove; no longer used.
5437
a690a978 5438 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5439
578c21e6
PE
5440 Remove unnecessary casts.
5441 * xterm.c (x_term_init):
5442 * xfns.c (x_set_border_pixel):
5443 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5444 These aren't needed now that we assume ANSI C.
5445
96f53c6c
PE
5446 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5447 It's more likely to cause problems (due to unsigned overflow)
5448 than to cure them.
5449
83c77d31
PE
5450 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5451
ee2079f1
PE
5452 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5453
6da65536
PE
5454 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5455
7147c4a4
PE
5456 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5457
193e32d9
PE
5458 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5459
e5533da6
PE
5460 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5461
9910e595
PE
5462 GLYPH_CODE_FACE returns EMACS_INT, not int.
5463 * dispextern.h (merge_faces):
5464 * xfaces.c (merge_faces):
01103c44
PE
5465 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5466 Don't assume EMACS_INT fits in int.
9910e595 5467
2638320e
PE
5468 * character.h (CHAR_VALID_P): Remove unused parameter.
5469 * fontset.c, lisp.h, xdisp.c: All uses changed.
5470
045eb8d9
PE
5471 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5472
c1f134b5
PE
5473 * fns.c (concat): Minor tuning based on overflow analysis.
5474 This doesn't fix any bugs. Use int to hold character, instead
5475 of constantly refetching from Emacs object. Use XFASTINT, not
5476 XINT, for value known to be a character. Don't bother comparing
5477 a single byte to 0400, as it's always less.
5478
395fcb93 5479 * floatfns.c (Fexpt):
327eeec8
PE
5480 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5481
abbd3d23
PE
5482 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5483 for characters.
5484
684a03ef
PE
5485 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5486
0fed43f3
PE
5487 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5488 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5489 incorrectly succeed when S was a string, because 4294967386 was
5490 truncated before it was used.
5491
8fd02eb7
PE
5492 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5493 Otherwise, an out-of-range integer could cause undefined behavior
5494 on a 64-bit host.
5495
f8c86b69
PE
5496 * composite.c: Use int, not EMACS_INT, for characters.
5497 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5498 EMACS_INT, for values that are known to be in character range.
5499 This doesn't fix any bugs but is the usual style inside Emacs and
5500 may generate better code on 32-bit machines.
5501
34206dd2
PE
5502 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5503 This is for reasons similar to the recent CHAR_STRING fix.
5504 * charset.c (Fencode_char): Check that character arg is actually
5505 a character. Pass an int to ENCODE_CHAR.
5506 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5507 wider than 'int', as a compile-time check to prevent future regressions
5508 in this area.
5509
c5958d4c 5510 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5511
5512 Make sure a 64-bit char is never passed to CHAR_STRING.
5513 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5514 by silently ignoring the top 32 bits, allowing some values
5515 that were far too large to be valid characters.
5516 * character.h: Include <verify.h>.
5517 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5518 arguments are no wider than unsigned, as a compile-time check
5519 to prevent future regressions in this area.
5520 * data.c (Faset):
01103c44 5521 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5522 (Fsubst_char_in_region):
5523 * fns.c (concat):
5524 * xdisp.c (decode_mode_spec_coding):
5525 Adjust to CHAR_STRING's new requirement.
5526 * editfns.c (Finsert_char, Fsubst_char_in_region):
5527 * fns.c (concat): Check that character args are actually
5528 characters. Without this test, these functions did the wrong
5529 thing with wildly out-of-range values on 64-bit hosts.
5530
d37ca623
PE
5531 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5532 These casts should not be needed on 32-bit hosts, either.
5533 * keyboard.c (read_char):
5534 * lread.c (Fload): Remove casts to unsigned.
5535
ea204efb
PE
5536 * lisp.h (UNSIGNED_CMP): New macro.
5537 This fixes comparison bugs on 64-bit hosts.
5538 (ASCII_CHAR_P): Use it.
5539 * casefiddle.c (casify_object):
01103c44 5540 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5541 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5542 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5543 * dispextern.h (FACE_FROM_ID):
5544 * keyboard.c (read_char): Use UNSIGNED_CMP.
5545
41cb286c
PE
5546 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5547 not to EMACS_INT, to avoid GCC warning.
5548
4a1b9832
PE
5549 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5550
55daad71
PE
5551 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5552 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5553 isn't needed on 32-bit machines.
8f95c75c 5554
01103c44
PE
5555 * buffer.c (Fgenerate_new_buffer_name):
5556 Use EMACS_INT for count, not int.
0ceccced 5557 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5558
5559 * data.c (Qcompiled_function): Now static.
5560
c6f072e7
PE
5561 * window.c (window_body_lines): Now static.
5562
20ce5912
PE
5563 * image.c (gif_load): Rename local to avoid shadowing.
5564
9c4c5f81
PE
5565 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5566 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5567 * alloc.c (make_save_value): Integer argument is now of type
5568 ptrdiff_t, not int.
5569 (mark_object): Use ptrdiff_t, not int.
5570 * lisp.h (pD): New macro.
5571 * print.c (print_object): Use it.
5572
c0c5c8ae
PE
5573 * alloc.c: Use EMACS_INT, not int, to count objects.
5574 (total_conses, total_markers, total_symbols, total_vector_size)
5575 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5576 (total_free_floats, total_floats, total_free_intervals)
5577 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5578 Now EMACS_INT, not int. All uses changed.
5579 (Fgarbage_collect): Compute overall total using a double, so that
5580 integer overflow is less likely to be a problem. Check for overflow
5581 when converting back to an integer.
5a25e253
PE
5582 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5583 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5584 These were 'int' variables that could overflow on 64-bit hosts;
5585 they were never used, so remove them instead of repairing them.
211a0b2a 5586 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5587 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5588 Previously, this ceilinged at INT_MAX, but that doesn't work on
5589 64-bit machines.
e46bb31a 5590 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5591
c78baabf 5592 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5593 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5594 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5595 when a (possibly-narrower) signed value would do just as well.
5596 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5597
c9d624c6
PE
5598 * alloc.c: Catch some string size overflows that we were missing.
5599 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5600 for convenience in STRING_BYTES_MAX.
5601 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5602 The definition here is exact; the one in lisp.h was approximate.
5603 (allocate_string_data): Check for string overflow. This catches
5604 some instances we weren't catching before. Also, it catches
5605 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5606 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5607 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5608
c9d624c6
PE
5609 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5610 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5611 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5612
353032ce
PE
5613 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5614
2bccce07
PE
5615 * alloc.c (Fmake_string): Check for out-of-range init.
5616
0ac30604
SM
56172011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5618
5619 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5620
c195f2de
JD
56212011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5622
5623 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5624 xg_get_default_scrollbar_width.
5625
5626 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5627 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5628 (style_changed_cb): Call update_theme_scrollbar_width and call
5629 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5630 all frames (Bug#8505).
5631 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5632 Call gtk_window_set_resizable if HAVE_GTK3.
5633 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5634 and height if HAVE_GTK3 (Bug#8505).
5635 (scroll_bar_width_for_theme): New variable.
5636 (update_theme_scrollbar_width): New function.
5637 (xg_get_default_scrollbar_width): Move code to
5638 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5639 (xg_initialize): Call update_theme_scrollbar_width.
5640
5641 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5642
5643 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5644
e10ac9f1
MR
56452011-06-12 Martin Rudalics <rudalics@gmx.at>
5646
5647 * frame.c (make_frame): Call other_buffer_safely instead of
5648 other_buffer.
5649
5650 * window.c (temp_output_buffer_show): Call display_buffer with
5651 second argument Vtemp_buffer_show_specifiers and reset latter
5652 immediately after the call.
5653 (Vtemp_buffer_show_specifiers): New variable.
5654 (auto_window_vscroll_p, next_screen_context_lines)
5655 (Vscroll_preserve_screen_position): Remove leading asterisks from
5656 doc-strings.
5657
2d3c217e 56582011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5659
7b7f97e8 5660 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5661 * buffer.c (Qclone_number): Remove for now, as it's unused.
5662 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5663 (record_buffer): Remove unused local.
5664 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5665 (set_frame_buffer_list): Remove; unused.
5666 * frame.h (other_visible_frames): Remove decl.
5667 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5668 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5669 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5670 if HAVE_GPM.
5671 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5672 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5673 Define only if HAVE_GPM.
5674 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5675 (update_hints_inhibit): Remove; never set. All uses removed.
5676 * widgetprv.h (emacsFrameClassRec): Remove decl.
5677 * window.c (delete_deletable_window): Now returns void, since it
5678 wasn't returning anything.
5679 (compare_window_configurations): Remove unused locals.
5680 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5681 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5682 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5683 the same widths as pointers. This follows up on the 2011-05-06 patch.
5684 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5685 * xterm.h: Likewise.
5686 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5687
1384b89e
JB
56882011-06-12 Juanma Barranquero <lekktu@gmail.com>
5689
5690 * makefile.w32-in: Update dependencies.
5691 (LISP_H): Add lib/intprops.h.
5692
1100a63c
CY
56932011-06-11 Chong Yidong <cyd@stupidchicken.com>
5694
5695 * image.c (gif_load): Add animation frame delay to the metadata.
5696 (syms_of_image): Use DEFSYM. New symbol `delay'.
5697
6198ccd0
MR
56982011-06-11 Martin Rudalics <rudalics@gmx.at>
5699
5700 * window.c (delete_deletable_window): Re-add.
5701 (Fset_window_configuration): Rewrite to handle dead buffers and
5702 consequently deletable windows.
5703 (window_tree, Fwindow_tree): Remove. Supply functionality in
5704 window.el.
5705 (compare_window_configurations): Simplify code.
5706
b6e3633c
AS
57072011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5708
1ab0dee5
AS
5709 * image.c (imagemagick_load_image): Fix type mismatch.
5710 (Fimagemagick_types): Likewise.
5711
b6e3633c
AS
5712 * window.h (replace_buffer_in_windows): Declare.
5713
9397e56f
MR
57142011-06-11 Martin Rudalics <rudalics@gmx.at>
5715
5716 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5717 Qclone_number. Remove external declaration of Qdelete_window.
5718 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5719 code.
640c8776
SM
5720 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5721 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5722 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5723 buffer list implementation.
5724 (other_buffer_safely): New function.
5725 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5726 calls to replace_buffer_in_windows and
5727 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5728 if allowed.
5729 (record_buffer): Inhibit quitting and rewrite using quittable
5730 functions. Run Qbuffer_list_update_hook if allowed.
5731 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5732 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5733 Move switch-to-buffer to window.el.
9397e56f
MR
5734 (bury-buffer): Move to window.el.
5735 (Vbuffer_list_update_hook): New variable.
5736
5737 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5738 section.
5739
5740 * window.h (resize_frame_windows): Move up in code.
5741 (Fwindow_frame): Remove EXFUN.
5742 (replace_buffer_in_all_windows): Remove prototype.
5743 (replace_buffer_in_windows_safely): Add prototype.
5744
5745 * window.c: Declare Qdelete_window static again. Move down
5746 declaration of select_count.
5747 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5748 (Fother_window): Move to window.el.
5749 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5750 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5751 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5752 window.el.
5753 (replace_buffer_in_windows): Implement by calling
5754 Qreplace_buffer_in_windows.
5755 (replace_buffer_in_all_windows): Remove with some functionality
5756 moved into replace_buffer_in_windows_safely.
5757 (replace_buffer_in_windows_safely): New function.
5758 (select_window_norecord, select_frame_norecord): Move in front
5759 of run_window_configuration_change_hook. Remove now obsolete
5760 declarations.
640c8776
SM
5761 (Fset_window_buffer): Rewrite doc-string.
5762 Call Qrecord_window_buffer.
9397e56f
MR
5763 (keys_of_window): Move binding for other-window to window.el.
5764
b50691aa
CY
57652011-06-11 Chong Yidong <cyd@stupidchicken.com>
5766
5767 * dispextern.h (struct image): Replace data member, whose int_val
5768 and ptr_val fields were not used by anything, with a single
5769 lisp_val object.
5770
5771 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5772 (gif_clear_image, gif_load, imagemagick_load_image)
5773 (gs_clear_image, gs_load): Callers changed.
5774
3f754b86
PE
57752011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5776
cca69397
PE
5777 * buffer.h: Include <time.h>, for time_t.
5778 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5779
109e28d0
PE
5780 Fix minor problems found by static checking.
5781
60737f02
PE
5782 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5783
4b66faf3
PE
5784 Make identifiers static if they are not used in other modules.
5785 * data.c (Qcompiled_function, Qframe, Qvector):
5786 * image.c (QimageMagick, Qsvg):
5787 * minibuf.c (Qmetadata):
5788 * window.c (resize_window_check, resize_root_window): Now static.
5789 * window.h (resize_window_check, resize_root_window): Remove decls.
5790
109e28d0
PE
5791 * window.c (window_deletion_count, delete_deletable_window):
5792 Remove; unused.
46a4ce9e
PE
5793 (window_body_lines): Now static.
5794 (Fdelete_other_windows_internal): Mark vars as initialized.
5795 Make sure 'resize_failed' is initialized.
5796 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5797 (resize_window_apply): Remove unused local.
5798 * window.h (delete_deletable_window): Remove decl.
5799
109e28d0 5800 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5801 (imagemagick_load_image): Fix pointer signedness problem by changing
5802 last arg from unsigned char * to char *. All uses changed.
5803 Also, fix a local for similar reasons.
5804 Remove unused locals. Remove locals to avoid shadowing.
5805 (fn_rsvg_handle_free): Remove; unused.
5806 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5807 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5808
3f754b86
PE
5809 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5810
2547adb1
CY
58112011-06-10 Chong Yidong <cyd@stupidchicken.com>
5812
5813 * image.c (gif_load): Fix omitted cast error introduced by
5814 2011-06-06 change.
5815
2c8e37d4
MR
58162011-06-10 Martin Rudalics <rudalics@gmx.at>
5817
5818 * window.h (resize_proportionally, orig_total_lines)
5819 (orig_top_line): Remove from window structure.
5820 (set_window_height, set_window_width, change_window_heights)
5821 (Fdelete_window): Remove prototypes.
5822 (resize_frame_windows): Remove duplicate declaration.
5823
440a42e3
EZ
58242011-06-10 Eli Zaretskii <eliz@gnu.org>
5825
5826 * window.h (resize_frame_windows, resize_window_check)
5827 (delete_deletable_window, resize_root_window)
5828 (resize_frame_windows): Declare prototypes.
5829
5830 * window.c (resize_window_apply): Make definition be "static" to
5831 match the prototype.
5832
562dd5e9
MR
58332011-06-10 Martin Rudalics <rudalics@gmx.at>
5834
5835 * window.c: Remove declarations of Qwindow_size_fixed,
5836 window_min_size_1, window_min_size_2, window_min_size,
5837 size_window, window_fixed_size_p, enlarge_window, delete_window.
5838 Remove static from declaration of Qdelete_window, it's
5839 temporarily needed by Fbury_buffer.
5840 (replace_window): Don't assign orig_top_line and
5841 orig_total_lines.
5842 (Fdelete_window, delete_window): Remove. Window deletion is
5843 handled by window.el.
640c8776
SM
5844 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5845 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5846 (Fdelete_other_windows): Remove. Deleting other windows is
5847 handled by window.el.
5848 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5849 handled in window.el.
5850 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5851 Window minimum sizes are handled in window.el.
5852 (shrink_windows, size_window, set_window_height)
5853 (set_window_width, change_window_heights, window_height)
5854 (window_width, CURBEG, CURSIZE, enlarge_window)
5855 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5856 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5857 handled in window.el.
5858 (make_dummy_parent): Rename to make_parent_window and give it a
5859 second argument horflag.
5860 (make_window): Don't set resize_proportionally any more.
5861 (Fsplit_window): Remove. Windows are split in window.el.
5862 (save_restore_action, save_restore_orig_size)
5863 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5864 Resize mini windows in window.el.
5865 (grow_mini_window, shrink_mini_window): Implement by calling
5866 Qresize_root_window_vertically, resize_window_check and
5867 resize_window_apply.
640c8776
SM
5868 (saved_window, Fset_window_configuration, save_window_save):
5869 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5870 resize_proportionally.
5871 (window_min_height, window_min_width): Move to window.el.
5872 (keys_of_window): Move bindings for delete-other-windows,
5873 split-window, delete-window and enlarge-window to window.el.
5874
5875 * buffer.c: Temporarily extern Qdelete_window.
5876 (Fbury_buffer): Temporarily call Qdelete_window instead of
5877 Fdelete_window (Fbury_buffer will move to window.el soon).
5878
5879 * frame.c (set_menu_bar_lines_1): Remove code handling
5880 orig_top_line and orig_total_lines.
5881
5882 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5883 set_window_height but set heights directly.
5884 (change_frame_size_1): Use resize_frame_windows.
5885
5886 * xdisp.c (init_xdisp): Don't use set_window_height but set
5887 heights directly.
5888
640c8776
SM
5889 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5890 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5891 run_window_configuration_change_hook.
5892
5893 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5894 instead of change_window_heights and run
5895 run_window_configuration_change_hook.
5896
1a13852e
MR
58972011-06-09 Martin Rudalics <rudalics@gmx.at>
5898
5899 * window.c (replace_window): Rename second argument REPLACEMENT to
5900 NEW. New third argument SETFLAG. Rewrite.
5901 (delete_window, make_dummy_parent): Call replace_window with
5902 third argument 1.
5903 (window_list_1): Move down in code.
5904 (run_window_configuration_change_hook): Move set_buffer part
5905 before select_frame_norecord part in order to unwind correctly.
5906 Rename count1 to count.
5907 (recombine_windows, delete_deletable_window, resize_root_window)
5908 (Fdelete_other_windows_internal)
5909 (Frun_window_configuration_change_hook, make_parent_window)
5910 (resize_window_check, resize_window_apply, Fresize_window_apply)
5911 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5912 (Fdelete_window_internal, Fresize_mini_window_internal):
5913 New functions.
1a13852e
MR
5914 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5915
f3d1777e
MR
59162011-06-08 Martin Rudalics <rudalics@gmx.at>
5917
496e208e
MR
5918 * window.h (window): Add some new members to window structure -
5919 normal_lines, normal_cols, new_total, new_normal, clone_number,
5920 splits, nest, prev_buffers, next_buffers.
5921 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5922 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5923
f3d1777e
MR
5924 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5925 Remove.
496e208e
MR
5926 (make_dummy_parent): Set new members of windows structure.
5927 (make_window): Move down in code. Handle new members of window
5928 structure.
5929 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5930 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5931 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5932 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5933 (Fset_window_next_buffers, Fset_window_clone_number):
5934 New functions.
496e208e
MR
5935 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5936 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5937 Doc-string fixes.
5938 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5939 Argument WINDOW can be now internal window too.
5940 (Fwindow_use_time): Move up in code.
5941 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5942 Rewrite doc-string.
5943 (Fset_window_configuration, saved_window)
5944 (Fcurrent_window_configuration, save_window_save): Handle new
5945 members of window structure.
b9e809c2
MR
5946 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5947 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5948 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5949 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5950 Qget_mru_window, Qresize_root_window,
5951 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5952 Qauto_buffer_name; staticpro them.
f3d1777e 5953
abde8f8c
MR
59542011-06-07 Martin Rudalics <rudalics@gmx.at>
5955
5956 * window.c (Fwindow_total_size, Fwindow_left_column)
5957 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5958 (Fwindow_list_1): New functions.
5959 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5960 (Fwindow_width, Fscroll_left, Fscroll_right):
5961 Use window_body_cols instead of window_box_text_cols.
5962 (delete_window, Fset_window_configuration):
5963 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5964 (delete_all_subwindows): Take a window as argument and not a
5965 structure. Rewrite.
190b47e6
MR
5966 (window_loop): Remove handling of GET_LRU_WINDOW and
5967 GET_LARGEST_WINDOW.
5968 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5969
5970 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5971 window_box_text_cols. delete_all_subwindows now takes a
5972 Lisp_Object as argument.
abde8f8c 5973
640c8776
SM
5974 * indent.c (compute_motion, Fcompute_motion):
5975 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5976
fa8a67e6
MR
5977 * frame.c (delete_frame): Call delete_all_subwindows with root
5978 window as argument.
5979
a54e3482
DC
59802011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5981
5982 * fns.c (Fputhash): Document return value.
5983
60002bf5
CY
59842011-06-06 Chong Yidong <cyd@stupidchicken.com>
5985
5986 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5987
0c671da6 59882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5989
b862a52a 5990 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5991
be44ca6c
PE
5992 Check for overflow when converting integer to cons and back.
5993 * charset.c (Fdefine_charset_internal, Fdecode_char):
5994 Use cons_to_unsigned to catch overflow.
5995 (Fencode_char): Use INTEGER_TO_CONS.
5996 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5997 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5998 * data.c (long_to_cons, cons_to_long): Remove.
5999 (cons_to_unsigned, cons_to_signed): New functions.
6000 These signal an error for invalid or out-of-range values.
6001 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6002 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6003 * font.c (Ffont_variation_glyphs):
6004 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6005 * lisp.h: Include <intprops.h>.
6006 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6007 (cons_to_signed, cons_to_unsigned): New decls.
6008 (long_to_cons, cons_to_long): Remove decls.
6009 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6010 (Fprimitive_undo): Use CONS_TO_INTEGER.
6011 * xfns.c (Fx_window_property): Likewise.
6012 * xselect.c: Include <limits.h>.
6013 (x_own_selection, selection_data_to_lisp_data):
6014 Use INTEGER_TO_CONS.
6015 (x_handle_selection_request, x_handle_selection_clear)
6016 (x_get_foreign_selection, Fx_disown_selection_internal)
6017 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6018 (lisp_data_to_selection_data): Use cons_to_unsigned.
6019 (x_fill_property_data): Use cons_to_signed.
6020 Report values out of range.
6021
d1f3d2af
PE
6022 Check for buffer and string overflow more precisely.
6023 * buffer.h (BUF_BYTES_MAX): New macro.
6024 * lisp.h (STRING_BYTES_MAX): New macro.
6025 * alloc.c (Fmake_string):
6026 * character.c (string_escape_byte8):
6027 * coding.c (coding_alloc_by_realloc):
6028 * doprnt.c (doprnt):
6029 * editfns.c (Fformat):
6030 * eval.c (verror):
6031 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6032 since they may not be the same number.
6033 * editfns.c (Finsert_char):
6034 * fileio.c (Finsert_file_contents):
6035 Likewise for BUF_BYTES_MAX.
6036
dd52fcea
PE
6037 * image.c: Use ptrdiff_t, not int, for sizes.
6038 (slurp_file): Switch from int to ptrdiff_t.
6039 All uses changed.
6040 (slurp_file): Check that file size fits in both size_t (for
6041 malloc) and ptrdiff_t (for sanity and safety).
6042
7f9bbdbb
PE
6043 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6044 if b->modtime has its maximal value.
6045
dfe18f82
PE
6046 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6047
84acfcf0
PE
6048 Don't assume time_t can fit into int.
6049 * buffer.h (struct buffer.modtime): Now time_t, not int.
6050 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6051 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6052
ccd9a01a
PE
6053 Minor fixes for signed vs unsigned integers.
6054 * character.h (MAYBE_UNIFY_CHAR):
6055 * charset.c (maybe_unify_char):
6056 * keyboard.c (read_char, reorder_modifiers):
6057 XINT -> XFASTINT, since the integer must be nonnegative.
6058 * ftfont.c (ftfont_spec_pattern):
6059 * keymap.c (access_keymap, silly_event_symbol_error):
6060 XUINT -> XFASTINT, since the integer must be nonnegative.
6061 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6062 since it makes no difference and we prefer signed.
6063 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6064 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6065 nonnegative.
6066
d6d100dd
SM
60672011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6068
6069 * window.h (Fwindow_frame): Declare.
6070
2b6148e4
PE
60712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6072
6073 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6074 (SPARE_MEMORY): Always define.
6075 (LARGE_REQUEST): Remove.
6076 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6077
f230ecc9
MR
60782011-06-06 Martin Rudalics <rudalics@gmx.at>
6079
727e958e
MR
6080 * lisp.h: Move EXFUNS for Fframe_root_window,
6081 Fframe_first_window and Fset_frame_selected_window to window.h.
6082
6083 * window.h: Move EXFUNS for Fframe_root_window,
6084 Fframe_first_window and Fset_frame_selected_window here from
6085 lisp.h.
6086
6087 * frame.c (Fwindow_frame, Fframe_first_window)
6088 (Fframe_root_window, Fframe_selected_window)
6089 (Fset_frame_selected_window): Move to window.c.
6090 (Factive_minibuffer_window): Move to minibuf.c.
6091 (Fother_visible_frames_p): New function.
6092
6093 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6094
f230ecc9
MR
6095 * window.c (decode_window, decode_any_window): Move up in code.
6096 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6097 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6098 (Fwindow_buffer): Move up and rewrite doc-string.
6099 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6100 (Fwindow_prev): New functions.
727e958e
MR
6101 (Fwindow_frame): Move here from frame.c. Accept any window as
6102 argument.
6103 (Fframe_root_window, Fframe_first_window)
6104 (Fframe_selected_window): Move here from frame.c. Accept frame
6105 or arbitrary window as argument. Update doc-strings.
6106 (Fminibuffer_window): Move up in code.
6107 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6108 (Fset_frame_selected_window): Move here from frame.c.
6109 Marginal rewrite.
727e958e
MR
6110 (Fselected_window, select_window, Fselect_window): Move up in
6111 code. Minor doc-string fixes.
f230ecc9 6112
4d09bcf6
PE
61132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6114
6115 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6116 Do not assume that spare memory exists; that assumption is valid
6117 only if SYSTEM_MALLOC.
6118 (LARGE_REQUEST): New macro, so that the issue of large requests
6119 is separated from the issue of spare memory.
6120
810928a2
AS
61212011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6122
172418ad
AS
6123 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6124 format. (Bug#8806)
6125
43f862f7
AS
6126 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6127
810928a2
AS
6128 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6129 before statements.
6130
a059fe24
JD
61312011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6132
6133 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6134
6135 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6136
6137 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6138 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6139
989bf368
JB
61402011-06-05 Juanma Barranquero <lekktu@gmail.com>
6141
6142 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6143
4b80f674
CY
61442011-06-04 Chong Yidong <cyd@stupidchicken.com>
6145
6146 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6147 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6148 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6149 New error handlers.
4b80f674
CY
6150 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6151 Obey Vx_select_enable_clipboard_manager. Catch errors in
6152 x_clipboard_manager_save (Bug#8779).
6153 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6154 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6155
99a33b77 61562011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6157
6158 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6159
99a33b77 61602011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6161
6162 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6163 in the current matrix if keep_current_p is non-zero.
6164
8264569d
EZ
61652011-06-04 Eli Zaretskii <eliz@gnu.org>
6166
6167 * bidi.c (bidi_level_of_next_char): Fix last change.
6168
57f97249
EZ
61692011-06-03 Eli Zaretskii <eliz@gnu.org>
6170
fec2107c 6171 Support bidi reordering of text covered by display properties.
57f97249 6172
fec2107c
EZ
6173 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6174 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6175 (bidi_cache_search, bidi_cache_iterator_state)
6176 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6177 (bidi_level_of_next_char, bidi_move_to_visually_next):
6178 Support character positions inside a run of characters covered by a
fec2107c
EZ
6179 display string.
6180 (bidi_paragraph_init, bidi_resolve_explicit_1)
6181 (bidi_level_of_next_char): Call bidi_fetch_char and
6182 bidi_fetch_char_advance instead of FETCH_CHAR and
6183 FETCH_CHAR_ADVANCE.
6184 (bidi_init_it): Initialize new members.
6185 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6186 definitions.
6187 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6188 instead of using explicit *_CHAR codes.
d6d100dd
SM
6189 (bidi_resolve_explicit, bidi_resolve_weak):
6190 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6191 bidirectional text is supported only in multibyte buffers.
6192 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6193 it to initialize the frame_window_p member of struct bidi_it.
6194 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6195 (bidi_resolve_explicit, bidi_resolve_weak)
6196 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6197 bidi_it->nchars is non-positive.
6198 (bidi_level_of_next_char): Don't try to lookup the cache for the
6199 next/previous character if nothing is cached there yet, or if we
6200 were just reseat()'ed to a new position.
c40e2fb2 6201
0e14fe90
EZ
6202 * xdisp.c (set_cursor_from_row): Set start and stop points
6203 according to the row's direction when priming the loop that looks
6204 for the glyph on which to display cursor.
6205 (single_display_spec_intangible_p): Function deleted.
6206 (display_prop_intangible_p): Reimplement to call
6207 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6208 Accept 3 additional arguments needed by handle_display_spec.
6209 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6210 values: lists, `(when COND...)' forms, etc.
6211 (single_display_spec_string_p): Support property values that are
6212 lists with the argument STRING its top-level element.
6213 (display_prop_string_p): Fix the condition for processing a
6214 property that is a list to be consistent with handle_display_spec.
fec2107c 6215 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6216 last portion of handle_display_prop.
6217 (compute_display_string_pos): Accept additional argument
6218 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6219 value of a `display' property is a "replacing spec".
6220 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6221 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6222 the display property, but just return a value indicating whether
6223 the display property will replace the characters it covers.
6224 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6225 frame_window_p members of struct bidi_it.
d6d100dd
SM
6226 (compute_display_string_pos, compute_display_string_end):
6227 New functions.
fec2107c
EZ
6228 (push_it): Accept second argument POSITION, where pop_it should
6229 jump to continue iteration.
6230 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6231
fec2107c
EZ
6232 * keyboard.c (adjust_point_for_property): Adjust the call to
6233 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6234
6235 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6236 (bidi_init_it): Update prototypes.
6237 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6238 (compute_display_string_pos, compute_display_string_end):
6239 Declare prototypes.
fec2107c
EZ
6240 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6241 EMACS_INT.
fc6f18ce 6242
40087514 62432011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6244
57f53182
PE
6245 Malloc failure behavior now depends on size of allocation.
6246 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6247 * lisp.h: Change signatures accordingly.
6248 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6249 All callers changed. (Bug#8762)
6250
6251 * gnutls.c: Use Emacs's memory allocators.
6252 Without this change, the gnutls library would invoke malloc etc.
6253 directly, which causes problems on non-SYNC_INPUT hosts, and which
6254 runs afoul of improving memory_full behavior. (Bug#8761)
6255 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6256 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6257 xfree instead of the default malloc, realloc, free.
6258 (Fgnutls_boot): No need to check for memory allocation failure,
6259 since xmalloc does that for us.
6260
ac32cd99 6261 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6262 * category.c (hash_get_category_set):
6263 * ccl.c (ccl_driver):
6264 * charset.c (Fdefine_charset_internal):
6265 * charset.h (struct charset.hash_index):
6266 * composite.c (get_composition_id, gstring_lookup_cache)
6267 (composition_gstring_put_cache):
6268 * composite.h (struct composition.hash_index):
6269 * dispextern.h (struct image.hash):
6270 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6271 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6272 (hashfn_equal, hashfn_user_defined, make_hash_table)
6273 (maybe_resize_hash_table, hash_lookup, hash_put)
6274 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6275 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6276 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6277 * image.c (make_image, search_image_cache, lookup_image)
6278 (xpm_put_color_table_h):
6279 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6280 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6281 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6282 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6283 * alloc.c (allocate_vectorlike):
6284 Check for overflow in vector size calculations.
6285 * ccl.c (ccl_driver):
6286 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6287 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6288 need to be updated by these changes.
40087514
PE
6289 * fns.c (make_hash_table, maybe_resize_hash_table):
6290 Check for integer overflow with large hash tables.
0de4bb68
PE
6291 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6292 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6293 (SXHASH_REDUCE): New macro.
6294 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6295 Use it instead of discarding useful hash info with large hash values.
6296 (sxhash_float): New function.
6297 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6298 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6299 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6300 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6301 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6302 Adjust signatures to match updated version of code.
6303 (consing_since_gc): Now EMACS_INT, since a single hash table can
6304 use more than INT_MAX bytes.
6305
698d32e2
DN
63062011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6307
6308 Make it possible to build with GCC-4.6+ -O2 -flto.
6309
6310 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6311
fd6fa53f
SM
63122011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6313
6314 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6315 Call minibuffer-inactive-mode.
6316
864db017
JB
63172011-05-31 Juanma Barranquero <lekktu@gmail.com>
6318
6319 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6320 Update dependencies.
6321
2ad0baf4
DN
63222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6323
6324 * data.c (init_data): Remove code for UTS, this system is not
6325 supported anymore.
6326
4fcc2638
DN
63272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6328
6329 Don't force ./temacs to start in terminal mode.
6330
6331 * frame.c (make_initial_frame): Initialize faces in all cases, not
6332 only when CANNOT_DUMP is defined.
6333 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6334
c56e0fd5
DN
63352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6336
6337 * dispnew.c (add_window_display_history): Use const for the string
6338 pointer. Remove declaration, not needed.
6339
333d54da 63402011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6341
55d4c1b2 6342 Use 'inline', not 'INLINE'.
333d54da 6343 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6344 * alloc.c, fontset.c (INLINE): Remove.
6345 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6346 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6347 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6348 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6349 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6350
738db178
DN
63512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6352
6353 Make it possible to run ./temacs.
6354
6355 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6356 syms_of_callproc does the same thing. Remove test for
6357 "initialized", do it in the caller.
6358 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6359
620c53a6
SM
63602011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6361
6362 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6363 (read_minibuf): Use get_minibuffer.
6364 (syms_of_minibuf): Use DEFSYM.
6365 (Qmetadata): New var.
6366 * data.c (Qbuffer): Don't make it static.
6367 (syms_of_data): Use DEFSYM.
6368
e003a292
PE
63692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6370
6371 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6372 (CCL_CODE_MIN): New macro.
6373
ed008a6d
PE
63742011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6375
3687c2ef
PE
6376 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6377
ed008a6d
PE
6378 * eval.c (Qdebug): Now static.
6379 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6380 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6381 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6382
d66c4c7c
CY
63832011-05-29 Chong Yidong <cyd@stupidchicken.com>
6384
6385 * image.c: Various fixes to ImageMagick code comments.
6386 (Fimagemagick_types): Doc fix.
6387
5fbc2025
PE
63882011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6389
0196f88a
PE
6390 Minor fixes prompted by GCC 4.6.0 warnings.
6391
6392 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6393
5fbc2025
PE
6394 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6395 (x_clipboard_manager_save_all): Move extern decl to ...
6396 * xterm.h: ... here, so that it can be checked for consistency.
6397
1dd3c2d9
CY
63982011-05-29 Chong Yidong <cyd@stupidchicken.com>
6399
6400 * xselect.c (x_clipboard_manager_save_frame)
6401 (x_clipboard_manager_save_all): New functions.
6402 (Fx_clipboard_manager_save): Lisp function deleted.
6403
6404 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6405 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6406
6407 * xterm.h: Update prototype.
6408
5ba6571d
WX
64092011-05-28 William Xu <william.xwl@gmail.com>
6410
6411 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6412 exiting (Bug#8239).
6413
3eaff834
JM
64142011-05-28 Jim Meyering <meyering@redhat.com>
6415
e1900994 6416 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6417 * fns.c (to_uchar): Define.
6418 (crypto_hash_function): Use it to convert some newly-signed
6419 variables to unsigned, to avoid sign-extension bugs. For example,
6420 without this change, (md5 "truc") would evaluate to
6421 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6422 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6423 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6424
0f6990a7
PE
64252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6426
6427 Integer overflow fixes.
c8a9ca5a 6428
08686060
PE
6429 * dbusbind.c: Serial number integer overflow fixes.
6430 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6431 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6432 to hold a serial number that is too large for a fixnum.
6433 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6434 Check for serial numbers out of range. Decode any serial number
59568bf0 6435 that was so large that it became a float. (Bug#8722)
08686060 6436
2d1fc3c7
PE
6437 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6438 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6439 Use XFASTINT rather than XUINT when numbers are nonnegative.
6440 (xd_append_arg, Fdbus_method_return_internal):
6441 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6442 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6443 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6444 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6445 (Bug#8722)
2d1fc3c7 6446
c8a9ca5a
PE
6447 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6448
519e1d69
PE
6449 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6450
6df6ae42 6451 ccl: Add integer overflow checks.
30569699
PE
6452 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6453 (IN_INT_RANGE): New macros.
6454 (ccl_driver): Use them to check for integer overflow when
6455 decoding a CCL program. Many of the new checks are whether XINT (x)
6456 fits in int; it doesn't always, on 64-bit hosts. The new version
6457 doesn't catch all possible integer overflows, but it's an
847044ea 6458 improvement. (Bug#8719)
30569699 6459
c11285dc
PE
6460 * alloc.c (make_event_array): Use XINT, not XUINT.
6461 There's no need for unsigned here.
6462
fdccd48e
PE
6463 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6464 This follows up to the 2011-05-06 change that substituted uintptr_t
6465 for EMACS_INT. This case wasn't caught back then.
6466
37910ab2
PE
6467 Rework Fformat to avoid integer overflow issues.
6468 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6469 now (part of C89). Include <verify.h>.
6470 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6471 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6472 (Fformat): Avoid the prepass trying to compute sizes; it was only
6473 approximate and thus did not catch overflow reliably. Instead, walk
6474 through the format just once, formatting and computing sizes as we go,
6475 checking for integer overflow at every step, and allocating a larger
6476 buffer as needed. Keep track separately whether the format is
6477 multibyte. Keep only the most-recently calculated precision, rather
6478 than them all. Record whether each argument has been converted to
6479 string. Use EMACS_INT, not int, for byte and char and arg counts.
6480 Support field widths and precisions larger than INT_MAX. Avoid
6481 sprintf's undefined behavior with conversion specifications such as %#d
6482 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6483 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6484 formatting out-of-range floating point numbers with int
9173deec 6485 formats. (Bug#8668)
37910ab2 6486
2e6578fb
PE
6487 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6488
0ae6bdee
PE
6489 * data.c: Avoid integer truncation in expressions involving floats.
6490 * data.c: Include <intprops.h>.
6491 (arith_driver): When there's an integer overflow in an expression
6492 involving floating point, convert the integers to floating point
6493 so that the resulting value does not suffer from catastrophic
6494 integer truncation. For example, on a 64-bit host (* 4
6495 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6496 Do not rely on undefined behavior after integer overflow.
6497
de883a70
PE
6498 merge count_size_as_multibyte, parse_str_to_multibyte
6499 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6500 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6501 Check for integer overflow.
6502 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6503 since it's now a duplicate of the other. This is more of
6504 a character than a buffer op, so better that it's in character.c.
6505 * fns.c, print.c: Adjust to above changes.
6506
2ff916cb
PE
65072011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6508
6509 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6510
f1b54466
PE
65112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6512
fb1ac845
PE
6513 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6514 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6515 (x_clipboard_manager_save): Now static.
6516 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6517
f1b54466
PE
6518 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6519 (crypto_hash_function): Now static.
6520 Fix pointer signedness problems. Avoid unnecessary initializations.
6521
a9f737ee
CY
65222011-05-27 Chong Yidong <cyd@stupidchicken.com>
6523
6524 * termhooks.h (Vselection_alist): Make it terminal-local.
6525
6526 * terminal.c (create_terminal): Initialize it.
6527
6528 * xselect.c: Support for clipboard managers.
6529 (Vselection_alist): Move to termhooks.h as terminal-local var.
6530 (LOCAL_SELECTION): New macro.
6531 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6532 (symbol_to_x_atom): Remove gratuitous arg.
6533 (x_handle_selection_request, lisp_data_to_selection_data)
6534 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6535 (x_own_selection, x_get_local_selection, x_convert_selection):
6536 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6537 (some_frame_on_display): Delete unused function.
6538 (Fx_own_selection_internal, Fx_get_selection_internal)
6539 (Fx_disown_selection_internal, Fx_selection_owner_p)
6540 (Fx_selection_exists_p): New optional frame arg.
6541 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6542 (x_handle_selection_clear): Don't treat other terminals with the
6543 same keyboard specially. Use the terminal-local Vselection_alist.
6544 (x_clear_frame_selections): Use Frun_hook_with_args.
6545
6546 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6547
6548 * xterm.h: Add support for those atoms.
6549
e067f0c1
CY
65502011-05-26 Chong Yidong <cyd@stupidchicken.com>
6551
6552 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6553 (converted_selections, conversion_fail_tag): New global variables.
6554 (x_selection_request_lisp_error): Free the above.
6555 (x_get_local_selection): Remove unnecessary code.
6556 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6557 of converted selections stored in converted_selections.
6558 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6559 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6560 (x_convert_selection): New function.
6561 (x_handle_selection_event): Simplify.
6562 (x_get_foreign_selection): Don't ignore incoming requests while
6563 waiting for an answer; this will fail when we implement
6564 SAVE_TARGETS, and seems unnecessary anyway.
6565 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6566 (Vx_sent_selection_functions): Doc fix.
6567
0f4aebc0
LL
65682011-05-26 Leo Liu <sdl.web@gmail.com>
6569
6570 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6571
e61124cd
YM
65722011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6573
6574 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6575
6576 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6577 for fringe update if it has periodic bitmap.
ac389d0c 6578 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6579 and fringe_bitmap_periodic_p.
6580
6581 * fringe.c (get_fringe_bitmap_data): New function.
6582 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6583 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6584 row. Mark glyph row for fringe update if periodicity changed.
6585
6586 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6587 for fringe update unless it has periodic bitmap.
6588
f16d9837
KH
65892011-05-25 Kenichi Handa <handa@m17n.org>
6590
6591 * xdisp.c (get_next_display_element): Set correct it->face_id for
6592 a static composition.
6593
e1b90ef6
LL
65942011-05-24 Leo Liu <sdl.web@gmail.com>
6595
6596 * deps.mk (fns.o):
6597 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6598
6599 * fns.c (crypto_hash_function, Fsha1): New function.
6600 (Fmd5): Use crypto_hash_function.
6601 (syms_of_fns): Add Ssha1.
6602
7400048f
PE
66032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6604
6605 * gnutls.c: Remove unused macros.
6606 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6607 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6608 Remove macros that are defined and never used.
6609 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6610
abb71cf4
CY
66112011-05-22 Chong Yidong <cyd@stupidchicken.com>
6612
6613 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6614 (Fx_get_selection_internal): Minor cleanup.
6615 (Fx_own_selection_internal): Rename arguments for consistency with
6616 select.el.
6617
6307db39
PE
66182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6619
6620 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6621
f3d4e0a4
CY
66222011-05-22 Chong Yidong <cyd@stupidchicken.com>
6623
6624 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6625
4d8ade89
YM
66262011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6627
6628 * dispnew.c (scrolling_window): Don't exclude the case that the
6629 last enabled row in the desired matrix touches the bottom boundary.
6630
32078c8d
GM
66312011-05-21 Glenn Morris <rgm@gnu.org>
6632
6633 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6634 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6635 and add some more files.
32078c8d 6636
7285dc67
EZ
66372011-05-20 Eli Zaretskii <eliz@gnu.org>
6638
6639 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6640 report_file_error introduced by the change from 2011-05-07.
6641
89d1bd22
PE
66422011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6643
6644 * systime.h (Time): Define only if emacs is defined.
6645 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6646 where the include path doesn't have X11/X.h by default. See
6647 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6648
cd394be1 66492011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6650
6651 * composite.c (find_automatic_composition): Fix previous change.
6652
b9704ad9
GM
66532011-05-20 Glenn Morris <rgm@gnu.org>
6654
6655 * lisp.mk: New file, split from Makefile.in.
6656 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6657 (shortlisp): Remove.
6658 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6659
4a720484
GM
66602011-05-19 Glenn Morris <rgm@gnu.org>
6661
6662 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6663 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6664 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6665 (lisp): Set the order to that of loadup.el.
6666 (shortlisp): Make it a copy of $lisp.
6667 (SOME_MACHINE_LISP): Remove.
6668 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6669 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6670
a28d4396
KH
66712011-05-18 Kenichi Handa <handa@m17n.org>
6672
6673 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6674 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6675 (find_automatic_composition): Mostly rewrite for efficiency.
6676
a2b1fa8e
JB
66772011-05-18 Juanma Barranquero <lekktu@gmail.com>
6678
6679 * makefile.w32-in: Update dependencies.
6680
8e1f5610
CS
66812011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6682
6683 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6684 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6685
7025ee00 66862011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6687
cdfa6eab
PE
6688 Fix some integer overflow issues, such as string length overflow.
6689
06d6db33
PE
6690 * insdel.c (count_size_as_multibyte): Check for string overflow.
6691
2b4560a8
PE
6692 * character.c (lisp_string_width): Check for string overflow.
6693 Use EMACS_INT, not int, for string indexes and lengths; in
6694 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6695 the resulting string length overflows an EMACS_INT; instead,
6696 report a string overflow if no precision given. When checking for
6697 precision exhaustion, use a check that cannot possibly have
6698 integer overflow. (Bug#8675)
6699 * character.h (lisp_string_width): Adjust to new signature.
6700
cb93f9be
PE
6701 * alloc.c (string_overflow): New function.
6702 (Fmake_string): Use it. This doesn't change behavior, but saves
6703 a few bytes and will simplify future changes.
6704 * character.c (string_escape_byte8): Likewise.
6705 * lisp.h (string_overflow): New decl.
6706
1a1f3366
PE
6707 Fixups, following up to the user-interface timestamp change.
6708 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6709 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6710 * msdos.c (mouse_get_pos): Likewise.
6711 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6712 * w32gui.h (Time): Define by including "systime.h" rather than by
6713 declaring it ourselves. (Bug#8664)
6714
d4e3e4d3
PE
6715 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6716 * image.c (clear_image_cache): Likewise.
6717
f6a24d19
PE
6718 * term.c (term_mouse_position): Don't assume time_t wraparound.
6719
08dc5ae6
PE
6720 Be more systematic about user-interface timestamps.
6721 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6722 and sometimes 'EMACS_UINT', to represent these timestamps.
6723 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6724 This makes the code easier to follow, and makes it easier to catch
6725 integer overflow bugs such as Bug#8664.
6726 * frame.c (Fmouse_position, Fmouse_pixel_position):
6727 Use Time, not unsigned long, for user-interface timestamps.
6728 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6729 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6730 * keyboard.h (last_event_timestamp): Likewise.
6731 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6732 * menu.h (xmenu_show): Likewise.
6733 * term.c (term_mouse_position): Likewise.
6734 * termhooks.h (struct input_event.timestamp): Likewise.
6735 (struct terminal.mouse_position_hook): Likewise.
6736 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6737 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6738 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6739 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6740 what it was before.
6741 * menu.h, termhooks.h: Include "systime.h", for Time.
6742
8e55734a
PE
6743 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6744 Don't assume that the difference between two unsigned long values
6745 can fit into an integer. At this point, we know button_down_time
6746 <= event->timestamp, so the difference must be nonnegative, so
6747 there's no need to cast the result if double-click-time is
6748 nonnegative, as it should be; check that it's nonnegative, just in
6749 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6750 apart (about 25 days). (Bug#8664)
8e55734a 6751
841f1b75 6752 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6753 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6754
3e26f69c
PE
6755 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6756 that always fit in int. Use a sentinel instead of a counter, to
6757 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6758 * frame.h (struct frame): Use int for menu_bar_items_used
6759 instead of EMACS_INT, since it always fits in int.
3e26f69c 6760
5cc152c0
PE
6761 * menu.c (grow_menu_items): Check for int overflow.
6762
d89eb65e
PE
6763 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6764
5235bd3e
PE
6765 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6766 Before, the code was not consistent. These values cannot exceed
6767 2**31 - 1 so there's no need to make them unsigned.
6768 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6769 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6770 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6771 as modifiers.
6772 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6773
bc827e23
PE
6774 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6775 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6776 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6777 presumably because the widths might not match.
6778
78eb494e
PE
6779 * window.c (size_window): Avoid needless test at loop start.
6780
04f2d78b
CB
67812011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6782
6783 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6784
d2fc7e3d 67852011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6786
6787 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6788
d2fc7e3d 67892011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6790
6791 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6792 `width' to `bar_area_x' and `bar_area_width', respectively.
6793 (x_scroll_run): Take account of fringe background extension.
6794
04f2d78b
CB
6795 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6796 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6797 `bar_area_width', respectively.
6798 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6799 background extension.
6800
79b70037
GM
68012011-05-10 Jim Meyering <meyering@redhat.com>
6802
6803 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6804
2f142cc5
JB
68052011-05-10 Juanma Barranquero <lekktu@gmail.com>
6806
6807 * image.c (Finit_image_library): Return t for built-in image types,
6808 like pbm and xbm. (Bug#8640)
6809
57679c86
AS
68102011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6811
6812 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6813
888c9e86
EZ
68142011-05-07 Eli Zaretskii <eliz@gnu.org>
6815
b0512a1d
EZ
6816 * w32console.c (Fset_screen_color): Doc fix.
6817 (Fget_screen_color): New function.
6818 (syms_of_ntterm): Defsubr it.
6819
7285dc67
EZ
6820 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6821 unlink the temporary file if Fcall_process didn't create it in the
6822 first place.
6823 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6824 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6825 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6826 cue to call_process_cleanup not to close that handle.
6827
4d3fcc8e
BK
68282011-05-07 Ben Key <bkey76@gmail.com>
6829
6830 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6831 one of two shell specific rules, either bootstrap-temacs-CMD or
6832 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6833 to the previous implementation of the bootstrap-temacs rule.
6834 The bootstrap-temacs-CMD rule is similar to the previous
6835 implementation of the bootstrap-temacs rule except that it
6836 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6837 variable.
6838
6839 These changes, along with some changes to nt/configure.bat,
6840 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6841 earlier fix to add support for --cflags and --ldflags options
6842 that include quotes so that it works whether make uses cmd or
6843 sh as the shell.
6844
b4289b64
MA
68452011-05-06 Michael Albinus <michael.albinus@gmx.de>
6846
6847 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6848 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6849 is a constant.
6850 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6851 a string. Handle both cases.
6852 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6853 (Fdbus_register_method): Use Qinvalid_function.
6854
af4c0e28
JB
68552011-05-06 Juanma Barranquero <lekktu@gmail.com>
6856
6857 * makefile.w32-in: Update dependencies.
6858 (LISP_H): Add inttypes.h and stdin.h.
6859 (PROCESS_H): Add unistd.h.
6860
c51453d9
EZ
68612011-05-06 Eli Zaretskii <eliz@gnu.org>
6862
6863 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6864 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6865
8ff0ac3c 68662011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6867
4c4b566b
PE
6868 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6869
aab2b9b5
PE
6870 * term.c (vfatal): Remove stray call to va_end.
6871 It's not needed and the C Standard doesn't allow it here anyway.
6872
c378da0b
PE
6873 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6874 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6875
288b08c7
PE
6876 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6877 bytes.
6878
e3601888
PE
6879 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6880
db6c0e74
PE
6881 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6882
dd5963ea
PE
6883 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6884
88c9450f
PE
6885 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6886
2f9442b8
PE
6887 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6888
c032b5f8
PE
6889 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6890 * charset.c (Fdefine_charset_internal): Don't initialize
6891 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6892 32-bit int (Bug#8600).
a108c10b
PE
6893
6894 * lread.c (read_integer): Be more consistent with string-to-number.
6895 Use string_to_number to do the actual conversion; this avoids
6896 rounding errors and fixes some other screwups. Without this fix,
6897 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6898 (digit_to_number): Move earlier, for benefit of read_integer.
6899 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6900 not a digit in any supported base. (Bug#8602)
a108c10b 6901
ad5f9eea
PE
6902 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6903
aec1708a
PE
6904 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6905 to match comment at start of function. This also removes a
6906 GCC warning about overflow in a 32+64-bit port.
6907
47be4ab5
PE
6908 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6909
371cac43
PE
6910 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6911 Reported by Stefan Monnier in
6912 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6913 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6914 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6915
d01a7826
PE
6916 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6917 (EMACS_UINTPTR): Likewise, with uintptr_t.
6918
7fd47d5c
PE
6919 * lisp.h: Prefer 64-bit EMACS_INT if available.
6920 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6921 on 32-bit hosts that have 64-bit int, so that they can access
6922 large files.
122b0c86
PE
6923 However, temporarily disable this change unless the temporary
6924 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6925
8727937b
PE
6926 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6927
8ac068ac
PE
6928 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6929 This removes an assumption that EMACS_INT and long are the same
6930 width as pointers. The assumption is true for Emacs porting targets
6931 now, but we want to make other targets possible.
6932 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6933 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6934 In the rest of the code, change types of integers that hold casted
6935 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6936 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6937 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6938 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6939 No need to cast type when ORing.
6940 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6941 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6942 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6943 assume EMACS_INT is the same width as char *.
6944 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6945 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6946 Remove no-longer-needed casts.
6947 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6948 (xg_tool_bar_help_callback, xg_make_tool_item):
6949 Use EMACS_INTPTR to hold an integer
6950 that will be cast to void *; this can avoid a GCC warning
6951 if EMACS_INT is not the same width as void *.
6952 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6953 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6954 (current_message_1, set_message_1):
6955 Use a local to convert to proper width without a cast.
6956 * xmenu.c (dialog_selection_callback): Likewise.
6957
ede49d71
PE
6958 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6959 Also, don't assume VALBITS / RAND_BITS is less than 5,
6960 and don't rely on undefined behavior when shifting a 1 left into
6961 the sign bit.
6962 * lisp.h (get_random): Change signature to match.
6963
2f30ecd0
PE
6964 * lread.c (hash_string): Use size_t, not int, for hash computation.
6965 Normally we prefer signed values; but hashing is special, because
6966 it's better to use unsigned division on hash table sizes so that
6967 the remainder is nonnegative. Also, size_t is the natural width
6968 for hashing into memory. The previous code used 'int', which doesn't
6969 retain enough info to hash well into very large tables.
6970 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6971
2a866e7b
PE
6972 * dbusbind.c: Don't possibly lose pointer info when converting.
6973 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6974 Use XPNTR rather than XHASH, so that the high-order bits of
6975 the pointer aren't lost when converting through void *.
6976
51639eac
PE
6977 * eval.c (Fautoload): Don't double-shift a pointer.
6978
92394119
PE
6979 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6980
dbdb9a7c
JB
69812011-05-06 Juanma Barranquero <lekktu@gmail.com>
6982
6983 * gnutls.c (DEF_GNUTLS_FN):
6984 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6985
db7a0b4f
AS
69862011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6987
6988 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6989 marker. (Bug#8610)
6990
cd394be1 69912011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6992
6993 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6994 New version that can reserve upto 2GB of heap space.
6995
f7ff1b0f 69962011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6997
6998 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6999
639c109b
TZ
70002011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7001
7002 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7003 `gnutls_certificate_set_x509_key_file'.
7004
d2127135
JB
70052011-05-05 Juanma Barranquero <lekktu@gmail.com>
7006
7007 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7008 Update dependencies.
7009
e968f4f3
JB
70102011-05-04 Juanma Barranquero <lekktu@gmail.com>
7011
7012 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7013 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7014 Remove unused parameter `fildes'.
7015 * process.c (read_process_output, send_process): Don't pass it.
7016
84d358f0
JB
70172011-05-04 Juanma Barranquero <lekktu@gmail.com>
7018
7019 Fix previous change: the library cache is defined in w32.c.
7020 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7021 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7022
0898ca10
JB
70232011-05-04 Juanma Barranquero <lekktu@gmail.com>
7024
7025 Implement dynamic loading of GnuTLS on Windows.
7026
7027 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7028 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7029 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7030 Declare.
7031
7032 * gnutls.c (Qgnutls_dll): Define.
7033 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7034 (gnutls_*): Declare function pointers.
7035 (init_gnutls_functions): New function to initialize function pointers.
7036 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7037 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7038 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7039 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7040 (emacs_gnutls_write, emacs_gnutls_read)
7041 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7042 (Fgnutls_available_p): New function.
7043 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7044 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7045 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7046
7047 * image.c: Include w32.h.
7048 (Vimage_type_cache): Delete.
7049 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7050 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7051 (w32_delayed_load): Move to w32.c.
7052
7053 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7054
7055 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7056 (w32_delayed_load): Move from image.c. When loading a library, record
7057 its filename in the :loaded-from property of the library id.
7058 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7059 Initialize and staticpro them.
7060 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7061
7062 * process.c: Include lisp.h before w32.h, not after.
7063 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7064 instead of gnutls_record_check_pending.
7065
7066 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7067
ff4de4aa
TZ
70682011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7069
7070 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7071 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7072 as passed in.
7073
abe95abb
JD
70742011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7075
7076 * xterm.c (x_set_frame_alpha): Do not set property on anything
7077 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7078
e16e55d4
JB
70792011-05-02 Juanma Barranquero <lekktu@gmail.com>
7080
7081 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7082
bafcf6a5
JB
70832011-05-02 Juanma Barranquero <lekktu@gmail.com>
7084
7085 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7086 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7087 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7088 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7089 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7090 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7091 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7092 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7093 (Qgnutls_bootprop_callbacks_verify): Make static.
7094
e7a6747f
AS
70952011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7096
19ed11ba
AS
7097 * callproc.c: Indentation fixup.
7098
e7a6747f 7099 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7100 (wait_for_termination, interruptible_wait_for_termination):
7101 Move after wait_for_termination_1.
e7a6747f 7102
1ef14cb4
LMI
71032011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7104
7105 * sysdep.c (interruptible_wait_for_termination): New function
7106 which is like wait_for_termination, but allows keyboard
7107 interruptions.
7108
7109 * callproc.c (Fcall_process): Add (:file "file") as an option for
7110 the STDOUT buffer.
7111 (Fcall_process_region): Ditto.
7112
330d880c
EZ
71132011-04-30 Eli Zaretskii <eliz@gnu.org>
7114
8db90b73
EZ
7115 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7116 rather than `XVECTOR (FOO)->size'.
7117
330d880c
EZ
7118 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7119 inttypes.h, as a gnulib replacement is used if it not available in
7120 system headers.
7121
15cbd324
EZ
71222011-04-21 Eli Zaretskii <eliz@gnu.org>
7123
7124 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7125 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7126 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7127
7128 * coding.c (coding_alloc_by_realloc): Error out if destination
7129 will grow beyond MOST_POSITIVE_FIXNUM.
7130 (decode_coding_emacs_mule): Abort if there isn't enough place in
7131 charbuf for the composition carryover bytes. Reserve an extra
7132 space for up to 2 characters produced in a loop.
7133 (decode_coding_iso_2022): Abort if there isn't enough place in
7134 charbuf for the composition carryover bytes.
7135
71362011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7137
ae940cca
EZ
7138 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7139 aborting when %lld or %lll format is passed.
7140 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7141 %llo or %llx format is passed. (Bug#8545)
7142
03ab8921
EZ
7143 * window.c (window_scroll_line_based): Use a marker instead of
7144 simple variables to record original value of point. (Bug#7952)
7145
afda1437
EZ
7146 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7147 produced by %s or %c overflows available buffer space. (Bug#8545)
7148
f76dee0c
PE
71492011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7150
7151 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7152 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7153
fdc5744d
JB
71542011-04-28 Juanma Barranquero <lekktu@gmail.com>
7155
7156 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7157
638f053a
JB
71582011-04-28 Juanma Barranquero <lekktu@gmail.com>
7159
7160 * keyboard.c (Qdelayed_warnings_hook): Define.
7161 (command_loop_1): Run `delayed-warnings-hook'
7162 if Vdelayed_warnings_list is non-nil.
7163 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7164 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7165
d178f871
EZ
71662011-04-28 Eli Zaretskii <eliz@gnu.org>
7167
7168 * doprnt.c (doprnt): Don't return value smaller than the buffer
7169 size if the message was truncated. (Bug#8545).
7170
b124fd93
JB
71712011-04-28 Juanma Barranquero <lekktu@gmail.com>
7172
7173 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7174 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7175
e810457d
PE
71762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7177
7178 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7179
ea51cceb
JB
71802011-04-27 Juanma Barranquero <lekktu@gmail.com>
7181
7182 * makefile.w32-in: Update dependencies.
7183
94dcfacf
EZ
71842011-04-27 Eli Zaretskii <eliz@gnu.org>
7185
7186 Improve `doprnt' and its usage. (Bug#8545)
7187 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7188 `format_end'. Remove support for %l as a conversion specifier.
7189 Don't use xrealloc. Improve diagnostics when the %l size modifier
7190 is used. Update the commentary.
7191
7192 * eval.c (verror): Simplify calculation of size_t.
7193
7194 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7195 messages.
7196
f61f41d7
PE
71972011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7198
7199 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7200 change.
7201
96fb4434
PE
72022011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7203
7204 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7205 This makes this file independent of the recent pseudovector change.
7206
671875da 72072011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7208
69e9b5a3
PE
7209 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7210
b5f869a7 7211 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7212 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7213 Remove unused local.
c8926152 7214 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7215
841a1577 7216 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7217 GCC 4.6.0 optimizes based on type-based alias analysis.
7218 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7219 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7220 != &v->size, and therefore "v->size = 1; b->size = 2; return
7221 v->size;" must therefore return 1. This assumption is incorrect
7222 for Emacs, since it type-puns struct Lisp_Vector * with many other
7223 types. To fix this problem, this patch adds a new type struct
f904488f 7224 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7225 and pseudovectors, and helps optimizing compilers not get fooled
7226 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7227 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7228 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7229 the size member.
eab3844f
PE
7230 (XSETPVECTYPE): Rewrite in terms of new macro.
7231 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7232 This is a bit clearer, and further avoids the possibility of
7233 undesirable aliasing.
7234 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7235 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7236 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7237 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7238 (ASIZE): Now uses header.size rather than size.
7239 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7240 to avoid the hassle of writing XVECTOR (foo)->header.size.
7241 (struct vectorlike_header): New type.
eab3844f
PE
7242 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7243 object, to help avoid aliasing.
7244 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7245 (SUBRP): Likewise, since Lisp_Subr is a special case.
7246 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7247 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7248 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7249 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7250 changed to be "header.size" and "header.next".
7251 * buffer.h (struct buffer): Likewise.
7252 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7253 * frame.h (struct frame): Likewise.
7254 * process.h (struct Lisp_Process): Likewise.
7255 * termhooks.h (struct terminal): Likewise.
7256 * window.c (struct save_window_data, struct saved_window): Likewise.
7257 * window.h (struct window): Likewise.
7258 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7259 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7260 * buffer.c (init_buffer_once): Likewise.
7261 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7262 special case.
7263 * process.c (Fformat_network_address): Use local var for size,
7264 for brevity.
7265
0df1eac5
PE
7266 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7267
847ab9d1 7268 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7269 * data.c (atof): Remove decl; no longer used or needed.
7270 (digit_to_number): Move to lread.c.
7271 (Fstring_to_number): Use new string_to_number function, to be
7272 consistent with how the Lisp reader treats infinities and NaNs.
7273 Do not assume that floating-point numbers represent EMACS_INT
7274 without losing information; this is not true on most 64-bit hosts.
7275 Avoid double-rounding errors, by insisting on integers when
7276 parsing non-base-10 numbers, as the documentation specifies.
7277 * lisp.h (string_to_number): New decl, replacing ...
7278 (isfloat_string): Remove.
bc0a5c13 7279 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7280 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7281 appears to have been a coding error. Similarly, do not accept
7282 strings like +-1e0 as floating point numbers. Do not report
7283 overflow for integer overflows unless the base is not 10 which
7284 means we have no simple and reliable way to continue.
7285 Break out the floating-point parsing into a new
7286 function string_to_number, so that Fstring_to_number parses
7287 floating point numbers consistently with the Lisp reader.
04f2d78b 7288 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7289 (E_CHAR, EXP_INT): Remove, replacing with ...
7290 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7291 (string_to_number): New function, replacing isfloat_string.
7292 This function checks for valid syntax and produces the resulting
7293 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7294 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7295 so that overflow for non-base-10 numbers is reported only when
7296 there's no portable and simple way to convert to floating point.
452f4150 7297
67769ffc
PE
7298 * textprop.c (set_text_properties_1): Rewrite for clarity,
7299 and to avoid GCC warning about integer overflow.
7300
c20db43f
PE
7301 * intervals.h (struct interval): Use EMACS_INT for members
7302 where EMACS_UINT might cause problems. See
7303 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7304 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7305 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7306 All uses changed.
37aa2f85
PE
7307 (offset_intervals): Tell GCC not to worry about length overflow
7308 when negating a negative length.
c20db43f 7309
2538aa2f
PE
7310 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7311 (overrun_check_free): Likewise.
7312
f2d3008d
PE
7313 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7314 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7315 word size.
7316
ec8df744
PE
7317 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7318 (gnutls_make_error): Rename local to avoid shadowing.
7319 (gnutls_emacs_global_deinit): ifdef out; not used.
7320 (Fgnutls_boot): Use const for pointer to readonly storage.
7321 Comment out unused local. Fix pointer signedness problems.
7322
640ee02d
PE
7323 * lread.c (openp): Don't stuff size_t into an 'int'.
7324 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7325 about possible signed overflow.
7326
6048fb2a
PE
7327 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7328 (GDK_KEY_g): Don't define if already defined.
7329 (xg_prepare_tooltip): Avoid pointer signedness problem.
7330 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7331
fa3c87e1
PE
7332 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7333 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7334
2172544b
PE
7335 * xfns.c (Fx_window_property): Simplify a bit,
7336 to make a bit faster and to avoid GCC 4.6.0 warning.
7337 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7338
9b821a21
PE
7339 * fns.c (internal_equal): Don't assume size_t fits in int.
7340
3c616cfa
PE
7341 * alloc.c (compact_small_strings): Tighten assertion a little.
7342
c2982e87
PE
7343 Replace pEd with more-general pI, and fix some printf arg casts.
7344 * lisp.h (pI): New macro, generalizing old pEd macro to other
7345 conversion specifiers. For example, use "...%"pI"d..." rather
7346 than "...%"pEd"...".
7347 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7348 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7349 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7350 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7351 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7352 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7353 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7354 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7355 64-bit hosts.
7356 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7357 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7358 * print.c (safe_debug_print, print_object): Likewise.
7359 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7360 to int.
6f04d126
PE
7361 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7362 avoiding the 0 flag, which is not portable.
c2982e87
PE
7363 * process.c (Fmake_network_process): Use pI to avoid cast.
7364 * region-cache.c (pp_cache): Likewise.
7365 * xdisp.c (decode_mode_spec): Likewise.
7366 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7367 behavior on 64-bit hosts with printf arg.
6f04d126 7368 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7369 (x_stop_queuing_selection_requests): Likewise.
7370 (x_get_window_property): Don't truncate byte count to an 'int'
7371 when tracing.
0b432f21 7372
5e073ec7
PE
7373 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7374 here, since it parses constructs like leading '-' and spaces,
7375 which are not wanted; and it overflows with large numbers.
7376 Instead, simply match F[0-9]+, which is what is wanted anyway.
7377
36372bf9
PE
7378 * alloc.c: Remove unportable assumptions about struct layout.
7379 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7380 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7381 (allocate_vectorlike, make_pure_vector): Use the new macros,
7382 plus offsetof, to remove unportable assumptions about struct layout.
7383 These assumptions hold on all porting targets that I know of, but
7384 they are not guaranteed, they're easy to remove, and removing them
7385 makes further changes easier.
7386
0b432f21
PE
7387 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7388 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7389 (string_overrun_cookie): Now const. Use initializers that
7390 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7391 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7392 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7393 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7394 multiple of sizeof (EMACS_INT); it need not be, if
7395 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7396 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7397
895009e1
JB
73982011-04-26 Juanma Barranquero <lekktu@gmail.com>
7399
7400 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7401
6a7a1b0b
TZ
74022011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7403
7404 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7405 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7406 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7407
841a1577 74082011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7409
7410 * lisp.h (Qdebug): List symbol.
895009e1 7411 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7412 * keyboard.c (debug-on-event): New variable.
7413 (handle_user_signal): Break into debugger when debug-on-event
7414 matches the current signal symbol.
7415
f2d3ba6f
DN
74162011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7417
7418 * alloc.c (check_sblock, check_string_bytes)
7419 (check_string_free_list): Convert to standard C.
7420
42ce4c63
TZ
74212011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7422
7423 * w32.c (emacs_gnutls_push): Fix typo.
7424
825cd63c
EZ
74252011-04-25 Eli Zaretskii <eliz@gnu.org>
7426
fb11d64d
EZ
7427 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7428 "cast to pointer from integer of different size".
7429
825cd63c
EZ
7430 Improve doprnt and its use in verror. (Bug#8545)
7431 * doprnt.c (doprnt): Document the set of format control sequences
7432 supported by the function. Use SAFE_ALLOCA instead of always
7433 using `alloca'.
7434
7435 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7436 is one byte too soon. Don't use xrealloc; instead xfree and
7437 xmalloc anew.
7438
e061a11b
TZ
74392011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7440
7441 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7442 callbacks stage.
7443
7444 * gnutls.c: Renamed global_initialized to
7445 gnutls_global_initialized. Added internals for the
7446 :verify-hostname-error, :verify-error, and :verify-flags
7447 parameters of `gnutls-boot' and documented those parameters in the
7448 docstring. Start callback support.
9173deec
JB
7449 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7450 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7451 on error. Return error code.
e061a11b
TZ
7452 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7453 (emacs_gnutls_read): Likewise.
7454 (Fgnutls_boot): Return handshake error code.
7455 (emacs_gnutls_handle_error): New function.
7456 (wsaerror_to_errno): Likewise.
7457
7458 * w32.h (emacs_gnutls_pull): Add prototype.
7459 (emacs_gnutls_push): Likewise.
7460
7461 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7462 (emacs_gnutls_push): Likewise.
7463
74642011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7465
7466 * process.c (wait_reading_process_output): Check if GnuTLS
7467 buffered some data internally if no FDs are set for TLS
7468 connections.
7469
7470 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7471 (LIBS): Link to USER_LIBS.
7472 ($(BLD)/gnutls.$(0)): New target.
7473
fa6996bc
EZ
74742011-04-24 Eli Zaretskii <eliz@gnu.org>
7475
eb35682e
EZ
7476 * xdisp.c (handle_single_display_spec): Rename the
7477 display_replaced_before_p argument into display_replaced_p, to
7478 make it consistent with the commentary. Fix typos in the
7479 commentary.
7480
e2ad650c
EZ
7481 * textprop.c (syms_of_textprop): Remove dead code.
7482 (copy_text_properties): Delete obsolete commentary about an
7483 interface that was deleted long ago. Fix typos in the description
7484 of arguments.
7485
1b2de274
EZ
7486 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7487 to changes in oldXMenu/XMenu.h from 2011-04-16.
7488 <menu_help_message, prev_menu_help_message>: Constify.
7489 (IT_menu_make_room): menu->help_text is now `const char **';
7490 adjust.
7491
7492 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7493 to changes in oldXMenu/XMenu.h from 2011-04-16.
7494 (struct XMenu): Declare `help_text' `const char **'.
7495
7496 * xfaces.c <Qunspecified>: Make extern again.
7497
7498 * syntax.c: Include sys/types.h before including regex.h, as
7499 required by Posix.
7500
762b15be
EZ
7501 * doc.c (get_doc_string): Improve the format passed to `error'.
7502
7503 * doprnt.c (doprnt): Improve commentary.
7504
7505 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7506
7507 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7508 them with etags.
7509
f1052e5d
EZ
7510 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7511 changes in globals.h immediately force recompilation.
762b15be
EZ
7512 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7513 $(CURDIR)/s/ms-w32.h.
7514 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7515
fa6996bc
EZ
7516 * character.c (Fchar_direction): Function deleted.
7517 (syms_of_character): Don't defsubr it.
7518 <char-direction-table>: Deleted.
7519
e6c3da20
EZ
75202011-04-23 Eli Zaretskii <eliz@gnu.org>
7521
7522 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7523 * doprnt.c: Include limits.h.
7524 (SIZE_MAX): New macro.
04f2d78b
CB
7525 (doprnt): Return a size_t value. 2nd arg is now size_t.
7526 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7527 Improve overflow protection. Support `l' modifier for integer
7528 conversions. Support %l conversion. Don't assume an EMACS_INT
7529 argument for integer conversions and for %c.
7530
7531 * lisp.h (doprnt): Restore prototype.
7532
7533 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7534 $(SRC)/character.h.
7535
7536 * Makefile.in (base_obj): Add back doprnt.o.
7537
7538 * deps.mk (doprnt.o): Add back prerequisites.
7539 (callint.o): Depend on character.h.
7540
7541 * eval.c (internal_lisp_condition_case): Include the handler
7542 representation in the error message.
7543 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7544 when breaking from the loop.
7545
7546 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7547
7548 * callint.c (Fcall_interactively): When displaying error message
7549 about invalid control letter, pass the character's codepoint, not
7550 a pointer to its multibyte form. Improve display of the character
7551 in octal and display also its hex code.
7552
7553 * character.c (char_string): Use %x to display the (unsigned)
7554 codepoint of an invalid character, to avoid displaying a bogus
7555 negative value.
7556
7557 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7558 `error', not SYMBOL_NAME itself.
7559
7560 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7561 character arguments to `error'.
7562
7563 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7564 to `error' in error message about FINAL_CHAR argument. Make sure
7565 FINAL_CHAR is a character, and use %c when it is passed as
7566 argument to `error'.
7567
4ffd0d6b 75682011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7569
7570 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7571
7572 * w32.c: Include <time.h>.
7573 (sys_localtime): New function.
7574
4ffd0d6b 75752011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7576
7577 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7578
4ffd0d6b 7579 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7580
4ffd0d6b 75812011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7582
4ffd0d6b
GM
7583 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7584 zombies (Bug#8467).
aac0c6e3 7585
04c56954
EZ
75862011-04-19 Eli Zaretskii <eliz@gnu.org>
7587
7588 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7589 gl_state.e_property when gl_state.object is Qt.
7590
7591 * insdel.c (make_gap_larger): Remove limitation of buffer size
7592 to <= INT_MAX.
7593
16a43933
CY
75942011-04-18 Chong Yidong <cyd@stupidchicken.com>
7595
7596 * xdisp.c (lookup_glyphless_char_display)
7597 (produce_glyphless_glyph): Handle cons cell entry in
7598 glyphless-char-display.
7599 (Vglyphless_char_display): Document it.
7600
7601 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7602 glyphless-char-display.
7603
4581706e
CY
76042011-04-17 Chong Yidong <cyd@stupidchicken.com>
7605
7606 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7607
7608 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7609
7610 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7611 definition for no-X builds.
7612
4887c6e2 76132011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7614
fd35b6f9
PE
7615 Static checks with GCC 4.6.0 and non-default toolkits.
7616
5c1ccb01
PE
7617 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7618
006c5daa
PE
7619 * process.c (keyboard_bit_set): Define only if SIGIO.
7620 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7621 (send_process): Repair possible setjmp clobbering.
7622
efc736d3
PE
7623 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7624
4e2fe2e6
PE
7625 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7626
f97334a2
PE
7627 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7628
4e75f29d
PE
7629 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7630 Define only if needed.
7631
90efadd1
PE
7632 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7633 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7634 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7635
3c647824
PE
7636 * dispextern.h (struct redisplay_interface): Rename param
7637 to avoid shadowing.
e264f262 7638 * termhooks.h (struct terminal): Likewise.
761383f4 7639 * xterm.c (xembed_send_message): Likewise.
3c647824 7640
b58c5c4a
PE
7641 * insdel.c (make_gap_smaller): Define only if
7642 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7643
cad59032
PE
7644 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7645 it.
7646
c339dc2e
PE
7647 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7648 so that we aren't warned about unused symbols.
7649
91a3e27b
PE
7650 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7651
399c71d3 7652 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7653
8ffc96f5
PE
7654 * xfns.c (x_real_positions): Mark locals as initialized.
7655
eef9bc79
PE
7656 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7657
098db9dd
PE
7658 * xterm.c: Fix problems found by static analysis with other toolkits.
7659 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7660 (x_dispatch_event): Declare static if USE_GTK, and
7661 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7662 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7663 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7664 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7665 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7666
eb18f6cc
PE
7667 * xmenu.c (menu_help_callback): Pointer type fixes.
7668 Use const pointers when pointing at readonly data. Avoid pointer
7669 signedness clashes.
7670 (FALSE): Remove unused macro.
7671 (update_frame_menubar): Remove unused decl.
7672
1fe72bf8
PE
7673 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7674
60d9e1db
PE
7675 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7676 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7677 (single_menu_item): Rename local to avoid shadowing.
7678
39261c26
PE
7679 * keyboard.c (make_lispy_event): Remove unused local var.
7680
018c5e19
PE
7681 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7682 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7683
63d2b86e
PE
7684 * bitmaps: Change bitmaps from unsigned char back to the X11
7685 compatible char. Avoid the old compiler warnings about
7686 out-of-range initializers by using, for example, '\xab' rather
7687 than 0xab.
7688
aefd87e1
PE
7689 * xgselect.c (xgselect_initialize): Check vs interface
7690 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7691
bf501fb9
PE
7692 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7693
e9829fdf
PE
7694 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7695 to read-only memory.
7696
1086c095
PE
7697 * fns.c (vector): Remove; this old hack is no longer needed.
7698
2baccd04 7699 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7700 Remove unused var.
dde42981 7701 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7702
72391843 7703 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7704
436c16df 7705 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7706 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7707 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7708
92bb796d 7709 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7710 (x_term_init): Remove local to avoid shadowing.
92bb796d 7711
764430a3 7712 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7713
7714 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7715 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7716
d1dfb56c
EZ
77172011-04-16 Eli Zaretskii <eliz@gnu.org>
7718
c4354cb4
EZ
7719 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7720
d1dfb56c
EZ
7721 Fix regex.c, syntax.c and friends for buffers > 2GB.
7722 * syntax.h (struct gl_state_s): Declare character position members
7723 EMACS_INT.
7724
7725 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7726
04f2d78b
CB
7727 * textprop.c (verify_interval_modification, interval_of):
7728 Declare arguments EMACS_INT.
d1dfb56c
EZ
7729
7730 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7731 EMACS_INT.
7732
7733 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7734
7735 * indent.c (Fvertical_motion): Local variable it_start is now
7736 EMACS_INT.
7737
7738 * regex.c (re_match, re_match_2, re_match_2_internal)
7739 (bcmp_translate, regcomp, regexec, print_double_string)
7740 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7741 (re_compile_pattern, re_exec): Declare arguments and local
7742 variables `size_t' and `ssize_t' and return values `regoff_t', as
7743 appropriate.
7744 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7745 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7746 <compile_stack_type>: `size' and `avail' are now `size_t'.
7747
7748 * regex.h <regoff_t>: Use ssize_t, not int.
7749 (re_search, re_search_2, re_match, re_match_2): Arguments that
7750 specify buffer/string position and length are now ssize_t and
7751 size_t. Return type is regoff_t.
7752
613052cd
BK
77532011-04-16 Ben Key <bkey76@gmail.com>
7754
7755 * nsfont.m: Fixed bugs in ns_get_family and
7756 ns_descriptor_to_entity that were caused by using free to
7757 deallocate memory blocks that were allocated by xmalloc (via
7758 xstrdup). This caused Emacs to crash when compiled with
7759 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7760 --enable-checking=xmallocoverrun). xfree is now used to
7761 deallocate these memory blocks.
7762
4170f62f 77632011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7764
71b41406
PE
7765 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7766
9587a89d
PE
7767 emacs_write: Accept and return EMACS_INT for sizes.
7768 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7769 et seq.
7770 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7771 Accept and return EMACS_INT.
7772 (emacs_gnutls_write): Return the number of bytes written on
7773 partial writes.
7774 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7775 (emacs_read, emacs_write): Remove check for negative size, as the
7776 Emacs source code has been audited now.
9587a89d
PE
7777 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7778 (emacs_read, emacs_write): Use it.
273a5f82
PE
7779 * process.c (send_process): Adjust to the new signatures of
7780 emacs_write and emacs_gnutls_write. Do not attempt to store
7781 a byte offset into an 'int'; it might overflow.
9587a89d 7782 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7783
3e047f51
PE
7784 * sound.c: Don't assume sizes fit in 'int'.
7785 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7786 Return EMACS_INT, not int.
3e047f51 7787 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7788 Accept EMACS_INT, not int.
7789 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7790 record read return values.
7791
cc39a9db
BK
77922011-04-15 Ben Key <bkey76@gmail.com>
7793
c9d0ec6d
JB
7794 * keyboard.c (Qundefined): Don't declare static since it is used
7795 in nsfns.m.
7796 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7797 static since they are used in nsfont.m.
cc39a9db 7798
6c60eb9f
SM
77992011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7800
7801 * process.c (Qprocessp): Don't declare static.
7802 * lisp.h (Qprocessp): Declare again.
7803
7990b61a
JB
78042011-04-15 Juanma Barranquero <lekktu@gmail.com>
7805
7806 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7807
5d4cb038
PE
78082011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7809
8bd7b830 7810 Improve C-level modularity by making more things 'static'.
cd64ea1d 7811
e3b27b31
PE
7812 Don't publish debugger-only interfaces to other modules.
7813 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7814 (verify_bytepos, count_markers): Move decls to the only modules
7815 that need them.
7816 * region-cache.h (pp_cache): Likewise.
7817 * window.h (check_all_windows): Likewise.
7818 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7819
5d4cb038
PE
7820 * sysdep.c (croak): Now static, if
7821 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7822 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7823
7824 * alloc.c (refill_memory_reserve): Now static if
7825 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7826 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7827
e87b6180
PE
7828 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7829 Define only if USE_LUCID.
7830
ac64929e
PE
7831 * xrdb.c (x_customization_string, x_rm_string): Now static.
7832
6f37259d
PE
7833 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7834 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7835
1683e3ab
PE
7836 * xdisp.c (draw_row_with_mouse_face): Now static.
7837 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7838
de9c2632
PE
7839 * window.h (check_all_windows): Mark externally visible.
7840
2b96acb7
PE
7841 * window.c (window_deletion_count): Now static.
7842
7843 * undo.c: Make symbols static if they're not exported.
7844 (last_undo_buffer, last_boundary_position, pending_boundary):
7845 Now static.
7846
50436f33
PE
7847 * textprop.c (interval_insert_behind_hooks): Now static.
7848 (interval_insert_in_front_hooks): Likewise.
7849
64520e5c
PE
7850 * term.c: Make symbols static if they're not exported.
7851 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7852 (max_frame_lines, tty_set_terminal_modes):
7853 (tty_reset_terminal_modes, tty_turn_off_highlight):
7854 (get_tty_terminal): Now static.
7855 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7856 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7857 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7858 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7859 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7860
1fa53021
PE
7861 * sysdep.c: Make symbols static if they're not exported.
7862 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7863 Now static.
7864 (sigprocmask_set, full_mask): Remove; unused.
7865 (wait_debugging): Mark as visible.
7866 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7867 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7868
d4b43b22
PE
7869 * syntax.c (syntax_temp): Define only if !__GNUC__.
7870
b7c513d0
PE
7871 * sound.c (current_sound_device, current_sound): Now static.
7872
989b29ad
PE
7873 * search.c (searchbufs, searchbuf_head): Now static.
7874
13a55a78
PE
7875 * scroll.c (scroll_cost): Remove; unused.
7876 * dispextern.h (scroll_cost): Remove decl.
7877
de68a1fc
PE
7878 * region-cache.h (pp_cache): Mark as externally visible.
7879
40ccffa6
PE
7880 * process.c: Make symbols static if they're not exported.
7881 (process_tick, update_tick, create_process, chan_process):
7882 (Vprocess_alist, proc_buffered_char, datagram_access):
7883 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7884 (deactivate_process): Mark defn as static, as well as decl.
7885 * lisp.h (create_process): Remove decl.
7886 * process.h (chan_process, Vprocess_alist): Remove decls.
7887
ad64fc97
PE
7888 * print.c: Make symbols static if they're not exported.
7889 (print_depth, new_backquote_output, being_printed, print_buffer):
7890 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7891 (print_interval, print_number_index, initial_stderr_stream):
7892 Now static.
7893 * lisp.h (Fprinc): Remove decl.
7894 (debug_output_compilation_hack): Mark as externally visible.
7895
adddb265
PE
7896 * sysdep.c (croak): Move decl from here to syssignal.h.
7897 * syssignal.h (croak): Put it here, so the API can be checked when
7898 'croak' is called from dissociate_if_controlling_tty.
7899
1717ede2
PE
7900 * minibuf.c: Make symbols static if they're not exported.
7901 (minibuf_save_list, choose_minibuf_frame): Now static.
7902 * lisp.h (choose_minibuf_frame): Remove decl.
7903
fa5fb2bc
PE
7904 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7905
1e3890d1
PE
7906 * lread.c: Make symbols static if they're not exported.
7907 (read_objects, initial_obarray, oblookup_last_bucket_number):
7908 Now static.
7909 (make_symbol): Remove; unused.
7910 * lisp.h (initial_obarray, make_symbol): Remove decls.
7911
8a1414fa
PE
7912 * keyboard.c: Make symbols static if they're not exported.
7913 (single_kboard, recent_keys_index, total_keys, recent_keys):
7914 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7915 (this_single_command_key_start, echoing, last_auto_save):
7916 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7917 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7918 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7919 (Vlispy_mouse_stem, double_click_count):
7920 Now static.
7921 (force_auto_save_soon): Define only if SIGDANGER.
7922 (ignore_mouse_drag_p): Now static if
7923 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7924 (print_help): Remove; unused.
7925 (stop_character, last_timer_event): Mark as externally visible.
7926 * keyboard.h (ignore_mouse_drag_p): Declare only if
7927 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7928 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7929 * lisp.h (echoing): Remove decl.
7930 (force_auto_save_soon): Declare only if SIGDANGER.
7931 * xdisp.c (redisplay_window): Simplify code, to make it more
7932 obvious that ignore_mouse_drag_p is not accessed if !defined
7933 USE_GTK && !defined HAVE_NS.
7934
93ea6e8f
PE
7935 * intervals.c: Make symbols static if they're not exported.
7936 (merge_properties_sticky, merge_interval_right, delete_interval):
7937 Now static.
7938 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7939
77382fcc
PE
7940 * insdel.c: Make symbols static if they're not exported.
7941 However, leave prepare_to_modify_buffer alone. It's never
7942 called from outside this function, but that appears to be a bug.
7943 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7944 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7945 (adjust_after_replace_noundo): Remove; unused.
7946 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7947 (signal_before_change): Remove decls.
77382fcc 7948
9306c32e
PE
7949 * indent.c (val_compute_motion, val_vmotion): Now static.
7950
cd44d2eb
PE
7951 * image.c: Make symbols static if they're not exported.
7952 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7953 if USE_GTK.
7954 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7955 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7956
ad9a7a06
PE
7957 * fringe.c (standard_bitmaps): Now static.
7958 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7959
81626931
PE
7960 * frame.c: Make symbols static if they're not exported.
7961 (x_report_frame_params, make_terminal_frame): Now static.
7962 (get_frame_param): Now static, unless HAVE_NS.
7963 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7964 (x_get_resource_string): Remove; not used.
7965 * frame.h (make_terminal_frame, x_report_frame_params):
7966 (x_get_resource_string); Remove decls.
7967 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7968 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7969
239f9db9
PE
7970 * font.c, fontset.c: Make symbols static if they're not exported.
7971 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7972 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7973 * font.c (font_close_object): Now static.
7974 * font.h (font_close_object): Remove.
7975 * fontset.c (FONTSET_OBJLIST): Remove.
7976 (free_realized_fontset) #if-0 the body, which does nothing.
7977 (face_suitable_for_char_p): #if-0, as it's never called.
7978 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7979 * xfaces.c (face_at_string_position):
7980 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7981 since 0 is always ASCII.
7982
dfcf3579
PE
7983 * fns.c (weak_hash_tables): Now static.
7984
5045092b
PE
7985 * fileio.c: Make symbols static if they're not exported.
7986 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7987 (Vwrite_region_annotation_buffers): Now static.
7988
57a96f5c
PE
7989 * eval.c: Make symbols static if they're not exported.
7990 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7991 * lisp.h (backtrace_list): Remove decl.
7992
35f08c38
PE
7993 * emacs.c: Make symbols static if they're not exported.
7994 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7995 (fatal_error_code, fatal_error_signal_hook, standard_args):
7996 Now static.
7997 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7998 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7999 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8000 * lisp.h (fatal_error_signal_hook): Remove decl.
8001 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8002
f44bd759
PE
8003 * editfns.c: Move a (normally-unused) function to its only use.
8004 * editfns.c, lisp.h (get_operating_system_release): Remove.
8005 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8006 worth the hassle of breaking this out.
8007
b532497d
PE
8008 * xterm.c: Make symbols static if they're not exported.
8009 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8010 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8011 (x_destroy_window, x_delete_display):
8012 Now static.
8013 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8014 (x_mouse_leave): Remove; unused.
8015 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8016 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8017 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8018 Remove decls.
8019 (x_mouse_leave): Declare only if WINDOWSNT.
8020 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8021 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8022 USE_X_TOOLKIT.
8023
1675728f
PE
8024 * ftxfont.c: Make symbols static if they're not exported.
8025 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8026 HAVE_FREETYPE.
8027 * font.h (ftxfont_driver): Likewise.
8028
e4cebfca
PE
8029 * xfns.c: Make symbols static if they're not exported.
8030 (x_last_font_name, x_display_info_for_name):
8031 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8032 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8033 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8034 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8035 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8036 (last_show_tip_args): Now static.
8037 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8038 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8039 (x_screen_planes): Remove; unused.
8040 * dispextern.h (x_screen_planes): Remove decl.
8041
5bf46f05
PE
8042 * dispnew.c: Make symbols static if they're not exported.
8043 * dispextern.h (redraw_garbaged_frames, scrolling):
8044 (increment_row_positions): Remove.
8045 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8046 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8047 Now static.
8048 (redraw_garbaged_frames): Remove; unused.
8049
435f4c28
PE
8050 * xfaces.c: Make symbols static if they're not exported.
8051 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8052 Remove decls.
8053 * xterm.h (defined_color): Remove decls.
8054 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8055 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8056 (menu_face_changed_default, defined_color, free_realized_face):
8057 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8058 (ascii_face_of_lisp_face): Remove; unused.
8059
8524aef3
PE
8060 * xdisp.c: Make symbols static if they're not exported.
8061 * dispextern.h (scratch_glyph_row, window_box_edges):
8062 (glyph_to_pixel_coords, set_cursor_from_row):
8063 (get_next_display_element, set_iterator_to_next):
8064 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8065 (show_mouse_face): Remove decls
8066 * frame.h (message_buf_print): Likewise.
8067 * lisp.h (pop_message, set_message, check_point_in_composition):
8068 Likewise.
8069 * xterm.h (set_vertical_scroll_bar): Likewise.
8070 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8071 (message_buf_print, scratch_glyph_row, displayed_buffer):
8072 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8073 (get_next_display_element, show_mouse_face, window_box_edges):
8074 (frame_to_window_pixel_xy, check_point_in_composition):
8075 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8076 (glyph_to_pixel_coords): Remove; unused.
8077
16390cd2
PE
8078 * dired.c (file_name_completion): Now static.
8079
8080 * dbusbind.c (xd_in_read_queued_messages): Now static.
8081
a25f4dfa
PE
8082 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8083 * data.c (circular_list_error): Remove.
8084
14a9c8df
PE
8085 * commands.h (last_point_position, last_point_position_buffer):
8086 (last_point_position_window): Remove decls.
8087 * keyboard.c: Make these variables static.
8088
04f2d78b
CB
8089 * coding.h (coding, code_convert_region, encode_coding_gap):
8090 Remove decls.
74ab6df5
PE
8091 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8092 (iso_code_class, detect_coding, code_convert_region): Now static.
8093 (encode_coding_gap): Remove; unused.
8094
38dfbee1
PE
8095 * chartab.c (chartab_chars, chartab_bits): Now static.
8096
a2cb4e63
PE
8097 * charset.h (charset_iso_8859_1): Remove decl.
8098 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8099 Now static.
8100
127198fd
PE
8101 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8102 * ccl.c (Vccl_program_table): Now static.
8103 (check_ccl_update): Remove; unused.
8104
d85b608f
PE
8105 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8106 * category.h: ... from here.
8107 * category.c (check_category_table, set_category_set): Now static.
8108
31cd66f3
PE
8109 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8110 * lisp.h: Remove these decls.
8111
c358e587
PE
8112 * buffer.c (buffer_count): Remove unused var.
8113
e78aecca
PE
8114 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8115 so that it's not optimized away.
8116 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8117 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8118 exported only to the debugger.
8119
e192d7d3 8120 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8121 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8122
92470028
PE
8123 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8124 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8125 was inaccessible from Lisp.
8126 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8127 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8128
244ed907
PE
8129 alloc.c: Import and export fewer symbols, and remove unused items.
8130 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8131 is defined.
8132 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8133 it's not optimized away by whole-program optimization.
8134 (message_enable_multibyte, free_misc): Remove.
8135 (catchlist, handlerlist, mark_backtrace):
8136 Declare only if BYTE_MARK_STACK.
8137 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8138 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8139 (message_enable_multibyte): Remove decl.
8140 (free_misc, interval_free_list, float_block, float_block_index):
8141 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8142 (cons_free_list, last_marked_index):
8143 Now static.
8144 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8145 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8146 (mark_backtrace): Define only if BYTE_MARK_STACK.
8147 * xdisp.c (message_enable_multibyte): Now static.
8148
61c2b50e 8149 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8150 This makes it easier for human readers (and static analyzers)
8151 to see whether these variables are used from other modules.
8152 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8153 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8154 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8155 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8156 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8157 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8158 * xmenu.c, xselect.c:
8159 Declare Q* vars static if they are not used in other modules.
8160 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8161 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8162 Remove decls of unexported vars.
8163 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8164
95c82688
PE
8165 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8166
16a97296
PE
8167 Make Emacs functions such as Fatom 'static' by default.
8168 This makes it easier for human readers (and static analyzers)
8169 to see whether these functions can be called from other modules.
8170 DEFUN now defines a static function. To make the function external
8171 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8172 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8173 (Finit_image_library):
16a97296
PE
8174 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8175 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8176 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8177 Remove decls, since these functions are now static.
8178 (Funintern, Fget_internal_run_time): New decls, since these functions
8179 were already external.
95c82688 8180
16a97296
PE
8181 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8182 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8183 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8184 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8185 * keyboard.c, keymap.c, lread.c:
8186 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8187 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8188 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8189 Mark functions with DEFUE instead of DEFUN,
8190 if they are used in other modules.
8191 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8192 decls for now-static functions.
8193 * buffer.h (Fdelete_overlay): Remove decl.
8194 * callproc.c (Fgetenv_internal): Mark as internal.
8195 * composite.c (Fremove_list_of_text_properties): Remove decl.
8196 (Fcomposition_get_gstring): New forward static decl.
8197 * composite.h (Fcomposite_get_gstring): Remove decl.
8198 * dired.c (Ffile_attributes): New forward static decl.
8199 * doc.c (Fdocumntation_property): New forward static decl.
8200 * eval.c (Ffetch_bytecode): New forward static decl.
8201 (Funintern): Remove extern decl; now in .h file where it belongs.
8202 * fileio.c (Fmake_symbolic_link): New forward static decl.
8203 * image.c (Finit_image_library): New forward static decl.
8204 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8205 * intervals.h (Fprevious_property_change):
8206 (Fremove_list_of_text_properties): Remove decls.
8207 * keyboard.c (Fthis_command_keys): Remove decl.
8208 (Fcommand_execute): New forward static decl.
8209 * keymap.c (Flookup_key): New forward static decl.
8210 (Fcopy_keymap): Now static.
8211 * keymap.h (Flookup_key): Remove decl.
8212 * process.c (Fget_process): New forward static decl.
8213 (Fprocess_datagram_address): Mark as internal.
8214 * syntax.c (Fsyntax_table_p): New forward static decl.
8215 (skip_chars): Remove duplicate decl.
8216 * textprop.c (Fprevious_property_change): New forward static decl.
8217 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8218 Now internal.
8219 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8220 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8221
785bbd42
PE
8222 * editfns.c (Fformat): Remove unreachable code.
8223
8b913b57
AS
82242011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8225
8226 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8227 change. (Bug#8496)
8228
a6744a35
EZ
82292011-04-13 Eli Zaretskii <eliz@gnu.org>
8230
8231 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8232 when at ZV. (Bug#8487)
8233
e7974947
AS
82342011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8235
baad03f0
AS
8236 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8237 (Bug#8437)
8238 * keyboard.c (parse_tool_bar_item): Likewise.
8239 * sound.c (sound_cleanup, alsa_close): Likewise.
8240 * termcap.c (tgetent): Likewise.
8241 * xfns.c (x_default_font_parameter): Likewise.
8242 * xsettings.c (read_and_apply_settings): Likewise.
8243
e7974947
AS
8244 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8245 (overrun_check_free): Protoize.
8246
28272684
PE
82472011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8248
8249 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8250 since callers should never pass a negative size.
8251 Change the signature to match that of plain 'read' and 'write'; see
8252 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8253 * lisp.h: Update prototypes of emacs_write and emacs_read.
8254
11997c76
EZ
82552011-04-11 Eli Zaretskii <eliz@gnu.org>
8256
8257 * xdisp.c (redisplay_window): Don't try to determine the character
8258 position of the scroll margin if the window start point w->startp
e896f03c 8259 is outside the buffer's accessible region. (Bug#8468)
11997c76 8260
8a2cbd72
EZ
82612011-04-10 Eli Zaretskii <eliz@gnu.org>
8262
8263 Fix write-region and its subroutines for buffers > 2GB.
8264 * fileio.c (a_write, e_write): Modify declaration of arguments and
8265 local variables to support buffers larger than 2GB.
8266 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8267
8268 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8269 argument, local variables, and return value.
8270
8271 * lisp.h: Update prototypes of emacs_write and emacs_read.
8272
8273 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8274
4073e537 82752011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8276
1ebfdcb6
PE
8277 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8278
b2ded58d
PE
8279 Fix more problems found by GCC 4.6.0's static checks.
8280
7d66342c
PE
8281 * xdisp.c (vmessage): Use a better test for character truncation.
8282
bbf47d44
PE
8283 * charset.c (load_charset_map): <, not <=, for optimization,
8284 and to avoid potential problems with integer overflow.
9248994d 8285 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8286 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8287 * editfns.c (Fformat): Likewise.
1e69125e 8288 * syntax.c (skip_chars): Likewise.
3befa583 8289
e3019616
PE
8290 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8291 This also lets GCC 4.6.0 generate slightly better loop code.
8292
becfa255
PE
8293 * callint.c (Fcall_interactively): <, not <=, for optimization.
8294 (Fcall_interactively): Count the number of arguments produced,
8295 not the number of arguments given. This is simpler and lets GCC
8296 4.6.0 generate slightly better code.
8297
dae0cd48
PE
8298 * ftfont.c: Distingish more carefully between FcChar8 and char.
8299 The previous code passed unsigned char * to a functions like
8300 strlen and xstrcasecmp that expect char *, which does not
8301 conform to the C standard.
8302 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8303 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8304 char * when the C standard requires it.
8305
76032d70
PE
8306 * keyboard.c (read_char): Remove unused var.
8307
eb3f1cc8
PE
8308 * eval.c: Port to Windows vsnprintf (Bug#8435).
8309 Include <limits.h>.
8310 (SIZE_MAX): Define if the headers do not.
8311 (verror): Do not give up if vsnprintf returns a negative count.
8312 Instead, grow the buffer. This ports to Windows vsnprintf, which
8313 does not conform to C99. Problem reported by Eli Zaretskii.
8314 Also, simplify the allocation scheme, by avoiding the need for
8315 calling realloc, and removing the ALLOCATED variable.
8316
70476b54
PE
8317 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8318
12020a9e
PE
8319 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8320 But keep the doprint source code for now, as we might revamp it
8321 and use it again (Bug#8435).
ea6c7ae6
PE
8322 * lisp.h (doprnt): Remove.
8323 * Makefile.in (base_obj): Remove doprnt.o.
8324 * deps.mk (doprnt.o): Remove.
8325
5fdb398c
PE
8326 error: Print 32- and 64-bit integers portably (Bug#8435).
8327 Without this change, on typical 64-bit hosts error ("...%d...", N)
8328 was used to print both 32- and 64-bit integers N, which relied on
8329 undefined behavior.
61bdb816 8330 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8331 * lisp.h (error, verror): Mark as printf-like functions.
8332 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8333 Report overflow in size calculations when allocating printf buffer.
8334 Do not truncate output string at its first null byte.
8335 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8336 Truncate the output at a character boundary, since vsnprintf does not
8337 do that.
8338 * charset.c (check_iso_charset_parameter): Convert internal
8339 character to string before calling 'error', since %c now has the
8340 printf meaning.
8341 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8342 overflow when computing char to be passed to 'error'. Do not
8343 pass Lisp_Object to 'error'; pass the integer instead.
8344 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8345 formatted with plain %d.
8346
b189fa66
PE
8347 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8348
bff87ef0
PE
8349 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8350
7e2cac20
PE
8351 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8352
ce4d90b5
PE
8353 * xterm.c (x_catch_errors): Remove duplicate declaration.
8354
266c9547
PE
8355 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8356
79c49ad2
PE
8357 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8358
368f4090
JM
83592011-04-10 Jim Meyering <meyering@redhat.com>
8360
8361 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8362 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8363 return ssize_t not "int", and use size_t as the buffer length.
8364 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8365 * gnutls.h: Update declarations.
8366 * process.c (read_process_output): Use ssize_t, to match.
8367 (send_process): Likewise.
8368
a32d4040
CY
83692011-04-09 Chong Yidong <cyd@stupidchicken.com>
8370
8371 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8372
8546720e 83732011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8374
04f2d78b
CB
8375 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8376 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8377
8546720e
GM
8378 * xterm.c (handle_one_xevent):
8379 * xmenu.c (create_and_show_popup_menu):
8380 * xselect.c (x_decline_selection_request)
8381 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8382
0a2f5c1a 83832011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8384
8385 Fix some uses of `int' instead of EMACS_INT.
8386 * search.c (string_match_1, fast_string_match)
8387 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8388 (scan_buffer, find_next_newline_no_quit)
8389 (find_before_next_newline, search_command, Freplace_match)
8390 (Fmatch_data): Make some `int' variables be EMACS_INT.
8391
8392 * xdisp.c (display_count_lines): 3rd argument and return value now
8393 EMACS_INT. All callers changed.
8394 (pint2hrstr): Last argument is now EMACS_INT.
8395
8396 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8397 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8398 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8399 (decode_coding_utf_16, decode_coding_emacs_mule)
8400 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8401 (decode_coding_ccl, decode_coding_charset)
8402 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8403 (decode_coding_iso_2022, decode_coding_emacs_mule)
8404 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8405 <char_offset, last_offset>: Declare EMACS_INT.
8406 (encode_coding_utf_8, encode_coding_utf_16)
8407 (encode_coding_emacs_mule, encode_invocation_designation)
8408 (encode_designation_at_bol, encode_coding_iso_2022)
8409 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8410 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8411 Declare EMACS_INT.
8412 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8413 (encode_invocation_designation): Last argument P_NCHARS is now
8414 EMACS_INT.
8415 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8416 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8417
8418 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8419 All users changed.
8420
8421 * ccl.c (Fccl_execute_on_string): Declare some variables
8422 EMACS_INT.
8423
8546720e 84242011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8425
8426 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8427
4e19a977
CS
84282011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8429
8430 * process.c (Fformat_network_address): Doc fix.
8431
87302331
R
84322011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8433
ee7683eb 8434 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8435
cbb59342
CY
84362011-04-08 Chong Yidong <cyd@stupidchicken.com>
8437
8438 * keyboard.c (read_char): Call Lisp function help-form-show,
8439 instead of using internal_with_output_to_temp_buffer.
8440 (Qhelp_form_show): New var.
e0d38eeb 8441 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8442
8443 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8444
8445 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8446
e67a13ab
CY
84472011-04-06 Chong Yidong <cyd@stupidchicken.com>
8448
04f2d78b
CB
8449 * process.c (Flist_processes): Remove to Lisp.
8450 (list_processes_1): Delete.
e67a13ab 8451
973f782d
EZ
84522011-04-06 Eli Zaretskii <eliz@gnu.org>
8453
7c106b1e
EZ
8454 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8455
973f782d
EZ
8456 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8457
41cf7d1a 84582011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8459
ca23cc88
PE
8460 Fix more problems found by GCC 4.6.0's static checks.
8461
f390e2d5
PE
8462 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8463
42eea0d0
PE
8464 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8465
b69769da 8466 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8467
f9541e84
PE
8468 * xdisp.c (vmessage): Mark as a printf-like function.
8469
13841b55
PE
8470 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8471
c136c10f
PE
8472 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8473
5e2d4a30
PE
8474 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8475 printf-like functions.
8476 (tiff_load): Add casts to remove these marks before passing them
8477 to system-supplied API.
8478
583f48b9
PE
8479 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8480
b25d760e
PE
8481 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8482 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8483 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8484 directly, rather than having caller test rule sign. This avoids
8485 some unnecessary tests.
8486 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8487 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8488 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8489
bc7b6697 8490 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8491 (xfont_open): Avoid unnecessary tests.
bc7b6697 8492
27ccc379
PE
8493 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8494
dcd5c89a
PE
8495 * composite.h, composite.c (composition_gstring_put_cache):
8496 Use EMACS_INT, not int, for length.
8497
b13a45c6
PE
8498 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8499 breaking out part of COMPOSITION_DECODE_RULE.
8500 (COMPOSITION_DECODE_RULE): Use it.
8501 * composite.c (get_composition_id): Remove unused local vars,
8502 by using the new macro.
8503
1e792e4d
PE
8504 * textprop.c (set_text_properties_1): Change while to do-while,
8505 since the condition is always true at first.
8506
dc6c6455 8507 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8508 (interval_deletion_adjustment): Return unsigned value.
8509 All uses changed.
dc6c6455 8510
aba7731a
PE
8511 * process.c (list_processes_1, create_pty, read_process_output):
8512 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8513 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8514 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8515 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8516 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8517
fdfc4bf3
PE
8518 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8519
fca8fe46 8520 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8521 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8522
06a0259a 8523 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8524 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8525 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8526
e7b9e80f
PE
8527 * print.c (print_error_message): Avoid int overflow.
8528
56201685
PE
8529 * font.c (font_list_entities): Redo for clarity,
8530 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8531
78834453 8532 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8533 (font_score): Avoid potential overflow in diff calculation.
78834453 8534
0bc0b309 8535 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8536 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8537
e610eaca
PE
8538 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8539
b895abce
PE
8540 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8541 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8542 can always succeed if overflow has undefined behavior.
8543
1f1d9321 8544 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8545 (wordify): Omit three unnecessary tests.
1f1d9321 8546
c59478bc
PE
8547 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8548 All callers changed. This avoids the need for an unused var.
8549
79b73827
PE
8550 * casefiddle.c (casify_region): Remove var that is set but not used.
8551
a4db5dfe
PE
8552 * dired.c (file_name_completion): Remove var that is set but not used.
8553
43aae36e
PE
8554 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8555
2a47c44d 8556 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8557 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8558
a37c69bf
PE
8559 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8560 Check for integer overflow on size calculations.
8561
328ab8e7
PE
8562 * buffer.c (Fprevious_overlay_change): Remove var that is set
8563 but not used.
8564
e5a2a5cb
PE
8565 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8566 Remove vars that are set but not used.
8d84a6eb 8567 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8568 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8569
a60e5f68
PE
8570 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8571
f661cb61 8572 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8573 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8574
f0397f5a
PE
8575 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8576 that are set but not used.
8577
8664db06 8578 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8579 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8580
6abdaa4a
PE
8581 * xselect.c (x_get_local_selection, x_handle_property_notify):
8582 Remove vars that are set but not used.
8583
0ce7538d 8584 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8585 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8586
9ae848fc
PE
8587 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8588 Remove var that is set but not used.
0b918413
PE
8589 (scroll_bar_windows_size): Now size_t, not int.
8590 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8591 Check for overflow.
9ae848fc 8592
a5a62657
PE
8593 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8594 (map_tty_color) [!defined MSDOS]: Likewise.
8595
5c5cdd39
PE
8596 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8597
66ebf983
PE
8598 * coding.c: Remove vars that are set but not used.
8599 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8600 All callers changed.
8601 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8602 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8603 (decode_coding_charset): Remove vars that are set but not used.
8604
1be4d761
PE
8605 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8606 that is set but not used.
8607
47553fa8
PE
8608 * print.c (print_object): Remove var that is set but not used.
8609
1f7196bf 8610 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8611 The gnulib version avoids calling malloc in the usual case,
8612 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8613 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8614 * filelock.c (current_lock_owner): Likewise.
8615 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8616 * sysdep.c: Include allocator.h, careadlinkat.h.
8617 (emacs_no_realloc_allocator): New static constant.
8618 (emacs_readlink): New function.
fdb61804
PE
8619 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8620 ../lib/careadlinkat.h.
d1fdcab7 8621
f84c17c7
SM
86222011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8623
8624 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8625 first non-nil return value).
8626
ef3862ad
JD
86272011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8628
8629 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8630 if not defined (Bug#8403).
8631
376a7006
JB
86322011-04-02 Juanma Barranquero <lekktu@gmail.com>
8633
8634 * xdisp.c (display_count_lines): Remove parameter `start',
8635 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8636 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8637 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8638 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8639 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8640 and thereabouts. All callers changed.
8641 (get_per_char_metric): Remove parameter `f', unused since
8642 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8643
6ca3801d
JM
86442011-04-02 Jim Meyering <meyering@redhat.com>
8645
8646 do not dereference NULL upon failed strdup
8647 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8648 (ns_get_family): Likewise.
8649
d8e2b5ba
JB
86502011-04-02 Juanma Barranquero <lekktu@gmail.com>
8651
8652 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8653
8c74fcbd
JD
86542011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8655
8656 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8657 later (Bug#8403).
8658
7200d79c
SM
86592011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8660
03408648 8661 Add lexical binding.
7200d79c 8662
03408648
SM
8663 * window.c (Ftemp_output_buffer_show): New fun.
8664 (Fsave_window_excursion):
8665 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8666
8667 * lread.c (lisp_file_lexically_bound_p): New function.
8668 (Fload): Bind Qlexical_binding.
8669 (readevalloop): Remove `evalfun' arg.
8670 Bind Qinternal_interpreter_environment.
8671 (Feval_buffer): Bind Qlexical_binding.
8672 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8673 Mark as dynamic.
8674 (syms_of_lread): Declare `lexical-binding'.
8675
8676 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8677
8678 * keyboard.c (eval_dyn): New fun.
8679 (menu_item_eval_property): Use it.
ca105506
SM
8680
8681 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8682
03408648
SM
8683 * fns.c (concat, mapcar1): Accept byte-code-functions.
8684
8685 * eval.c (Fsetq): Handle lexical vars.
8686 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8687 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8688 (FletX, Flet): Obey lexical binding.
8689 (Fcommandp): Handle closures.
8690 (Feval): New `lexical' arg.
8691 (eval_sub): New function extracted from Feval. Use it almost
8692 everywhere where Feval was used. Look up vars in lexical env.
8693 Handle closures.
8694 (Ffunctionp): Move from subr.el.
8695 (Ffuncall): Handle closures.
8696 (apply_lambda): Remove `eval_flags'.
8697 (funcall_lambda): Handle closures and new byte-code-functions.
8698 (Fspecial_variable_p): New function.
8699 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8700 but without exporting it to Lisp.
23aba0ea 8701
23aba0ea 8702 * doc.c (Fdocumentation, store_function_docstring):
03408648 8703 * data.c (Finteractive_form): Handle closures.
23aba0ea 8704
03408648
SM
8705 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8706 interactive spec.
ba83908c 8707
04f2d78b
CB
8708 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8709 New byte-codes.
03408648
SM
8710 (exec_byte_code): New function extracted from Fbyte_code to handle new
8711 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8712
03408648 8713 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8714
03408648 8715 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8716
e2abce01
JB
87172011-03-31 Juanma Barranquero <lekktu@gmail.com>
8718
8719 * xdisp.c (redisplay_internal): Fix prototype.
8720
63696a73 87212011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8722
63696a73 8723 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8724 (try_scrolling): Use it when setting scroll_limit.
8725 Limit scrolling to 100 screen lines.
63696a73
EZ
8726 (redisplay_window): Even when falling back on "recentering",
8727 position point in the window according to scroll-conservatively,
8728 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8729
8730 (try_scrolling): When point is above the window, allow searching
8731 as far as scroll_max, or one screenful, to compute vertical
8732 distance from PT to the scroll margin position. This prevents
8733 try_scrolling from unnecessarily failing when
8734 scroll-conservatively is set to a value slightly larger than the
8735 window height. Clean up the case of PT below the margin at bottom
8736 of window: scroll_max can no longer be INT_MAX. When aggressive
8737 scrolling is in use, don't let point enter the opposite scroll
8738 margin as result of the scroll.
8739 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8740 threshold of 100 lines for never-recentering scrolling.
8741
e4cc2dfc
JB
87422011-03-31 Juanma Barranquero <lekktu@gmail.com>
8743
8744 * dispextern.h (move_it_by_lines):
8745 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8746 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8747 (message_log_check_duplicate): Remove parameters `prev_bol' and
8748 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8749 (redisplay_internal): Remove parameter `preserve_echo_area',
8750 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8751
8752 * indent.c (Fvertical_motion):
8753 * window.c (window_scroll_pixel_based, Frecenter):
8754 Don't pass `need_y_p' to `move_it_by_lines'.
8755
1c470562
SM
87562011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8757
44f230aa
SM
8758 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8759 steal a few bits to be more compact.
8760 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8761 Remove unneeded casts.
8762
1c470562
SM
8763 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8764
888adce9
ZK
87652011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8766
8767 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8768 binding" message (bug#7967).
8769
f838ed7b
PE
87702011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8771
77861b95
PE
8772 Fix more problems found by GCC 4.6.0's static checks.
8773
de6dbc14
PE
8774 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8775 Remove unused local var.
8776
f838ed7b
PE
8777 * editfns.c (Fmessage_box): Remove unused local var.
8778
792c7b2b
PE
8779 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8780 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8781 Omit unused local vars.
c499e557 8782 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8783 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8784 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8785 Omit unused local var.
8786
ba0165e1
PE
8787 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8788 Don't assume string length fits in int.
32ad8845 8789 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8790 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8791
3c59b4c9
PE
8792 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8793 instead of alloca (Bug#8344).
8794
a3eed478 8795 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8796 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8797
eb4d412d
PE
8798 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8799
1658b401
PE
8800 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8801 concerns.
8802
8803 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8804
8805 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8806
9a2c6e05
PE
8807 * keyboard.c (syms_of_keyboard): Use the same style as later
8808 in this function when indexing through an array. This also
8809 works around GCC bug 48267.
8810
03d0a109
PE
8811 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8812
44f730c8
PE
8813 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8814
fe75f926
PE
8815 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8816 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8817
ffa8c828
PE
8818 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8819 This avoids undefined behavior on integer overflow, and is a bit
8820 more convenient anyway since it is compared to a size_t variable.
8821
c5101a77
PE
8822 Variadic C functions now count arguments with size_t, not int.
8823 This avoids an unnecessary limitation on 64-bit machines, which
8824 caused (substring ...) to crash on large vectors (Bug#8344).
8825 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8826 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8827 All variadic functions and their callers changed accordingly.
c5101a77
PE
8828 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8829 * data.c (arith_driver, float_arith_driver): Likewise.
8830 * editfns.c (general_insert_function): Likewise.
8831 * eval.c (struct backtrace.nargs, interactive_p)
8832 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8833 (funcall_lambda, mark_backtrace): Likewise.
8834 * fns.c (concat): Likewise.
8835 * frame.c (x_set_frame_parameters): Likewise.
8836 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8837 0 if not found, not -1. All callers changed.
8838
dd3f25f7
PE
8839 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8840 (stack_copy_size): Now size_t, not int.
8841 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8842
461c2ab9
JB
88432011-03-28 Juanma Barranquero <lekktu@gmail.com>
8844
8845 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8846 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8847 All callers changed.
8848
8849 * lisp.h (multibyte_char_to_unibyte):
8850 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8851 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8852 * character.h (CHAR_TO_BYTE8):
8853 * cmds.c (internal_self_insert):
8854 * editfns.c (general_insert_function):
8855 * keymap.c (push_key_description):
8856 * search.c (Freplace_match):
8857 * xdisp.c (message_dolog, set_message_1): All callers changed.
8858
f6d62986
SM
88592011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8860
8861 * keyboard.c (safe_run_hook_funcall): New function.
8862 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8863 don't set the hook to nil, but remove the offending function instead.
8864 (Qcommand_hook_internal): Remove, unused.
8865 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8866 Vcommand_hook_internal.
8867
8868 * eval.c (enum run_hooks_condition): Remove.
8869 (funcall_nil, funcall_not): New functions.
8870 (run_hook_with_args): Call each function through a `funcall' argument.
8871 Remove `cond' argument, now redundant.
8872 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8873 (Frun_hook_with_args_until_failure): Adjust accordingly.
8874 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8875
1db5b1ad
JB
88762011-03-28 Juanma Barranquero <lekktu@gmail.com>
8877
8878 * dispextern.h (string_buffer_position): Remove declaration.
8879
8880 * print.c (strout): Remove parameter `multibyte', unused since
8881 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8882
8883 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8884 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8885 All callers changed.
8886
8887 * w32.c (_wsa_errlist): Use braces for struct initializers.
8888
8889 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8890 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8891 All callers changed.
8892 (string_buffer_position): Likewise. Also, make static (it's never
8893 used outside xdisp.c).
8894 (cursor_row_p): Remove parameter `w', unused since
8895 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8896 (decode_mode_spec): Remove parameter `precision', introduced during
8897 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8898 All callers changed.
8899
5ffb62aa
JD
89002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8901
8902 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8903
461c2ab9 89042011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8905
8906 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8907 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8908 (ns_update_auto_hide_menu_bar): New functions.
8909 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8910 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8911 ns_constrain_all_frames.
8912 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8913 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8914
5c380ffb
JD
89152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8916
8917 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8918
9af30bdf
GM
89192011-03-27 Glenn Morris <rgm@gnu.org>
8920
8921 * syssignal.h: Replace RETSIGTYPE with void.
8922 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8923 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8924 Replace SIGTYPE with void everywhere.
8925 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8926 * s/template.h (SIGTYPE): Remove commented out definition.
8927
e2abce01
JB
89282011-03-26 Eli Zaretskii <eliz@gnu.org>
8929
8930 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8931 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8932
f868cd8a
JB
89332011-03-26 Juanma Barranquero <lekktu@gmail.com>
8934
59eb0929
JB
8935 * w32.c (read_unc_volume): Use parameter `henum', instead of
8936 global variable `wget_enum_handle'.
8937
8938 * keymap.c (describe_vector): Remove parameters `indices' and
8939 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8940 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8941
f868cd8a
JB
8942 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8943
8944 * keyboard.c (timer_check): Remove parameter `do_it_now',
8945 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8946 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8947 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8948
8949 * keyboard.c (read_char):
8950 * w32menu.c (w32_menu_display_help):
8951 * xmenu.c (show_help_event, menu_help_callback):
8952 Adjust calls to `show_help_echo'.
8953
8954 * gtkutil.c (xg_maybe_add_timer):
8955 * keyboard.c (readable_events):
8956 * process.c (wait_reading_process_output):
8957 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8958
8959 * insdel.c (adjust_markers_gap_motion):
8960 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8961 (gap_left, gap_right): Don't call it.
8962
2ecf6fdb
CY
89632011-03-25 Chong Yidong <cyd@stupidchicken.com>
8964
8965 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8966 incurred during fontification.
8967
6b1f9ba4
JB
89682011-03-25 Juanma Barranquero <lekktu@gmail.com>
8969
8970 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8971 (DEFVAR_PER_BUFFER): Don't pass it.
8972
8973 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8974 (scrolling_window): Don't pass it.
8975
0f4a96b5
JB
89762011-03-25 Juanma Barranquero <lekktu@gmail.com>
8977
8978 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8979
8980 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8981 and `suffix'.
8982 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8983 of variables specific to SELinux and computation of `encoded_absname'.
8984
8985 * image.c (XPutPixel): Remove unused variable `height'.
8986
8987 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8988
8989 * unexw32.c (get_section_info): Remove unused variable `section'.
8990
8991 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8992 (system_process_attributes): Remove unused variable `sess'.
8993 (sys_read): Remove unused variable `err'.
8994
8995 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8996 (w32_wnd_proc): Remove unused variable `isdead'.
8997 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8998 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8999 (x_create_tip_frame): Remove unused variable `tem'.
9000
9001 * w32inevt.c (w32_console_read_socket):
9002 Remove unused variable `no_events'.
9003
9004 * w32term.c (x_draw_composite_glyph_string_foreground):
9005 Remove unused variable `width'.
9006
1149507c
JB
90072011-03-24 Juanma Barranquero <lekktu@gmail.com>
9008
9009 * w32term.c (x_set_glyph_string_clipping):
9010 Don't pass uninitialized region to CombineRgn.
9011
9c88f339
JB
90122011-03-23 Juanma Barranquero <lekktu@gmail.com>
9013
9014 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9015 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9016 (Fx_close_connection): Remove unused variable `i'.
9017
9018 * w32font.c (w32font_draw): Return number of glyphs.
9019 (w32font_open_internal): Remove unused variable `i'.
9020 (w32font_driver): Add missing initializer.
9021
9022 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9023 (fill_in_menu): Remove unused variable `items_added'.
9024
9025 * w32term.c (last_mouse_press_frame): Remove static global variable.
9026 (w32_clip_to_row): Remove unused variable `f'.
9027 (x_delete_terminal): Remove unused variable `i'.
9028
9029 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9030 (NOTHING): Remove unused static global variable.
9031 (uniscribe_check_otf): Remove unused variable `table'.
9032 (uniscribe_font_driver): Add missing initializers.
9033
dee091a3
JD
90342011-03-23 Julien Danjou <julien@danjou.info>
9035
9036 * term.c (Fsuspend_tty, Fresume_tty):
9037 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9038 * window.c (temp_output_buffer_show):
9039 * insdel.c (signal_before_change):
9040 * frame.c (Fhandle_switch_frame):
9041 * fileio.c (Fdo_auto_save):
9042 * emacs.c (Fkill_emacs):
9043 * editfns.c (save_excursion_restore):
9044 * cmds.c (internal_self_insert):
9045 * callint.c (Fcall_interactively):
9046 * buffer.c (Fkill_all_local_variables):
9047 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9048 Use Frun_hooks.
0f4a96b5 9049 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9050 unconditionally since it does the check itself.
dee091a3 9051
2c520ab5 90522011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9053
c9c49752
PE
9054 Fix more problems found by GCC 4.5.2's static checks.
9055
8abc3f12
PE
9056 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9057 the first time through the loop, since we know p0 < p1 then.
9058 This also avoids a gcc -Wstrict-overflow warning.
9059
a2d26660
PE
9060 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9061 leading to a memory leak, possible in functions like
9062 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9063 of objects (Bug#8318).
a2d26660 9064
916c72e9
PE
9065 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9066 that could (at least in theory) be that large.
9067
19ab8a18
PE
9068 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9069 This is less likely to overflow, and avoids undefined behavior if
9070 overflow does occur. All callers changed. Use strtoul to scan
9071 for the unsigned long integer.
b7cbbd6f
PE
9072 (pint2hrstr): Simplify and tune code slightly.
9073 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9074
f0641eff
PE
9075 * scroll.c (do_scrolling): Work around GCC bug 48228.
9076 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9077
7f650bb9
PE
9078 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9079 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9080 (validate_x_resource_name): Simplify count usage.
9081 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9082
37dd57d1
PE
9083 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9084 fail (Bug#8306).
81e56e61 9085
699979fc 9086 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9087
401bf9b4
PE
9088 * process.c (Fmake_network_process): Use socklen_t, not int,
9089 where POSIX says socklen_t is required in portable programs.
9090 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9091 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9092 (Fmake_network_process, server_accept_connection):
9093 (wait_reading_process_output, read_process_output):
9094 Likewise.
9095
b93aacde
PE
9096 * process.c: Rename or move locals to avoid shadowing.
9097 (list_processes_1, Fmake_network_process):
9098 (read_process_output_error_handler, exec_sentinel_error_handler):
9099 Rename or move locals.
4dc343ee 9100 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9101 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9102 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9103 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9104 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9105
af8a867c 9106 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9107 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9108 Include tparam.h instead, since it declares them.
af8a867c
PE
9109 * cm.h (PC): Remove extern decl; tparam.h now does this.
9110 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9111 * terminfo.c: Include tparam.h, to check interfaces.
9112 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9113 (tparam): Adjust signature to match interface in tparam.h;
9114 this removes some undefined behavior. Check that outstring and len
9115 are zero, which they always are with Emacs.
9116 * tparam.h (PC, BC, UP): New extern decls.
9117
0248044d 9118 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9119 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9120
8ff096c1 9121 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9122 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9123 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9124 (ftfont_list): Remove unused local.
49eaafba
PE
9125 (get_adstyle_property, ftfont_pattern_entity):
9126 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9127 Rename locals to avoid shadowing.
8ff096c1 9128
e2be39f6
PE
9129 * xfont.c (xfont_list_family): Mark var as initialized.
9130
c9735e30
PE
9131 * xml.c (make_dom): Now static.
9132
8f5201ae
PE
9133 * composite.c (composition_compute_stop_pos): Rename local to
9134 avoid shadowing.
b246f932
PE
9135 (composition_reseat_it): Remove unused locals.
9136 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9137 (composition_update_it): Mark var as initialized.
11b61122
PE
9138 (find_automatic_composition): Mark vars as initialized,
9139 with a FIXME (Bug#8290).
8f5201ae 9140
760fbc2c
PE
9141 character.h: Rename locals to avoid shadowing.
9142 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9143 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9144 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9145 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9146 to avoid shadowing.
9147
ff08eb85
PE
9148 * textprop.c (property_change_between_p): Remove; unused.
9149
fc7bf025
PE
9150 * intervals.c (interval_start_pos): Now static.
9151
235d7abc
PE
9152 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9153
44f230aa
SM
9154 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9155 Rename locals to avoid shadowing.
3e7d6594 9156
50060332
PE
9157 * sound.c (wav_play, au_play, Fplay_sound_internal):
9158 Fix pointer signedness.
d01f234b 9159 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9160 (wav_play): Initialize a variable to 0, to prevent undefined
9161 behavior (Bug#8278).
50060332 9162
c4fc4e30
PE
9163 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9164
918436ed
PE
9165 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9166
c939f91b
PE
9167 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9168 clobbering (Bug#8298).
b9c7f648
PE
9169 * sysdep.c (sys_subshell): Likewise.
9170 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9171
6bd8c144
PE
9172 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9173 This should get cleaned up, so that child_setup has the
9174 same signature on all platforms.
9175
7710357c 9176 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9177 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9178
c59da222
CY
91792011-03-22 Chong Yidong <cyd@stupidchicken.com>
9180
9181 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9182 not to be necessary, and produces flickering.
9183
66b87493
GM
91842011-03-20 Glenn Morris <rgm@gnu.org>
9185
9186 * config.in: Remove file.
9187
45b6f6d5
JB
91882011-03-20 Juanma Barranquero <lekktu@gmail.com>
9189
9190 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9191 are now in src/globals.h.
9192 (syms_of_minibuf): Remove spurious & from previous change.
9193
cd394be1 91942011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9195
9196 * minibuf.c (completing-read-function): New variable.
9197 (completing-read-default): Rename from completing-read.
9198 (completing-read): Call completing-read-function.
9199
b14e3e21
CY
92002011-03-19 Juanma Barranquero <lekktu@gmail.com>
9201
9202 * xfaces.c (Fx_load_color_file):
9203 Read color file from absolute filename (bug#8250).
9204
f2b726e6
JB
92052011-03-19 Juanma Barranquero <lekktu@gmail.com>
9206
9207 * makefile.w32-in: Update dependencies.
9208
09f6ff02
EZ
92092011-03-17 Eli Zaretskii <eliz@gnu.org>
9210
9211 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9212
29a6015a
PE
92132011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9214
a3a6c54e
PE
9215 Fix more problems found by GCC 4.5.2's static checks.
9216
b766f867
PE
9217 * process.c (make_serial_process_unwind, send_process_trap):
9218 (sigchld_handler): Now static.
9219
be02381c
PE
9220 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9221 That way, the code declares only the vars that it needs.
9222 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9223 * s/cygwin.h (PTY_ITERATION): Likewise.
9224 * s/darwin.h (PTY_ITERATION): Likewise.
9225 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9226
57048744
PE
9227 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9228 * process.c (allocate_pty): Don't declare stb unless it's needed.
9229
7914961c 9230 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9231 (CONSTANTLIM): Remove; unused.
9232 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9233 Define only if needed.
7914961c 9234
b3967b18
PE
9235 * unexelf.c (unexec): Name an expression,
9236 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9237 Use a different way to cause a compilation error if anyone uses
9238 n rather than nn, a way that does not involve shadowing.
73366a00 9239 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9240
29a6015a
PE
9241 * deps.mk (unexalpha.o): Remove; unused.
9242
43cfc33e 9243 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9244 * unexec.h: New file.
ce701a33
PE
9245 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9246 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9247 Depend on unexec.h.
9248 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9249 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9250 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9251 Change as necessary to match prototype in unexec.h.
ce701a33 9252
01f44d5a
PE
9253 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9254 shadowing.
4f63c6bb 9255 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9256
a6670b0b
PE
9257 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9258 Rename locals to avoid shadowing.
9259
cef2010d 9260 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9261 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9262
d4d7173a
PE
9263 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9264
f08b802a
PE
9265 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9266 warning when compiling print.c.
9267
3ddb0639
PE
9268 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9269 instead of using an uninitialized var.
5ad03b97 9270 (font_sort_entities): Mark var as initialized.
3ddb0639 9271
170a2692
PE
9272 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9273
e663c700
PE
9274 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9275 pointers to constants.
89bc529a 9276 (font_parse_fcname): Remove unused vars.
7b81e2d0 9277 (font_delete_unmatched): Now static.
ea838e10 9278 (font_get_spec): Remove; unused.
13a547c6
PE
9279 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9280 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9281 Rename or move locals to avoid shadowing.
e663c700 9282
2a80c887 9283 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9284 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9285
1384fa33 9286 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9287 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9288
8b2c52e9
PE
9289 * alloc.c (mark_backtrace): Move decl from here ...
9290 * lisp.h: ... to here, so that it can be checked.
9291
475545b5 9292 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9293 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9294 (lisp_indirect_variable): Name an expression,
9295 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9296 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9297
b1349114 9298 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9299 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9300 Use const pointer when appropriate.
b1349114 9301
a2928364
PE
9302 * lisp.h (get_system_name, get_operating_system_release):
9303 Move decls here, to check interfaces.
9304 * process.c (get_operating_system_release): Move decl to lisp.h.
9305 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9306 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9307 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9308 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9309 (Fformat_time_string, Fencode_time, Finsert_char):
9310 (Ftranslate_region_internal, Fformat):
9311 Rename or remove local vars to avoid shadowing.
9710023e 9312 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9313
a415e694
PE
9314 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9315 avoid shadowing.
9316
8ef4622d
PE
9317 * lisp.h (eassert): Check that the argument compiles, even if
9318 ENABLE_CHECKING is not defined.
9319
946f9a5b
PE
9320 * data.c (Findirect_variable): Name an expression, to avoid
9321 gcc -Wbad-function-cast warning.
112396d6 9322 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9323 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9324 (Fmake_variable_buffer_local, Fmake_local_variable):
9325 Mark variables as initialized.
52746918 9326 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9327
e5aab7e7 9328 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9329 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9330 Rename locals to avoid shadowing.
dff45157
PE
9331 (mark_stack): Move local variables into the #ifdef region where
9332 they're used.
7bc26fdb
PE
9333 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9334 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9335 needed otherwise.
9336 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9337 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9338 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9339
e5aab7e7
PE
9340 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9341 avoids undefined behavior in theory.
9342
4da60324
PE
9343 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9344
88043301
PE
9345 Use functions, not macros, for up- and down-casing (Bug#8254).
9346 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9347 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9348 to use the following functions instead of these macros.
9349 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9350 EMACS_INT, since callers assume the returned value fits in int.
9351 (upcase1): Likewise, for UPCASE_TABLE.
9352 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9353 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9354 the race-condition problem in the old DOWNCASE.
88043301 9355
19ed5445
PE
9356 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9357 Rename locals to avoid shadowing.
9358 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9359 (regex_compile, re_search_2, re_match_2_internal):
9360 Remove unused local vars.
952db0d7
PE
9361 (FREE_VAR): Rewrite so as not to use empty "else",
9362 which gcc can warn about.
da053e48 9363 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9364 (RETALLOC_IF): Define only if needed.
9365 (WORDCHAR_P): Likewise. This one is never needed, but is used
9366 only in a comment talking about a compiler bug, so put inside
9367 the #if 0 of that comment.
9368 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9369 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9370 Remove; unused.
19ed5445 9371
1f3561e4 9372 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9373 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9374 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9375
ded6f8f7
PE
9376 * search.c (simple_search): Remove unused var.
9377
dbd37a95
PE
9378 * dired.c (compile_pattern): Move decl from here ...
9379 * lisp.h: ... to here, so that it can be checked.
9380 (struct re_registers): New forward decl.
9381
7e47afad
PE
9382 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9383
85f24f61
PE
9384 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9385 All uses changed.
9386 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9387 Rename locals to avoid shadowing.
5671df8f 9388 (Fvertical_motion): Mark locals as initialized.
85f24f61 9389
181aa2be 9390 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9391 (casify_region): Mark local as initialized.
181aa2be 9392
930d429c
PE
9393 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9394
7082eac6
PE
9395 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9396 New macros, so that the caller can use some names other than
9397 gcpro1, gcpro2, etc.
9398 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9399 of the new macros.
9400 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9401 argument, for consistency with GCPRO2_VAR, etc: it is now the
9402 prefix of the variable, not the variable itself. All uses
9403 changed.
38b2c076
PE
9404 * dired.c (directory_files_internal, file_name_completion):
9405 Rename locals to avoid shadowing.
9406
15206ed9
PE
9407 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9408 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9409 dired.c's scmp function, had undefined behavior.
9410 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9411 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9412 * buffer.h: ... to here, because these macros use current_buffer,
9413 and the new implementation with inline functions needs to have
9414 current_buffer in scope now, rather than later when the macros
9415 are used.
9416 (downcase, upcase1): New static inline functions.
9417 (DOWNCASE, UPCASE1): Reimplement using these functions.
9418 This avoids undefined behavior in expressions like
9419 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9420 from race conditions in accessing the global variables
9421 case_temp1 and case_temp2.
9422 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9423 * lisp.h (case_temp1, case_temp2): Remove their decls.
9424 * character.h (ASCII_CHAR_P): Move from here ...
9425 * lisp.h: ... to here, so that the inline functions mentioned
9426 above can use them.
9427
4a6bea26
PE
9428 * dired.c (directory_files_internal_unwind): Now static.
9429
f14b7e14
PE
9430 * fileio.c (file_name_as_directory, directory_file_name):
9431 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9432 Now static.
2893f146
PE
9433 (file_name_as_directory): Use const pointers when appropriate.
9434 (Fexpand_file_name): Likewise. In particular, newdir might
9435 point at constant storage, so make it a const pointer.
fd4ead52 9436 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9437 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9438 signedness issues.
f839df0c
PE
9439 (Fset_file_times, Finsert_file_contents, auto_save_error):
9440 Rename locals to avoid shadowing.
f14b7e14 9441
5716756e 9442 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9443 (Ftry_completion, Fall_completions): Rename or remove locals
9444 to avoid shadowing.
5716756e 9445
b4c3046a
PE
9446 * marker.c (bytepos_to_charpos): Remove; unused.
9447
b45db522
PE
9448 * lisp.h (verify_bytepos, count_markers): New decls,
9449 so that gcc does not warn that these functions aren't declared.
9450
85876d07
PE
9451 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9452 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9453 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9454 (copy_text): Remove unused local var.
85876d07 9455
03d78a21 9456 * filelock.c (within_one_second): Now static.
b3dd38ab 9457 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9458
5df8f01b
PE
9459 * buffer.c (fix_overlays_before): Mark locals as initialized.
9460 (fix_start_end_in_overlays): Likewise. This function should be
9461 simplified by using pointers-to-pointers, but that's a different
9462 matter.
b1d876f1 9463 (switch_to_buffer_1): Now static.
8f54f30a
PE
9464 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9465 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9466
a70072c9 9467 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9468 Fix pointer signedness issue.
edced198
PE
9469 (sys_subshell): Mark local as volatile if checking for lint,
9470 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9471 (MAXPATHLEN): Define only if needed.
a70072c9 9472
a0977c44
PE
9473 * process.c (serial_open, serial_configure): Move decls from here ...
9474 * systty.h: ... to here, so that they can be checked.
9475
a884fdcc
PE
9476 * fns.c (get_random, seed_random): Move extern decls from here ...
9477 * lisp.h: ... to here, so that they can be checked.
9478
604efe86 9479 * sysdep.c (reset_io): Now static.
b8950c94 9480 (wait_for_termination_signal): Remove; unused.
604efe86 9481
38fc62d9
PE
9482 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9483 (copy_keymap_item, append_key, push_text_char_description):
9484 Now static.
1004a21a 9485 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9486 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9487 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9488 (describe_map_tree):
9489 Rename locals to avoid shadowing.
38fc62d9 9490
2f2650da
PE
9491 * keyboard.c: Declare functions static if they are not used elsewhere.
9492 (echo_char, echo_dash, cmd_error, top_level_2):
9493 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9494 (read_char, kbd_buffer_get_event, make_lispy_position):
9495 (make_lispy_event, make_lispy_movement, apply_modifiers):
9496 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9497 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9498 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9499 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9500 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9501
a053e86c 9502 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9503 (mark_kboards): Move decl here ...
9504 * alloc.c (mark_kboards): ... from here.
a053e86c 9505
4752793e
PE
9506 * lisp.h (force_auto_save_soon): New decl.
9507
74f10ca7 9508 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9509 (DEFINE_DUMMY_FUNCTION): New macro.
9510 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9511 Use it.
c03cd23f
PE
9512 (main): Add casts to avoid warnings
9513 if GCC considers string literals to be constants.
74f10ca7 9514
022e70d4
PE
9515 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9516
59d6fe83
PE
9517 * dbusbind.c: Pointer signedness fixes.
9518 (xd_signature, xd_append_arg, xd_initialize):
9519 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9520 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9521 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9522 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9523
78320123
PE
9524 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9525 if GCC considers string literals to be constants.
49cebcca 9526 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9527
35ac2a97
SM
95282011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9529
fb103ca9
SM
9530 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9531 (print_preprocess, print_object): New macro to fix last change.
9532
35ac2a97
SM
9533 * print.c (print_preprocess): Don't forget font objects.
9534
62973b41
JB
95352011-03-16 Juanma Barranquero <lekktu@gmail.com>
9536
9537 * emacs.c (USAGE3): Doc fixes.
9538
0e48bb22
AS
95392011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9540
9541 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9542 structure.
9543
7684e57b
JB
95442011-03-14 Juanma Barranquero <lekktu@gmail.com>
9545
9546 * lisp.h (VWindow_system, Qfile_name_history):
9547 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9548 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9549 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9550
9551 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9552 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9553
9554 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9555 * w32console.c (detect_input_pending, read_input_pending)
9556 (encode_terminal_code):
9557 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9558 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9559 (w32_system_caret_y, Qfile_name_history):
9560 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9561 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9562 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9563 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9564 * w32proc.c (Qlocal, report_file_error):
9565 * w32term.c (Vwindow_system, updating_frame):
9566 * w32uniscribe.c (initialized, uniscribe_font_driver):
9567 Remove unneeded extern declarations.
9568
2aa46d6c
CY
95692011-03-14 Chong Yidong <cyd@stupidchicken.com>
9570
c96bbc66 9571 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9572
cffc6f3b
CY
95732011-03-13 Chong Yidong <cyd@stupidchicken.com>
9574
9575 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9576 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9577 These macros can no longer be used for assignment.
9578
44f230aa
SM
9579 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9580 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9581 (record_buffer_markers, fetch_buffer_markers): New functions for
9582 recording and fetching special buffer markers.
9583 (set_buffer_internal_1, set_buffer_temp): Use them.
9584
9585 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9586
9587 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9588
9589 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9590 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9591
9592 * xdisp.c (hscroll_window_tree):
9593 (reconsider_clip_changes): Use PT instead of BUF_PT.
9594
d251f04b
EZ
95952011-03-13 Eli Zaretskii <eliz@gnu.org>
9596
9597 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9598 $(EMACS_ROOT)/lib/intprops.h.
9599
f0c77cd1
PE
96002011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9601
3eca4629
PE
9602 Fix more problems found by GCC 4.5.2's static checks.
9603
7c86ee98
PE
9604 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9605 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9606 (xg_free_frame_widgets): Make it clear that a local variable is
9607 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9608 (gdk_window_get_screen): Make it clear that this macro is needed
9609 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9610 (int_gtk_range_get_value): New function, which avoids a diagnostic
9611 from gcc -Wbad-function-cast.
9612 (xg_set_toolkit_scroll_bar_thumb): Use it.
9613 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9614 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9615 (get_utf8_string, xg_get_file_with_chooser):
9616 Rename locals to avoid shadowing.
9617 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9618
41729b81
PE
9619 * xgselect.c (xg_select): Remove unused var.
9620
f0c77cd1
PE
9621 * image.c (four_corners_best): Mark locals as initialized.
9622 (gif_load): Initialize transparent_p to zero (Bug#8238).
9623 Mark another local as initialized.
ec6cf4c6 9624 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9625
ce0ad53d 9626 * image.c (clear_image_cache): Now static.
d5d5a617 9627 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9628 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9629 (x_edge_detection): Remove unnecessary cast that
9630 gcc -Wbad-function-cast diagnoses.
2037898d 9631 (gif_load): Fix pointer signedness.
6ae141d6
PE
9632 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9633 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9634
33383987 96352011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9636
d32df629
PE
9637 Improve quality of tests for time stamp overflow.
9638 For example, without this patch (encode-time 0 0 0 1 1
9639 1152921504606846976) returns the obviously-bogus value (-948597
9640 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9641 reports time overflow. See
9642 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9643 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9644 * editfns.c: Include limits.h and intprops.h.
9645 (TIME_T_MIN, TIME_T_MAX): New macros.
9646 (time_overflow): Move earlier, to before first use.
9647 (hi_time, lo_time): New functions, for an accurate test for
9648 out-of-range times.
9649 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9650 (Fget_internal_run_time): Don't assume time_t fits in int.
9651 (make_time): Use list2 instead of Fcons twice.
9652 (Fdecode_time): More accurate test for out-of-range times.
9653 (check_tm_member): New function.
9654 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9655 (lisp_time_argument): Don't rely on undefined left-shift and
9656 right-shift behavior when checking for time stamp overflow.
8be6f318 9657
fe31d94c
PE
9658 * editfns.c (time_overflow): New function, refactoring common code.
9659 (Fformat_time_string, Fdecode_time, Fencode_time):
9660 (Fcurrent_time_string): Use it.
9661
8be6f318
PE
9662 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9663 * dired.c (make_time): Move to ...
9664 * editfns.c (make_time): ... here.
9665 * systime.h: Note the move.
9666
09d9db2c 96672011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9668
126bc0dc
YM
9669 * fringe.c (update_window_fringes): Remove unused variables.
9670
c47cbdfd
YM
9671 * unexmacosx.c (copy_data_segment): Also copy __got section.
9672 (Bug#8223)
9673
7ac80be9
EZ
96742011-03-12 Eli Zaretskii <eliz@gnu.org>
9675
c96bbc66 9676 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9677 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9678 Constify `char *' arguments and their references according to
9679 prototypes in tparam.h.
9680
ecb0f94d 9681 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9682
7ac80be9
EZ
9683 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9684 Adapt all references accordingly.
9685
9686 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9687
ef1fd07e
TT
96882011-03-11 Tom Tromey <tromey@redhat.com>
9689
9690 * buffer.c (syms_of_buffer): Remove obsolete comment.
9691
7ef4b50c
EZ
96922011-03-11 Eli Zaretskii <eliz@gnu.org>
9693
9694 * termhooks.h (encode_terminal_code): Declare prototype.
9695
9696 * msdos.c (encode_terminal_code): Don't declare prototype.
9697
9698 * term.c (encode_terminal_code): Now external again, used by
9699 w32console.c and msdos.c.
9700
44f230aa
SM
9701 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9702 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9703
4b1ec863 97042011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9705
1714f52b 9706 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9707
4b1ec863
PE
9708 * fringe.c (update_window_fringes): Mark locals as initialized
9709 (Bug#8227).
9710 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9711
524c7aa6
PE
9712 * alloc.c (mark_fringe_data): Move decl from here ...
9713 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9714 to check its interface.
9715 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9716
a5c0af81 9717 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9718 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9719 (fontset_font): Mark local as initialized.
a9a06e0b 9720 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9721
b4716021
PE
9722 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9723
811e9bac 9724 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9725 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9726 (x_own_selection, Fx_disown_selection_internal): Rename locals
9727 to avoid shadowing.
9728 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9729
7e3ab302
PE
9730 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9731 so that the caller can use some name other than gcpro1.
9732 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9733 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9734 (Fx_backspace_delete_keys_p):
9735 Use them to avoid shadowing, and rename vars to avoid shadowing.
9736 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9737 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9738 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9739 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9740 Remove unused locals.
7e3ab302
PE
9741 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9742 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9743 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9744 macros.
f78faa98 9745
e2b13473
PE
9746 * xterm.h (x_mouse_leave): New decl.
9747
77f23912
PE
9748 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9749 Remove unused functions.
cdf4ba58
PE
9750 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9751 (x_calc_absolute_position): Now static.
7411c686 9752 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9753 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9754 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9755 unless they are used.
38d0b34a
PE
9756 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9757 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9758 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9759 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9760 (x_error_catcher, x_connection_closed, x_error_handler):
9761 (x_error_quitter, xembed_send_message, x_iconify_frame):
9762 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9763 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9764 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9765
44f230aa
SM
9766 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9767 Rename or move locals to avoid shadowing.
6b463e58 9768 (tty_defined_color, merge_face_heights): Now static.
5967d051 9769 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9770 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9771 does not deduce is never used uninitialized.
73719eba
PE
9772 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9773 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9774
426994c3 9775 * terminal.c (store_terminal_param): Now static.
5489860b 9776
032f1620 9777 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9778 (set_frame_menubar): Remove unused local.
d4323972 9779 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9780 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9781 since they might point to immutable storage.
281585b0
PE
9782 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9783 since it's unused otherwise.
032f1620 9784
367c19e5 9785 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9786 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9787 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9788 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9789 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9790 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9791 does not deduce are never used uninitialized.
70739cbe 9792
07b48fa9
PE
9793 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9794
8868a238 9795 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9796 * window.c (window_loop, size_window):
9797 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9798
7e5cf297 9799 * window.c (display_buffer): Now static.
d6550a9f
PE
9800 (size_window): Mark variables that gcc -Wuninitialized
9801 does not deduce are never used uninitialized.
a586633d
PE
9802 * window.h (check_all_windows): New decl, to forestall
9803 gcc -Wmissing-prototypes diagnostic.
5b555da1 9804 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9805
f6095868
PE
9806 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9807 shadowing.
9808 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9809 Include <limits.h>.
9810 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9811 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9812 (load_charset_map): Mark variables that gcc -Wuninitialized
9813 does not deduce are never used uninitialized.
53df7c11 9814 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9815
f38b440c
PE
9816 * coding.c (coding_set_source, coding_set_destination):
9817 Use "else { /* comment */ }" rather than "else /* comment */;"
9818 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9819 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9820 a block, when the outer 'i' will do.
9821 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9822 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9823 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9824 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9825 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9826 Rename locals to avoid shadowing.
9827 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9828 * coding.c (emacs_mule_char, encode_invocation_designation):
9829 Now static, since they're not used elsewhere.
413bb2db 9830 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9831 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9832 (decode_coding_emacs_mule): Mark variables that gcc
9833 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9834 (detect_coding_iso_2022): Initialize a local variable that might
9835 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9836 this initialization is needed. (Bug#8211)
5f58e762
PE
9837 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9838 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9839 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9840 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9841 Remove unused macros.
f38b440c 9842
232b38b9 9843 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9844 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9845 * character.c (string_count_byte8): Likewise.
232b38b9 9846
fb90da1b
PE
9847 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9848 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9849
fb93dbc2
PE
9850 * chartab.c (copy_sub_char_table): Now static, since it's not used
9851 elsewhere.
5c156ace
PE
9852 (sub_char_table_ref_and_range, char_table_ref_and_range):
9853 Rename locals to avoid shadowing.
bbcd0949 9854 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9855
7d3b3862 9856 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9857 (BIDI_BOB): Remove unused macro.
7d3b3862 9858
6be7d3da
PE
9859 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9860 deduce are never used uninitialized.
c2ed9c8b 9861 * term.c (encode_terminal_code): Likewise.
6be7d3da 9862
75f8807f 9863 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9864
50938595
PE
9865 * tparam.h: New file.
9866 * term.c, tparam.h: Include it.
9867 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9868 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9869 Move these decls to tparam.h, and make them agree with what
9870 is actually in tparam.c. The previous trick of using incompatible
9871 decls in different modules does not conform to the C standard.
9872 All callers of tparam changed to use tparam's actual API.
9873 * tparam.c (tparam1, tparam, tgoto):
9874 Use const pointers where appropriate.
9875
fbceeba2
PE
9876 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9877 * cm.h (struct cm): Likewise.
9878 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9879 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9880 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9881 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9882 (turn_on_face, init_tty): Likewise.
9883 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9884
7f3f1250
PE
9885 * term.c (term_mouse_position): Rename local to avoid shadowing.
9886
e6ca6543
PE
9887 * alloc.c (mark_ttys): Move decl from here ...
9888 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9889
c40f8d15
AS
98902011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9891
9892 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9893
cfe0661d
JB
98942011-03-09 Juanma Barranquero <lekktu@gmail.com>
9895
9896 * search.c (compile_pattern_1): Remove argument regp, unused since
9897 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9898 (compile_pattern): Don't pass it.
9899
0afb4571
J
99002011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9901
9902 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9903 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9904 for ! HAVE_GTK3.
9905 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9906
9907 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9908
9909 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9910 gdk_window_get_screen, gdk_window_get_geometry,
9911 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9912 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9913 (xg_get_pixbuf_from_pixmap): New function.
9914 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9915 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9916 Call xg_get_pixbuf_from_pixmap instead of
9917 gdk_pixbuf_get_from_drawable.
9918 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9919 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9920 (xg_check_special_colors): Use GtkStyleContext and its functions
9921 for HAVE_GTK3.
9922 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9923 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9924 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9925 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9926 Call gtk_widget_get_preferred_size.
0afb4571
J
9927 (xg_frame_resized): gdk_window_get_geometry only takes 5
9928 parameters.
44f230aa
SM
9929 (xg_win_to_widget, xg_event_is_for_menubar):
9930 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9931 (xg_set_widget_bg): New function.
9932 (delete_cb): New function.
895009e1 9933 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9934 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9935 (xg_set_background_color): Call xg_set_widget_bg.
9936 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9937 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9938 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9939 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9940 if ! HAVE_GTK3.
9941 (update_frame_tool_bar): Call gtk_widget_hide.
9942 (xg_initialize): Use GDK_KEY_g.
9943
9944 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9945 if ! HAVE_GTK3
9946 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9947
9948 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9949 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9950 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9951
1c2cc4ef
JB
99522011-03-08 Juanma Barranquero <lekktu@gmail.com>
9953
9954 * w32xfns.c (select_palette): Check success of RealizePalette against
9955 GDI_ERROR, not zero.
9956
33383987 9957See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9958
9959;; Local Variables:
9960;; coding: utf-8
aac0c6e3
MR
9961;; End:
9962
acaf905b 9963 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9964
9965 This file is part of GNU Emacs.
9966
9967 GNU Emacs is free software: you can redistribute it and/or modify
9968 it under the terms of the GNU General Public License as published by
9969 the Free Software Foundation, either version 3 of the License, or
9970 (at your option) any later version.
9971
9972 GNU Emacs is distributed in the hope that it will be useful,
9973 but WITHOUT ANY WARRANTY; without even the implied warranty of
9974 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9975 GNU General Public License for more details.
9976
9977 You should have received a copy of the GNU General Public License
9978 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.