Commit auto-generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7cd4e72c
EZ
12011-12-09 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4 (Bug#10170)
5
b34d7317
YM
62011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7
8 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
9 that where the value of an _OBJC_* symbol points to is in the .bss
10 section (Bug#10240).
11
76470ad1
KH
122011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
13
14 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 15 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 16
745fff94
KH
172011-12-08 Kenichi Handa <handa@m17n.org>
18
19 * ftfont.c (get_adstyle_property): Fix previous change
20 (Bug#10233).
21
6e44397c
JB
222011-12-07 Juanma Barranquero <lekktu@gmail.com>
23
24 * w32.c (init_environment): If no_site_lisp, remove site-lisp
25 dirs from the default value of EMACSLOADPATH (bug#10208).
26
7efa6272
GM
272011-12-07 Glenn Morris <rgm@gnu.org>
28
29 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
30 installation and source directories as well. (Bug#10208)
31
f6fc4d87
CY
322011-12-06 Chong Yidong <cyd@gnu.org>
33
34 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
35
2bf26180
GM
362011-12-06 Glenn Morris <rgm@gnu.org>
37
38 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
39 as an error, not just -1. (Bug#10217)
40
3a6ad4f0
CY
412011-12-05 Chong Yidong <cyd@gnu.org>
42
43 * keyboard.c (process_special_events): New function.
44 (swallow_events, Finput_pending_p): Use it (Bug#10195).
45
75a3b399
PE
462011-12-05 Paul Eggert <eggert@cs.ucla.edu>
47
48 * coding.c (encode_designation_at_bol): Don't use uninitialized
49 local variable (Bug#9318).
50
c3c9e25e
KH
512011-12-05 Kenichi Handa <handa@m17n.org>
52
53 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
54 return Qnil (Bug#8046, Bug#10193).
55
5eb05ea3
KH
562011-12-05 Kenichi Handa <handa@m17n.org>
57
58 * coding.c (encode_designation_at_bol): New args charbuf_end and
59 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
60 (coding_set_source): Return how many bytes coding->source was
61 relocated.
62 (coding_set_destination): Return how many bytes
63 coding->destination was relocated.
64 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
65 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
66
672011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
68
69 * coding.c (CODING_CHAR_CHARSET_P): New macro.
70 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
71 macro (Bug#9318).
72
732011-12-05 Andreas Schwab <schwab@linux-m68k.org>
74
75 The following changes are to fix Bug#9318.
76
a79703f5 77 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
78 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
79 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 80 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 81
7dbda6df
JB
822011-12-05 Juanma Barranquero <lekktu@gmail.com>
83
84 * lisp.h (process_quit_flag): Fix external declaration.
85
6d5eb5b0
SM
862011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
87
88 Don't macro-inline non-performance-critical code.
89 * eval.c (process_quit_flag): New function.
90 * lisp.h (QUIT): Use it.
91
a0c3fad0
JD
922011-12-04 Jan Djärv <jan.h.d@swipnet.se>
93
94 * nsfns.m (get_geometry_from_preferences): New function.
95 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
96
6c07aac2
AS
972011-12-04 Andreas Schwab <schwab@linux-m68k.org>
98
99 * emacs.c (Qkill_emacs): Define.
100 (syms_of_emacs): Initialize it.
101 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
102 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
103 (quit_throw_to_read_char): Add parameter `from_signal'.
104 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
105 * lisp.h (QUIT): Call Fkill_emacs if requested.
106
c052ead4
JD
1072011-12-03 Jan Djärv <jan.h.d@swipnet.se>
108
109 * widget.c (update_wm_hints): Return if wmshell is null.
110 (widget_update_wm_size_hints): New function.
111
112 * widget.h (widget_update_wm_size_hints): Declare.
113
114 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
115 widget_update_wm_size_hints (Bug#10104).
116
9e49252b
EZ
1172011-12-03 Eli Zaretskii <eliz@gnu.org>
118
119 * xdisp.c (handle_invisible_prop): If the invisible text ends just
120 before a newline, prepare the bidi iterator for consuming the
121 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 122 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 123
02b16839
JL
1242011-12-02 Juri Linkov <juri@jurta.org>
125
126 * search.c (Fword_search_regexp): New Lisp function created from
127 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
128 (Fword_search_backward, Fword_search_forward)
129 (Fword_search_backward_lax, Fword_search_forward_lax):
130 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
131 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
132
0068070e
SM
1332011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
134
135 * fileio.c (Finsert_file_contents): Move after-change-function call
136 to before the "handled:" label, since all "goto handled" appear in
137 cases where the *-change-functions have already been properly called
138 (bug#10117).
139
3360a3fc
AS
1402011-12-01 Andreas Schwab <schwab@linux-m68k.org>
141
142 * keyboard.c (interrupt_signal): Don't call kill-emacs when
143 waiting for input. (Bug#10169)
144
73d6c093
EZ
1452011-11-30 Eli Zaretskii <eliz@gnu.org>
146
147 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
148 verifies glyph row's hash code--we have just reallocated the
149 glyphs, so their contents can be complete garbage. (Bug#10164)
150
febe6bea
JB
1512011-11-30 Juanma Barranquero <lekktu@gmail.com>
152
153 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
154
801a4313
EZ
1552011-11-30 Eli Zaretskii <eliz@gnu.org>
156
157 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
158 attributes are tested _before_ calling verify_row_hash, to protect
159 against GCC re-ordering of the tests. (Bug#10164)
160
2b56b87e
JD
1612011-11-29 Jan Djärv <jan.h.d@swipnet.se>
162
163 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
164
165 * xterm.c (handle_one_xevent): Only set async_visible and friends
166 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 167 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
168 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
169
dbf31225
PE
1702011-11-28 Paul Eggert <eggert@cs.ucla.edu>
171
172 Remove GCPRO-related macros that exist only to avoid shadowing locals.
173 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
174 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
175 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
176 All uses changed to use GCPRO1 etc.
177 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
178 Revert to old implementation (i.e., before 2011-03-11).
179
1305621b
YM
1802011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
181
182 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
183 of scroll runs so as to avoid assigning disabled bogus rows and
184 unnecessary graphics copy operations.
185
8c9afb46
EZ
1862011-11-27 Eli Zaretskii <eliz@gnu.org>
187
188 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
189 (snprintf) [_MSC_VER]: Redirect to _snprintf.
190 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
191 (malloc, free, realloc, calloc): Redirect to e_* only when
192 compiling Emacs.
193
194 * lisp.h (GCTYPEBITS): Move before first use.
195 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
196 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
197 this macro definition.
198
199 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
200 _MSC_VER.
201
54e9e3bf
JD
2022011-11-27 Jan Djärv <jan.h.d@swipnet.se>
203
6d5eb5b0
SM
204 * gtkutil.c (xg_create_frame_widgets):
205 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
206 present with Gtk+ 2.0.
207
83aca1cb
PE
2082011-11-26 Paul Eggert <eggert@cs.ucla.edu>
209
210 * fileio.c (Finsert_file_contents): Undo previous change; see
211 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
212
5b76caa4
PE
2132011-11-26 Paul Eggert <eggert@cs.ucla.edu>
214
215 Rename locals to avoid shadowing.
216 * fileio.c (Finsert_file_contents):
217 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
218 * process.c (wait_reading_process_output):
219 Rename inner 'proc' to 'p' to avoid shadowing.
220 Indent for consistency with usual Emacs style.
221
8c535114
EZ
2222011-11-25 Eli Zaretskii <eliz@gnu.org>
223
224 * xdisp.c (redisplay_window): If cursor row is not fully visible
225 after recentering, and scroll-conservatively is set to a large
226 number, scroll window by a few more lines to make the cursor fully
227 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
228 (start_display): Don't move to the next line if the display should
229 start at a newline that is part of a display vector or an overlay
230 string. (Bug#10119)
8c535114 231
fa4fdb5c
JL
2322011-11-24 Juri Linkov <juri@jurta.org>
233
234 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
235 after the `MagickPingImage' call. (Bug#10112)
236
90ec88df
CY
2372011-11-23 Chong Yidong <cyd@gnu.org>
238
239 * window.c (Fcoordinates_in_window_p): Accept only live windows.
240
56e2e794
MR
2412011-11-23 Martin Rudalics <rudalics@gmx.at>
242
243 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
244 making another buffer current. (Bug#10114)
245
b6e64c41
GM
2462011-11-23 Glenn Morris <rgm@gnu.org>
247
248 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
249
6b21de18
CY
2502011-11-23 Chong Yidong <cyd@gnu.org>
251
252 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
253 using it (Bug#5984).
254
b12cd789
EZ
2552011-11-22 Eli Zaretskii <eliz@gnu.org>
256
257 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
258 and header-lines, as they don't have one computed for them.
259 (Bug#10098)
260
261 * .gdbinit (prow): Make displayed values more self-explaining.
262 Add row's hash code.
263
261b6fd4
LMI
2642011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
265
266 * process.c (wait_reading_process_output): Fix asynchrounous
267 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 268 (wait_reading_process_output): Add comment and URL.
261b6fd4 269
e7cfd277
JD
2702011-11-21 Jan Djärv <jan.h.d@swipnet.se>
271
272 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
273
a9b9b7f5
CY
2742011-11-21 Chong Yidong <cyd@gnu.org>
275
276 * window.c (Fnext_window, Fprevious_window): Doc fix.
277
b0d15b4f
SM
2782011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
279
280 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
281
fe7a3057
JB
2822011-11-20 Juanma Barranquero <lekktu@gmail.com>
283
284 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
285
d2999b1a
MR
2862011-11-20 Martin Rudalics <rudalics@gmx.at>
287
288 * window.c (Fset_window_combination_limit): Rename argument
289 STATUS to LIMIT.
290 (Vwindow_combination_limit): Remove "status" from doc-string.
291
d5ff9cd0
AS
2922011-11-20 Andreas Schwab <schwab@linux-m68k.org>
293
294 * m/ibms390.h: Remove.
295 * m/ibms390x.h: Don't include "ibms390.h".
296
a5bb9bd3
SM
2972011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
298
299 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
300 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
301
cd1181db
JB
3022011-11-20 Juanma Barranquero <lekktu@gmail.com>
303
304 * casetab.c (Fset_case_table):
305 * charset.c (Fcharset_after): Fix typos.
306
615a3b8d 3072011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 308
17e845af
PE
309 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
310 Otherwise, valgrind does not work on some platforms.
311 Problem reported by Andreas Schwab in
6a0bf43d
PE
312 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
313 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
314 is set, removing the need for VIRT_ADDRESS_VARIES.
315 (PURE_P): Use a more-efficient implementation that needs just one
316 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
317 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
318 to 4 (xorl, subq, cmpq, setbe).
319 * alloc.c (pure): Always extern now, since that's the
320 VIRT_ADDR_VARIES behavior.
321 (PURE_POINTER_P): Use a single comparison, not two, for
322 consistency with the new puresize.h.
323 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
324 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
325 Remove VIRT_ADDR_VARIES no longer needed.
326
f8fe6f96
EZ
3272011-11-19 Eli Zaretskii <eliz@gnu.org>
328
329 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
330 (erase_phys_cursor, update_window_cursor, show_mouse_face)
331 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
332 behave as if the cursor position were at the window margin.
333
334 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
335 and the cursor position is out of bounds, behave as if the cursor
336 position were at the window margin. (Bug#10075)
337
df05a53c
CY
3382011-11-18 Chong Yidong <cyd@gnu.org>
339
340 * window.c (Fwindow_combination_limit): Make first argument
341 non-optional, since it is meaningless for live windows like the
342 selected window.
343
2071918e
DA
3442011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
345
346 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
347
b50a28de
SM
3482011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
349
350 * intervals.c: Fix grafting over the whole buffer (bug#10071).
351 (graft_intervals_into_buffer): Simplify.
352
015137db
EZ
3532011-11-18 Eli Zaretskii <eliz@gnu.org>
354
355 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
356 hash values of the two rows.
357 (copy_row_except_pointers): Preserve the used[] arrays and the
358 hash values of the two rows. (Bug#10035)
68c95424 359 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
360
361 * xdisp.c (row_hash): New function, body extracted from
362 compute_line_metrics.
363 (compute_line_metrics): Call row_hash, instead of computing the
364 hash code inline.
365
366 * dispnew.c (verify_row_hash): Call row_hash for computing the
367 hash code of a row, instead of duplicating code from xdisp.c.
368
369 * dispextern.h (row_hash): Add prototype.
370
a2addb04
TH
3712011-11-18 Tassilo Horn <tassilo@member.fsf.org>
372
373 * frame.c (delete_frame): Don't delete the terminal when the last
374 X frame is closed if emacs is built with GTK toolkit.
375
df85d315
JB
3762011-11-17 Juanma Barranquero <lekktu@gmail.com>
377
378 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
379
a0c2d0ae
MR
3802011-11-17 Martin Rudalics <rudalics@gmx.at>
381
382 * window.c (Vwindow_splits): Rename to
383 Vwindow_combination_resize. Suggested by Juri Linkov.
384 (Fsplit_window_internal): Use Vwindow_combination_resize instead
385 of Vwindow_splits.
386
58179cce
JB
3872011-11-16 Juanma Barranquero <lekktu@gmail.com>
388
7877f373
JB
389 * nsfns.m (Fns_font_name):
390 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 391
b6f67890
MR
3922011-11-16 Martin Rudalics <rudalics@gmx.at>
393
394 * window.h (window): Rename slot "nest" to "combination_limit".
395 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
396 (Fset_window_nest): Rename to Fset_window_combination_limit.
397 (Vwindow_nest): Rename to Vwindow_combination_limit.
398 (recombine_windows, make_parent_window, make_window)
399 (Fsplit_window_internal, saved_window)
400 (Fset_window_configuration, save_window_save): Rename all
401 occurrences of window_nest to window_combination_limit.
402
c7015153
JB
4032011-11-15 Juanma Barranquero <lekktu@gmail.com>
404
405 * image.c (imagemagick_load_image): Fix typo.
406
322ad6ec
EZ
4072011-11-14 Eli Zaretskii <eliz@gnu.org>
408
409 * xdisp.c (display_line): Move the call to
410 highlight_trailing_whitespace before the call to
411 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
412 faces of all the glyphs to compute ROW's hash value.
413 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 414
f067b8ec
JB
4152011-11-14 Juanma Barranquero <lekktu@gmail.com>
416
417 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
418 just return (bug#10044).
419
1e5b2111
EZ
4202011-11-12 Eli Zaretskii <eliz@gnu.org>
421
7ef3cbd5
EZ
422 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
423 with user-defined heap size. Bump the default size of the temacs
424 heap to 27MB, to avoid memory warning when running temacs.
425 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
426
1e5b2111
EZ
427 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
428 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
429 (verify_row_hash) [XASSERTS]: New function.
430 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
431 that the hash value of glyph rows is correct.
1e5b2111 432
89d61221
MR
4332011-11-12 Martin Rudalics <rudalics@gmx.at>
434
435 * window.h (window): Remove splits slot.
436 * window.c (Fwindow_splits, Fset_window_splits): Remove.
437 (Fdelete_other_windows_internal, make_parent_window)
438 (make_window, Fsplit_window_internal, Fdelete_window_internal)
439 (Fset_window_configuration, save_window_save): Don't deal with
440 split status of windows.
441 (saved_window): Remove splits slot.
442 (Vwindow_splits): Rewrite doc-string.
443
97f18cc8
JD
4442011-11-11 Jan Djärv <jan.h.d@swipnet.se>
445
446 * xfns.c (unwind_create_frame):
447 * nsfns.m (unwind_create_frame):
448 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
449 Vframe_list (Bug#9999).
450
22a648b4
DA
4512011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
452
0b381c7e 453 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 454
659afede
KH
4552011-11-11 Kenichi Handa <handa@m17n.org>
456
457 * callproc.c (Fcall_process): Set the member dst_multibyte of
458 process_coding.
459
9ac0394b
KH
4602011-11-11 Johan Bockgård <bojohan@gnu.org>
461
462 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
463 avoid a crash (bug#9496).
464
2fbdc249
CY
4652011-11-09 Chong Yidong <cyd@gnu.org>
466
467 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
468 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
469
ac6b1f81
PE
4702011-11-08 Paul Eggert <eggert@cs.ucla.edu>
471
472 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
473
09db192c
PE
4742011-11-08 Paul Eggert <eggert@cs.ucla.edu>
475
476 Avoid some portability problems by eschewing 'extern inline' functions.
477 The trivial performance wins aren't worth the portability hassles; see
478 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
479 et seq.
480 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
481 (window_box_width, window_box_left, window_box_left_offset)
482 (window_box_right, window_box_right_offset): Undo previous change,
483 by removing the "extern"s.
484 * intervals.c (adjust_intervals_for_insertion)
485 (adjust_intervals_for_deletion): Undo previous change,
486 making these static again.
487 (offset_intervals, temp_set_point_both, temp_set_point)
488 (copy_intervals_to_string): No longer inline.
489 * xdisp.c (window_text_bottom_y, window_box_width)
490 (window_box_height, window_box_left_offset)
491 (window_box_right_offset, window_box_left, window_box_right)
492 (window_box): No longer inline.
493
105216ed
CY
4942011-11-08 Chong Yidong <cyd@gnu.org>
495
496 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
497 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
498 Signal an error if not a live window.
105216ed
CY
499 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
500 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
501
ae9e237f
JB
5022011-11-07 Juanma Barranquero <lekktu@gmail.com>
503
504 * lisp.h (syms_of_abbrev): Remove declaration.
505 Reported by CHENG Gao <chenggao@royau.me>.
506
c7aa8333
EZ
5072011-11-07 Eli Zaretskii <eliz@gnu.org>
508
509 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
510 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
511 of temacs in GUI mode.
512
be7f5545
MR
5132011-11-07 Martin Rudalics <rudalics@gmx.at>
514
515 * window.h: Declare delete_all_child_windows instead of
516 delete_all_subwindows.
517 * window.c (Fwindow_nest, Fset_window_nest)
518 (Fset_window_new_total, Fset_window_new_normal)
519 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
520 (delete_all_subwindows): Rename to delete_all_child_windows.
521 (Fdelete_other_windows_internal, Fset_window_configuration):
522 Call delete_all_child_windows instead of delete_all_subwindows.
523 * frame.c (delete_frame): Call delete_all_child_windows instead
524 of delete_all_subwindows.
525
ca78dc43
PE
5262011-11-07 Paul Eggert <eggert@cs.ucla.edu>
527
528 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
529 This is also needed for porting to any host where GC_MARK_STACK is
530 not GC_MAKE_GCPROS_NOOPS.
531 (which_symbols): Use it.
532
a0241d01
KH
5332011-11-07 Kenichi Handa <handa@m17n.org>
534
535 * coding.c (coding_set_destination): Check coding->src_pos only
536 when coding->src_object is a buffer (bug#9910).
537
538 * process.c (send_process): Set the member src_multibyte of coding
539 to 0 (bug#9911) when sending a unibyte text.
540
541 * callproc.c (Fcall_process): Set the member src_multibyte of
542 process_coding to 0 (bug#9912).
543
a64bfdfa 5442011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
545
546 * xmenu.c (cleanup_widget_value_tree): New function.
547 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
548 calling free_menubar_widget_value_tree directly (Bug#9830).
549
cb41b32a
PE
5502011-11-06 Paul Eggert <eggert@cs.ucla.edu>
551
552 Fix some portability problems with 'inline'.
553 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
554 (window_box_width, window_box_left, window_box_left_offset)
555 (window_box_right, window_box_right_offset): Declare extern.
556 Otherwise, these inline functions do not conform to C99 and
557 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
558 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
559 * intervals.c (adjust_intervals_for_insertion)
560 (adjust_intervals_for_deletion): Now extern, because otherwise the
561 extern inline functions 'offset_intervals' couldn't refer to it.
562 (static_offset_intervals): Remove.
563 (offset_intervals): Rewrite using the old contents of
564 static_offset_intervals. The old version didn't conform to C99
565 because an extern inline function contained a reference to an
566 identifier with static linkage.
567
b7041366
AS
5682011-11-06 Andreas Schwab <schwab@linux-m68k.org>
569
570 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
571 GC.
572
88a37c4d
EZ
5732011-11-06 Eli Zaretskii <eliz@gnu.org>
574
575 * xdisp.c (init_iterator, reseat_to_string): Don't set the
576 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
577 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
578 return Qleft_to_right.
579
49745b39
CY
5802011-11-06 Chong Yidong <cyd@gnu.org>
581
582 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
583 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
584 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
585 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
586 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
587 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
588 (Fwindow_vscroll): Doc fix.
589 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
590 argument, since it makes no sense to pass a live window and for
591 consistency with window-child.
592
1f05cd82
CS
5932011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
594
595 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
596 support MSVC.
597
22610910
JR
5982011-11-05 Jason Rumney <jasonr@gnu.org>
599
600 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
601 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
602 fonts (Bug#6029).
603 (add_font_entity_to_list): Fix logic errors in mixed boolean and
604 bitwise arithmetic preventing use of unicode-sip and non-truetype
605 opentype fonts.
606
a06776b2
EZ
6072011-11-05 Eli Zaretskii <eliz@gnu.org>
608
3ad924ba
EZ
609 * s/ms-w32.h (fstat, stat, utime): Move redirections to
610 "emacs"-only part.
611
a06776b2
EZ
612 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
613 initialization code to keep similarity to xfns.c after changes
614 from 2011-11-05.
615
c9e7db78
JD
6162011-11-05 Jan Djärv <jan.h.d@swipnet.se>
617
a97f8f3f
JD
618 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
619 (unwind_create_frame): New function (Bug#9943).
620 (Fx_create_frame): Restructure code to be more similar to the one in
621 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
622 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
623 Move terminal->reference_count++ just before making the frame official
624 (Bug#9943).
625
626 * nsterm.m (x_free_frame_resources): New function.
627 (x_destroy_window): Move code to x_free_frame_resources.
628
c9e7db78 629 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
630 (Fx_create_frame, x_create_tip_frame):
631 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
632 official. Move initialization of image_cache_refcount and
633 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
634
a6fc3b5c
EZ
6352011-11-05 Eli Zaretskii <eliz@gnu.org>
636
637 Support MSVC build with newer versions of Visual Studio.
638 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
639 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
640 nt/gmake.defs.
641
642 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
643 which are not supported by MSVC.
644 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
645 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
646 bitfields.
647 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
648 types in bitfields.
649 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
650
651 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
652
58179cce 6532011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
654
655 Support MSVC build with newer versions of Visual Studio.
656 * w32.c: Don't include w32api.h for MSVC.
657 (init_environment) [_MSC_VER]: Call sys_access, not _access.
658
659 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
660 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
661 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
662 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
663 e_* cousins.
664 (alloca) [_MSC_VER]: Define to _alloca.
665
666 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
667
668 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
669
a58c13ed
EZ
6702011-11-04 Eli Zaretskii <eliz@gnu.org>
671
672 * xdisp.c (note_mouse_highlight): If either of
673 previous/next-single-property-change returns nil, treat that as
674 the beginning or the end of the buffer. (Bug#9955)
675
fe0b6370
JD
6762011-11-04 Jan Djärv <jan.h.d@swipnet.se>
677
a58c13ed 678 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
679 label is not null (Bug#9951).
680 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
681 may be NULL.
682
89bd5ee1
EZ
6832011-11-04 Eli Zaretskii <eliz@gnu.org>
684
685 * window.c (Fwindow_body_size): Mention in the doc string that the
686 return value is in frame's canonical units. (Bug#9949)
687
84c3edb9
EZ
6882011-11-03 Eli Zaretskii <eliz@gnu.org>
689
4e2fb5c7
EZ
690 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
691
84c3edb9 692 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 693 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 694 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 695
bc17a887
EZ
6962011-11-01 Eli Zaretskii <eliz@gnu.org>
697
698 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
699 Don't stop backward scan on the continuation glyph, even though
700 its CHARPOS is positive.
6d5eb5b0
SM
701 (mouse_face_from_buffer_pos, note_mouse_highlight):
702 Rename cover_string to disp_string.
bc17a887 703
4ee88440
MR
7042011-11-01 Martin Rudalics <rudalics@gmx.at>
705
706 * window.c (temp_output_buffer_show): Don't use
707 Vtemp_buffer_show_specifiers.
708 (Vtemp_buffer_show_specifiers): Remove unused variable.
709
c2ff3c02
EZ
7102011-10-30 Eli Zaretskii <eliz@gnu.org>
711
712 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
713 past the beginning of the current glyph matrix.
714
58179cce 7152011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
716
717 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
718 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
719 HAVE_GTK3 (Bug#9869).
b77a6a7f 720
3b574623
JD
721 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
722 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
723
b77a6a7f
JD
724 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
725
726 * xterm.c: Declare x_handle_net_wm_state to return int.
727 (handle_one_xevent): Check if we are iconified but don't have
728 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
729 (get_current_wm_state): Return non-zero if not hidden,
730 check for _NET_WM_STATE_HIDDEN (Bug#9893).
731 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
732 (x_handle_net_wm_state): Return what get_current_wm_state returns.
733 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
734
196e41e4
PE
7352011-10-29 Paul Eggert <eggert@cs.ucla.edu>
736
737 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
738 so that this new function doesn't get optimized away by a
739 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
740
021f2e1a
AS
7412011-10-29 Andreas Schwab <schwab@linux-m68k.org>
742
743 * frame.h (MOUSE_HL_INFO): Remove excess parens.
744
8b058d44
EZ
7452011-10-29 Eli Zaretskii <eliz@gnu.org>
746
747 Fix the `xbytecode' command.
748 * .gdbinit (xprintbytestr): New command.
b50a28de 749 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
750 (xbytecode): Print the byte-code string as well.
751
4452fb80
EZ
7522011-10-29 Kim Storm <storm@cua.dk>
753
8b058d44
EZ
754 * alloc.c (which_symbols): New function.
755
21b72067
AS
7562011-10-29 Andreas Schwab <schwab@linux-m68k.org>
757
758 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
759 line. (Bug#9903)
760
83ed7b5c
GM
7612011-10-29 Glenn Morris <rgm@gnu.org>
762
763 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
764 Not clear what it was for, and it causes various bugs. (Bug#9839)
765
5a7a728b
EZ
7662011-10-28 Eli Zaretskii <eliz@gnu.org>
767
768 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
769 possible random value that matches one of those tested as
770 condition to clear the mouse face.
771
d3d0842f
CY
7722011-10-28 Chong Yidong <cyd@gnu.org>
773
774 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
775
31b39d13
DN
7762011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
777
778 * window.c (make_window): Initialize phys_cursor_on_p.
779
9aba6043
SM
7802011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
781
782 * lisp.h (struct Lisp_Symbol): Update comments.
783
c20992f4
JB
7842011-10-28 Juanma Barranquero <lekktu@gmail.com>
785
786 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
787
db4f02f2
EZ
7882011-10-28 Eli Zaretskii <eliz@gnu.org>
789
790 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
791 <oslsachem@gmail.com> for helping to debug this.
792
793 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
794 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
795 (g_b_init_get_glyph_outline_w): New static variables.
796 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
797 (GetGlyphOutlineW_Proc): New typedefs.
798 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
799 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
800 New functions.
801 (w32font_open_internal, compute_metrics):
802 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
803 instead of calling the "wide" APIs directly.
804
805 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
806
807 * w32.h (syms_of_w32font): Add prototype.
808
87e68db4
JB
8092011-10-27 Juanma Barranquero <lekktu@gmail.com>
810
811 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
812 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
813 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
814 (Fmove_to_window_line): Doc fix.
815
435c1d67
CY
8162011-10-27 Chong Yidong <cyd@gnu.org>
817
818 * process.c (make_process): Set gnutls_state to NULL.
819
820 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
821 non-NULL, regardless of GNUTLS_INITSTAGE.
822 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
823 an error. Set process slots as soon as we allocate them.
824
825 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
826
9c6c6f49
CY
8272011-10-27 Chong Yidong <cyd@gnu.org>
828
9aba6043
SM
829 * gnutls.c (emacs_gnutls_deinit): New function.
830 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
831 (Fgnutls_deinit, Fgnutls_boot): Use it.
832
833 * process.c (make_process): Initialize GnuTLS credentials to NULL.
834 (deactivate_process): Call emacs_gnutls_deinit.
835
657d08d3
JB
8362011-10-27 Juanma Barranquero <lekktu@gmail.com>
837
838 * image.c (x_create_x_image_and_pixmap):
839 * w32.c (sys_rename, w32_delayed_load):
840 * w32font.c (fill_in_logfont):
841 * w32reg.c (x_get_string_resource): Silence compiler warnings.
842
5430d399
JB
8432011-10-26 Juanma Barranquero <lekktu@gmail.com>
844
845 * w32fns.c (w32_default_color_map): New function,
846 extracted from Fw32_default_color_map.
a7ef684b 847 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 848
fe0055fa
PE
8492011-10-25 Paul Eggert <eggert@cs.ucla.edu>
850
851 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
852
e6346438
SM
8532011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
854
855 * keyboard.c (test_undefined): New function (bug#9751).
856 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
857
e112cc37
ET
8582011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
859
860 * sysdep.c (init_sys_modes): Fix the check for the controlling
861 terminal (Bug#6649).
862
7b5d6677
EZ
8632011-10-20 Eli Zaretskii <eliz@gnu.org>
864
865 * dispextern.h (struct bidi_it): New member next_en_type.
866
867 * bidi.c (bidi_line_init): Initialize the next_en_type member.
868 (bidi_resolve_explicit_1): When next_en_pos is valid for the
869 current character, check also for next_en_type being WEAK_EN.
870 (bidi_resolve_weak): Don't enter the expensive loop if the current
871 position is before next_en_pos. Record the bidi type of the first
872 non-ET, non-BN character we find, in addition to its position.
873 (bidi_level_of_next_char): Invalidate next_en_type when
874 next_en_pos is over-stepped.
875
7da0b018
PE
8762011-10-20 Paul Eggert <eggert@cs.ucla.edu>
877
878 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
879 * editfns.c: Rewrite current-time-zone so that it invokes
880 the equivalent of (format-time-string "%Z") to get the time zone name.
881 This fixes a bug when the time zone name contains characters that
882 need converting from the system time locale to Emacs internal format.
883 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
884 that patch fixed format-time-string to do the conversion, but
885 I forgot to fix current-time-zone.
886 (format_time_string): New function, containing most of
887 what Fformat_time_string used to contain.
888 (Fformat_time_string): Rewrite in terms of format_time_string.
889 This doesn't change this function's behavior.
890 (current-time-zone): Rewrite to use format_time_string.
891 This fixes the bug reported by Michael Schierl in
892 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
893 Jason Rumney's 2007-06-07 change worked around this bug, but
894 didn't fix it.
895 * systime.h (tzname, timezone): Remove no-longer-used declarations.
896
8547b010
EZ
8972011-10-19 Eli Zaretskii <eliz@gnu.org>
898
899 * xdisp.c (start_display): If the character at POS is displayed
900 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
901 (try_window_reusing_current_matrix): If a line ends in a display
902 vector or the next line starts in a display vector, continue
903 redrawing the window even though the character position of
904 start_row was reached.
8547b010
EZ
905 (Bug#9771, part 2)
906
4e948d15
CY
9072011-10-18 Chong Yidong <cyd@gnu.org>
908
909 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
910 with nobreak-char-display too.
911
4787455f
EZ
9122011-10-18 Eli Zaretskii <eliz@gnu.org>
913
914 Fix part 3 of bug#9771.
915 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
916 (bidi_resolve_neutral): Don't enter the expensive loop looking for
917 non-neutral characters if the current character is a paragraph
918 separator (a.k.a. Newline). This avoids running the same
919 expensive loop twice, once when we consume the preceding newline
920 and the other time when the line actually needs to be displayed.
921 Avoid the loop when we see neutrals on the base embedding level
922 following a character whose directionality is the same as the
923 paragraph's. This avoids running the expensive loop when a line
924 ends in a long sequence of neutrals, like control characters.
925 Add assertion against STRONG_AL type. Slightly rearrange code
926 that determines the type of a neutral given the first non-neutral
927 that follows it.
928 (bidi_level_of_next_char): Set next_en_pos to zero when
929 invalidating its info.
930
2c91f553
EZ
9312011-10-17 Eli Zaretskii <eliz@gnu.org>
932
933 * xdisp.c (push_display_prop): Determine whether to record string
934 or buffer position by IT->string, not by IT->method. Allow
935 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
936 (move_it_vertically_backward): Don't look for character position
937 immediately after the newline when in a continuation line.
938 (Bug#9771, part 1)
2c91f553 939
c7b08b0d
MR
9402011-10-15 Martin Rudalics <rudalics@gmx.at>
941
942 * window.c (coordinates_in_window): Rewrite and delabelize
943 vertical border check. (Bug#5357) (Bug#9618)
944
6b02f655
SM
9452011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
946
947 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
948 errors in XSetWindowBorder (bug#9310).
949
81d40c92
DA
9502011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
951
952 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
953 avoid crash when xmalloc overrun checking is enabled.
954
d4172c3b
EZ
9552011-10-13 Eli Zaretskii <eliz@gnu.org>
956
957 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
958 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
959 cursor motion with <left> and <right> arrow keys.
960
961 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
962 some callers set that themselves.
963
b00eea75
EZ
9642011-10-12 Eli Zaretskii <eliz@gnu.org>
965
966 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
967 display string and the previous row comes from the same string and
968 is empty. (Bug#9739) (Bug#9738)
969
8fe012c4
SM
9702011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
971
972 * doc.c (get_doc_string): Encode file name (bug#9735).
973
0074aef2
EZ
9742011-10-12 Eli Zaretskii <eliz@gnu.org>
975
79beb178
EZ
976 * bidi.c (bidi_level_of_next_char):
977 * xdisp.c (get_visually_first_element): Remove old incorrect
978 comments regarding the Unicode Line Separator character.
979
0074aef2
EZ
980 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
981
6e4b3fbe
DA
9822011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
983
984 * alloc.c (Fgc_status): Do not access beyond zombies array
985 boundary if nzombies > MAX_ZOMBIES.
986 * alloc.c (dump_zombies): Add missing format specifier.
987
0324f3af
PE
9882011-10-12 Paul Eggert <eggert@cs.ucla.edu>
989
b5525cac
PE
990 * xdisp.c (set_cursor_from_row): Simplify conditionals,
991 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
992
0324f3af
PE
993 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
994 Some packages use them to denote characters with modifiers.
995
e9b5f888
AS
9962011-10-11 Andreas Schwab <schwab@linux-m68k.org>
997
998 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
999 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1000 matching a pp-number. Rename parameter var to var1.
1001
127827c0
SM
10022011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1003
1004 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1005
c8fd3bd0
GM
10062011-10-08 Glenn Morris <rgm@gnu.org>
1007
1008 * callint.c (Fcall_interactively): Give a more explicit error for the
1009 'c' case with a non-character input. (Bug#8479)
1010
352ec8ff
EZ
10112011-10-08 Eli Zaretskii <eliz@gnu.org>
1012
03669ccb
EZ
1013 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1014 lines.
7061c986
EZ
1015 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1016 lines that are hscrolled on the left.
03669ccb 1017
352ec8ff
EZ
1018 * dispnew.c (buffer_posn_from_coords): Account for a possible
1019 presence of header-line. (Bug#4426)
1020
a66cfb1c
SM
10212011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1022
6b02f655
SM
1023 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1024 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1025
7c5ee88e
PE
10262011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1027
1028 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1029 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1030 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1031 this makes Emacs dump core during garbage collection on rare
1032 occasions. sizeof is obviously inferior to offsetof here, so
1033 stick with offsetof.
1034 (GC_POINTER_ALIGNMENT): New macro.
1035 (mark_memory): Omit 3rd (offset) arg; caller changed.
1036 Don't assume EMACS_INT alignment is the same as pointer alignment.
1037
df1bbe5b
SM
10382011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1039
1040 * keyboard.c (read_key_sequence_remapped): New var.
1041 (read_key_sequence): Compute remapping in the right buffer.
1042 (command_loop_1): Use read_key_sequence's remapping directly.
1043
51553db6
SM
10442011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1045
32c1fffd
SM
1046 * dired.c (file_name_completion): Don't expand file name.
1047 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1048 before checking file name handler.
1049
51553db6
SM
1050 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1051 they've been requested explicitly (bug#9591).
1052
b6bd1599 10532011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1054
1055 * keymap.c (Fsingle_key_description): Use make_specified_string
1056 instead of build_string to build string from push_key_description.
1057 (Bug#5193)
1058
f701dc2a
PE
10592011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1060
4222c55d
PE
1061 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1062 This fixes a Y2038 bug on 64-bit hosts.
1063 * buffer.c (reset_buffer):
1064 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1065 (Fclear_buffer_auto_save_failure):
1066 Use 0, not -1, to represent an unset failure time, since time_t
1067 might not be signed.
1068
f701dc2a
PE
1069 Remove dependency on glibc malloc internals.
1070 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1071 Move back here from lisp.h, but with their new implementations.
1072 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1073 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1074 * charset.c (charset_table_init): New static var.
1075 (syms_of_charset): Use it instead of xmalloc. This removes a
1076 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1077 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1078 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1079 Move back to alloc.c.
1080 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1081 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1082
9ceebf39
JD
10832011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1084
1085 * nsterm.m (windowDidResize): Call x_set_window_size only when
1086 ns_in_resize is true. Otherwise set pixelwidth/height and
1087 call change_frame_size (Bug#9628).
1088
cb993c58
PE
10892011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1090
3930c88b
PE
1091 Port --enable-checking=all to Fedora 14 x86-64.
1092 * charset.c (syms_of_charset): Also account for glibc malloc's
1093 internal overhead when calculating the initial malloc maximum.
1094
cb993c58
PE
1095 Port --enable-checking=all to Fedora 14 x86.
1096 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1097 Move to lisp.h.
1098 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1099 (overrun_check_realloc, overrun_check_free):
1100 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1101 That way, xmalloc returns a properly-aligned pointer even if
1102 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1103 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1104 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1105 into account when calculating the initial malloc maximum.
1106 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1107 Move here from alloc.c, so that charset.c can use it too.
1108 Properly align; the old code wasn't right for common 32-bit hosts
1109 when configured with --enable-checking=all.
1110 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1111 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1112
31bed486
EZ
11132011-09-29 Eli Zaretskii <eliz@gnu.org>
1114
04c70788 1115 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1116 use EDOM.
1117
fbcaa2f3
EZ
11182011-09-28 Eli Zaretskii <eliz@gnu.org>
1119
1120 * xdisp.c (compute_display_string_end): If there's no display
1121 string at CHARPOS, return -1.
1122
1123 * bidi.c (bidi_fetch_char): When compute_display_string_end
1124 returns a negative value, treat the character as a normal
1125 character not covered by a display string. (Bug#9624)
1126
a239d4e9
JB
11272011-09-28 Juanma Barranquero <lekktu@gmail.com>
1128
1129 * lread.c (Fread_from_string): Fix typo in docstring.
1130
88652fd5
EZ
11312011-09-27 Eli Zaretskii <eliz@gnu.org>
1132
1133 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1134 newline, reseat the iterator instead of bidi-iterating there one
1135 character at a time. (Bug#9610)
32c1fffd
SM
1136 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1137 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1138
ed497dd4
AS
11392011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1140
1141 * lread.c (readevalloop): Use correct code for NBSP.
1142 (read1): Likewise. (Bug#9608)
1143
b2bf61aa
MA
11442011-09-25 Michael Albinus <michael.albinus@gmx.de>
1145
1146 * dbusbind.c (Fdbus_register_signal): When service is not
1147 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1148
32bbb17c
GM
11492011-09-25 Glenn Morris <rgm@gnu.org>
1150
1151 * buffer.c (truncate-lines): Doc fix.
1152
94e0933e
CY
11532011-09-24 Chong Yidong <cyd@stupidchicken.com>
1154
1155 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1156 (Fset_window_next_buffers): Doc fix.
1157
cddde921
GM
11582011-09-24 Glenn Morris <rgm@gnu.org>
1159
1160 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1161
1260aef1
PE
11622011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1163
25b4bfa0
PE
1164 Fix minor problems found by static checking.
1165 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1166 * indent.c (Fvertical_motion): Fix == vs = typo.
1167
e3cbd34b
EZ
11682011-09-24 Eli Zaretskii <eliz@gnu.org>
1169
a66cfb1c
SM
1170 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1171 Default value is now t. Doc fix.
6bf7006f 1172
e3cbd34b 1173 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1174 logic when moving up, not only when moving down. Fix the
e3cbd34b 1175 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1176 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1177
1178 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1179 CHARPOS is covered by a display string which includes newlines.
1180 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1181 is covered by a display string with embedded newlines.
1182
a3de0cbd
MA
11832011-09-24 Michael Albinus <michael.albinus@gmx.de>
1184
1185 * dbusbind.c (Fdbus_register_signal): Add match rule to
1186 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1187 (Fdbus_register_method, Vdbus_registered_objects_table):
1188 Fix docstring.
a3de0cbd 1189
b260039d
JM
11902011-09-24 Jim Meyering <meyering@redhat.com>
1191
32c1fffd 1192 do not ignore write error for any output size
b260039d
JM
1193 The previous change was incomplete.
1194 While it makes emacs --batch detect the vast majority of stdout
1195 write failures, errors were still ignored whenever the output size is
1196 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1197 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1198 && echo FAIL: ignored write error
1199 FAIL: ignored write error
1200 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1201 && echo FAIL: ignored write error
1202 FAIL: ignored write error
1203 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1204
8eca8a7c
AS
12052011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1206
1207 * emacs.c (Fkill_emacs): In noninteractive mode exit
1208 non-successfully if a write error occurred on stdout. (Bug#9574)
1209
3341db62
EZ
12102011-09-21 Eli Zaretskii <eliz@gnu.org>
1211
1212 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1213 the xassert test.
1214
1215 * dispextern.h (struct it): Update the comment documenting what
1216 can it->OBJECT be.
1217
8c203dbf
EZ
12182011-09-20 Eli Zaretskii <eliz@gnu.org>
1219
1220 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1221 a display string, extend search for cursor position to end of row.
1222 (find_row_edges): If the row ends in a newline from a display
1223 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1224 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1225 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1226 non-empty line. Fixes confusing cursor motion with arrow keys at
1227 the beginning of a line that starts with whitespace.
8c203dbf 1228
a4824228
LMI
12292011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1230
1231 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1232 (bug#9493).
1233
33ed493b
CY
12342011-09-18 Chong Yidong <cyd@stupidchicken.com>
1235
1236 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1237 boolean (Bug#9154).
1238
56cd55c8
EZ
12392011-09-18 Eli Zaretskii <eliz@gnu.org>
1240
1241 * xdisp.c (display_line): Record maximum and minimum buffer
1242 positions even if no glyphs were produced (e.g., by a zero-width
1243 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1244 buffer positions that will be removed from the glyph row because
1245 they don't fit.
c02dcedf
EZ
1246 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1247 column is beyond frame width: don't subtract 1 "pixel" when
1248 computing width of the stretch.
3e62b7e0
EZ
1249 (reseat_at_next_visible_line_start): Undo the change made on
1250 2011-09-17 that saved paragraph information and restored it after
1251 the call to `reseat'. (Bug#9545)
56cd55c8 1252
5ed99d36 12532011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1254
1255 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1256 and turn window cursor on if cleared (Bug#9415).
1257
5ed99d36 12582011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1259
1260 * search.c (boyer_moore): Take unibyte characters from pattern
1261 literally. (Bug#9458)
1262
9bade7b2
EZ
12632011-09-18 Eli Zaretskii <eliz@gnu.org>
1264
1265 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1266
e5e9d610
PE
12672011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1268
87e4427a
PE
1269 Fix minor problem found by static checking.
1270 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1271 initialized, to pacify gcc -Wuninitialized.
1272
e5e9d610
PE
1273 * fileio.c: Report proper errno when syscall falls.
1274 (Finsert_file_contents): Save and restore errno,
1275 so that report_file_error outputs the correct diagnostic.
1276 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1277
a1674f0b
EZ
12782011-09-18 Eli Zaretskii <eliz@gnu.org>
1279
1280 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1281
fbfb6dd4
EZ
12822011-09-17 Eli Zaretskii <eliz@gnu.org>
1283
1284 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1285 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1286
bb187662
EZ
12872011-09-17 Eli Zaretskii <eliz@gnu.org>
1288
1137e8b8 1289 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1290 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1291
1292 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1293 (bidi_find_paragraph_start): Search back for paragraph beginning
1294 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1295 (bidi_move_to_visually_next): Only trigger paragraph-related
1296 computations when the last character is a newline or at EOB, not
1297 just any NEUTRAL_B. (Bug#9470)
1298
bb187662
EZ
1299 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1300 truncated lines if point is covered by a display string. (Bug#9524)
1301
2e621251
PE
13022011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1305 (cons_to_x_long): New function.
1306 (lisp_data_to_selection_data): Use it. Correct the test for
1307 short-versus-long data; it was negated. Break out of vector
1308 loop, for efficiency, when a long datum is discovered.
1309
91a15bc6
SM
13102011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1311
1312 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1313
b41c3a35
EZ
13142011-09-16 Eli Zaretskii <eliz@gnu.org>
1315
1316 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1317 GCC PR/17406) by declaring this function with external scope.
1318
7812ba2d
PE
13192011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1322 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1323
cf7edc2a
AS
13242011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1325
1326 * editfns.c (Fformat): Correctly handle text properties on "%%".
1327
bd01620e
EZ
13282011-09-15 Eli Zaretskii <eliz@gnu.org>
1329
1330 * xterm.c (x_draw_composite_glyph_string_foreground):
1331 * w32term.c (x_draw_composite_glyph_string_foreground):
1332 * term.c (encode_terminal_code):
1333 * composite.c (composition_update_it, get_composition_id):
1334 * xdisp.c (get_next_display_element)
1335 (fill_composite_glyph_string): Add comments about special meaning
1336 of TAB characters in a composition.
1337
a02719a3
PE
13382011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1341 This occurs when processing a multibyte format.
1342 Problem reported by Wolfgang Jenker.
a02719a3 1343
72589a3c
JB
13442011-09-15 Johan Bockgård <bojohan@gnu.org>
1345
1346 * xdisp.c (try_cursor_movement): Only check for exact match if
1347 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1348
1c14176c
PE
13492011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1350
1351 Remove unused external symbols.
1352 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1353 * xdisp.c (calc_pixel_width_or_height): Now static.
1354 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1355 * indent.c (check_display_width):
1356 * w32term.c: Fix comment to match code.
1357 * xterm.c, xterm.h (x_catching_errors): Remove.
1358
d2eea5b5
PE
13592011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 * xselect.c: Use signed conversions more consistently (Bug#9498).
1362 (selection_data_to_lisp_data): Assume incoming selection data are
1363 signed integers, not unsigned. This is to be consistent with
1364 outgoing selection data, which was modified to use signed integers
1365 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1366 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1367 expects long, not unsigned long.
1368
46888499
EZ
13692011-09-14 Eli Zaretskii <eliz@gnu.org>
1370
1371 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1372 computation of loop end. Reported by Johan Bockgård
1373 <bojohan@gnu.org>.
1374
ef8ef9fb
CY
13752011-09-13 Chong Yidong <cyd@stupidchicken.com>
1376
1377 * frame.c (Fother_visible_frames_p): Function deleted.
1378
fa819fed
EZ
13792011-09-12 Eli Zaretskii <eliz@gnu.org>
1380
1381 * indent.c (compute_motion): Process display vector front to back
1382 rather than the other way around. (Bug#2496)
1383
2ba8e008
SM
13842011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1385
1386 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1387
20f53c69
CY
13882011-09-11 Chong Yidong <cyd@stupidchicken.com>
1389
1390 * minibuf.c (Fread_from_minibuffer): Doc fix.
1391
d562d7a4
EZ
13922011-09-11 Eli Zaretskii <eliz@gnu.org>
1393
1394 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1395 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1396
1c4d7f3d
LMI
13972011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1398
1399 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1400 value for non-existent files.
1401
b885bf36
EZ
14022011-09-11 Eli Zaretskii <eliz@gnu.org>
1403
1404 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1405 set its "size" to -1. This will set the modtime_size field of
1406 the corresponding buffer to -1, which is what
1407 verify-visited-file-modtime expects for files that do not exist.
1408 (Bug#9139)
1409
6612f0bf
PE
14102011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1411
1412 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1413 here ...
1414 * lisp.h: ... from here. push_key_description is no longer
1415 defined in keyboard.c, so its declaration should not be in
1416 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1417 logically belongs with push_key_description.
1418
dfb3f755
PE
14192011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1420
1421 * buffer.h: Include <sys/types.h> instead of <time.h>.
1422 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1423 Problem reported by Herbert J. Skuhra.
1424
3134906c
LMI
14252011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1426
1427 * xml.c (parse_region): Make the parsing work for
1428 non-comment-starting XML files again (bug#9144).
1429
8d903f4e
AS
14302011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1431
1432 * image.c (gif_load): Fix calculation of bottom and right corner.
1433 (Bug#9468)
1434
80ad64f4
EZ
14352011-09-10 Eli Zaretskii <eliz@gnu.org>
1436
1437 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1438 redisplay in small windows.
1439
208a048d
EZ
14402011-09-09 Eli Zaretskii <eliz@gnu.org>
1441
1442 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1443
9b1c252e
MR
14442011-09-08 Martin Rudalics <rudalics@gmx.at>
1445
1446 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1447 Operate on live windows only.
1448
2949f33b
JB
14492011-09-08 Juanma Barranquero <lekktu@gmail.com>
1450
1451 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1452
e08dcafd
EZ
14532011-09-07 Eli Zaretskii <eliz@gnu.org>
1454
1455 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1456 only under bidi iteration.
1457
115b96bd
JD
14582011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1459
1460 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1461
c8199d0f
PE
14622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1463
1464 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1465 Without this fix, the command to link temacs failed due to an
1466 undefined symbol __builtin_isnan. This is because
1467 /usr/include/iso/math_c99.h #defines isnan(x) to
1468 __builtin_isnan(x), but the bundled gcc, which identifies itself
1469 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1470 a __builtin_isnan.
1471 * floatfns.c (isnan): #undef, and then #define to a clone of
1472 what's in data.c.
1473 (Fisnan): Always define, since it's always available now.
1474 (syms_of_floatfns): Always define isnan at the Lisp level.
1475
e39b275c 14762011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1477
1478 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1479
b2db44d9 14802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1481
f4af5137 1482 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1483 The previous code assumed that file offsets (off_t values) fit in
1484 EMACS_INT variables, which is not true on typical 32-bit hosts.
1485 The code messed up by falsely reporting buffer overflow in cases
1486 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1487 when "big" contains more than 2**29 bytes, even though this
1488 inserts just one byte and does not overflow the buffer.
1489 (Finsert_file_contents): Store file offsets as off_t
1490 values, not as EMACS_INT values. Check for overflow when
1491 converting between EMACS_INT and off_t. When checking for
1492 buffer overflow or for overlap, take the offsets into account.
1493 Don't use EMACS_INT for small values where int suffices.
1494 When checking for overlap, fix a typo: ZV was used where
1495 ZV_BYTE was intended.
1496 (Fwrite_region): Don't assume off_t fits into 'long'.
1497 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1498
ecfc0a49
MA
14992011-09-05 Michael Albinus <michael.albinus@gmx.de>
1500
1501 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1502
6511acf2 15032011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1504
0999621a 1505 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1506
1507 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1508 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1509 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1510 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1511 (modify_event_symbol): Do not assume that the length of
1512 name_alist_or_stem is safe to alloca and fits in int.
1513 (Fexecute_extended_command): Likewise for function name and binding.
1514 (Frecursion_depth): Wrap around reliably on integer overflow.
1515 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1516 since some callers pass EMACS_INT values.
1517 (Fsingle_key_description): Don't crash if symbol name contains more
1518 than MAX_ALLOCA bytes.
1519 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1520 (get_minibuffer): Arg is now EMACS_INT, not int.
1521 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1522 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1523 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1524
2be7d702
PE
1525 * dbusbind.c (signature_cat): New function.
1526 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1527 Do not overrun buffer; instead, report string overflow.
1528
9d1df220
PE
1529 * dispnew.c (add_window_display_history): Don't overrun buffer.
1530 Truncate instead; this is OK since it's just a log.
1531
33ef5c64
PE
1532 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1533 even if the time zone offset is outlandishly large.
1534 Don't mishandle offset == INT_MIN.
1535
66c6fdd5
PE
1536 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1537 when creating daemon; the previous buffer-overflow check was incorrect.
1538
d749b01b
PE
1539 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1540 which has the guts of the old verror function.
1541
b5cd1905
PE
1542 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1543 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1544
6e1a67fb
PE
1545 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1546 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1547 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1548 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1549 length of string rather than counting it via multiple sprintfs;
1550 that's simpler and more reliable.
c21721cc
PE
1551 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1552 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1553 sprintf, in case result does not fit in int.
1554
c57b67fc
PE
1555 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1556 (fontset_from_font): Print it.
1557
8a401434
PE
1558 * frame.c (tty_frame_count): Now printmax_t, not int.
1559 (make_terminal_frame, set_term_frame_name): Print it.
1560 (x_report_frame_params): In X, window IDs are unsigned long,
1561 not signed long, so print them as unsigned.
1562 (validate_x_resource_name): Check for implausibly long names,
1563 and don't assume name length fits in 'int'.
1564 (x_get_resource_string): Don't blindly alloca invocation name;
1565 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1566 not fit in int.
1567
6e1a67fb
PE
1568 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1569 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1570 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1571
0df02bf3
PE
1572 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1573 Use esprintf, not sprintf, in case result does not fit in int.
1574
48e30793
PE
1575 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1576 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1577 it as a large positive number.
1578 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1579 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1580
a66ff6d8
PE
1581 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1582 in case result does not fit in int.
1583
aca216ff
PE
1584 * print.c (float_to_string): Detect width overflow more reliably.
1585 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1586 buffer overrun. Don't assume list length fits in 'int'. Treat
1587 print length of 0 as 0, not as infinity; to be consistent with other
1588 uses of print length in this function. Don't overflow print length
1589 index. Don't assume hash table size fits in 'long', or that
1590 vectorlike size fits in 'unsigned long'.
1591
31c286f7
PE
1592 * process.c (make_process): Use printmax_t, not int, to format
1593 process-name gensyms.
1594
55e5faa1
PE
1595 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1596
80f2e268
PE
1597 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1598 to avoid potential buffer overrun.
1599
670741ab
PE
1600 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1601 if X resource line is longer than 512 bytes.
1602
b7163a50
PE
1603 * xfns.c (x_window): Make sprintf buffer a bit bigger
1604 to avoid potential buffer overrun.
1605
ae58ff1f
PE
1606 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1607
c43c8a6a
PE
1608 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1609
3f8236f4
PE
16102011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1611
53e9fe90 1612 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1613 Without these, Emacs silently mishandles large integers sometimes.
1614 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1615 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1616
6511acf2
PE
1617 * xdisp.c (try_window_id): Check Emacs fixnum range before
1618 converting to 'int'.
806add1d 1619
6511acf2 1620 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1621 Check that an Emacs fixnum is in range before assigning it to 'int'.
1622 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1623 values converted from Emacs fixnums.
1624 (Frecenter): Don't wrap around a line count if it is out of 'int'
1625 range; instead, treat it as an extreme value.
1626 (Fset_window_configuration, compare_window_configurations):
1627 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1628
6511acf2
PE
1629 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1630 that can exceed INT_MAX. Check that EMACS_INT value is in range
1631 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1632 (match_limit): Don't assume that a fixnum can fit in 'int'.
1633
6511acf2 1634 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1635 exceed INT_MAX.
1636
6511acf2 1637 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1638 (Fvertical_motion): Don't wrap around LINES values that don't fit
1639 in 'int'. Instead, treat them as extreme values. This is good
1640 enough for windows, which can't have more than INT_MAX lines anyway.
1641
fcb901a7
LMI
16422011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1643
0f2f6b6d
LMI
1644 * Require libxml/parser.h to avoid compilation warning.
1645
fcb901a7
LMI
1646 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1647
1648 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1649 since this reportedly can destroy thread storage.
1650
6e20a0d4
CY
16512011-08-30 Chong Yidong <cyd@stupidchicken.com>
1652
1653 * syntax.c (find_defun_start): Update all cache variables if
1654 exiting early (Bug#9401).
1655
148ae00e
EZ
16562011-08-30 Eli Zaretskii <eliz@gnu.org>
1657
f6cfbd8f
EZ
1658 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1659
148ae00e
EZ
1660 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1661 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1662 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1663
1664 * term.c (tty_append_glyph): New function.
1665 (produce_stretch_glyph): Static function and its prototype deleted.
1666
a66cfb1c
SM
1667 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1668 Add prototypes.
148ae00e 1669
c4a07a4c
PE
16702011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1671
1672 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1673 when checking :margin (Bug#9390).
1674 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1675 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1676 so that the name doesn't mislead. All uses changed.
1677
6bc8cd65
JB
16782011-08-28 Johan Bockgård <bojohan@gnu.org>
1679
1680 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1681 set_tty_hooks.
1682
dca4927e
EZ
16832011-08-27 Eli Zaretskii <eliz@gnu.org>
1684
1685 * xdisp.c (move_it_to): Don't bail out early when reaching
1686 position beyond to_charpos, if we are scanning backwards.
1687 (move_it_vertically_backward): When DY == 0, make sure we get to
1688 the first character in the line after the newline.
1689
f2cad773
PE
16902011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1691
1692 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1693 (ccl_driver): Do not generate an out-of-range pointer.
1694 (Fccl_execute_on_string): Remove unnecessary check for
1695 integer overflow, noted by Stefan Monnier in
1696 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1697 Remove a FIXME that didn't need fixing.
1698 Simplify the newly-introduced buffer reallocation code.
1699
0cae2cdb
JB
17002011-08-27 Juanma Barranquero <lekktu@gmail.com>
1701
1702 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1703
5fc295a4 17042011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1705
70c60eb2 1706 Integer and memory overflow issues (Bug#9196).
726e0ab1 1707
d31850da
PE
1708 * doc.c (get_doc_string): Rework so that
1709 get_doc_string_buffer_size is the actual buffer size, rather than
1710 being 1 less than the actual buffer size; this makes xpalloc more
1711 convenient.
1712
a69fbedb
PE
1713 * image.c (x_allocate_bitmap_record, cache_image):
1714 * xselect.c (Fx_register_dnd_atom):
1715 Simplify previous changes by using xpalloc.
1716
fe5c5d37
PE
1717 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1718 since either will do and ptrdiff_t is convenient with xpalloc.
1719
0065d054
PE
1720 * charset.c (charset_table_size)
1721 (struct charset_sort_data.priority): Now ptrdiff_t.
1722 (charset_compare): Don't overflow if priorities differ greatly.
1723 (Fsort_charsets): Don't assume list length fits in int.
1724 Check for size-calculation overflow when allocating sort data.
1725 (syms_of_charset): Allocate an initial charset table that is
1726 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1727
1728 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1729
1730 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1731 The actual value is always <= INT_MAX, and leaving it unsigned made
1732 overflow checking harder.
1733
1734 * dispextern.h (struct glyph_matrix.rows_allocated)
1735 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1736 with xpalloc. The values are still always <= INT_MAX.
1737
1738 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1739
1740 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1741 (SAFE_NALLOCA): New macro.
1742
1743 * region-cache.c (struct boundary.pos, find_cache_boundary)
1744 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1745 (set_cache_region, invalidate_region_cache)
1746 (revalidate_region_cache, know_region_cache, region_cache_forward)
1747 (region_cache_backward, pp_cache):
1748 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1749 so that ptrdiff_t * can be passed to xpalloc.
1750 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1751 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1752 (pp_cache): Don't assume cache_len fits in int.
1753 * region-cache.h: Adjust extern decls to match.
1754
1755 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1756 EMACS_INT, since either will do, for xpalloc.
1757
1758 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1759 (xnmalloc, xnrealloc, xpalloc): New functions.
1760
726e0ab1
PE
1761 * bidi.c (bidi_shelve_header_size): New constant.
1762 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1763 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1764
51f30bc5 1765 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1766 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1767 (overlay_strings):
1768 Don't update size of array until after memory allocation succeeds,
1769 because xmalloc/xrealloc may not return.
0065d054
PE
1770 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1771 now that we have proper integer overflow checking.
1772 (record_overlay_string, overlay_strings): Catch overflows when
1773 calculating size of overlay_str_buf.
726e0ab1 1774
0065d054
PE
1775 * callproc.c (Fcall_process): Check for size overflow when
1776 calculating size of args2.
1777 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1778 Normally we prefer signed values, but sticking with ptrdiff_t would
1779 require adding more-complicated checks.
726e0ab1
PE
1780
1781 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1782 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1783 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1784 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1785
1786 * character.c (Fstring): Check for size-calculation overflow.
1787
1788 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1789 unnecessary integer overflow. Check for size overflow.
1790 (encode_coding_object): Don't update size until xmalloc succeeds.
1791
1792 * composite.c (get_composition_id): Check for overflow in glyph
1793 length calculations.
1794
1795 Integer and memory overflow fixes for display code.
1796 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1797 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1798 (scrolling_window): Check for overflow in size calculations.
1799 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1800 Don't assume glyph table len fits in int.
1801 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1802 (row_table_size): Now ptrdiff_t, not int.
1803 (scrolling_window): Avoid overflow in size calculations.
1804 Don't update size until allocation succeeds.
1805 * fns.c (concat): Check for overflow in size calculations.
1806 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1807 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1808 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1809
1810 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1811 (get_doc_string): Check for size calculation overflow.
1812 Don't update size until allocation succeeds.
1813 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1814 EMACS_INT, where ptrdiff_t will do.
1815 (Fsubstitute_command_keys): Check for string overflow.
1816
1817 * editfns.c (set_time_zone_rule): Don't assume environment length
1818 fits in int.
1819 (message_length): Now ptrdiff_t, not int.
1820 (Fmessage_box): Don't update size until allocation succeeds.
1821 Don't assume message length fits in int.
1822 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1823
0065d054
PE
1824 * emacs.c (main): Do not reallocate argv, since there is a null at
1825 the end that can be overwritten, and this way there's no need to
1826 worry about size-calculation overflow.
1827 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1828
1829 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1830 alloc succeeds.
1831 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1832
1833 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1834 (x_set_scroll_bar_width, x_figure_window_size):
1835 Check for integer overflow.
1836 (x_set_alpha): Do not assume XINT fits in int.
1837
1838 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1839 This is for the members text_lines, text_cols, total_lines, total_cols,
1840 where the system imposes an 'int' limit.
1841
1842 * fringe.c (Fdefine_fringe_bitmap):
1843 Don't update size until alloc works.
1844
1845 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1846 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1847
1848 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1849 Check for size-calculation overflow.
1850 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1851 do, as we prefer signed integers.
1852 (id_to_widget.max_size, id_to_widget.used)
1853 (xg_store_widget_in_map, xg_remove_widget_from_map)
1854 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1855 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1856 Use and return ptrdiff_t, not int.
1857 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1858 * gtkutil.h: Change prototypes to match the above.
1859
1860 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1861 are duplicate now that they've been promoted to lisp.h.
1862 (x_allocate_bitmap_record, x_alloc_image_color)
1863 (make_image_cache, cache_image, xpm_load):
1864 Don't update size until alloc is done.
1865 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1866 (x_detect_edges):
3256efce 1867 Check for size calculation overflow.
726e0ab1
PE
1868 (ct_colors_allocated_max): New constant.
1869 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1870 overflow.
3256efce 1871
726e0ab1
PE
1872 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1873 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1874 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1875 Use ptrdiff_t, not int, to count maps.
1876 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1877 calculations. Don't update size until allocation succeeds.
1878 Redo calculations to avoid overflow.
726e0ab1
PE
1879 * keyboard.h: Change prototypes to match the above.
1880
1881 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1882 to count maps.
1883 (current_minor_maps): Check for size calculation overflow.
1884 * keymap.h: Change prototypes to match the above.
1885
1886 * lread.c (read1, init_obarray): Don't update size until alloc done.
1887
1888 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1889 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1890
726e0ab1
PE
1891 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1892 Now ptrdiff_t, not int.
1893 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1894 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1895
1896 * process.c (Fnetwork_interface_list): Check for overflow
1897 in size calculation.
1898
1899 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1900
1901 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1902 overflow. Don't bother calling xmalloc when xrealloc will do.
1903
1904 * search.c (Freplace_match): Check for size calculation overflow.
1905 (Fset_match_data): Don't assume list lengths fit in 'int'.
1906
1907 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1908 for command line length. Do not attempt to address one before the
1909 beginning of an array, as that's not portable.
1910
1911 * term.c (max_frame_lines): Remove; unused.
1912 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1913 not int.
1914 (encode_terminal_code, calculate_costs): Check for size
1915 calculation overflow.
1916 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1917 table lengths and related sizes. Don't update size until alloc
1918 done. Redo calculations to avoid overflow.
1919 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1920
1921 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1922 subtracting pointers.
1923 (gobble_line): Check for overflow more carefully. Don't update size
1924 until alloc done.
1925
1926 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1927 Don't update size until alloc done.
1928 Redo size calculations to avoid overflow.
1929 Check for size calculation overflow.
0065d054 1930 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1931
1932 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1933 Use ptrdiff_t, not int, for sizes.
1934 (store_mode_line_noprop_char): Don't update size until alloc done.
1935
0065d054
PE
1936 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1937 Use ptrdiff_t, not int, for sizes.
1938 (Finternal_make_lisp_face, cache_face):
1939 Check for size calculation overflow.
1940 (cache_face): Treat size calculation overflows as if they were
1941 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1942
1943 * xfns.c (x_encode_text, x_set_name_internal)
1944 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1945 sizes, since they can exceed INT_MAX in size. Check for size
1946 calculation overflow.
1947
0065d054
PE
1948 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1949 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1950 Don't update size until alloc done.
1951
0065d054 1952 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1953 as sprintf is limited to int lengths.
1d526e2f 1954
252c5ee1
PE
1955 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1956 (X_LONG_MIN): New macros.
864d7ce7
PE
1957 Use them to make the following changes clearer.
1958 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1959 This change doesn't affect the value now, but it may help remind
1960 future maintainers not to raise the value too much later.
1961 (SELECTION_QUANTUM): Remove, replacing with ...
1962 (selection_quantum): ... new function, which avoids overflow.
1963 All uses changed.
1964 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1965 assumption that selection length fits in 'int'.
1966 (x_reply_selection_request, x_handle_selection_request)
1967 (x_get_window_property, receive_incremental_selection)
1968 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1969 (lisp_data_to_selection_data, clean_local_selection_data):
1970 Use ptrdiff_t, not int, to record length of selection.
1971 (x_reply_selection_request, x_get_window_property)
1972 (receive_incremental_selection, x_property_data_to_lisp):
1973 Redo calculations to avoid overflow.
1974 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1975 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1976 something.
1977 (x_get_window_property, receive_incremental_selection)
1978 (lisp_data_to_selection_data, x_property_data_to_lisp):
1979 Check for size-calculation overflow.
1980 (x_get_window_property, receive_incremental_selection)
1981 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1982 Don't store size until memory allocation succeeds.
1983 (x_get_window_property): Plug memory leak on memory exhaustion.
1984 Don't double-block input; malloc is safe here. Don't assume 2**34
1985 - 4 fits in unsigned long. Add an xassert to check
1986 XGetWindowProperty overflow. Be more careful about overflow
1987 calculations, and distinguish size from memory overflow better.
1988 (receive_incremental_selection): When tracing, don't assume
1989 unsigned int is less than INT_MAX.
1990 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1991 harmful) conversions of unsigned short to int.
1992 (lisp_data_to_selection_data): Don't assume that integers
1993 in the range -65535 through -1 fit in an X unsigned short.
1994 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1995 result parameters unless successful. Rely on cons_to_unsigned
1996 to report problems with elements; the old code wasn't right anyway.
1997 (x_check_property_data): Check for int overflow; we cannot use
1998 a wider type due to X limits.
1999 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2000
726e0ab1 2001 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2002
0065d054
PE
2003 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2004 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2005 (x_color_cells): Don't store size until memory allocation succeeds.
2006 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2007 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2008 (x_term_init): Don't assume length fits in int (sprintf is limited
2009 to int size).
bc18e09d 2010
ebfa62c0
PE
2011 Use ptrdiff_t for composition IDs.
2012 * character.c (lisp_string_width):
2013 * composite.c (composition_table_size, n_compositions)
2014 (get_composition_id, composition_gstring_from_id):
2015 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2016 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2017 * window.c (Frecenter):
2018 Use ptrdiff_t, not int, for composition IDs.
2019 * composite.c (get_composition_id): Check for integer overflow.
2020 * composite.h: Adjust prototypes to match the above changes.
2021
d3411f89
PE
2022 Use ptrdiff_t for hash table indexes.
2023 * category.c (hash_get_category_set):
2024 * ccl.c (ccl_driver):
2025 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2026 * coding.c (coding_system_charset_list, detect_coding_system):
2027 * coding.h (struct coding_system.id):
2028 * composite.c (get_composition_id, gstring_lookup_cache):
2029 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2030 * image.c (xpm_get_color_table_h):
2031 * lisp.h (hash_lookup, hash_put):
2032 * minibuf.c (Ftest_completion):
2033 Use ptrdiff_t for hash table indexes, not int (which is too
2034 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2035 32-bit --with-wide-int hosts).
2036
e097a6fa
PE
2037 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2038 Add a FIXME comment about memory leaks.
2039 (syms_of_charset): Don't assume xmalloc returns.
2040
5637687f
PE
2041 Don't assume that stated character widths fit in int.
2042 * character.c (Fchar_width, c_string_width, lisp_string_width):
2043 * character.h (CHAR_WIDTH):
2044 * indent.c (MULTIBYTE_BYTES_WIDTH):
2045 Use sanitize_char_width to avoid undefined and/or bad behavior
2046 with outlandish widths.
a66cfb1c 2047 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2048 now that we have two such functions. All uses changed.
2049 (sanitize_char_width): New inline function.
2050
a2271ba2
PE
2051 Don't assume that tab-width fits in int.
2052 * character.h (sanitize_width): New inline function.
2053 (SANE_TAB_WIDTH): New macro.
2054 (ASCII_CHAR_WIDTH): Use it.
2055 * indent.c (sane_tab_width): Remove. All uses replaced by
2056 SANE_TAB_WIDTH (current_buffer).
2057 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2058
18c52557
PE
2059 * fileio.c: Integer overflow issues with file modes.
2060 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2061
caeeedc1
PE
2062 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2063 Remove unreachable code.
2064 (read_hex, load_charset_map_from_file): Check for integer overflow.
2065
50849c52
PE
2066 * xterm.c: don't go over XClientMessageEvent limit
2067 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2068 (x_send_scroll_bar_event): Likewise. Check that the size does not
2069 exceed limits imposed by XClientMessageEvent, as well as the usual
2070 ptrdiff_t and size_t limits.
2071
b13995db
PE
2072 * keyboard.c: Overflow, signedness and related fixes.
2073 (make_lispy_movement): Use same integer type in forward decl
2074 that is used in the definition.
2075 (read_key_sequence, keyremap_step):
2076 Change bufsize argument back to int, undoing my 2011-03-30 change.
2077 We prefer signed types, and int is wide enough here.
2078 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2079 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2080 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2081 length, not size_t. Use ptrdiff_t for index, not int.
2082 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2083 possibility of integer overflow.
2084
13464394
PE
2085 Overflow, signedness and related fixes for images.
2086
2087 * dispextern.h (struct it.stack[0].u.image.image_id)
2088 (struct_it.image_id, struct image.id, struct image_cache.size)
2089 (struct image_cache.used, struct image_cache.ref_count):
2090 * gtkutil.c (update_frame_tool_bar):
2091 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2092 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2093 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2094 * nsmenu.m (update_frame_tool_bar):
2095 * xdisp.c (calc_pixel_width_or_height):
2096 * xfns.c (image_cache_refcount):
2097 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2098 on typical 64-bit hosts.
2099
2100 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2101 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2102 Omit unnecessary casts to int.
2103 (parse_image_spec): Check that integers fall into 'int' range
2104 when the callers expect that.
2105 (image_ascent): Redo ascent calculation to avoid int overflow.
2106 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2107 (lookup_image): Remove unnecessary tests.
2108 (xbm_image_p): Locals are now of int, not EMACS_INT,
2109 since parse_image_check makes sure they fit into int.
2110 (png_load, gif_load, svg_load_image):
2111 Prefer int to unsigned where either will do.
2112 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2113 old tiff_error_handler and tiff_warning_handler.
2114 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2115 stack buffer overflows. It uses only the features of vsnprintf
2116 that are common to both POSIX and native Microsoft.
2117 (tiff_error_handler, tiff_warning_handler): Use it.
2118 (tiff_load, gif_load, imagemagick_load_image):
2119 Don't assume :index value fits in 'int'.
2120 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2121 (imagemagick_load_image): Check that crop parameters fit into
2122 the integer types that MagickCropImage accepts. Don't assume
2123 Vimagemagick_render_type has a nonnegative value. Don't assume
2124 size_t fits in 'long'.
2125 (gs_load): Use printmax_t to print the widest integers possible.
2126 Check for integer overflow when computing image height and width.
2127
c11821d4
EZ
21282011-08-26 Eli Zaretskii <eliz@gnu.org>
2129
2130 * xdisp.c (redisplay_window): Don't force window start if point
2131 will be invisible in the resulting window. (Bug#9324)
2132
0c95fcf7
EZ
21332011-08-25 Eli Zaretskii <eliz@gnu.org>
2134
2135 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2136 the display spec is of the form `(space ...)'.
2137 (handle_display_spec): Return the value returned by
2138 handle_single_display_spec, not just 1 or zero.
2139 (handle_single_display_spec): If the display spec is of the form
2140 `(space ...)', and specifies display in the text area, return 2
2141 rather than 1.
fee65a97 2142 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2143 accurately, and prefer exact match for point under bidi.
2144 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2145
2146 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2147 into disp_prop; all users changed.
2148
2149 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2150 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2151 for the text covered by the display property.
2152
e4ed06f1
CY
21532011-08-25 Chong Yidong <cyd@stupidchicken.com>
2154
2155 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2156 Change return value to nil.
2157 (Frecord_buffer): Delete unused function.
2158
f67cdd7f
EZ
21592011-08-24 Eli Zaretskii <eliz@gnu.org>
2160
5980d4c6
EZ
2161 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2162 buffers, return left-to-right.
8610fe8b
EZ
2163 (set_cursor_from_row): Consider candidate row a win if its glyph
2164 represents a newline and point is on that newline. Fixes cursor
2165 positioning on the newline at EOL of R2L text within L2R
2166 paragraph, and vice versa.
2167 (try_cursor_movement): Check continued rows, in addition to
2168 continuation rows. Fixes unwarranted scroll when point enters a
2169 continued line of R2L text within an L2R paragraph, or vice versa.
2170 (cursor_row_p): Consider the case of point being equal to
2171 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2172 from the end of a short line to the beginning of a continued line
2173 of R2L text within L2R paragraph.
2174 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2175 composed characters.
5980d4c6 2176
f67cdd7f
EZ
2177 * bidi.c (bidi_check_type): Use xassert.
2178 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2179 members.
2180
bca633fb
EZ
21812011-08-23 Eli Zaretskii <eliz@gnu.org>
2182
2183 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2184 a character.
2185
4a5885a7
CY
21862011-08-23 Chong Yidong <cyd@stupidchicken.com>
2187
2188 * nsfont.m (ns_otf_to_script): Fix typo.
2189
0902a04e
KH
21902011-08-22 Kenichi Handa <handa@m17n.org>
2191
2192 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2193 extra slot even if the purpose is char-code-property-table.
2194
1a2e6670
EZ
21952011-08-23 Eli Zaretskii <eliz@gnu.org>
2196
8ddde651
EZ
2197 * xdisp.c (redisplay_window): When computing centering_position,
2198 account for the height of the header line. (Bug#8874)
2199
425cc014
EZ
2200 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2201 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2202 candidate is selected by the mouse, and that candidate has a
2203 composed character under the mouse.
2204
1a2e6670
EZ
2205 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2206 coordinates reported by pos-visible-in-window-p for a composed
2207 character in column zero.
2208
8b76d6f8
SM
22092011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2210
2211 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2212
dac347dd
EZ
22132011-08-22 Eli Zaretskii <eliz@gnu.org>
2214
2215 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2216 consider it a hit if to_charpos is anywhere in the range of the
2217 composed buffer positions.
2218
e013fb34
CY
22192011-08-22 Chong Yidong <cyd@stupidchicken.com>
2220
2221 * image.c (gif_load): Don't assume that each subimage has the same
2222 dimensions as the base image. Handle disposal method that is
2223 "undefined" by the gif spec (Bug#9335).
2224
bd1ba3e8
CY
22252011-08-20 Chong Yidong <cyd@stupidchicken.com>
2226
2227 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2228 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2229
54a1215b
EZ
22302011-08-19 Eli Zaretskii <eliz@gnu.org>
2231
823564e5
EZ
2232 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2233 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2234 from an Org mode buffer to a Speedbar frame.
2235
54a1215b
EZ
2236 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2237 a composition, take its buffer position from IT->cmp_it.charpos.
2238 Fixes cursor positioning at the beginning of a line that begins
2239 with a composed character.
2240
9778ebcc
EZ
22412011-08-18 Eli Zaretskii <eliz@gnu.org>
2242
0be6ee06
EZ
2243 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2244 character bidirectional type, use STRONG_L instead. Fixes crashes
2245 in a buffer produced by `describe-categories'.
2246
9778ebcc
EZ
2247 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2248 members before the level stack, so they would be saved and
2249 restored when copying iterator state. Fixes incorrect reordering
2250 around TABs covered by display properties.
2251
156bffbe
AS
22522011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2253
6b02f655 2254 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2255
72ad093b
CY
22562011-08-17 Chong Yidong <cyd@stupidchicken.com>
2257
2258 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2259 (internal_condition_case_2, internal_condition_case_n):
2260 Remove unnecessary aborts (Bug#9081).
72ad093b 2261
35774242
EZ
22622011-08-17 Eli Zaretskii <eliz@gnu.org>
2263
2264 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2265 has no `load' handler, try opening the file locally. (Bug#9311)
2266
db76dd85
KB
22672011-08-16 Ken Brown <kbrown@cornell.edu>
2268
2269 * gmalloc.c: Expand comment.
2270
b215eee5
EZ
22712011-08-16 Eli Zaretskii <eliz@gnu.org>
2272
2273 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2274 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2275
a4579d33
KB
22762011-08-16 Ken Brown <kbrown@cornell.edu>
2277
2278 Fix memory allocation problems in Cygwin build (Bug#9273).
2279
2280 * unexcw.c ( __malloc_initialized): Declare external variable.
2281 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2282
8b76d6f8
SM
2283 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2284 New variables.
a4579d33
KB
2285 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2286 dumped emacs.
2287 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2288 in the static heap.
2289 [CYGWIN] (special_realloc): New function.
2290 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2291 requests to realloc storage in the static heap.
2292
3ebec551
PE
22932011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2294
2295 * bidi.c (bidi_initialize): Remove unused local.
2296
9fd8be00
EZ
22972011-08-15 Eli Zaretskii <eliz@gnu.org>
2298
6b02f655
SM
2299 * bidimirror.h:
2300 * biditype.h: Remove file.
2301 * makefile.w32-in ($(BLD)/bidi.$(O)):
2302 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2303
2304 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2305
2306 * chartab.c: Improve commentary for the uniprop_table API.
2307
32413314
EZ
2308 * bidi.c (bidi_paragraph_init): Support zero value of
2309 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2310 (bidi_initialize): Use uniprop_table instead of including
2311 biditype.h and bidimirror.h.
32413314 2312
9fd8be00
EZ
2313 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2314 coordinates of the iterator when restoring from ppos_it.
2315 (Bug#9296)
2316
5cf2b69b
KH
23172011-08-14 Kenichi Handa <handa@m17n.org>
2318
2319 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2320 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2321
daf17d00
EZ
23222011-08-14 Eli Zaretskii <eliz@gnu.org>
2323
2324 * xdisp.c (move_it_in_display_line_to): Don't invoke
2325 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2326 ppos_it. Fixes vertical cursor motion when line beginning is
2327 covered by an image. (Bug#9296)
2328
08e3161a
JD
23292011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2330
2331 * nsterm.h (ns_run_ascript): Declare.
2332 (NSAPP_DATA2_RUNASSCRIPT): Define.
2333
2334 * nsfns.m (as_script, as_result, as_status): New static variables.
2335 (ns_run_ascript): New function.
5e617bc2 2336 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2337 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2338 the event loop. Get status from as_status (Bug#7276).
2339
2340 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2341 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2342 the event loop (Bug#7276).
2343
a3720aa2
AS
23442011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2345
2346 * gnutls.c (QCgnutls_bootprop_priority)
2347 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2348 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2349 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2350 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2351 (QCgnutls_bootprop_verify_hostname_error)
2352 (QCgnutls_bootprop_callbacks_verify): Rename from
2353 Qgnutls_bootprop_..., all uses changed.
2354
2355 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2356 uses changed.
2357
0a0d27fb
PE
23582011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2359
19d5c50c
PE
2360 * xfaces.c (Qframe_set_background_mode): Now static.
2361 * dispextern.h (Qframe_set_background_mode): Remove decl.
2362
0a0d27fb
PE
2363 * process.c (Fnetwork_interface_info): Declare local only if needed.
2364
377538cb
JD
23652011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2366
2367 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2368 (Fnetwork_interface_list): Allocate in increments of bytes instead
2369 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2370 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2371 sockaddr.
2372 (struct ifflag_def): notrailers is smart on OSX.
2373 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2374 Get hardware address with getifaddrs if available.
2375
08fff70c
EZ
23762011-08-12 Eli Zaretskii <eliz@gnu.org>
2377
2378 * xdisp.c (iterate_out_of_display_property): xassert that
2379 IT->position is set to within IT->object's boundaries. Break from
2380 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2381 when IT->position is set up wrongly due to some bug.
2382 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2383 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2384 entry. Force push_it to save on the stack the current
2385 buffer/string position, to be restored by pop_it. Fix flags in
2386 the iterator structure wrt the object coming from a display
2387 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2388 properties. (Bug#9284)
2389
7be1c708 23902011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2391
7be1c708
CY
2392 * fontset.c (fontset_get_font_group): Add proper type checks.
2393 (Bug#9172)
aac0c6e3 2394
7be1c708 23952011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2396
7be1c708
CY
2397 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2398 and LC_VERSION_MIN_MACOSX.
2399 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2400 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2401
97bb72a6
EZ
24022011-08-08 Eli Zaretskii <eliz@gnu.org>
2403
2404 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2405 no-display-properties-and-no-overlays under bidi display.
2406 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2407 properties and overlays.
97bb72a6 2408
d5617611
CY
24092011-08-08 Chong Yidong <cyd@stupidchicken.com>
2410
37e11a63
CY
2411 * editfns.c (Fset_time_zone_rule): Document relationship with the
2412 setenv function.
2413
d5617611
CY
2414 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2415 the font entity extracted from the cache (Bug#8109).
2416
58872834
CY
24172011-08-07 Chong Yidong <cyd@stupidchicken.com>
2418
2419 * composite.c (autocmp_chars): Don't reset point. That is done by
2420 restore_point_unwind (Bug#5984).
2421
75bfc667
JL
24222011-08-07 Juri Linkov <juri@jurta.org>
2423
2424 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2425 to show the arg `TIME' instead of `TIMEVAL'.
2426
d1410150
EZ
24272011-08-06 Eli Zaretskii <eliz@gnu.org>
2428
2429 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2430 display property strides EOL and includes a newline, as in
2431 longlines-mode. (Bug#9254)
75b771e4
EZ
2432 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2433 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2434
2435 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2436 is non-zero, even if the data buffer is NULL. Fixes a crash in
2437 vertical-motion with longlines-mode. (Bug#9254)
2438
35928349
EZ
24392011-08-05 Eli Zaretskii <eliz@gnu.org>
2440
ec7cc85b
EZ
2441 * bidi.c <bidi_cache_total_alloc>: Now static.
2442 (bidi_initialize): Initialize bidi_cache_total_alloc.
2443
8b76d6f8 2444 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2445 cache. (Bug#9221)
2446
2447 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2448 amount allocated this far in `bidi_cache_total_alloc'.
2449 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2450 non-zero, only free the data buffer without restoring the cache
2451 contents. All callers changed.
2452
2453 * dispextern.h (bidi_unshelve_cache): Update prototype.
2454
2455 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2456 (move_it_in_display_line, move_it_to)
2457 (move_it_vertically_backward, move_it_by_lines): Replace the call
2458 to xfree to an equivalent call to bidi_unshelve_cache.
2459 (move_it_in_display_line_to): Fix logic of returning
412b6358 2460 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2461
e2e2423b
EZ
24622011-08-05 Eli Zaretskii <eliz@gnu.org>
2463
2464 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2465 came from a string character with a `cursor' property. (Bug#9229)
2466
ae9e757a
JD
24672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2468
2469 * Makefile.in (LIB_PTHREAD): New variable.
2470 (LIBES): Add LIB_PTHREAD (Bug#9216).
2471
2472 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2473 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2474
213bd7f2
AS
24752011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2476
6b02f655 2477 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2478
99aaf75f
JD
24792011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2480
2481 * xterm.c (x_find_topmost_parent): New function.
2482 (x_set_frame_alpha): Find topmost parent window with
2483 x_find_topmost_parent and set the property there also (bug#9181).
2484 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2485
c74e9d86
PE
24862011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2487
2488 * callproc.c (Fcall_process): Avoid vfork clobbering
2489 the local vars buffer, coding_systems, current_dir.
2490
640c8776
SM
24912011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2492
2493 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2494
f26d0e4c
PE
24952011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2496
8a10d76c
PE
2497 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2498 so that it is not optimized away.
2499
f26d0e4c
PE
2500 * xdisp.c (compute_display_string_pos): Remove unused local.
2501
55439c61
EZ
25022011-08-02 Eli Zaretskii <eliz@gnu.org>
2503
2504 Fix slow cursor motion and scrolling in large buffers with
2505 selective display, like Org Mode buffers. (Bug#9218)
2506
2507 * dispextern.h (struct bidi_it): New member disp_prop_p.
2508
2509 * xdisp.c: Remove one-slot cache of display string positions.
2510 (compute_display_string_pos): Accept an additional argument
5e617bc2 2511 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2512 for a display string or property. If found, set DISP_PROP_P
2513 non-zero.
2514
2515 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2516 DISP_PROP_P, and pass it to compute_display_string_pos.
2517 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2518 non-zero. All callers of bidi_fetch_char changed.
2519
fb33fa43
SM
25202011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2521
2522 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2523
b099e063
DM
25242010-12-03 Don March <don@ohspite.net>
2525
2526 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2527 last character M-[char] is translated to ESC [char] (bug#7541).
2528
5cc7f7af
KH
25292011-08-02 Kenichi Handa <handa@m17n.org>
2530
d0fffa3f 2531 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2532
2533 * chartab.c (uniprop_table): Make it non-static.
2534
525d5e6e
EZ
25352011-08-01 Eli Zaretskii <eliz@gnu.org>
2536
2537 * xdisp.c (forward_to_next_line_start): Accept additional argument
2538 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2539 on the newline.
2540 (reseat_at_next_visible_line_start): Use the bidi iterator state
2541 returned by forward_to_next_line_start to restore the state of
2542 it->bidi_it after backing up to previous newline. (Bug#9212)
2543
31011111
AS
25442011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2545
2546 * regex.c (re_comp): Protoize.
2547 (re_exec): Fix return type.
2548 (regexec): Fix type of `ret'. (Bug#9203)
2549
476371c4
PE
25502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2551
e5d76069
PE
2552 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2553 This is needed if max-image-size is a floating-point number.
2554
9a79b20c
AS
25552011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2556
2557 * print.c (print_object): Print empty symbol as ##.
2558
2559 * lread.c (read1): Read ## as empty symbol.
2560
d8c2fa78
AA
25612011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2562
2563 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2564 setting frame foreground color (Bug#9175).
2565 (x_set_background_color): Likewise.
2566
ffe57a7a
AA
2567 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2568 contents (Bug#9176).
2569 (EmacsTooltip -init): Remove bezels and add shadows to
2570 tooltip windows.
2571
bf3492a5
AA
2572 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2573 or scroll bar (Bug#8470).
2574
d55e9c53
AA
2575 * nsfont.m (nsfont_open): Remove assignment to voffset and
2576 unnecessary vars hshink, expand, hd, full_height, min_height.
2577 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2578
2579 * nsterm.h (nsfont_info): Remove voffset field.
2580
d8c2fa78 25812011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2582
2583 Implement strike-through and overline on NextStep (Bug#8863).
2584
2585 * nsfont.m (nsfont_open): Use underline position provided by font,
2586 instead of hard-coded value of 2.
2587 (nsfont_draw): Call ns_draw_text_decoration instead.
2588
2589 * nsterm.h: Add declaration for ns_draw_text_decoration.
2590
2591 * nsterm.m (ns_draw_text_decoration): New function for drawing
2592 underline, overline, and strike-through.
2593 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2594 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2595 accommodate underlining, etc.
4843aac3 2596
4cc60b9b
EZ
25972011-07-28 Eli Zaretskii <eliz@gnu.org>
2598
bc7ece87
EZ
2599 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2600 default.
4cc60b9b 2601
476371c4
PE
26022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2603
66606eea
PE
2604 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2605 Without this fix, if a signal arrives just after memory fills up,
2606 'malloc' might be invoked reentrantly.
2607
476371c4
PE
2608 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2609 In other words, assume that every image size is allowed, on non-X
2610 hosts. This assumption is probably wrong, but it lets Emacs compile.
2611
f3fcc40d
AS
26122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2613
2614 * regex.c (re_iswctype): Convert return values to boolean.
2615
350c992f
EZ
26162011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2617
2618 * xdisp.c (compute_display_string_pos): Don't use cached display
2619 string position if the buffer had its restriction changed.
2620 (Bug#9184)
2621
5266b4bb
PE
26222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2623
2624 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2625
2573a837 26262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2627
41f55ccd 2628 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2629
39e378da
PE
2630 * bidi.c: Integer size and overflow fixes.
2631 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2632 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2633 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2634 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2635 (bidi_find_other_level_edge):
2636 Use ptrdiff_t instead of EMACS_INT where either will do.
2637 This works better on 32-bit hosts configured --with-wide-int.
2638 (bidi_cache_ensure_space): Check for size-calculation overflow.
2639 Use % rather than repeated addition, for better worst-case speed.
2640 Don't set bidi_cache_size until after xrealloc returns, because it
2641 might not return.
2642 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2643 (bidi_cache_ensure_space): Also check that the bidi cache size
2644 does not exceed that of the largest Lisp string or buffer. See Eli
2645 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2646
5e927815
PE
2647 * alloc.c (__malloc_size_t): Remove.
2648 All uses replaced by size_t. See Andreas Schwab's note
2649 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2650
ca4aa935
PE
2651 * image.c: Improve checking for integer overflow.
2652 (check_image_size): Assume that f is nonnull, since
2653 it is always nonnull in practice. This is one less thing to
2654 worry about when checking for integer overflow later.
2655 (x_check_image_size): New function, which checks for integer
2656 overflow issues inside X.
2657 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2658 This removes the need for a memory_full check.
2659 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2660 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2661 (xbm_read_bitmap_data): Change locals back to 'int', since
2662 their values must fit in 'int'.
2663 (xpm_load_image, png_load, tiff_load):
2664 Invoke x_create_x_image_and_pixmap earlier,
2665 to avoid much needless work if the image is too large.
2666 (tiff_load): Treat overly large images as if
2667 x_create_x_image_and_pixmap failed, not as malloc failures.
2668 (gs_load): Use x_check_image_size.
2669
5f8f9cc2
PE
2670 * gtkutil.c: Omit integer casts.
2671 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2672 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2673
5adf60bc
PE
2674 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2675
c8907a93
PE
2676 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2677 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2678 would wrongly return t on a 64-bit host.
2679
e3c25c68
PE
2680 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2681 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2682 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2683 and therefore cause GCC to emit a bogus diagnostic in some cases.
2684
3f791afe
PE
2685 * image.c: Integer signedness and overflow and related fixes.
2686 This is not an exhaustive set of fixes, but it's time to
2687 record what I've got.
2688 (lookup_pixel_color, check_image_size): Remove redundant decls.
2689 (check_image_size): Don't assume that arbitrary EMACS_INT values
2690 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2691 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2692 (tiff_load, imagemagick_load_image):
2693 Check for overflow in size calculations.
2694 (x_create_x_image_and_pixmap): Remove unnecessary test for
2695 xmalloc returning NULL; that can't happen.
2696 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2697 (xpm_color_bucket): Use better integer hashing function.
2698 (xpm_cache_color): Don't possibly over-allocate memory.
2699 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2700 (gif_memory_source):
2701 Use ptrdiff_t, not int or size_t, to record sizes.
2702 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2703 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2704 either works, as we prefer signed integers.
2705 (tiff_read_from_memory, tiff_write_from_memory):
2706 Return tsize_t, not size_t, since that's what the TIFF API wants.
2707 (tiff_read_from_memory): Don't fail simply because the read would
2708 go past EOF; instead, return a short read.
2709 (tiff_load): Omit no-longer-needed casts.
2710 (Fimagemagick_types): Don't assume size fits into 'int'.
2711
3cc5a532
PE
2712 Improve hashing quality when configured --with-wide-int.
2713 * fns.c (hash_string): New function, taken from sxhash_string.
2714 Do not discard information about ASCII character case; this
2715 discarding is no longer needed.
2716 (sxhash-string): Use it. Change sig to match it. Caller changed.
2717 * lisp.h: Declare it.
2718 * lread.c (hash_string): Remove, since we now use fns.c's version.
2719 The fns.c version returns a wider integer if --with-wide-int is
2720 specified, so this should help the quality of the hashing a bit.
2721
b312a492
PE
2722 * emacs.c: Integer overflow minor fix.
2723 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2724 Define only if GNU_LINUX.
2725 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2726
dfd153ae
PE
2727 * dispnew.c: Integer signedness and overflow fixes.
2728 Remove unnecessary forward decls, that were a maintenance hassle.
2729 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2730 All uses changed.
2731 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2732 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2733 (prepare_desired_row, line_draw_cost):
2734 Use int, not unsigned, where either works.
2735 (save_current_matrix, restore_current_matrix):
2736 Use ptrdiff_t, not size_t, where either works.
2737 (init_display): Check for overflow more accurately, and without
2738 relying on undefined behavior.
2739
a81d11a3
PE
2740 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2741 Remove, replacing with the new symbols in lisp.h. All uses changed.
2742 * fileio.c (make_temp_name):
2743 * filelock.c (lock_file_1, lock_file):
2744 * xdisp.c (message_dolog):
2745 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2746 Use pMd etc. instead.
2747 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2748 replacing the pWIDE etc. symbols removed from editfns.c.
2749
3300e6fd
PE
2750 * keyboard.h (num_input_events): Now uintmax_t.
2751 This is (very slightly) less likely to mess up due to wraparound.
2752 All uses changed.
2753
fd05c7e9
PE
2754 * buffer.c: Integer signedness fixes.
2755 (alloc_buffer_text, enlarge_buffer_text):
2756 Use ptrdiff_t rather than size_t when either will do, as we prefer
2757 signed integers.
2758
903fe15d
PE
2759 * alloc.c: Integer signedness and overflow fixes.
2760 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2761 (__malloc_size_t): Default to size_t, not to int.
2762 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2763 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2764 Prefer ptrdiff_t to size_t when either would do, as we prefer
2765 signed integers.
2766 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2767 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2768 Now const. Initialize with values that are in range even if char
2769 is signed.
2770 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2771 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2772 These functions do the right thing with sizes > 2**32.
2773 (check_depth): Now ptrdiff_t, not int.
2774 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2775 Adjust to new way of storing sizes. Check for size overflow bugs
2776 in rest of code.
2777 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2778 slightly wrong anyway, as it missed one instance of
2779 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2780 (refill_memory_reserve): Omit needless cast to size_t.
2781 (mark_object_loop_halt): Mark as externally visible.
2782
ac82cc6a
PE
2783 * xselect.c: Integer signedness and overflow fixes.
2784 (Fx_register_dnd_atom, x_handle_dnd_message):
2785 Use ptrdiff_t, not size_t, since we prefer signed.
2786 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2787 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2788 x_dnd_atoms_size and x_dnd_atoms_length.
2789
c2d1e36d
PE
2790 * doprnt.c: Prefer signed to unsigned when either works.
2791 * eval.c (verror):
2792 * doprnt.c (doprnt):
2793 * lisp.h (doprnt):
2794 * xdisp.c (vmessage):
2795 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2796 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2797 prefer signed arithmetic to avoid comparison confusion.
2798 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2799 but is a bit tricky.
2800
0e926e56
PE
2801 Assume freestanding C89 headers, string.h, stdlib.h.
2802 * data.c, doprnt.c, floatfns.c, print.c:
2803 Include float.h unconditionally.
2804 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2805 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2806 * regex.c: Likewise for stddef.h, string.h.
2807 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2808 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2809 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2810 (STDC_HEADERS): Remove obsolete defines.
2811 * sysdep.c: Include limits.h unconditionally.
2812
9cfdb3ec
PE
2813 Assume support for memcmp, memcpy, memmove, memset.
2814 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2815 * regex.c (memcmp, memcpy):
2816 Remove; we assume C89 now.
2817
2818 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2819 (__malloc_safe_bcopy): Remove; no longer needed.
2820
cf950e6b 2821 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2822 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2823 well either way, and we prefer signed to unsigned.
2824
dbf38e02
LMI
28252011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2826
2827 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2828 closes the connection while we're reading (bug#9182).
2829
d6f0886c 28302011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2831
d6f0886c
JD
2832 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2833 are specified (Bug#9168).
24e0f6b1 2834
2eb1f9e6
PE
28352011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2838 Found by GCC static checking and --with-wide-int on a 32-bit host.
2839
22381272 28402011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2841
2842 * xdisp.c (compute_display_string_pos): Fix logic of caching
2843 previous display string position. Initialize cached_prev_pos to
2844 -1. Fixes slow-down at the beginning of a buffer.
2845
f25e39b4
EZ
28462011-07-24 Eli Zaretskii <eliz@gnu.org>
2847
2848 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2849 for attrs[LFACE_FONTSET_INDEX].
2850
04c4b52e
PE
28512011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2852
2853 * xml.c (parse_region): Remove unused local
2854 that was recently introduced.
2855
c1734fbd
EZ
28562011-07-23 Eli Zaretskii <eliz@gnu.org>
2857
be18c5a5
EZ
2858 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2859 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2860
c1734fbd
EZ
2861 * xdisp.c (move_it_in_display_line_to): Record the best matching
2862 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2863 exit if none of the characters scanned was an exact match.
2864 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2865 when exact match is impossible due to invisible text, and the
2866 lines are truncated.
2867
a258d627
JD
28682011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2869
2870 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2871 for OSX >= 10.7.
2872
b6d5a689
EZ
28732011-07-22 Eli Zaretskii <eliz@gnu.org>
2874
0f74f785
EZ
2875 Fix a significant slow-down of cursor motion with C-n, C-p,
2876 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2877 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2878 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2879 (next_element_from_buffer): Call compute_stop_pos_backwards to
2880 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2881 base_level_stop.
2882 (reseat): Don't look for prev_stop, as that could mean a very long
2883 run.
2884 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2885 <cached_disp_overlay_modiff>: Cache for last found display string
2886 position.
551918c1 2887 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2888 about the same buffer in the same area of character positions, and
2889 the buffer wasn't changed since the time the display string
2890 position was cached.
551918c1 2891
b2d0c91a
EZ
28922011-07-22 Eli Zaretskii <eliz@gnu.org>
2893
2894 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2895 is an integer, which is important for empty lines. (Bug#9149)
2896
043604ee
CY
28972011-07-22 Chong Yidong <cyd@stupidchicken.com>
2898
2899 * frame.c (Fmodify_frame_parameters): In tty case, update the
2900 default face if necessary (Bug#4238).
2901
da4adb04
CY
29022011-07-21 Chong Yidong <cyd@stupidchicken.com>
2903
2904 * editfns.c (Fstring_to_char): No need to explain what a character
2905 is in the docstring (Bug#6576).
2906
9abd0532
LMI
29072011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2908
2909 * xml.c (parse_region): Make sure we always return a tree.
2910
36881d16
HK
29112011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2912
2913 * xml.c (parse_region): If a document contains only comments,
2914 return that, too.
2915
1e98674d
LMI
29162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2917
2918 * xml.c (make_dom): Return comments, too.
2919
590bd467
PE
29202011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2921
2922 Port to OpenBSD.
2923 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2924 and the surrounding thread.
2925 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2926 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2927 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2928 timer goes off.
2929 * s/openbsd.h (BROKEN_SIGIO): Define.
2930 * unexelf.c (unexec) [__OpenBSD__]:
2931 Don't update the .mdebug section of the Alpha COFF symbol table.
2932
f41628b2
LMI
29332011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2934
2935 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2936 (bug#8460).
2937
b59b67c5
PE
29382011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2939
15e3a074
PE
2940 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2941 This fixes some race conditions on the permissions of any newly
2942 created file.
2943
41bed37d
PE
2944 * alloc.c (valid_pointer_p): Use pipe, not open.
2945 This fixes some permissions issues when debugging.
2946
b59b67c5
PE
2947 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2948 If fchown fails to set both uid and gid, try to set just gid,
2949 as that is sometimes allowed. Adjust the file's mode to eliminate
2950 setuid or setgid bits that are inappropriate if fchown fails.
2951
925a6be7
SM
29522011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2953
2954 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2955 to compare Lisp_Objects.
2956 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2957 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2958 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2959
52968808
AS
29602011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2961
0a6a104b
AS
2962 * lread.c (read_integer): Unread even EOF character.
2963 (read1): Likewise. Properly record start position of symbol.
2964
52968808
AS
2965 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2966 symbol character follows.
2967
9e381cdd
PE
29682011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2969
2970 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2971 This works around a problem with the previous change to Fcopy_file.
2972 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2973 and without this change, GCC might complain about discarding
2974 fchown's return value.
2975
b5641435
JB
29762011-07-16 Juanma Barranquero <lekktu@gmail.com>
2977
2978 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2979
a8031457
PE
29802011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2981
2982 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2983
dd889327
LMI
29842011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2985
750c33f7
LMI
2986 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2987 it's used from the C level.
2988
dd889327
LMI
2989 * process.c: Use the same condition for POLL_FOR_INPUT in both
2990 keyboard.c and process.c (bug#1858).
2991
87e86684
LM
29922011-07-09 Lawrence Mitchell <wence@gmx.li>
2993
2994 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2995 (Fgnutls_boot): Use it.
2996
64348f40
AS
29972011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2998
2999 * doc.c (Fsubstitute_command_keys): Revert last change.
3000
1d698799
LMI
30012011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3002
f863868c
LMI
3003 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3004 quotes the next character, and doesn't affect other longer
3005 sequences (bug#8935).
3006
1d698799
LMI
3007 * lread.c (syms_of_lread): Clarify that is isn't only
3008 `eval-buffer' and `eval-defun' that's affected by
3009 `lexical-binding' (bug#8460).
3010
aa4b6df6
EZ
30112011-07-15 Eli Zaretskii <eliz@gnu.org>
3012
3013 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3014 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3015
5d856da6
PE
30162011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3017
ad6042bb
PE
3018 Fix minor problems found by static checking.
3019 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3020 (elsz): Now a signed constant, not a size_t var. We prefer signed
3021 types to unsigned, to avoid integer comparison confusion. Without
3022 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3023 "cannot optimize loop, the loop counter may overflow", a symptom
3024 of the confusion.
f00bbb22 3025 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3026 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3027
6468f31c
LMI
30282011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3029
49080b10
LMI
3030 * search.c (Fre_search_backward): Mention `case-fold-search' in
3031 all the re_search_* functions (bug#8138).
3032
6468f31c
LMI
3033 * keyboard.c (Fopen_dribble_file): Document when the file is
3034 closed (bug#8056).
3035
c965adc5
EZ
30362011-07-14 Eli Zaretskii <eliz@gnu.org>
3037
df9733bf
EZ
3038 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3039 bidi_cache_idx.
3040
0bb23927
EZ
3041 Support bidi reordering of display and overlay strings.
3042 * xdisp.c (compute_display_string_pos)
3043 (compute_display_string_end): Accept additional argument STRING.
3044 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3045 (reseat_to_string): Initialize bidi_it->string.s and
3046 bidi_it->string.schars.
3047 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3048 NULL (avoids a crash in bidi_paragraph_init).
3049 Initialize itb.string.lstring.
0bb23927
EZ
3050 (init_iterator): Call bidi_init_it only of a valid
3051 buffer position was specified. Initialize paragraph_embedding to
3052 L2R.
3053 (reseat_to_string): Initialize the bidi iterator.
3054 (display_string): If we need to ignore text properties of
3055 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3056 original value of -1 will not work with bidi.)
3057 (compute_display_string_pos): First arg is now struct
3058 `text_pos *'; all callers changed. Support display properties on
3059 Lisp strings.
3060 (compute_display_string_end): Support display properties on Lisp
3061 strings.
3062 (init_iterator, reseat_1, reseat_to_string): Initialize the
3063 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3064 when iterating on a string not from display properties).
640c8776
SM
3065 (compute_display_string_pos, compute_display_string_end):
3066 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3067 arrow keys.
3068 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3069 base_level_stop; instead, set base_level_stop to BEGV.
3070 Fixes crashes in vertical-motion.
0bb23927
EZ
3071 (next_element_from_buffer): Improve commentary for when
3072 the iterator is before prev_stop.
3073 (init_iterator): Initialize bidi_p from the default value of
3074 bidi-display-reordering, not from buffer-local value. Use the
3075 buffer-local value only if initializing for buffer iteration.
3076 (handle_invisible_prop): Support invisible properties on strings
3077 that are being bidi-reordered.
3078 (set_iterator_to_next): Support bidi reordering of C strings and
3079 Lisp strings.
3080 (next_element_from_string): Support bidi reordering of Lisp
3081 strings.
3082 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3083 (display_string): Support display of R2L glyph rows.
3084 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3085 (init_iterator): Don't initialize it->bidi_p for strings
3086 here.
3087 (reseat_to_string): Initialize it->bidi_p for strings here.
3088 (next_element_from_string, next_element_from_c_string)
3089 (next_element_from_buffer): Add xassert's for correspondence
3090 between IT's object being iterated and it->bidi_it.string
3091 structure.
3092 (face_before_or_after_it_pos): Support bidi iteration.
3093 (next_element_from_c_string): Handle the case of the first string
3094 character that is not the first one in the visual order.
3095 (get_visually_first_element): New function, refactored from common
3096 parts of next_element_from_buffer, next_element_from_string, and
3097 next_element_from_c_string.
3098 (tool_bar_lines_needed, redisplay_tool_bar)
3099 (display_menu_bar): Force left-to-right direction. Add a FIXME
3100 comment for making that be controlled by a user option.
3101 (push_it, pop_it): Save and restore the state of the
3102 bidi iterator. Save and restore the bidi_p flag.
3103 (pop_it): Iterate out of display property for string iteration as
3104 well.
3105 (iterate_out_of_display_property): Support iteration over strings.
3106 (handle_single_display_spec): Set up it->bidi_it for iteration
3107 over a display string, and call bidi_init_it.
3108 (handle_single_display_spec, next_overlay_string)
3109 (get_overlay_strings_1, push_display_prop): Set up the bidi
3110 iterator for displaying display or overlay strings.
3111 (forward_to_next_line_start): Don't use the shortcut if
3112 bidi-iterating.
3113 (back_to_previous_visible_line_start): If handle_display_prop
3114 pushed the iterator stack, restore the internal state of the bidi
3115 iterator by calling bidi_pop_it same number of times.
3116 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3117 and we are bidi-iterating, don't decrement the iterator position;
3118 instead, set the first_elt flag in the bidi iterator, to produce
3119 the same effect.
3120 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3121 (push_display_prop): xassert that we are iterating a buffer.
3122 (push_it, pop_it): Save and restore paragraph_embedding member.
3123 (handle_single_display_spec, next_overlay_string)
3124 (get_overlay_strings_1, reseat_1, reseat_to_string)
3125 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3126 correctly. Don't assume unibyte strings are not bidi-reordered.
3127 (compute_display_string_pos)
3128 (compute_display_string_end): Fix handling the case of C string.
3129 (push_it, pop_it): Save and restore from_disp_prop_p.
3130 (handle_single_display_spec, push_display_prop): Set the
3131 from_disp_prop_p flag.
3132 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3133 (pop_it): Call iterate_out_of_display_property only if we are
3134 popping after iteration over a string that came from a display
3135 property. Fix a typo in popping stretch info. Add an assertion
3136 for verifying that the iterator position is in sync with the bidi
3137 iterator.
3138 (handle_single_display_spec, get_overlay_strings_1)
3139 (push_display_prop): Fix initialization of paragraph direction for
3140 string when that of the parent object is not yet determined.
3141 (reseat_1): Call bidi_init_it to resync the bidi
3142 iterator with IT's position. (Bug#7616)
3143 (find_row_edges): If ROW->start.pos gives position
3144 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3145 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3146 Reset the from_disp_prop_p flag.
3147 (SAVE_IT, RESTORE_IT): New macros.
3148 (pos_visible_p, face_before_or_after_it_pos)
3149 (back_to_previous_visible_line_start)
3150 (move_it_in_display_line_to, move_it_in_display_line)
3151 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3152 (try_scrolling, redisplay_window, display_line): Use them when
3153 saving a temporary copy of the iterator and restoring it back.
3154 (back_to_previous_visible_line_start, reseat_1)
3155 (init_iterator): Empty the bidi cache "stack".
3156 (move_it_in_display_line_to): If iterator ended up at
3157 EOL, but we never saw any buffer positions smaller than
3158 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3159 motion in bidi-reordered lines.
3160 (move_it_in_display_line_to): Record prev_method and prev_pos
3161 immediately before the call to set_iterator_to_next. Fixes cursor
3162 motion in bidi-reordered lines with stretch glyphs and strings
3163 displayed in margins. (Bug#8133) (Bug#8867)
3164 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3165 TO_CHARPOS.
640c8776
SM
3166 (pos_visible_p): Support positions in bidi-reordered lines.
3167 Save and restore bidi cache.
0bb23927
EZ
3168
3169 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3170 (bidi_paragraph_info): Delete unused struct.
3171 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3172 (bidi_cache_start): New variable.
3173 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3174 to zero.
3175 (bidi_cache_fetch_state, bidi_cache_search)
3176 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3177 (bidi_cache_find, bidi_peek_at_next_level)
3178 (bidi_level_of_next_char, bidi_find_other_level_edge)
3179 (bidi_move_to_visually_next): Compare cache index with
3180 bidi_cache_start rather than with zero.
3181 (bidi_fetch_char): Accept new argument STRING; all callers
3182 changed. Support iteration over a string. Support strings with
3183 display properties. Support unibyte strings. Fix the type of
3184 `len' according to what STRING_CHAR_AND_LENGTH expects.
3185 (bidi_paragraph_init, bidi_resolve_explicit_1)
3186 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3187 (bidi_level_of_next_char, bidi_move_to_visually_next):
3188 Support iteration over a string.
0bb23927
EZ
3189 (bidi_set_sor_type, bidi_resolve_explicit_1)
3190 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3191 can now be zero (for strings); special values 0 and -1 were
3192 changed to -1 and -2, respectively.
3193 (bidi_char_at_pos): New function.
3194 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3195 Call it instead of FETCH_MULTIBYTE_CHAR.
3196 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3197 initialized to valid values.
3198 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3199 values.
3200 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3201 the test for valid cached positions. Fix the logic for looking up
3202 the sentinel state in the cache. GCPRO the Lisp string we are
3203 iterating.
3204 (bidi_push_it, bidi_pop_it): New functions.
3205 (bidi_initialize): Initialize the bidi cache start stack pointer.
3206 (bidi_cache_ensure_space): New function, refactored from part of
3207 bidi_cache_iterator_state. Don't assume the required size is just
3208 one BIDI_CACHE_CHUNK away.
3209 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3210 (bidi_count_bytes, bidi_char_at_pos): New functions.
3211 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3212 always valid if bidi_cache_idx is valid.
3213 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3214 is valid if it's going to be used.
3215 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3216 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3217 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3218 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3219 (bidi_find_other_level_edge, bidi_cache_start_stack):
3220 All variables related to cache indices are now EMACS_INT.
c965adc5 3221
0bb23927
EZ
3222 * dispextern.h (struct bidi_string_data): New structure.
3223 (struct bidi_it): New member `string'. Make flag members be 1-bit
3224 fields, and put them last in the struct.
640c8776
SM
3225 (compute_display_string_pos, compute_display_string_end):
3226 Update prototypes.
0bb23927
EZ
3227 (bidi_push_it, bidi_pop_it): Add prototypes.
3228 (struct iterator_stack_entry): New members bidi_p,
3229 paragraph_embedding, and from_disp_prop_p.
3230 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3231 (bidi_shelve_cache, bidi_unshelve_cache):
3232 Declare prototypes.
0bb23927
EZ
3233
3234 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3235 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3236 and vector-like objects.
3237
3238 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3239 cache around display iteration.
3240
3241 * window.c (Fwindow_end, window_scroll_pixel_based)
3242 (displayed_window_lines, Frecenter): Save and restore the bidi
3243 cache around display iteration.
3244
3bbd2265
LMI
32452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3246
3247 * editfns.c (Fdelete_region): Clarify the use of the named
3248 parameters (bug#6788).
3249
adc47434
MR
32502011-07-14 Martin Rudalics <rudalics@gmx.at>
3251
3252 * indent.c (Fvertical_motion): Set and restore w->pointm when
3253 saving and restoring the window's buffer (Bug#9006).
3254
837c31f8
LMI
32552011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3256
3257 * editfns.c (Fstring_to_char): Clarify just what is returned
3258 (bug#6576). Text by Eli Zaretskii.
3259
ac389d0c
JB
32602011-07-13 Juanma Barranquero <lekktu@gmail.com>
3261
3262 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3263
0be0ce47
EZ
32642011-07-13 Eli Zaretskii <eliz@gnu.org>
3265
3266 * buffer.c (mmap_find): Fix a typo.
3267
cd18e7e3
JB
32682011-07-13 Johan Bockgård <bojohan@gnu.org>
3269
3270 Fix execution of x selection hooks.
3271 * xselect.c (Qx_lost_selection_functions)
3272 (Qx_sent_selection_functions): New vars.
3273 (syms_of_xselect): DEFSYM them.
3274 (x_handle_selection_request): Pass Qx_sent_selection_functions
3275 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3276 (x_handle_selection_clear,x_clear_frame_selections):
3277 Pass Qx_lost_selection_functions rather than
3278 Vx_lost_selection_functions to Frun_hook_with_args.
3279
47ea7f44
PE
32802011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3281
ac389d0c 3282 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3283 The old code sometimes used this field without initializing it.
3284
47ea7f44
PE
3285 * alloc.c (gc_sweep): Don't read past end of array.
3286 In theory, the old code could also have corrupted Emacs internals,
3287 though it'd be very unlikely.
3288
bc985c87
AS
32892011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3290
3291 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3292 argument. (Bug#4026)
bc985c87 3293
0cf34688
LMI
32942011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3295
b3dadd76
LMI
3296 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3297 key" (bug#4257).
3298
0cf34688
LMI
3299 * window.c (Fset_window_start): Doc fix (bug#4199).
3300 (Fset_window_hscroll): Ditto.
3301
270768cd
PE
33022011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3303
077e3dda 3304 Fix minor new problems caught by GCC 4.6.1.
270768cd 3305 * term.c (init_tty): Remove unused local.
490011a6 3306 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3307 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3308 not used otherwise.
270768cd 3309
b1f58454
CY
33102011-07-12 Chong Yidong <cyd@stupidchicken.com>
3311
3312 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3313
22b9578d
LMI
33142011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3315
6e70ab07
LMI
3316 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3317 are the mini-buffer and the echo area (bug#3320).
3318
22b9578d
LMI
3319 * term.c (init_tty): Remove support for supdup, c10 and perq
3320 terminals, which are no longer supported (bug#1482).
3321
8974cc9f
JB
33222011-07-10 Johan Bockgård <bojohan@gnu.org>
3323
3324 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3325
a560d974
JD
33262011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3327
3328 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3329 for non-popups (Bug#3642).
3330
1dae0f0a
AS
33312011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3332
268c2c36 3333 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3334 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3335 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3336 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3337 * data.c (fmod): Likewise.
3338 * dispnew.c (swap_glyphs_in_rows): Likewise.
3339 * emacs.c (memory_warning_signal): Likewise.
3340 * floatfns.c (float_error): Likewise.
3341 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3342 (otf_open, font_otf_capability, generate_otf_features)
3343 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3344 Likewise.
3345 * image.c (pbm_read_file): Likewise.
3346 * indent.c (string_display_width): Likewise.
3347 * intervals.c (check_for_interval, search_for_interval)
3348 (inc_interval_count, count_intervals, root_interval)
3349 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3350 * lread.c (defalias): Likewise.
268c2c36 3351 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3352 * regex.c (set_image_of_range_1, set_image_of_range)
3353 (regex_grow_registers): Likewise.
3354 * sysdep.c (strerror): Likewise.
3355 * termcap.c (valid_filename_p, tprint, main): Likewise.
3356 * tparam.c (main): Likewise.
3357 * unexhp9k800.c (run_time_remap, save_data_space)
3358 (update_file_ptrs, read_header, write_header, calculate_checksum)
3359 (copy_file, copy_rest, display_header): Likewise.
3360 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3361 Likewise.
3362 * xdisp.c (check_it): Likewise.
3363 * xfaces.c (register_color, unregister_color, unregister_colors):
3364 Likewise.
3365 * xfns.c (print_fontset_result): Likewise.
3366 * xrdb.c (member, fatal, main): Likewise.
3367
99033785
PE
33682011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3369
3370 Fix minor problems found by static checking (Bug#9031).
3371 * chartab.c (char_table_set_range, map_sub_char_table):
3372 Remove unused locals.
3373 (uniprop_table): Now static.
3374 * composite.c (_work_char): Remove unused static var.
3375
9cb2ac56
JB
33762011-07-09 Juanma Barranquero <lekktu@gmail.com>
3377
3378 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3379
f25661f0
JD
33802011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3381
3382 * gtkutil.c (qttip_cb): Remove code without function.
3383
8278c4fe
EZ
33842011-07-09 Eli Zaretskii <eliz@gnu.org>
3385
3386 * w32.c (pthread_sigmask): New stub.
3387
1692ae2d 33882011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3389
8a6ebd58 3390 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3391 sigprocmask is portable only for single-threaded applications, and
3392 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3393 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3394 (LIBES): Use it.
3395 * callproc.c (Fcall_process):
3396 * process.c (create_process):
3397 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3398 Use pthread_sigmask, not sigprocmask.
123403e4 3399
1b854618
JD
34002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3401
3402 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3403 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3404 wrong (Bug#8591).
3405
3fe4b549
JD
34062011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3407
0ce7e563
JD
3408 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3409 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3410 (xg_hide_tooltip): Fix comment.
3411
3fe4b549
JD
3412 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3413 in registerServicesMenuSendTypes.
3414 (validRequestorForSendType): Don't check ns_return_types.
3415
3416 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3417 ns_return_type.
3418
5df75e47
JR
34192011-07-08 Jason Rumney <jasonr@gnu.org>
3420
22610910
JR
3421 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3422 SH_SHOW for hidden windows (Bug#5482).
3423
5df75e47
JR
3424 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3425 frame struct members of non-existent frames (Bug#6284).
3426
699c10bd
JD
34272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3428
4393663b
JD
3429 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3430 variable firstTime not needed on OSX >= 10.6.
3431 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3432 >= 10.5. Use setKnobProportion, setDoubleValue.
3433
3434 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3435 (MAC_OS_X_VERSION_10_5): Define if not defined.
3436 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3437 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3438 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3439
3440 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3441 cString and lossyCString on OSX >= 10.4
3442
58179cce 3443 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3444 sizeToFit on OSX >= 10.2.
3445
3446 * nsimage.m (allocInitFromFile): Don't use deprecated method
3447 bestRepresentationForDevice on OSX >= 10.6.
3448
3449 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3450 to avoid warning.
3451
3452 * emacs.c: Declare unexec_init_emacs_zone.
3453
a63e0781
JD
3454 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3455
699c10bd
JD
3456 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3457
3458 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3459 on svcsMenu (Bug#8842).
3460
3461 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3462 ns_return_types.
3463 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3464
3465 * nsterm.m (QUTF8_STRING): Declare.
3466 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3467 (validRequestorForSendType): Return type is (id).
3468 Change indexOfObjectIdenticalTo to indexOfObject.
3469 Check if we have local selection before returning self (Bug#8842).
3470 (writeSelectionToPasteboard): Put local selection into paste board
3471 if we have a local selection (Bug#8842).
3472 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3473
3474 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3475 (ns_get_local_selection): Declare.
3476
54e10184
LMI
34772011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3478
9888ff71
LMI
3479 * keymap.c (describe_map_tree): Don't insert a double newline at
3480 the end of the buffer (bug#1169) and return whether we inserted
3481 something.
3482
54e10184
LMI
3483 * callint.c (Fcall_interactively): Change "reading args" to
3484 "providing args" to try to clarify what it does (bug#1010).
3485
15fa4783
KH
34862011-07-07 Kenichi Handa <handa@m17n.org>
3487
3488 * composite.c (composition_compute_stop_pos): Ignore a static
3489 composition starting before CHARPOS (Bug#8915).
3490
3491 * xdisp.c (handle_composition_prop): Likewise.
3492
a8815b00
EZ
34932011-07-07 Eli Zaretskii <eliz@gnu.org>
3494
3495 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3496 (Bug#9015)
3497
ef7b981d 34982011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3499
3500 * character.h (unicode_category_t): New enum type.
3501
3502 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3503 (Qchar_code_property_table): New variable.
3504 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3505 (UNIPROP_COMPRESSED_FORM_P): New macros.
3506 (char_table_ascii): Uncompress the compressed values.
3507 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3508 Uncompress the compressed values.
ac389d0c 3509 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3510 (char_table_ref_and_range): Uncompress the compressed values.
3511 (sub_char_table_set): New arg is_uniprop. Callers changed.
3512 Uncompress the compressed values.
3513 (sub_char_table_set_range): Args changed. Callers changed.
3514 (char_table_set_range): Adjuted for the above change.
3515 (map_sub_char_table): Delete args default_val and parent. Add arg
3516 top. Give decoded values to a Lisp function.
640c8776 3517 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3518 values to a Lisp function. Gcpro more variables.
3519 (uniprop_table_uncompress)
3520 (uniprop_decode_value_run_length): New functions.
3521 (uniprop_decoder, uniprop_decoder_count): New variables.
3522 (uniprop_get_decoder, uniprop_encode_value_character)
3523 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3524 New functions.
3525 (uniprop_encoder, uniprop_encoder_count): New variables.
3526 (uniprop_get_encoder, uniprop_table)
3527 (Funicode_property_table_internal, Fget_unicode_property_internal)
3528 (Fput_unicode_property_internal): New functions.
3529 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3530 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3531 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3532 char-code-property-alist.
3533
640c8776 3534 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3535 Vunicode_category_table.
3536
640c8776 3537 * font.c (font_range): Adjust for the change of
c805dec0
KH
3538 Vunicode_category_table.
3539
76b397fb
DN
35402011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3541
3542 * m/iris4d.h: Remove file, move contents ...
3543 * s/irix6-5.h: ... here.
3544
22b4128e
PE
35452011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3546
3547 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3548 * alloc.c (mark_buffer):
3549 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3550 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3551 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3552 This isn't true in general, and it's particularly not true
3553 if Emacs is configured with --with-wide-int.
3554 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3555 New macros, used in the buffer.c change.
3556
869795d6
JD
35572011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3558
3559 * xsettings.c: Use both GConf and GSettings if both are available.
3560 (store_config_changed_event): Add comment.
3561 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3562 (store_tool_bar_style_changed): New functions.
5e617bc2 3563 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3564 (struct xsettings): Move font inside HAVE_XFT.
3565 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3566 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3567 Move inside HAVE_XFT.
640c8776 3568 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3569 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3570 also.
3571 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3572 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3573 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3574 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3575 (parse_settings): Move check for font inside HAVE_XFT.
3576 (read_settings, apply_xft_settings): Add comment.
3577 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3578 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3579 call store_font_name_changed.
3580 (xft_settings_event): Add comment.
3581 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3582 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3583 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3584 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3585 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3586 (xsettings_get_system_font, xsettings_get_system_normal_font):
3587 Add comment.
869795d6 3588
d8ed26bd
PE
35892011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3590
3591 Random fixes. E.g., (random) never returned negative values.
3592 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3593 subseconds part to the entropy, as that's a bit more random.
3594 Prefer signed to unsigned, since the signedness doesn't matter and
3595 in general we prefer signed. When given a limit, use a
3596 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3597 latter isn't right if USE_2_TAGS_FOR_INTS.
3598 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3599 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3600
cabf1cac
SM
36012011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3602
3603 * textprop.c (text_property_stickiness):
3604 Obey Vtext_property_default_nonsticky.
3605 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3606 * w32fns.c (syms_of_w32fns):
3607 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3608
6e9b2be9
PE
36092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3610
3611 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3612 This is more efficient than Ffile_directory_p and avoids a minor race.
3613
90186c68
LMI
36142011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3615
7c301272
LMI
3616 * buffer.c (Foverlay_put): Say what the return value is
3617 (bug#7835).
3618
c4f2d8d4
LMI
3619 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3620 is a directory before asking whether to use the file name
3621 (bug#7564).
ad637907
LMI
3622 (barf_or_query_if_file_exists): Make the "File is a directory"
3623 error be more correct.
c4f2d8d4 3624
90186c68
LMI
3625 * fns.c (Frequire): Remove the mention of the .gz files, since
3626 that's installation-specific, but keep the mention of
3627 `get-load-suffixes'.
3628
da64016e
PE
36292011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3630
3631 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3632 Report string overflow if the output is too long.
3633
7d47b580
JB
36342011-07-04 Juanma Barranquero <lekktu@gmail.com>
3635
a555cb87
JB
3636 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3637 (syms_of_gnutls): Remove duplicate DEFSYM for
3638 Qgnutls_bootprop_verify_hostname_error, an error for
3639 Qgnutls_bootprop_verify_error (which is no longer used).
3640
7d47b580
JB
3641 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3642 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3643 Also (re)move comments that are misplaced or no longer relevant.
3644
1e49bfab
LMI
36452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3646
3647 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3648
1485f4c0
CY
36492011-07-03 Chong Yidong <cyd@stupidchicken.com>
3650
3651 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3652 and background color parameters if they have been changed.
3653
a9ab721e
LMI
36542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3655
3656 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3657
cf7cff57
PE
36582011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3659
2e13213d
PE
3660 * xsettings.c (SYSTEM_FONT): Define only when used.
3661 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3662
cf7cff57
PE
3663 * keymap.c (access_keymap_1): Now static.
3664
7a8e04f7
CY
36652011-07-02 Chong Yidong <cyd@stupidchicken.com>
3666
3667 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3668 leave any prefix arg for the up event (Bug#1586).
3669
61352f62
LMI
36702011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3671
69bb1ef7
LMI
3672 * lread.c (syms_of_lread): Mention single symbols defined by
3673 `defvar' or `defconst' (bug#7154).
3674
61352f62 3675 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3676 (Frequire): Mention get-load-suffixes.
61352f62 3677
28545e04
MR
36782011-07-02 Martin Rudalics <rudalics@gmx.at>
3679
3680 * window.h (window): Remove clone_number slot.
3681 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3682 Remove.
3683 (make_parent_window, make_window, saved_window)
3684 (Fset_window_configuration, save_window_save): Don't deal with
3685 clone numbers.
3686 * buffer.c (Qclone_number): Remove declaration.
3687 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3688
3349e122
SM
36892011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3690
3691 Add multiple inheritance to keymaps.
3692 * keymap.c (Fmake_composed_keymap): New function.
3693 (Fset_keymap_parent): Simplify.
3694 (fix_submap_inheritance): Remove.
3695 (access_keymap_1): New function extracted from access_keymap to handle
3696 embedded parents and handle lists of maps.
3697 (access_keymap): Use it.
3698 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3699 (Fcopy_keymap): Handle embedded parents.
3700 (Fcommand_remapping, define_as_prefix): Simplify.
3701 (Fkey_binding): Simplify.
3702 (syms_of_keymap): Move minibuffer-local-completion-map,
3703 minibuffer-local-filename-completion-map,
3704 minibuffer-local-must-match-map, and
3705 minibuffer-local-filename-must-match-map to Elisp.
3706 (syms_of_keymap): Defsubr make-composed-keymap.
3707 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3708 (parse_menu_item): Trivial simplification.
3709
3279eb87
GM
37102011-07-01 Glenn Morris <rgm@gnu.org>
3711
3712 * Makefile.in (SETTINGS_LIBS): Fix typo.
3713
4550efdf
KI
37142011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3715
3716 * coding.c (Fencode_coding_string): Record the last coding system
3717 used, as the function doc string says (bug#8738).
3718
0949d2b6
JD
37192011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3720
3721 * xsettings.c (store_monospaced_changed): Take new font as arg and
3722 check for change against current_mono_font.
3723 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3724 (emacs_settings_constructor, emacs_settings_get_property)
3725 (emacs_settings_set_property, emacs_settings_class_init)
3726 (emacs_settings_init, gsettings_obj): Remove.
3727 (something_changedCB): New function for HAVE_GSETTINGS.
3728 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3729 with value as argument.
3730 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3731 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3732 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3733 "changed".
3734
3735 * xgselect.c: Add defined (HAVE_GSETTINGS).
3736 (xgselect_initialize): Ditto.
3737
3738 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3739 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3740 xg_select.
3741
bbc6b304
PE
37422011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3743
3744 * eval.c (struct backtrace): Simplify and port the data structure.
3745 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3746 signed bit field, as this assumption is not portable and it makes
3747 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3748 "char debug_on_exit : 1" as this is not portable either; instead,
3749 use the portable "unsigned int debug_on_exit : 1". Remove unused
3750 member evalargs. Remove obsolete comments about cc bombing out.
3751
9851bfc5
JD
37522011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3753
51bb811f 3754 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3755 Let HAVE_GSETTINGS override HAVE_GCONF.
3756 (store_monospaced_changed): New function.
3757 (EMACS_SETTINGS): A new type derived from GObject to handle
3758 GSettings notifications.
3759 (emacs_settings_constructor, emacs_settings_get_property)
3760 (emacs_settings_set_property, emacs_settings_class_init):
3761 New functions.
3762 (gsettings_client, gsettings_obj): New variables.
3763 (GSETTINGS_SCHEMA): New define.
3764 (something_changedCB): Call store_monospaced_changed.
3765 (init_gsettings): New function.
3766 (xsettings_initialize): Call init_gsettings.
3767 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3768 to NULL.
3769
640c8776 3770 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3771 GCONF_CFLAGS/LIBS.
3772
5386012d
MR
37732011-06-29 Martin Rudalics <rudalics@gmx.at>
3774
3775 * window.c (resize_root_window, grow_mini_window)
3776 (shrink_mini_window): Rename Qresize_root_window to
3777 Qwindow_resize_root_window and Qresize_root_window_vertically to
3778 Qwindow_resize_root_window_vertically.
3779
f13e0b08
PE
37802011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3781
3782 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3783
94515237
JB
37842011-06-27 Juanma Barranquero <lekktu@gmail.com>
3785
3786 * makefile.w32-in: Redesign dependencies so they reflect more
3787 clearly which files are directly included by each source file,
3788 and not through other includes.
3789
e43b6e43
MR
37902011-06-27 Martin Rudalics <rudalics@gmx.at>
3791
3792 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3793 (sort_overlays, overlay_strings): When an overlay's clone number
3794 matches the window's clone number process the overlay even if
3795 the overlay's window property doesn't match the current window.
3796
d68443dc
MR
3797 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3798 (Fwindow_hchild): Rename to Fwindow_left_child.
3799 (Fwindow_next): Rename to Fwindow_next_sibling.
3800 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3801 (resize_window_check): Rename to window_resize_check.
3802 (resize_window_apply): Rename to window_resize_apply.
3803 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3804 (Fdelete_other_windows_internal, resize_frame_windows)
3805 (Fsplit_window_internal, Fdelete_window_internal)
3806 (grow_mini_window, shrink_mini_window)
3807 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3808
c7e73be5
JD
38092011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3810
3811 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3812 (emacs_fixed_set_min_size): Remove.
3813 (emacs_fixed_new): Take frame as argument.
3814
3815 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3816 (_EmacsFixedPrivate): Remove minwidth/height.
3817 Add struct frame *f.
3818 (emacs_fixed_init): Initialize priv->f.
3819 (get_parent_class, emacs_fixed_set_min_size): Remove.
3820 (emacs_fixed_new): Set priv->f to argument.
3821 (emacs_fixed_get_preferred_width)
3822 (emacs_fixed_get_preferred_height): Use min_width/height from
3823 frames size_hint to set minimum and natural (Bug#8919).
3824 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3825 and use min_width/height from frames size_hint to set
3826 min_width/height (Bug#8919).
3827
3828 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3829 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3830 Fix indentation.
c7e73be5 3831
cf99dcf8
EZ
38322011-06-26 Eli Zaretskii <eliz@gnu.org>
3833
3834 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3835 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3836 called at ZV.
3837
029529ac
CY
38382011-06-26 Chong Yidong <cyd@stupidchicken.com>
3839
3840 * process.c (wait_reading_process_output): Bypass select if
3841 waiting for a cell while ignoring keyboard input, and input is
3842 pending. Suggested by Jan Djärv (Bug#8869).
3843
7a7ef429
PE
38442011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3845
3846 Use gnulib's dup2 module instead of rolling our own.
3847 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3848
11fdef7d 38492011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3850
3851 * dispnew.c (scrolling_window): Before scrolling, turn off a
3852 mouse-highlight in the window being scrolled.
3853
cd3520a4
JB
38542011-06-24 Juanma Barranquero <lekktu@gmail.com>
3855
3856 Move DEFSYM to lisp.h and use everywhere.
3857
3858 * character.h (DEFSYM): Move declaration...
3859 * lisp.h (DEFSYM): ...here.
3860
3861 * gnutls.c:
3862 * minibuf.c:
3863 * w32menu.c:
3864 * w32proc.c:
3865 * w32select.c: Don't include character.h.
3866
3867 * alloc.c (syms_of_alloc):
3868 * buffer.c (syms_of_buffer):
3869 * bytecode.c (syms_of_bytecode):
3870 * callint.c (syms_of_callint):
3871 * casefiddle.c (syms_of_casefiddle):
3872 * casetab.c (init_casetab_once):
3873 * category.c (init_category_once, syms_of_category):
3874 * ccl.c (syms_of_ccl):
3875 * cmds.c (syms_of_cmds):
3876 * composite.c (syms_of_composite):
3877 * dbusbind.c (syms_of_dbusbind):
3878 * dired.c (syms_of_dired):
3879 * dispnew.c (syms_of_display):
3880 * doc.c (syms_of_doc):
3881 * editfns.c (syms_of_editfns):
3882 * emacs.c (syms_of_emacs):
3883 * eval.c (syms_of_eval):
3884 * fileio.c (syms_of_fileio):
3885 * fns.c (syms_of_fns):
3886 * frame.c (syms_of_frame):
3887 * fringe.c (syms_of_fringe):
3888 * insdel.c (syms_of_insdel):
3889 * keymap.c (syms_of_keymap):
3890 * lread.c (init_obarray, syms_of_lread):
3891 * macros.c (syms_of_macros):
3892 * msdos.c (syms_of_msdos):
3893 * print.c (syms_of_print):
3894 * process.c (syms_of_process):
3895 * search.c (syms_of_search):
3896 * sound.c (syms_of_sound):
3897 * syntax.c (init_syntax_once, syms_of_syntax):
3898 * terminal.c (syms_of_terminal):
3899 * textprop.c (syms_of_textprop):
3900 * undo.c (syms_of_undo):
3901 * w32.c (globals_of_w32):
3902 * window.c (syms_of_window):
3903 * xdisp.c (syms_of_xdisp):
3904 * xfaces.c (syms_of_xfaces):
3905 * xfns.c (syms_of_xfns):
3906 * xmenu.c (syms_of_xmenu):
3907 * xsettings.c (syms_of_xsettings):
3908 * xterm.c (syms_of_xterm): Use DEFSYM.
3909
4228cf16
TZ
39102011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3911
cd3520a4 3912 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3913
7fcccf1e
PE
39142011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3915
7efb4e0e
PE
3916 Integer and buffer overflow fixes (Bug#8873).
3917
ff5844ad
PE
3918 * print.c (printchar, strout): Check for string overflow.
3919 (PRINTPREPARE, printchar, strout):
3920 Don't set size unless allocation succeeds.
3921
90532f02
PE
3922 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3923 for sizes. Check for string overflow more accurately.
3924 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3925
6d84508d
PE
3926 * macros.c: Integer and buffer overflow fixes.
3927 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3928 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3929 Use ptrdiff_t, not int, for sizes.
3930 Don't increment bufsize until after realloc succeeds.
3931 Check for size-calculation overflow.
3932 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3933
437b2cb4
PE
3934 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3935
8b9ac8b4
PE
3936 * lread.c: Integer overflow fixes.
3937 (read_integer): Radix is now EMACS_INT, not int,
3938 to improve quality of diagnostics for out-of-range radices.
3939 Calculate buffer size correctly for out-of-range radices.
3940 (read1): Check for integer overflow in radices, and in
3941 read-circle numbers.
82cb60d3
PE
3942 (read_escape): Avoid int overflow.
3943 (Fload, openp, read_buffer_size, read1)
3944 (substitute_object_recurse, read_vector, read_list, map_obarray):
3945 Use ptrdiff_t, not int, for sizes.
3946 (read1): Use EMACS_INT, not int, for sizes.
20270765 3947 Check for size overflow.
8b9ac8b4 3948
7fcccf1e
PE
3949 * image.c (cache_image): Check for size arithmetic overflow.
3950
bfbbd7e7
PE
3951 * lread.c: Integer overflow issues.
3952 (saved_doc_string_size, saved_doc_string_length)
3953 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3954 Now ptrdiff_t, not int.
3955 (read1): Don't assume doc string length fits in int. Check for
3956 out-of-range doc string lengths.
3957 (read_list): Don't assume file position fits in int.
39019e54 3958 (read_escape): Check for hex character overflow.
bfbbd7e7 3959
4e323265
LL
39602011-06-22 Leo Liu <sdl.web@gmail.com>
3961
3962 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3963 Move to minibuffer.el.
3964
85fece3e
PE
39652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3966
20b84ce9 3967 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3968 The following patches are for when GLYPH_DEBUG && !XASSERT.
3969 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3970 * dispnew.c (flush_stdout):
3971 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3972 Mark as externally visible.
3973 * dispnew.c (check_window_matrix_pointers): Now static.
3974 * dispnew.c (window_to_frame_vpos):
3975 * xfns.c (unwind_create_frame):
3976 * xterm.c (x_check_font): Remove unused local.
3977 * scroll.c (CHECK_BOUNDS):
3978 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3979 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3980 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3981 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3982 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3983 Now static.
3984 (debug_method_add): Use va_list and vsprintf rather than relying
3985 on undefined behavior with wrong number of arguments.
3986 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3987 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3988 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3989 since we're not interested in debugging glyphs with old libraries.
3990 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3991 GCC 4.6.0's static checking.
3992
0766b489
PE
39932011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3994
31fd4b32
PE
3995 Integer overflow and signedness fixes (Bug#8873).
3996 A few related buffer overrun fixes, too.
3997
b79e8648
PE
3998 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3999
0766b489
PE
4000 * dispextern.h (struct face.stipple):
4001 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4002 (x_bitmap_mask, x_allocate_bitmap_record)
4003 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4004 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4005 (x_create_bitmap_from_xpm_data):
4006 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4007 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4008 (.bitmaps_last):
4009 * xfaces.c (load_pixmap):
4010 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4011 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4012 (.bitmaps_last, struct x_output.icon_bitmap):
4013 Use ptrdiff_t, not int, for bitmap indexes.
4014 (x_allocate_bitmap_record): Check for size overflow.
4015 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4016
b081724f
PE
4017 Use ptrdiff_t, not int, for overlay counts.
4018 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4019 * editfns.c (overlays_around, get_pos_property):
4020 * textprop.c (get_char_property_and_overlay):
4021 * xdisp.c (next_overlay_change, note_mouse_highlight):
4022 * xfaces.c (face_at_buffer_position):
21514da7
PE
4023 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4024 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4025 (Fnext_overlay_change, Fprevious_overlay_change)
4026 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4027 Use ptrdiff_t, not int, for sizes.
21514da7 4028 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4029
3de73e5e
PE
4030 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4031
2606c57b
PE
4032 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4033 (x_session_initialize): Do not assume string length fits in int.
4034
aaafe47a
PE
4035 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4036 This is unlikely, but can occur if DPI is outlandish.
4037
2674ddc8 4038 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4039 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4040
28154962
PE
4041 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4042 * xrdb.c (magic_file_p, search_magic_path):
4043 Omit last arg SUFFIX; it was always 0. All callers changed.
4044 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4045
7de51af5
PE
4046 * xfont.c (xfont_match): Avoid need for strlen.
4047
25ed6cc3
PE
4048 * xfns.c: Don't assume strlen fits in int.
4049 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4050
4eab31dd
PE
4051 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4052 not unsigned long, as we prefer signed integers. All callers changed.
4053 Detect integer overflow in repeat count.
4054 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4055 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4056
171e2a58
PE
4057 * termcap.c: Don't assume sizes fit in int and never overflow.
4058 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4059 (gobble_line): Check for size-calculation overflow.
4060
ad39faca 4061 * minibuf.c (Fread_buffer):
6e5bb2dc 4062 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4063 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4064 Don't assume string length fits in int.
4065
52c61c22 4066 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4067 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4068
b5b8c9e5
PE
4069 * font.c: Don't assume string length fits in int.
4070 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4071 Use ptrdiff_t, not int.
ccd6111c
PE
4072 (font_intern_prop): Don't assume string length fits in int.
4073 Don't assume integer property fits in fixnum.
4074 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4075
882f0d81 4076 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4077 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4078 Reformulate so as not to need the command string.
4079 Invoke gzip -cd rather than gunzip, as it's more portable.
4080 (lock_info_type, lock_file_1, lock_file):
4081 Don't assume pid_t and time_t fit in unsigned long.
4082 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4083 (current_lock_owner): Prefer signed type for sizes.
4084 Use memcpy, not strncpy, where memcpy is what is really wanted.
4085 Don't assume (via atoi) that time_t and pid_t fit in int.
4086 Check for time_t and/or pid_t out of range, e.g., via a network share.
4087 Don't alloca where an auto var works fine.
4088
93f4cf88
PE
4089 * fileio.c: Fix some integer overflow issues.
4090 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4091 Don't assume string length fits in int.
4092 (directory_file_name): Don't assume string length fits in long.
4093 (make_temp_name): Don't assume pid fits in int, or that its print
4094 length is less than 20.
4095
f3e92b69
PE
4096 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4097
1bfdaf10
PE
4098 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4099
35016e9a
PE
4100 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4101
3d1e65a1
PE
4102 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4103 We prefer signed integers, even for size calculations.
4104
0b963a93
PE
4105 * emacs.c: Don't assume string length fits in 'int'.
4106 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4107 (main): Don't invoke strlen when not needed.
4108
573f4b54
PE
4109 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4110 (XD_DEBUG_MESSAGE): Don't waste a byte.
4111
989f33ba
PE
4112 * callproc.c (getenv_internal_1, getenv_internal)
4113 (Fgetenv_internal):
965d34eb
PE
4114 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4115
e4d29b33
PE
4116 * lread.c (invalid_syntax): Omit length argument.
4117 All uses changed. This doesn't fix a bug, but it simplifies the
4118 code away from its former Hollerith-constant appearance, and it's
4119 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4120 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4121
eb49b136
PE
4122 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4123 This didn't break anything, but it didn't help either.
4124 It's confusing to put a bogus integer in a place where the actual
4125 value does not matter.
9f62aeb1 4126 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4127 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4128
15375a22
PE
4129 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4130 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4131 implementation.
b61cc01c
PE
4132 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4133 We prefer signed types, and the value cannot exceed the EMACS_INT
4134 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4135 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4136 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4137 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4138
53b2623d
PE
4139 * indent.c (sane_tab_width): New function.
4140 (current_column, scan_for_column, Findent_to, position_indentation)
4141 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4142 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4143
51cab52b 4144 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4145
f2ed8a70
PE
4146 * lisp.h (lint_assume): New macro.
4147 * composite.c (composition_gstring_put_cache):
4148 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4149
abe80cc6
PE
4150 * editfns.c, insdel.c:
4151 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4152
b02c740e
PE
4153 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4154
ebc96716
PE
4155 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4156
b4e50fa0 4157 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4158 Use much-faster test for byte-length change.
311d5d7c 4159 Don't assume string byte-length fits in 'int'.
a4cf38e4 4160 Check that character arg fits in 'int'.
85461888 4161 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4162
c0c1ee9f
PE
4163 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4164
a498d7f4
PE
4165 * fns.c (concat): Catch string overflow earlier.
4166 Do not rely on integer wraparound.
4167
51cab52b
PE
4168 * dispextern.h (struct it.overlay_strings_charpos)
4169 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4170 * xdisp.c (forward_to_next_line_start)
4171 (back_to_previous_visible_line_start)
4172 (reseat_at_next_visible_line_start, next_element_from_buffer):
4173 Don't arbitrarily truncate the value of 'selective' to int.
4174
76031fad
PE
4175 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4176
5eb55db9
PE
4177 * composite.c: Don't truncate sizes to 'int'.
4178 (composition_gstring_p, composition_reseat_it)
4179 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4180 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4181 not EMACS_UINT, for indexes.
5eb55db9 4182
0703a717
PE
4183 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4184
d6202519
PE
4185 * buffer.c: Include <verify.h>.
4186 (struct sortvec.priority, struct sortstr.priority):
8961a454 4187 Now EMACS_INT, not int.
c20998a7 4188 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4189 (struct sortstr.size, record_overlay_string)
4190 (struct sortstrlist.size, struct sortlist.used):
4191 Don't truncate size to int.
4192 (record_overlay_string): Check for size-calculation overflow.
d6202519 4193 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4194
d5a19415
JM
41952011-06-22 Jim Meyering <meyering@redhat.com>
4196
029529ac 4197 Don't leak an XBM-image-sized buffer
d5a19415
JM
4198 * image.c (xbm_load): Free the image buffer after using it.
4199
a9041e6c
PE
42002011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4201
4202 Port to Sun C.
4203 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4204 that Sun C diagnosed.
4205 * fns.c (secure_hash): Fix pointer signedness issue.
4206 * intervals.c (static_offset_intervals): New function.
4207 (offset_intervals): Use it.
4208
7f3f739f
LL
42092011-06-21 Leo Liu <sdl.web@gmail.com>
4210
4211 * deps.mk (fns.o):
4212 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4213 sha512.h.
4214
4215 * fns.c (secure_hash): Rename from crypto_hash_function and change
4216 the first arg to accept symbols.
5b66d427 4217 (Fsecure_hash): New primitive.
7f3f739f
LL
4218 (syms_of_fns): New symbols.
4219
76147d94
DD
42202011-06-20 Deniz Dogan <deniz@dogan.se>
4221
4222 * process.c (Fset_process_buffer): Clarify return value in
4223 docstring.
4224
7d7d0045
CY
42252011-06-18 Chong Yidong <cyd@stupidchicken.com>
4226
4227 * dispnew.c (add_window_display_history): Use BVAR.
4228
4229 * xdisp.c (debug_method_add): Use BVAR.
4230 (check_window_end, dump_glyph_matrix, dump_glyph)
4231 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4232
4233 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4234 Likewise.
4235
4236 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4237 check till after the cache is created in init_frame_faces.
4238
ff2bc410
SM
42392011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4240
4241 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4242
28177add
PE
42432011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4244
dd3482fe
PE
4245 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4246 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4247 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4248
393d71f3 4249 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4250 * fileio.c (Finsert_file_contents):
4251 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4252 Remove the old (too-loose) buffer overflow checks.
4253 They weren't needed, since make_gap checks for buffer overflow.
4254 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4255 The old code merely checked for Emacs fixnum overflow, and relied
4256 on undefined (wraparound) behavior. The new code avoids undefined
4257 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4258
2e6813b0 4259 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4260 Tune. Don't use wider integers than needed. Don't use alloca.
4261 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4262
599a9e4f
PE
4263 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4264
99561444
PE
4265 * insdel.c, lisp.h (buffer_overflow): New function.
4266 (insert_from_buffer_1, replace_range, replace_range_2):
4267 * insdel.c (make_gap_larger):
4268 * editfns.c (Finsert_char):
4269 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4270
28177add
PE
4271 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4272
e69dafad
PE
42732011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4274
a7af7fde 4275 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4276
b1c46f02
PE
4277 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4278 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4279
e69dafad
PE
4280 * fileio.c: Don't assume EMACS_INT fits in off_t.
4281 (emacs_lseek): New static function.
4282 (Finsert_file_contents, Fwrite_region): Use it.
4283 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4284
566684ea
PE
4285 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4286
e6966cd6
PE
4287 * fns.c: Don't overflow int when computing a list length.
4288 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4289 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4290 truncation on 64-bit hosts. Check for QUIT every
4291 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4292 faster and is responsive enough.
4293 (Flength): Report an error instead of overflowing an integer.
4294 (Fsafe_length): Return a float if the value is not representable
4295 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4296 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4297 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4298
dd0b0efb
PE
4299 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4300 (header_size, word_size): New constants.
4301 (allocate_vectorlike): Don't check size overflow here.
4302 (allocate_vector): Check it here instead, since this is the only
4303 caller of allocate_vectorlike that could cause overflow.
4304 Check that the new vector's length is representable as a fixnum.
4305
86fe5cfe
PE
4306 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4307 The previous code was bogus. For example, next_almost_prime (32)
4308 returned 39, which is undesirable as it is a multiple of 3; and
4309 next_almost_prime (24) returned 25, which is a multiple of 5 so
4310 why was the code bothering to check for multiples of 7?
4311
80e88859
PE
4312 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4313
4a2f0ad6
PE
4314 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4315
f66c7cf8
PE
4316 Variadic C functions now count arguments with ptrdiff_t.
4317 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4318 Back then I didn't know that the Emacs coding style prefers signed int.
4319 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4320 were being counted with int, which may truncate counts on 64-bit
4321 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4322 * lisp.h (struct Lisp_Subr.function.aMANY)
4323 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4324 Arg counts are now ptrdiff_t, not size_t.
4325 All variadic functions and their callers changed accordingly.
4326 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4327 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4328 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4329 * callint.c (Fcall_interactively): Check arg count for overflow,
4330 to avoid potential buffer overrun. Use signed char, not 'int',
4331 for 'varies' array, so that we needn't bother to check its size
4332 calculation for overflow.
4333 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4334 * eval.c (apply_lambda):
4335 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4336 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4337 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4338
a1759b76
PE
4339 * callint.c (Fcall_interactively): Don't use index var as event count.
4340
d96be9fc
PE
4341 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4342 * mem-limits.h (SIZE): Remove; no longer used.
4343
a690a978 4344 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4345
578c21e6
PE
4346 Remove unnecessary casts.
4347 * xterm.c (x_term_init):
4348 * xfns.c (x_set_border_pixel):
4349 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4350 These aren't needed now that we assume ANSI C.
4351
96f53c6c
PE
4352 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4353 It's more likely to cause problems (due to unsigned overflow)
4354 than to cure them.
4355
83c77d31
PE
4356 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4357
ee2079f1
PE
4358 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4359
6da65536
PE
4360 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4361
7147c4a4
PE
4362 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4363
193e32d9
PE
4364 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4365
e5533da6
PE
4366 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4367
9910e595
PE
4368 GLYPH_CODE_FACE returns EMACS_INT, not int.
4369 * dispextern.h (merge_faces):
4370 * xfaces.c (merge_faces):
01103c44
PE
4371 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4372 Don't assume EMACS_INT fits in int.
9910e595 4373
2638320e
PE
4374 * character.h (CHAR_VALID_P): Remove unused parameter.
4375 * fontset.c, lisp.h, xdisp.c: All uses changed.
4376
045eb8d9
PE
4377 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4378
c1f134b5
PE
4379 * fns.c (concat): Minor tuning based on overflow analysis.
4380 This doesn't fix any bugs. Use int to hold character, instead
4381 of constantly refetching from Emacs object. Use XFASTINT, not
4382 XINT, for value known to be a character. Don't bother comparing
4383 a single byte to 0400, as it's always less.
4384
395fcb93 4385 * floatfns.c (Fexpt):
327eeec8
PE
4386 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4387
abbd3d23
PE
4388 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4389 for characters.
4390
684a03ef
PE
4391 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4392
0fed43f3
PE
4393 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4394 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4395 incorrectly succeed when S was a string, because 4294967386 was
4396 truncated before it was used.
4397
8fd02eb7
PE
4398 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4399 Otherwise, an out-of-range integer could cause undefined behavior
4400 on a 64-bit host.
4401
f8c86b69
PE
4402 * composite.c: Use int, not EMACS_INT, for characters.
4403 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4404 EMACS_INT, for values that are known to be in character range.
4405 This doesn't fix any bugs but is the usual style inside Emacs and
4406 may generate better code on 32-bit machines.
4407
34206dd2
PE
4408 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4409 This is for reasons similar to the recent CHAR_STRING fix.
4410 * charset.c (Fencode_char): Check that character arg is actually
4411 a character. Pass an int to ENCODE_CHAR.
4412 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4413 wider than 'int', as a compile-time check to prevent future regressions
4414 in this area.
4415
c5958d4c 4416 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4417
4418 Make sure a 64-bit char is never passed to CHAR_STRING.
4419 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4420 by silently ignoring the top 32 bits, allowing some values
4421 that were far too large to be valid characters.
4422 * character.h: Include <verify.h>.
4423 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4424 arguments are no wider than unsigned, as a compile-time check
4425 to prevent future regressions in this area.
4426 * data.c (Faset):
01103c44 4427 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4428 (Fsubst_char_in_region):
4429 * fns.c (concat):
4430 * xdisp.c (decode_mode_spec_coding):
4431 Adjust to CHAR_STRING's new requirement.
4432 * editfns.c (Finsert_char, Fsubst_char_in_region):
4433 * fns.c (concat): Check that character args are actually
4434 characters. Without this test, these functions did the wrong
4435 thing with wildly out-of-range values on 64-bit hosts.
4436
d37ca623
PE
4437 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4438 These casts should not be needed on 32-bit hosts, either.
4439 * keyboard.c (read_char):
4440 * lread.c (Fload): Remove casts to unsigned.
4441
ea204efb
PE
4442 * lisp.h (UNSIGNED_CMP): New macro.
4443 This fixes comparison bugs on 64-bit hosts.
4444 (ASCII_CHAR_P): Use it.
4445 * casefiddle.c (casify_object):
01103c44 4446 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4447 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4448 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4449 * dispextern.h (FACE_FROM_ID):
4450 * keyboard.c (read_char): Use UNSIGNED_CMP.
4451
41cb286c
PE
4452 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4453 not to EMACS_INT, to avoid GCC warning.
4454
4a1b9832
PE
4455 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4456
55daad71
PE
4457 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4458 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4459 isn't needed on 32-bit machines.
8f95c75c 4460
01103c44
PE
4461 * buffer.c (Fgenerate_new_buffer_name):
4462 Use EMACS_INT for count, not int.
0ceccced 4463 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4464
4465 * data.c (Qcompiled_function): Now static.
4466
c6f072e7
PE
4467 * window.c (window_body_lines): Now static.
4468
20ce5912
PE
4469 * image.c (gif_load): Rename local to avoid shadowing.
4470
9c4c5f81
PE
4471 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4472 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4473 * alloc.c (make_save_value): Integer argument is now of type
4474 ptrdiff_t, not int.
4475 (mark_object): Use ptrdiff_t, not int.
4476 * lisp.h (pD): New macro.
4477 * print.c (print_object): Use it.
4478
c0c5c8ae
PE
4479 * alloc.c: Use EMACS_INT, not int, to count objects.
4480 (total_conses, total_markers, total_symbols, total_vector_size)
4481 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4482 (total_free_floats, total_floats, total_free_intervals)
4483 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4484 Now EMACS_INT, not int. All uses changed.
4485 (Fgarbage_collect): Compute overall total using a double, so that
4486 integer overflow is less likely to be a problem. Check for overflow
4487 when converting back to an integer.
5a25e253
PE
4488 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4489 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4490 These were 'int' variables that could overflow on 64-bit hosts;
4491 they were never used, so remove them instead of repairing them.
211a0b2a 4492 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4493 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4494 Previously, this ceilinged at INT_MAX, but that doesn't work on
4495 64-bit machines.
e46bb31a 4496 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4497
c78baabf 4498 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4499 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4500 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4501 when a (possibly-narrower) signed value would do just as well.
4502 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4503
c9d624c6
PE
4504 * alloc.c: Catch some string size overflows that we were missing.
4505 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4506 for convenience in STRING_BYTES_MAX.
4507 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4508 The definition here is exact; the one in lisp.h was approximate.
4509 (allocate_string_data): Check for string overflow. This catches
4510 some instances we weren't catching before. Also, it catches
4511 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4512 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4513 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4514
c9d624c6
PE
4515 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4516 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4517 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4518
353032ce
PE
4519 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4520
2bccce07
PE
4521 * alloc.c (Fmake_string): Check for out-of-range init.
4522
0ac30604
SM
45232011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4524
4525 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4526
c195f2de
JD
45272011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4528
4529 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4530 xg_get_default_scrollbar_width.
4531
4532 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4533 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4534 (style_changed_cb): Call update_theme_scrollbar_width and call
4535 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4536 all frames (Bug#8505).
4537 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4538 Call gtk_window_set_resizable if HAVE_GTK3.
4539 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4540 and height if HAVE_GTK3 (Bug#8505).
4541 (scroll_bar_width_for_theme): New variable.
4542 (update_theme_scrollbar_width): New function.
4543 (xg_get_default_scrollbar_width): Move code to
4544 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4545 (xg_initialize): Call update_theme_scrollbar_width.
4546
4547 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4548
4549 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4550
e10ac9f1
MR
45512011-06-12 Martin Rudalics <rudalics@gmx.at>
4552
4553 * frame.c (make_frame): Call other_buffer_safely instead of
4554 other_buffer.
4555
4556 * window.c (temp_output_buffer_show): Call display_buffer with
4557 second argument Vtemp_buffer_show_specifiers and reset latter
4558 immediately after the call.
4559 (Vtemp_buffer_show_specifiers): New variable.
4560 (auto_window_vscroll_p, next_screen_context_lines)
4561 (Vscroll_preserve_screen_position): Remove leading asterisks from
4562 doc-strings.
4563
2d3c217e 45642011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4565
7b7f97e8 4566 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4567 * buffer.c (Qclone_number): Remove for now, as it's unused.
4568 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4569 (record_buffer): Remove unused local.
4570 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4571 (set_frame_buffer_list): Remove; unused.
4572 * frame.h (other_visible_frames): Remove decl.
4573 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4574 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4575 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4576 if HAVE_GPM.
4577 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4578 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4579 Define only if HAVE_GPM.
4580 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4581 (update_hints_inhibit): Remove; never set. All uses removed.
4582 * widgetprv.h (emacsFrameClassRec): Remove decl.
4583 * window.c (delete_deletable_window): Now returns void, since it
4584 wasn't returning anything.
4585 (compare_window_configurations): Remove unused locals.
4586 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4587 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4588 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4589 the same widths as pointers. This follows up on the 2011-05-06 patch.
4590 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4591 * xterm.h: Likewise.
4592 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4593
1384b89e
JB
45942011-06-12 Juanma Barranquero <lekktu@gmail.com>
4595
4596 * makefile.w32-in: Update dependencies.
4597 (LISP_H): Add lib/intprops.h.
4598
1100a63c
CY
45992011-06-11 Chong Yidong <cyd@stupidchicken.com>
4600
4601 * image.c (gif_load): Add animation frame delay to the metadata.
4602 (syms_of_image): Use DEFSYM. New symbol `delay'.
4603
6198ccd0
MR
46042011-06-11 Martin Rudalics <rudalics@gmx.at>
4605
4606 * window.c (delete_deletable_window): Re-add.
4607 (Fset_window_configuration): Rewrite to handle dead buffers and
4608 consequently deletable windows.
4609 (window_tree, Fwindow_tree): Remove. Supply functionality in
4610 window.el.
4611 (compare_window_configurations): Simplify code.
4612
b6e3633c
AS
46132011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4614
1ab0dee5
AS
4615 * image.c (imagemagick_load_image): Fix type mismatch.
4616 (Fimagemagick_types): Likewise.
4617
b6e3633c
AS
4618 * window.h (replace_buffer_in_windows): Declare.
4619
9397e56f
MR
46202011-06-11 Martin Rudalics <rudalics@gmx.at>
4621
4622 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4623 Qclone_number. Remove external declaration of Qdelete_window.
4624 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4625 code.
640c8776
SM
4626 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4627 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4628 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4629 buffer list implementation.
4630 (other_buffer_safely): New function.
4631 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4632 calls to replace_buffer_in_windows and
4633 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4634 if allowed.
4635 (record_buffer): Inhibit quitting and rewrite using quittable
4636 functions. Run Qbuffer_list_update_hook if allowed.
4637 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4638 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4639 Move switch-to-buffer to window.el.
9397e56f
MR
4640 (bury-buffer): Move to window.el.
4641 (Vbuffer_list_update_hook): New variable.
4642
4643 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4644 section.
4645
4646 * window.h (resize_frame_windows): Move up in code.
4647 (Fwindow_frame): Remove EXFUN.
4648 (replace_buffer_in_all_windows): Remove prototype.
4649 (replace_buffer_in_windows_safely): Add prototype.
4650
4651 * window.c: Declare Qdelete_window static again. Move down
4652 declaration of select_count.
4653 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4654 (Fother_window): Move to window.el.
4655 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4656 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4657 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4658 window.el.
4659 (replace_buffer_in_windows): Implement by calling
4660 Qreplace_buffer_in_windows.
4661 (replace_buffer_in_all_windows): Remove with some functionality
4662 moved into replace_buffer_in_windows_safely.
4663 (replace_buffer_in_windows_safely): New function.
4664 (select_window_norecord, select_frame_norecord): Move in front
4665 of run_window_configuration_change_hook. Remove now obsolete
4666 declarations.
640c8776
SM
4667 (Fset_window_buffer): Rewrite doc-string.
4668 Call Qrecord_window_buffer.
9397e56f
MR
4669 (keys_of_window): Move binding for other-window to window.el.
4670
b50691aa
CY
46712011-06-11 Chong Yidong <cyd@stupidchicken.com>
4672
4673 * dispextern.h (struct image): Replace data member, whose int_val
4674 and ptr_val fields were not used by anything, with a single
4675 lisp_val object.
4676
4677 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4678 (gif_clear_image, gif_load, imagemagick_load_image)
4679 (gs_clear_image, gs_load): Callers changed.
4680
3f754b86
PE
46812011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4682
cca69397
PE
4683 * buffer.h: Include <time.h>, for time_t.
4684 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4685
109e28d0
PE
4686 Fix minor problems found by static checking.
4687
60737f02
PE
4688 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4689
4b66faf3
PE
4690 Make identifiers static if they are not used in other modules.
4691 * data.c (Qcompiled_function, Qframe, Qvector):
4692 * image.c (QimageMagick, Qsvg):
4693 * minibuf.c (Qmetadata):
4694 * window.c (resize_window_check, resize_root_window): Now static.
4695 * window.h (resize_window_check, resize_root_window): Remove decls.
4696
109e28d0
PE
4697 * window.c (window_deletion_count, delete_deletable_window):
4698 Remove; unused.
46a4ce9e
PE
4699 (window_body_lines): Now static.
4700 (Fdelete_other_windows_internal): Mark vars as initialized.
4701 Make sure 'resize_failed' is initialized.
4702 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4703 (resize_window_apply): Remove unused local.
4704 * window.h (delete_deletable_window): Remove decl.
4705
109e28d0 4706 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4707 (imagemagick_load_image): Fix pointer signedness problem by changing
4708 last arg from unsigned char * to char *. All uses changed.
4709 Also, fix a local for similar reasons.
4710 Remove unused locals. Remove locals to avoid shadowing.
4711 (fn_rsvg_handle_free): Remove; unused.
4712 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4713 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4714
3f754b86
PE
4715 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4716
2547adb1
CY
47172011-06-10 Chong Yidong <cyd@stupidchicken.com>
4718
4719 * image.c (gif_load): Fix omitted cast error introduced by
4720 2011-06-06 change.
4721
2c8e37d4
MR
47222011-06-10 Martin Rudalics <rudalics@gmx.at>
4723
4724 * window.h (resize_proportionally, orig_total_lines)
4725 (orig_top_line): Remove from window structure.
4726 (set_window_height, set_window_width, change_window_heights)
4727 (Fdelete_window): Remove prototypes.
4728 (resize_frame_windows): Remove duplicate declaration.
4729
440a42e3
EZ
47302011-06-10 Eli Zaretskii <eliz@gnu.org>
4731
4732 * window.h (resize_frame_windows, resize_window_check)
4733 (delete_deletable_window, resize_root_window)
4734 (resize_frame_windows): Declare prototypes.
4735
4736 * window.c (resize_window_apply): Make definition be "static" to
4737 match the prototype.
4738
562dd5e9
MR
47392011-06-10 Martin Rudalics <rudalics@gmx.at>
4740
4741 * window.c: Remove declarations of Qwindow_size_fixed,
4742 window_min_size_1, window_min_size_2, window_min_size,
4743 size_window, window_fixed_size_p, enlarge_window, delete_window.
4744 Remove static from declaration of Qdelete_window, it's
4745 temporarily needed by Fbury_buffer.
4746 (replace_window): Don't assign orig_top_line and
4747 orig_total_lines.
4748 (Fdelete_window, delete_window): Remove. Window deletion is
4749 handled by window.el.
640c8776
SM
4750 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4751 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4752 (Fdelete_other_windows): Remove. Deleting other windows is
4753 handled by window.el.
4754 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4755 handled in window.el.
4756 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4757 Window minimum sizes are handled in window.el.
4758 (shrink_windows, size_window, set_window_height)
4759 (set_window_width, change_window_heights, window_height)
4760 (window_width, CURBEG, CURSIZE, enlarge_window)
4761 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4762 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4763 handled in window.el.
4764 (make_dummy_parent): Rename to make_parent_window and give it a
4765 second argument horflag.
4766 (make_window): Don't set resize_proportionally any more.
4767 (Fsplit_window): Remove. Windows are split in window.el.
4768 (save_restore_action, save_restore_orig_size)
4769 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4770 Resize mini windows in window.el.
4771 (grow_mini_window, shrink_mini_window): Implement by calling
4772 Qresize_root_window_vertically, resize_window_check and
4773 resize_window_apply.
640c8776
SM
4774 (saved_window, Fset_window_configuration, save_window_save):
4775 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4776 resize_proportionally.
4777 (window_min_height, window_min_width): Move to window.el.
4778 (keys_of_window): Move bindings for delete-other-windows,
4779 split-window, delete-window and enlarge-window to window.el.
4780
4781 * buffer.c: Temporarily extern Qdelete_window.
4782 (Fbury_buffer): Temporarily call Qdelete_window instead of
4783 Fdelete_window (Fbury_buffer will move to window.el soon).
4784
4785 * frame.c (set_menu_bar_lines_1): Remove code handling
4786 orig_top_line and orig_total_lines.
4787
4788 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4789 set_window_height but set heights directly.
4790 (change_frame_size_1): Use resize_frame_windows.
4791
4792 * xdisp.c (init_xdisp): Don't use set_window_height but set
4793 heights directly.
4794
640c8776
SM
4795 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4796 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4797 run_window_configuration_change_hook.
4798
4799 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4800 instead of change_window_heights and run
4801 run_window_configuration_change_hook.
4802
1a13852e
MR
48032011-06-09 Martin Rudalics <rudalics@gmx.at>
4804
4805 * window.c (replace_window): Rename second argument REPLACEMENT to
4806 NEW. New third argument SETFLAG. Rewrite.
4807 (delete_window, make_dummy_parent): Call replace_window with
4808 third argument 1.
4809 (window_list_1): Move down in code.
4810 (run_window_configuration_change_hook): Move set_buffer part
4811 before select_frame_norecord part in order to unwind correctly.
4812 Rename count1 to count.
4813 (recombine_windows, delete_deletable_window, resize_root_window)
4814 (Fdelete_other_windows_internal)
4815 (Frun_window_configuration_change_hook, make_parent_window)
4816 (resize_window_check, resize_window_apply, Fresize_window_apply)
4817 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4818 (Fdelete_window_internal, Fresize_mini_window_internal):
4819 New functions.
1a13852e
MR
4820 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4821
f3d1777e
MR
48222011-06-08 Martin Rudalics <rudalics@gmx.at>
4823
496e208e
MR
4824 * window.h (window): Add some new members to window structure -
4825 normal_lines, normal_cols, new_total, new_normal, clone_number,
4826 splits, nest, prev_buffers, next_buffers.
4827 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4828 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4829
f3d1777e
MR
4830 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4831 Remove.
496e208e
MR
4832 (make_dummy_parent): Set new members of windows structure.
4833 (make_window): Move down in code. Handle new members of window
4834 structure.
4835 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4836 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4837 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4838 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4839 (Fset_window_next_buffers, Fset_window_clone_number):
4840 New functions.
496e208e
MR
4841 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4842 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4843 Doc-string fixes.
4844 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4845 Argument WINDOW can be now internal window too.
4846 (Fwindow_use_time): Move up in code.
4847 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4848 Rewrite doc-string.
4849 (Fset_window_configuration, saved_window)
4850 (Fcurrent_window_configuration, save_window_save): Handle new
4851 members of window structure.
b9e809c2
MR
4852 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4853 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4854 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4855 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4856 Qget_mru_window, Qresize_root_window,
4857 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4858 Qauto_buffer_name; staticpro them.
f3d1777e 4859
abde8f8c
MR
48602011-06-07 Martin Rudalics <rudalics@gmx.at>
4861
4862 * window.c (Fwindow_total_size, Fwindow_left_column)
4863 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4864 (Fwindow_list_1): New functions.
4865 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4866 (Fwindow_width, Fscroll_left, Fscroll_right):
4867 Use window_body_cols instead of window_box_text_cols.
4868 (delete_window, Fset_window_configuration):
4869 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4870 (delete_all_subwindows): Take a window as argument and not a
4871 structure. Rewrite.
190b47e6
MR
4872 (window_loop): Remove handling of GET_LRU_WINDOW and
4873 GET_LARGEST_WINDOW.
4874 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4875
4876 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4877 window_box_text_cols. delete_all_subwindows now takes a
4878 Lisp_Object as argument.
abde8f8c 4879
640c8776
SM
4880 * indent.c (compute_motion, Fcompute_motion):
4881 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4882
fa8a67e6
MR
4883 * frame.c (delete_frame): Call delete_all_subwindows with root
4884 window as argument.
4885
a54e3482
DC
48862011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4887
4888 * fns.c (Fputhash): Document return value.
4889
60002bf5
CY
48902011-06-06 Chong Yidong <cyd@stupidchicken.com>
4891
4892 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4893
0c671da6 48942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4895
b862a52a 4896 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4897
be44ca6c
PE
4898 Check for overflow when converting integer to cons and back.
4899 * charset.c (Fdefine_charset_internal, Fdecode_char):
4900 Use cons_to_unsigned to catch overflow.
4901 (Fencode_char): Use INTEGER_TO_CONS.
4902 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4903 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4904 * data.c (long_to_cons, cons_to_long): Remove.
4905 (cons_to_unsigned, cons_to_signed): New functions.
4906 These signal an error for invalid or out-of-range values.
4907 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4908 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4909 * font.c (Ffont_variation_glyphs):
4910 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4911 * lisp.h: Include <intprops.h>.
4912 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4913 (cons_to_signed, cons_to_unsigned): New decls.
4914 (long_to_cons, cons_to_long): Remove decls.
4915 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4916 (Fprimitive_undo): Use CONS_TO_INTEGER.
4917 * xfns.c (Fx_window_property): Likewise.
4918 * xselect.c: Include <limits.h>.
4919 (x_own_selection, selection_data_to_lisp_data):
4920 Use INTEGER_TO_CONS.
4921 (x_handle_selection_request, x_handle_selection_clear)
4922 (x_get_foreign_selection, Fx_disown_selection_internal)
4923 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4924 (lisp_data_to_selection_data): Use cons_to_unsigned.
4925 (x_fill_property_data): Use cons_to_signed.
4926 Report values out of range.
4927
d1f3d2af
PE
4928 Check for buffer and string overflow more precisely.
4929 * buffer.h (BUF_BYTES_MAX): New macro.
4930 * lisp.h (STRING_BYTES_MAX): New macro.
4931 * alloc.c (Fmake_string):
4932 * character.c (string_escape_byte8):
4933 * coding.c (coding_alloc_by_realloc):
4934 * doprnt.c (doprnt):
4935 * editfns.c (Fformat):
4936 * eval.c (verror):
4937 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4938 since they may not be the same number.
4939 * editfns.c (Finsert_char):
4940 * fileio.c (Finsert_file_contents):
4941 Likewise for BUF_BYTES_MAX.
4942
dd52fcea
PE
4943 * image.c: Use ptrdiff_t, not int, for sizes.
4944 (slurp_file): Switch from int to ptrdiff_t.
4945 All uses changed.
4946 (slurp_file): Check that file size fits in both size_t (for
4947 malloc) and ptrdiff_t (for sanity and safety).
4948
7f9bbdbb
PE
4949 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4950 if b->modtime has its maximal value.
4951
dfe18f82
PE
4952 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4953
84acfcf0
PE
4954 Don't assume time_t can fit into int.
4955 * buffer.h (struct buffer.modtime): Now time_t, not int.
4956 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4957 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4958
ccd9a01a
PE
4959 Minor fixes for signed vs unsigned integers.
4960 * character.h (MAYBE_UNIFY_CHAR):
4961 * charset.c (maybe_unify_char):
4962 * keyboard.c (read_char, reorder_modifiers):
4963 XINT -> XFASTINT, since the integer must be nonnegative.
4964 * ftfont.c (ftfont_spec_pattern):
4965 * keymap.c (access_keymap, silly_event_symbol_error):
4966 XUINT -> XFASTINT, since the integer must be nonnegative.
4967 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4968 since it makes no difference and we prefer signed.
4969 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4970 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4971 nonnegative.
4972
d6d100dd
SM
49732011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4974
4975 * window.h (Fwindow_frame): Declare.
4976
2b6148e4
PE
49772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4978
4979 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4980 (SPARE_MEMORY): Always define.
4981 (LARGE_REQUEST): Remove.
4982 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4983
f230ecc9
MR
49842011-06-06 Martin Rudalics <rudalics@gmx.at>
4985
727e958e
MR
4986 * lisp.h: Move EXFUNS for Fframe_root_window,
4987 Fframe_first_window and Fset_frame_selected_window to window.h.
4988
4989 * window.h: Move EXFUNS for Fframe_root_window,
4990 Fframe_first_window and Fset_frame_selected_window here from
4991 lisp.h.
4992
4993 * frame.c (Fwindow_frame, Fframe_first_window)
4994 (Fframe_root_window, Fframe_selected_window)
4995 (Fset_frame_selected_window): Move to window.c.
4996 (Factive_minibuffer_window): Move to minibuf.c.
4997 (Fother_visible_frames_p): New function.
4998
4999 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5000
f230ecc9
MR
5001 * window.c (decode_window, decode_any_window): Move up in code.
5002 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5003 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5004 (Fwindow_buffer): Move up and rewrite doc-string.
5005 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5006 (Fwindow_prev): New functions.
727e958e
MR
5007 (Fwindow_frame): Move here from frame.c. Accept any window as
5008 argument.
5009 (Fframe_root_window, Fframe_first_window)
5010 (Fframe_selected_window): Move here from frame.c. Accept frame
5011 or arbitrary window as argument. Update doc-strings.
5012 (Fminibuffer_window): Move up in code.
5013 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5014 (Fset_frame_selected_window): Move here from frame.c.
5015 Marginal rewrite.
727e958e
MR
5016 (Fselected_window, select_window, Fselect_window): Move up in
5017 code. Minor doc-string fixes.
f230ecc9 5018
4d09bcf6
PE
50192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5020
5021 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5022 Do not assume that spare memory exists; that assumption is valid
5023 only if SYSTEM_MALLOC.
5024 (LARGE_REQUEST): New macro, so that the issue of large requests
5025 is separated from the issue of spare memory.
5026
810928a2
AS
50272011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5028
172418ad
AS
5029 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5030 format. (Bug#8806)
5031
43f862f7
AS
5032 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5033
810928a2
AS
5034 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5035 before statements.
5036
a059fe24
JD
50372011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5038
5039 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5040
5041 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5042
5043 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5044 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5045
989bf368
JB
50462011-06-05 Juanma Barranquero <lekktu@gmail.com>
5047
5048 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5049
4b80f674
CY
50502011-06-04 Chong Yidong <cyd@stupidchicken.com>
5051
5052 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5053 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5054 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5055 New error handlers.
4b80f674
CY
5056 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5057 Obey Vx_select_enable_clipboard_manager. Catch errors in
5058 x_clipboard_manager_save (Bug#8779).
5059 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5060 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5061
99a33b77 50622011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5063
5064 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5065
99a33b77 50662011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5067
5068 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5069 in the current matrix if keep_current_p is non-zero.
5070
8264569d
EZ
50712011-06-04 Eli Zaretskii <eliz@gnu.org>
5072
5073 * bidi.c (bidi_level_of_next_char): Fix last change.
5074
57f97249
EZ
50752011-06-03 Eli Zaretskii <eliz@gnu.org>
5076
fec2107c 5077 Support bidi reordering of text covered by display properties.
57f97249 5078
fec2107c
EZ
5079 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5080 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5081 (bidi_cache_search, bidi_cache_iterator_state)
5082 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5083 (bidi_level_of_next_char, bidi_move_to_visually_next):
5084 Support character positions inside a run of characters covered by a
fec2107c
EZ
5085 display string.
5086 (bidi_paragraph_init, bidi_resolve_explicit_1)
5087 (bidi_level_of_next_char): Call bidi_fetch_char and
5088 bidi_fetch_char_advance instead of FETCH_CHAR and
5089 FETCH_CHAR_ADVANCE.
5090 (bidi_init_it): Initialize new members.
5091 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5092 definitions.
5093 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5094 instead of using explicit *_CHAR codes.
d6d100dd
SM
5095 (bidi_resolve_explicit, bidi_resolve_weak):
5096 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5097 bidirectional text is supported only in multibyte buffers.
5098 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5099 it to initialize the frame_window_p member of struct bidi_it.
5100 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5101 (bidi_resolve_explicit, bidi_resolve_weak)
5102 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5103 bidi_it->nchars is non-positive.
5104 (bidi_level_of_next_char): Don't try to lookup the cache for the
5105 next/previous character if nothing is cached there yet, or if we
5106 were just reseat()'ed to a new position.
c40e2fb2 5107
0e14fe90
EZ
5108 * xdisp.c (set_cursor_from_row): Set start and stop points
5109 according to the row's direction when priming the loop that looks
5110 for the glyph on which to display cursor.
5111 (single_display_spec_intangible_p): Function deleted.
5112 (display_prop_intangible_p): Reimplement to call
5113 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5114 Accept 3 additional arguments needed by handle_display_spec.
5115 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5116 values: lists, `(when COND...)' forms, etc.
5117 (single_display_spec_string_p): Support property values that are
5118 lists with the argument STRING its top-level element.
5119 (display_prop_string_p): Fix the condition for processing a
5120 property that is a list to be consistent with handle_display_spec.
fec2107c 5121 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5122 last portion of handle_display_prop.
5123 (compute_display_string_pos): Accept additional argument
5124 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5125 value of a `display' property is a "replacing spec".
5126 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5127 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5128 the display property, but just return a value indicating whether
5129 the display property will replace the characters it covers.
5130 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5131 frame_window_p members of struct bidi_it.
d6d100dd
SM
5132 (compute_display_string_pos, compute_display_string_end):
5133 New functions.
fec2107c
EZ
5134 (push_it): Accept second argument POSITION, where pop_it should
5135 jump to continue iteration.
5136 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5137
fec2107c
EZ
5138 * keyboard.c (adjust_point_for_property): Adjust the call to
5139 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5140
5141 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5142 (bidi_init_it): Update prototypes.
5143 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5144 (compute_display_string_pos, compute_display_string_end):
5145 Declare prototypes.
fec2107c
EZ
5146 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5147 EMACS_INT.
fc6f18ce 5148
40087514 51492011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5150
57f53182
PE
5151 Malloc failure behavior now depends on size of allocation.
5152 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5153 * lisp.h: Change signatures accordingly.
5154 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5155 All callers changed. (Bug#8762)
5156
5157 * gnutls.c: Use Emacs's memory allocators.
5158 Without this change, the gnutls library would invoke malloc etc.
5159 directly, which causes problems on non-SYNC_INPUT hosts, and which
5160 runs afoul of improving memory_full behavior. (Bug#8761)
5161 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5162 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5163 xfree instead of the default malloc, realloc, free.
5164 (Fgnutls_boot): No need to check for memory allocation failure,
5165 since xmalloc does that for us.
5166
ac32cd99 5167 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5168 * category.c (hash_get_category_set):
5169 * ccl.c (ccl_driver):
5170 * charset.c (Fdefine_charset_internal):
5171 * charset.h (struct charset.hash_index):
5172 * composite.c (get_composition_id, gstring_lookup_cache)
5173 (composition_gstring_put_cache):
5174 * composite.h (struct composition.hash_index):
5175 * dispextern.h (struct image.hash):
5176 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5177 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5178 (hashfn_equal, hashfn_user_defined, make_hash_table)
5179 (maybe_resize_hash_table, hash_lookup, hash_put)
5180 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5181 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5182 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5183 * image.c (make_image, search_image_cache, lookup_image)
5184 (xpm_put_color_table_h):
5185 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5186 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5187 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5188 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5189 * alloc.c (allocate_vectorlike):
5190 Check for overflow in vector size calculations.
5191 * ccl.c (ccl_driver):
5192 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5193 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5194 need to be updated by these changes.
40087514
PE
5195 * fns.c (make_hash_table, maybe_resize_hash_table):
5196 Check for integer overflow with large hash tables.
0de4bb68
PE
5197 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5198 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5199 (SXHASH_REDUCE): New macro.
5200 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5201 Use it instead of discarding useful hash info with large hash values.
5202 (sxhash_float): New function.
5203 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5204 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5205 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5206 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5207 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5208 Adjust signatures to match updated version of code.
5209 (consing_since_gc): Now EMACS_INT, since a single hash table can
5210 use more than INT_MAX bytes.
5211
698d32e2
DN
52122011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5213
5214 Make it possible to build with GCC-4.6+ -O2 -flto.
5215
5216 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5217
fd6fa53f
SM
52182011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5219
5220 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5221 Call minibuffer-inactive-mode.
5222
864db017
JB
52232011-05-31 Juanma Barranquero <lekktu@gmail.com>
5224
5225 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5226 Update dependencies.
5227
2ad0baf4
DN
52282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5229
5230 * data.c (init_data): Remove code for UTS, this system is not
5231 supported anymore.
5232
4fcc2638
DN
52332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5234
5235 Don't force ./temacs to start in terminal mode.
5236
5237 * frame.c (make_initial_frame): Initialize faces in all cases, not
5238 only when CANNOT_DUMP is defined.
5239 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5240
c56e0fd5
DN
52412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5242
5243 * dispnew.c (add_window_display_history): Use const for the string
5244 pointer. Remove declaration, not needed.
5245
333d54da 52462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5247
55d4c1b2 5248 Use 'inline', not 'INLINE'.
333d54da 5249 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5250 * alloc.c, fontset.c (INLINE): Remove.
5251 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5252 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5253 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5254 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5255 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5256
738db178
DN
52572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5258
5259 Make it possible to run ./temacs.
5260
5261 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5262 syms_of_callproc does the same thing. Remove test for
5263 "initialized", do it in the caller.
5264 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5265
620c53a6
SM
52662011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5267
5268 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5269 (read_minibuf): Use get_minibuffer.
5270 (syms_of_minibuf): Use DEFSYM.
5271 (Qmetadata): New var.
5272 * data.c (Qbuffer): Don't make it static.
5273 (syms_of_data): Use DEFSYM.
5274
e003a292
PE
52752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5276
5277 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5278 (CCL_CODE_MIN): New macro.
5279
ed008a6d
PE
52802011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5281
3687c2ef
PE
5282 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5283
ed008a6d
PE
5284 * eval.c (Qdebug): Now static.
5285 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5286 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5287 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5288
d66c4c7c
CY
52892011-05-29 Chong Yidong <cyd@stupidchicken.com>
5290
5291 * image.c: Various fixes to ImageMagick code comments.
5292 (Fimagemagick_types): Doc fix.
5293
5fbc2025
PE
52942011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5295
0196f88a
PE
5296 Minor fixes prompted by GCC 4.6.0 warnings.
5297
5298 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5299
5fbc2025
PE
5300 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5301 (x_clipboard_manager_save_all): Move extern decl to ...
5302 * xterm.h: ... here, so that it can be checked for consistency.
5303
1dd3c2d9
CY
53042011-05-29 Chong Yidong <cyd@stupidchicken.com>
5305
5306 * xselect.c (x_clipboard_manager_save_frame)
5307 (x_clipboard_manager_save_all): New functions.
5308 (Fx_clipboard_manager_save): Lisp function deleted.
5309
5310 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5311 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5312
5313 * xterm.h: Update prototype.
5314
5ba6571d
WX
53152011-05-28 William Xu <william.xwl@gmail.com>
5316
5317 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5318 exiting (Bug#8239).
5319
3eaff834
JM
53202011-05-28 Jim Meyering <meyering@redhat.com>
5321
e1900994 5322 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5323 * fns.c (to_uchar): Define.
5324 (crypto_hash_function): Use it to convert some newly-signed
5325 variables to unsigned, to avoid sign-extension bugs. For example,
5326 without this change, (md5 "truc") would evaluate to
5327 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5328 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5329 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5330
0f6990a7
PE
53312011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5332
5333 Integer overflow fixes.
c8a9ca5a 5334
08686060
PE
5335 * dbusbind.c: Serial number integer overflow fixes.
5336 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5337 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5338 to hold a serial number that is too large for a fixnum.
5339 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5340 Check for serial numbers out of range. Decode any serial number
59568bf0 5341 that was so large that it became a float. (Bug#8722)
08686060 5342
2d1fc3c7
PE
5343 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5344 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5345 Use XFASTINT rather than XUINT when numbers are nonnegative.
5346 (xd_append_arg, Fdbus_method_return_internal):
5347 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5348 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5349 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5350 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5351 (Bug#8722)
2d1fc3c7 5352
c8a9ca5a
PE
5353 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5354
519e1d69
PE
5355 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5356
30569699
PE
5357 ccl: add integer overflow checks
5358 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5359 (IN_INT_RANGE): New macros.
5360 (ccl_driver): Use them to check for integer overflow when
5361 decoding a CCL program. Many of the new checks are whether XINT (x)
5362 fits in int; it doesn't always, on 64-bit hosts. The new version
5363 doesn't catch all possible integer overflows, but it's an
847044ea 5364 improvement. (Bug#8719)
30569699 5365
c11285dc
PE
5366 * alloc.c (make_event_array): Use XINT, not XUINT.
5367 There's no need for unsigned here.
5368
fdccd48e
PE
5369 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5370 This follows up to the 2011-05-06 change that substituted uintptr_t
5371 for EMACS_INT. This case wasn't caught back then.
5372
37910ab2
PE
5373 Rework Fformat to avoid integer overflow issues.
5374 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5375 now (part of C89). Include <verify.h>.
5376 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5377 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5378 (Fformat): Avoid the prepass trying to compute sizes; it was only
5379 approximate and thus did not catch overflow reliably. Instead, walk
5380 through the format just once, formatting and computing sizes as we go,
5381 checking for integer overflow at every step, and allocating a larger
5382 buffer as needed. Keep track separately whether the format is
5383 multibyte. Keep only the most-recently calculated precision, rather
5384 than them all. Record whether each argument has been converted to
5385 string. Use EMACS_INT, not int, for byte and char and arg counts.
5386 Support field widths and precisions larger than INT_MAX. Avoid
5387 sprintf's undefined behavior with conversion specifications such as %#d
5388 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5389 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5390 formatting out-of-range floating point numbers with int
9173deec 5391 formats. (Bug#8668)
37910ab2 5392
2e6578fb
PE
5393 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5394
0ae6bdee
PE
5395 * data.c: Avoid integer truncation in expressions involving floats.
5396 * data.c: Include <intprops.h>.
5397 (arith_driver): When there's an integer overflow in an expression
5398 involving floating point, convert the integers to floating point
5399 so that the resulting value does not suffer from catastrophic
5400 integer truncation. For example, on a 64-bit host (* 4
5401 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5402 Do not rely on undefined behavior after integer overflow.
5403
de883a70
PE
5404 merge count_size_as_multibyte, parse_str_to_multibyte
5405 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5406 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5407 Check for integer overflow.
5408 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5409 since it's now a duplicate of the other. This is more of
5410 a character than a buffer op, so better that it's in character.c.
5411 * fns.c, print.c: Adjust to above changes.
5412
2ff916cb
PE
54132011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5414
5415 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5416
f1b54466
PE
54172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5418
fb1ac845
PE
5419 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5420 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5421 (x_clipboard_manager_save): Now static.
5422 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5423
f1b54466
PE
5424 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5425 (crypto_hash_function): Now static.
5426 Fix pointer signedness problems. Avoid unnecessary initializations.
5427
a9f737ee
CY
54282011-05-27 Chong Yidong <cyd@stupidchicken.com>
5429
5430 * termhooks.h (Vselection_alist): Make it terminal-local.
5431
5432 * terminal.c (create_terminal): Initialize it.
5433
5434 * xselect.c: Support for clipboard managers.
5435 (Vselection_alist): Move to termhooks.h as terminal-local var.
5436 (LOCAL_SELECTION): New macro.
5437 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5438 (symbol_to_x_atom): Remove gratuitous arg.
5439 (x_handle_selection_request, lisp_data_to_selection_data)
5440 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5441 (x_own_selection, x_get_local_selection, x_convert_selection):
5442 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5443 (some_frame_on_display): Delete unused function.
5444 (Fx_own_selection_internal, Fx_get_selection_internal)
5445 (Fx_disown_selection_internal, Fx_selection_owner_p)
5446 (Fx_selection_exists_p): New optional frame arg.
5447 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5448 (x_handle_selection_clear): Don't treat other terminals with the
5449 same keyboard specially. Use the terminal-local Vselection_alist.
5450 (x_clear_frame_selections): Use Frun_hook_with_args.
5451
5452 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5453
5454 * xterm.h: Add support for those atoms.
5455
e067f0c1
CY
54562011-05-26 Chong Yidong <cyd@stupidchicken.com>
5457
5458 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5459 (converted_selections, conversion_fail_tag): New global variables.
5460 (x_selection_request_lisp_error): Free the above.
5461 (x_get_local_selection): Remove unnecessary code.
5462 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5463 of converted selections stored in converted_selections.
5464 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5465 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5466 (x_convert_selection): New function.
5467 (x_handle_selection_event): Simplify.
5468 (x_get_foreign_selection): Don't ignore incoming requests while
5469 waiting for an answer; this will fail when we implement
5470 SAVE_TARGETS, and seems unnecessary anyway.
5471 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5472 (Vx_sent_selection_functions): Doc fix.
5473
0f4aebc0
LL
54742011-05-26 Leo Liu <sdl.web@gmail.com>
5475
5476 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5477
e61124cd
YM
54782011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5479
5480 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5481
5482 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5483 for fringe update if it has periodic bitmap.
ac389d0c 5484 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5485 and fringe_bitmap_periodic_p.
5486
5487 * fringe.c (get_fringe_bitmap_data): New function.
5488 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5489 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5490 row. Mark glyph row for fringe update if periodicity changed.
5491
5492 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5493 for fringe update unless it has periodic bitmap.
5494
f16d9837
KH
54952011-05-25 Kenichi Handa <handa@m17n.org>
5496
5497 * xdisp.c (get_next_display_element): Set correct it->face_id for
5498 a static composition.
5499
e1b90ef6
LL
55002011-05-24 Leo Liu <sdl.web@gmail.com>
5501
5502 * deps.mk (fns.o):
5503 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5504
5505 * fns.c (crypto_hash_function, Fsha1): New function.
5506 (Fmd5): Use crypto_hash_function.
5507 (syms_of_fns): Add Ssha1.
5508
7400048f
PE
55092011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5510
5511 * gnutls.c: Remove unused macros.
5512 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5513 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5514 Remove macros that are defined and never used.
5515 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5516
abb71cf4
CY
55172011-05-22 Chong Yidong <cyd@stupidchicken.com>
5518
5519 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5520 (Fx_get_selection_internal): Minor cleanup.
5521 (Fx_own_selection_internal): Rename arguments for consistency with
5522 select.el.
5523
6307db39
PE
55242011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5525
5526 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5527
f3d4e0a4
CY
55282011-05-22 Chong Yidong <cyd@stupidchicken.com>
5529
5530 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5531
4d8ade89
YM
55322011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5533
5534 * dispnew.c (scrolling_window): Don't exclude the case that the
5535 last enabled row in the desired matrix touches the bottom boundary.
5536
32078c8d
GM
55372011-05-21 Glenn Morris <rgm@gnu.org>
5538
5539 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5540 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5541 and add some more files.
32078c8d 5542
7285dc67
EZ
55432011-05-20 Eli Zaretskii <eliz@gnu.org>
5544
5545 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5546 report_file_error introduced by the change from 2011-05-07.
5547
89d1bd22
PE
55482011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5549
5550 * systime.h (Time): Define only if emacs is defined.
5551 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5552 where the include path doesn't have X11/X.h by default. See
5553 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5554
e23640bb 55552011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5556
5557 * composite.c (find_automatic_composition): Fix previous change.
5558
b9704ad9
GM
55592011-05-20 Glenn Morris <rgm@gnu.org>
5560
5561 * lisp.mk: New file, split from Makefile.in.
5562 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5563 (shortlisp): Remove.
5564 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5565
4a720484
GM
55662011-05-19 Glenn Morris <rgm@gnu.org>
5567
5568 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5569 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5570 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5571 (lisp): Set the order to that of loadup.el.
5572 (shortlisp): Make it a copy of $lisp.
5573 (SOME_MACHINE_LISP): Remove.
5574 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5575 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5576
a28d4396
KH
55772011-05-18 Kenichi Handa <handa@m17n.org>
5578
5579 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5580 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5581 (find_automatic_composition): Mostly rewrite for efficiency.
5582
a2b1fa8e
JB
55832011-05-18 Juanma Barranquero <lekktu@gmail.com>
5584
5585 * makefile.w32-in: Update dependencies.
5586
8e1f5610
CS
55872011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5588
5589 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5590 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5591
7025ee00 55922011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5593
cdfa6eab
PE
5594 Fix some integer overflow issues, such as string length overflow.
5595
06d6db33
PE
5596 * insdel.c (count_size_as_multibyte): Check for string overflow.
5597
2b4560a8
PE
5598 * character.c (lisp_string_width): Check for string overflow.
5599 Use EMACS_INT, not int, for string indexes and lengths; in
5600 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5601 the resulting string length overflows an EMACS_INT; instead,
5602 report a string overflow if no precision given. When checking for
5603 precision exhaustion, use a check that cannot possibly have
5604 integer overflow. (Bug#8675)
5605 * character.h (lisp_string_width): Adjust to new signature.
5606
cb93f9be
PE
5607 * alloc.c (string_overflow): New function.
5608 (Fmake_string): Use it. This doesn't change behavior, but saves
5609 a few bytes and will simplify future changes.
5610 * character.c (string_escape_byte8): Likewise.
5611 * lisp.h (string_overflow): New decl.
5612
1a1f3366
PE
5613 Fixups, following up to the user-interface timestamp change.
5614 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5615 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5616 * msdos.c (mouse_get_pos): Likewise.
5617 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5618 * w32gui.h (Time): Define by including "systime.h" rather than by
5619 declaring it ourselves. (Bug#8664)
5620
d4e3e4d3
PE
5621 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5622 * image.c (clear_image_cache): Likewise.
5623
f6a24d19
PE
5624 * term.c (term_mouse_position): Don't assume time_t wraparound.
5625
08dc5ae6
PE
5626 Be more systematic about user-interface timestamps.
5627 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5628 and sometimes 'EMACS_UINT', to represent these timestamps.
5629 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5630 This makes the code easier to follow, and makes it easier to catch
5631 integer overflow bugs such as Bug#8664.
5632 * frame.c (Fmouse_position, Fmouse_pixel_position):
5633 Use Time, not unsigned long, for user-interface timestamps.
5634 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5635 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5636 * keyboard.h (last_event_timestamp): Likewise.
5637 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5638 * menu.h (xmenu_show): Likewise.
5639 * term.c (term_mouse_position): Likewise.
5640 * termhooks.h (struct input_event.timestamp): Likewise.
5641 (struct terminal.mouse_position_hook): Likewise.
5642 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5643 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5644 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5645 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5646 what it was before.
5647 * menu.h, termhooks.h: Include "systime.h", for Time.
5648
8e55734a
PE
5649 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5650 Don't assume that the difference between two unsigned long values
5651 can fit into an integer. At this point, we know button_down_time
5652 <= event->timestamp, so the difference must be nonnegative, so
5653 there's no need to cast the result if double-click-time is
5654 nonnegative, as it should be; check that it's nonnegative, just in
5655 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5656 apart (about 25 days). (Bug#8664)
8e55734a 5657
841f1b75 5658 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5659 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5660
3e26f69c
PE
5661 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5662 that always fit in int. Use a sentinel instead of a counter, to
5663 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5664 * frame.h (struct frame): Use int for menu_bar_items_used
5665 instead of EMACS_INT, since it always fits in int.
3e26f69c 5666
5cc152c0
PE
5667 * menu.c (grow_menu_items): Check for int overflow.
5668
d89eb65e
PE
5669 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5670
5235bd3e
PE
5671 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5672 Before, the code was not consistent. These values cannot exceed
5673 2**31 - 1 so there's no need to make them unsigned.
5674 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5675 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5676 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5677 as modifiers.
5678 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5679
bc827e23
PE
5680 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5681 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5682 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5683 presumably because the widths might not match.
5684
78eb494e
PE
5685 * window.c (size_window): Avoid needless test at loop start.
5686
04f2d78b
CB
56872011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5688
5689 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5690
d2fc7e3d 56912011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5692
5693 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5694
d2fc7e3d 56952011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5696
5697 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5698 `width' to `bar_area_x' and `bar_area_width', respectively.
5699 (x_scroll_run): Take account of fringe background extension.
5700
04f2d78b
CB
5701 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5702 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5703 `bar_area_width', respectively.
5704 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5705 background extension.
5706
79b70037
GM
57072011-05-10 Jim Meyering <meyering@redhat.com>
5708
5709 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5710
2f142cc5
JB
57112011-05-10 Juanma Barranquero <lekktu@gmail.com>
5712
5713 * image.c (Finit_image_library): Return t for built-in image types,
5714 like pbm and xbm. (Bug#8640)
5715
57679c86
AS
57162011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5717
5718 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5719
888c9e86
EZ
57202011-05-07 Eli Zaretskii <eliz@gnu.org>
5721
b0512a1d
EZ
5722 * w32console.c (Fset_screen_color): Doc fix.
5723 (Fget_screen_color): New function.
5724 (syms_of_ntterm): Defsubr it.
5725
7285dc67
EZ
5726 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5727 unlink the temporary file if Fcall_process didn't create it in the
5728 first place.
5729 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5730 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5731 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5732 cue to call_process_cleanup not to close that handle.
5733
4d3fcc8e
BK
57342011-05-07 Ben Key <bkey76@gmail.com>
5735
5736 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5737 one of two shell specific rules, either bootstrap-temacs-CMD or
5738 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5739 to the previous implementation of the bootstrap-temacs rule.
5740 The bootstrap-temacs-CMD rule is similar to the previous
5741 implementation of the bootstrap-temacs rule except that it
5742 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5743 variable.
5744
5745 These changes, along with some changes to nt/configure.bat,
5746 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5747 earlier fix to add support for --cflags and --ldflags options
5748 that include quotes so that it works whether make uses cmd or
5749 sh as the shell.
5750
b4289b64
MA
57512011-05-06 Michael Albinus <michael.albinus@gmx.de>
5752
5753 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5754 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5755 is a constant.
5756 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5757 a string. Handle both cases.
5758 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5759 (Fdbus_register_method): Use Qinvalid_function.
5760
af4c0e28
JB
57612011-05-06 Juanma Barranquero <lekktu@gmail.com>
5762
5763 * makefile.w32-in: Update dependencies.
5764 (LISP_H): Add inttypes.h and stdin.h.
5765 (PROCESS_H): Add unistd.h.
5766
c51453d9
EZ
57672011-05-06 Eli Zaretskii <eliz@gnu.org>
5768
5769 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5770 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5771
8ff0ac3c 57722011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5773
4c4b566b
PE
5774 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5775
aab2b9b5
PE
5776 * term.c (vfatal): Remove stray call to va_end.
5777 It's not needed and the C Standard doesn't allow it here anyway.
5778
c378da0b
PE
5779 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5780 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5781
288b08c7
PE
5782 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5783 bytes.
5784
e3601888
PE
5785 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5786
db6c0e74
PE
5787 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5788
dd5963ea
PE
5789 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5790
88c9450f
PE
5791 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5792
2f9442b8
PE
5793 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5794
c032b5f8
PE
5795 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5796 * charset.c (Fdefine_charset_internal): Don't initialize
5797 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5798 32-bit int (Bug#8600).
a108c10b
PE
5799
5800 * lread.c (read_integer): Be more consistent with string-to-number.
5801 Use string_to_number to do the actual conversion; this avoids
5802 rounding errors and fixes some other screwups. Without this fix,
5803 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5804 (digit_to_number): Move earlier, for benefit of read_integer.
5805 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5806 not a digit in any supported base. (Bug#8602)
a108c10b 5807
ad5f9eea
PE
5808 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5809
aec1708a
PE
5810 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5811 to match comment at start of function. This also removes a
5812 GCC warning about overflow in a 32+64-bit port.
5813
47be4ab5
PE
5814 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5815
371cac43
PE
5816 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5817 Reported by Stefan Monnier in
5818 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5819 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5820 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5821
d01a7826
PE
5822 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5823 (EMACS_UINTPTR): Likewise, with uintptr_t.
5824
7fd47d5c
PE
5825 * lisp.h: Prefer 64-bit EMACS_INT if available.
5826 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5827 on 32-bit hosts that have 64-bit int, so that they can access
5828 large files.
122b0c86
PE
5829 However, temporarily disable this change unless the temporary
5830 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5831
8727937b
PE
5832 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5833
8ac068ac
PE
5834 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5835 This removes an assumption that EMACS_INT and long are the same
5836 width as pointers. The assumption is true for Emacs porting targets
5837 now, but we want to make other targets possible.
5838 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5839 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5840 In the rest of the code, change types of integers that hold casted
5841 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5842 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5843 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5844 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5845 No need to cast type when ORing.
5846 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5847 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5848 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5849 assume EMACS_INT is the same width as char *.
5850 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5851 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5852 Remove no-longer-needed casts.
5853 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5854 (xg_tool_bar_help_callback, xg_make_tool_item):
5855 Use EMACS_INTPTR to hold an integer
5856 that will be cast to void *; this can avoid a GCC warning
5857 if EMACS_INT is not the same width as void *.
5858 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5859 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5860 (current_message_1, set_message_1):
5861 Use a local to convert to proper width without a cast.
5862 * xmenu.c (dialog_selection_callback): Likewise.
5863
ede49d71
PE
5864 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5865 Also, don't assume VALBITS / RAND_BITS is less than 5,
5866 and don't rely on undefined behavior when shifting a 1 left into
5867 the sign bit.
5868 * lisp.h (get_random): Change signature to match.
5869
2f30ecd0
PE
5870 * lread.c (hash_string): Use size_t, not int, for hash computation.
5871 Normally we prefer signed values; but hashing is special, because
5872 it's better to use unsigned division on hash table sizes so that
5873 the remainder is nonnegative. Also, size_t is the natural width
5874 for hashing into memory. The previous code used 'int', which doesn't
5875 retain enough info to hash well into very large tables.
5876 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5877
2a866e7b
PE
5878 * dbusbind.c: Don't possibly lose pointer info when converting.
5879 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5880 Use XPNTR rather than XHASH, so that the high-order bits of
5881 the pointer aren't lost when converting through void *.
5882
51639eac
PE
5883 * eval.c (Fautoload): Don't double-shift a pointer.
5884
92394119
PE
5885 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5886
dbdb9a7c
JB
58872011-05-06 Juanma Barranquero <lekktu@gmail.com>
5888
5889 * gnutls.c (DEF_GNUTLS_FN):
5890 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5891
db7a0b4f
AS
58922011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5893
5894 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5895 marker. (Bug#8610)
5896
f7ff1b0f 58972011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5898
5899 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5900 New version that can reserve upto 2GB of heap space.
5901
f7ff1b0f 59022011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5903
5904 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5905
639c109b
TZ
59062011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5907
5908 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5909 `gnutls_certificate_set_x509_key_file'.
5910
d2127135
JB
59112011-05-05 Juanma Barranquero <lekktu@gmail.com>
5912
5913 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5914 Update dependencies.
5915
e968f4f3
JB
59162011-05-04 Juanma Barranquero <lekktu@gmail.com>
5917
5918 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5919 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5920 Remove unused parameter `fildes'.
5921 * process.c (read_process_output, send_process): Don't pass it.
5922
84d358f0
JB
59232011-05-04 Juanma Barranquero <lekktu@gmail.com>
5924
5925 Fix previous change: the library cache is defined in w32.c.
5926 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5927 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5928
0898ca10
JB
59292011-05-04 Juanma Barranquero <lekktu@gmail.com>
5930
5931 Implement dynamic loading of GnuTLS on Windows.
5932
5933 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5934 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5935 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5936 Declare.
5937
5938 * gnutls.c (Qgnutls_dll): Define.
5939 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5940 (gnutls_*): Declare function pointers.
5941 (init_gnutls_functions): New function to initialize function pointers.
5942 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5943 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5944 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5945 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5946 (emacs_gnutls_write, emacs_gnutls_read)
5947 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5948 (Fgnutls_available_p): New function.
5949 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5950 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5951 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5952
5953 * image.c: Include w32.h.
5954 (Vimage_type_cache): Delete.
5955 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5956 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5957 (w32_delayed_load): Move to w32.c.
5958
5959 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5960
5961 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5962 (w32_delayed_load): Move from image.c. When loading a library, record
5963 its filename in the :loaded-from property of the library id.
5964 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5965 Initialize and staticpro them.
5966 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5967
5968 * process.c: Include lisp.h before w32.h, not after.
5969 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5970 instead of gnutls_record_check_pending.
5971
5972 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5973
ff4de4aa
TZ
59742011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5975
5976 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5977 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5978 as passed in.
5979
abe95abb
JD
59802011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5981
5982 * xterm.c (x_set_frame_alpha): Do not set property on anything
5983 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5984
e16e55d4
JB
59852011-05-02 Juanma Barranquero <lekktu@gmail.com>
5986
5987 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5988
bafcf6a5
JB
59892011-05-02 Juanma Barranquero <lekktu@gmail.com>
5990
5991 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5992 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5993 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5994 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5995 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5996 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5997 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5998 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5999 (Qgnutls_bootprop_callbacks_verify): Make static.
6000
e7a6747f
AS
60012011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6002
19ed11ba
AS
6003 * callproc.c: Indentation fixup.
6004
e7a6747f 6005 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6006 (wait_for_termination, interruptible_wait_for_termination):
6007 Move after wait_for_termination_1.
e7a6747f 6008
1ef14cb4
LMI
60092011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6010
6011 * sysdep.c (interruptible_wait_for_termination): New function
6012 which is like wait_for_termination, but allows keyboard
6013 interruptions.
6014
6015 * callproc.c (Fcall_process): Add (:file "file") as an option for
6016 the STDOUT buffer.
6017 (Fcall_process_region): Ditto.
6018
330d880c
EZ
60192011-04-30 Eli Zaretskii <eliz@gnu.org>
6020
8db90b73
EZ
6021 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6022 rather than `XVECTOR (FOO)->size'.
6023
330d880c
EZ
6024 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6025 inttypes.h, as a gnulib replacement is used if it not available in
6026 system headers.
6027
15cbd324
EZ
60282011-04-21 Eli Zaretskii <eliz@gnu.org>
6029
6030 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6031 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6032 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6033
6034 * coding.c (coding_alloc_by_realloc): Error out if destination
6035 will grow beyond MOST_POSITIVE_FIXNUM.
6036 (decode_coding_emacs_mule): Abort if there isn't enough place in
6037 charbuf for the composition carryover bytes. Reserve an extra
6038 space for up to 2 characters produced in a loop.
6039 (decode_coding_iso_2022): Abort if there isn't enough place in
6040 charbuf for the composition carryover bytes.
6041
60422011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6043
ae940cca
EZ
6044 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6045 aborting when %lld or %lll format is passed.
6046 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6047 %llo or %llx format is passed. (Bug#8545)
6048
03ab8921
EZ
6049 * window.c (window_scroll_line_based): Use a marker instead of
6050 simple variables to record original value of point. (Bug#7952)
6051
afda1437
EZ
6052 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6053 produced by %s or %c overflows available buffer space. (Bug#8545)
6054
f76dee0c
PE
60552011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6056
6057 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6058 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6059
fdc5744d
JB
60602011-04-28 Juanma Barranquero <lekktu@gmail.com>
6061
6062 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6063
638f053a
JB
60642011-04-28 Juanma Barranquero <lekktu@gmail.com>
6065
6066 * keyboard.c (Qdelayed_warnings_hook): Define.
6067 (command_loop_1): Run `delayed-warnings-hook'
6068 if Vdelayed_warnings_list is non-nil.
6069 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6070 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6071
d178f871
EZ
60722011-04-28 Eli Zaretskii <eliz@gnu.org>
6073
6074 * doprnt.c (doprnt): Don't return value smaller than the buffer
6075 size if the message was truncated. (Bug#8545).
6076
b124fd93
JB
60772011-04-28 Juanma Barranquero <lekktu@gmail.com>
6078
6079 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6080 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6081
e810457d
PE
60822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6083
6084 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6085
ea51cceb
JB
60862011-04-27 Juanma Barranquero <lekktu@gmail.com>
6087
6088 * makefile.w32-in: Update dependencies.
6089
94dcfacf
EZ
60902011-04-27 Eli Zaretskii <eliz@gnu.org>
6091
6092 Improve `doprnt' and its usage. (Bug#8545)
6093 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6094 `format_end'. Remove support for %l as a conversion specifier.
6095 Don't use xrealloc. Improve diagnostics when the %l size modifier
6096 is used. Update the commentary.
6097
6098 * eval.c (verror): Simplify calculation of size_t.
6099
6100 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6101 messages.
6102
f61f41d7
PE
61032011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6104
6105 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6106 change.
6107
96fb4434
PE
61082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6109
6110 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6111 This makes this file independent of the recent pseudovector change.
6112
671875da 61132011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6114
69e9b5a3
PE
6115 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6116
b5f869a7 6117 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6118 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6119 Remove unused local.
c8926152 6120 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6121
841a1577 6122 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6123 GCC 4.6.0 optimizes based on type-based alias analysis.
6124 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6125 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6126 != &v->size, and therefore "v->size = 1; b->size = 2; return
6127 v->size;" must therefore return 1. This assumption is incorrect
6128 for Emacs, since it type-puns struct Lisp_Vector * with many other
6129 types. To fix this problem, this patch adds a new type struct
f904488f 6130 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6131 and pseudovectors, and helps optimizing compilers not get fooled
6132 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6133 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6134 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6135 the size member.
eab3844f
PE
6136 (XSETPVECTYPE): Rewrite in terms of new macro.
6137 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6138 This is a bit clearer, and further avoids the possibility of
6139 undesirable aliasing.
6140 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6141 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6142 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6143 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6144 (ASIZE): Now uses header.size rather than size.
6145 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6146 to avoid the hassle of writing XVECTOR (foo)->header.size.
6147 (struct vectorlike_header): New type.
eab3844f
PE
6148 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6149 object, to help avoid aliasing.
6150 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6151 (SUBRP): Likewise, since Lisp_Subr is a special case.
6152 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6153 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6154 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6155 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6156 changed to be "header.size" and "header.next".
6157 * buffer.h (struct buffer): Likewise.
6158 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6159 * frame.h (struct frame): Likewise.
6160 * process.h (struct Lisp_Process): Likewise.
6161 * termhooks.h (struct terminal): Likewise.
6162 * window.c (struct save_window_data, struct saved_window): Likewise.
6163 * window.h (struct window): Likewise.
6164 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6165 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6166 * buffer.c (init_buffer_once): Likewise.
6167 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6168 special case.
6169 * process.c (Fformat_network_address): Use local var for size,
6170 for brevity.
6171
0df1eac5
PE
6172 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6173
847ab9d1 6174 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6175 * data.c (atof): Remove decl; no longer used or needed.
6176 (digit_to_number): Move to lread.c.
6177 (Fstring_to_number): Use new string_to_number function, to be
6178 consistent with how the Lisp reader treats infinities and NaNs.
6179 Do not assume that floating-point numbers represent EMACS_INT
6180 without losing information; this is not true on most 64-bit hosts.
6181 Avoid double-rounding errors, by insisting on integers when
6182 parsing non-base-10 numbers, as the documentation specifies.
6183 * lisp.h (string_to_number): New decl, replacing ...
6184 (isfloat_string): Remove.
bc0a5c13 6185 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6186 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6187 appears to have been a coding error. Similarly, do not accept
6188 strings like +-1e0 as floating point numbers. Do not report
6189 overflow for integer overflows unless the base is not 10 which
6190 means we have no simple and reliable way to continue.
6191 Break out the floating-point parsing into a new
6192 function string_to_number, so that Fstring_to_number parses
6193 floating point numbers consistently with the Lisp reader.
04f2d78b 6194 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6195 (E_CHAR, EXP_INT): Remove, replacing with ...
6196 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6197 (string_to_number): New function, replacing isfloat_string.
6198 This function checks for valid syntax and produces the resulting
6199 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6200 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6201 so that overflow for non-base-10 numbers is reported only when
6202 there's no portable and simple way to convert to floating point.
452f4150 6203
67769ffc
PE
6204 * textprop.c (set_text_properties_1): Rewrite for clarity,
6205 and to avoid GCC warning about integer overflow.
6206
c20db43f
PE
6207 * intervals.h (struct interval): Use EMACS_INT for members
6208 where EMACS_UINT might cause problems. See
6209 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6210 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6211 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6212 All uses changed.
37aa2f85
PE
6213 (offset_intervals): Tell GCC not to worry about length overflow
6214 when negating a negative length.
c20db43f 6215
2538aa2f
PE
6216 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6217 (overrun_check_free): Likewise.
6218
f2d3008d
PE
6219 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6220 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6221 word size.
6222
ec8df744
PE
6223 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6224 (gnutls_make_error): Rename local to avoid shadowing.
6225 (gnutls_emacs_global_deinit): ifdef out; not used.
6226 (Fgnutls_boot): Use const for pointer to readonly storage.
6227 Comment out unused local. Fix pointer signedness problems.
6228
640ee02d
PE
6229 * lread.c (openp): Don't stuff size_t into an 'int'.
6230 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6231 about possible signed overflow.
6232
6048fb2a
PE
6233 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6234 (GDK_KEY_g): Don't define if already defined.
6235 (xg_prepare_tooltip): Avoid pointer signedness problem.
6236 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6237
fa3c87e1
PE
6238 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6239 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6240
2172544b
PE
6241 * xfns.c (Fx_window_property): Simplify a bit,
6242 to make a bit faster and to avoid GCC 4.6.0 warning.
6243 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6244
9b821a21
PE
6245 * fns.c (internal_equal): Don't assume size_t fits in int.
6246
3c616cfa
PE
6247 * alloc.c (compact_small_strings): Tighten assertion a little.
6248
c2982e87
PE
6249 Replace pEd with more-general pI, and fix some printf arg casts.
6250 * lisp.h (pI): New macro, generalizing old pEd macro to other
6251 conversion specifiers. For example, use "...%"pI"d..." rather
6252 than "...%"pEd"...".
6253 (pEd): Remove. All uses replaced with similar uses of pI.
6254 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6255 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6256 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6257 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6258 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6259 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6260 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6261 64-bit hosts.
6262 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6263 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6264 * print.c (safe_debug_print, print_object): Likewise.
6265 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6266 to int.
6f04d126
PE
6267 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6268 avoiding the 0 flag, which is not portable.
c2982e87
PE
6269 * process.c (Fmake_network_process): Use pI to avoid cast.
6270 * region-cache.c (pp_cache): Likewise.
6271 * xdisp.c (decode_mode_spec): Likewise.
6272 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6273 behavior on 64-bit hosts with printf arg.
6f04d126 6274 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6275 (x_stop_queuing_selection_requests): Likewise.
6276 (x_get_window_property): Don't truncate byte count to an 'int'
6277 when tracing.
0b432f21 6278
5e073ec7
PE
6279 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6280 here, since it parses constructs like leading '-' and spaces,
6281 which are not wanted; and it overflows with large numbers.
6282 Instead, simply match F[0-9]+, which is what is wanted anyway.
6283
36372bf9
PE
6284 * alloc.c: Remove unportable assumptions about struct layout.
6285 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6286 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6287 (allocate_vectorlike, make_pure_vector): Use the new macros,
6288 plus offsetof, to remove unportable assumptions about struct layout.
6289 These assumptions hold on all porting targets that I know of, but
6290 they are not guaranteed, they're easy to remove, and removing them
6291 makes further changes easier.
6292
0b432f21
PE
6293 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6294 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6295 (string_overrun_cookie): Now const. Use initializers that
6296 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6297 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6298 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6299 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6300 multiple of sizeof (EMACS_INT); it need not be, if
6301 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6302 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6303
895009e1
JB
63042011-04-26 Juanma Barranquero <lekktu@gmail.com>
6305
6306 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6307
6a7a1b0b
TZ
63082011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6309
6310 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6311 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6312 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6313
841a1577 63142011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6315
6316 * lisp.h (Qdebug): List symbol.
895009e1 6317 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6318 * keyboard.c (debug-on-event): New variable.
6319 (handle_user_signal): Break into debugger when debug-on-event
6320 matches the current signal symbol.
6321
f2d3ba6f
DN
63222011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6323
6324 * alloc.c (check_sblock, check_string_bytes)
6325 (check_string_free_list): Convert to standard C.
6326
42ce4c63
TZ
63272011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6328
6329 * w32.c (emacs_gnutls_push): Fix typo.
6330
825cd63c
EZ
63312011-04-25 Eli Zaretskii <eliz@gnu.org>
6332
fb11d64d
EZ
6333 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6334 "cast to pointer from integer of different size".
6335
825cd63c
EZ
6336 Improve doprnt and its use in verror. (Bug#8545)
6337 * doprnt.c (doprnt): Document the set of format control sequences
6338 supported by the function. Use SAFE_ALLOCA instead of always
6339 using `alloca'.
6340
6341 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6342 is one byte too soon. Don't use xrealloc; instead xfree and
6343 xmalloc anew.
6344
e061a11b
TZ
63452011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6346
6347 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6348 callbacks stage.
6349
6350 * gnutls.c: Renamed global_initialized to
6351 gnutls_global_initialized. Added internals for the
6352 :verify-hostname-error, :verify-error, and :verify-flags
6353 parameters of `gnutls-boot' and documented those parameters in the
6354 docstring. Start callback support.
9173deec
JB
6355 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6356 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6357 on error. Return error code.
e061a11b
TZ
6358 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6359 (emacs_gnutls_read): Likewise.
6360 (Fgnutls_boot): Return handshake error code.
6361 (emacs_gnutls_handle_error): New function.
6362 (wsaerror_to_errno): Likewise.
6363
6364 * w32.h (emacs_gnutls_pull): Add prototype.
6365 (emacs_gnutls_push): Likewise.
6366
6367 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6368 (emacs_gnutls_push): Likewise.
6369
63702011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6371
6372 * process.c (wait_reading_process_output): Check if GnuTLS
6373 buffered some data internally if no FDs are set for TLS
6374 connections.
6375
6376 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6377 (LIBS): Link to USER_LIBS.
6378 ($(BLD)/gnutls.$(0)): New target.
6379
fa6996bc
EZ
63802011-04-24 Eli Zaretskii <eliz@gnu.org>
6381
eb35682e
EZ
6382 * xdisp.c (handle_single_display_spec): Rename the
6383 display_replaced_before_p argument into display_replaced_p, to
6384 make it consistent with the commentary. Fix typos in the
6385 commentary.
6386
e2ad650c
EZ
6387 * textprop.c (syms_of_textprop): Remove dead code.
6388 (copy_text_properties): Delete obsolete commentary about an
6389 interface that was deleted long ago. Fix typos in the description
6390 of arguments.
6391
1b2de274
EZ
6392 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6393 to changes in oldXMenu/XMenu.h from 2011-04-16.
6394 <menu_help_message, prev_menu_help_message>: Constify.
6395 (IT_menu_make_room): menu->help_text is now `const char **';
6396 adjust.
6397
6398 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6399 to changes in oldXMenu/XMenu.h from 2011-04-16.
6400 (struct XMenu): Declare `help_text' `const char **'.
6401
6402 * xfaces.c <Qunspecified>: Make extern again.
6403
6404 * syntax.c: Include sys/types.h before including regex.h, as
6405 required by Posix.
6406
762b15be
EZ
6407 * doc.c (get_doc_string): Improve the format passed to `error'.
6408
6409 * doprnt.c (doprnt): Improve commentary.
6410
6411 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6412
6413 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6414 them with etags.
6415
f1052e5d
EZ
6416 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6417 changes in globals.h immediately force recompilation.
762b15be
EZ
6418 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6419 $(CURDIR)/s/ms-w32.h.
6420 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6421
fa6996bc
EZ
6422 * character.c (Fchar_direction): Function deleted.
6423 (syms_of_character): Don't defsubr it.
6424 <char-direction-table>: Deleted.
6425
e6c3da20
EZ
64262011-04-23 Eli Zaretskii <eliz@gnu.org>
6427
6428 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6429 * doprnt.c: Include limits.h.
6430 (SIZE_MAX): New macro.
04f2d78b
CB
6431 (doprnt): Return a size_t value. 2nd arg is now size_t.
6432 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6433 Improve overflow protection. Support `l' modifier for integer
6434 conversions. Support %l conversion. Don't assume an EMACS_INT
6435 argument for integer conversions and for %c.
6436
6437 * lisp.h (doprnt): Restore prototype.
6438
6439 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6440 $(SRC)/character.h.
6441
6442 * Makefile.in (base_obj): Add back doprnt.o.
6443
6444 * deps.mk (doprnt.o): Add back prerequisites.
6445 (callint.o): Depend on character.h.
6446
6447 * eval.c (internal_lisp_condition_case): Include the handler
6448 representation in the error message.
6449 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6450 when breaking from the loop.
6451
6452 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6453
6454 * callint.c (Fcall_interactively): When displaying error message
6455 about invalid control letter, pass the character's codepoint, not
6456 a pointer to its multibyte form. Improve display of the character
6457 in octal and display also its hex code.
6458
6459 * character.c (char_string): Use %x to display the (unsigned)
6460 codepoint of an invalid character, to avoid displaying a bogus
6461 negative value.
6462
6463 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6464 `error', not SYMBOL_NAME itself.
6465
6466 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6467 character arguments to `error'.
6468
6469 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6470 to `error' in error message about FINAL_CHAR argument. Make sure
6471 FINAL_CHAR is a character, and use %c when it is passed as
6472 argument to `error'.
6473
4ffd0d6b 64742011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6475
6476 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6477
6478 * w32.c: Include <time.h>.
6479 (sys_localtime): New function.
6480
4ffd0d6b 64812011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6482
6483 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6484
4ffd0d6b 6485 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6486
4ffd0d6b 64872011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6488
4ffd0d6b
GM
6489 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6490 zombies (Bug#8467).
aac0c6e3 6491
04c56954
EZ
64922011-04-19 Eli Zaretskii <eliz@gnu.org>
6493
6494 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6495 gl_state.e_property when gl_state.object is Qt.
6496
6497 * insdel.c (make_gap_larger): Remove limitation of buffer size
6498 to <= INT_MAX.
6499
16a43933
CY
65002011-04-18 Chong Yidong <cyd@stupidchicken.com>
6501
6502 * xdisp.c (lookup_glyphless_char_display)
6503 (produce_glyphless_glyph): Handle cons cell entry in
6504 glyphless-char-display.
6505 (Vglyphless_char_display): Document it.
6506
6507 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6508 glyphless-char-display.
6509
4581706e
CY
65102011-04-17 Chong Yidong <cyd@stupidchicken.com>
6511
6512 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6513
6514 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6515
6516 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6517 definition for no-X builds.
6518
4887c6e2 65192011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6520
fd35b6f9
PE
6521 Static checks with GCC 4.6.0 and non-default toolkits.
6522
5c1ccb01
PE
6523 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6524
006c5daa
PE
6525 * process.c (keyboard_bit_set): Define only if SIGIO.
6526 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6527 (send_process): Repair possible setjmp clobbering.
6528
efc736d3
PE
6529 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6530
4e2fe2e6
PE
6531 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6532
f97334a2
PE
6533 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6534
4e75f29d
PE
6535 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6536 Define only if needed.
6537
90efadd1
PE
6538 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6539 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6540 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6541
3c647824
PE
6542 * dispextern.h (struct redisplay_interface): Rename param
6543 to avoid shadowing.
e264f262 6544 * termhooks.h (struct terminal): Likewise.
761383f4 6545 * xterm.c (xembed_send_message): Likewise.
3c647824 6546
b58c5c4a
PE
6547 * insdel.c (make_gap_smaller): Define only if
6548 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6549
cad59032
PE
6550 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6551 it.
6552
c339dc2e
PE
6553 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6554 so that we aren't warned about unused symbols.
6555
91a3e27b
PE
6556 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6557
399c71d3 6558 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6559
8ffc96f5
PE
6560 * xfns.c (x_real_positions): Mark locals as initialized.
6561
eef9bc79
PE
6562 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6563
098db9dd
PE
6564 * xterm.c: Fix problems found by static analysis with other toolkits.
6565 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6566 (x_dispatch_event): Declare static if USE_GTK, and
6567 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6568 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6569 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6570 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6571 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6572
eb18f6cc
PE
6573 * xmenu.c (menu_help_callback): Pointer type fixes.
6574 Use const pointers when pointing at readonly data. Avoid pointer
6575 signedness clashes.
6576 (FALSE): Remove unused macro.
6577 (update_frame_menubar): Remove unused decl.
6578
1fe72bf8
PE
6579 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6580
60d9e1db
PE
6581 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6582 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6583 (single_menu_item): Rename local to avoid shadowing.
6584
39261c26
PE
6585 * keyboard.c (make_lispy_event): Remove unused local var.
6586
018c5e19
PE
6587 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6588 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6589
63d2b86e
PE
6590 * bitmaps: Change bitmaps from unsigned char back to the X11
6591 compatible char. Avoid the old compiler warnings about
6592 out-of-range initializers by using, for example, '\xab' rather
6593 than 0xab.
6594
aefd87e1
PE
6595 * xgselect.c (xgselect_initialize): Check vs interface
6596 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6597
bf501fb9
PE
6598 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6599
e9829fdf
PE
6600 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6601 to read-only memory.
6602
1086c095
PE
6603 * fns.c (vector): Remove; this old hack is no longer needed.
6604
2baccd04 6605 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6606 Remove unused var.
dde42981 6607 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6608
72391843 6609 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6610
436c16df 6611 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6612 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6613 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6614
92bb796d 6615 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6616 (x_term_init): Remove local to avoid shadowing.
92bb796d 6617
764430a3 6618 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6619
6620 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6621 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6622
d1dfb56c
EZ
66232011-04-16 Eli Zaretskii <eliz@gnu.org>
6624
c4354cb4
EZ
6625 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6626
d1dfb56c
EZ
6627 Fix regex.c, syntax.c and friends for buffers > 2GB.
6628 * syntax.h (struct gl_state_s): Declare character position members
6629 EMACS_INT.
6630
6631 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6632
04f2d78b
CB
6633 * textprop.c (verify_interval_modification, interval_of):
6634 Declare arguments EMACS_INT.
d1dfb56c
EZ
6635
6636 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6637 EMACS_INT.
6638
6639 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6640
6641 * indent.c (Fvertical_motion): Local variable it_start is now
6642 EMACS_INT.
6643
6644 * regex.c (re_match, re_match_2, re_match_2_internal)
6645 (bcmp_translate, regcomp, regexec, print_double_string)
6646 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6647 (re_compile_pattern, re_exec): Declare arguments and local
6648 variables `size_t' and `ssize_t' and return values `regoff_t', as
6649 appropriate.
6650 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6651 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6652 <compile_stack_type>: `size' and `avail' are now `size_t'.
6653
6654 * regex.h <regoff_t>: Use ssize_t, not int.
6655 (re_search, re_search_2, re_match, re_match_2): Arguments that
6656 specify buffer/string position and length are now ssize_t and
6657 size_t. Return type is regoff_t.
6658
613052cd
BK
66592011-04-16 Ben Key <bkey76@gmail.com>
6660
6661 * nsfont.m: Fixed bugs in ns_get_family and
6662 ns_descriptor_to_entity that were caused by using free to
6663 deallocate memory blocks that were allocated by xmalloc (via
6664 xstrdup). This caused Emacs to crash when compiled with
6665 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6666 --enable-checking=xmallocoverrun). xfree is now used to
6667 deallocate these memory blocks.
6668
4170f62f 66692011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6670
71b41406
PE
6671 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6672
9587a89d
PE
6673 emacs_write: Accept and return EMACS_INT for sizes.
6674 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6675 et seq.
6676 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6677 Accept and return EMACS_INT.
6678 (emacs_gnutls_write): Return the number of bytes written on
6679 partial writes.
6680 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6681 (emacs_read, emacs_write): Remove check for negative size, as the
6682 Emacs source code has been audited now.
9587a89d
PE
6683 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6684 (emacs_read, emacs_write): Use it.
273a5f82
PE
6685 * process.c (send_process): Adjust to the new signatures of
6686 emacs_write and emacs_gnutls_write. Do not attempt to store
6687 a byte offset into an 'int'; it might overflow.
9587a89d 6688 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6689
3e047f51
PE
6690 * sound.c: Don't assume sizes fit in 'int'.
6691 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6692 Return EMACS_INT, not int.
3e047f51 6693 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6694 Accept EMACS_INT, not int.
6695 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6696 record read return values.
6697
cc39a9db
BK
66982011-04-15 Ben Key <bkey76@gmail.com>
6699
c9d0ec6d
JB
6700 * keyboard.c (Qundefined): Don't declare static since it is used
6701 in nsfns.m.
6702 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6703 static since they are used in nsfont.m.
cc39a9db 6704
6c60eb9f
SM
67052011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6706
6707 * process.c (Qprocessp): Don't declare static.
6708 * lisp.h (Qprocessp): Declare again.
6709
7990b61a
JB
67102011-04-15 Juanma Barranquero <lekktu@gmail.com>
6711
6712 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6713
5d4cb038
PE
67142011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6715
8bd7b830 6716 Improve C-level modularity by making more things 'static'.
cd64ea1d 6717
e3b27b31
PE
6718 Don't publish debugger-only interfaces to other modules.
6719 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6720 (verify_bytepos, count_markers): Move decls to the only modules
6721 that need them.
6722 * region-cache.h (pp_cache): Likewise.
6723 * window.h (check_all_windows): Likewise.
6724 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6725
5d4cb038
PE
6726 * sysdep.c (croak): Now static, if
6727 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6728 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6729
6730 * alloc.c (refill_memory_reserve): Now static if
6731 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6732 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6733
e87b6180
PE
6734 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6735 Define only if USE_LUCID.
6736
ac64929e
PE
6737 * xrdb.c (x_customization_string, x_rm_string): Now static.
6738
6f37259d
PE
6739 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6740 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6741
1683e3ab
PE
6742 * xdisp.c (draw_row_with_mouse_face): Now static.
6743 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6744
de9c2632
PE
6745 * window.h (check_all_windows): Mark externally visible.
6746
2b96acb7
PE
6747 * window.c (window_deletion_count): Now static.
6748
6749 * undo.c: Make symbols static if they're not exported.
6750 (last_undo_buffer, last_boundary_position, pending_boundary):
6751 Now static.
6752
50436f33
PE
6753 * textprop.c (interval_insert_behind_hooks): Now static.
6754 (interval_insert_in_front_hooks): Likewise.
6755
64520e5c
PE
6756 * term.c: Make symbols static if they're not exported.
6757 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6758 (max_frame_lines, tty_set_terminal_modes):
6759 (tty_reset_terminal_modes, tty_turn_off_highlight):
6760 (get_tty_terminal): Now static.
6761 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6762 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6763 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6764 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6765 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6766
1fa53021
PE
6767 * sysdep.c: Make symbols static if they're not exported.
6768 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6769 Now static.
6770 (sigprocmask_set, full_mask): Remove; unused.
6771 (wait_debugging): Mark as visible.
6772 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6773 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6774
d4b43b22
PE
6775 * syntax.c (syntax_temp): Define only if !__GNUC__.
6776
b7c513d0
PE
6777 * sound.c (current_sound_device, current_sound): Now static.
6778
989b29ad
PE
6779 * search.c (searchbufs, searchbuf_head): Now static.
6780
13a55a78
PE
6781 * scroll.c (scroll_cost): Remove; unused.
6782 * dispextern.h (scroll_cost): Remove decl.
6783
de68a1fc
PE
6784 * region-cache.h (pp_cache): Mark as externally visible.
6785
40ccffa6
PE
6786 * process.c: Make symbols static if they're not exported.
6787 (process_tick, update_tick, create_process, chan_process):
6788 (Vprocess_alist, proc_buffered_char, datagram_access):
6789 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6790 (deactivate_process): Mark defn as static, as well as decl.
6791 * lisp.h (create_process): Remove decl.
6792 * process.h (chan_process, Vprocess_alist): Remove decls.
6793
ad64fc97
PE
6794 * print.c: Make symbols static if they're not exported.
6795 (print_depth, new_backquote_output, being_printed, print_buffer):
6796 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6797 (print_interval, print_number_index, initial_stderr_stream):
6798 Now static.
6799 * lisp.h (Fprinc): Remove decl.
6800 (debug_output_compilation_hack): Mark as externally visible.
6801
adddb265
PE
6802 * sysdep.c (croak): Move decl from here to syssignal.h.
6803 * syssignal.h (croak): Put it here, so the API can be checked when
6804 'croak' is called from dissociate_if_controlling_tty.
6805
1717ede2
PE
6806 * minibuf.c: Make symbols static if they're not exported.
6807 (minibuf_save_list, choose_minibuf_frame): Now static.
6808 * lisp.h (choose_minibuf_frame): Remove decl.
6809
fa5fb2bc
PE
6810 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6811
1e3890d1
PE
6812 * lread.c: Make symbols static if they're not exported.
6813 (read_objects, initial_obarray, oblookup_last_bucket_number):
6814 Now static.
6815 (make_symbol): Remove; unused.
6816 * lisp.h (initial_obarray, make_symbol): Remove decls.
6817
8a1414fa
PE
6818 * keyboard.c: Make symbols static if they're not exported.
6819 (single_kboard, recent_keys_index, total_keys, recent_keys):
6820 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6821 (this_single_command_key_start, echoing, last_auto_save):
6822 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6823 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6824 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6825 (Vlispy_mouse_stem, double_click_count):
6826 Now static.
6827 (force_auto_save_soon): Define only if SIGDANGER.
6828 (ignore_mouse_drag_p): Now static if
6829 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6830 (print_help): Remove; unused.
6831 (stop_character, last_timer_event): Mark as externally visible.
6832 * keyboard.h (ignore_mouse_drag_p): Declare only if
6833 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6834 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6835 * lisp.h (echoing): Remove decl.
6836 (force_auto_save_soon): Declare only if SIGDANGER.
6837 * xdisp.c (redisplay_window): Simplify code, to make it more
6838 obvious that ignore_mouse_drag_p is not accessed if !defined
6839 USE_GTK && !defined HAVE_NS.
6840
93ea6e8f
PE
6841 * intervals.c: Make symbols static if they're not exported.
6842 (merge_properties_sticky, merge_interval_right, delete_interval):
6843 Now static.
6844 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6845
77382fcc
PE
6846 * insdel.c: Make symbols static if they're not exported.
6847 However, leave prepare_to_modify_buffer alone. It's never
6848 called from outside this function, but that appears to be a bug.
6849 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6850 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6851 (adjust_after_replace_noundo): Remove; unused.
6852 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6853 (signal_before_change): Remove decls.
77382fcc 6854
9306c32e
PE
6855 * indent.c (val_compute_motion, val_vmotion): Now static.
6856
cd44d2eb
PE
6857 * image.c: Make symbols static if they're not exported.
6858 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6859 if USE_GTK.
6860 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6861 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6862
ad9a7a06
PE
6863 * fringe.c (standard_bitmaps): Now static.
6864 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6865
81626931
PE
6866 * frame.c: Make symbols static if they're not exported.
6867 (x_report_frame_params, make_terminal_frame): Now static.
6868 (get_frame_param): Now static, unless HAVE_NS.
6869 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6870 (x_get_resource_string): Remove; not used.
6871 * frame.h (make_terminal_frame, x_report_frame_params):
6872 (x_get_resource_string); Remove decls.
6873 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6874 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6875
239f9db9
PE
6876 * font.c, fontset.c: Make symbols static if they're not exported.
6877 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6878 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6879 * font.c (font_close_object): Now static.
6880 * font.h (font_close_object): Remove.
6881 * fontset.c (FONTSET_OBJLIST): Remove.
6882 (free_realized_fontset) #if-0 the body, which does nothing.
6883 (face_suitable_for_char_p): #if-0, as it's never called.
6884 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6885 * xfaces.c (face_at_string_position):
6886 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6887 since 0 is always ASCII.
6888
dfcf3579
PE
6889 * fns.c (weak_hash_tables): Now static.
6890
5045092b
PE
6891 * fileio.c: Make symbols static if they're not exported.
6892 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6893 (Vwrite_region_annotation_buffers): Now static.
6894
57a96f5c
PE
6895 * eval.c: Make symbols static if they're not exported.
6896 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6897 * lisp.h (backtrace_list): Remove decl.
6898
35f08c38
PE
6899 * emacs.c: Make symbols static if they're not exported.
6900 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6901 (fatal_error_code, fatal_error_signal_hook, standard_args):
6902 Now static.
6903 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6904 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6905 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6906 * lisp.h (fatal_error_signal_hook): Remove decl.
6907 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6908
f44bd759
PE
6909 * editfns.c: Move a (normally-unused) function to its only use.
6910 * editfns.c, lisp.h (get_operating_system_release): Remove.
6911 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6912 worth the hassle of breaking this out.
6913
b532497d
PE
6914 * xterm.c: Make symbols static if they're not exported.
6915 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6916 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6917 (x_destroy_window, x_delete_display):
6918 Now static.
6919 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6920 (x_mouse_leave): Remove; unused.
6921 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6922 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6923 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6924 Remove decls.
6925 (x_mouse_leave): Declare only if WINDOWSNT.
6926 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6927 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6928 USE_X_TOOLKIT.
6929
1675728f
PE
6930 * ftxfont.c: Make symbols static if they're not exported.
6931 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6932 HAVE_FREETYPE.
6933 * font.h (ftxfont_driver): Likewise.
6934
e4cebfca
PE
6935 * xfns.c: Make symbols static if they're not exported.
6936 (x_last_font_name, x_display_info_for_name):
6937 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6938 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6939 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6940 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6941 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6942 (last_show_tip_args): Now static.
6943 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6944 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6945 (x_screen_planes): Remove; unused.
6946 * dispextern.h (x_screen_planes): Remove decl.
6947
5bf46f05
PE
6948 * dispnew.c: Make symbols static if they're not exported.
6949 * dispextern.h (redraw_garbaged_frames, scrolling):
6950 (increment_row_positions): Remove.
6951 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6952 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6953 Now static.
6954 (redraw_garbaged_frames): Remove; unused.
6955
435f4c28
PE
6956 * xfaces.c: Make symbols static if they're not exported.
6957 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6958 Remove decls.
6959 * xterm.h (defined_color): Remove decls.
6960 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6961 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6962 (menu_face_changed_default, defined_color, free_realized_face):
6963 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6964 (ascii_face_of_lisp_face): Remove; unused.
6965
8524aef3
PE
6966 * xdisp.c: Make symbols static if they're not exported.
6967 * dispextern.h (scratch_glyph_row, window_box_edges):
6968 (glyph_to_pixel_coords, set_cursor_from_row):
6969 (get_next_display_element, set_iterator_to_next):
6970 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6971 (show_mouse_face): Remove decls
6972 * frame.h (message_buf_print): Likewise.
6973 * lisp.h (pop_message, set_message, check_point_in_composition):
6974 Likewise.
6975 * xterm.h (set_vertical_scroll_bar): Likewise.
6976 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6977 (message_buf_print, scratch_glyph_row, displayed_buffer):
6978 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6979 (get_next_display_element, show_mouse_face, window_box_edges):
6980 (frame_to_window_pixel_xy, check_point_in_composition):
6981 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6982 (glyph_to_pixel_coords): Remove; unused.
6983
16390cd2
PE
6984 * dired.c (file_name_completion): Now static.
6985
6986 * dbusbind.c (xd_in_read_queued_messages): Now static.
6987
a25f4dfa
PE
6988 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6989 * data.c (circular_list_error): Remove.
6990
14a9c8df
PE
6991 * commands.h (last_point_position, last_point_position_buffer):
6992 (last_point_position_window): Remove decls.
6993 * keyboard.c: Make these variables static.
6994
04f2d78b
CB
6995 * coding.h (coding, code_convert_region, encode_coding_gap):
6996 Remove decls.
74ab6df5
PE
6997 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6998 (iso_code_class, detect_coding, code_convert_region): Now static.
6999 (encode_coding_gap): Remove; unused.
7000
38dfbee1
PE
7001 * chartab.c (chartab_chars, chartab_bits): Now static.
7002
a2cb4e63
PE
7003 * charset.h (charset_iso_8859_1): Remove decl.
7004 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7005 Now static.
7006
127198fd
PE
7007 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7008 * ccl.c (Vccl_program_table): Now static.
7009 (check_ccl_update): Remove; unused.
7010
d85b608f
PE
7011 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7012 * category.h: ... from here.
7013 * category.c (check_category_table, set_category_set): Now static.
7014
31cd66f3
PE
7015 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7016 * lisp.h: Remove these decls.
7017
c358e587
PE
7018 * buffer.c (buffer_count): Remove unused var.
7019
e78aecca
PE
7020 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7021 so that it's not optimized away.
7022 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7023 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7024 exported only to the debugger.
7025
e192d7d3 7026 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7027 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7028
92470028
PE
7029 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7030 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7031 was inaccessible from Lisp.
7032 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7033 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7034
244ed907
PE
7035 alloc.c: Import and export fewer symbols, and remove unused items.
7036 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7037 is defined.
7038 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7039 it's not optimized away by whole-program optimization.
7040 (message_enable_multibyte, free_misc): Remove.
7041 (catchlist, handlerlist, mark_backtrace):
7042 Declare only if BYTE_MARK_STACK.
7043 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7044 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7045 (message_enable_multibyte): Remove decl.
7046 (free_misc, interval_free_list, float_block, float_block_index):
7047 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7048 (cons_free_list, last_marked_index):
7049 Now static.
7050 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7051 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7052 (mark_backtrace): Define only if BYTE_MARK_STACK.
7053 * xdisp.c (message_enable_multibyte): Now static.
7054
61c2b50e 7055 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7056 This makes it easier for human readers (and static analyzers)
7057 to see whether these variables are used from other modules.
7058 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7059 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7060 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7061 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7062 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7063 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7064 * xmenu.c, xselect.c:
7065 Declare Q* vars static if they are not used in other modules.
7066 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7067 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7068 Remove decls of unexported vars.
7069 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7070
95c82688
PE
7071 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7072
16a97296
PE
7073 Make Emacs functions such as Fatom 'static' by default.
7074 This makes it easier for human readers (and static analyzers)
7075 to see whether these functions can be called from other modules.
7076 DEFUN now defines a static function. To make the function external
7077 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7078 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7079 (Finit_image_library):
16a97296
PE
7080 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7081 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7082 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7083 Remove decls, since these functions are now static.
7084 (Funintern, Fget_internal_run_time): New decls, since these functions
7085 were already external.
95c82688 7086
16a97296
PE
7087 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7088 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7089 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7090 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7091 * keyboard.c, keymap.c, lread.c:
7092 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7093 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7094 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7095 Mark functions with DEFUE instead of DEFUN,
7096 if they are used in other modules.
7097 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7098 decls for now-static functions.
7099 * buffer.h (Fdelete_overlay): Remove decl.
7100 * callproc.c (Fgetenv_internal): Mark as internal.
7101 * composite.c (Fremove_list_of_text_properties): Remove decl.
7102 (Fcomposition_get_gstring): New forward static decl.
7103 * composite.h (Fcomposite_get_gstring): Remove decl.
7104 * dired.c (Ffile_attributes): New forward static decl.
7105 * doc.c (Fdocumntation_property): New forward static decl.
7106 * eval.c (Ffetch_bytecode): New forward static decl.
7107 (Funintern): Remove extern decl; now in .h file where it belongs.
7108 * fileio.c (Fmake_symbolic_link): New forward static decl.
7109 * image.c (Finit_image_library): New forward static decl.
7110 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7111 * intervals.h (Fprevious_property_change):
7112 (Fremove_list_of_text_properties): Remove decls.
7113 * keyboard.c (Fthis_command_keys): Remove decl.
7114 (Fcommand_execute): New forward static decl.
7115 * keymap.c (Flookup_key): New forward static decl.
7116 (Fcopy_keymap): Now static.
7117 * keymap.h (Flookup_key): Remove decl.
7118 * process.c (Fget_process): New forward static decl.
7119 (Fprocess_datagram_address): Mark as internal.
7120 * syntax.c (Fsyntax_table_p): New forward static decl.
7121 (skip_chars): Remove duplicate decl.
7122 * textprop.c (Fprevious_property_change): New forward static decl.
7123 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7124 Now internal.
7125 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7126 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7127
785bbd42
PE
7128 * editfns.c (Fformat): Remove unreachable code.
7129
8b913b57
AS
71302011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7131
7132 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7133 change. (Bug#8496)
7134
a6744a35
EZ
71352011-04-13 Eli Zaretskii <eliz@gnu.org>
7136
7137 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7138 when at ZV. (Bug#8487)
7139
e7974947
AS
71402011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7141
baad03f0
AS
7142 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7143 (Bug#8437)
7144 * keyboard.c (parse_tool_bar_item): Likewise.
7145 * sound.c (sound_cleanup, alsa_close): Likewise.
7146 * termcap.c (tgetent): Likewise.
7147 * xfns.c (x_default_font_parameter): Likewise.
7148 * xsettings.c (read_and_apply_settings): Likewise.
7149
e7974947
AS
7150 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7151 (overrun_check_free): Protoize.
7152
28272684
PE
71532011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7154
7155 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7156 since callers should never pass a negative size.
7157 Change the signature to match that of plain 'read' and 'write'; see
7158 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7159 * lisp.h: Update prototypes of emacs_write and emacs_read.
7160
11997c76
EZ
71612011-04-11 Eli Zaretskii <eliz@gnu.org>
7162
7163 * xdisp.c (redisplay_window): Don't try to determine the character
7164 position of the scroll margin if the window start point w->startp
e896f03c 7165 is outside the buffer's accessible region. (Bug#8468)
11997c76 7166
8a2cbd72
EZ
71672011-04-10 Eli Zaretskii <eliz@gnu.org>
7168
7169 Fix write-region and its subroutines for buffers > 2GB.
7170 * fileio.c (a_write, e_write): Modify declaration of arguments and
7171 local variables to support buffers larger than 2GB.
7172 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7173
7174 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7175 argument, local variables, and return value.
7176
7177 * lisp.h: Update prototypes of emacs_write and emacs_read.
7178
7179 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7180
4073e537 71812011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7182
1ebfdcb6
PE
7183 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7184
b2ded58d
PE
7185 Fix more problems found by GCC 4.6.0's static checks.
7186
7d66342c
PE
7187 * xdisp.c (vmessage): Use a better test for character truncation.
7188
bbf47d44
PE
7189 * charset.c (load_charset_map): <, not <=, for optimization,
7190 and to avoid potential problems with integer overflow.
9248994d 7191 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7192 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7193 * editfns.c (Fformat): Likewise.
1e69125e 7194 * syntax.c (skip_chars): Likewise.
3befa583 7195
e3019616
PE
7196 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7197 This also lets GCC 4.6.0 generate slightly better loop code.
7198
becfa255
PE
7199 * callint.c (Fcall_interactively): <, not <=, for optimization.
7200 (Fcall_interactively): Count the number of arguments produced,
7201 not the number of arguments given. This is simpler and lets GCC
7202 4.6.0 generate slightly better code.
7203
dae0cd48
PE
7204 * ftfont.c: Distingish more carefully between FcChar8 and char.
7205 The previous code passed unsigned char * to a functions like
7206 strlen and xstrcasecmp that expect char *, which does not
7207 conform to the C standard.
7208 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7209 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7210 char * when the C standard requires it.
7211
76032d70
PE
7212 * keyboard.c (read_char): Remove unused var.
7213
eb3f1cc8
PE
7214 * eval.c: Port to Windows vsnprintf (Bug#8435).
7215 Include <limits.h>.
7216 (SIZE_MAX): Define if the headers do not.
7217 (verror): Do not give up if vsnprintf returns a negative count.
7218 Instead, grow the buffer. This ports to Windows vsnprintf, which
7219 does not conform to C99. Problem reported by Eli Zaretskii.
7220 Also, simplify the allocation scheme, by avoiding the need for
7221 calling realloc, and removing the ALLOCATED variable.
7222
70476b54
PE
7223 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7224
12020a9e
PE
7225 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7226 But keep the doprint source code for now, as we might revamp it
7227 and use it again (Bug#8435).
ea6c7ae6
PE
7228 * lisp.h (doprnt): Remove.
7229 * Makefile.in (base_obj): Remove doprnt.o.
7230 * deps.mk (doprnt.o): Remove.
7231
5fdb398c
PE
7232 error: Print 32- and 64-bit integers portably (Bug#8435).
7233 Without this change, on typical 64-bit hosts error ("...%d...", N)
7234 was used to print both 32- and 64-bit integers N, which relied on
7235 undefined behavior.
7236 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7237 New macro.
7238 * lisp.h (error, verror): Mark as printf-like functions.
7239 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7240 Report overflow in size calculations when allocating printf buffer.
7241 Do not truncate output string at its first null byte.
7242 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7243 Truncate the output at a character boundary, since vsnprintf does not
7244 do that.
7245 * charset.c (check_iso_charset_parameter): Convert internal
7246 character to string before calling 'error', since %c now has the
7247 printf meaning.
7248 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7249 overflow when computing char to be passed to 'error'. Do not
7250 pass Lisp_Object to 'error'; pass the integer instead.
7251 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7252 formatted with plain %d.
7253
b189fa66
PE
7254 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7255
bff87ef0
PE
7256 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7257
7e2cac20
PE
7258 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7259
ce4d90b5
PE
7260 * xterm.c (x_catch_errors): Remove duplicate declaration.
7261
266c9547
PE
7262 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7263
79c49ad2
PE
7264 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7265
368f4090
JM
72662011-04-10 Jim Meyering <meyering@redhat.com>
7267
7268 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7269 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7270 return ssize_t not "int", and use size_t as the buffer length.
7271 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7272 * gnutls.h: Update declarations.
7273 * process.c (read_process_output): Use ssize_t, to match.
7274 (send_process): Likewise.
7275
a32d4040
CY
72762011-04-09 Chong Yidong <cyd@stupidchicken.com>
7277
7278 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7279
8546720e 72802011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7281
04f2d78b
CB
7282 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7283 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7284
8546720e
GM
7285 * xterm.c (handle_one_xevent):
7286 * xmenu.c (create_and_show_popup_menu):
7287 * xselect.c (x_decline_selection_request)
7288 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7289
0a2f5c1a 72902011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7291
7292 Fix some uses of `int' instead of EMACS_INT.
7293 * search.c (string_match_1, fast_string_match)
7294 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7295 (scan_buffer, find_next_newline_no_quit)
7296 (find_before_next_newline, search_command, Freplace_match)
7297 (Fmatch_data): Make some `int' variables be EMACS_INT.
7298
7299 * xdisp.c (display_count_lines): 3rd argument and return value now
7300 EMACS_INT. All callers changed.
7301 (pint2hrstr): Last argument is now EMACS_INT.
7302
7303 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7304 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7305 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7306 (decode_coding_utf_16, decode_coding_emacs_mule)
7307 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7308 (decode_coding_ccl, decode_coding_charset)
7309 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7310 (decode_coding_iso_2022, decode_coding_emacs_mule)
7311 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7312 <char_offset, last_offset>: Declare EMACS_INT.
7313 (encode_coding_utf_8, encode_coding_utf_16)
7314 (encode_coding_emacs_mule, encode_invocation_designation)
7315 (encode_designation_at_bol, encode_coding_iso_2022)
7316 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7317 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7318 Declare EMACS_INT.
7319 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7320 (encode_invocation_designation): Last argument P_NCHARS is now
7321 EMACS_INT.
7322 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7323 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7324
7325 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7326 All users changed.
7327
7328 * ccl.c (Fccl_execute_on_string): Declare some variables
7329 EMACS_INT.
7330
8546720e 73312011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7332
7333 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7334
4e19a977
CS
73352011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7336
7337 * process.c (Fformat_network_address): Doc fix.
7338
87302331
R
73392011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7340
ee7683eb 7341 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7342
cbb59342
CY
73432011-04-08 Chong Yidong <cyd@stupidchicken.com>
7344
7345 * keyboard.c (read_char): Call Lisp function help-form-show,
7346 instead of using internal_with_output_to_temp_buffer.
7347 (Qhelp_form_show): New var.
e0d38eeb 7348 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7349
7350 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7351
7352 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7353
e67a13ab
CY
73542011-04-06 Chong Yidong <cyd@stupidchicken.com>
7355
04f2d78b
CB
7356 * process.c (Flist_processes): Remove to Lisp.
7357 (list_processes_1): Delete.
e67a13ab 7358
973f782d
EZ
73592011-04-06 Eli Zaretskii <eliz@gnu.org>
7360
7c106b1e
EZ
7361 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7362
973f782d
EZ
7363 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7364
41cf7d1a 73652011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7366
ca23cc88
PE
7367 Fix more problems found by GCC 4.6.0's static checks.
7368
f390e2d5
PE
7369 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7370
42eea0d0
PE
7371 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7372
b69769da 7373 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7374
f9541e84
PE
7375 * xdisp.c (vmessage): Mark as a printf-like function.
7376
13841b55
PE
7377 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7378
c136c10f
PE
7379 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7380
5e2d4a30
PE
7381 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7382 printf-like functions.
7383 (tiff_load): Add casts to remove these marks before passing them
7384 to system-supplied API.
7385
583f48b9
PE
7386 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7387
b25d760e
PE
7388 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7389 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7390 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7391 directly, rather than having caller test rule sign. This avoids
7392 some unnecessary tests.
7393 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7394 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7395 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7396
bc7b6697 7397 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7398 (xfont_open): Avoid unnecessary tests.
bc7b6697 7399
27ccc379
PE
7400 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7401
dcd5c89a
PE
7402 * composite.h, composite.c (composition_gstring_put_cache):
7403 Use EMACS_INT, not int, for length.
7404
b13a45c6
PE
7405 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7406 breaking out part of COMPOSITION_DECODE_RULE.
7407 (COMPOSITION_DECODE_RULE): Use it.
7408 * composite.c (get_composition_id): Remove unused local vars,
7409 by using the new macro.
7410
1e792e4d
PE
7411 * textprop.c (set_text_properties_1): Change while to do-while,
7412 since the condition is always true at first.
7413
dc6c6455 7414 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7415 (interval_deletion_adjustment): Return unsigned value.
7416 All uses changed.
dc6c6455 7417
aba7731a
PE
7418 * process.c (list_processes_1, create_pty, read_process_output):
7419 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7420 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7421 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7422 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7423 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7424
fdfc4bf3
PE
7425 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7426
fca8fe46 7427 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7428 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7429
06a0259a 7430 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7431 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7432 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7433
e7b9e80f
PE
7434 * print.c (print_error_message): Avoid int overflow.
7435
56201685
PE
7436 * font.c (font_list_entities): Redo for clarity,
7437 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7438
78834453 7439 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7440 (font_score): Avoid potential overflow in diff calculation.
78834453 7441
0bc0b309 7442 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7443 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7444
e610eaca
PE
7445 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7446
b895abce
PE
7447 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7448 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7449 can always succeed if overflow has undefined behavior.
7450
1f1d9321 7451 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7452 (wordify): Omit three unnecessary tests.
1f1d9321 7453
c59478bc
PE
7454 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7455 All callers changed. This avoids the need for an unused var.
7456
79b73827
PE
7457 * casefiddle.c (casify_region): Remove var that is set but not used.
7458
a4db5dfe
PE
7459 * dired.c (file_name_completion): Remove var that is set but not used.
7460
43aae36e
PE
7461 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7462
2a47c44d 7463 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7464 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7465
a37c69bf
PE
7466 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7467 Check for integer overflow on size calculations.
7468
328ab8e7
PE
7469 * buffer.c (Fprevious_overlay_change): Remove var that is set
7470 but not used.
7471
e5a2a5cb
PE
7472 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7473 Remove vars that are set but not used.
8d84a6eb 7474 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7475 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7476
a60e5f68
PE
7477 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7478
f661cb61 7479 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7480 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7481
f0397f5a
PE
7482 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7483 that are set but not used.
7484
8664db06 7485 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7486 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7487
6abdaa4a
PE
7488 * xselect.c (x_get_local_selection, x_handle_property_notify):
7489 Remove vars that are set but not used.
7490
0ce7538d 7491 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7492 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7493
9ae848fc
PE
7494 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7495 Remove var that is set but not used.
0b918413
PE
7496 (scroll_bar_windows_size): Now size_t, not int.
7497 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7498 Check for overflow.
9ae848fc 7499
a5a62657
PE
7500 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7501 (map_tty_color) [!defined MSDOS]: Likewise.
7502
5c5cdd39
PE
7503 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7504
66ebf983
PE
7505 * coding.c: Remove vars that are set but not used.
7506 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7507 All callers changed.
7508 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7509 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7510 (decode_coding_charset): Remove vars that are set but not used.
7511
1be4d761
PE
7512 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7513 that is set but not used.
7514
47553fa8
PE
7515 * print.c (print_object): Remove var that is set but not used.
7516
1f7196bf 7517 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7518 The gnulib version avoids calling malloc in the usual case,
7519 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7520 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7521 * filelock.c (current_lock_owner): Likewise.
7522 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7523 * sysdep.c: Include allocator.h, careadlinkat.h.
7524 (emacs_no_realloc_allocator): New static constant.
7525 (emacs_readlink): New function.
fdb61804
PE
7526 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7527 ../lib/careadlinkat.h.
d1fdcab7 7528
f84c17c7
SM
75292011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7530
7531 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7532 first non-nil return value).
7533
ef3862ad
JD
75342011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7535
7536 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7537 if not defined (Bug#8403).
7538
376a7006
JB
75392011-04-02 Juanma Barranquero <lekktu@gmail.com>
7540
7541 * xdisp.c (display_count_lines): Remove parameter `start',
7542 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7543 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7544 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7545 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7546 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7547 and thereabouts. All callers changed.
7548 (get_per_char_metric): Remove parameter `f', unused since
7549 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7550
6ca3801d
JM
75512011-04-02 Jim Meyering <meyering@redhat.com>
7552
7553 do not dereference NULL upon failed strdup
7554 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7555 (ns_get_family): Likewise.
7556
d8e2b5ba
JB
75572011-04-02 Juanma Barranquero <lekktu@gmail.com>
7558
7559 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7560
8c74fcbd
JD
75612011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7562
7563 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7564 later (Bug#8403).
7565
7200d79c
SM
75662011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7567
03408648 7568 Add lexical binding.
7200d79c 7569
03408648
SM
7570 * window.c (Ftemp_output_buffer_show): New fun.
7571 (Fsave_window_excursion):
7572 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7573
7574 * lread.c (lisp_file_lexically_bound_p): New function.
7575 (Fload): Bind Qlexical_binding.
7576 (readevalloop): Remove `evalfun' arg.
7577 Bind Qinternal_interpreter_environment.
7578 (Feval_buffer): Bind Qlexical_binding.
7579 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7580 Mark as dynamic.
7581 (syms_of_lread): Declare `lexical-binding'.
7582
7583 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7584
7585 * keyboard.c (eval_dyn): New fun.
7586 (menu_item_eval_property): Use it.
ca105506
SM
7587
7588 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7589
03408648
SM
7590 * fns.c (concat, mapcar1): Accept byte-code-functions.
7591
7592 * eval.c (Fsetq): Handle lexical vars.
7593 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7594 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7595 (FletX, Flet): Obey lexical binding.
7596 (Fcommandp): Handle closures.
7597 (Feval): New `lexical' arg.
7598 (eval_sub): New function extracted from Feval. Use it almost
7599 everywhere where Feval was used. Look up vars in lexical env.
7600 Handle closures.
7601 (Ffunctionp): Move from subr.el.
7602 (Ffuncall): Handle closures.
7603 (apply_lambda): Remove `eval_flags'.
7604 (funcall_lambda): Handle closures and new byte-code-functions.
7605 (Fspecial_variable_p): New function.
7606 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7607 but without exporting it to Lisp.
23aba0ea 7608
23aba0ea 7609 * doc.c (Fdocumentation, store_function_docstring):
03408648 7610 * data.c (Finteractive_form): Handle closures.
23aba0ea 7611
03408648
SM
7612 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7613 interactive spec.
ba83908c 7614
04f2d78b
CB
7615 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7616 New byte-codes.
03408648
SM
7617 (exec_byte_code): New function extracted from Fbyte_code to handle new
7618 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7619
03408648 7620 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7621
03408648 7622 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7623
e2abce01
JB
76242011-03-31 Juanma Barranquero <lekktu@gmail.com>
7625
7626 * xdisp.c (redisplay_internal): Fix prototype.
7627
63696a73 76282011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7629
63696a73 7630 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7631 (try_scrolling): Use it when setting scroll_limit.
7632 Limit scrolling to 100 screen lines.
63696a73
EZ
7633 (redisplay_window): Even when falling back on "recentering",
7634 position point in the window according to scroll-conservatively,
7635 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7636
7637 (try_scrolling): When point is above the window, allow searching
7638 as far as scroll_max, or one screenful, to compute vertical
7639 distance from PT to the scroll margin position. This prevents
7640 try_scrolling from unnecessarily failing when
7641 scroll-conservatively is set to a value slightly larger than the
7642 window height. Clean up the case of PT below the margin at bottom
7643 of window: scroll_max can no longer be INT_MAX. When aggressive
7644 scrolling is in use, don't let point enter the opposite scroll
7645 margin as result of the scroll.
7646 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7647 threshold of 100 lines for never-recentering scrolling.
7648
e4cc2dfc
JB
76492011-03-31 Juanma Barranquero <lekktu@gmail.com>
7650
7651 * dispextern.h (move_it_by_lines):
7652 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7653 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7654 (message_log_check_duplicate): Remove parameters `prev_bol' and
7655 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7656 (redisplay_internal): Remove parameter `preserve_echo_area',
7657 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7658
7659 * indent.c (Fvertical_motion):
7660 * window.c (window_scroll_pixel_based, Frecenter):
7661 Don't pass `need_y_p' to `move_it_by_lines'.
7662
1c470562
SM
76632011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7664
44f230aa
SM
7665 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7666 steal a few bits to be more compact.
7667 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7668 Remove unneeded casts.
7669
1c470562
SM
7670 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7671
888adce9
ZK
76722011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7673
7674 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7675 binding" message (bug#7967).
7676
f838ed7b
PE
76772011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7678
77861b95
PE
7679 Fix more problems found by GCC 4.6.0's static checks.
7680
de6dbc14
PE
7681 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7682 Remove unused local var.
7683
f838ed7b
PE
7684 * editfns.c (Fmessage_box): Remove unused local var.
7685
792c7b2b
PE
7686 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7687 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7688 Omit unused local vars.
c499e557 7689 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7690 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7691 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7692 Omit unused local var.
7693
ba0165e1
PE
7694 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7695 Don't assume string length fits in int.
32ad8845 7696 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7697 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7698
3c59b4c9
PE
7699 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7700 instead of alloca (Bug#8344).
7701
a3eed478 7702 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7703 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7704
eb4d412d
PE
7705 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7706
1658b401
PE
7707 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7708 concerns.
7709
7710 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7711
7712 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7713
9a2c6e05
PE
7714 * keyboard.c (syms_of_keyboard): Use the same style as later
7715 in this function when indexing through an array. This also
7716 works around GCC bug 48267.
7717
03d0a109
PE
7718 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7719
44f730c8
PE
7720 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7721
fe75f926
PE
7722 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7723 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7724
ffa8c828
PE
7725 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7726 This avoids undefined behavior on integer overflow, and is a bit
7727 more convenient anyway since it is compared to a size_t variable.
7728
c5101a77
PE
7729 Variadic C functions now count arguments with size_t, not int.
7730 This avoids an unnecessary limitation on 64-bit machines, which
7731 caused (substring ...) to crash on large vectors (Bug#8344).
7732 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7733 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7734 All variadic functions and their callers changed accordingly.
c5101a77
PE
7735 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7736 * data.c (arith_driver, float_arith_driver): Likewise.
7737 * editfns.c (general_insert_function): Likewise.
7738 * eval.c (struct backtrace.nargs, interactive_p)
7739 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7740 (funcall_lambda, mark_backtrace): Likewise.
7741 * fns.c (concat): Likewise.
7742 * frame.c (x_set_frame_parameters): Likewise.
7743 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7744 0 if not found, not -1. All callers changed.
7745
dd3f25f7
PE
7746 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7747 (stack_copy_size): Now size_t, not int.
7748 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7749
461c2ab9
JB
77502011-03-28 Juanma Barranquero <lekktu@gmail.com>
7751
7752 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7753 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7754 All callers changed.
7755
7756 * lisp.h (multibyte_char_to_unibyte):
7757 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7758 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7759 * character.h (CHAR_TO_BYTE8):
7760 * cmds.c (internal_self_insert):
7761 * editfns.c (general_insert_function):
7762 * keymap.c (push_key_description):
7763 * search.c (Freplace_match):
7764 * xdisp.c (message_dolog, set_message_1): All callers changed.
7765
f6d62986
SM
77662011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7767
7768 * keyboard.c (safe_run_hook_funcall): New function.
7769 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7770 don't set the hook to nil, but remove the offending function instead.
7771 (Qcommand_hook_internal): Remove, unused.
7772 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7773 Vcommand_hook_internal.
7774
7775 * eval.c (enum run_hooks_condition): Remove.
7776 (funcall_nil, funcall_not): New functions.
7777 (run_hook_with_args): Call each function through a `funcall' argument.
7778 Remove `cond' argument, now redundant.
7779 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7780 (Frun_hook_with_args_until_failure): Adjust accordingly.
7781 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7782
1db5b1ad
JB
77832011-03-28 Juanma Barranquero <lekktu@gmail.com>
7784
7785 * dispextern.h (string_buffer_position): Remove declaration.
7786
7787 * print.c (strout): Remove parameter `multibyte', unused since
7788 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7789
7790 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7791 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7792 All callers changed.
7793
7794 * w32.c (_wsa_errlist): Use braces for struct initializers.
7795
7796 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7797 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7798 All callers changed.
7799 (string_buffer_position): Likewise. Also, make static (it's never
7800 used outside xdisp.c).
7801 (cursor_row_p): Remove parameter `w', unused since
7802 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7803 (decode_mode_spec): Remove parameter `precision', introduced during
7804 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7805 All callers changed.
7806
5ffb62aa
JD
78072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7808
7809 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7810
461c2ab9 78112011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7812
7813 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7814 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7815 (ns_update_auto_hide_menu_bar): New functions.
7816 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7817 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7818 ns_constrain_all_frames.
7819 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7820 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7821
5c380ffb
JD
78222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7823
7824 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7825
9af30bdf
GM
78262011-03-27 Glenn Morris <rgm@gnu.org>
7827
7828 * syssignal.h: Replace RETSIGTYPE with void.
7829 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7830 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7831 Replace SIGTYPE with void everywhere.
7832 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7833 * s/template.h (SIGTYPE): Remove commented out definition.
7834
e2abce01
JB
78352011-03-26 Eli Zaretskii <eliz@gnu.org>
7836
7837 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7838 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7839
f868cd8a
JB
78402011-03-26 Juanma Barranquero <lekktu@gmail.com>
7841
59eb0929
JB
7842 * w32.c (read_unc_volume): Use parameter `henum', instead of
7843 global variable `wget_enum_handle'.
7844
7845 * keymap.c (describe_vector): Remove parameters `indices' and
7846 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7847 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7848
f868cd8a
JB
7849 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7850
7851 * keyboard.c (timer_check): Remove parameter `do_it_now',
7852 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7853 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7854 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7855
7856 * keyboard.c (read_char):
7857 * w32menu.c (w32_menu_display_help):
7858 * xmenu.c (show_help_event, menu_help_callback):
7859 Adjust calls to `show_help_echo'.
7860
7861 * gtkutil.c (xg_maybe_add_timer):
7862 * keyboard.c (readable_events):
7863 * process.c (wait_reading_process_output):
7864 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7865
7866 * insdel.c (adjust_markers_gap_motion):
7867 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7868 (gap_left, gap_right): Don't call it.
7869
2ecf6fdb
CY
78702011-03-25 Chong Yidong <cyd@stupidchicken.com>
7871
7872 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7873 incurred during fontification.
7874
6b1f9ba4
JB
78752011-03-25 Juanma Barranquero <lekktu@gmail.com>
7876
7877 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7878 (DEFVAR_PER_BUFFER): Don't pass it.
7879
7880 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7881 (scrolling_window): Don't pass it.
7882
0f4a96b5
JB
78832011-03-25 Juanma Barranquero <lekktu@gmail.com>
7884
7885 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7886
7887 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7888 and `suffix'.
7889 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7890 of variables specific to SELinux and computation of `encoded_absname'.
7891
7892 * image.c (XPutPixel): Remove unused variable `height'.
7893
7894 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7895
7896 * unexw32.c (get_section_info): Remove unused variable `section'.
7897
7898 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7899 (system_process_attributes): Remove unused variable `sess'.
7900 (sys_read): Remove unused variable `err'.
7901
7902 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7903 (w32_wnd_proc): Remove unused variable `isdead'.
7904 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7905 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7906 (x_create_tip_frame): Remove unused variable `tem'.
7907
7908 * w32inevt.c (w32_console_read_socket):
7909 Remove unused variable `no_events'.
7910
7911 * w32term.c (x_draw_composite_glyph_string_foreground):
7912 Remove unused variable `width'.
7913
1149507c
JB
79142011-03-24 Juanma Barranquero <lekktu@gmail.com>
7915
7916 * w32term.c (x_set_glyph_string_clipping):
7917 Don't pass uninitialized region to CombineRgn.
7918
9c88f339
JB
79192011-03-23 Juanma Barranquero <lekktu@gmail.com>
7920
7921 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7922 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7923 (Fx_close_connection): Remove unused variable `i'.
7924
7925 * w32font.c (w32font_draw): Return number of glyphs.
7926 (w32font_open_internal): Remove unused variable `i'.
7927 (w32font_driver): Add missing initializer.
7928
7929 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7930 (fill_in_menu): Remove unused variable `items_added'.
7931
7932 * w32term.c (last_mouse_press_frame): Remove static global variable.
7933 (w32_clip_to_row): Remove unused variable `f'.
7934 (x_delete_terminal): Remove unused variable `i'.
7935
7936 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7937 (NOTHING): Remove unused static global variable.
7938 (uniscribe_check_otf): Remove unused variable `table'.
7939 (uniscribe_font_driver): Add missing initializers.
7940
dee091a3
JD
79412011-03-23 Julien Danjou <julien@danjou.info>
7942
7943 * term.c (Fsuspend_tty, Fresume_tty):
7944 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7945 * window.c (temp_output_buffer_show):
7946 * insdel.c (signal_before_change):
7947 * frame.c (Fhandle_switch_frame):
7948 * fileio.c (Fdo_auto_save):
7949 * emacs.c (Fkill_emacs):
7950 * editfns.c (save_excursion_restore):
7951 * cmds.c (internal_self_insert):
7952 * callint.c (Fcall_interactively):
7953 * buffer.c (Fkill_all_local_variables):
7954 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7955 Use Frun_hooks.
0f4a96b5 7956 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7957 unconditionally since it does the check itself.
dee091a3 7958
2c520ab5 79592011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7960
c9c49752
PE
7961 Fix more problems found by GCC 4.5.2's static checks.
7962
8abc3f12
PE
7963 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7964 the first time through the loop, since we know p0 < p1 then.
7965 This also avoids a gcc -Wstrict-overflow warning.
7966
a2d26660
PE
7967 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7968 leading to a memory leak, possible in functions like
7969 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7970 of objects (Bug#8318).
a2d26660 7971
916c72e9
PE
7972 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7973 that could (at least in theory) be that large.
7974
19ab8a18
PE
7975 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7976 This is less likely to overflow, and avoids undefined behavior if
7977 overflow does occur. All callers changed. Use strtoul to scan
7978 for the unsigned long integer.
b7cbbd6f
PE
7979 (pint2hrstr): Simplify and tune code slightly.
7980 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7981
f0641eff
PE
7982 * scroll.c (do_scrolling): Work around GCC bug 48228.
7983 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7984
7f650bb9
PE
7985 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7986 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7987 (validate_x_resource_name): Simplify count usage.
7988 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7989
37dd57d1
PE
7990 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7991 fail (Bug#8306).
81e56e61 7992
699979fc 7993 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7994
401bf9b4
PE
7995 * process.c (Fmake_network_process): Use socklen_t, not int,
7996 where POSIX says socklen_t is required in portable programs.
7997 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7998 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7999 (Fmake_network_process, server_accept_connection):
8000 (wait_reading_process_output, read_process_output):
8001 Likewise.
8002
b93aacde
PE
8003 * process.c: Rename or move locals to avoid shadowing.
8004 (list_processes_1, Fmake_network_process):
8005 (read_process_output_error_handler, exec_sentinel_error_handler):
8006 Rename or move locals.
4dc343ee 8007 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8008 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8009 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8010 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8011 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8012
af8a867c 8013 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8014 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8015 Include tparam.h instead, since it declares them.
af8a867c
PE
8016 * cm.h (PC): Remove extern decl; tparam.h now does this.
8017 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8018 * terminfo.c: Include tparam.h, to check interfaces.
8019 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8020 (tparam): Adjust signature to match interface in tparam.h;
8021 this removes some undefined behavior. Check that outstring and len
8022 are zero, which they always are with Emacs.
8023 * tparam.h (PC, BC, UP): New extern decls.
8024
0248044d 8025 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8026 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8027
8ff096c1 8028 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8029 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8030 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8031 (ftfont_list): Remove unused local.
49eaafba
PE
8032 (get_adstyle_property, ftfont_pattern_entity):
8033 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8034 Rename locals to avoid shadowing.
8ff096c1 8035
e2be39f6
PE
8036 * xfont.c (xfont_list_family): Mark var as initialized.
8037
c9735e30
PE
8038 * xml.c (make_dom): Now static.
8039
8f5201ae
PE
8040 * composite.c (composition_compute_stop_pos): Rename local to
8041 avoid shadowing.
b246f932
PE
8042 (composition_reseat_it): Remove unused locals.
8043 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8044 (composition_update_it): Mark var as initialized.
11b61122
PE
8045 (find_automatic_composition): Mark vars as initialized,
8046 with a FIXME (Bug#8290).
8f5201ae 8047
760fbc2c
PE
8048 character.h: Rename locals to avoid shadowing.
8049 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8050 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8051 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8052 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8053 to avoid shadowing.
8054
ff08eb85
PE
8055 * textprop.c (property_change_between_p): Remove; unused.
8056
fc7bf025
PE
8057 * intervals.c (interval_start_pos): Now static.
8058
235d7abc
PE
8059 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8060
44f230aa
SM
8061 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8062 Rename locals to avoid shadowing.
3e7d6594 8063
50060332
PE
8064 * sound.c (wav_play, au_play, Fplay_sound_internal):
8065 Fix pointer signedness.
d01f234b 8066 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8067 (wav_play): Initialize a variable to 0, to prevent undefined
8068 behavior (Bug#8278).
50060332 8069
c4fc4e30
PE
8070 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8071
918436ed
PE
8072 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8073
c939f91b
PE
8074 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8075 clobbering (Bug#8298).
b9c7f648
PE
8076 * sysdep.c (sys_subshell): Likewise.
8077 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8078
6bd8c144
PE
8079 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8080 This should get cleaned up, so that child_setup has the
8081 same signature on all platforms.
8082
7710357c 8083 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8084 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8085
c59da222
CY
80862011-03-22 Chong Yidong <cyd@stupidchicken.com>
8087
8088 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8089 not to be necessary, and produces flickering.
8090
66b87493
GM
80912011-03-20 Glenn Morris <rgm@gnu.org>
8092
8093 * config.in: Remove file.
8094
45b6f6d5
JB
80952011-03-20 Juanma Barranquero <lekktu@gmail.com>
8096
8097 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8098 are now in src/globals.h.
8099 (syms_of_minibuf): Remove spurious & from previous change.
8100
3ec03f7e
LL
81012011-03-20 Leo <sdl.web@gmail.com>
8102
8103 * minibuf.c (completing-read-function): New variable.
8104 (completing-read-default): Rename from completing-read.
8105 (completing-read): Call completing-read-function.
8106
b14e3e21
CY
81072011-03-19 Juanma Barranquero <lekktu@gmail.com>
8108
8109 * xfaces.c (Fx_load_color_file):
8110 Read color file from absolute filename (bug#8250).
8111
f2b726e6
JB
81122011-03-19 Juanma Barranquero <lekktu@gmail.com>
8113
8114 * makefile.w32-in: Update dependencies.
8115
09f6ff02
EZ
81162011-03-17 Eli Zaretskii <eliz@gnu.org>
8117
8118 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8119
29a6015a
PE
81202011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8121
a3a6c54e
PE
8122 Fix more problems found by GCC 4.5.2's static checks.
8123
b766f867
PE
8124 * process.c (make_serial_process_unwind, send_process_trap):
8125 (sigchld_handler): Now static.
8126
be02381c
PE
8127 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8128 That way, the code declares only the vars that it needs.
8129 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8130 * s/cygwin.h (PTY_ITERATION): Likewise.
8131 * s/darwin.h (PTY_ITERATION): Likewise.
8132 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8133
57048744
PE
8134 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8135 * process.c (allocate_pty): Don't declare stb unless it's needed.
8136
7914961c 8137 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8138 (CONSTANTLIM): Remove; unused.
8139 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8140 Define only if needed.
7914961c 8141
b3967b18
PE
8142 * unexelf.c (unexec): Name an expression,
8143 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8144 Use a different way to cause a compilation error if anyone uses
8145 n rather than nn, a way that does not involve shadowing.
73366a00 8146 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8147
29a6015a
PE
8148 * deps.mk (unexalpha.o): Remove; unused.
8149
43cfc33e 8150 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8151 * unexec.h: New file.
ce701a33
PE
8152 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8153 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8154 Depend on unexec.h.
8155 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8156 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8157 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8158 Change as necessary to match prototype in unexec.h.
ce701a33 8159
01f44d5a
PE
8160 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8161 shadowing.
4f63c6bb 8162 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8163
a6670b0b
PE
8164 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8165 Rename locals to avoid shadowing.
8166
cef2010d 8167 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8168 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8169
d4d7173a
PE
8170 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8171
f08b802a
PE
8172 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8173 warning when compiling print.c.
8174
3ddb0639
PE
8175 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8176 instead of using an uninitialized var.
5ad03b97 8177 (font_sort_entities): Mark var as initialized.
3ddb0639 8178
170a2692
PE
8179 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8180
e663c700
PE
8181 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8182 pointers to constants.
89bc529a 8183 (font_parse_fcname): Remove unused vars.
7b81e2d0 8184 (font_delete_unmatched): Now static.
ea838e10 8185 (font_get_spec): Remove; unused.
13a547c6
PE
8186 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8187 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8188 Rename or move locals to avoid shadowing.
e663c700 8189
2a80c887 8190 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8191 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8192
1384fa33 8193 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8194 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8195
8b2c52e9
PE
8196 * alloc.c (mark_backtrace): Move decl from here ...
8197 * lisp.h: ... to here, so that it can be checked.
8198
475545b5 8199 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8200 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8201 (lisp_indirect_variable): Name an expression,
8202 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8203 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8204
b1349114 8205 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8206 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8207 Use const pointer when appropriate.
b1349114 8208
a2928364
PE
8209 * lisp.h (get_system_name, get_operating_system_release):
8210 Move decls here, to check interfaces.
8211 * process.c (get_operating_system_release): Move decl to lisp.h.
8212 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8213 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8214 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8215 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8216 (Fformat_time_string, Fencode_time, Finsert_char):
8217 (Ftranslate_region_internal, Fformat):
8218 Rename or remove local vars to avoid shadowing.
9710023e 8219 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8220
a415e694
PE
8221 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8222 avoid shadowing.
8223
8ef4622d
PE
8224 * lisp.h (eassert): Check that the argument compiles, even if
8225 ENABLE_CHECKING is not defined.
8226
946f9a5b
PE
8227 * data.c (Findirect_variable): Name an expression, to avoid
8228 gcc -Wbad-function-cast warning.
112396d6 8229 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8230 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8231 (Fmake_variable_buffer_local, Fmake_local_variable):
8232 Mark variables as initialized.
52746918 8233 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8234
e5aab7e7 8235 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8236 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8237 Rename locals to avoid shadowing.
dff45157
PE
8238 (mark_stack): Move local variables into the #ifdef region where
8239 they're used.
7bc26fdb
PE
8240 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8241 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8242 needed otherwise.
8243 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8244 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8245 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8246
e5aab7e7
PE
8247 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8248 avoids undefined behavior in theory.
8249
4da60324
PE
8250 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8251
88043301
PE
8252 Use functions, not macros, for up- and down-casing (Bug#8254).
8253 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8254 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8255 to use the following functions instead of these macros.
8256 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8257 EMACS_INT, since callers assume the returned value fits in int.
8258 (upcase1): Likewise, for UPCASE_TABLE.
8259 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8260 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8261 the race-condition problem in the old DOWNCASE.
88043301 8262
19ed5445
PE
8263 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8264 Rename locals to avoid shadowing.
8265 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8266 (regex_compile, re_search_2, re_match_2_internal):
8267 Remove unused local vars.
952db0d7
PE
8268 (FREE_VAR): Rewrite so as not to use empty "else",
8269 which gcc can warn about.
da053e48 8270 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8271 (RETALLOC_IF): Define only if needed.
8272 (WORDCHAR_P): Likewise. This one is never needed, but is used
8273 only in a comment talking about a compiler bug, so put inside
8274 the #if 0 of that comment.
8275 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8276 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8277 Remove; unused.
19ed5445 8278
1f3561e4 8279 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8280 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8281 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8282
ded6f8f7
PE
8283 * search.c (simple_search): Remove unused var.
8284
dbd37a95
PE
8285 * dired.c (compile_pattern): Move decl from here ...
8286 * lisp.h: ... to here, so that it can be checked.
8287 (struct re_registers): New forward decl.
8288
7e47afad
PE
8289 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8290
85f24f61
PE
8291 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8292 All uses changed.
8293 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8294 Rename locals to avoid shadowing.
5671df8f 8295 (Fvertical_motion): Mark locals as initialized.
85f24f61 8296
181aa2be 8297 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8298 (casify_region): Mark local as initialized.
181aa2be 8299
930d429c
PE
8300 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8301
7082eac6
PE
8302 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8303 New macros, so that the caller can use some names other than
8304 gcpro1, gcpro2, etc.
8305 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8306 of the new macros.
8307 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8308 argument, for consistency with GCPRO2_VAR, etc: it is now the
8309 prefix of the variable, not the variable itself. All uses
8310 changed.
38b2c076
PE
8311 * dired.c (directory_files_internal, file_name_completion):
8312 Rename locals to avoid shadowing.
8313
15206ed9
PE
8314 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8315 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8316 dired.c's scmp function, had undefined behavior.
8317 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8318 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8319 * buffer.h: ... to here, because these macros use current_buffer,
8320 and the new implementation with inline functions needs to have
8321 current_buffer in scope now, rather than later when the macros
8322 are used.
8323 (downcase, upcase1): New static inline functions.
8324 (DOWNCASE, UPCASE1): Reimplement using these functions.
8325 This avoids undefined behavior in expressions like
8326 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8327 from race conditions in accessing the global variables
8328 case_temp1 and case_temp2.
8329 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8330 * lisp.h (case_temp1, case_temp2): Remove their decls.
8331 * character.h (ASCII_CHAR_P): Move from here ...
8332 * lisp.h: ... to here, so that the inline functions mentioned
8333 above can use them.
8334
4a6bea26
PE
8335 * dired.c (directory_files_internal_unwind): Now static.
8336
f14b7e14
PE
8337 * fileio.c (file_name_as_directory, directory_file_name):
8338 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8339 Now static.
2893f146
PE
8340 (file_name_as_directory): Use const pointers when appropriate.
8341 (Fexpand_file_name): Likewise. In particular, newdir might
8342 point at constant storage, so make it a const pointer.
fd4ead52 8343 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8344 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8345 signedness issues.
f839df0c
PE
8346 (Fset_file_times, Finsert_file_contents, auto_save_error):
8347 Rename locals to avoid shadowing.
f14b7e14 8348
5716756e 8349 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8350 (Ftry_completion, Fall_completions): Rename or remove locals
8351 to avoid shadowing.
5716756e 8352
b4c3046a
PE
8353 * marker.c (bytepos_to_charpos): Remove; unused.
8354
b45db522
PE
8355 * lisp.h (verify_bytepos, count_markers): New decls,
8356 so that gcc does not warn that these functions aren't declared.
8357
85876d07
PE
8358 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8359 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8360 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8361 (copy_text): Remove unused local var.
85876d07 8362
03d78a21 8363 * filelock.c (within_one_second): Now static.
b3dd38ab 8364 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8365
5df8f01b
PE
8366 * buffer.c (fix_overlays_before): Mark locals as initialized.
8367 (fix_start_end_in_overlays): Likewise. This function should be
8368 simplified by using pointers-to-pointers, but that's a different
8369 matter.
b1d876f1 8370 (switch_to_buffer_1): Now static.
8f54f30a
PE
8371 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8372 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8373
a70072c9 8374 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8375 Fix pointer signedness issue.
edced198
PE
8376 (sys_subshell): Mark local as volatile if checking for lint,
8377 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8378 (MAXPATHLEN): Define only if needed.
a70072c9 8379
a0977c44
PE
8380 * process.c (serial_open, serial_configure): Move decls from here ...
8381 * systty.h: ... to here, so that they can be checked.
8382
a884fdcc
PE
8383 * fns.c (get_random, seed_random): Move extern decls from here ...
8384 * lisp.h: ... to here, so that they can be checked.
8385
604efe86 8386 * sysdep.c (reset_io): Now static.
b8950c94 8387 (wait_for_termination_signal): Remove; unused.
604efe86 8388
38fc62d9
PE
8389 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8390 (copy_keymap_item, append_key, push_text_char_description):
8391 Now static.
1004a21a 8392 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8393 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8394 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8395 (describe_map_tree):
8396 Rename locals to avoid shadowing.
38fc62d9 8397
2f2650da
PE
8398 * keyboard.c: Declare functions static if they are not used elsewhere.
8399 (echo_char, echo_dash, cmd_error, top_level_2):
8400 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8401 (read_char, kbd_buffer_get_event, make_lispy_position):
8402 (make_lispy_event, make_lispy_movement, apply_modifiers):
8403 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8404 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8405 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8406 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8407 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8408
a053e86c 8409 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8410 (mark_kboards): Move decl here ...
8411 * alloc.c (mark_kboards): ... from here.
a053e86c 8412
4752793e
PE
8413 * lisp.h (force_auto_save_soon): New decl.
8414
74f10ca7 8415 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8416 (DEFINE_DUMMY_FUNCTION): New macro.
8417 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8418 Use it.
c03cd23f
PE
8419 (main): Add casts to avoid warnings
8420 if GCC considers string literals to be constants.
74f10ca7 8421
022e70d4
PE
8422 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8423
59d6fe83
PE
8424 * dbusbind.c: Pointer signedness fixes.
8425 (xd_signature, xd_append_arg, xd_initialize):
8426 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8427 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8428 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8429 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8430
78320123
PE
8431 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8432 if GCC considers string literals to be constants.
49cebcca 8433 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8434
35ac2a97
SM
84352011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8436
fb103ca9
SM
8437 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8438 (print_preprocess, print_object): New macro to fix last change.
8439
35ac2a97
SM
8440 * print.c (print_preprocess): Don't forget font objects.
8441
62973b41
JB
84422011-03-16 Juanma Barranquero <lekktu@gmail.com>
8443
8444 * emacs.c (USAGE3): Doc fixes.
8445
0e48bb22
AS
84462011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8447
8448 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8449 structure.
8450
7684e57b
JB
84512011-03-14 Juanma Barranquero <lekktu@gmail.com>
8452
8453 * lisp.h (VWindow_system, Qfile_name_history):
8454 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8455 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8456 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8457
8458 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8459 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8460
8461 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8462 * w32console.c (detect_input_pending, read_input_pending)
8463 (encode_terminal_code):
8464 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8465 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8466 (w32_system_caret_y, Qfile_name_history):
8467 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8468 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8469 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8470 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8471 * w32proc.c (Qlocal, report_file_error):
8472 * w32term.c (Vwindow_system, updating_frame):
8473 * w32uniscribe.c (initialized, uniscribe_font_driver):
8474 Remove unneeded extern declarations.
8475
2aa46d6c
CY
84762011-03-14 Chong Yidong <cyd@stupidchicken.com>
8477
c96bbc66 8478 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8479
cffc6f3b
CY
84802011-03-13 Chong Yidong <cyd@stupidchicken.com>
8481
8482 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8483 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8484 These macros can no longer be used for assignment.
8485
44f230aa
SM
8486 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8487 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8488 (record_buffer_markers, fetch_buffer_markers): New functions for
8489 recording and fetching special buffer markers.
8490 (set_buffer_internal_1, set_buffer_temp): Use them.
8491
8492 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8493
8494 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8495
8496 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8497 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8498
8499 * xdisp.c (hscroll_window_tree):
8500 (reconsider_clip_changes): Use PT instead of BUF_PT.
8501
d251f04b
EZ
85022011-03-13 Eli Zaretskii <eliz@gnu.org>
8503
8504 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8505 $(EMACS_ROOT)/lib/intprops.h.
8506
f0c77cd1
PE
85072011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8508
3eca4629
PE
8509 Fix more problems found by GCC 4.5.2's static checks.
8510
7c86ee98
PE
8511 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8512 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8513 (xg_free_frame_widgets): Make it clear that a local variable is
8514 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8515 (gdk_window_get_screen): Make it clear that this macro is needed
8516 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8517 (int_gtk_range_get_value): New function, which avoids a diagnostic
8518 from gcc -Wbad-function-cast.
8519 (xg_set_toolkit_scroll_bar_thumb): Use it.
8520 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8521 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8522 (get_utf8_string, xg_get_file_with_chooser):
8523 Rename locals to avoid shadowing.
8524 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8525
41729b81
PE
8526 * xgselect.c (xg_select): Remove unused var.
8527
f0c77cd1
PE
8528 * image.c (four_corners_best): Mark locals as initialized.
8529 (gif_load): Initialize transparent_p to zero (Bug#8238).
8530 Mark another local as initialized.
ec6cf4c6 8531 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8532
ce0ad53d 8533 * image.c (clear_image_cache): Now static.
d5d5a617 8534 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8535 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8536 (x_edge_detection): Remove unnecessary cast that
8537 gcc -Wbad-function-cast diagnoses.
2037898d 8538 (gif_load): Fix pointer signedness.
6ae141d6
PE
8539 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8540 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8541
33383987 85422011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8543
d32df629
PE
8544 Improve quality of tests for time stamp overflow.
8545 For example, without this patch (encode-time 0 0 0 1 1
8546 1152921504606846976) returns the obviously-bogus value (-948597
8547 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8548 reports time overflow. See
8549 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8550 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8551 * editfns.c: Include limits.h and intprops.h.
8552 (TIME_T_MIN, TIME_T_MAX): New macros.
8553 (time_overflow): Move earlier, to before first use.
8554 (hi_time, lo_time): New functions, for an accurate test for
8555 out-of-range times.
8556 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8557 (Fget_internal_run_time): Don't assume time_t fits in int.
8558 (make_time): Use list2 instead of Fcons twice.
8559 (Fdecode_time): More accurate test for out-of-range times.
8560 (check_tm_member): New function.
8561 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8562 (lisp_time_argument): Don't rely on undefined left-shift and
8563 right-shift behavior when checking for time stamp overflow.
8be6f318 8564
fe31d94c
PE
8565 * editfns.c (time_overflow): New function, refactoring common code.
8566 (Fformat_time_string, Fdecode_time, Fencode_time):
8567 (Fcurrent_time_string): Use it.
8568
8be6f318
PE
8569 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8570 * dired.c (make_time): Move to ...
8571 * editfns.c (make_time): ... here.
8572 * systime.h: Note the move.
8573
09d9db2c 85742011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8575
126bc0dc
YM
8576 * fringe.c (update_window_fringes): Remove unused variables.
8577
c47cbdfd
YM
8578 * unexmacosx.c (copy_data_segment): Also copy __got section.
8579 (Bug#8223)
8580
7ac80be9
EZ
85812011-03-12 Eli Zaretskii <eliz@gnu.org>
8582
c96bbc66 8583 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8584 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8585 Constify `char *' arguments and their references according to
8586 prototypes in tparam.h.
8587
ecb0f94d 8588 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8589
7ac80be9
EZ
8590 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8591 Adapt all references accordingly.
8592
8593 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8594
ef1fd07e
TT
85952011-03-11 Tom Tromey <tromey@redhat.com>
8596
8597 * buffer.c (syms_of_buffer): Remove obsolete comment.
8598
7ef4b50c
EZ
85992011-03-11 Eli Zaretskii <eliz@gnu.org>
8600
8601 * termhooks.h (encode_terminal_code): Declare prototype.
8602
8603 * msdos.c (encode_terminal_code): Don't declare prototype.
8604
8605 * term.c (encode_terminal_code): Now external again, used by
8606 w32console.c and msdos.c.
8607
44f230aa
SM
8608 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8609 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8610
4b1ec863 86112011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8612
1714f52b 8613 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8614
4b1ec863
PE
8615 * fringe.c (update_window_fringes): Mark locals as initialized
8616 (Bug#8227).
8617 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8618
524c7aa6
PE
8619 * alloc.c (mark_fringe_data): Move decl from here ...
8620 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8621 to check its interface.
8622 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8623
a5c0af81 8624 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8625 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8626 (fontset_font): Mark local as initialized.
a9a06e0b 8627 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8628
b4716021
PE
8629 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8630
811e9bac 8631 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8632 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8633 (x_own_selection, Fx_disown_selection_internal): Rename locals
8634 to avoid shadowing.
8635 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8636
7e3ab302
PE
8637 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8638 so that the caller can use some name other than gcpro1.
8639 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8640 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8641 (Fx_backspace_delete_keys_p):
8642 Use them to avoid shadowing, and rename vars to avoid shadowing.
8643 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8644 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8645 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8646 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8647 Remove unused locals.
7e3ab302
PE
8648 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8649 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8650 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8651 macros.
f78faa98 8652
e2b13473
PE
8653 * xterm.h (x_mouse_leave): New decl.
8654
77f23912
PE
8655 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8656 Remove unused functions.
cdf4ba58
PE
8657 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8658 (x_calc_absolute_position): Now static.
7411c686 8659 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8660 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8661 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8662 unless they are used.
38d0b34a
PE
8663 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8664 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8665 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8666 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8667 (x_error_catcher, x_connection_closed, x_error_handler):
8668 (x_error_quitter, xembed_send_message, x_iconify_frame):
8669 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8670 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8671 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8672
44f230aa
SM
8673 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8674 Rename or move locals to avoid shadowing.
6b463e58 8675 (tty_defined_color, merge_face_heights): Now static.
5967d051 8676 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8677 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8678 does not deduce is never used uninitialized.
73719eba
PE
8679 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8680 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8681
426994c3 8682 * terminal.c (store_terminal_param): Now static.
5489860b 8683
032f1620 8684 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8685 (set_frame_menubar): Remove unused local.
d4323972 8686 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8687 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8688 since they might point to immutable storage.
281585b0
PE
8689 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8690 since it's unused otherwise.
032f1620 8691
367c19e5 8692 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8693 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8694 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8695 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8696 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8697 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8698 does not deduce are never used uninitialized.
70739cbe 8699
07b48fa9
PE
8700 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8701
8868a238 8702 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8703 * window.c (window_loop, size_window):
8704 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8705
7e5cf297 8706 * window.c (display_buffer): Now static.
d6550a9f
PE
8707 (size_window): Mark variables that gcc -Wuninitialized
8708 does not deduce are never used uninitialized.
a586633d
PE
8709 * window.h (check_all_windows): New decl, to forestall
8710 gcc -Wmissing-prototypes diagnostic.
5b555da1 8711 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8712
f6095868
PE
8713 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8714 shadowing.
8715 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8716 Include <limits.h>.
8717 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8718 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8719 (load_charset_map): Mark variables that gcc -Wuninitialized
8720 does not deduce are never used uninitialized.
53df7c11 8721 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8722
f38b440c
PE
8723 * coding.c (coding_set_source, coding_set_destination):
8724 Use "else { /* comment */ }" rather than "else /* comment */;"
8725 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8726 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8727 a block, when the outer 'i' will do.
8728 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8729 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8730 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8731 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8732 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8733 Rename locals to avoid shadowing.
8734 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8735 * coding.c (emacs_mule_char, encode_invocation_designation):
8736 Now static, since they're not used elsewhere.
413bb2db 8737 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8738 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8739 (decode_coding_emacs_mule): Mark variables that gcc
8740 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8741 (detect_coding_iso_2022): Initialize a local variable that might
8742 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8743 this initialization is needed. (Bug#8211)
5f58e762
PE
8744 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8745 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8746 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8747 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8748 Remove unused macros.
f38b440c 8749
232b38b9 8750 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8751 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8752 * character.c (string_count_byte8): Likewise.
232b38b9 8753
fb90da1b
PE
8754 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8755 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8756
fb93dbc2
PE
8757 * chartab.c (copy_sub_char_table): Now static, since it's not used
8758 elsewhere.
5c156ace
PE
8759 (sub_char_table_ref_and_range, char_table_ref_and_range):
8760 Rename locals to avoid shadowing.
bbcd0949 8761 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8762
7d3b3862 8763 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8764 (BIDI_BOB): Remove unused macro.
7d3b3862 8765
6be7d3da
PE
8766 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8767 deduce are never used uninitialized.
c2ed9c8b 8768 * term.c (encode_terminal_code): Likewise.
6be7d3da 8769
75f8807f 8770 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8771
50938595
PE
8772 * tparam.h: New file.
8773 * term.c, tparam.h: Include it.
8774 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8775 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8776 Move these decls to tparam.h, and make them agree with what
8777 is actually in tparam.c. The previous trick of using incompatible
8778 decls in different modules does not conform to the C standard.
8779 All callers of tparam changed to use tparam's actual API.
8780 * tparam.c (tparam1, tparam, tgoto):
8781 Use const pointers where appropriate.
8782
fbceeba2
PE
8783 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8784 * cm.h (struct cm): Likewise.
8785 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8786 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8787 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8788 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8789 (turn_on_face, init_tty): Likewise.
8790 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8791
7f3f1250
PE
8792 * term.c (term_mouse_position): Rename local to avoid shadowing.
8793
e6ca6543
PE
8794 * alloc.c (mark_ttys): Move decl from here ...
8795 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8796
c40f8d15
AS
87972011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8798
8799 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8800
cfe0661d
JB
88012011-03-09 Juanma Barranquero <lekktu@gmail.com>
8802
8803 * search.c (compile_pattern_1): Remove argument regp, unused since
8804 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8805 (compile_pattern): Don't pass it.
8806
0afb4571
J
88072011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8808
8809 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8810 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8811 for ! HAVE_GTK3.
8812 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8813
8814 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8815
8816 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8817 gdk_window_get_screen, gdk_window_get_geometry,
8818 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8819 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8820 (xg_get_pixbuf_from_pixmap): New function.
8821 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8822 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8823 Call xg_get_pixbuf_from_pixmap instead of
8824 gdk_pixbuf_get_from_drawable.
8825 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8826 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8827 (xg_check_special_colors): Use GtkStyleContext and its functions
8828 for HAVE_GTK3.
8829 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8830 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8831 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8832 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8833 Call gtk_widget_get_preferred_size.
0afb4571
J
8834 (xg_frame_resized): gdk_window_get_geometry only takes 5
8835 parameters.
44f230aa
SM
8836 (xg_win_to_widget, xg_event_is_for_menubar):
8837 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8838 (xg_set_widget_bg): New function.
8839 (delete_cb): New function.
895009e1 8840 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8841 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8842 (xg_set_background_color): Call xg_set_widget_bg.
8843 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8844 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8845 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8846 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8847 if ! HAVE_GTK3.
8848 (update_frame_tool_bar): Call gtk_widget_hide.
8849 (xg_initialize): Use GDK_KEY_g.
8850
8851 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8852 if ! HAVE_GTK3
8853 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8854
8855 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8856 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8857 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8858
1c2cc4ef
JB
88592011-03-08 Juanma Barranquero <lekktu@gmail.com>
8860
8861 * w32xfns.c (select_palette): Check success of RealizePalette against
8862 GDI_ERROR, not zero.
8863
33383987 8864See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8865
8866;; Local Variables:
8867;; coding: utf-8
aac0c6e3
MR
8868;; End:
8869
33383987 8870 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8871
8872 This file is part of GNU Emacs.
8873
8874 GNU Emacs is free software: you can redistribute it and/or modify
8875 it under the terms of the GNU General Public License as published by
8876 the Free Software Foundation, either version 3 of the License, or
8877 (at your option) any later version.
8878
8879 GNU Emacs is distributed in the hope that it will be useful,
8880 but WITHOUT ANY WARRANTY; without even the implied warranty of
8881 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8882 GNU General Public License for more details.
8883
8884 You should have received a copy of the GNU General Public License
8885 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.