Fix definition of `mode_t'.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a06776b2
EZ
12011-11-05 Eli Zaretskii <eliz@gnu.org>
2
3ad924ba
EZ
3 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4 "emacs"-only part.
5
a06776b2
EZ
6 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7 initialization code to keep similarity to xfns.c after changes
8 from 2011-11-05.
9
c9e7db78
JD
102011-11-05 Jan Djärv <jan.h.d@swipnet.se>
11
a97f8f3f
JD
12 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
13 (unwind_create_frame): New function (Bug#9943).
14 (Fx_create_frame): Restructure code to be more similar to the one in
15 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
16 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
17 Move terminal->reference_count++ just before making the frame official
18 (Bug#9943).
19
20 * nsterm.m (x_free_frame_resources): New function.
21 (x_destroy_window): Move code to x_free_frame_resources.
22
c9e7db78
JD
23 * xfns.c (unwind_create_frame): Fix comment.
24 (Fx_create_frame, x_create_tip_frame): Move
25 terminal->reference_count++ just before making the frame
26 official. Move initialization of image_cache_refcount and
27 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
28
a6fc3b5c
EZ
292011-11-05 Eli Zaretskii <eliz@gnu.org>
30
31 Support MSVC build with newer versions of Visual Studio.
32 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
33 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
34 nt/gmake.defs.
35
36 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
37 which are not supported by MSVC.
38 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
39 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
40 bitfields.
41 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
42 types in bitfields.
43 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
44
45 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
46
472011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
48
49 Support MSVC build with newer versions of Visual Studio.
50 * w32.c: Don't include w32api.h for MSVC.
51 (init_environment) [_MSC_VER]: Call sys_access, not _access.
52
53 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
54 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
55 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
56 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
57 e_* cousins.
58 (alloca) [_MSC_VER]: Define to _alloca.
59
60 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
61
62 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
63
a58c13ed
EZ
642011-11-04 Eli Zaretskii <eliz@gnu.org>
65
66 * xdisp.c (note_mouse_highlight): If either of
67 previous/next-single-property-change returns nil, treat that as
68 the beginning or the end of the buffer. (Bug#9955)
69
fe0b6370
JD
702011-11-04 Jan Djärv <jan.h.d@swipnet.se>
71
a58c13ed 72 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
73 label is not null (Bug#9951).
74 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
75 may be NULL.
76
89bd5ee1
EZ
772011-11-04 Eli Zaretskii <eliz@gnu.org>
78
79 * window.c (Fwindow_body_size): Mention in the doc string that the
80 return value is in frame's canonical units. (Bug#9949)
81
84c3edb9
EZ
822011-11-03 Eli Zaretskii <eliz@gnu.org>
83
4e2fb5c7
EZ
84 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
85
84c3edb9 86 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 87 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 88 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 89
bc17a887
EZ
902011-11-01 Eli Zaretskii <eliz@gnu.org>
91
92 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
93 Don't stop backward scan on the continuation glyph, even though
94 its CHARPOS is positive.
26b46e51
EZ
95 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
96 cover_string to disp_string.
bc17a887 97
4ee88440
MR
982011-11-01 Martin Rudalics <rudalics@gmx.at>
99
100 * window.c (temp_output_buffer_show): Don't use
101 Vtemp_buffer_show_specifiers.
102 (Vtemp_buffer_show_specifiers): Remove unused variable.
103
c2ff3c02
EZ
1042011-10-30 Eli Zaretskii <eliz@gnu.org>
105
106 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
107 past the beginning of the current glyph matrix.
108
6e56383b
JD
1092011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
110
111 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
112 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
113 HAVE_GTK3 (Bug#9869).
b77a6a7f 114
3b574623
JD
115 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
116 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
117
b77a6a7f
JD
118 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
119
120 * xterm.c: Declare x_handle_net_wm_state to return int.
121 (handle_one_xevent): Check if we are iconified but don't have
122 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
123 (get_current_wm_state): Return non-zero if not hidden,
124 check for _NET_WM_STATE_HIDDEN (Bug#9893).
125 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
126 (x_handle_net_wm_state): Return what get_current_wm_state returns.
127 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
128
196e41e4
PE
1292011-10-29 Paul Eggert <eggert@cs.ucla.edu>
130
131 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
132 so that this new function doesn't get optimized away by a
133 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
134
021f2e1a
AS
1352011-10-29 Andreas Schwab <schwab@linux-m68k.org>
136
137 * frame.h (MOUSE_HL_INFO): Remove excess parens.
138
8b058d44
EZ
1392011-10-29 Eli Zaretskii <eliz@gnu.org>
140
141 Fix the `xbytecode' command.
142 * .gdbinit (xprintbytestr): New command.
143 (xwhichsymbols): Renamed from `which'; all callers changed.
144 (xbytecode): Print the byte-code string as well.
145
4452fb80
EZ
1462011-10-29 Kim Storm <storm@cua.dk>
147
8b058d44
EZ
148 * alloc.c (which_symbols): New function.
149
21b72067
AS
1502011-10-29 Andreas Schwab <schwab@linux-m68k.org>
151
152 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
153 line. (Bug#9903)
154
83ed7b5c
GM
1552011-10-29 Glenn Morris <rgm@gnu.org>
156
157 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
158 Not clear what it was for, and it causes various bugs. (Bug#9839)
159
5a7a728b
EZ
1602011-10-28 Eli Zaretskii <eliz@gnu.org>
161
162 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
163 possible random value that matches one of those tested as
164 condition to clear the mouse face.
165
d3d0842f
CY
1662011-10-28 Chong Yidong <cyd@gnu.org>
167
168 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
169
31b39d13
DN
1702011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
171
172 * window.c (make_window): Initialize phys_cursor_on_p.
173
9aba6043
SM
1742011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
175
176 * lisp.h (struct Lisp_Symbol): Update comments.
177
c20992f4
JB
1782011-10-28 Juanma Barranquero <lekktu@gmail.com>
179
180 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
181
db4f02f2
EZ
1822011-10-28 Eli Zaretskii <eliz@gnu.org>
183
184 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
185 <oslsachem@gmail.com> for helping to debug this.
186
187 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
188 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
189 (g_b_init_get_glyph_outline_w): New static variables.
190 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
191 (GetGlyphOutlineW_Proc): New typedefs.
192 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
193 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
194 New functions.
195 (w32font_open_internal, compute_metrics):
196 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
197 instead of calling the "wide" APIs directly.
198
199 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
200
201 * w32.h (syms_of_w32font): Add prototype.
202
87e68db4
JB
2032011-10-27 Juanma Barranquero <lekktu@gmail.com>
204
205 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
206 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
207 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
208 (Fmove_to_window_line): Doc fix.
209
435c1d67
CY
2102011-10-27 Chong Yidong <cyd@gnu.org>
211
212 * process.c (make_process): Set gnutls_state to NULL.
213
214 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
215 non-NULL, regardless of GNUTLS_INITSTAGE.
216 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
217 an error. Set process slots as soon as we allocate them.
218
219 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
220
9c6c6f49
CY
2212011-10-27 Chong Yidong <cyd@gnu.org>
222
9aba6043
SM
223 * gnutls.c (emacs_gnutls_deinit): New function.
224 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
225 (Fgnutls_deinit, Fgnutls_boot): Use it.
226
227 * process.c (make_process): Initialize GnuTLS credentials to NULL.
228 (deactivate_process): Call emacs_gnutls_deinit.
229
657d08d3
JB
2302011-10-27 Juanma Barranquero <lekktu@gmail.com>
231
232 * image.c (x_create_x_image_and_pixmap):
233 * w32.c (sys_rename, w32_delayed_load):
234 * w32font.c (fill_in_logfont):
235 * w32reg.c (x_get_string_resource): Silence compiler warnings.
236
5430d399
JB
2372011-10-26 Juanma Barranquero <lekktu@gmail.com>
238
239 * w32fns.c (w32_default_color_map): New function,
240 extracted from Fw32_default_color_map.
a7ef684b 241 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 242
fe0055fa
PE
2432011-10-25 Paul Eggert <eggert@cs.ucla.edu>
244
245 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
246
e6346438
SM
2472011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
248
249 * keyboard.c (test_undefined): New function (bug#9751).
250 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
251
e112cc37
ET
2522011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
253
254 * sysdep.c (init_sys_modes): Fix the check for the controlling
255 terminal (Bug#6649).
256
7b5d6677
EZ
2572011-10-20 Eli Zaretskii <eliz@gnu.org>
258
259 * dispextern.h (struct bidi_it): New member next_en_type.
260
261 * bidi.c (bidi_line_init): Initialize the next_en_type member.
262 (bidi_resolve_explicit_1): When next_en_pos is valid for the
263 current character, check also for next_en_type being WEAK_EN.
264 (bidi_resolve_weak): Don't enter the expensive loop if the current
265 position is before next_en_pos. Record the bidi type of the first
266 non-ET, non-BN character we find, in addition to its position.
267 (bidi_level_of_next_char): Invalidate next_en_type when
268 next_en_pos is over-stepped.
269
7da0b018
PE
2702011-10-20 Paul Eggert <eggert@cs.ucla.edu>
271
272 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
273 * editfns.c: Rewrite current-time-zone so that it invokes
274 the equivalent of (format-time-string "%Z") to get the time zone name.
275 This fixes a bug when the time zone name contains characters that
276 need converting from the system time locale to Emacs internal format.
277 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
278 that patch fixed format-time-string to do the conversion, but
279 I forgot to fix current-time-zone.
280 (format_time_string): New function, containing most of
281 what Fformat_time_string used to contain.
282 (Fformat_time_string): Rewrite in terms of format_time_string.
283 This doesn't change this function's behavior.
284 (current-time-zone): Rewrite to use format_time_string.
285 This fixes the bug reported by Michael Schierl in
286 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
287 Jason Rumney's 2007-06-07 change worked around this bug, but
288 didn't fix it.
289 * systime.h (tzname, timezone): Remove no-longer-used declarations.
290
8547b010
EZ
2912011-10-19 Eli Zaretskii <eliz@gnu.org>
292
293 * xdisp.c (start_display): If the character at POS is displayed
294 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
295 (try_window_reusing_current_matrix): If a line ends in a display
296 vector or the next line starts in a display vector, continue
297 redrawing the window even though the character position of
298 start_row was reached.
8547b010
EZ
299 (Bug#9771, part 2)
300
4e948d15
CY
3012011-10-18 Chong Yidong <cyd@gnu.org>
302
303 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
304 with nobreak-char-display too.
305
4787455f
EZ
3062011-10-18 Eli Zaretskii <eliz@gnu.org>
307
308 Fix part 3 of bug#9771.
309 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
310 (bidi_resolve_neutral): Don't enter the expensive loop looking for
311 non-neutral characters if the current character is a paragraph
312 separator (a.k.a. Newline). This avoids running the same
313 expensive loop twice, once when we consume the preceding newline
314 and the other time when the line actually needs to be displayed.
315 Avoid the loop when we see neutrals on the base embedding level
316 following a character whose directionality is the same as the
317 paragraph's. This avoids running the expensive loop when a line
318 ends in a long sequence of neutrals, like control characters.
319 Add assertion against STRONG_AL type. Slightly rearrange code
320 that determines the type of a neutral given the first non-neutral
321 that follows it.
322 (bidi_level_of_next_char): Set next_en_pos to zero when
323 invalidating its info.
324
2c91f553
EZ
3252011-10-17 Eli Zaretskii <eliz@gnu.org>
326
327 * xdisp.c (push_display_prop): Determine whether to record string
328 or buffer position by IT->string, not by IT->method. Allow
329 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
330 (move_it_vertically_backward): Don't look for character position
331 immediately after the newline when in a continuation line.
332 (Bug#9771, part 1)
2c91f553 333
c7b08b0d
MR
3342011-10-15 Martin Rudalics <rudalics@gmx.at>
335
336 * window.c (coordinates_in_window): Rewrite and delabelize
337 vertical border check. (Bug#5357) (Bug#9618)
338
6b02f655
SM
3392011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
340
341 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
342 errors in XSetWindowBorder (bug#9310).
343
81d40c92
DA
3442011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
345
346 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
347 avoid crash when xmalloc overrun checking is enabled.
348
d4172c3b
EZ
3492011-10-13 Eli Zaretskii <eliz@gnu.org>
350
351 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
352 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
353 cursor motion with <left> and <right> arrow keys.
354
355 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
356 some callers set that themselves.
357
b00eea75
EZ
3582011-10-12 Eli Zaretskii <eliz@gnu.org>
359
360 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
361 display string and the previous row comes from the same string and
362 is empty. (Bug#9739) (Bug#9738)
363
8fe012c4
SM
3642011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
365
366 * doc.c (get_doc_string): Encode file name (bug#9735).
367
0074aef2
EZ
3682011-10-12 Eli Zaretskii <eliz@gnu.org>
369
79beb178
EZ
370 * bidi.c (bidi_level_of_next_char):
371 * xdisp.c (get_visually_first_element): Remove old incorrect
372 comments regarding the Unicode Line Separator character.
373
0074aef2
EZ
374 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
375
6e4b3fbe
DA
3762011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
377
378 * alloc.c (Fgc_status): Do not access beyond zombies array
379 boundary if nzombies > MAX_ZOMBIES.
380 * alloc.c (dump_zombies): Add missing format specifier.
381
0324f3af
PE
3822011-10-12 Paul Eggert <eggert@cs.ucla.edu>
383
b5525cac
PE
384 * xdisp.c (set_cursor_from_row): Simplify conditionals,
385 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
386
0324f3af
PE
387 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
388 Some packages use them to denote characters with modifiers.
389
e9b5f888
AS
3902011-10-11 Andreas Schwab <schwab@linux-m68k.org>
391
392 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
393 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
394 matching a pp-number. Rename parameter var to var1.
395
127827c0
SM
3962011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
397
398 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
399
c8fd3bd0
GM
4002011-10-08 Glenn Morris <rgm@gnu.org>
401
402 * callint.c (Fcall_interactively): Give a more explicit error for the
403 'c' case with a non-character input. (Bug#8479)
404
352ec8ff
EZ
4052011-10-08 Eli Zaretskii <eliz@gnu.org>
406
03669ccb
EZ
407 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
408 lines.
7061c986
EZ
409 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
410 lines that are hscrolled on the left.
03669ccb 411
352ec8ff
EZ
412 * dispnew.c (buffer_posn_from_coords): Account for a possible
413 presence of header-line. (Bug#4426)
414
a66cfb1c
SM
4152011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
416
6b02f655
SM
417 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
418 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 419
7c5ee88e
PE
4202011-10-07 Paul Eggert <eggert@cs.ucla.edu>
421
422 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
423 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
424 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
425 this makes Emacs dump core during garbage collection on rare
426 occasions. sizeof is obviously inferior to offsetof here, so
427 stick with offsetof.
428 (GC_POINTER_ALIGNMENT): New macro.
429 (mark_memory): Omit 3rd (offset) arg; caller changed.
430 Don't assume EMACS_INT alignment is the same as pointer alignment.
431
df1bbe5b
SM
4322011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
433
434 * keyboard.c (read_key_sequence_remapped): New var.
435 (read_key_sequence): Compute remapping in the right buffer.
436 (command_loop_1): Use read_key_sequence's remapping directly.
437
51553db6
SM
4382011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
439
32c1fffd
SM
440 * dired.c (file_name_completion): Don't expand file name.
441 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
442 before checking file name handler.
443
51553db6
SM
444 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
445 they've been requested explicitly (bug#9591).
446
b6bd1599 4472011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
448
449 * keymap.c (Fsingle_key_description): Use make_specified_string
450 instead of build_string to build string from push_key_description.
451 (Bug#5193)
452
f701dc2a
PE
4532011-09-30 Paul Eggert <eggert@cs.ucla.edu>
454
4222c55d
PE
455 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
456 This fixes a Y2038 bug on 64-bit hosts.
457 * buffer.c (reset_buffer):
458 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
459 (Fclear_buffer_auto_save_failure):
460 Use 0, not -1, to represent an unset failure time, since time_t
461 might not be signed.
462
f701dc2a
PE
463 Remove dependency on glibc malloc internals.
464 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
465 Move back here from lisp.h, but with their new implementations.
466 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
467 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
468 * charset.c (charset_table_init): New static var.
469 (syms_of_charset): Use it instead of xmalloc. This removes a
470 dependency on glibc malloc internals. See Eli Zaretskii's comment in
471 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
472 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
473 Move back to alloc.c.
474 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
475 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
476
9ceebf39
JD
4772011-09-30 Jan Djärv <jan.h.d@swipnet.se>
478
479 * nsterm.m (windowDidResize): Call x_set_window_size only when
480 ns_in_resize is true. Otherwise set pixelwidth/height and
481 call change_frame_size (Bug#9628).
482
cb993c58
PE
4832011-09-30 Paul Eggert <eggert@cs.ucla.edu>
484
3930c88b
PE
485 Port --enable-checking=all to Fedora 14 x86-64.
486 * charset.c (syms_of_charset): Also account for glibc malloc's
487 internal overhead when calculating the initial malloc maximum.
488
cb993c58
PE
489 Port --enable-checking=all to Fedora 14 x86.
490 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
491 Move to lisp.h.
492 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
493 (overrun_check_realloc, overrun_check_free):
494 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
495 That way, xmalloc returns a properly-aligned pointer even if
496 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
497 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
498 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
499 into account when calculating the initial malloc maximum.
500 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
501 Move here from alloc.c, so that charset.c can use it too.
502 Properly align; the old code wasn't right for common 32-bit hosts
503 when configured with --enable-checking=all.
504 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
505 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
506
31bed486
EZ
5072011-09-29 Eli Zaretskii <eliz@gnu.org>
508
04c70788 509 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
510 use EDOM.
511
fbcaa2f3
EZ
5122011-09-28 Eli Zaretskii <eliz@gnu.org>
513
514 * xdisp.c (compute_display_string_end): If there's no display
515 string at CHARPOS, return -1.
516
517 * bidi.c (bidi_fetch_char): When compute_display_string_end
518 returns a negative value, treat the character as a normal
519 character not covered by a display string. (Bug#9624)
520
a239d4e9
JB
5212011-09-28 Juanma Barranquero <lekktu@gmail.com>
522
523 * lread.c (Fread_from_string): Fix typo in docstring.
524
88652fd5
EZ
5252011-09-27 Eli Zaretskii <eliz@gnu.org>
526
527 * xdisp.c (handle_invisible_prop): If invisible text ends on a
528 newline, reseat the iterator instead of bidi-iterating there one
529 character at a time. (Bug#9610)
32c1fffd
SM
530 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
531 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 532
ed497dd4
AS
5332011-09-27 Andreas Schwab <schwab@linux-m68k.org>
534
535 * lread.c (readevalloop): Use correct code for NBSP.
536 (read1): Likewise. (Bug#9608)
537
b2bf61aa
MA
5382011-09-25 Michael Albinus <michael.albinus@gmx.de>
539
540 * dbusbind.c (Fdbus_register_signal): When service is not
541 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
542
32bbb17c
GM
5432011-09-25 Glenn Morris <rgm@gnu.org>
544
545 * buffer.c (truncate-lines): Doc fix.
546
94e0933e
CY
5472011-09-24 Chong Yidong <cyd@stupidchicken.com>
548
549 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
550 (Fset_window_next_buffers): Doc fix.
551
cddde921
GM
5522011-09-24 Glenn Morris <rgm@gnu.org>
553
554 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
555
1260aef1
PE
5562011-09-24 Paul Eggert <eggert@cs.ucla.edu>
557
25b4bfa0
PE
558 Fix minor problems found by static checking.
559 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
560 * indent.c (Fvertical_motion): Fix == vs = typo.
561
e3cbd34b
EZ
5622011-09-24 Eli Zaretskii <eliz@gnu.org>
563
a66cfb1c
SM
564 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
565 Default value is now t. Doc fix.
6bf7006f 566
e3cbd34b 567 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 568 logic when moving up, not only when moving down. Fix the
e3cbd34b 569 confusing name and values of the it_overshoot_expected variable;
32c1fffd 570 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
571
572 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
573 CHARPOS is covered by a display string which includes newlines.
574 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
575 is covered by a display string with embedded newlines.
576
a3de0cbd
MA
5772011-09-24 Michael Albinus <michael.albinus@gmx.de>
578
579 * dbusbind.c (Fdbus_register_signal): Add match rule to
580 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
581 (Fdbus_register_method, Vdbus_registered_objects_table):
582 Fix docstring.
a3de0cbd 583
b260039d
JM
5842011-09-24 Jim Meyering <meyering@redhat.com>
585
32c1fffd 586 do not ignore write error for any output size
b260039d
JM
587 The previous change was incomplete.
588 While it makes emacs --batch detect the vast majority of stdout
589 write failures, errors were still ignored whenever the output size is
590 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
591 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
592 && echo FAIL: ignored write error
593 FAIL: ignored write error
594 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
595 && echo FAIL: ignored write error
596 FAIL: ignored write error
597 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
598
8eca8a7c
AS
5992011-09-23 Andreas Schwab <schwab@linux-m68k.org>
600
601 * emacs.c (Fkill_emacs): In noninteractive mode exit
602 non-successfully if a write error occurred on stdout. (Bug#9574)
603
3341db62
EZ
6042011-09-21 Eli Zaretskii <eliz@gnu.org>
605
606 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
607 the xassert test.
608
609 * dispextern.h (struct it): Update the comment documenting what
610 can it->OBJECT be.
611
8c203dbf
EZ
6122011-09-20 Eli Zaretskii <eliz@gnu.org>
613
614 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
615 a display string, extend search for cursor position to end of row.
616 (find_row_edges): If the row ends in a newline from a display
617 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
618 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
619 (Fcurrent_bidi_paragraph_direction): Fix search for previous
620 non-empty line. Fixes confusing cursor motion with arrow keys at
621 the beginning of a line that starts with whitespace.
8c203dbf 622
a4824228
LMI
6232011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
624
625 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
626 (bug#9493).
627
33ed493b
CY
6282011-09-18 Chong Yidong <cyd@stupidchicken.com>
629
630 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
631 boolean (Bug#9154).
632
56cd55c8
EZ
6332011-09-18 Eli Zaretskii <eliz@gnu.org>
634
635 * xdisp.c (display_line): Record maximum and minimum buffer
636 positions even if no glyphs were produced (e.g., by a zero-width
637 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
638 buffer positions that will be removed from the glyph row because
639 they don't fit.
c02dcedf
EZ
640 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
641 column is beyond frame width: don't subtract 1 "pixel" when
642 computing width of the stretch.
3e62b7e0
EZ
643 (reseat_at_next_visible_line_start): Undo the change made on
644 2011-09-17 that saved paragraph information and restored it after
645 the call to `reseat'. (Bug#9545)
56cd55c8 646
5ed99d36 6472011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
648
649 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
650 and turn window cursor on if cleared (Bug#9415).
651
5ed99d36 6522011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
653
654 * search.c (boyer_moore): Take unibyte characters from pattern
655 literally. (Bug#9458)
656
9bade7b2
EZ
6572011-09-18 Eli Zaretskii <eliz@gnu.org>
658
659 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
660
e5e9d610
PE
6612011-09-18 Paul Eggert <eggert@cs.ucla.edu>
662
87e4427a
PE
663 Fix minor problem found by static checking.
664 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
665 initialized, to pacify gcc -Wuninitialized.
666
e5e9d610
PE
667 * fileio.c: Report proper errno when syscall falls.
668 (Finsert_file_contents): Save and restore errno,
669 so that report_file_error outputs the correct diagnostic.
670 (Fwrite_region) [CLASH_DETECTION]: Likewise.
671
a1674f0b
EZ
6722011-09-18 Eli Zaretskii <eliz@gnu.org>
673
674 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
675
fbfb6dd4
EZ
6762011-09-17 Eli Zaretskii <eliz@gnu.org>
677
678 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
679 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
680
bb187662
EZ
6812011-09-17 Eli Zaretskii <eliz@gnu.org>
682
1137e8b8 683 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 684 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
685
686 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
687 (bidi_find_paragraph_start): Search back for paragraph beginning
688 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
689 (bidi_move_to_visually_next): Only trigger paragraph-related
690 computations when the last character is a newline or at EOB, not
691 just any NEUTRAL_B. (Bug#9470)
692
bb187662
EZ
693 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
694 truncated lines if point is covered by a display string. (Bug#9524)
695
2e621251
PE
6962011-09-16 Paul Eggert <eggert@cs.ucla.edu>
697
698 * xselect.c: Relax test for outgoing X longs (Bug#9498).
699 (cons_to_x_long): New function.
700 (lisp_data_to_selection_data): Use it. Correct the test for
701 short-versus-long data; it was negated. Break out of vector
702 loop, for efficiency, when a long datum is discovered.
703
91a15bc6
SM
7042011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
705
706 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
707
b41c3a35
EZ
7082011-09-16 Eli Zaretskii <eliz@gnu.org>
709
710 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
711 GCC PR/17406) by declaring this function with external scope.
712
7812ba2d
PE
7132011-09-15 Paul Eggert <eggert@cs.ucla.edu>
714
715 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
716 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
717
cf7edc2a
AS
7182011-09-15 Andreas Schwab <schwab@linux-m68k.org>
719
720 * editfns.c (Fformat): Correctly handle text properties on "%%".
721
bd01620e
EZ
7222011-09-15 Eli Zaretskii <eliz@gnu.org>
723
724 * xterm.c (x_draw_composite_glyph_string_foreground):
725 * w32term.c (x_draw_composite_glyph_string_foreground):
726 * term.c (encode_terminal_code):
727 * composite.c (composition_update_it, get_composition_id):
728 * xdisp.c (get_next_display_element)
729 (fill_composite_glyph_string): Add comments about special meaning
730 of TAB characters in a composition.
731
a02719a3
PE
7322011-09-15 Paul Eggert <eggert@cs.ucla.edu>
733
734 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
735 This occurs when processing a multibyte format.
736 Problem reported by Wolfgang Jenker.
a02719a3 737
72589a3c
JB
7382011-09-15 Johan Bockgård <bojohan@gnu.org>
739
740 * xdisp.c (try_cursor_movement): Only check for exact match if
741 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
742
1c14176c
PE
7432011-09-14 Paul Eggert <eggert@cs.ucla.edu>
744
745 Remove unused external symbols.
746 * dispextern.h (calc_pixel_width_or_height): Remove decl.
747 * xdisp.c (calc_pixel_width_or_height): Now static.
748 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
749 * indent.c (check_display_width):
750 * w32term.c: Fix comment to match code.
751 * xterm.c, xterm.h (x_catching_errors): Remove.
752
d2eea5b5
PE
7532011-09-14 Paul Eggert <eggert@cs.ucla.edu>
754
755 * xselect.c: Use signed conversions more consistently (Bug#9498).
756 (selection_data_to_lisp_data): Assume incoming selection data are
757 signed integers, not unsigned. This is to be consistent with
758 outgoing selection data, which was modified to use signed integers
759 in as part of the fix to Bug#9196 in response to Jan D.'s comment
760 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
761 expects long, not unsigned long.
762
46888499
EZ
7632011-09-14 Eli Zaretskii <eliz@gnu.org>
764
765 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
766 computation of loop end. Reported by Johan Bockgård
767 <bojohan@gnu.org>.
768
ef8ef9fb
CY
7692011-09-13 Chong Yidong <cyd@stupidchicken.com>
770
771 * frame.c (Fother_visible_frames_p): Function deleted.
772
fa819fed
EZ
7732011-09-12 Eli Zaretskii <eliz@gnu.org>
774
775 * indent.c (compute_motion): Process display vector front to back
776 rather than the other way around. (Bug#2496)
777
2ba8e008
SM
7782011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
779
780 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
781
20f53c69
CY
7822011-09-11 Chong Yidong <cyd@stupidchicken.com>
783
784 * minibuf.c (Fread_from_minibuffer): Doc fix.
785
d562d7a4
EZ
7862011-09-11 Eli Zaretskii <eliz@gnu.org>
787
788 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
789 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
790
1c4d7f3d
LMI
7912011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
792
793 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
794 value for non-existent files.
795
b885bf36
EZ
7962011-09-11 Eli Zaretskii <eliz@gnu.org>
797
798 * fileio.c (Finsert_file_contents): If the file cannot be opened,
799 set its "size" to -1. This will set the modtime_size field of
800 the corresponding buffer to -1, which is what
801 verify-visited-file-modtime expects for files that do not exist.
802 (Bug#9139)
803
6612f0bf
PE
8042011-09-11 Paul Eggert <eggert@cs.ucla.edu>
805
806 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
807 here ...
808 * lisp.h: ... from here. push_key_description is no longer
809 defined in keyboard.c, so its declaration should not be in
810 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
811 logically belongs with push_key_description.
812
dfb3f755
PE
8132011-09-10 Paul Eggert <eggert@cs.ucla.edu>
814
815 * buffer.h: Include <sys/types.h> instead of <time.h>.
816 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
817 Problem reported by Herbert J. Skuhra.
818
3134906c
LMI
8192011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
820
821 * xml.c (parse_region): Make the parsing work for
822 non-comment-starting XML files again (bug#9144).
823
8d903f4e
AS
8242011-09-10 Andreas Schwab <schwab@linux-m68k.org>
825
826 * image.c (gif_load): Fix calculation of bottom and right corner.
827 (Bug#9468)
828
80ad64f4
EZ
8292011-09-10 Eli Zaretskii <eliz@gnu.org>
830
831 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
832 redisplay in small windows.
833
208a048d
EZ
8342011-09-09 Eli Zaretskii <eliz@gnu.org>
835
836 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
837
9b1c252e
MR
8382011-09-08 Martin Rudalics <rudalics@gmx.at>
839
840 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
841 Operate on live windows only.
842
2949f33b
JB
8432011-09-08 Juanma Barranquero <lekktu@gmail.com>
844
845 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
846
e08dcafd
EZ
8472011-09-07 Eli Zaretskii <eliz@gnu.org>
848
849 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
850 only under bidi iteration.
851
115b96bd
JD
8522011-09-07 Jan Djärv <jan.h.d@swipnet.se>
853
854 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
855
c8199d0f
PE
8562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
857
858 isnan: Fix porting problem to Solaris 10 with bundled gcc.
859 Without this fix, the command to link temacs failed due to an
860 undefined symbol __builtin_isnan. This is because
861 /usr/include/iso/math_c99.h #defines isnan(x) to
862 __builtin_isnan(x), but the bundled gcc, which identifies itself
863 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
864 a __builtin_isnan.
865 * floatfns.c (isnan): #undef, and then #define to a clone of
866 what's in data.c.
867 (Fisnan): Always define, since it's always available now.
868 (syms_of_floatfns): Always define isnan at the Lisp level.
869
e39b275c 8702011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
871
872 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
873
b2db44d9 8742011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 875
f4af5137 876 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
877 The previous code assumed that file offsets (off_t values) fit in
878 EMACS_INT variables, which is not true on typical 32-bit hosts.
879 The code messed up by falsely reporting buffer overflow in cases
880 such as (insert-file-contents "big" nil 1 2) into an empty buffer
881 when "big" contains more than 2**29 bytes, even though this
882 inserts just one byte and does not overflow the buffer.
883 (Finsert_file_contents): Store file offsets as off_t
884 values, not as EMACS_INT values. Check for overflow when
885 converting between EMACS_INT and off_t. When checking for
886 buffer overflow or for overlap, take the offsets into account.
887 Don't use EMACS_INT for small values where int suffices.
888 When checking for overlap, fix a typo: ZV was used where
889 ZV_BYTE was intended.
890 (Fwrite_region): Don't assume off_t fits into 'long'.
891 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
892
ecfc0a49
MA
8932011-09-05 Michael Albinus <michael.albinus@gmx.de>
894
895 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
896
6511acf2 8972011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 898
0999621a 899 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
900
901 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 902 (esprintf, exprintf, evxprintf): New functions.
62f19c19 903 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 904 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
905 (modify_event_symbol): Do not assume that the length of
906 name_alist_or_stem is safe to alloca and fits in int.
907 (Fexecute_extended_command): Likewise for function name and binding.
908 (Frecursion_depth): Wrap around reliably on integer overflow.
909 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
910 since some callers pass EMACS_INT values.
911 (Fsingle_key_description): Don't crash if symbol name contains more
912 than MAX_ALLOCA bytes.
913 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
914 (get_minibuffer): Arg is now EMACS_INT, not int.
915 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 916 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
917 * window.h (command_loop_level, minibuf_level): Reflect API changes.
918
2be7d702
PE
919 * dbusbind.c (signature_cat): New function.
920 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
921 Do not overrun buffer; instead, report string overflow.
922
9d1df220
PE
923 * dispnew.c (add_window_display_history): Don't overrun buffer.
924 Truncate instead; this is OK since it's just a log.
925
33ef5c64
PE
926 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
927 even if the time zone offset is outlandishly large.
928 Don't mishandle offset == INT_MIN.
929
66c6fdd5
PE
930 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
931 when creating daemon; the previous buffer-overflow check was incorrect.
932
d749b01b
PE
933 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
934 which has the guts of the old verror function.
935
b5cd1905
PE
936 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
937 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
938
6e1a67fb
PE
939 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
940 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 941 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 942 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
943 length of string rather than counting it via multiple sprintfs;
944 that's simpler and more reliable.
c21721cc
PE
945 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
946 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
947 sprintf, in case result does not fit in int.
948
c57b67fc
PE
949 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
950 (fontset_from_font): Print it.
951
8a401434
PE
952 * frame.c (tty_frame_count): Now printmax_t, not int.
953 (make_terminal_frame, set_term_frame_name): Print it.
954 (x_report_frame_params): In X, window IDs are unsigned long,
955 not signed long, so print them as unsigned.
956 (validate_x_resource_name): Check for implausibly long names,
957 and don't assume name length fits in 'int'.
958 (x_get_resource_string): Don't blindly alloca invocation name;
959 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
960 not fit in int.
961
6e1a67fb
PE
962 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
963 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
964 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
965
0df02bf3
PE
966 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
967 Use esprintf, not sprintf, in case result does not fit in int.
968
48e30793
PE
969 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
970 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
971 it as a large positive number.
972 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
973 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
974
a66ff6d8
PE
975 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
976 in case result does not fit in int.
977
aca216ff
PE
978 * print.c (float_to_string): Detect width overflow more reliably.
979 (print_object): Make sprintf buffer a bit bigger, to avoid potential
980 buffer overrun. Don't assume list length fits in 'int'. Treat
981 print length of 0 as 0, not as infinity; to be consistent with other
982 uses of print length in this function. Don't overflow print length
983 index. Don't assume hash table size fits in 'long', or that
984 vectorlike size fits in 'unsigned long'.
985
31c286f7
PE
986 * process.c (make_process): Use printmax_t, not int, to format
987 process-name gensyms.
988
55e5faa1
PE
989 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
990
80f2e268
PE
991 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
992 to avoid potential buffer overrun.
993
670741ab
PE
994 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
995 if X resource line is longer than 512 bytes.
996
b7163a50
PE
997 * xfns.c (x_window): Make sprintf buffer a bit bigger
998 to avoid potential buffer overrun.
999
ae58ff1f
PE
1000 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1001
c43c8a6a
PE
1002 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1003
3f8236f4
PE
10042011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1005
53e9fe90 1006 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1007 Without these, Emacs silently mishandles large integers sometimes.
1008 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1009 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1010
6511acf2
PE
1011 * xdisp.c (try_window_id): Check Emacs fixnum range before
1012 converting to 'int'.
806add1d 1013
6511acf2 1014 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1015 Check that an Emacs fixnum is in range before assigning it to 'int'.
1016 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1017 values converted from Emacs fixnums.
1018 (Frecenter): Don't wrap around a line count if it is out of 'int'
1019 range; instead, treat it as an extreme value.
1020 (Fset_window_configuration, compare_window_configurations):
1021 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1022
6511acf2
PE
1023 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1024 that can exceed INT_MAX. Check that EMACS_INT value is in range
1025 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1026 (match_limit): Don't assume that a fixnum can fit in 'int'.
1027
6511acf2 1028 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1029 exceed INT_MAX.
1030
6511acf2 1031 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1032 (Fvertical_motion): Don't wrap around LINES values that don't fit
1033 in 'int'. Instead, treat them as extreme values. This is good
1034 enough for windows, which can't have more than INT_MAX lines anyway.
1035
fcb901a7
LMI
10362011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1037
0f2f6b6d
LMI
1038 * Require libxml/parser.h to avoid compilation warning.
1039
fcb901a7
LMI
1040 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1041
1042 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1043 since this reportedly can destroy thread storage.
1044
6e20a0d4
CY
10452011-08-30 Chong Yidong <cyd@stupidchicken.com>
1046
1047 * syntax.c (find_defun_start): Update all cache variables if
1048 exiting early (Bug#9401).
1049
148ae00e
EZ
10502011-08-30 Eli Zaretskii <eliz@gnu.org>
1051
f6cfbd8f
EZ
1052 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1053
148ae00e
EZ
1054 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1055 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1056 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1057
1058 * term.c (tty_append_glyph): New function.
1059 (produce_stretch_glyph): Static function and its prototype deleted.
1060
a66cfb1c
SM
1061 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1062 Add prototypes.
148ae00e 1063
c4a07a4c
PE
10642011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1065
1066 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1067 when checking :margin (Bug#9390).
1068 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1069 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1070 so that the name doesn't mislead. All uses changed.
1071
6bc8cd65
JB
10722011-08-28 Johan Bockgård <bojohan@gnu.org>
1073
1074 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1075 set_tty_hooks.
1076
dca4927e
EZ
10772011-08-27 Eli Zaretskii <eliz@gnu.org>
1078
1079 * xdisp.c (move_it_to): Don't bail out early when reaching
1080 position beyond to_charpos, if we are scanning backwards.
1081 (move_it_vertically_backward): When DY == 0, make sure we get to
1082 the first character in the line after the newline.
1083
f2cad773
PE
10842011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1085
1086 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1087 (ccl_driver): Do not generate an out-of-range pointer.
1088 (Fccl_execute_on_string): Remove unnecessary check for
1089 integer overflow, noted by Stefan Monnier in
1090 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1091 Remove a FIXME that didn't need fixing.
1092 Simplify the newly-introduced buffer reallocation code.
1093
0cae2cdb
JB
10942011-08-27 Juanma Barranquero <lekktu@gmail.com>
1095
1096 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1097
5fc295a4 10982011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1099
70c60eb2 1100 Integer and memory overflow issues (Bug#9196).
726e0ab1 1101
d31850da
PE
1102 * doc.c (get_doc_string): Rework so that
1103 get_doc_string_buffer_size is the actual buffer size, rather than
1104 being 1 less than the actual buffer size; this makes xpalloc more
1105 convenient.
1106
a69fbedb
PE
1107 * image.c (x_allocate_bitmap_record, cache_image):
1108 * xselect.c (Fx_register_dnd_atom):
1109 Simplify previous changes by using xpalloc.
1110
fe5c5d37
PE
1111 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1112 since either will do and ptrdiff_t is convenient with xpalloc.
1113
0065d054
PE
1114 * charset.c (charset_table_size)
1115 (struct charset_sort_data.priority): Now ptrdiff_t.
1116 (charset_compare): Don't overflow if priorities differ greatly.
1117 (Fsort_charsets): Don't assume list length fits in int.
1118 Check for size-calculation overflow when allocating sort data.
1119 (syms_of_charset): Allocate an initial charset table that is
1120 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1121
1122 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1123
1124 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1125 The actual value is always <= INT_MAX, and leaving it unsigned made
1126 overflow checking harder.
1127
1128 * dispextern.h (struct glyph_matrix.rows_allocated)
1129 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1130 with xpalloc. The values are still always <= INT_MAX.
1131
1132 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1133
1134 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1135 (SAFE_NALLOCA): New macro.
1136
1137 * region-cache.c (struct boundary.pos, find_cache_boundary)
1138 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1139 (set_cache_region, invalidate_region_cache)
1140 (revalidate_region_cache, know_region_cache, region_cache_forward)
1141 (region_cache_backward, pp_cache):
1142 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1143 so that ptrdiff_t * can be passed to xpalloc.
1144 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1145 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1146 (pp_cache): Don't assume cache_len fits in int.
1147 * region-cache.h: Adjust extern decls to match.
1148
1149 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1150 EMACS_INT, since either will do, for xpalloc.
1151
1152 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1153 (xnmalloc, xnrealloc, xpalloc): New functions.
1154
726e0ab1
PE
1155 * bidi.c (bidi_shelve_header_size): New constant.
1156 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1157 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1158
51f30bc5 1159 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1160 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1161 (overlay_strings):
1162 Don't update size of array until after memory allocation succeeds,
1163 because xmalloc/xrealloc may not return.
0065d054
PE
1164 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1165 now that we have proper integer overflow checking.
1166 (record_overlay_string, overlay_strings): Catch overflows when
1167 calculating size of overlay_str_buf.
726e0ab1 1168
0065d054
PE
1169 * callproc.c (Fcall_process): Check for size overflow when
1170 calculating size of args2.
1171 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1172 Normally we prefer signed values, but sticking with ptrdiff_t would
1173 require adding more-complicated checks.
726e0ab1
PE
1174
1175 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1176 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1177 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1178 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1179
1180 * character.c (Fstring): Check for size-calculation overflow.
1181
1182 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1183 unnecessary integer overflow. Check for size overflow.
1184 (encode_coding_object): Don't update size until xmalloc succeeds.
1185
1186 * composite.c (get_composition_id): Check for overflow in glyph
1187 length calculations.
1188
1189 Integer and memory overflow fixes for display code.
1190 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1191 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1192 (scrolling_window): Check for overflow in size calculations.
1193 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1194 Don't assume glyph table len fits in int.
1195 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1196 (row_table_size): Now ptrdiff_t, not int.
1197 (scrolling_window): Avoid overflow in size calculations.
1198 Don't update size until allocation succeeds.
1199 * fns.c (concat): Check for overflow in size calculations.
1200 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1201 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1202 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1203
1204 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1205 (get_doc_string): Check for size calculation overflow.
1206 Don't update size until allocation succeeds.
1207 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1208 EMACS_INT, where ptrdiff_t will do.
1209 (Fsubstitute_command_keys): Check for string overflow.
1210
1211 * editfns.c (set_time_zone_rule): Don't assume environment length
1212 fits in int.
1213 (message_length): Now ptrdiff_t, not int.
1214 (Fmessage_box): Don't update size until allocation succeeds.
1215 Don't assume message length fits in int.
1216 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1217
0065d054
PE
1218 * emacs.c (main): Do not reallocate argv, since there is a null at
1219 the end that can be overwritten, and this way there's no need to
1220 worry about size-calculation overflow.
1221 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1222
1223 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1224 alloc succeeds.
1225 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1226
1227 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1228 (x_set_scroll_bar_width, x_figure_window_size):
1229 Check for integer overflow.
1230 (x_set_alpha): Do not assume XINT fits in int.
1231
1232 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1233 This is for the members text_lines, text_cols, total_lines, total_cols,
1234 where the system imposes an 'int' limit.
1235
1236 * fringe.c (Fdefine_fringe_bitmap):
1237 Don't update size until alloc works.
1238
1239 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1240 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1241
1242 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1243 Check for size-calculation overflow.
1244 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1245 do, as we prefer signed integers.
1246 (id_to_widget.max_size, id_to_widget.used)
1247 (xg_store_widget_in_map, xg_remove_widget_from_map)
1248 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1249 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1250 Use and return ptrdiff_t, not int.
1251 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1252 * gtkutil.h: Change prototypes to match the above.
1253
1254 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1255 are duplicate now that they've been promoted to lisp.h.
1256 (x_allocate_bitmap_record, x_alloc_image_color)
1257 (make_image_cache, cache_image, xpm_load):
1258 Don't update size until alloc is done.
1259 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1260 (x_detect_edges):
3256efce 1261 Check for size calculation overflow.
726e0ab1
PE
1262 (ct_colors_allocated_max): New constant.
1263 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1264 overflow.
3256efce 1265
726e0ab1
PE
1266 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1267 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1268 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1269 Use ptrdiff_t, not int, to count maps.
1270 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1271 calculations. Don't update size until allocation succeeds.
1272 Redo calculations to avoid overflow.
726e0ab1
PE
1273 * keyboard.h: Change prototypes to match the above.
1274
1275 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1276 to count maps.
1277 (current_minor_maps): Check for size calculation overflow.
1278 * keymap.h: Change prototypes to match the above.
1279
1280 * lread.c (read1, init_obarray): Don't update size until alloc done.
1281
1282 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1283 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1284
726e0ab1
PE
1285 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1286 Now ptrdiff_t, not int.
1287 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1288 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1289
1290 * process.c (Fnetwork_interface_list): Check for overflow
1291 in size calculation.
1292
1293 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1294
1295 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1296 overflow. Don't bother calling xmalloc when xrealloc will do.
1297
1298 * search.c (Freplace_match): Check for size calculation overflow.
1299 (Fset_match_data): Don't assume list lengths fit in 'int'.
1300
1301 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1302 for command line length. Do not attempt to address one before the
1303 beginning of an array, as that's not portable.
1304
1305 * term.c (max_frame_lines): Remove; unused.
1306 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1307 not int.
1308 (encode_terminal_code, calculate_costs): Check for size
1309 calculation overflow.
1310 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1311 table lengths and related sizes. Don't update size until alloc
1312 done. Redo calculations to avoid overflow.
1313 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1314
1315 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1316 subtracting pointers.
1317 (gobble_line): Check for overflow more carefully. Don't update size
1318 until alloc done.
1319
1320 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1321 Don't update size until alloc done.
1322 Redo size calculations to avoid overflow.
1323 Check for size calculation overflow.
0065d054 1324 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1325
1326 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1327 Use ptrdiff_t, not int, for sizes.
1328 (store_mode_line_noprop_char): Don't update size until alloc done.
1329
0065d054
PE
1330 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1331 Use ptrdiff_t, not int, for sizes.
1332 (Finternal_make_lisp_face, cache_face):
1333 Check for size calculation overflow.
1334 (cache_face): Treat size calculation overflows as if they were
1335 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1336
1337 * xfns.c (x_encode_text, x_set_name_internal)
1338 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1339 sizes, since they can exceed INT_MAX in size. Check for size
1340 calculation overflow.
1341
0065d054
PE
1342 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1343 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1344 Don't update size until alloc done.
1345
0065d054 1346 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1347 as sprintf is limited to int lengths.
1d526e2f 1348
252c5ee1
PE
1349 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1350 (X_LONG_MIN): New macros.
864d7ce7
PE
1351 Use them to make the following changes clearer.
1352 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1353 This change doesn't affect the value now, but it may help remind
1354 future maintainers not to raise the value too much later.
1355 (SELECTION_QUANTUM): Remove, replacing with ...
1356 (selection_quantum): ... new function, which avoids overflow.
1357 All uses changed.
1358 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1359 assumption that selection length fits in 'int'.
1360 (x_reply_selection_request, x_handle_selection_request)
1361 (x_get_window_property, receive_incremental_selection)
1362 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1363 (lisp_data_to_selection_data, clean_local_selection_data):
1364 Use ptrdiff_t, not int, to record length of selection.
1365 (x_reply_selection_request, x_get_window_property)
1366 (receive_incremental_selection, x_property_data_to_lisp):
1367 Redo calculations to avoid overflow.
1368 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1369 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1370 something.
1371 (x_get_window_property, receive_incremental_selection)
1372 (lisp_data_to_selection_data, x_property_data_to_lisp):
1373 Check for size-calculation overflow.
1374 (x_get_window_property, receive_incremental_selection)
1375 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1376 Don't store size until memory allocation succeeds.
1377 (x_get_window_property): Plug memory leak on memory exhaustion.
1378 Don't double-block input; malloc is safe here. Don't assume 2**34
1379 - 4 fits in unsigned long. Add an xassert to check
1380 XGetWindowProperty overflow. Be more careful about overflow
1381 calculations, and distinguish size from memory overflow better.
1382 (receive_incremental_selection): When tracing, don't assume
1383 unsigned int is less than INT_MAX.
1384 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1385 harmful) conversions of unsigned short to int.
1386 (lisp_data_to_selection_data): Don't assume that integers
1387 in the range -65535 through -1 fit in an X unsigned short.
1388 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1389 result parameters unless successful. Rely on cons_to_unsigned
1390 to report problems with elements; the old code wasn't right anyway.
1391 (x_check_property_data): Check for int overflow; we cannot use
1392 a wider type due to X limits.
1393 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1394
726e0ab1 1395 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1396
0065d054
PE
1397 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1398 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1399 (x_color_cells): Don't store size until memory allocation succeeds.
1400 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1401 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1402 (x_term_init): Don't assume length fits in int (sprintf is limited
1403 to int size).
bc18e09d 1404
ebfa62c0
PE
1405 Use ptrdiff_t for composition IDs.
1406 * character.c (lisp_string_width):
1407 * composite.c (composition_table_size, n_compositions)
1408 (get_composition_id, composition_gstring_from_id):
1409 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1410 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1411 * window.c (Frecenter):
1412 Use ptrdiff_t, not int, for composition IDs.
1413 * composite.c (get_composition_id): Check for integer overflow.
1414 * composite.h: Adjust prototypes to match the above changes.
1415
d3411f89
PE
1416 Use ptrdiff_t for hash table indexes.
1417 * category.c (hash_get_category_set):
1418 * ccl.c (ccl_driver):
1419 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1420 * coding.c (coding_system_charset_list, detect_coding_system):
1421 * coding.h (struct coding_system.id):
1422 * composite.c (get_composition_id, gstring_lookup_cache):
1423 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1424 * image.c (xpm_get_color_table_h):
1425 * lisp.h (hash_lookup, hash_put):
1426 * minibuf.c (Ftest_completion):
1427 Use ptrdiff_t for hash table indexes, not int (which is too
1428 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1429 32-bit --with-wide-int hosts).
1430
e097a6fa
PE
1431 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1432 Add a FIXME comment about memory leaks.
1433 (syms_of_charset): Don't assume xmalloc returns.
1434
5637687f
PE
1435 Don't assume that stated character widths fit in int.
1436 * character.c (Fchar_width, c_string_width, lisp_string_width):
1437 * character.h (CHAR_WIDTH):
1438 * indent.c (MULTIBYTE_BYTES_WIDTH):
1439 Use sanitize_char_width to avoid undefined and/or bad behavior
1440 with outlandish widths.
a66cfb1c 1441 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1442 now that we have two such functions. All uses changed.
1443 (sanitize_char_width): New inline function.
1444
a2271ba2
PE
1445 Don't assume that tab-width fits in int.
1446 * character.h (sanitize_width): New inline function.
1447 (SANE_TAB_WIDTH): New macro.
1448 (ASCII_CHAR_WIDTH): Use it.
1449 * indent.c (sane_tab_width): Remove. All uses replaced by
1450 SANE_TAB_WIDTH (current_buffer).
1451 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1452
18c52557
PE
1453 * fileio.c: Integer overflow issues with file modes.
1454 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1455
caeeedc1
PE
1456 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1457 Remove unreachable code.
1458 (read_hex, load_charset_map_from_file): Check for integer overflow.
1459
50849c52
PE
1460 * xterm.c: don't go over XClientMessageEvent limit
1461 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1462 (x_send_scroll_bar_event): Likewise. Check that the size does not
1463 exceed limits imposed by XClientMessageEvent, as well as the usual
1464 ptrdiff_t and size_t limits.
1465
b13995db
PE
1466 * keyboard.c: Overflow, signedness and related fixes.
1467 (make_lispy_movement): Use same integer type in forward decl
1468 that is used in the definition.
1469 (read_key_sequence, keyremap_step):
1470 Change bufsize argument back to int, undoing my 2011-03-30 change.
1471 We prefer signed types, and int is wide enough here.
1472 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1473 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1474 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1475 length, not size_t. Use ptrdiff_t for index, not int.
1476 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1477 possibility of integer overflow.
1478
13464394
PE
1479 Overflow, signedness and related fixes for images.
1480
1481 * dispextern.h (struct it.stack[0].u.image.image_id)
1482 (struct_it.image_id, struct image.id, struct image_cache.size)
1483 (struct image_cache.used, struct image_cache.ref_count):
1484 * gtkutil.c (update_frame_tool_bar):
1485 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1486 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1487 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1488 * nsmenu.m (update_frame_tool_bar):
1489 * xdisp.c (calc_pixel_width_or_height):
1490 * xfns.c (image_cache_refcount):
1491 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1492 on typical 64-bit hosts.
1493
1494 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1495 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1496 Omit unnecessary casts to int.
1497 (parse_image_spec): Check that integers fall into 'int' range
1498 when the callers expect that.
1499 (image_ascent): Redo ascent calculation to avoid int overflow.
1500 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1501 (lookup_image): Remove unnecessary tests.
1502 (xbm_image_p): Locals are now of int, not EMACS_INT,
1503 since parse_image_check makes sure they fit into int.
1504 (png_load, gif_load, svg_load_image):
1505 Prefer int to unsigned where either will do.
1506 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1507 old tiff_error_handler and tiff_warning_handler.
1508 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1509 stack buffer overflows. It uses only the features of vsnprintf
1510 that are common to both POSIX and native Microsoft.
1511 (tiff_error_handler, tiff_warning_handler): Use it.
1512 (tiff_load, gif_load, imagemagick_load_image):
1513 Don't assume :index value fits in 'int'.
1514 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1515 (imagemagick_load_image): Check that crop parameters fit into
1516 the integer types that MagickCropImage accepts. Don't assume
1517 Vimagemagick_render_type has a nonnegative value. Don't assume
1518 size_t fits in 'long'.
1519 (gs_load): Use printmax_t to print the widest integers possible.
1520 Check for integer overflow when computing image height and width.
1521
c11821d4
EZ
15222011-08-26 Eli Zaretskii <eliz@gnu.org>
1523
1524 * xdisp.c (redisplay_window): Don't force window start if point
1525 will be invisible in the resulting window. (Bug#9324)
1526
0c95fcf7
EZ
15272011-08-25 Eli Zaretskii <eliz@gnu.org>
1528
1529 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1530 the display spec is of the form `(space ...)'.
1531 (handle_display_spec): Return the value returned by
1532 handle_single_display_spec, not just 1 or zero.
1533 (handle_single_display_spec): If the display spec is of the form
1534 `(space ...)', and specifies display in the text area, return 2
1535 rather than 1.
fee65a97 1536 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1537 accurately, and prefer exact match for point under bidi.
1538 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1539
1540 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1541 into disp_prop; all users changed.
1542
1543 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1544 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1545 for the text covered by the display property.
1546
e4ed06f1
CY
15472011-08-25 Chong Yidong <cyd@stupidchicken.com>
1548
1549 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1550 Change return value to nil.
1551 (Frecord_buffer): Delete unused function.
1552
f67cdd7f
EZ
15532011-08-24 Eli Zaretskii <eliz@gnu.org>
1554
5980d4c6
EZ
1555 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1556 buffers, return left-to-right.
8610fe8b
EZ
1557 (set_cursor_from_row): Consider candidate row a win if its glyph
1558 represents a newline and point is on that newline. Fixes cursor
1559 positioning on the newline at EOL of R2L text within L2R
1560 paragraph, and vice versa.
1561 (try_cursor_movement): Check continued rows, in addition to
1562 continuation rows. Fixes unwarranted scroll when point enters a
1563 continued line of R2L text within an L2R paragraph, or vice versa.
1564 (cursor_row_p): Consider the case of point being equal to
1565 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1566 from the end of a short line to the beginning of a continued line
1567 of R2L text within L2R paragraph.
1568 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1569 composed characters.
5980d4c6 1570
f67cdd7f
EZ
1571 * bidi.c (bidi_check_type): Use xassert.
1572 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1573 members.
1574
bca633fb
EZ
15752011-08-23 Eli Zaretskii <eliz@gnu.org>
1576
1577 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1578 a character.
1579
4a5885a7
CY
15802011-08-23 Chong Yidong <cyd@stupidchicken.com>
1581
1582 * nsfont.m (ns_otf_to_script): Fix typo.
1583
0902a04e
KH
15842011-08-22 Kenichi Handa <handa@m17n.org>
1585
1586 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1587 extra slot even if the purpose is char-code-property-table.
1588
1a2e6670
EZ
15892011-08-23 Eli Zaretskii <eliz@gnu.org>
1590
8ddde651
EZ
1591 * xdisp.c (redisplay_window): When computing centering_position,
1592 account for the height of the header line. (Bug#8874)
1593
425cc014
EZ
1594 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1595 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1596 candidate is selected by the mouse, and that candidate has a
1597 composed character under the mouse.
1598
1a2e6670
EZ
1599 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1600 coordinates reported by pos-visible-in-window-p for a composed
1601 character in column zero.
1602
8b76d6f8
SM
16032011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1604
1605 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1606
dac347dd
EZ
16072011-08-22 Eli Zaretskii <eliz@gnu.org>
1608
1609 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1610 consider it a hit if to_charpos is anywhere in the range of the
1611 composed buffer positions.
1612
e013fb34
CY
16132011-08-22 Chong Yidong <cyd@stupidchicken.com>
1614
1615 * image.c (gif_load): Don't assume that each subimage has the same
1616 dimensions as the base image. Handle disposal method that is
1617 "undefined" by the gif spec (Bug#9335).
1618
bd1ba3e8
CY
16192011-08-20 Chong Yidong <cyd@stupidchicken.com>
1620
1621 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1622 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1623
54a1215b
EZ
16242011-08-19 Eli Zaretskii <eliz@gnu.org>
1625
823564e5
EZ
1626 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1627 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1628 from an Org mode buffer to a Speedbar frame.
1629
54a1215b
EZ
1630 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1631 a composition, take its buffer position from IT->cmp_it.charpos.
1632 Fixes cursor positioning at the beginning of a line that begins
1633 with a composed character.
1634
9778ebcc
EZ
16352011-08-18 Eli Zaretskii <eliz@gnu.org>
1636
0be6ee06
EZ
1637 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1638 character bidirectional type, use STRONG_L instead. Fixes crashes
1639 in a buffer produced by `describe-categories'.
1640
9778ebcc
EZ
1641 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1642 members before the level stack, so they would be saved and
1643 restored when copying iterator state. Fixes incorrect reordering
1644 around TABs covered by display properties.
1645
156bffbe
AS
16462011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1647
6b02f655 1648 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1649
72ad093b
CY
16502011-08-17 Chong Yidong <cyd@stupidchicken.com>
1651
1652 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1653 (internal_condition_case_2, internal_condition_case_n):
1654 Remove unnecessary aborts (Bug#9081).
72ad093b 1655
35774242
EZ
16562011-08-17 Eli Zaretskii <eliz@gnu.org>
1657
1658 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1659 has no `load' handler, try opening the file locally. (Bug#9311)
1660
db76dd85
KB
16612011-08-16 Ken Brown <kbrown@cornell.edu>
1662
1663 * gmalloc.c: Expand comment.
1664
b215eee5
EZ
16652011-08-16 Eli Zaretskii <eliz@gnu.org>
1666
1667 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1668 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1669
a4579d33
KB
16702011-08-16 Ken Brown <kbrown@cornell.edu>
1671
1672 Fix memory allocation problems in Cygwin build (Bug#9273).
1673
1674 * unexcw.c ( __malloc_initialized): Declare external variable.
1675 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1676
8b76d6f8
SM
1677 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1678 New variables.
a4579d33
KB
1679 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1680 dumped emacs.
1681 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1682 in the static heap.
1683 [CYGWIN] (special_realloc): New function.
1684 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1685 requests to realloc storage in the static heap.
1686
3ebec551
PE
16872011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1688
1689 * bidi.c (bidi_initialize): Remove unused local.
1690
9fd8be00
EZ
16912011-08-15 Eli Zaretskii <eliz@gnu.org>
1692
6b02f655
SM
1693 * bidimirror.h:
1694 * biditype.h: Remove file.
1695 * makefile.w32-in ($(BLD)/bidi.$(O)):
1696 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1697
1698 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1699
1700 * chartab.c: Improve commentary for the uniprop_table API.
1701
32413314
EZ
1702 * bidi.c (bidi_paragraph_init): Support zero value of
1703 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1704 (bidi_initialize): Use uniprop_table instead of including
1705 biditype.h and bidimirror.h.
32413314 1706
9fd8be00
EZ
1707 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1708 coordinates of the iterator when restoring from ppos_it.
1709 (Bug#9296)
1710
5cf2b69b
KH
17112011-08-14 Kenichi Handa <handa@m17n.org>
1712
1713 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1714 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1715
daf17d00
EZ
17162011-08-14 Eli Zaretskii <eliz@gnu.org>
1717
1718 * xdisp.c (move_it_in_display_line_to): Don't invoke
1719 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1720 ppos_it. Fixes vertical cursor motion when line beginning is
1721 covered by an image. (Bug#9296)
1722
08e3161a
JD
17232011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1724
1725 * nsterm.h (ns_run_ascript): Declare.
1726 (NSAPP_DATA2_RUNASSCRIPT): Define.
1727
1728 * nsfns.m (as_script, as_result, as_status): New static variables.
1729 (ns_run_ascript): New function.
5e617bc2 1730 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1731 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1732 the event loop. Get status from as_status (Bug#7276).
1733
1734 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1735 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1736 the event loop (Bug#7276).
1737
a3720aa2
AS
17382011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1739
1740 * gnutls.c (QCgnutls_bootprop_priority)
1741 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1742 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1743 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1744 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1745 (QCgnutls_bootprop_verify_hostname_error)
1746 (QCgnutls_bootprop_callbacks_verify): Rename from
1747 Qgnutls_bootprop_..., all uses changed.
1748
1749 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1750 uses changed.
1751
0a0d27fb
PE
17522011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1753
19d5c50c
PE
1754 * xfaces.c (Qframe_set_background_mode): Now static.
1755 * dispextern.h (Qframe_set_background_mode): Remove decl.
1756
0a0d27fb
PE
1757 * process.c (Fnetwork_interface_info): Declare local only if needed.
1758
377538cb
JD
17592011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1760
1761 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1762 (Fnetwork_interface_list): Allocate in increments of bytes instead
1763 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1764 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1765 sockaddr.
1766 (struct ifflag_def): notrailers is smart on OSX.
1767 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1768 Get hardware address with getifaddrs if available.
1769
08fff70c
EZ
17702011-08-12 Eli Zaretskii <eliz@gnu.org>
1771
1772 * xdisp.c (iterate_out_of_display_property): xassert that
1773 IT->position is set to within IT->object's boundaries. Break from
1774 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1775 when IT->position is set up wrongly due to some bug.
1776 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1777 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1778 entry. Force push_it to save on the stack the current
1779 buffer/string position, to be restored by pop_it. Fix flags in
1780 the iterator structure wrt the object coming from a display
1781 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1782 properties. (Bug#9284)
1783
7be1c708 17842011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1785
7be1c708
CY
1786 * fontset.c (fontset_get_font_group): Add proper type checks.
1787 (Bug#9172)
aac0c6e3 1788
7be1c708 17892011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1790
7be1c708
CY
1791 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1792 and LC_VERSION_MIN_MACOSX.
1793 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1794 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1795
97bb72a6
EZ
17962011-08-08 Eli Zaretskii <eliz@gnu.org>
1797
1798 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1799 no-display-properties-and-no-overlays under bidi display.
1800 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1801 properties and overlays.
97bb72a6 1802
d5617611
CY
18032011-08-08 Chong Yidong <cyd@stupidchicken.com>
1804
37e11a63
CY
1805 * editfns.c (Fset_time_zone_rule): Document relationship with the
1806 setenv function.
1807
d5617611
CY
1808 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1809 the font entity extracted from the cache (Bug#8109).
1810
58872834
CY
18112011-08-07 Chong Yidong <cyd@stupidchicken.com>
1812
1813 * composite.c (autocmp_chars): Don't reset point. That is done by
1814 restore_point_unwind (Bug#5984).
1815
75bfc667
JL
18162011-08-07 Juri Linkov <juri@jurta.org>
1817
1818 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1819 to show the arg `TIME' instead of `TIMEVAL'.
1820
d1410150
EZ
18212011-08-06 Eli Zaretskii <eliz@gnu.org>
1822
1823 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1824 display property strides EOL and includes a newline, as in
1825 longlines-mode. (Bug#9254)
75b771e4
EZ
1826 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1827 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1828
1829 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1830 is non-zero, even if the data buffer is NULL. Fixes a crash in
1831 vertical-motion with longlines-mode. (Bug#9254)
1832
35928349
EZ
18332011-08-05 Eli Zaretskii <eliz@gnu.org>
1834
ec7cc85b
EZ
1835 * bidi.c <bidi_cache_total_alloc>: Now static.
1836 (bidi_initialize): Initialize bidi_cache_total_alloc.
1837
8b76d6f8 1838 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1839 cache. (Bug#9221)
1840
1841 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1842 amount allocated this far in `bidi_cache_total_alloc'.
1843 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1844 non-zero, only free the data buffer without restoring the cache
1845 contents. All callers changed.
1846
1847 * dispextern.h (bidi_unshelve_cache): Update prototype.
1848
1849 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1850 (move_it_in_display_line, move_it_to)
1851 (move_it_vertically_backward, move_it_by_lines): Replace the call
1852 to xfree to an equivalent call to bidi_unshelve_cache.
1853 (move_it_in_display_line_to): Fix logic of returning
412b6358 1854 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1855
e2e2423b
EZ
18562011-08-05 Eli Zaretskii <eliz@gnu.org>
1857
1858 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1859 came from a string character with a `cursor' property. (Bug#9229)
1860
ae9e757a
JD
18612011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1862
1863 * Makefile.in (LIB_PTHREAD): New variable.
1864 (LIBES): Add LIB_PTHREAD (Bug#9216).
1865
1866 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1867 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1868
213bd7f2
AS
18692011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1870
6b02f655 1871 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1872
99aaf75f
JD
18732011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1874
1875 * xterm.c (x_find_topmost_parent): New function.
1876 (x_set_frame_alpha): Find topmost parent window with
1877 x_find_topmost_parent and set the property there also (bug#9181).
1878 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1879
c74e9d86
PE
18802011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1881
1882 * callproc.c (Fcall_process): Avoid vfork clobbering
1883 the local vars buffer, coding_systems, current_dir.
1884
640c8776
SM
18852011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1886
1887 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1888
f26d0e4c
PE
18892011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1890
8a10d76c
PE
1891 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1892 so that it is not optimized away.
1893
f26d0e4c
PE
1894 * xdisp.c (compute_display_string_pos): Remove unused local.
1895
55439c61
EZ
18962011-08-02 Eli Zaretskii <eliz@gnu.org>
1897
1898 Fix slow cursor motion and scrolling in large buffers with
1899 selective display, like Org Mode buffers. (Bug#9218)
1900
1901 * dispextern.h (struct bidi_it): New member disp_prop_p.
1902
1903 * xdisp.c: Remove one-slot cache of display string positions.
1904 (compute_display_string_pos): Accept an additional argument
5e617bc2 1905 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1906 for a display string or property. If found, set DISP_PROP_P
1907 non-zero.
1908
1909 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1910 DISP_PROP_P, and pass it to compute_display_string_pos.
1911 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1912 non-zero. All callers of bidi_fetch_char changed.
1913
fb33fa43
SM
19142011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1915
1916 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1917
b099e063
DM
19182010-12-03 Don March <don@ohspite.net>
1919
1920 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1921 last character M-[char] is translated to ESC [char] (bug#7541).
1922
5cc7f7af
KH
19232011-08-02 Kenichi Handa <handa@m17n.org>
1924
d0fffa3f 1925 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1926
1927 * chartab.c (uniprop_table): Make it non-static.
1928
525d5e6e
EZ
19292011-08-01 Eli Zaretskii <eliz@gnu.org>
1930
1931 * xdisp.c (forward_to_next_line_start): Accept additional argument
1932 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1933 on the newline.
1934 (reseat_at_next_visible_line_start): Use the bidi iterator state
1935 returned by forward_to_next_line_start to restore the state of
1936 it->bidi_it after backing up to previous newline. (Bug#9212)
1937
31011111
AS
19382011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1939
1940 * regex.c (re_comp): Protoize.
1941 (re_exec): Fix return type.
1942 (regexec): Fix type of `ret'. (Bug#9203)
1943
476371c4
PE
19442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1945
e5d76069
PE
1946 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1947 This is needed if max-image-size is a floating-point number.
1948
9a79b20c
AS
19492011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1950
1951 * print.c (print_object): Print empty symbol as ##.
1952
1953 * lread.c (read1): Read ## as empty symbol.
1954
d8c2fa78
AA
19552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1956
1957 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1958 setting frame foreground color (Bug#9175).
1959 (x_set_background_color): Likewise.
1960
ffe57a7a
AA
1961 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1962 contents (Bug#9176).
1963 (EmacsTooltip -init): Remove bezels and add shadows to
1964 tooltip windows.
1965
bf3492a5
AA
1966 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1967 or scroll bar (Bug#8470).
1968
d55e9c53
AA
1969 * nsfont.m (nsfont_open): Remove assignment to voffset and
1970 unnecessary vars hshink, expand, hd, full_height, min_height.
1971 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1972
1973 * nsterm.h (nsfont_info): Remove voffset field.
1974
d8c2fa78 19752011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1976
1977 Implement strike-through and overline on NextStep (Bug#8863).
1978
1979 * nsfont.m (nsfont_open): Use underline position provided by font,
1980 instead of hard-coded value of 2.
1981 (nsfont_draw): Call ns_draw_text_decoration instead.
1982
1983 * nsterm.h: Add declaration for ns_draw_text_decoration.
1984
1985 * nsterm.m (ns_draw_text_decoration): New function for drawing
1986 underline, overline, and strike-through.
1987 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1988 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1989 accommodate underlining, etc.
4843aac3 1990
4cc60b9b
EZ
19912011-07-28 Eli Zaretskii <eliz@gnu.org>
1992
bc7ece87
EZ
1993 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1994 default.
4cc60b9b 1995
476371c4
PE
19962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1997
66606eea
PE
1998 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1999 Without this fix, if a signal arrives just after memory fills up,
2000 'malloc' might be invoked reentrantly.
2001
476371c4
PE
2002 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2003 In other words, assume that every image size is allowed, on non-X
2004 hosts. This assumption is probably wrong, but it lets Emacs compile.
2005
f3fcc40d
AS
20062011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2007
2008 * regex.c (re_iswctype): Convert return values to boolean.
2009
350c992f
EZ
20102011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2011
2012 * xdisp.c (compute_display_string_pos): Don't use cached display
2013 string position if the buffer had its restriction changed.
2014 (Bug#9184)
2015
5266b4bb
PE
20162011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2017
2018 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2019
2573a837 20202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2021
41f55ccd 2022 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2023
39e378da
PE
2024 * bidi.c: Integer size and overflow fixes.
2025 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2026 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2027 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2028 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2029 (bidi_find_other_level_edge):
2030 Use ptrdiff_t instead of EMACS_INT where either will do.
2031 This works better on 32-bit hosts configured --with-wide-int.
2032 (bidi_cache_ensure_space): Check for size-calculation overflow.
2033 Use % rather than repeated addition, for better worst-case speed.
2034 Don't set bidi_cache_size until after xrealloc returns, because it
2035 might not return.
2036 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2037 (bidi_cache_ensure_space): Also check that the bidi cache size
2038 does not exceed that of the largest Lisp string or buffer. See Eli
2039 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2040
5e927815
PE
2041 * alloc.c (__malloc_size_t): Remove.
2042 All uses replaced by size_t. See Andreas Schwab's note
2043 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2044
ca4aa935
PE
2045 * image.c: Improve checking for integer overflow.
2046 (check_image_size): Assume that f is nonnull, since
2047 it is always nonnull in practice. This is one less thing to
2048 worry about when checking for integer overflow later.
2049 (x_check_image_size): New function, which checks for integer
2050 overflow issues inside X.
2051 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2052 This removes the need for a memory_full check.
2053 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2054 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2055 (xbm_read_bitmap_data): Change locals back to 'int', since
2056 their values must fit in 'int'.
2057 (xpm_load_image, png_load, tiff_load):
2058 Invoke x_create_x_image_and_pixmap earlier,
2059 to avoid much needless work if the image is too large.
2060 (tiff_load): Treat overly large images as if
2061 x_create_x_image_and_pixmap failed, not as malloc failures.
2062 (gs_load): Use x_check_image_size.
2063
5f8f9cc2
PE
2064 * gtkutil.c: Omit integer casts.
2065 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2066 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2067
5adf60bc
PE
2068 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2069
c8907a93
PE
2070 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2071 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2072 would wrongly return t on a 64-bit host.
2073
e3c25c68
PE
2074 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2075 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2076 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2077 and therefore cause GCC to emit a bogus diagnostic in some cases.
2078
3f791afe
PE
2079 * image.c: Integer signedness and overflow and related fixes.
2080 This is not an exhaustive set of fixes, but it's time to
2081 record what I've got.
2082 (lookup_pixel_color, check_image_size): Remove redundant decls.
2083 (check_image_size): Don't assume that arbitrary EMACS_INT values
2084 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2085 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2086 (tiff_load, imagemagick_load_image):
2087 Check for overflow in size calculations.
2088 (x_create_x_image_and_pixmap): Remove unnecessary test for
2089 xmalloc returning NULL; that can't happen.
2090 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2091 (xpm_color_bucket): Use better integer hashing function.
2092 (xpm_cache_color): Don't possibly over-allocate memory.
2093 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2094 (gif_memory_source):
2095 Use ptrdiff_t, not int or size_t, to record sizes.
2096 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2097 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2098 either works, as we prefer signed integers.
2099 (tiff_read_from_memory, tiff_write_from_memory):
2100 Return tsize_t, not size_t, since that's what the TIFF API wants.
2101 (tiff_read_from_memory): Don't fail simply because the read would
2102 go past EOF; instead, return a short read.
2103 (tiff_load): Omit no-longer-needed casts.
2104 (Fimagemagick_types): Don't assume size fits into 'int'.
2105
3cc5a532
PE
2106 Improve hashing quality when configured --with-wide-int.
2107 * fns.c (hash_string): New function, taken from sxhash_string.
2108 Do not discard information about ASCII character case; this
2109 discarding is no longer needed.
2110 (sxhash-string): Use it. Change sig to match it. Caller changed.
2111 * lisp.h: Declare it.
2112 * lread.c (hash_string): Remove, since we now use fns.c's version.
2113 The fns.c version returns a wider integer if --with-wide-int is
2114 specified, so this should help the quality of the hashing a bit.
2115
b312a492
PE
2116 * emacs.c: Integer overflow minor fix.
2117 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2118 Define only if GNU_LINUX.
2119 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2120
dfd153ae
PE
2121 * dispnew.c: Integer signedness and overflow fixes.
2122 Remove unnecessary forward decls, that were a maintenance hassle.
2123 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2124 All uses changed.
2125 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2126 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2127 (prepare_desired_row, line_draw_cost):
2128 Use int, not unsigned, where either works.
2129 (save_current_matrix, restore_current_matrix):
2130 Use ptrdiff_t, not size_t, where either works.
2131 (init_display): Check for overflow more accurately, and without
2132 relying on undefined behavior.
2133
a81d11a3
PE
2134 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2135 Remove, replacing with the new symbols in lisp.h. All uses changed.
2136 * fileio.c (make_temp_name):
2137 * filelock.c (lock_file_1, lock_file):
2138 * xdisp.c (message_dolog):
2139 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2140 Use pMd etc. instead.
2141 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2142 replacing the pWIDE etc. symbols removed from editfns.c.
2143
3300e6fd
PE
2144 * keyboard.h (num_input_events): Now uintmax_t.
2145 This is (very slightly) less likely to mess up due to wraparound.
2146 All uses changed.
2147
fd05c7e9
PE
2148 * buffer.c: Integer signedness fixes.
2149 (alloc_buffer_text, enlarge_buffer_text):
2150 Use ptrdiff_t rather than size_t when either will do, as we prefer
2151 signed integers.
2152
903fe15d
PE
2153 * alloc.c: Integer signedness and overflow fixes.
2154 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2155 (__malloc_size_t): Default to size_t, not to int.
2156 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2157 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2158 Prefer ptrdiff_t to size_t when either would do, as we prefer
2159 signed integers.
2160 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2161 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2162 Now const. Initialize with values that are in range even if char
2163 is signed.
2164 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2165 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2166 These functions do the right thing with sizes > 2**32.
2167 (check_depth): Now ptrdiff_t, not int.
2168 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2169 Adjust to new way of storing sizes. Check for size overflow bugs
2170 in rest of code.
2171 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2172 slightly wrong anyway, as it missed one instance of
2173 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2174 (refill_memory_reserve): Omit needless cast to size_t.
2175 (mark_object_loop_halt): Mark as externally visible.
2176
ac82cc6a
PE
2177 * xselect.c: Integer signedness and overflow fixes.
2178 (Fx_register_dnd_atom, x_handle_dnd_message):
2179 Use ptrdiff_t, not size_t, since we prefer signed.
2180 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2181 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2182 x_dnd_atoms_size and x_dnd_atoms_length.
2183
c2d1e36d
PE
2184 * doprnt.c: Prefer signed to unsigned when either works.
2185 * eval.c (verror):
2186 * doprnt.c (doprnt):
2187 * lisp.h (doprnt):
2188 * xdisp.c (vmessage):
2189 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2190 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2191 prefer signed arithmetic to avoid comparison confusion.
2192 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2193 but is a bit tricky.
2194
0e926e56
PE
2195 Assume freestanding C89 headers, string.h, stdlib.h.
2196 * data.c, doprnt.c, floatfns.c, print.c:
2197 Include float.h unconditionally.
2198 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2199 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2200 * regex.c: Likewise for stddef.h, string.h.
2201 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2202 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2203 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2204 (STDC_HEADERS): Remove obsolete defines.
2205 * sysdep.c: Include limits.h unconditionally.
2206
9cfdb3ec
PE
2207 Assume support for memcmp, memcpy, memmove, memset.
2208 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2209 * regex.c (memcmp, memcpy):
2210 Remove; we assume C89 now.
2211
2212 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2213 (__malloc_safe_bcopy): Remove; no longer needed.
2214
cf950e6b 2215 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2216 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2217 well either way, and we prefer signed to unsigned.
2218
dbf38e02
LMI
22192011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2220
2221 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2222 closes the connection while we're reading (bug#9182).
2223
d6f0886c 22242011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2225
d6f0886c
JD
2226 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2227 are specified (Bug#9168).
24e0f6b1 2228
2eb1f9e6
PE
22292011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2232 Found by GCC static checking and --with-wide-int on a 32-bit host.
2233
22381272 22342011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2235
2236 * xdisp.c (compute_display_string_pos): Fix logic of caching
2237 previous display string position. Initialize cached_prev_pos to
2238 -1. Fixes slow-down at the beginning of a buffer.
2239
f25e39b4
EZ
22402011-07-24 Eli Zaretskii <eliz@gnu.org>
2241
2242 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2243 for attrs[LFACE_FONTSET_INDEX].
2244
04c4b52e
PE
22452011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2246
2247 * xml.c (parse_region): Remove unused local
2248 that was recently introduced.
2249
c1734fbd
EZ
22502011-07-23 Eli Zaretskii <eliz@gnu.org>
2251
be18c5a5
EZ
2252 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2253 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2254
c1734fbd
EZ
2255 * xdisp.c (move_it_in_display_line_to): Record the best matching
2256 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2257 exit if none of the characters scanned was an exact match.
2258 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2259 when exact match is impossible due to invisible text, and the
2260 lines are truncated.
2261
a258d627
JD
22622011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2263
2264 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2265 for OSX >= 10.7.
2266
b6d5a689
EZ
22672011-07-22 Eli Zaretskii <eliz@gnu.org>
2268
0f74f785
EZ
2269 Fix a significant slow-down of cursor motion with C-n, C-p,
2270 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2271 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2272 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2273 (next_element_from_buffer): Call compute_stop_pos_backwards to
2274 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2275 base_level_stop.
2276 (reseat): Don't look for prev_stop, as that could mean a very long
2277 run.
2278 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2279 <cached_disp_overlay_modiff>: Cache for last found display string
2280 position.
551918c1 2281 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2282 about the same buffer in the same area of character positions, and
2283 the buffer wasn't changed since the time the display string
2284 position was cached.
551918c1 2285
b2d0c91a
EZ
22862011-07-22 Eli Zaretskii <eliz@gnu.org>
2287
2288 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2289 is an integer, which is important for empty lines. (Bug#9149)
2290
043604ee
CY
22912011-07-22 Chong Yidong <cyd@stupidchicken.com>
2292
2293 * frame.c (Fmodify_frame_parameters): In tty case, update the
2294 default face if necessary (Bug#4238).
2295
da4adb04
CY
22962011-07-21 Chong Yidong <cyd@stupidchicken.com>
2297
2298 * editfns.c (Fstring_to_char): No need to explain what a character
2299 is in the docstring (Bug#6576).
2300
9abd0532
LMI
23012011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2302
2303 * xml.c (parse_region): Make sure we always return a tree.
2304
36881d16
HK
23052011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2306
2307 * xml.c (parse_region): If a document contains only comments,
2308 return that, too.
2309
1e98674d
LMI
23102011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2311
2312 * xml.c (make_dom): Return comments, too.
2313
590bd467
PE
23142011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2315
2316 Port to OpenBSD.
2317 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2318 and the surrounding thread.
2319 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2320 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2321 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2322 timer goes off.
2323 * s/openbsd.h (BROKEN_SIGIO): Define.
2324 * unexelf.c (unexec) [__OpenBSD__]:
2325 Don't update the .mdebug section of the Alpha COFF symbol table.
2326
f41628b2
LMI
23272011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2328
2329 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2330 (bug#8460).
2331
b59b67c5
PE
23322011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2333
15e3a074
PE
2334 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2335 This fixes some race conditions on the permissions of any newly
2336 created file.
2337
41bed37d
PE
2338 * alloc.c (valid_pointer_p): Use pipe, not open.
2339 This fixes some permissions issues when debugging.
2340
b59b67c5
PE
2341 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2342 If fchown fails to set both uid and gid, try to set just gid,
2343 as that is sometimes allowed. Adjust the file's mode to eliminate
2344 setuid or setgid bits that are inappropriate if fchown fails.
2345
925a6be7
SM
23462011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2347
2348 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2349 to compare Lisp_Objects.
2350 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2351 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2352 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2353
52968808
AS
23542011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2355
0a6a104b
AS
2356 * lread.c (read_integer): Unread even EOF character.
2357 (read1): Likewise. Properly record start position of symbol.
2358
52968808
AS
2359 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2360 symbol character follows.
2361
9e381cdd
PE
23622011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2363
2364 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2365 This works around a problem with the previous change to Fcopy_file.
2366 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2367 and without this change, GCC might complain about discarding
2368 fchown's return value.
2369
b5641435
JB
23702011-07-16 Juanma Barranquero <lekktu@gmail.com>
2371
2372 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2373
a8031457
PE
23742011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2375
2376 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2377
dd889327
LMI
23782011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2379
750c33f7
LMI
2380 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2381 it's used from the C level.
2382
dd889327
LMI
2383 * process.c: Use the same condition for POLL_FOR_INPUT in both
2384 keyboard.c and process.c (bug#1858).
2385
87e86684
LM
23862011-07-09 Lawrence Mitchell <wence@gmx.li>
2387
2388 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2389 (Fgnutls_boot): Use it.
2390
64348f40
AS
23912011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2392
2393 * doc.c (Fsubstitute_command_keys): Revert last change.
2394
1d698799
LMI
23952011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2396
f863868c
LMI
2397 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2398 quotes the next character, and doesn't affect other longer
2399 sequences (bug#8935).
2400
1d698799
LMI
2401 * lread.c (syms_of_lread): Clarify that is isn't only
2402 `eval-buffer' and `eval-defun' that's affected by
2403 `lexical-binding' (bug#8460).
2404
aa4b6df6
EZ
24052011-07-15 Eli Zaretskii <eliz@gnu.org>
2406
2407 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2408 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2409
5d856da6
PE
24102011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2411
ad6042bb
PE
2412 Fix minor problems found by static checking.
2413 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2414 (elsz): Now a signed constant, not a size_t var. We prefer signed
2415 types to unsigned, to avoid integer comparison confusion. Without
2416 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2417 "cannot optimize loop, the loop counter may overflow", a symptom
2418 of the confusion.
f00bbb22 2419 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2420 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2421
6468f31c
LMI
24222011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2423
49080b10
LMI
2424 * search.c (Fre_search_backward): Mention `case-fold-search' in
2425 all the re_search_* functions (bug#8138).
2426
6468f31c
LMI
2427 * keyboard.c (Fopen_dribble_file): Document when the file is
2428 closed (bug#8056).
2429
c965adc5
EZ
24302011-07-14 Eli Zaretskii <eliz@gnu.org>
2431
df9733bf
EZ
2432 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2433 bidi_cache_idx.
2434
0bb23927
EZ
2435 Support bidi reordering of display and overlay strings.
2436 * xdisp.c (compute_display_string_pos)
2437 (compute_display_string_end): Accept additional argument STRING.
2438 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2439 (reseat_to_string): Initialize bidi_it->string.s and
2440 bidi_it->string.schars.
2441 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2442 NULL (avoids a crash in bidi_paragraph_init).
2443 Initialize itb.string.lstring.
0bb23927
EZ
2444 (init_iterator): Call bidi_init_it only of a valid
2445 buffer position was specified. Initialize paragraph_embedding to
2446 L2R.
2447 (reseat_to_string): Initialize the bidi iterator.
2448 (display_string): If we need to ignore text properties of
2449 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2450 original value of -1 will not work with bidi.)
2451 (compute_display_string_pos): First arg is now struct
2452 `text_pos *'; all callers changed. Support display properties on
2453 Lisp strings.
2454 (compute_display_string_end): Support display properties on Lisp
2455 strings.
2456 (init_iterator, reseat_1, reseat_to_string): Initialize the
2457 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2458 when iterating on a string not from display properties).
640c8776
SM
2459 (compute_display_string_pos, compute_display_string_end):
2460 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2461 arrow keys.
2462 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2463 base_level_stop; instead, set base_level_stop to BEGV.
2464 Fixes crashes in vertical-motion.
0bb23927
EZ
2465 (next_element_from_buffer): Improve commentary for when
2466 the iterator is before prev_stop.
2467 (init_iterator): Initialize bidi_p from the default value of
2468 bidi-display-reordering, not from buffer-local value. Use the
2469 buffer-local value only if initializing for buffer iteration.
2470 (handle_invisible_prop): Support invisible properties on strings
2471 that are being bidi-reordered.
2472 (set_iterator_to_next): Support bidi reordering of C strings and
2473 Lisp strings.
2474 (next_element_from_string): Support bidi reordering of Lisp
2475 strings.
2476 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2477 (display_string): Support display of R2L glyph rows.
2478 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2479 (init_iterator): Don't initialize it->bidi_p for strings
2480 here.
2481 (reseat_to_string): Initialize it->bidi_p for strings here.
2482 (next_element_from_string, next_element_from_c_string)
2483 (next_element_from_buffer): Add xassert's for correspondence
2484 between IT's object being iterated and it->bidi_it.string
2485 structure.
2486 (face_before_or_after_it_pos): Support bidi iteration.
2487 (next_element_from_c_string): Handle the case of the first string
2488 character that is not the first one in the visual order.
2489 (get_visually_first_element): New function, refactored from common
2490 parts of next_element_from_buffer, next_element_from_string, and
2491 next_element_from_c_string.
2492 (tool_bar_lines_needed, redisplay_tool_bar)
2493 (display_menu_bar): Force left-to-right direction. Add a FIXME
2494 comment for making that be controlled by a user option.
2495 (push_it, pop_it): Save and restore the state of the
2496 bidi iterator. Save and restore the bidi_p flag.
2497 (pop_it): Iterate out of display property for string iteration as
2498 well.
2499 (iterate_out_of_display_property): Support iteration over strings.
2500 (handle_single_display_spec): Set up it->bidi_it for iteration
2501 over a display string, and call bidi_init_it.
2502 (handle_single_display_spec, next_overlay_string)
2503 (get_overlay_strings_1, push_display_prop): Set up the bidi
2504 iterator for displaying display or overlay strings.
2505 (forward_to_next_line_start): Don't use the shortcut if
2506 bidi-iterating.
2507 (back_to_previous_visible_line_start): If handle_display_prop
2508 pushed the iterator stack, restore the internal state of the bidi
2509 iterator by calling bidi_pop_it same number of times.
2510 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2511 and we are bidi-iterating, don't decrement the iterator position;
2512 instead, set the first_elt flag in the bidi iterator, to produce
2513 the same effect.
2514 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2515 (push_display_prop): xassert that we are iterating a buffer.
2516 (push_it, pop_it): Save and restore paragraph_embedding member.
2517 (handle_single_display_spec, next_overlay_string)
2518 (get_overlay_strings_1, reseat_1, reseat_to_string)
2519 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2520 correctly. Don't assume unibyte strings are not bidi-reordered.
2521 (compute_display_string_pos)
2522 (compute_display_string_end): Fix handling the case of C string.
2523 (push_it, pop_it): Save and restore from_disp_prop_p.
2524 (handle_single_display_spec, push_display_prop): Set the
2525 from_disp_prop_p flag.
2526 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2527 (pop_it): Call iterate_out_of_display_property only if we are
2528 popping after iteration over a string that came from a display
2529 property. Fix a typo in popping stretch info. Add an assertion
2530 for verifying that the iterator position is in sync with the bidi
2531 iterator.
2532 (handle_single_display_spec, get_overlay_strings_1)
2533 (push_display_prop): Fix initialization of paragraph direction for
2534 string when that of the parent object is not yet determined.
2535 (reseat_1): Call bidi_init_it to resync the bidi
2536 iterator with IT's position. (Bug#7616)
2537 (find_row_edges): If ROW->start.pos gives position
2538 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2539 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2540 Reset the from_disp_prop_p flag.
2541 (SAVE_IT, RESTORE_IT): New macros.
2542 (pos_visible_p, face_before_or_after_it_pos)
2543 (back_to_previous_visible_line_start)
2544 (move_it_in_display_line_to, move_it_in_display_line)
2545 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2546 (try_scrolling, redisplay_window, display_line): Use them when
2547 saving a temporary copy of the iterator and restoring it back.
2548 (back_to_previous_visible_line_start, reseat_1)
2549 (init_iterator): Empty the bidi cache "stack".
2550 (move_it_in_display_line_to): If iterator ended up at
2551 EOL, but we never saw any buffer positions smaller than
2552 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2553 motion in bidi-reordered lines.
2554 (move_it_in_display_line_to): Record prev_method and prev_pos
2555 immediately before the call to set_iterator_to_next. Fixes cursor
2556 motion in bidi-reordered lines with stretch glyphs and strings
2557 displayed in margins. (Bug#8133) (Bug#8867)
2558 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2559 TO_CHARPOS.
640c8776
SM
2560 (pos_visible_p): Support positions in bidi-reordered lines.
2561 Save and restore bidi cache.
0bb23927
EZ
2562
2563 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2564 (bidi_paragraph_info): Delete unused struct.
2565 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2566 (bidi_cache_start): New variable.
2567 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2568 to zero.
2569 (bidi_cache_fetch_state, bidi_cache_search)
2570 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2571 (bidi_cache_find, bidi_peek_at_next_level)
2572 (bidi_level_of_next_char, bidi_find_other_level_edge)
2573 (bidi_move_to_visually_next): Compare cache index with
2574 bidi_cache_start rather than with zero.
2575 (bidi_fetch_char): Accept new argument STRING; all callers
2576 changed. Support iteration over a string. Support strings with
2577 display properties. Support unibyte strings. Fix the type of
2578 `len' according to what STRING_CHAR_AND_LENGTH expects.
2579 (bidi_paragraph_init, bidi_resolve_explicit_1)
2580 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2581 (bidi_level_of_next_char, bidi_move_to_visually_next):
2582 Support iteration over a string.
0bb23927
EZ
2583 (bidi_set_sor_type, bidi_resolve_explicit_1)
2584 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2585 can now be zero (for strings); special values 0 and -1 were
2586 changed to -1 and -2, respectively.
2587 (bidi_char_at_pos): New function.
2588 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2589 Call it instead of FETCH_MULTIBYTE_CHAR.
2590 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2591 initialized to valid values.
2592 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2593 values.
2594 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2595 the test for valid cached positions. Fix the logic for looking up
2596 the sentinel state in the cache. GCPRO the Lisp string we are
2597 iterating.
2598 (bidi_push_it, bidi_pop_it): New functions.
2599 (bidi_initialize): Initialize the bidi cache start stack pointer.
2600 (bidi_cache_ensure_space): New function, refactored from part of
2601 bidi_cache_iterator_state. Don't assume the required size is just
2602 one BIDI_CACHE_CHUNK away.
2603 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2604 (bidi_count_bytes, bidi_char_at_pos): New functions.
2605 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2606 always valid if bidi_cache_idx is valid.
2607 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2608 is valid if it's going to be used.
2609 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2610 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2611 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2612 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2613 (bidi_find_other_level_edge, bidi_cache_start_stack):
2614 All variables related to cache indices are now EMACS_INT.
c965adc5 2615
0bb23927
EZ
2616 * dispextern.h (struct bidi_string_data): New structure.
2617 (struct bidi_it): New member `string'. Make flag members be 1-bit
2618 fields, and put them last in the struct.
640c8776
SM
2619 (compute_display_string_pos, compute_display_string_end):
2620 Update prototypes.
0bb23927
EZ
2621 (bidi_push_it, bidi_pop_it): Add prototypes.
2622 (struct iterator_stack_entry): New members bidi_p,
2623 paragraph_embedding, and from_disp_prop_p.
2624 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2625 (bidi_shelve_cache, bidi_unshelve_cache):
2626 Declare prototypes.
0bb23927
EZ
2627
2628 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2629 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2630 and vector-like objects.
2631
2632 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2633 cache around display iteration.
2634
2635 * window.c (Fwindow_end, window_scroll_pixel_based)
2636 (displayed_window_lines, Frecenter): Save and restore the bidi
2637 cache around display iteration.
2638
3bbd2265
LMI
26392011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2640
2641 * editfns.c (Fdelete_region): Clarify the use of the named
2642 parameters (bug#6788).
2643
adc47434
MR
26442011-07-14 Martin Rudalics <rudalics@gmx.at>
2645
2646 * indent.c (Fvertical_motion): Set and restore w->pointm when
2647 saving and restoring the window's buffer (Bug#9006).
2648
837c31f8
LMI
26492011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2650
2651 * editfns.c (Fstring_to_char): Clarify just what is returned
2652 (bug#6576). Text by Eli Zaretskii.
2653
ac389d0c
JB
26542011-07-13 Juanma Barranquero <lekktu@gmail.com>
2655
2656 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2657
0be0ce47
EZ
26582011-07-13 Eli Zaretskii <eliz@gnu.org>
2659
2660 * buffer.c (mmap_find): Fix a typo.
2661
cd18e7e3
JB
26622011-07-13 Johan Bockgård <bojohan@gnu.org>
2663
2664 Fix execution of x selection hooks.
2665 * xselect.c (Qx_lost_selection_functions)
2666 (Qx_sent_selection_functions): New vars.
2667 (syms_of_xselect): DEFSYM them.
2668 (x_handle_selection_request): Pass Qx_sent_selection_functions
2669 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2670 (x_handle_selection_clear,x_clear_frame_selections):
2671 Pass Qx_lost_selection_functions rather than
2672 Vx_lost_selection_functions to Frun_hook_with_args.
2673
47ea7f44
PE
26742011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2675
ac389d0c 2676 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2677 The old code sometimes used this field without initializing it.
2678
47ea7f44
PE
2679 * alloc.c (gc_sweep): Don't read past end of array.
2680 In theory, the old code could also have corrupted Emacs internals,
2681 though it'd be very unlikely.
2682
bc985c87
AS
26832011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2684
2685 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2686 argument. (Bug#4026)
bc985c87 2687
0cf34688
LMI
26882011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2689
b3dadd76
LMI
2690 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2691 key" (bug#4257).
2692
0cf34688
LMI
2693 * window.c (Fset_window_start): Doc fix (bug#4199).
2694 (Fset_window_hscroll): Ditto.
2695
270768cd
PE
26962011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2697
077e3dda 2698 Fix minor new problems caught by GCC 4.6.1.
270768cd 2699 * term.c (init_tty): Remove unused local.
490011a6 2700 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2701 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2702 not used otherwise.
270768cd 2703
b1f58454
CY
27042011-07-12 Chong Yidong <cyd@stupidchicken.com>
2705
2706 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2707
22b9578d
LMI
27082011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2709
6e70ab07
LMI
2710 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2711 are the mini-buffer and the echo area (bug#3320).
2712
22b9578d
LMI
2713 * term.c (init_tty): Remove support for supdup, c10 and perq
2714 terminals, which are no longer supported (bug#1482).
2715
8974cc9f
JB
27162011-07-10 Johan Bockgård <bojohan@gnu.org>
2717
2718 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2719
a560d974
JD
27202011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2721
2722 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2723 for non-popups (Bug#3642).
2724
1dae0f0a
AS
27252011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2726
268c2c36 2727 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2728 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2729 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2730 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2731 * data.c (fmod): Likewise.
2732 * dispnew.c (swap_glyphs_in_rows): Likewise.
2733 * emacs.c (memory_warning_signal): Likewise.
2734 * floatfns.c (float_error): Likewise.
2735 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2736 (otf_open, font_otf_capability, generate_otf_features)
2737 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2738 Likewise.
2739 * image.c (pbm_read_file): Likewise.
2740 * indent.c (string_display_width): Likewise.
2741 * intervals.c (check_for_interval, search_for_interval)
2742 (inc_interval_count, count_intervals, root_interval)
2743 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2744 * lread.c (defalias): Likewise.
268c2c36 2745 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2746 * regex.c (set_image_of_range_1, set_image_of_range)
2747 (regex_grow_registers): Likewise.
2748 * sysdep.c (strerror): Likewise.
2749 * termcap.c (valid_filename_p, tprint, main): Likewise.
2750 * tparam.c (main): Likewise.
2751 * unexhp9k800.c (run_time_remap, save_data_space)
2752 (update_file_ptrs, read_header, write_header, calculate_checksum)
2753 (copy_file, copy_rest, display_header): Likewise.
2754 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2755 Likewise.
2756 * xdisp.c (check_it): Likewise.
2757 * xfaces.c (register_color, unregister_color, unregister_colors):
2758 Likewise.
2759 * xfns.c (print_fontset_result): Likewise.
2760 * xrdb.c (member, fatal, main): Likewise.
2761
99033785
PE
27622011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2763
2764 Fix minor problems found by static checking (Bug#9031).
2765 * chartab.c (char_table_set_range, map_sub_char_table):
2766 Remove unused locals.
2767 (uniprop_table): Now static.
2768 * composite.c (_work_char): Remove unused static var.
2769
9cb2ac56
JB
27702011-07-09 Juanma Barranquero <lekktu@gmail.com>
2771
2772 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2773
f25661f0
JD
27742011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2775
2776 * gtkutil.c (qttip_cb): Remove code without function.
2777
8278c4fe
EZ
27782011-07-09 Eli Zaretskii <eliz@gnu.org>
2779
2780 * w32.c (pthread_sigmask): New stub.
2781
1692ae2d 27822011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2783
8a6ebd58 2784 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2785 sigprocmask is portable only for single-threaded applications, and
2786 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2787 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2788 (LIBES): Use it.
2789 * callproc.c (Fcall_process):
2790 * process.c (create_process):
2791 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2792 Use pthread_sigmask, not sigprocmask.
123403e4 2793
1b854618
JD
27942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2795
2796 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2797 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2798 wrong (Bug#8591).
2799
3fe4b549
JD
28002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2801
0ce7e563
JD
2802 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2803 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2804 (xg_hide_tooltip): Fix comment.
2805
3fe4b549
JD
2806 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2807 in registerServicesMenuSendTypes.
2808 (validRequestorForSendType): Don't check ns_return_types.
2809
2810 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2811 ns_return_type.
2812
5df75e47
JR
28132011-07-08 Jason Rumney <jasonr@gnu.org>
2814
2815 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2816 frame struct members of non-existent frames (Bug#6284).
2817
699c10bd
JD
28182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2819
4393663b
JD
2820 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2821 variable firstTime not needed on OSX >= 10.6.
2822 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2823 >= 10.5. Use setKnobProportion, setDoubleValue.
2824
2825 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2826 (MAC_OS_X_VERSION_10_5): Define if not defined.
2827 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2828 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2829 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2830
2831 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2832 cString and lossyCString on OSX >= 10.4
2833
2834 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2835 sizeToFit on OSX >= 10.2.
2836
2837 * nsimage.m (allocInitFromFile): Don't use deprecated method
2838 bestRepresentationForDevice on OSX >= 10.6.
2839
2840 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2841 to avoid warning.
2842
2843 * emacs.c: Declare unexec_init_emacs_zone.
2844
a63e0781
JD
2845 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2846
699c10bd
JD
2847 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2848
2849 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2850 on svcsMenu (Bug#8842).
2851
2852 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2853 ns_return_types.
2854 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2855
2856 * nsterm.m (QUTF8_STRING): Declare.
2857 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2858 (validRequestorForSendType): Return type is (id).
2859 Change indexOfObjectIdenticalTo to indexOfObject.
2860 Check if we have local selection before returning self (Bug#8842).
2861 (writeSelectionToPasteboard): Put local selection into paste board
2862 if we have a local selection (Bug#8842).
2863 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2864
2865 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2866 (ns_get_local_selection): Declare.
2867
54e10184
LMI
28682011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2869
9888ff71
LMI
2870 * keymap.c (describe_map_tree): Don't insert a double newline at
2871 the end of the buffer (bug#1169) and return whether we inserted
2872 something.
2873
54e10184
LMI
2874 * callint.c (Fcall_interactively): Change "reading args" to
2875 "providing args" to try to clarify what it does (bug#1010).
2876
15fa4783
KH
28772011-07-07 Kenichi Handa <handa@m17n.org>
2878
2879 * composite.c (composition_compute_stop_pos): Ignore a static
2880 composition starting before CHARPOS (Bug#8915).
2881
2882 * xdisp.c (handle_composition_prop): Likewise.
2883
a8815b00
EZ
28842011-07-07 Eli Zaretskii <eliz@gnu.org>
2885
2886 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2887 (Bug#9015)
2888
ef7b981d 28892011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2890
2891 * character.h (unicode_category_t): New enum type.
2892
2893 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2894 (Qchar_code_property_table): New variable.
2895 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2896 (UNIPROP_COMPRESSED_FORM_P): New macros.
2897 (char_table_ascii): Uncompress the compressed values.
2898 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2899 Uncompress the compressed values.
ac389d0c 2900 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2901 (char_table_ref_and_range): Uncompress the compressed values.
2902 (sub_char_table_set): New arg is_uniprop. Callers changed.
2903 Uncompress the compressed values.
2904 (sub_char_table_set_range): Args changed. Callers changed.
2905 (char_table_set_range): Adjuted for the above change.
2906 (map_sub_char_table): Delete args default_val and parent. Add arg
2907 top. Give decoded values to a Lisp function.
640c8776 2908 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2909 values to a Lisp function. Gcpro more variables.
2910 (uniprop_table_uncompress)
2911 (uniprop_decode_value_run_length): New functions.
2912 (uniprop_decoder, uniprop_decoder_count): New variables.
2913 (uniprop_get_decoder, uniprop_encode_value_character)
2914 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2915 New functions.
2916 (uniprop_encoder, uniprop_encoder_count): New variables.
2917 (uniprop_get_encoder, uniprop_table)
2918 (Funicode_property_table_internal, Fget_unicode_property_internal)
2919 (Fput_unicode_property_internal): New functions.
2920 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2921 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2922 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2923 char-code-property-alist.
2924
640c8776 2925 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2926 Vunicode_category_table.
2927
640c8776 2928 * font.c (font_range): Adjust for the change of
c805dec0
KH
2929 Vunicode_category_table.
2930
76b397fb
DN
29312011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2932
2933 * m/iris4d.h: Remove file, move contents ...
2934 * s/irix6-5.h: ... here.
2935
22b4128e
PE
29362011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2937
2938 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2939 * alloc.c (mark_buffer):
2940 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2941 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2942 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2943 This isn't true in general, and it's particularly not true
2944 if Emacs is configured with --with-wide-int.
2945 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2946 New macros, used in the buffer.c change.
2947
869795d6
JD
29482011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2949
2950 * xsettings.c: Use both GConf and GSettings if both are available.
2951 (store_config_changed_event): Add comment.
2952 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2953 (store_tool_bar_style_changed): New functions.
5e617bc2 2954 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2955 (struct xsettings): Move font inside HAVE_XFT.
2956 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2957 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2958 Move inside HAVE_XFT.
640c8776 2959 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2960 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2961 also.
2962 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2963 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2964 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2965 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2966 (parse_settings): Move check for font inside HAVE_XFT.
2967 (read_settings, apply_xft_settings): Add comment.
2968 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2969 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2970 call store_font_name_changed.
2971 (xft_settings_event): Add comment.
2972 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2973 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2974 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2975 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2976 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2977 (xsettings_get_system_font, xsettings_get_system_normal_font):
2978 Add comment.
869795d6 2979
d8ed26bd
PE
29802011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2981
2982 Random fixes. E.g., (random) never returned negative values.
2983 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2984 subseconds part to the entropy, as that's a bit more random.
2985 Prefer signed to unsigned, since the signedness doesn't matter and
2986 in general we prefer signed. When given a limit, use a
2987 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2988 latter isn't right if USE_2_TAGS_FOR_INTS.
2989 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2990 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2991
cabf1cac
SM
29922011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2993
2994 * textprop.c (text_property_stickiness):
2995 Obey Vtext_property_default_nonsticky.
2996 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2997 * w32fns.c (syms_of_w32fns):
2998 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2999
6e9b2be9
PE
30002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3001
3002 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3003 This is more efficient than Ffile_directory_p and avoids a minor race.
3004
90186c68
LMI
30052011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3006
7c301272
LMI
3007 * buffer.c (Foverlay_put): Say what the return value is
3008 (bug#7835).
3009
c4f2d8d4
LMI
3010 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3011 is a directory before asking whether to use the file name
3012 (bug#7564).
ad637907
LMI
3013 (barf_or_query_if_file_exists): Make the "File is a directory"
3014 error be more correct.
c4f2d8d4 3015
90186c68
LMI
3016 * fns.c (Frequire): Remove the mention of the .gz files, since
3017 that's installation-specific, but keep the mention of
3018 `get-load-suffixes'.
3019
da64016e
PE
30202011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3021
3022 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3023 Report string overflow if the output is too long.
3024
7d47b580
JB
30252011-07-04 Juanma Barranquero <lekktu@gmail.com>
3026
a555cb87
JB
3027 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3028 (syms_of_gnutls): Remove duplicate DEFSYM for
3029 Qgnutls_bootprop_verify_hostname_error, an error for
3030 Qgnutls_bootprop_verify_error (which is no longer used).
3031
7d47b580
JB
3032 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3033 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3034 Also (re)move comments that are misplaced or no longer relevant.
3035
1e49bfab
LMI
30362011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3037
3038 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3039
1485f4c0
CY
30402011-07-03 Chong Yidong <cyd@stupidchicken.com>
3041
3042 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3043 and background color parameters if they have been changed.
3044
a9ab721e
LMI
30452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3046
3047 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3048
cf7cff57
PE
30492011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3050
2e13213d
PE
3051 * xsettings.c (SYSTEM_FONT): Define only when used.
3052 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3053
cf7cff57
PE
3054 * keymap.c (access_keymap_1): Now static.
3055
7a8e04f7
CY
30562011-07-02 Chong Yidong <cyd@stupidchicken.com>
3057
3058 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3059 leave any prefix arg for the up event (Bug#1586).
3060
61352f62
LMI
30612011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3062
69bb1ef7
LMI
3063 * lread.c (syms_of_lread): Mention single symbols defined by
3064 `defvar' or `defconst' (bug#7154).
3065
61352f62 3066 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3067 (Frequire): Mention get-load-suffixes.
61352f62 3068
28545e04
MR
30692011-07-02 Martin Rudalics <rudalics@gmx.at>
3070
3071 * window.h (window): Remove clone_number slot.
3072 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3073 Remove.
3074 (make_parent_window, make_window, saved_window)
3075 (Fset_window_configuration, save_window_save): Don't deal with
3076 clone numbers.
3077 * buffer.c (Qclone_number): Remove declaration.
3078 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3079
3349e122
SM
30802011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3081
3082 Add multiple inheritance to keymaps.
3083 * keymap.c (Fmake_composed_keymap): New function.
3084 (Fset_keymap_parent): Simplify.
3085 (fix_submap_inheritance): Remove.
3086 (access_keymap_1): New function extracted from access_keymap to handle
3087 embedded parents and handle lists of maps.
3088 (access_keymap): Use it.
3089 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3090 (Fcopy_keymap): Handle embedded parents.
3091 (Fcommand_remapping, define_as_prefix): Simplify.
3092 (Fkey_binding): Simplify.
3093 (syms_of_keymap): Move minibuffer-local-completion-map,
3094 minibuffer-local-filename-completion-map,
3095 minibuffer-local-must-match-map, and
3096 minibuffer-local-filename-must-match-map to Elisp.
3097 (syms_of_keymap): Defsubr make-composed-keymap.
3098 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3099 (parse_menu_item): Trivial simplification.
3100
3279eb87
GM
31012011-07-01 Glenn Morris <rgm@gnu.org>
3102
3103 * Makefile.in (SETTINGS_LIBS): Fix typo.
3104
4550efdf
KI
31052011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3106
3107 * coding.c (Fencode_coding_string): Record the last coding system
3108 used, as the function doc string says (bug#8738).
3109
0949d2b6
JD
31102011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3111
3112 * xsettings.c (store_monospaced_changed): Take new font as arg and
3113 check for change against current_mono_font.
3114 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3115 (emacs_settings_constructor, emacs_settings_get_property)
3116 (emacs_settings_set_property, emacs_settings_class_init)
3117 (emacs_settings_init, gsettings_obj): Remove.
3118 (something_changedCB): New function for HAVE_GSETTINGS.
3119 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3120 with value as argument.
3121 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3122 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3123 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3124 "changed".
3125
3126 * xgselect.c: Add defined (HAVE_GSETTINGS).
3127 (xgselect_initialize): Ditto.
3128
3129 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3130 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3131 xg_select.
3132
bbc6b304
PE
31332011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3134
3135 * eval.c (struct backtrace): Simplify and port the data structure.
3136 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3137 signed bit field, as this assumption is not portable and it makes
3138 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3139 "char debug_on_exit : 1" as this is not portable either; instead,
3140 use the portable "unsigned int debug_on_exit : 1". Remove unused
3141 member evalargs. Remove obsolete comments about cc bombing out.
3142
9851bfc5
JD
31432011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3144
51bb811f 3145 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3146 Let HAVE_GSETTINGS override HAVE_GCONF.
3147 (store_monospaced_changed): New function.
3148 (EMACS_SETTINGS): A new type derived from GObject to handle
3149 GSettings notifications.
3150 (emacs_settings_constructor, emacs_settings_get_property)
3151 (emacs_settings_set_property, emacs_settings_class_init):
3152 New functions.
3153 (gsettings_client, gsettings_obj): New variables.
3154 (GSETTINGS_SCHEMA): New define.
3155 (something_changedCB): Call store_monospaced_changed.
3156 (init_gsettings): New function.
3157 (xsettings_initialize): Call init_gsettings.
3158 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3159 to NULL.
3160
640c8776 3161 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3162 GCONF_CFLAGS/LIBS.
3163
5386012d
MR
31642011-06-29 Martin Rudalics <rudalics@gmx.at>
3165
3166 * window.c (resize_root_window, grow_mini_window)
3167 (shrink_mini_window): Rename Qresize_root_window to
3168 Qwindow_resize_root_window and Qresize_root_window_vertically to
3169 Qwindow_resize_root_window_vertically.
3170
f13e0b08
PE
31712011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3172
3173 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3174
94515237
JB
31752011-06-27 Juanma Barranquero <lekktu@gmail.com>
3176
3177 * makefile.w32-in: Redesign dependencies so they reflect more
3178 clearly which files are directly included by each source file,
3179 and not through other includes.
3180
e43b6e43
MR
31812011-06-27 Martin Rudalics <rudalics@gmx.at>
3182
3183 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3184 (sort_overlays, overlay_strings): When an overlay's clone number
3185 matches the window's clone number process the overlay even if
3186 the overlay's window property doesn't match the current window.
3187
d68443dc
MR
3188 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3189 (Fwindow_hchild): Rename to Fwindow_left_child.
3190 (Fwindow_next): Rename to Fwindow_next_sibling.
3191 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3192 (resize_window_check): Rename to window_resize_check.
3193 (resize_window_apply): Rename to window_resize_apply.
3194 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3195 (Fdelete_other_windows_internal, resize_frame_windows)
3196 (Fsplit_window_internal, Fdelete_window_internal)
3197 (grow_mini_window, shrink_mini_window)
3198 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3199
c7e73be5
JD
32002011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3201
3202 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3203 (emacs_fixed_set_min_size): Remove.
3204 (emacs_fixed_new): Take frame as argument.
3205
3206 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3207 (_EmacsFixedPrivate): Remove minwidth/height.
3208 Add struct frame *f.
3209 (emacs_fixed_init): Initialize priv->f.
3210 (get_parent_class, emacs_fixed_set_min_size): Remove.
3211 (emacs_fixed_new): Set priv->f to argument.
3212 (emacs_fixed_get_preferred_width)
3213 (emacs_fixed_get_preferred_height): Use min_width/height from
3214 frames size_hint to set minimum and natural (Bug#8919).
3215 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3216 and use min_width/height from frames size_hint to set
3217 min_width/height (Bug#8919).
3218
3219 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3220 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3221 Fix indentation.
c7e73be5 3222
cf99dcf8
EZ
32232011-06-26 Eli Zaretskii <eliz@gnu.org>
3224
3225 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3226 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3227 called at ZV.
3228
029529ac
CY
32292011-06-26 Chong Yidong <cyd@stupidchicken.com>
3230
3231 * process.c (wait_reading_process_output): Bypass select if
3232 waiting for a cell while ignoring keyboard input, and input is
3233 pending. Suggested by Jan Djärv (Bug#8869).
3234
7a7ef429
PE
32352011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3236
3237 Use gnulib's dup2 module instead of rolling our own.
3238 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3239
11fdef7d 32402011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3241
3242 * dispnew.c (scrolling_window): Before scrolling, turn off a
3243 mouse-highlight in the window being scrolled.
3244
cd3520a4
JB
32452011-06-24 Juanma Barranquero <lekktu@gmail.com>
3246
3247 Move DEFSYM to lisp.h and use everywhere.
3248
3249 * character.h (DEFSYM): Move declaration...
3250 * lisp.h (DEFSYM): ...here.
3251
3252 * gnutls.c:
3253 * minibuf.c:
3254 * w32menu.c:
3255 * w32proc.c:
3256 * w32select.c: Don't include character.h.
3257
3258 * alloc.c (syms_of_alloc):
3259 * buffer.c (syms_of_buffer):
3260 * bytecode.c (syms_of_bytecode):
3261 * callint.c (syms_of_callint):
3262 * casefiddle.c (syms_of_casefiddle):
3263 * casetab.c (init_casetab_once):
3264 * category.c (init_category_once, syms_of_category):
3265 * ccl.c (syms_of_ccl):
3266 * cmds.c (syms_of_cmds):
3267 * composite.c (syms_of_composite):
3268 * dbusbind.c (syms_of_dbusbind):
3269 * dired.c (syms_of_dired):
3270 * dispnew.c (syms_of_display):
3271 * doc.c (syms_of_doc):
3272 * editfns.c (syms_of_editfns):
3273 * emacs.c (syms_of_emacs):
3274 * eval.c (syms_of_eval):
3275 * fileio.c (syms_of_fileio):
3276 * fns.c (syms_of_fns):
3277 * frame.c (syms_of_frame):
3278 * fringe.c (syms_of_fringe):
3279 * insdel.c (syms_of_insdel):
3280 * keymap.c (syms_of_keymap):
3281 * lread.c (init_obarray, syms_of_lread):
3282 * macros.c (syms_of_macros):
3283 * msdos.c (syms_of_msdos):
3284 * print.c (syms_of_print):
3285 * process.c (syms_of_process):
3286 * search.c (syms_of_search):
3287 * sound.c (syms_of_sound):
3288 * syntax.c (init_syntax_once, syms_of_syntax):
3289 * terminal.c (syms_of_terminal):
3290 * textprop.c (syms_of_textprop):
3291 * undo.c (syms_of_undo):
3292 * w32.c (globals_of_w32):
3293 * window.c (syms_of_window):
3294 * xdisp.c (syms_of_xdisp):
3295 * xfaces.c (syms_of_xfaces):
3296 * xfns.c (syms_of_xfns):
3297 * xmenu.c (syms_of_xmenu):
3298 * xsettings.c (syms_of_xsettings):
3299 * xterm.c (syms_of_xterm): Use DEFSYM.
3300
4228cf16
TZ
33012011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3302
cd3520a4 3303 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3304
7fcccf1e
PE
33052011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3306
7efb4e0e
PE
3307 Integer and buffer overflow fixes (Bug#8873).
3308
ff5844ad
PE
3309 * print.c (printchar, strout): Check for string overflow.
3310 (PRINTPREPARE, printchar, strout):
3311 Don't set size unless allocation succeeds.
3312
90532f02
PE
3313 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3314 for sizes. Check for string overflow more accurately.
3315 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3316
6d84508d
PE
3317 * macros.c: Integer and buffer overflow fixes.
3318 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3319 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3320 Use ptrdiff_t, not int, for sizes.
3321 Don't increment bufsize until after realloc succeeds.
3322 Check for size-calculation overflow.
3323 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3324
437b2cb4
PE
3325 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3326
8b9ac8b4
PE
3327 * lread.c: Integer overflow fixes.
3328 (read_integer): Radix is now EMACS_INT, not int,
3329 to improve quality of diagnostics for out-of-range radices.
3330 Calculate buffer size correctly for out-of-range radices.
3331 (read1): Check for integer overflow in radices, and in
3332 read-circle numbers.
82cb60d3
PE
3333 (read_escape): Avoid int overflow.
3334 (Fload, openp, read_buffer_size, read1)
3335 (substitute_object_recurse, read_vector, read_list, map_obarray):
3336 Use ptrdiff_t, not int, for sizes.
3337 (read1): Use EMACS_INT, not int, for sizes.
20270765 3338 Check for size overflow.
8b9ac8b4 3339
7fcccf1e
PE
3340 * image.c (cache_image): Check for size arithmetic overflow.
3341
bfbbd7e7
PE
3342 * lread.c: Integer overflow issues.
3343 (saved_doc_string_size, saved_doc_string_length)
3344 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3345 Now ptrdiff_t, not int.
3346 (read1): Don't assume doc string length fits in int. Check for
3347 out-of-range doc string lengths.
3348 (read_list): Don't assume file position fits in int.
39019e54 3349 (read_escape): Check for hex character overflow.
bfbbd7e7 3350
4e323265
LL
33512011-06-22 Leo Liu <sdl.web@gmail.com>
3352
3353 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3354 Move to minibuffer.el.
3355
85fece3e
PE
33562011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3357
20b84ce9 3358 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3359 The following patches are for when GLYPH_DEBUG && !XASSERT.
3360 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3361 * dispnew.c (flush_stdout):
3362 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3363 Mark as externally visible.
3364 * dispnew.c (check_window_matrix_pointers): Now static.
3365 * dispnew.c (window_to_frame_vpos):
3366 * xfns.c (unwind_create_frame):
3367 * xterm.c (x_check_font): Remove unused local.
3368 * scroll.c (CHECK_BOUNDS):
3369 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3370 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3371 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3372 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3373 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3374 Now static.
3375 (debug_method_add): Use va_list and vsprintf rather than relying
3376 on undefined behavior with wrong number of arguments.
3377 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3378 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3379 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3380 since we're not interested in debugging glyphs with old libraries.
3381 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3382 GCC 4.6.0's static checking.
3383
0766b489
PE
33842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3385
31fd4b32
PE
3386 Integer overflow and signedness fixes (Bug#8873).
3387 A few related buffer overrun fixes, too.
3388
b79e8648
PE
3389 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3390
0766b489
PE
3391 * dispextern.h (struct face.stipple):
3392 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3393 (x_bitmap_mask, x_allocate_bitmap_record)
3394 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3395 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3396 (x_create_bitmap_from_xpm_data):
3397 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3398 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3399 (.bitmaps_last):
3400 * xfaces.c (load_pixmap):
3401 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3402 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3403 (.bitmaps_last, struct x_output.icon_bitmap):
3404 Use ptrdiff_t, not int, for bitmap indexes.
3405 (x_allocate_bitmap_record): Check for size overflow.
3406 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3407
b081724f
PE
3408 Use ptrdiff_t, not int, for overlay counts.
3409 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3410 * editfns.c (overlays_around, get_pos_property):
3411 * textprop.c (get_char_property_and_overlay):
3412 * xdisp.c (next_overlay_change, note_mouse_highlight):
3413 * xfaces.c (face_at_buffer_position):
21514da7
PE
3414 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3415 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3416 (Fnext_overlay_change, Fprevious_overlay_change)
3417 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3418 Use ptrdiff_t, not int, for sizes.
21514da7 3419 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3420
3de73e5e
PE
3421 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3422
2606c57b
PE
3423 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3424 (x_session_initialize): Do not assume string length fits in int.
3425
aaafe47a
PE
3426 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3427 This is unlikely, but can occur if DPI is outlandish.
3428
2674ddc8 3429 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3430 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3431
28154962
PE
3432 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3433 * xrdb.c (magic_file_p, search_magic_path):
3434 Omit last arg SUFFIX; it was always 0. All callers changed.
3435 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3436
7de51af5
PE
3437 * xfont.c (xfont_match): Avoid need for strlen.
3438
25ed6cc3
PE
3439 * xfns.c: Don't assume strlen fits in int.
3440 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3441
4eab31dd
PE
3442 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3443 not unsigned long, as we prefer signed integers. All callers changed.
3444 Detect integer overflow in repeat count.
3445 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3446 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3447
171e2a58
PE
3448 * termcap.c: Don't assume sizes fit in int and never overflow.
3449 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3450 (gobble_line): Check for size-calculation overflow.
3451
ad39faca 3452 * minibuf.c (Fread_buffer):
6e5bb2dc 3453 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3454 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3455 Don't assume string length fits in int.
3456
52c61c22 3457 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3458 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3459
b5b8c9e5
PE
3460 * font.c: Don't assume string length fits in int.
3461 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3462 Use ptrdiff_t, not int.
ccd6111c
PE
3463 (font_intern_prop): Don't assume string length fits in int.
3464 Don't assume integer property fits in fixnum.
3465 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3466
882f0d81 3467 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3468 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3469 Reformulate so as not to need the command string.
3470 Invoke gzip -cd rather than gunzip, as it's more portable.
3471 (lock_info_type, lock_file_1, lock_file):
3472 Don't assume pid_t and time_t fit in unsigned long.
3473 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3474 (current_lock_owner): Prefer signed type for sizes.
3475 Use memcpy, not strncpy, where memcpy is what is really wanted.
3476 Don't assume (via atoi) that time_t and pid_t fit in int.
3477 Check for time_t and/or pid_t out of range, e.g., via a network share.
3478 Don't alloca where an auto var works fine.
3479
93f4cf88
PE
3480 * fileio.c: Fix some integer overflow issues.
3481 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3482 Don't assume string length fits in int.
3483 (directory_file_name): Don't assume string length fits in long.
3484 (make_temp_name): Don't assume pid fits in int, or that its print
3485 length is less than 20.
3486
f3e92b69
PE
3487 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3488
1bfdaf10
PE
3489 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3490
35016e9a
PE
3491 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3492
3d1e65a1
PE
3493 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3494 We prefer signed integers, even for size calculations.
3495
0b963a93
PE
3496 * emacs.c: Don't assume string length fits in 'int'.
3497 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3498 (main): Don't invoke strlen when not needed.
3499
573f4b54
PE
3500 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3501 (XD_DEBUG_MESSAGE): Don't waste a byte.
3502
989f33ba
PE
3503 * callproc.c (getenv_internal_1, getenv_internal)
3504 (Fgetenv_internal):
965d34eb
PE
3505 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3506
e4d29b33
PE
3507 * lread.c (invalid_syntax): Omit length argument.
3508 All uses changed. This doesn't fix a bug, but it simplifies the
3509 code away from its former Hollerith-constant appearance, and it's
3510 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3511 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3512
eb49b136
PE
3513 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3514 This didn't break anything, but it didn't help either.
3515 It's confusing to put a bogus integer in a place where the actual
3516 value does not matter.
9f62aeb1 3517 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3518 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3519
15375a22
PE
3520 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3521 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3522 implementation.
b61cc01c
PE
3523 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3524 We prefer signed types, and the value cannot exceed the EMACS_INT
3525 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3526 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3527 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3528 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3529
53b2623d
PE
3530 * indent.c (sane_tab_width): New function.
3531 (current_column, scan_for_column, Findent_to, position_indentation)
3532 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3533 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3534
51cab52b 3535 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3536
f2ed8a70
PE
3537 * lisp.h (lint_assume): New macro.
3538 * composite.c (composition_gstring_put_cache):
3539 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3540
abe80cc6
PE
3541 * editfns.c, insdel.c:
3542 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3543
b02c740e
PE
3544 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3545
ebc96716
PE
3546 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3547
b4e50fa0 3548 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3549 Use much-faster test for byte-length change.
311d5d7c 3550 Don't assume string byte-length fits in 'int'.
a4cf38e4 3551 Check that character arg fits in 'int'.
85461888 3552 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3553
c0c1ee9f
PE
3554 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3555
a498d7f4
PE
3556 * fns.c (concat): Catch string overflow earlier.
3557 Do not rely on integer wraparound.
3558
51cab52b
PE
3559 * dispextern.h (struct it.overlay_strings_charpos)
3560 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3561 * xdisp.c (forward_to_next_line_start)
3562 (back_to_previous_visible_line_start)
3563 (reseat_at_next_visible_line_start, next_element_from_buffer):
3564 Don't arbitrarily truncate the value of 'selective' to int.
3565
76031fad
PE
3566 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3567
5eb55db9
PE
3568 * composite.c: Don't truncate sizes to 'int'.
3569 (composition_gstring_p, composition_reseat_it)
3570 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3571 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3572 not EMACS_UINT, for indexes.
5eb55db9 3573
0703a717
PE
3574 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3575
d6202519
PE
3576 * buffer.c: Include <verify.h>.
3577 (struct sortvec.priority, struct sortstr.priority):
8961a454 3578 Now EMACS_INT, not int.
c20998a7 3579 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3580 (struct sortstr.size, record_overlay_string)
3581 (struct sortstrlist.size, struct sortlist.used):
3582 Don't truncate size to int.
3583 (record_overlay_string): Check for size-calculation overflow.
d6202519 3584 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3585
d5a19415
JM
35862011-06-22 Jim Meyering <meyering@redhat.com>
3587
029529ac 3588 Don't leak an XBM-image-sized buffer
d5a19415
JM
3589 * image.c (xbm_load): Free the image buffer after using it.
3590
a9041e6c
PE
35912011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3592
3593 Port to Sun C.
3594 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3595 that Sun C diagnosed.
3596 * fns.c (secure_hash): Fix pointer signedness issue.
3597 * intervals.c (static_offset_intervals): New function.
3598 (offset_intervals): Use it.
3599
7f3f739f
LL
36002011-06-21 Leo Liu <sdl.web@gmail.com>
3601
3602 * deps.mk (fns.o):
3603 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3604 sha512.h.
3605
3606 * fns.c (secure_hash): Rename from crypto_hash_function and change
3607 the first arg to accept symbols.
5b66d427 3608 (Fsecure_hash): New primitive.
7f3f739f
LL
3609 (syms_of_fns): New symbols.
3610
76147d94
DD
36112011-06-20 Deniz Dogan <deniz@dogan.se>
3612
3613 * process.c (Fset_process_buffer): Clarify return value in
3614 docstring.
3615
7d7d0045
CY
36162011-06-18 Chong Yidong <cyd@stupidchicken.com>
3617
3618 * dispnew.c (add_window_display_history): Use BVAR.
3619
3620 * xdisp.c (debug_method_add): Use BVAR.
3621 (check_window_end, dump_glyph_matrix, dump_glyph)
3622 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3623
3624 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3625 Likewise.
3626
3627 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3628 check till after the cache is created in init_frame_faces.
3629
ff2bc410
SM
36302011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3631
3632 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3633
28177add
PE
36342011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3635
dd3482fe
PE
3636 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3637 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3638 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3639
393d71f3 3640 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3641 * fileio.c (Finsert_file_contents):
3642 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3643 Remove the old (too-loose) buffer overflow checks.
3644 They weren't needed, since make_gap checks for buffer overflow.
3645 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3646 The old code merely checked for Emacs fixnum overflow, and relied
3647 on undefined (wraparound) behavior. The new code avoids undefined
3648 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3649
2e6813b0 3650 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3651 Tune. Don't use wider integers than needed. Don't use alloca.
3652 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3653
599a9e4f
PE
3654 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3655
99561444
PE
3656 * insdel.c, lisp.h (buffer_overflow): New function.
3657 (insert_from_buffer_1, replace_range, replace_range_2):
3658 * insdel.c (make_gap_larger):
3659 * editfns.c (Finsert_char):
3660 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3661
28177add
PE
3662 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3663
e69dafad
PE
36642011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3665
a7af7fde 3666 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3667
b1c46f02
PE
3668 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3669 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3670
e69dafad
PE
3671 * fileio.c: Don't assume EMACS_INT fits in off_t.
3672 (emacs_lseek): New static function.
3673 (Finsert_file_contents, Fwrite_region): Use it.
3674 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3675
566684ea
PE
3676 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3677
e6966cd6
PE
3678 * fns.c: Don't overflow int when computing a list length.
3679 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3680 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3681 truncation on 64-bit hosts. Check for QUIT every
3682 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3683 faster and is responsive enough.
3684 (Flength): Report an error instead of overflowing an integer.
3685 (Fsafe_length): Return a float if the value is not representable
3686 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3687 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3688 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3689
dd0b0efb
PE
3690 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3691 (header_size, word_size): New constants.
3692 (allocate_vectorlike): Don't check size overflow here.
3693 (allocate_vector): Check it here instead, since this is the only
3694 caller of allocate_vectorlike that could cause overflow.
3695 Check that the new vector's length is representable as a fixnum.
3696
86fe5cfe
PE
3697 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3698 The previous code was bogus. For example, next_almost_prime (32)
3699 returned 39, which is undesirable as it is a multiple of 3; and
3700 next_almost_prime (24) returned 25, which is a multiple of 5 so
3701 why was the code bothering to check for multiples of 7?
3702
80e88859
PE
3703 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3704
4a2f0ad6
PE
3705 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3706
f66c7cf8
PE
3707 Variadic C functions now count arguments with ptrdiff_t.
3708 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3709 Back then I didn't know that the Emacs coding style prefers signed int.
3710 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3711 were being counted with int, which may truncate counts on 64-bit
3712 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3713 * lisp.h (struct Lisp_Subr.function.aMANY)
3714 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3715 Arg counts are now ptrdiff_t, not size_t.
3716 All variadic functions and their callers changed accordingly.
3717 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3718 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3719 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3720 * callint.c (Fcall_interactively): Check arg count for overflow,
3721 to avoid potential buffer overrun. Use signed char, not 'int',
3722 for 'varies' array, so that we needn't bother to check its size
3723 calculation for overflow.
3724 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3725 * eval.c (apply_lambda):
3726 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3727 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3728 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3729
a1759b76
PE
3730 * callint.c (Fcall_interactively): Don't use index var as event count.
3731
d96be9fc
PE
3732 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3733 * mem-limits.h (SIZE): Remove; no longer used.
3734
a690a978 3735 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3736
578c21e6
PE
3737 Remove unnecessary casts.
3738 * xterm.c (x_term_init):
3739 * xfns.c (x_set_border_pixel):
3740 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3741 These aren't needed now that we assume ANSI C.
3742
96f53c6c
PE
3743 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3744 It's more likely to cause problems (due to unsigned overflow)
3745 than to cure them.
3746
83c77d31
PE
3747 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3748
ee2079f1
PE
3749 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3750
6da65536
PE
3751 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3752
7147c4a4
PE
3753 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3754
193e32d9
PE
3755 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3756
e5533da6
PE
3757 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3758
9910e595
PE
3759 GLYPH_CODE_FACE returns EMACS_INT, not int.
3760 * dispextern.h (merge_faces):
3761 * xfaces.c (merge_faces):
01103c44
PE
3762 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3763 Don't assume EMACS_INT fits in int.
9910e595 3764
2638320e
PE
3765 * character.h (CHAR_VALID_P): Remove unused parameter.
3766 * fontset.c, lisp.h, xdisp.c: All uses changed.
3767
045eb8d9
PE
3768 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3769
c1f134b5
PE
3770 * fns.c (concat): Minor tuning based on overflow analysis.
3771 This doesn't fix any bugs. Use int to hold character, instead
3772 of constantly refetching from Emacs object. Use XFASTINT, not
3773 XINT, for value known to be a character. Don't bother comparing
3774 a single byte to 0400, as it's always less.
3775
395fcb93 3776 * floatfns.c (Fexpt):
327eeec8
PE
3777 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3778
abbd3d23
PE
3779 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3780 for characters.
3781
684a03ef
PE
3782 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3783
0fed43f3
PE
3784 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3785 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3786 incorrectly succeed when S was a string, because 4294967386 was
3787 truncated before it was used.
3788
8fd02eb7
PE
3789 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3790 Otherwise, an out-of-range integer could cause undefined behavior
3791 on a 64-bit host.
3792
f8c86b69
PE
3793 * composite.c: Use int, not EMACS_INT, for characters.
3794 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3795 EMACS_INT, for values that are known to be in character range.
3796 This doesn't fix any bugs but is the usual style inside Emacs and
3797 may generate better code on 32-bit machines.
3798
34206dd2
PE
3799 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3800 This is for reasons similar to the recent CHAR_STRING fix.
3801 * charset.c (Fencode_char): Check that character arg is actually
3802 a character. Pass an int to ENCODE_CHAR.
3803 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3804 wider than 'int', as a compile-time check to prevent future regressions
3805 in this area.
3806
c5958d4c 3807 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3808
3809 Make sure a 64-bit char is never passed to CHAR_STRING.
3810 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3811 by silently ignoring the top 32 bits, allowing some values
3812 that were far too large to be valid characters.
3813 * character.h: Include <verify.h>.
3814 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3815 arguments are no wider than unsigned, as a compile-time check
3816 to prevent future regressions in this area.
3817 * data.c (Faset):
01103c44 3818 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3819 (Fsubst_char_in_region):
3820 * fns.c (concat):
3821 * xdisp.c (decode_mode_spec_coding):
3822 Adjust to CHAR_STRING's new requirement.
3823 * editfns.c (Finsert_char, Fsubst_char_in_region):
3824 * fns.c (concat): Check that character args are actually
3825 characters. Without this test, these functions did the wrong
3826 thing with wildly out-of-range values on 64-bit hosts.
3827
d37ca623
PE
3828 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3829 These casts should not be needed on 32-bit hosts, either.
3830 * keyboard.c (read_char):
3831 * lread.c (Fload): Remove casts to unsigned.
3832
ea204efb
PE
3833 * lisp.h (UNSIGNED_CMP): New macro.
3834 This fixes comparison bugs on 64-bit hosts.
3835 (ASCII_CHAR_P): Use it.
3836 * casefiddle.c (casify_object):
01103c44 3837 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3838 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3839 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3840 * dispextern.h (FACE_FROM_ID):
3841 * keyboard.c (read_char): Use UNSIGNED_CMP.
3842
41cb286c
PE
3843 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3844 not to EMACS_INT, to avoid GCC warning.
3845
4a1b9832
PE
3846 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3847
55daad71
PE
3848 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3849 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3850 isn't needed on 32-bit machines.
8f95c75c 3851
01103c44
PE
3852 * buffer.c (Fgenerate_new_buffer_name):
3853 Use EMACS_INT for count, not int.
0ceccced 3854 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3855
3856 * data.c (Qcompiled_function): Now static.
3857
c6f072e7
PE
3858 * window.c (window_body_lines): Now static.
3859
20ce5912
PE
3860 * image.c (gif_load): Rename local to avoid shadowing.
3861
9c4c5f81
PE
3862 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3863 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3864 * alloc.c (make_save_value): Integer argument is now of type
3865 ptrdiff_t, not int.
3866 (mark_object): Use ptrdiff_t, not int.
3867 * lisp.h (pD): New macro.
3868 * print.c (print_object): Use it.
3869
c0c5c8ae
PE
3870 * alloc.c: Use EMACS_INT, not int, to count objects.
3871 (total_conses, total_markers, total_symbols, total_vector_size)
3872 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3873 (total_free_floats, total_floats, total_free_intervals)
3874 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3875 Now EMACS_INT, not int. All uses changed.
3876 (Fgarbage_collect): Compute overall total using a double, so that
3877 integer overflow is less likely to be a problem. Check for overflow
3878 when converting back to an integer.
5a25e253
PE
3879 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3880 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3881 These were 'int' variables that could overflow on 64-bit hosts;
3882 they were never used, so remove them instead of repairing them.
211a0b2a 3883 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3884 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3885 Previously, this ceilinged at INT_MAX, but that doesn't work on
3886 64-bit machines.
e46bb31a 3887 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3888
c78baabf 3889 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3890 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3891 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3892 when a (possibly-narrower) signed value would do just as well.
3893 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3894
c9d624c6
PE
3895 * alloc.c: Catch some string size overflows that we were missing.
3896 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3897 for convenience in STRING_BYTES_MAX.
3898 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3899 The definition here is exact; the one in lisp.h was approximate.
3900 (allocate_string_data): Check for string overflow. This catches
3901 some instances we weren't catching before. Also, it catches
3902 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3903 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3904 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3905
c9d624c6
PE
3906 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3907 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3908 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3909
353032ce
PE
3910 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3911
2bccce07
PE
3912 * alloc.c (Fmake_string): Check for out-of-range init.
3913
0ac30604
SM
39142011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3915
3916 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3917
c195f2de
JD
39182011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3919
3920 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3921 xg_get_default_scrollbar_width.
3922
3923 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3924 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3925 (style_changed_cb): Call update_theme_scrollbar_width and call
3926 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3927 all frames (Bug#8505).
3928 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3929 Call gtk_window_set_resizable if HAVE_GTK3.
3930 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3931 and height if HAVE_GTK3 (Bug#8505).
3932 (scroll_bar_width_for_theme): New variable.
3933 (update_theme_scrollbar_width): New function.
3934 (xg_get_default_scrollbar_width): Move code to
3935 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3936 (xg_initialize): Call update_theme_scrollbar_width.
3937
3938 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3939
3940 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3941
e10ac9f1
MR
39422011-06-12 Martin Rudalics <rudalics@gmx.at>
3943
3944 * frame.c (make_frame): Call other_buffer_safely instead of
3945 other_buffer.
3946
3947 * window.c (temp_output_buffer_show): Call display_buffer with
3948 second argument Vtemp_buffer_show_specifiers and reset latter
3949 immediately after the call.
3950 (Vtemp_buffer_show_specifiers): New variable.
3951 (auto_window_vscroll_p, next_screen_context_lines)
3952 (Vscroll_preserve_screen_position): Remove leading asterisks from
3953 doc-strings.
3954
2d3c217e 39552011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3956
7b7f97e8 3957 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3958 * buffer.c (Qclone_number): Remove for now, as it's unused.
3959 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3960 (record_buffer): Remove unused local.
3961 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3962 (set_frame_buffer_list): Remove; unused.
3963 * frame.h (other_visible_frames): Remove decl.
3964 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3965 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3966 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3967 if HAVE_GPM.
3968 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3969 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3970 Define only if HAVE_GPM.
3971 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3972 (update_hints_inhibit): Remove; never set. All uses removed.
3973 * widgetprv.h (emacsFrameClassRec): Remove decl.
3974 * window.c (delete_deletable_window): Now returns void, since it
3975 wasn't returning anything.
3976 (compare_window_configurations): Remove unused locals.
3977 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3978 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3979 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3980 the same widths as pointers. This follows up on the 2011-05-06 patch.
3981 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3982 * xterm.h: Likewise.
3983 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3984
1384b89e
JB
39852011-06-12 Juanma Barranquero <lekktu@gmail.com>
3986
3987 * makefile.w32-in: Update dependencies.
3988 (LISP_H): Add lib/intprops.h.
3989
1100a63c
CY
39902011-06-11 Chong Yidong <cyd@stupidchicken.com>
3991
3992 * image.c (gif_load): Add animation frame delay to the metadata.
3993 (syms_of_image): Use DEFSYM. New symbol `delay'.
3994
6198ccd0
MR
39952011-06-11 Martin Rudalics <rudalics@gmx.at>
3996
3997 * window.c (delete_deletable_window): Re-add.
3998 (Fset_window_configuration): Rewrite to handle dead buffers and
3999 consequently deletable windows.
4000 (window_tree, Fwindow_tree): Remove. Supply functionality in
4001 window.el.
4002 (compare_window_configurations): Simplify code.
4003
b6e3633c
AS
40042011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4005
1ab0dee5
AS
4006 * image.c (imagemagick_load_image): Fix type mismatch.
4007 (Fimagemagick_types): Likewise.
4008
b6e3633c
AS
4009 * window.h (replace_buffer_in_windows): Declare.
4010
9397e56f
MR
40112011-06-11 Martin Rudalics <rudalics@gmx.at>
4012
4013 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4014 Qclone_number. Remove external declaration of Qdelete_window.
4015 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4016 code.
640c8776
SM
4017 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4018 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4019 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4020 buffer list implementation.
4021 (other_buffer_safely): New function.
4022 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4023 calls to replace_buffer_in_windows and
4024 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4025 if allowed.
4026 (record_buffer): Inhibit quitting and rewrite using quittable
4027 functions. Run Qbuffer_list_update_hook if allowed.
4028 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4029 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4030 Move switch-to-buffer to window.el.
9397e56f
MR
4031 (bury-buffer): Move to window.el.
4032 (Vbuffer_list_update_hook): New variable.
4033
4034 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4035 section.
4036
4037 * window.h (resize_frame_windows): Move up in code.
4038 (Fwindow_frame): Remove EXFUN.
4039 (replace_buffer_in_all_windows): Remove prototype.
4040 (replace_buffer_in_windows_safely): Add prototype.
4041
4042 * window.c: Declare Qdelete_window static again. Move down
4043 declaration of select_count.
4044 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4045 (Fother_window): Move to window.el.
4046 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4047 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4048 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4049 window.el.
4050 (replace_buffer_in_windows): Implement by calling
4051 Qreplace_buffer_in_windows.
4052 (replace_buffer_in_all_windows): Remove with some functionality
4053 moved into replace_buffer_in_windows_safely.
4054 (replace_buffer_in_windows_safely): New function.
4055 (select_window_norecord, select_frame_norecord): Move in front
4056 of run_window_configuration_change_hook. Remove now obsolete
4057 declarations.
640c8776
SM
4058 (Fset_window_buffer): Rewrite doc-string.
4059 Call Qrecord_window_buffer.
9397e56f
MR
4060 (keys_of_window): Move binding for other-window to window.el.
4061
b50691aa
CY
40622011-06-11 Chong Yidong <cyd@stupidchicken.com>
4063
4064 * dispextern.h (struct image): Replace data member, whose int_val
4065 and ptr_val fields were not used by anything, with a single
4066 lisp_val object.
4067
4068 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4069 (gif_clear_image, gif_load, imagemagick_load_image)
4070 (gs_clear_image, gs_load): Callers changed.
4071
3f754b86
PE
40722011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4073
cca69397
PE
4074 * buffer.h: Include <time.h>, for time_t.
4075 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4076
109e28d0
PE
4077 Fix minor problems found by static checking.
4078
60737f02
PE
4079 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4080
4b66faf3
PE
4081 Make identifiers static if they are not used in other modules.
4082 * data.c (Qcompiled_function, Qframe, Qvector):
4083 * image.c (QimageMagick, Qsvg):
4084 * minibuf.c (Qmetadata):
4085 * window.c (resize_window_check, resize_root_window): Now static.
4086 * window.h (resize_window_check, resize_root_window): Remove decls.
4087
109e28d0
PE
4088 * window.c (window_deletion_count, delete_deletable_window):
4089 Remove; unused.
46a4ce9e
PE
4090 (window_body_lines): Now static.
4091 (Fdelete_other_windows_internal): Mark vars as initialized.
4092 Make sure 'resize_failed' is initialized.
4093 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4094 (resize_window_apply): Remove unused local.
4095 * window.h (delete_deletable_window): Remove decl.
4096
109e28d0 4097 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4098 (imagemagick_load_image): Fix pointer signedness problem by changing
4099 last arg from unsigned char * to char *. All uses changed.
4100 Also, fix a local for similar reasons.
4101 Remove unused locals. Remove locals to avoid shadowing.
4102 (fn_rsvg_handle_free): Remove; unused.
4103 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4104 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4105
3f754b86
PE
4106 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4107
2547adb1
CY
41082011-06-10 Chong Yidong <cyd@stupidchicken.com>
4109
4110 * image.c (gif_load): Fix omitted cast error introduced by
4111 2011-06-06 change.
4112
2c8e37d4
MR
41132011-06-10 Martin Rudalics <rudalics@gmx.at>
4114
4115 * window.h (resize_proportionally, orig_total_lines)
4116 (orig_top_line): Remove from window structure.
4117 (set_window_height, set_window_width, change_window_heights)
4118 (Fdelete_window): Remove prototypes.
4119 (resize_frame_windows): Remove duplicate declaration.
4120
440a42e3
EZ
41212011-06-10 Eli Zaretskii <eliz@gnu.org>
4122
4123 * window.h (resize_frame_windows, resize_window_check)
4124 (delete_deletable_window, resize_root_window)
4125 (resize_frame_windows): Declare prototypes.
4126
4127 * window.c (resize_window_apply): Make definition be "static" to
4128 match the prototype.
4129
562dd5e9
MR
41302011-06-10 Martin Rudalics <rudalics@gmx.at>
4131
4132 * window.c: Remove declarations of Qwindow_size_fixed,
4133 window_min_size_1, window_min_size_2, window_min_size,
4134 size_window, window_fixed_size_p, enlarge_window, delete_window.
4135 Remove static from declaration of Qdelete_window, it's
4136 temporarily needed by Fbury_buffer.
4137 (replace_window): Don't assign orig_top_line and
4138 orig_total_lines.
4139 (Fdelete_window, delete_window): Remove. Window deletion is
4140 handled by window.el.
640c8776
SM
4141 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4142 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4143 (Fdelete_other_windows): Remove. Deleting other windows is
4144 handled by window.el.
4145 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4146 handled in window.el.
4147 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4148 Window minimum sizes are handled in window.el.
4149 (shrink_windows, size_window, set_window_height)
4150 (set_window_width, change_window_heights, window_height)
4151 (window_width, CURBEG, CURSIZE, enlarge_window)
4152 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4153 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4154 handled in window.el.
4155 (make_dummy_parent): Rename to make_parent_window and give it a
4156 second argument horflag.
4157 (make_window): Don't set resize_proportionally any more.
4158 (Fsplit_window): Remove. Windows are split in window.el.
4159 (save_restore_action, save_restore_orig_size)
4160 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4161 Resize mini windows in window.el.
4162 (grow_mini_window, shrink_mini_window): Implement by calling
4163 Qresize_root_window_vertically, resize_window_check and
4164 resize_window_apply.
640c8776
SM
4165 (saved_window, Fset_window_configuration, save_window_save):
4166 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4167 resize_proportionally.
4168 (window_min_height, window_min_width): Move to window.el.
4169 (keys_of_window): Move bindings for delete-other-windows,
4170 split-window, delete-window and enlarge-window to window.el.
4171
4172 * buffer.c: Temporarily extern Qdelete_window.
4173 (Fbury_buffer): Temporarily call Qdelete_window instead of
4174 Fdelete_window (Fbury_buffer will move to window.el soon).
4175
4176 * frame.c (set_menu_bar_lines_1): Remove code handling
4177 orig_top_line and orig_total_lines.
4178
4179 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4180 set_window_height but set heights directly.
4181 (change_frame_size_1): Use resize_frame_windows.
4182
4183 * xdisp.c (init_xdisp): Don't use set_window_height but set
4184 heights directly.
4185
640c8776
SM
4186 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4187 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4188 run_window_configuration_change_hook.
4189
4190 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4191 instead of change_window_heights and run
4192 run_window_configuration_change_hook.
4193
1a13852e
MR
41942011-06-09 Martin Rudalics <rudalics@gmx.at>
4195
4196 * window.c (replace_window): Rename second argument REPLACEMENT to
4197 NEW. New third argument SETFLAG. Rewrite.
4198 (delete_window, make_dummy_parent): Call replace_window with
4199 third argument 1.
4200 (window_list_1): Move down in code.
4201 (run_window_configuration_change_hook): Move set_buffer part
4202 before select_frame_norecord part in order to unwind correctly.
4203 Rename count1 to count.
4204 (recombine_windows, delete_deletable_window, resize_root_window)
4205 (Fdelete_other_windows_internal)
4206 (Frun_window_configuration_change_hook, make_parent_window)
4207 (resize_window_check, resize_window_apply, Fresize_window_apply)
4208 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4209 (Fdelete_window_internal, Fresize_mini_window_internal):
4210 New functions.
1a13852e
MR
4211 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4212
f3d1777e
MR
42132011-06-08 Martin Rudalics <rudalics@gmx.at>
4214
496e208e
MR
4215 * window.h (window): Add some new members to window structure -
4216 normal_lines, normal_cols, new_total, new_normal, clone_number,
4217 splits, nest, prev_buffers, next_buffers.
4218 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4219 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4220
f3d1777e
MR
4221 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4222 Remove.
496e208e
MR
4223 (make_dummy_parent): Set new members of windows structure.
4224 (make_window): Move down in code. Handle new members of window
4225 structure.
4226 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4227 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4228 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4229 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4230 (Fset_window_next_buffers, Fset_window_clone_number):
4231 New functions.
496e208e
MR
4232 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4233 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4234 Doc-string fixes.
4235 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4236 Argument WINDOW can be now internal window too.
4237 (Fwindow_use_time): Move up in code.
4238 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4239 Rewrite doc-string.
4240 (Fset_window_configuration, saved_window)
4241 (Fcurrent_window_configuration, save_window_save): Handle new
4242 members of window structure.
b9e809c2
MR
4243 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4244 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4245 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4246 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4247 Qget_mru_window, Qresize_root_window,
4248 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4249 Qauto_buffer_name; staticpro them.
f3d1777e 4250
abde8f8c
MR
42512011-06-07 Martin Rudalics <rudalics@gmx.at>
4252
4253 * window.c (Fwindow_total_size, Fwindow_left_column)
4254 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4255 (Fwindow_list_1): New functions.
4256 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4257 (Fwindow_width, Fscroll_left, Fscroll_right):
4258 Use window_body_cols instead of window_box_text_cols.
4259 (delete_window, Fset_window_configuration):
4260 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4261 (delete_all_subwindows): Take a window as argument and not a
4262 structure. Rewrite.
190b47e6
MR
4263 (window_loop): Remove handling of GET_LRU_WINDOW and
4264 GET_LARGEST_WINDOW.
4265 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4266
4267 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4268 window_box_text_cols. delete_all_subwindows now takes a
4269 Lisp_Object as argument.
abde8f8c 4270
640c8776
SM
4271 * indent.c (compute_motion, Fcompute_motion):
4272 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4273
fa8a67e6
MR
4274 * frame.c (delete_frame): Call delete_all_subwindows with root
4275 window as argument.
4276
a54e3482
DC
42772011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4278
4279 * fns.c (Fputhash): Document return value.
4280
60002bf5
CY
42812011-06-06 Chong Yidong <cyd@stupidchicken.com>
4282
4283 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4284
0c671da6 42852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4286
b862a52a 4287 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4288
be44ca6c
PE
4289 Check for overflow when converting integer to cons and back.
4290 * charset.c (Fdefine_charset_internal, Fdecode_char):
4291 Use cons_to_unsigned to catch overflow.
4292 (Fencode_char): Use INTEGER_TO_CONS.
4293 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4294 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4295 * data.c (long_to_cons, cons_to_long): Remove.
4296 (cons_to_unsigned, cons_to_signed): New functions.
4297 These signal an error for invalid or out-of-range values.
4298 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4299 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4300 * font.c (Ffont_variation_glyphs):
4301 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4302 * lisp.h: Include <intprops.h>.
4303 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4304 (cons_to_signed, cons_to_unsigned): New decls.
4305 (long_to_cons, cons_to_long): Remove decls.
4306 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4307 (Fprimitive_undo): Use CONS_TO_INTEGER.
4308 * xfns.c (Fx_window_property): Likewise.
4309 * xselect.c: Include <limits.h>.
4310 (x_own_selection, selection_data_to_lisp_data):
4311 Use INTEGER_TO_CONS.
4312 (x_handle_selection_request, x_handle_selection_clear)
4313 (x_get_foreign_selection, Fx_disown_selection_internal)
4314 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4315 (lisp_data_to_selection_data): Use cons_to_unsigned.
4316 (x_fill_property_data): Use cons_to_signed.
4317 Report values out of range.
4318
d1f3d2af
PE
4319 Check for buffer and string overflow more precisely.
4320 * buffer.h (BUF_BYTES_MAX): New macro.
4321 * lisp.h (STRING_BYTES_MAX): New macro.
4322 * alloc.c (Fmake_string):
4323 * character.c (string_escape_byte8):
4324 * coding.c (coding_alloc_by_realloc):
4325 * doprnt.c (doprnt):
4326 * editfns.c (Fformat):
4327 * eval.c (verror):
4328 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4329 since they may not be the same number.
4330 * editfns.c (Finsert_char):
4331 * fileio.c (Finsert_file_contents):
4332 Likewise for BUF_BYTES_MAX.
4333
dd52fcea
PE
4334 * image.c: Use ptrdiff_t, not int, for sizes.
4335 (slurp_file): Switch from int to ptrdiff_t.
4336 All uses changed.
4337 (slurp_file): Check that file size fits in both size_t (for
4338 malloc) and ptrdiff_t (for sanity and safety).
4339
7f9bbdbb
PE
4340 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4341 if b->modtime has its maximal value.
4342
dfe18f82
PE
4343 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4344
84acfcf0
PE
4345 Don't assume time_t can fit into int.
4346 * buffer.h (struct buffer.modtime): Now time_t, not int.
4347 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4348 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4349
ccd9a01a
PE
4350 Minor fixes for signed vs unsigned integers.
4351 * character.h (MAYBE_UNIFY_CHAR):
4352 * charset.c (maybe_unify_char):
4353 * keyboard.c (read_char, reorder_modifiers):
4354 XINT -> XFASTINT, since the integer must be nonnegative.
4355 * ftfont.c (ftfont_spec_pattern):
4356 * keymap.c (access_keymap, silly_event_symbol_error):
4357 XUINT -> XFASTINT, since the integer must be nonnegative.
4358 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4359 since it makes no difference and we prefer signed.
4360 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4361 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4362 nonnegative.
4363
d6d100dd
SM
43642011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4365
4366 * window.h (Fwindow_frame): Declare.
4367
2b6148e4
PE
43682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4369
4370 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4371 (SPARE_MEMORY): Always define.
4372 (LARGE_REQUEST): Remove.
4373 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4374
f230ecc9
MR
43752011-06-06 Martin Rudalics <rudalics@gmx.at>
4376
727e958e
MR
4377 * lisp.h: Move EXFUNS for Fframe_root_window,
4378 Fframe_first_window and Fset_frame_selected_window to window.h.
4379
4380 * window.h: Move EXFUNS for Fframe_root_window,
4381 Fframe_first_window and Fset_frame_selected_window here from
4382 lisp.h.
4383
4384 * frame.c (Fwindow_frame, Fframe_first_window)
4385 (Fframe_root_window, Fframe_selected_window)
4386 (Fset_frame_selected_window): Move to window.c.
4387 (Factive_minibuffer_window): Move to minibuf.c.
4388 (Fother_visible_frames_p): New function.
4389
4390 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4391
f230ecc9
MR
4392 * window.c (decode_window, decode_any_window): Move up in code.
4393 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4394 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4395 (Fwindow_buffer): Move up and rewrite doc-string.
4396 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4397 (Fwindow_prev): New functions.
727e958e
MR
4398 (Fwindow_frame): Move here from frame.c. Accept any window as
4399 argument.
4400 (Fframe_root_window, Fframe_first_window)
4401 (Fframe_selected_window): Move here from frame.c. Accept frame
4402 or arbitrary window as argument. Update doc-strings.
4403 (Fminibuffer_window): Move up in code.
4404 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4405 (Fset_frame_selected_window): Move here from frame.c.
4406 Marginal rewrite.
727e958e
MR
4407 (Fselected_window, select_window, Fselect_window): Move up in
4408 code. Minor doc-string fixes.
f230ecc9 4409
4d09bcf6
PE
44102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4411
4412 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4413 Do not assume that spare memory exists; that assumption is valid
4414 only if SYSTEM_MALLOC.
4415 (LARGE_REQUEST): New macro, so that the issue of large requests
4416 is separated from the issue of spare memory.
4417
810928a2
AS
44182011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4419
172418ad
AS
4420 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4421 format. (Bug#8806)
4422
43f862f7
AS
4423 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4424
810928a2
AS
4425 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4426 before statements.
4427
a059fe24
JD
44282011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4429
4430 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4431
4432 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4433
4434 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4435 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4436
989bf368
JB
44372011-06-05 Juanma Barranquero <lekktu@gmail.com>
4438
4439 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4440
4b80f674
CY
44412011-06-04 Chong Yidong <cyd@stupidchicken.com>
4442
4443 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4444 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4445 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4446 New error handlers.
4b80f674
CY
4447 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4448 Obey Vx_select_enable_clipboard_manager. Catch errors in
4449 x_clipboard_manager_save (Bug#8779).
4450 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4451 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4452
99a33b77 44532011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4454
4455 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4456
99a33b77 44572011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4458
4459 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4460 in the current matrix if keep_current_p is non-zero.
4461
8264569d
EZ
44622011-06-04 Eli Zaretskii <eliz@gnu.org>
4463
4464 * bidi.c (bidi_level_of_next_char): Fix last change.
4465
57f97249
EZ
44662011-06-03 Eli Zaretskii <eliz@gnu.org>
4467
fec2107c 4468 Support bidi reordering of text covered by display properties.
57f97249 4469
fec2107c
EZ
4470 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4471 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4472 (bidi_cache_search, bidi_cache_iterator_state)
4473 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4474 (bidi_level_of_next_char, bidi_move_to_visually_next):
4475 Support character positions inside a run of characters covered by a
fec2107c
EZ
4476 display string.
4477 (bidi_paragraph_init, bidi_resolve_explicit_1)
4478 (bidi_level_of_next_char): Call bidi_fetch_char and
4479 bidi_fetch_char_advance instead of FETCH_CHAR and
4480 FETCH_CHAR_ADVANCE.
4481 (bidi_init_it): Initialize new members.
4482 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4483 definitions.
4484 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4485 instead of using explicit *_CHAR codes.
d6d100dd
SM
4486 (bidi_resolve_explicit, bidi_resolve_weak):
4487 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4488 bidirectional text is supported only in multibyte buffers.
4489 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4490 it to initialize the frame_window_p member of struct bidi_it.
4491 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4492 (bidi_resolve_explicit, bidi_resolve_weak)
4493 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4494 bidi_it->nchars is non-positive.
4495 (bidi_level_of_next_char): Don't try to lookup the cache for the
4496 next/previous character if nothing is cached there yet, or if we
4497 were just reseat()'ed to a new position.
c40e2fb2 4498
0e14fe90
EZ
4499 * xdisp.c (set_cursor_from_row): Set start and stop points
4500 according to the row's direction when priming the loop that looks
4501 for the glyph on which to display cursor.
4502 (single_display_spec_intangible_p): Function deleted.
4503 (display_prop_intangible_p): Reimplement to call
4504 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4505 Accept 3 additional arguments needed by handle_display_spec.
4506 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4507 values: lists, `(when COND...)' forms, etc.
4508 (single_display_spec_string_p): Support property values that are
4509 lists with the argument STRING its top-level element.
4510 (display_prop_string_p): Fix the condition for processing a
4511 property that is a list to be consistent with handle_display_spec.
fec2107c 4512 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4513 last portion of handle_display_prop.
4514 (compute_display_string_pos): Accept additional argument
4515 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4516 value of a `display' property is a "replacing spec".
4517 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4518 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4519 the display property, but just return a value indicating whether
4520 the display property will replace the characters it covers.
4521 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4522 frame_window_p members of struct bidi_it.
d6d100dd
SM
4523 (compute_display_string_pos, compute_display_string_end):
4524 New functions.
fec2107c
EZ
4525 (push_it): Accept second argument POSITION, where pop_it should
4526 jump to continue iteration.
4527 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4528
fec2107c
EZ
4529 * keyboard.c (adjust_point_for_property): Adjust the call to
4530 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4531
4532 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4533 (bidi_init_it): Update prototypes.
4534 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4535 (compute_display_string_pos, compute_display_string_end):
4536 Declare prototypes.
fec2107c
EZ
4537 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4538 EMACS_INT.
fc6f18ce 4539
40087514 45402011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4541
57f53182
PE
4542 Malloc failure behavior now depends on size of allocation.
4543 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4544 * lisp.h: Change signatures accordingly.
4545 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4546 All callers changed. (Bug#8762)
4547
4548 * gnutls.c: Use Emacs's memory allocators.
4549 Without this change, the gnutls library would invoke malloc etc.
4550 directly, which causes problems on non-SYNC_INPUT hosts, and which
4551 runs afoul of improving memory_full behavior. (Bug#8761)
4552 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4553 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4554 xfree instead of the default malloc, realloc, free.
4555 (Fgnutls_boot): No need to check for memory allocation failure,
4556 since xmalloc does that for us.
4557
ac32cd99 4558 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4559 * category.c (hash_get_category_set):
4560 * ccl.c (ccl_driver):
4561 * charset.c (Fdefine_charset_internal):
4562 * charset.h (struct charset.hash_index):
4563 * composite.c (get_composition_id, gstring_lookup_cache)
4564 (composition_gstring_put_cache):
4565 * composite.h (struct composition.hash_index):
4566 * dispextern.h (struct image.hash):
4567 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4568 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4569 (hashfn_equal, hashfn_user_defined, make_hash_table)
4570 (maybe_resize_hash_table, hash_lookup, hash_put)
4571 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4572 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4573 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4574 * image.c (make_image, search_image_cache, lookup_image)
4575 (xpm_put_color_table_h):
4576 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4577 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4578 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4579 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4580 * alloc.c (allocate_vectorlike):
4581 Check for overflow in vector size calculations.
4582 * ccl.c (ccl_driver):
4583 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4584 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4585 need to be updated by these changes.
40087514
PE
4586 * fns.c (make_hash_table, maybe_resize_hash_table):
4587 Check for integer overflow with large hash tables.
0de4bb68
PE
4588 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4589 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4590 (SXHASH_REDUCE): New macro.
4591 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4592 Use it instead of discarding useful hash info with large hash values.
4593 (sxhash_float): New function.
4594 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4595 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4596 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4597 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4598 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4599 Adjust signatures to match updated version of code.
4600 (consing_since_gc): Now EMACS_INT, since a single hash table can
4601 use more than INT_MAX bytes.
4602
698d32e2
DN
46032011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4604
4605 Make it possible to build with GCC-4.6+ -O2 -flto.
4606
4607 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4608
fd6fa53f
SM
46092011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4610
4611 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4612 Call minibuffer-inactive-mode.
4613
864db017
JB
46142011-05-31 Juanma Barranquero <lekktu@gmail.com>
4615
4616 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4617 Update dependencies.
4618
2ad0baf4
DN
46192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4620
4621 * data.c (init_data): Remove code for UTS, this system is not
4622 supported anymore.
4623
4fcc2638
DN
46242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4625
4626 Don't force ./temacs to start in terminal mode.
4627
4628 * frame.c (make_initial_frame): Initialize faces in all cases, not
4629 only when CANNOT_DUMP is defined.
4630 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4631
c56e0fd5
DN
46322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4633
4634 * dispnew.c (add_window_display_history): Use const for the string
4635 pointer. Remove declaration, not needed.
4636
333d54da 46372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4638
55d4c1b2 4639 Use 'inline', not 'INLINE'.
333d54da 4640 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4641 * alloc.c, fontset.c (INLINE): Remove.
4642 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4643 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4644 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4645 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4646 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4647
738db178
DN
46482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4649
4650 Make it possible to run ./temacs.
4651
4652 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4653 syms_of_callproc does the same thing. Remove test for
4654 "initialized", do it in the caller.
4655 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4656
620c53a6
SM
46572011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4658
4659 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4660 (read_minibuf): Use get_minibuffer.
4661 (syms_of_minibuf): Use DEFSYM.
4662 (Qmetadata): New var.
4663 * data.c (Qbuffer): Don't make it static.
4664 (syms_of_data): Use DEFSYM.
4665
e003a292
PE
46662011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4667
4668 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4669 (CCL_CODE_MIN): New macro.
4670
ed008a6d
PE
46712011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4672
3687c2ef
PE
4673 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4674
ed008a6d
PE
4675 * eval.c (Qdebug): Now static.
4676 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4677 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4678 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4679
d66c4c7c
CY
46802011-05-29 Chong Yidong <cyd@stupidchicken.com>
4681
4682 * image.c: Various fixes to ImageMagick code comments.
4683 (Fimagemagick_types): Doc fix.
4684
5fbc2025
PE
46852011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4686
0196f88a
PE
4687 Minor fixes prompted by GCC 4.6.0 warnings.
4688
4689 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4690
5fbc2025
PE
4691 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4692 (x_clipboard_manager_save_all): Move extern decl to ...
4693 * xterm.h: ... here, so that it can be checked for consistency.
4694
1dd3c2d9
CY
46952011-05-29 Chong Yidong <cyd@stupidchicken.com>
4696
4697 * xselect.c (x_clipboard_manager_save_frame)
4698 (x_clipboard_manager_save_all): New functions.
4699 (Fx_clipboard_manager_save): Lisp function deleted.
4700
4701 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4702 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4703
4704 * xterm.h: Update prototype.
4705
5ba6571d
WX
47062011-05-28 William Xu <william.xwl@gmail.com>
4707
4708 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4709 exiting (Bug#8239).
4710
3eaff834
JM
47112011-05-28 Jim Meyering <meyering@redhat.com>
4712
e1900994 4713 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4714 * fns.c (to_uchar): Define.
4715 (crypto_hash_function): Use it to convert some newly-signed
4716 variables to unsigned, to avoid sign-extension bugs. For example,
4717 without this change, (md5 "truc") would evaluate to
4718 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4719 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4720 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4721
0f6990a7
PE
47222011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4723
4724 Integer overflow fixes.
c8a9ca5a 4725
08686060
PE
4726 * dbusbind.c: Serial number integer overflow fixes.
4727 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4728 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4729 to hold a serial number that is too large for a fixnum.
4730 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4731 Check for serial numbers out of range. Decode any serial number
59568bf0 4732 that was so large that it became a float. (Bug#8722)
08686060 4733
2d1fc3c7
PE
4734 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4735 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4736 Use XFASTINT rather than XUINT when numbers are nonnegative.
4737 (xd_append_arg, Fdbus_method_return_internal):
4738 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4739 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4740 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4741 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4742 (Bug#8722)
2d1fc3c7 4743
c8a9ca5a
PE
4744 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4745
519e1d69
PE
4746 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4747
30569699
PE
4748 ccl: add integer overflow checks
4749 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4750 (IN_INT_RANGE): New macros.
4751 (ccl_driver): Use them to check for integer overflow when
4752 decoding a CCL program. Many of the new checks are whether XINT (x)
4753 fits in int; it doesn't always, on 64-bit hosts. The new version
4754 doesn't catch all possible integer overflows, but it's an
847044ea 4755 improvement. (Bug#8719)
30569699 4756
c11285dc
PE
4757 * alloc.c (make_event_array): Use XINT, not XUINT.
4758 There's no need for unsigned here.
4759
fdccd48e
PE
4760 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4761 This follows up to the 2011-05-06 change that substituted uintptr_t
4762 for EMACS_INT. This case wasn't caught back then.
4763
37910ab2
PE
4764 Rework Fformat to avoid integer overflow issues.
4765 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4766 now (part of C89). Include <verify.h>.
4767 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4768 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4769 (Fformat): Avoid the prepass trying to compute sizes; it was only
4770 approximate and thus did not catch overflow reliably. Instead, walk
4771 through the format just once, formatting and computing sizes as we go,
4772 checking for integer overflow at every step, and allocating a larger
4773 buffer as needed. Keep track separately whether the format is
4774 multibyte. Keep only the most-recently calculated precision, rather
4775 than them all. Record whether each argument has been converted to
4776 string. Use EMACS_INT, not int, for byte and char and arg counts.
4777 Support field widths and precisions larger than INT_MAX. Avoid
4778 sprintf's undefined behavior with conversion specifications such as %#d
4779 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4780 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4781 formatting out-of-range floating point numbers with int
9173deec 4782 formats. (Bug#8668)
37910ab2 4783
2e6578fb
PE
4784 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4785
0ae6bdee
PE
4786 * data.c: Avoid integer truncation in expressions involving floats.
4787 * data.c: Include <intprops.h>.
4788 (arith_driver): When there's an integer overflow in an expression
4789 involving floating point, convert the integers to floating point
4790 so that the resulting value does not suffer from catastrophic
4791 integer truncation. For example, on a 64-bit host (* 4
4792 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4793 Do not rely on undefined behavior after integer overflow.
4794
de883a70
PE
4795 merge count_size_as_multibyte, parse_str_to_multibyte
4796 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4797 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4798 Check for integer overflow.
4799 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4800 since it's now a duplicate of the other. This is more of
4801 a character than a buffer op, so better that it's in character.c.
4802 * fns.c, print.c: Adjust to above changes.
4803
2ff916cb
PE
48042011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4805
4806 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4807
f1b54466
PE
48082011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4809
fb1ac845
PE
4810 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4811 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4812 (x_clipboard_manager_save): Now static.
4813 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4814
f1b54466
PE
4815 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4816 (crypto_hash_function): Now static.
4817 Fix pointer signedness problems. Avoid unnecessary initializations.
4818
a9f737ee
CY
48192011-05-27 Chong Yidong <cyd@stupidchicken.com>
4820
4821 * termhooks.h (Vselection_alist): Make it terminal-local.
4822
4823 * terminal.c (create_terminal): Initialize it.
4824
4825 * xselect.c: Support for clipboard managers.
4826 (Vselection_alist): Move to termhooks.h as terminal-local var.
4827 (LOCAL_SELECTION): New macro.
4828 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4829 (symbol_to_x_atom): Remove gratuitous arg.
4830 (x_handle_selection_request, lisp_data_to_selection_data)
4831 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4832 (x_own_selection, x_get_local_selection, x_convert_selection):
4833 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4834 (some_frame_on_display): Delete unused function.
4835 (Fx_own_selection_internal, Fx_get_selection_internal)
4836 (Fx_disown_selection_internal, Fx_selection_owner_p)
4837 (Fx_selection_exists_p): New optional frame arg.
4838 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4839 (x_handle_selection_clear): Don't treat other terminals with the
4840 same keyboard specially. Use the terminal-local Vselection_alist.
4841 (x_clear_frame_selections): Use Frun_hook_with_args.
4842
4843 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4844
4845 * xterm.h: Add support for those atoms.
4846
e067f0c1
CY
48472011-05-26 Chong Yidong <cyd@stupidchicken.com>
4848
4849 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4850 (converted_selections, conversion_fail_tag): New global variables.
4851 (x_selection_request_lisp_error): Free the above.
4852 (x_get_local_selection): Remove unnecessary code.
4853 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4854 of converted selections stored in converted_selections.
4855 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4856 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4857 (x_convert_selection): New function.
4858 (x_handle_selection_event): Simplify.
4859 (x_get_foreign_selection): Don't ignore incoming requests while
4860 waiting for an answer; this will fail when we implement
4861 SAVE_TARGETS, and seems unnecessary anyway.
4862 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4863 (Vx_sent_selection_functions): Doc fix.
4864
0f4aebc0
LL
48652011-05-26 Leo Liu <sdl.web@gmail.com>
4866
4867 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4868
e61124cd
YM
48692011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4870
4871 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4872
4873 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4874 for fringe update if it has periodic bitmap.
ac389d0c 4875 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4876 and fringe_bitmap_periodic_p.
4877
4878 * fringe.c (get_fringe_bitmap_data): New function.
4879 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4880 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4881 row. Mark glyph row for fringe update if periodicity changed.
4882
4883 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4884 for fringe update unless it has periodic bitmap.
4885
f16d9837
KH
48862011-05-25 Kenichi Handa <handa@m17n.org>
4887
4888 * xdisp.c (get_next_display_element): Set correct it->face_id for
4889 a static composition.
4890
e1b90ef6
LL
48912011-05-24 Leo Liu <sdl.web@gmail.com>
4892
4893 * deps.mk (fns.o):
4894 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4895
4896 * fns.c (crypto_hash_function, Fsha1): New function.
4897 (Fmd5): Use crypto_hash_function.
4898 (syms_of_fns): Add Ssha1.
4899
7400048f
PE
49002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4901
4902 * gnutls.c: Remove unused macros.
4903 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4904 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4905 Remove macros that are defined and never used.
4906 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4907
abb71cf4
CY
49082011-05-22 Chong Yidong <cyd@stupidchicken.com>
4909
4910 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4911 (Fx_get_selection_internal): Minor cleanup.
4912 (Fx_own_selection_internal): Rename arguments for consistency with
4913 select.el.
4914
6307db39
PE
49152011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4916
4917 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4918
f3d4e0a4
CY
49192011-05-22 Chong Yidong <cyd@stupidchicken.com>
4920
4921 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4922
4d8ade89
YM
49232011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4924
4925 * dispnew.c (scrolling_window): Don't exclude the case that the
4926 last enabled row in the desired matrix touches the bottom boundary.
4927
32078c8d
GM
49282011-05-21 Glenn Morris <rgm@gnu.org>
4929
4930 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4931 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4932 and add some more files.
32078c8d 4933
7285dc67
EZ
49342011-05-20 Eli Zaretskii <eliz@gnu.org>
4935
4936 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4937 report_file_error introduced by the change from 2011-05-07.
4938
89d1bd22
PE
49392011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4940
4941 * systime.h (Time): Define only if emacs is defined.
4942 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4943 where the include path doesn't have X11/X.h by default. See
4944 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4945
e23640bb 49462011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4947
4948 * composite.c (find_automatic_composition): Fix previous change.
4949
b9704ad9
GM
49502011-05-20 Glenn Morris <rgm@gnu.org>
4951
4952 * lisp.mk: New file, split from Makefile.in.
4953 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4954 (shortlisp): Remove.
4955 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4956
4a720484
GM
49572011-05-19 Glenn Morris <rgm@gnu.org>
4958
4959 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4960 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4961 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4962 (lisp): Set the order to that of loadup.el.
4963 (shortlisp): Make it a copy of $lisp.
4964 (SOME_MACHINE_LISP): Remove.
4965 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4966 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4967
a28d4396
KH
49682011-05-18 Kenichi Handa <handa@m17n.org>
4969
4970 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4971 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4972 (find_automatic_composition): Mostly rewrite for efficiency.
4973
a2b1fa8e
JB
49742011-05-18 Juanma Barranquero <lekktu@gmail.com>
4975
4976 * makefile.w32-in: Update dependencies.
4977
8e1f5610
CS
49782011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4979
4980 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4981 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4982
7025ee00 49832011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4984
cdfa6eab
PE
4985 Fix some integer overflow issues, such as string length overflow.
4986
06d6db33
PE
4987 * insdel.c (count_size_as_multibyte): Check for string overflow.
4988
2b4560a8
PE
4989 * character.c (lisp_string_width): Check for string overflow.
4990 Use EMACS_INT, not int, for string indexes and lengths; in
4991 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4992 the resulting string length overflows an EMACS_INT; instead,
4993 report a string overflow if no precision given. When checking for
4994 precision exhaustion, use a check that cannot possibly have
4995 integer overflow. (Bug#8675)
4996 * character.h (lisp_string_width): Adjust to new signature.
4997
cb93f9be
PE
4998 * alloc.c (string_overflow): New function.
4999 (Fmake_string): Use it. This doesn't change behavior, but saves
5000 a few bytes and will simplify future changes.
5001 * character.c (string_escape_byte8): Likewise.
5002 * lisp.h (string_overflow): New decl.
5003
1a1f3366
PE
5004 Fixups, following up to the user-interface timestamp change.
5005 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5006 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5007 * msdos.c (mouse_get_pos): Likewise.
5008 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5009 * w32gui.h (Time): Define by including "systime.h" rather than by
5010 declaring it ourselves. (Bug#8664)
5011
d4e3e4d3
PE
5012 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5013 * image.c (clear_image_cache): Likewise.
5014
f6a24d19
PE
5015 * term.c (term_mouse_position): Don't assume time_t wraparound.
5016
08dc5ae6
PE
5017 Be more systematic about user-interface timestamps.
5018 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5019 and sometimes 'EMACS_UINT', to represent these timestamps.
5020 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5021 This makes the code easier to follow, and makes it easier to catch
5022 integer overflow bugs such as Bug#8664.
5023 * frame.c (Fmouse_position, Fmouse_pixel_position):
5024 Use Time, not unsigned long, for user-interface timestamps.
5025 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5026 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5027 * keyboard.h (last_event_timestamp): Likewise.
5028 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5029 * menu.h (xmenu_show): Likewise.
5030 * term.c (term_mouse_position): Likewise.
5031 * termhooks.h (struct input_event.timestamp): Likewise.
5032 (struct terminal.mouse_position_hook): Likewise.
5033 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5034 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5035 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5036 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5037 what it was before.
5038 * menu.h, termhooks.h: Include "systime.h", for Time.
5039
8e55734a
PE
5040 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5041 Don't assume that the difference between two unsigned long values
5042 can fit into an integer. At this point, we know button_down_time
5043 <= event->timestamp, so the difference must be nonnegative, so
5044 there's no need to cast the result if double-click-time is
5045 nonnegative, as it should be; check that it's nonnegative, just in
5046 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5047 apart (about 25 days). (Bug#8664)
8e55734a 5048
841f1b75 5049 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5050 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5051
3e26f69c
PE
5052 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5053 that always fit in int. Use a sentinel instead of a counter, to
5054 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5055 * frame.h (struct frame): Use int for menu_bar_items_used
5056 instead of EMACS_INT, since it always fits in int.
3e26f69c 5057
5cc152c0
PE
5058 * menu.c (grow_menu_items): Check for int overflow.
5059
d89eb65e
PE
5060 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5061
5235bd3e
PE
5062 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5063 Before, the code was not consistent. These values cannot exceed
5064 2**31 - 1 so there's no need to make them unsigned.
5065 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5066 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5067 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5068 as modifiers.
5069 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5070
bc827e23
PE
5071 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5072 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5073 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5074 presumably because the widths might not match.
5075
78eb494e
PE
5076 * window.c (size_window): Avoid needless test at loop start.
5077
04f2d78b
CB
50782011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5079
5080 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5081
d2fc7e3d 50822011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5083
5084 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5085
d2fc7e3d 50862011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5087
5088 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5089 `width' to `bar_area_x' and `bar_area_width', respectively.
5090 (x_scroll_run): Take account of fringe background extension.
5091
04f2d78b
CB
5092 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5093 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5094 `bar_area_width', respectively.
5095 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5096 background extension.
5097
79b70037
GM
50982011-05-10 Jim Meyering <meyering@redhat.com>
5099
5100 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5101
2f142cc5
JB
51022011-05-10 Juanma Barranquero <lekktu@gmail.com>
5103
5104 * image.c (Finit_image_library): Return t for built-in image types,
5105 like pbm and xbm. (Bug#8640)
5106
57679c86
AS
51072011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5108
5109 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5110
888c9e86
EZ
51112011-05-07 Eli Zaretskii <eliz@gnu.org>
5112
b0512a1d
EZ
5113 * w32console.c (Fset_screen_color): Doc fix.
5114 (Fget_screen_color): New function.
5115 (syms_of_ntterm): Defsubr it.
5116
7285dc67
EZ
5117 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5118 unlink the temporary file if Fcall_process didn't create it in the
5119 first place.
5120 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5121 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5122 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5123 cue to call_process_cleanup not to close that handle.
5124
4d3fcc8e
BK
51252011-05-07 Ben Key <bkey76@gmail.com>
5126
5127 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5128 one of two shell specific rules, either bootstrap-temacs-CMD or
5129 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5130 to the previous implementation of the bootstrap-temacs rule.
5131 The bootstrap-temacs-CMD rule is similar to the previous
5132 implementation of the bootstrap-temacs rule except that it
5133 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5134 variable.
5135
5136 These changes, along with some changes to nt/configure.bat,
5137 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5138 earlier fix to add support for --cflags and --ldflags options
5139 that include quotes so that it works whether make uses cmd or
5140 sh as the shell.
5141
b4289b64
MA
51422011-05-06 Michael Albinus <michael.albinus@gmx.de>
5143
5144 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5145 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5146 is a constant.
5147 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5148 a string. Handle both cases.
5149 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5150 (Fdbus_register_method): Use Qinvalid_function.
5151
af4c0e28
JB
51522011-05-06 Juanma Barranquero <lekktu@gmail.com>
5153
5154 * makefile.w32-in: Update dependencies.
5155 (LISP_H): Add inttypes.h and stdin.h.
5156 (PROCESS_H): Add unistd.h.
5157
c51453d9
EZ
51582011-05-06 Eli Zaretskii <eliz@gnu.org>
5159
5160 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5161 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5162
8ff0ac3c 51632011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5164
4c4b566b
PE
5165 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5166
aab2b9b5
PE
5167 * term.c (vfatal): Remove stray call to va_end.
5168 It's not needed and the C Standard doesn't allow it here anyway.
5169
c378da0b
PE
5170 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5171 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5172
288b08c7
PE
5173 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5174 bytes.
5175
e3601888
PE
5176 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5177
db6c0e74
PE
5178 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5179
dd5963ea
PE
5180 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5181
88c9450f
PE
5182 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5183
2f9442b8
PE
5184 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5185
c032b5f8
PE
5186 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5187 * charset.c (Fdefine_charset_internal): Don't initialize
5188 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5189 32-bit int (Bug#8600).
a108c10b
PE
5190
5191 * lread.c (read_integer): Be more consistent with string-to-number.
5192 Use string_to_number to do the actual conversion; this avoids
5193 rounding errors and fixes some other screwups. Without this fix,
5194 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5195 (digit_to_number): Move earlier, for benefit of read_integer.
5196 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5197 not a digit in any supported base. (Bug#8602)
a108c10b 5198
ad5f9eea
PE
5199 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5200
aec1708a
PE
5201 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5202 to match comment at start of function. This also removes a
5203 GCC warning about overflow in a 32+64-bit port.
5204
47be4ab5
PE
5205 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5206
371cac43
PE
5207 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5208 Reported by Stefan Monnier in
5209 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5210 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5211 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5212
d01a7826
PE
5213 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5214 (EMACS_UINTPTR): Likewise, with uintptr_t.
5215
7fd47d5c
PE
5216 * lisp.h: Prefer 64-bit EMACS_INT if available.
5217 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5218 on 32-bit hosts that have 64-bit int, so that they can access
5219 large files.
122b0c86
PE
5220 However, temporarily disable this change unless the temporary
5221 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5222
8727937b
PE
5223 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5224
8ac068ac
PE
5225 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5226 This removes an assumption that EMACS_INT and long are the same
5227 width as pointers. The assumption is true for Emacs porting targets
5228 now, but we want to make other targets possible.
5229 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5230 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5231 In the rest of the code, change types of integers that hold casted
5232 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5233 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5234 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5235 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5236 No need to cast type when ORing.
5237 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5238 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5239 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5240 assume EMACS_INT is the same width as char *.
5241 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5242 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5243 Remove no-longer-needed casts.
5244 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5245 (xg_tool_bar_help_callback, xg_make_tool_item):
5246 Use EMACS_INTPTR to hold an integer
5247 that will be cast to void *; this can avoid a GCC warning
5248 if EMACS_INT is not the same width as void *.
5249 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5250 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5251 (current_message_1, set_message_1):
5252 Use a local to convert to proper width without a cast.
5253 * xmenu.c (dialog_selection_callback): Likewise.
5254
ede49d71
PE
5255 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5256 Also, don't assume VALBITS / RAND_BITS is less than 5,
5257 and don't rely on undefined behavior when shifting a 1 left into
5258 the sign bit.
5259 * lisp.h (get_random): Change signature to match.
5260
2f30ecd0
PE
5261 * lread.c (hash_string): Use size_t, not int, for hash computation.
5262 Normally we prefer signed values; but hashing is special, because
5263 it's better to use unsigned division on hash table sizes so that
5264 the remainder is nonnegative. Also, size_t is the natural width
5265 for hashing into memory. The previous code used 'int', which doesn't
5266 retain enough info to hash well into very large tables.
5267 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5268
2a866e7b
PE
5269 * dbusbind.c: Don't possibly lose pointer info when converting.
5270 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5271 Use XPNTR rather than XHASH, so that the high-order bits of
5272 the pointer aren't lost when converting through void *.
5273
51639eac
PE
5274 * eval.c (Fautoload): Don't double-shift a pointer.
5275
92394119
PE
5276 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5277
dbdb9a7c
JB
52782011-05-06 Juanma Barranquero <lekktu@gmail.com>
5279
5280 * gnutls.c (DEF_GNUTLS_FN):
5281 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5282
db7a0b4f
AS
52832011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5284
5285 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5286 marker. (Bug#8610)
5287
f7ff1b0f 52882011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5289
5290 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5291 New version that can reserve upto 2GB of heap space.
5292
f7ff1b0f 52932011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5294
5295 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5296
639c109b
TZ
52972011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5298
5299 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5300 `gnutls_certificate_set_x509_key_file'.
5301
d2127135
JB
53022011-05-05 Juanma Barranquero <lekktu@gmail.com>
5303
5304 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5305 Update dependencies.
5306
e968f4f3
JB
53072011-05-04 Juanma Barranquero <lekktu@gmail.com>
5308
5309 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5310 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5311 Remove unused parameter `fildes'.
5312 * process.c (read_process_output, send_process): Don't pass it.
5313
84d358f0
JB
53142011-05-04 Juanma Barranquero <lekktu@gmail.com>
5315
5316 Fix previous change: the library cache is defined in w32.c.
5317 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5318 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5319
0898ca10
JB
53202011-05-04 Juanma Barranquero <lekktu@gmail.com>
5321
5322 Implement dynamic loading of GnuTLS on Windows.
5323
5324 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5325 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5326 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5327 Declare.
5328
5329 * gnutls.c (Qgnutls_dll): Define.
5330 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5331 (gnutls_*): Declare function pointers.
5332 (init_gnutls_functions): New function to initialize function pointers.
5333 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5334 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5335 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5336 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5337 (emacs_gnutls_write, emacs_gnutls_read)
5338 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5339 (Fgnutls_available_p): New function.
5340 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5341 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5342 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5343
5344 * image.c: Include w32.h.
5345 (Vimage_type_cache): Delete.
5346 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5347 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5348 (w32_delayed_load): Move to w32.c.
5349
5350 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5351
5352 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5353 (w32_delayed_load): Move from image.c. When loading a library, record
5354 its filename in the :loaded-from property of the library id.
5355 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5356 Initialize and staticpro them.
5357 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5358
5359 * process.c: Include lisp.h before w32.h, not after.
5360 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5361 instead of gnutls_record_check_pending.
5362
5363 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5364
ff4de4aa
TZ
53652011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5366
5367 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5368 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5369 as passed in.
5370
abe95abb
JD
53712011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5372
5373 * xterm.c (x_set_frame_alpha): Do not set property on anything
5374 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5375
e16e55d4
JB
53762011-05-02 Juanma Barranquero <lekktu@gmail.com>
5377
5378 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5379
bafcf6a5
JB
53802011-05-02 Juanma Barranquero <lekktu@gmail.com>
5381
5382 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5383 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5384 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5385 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5386 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5387 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5388 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5389 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5390 (Qgnutls_bootprop_callbacks_verify): Make static.
5391
e7a6747f
AS
53922011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5393
19ed11ba
AS
5394 * callproc.c: Indentation fixup.
5395
e7a6747f 5396 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5397 (wait_for_termination, interruptible_wait_for_termination):
5398 Move after wait_for_termination_1.
e7a6747f 5399
1ef14cb4
LMI
54002011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5401
5402 * sysdep.c (interruptible_wait_for_termination): New function
5403 which is like wait_for_termination, but allows keyboard
5404 interruptions.
5405
5406 * callproc.c (Fcall_process): Add (:file "file") as an option for
5407 the STDOUT buffer.
5408 (Fcall_process_region): Ditto.
5409
330d880c
EZ
54102011-04-30 Eli Zaretskii <eliz@gnu.org>
5411
8db90b73
EZ
5412 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5413 rather than `XVECTOR (FOO)->size'.
5414
330d880c
EZ
5415 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5416 inttypes.h, as a gnulib replacement is used if it not available in
5417 system headers.
5418
15cbd324
EZ
54192011-04-21 Eli Zaretskii <eliz@gnu.org>
5420
5421 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5422 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5423 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5424
5425 * coding.c (coding_alloc_by_realloc): Error out if destination
5426 will grow beyond MOST_POSITIVE_FIXNUM.
5427 (decode_coding_emacs_mule): Abort if there isn't enough place in
5428 charbuf for the composition carryover bytes. Reserve an extra
5429 space for up to 2 characters produced in a loop.
5430 (decode_coding_iso_2022): Abort if there isn't enough place in
5431 charbuf for the composition carryover bytes.
5432
54332011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5434
ae940cca
EZ
5435 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5436 aborting when %lld or %lll format is passed.
5437 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5438 %llo or %llx format is passed. (Bug#8545)
5439
03ab8921
EZ
5440 * window.c (window_scroll_line_based): Use a marker instead of
5441 simple variables to record original value of point. (Bug#7952)
5442
afda1437
EZ
5443 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5444 produced by %s or %c overflows available buffer space. (Bug#8545)
5445
f76dee0c
PE
54462011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5447
5448 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5449 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5450
fdc5744d
JB
54512011-04-28 Juanma Barranquero <lekktu@gmail.com>
5452
5453 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5454
638f053a
JB
54552011-04-28 Juanma Barranquero <lekktu@gmail.com>
5456
5457 * keyboard.c (Qdelayed_warnings_hook): Define.
5458 (command_loop_1): Run `delayed-warnings-hook'
5459 if Vdelayed_warnings_list is non-nil.
5460 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5461 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5462
d178f871
EZ
54632011-04-28 Eli Zaretskii <eliz@gnu.org>
5464
5465 * doprnt.c (doprnt): Don't return value smaller than the buffer
5466 size if the message was truncated. (Bug#8545).
5467
b124fd93
JB
54682011-04-28 Juanma Barranquero <lekktu@gmail.com>
5469
5470 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5471 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5472
e810457d
PE
54732011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5474
5475 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5476
ea51cceb
JB
54772011-04-27 Juanma Barranquero <lekktu@gmail.com>
5478
5479 * makefile.w32-in: Update dependencies.
5480
94dcfacf
EZ
54812011-04-27 Eli Zaretskii <eliz@gnu.org>
5482
5483 Improve `doprnt' and its usage. (Bug#8545)
5484 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5485 `format_end'. Remove support for %l as a conversion specifier.
5486 Don't use xrealloc. Improve diagnostics when the %l size modifier
5487 is used. Update the commentary.
5488
5489 * eval.c (verror): Simplify calculation of size_t.
5490
5491 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5492 messages.
5493
f61f41d7
PE
54942011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5495
5496 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5497 change.
5498
96fb4434
PE
54992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5500
5501 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5502 This makes this file independent of the recent pseudovector change.
5503
671875da 55042011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5505
69e9b5a3
PE
5506 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5507
b5f869a7 5508 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5509 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5510 Remove unused local.
c8926152 5511 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5512
841a1577 5513 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5514 GCC 4.6.0 optimizes based on type-based alias analysis.
5515 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5516 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5517 != &v->size, and therefore "v->size = 1; b->size = 2; return
5518 v->size;" must therefore return 1. This assumption is incorrect
5519 for Emacs, since it type-puns struct Lisp_Vector * with many other
5520 types. To fix this problem, this patch adds a new type struct
f904488f 5521 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5522 and pseudovectors, and helps optimizing compilers not get fooled
5523 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5524 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5525 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5526 the size member.
eab3844f
PE
5527 (XSETPVECTYPE): Rewrite in terms of new macro.
5528 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5529 This is a bit clearer, and further avoids the possibility of
5530 undesirable aliasing.
5531 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5532 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5533 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5534 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5535 (ASIZE): Now uses header.size rather than size.
5536 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5537 to avoid the hassle of writing XVECTOR (foo)->header.size.
5538 (struct vectorlike_header): New type.
eab3844f
PE
5539 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5540 object, to help avoid aliasing.
5541 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5542 (SUBRP): Likewise, since Lisp_Subr is a special case.
5543 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5544 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5545 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5546 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5547 changed to be "header.size" and "header.next".
5548 * buffer.h (struct buffer): Likewise.
5549 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5550 * frame.h (struct frame): Likewise.
5551 * process.h (struct Lisp_Process): Likewise.
5552 * termhooks.h (struct terminal): Likewise.
5553 * window.c (struct save_window_data, struct saved_window): Likewise.
5554 * window.h (struct window): Likewise.
5555 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5556 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5557 * buffer.c (init_buffer_once): Likewise.
5558 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5559 special case.
5560 * process.c (Fformat_network_address): Use local var for size,
5561 for brevity.
5562
0df1eac5
PE
5563 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5564
847ab9d1 5565 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5566 * data.c (atof): Remove decl; no longer used or needed.
5567 (digit_to_number): Move to lread.c.
5568 (Fstring_to_number): Use new string_to_number function, to be
5569 consistent with how the Lisp reader treats infinities and NaNs.
5570 Do not assume that floating-point numbers represent EMACS_INT
5571 without losing information; this is not true on most 64-bit hosts.
5572 Avoid double-rounding errors, by insisting on integers when
5573 parsing non-base-10 numbers, as the documentation specifies.
5574 * lisp.h (string_to_number): New decl, replacing ...
5575 (isfloat_string): Remove.
bc0a5c13 5576 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5577 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5578 appears to have been a coding error. Similarly, do not accept
5579 strings like +-1e0 as floating point numbers. Do not report
5580 overflow for integer overflows unless the base is not 10 which
5581 means we have no simple and reliable way to continue.
5582 Break out the floating-point parsing into a new
5583 function string_to_number, so that Fstring_to_number parses
5584 floating point numbers consistently with the Lisp reader.
04f2d78b 5585 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5586 (E_CHAR, EXP_INT): Remove, replacing with ...
5587 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5588 (string_to_number): New function, replacing isfloat_string.
5589 This function checks for valid syntax and produces the resulting
5590 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5591 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5592 so that overflow for non-base-10 numbers is reported only when
5593 there's no portable and simple way to convert to floating point.
452f4150 5594
67769ffc
PE
5595 * textprop.c (set_text_properties_1): Rewrite for clarity,
5596 and to avoid GCC warning about integer overflow.
5597
c20db43f
PE
5598 * intervals.h (struct interval): Use EMACS_INT for members
5599 where EMACS_UINT might cause problems. See
5600 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5601 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5602 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5603 All uses changed.
37aa2f85
PE
5604 (offset_intervals): Tell GCC not to worry about length overflow
5605 when negating a negative length.
c20db43f 5606
2538aa2f
PE
5607 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5608 (overrun_check_free): Likewise.
5609
f2d3008d
PE
5610 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5611 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5612 word size.
5613
ec8df744
PE
5614 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5615 (gnutls_make_error): Rename local to avoid shadowing.
5616 (gnutls_emacs_global_deinit): ifdef out; not used.
5617 (Fgnutls_boot): Use const for pointer to readonly storage.
5618 Comment out unused local. Fix pointer signedness problems.
5619
640ee02d
PE
5620 * lread.c (openp): Don't stuff size_t into an 'int'.
5621 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5622 about possible signed overflow.
5623
6048fb2a
PE
5624 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5625 (GDK_KEY_g): Don't define if already defined.
5626 (xg_prepare_tooltip): Avoid pointer signedness problem.
5627 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5628
fa3c87e1
PE
5629 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5630 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5631
2172544b
PE
5632 * xfns.c (Fx_window_property): Simplify a bit,
5633 to make a bit faster and to avoid GCC 4.6.0 warning.
5634 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5635
9b821a21
PE
5636 * fns.c (internal_equal): Don't assume size_t fits in int.
5637
3c616cfa
PE
5638 * alloc.c (compact_small_strings): Tighten assertion a little.
5639
c2982e87
PE
5640 Replace pEd with more-general pI, and fix some printf arg casts.
5641 * lisp.h (pI): New macro, generalizing old pEd macro to other
5642 conversion specifiers. For example, use "...%"pI"d..." rather
5643 than "...%"pEd"...".
5644 (pEd): Remove. All uses replaced with similar uses of pI.
5645 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5646 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5647 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5648 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5649 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5650 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5651 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5652 64-bit hosts.
5653 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5654 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5655 * print.c (safe_debug_print, print_object): Likewise.
5656 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5657 to int.
6f04d126
PE
5658 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5659 avoiding the 0 flag, which is not portable.
c2982e87
PE
5660 * process.c (Fmake_network_process): Use pI to avoid cast.
5661 * region-cache.c (pp_cache): Likewise.
5662 * xdisp.c (decode_mode_spec): Likewise.
5663 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5664 behavior on 64-bit hosts with printf arg.
6f04d126 5665 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5666 (x_stop_queuing_selection_requests): Likewise.
5667 (x_get_window_property): Don't truncate byte count to an 'int'
5668 when tracing.
0b432f21 5669
5e073ec7
PE
5670 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5671 here, since it parses constructs like leading '-' and spaces,
5672 which are not wanted; and it overflows with large numbers.
5673 Instead, simply match F[0-9]+, which is what is wanted anyway.
5674
36372bf9
PE
5675 * alloc.c: Remove unportable assumptions about struct layout.
5676 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5677 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5678 (allocate_vectorlike, make_pure_vector): Use the new macros,
5679 plus offsetof, to remove unportable assumptions about struct layout.
5680 These assumptions hold on all porting targets that I know of, but
5681 they are not guaranteed, they're easy to remove, and removing them
5682 makes further changes easier.
5683
0b432f21
PE
5684 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5685 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5686 (string_overrun_cookie): Now const. Use initializers that
5687 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5688 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5689 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5690 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5691 multiple of sizeof (EMACS_INT); it need not be, if
5692 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5693 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5694
895009e1
JB
56952011-04-26 Juanma Barranquero <lekktu@gmail.com>
5696
5697 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5698
6a7a1b0b
TZ
56992011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5700
5701 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5702 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5703 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5704
841a1577 57052011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5706
5707 * lisp.h (Qdebug): List symbol.
895009e1 5708 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5709 * keyboard.c (debug-on-event): New variable.
5710 (handle_user_signal): Break into debugger when debug-on-event
5711 matches the current signal symbol.
5712
f2d3ba6f
DN
57132011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5714
5715 * alloc.c (check_sblock, check_string_bytes)
5716 (check_string_free_list): Convert to standard C.
5717
42ce4c63
TZ
57182011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5719
5720 * w32.c (emacs_gnutls_push): Fix typo.
5721
825cd63c
EZ
57222011-04-25 Eli Zaretskii <eliz@gnu.org>
5723
fb11d64d
EZ
5724 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5725 "cast to pointer from integer of different size".
5726
825cd63c
EZ
5727 Improve doprnt and its use in verror. (Bug#8545)
5728 * doprnt.c (doprnt): Document the set of format control sequences
5729 supported by the function. Use SAFE_ALLOCA instead of always
5730 using `alloca'.
5731
5732 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5733 is one byte too soon. Don't use xrealloc; instead xfree and
5734 xmalloc anew.
5735
e061a11b
TZ
57362011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5737
5738 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5739 callbacks stage.
5740
5741 * gnutls.c: Renamed global_initialized to
5742 gnutls_global_initialized. Added internals for the
5743 :verify-hostname-error, :verify-error, and :verify-flags
5744 parameters of `gnutls-boot' and documented those parameters in the
5745 docstring. Start callback support.
9173deec
JB
5746 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5747 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5748 on error. Return error code.
e061a11b
TZ
5749 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5750 (emacs_gnutls_read): Likewise.
5751 (Fgnutls_boot): Return handshake error code.
5752 (emacs_gnutls_handle_error): New function.
5753 (wsaerror_to_errno): Likewise.
5754
5755 * w32.h (emacs_gnutls_pull): Add prototype.
5756 (emacs_gnutls_push): Likewise.
5757
5758 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5759 (emacs_gnutls_push): Likewise.
5760
57612011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5762
5763 * process.c (wait_reading_process_output): Check if GnuTLS
5764 buffered some data internally if no FDs are set for TLS
5765 connections.
5766
5767 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5768 (LIBS): Link to USER_LIBS.
5769 ($(BLD)/gnutls.$(0)): New target.
5770
fa6996bc
EZ
57712011-04-24 Eli Zaretskii <eliz@gnu.org>
5772
eb35682e
EZ
5773 * xdisp.c (handle_single_display_spec): Rename the
5774 display_replaced_before_p argument into display_replaced_p, to
5775 make it consistent with the commentary. Fix typos in the
5776 commentary.
5777
e2ad650c
EZ
5778 * textprop.c (syms_of_textprop): Remove dead code.
5779 (copy_text_properties): Delete obsolete commentary about an
5780 interface that was deleted long ago. Fix typos in the description
5781 of arguments.
5782
1b2de274
EZ
5783 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5784 to changes in oldXMenu/XMenu.h from 2011-04-16.
5785 <menu_help_message, prev_menu_help_message>: Constify.
5786 (IT_menu_make_room): menu->help_text is now `const char **';
5787 adjust.
5788
5789 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5790 to changes in oldXMenu/XMenu.h from 2011-04-16.
5791 (struct XMenu): Declare `help_text' `const char **'.
5792
5793 * xfaces.c <Qunspecified>: Make extern again.
5794
5795 * syntax.c: Include sys/types.h before including regex.h, as
5796 required by Posix.
5797
762b15be
EZ
5798 * doc.c (get_doc_string): Improve the format passed to `error'.
5799
5800 * doprnt.c (doprnt): Improve commentary.
5801
5802 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5803
5804 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5805 them with etags.
5806
f1052e5d
EZ
5807 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5808 changes in globals.h immediately force recompilation.
762b15be
EZ
5809 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5810 $(CURDIR)/s/ms-w32.h.
5811 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5812
fa6996bc
EZ
5813 * character.c (Fchar_direction): Function deleted.
5814 (syms_of_character): Don't defsubr it.
5815 <char-direction-table>: Deleted.
5816
e6c3da20
EZ
58172011-04-23 Eli Zaretskii <eliz@gnu.org>
5818
5819 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5820 * doprnt.c: Include limits.h.
5821 (SIZE_MAX): New macro.
04f2d78b
CB
5822 (doprnt): Return a size_t value. 2nd arg is now size_t.
5823 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5824 Improve overflow protection. Support `l' modifier for integer
5825 conversions. Support %l conversion. Don't assume an EMACS_INT
5826 argument for integer conversions and for %c.
5827
5828 * lisp.h (doprnt): Restore prototype.
5829
5830 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5831 $(SRC)/character.h.
5832
5833 * Makefile.in (base_obj): Add back doprnt.o.
5834
5835 * deps.mk (doprnt.o): Add back prerequisites.
5836 (callint.o): Depend on character.h.
5837
5838 * eval.c (internal_lisp_condition_case): Include the handler
5839 representation in the error message.
5840 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5841 when breaking from the loop.
5842
5843 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5844
5845 * callint.c (Fcall_interactively): When displaying error message
5846 about invalid control letter, pass the character's codepoint, not
5847 a pointer to its multibyte form. Improve display of the character
5848 in octal and display also its hex code.
5849
5850 * character.c (char_string): Use %x to display the (unsigned)
5851 codepoint of an invalid character, to avoid displaying a bogus
5852 negative value.
5853
5854 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5855 `error', not SYMBOL_NAME itself.
5856
5857 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5858 character arguments to `error'.
5859
5860 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5861 to `error' in error message about FINAL_CHAR argument. Make sure
5862 FINAL_CHAR is a character, and use %c when it is passed as
5863 argument to `error'.
5864
4ffd0d6b 58652011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5866
5867 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5868
5869 * w32.c: Include <time.h>.
5870 (sys_localtime): New function.
5871
4ffd0d6b 58722011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5873
5874 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5875
4ffd0d6b 5876 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5877
4ffd0d6b 58782011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5879
4ffd0d6b
GM
5880 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5881 zombies (Bug#8467).
aac0c6e3 5882
04c56954
EZ
58832011-04-19 Eli Zaretskii <eliz@gnu.org>
5884
5885 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5886 gl_state.e_property when gl_state.object is Qt.
5887
5888 * insdel.c (make_gap_larger): Remove limitation of buffer size
5889 to <= INT_MAX.
5890
16a43933
CY
58912011-04-18 Chong Yidong <cyd@stupidchicken.com>
5892
5893 * xdisp.c (lookup_glyphless_char_display)
5894 (produce_glyphless_glyph): Handle cons cell entry in
5895 glyphless-char-display.
5896 (Vglyphless_char_display): Document it.
5897
5898 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5899 glyphless-char-display.
5900
4581706e
CY
59012011-04-17 Chong Yidong <cyd@stupidchicken.com>
5902
5903 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5904
5905 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5906
5907 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5908 definition for no-X builds.
5909
4887c6e2 59102011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5911
fd35b6f9
PE
5912 Static checks with GCC 4.6.0 and non-default toolkits.
5913
5c1ccb01
PE
5914 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5915
006c5daa
PE
5916 * process.c (keyboard_bit_set): Define only if SIGIO.
5917 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5918 (send_process): Repair possible setjmp clobbering.
5919
efc736d3
PE
5920 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5921
4e2fe2e6
PE
5922 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5923
f97334a2
PE
5924 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5925
4e75f29d
PE
5926 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5927 Define only if needed.
5928
90efadd1
PE
5929 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5930 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5931 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5932
3c647824
PE
5933 * dispextern.h (struct redisplay_interface): Rename param
5934 to avoid shadowing.
e264f262 5935 * termhooks.h (struct terminal): Likewise.
761383f4 5936 * xterm.c (xembed_send_message): Likewise.
3c647824 5937
b58c5c4a
PE
5938 * insdel.c (make_gap_smaller): Define only if
5939 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5940
cad59032
PE
5941 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5942 it.
5943
c339dc2e
PE
5944 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5945 so that we aren't warned about unused symbols.
5946
91a3e27b
PE
5947 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5948
399c71d3 5949 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5950
8ffc96f5
PE
5951 * xfns.c (x_real_positions): Mark locals as initialized.
5952
eef9bc79
PE
5953 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5954
098db9dd
PE
5955 * xterm.c: Fix problems found by static analysis with other toolkits.
5956 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5957 (x_dispatch_event): Declare static if USE_GTK, and
5958 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5959 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5960 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5961 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5962 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5963
eb18f6cc
PE
5964 * xmenu.c (menu_help_callback): Pointer type fixes.
5965 Use const pointers when pointing at readonly data. Avoid pointer
5966 signedness clashes.
5967 (FALSE): Remove unused macro.
5968 (update_frame_menubar): Remove unused decl.
5969
1fe72bf8
PE
5970 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5971
60d9e1db
PE
5972 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5973 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5974 (single_menu_item): Rename local to avoid shadowing.
5975
39261c26
PE
5976 * keyboard.c (make_lispy_event): Remove unused local var.
5977
018c5e19
PE
5978 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5979 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5980
63d2b86e
PE
5981 * bitmaps: Change bitmaps from unsigned char back to the X11
5982 compatible char. Avoid the old compiler warnings about
5983 out-of-range initializers by using, for example, '\xab' rather
5984 than 0xab.
5985
aefd87e1
PE
5986 * xgselect.c (xgselect_initialize): Check vs interface
5987 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5988
bf501fb9
PE
5989 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5990
e9829fdf
PE
5991 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5992 to read-only memory.
5993
1086c095
PE
5994 * fns.c (vector): Remove; this old hack is no longer needed.
5995
2baccd04 5996 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5997 Remove unused var.
dde42981 5998 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5999
72391843 6000 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6001
436c16df 6002 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6003 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6004 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6005
92bb796d 6006 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6007 (x_term_init): Remove local to avoid shadowing.
92bb796d 6008
764430a3 6009 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6010
6011 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6012 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6013
d1dfb56c
EZ
60142011-04-16 Eli Zaretskii <eliz@gnu.org>
6015
c4354cb4
EZ
6016 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6017
d1dfb56c
EZ
6018 Fix regex.c, syntax.c and friends for buffers > 2GB.
6019 * syntax.h (struct gl_state_s): Declare character position members
6020 EMACS_INT.
6021
6022 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6023
04f2d78b
CB
6024 * textprop.c (verify_interval_modification, interval_of):
6025 Declare arguments EMACS_INT.
d1dfb56c
EZ
6026
6027 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6028 EMACS_INT.
6029
6030 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6031
6032 * indent.c (Fvertical_motion): Local variable it_start is now
6033 EMACS_INT.
6034
6035 * regex.c (re_match, re_match_2, re_match_2_internal)
6036 (bcmp_translate, regcomp, regexec, print_double_string)
6037 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6038 (re_compile_pattern, re_exec): Declare arguments and local
6039 variables `size_t' and `ssize_t' and return values `regoff_t', as
6040 appropriate.
6041 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6042 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6043 <compile_stack_type>: `size' and `avail' are now `size_t'.
6044
6045 * regex.h <regoff_t>: Use ssize_t, not int.
6046 (re_search, re_search_2, re_match, re_match_2): Arguments that
6047 specify buffer/string position and length are now ssize_t and
6048 size_t. Return type is regoff_t.
6049
613052cd
BK
60502011-04-16 Ben Key <bkey76@gmail.com>
6051
6052 * nsfont.m: Fixed bugs in ns_get_family and
6053 ns_descriptor_to_entity that were caused by using free to
6054 deallocate memory blocks that were allocated by xmalloc (via
6055 xstrdup). This caused Emacs to crash when compiled with
6056 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6057 --enable-checking=xmallocoverrun). xfree is now used to
6058 deallocate these memory blocks.
6059
4170f62f 60602011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6061
71b41406
PE
6062 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6063
9587a89d
PE
6064 emacs_write: Accept and return EMACS_INT for sizes.
6065 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6066 et seq.
6067 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6068 Accept and return EMACS_INT.
6069 (emacs_gnutls_write): Return the number of bytes written on
6070 partial writes.
6071 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6072 (emacs_read, emacs_write): Remove check for negative size, as the
6073 Emacs source code has been audited now.
9587a89d
PE
6074 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6075 (emacs_read, emacs_write): Use it.
273a5f82
PE
6076 * process.c (send_process): Adjust to the new signatures of
6077 emacs_write and emacs_gnutls_write. Do not attempt to store
6078 a byte offset into an 'int'; it might overflow.
9587a89d 6079 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6080
3e047f51
PE
6081 * sound.c: Don't assume sizes fit in 'int'.
6082 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6083 Return EMACS_INT, not int.
3e047f51 6084 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6085 Accept EMACS_INT, not int.
6086 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6087 record read return values.
6088
cc39a9db
BK
60892011-04-15 Ben Key <bkey76@gmail.com>
6090
c9d0ec6d
JB
6091 * keyboard.c (Qundefined): Don't declare static since it is used
6092 in nsfns.m.
6093 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6094 static since they are used in nsfont.m.
cc39a9db 6095
6c60eb9f
SM
60962011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6097
6098 * process.c (Qprocessp): Don't declare static.
6099 * lisp.h (Qprocessp): Declare again.
6100
7990b61a
JB
61012011-04-15 Juanma Barranquero <lekktu@gmail.com>
6102
6103 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6104
5d4cb038
PE
61052011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6106
8bd7b830 6107 Improve C-level modularity by making more things 'static'.
cd64ea1d 6108
e3b27b31
PE
6109 Don't publish debugger-only interfaces to other modules.
6110 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6111 (verify_bytepos, count_markers): Move decls to the only modules
6112 that need them.
6113 * region-cache.h (pp_cache): Likewise.
6114 * window.h (check_all_windows): Likewise.
6115 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6116
5d4cb038
PE
6117 * sysdep.c (croak): Now static, if
6118 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6119 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6120
6121 * alloc.c (refill_memory_reserve): Now static if
6122 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6123 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6124
e87b6180
PE
6125 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6126 Define only if USE_LUCID.
6127
ac64929e
PE
6128 * xrdb.c (x_customization_string, x_rm_string): Now static.
6129
6f37259d
PE
6130 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6131 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6132
1683e3ab
PE
6133 * xdisp.c (draw_row_with_mouse_face): Now static.
6134 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6135
de9c2632
PE
6136 * window.h (check_all_windows): Mark externally visible.
6137
2b96acb7
PE
6138 * window.c (window_deletion_count): Now static.
6139
6140 * undo.c: Make symbols static if they're not exported.
6141 (last_undo_buffer, last_boundary_position, pending_boundary):
6142 Now static.
6143
50436f33
PE
6144 * textprop.c (interval_insert_behind_hooks): Now static.
6145 (interval_insert_in_front_hooks): Likewise.
6146
64520e5c
PE
6147 * term.c: Make symbols static if they're not exported.
6148 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6149 (max_frame_lines, tty_set_terminal_modes):
6150 (tty_reset_terminal_modes, tty_turn_off_highlight):
6151 (get_tty_terminal): Now static.
6152 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6153 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6154 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6155 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6156 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6157
1fa53021
PE
6158 * sysdep.c: Make symbols static if they're not exported.
6159 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6160 Now static.
6161 (sigprocmask_set, full_mask): Remove; unused.
6162 (wait_debugging): Mark as visible.
6163 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6164 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6165
d4b43b22
PE
6166 * syntax.c (syntax_temp): Define only if !__GNUC__.
6167
b7c513d0
PE
6168 * sound.c (current_sound_device, current_sound): Now static.
6169
989b29ad
PE
6170 * search.c (searchbufs, searchbuf_head): Now static.
6171
13a55a78
PE
6172 * scroll.c (scroll_cost): Remove; unused.
6173 * dispextern.h (scroll_cost): Remove decl.
6174
de68a1fc
PE
6175 * region-cache.h (pp_cache): Mark as externally visible.
6176
40ccffa6
PE
6177 * process.c: Make symbols static if they're not exported.
6178 (process_tick, update_tick, create_process, chan_process):
6179 (Vprocess_alist, proc_buffered_char, datagram_access):
6180 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6181 (deactivate_process): Mark defn as static, as well as decl.
6182 * lisp.h (create_process): Remove decl.
6183 * process.h (chan_process, Vprocess_alist): Remove decls.
6184
ad64fc97
PE
6185 * print.c: Make symbols static if they're not exported.
6186 (print_depth, new_backquote_output, being_printed, print_buffer):
6187 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6188 (print_interval, print_number_index, initial_stderr_stream):
6189 Now static.
6190 * lisp.h (Fprinc): Remove decl.
6191 (debug_output_compilation_hack): Mark as externally visible.
6192
adddb265
PE
6193 * sysdep.c (croak): Move decl from here to syssignal.h.
6194 * syssignal.h (croak): Put it here, so the API can be checked when
6195 'croak' is called from dissociate_if_controlling_tty.
6196
1717ede2
PE
6197 * minibuf.c: Make symbols static if they're not exported.
6198 (minibuf_save_list, choose_minibuf_frame): Now static.
6199 * lisp.h (choose_minibuf_frame): Remove decl.
6200
fa5fb2bc
PE
6201 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6202
1e3890d1
PE
6203 * lread.c: Make symbols static if they're not exported.
6204 (read_objects, initial_obarray, oblookup_last_bucket_number):
6205 Now static.
6206 (make_symbol): Remove; unused.
6207 * lisp.h (initial_obarray, make_symbol): Remove decls.
6208
8a1414fa
PE
6209 * keyboard.c: Make symbols static if they're not exported.
6210 (single_kboard, recent_keys_index, total_keys, recent_keys):
6211 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6212 (this_single_command_key_start, echoing, last_auto_save):
6213 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6214 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6215 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6216 (Vlispy_mouse_stem, double_click_count):
6217 Now static.
6218 (force_auto_save_soon): Define only if SIGDANGER.
6219 (ignore_mouse_drag_p): Now static if
6220 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6221 (print_help): Remove; unused.
6222 (stop_character, last_timer_event): Mark as externally visible.
6223 * keyboard.h (ignore_mouse_drag_p): Declare only if
6224 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6225 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6226 * lisp.h (echoing): Remove decl.
6227 (force_auto_save_soon): Declare only if SIGDANGER.
6228 * xdisp.c (redisplay_window): Simplify code, to make it more
6229 obvious that ignore_mouse_drag_p is not accessed if !defined
6230 USE_GTK && !defined HAVE_NS.
6231
93ea6e8f
PE
6232 * intervals.c: Make symbols static if they're not exported.
6233 (merge_properties_sticky, merge_interval_right, delete_interval):
6234 Now static.
6235 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6236
77382fcc
PE
6237 * insdel.c: Make symbols static if they're not exported.
6238 However, leave prepare_to_modify_buffer alone. It's never
6239 called from outside this function, but that appears to be a bug.
6240 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6241 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6242 (adjust_after_replace_noundo): Remove; unused.
6243 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6244 (signal_before_change): Remove decls.
77382fcc 6245
9306c32e
PE
6246 * indent.c (val_compute_motion, val_vmotion): Now static.
6247
cd44d2eb
PE
6248 * image.c: Make symbols static if they're not exported.
6249 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6250 if USE_GTK.
6251 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6252 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6253
ad9a7a06
PE
6254 * fringe.c (standard_bitmaps): Now static.
6255 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6256
81626931
PE
6257 * frame.c: Make symbols static if they're not exported.
6258 (x_report_frame_params, make_terminal_frame): Now static.
6259 (get_frame_param): Now static, unless HAVE_NS.
6260 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6261 (x_get_resource_string): Remove; not used.
6262 * frame.h (make_terminal_frame, x_report_frame_params):
6263 (x_get_resource_string); Remove decls.
6264 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6265 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6266
239f9db9
PE
6267 * font.c, fontset.c: Make symbols static if they're not exported.
6268 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6269 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6270 * font.c (font_close_object): Now static.
6271 * font.h (font_close_object): Remove.
6272 * fontset.c (FONTSET_OBJLIST): Remove.
6273 (free_realized_fontset) #if-0 the body, which does nothing.
6274 (face_suitable_for_char_p): #if-0, as it's never called.
6275 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6276 * xfaces.c (face_at_string_position):
6277 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6278 since 0 is always ASCII.
6279
dfcf3579
PE
6280 * fns.c (weak_hash_tables): Now static.
6281
5045092b
PE
6282 * fileio.c: Make symbols static if they're not exported.
6283 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6284 (Vwrite_region_annotation_buffers): Now static.
6285
57a96f5c
PE
6286 * eval.c: Make symbols static if they're not exported.
6287 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6288 * lisp.h (backtrace_list): Remove decl.
6289
35f08c38
PE
6290 * emacs.c: Make symbols static if they're not exported.
6291 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6292 (fatal_error_code, fatal_error_signal_hook, standard_args):
6293 Now static.
6294 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6295 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6296 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6297 * lisp.h (fatal_error_signal_hook): Remove decl.
6298 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6299
f44bd759
PE
6300 * editfns.c: Move a (normally-unused) function to its only use.
6301 * editfns.c, lisp.h (get_operating_system_release): Remove.
6302 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6303 worth the hassle of breaking this out.
6304
b532497d
PE
6305 * xterm.c: Make symbols static if they're not exported.
6306 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6307 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6308 (x_destroy_window, x_delete_display):
6309 Now static.
6310 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6311 (x_mouse_leave): Remove; unused.
6312 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6313 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6314 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6315 Remove decls.
6316 (x_mouse_leave): Declare only if WINDOWSNT.
6317 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6318 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6319 USE_X_TOOLKIT.
6320
1675728f
PE
6321 * ftxfont.c: Make symbols static if they're not exported.
6322 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6323 HAVE_FREETYPE.
6324 * font.h (ftxfont_driver): Likewise.
6325
e4cebfca
PE
6326 * xfns.c: Make symbols static if they're not exported.
6327 (x_last_font_name, x_display_info_for_name):
6328 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6329 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6330 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6331 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6332 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6333 (last_show_tip_args): Now static.
6334 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6335 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6336 (x_screen_planes): Remove; unused.
6337 * dispextern.h (x_screen_planes): Remove decl.
6338
5bf46f05
PE
6339 * dispnew.c: Make symbols static if they're not exported.
6340 * dispextern.h (redraw_garbaged_frames, scrolling):
6341 (increment_row_positions): Remove.
6342 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6343 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6344 Now static.
6345 (redraw_garbaged_frames): Remove; unused.
6346
435f4c28
PE
6347 * xfaces.c: Make symbols static if they're not exported.
6348 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6349 Remove decls.
6350 * xterm.h (defined_color): Remove decls.
6351 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6352 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6353 (menu_face_changed_default, defined_color, free_realized_face):
6354 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6355 (ascii_face_of_lisp_face): Remove; unused.
6356
8524aef3
PE
6357 * xdisp.c: Make symbols static if they're not exported.
6358 * dispextern.h (scratch_glyph_row, window_box_edges):
6359 (glyph_to_pixel_coords, set_cursor_from_row):
6360 (get_next_display_element, set_iterator_to_next):
6361 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6362 (show_mouse_face): Remove decls
6363 * frame.h (message_buf_print): Likewise.
6364 * lisp.h (pop_message, set_message, check_point_in_composition):
6365 Likewise.
6366 * xterm.h (set_vertical_scroll_bar): Likewise.
6367 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6368 (message_buf_print, scratch_glyph_row, displayed_buffer):
6369 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6370 (get_next_display_element, show_mouse_face, window_box_edges):
6371 (frame_to_window_pixel_xy, check_point_in_composition):
6372 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6373 (glyph_to_pixel_coords): Remove; unused.
6374
16390cd2
PE
6375 * dired.c (file_name_completion): Now static.
6376
6377 * dbusbind.c (xd_in_read_queued_messages): Now static.
6378
a25f4dfa
PE
6379 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6380 * data.c (circular_list_error): Remove.
6381
14a9c8df
PE
6382 * commands.h (last_point_position, last_point_position_buffer):
6383 (last_point_position_window): Remove decls.
6384 * keyboard.c: Make these variables static.
6385
04f2d78b
CB
6386 * coding.h (coding, code_convert_region, encode_coding_gap):
6387 Remove decls.
74ab6df5
PE
6388 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6389 (iso_code_class, detect_coding, code_convert_region): Now static.
6390 (encode_coding_gap): Remove; unused.
6391
38dfbee1
PE
6392 * chartab.c (chartab_chars, chartab_bits): Now static.
6393
a2cb4e63
PE
6394 * charset.h (charset_iso_8859_1): Remove decl.
6395 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6396 Now static.
6397
127198fd
PE
6398 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6399 * ccl.c (Vccl_program_table): Now static.
6400 (check_ccl_update): Remove; unused.
6401
d85b608f
PE
6402 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6403 * category.h: ... from here.
6404 * category.c (check_category_table, set_category_set): Now static.
6405
31cd66f3
PE
6406 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6407 * lisp.h: Remove these decls.
6408
c358e587
PE
6409 * buffer.c (buffer_count): Remove unused var.
6410
e78aecca
PE
6411 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6412 so that it's not optimized away.
6413 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6414 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6415 exported only to the debugger.
6416
e192d7d3 6417 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6418 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6419
92470028
PE
6420 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6421 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6422 was inaccessible from Lisp.
6423 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6424 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6425
244ed907
PE
6426 alloc.c: Import and export fewer symbols, and remove unused items.
6427 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6428 is defined.
6429 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6430 it's not optimized away by whole-program optimization.
6431 (message_enable_multibyte, free_misc): Remove.
6432 (catchlist, handlerlist, mark_backtrace):
6433 Declare only if BYTE_MARK_STACK.
6434 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6435 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6436 (message_enable_multibyte): Remove decl.
6437 (free_misc, interval_free_list, float_block, float_block_index):
6438 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6439 (cons_free_list, last_marked_index):
6440 Now static.
6441 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6442 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6443 (mark_backtrace): Define only if BYTE_MARK_STACK.
6444 * xdisp.c (message_enable_multibyte): Now static.
6445
61c2b50e 6446 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6447 This makes it easier for human readers (and static analyzers)
6448 to see whether these variables are used from other modules.
6449 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6450 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6451 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6452 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6453 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6454 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6455 * xmenu.c, xselect.c:
6456 Declare Q* vars static if they are not used in other modules.
6457 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6458 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6459 Remove decls of unexported vars.
6460 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6461
95c82688
PE
6462 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6463
16a97296
PE
6464 Make Emacs functions such as Fatom 'static' by default.
6465 This makes it easier for human readers (and static analyzers)
6466 to see whether these functions can be called from other modules.
6467 DEFUN now defines a static function. To make the function external
6468 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6469 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6470 (Finit_image_library):
16a97296
PE
6471 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6472 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6473 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6474 Remove decls, since these functions are now static.
6475 (Funintern, Fget_internal_run_time): New decls, since these functions
6476 were already external.
95c82688 6477
16a97296
PE
6478 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6479 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6480 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6481 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6482 * keyboard.c, keymap.c, lread.c:
6483 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6484 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6485 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6486 Mark functions with DEFUE instead of DEFUN,
6487 if they are used in other modules.
6488 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6489 decls for now-static functions.
6490 * buffer.h (Fdelete_overlay): Remove decl.
6491 * callproc.c (Fgetenv_internal): Mark as internal.
6492 * composite.c (Fremove_list_of_text_properties): Remove decl.
6493 (Fcomposition_get_gstring): New forward static decl.
6494 * composite.h (Fcomposite_get_gstring): Remove decl.
6495 * dired.c (Ffile_attributes): New forward static decl.
6496 * doc.c (Fdocumntation_property): New forward static decl.
6497 * eval.c (Ffetch_bytecode): New forward static decl.
6498 (Funintern): Remove extern decl; now in .h file where it belongs.
6499 * fileio.c (Fmake_symbolic_link): New forward static decl.
6500 * image.c (Finit_image_library): New forward static decl.
6501 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6502 * intervals.h (Fprevious_property_change):
6503 (Fremove_list_of_text_properties): Remove decls.
6504 * keyboard.c (Fthis_command_keys): Remove decl.
6505 (Fcommand_execute): New forward static decl.
6506 * keymap.c (Flookup_key): New forward static decl.
6507 (Fcopy_keymap): Now static.
6508 * keymap.h (Flookup_key): Remove decl.
6509 * process.c (Fget_process): New forward static decl.
6510 (Fprocess_datagram_address): Mark as internal.
6511 * syntax.c (Fsyntax_table_p): New forward static decl.
6512 (skip_chars): Remove duplicate decl.
6513 * textprop.c (Fprevious_property_change): New forward static decl.
6514 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6515 Now internal.
6516 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6517 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6518
785bbd42
PE
6519 * editfns.c (Fformat): Remove unreachable code.
6520
8b913b57
AS
65212011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6522
6523 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6524 change. (Bug#8496)
6525
a6744a35
EZ
65262011-04-13 Eli Zaretskii <eliz@gnu.org>
6527
6528 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6529 when at ZV. (Bug#8487)
6530
e7974947
AS
65312011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6532
baad03f0
AS
6533 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6534 (Bug#8437)
6535 * keyboard.c (parse_tool_bar_item): Likewise.
6536 * sound.c (sound_cleanup, alsa_close): Likewise.
6537 * termcap.c (tgetent): Likewise.
6538 * xfns.c (x_default_font_parameter): Likewise.
6539 * xsettings.c (read_and_apply_settings): Likewise.
6540
e7974947
AS
6541 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6542 (overrun_check_free): Protoize.
6543
28272684
PE
65442011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6545
6546 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6547 since callers should never pass a negative size.
6548 Change the signature to match that of plain 'read' and 'write'; see
6549 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6550 * lisp.h: Update prototypes of emacs_write and emacs_read.
6551
11997c76
EZ
65522011-04-11 Eli Zaretskii <eliz@gnu.org>
6553
6554 * xdisp.c (redisplay_window): Don't try to determine the character
6555 position of the scroll margin if the window start point w->startp
e896f03c 6556 is outside the buffer's accessible region. (Bug#8468)
11997c76 6557
8a2cbd72
EZ
65582011-04-10 Eli Zaretskii <eliz@gnu.org>
6559
6560 Fix write-region and its subroutines for buffers > 2GB.
6561 * fileio.c (a_write, e_write): Modify declaration of arguments and
6562 local variables to support buffers larger than 2GB.
6563 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6564
6565 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6566 argument, local variables, and return value.
6567
6568 * lisp.h: Update prototypes of emacs_write and emacs_read.
6569
6570 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6571
4073e537 65722011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6573
1ebfdcb6
PE
6574 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6575
b2ded58d
PE
6576 Fix more problems found by GCC 4.6.0's static checks.
6577
7d66342c
PE
6578 * xdisp.c (vmessage): Use a better test for character truncation.
6579
bbf47d44
PE
6580 * charset.c (load_charset_map): <, not <=, for optimization,
6581 and to avoid potential problems with integer overflow.
9248994d 6582 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6583 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6584 * editfns.c (Fformat): Likewise.
1e69125e 6585 * syntax.c (skip_chars): Likewise.
3befa583 6586
e3019616
PE
6587 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6588 This also lets GCC 4.6.0 generate slightly better loop code.
6589
becfa255
PE
6590 * callint.c (Fcall_interactively): <, not <=, for optimization.
6591 (Fcall_interactively): Count the number of arguments produced,
6592 not the number of arguments given. This is simpler and lets GCC
6593 4.6.0 generate slightly better code.
6594
dae0cd48
PE
6595 * ftfont.c: Distingish more carefully between FcChar8 and char.
6596 The previous code passed unsigned char * to a functions like
6597 strlen and xstrcasecmp that expect char *, which does not
6598 conform to the C standard.
6599 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6600 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6601 char * when the C standard requires it.
6602
76032d70
PE
6603 * keyboard.c (read_char): Remove unused var.
6604
eb3f1cc8
PE
6605 * eval.c: Port to Windows vsnprintf (Bug#8435).
6606 Include <limits.h>.
6607 (SIZE_MAX): Define if the headers do not.
6608 (verror): Do not give up if vsnprintf returns a negative count.
6609 Instead, grow the buffer. This ports to Windows vsnprintf, which
6610 does not conform to C99. Problem reported by Eli Zaretskii.
6611 Also, simplify the allocation scheme, by avoiding the need for
6612 calling realloc, and removing the ALLOCATED variable.
6613
70476b54
PE
6614 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6615
12020a9e
PE
6616 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6617 But keep the doprint source code for now, as we might revamp it
6618 and use it again (Bug#8435).
ea6c7ae6
PE
6619 * lisp.h (doprnt): Remove.
6620 * Makefile.in (base_obj): Remove doprnt.o.
6621 * deps.mk (doprnt.o): Remove.
6622
5fdb398c
PE
6623 error: Print 32- and 64-bit integers portably (Bug#8435).
6624 Without this change, on typical 64-bit hosts error ("...%d...", N)
6625 was used to print both 32- and 64-bit integers N, which relied on
6626 undefined behavior.
6627 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6628 New macro.
6629 * lisp.h (error, verror): Mark as printf-like functions.
6630 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6631 Report overflow in size calculations when allocating printf buffer.
6632 Do not truncate output string at its first null byte.
6633 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6634 Truncate the output at a character boundary, since vsnprintf does not
6635 do that.
6636 * charset.c (check_iso_charset_parameter): Convert internal
6637 character to string before calling 'error', since %c now has the
6638 printf meaning.
6639 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6640 overflow when computing char to be passed to 'error'. Do not
6641 pass Lisp_Object to 'error'; pass the integer instead.
6642 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6643 formatted with plain %d.
6644
b189fa66
PE
6645 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6646
bff87ef0
PE
6647 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6648
7e2cac20
PE
6649 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6650
ce4d90b5
PE
6651 * xterm.c (x_catch_errors): Remove duplicate declaration.
6652
266c9547
PE
6653 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6654
79c49ad2
PE
6655 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6656
368f4090
JM
66572011-04-10 Jim Meyering <meyering@redhat.com>
6658
6659 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6660 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6661 return ssize_t not "int", and use size_t as the buffer length.
6662 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6663 * gnutls.h: Update declarations.
6664 * process.c (read_process_output): Use ssize_t, to match.
6665 (send_process): Likewise.
6666
a32d4040
CY
66672011-04-09 Chong Yidong <cyd@stupidchicken.com>
6668
6669 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6670
8546720e 66712011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6672
04f2d78b
CB
6673 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6674 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6675
8546720e
GM
6676 * xterm.c (handle_one_xevent):
6677 * xmenu.c (create_and_show_popup_menu):
6678 * xselect.c (x_decline_selection_request)
6679 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6680
0a2f5c1a 66812011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6682
6683 Fix some uses of `int' instead of EMACS_INT.
6684 * search.c (string_match_1, fast_string_match)
6685 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6686 (scan_buffer, find_next_newline_no_quit)
6687 (find_before_next_newline, search_command, Freplace_match)
6688 (Fmatch_data): Make some `int' variables be EMACS_INT.
6689
6690 * xdisp.c (display_count_lines): 3rd argument and return value now
6691 EMACS_INT. All callers changed.
6692 (pint2hrstr): Last argument is now EMACS_INT.
6693
6694 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6695 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6696 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6697 (decode_coding_utf_16, decode_coding_emacs_mule)
6698 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6699 (decode_coding_ccl, decode_coding_charset)
6700 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6701 (decode_coding_iso_2022, decode_coding_emacs_mule)
6702 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6703 <char_offset, last_offset>: Declare EMACS_INT.
6704 (encode_coding_utf_8, encode_coding_utf_16)
6705 (encode_coding_emacs_mule, encode_invocation_designation)
6706 (encode_designation_at_bol, encode_coding_iso_2022)
6707 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6708 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6709 Declare EMACS_INT.
6710 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6711 (encode_invocation_designation): Last argument P_NCHARS is now
6712 EMACS_INT.
6713 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6714 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6715
6716 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6717 All users changed.
6718
6719 * ccl.c (Fccl_execute_on_string): Declare some variables
6720 EMACS_INT.
6721
8546720e 67222011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6723
6724 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6725
4e19a977
CS
67262011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6727
6728 * process.c (Fformat_network_address): Doc fix.
6729
87302331
R
67302011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6731
6732 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6733
cbb59342
CY
67342011-04-08 Chong Yidong <cyd@stupidchicken.com>
6735
6736 * keyboard.c (read_char): Call Lisp function help-form-show,
6737 instead of using internal_with_output_to_temp_buffer.
6738 (Qhelp_form_show): New var.
e0d38eeb 6739 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6740
6741 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6742
6743 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6744
e67a13ab
CY
67452011-04-06 Chong Yidong <cyd@stupidchicken.com>
6746
04f2d78b
CB
6747 * process.c (Flist_processes): Remove to Lisp.
6748 (list_processes_1): Delete.
e67a13ab 6749
973f782d
EZ
67502011-04-06 Eli Zaretskii <eliz@gnu.org>
6751
7c106b1e
EZ
6752 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6753
973f782d
EZ
6754 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6755
41cf7d1a 67562011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6757
ca23cc88
PE
6758 Fix more problems found by GCC 4.6.0's static checks.
6759
f390e2d5
PE
6760 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6761
42eea0d0
PE
6762 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6763
b69769da 6764 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6765
f9541e84
PE
6766 * xdisp.c (vmessage): Mark as a printf-like function.
6767
13841b55
PE
6768 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6769
c136c10f
PE
6770 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6771
5e2d4a30
PE
6772 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6773 printf-like functions.
6774 (tiff_load): Add casts to remove these marks before passing them
6775 to system-supplied API.
6776
583f48b9
PE
6777 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6778
b25d760e
PE
6779 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6780 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6781 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6782 directly, rather than having caller test rule sign. This avoids
6783 some unnecessary tests.
6784 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6785 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6786 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6787
bc7b6697 6788 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6789 (xfont_open): Avoid unnecessary tests.
bc7b6697 6790
27ccc379
PE
6791 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6792
dcd5c89a
PE
6793 * composite.h, composite.c (composition_gstring_put_cache):
6794 Use EMACS_INT, not int, for length.
6795
b13a45c6
PE
6796 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6797 breaking out part of COMPOSITION_DECODE_RULE.
6798 (COMPOSITION_DECODE_RULE): Use it.
6799 * composite.c (get_composition_id): Remove unused local vars,
6800 by using the new macro.
6801
1e792e4d
PE
6802 * textprop.c (set_text_properties_1): Change while to do-while,
6803 since the condition is always true at first.
6804
dc6c6455 6805 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6806 (interval_deletion_adjustment): Return unsigned value.
6807 All uses changed.
dc6c6455 6808
aba7731a
PE
6809 * process.c (list_processes_1, create_pty, read_process_output):
6810 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6811 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6812 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6813 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6814 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6815
fdfc4bf3
PE
6816 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6817
fca8fe46 6818 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6819 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6820
06a0259a 6821 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6822 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6823 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6824
e7b9e80f
PE
6825 * print.c (print_error_message): Avoid int overflow.
6826
56201685
PE
6827 * font.c (font_list_entities): Redo for clarity,
6828 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6829
78834453 6830 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6831 (font_score): Avoid potential overflow in diff calculation.
78834453 6832
0bc0b309 6833 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6834 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6835
e610eaca
PE
6836 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6837
b895abce
PE
6838 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6839 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6840 can always succeed if overflow has undefined behavior.
6841
1f1d9321 6842 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6843 (wordify): Omit three unnecessary tests.
1f1d9321 6844
c59478bc
PE
6845 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6846 All callers changed. This avoids the need for an unused var.
6847
79b73827
PE
6848 * casefiddle.c (casify_region): Remove var that is set but not used.
6849
a4db5dfe
PE
6850 * dired.c (file_name_completion): Remove var that is set but not used.
6851
43aae36e
PE
6852 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6853
2a47c44d 6854 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6855 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6856
a37c69bf
PE
6857 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6858 Check for integer overflow on size calculations.
6859
328ab8e7
PE
6860 * buffer.c (Fprevious_overlay_change): Remove var that is set
6861 but not used.
6862
e5a2a5cb
PE
6863 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6864 Remove vars that are set but not used.
8d84a6eb 6865 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6866 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6867
a60e5f68
PE
6868 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6869
f661cb61 6870 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6871 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6872
f0397f5a
PE
6873 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6874 that are set but not used.
6875
8664db06 6876 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6877 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6878
6abdaa4a
PE
6879 * xselect.c (x_get_local_selection, x_handle_property_notify):
6880 Remove vars that are set but not used.
6881
0ce7538d 6882 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6883 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6884
9ae848fc
PE
6885 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6886 Remove var that is set but not used.
0b918413
PE
6887 (scroll_bar_windows_size): Now size_t, not int.
6888 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6889 Check for overflow.
9ae848fc 6890
a5a62657
PE
6891 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6892 (map_tty_color) [!defined MSDOS]: Likewise.
6893
5c5cdd39
PE
6894 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6895
66ebf983
PE
6896 * coding.c: Remove vars that are set but not used.
6897 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6898 All callers changed.
6899 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6900 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6901 (decode_coding_charset): Remove vars that are set but not used.
6902
1be4d761
PE
6903 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6904 that is set but not used.
6905
47553fa8
PE
6906 * print.c (print_object): Remove var that is set but not used.
6907
1f7196bf 6908 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6909 The gnulib version avoids calling malloc in the usual case,
6910 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6911 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6912 * filelock.c (current_lock_owner): Likewise.
6913 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6914 * sysdep.c: Include allocator.h, careadlinkat.h.
6915 (emacs_no_realloc_allocator): New static constant.
6916 (emacs_readlink): New function.
fdb61804
PE
6917 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6918 ../lib/careadlinkat.h.
d1fdcab7 6919
f84c17c7
SM
69202011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6921
6922 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6923 first non-nil return value).
6924
ef3862ad
JD
69252011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6926
6927 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6928 if not defined (Bug#8403).
6929
376a7006
JB
69302011-04-02 Juanma Barranquero <lekktu@gmail.com>
6931
6932 * xdisp.c (display_count_lines): Remove parameter `start',
6933 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6934 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6935 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6936 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6937 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6938 and thereabouts. All callers changed.
6939 (get_per_char_metric): Remove parameter `f', unused since
6940 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6941
6ca3801d
JM
69422011-04-02 Jim Meyering <meyering@redhat.com>
6943
6944 do not dereference NULL upon failed strdup
6945 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6946 (ns_get_family): Likewise.
6947
d8e2b5ba
JB
69482011-04-02 Juanma Barranquero <lekktu@gmail.com>
6949
6950 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6951
8c74fcbd
JD
69522011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6953
6954 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6955 later (Bug#8403).
6956
7200d79c
SM
69572011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6958
03408648 6959 Add lexical binding.
7200d79c 6960
03408648
SM
6961 * window.c (Ftemp_output_buffer_show): New fun.
6962 (Fsave_window_excursion):
6963 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6964
6965 * lread.c (lisp_file_lexically_bound_p): New function.
6966 (Fload): Bind Qlexical_binding.
6967 (readevalloop): Remove `evalfun' arg.
6968 Bind Qinternal_interpreter_environment.
6969 (Feval_buffer): Bind Qlexical_binding.
6970 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6971 Mark as dynamic.
6972 (syms_of_lread): Declare `lexical-binding'.
6973
6974 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6975
6976 * keyboard.c (eval_dyn): New fun.
6977 (menu_item_eval_property): Use it.
ca105506
SM
6978
6979 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6980
03408648
SM
6981 * fns.c (concat, mapcar1): Accept byte-code-functions.
6982
6983 * eval.c (Fsetq): Handle lexical vars.
6984 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6985 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6986 (FletX, Flet): Obey lexical binding.
6987 (Fcommandp): Handle closures.
6988 (Feval): New `lexical' arg.
6989 (eval_sub): New function extracted from Feval. Use it almost
6990 everywhere where Feval was used. Look up vars in lexical env.
6991 Handle closures.
6992 (Ffunctionp): Move from subr.el.
6993 (Ffuncall): Handle closures.
6994 (apply_lambda): Remove `eval_flags'.
6995 (funcall_lambda): Handle closures and new byte-code-functions.
6996 (Fspecial_variable_p): New function.
6997 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6998 but without exporting it to Lisp.
23aba0ea 6999
23aba0ea 7000 * doc.c (Fdocumentation, store_function_docstring):
03408648 7001 * data.c (Finteractive_form): Handle closures.
23aba0ea 7002
03408648
SM
7003 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7004 interactive spec.
ba83908c 7005
04f2d78b
CB
7006 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7007 New byte-codes.
03408648
SM
7008 (exec_byte_code): New function extracted from Fbyte_code to handle new
7009 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7010
03408648 7011 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7012
03408648 7013 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7014
e2abce01
JB
70152011-03-31 Juanma Barranquero <lekktu@gmail.com>
7016
7017 * xdisp.c (redisplay_internal): Fix prototype.
7018
63696a73 70192011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7020
63696a73 7021 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7022 (try_scrolling): Use it when setting scroll_limit.
7023 Limit scrolling to 100 screen lines.
63696a73
EZ
7024 (redisplay_window): Even when falling back on "recentering",
7025 position point in the window according to scroll-conservatively,
7026 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7027
7028 (try_scrolling): When point is above the window, allow searching
7029 as far as scroll_max, or one screenful, to compute vertical
7030 distance from PT to the scroll margin position. This prevents
7031 try_scrolling from unnecessarily failing when
7032 scroll-conservatively is set to a value slightly larger than the
7033 window height. Clean up the case of PT below the margin at bottom
7034 of window: scroll_max can no longer be INT_MAX. When aggressive
7035 scrolling is in use, don't let point enter the opposite scroll
7036 margin as result of the scroll.
7037 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7038 threshold of 100 lines for never-recentering scrolling.
7039
e4cc2dfc
JB
70402011-03-31 Juanma Barranquero <lekktu@gmail.com>
7041
7042 * dispextern.h (move_it_by_lines):
7043 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7044 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7045 (message_log_check_duplicate): Remove parameters `prev_bol' and
7046 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7047 (redisplay_internal): Remove parameter `preserve_echo_area',
7048 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7049
7050 * indent.c (Fvertical_motion):
7051 * window.c (window_scroll_pixel_based, Frecenter):
7052 Don't pass `need_y_p' to `move_it_by_lines'.
7053
1c470562
SM
70542011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7055
44f230aa
SM
7056 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7057 steal a few bits to be more compact.
7058 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7059 Remove unneeded casts.
7060
1c470562
SM
7061 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7062
888adce9
ZK
70632011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7064
7065 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7066 binding" message (bug#7967).
7067
f838ed7b
PE
70682011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7069
77861b95
PE
7070 Fix more problems found by GCC 4.6.0's static checks.
7071
de6dbc14
PE
7072 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7073 Remove unused local var.
7074
f838ed7b
PE
7075 * editfns.c (Fmessage_box): Remove unused local var.
7076
792c7b2b
PE
7077 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7078 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7079 Omit unused local vars.
c499e557 7080 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7081 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7082 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7083 Omit unused local var.
7084
ba0165e1
PE
7085 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7086 Don't assume string length fits in int.
32ad8845 7087 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7088 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7089
3c59b4c9
PE
7090 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7091 instead of alloca (Bug#8344).
7092
a3eed478 7093 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7094 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7095
eb4d412d
PE
7096 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7097
1658b401
PE
7098 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7099 concerns.
7100
7101 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7102
7103 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7104
9a2c6e05
PE
7105 * keyboard.c (syms_of_keyboard): Use the same style as later
7106 in this function when indexing through an array. This also
7107 works around GCC bug 48267.
7108
03d0a109
PE
7109 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7110
44f730c8
PE
7111 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7112
fe75f926
PE
7113 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7114 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7115
ffa8c828
PE
7116 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7117 This avoids undefined behavior on integer overflow, and is a bit
7118 more convenient anyway since it is compared to a size_t variable.
7119
c5101a77
PE
7120 Variadic C functions now count arguments with size_t, not int.
7121 This avoids an unnecessary limitation on 64-bit machines, which
7122 caused (substring ...) to crash on large vectors (Bug#8344).
7123 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7124 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7125 All variadic functions and their callers changed accordingly.
c5101a77
PE
7126 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7127 * data.c (arith_driver, float_arith_driver): Likewise.
7128 * editfns.c (general_insert_function): Likewise.
7129 * eval.c (struct backtrace.nargs, interactive_p)
7130 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7131 (funcall_lambda, mark_backtrace): Likewise.
7132 * fns.c (concat): Likewise.
7133 * frame.c (x_set_frame_parameters): Likewise.
7134 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7135 0 if not found, not -1. All callers changed.
7136
dd3f25f7
PE
7137 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7138 (stack_copy_size): Now size_t, not int.
7139 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7140
461c2ab9
JB
71412011-03-28 Juanma Barranquero <lekktu@gmail.com>
7142
7143 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7144 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7145 All callers changed.
7146
7147 * lisp.h (multibyte_char_to_unibyte):
7148 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7149 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7150 * character.h (CHAR_TO_BYTE8):
7151 * cmds.c (internal_self_insert):
7152 * editfns.c (general_insert_function):
7153 * keymap.c (push_key_description):
7154 * search.c (Freplace_match):
7155 * xdisp.c (message_dolog, set_message_1): All callers changed.
7156
f6d62986
SM
71572011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7158
7159 * keyboard.c (safe_run_hook_funcall): New function.
7160 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7161 don't set the hook to nil, but remove the offending function instead.
7162 (Qcommand_hook_internal): Remove, unused.
7163 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7164 Vcommand_hook_internal.
7165
7166 * eval.c (enum run_hooks_condition): Remove.
7167 (funcall_nil, funcall_not): New functions.
7168 (run_hook_with_args): Call each function through a `funcall' argument.
7169 Remove `cond' argument, now redundant.
7170 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7171 (Frun_hook_with_args_until_failure): Adjust accordingly.
7172 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7173
1db5b1ad
JB
71742011-03-28 Juanma Barranquero <lekktu@gmail.com>
7175
7176 * dispextern.h (string_buffer_position): Remove declaration.
7177
7178 * print.c (strout): Remove parameter `multibyte', unused since
7179 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7180
7181 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7182 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7183 All callers changed.
7184
7185 * w32.c (_wsa_errlist): Use braces for struct initializers.
7186
7187 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7188 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7189 All callers changed.
7190 (string_buffer_position): Likewise. Also, make static (it's never
7191 used outside xdisp.c).
7192 (cursor_row_p): Remove parameter `w', unused since
7193 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7194 (decode_mode_spec): Remove parameter `precision', introduced during
7195 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7196 All callers changed.
7197
5ffb62aa
JD
71982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7199
7200 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7201
461c2ab9 72022011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7203
7204 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7205 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7206 (ns_update_auto_hide_menu_bar): New functions.
7207 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7208 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7209 ns_constrain_all_frames.
7210 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7211 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7212
5c380ffb
JD
72132011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7214
7215 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7216
9af30bdf
GM
72172011-03-27 Glenn Morris <rgm@gnu.org>
7218
7219 * syssignal.h: Replace RETSIGTYPE with void.
7220 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7221 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7222 Replace SIGTYPE with void everywhere.
7223 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7224 * s/template.h (SIGTYPE): Remove commented out definition.
7225
e2abce01
JB
72262011-03-26 Eli Zaretskii <eliz@gnu.org>
7227
7228 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7229 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7230
f868cd8a
JB
72312011-03-26 Juanma Barranquero <lekktu@gmail.com>
7232
59eb0929
JB
7233 * w32.c (read_unc_volume): Use parameter `henum', instead of
7234 global variable `wget_enum_handle'.
7235
7236 * keymap.c (describe_vector): Remove parameters `indices' and
7237 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7238 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7239
f868cd8a
JB
7240 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7241
7242 * keyboard.c (timer_check): Remove parameter `do_it_now',
7243 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7244 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7245 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7246
7247 * keyboard.c (read_char):
7248 * w32menu.c (w32_menu_display_help):
7249 * xmenu.c (show_help_event, menu_help_callback):
7250 Adjust calls to `show_help_echo'.
7251
7252 * gtkutil.c (xg_maybe_add_timer):
7253 * keyboard.c (readable_events):
7254 * process.c (wait_reading_process_output):
7255 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7256
7257 * insdel.c (adjust_markers_gap_motion):
7258 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7259 (gap_left, gap_right): Don't call it.
7260
2ecf6fdb
CY
72612011-03-25 Chong Yidong <cyd@stupidchicken.com>
7262
7263 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7264 incurred during fontification.
7265
6b1f9ba4
JB
72662011-03-25 Juanma Barranquero <lekktu@gmail.com>
7267
7268 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7269 (DEFVAR_PER_BUFFER): Don't pass it.
7270
7271 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7272 (scrolling_window): Don't pass it.
7273
0f4a96b5
JB
72742011-03-25 Juanma Barranquero <lekktu@gmail.com>
7275
7276 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7277
7278 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7279 and `suffix'.
7280 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7281 of variables specific to SELinux and computation of `encoded_absname'.
7282
7283 * image.c (XPutPixel): Remove unused variable `height'.
7284
7285 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7286
7287 * unexw32.c (get_section_info): Remove unused variable `section'.
7288
7289 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7290 (system_process_attributes): Remove unused variable `sess'.
7291 (sys_read): Remove unused variable `err'.
7292
7293 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7294 (w32_wnd_proc): Remove unused variable `isdead'.
7295 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7296 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7297 (x_create_tip_frame): Remove unused variable `tem'.
7298
7299 * w32inevt.c (w32_console_read_socket):
7300 Remove unused variable `no_events'.
7301
7302 * w32term.c (x_draw_composite_glyph_string_foreground):
7303 Remove unused variable `width'.
7304
1149507c
JB
73052011-03-24 Juanma Barranquero <lekktu@gmail.com>
7306
7307 * w32term.c (x_set_glyph_string_clipping):
7308 Don't pass uninitialized region to CombineRgn.
7309
9c88f339
JB
73102011-03-23 Juanma Barranquero <lekktu@gmail.com>
7311
7312 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7313 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7314 (Fx_close_connection): Remove unused variable `i'.
7315
7316 * w32font.c (w32font_draw): Return number of glyphs.
7317 (w32font_open_internal): Remove unused variable `i'.
7318 (w32font_driver): Add missing initializer.
7319
7320 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7321 (fill_in_menu): Remove unused variable `items_added'.
7322
7323 * w32term.c (last_mouse_press_frame): Remove static global variable.
7324 (w32_clip_to_row): Remove unused variable `f'.
7325 (x_delete_terminal): Remove unused variable `i'.
7326
7327 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7328 (NOTHING): Remove unused static global variable.
7329 (uniscribe_check_otf): Remove unused variable `table'.
7330 (uniscribe_font_driver): Add missing initializers.
7331
dee091a3
JD
73322011-03-23 Julien Danjou <julien@danjou.info>
7333
7334 * term.c (Fsuspend_tty, Fresume_tty):
7335 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7336 * window.c (temp_output_buffer_show):
7337 * insdel.c (signal_before_change):
7338 * frame.c (Fhandle_switch_frame):
7339 * fileio.c (Fdo_auto_save):
7340 * emacs.c (Fkill_emacs):
7341 * editfns.c (save_excursion_restore):
7342 * cmds.c (internal_self_insert):
7343 * callint.c (Fcall_interactively):
7344 * buffer.c (Fkill_all_local_variables):
7345 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7346 Use Frun_hooks.
0f4a96b5 7347 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7348 unconditionnaly since it does the check itself.
7349
2c520ab5 73502011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7351
c9c49752
PE
7352 Fix more problems found by GCC 4.5.2's static checks.
7353
8abc3f12
PE
7354 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7355 the first time through the loop, since we know p0 < p1 then.
7356 This also avoids a gcc -Wstrict-overflow warning.
7357
a2d26660
PE
7358 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7359 leading to a memory leak, possible in functions like
7360 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7361 of objects (Bug#8318).
a2d26660 7362
916c72e9
PE
7363 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7364 that could (at least in theory) be that large.
7365
19ab8a18
PE
7366 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7367 This is less likely to overflow, and avoids undefined behavior if
7368 overflow does occur. All callers changed. Use strtoul to scan
7369 for the unsigned long integer.
b7cbbd6f
PE
7370 (pint2hrstr): Simplify and tune code slightly.
7371 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7372
f0641eff
PE
7373 * scroll.c (do_scrolling): Work around GCC bug 48228.
7374 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7375
7f650bb9
PE
7376 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7377 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7378 (validate_x_resource_name): Simplify count usage.
7379 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7380
37dd57d1
PE
7381 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7382 fail (Bug#8306).
81e56e61 7383
699979fc 7384 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7385
401bf9b4
PE
7386 * process.c (Fmake_network_process): Use socklen_t, not int,
7387 where POSIX says socklen_t is required in portable programs.
7388 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7389 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7390 (Fmake_network_process, server_accept_connection):
7391 (wait_reading_process_output, read_process_output):
7392 Likewise.
7393
b93aacde
PE
7394 * process.c: Rename or move locals to avoid shadowing.
7395 (list_processes_1, Fmake_network_process):
7396 (read_process_output_error_handler, exec_sentinel_error_handler):
7397 Rename or move locals.
4dc343ee 7398 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7399 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7400 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7401 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7402 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7403
af8a867c 7404 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7405 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7406 Include tparam.h instead, since it declares them.
af8a867c
PE
7407 * cm.h (PC): Remove extern decl; tparam.h now does this.
7408 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7409 * terminfo.c: Include tparam.h, to check interfaces.
7410 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7411 (tparam): Adjust signature to match interface in tparam.h;
7412 this removes some undefined behavior. Check that outstring and len
7413 are zero, which they always are with Emacs.
7414 * tparam.h (PC, BC, UP): New extern decls.
7415
0248044d 7416 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7417 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7418
8ff096c1 7419 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7420 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7421 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7422 (ftfont_list): Remove unused local.
49eaafba
PE
7423 (get_adstyle_property, ftfont_pattern_entity):
7424 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7425 Rename locals to avoid shadowing.
8ff096c1 7426
e2be39f6
PE
7427 * xfont.c (xfont_list_family): Mark var as initialized.
7428
c9735e30
PE
7429 * xml.c (make_dom): Now static.
7430
8f5201ae
PE
7431 * composite.c (composition_compute_stop_pos): Rename local to
7432 avoid shadowing.
b246f932
PE
7433 (composition_reseat_it): Remove unused locals.
7434 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7435 (composition_update_it): Mark var as initialized.
11b61122
PE
7436 (find_automatic_composition): Mark vars as initialized,
7437 with a FIXME (Bug#8290).
8f5201ae 7438
760fbc2c
PE
7439 character.h: Rename locals to avoid shadowing.
7440 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7441 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7442 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7443 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7444 to avoid shadowing.
7445
ff08eb85
PE
7446 * textprop.c (property_change_between_p): Remove; unused.
7447
fc7bf025
PE
7448 * intervals.c (interval_start_pos): Now static.
7449
235d7abc
PE
7450 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7451
44f230aa
SM
7452 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7453 Rename locals to avoid shadowing.
3e7d6594 7454
50060332
PE
7455 * sound.c (wav_play, au_play, Fplay_sound_internal):
7456 Fix pointer signedness.
d01f234b 7457 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7458 (wav_play): Initialize a variable to 0, to prevent undefined
7459 behavior (Bug#8278).
50060332 7460
c4fc4e30
PE
7461 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7462
918436ed
PE
7463 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7464
c939f91b
PE
7465 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7466 clobbering (Bug#8298).
b9c7f648
PE
7467 * sysdep.c (sys_subshell): Likewise.
7468 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7469
6bd8c144
PE
7470 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7471 This should get cleaned up, so that child_setup has the
7472 same signature on all platforms.
7473
7710357c 7474 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7475 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7476
c59da222
CY
74772011-03-22 Chong Yidong <cyd@stupidchicken.com>
7478
7479 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7480 not to be necessary, and produces flickering.
7481
66b87493
GM
74822011-03-20 Glenn Morris <rgm@gnu.org>
7483
7484 * config.in: Remove file.
7485
45b6f6d5
JB
74862011-03-20 Juanma Barranquero <lekktu@gmail.com>
7487
7488 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7489 are now in src/globals.h.
7490 (syms_of_minibuf): Remove spurious & from previous change.
7491
3ec03f7e
LL
74922011-03-20 Leo <sdl.web@gmail.com>
7493
7494 * minibuf.c (completing-read-function): New variable.
7495 (completing-read-default): Rename from completing-read.
7496 (completing-read): Call completing-read-function.
7497
b14e3e21
CY
74982011-03-19 Juanma Barranquero <lekktu@gmail.com>
7499
7500 * xfaces.c (Fx_load_color_file):
7501 Read color file from absolute filename (bug#8250).
7502
f2b726e6
JB
75032011-03-19 Juanma Barranquero <lekktu@gmail.com>
7504
7505 * makefile.w32-in: Update dependencies.
7506
09f6ff02
EZ
75072011-03-17 Eli Zaretskii <eliz@gnu.org>
7508
7509 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7510
29a6015a
PE
75112011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7512
a3a6c54e
PE
7513 Fix more problems found by GCC 4.5.2's static checks.
7514
b766f867
PE
7515 * process.c (make_serial_process_unwind, send_process_trap):
7516 (sigchld_handler): Now static.
7517
be02381c
PE
7518 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7519 That way, the code declares only the vars that it needs.
7520 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7521 * s/cygwin.h (PTY_ITERATION): Likewise.
7522 * s/darwin.h (PTY_ITERATION): Likewise.
7523 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7524
57048744
PE
7525 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7526 * process.c (allocate_pty): Don't declare stb unless it's needed.
7527
7914961c 7528 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7529 (CONSTANTLIM): Remove; unused.
7530 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7531 Define only if needed.
7914961c 7532
b3967b18
PE
7533 * unexelf.c (unexec): Name an expression,
7534 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7535 Use a different way to cause a compilation error if anyone uses
7536 n rather than nn, a way that does not involve shadowing.
73366a00 7537 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7538
29a6015a
PE
7539 * deps.mk (unexalpha.o): Remove; unused.
7540
43cfc33e 7541 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7542 * unexec.h: New file.
ce701a33
PE
7543 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7544 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7545 Depend on unexec.h.
7546 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7547 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7548 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7549 Change as necessary to match prototype in unexec.h.
ce701a33 7550
01f44d5a
PE
7551 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7552 shadowing.
4f63c6bb 7553 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7554
a6670b0b
PE
7555 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7556 Rename locals to avoid shadowing.
7557
cef2010d 7558 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7559 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7560
d4d7173a
PE
7561 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7562
f08b802a
PE
7563 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7564 warning when compiling print.c.
7565
3ddb0639
PE
7566 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7567 instead of using an uninitialized var.
5ad03b97 7568 (font_sort_entities): Mark var as initialized.
3ddb0639 7569
170a2692
PE
7570 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7571
e663c700
PE
7572 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7573 pointers to constants.
89bc529a 7574 (font_parse_fcname): Remove unused vars.
7b81e2d0 7575 (font_delete_unmatched): Now static.
ea838e10 7576 (font_get_spec): Remove; unused.
13a547c6
PE
7577 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7578 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7579 Rename or move locals to avoid shadowing.
e663c700 7580
2a80c887 7581 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7582 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7583
1384fa33 7584 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7585 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7586
8b2c52e9
PE
7587 * alloc.c (mark_backtrace): Move decl from here ...
7588 * lisp.h: ... to here, so that it can be checked.
7589
475545b5 7590 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7591 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7592 (lisp_indirect_variable): Name an expression,
7593 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7594 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7595
b1349114 7596 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7597 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7598 Use const pointer when appropriate.
b1349114 7599
a2928364
PE
7600 * lisp.h (get_system_name, get_operating_system_release):
7601 Move decls here, to check interfaces.
7602 * process.c (get_operating_system_release): Move decl to lisp.h.
7603 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7604 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7605 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7606 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7607 (Fformat_time_string, Fencode_time, Finsert_char):
7608 (Ftranslate_region_internal, Fformat):
7609 Rename or remove local vars to avoid shadowing.
9710023e 7610 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7611
a415e694
PE
7612 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7613 avoid shadowing.
7614
8ef4622d
PE
7615 * lisp.h (eassert): Check that the argument compiles, even if
7616 ENABLE_CHECKING is not defined.
7617
946f9a5b
PE
7618 * data.c (Findirect_variable): Name an expression, to avoid
7619 gcc -Wbad-function-cast warning.
112396d6 7620 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7621 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7622 (Fmake_variable_buffer_local, Fmake_local_variable):
7623 Mark variables as initialized.
52746918 7624 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7625
e5aab7e7 7626 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7627 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7628 Rename locals to avoid shadowing.
dff45157
PE
7629 (mark_stack): Move local variables into the #ifdef region where
7630 they're used.
7bc26fdb
PE
7631 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7632 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7633 needed otherwise.
7634 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7635 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7636 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7637
e5aab7e7
PE
7638 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7639 avoids undefined behavior in theory.
7640
4da60324
PE
7641 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7642
88043301
PE
7643 Use functions, not macros, for up- and down-casing (Bug#8254).
7644 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7645 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7646 to use the following functions instead of these macros.
7647 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7648 EMACS_INT, since callers assume the returned value fits in int.
7649 (upcase1): Likewise, for UPCASE_TABLE.
7650 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7651 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7652 the race-condition problem in the old DOWNCASE.
88043301 7653
19ed5445
PE
7654 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7655 Rename locals to avoid shadowing.
7656 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7657 (regex_compile, re_search_2, re_match_2_internal):
7658 Remove unused local vars.
952db0d7
PE
7659 (FREE_VAR): Rewrite so as not to use empty "else",
7660 which gcc can warn about.
da053e48 7661 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7662 (RETALLOC_IF): Define only if needed.
7663 (WORDCHAR_P): Likewise. This one is never needed, but is used
7664 only in a comment talking about a compiler bug, so put inside
7665 the #if 0 of that comment.
7666 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7667 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7668 Remove; unused.
19ed5445 7669
1f3561e4 7670 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7671 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7672 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7673
ded6f8f7
PE
7674 * search.c (simple_search): Remove unused var.
7675
dbd37a95
PE
7676 * dired.c (compile_pattern): Move decl from here ...
7677 * lisp.h: ... to here, so that it can be checked.
7678 (struct re_registers): New forward decl.
7679
7e47afad
PE
7680 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7681
85f24f61
PE
7682 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7683 All uses changed.
7684 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7685 Rename locals to avoid shadowing.
5671df8f 7686 (Fvertical_motion): Mark locals as initialized.
85f24f61 7687
181aa2be 7688 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7689 (casify_region): Mark local as initialized.
181aa2be 7690
930d429c
PE
7691 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7692
7082eac6
PE
7693 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7694 New macros, so that the caller can use some names other than
7695 gcpro1, gcpro2, etc.
7696 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7697 of the new macros.
7698 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7699 argument, for consistency with GCPRO2_VAR, etc: it is now the
7700 prefix of the variable, not the variable itself. All uses
7701 changed.
38b2c076
PE
7702 * dired.c (directory_files_internal, file_name_completion):
7703 Rename locals to avoid shadowing.
7704
15206ed9
PE
7705 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7706 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7707 dired.c's scmp function, had undefined behavior.
7708 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7709 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7710 * buffer.h: ... to here, because these macros use current_buffer,
7711 and the new implementation with inline functions needs to have
7712 current_buffer in scope now, rather than later when the macros
7713 are used.
7714 (downcase, upcase1): New static inline functions.
7715 (DOWNCASE, UPCASE1): Reimplement using these functions.
7716 This avoids undefined behavior in expressions like
7717 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7718 from race conditions in accessing the global variables
7719 case_temp1 and case_temp2.
7720 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7721 * lisp.h (case_temp1, case_temp2): Remove their decls.
7722 * character.h (ASCII_CHAR_P): Move from here ...
7723 * lisp.h: ... to here, so that the inline functions mentioned
7724 above can use them.
7725
4a6bea26
PE
7726 * dired.c (directory_files_internal_unwind): Now static.
7727
f14b7e14
PE
7728 * fileio.c (file_name_as_directory, directory_file_name):
7729 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7730 Now static.
2893f146
PE
7731 (file_name_as_directory): Use const pointers when appropriate.
7732 (Fexpand_file_name): Likewise. In particular, newdir might
7733 point at constant storage, so make it a const pointer.
fd4ead52 7734 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7735 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7736 signedness issues.
f839df0c
PE
7737 (Fset_file_times, Finsert_file_contents, auto_save_error):
7738 Rename locals to avoid shadowing.
f14b7e14 7739
5716756e 7740 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7741 (Ftry_completion, Fall_completions): Rename or remove locals
7742 to avoid shadowing.
5716756e 7743
b4c3046a
PE
7744 * marker.c (bytepos_to_charpos): Remove; unused.
7745
b45db522
PE
7746 * lisp.h (verify_bytepos, count_markers): New decls,
7747 so that gcc does not warn that these functions aren't declared.
7748
85876d07
PE
7749 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7750 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7751 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7752 (copy_text): Remove unused local var.
85876d07 7753
03d78a21 7754 * filelock.c (within_one_second): Now static.
b3dd38ab 7755 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7756
5df8f01b
PE
7757 * buffer.c (fix_overlays_before): Mark locals as initialized.
7758 (fix_start_end_in_overlays): Likewise. This function should be
7759 simplified by using pointers-to-pointers, but that's a different
7760 matter.
b1d876f1 7761 (switch_to_buffer_1): Now static.
8f54f30a
PE
7762 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7763 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7764
a70072c9 7765 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7766 Fix pointer signedness issue.
edced198
PE
7767 (sys_subshell): Mark local as volatile if checking for lint,
7768 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7769 (MAXPATHLEN): Define only if needed.
a70072c9 7770
a0977c44
PE
7771 * process.c (serial_open, serial_configure): Move decls from here ...
7772 * systty.h: ... to here, so that they can be checked.
7773
a884fdcc
PE
7774 * fns.c (get_random, seed_random): Move extern decls from here ...
7775 * lisp.h: ... to here, so that they can be checked.
7776
604efe86 7777 * sysdep.c (reset_io): Now static.
b8950c94 7778 (wait_for_termination_signal): Remove; unused.
604efe86 7779
38fc62d9
PE
7780 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7781 (copy_keymap_item, append_key, push_text_char_description):
7782 Now static.
1004a21a 7783 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7784 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7785 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7786 (describe_map_tree):
7787 Rename locals to avoid shadowing.
38fc62d9 7788
2f2650da
PE
7789 * keyboard.c: Declare functions static if they are not used elsewhere.
7790 (echo_char, echo_dash, cmd_error, top_level_2):
7791 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7792 (read_char, kbd_buffer_get_event, make_lispy_position):
7793 (make_lispy_event, make_lispy_movement, apply_modifiers):
7794 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7795 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7796 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7797 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7798 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7799
a053e86c 7800 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7801 (mark_kboards): Move decl here ...
7802 * alloc.c (mark_kboards): ... from here.
a053e86c 7803
4752793e
PE
7804 * lisp.h (force_auto_save_soon): New decl.
7805
74f10ca7 7806 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7807 (DEFINE_DUMMY_FUNCTION): New macro.
7808 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7809 Use it.
c03cd23f
PE
7810 (main): Add casts to avoid warnings
7811 if GCC considers string literals to be constants.
74f10ca7 7812
022e70d4
PE
7813 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7814
59d6fe83
PE
7815 * dbusbind.c: Pointer signedness fixes.
7816 (xd_signature, xd_append_arg, xd_initialize):
7817 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7818 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7819 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7820 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7821
78320123
PE
7822 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7823 if GCC considers string literals to be constants.
49cebcca 7824 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7825
35ac2a97
SM
78262011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7827
fb103ca9
SM
7828 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7829 (print_preprocess, print_object): New macro to fix last change.
7830
35ac2a97
SM
7831 * print.c (print_preprocess): Don't forget font objects.
7832
62973b41
JB
78332011-03-16 Juanma Barranquero <lekktu@gmail.com>
7834
7835 * emacs.c (USAGE3): Doc fixes.
7836
0e48bb22
AS
78372011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7838
7839 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7840 structure.
7841
7684e57b
JB
78422011-03-14 Juanma Barranquero <lekktu@gmail.com>
7843
7844 * lisp.h (VWindow_system, Qfile_name_history):
7845 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7846 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7847 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7848
7849 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7850 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7851
7852 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7853 * w32console.c (detect_input_pending, read_input_pending)
7854 (encode_terminal_code):
7855 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7856 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7857 (w32_system_caret_y, Qfile_name_history):
7858 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7859 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7860 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7861 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7862 * w32proc.c (Qlocal, report_file_error):
7863 * w32term.c (Vwindow_system, updating_frame):
7864 * w32uniscribe.c (initialized, uniscribe_font_driver):
7865 Remove unneeded extern declarations.
7866
2aa46d6c
CY
78672011-03-14 Chong Yidong <cyd@stupidchicken.com>
7868
c96bbc66 7869 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7870
cffc6f3b
CY
78712011-03-13 Chong Yidong <cyd@stupidchicken.com>
7872
7873 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7874 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7875 These macros can no longer be used for assignment.
7876
44f230aa
SM
7877 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7878 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7879 (record_buffer_markers, fetch_buffer_markers): New functions for
7880 recording and fetching special buffer markers.
7881 (set_buffer_internal_1, set_buffer_temp): Use them.
7882
7883 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7884
7885 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7886
7887 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7888 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7889
7890 * xdisp.c (hscroll_window_tree):
7891 (reconsider_clip_changes): Use PT instead of BUF_PT.
7892
d251f04b
EZ
78932011-03-13 Eli Zaretskii <eliz@gnu.org>
7894
7895 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7896 $(EMACS_ROOT)/lib/intprops.h.
7897
f0c77cd1
PE
78982011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7899
3eca4629
PE
7900 Fix more problems found by GCC 4.5.2's static checks.
7901
7c86ee98
PE
7902 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7903 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7904 (xg_free_frame_widgets): Make it clear that a local variable is
7905 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7906 (gdk_window_get_screen): Make it clear that this macro is needed
7907 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7908 (int_gtk_range_get_value): New function, which avoids a diagnostic
7909 from gcc -Wbad-function-cast.
7910 (xg_set_toolkit_scroll_bar_thumb): Use it.
7911 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7912 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7913 (get_utf8_string, xg_get_file_with_chooser):
7914 Rename locals to avoid shadowing.
7915 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7916
41729b81
PE
7917 * xgselect.c (xg_select): Remove unused var.
7918
f0c77cd1
PE
7919 * image.c (four_corners_best): Mark locals as initialized.
7920 (gif_load): Initialize transparent_p to zero (Bug#8238).
7921 Mark another local as initialized.
ec6cf4c6 7922 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7923
ce0ad53d 7924 * image.c (clear_image_cache): Now static.
d5d5a617 7925 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7926 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7927 (x_edge_detection): Remove unnecessary cast that
7928 gcc -Wbad-function-cast diagnoses.
2037898d 7929 (gif_load): Fix pointer signedness.
6ae141d6
PE
7930 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7931 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7932
33383987 79332011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7934
d32df629
PE
7935 Improve quality of tests for time stamp overflow.
7936 For example, without this patch (encode-time 0 0 0 1 1
7937 1152921504606846976) returns the obviously-bogus value (-948597
7938 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7939 reports time overflow. See
7940 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7941 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7942 * editfns.c: Include limits.h and intprops.h.
7943 (TIME_T_MIN, TIME_T_MAX): New macros.
7944 (time_overflow): Move earlier, to before first use.
7945 (hi_time, lo_time): New functions, for an accurate test for
7946 out-of-range times.
7947 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7948 (Fget_internal_run_time): Don't assume time_t fits in int.
7949 (make_time): Use list2 instead of Fcons twice.
7950 (Fdecode_time): More accurate test for out-of-range times.
7951 (check_tm_member): New function.
7952 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7953 (lisp_time_argument): Don't rely on undefined left-shift and
7954 right-shift behavior when checking for time stamp overflow.
8be6f318 7955
fe31d94c
PE
7956 * editfns.c (time_overflow): New function, refactoring common code.
7957 (Fformat_time_string, Fdecode_time, Fencode_time):
7958 (Fcurrent_time_string): Use it.
7959
8be6f318
PE
7960 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7961 * dired.c (make_time): Move to ...
7962 * editfns.c (make_time): ... here.
7963 * systime.h: Note the move.
7964
09d9db2c 79652011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7966
126bc0dc
YM
7967 * fringe.c (update_window_fringes): Remove unused variables.
7968
c47cbdfd
YM
7969 * unexmacosx.c (copy_data_segment): Also copy __got section.
7970 (Bug#8223)
7971
7ac80be9
EZ
79722011-03-12 Eli Zaretskii <eliz@gnu.org>
7973
c96bbc66 7974 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7975 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7976 Constify `char *' arguments and their references according to
7977 prototypes in tparam.h.
7978
ecb0f94d 7979 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7980
7ac80be9
EZ
7981 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7982 Adapt all references accordingly.
7983
7984 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7985
ef1fd07e
TT
79862011-03-11 Tom Tromey <tromey@redhat.com>
7987
7988 * buffer.c (syms_of_buffer): Remove obsolete comment.
7989
7ef4b50c
EZ
79902011-03-11 Eli Zaretskii <eliz@gnu.org>
7991
7992 * termhooks.h (encode_terminal_code): Declare prototype.
7993
7994 * msdos.c (encode_terminal_code): Don't declare prototype.
7995
7996 * term.c (encode_terminal_code): Now external again, used by
7997 w32console.c and msdos.c.
7998
44f230aa
SM
7999 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8000 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8001
4b1ec863 80022011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8003
1714f52b 8004 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8005
4b1ec863
PE
8006 * fringe.c (update_window_fringes): Mark locals as initialized
8007 (Bug#8227).
8008 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8009
524c7aa6
PE
8010 * alloc.c (mark_fringe_data): Move decl from here ...
8011 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8012 to check its interface.
8013 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8014
a5c0af81 8015 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8016 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8017 (fontset_font): Mark local as initialized.
a9a06e0b 8018 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8019
b4716021
PE
8020 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8021
811e9bac 8022 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8023 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8024 (x_own_selection, Fx_disown_selection_internal): Rename locals
8025 to avoid shadowing.
8026 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8027
7e3ab302
PE
8028 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8029 so that the caller can use some name other than gcpro1.
8030 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8031 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8032 (Fx_backspace_delete_keys_p):
8033 Use them to avoid shadowing, and rename vars to avoid shadowing.
8034 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8035 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8036 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8037 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8038 Remove unused locals.
7e3ab302
PE
8039 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8040 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8041 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8042 macros.
f78faa98 8043
e2b13473
PE
8044 * xterm.h (x_mouse_leave): New decl.
8045
77f23912
PE
8046 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8047 Remove unused functions.
cdf4ba58
PE
8048 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8049 (x_calc_absolute_position): Now static.
7411c686 8050 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8051 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8052 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8053 unless they are used.
38d0b34a
PE
8054 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8055 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8056 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8057 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8058 (x_error_catcher, x_connection_closed, x_error_handler):
8059 (x_error_quitter, xembed_send_message, x_iconify_frame):
8060 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8061 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8062 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8063
44f230aa
SM
8064 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8065 Rename or move locals to avoid shadowing.
6b463e58 8066 (tty_defined_color, merge_face_heights): Now static.
5967d051 8067 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8068 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8069 does not deduce is never used uninitialized.
73719eba
PE
8070 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8071 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8072
426994c3 8073 * terminal.c (store_terminal_param): Now static.
5489860b 8074
032f1620 8075 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8076 (set_frame_menubar): Remove unused local.
d4323972 8077 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8078 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8079 since they might point to immutable storage.
281585b0
PE
8080 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8081 since it's unused otherwise.
032f1620 8082
367c19e5 8083 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8084 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8085 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8086 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8087 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8088 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8089 does not deduce are never used uninitialized.
70739cbe 8090
07b48fa9
PE
8091 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8092
8868a238 8093 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8094 * window.c (window_loop, size_window):
8095 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8096
7e5cf297 8097 * window.c (display_buffer): Now static.
d6550a9f
PE
8098 (size_window): Mark variables that gcc -Wuninitialized
8099 does not deduce are never used uninitialized.
a586633d
PE
8100 * window.h (check_all_windows): New decl, to forestall
8101 gcc -Wmissing-prototypes diagnostic.
5b555da1 8102 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8103
f6095868
PE
8104 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8105 shadowing.
8106 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8107 Include <limits.h>.
8108 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8109 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8110 (load_charset_map): Mark variables that gcc -Wuninitialized
8111 does not deduce are never used uninitialized.
53df7c11 8112 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8113
f38b440c
PE
8114 * coding.c (coding_set_source, coding_set_destination):
8115 Use "else { /* comment */ }" rather than "else /* comment */;"
8116 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8117 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8118 a block, when the outer 'i' will do.
8119 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8120 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8121 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8122 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8123 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8124 Rename locals to avoid shadowing.
8125 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8126 * coding.c (emacs_mule_char, encode_invocation_designation):
8127 Now static, since they're not used elsewhere.
413bb2db 8128 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8129 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8130 (decode_coding_emacs_mule): Mark variables that gcc
8131 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8132 (detect_coding_iso_2022): Initialize a local variable that might
8133 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8134 this initialization is needed. (Bug#8211)
5f58e762
PE
8135 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8136 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8137 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8138 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8139 Remove unused macros.
f38b440c 8140
232b38b9 8141 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8142 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8143 * character.c (string_count_byte8): Likewise.
232b38b9 8144
fb90da1b
PE
8145 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8146 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8147
fb93dbc2
PE
8148 * chartab.c (copy_sub_char_table): Now static, since it's not used
8149 elsewhere.
5c156ace
PE
8150 (sub_char_table_ref_and_range, char_table_ref_and_range):
8151 Rename locals to avoid shadowing.
bbcd0949 8152 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8153
7d3b3862 8154 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8155 (BIDI_BOB): Remove unused macro.
7d3b3862 8156
6be7d3da
PE
8157 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8158 deduce are never used uninitialized.
c2ed9c8b 8159 * term.c (encode_terminal_code): Likewise.
6be7d3da 8160
75f8807f 8161 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8162
50938595
PE
8163 * tparam.h: New file.
8164 * term.c, tparam.h: Include it.
8165 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8166 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8167 Move these decls to tparam.h, and make them agree with what
8168 is actually in tparam.c. The previous trick of using incompatible
8169 decls in different modules does not conform to the C standard.
8170 All callers of tparam changed to use tparam's actual API.
8171 * tparam.c (tparam1, tparam, tgoto):
8172 Use const pointers where appropriate.
8173
fbceeba2
PE
8174 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8175 * cm.h (struct cm): Likewise.
8176 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8177 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8178 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8179 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8180 (turn_on_face, init_tty): Likewise.
8181 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8182
7f3f1250
PE
8183 * term.c (term_mouse_position): Rename local to avoid shadowing.
8184
e6ca6543
PE
8185 * alloc.c (mark_ttys): Move decl from here ...
8186 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8187
c40f8d15
AS
81882011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8189
8190 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8191
cfe0661d
JB
81922011-03-09 Juanma Barranquero <lekktu@gmail.com>
8193
8194 * search.c (compile_pattern_1): Remove argument regp, unused since
8195 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8196 (compile_pattern): Don't pass it.
8197
0afb4571
J
81982011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8199
8200 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8201 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8202 for ! HAVE_GTK3.
8203 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8204
8205 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8206
8207 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8208 gdk_window_get_screen, gdk_window_get_geometry,
8209 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8210 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8211 (xg_get_pixbuf_from_pixmap): New function.
8212 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8213 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8214 Call xg_get_pixbuf_from_pixmap instead of
8215 gdk_pixbuf_get_from_drawable.
8216 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8217 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8218 (xg_check_special_colors): Use GtkStyleContext and its functions
8219 for HAVE_GTK3.
8220 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8221 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8222 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8223 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8224 Call gtk_widget_get_preferred_size.
0afb4571
J
8225 (xg_frame_resized): gdk_window_get_geometry only takes 5
8226 parameters.
44f230aa
SM
8227 (xg_win_to_widget, xg_event_is_for_menubar):
8228 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8229 (xg_set_widget_bg): New function.
8230 (delete_cb): New function.
895009e1 8231 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8232 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8233 (xg_set_background_color): Call xg_set_widget_bg.
8234 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8235 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8236 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8237 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8238 if ! HAVE_GTK3.
8239 (update_frame_tool_bar): Call gtk_widget_hide.
8240 (xg_initialize): Use GDK_KEY_g.
8241
8242 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8243 if ! HAVE_GTK3
8244 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8245
8246 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8247 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8248 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8249
1c2cc4ef
JB
82502011-03-08 Juanma Barranquero <lekktu@gmail.com>
8251
8252 * w32xfns.c (select_palette): Check success of RealizePalette against
8253 GDI_ERROR, not zero.
8254
33383987 8255See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8256
8257;; Local Variables:
8258;; coding: utf-8
aac0c6e3
MR
8259;; End:
8260
33383987 8261 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8262
8263 This file is part of GNU Emacs.
8264
8265 GNU Emacs is free software: you can redistribute it and/or modify
8266 it under the terms of the GNU General Public License as published by
8267 the Free Software Foundation, either version 3 of the License, or
8268 (at your option) any later version.
8269
8270 GNU Emacs is distributed in the hope that it will be useful,
8271 but WITHOUT ANY WARRANTY; without even the implied warranty of
8272 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8273 GNU General Public License for more details.
8274
8275 You should have received a copy of the GNU General Public License
8276 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.